status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | apache/dubbo | https://github.com/apache/dubbo | 9,533 | ["dubbo-demo/dubbo-demo-triple/src/main/java/org/apache/dubbo/demo/GreeterService.java", "dubbo-demo/dubbo-demo-triple/src/main/java/org/apache/dubbo/demo/GreeterServiceImpl.java", "dubbo-demo/dubbo-demo-triple/src/main/java/org/apache/dubbo/demo/consumer/ApiConsumer.java", "dubbo-serialization/dubbo-serialization-api/src/main/java/org/apache/dubbo/common/serialize/DefaultMultipleSerialization.java"] | CompletableFuture Failed to deserialize response | <!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.5
* Operating System version: windows 11
* Java version: 1.8
### Steps to reproduce this issue
code repositorie：https://github.com/lmm1990/dubbo-completableFuture-bug
1. http://localhost:20003/demo/hello?name=mark
success
2. http://localhost:20003/demo/hello_async?name=mark
Failed to deserialize response
### Expected Behavior
http://localhost:20003/demo/hello_async?name=mark
need success
### Actual Behavior
Failed to deserialize response
If there is an exception, please attach the exception trace:
```
java.util.concurrent.CompletionException: org.apache.dubbo.remoting.RemotingException: Failed to deserialize response
at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:292)
at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:308)
at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:769)
at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:1977)
at org.apache.dubbo.rpc.protocol.dubbo.FutureAdapter.lambda$new$0(FutureAdapter.java:44)
at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)
at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736)
at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:1977)
at org.apache.dubbo.remoting.exchange.support.DefaultFuture2.doReceived(DefaultFuture2.java:191)
at org.apache.dubbo.remoting.exchange.support.DefaultFuture2.received(DefaultFuture2.java:139)
at org.apache.dubbo.remoting.exchange.support.DefaultFuture2.received(DefaultFuture2.java:128)
at org.apache.dubbo.rpc.protocol.tri.UnaryClientStream$ClientUnaryInboundTransportObserver.onError(UnaryClientStream.java:116)
at org.apache.dubbo.rpc.protocol.tri.UnaryClientStream$ClientUnaryInboundTransportObserver.lambda$onComplete$0(UnaryClientStream.java:95)
at org.apache.dubbo.common.threadpool.serial.SerializingExecutor.run(SerializingExecutor.java:99)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at org.apache.dubbo.common.threadlocal.InternalRunnable.run(InternalRunnable.java:41)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.dubbo.remoting.RemotingException: Failed to deserialize response
... 10 more
```
| https://github.com/apache/dubbo/issues/9533 | https://github.com/apache/dubbo/pull/9536 | 3caab028bc6b505d01e1e5423fc778f7dad6705c | e5f309a322b850db172e3f93eb657aa2ee013235 | 2022-01-06T07:53:23Z | java | 2022-01-23T08:58:52Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,466 | ["dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractClientStream.java", "dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractServerStream.java", "dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/AbstractStream.java", "dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/Metadata.java", "dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/UnaryServerStream.java", "dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/command/QueuedCommand.java", "dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/ClientStreamTest.java", "dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/ServerStreamTest.java", "dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocolTest.java", "dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/WriteQueueTest.java"] | [3.0]Triple protocol provider throw `ClosedChannelException` when invoke timeout | <!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.5-SNAPSHOT
### Steps to reproduce this issue
1. Start provider and consumer use `triple` protocol.
2. Consumer invoke timeout interface.
3. Provider throw `ClosedChannelException`
```
java.nio.channels.ClosedChannelException
at io.netty.handler.codec.http2.AbstractHttp2StreamChannel$Http2ChannelUnsafe.write(AbstractHttp2StreamChannel.java:916)
at io.netty.channel.DefaultChannelPipeline$HeadContext.write(DefaultChannelPipeline.java:1367)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:717)
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:709)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:792)
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:702)
at io.netty.channel.DefaultChannelPipeline.write(DefaultChannelPipeline.java:1015)
at io.netty.handler.codec.http2.AbstractHttp2StreamChannel.write(AbstractHttp2StreamChannel.java:480)
at org.apache.dubbo.rpc.protocol.tri.command.QueuedCommand$AbstractQueuedCommand.run(QueuedCommand.java:56)
at org.apache.dubbo.rpc.protocol.tri.WriteQueue.flush(WriteQueue.java:67)
at io.netty.util.concurrent.AbstractEventExecutor.safeExecute$$$capture(AbstractEventExecutor.java:164)
at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748)
[WARN][2021-12-22 15:40:12.099][NettyServerWorker-3-1][org.apache.dubbo.rpc.protocol.tri.ServerOutboundTransportObserver.lambda$onMetadata$0(ServerOutboundTransportObserver.java:42)ogger{50}] [DUBBO] send header error endStream=true, dubbo version: 3.0.5-SNAPSHOT, current host: 10.128.49.130
```
4. When invoke timeout client will close channel.
https://github.com/apache/dubbo/blob/0765b612cb89fa22a40c3043e955552c8e941160/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleClientRequestHandler.java#L57-L58
Pls. provide [GitHub address] to reproduce this issue.
### Expected Behavior
<!-- What do you expect from the above steps？-->
### Actual Behavior
<!-- What actually happens? -->
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/9466 | https://github.com/apache/dubbo/pull/9498 | ba878f67462817acf3c20cd1d1e178e2b4e6c917 | 0f4dc265c089b80dd31fe06e1ecd9c9902e75dd7 | 2021-12-22T07:48:47Z | java | 2022-01-17T03:16:55Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,440 | ["dubbo-demo/dubbo-demo-triple/pom.xml"] | Exception caught during async address migration. | ```java
org.apache.dubbo.demo.DemoService, dubbo version: 3.0.5-SNAPSHOT, current host: 172.18.0.5
2021-12-17T06:16:38.7893956Z [17/12/21 06:16:34:574 UTC] main INFO dubbo.LazyConnectExchangeClient: [DUBBO] Lazy connect to 172.18.0.3:20882?codec=dubbo&connect.lazy.initial.state=true&dubbo.endpoints=[{"port":20882,"protocol":"dubbo"}]&dubbo.metadata-service.url-params={"connections":"1","version":"1.0.0","dubbo":"2.0.2","release":"3.0.5-SNAPSHOT","port":"20882","protocol":"dubbo"}&dubbo.metadata.revision=2cf1513ca20917801747a48567aa0603&dubbo.metadata.storage-type=local&heartbeat=60000&send.reconnect=true&threadname=DubboClientHandler&threadpool=cached, dubbo version: 3.0.5-SNAPSHOT, current host: 172.18.0.5
2021-12-17T06:16:38.7897343Z Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 13.707 s <<< FAILURE! - in org.apache.dubbo.demo.consumer.DemoServiceIT
2021-12-17T06:16:38.7899032Z test(org.apache.dubbo.demo.consumer.DemoServiceIT) Time elapsed: 10.206 s <<< ERROR!
2021-12-17T06:16:38.7900260Z java.lang.IllegalArgumentException: Extension name == null
2021-12-17T06:16:38.7901902Z at org.apache.dubbo.common.extension.ExtensionLoader.hasExtension(ExtensionLoader.java:579)
2021-12-17T06:16:38.7904347Z at org.apache.dubbo.remoting.transport.AbstractEndpoint.getChannelCodec(AbstractEndpoint.java:52)
2021-12-17T06:16:38.7906597Z at org.apache.dubbo.remoting.transport.AbstractEndpoint.<init>(AbstractEndpoint.java:45)
2021-12-17T06:16:38.7908423Z at org.apache.dubbo.remoting.transport.AbstractClient.<init>(AbstractClient.java:54)
2021-12-17T06:16:38.7910230Z at org.apache.dubbo.remoting.transport.netty4.NettyClient.<init>(NettyClient.java:88)
2021-12-17T06:16:38.7912431Z at org.apache.dubbo.remoting.transport.netty4.NettyTransporter.connect(NettyTransporter.java:40)
2021-12-17T06:16:38.7914362Z at org.apache.dubbo.remoting.Transporter$Adaptive.connect(Transporter$Adaptive.java)
2021-12-17T06:16:38.7915785Z at org.apache.dubbo.remoting.Transporters.connect(Transporters.java:74)
2021-12-17T06:16:38.7917966Z at org.apache.dubbo.remoting.exchange.support.header.HeaderExchanger.connect(HeaderExchanger.java:39)
2021-12-17T06:16:38.7920270Z at org.apache.dubbo.remoting.exchange.Exchangers.connect(Exchangers.java:108)
2021-12-17T06:16:38.7922765Z at org.apache.dubbo.rpc.protocol.dubbo.LazyConnectExchangeClient.initClient(LazyConnectExchangeClient.java:84)
2021-12-17T06:16:38.7925793Z at org.apache.dubbo.rpc.protocol.dubbo.LazyConnectExchangeClient.request(LazyConnectExchangeClient.java:128)
2021-12-17T06:16:38.7928832Z at org.apache.dubbo.rpc.protocol.dubbo.ReferenceCountExchangeClient.request(ReferenceCountExchangeClient.java:95)
2021-12-17T06:16:38.7931436Z at org.apache.dubbo.rpc.protocol.dubbo.DubboInvoker.doInvoke(DubboInvoker.java:111)
2021-12-17T06:16:38.7933613Z at org.apache.dubbo.rpc.protocol.AbstractInvoker.doInvokeAndReturn(AbstractInvoker.java:215)
2021-12-17T06:16:38.7935673Z at org.apache.dubbo.rpc.protocol.AbstractInvoker.invoke(AbstractInvoker.java:176)
2021-12-17T06:16:38.7937726Z at org.apache.dubbo.rpc.listener.ListenerInvokerWrapper.invoke(ListenerInvokerWrapper.java:78)
2021-12-17T06:16:38.7940536Z at org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker.invokeWithContext(AbstractClusterInvoker.java:364)
2021-12-17T06:16:38.7943555Z at org.apache.dubbo.rpc.cluster.support.FailoverClusterInvoker.doInvoke(FailoverClusterInvoker.java:80)
2021-12-17T06:16:38.7946230Z at org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker.invoke(AbstractClusterInvoker.java:332)
2021-12-17T06:16:38.7948420Z at org.apache.dubbo.monitor.support.MonitorFilter.invoke(MonitorFilter.java:99)
2021-12-17T06:16:38.7950456Z at org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$FilterChainNode.invoke(FilterChainBuilder.java:84)
2021-12-17T06:16:38.7952646Z at org.apache.dubbo.rpc.protocol.dubbo.filter.FutureFilter.invoke(FutureFilter.java:51)
2021-12-17T06:16:38.7954870Z at org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$FilterChainNode.invoke(FilterChainBuilder.java:84)
2021-12-17T06:16:38.7957448Z at org.apache.dubbo.rpc.cluster.filter.support.ConsumerContextFilter.invoke(ConsumerContextFilter.java:109)
2021-12-17T06:16:38.7960042Z at org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$FilterChainNode.invoke(FilterChainBuilder.java:84)
2021-12-17T06:16:38.7962493Z at org.apache.dubbo.rpc.cluster.support.wrapper.AbstractCluster$ClusterFilterInvoker.invoke(AbstractCluster.java:92)
2021-12-17T06:16:38.7965155Z at org.apache.dubbo.rpc.cluster.support.wrapper.MockClusterInvoker.invoke(MockClusterInvoker.java:95)
2021-12-17T06:16:38.7967766Z at org.apache.dubbo.registry.client.migration.MigrationInvoker.invoke(MigrationInvoker.java:276)
2021-12-17T06:16:38.7970172Z at org.apache.dubbo.rpc.proxy.InvokerInvocationHandler.invoke(InvokerInvocationHandler.java:92)
2021-12-17T06:16:38.7972099Z at org.apache.dubbo.common.bytecode.proxy1.sayHello(proxy1.java)
2021-12-17T06:16:38.7973577Z at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2021-12-17T06:16:38.7975126Z at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2021-12-17T06:16:38.7977012Z at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2021-12-17T06:16:38.7978482Z at java.lang.reflect.Method.invoke(Method.java:498)
2021-12-17T06:16:38.7980290Z at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:333)
2021-12-17T06:16:38.7982753Z at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:207)
2021-12-17T06:16:38.7984207Z at com.sun.proxy.$Proxy27.sayHello(Unknown Source)
2021-12-17T06:16:38.7985622Z at org.apache.dubbo.demo.consumer.DemoServiceIT.testApplication(DemoServiceIT.java:86)
2021-12-17T06:16:38.7987532Z at org.apache.dubbo.demo.consumer.DemoServiceIT.test(DemoServiceIT.java:49)
2021-12-17T06:16:38.7989050Z at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2021-12-17T06:16:38.7990612Z at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2021-12-17T06:16:38.7992470Z at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2021-12-17T06:16:38.7993906Z at java.lang.reflect.Method.invoke(Method.java:498)
2021-12-17T06:16:38.7995097Z at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
2021-12-17T06:16:38.7996847Z at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
2021-12-17T06:16:38.7998862Z at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
2021-12-17T06:16:38.8000915Z at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
2021-12-17T06:16:38.8004156Z at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
2021-12-17T06:16:38.8008341Z at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
2021-12-17T06:16:38.8011777Z at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
2021-12-17T06:16:38.8013767Z at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
2021-12-17T06:16:38.8015910Z at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:252)
2021-12-17T06:16:38.8018969Z at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:94)
2021-12-17T06:16:38.8020991Z at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
2021-12-17T06:16:38.8022030Z at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
2021-12-17T06:16:38.8023245Z at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
2021-12-17T06:16:38.8024521Z at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
2021-12-17T06:16:38.8025663Z at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
2021-12-17T06:16:38.8028263Z at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
2021-12-17T06:16:38.8032393Z at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
2021-12-17T06:16:38.8034917Z at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
2021-12-17T06:16:38.8036858Z at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:191)
2021-12-17T06:16:38.8039170Z at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
2021-12-17T06:16:38.8041289Z at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
2021-12-17T06:16:38.8043626Z at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
2021-12-17T06:16:38.8045748Z at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
2021-12-17T06:16:38.8047395Z at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2021-12-17T06:16:38.8048930Z at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2021-12-17T06:16:38.8050802Z at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2021-12-17T06:16:38.8052263Z at java.lang.reflect.Method.invoke(Method.java:498)
2021-12-17T06:16:38.8054051Z at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:206)
2021-12-17T06:16:38.8056349Z at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:161)
2021-12-17T06:16:38.8058471Z at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:84)
2021-12-17T06:16:38.8061280Z at org.apache.dubbo.test.runner.ClassloaderSurefireStarter.runSuitesInProcess(ClassloaderSurefireStarter.java:78)
2021-12-17T06:16:38.8063703Z at org.apache.dubbo.test.runner.TestRunnerMain.main(TestRunnerMain.java:185)
2021-12-17T06:16:38.8064576Z
2021-12-17T06:16:38.8064782Z
2021-12-17T06:16:38.8065095Z Results:
2021-12-17T06:16:38.8065326Z
2021-12-17T06:16:38.8065630Z Errors:
2021-12-17T06:16:38.8067653Z DemoServiceIT.test:49->testApplication:86 » IllegalArgument Extension name == ...
2021-12-17T06:16:38.8068234Z
2021-12-17T06:16:38.8068647Z Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
2021-12-17T06:16:38.8068973Z
2021-12-17T06:16:38.8069635Z ------------------------------------------------------------------------
2021-12-17T06:16:38.8070276Z TEST FAILURE, Total: 1, Failures: 0, Errors: 1, Skipped: 0
``` | https://github.com/apache/dubbo/issues/9440 | https://github.com/apache/dubbo/pull/11281 | f3afca8eaef1b2be5cfeb843ecf29d5d7e180fda | f1cf9f21bfa07c823c8ec69fc76c020a23ef7b72 | 2021-12-17T11:55:46Z | java | 2023-01-11T23:52:35Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,435 | ["dubbo-demo/dubbo-demo-triple/pom.xml"] | dubbo-servicediscovery-migration example failed on Dubbo 3 | dubbo-servicediscovery-migration was failed on dubbo 3 branch recently.
https://github.com/apache/dubbo/runs/4530469700?check_suite_focus=true
https://github.com/apache/dubbo/runs/4556151932?check_suite_focus=true
https://github.com/apache/dubbo/runs/4549841354?check_suite_focus=true
```
Failed tests: 1
[1/30] [dubbo-servicediscovery-migration:1/1] TEST FAILURE: Run tests failed, version: -Ddubbo.version=3.0.5-SNAPSHOT -Dspring.version=4.3.30.RELEASE, please check logs: /home/runner/work/dubbo/dubbo/dubbo-samples-cloud-native/dubbo-servicediscovery-migration/target/logs
```
```
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 14.287 s <<< FAILURE! - in org.apache.dubbo.demo.consumer.DemoServiceIT
test(org.apache.dubbo.demo.consumer.DemoServiceIT) Time elapsed: 10.195 s <<< ERROR!
java.lang.IllegalArgumentException: Extension name == null
at org.apache.dubbo.common.extension.ExtensionLoader.hasExtension(ExtensionLoader.java:579)
at org.apache.dubbo.remoting.transport.AbstractEndpoint.getChannelCodec(AbstractEndpoint.java:52)
at org.apache.dubbo.remoting.transport.AbstractEndpoint.<init>(AbstractEndpoint.java:45)
at org.apache.dubbo.remoting.transport.AbstractClient.<init>(AbstractClient.java:54)
at org.apache.dubbo.remoting.transport.netty4.NettyClient.<init>(NettyClient.java:88)
at org.apache.dubbo.remoting.transport.netty4.NettyTransporter.connect(NettyTransporter.java:40)
at org.apache.dubbo.remoting.Transporter$Adaptive.connect(Transporter$Adaptive.java)
at org.apache.dubbo.remoting.Transporters.connect(Transporters.java:74)
at org.apache.dubbo.remoting.exchange.support.header.HeaderExchanger.connect(HeaderExchanger.java:39)
at org.apache.dubbo.remoting.exchange.Exchangers.connect(Exchangers.java:108)
at org.apache.dubbo.rpc.protocol.dubbo.LazyConnectExchangeClient.initClient(LazyConnectExchangeClient.java:84)
at org.apache.dubbo.rpc.protocol.dubbo.LazyConnectExchangeClient.request(LazyConnectExchangeClient.java:128)
at org.apache.dubbo.rpc.protocol.dubbo.ReferenceCountExchangeClient.request(ReferenceCountExchangeClient.java:95)
at org.apache.dubbo.rpc.protocol.dubbo.DubboInvoker.doInvoke(DubboInvoker.java:111)
at org.apache.dubbo.rpc.protocol.AbstractInvoker.doInvokeAndReturn(AbstractInvoker.java:215)
at org.apache.dubbo.rpc.protocol.AbstractInvoker.invoke(AbstractInvoker.java:176)
at org.apache.dubbo.rpc.listener.ListenerInvokerWrapper.invoke(ListenerInvokerWrapper.java:78)
at org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker.invokeWithContext(AbstractClusterInvoker.java:364)
at org.apache.dubbo.rpc.cluster.support.FailoverClusterInvoker.doInvoke(FailoverClusterInvoker.java:80)
at org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker.invoke(AbstractClusterInvoker.java:332)
at org.apache.dubbo.monitor.support.MonitorFilter.invoke(MonitorFilter.java:99)
at org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$FilterChainNode.invoke(FilterChainBuilder.java:84)
at org.apache.dubbo.rpc.protocol.dubbo.filter.FutureFilter.invoke(FutureFilter.java:51)
at org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$FilterChainNode.invoke(FilterChainBuilder.java:84)
at org.apache.dubbo.rpc.cluster.filter.support.ConsumerContextFilter.invoke(ConsumerContextFilter.java:109)
at org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$FilterChainNode.invoke(FilterChainBuilder.java:84)
at org.apache.dubbo.rpc.cluster.support.wrapper.AbstractCluster$ClusterFilterInvoker.invoke(AbstractCluster.java:92)
at org.apache.dubbo.rpc.cluster.support.wrapper.MockClusterInvoker.invoke(MockClusterInvoker.java:95)
at org.apache.dubbo.registry.client.migration.MigrationInvoker.invoke(MigrationInvoker.java:276)
at org.apache.dubbo.rpc.proxy.InvokerInvocationHandler.invoke(InvokerInvocationHandler.java:92)
at org.apache.dubbo.common.bytecode.proxy1.sayHello(proxy1.java)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:333)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:207)
at com.sun.proxy.$Proxy27.sayHello(Unknown Source)
at org.apache.dubbo.demo.consumer.DemoServiceIT.testApplication(DemoServiceIT.java:86)
at org.apache.dubbo.demo.consumer.DemoServiceIT.test(DemoServiceIT.java:49)
```
| https://github.com/apache/dubbo/issues/9435 | https://github.com/apache/dubbo/pull/11281 | f3afca8eaef1b2be5cfeb843ecf29d5d7e180fda | f1cf9f21bfa07c823c8ec69fc76c020a23ef7b72 | 2021-12-17T06:29:44Z | java | 2023-01-11T23:52:35Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,404 | ["dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/InstanceAddressURL.java", "dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/LazyConnectExchangeClient.java"] | The following log found during dubbo consumer shutdown | ```java
[14/12/21 15:14:33:695 CST] DubboShutdownHook WARN protocol.AbstractInvoker: [DUBBO] null, dubbo version: , current host: 30.225.12.132
java.lang.NullPointerException
at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
at org.apache.dubbo.metadata.MetadataInfo.getServiceInfo(MetadataInfo.java:178)
at org.apache.dubbo.registry.client.InstanceAddressURL.getPath(InstanceAddressURL.java:133)
at org.apache.dubbo.rpc.protocol.dubbo.LazyConnectExchangeClient.<init>(LazyConnectExchangeClient.java:65)
at org.apache.dubbo.rpc.protocol.dubbo.ReferenceCountExchangeClient.replaceWithLazyClient(ReferenceCountExchangeClient.java:216)
at org.apache.dubbo.rpc.protocol.dubbo.ReferenceCountExchangeClient.closeInternal(ReferenceCountExchangeClient.java:186)
at org.apache.dubbo.rpc.protocol.dubbo.ReferenceCountExchangeClient.close(ReferenceCountExchangeClient.java:163)
at org.apache.dubbo.rpc.protocol.dubbo.DubboInvoker.destroyInternal(DubboInvoker.java:174)
at org.apache.dubbo.rpc.protocol.dubbo.DubboInvoker.destroy(DubboInvoker.java:141)
at org.apache.dubbo.rpc.listener.ListenerInvokerWrapper.destroy(ListenerInvokerWrapper.java:89)
at org.apache.dubbo.rpc.Invoker.destroyAll(Invoker.java:50)
at org.apache.dubbo.registry.client.ServiceDiscoveryRegistryDirectory.destroyAllInvokers(ServiceDiscoveryRegistryDirectory.java:345)
at org.apache.dubbo.registry.integration.DynamicDirectory.destroy(DynamicDirectory.java:297)
at org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker.destroy(AbstractClusterInvoker.java:126)
at org.apache.dubbo.rpc.cluster.support.wrapper.MockClusterInvoker.destroy(MockClusterInvoker.java:80)
at org.apache.dubbo.registry.client.migration.MigrationInvoker.destroy(MigrationInvoker.java:316)
at org.apache.dubbo.rpc.proxy.InvokerInvocationHandler.invoke(InvokerInvocationHandler.java:72)
at org.apache.dubbo.common.bytecode.proxy3.$destroy(proxy3.java)
at org.apache.dubbo.config.utils.SimpleReferenceCache.destroyReference(SimpleReferenceCache.java:237)
at org.apache.dubbo.config.utils.SimpleReferenceCache.lambda$destroyAll$5(SimpleReferenceCache.java:227)
at java.util.concurrent.ConcurrentHashMap.forEach(ConcurrentHashMap.java:1597)
at org.apache.dubbo.config.utils.SimpleReferenceCache.destroyAll(SimpleReferenceCache.java:225)
at org.apache.dubbo.config.deploy.DefaultModuleDeployer.unreferServices(DefaultModuleDeployer.java:403)
at org.apache.dubbo.config.deploy.DefaultModuleDeployer.postDestroy(DefaultModuleDeployer.java:205)
at org.apache.dubbo.rpc.model.ModuleModel.onDestroy(ModuleModel.java:107)
at org.apache.dubbo.rpc.model.ScopeModel.destroy(ScopeModel.java:108)
at org.apache.dubbo.rpc.model.ApplicationModel.onDestroy(ApplicationModel.java:252)
at org.apache.dubbo.rpc.model.ScopeModel.destroy(ScopeModel.java:108)
at org.apache.dubbo.config.DubboShutdownHook.doDestroy(DubboShutdownHook.java:67)
at org.apache.dubbo.config.DubboShutdownHook.run(DubboShutdownHook.java:62)
``` | https://github.com/apache/dubbo/issues/9404 | https://github.com/apache/dubbo/pull/9409 | c271c686379b6b617f1c1c484730ceb1ef0479ef | dc8ba019dcf913c3e8294f4f6a340357eddab787 | 2021-12-14T07:15:33Z | java | 2021-12-15T06:20:37Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,339 | ["dubbo-serialization/dubbo-serialization-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/dubbo/DefaultHessian2FactoryInitializer.java", "dubbo-serialization/dubbo-serialization-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/dubbo/WhitelistHessian2FactoryInitializer.java"] | hessian 序列化如何不支持非Serializable 对象 | <!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
## Ask your question here
hessian 序列化如何不支持非Serializable 对象 | https://github.com/apache/dubbo/issues/9339 | https://github.com/apache/dubbo/pull/9340 | 43d46d9d9e5037b1c89c2a27734b33c01bb6eca5 | 72c8cbae076fb95a1cb4782eff8045c2cf605fdd | 2021-12-01T09:38:39Z | java | 2021-12-01T10:48:33Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,318 | ["dubbo-configcenter/dubbo-configcenter-apollo/src/main/java/org/apache/dubbo/configcenter/support/apollo/ApolloDynamicConfiguration.java"] | Apollo 配置中心 close 异常 | 
apollo 配置中心的 close 方法被注释，导致调用的时候直接调用接口的 default 方法，接口的默认实现是抛异常 | https://github.com/apache/dubbo/issues/9318 | https://github.com/apache/dubbo/pull/9321 | 06b34ddde4379915a502c92d779326851517205b | 58c54c3829ef685563dd121e85301a4b3a9cd841 | 2021-11-25T02:46:01Z | java | 2021-11-28T15:15:10Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,268 | ["dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/config/ZookeeperConfig.java"] | Start unit test zookeeper server failed in macOS | <!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.5
* Operating System version: macOS 10.15.4
* Java version: xxx
### Errors
1. Run unit test in `IDEA`
2. Error log
```
[13/11/21 18:19:38:924 CST] main INFO initializer.UnpackZookeeperInitializer: [DUBBO] The file has been unpacked, target path:/var/folders/rm/xplq6_5j1s19bxtv8s6vprj80000gp/T/dubbo-mocked-zookeeper/2181, dubbo version: , current host: 192.168.31.105
[13/11/21 18:19:38:932 CST] main INFO initializer.UnpackZookeeperInitializer: [DUBBO] The file has been unpacked, target path:/var/folders/rm/xplq6_5j1s19bxtv8s6vprj80000gp/T/dubbo-mocked-zookeeper/2182, dubbo version: , current host: 192.168.31.105
[13/11/21 18:19:40:247 CST] main INFO processor.StartZookeeperUnixProcessor: [DUBBO] The zookeeper-2181 is starting..., dubbo version: , current host: 192.168.31.105
ZooKeeper JMX enabled by default
Using config: /var/folders/rm/xplq6_5j1s19bxtv8s6vprj80000gp/T/dubbo-mocked-zookeeper/2181/apache-zookeeper-3.6.0-bin/conf/zoo.cfg
[13/11/21 18:25:35:286 CST] main INFO processor.StartZookeeperUnixProcessor: [DUBBO] The zookeeper-2182 is starting..., dubbo version: , current host: 192.168.31.105
ZooKeeper JMX enabled by default
Using config: /var/folders/rm/xplq6_5j1s19bxtv8s6vprj80000gp/T/dubbo-mocked-zookeeper/2182/apache-zookeeper-3.6.0-bin/conf/zoo.cfg
十一月 13, 2021 6:25:35 下午 org.junit.platform.launcher.core.TestExecutionListenerRegistry lambda$notifyEach$1
警告: TestExecutionListener [org.apache.dubbo.test.check.RegistryCenterStarted] threw exception for method: testPlanExecutionStarted(org.junit.platform.launcher.core.InternalTestPlan@7dda48d9)
java.lang.IllegalStateException: Failed to start zookeeper instance in unit test
at org.apache.dubbo.test.check.RegistryCenterStarted.testPlanExecutionStarted(RegistryCenterStarted.java:36)
at org.junit.platform.launcher.core.TestExecutionListenerRegistry$CompositeTestExecutionListener.lambda$testPlanExecutionStarted$12(TestExecutionListenerRegistry.java:115)
at org.junit.platform.launcher.core.TestExecutionListenerRegistry.lambda$notifyEach$1(TestExecutionListenerRegistry.java:67)
at java.util.ArrayList.forEach(ArrayList.java:1255)
at org.junit.platform.launcher.core.TestExecutionListenerRegistry.notifyEach(TestExecutionListenerRegistry.java:65)
at org.junit.platform.launcher.core.TestExecutionListenerRegistry.access$200(TestExecutionListenerRegistry.java:32)
at org.junit.platform.launcher.core.TestExecutionListenerRegistry$CompositeTestExecutionListener.testPlanExecutionStarted(TestExecutionListenerRegistry.java:115)
at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$5(DefaultLauncher.java:200)
at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:226)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:199)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:132)
at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:71)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
Caused by: org.apache.dubbo.test.check.exception.DubboTestException: Ready pattern not found in log, log:
Starting zookeeper ... already running as process 73031.
at org.apache.dubbo.test.check.registrycenter.processor.ZookeeperUnixProcessor.awaitProcessReady(ZookeeperUnixProcessor.java:83)
at org.apache.dubbo.test.check.registrycenter.processor.ZookeeperUnixProcessor.process(ZookeeperUnixProcessor.java:45)
at org.apache.dubbo.test.check.registrycenter.ZookeeperRegistryCenter.startup(ZookeeperRegistryCenter.java:151)
at org.apache.dubbo.test.check.registrycenter.GlobalRegistryCenter.startup(GlobalRegistryCenter.java:35)
at org.apache.dubbo.test.check.RegistryCenterStarted.testPlanExecutionStarted(RegistryCenterStarted.java:33)
... 14 more
```
2181/apache-zookeeper-bin/logs/zookeeper-xxx.log
```
"logs/zookeeper-gongdewei-server-mbp1649.local.out" 104L, 17640C
2021-11-13 19:48:22,772 [myid:] - INFO [main:DefaultSessionIdManager@333] - DefaultSessionIdManager workerName=node0
2021-11-13 19:48:22,772 [myid:] - INFO [main:DefaultSessionIdManager@338] - No SessionScavenger set, using defaults
2021-11-13 19:48:22,776 [myid:] - INFO [main:HouseKeeper@140] - node0 Scavenging every 600000ms
2021-11-13 19:48:22,786 [myid:] - INFO [main:ContextHandler@825] - Started o.e.j.s.ServletContextHandler@4d41cee{/,null,AVAILABLE}
2021-11-13 19:48:22,796 [myid:] - ERROR [main:ZooKeeperServerMain@85] - Unable to start AdminServer, exiting abnormally
org.apache.zookeeper.server.admin.AdminServer$AdminServerException: Problem starting AdminServer on address 0.0.0.0, port 8081 and command URL /commands
at org.apache.zookeeper.server.admin.JettyAdminServer.start(JettyAdminServer.java:176)
at org.apache.zookeeper.server.ZooKeeperServerMain.runFromConfig(ZooKeeperServerMain.java:153)
at org.apache.zookeeper.server.ZooKeeperServerMain.initializeAndRun(ZooKeeperServerMain.java:112)
at org.apache.zookeeper.server.ZooKeeperServerMain.main(ZooKeeperServerMain.java:67)
at org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:140)
at org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:90)
Caused by: java.io.IOException: Failed to bind to /0.0.0.0:8081
at org.eclipse.jetty.server.ServerConnector.openAcceptChannel(ServerConnector.java:346)
at org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:307)
at org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:80)
at org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:231)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
at org.eclipse.jetty.server.Server.doStart(Server.java:385)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
at org.apache.zookeeper.server.admin.JettyAdminServer.start(JettyAdminServer.java:167)
... 5 more
Caused by: java.net.BindException: Address already in use
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Net.java:444)
at sun.nio.ch.Net.bind(Net.java:436)
at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:225)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
at org.eclipse.jetty.server.ServerConnector.openAcceptChannel(ServerConnector.java:342)
... 12 more
Unable to start AdminServer, exiting abnormally
2021-11-13 19:48:22,800 [myid:] - INFO [main:ZKAuditProvider@42] - ZooKeeper audit is disabled.
2021-11-13 19:48:22,801 [myid:] - ERROR [main:ServiceUtils@42] - Exiting JVM with code 4
```
It seems port `8081` is already used by other process.
| https://github.com/apache/dubbo/issues/9268 | https://github.com/apache/dubbo/pull/9269 | fb569c4d99f1fb732e93247d8e6fbbc3d7e66c61 | a5f77c3566c59883c94ba2df55d949d435d111d0 | 2021-11-13T10:42:12Z | java | 2021-11-13T12:19:22Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,202 | ["dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java"] | NacosRegistry memory leak | <!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.14、3.0.4
### Steps to reproduce this issue
1. start dubbo admin (nacos registry)
The ```EventListener``` instance has created countless times by the scheduled task(```scheduledExecutorService```) and cached in the ```InstancesChangeNotifier#listenerMap```(Nacos) , until the memory is full.
- NacosRegistry
```
private void subscribeEventListener(String serviceName, final URL url, final NotifyListener listener)
throws NacosException {
EventListener eventListener = new RegistryChildListenerImpl(serviceName, url, listener);
namingService.subscribe(serviceName,
getUrl().getGroup(Constants.DEFAULT_GROUP),
eventListener);
}
```
- InstancesChangeNotifier
```
private final Map<String, ConcurrentHashSet<EventListener>> listenerMap = new ConcurrentHashMap<String, ConcurrentHashSet<EventListener>>();
public void registerListener(String serviceName, String clusters, EventListener listener) {
String key = ServiceInfo.getKey(serviceName, clusters);
ConcurrentHashSet<EventListener> eventListeners = listenerMap.get(key);
if (eventListeners == null) {
synchronized (lock) {
eventListeners = listenerMap.get(key);
if (eventListeners == null) {
eventListeners = new ConcurrentHashSet<EventListener>();
listenerMap.put(key, eventListeners);
}
}
}
eventListeners.add(listener);
}
```
The ```namingService.subscribe``` is finally called to the ```InstancesChangeNotifier#registerListener``` , so
eventListener cached in eventListeners.
| https://github.com/apache/dubbo/issues/9202 | https://github.com/apache/dubbo/pull/9261 | 0ae2ccc99c7a185ff873f6832ad22f99ed87b389 | f69c2f3c24793d809c71496f8517d13732364671 | 2021-11-03T14:33:01Z | java | 2021-11-18T12:30:34Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,190 | ["dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/metadata/MetadataUtils.java", "dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/metadata/StandardMetadataServiceURLBuilder.java", "dubbo-registry/dubbo-registry-api/src/test/java/org/apache/dubbo/registry/client/metadata/MetadataUtilsTest.java", "dubbo-registry/dubbo-registry-api/src/test/java/org/apache/dubbo/registry/client/metadata/StandardMetadataServiceURLBuilderTest.java"] | MetadataUtils.referProxy error | <!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.5
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
Frequent exceptions in unit testing:
```
[INFO] [02/11/21 06:31:32:300 UTC] ERROR listener.ServiceInstancesChangedListener: [DUBBO] Failed to load service metadata, meta type is local, dubbo version: 3.0.5-SNAPSHOT, current host: 172.28.16.1
[INFO] java.lang.IllegalStateException: There's no ApplicationConfig specified.
[INFO] at org.apache.dubbo.config.context.ConfigManager.lambda$getApplicationOrElseThrow$0(ConfigManager.java:85)
[INFO] at java.util.Optional.orElseThrow(Optional.java:290)
[INFO] at org.apache.dubbo.config.context.ConfigManager.getApplicationOrElseThrow(ConfigManager.java:85)
[INFO] at org.apache.dubbo.rpc.model.ApplicationModel.getCurrentConfig(ApplicationModel.java:315)
[INFO] at org.apache.dubbo.registry.client.metadata.StandardMetadataServiceURLBuilder.generateUrlWithoutMetadata(StandardMetadataServiceURLBuilder.java:112)
[INFO] at org.apache.dubbo.registry.client.metadata.StandardMetadataServiceURLBuilder.build(StandardMetadataServiceURLBuilder.java:82)
[INFO] at org.apache.dubbo.registry.client.metadata.MetadataUtils.referProxy(MetadataUtils.java:93)
[INFO] at org.apache.dubbo.registry.client.metadata.MetadataUtils.lambda$getMetadataServiceProxy$0(MetadataUtils.java:67)
[INFO] at java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1660)
[INFO] at org.apache.dubbo.registry.client.metadata.MetadataUtils.getMetadataServiceProxy(MetadataUtils.java:67)
[INFO] at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener.doGetMetadataInfo(ServiceInstancesChangedListener.java:379)
[INFO] at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener.getRemoteMetadata(ServiceInstancesChangedListener.java:330)
[INFO] at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener.onEvent(ServiceInstancesChangedListener.java:143)
[INFO] at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener$AddressRefreshRetryTask.run(ServiceInstancesChangedListener.java:493)
[INFO] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[INFO] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[INFO] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
[INFO] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
[INFO] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[INFO] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[INFO] at java.lang.Thread.run(Thread.java:748)
```
| https://github.com/apache/dubbo/issues/9190 | https://github.com/apache/dubbo/pull/9191 | efa6900bb1b59c70f131af868396a8903b098a18 | 59ab2da9e4e0009d65d847f3d2e5aea47cb2b34d | 2021-11-02T13:47:43Z | java | 2021-11-03T03:18:02Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,172 | ["dubbo-common/src/main/java/org/apache/dubbo/config/annotation/DubboReference.java", "dubbo-common/src/main/java/org/apache/dubbo/config/annotation/DubboService.java", "dubbo-common/src/main/java/org/apache/dubbo/config/context/ModuleConfigManager.java", "dubbo-common/src/test/java/org/apache/dubbo/config/context/ConfigManagerTest.java", "dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationPostProcessor.java", "dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/reference/ReferenceCreator.java", "dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/beans/factory/annotation/ReferenceCreatorTest.java", "dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/issues/issue9172/MultipleConsumerAndProviderTest.java", "dubbo-config/dubbo-config-spring/src/test/resources/META-INF/issues/issue9172/consumer.properties", "dubbo-config/dubbo-config-spring/src/test/resources/META-INF/issues/issue9172/provider.properties"] | @DubboReference(consumer = "xxx", lazy = true) 引用不到正确的consumer对象 | 在配置文件中配置多个consumer，可能@DubboReference引用不到正确consumer，永远只能取列表第一个consumer使用
server.port=8083
dubbo.application.name=rpc-two-consumer
dubbo.application.owner=com.test
dubbo.application.organization=test
dubbo.application.logger=slf4j
dubbo.application.compiler=javassist
dubbo.application.qosEnable=true
#RegistryConfig
dubbo.registries.registry-rpc-one.id=registry-rpc-one
dubbo.registries.registry-rpc-one.protocol=zookeeper
dubbo.registries.registry-rpc-one.client=curator
#两个不同集群的注册中心 其中一个
dubbo.registries.registry-rpc-one.address=localhost:2181
dubbo.registries.registry-rpc-one.group=dubbo/rpc-one-server
dubbo.consumers.consumer-rpc-one.registryIds=registry-rpc-one
dubbo.consumers.consumer-rpc-one.check=true
dubbo.consumers.consumer-rpc-one.timeout=15000
#dubbo.protocols.{protocol bean name}.id
dubbo.registries.registry-rpc-two.id=registry-rpc-two
dubbo.registries.registry-rpc-two.protocol=zookeeper
dubbo.registries.registry-rpc-two.client=curator
#两个不同集群的注册中心 其中一个
dubbo.registries.registry-rpc-two.address=localhost:2181
dubbo.registries.registry-rpc-two.group=dubbo/rpc-two-server
dubbo.consumers.consumer-rpc-two.registryIds=registry-rpc-two
dubbo.consumers.consumer-rpc-two.check=true
dubbo.consumers.consumer-rpc-two.timeout=15000
| https://github.com/apache/dubbo/issues/9172 | https://github.com/apache/dubbo/pull/9175 | c6e427987013e1b32f205e88cb9c60adb4f0f4b2 | 82735984389f4c8840db52a9f535bb683c87608f | 2021-11-01T03:19:42Z | java | 2021-11-04T09:01:05Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,156 | ["dubbo-demo/dubbo-demo-triple/pom.xml"] | dubbo2.7.13版本容器化部署时如何满足注册端口和绑定端口需要不一致的问题 | <!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
场景需求：
我在dubbo服务容器化时遇到一个问题。
**该容器化平台暂时只支持将宿主机的随机端口转发给容器的指定端口**。
比如dubbo provider进程在任意容器内启动后在容器内的端口需要是20880，而dubbo consumer访问容器内的dubbo provider需要通过宿主机的端口才能访问（容器拉起来的时候会随机分配一个端口，并将该端口映射容器的20880端口）。
问题：
我参考文档：https://github.com/apache/dubbo-samples/tree/b95ca08af9f207116ec70631559df4073fe4d75e/dubbo-samples-docker
使用DUBBO_PORT_TO_REGISTRY=宿主机的随机端口来实现，但是发现启动后容器内的dubbo provider的进程端口也变成了宿主机的随机端口，而非我指定的20880端口了。我当前使用的dubbo版本是2.7.13，查看源码里关于注册端口和绑定端口的逻辑（org.apache.dubbo.config.ServiceConfig.findConfigedPorts），发现从2.7.12开始注册端口和绑定端口被改成一致了，之前的版本允许注册端口和绑定端口不一致。
请问下2.7.12及以后的版本，如果需求上要求注册端口和绑定端口不一样，我该如果解决呢？
| https://github.com/apache/dubbo/issues/9156 | https://github.com/apache/dubbo/pull/11281 | f3afca8eaef1b2be5cfeb843ecf29d5d7e180fda | f1cf9f21bfa07c823c8ec69fc76c020a23ef7b72 | 2021-10-28T15:24:37Z | java | 2023-01-11T23:52:35Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,150 | ["dubbo-demo/dubbo-demo-triple/pom.xml"] | Filter SPI Auto Load | ExtensionLoader can not inject spring bean by type.
ex: when I customize Filter， I wanna inject spring boot Environment bean, then will delegate SpringExtensionFactory lookup with getOptionalBean, but getOptionalBean only can inject by type when parameter beanName is null.
### Environment
* Dubbo version: 2.7.8
* Operating System version: MacOS 11.6
* Java version: 1.8
### Expected Behavior
ExtensionLoader can inject spring bean by type.
Possible Solutions:
A: To annotate the setter method inject by type.
B: DubboBeanUtils#getOptionalBean by name, attempt to set null to beanName if not found !
### Actual Behavior
ExtensionLoader can not inject spring bean by type. | https://github.com/apache/dubbo/issues/9150 | https://github.com/apache/dubbo/pull/11281 | f3afca8eaef1b2be5cfeb843ecf29d5d7e180fda | f1cf9f21bfa07c823c8ec69fc76c020a23ef7b72 | 2021-10-28T02:42:49Z | java | 2023-01-11T23:52:35Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,130 | ["dubbo-spring-boot/dubbo-spring-boot-compatible/autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboListenerAutoConfiguration.java", "dubbo-spring-boot/dubbo-spring-boot-compatible/autoconfigure/src/main/resources/META-INF/spring.factories"] | dubbo3.0.4启动不打印版本信息了，是有开关吗？ | 3.0.4启动不打印版本信息了，是有开关吗？ | https://github.com/apache/dubbo/issues/9130 | https://github.com/apache/dubbo/pull/9192 | 502f565d3718b4bc36eee1a613b88650d6d1727f | 690d397f5e8da2968fe9fe65cd56e63aa81827d3 | 2021-10-26T01:44:21Z | java | 2021-11-04T09:02:39Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 9,049 | ["dubbo-registry/dubbo-registry-multiple/src/main/java/org/apache/dubbo/registry/multiple/MultipleServiceDiscovery.java"] | `MultipleServiceDiscovery ` can't support instance mode subscribe | <!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.3
* Operating System version: all
* Java version: all
### Steps to reproduce this issue
1. consumer config
`dubbo.registry.address=multiple://?reference-registry=zookeeper://127.0.0.1:2181,nacos://127.0.0.1:8848&child.zk=zookeeper://127.0.0.1:2181&child.nacos=nacos://127.0.0.1:8848`
If there is an exception, please attach the exception trace:
```
java.lang.UnsupportedOperationException: Current implementation does not support pagination query method.
at org.apache.dubbo.registry.client.ServiceDiscovery.getInstances(ServiceDiscovery.java:175) ~[dubbo-3.0.3.jar:3.0.3]
at org.apache.dubbo.registry.multiple.MultipleServiceDiscovery.getInstances(MultipleServiceDiscovery.java:119) ~[dubbo-3.0.3.jar:3.0.3]
at org.apache.dubbo.registry.client.ServiceDiscovery.getInstances(ServiceDiscovery.java:157) ~[dubbo-3.0.3.jar:3.0.3]
at org.apache.dubbo.registry.client.ServiceDiscovery.getInstances(ServiceDiscovery.java:130) ~[dubbo-3.0.3.jar:3.0.3]
at org.apache.dubbo.registry.client.ServiceDiscoveryRegistry.subscribeURLs(ServiceDiscoveryRegistry.java:302) ~[dubbo-3.0.3.jar:3.0.3]
at org.apache.dubbo.registry.client.ServiceDiscoveryRegistry$DefaultMappingListener.onEvent(ServiceDiscoveryRegistry.java:376) ~[dubbo-3.0.3.jar:3.0.3]
```
| https://github.com/apache/dubbo/issues/9049 | https://github.com/apache/dubbo/pull/9050 | 36f23a44dc570d7bc68b5e596d2d701119e4143a | 3df4f588b9084a33334d0b7822c18feeac5149cc | 2021-10-17T09:36:52Z | java | 2021-10-21T03:18:42Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,996 | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java"] | [3.0] ReferenceConfig的createInvokerForLocal构造StaticDirectory传入的列表类型是Collections.singletonList | ### Environment
* Dubbo version: 3.0
StaticDirectory.destroy方法最后要对列表做clear操作，但是ReferenceConfig的createInvokerForLocal构造StaticDirectory传入的列表类型是Collections.singletonList，执行clear就会抛异常：
```
[08/10/21 07:35:39:302 UTC] main WARN config.ReferenceConfig: [DUBBO] Unexpected error occurred when destroy invoker of ReferenceConfig(null)., dubbo version: 3.0.4-SNAPSHOT, current host: 172.19.112.1
java.lang.UnsupportedOperationException
at java.util.AbstractList.remove(AbstractList.java:161)
at java.util.AbstractList$Itr.remove(AbstractList.java:374)
at java.util.AbstractList.removeRange(AbstractList.java:571)
at java.util.AbstractList.clear(AbstractList.java:234)
at org.apache.dubbo.rpc.cluster.directory.StaticDirectory.destroy(StaticDirectory.java:91)
at org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker.destroy(AbstractClusterInvoker.java:113)
at org.apache.dubbo.rpc.cluster.support.wrapper.MockClusterInvoker.destroy(MockClusterInvoker.java:79)
at org.apache.dubbo.config.ReferenceConfig.destroy(ReferenceConfig.java:219)
``` | https://github.com/apache/dubbo/issues/8996 | https://github.com/apache/dubbo/pull/8997 | c261f7d19bc840c1a66661de79d78da25b24e87f | babd7b14b446c515519d6bf093e7fb14e3f2fc14 | 2021-10-09T01:40:50Z | java | 2021-10-09T08:03:27Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,980 | ["dubbo-registry/dubbo-registry-api/src/test/java/org/apache/dubbo/registry/support/FailbackRegistryTest.java"] | FailbackRegistryTest的testRecover方法的await问题 | ### Environment
* Dubbo version: 3.0 / master
3.0 github日志：
```
org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
at org.apache.dubbo.registry.support.FailbackRegistryTest.testRecover(FailbackRegistryTest.java:173)
```
173行代码为：```Assertions.assertEquals(0, mockRegistry.getFailedRegistered().size());```
原因：FailedRegisteredTask和FailedSubscribedTask的doRetry都是先执行doRegister或doSubscribe，再删掉failed task；但MockRegistry在doRegister和doSubscribe就做了latch.countDown()，所以latch.await()返回时机过早导致上述断言失败。 | https://github.com/apache/dubbo/issues/8980 | https://github.com/apache/dubbo/pull/8981 | 48c22fdb578c1ec2a3fb9d9aad3351d3a8e548d6 | 261a938c116f8b58dc47626d50f72757aca4ac18 | 2021-10-05T11:52:33Z | java | 2021-10-09T07:48:41Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,978 | ["dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/api/MultiplexProtocolConnectionManagerTest.java", "dubbo-remoting/dubbo-remoting-api/src/test/resources/META-INF/dubbo/internal/org.apache.dubbo.remoting.api.WireProtocol"] | [3.0] MultiplexProtocolConnectionManagerTest指令重排暴露的问题 | ### Environment
* Dubbo version: 3.0
github构建日志
```
[INFO] Running org.apache.dubbo.remoting.api.MultiplexProtocolConnectionManagerTest
Error: Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.046 s <<< FAILURE! - in org.apache.dubbo.remoting.api.MultiplexProtocolConnectionManagerTest
Error: testForEachConnection Time elapsed: 0.029 s <<< ERROR!
java.lang.IllegalStateException: No such extension org.apache.dubbo.remoting.api.WireProtocol by name tri, no related exception was found, please check whether related SPI module is missing.
at org.apache.dubbo.remoting.api.MultiplexProtocolConnectionManagerTest.testForEachConnection(MultiplexProtocolConnectionManagerTest.java:53)
```
测试方法代码:
```
public void testForEachConnection() throws RemotingException {
{
URL url = URL.valueOf("empty://127.0.0.1:8080?foo=bar");
Connection connect = connectionManager.connect(url);
}
{
URL url = URL.valueOf("tri://127.0.0.1:8080?foo=bar");
Connection connect = connectionManager.connect(url); <== throw IllegalStateException at line 53
}
Consumer<Connection> consumer = new Consumer<Connection>() {
@Override
public void accept(Connection connection) {
try {
Assertions.assertEquals("empty", connection.getUrl().getProtocol());
} catch (Exception e) {
Assertions.assertEquals("tri", connection.getUrl().getProtocol());
}
}
};
connectionManager.forEachConnection(consumer);
}
```
问题重现方法：
把创建两个Connection的代码块顺序颠倒一下，首先创建tri的connection。
分析原因：
指令重排导致tri的连接先行创建，但META-INF/dubbo/internal/org.apache.dubbo.remoting.api.WireProtocol文件里没有配置tri扩展。
其他问题：
1. 两个connection的url用了相同的地址（host和port相同），导致只会建一个Connection；
2. catch捕捉的类型错， 断言异常AssertionFailedError是Error类型，捕获Exception是捕获不到的 ;
3. 测试方法结束时两个connection都没有关闭，SingleProtocolConnectionManager全局对象里的connections没有清空，影响后续测试类，修复前两个问题会导致windows环境github构建失败（windows默认按字母顺序执行测试，SingleProtocolConnectionManagerTest在MultiplexProtocolConnectionManagerTest后面）。
另外有个涉及MultiplexProtocolConnectionManager的疑问：
MultiplexProtocolConnectionManager的createSingleProtocolConnectionManager方法虽然传入了protocol：
```
private ConnectionManager createSingleProtocolConnectionManager(String protocol) {
return frameworkModel.getExtensionLoader(ConnectionManager.class).getExtension("single");
}
```
但并没有用到这个protocol参数，返回的SingleProtocolConnectionManager都是同一个对象，这样MultiplexProtocolConnectionManager的connect方法往下面这个map里面放的ConnectionManager都是同一个SingleProtocolConnectionManager对象：
```
private final ConcurrentMap<String, ConnectionManager> protocols = new ConcurrentHashMap<>();
```
只有一个SingleProtocolConnectionManager为啥还要搞个map？MultiplexProtocolConnectionManager的forEachConnection方法遍历上面这个protocols，每个protocol都要搞一遍所有协议的全部连接，这样设计不太符合常理。 | https://github.com/apache/dubbo/issues/8978 | https://github.com/apache/dubbo/pull/8979 | d747177b71a04a280de5bc5f620170e60bc8abfa | d6085fab882df77cde72ec76988aed472fa652f3 | 2021-10-05T09:26:38Z | java | 2021-10-09T07:58:02Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,961 | ["dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/ConfigTest.java", "dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/ShutdownHookTest.java", "dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java"] | [3.0] The application level service discovery is not working in Triple Protocol (NPE problem) | Reproduce steps:
* Use Triple protocol in both consumer and provider,
* The provider works with `-Ddubbo.application.register-mode=instance`
* The consumer works with `-Ddubbo.application.service-discovery.migration=FORCE_APPLICATION`
Above test case will throw following errors:
```shell
[29/09/21 11:52:35:035 CST] NettyClientWorker-3-3 WARN channel.ChannelInitializer: Failed to initialize a channel. Closing: [id: 0xc1ba4a78]
java.lang.NullPointerException
at org.apache.dubbo.registry.client.InstanceAddressURL.getScopeModel(InstanceAddressURL.java:498)
at org.apache.dubbo.rpc.protocol.tri.TripleHttp2Protocol.configClientPipeline(TripleHttp2Protocol.java:76)
at org.apache.dubbo.remoting.api.Connection$1.initChannel(Connection.java:115)
at org.apache.dubbo.remoting.api.Connection$1.initChannel(Connection.java:102)
at io.netty.channel.ChannelInitializer.initChannel(ChannelInitializer.java:129)
at io.netty.channel.ChannelInitializer.handlerAdded(ChannelInitializer.java:112)
at io.netty.channel.AbstractChannelHandlerContext.callHandlerAdded(AbstractChannelHandlerContext.java:938)
at io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:609)
at io.netty.channel.DefaultChannelPipeline.access$100(DefaultChannelPipeline.java:46)
at io.netty.channel.DefaultChannelPipeline$PendingHandlerAddedTask.execute(DefaultChannelPipeline.java:1463)
at io.netty.channel.DefaultChannelPipeline.callHandlerAddedForAllHandlers(DefaultChannelPipeline.java:1115)
at io.netty.channel.DefaultChannelPipeline.invokeHandlerAddedIfNeeded(DefaultChannelPipeline.java:650)
at io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:502)
at io.netty.channel.AbstractChannel$AbstractUnsafe.access$200(AbstractChannel.java:417)
at io.netty.channel.AbstractChannel$AbstractUnsafe$1.run(AbstractChannel.java:474)
at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748)
``` | https://github.com/apache/dubbo/issues/8961 | https://github.com/apache/dubbo/pull/8984 | 7c2f52d4b59200a4a1f345c3718c4d95171e5848 | bb273ff86932de5cfb806a6c1b7a1ea5abe73c28 | 2021-09-29T15:54:48Z | java | 2021-10-09T03:00:25Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,940 | ["dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh/route/MeshRuleRouter.java", "dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/mesh/route/MeshRuleRouterTest.java"] | Instance registry mode can't use mesh route | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.3
### Steps to reproduce this issue
1. 启动 provider `-Ddubbo.application.register-mode=instance`
2. 启动 consumer `dubbo.application.service-discovery.migration=FORCE_APPLICATION`
3. 使用 `dubbo admin` 创建 mesh 路由
4. `org.apache.dubbo.registry.client.InstanceAddressURL#getParameters` 不能获取真正的 url 参数，导致路由规则匹配失败
5. 原因在于 `getProtocolServiceKey()` 方法是从`RpcContext`中获取，此时获取的`protocolServiceKey` 为 null，导致获取的为 instance 参数，实际需要获取对应服务的参数。
```
public Map<String, String> getParameters() {
String protocolServiceKey = getProtocolServiceKey();
if (StringUtils.isEmpty(protocolServiceKey)) {
return getInstance().getAllParams();
}
return getServiceParameters(protocolServiceKey);
}
```
```
public String getProtocolServiceKey() {
return RpcContext.getServiceContext().getProtocolServiceKey();
}
```
| https://github.com/apache/dubbo/issues/8940 | https://github.com/apache/dubbo/pull/8947 | fee0dbab0c255d79bfba50aaaafd5c7c33220bbb | f275c1b51abe29017cd7cc2bbd81859b34e3aa11 | 2021-09-27T15:49:44Z | java | 2021-09-30T02:14:15Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,845 | ["dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java"] | Consumer cannot get provider instance list updated using Zookeeper registry | - [*] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [*] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.10
* Operating System version: CentOS 7
* Java version: 1.8.0
### Expected Result
Consumer using Zookeeper registry can get provider instance list updated whenever a provider instance is registered or deregistered.
### Actual Result
Provider instance list is never updated when first call to doSubscribe failed with an exception.
thread dump below shows that zookeeper event thread is forever waiting on a `CountDownLatch`.
```
"main-EventThread" #109 daemon prio=5 os_prio=0 tid=0x00007f5d67934800 nid=0x95 waiting on condition [0x00007f5b41c5e000]
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0x00000005c73a9390> (a java.util.concurrent.CountDownLatch$Sync)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:997)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1304)
at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:231)
at org.apache.dubbo.registry.zookeeper.ZookeeperRegistry$RegistryChildListenerImpl.childChanged(ZookeeperRegistry.java:338)
at org.apache.dubbo.remoting.zookeeper.curator.CuratorZookeeperClient$CuratorWatcherImpl.process(CuratorZookeeperClient.java:294)
at org.apache.curator.framework.imps.NamespaceWatcher.process(NamespaceWatcher.java:83)
at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:531)
at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:506)
```
The CountDownLatch is used in `ZookeeperRegistry#doSubscribe()`, which may not be `countDown` if an exception is thrown, like below
```
...
Caused by: org.apache.dubbo.rpc.RpcException: Failed to subscribe consumer://172.17.0.5/..., cause: null
at org.apache.dubbo.registry.zookeeper.ZookeeperRegistry.doSubscribe(ZookeeperRegistry.java:186) ~[dubbo-2.7.10.jar!/:2.7.10]
at org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:299) ~[dubbo-2.7.10.jar!/:2.7.10]
... 33 more
Caused by: java.lang.IllegalStateException
at org.apache.dubbo.remoting.zookeeper.curator.CuratorZookeeperClient.addTargetChildListener(CuratorZookeeperClient.java:215) ~[dubbo-2.7.10.jar!/:2.7.10]
at org.apache.dubbo.remoting.zookeeper.curator.CuratorZookeeperClient.addTargetChildListener(CuratorZookeeperClient.java:53) ~[dubbo-2.7.10.jar!/:2.7.10]
at org.apache.dubbo.remoting.zookeeper.support.AbstractZookeeperClient.addChildListener(AbstractZookeeperClient.java:112) ~[dubbo-2.7.10.jar!/:2.7.10]
at org.apache.dubbo.registry.zookeeper.ZookeeperRegistry.doSubscribe(ZookeeperRegistry.java:176) ~[dubbo-2.7.10.jar!/:2.7.10]
at org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:299) ~[dubbo-2.7.10.jar!/:2.7.10]
... 33 more
Caused by: java.lang.InterruptedException
at java.lang.Object.wait(Native Method) ~[?:1.8.0_111]
at java.lang.Object.wait(Object.java:502) ~[?:1.8.0_111]
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1409) ~[zookeeper-3.4.11.jar!/:3.4.11-37e277162d567b55a07d1755f0b31c32e93c01a0]
at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1651) ~[zookeeper-3.4.11.jar!/:3.4.11-37e277162d567b55a07d1755f0b31c32e93c01a0]
at org.apache.curator.framework.imps.GetChildrenBuilderImpl$3.call(GetChildrenBuilderImpl.java:242) ~[curator-framework-4.0.1.jar!/:4.0.1]
at org.apache.curator.framework.imps.GetChildrenBuilderImpl$3.call(GetChildrenBuilderImpl.java:231) ~[curator-framework-4.0.1.jar!/:4.0.1]
at org.apache.curator.connection.StandardConnectionHandlingPolicy.callWithRetry(StandardConnectionHandlingPolicy.java:64) ~[curator-client-4.0.1.jar!/:?]
at org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:100) ~[curator-client-4.0.1.jar!/:?]
at org.apache.curator.framework.imps.GetChildrenBuilderImpl.pathInForeground(GetChildrenBuilderImpl.java:228) ~[curator-framework-4.0.1.jar!/:4.0.1]
at org.apache.curator.framework.imps.GetChildrenBuilderImpl.forPath(GetChildrenBuilderImpl.java:219) ~[curator-framework-4.0.1.jar!/:4.0.1]
at org.apache.curator.framework.imps.GetChildrenBuilderImpl.forPath(GetChildrenBuilderImpl.java:41) ~[curator-framework-4.0.1.jar!/:4.0.1]
at org.apache.dubbo.remoting.zookeeper.curator.CuratorZookeeperClient.addTargetChildListener(CuratorZookeeperClient.java:211) ~[dubbo-2.7.10.jar!/:2.7.10]
at org.apache.dubbo.remoting.zookeeper.curator.CuratorZookeeperClient.addTargetChildListener(CuratorZookeeperClient.java:53) ~[dubbo-2.7.10.jar!/:2.7.10]
at org.apache.dubbo.remoting.zookeeper.support.AbstractZookeeperClient.addChildListener(AbstractZookeeperClient.java:112) ~[dubbo-2.7.10.jar!/:2.7.10]
at org.apache.dubbo.registry.zookeeper.ZookeeperRegistry.doSubscribe(ZookeeperRegistry.java:176) ~[dubbo-2.7.10.jar!/:2.7.10]
at org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:299) ~[dubbo-2.7.10.jar!/:2.7.10]
... 33 more
```
| https://github.com/apache/dubbo/issues/8845 | https://github.com/apache/dubbo/pull/8878 | eb574aaf71b9db1d60a8755dd1e2f90b95e00058 | c4566a34ff1ab4432e234f637244a0d2a47ca9c6 | 2021-09-18T07:33:15Z | java | 2021-09-23T09:21:09Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,841 | ["dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java"] | When subscribing, the check configuration section is unavailable | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0
When the subscription is initiated, check is forcibly set to false, which should be determined by the upper-level configuration
For example：
Mandatory set the check value to false in ZookeeperRegistry
Expectation: If check is an interface-level service discovery, it can be configured for different interfaces. If it is an application-level service discovery, it can be configured for an application. | https://github.com/apache/dubbo/issues/8841 | https://github.com/apache/dubbo/pull/8879 | c4566a34ff1ab4432e234f637244a0d2a47ca9c6 | ab53b5a164d2ecc4b7ee48e4fcb185443cbd499d | 2021-09-18T02:54:32Z | java | 2021-09-23T09:22:53Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,811 | ["dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java"] | [3.0] 服务端超时DecodeableRpcResult.decode(Channel channel, InputStream input)抛NPE异常 | ### Environment
* Dubbo version: 3.0
### Steps to reproduce this issue
测试dubbo-samples项目的AnnotationServicesIT.testGreeting方法时，偶尔会出现服务端超时触发此异常。
手工触发方法：
修改AnnotationAction.java的greetingService服务引用对象的method超时注解，从3000改为1000（服务端代码里有2000毫秒sleep），然后运行就会遇到NPE：
```
java.lang.NullPointerException
at org.apache.dubbo.rpc.protocol.dubbo.DecodeableRpcResult.decode(DecodeableRpcResult.java:85)
```
DecodeableRpcResult 85行代码：```if (invocation.getServiceModel() != null) { ```
服务端超时，此处invocation为null。 | https://github.com/apache/dubbo/issues/8811 | https://github.com/apache/dubbo/pull/8812 | cf5eb3d3fbdcf54ac2a2709136b8ab7804ea1df4 | b9230c29113071a4cc4fb09cb516c90b1d360346 | 2021-09-15T13:15:52Z | java | 2021-09-20T15:11:13Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,793 | ["dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/DubboInfraBeanRegisterPostProcessor.java"] | 3.0.1和3.0.2版本下Consumer端Filter注入SpringBean失败场景分析 | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.1、3.0.2
* Operating System version: Mac OS
* Java version: 1.8
### Steps to reproduce this issue
1. 编写一个Filter和一个普通SpringBean
2. 装载Filter
3. 启动dubbo-demo-annotation-consumer(dubbo内置示例工程)
Filter和SpringBean代码如下。
@Activate(group = {"consumer", "provider"})
public class DemoFilter implements Filter {
private DemoServiceComponent demoServiceComponent;
private ABTestBean abTestBean;
public void setDemoServiceComponent(DemoServiceComponent demoServiceComponent) {
this.demoServiceComponent = demoServiceComponent;
}
public void setAbTestBean(ABTestBean abTestBean) {
this.abTestBean = abTestBean;
}
@Override
public Result invoke(Invoker<?> invoker, Invocation invocation) throws RpcException {
System.out.println("1");
return invoker.invoke(invocation);
}
}
@Service("abTestBean")
public class ABTestBean {
private String name = "1f2";
}
结果：启动后发现DemoFilter中的SpringBean无法注入。
经分析，IOC启动是通过DubboInfraBeanRegisterPostProcessor##setApplicationContex将上下文设置进SprinExtensionFactory#CONTEXTS属性中。
但是，在随后SpringExtensionFactory的初始化过程中又会调用SpringExtension#initialize，此处会清空当前的上下文
由于此处启动的是消费端，后面没有再次设置上下文进SpringExtensionFactory的地方，因此会导致Filter中相关的SpringBean注入不进去，结果如下所示。
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
期望后续能有一个好的解决方案，目前提供两个止血方案。
1. 使用SpringContext自行获取，参考如下：https://blog.csdn.net/sinat_21184471/article/details/81353431
2. 在DubboBootstrapApplicationListener#onContextRefreshedEvent中将上下文加入到SpringExtensionFactory(这只是暂时止血的方案，是否”优雅“有待讨论)
What do you expected from the above steps？
### Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/8793 | https://github.com/apache/dubbo/pull/9636 | cbce5f1f3832597f01a0edbf102b7060a0eb9d50 | c57d9452897ab41672c8a94066192a9ad5264368 | 2021-09-14T02:34:35Z | java | 2022-01-28T03:40:49Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,792 | ["dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/DubboInfraBeanRegisterPostProcessor.java"] | dubbo consumer 在注入spring bean时,无法注入相关的service | ### Environment
* Dubbo version: 3.0.2/3.0.2.1
* Operating System version: macos big sur 11.5
* Java version: 1.8
### Steps to reproduce this issue
1. 定义一个XXXFilter implements org.apache.dubbo.rpc.Filter
2. 在XXXFilter 里定义一个 属性 xxService(需要有一个实现xxService 并增加spring 的@Service注解)
3. 增加一个属性的set方法xxService
4. 启动消费者后,会发现XXXFilter中的xxService并未被实例化,还是null（同理提供者是正常的）
### 问题原因
最开始设置上下文的地方在DubboInfraBeanRegisterPostProcessor#setApplicationContex中，这里将上下文设置进SpringExtensionFactory。后面调用SpringExtensionFactory#initialize()就会清掉，而consumer端后面没有地方再设置（configCenter没配的情况下）
```
| https://github.com/apache/dubbo/issues/8792 | https://github.com/apache/dubbo/pull/9636 | cbce5f1f3832597f01a0edbf102b7060a0eb9d50 | c57d9452897ab41672c8a94066192a9ad5264368 | 2021-09-14T02:23:09Z | java | 2022-01-28T03:40:49Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,741 | ["dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/tag/TagStaticStateRouter.java"] | Dubbo service with tag cause no provider found issue |
### Environment
* Dubbo version: 3.0.2.1
* Operating System version: Linux 4.14.152-127.182.amzn2.x86_64
* Java version: 1.8_310
### Steps to reproduce this issue
1. A provider annotated with @DubboService(tag = 'XXX')
2. A Consumer annotated with @DubboReference(tag = 'XXX')
3. Consumer will complain no provider found
Possible Cause:
1. TagDynamicStateRouter#line 112 will hardcode tag as 'noTag' even the service has a valid tag but without tagRouterRule set
```
invocation.setAttachment(TAG_KEY, NO_TAG);
```
2. TagStaticStateRouter#64 try to locate the tag with below code, however the tag attachment already set as noTag from previous router, hence the tag is always noTag even the url has a valid tag set.
```
String tag = StringUtils.isEmpty(invocation.getAttachment(TAG_KEY)) ? url.getParameter(TAG_KEY) :
invocation.getAttachment(TAG_KEY);
if (StringUtils.isEmpty(tag)) {
tag = NO_TAG;
}
```
Possible Fix:
replace StringUtils.isEmpty as below function:
```
boolean isNoTag(String value) {
return StringUtils.isEmpty(value) || NO_TAG.equals(value));
}
``` | https://github.com/apache/dubbo/issues/8741 | https://github.com/apache/dubbo/pull/8763 | d5f44c256a4a22699cbd49db41aaf18a99fc4dc8 | 2c60b8ee630ad430a9c27a48700303f5a1a31f31 | 2021-09-09T07:49:21Z | java | 2021-09-12T12:10:31Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,733 | ["dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleClientHandler.java", "dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleInvoker.java"] | [3.0-Triple] Application service discovery had broken down because of consumerModel's NPE in TripleClientHandler | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
Because of TripleClientHandler working in a new thread, The line `url.getServiceMode` doesn't work in TripleClientHandler with InstanceAddressURL when we try to use application-service-discovery.
```java
// => org.apache.dubbo.rpc.protocol.tri.TripleClientHandler#writeRequest
private void writeRequest(ChannelHandlerContext ctx, final Request req, final ChannelPromise promise) {
final RpcInvocation inv = (RpcInvocation) req.getData();
final URL url = inv.getInvoker().getUrl();
// Here will throw NPE
ConsumerModel consumerModel = (ConsumerModel) url.getServiceModel();
// ......
}
```
See InstanceAddressURL:
```java
// => org.apache.dubbo.registry.client.InstanceAddressURL#getServiceModel
public ServiceModel getServiceModel() {
return RpcContext.getServiceContext().getConsumerUrl().getServiceModel();
}
// => org.apache.dubbo.rpc.RpcContext
private static final InternalThreadLocal<RpcServiceContext> SERVICE_CONTEXT = new InternalThreadLocal<RpcServiceContext>() {
@Override
protected RpcServiceContext initialValue() {
return new RpcServiceContext();
}
};
```
| https://github.com/apache/dubbo/issues/8733 | https://github.com/apache/dubbo/pull/8734 | 13a1e8b6649e2a8a34503bd96c99dc7efcd53d1e | 13c15fdc2e44f8426d711d558fcaf7737d74065b | 2021-09-08T16:22:15Z | java | 2021-09-09T04:20:38Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,722 | ["dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/metadata/MetadataServiceNameMapping.java"] | [3.0] the same service export multi protocol error | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.3-SNAPSHOT
* Operating System version: macos
* Java version: 1.8
### Steps to reproduce this issue
1. provider export multi protocol
```java
class ApiMigrationBothProvider {
public static void main(String[] args) {
ServiceConfig<IWrapperGreeter> service = new ServiceConfig<>();
service.setInterface(IWrapperGreeter.class);
service.setRef(new IGreeter2Impl());
DubboBootstrap bootstrap = DubboBootstrap.getInstance();
bootstrap.application(new ApplicationConfig("demo-migration-both-provider"))
.registry(new RegistryConfig(TriSampleConstants.ZK_ADDRESS))
.protocol(new ProtocolConfig(CommonConstants.TRIPLE, TriSampleConstants.SERVER_PORT))
.protocol(new ProtocolConfig(CommonConstants.DUBBO, TriSampleConstants.DEFAULT_DUBBO_PORT))
.service(service)
.start()
.await();
}
}
```
2. run provider
## reason
when the second protocol export, contains always true
Pls. provide [GitHub address] to reproduce this issue.
https://github.com/apache/dubbo-samples/pull/356
### Expected Result
everything is ok
### Actual Result
throw exception
If there is an exception, please attach the exception trace:
```
java.lang.RuntimeException
at org.apache.dubbo.registry.client.metadata.MetadataServiceNameMapping.map(MetadataServiceNameMapping.java:88)
at org.apache.dubbo.config.ServiceConfig.lambda$exported$1(ServiceConfig.java:270)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.apache.dubbo.config.ServiceConfig.exported(ServiceConfig.java:266)
at org.apache.dubbo.config.ServiceConfig.doExport(ServiceConfig.java:371)
at org.apache.dubbo.config.ServiceConfig.export(ServiceConfig.java:244)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.exportServices(DubboBootstrap.java:1476)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.doStart(DubboBootstrap.java:1190)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:1166)
at org.apache.dubbo.sample.tri.migration.ApiMigrationBothProvider.main(ApiMigrationBothProvider.java:44)
```
| https://github.com/apache/dubbo/issues/8722 | https://github.com/apache/dubbo/pull/8721 | 3a43fb927e4c10aacd7f9a32f41c56cfc0ceec47 | 6907dde34d1ce54683689f49e5db1f38a36f1560 | 2021-09-08T03:01:59Z | java | 2021-09-08T04:35:02Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,708 | ["dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java"] | Consumer is `admin` protocol nacos can't get real interface | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Steps to reproduce this issue
1. Subscribe service and consumer url is `admin://ip?category=providers,consumers,routers,configurators&check=false&classifier=*&enabled=*&group=*&interface=*&version=*`
2. `ServiceAddressURL#getServiceInterface` return consumerURL `*`
3. Zookeeper registry is normal.
4. Because zookeeper change consumer url interface and path nacos should be like this too.
https://github.com/apache/dubbo/blob/bdd253f8eeea0e256e2e037aa867b272de442625/dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java#L150
| https://github.com/apache/dubbo/issues/8708 | https://github.com/apache/dubbo/pull/8782 | 1702fa0abb2c9f421d88593b0c0f6206e1a86d6c | 082e632f512632074e6cab26f80089e8e8b03d01 | 2021-09-07T04:36:56Z | java | 2021-09-18T02:56:32Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,698 | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/metadata/ServiceInstanceHostPortCustomizer.java", "dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/metadata/ServiceInstanceHostPortCustomizerTest.java"] | [3.0] The logic of preferredProtocol was not user-friendly, we maybe should optimize it. | ## The logic of preferredProtocol was not user-friendly, we maybe should optimize it.
### What's the problem?
When we only use the `triple` protocol in dubbo with setting provider's register-mode as `instance`, the consumer can't find the service.
The source is in `org.apache.dubbo.config.metadata.ServiceInstanceHostPortCustomizer`, let's have a look:
```java
@Override
public void customize(ServiceInstance serviceInstance) {
String host = null;
int port = -1;
// ......
Set<URL> urls = writableMetadataService.getExportedServiceURLs();
if (CollectionUtils.isNotEmpty(urls)) {
ApplicationModel applicationModel = serviceInstance.getApplicationModel();
String preferredProtocol = applicationModel.getCurrentConfig().getProtocol();
// The default value of preferredProtocol is dubbo.
if (preferredProtocol != null) {
for (URL exportedURL : urls) {
// The protocol of exportedURL is tri
// because of tri != dubbo, the host and port will not be assigned values.
if (preferredProtocol.equals(exportedURL.getProtocol())) {
host = exportedURL.getHost();
port = exportedURL.getPort();
break;
}
}
} else {
URL url = urls.iterator().next();
host = url.getHost();
port = url.getPort();
}
// If not the port of instace > 0, the application instance will not be registered to RegistryCenter(like Nacos, Zookeeper).
// As a result, the consumer can't find the avaliabe providers when our settging is registry-mode=instance
if (serviceInstance instanceof DefaultServiceInstance) {
DefaultServiceInstance instance = (DefaultServiceInstance) serviceInstance;
instance.setHost(host);
instance.setPort(port);
}
}
}
```
For the moment, if you want both consumer and provider to force using `Application Discovery` in tri protocol, just change one line config of provider as follows:
```yaml
dubbo:
application:
metadata-type: remote
register-mode: instance
protocol: tri <==== HERE, set preferredProtocol as tri
```
### The possible solution
change the default `application-protocol` as `TRIPLE` in the future
> Why not now? Because most users are still trying to migrate from 2.0 to 3.0
```java
// => org.apache.dubbo.config.ApplicationConfig#checkDefault
protected void checkDefault() {
super.checkDefault();
if (protocol == null) {
protocol = DUBBO; // <======= HERE
}
// ......
}
```
In `ServiceInstanceHostPortCustomizer`, If the default protocol not exists, just try to get the first protocol and log an error log.
Related to #8666
Related to #8599 | https://github.com/apache/dubbo/issues/8698 | https://github.com/apache/dubbo/pull/8699 | 18799e51a9056a79aa8eeaee44db1dadeb1ddb86 | 0fe0321d96e6201043e7a5218d542fa77707f586 | 2021-09-06T13:54:51Z | java | 2021-09-08T03:02:46Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,681 | ["dubbo-common/src/main/java/org/apache/dubbo/rpc/model/ApplicationModel.java", "dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/ReferenceConfigTest.java", "dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java"] | github构建日志里有很多涉及RegistryProtocol的异常 | ### Environment
* Dubbo version: 3.0
### Steps to reproduce this issue
翻看github构建日志本来是去找GenericServiceTest为啥常常出现java.lang.IllegalStateException: Failed to check the status of the service org.apache.dubbo.config.spring.api.LocalMissClass的线索，相关的线索没找到，却找到了这个
2021-09-04T20:19:48.3933128Z [04/09/21 20:19:47:427 UTC] main WARN integration.RegistryProtocol: [DUBBO] unsubscribe listener == null, dubbo version: 3.0.3-SNAPSHOT, current host: 172.17.16.1
2021-09-04T20:19:48.3934495Z java.lang.IllegalArgumentException: unsubscribe listener == null
2021-09-04T20:19:48.3936385Z at org.apache.dubbo.registry.support.AbstractRegistry.unsubscribe(AbstractRegistry.java:329)
2021-09-04T20:19:48.3938947Z at org.apache.dubbo.registry.support.FailbackRegistry.unsubscribe(FailbackRegistry.java:328)
2021-09-04T20:19:48.3942540Z at org.apache.dubbo.registry.ListenerRegistryWrapper.unsubscribe(ListenerRegistryWrapper.java:134)
2021-09-04T20:19:48.3945186Z at org.apache.dubbo.registry.integration.RegistryProtocol$ExporterChangeableWrapper.unexport(RegistryProtocol.java:876)
2021-09-04T20:19:48.3948433Z at org.apache.dubbo.registry.integration.RegistryProtocol$DestroyableExporter.unexport(RegistryProtocol.java:669)
2021-09-04T20:19:48.3950662Z at org.apache.dubbo.config.ServiceConfig.unexport(ServiceConfig.java:187)
2021-09-04T20:19:48.3952706Z at org.apache.dubbo.config.bootstrap.DubboBootstrap.lambda$unexportServices$9(DubboBootstrap.java:1487)
2021-09-04T20:19:48.3954404Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
2021-09-04T20:19:48.3956255Z at org.apache.dubbo.config.bootstrap.DubboBootstrap.unexportServices(DubboBootstrap.java:1484)
2021-09-04T20:19:48.3958714Z at org.apache.dubbo.config.bootstrap.DubboBootstrap.destroy(DubboBootstrap.java:1635)
2021-09-04T20:19:48.3960885Z at org.apache.dubbo.config.bootstrap.DubboBootstrap.reset(DubboBootstrap.java:239)
2021-09-04T20:19:48.3963018Z at org.apache.dubbo.config.bootstrap.DubboBootstrap.reset(DubboBootstrap.java:225)
2021-09-04T20:19:48.3965492Z at org.apache.dubbo.config.spring.schema.GenericServiceTest.tearDown(GenericServiceTest.java:67)
并且不止这一个测试类抛这个异常，有十多个测试类都抛这个东西，看了看代码，感觉应该是重复注销导致的，RegistryProtocol注销listener前检查一下是否为null应该就能避免这个异常了。 | https://github.com/apache/dubbo/issues/8681 | https://github.com/apache/dubbo/pull/8768 | f29188797cb34343362762b4dd62c132c530f380 | 22dc29472c8919ba7c5d853c65600be106560519 | 2021-09-05T06:17:35Z | java | 2021-09-20T16:23:46Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,675 | ["dubbo-common/src/main/java/org/apache/dubbo/common/constants/RegistryConstants.java", "dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscoveryRegistryDirectory.java", "dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryDirectory.java"] | [3.0] ServiceDiscoveryRegistryDirectory的refreshInvoker方法和isAvailable存在并行执行冲突 | ### Environment
* Dubbo version: 3.0
集成构建时，执行GenericServiceTest测试方法下面的语句时，
```
// Test generic service without interface class locally
result = genericServiceWithoutInterfaceRef.$invoke("sayHello", new String[]{"java.lang.String"}, new Object[]{"generic"});
```
ReferenceConfig的checkInvokerAvailable方法有时会抛异常，导致集成构建失败，异常信息如下：
java.lang.IllegalStateException: Failed to check the status of the service org.apache.dubbo.config.spring.api.LocalMissClass. No provider available for the service org.apache.dubbo.config.spring.api.LocalMissClass from the url dubbo://10.1.0.184/org.apache.dubbo.config.spring.api.LocalMissClass?application=dubbo-generic-consumer&dubbo=2.0.2&file.cache=false&generic=true&init=false&interface=org.apache.dubbo.config.spring.api.LocalMissClass&metadata-type=remote&pid=9816®ister.ip=10.1.0.184&release=3.0.3-SNAPSHOT&side=consumer&sticky=false×tamp=1630699707283 to the consumer 10.1.0.184 use dubbo version 3.0.3-SNAPSHOT
at org.apache.dubbo.config.spring.schema.GenericServiceTest.testGeneric(GenericServiceTest.java:97)
* 更新2021-09-10：
执行ServiceDiscoveryRegistryDirectory的refreshInvoker方法刷新urlInvokerMap的线程和执行ReferenceConfig的init方法的线程不是一个线程，刷新的线程名是main-EventThread，执行init的线程是main线程。而refreshInvoker方法调用toInvokers时会先把当前的this.urlInvokerMap里面的entry全清，在将newUrlInvokerMap重新赋值给this.urlInvokerMap前，如果恰好遇到执行init的main线程在执行isAvailable判断就会因为this.urlInvokerMap没有entry而返回false。
重现方法：在ServiceDiscoveryRegistryDirectory的toInvokers方法调用返回的下一行代码设置断点，在isAvailable的Map<String, Invoker<T>> localUrlInvokerMap = urlInvokerMap处设置断点，执行到toInvokers返回时暂停main-EventThread线程执行，切换到停留在isAvailable的main线程继续执行，就能重现这个issue。
PS：
采用genericServiceWithoutInterface方式的JavaConfigReferenceBeanTest的testGenericServiceAnnotationBean方法的165行有时也抛异常
* 更新2021-09-10：这个RpcException异常可能是上一个测试方法执行AfterEach释放了全局资源干扰了仍在运行的dubbo后台线程导致的，已另开issue
```
Object sayHelloResult = genericServiceWithoutInterface.$invoke("sayHello", new String[]{"java.lang.String"}, new Object[]{"Dubbo"});
```
只是抛的异常是RpcException: Directory already destroyed
```
2021-09-03T18:39:04.9792146Z org.apache.dubbo.rpc.RpcException: Directory already destroyed .url: zookeeper://127.0.0.1:2181/org.apache.dubbo.registry.RegistryService?application=consumer-app&dubbo=2.0.2&file.cache=false&pid=8884&release=3.0.3-SNAPSHOT×tamp=1630694303313
2021-09-03T18:39:04.9797067Z at org.apache.dubbo.config.spring.reference.javaconfig.JavaConfigReferenceBeanTest.testGenericServiceAnnotationBean(JavaConfigReferenceBeanTest.java:165)
``` | https://github.com/apache/dubbo/issues/8675 | https://github.com/apache/dubbo/pull/8701 | aed194a9a71829be0beb4b23795bc0c024117bd9 | 47e4b813f096e8e0aed560396bb530ce5be6ff24 | 2021-09-04T04:15:07Z | java | 2021-09-21T16:08:04Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,614 | ["dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscoveryRegistry.java"] | telnet org.apache.dubbo.registry.client.ServiceDiscoveryRegistry cannot be cast to org.apache.dubbo.registry.support.AbstractRegistry | - [*] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [*] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.2.1
* Operating System version: Ubuntu20
* Java version: 1.8
### Steps to reproduce this issue
1. telnet localhost 22222
2. dubbo>ls service
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
list services
### Actual Result
```
ls service :fail to execute commandContext by org.apache.dubbo.registry.client.ServiceDiscoveryRegistry cannot be cast to org.apache.dubbo.registry.support.AbstractRegistry
```
| https://github.com/apache/dubbo/issues/8614 | https://github.com/apache/dubbo/pull/8619 | 6a79caffe59396acea7ebacecbc4388917065512 | 8e4d9f694ccf990b386b5feb7490e89fb2334268 | 2021-08-27T02:19:57Z | java | 2021-09-27T03:49:07Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,599 | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/metadata/ServiceInstanceHostPortCustomizer.java", "dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/metadata/ServiceInstanceHostPortCustomizerTest.java"] | triple不支持应用级地址发现 | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.x
* Operating System version: Ubuntu 18.04.5
* Java version: 11
* nacos version: 1.4.2
### Steps to reproduce this issue
1. provider配置
```
dubbo:
application:
metadata-type: remote
register-mode: instance
registry:
address: nacos://${nacos.host}:${nacos.port}
protocol:
name: tri
serialization: protobuf
```
2. consumer配置
```
dubbo:
application:
metadata-type: remote
service-discovery:
migration: APPLICATION_FIRST
registry:
address: nacos://${nacos.host}:${nacos.port}
# ?registry-type=${nacos.registry-type}
protocol:
name: tri
serialization: protobuf
```
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
### Actual Result
If there is an exception, please attach the exception trace:
java.lang.IllegalStateException: Failed to check the status of the service service.HelloService. No provider available for the service service.HelloService from the url dubbo://
| https://github.com/apache/dubbo/issues/8599 | https://github.com/apache/dubbo/pull/8699 | 18799e51a9056a79aa8eeaee44db1dadeb1ddb86 | 0fe0321d96e6201043e7a5218d542fa77707f586 | 2021-08-26T01:46:10Z | java | 2021-09-08T03:02:46Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,581 | ["dubbo-common/src/main/java/org/apache/dubbo/common/utils/NetUtils.java", "dubbo-common/src/test/java/org/apache/dubbo/common/utils/NetUtilsInterfaceDisplayNameHasMetaCharactersTest.java", "dubbo-common/src/test/java/org/apache/dubbo/common/utils/NetUtilsTest.java"] | [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境 | ### Environment
* Dubbo version: 2.7.13
### Steps to reproduce this issue
NetUtils.ignoreNetworkInterface方法使用matches判断是否是要忽略的网卡，
当网卡名称包含圆括号时，如INTEL(R) XXX
即使完全相同，结果也是false： ”INTEL(R) XXX".matches("INTEL(R) XXX" 结果为false！
比较了3.0的代码，该方法已经删除了DUBBO_NETWORK_IGNORED_INTERFACE相关的处理，建议2.7系列做一下同步修订。 | https://github.com/apache/dubbo/issues/8581 | https://github.com/apache/dubbo/pull/8723 | a09cece9d5cc8f9ce47629329a12d40cc244a62d | cfece5771a843015168cd71d2081bae620d85d18 | 2021-08-23T12:27:56Z | java | 2021-09-11T13:49:14Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,572 | ["dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java"] | Nacos Registry not support wildcard group with ServiceDiscovery enabled | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: xxx
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
1. xxx
2. xxx
3. xxx
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps？
### Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/8572 | https://github.com/apache/dubbo/pull/8573 | 24e4bd318b589ae7c39f05839f9a42ec801eef0d | bce96419f2d75e7d9b770067194a8e5fb14a5fbd | 2021-08-23T06:09:40Z | java | 2021-08-27T06:33:41Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,545 | ["dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh/route/MeshEnvListener.java", "dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh/route/MeshEnvListenerFactory.java", "dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/mesh/route/MeshRuleManager.java", "dubbo-distribution/dubbo-all/pom.xml", "dubbo-registry/dubbo-registry-kubernetes/src/main/java/org/apache/dubbo/registry/kubernetes/KubernetesMeshEnvListenerFactory.java", "dubbo-registry/dubbo-registry-kubernetes/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.cluster.router.mesh.route.MeshEnvListenerFactory"] | 3.0.2版本 k8s依赖不存在报错 | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: xxx
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps？
### Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/8545 | https://github.com/apache/dubbo/pull/8546 | b5f657e9a3baada81831b6dbace52dba99612d87 | 873937453b41374d58421f977b4eca5ee1ca4730 | 2021-08-19T09:27:23Z | java | 2021-08-19T11:00:55Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,527 | ["dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosNamingServiceWrapper.java", "dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosServiceDiscovery.java", "dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/util/NacosNamingServiceUtils.java"] | dubbo3.0.1升级dubbo3.0.2无法访问服务 | **注解中指定分组和在yaml中配置分组都无效**,导致指定了分组的无法访问
demo下载地址：https://wws.lanzoui.com/iE2BEsrb3nc
**dubbo3.0.1可以正常，升级到3.0.2无法访问，报下面的错。**
生产端：
消费端
nacos控制台：
| https://github.com/apache/dubbo/issues/8527 | https://github.com/apache/dubbo/pull/8533 | 2a5a3551d21f8940ae8312bc8804ff3e9686e027 | d94e6990aeca562b9cde0a34c0ce26bc8370893b | 2021-08-17T07:14:52Z | java | 2021-08-19T09:40:25Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,422 | ["dubbo-serialization/dubbo-serialization-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/dubbo/DefaultHessian2FactoryInitializer.java", "dubbo-serialization/dubbo-serialization-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/dubbo/WhitelistHessian2FactoryInitializer.java"] | [3.0] Invoke `MetadataService` serialization error. | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Steps to reproduce this issue
1. start provider and consumer
2. provider return `MetadataInfo`
3. consumer received `HashMap`
4. error
```
java.lang.ClassCastException: java.util.HashMap cannot be cast to org.apache.dubbo.metadata.MetadataInfo
at org.apache.dubbo.common.bytecode.proxy0.getMetadataInfo(proxy0.java)
at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener.doGetMetadataInfo(ServiceInstancesChangedListener.java:331)
at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener.getRemoteMetadata(ServiceInstancesChangedListener.java:285)
at org.apache.dubbo.registry.client.event.listener.ServiceInstancesChangedListener.onEvent(ServiceInstancesChangedListener.java:136)
at org.apache.dubbo.registry.nacos.NacosServiceDiscovery.handleEvent(NacosServiceDiscovery.java:143)
at org.apache.dubbo.registry.nacos.NacosServiceDiscovery.lambda$null$4(NacosServiceDiscovery.java:122)
```
5. It should be caused by the serialization whitelist. I removed this change and the call is normal. #8386
| https://github.com/apache/dubbo/issues/8422 | https://github.com/apache/dubbo/pull/8423 | 1832ff597758bcbb80de024ddde589fd36ec5865 | 100655a888e7f30ed41f0d16a20dcc80103e7e0f | 2021-08-05T08:12:21Z | java | 2021-08-05T11:04:18Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,383 | ["dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/InstanceAddressURL.java"] | [3.0] Token 认证调用失败 | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Steps to reproduce this issue
1. provider 开启认证 `dubbo.provider.token=true`
2. 调用异常
```
org.apache.dubbo.rpc.RpcException: Invalid token! Forbid invoke remote service interface org.test.apache.dubbo.interfaces.PeopleService method work() from consumer 192.168.1.3 to provider 192.168.1.3, consumer incorrect token is 54ff0e8d-e486-4986-823d-f028302d5fbb
```
### 原因
consumer 在获取token的时候，先获取 Instance 的 token ，如果没有再获取 interface 的 token.
`实例 token`
`接口 token`
`最终获取的 token 是实例的 token`
https://github.com/apache/dubbo/blob/6c8046aa43771ced3d725af4fb8e7455166fe9ea/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/InstanceAddressURL.java#L142-L148
| https://github.com/apache/dubbo/issues/8383 | https://github.com/apache/dubbo/pull/8385 | 84078a55fcf1b45cdb6a2dedd5af99ad39d4f3bc | 88313f04c87a77e3b1a414228cf8e5bdb9d5921e | 2021-07-31T12:46:39Z | java | 2021-08-01T02:59:31Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,408 | ["dubbo-dependencies-bom/pom.xml"] | 注册中心问题：如何定义注册到的注册中心上的dubbo server 名称 | 因为有些原因，没有办法使用公用的api模块暴露接口给consumer，只能在consumer内部自定义一个包路径和类名称一摸一样的接口，有没有办法自定义这个名称，因为我看注册到nacos上的名称都是 （包路径+类名+版本号）这种形式。 | https://github.com/apache/dubbo/issues/8408 | https://github.com/apache/dubbo/pull/10702 | 2ff4274cc914f61034e95931af0362e249247dc7 | ed01cc3aac37f6b4a5717a4e27a87fdfa78d5a5d | 2021-07-30T08:40:11Z | java | 2022-10-12T02:03:32Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,359 | ["dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/schema/DubboBeanDefinitionParser.java"] | Could not resolve placeholder 'dubbo.application' in value "${dubbo.application}"(dubbo 3.0+) | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.1
* Spring 5.3.9
* Java version: 1.8
### Steps to reproduce this issue
最近发现dubbo3.0已经发布好久了,而且也已经第三个版本了. 遂考虑将本地的dubbo-2.7.8升级到3.0.1, 可再项目启动的时候报
`Caused by: java.lang.IllegalArgumentException: Could not resolve placeholder 'dubbo.application' in value "${dubbo.application}"
at org.springframework.util.PropertyPlaceholderHelper.parseStringValue(PropertyPlaceholderHelper.java:174)
at org.springframework.util.PropertyPlaceholderHelper.replacePlaceholders(PropertyPlaceholderHelper.java:126)
at org.springframework.core.env.AbstractPropertyResolver.doResolvePlaceholders(AbstractPropertyResolver.java:236)
at org.springframework.core.env.AbstractPropertyResolver.resolveRequiredPlaceholders(AbstractPropertyResolver.java:210)
at org.springframework.core.env.AbstractEnvironment.resolveRequiredPlaceholders(AbstractEnvironment.java:572)
at org.apache.dubbo.config.spring.schema.DubboBeanDefinitionParser.resolvePlaceholders(DubboBeanDefinitionParser.java:519)
at org.apache.dubbo.config.spring.schema.DubboBeanDefinitionParser.parse(DubboBeanDefinitionParser.java:101)
at org.apache.dubbo.config.spring.schema.DubboBeanDefinitionParser.parse(DubboBeanDefinitionParser.java:505)
at org.springframework.beans.factory.xml.NamespaceHandlerSupport.parse(NamespaceHandlerSupport.java:74)
at org.apache.dubbo.config.spring.schema.DubboNamespaceHandler.parse(DubboNamespaceHandler.java:90)
at org.springframework.beans.factory.xml.BeanDefinitionParserDelegate.parseCustomElement(BeanDefinitionParserDelegate.java:1435)
at org.springframework.beans.factory.xml.BeanDefinitionParserDelegate.parseCustomElement(BeanDefinitionParserDelegate.java:1419)
at org.springframework.beans.factory.xml.DefaultBeanDefinitionDocumentReader.parseBeanDefinitions(DefaultBeanDefinitionDocumentReader.java:172)
at org.springframework.beans.factory.xml.DefaultBeanDefinitionDocumentReader.doRegisterBeanDefinitions(DefaultBeanDefinitionDocumentReader.java:142)
at org.springframework.beans.factory.xml.DefaultBeanDefinitionDocumentReader.registerBeanDefinitions(DefaultBeanDefinitionDocumentReader.java:94)
at org.springframework.beans.factory.xml.XmlBeanDefinitionReader.registerBeanDefinitions(XmlBeanDefinitionReader.java:508)
at org.springframework.beans.factory.xml.XmlBeanDefinitionReader.doLoadBeanDefinitions(XmlBeanDefinitionReader.java:392)`
将dubbo降到2.7.8又能正常启动, 有谁碰到这个问题没? 可以排除的问题:
1:key值拼写错误
2:本地自定义spring-*.xml中有多套PropertySources被初始化
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps？
### Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/8359 | https://github.com/apache/dubbo/pull/8368 | e5aaeffbe317b083e966235855c8e17e91efa759 | 6c8046aa43771ced3d725af4fb8e7455166fe9ea | 2021-07-27T08:35:19Z | java | 2021-07-30T06:42:14Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,323 | ["dubbo-dependencies-bom/pom.xml"] | How to disable telnet |
* Dubbo version: 2.7.x
| https://github.com/apache/dubbo/issues/8323 | https://github.com/apache/dubbo/pull/10702 | 2ff4274cc914f61034e95931af0362e249247dc7 | ed01cc3aac37f6b4a5717a4e27a87fdfa78d5a5d | 2021-07-20T06:23:03Z | java | 2022-10-12T02:03:32Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,301 | ["dubbo-dependencies-bom/pom.xml"] | Add integration testcase for testing ReferenceConfig and RegistryProtocol | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0
* Operating System version: Mac OS
* Java version: 1.8
### Steps to reproduce this issue
Add testcase to integrate `ReferenceConfig` and `RegistryProtocol#refer()`
| https://github.com/apache/dubbo/issues/8301 | https://github.com/apache/dubbo/pull/10702 | 2ff4274cc914f61034e95931af0362e249247dc7 | ed01cc3aac37f6b4a5717a4e27a87fdfa78d5a5d | 2021-07-15T15:46:38Z | java | 2022-10-12T02:03:32Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,249 | ["dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/MetadataInfo.java"] | Dubbo3.0 Metadata 泄漏 | 每次应用重启，都会在 /dubbo/metadata/${appName} 下生成一个版本号。经过调试，发现在每次计算 revison， 会连同 pid 和 timestamp 一起计算。这样是不是有问题呢？
| https://github.com/apache/dubbo/issues/8249 | https://github.com/apache/dubbo/pull/8376 | 6c8046aa43771ced3d725af4fb8e7455166fe9ea | 84078a55fcf1b45cdb6a2dedd5af99ad39d4f3bc | 2021-07-09T09:37:53Z | java | 2021-08-01T01:50:49Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,241 | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/metadata/ConfigurableMetadataServiceExporter.java"] | dubbo 3.0.1 dubbo.provider.delay参数设置后报空指针 | ### 问题
在测试新发布的3.0.1时，如果给dubbo.provider.delay指定值实现延迟暴露时，启动时会报空指针异常。
### 环境
* Dubbo version: 3.0.1
* Operating System version: win10
* Java version: 1.8.0_201
### 核心代码
1. maven 依赖文件
```
<properties>
<spring-boot.version>2.3.0.RELEASE</spring-boot.version>
<dubbo.version>3.0.1</dubbo.version>
<nacos-client.version>2.0.1</nacos-client.version>
<java.version>1.8</java.version>
</properties>
<dependencies>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-spring-boot-starter</artifactId>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo</artifactId>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-registry-nacos</artifactId>
</dependency>
<dependency>
<groupId>com.alibaba.nacos</groupId>
<artifactId>nacos-client</artifactId>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
</dependencies>
<dependencyManagement>
<dependencies>
<!-- Apache Dubbo -->
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-dependencies-bom</artifactId>
<version>${dubbo.version}</version>
<type>pom</type>
<scope>compile</scope>
</dependency>
<!-- Dubbo Registry Nacos -->
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-registry-nacos</artifactId>
<version>${dubbo.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.alibaba.nacos</groupId>
<artifactId>nacos-client</artifactId>
<version>${nacos-client.version}</version>
<scope>compile</scope>
</dependency>
<!-- Dubbo Spring Boot Starter -->
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-spring-boot-starter</artifactId>
<version>${dubbo.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo</artifactId>
<version>${dubbo.version}</version>
<scope>compile</scope>
</dependency>
</dependencies>
</dependencyManagement>
```
2. application.properties配置
```
dubbo.application.name=dubbo-provider
dubbo.registry.address=nacos://127.0.0.1:8848
dubbo.registry.check=false
dubbo.registry.username=nacos
dubbo.registry.password=nacos
dubbo.provider.delay=5000
dubbo.consumer.check=false
dubbo.metadata-report.address=nacos://127.0.0.1:8848
dubbo.metadata-report.username=nacos
dubbo.metadata-report.password=nacos
dubbo.protocol.name=dubbo
dubbo.protocol.port=20885
dubbo.protocol.threadpool=fixed
dubbo.protocol.threads=500
dubbo.version=1.0.0
```
3. 启动报空指针
>java.lang.NullPointerException: null
> at org.apache.dubbo.registry.client.metadata.ServiceInstanceMetadataUtils.getMetadataServiceParameter(ServiceInstanceMetadataUtils.java:115) ~[dubbo-3.0.1.jar:3.0.1]
> at org.apache.dubbo.registry.client.metadata.MetadataServiceURLParamsMetadataCustomizer.resolveMetadataPropertyValue(MetadataServiceURLParamsMetadataCustomizer.java:51) ~[dubbo-3.0.1.jar:3.0.1]
> at org.apache.dubbo.registry.client.metadata.MetadataServiceURLParamsMetadataCustomizer.customize(MetadataServiceURLParamsMetadataCustomizer.java:38) ~[dubbo-3.0.1.jar:3.0.1]
> at org.apache.dubbo.registry.client.metadata.ServiceInstanceMetadataUtils.lambda$customizeInstance$2(ServiceInstanceMetadataUtils.java:285) ~[dubbo-3.0.1.jar:3.0.1]
> at java.lang.Iterable.forEach(Iterable.java:75) ~[na:1.8.0_201]
> at org.apache.dubbo.registry.client.metadata.ServiceInstanceMetadataUtils.customizeInstance(ServiceInstanceMetadataUtils.java:283) ~[dubbo-3.0.1.jar:3.0.1]
> at org.apache.dubbo.config.bootstrap.DubboBootstrap.createServiceInstance(DubboBootstrap.java:1432) ~[dubbo-3.0.1.jar:3.0.1]
> at org.apache.dubbo.config.bootstrap.DubboBootstrap.registerServiceInstance(DubboBootstrap.java:1373) ~[dubbo-3.0.1.jar:3.0.1]
> at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:1103) ~[dubbo-3.0.1.jar:3.0.1]
> at org.apache.dubbo.config.spring.context.DubboBootstrapApplicationListener.onContextRefreshedEvent(DubboBootstrapApplicationListener.java:80) ~[dubbo-3.0.1.jar:3.0.1]
> at org.apache.dubbo.config.spring.context.DubboBootstrapApplicationListener.onApplicationContextEvent(DubboBootstrapApplicationListener.java:72) ~[dubbo-3.0.1.jar:3.0.1]
> at com.alibaba.spring.context.OnceApplicationContextEventListener.onApplicationEvent(OnceApplicationContextEventListener.java:52) ~[spring-context-support-1.0.8.jar:na]
> at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:176) ~[spring-context-5.3.5.jar:5.3.5]
> at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:169) ~[spring-context-5.3.5.jar:5.3.5]
> at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:143) ~[spring-context-5.3.5.jar:5.3.5]
> at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:421) ~[spring-context-5.3.5.jar:5.3.5]
> at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:378) ~[spring-context-5.3.5.jar:5.3.5]
> at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:938) ~[spring-context-5.3.5.jar:5.3.5]
> at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:586) ~[spring-context-5.3.5.jar:5.3.5]
> at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:144) ~[spring-boot-2.4.4.jar:2.4.4]
> at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:769) [spring-boot-2.4.4.jar:2.4.4]
> at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:761) [spring-boot-2.4.4.jar:2.4.4]
> at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:426) [spring-boot-2.4.4.jar:2.4.4]
> at org.springframework.boot.SpringApplication.run(SpringApplication.java:326) [spring-boot-2.4.4.jar:2.4.4]
> at org.springframework.boot.SpringApplication.run(SpringApplication.java:1313) [spring-boot-2.4.4.jar:2.4.4]
> at org.springframework.boot.SpringApplication.run(SpringApplication.java:1302) [spring-boot-2.4.4.jar:2.4.4]
> at cn.liyuguo.user.StartService.main(StartService.java:12) [classes/:na]
同样的配置，在2.7.11中，运行是正常的，如果配置方式已调整，请帮忙指出新的配置方法。 | https://github.com/apache/dubbo/issues/8241 | https://github.com/apache/dubbo/pull/8243 | 01874fc4e5fb39c8cc9040368b298cd80a4208b8 | 806850c8578a580296ce3dcbacbfde7ae8ecfa9a | 2021-07-07T12:34:18Z | java | 2021-07-10T04:13:13Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,237 | ["dubbo-common/src/main/java/org/apache/dubbo/config/ConfigCenterConfig.java", "dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/ConfigCenterConfigTest.java"] | org.apache.dubbo.config.ConfigCenterConfig#setAddress 会将 username 覆盖为 null | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.0
### Steps to reproduce this issue
1. dubbo config-center 相关yml配置如下
```
dubbo:
...
config-center:
address: nacos://xxxx:8848
username: someusername
password: xxxx
```
2. 在执行 org.apache.dubbo.config.bootstrap.DubboBootstrap#startConfigCenter 方法时会调用 configCenterConfig.refresh(); 方法。
3. setAddress方法，会覆盖已经设置过的username和password
```
public void setAddress(String address) {
this.address = address;
if (address != null) {
try {
URL url = URL.valueOf(address);
setUsername(url.getUsername());
setPassword(url.getPassword());
updateIdIfAbsent(url.getProtocol());
updateProtocolIfAbsent(url.getProtocol());
updatePortIfAbsent(url.getPort());
updateParameters(url.getParameters());
} catch (Exception ignored) {
}
}
}
```
### Expected Result
希望设置前先判断是否已经设置过相关属性值
| https://github.com/apache/dubbo/issues/8237 | https://github.com/apache/dubbo/pull/8242 | 940c7da0f53a1ff65bb57cf78624f72cb9772eee | 7af0d771de640fb5daa53a0c891bc56961a218eb | 2021-07-07T04:12:28Z | java | 2021-07-09T04:06:13Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,202 | ["dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/MergeableClusterInvoker.java"] | 不使用CompletableFuture#get() |
### Environment
* Dubbo version: 3.0
AbstractInvoker中有注释
/*
* NOTICE!
* must call {@link java.util.concurrent.CompletableFuture#get(long, TimeUnit)} because
* {@link java.util.concurrent.CompletableFuture#get()} was proved to have serious performance drop.
*/
要使用get(long, TimeUnit)
MergeableClusterInvoker中的
Result r = asyncResult.get()
也要改一下吧
| https://github.com/apache/dubbo/issues/8202 | https://github.com/apache/dubbo/pull/8223 | aef74db40405e685f5f5b8a52e3c643f3cdd8158 | 9ef015bd995558514ccc1c87df10cfc26b4fdb91 | 2021-07-02T07:50:23Z | java | 2021-07-08T14:09:09Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,178 | ["dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java", "dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java"] | Always publish service name mapping info | https://github.com/apache/dubbo/blob/532ce72f8377abf8ff659430b86e0919c9aff562/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java#L240-L248
What ever user use `instance` service discovery or `interface` service discovery, we also publish service name mapping info.
But service name mapping need metadata report dependency, so if some one just use `interface` service discovery, the user still need need metadata report dependency.
Here we add a judgement, check current service config use `instance` service discovery or not, to judge publish service name mapping or not.
| https://github.com/apache/dubbo/issues/8178 | https://github.com/apache/dubbo/pull/8179 | e7b41b2a3d54cb62133b9bb6bfe510a70de199c4 | bb6d62b858afaa6fc1d63d1ac0ed3ba3a2f024a9 | 2021-06-29T17:37:22Z | java | 2021-07-02T03:36:48Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,108 | ["dubbo-remoting/dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/jetty/JettyHttpServer.java", "dubbo-remoting/dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/jetty/JettyLoggerAdapter.java", "dubbo-remoting/dubbo-remoting-http/src/test/java/org/apache/dubbo/remoting/http/jetty/JettyLoggerAdapterTest.java", "dubbo-remoting/dubbo-remoting-http/src/test/resources/log4j.xml"] | [3.0] Rest协议下错误日志丢失 | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.0
* Operating System version: Mac OS Big Sur 11.4
* Java version: 1.8
### Steps to reproduce this issue
1. 克隆dubbo代码，检出3.0版本的tag；
2. 修改demo工程，制造1个rest协议报错的case；
3. 启动demo工程 /dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider；
4. 观察控制台日志，发现有部分错误日志被打印到了StdError，截图如下：
### Expected Result
将错误日志桥接到Dubbo自己的日志系统，而非打印到StdError。
### Actual Result
错误日志打印到了StdError，导致基于Dubbo日志做的收集和其它扩展失效。
关键代码：
1. 类文件： ``org.apache.dubbo.remoting.http.jetty.JettyHttpServer``；
2. 代码位置：第33行 ``Log.setLog(new StdErrLog());``。 | https://github.com/apache/dubbo/issues/8108 | https://github.com/apache/dubbo/pull/9052 | 42264426e1b12d5cfeb73a5f0f4e93d0c4e82031 | 8a7c360475a6fe33697fd4a1c9cae378f977f684 | 2021-06-21T06:07:00Z | java | 2021-12-06T05:34:55Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 8,070 | ["dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/migration/MigrationRuleListener.java"] | [3.0] 优化MigrationRuleListener | MigrationRuleListener类中有以下缺陷
1、
```java
public synchronized void process(ConfigChangedEvent event) {
// 如果有其他Reference未调用onRefer方法，此时配置中心传入空配置，会导致后续onRefer方法调用失败
rawRule = event.getContent();
if (StringUtils.isEmpty(rawRule)) {
logger.warn("Received empty migration rule, will ignore.");
return;
}
logger.info("Using the following migration rule to migrate:");
logger.info(rawRule);
rule = parseRule(rawRule);
if (CollectionUtils.isNotEmptyMap(handlers)) {
handlers.forEach((_key, handler) -> handler.doMigrate(rule));
}
}
@Override
public synchronized void onRefer(RegistryProtocol registryProtocol, ClusterInvoker<?> invoker, URL consumerUrl, URL registryURL) {
MigrationRuleHandler<?> migrationRuleHandler = handlers.computeIfAbsent((MigrationInvoker<?>) invoker, _key -> {
((MigrationInvoker<?>) invoker).setMigrationRuleListener(this);
return new MigrationRuleHandler<>((MigrationInvoker<?>) invoker, consumerUrl);
});
rule = parseRule(rawRule);
migrationRuleHandler.doMigrate(rule);
}
```
2、
```java
public synchronized void process(ConfigChangedEvent event) {
rawRule = event.getContent();
if (StringUtils.isEmpty(rawRule)) {
logger.warn("Received empty migration rule, will ignore.");
return;
}
logger.info("Using the following migration rule to migrate:");
logger.info(rawRule);
rule = parseRule(rawRule);
if (CollectionUtils.isNotEmptyMap(handlers)) {
handlers.forEach((_key, handler) -> handler.doMigrate(rule));
}
}
@Override
public synchronized void onRefer(RegistryProtocol registryProtocol, ClusterInvoker<?> invoker, URL consumerUrl, URL registryURL) {
MigrationRuleHandler<?> migrationRuleHandler = handlers.computeIfAbsent((MigrationInvoker<?>) invoker, _key -> {
((MigrationInvoker<?>) invoker).setMigrationRuleListener(this);
return new MigrationRuleHandler<>((MigrationInvoker<?>) invoker, consumerUrl);
});
// 该方法在有大量Reference场景下会调用多次yaml反序列化操作
rule = parseRule(rawRule);
migrationRuleHandler.doMigrate(rule);
}
``` | https://github.com/apache/dubbo/issues/8070 | https://github.com/apache/dubbo/pull/8071 | 3d3f974feb192368ae03e7d2cda07cff6260cf7d | f00464324398a401afa4f1cc9628224d970a1983 | 2021-06-16T10:06:11Z | java | 2021-06-21T02:18:33Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,999 | ["dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/migration/MigrationInvoker.java", "dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/migration/MigrationRuleListener.java", "dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/migration/ServiceDiscoveryMigrationInvoker.java", "dubbo-registry/dubbo-registry-api/src/test/java/org/apache/dubbo/registry/client/migration/MigrationRuleListenerTest.java"] | Consumer only subscribe service from first registry | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0.0-SNAPSHOT
* Operating System version: ANY
* Java version: 8
### Steps to reproduce this issue
issue demo:https://github.com/zhangyz-hd/dubbo-issues-3/tree/main/210607-no-provider-when-using-two-registries
消费者配置2个注册中心
```
dubbo.registries.z1.address=zookeeper://127.0.0.1:2181
dubbo.registries.z2.address=zookeeper://127.0.0.1:2182
```
提供者只配置消费者的第二个注册中心
```
dubbo.registries.z2.address=zookeeper://127.0.0.1:2182
```
1. 启动提供者
2. 启动消费者，无法启动
```
Failed to check the status of the service org.apache.dubbo.demo.DemoService. No provider available for the service org.apache.dubbo.demo.DemoService from the multi registry cluster use dubbo version
```
3. 如果消费者服务配置check=false，则服务调用时候No provider available
```
No provider available from registry 127.0.0.1:2181 for service org.apache.dubbo.demo.DemoService on consumer 192.168.2.193 use dubbo version , please check status of providers(disabled, not registered or in blacklist).
at org.apache.dubbo.registry.integration.RegistryDirectory.doList(RegistryDirectory.java:504)
```
4. 检查第二个注册中心的/dubbo/org.apache.dubbo.demo.DemoService/consumers节点，无消费者信息。
备注：2.7不存在此问题。 | https://github.com/apache/dubbo/issues/7999 | https://github.com/apache/dubbo/pull/8029 | 88416348314c71d4f8764b1e5c4ddc59dca35db0 | 4844effcb60c0682511bc8ca55d0503313f93057 | 2021-06-07T07:19:53Z | java | 2021-06-11T10:00:32Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,989 | ["dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/DefaultExecutorRepository.java"] | [3.0] Executor in ExecutorRepository should have shutdown logic. | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: xxx
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
1. xxx
2. xxx
3. xxx
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps？
### Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/7989 | https://github.com/apache/dubbo/pull/7990 | b7b17988325003dbc6730314b78b416583aab816 | 3cb9ac6564bf85987773b988b2f192befe415d5f | 2021-06-05T15:38:29Z | java | 2021-06-07T07:32:40Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,947 | ["dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/AbstractInvoker.java"] | [3.0] refactor to optimize the {@code AbstractInvoker#invoke()} code | Hi dubbo!
When reading the code of the {@code AbstractInvoker#invoke()}, find some places that can be optimized. These optimizations will make the code logic clearer.
### E.g
#### 1. Different expressions
These code in {@link AbstractInvoker#invoke()} line 151.
```java
if (CollectionUtils.isNotEmptyMap(attachment)) {
invocation.addObjectAttachmentsIfAbsent(attachment);
}
Map<String, Object> contextAttachments = RpcContext.getClientAttachment().getObjectAttachments();
if (contextAttachments != null && contextAttachments.size() != 0) {
invocation.addObjectAttachmentsIfAbsent(contextAttachments);
}
```
We can use `CollectionUtils.isNotEmptyMap` instead of `contextAttachments != null && contextAttachments.size() != 0`, which helps to use the same expression.
#### 2. Useless try-catch
These code in {@link AbstractInvoker#waitForResultIfSync()} line 211.
```java
try {
if (InvokeMode.SYNC == invocation.getInvokeMode()) {
/**
* NOTICE!
* must call {@link java.util.concurrent.CompletableFuture#get(long, TimeUnit)} because
* {@link java.util.concurrent.CompletableFuture#get()} was proved to have serious performance drop.
*/
asyncResult.get(Integer.MAX_VALUE, TimeUnit.MILLISECONDS);
}
} catch (InterruptedException e) {
```
For non-sync mode, entering the try-catch block has no meaning.
So it can be like this:
```java
if (InvokeMode.SYNC != invocation.getInvokeMode()) {
return;
}
try {
/*
* NOTICE!
* must call {@link java.util.concurrent.CompletableFuture#get(long, TimeUnit)} because
* {@link java.util.concurrent.CompletableFuture#get()} was proved to have serious performance drop.
*/
asyncResult.get(Integer.MAX_VALUE, TimeUnit.MILLISECONDS);
} catch (InterruptedException e) {
```
Although the performance of the two is not much different, the second way of writing will be more logically clear.
#### 3. Lengthy function
The {@link AbstractInvoker#invoke()} code has 63 lines, which is close to the length of two screens, making it unclear to read.
But this part of the code is divided into three very clear parts:
1. adding parameters to the {@code Invocation} obj
2. executing the {@code doInvoke()} call and returning the {@code Result} obj
3. waiting for the result
So decomposing it into three sub-functions will clearly express the entire process, like:
```java
// if invoker is destroyed due to address refresh from registry, let's allow the current invoke to proceed
if (isDestroyed()) {
logger.warn("Invoker for service " + this + " on consumer " + NetUtils.getLocalHost() + " is destroyed, "
+ ", dubbo version is " + Version.getVersion() + ", this invoker should not be used any longer");
}
RpcInvocation invocation = (RpcInvocation) inv;
// prepare rpc invocation
prepareInvocation(invocation);
// do invoke rpc invocation and return async result
AsyncRpcResult asyncResult = doInvokeAndReturn(invocation);
// wait rpc result if sync
waitForResultIfSync(asyncResult, invocation);
return asyncResult;
```
---
The above are some optimization suggestions for {@code AbstractInvoker}, I am very happy to make my own contribution to dubbo's code quality.
Looking forward to your reply. | https://github.com/apache/dubbo/issues/7947 | https://github.com/apache/dubbo/pull/7952 | ee4d90910a7bc2210eb1b9c06629ccff6b0840c1 | ebedc1d95c0d9352fd75e4a41c8053873f4b3896 | 2021-06-01T11:00:53Z | java | 2021-06-03T09:21:22Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,896 | ["dubbo-spring-boot/dubbo-spring-boot-compatible/autoconfigure/src/main/java/org/apache/dubbo/spring/boot/autoconfigure/DubboListenerAutoConfiguration.java", "dubbo-spring-boot/dubbo-spring-boot-compatible/autoconfigure/src/main/java/org/apache/dubbo/spring/boot/context/event/DubboConfigBeanDefinitionConflictApplicationListener.java", "dubbo-spring-boot/dubbo-spring-boot-compatible/autoconfigure/src/main/resources/META-INF/spring.factories"] | AwaitingNonWebApplicationListener中的ExecutorService对象未使用守护线程，导致Spring初始化异常进程仍旧运行 | java.util.concurrent.Executors#newSingleThreadExecutor()中的ThreadFactory生成的Thread不是守护线程，并且没有相应逻辑在Spring初始化异常出现时调起ExecutorService的shutdown方法，导致spring初始化失败进程依旧存在，无法通过进程是否存在判断程序启动是否正常。建议更换ThreadFactory。可通过错误的application.yml配置复现问题。 | https://github.com/apache/dubbo/issues/7896 | https://github.com/apache/dubbo/pull/9006 | 4b7fec2d5a9ca15290eb45691984878bc47def40 | ee961556faf34ea1abb75d238cbc8085e0a8628d | 2021-05-24T05:24:46Z | java | 2021-10-12T02:41:42Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,822 | ["dubbo-dependencies-bom/pom.xml"] | [BUG] Use the multi-registry feature with Nacos registry that set namingLoadCacheAtStart=true, the cache of NacosNamingService will overwrite each other | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: build from mater branch
* Operating System version: Mac OSX
* Java version: 1.8
### Steps to reproduce this issue
When I use the [multi-registry](https://dubbo.apache.org/en/docs/v2.7/user/examples/multi-registry/) feature of Dubbo with setting `namingLoadCacheAtStart=true`(**default is also true in Dubbo**), the cache of NacosNamingService will overwrite each other.
If two registries have different services, some of the services will be lost because of overwriting.
For example, we have settings as below:
```xml
<dubbo:registry id="registryDev" address="nacos://127.0.0.1:8849?namingLoadCacheAtStart=true"/>
<dubbo:registry id="registryTest" address="nacos://127.0.0.1:8848?namingLoadCacheAtStart=true"/>
```
If registryStable overwrites registryDev, the consumer can't find the GreetingService in registryDev.
### Expected Result
The different registry has different cache folder, so the cache will not overwrite each other.
PS: zookeeper works well with multi-registry feature of Dubbo.
### Actual Result
The cache of NacosNamingService will overwrite each other.
If two registries have different services, some of the services will be lost because of overwriting.
| https://github.com/apache/dubbo/issues/7822 | https://github.com/apache/dubbo/pull/8588 | 7537786b8e7d70cb7700d3297b852f0a101c30a4 | c089e335b15ef4adb41cd630d8124868af3b3182 | 2021-05-22T03:45:55Z | java | 2021-08-27T05:00:13Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,722 | ["dubbo-config/dubbo-config-api/pom.xml", "dubbo-dependencies-bom/pom.xml"] | ServiceNameMapping didn't work when registry-type=service. | ### Environment
* Dubbo version: master
What actually happens?
https://github.com/apache/dubbo/blob/2ca0099c9029921507219e53ad907850dcc180c8/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java#L214-L227
line_219 judgement exist problem. It's communication protocol, not registry protocol.
| https://github.com/apache/dubbo/issues/7722 | https://github.com/apache/dubbo/pull/13389 | aff714e5bb7e1e8dafaea63657c7ea80354a0687 | 77bf43d40c808a9d80c58f17f669a185a4fcd513 | 2021-05-10T18:10:55Z | java | 2023-11-21T02:22:00Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,718 | ["dubbo-config/dubbo-config-api/pom.xml", "dubbo-dependencies-bom/pom.xml"] | Consumer side call DefaultExecutorRepository#getExecutor cannot hit the cache when use the service discovery pattern | I use the `dubbo-samples/dubbo-samples-cloud-native/dubbo-demo-servicediscovery-xml/` test case in`dubbo-samples` project, consumer call `DefaultExecutorRepository#createExecutorIfAbsent` method is normal, `url.getParameter(SIDE_KEY) ` is `consumer`, and it's put entry ` {Integer.MAX_VALUE,executor} `into cache . However, when calling the `DefaultExecutorRepository#getExecutor` method, the `url.getParameter(SIDE_KEY)` is `null`,This will make it impossible to use previously cached Executors
| https://github.com/apache/dubbo/issues/7718 | https://github.com/apache/dubbo/pull/13389 | aff714e5bb7e1e8dafaea63657c7ea80354a0687 | 77bf43d40c808a9d80c58f17f669a185a4fcd513 | 2021-05-10T08:59:23Z | java | 2023-11-21T02:22:00Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,695 | ["dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/ConfigTest.java"] | Address already in use in ConfigTest#testDubboProtocolPortOverride | - [X] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [X] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 3.0
* Operating System version: Mac OS
* Java version: 1.8
### Steps to reproduce this issue
Sometimes, I failed to run ConfigTest#testDubboProtocolPortOverride
### Expected Result
All testcases run successfully
### Actual Result
An exception orrcurred as follows
```
[ERROR] Errors:
[ERROR] ConfigTest.testDubboProtocolPortOverride:1022 » Rpc Fail to start server(url: ...
[INFO]
[ERROR] Tests run: 116, Failures: 0, Errors: 1, Skipped: 28
```
```java
[07/05/21 14:37:25:260 CST] main INFO logger.LoggerFactory: using logger: org.apache.dubbo.common.logger.log4j.Log4jLoggerAdapter
[07/05/21 14:37:25:866 CST] main INFO bootstrap.DubboBootstrap: [DUBBO] No value is configured in the registry, the DynamicConfigurationFactory extension[name : null] does not support as the config center, dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:25:869 CST] main INFO bootstrap.DubboBootstrap: [DUBBO] The registry[<dubbo:registry address="N/A" port="0" />] will be not used as the config center, dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:25:998 CST] main INFO utils.ConfigValidationUtils: [DUBBO] There's no valid monitor config found, if you want to open monitor statistics for Dubbo, please make sure your monitor is configured properly., dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:26:017 CST] main INFO bootstrap.DubboBootstrap: [DUBBO] No value is configured in the registry, the MetadataReportFactory extension[name : null] does not support as the metadata center, dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:26:019 CST] main INFO bootstrap.DubboBootstrap: [DUBBO] The registry[<dubbo:registry address="N/A" port="0" />] will be not used as the metadata center, dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:26:031 CST] main INFO bootstrap.DubboBootstrap: [DUBBO] DubboBootstrap has been initialized!, dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:26:031 CST] main INFO bootstrap.DubboBootstrap: [DUBBO] DubboBootstrap is starting..., dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:26:204 CST] main INFO config.ServiceConfig: [DUBBO] Export dubbo service org.apache.dubbo.config.spring.api.DemoService to local registry url : injvm://127.0.0.1/org.apache.dubbo.config.spring.api.DemoService?anyhost=true&application=dubbo-protocol-port-override&bind.ip=10.38.233.86&bind.port=55555&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&interface=org.apache.dubbo.config.spring.api.DemoService&methods=sayName,getBox&pid=23005&release=&side=provider×tamp=1620369446048, dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:26:205 CST] main INFO config.ServiceConfig: [DUBBO] Export dubbo service org.apache.dubbo.config.spring.api.DemoService to url dubbo://10.38.233.86:55555/org.apache.dubbo.config.spring.api.DemoService?anyhost=true&application=dubbo-protocol-port-override&bind.ip=10.38.233.86&bind.port=55555&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&interface=org.apache.dubbo.config.spring.api.DemoService&methods=sayName,getBox&pid=23005&release=&side=provider×tamp=1620369446048, dubbo version: , current host: 10.38.233.86
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [ch.qos.logback.classic.util.ContextSelectorStaticBinder]
14:37:26.340 [main] DEBUG io.netty.util.internal.logging.InternalLoggerFactory - Using SLF4J as the default logging framework
14:37:26.352 [main] DEBUG io.netty.channel.MultithreadEventLoopGroup - -Dio.netty.eventLoopThreads: 16
14:37:26.367 [main] DEBUG io.netty.util.internal.InternalThreadLocalMap - -Dio.netty.threadLocalMap.stringBuilder.initialSize: 1024
14:37:26.367 [main] DEBUG io.netty.util.internal.InternalThreadLocalMap - -Dio.netty.threadLocalMap.stringBuilder.maxSize: 4096
14:37:26.374 [main] DEBUG io.netty.channel.nio.NioEventLoop - -Dio.netty.noKeySetOptimization: false
14:37:26.374 [main] DEBUG io.netty.channel.nio.NioEventLoop - -Dio.netty.selectorAutoRebuildThreshold: 512
14:37:26.397 [main] DEBUG io.netty.util.internal.PlatformDependent - Platform: MacOS
14:37:26.398 [main] DEBUG io.netty.util.internal.PlatformDependent0 - -Dio.netty.noUnsafe: false
14:37:26.398 [main] DEBUG io.netty.util.internal.PlatformDependent0 - Java version: 8
14:37:26.399 [main] DEBUG io.netty.util.internal.PlatformDependent0 - sun.misc.Unsafe.theUnsafe: available
14:37:26.400 [main] DEBUG io.netty.util.internal.PlatformDependent0 - sun.misc.Unsafe.copyMemory: available
14:37:26.401 [main] DEBUG io.netty.util.internal.PlatformDependent0 - java.nio.Buffer.address: available
14:37:26.401 [main] DEBUG io.netty.util.internal.PlatformDependent0 - direct buffer constructor: available
14:37:26.402 [main] DEBUG io.netty.util.internal.PlatformDependent0 - java.nio.Bits.unaligned: available, true
14:37:26.402 [main] DEBUG io.netty.util.internal.PlatformDependent0 - jdk.internal.misc.Unsafe.allocateUninitializedArray(int): unavailable prior to Java9
14:37:26.402 [main] DEBUG io.netty.util.internal.PlatformDependent0 - java.nio.DirectByteBuffer.<init>(long, int): available
14:37:26.402 [main] DEBUG io.netty.util.internal.PlatformDependent - sun.misc.Unsafe: available
14:37:26.402 [main] DEBUG io.netty.util.internal.PlatformDependent - -Dio.netty.tmpdir: /var/folders/qb/c5lkt6s932s1v2gvx702sqx40000gp/T (java.io.tmpdir)
14:37:26.402 [main] DEBUG io.netty.util.internal.PlatformDependent - -Dio.netty.bitMode: 64 (sun.arch.data.model)
14:37:26.404 [main] DEBUG io.netty.util.internal.PlatformDependent - -Dio.netty.maxDirectMemory: 3817865216 bytes
14:37:26.404 [main] DEBUG io.netty.util.internal.PlatformDependent - -Dio.netty.uninitializedArrayAllocationThreshold: -1
14:37:26.405 [main] DEBUG io.netty.util.internal.CleanerJava6 - java.nio.ByteBuffer.cleaner(): available
14:37:26.405 [main] DEBUG io.netty.util.internal.PlatformDependent - -Dio.netty.noPreferDirect: false
14:37:26.415 [main] DEBUG io.netty.util.internal.PlatformDependent - org.jctools-core.MpscChunkedArrayQueue: available
14:37:26.454 [main] DEBUG io.netty.util.ResourceLeakDetector - -Dio.netty.leakDetection.level: simple
14:37:26.454 [main] DEBUG io.netty.util.ResourceLeakDetector - -Dio.netty.leakDetection.targetRecords: 4
14:37:26.458 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.numHeapArenas: 16
14:37:26.458 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.numDirectArenas: 16
14:37:26.458 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.pageSize: 8192
14:37:26.458 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.maxOrder: 11
14:37:26.458 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.chunkSize: 16777216
14:37:26.458 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.smallCacheSize: 256
14:37:26.458 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.normalCacheSize: 64
14:37:26.459 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.maxCachedBufferCapacity: 32768
14:37:26.459 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.cacheTrimInterval: 8192
14:37:26.459 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.cacheTrimIntervalMillis: 0
14:37:26.459 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.useCacheForAllThreads: true
14:37:26.459 [main] DEBUG io.netty.buffer.PooledByteBufAllocator - -Dio.netty.allocator.maxCachedByteBuffersPerChunk: 1023
14:37:26.488 [main] DEBUG io.netty.channel.DefaultChannelId - -Dio.netty.processId: 23005 (auto-detected)
14:37:26.489 [main] DEBUG io.netty.util.NetUtil - -Djava.net.preferIPv4Stack: false
14:37:26.489 [main] DEBUG io.netty.util.NetUtil - -Djava.net.preferIPv6Addresses: false
14:37:26.491 [main] DEBUG io.netty.util.NetUtilInitializations - Loopback interface: lo0 (lo0, 0:0:0:0:0:0:0:1%lo0)
14:37:26.492 [main] DEBUG io.netty.util.NetUtil - Failed to get SOMAXCONN from sysctl and file /proc/sys/net/core/somaxconn. Default: 128
14:37:26.495 [main] DEBUG io.netty.channel.DefaultChannelId - -Dio.netty.machineId: a0:78:17:ff:fe:62:c4:0d (auto-detected)
14:37:26.517 [main] DEBUG io.netty.buffer.ByteBufUtil - -Dio.netty.allocator.type: pooled
14:37:26.517 [main] DEBUG io.netty.buffer.ByteBufUtil - -Dio.netty.threadLocalDirectBufferSize: 0
14:37:26.518 [main] DEBUG io.netty.buffer.ByteBufUtil - -Dio.netty.maxThreadLocalCharBufferSize: 16384
[07/05/21 14:37:26:561 CST] main INFO support.AbstractRegistryFactory: [DUBBO] Close all registries [], dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:26:561 CST] main INFO dubbo.DubboProtocol: [DUBBO] Unexport service: dubbo://10.38.233.86:55555/org.apache.dubbo.config.spring.api.DemoService?anyhost=true&application=dubbo-protocol-port-override&bind.ip=10.38.233.86&bind.port=55555&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&interface=org.apache.dubbo.config.spring.api.DemoService&methods=sayName,getBox&pid=23005&release=&side=provider×tamp=1620369446048, dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:26:561 CST] main INFO injvm.InjvmProtocol: [DUBBO] Unexport service: injvm://127.0.0.1/org.apache.dubbo.config.spring.api.DemoService?anyhost=true&application=dubbo-protocol-port-override&bind.ip=10.38.233.86&bind.port=55555&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&interface=org.apache.dubbo.config.spring.api.DemoService&methods=sayName,getBox&pid=23005&release=&side=provider×tamp=1620369446048, dubbo version: , current host: 10.38.233.86
[07/05/21 14:37:26:568 CST] main INFO bootstrap.DubboBootstrap: [DUBBO] DubboBootstrap is about to shutdown..., dubbo version: , current host: 10.38.233.86
org.apache.dubbo.rpc.RpcException: Fail to start server(url: dubbo://10.38.233.86:55555/org.apache.dubbo.config.spring.api.DemoService?anyhost=true&application=dubbo-protocol-port-override&bind.ip=10.38.233.86&bind.port=55555&channel.readonly.sent=true&codec=dubbo&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&heartbeat=60000&interface=org.apache.dubbo.config.spring.api.DemoService&methods=sayName,getBox&pid=23005&release=&side=provider×tamp=1620369446048) Failed to bind NettyServer on /10.38.233.86:55555, cause: Address already in use
at org.apache.dubbo.rpc.protocol.dubbo.DubboProtocol.createServer(DubboProtocol.java:348)
at org.apache.dubbo.rpc.protocol.dubbo.DubboProtocol.openServer(DubboProtocol.java:320)
at org.apache.dubbo.rpc.protocol.dubbo.DubboProtocol.export(DubboProtocol.java:303)
at org.apache.dubbo.rpc.protocol.ProtocolListenerWrapper.export(ProtocolListenerWrapper.java:66)
at org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper.export(ProtocolFilterWrapper.java:62)
at org.apache.dubbo.rpc.Protocol$Adaptive.export(Protocol$Adaptive.java)
at org.apache.dubbo.config.ServiceConfig.doExportUrlsFor1Protocol(ServiceConfig.java:518)
at org.apache.dubbo.config.ServiceConfig.doExportUrls(ServiceConfig.java:338)
at org.apache.dubbo.config.ServiceConfig.doExport(ServiceConfig.java:312)
at org.apache.dubbo.config.ServiceConfig.export(ServiceConfig.java:214)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.lambda$exportServices$12(DubboBootstrap.java:1106)
at java.util.HashMap$Values.forEach(HashMap.java:981)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.exportServices(DubboBootstrap.java:1093)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:908)
at org.apache.dubbo.config.spring.ConfigTest.testDubboProtocolPortOverride(ConfigTest.java:1022)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:686)
at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:205)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:201)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:137)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:71)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:248)
at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$5(DefaultLauncher.java:211)
at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:226)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:199)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:132)
at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:71)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:220)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:53)
Caused by: org.apache.dubbo.remoting.RemotingException: Failed to bind NettyServer on /10.38.233.86:55555, cause: Address already in use
at org.apache.dubbo.remoting.transport.AbstractServer.<init>(AbstractServer.java:77)
at org.apache.dubbo.remoting.transport.netty4.NettyServer.<init>(NettyServer.java:77)
at org.apache.dubbo.remoting.transport.netty4.NettyTransporter.bind(NettyTransporter.java:35)
at org.apache.dubbo.remoting.Transporter$Adaptive.bind(Transporter$Adaptive.java)
at org.apache.dubbo.remoting.Transporters.bind(Transporters.java:56)
at org.apache.dubbo.remoting.exchange.support.header.HeaderExchanger.bind(HeaderExchanger.java:44)
at org.apache.dubbo.remoting.exchange.Exchangers.bind(Exchangers.java:70)
at org.apache.dubbo.rpc.protocol.dubbo.DubboProtocol.createServer(DubboProtocol.java:346)
... 77 more
Caused by: java.net.BindException: Address already in use
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Net.java:444)
at sun.nio.ch.Net.bind(Net.java:436)
at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:225)
at io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:134)
at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:550)
at io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1334)
at io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:506)
at io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:491)
at io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:973)
at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:248)
at io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:356)
at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:748)
``` | https://github.com/apache/dubbo/issues/7695 | https://github.com/apache/dubbo/pull/7696 | 3a3d0ef50ee0939dbf5cd6ddb4b0aeb789b329af | ca0b9828667dc981986b1235bc4e032f8cd46171 | 2021-05-07T06:59:53Z | java | 2021-05-07T08:26:06Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,646 | ["dubbo-config/dubbo-config-api/pom.xml", "dubbo-dependencies-bom/pom.xml"] | 注解模式和API模式telnet无法使用invoke | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.10
* Operating System version: MacOS
* Java version: 1.8.0_281
### Steps to reproduce this issue
1. clone代码
```bash
git clone [email protected]:apache/dubbo.git
git checkout -b 2.7.10 7b39089f
```
2. 分别运行dubbo-demo-annotation, dubbo-demo-api, dubbo-demo-xml的provider Application
**dubbo-demo-annotation**
**dubbo-demo-api**
**dubbo-demo-xml**
xml方式的telnet可以invoke，其他两种不行
请问一下是我使用的方式不对吗？还是说2.7.10版本的Dubbo 注解和api方式不支持telnet的invoke的那些参数？
| https://github.com/apache/dubbo/issues/7646 | https://github.com/apache/dubbo/pull/13422 | 2b06ac6838dcee9e075f6b8ecba3f253f3c96207 | 01961a0e6ffe8411a417a7c96bf388660d9741a0 | 2021-04-27T15:26:34Z | java | 2023-11-29T13:17:37Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,483 | ["dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/CacheableFailbackRegistry.java"] | [3.0] stringUrls cache was deleted when startup | https://github.com/apache/dubbo/pull/7476/files#diff-b00639ea715ae8698865e33943cacc6a08ba0985e78980b8b74c085e4b12188bR165-R168
This pull request wants to delete stringUrls cache when the provider is empty or unsubscribe is called. but forgot to check path `/providers` in the first case, cause stringUrls was cleared every time when providers change. And this pull request also forgot to clear stringAddress and stringParam cache.
| https://github.com/apache/dubbo/issues/7483 | https://github.com/apache/dubbo/pull/7484 | 5f52fab4fdf64c105ad8f09b8193837f251b0629 | 1899389d6f36be344cd202b42069667cb6488db9 | 2021-03-30T08:40:24Z | java | 2021-04-29T11:35:17Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,238 | ["dubbo-config/dubbo-config-api/pom.xml", "dubbo-dependencies-bom/pom.xml"] | dubbo 2.7.9 无法注册到zk上去 |
### Environment
* Dubbo dubbo 2.7.9
* Operating System version: window 10
* java version "1.8.0_191"
### Steps to reproduce this issue
1. zookeeper 版本 3.6.2-bin (https://mirrors.tuna.tsinghua.edu.cn/apache/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2-bin.tar.gz)
zk 配置
```tickTime=2000
initLimit=10
syncLimit=5
dataDir=C:\\openSource\\apache-zookeeper-3.6.2-bin\\data
dataLogDir=C:\\openSource\\apache-zookeeper-3.6.2-bin\\log
clientPort=2181
audit.enable=true
admin.serverPort=9991
```
2. 当我运行dubbo-demo-annotation-provider 的org.apache.dubbo.demo.provider.Application#main 时候, 打印日志如下, 并没有报错
```
Connected to the target VM, address: '127.0.0.1:53362', transport: 'socket'
[22/02/21 22:23:29:481 CST] main INFO logger.LoggerFactory: using logger: org.apache.dubbo.common.logger.log4j.Log4jLoggerAdapter
```
3. 运行 dubbo-demo-annotation-consumer 的 org.apache.dubbo.demo.consumer.Application#main, 报错
```
Exception in thread "main" java.lang.NullPointerException
at org.apache.dubbo.demo.consumer.comp.DemoServiceComponent.sayHello(DemoServiceComponent.java:40)
at org.apache.dubbo.demo.consumer.Application.main(Application.java:37)
```
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
期待的结果是调用 sayHello
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/7238 | https://github.com/apache/dubbo/pull/12969 | 042a17941dd42de8eddd611710055ea549c8899f | e07fc6311b54055abc86f849d8b1598d8bc347b3 | 2021-02-22T14:25:43Z | java | 2023-08-29T08:04:43Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,161 | ["dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/api/SslContexts.java", "dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/GrpcOptionsUtils.java"] | maybe dubbo open ssl cert file leak? | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.6
* Operating System version: CentOS-7
* Java version: 1.8.0_275
### Steps to reproduce this issue
dobbo use netty to listen as a server . and use this class SslConfig.java and netty4/SslContexts.java to use ssl cert file .
this class always open file .
by netty's source : PemReader and SslContextBuilder they not close this InputStream yet .and netty expect user close the InputStream if the InputStream is open by user.
https://github.com/netty/netty/issues/10974
https://github.com/netty/netty/pull/10976
but it seems dobbo not close it ?
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
InputStream maybe need close immediately?
### Actual Result
InputStream seems leak.
| https://github.com/apache/dubbo/issues/7161 | https://github.com/apache/dubbo/pull/9245 | 5a00ef4647472a818d1ef602c512a63fe9a532f6 | 838493c4c4eaa09fe7291ef6e6963bf816475219 | 2021-02-01T01:01:40Z | java | 2021-11-10T05:35:29Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,085 | ["dubbo-config/dubbo-config-api/pom.xml", "dubbo-dependencies-bom/pom.xml"] | dubbo2.7.7泛化调用找不到方法，下方是具体报错 | org.apache.dubbo.rpc.RpcException: Failed to invoke the method searchReportByFilter in the service org.apache.dubbo.rpc.service.GenericService. Tried 1 times of the providers [xxxxxx:20880] (1/1) from the registry xxxxx:2181 on the consumer xxxxxx using the dubbo version 2.7.7. Last error is: Failed to invoke remote method: $invoke, provider: dubbo://xxxxxx:20880/cn.sto.service.manage.protocol.IndexSearchService?anyhost=true&application=share_web_consumer&check=false&deprecated=false&dubbo=2.0.2&dynamic=true&generic=true&init=false&interface=cn.sto.service.manage.protocol.IndexSearchService&metadata-type=remote&methods=searchIndexListByFilter,searchIndexByFilter,searchIndexDetailByFilter,searchReportByFilter&monitor=dubbo%3A%2F%2F192.168.122.73%3A2181%2Forg.apache.dubbo.registry.RegistryService%3Fapplication%3Dshare_web_consumer%26backup%3D192.168.122.74%3A2181%2C192.168.122.75%3A2181%26dubbo%3D2.0.2%26pid%3D49320%26protocol%3Dregistry%26qos.enable%3Dfalse%26refer%3Dapplication%253Dshare_web_consumer%2526dubbo%253D2.0.2%2526interface%253Dorg.apache.dubbo.monitor.MonitorService%2526pid%253D49320%2526qos.enable%253Dfalse%2526register.ip%253D192.168.14.209%2526release%253D2.7.7%2526timestamp%253D1609999040343%26registry%3Dzookeeper%26release%3D2.7.7%26timestamp%3D1609999040340&pid=49320&qos.enable=false®ister.ip=192.168.14.209&release=2.7.7&remote.application=sto-service-manage&retries=0&revision=1.0.0&side=consumer&sticky=false&timeout=3000×tamp=1609988936017&version=1.0.0, cause: org.apache.dubbo.remoting.RemotingException: org.apache.dubbo.rpc.RpcException: cn.sto.service.manage.protocol.IndexSearchService.searchReportByFilter(java.lang.String)
org.apache.dubbo.rpc.RpcException: xxxxx.xxxxx.xxxx(java.lang.String)
at org.apache.dubbo.rpc.filter.GenericFilter.invoke(GenericFilter.java:149)
at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:81)
at org.apache.dubbo.rpc.filter.ClassLoaderFilter.invoke(ClassLoaderFilter.java:38)
at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:81)
at org.apache.dubbo.rpc.filter.EchoFilter.invoke(EchoFilter.java:41)
at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:81)
at org.apache.dubbo.rpc.protocol.dubbo.DubboProtocol$1.reply(DubboProtocol.java:145)
at org.apache.dubbo.remoting.exchange.support.header.HeaderExchangeHandler.handleRequest(HeaderExchangeHandler.java:100)
at org.apache.dubbo.remoting.exchange.support.header.HeaderExchangeHandler.received(HeaderExchangeHandler.java:175)
at org.apache.dubbo.remoting.transport.DecodeHandler.received(DecodeHandler.java:51)
at org.apache.dubbo.remoting.transport.dispatcher.ChannelEventRunnable.run(ChannelEventRunnable.java:57)
at com.alibaba.ttl.TtlRunnable.run(TtlRunnable.java:51)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NoSuchMethodException:xxxxx.xxxx.xxxxx(java.lang.String) | https://github.com/apache/dubbo/issues/7085 | https://github.com/apache/dubbo/pull/12456 | a9a579929f563779b4b77f15c42c4806d8c89af7 | 2227f0b4aafc78b9fc2f6643d715a81fc558bd06 | 2021-01-07T06:05:42Z | java | 2023-06-06T09:37:33Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,059 | ["dubbo-config/dubbo-config-api/pom.xml", "dubbo-dependencies-bom/pom.xml"] | 不使用dubbo的默认日志框架，启动时会报拒绝连接错误 | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.8
* Operating System version: deepin V20 社区版
* Java version: 1.8
### Steps to reproduce this issue
1. 在springboot启动main方法里添加如下代码：
```
System.setProperty("dubbo.application.logger","slf4j");
```
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
希望项目启动时不要报异常
### Actual Result
如果使用dubbo的默认日志框架启动时不会报任何错误。
使用了指定的slf4j就会报如下异常，但并不影响使用。
为了不看见异常，我暂时使用默认的log4j
```
2020-12-26 19:01:40.203 INFO 10072 --- [ main] org.apache.dubbo.config.ServiceConfig : [DUBBO] Export dubbo service com.zbi.admin.service.PermissionService to local registry url : injvm://127.0.0.1/com.zbi.admin.service.PermissionService?anyhost=true&application=zbi-admin-server&bind.ip=192.168.31.90&bind.port=20880&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&group=permissionServiceImpl&interface=com.zbi.admin.service.PermissionService&logger=slf4j&methods=query,update,del,delete,queryList,queryColumns,findPermissionByIds,queryById&pid=10072&qos.enable=false&release=2.7.8&side=provider×tamp=1608980500199, dubbo version: 2.7.8, current host: 192.168.31.90
2020-12-26 19:01:40.203 INFO 10072 --- [ main] org.apache.dubbo.config.ServiceConfig : [DUBBO] Register dubbo service com.zbi.admin.service.PermissionService url dubbo://192.168.31.90:20880/com.zbi.admin.service.PermissionService?anyhost=true&application=zbi-admin-server&bind.ip=192.168.31.90&bind.port=20880&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&group=permissionServiceImpl&interface=com.zbi.admin.service.PermissionService&logger=slf4j&methods=query,update,del,delete,queryList,queryColumns,findPermissionByIds,queryById&pid=10072&qos.enable=false&release=2.7.8&side=provider×tamp=1608980500199 to registry registry://localhost:9090/org.apache.dubbo.registry.RegistryService?application=zbi-admin-server&dubbo=2.0.2&logger=slf4j&pid=10072&qos.enable=false®istry=spring-cloud&release=2.7.8×tamp=1608980500199, dubbo version: 2.7.8, current host: 192.168.31.90
2020-12-26 19:01:40.204 INFO 10072 --- [ main] c.a.c.dubbo.registry.DubboCloudRegistry : [DUBBO] Register: dubbo://192.168.31.90:20880/com.zbi.admin.service.PermissionService?anyhost=true&application=zbi-admin-server&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&group=permissionServiceImpl&interface=com.zbi.admin.service.PermissionService&logger=slf4j&methods=query,update,del,delete,queryList,queryColumns,findPermissionByIds,queryById&pid=10072&release=2.7.8&side=provider×tamp=1608980500199, dubbo version: 2.7.8, current host: 192.168.31.90
2020-12-26 19:01:40.205 INFO 10072 --- [ main] c.a.c.dubbo.registry.DubboCloudRegistry : [DUBBO] Subscribe: provider://192.168.31.90:20880/com.zbi.admin.service.PermissionService?anyhost=true&application=zbi-admin-server&bind.ip=192.168.31.90&bind.port=20880&category=configurators&check=false&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&group=permissionServiceImpl&interface=com.zbi.admin.service.PermissionService&logger=slf4j&methods=query,update,del,delete,queryList,queryColumns,findPermissionByIds,queryById&pid=10072&qos.enable=false&release=2.7.8&side=provider×tamp=1608980500199, dubbo version: 2.7.8, current host: 192.168.31.90
2020-12-26 19:01:40.206 INFO 10072 --- [ main] m.DynamicConfigurationServiceNameMapping : [DUBBO] Dubbo service[permissionServiceImpl] mapped to interface name[com.zbi.admin.service.PermissionService]., dubbo version: 2.7.8, current host: 192.168.31.90
2020-12-26 19:01:40.213 INFO 10072 --- [ main] org.apache.dubbo.config.ServiceConfig : [DUBBO] No valid ip found from environment, try to find valid host from DNS., dubbo version: 2.7.8, current host: 192.168.31.90
2020-12-26 19:01:40.213 WARN 10072 --- [ main] org.apache.dubbo.config.ServiceConfig : [DUBBO] 拒绝连接, dubbo version: 2.7.8, current host: 192.168.31.90
java.net.ConnectException: 拒绝连接
at java.net.PlainSocketImpl.socketConnect(Native Method) ~[na:1.8.0_60]
at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350) ~[na:1.8.0_60]
at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206) ~[na:1.8.0_60]
at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) ~[na:1.8.0_60]
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) ~[na:1.8.0_60]
at java.net.Socket.connect(Socket.java:589) ~[na:1.8.0_60]
at org.apache.dubbo.config.ServiceConfig.findConfigedHosts(ServiceConfig.java:588) [dubbo-2.7.8.jar:2.7.8]
at org.apache.dubbo.config.ServiceConfig.doExportUrlsFor1Protocol(ServiceConfig.java:443) [dubbo-2.7.8.jar:2.7.8]
at org.apache.dubbo.config.ServiceConfig.doExportUrls(ServiceConfig.java:325) [dubbo-2.7.8.jar:2.7.8]
at org.apache.dubbo.config.ServiceConfig.doExport(ServiceConfig.java:300) [dubbo-2.7.8.jar:2.7.8]
at org.apache.dubbo.config.ServiceConfig.export(ServiceConfig.java:206) [dubbo-2.7.8.jar:2.7.8]
at org.apache.dubbo.config.bootstrap.DubboBootstrap.lambda$exportServices$15(DubboBootstrap.java:1103) [dubbo-2.7.8.jar:2.7.8]
at java.util.HashMap$Values.forEach(HashMap.java:972) ~[na:1.8.0_60]
at org.apache.dubbo.config.bootstrap.DubboBootstrap.exportServices(DubboBootstrap.java:1090) [dubbo-2.7.8.jar:2.7.8]
at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:901) [dubbo-2.7.8.jar:2.7.8]
at org.apache.dubbo.config.spring.context.DubboBootstrapApplicationListener.onContextRefreshedEvent(DubboBootstrapApplicationListener.java:59) ~[dubbo-2.7.8.jar:2.7.8]
at org.apache.dubbo.config.spring.context.DubboBootstrapApplicationListener.onApplicationContextEvent(DubboBootstrapApplicationListener.java:52) ~[dubbo-2.7.8.jar:2.7.8]
at org.apache.dubbo.config.spring.context.OneTimeExecutionApplicationContextEventListener.onApplicationEvent(OneTimeExecutionApplicationContextEventListener.java:40) ~[dubbo-2.7.8.jar:2.7.8]
at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:172) ~[spring-context-5.2.8.RELEASE.jar:5.2.8.RELEASE]
at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:165) ~[spring-context-5.2.8.RELEASE.jar:5.2.8.RELEASE]
at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139) ~[spring-context-5.2.8.RELEASE.jar:5.2.8.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:404) ~[spring-context-5.2.8.RELEASE.jar:5.2.8.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:361) ~[spring-context-5.2.8.RELEASE.jar:5.2.8.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:898) ~[spring-context-5.2.8.RELEASE.jar:5.2.8.RELEASE]
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.finishRefresh(ServletWebServerApplicationContext.java:162) ~[spring-boot-2.2.5.RELEASE.jar:2.2.5.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:554) ~[spring-context-5.2.8.RELEASE.jar:5.2.8.RELEASE]
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:141) ~[spring-boot-2.2.5.RELEASE.jar:2.2.5.RELEASE]
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:747) ~[spring-boot-2.2.5.RELEASE.jar:2.2.5.RELEASE]
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397) ~[spring-boot-2.2.5.RELEASE.jar:2.2.5.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:315) ~[spring-boot-2.2.5.RELEASE.jar:2.2.5.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1226) ~[spring-boot-2.2.5.RELEASE.jar:2.2.5.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1215) ~[spring-boot-2.2.5.RELEASE.jar:2.2.5.RELEASE]
at com.zbi.admin.AdminServerApplication.main(AdminServerApplication.java:32) ~[classes/:na]
```
| https://github.com/apache/dubbo/issues/7059 | https://github.com/apache/dubbo/pull/12456 | a9a579929f563779b4b77f15c42c4806d8c89af7 | 2227f0b4aafc78b9fc2f6643d715a81fc558bd06 | 2020-12-26T11:12:35Z | java | 2023-06-06T09:37:33Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 7,054 | ["dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/DefaultExecutorRepository.java", "dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/manager/ExecutorRepository.java", "dubbo-common/src/test/java/org/apache/dubbo/common/threadpool/manager/ExecutorRepositoryTest.java", "dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java", "dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/AbstractClient.java", "dubbo-remoting/dubbo-remoting-netty/src/test/java/org/apache/dubbo/remoting/transport/netty/ThreadNameTest.java"] | consumer端线程池的实现非常不科学 | * Dubbo version: 2.7.8
先说结论吧，目前的实现问题非常大，对于一个默认配置的consumer，只要运行一段时间，consumer应用就会有n个线程数为200的FixedThreadPool，n是应用依赖的所有provider的不同端口的数量Set(provider.getPort()).size()，并且每一个provider下线都会导致关闭和重建一个FixedThreadPool。
详细解释一下，我们假设consumer端所有配置为默认，那么会有以下问题：
1. 对不同的provider，consumer会通过一个map共用线程池，其中key是provider的端口。所以如果provider有多个端口，还是会使用多个线程池，当然仅仅是这个问题的话影响还不算大。
但是考虑有100个provider，他们的端口全部相同，那么每个provider下线的时候，AbstractClient.close()方法会被调用，线程池会被关闭... 而dubbo有默认端口，在实际场景下大部分provider端口都一致，其中只要有一个下线，整个线程池就会关闭。
所以在实际场景中，consumer使用的线程池一直在不断的关闭，不断的新建...
2. 前面这个问题已经很大了，但这没有结束，它还会导致另外一个大问题...
AbstractClient.initExecutor()方法会设置线程池的名字和类型，默认名字为DubboClientHandler，类型为cache，看起来都是CachedThreadPool。但实际上initExecutor方法调用在wrapChannelHandler方法之后，Dispatcher.dispatch()方法的url参数并没有设置为cache，所以对于同一个端口，最开始会是一个名字为DubboClientHandler的CachedThreadPool，但是因为上一个问题的存在，一台provider下线就会导致这个线程池被关闭。
然后consumer继续调用provider，这时候会调用WrappedChannelHandler.getExecutorService()方法，因为原线程池被关闭，会直接新建一个线程池，但是因为WrappedChannelHandler里的url没有被设置过，重建的线程池会是一个名叫Dubbo的200个线程的FixedThreadPool... 并且这个FixedThreadPool还在一直随着provider下线被关闭和重建...
所以最终结果就是一堆200个线程的FixedThreadPool在不断关闭与重建...... | https://github.com/apache/dubbo/issues/7054 | https://github.com/apache/dubbo/pull/7950 | d5b46c3e6561b1c42d8f146f03e388342d9d787d | 259dff2d04d91223d7db8fbae7cff543b830a38c | 2020-12-25T07:08:25Z | java | 2021-06-04T02:25:14Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,814 | ["dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java"] | Consumer aborted with ArrayIndexOutOfBoundsException when subscribing services from Nacos with '*' in group or version | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: reproduced with 2.7.3, 2.7.8
* Operating System version: Windows 10
* Java version: 1.8.0
### Steps to reproduce this issue
1. Register a service with a non-dubbo service name (e.g. `user-service`) in a Nacos registry
2. Start a dubbo provider registering to the same Nacos registry
3. Start a dubbo consumer consuming the service provided by the former provider, with a wildcard selector ('*') in group or version
### Expected Result
The consumer can initialize and call services successfully.
### Actual Result
What actually happens?
The consumer aborted during initialization, with the following exception:
```
Exception in thread "main" org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'demoServiceComponent': Injection of @DubboReference dependencies is failed; nested exception is java.lang.IllegalStateException: Failed to subscribe consumer://192.168.1.241/org.apache.dubbo.demo.DemoService?application=dubbo-demo-annotation-consumer&category=providers,configurators,routers&dubbo=2.0.2&group=*&init=false&interface=org.apache.dubbo.demo.DemoService&methods=sayHello,sayHelloAsync&pid=10232&side=consumer&sticky=false×tamp=1603163878386, cause: 1
at com.alibaba.spring.beans.factory.annotation.AbstractAnnotationBeanPostProcessor.postProcessPropertyValues(AbstractAnnotationBeanPostProcessor.java:146)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1268)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:553)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:483)
at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:312)
at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:308)
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:761)
at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:867)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:543)
at org.springframework.context.annotation.AnnotationConfigApplicationContext.<init>(AnnotationConfigApplicationContext.java:84)
at org.apache.dubbo.demo.consumer.Application.main(Application.java:34)
Caused by: java.lang.IllegalStateException: Failed to subscribe consumer://192.168.1.241/org.apache.dubbo.demo.DemoService?application=dubbo-demo-annotation-consumer&category=providers,configurators,routers&dubbo=2.0.2&group=*&init=false&interface=org.apache.dubbo.demo.DemoService&methods=sayHello,sayHelloAsync&pid=10232&side=consumer&sticky=false×tamp=1603163878386, cause: 1
at org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:350)
at org.apache.dubbo.registry.ListenerRegistryWrapper.subscribe(ListenerRegistryWrapper.java:105)
at org.apache.dubbo.registry.integration.RegistryDirectory.subscribe(RegistryDirectory.java:185)
at org.apache.dubbo.registry.integration.RegistryProtocol.doRefer(RegistryProtocol.java:469)
at org.apache.dubbo.registry.integration.RegistryProtocol.refer(RegistryProtocol.java:449)
at org.apache.dubbo.rpc.protocol.ProtocolListenerWrapper.refer(ProtocolListenerWrapper.java:72)
at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper.refer(ProtocolFilterWrapper.java:161)
at org.apache.dubbo.rpc.Protocol$Adaptive.refer(Protocol$Adaptive.java)
at org.apache.dubbo.config.ReferenceConfig.createProxy(ReferenceConfig.java:356)
at org.apache.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:296)
at org.apache.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:200)
at org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.doGetInjectedBean(ReferenceAnnotationBeanPostProcessor.java:144)
at com.alibaba.spring.beans.factory.annotation.AbstractAnnotationBeanPostProcessor.getInjectedObject(AbstractAnnotationBeanPostProcessor.java:359)
at com.alibaba.spring.beans.factory.annotation.AbstractAnnotationBeanPostProcessor$AnnotatedFieldElement.inject(AbstractAnnotationBeanPostProcessor.java:539)
at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:88)
at com.alibaba.spring.beans.factory.annotation.AbstractAnnotationBeanPostProcessor.postProcessPropertyValues(AbstractAnnotationBeanPostProcessor.java:142)
... 12 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 1
at org.apache.dubbo.registry.nacos.NacosServiceName.<init>(NacosServiceName.java:80)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
at org.apache.dubbo.registry.nacos.NacosRegistry.lambda$filterServiceNames$4(NacosRegistry.java:303)
at org.apache.dubbo.registry.nacos.NacosRegistry.execute(NacosRegistry.java:583)
at org.apache.dubbo.registry.nacos.NacosRegistry.filterServiceNames(NacosRegistry.java:295)
at org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames0(NacosRegistry.java:286)
at org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames(NacosRegistry.java:267)
at org.apache.dubbo.registry.nacos.NacosRegistry.doSubscribe(NacosRegistry.java:178)
at org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:333)
... 27 more
```
### Root Cause
When NacosRegistry tries to subscribe dubbo services with wildcard in group or version, it will fetch and parse all service names from nacos. However the parsing logic made a wrong assumption that all services names conform to the dubbo service format like `providers:org.apache.dubbo.demo.DemoService:1.0.0:group1`, while there may be other service names like `user-service` in the registry. | https://github.com/apache/dubbo/issues/6814 | https://github.com/apache/dubbo/pull/8573 | 24e4bd318b589ae7c39f05839f9a42ec801eef0d | bce96419f2d75e7d9b770067194a8e5fb14a5fbd | 2020-10-20T03:43:39Z | java | 2021-08-27T06:33:41Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,504 | ["dubbo-configcenter/dubbo-configcenter-consul/src/main/java/org/apache/dubbo/configcenter/consul/ConsulDynamicConfiguration.java"] | [Feature]Make Consul Dynamic Configuration support ACL | If the consul enable acl, current consul dynamic configuration does not support. So it need to support it.
| https://github.com/apache/dubbo/issues/6504 | https://github.com/apache/dubbo/pull/6505 | d41bfaba21f55018669423469a7801fdbfc21c9a | 47ed75489206c4c944dd0eb187157eaa0ffc0527 | 2020-07-22T17:23:13Z | java | 2020-07-27T16:50:12Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,497 | ["dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java", "dubbo-rpc/dubbo-rpc-webservice/src/main/java/org/apache/dubbo/rpc/protocol/webservice/WebServiceProtocol.java", "dubbo-rpc/dubbo-rpc-webservice/src/test/java/org/apache/dubbo/rpc/protocol/webservice/WebserviceProtocolTest.java"] | [Bug]Webservice consumer cannot invoke webservice provider when provider container has contextPath and servlet has url pattern | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: xxx
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
1.
Use a web container, for example tomcat, and use a context path, for example set the container context path "dubbo_samples_webservice_provider_war"
2.
config web.xml
```xml
<servlet>
<servlet-name>dubbo</servlet-name>
<servlet-class>org.apache.dubbo.remoting.http.servlet.DispatcherServlet</servlet-class>
<load-on-startup>1</load-on-startup>
</servlet>
<servlet-mapping>
<servlet-name>dubbo</servlet-name>
<url-pattern>/services/*</url-pattern>
</servlet-mapping>
```
3.
config provider
```xml
<dubbo:application name="dubbo-webservice-app" />
<dubbo:registry address="zookeeper://127.0.0.1:2181" />
<dubbo:protocol name="webservice" port="8083" server="servlet" contextpath="dubbo_samples_webservice_provider_war/services"/>
<dubbo:service interface="org.apache.dubbo.samples.webservice.DemoService" ref="demoService" />
<bean id="demoService" class="org.apache.dubbo.samples.webservice.provider.impl.DemoServiceImpl" />
```
4.
start provider
start consumer
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
The consumer can invoke provider successfully.
### Actual Result
The invoke fails
If there is an exception, please attach the exception trace:
```
org.apache.cxf.interceptor.Fault: Could not send Message.
at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSenderInterceptor.java:67)
at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.endpoint.ClientImpl.doInvoke(ClientImpl.java:530)
at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:441)
at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:356)
at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:314)
at org.apache.cxf.frontend.ClientProxy.invokeSync(ClientProxy.java:96)
at org.apache.cxf.frontend.ClientProxy.invoke(ClientProxy.java:81)
at com.sun.proxy.$Proxy32.hello(Unknown Source)
at org.apache.dubbo.common.bytecode.Wrapper0.invokeMethod(Wrapper0.java)
at org.apache.dubbo.rpc.proxy.javassist.JavassistProxyFactory$1.doInvoke(JavassistProxyFactory.java:47)
at org.apache.dubbo.rpc.proxy.AbstractProxyInvoker.invoke(AbstractProxyInvoker.java:84)
at org.apache.dubbo.rpc.protocol.AbstractProxyProtocol$2.doInvoke(AbstractProxyProtocol.java:113)
at org.apache.dubbo.rpc.protocol.AbstractInvoker.invoke(AbstractInvoker.java:163)
at org.apache.dubbo.rpc.protocol.AsyncToSyncInvoker.invoke(AsyncToSyncInvoker.java:52)
at org.apache.dubbo.rpc.listener.ListenerInvokerWrapper.invoke(ListenerInvokerWrapper.java:78)
at org.apache.dubbo.monitor.support.MonitorFilter.invoke(MonitorFilter.java:89)
at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:81)
at org.apache.dubbo.rpc.protocol.dubbo.filter.FutureFilter.invoke(FutureFilter.java:51)
at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:81)
at org.apache.dubbo.rpc.filter.ConsumerContextFilter.invoke(ConsumerContextFilter.java:69)
at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper$1.invoke(ProtocolFilterWrapper.java:81)
at org.apache.dubbo.rpc.protocol.InvokerWrapper.invoke(InvokerWrapper.java:56)
at org.apache.dubbo.rpc.cluster.support.FailoverClusterInvoker.doInvoke(FailoverClusterInvoker.java:82)
at org.apache.dubbo.rpc.cluster.support.AbstractClusterInvoker.invoke(AbstractClusterInvoker.java:259)
at org.apache.dubbo.rpc.cluster.interceptor.ClusterInterceptor.intercept(ClusterInterceptor.java:47)
at org.apache.dubbo.rpc.cluster.support.wrapper.AbstractCluster$InterceptorInvokerNode.invoke(AbstractCluster.java:92)
at org.apache.dubbo.rpc.cluster.support.wrapper.MockClusterInvoker.invoke(MockClusterInvoker.java:82)
at org.apache.dubbo.rpc.proxy.InvokerInvocationHandler.invoke(InvokerInvocationHandler.java:74)
at org.apache.dubbo.common.bytecode.proxy0.hello(proxy0.java)
at org.apache.dubbo.samples.webservice.consumer.Application.main(Application.java:27)
Caused by: org.apache.cxf.transport.http.HTTPException: HTTP response '404: null' when communicating with http://127.0.0.1:8083/dubbo_samples_webservice_provider_war/services/org.apache.dubbo.samples.webservice.DemoService
at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.doProcessResponseCode(HTTPConduit.java:1618)
at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponseInternal(HTTPConduit.java:1625)
at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.handleResponse(HTTPConduit.java:1570)
at org.apache.cxf.transport.http.HTTPConduit$WrappedOutputStream.close(HTTPConduit.java:1371)
at org.apache.cxf.transport.AbstractConduit.close(AbstractConduit.java:56)
at org.apache.cxf.transport.http.HTTPConduit.close(HTTPConduit.java:671)
at org.apache.cxf.interceptor.MessageSenderInterceptor$MessageSenderEndingInterceptor.handleMessage(MessageSenderInterceptor.java:63)
... 30 more
```
In fact, the wsdl url is
http://localhost:8083/dubbo_samples_webservice_provider_war/services/dubbo_samples_webservice_provider_war/services/org.apache.dubbo.samples.webservice.DemoService?wsdl
**It's because the consumer cannot get the provider container context path and the servlet pattern defined in the provider.** | https://github.com/apache/dubbo/issues/6497 | https://github.com/apache/dubbo/pull/6498 | ae3dca5bbf0a5ad0c983eb5e7f1e2147faa5975b | d41bfaba21f55018669423469a7801fdbfc21c9a | 2020-07-18T17:38:43Z | java | 2020-07-22T05:08:19Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,494 | ["dubbo-rpc/dubbo-rpc-webservice/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.Protocol"] | [Bug]Spi file of WebServiceProtocol is wrong | The content of the spi file of WebServiceProtocol is wrong, it does not comply with the Spi system of Dubbo.
| https://github.com/apache/dubbo/issues/6494 | https://github.com/apache/dubbo/pull/6495 | fb5761683729f63c715e39c78a8b7b75278050c9 | ae3dca5bbf0a5ad0c983eb5e7f1e2147faa5975b | 2020-07-17T19:44:44Z | java | 2020-07-21T13:05:28Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,449 | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java"] | [Bug]NPE when unexport Metadata Services if the set of Metadata Service is null | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.8-SNAPSHOT
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
1. Do not start zookeeper server, which is used as a metadata center
2. start a provider
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
The app exit normally
### Actual Result
The app exit with a NPE
If there is an exception, please attach the exception trace:
```
Exception in thread "DubboShutdownHook" java.lang.RuntimeException: java.lang.NullPointerException
at org.apache.dubbo.common.function.ThrowableAction.execute(ThrowableAction.java:48)
at org.apache.dubbo.common.lang.ShutdownHookCallbacks.lambda$callback$0(ShutdownHookCallbacks.java:70)
at java.base/java.lang.Iterable.forEach(Iterable.java:75)
at org.apache.dubbo.common.lang.ShutdownHookCallbacks.callback(ShutdownHookCallbacks.java:70)
at org.apache.dubbo.config.DubboShutdownHook.callback(DubboShutdownHook.java:85)
at org.apache.dubbo.config.DubboShutdownHook.run(DubboShutdownHook.java:73)
Caused by: java.lang.NullPointerException
at org.apache.dubbo.config.bootstrap.DubboBootstrap.unexportMetadataService(DubboBootstrap.java:1009)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.destroy(DubboBootstrap.java:1188)
at org.apache.dubbo.config.bootstrap.DubboBootstrap$1.callback(DubboBootstrap.java:198)
at org.apache.dubbo.common.function.ThrowableAction.execute(ThrowableAction.java:46)
... 5 more
```
| https://github.com/apache/dubbo/issues/6449 | https://github.com/apache/dubbo/pull/6450 | 58d5e519af824f7d08dfa5c68e0403546f1fba9f | a2e5102657a8abe03812f0b025f457ca3d994921 | 2020-07-11T10:17:25Z | java | 2020-07-13T08:22:42Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,443 | ["dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/Exchangers.java", "dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/header/HeaderExchangeClient.java", "dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/transport/AbstractClient.java", "dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/Constants.java", "dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/LazyConnectExchangeClient.java", "dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/ReferenceCountExchangeClient.java", "dubbo-rpc/dubbo-rpc-dubbo/src/test/java/org/apache/dubbo/rpc/protocol/dubbo/DubboInvokerAvailableTest.java", "dubbo-rpc/dubbo-rpc-dubbo/src/test/java/org/apache/dubbo/rpc/protocol/dubbo/DubboLazyConnectTest.java"] | 支持直连模式下，在连接不可用时的快速失败 | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.3
* Operating System version: macOS
* Java version: 1.8
### Steps to reproduce this issue
1. 服务端打开dubbo协议，并监听8080端口
2. 客户端通过dubbo作为代理，以直连的方式与服务端建立连接。
```
String url="dubbo://127.0.0.1:20880"
ReferenceConfig<DemoService> referenceConfig = new ReferenceConfig<>();
referenceConfig.setInterface(DemoService.class);
referenceConfig.setUrl(url);
```
3. 客户端跟服务端的网络出现问题，请求无法到达服务端。
原因：
为了避免并发请求重复创建线程，Netty在建连的时候时加锁的。
org.apache.dubbo.remoting.transport.netty.NettyClient
```
@Override
protected void doConnect() throws Throwable {
long start = System.currentTimeMillis();
ChannelFuture future = bootstrap.connect(getConnectAddress());
try {
boolean ret = future.awaitUninterruptibly(getConnectTimeout(), TimeUnit.MILLISECONDS);
...
} finally {
}
}
```
org.jboss.netty.channel.DefaultChannelFuture
```
private boolean await0(long timeoutNanos, boolean interruptable) throws InterruptedException {
try {
synchronized (this) {
try {
for (;;) {
try {
this.wait(waitTime / 1000000, (int) (waitTime % 1000000));
} catch (InterruptedException e) {
}
}
} finally {
}
}
} finally {
}
}
```
从调用的堆栈中可以发现，在请求发送之前会检查当前连接是否可用，如果不可用就会重新建连。
假设同时进来了100个请求，第一个请求发现连接不可用需要重新建连，由于服务端不可达，就会一直持有连接的锁，直到3s超时之后才会释放锁。那么，第100个请求等待的时候就是100*3=300s，会导致线程被大量阻塞。
```
at org.apache.dubbo.remoting.transport.netty.NettyClient.doConnect(NettyClient.java:130)
at org.apache.dubbo.remoting.transport.AbstractClient.connect(AbstractClient.java:189)
at org.apache.dubbo.remoting.transport.AbstractClient.<init>(AbstractClient.java:71)
at org.apache.dubbo.remoting.transport.netty.NettyClient.<init>(NettyClient.java:59)
at org.apache.dubbo.remoting.transport.netty.NettyTransporter.connect(NettyTransporter.java:37)
at com.ctrip.framework.cdubbo.internal.delegate.CDubboTransporterDelegate.connect(CDubboTransporterDelegate.java:25)
at org.apache.dubbo.remoting.Transporter$Adaptive.connect(Transporter$Adaptive.java)
at org.apache.dubbo.remoting.Transporters.connect(Transporters.java:75)
at org.apache.dubbo.remoting.exchange.support.header.HeaderExchanger.connect(HeaderExchanger.java:39)
at org.apache.dubbo.remoting.exchange.Exchangers.connect(Exchangers.java:109)
at org.apache.dubbo.rpc.protocol.dubbo.LazyConnectExchangeClient.initClient(LazyConnectExchangeClient.java:83)
at org.apache.dubbo.rpc.protocol.dubbo.LazyConnectExchangeClient.request(LazyConnectExchangeClient.java:127)
```
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
对于直连模式，在出现服务端连接不可用的情况下，能够支持快速失败。
### Actual Result
对于直连模式，在出现服务端连接不可用的情况下，会导致线程阻塞。
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/6443 | https://github.com/apache/dubbo/pull/9507 | 431f2a7e77a2bd5decea67575bb288533157c5a0 | d1cd33bee80df038221b787a8f4590fe2d16e9fe | 2020-07-10T10:08:05Z | java | 2022-01-23T08:48:37Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,428 | ["dubbo-compatible/src/main/java/com/alibaba/dubbo/common/extension/ExtensionFactory.java"] | dubbo-compatible @SPI interface compatible not work | * Dubbo version: 2.7.7
EG:
SPI interface in apache dubbo
```
package org.apache.dubbo.common.extension;
/**
* ExtensionFactory
*/
@SPI
public interface ExtensionFactory {
...
}
```
compatible class with alibaba dubbo
```
package com.alibaba.dubbo.common.extension;
@Deprecated
public interface ExtensionFactory extends org.apache.dubbo.common.extension.ExtensionFactory {
}
```
Not ADD @SPI annotation
``` java
public static <T> ExtensionLoader<T> getExtensionLoader(Class<T> type) {
.....
if (!withExtensionAnnotation(type)) {
throw new IllegalArgumentException("Extension type (" + type +
") is not an extension, because it is NOT annotated with @" + SPI.class.getSimpleName() + "!");
}
....
return loader;
}
```
In ExtensionLoader#getExtensionLoader will check failed and throw Exception.
BTW, ExtensionLoader not provided compatible class.
| https://github.com/apache/dubbo/issues/6428 | https://github.com/apache/dubbo/pull/6436 | a243906127849791c8412ac1c136078e76b20279 | 40d03b081e8a8f74fb5092163e51bdd17842cb5a | 2020-07-08T03:01:00Z | java | 2020-07-09T02:42:51Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,350 | ["dubbo-configcenter/dubbo-configcenter-consul/src/main/java/org/apache/dubbo/configcenter/consul/ConsulDynamicConfiguration.java", "dubbo-configcenter/dubbo-configcenter-consul/src/test/java/org/apache/dubbo/configcenter/consul/ConsulDynamicConfigurationTest.java"] | [Bug]Consul config center can not publish config correncly | The code of Method publishConfig of Class ConsulDynamicConfiguration:
```java
@Override
public boolean publishConfig(String key, String group, String content) throws UnsupportedOperationException {
String normalizedKey = convertKey(group, key);
return kvClient.putValue(normalizedKey + PATH_SEPARATOR + content);
}
```
We want put a config with value with the "content", but the method just add the "content" to the key and put a null value. | https://github.com/apache/dubbo/issues/6350 | https://github.com/apache/dubbo/pull/6351 | 1e51703f8f2d8932b839380fe1d24aa584dc0b4e | 5230444d5f83e586ce759d15e02ee799cf6241e7 | 2020-06-19T15:51:22Z | java | 2020-06-20T16:12:40Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,348 | ["dubbo-monitor/dubbo-monitor-api/src/main/java/org/apache/dubbo/monitor/support/MonitorFilter.java", "dubbo-monitor/dubbo-monitor-api/src/test/java/org/apache/dubbo/monitor/support/MonitorFilterTest.java"] | 回声测试异常NumberFormatException | ### Environment
* Dubbo version: 2.7.3
* Operating System version: linux
* Java version:1.8
### Steps to reproduce this issue
带"monitor"参数进行回声测试时抛返回异常
ause: org.apache.dubbo.remoting.RemotingException: java.util.concurrent.CompletionException: java.lang.NumberFormatException: null java.util.concurrent.CompletionException: java.lang.NumberFormatException: null at
抛异常的位置在MonitorFilter的onResponse
大致原因：
EchoFilter在MonitorFilter之前执行并终止Invoker链，导致MonitorFilter没有执行，invocation没有设置key“monitor_filter_start_time” | https://github.com/apache/dubbo/issues/6348 | https://github.com/apache/dubbo/pull/9108 | 3bfa4f5c8bdfea5ecb834cdefb6e924534fe9bc7 | 18e8645d8301f110b2ab33f9fef1a0289578c567 | 2020-06-19T14:41:59Z | java | 2021-10-25T04:38:32Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,340 | ["dubbo-registry/dubbo-registry-consul/src/main/java/org/apache/dubbo/registry/consul/ConsulRegistry.java"] | [Bug]Application cannot exit when use consul registry | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.x
* Operating System version: Mac OS
* Java version: N/A
### Steps to reproduce this issue
Run dubbo-demo project
1. Use consul as registry center
2. Start provider
3. Start consumer
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
The consumer can exit as usual
### Actual Result
The consumer cannot exit.
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/6340 | https://github.com/apache/dubbo/pull/6341 | 3ef35a1c0d98b27f05051442176e2536a9ca352a | c4f11fc25e7e11b29ca543cf691e4d084bb76cd5 | 2020-06-17T17:09:12Z | java | 2020-06-18T12:36:40Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,269 | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/utils/ConfigValidationUtils.java"] | 自定义ExportListener，并在dubbo:service中配置listener为该自定义的ExportListener，服务启动失败 | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.6
* Operating System version: mac 10.15
* Java version: 1.8.0.231
### Steps to reproduce this issue
1. spring boot应用中自定义ExportListener SPI扩展，记为X
2. 在dubbo:service中设置listener为XXX
3. 启动spring boot应用
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps？
应用正常启动
### Actual Result
What actually happens?
异常堆栈如下，我跟踪了一下代码执行，问题出在org.apache.dubbo.config.utils.ConfigValidationUtils#validateServiceConfig方法中，先校验了一次ExporterListener.class的扩展点，而后在validateAbstractInterfaceConfig(config)中，针对同一个ServiceConfig校验了一次 InvokerListener.class的扩展。这个地方我感觉有问题，因为我是针对dubbo:service设置的ExporterListener，而InvokerListener因为是针对dubbo:reference的，为何针对dubbo:service也去校验InvokerListener扩展呢？
java.lang.IllegalStateException: No such extension XXX for listener/org.apache.dubbo.rpc.InvokerListener
at org.apache.dubbo.config.utils.ConfigValidationUtils.checkMultiExtension(ConfigValidationUtils.java:531)
at org.apache.dubbo.config.utils.ConfigValidationUtils.validateAbstractInterfaceConfig(ConfigValidationUtils.java:299)
at org.apache.dubbo.config.utils.ConfigValidationUtils.validateServiceConfig(ConfigValidationUtils.java:316)
at org.apache.dubbo.config.ServiceConfig.checkAndUpdateSubConfigs(ServiceConfig.java:283)
at org.apache.dubbo.config.ServiceConfig.export(ServiceConfig.java:193)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.lambda$exportServices$15(DubboBootstrap.java:917)
at java.util.HashMap$Values.forEach(HashMap.java:981)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.exportServices(DubboBootstrap.java:905)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:745)
at org.apache.dubbo.config.spring.context.DubboBootstrapApplicationListener.onContextRefreshedEvent(DubboBootstrapApplicationListener.java:59)
at org.apache.dubbo.config.spring.context.DubboBootstrapApplicationListener.onApplicationContextEvent(DubboBootstrapApplicationListener.java:52)
at org.apache.dubbo.config.spring.context.OneTimeExecutionApplicationContextEventListener.onApplicationEvent(OneTimeExecutionApplicationContextEventListener.java:40)
at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:172)
at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:165)
at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:403)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:360)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:897)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.finishRefresh(ServletWebServerApplicationContext.java:162)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:553)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:141)
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:747)
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:315)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1226)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1215)
at cn.edu.bupt.Starter.main(Starter.java:18)
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/6269 | https://github.com/apache/dubbo/pull/6271 | 9cd30867c10a28e4b52fba8d271ecf58da04454b | 91989cae508f8482f31ac335879da4a5975661c8 | 2020-06-04T07:27:51Z | java | 2020-06-08T13:25:10Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,207 | ["dubbo-remoting/dubbo-remoting-netty/src/main/java/org/apache/dubbo/remoting/transport/netty/NettyBackedChannelBuffer.java", "dubbo-remoting/dubbo-remoting-netty/src/test/java/org/apache/dubbo/remoting/transport/netty/NettyBackedChannelBufferTest.java", "dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyBackedChannelBuffer.java", "dubbo-remoting/dubbo-remoting-netty4/src/test/java/org/apache/dubbo/remoting/transport/netty4/NettyBackedChannelBufferTest.java"] | is there a problem in NettyBackedChannelBuffer.setBytes(...)? | hi,I see the code for method setBytes in class com.alibaba.dubbo.remoting.transport.netty4.NettyBackedChannelBuffer.java which is below,is there a problem ?
org.apache.dubbo.remoting.transport.netty4.NettyBackedChannelBuffer
[https://github.com/apache/dubbo/blob/master/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyBackedChannelBuffer.java](url)
I think this method is Transfering the specified source buffer's data to this buffer starting at
the specified absolute as description of the method, but it have nothing to do with param: src.
Should be like below？
| https://github.com/apache/dubbo/issues/6207 | https://github.com/apache/dubbo/pull/9174 | dc8ba019dcf913c3e8294f4f6a340357eddab787 | dee5181645036f3bbaca9cc9492e9ccd3c2b700e | 2020-05-24T08:44:21Z | java | 2021-12-16T06:39:14Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,093 | ["dubbo-common/src/test/java/org/apache/dubbo/common/config/configcenter/AbstractDynamicConfigurationTest.java"] | 发PR时，Travis CI build failed | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Steps to reproduce this issue
1. 提交PR，Travis CI build failed，原因为单元测试不通过
2. 单元测试要求直接报异常
3. 5月1号解决[#5916]时，将默认方法修改了，现在不会报异常出来
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
Travis CI build 可以通过
| https://github.com/apache/dubbo/issues/6093 | https://github.com/apache/dubbo/pull/6094 | 2d0d71385d2cd26b97e07c699f84cd58b862cef9 | b2e6d512e328c41d3756d9e324bd2b4499b8a3e0 | 2020-05-02T06:14:00Z | java | 2020-05-06T04:25:37Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 6,090 | ["dubbo-common/src/main/java/org/apache/dubbo/config/annotation/DubboReference.java", "dubbo-common/src/main/java/org/apache/dubbo/config/annotation/Method.java"] | 基于注解方式不支持merger调用 | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.5
* Operating System version: win10
* Java version: 1.8
### Steps to reproduce this issue
1. 基于xml的方式可以对分组方法进行merger调用
2. 但是基于注解方式`@Reference`或`@Method`都不支持指定merger
### Expected Result
可以通过`@Reference`或`@Method`指定merger | https://github.com/apache/dubbo/issues/6090 | https://github.com/apache/dubbo/pull/6092 | 6140f5f9eb4d7eb141e7910caeceb564b919b58b | 4d3316b87d18d37ce982928052fd5451f63cea92 | 2020-05-02T05:08:38Z | java | 2020-05-07T03:10:30Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,988 | ["dubbo-config/dubbo-config-api/pom.xml", "dubbo-dependencies-bom/pom.xml"] | @Reference断点调试报错java.lang.reflect.InvocationTargetException: null，未加断点正常 | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.6.2
* Operating System version: MAC
* Java version: 1.8.0_162
### Steps to reproduce this issue
1. 通过url直连的方式引用远程服务
`@Reference(url = "172.16.105.142:20082")
private IUser userService;`
2. 如果不加断点调试，userService可以正常rpc调用
断点加载其他位置也正常，但是我在AbstractAnnotationConfigBeanBuilder这个类中加上一个断点调试之后，报错
AbstractAnnotationConfigBeanBuilder#build
` public final B build() throws Exception {
checkDependencies();
B bean = doBuild();
configureBean(bean);
if (logger.isInfoEnabled()) {
logger.info(bean + " has been built.");
}
return bean;
}`
断点的位置为configureBean(bean);这一行。然后通过debug的模式运行到这一行之后，报错，继续运行会导致服务userService在之后的程序中为null
### Expected Result
预期结果：不报错，userService不为空
### Actual Result
错误栈如下：
```
> java.lang.reflect.InvocationTargetException: null
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_162]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_162]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_162]
at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_162]
at com.alibaba.dubbo.config.AbstractConfig.toString(AbstractConfig.java:474) ~[dubbo-2.6.2.jar:2.6.2]
at com.alibaba.dubbo.config.spring.beans.factory.annotation.AbstractAnnotationConfigBeanBuilder.build(AbstractAnnotationConfigBeanBuilder.java:76) [dubbo-2.6.2.jar:2.6.2]
at com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.buildReferenceBean(ReferenceAnnotationBeanPostProcessor.java:385) [dubbo-2.6.2.jar:2.6.2]
at com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.access$100(ReferenceAnnotationBeanPostProcessor.java:65) [dubbo-2.6.2.jar:2.6.2]
at com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor$ReferenceFieldElement.inject(ReferenceAnnotationBeanPostProcessor.java:363) [dubbo-2.6.2.jar:2.6.2]
at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:90) [spring-beans-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at com.alibaba.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor.postProcessPropertyValues(ReferenceAnnotationBeanPostProcessor.java:92) [dubbo-2.6.2.jar:2.6.2]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1416) [spring-beans-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:592) [spring-beans-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:515) [spring-beans-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320) [spring-beans-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222) ~[spring-beans-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318) [spring-beans-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199) [spring-beans-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:845) ~[spring-beans-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:877) ~[spring-context-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:549) ~[spring-context-5.1.8.RELEASE.jar:5.1.8.RELEASE]
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:140) ~[spring-boot-2.1.6.RELEASE.jar:2.1.6.RELEASE]
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:742) ~[spring-boot-2.1.6.RELEASE.jar:2.1.6.RELEASE]
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:389) ~[spring-boot-2.1.6.RELEASE.jar:2.1.6.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:311) ~[spring-boot-2.1.6.RELEASE.jar:2.1.6.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1213) ~[spring-boot-2.1.6.RELEASE.jar:2.1.6.RELEASE]
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1202) ~[spring-boot-2.1.6.RELEASE.jar:2.1.6.RELEASE]
at com.example.demo.DemoApplication.main(DemoApplication.java:12) ~[classes/:na]
Caused by: java.lang.IllegalStateException: <dubbo:reference interface="" /> interface not allow null!
at com.alibaba.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:191) ~[dubbo-2.6.2.jar:2.6.2]
at com.alibaba.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:163) ~[dubbo-2.6.2.jar:2.6.2]
at com.alibaba.dubbo.config.spring.ReferenceBean.getObject(ReferenceBean.java:66) ~[dubbo-2.6.2.jar:2.6.2]
... 28 common frames omitted
```
| https://github.com/apache/dubbo/issues/5988 | https://github.com/apache/dubbo/pull/11367 | 1d8e896970a6b9e51d7cd94f2bc2580a22a1634c | 7439ae40b585ad2297153d636e7706fe922954ab | 2020-04-09T12:39:49Z | java | 2023-01-28T03:22:49Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,978 | ["dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java"] | dubbo nacos版本的服务发现 dubbo.registry.group配置无效 | ### Environment
* Dubbo version: dubbo-registry-nacos 2.7.6
* Operating System version: Win10
* Java version: JAVA 8
### Steps to reproduce this issue
1 springboot yml配置如下：
registry:
address: nacos://127.0.0.1:8848
simplified: true
group: dubbo-local
metadata-report:
address: nacos://127.0.0.1:8848
group: dubbo-local
2 登陆nacos 1.2.1 控制台发现元数据 group配置生效，但是服务管理下的group依旧是DEFAULT_GROUP。
3 跟了下dubbo-registry-nacos 2.7.6的代码 发现在调用NamingService中 没有传入配置的group参数，使用的默认组参数
public void doRegister(URL url) {
String serviceName = this.getServiceName(url);
Instance instance = this.createInstance(url);
this.execute((namingService) -> {
namingService.registerInstance(serviceName, instance);
});
}
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps？
### Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
| https://github.com/apache/dubbo/issues/5978 | https://github.com/apache/dubbo/pull/5997 | 78aeadc48348f5b36862db6a16adf8226d23a2f4 | acd6e87ddeba5ea2a491b04799cd55e2dce2541f | 2020-04-07T08:42:02Z | java | 2020-04-28T09:03:19Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,976 | ["dubbo-spring-boot/dubbo-spring-boot-starters/observability/pom.xml"] | No application config found or it's not a valid config | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.6
* Operating System version: macos 10.15.13
* Java version: xxx
### Steps to reproduce this issue
1. Spring boot 1.5.2 ,when update dubbo 2.5.3 to 2.7.6 ，I have some problems
2. my config is <dubbo:application name="indicatiors" owner="xxx"/>
3. No application config found or it's not a valid config! Please add <dubbo:application name="..." />
只在特定的项目里面发生这个问题，但是整体的环境都是一样的
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps？
### Actual Result
run error
the exception trace:
```
Caused by: java.lang.IllegalStateException: No application config found or it's not a valid config! Please add <dubbo:application name="..." /> to your spring config.
at org.apache.dubbo.config.utils.ConfigValidationUtils.validateApplicationConfig(ConfigValidationUtils.java:371)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.checkGlobalConfigs(DubboBootstrap.java:526)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.initialize(DubboBootstrap.java:513)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.init(DubboBootstrap.java:494)
at org.apache.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:190)
at org.apache.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:158)
at org.apache.dubbo.config.spring.ReferenceBean.getObject(ReferenceBean.java:68)
at org.springframework.beans.factory.support.FactoryBeanRegistrySupport.doGetObjectFromFactoryBean(FactoryBeanRegistrySupport.java:168)
... 64 common frames omitted
```
| https://github.com/apache/dubbo/issues/5976 | https://github.com/apache/dubbo/pull/13392 | 77bf43d40c808a9d80c58f17f669a185a4fcd513 | 6378c144f8ddf0888b00d03308f225a1053f33c1 | 2020-04-07T02:41:01Z | java | 2023-11-21T02:22:08Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,957 | ["dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/event/ThreadPoolExhaustedEvent.java", "dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/support/AbortPolicyWithReport.java", "dubbo-common/src/test/java/org/apache/dubbo/common/threadpool/event/ThreadPoolExhaustedEventListenerTest.java", "dubbo-common/src/test/java/org/apache/dubbo/common/threadpool/event/ThreadPoolExhaustedEventTest.java"] | [Feature] publish event when thread pool exhausted | add ThreadPoolExhaustedEvent and publish it in AbortPolicyWithReport.rejectedExecution method
user can listen ThreadPoolExhaustedEvent to do some alert | https://github.com/apache/dubbo/issues/5957 | https://github.com/apache/dubbo/pull/5958 | 0ba92ea14af85b0261a6f153ae5309fedd1c4b2a | cfee3f835ab6634600ff8f23b8fd313a98cb05a9 | 2020-04-01T05:23:29Z | java | 2020-04-01T14:39:02Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,948 | ["dubbo-common/src/main/java/org/apache/dubbo/common/URL.java", "dubbo-common/src/test/java/org/apache/dubbo/common/utils/UrlUtilsTest.java"] | default. 导致的高版本与低版本间的服务发现问题（default.version default.group） | lower version, for example 2.6.8
```properties
dubbo.provider.version=1.0
```
2.7.6 failed to recognize the provider url with 'default.version=1.0' key, it only takes 'version.1.0' into consideration.
| https://github.com/apache/dubbo/issues/5948 | https://github.com/apache/dubbo/pull/5950 | 4dd5a0db57dec56716a7da146661866be5d05f77 | abd6e36991390a95fa0b3094249eb860c3ea6dd5 | 2020-03-31T10:11:36Z | java | 2020-04-03T04:38:28Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,947 | ["dubbo-common/src/main/java/org/apache/dubbo/common/utils/ReflectUtils.java", "dubbo-common/src/main/java/org/apache/dubbo/config/context/ConfigManager.java", "dubbo-common/src/test/java/org/apache/dubbo/config/context/ConfigManagerTest.java"] | 使用默认 protocol 配置的问题 | 
dubbo 2.7.3， 同时暴露rest和dubbo，com.alibaba.dubbo.samples.echo.api.EchoService这个接口是dubbo协议的，还是当做rest来暴露？
| https://github.com/apache/dubbo/issues/5947 | https://github.com/apache/dubbo/pull/5952 | 5d6ca6234f64a670fed2f3c5fdc1d0dba74a9c88 | b37a05d4e4db138278d4d524de32a8defea5cc21 | 2020-03-31T10:10:29Z | java | 2020-04-03T11:31:16Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,939 | ["dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java", "dubbo-common/src/test/java/org/apache/dubbo/common/utils/PojoUtilsTest.java", "dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/legacy/InvokerTelnetHandlerTest.java", "dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/legacy/service/DemoService.java", "dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/legacy/service/DemoServiceImpl.java"] | telnet issue | ### Environment
* Dubbo version: 2.7.4.1
* Operating System version: macOS Catalina Version 10.15.3
* Java version: 1.8.0_231
### Steps to reproduce this issue
1. 通过telnet调用接口如下
方法(Method)
`public String convert7(UserInfoCondition userInfoCondition) { }`
参数(Parameter)
`public class UserInfoCondition {
private List<Map<Integer, UserInfo>> userList;
}`
`public class UserInfo {
private String accountMobile;
private String userPassword;
}`
invoke UsesrInfoFacade.convert7({"userList":[{"1":{"accountMobile":"15052234567"}}]})
or
invoke UsesrInfoFacade.convert7({"userList":[{1:{"accountMobile":"15052234567"}}]})
提示如下错误(has a problem)
到底如何书写这个入参呢?(How to write the parameters)
| https://github.com/apache/dubbo/issues/5939 | https://github.com/apache/dubbo/pull/6106 | e0d031ec16a3a01ab44dc0fcd66c4e45dd953fbb | bbacab0b32b74ba4beb90f9100980b184ac70c71 | 2020-03-30T08:47:07Z | java | 2020-06-30T07:36:08Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,932 | ["dubbo-spring-boot/dubbo-spring-boot-starters/observability/pom.xml"] | 按照路由扩展的文档自定义路由后，怎么让路由生效，是不是要往注册中心写一些东西，这部分在文档里没有说明 | 按照路由扩展的文档自定义路由后，怎么让路由生效，是不是要往注册中心写一些东西，这部分在文档里没有说明 | https://github.com/apache/dubbo/issues/5932 | https://github.com/apache/dubbo/pull/13392 | 77bf43d40c808a9d80c58f17f669a185a4fcd513 | 6378c144f8ddf0888b00d03308f225a1053f33c1 | 2020-03-28T00:32:53Z | java | 2023-11-21T02:22:08Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,916 | ["dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/DynamicConfiguration.java"] | Change default behaviour of DynamicConfiguration.publishConfig: do nothing if not implemented. | do nothing if not implemented, instead of throw exception. | https://github.com/apache/dubbo/issues/5916 | https://github.com/apache/dubbo/pull/6086 | 04fc3ce4cc87b9bd09546c12df3f8762b9525da9 | 2d0d71385d2cd26b97e07c699f84cd58b862cef9 | 2020-03-25T06:15:27Z | java | 2020-05-01T08:15:02Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,911 | ["dubbo-spring-boot/dubbo-spring-boot-starters/observability/pom.xml"] | dubbo部署到k8s, 连接外部的ZK, 外部dubbo连接ZK发现地址不通 | 我们的环境是dubbo去服务治理（zookeeper）注册，应用有复杂的调用关系，只有部分应用可以放到k8s下，这种情况下，dubbo注册的是容器的地址，外部服务的消费者取到容器地址有无法访问。 这种环境下，有什么办法解决？ | https://github.com/apache/dubbo/issues/5911 | https://github.com/apache/dubbo/pull/13071 | a0f229935d9489255730a9f3f325b832c283a6ce | dcf4cff51bc9b4fadc0cb0d36a74a74e299c8a54 | 2020-03-24T07:28:57Z | java | 2023-09-20T01:42:23Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,877 | ["dubbo-spring-boot/dubbo-spring-boot-starters/observability/pom.xml"] | unable to build dubbo-common ( unit test fail in AdaptiveClassCodeGeneratorTest ) | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.5
* Operating System version: Windows 10 1903
* Java version: 1.8.0_221
### Steps to reproduce this issue
1. in root folder execute "mvn clean test"
### Expected Result
pass unit test
### Actual Result
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at org.apache.dubbo.common.extension.AdaptiveClassCodeGeneratorTest.testGenerate(AdaptiveClassCodeGeneratorTest.java:45)
### Any try
the souce of is AdaptiveClassCodeGeneratorTest
```
public class AdaptiveClassCodeGeneratorTest {
@Test
public void testGenerate() throws IOException {
AdaptiveClassCodeGenerator generator = new AdaptiveClassCodeGenerator(HasAdaptiveExt.class, "adaptive");
String value = generator.generate();
URL url = getClass().getResource("/org/apache/dubbo/common/extension/adaptive/HasAdaptiveExt$Adaptive");
try (InputStream inputStream = url.openStream()) {
String content = IOUtils.read(new InputStreamReader(inputStream, "UTF-8"));
assertTrue(content.contains(value));
}
}
}
```
When I add the following code to it, the unit pass.
```
value = value.replace("\r","");
value = value.replace("\n","");
content = content.replace("\r","");
content = content.replace("\n","");
``` | https://github.com/apache/dubbo/issues/5877 | https://github.com/apache/dubbo/pull/13168 | 7ecb1814f571a1f49abffc10a98d8e749c3a0d26 | 25ea56b7b8be24fba3d020b80ee0f4cd93a626b7 | 2020-03-16T15:53:00Z | java | 2023-10-09T09:19:22Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,876 | ["dubbo-common/src/main/java/org/apache/dubbo/common/config/Environment.java", "dubbo-metadata/dubbo-metadata-processor/src/main/java/org/apache/dubbo/metadata/annotation/processing/rest/ServiceRestMetadataStorage.java"] | Remove unused variable in Environment.java and ServiceRestMetadataStorage.jar | Two code reported by LGTM, those issues need investigate
https://lgtm.com/projects/g/apache/dubbo/snapshot/001162d4f461e28561b01e2f90b15c1627706cf7/files/dubbo-common/src/main/java/org/apache/dubbo/common/config/Environment.java?sort=name&dir=ASC&mode=heatmap
https://lgtm.com/projects/g/apache/dubbo/snapshot/001162d4f461e28561b01e2f90b15c1627706cf7/files/dubbo-metadata/dubbo-metadata-processor/src/main/java/org/apache/dubbo/metadata/annotation/processing/rest/ServiceRestMetadataStorage.java?sort=name&dir=ASC&mode=heatmap | https://github.com/apache/dubbo/issues/5876 | https://github.com/apache/dubbo/pull/5879 | 40e14a5599379960273c8f21a08d0cd9233d0f23 | 40be2972e326c816a154e4dec7dea1a3fc625a2e | 2020-03-16T13:45:51Z | java | 2020-03-28T15:44:04Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,871 | ["dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java", "dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/util/NacosInstanceManageUtil.java"] | Consumer will lose subscribed service information when use Nacos as registry center | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.7-SNAPSHOT
* Operating System version: MacOS
* Java version: OpenJDK 13
### Steps to reproduce this issue
1. Open the dubbo-demo-xml project
2. Modify the registry center both of provider and consumer to Nacos；Open the check switch of consumer
3. Run the provider
4.Run the consumer
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
The rpc can work properly.
### Actual Result
It fails.
If there is an exception, please attach the exception trace:
```
Exception in thread "main" org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'demoService': FactoryBean threw exception on object creation; nested exception is java.lang.IllegalStateException: Failed to check the status of the service org.apache.dubbo.demo.DemoService. No provider available for the service org.apache.dubbo.demo.DemoService from the url nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=demo-consumer&dubbo=2.0.2&init=false&interface=org.apache.dubbo.demo.DemoService&methods=sayHello,sayHelloAsync&pid=90344&qos.port=33333®ister.ip=127.0.0.1&side=consumer&sticky=false×tamp=1584323664330 to the consumer 127.0.0.1 use dubbo version
at org.springframework.beans.factory.support.FactoryBeanRegistrySupport.doGetObjectFromFactoryBean(FactoryBeanRegistrySupport.java:177)
at org.springframework.beans.factory.support.FactoryBeanRegistrySupport.getObjectFromFactoryBean(FactoryBeanRegistrySupport.java:103)
at org.springframework.beans.factory.support.AbstractBeanFactory.getObjectForBeanInstance(AbstractBeanFactory.java:1640)
at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:254)
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
at org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1086)
at org.apache.dubbo.demo.consumer.Application.main(Application.java:33)
Caused by: java.lang.IllegalStateException: Failed to check the status of the service org.apache.dubbo.demo.DemoService. No provider available for the service org.apache.dubbo.demo.DemoService from the url nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=demo-consumer&dubbo=2.0.2&init=false&interface=org.apache.dubbo.demo.DemoService&methods=sayHello,sayHelloAsync&pid=90344&qos.port=33333®ister.ip=127.0.0.1&side=consumer&sticky=false×tamp=1584323664330 to the consumer 127.0.0.1 use dubbo version
at org.apache.dubbo.config.ReferenceConfig.createProxy(ReferenceConfig.java:350)
at org.apache.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:258)
at org.apache.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:158)
at org.apache.dubbo.config.spring.ReferenceBean.getObject(ReferenceBean.java:68)
at org.springframework.beans.factory.support.FactoryBeanRegistrySupport.doGetObjectFromFactoryBean(FactoryBeanRegistrySupport.java:170)
... 6 more
``` | https://github.com/apache/dubbo/issues/5871 | https://github.com/apache/dubbo/pull/5902 | 369907ebff82bf046d320fccd8b221188550080e | cb12928a710a34142e8c6a9b93e532239906a69e | 2020-03-16T01:55:24Z | java | 2020-03-31T06:55:10Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,855 | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java"] | [WARN]ReferenceConfig(null) is not DESTROYED when FINALIZE |
### Environment
* Dubbo version: 2.7.4.1
### Steps to reproduce this issue
在dubbo正常启动的时候，会出现很多一样的警告
```
2020-03-11 22:56:34.344 [Finalizer] [WARN] com.alibaba.dubbo.config.AbstractConfig - [DUBBO] ReferenceConfig(null) is not DESTROYED when FINALIZE, dubbo version: 2.6.4, current host: 192.168.31.245
2020-03-11 22:56:34.345 [Finalizer] [WARN] com.alibaba.dubbo.config.AbstractConfig - [DUBBO] ReferenceConfig(null) is not DESTROYED when FINALIZE, dubbo version: 2.6.4, current host: 192.168.31.245
2020-03-11 22:56:34.345 [Finalizer] [WARN] com.alibaba.dubbo.config.AbstractConfig - [DUBBO] ReferenceConfig(null) is not DESTROYED when FINALIZE, dubbo version: 2.6.4, current host: 192.168.31.245
```
是从下面触发了finalize()方法发出，但是现在这个里面也已经没有做任何操作了，是不是可以把finalizerGuardian去掉了？
```
private final Object finalizerGuardian = new Object() {
@Override
protected void finalize() throws Throwable {
super.finalize();
if (!ReferenceConfig.this.destroyed) {
logger.warn("ReferenceConfig(" + url + ") is not DESTROYED when FINALIZE");
/* don't destroy for now
try {
ReferenceConfig.this.destroy();
} catch (Throwable t) {
logger.warn("Unexpected err when destroy invoker of ReferenceConfig(" + url + ") in finalize method!", t);
}
*/
}
}
};
```
| https://github.com/apache/dubbo/issues/5855 | https://github.com/apache/dubbo/pull/5863 | b60acc5e52e7f7f34bb2145df530edbc0f897f74 | 8e07686047404ed4729ab1af481fa14984d5ed2b | 2020-03-11T15:02:32Z | java | 2020-04-02T11:38:03Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,837 | ["dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryDirectory.java"] | simplified property does't work in 2.7.6-SNAPSHOT | ### Environment
* Dubbo version: 2.7.6-SNAPSHOT
* Operating System version: Mac
* Java version: 1.8
### Steps to reproduce this issue
run dubbo-samples-simplified-registry-xml
org.apache.dubbo.samples.simplified.registry.xml.DemoServiceIT
### Expected Result
should pass
### Actual Result
throw exception | https://github.com/apache/dubbo/issues/5837 | https://github.com/apache/dubbo/pull/5839 | 529713305fc7807dd1600f18199ff4e7442f955f | 37d7fc123d4bdbb0847b1f91dd776191b79ac420 | 2020-03-08T05:42:27Z | java | 2020-03-09T09:45:21Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,836 | ["dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/proxy/wrapper/StubProxyFactoryWrapper.java"] | Stub does't work in 2.7.6-SNAPSHOT | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.6-SNAPSHOT
* Operating System version: Mac
* Java version: 1.8
### Steps to reproduce this issue
run dubbo-samples-stub sample
### Expected Result
"stub - greeting dubbo"
### Actual Result
return "greeting dubbo"
| https://github.com/apache/dubbo/issues/5836 | https://github.com/apache/dubbo/pull/5838 | 4037b5d33e572b5c2904c469a04c62ca878bfaea | 529713305fc7807dd1600f18199ff4e7442f955f | 2020-03-08T05:34:17Z | java | 2020-03-09T09:42:31Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,827 | ["dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/filter/FutureFilter.java"] | invoke onError when timeout occurred in async mode | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: 2.7.3
* Operating System version: MacOs
* Java version: 1.8
### Steps to reproduce this issue
1.start DemoService provider
2.Set onreturn and onthrow for sayHello method in async mode, and then start consumer.
```
<bean id="demoCallback" class="com.alibaba.dubbo.samples.notify.impl.NotifyImpl" />
<dubbo:reference id="demoService" interface="com.alibaba.dubbo.DemoService">
<dubbo:method name="sayHello" onreturn="demoCallback.onreturn" onthrow="demoCallback.onthrow"/>
</dubbo:reference>
```
2. send a request in async mode.
When timeout occurred, demoCallback.onthrow callback have not been invoked.
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
onthrow callback should be invoked.
### Actual Result
onthrow have not be invoked.
If there is an exception, please attach the exception trace:
Once exception occurs, CallbackRegistrationInvoker onError will be invoked
```.
@Override
public Result invoke(Invocation invocation) throws RpcException {
Result asyncResult = filterInvoker.invoke(invocation);
asyncResult = asyncResult.whenCompleteWithContext((r, t) -> {
for (int i = filters.size() - 1; i >= 0; i--) {
Filter filter = filters.get(i);
// onResponse callback
if (filter instanceof ListenableFilter) {
Filter.Listener listener = ((ListenableFilter) filter).listener();
if (listener != null) {
if (t == null) {
listener.onResponse(r, filterInvoker, invocation);
} else {
listener.onError(t, filterInvoker, invocation);
}
}
} else {
filter.onResponse(r, filterInvoker, invocation);
}
}
});
return asyncResult;
}
```
But, the FutureListener's onError is not implemented, cannot invoke the onreturn/onerror callback.
```
class FutureListener implements Listener {
@Override
public void onResponse(Result result, Invoker<?> invoker, Invocation invocation) {
if (result.hasException()) {
fireThrowCallback(invoker, invocation, result.getException());
} else {
fireReturnCallback(invoker, invocation, result.getValue());
}
}
@Override
public void onError(Throwable t, Invoker<?> invoker, Invocation invocation) {
}
}
``` | https://github.com/apache/dubbo/issues/5827 | https://github.com/apache/dubbo/pull/5828 | e72b3b20d7a3d4e0ffb3525b86111412cf525630 | cb5c5763cc3b3b1e6a45ca7a55aa091149062a11 | 2020-03-04T08:07:01Z | java | 2020-03-04T08:29:56Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,813 | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/DubboShutdownHook.java", "dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java"] | destroyAll method of DubboShutdownHook will be invoke twice when using spring framework | - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: xxx
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
1. run main method of Application of dubbo-demo-xml-consumer.
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
The application will exit without thrown exception
### Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
```log
java.lang.IllegalStateException: There's no ApplicationConfig specified.
at org.apache.dubbo.config.context.ConfigManager.lambda$getApplicationOrElseThrow$0(ConfigManager.java:88)
at java.base/java.util.Optional.orElseThrow(Optional.java:401)
at org.apache.dubbo.config.context.ConfigManager.getApplicationOrElseThrow(ConfigManager.java:88)
at org.apache.dubbo.rpc.model.ApplicationModel.getApplicationConfig(ApplicationModel.java:100)
at org.apache.dubbo.rpc.model.ApplicationModel.getName(ApplicationModel.java:104)
at org.apache.dubbo.rpc.model.ApplicationModel.getApplication(ApplicationModel.java:112)
at org.apache.dubbo.registry.integration.RegistryProtocol.destroy(RegistryProtocol.java:500)
at org.apache.dubbo.rpc.protocol.ProtocolFilterWrapper.destroy(ProtocolFilterWrapper.java:166)
at org.apache.dubbo.rpc.protocol.ProtocolListenerWrapper.destroy(ProtocolListenerWrapper.java:80)
at org.apache.dubbo.config.DubboShutdownHook.destroyProtocols(DubboShutdownHook.java:140)
at org.apache.dubbo.config.DubboShutdownHook.destroyAll(DubboShutdownHook.java:124)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.destroy(DubboBootstrap.java:1037)
at org.apache.dubbo.config.bootstrap.DubboBootstrap.stop(DubboBootstrap.java:817)
at org.apache.dubbo.config.spring.context.DubboBootstrapApplicationListener.onContextClosedEvent(DubboBootstrapApplicationListener.java:63)
at org.apache.dubbo.config.spring.context.DubboBootstrapApplicationListener.onApplicationContextEvent(DubboBootstrapApplicationListener.java:54)
at org.apache.dubbo.config.spring.context.OneTimeExecutionApplicationContextEventListener.onApplicationEvent(OneTimeExecutionApplicationContextEventListener.java:40)
at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:172)
at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:165)
at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:393)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:347)
at org.springframework.context.support.AbstractApplicationContext.doClose(AbstractApplicationContext.java:991)
at org.springframework.context.support.AbstractApplicationContext$2.run(AbstractApplicationContext.java:929)
```
It's because the destroy method of DubboBootstrap is invoked twice when the application is closing.
(1.When the DubboBootstrapApplicationListener accept the ContextClosedEvent, running once.)
(2.The ShutdownHookCallback register when new the DubboBootstrap, running another time.) | https://github.com/apache/dubbo/issues/5813 | https://github.com/apache/dubbo/pull/5819 | 5576991be387d00fa707655b0a0de0010b1f13a7 | e72b3b20d7a3d4e0ffb3525b86111412cf525630 | 2020-02-28T15:55:45Z | java | 2020-03-02T09:33:13Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,797 | ["dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java"] | Expansion of ConcurrentHashMap in ExtensionLoader | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: master
* Operating System version: windows
* Java version: 1.8
In ExtensionLoader, EXTENSION INSTANCES is a ConcurrentHashMap with a default size, and the extension class provided in Dubbo has exceeded 16.
Start the program, it will expand at least twice. I think it is more appropriate to add an initial size of 64 here.
Other places where ConcurrentHashMap is used should also pay attention to a suitable initial size | https://github.com/apache/dubbo/issues/5797 | https://github.com/apache/dubbo/pull/5812 | 7594d814891aa43ff01a3f14e372e48ef3792ae3 | f3fb25282378271bb2b2b81d3a9e0e1e9446bbb7 | 2020-02-26T03:41:48Z | java | 2020-03-07T08:08:12Z |
closed | apache/dubbo | https://github.com/apache/dubbo | 5,777 | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java"] | Dubbo 2.7.5 problems summary | - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
All problem already resolve by Dubbo SPI on my framework, but I think I should share those problems and the reason why those problems come up.
Please Dubbo team fix those issue for good.
### Environment
* Dubbo version: Dubbo 2.7.5
* Operating System version: MacOS
* Java version: Oracle JDK 8
Finally I back to the Vertion 2.7.4.1, And This is all issue of the Dubbo 2.7.5 I found:
- **Failure due to the Dubbo starting early**. This is my environment:
- Dubbo 2.7.5 + Nacos 1.1.4
- Use Dynamic Config Center
- Spring boot 2.1.9
- Use YAML Config
In this case, the Dubbo will be startup before the `ConfigCenterConfig` inject into `DubboBootstrap`, it make Dubbo use default config and starting failure. And the reason of the Dubbo startup is **Spring framework scan Dubbo Service Interface and initial it, and the Dubbo Service Interface active the Dubbo framework**. the Dubbo framework not even get the `ConfigCenterConfig` at that time.
After reading the Dubbo source code, I found some key code in the class `DubboBootstrap`, method name `startConfigCenter`, line 560.
```java
// Get the class "ConfigCenterConfig"
Collection<ConfigCenterConfig> configCenters = configManager.getConfigCenters();
if (CollectionUtils.isNotEmpty(configCenters)) {
CompositeDynamicConfiguration compositeDynamicConfiguration = new CompositeDynamicConfiguration();
for (ConfigCenterConfig configCenter : configCenters) {
configCenter.refresh();
ConfigValidationUtils.validateConfigCenterConfig(configCenter);
// The method "prepareEnvironment" get all dubbo config from remote server
compositeDynamicConfiguration.addConfiguration(prepareEnvironment(configCenter));
}
environment.setDynamicConfiguration(compositeDynamicConfiguration);
}
configManager.refreshAll();
```
And this is the code I use to fix that problem( This code can not fix the problem in some case because it still depend on the order of the Bean initialize in Spring framework, that is the reason why I specified name at `@Configuration`. for the `@DependOn` ):
```java
@Order(-1)
@AllArgsConstructor
@Configuration("apacheDubboBootstrap")
@ConditionalOnClass(name = "org.apache.dubbo.config.ConfigCenterConfig")
public static class ApacheDubboBootstrap {
private final DynamicConfigProperties properties;
@PostConstruct
public void init() {
// 在 Spring boot 环境下由于 Dubbo 接口的代理类创建间接触发了 Dubbo 框架流程
// 这一行代码是为了解决启动优先级的问题, 在触发 Dubbo 框架流程之前注入动态配置中心配置
// 而依赖 Spring boot 进行注入有可能会因为 Dubbo 先启动而不知道存在配置中心导致启动失败
DubboBootstrap.getInstance().configCenter(properties.ofConfigCenterConfig());
}
}
```
- **Not friendly with the YAML config**
For the history reason, the Dubbo framework use XML as config foramt at early, then Properties come up. And now I found that the Dubbo not identify and not inject the YAML config, only XML and Properties can.
###### For example, This is the qos server config in YAML:
```yaml
# Wrong config
# This config ( just qos-enable ) problem seem like fixed in Dubbo 2.7.5 ? But I haven't verified yet
dubbo:
application:
qos-enable: true
# Correct config
dubbo:
application:
qos.enable: true
```
If you run Dubbo as debug mode and put some breakpoint in the class `ApplicationConfig`, you can see the method `setQosEnable` only be called when you write `qos.enable` . And what about `qos-enable` ? Just nothing happen.
###### And other example, The `ConfigCenterConfig`:
```yaml
dubbo:
config-center:
address: nacos://xxxx
config-file: xxxxxx
group: xxxxxx
namespace: xxxxxx
```
Only `address` is effective in those configs( The method `setAddress` has been called ) and other config still keep that default value( Nothing happen on the setter of those property ). So that I have to write my configuration and use it config Dubbo:
```java
public class DynamicConfigProperties {
public static final String PREFIX = "dubbo.config-server";
/**
* Nacos 服务 Ip 地址
*/
private String serverAddr;
// some property...
public org.apache.dubbo.config.ConfigCenterConfig ofConfigCenterConfig() {
org.apache.dubbo.config.ConfigCenterConfig config = new ConfigCenterConfig();
Map<String, String> parameters = new HashMap<>(4);
setParameter(parameters, PropertyKeyConst.ACCESS_KEY, accessKey);
setParameter(parameters, PropertyKeyConst.SECRET_KEY, secretKey);
setParameter(parameters, PropertyKeyConst.ENDPOINT, endpoint);
config.setParameters(parameters);
config.setHighestPriority(allowOverride);
config.setNamespace(namespace);
config.setAddress(serverAddr);
config.setConfigFile(dataId);
config.setCheck(abortOnFail);
config.setTimeout(timeout);
config.setGroup(group);
return config;
}
}
```
###### The last example, let see the `DubboBootstrap`, method `prepareEnvironment`, line 828 & 829.
```java
DynamicConfiguration dynamicConfiguration = getDynamicConfiguration(configCenter.toUrl());
// Get config from remote server.
String configContent = dynamicConfiguration.getProperties(configCenter.getConfigFile(), configCenter.getGroup());
String appGroup = getApplication().getName();
String appConfigContent = null;
if (isNotEmpty(appGroup)) {
appConfigContent = dynamicConfiguration.getProperties
(isNotEmpty(configCenter.getAppConfigFile()) ? configCenter.getAppConfigFile() : configCenter.getConfigFile(),
appGroup
);
}
try {
environment.setConfigCenterFirst(configCenter.isHighestPriority());
// It force all remote config must use "properties" format.
environment.updateExternalConfigurationMap(parseProperties(configContent));
environment.updateAppExternalConfigurationMap(parseProperties(appConfigContent));
} catch (IOException e) {
throw new IllegalStateException("Failed to parse configurations from Config Center.", e);
}
```
Because the method `parseProperties`, I have to create my own protocol `banacos` and `BanacosDynamicConfiguration`, the goal is parse yaml and tranform to properties format.
It should be add a property name `format`( or `file-extension` like nacos client ? ) to decide what parser should be Dubbo use, rather than write those dead code.
- **Metadata server not effective, and the `ServiceNameMapping` write meta data anywhere**
The reason of meta server not effective is same with my first issue "**Failure due to the Dubbo starting early**". Let see `DubboBootstrap` again, the method `startMetadataReport`:
```java
ApplicationConfig applicationConfig = getApplication();
String metadataType = applicationConfig.getMetadataType();
// FIXME, multiple metadata config support.
Collection<MetadataReportConfig> metadataReportConfigs = configManager.getMetadataConfigs();
if (CollectionUtils.isEmpty(metadataReportConfigs)) {
if (REMOTE_METADATA_STORAGE_TYPE.equals(metadataType)) {
throw new IllegalStateException("No MetadataConfig found, you must specify the remote Metadata Center address when 'metadata=remote' is enabled.");
}
return;
}
MetadataReportConfig metadataReportConfig = metadataReportConfigs.iterator().next();
ConfigValidationUtils.validateMetadataConfig(metadataReportConfig);
if (!metadataReportConfig.isValid()) {
return;
}
MetadataReportInstance.init(metadataReportConfig.toUrl());
```
Is it familiar ? Dubbo activate too soon, even before any config injected, that is the reason why some functions is not work on Dubbo 2.7.5 . We should pay attention to the Bean initialize, especially startup Dubbo under Spring framrwork.
And this is the last issue for this article, the class `DynamicConfigurationServiceNameMapping` push metadata to anywhere:
```java
@Override
public void map(String serviceInterface, String group, String version, String protocol) {
if (IGNORED_SERVICE_INTERFACES.contains(serviceInterface)) {
return;
}
// The value of variable 'dynamicConfiguration' is CompositeDynamicConfiguration
DynamicConfiguration dynamicConfiguration = DynamicConfiguration.getDynamicConfiguration();
}
```
The javadoc of the class `CompositeDynamicConfiguration` is ***support multiple config center, simply iterating each concrete config center***. It mean this class will push metadata to any config center we configed.
In my opinion, those "metadata" should push to metadata server rather than config server. Now every I startup Dubbo service as provider, my config server always fill all data that useless in my view. Just a mess on my config server If I startup all Dubbo service. | https://github.com/apache/dubbo/issues/5777 | https://github.com/apache/dubbo/pull/5811 | 2a7b5d1dd26050f593db36af566354975ec9dfa3 | ca288152a0adcb48085f87b27a643bea31953449 | 2020-02-22T13:54:53Z | java | 2020-02-28T11:50:06Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.