status
stringclasses
1 value
repo_name
stringlengths
9
24
repo_url
stringlengths
28
43
issue_id
int64
1
104k
updated_files
stringlengths
8
1.76k
title
stringlengths
4
369
body
stringlengths
0
254k
issue_url
stringlengths
37
56
pull_url
stringlengths
37
54
before_fix_sha
stringlengths
40
40
after_fix_sha
stringlengths
40
40
report_datetime
timestamp[ns, tz=UTC]
language
stringclasses
5 values
commit_datetime
timestamp[us, tz=UTC]
closed
electron/electron
https://github.com/electron/electron
7,551
["atom/browser/mac/atom_application_delegate.mm"]
Crash occasionally on macOS Sierra when inputting with Chinese IME
- Electron version: 1.2.8 - Operating system: macOS Sierra (10.12) We haven't encountered this problem prior to macOS 10.12. So it may be related to the system itself. Anyway, the stack trace is attached below: ``` Date/Time: 2016-10-11 11:52:21.463 +0800 OS Version: Mac OS X 10.12 (16A323) Report Version: 12 Anonymous UUID: 361C0B73-1C8E-448F-4E98-03E6159FF5CB Sleep/Wake UUID: 2AF37609-7364-400C-BF07-7A5A663DB017 Time Awake Since Boot: 91000 seconds Time Since Wake: 3300 seconds System Integrity Protection: enabled Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread Exception Type: EXC_BREAKPOINT (SIGTRAP) Exception Codes: 0x0000000000000002, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Trace/BPT trap: 5 Termination Reason: Namespace SIGNAL, Code 0x5 Terminating Process: exc handler [0] Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread 0 com.github.electron.framework 0x000000010871a751 0x10855e000 + 1820497 1 com.github.electron.framework 0x0000000108732854 0x10855e000 + 1919060 2 com.github.electron.framework 0x000000010874dff3 0x10855e000 + 2031603 3 com.github.electron.framework 0x000000010874ec75 0x10855e000 + 2034805 4 libsystem_malloc.dylib 0x00007fffa248e332 malloc_zone_malloc + 107 5 libsystem_malloc.dylib 0x00007fffa248d2b0 malloc + 24 6 com.apple.HIToolbox 0x00007fff8caceb32 -[IMKInputSession _coreAttributesFromRange:whichAttributes:completionHandler:] + 61 7 com.apple.HIToolbox 0x00007fff8cad0bb0 -[IMKInputSession attributedSubstringFromRange:completionHandler:] + 186 8 com.apple.HIToolbox 0x00007fff8cac13ab __61-[IMKInputSession imkxpc_attributedSubstringFromRange:reply:]_block_invoke + 530 9 com.apple.CoreFoundation 0x00007fff8d2ec3ac __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12 10 com.apple.CoreFoundation 0x00007fff8d2cd424 __CFRunLoopDoBlocks + 356 11 com.apple.CoreFoundation 0x00007fff8d2ccf66 __CFRunLoopRun + 1878 12 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 13 com.apple.HIToolbox 0x00007fff8caa863e -[IMKInputSessionXPCInvocation invocationAwaitXPCReply] + 606 14 com.apple.HIToolbox 0x00007fff8caafb6a __49-[IMKInputSession handleEvent:completionHandler:]_block_invoke_2.479 + 1720 15 com.apple.HIToolbox 0x00007fff8caaef88 __49-[IMKInputSession handleEvent:completionHandler:]_block_invoke_2.438 + 566 16 com.apple.HIToolbox 0x00007fff8ca93314 -[IMKClient switchedInputMode:completionHandler:] + 405 17 com.apple.HIToolbox 0x00007fff8caade32 -[IMKInputSession tryHandleEventSwitchedInputMode:eventWasHandled:continuationHandler:] + 122 18 com.apple.HIToolbox 0x00007fff8caaed2c __49-[IMKInputSession handleEvent:completionHandler:]_block_invoke.437 + 170 19 com.apple.HIToolbox 0x00007fff8caaeb6b __49-[IMKInputSession handleEvent:completionHandler:]_block_invoke + 261 20 com.apple.HIToolbox 0x00007fff8cabad3f -[IMKInputSession _eventIsOn:completionHandler:] + 1838 21 com.apple.HIToolbox 0x00007fff8caae3e1 -[IMKInputSession handleEvent:completionHandler:] + 890 22 com.apple.HIToolbox 0x00007fff8ca5ef10 IMKInputSessionProcessEventRefWithCompletionHandler + 120 23 com.apple.HIToolbox 0x00007fff8ca5e2c2 InputMethodInstanceProcessEventRef_WithCompletionHandler + 129 24 com.apple.HIToolbox 0x00007fff8ca4ca1a __TSMEventToInputMethod_WithCompletionHandler_block_invoke + 124 25 com.apple.HIToolbox 0x00007fff8ca508a0 __SendTSMDocumentLockEvent_WithCompletionHandler_block_invoke + 95 26 com.apple.HIToolbox 0x00007fff8c89ef92 ___ZL23DispatchEventToHandlersP14EventTargetRecP14OpaqueEventRefP14HandlerCallRec_block_invoke + 108 27 com.apple.AppKit 0x00007fff8b0faa4d -[NSTextInputContext handleTSMEvent:completionHandler:] + 3298 28 com.apple.AppKit 0x00007fff8b0f9cfd _NSTSMEventHandler + 319 29 com.apple.HIToolbox 0x00007fff8c8460d5 DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 1708 30 com.apple.HIToolbox 0x00007fff8c845346 SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*) + 428 31 com.apple.HIToolbox 0x00007fff8c84518f SendEventToEventTargetWithOptions + 43 32 com.apple.HIToolbox 0x00007fff8c89bf86 SendTSMEvent_WithCompletionHandler + 408 33 com.apple.HIToolbox 0x00007fff8ca4c951 TrySendLockEvent_BeforeEventToInputMethod_WithContinuationHandler + 351 34 com.apple.HIToolbox 0x00007fff8ca4c78e TSMEventToInputMethod_WithCompletionHandler + 148 35 com.apple.HIToolbox 0x00007fff8ca4c6da TSMEventToKeyboardInputMethod_WithCompletionHandler + 127 36 com.apple.HIToolbox 0x00007fff8c89b474 TSMKeyEvent_WithCompletionHandler + 584 37 com.apple.HIToolbox 0x00007fff8c89b1f3 __TSMProcessRawKeyEventWithOptionsAndCompletionHandler_block_invoke_4 + 251 38 com.apple.HIToolbox 0x00007fff8c89b020 __TSMProcessRawKeyEventWithOptionsAndCompletionHandler_block_invoke_3 + 281 39 com.apple.HIToolbox 0x00007fff8c89ad36 __TSMProcessRawKeyEventWithOptionsAndCompletionHandler_block_invoke_2 + 308 40 com.apple.HIToolbox 0x00007fff8c89aa6d __TSMProcessRawKeyEventWithOptionsAndCompletionHandler_block_invoke + 300 41 com.apple.HIToolbox 0x00007fff8c899fdd TSMProcessRawKeyEventWithOptionsAndCompletionHandler + 3604 42 com.apple.AppKit 0x00007fff8b89af16 __61-[NSTextInputContext _handleEvent:options:completionHandler:]_block_invoke.885 + 116 43 com.apple.AppKit 0x00007fff8b89a9c5 __204-[NSTextInputContext tryTSMProcessRawKeyEvent_orSubstitution:dispatchCondition:setupForDispatch:furtherCondition:doubleSpaceSubstitutionCondition:doubleSpaceSubstitutionWork:dispatchTSMWork:continuation:]_block_invoke.817 + 121 44 com.apple.AppKit 0x00007fff8b89a82f -[NSTextInputContext tryTSMProcessRawKeyEvent_orSubstitution:dispatchCondition:setupForDispatch:furtherCondition:doubleSpaceSubstitutionCondition:doubleSpaceSubstitutionWork:dispatchTSMWork:continuation:] + 285 45 com.apple.AppKit 0x00007fff8b0f85fb -[NSTextInputContext _handleEvent:options:completionHandler:] + 1298 46 com.apple.AppKit 0x00007fff8b0f80ae -[NSTextInputContext handleEvent:] + 109 47 com.apple.AppKit 0x00007fff8b0f7fb2 -[NSView interpretKeyEvents:] + 232 48 com.github.electron.framework 0x000000010909af55 0x10855e000 + 11784021 49 com.github.electron.framework 0x000000010909a9b5 0x10855e000 + 11782581 50 com.github.electron.framework 0x000000010a57ae6e 0x10855e000 + 33672814 51 com.apple.AppKit 0x00007fff8b7d37ec -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 4086 52 com.apple.AppKit 0x00007fff8b7d242a -[NSWindow(NSEventRouting) sendEvent:] + 541 53 com.github.electron.framework 0x00000001086ad724 0x10855e000 + 1373988 54 com.apple.AppKit 0x00007fff8b673a1c -[NSApplication(NSEvent) sendEvent:] + 4768 55 com.github.electron.framework 0x00000001085f925b 0x10855e000 + 635483 56 com.apple.AppKit 0x00007fff8af59009 -[NSApplication run] + 1002 57 com.github.electron.framework 0x00000001087119d6 0x10855e000 + 1784278 58 com.github.electron.framework 0x0000000108710ff4 0x10855e000 + 1781748 59 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 60 com.github.electron.framework 0x0000000108e5769b 0x10855e000 + 9410203 61 com.github.electron.framework 0x0000000108e574a3 0x10855e000 + 9409699 62 com.github.electron.framework 0x0000000108e59ab2 0x10855e000 + 9419442 63 com.github.electron.framework 0x0000000108e5313d 0x10855e000 + 9392445 64 com.github.electron.framework 0x0000000108dc6401 0x10855e000 + 8815617 65 com.github.electron.framework 0x0000000108dc5576 0x10855e000 + 8811894 66 com.github.electron.framework 0x000000010855f947 AtomMain + 71 67 im.pubu.desktop 0x0000000108553ec6 main + 38 68 libdyld.dylib 0x00007fffa230c255 start + 1 Thread 1:: NetworkConfigWatcher 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff8d2cd8d4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff8d2ccd61 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 5 com.apple.Foundation 0x00007fff8ecc9cb2 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 6 com.github.electron.framework 0x000000010871180e 0x10855e000 + 1783822 7 com.github.electron.framework 0x0000000108710ff4 0x10855e000 + 1781748 8 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 9 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 10 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 11 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 12 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 13 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 14 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 2:: DnsConfigService 0 libsystem_kernel.dylib 0x00007fffa243c236 poll + 10 1 com.github.electron.framework 0x00000001094ff52c 0x10855e000 + 16389420 2 com.github.electron.framework 0x00000001094fe2db 0x10855e000 + 16384731 3 com.github.electron.framework 0x00000001087105df 0x10855e000 + 1779167 4 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 5 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 6 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 7 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 8 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 9 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 10 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 3:: CrShutdownDetector 0 libsystem_kernel.dylib 0x00007fffa243c2de read + 10 1 com.github.electron.framework 0x00000001085ed58f 0x10855e000 + 587151 2 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 3 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 4 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 5 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 4:: Chrome_DBThread 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff8d2cd8d4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff8d2ccd61 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 5 com.github.electron.framework 0x000000010871156f 0x10855e000 + 1783151 6 com.github.electron.framework 0x0000000108710ff4 0x10855e000 + 1781748 7 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 8 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 9 com.github.electron.framework 0x0000000108e61fe8 0x10855e000 + 9453544 10 com.github.electron.framework 0x0000000108e623f7 0x10855e000 + 9454583 11 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 12 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 13 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 14 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 15 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 5:: Chrome_FileThread 0 libsystem_kernel.dylib 0x00007fffa243c236 poll + 10 1 com.github.electron.framework 0x00000001094ff52c 0x10855e000 + 16389420 2 com.github.electron.framework 0x00000001094fe2db 0x10855e000 + 16384731 3 com.github.electron.framework 0x00000001087105df 0x10855e000 + 1779167 4 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 5 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 6 com.github.electron.framework 0x0000000108e62068 0x10855e000 + 9453672 7 com.github.electron.framework 0x0000000108e62407 0x10855e000 + 9454599 8 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 9 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 10 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 11 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 12 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 6:: Chrome_FileUserBlockingThread 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff8d2cd8d4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff8d2ccd61 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 5 com.github.electron.framework 0x000000010871156f 0x10855e000 + 1783151 6 com.github.electron.framework 0x0000000108710ff4 0x10855e000 + 1781748 7 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 8 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 9 com.github.electron.framework 0x0000000108e620e8 0x10855e000 + 9453800 10 com.github.electron.framework 0x0000000108e62417 0x10855e000 + 9454615 11 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 12 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 13 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 14 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 15 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 7:: Chrome_ProcessLauncherThread 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff8d2cd8d4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff8d2ccd61 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 5 com.github.electron.framework 0x000000010871156f 0x10855e000 + 1783151 6 com.github.electron.framework 0x0000000108710ff4 0x10855e000 + 1781748 7 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 8 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 9 com.github.electron.framework 0x0000000108e62168 0x10855e000 + 9453928 10 com.github.electron.framework 0x0000000108e62424 0x10855e000 + 9454628 11 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 12 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 13 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 14 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 15 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 8:: Chrome_CacheThread 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff8d2cd8d4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff8d2ccd61 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 5 com.github.electron.framework 0x000000010871156f 0x10855e000 + 1783151 6 com.github.electron.framework 0x0000000108710ff4 0x10855e000 + 1781748 7 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 8 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 9 com.github.electron.framework 0x0000000108e621e8 0x10855e000 + 9454056 10 com.github.electron.framework 0x0000000108e62431 0x10855e000 + 9454641 11 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 12 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 13 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 14 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 15 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 9:: Chrome_IOThread 0 libsystem_kernel.dylib 0x00007fffa243c236 poll + 10 1 com.github.electron.framework 0x00000001094ff52c 0x10855e000 + 16389420 2 com.github.electron.framework 0x00000001094fe2db 0x10855e000 + 16384731 3 com.github.electron.framework 0x00000001087105c6 0x10855e000 + 1779142 4 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 5 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 6 com.github.electron.framework 0x0000000108e62268 0x10855e000 + 9454184 7 com.github.electron.framework 0x0000000108e6243e 0x10855e000 + 9454654 8 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 9 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 10 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 11 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 12 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 10:: IndexedDB 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff8d2cd8d4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff8d2ccd61 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 5 com.github.electron.framework 0x000000010871156f 0x10855e000 + 1783151 6 com.github.electron.framework 0x0000000108710ff4 0x10855e000 + 1781748 7 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 8 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 9 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 10 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 11 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 12 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 13 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 11:: CompositorTileWorker1/42499 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 com.github.electron.framework 0x0000000108b2fed8 0x10855e000 + 6102744 3 com.github.electron.framework 0x000000010876f8e3 0x10855e000 + 2169059 4 com.github.electron.framework 0x000000010876f72d 0x10855e000 + 2168621 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 12: 0 libsystem_kernel.dylib 0x00007fffa243af4e __select + 10 1 com.github.electron.framework 0x0000000108655622 atom::NodeBindingsMac::PollEvents() + 210 2 com.github.electron.framework 0x0000000108654bcf atom::NodeBindings::EmbedThreadRunner(void*) + 63 3 libnode.dylib 0x000000010cb394d9 0x10c9df000 + 1418457 4 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 5 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 6 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 13: 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 libnode.dylib 0x000000010cb39879 uv_cond_wait + 9 3 libnode.dylib 0x000000010cb2e023 0x10c9df000 + 1372195 4 libnode.dylib 0x000000010cb394d9 0x10c9df000 + 1418457 5 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 6 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 7 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 14: 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 libnode.dylib 0x000000010cb39879 uv_cond_wait + 9 3 libnode.dylib 0x000000010cb2e023 0x10c9df000 + 1372195 4 libnode.dylib 0x000000010cb394d9 0x10c9df000 + 1418457 5 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 6 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 7 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 15: 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 libnode.dylib 0x000000010cb39879 uv_cond_wait + 9 3 libnode.dylib 0x000000010cb2e023 0x10c9df000 + 1372195 4 libnode.dylib 0x000000010cb394d9 0x10c9df000 + 1418457 5 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 6 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 7 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 16: 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 libnode.dylib 0x000000010cb39879 uv_cond_wait + 9 3 libnode.dylib 0x000000010cb2e023 0x10c9df000 + 1372195 4 libnode.dylib 0x000000010cb394d9 0x10c9df000 + 1418457 5 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 6 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 7 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 17:: com.apple.NSEventThread 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff8d2cd8d4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff8d2ccd61 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 5 com.apple.AppKit 0x00007fff8b0b0e9e _NSEventThread + 205 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 18:: BrowserBlockingWorker1/56939 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010876d24a 0x10855e000 + 2159178 3 com.github.electron.framework 0x000000010876c9cd 0x10855e000 + 2157005 4 com.github.electron.framework 0x000000010876f72d 0x10855e000 + 2168621 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 19:: NetworkConfigWatcher 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff8d2cd8d4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff8d2ccd61 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 5 com.apple.Foundation 0x00007fff8ecc9cb2 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 6 com.github.electron.framework 0x000000010871180e 0x10855e000 + 1783822 7 com.github.electron.framework 0x0000000108710ff4 0x10855e000 + 1781748 8 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 9 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 10 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 11 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 12 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 13 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 14 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 20:: BrowserBlockingWorker2/78087 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010876d24a 0x10855e000 + 2159178 3 com.github.electron.framework 0x000000010876c9cd 0x10855e000 + 2157005 4 com.github.electron.framework 0x000000010876f72d 0x10855e000 + 2168621 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 21:: CachePoolWorker1/84275 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010876d24a 0x10855e000 + 2159178 3 com.github.electron.framework 0x000000010876c9cd 0x10855e000 + 2157005 4 com.github.electron.framework 0x000000010876f72d 0x10855e000 + 2168621 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 22:: CachePoolWorker2/85515 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010876d24a 0x10855e000 + 2159178 3 com.github.electron.framework 0x000000010876c9cd 0x10855e000 + 2157005 4 com.github.electron.framework 0x000000010876f72d 0x10855e000 + 2168621 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 23:: com.apple.audio.IOThread.client 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.audio.CoreAudio 0x00007fff8ce5af26 HALB_MachPort::SendMessageWithReply(unsigned int, unsigned int, unsigned int, unsigned int, mach_msg_header_t*, bool, unsigned int) + 122 3 com.apple.audio.CoreAudio 0x00007fff8ce5ae9c HALB_MachPort::SendSimpleMessageWithSimpleReply(unsigned int, unsigned int, int, int&, bool, unsigned int) + 42 4 com.apple.audio.CoreAudio 0x00007fff8ce57cee HALC_ProxyIOContext::IOWorkLoop() + 1198 5 com.apple.audio.CoreAudio 0x00007fff8ce57667 HALC_ProxyIOContext::IOThreadEntry(void*) + 131 6 com.apple.audio.CoreAudio 0x00007fff8ce5738b HALB_IOThread::Entry(void*) + 75 7 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 8 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 9 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 24:: CachePoolWorker3/98099 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010876d24a 0x10855e000 + 2159178 3 com.github.electron.framework 0x000000010876c9cd 0x10855e000 + 2157005 4 com.github.electron.framework 0x000000010876f72d 0x10855e000 + 2168621 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 25:: PowerSaveBlocker 0 libsystem_kernel.dylib 0x00007fffa243341a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fffa2432867 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff8d2cd8d4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff8d2ccd61 __CFRunLoopRun + 1361 4 com.apple.CoreFoundation 0x00007fff8d2cc5b4 CFRunLoopRunSpecific + 420 5 com.github.electron.framework 0x000000010871156f 0x10855e000 + 1783151 6 com.github.electron.framework 0x0000000108710ff4 0x10855e000 + 1781748 7 com.github.electron.framework 0x0000000108750ba3 0x10855e000 + 2042787 8 com.github.electron.framework 0x000000010873b89d 0x10855e000 + 1955997 9 com.github.electron.framework 0x0000000108770168 0x10855e000 + 2171240 10 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 11 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 12 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 13 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 26:: CachePoolWorker4/108635 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010876d24a 0x10855e000 + 2159178 3 com.github.electron.framework 0x000000010876c9cd 0x10855e000 + 2157005 4 com.github.electron.framework 0x000000010876f72d 0x10855e000 + 2168621 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 27:: BrowserBlockingWorker3/15375 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010876d24a 0x10855e000 + 2159178 3 com.github.electron.framework 0x000000010876c9cd 0x10855e000 + 2157005 4 com.github.electron.framework 0x000000010876f72d 0x10855e000 + 2168621 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 28:: CachePoolWorker5/115227 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa252397a _pthread_cond_wait + 712 2 com.github.electron.framework 0x000000010876d24a 0x10855e000 + 2159178 3 com.github.electron.framework 0x000000010876c9cd 0x10855e000 + 2157005 4 com.github.electron.framework 0x000000010876f72d 0x10855e000 + 2168621 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 29:: WorkerPool/90083 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa25239b3 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010875f2db 0x10855e000 + 2101979 3 com.github.electron.framework 0x0000000108771b5e 0x10855e000 + 2177886 4 com.github.electron.framework 0x0000000108771fa8 0x10855e000 + 2178984 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 30:: WorkerPool/125375 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa25239b3 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010875f2db 0x10855e000 + 2101979 3 com.github.electron.framework 0x0000000108771b5e 0x10855e000 + 2177886 4 com.github.electron.framework 0x0000000108771fa8 0x10855e000 + 2178984 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 31:: WorkerPool/13675 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa25239b3 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010875f2db 0x10855e000 + 2101979 3 com.github.electron.framework 0x0000000108771b5e 0x10855e000 + 2177886 4 com.github.electron.framework 0x0000000108771fa8 0x10855e000 + 2178984 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 32:: WorkerPool/109611 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa25239b3 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010875f2db 0x10855e000 + 2101979 3 com.github.electron.framework 0x0000000108771b5e 0x10855e000 + 2177886 4 com.github.electron.framework 0x0000000108771fa8 0x10855e000 + 2178984 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 33:: WorkerPool/125999 0 libsystem_kernel.dylib 0x00007fffa243ac8a __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fffa25239b3 _pthread_cond_wait + 769 2 com.github.electron.framework 0x000000010875f2db 0x10855e000 + 2101979 3 com.github.electron.framework 0x0000000108771b5e 0x10855e000 + 2177886 4 com.github.electron.framework 0x0000000108771fa8 0x10855e000 + 2178984 5 com.github.electron.framework 0x000000010876c467 0x10855e000 + 2155623 6 libsystem_pthread.dylib 0x00007fffa2522abb _pthread_body + 180 7 libsystem_pthread.dylib 0x00007fffa2522a07 _pthread_start + 286 8 libsystem_pthread.dylib 0x00007fffa2522231 thread_start + 13 Thread 34: 0 libsystem_kernel.dylib 0x00007fffa243b4e6 __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fffa2522632 _pthread_wqthread + 1023 2 libsystem_pthread.dylib 0x00007fffa2522221 start_wqthread + 13 Thread 35: 0 libsystem_kernel.dylib 0x00007fffa243b4e6 __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fffa25227c5 _pthread_wqthread + 1426 2 libsystem_pthread.dylib 0x00007fffa2522221 start_wqthread + 13 Thread 36: 0 libsystem_kernel.dylib 0x00007fffa243b4e6 __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fffa2522632 _pthread_wqthread + 1023 2 libsystem_pthread.dylib 0x00007fffa2522221 start_wqthread + 13 Thread 37: 0 libsystem_kernel.dylib 0x00007fffa243b4e6 __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fffa2522632 _pthread_wqthread + 1023 2 libsystem_pthread.dylib 0x00007fffa2522221 start_wqthread + 13 Thread 0 crashed with X86 Thread State (64-bit): rax: 0x0000000000000400 rbx: 0x0000000000000000 rcx: 0x0000000000000020 rdx: 0xffffffffffffffe0 rdi: 0x000000010c37ebec rsi: 0x00007fc5780c11e0 rbp: 0x00007fff576a81b0 rsp: 0x00007fff576a81b0 r8: 0x0000000000000040 r9: 0x00007fffaafe5040 r10: 0x000000010c993100 r11: 0x00000039df5e7400 r12: 0x00007fff576a86e8 r13: 0xe7a0d248d2d000d9 r14: 0x00007fff576a86d8 r15: 0x00007fff576a86e0 rip: 0x000000010871a751 rfl: 0x0000000000000246 cr2: 0x00007fffa23ca7ee Logical CPU: 6 Error Code: 0x00000000 Trap Number: 3 ```
https://github.com/electron/electron/issues/7551
https://github.com/electron/electron/pull/10393
1430faa2fd6d6586bfaf63a1a06199834d03e27d
bca71fcfc169e11037b581503cc9f32c642175c7
2016-10-11T04:30:51Z
c++
2017-09-12T07:19:08Z
closed
electron/electron
https://github.com/electron/electron
7,532
["docs/api/web-contents.md", "lib/browser/api/web-contents.js", "lib/renderer/init.js", "spec/api-browser-window-spec.js", "spec/static/main.js"]
An asynchronous executeJavaScript option
My app sends arbitrary javascript to its web views which contain untrusted content (and hence only can talk through message sending via the preload script). As such, to accommodate an asynchronous executeJavaScript (that can return/throw), I do the following. In the preload script I have something like: `function __respond(uuid, object, error) { ipcRenderer.send("response", uuid, object, error) }` Such that in the server I have something like (Here single quotes represent template string backticks because I can't figure out how to escape a backtick): ``` var handlers = { }; ipcMain.on("response", function (_, uuid, object, error) { if (error) { handlers[uuid].reject(error) }; else { handlers[uuid].resolve(object) }; } function executeJavaScript(aFunction) { var the_uuid = uuid.v4(); var functionString = "(" + aFunction + ")"; return new Promise(function (resolve, reject) { handlers[the_uuid] = { resolve, reject }; webview.executeJavaScript('(${functionString}) ( function (object) { __respond(${uuid}, object) }, function (error) { __respond(${uuid}, null, error) } )'); }); } ``` With these two pieces, I can now have a promise style executeJavaScript: ``` var backgroundColor = await executeJavaScript(function(resolve, reject) { resolve(document.body.style.background) }); ``` However, I don't like there being a global __respond method in a third party site that sends arbitrary data back to the main process. Sure, the fact that its protected by uuid and just sending data back for a promise to resolve is OK, but I'd prefer something scope protected like I could do if it was my own page and the communication could happen solely through message passing. However, I _can't_ use message passing to get the data into the web view in question because it is third party websites that have CSP turned on, and as such sending a code string and evaling it fails. It would be nice to simply build in the promise style resolve/reject into executeJavaScript such that it could easily return values.
https://github.com/electron/electron/issues/7532
https://github.com/electron/electron/pull/7533
cf0cd5b50b38d05f79829105b9c78d6a38436a6c
7e90bb47a5cd1c22f57fe5d47cb66e2896af3921
2016-10-08T22:46:55Z
c++
2016-11-03T17:32:21Z
closed
electron/electron
https://github.com/electron/electron
7,525
["docs/tutorial/online-offline-events.md"]
online-offline-events tutorial is misleading
docs/tutorial/online-offline-events.md The docs use the `navigator.onLine()` statement and events as an indicator if a browser is on/offline. This is not a good idea, as this will only tell you if a user's computer is connected to a local network - not if they have internet connectivity. Electron users will be using this tutorial to create offline pages, which simply won't appear in a large percentage of cases where there is no connectivity. I know because we have had lots of user reports of a blank screen where nothing can be clicked :-) Either the tutorial article should be altered to be shown offline when the `window.loadURL` statement fails, the tutorial removed, or have a big red warning at the top saying that it will be useless in a good chunk of cases.
https://github.com/electron/electron/issues/7525
https://github.com/electron/electron/pull/7608
902a8c57bd098cb2a94d180ae9a998b581eb037c
9367c764be6645eb034edcd2366592707940159e
2016-10-07T13:10:09Z
c++
2016-10-13T21:17:07Z
closed
electron/electron
https://github.com/electron/electron
7,519
["lib/browser/guest-window-manager.js", "spec/api-browser-window-spec.js"]
Unable to use `window.open` in [email protected]
- Electron version: 1.4.3 - Operating system: Linux Mint 17.1 We recently received an error report of `karma-electron` no longer working with [email protected] (https://github.com/twolfson/karma-electron/issues/16). After some debugging, we determined this is being caused by breaking functionality `window.open`. We have set up a minimal gist to reproduce the issue: https://gist.github.com/twolfson/990cef4aa6dfca94282cf012a590a1e5 The stack trace we are getting is: ``` /home/todd/github/gist-electron-cannot-set-openerid/index.js:4 throw err; ^ TypeError: Cannot set property 'openerId' of undefined at mergeBrowserWindowOptions (/home/todd/github/gist-electron-cannot-set-openerid/node_modules/electron/dist/resources/electron.asar/browser/guest-window-manager.js:44:35) at EventEmitter.<anonymous> (/home/todd/github/gist-electron-cannot-set-openerid/node_modules/electron/dist/resources/electron.asar/browser/guest-window-manager.js:144:13) at emitMany (events.js:127:13) at EventEmitter.emit (events.js:201:7) at WebContents.<anonymous> (/home/todd/github/gist-electron-cannot-set-openerid/node_modules/electron/dist/resources/electron.asar/browser/api/web-contents.js:219:13) at emitTwo (events.js:106:13) at WebContents.emit (events.js:191:7) ``` which is likely caused by the changes to `browser/guest-window-manager.js`.
https://github.com/electron/electron/issues/7519
https://github.com/electron/electron/pull/7520
4d7050553c4277222d06a71837f9b18173cc0d2a
9339853448ec08908008d28da7a48b173027f0b5
2016-10-07T00:23:18Z
c++
2016-10-07T17:10:40Z
closed
electron/electron
https://github.com/electron/electron
7,517
["docs/api/dialog.md", "lib/browser/api/dialog.js"]
Keyboard shortcuts/accelerators for dialog buttons
## Problem Windows and Linux allow keyboard accelerators (one-key shortcuts) in dialogs which would be useful to be able to access via the Dialog module in Electron in a safe way. Today the underlying API on Windows (and I suspect Linux) take & as the signal that the following letter in the button is the accelerator and Atom passes that through e.g. `dialog.showMessageBox({message: 'Your changes will be lost unless you save them.', buttons: [ '&Don\'t Save', '&Save' ]})` Renders as; ![image](https://cloud.githubusercontent.com/assets/118951/19169473/84d04d66-8bc9-11e6-9f3c-2ca843de8546.png) macOS doesn't support that syntax and will display the ampersand in-place. This means developers using Electron must wrap all their calls to Dialog with appropriate logic to either add or strip the & before passing through.
https://github.com/electron/electron/issues/7517
https://github.com/electron/electron/pull/8308
0e5fc9c4e4ce78b26059c3d856cac03fecb116ec
0a7dccbad8ecc649c3a17bece4f7ba12557f901a
2016-10-06T20:43:36Z
c++
2017-01-06T17:55:06Z
closed
electron/electron
https://github.com/electron/electron
7,490
["atom/browser/api/atom_api_web_contents.cc", "spec/api-browser-window-spec.js", "spec/static/main.js"]
Sandbox mode: "Check failed: !wrapper_.IsEmpty()" crash after preventDefault in new-window
- Electron version: 1.4.2 - Operating system: macOS 10.12 STEPS: 1. Run in shell: `~/Downloads/electron-v1.4.2-darwin-x64/Elec ron.app/Contents/MacOS/Electron .` 2. Click `click me` in the window. 3. Wait for 30-70 seconds for the app to crash. index.js ``` const { BrowserWindow, app } = require('electron'); let win; app.on('ready', () => { win = new BrowserWindow({ webPreferences: { sandbox: true } }) win.loadURL(`file://${__dirname}/index.html`) win.webContents.on('new-window', (e, url) => e.preventDefault()) } ``` index.html ``` <!DOCTYPE html> click here <script> document.onclick = () => window.open('second.html', '_blank', 'width=800,height=200,location=0,scrollbars=0,status=0') </script> ``` Console text when crashed ``` [24501:1004/173223:FATAL:wrappable.cc(24)] Check failed: !wrapper_.IsEmpty(). 0 Electron Framework 0x0000000109b11cc3 _ZN4base8internal14NarrowingRangeIilE3minEv + 434723 1 Electron Framework 0x0000000109b29577 _ZN4base8internal14NarrowingRangeIilE3minEv + 531159 2 Electron Framework 0x0000000109a790f5 _ZN4mate13WrappableBase10GetWrapperEv + 101 3 Electron Framework 0x000000010998a2b9 _ZN4mate12EventEmitterIN4atom3api11WebContentsEE10GetWrapperEv + 9 4 Electron Framework 0x000000010998d009 _ZN4mate12EventEmitterIN4atom3api11WebContentsEE14EmitWithSenderIJiEEEbRKN4base16BasicStringPieceINSt3__112basic_stringIcNS8_11char_traitsIcEENS8_9allocatorIcEEEEEEPN7content11WebContentsEPN3IPC7MessageEDpRKT_ + 89 5 Electron Framework 0x0000000109983a13 _ZN4mate12EventEmitterIN4atom3api11WebContentsEE4EmitIJiEEEbRKN4base16BasicStringPieceINSt3__112basic_stringIcNS8_11char_traitsIcEENS8_9allocatorIcEEEEEEDpRKT_ + 19 6 Electron Framework 0x00000001099839f1 _ZN4atom3api11WebContents17RenderViewDeletedEPN7content14RenderViewHostE + 81 7 Electron Framework 0x0000000109982727 _ZN4atom3api11WebContentsD2Ev + 199 8 Electron Framework 0x0000000109982819 _ZN4atom3api11WebContentsD1Ev + 9 9 Electron Framework 0x00000001099828ae _ZN4atom3api11WebContentsD0Ev + 14 10 Electron Framework 0x00000001099828cd _ZThn48_N4atom3api11WebContentsD0Ev + 13 11 Electron Framework 0x0000000109a79383 _ZN4mate13WrappableBase18SecondWeakCallbackERKN2v816WeakCallbackInfoIS0_EE + 19 12 libnode.dylib 0x000000010dd8c396 _ZN2v88internal13GlobalHandles31DispatchPendingPhantomCallbacksEb + 854 13 libnode.dylib 0x000000010dd8c42e _ZN2v88internal13GlobalHandles31PostGarbageCollectionProcessingENS0_16GarbageCollectorENS_15GCCallbackFlagsE + 46 14 libnode.dylib 0x000000010dd9b8f8 _ZN2v88internal4Heap24PerformGarbageCollectionENS0_16GarbageCollectorENS_15GCCallbackFlagsE + 1768 15 libnode.dylib 0x000000010dd9ad44 _ZN2v88internal4Heap14CollectGarbageENS0_16GarbageCollectorEPKcS4_NS_15GCCallbackFlagsE + 676 16 libnode.dylib 0x000000010dd9aa48 _ZN2v88internal4Heap26CollectAllAvailableGarbageEPKc + 104 17 libnode.dylib 0x000000010da30914 _ZN2v87Isolate21LowMemoryNotificationEv + 196 18 Electron Framework 0x00000001099ba430 _ZNK4base8internal15RunnableAdapterIMN2v87IsolateEFvvEE3RunIPS3_JEEEvOT_DpOT0_ + 32 19 Electron Framework 0x00000001099ba3f9 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKNS0_15RunnableAdapterIMN2v87IsolateEFvvEEEJPS6_EEEvOT_DpOT0_ + 9 20 Electron Framework 0x00000001099ba3e1 _ZN4base8internal7InvokerINS0_9BindStateINS0_15RunnableAdapterIMN2v87IsolateEFvvEEEJNS0_17UnretainedWrapperIS5_EEEEEFvvEE7RunImplIRKS8_RKNSt3__15tupleIJSA_EEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE + 33 21 Electron Framework 0x00000001099ba304 _ZN4base8internal7InvokerINS0_9BindStateINS0_15RunnableAdapterIMN2v87IsolateEFvvEEEJNS0_17UnretainedWrapperIS5_EEEEEFvvEE3RunEPNS0_13BindStateBaseE + 20 22 Electron Framework 0x0000000109b6c269 _ZN4base8internal14NarrowingRangeIilE3minEv + 804809 23 Electron Framework 0x0000000109b121bb _ZN4base8internal14NarrowingRangeIilE3minEv + 435995 24 Electron Framework 0x0000000109b32f8c _ZN4base8internal14NarrowingRangeIilE3minEv + 570604 25 Electron Framework 0x0000000109b3329c _ZN4base8internal14NarrowingRangeIilE3minEv + 571388 26 Electron Framework 0x0000000109b3387b _ZN4base8internal14NarrowingRangeIilE3minEv + 572891 27 Electron Framework 0x0000000109b07b49 _ZN4base8internal14NarrowingRangeIilE3minEv + 393385 28 Electron Framework 0x0000000109b29f4a _ZN4base8internal14NarrowingRangeIilE3minEv + 533674 29 Electron Framework 0x0000000109b07534 _ZN4base8internal14NarrowingRangeIilE3minEv + 391828 30 CoreFoundation 0x00007fff832e6551 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 31 CoreFoundation 0x00007fff832c76bd __CFRunLoopDoSources0 + 557 32 CoreFoundation 0x00007fff832c6bb6 __CFRunLoopRun + 934 33 CoreFoundation 0x00007fff832c65b4 CFRunLoopRunSpecific + 420 34 HIToolbox 0x00007fff82867f6c RunCurrentEventLoopInMode + 240 35 HIToolbox 0x00007fff82867da1 ReceiveNextEventCommon + 432 36 HIToolbox 0x00007fff82867bd6 _BlockUntilNextEventMatchingListInModeWithFilter + 71 37 AppKit 0x00007fff80f5e5f5 _DPSNextEvent + 1093 38 AppKit 0x00007fff8166e8eb -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1637 39 AppKit 0x00007fff80f52fbd -[NSApplication run] + 926 40 Electron Framework 0x0000000109b0837e _ZN4base8internal14NarrowingRangeIilE3minEv + 395486 41 Electron Framework 0x0000000109b07984 _ZN4base8internal14NarrowingRangeIilE3minEv + 392932 42 Electron Framework 0x0000000109b492d1 _ZN4base8internal14NarrowingRangeIilE3minEv + 661553 43 Electron Framework 0x000000010a268f6b _ZN4base8internal14NarrowingRangeIilE3minEv + 8131787 44 Electron Framework 0x000000010a268dc0 _ZN4base8internal14NarrowingRangeIilE3minEv + 8131360 45 Electron Framework 0x000000010a26b2c2 _ZN4base8internal14NarrowingRangeIilE3minEv + 8140834 46 Electron Framework 0x000000010a26530d _ZN4base8internal14NarrowingRangeIilE3minEv + 8116333 47 Electron Framework 0x000000010a1ce100 _ZN4base8internal14NarrowingRangeIilE3minEv + 7497312 48 Electron Framework 0x000000010a1cd2e6 _ZN4base8internal14NarrowingRangeIilE3minEv + 7493702 49 Electron Framework 0x0000000109922d47 AtomMain + 71 50 Electron 0x000000010991cf26 main + 38 51 libdyld.dylib 0x00007fff98306255 start + 1 52 ??? 0x0000000000000002 0x0 + 2 Trace/BPT trap: 5 ```
https://github.com/electron/electron/issues/7490
https://github.com/electron/electron/pull/8377
070bbcfc3d5cea9dd288212faf6e57e2c69b0815
9ff1f6bbde6b33e4a94af5d88b669e183da28332
2016-10-05T00:44:13Z
c++
2017-01-12T19:43:35Z
closed
electron/electron
https://github.com/electron/electron
7,474
["atom/app/node_main.cc", "atom/common/api/atom_bindings.cc", "atom/common/api/atom_bindings.h", "atom/common/crash_reporter/crash_reporter.cc", "atom/common/crash_reporter/crash_reporter.h", "spec/api-crash-reporter-spec.js", "spec/fixtures/module/crash.js"]
Crash Reporter submits crash report with only minidump and no data
- Electron version: 0.37.6 - Operating system: Mac OS X The crash reporter works well for our product in Windows and Linux. But in Mac OS X, apart from the usual crash reports, we are seeing quite a few getting submitted with just the minidump and no other data (neither the default ones nor the extra). Has anyone seen such a case? The crash report submission is successful, which leads me to believe that crashReporter.start() was successful, as that is how the crashReporter could have gotten the submitUrl. But why none of the other data failed to pass through is the question. Apologies, if this is not the right place for questions on the electron crash reporter behaviors.
https://github.com/electron/electron/issues/7474
https://github.com/electron/electron/pull/8109
61aff5ed35d4b4ffc29745feefe6a1d2dc41bc47
ce472315f4b2b2fc4e34b74e5b07b10247e82377
2016-10-04T02:07:11Z
c++
2017-01-24T22:02:47Z
closed
electron/electron
https://github.com/electron/electron
7,469
["atom/browser/api/atom_api_system_preferences.cc", "atom/browser/api/atom_api_system_preferences.h", "atom/browser/api/atom_api_system_preferences_win.cc", "docs/api/system-preferences.md", "spec/api-system-preferences-spec.js"]
Electron app doesn't support High Contrast mode
Electron version: 0.34 Operating system: windows, mac osx and linux I noticed when I turn on the High Contrast mode, my electron app doesn't react accordingly. Has it been the issue in the older version ? We are going to adopt the 1.3.3 version soon. Has this issue been resolved in the newer version? Is there any app out in the market(you're aware of) which is using the latest version of electron. I would like to do some accessibility testing. Thanks !
https://github.com/electron/electron/issues/7469
https://github.com/electron/electron/pull/7518
d5b3ef538076b11786d6cb56b5000ff73ea557e8
2a3bcdcaab5dcdb17d58f7235d27d5df1a35a1b7
2016-10-03T21:11:49Z
c++
2016-10-11T10:31:34Z
closed
electron/electron
https://github.com/electron/electron
7,467
["atom/common/keyboard_util.cc", "atom/common/keyboard_util.h", "atom/common/native_mate_converters/blink_converter.cc", "spec/api-web-contents-spec.js", "spec/fixtures/pages/key-events.html", "spec/fixtures/pages/onkeyup.html", "spec/webview-spec.js"]
Accelerator for Tab key has stopped working on OS X
- Electron version: 1.4.0 - Operating system: OS X 10.10.5 I've been using the following code to send Tab key events to a webview in my project: ``` js const webContents = webView.getWebContents(); const keyEvent = { type: 'keyDown', keyCode: 'Tab' }; webContents.sendInputEvent(keyEvent); ``` I have had no issues with this until the recent update to 1.4.0. The last version the above code works in OS X is **1.3.7**. I've tried this with the latest versions of Electron (1.4.1 & 1.4.2) with the same results. Am I doing something wrong here? Is this a known issue?
https://github.com/electron/electron/issues/7467
https://github.com/electron/electron/pull/7528
2a3bcdcaab5dcdb17d58f7235d27d5df1a35a1b7
0baa60caaba9615bf8937c9751c2a72440b57cfa
2016-10-03T16:07:37Z
c++
2016-10-11T10:34:05Z
closed
electron/electron
https://github.com/electron/electron
7,430
["atom/renderer/api/atom_api_web_frame.cc", "atom/renderer/api/atom_api_web_frame.h", "docs/api/web-frame.md", "spec/api-web-frame-spec.js"]
More control over the individual flags in RegisterURLSchemeAsPrivileged
- Electron version: 1.4.1 - Operating system: - RegisterURLSchemeAsPrivileged sets the scheme's policies to: - Secure - Bypassing CSP - Allowing Service Workers - Supporting Fetch API - CORS Enabled I want all of those except Bypassing CSP. (Correct me if I'm wrong: Bypassing CSP means I couldn't enforce, say, 'object-src none', because that scheme would bypass the object-src policy. If I'm wrong, please LMK -- this may be a non-issue.) Could we add an options argument to RegisterURLSchemeAsPrivileged for configuring which is enabled? Something like: ``` js webFrame.registerURLSchemeAsPrivileged('foo', { secure: true, bypassCSP: false, allowServiceWorkers: true, supportFetchAPI: true, corsEnabled: true }) ``` For backwards compatibility, the flags would default to `true`, so my usecase would be: ``` js webFrame.registerURLSchemeAsPrivileged('foo', { bypassCSP: false }) ``` If 👍 , I'm happy to write a PR.
https://github.com/electron/electron/issues/7430
https://github.com/electron/electron/pull/7665
632739ec6e73ba43da8ac008c7bc1c008f645721
ad48aeeea436ac45b8051c503dba2aff901897e4
2016-09-30T17:05:12Z
c++
2016-10-24T06:56:18Z
closed
electron/electron
https://github.com/electron/electron
7,426
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_web_contents.h"]
backgroundThrottling:false isn't persistent on "Reload"
- Electron version: 1.4.0 - Operating system: OSX When the Electron window is reloaded, the backgroundThrottling:false flag isn't persisted I tried to find something in the documentation to make it persistent, but couldn't find anything I'm assuming this is a bug
https://github.com/electron/electron/issues/7426
https://github.com/electron/electron/pull/8298
6ea1bacc73d407d566b9cc4c18e2ee68668680e9
fc75080c287eaafac9dcae567e5ee924b908afad
2016-09-30T15:02:07Z
c++
2016-12-29T21:31:09Z
closed
electron/electron
https://github.com/electron/electron
7,414
["lib/browser/api/menu-item.js", "lib/browser/api/menu.js", "spec/api-menu-spec.js"]
MenuItem constructor ignores custom properties
- Electron version: 1.4.0 - Operating system: All In reference to issue #54: Adding custom fields seems to work only when building a menu from a template. If the MenuItem constructor is used, which takes the same structure as a template as argument, custom fields are ignored/not added to the MenuItem instance. This works: ``` let tmpl = { "label": "menu 1", "commandData": "foo", "submenu": [ { "label" "item 1", "commandData": "bar" } ] } let mnu = new Menu.buildFromTemplate(tmpl); console.log(mnu.commandData); // --> foo console.log(mnu.submenu.items[0].commandData); // --> bar ``` This does not work (as expected): ``` let tmpl = { "label": "menu 2", "commandData": "foo", "submenu": [] } let mnu = new Menu.buildFromTemplate(tmpl); mnu.submenu.append(new MenuItem({ "label" "item 1", "commandData": "bar" })); console.log(mnu.commandData); // --> foo console.log(mnu.submenu.items[0].commandData); // --> undefined ```
https://github.com/electron/electron/issues/7414
https://github.com/electron/electron/pull/7498
13f9a6c273fc10b0421c5279e34664ec8a0a697d
d4a8a64ba7be50906ed5116669b7c06d8da3574f
2016-09-29T17:29:33Z
c++
2016-10-11T21:24:13Z
closed
electron/electron
https://github.com/electron/electron
7,406
["atom/browser/mac/atom_application_delegate.mm"]
"Show Tab Bar" menu item is automatically added on macOS Sierra
- Electron version: 1.4.1 - Operating system: macOS Sierra 10.12 At the moment, "Show Tab Bar" menu item is automatically added under View. I think the desired behavior would be to let developer to add the item manually via role-based menu item. <img width="444" alt="b65e490a-80b1-11e6-9263-5709c2b27b66" src="https://cloud.githubusercontent.com/assets/525332/18954430/a7f71fd4-8685-11e6-86e4-5a4f9f5f519c.png">
https://github.com/electron/electron/issues/7406
https://github.com/electron/electron/pull/7415
1b5db42ec66e005ff4b1c7509bf93c10b55c27e2
11d16a73426d861bb9eee616e426a88de83e9333
2016-09-29T12:49:29Z
c++
2016-09-30T09:23:54Z
closed
electron/electron
https://github.com/electron/electron
7,403
["atom/browser/atom_browser_client.cc"]
Devtools: Saving a CPU profile produces empty file
- Electron version: 1.3.7 - Operating system: Mac OS and Windows 10 Steps: - run a CPU profile from dev tools - stop it (you get some output) - save the file => the resulting file has 0KB I cannot reproduce in Chrome 53, but I can reproduce in a bare electron app.
https://github.com/electron/electron/issues/7403
https://github.com/electron/electron/pull/7413
b3b9994ce84fa914182098350d2941506cf34447
b14870d9a139dd7e5966c8e24f218dd347f4ac79
2016-09-29T11:29:12Z
c++
2016-09-29T17:52:47Z
closed
electron/electron
https://github.com/electron/electron
7,401
["atom/browser/native_window_mac.mm"]
Application freezes when shows / closes the modal dialog repeatedly
- Electron version: 1.4.1 - Operating system: MacOSX 10.10, 10.12 From Electron version 1.2.4, `BrowserWindow` can accept `parent:` and `modal:` parameter. I modified [**electron-api-demos**](https://github.com/electron/electron-api-demos) render-process/windows/create-window.js like this: ``` javascript newWindowBtn.addEventListener('click', function (event) { const modalPath = path.join('file://', __dirname, '../../sections/windows/modal.html') const parentWindow = require('electron').remote.getCurrentWindow(); // Parent Window let win = new BrowserWindow({ parent: parentWindow, modal: true, width: 400, height: 320 }); //let win = new BrowserWindow({width: 400, height: 320 }); // Original code win.on('close', function () { win = null }) win.loadURL(modalPath) win.show() }) ``` Start api-demo and select "Create and manage windows" demo. When clicking "View Demo", a modal dialog comes down from the top edge of the application window. Then close it with clicking "Close this window" link (at this moment, the modal dialog behaves strangely in closing). Furthermore, click "View Demo" and "Close this window" again, then the dialog went blank. Also the application froze. It occurs 10/10 in my environment (10.10 and 10.12). ![electronmodaldialogissue](https://cloud.githubusercontent.com/assets/10972221/18944883/bdb7e5e2-8662-11e6-808d-3d435e0022c7.gif) Once it falls in this status, the app can be terminated only by killing the process. In Electron 1.2.5 and 1.2.6, this phenomenon happens occasionally. (I found it tends to occur after minimized -> recover the app with some other background task like build some program) I tried commented out a line from 1.4.1's `atom/browser/native_window_mac.mm` as it has the difference from 1.2.5: ``` cpp void NativeWindowMac::Close() { // When this is a sheet showing, performClose won't work. if (is_modal() && parent() && IsVisible()) { //[parent()->GetNativeWindow() endSheet:window_]; // Commented out this line CloseImmediately(); return; } ... ``` After this modification, the frequency of the phenomenon seems to be the same as 1.2.5. **Could you tell me the workaround about this issue?**
https://github.com/electron/electron/issues/7401
https://github.com/electron/electron/pull/7417
fb4147455529f251d35810292a055a9ee58339e5
ff6a8fac2a370059aaf54dc027203bfedc08c630
2016-09-29T08:16:45Z
c++
2016-09-30T20:08:35Z
closed
electron/electron
https://github.com/electron/electron
7,389
["vendor/brightray"]
Check failed: cert_transparency_verifier_
- Electron version: 1.4.1 - Operating system: Mac OS X 10.10 I get the following fatal error when I try to use electron to join video conferencing hosted by https://my.videxio.com/. The app crashes directly. ``` [55132:0928/130545:FATAL:ssl_client_socket_impl.cc(527)] Check failed: cert_transparency_verifier_. 0 Electron Framework 0x000000010a959863 _ZN4base8internal14NarrowingRangeIilE3minEv + 434723 1 Electron Framework 0x000000010a971117 _ZN4base8internal14NarrowingRangeIilE3minEv + 531159 2 Electron Framework 0x000000010c03d35b _ZN4base8internal14NarrowingRangeIilE3minEv + 24435995 3 Electron Framework 0x000000010c18fdf2 _ZN4base8internal14NarrowingRangeIilE3minEv + 25823154 4 Electron Framework 0x000000010b3f76cf _ZN4base8internal14NarrowingRangeIilE3minEv + 11567247 5 Electron Framework 0x000000010b942cae _ZN4base8internal14NarrowingRangeIilE3minEv + 17118830 6 Electron Framework 0x000000010c03b79d _ZN4base8internal14NarrowingRangeIilE3minEv + 24428893 7 Electron Framework 0x000000010c1944f5 _ZN4base8internal14NarrowingRangeIilE3minEv + 25841333 8 Electron Framework 0x000000010a959d5b _ZN4base8internal14NarrowingRangeIilE3minEv + 435995 9 Electron Framework 0x000000010a97ab2c _ZN4base8internal14NarrowingRangeIilE3minEv + 570604 10 Electron Framework 0x000000010a97ae3c _ZN4base8internal14NarrowingRangeIilE3minEv + 571388 11 Electron Framework 0x000000010a97b19b _ZN4base8internal14NarrowingRangeIilE3minEv + 572251 12 Electron Framework 0x000000010a94eb45 _ZN4base8internal14NarrowingRangeIilE3minEv + 390405 13 Electron Framework 0x000000010a990e71 _ZN4base8internal14NarrowingRangeIilE3minEv + 661553 14 Electron Framework 0x000000010a9b03bd _ZN4base8internal14NarrowingRangeIilE3minEv + 789885 15 Electron Framework 0x000000010b0bb7d8 _ZN4base8internal14NarrowingRangeIilE3minEv + 8176024 16 Electron Framework 0x000000010b0bb9bb _ZN4base8internal14NarrowingRangeIilE3minEv + 8176507 17 Electron Framework 0x000000010a9b04af _ZN4base8internal14NarrowingRangeIilE3minEv + 790127 18 Electron Framework 0x000000010a9ac8c7 _ZN4base8internal14NarrowingRangeIilE3minEv + 774791 19 libsystem_pthread.dylib 0x00007fff9352705a _pthread_body + 131 20 libsystem_pthread.dylib 0x00007fff93526fd7 _pthread_body + 0 21 libsystem_pthread.dylib 0x00007fff935243ed thread_start + 13 ```
https://github.com/electron/electron/issues/7389
https://github.com/electron/electron/pull/7393
e1d68fa3cda8f6cd7d5aa97c9e6f50ae8e5e3f1f
15b844941137f3c00da1074eb96cbb83f6024ec0
2016-09-28T17:08:56Z
c++
2016-09-29T08:56:31Z
closed
electron/electron
https://github.com/electron/electron
7,351
["docs/api/dialog.md", "lib/browser/rpc-server.js", "lib/common/init.js", "lib/common/parse-features-string.js", "lib/renderer/api/remote.js", "lib/renderer/override.js"]
Uncaught Error remote.js
- Electron version: 1.3.5 - 1.4.1 - Operating system: MacOS I keep getting this error if i start the app with dev tools open and then hit refresh, from the second time it keeps showing this error and i don't know why happens, first time when i run the app everything is ok. This doesn't happen in 1.2.6 ``` remote.js:217 Uncaught Error: Cannot read property 'object' of undefined TypeError: Cannot read property 'object' of undefined at ObjectsRegistry.get (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/objects-registry.js:44:28) at EventEmitter.<anonymous> (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/rpc-server.js:306:31) at emitMany (events.js:127:13) at EventEmitter.emit (events.js:201:7) at WebContents.<anonymous> (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/api/web-contents.js:219:13) at emitTwo (events.js:106:13) at WebContents.emit (events.js:191:7) ``` And after the first run the app is full of another error ``` remote.js:209 Uncaught (in promise) Error: Cannot read property 'object' of undefined TypeError: Cannot read property 'object' of undefined at ObjectsRegistry.get (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/objects-registry.js:44:28) at EventEmitter.<anonymous> (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/rpc-server.js:305:31) at emitMany (events.js:127:13) at EventEmitter.emit (events.js:201:7) at WebContents.<anonymous> (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/api/web-contents.js:218:13) at emitTwo (events.js:106:13) at WebContents.emit (events.js:191:7) at ObjectsRegistry.get (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/objects-registry.js:44:28) at EventEmitter.<anonymous> (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/rpc-server.js:305:31) at emitMany (events.js:127:13) at EventEmitter.emit (events.js:201:7) at WebContents.<anonymous> (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/api/web-contents.js:218:13) at emitTwo (events.js:106:13) at WebContents.emit (events.js:191:7) at metaToValue (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:209:13) at remoteMemberFunction (/Users/Paul/Work/js/desktop/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:110:18) at ```
https://github.com/electron/electron/issues/7351
https://github.com/electron/electron/pull/8120
c27633dff4eec32030a9c4c887fd4808ecc2a7c6
a9d4d9ad85f8969dbc532dc9781645c01da4bdbc
2016-09-26T15:50:23Z
c++
2016-12-05T17:29:11Z
closed
electron/electron
https://github.com/electron/electron
7,347
["atom/renderer/atom_render_view_observer.cc"]
Hit testing is wrong for drag areas in frameless window (Windows)
- Electron version: 1.4.1 - Operating system: Windows 7 Pro, x64 (with display set to 150%) **Problem description** When using a BrowserWindow with `frame: false`, electron does not always appear to be doing proper hit testing (mouse over, click, etc) for draggable areas. It works great with my stock Windows settings, but if you scale up your display to 150% it breaks. Unfortunately, some laptops/PCs ship with this setting NOT being 100%. **Steps to reproduce** - Have a machine w/ Windows 7 (physical or VM) - Right click desktop, pick Personalize - Click display in the bottom left corner - Pick 150% and hit apply ![win7-magnifier](https://cloud.githubusercontent.com/assets/4733304/18824724/148b92fc-8379-11e6-9890-b945a2ff717d.png) - open a shell and clone my demo project: - `git clone [email protected]:bsclifton/electron-quick-start.git` - `cd electron-quick-start` - `npm start` - You'll see the following: <img width="713" alt="screen shot 2016-09-25 at 11 31 11 pm" src="https://cloud.githubusercontent.com/assets/4733304/18824781/7559b42e-8379-11e6-9b80-b87dae4b49c1.png"> The red area is tagged with `-webkit-app-region: drag` and the overlapping yellow area is tagged with `-webkit-app-region: no-drag`. - Try clicking and dragging in the red area. You'll notice it's inconsistent. - Close program, set display scaling back to 100% and relaunch program - Notice that dragging works great
https://github.com/electron/electron/issues/7347
https://github.com/electron/electron/pull/7362
53d4c363324964762469ce581eb533aaf412b102
c51982a2319202ba86f2db820ee1b89cd8abe826
2016-09-26T06:44:07Z
c++
2016-09-28T11:42:17Z
closed
electron/electron
https://github.com/electron/electron
7,334
["script/lib/config.py"]
Windows 10 AU new emoji doesn't show properly
- Electron version: 1.4.1 - Operating system: Windows 10 AU Some new emoji can't display and show up as a square. i.e. http://emojipedia.org/first-place-medal/ <- this one can display in Edge, Opera and even in notepad.
https://github.com/electron/electron/issues/7334
https://github.com/electron/electron/pull/7491
43f4eb76c4da51f2694a44d2a25eb83023839175
ebaeec16774ea47f4db87de7c8e677e8aa8b459c
2016-09-24T03:41:01Z
c++
2016-10-05T05:15:55Z
closed
electron/electron
https://github.com/electron/electron
7,312
["atom/app/atom_login_helper.mm", "atom/app/resources/mac/loginhelper-Info.plist", "atom/browser/browser_mac.mm", "atom/common/platform_util.h", "atom/common/platform_util_mac.mm", "docs/api/app.md", "docs/tutorial/mac-app-store-submission-guide.md", "electron.gyp", "filenames.gypi"]
Support LoginItem API in Mac App Store builds
- Electron version: N/A - Operating system: Mac or Windows I don't know how I've only discovered these methods now 😄 but anyway... Would an app get rejected by the MAS if it used [`app.setLoginItemSettings`](http://electron.atom.io/docs/api/app/#appsetloginitemsettingssettings-macos-windows) for example? The [Mac App Store submission guide](http://electron.atom.io/docs/tutorial/mac-app-store-submission-guide/#limitations-of-mas-build) doesn't list it as a limitation but I would assume that it isn't MAS-friendly. Although, it would be _great_ if it was compatible. I guess it depends on how it's implemented underneath (i.e. whether it reaches out of the sandbox or not, etc.) cc @kevinsawicki --- Related: https://github.com/Teamwork/node-auto-launch/issues/43
https://github.com/electron/electron/issues/7312
https://github.com/electron/electron/pull/10856
bbde795a1ff38ec36e917b7393c8efbb25f97e93
4b8ab8fc970c9b99a71531402b72cde0741ea348
2016-09-22T20:52:14Z
c++
2017-11-14T12:34:50Z
closed
electron/electron
https://github.com/electron/electron
7,309
["lib/renderer/web-view/web-view.js"]
:host { display: flex } shown in the HTML content?
- Electron version: latest. - Operating system: Win 7, SP1 For a user on the above system, this CSS is shown inside, as content.. Not sure why. I noticed this CSS rule is added to a webview. Below is the normal behavior: index.html : `<webview id="server" src="about:blank" preload="./js/server-ipc.js"></webview> ` Rendered: ``` webview shadowroot <style>:host { display: flex }</style> <object is="browserplugin" type="application/browser-plugin" id="browser-plugin-1" style="flex: 1 1 auto;"></object> ``` ![iotatest](https://cloud.githubusercontent.com/assets/20187287/18754868/73e4b18e-80ea-11e6-951d-aba159f6d785.png)
https://github.com/electron/electron/issues/7309
https://github.com/electron/electron/pull/7313
4c8d0ab8043daf2444013aa58c25070904632d8d
9850af93c9b4f72fed925a3a70449a0d3ae8ee26
2016-09-22T15:33:35Z
c++
2016-09-27T11:03:08Z
closed
electron/electron
https://github.com/electron/electron
7,282
["atom/browser/ui/views/menu_bar.cc", "atom/browser/ui/views/menu_bar.h", "atom/browser/ui/views/submenu_button.cc", "atom/browser/ui/views/submenu_button.h"]
Window not put to front when clicking menu in other window
- Electron version: 1.3.5 - Operating system: Windows 10 Steps: - open 2 windows - stack the windows so that the one is on top of the other but you can still see both menus in both windows - in the one window trigger the menu (e.g. File) - while the menu is open, click on the menu in the other window => the other window is not getting focus but you can still interact with the menu => this causes issues because to my knowledge I cannot find out on which window an action was invoked so my actions all target the wrong window
https://github.com/electron/electron/issues/7282
https://github.com/electron/electron/pull/7468
bb04069e83caa8c69c20eb1a02b5be148e7dc724
cf050ff9e2d7461319f706def756c488397dcbff
2016-09-21T06:13:32Z
c++
2016-10-04T05:22:49Z
closed
electron/electron
https://github.com/electron/electron
7,279
["atom/browser/ui/views/menu_bar.cc", "atom/browser/ui/views/submenu_button.cc", "atom/browser/ui/views/submenu_button.h"]
Menu doesn't draw pressed state
- Electron version: 1.4.0 - Operating system: Windows 7 (x64) I launch Electron and then press `ALT` to show menu. Now you mouse click on any top-level menu item, active menu item will NOT be changed to down state. I checked with 1.3.5, it is fine.
https://github.com/electron/electron/issues/7279
https://github.com/electron/electron/pull/7397
df0bda058fd3d367fd8968ead27b928391aac500
b3b9994ce84fa914182098350d2941506cf34447
2016-09-21T01:57:35Z
c++
2016-09-29T16:15:12Z
closed
electron/electron
https://github.com/electron/electron
7,225
["atom/browser/api/atom_api_power_monitor.cc", "atom/browser/api/atom_api_screen.cc", "docs/api/power-monitor.md", "docs/api/screen.md", "lib/common/init.js"]
App not ready error not thrown when requiring powerMonitor too early
- Electron version: v1.4.0 - Operating system: macOS 10.11.6 Given the following `main.js`: ``` js const {powerMonitor} = require('electron') ``` I get the following exception: ``` $ electron . App threw an error during load TypeError: Cannot match against 'undefined' or 'null'. at Object.<anonymous> (/usr/local/lib/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/api/power-monitor.js:2:46) at Module._compile (module.js:556:32) at Object.Module._extensions..js (module.js:565:10) at Module.load (module.js:473:32) at tryModuleLoad (module.js:432:12) at Function.Module._load (module.js:424:3) at Module.require (module.js:483:17) at require (internal/module.js:20:19) at Object.get [as powerMonitor] (/usr/local/lib/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/api/exports/electron.js:65:14) at Object.<anonymous> (electron-test/main.js:1:87) ```
https://github.com/electron/electron/issues/7225
https://github.com/electron/electron/pull/7226
27bc6c7883344926607f97009d6ed07b3456532b
ffe931bde7d4fb0893a0b9591918b3a1c69f95c1
2016-09-16T16:00:30Z
c++
2016-09-19T06:25:18Z
closed
electron/electron
https://github.com/electron/electron
7,221
["vendor/brightray"]
net::ERR_INSECURE_RESPONSE errors
- Electron version: 1.4.0 - Operating system: OS X 10.11.6 After updating to electron v1.4.0, I noticed getting a lot of `ERR_INSECURE_RESPONSE` from the requests in a webview. I have tried the same website (http://www.bloomberg.com/) on electron v.1.3.6 and not getting any error. ![screen shot 2016-09-16 at 4 32 28 pm](https://cloud.githubusercontent.com/assets/525332/18580059/e05e3826-7c2b-11e6-9744-4d240d2f4e03.png)
https://github.com/electron/electron/issues/7221
https://github.com/electron/electron/pull/7292
c2c48c407928bd8761ea28a5091d583e20d71e8e
296a53536dfac96bb4ee9abc5c4977185a7ac9cd
2016-09-16T08:38:43Z
c++
2016-09-22T05:11:20Z
closed
electron/electron
https://github.com/electron/electron
7,220
["lib/browser/api/app.js"]
app.commandLine.appendSwitch should auto cast arguments to string
Was doing this: `app.commandLine.appendSwitch('remote-debugging-port', devtoolsPort);` And pulling out my hair wondering why on Earth it stopped working. Now, hours later I figured out `devtoolsPort` now was no longer a string, but a number. I need a beer. - Electron version: 1.3.3 - Operating system: ANY
https://github.com/electron/electron/issues/7220
https://github.com/electron/electron/pull/7227
b05254807b8ceff047b1414accdb9302d50ef978
e8f3cf164b7e9e7181826735e7b85153b0d2706e
2016-09-16T03:24:22Z
c++
2016-09-19T17:22:28Z
closed
electron/electron
https://github.com/electron/electron
7,210
["docs/api/shell.md", "shell/browser/ui/inspectable_web_contents_impl.cc", "shell/common/api/atom_api_shell.cc", "shell/common/platform_util.h", "shell/common/platform_util_linux.cc", "shell/common/platform_util_mac.mm", "shell/common/platform_util_win.cc", "spec/ts-smoke/electron/main.ts"]
shell.openItem() is not async
- Electron version: 1.3.6 - Operating system: Windows 7 x64 - Other: Microsoft Office 2013 (will make more sense in a bit) `shell.openItem()` is a blocking call, it would be nice if it's async or has an async version to handle synchronous external application behavior. Reproduce: Open a password-protected Microsoft Excel file, `shell.openItem()` will be blocking until the Password window is submitted or dismissed. Consequently Microsoft Word does not have this issue. Related to #2761.
https://github.com/electron/electron/issues/7210
https://github.com/electron/electron/pull/20682
fd70ac117394bee04296295462c4edeb15f2b314
d3622f9c37e8cd94e47206bb6211346011d5f76b
2016-09-14T22:13:53Z
c++
2019-11-08T07:08:43Z
closed
electron/electron
https://github.com/electron/electron
7,208
["atom/browser/native_window_views.cc", "atom/browser/native_window_views.h", "atom/browser/native_window_views_win.cc", "electron.gyp"]
Electron enables accessibility mode all the time with touch monitors (100% CPU usage in "Other")
- Electron version: 1.3.6 (win32-ia32 zip) - Operating system: Windows 10.0.14393 Build 14393 Create a `main.js` file that loads a wikipedia page: ``` js var electron = require('electron') var app = electron.app var BrowserWindow = electron.BrowserWindow var mainWindow; function createWindow () { mainWindow = new BrowserWindow({width: 800, height: 600}) mainWindow.loadURL(`https://en.wikipedia.org/wiki/Timi%C8%99oara`) mainWindow.webContents.openDevTools() mainWindow.on('closed', function () { mainWindow = null }) } app.on('ready', createWindow) app.on('window-all-closed', function () { if (process.platform !== 'darwin') { app.quit() } }) app.on('activate', function () { if (mainWindow === null) { createWindow() } }) ``` - run `electron.exe main.js` - scroll up and down rapidly by dragging the scrollbar - watch CPU usage or Record with the Timeline - **renderer process goes to 100% CPU usage** - main process stays at 1-2% CPU usage - both Chromium on a version before and Chrome on a version after do not have this problem. ## Electron v1.3.6 (process.versions.chrome = 52.0.2743.82) ![image](https://cloud.githubusercontent.com/assets/5047891/18516379/fb00b350-7a98-11e6-840c-8303857e276c.png) ## Chromium version 52.0.2743.0 ![image](https://cloud.githubusercontent.com/assets/5047891/18516434/4749037a-7a99-11e6-9ce7-74ae68ee55fc.png) ## Chrome version 53.0.2785.113 m (64-bit) ![image](https://cloud.githubusercontent.com/assets/5047891/18516666/22c69886-7a9a-11e6-9146-8f2996e80c00.png) ## Electron version 0.37.6 (process.versions.chrome = 49.0.2623.75) ![image](https://cloud.githubusercontent.com/assets/5047891/18516934/08ed6e3e-7a9b-11e6-9446-efdb8b8dfbb6.png) ## More info: - **Reproduces** in Electron version 0.37.6 - fyi @bbondy Reproduces in Brave 0.12.0 (Electron 1.3.10, libchromiumcontent: 52.0.2743.116) - Reproduces on Surface Book, in external monitor at 100% zoom - **Does not** reproduce on Lenovo w530 with the same Windows version - this impacts VSCode considerably (why I started looking into this) ## Hints: - The only hints I could find are when clicking on the input events and most of them in Electron appear to be waiting a long time on the main process. For Chromium 52 or Chrome 53, the total time of these events is never longer than 20-30ms, typically even shorter: ![image](https://cloud.githubusercontent.com/assets/5047891/18516749/65585ff4-7a9a-11e6-9077-0c0f2970341d.png) fyi @zcbenz @kevinsawicki @bpasero @dbaeumer
https://github.com/electron/electron/issues/7208
https://github.com/electron/electron/pull/7611
988e2334f59d8aaccdec394a9d9fa0c39920068d
3dd83772183b30e69542dd7fd11dbbbd0fcda827
2016-09-14T14:56:39Z
c++
2016-10-14T19:46:32Z
closed
electron/electron
https://github.com/electron/electron
7,202
["docs/development/build-instructions-linux.md", "docs/development/build-instructions-osx.md", "docs/development/build-instructions-windows.md"]
Mention npm run clean in build docs
- Electron version: 1.3.6 - Operating system: macOS 10.11.6 - Node: 5.12.0 - NPM: 3.8.6 - node-gyp: 3.3.1 I'm getting errors running a build from a clean checkout of current master cfe7bfd. I've installed the Xcode 8 GM seed, but _not_ the Sierra GM seed. Not sure if this setup is supported or has been tested by the core team but it's probably relatively common at the moment, so hopefully the report is useful (might of course be something else up with my environment) I've wiped my `~/.node-gyp` directory, here's my `npm list -g` output: https://gist.github.com/jwheare/96cf303335a2e18f8c28c8b03e670632 The first sign of trouble is during `./script/bootstrap.py -v`, while building `bufferutil` and `utf-8-validate`: https://gist.github.com/jwheare/00bb13d4d7c1e1ed3614c36f3de51c4e https://gist.github.com/jwheare/8acb33ca0e0c10be7bb1d46f4280e728 The rest of bootstrap appears to run correctly and exits normally. But then `./script/build.py -c D` fails building `inspectable_web_contents_view`: https://gist.github.com/jwheare/11322048eb8a4279d5b87c059b86b47a Any ideas?
https://github.com/electron/electron/issues/7202
https://github.com/electron/electron/pull/7297
c9a3ab3a81bb560015e5cd523e839fdf07d9d1d1
32543997d4ec8e28d9533b485d5ff9bf7f379ccf
2016-09-14T10:54:10Z
c++
2016-09-22T05:14:36Z
closed
electron/electron
https://github.com/electron/electron
7,196
["lib/renderer/api/remote.js", "spec/api-ipc-spec.js", "spec/fixtures/module/function-with-missing-properties.js"]
TypeError when accessing remote objects
- Electron version: 1.3.5 - Operating system: Windows 7 x64 I am running into errors randomly whenever accessing remote methods. Errors like this: ``` TypeError: Cannot read property 'object' of undefined at ObjectsRegistry.get (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\browser\objects-registry.js:44:28) at EventEmitter.<anonymous> (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\browser\rpc-server.js:305:31) at emitMany (events.js:127:13) at EventEmitter.emit (events.js:201:7) at WebContents.<anonymous> (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\browser\api\web-contents.js:218:13) at emitTwo (events.js:106:13) at WebContents.emit (events.js:191:7) at ObjectsRegistry.get (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\browser\objects-registry.js:44:28) at EventEmitter.<anonymous> (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\browser\rpc-server.js:305:31) at emitMany (events.js:127:13) at EventEmitter.emit (events.js:201:7) at WebContents.<anonymous> (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\browser\api\web-contents.js:218:13) at emitTwo (events.js:106:13) at WebContents.emit (events.js:191:7) at metaToValue (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\renderer\api\remote.js:209:13) at remoteMemberFunction (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\renderer\api\remote.js:110:18) ``` Or this: ``` TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined at setObjectMembers (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\renderer\api\remote.js:97:22) at loadRemoteProperties (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\renderer\api\remote.js:163:5) at Object.getOwnPropertyDescriptor (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\renderer\api\remote.js:178:7) at descriptor.get [as reload] (D:\dev\electron-v1.3.5-win32-x64\resources\electron.asar\renderer\api\remote.js:117:32) ``` I believe it is similar to #4733. I started getting these errors since 1.3.4. Previous versions had been working fine.
https://github.com/electron/electron/issues/7196
https://github.com/electron/electron/pull/7209
69d4cac760f43463b4417f2910c33148444ffa3f
ea244a518826bcb92485062d0b14a16e5fba7f93
2016-09-14T03:58:46Z
c++
2016-09-16T12:11:12Z
closed
electron/electron
https://github.com/electron/electron
7,190
["docs/api/clipboard.md"]
Unable to paste clipboard entry created with writeBookmark on Windows
- Electron version: v1.3.5 - Operating system: Windows 10 Based on issue: https://github.com/sindresorhus/electron-context-menu/issues/18 _What happens:_ 1. Copy a link by using `electron.clipboard.writeBookmark` 2. Focus a text field and press `CTRL+c` - nothing happens 3. Listen to `context-menu`, do a right click on a text field: `canPaste` is false I'm able to paste these bookmarks into the Chrome address bar (which seems to be the only place). _What I expected:_ 2. and 3. should paste the link into the text field. As it does on MacOS. Maybe this is intended behavior - in this case this should be documented and consistent across Mac&Win I guess.
https://github.com/electron/electron/issues/7190
https://github.com/electron/electron/pull/7293
296a53536dfac96bb4ee9abc5c4977185a7ac9cd
de9b01409b7541667e4260be7f1e3dce59d073ea
2016-09-13T17:27:27Z
c++
2016-09-22T05:13:28Z
closed
electron/electron
https://github.com/electron/electron
7,158
["atom/browser/api/frame_subscriber.cc"]
beginFrameSubscription cropped for WebView WebContents on HiDPI screens
This issue can be reproduced in the latest Electron version on a Retina device. Essentially, only the top left fourth of the screen's pixels are returned on retina screens. I presume this happens because beginFrameSubscription, even on mainWindow, does not return retina pixel data ever. Issue arrises after: https://github.com/electron/libchromiumcontent/pull/227 Issue description: https://github.com/electron/electron/issues/5665#issuecomment-245813684
https://github.com/electron/electron/issues/7158
https://github.com/electron/electron/pull/7163
9dad9478fa8074eb6891d7da2631316cfb8ca670
da677b683b49147da6a9985aa9e739ea3e2ee5d8
2016-09-09T18:00:10Z
c++
2016-09-16T12:24:53Z
closed
electron/electron
https://github.com/electron/electron
7,151
["atom/browser/api/atom_api_download_item.cc", "atom/browser/api/atom_api_web_contents.cc", "atom/browser/atom_download_manager_delegate.cc", "docs/api/web-contents.md", "docs/api/web-view-tag.md", "spec/api-session-spec.js"]
Default download savePath for URLs with a trailing slash
- Electron version: 1.3.5 - Operating system: macOS/Windows Alt-clicking a link is a default shortcut for downloading a file without a save prompt, and we make use of it in our app. But for links that end in a trailing slash, the resulting filename isn't consistent with the default file name in the save prompt. The save prompt constructs a name from the word "download" and the extension for the mime type of the file, but the prompt-less savepath is just the domain name of the link. This leads to unusable files (e.g. with a .com file extension) being saved to the filesystem. Here's my current workaround, but given the prompt does get a useful path, and Chrome behaves correctly, I imagine this might be straightforward to fix if you know where to look: ``` javascript const mime = require('mime-types'); const _ = require('lodash'); const path = require('path'); const unusedFilename = require('unused-filename'); win.webContents.session.on('will-download', function (e, item, webContents) { if (item.getSavePath() && _.last(item.getURL()) === '/') { var savePath = unusedFilename.sync(path.format({ dir: path.dirname(item.getSavePath()), name: 'download', ext: '.' + mime.extension(item.getMimeType()) })); item.setSavePath(savePath); } }); ```
https://github.com/electron/electron/issues/7151
https://github.com/electron/electron/pull/7169
ea244a518826bcb92485062d0b14a16e5fba7f93
9dad9478fa8074eb6891d7da2631316cfb8ca670
2016-09-09T11:30:16Z
c++
2016-09-16T12:19:21Z
closed
electron/electron
https://github.com/electron/electron
7,097
["docs/api/web-contents.md", "docs/api/webview-tag.md", "lib/browser/guest-view-manager.ts", "shell/browser/api/electron_api_web_contents.cc", "shell/browser/electron_navigation_throttle.cc", "spec/api-browser-window-spec.ts", "spec/fixtures/pages/webview-will-navigate-in-frame.html", "spec/webview-spec.ts"]
Add will-frame-navigate event
- Electron version: ## \* Operating system: window 7 Found in webContents listening 'will - navigate' with 'event callback function event. The preventDefault ();'can't stop jumping events in the iframe.Example: in the iframe "< a href =" github.com "> test < / a >"
https://github.com/electron/electron/issues/7097
https://github.com/electron/electron/pull/34418
2e1f803f374a1d262be21b3b4e355698e1753daa
2b9dae4b065e9fea59c90ddee2acf2c01b9ebd59
2016-09-05T09:41:42Z
c++
2023-03-28T14:55:41Z
closed
electron/electron
https://github.com/electron/electron
7,088
["lib/browser/init.js", "lib/common/init.js", "spec/node-spec.js"]
Passing React Component Reference through remote.js throws error
- Electron version: `1.3.5` - Operating system: Windows When passing a React Component from Enzyme through `remote.js` some rather interesting errors get thrown. ``` bash Error: Implement me. Unknown stdin file type! at process.getStdin [as stdin] (internal/process/stdio.js:82:15) at valueToMeta (C:\Users\Samuel\projects\Google-Play-Music-Desktop-Player-UNOFFICIAL-\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:67:35) at valueToMeta (C:\Users\Samuel\projects\Google-Play-Music-Desktop-Player-UNOFFICIAL-\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:67:18) at valueToMeta (C:\Users\Samuel\projects\Google-Play-Music-Desktop-Player-UNOFFICIAL-\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:67:18) at valueToMeta (C:\Users\Samuel\projects\Google-Play-Music-Desktop-Player-UNOFFICIAL-\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:67:18) at valueToMeta (C:\Users\Samuel\projects\Google-Play-Music-Desktop-Player-UNOFFICIAL-\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:67:18) at valueToMeta (C:\Users\Samuel\projects\Google-Play-Music-Desktop-Player-UNOFFICIAL-\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:67:18) at valueToMeta (C:\Users\Samuel\projects\Google-Play-Music-Desktop-Player-UNOFFICIAL-\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:67:18) at valueToMeta (C:\Users\Samuel\projects\Google-Play-Music-Desktop-Player-UNOFFICIAL-\node_modules\electron\dist\resources\electron.asar\renderer\api\remote.js:67:18) ``` Admittedly, passing a React Component through IPC is probably not a good plan. But as far as I am aware, any properties that can't be passed through would just be stripped on the way. I don't think an error should be thrown. Trying to make a minimal example at the moment.
https://github.com/electron/electron/issues/7088
https://github.com/electron/electron/pull/7130
45e8c40ae8cd92ecfda413fd7dace0ba8570c0b2
a0eccdfe1ee48465c797a231811057199a509279
2016-09-04T17:51:16Z
c++
2016-09-08T06:04:10Z
closed
electron/electron
https://github.com/electron/electron
7,086
["lib/browser/api/web-contents.js"]
Right click on flash player shows TypeError: Menu.buildFromTemplate is not a function
- Electron version: v1.3.5 - Operating system: Mac OSX: 10.11.6 - PepperFlashPlayer Version: 22.0.0.209 - problem 1. open page with flash video in webview. ex: http://www.adobe.com/jp/devnet/actionscript/samples/component_1.html 2. right click on the flash video 3. error dialog opened. > A JavaScript error occurred in the main process > > Uncaught Exception: > TypeError: Menu.buildFromTemplate is not a function > at WebContents.<anonymous> (/Users/me/.node-gyp/lib/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/electron.asar/browser/api/web-contents.js:223:23) > at emitTwo (events.js:106:13) > at WebContents.emit (events.js:191:7) - expected to open flash context menu. - Source code for reproduction. **Please put flash plugin to project root directory before.** **index.js** ``` 'use strict'; const {app, BrowserWindow} = require('electron'); let win; app.on('window-all-closed', function() { app.quit(); }); app.on('ready', function() { win = new BrowserWindow({ width: 800, height: 600 }); win.loadURL('file://' + __dirname + '/index.html'); win.on('closed', function() { win = null; }); }); // Path to flash let pluginName; switch (process.platform) { case 'win32': pluginName = 'pepflashplayer.dll'; break; case 'darwin': pluginName = 'PepperFlashPlayer.plugin'; break; case 'linux': pluginName = 'libpepflashplayer.so'; break; default: break; }; const path = require('path'); app.commandLine.appendSwitch('ppapi-flash-path', path.join(__dirname, pluginName)); ``` **index.html** ``` <!DOCTYPE html> <html> <head> <meta charset="UTF-8"> <title></title> </head> <body> <style> html{ width:100%; height:100%; } body{ margin:0;padding:0; height:100%; } </style> <script> </script> <webview id="main" src="http://www.adobe.com/jp/devnet/actionscript/samples/component_1.html" autosize="on" style="display:inline-flex; width:100%; height:100%" plugins></webview> </body> </html> ```
https://github.com/electron/electron/issues/7086
https://github.com/electron/electron/pull/7110
076d957ab9194306212f6bfaf9892b882f12329f
ade60ed482204822fa44d85a2c0aac497c88243e
2016-09-04T05:23:07Z
c++
2016-09-07T07:32:23Z
closed
electron/electron
https://github.com/electron/electron
7,081
["docs/tutorial/security.md", "lib/renderer/init.js", "spec/api-browser-window-spec.js", "spec/fixtures/module/declare-buffer.js", "spec/fixtures/module/preload-node-off.js", "spec/fixtures/module/preload.js", "spec/fixtures/module/send-later.js", "spec/modules-spec.js", "spec/webview-spec.js", "vendor/node"]
Buffer is globally available when node integration is disabled
[Archive.zip](https://github.com/electron/electron/files/453259/Archive.zip) - Electron version: 1.3.4 ( same in 0.37.8) - Operating system: OSX 10.11.6 From one day to another my Electron app cannot load and display a specific web page anymore. The page https://ctoption.com/ does load some scripts but does not contain any useful HTML. The page does load normally in Chromium so something is different from the Electron version of the browser. This is related to issue #7047. The solution there did not work. I opened a new issue instead of reopening because my question in #7047 was apparently not really the problem. I need to display the page in a _webview_ as my app has more pages, all inside a _webview_. This problem is breaking my existing Electron app so any hacks, work-arounds or other means to show this web page would be very appreciated. Added zip with a sample app. **main.js** ``` const electron = require('electron') const app = electron.app const BrowserWindow = electron.BrowserWindow let mainWindow function createWindow () { mainWindow = new BrowserWindow({width: 800, height: 600}); mainWindow.loadURL(`file://${__dirname}/index.html`) mainWindow.on('closed', function () { mainWindow = null }) } app.on('ready', createWindow) app.on('window-all-closed', function () { if (process.platform !== 'darwin') { app.quit() } }) app.on('activate', function () { if (mainWindow === null) { createWindow() } }) ``` **index.html** ``` <!DOCTYPE html> <html> <head> <meta charset="UTF-8"> <title>Hello World!</title> </head> <body> <h1>Hello World!</h1> <webview partition="CTO" preload="./somefile.js" src="https://ctoption.com/" plugins</webview> <script src="renderer.js"></script> </body> </html> ```
https://github.com/electron/electron/issues/7081
https://github.com/electron/electron/pull/8605
80dad58a59c30b4afe1d2ab8f4f441d8f38f9819
624e44dd6fb585cc9acd4a0b56c0568c789b5bd1
2016-09-03T07:17:09Z
c++
2017-02-14T17:07:24Z
closed
electron/electron
https://github.com/electron/electron
7,074
["atom/browser/window_list.cc"]
Crash in NativeWindowViews::GetAcceleratedWidget()
- Electron version: 1.3.3 - Operating system: Windows ``` Thread 0 (crashed) 0 electron.exe!aura::Window::GetHost() [window.cc : 221 + 0x0] rax = 0x0000000000000000 rdx = 0x0000000000000064 rcx = 0x0000000000000000 rbx = 0x00000094db8ec840 rsi = 0x0000000000000002 rdi = 0x00000094ded74740 rbp = 0x0000000000000001 rsp = 0x00000094d839dc40 r8 = 0x00000094d84539c0 r9 = 0x0000000000008000 r10 = 0x0000000000000000 r11 = 0x0000000000000202 r12 = 0x0000000000000000 r13 = 0x00007ff61e79d27c r14 = 0x0000000000000000 r15 = 0x00007ff61e79d27c rip = 0x00007ff61e982e54 electron.exe!atom::NativeWindowViews::GetAcceleratedWidget() [native_window_views.cc : 975 + 0x11] rsp = 0x00000094d839dc70 rip = 0x00007ff61e915549 electron.exe!atom::NativeWindowViews::IsClosable() [native_window_views.cc : 671 + 0x9] rsp = 0x00000094d839dca0 rip = 0x00007ff61e915947 electron.exe!atom::NativeWindowViews::Close() [native_window_views.cc : 339 + 0xc] rsp = 0x00000094d839dd20 rip = 0x00007ff61e915152 electron.exe!atom::WindowList::CloseAllWindows() [window_list.cc : 74 + 0x9] rsp = 0x00000094d839dd50 rip = 0x00007ff61e8d91e5 electron.exe!atom::Browser::Quit() [browser.cc : 48 + 0x5] rsp = 0x00000094d839dda0 rip = 0x00007ff61e8018b5 ```
https://github.com/electron/electron/issues/7074
https://github.com/electron/electron/pull/7432
8ae91ea2ee8eeb3f522387fa29f9e9c6acfbc91c
ec34bfde2695848eedd058db708e7018a4f64c72
2016-09-02T19:28:30Z
c++
2016-10-03T12:21:35Z
closed
electron/electron
https://github.com/electron/electron
7,035
["lib/renderer/override.js", "lib/renderer/web-view/web-view-attributes.js", "spec/chromium-spec.js", "spec/webview-spec.js"]
webview with empty src loads host url
- Electron version: 1.3.4 - Operating system: Windows 10 64-bit I have noticed a side-effect of an unhandled exception in the renderer process. To reproduce, add e.g. `throw new Error();` to the top of the source file that you load into a new `BrowserWindow` with `loadURL()`. If the `webContents` of the `BrowserWindow` contain a `<webview>`, the `<webview>` will now show the same content as the `webContents` of the `BrowserWindow`, with the `src` of the `webview` pointing to the file URL that was loaded with `BrowserWindow.loadURL()`. DevTools does not reveal if it's recursive, though.
https://github.com/electron/electron/issues/7035
https://github.com/electron/electron/pull/7146
932b6dc0cf0c077dfc84a43cac49756f183769fd
693ba1375b3c62b8831db0c8773d9db938d815f8
2016-08-30T14:19:18Z
c++
2016-09-09T10:58:41Z
closed
electron/electron
https://github.com/electron/electron
7,025
["atom/browser/browser.cc", "atom/browser/browser.h", "docs/api/app.md"]
process.exit() incompatibility - exitCode should be optional
- Electron version: v1.3.4 and HEAD. Node's [`process.exit`](https://nodejs.org/api/process.html#process_process_exit_code) takes an **optional** code argument, which defaults to `0`. Electron's [`app.exit`](http://electron.atom.io/docs/api/app/#appexitexitcode) takes a **required** code argument. So the current [`process.exit = app.exit`](https://github.com/electron/electron/blob/b5dec9990eb34a711c57a4f639b2c4c8de866d5f/lib/browser/init.js#L101) breaks electron's `process`-api compatibility with node. Which causes unhappiness. For example, when asking `argparse` to print help and exit. This `(new require('argparse').ArgumentParser()).parseArgs(['--help'])` complains `.: error: Error processing argument at index 0, conversion failure from undefined`. `process.exit = app.exit` could be changed to something like `process.exit = function AppExitWithOptionalCode (exitCode) { return app.exit(exitCode || 0); }`. In node v5.4.1 at least, `process.exit(undefined)` behaves the same as `process.exit()`. Or perhaps a more precise `app.exit.apply(app, arguments.length ? arguments : [0])`.
https://github.com/electron/electron/issues/7025
https://github.com/electron/electron/pull/7028
f30ebc68396d0251d4ef76a8aabbbe63ebb124ca
e2d70fb92b530ccd8cad550077c107110f6aa882
2016-08-29T22:12:37Z
c++
2016-08-30T10:36:03Z
closed
electron/electron
https://github.com/electron/electron
7,011
["lib/common/asar.js", "spec/asar-spec.js"]
Broken ASAR after execSync
- Electron version: 1.3.1 - Operating system: Windows 10 64-bit - Windows 7 32 bit - ArchLinux 64 bit > Using electron-packager with --asar=true If execSync throws (is called on an invalid command or a command that returns an error code), subsequent ASAR related file handling will fail. ``` js const childProcess = require("child_process"), app = require("electron").app; process.on("uncaughtException", (err)=>{ console.log(err); app.quit(); }); app.on("ready", ()=>{ console.log("Stat sync call..."); console.log(require("fs").statSync(__filename)); try { childProcess.execSync("xxxx"); } catch(e) {} console.log("Same statSync call as above..."); console.log(require("fs").statSync(__filename)); //Throws with ENOENT / ENOTDIR (win/linux) }); ``` [broken-asar.zip](https://github.com/electron/electron/files/440974/broken-asar.zip)
https://github.com/electron/electron/issues/7011
https://github.com/electron/electron/pull/7116
ade60ed482204822fa44d85a2c0aac497c88243e
e561608c0d313e99a0c34e2809442626822441f4
2016-08-28T03:53:13Z
c++
2016-09-07T07:50:26Z
closed
electron/electron
https://github.com/electron/electron
6,978
["docs/api/web-contents.md"]
webContents.fromId(id)
https://github.com/electron/electron/issues/6978
https://github.com/electron/electron/pull/7041
4833c4800ea8c880c70f0069d9cd372682cce05b
a37544cef4f4af511d5e77d5ff28e8e82f8f0823
2016-08-25T17:14:35Z
c++
2016-08-31T12:01:49Z
closed
electron/electron
https://github.com/electron/electron
6,955
["atom/browser/api/atom_api_app.cc", "atom/browser/browser.h", "atom/browser/browser_mac.mm", "atom/browser/mac/atom_application.mm", "docs/api/app.md"]
Enhance "About" menu role to support customized options
- Electron version: 1.3.3 - Operating system: Mac OS X 10.11.6 Currently the MacOS "about" role maps to the `orderFrontStandardAboutPanel` action (per the docs) which may be sufficient for most people, but we would like to have more customizable options on what is shown in the about panel. Essentially, I would prefer to have it mapped to the `orderFrontStandardAboutPanelWithOptions` action and just pass in nil for the options if no options are set, which is what `orderFrontStandardAboutPanel` does anyway. The main reason for this is that we want the version number to be displayed as the version of our web application and not the desktop application. Is this possible/considerable?
https://github.com/electron/electron/issues/6955
https://github.com/electron/electron/pull/7549
0baa60caaba9615bf8937c9751c2a72440b57cfa
4ae190dab930975bd0d686b86c43d0547515c61c
2016-08-24T14:38:02Z
c++
2016-10-11T11:18:23Z
closed
electron/electron
https://github.com/electron/electron
6,954
["atom/browser/native_window_views.cc"]
The win.setFullScreen(false) makes the window full screen on Linux (Ubuntu)
While the [`win.setFullScreen(false)`](https://github.com/electron/electron/blob/master/docs/api/browser-window.md#winsetfullscreenflag) works as expected on macOS and Windows, it seems that on Ubuntu it goes to full screen regardless of the argument. - Electron version: 1.2.8 - Operating system: Ubuntu 64bit 16.04
https://github.com/electron/electron/issues/6954
https://github.com/electron/electron/pull/6961
a97b40eff576aa75db2bcf403ab69b79d53dd019
6e75e8e2bf52ba3809197900a29fef455582fe02
2016-08-24T06:57:31Z
c++
2016-08-25T00:23:02Z
closed
electron/electron
https://github.com/electron/electron
6,949
["atom/browser/atom_browser_client.cc", "atom/browser/atom_browser_client.h", "docs/api/protocol.md", "spec/api-protocol-spec.js", "spec/fixtures/pages/filesystem.html"]
webkitRequestFileSystem fails with SecurityError in custom protocols
- Electron version: 1.3.3 - Operating system: OSX El Capitan ``` javascript function cbError(e) { console.error('failure', e); } navigator.webkitPersistentStorage.requestQuota( 10 * 1024* 1024, function(granted) { webkitRequestFileSystem(PERSISTENT, granted, cb, cbError); }, cbError) ``` webkitRequestFileSystem is failing with: ``` FileError {code: 2, name: "SecurityError", message: "It was determined that certain files are unsafe fo… too many calls are being made on file resources."}code: 2message: "It was determined that certain files are unsafe for access within a Web application, or that too many calls are being made on file resources."name: "SecurityError"__proto__: FileError ``` This page is being served from a custom:// scheme if that matters.
https://github.com/electron/electron/issues/6949
https://github.com/electron/electron/pull/6952
6e75e8e2bf52ba3809197900a29fef455582fe02
764c84f569a769b5b27b442beb3f1a8f1825181b
2016-08-23T22:43:10Z
c++
2016-08-25T00:28:34Z
closed
electron/electron
https://github.com/electron/electron
6,942
["lib/browser/rpc-server.js", "lib/renderer/api/remote.js", "spec/api-ipc-spec.js"]
Do not convert ArrayBuffer to Array in remote module
- Electron version: 1.3.3 - Operating system: OSX El Capitan https://github.com/electron/electron/blob/master/lib/renderer/api/remote.js#L33 remote.js converts the ArrayBuffer or Buffer into an array. Not familiar with the IPC wire protocol, is it binary or JSON under the hood?
https://github.com/electron/electron/issues/6942
https://github.com/electron/electron/pull/6963
764c84f569a769b5b27b442beb3f1a8f1825181b
97a004a357a8aeede751851379d8403e91fff962
2016-08-23T09:23:54Z
c++
2016-08-25T08:29:12Z
closed
electron/electron
https://github.com/electron/electron
6,940
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_web_contents_mac.mm", "spec/api-web-contents-spec.js"]
Calling webContents.openDevTools followed by BrowserWindow.inspectElement crash
- Electron version: 1.3.3 - Operating system: OSX El Capitan 10.11.6 The following code crashes Electron. The dev tools don't open, but the HTML element highlights like it is open. ``` javascript selfBrowserWindow.webContents.openDevTools({mode: 'detach'}) selfBrowserWindow.inspectElement(rightClickPosition.x, rightClickPosition.y) ``` The reason I'm doing this is because I want to open the dev tools detached, then inspect. Calling inspectElement first will open the dev tools docked by default.
https://github.com/electron/electron/issues/6940
https://github.com/electron/electron/pull/6944
dc73a5afea7b6d9772b61cd8554d5b70dce08f83
7bdce522905dee8cea880d29593559cf2885165d
2016-08-23T03:59:14Z
c++
2016-08-24T07:25:27Z
closed
electron/electron
https://github.com/electron/electron
6,939
["docs/api/webview-tag.md"]
Ambiguous default value for nodeintegration in <webview>
- Electron version: 1.3.3 - Operating system: all In `docs/api/web-view-tag.md` it reads: > `<webview src="http://www.google.com/" nodeintegration></webview>` > If "on", the guest page in webview will have node integration and can use node APIs like require and process to access low level system resources. The phrasing in the description implies that if the `nodeintegration` attribute is not explicitly set on the tag, then the `<webview>` won't have node integration. However, in `docs/tutorial/security.md` it reads: > WebViews: Set nodeintegration to false This should be clarified in the documentation. Also, valid attribute values should either be `[true, false]` or `[on, off]`, not a mix as stated above. More generally, there should be exactly one way to set security properties, and all others should throw an error. As of 1.3.3, I can write `<webview nodeintegration="nada">`, this won't throw an error or warning, and it's not immediately clear if the value evaluates to truthy or not.
https://github.com/electron/electron/issues/6939
https://github.com/electron/electron/pull/8569
4abbd65628982053a3cfefb49795e787168878fd
555347e726d5f35557e0f703b54370a3e7dabfa7
2016-08-23T00:10:50Z
c++
2017-02-03T17:39:22Z
closed
electron/electron
https://github.com/electron/electron
6,928
["atom/browser/api/atom_api_session.cc", "docs/api/session.md"]
Passing undefined for expected keys in enableNetworkEmulation breaks silently
- Electron version: 1.2.5 - Operating system: Mac OS X 10.11.6 I am using `session.enableNetworkEmulation` to rate limit upload speed for an uploader app, and noticed that if I only pass the `uploadThroughput` key in the options object, network IO hangs (not sure if it's just down or both ways). I checked out the [code](https://github.com/electron/electron/blob/master/atom/browser/api/atom_api_session.cc#L416-L437) and it looks like it is just expecting all three keys to have defined values. That's fine, but it seems like there could be default values, or at least it should error harder? Anyone running into this can just make sure to set whatever settings they want unchanged to `0` to get the desired behavior, but this seems like something we can easily guard against, no?
https://github.com/electron/electron/issues/6928
https://github.com/electron/electron/pull/6935
0955c2fd4d058adf9e681ab075df0170831e690c
4ca6587660f1436ac14361fb7d270ee22a7f9aaf
2016-08-22T13:06:32Z
c++
2016-08-23T07:40:36Z
closed
electron/electron
https://github.com/electron/electron
6,901
["atom/browser/api/atom_api_app.cc", "atom/browser/api/atom_api_app.h", "atom/browser/browser.h", "atom/browser/browser_linux.cc", "atom/browser/browser_mac.mm", "atom/browser/browser_win.cc", "docs/api/app.md", "spec/api-app-spec.js"]
Allow settings of custom exe and arguments when using the setLoginItem API
Hi there, Windows does not supply an application with information on whether or not it was launched on system start. This is why on Windows, you would typically set up the automatic launch of an application in such a way that a parameter is passed to the application that notifies it of being launched in this specific way (e. g. instead of storing "/path/to/app.exe" in the registry, you’d store "/path/to/app.exe --onlogin"). Do you think Electron should support automatically appending such a parameter in order to determine `wasOpenedAtLogin` on Windows (and potentially other systems) or would this be infringing with developers’ ability to determine their own parameter structure too much? Maybe a better way would be to allow passing custom arguments to app.setLoginItemSettings (like `app.setLoginItemSettings({loginArguments: '--onlogin'})`) so that developers can set up their own fallback solutions for systems that do not support `wasOpenedAtLogin` natively. What’s your take on this?
https://github.com/electron/electron/issues/6901
https://github.com/electron/electron/pull/8515
093b84485992dc033f51b4283d0a242a895bd0bf
18357512f344a6b36a58a2b64836cbd229cee410
2016-08-19T09:07:47Z
c++
2017-02-06T16:55:32Z
closed
electron/electron
https://github.com/electron/electron
6,873
["atom/browser/api/atom_api_window.cc", "atom/browser/api/atom_api_window.h", "atom/browser/native_window.cc", "atom/browser/native_window.h", "atom/browser/native_window_mac.h", "atom/browser/native_window_mac.mm", "atom/browser/native_window_observer.h", "docs/api/browser-window.md"]
`scroll-touch-begin` and `scroll-touch-end` events don't work as expected in v1.3.3
- Electron version: v1.3.3 - Operating system: OS X 10.11.6 v1.3.3 broke the detection of the `scroll-touch-begin` and `scroll-touch-end` events for me within a `webview`. It looks like the pull request #6754 caused this issue. v1.3.2 works as expected. Behavior that I'm observing on v1.3.3: - Most of the time, the `scroll-touch-*` events are not emitted when the cursor is on top of a `webview`. - The `scroll-touch-*` events seem to be emitted _only once_ when the cursor is on a `webview` and on a scrollable element. The scrollable elements in my app have no native scrollbar set (they have the style `overflow: hidden;` set instead of `overflow: scroll;`). This is the case in which I need to receive the `scroll-touch-*` events. - The `scroll-touch-*` events seem to work fine when the cursor is outside of the `webview` tag.
https://github.com/electron/electron/issues/6873
https://github.com/electron/electron/pull/7239
143d7ab98fc8a27dcaf270acaf4d2b9706b6da6e
30a6b597a56ef0326dbc5c877fb06e4ae4c9daae
2016-08-16T23:15:45Z
c++
2016-09-20T05:51:10Z
closed
electron/electron
https://github.com/electron/electron
6,866
["atom/browser/ui/file_dialog_mac.mm"]
dialog.showOpenDialog with 'createDirectory', 'openDirectory' puts buttons on top of each other
- Electron version: 1.3.3 - Operating system: OS X 10.11.6 ``` js dialog.showOpenDialog({ properties: [ 'createDirectory', 'openDirectory' ] }) ``` With `createDirectory`, the `New Folder` button looks funny because it gets overlaid on top of something: <img width="147" alt="screen shot 2016-08-16 at 1 14 46 pm" src="https://cloud.githubusercontent.com/assets/13760/17708762/6b5debdc-63b4-11e6-82cd-109463f05809.png"> Without `createDirectory`, we can see what it is: <img width="139" alt="screen shot 2016-08-16 at 1 20 57 pm" src="https://cloud.githubusercontent.com/assets/13760/17708745/531a2b26-63b4-11e6-911d-0ba75794c4d6.png"> In the context of an Open dialog, the `Hide extension` checkbox doesn't make sense so it shouldn't be shown at all.
https://github.com/electron/electron/issues/6866
https://github.com/electron/electron/pull/6872
faebe5259d6a298ed6039435238c5f4afe81809d
0b7b6b38c0d272e424dc0cd85487a5c06b5989f2
2016-08-16T17:28:06Z
c++
2016-08-17T13:35:15Z
closed
electron/electron
https://github.com/electron/electron
6,863
["lib/renderer/api/remote.js", "spec/api-ipc-spec.js", "spec/fixtures/module/export-function-with-properties.js", "spec/fixtures/module/function-with-properties.js", "spec/fixtures/module/property.js", "spec/fixtures/module/remote-static.js"]
Cannot access properties of functions which are members of objects through remote IPC
- Electron version: master as of now (420f756) - Operating system: OS X 10.11 It seems that properties of functions which are members of objects (methods) are cannot accessible through `remote` IPC. (you can still access properties of functions which are not object members) This is also reported in #4957. ``` js // remote1.js (access function directly) function func() {} func.prop = 'test' module.exports = func // remote2.js (access function as property) function func() {} func.prop = 'test' module.exports = { func: func } // remote3.js (access function as array item) function func() {} func.prop = 'test' module.exports = { func: [func] } // renderer const {remote} = require("electron") console.log(remote.require("./remote1").prop) // 'test' console.log(remote.require("./remote2").func.prop) // undefined, cannot access to property console.log(remote.require("./remote3").func[0].prop) // 'test' ``` This is especially problematic when you are using named exported classes with static members: ``` js // foo.js class Foo { static bar() { ... } } exports.Foo = Foo ``` ``` js let {Foo} = remote.require("./foo") Foo.bar() // error, cannot call static method 😞 ```
https://github.com/electron/electron/issues/6863
https://github.com/electron/electron/pull/6867
e2d70fb92b530ccd8cad550077c107110f6aa882
f854b27bfbdc3c868e7a0d8b1e252ce89fcdcb29
2016-08-16T15:32:02Z
c++
2016-08-31T08:28:09Z
closed
electron/electron
https://github.com/electron/electron
6,855
["atom/browser/net/atom_network_delegate.cc"]
webRequest.onBeforeSendHeaders drops headers with "." in the name
- Electron version: 1.3.3 - Operating system: All wsj.com uses a header called `Dylan2010.EntitlementToken` which is lost if you register an `onBeforeSenderHeaders` callback. This happens because `DictionaryValue::SetString` does automatic path expansion unless you explicitly call `DictionaryValue::SetStringWithoutPathExpansion'. Pr to follow
https://github.com/electron/electron/issues/6855
https://github.com/electron/electron/pull/6856
420f756c470f21f58d0095f2095602d4d8f6c0b4
c93a8fb4eafbc5ce80bbf5d2b21b49c2d8771c7c
2016-08-16T00:19:14Z
c++
2016-08-16T15:54:26Z
closed
electron/electron
https://github.com/electron/electron
6,845
["atom/browser/native_window_mac.mm", "spec/api-browser-window-spec.js"]
BrowserWindow resizing alone on OSX
- Electron version: > 1.1.0 - Operating system: OS X El Capitan 10.11.3 ## Behavior When I use the methods of `BrowserWindow` as `setClosable`, `setMaximizable` and `setMinimizable`, the window height is automatically increased every call of the methods cited of `BrowserWindow`. This behavior only occurs when using the Electron in OSX and when you create a `BrowserWindow` with the following options : - frame : false, or - titleBarStyle 'hidden' || 'hidden-inset' With `titleStyleBar` equal `hidden` or `frame` equal `false` the increment is `22px` and `titleStyleBar` equal `hidden-inset` the increment is `37px`. ## Error reproduction Using the Quick Start project (https://github.com/electron/electron-quick-start) and set options of `BrowserWindow` to, for example, `titleBarStyle 'hidden'` and insert the code below after line 27, in **mais.js** ``` javascript setTimeout(function(){ mainWindow.setMinimizable(false); }, 3000); setTimeout(function(){ mainWindow.setMinimizable(true); }, 6000); setTimeout(function(){ mainWindow.setMinimizable(false); }, 9000); setTimeout(function(){ mainWindow.setMinimizable(true); }, 12000); ``` \* Electron version > 1.1.0 and only OSX ## Other information - The behavior began to appear in versions greater than 1.1.0 Electron - I tested using `frame : false` in **Windows** and the problem does not appear.
https://github.com/electron/electron/issues/6845
https://github.com/electron/electron/pull/6850
2e8d7cd6db9262bf5cf1cb19e87583d531045a74
79f35fa475ebf4631c2eebe9272f1588d28775c0
2016-08-15T17:07:50Z
c++
2016-08-17T12:19:35Z
closed
electron/electron
https://github.com/electron/electron
6,844
["docs/api/native-image.md", "spec/api-native-image-spec.js"]
nativeImage.createFromPath(path) fails silently for bad paths
- Electron version: 1.3.3 - Operating system: all (Ubuntu in that case) Just reporting something I've just faced. I did a release of a software based on Electron, but in the build process, the `images` folders were deleted, with the app icon inside. Then, when running Electron, no error were thrown, and the app had no icon (ofc). Shouldn't a warning or an error be thrown in that case ?
https://github.com/electron/electron/issues/6844
https://github.com/electron/electron/pull/7295
3b4a071723a815cd126bec9be8329d8dd8488db9
c9a3ab3a81bb560015e5cd523e839fdf07d9d1d1
2016-08-15T13:59:14Z
c++
2016-09-22T05:14:15Z
closed
electron/electron
https://github.com/electron/electron
6,830
["atom/common/node_bindings.cc", "spec/chromium-spec.js"]
WebView crashing with fetch api
- Electron version: 1.3.3 - Operating system: Windows 10.0.10586 The issue is one of my webviews is crashing when using the _**fetch**_ api. I use it to handle a chunked http response. When calling **_stream.read()_** for a second time it returns Promise.reject(NETWORK ERROR) and the webview crashes. The issue does not occur on mac os. I'm attaching some dump information. I failed to add the symbols but I'll try again and come back with an updated version. Any help would be greatly appreciated. Thanks Juan [electron.txt](https://github.com/electron/electron/files/415696/electron.txt)
https://github.com/electron/electron/issues/6830
https://github.com/electron/electron/pull/6926
374e23fc375ce58c87c5d2aeb8f56f7907984ec5
d6a63855c41552e34fed963c4ca70ec91e7864f4
2016-08-12T16:02:24Z
c++
2016-08-22T11:08:08Z
closed
electron/electron
https://github.com/electron/electron
6,813
["atom/common/api/remote_object_freer.cc", "atom/common/api/remote_object_freer.h"]
renderer crash during GC
- Electron version: 1.3.3 - Operating system: Windows 10.0.10586 - Architecture: ia32 We recently upgraded from 0.37.6 => 1.3.0 (1.3.1, 1.3.2, 1.3.3 exhibit the same behavior) and since it's gone live we've been seeing ~1000 crashes/day in renderer processes. Electron recovers gracefully but our users do notice the hiccup and report the issue. Unfortunately we're not having very much luck reproducing the issue so I figured I would drop a sample dump here on off chance someone else can point out something obvious: ``` Operating system: Windows NT 10.0.10586 CPU: x86 GenuineIntel family 6 model 23 stepping 6 8 CPUs Crash reason: EXCEPTION_ACCESS_VIOLATION_READ Crash address: 0x27 Process uptime: not available Thread 0 (crashed) 0 node.dll!v8::Isolate::GetCurrentContext() [api.cc : 7083 + 0x0] eip = 0x6cf38ffc esp = 0x00dfed44 ebp = 0x00dfed48 ebx = 0x0b2428a0 esi = 0x0b2428a0 edi = 0x00000014 eax = 0x04efa918 ecx = 0x04efa918 edx = 0x0b485950 efl = 0x00010206 Found by: given as instruction pointer in context 1 MainExecutable.exe!blink::WebLocalFrame::frameForCurrentContext() [weblocalframeimpl.cpp : 530 + 0x10] eip = 0x015569b4 esp = 0x00dfed50 ebp = 0x00dfed58 Found by: call frame info 2 MainExecutable.exe!atom::RemoteObjectFreer::RunDestructor() [remote_object_freer.cc : 51 + 0x5] eip = 0x01401662 esp = 0x00dfed60 ebp = 0x00dfedc8 Found by: call frame info 3 MainExecutable.exe!atom::ObjectLifeMonitor::OnObjectGC(v8::WeakCallbackInfo<atom::ObjectLifeMonitor> const &) [object_life_monitor.cc : 34 + 0x7] eip = 0x01416093 esp = 0x00dfedd0 ebp = 0x00dfedd8 Found by: call frame info 4 node.dll!v8::internal::GlobalHandles::DispatchPendingPhantomCallbacks(bool) [global-handles.cc : 1061 + 0x24] eip = 0x6cf741ce esp = 0x00dfede0 ebp = 0x00dfee14 Found by: call frame info 5 node.dll!v8::internal::GlobalHandles::PostGarbageCollectionProcessing(v8::internal::GarbageCollector,v8::GCCallbackFlags) [global-handles.cc : 1117 + 0x9] eip = 0x6cf74fde esp = 0x00dfee1c ebp = 0x00dfee2c Found by: call frame info 6 node.dll!v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector,v8::GCCallbackFlags) [heap.cc : 1326 + 0x14] eip = 0x6cd1246d esp = 0x00dfee34 ebp = 0x00dfef18 Found by: call frame info 7 node.dll!v8::internal::Heap::CollectGarbage(v8::internal::GarbageCollector,char const *,char const *,v8::GCCallbackFlags) [heap.cc : 1009 + 0xb] eip = 0x6cd07c7e esp = 0x00dfef20 ebp = 0x00dfef88 Found by: call frame info 8 node.dll!v8::internal::Factory::NewHeapNumber(double,v8::internal::MutableMode,v8::internal::PretenureFlag) [factory.cc : 1109 + 0x2c] eip = 0x6cf62f99 esp = 0x00dfef90 ebp = 0x00dfefb8 Found by: call frame info 9 node.dll!v8::internal::Runtime_AllocateHeapNumber(int,v8::internal::Object * *,v8::internal::Isolate *) [runtime-object.cc : 630 + 0x56] eip = 0x6cec8926 esp = 0x00dfefc0 ebp = 0x00dfefe8 Found by: call frame info 10 0x3cf0ab26 eip = 0x3cf0ab26 esp = 0x00dfeff0 ebp = 0x00dff04c Found by: call frame info 11 0x3cf10d2c eip = 0x3cf10d2c esp = 0x00dff054 ebp = 0x00dff078 Found by: previous frame's frame pointer 12 0x376b59b8 eip = 0x376b59b8 esp = 0x00dff080 ebp = 0x00dff0e4 Found by: previous frame's frame pointer 13 0x3cf0c816 eip = 0x3cf0c816 esp = 0x00dff0ec ebp = 0x00dff0fc Found by: previous frame's frame pointer 14 0x14b937ca eip = 0x14b937ca esp = 0x00dff104 ebp = 0x00dff120 Found by: previous frame's frame pointer 15 0x3cf3b09e eip = 0x3cf3b09e esp = 0x00dff128 ebp = 0x00dff13c Found by: previous frame's frame pointer 16 0x3cf257c3 eip = 0x3cf257c3 esp = 0x00dff144 ebp = 0x00dff168 Found by: previous frame's frame pointer 17 node.dll!v8::internal::`anonymous namespace'::Invoke [execution.cc : 98 + 0x10] eip = 0x6cf5ab33 esp = 0x00dff170 ebp = 0x00dff1c8 Found by: previous frame's frame pointer 18 node.dll!v8::internal::Execution::Call(v8::internal::Isolate *,v8::internal::Handle<v8::internal::Object>,v8::internal::Handle<v8::internal::Object>,int,v8::internal::Handle<v8::internal::Object> * const) [execution.cc : 154 + 0x20] eip = 0x6cf5a380 esp = 0x00dff1d0 ebp = 0x00dff20c Found by: call frame info 19 node.dll!v8::Function::Call(v8::Local<v8::Context>,v8::Local<v8::Value>,int,v8::Local<v8::Value> * const) [api.cc : 4476 + 0x1b] eip = 0x6cf31734 esp = 0x00dff214 ebp = 0x00dff294 Found by: call frame info 20 MainExecutable.exe!blink::V8ScriptRunner::callFunction(v8::Local<v8::Function>,blink::ExecutionContext *,v8::Local<v8::Value>,int,v8::Local<v8::Value> * const,v8::Isolate *) [v8scriptrunner.cpp : 467 + 0x27] eip = 0x030da7f0 esp = 0x00dff29c ebp = 0x00dff310 Found by: call frame info 21 MainExecutable.exe!blink::ScriptController::callFunction(blink::ExecutionContext *,v8::Local<v8::Function>,v8::Local<v8::Value>,int,v8::Local<v8::Value> * const,v8::Isolate *) [scriptcontroller.cpp : 122 + 0x1a] eip = 0x02fefa8d esp = 0x00dff318 ebp = 0x00dff334 Found by: call frame info 22 MainExecutable.exe!blink::V8FrameRequestCallback::handleEvent(double) [v8framerequestcallback.cpp : 52 + 0x3e] eip = 0x03094a48 esp = 0x00dff33c ebp = 0x00dff37c Found by: call frame info 23 MainExecutable.exe!blink::FrameRequestCallbackCollection::executeCallbacks(double,double) [framerequestcallbackcollection.cpp : 70 + 0xd] eip = 0x02f4b6cf esp = 0x00dff384 ebp = 0x00dff3fc Found by: call frame info 24 MainExecutable.exe!blink::ScriptedAnimationController::executeCallbacks(double) [scriptedanimationcontroller.cpp : 135 + 0x23] eip = 0x02f771ad esp = 0x00dff404 ebp = 0x00dff420 Found by: call frame info 25 MainExecutable.exe!blink::ScriptedAnimationController::serviceScriptedAnimations(double) [scriptedanimationcontroller.cpp : 163 + 0x14] eip = 0x02f77aa8 esp = 0x00dff428 ebp = 0x00dff438 Found by: call frame info 26 MainExecutable.exe!blink::Document::serviceScriptedAnimations(double) [document.cpp : 5412 + 0x12] eip = 0x02effeaf esp = 0x00dff440 ebp = 0x00dff448 Found by: call frame info 27 MainExecutable.exe!blink::PageAnimator::serviceScriptedAnimations(double) [pageanimator.cpp : 67 + 0x14] eip = 0x0332ef9a esp = 0x00dff450 ebp = 0x00dff498 Found by: call frame info 28 MainExecutable.exe!blink::PageWidgetDelegate::animate(blink::Page &,double) [pagewidgetdelegate.cpp : 57 + 0x15] eip = 0x0156a571 esp = 0x00dff4a0 ebp = 0x00dff4ac Found by: call frame info 29 MainExecutable.exe!blink::WebViewImpl::beginFrame(double) [webviewimpl.cpp : 1984 + 0x15] eip = 0x015436e2 esp = 0x00dff4b4 ebp = 0x00dff558 Found by: call frame info 30 MainExecutable.exe!content::RenderWidget::BeginMainFrame(double) [render_widget.cc : 698 + 0x15] eip = 0x01b8d6b8 esp = 0x00dff560 ebp = 0x00dff568 Found by: call frame info 31 MainExecutable.exe!content::RenderWidgetCompositor::BeginMainFrame(cc::BeginFrameArgs const &) [render_widget_compositor.cc : 905 + 0x18] eip = 0x01b96068 esp = 0x00dff570 ebp = 0x00dff588 Found by: call frame info 32 MainExecutable.exe!cc::ProxyMain::BeginMainFrame(std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> >) [proxy_main.cc : 193 + 0xf] eip = 0x03b16402 esp = 0x00dff590 ebp = 0x00dff610 Found by: call frame info 33 MainExecutable.exe!base::internal::Invoker<base::IndexSequence<0,1>,base::internal::BindState<base::internal::RunnableAdapter<void ( cc::ProxyMain::*)(std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> >)>,void ,base::WeakPtr<cc::ProxyMain> &,base::internal::PassedWrapper<std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> > > >,base::internal::InvokeHelper<1,void,base::internal::RunnableAdapter<void ( cc::ProxyMain::*)(std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> >)> >,void >::Run(base::internal::BindStateBase *) [bind_internal.h : 362 + 0x83] eip = 0x03b720f7 esp = 0x00dff618 ebp = 0x00dff6e0 Found by: call frame info 34 MainExecutable.exe!base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask const &) [task_annotator.cc : 51 + 0x8] eip = 0x014c40e7 esp = 0x00dff6e8 ebp = 0x00dff73c Found by: call frame info 35 MainExecutable.exe!scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(scheduler::internal::WorkQueue *,scheduler::internal::TaskQueueImpl::Task *) [task_queue_manager.cc : 289 + 0x1d] eip = 0x02a86977 esp = 0x00dff744 ebp = 0x00dff818 Found by: call frame info 36 MainExecutable.exe!scheduler::TaskQueueManager::DoWork(base::TimeTicks,bool) [task_queue_manager.cc : 201 + 0xc] eip = 0x02a86193 esp = 0x00dff820 ebp = 0x00dff960 Found by: call frame info 37 MainExecutable.exe!base::internal::Invoker<base::IndexSequence<0,1,2>,base::internal::BindState<base::internal::RunnableAdapter<void ( scheduler::TaskQueueManager::*)(base::TimeTicks,bool)>,void ,base::WeakPtr<scheduler::TaskQueueManager>,base::TimeTicks,bool>,base::internal::InvokeHelper<1,void,base::internal::RunnableAdapter<void ( scheduler::TaskQueueManager::*)(base::TimeTicks,bool)> >,void >::Run(base::internal::BindStateBase *) [bind_internal.h : 362 + 0x47] eip = 0x02a86d0f esp = 0x00dff968 ebp = 0x00dff984 Found by: call frame info 38 MainExecutable.exe!base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask const &) [task_annotator.cc : 51 + 0x8] eip = 0x014c40e7 esp = 0x00dff98c ebp = 0x00dff9e0 Found by: call frame info 39 MainExecutable.exe!base::MessageLoop::RunTask(base::PendingTask const &) [message_loop.cc : 478 + 0x11] eip = 0x0147ca1b esp = 0x00dff9e8 ebp = 0x00dffb28 Found by: call frame info 40 MainExecutable.exe!base::MessageLoop::DoWork() [message_loop.cc : 604 + 0xb] eip = 0x0147be65 esp = 0x00dffb30 ebp = 0x00dffbac Found by: call frame info 41 MainExecutable.exe!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc : 33 + 0x9] eip = 0x014c5a87 esp = 0x00dffbb4 ebp = 0x00dffbd0 Found by: call frame info 42 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x00dffbd8 ebp = 0x00dffc00 Found by: call frame info 43 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x00dffbe4 ebp = 0x00dffc00 Found by: call frame info 44 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x00dffc08 ebp = 0x00dffc24 Found by: call frame info 45 MainExecutable.exe!content::RendererMain(content::MainFunctionParams const &) [renderer_main.cc : 199 + 0xc] eip = 0x01b89bee esp = 0x00dffc2c ebp = 0x00dffd18 Found by: call frame info 46 MainExecutable.exe!content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *) [content_main_runner.cc : 420 + 0xd] eip = 0x015dcf50 esp = 0x00dffd20 ebp = 0x00dffd38 Found by: call frame info 47 MainExecutable.exe!content::ContentMainRunnerImpl::Run() [content_main_runner.cc : 787 + 0x6] eip = 0x015dcdf5 esp = 0x00dffd40 ebp = 0x00dffd8c Found by: call frame info 48 MainExecutable.exe!content::ContentMain(content::ContentMainParams const &) [content_main.cc : 20 + 0x7] eip = 0x015d9f33 esp = 0x00dffd94 ebp = 0x00dffd9c Found by: call frame info 49 MainExecutable.exe!wWinMain [atom_main.cc : 114 + 0x9] eip = 0x012d0df2 esp = 0x00dffda4 ebp = 0x00dffe3c Found by: call frame info 50 MainExecutable.exe!__scrt_common_main_seh [exe_common.inl : 253 + 0x1a] eip = 0x037fb8eb esp = 0x00dffe44 ebp = 0x00dffe88 Found by: call frame info 51 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x00dffe90 ebp = 0x00dffe9c Found by: call frame info 52 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x00dffea4 ebp = 0x00dffee4 Found by: previous frame's frame pointer 53 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x00dffeec ebp = 0x00dffef4 Found by: previous frame's frame pointer Thread 1 0 ntdll.dll + 0x76c4c eip = 0x77936c4c esp = 0x0825f698 ebp = 0x0825f6cc ebx = 0x00000000 esi = 0x00000000 edi = 0x00000000 eax = 0x041e9200 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000202 Found by: given as instruction pointer in context 1 MainExecutable.exe!sandbox::BrokerServicesBase::TargetEventsThread(void *) [broker_services.cc : 178 + 0x20] eip = 0x041e92af esp = 0x0825f6d4 ebp = 0x0825f7f0 Found by: previous frame's frame pointer 2 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0825f7f8 ebp = 0x0825f804 Found by: call frame info 3 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0825f80c ebp = 0x0825f84c Found by: previous frame's frame pointer 4 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0825f854 ebp = 0x0825f85c Found by: previous frame's frame pointer Thread 2 0 ntdll.dll + 0x76c4c eip = 0x77936c4c esp = 0x0839fb74 ebp = 0x0839fba8 ebx = 0x00000000 esi = 0x00000000 edi = 0x0839fbf0 eax = 0x00000001 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 MainExecutable.exe!base::MessagePumpForIO::GetIOItem(unsigned long,base::MessagePumpForIO::IOItem *) [message_pump_win.cc : 568 + 0x2d] eip = 0x014c4fe5 esp = 0x0839fbb0 ebp = 0x0839fbd0 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::MessagePumpForIO::WaitForWork() [message_pump_win.cc : 539 + 0xc] eip = 0x014c578b esp = 0x0839fbd8 ebp = 0x0839fbfc Found by: call frame info 3 MainExecutable.exe!base::MessagePumpForIO::DoRunLoop() [message_pump_win.cc : 524 + 0x7] eip = 0x014c4dae esp = 0x0839fc04 ebp = 0x0839fce0 Found by: call frame info 4 MainExecutable.exe!base::MessagePumpWin::Run(base::MessagePump::Delegate *) [message_pump_win.cc : 54 + 0xa] eip = 0x014c553a esp = 0x0839fce8 ebp = 0x0839fd08 Found by: call frame info 5 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x0839fd10 ebp = 0x0839fd38 Found by: call frame info 6 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x0839fd1c ebp = 0x0839fd38 Found by: call frame info 7 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x0839fd40 ebp = 0x0839fd5c Found by: call frame info 8 MainExecutable.exe!base::Thread::Run(base::MessageLoop *) [thread.cc : 202 + 0x8] eip = 0x0147defb esp = 0x0839fd64 ebp = 0x0839fd64 Found by: call frame info 9 MainExecutable.exe!base::Thread::ThreadMain() [thread.cc : 254 + 0xa] eip = 0x0147e3bd esp = 0x0839fd6c ebp = 0x0839fd9c Found by: call frame info 10 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0839fda4 ebp = 0x0839fdb8 Found by: call frame info 11 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0839fdc0 ebp = 0x0839fdcc Found by: call frame info 12 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0839fdd4 ebp = 0x0839fe14 Found by: previous frame's frame pointer 13 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0839fe1c ebp = 0x0839fe24 Found by: previous frame's frame pointer Thread 3 0 ntdll.dll + 0x7876c eip = 0x7793876c esp = 0x084df928 ebp = 0x084dfae0 ebx = 0x00000000 esi = 0x04eeb5a8 edi = 0x04ee49b0 eax = 0x778ec6d0 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x084dfae8 ebp = 0x084dfaf4 Found by: previous frame's frame pointer 2 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x084dfafc ebp = 0x084dfb3c Found by: previous frame's frame pointer 3 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x084dfb44 ebp = 0x084dfb4c Found by: previous frame's frame pointer Thread 4 0 ntdll.dll + 0x76bfc eip = 0x77936bfc esp = 0x0861fb6c ebp = 0x0861fbdc ebx = 0x04f20640 esi = 0x00000000 edi = 0x00000314 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0xae162 eip = 0x7487e162 esp = 0x0861fbe4 ebp = 0x0861fbf0 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::WaitableEvent::TimedWait(base::TimeDelta const &) [waitable_event_win.cc : 62 + 0x9] eip = 0x014ca979 esp = 0x0861fbf8 ebp = 0x0861fc08 Found by: previous frame's frame pointer 3 MainExecutable.exe!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc : 57 + 0xc] eip = 0x014c5a6f esp = 0x0861fc10 ebp = 0x0861fc30 Found by: call frame info 4 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x0861fc38 ebp = 0x0861fc60 Found by: call frame info 5 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x0861fc44 ebp = 0x0861fc60 Found by: call frame info 6 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x0861fc68 ebp = 0x0861fc84 Found by: call frame info 7 MainExecutable.exe!base::Thread::Run(base::MessageLoop *) [thread.cc : 202 + 0x8] eip = 0x0147defb esp = 0x0861fc8c ebp = 0x0861fc8c Found by: call frame info 8 MainExecutable.exe!base::Thread::ThreadMain() [thread.cc : 254 + 0xa] eip = 0x0147e3bd esp = 0x0861fc94 ebp = 0x0861fcc4 Found by: call frame info 9 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0861fccc ebp = 0x0861fce0 Found by: call frame info 10 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0861fce8 ebp = 0x0861fcf4 Found by: call frame info 11 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0861fcfc ebp = 0x0861fd3c Found by: previous frame's frame pointer 12 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0861fd44 ebp = 0x0861fd4c Found by: previous frame's frame pointer Thread 5 0 ntdll.dll + 0x7873c eip = 0x7793873c esp = 0x0875f8d4 ebp = 0x0875f914 ebx = 0x04ef3d18 esi = 0x00000000 edi = 0x04ef3d30 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0x137fa3 eip = 0x74907fa3 esp = 0x0875f91c ebp = 0x0875f938 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::ConditionVariable::Wait() [condition_variable_win.cc : 26 + 0x1d] eip = 0x014ced2c esp = 0x0875f940 ebp = 0x0875f95c Found by: previous frame's frame pointer 3 MainExecutable.exe!content::RasterWorkerPool::Run(std::vector<cc::TaskCategory,std::allocator<cc::TaskCategory> > const &,base::ConditionVariable *) [raster_worker_pool.cc : 240 + 0x8] eip = 0x01c564fb esp = 0x0875f964 ebp = 0x0875f978 Found by: call frame info 4 MainExecutable.exe!content::`anonymous namespace'::RasterWorkerPoolThread::Run [raster_worker_pool.cc : 34 + 0xf] eip = 0x01c5653f esp = 0x0875f980 ebp = 0x0875f9b0 Found by: call frame info 5 MainExecutable.exe!base::SimpleThread::ThreadMain() [simple_thread.cc : 66 + 0x7] eip = 0x014cf4f2 esp = 0x0875f98c ebp = 0x0875f9b0 Found by: call frame info 6 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0875f9b8 ebp = 0x0875f9cc Found by: call frame info 7 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0875f9d4 ebp = 0x0875f9e0 Found by: call frame info 8 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0875f9e8 ebp = 0x0875fa28 Found by: previous frame's frame pointer 9 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0875fa30 ebp = 0x0875fa38 Found by: previous frame's frame pointer Thread 6 0 ntdll.dll + 0x7873c eip = 0x7793873c esp = 0x0889fd14 ebp = 0x0889fd5c ebx = 0x04ef3d18 esi = 0x00000000 edi = 0x04ef3d30 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00200206 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0x137fa3 eip = 0x74907fa3 esp = 0x0889fd64 ebp = 0x0889fd80 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::ConditionVariable::Wait() [condition_variable_win.cc : 26 + 0x1d] eip = 0x014ced2c esp = 0x0889fd88 ebp = 0x0889fda4 Found by: previous frame's frame pointer 3 MainExecutable.exe!content::RasterWorkerPool::Run(std::vector<cc::TaskCategory,std::allocator<cc::TaskCategory> > const &,base::ConditionVariable *) [raster_worker_pool.cc : 240 + 0x8] eip = 0x01c564fb esp = 0x0889fdac ebp = 0x0889fdc0 Found by: call frame info 4 MainExecutable.exe!content::`anonymous namespace'::RasterWorkerPoolThread::Run [raster_worker_pool.cc : 34 + 0xf] eip = 0x01c5653f esp = 0x0889fdc8 ebp = 0x0889fdf8 Found by: call frame info 5 MainExecutable.exe!base::SimpleThread::ThreadMain() [simple_thread.cc : 66 + 0x7] eip = 0x014cf4f2 esp = 0x0889fdd4 ebp = 0x0889fdf8 Found by: call frame info 6 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0889fe00 ebp = 0x0889fe14 Found by: call frame info 7 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0889fe1c ebp = 0x0889fe28 Found by: call frame info 8 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0889fe30 ebp = 0x0889fe70 Found by: previous frame's frame pointer 9 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0889fe78 ebp = 0x0889fe80 Found by: previous frame's frame pointer Thread 7 0 ntdll.dll + 0x7873c eip = 0x7793873c esp = 0x089df874 ebp = 0x089df8bc ebx = 0x04ef3d18 esi = 0x00000000 edi = 0x04ef3d30 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00200206 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0x137fa3 eip = 0x74907fa3 esp = 0x089df8c4 ebp = 0x089df8e0 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::ConditionVariable::Wait() [condition_variable_win.cc : 26 + 0x1d] eip = 0x014ced2c esp = 0x089df8e8 ebp = 0x089df904 Found by: previous frame's frame pointer 3 MainExecutable.exe!content::RasterWorkerPool::Run(std::vector<cc::TaskCategory,std::allocator<cc::TaskCategory> > const &,base::ConditionVariable *) [raster_worker_pool.cc : 240 + 0x8] eip = 0x01c564fb esp = 0x089df90c ebp = 0x089df920 Found by: call frame info 4 MainExecutable.exe!content::`anonymous namespace'::RasterWorkerPoolThread::Run [raster_worker_pool.cc : 34 + 0xf] eip = 0x01c5653f esp = 0x089df928 ebp = 0x089df958 Found by: call frame info 5 MainExecutable.exe!base::SimpleThread::ThreadMain() [simple_thread.cc : 66 + 0x7] eip = 0x014cf4f2 esp = 0x089df934 ebp = 0x089df958 Found by: call frame info 6 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x089df960 ebp = 0x089df974 Found by: call frame info 7 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x089df97c ebp = 0x089df988 Found by: call frame info 8 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x089df990 ebp = 0x089df9d0 Found by: previous frame's frame pointer 9 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x089df9d8 ebp = 0x089df9e0 Found by: previous frame's frame pointer Thread 8 0 ntdll.dll + 0x7873c eip = 0x7793873c esp = 0x08b1fb94 ebp = 0x08b1fbd0 ebx = 0x04ef3d18 esi = 0x00000000 edi = 0x04ef3d30 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00200202 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0x137fa3 eip = 0x74907fa3 esp = 0x08b1fbd8 ebp = 0x08b1fbf4 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::ConditionVariable::Wait() [condition_variable_win.cc : 26 + 0x1d] eip = 0x014ced2c esp = 0x08b1fbfc ebp = 0x08b1fc18 Found by: previous frame's frame pointer 3 MainExecutable.exe!content::RasterWorkerPool::Run(std::vector<cc::TaskCategory,std::allocator<cc::TaskCategory> > const &,base::ConditionVariable *) [raster_worker_pool.cc : 240 + 0x8] eip = 0x01c564fb esp = 0x08b1fc20 ebp = 0x08b1fc34 Found by: call frame info 4 MainExecutable.exe!content::`anonymous namespace'::RasterWorkerPoolThread::Run [raster_worker_pool.cc : 34 + 0xf] eip = 0x01c5653f esp = 0x08b1fc3c ebp = 0x08b1fc6c Found by: call frame info 5 MainExecutable.exe!base::SimpleThread::ThreadMain() [simple_thread.cc : 66 + 0x7] eip = 0x014cf4f2 esp = 0x08b1fc48 ebp = 0x08b1fc6c Found by: call frame info 6 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x08b1fc74 ebp = 0x08b1fc88 Found by: call frame info 7 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x08b1fc90 ebp = 0x08b1fc9c Found by: call frame info 8 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x08b1fca4 ebp = 0x08b1fce4 Found by: previous frame's frame pointer 9 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x08b1fcec ebp = 0x08b1fcf4 Found by: previous frame's frame pointer Thread 9 0 ntdll.dll + 0x7873c eip = 0x7793873c esp = 0x08c5f784 ebp = 0x08c5f7cc ebx = 0x04ef3d18 esi = 0x00000000 edi = 0x04ef3d30 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0x137fa3 eip = 0x74907fa3 esp = 0x08c5f7d4 ebp = 0x08c5f7f0 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::ConditionVariable::Wait() [condition_variable_win.cc : 26 + 0x1d] eip = 0x014ced2c esp = 0x08c5f7f8 ebp = 0x08c5f814 Found by: previous frame's frame pointer 3 MainExecutable.exe!content::RasterWorkerPool::Run(std::vector<cc::TaskCategory,std::allocator<cc::TaskCategory> > const &,base::ConditionVariable *) [raster_worker_pool.cc : 240 + 0x8] eip = 0x01c564fb esp = 0x08c5f81c ebp = 0x08c5f830 Found by: call frame info 4 MainExecutable.exe!content::`anonymous namespace'::RasterWorkerPoolThread::Run [raster_worker_pool.cc : 34 + 0xf] eip = 0x01c5653f esp = 0x08c5f838 ebp = 0x08c5f868 Found by: call frame info 5 MainExecutable.exe!base::SimpleThread::ThreadMain() [simple_thread.cc : 66 + 0x7] eip = 0x014cf4f2 esp = 0x08c5f844 ebp = 0x08c5f868 Found by: call frame info 6 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x08c5f870 ebp = 0x08c5f884 Found by: call frame info 7 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x08c5f88c ebp = 0x08c5f898 Found by: call frame info 8 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x08c5f8a0 ebp = 0x08c5f8e0 Found by: previous frame's frame pointer 9 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x08c5f8e8 ebp = 0x08c5f8f0 Found by: previous frame's frame pointer Thread 10 0 ntdll.dll + 0x76c4c eip = 0x77936c4c esp = 0x0920fcbc ebp = 0x0920fcf0 ebx = 0x04f61eb0 esi = 0x00000000 edi = 0x04eaf064 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000202 Found by: given as instruction pointer in context 1 MainExecutable.exe!atom::NodeBindingsWin::PollEvents() [node_bindings_win.cc : 33 + 0x19] eip = 0x01304e72 esp = 0x0920fcf8 ebp = 0x0920fd1c Found by: previous frame's frame pointer 2 MainExecutable.exe!atom::NodeBindings::EmbedThreadRunner(void *) [node_bindings.cc : 267 + 0x7] eip = 0x01305c13 esp = 0x0920fd24 ebp = 0x0920fd2c Found by: call frame info 3 node.dll!uv__thread_start [thread.c : 122 + 0x6] eip = 0x6d113835 esp = 0x0920fd34 ebp = 0x0920fd4c Found by: call frame info 4 node.dll!thread_start<unsigned int (__stdcall*)(void *)> [thread.cpp : 115 + 0x2] eip = 0x6d1752e1 esp = 0x0920fd54 ebp = 0x0920fd88 Found by: call frame info 5 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0920fd90 ebp = 0x0920fd9c Found by: call frame info 6 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0920fda4 ebp = 0x0920fde4 Found by: previous frame's frame pointer 7 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0920fdec ebp = 0x0920fdf4 Found by: previous frame's frame pointer Thread 11 0 ntdll.dll + 0x76bfc eip = 0x77936bfc esp = 0x0978f6b8 ebp = 0x0978f728 ebx = 0x04f64690 esi = 0x00000000 edi = 0x000004a8 eax = 0xc000002a ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0xae162 eip = 0x7487e162 esp = 0x0978f730 ebp = 0x0978f73c Found by: previous frame's frame pointer 2 MainExecutable.exe!base::WaitableEvent::Wait() [waitable_event_win.cc : 48 + 0xa] eip = 0x014ca99a esp = 0x0978f744 ebp = 0x0978f76c Found by: previous frame's frame pointer 3 MainExecutable.exe!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc : 53 + 0x8] eip = 0x014c5a3b esp = 0x0978f750 ebp = 0x0978f76c Found by: call frame info 4 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x0978f774 ebp = 0x0978f79c Found by: call frame info 5 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x0978f780 ebp = 0x0978f79c Found by: call frame info 6 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x0978f7a4 ebp = 0x0978f7c0 Found by: call frame info 7 MainExecutable.exe!base::Thread::Run(base::MessageLoop *) [thread.cc : 202 + 0x8] eip = 0x0147defb esp = 0x0978f7c8 ebp = 0x0978f7c8 Found by: call frame info 8 MainExecutable.exe!base::Thread::ThreadMain() [thread.cc : 254 + 0xa] eip = 0x0147e3bd esp = 0x0978f7d0 ebp = 0x0978f800 Found by: call frame info 9 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0978f808 ebp = 0x0978f81c Found by: call frame info 10 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0978f824 ebp = 0x0978f830 Found by: call frame info 11 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0978f838 ebp = 0x0978f878 Found by: previous frame's frame pointer 12 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0978f880 ebp = 0x0978f888 Found by: previous frame's frame pointer Thread 12 0 ntdll.dll + 0x76bfc eip = 0x77936bfc esp = 0x09eff664 ebp = 0x09eff6d4 ebx = 0x04f64860 esi = 0x00000000 edi = 0x000004cc eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000202 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0xae162 eip = 0x7487e162 esp = 0x09eff6dc ebp = 0x09eff6e8 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::WaitableEvent::Wait() [waitable_event_win.cc : 48 + 0xa] eip = 0x014ca99a esp = 0x09eff6f0 ebp = 0x09eff718 Found by: previous frame's frame pointer 3 MainExecutable.exe!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc : 53 + 0x8] eip = 0x014c5a3b esp = 0x09eff6fc ebp = 0x09eff718 Found by: call frame info 4 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x09eff720 ebp = 0x09eff748 Found by: call frame info 5 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x09eff72c ebp = 0x09eff748 Found by: call frame info 6 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x09eff750 ebp = 0x09eff76c Found by: call frame info 7 MainExecutable.exe!base::Thread::Run(base::MessageLoop *) [thread.cc : 202 + 0x8] eip = 0x0147defb esp = 0x09eff774 ebp = 0x09eff774 Found by: call frame info 8 MainExecutable.exe!base::Thread::ThreadMain() [thread.cc : 254 + 0xa] eip = 0x0147e3bd esp = 0x09eff77c ebp = 0x09eff7ac Found by: call frame info 9 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x09eff7b4 ebp = 0x09eff7c8 Found by: call frame info 10 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x09eff7d0 ebp = 0x09eff7dc Found by: call frame info 11 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x09eff7e4 ebp = 0x09eff824 Found by: previous frame's frame pointer 12 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x09eff82c ebp = 0x09eff834 Found by: previous frame's frame pointer Thread 13 0 ntdll.dll + 0x76bfc eip = 0x77936bfc esp = 0x0f0ff988 ebp = 0x0f0ff9f8 ebx = 0x04f64b18 esi = 0x00000000 edi = 0x0000058c eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0xae162 eip = 0x7487e162 esp = 0x0f0ffa00 ebp = 0x0f0ffa0c Found by: previous frame's frame pointer 2 MainExecutable.exe!base::WaitableEvent::Wait() [waitable_event_win.cc : 48 + 0xa] eip = 0x014ca99a esp = 0x0f0ffa14 ebp = 0x0f0ffa3c Found by: previous frame's frame pointer 3 MainExecutable.exe!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc : 53 + 0x8] eip = 0x014c5a3b esp = 0x0f0ffa20 ebp = 0x0f0ffa3c Found by: call frame info 4 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x0f0ffa44 ebp = 0x0f0ffa6c Found by: call frame info 5 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x0f0ffa50 ebp = 0x0f0ffa6c Found by: call frame info 6 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x0f0ffa74 ebp = 0x0f0ffa90 Found by: call frame info 7 MainExecutable.exe!base::Thread::Run(base::MessageLoop *) [thread.cc : 202 + 0x8] eip = 0x0147defb esp = 0x0f0ffa98 ebp = 0x0f0ffa98 Found by: call frame info 8 MainExecutable.exe!base::Thread::ThreadMain() [thread.cc : 254 + 0xa] eip = 0x0147e3bd esp = 0x0f0ffaa0 ebp = 0x0f0ffad0 Found by: call frame info 9 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0f0ffad8 ebp = 0x0f0ffaec Found by: call frame info 10 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0f0ffaf4 ebp = 0x0f0ffb00 Found by: call frame info 11 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0f0ffb08 ebp = 0x0f0ffb48 Found by: previous frame's frame pointer 12 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0f0ffb50 ebp = 0x0f0ffb58 Found by: previous frame's frame pointer Thread 14 0 ntdll.dll + 0x77a1c eip = 0x77937a1c esp = 0x0e73ecf8 ebp = 0x0e73ed04 ebx = 0x17822c10 esi = 0x000002cc edi = 0x76cdec60 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000202 Found by: given as instruction pointer in context 1 0x6c0069 eip = 0x006c0069 esp = 0x0e73ed0c ebp = 0x00460067 Found by: previous frame's frame pointer Thread 15 0 ntdll.dll + 0x76bfc eip = 0x77936bfc esp = 0x0ba4f99c ebp = 0x0ba4fa0c ebx = 0x0f2ee208 esi = 0x00000000 edi = 0x00000b7c eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0xae162 eip = 0x7487e162 esp = 0x0ba4fa14 ebp = 0x0ba4fa20 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::WaitableEvent::Wait() [waitable_event_win.cc : 48 + 0xa] eip = 0x014ca99a esp = 0x0ba4fa28 ebp = 0x0ba4fa50 Found by: previous frame's frame pointer 3 MainExecutable.exe!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc : 53 + 0x8] eip = 0x014c5a3b esp = 0x0ba4fa34 ebp = 0x0ba4fa50 Found by: call frame info 4 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x0ba4fa58 ebp = 0x0ba4fa80 Found by: call frame info 5 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x0ba4fa64 ebp = 0x0ba4fa80 Found by: call frame info 6 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x0ba4fa88 ebp = 0x0ba4faa4 Found by: call frame info 7 MainExecutable.exe!base::Thread::Run(base::MessageLoop *) [thread.cc : 202 + 0x8] eip = 0x0147defb esp = 0x0ba4faac ebp = 0x0ba4faac Found by: call frame info 8 MainExecutable.exe!base::Thread::ThreadMain() [thread.cc : 254 + 0xa] eip = 0x0147e3bd esp = 0x0ba4fab4 ebp = 0x0ba4fae4 Found by: call frame info 9 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0ba4faec ebp = 0x0ba4fb00 Found by: call frame info 10 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0ba4fb08 ebp = 0x0ba4fb14 Found by: call frame info 11 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0ba4fb1c ebp = 0x0ba4fb5c Found by: previous frame's frame pointer 12 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0ba4fb64 ebp = 0x0ba4fb6c Found by: previous frame's frame pointer Thread 16 0 ntdll.dll + 0x76bfc eip = 0x77936bfc esp = 0x0bb4f92c ebp = 0x0bb4f99c ebx = 0x0f2ee4c0 esi = 0x00000000 edi = 0x000009a8 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000202 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0xae162 eip = 0x7487e162 esp = 0x0bb4f9a4 ebp = 0x0bb4f9b0 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::WaitableEvent::Wait() [waitable_event_win.cc : 48 + 0xa] eip = 0x014ca99a esp = 0x0bb4f9b8 ebp = 0x0bb4f9e0 Found by: previous frame's frame pointer 3 MainExecutable.exe!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc : 53 + 0x8] eip = 0x014c5a3b esp = 0x0bb4f9c4 ebp = 0x0bb4f9e0 Found by: call frame info 4 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x0bb4f9e8 ebp = 0x0bb4fa10 Found by: call frame info 5 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x0bb4f9f4 ebp = 0x0bb4fa10 Found by: call frame info 6 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x0bb4fa18 ebp = 0x0bb4fa34 Found by: call frame info 7 MainExecutable.exe!base::Thread::Run(base::MessageLoop *) [thread.cc : 202 + 0x8] eip = 0x0147defb esp = 0x0bb4fa3c ebp = 0x0bb4fa3c Found by: call frame info 8 MainExecutable.exe!base::Thread::ThreadMain() [thread.cc : 254 + 0xa] eip = 0x0147e3bd esp = 0x0bb4fa44 ebp = 0x0bb4fa74 Found by: call frame info 9 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0bb4fa7c ebp = 0x0bb4fa90 Found by: call frame info 10 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0bb4fa98 ebp = 0x0bb4faa4 Found by: call frame info 11 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0bb4faac ebp = 0x0bb4faec Found by: previous frame's frame pointer 12 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0bb4faf4 ebp = 0x0bb4fafc Found by: previous frame's frame pointer Thread 17 0 ntdll.dll + 0x7876c eip = 0x7793876c esp = 0x0bdbfae8 ebp = 0x0bdbfca0 ebx = 0x092bd8d0 esi = 0x092bd710 edi = 0x04ea4078 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0bdbfca8 ebp = 0x0bdbfcb4 Found by: previous frame's frame pointer 2 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0bdbfcbc ebp = 0x0bdbfcfc Found by: previous frame's frame pointer 3 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0bdbfd04 ebp = 0x0bdbfd0c Found by: previous frame's frame pointer Thread 18 0 ntdll.dll + 0x76bfc eip = 0x77936bfc esp = 0x0509f818 ebp = 0x0509f888 ebx = 0x0f2ed8f8 esi = 0x00000000 edi = 0x00000b54 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000206 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0xae162 eip = 0x7487e162 esp = 0x0509f890 ebp = 0x0509f89c Found by: previous frame's frame pointer 2 MainExecutable.exe!base::WaitableEvent::Wait() [waitable_event_win.cc : 48 + 0xa] eip = 0x014ca99a esp = 0x0509f8a4 ebp = 0x0509f8cc Found by: previous frame's frame pointer 3 MainExecutable.exe!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc : 53 + 0x8] eip = 0x014c5a3b esp = 0x0509f8b0 ebp = 0x0509f8cc Found by: call frame info 4 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x0509f8d4 ebp = 0x0509f8fc Found by: call frame info 5 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x0509f8e0 ebp = 0x0509f8fc Found by: call frame info 6 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x0509f904 ebp = 0x0509f920 Found by: call frame info 7 MainExecutable.exe!base::Thread::Run(base::MessageLoop *) [thread.cc : 202 + 0x8] eip = 0x0147defb esp = 0x0509f928 ebp = 0x0509f928 Found by: call frame info 8 MainExecutable.exe!base::Thread::ThreadMain() [thread.cc : 254 + 0xa] eip = 0x0147e3bd esp = 0x0509f930 ebp = 0x0509f960 Found by: call frame info 9 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0509f968 ebp = 0x0509f97c Found by: call frame info 10 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0509f984 ebp = 0x0509f990 Found by: call frame info 11 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0509f998 ebp = 0x0509f9d8 Found by: previous frame's frame pointer 12 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0509f9e0 ebp = 0x0509f9e8 Found by: previous frame's frame pointer Thread 19 0 ntdll.dll + 0x7876c eip = 0x7793876c esp = 0x0a1ffcd0 ebp = 0x0a1ffe88 ebx = 0x108b7de8 esi = 0x108b7c28 edi = 0x04ea4078 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000212 Found by: given as instruction pointer in context 1 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0a1ffe90 ebp = 0x0a1ffe9c Found by: previous frame's frame pointer 2 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0a1ffea4 ebp = 0x0a1ffee4 Found by: previous frame's frame pointer 3 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0a1ffeec ebp = 0x0a1ffef4 Found by: previous frame's frame pointer Thread 20 0 ntdll.dll + 0x7876c eip = 0x7793876c esp = 0x0a2ff68c ebp = 0x0a2ff844 ebx = 0x0a0bcd78 esi = 0x0a0bcbb8 edi = 0x04ea4078 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000202 Found by: given as instruction pointer in context 1 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0a2ff84c ebp = 0x0a2ff858 Found by: previous frame's frame pointer 2 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0a2ff860 ebp = 0x0a2ff8a0 Found by: previous frame's frame pointer 3 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0a2ff8a8 ebp = 0x0a2ff8b0 Found by: previous frame's frame pointer Thread 21 0 ntdll.dll + 0x76bfc eip = 0x77936bfc esp = 0x0aaff650 ebp = 0x0aaff6c0 ebx = 0x0b397b78 esi = 0x00000000 edi = 0x000008ec eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000216 Found by: given as instruction pointer in context 1 KERNELBASE.dll + 0xae162 eip = 0x7487e162 esp = 0x0aaff6c8 ebp = 0x0aaff6d4 Found by: previous frame's frame pointer 2 MainExecutable.exe!base::WaitableEvent::Wait() [waitable_event_win.cc : 48 + 0xa] eip = 0x014ca99a esp = 0x0aaff6dc ebp = 0x0aaff704 Found by: previous frame's frame pointer 3 MainExecutable.exe!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc : 53 + 0x8] eip = 0x014c5a3b esp = 0x0aaff6e8 ebp = 0x0aaff704 Found by: call frame info 4 MainExecutable.exe!base::MessageLoop::RunHandler() [message_loop.cc : 442 + 0x9] eip = 0x0147c711 esp = 0x0aaff70c ebp = 0x0aaff734 Found by: call frame info 5 MainExecutable.exe!base::RunLoop::Run() [run_loop.cc : 35 + 0x7] eip = 0x014ca645 esp = 0x0aaff718 ebp = 0x0aaff734 Found by: call frame info 6 MainExecutable.exe!base::MessageLoop::Run() [message_loop.cc : 294 + 0x8] eip = 0x0147c6ed esp = 0x0aaff73c ebp = 0x0aaff758 Found by: call frame info 7 MainExecutable.exe!base::Thread::Run(base::MessageLoop *) [thread.cc : 202 + 0x8] eip = 0x0147defb esp = 0x0aaff760 ebp = 0x0aaff760 Found by: call frame info 8 MainExecutable.exe!base::Thread::ThreadMain() [thread.cc : 254 + 0xa] eip = 0x0147e3bd esp = 0x0aaff768 ebp = 0x0aaff798 Found by: call frame info 9 MainExecutable.exe!base::`anonymous namespace'::ThreadFunc [platform_thread_win.cc : 84 + 0x9] eip = 0x0146b622 esp = 0x0aaff7a0 ebp = 0x0aaff7b4 Found by: call frame info 10 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x0aaff7bc ebp = 0x0aaff7c8 Found by: call frame info 11 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x0aaff7d0 ebp = 0x0aaff810 Found by: previous frame's frame pointer 12 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x0aaff818 ebp = 0x0aaff820 Found by: previous frame's frame pointer Thread 22 0 ntdll.dll + 0x7876c eip = 0x7793876c esp = 0x14dff920 ebp = 0x14dffad8 ebx = 0x0f36c028 esi = 0x0f36be68 edi = 0x04ea4078 eax = 0x00000000 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000212 Found by: given as instruction pointer in context 1 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x14dffae0 ebp = 0x14dffaec Found by: previous frame's frame pointer 2 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x14dffaf4 ebp = 0x14dffb34 Found by: previous frame's frame pointer 3 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x14dffb3c ebp = 0x14dffb44 Found by: previous frame's frame pointer Thread 23 0 ntdll.dll + 0x7876c eip = 0x7793876c esp = 0x14effd98 ebp = 0x14efff50 ebx = 0x00000000 esi = 0x0f775490 edi = 0x04ea4078 eax = 0x778ec6d0 ecx = 0x00000000 edx = 0x00000000 efl = 0x00000202 Found by: given as instruction pointer in context 1 kernel32.dll + 0x138f4 eip = 0x76cd38f4 esp = 0x14efff58 ebp = 0x14efff64 Found by: previous frame's frame pointer 2 ntdll.dll + 0x65de3 eip = 0x77925de3 esp = 0x14efff6c ebp = 0x14efffac Found by: previous frame's frame pointer 3 ntdll.dll + 0x65dae eip = 0x77925dae esp = 0x14efffb4 ebp = 0x14efffbc Found by: previous frame's frame pointer Loaded modules: 0x01260000 - 0x04e2efff MainExecutable.exe 0.0.139.0 (main) 0x20000000 - 0x20005fff wheel.dll ??? 0x52d80000 - 0x52daefff 9474.tmp.node ??? 0x6bae0000 - 0x6baf5fff pnrpnsp.dll 10.0.10586.0 0x6c770000 - 0x6caabfff ffmpeg.dll ??? 0x6cab0000 - 0x6d72bfff node.dll 6.3.0.0 0x6daa0000 - 0x6dabbfff srvcli.dll 10.0.10586.212 0x6ded0000 - 0x6df23fff oleacc.dll 7.2.10586.212 0x6df30000 - 0x6df45fff usp10.dll 10.0.10586.0 0x6efe0000 - 0x6efeafff winrnr.dll 10.0.10586.0 0x6eff0000 - 0x6f001fff NapiNSP.dll 10.0.10586.0 0x71d60000 - 0x71f50fff DWrite.dll 10.0.10586.494 0x72650000 - 0x728b9fff wininet.dll 11.0.10586.545 0x72a20000 - 0x72a29fff netutils.dll 10.0.10586.0 0x72a30000 - 0x72a3ffff wkscli.dll 10.0.10586.212 0x72c10000 - 0x72c17fff winnsi.dll 10.0.10586.0 0x72c80000 - 0x72ca0fff mdnsNSP.dll 3.0.0.10 0x72cb0000 - 0x72cfefff mswsock.dll 10.0.10586.420 0x72dd0000 - 0x72fdefff comctl32.dll 6.10.10586.494 0x73110000 - 0x73132fff WINMMBASE.dll 10.0.10586.0 0x73180000 - 0x731a3fff winmm.dll 10.0.10586.0 0x73280000 - 0x732aefff rsaenh.dll 10.0.10586.306 0x732b0000 - 0x732c2fff cryptsp.dll 10.0.10586.0 0x73300000 - 0x7332cfff fwbase.dll 10.0.10586.162 0x73330000 - 0x73343fff dhcpcsvc.dll 10.0.10586.420 0x73350000 - 0x73362fff dhcpcsvc6.DLL 10.0.10586.420 0x73410000 - 0x73430fff dbgcore.dll 10.0.10586.0 0x734f0000 - 0x7362efff dbghelp.dll 10.0.10586.0 0x73630000 - 0x7363afff davhlpr.dll 10.0.10586.0 0x739a0000 - 0x73a23fff dnsapi.dll 10.0.10586.212 0x73a50000 - 0x73a63fff nlaapi.dll 10.0.10586.0 0x73be0000 - 0x73bfafff bcrypt.dll 10.0.10586.0 0x73c00000 - 0x73c66fff winspool.drv 10.0.10586.122 0x74000000 - 0x74007fff version.dll 10.0.10586.0 0x74010000 - 0x74028fff userenv.dll 10.0.10586.0 0x74030000 - 0x7405efff IPHLPAPI.DLL 10.0.10586.0 0x744a0000 - 0x74514fff uxtheme.dll 10.0.10586.0 0x74520000 - 0x7453cfff dwmapi.dll 10.0.10586.0 0x745e0000 - 0x745e9fff CRYPTBASE.dll 10.0.10586.0 0x745f0000 - 0x7460dfff sspicli.dll 10.0.10586.0 0x74610000 - 0x74654fff shlwapi.dll 10.0.10586.0 0x747d0000 - 0x7494dfff KERNELBASE.dll 10.0.10586.494 (WARNING: No symbols, wkernelbase.pdb, 5487284F31FA4704ACA66F46B1F0390A1) 0x74960000 - 0x74966fff nsi.dll 10.0.10586.0 0x74970000 - 0x749cdfff FirewallAPI.dll 10.0.10586.162 0x74a20000 - 0x75e1dfff shell32.dll 10.0.10586.545 0x75e20000 - 0x75e9afff advapi32.dll 10.0.10586.63 0x75f00000 - 0x75f36fff cfgmgr32.dll 10.0.10586.0 0x75f40000 - 0x75f97fff bcryptPrimitives.dll 10.0.10586.420 0x75fa0000 - 0x75fb2fff netapi32.dll 10.0.10586.212 0x75fc0000 - 0x7617cfff combase.dll 10.0.10586.103 0x76180000 - 0x761c3fff sechost.dll 10.0.10586.0 0x761d0000 - 0x761d5fff psapi.dll 10.0.10586.0 0x761e0000 - 0x7628cfff rpcrt4.dll 10.0.10586.306 0x762f0000 - 0x7631afff imm32.dll 10.0.10586.0 0x76450000 - 0x76596fff user32.dll 10.0.10586.306 0x765a0000 - 0x765e3fff powrprof.dll 10.0.10586.0 0x76650000 - 0x7673afff ole32.dll 10.0.10586.545 0x76740000 - 0x767d1fff oleaut32.dll 10.0.10586.0 0x767e0000 - 0x7689dfff msvcrt.dll 7.0.10586.0 0x768c0000 - 0x76a0efff gdi32.dll 10.0.10586.420 0x76a10000 - 0x76a1bfff kernel.appcore.dll 10.0.10586.0 0x76cc0000 - 0x76d9ffff kernel32.dll 10.0.10586.0 (WARNING: No symbols, wkernel32.pdb, 3886D90B46544A42B146E6AB1BF7A3781) 0x76da0000 - 0x76e2cfff SHCore.dll 10.0.10586.494 0x76e30000 - 0x77329fff windows.storage.dll 10.0.10586.494 0x77330000 - 0x7733efff profapi.dll 10.0.10586.0 0x77350000 - 0x77441fff comdlg32.dll 10.0.10586.494 0x77860000 - 0x778befff ws2_32.dll 10.0.10586.420 0x778c0000 - 0x77a3afff ntdll.dll 10.0.10586.306 (WARNING: No symbols, wntdll.pdb, 94FD57A20B2B4917A44938FAF1F214811) ```
https://github.com/electron/electron/issues/6813
https://github.com/electron/electron/pull/6832
4e355355a9350a52dfa9c8f9b1806665abdd1b78
bd03ae53f20decceb14899b8a511bfc54ffc253d
2016-08-11T17:01:21Z
c++
2016-08-17T11:31:06Z
closed
electron/electron
https://github.com/electron/electron
6,811
["atom/browser/api/atom_api_web_contents.cc", "spec/api-web-contents-spec.js"]
Menu items roles may not be executed on the correct web contents
- Electron version: 1.2.8 - Operating system: Windows Hi, I've been trying to get a context menu containing some [predefined web contents roles](https://github.com/electron/electron/blob/master/lib/browser/api/menu-item-roles.js#L17) working for an application where we have multiple windows simultaneously. I've noticed that when a context menu is opened for a window that was created later than others, the role commands don't seem to execute when clicked. However, if don't use a role and instead define a click handler that calls the command on the web contents manually, it behaves normally. I've been doing some digging and it seems that the reason is because, for a role, [`electron.webContents.getFocusedWebContents`](https://github.com/electron/electron/blob/master/lib/browser/api/web-contents.js#L257) is used to determine which web contents to call the command on (see [menu.js](https://github.com/electron/electron/blob/master/lib/browser/api/menu.js#L121)). This function iterates through all existing web contents, then returns the first in the collection that is in a `webview`, otherwise the first that returns `true` from `contents.isFocused()`. However, it seems to be entirely possible that there are web contents other than the one that the context menu was raised for, who think they are focused (or perhaps are within a `webview`), and who were created earlier and therefore appear earlier in the collection. This means there are situations when the 'wrong' web contents is returned from `getFocusedWebContents`, and therefore the role command is called on that 'wrong' web contents, which leads to the unexpected behaviour described above. Is this a bug? And if so, is there a fix and/or workaround for this? I'm happy to contribute a PR if needed.
https://github.com/electron/electron/issues/6811
https://github.com/electron/electron/pull/6851
925fb27b1e59f9c769eee04cd75f4e94f014f132
4e355355a9350a52dfa9c8f9b1806665abdd1b78
2016-08-11T16:40:42Z
c++
2016-08-17T11:15:37Z
closed
electron/electron
https://github.com/electron/electron
6,808
["atom/browser/api/atom_api_web_contents.cc", "docs/api/web-contents.md", "docs/api/web-view-tag.md", "lib/renderer/web-view/guest-view-internal.js"]
did-navigate-in-page event triggered by IFRAME load
- Electron version: 1.3.3 - Operating system: Windows I have noticed that a `webview` will emit the `did-navigate-in-page` event when an IFRAME included in the page finishes loading. Is this the desired behavior? The documentation implies that this event shall only trigger when the main frame's URL hash changes. In any case, a flag `isMainFrame` would be helpful here.
https://github.com/electron/electron/issues/6808
https://github.com/electron/electron/pull/6810
58b391cb777c42f307f3180cc5df37f5181cb29f
6a7c6cae3ada5b7a7e18330484b801fe0b463659
2016-08-11T08:58:43Z
c++
2016-08-12T08:10:47Z
closed
electron/electron
https://github.com/electron/electron
6,784
["atom/browser/atom_download_manager_delegate.cc", "atom/browser/atom_download_manager_delegate.h", "spec/api-session-spec.js"]
DownloadItem shows save dialog on 404
- Electron version: 1.2.4 (May Be All Version has the issue) - Operating system: MAC OS X 10.10.5 (May Be All OS) i set the `DownloadItem.setSavePath` but if the target resource return 404 status from server, then the save dialog prompt. ### Steps to reproduce Merged in from #6957 1. Disconnect from the network 2. initiate a download using mainWindow.webContents.downloadURL(url); 3. call item.setSavePath(path) in the will-download handler Result: The browser will show a save dialog. Expected result: No save dialog, just an updated or done callback on the item It appears that the code that notices a save path has been set and prevents the dialog from coming up doesn't happen when the download fails.
https://github.com/electron/electron/issues/6784
https://github.com/electron/electron/pull/6983
d35613b5ad886b37d50b84ca6d8bf80dc730d20a
cd469b5f31b75ea3a7ea7ccabe12d327444720d6
2016-08-09T02:36:56Z
c++
2016-08-26T11:41:03Z
closed
electron/electron
https://github.com/electron/electron
6,734
["docs/api/remote.md"]
Remote array mutation not working in render process
- Electron version: 1.3.1 - Operating system: OS X 10.11.6 Mutating a remote-retrieved array doesn’t seem to work. Here’s a boiled-down example: ``` js // Main process module.exports = function getFromRemote() { return Promise.resolve({ myArray: [], }); }; ``` Using `Array#push` doesn’t actually mutate the array: ``` js // Render process const { remote } = require('electron'); const getFromRemote = remote.require('get-from-remote.js'); getFromRemote().then(myObject => { myObject.myArray.push('my-item'); // `myObject.myArray` doesn’t contain 'my-item' }); ``` Reassigning does work: ``` js getFromRemote().then(myObject => { myObject.myArray = myObject.myArray.concat('my-item'); // `myObject.myArray` contains 'my-item' }); ``` Any thoughts? This doesn’t seem like planned behavior based on the [`remote` documentation](http://electron.atom.io/docs/api/remote/).
https://github.com/electron/electron/issues/6734
https://github.com/electron/electron/pull/7294
de9b01409b7541667e4260be7f1e3dce59d073ea
3b4a071723a815cd126bec9be8329d8dd8488db9
2016-08-04T18:01:13Z
c++
2016-09-22T05:13:49Z
closed
electron/electron
https://github.com/electron/electron
6,704
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_web_contents.h", "atom/browser/osr/osr_output_device.cc", "atom/browser/osr/osr_output_device.h", "atom/browser/osr/osr_render_widget_host_view.cc", "atom/browser/osr/osr_render_widget_host_view.h", "docs/api/web-contents.md"]
Problems with offscreen mode
I tired with the offscreen mode and here are the problems I found: - [x] <del>The `data` of `paint` event is empty when loading simple local pages.</del> - [x] The size of `data` is wrong, current implement uses the size of pointer (`sizeof(bitmap_pixels)`). - [x] Crashes when opening devtools for offscreen window. - [x] We should probably show a dummy view indicating it is offscreen instead of provide NULL. - [x] The offscreen window is affecting the rendering of other windows. Try running `./script/test.py -g offscreen` and then refreshing the window. /cc @gerhardberger @brenca
https://github.com/electron/electron/issues/6704
https://github.com/electron/electron/pull/6713
01d3f76f92d49139e84931798465927712cb6063
32d93824175bfb03f3f2d318328dace8ae5281d1
2016-08-03T06:57:55Z
c++
2016-08-04T04:00:54Z
closed
electron/electron
https://github.com/electron/electron
6,695
["atom/browser/auto_updater_mac.mm"]
autoupdater.checkForUpdates does not display / bubble up possible "recovery suggestion" for errors on MacOS
The `autoUpdater.checkForUpdates` method calls `SQRLUpdater.checkForUpdatesCommand` in Squirrel.Mac. This method can throw an `NSError` under different circumstances, and it includes a `localizedRecoverySuggestion` in the error that is helpful for troubleshooting (i.e. "The server sent an invalid response" or "The server sent an invalid JSON response.") . See https://github.com/Squirrel/Squirrel.Mac/blob/master/Squirrel/SQRLUpdater.m. If there is an error in Squirrel.Mac while calling `autoUpdater.checkForUpdates()`, only `localizedDescription` and `localizedFailureReason` are bubbled up (see https://github.com/electron/electron/blob/master/atom/browser/auto_updater_mac.mm#L107). Would it be possible to also bubble up `localizedRecoverySuggestion`, so it is easier to troubleshoot any issues during updates on MacOS. - Electron version: 1.3.1. - Operating system: MacOS any.
https://github.com/electron/electron/issues/6695
https://github.com/electron/electron/pull/6743
5eeadb0ad4c3473961343068d4ed6404db41901c
fd461cdd27e660241792f01642c712a683e73826
2016-08-02T20:55:42Z
c++
2016-08-08T07:02:13Z
closed
electron/electron
https://github.com/electron/electron
6,664
["atom/browser/native_window_mac.mm", "spec/api-browser-window-spec.js"]
`resizable: false` also disables fullscreen
- Electron version: 1.3.1 - Operating system: OS X 10.11.6 Hi, I noticed an unintuitive behaviour, if I use resizable: false on browser window init, the fullscreen(green) button gets disabled and resize of window is also disabled. But if I set the resizable:true on init, and immediately on ready-to-show I use mainWindow.setResizable(false) the green button stays activated, which is my expected behaviour. (I want to have a fullscreenable, but not resizable window). Also, using this combination , I can only get a resize event, not a fullscreen on. Maybe fulscreenable:true should have precedence over resizable:false? - (I used that with no effect) Keep up the good work!
https://github.com/electron/electron/issues/6664
https://github.com/electron/electron/pull/6736
8a33464d41d4b3569668923814c41ed0fc264f55
3be68ba136e21cc10a34c6755008a30a49aaa273
2016-07-31T08:41:03Z
c++
2016-08-05T08:25:22Z
closed
electron/electron
https://github.com/electron/electron
6,659
["atom/browser/api/atom_api_protocol.cc", "atom/browser/atom_browser_context.cc", "atom/browser/atom_browser_context.h", "spec/api-session-spec.js"]
cookies.set( ) throw error with custom protocol
- Electron version: 1.2.2, and 1.3.1 (I only tested the 2 versions) - Operating system: Windows 10 steps: 1. Register a custom protocol **`"app"`** by `protocol.registerFileProtocol` ``` protocol.registerStandardSchemes(['app']); app.on('ready', function(){ protocol.registerFileProtocol('app', (request, callback) => { //....... }); //....... }); ``` 2. call `cookies.set` for **`app://myhost/`** ``` session.defaultSession.cookies.set({ url : 'app://myhost/', //custom protocol name : 'test', value : '12345' }, (error)=>{ if(error){ console.log(error); //error occurred here } } ); ``` With url of custom protocol, an error will occur. If using standard http protocol, the code works well. ``` session.defaultSession.cookies.set({ url : 'http://otherhost/', //standard http protocol name : 'test', value : '12345' }, (error)=>{ //works well, no error if(error){ console.log(error); } } ); ```
https://github.com/electron/electron/issues/6659
https://github.com/electron/electron/pull/6708
ce5bdaf46f553d10e02994080401be80c38fa21a
6cd1aa21afbe3c3f64873f3c9fe1c5b00485d7b5
2016-07-30T14:00:56Z
c++
2016-08-05T07:25:23Z
closed
electron/electron
https://github.com/electron/electron
6,648
["atom/browser/atom_access_token_store.cc", "atom/common/google_api_key.h", "docs/api/environment-variables.md"]
Provide a way to dynamically set GOOGLEAPIS_API_KEY
- Electron version: 1.3.1 - Operating system: OS X 10.11.6 Follow the instructions for running the electron-quickstart. Modify the index.html by adding this script to the bottom: ``` <script> window.addEventListener('load', function() { if (navigator.geolocation) { navigator.geolocation.getCurrentPosition(function(result) { console.log(result); }, function(error) { console.log(error); }); } }); </script> ``` You will now see a Position Error in your console when running. Error Code 2, 403 returned from google. Adding a permission request handler to your session and always calling the callback with true does not eliminate this error.
https://github.com/electron/electron/issues/6648
https://github.com/electron/electron/pull/7276
85702604c30b16df472cea6d6e502570ee736c2a
805ce0dee94a35f820d483c8c4118d559e2f1b69
2016-07-29T04:00:54Z
c++
2016-09-21T06:16:29Z
closed
electron/electron
https://github.com/electron/electron
6,647
["lib/browser/api/auto-updater/auto-updater-win.js", "spec/api-auto-updater-spec.js"]
autoUpdater.quitAndInstall() does not work if checked for update after update-downloaded is emitted on Windows
App installed on windows. 1. App calls autoUpdater.checkForUpdates(). 2. Event 'update-available' is emitted, then 'update-downloaded' is emitted. 3. App calls autoUpdater.checkForUpdates() again. 4. Event 'update-not-available' is emitted. I assume this means no newer update is available. 5. Now the app calls autoUpdater.quitAndInstall() for the first update downloaded in step 2. It gives an error "Error: No update available, can't quit and install" Expected: The app should quit and install, even after it emitted "update-not-available", as long as it emitted "update-downloaded" at least once. Sometimes the user might not want to quit and install an update immediately, and the app should be able to keep checking for newer update. This works fine on Mac. - Electron version: 1.2.6 - Operating system: Windows
https://github.com/electron/electron/issues/6647
https://github.com/electron/electron/pull/6780
25f29e30f5f8217bf61816c833f5e57ca03d5110
01f92a83ab83001a48644a32e2cfcfe569ef13c6
2016-07-29T02:58:55Z
c++
2016-08-09T11:44:26Z
closed
electron/electron
https://github.com/electron/electron
6,642
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_web_contents_mac.mm"]
Crash in WebContents::IsFocused when copy/paste
- Electron version: I'm using `"electron-prebuilt": "^1.2.0"` - Operating system: Mac OS X 10.11.6 I'm having trouble loading the following website https://blowback.fr in a webview in an electron app. I can't seem to find any information in the console or network related to it either. The website loads fine in Chrome. Any thoughts as to how to debug this or figure out what's going on? In addition, some users are reporting crashes when loading a website like that and attempting to copy/paste. ``` Date/Time: 2016-07-28 11:32:42.486 -0700 OS Version: Mac OS X 10.11.6 (15G31) Report Version: 11 Anonymous UUID: 539395CE-7099-6EBB-B667-B10B9A189857 Sleep/Wake UUID: 77786FFA-C69E-4BC7-BD08-5450BF63F530 Time Awake Since Boot: 140000 seconds Time Since Wake: 280 seconds System Integrity Protection: enabled Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY VM Regions Near 0: --> __TEXT 0000000108c05000-0000000108c06000 [ 4K] r-x/rwx SM=COW /Users/USER/Downloads/Orion.app/Contents/MacOS/Orion Application Specific Information: Performing @selector(itemSelected:) from sender NSMenuItem 0x7fb6a17b34d0 Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread 0 com.github.electron.framework 0x000000010983134c 0x108c10000 + 12718924 1 com.github.electron.framework 0x0000000108c86bed atom::api::WebContents::IsFocused() const + 45 2 com.github.electron.framework 0x0000000108c7bf8c bool base::internal::RunnableAdapter<bool (atom::api::WebContents::*)() const>::Run<>(atom::api::WebContents const*) + 28 3 com.github.electron.framework 0x0000000108c7bf5c bool base::internal::InvokeHelper<false, bool, base::internal::RunnableAdapter<bool (atom::api::WebContents::*)() const> >::MakeItSo<atom::api::WebContents const*>(base::internal::RunnableAdapter<bool (atom::api::WebContents::*)() const>, atom::api::WebContents const*&&) + 28 4 com.github.electron.framework 0x0000000108c7bf3a base::internal::Invoker<base::IndexSequence<>, base::internal::BindState<base::internal::RunnableAdapter<bool (atom::api::WebContents::*)() const>, bool (atom::api::WebContents const*)>, base::internal::InvokeHelper<false, bool, base::internal::RunnableAdapter<bool (atom::api::WebContents::*)() const> >, bool (atom::api::WebContents const*)>::Run(base::internal::BindStateBase*, atom::api::WebContents const*&&) + 26 5 com.github.electron.framework 0x0000000108c7be3c base::Callback<bool (atom::api::WebContents const*), (base::internal::CopyMode)1>::Run(atom::api::WebContents const*) const + 28 6 com.github.electron.framework 0x0000000108c7bdfc void mate::internal::Invoker<mate::internal::IndicesHolder<0ul>, atom::api::WebContents const*>::DispatchToCallback<bool>(base::Callback<bool (atom::api::WebContents const*), (base::internal::CopyMode)1>) + 60 7 com.github.electron.framework 0x0000000108c7bccc mate::internal::Dispatcher<bool (atom::api::WebContents const*)>::DispatchToCallback(v8::FunctionCallbackInfo<v8::Value> const&) + 172 8 libnode.dylib 0x000000010d49a821 v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) + 369 9 libnode.dylib 0x000000010d4d23c7 0x10d0f6000 + 4047815 10 libnode.dylib 0x000000010d4dcb9a 0x10d0f6000 + 4090778 11 ??? 0x000028005e7092a7 0 + 43982049546919 12 ??? 0x000028005e8cf1e7 0 + 43982051406311 13 ??? 0x000028005e8e090a 0 + 43982051477770 14 ??? 0x000028005e73b843 0 + 43982049753155 15 ??? 0x000028005e72512f 0 + 43982049661231 16 libnode.dylib 0x000000010d78a380 0x10d0f6000 + 6898560 17 libnode.dylib 0x000000010d78a1b6 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 326 18 libnode.dylib 0x000000010d483405 v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) + 469 19 com.github.electron.framework 0x0000000108c445ec mate::internal::V8FunctionInvoker<void (v8::Local<v8::Value>, int)>::Go(v8::Isolate*, mate::internal::SafeV8Function const&, v8::Local<v8::Value>, int) + 252 20 com.github.electron.framework 0x0000000108c447f9 void base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, v8::Local<v8::Value>, int)>::Run<v8::Isolate* const&, mate::internal::SafeV8Function const&, v8::Local<v8::Value>, int>(v8::Isolate* const&&&, mate::internal::SafeV8Function const&&&, v8::Local<v8::Value>&&, int&&) + 25 21 com.github.electron.framework 0x0000000108c447d5 void base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, v8::Local<v8::Value>, int)> >::MakeItSo<v8::Isolate* const&, mate::internal::SafeV8Function const&, v8::Local<v8::Value>, int>(base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, v8::Local<v8::Value>, int)>, v8::Isolate* const&&&, mate::internal::SafeV8Function const&&&, v8::Local<v8::Value>&&, int&&) + 21 22 com.github.electron.framework 0x0000000108c447a7 base::internal::Invoker<base::IndexSequence<0ul, 1ul>, base::internal::BindState<base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, v8::Local<v8::Value>, int)>, void (v8::Isolate*, mate::internal::SafeV8Function const&, v8::Local<v8::Value>, int), v8::Isolate*&, mate::internal::SafeV8Function>, base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (*)(v8::Isolate*, mate::internal::SafeV8Function const&, v8::Local<v8::Value>, int)> >, void (v8::Local<v8::Value>, int)>::Run(base::internal::BindStateBase*, v8::Local<v8::Value>&&, int&&) + 71 23 com.github.electron.framework 0x0000000108c42376 base::Callback<void (v8::Local<v8::Value>, int), (base::internal::CopyMode)1>::Run(v8::Local<v8::Value>, int) const + 38 24 com.github.electron.framework 0x0000000108c42337 atom::api::Menu::ExecuteCommand(int, int) + 55 25 com.github.electron.framework 0x0000000108c4238d non-virtual thunk to atom::api::Menu::ExecuteCommand(int, int) + 13 26 com.github.electron.framework 0x0000000108ccc205 0x108c10000 + 770565 27 libsystem_trace.dylib 0x00007fff8fafb07a _os_activity_initiate + 75 28 com.apple.AppKit 0x00007fff96fd8dbd -[NSApplication sendAction:to:from:] + 460 29 com.apple.AppKit 0x00007fff96fd8b57 -[NSMenuItem _corePerformAction] + 336 30 com.apple.AppKit 0x00007fff96fd88b7 -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] + 114 31 libsystem_trace.dylib 0x00007fff8fafb07a _os_activity_initiate + 75 32 com.apple.AppKit 0x00007fff96fd77a5 -[NSMenu performKeyEquivalent:] + 357 33 com.github.electron.framework 0x0000000108ca55ab atom::CommonWebContentsDelegate::HandleKeyboardEvent(content::WebContents*, content::NativeWebKeyboardEvent const&) + 139 34 com.github.electron.framework 0x0000000108c6c03d atom::api::WebContents::HandleKeyboardEvent(content::WebContents*, content::NativeWebKeyboardEvent const&) + 45 35 com.github.electron.framework 0x0000000108c6c04d non-virtual thunk to atom::api::WebContents::HandleKeyboardEvent(content::WebContents*, content::NativeWebKeyboardEvent const&) + 13 36 com.github.electron.framework 0x00000001096f515b 0x108c10000 + 11424091 37 com.github.electron.framework 0x00000001096f4d27 0x108c10000 + 11423015 38 com.github.electron.framework 0x00000001096f39fa 0x108c10000 + 11418106 39 com.github.electron.framework 0x00000001096f382e 0x108c10000 + 11417646 40 com.github.electron.framework 0x00000001096f34af 0x108c10000 + 11416751 41 com.github.electron.framework 0x000000010974c081 0x108c10000 + 11780225 42 com.github.electron.framework 0x0000000109739639 0x108c10000 + 11703865 43 com.github.electron.framework 0x0000000109d1e1f8 0x108c10000 + 17883640 44 com.github.electron.framework 0x0000000108ddce4b 0x108c10000 + 1887819 45 com.github.electron.framework 0x0000000108dfd8b3 0x108c10000 + 2021555 46 com.github.electron.framework 0x0000000108dfdbcc 0x108c10000 + 2022348 47 com.github.electron.framework 0x0000000108dfddbb 0x108c10000 + 2022843 48 com.github.electron.framework 0x0000000108dd2871 0x108c10000 + 1845361 49 com.github.electron.framework 0x0000000108df440a 0x108c10000 + 1983498 50 com.github.electron.framework 0x0000000108dd2274 0x108c10000 + 1843828 51 com.apple.CoreFoundation 0x00007fff93228881 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 52 com.apple.CoreFoundation 0x00007fff93207fbc __CFRunLoopDoSources0 + 556 53 com.apple.CoreFoundation 0x00007fff932074df __CFRunLoopRun + 927 54 com.apple.CoreFoundation 0x00007fff93206ed8 CFRunLoopRunSpecific + 296 55 com.apple.HIToolbox 0x00007fff96071935 RunCurrentEventLoopInMode + 235 56 com.apple.HIToolbox 0x00007fff9607176f ReceiveNextEventCommon + 432 57 com.apple.HIToolbox 0x00007fff960715af _BlockUntilNextEventMatchingListInModeWithFilter + 71 58 com.apple.AppKit 0x00007fff96d6fdf6 _DPSNextEvent + 1067 59 com.apple.AppKit 0x00007fff96d6f226 -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 454 60 com.apple.AppKit 0x00007fff96d63d80 -[NSApplication run] + 682 61 com.github.electron.framework 0x0000000108dd30a6 0x108c10000 + 1847462 62 com.github.electron.framework 0x0000000108dd26c4 0x108c10000 + 1844932 63 com.github.electron.framework 0x0000000108e12363 0x108c10000 + 2106211 64 com.github.electron.framework 0x000000010951a73b 0x108c10000 + 9479995 65 com.github.electron.framework 0x000000010951a543 0x108c10000 + 9479491 66 com.github.electron.framework 0x000000010951cb52 0x108c10000 + 9489234 67 com.github.electron.framework 0x00000001095161dd 0x108c10000 + 9462237 68 com.github.electron.framework 0x0000000109487c01 0x108c10000 + 8879105 69 com.github.electron.framework 0x0000000109486d76 0x108c10000 + 8875382 70 com.github.electron.framework 0x0000000108c12587 AtomMain + 71 71 com.stripe.orion 0x0000000108c05ec6 main + 38 72 libdyld.dylib 0x00007fff924295ad start + 1 Thread 1:: Dispatch queue: com.apple.libdispatch-manager 0 libsystem_kernel.dylib 0x00007fff946f8efa kevent_qos + 10 1 libdispatch.dylib 0x00007fff8f8d6165 _dispatch_mgr_invoke + 216 2 libdispatch.dylib 0x00007fff8f8d5dcd _dispatch_mgr_thread + 52 Thread 2:: NetworkConfigWatcher 0 libsystem_kernel.dylib 0x00007fff946f1f72 mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff946f13b3 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff932081c4 __CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff9320768c __CFRunLoopRun + 1356 4 com.apple.CoreFoundation 0x00007fff93206ed8 CFRunLoopRunSpecific + 296 5 com.apple.Foundation 0x00007fff926b2ed9 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 270 6 com.github.electron.framework 0x0000000108dd2ede 0x108c10000 + 1847006 7 com.github.electron.framework 0x0000000108dd26c4 0x108c10000 + 1844932 8 com.github.electron.framework 0x0000000108e12363 0x108c10000 + 2106211 9 com.github.electron.framework 0x0000000108dfd05d 0x108c10000 + 2019421 10 com.github.electron.framework 0x0000000108e31938 0x108c10000 + 2234680 11 com.github.electron.framework 0x0000000108e2dc37 0x108c10000 + 2219063 12 libsystem_pthread.dylib 0x00007fff8884299d _pthread_body + 131 13 libsystem_pthread.dylib 0x00007fff8884291a _pthread_start + 168 14 libsystem_pthread.dylib 0x00007fff88840351 thread_start + 13 Thread 3:: DnsConfigService 0 libsystem_kernel.dylib 0x00007fff946f8eca kevent + 10 ```
https://github.com/electron/electron/issues/6642
https://github.com/electron/electron/pull/6644
6bb342ef2ac8da6be5668870dd060b96e5dc654b
ea6e6dab8c45eff0cb061f0cbc2c068814de3418
2016-07-28T21:19:06Z
c++
2016-07-29T02:08:11Z
closed
electron/electron
https://github.com/electron/electron
6,635
["electron.gyp", "script/create-dist.py", "vendor/brightray"]
yellow border in <select>
- Electron version: 1.3.1 - Operating system: Linux ![yellow](https://cloud.githubusercontent.com/assets/188463/17215744/d7f72fe4-54d5-11e6-880f-1ea08039acc6.png) Possibly related to #6587, though I don't get any yellow in native menus.
https://github.com/electron/electron/issues/6635
https://github.com/electron/electron/pull/6646
72612ed2f5ff0a8435bb8379a21225ddb699f772
6bb342ef2ac8da6be5668870dd060b96e5dc654b
2016-07-28T14:17:47Z
c++
2016-07-29T02:07:23Z
closed
electron/electron
https://github.com/electron/electron
6,630
["atom/browser/common_web_contents_delegate_mac.mm"]
-[NSToolbarFullScreenWindow redispatchKeyEvent:]: unrecognized selector sent to instance
Electron 1.2.7, macOS only Seen a few reports of this: ``` Date/Time: 2016-07-27 17:33:16.936 -0700 OS Version: Mac OS X 10.11.5 (15F34) Report Version: 11 Anonymous UUID: BFDB9318-F4C7-3E88-A2B0-838D74414044 Sleep/Wake UUID: F6F84732-50DF-4A03-BC5A-005598A95D59 Time Awake Since Boot: 390000 seconds Time Since Wake: 3500 seconds System Integrity Protection: enabled Crashed Thread: 0 CrBrowserMain Dispatch queue: com.apple.main-thread Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Application Specific Information: *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSToolbarFullScreenWindow redispatchKeyEvent:]: unrecognized selector sent to instance 0x7f9123c3bef0' terminating with uncaught exception of type NSException abort() called Application Specific Backtrace 1: 0 CoreFoundation 0x00007fff8fa324f2 __exceptionPreprocess + 178 1 libobjc.A.dylib 0x00007fff88c1af7e objc_exception_throw + 48 2 CoreFoundation 0x00007fff8fa9c1ad -[NSObject(NSObject) doesNotRecognizeSelector:] + 205 3 CoreFoundation 0x00007fff8f9a2571 ___forwarding___ + 1009 4 CoreFoundation 0x00007fff8f9a20f8 _CF_forwarding_prep_0 + 120 5 Electron Framework 0x000000010ee0779a _ZN4atom25CommonWebContentsDelegate19HandleKeyboardEventEPN7content11WebContentsERKNS1_22NativeWebKeyboardEventE + 202 6 Electron Framework 0x000000010edce75d _ZN4atom3api11WebContents19HandleKeyboardEventEPN7content11WebContentsERKNS2_22NativeWebKeyboardEventE + 45 7 Electron Framework 0x000000010edce752 _ZN4atom3api11WebContents19HandleKeyboardEventEPN7content11WebContentsERKNS2_22NativeWebKeyboardEventE + 34 8 Electron Framework 0x000000010edce76d _ZThn80_N4atom3api11WebContents19HandleKeyboardEventEPN7content11WebContentsERKNS2_22NativeWebKeyboardEventE + 13 9 Electron Framework 0x000000010f856edb _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 9935307 10 Electron Framework 0x000000010f856aa7 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 9934231 11 Electron Framework 0x000000010f85577a _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 9929322 12 Electron Framework 0x000000010f8555ae _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 9928862 13 Electron Framework 0x000000010f85522f _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 9927967 14 Electron Framework 0x000000010f8ade41 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 10291505 15 Electron Framework 0x000000010f89b3f9 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 10215145 16 Electron Framework 0x000000010fe7ffb8 _CTFontManagerUnregisterFontForData + 3800696 17 Electron Framework 0x000000010ef3ebcb _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 399035 18 Electron Framework 0x000000010ef5f633 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 532771 19 Electron Framework 0x000000010ef5f94c _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 533564 20 Electron Framework 0x000000010ef5fb3b _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 534059 21 Electron Framework 0x000000010ef345f1 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 356577 22 Electron Framework 0x000000010ef5618a _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 494714 23 Electron Framework 0x000000010ef33ff4 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 355044 24 CoreFoundation 0x00007fff8f9c7881 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 25 CoreFoundation 0x00007fff8f9a6fbc __CFRunLoopDoSources0 + 556 26 CoreFoundation 0x00007fff8f9a64df __CFRunLoopRun + 927 27 CoreFoundation 0x00007fff8f9a5ed8 CFRunLoopRunSpecific + 296 28 HIToolbox 0x00007fff90d87935 RunCurrentEventLoopInMode + 235 29 HIToolbox 0x00007fff90d8776f ReceiveNextEventCommon + 432 30 HIToolbox 0x00007fff90d875af _BlockUntilNextEventMatchingListInModeWithFilter + 71 31 AppKit 0x00007fff8d83bdf6 _DPSNextEvent + 1067 32 AppKit 0x00007fff8d83b226 -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 454 33 AppKit 0x00007fff8d82fd80 -[NSApplication run] + 682 34 Electron Framework 0x000000010ef34e26 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 358678 35 Electron Framework 0x000000010ef34444 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 356148 36 Electron Framework 0x000000010ef740e3 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 617427 37 Electron Framework 0x000000010f67c4bb _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 7991211 38 Electron Framework 0x000000010f67c2c3 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 7990707 39 Electron Framework 0x000000010f67e8d2 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 8000450 40 Electron Framework 0x000000010f677f5d _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 7973453 41 Electron Framework 0x000000010f5e9981 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 7390321 42 Electron Framework 0x000000010f5e8af6 _ZN4base8internal30DstRangeRelationToSrcRangeImplIilLNS0_21IntegerRepresentationE1ELS2_1ELNS0_26NumericRangeRepresentationE0EE5CheckEl + 7386598 43 Electron Framework 0x000000010ed75307 AtomMain + 71 44 Slack 0x000000010ed6eec6 main + 38 45 libdyld.dylib 0x00007fff8eaf05ad start + 1 Thread 0 Crashed:: CrBrowserMain Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x00007fff83e38f06 __pthread_kill + 10 1 libsystem_pthread.dylib 0x00007fff8ae7c4ec pthread_kill + 90 2 libsystem_c.dylib 0x00007fff8ecff6e7 abort + 129 3 libc++abi.dylib 0x00007fff88be0f81 abort_message + 257 4 libc++abi.dylib 0x00007fff88c06a47 default_terminate_handler() + 267 5 libobjc.A.dylib 0x00007fff88c1d6ae _objc_terminate() + 103 6 libc++abi.dylib 0x00007fff88c0419e std::__terminate(void (*)()) + 8 7 libc++abi.dylib 0x00007fff88c03c12 __cxa_throw + 121 8 libobjc.A.dylib 0x00007fff88c1b08c objc_exception_throw + 318 9 com.apple.CoreFoundation 0x00007fff8fa9c1ad -[NSObject(NSObject) doesNotRecognizeSelector:] + 205 10 com.apple.CoreFoundation 0x00007fff8f9a2571 ___forwarding___ + 1009 11 com.apple.CoreFoundation 0x00007fff8f9a20f8 _CF_forwarding_prep_0 + 120 12 com.github.electron.framework 0x000000010ee0779a atom::CommonWebContentsDelegate::HandleKeyboardEvent(content::WebContents*, content::NativeWebKeyboardEvent const&) + 202 13 com.github.electron.framework 0x000000010edce75d atom::api::WebContents::HandleKeyboardEvent(content::WebContents*, content::NativeWebKeyboardEvent const&) + 45 14 com.github.electron.framework 0x000000010edce752 atom::api::WebContents::HandleKeyboardEvent(content::WebContents*, content::NativeWebKeyboardEvent const&) + 34 15 com.github.electron.framework 0x000000010edce76d non-virtual thunk to atom::api::WebContents::HandleKeyboardEvent(content::WebContents*, content::NativeWebKeyboardEvent const&) + 13 ```
https://github.com/electron/electron/issues/6630
https://github.com/electron/electron/pull/6637
e5e4c53b1ef8722a29a432fabffd4ecfbd3eda19
72612ed2f5ff0a8435bb8379a21225ddb699f772
2016-07-28T04:02:13Z
c++
2016-07-29T01:42:36Z
closed
electron/electron
https://github.com/electron/electron
6,610
["atom/browser/atom_browser_context.cc"]
Electron crashes, when add project to workspace in devtools
- Electron version: 1.3.0 - Operating system: Kubuntu 16.04
https://github.com/electron/electron/issues/6610
https://github.com/electron/electron/pull/6613
7c1f48808b50684cdae3c9d75d1d149c22b7ac70
b3530a55a917ebc49465653745cb680c4472ad96
2016-07-26T09:47:21Z
c++
2016-07-26T23:53:33Z
closed
electron/electron
https://github.com/electron/electron
6,608
["atom/browser/javascript_environment.cc", "atom/common/node_bindings.cc"]
--debug-brk doesn't stop on first line
- Electron version: 1.3.0 - Operating system: OS X 10.11.6 I'm trying to use VSCode to debug Electron's main process. So I cloned https://github.com/electron/electron-quick-start Setup VSCode debugging in `.vscode/launch.json`. ``` { "version": "0.2.0", "configurations": [ { "name": "Attach", "type": "node", "request": "attach", "port": 5858, "sourceMaps": false } ] ``` Now I run `./node_modules/.bin/electron --debug-brk=5858 main.js`, then using VSCode to attach to the process. ### main.js (simplified from `electron/electron-quick-start`): ``` const electron = require('electron') const app = electron.app const BrowserWindow = electron.BrowserWindow // BREAKPOINT let mainWindow function createWindow () { mainWindow = new BrowserWindow({width: 800, height: 600}) // BREAKPOINT mainWindow.loadURL(`file://${__dirname}/index.html`) mainWindow.on('closed', function () { mainWindow = null }) } app.on('ready', createWindow) app.on('window-all-closed', function () { if (process.platform !== 'darwin') { app.quit() } }) app.on('activate', function () { if (mainWindow === null) { createWindow() } }) ``` VSCode attaches correctly, but it misses the two breakpoints in the initial run. However, if I then close the Renderer window, and click the dock icon again, I'm able to hit the breakpoint in `createWindow`. I'm expecting with `--debug-brk=5858`, it should break on this line: `const electron = require('electron')` And then after attaching the process, I should be able to step through from there. But Electron just goes on to create the Renderer window. Any idea how I can get it to stop at the first line of script, as the documentation says? <img width="851" alt="screen shot 2016-07-25 at 11 17 09 pm" src="https://cloud.githubusercontent.com/assets/4033249/17127918/f3a13696-52bd-11e6-8e99-029cd23dae5b.png">
https://github.com/electron/electron/issues/6608
https://github.com/electron/electron/pull/7001
9965423c4d51e25294cfd705f49829ee014c59ca
ac9e64cfd4e3140ac0ec5fdfeeefbbcf9d7a4470
2016-07-26T06:25:15Z
c++
2016-08-29T06:15:14Z
closed
electron/electron
https://github.com/electron/electron
6,605
["atom/common/node_bindings.cc"]
Remote DevTools in a webview throws error
Steps to reproduce the problem: Load a remote DevTools front-end in a webview (same Electron version on both ends) What is the expected behavior? Remote DevTools is opened in the webview What went wrong? "Uncaught TypeError: Cannot read property 'extensions' of undefined". At this point, it tries to access window.runtime.extensions("settings"). See screenshot. Did this work before? Yes 51.0.2704.63 Chrome version: 52.0.2743.82 OS Version: OS X 10.11.4 Worked fine until Electron 1.2.0 (Chromium 51.0.2704.63) with the disablewebsecurity attribute set. Broken on 1.2.1. Current chromium version (1.3.0): 52.0.2743.82 ![screen shot 2016-07-25 at 5 36 13 pm](https://cloud.githubusercontent.com/assets/1028286/17125639/1a265cce-52aa-11e6-8413-2d75c642dbb2.png)
https://github.com/electron/electron/issues/6605
https://github.com/electron/electron/pull/6707
617820dfc24573d232f293e33a40665855d84c02
230943d425c6921ee04b4cf82cec2ae85ea3205e
2016-07-26T03:55:34Z
c++
2016-08-03T09:14:01Z
closed
electron/electron
https://github.com/electron/electron
6,587
["electron.gyp", "script/create-dist.py", "script/lib/config.py", "vendor/brightray"]
Electron 1.3.0-pre: Menus are oddly spaced and have yellow highlight on Win32
![image](https://cloud.githubusercontent.com/assets/1396/17084998/fedc4c18-5181-11e6-862f-42fab562a962.png) Easy to miss on the default app since it's set to hide menus by default
https://github.com/electron/electron/issues/6587
https://github.com/electron/electron/pull/6589
f4207560f29ef2041597dabd1de2a5876d7439ba
4af72617ee055acd52b95129df8a010f1eb3d6dc
2016-07-24T16:36:04Z
c++
2016-07-25T03:54:45Z
closed
electron/electron
https://github.com/electron/electron
6,574
["atom/browser/native_window_views_win.cc"]
Window position doesn't restore correctly minimize and restore window
- Electron version: 1.2.7 - Operating system: Windows Copy the released electron windows binary from 1.2.7 and run electron.exe. On the browser window opened, move the window to a different position on the screen to change x and y of browser window. Minimize the browser window Click on the task bar icon to bring app into foregroun (or use alt + tab) Browser window gets restored to position (x,y) before the move operation.
https://github.com/electron/electron/issues/6574
https://github.com/electron/electron/pull/6596
c70ec47138330f78ee0796f14a857c52d8bd414d
7b6d74fdc2a0267ae687de7dd0b4fd28e7b656ca
2016-07-22T21:36:53Z
c++
2016-07-26T02:21:59Z
closed
electron/electron
https://github.com/electron/electron
6,555
["lib/common/asar.js", "spec/asar-spec.js"]
Missing fs.access patches for asar traversal
- Electron version: 1.2.7 - Operating system: macOS 10.11.5 As noted here: https://github.com/sindresorhus/electron-config/issues/1#issuecomment-234118084 [`fs.access`](https://nodejs.org/api/fs.html#fs_fs_access_path_mode_callback) and [`fs.accessSync`](https://nodejs.org/api/fs.html#fs_fs_accesssync_path_mode) aren't patched in [asar.js](https://github.com/electron/electron/blob/a0c5749ac1731afbbb7d042f1717597d6d68ea02/lib/common/asar.js), which breaks packages like [path-exists](https://github.com/sindresorhus/path-exists/) when traversing within an asar.
https://github.com/electron/electron/issues/6555
https://github.com/electron/electron/pull/6598
7b6d74fdc2a0267ae687de7dd0b4fd28e7b656ca
b139d5ad1c48d8e9daeb3a147fa59cf8306d29cf
2016-07-21T00:05:19Z
c++
2016-07-26T03:42:59Z
closed
electron/electron
https://github.com/electron/electron
6,553
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_web_contents.h", "docs/api/web-contents.md"]
Allow access to base64 data URL of media from context-menu
- Electron version: 1.2.7 - Operating system: macOS 10.11.5 I'd like to add the option to copy an image directly from a context menu, but the only ways I can see to access the data are: 1) Redownload the image srcURL, resulting in an extra HTTP request and an undefined delay before the clipboard is updated 2) Use the DOM to add the image to a canvas element and pull the base64 out of that, which won't work for cross origin urls. Could the image data be made available from the context menu, or else provide some other way to access it from an img tag in webcontents?
https://github.com/electron/electron/issues/6553
https://github.com/electron/electron/pull/6619
7994f087fb46c845f7fbe3dab216324b6b97ddb7
99b523176b05f399c11d4d82a99384cf43943550
2016-07-20T19:02:41Z
c++
2016-07-27T01:15:38Z
closed
electron/electron
https://github.com/electron/electron
6,550
["atom/common/crash_reporter/crash_reporter_win.cc", "atom/common/crash_reporter/crash_reporter_win.h", "spec/api-crash-reporter-spec.js"]
Crash on restarting crashreporter for main/renderer process
- Electron version: 1.2.7 - Operating system: Windows 64-bit When restarting crashreporter for Main/Renderer process causes the app to crash. And i wanted to restart the crash reporter to be able to update the extra/options parameters which are not available when the app starts initially. Without delaying the crash reporter start, is there a way to update the crash reporter options/extra parameters? Stack: INVALID_POINTER_WRITE_electron!crash_reporter::_anonymous_namespace_::RegisterNonABICompliantCodeRange+23 00 00000095`813fc230 00007ff7`06221b70 electron!crash_reporter::`anonymous namespace'::RegisterNonABICompliantCodeRange+0x23 [c:\jenkins\workspace\electron-win-x64\atom\common\crash_reporter\crash_reporter_win.cc @ 95] 01 00000095`813fc370 00007ff7`06222ebf electron!crash_reporter::CrashReporterWin::InitBreakpad+0x3c4 [c:\jenkins\workspace\electron-win-x64\atom\common\crash_reporter\crash_reporter_win.cc @ 203] 02 00000095`813fc620 00007ff7`06194bb6 electron!crash_reporter::CrashReporter::Start+0x9f [c:\jenkins\workspace\electron-win-x64\atom\common\crash_reporter\crash_reporter.cc @ 33]
https://github.com/electron/electron/issues/6550
https://github.com/electron/electron/pull/6618
4dc8e905865310ebf091ab994dd78a6b13512e2d
7994f087fb46c845f7fbe3dab216324b6b97ddb7
2016-07-20T18:35:12Z
c++
2016-07-27T00:52:18Z
closed
electron/electron
https://github.com/electron/electron
6,541
["atom/common/native_mate_converters/content_converter.cc"]
hasImageContents always true
- Electron version: 1.2.7 - Operating system: Win10 64bit browser process ``` javascript win.webContents.on('context-menu', (event, params) => { // It prints "hasImageContent: undefined" no matter where you right click on the page console.log(`hasImageContent: ${ params.hasImageContent }`); }); ``` index.html body ``` html <body> <textarea name="name" rows="8" cols="40"> Hello world. Second line. </textarea> <img src="https://bearychat.com/e655795080a2258b3bc7476cf6b519ab.png"/> </body> ```
https://github.com/electron/electron/issues/6541
https://github.com/electron/electron/pull/6817
d84098c4c14ab9086de55465ec28107db376e1d6
05518ccd5299a96e30254f993d433c79d90080b8
2016-07-20T06:18:13Z
c++
2016-08-12T08:51:40Z
closed
electron/electron
https://github.com/electron/electron
6,538
["docs/api/web-view-tag.md"]
Webview contradictory documentation
- > For security purpose, webview can only be used in BrowserWindows that have nodeIntegration enabled. > https://github.com/electron/electron/blob/master/docs/api/web-view-tag.md#webview-tag - > Node integration will always be disabled in the webview if it is disabled on the parent window. > https://github.com/electron/electron/blob/master/docs/api/web-view-tag.md#nodeintegration
https://github.com/electron/electron/issues/6538
https://github.com/electron/electron/pull/6547
99524bf490de10455285d1845593bd6cdd2677aa
a0c5749ac1731afbbb7d042f1717597d6d68ea02
2016-07-19T21:04:01Z
c++
2016-07-20T11:18:47Z
closed
electron/electron
https://github.com/electron/electron
6,536
["atom/browser/api/atom_api_window.cc", "atom/browser/api/atom_api_window.h", "atom/browser/native_window.cc", "atom/browser/native_window.h", "atom/browser/native_window_mac.h", "atom/browser/native_window_mac.mm", "atom/browser/native_window_views.cc", "atom/browser/native_window_views.h", "docs/api/browser-window.md", "spec/api-browser-window-spec.js"]
Expose a way to get the content position start
We can get the content size and the window size, but not the chrome position. At the moment we do this: ``` leftBorderWidth = (windowWidth - contentWidth) / 2; titlebarHeight = windowHeight - (contentHeight + leftBorderWidth); ``` which makes some assumptions so therefore feels a bit wrong. it would be nice if alongside getContentSize (https://github.com/electron/electron/blob/master/docs/api/browser-window.md#wingetcontentsize) there was a getContentOffset. I've been looking at the C++ - https://github.com/electron/electron/blob/e05804848f98959d63337aacd9047cd579c5b23f/chromium_src/extensions/browser/app_window/size_constraints.cc and I don't see an easy way to get this information - do you have any ideas or pointers if you accept this as a feature request?
https://github.com/electron/electron/issues/6536
https://github.com/electron/electron/pull/6654
2ef33bc158d0c0d973f5fbdff7e2f42e84fa409d
8a33464d41d4b3569668923814c41ed0fc264f55
2016-07-19T08:48:03Z
c++
2016-08-05T08:23:24Z
closed
electron/electron
https://github.com/electron/electron
6,528
["atom/browser/api/atom_api_tray.cc", "atom/browser/api/atom_api_tray.h", "atom/browser/ui/tray_icon.cc", "atom/browser/ui/tray_icon.h", "atom/browser/ui/tray_icon_cocoa.h", "atom/browser/ui/tray_icon_cocoa.mm", "docs/api/tray.md"]
Tray icon manual highlight on OSX
- Electron version: 1.2.7 - Operating system: OSX Hi everyone, I'm working on a project where I have a Tray icon, and a window pops out of it when clicked, and this window is hidden when the Tray is clicked again. The current behaviour of the Tray when clicked is to be highlighted while clicked, but I'd like to make it stay highlighted while my window is opened. I haven't found a way to make it work with the latest (1.2.7) version of electron. What I'd suggest is to add a Tray method 'setHighlighted' which takes a boolean, along with 'getHighlighted' which returns a boolean. Is it feasible ?
https://github.com/electron/electron/issues/6528
https://github.com/electron/electron/pull/6620
99b523176b05f399c11d4d82a99384cf43943550
b8bafbc5a3f7bb6dfd9ccad3ee866a43f9a629a4
2016-07-18T15:12:07Z
c++
2016-07-27T01:49:38Z
closed
electron/electron
https://github.com/electron/electron
6,519
["atom/browser/relauncher_mac.cc"]
Relaunching on macOS fails with EBADF
- Electron version: `1.2.7` - Operating system: macOS Attempting to relaunch the app like so ``` js remote.app.relaunch({ args: remote.process.argv.slice(1).concat(['--dev']) }); remote.app.quit(); ``` Throws a really strange error from the `default_app`. <img width="429" alt="screen shot 2016-07-17 at 1 14 08 pm" src="https://cloud.githubusercontent.com/assets/6634592/16898177/5594b28c-4c20-11e6-8aef-a5d3b91fb643.png"> This is strange as the line it claims to fail on is https://github.com/electron/electron/blob/master/default_app/main.js#L259 Which does `console.error` so I don't see why it ends up calling `fs.writeSync` This issue does not occur in the normal Electron app but I assume that is because it isn't attempting to read a `package.json`
https://github.com/electron/electron/issues/6519
https://github.com/electron/electron/pull/6527
1a0199c2adab2ca5052bf4cafbaa1500b00193bc
4081381700cc43c83afb7aa754113c80c26bd834
2016-07-17T01:15:50Z
c++
2016-07-18T15:00:36Z
closed
electron/electron
https://github.com/electron/electron
6,516
["atom/renderer/atom_renderer_client.cc"]
Widevine plugin detected only after referencing it in console
- Electron version: 1.2.7 - Operating system: Mac OSX El Capitan - Widevine CDM version: 1.4.8.885 I'm trying to build an app which play widevine-encrypted video. My prototype works only if I type `navigator.plugins` in console or if I execute `console.log(navigator.plugins);` (with console open). Otherwise it won't work. I tried it with shaka player demo page and with local dashjs-based player.
https://github.com/electron/electron/issues/6516
https://github.com/electron/electron/pull/8907
84e7387b17cfd45a09321bfe303d7df506549e9c
48152a813ba12c9bdbdcfaefaf578f490836dfa3
2016-07-16T14:11:11Z
c++
2017-03-13T16:22:21Z
closed
electron/electron
https://github.com/electron/electron
6,491
["atom/browser/api/atom_api_session.cc", "docs/api/session.md"]
Make the callback of session.clearStorageData optional
Docs: https://github.com/electron/electron/blob/master/docs/api/session.md#sesclearstoragedataoptions-callback I was running into a strange error when calling the `clearStorageData` method. It was saying it was unable to process the argument at index 1, which I was not passing. After some research I found that the callback is currently required, but in my case I did not care to provide one. To fix it, I supplied an empty function. Here is my code: ``` Electron.remote.getCurrentWebContents().session.clearStorageData( { storages: [ 'appcache', 'cookies', 'filesystem', 'indexdb', 'localstorage', 'shadercache', 'websql', 'serviceworkers', ], quotas: [ 'temporary', 'persistent', 'syncable', ], }, function() {} // <--- I shouldn't have to do this ); ``` - Electron version: 1.2.7 - Operating system: macOS
https://github.com/electron/electron/issues/6491
https://github.com/electron/electron/pull/6502
9eacd07eda28147d09219bb8d16484a3a8e14e61
43b5e655a45c01a9ed017c7f0e7565de0880c94e
2016-07-14T20:27:28Z
c++
2016-07-15T13:45:49Z
closed
electron/electron
https://github.com/electron/electron
6,454
["atom/browser/api/atom_api_auto_updater.cc", "atom/browser/api/atom_api_auto_updater.h", "atom/browser/auto_updater.cc", "atom/browser/auto_updater.h", "atom/browser/auto_updater_mac.mm", "docs/api/auto-updater.md", "lib/browser/api/auto-updater/auto-updater-win.js", "spec/api-auto-updater-spec.js"]
Add getFeedURL API to autoUpdater
- Electron version: 1.2.6 - Operating system: osx yosemite Do the autoUpdater objects on osx and windows have different properties? On windows, when i do `console.log(JSON.stringify(autoUpdater));` I see the properties `domain`, `_events`, `_eventsCount`, and `updateURL`. However, doing the same thing on osx only allows me to see the properties `_events` and `_eventsCount`. I want to access `updateURL` in my code but I'm wondering whether that property is accessible. Maybe I should submit a PR for a `getFeedURL` method?
https://github.com/electron/electron/issues/6454
https://github.com/electron/electron/pull/6486
7c5616963313935058fa1cfb7a6487b56e00adc5
5db758297fbd55236f2d196a5ba440cbac43cf4f
2016-07-12T17:05:32Z
c++
2016-07-15T01:02:05Z
closed
electron/electron
https://github.com/electron/electron
6,435
["lib/renderer/api/remote.js", "spec/api-ipc-spec.js", "spec/fixtures/module/circular.js"]
Remote call Array reference does not work (for twice).
- Electron version:1.2.6 - Operating system:Windows 10 x64 ``` JavaScript //renderer process const flags = ['disabled']; currentWindow.setThumbarButtons([{ tooltip: 'rewind', icon: path.join(__dirname, 'rewind.png'), flags }, { tooltip: this.state === 'play' ? 'pause' : 'play', icon: path.join(__dirname, 'play.png'), flags }, { tooltip: 'forward', icon: path.join(__dirname, 'forward.png'), flags }]); ``` Only the first one disabled...It should be IRC(remote module)'s bug, because it does work in main process
https://github.com/electron/electron/issues/6435
https://github.com/electron/electron/pull/6442
53440e89937cc23366b34f50e256e68057b6fa57
21a8a727f8cea03e90b2404b23906530c14da66d
2016-07-11T07:59:53Z
c++
2016-07-12T01:39:16Z
closed
electron/electron
https://github.com/electron/electron
6,426
["atom/browser/api/atom_api_web_contents.cc", "atom/browser/api/atom_api_web_contents.h", "atom/common/api/api_messages.h", "atom/renderer/atom_render_view_observer.cc", "atom/renderer/atom_render_view_observer.h", "docs/api/web-contents.md"]
Add "painted" event in which can safely call capturePage
- Electron version: 1.2.6 - Operating system: Windows 7 x64 I've made a simple app that gets a file with URL list, load every URL in the main window, make a full screenshot and save it in the `img` subdirectory as PNG. Here is all the test code: `package.json` ``` json { "name": "electron-screenshots", "main": "screenshots.win.js" } ``` `screenshots.urls.txt` ``` http://json.org/json-de.html http://json.org/json-en.html http://json.org/json-fr.html ``` `screenshots.win.js` ``` js /******************************************************************************/ 'use strict'; /******************************************************************************/ const fs = require('fs'); const path = require('path'); const rl = require('readline'); const { app, BrowserWindow } = require('electron'); /******************************************************************************/ const imgPath = path.join(__dirname, 'img'); const urls = []; const timeoutFromLoad = 100; const timeoutFromResize = 100; let mainWindow; let i = 0; /******************************************************************************/ app.disableHardwareAcceleration(); if (!fs.readdirSync(__dirname).includes('img')) fs.mkdirSync(imgPath); app.once('ready', createWindow); /******************************************************************************/ function createWindow() { mainWindow = new BrowserWindow({ enableLargerThanScreen: true, webPreferences: { nodeIntegration: false, }, }); mainWindow.setMenu(null); mainWindow.webContents.on('did-finish-load', () => { setTimeout(saveDoc, timeoutFromLoad); }); getURLs(); } /******************************************************************************/ function getURLs() { rl.createInterface({ input: fs.createReadStream( path.join(__dirname, 'screenshots.urls.txt'), { encoding: 'utf8' } ), }).on('line', line => { line = line.trim(); if (line) urls.push(line); }).on('close', getDoc); } /******************************************************************************/ function getDoc() { if (urls.length) mainWindow.loadURL(urls.shift()); else console.log('All done.'); } /******************************************************************************/ function saveDoc() { mainWindow.webContents.executeJavaScript( `[document.documentElement.scrollWidth, document.documentElement.scrollHeight]`, false, result => { mainWindow.setContentSize(result[0], result[1]); setTimeout(() => { mainWindow.capturePage(img => { fs.writeFileSync(path.join(imgPath, `${++i}.png`), img.toPNG()); console.log(`${mainWindow.webContents.getURL()} saved.`); getDoc(); }); }, timeoutFromResize); } ); } /******************************************************************************/ ``` This code works fine. Here are some found verifiable issues: 1. If I does not disable hardware acceleration, I get an empty window after resize and empty images after screenshots saving. To verify: comment out `app.disableHardwareAcceleration();`. 2. If I does not add timeout after `setContentSize`, I get the first image with distorted proportions (other images are OK because they do not need resize after the first resize). To verify: set `timeoutFromResize` to `0`. 3. If I does not add timeout after `did-finish-load` fired, I get images with lacunas (no page `img` elements, aborted text an so on). Sometimes I get PNG with 0 bytes. It seems that for `capturePage` to work properly, a user need an event like `document-painted` or `document-rendered`. To verify: set `timeoutFromLoad` to `0`, comment out `app.disableHardwareAcceleration();`, comment out or delete all the resize code, i.e. just make `saveDoc()` like this: ``` js function saveDoc() { mainWindow.capturePage(img => { fs.writeFileSync(path.join(imgPath, `${++i}.png`), img.toPNG()); console.log(`${mainWindow.webContents.getURL()} saved.`); getDoc(); }); } ```
https://github.com/electron/electron/issues/6426
https://github.com/electron/electron/pull/6524
c0f81d14e40a87b5eed6d286deb7d1bbbf76b532
c497765dea35cdfa060b045fabcdb2ae87468f28
2016-07-10T21:24:58Z
c++
2016-07-25T07:02:50Z
closed
electron/electron
https://github.com/electron/electron
6,396
["atom/browser/resources/win/atom.ico"]
Taskbar icon looks pixelated in 125% scaling environment on Windows
- Electron version: 1.2.6 - Operating system: Windows 10 x64 When using 125% scaling, the taskbar icon looks pixelated. It looks fine in 100% and 150%. I tried three apps, [email protected], [email protected] and [email protected]. I think that Atom should have same problem, but it looks fine in all environment. I'm not sure the reason why atom has no problem. 100%: ![100](https://cloud.githubusercontent.com/assets/1412057/16688067/1f7802a0-4557-11e6-852a-1fad65e0e186.png) 125%: ![125](https://cloud.githubusercontent.com/assets/1412057/16688069/20184b16-4557-11e6-8f5c-6df044e3357b.png) 150%: ![150](https://cloud.githubusercontent.com/assets/1412057/16688072/21c8e506-4557-11e6-8ebe-956be176c592.png) Dialog for 125%: ![2016-07-08 21 38 36](https://cloud.githubusercontent.com/assets/1412057/16688111/58cf37a8-4557-11e6-8dd8-50cd157b77f2.png)
https://github.com/electron/electron/issues/6396
https://github.com/electron/electron/pull/6645
8bf30ace4ba8187e14736f16339ecc6dd2c00d4e
e5e4c53b1ef8722a29a432fabffd4ecfbd3eda19
2016-07-08T13:09:08Z
c++
2016-07-29T01:33:55Z
closed
electron/electron
https://github.com/electron/electron
6,388
["atom/browser/api/atom_api_protocol.cc", "atom/browser/api/atom_api_protocol.h", "atom/browser/atom_access_token_store.cc", "atom/browser/net/atom_url_request_job_factory.cc", "atom/browser/net/atom_url_request_job_factory.h"]
Session is lost between app restarts
- Electron version: 1.2.6 - Operating system: macOS 10.11.5, Windows 10 (issue verified in both) Up to and including v1.2.2, closing an Electron application and reopening it would restore the session/cookies as it was previously. As of v1.2.3 (and still verified as an issue in v1.2.6), this is no longer the case. In our case users login to our application and get a cookie that allows them to continue using the app for a few weeks. This may be tangental, but it seems that if the session was created by v1.2.2 or older, upgrading to v1.2.3+ retains that session. But as soon as it is cleared by v1.2.3+ and you try to login again, closing the app and reopening will always present the login screen, tossing the session that was created by the previous app instance.
https://github.com/electron/electron/issues/6388
https://github.com/electron/electron/pull/6411
3481acd5700d761468ddafbe3d771e618b7bbdad
1beba5bdc086671bed9205faa694817f5a07c6ad
2016-07-08T00:04:32Z
c++
2016-07-09T08:18:31Z
closed
electron/electron
https://github.com/electron/electron
6,387
["docs/api/remote.md"]
Possible typos in the remote.md
- Electron version: 1.2.6 - Operating system: Windows 7 x 64 The code example [here](https://github.com/electron/electron/blob/master/docs/api/remote.md#passing-callbacks-to-the-main-process) seems to have two typos: 1. `return exports.mapNumbers(x => x + 1);` should be `return [1,2,3].map(x => x + 1);` (for now it just throws `...exports.mapNumbers is not a function...`) 2. `[true, true, true]` should be `[undefined, undefined, undefined]` according to the output I get with first typo fixed. If I do get it right, I could make a PR for this fix.
https://github.com/electron/electron/issues/6387
https://github.com/electron/electron/pull/6392
b02a83c96e716c5870d1e396a0bf2e37f7dc5ec4
204734f80bb85882bf33dea732e09018d9452c4a
2016-07-07T22:48:15Z
c++
2016-07-08T01:03:32Z
closed
electron/electron
https://github.com/electron/electron
6,373
["docs/api/web-contents.md", "docs/development/setting-up-symbol-server.md", "docs/tutorial/windows-store-guide.md"]
Is pdf.dll still needed?
- Electron version: 1.2.6 - Operating system: Windows 7 x 64 `pdf.dll` is mentioned in the `webContents` doc: > Note: On Windows, the print API relies on pdf.dll. If your application doesn’t need the print feature, you can safely remove pdf.dll to reduce binary size. and in the "Windows Store Guide" doc (package file tree). However, in the last precompiled versions for Windows x64 there is no `pdf.dll`. And `webContents.printToPDF` seems to work without it. Are these mentions some legacy fragments?
https://github.com/electron/electron/issues/6373
https://github.com/electron/electron/pull/6377
a053dc2f7dcd4de2330df63cf22d5ae4b7ba1bc3
eedac775e4418164ef10507f19ba2797e9d5fe5f
2016-07-06T19:42:35Z
c++
2016-07-07T01:45:55Z
closed
electron/electron
https://github.com/electron/electron
6,362
["atom/browser/common_web_contents_delegate_mac.mm"]
Accelerator is not working without combination key
- Electron version: 1.2.5 - Operating system: OS X 10.11.5 Accelerator is not working without combination key (e.g., 'H') since 1.2.4 (at 1.2.3, it works fine.) It works well if accelerator is combinated key (e.g., 'CmdOrCtrl+T') [accelerator-not-working.zip](https://github.com/electron/electron/files/349634/accelerator-not-working.zip)
https://github.com/electron/electron/issues/6362
https://github.com/electron/electron/pull/6370
bbfdaf7679cf69bdd22437c46282d0c2ae56a1ae
c7e0df09bc7a08a3670949b6b77ab5b4938d5294
2016-07-06T11:28:18Z
c++
2016-07-07T01:11:12Z
closed
electron/electron
https://github.com/electron/electron
6,353
["lib/browser/init.js"]
Electron throws if package.json is in UTF-8 with BOM
- Electron version: 1.2.5 - Operating system: Windows 7 An error dialog with the `Unexpected token in JSON at position 0` message appears. Electron properly strips BOM from `.js` and `.html` files, why not to do so for `package.json`? Node.js, npm, eslint, NW.js strip BOM from `package.json` in UTF-8.
https://github.com/electron/electron/issues/6353
https://github.com/electron/electron/pull/6354
83ae14f2ed627ff73a2c83b152c9c6a69d75460c
6fe4653b54dbf68ed466d1c1780d13b08a979038
2016-07-05T22:39:44Z
c++
2016-07-06T00:48:37Z
closed
electron/electron
https://github.com/electron/electron
6,347
["atom/browser/native_window_mac.mm"]
Calling setSize can override minimum width values
- Electron version: `1.2.3` - Operating system: macOS If you define a `minWidth` and then call `setSize` on a BrowserWindow with a width less than the `minWidth`, the window will be resized temporarily but any attempt to resize it will immediately return it to the minWidth. ``` js const { app, BrowserWindow } = require('electron'); app.on('ready', () => { const b = new BrowserWindow({ minWidth: 300, maxWidth: 300, width: 300, }); setTimeout(() => { b.setSize(100, 500); }, 1000); }) ``` `setSize` should be a noop for dimension changes that put the dimensions smaller than the `minWidth` or larger than the `maxWidth`
https://github.com/electron/electron/issues/6347
https://github.com/electron/electron/pull/6363
c3ce53a7b2859a7da8632fe475e51f70e13d7f4a
43e9f30b2113c4ab6703a7821ccbc1f67ef46baa
2016-07-05T02:36:33Z
c++
2016-07-07T10:52:47Z
closed
electron/electron
https://github.com/electron/electron
6,344
["atom/browser/native_window.cc"]
No LCD-text-antialiasing anymore since Electron 1.2.0 (since the Chrome 51 update)
Since Electron 1.2.0, that means since the update from Chrome 50 to Chrome 51, there no LCD-text-antialiasing anymore (tested only on Windows). Here an animated GIF showing the difference (300% zoomed screenshots) - look at the 'To run...' text: ![lcd-text-antialiasing](https://cloud.githubusercontent.com/assets/5989766/16565403/46503f2a-420d-11e6-9573-da40f6abd453.gif) The text is now less sharp and slightly blurred... NWJS has the same problem since updating to Chrome 51, but Chrome 51 itself is fine. Due my own research it seems that the problem might be somehow related to some page/window background-color and/or transparency settings... (Chrome renders automatically with grayscale-antialiasing on transparent elements).
https://github.com/electron/electron/issues/6344
https://github.com/electron/electron/pull/6606
2b0cd97bb8c84c696a86717eddc443ca630c4d25
61d16d5caade0d966127fcfc24ae061ffe7d2de1
2016-07-04T15:34:27Z
c++
2016-07-26T05:11:20Z
closed
electron/electron
https://github.com/electron/electron
6,305
["atom/browser/ui/file_dialog_gtk.cc"]
GNU/Linux: `dialog.showOpenDialog()` changing result extensions based on filters
I'm encountering a very weird issue, only in GNU/Linux. Consider the following gist that shows an open dialog and presents the resulting filename in the screen: https://gist.github.com/jviotti/b8358165f1694228fbc31e400dbadab6, which you can run by `npm install && npm start`. Now create a file with a `.img.gz` extension, like `foo.img.gz`. Using the `touch` command is enough. Try to select it using the gist application. The `.img.gz` extension is replaced by `.zip` (or whatever is the first item of the extensions filter) for some strange reason. The issue only seems reproducible with files containing multiple extensions, and when a dialog filter is present. - Electron version: 1.2.5 - Operating system: GNU/Linux (Ubuntu 14.04 and Arch Linux)
https://github.com/electron/electron/issues/6305
https://github.com/electron/electron/pull/6315
cff50614e55f3159d06578e634cd996b23dbff9d
df3e651fbf542815475e74ab61631415103b35d6
2016-06-30T18:28:40Z
c++
2016-07-01T14:14:18Z
closed
electron/electron
https://github.com/electron/electron
6,302
["atom/browser/atom_resource_dispatcher_host_delegate.cc", "atom/common/api/atom_api_shell.cc", "atom/common/platform_util.h", "atom/common/platform_util_win.cc"]
shell.openExternal(path) does not work well if there are non-ascii chars in the path
- Electron version: 1.1.1 - Operating system: win 10 I want to open a dir in local disk on windows, but noticed if there are some chinese chars in the path, it just did not work you can reproduce it by create a dir named "测试" and try to open that path ( I did not test on newer electron version as I have to stick to electron 1.1.1 for there is a serious bug in later electron version https://github.com/electron/electron/issues/5844 )
https://github.com/electron/electron/issues/6302
https://github.com/electron/electron/pull/6436
5abe72667889b4a048f79adcc081c3e6349e29d7
61641391674e2975953fda8e9904964e80996865
2016-06-30T15:44:55Z
c++
2016-07-11T08:31:17Z
closed
electron/electron
https://github.com/electron/electron
6,293
["atom/browser/native_window_mac.mm"]
Showing sync message box immediately after closing modal window hangs
- Electron version: 1.2.5 - Operating system: macOS 10.10.5 I am experience a hang in my Electron application that does not occur in 1.2.3. My application creates a modal browser window. In response to a button click, the modal browser window is closed. Then, I try to quit the application using Cmd-Q. I handle before-quit and in the process I try to open a message box dialog.The dialog is never displayed. The Quit menu item is grayed out. The application is behaving as if the modal browser window had not been closed (but I closed it).
https://github.com/electron/electron/issues/6293
https://github.com/electron/electron/pull/7131
a0eccdfe1ee48465c797a231811057199a509279
2885e980a5d01f9df35ec097b34d6964820f8223
2016-06-29T21:30:36Z
c++
2016-09-08T06:53:07Z