status
stringclasses 1
value | repo_name
stringlengths 9
24
| repo_url
stringlengths 28
43
| issue_id
int64 1
104k
| updated_files
stringlengths 8
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 37
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
facebook/react
|
https://github.com/facebook/react
| 24,279 |
["packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js", "packages/eslint-plugin-react-hooks/src/RulesOfHooks.js", "scripts/rollup/validate/eslintrc.cjs.js", "scripts/rollup/validate/eslintrc.cjs2015.js"]
|
Bug: [eslint-plugin-exhaustive-deps] hook wrongly marked as conditional (at exact number of conditionals in FC)
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
When using an exact number of conditionals before and after a react hook, the `React Hook "hook_name" is called conditionally. React Hooks must be called in the exact same order in every component render` rule is wrongly flagged as being violated. This is a really weird bug and it's kind of hard to explain. Just take a look at the code and watch as ESLint flags the hook as somehow being conditional. While this may seem like a huge edge case, this actually triggered in our code base and caused all hooks in the component to be flagged as conditional.
React version: 18.0.0 (doesn't seem to matter)
## Steps To Reproduce
1. Check out [this project](https://github.com/SanderRonde/eslint-hook-bug), run `yarn` and run `yarn eslint app/foo.tsx`.
2. Watch as the hook is incorrectly flagged as conditional.
3. Removing **or adding** one of the conditionals in the return statement makes the bug go away. The same goes for removing one of the conditionals above the hook.
Link to code example: https://github.com/SanderRonde/eslint-hook-bug
Unfortunately I couldn't get it to work online (because of a lack of terminals)
## The current behavior
Hook is incorrectly flagged as conditional
## The expected behavior
Hook should not be conditional
|
https://github.com/facebook/react/issues/24279
|
https://github.com/facebook/react/pull/24287
|
f56dfe950b206651913bf0b836c10592c393357d
|
1f7a901d7b2fc073e29a1887553b1bd18080da1b
| 2022-04-05T13:03:48Z |
javascript
| 2022-04-07T23:22:47Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 24,270 |
["packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js", "packages/react-dom/src/client/ReactDOMComponent.js", "packages/react-dom/src/client/ReactDOMHostConfig.js"]
|
Bug: `suppressHydrationWarning` is not taken into account in production builds in React 18
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18
## Steps To Reproduce
1. Clone https://github.com/Avansai/next-multilingual
2. run: npm install
3. run: npm build
4. run: npm run start-example-build
5. Go to the following URL: http://localhost:3000/fr-ca/tests/routes-dynamiques/123
6. Open the console log: no errors
7. Kill the app, and update the react and react-dom package to version 18.0
8. Re-run steps 2 to 5
9. Open the console log: lots of hydration errors #[425](https://reactjs.org/docs/error-decoder.html?invariant=425), #[418](https://reactjs.org/docs/error-decoder.html?invariant=418) and #[423](https://reactjs.org/docs/error-decoder.html?invariant=423).
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
https://github.com/Avansai/next-multilingual
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
Using React 18, the tests are failing because of the errors being thrown in the console.
<img width="935" alt="image" src="https://user-images.githubusercontent.com/6453322/161457567-c0777ffa-a3e5-4e21-80bc-51619942299f.png">
I confirmed this was related to `suppressHydrationWarning` because as soon as I removed the following code from: https://github.com/Avansai/next-multilingual/blob/main/example/pages/tests/dynamic-routes/%5Bid%5D.tsx#L37
```jsx
<tr>
<td>{messages.format('rowLocalizedWithAsPath')}</td>
{/* Adding `suppressHydrationWarning` until
https://github.com/vercel/next.js/issues/32772 is resolved */}
<td suppressHydrationWarning={true}>{asPath}</td>
</tr>
```
The errors stop. However, I could not find any mention that `suppressHydrationWarning` was no longer supported with React 18 and these errors are only triggered on builds, not in dev mode (which is why I am opening this issue)
## The expected behavior
`suppressHydrationWarning` should prevent these errors from being thrown.
|
https://github.com/facebook/react/issues/24270
|
https://github.com/facebook/react/pull/24271
|
985272e26858ce3838fde856b022200b9c7d3dcb
|
fc47cb1b61ac012f9bd6d7251eb19fcecf364a3b
| 2022-04-04T00:59:24Z |
javascript
| 2022-04-04T15:23:58Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 24,268 |
["packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js", "packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js"]
|
Bug: [eslint-plugin-exhaustive-deps] can't find unstable value.
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0 (not important)
## Steps To Reproduce
I'll show as a code.
<img width="593" alt="스크린샷 2022-04-04 오전 12 01 05" src="https://user-images.githubusercontent.com/65149763/161434194-868b7fbb-9571-40d8-a4e3-2b261506d9ac.png">
Link to code example:
https://codesandbox.io/s/stupefied-raman-g6j3fi?file=/src/App.js
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
exhaustive-deps can't found unstable dependency.
## The expected behavior
Warn lint message.
## Opinion
I know this code is super weird but This code may be improved. something like
- Add more core lint rule like 'useState is always declared as a const'
- eslint-plugin-exhaustive-deps should find reallocation value. and calculate real value.
- Or just stay it.
I just wonder what is your opinion. thank you.
|
https://github.com/facebook/react/issues/24268
|
https://github.com/facebook/react/pull/24343
|
4997515b96eede5ab1ca622e0439a0707f8d4afd
|
069d23bb74939c19bc8860ad4013324bd6e1c5f3
| 2022-04-03T15:14:27Z |
javascript
| 2022-04-11T20:43:16Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 24,233 |
["packages/eslint-plugin-react-hooks/CHANGELOG.md"]
|
eslint-plugin-react-hooks CHANGELOG missing 4.4.0 release
|
Currently the CHANGELOG shows 4.3.0 as the latest version of `eslint-plugin-react-hooks`, but at least on `main`, there is not a 4.4.0.
React version: n/a
## Steps To Reproduce
1. View Changelog
2. Compare to version on https://www.npmjs.com/package/eslint-plugin-react-hooks
Link to code example: n/a
## The current behavior
No 4.4.0 explanation in CHANGELOG.md
## The expected behavior
4.4.0 explanation in CHANGELOG.md
|
https://github.com/facebook/react/issues/24233
|
https://github.com/facebook/react/pull/24234
|
b76103d66fdb7396cbfcc66a032b31a0cd8ad342
|
aa05e73150d4a80fe4b1f9cbf61d3b81766fa127
| 2022-03-31T14:05:12Z |
javascript
| 2022-03-31T14:43:08Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 24,203 |
["packages/react-reconciler/src/ReactFiberWorkLoop.new.js", "packages/react-reconciler/src/ReactFiberWorkLoop.old.js"]
|
Bug: No warning on infinite useEffect loop in React 18
|
https://codesandbox.io/s/elastic-mayer-rzz4h2?file=/package.json
This is supposed to `console.error` but it doesn't.
17 warns: https://codesandbox.io/s/admiring-minsky-sze07m?file=/src/App.js
|
https://github.com/facebook/react/issues/24203
|
https://github.com/facebook/react/pull/24295
|
0579154772af551bfccf9ff0cc7076a39316344a
|
d68b09defca37c30d3a7a34d4de884e374c74858
| 2022-03-29T23:03:55Z |
javascript
| 2022-04-07T17:06:35Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 24,162 |
["packages/react-devtools-extensions/src/backend.js", "packages/react-devtools-extensions/src/contentScript.js"]
|
[DevTools Bug] Cannot add node "1" because a node with that id is already in the Store.
|
### Website or app
http://bestellen-a.cito.nl
### Repro steps
Just opening the console and going to Components or Profiler shows this error.
I noticed that in the console there are two warnings for contentScript.js (I am assuming this file is part of this extension):
contentScript.js:113 [Violation] 'message' handler took 210ms
contentScript.js:113 [Violation] 'message' handler took 891ms
### How often does this bug happen?
Sometimes
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.24.0-82762bea5
### Error message (automated)
Cannot add node "1" because a node with that id is already in the Store.
### Error call stack (automated)
```text
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:26326:41
at bridge_Bridge.emit (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:24400:22)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:24566:14
at listener (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:54300:39)
```
### Error component stack (automated)
_No response_
### GitHub query string (automated)
```text
https://api.github.com/search/issues?q=Cannot add node because a node with that id is already in the Store. in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
```
|
https://github.com/facebook/react/issues/24162
|
https://github.com/facebook/react/pull/24186
|
e7d0053e65db49a536440eb24e6c1e4961d976f6
|
ba0aee5d71874202ebf8760a802bb1d6f2f61a5e
| 2022-03-25T13:05:28Z |
javascript
| 2022-03-28T18:25:30Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 24,160 |
["packages/react-reconciler/src/ReactFiberCommitWork.new.js", "packages/react-reconciler/src/ReactFiberCommitWork.old.js", "packages/react-reconciler/src/ReactFiberWorkLoop.new.js", "packages/react-reconciler/src/ReactFiberWorkLoop.old.js", "packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js"]
|
React 18: Updates scheduled from useInsertionEffect
|
Following up on https://github.com/reactjs/reactjs.org/pull/4486#discussion_r834319756 (/cc @acdlite )
React version: 18.0.0-rc.3-next-1159ff619-20220324
## Steps To Reproduce
1. schedule an update (e.g. `setState`) from within `useInsertionEffect`
Link to code example: https://codesandbox.io/s/naughty-bogdan-boghf6?file=/src/index.js
## The current behavior
Update is applied and no warning is issued.
## The expected behavior
According to https://github.com/reactjs/reactjs.org/pull/4486/files#diff-a1c8ec10dc40c86b4bbd55ad3f0126835bd45e9aa9e56c846a2e28ad6dd6acffR602 `useInsertionEffect` cannot schedule updates. But `setState` seems to "work". Maybe this is just incidental because it's the first render?
I got the impression that this should definitely cause a warning (not implemented) but I wonder if we also should consistently drop updates from `useInsertionEffect`?
|
https://github.com/facebook/react/issues/24160
|
https://github.com/facebook/react/pull/24298
|
548b542b41565340a9ffd36d0d4e5e1d244cc113
|
f56dfe950b206651913bf0b836c10592c393357d
| 2022-03-25T10:03:02Z |
javascript
| 2022-04-07T19:12:49Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 24,096 |
["packages/react-devtools-shared/src/__tests__/inspectedElement-test.js", "packages/react-devtools-shared/src/backend/renderer.js", "packages/react-devtools-shared/src/backend/types.js", "packages/react-devtools-shared/src/backendAPI.js", "packages/react-devtools-shared/src/devtools/views/ErrorBoundary/CaughtErrorView.js", "packages/react-devtools-shared/src/devtools/views/ErrorBoundary/ErrorBoundary.js", "packages/react-devtools-shared/src/errors/TimeoutError.js", "packages/react-devtools-shared/src/errors/UnknownHookError.js", "packages/react-devtools-shared/src/errors/UserError.js", "packages/react-devtools-shared/src/inspectedElementMutableSource.js"]
|
[React DevTools] Improve DevTools UI when Inspecting a Component that Throws an Error
|
In this [issue](https://github.com/facebook/react/issues/23373), when you navigate to [this app](https://next-rsc-notes.vercel.app/note/1646289027680) and inspect the sidebar in the components tab, you will get this error:
This is a user error. One of the components in the user's app thrown. However, the UI for this is confusing, because it seems like it's a DevTools error. We've gotten a lot of bug reports like this, and it would be good to differentiate between DevTools bugs and bugs in the app. For this task:
- [ ] Build the React DevTools extension locally (instructions [here](https://github.com/facebook/react/tree/main/packages/react-devtools-extensions)) and reproduce the error
- [ ] Figure out a way to have the front end be able to differentiate whether the error is a error within DevTools or within the user's app
- [ ] Design/implement a better UI to help app developers distinguish between these two cases
|
https://github.com/facebook/react/issues/24096
|
https://github.com/facebook/react/pull/24248
|
547b707493735327373a9f8792343f73a5b080da
|
e531a4a62d0b88301ac06d4efd3f5a30faa03c94
| 2022-03-14T19:02:35Z |
javascript
| 2022-05-06T00:17:23Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 24,032 |
["packages/react-dom/src/__tests__/ReactDOMFizzServerBrowser-test.js", "packages/react-server/src/ReactServerStreamConfigBrowser.js"]
|
renderToReadableStream Passes Reusable Chunks
|
https://github.com/cloudflare/miniflare/issues/203
We switched to using "bytes" streams but, by spec, chunks get transferred in that format. Totally reasonable. However, we pass reusable chunks which then get detached. I'm not sure why the polyfill or fixtures didn't catch this.
We really should be using the byob model instead and copy into a larger chunk for perf anyway so this just makes that more urgent.
|
https://github.com/facebook/react/issues/24032
|
https://github.com/facebook/react/pull/24034
|
14c2be8dac2d5482fda8a0906a31d239df8551fc
|
e09518e5bbb78447d6c86481cf0dcafb4b09c734
| 2022-03-04T20:49:02Z |
javascript
| 2022-03-07T18:34:11Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 23,373 |
["packages/react-devtools-shared/src/devtools/views/ErrorBoundary/ErrorBoundary.js"]
|
[DevTools Bug] Cannot read properties of undefined (reading 'split')
|
### Website or app
https://next-rsc-notes.vercel.app/
### Repro steps
1. enter the site
2. open react-devtools
3. select We(maybe suspense's child component)
4. and show following errors.
### How often does this bug happen?
Every time
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.23.0-e28a0db22
### Error message (automated)
Cannot read properties of undefined (reading 'split')
### Error call stack (automated)
```text
at getDerivedStateFromError (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37414:114)
at ErrorBoundary_ErrorBoundary.c.payload (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:16143:14)
at Gg (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:14571:47)
at Dj (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:16788:5)
at jl (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19204:86)
at il (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:18756:11)
at hl (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:18748:23)
at Wk (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:18732:5)
at al (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:18393:37)
at Uk (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:18314:51)
```
### Error component stack (automated)
```text
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37375:5)
at div
at InspectedElementErrorBoundaryWrapper (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37864:3)
at NativeStyleContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40513:3)
at div
at div
at OwnersListContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:33354:3)
at SettingsModalContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:35975:3)
at Components_Components (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:42520:52)
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37375:5)
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37518:3)
at PortaledContent (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37548:5)
at div
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37518:3)
at TimelineContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:42700:3)
at ProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:42146:3)
at TreeContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30256:3)
at SettingsContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30878:3)
at ModalDialogContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37927:3)
at DevTools_DevTools (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:53807:3)
```
### GitHub query string (automated)
```text
https://api.github.com/search/issues?q=Cannot read properties of undefined (reading 'split') in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
```
|
https://github.com/facebook/react/issues/23373
|
https://github.com/facebook/react/pull/24065
|
48a8574a68066be0385bd90c4a24e3e620eafb92
|
4a87fb52115ca26b2251bdcc94deeff841b66e52
| 2022-02-26T13:41:36Z |
javascript
| 2022-03-10T18:36:47Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 23,283 |
["packages/react-devtools-shared/src/__tests__/__snapshots__/profilingCache-test.js.snap", "packages/react-devtools-shared/src/__tests__/profilingCache-test.js", "packages/react-devtools-shared/src/backend/renderer.js"]
|
[DevTools Bug] Could not find node with id "18" in commit tree
|
### Website or app
https://github.com/ModelSaber/ModelSaber.Main
### Repro steps
Just try and load the 2/5 and 3/5 report from a reload and start profiling instance.
Change `REACT_APP_API_URL` to `https://apimodelsaber.rainemods.io` in order to launch the app without needing the full .NET 6 environment and the corresponding data in the postgres database.
### How often does this bug happen?
Every time
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.23.0-e28a0db22
### Error message (automated)
Could not find node with id "18" in commit tree
### Error call stack (automated)
```text
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:25574:13
at Map.forEach (<anonymous>)
at RankedChartBuilder_getChartData (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:25570:24)
at ProfilingCache_ProfilingCache.getRankedChartData (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:25686:11)
at CommitRankedAutoSizer (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:43680:32)
at gi (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:15400:7)
at zj (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:16741:7)
at jl (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19201:86)
at il (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:18756:11)
at hl (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:18748:23)
```
### Error component stack (automated)
```text
at CommitRankedAutoSizer (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:43659:34)
at div
at div
at div
at SettingsModalContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:35975:3)
at Profiler_Profiler (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:53276:34)
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37375:5)
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37518:3)
at PortaledContent (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37548:5)
at div
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37518:3)
at TimelineContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:42700:3)
at ProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:42146:3)
at TreeContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30256:3)
at SettingsContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30878:3)
at ModalDialogContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37927:3)
at DevTools_DevTools (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:53807:3)
```
### GitHub query string (automated)
```text
https://api.github.com/search/issues?q=Could not find node with id in commit tree in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
```
|
https://github.com/facebook/react/issues/23283
|
https://github.com/facebook/react/pull/24031
|
72a933d2892dac9e5327678b6bd37af8d589bb22
|
48a8574a68066be0385bd90c4a24e3e620eafb92
| 2022-02-12T23:29:52Z |
javascript
| 2022-03-10T18:35:52Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 23,089 |
["packages/react-dom/src/__tests__/ReactDOMFizzServerNode-test.js", "packages/react-server/src/ReactFizzNewContext.js"]
|
React 18: Context providers are reset to initial value in SSR during rendering
|
<!--
Ask a question or share feedback about the React 18 release here.
-->
While testing SSR streaming in latest React 18 experimental and alpha versions, [we noticed](https://github.com/Shopify/hydrogen/issues/415) that context providers are reset to their initial values during rendering under certain conditions.
It works well when handling 1 request at a time. However, when the server gets 2 or more requests at the same time, the context providers seem to get confused. The context is correct at the beginning of the rendering for each request but it gets lost after a while.
There's a reproduction here using @gaearon 's demo: https://codesandbox.io/s/keen-snowflake-8nyo8?file=/src/data.js:1035-1082
To my understanding, since the React tree is wrapped in a provider in SSR, `useContext` should never return `null` in the server. Have a look at the terminal and see how it actually logs `null` sometimes when getting multiple requests.
```
[0] This should never be null: { read: [Function: read] }
[0] This should never be null: { read: [Function: read] }
[0] This should never be null: null
[0] This should never be null: null
```
Run the following code from the console to simulate multiple requests:
```js
function doRequest() { return fetch('https://8nyo8.sse.codesandbox.io/', {headers: {accept:'text/html'}}).then(r => r.text()) }
await Promise.all([doRequest(), doRequest()])
```
We saw this same issue in different setups, using both Webpack and Vite.
Thanks!
|
https://github.com/facebook/react/issues/23089
|
https://github.com/facebook/react/pull/23171
|
e28a0db224e1c702cf63916eb39284325c439b8b
|
529dc3ce84f0efe99a8be33ff453c09d5801d5ca
| 2022-01-10T17:54:13Z |
javascript
| 2022-01-24T17:52:51Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 23,063 |
["packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js", "packages/react-dom/src/server/ReactDOMServerFormatConfig.js"]
|
React 18: bootstrapScriptContent escapes HTML so quotes can’t be used
|
If you use the `bootstrapScriptContent` option of `renderToPipeableStream()` to provide hydration data (as [recommended in the <script> upgrade guide](https://github.com/reactwg/react-18/discussions/114)) with `JSON.stringify()` it doesn’t work because React escapes HTML characters in `bootstrapScriptContent` like quotes. I’ve worked around this by using backticks to deliniate strings.
What’s the correct thing to do here?
https://github.com/facebook/react/blob/cdb8a1d19d0c0d43a72c3f0fe739b04da247c360/packages/react-dom/src/server/ReactDOMServerFormatConfig.js#L99-L105
|
https://github.com/facebook/react/issues/23063
|
https://github.com/facebook/react/pull/24385
|
726ba80298dad46b331aca1bcb71ca9b2004ed91
|
d40dc73cf903e8a12fd29e900df2406e7f611c5c
| 2022-01-03T20:36:40Z |
javascript
| 2022-04-16T17:47:46Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 23,041 |
["packages/react-dom/src/__tests__/DOMPropertyOperations-test.js", "packages/react-dom/src/client/DOMPropertyOperations.js"]
|
Bug: custom element properties can't accept functions
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
This was raised here: https://github.com/facebook/react/issues/11347#issuecomment-1002153792
I will open a PR to address this shortly. Please assign this bug to me.
React version: experimental
## Steps To Reproduce
1. Create a custom element with a property setter
2. Assign a function to that property
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example: https://jsfiddle.net/jarhar/df4k156b/
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
The function does not get passed to the custom element setter
## The expected behavior
The function gets passed to the custom element setter
|
https://github.com/facebook/react/issues/23041
|
https://github.com/facebook/react/pull/23042
|
9a7e6bf0d0cf08114b74c9fe45c06e60a5e496e4
|
a87adefecdff672d5261e93945c227ad72c5444c
| 2021-12-28T17:23:40Z |
javascript
| 2022-01-12T20:12:07Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,988 |
["scripts/rollup/wrappers.js"]
|
Bug: `@license` header in React 18 bundles contains `vundefined`
|
Can be checked on top of the files here:
- https://unpkg.com/[email protected]/cjs/react.development.js
- https://unpkg.com/[email protected]/cjs/react.development.js
I've wanted to fix this quickly... but it turns out that your whole build pipeline is a little bit convoluted so it ain't a 5 min fix. I could still work on this but I would need some pointers as to what is the preferred fix.
From what I understand - this broken version is read here:
https://github.com/facebook/react/blob/ceee524a8f45b97c5fa9861aec3f36161495d2e1/scripts/rollup/wrappers.js#L6
but the root package.json doesn't contain a version. It seems that scripts are updating "root" package.json here:
https://github.com/facebook/react/blob/ceee524a8f45b97c5fa9861aec3f36161495d2e1/scripts/release/utils.js#L231-L238
but this only happens for the temp dir created during the release as 2 scripts are using `copyRepoToTempDirectory`.
I think the scripts should be run in the context of those temp dirs and that could potentially fix the problem (maybe they already are but something else is broken? I didn't yet confirm this).
The additional problem is that this wouldn't fix the local `yarn build` as this doesn't update this root package.json version at all.
|
https://github.com/facebook/react/issues/22988
|
https://github.com/facebook/react/pull/23004
|
a4ead704ba1df8718d4866a23ac25e78f8ea901a
|
bd0a5dd6826ff7b3ab889ed0bd55dacc2f69a47e
| 2021-12-19T10:59:57Z |
javascript
| 2021-12-21T17:27:59Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,970 |
["packages/react-devtools-shared/src/__tests__/profilerStore-test.js", "packages/react-devtools-shared/src/backend/renderer.js"]
|
[DevTools Bug] Could not find ID for Fiber "App"
|
### Website or app
not public
### Repro steps
I have two code bases in a yarn workspaces linked monorepo. One is using react-three-fiber (the lib), and the other one is really thin wrapper around it with some simple UI, just couple of buttons. Both are using multiple (3) zustand stores.
### How often does this bug happen?
Every time
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.21.0-2f8f60ca8
### Error message (automated)
Could not find ID for Fiber "App"
### Error call stack (automated)
```text
at getFiberIDThrows (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/react_devtools_backend.js:5836:11)
at fiberToSerializedElement (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/react_devtools_backend.js:7543:11)
at inspectElementRaw (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/react_devtools_backend.js:7712:21)
at Object.inspectElement (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/react_devtools_backend.js:8004:38)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/react_devtools_backend.js:9837:56
at Bridge.emit (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/react_devtools_backend.js:4257:18)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/react_devtools_backend.js:10500:12
at listener (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/react_devtools_backend.js:11737:9)
```
### Error component stack (automated)
```text
at InspectedElementContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:38726:3)
at Suspense
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37092:5)
at div
at InspectedElementErrorBoundaryWrapper (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37572:3)
at NativeStyleContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40146:3)
at div
at div
at OwnersListContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:35254:3)
at SettingsModalContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:35695:3)
at Components_Components (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:42085:52)
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37092:5)
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37222:3)
at PortaledContent (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37256:5)
at div
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37222:3)
at SchedulingProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:43423:3)
at ProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:41711:3)
at TreeContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30116:3)
at SettingsContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30727:3)
at ModalDialogContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37635:3)
at DevTools_DevTools (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:53004:3)
```
### GitHub query string (automated)
```text
https://api.github.com/search/issues?q=Could not find ID for Fiber "App" in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
```
|
https://github.com/facebook/react/issues/22970
|
https://github.com/facebook/react/pull/23162
|
ca143e18d83dcc57d7133d8859e0fc06df39b9f0
|
13036bfbc8ecbcf4451adb7bde397f438caa8607
| 2021-12-15T20:20:58Z |
javascript
| 2022-01-21T16:05:49Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,959 |
["packages/react-devtools/package.json"]
|
react-devtools report Error: Cannot find module './app'
|
react-devtools version: 4.22.0
npm -g install react-devtools
react-devtools
```
internal/modules/cjs/loader.js:905
throw err;
^
Error: Cannot find module './app'
Require stack:
- /Users/foo/.nvm/versions/node/v14.18.1/lib/node_modules/react-devtools/bin.js
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
at Function.resolve (internal/modules/cjs/helpers.js:99:19)
at Object.<anonymous> (/Users/foo/.nvm/versions/node/v14.18.1/lib/node_modules/react-devtools/bin.js:32:46)
at Module._compile (internal/modules/cjs/loader.js:1085:14)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
at Module.load (internal/modules/cjs/loader.js:950:32)
at Function.Module._load (internal/modules/cjs/loader.js:790:12)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/Users/foo/.nvm/versions/node/v14.18.1/lib/node_modules/react-devtools/bin.js'
]
}
```
|
https://github.com/facebook/react/issues/22959
|
https://github.com/facebook/react/pull/22960
|
cd1a3e9b556ab1eb8009676a38857aae7585dc8b
|
3f45b681414a64c7034fab7f5e7bb4bb8df60f9c
| 2021-12-15T03:33:08Z |
javascript
| 2021-12-15T04:28:57Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,958 |
["packages/react-devtools-inline/webpack.config.js"]
|
[react-devtools-inline][4.22.0]: broken published package
|
## Steps To Reproduce
1. install `react-devtools-inline` in a project that has `react` and `react-is`
2. open node
3. `require('react-devtools-inline')`
4. See error:
```
Uncaught:
Error: Cannot find module '/Users/jstejada/code/jstejada-react/build/oss-experimental/react-is'
Require stack:
- /home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js
- <repl>
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Module.require (node:internal/modules/cjs/loader:1005:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object.14 (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:1344:18)
at __webpack_require__ (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:21:30)
at Object.3 (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:5710:17)
at __webpack_require__ (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:21:30)
at Object.10 (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:495:64)
at __webpack_require__ (/home/avi/projects/temp/inlinetest/node_modules/react-devtools-inline/dist/backend.js:21:30)
```
## The current behavior
Published package contains the following code:
```
module.exports = require("/Users/jstejada/code/jstejada-react/build/oss-experimental/react-is");
...
module.exports = require("/Users/jstejada/code/jstejada-react/build/oss-experimental/react");
```
## The expected behavior
No absolute paths in bundle. successful evaluation.
|
https://github.com/facebook/react/issues/22958
|
https://github.com/facebook/react/pull/22961
|
3f45b681414a64c7034fab7f5e7bb4bb8df60f9c
|
b10c3780246c82d4b9770309dec44070a2003ad8
| 2021-12-15T00:54:52Z |
javascript
| 2021-12-15T04:45:46Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,888 |
["packages/react-dom/src/__tests__/DOMPropertyOperations-test.js", "packages/react-dom/src/events/plugins/ChangeEventPlugin.js"]
|
Bug: `onChange` event handlers don't work on custom elements
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
Found here: https://github.com/facebook/react/issues/11347#issuecomment-989021700
React version: experimental
## Steps To Reproduce
1. `<my-custom-element onChange={() => console.log('onchange')} />`
2. `querySelector('my-custom-element').dispatchEvent('change')`
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example: https://codesandbox.io/s/shy-tdd-8b4tq?file=/src/App.js
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
`onChange` event handlers don't get called when `change` events are fired.
## The expected behavior
`onChange` event handlers do get called when `change` events are fired.
|
https://github.com/facebook/react/issues/22888
|
https://github.com/facebook/react/pull/22938
|
d8cfeaf221563f3828fe7bf07833f3824accfa39
|
05a55a4b09b7b7c8f63778fb8252a001ca66f8d7
| 2021-12-09T00:12:00Z |
javascript
| 2022-01-19T19:34:07Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,834 |
["packages/react-devtools-extensions/src/injectGlobalHook.js"]
|
[DevTools Bug]: CDN-based site not working
|
### Website or app
https://lcdev.shaped.ca
### Repro steps
Dev tools not working in FF or Chrome, says "This page doesn't appear to be using react".
React is included via CDN as shown on react website https://reactjs.org/docs/cdn-links.html:
``
<script crossorigin="anonymous" src="https://unpkg.com/react@17/umd/react.development.js"></script>
``
Web Console on said page says:
``
Download the React DevTools for a better development experience: https://reactjs.org/link/react-devtools
``
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
_No response_
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_
|
https://github.com/facebook/react/issues/22834
|
https://github.com/facebook/react/pull/22932
|
f2a59df48bec2352a4dd3b5415282a4ea240a4f8
|
2c1cf5618a24238136e3bd6139fb7f359dffe0f9
| 2021-11-26T00:52:17Z |
javascript
| 2021-12-09T20:32:11Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,796 |
["packages/react-reconciler/src/ReactFiberNewContext.js", "packages/react-reconciler/src/__tests__/ReactNewContext-test.js"]
|
React 18 Bug: react-dom/server "Detected multiple renderers..." if preceeded by react-test-renderer
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0-beta-149b420f6-20211119
## Steps To Reproduce
1. render a context with `react-test-renderer` (wrapped in act)
2. render the same context with `react-dom/server`
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example: https://codesandbox.io/s/react-18-react-test-renderer-react-dom-server-forked-lbs7j?file=/package.json:189-219
```js
const Context = React.createContext(null);
function Component({ renderer }) {
return (
<Context.Provider value={renderer}>
<div />
</Context.Provider>
);
}
let testRendererRoot;
ReactTestRenderer.act(() => {
testRendererRoot = ReactTestRenderer.create(
<Component renderer="react-test-renderer" />
);
});
ReactTestRenderer.act(() => {
testRendererRoot.unmount();
});
ReactDOMServer.renderToString(<Component renderer="react-dom/server" />);
```
## The current behavior
`renderToString` results in the console error "Warning: Detected multiple renderers concurrently rendering the same context provider. This is currently unsupported."
## The expected behavior
No error like in React 17 (https://codesandbox.io/s/react-17-react-test-renderer-react-dom-server-yr8gx).
Considering all renders are wrapped in their corresponding `act` I don't expect that I'm concurrently rendering.
I tried to understand when we reset the `rendererSigil` (responsible for checking if we "concurrently rendering") is reset and it seems like we never reset it but only initialize it when creating the context (`createContext`)
So it either seems like multiple renderers in the same module are not supported anymore or the reset is missing.
|
https://github.com/facebook/react/issues/22796
|
https://github.com/facebook/react/pull/22797
|
0fce6bb498357feb4465859912004b2e20fe7084
|
555ece0cd14779abd5a1fc50f71625f9ada42bef
| 2021-11-20T12:40:28Z |
javascript
| 2023-01-12T12:17:15Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,772 |
["packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js", "packages/react-server/src/ReactFizzServer.js", "packages/react-server/src/ReactFlightServer.js"]
|
React 18: "The stream is not in a state that permits close" in `renderToReadableStream`
|
When using `renderToReadableStream` for e.g. Cloudflare Workers runtimes, I'm noticing this error on the server:
```
TypeError: The stream is not in a state that permits close
at ReadableStreamDefaultController.close (/Users/joshlarson/src/github.com/jplhomer/vite-streaming-ssr-demo/node_modules/web-streams-polyfill/src/lib/readable-stream/default-controller.ts:72:13)
at Mc (/Users/joshlarson/src/github.com/jplhomer/vite-streaming-ssr-demo/dist/worker/worker.js:3636:145)
at Bc (/Users/joshlarson/src/github.com/jplhomer/vite-streaming-ssr-demo/dist/worker/worker.js:3457:33)
at ping (/Users/joshlarson/src/github.com/jplhomer/vite-streaming-ssr-demo/dist/worker/worker.js:3128:24)
GET / 200 OK (2091.13ms)
```
I'm assuming this results in the following malformed chunk being sent to the stream:
```
<div hidden id="<div hidden id="S:1">
```
Which results in the client failing:
```
Uncaught TypeError: Cannot read properties of null (reading 'parentNode')
at $RS (127.0.0.1/:11)
at 127.0.0.1/:11
```
I put together a reproduction here, powered by [Miniflare](https://miniflare.dev/) for the Workers runtime: https://github.com/jplhomer/vite-streaming-ssr-demo
## Possible issues
- Could this be related to the "fundamentally flawed" nature of Web Streams implementations in e.g. Cloudflare Workers runtime? https://github.com/reactwg/react-18/discussions/66#discussioncomment-944266
- Is something going on with corking/uncorking, as per https://github.com/reactwg/react-18/discussions/91
- Maybe something's wrong with Miniflare's polyfill and this is a non-issue, coming from `web-streams-polyfill`?
- Finally, it's possible something is wrong with the Vite version of the example I've put together. I could try rebuilding with webpack if it's determined none of these items apply.
|
https://github.com/facebook/react/issues/22772
|
https://github.com/facebook/react/pull/23342
|
1760b27c02b632594048183a93afc7881203a230
|
2c693b2dee6e0a644e9e952b5c2b64a1b21c8e55
| 2021-11-15T22:45:59Z |
javascript
| 2022-02-23T05:33:41Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,747 |
["packages/react-reconciler/src/SchedulingProfiler.js"]
|
Bug: markInternalModuleRanges undefined
|
Testing react 18 im getting this error
React version: https://unpkg.com/[email protected]/umd/react-dom.development.js
wants to add that in this version: https://unpkg.com/[email protected]/umd/react-dom.development.js no happens, so probably a recent change affected this
File Related: https://github.com/facebook/react/blob/1bf6deb865052111474f2988bb831de13d09c560/packages/react-reconciler/src/SchedulingProfiler.js
## Steps To Reproduce
cant reproduce this for the moment, happens randomly and had to downgrade the version
Link to code example:
cant reproduce it, happens randomly
## The current behavior
in some cases is undefined
## The expected behavior
should not be undefined
|
https://github.com/facebook/react/issues/22747
|
https://github.com/facebook/react/pull/22748
|
56efc65e5857abe22062c9506207abc35c9532d1
|
cb11155c86e756838a97679fb04c3256de101943
| 2021-11-12T07:37:28Z |
javascript
| 2021-11-12T15:03:41Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,705 |
["packages/react-devtools-timeline/src/CanvasPage.js", "packages/react-devtools-timeline/src/EventTooltip.js", "packages/react-devtools-timeline/src/constants.js", "packages/react-devtools-timeline/src/content-views/SnapshotsView.js", "packages/react-devtools-timeline/src/content-views/constants.js", "packages/react-devtools-timeline/src/import-worker/__tests__/preprocessData-test.internal.js", "packages/react-devtools-timeline/src/import-worker/preprocessData.js", "packages/react-devtools-timeline/src/types.js", "packages/react-devtools-timeline/src/view-base/View.js"]
|
Timeline screenshots are sometimes way too small (depending on aspect ratio)
|
For example:
<img width="1904" alt="Screen Shot 2021-11-05 at 11 59 05 AM" src="https://user-images.githubusercontent.com/29597/140540816-25d6d47b-7aea-4121-aeaa-565accc65b1f.png">
|
https://github.com/facebook/react/issues/22705
|
https://github.com/facebook/react/pull/22706
|
327d5c48454aaee0d78fa69b7ef96a14605bf93b
|
99a73ac670ce8d71ae8a690e9795d35cbdfa20b6
| 2021-11-05T15:59:49Z |
javascript
| 2021-11-08T17:28:33Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,673 |
["scripts/rollup/wrappers.js", "scripts/rollup/wrappers/registerInternalModuleBegin.js", "scripts/rollup/wrappers/registerInternalModuleEnd.js"]
|
Avoid duplicate boilerplate header
|
Follow up on @rickhanlonii's comment: https://github.com/facebook/react/pull/22670#issuecomment-956569098
|
https://github.com/facebook/react/issues/22673
|
https://github.com/facebook/react/pull/22688
|
1bf6deb865052111474f2988bb831de13d09c560
|
8ca3f567bc3ed56c2101e5c51f968a5339f63093
| 2021-11-01T21:47:08Z |
javascript
| 2021-11-04T14:40:35Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,646 |
[".circleci/config.yml", "scripts/circleci/run_devtools_e2e_tests.js"]
|
Add e2e tests for inline package
|
DevTools has good unit test coverage but no e2e test coverage. This is because the support for testing _extensions_ is pretty limited in e2e testing libraries. That being said, we could probably get 80% of the value of e2e testing leveraging our `react-devtools-inline` package.
We should create a few example tests (e.g. load hook names, select a component and edit props/state, etc) to see how viable this is.
For now, these tests should not block PRs from landing.
|
https://github.com/facebook/react/issues/22646
|
https://github.com/facebook/react/pull/23019
|
3dc41d8a2590768a6ac906cd1f4c11ca00417eee
|
9724e180045806480d7ef2a50e6a9d70fea98252
| 2021-10-28T15:38:19Z |
javascript
| 2022-01-04T15:28:03Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,613 |
["packages/react-devtools-scheduling-profiler/src/import-worker/__tests__/preprocessData-test.internal.js", "packages/react-devtools-scheduling-profiler/src/import-worker/preprocessData.js"]
|
Scheduling Profiler flags useDeferredValue / useTransition updates as expensive
|
This feature is meant to warn about sync priority updates that block paint (e.g. set state in layout effect) but it appears to also warn for transition priority updates. We should fix this.
|
https://github.com/facebook/react/issues/22613
|
https://github.com/facebook/react/pull/22614
|
0e8a5aff3ddf0f863839a924738f958fd940e3be
|
bfb40225b509dc65314f3fda95633090bf29ebf0
| 2021-10-21T17:44:39Z |
javascript
| 2021-10-21T19:16:26Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,591 |
["packages/react-devtools-extensions/src/main.js"]
|
[DevTools Bug]: Loading / parsing hook names is failing on v4.20
|
### Website or app
reactjs.org
### Repro steps
1. Open a website that uses React.
2. Inspect an element that uses Hooks.
3. Attempt to load hook names.
4. Loading hook names always fails:
|
https://github.com/facebook/react/issues/22591
|
https://github.com/facebook/react/pull/22590
|
02f411578a8e58af8ec28e385f6b0dcb768cdc41
|
fe0356ce2baa0b6569de6cbae6d54166bebb1fdb
| 2021-10-19T22:09:48Z |
javascript
| 2021-10-19T21:43:59Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,577 |
["packages/react-devtools-extensions/src/backend.js", "packages/react-devtools-extensions/src/contentScript.js", "packages/react-devtools-extensions/src/injectGlobalHook.js"]
|
[DevTools Bug]: Blank tools localhost only
|
### Website or app
google.com
### Repro steps
This started after last update 4.20.0
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
_No response_
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_
|
https://github.com/facebook/react/issues/22577
|
https://github.com/facebook/react/pull/22597
|
cdb8a1d19d0c0d43a72c3f0fe739b04da247c360
|
5ca4b0433205d01294b6306a3a90af1103e37dc9
| 2021-10-18T10:24:54Z |
javascript
| 2021-10-20T13:50:26Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,572 |
["packages/react-devtools-extensions/src/checkForDuplicateInstallations.js"]
|
[DevTools Bug]: Firefox and Edge show error in console about unrecognized installation on v4.20.0
|
### Website or app
reactjs.org
### Repro steps
1. Install React DevTools v4.20.0 in Firefox
2. Load reactjs.org in Firefox
3. Open Firefox DevTools
4. Observe error in console
### How often does this bug happen?
Every time
|
https://github.com/facebook/react/issues/22572
|
https://github.com/facebook/react/pull/22571
|
e5f486b5a82c58001e526ade72525434dc1afca9
|
b72dc8e9300f5ae997f7f5cfcd79b604cca3df0c
| 2021-10-15T20:09:41Z |
javascript
| 2021-10-15T21:18:20Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,570 |
["packages/react-devtools-core/package.json", "packages/react-devtools-extensions/chrome/manifest.json", "packages/react-devtools-extensions/edge/manifest.json", "packages/react-devtools-extensions/firefox/manifest.json", "packages/react-devtools-inline/package.json", "packages/react-devtools-scheduling-profiler/package.json", "packages/react-devtools/CHANGELOG.md", "packages/react-devtools/package.json"]
|
[DevTools Bug] Cannot add node "1" because a node with that id is already in the Store.
|
### Website or app
https://wayray.com/#how-we-work
### Repro steps
not able to see
### How often does this bug happen?
Sometimes
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.19.2-20ca9b565
### Error message (automated)
Cannot add node "1" because a node with that id is already in the Store.
### Error call stack (automated)
```text
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:25708:41
at bridge_Bridge.emit (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:23923:22)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:24083:12
at listener (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:52511:39)
```
### Error component stack (automated)
_No response_
### GitHub query string (automated)
```text
https://api.github.com/search/issues?q=Cannot add node because a node with that id is already in the Store. in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
```
|
https://github.com/facebook/react/issues/22570
|
https://github.com/facebook/react/pull/22605
|
5ca4b0433205d01294b6306a3a90af1103e37dc9
|
c213030b4966e935bb36c138e28761ea22dd837d
| 2021-10-15T19:16:38Z |
javascript
| 2021-10-20T20:00:13Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,486 |
["packages/react-devtools-extensions/src/background.js", "packages/react-devtools-extensions/src/checkForDuplicateInstallations.js", "packages/react-devtools-extensions/src/constants.js", "packages/react-devtools-extensions/src/main.js", "packages/react-devtools-shared/src/devtools/views/DevTools.js", "packages/react-devtools-shared/src/devtools/views/DuplicateInstallationDialog.js"]
|
Detect and warn if multiple copies of React DevTools are installed
|
If you have more than one copy of React DevTools installed and enabled (e.g. the version in the Chrome store and a locally built version) they can interfere with each other.
DevTools should detect this case and warn by showing a dialog in the DevTools UI and/or by logging to the console.
Note that we _should not warn_ if a related tool like Fast Refresh is present, only another copy of DevTools.
|
https://github.com/facebook/react/issues/22486
|
https://github.com/facebook/react/pull/22563
|
9d3d03025cf2474286ee5d9ba642f3ea9377a435
|
930c9e7eeb4c9721e1b8dee074c2eef4d1eae5dc
| 2021-10-01T20:41:13Z |
javascript
| 2021-10-15T15:27:13Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,459 |
["packages/react-dom/src/__tests__/ReactDOMSafariMicrotaskBug-test.js", "packages/react-reconciler/src/ReactFiberWorkLoop.new.js", "packages/react-reconciler/src/ReactFiberWorkLoop.old.js"]
|
Bug: setState updater called but not rendered, in Safari, in concurrent mode
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0-alpha-9175f4d15-20210928
## Steps To Reproduce
Minimal reproduction in [this codesandbox](https://codesandbox.io/s/black-moon-ymw10?file=/src/index.js).
This issue only appears in Safari, including mobile Safari. It works fine in Chrome and Firefox.
In order to reproduce, you'll need to:
0. Render the app with `createRoot` in the latest 18.0 alpha
1. Within an element's `ref` function, append an iframe to that element using `appendChild`
*The following steps have been removed after simplifying the reproduction:*
~~1. Make a state change originating in a message from a YouTube embed iframe. I assume the same issue would occur with messages from other cross domain iframes, although I have not tested this. The issue does *not* appear when making an async state change through `setTimeout`.~~
~~2. Render a tooltip using the "tippy.js" library. I haven't dug into what inside of Tippy is causing this, but commenting out the tippy element resolves the issue. I have confirmed that rendering a simple portal does *not* reproduce the issue.~~
Link to code example:
https://codesandbox.io/s/black-moon-ymw10?file=/src/index.js
## The current behavior
In the example in safari, the updater function passed to `setState` is run (confirmed with the "run state updater" console.log)... but the new state is never passed to the component function, leaving the app hanging with no error message, and displaying "not done".
## The expected behavior
In Chrome and Firefox, the App component updates after the state updater function is called, as expected, displaying "done".
---
Thanks for all the wonderful work on React, btw! It's been a lot of fun playing with the new concurrent React features. Can't wait to see them hit a stable release!
|
https://github.com/facebook/react/issues/22459
|
https://github.com/facebook/react/pull/23111
|
51947a14bb24bd151f76f6fc0acdbbc404de13f7
|
790b5246f691adafbf4b6a4b3fe2e6cc1370c43e
| 2021-09-29T08:43:19Z |
javascript
| 2022-01-18T18:25:34Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,441 |
["packages/shared/ReactComponentStackFrame.js", "scripts/jest/matchers/toThrow.js", "scripts/jest/setupTests.js", "scripts/jest/spec-equivalence-reporter/setupTests.js"]
|
Several tests fail on main with Node v16
|
I forked and cloned the repo this morning (at c88fb49d37fd01024e0a254a37b7810d107bdd1d), ran `yarn` and `yarn test`, and several tests failed.
React version: main (c88fb49d37fd01024e0a254a37b7810d107bdd1d)
## Steps To Reproduce
1. Clone repo
2. `yarn` and `yarn test`
I was on the latest NodeJS version (16.10.0). Note that tests pass for me when switching to the 14.x LTS release of Node.
## The current behavior
13 tests fail across 5 suites. Output at https://gist.github.com/josephsavona/91a3d48add8a1c47c71178522583281b
## The expected behavior
All tests pass
|
https://github.com/facebook/react/issues/22441
|
https://github.com/facebook/react/pull/22477
|
55d75005bc26aa41cddc090273f82aa106729fb8
|
c16b005f2d71acde26658f035ff491a5e027da39
| 2021-09-27T18:16:22Z |
javascript
| 2021-10-11T22:40:42Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,422 |
["packages/react-devtools-shared/src/__tests__/store-test.js", "packages/react-devtools-shared/src/backend/renderer.js", "packages/react-devtools-shared/src/utils.js"]
|
[DevTools Bug]: Emoji as visual helper produce strange symbole
|
### Website or app
https://codesandbox.io/s/react-playground-forked-j4niq
### Repro steps
Emoji seem supported but produce strange symbole
To test emoji on Window Os, use `[win]+[.]` 🟩
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
_No response_
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_
|
https://github.com/facebook/react/issues/22422
|
https://github.com/facebook/react/pull/22424
|
c88fb49d37fd01024e0a254a37b7810d107bdd1d
|
2e41568313620ab564425be7e5d777581e2db5d4
| 2021-09-24T20:15:48Z |
javascript
| 2021-09-27T17:34:39Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,293 |
["packages/react-devtools-shared/src/utils.js"]
|
Bug: Maximum call stack size exceeded (React Devtools)
|
I encountered the same issue as #20640 but using `react-devtools` as a stand-alone app instead of from the the browser.
The bottom line is that the profiler becomes unresponsive after any interaction with a heavily loaded react page.
React version:
* React: 17.0.2
* ReactDOM: 17.0.2
* React Devtools: 4.18.0
## Steps To Reproduce
1. Attach a react-devtools stand-alone (`yarn run react-devtools`) to a session
2. Start profiling
3. Do something on your app that would cause a huge number of updates
4. The profiler stops functioning
## Diagnostics
I actually went through and found out the origin of the issue, however I am not sure what would be the best approach to fix it.
It seems the the origin is a (very) big incoming message:
<img width="516" alt="image" src="https://user-images.githubusercontent.com/883486/132918559-c6a3dee1-1ddd-4647-ab06-2f19892b67b0.png">
That eventually causes a maximum call stack exceeded error:
<img width="522" alt="image" src="https://user-images.githubusercontent.com/883486/132918578-f02f3031-b84a-4a89-84cf-4dd4d70cef7f.png">
Coming from `util.js:128`:
```ts
export function utfDecodeString(array: Array<number>): string {
return String.fromCodePoint(...array);
}
```
And interestingly enough, doing spread operator with an array with 235124 elements actually causes a `Maximum call stack size exceeded` error 😄
I tried replacing the code above with the following replacement and it seems to work:
```ts
export function utfDecodeString(array: Array<number>): string {
return array.map(c => String.fromCodePoint(c)).join("")
}
```
|
https://github.com/facebook/react/issues/22293
|
https://github.com/facebook/react/pull/22330
|
b0803f255ba639aae5a6bd66d1234d12eb18d972
|
f2fd1b80d5501a0bce00641f383d18cbd24e3d32
| 2021-09-10T21:18:32Z |
javascript
| 2021-09-17T13:52:52Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,246 |
[".eslintrc.js", "package.json", "packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js", "packages/eslint-plugin-react-hooks/package.json", "packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js", "packages/eslint-plugin-react-hooks/src/RulesOfHooks.js", "yarn.lock"]
|
[eslint-plugin-react-hooks] Support ESLint 8.x
|
ESLint has released the first beta versions of v8 🎉
https://eslint.org/blog/2021/08/eslint-v8.0.0-beta.0-released
https://eslint.org/blog/2021/08/eslint-v8.0.0-beta.1-released
https://eslint.org/blog/2021/09/eslint-v8.0.0-beta.2-released
https://eslint.org/blog/2021/09/eslint-v8.0.0-rc.0-released
It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂
|
https://github.com/facebook/react/issues/22246
|
https://github.com/facebook/react/pull/22248
|
380284a2b4a1c431b197d7cac7bfaa7930ed102e
|
0c0d1ddae4be922f800705ae686fbb887184b38b
| 2021-09-04T17:10:00Z |
javascript
| 2021-09-06T19:17:51Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,241 |
["packages/react-devtools-shared/src/__tests__/inspectedElement-test.js", "packages/react-devtools-shared/src/backend/agent.js", "packages/react-devtools-shared/src/backend/legacy/renderer.js", "packages/react-devtools-shared/src/backend/renderer.js", "packages/react-devtools-shared/src/backend/types.js", "packages/react-devtools-shared/src/backendAPI.js", "packages/react-devtools-shared/src/bridge.js", "packages/react-devtools-shared/src/inspectedElementMutableSource.js"]
|
[DevTools Bug] Could not inspect element with id "219". Error thrown:Cached data for element "219" not found
|
### Website or app
employer-test.apna.co
### Repro steps
The error occurred at InspectedElementContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37563:3)
at Suspense
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36097:5)
at div
at InspectedElementErrorBoundaryWrapper (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36542:3)
at NativeStyleContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:38972:3)
at div
at div
at OwnersListContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:34323:3)
at SettingsModalContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:34764:3)
at Components_Components (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40911:52)
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36097:5)
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36215:3)
at PortaledContent (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36249:5)
at div
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36215:3)
at SchedulingProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:42093:3)
at ProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40537:3)
at TreeContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:29185:3)
at SettingsContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:29796:3)
at ModalDialogContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36605:3)
at DevTools_DevTools (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:51354:3)
### How often does this bug happen?
Often
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.18.0-f58bbcf9a
### Error message (automated)
Could not inspect element with id "219". Error thrown:Cached data for element "219" not found
### Error call stack (automated)
_No response_
### Error component stack (automated)
```text
at InspectedElementContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37563:3)
at Suspense
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36097:5)
at div
at InspectedElementErrorBoundaryWrapper (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36542:3)
at NativeStyleContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:38972:3)
at div
at div
at OwnersListContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:34323:3)
at SettingsModalContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:34764:3)
at Components_Components (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40911:52)
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36097:5)
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36215:3)
at PortaledContent (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36249:5)
at div
at div
at div
at ThemeProvider (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36215:3)
at SchedulingProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:42093:3)
at ProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:40537:3)
at TreeContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:29185:3)
at SettingsContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:29796:3)
at ModalDialogContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36605:3)
at DevTools_DevTools (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:51354:3)
```
### GitHub query string (automated)
```text
https://api.github.com/search/issues?q=Could not inspect element with id . Error thrown:
Cached data for element not found in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
```
|
https://github.com/facebook/react/issues/22241
|
https://github.com/facebook/react/pull/22472
|
7d38e4fd896911f7204165853236e1b7f2786a60
|
47177247f8c792fbb9a33328c913e246ff139a2d
| 2021-09-03T12:41:47Z |
javascript
| 2021-09-30T16:48:53Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,143 |
["packages/react-devtools-shared/src/__tests__/treeContext-test.js", "packages/react-devtools-shared/src/devtools/store.js"]
|
DevTools scroll-to error or warning feature broken
|
Not sure when this happened, but the feature got broken:
https://user-images.githubusercontent.com/29597/130155150-18fbca13-42d7-4d7d-831e-8db4a9672d94.mp4
Using the up/down arrows to navigate the list works fine, but jumping to the next/previous component with a warning or error doesn't quite work correctly. (The scroll offset is wrong so the component is often not visible.)
|
https://github.com/facebook/react/issues/22143
|
https://github.com/facebook/react/pull/22144
|
986d0e61d7085d4b8eea0386235d1b5ca9f47349
|
b6ff9ad1630b4f1d7cb98e9b9ec46bca315bb302
| 2021-08-19T23:04:36Z |
javascript
| 2021-08-20T15:55:42Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,115 |
["packages/react-devtools-extensions/src/main.js", "packages/react-devtools-extensions/webpack.config.js"]
|
DevTools: Better Bundle Names for Dynamically Imported Modules
|
In the DevTools extension, webpack currently uses an automatically assigned ID as the chunk name for dynamically imported modules (ie. `parseHookNames` and associated code will get bundled into `6.js`).
We've tried adding `chunkFilename: '[name].js'` to `output` in `webpack.config.js` and magic comments (ie.`/* webpackChunkName: "parseHookNames" */`) to the dynamic import to fix, but neither works.
|
https://github.com/facebook/react/issues/22115
|
https://github.com/facebook/react/pull/22322
|
f4ac680c7a1db67cae2659f531bb5531833f5c2f
|
e8feb11b62e869804970258fa629922edbfc836b
| 2021-08-17T20:46:42Z |
javascript
| 2021-09-15T17:51:33Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,113 |
["packages/react/src/forks/ReactSharedInternals.umd.js"]
|
react-dom@alpha UMD bundle throws when rendering
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 18.0.0-alpha-bd255700d-20210816 or main branch
## Steps To Reproduce
1. Use ReactDOM development from alpha version or main branch
2. Call ReactDOM.render() or ReactDOM.createRoot(...).render()
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example: https://jsfiddle.net/jarhar/sLz2f5q1/
If you open DevTools you can see the error which is preventing rendering. If you change the scripts from development.js to production.min.js, you can see the problem go away.
|
https://github.com/facebook/react/issues/22113
|
https://github.com/facebook/react/pull/22117
|
bd255700d73ed5fa88f9e32fa4b43623679adf0c
|
9eb2aaaf8181743481bdce955ab3b5e9bbacac90
| 2021-08-17T18:04:29Z |
javascript
| 2021-08-18T05:40:55Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 22,099 |
["packages/react-devtools-shared/src/__tests__/inspectedElement-test.js", "packages/react-devtools-shared/src/inspectedElementCache.js", "packages/react-devtools-shared/src/inspectedElementMutableSource.js", "packages/react-devtools-shared/src/types.js"]
|
[DevTools Bug] Could not inspect element with id "1335"
|
### Website or app
Web app we are developing for a client.
### Repro steps
Open the components tab - no components will display
Close the components tab
Open the components tab again, this time the the components show but the error shows on the right pane.
### How often does this bug happen?
Often
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.14.0-d0ec283819
### Error message (automated)
Could not inspect element with id "1335"
### Error call stack (automated)
_No response_
### Error component stack (automated)
```text
[email protected]:109842:43
Suspense
[email protected]:108452:5
div
[email protected]:108838:46
[email protected]:111206:38
div
div
[email protected]:106680:37
[email protected]:107121:40
[email protected]:113123:52
[email protected]:108452:5
[email protected]:108571:34
div
div
[email protected]:112748:35
[email protected]:103336:31
[email protected]:103939:35
[email protected]:108901:38
[email protected]:115897:27
```
### GitHub query string (automated)
```text
https://api.github.com/search/issues?q=Could not inspect element with id in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
```
|
https://github.com/facebook/react/issues/22099
|
https://github.com/facebook/react/pull/22160
|
bd5bf555e1167e7088a4391e5cd419dccb39714c
|
edfe50510b4129295cbe49f05d7b94bbfc48da5b
| 2021-08-16T14:53:28Z |
javascript
| 2021-08-23T23:22:31Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,986 |
["packages/react-devtools-scheduling-profiler/package.json", "packages/react-devtools-shared/package.json", "yarn.lock"]
|
[DevTools Bug]: Component tree size too small, components can't be selected
|
### Website or app
https://reactjs.org/
### Repro steps
1. Visit reactjs.org
2. Open devtools
3. Open "Components" tab
At first the component tree won't appear. Once I'm at the "Components" tab, I then have to also refresh the page to make the tree render. And when it does render, it still doesn't work properly.
As a note, this issue started happening after I had to forcibly restart my computer. Since then I have tried reinstalling the extension, restarting Chrome, restarting my pc, all of which haven't worked. I'd like to avoid reinstalling Chrome completely but that's the only thing I haven't yet tried. Using Windows 10, btw.
Here is what the broken component tree looks like. It's very narrow and the components cannot be selected:
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
_No response_
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_
|
https://github.com/facebook/react/issues/21986
|
https://github.com/facebook/react/pull/22083
|
82583617b7842008f537653ffb3fae4858213b00
|
e4e8226c625220944819c9237346569f09ad90a9
| 2021-07-29T05:13:14Z |
javascript
| 2021-08-13T00:41:56Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,972 |
["fixtures/dom/src/components/fixtures/media-events/index.js", "packages/react-dom/src/__tests__/ReactDOMEventListener-test.js", "packages/react-dom/src/__tests__/ReactDOMEventPropagation-test.js", "packages/react-dom/src/__tests__/__snapshots__/ReactTestUtils-test.js.snap", "packages/react-dom/src/events/DOMEventNames.js", "packages/react-dom/src/events/DOMEventProperties.js", "packages/react-dom/src/events/DOMPluginEventSystem.js", "packages/react-dom/src/events/ReactDOMEventListener.js", "packages/react-dom/src/events/TopLevelEventTypes.js", "packages/react-dom/src/test-utils/ReactTestUtils.js"]
|
Bug: `onResize` media event is missing
|
Note: I’m happy to make a pull request to fix this, I just wanted to log it first to ensure there’s interest.
---
React’s [synthetic media events](https://reactjs.org/docs/events.html#media-events) contain several [existing media events](https://html.spec.whatwg.org/multipage/media.html#mediaevents), for instance `onLoadedMetadata` and `onVolumeChange`. But there is no `onResize` handler.
[`resize` is a standard media event](https://html.spec.whatwg.org/multipage/media.html#event-media-resize) that triggers when one or both of the `videoWidth` and `videoHeight` attributes have just been updated. It’s useful for responding to resolution changes in video players.
React version: 17.0.2 (latest release as of initial issue report)
## Steps To Reproduce
1. Create a `<video>` element with an `onResize` prop.
2. Check the console for the following warning:
```
Warning: Unknown event handler property `onResize`. It will be ignored.
```
Link to code example: https://codesandbox.io/s/musing-snowflake-zb0qh?file=/src/App.js
## The current behavior
`onResize` handlers are ignored on `<video>` elements.
## The expected behavior
`onResize` handlers are valid on `<video>` elements.
|
https://github.com/facebook/react/issues/21972
|
https://github.com/facebook/react/pull/21973
|
2f156eafb83d129a729947ac2bd7089d20b208ab
|
fbce2d52749ff64a156c3f9cd6eb32715bb76e37
| 2021-07-27T18:34:14Z |
javascript
| 2021-09-07T22:28:19Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,939 |
["packages/react-devtools-shared/src/__tests__/profilingCharts-test.js", "packages/react-devtools-shared/src/__tests__/store-test.js", "packages/react-devtools-shared/src/backend/renderer.js", "packages/react-devtools-shared/src/utils.js"]
|
DevTools: Order of higher-order component badges
|
Given
```jsx
const StyleDiv = forwardRef(function Component({ children }, ref) {
return <div ref={ref}>{children}</div>;
});
StyleDiv.displayName = `styled(connected(div))`;
```
-- https://codesandbox.io/s/little-sky-y8h1b?file=/src/App.js
I would expect that the badges from the display name are prioritized in the component tree.
However, devtools currently displays the `ForwardRef` badge first:
> `div ForwardRef +2`
Oddly enough, the inline devtools in codesandbox do prioritize the badge from the `displayName` (maybe this regressed?):
> `div styled +2` 
There's also an argument to be made that devtools should not display the `ForwardRef` badge to begin with (since we explicitly omitted it in `displayName`). That can be discussed separately but would solve the issue entirely.
|
https://github.com/facebook/react/issues/21939
|
https://github.com/facebook/react/pull/21952
|
49f8254d6dec7c6de789116e20ffc5a9401aa725
|
b66936ece7d9ad41a33e077933c9af0bda8bff87
| 2021-07-22T09:48:55Z |
javascript
| 2022-07-25T07:02:12Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,876 |
["packages/react-reconciler/src/ReactFiberCommitWork.new.js", "packages/react-reconciler/src/ReactFiberCommitWork.old.js", "packages/react-reconciler/src/ReactFiberCompleteWork.new.js", "packages/react-reconciler/src/ReactFiberCompleteWork.old.js", "packages/react-reconciler/src/ReactFiberFlags.js", "packages/react-reconciler/src/__tests__/ReactSuspenseEffectsSemanticsDOM-test.js"]
|
[React 18] Bug: `Maximum update depth exceeded` on the `ref` prop when suspending
|
Functional `ref` prop throws a `Maximum update depth exceeded` error when suspending.
React version: `18.0.0-alpha-464f27572-20210713`
## Steps To Reproduce
1. Click on the `suspend` button: https://codesandbox.io/s/ref-set-too-many-times-jm0c3?file=/src/App.js.
## The current behavior
Clicking on the `suspend` button throws a `Maximum update depth exceeded` error.
## The expected behavior
Clicking on the `suspend` button suspends.
|
https://github.com/facebook/react/issues/21876
|
https://github.com/facebook/react/pull/21875
|
f0efb7b70f9c1570b35e71a7fcc6690684fe9d08
|
a97b5ac078499e33bbcf937935ab7139a317bac4
| 2021-07-14T11:58:30Z |
javascript
| 2021-07-14T17:37:10Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,855 |
["packages/react-devtools-extensions/firefox/manifest.json", "packages/react-devtools-extensions/package.json", "packages/react-devtools-extensions/src/__tests__/parseHookNames-test.js", "packages/react-devtools-extensions/src/parseHookNames/index.js", "packages/react-devtools-extensions/src/parseHookNames/parseHookNames.js", "packages/react-devtools-extensions/src/parseHookNames/parseHookNames.worker.js", "packages/react-devtools-extensions/webpack.config.js", "packages/react-devtools-shared/src/hookNamesCache.js", "yarn.lock"]
|
[DevTools] Parse named source AST in a worker
|
Hooks are the preferred way for writing stateful React components, but there are a few things about them that still lag behind the class component API: inspecting state in DevTools (since hooks aren’t “named”). Even now that this feature has been released, it remains disabled by default because the size of DEV bundles in larger apps (e.g. Facebook) makes parsing the AST very slow.
To alleviate this, we plan to provide an additional compilation tool that adds hook names to an extended source map during build time (#21782). However not every application will use this and so DevTools will still need to fall back to parsing source into an AST.
Currently this is done using the '@babel/parser' package on the main thread:
https://github.com/facebook/react/blob/c2c6ea1fdead7a33a33664675365b1575315276e/packages/react-devtools-extensions/src/parseHookNames.js#L536-L540
It would be nice to move this into a worker so that DevTools remains responsive even when parsing large sources.
---
One downside of using a worker for this is that serializing data to share between the worker and main thread (e.g. the source code string or the AST itself) could be expensive. This change will probably also require redesigning the boundaries a bit to reduce the number and size of things passed between boundaries. For example, the main thread could pass the URL of the source code to the worker, which could fetch and parse the file. Then the main thread could pass line/column information and the worker could return a hook name (or null). The goal would be to avoid having to serialize large AST structures.
|
https://github.com/facebook/react/issues/21855
|
https://github.com/facebook/react/pull/21902
|
9ab90de602357407fb03a27715b61761a258a8c4
|
25f09e3e4e900fc5d510243ce9ed3272d0af59e7
| 2021-07-12T21:04:01Z |
javascript
| 2021-07-21T16:16:08Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,834 |
["packages/react-devtools-extensions/src/__tests__/__source__/__untransformed__/ComponentWithExternalUseEffect.js", "packages/react-devtools-extensions/src/__tests__/__source__/__untransformed__/useCustom.js", "packages/react-devtools-extensions/src/__tests__/parseHookNames-test.js", "packages/react-devtools-extensions/src/astUtils.js", "packages/react-devtools-extensions/src/parseHookNames.js"]
|
[DevTools] Skip loading and parsing source for unnamed built-in hooks
|
Hooks like `useEffect` or `useLayoutEffect` will _never_ have names, so if a the only hooks for a given source file are these "unnamed" built-in hooks, we should skip loading the source code.
|
https://github.com/facebook/react/issues/21834
|
https://github.com/facebook/react/pull/21835
|
f52b73f9d0a9adbdb2815af440b2edd6b5627ff0
|
32d88d4332d6c2b32c9ea58a60e2a56d833fc1ad
| 2021-07-08T20:11:17Z |
javascript
| 2021-07-08T20:46:17Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,822 |
["packages/react-devtools-extensions/src/parseHookNames.js", "packages/react-devtools-shared/src/devtools/views/Components/InspectedElementContext.js", "packages/react-devtools-shared/src/devtools/views/Components/InspectedElementHooksTree.js", "packages/react-devtools-shared/src/hookNamesCache.js", "packages/react-devtools-shared/src/types.js"]
|
[DevTools] Make sure named hooks Suspense cache is persisting between elements
|
It currently looks like the `map.get(element)` returns `undefined` even for previously-loaded elements. Are we evicting from the cache prematurely? Why?
Our second level caching (inside of `parseHookNames`) is working but this is still resulting in a lot of unnecessary work.
|
https://github.com/facebook/react/issues/21822
|
https://github.com/facebook/react/pull/21831
|
241485a2c4db75f42baf62c68f54e7cdef101c31
|
feb2f6892ab42a6efc1333bbf1544b7337e8f244
| 2021-07-07T22:19:13Z |
javascript
| 2021-07-08T17:54:16Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,819 |
["packages/react-devtools-shared/src/devtools/views/Components/InspectedElementContext.js", "packages/react-devtools-shared/src/devtools/views/Components/InspectedElementErrorBoundary.js", "packages/react-devtools-shared/src/devtools/views/ErrorBoundary/ErrorBoundary.js", "packages/react-devtools-shared/src/inspectedElementCache.js"]
|
[DevTools] Improve "retry" function for inspected component props/state/hooks
|
Currently if an error occurs when inspecting a component, an error overlay is shown in the right hand side of DevTools along with a "dismiss" button to allow the inspection to be retried. However, currently this "retry" does not clear the entry from the cache and so it will immediately fail again if the same component is re-selected. We should clear the cache entry so that we actually retry when the modal is dismissed
|
https://github.com/facebook/react/issues/21819
|
https://github.com/facebook/react/pull/21821
|
feb2f6892ab42a6efc1333bbf1544b7337e8f244
|
92f3414d03d8744c420e15e55d7dc832deb2fa53
| 2021-07-07T19:27:38Z |
javascript
| 2021-07-08T18:07:15Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,818 |
["packages/react-devtools-extensions/src/parseHookNames.js", "packages/react-devtools-shared/src/devtools/views/Components/InspectedElementContext.js", "packages/react-devtools-shared/src/devtools/views/Components/InspectedElementHooksTree.js", "packages/react-devtools-shared/src/hookNamesCache.js", "packages/react-devtools-shared/src/types.js"]
|
[DevTools] Named hooks transient errors
|
Sometimes named hooks inspection will seemingly fail the first time then work the second time. (e.g. using a DEV build of Facebook.com, the `<CometTheme>` component currently does this).
I _think_ this might indicate a timeout during inspection? (So the retry is fast because everything is cached.)
|
https://github.com/facebook/react/issues/21818
|
https://github.com/facebook/react/pull/21831
|
241485a2c4db75f42baf62c68f54e7cdef101c31
|
feb2f6892ab42a6efc1333bbf1544b7337e8f244
| 2021-07-07T19:24:33Z |
javascript
| 2021-07-08T17:54:16Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,817 |
["packages/react-devtools-shared/src/devtools/views/Components/InspectedElementContext.js", "packages/react-devtools-shared/src/devtools/views/Components/InspectedElementHooksTree.css", "packages/react-devtools-shared/src/devtools/views/Components/InspectedElementHooksTree.js"]
|
[DevTools] Named hooks error badge
|
The named hooks cache returns `Array<string | null> | null` The first (mixed array of string and null) indicates an overall success, even if some names couldn't be inferred. The second indicates an error (e.g. couldn't locate or load source map).
In the event of the 2nd response type, the UI currently does nothing (falls back to default) but we _should_ show an error badge (maybe a disabled but red icon with a tooltip saying there was an error) since it's a confusing user experience to just do nothing.
|
https://github.com/facebook/react/issues/21817
|
https://github.com/facebook/react/pull/21820
|
9ccc25a0ea322b39ea04f8dfc03620ea90e0da94
|
8b34d5a905a17e95b5b9b515b60acbb2370f3603
| 2021-07-07T19:23:34Z |
javascript
| 2021-07-07T20:27:39Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,811 |
["packages/react-devtools-extensions/src/parseHookNames.js", "packages/react-devtools-shared/src/backend/renderer.js", "packages/react-devtools-shared/src/hydration.js"]
|
[DevTools] Don't serialize hook source fileNames (URLs)
|
This can cause long file names (URLs) to be truncated which in turn will break named hooks code (since it needs to load those file names).
|
https://github.com/facebook/react/issues/21811
|
https://github.com/facebook/react/pull/21814
|
9c7f29ebe75a7546e59038123d3b0c3515bec916
|
42b3c89c57a6b7027a6599785d63f47f809fda26
| 2021-07-07T15:18:56Z |
javascript
| 2021-07-07T18:24:17Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,793 |
["packages/react-devtools-extensions/src/parseHookNames.js"]
|
[DevTools] Support Flow syntax for named hooks parsing
|
DevTools tells Babel to parse the source code using "jsx" and "typescript" plug-ins:
https://github.com/facebook/react/blob/ed6c091fe961a3b95e956ebcefe8f152177b1fb7/packages/react-devtools-extensions/src/parseHookNames.js#L446-L462
This will work for some simple usages of Flow, but syntax may diverge and cause the parsing to fail.
Let's scan the source code for a `@flow` pragma and pass "flow" instead of "typescript" if one is found.
---
We should also add tests for both Flow and TypeScript to the test component pool:
https://github.com/facebook/react/tree/main/packages/react-devtools-extensions/src/__tests__/__source__
|
https://github.com/facebook/react/issues/21793
|
https://github.com/facebook/react/pull/21815
|
42b3c89c57a6b7027a6599785d63f47f809fda26
|
b6258b05f4ea16776557bc370ee0892604504d8f
| 2021-07-02T14:41:32Z |
javascript
| 2021-07-07T18:29:41Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,792 |
["packages/react-devtools-extensions/src/astUtils.js", "packages/react-devtools-extensions/src/parseHookNames.js"]
|
[DevTools] Use line number and column number to match hook
|
DevTools named hook parsing logic currently matches AST nodes using the original line number:
https://github.com/facebook/react/blob/ed6c091fe961a3b95e956ebcefe8f152177b1fb7/packages/react-devtools-extensions/src/parseHookNames.js#L341-L346
But this may not be sufficient, as mentioned in comment https://github.com/facebook/react/pull/21641#discussion_r662951987:
> Are we assuming that a line number is sufficient to identify a hook call? Seems like that assumption breaks down in edge cases:
>
> 1. Minified code (either without a source map, or a bundle *built* from pre-minified inputs) can have multiple hooks on one line.
> 2. Some code might be authored with quirky formatting, i.e. not with a typical Prettier / ESLint setup.
|
https://github.com/facebook/react/issues/21792
|
https://github.com/facebook/react/pull/21865
|
464f275724ab11e3b55ea753bc4aee6700399332
|
64bbd7a7f1b7874ffcbfc69fa87be4f606e5adc5
| 2021-07-02T14:38:02Z |
javascript
| 2021-07-13T17:28:01Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,765 |
["packages/react-dom/src/__tests__/ReactTestUtilsAct-test.js", "packages/react-reconciler/src/ReactFiberWorkLoop.new.js", "packages/react-reconciler/src/ReactFiberWorkLoop.old.js"]
|
React 18: "missing act()" warnings partially missing if a prior render threw
|
Specifically `An update to * inside a test was not wrapped in act(...)` is not logged when a prior update threw.
<details>
<summary>failing test (#21766)</summary>
```js
// @gate __DEV__
it('warns if a setState is called outside of act(...) after a component threw', () => {
let setValue = null;
function App({defaultValue}) {
if (defaultValue === undefined) {
throw new Error();
}
const [value, _setValue] = React.useState(defaultValue);
setValue = _setValue;
return value;
}
expect(() => {
act(() => {
render(<App defaultValue={undefined} />, container);
});
}).toThrow();
act(() => {
rerender(<App defaultValue={0} />, container);
});
expect(() => setValue(1)).toErrorDev([
'An update to App inside a test was not wrapped in act(...).',
]);
});
```
</details>
What I noticed is that in https://github.com/facebook/react/blob/27c9c95e23ddedb9163373950e364dd62038f6c0/packages/react-reconciler/src/ReactFiberWorkLoop.new.js#L2855-L2865
the `executionContext` will still equal `RetryAfterError` when we would expect a "missing act" warning.
"missing act" warnings are working as expected with legacy roots.
|
https://github.com/facebook/react/issues/21765
|
https://github.com/facebook/react/pull/21766
|
9fec3f2adde00614c562f23feb74948e47aaafb6
|
9090257e6edec44a09a4cd5723d1d0f7ce2ab7c4
| 2021-06-29T12:50:36Z |
javascript
| 2021-07-13T21:38:25Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,736 |
["packages/react-devtools-shared/src/__tests__/__snapshots__/profilingCache-test.js.snap", "packages/react-devtools-shared/src/__tests__/profilingCache-test.js", "packages/react-devtools-shared/src/backend/renderer.js", "packages/react-devtools-shell/src/app/InspectableElements/Contexts.js"]
|
[DevTools]: Show which context(s) changed for function components
|
`getContextChangedKeys` only handles class components:
https://github.com/facebook/react/blob/355591add41c0f6dad738fdb1b6603e0786b7b4e/packages/react-devtools-shared/src/backend/renderer.js#L1276-L1304
|
https://github.com/facebook/react/issues/21736
|
https://github.com/facebook/react/pull/22047
|
5634ed16aaba4a507844f0502953abcf40e3a165
|
da627ded867c882290776b4477250b6b312b77b4
| 2021-06-23T18:54:52Z |
javascript
| 2021-08-10T18:16:54Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,718 |
["packages/react-devtools-shared/src/devtools/views/Settings/SettingsModal.css", "packages/react-devtools-shared/src/devtools/views/TabBar.css"]
|
[DevTools Bug]: Settings panel layout broken
|
### Website or app
https://www.enexis.nl/
### Repro steps
Website is actually irrelevant, but required.
1. Open the devtools
2. Press the settings button.
3. Observe the layout being broken (causing horizontal scrollbar).
Screenshot
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
_No response_
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_
|
https://github.com/facebook/react/issues/21718
|
https://github.com/facebook/react/pull/21747
|
7fec38041faf7f4691f503feccbaf5af901367e2
|
386e8f2ea7209121b89159dbfbca53f70e87e1fb
| 2021-06-22T09:42:35Z |
javascript
| 2021-06-24T15:19:57Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,712 |
["packages/react-dom/src/__tests__/ReactDOMConsoleErrorReporting-test.js", "packages/react-reconciler/src/ReactFiberCommitWork.new.js", "packages/react-reconciler/src/ReactFiberCommitWork.old.js"]
|
React 18: Error boundaries actually catches errors in effects
|
Given
```js
function ThrowInEffect() {
React.useEffect(() => {
throw new Error('passive effect')
}, [])
return null;
}
```
In React 17 this error got logged to the console (and triggered the error overlay in create-react-app) regardless of whether `ThrowInEffect` was a child of an Error Boundary or not.
In React 18 (`createRoot` and legacy root API) an Error Boundary will prevent logging that error to the console (and not trigger the error overlay in create-react-app).
Errors during render work like they did in React 17.
Behavior in React 17: https://codesandbox.io/s/react-17-error-boundaries-vp21e?file=/src/index.js
Behavior in React 18: https://codesandbox.io/s/react-18-error-boundaries-psd56?file=/src/index.js
Recording of effect errors in React 17 and 18 and with and without Error Boundaries_
https://user-images.githubusercontent.com/12292047/122749780-053ced00-d28e-11eb-98ce-075dcdc53ee2.mp4
|
https://github.com/facebook/react/issues/21712
|
https://github.com/facebook/react/pull/21723
|
27c9c95e23ddedb9163373950e364dd62038f6c0
|
7fec38041faf7f4691f503feccbaf5af901367e2
| 2021-06-21T10:43:39Z |
javascript
| 2021-06-24T14:48:28Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,676 |
["packages/react-reconciler/src/ReactFiberCommitWork.new.js", "packages/react-reconciler/src/ReactFiberCommitWork.old.js", "packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js"]
|
Bug: Layout effects don't re-fire in 18 on Suspense re-showing
|
Intended behavior: https://github.com/reactwg/react-18/discussions/31
Sandbox: https://codesandbox.io/s/react-18-layouteffect-semantics-forked-m02w5
Expected: when suspended content is hidden and then shown, we get layout cleanup followed by layout setup.
Actual: only layout cleanup happens.
|
https://github.com/facebook/react/issues/21676
|
https://github.com/facebook/react/pull/21694
|
bd0a963445715f2963d4a9e3a0485e56cbe60653
|
d0f348dc1b1ab1c3f7377f918d8ffd3fa64c6918
| 2021-06-14T15:19:13Z |
javascript
| 2021-06-16T23:44:44Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,558 |
["packages/react-dom/src/__tests__/ReactFunctionComponent-test.js", "packages/react-reconciler/src/ReactFiber.new.js", "packages/react-reconciler/src/ReactFiber.old.js", "packages/react-reconciler/src/ReactFiberBeginWork.new.js", "packages/react-reconciler/src/ReactFiberBeginWork.old.js", "packages/react-reconciler/src/ReactInternalTypes.js"]
|
Remove _debugID field from Fiber
|
This DEV-only field was added in 836331ba5f69f2cc53b273ec073fae116db14302 by @sebmarkbage but it's not being used anymore to my knowledge.
|
https://github.com/facebook/react/issues/21558
|
https://github.com/facebook/react/pull/21570
|
bb1c8215569f59b70276e8939bd8a59aa7f28f53
|
0d493dcda96fc86242cf9a05a44130978a56fbdd
| 2021-05-25T15:10:11Z |
javascript
| 2021-05-26T20:53:18Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,541 |
[".github/workflows/devtools_check_repro.yml"]
|
Create GitHub actions to auto verify DevTools issues have repro steps
|
Many of the issues created with the with the [`devtools_bug_report.yml`](https://github.com/facebook/react/blob/master/.github/ISSUE_TEMPLATE/devtools_bug_report.yml) template are missing repro information (e.g. a "localhost" or otherwise invalid URL, missing or no repro description). I usually have to review, label, comment, and close this by hand.
It would be nice if we had an automated action that checked:
* Was the issue made with the [`devtools_bug_report.yml`](https://github.com/facebook/react/blob/master/.github/ISSUE_TEMPLATE/devtools_bug_report.yml) template?
* Does the URL section have an invalid URL (e.g. "localhost" or "company website")
* Does the repro steps section have invalid steps (e.g. "don't know")
For issues that pass all of the above text, the bot should:
* Assign the "Resolution: Needs More Information" label
* Close the issue
* Leave a comment explaining that repro information was missing and that we'll re-open it if information is provided
|
https://github.com/facebook/react/issues/21541
|
https://github.com/facebook/react/pull/21542
|
51ebccc37482f84e41417ef2917b0e4e44cc7465
|
a731a51696239a69a6cd89cdd34f23ce2fc39099
| 2021-05-20T20:51:10Z |
javascript
| 2021-05-21T19:48:12Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,528 |
["packages/react-devtools-shared/src/__tests__/inspectedElement-test.js", "packages/react-devtools-shared/src/backend/renderer.js"]
|
[DevTools Bug]: Fast Refresh + DevTools breaks component inspection
|
### Website or app
https://github.com/eps1lon/react-devtools-repro-no-matching-node/
### Repro steps
1. `yarn start`
2. Open `App.js`
3. Uncomment the `useEffect` block
4. Click to inspect "Component" in DevTools
5. Error: "_Could not inspect element with id 5_"
Originally reported in https://github.com/facebook/react/issues/21436#issuecomment-835406075
---
https://user-images.githubusercontent.com/12292047/117544707-e6a6cd80-b022-11eb-9f8f-bb8cfd9f7743.mp4
### How often does this bug happen?
Every time
|
https://github.com/facebook/react/issues/21528
|
https://github.com/facebook/react/pull/21536
|
ebcec3cc20417528ffe80f0b11701af42b399939
|
b8bbb6a13d0d0fc93bd1bf51bd66d626aad84672
| 2021-05-19T15:50:20Z |
javascript
| 2021-05-20T15:24:08Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,522 |
["packages/react-devtools-shared/src/__tests__/profilerStore-test.js", "packages/react-devtools-shared/src/backend/renderer.js"]
|
[DevTools Error] Cannot remove node "771" because no matching node was found in the Store.
|
### Website or app
https://soshace.com/react-user-login-authentication-using-usecontext-and-usereducer/
### Repro steps
I'm using a context to manage app global state like in [Website](https://soshace.com/react-user-login-authentication-using-usecontext-and-usereducer/) when get that error
### How often does this bug happen?
Every time
### DevTools package (automated)
react-devtools-extensions
### DevTools version (automated)
4.13.2-e468072e17
### Error message (automated)
Cannot remove node "771" because no matching node was found in the Store.
### Error call stack (automated)
```text
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:21477:43
at bridge_Bridge.emit (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19585:22)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19745:12
at listener (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37733:39)
```
### Error component stack (automated)
_No response_
### GitHub query string (automated)
```text
https://api.github.com/search/issues?q=Cannot remove node because no matching node was found in the Store. in:title is:issue is:open is:public label:"Component: Developer Tools" repo:facebook/react
```
|
https://github.com/facebook/react/issues/21522
|
https://github.com/facebook/react/pull/21524
|
343776fc9071f9e8c8a1dee0166c033bf381f04d
|
b15bf2b2f1effb6f760effac9f48c5901622f27b
| 2021-05-18T16:52:46Z |
javascript
| 2021-05-18T20:43:33Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,518 |
["packages/react-devtools-shared/src/__tests__/utils-test.js", "packages/react-devtools-shared/src/backend/utils.js"]
|
[DevTools Bug]: console.log throws type error if one of the arguments is symbol
|
### Website or app
https://github.com/facebook/react/blob/0e100ed00fb52cfd107db1d1081ef18fe4b9167f/packages/react-devtools-shared/src/backend/utils.js#L199
### Repro steps
This function will throw this error if one of the arguments is type of `symbol`.
The error is swallowed [here](https://github.com/facebook/react/blob/22ab39be681251f1c0f257af7e636cb8debf31c4/packages/react-devtools-shared/src/backend/console.js#L194-L196) but it does interfere with debugging. When I run with the "pause on caught exceptions" I get trapped here all the time.
Can we change
```js
if (args.length) {
formatted += ' ' + args.join(' ');
} // update escaped %% values
```
into
```js
for (let i = 0; i < args.length; i++) {
formatted += ' ' + String(args[i]);
} // update escaped %% values
```
???
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
4.13.2-e468072e17
### Error message (automated)
TypeError: Cannot convert a Symbol value to a string
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_
|
https://github.com/facebook/react/issues/21518
|
https://github.com/facebook/react/pull/21521
|
1e3383a41154cb32d8d6b78b2451ee4dabfcb973
|
63927e08438e8a52b41840bd583a07b3ceb2956e
| 2021-05-18T08:09:22Z |
javascript
| 2021-05-18T15:46:04Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,469 |
["packages/react-devtools-shared/src/__tests__/FastRefreshDevToolsIntegration-test.js", "packages/react-devtools-shared/src/__tests__/__snapshots__/profilingCache-test.js.snap", "packages/react-devtools-shared/src/__tests__/__snapshots__/profilingCommitTreeBuilder-test.js.snap", "packages/react-devtools-shared/src/backend/renderer.js"]
|
[DevTools Bug]: Children list grows indefinitely when adding/removing useEffect
|
### Website or app
Please checkout the linked branch not `main`
https://github.com/eps1lon/react-devtools-repro-no-matching-node/tree/repro/elements-leaking
Repro steps and screen recording included in the repro
### Repro steps
1. Clone repro
1. yarn
1. yarn start
1. Open app page
1. open devtools
1. Uncomment the `useEffect` block i.e. add an effect
1. inspect `Component` element
1. comment `useEffect` block i.e. remove the effect
1. Repeat comment/uncomment to see that children grow indefinitely
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
Could not inspect element with id 4
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_
Might be a duplicate of https://github.com/facebook/react/issues/21436#issuecomment-835406075 since the repro steps are the same. But depending on what the effect is doing, the behavior is different.
|
https://github.com/facebook/react/issues/21469
|
https://github.com/facebook/react/pull/21516
|
7bef382bf92e380f2b94e825cf35b8af58f8a2ec
|
1e3383a41154cb32d8d6b78b2451ee4dabfcb973
| 2021-05-08T15:43:14Z |
javascript
| 2021-05-18T15:42:08Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,445 |
["packages/react-devtools-shared/src/__tests__/store-test.js", "packages/react-devtools-shared/src/backend/renderer.js"]
|
Error: "Cannot add child "18903" to parent "18774" because parent node was not found in the Store."
|
<!-- Please answer both questions below before submitting this issue. -->
### Which website or app were you using when the bug happened?
Please provide a link to the URL of the website (if it is public), a CodeSandbox (https://codesandbox.io/s/new) example that reproduces the bug, or a project on GitHub that we can checkout and run locally.
### What were you doing on the website or app when the bug happened?
If possible, please describe how to reproduce this bug on the website or app mentioned above:
1. <!-- FILL THIS IN -->
2. <!-- FILL THIS IN -->
3. <!-- FILL THIS IN -->
<!--------------------------------------------------->
<!-- Please do not remove the text below this line -->
<!--------------------------------------------------->
### Generated information
DevTools version: 4.13.1-93782cfed2
Call stack:
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:21447:43
at bridge_Bridge.emit (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19607:22)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19767:12
at listener (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37788:39)
Component stack:
(none)
GitHub URL search query:
https://api.github.com/search/issues?q=Cannot%20add%20child%20%20to%20parent%20%20because%20parent%20node%20was%20not%20found%20in%20the%20Store.%20in%3Atitle%20is%3Aissue%20is%3Aopen%20is%3Apublic%20label%3A%22Component%3A%20Developer%20Tools%22%20repo%3Afacebook%2Freact
|
https://github.com/facebook/react/issues/21445
|
https://github.com/facebook/react/pull/21562
|
2d8d133e1756ea50a48e615db0c22870e92f4af6
|
965fb8be6b9e59d6552231039f3d8c1ff20d2793
| 2021-05-06T12:06:15Z |
javascript
| 2021-05-25T18:49:05Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,442 |
["packages/react-devtools-shared/src/__tests__/FastRefreshDevToolsIntegration-test.js", "packages/react-devtools-shared/src/__tests__/__snapshots__/profilingCache-test.js.snap", "packages/react-devtools-shared/src/__tests__/__snapshots__/profilingCommitTreeBuilder-test.js.snap", "packages/react-devtools-shared/src/backend/renderer.js"]
|
Error: "Cannot remove node "2626" because no matching node was found in the Store."
|
<!-- Please answer both questions below before submitting this issue. -->
### Which website or app were you using when the bug happened?
Please provide a link to the URL of the website (if it is public), a CodeSandbox (https://codesandbox.io/s/new) example that reproduces the bug, or a project on GitHub that we can checkout and run locally.
### What were you doing on the website or app when the bug happened?
If possible, please describe how to reproduce this bug on the website or app mentioned above:
1. <!-- FILL THIS IN -->
2. <!-- FILL THIS IN -->
3. <!-- FILL THIS IN -->
<!--------------------------------------------------->
<!-- Please do not remove the text below this line -->
<!--------------------------------------------------->
### Generated information
DevTools version: 4.13.1-93782cfed2
Call stack:
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:21499:43
at bridge_Bridge.emit (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19607:22)
at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19767:12
at listener (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37788:39)
Component stack:
(none)
GitHub URL search query:
https://api.github.com/search/issues?q=Cannot%20remove%20node%20%20because%20no%20matching%20node%20was%20found%20in%20the%20Store.%20in%3Atitle%20is%3Aissue%20is%3Aopen%20is%3Apublic%20label%3A%22Component%3A%20Developer%20Tools%22%20repo%3Afacebook%2Freact
|
https://github.com/facebook/react/issues/21442
|
https://github.com/facebook/react/pull/21516
|
7bef382bf92e380f2b94e825cf35b8af58f8a2ec
|
1e3383a41154cb32d8d6b78b2451ee4dabfcb973
| 2021-05-06T08:37:57Z |
javascript
| 2021-05-18T15:42:08Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,436 |
["packages/react-devtools-shared/src/__tests__/FastRefreshDevToolsIntegration-test.js", "packages/react-devtools-shared/src/backend/renderer.js", "packages/react-devtools/CHANGELOG.md"]
|
Error: "Cannot add node "1" because a node with that id is already in the Store."
|
<!-- Please answer both questions below before submitting this issue. -->
### Which website or app were you using when the bug happened?
Please provide a link to the URL of the website (if it is public), a CodeSandbox (https://codesandbox.io/s/new) example that reproduces the bug, or a project on GitHub that we can checkout and run locally.
### What were you doing on the website or app when the bug happened?
If possible, please describe how to reproduce this bug on the website or app mentioned above:
1. <!-- FILL THIS IN -->
2. <!-- FILL THIS IN -->
3. <!-- FILL THIS IN -->
<!--------------------------------------------------->
<!-- Please do not remove the text below this line -->
<!--------------------------------------------------->
### Generated information
DevTools version: 4.13.1-93782cfed2
Call stack:
(none)
Component stack:
(none)
GitHub URL search query:
https://api.github.com/search/issues?q=Cannot%20add%20node%20%20because%20a%20node%20with%20that%20id%20is%20already%20in%20the%20Store.%20in%3Atitle%20is%3Aissue%20is%3Aopen%20is%3Apublic%20label%3A%22Component%3A%20Developer%20Tools%22%20repo%3Afacebook%2Freact
|
https://github.com/facebook/react/issues/21436
|
https://github.com/facebook/react/pull/21523
|
b15bf2b2f1effb6f760effac9f48c5901622f27b
|
d6604ac0318f2ee139492d8dce64d6427e921658
| 2021-05-05T17:58:25Z |
javascript
| 2021-05-19T02:44:29Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,332 |
["packages/react-devtools-shared/src/__tests__/console-test.js", "packages/react-devtools-shared/src/backend/console.js", "packages/react-devtools-shell/src/app/InlineWarnings/index.js"]
|
DevTools does not handle Symbol values logged to cosole.warn/console.error
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: DevTools version 4.12.2-d14b6a4bdd
## Steps To Reproduce
1. Use `console.warn` from within a React component where the last argument is typeof `"symbol"`
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example: https://codesandbox.io/s/pedantic-neumann-711ph?file=/src/App.js
The bug only happens when you make a change, so if you use the code sandbox link you need, open a new window, active dev tools, open the React dev tools and then uncomment line 5: `// return null` only then will the error actually happen.
I've located the culprit to this line of code
https://github.com/facebook/react/blob/0e100ed00fb52cfd107db1d1081ef18fe4b9167f/packages/react-devtools-shared/src/backend/console.js#L146-L147
And would offer the following change
```
const alreadyHasComponentStack = typeof lastArg === "string" && isStringComponentStack(lastArg);
```
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
React DevTools is implicitly converting a Symbol to a string.
## The expected behavior
React DevTools does not implicitly try to convert a Symbol to a string.
|
https://github.com/facebook/react/issues/21332
|
https://github.com/facebook/react/pull/21368
|
2182563dc400b51fccea034dfcebe2aff9ee979e
|
22ab39be681251f1c0f257af7e636cb8debf31c4
| 2021-04-22T16:20:15Z |
javascript
| 2021-04-27T20:36:20Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,271 |
["packages/react-devtools-shared/src/backend/renderer.js"]
|
Error: "Could not find node with id "40035" in commit tree"
|
Describe what you were doing when the bug occurred:
1.
2.
3.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.11.0-39713716aa
Call stack: at chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:20884:13
at Map.forEach (<anonymous>)
at RankedChartBuilder_getChartData (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:20880:24)
at ProfilingCache_ProfilingCache.getRankedChartData (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:21004:11)
at CommitRankedAutoSizer (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:35717:32)
at Rh (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:13245:7)
at Ci (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:13944:7)
at uk (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:16725:86)
at tk (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:16245:11)
at qk (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:16237:23)
Component stack: at CommitRankedAutoSizer (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:35696:34)
at div
at div
at div
at SettingsModalContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:29121:3)
at Profiler_Profiler (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37243:34)
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30035:5)
at PortaledContent (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30157:5)
at div
at div
at ProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:34264:3)
at TreeContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:25356:3)
at SettingsContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:25963:3)
at ModalDialogContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30300:3)
at DevTools_DevTools (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:37639:3)
|
https://github.com/facebook/react/issues/21271
|
https://github.com/facebook/react/pull/21377
|
a5267faad5849eb3d10ead6be911f661691e0345
|
a0d6b155dc3a182162b9f91baac33df39d7919df
| 2021-04-14T19:16:21Z |
javascript
| 2021-04-28T14:29:22Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,262 |
["packages/react-devtools-shared/src/backend/renderer.js", "packages/react-devtools-shared/src/backend/types.js", "packages/react-reconciler/src/ReactFiberReconciler.new.js", "packages/react-reconciler/src/ReactFiberReconciler.old.js"]
|
DevTools use the renderer version to detect features on react-reconciler
|
This is a followup issue for pmndrs/react-three-fiber#1231
From my understanding of [this code](https://github.com/facebook/react/blob/master/packages/react-devtools-shared/src/backend/renderer.js#L141), the DevTools parse the version number advertised by the renderer in `injectIntoDevTools` to select how to parse the internal fiber object. Unfortunately this means that third-party renderers that advertise a version lower than the equivalent React version for the `react-reconciler` release they are using get misclassified: for instance `@react-three/[email protected]` is using `[email protected]` which is equivalent to `[email protected]`, and since major version `6.y.z` is much lower than `17.y.z` it uses the default values for the `ReactTypeOfWork` enum which in turns lead to `FunctionComponent` getting identified as `IndeterminateComponent` and hook inspection being unavailable.
A short term solution for renderers is to advertise a React-compatible version number, but ideally this is an implementation detail of the devtools that users of `react-reconciler` should not have to be aware of (also this means the version number displayed in the devtools is wrong). I'm not sure I'm familiar enough with the internals of the devtools to open a PR for this, but since the version parsing logic is used to detect features that are internal to `react-reconciler` anyway I guess a solution would be to have the Reconciler package add its own value for the `ReactVersion` constant along with the parameters sent to the devtools backend, and have the devtools use this string if its available over the renderer version.
|
https://github.com/facebook/react/issues/21262
|
https://github.com/facebook/react/pull/21269
|
15e779d921e11f22a39e688a5de89c3777462114
|
68097787f6e8f6d73af06e7c549a294df942b986
| 2021-04-14T07:53:21Z |
javascript
| 2021-04-14T18:48:05Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,235 |
["packages/react-devtools-inline/package.json", "packages/react-devtools-inline/webpack.config.js", "packages/react-devtools/CHANGELOG.md"]
|
Bug([email protected]): publish artifact points to /Users/bvaughn/Documents/git/react.devtools/
|
Published `[email protected]` has the following piece of code in `react-devtools-inline/dist/backend.js`:
```js
module.exports = require("/Users/bvaughn/Documents/git/react.devtools/packages/react-devtools-shared/src/config/DevToolsFeatureFlags.default");
```
:roll_eyes:
|
https://github.com/facebook/react/issues/21235
|
https://github.com/facebook/react/pull/21237
|
bb88ce95a87934a655ef842af776c164391131ac
|
9d48779b362ef773da50fef95af6998b560c75c0
| 2021-04-11T15:51:16Z |
javascript
| 2021-04-11T18:59:52Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,172 |
["packages/react-devtools-shared/src/devtools/views/hooks.js"]
|
Bug: DevTools settings dialog no longer opens
|
Click the settings gear in either the inline or extension build and it does not open.
Edit: This was broken by a change to React via f8ef4ff571db3de73b0bfab566c1ce9d69c6582f / #21150
|
https://github.com/facebook/react/issues/21172
|
https://github.com/facebook/react/pull/21173
|
b4f119cdf1defe2437e00022f670c6ef818cd43f
|
a817840ea7d3818c0590cccb9159b13220f4fdb4
| 2021-04-03T13:24:52Z |
javascript
| 2021-04-05T15:09:43Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,118 |
["packages/react-devtools-extensions/chrome/manifest.json", "packages/react-devtools-extensions/edge/manifest.json", "packages/react-devtools-extensions/firefox/manifest.json"]
|
Bump DevTools Chrome and Firefox versions
|
We currently build DevTools to target Chrome 49 and Firefox 54. These are super old browser versions and they did not have full ES6 support, so the generated build is more bloated than it needs to be.
DevTools uses most modern language features. Off the top of my head, the following features are used (basically everything but async and generator functions):
| Feature | Chrome support | Firefox support |
|:---|:---:|:---:|
| `let` and `const` | 49 |36 |
| `Map`, `Set`, and `WeakMap` | 36 | 6 |
| Arrow functions | 45 | 22 |
| Classes | 49 | 45 |
| Template strings |41 |34 |
| `Symbol()` | 38 | 36 |
| Spread operator | 60 | 55 |
| Destructuring assignment | 60 | 55 |
| For-of operator |38 | 13|
| `Object.assign` | 45 |34 |
| `Promise` | 33 | 29 |
The above min browser versions come from caniuse.com. Assuming I'm not forgetting things, it looks like we'd need to target Chrome 60+ (released 2017-07-25) and Firefox 55+ (released 2017-04-18). This seems like a reasonable set of browsers to target.
Interestingly enough, according to caniuse.com, [Chrome 51 and Firefox 54 are mostly ES6 compliant](https://caniuse.com/es6) but I think certain details (like spread in object literals) weren't included in the original spec and/or weren't added until later.
Note that we can't remove the IE 11 target from the `react-devtools-core` backend yet due to Hermes (React Native) ES6 support but that should be doable by the end of the year given current engineering targets. But we could update the frontend target, as well as the targets for the extensions and the `react-devtools-inline` package.
It would be good to increase the browser versions we target to _at least_ the version numbers mentioned above, rebuild the DevTools, and compare bundle sizes and generated code.
|
https://github.com/facebook/react/issues/21118
|
https://github.com/facebook/react/pull/21185
|
d778518998b290abfd21647dbd027118a9b5b88e
|
ee6a05c2bff30e423a98bc083209a5dca6965ec5
| 2021-03-27T14:37:13Z |
javascript
| 2021-04-06T15:18:46Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,098 |
["packages/react-dom/src/shared/CSSProperty.js"]
|
Bug: aspectRatio not being applied via style
|
React version: 16.14.0, 17.0.2
## Steps To Reproduce
1. Apply aspectRatio via `style` - no aspectRatio applied
2. Add via className - aspectRatio applied
Needs Chrome 79 or above:
Link to code example: https://codesandbox.io/s/react-bug-not-applying-aspect-ratio-via-style-w2pqh?file=/src/App.js
## The current behavior
No aspectRatio rule applied:
https://codesandbox.io/s/react-bug-not-applying-aspect-ratio-via-style-w2pqh?file=/src/App.js
## The expected behavior
aspectRatio applied, here I'm adding it via a `useLayoutEffect`:
https://codesandbox.io/s/currying-hill-i09qn?file=/src/App.js
|
https://github.com/facebook/react/issues/21098
|
https://github.com/facebook/react/pull/21100
|
4a99c5c3a780d8178d9278c29d0b7f44be6a0dce
|
a7c57268fb71163e4abb5e386c0d0e63290baaae
| 2021-03-25T15:03:36Z |
javascript
| 2021-03-25T17:01:36Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 21,026 |
["packages/react-devtools-shared/src/devtools/views/Components/InspectedElementHooksTree.css", "packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js", "packages/react-devtools-shared/src/devtools/views/root.css"]
|
Bug: DevTools built-in hook number badges are broken for "light" theme
|
I mostly use the "dark" theme which these badges looked good in. The "light" theme is broken though. No contrast.
|
https://github.com/facebook/react/issues/21026
|
https://github.com/facebook/react/pull/21034
|
154b85213a65377a67ac4f7a4a39116024bc3028
|
7d06b80af64d0121d373d8c6e8750a952c3897be
| 2021-03-18T00:32:29Z |
javascript
| 2021-03-19T13:52:59Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,997 |
["packages/react-devtools-extensions/build.js", "packages/react-devtools-extensions/firefox/README.md", "packages/react-devtools-extensions/firefox/test.js", "scripts/rollup/build-all-release-channels.js"]
|
Bug: Can't build react-devtools-extensions
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
I've just cloned the repo, ran `yarn`, and then `yarn build-for-devtools` as explained in the [README](https://github.com/facebook/react/blob/master/packages/react-devtools-extensions/README.md) but when trying to run `yarn build:firefox:dev` it can't find the packages I just built.
I think I'm following all the instructions here.
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
|
https://github.com/facebook/react/issues/20997
|
https://github.com/facebook/react/pull/21004
|
f227e7f26b81cb1eba0c837ab2acd7fa7f91404f
|
c06d245fc7325612347ed19232d92385cae2e0a7
| 2021-03-13T18:15:02Z |
javascript
| 2021-03-15T13:46:46Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,932 |
["packages/react-dom/src/__tests__/ReactWrongReturnPointer-test.js", "packages/react-reconciler/src/ReactFiber.new.js", "packages/react-reconciler/src/ReactFiber.old.js"]
|
Bug: SuspenseList crash
|
https://codesandbox.io/s/nostalgic-frost-53gys?file=/src/App.js
```js
import * as React from "react";
function S(props) {
return <React.Suspense {...props} />;
}
export default function App() {
return (
<React.unstable_SuspenseList revealOrder="forwards">
<S fallback={null}>
<Bad />
</S>
<S fallback={null}>
<h1>wow</h1>
</S>
</React.unstable_SuspenseList>
);
}
function Bad() {
const [c, setC] = React.useState(0);
read(c);
const r = React.useRef(true);
React.useEffect(() => {
if (r.current) {
r.current = false;
setC((x) => x + 1);
}
}, [c]);
return <h2>wow</h2>;
}
const cache = {};
function read(i) {
if (cache[i]) {
if (cache[i].result) {
return cache[i].result;
} else {
throw cache[i].promise;
}
}
cache[i] = {
promise: new Promise((resolve) => {
setTimeout(() => {
cache[i].result = "foo";
resolve();
}, 1000);
})
};
throw cache[i].promise;
}
```
|
https://github.com/facebook/react/issues/20932
|
https://github.com/facebook/react/pull/20948
|
c7b4497988e81606f1c7686434f55a49342c9efc
|
f04bcb8139cfa341640ea875c2eae15523ae9cd9
| 2021-03-05T00:04:16Z |
javascript
| 2021-03-07T17:20:01Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,905 |
["packages/react-devtools-shared/src/hydration.js"]
|
Redundant condition in react-devtools-shared
|
This is not important but it seems that this if statement is superfluous since `typeof` always returns a string.
https://github.com/facebook/react/blob/553440bd1578ef71982c4a10e2cc8c462f33d9be/packages/react-devtools-shared/src/hydration.js#L246
|
https://github.com/facebook/react/issues/20905
|
https://github.com/facebook/react/pull/21101
|
a77dd13ede337175e94a7a1d4198ff440a5cd87b
|
a5aa9d525345ca3281e027a6f62f212f5feee0cd
| 2021-03-01T15:16:34Z |
javascript
| 2021-03-26T17:50:58Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,868 |
["packages/react-is/index.experimental.js", "packages/react-is/index.stable.js", "packages/react-is/src/ReactIs.js", "packages/react-is/src/__tests__/ReactIs-test.js"]
|
react-is lacks SuspenseList
|
I'd like to be able to detect `SuspenseList` using `react-is`. Is there any reason why I shouldn't?
|
https://github.com/facebook/react/issues/20868
|
https://github.com/facebook/react/pull/20874
|
8336f19aa80c6646d6969fa61e34420776d884be
|
90bde6505e43434596ff6398c2c8acb67ced815b
| 2021-02-23T18:21:15Z |
javascript
| 2021-02-25T21:22:33Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,829 |
["packages/scheduler/src/SchedulerProfiling.js"]
|
Scheduler's use of SharedArrayBuffer will require cross-origin isolation
|
React version: v17.0.1
## Steps To Reproduce
1. `npx create-react-app myapp`
2. `cd myapp && npm start`
3. Open http://localhost:3000 in **Chrome 88 or 89, regular or Incognito mode**
4. Open DevTools: the warning is displayed
Link to code example: https://react-z95km1.stackblitz.io/
https://stackblitz.com/edit/react-z95km1
## The current behavior
Warning: `scheduler.development.js:298 [Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.`
## The expected behavior
No warning will be shown.
As the warning shows, Chrome will require cross-origin isolation starting version 91 in order to use SharedArrayBuffer. To enable cross-origin isolation, the page needs to be loaded with COOP and COEP headers which I believe is out of React's control. You can learn more about this at https://developer.chrome.com/blog/enabling-shared-array-buffer/.
As it's confusing for React users to see this warning every time they open the page, I'd propose two things:
1. Suppress the message by using SAB only when cross-origin isolation is enabled. You can check it by `self.crossOriginIsolated` boolean flag.
2. Document that the page needs to send COOP and COEP headers to profile performance using SharedArrayBuffer. You can find an actionable guide here: https://web.dev/cross-origin-isolation-guide/
The problematic code is here: https://github.com/facebook/react/blob/master/packages/scheduler/src/SchedulerProfiling.js#L21-L22
FWIW, with cross-origin isolation, you'll be able to use [JS Self-Profiling API](https://wicg.github.io/js-self-profiling/) too.
cc: @acomminos @maudnals
|
https://github.com/facebook/react/issues/20829
|
https://github.com/facebook/react/pull/20831
|
09916479219a61ae86d2ec8ce159a161337b9007
|
8fa0ccca0090acbf2d4717a19bc37e9443ba0bf8
| 2021-02-17T03:34:47Z |
javascript
| 2021-02-17T21:43:25Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,806 |
["packages/react-devtools-shared/src/backend/agent.js", "packages/react-devtools-shared/src/backend/utils.js", "packages/react-devtools-shared/src/bridge.js", "packages/react-devtools-shared/src/devtools/store.js"]
|
Bug: devtools reload-and-profile feature is defeated by sync-xhr feature policy
|
React version: all
## Steps To Reproduce
1. Visit a site that uses `Feature-Policy: sync-xhr 'none'` and has the profiling build of react enabled
2. Attempt to use the "reload and start profiling" feature of devtools
3. The xhr request will fail on reload because it [attempts to make a synchronous XHR call](https://github.com/facebook/react/blob/9198a5cec0936a21a5ba194a22fcbac03eba5d1d/packages/react-devtools-extensions/src/injectGlobalHook.js#L84). The profiling tab will be stuck in "press record to stop recording" state. Devtools will now fail to load on all subsequent refreshes unless the developer clears session storage, because it keeps trying and failing to make that XHR request.
## The current behavior
see `3.` above
## The expected behavior
Ideally, this feature would not depend on synchronous XHR to function. [Browsers are deprecating it](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Synchronous_and_Asynchronous_Requests#synchronous_request) and sites are blocking it via `Feature-Policy` due to third-party javascript abusing it.
In its current state, the feature should fail more gracefully when the XHR is blocked due to feature policy or in the future when browsers start blocking it by default.
|
https://github.com/facebook/react/issues/20806
|
https://github.com/facebook/react/pull/20879
|
b7e6310669ed7948d3d8729cc6c0d7904945f05b
|
bd245c1bab1a1f965cb51f5d01406a2770244930
| 2021-02-11T19:01:26Z |
javascript
| 2021-03-11T15:31:57Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,696 |
["packages/react-devtools-shared/src/backend/renderer.js"]
|
Bug: React Dev Tools fail to show component updates with memoized components.
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.1
## Steps To Reproduce
1. run the project: https://github.com/lifeiscontent/immutable-todo
2. open react dev tools and set the highlight updates when components render option.
3. add changes to the todos
4. see no updates are displayed via React dev tools
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
https://github.com/lifeiscontent/immutable-todo
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
currently, updates are only displayed if the react component is not memoized.
## The expected behavior
all react components should show their updates regardless of memoization.
|
https://github.com/facebook/react/issues/20696
|
https://github.com/facebook/react/pull/22008
|
3a1dc3ec8543cbfaf57f5d46d1db070d0555015b
|
b54f36f2b6eba4ae722bea56d4081a920fc9ad74
| 2021-01-30T05:35:47Z |
javascript
| 2021-08-03T15:50:00Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,685 |
["packages/react-devtools-shared/src/__tests__/console-test.js", "packages/react-devtools-shared/src/backend/agent.js", "packages/react-devtools-shared/src/backend/renderer.js", "packages/react-devtools-shared/src/hook.js"]
|
DevTools: Make sure inline warnings feature works even if append stacks is disabled
|
https://github.com/facebook/react/issues/20685
|
https://github.com/facebook/react/pull/20688
|
7cb9fd7ef822436aef13c8cbf648af1e21a5309a
|
3e0bdbefa3cb78c5534b808772ed6afad7c34827
| 2021-01-28T17:52:47Z |
javascript
| 2021-02-02T15:19:53Z |
|
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,675 |
["packages/react-devtools-shared/src/backend/renderer.js", "packages/react-reconciler/src/ReactFiberHooks.new.js", "packages/react-reconciler/src/ReactFiberHooks.old.js", "packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js"]
|
Bug: FunctionComponent re-render phase cause a bug
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:v17.0.1
## Steps To Reproduce
There maybe be a bug in following method
```
function updateEffectImpl(fiberFlags, hookFlags, create, deps): void {
const hook = updateWorkInProgressHook();
const nextDeps = deps === undefined ? null : deps;
let destroy = undefined;
if (currentHook !== null) {
const prevEffect = currentHook.memoizedState;
destroy = prevEffect.destroy;
if (nextDeps !== null) {
const prevDeps = prevEffect.deps;
if (areHookInputsEqual(nextDeps, prevDeps)) {
pushEffect(hookFlags, create, destroy, nextDeps);
return;
}
}
}
currentlyRenderingFiber.flags |= fiberFlags;
hook.memoizedState = pushEffect(
HookHasEffect | hookFlags,
create,
destroy,
nextDeps,
);
}
```
Link to the source code: [https://github.com/facebook/react/blob/e316f785526e503eceed1ae33b7a06440084b9c9/packages/react-reconciler/src/ReactFiberHooks.new.js#L1320](https://github.com/facebook/react/blob/e316f785526e503eceed1ae33b7a06440084b9c9/packages/react-reconciler/src/ReactFiberHooks.new.js#L1320)
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example: [https://codesandbox.io/s/reacthooks-fkihz?file=/src/MaybeABug.js](https://codesandbox.io/s/reacthooks-fkihz?file=/src/MaybeABug.js)
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
The first time click the button, it will not print the "effect"
But the second click will print the "effect"
the third will not, the fourth will be and so on
## The expected behavior
Maybe should always print nothing!
## Remarks
The reason for this phenomenon is when component entering re-render phase, the effect object is a big different in updateQueue and Hook object. But i think should be consistent。
In fact, i am not sure if it is a bug, so I look forward to receiving a reply, thanks
|
https://github.com/facebook/react/issues/20675
|
https://github.com/facebook/react/pull/20676
|
766a7a28a9a233b236a97166411a9242376df7a6
|
bb1b7951d182d36345c83154f9d9bab218011b46
| 2021-01-27T11:36:45Z |
javascript
| 2021-01-29T15:51:11Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,594 |
["packages/react-reconciler/src/ReactChildFiber.new.js", "packages/react-reconciler/src/ReactChildFiber.old.js"]
|
Bug: unintended .valueOf() maybe?
|
While chasing https://github.com/tc39/proposal-temporal/issues/1224 where I mistakenly pasted a `ZonedDateTime` into JSX, I discovered that:
* `react-reconciler` doesn't like arbitrary objects (fair)
* calls `throwOnInvalidObjectType` on such objects, source code of which looks completely fine†
* but said source code gets compiled into `... "foo" + newChild + "bar" ...`‡
* at the same time, react explicitly chose not to `valueOf()` objects in https://github.com/facebook/react/issues/4769
* this specific type throws unconditionally on `.valueOf` (I'm ambivalent about that decision)
† https://github.com/facebook/react/blob/98313aaa7ea58d49eb30ecffc0f9eb6fc1ef467a/packages/react-reconciler/src/ReactChildFiber.new.js#L223-L235
‡ compiled to `throw Error( "Objects are not valid as a React child (found: " + (Object.prototype.toString.call(newChild) === '[object Object]' ? 'object with keys {' + Object.keys(newChild).join(', ') + '}' : newChild) + "). If you meant to render a collection of children, use an array instead." );`
So, react won't use `valueOf` to render an element, but will use it to report and error about an element.
Maybe the "compilation" or interpolation of `invariant` is wrong?
Or perhaps `%s` handling in `invariant` is wrong?
Maybe my assumptions are wrong?
Maybe that type is wrong?
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: `17.0.1`
Steps To Reproduce
1. `return <div>{ new Temporal.Instant(0n).toZonedDateTimeISO("Europe/Berlin") }</div>;`
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example: https://github.com/dimaqq/test-temporal
|
https://github.com/facebook/react/issues/20594
|
https://github.com/facebook/react/pull/20617
|
2a646f73e4f64000fcd1a483cec1c08614f20e9c
|
2e948e0d91360e4763594854be84347737e4b1f6
| 2021-01-15T02:49:07Z |
javascript
| 2021-01-20T01:59:31Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,454 |
["packages/react-devtools/package.json", "yarn.lock"]
|
React DevTools should bump the Electron version to 11.0.1 for darwin-arm64 builds
|
## Environment:
- macOS 11.0.1 Big Sur, on an Apple Silicon (M1) chip
- React 17.0.1
- React DevTools 4.10.1, running in standalone mode via Electron 11.1.0 (darwin-arm64 build)
- New project using create-react-app . with the useScript hook to add the <script> tag required by React DevTools.
## Steps to reproduce
1. Add React DevTools to a project with `npm install --save react-devtools` (or yarn).
2. react-devtools expects Electron 9.x.x; however builds for darwin-arm64 are only available for 11.1.0. Installation fails with:
```
npm ERR! code 1
npm ERR! path /Users/michael/git/components-blank/node_modules/electron
npm ERR! command failed
npm ERR! command sh -c node install.js
HTTPError: Response code 404 (Not Found) for https://github.com/electron/electron/releases/download/v9.4.0/electron-v9.4.0-darwin-arm64.zip
...
```
Link to code example: [mglukhovsky/react-devtools-components-blank](https://github.com/mglukhovsky/react-devtools-components-blank)
## The current behavior
Workarounds are [documented here](https://github.com/mglukhovsky/react-devtools-components-blank#electron-1110-required-for-m1); however a 11.1.0 build is required.
## The expected behavior
Bump the version in package.json so this works out of the box.
|
https://github.com/facebook/react/issues/20454
|
https://github.com/facebook/react/pull/20496
|
6630c2de2a578aba0b61cb2e61e58a1466e80ca2
|
beb38aba3e5617cb915a8e979245b2996e1764e8
| 2020-12-13T23:57:36Z |
javascript
| 2021-01-04T15:38:11Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,431 |
["packages/react-devtools-shared/src/backend/renderer.js"]
|
Error: "Commit tree does not contain fiber "5766". This is a bug in React DevTools."
|
Describe what you were doing when the bug occurred:
1. Profiling [recharts library](https://recharts.org/en-US/api/LineChart)
2. Filtered on commits greater than 3s
3. Walking through the commits doing a next > next
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.10.1-f160547f47
Call stack: at updateTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19729:21)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:19594:26)
at ProfilingCache_ProfilingCache.getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:20115:11)
at CommitFlamegraphAutoSizer (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:34161:33)
at Hh (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:12807:7)
at qi (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:13457:7)
at mk (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:16074:86)
at lk (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:15459:11)
at kk (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:15451:23)
at ck (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:15435:5)
Component stack: at CommitFlamegraphAutoSizer (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:34144:50)
at div
at div
at div
at SettingsModalContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:28206:3)
at Profiler_Profiler (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:35772:50)
at ErrorBoundary_ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:29219:5)
at PortaledContent (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:29336:32)
at div
at div
at ProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:32934:3)
at TreeContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:24322:3)
at SettingsContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:24811:3)
at ModalDialogContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:29404:3)
at DevTools_DevTools (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:36207:3)
|
https://github.com/facebook/react/issues/20431
|
https://github.com/facebook/react/pull/21377
|
a5267faad5849eb3d10ead6be911f661691e0345
|
a0d6b155dc3a182162b9f91baac33df39d7919df
| 2020-12-11T04:00:11Z |
javascript
| 2021-04-28T14:29:22Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,417 |
["packages/react-refresh/src/ReactFreshBabelPlugin.js", "packages/react-refresh/src/ReactFreshRuntime.js", "packages/react-refresh/src/__tests__/ReactFreshBabelPlugin-test.js", "packages/react-refresh/src/__tests__/ReactFreshIntegration-test.js", "packages/react-refresh/src/__tests__/__snapshots__/ReactFreshBabelPlugin-test.js.snap"]
|
Bug: MobX-like observer pattern doesn't work with Fast Refresh because Hooks don't get detected
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 17.0.0
## Steps To Reproduce
1. https://codesandbox.io/s/react-refresh-webpack-plugin-rendered-more-hooks-than-during-the-previous-render-issue-ezcrz?file=/src/Comp.js
2. Delete one of the hooks there
<!--
Your bug will get fixed much faster if we can run your code and it doesn't
have dependencies other than React. Issues without reproduction steps or
code examples may be immediately closed as not actionable.
-->
Link to code example:
https://codesandbox.io/s/react-refresh-webpack-plugin-rendered-more-hooks-than-during-the-previous-render-issue-ezcrz?file=/src/Comp.js
<!--
Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
repository on GitHub, or provide a minimal code example that reproduces the
problem. You may provide a screenshot of the application if you think it is
relevant to your bug report. Here are some tips for providing a minimal
example: https://stackoverflow.com/help/mcve.
-->
## The current behavior
You get "Rendered more hooks than during the previous render" error
## The expected behavior
Should hot reload and re-mount the component.
The source of the issue have two parts:
1. react-refresh and the bundler fails to inject signature to the component
2. When no signature apparent, `react-refresh` consider the components as compatible, which is not always true, as in the repro https://github.com/facebook/react/blob/9aca239f11f31109dc1a229aa1571c2bf02f5524/packages/react-refresh/src/ReactFreshRuntime.js#L126-L132
I've filed an issue also for the webpack plugin: https://github.com/pmmmwh/react-refresh-webpack-plugin/issues/266
Mobx related issue: https://github.com/mobxjs/mobx/issues/2668
|
https://github.com/facebook/react/issues/20417
|
https://github.com/facebook/react/pull/21104
|
0853aab74dc8285401e62d1e490551ba3c96fd64
|
516b76b9ae177ecc38cc64ba33ddfc7cfe5f5a99
| 2020-12-09T20:49:59Z |
javascript
| 2021-03-30T15:08:50Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,343 |
["packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js", "packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js"]
|
[eslint-plugin-react-hooks] Bug: ESLint crashes if there's a `useEffect` / `useLayoutEffect` invocation without any arguments.
|
eslint-plugin-react-hooks version: 4.2.0
## Steps To Reproduce
I know it shouldn't exist in production code, but it's annoying while editing some files.
```js
import React, { useEffect } from "react";
const App = () => {
useEffect(); // <-
return null;
};
export default App;
```
Link to code example: https://codesandbox.io/s/polished-sun-3wr27?file=/src/App.js
## The current behavior
ESLint crashed.
```
TypeError: Cannot read property 'type' of undefined
```
## The expected behavior
ESLint doesn't crash but reports an error instead.
|
https://github.com/facebook/react/issues/20343
|
https://github.com/facebook/react/pull/20385
|
27659559ebfd6b7119bfc0ff02ecb851c135020c
|
e8eff119e036485b74b2acb6f57045390703f6fb
| 2020-11-28T15:49:52Z |
javascript
| 2021-01-11T20:18:45Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,224 |
["packages/use-subscription/package.json"]
|
Bug: Peer dependency change between use-subscription 1.4.1 and 1.5.0
|
React version: `[email protected]`
## Steps To Reproduce
1. Run `npm install [email protected] [email protected]`.
2. Run `npm install [email protected]`. Note the React peer dependency error.
Notably, this currently affects `npm install react@16 next@10` (see https://github.com/vercel/next.js/issues/18518). `npm@7` will refuse to perform this installation entirely.
## The current behavior
`[email protected]` peer-depends on `react@^16.8.0` whereas `[email protected]` peer-depends on `react@^17.0.0`, which is generally considered a breaking change in a minor version. This might have been an oversight in how https://github.com/facebook/react/pull/20062 interacted with https://github.com/facebook/react/pull/19373?
(It's considered a breaking change because a package.json like the below should always result in a valid install.)
```json
{
"dependencies": {
"react": "^16.14.0",
"use-subscription": "^1.4.1"
}
}
```
## The expected behavior
Here are two potential solutions:
- Cut a release of `[email protected]` that peer-depends on `^16.8.0 || ^17.0.0`, strictly widening the peer dep range from that of 1.4.1.
- Cut a major release of `use-subscription@2` that peer-depends on `^17.0.0`, and cut a release of `[email protected]` that reverts its peer dependency to `^16.8.0`.
|
https://github.com/facebook/react/issues/20224
|
https://github.com/facebook/react/pull/20225
|
15df051c94533c70b065d51c41cf9b6b2f1dc6a6
|
e7006d67dff2b9d3a9545204a469f32c70d52a8b
| 2020-11-11T17:40:09Z |
javascript
| 2020-11-12T00:30:19Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,204 |
["packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js", "packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js"]
|
Bug: eslint-plugin-react-hooks: Cannot read property 'type' of undefined at analyzePropertyChain
|
<!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
```json
"react": "^16.14.0"
"eslint-plugin-react-hooks": "^4.2.0",
```
## Steps To Reproduce
1. Lint file with contents below
```js
// useCustomHook.js
import { useEffect } from 'react';
export function useCustomHook(someObject) {
useEffect(() => {
}, [
someObject?.optionalField.method(),
]);
}
```
```js
// .eslint.rc
module.exports = {
root: true,
env: {
es6: true,
},
parserOptions: {
ecmaVersion: 2020,
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
},
settings: {
react: {
version: 'detect',
},
},
plugins: ['react-hooks'],
extends: [
'plugin:react-hooks/recommended',
],
};
```
## The current behavior
ESlint reports error: `Cannot read property 'type' of undefined Occurred while linting <file>`.
https://github.com/facebook/react/blob/13a62feab8c39bc0292eb36d636af0bb4f3a78df/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js#L1624-L1625
## The expected behavior
ESlint rule should not crash. According to https://github.com/facebook/react/issues/18819#issuecomment-655151489 optional chaining should be supported.
I was testing [an ESLint testing tool](https://github.com/AriPerkkio/eslint-remote-tester) I've been creating and ran into this issue. I can work on a fix for this later if needed.
Here's the results and log.
<details>
<summary>Error result</summary>
## Rule: unable-to-parse-rule-id
- Message: `Cannot read property 'type' of undefined
Occurred while linting <text>:45`
- Path: `elastic/kibana/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/use_rules.tsx`
- [Link](https://github.com/elastic/kibana/blob/HEAD/x-pack/plugins/security_solution/public/detections/containers/detection_engine/rules/use_rules.tsx#L45)
```tsx
const reFetchRules = useRef<(refreshPrePackagedRule?: boolean) => void>(noop);
const [loading, setLoading] = useState(true);
const [, dispatchToaster] = useStateToaster();
useEffect(() => {
let isSubscribed = true;
const abortCtrl = new AbortController();
async function fetchData() {
try {
```
```
TypeError: Cannot read property 'type' of undefined
Occurred while linting <text>:45
at analyzePropertyChain (/<removed>/eslint-remote-tester/node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js:2235:12)
at analyzePropertyChain (/<removed>/eslint-remote-tester/node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js:2264:20)
at /<removed>/eslint-remote-tester/node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js:1297:34
at Array.forEach (<anonymous>)
at visitFunctionWithDependencies (/<removed>/eslint-remote-tester/node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js:1277:43)
at visitCallExpression (/<removed>/eslint-remote-tester/node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js:1737:11)
at /<removed>/eslint-remote-tester/node_modules/eslint/lib/linter/safe-emitter.js:45:58
at Array.forEach (<anonymous>)
at Object.emit (/<removed>/eslint-remote-tester/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
at NodeEventGenerator.applySelector (/<removed>/eslint-remote-tester/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
```
</details>
<details>
<summary>Log</summary>
```
Full log:
[DONE] AriPerkkio/js-framework-playground 0 errors
[DONE] oldboyxx/jira_clone 0 errors
[WARN] Linting cities.ts took 7s at reach/reach-ui/packages/combobox/examples
[WARN] Linting cities.js took 6s at reach/reach-ui/website/src/components
[DONE] reach/reach-ui 0 errors
[DONE] ant-design/ant-design 0 errors
[DONE] StreakYC/react-smooth-collapse 0 errors
[WARN] pmndrs/react-spring crashed: no-useless-constructor
[DONE] pmndrs/react-spring 1 errors
[DONE] AriPerkkio/scrpr 0 errors
[DONE] react-bootstrap/react-bootstrap 0 errors
[DONE] AriPerkkio/suspense-examples 0 errors
[DONE] AriPerkkio/state-mgmt-examples 0 errors
[WARN] withspectrum/spectrum crashed: no-useless-constructor
[DONE] withspectrum/spectrum 1 errors
[DONE] codesandbox/codesandbox-client 0 errors
[WARN] Linting index.js took 40s at mui-org/material-ui/packages/material-ui-icons/src
[WARN] mui-org/material-ui crashed: no-useless-constructor
[DONE] mui-org/material-ui 2 errors
[DONE] reactjs/reactjs.org 0 errors
[DONE] zesty-io/accounts-ui 0 errors
[DONE] zesty-io/design-system 0 errors
[DONE] segmentio/evergreen 0 errors
[DONE] segmentio/ui-box 0 errors
[DONE] kentcdodds/kentcdodds.com 0 errors
[DONE] kentcdodds/react-fundamentals 0 errors
[DONE] kentcdodds/testing-react-apps 0 errors
[DONE] kentcdodds/react-suspense 0 errors
[DONE] kentcdodds/react-hooks 0 errors
[DONE] artsy/force 0 errors
[DONE] kentcdodds/react-performance 0 errors
[DONE] kentcdodds/advanced-react-hooks 0 errors
[DONE] kentcdodds/advanced-react-patterns 0 errors
[DONE] kentcdodds/bookshelf 0 errors
[DONE] kentcdodds/react-testing-library-examples 0 errors
[DONE] kentcdodds/react-testing-library-course 0 errors
[DONE] kentcdodds/learn-react 0 errors
[DONE] kentcdodds/concurrent-react 0 errors
[WARN] Linting material.min.js took 7s at project-bobon/bobonroastprofile/public
[DONE] project-bobon/bobonroastprofile 0 errors
[DONE] gothinkster/react-redux-realworld-example-app 0 errors
[DONE] 1ven/do 0 errors
[DONE] dockunit/platform 0 errors
[DONE] afghl/dribbble-demo 0 errors
[DONE] ismaelgt/english-accents-map 0 errors
[DONE] DevAlien/dripr-ui 0 errors
[DONE] rwieruch/favesound-mobx 0 errors
[DONE] rwieruch/favesound-redux 0 errors
[DONE] skidding/flatris 0 errors
[DONE] feednext/feednext 0 errors
[DONE] pearofducks/foodprocessor 0 errors
[DONE] limichange/flex-editor 0 errors
[DONE] HVF/franchise 0 errors
[DONE] vercel/hyper 0 errors
[DONE] getguesstimate/guesstimate-app 0 errors
[DONE] stevenhauser/i-have-to-return-some-videotapes 0 errors
[DONE] bebraw/invoice-frontend 0 errors
[DONE] gpbl/isomorphic500 0 errors
[DONE] WebbyLab/itsquiz-wall 0 errors
[DONE] docker/kitematic 0 errors
[DONE] KrateLabs/KrateLabs-App 0 errors
[DONE] afghl/dribble-demo 0 errors
[DONE] zeit/hyper 0 errors
[DONE] koodilehto/invoice-frontend 0 errors
[DONE] insin/lifequote 0 errors
[DONE] paulhoughton/mortgage 0 errors
[DONE] paulhoughton/mortgage-mobx 0 errors
[DONE] browniefed/pdxlivebus 0 errors
[WARN] Linting jquery.js took 9s at Khan/perseus/lib
[WARN] skidding/illustrated-algorithms failed to pull
[DONE] skidding/illustrated-algorithms 0 errors
[WARN] Linting kas.js took 9s at Khan/perseus/lib
[WARN] Linting katex.js took 8s at Khan/perseus/lib/katex
[WARN] Linting less.js took 11s at Khan/perseus/lib
[WARN] Linting mathquill-basic.js took 8s at Khan/perseus/lib/mathquill
[WARN] Linting raphael.js took 7s at Khan/perseus/lib
[DONE] guyellis/plant 0 errors
[DONE] benoitvallon/react-native-nw-react-calculator 0 errors
[WARN] Linting react-with-addons.js took 22s at Khan/perseus/lib
[DONE] insin/react-hn 0 errors
[DONE] LeoAJ/react-iTunes-search 0 errors
[WARN] FormidableLabs/react-music crashed: no-useless-constructor
[DONE] FormidableLabs/react-music 1 errors
[DONE] echenley/react-news 0 errors
[WARN] Linting vendors.min.js took 27s at lkazberova/react-photo-feed/static
[DONE] lkazberova/react-photo-feed 0 errors
[DONE] Khan/perseus 0 errors
[DONE] pl12133/react-solitaire 0 errors
[WARN] Linting bundle.js took 18s at afonsopacifer/react-pomodoro/app
[DONE] afonsopacifer/react-pomodoro 0 errors
[DONE] chvin/react-tetris 0 errors
[DONE] web-pal/react-trello-board 0 errors
[DONE] fcsonline/react-transmission 0 errors
[DONE] SKempin/reactjs-tmdb-app 0 errors
[DONE] fullstackreact/react-yelp-clone 0 errors
[DONE] hoppula/refire-forum 0 errors
[WARN] Linting bootstrap.min.js took 8s at antoinejaussoin/retro-board/retro-board-app/public/marketing/js
[DONE] ritoplz/ritoplz 0 errors
[DONE] andrewngu/sound-redux 0 errors
[DONE] antoinejaussoin/retro-board 0 errors
[DONE] FormidableLabs/spectacle 0 errors
[DONE] torontojs/torontojs.com 0 errors
[DONE] sprintly/sprintly-ui 0 errors
[WARN] captbaritone/winamp2-js crashed: no-useless-constructor
[DONE] captbaritone/winamp2-js 1 errors
[DONE] Automattic/wp-calypso 0 errors
[DONE] marmelab/react-admin 0 errors
[DONE] reactstrap/reactstrap 0 errors
[DONE] palantir/blueprint 0 errors
[DONE] Semantic-Org/Semantic-UI-React 0 errors
[DONE] grommet/grommet 0 errors
[DONE] rebassjs/rebass 0 errors
[DONE] FortAwesome/react-fontawesome 0 errors
[WARN] microsoft/fluentui crashed: no-useless-constructor
[DONE] chakra-ui/chakra-ui 0 errors
[WARN] reakit/reakit crashed: no-useless-constructor
[DONE] reakit/reakit 1 errors
[DONE] rsuite/rsuite 0 errors
[WARN] Linting Calendar.js took 26s at primefaces/primereact/src/components/calendar
[DONE] uber/baseweb 0 errors
[DONE] couds/react-bulma-components 0 errors
[DONE] kulakowka/react-bulma 0 errors
[DONE] dfee/rbx 0 errors
[WARN] Linting index.ts took 13s at microsoft/fluentui/packages/react-icons-mdl2/src
[DONE] primefaces/primereact 0 errors
[DONE] fibo/trunx 0 errors
[DONE] knipferrc/tails-ui 0 errors
[DONE] emortlock/tailwind-react-ui 0 errors
[DONE] geist-org/react 0 errors
[WARN] Linting List.tsx took 8s at microsoft/fluentui/packages/react-internal/src/components/List
[DONE] brillout/awesome-react-components 0 errors
[WARN] Linting react-datepicker.js took 16s at elastic/eui/packages
[DONE] JedWatson/react-select 0 errors
[DONE] atlassian/react-beautiful-dnd 0 errors
[DONE] react-dnd/react-dnd 0 errors
[DONE] strml/react-grid-layout 0 errors
[DONE] microsoft/fluentui 1 errors
[DONE] adazzle/react-data-grid 0 errors
[DONE] tannerlinsley/react-table 0 errors
[WARN] elastic/eui crashed: no-useless-constructor
[DONE] mzabriskie/react-draggable 0 errors
[DONE] strml/react-resizable 0 errors
[DONE] bokuweb/react-resizable-and-movable 0 errors
[DONE] elastic/eui 1 errors
[DONE] axmz/react-searchbox-awesome 0 errors
[DONE] bokuweb/react-resizable-box 0 errors
[DONE] bokuweb/react-sortable-pane 0 errors
[DONE] aeagle/react-spaces 0 errors
[DONE] Hacker0x01/react-datepicker 0 errors
[WARN] Linting DayPickerRangeController_spec.jsx took 8s at airbnb/react-dates/test/components
[DONE] orgsync/react-list 0 errors
[DONE] airbnb/react-dates 0 errors
[WARN] Linting bundle.js took 45s at intljusticemission/react-big-calendar/examples
[DONE] intljusticemission/react-big-calendar 0 errors
[DONE] i18next/react-i18next 0 errors
[DONE] davidtheclark/react-aria-modal 0 errors
[WARN] Linting test262-main.ts took 10s at yahoo/react-intl/packages/intl-listformat
[WARN] Linting app.js took 18s at glortho/react-keydown/example/public/js
[DONE] glortho/react-keydown 0 errors
[WARN] Linting test262-main.ts took 7s at yahoo/react-intl/packages/intl-numberformat
[DONE] gilbarbara/react-joyride 0 errors
[DONE] greena13/react-hotkeys 0 errors
[DONE] bvaughn/react-window 0 errors
[WARN] text-mask/text-mask crashed: no-useless-constructor
[WARN] Linting test262-main.ts took 41s at yahoo/react-intl/packages/intl-relativetimeformat
[DONE] yahoo/react-intl 0 errors
[DONE] bvaughn/react-virtualized 0 errors
[DONE] dvtng/react-loading-skeleton 0 errors
[DONE] KyleAMathews/react-spinkit 0 errors
[DONE] zpao/qrcode.react 0 errors
[DONE] airbnb/rheostat 0 errors
[DONE] pierpo/react-archer 0 errors
[WARN] Linting bundle.js took 23s at text-mask/text-mask/website/static
[DONE] text-mask/text-mask 1 errors
[DONE] mkosir/react-parallax-tilt 0 errors
[DONE] rackt/react-autocomplete 0 errors
[DONE] phuoc-ng/react-pdf-viewer 0 errors
[DONE] eliseumds/react-autocomplete 0 errors
[DONE] moroshko/react-autosuggest 0 errors
[DONE] prometheusresearch/react-autocomplete 0 errors
[DONE] gragland/instatype 0 errors
[DONE] paypal/downshift 0 errors
[DONE] ericgio/react-bootstrap-typeahead 0 errors
[DONE] matteobruni/tsparticles 0 errors
[DONE] facebook/react-art 0 errors
[DONE] Flipboard/react-canvas 0 errors
[DONE] pilwon/react-famous 0 errors
[DONE] kmkzt/react-hooks-svgdrawing 0 errors
[DONE] gorangajic/react-svg-morph 0 errors
[WARN] Linting kinetic-v5.1.0.js took 14s at freiksenet/react-kinetic/vendor
[DONE] freiksenet/react-kinetic 0 errors
[DONE] chrvadala/react-svg-pan-zoom 0 errors
[DONE] reduction-admin/react-reduction 0 errors
[DONE] jeffersonRibeiro/react-shopping-cart 0 errors
[DONE] clintonwoo/hackernews-react-graphql 0 errors
[DONE] firefox-devtools/debugger 0 errors
[DONE] gaearon/overreacted.io 0 errors
[WARN] Linting admin_definition.jsx took 6s at mattermost/mattermost-webapp/components/admin_console
[DONE] dnote/dnote 0 errors
[WARN] elastic/kibana crashed: no-useless-constructor
[DONE] mattermost/mattermost-webapp 0 errors
[WARN] elastic/kibana crashed: unable-to-parse-rule-id
[DONE] elastic/kibana 8 errors
[DONE] Finished scan of 164 repositories
✨ Done in 3720.16s.
```
</details>
|
https://github.com/facebook/react/issues/20204
|
https://github.com/facebook/react/pull/20247
|
7b84dbd1697609d4df5931422c9591fe62022cb9
|
eb58c3909aa19fb6ffbed27b9c9dba4aada3cb8e
| 2020-11-09T18:15:07Z |
javascript
| 2021-03-24T16:45:27Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,202 |
["packages/react-reconciler/src/SchedulingProfiler.js", "packages/react-reconciler/src/__tests__/SchedulingProfiler-test.internal.js", "packages/shared/forks/ReactFeatureFlags.www-dynamic.js", "packages/shared/forks/ReactFeatureFlags.www.js"]
|
Scheduling profiler tweaks
|
Make the `enableSchedulingProfiler` flag dynamic for the profiling build (so marks can be disabled). I think it should be sufficient to do something like:
```js
export const enableSchedulingProfiler =
__PROFILE__ && dynamicFeatureFlags.enableSchedulingProfiler;
```
Update our User Timing API check to include `clearMeasures` and when we call `mark(name)`, also call `clearMeasures(name)` to avoid clogging the entries buffer. (Apparently this has a significant negative performance impact for Firefox.)
|
https://github.com/facebook/react/issues/20202
|
https://github.com/facebook/react/pull/20215
|
9403c3b536f510fc54a16607bb211f630c71b55f
|
760d9ab57a0fbffe8caf1d15c40efaa0a3592733
| 2020-11-09T17:57:29Z |
javascript
| 2020-11-12T14:47:04Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,186 |
["scripts/rollup/build.js", "scripts/rollup/plugins/closure-plugin.js", "scripts/rollup/wrappers.js"]
|
Distribute source maps for easier debugging in Chrome's Performance tab
|
~~I want to propose the addition of a new file in the `react-dom` npm package called `react-dom.production.js` — a non-minified version of `react-dom` production build.~~
Edit: After some discussion(see below) it seems that distributing source maps makes more sense. Source maps will help you see the real function names and explore them. (The points below apply for source maps as well.)
## Why?
There are a few ways to profile React's performance — none of them provide a low-level view of what's happening. I believe the best way to profile React is using Chrome's Performance tab using a non-minified production build. Here's why:
- **Familiar.** People use the Performance tab for every other performance profiling so they are familiar with how to use it.
- **Powerful.** The Performance tab is extremely powerful. Years of engineering have been put into developing it.
- **Better understanding.** When using the React DevTools profiler I have a common problem – I see a component being rendered slowly but I don't know what is causing it. In order to understand I need a more low-level view. Here are some questions that can be answered only with the Chrome Performance tab:
- What's the balance between the app's code and React execution times? Should I implement some frequently updated components using custom non-React implementation?
- What time is spend on setting attribute values, setting `innerHTML` and adding and removing listeners?
- What time is spent on disposing effects? Is there a specific dispose function that is taking more than usual?
- What time is spent on mounting effects? Is there a specific effect mount that is taking more than usual?
## Disadvantages
As with every solution, there are some drawbacks to using this approach:
- **Documentation needed.** In order to make sense of what's happening you will need some knowledge of the core functions in React. A little guide with the names of the functions for mount/unmount, effects, and DOM manipulations will be useful. This of course can be done by the community(you are already linking to some community posts in React's documentation).
- **Requires more skill.** This isn't for everybody. It's aimed at more experienced developers. This type of profiling is a lot more overwhelming than the current approach.
- **May not fit your principles.** Maybe it's not part of your principles to introduce and promote such a complicated solution. Maybe you are more interested in searching for a more elegant and minimal solution.
|
https://github.com/facebook/react/issues/20186
|
https://github.com/facebook/react/pull/26446
|
2983249dd2bb1a295f27939e36ab0de9e4bfab76
|
2c8a139a593e0294c3a6953d74b451bd05fdcfca
| 2020-11-06T21:10:50Z |
javascript
| 2023-11-07T18:59:27Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,100 |
["packages/react-refresh/package.json", "packages/react-refresh/src/ReactFreshRuntime.js", "packages/react-refresh/src/__tests__/ReactFresh-test.js", "yarn.lock"]
|
Bug: DevTools not finding/showing React components
|
When I use DevTools to select an element on the page, it can't jump/find it.
It also doesn't show it in the Components page.
This was checked by finding its parent and checking the children, non of the newly generated ones are there.
As a probably related bug Profiler doesn't show/record the changes.
React version: 16.13.1
React-dom version: 16.13.1
Parcel: 2.0.0-beta.1
## Steps To Reproduce
1. Have a parent element
2. Have a child element (A)
3. Using conditional rendering (`condition ? A : B`) "hide" A
4. B now shows
5. Try and select B using Chrome Dev Tools's "Select an element in the page to inspect it"
6. Jumps nowhere/Can't find it manually in the list.
## Example
In this example, I demonstrate that it works on the Search Bar (light grey bar) which is the TextField=>InputBase tree, and the Container that contains the search & images and how hovering over the image doesn't do anything.
I then click on the image and nothing happens & the state panel on the right of Dev Tools empties itself.
## The current behaviour
Can't find newly rendered components in React Dev Tools Components panel
## The expected behavior
Being able to find the newly rendered components in React Dev Tools Components panel
|
https://github.com/facebook/react/issues/20100
|
https://github.com/facebook/react/pull/20129
|
b6a750be3ca0fc4126ef018e205c951b890c1881
|
343d7a4a7eb621a31ba946309b557e0988be3a63
| 2020-10-26T12:48:50Z |
javascript
| 2020-10-29T17:23:57Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 20,069 |
["packages/react-reconciler/src/ReactFiberLane.js"]
|
react-dom 17 breaks on internet explorer
|
After updating react-dom to version 17 the build now includes Array.fill() which isn't supported by ie11 without polyfilling. Coming from this line. Tested with just the default cra production build to make sure it wasn't a problem with my webpack config and the same issue.
https://github.com/facebook/react/blob/96ac799eace5d989de3b4f80e6414e94a08ff77a/packages/react-reconciler/src/ReactFiberLane.js#L671
Tested using CRA on version 16.9.8 of react and react-dom which works with the production build for ie11.
|
https://github.com/facebook/react/issues/20069
|
https://github.com/facebook/react/pull/20071
|
40cfe1f486a6f3901f98e7856cb7974690f311e9
|
6f62abb58ae46d9c88525635f1790487285666e6
| 2020-10-21T10:52:51Z |
javascript
| 2020-10-21T12:17:44Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 19,948 |
["packages/react-reconciler/src/ReactFiberHooks.new.js", "packages/react-reconciler/src/ReactFiberHooks.old.js", "packages/react-reconciler/src/__tests__/useMutableSource-test.internal.js", "packages/react/src/ReactMutableSource.js", "packages/shared/ReactTypes.js", "scripts/error-codes/codes.json"]
|
Bug: unstable_useMutableSource throws error when mutated before subscribe
|
React version: 0.0.0-experimental-94c0244ba
## Steps To Reproduce
Mutating the external source during the initial render before subscribe throws error.
https://codesandbox.io/s/usemutablesource-7nbs6?file=/src/App.js
1. Navigate to the above code sandbox
2. Click on the Mutate button. Final Value is rendered without any error. (Success Mode)
3. Toggle to Error Mode and click on the Mutate button again.
4. Error thrown (and the UI is rendered with the Final Value when run from vscode)
> Note: In our actual codebase (private), we are seeing this error at different instances e.g. component getting updated due to `setState` call in `useLayoutEffect` etc.
## The current behavior
Seeing errors in development build.
## The expected behavior
These errors thrown by useMutableSource should not showup on the UI and not passed to the error boundary as the component is eventually re-rendered with the latest state without any error.
|
https://github.com/facebook/react/issues/19948
|
https://github.com/facebook/react/pull/20665
|
a922f1c710f60f64c9013fb567ce8b9c15f252eb
|
766a7a28a9a233b236a97166411a9242376df7a6
| 2020-10-02T19:53:35Z |
javascript
| 2021-01-29T15:22:55Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 19,911 |
["packages/react-devtools-shared/src/__tests__/componentStacks-test.js", "packages/react-devtools-shared/src/backend/DevToolsComponentStackFrame.js"]
|
Bug: devtools Profiler causes unexpected errors
|
We noticed that our app would behave differently during profiling runs and trigger errors. I'm not totally sure what the underlying issue is but I was able to put together a example app to reproduce. As far as I can tell it has to do with how devtools is overriding `console.warn` and `console.error`. In that case `describeNativeComponentFrame()` will call a function component with no args. This works fine as the error is caught in `describeNativeComponentFrame()` but in it looks like a `useEffect()` that accesses those `props` is still triggered and it does not expect `props` to be undefined.
I realize that having `props` in the dependencies array of the `useEffect` doesn't really make sense but I still think it probably shouldn't error.
React version: 16.13.1
React devtools version: 4.8.2
## Steps To Reproduce
1. Open link to code example below
2. Click "Open In New Window" from the "Browser" tab
3. Observe a simple app with only `<h1>Hello World</h1>`
3. Open the React devtools Profiler tab
4. Click "Reload and start profiling"
5. Observe an error `Uncaught TypeError: Cannot read property 'foo' of undefined`
Link to code example:
https://codesandbox.io/s/cool-sun-wdrry
## The current behavior
## The expected behavior
The app should work as it while not profile. It should render a `<h1>Hello World</h1>`
|
https://github.com/facebook/react/issues/19911
|
https://github.com/facebook/react/pull/20011
|
880587366d84f9d36dd606088bc7bad050ead77e
|
f75f8b48a2ab14e31712389f91750c58de18c378
| 2020-09-25T18:18:33Z |
javascript
| 2020-10-14T17:19:47Z |
closed
|
facebook/react
|
https://github.com/facebook/react
| 19,839 |
["packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js"]
|
Error: "Maximum call stack size exceeded" for getCommitTree
|
Describe what you were doing when the bug occurred:
1. Clicking back to go back through the frames following a profile session. I think I got to zero and then clicked it again and then it errored
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.8.2-fed4ae024
Call stack: at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17661:26)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17710:30)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17710:30)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17710:30)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17710:30)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17710:30)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17710:30)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17710:30)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17710:30)
at getCommitTree (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:17710:30)
Component stack: at CommitRankedAutoSizer (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:31963:48)
at div
at div
at div
at SettingsModalContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:26139:23)
at Profiler_Profiler (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:33363:48)
at ErrorBoundary (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:27172:5)
at PortaledContent (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:27303:32)
at div
at div
at ProfilerContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:30463:23)
at TreeContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:22538:23)
at SettingsContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:23040:27)
at ModalDialogContextController (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:28328:23)
at DevTools_DevTools (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/main.js:33797:21)
|
https://github.com/facebook/react/issues/19839
|
https://github.com/facebook/react/pull/21383
|
9e9dac650535406b25979758a630a78b7c68a22c
|
3c21aa855a13707a8abe5dc6eaf2d2a7429fa762
| 2020-09-15T20:56:05Z |
javascript
| 2021-04-28T20:32:35Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.