status
stringclasses
1 value
repo_name
stringclasses
31 values
repo_url
stringclasses
31 values
issue_id
int64
1
104k
title
stringlengths
4
233
body
stringlengths
0
186k
issue_url
stringlengths
38
56
pull_url
stringlengths
37
54
before_fix_sha
stringlengths
40
40
after_fix_sha
stringlengths
40
40
report_datetime
timestamp[us, tz=UTC]
language
stringclasses
5 values
commit_datetime
timestamp[us, tz=UTC]
updated_file
stringlengths
7
188
chunk_content
stringlengths
1
1.03M
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,607
[Bug] [dolphinscheduler-api] Failed to execute PROCEDURE node
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened 1.An error is reported when the data storage IN mode references a user-defined parameter ![image](https://user-images.githubusercontent.com/95271106/147314112-2de413d6-8a26-4273-9498-2a2d3b267b2c.png) ![image](https://user-images.githubusercontent.com/95271106/147314340-4f353213-0f1c-41e5-ad74-301c7edee50c.png) 2.An error is reported when the data storage OUTmode references a user-defined parameter ![image](https://user-images.githubusercontent.com/95271106/147314276-6184d141-c402-4f52-84f0-3bcd110f798c.png) ![image](https://user-images.githubusercontent.com/95271106/147314303-d7794de0-ed75-45a6-94ff-35d76fb87728.png) ### What you expected to happen . ### How to reproduce . ### Anything else _No response_ ### Version 2.0.1 ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7607
https://github.com/apache/dolphinscheduler/pull/7680
2b05ebf47e3f6c3d02810a8c0dd18c32be4ffde0
cc77963522536526618e19216d38dcd4fd8da472
2021-12-24T03:58:29Z
java
2021-12-28T11:19:30Z
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java
if (!m.find()) { break; } String paramName = m.group(1); String paramValue = sqlParamsMap.get(paramName).getValue(); content = m.replaceFirst(paramValue); } return content; } /** * create function list * * @param udfFuncTenantCodeMap key is udf function,value is tenant code * @param logger logger * @return create function list */ public static List<String> createFuncs(Map<UdfFuncRequest, String> udfFuncTenantCodeMap, String defaultFS, Logger logger) { if (MapUtils.isEmpty(udfFuncTenantCodeMap)) { logger.info("can't find udf function resource"); return null; } List<String> funcList = new ArrayList<>(); // b buildJarSql(funcList, udfFuncTenantCodeMap, defaultFS); // b buildTempFuncSql(funcList, new ArrayList<>(udfFuncTenantCodeMap.keySet())); return funcList; } /** * b
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,607
[Bug] [dolphinscheduler-api] Failed to execute PROCEDURE node
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened 1.An error is reported when the data storage IN mode references a user-defined parameter ![image](https://user-images.githubusercontent.com/95271106/147314112-2de413d6-8a26-4273-9498-2a2d3b267b2c.png) ![image](https://user-images.githubusercontent.com/95271106/147314340-4f353213-0f1c-41e5-ad74-301c7edee50c.png) 2.An error is reported when the data storage OUTmode references a user-defined parameter ![image](https://user-images.githubusercontent.com/95271106/147314276-6184d141-c402-4f52-84f0-3bcd110f798c.png) ![image](https://user-images.githubusercontent.com/95271106/147314303-d7794de0-ed75-45a6-94ff-35d76fb87728.png) ### What you expected to happen . ### How to reproduce . ### Anything else _No response_ ### Version 2.0.1 ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7607
https://github.com/apache/dolphinscheduler/pull/7680
2b05ebf47e3f6c3d02810a8c0dd18c32be4ffde0
cc77963522536526618e19216d38dcd4fd8da472
2021-12-24T03:58:29Z
java
2021-12-28T11:19:30Z
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java
* * @param sqls sql list * @param udfFuncRequests udf function list */ private static void buildTempFuncSql(List<String> sqls, List<UdfFuncRequest> udfFuncRequests) { if (CollectionUtils.isNotEmpty(udfFuncRequests)) { for (UdfFuncRequest udfFuncRequest : udfFuncRequests) { sqls.add(MessageFormat .format(CREATE_FUNCTION_FORMAT, udfFuncRequest.getFuncName(), udfFuncRequest.getClassName())); } } } /** * b * @param sqls sql list * @param udfFuncTenantCodeMap key is udf function,value is tenant code */ private static void buildJarSql(List<String> sqls, Map<UdfFuncRequest,String> udfFuncTenantCodeMap, String defaultFS) { String resourceFullName; Set<Entry<UdfFuncRequest, String>> entries = udfFuncTenantCodeMap.entrySet(); for (Map.Entry<UdfFuncRequest, String> entry : entries) { String prefixPath = defaultFS.startsWith("file://") ? "file://" : defaultFS; String uploadPath = CommonUtils.getHdfsUdfDir(entry.getValue()); resourceFullName = entry.getKey().getResourceName(); resourceFullName = resourceFullName.startsWith("/") ? resourceFullName : String.format("/%s", resourceFullName); sqls.add(String.format("add jar %s%s%s", prefixPath, uploadPath, resourceFullName)); } } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.api.service.impl; import com.baomidou.mybatisplus.core.metadata.IPage; import com.baomidou.mybatisplus.extension.plugins.pagination.Page; import org.apache.dolphinscheduler.api.enums.Status; import org.apache.dolphinscheduler.api.service.TaskGroupQueueService; import org.apache.dolphinscheduler.api.service.TaskGroupService; import org.apache.dolphinscheduler.api.utils.PageInfo; import org.apache.dolphinscheduler.common.Constants;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
import org.apache.dolphinscheduler.common.enums.Flag; import org.apache.dolphinscheduler.dao.entity.TaskGroup; import org.apache.dolphinscheduler.dao.entity.User; import org.apache.dolphinscheduler.dao.mapper.TaskGroupMapper; import org.apache.dolphinscheduler.service.process.ProcessService; import org.apache.dolphinscheduler.spi.utils.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; import java.util.ArrayList; import java.util.Date; import java.util.HashMap; import java.util.List; import java.util.Map; /** * task Group Service */ @Service public class TaskGroupServiceImpl extends BaseServiceImpl implements TaskGroupService { @Autowired private TaskGroupMapper taskGroupMapper; @Autowired private TaskGroupQueueService taskGroupQueueService; @Autowired private ProcessService processService; private static final Logger logger = LoggerFactory.getLogger(TaskGroupServiceImpl.class); /** * create a Task group *
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
* @param loginUser login user * @param name task group name * @param description task group description * @param groupSize task group total size * @return the result code and msg */ @Override public Map<String, Object> createTaskGroup(User loginUser, long projectcode, String name, String description, int groupSize) { Map<String, Object> result = new HashMap<>(); if (isNotAdmin(loginUser, result)) { return result; } if (name == null) { putMsg(result, Status.NAME_NULL); return result; } if (groupSize <= 0) { putMsg(result, Status.TASK_GROUP_SIZE_ERROR); return result; } TaskGroup taskGroup1 = taskGroupMapper.queryByName(loginUser.getId(), name); if (taskGroup1 != null) { putMsg(result, Status.TASK_GROUP_NAME_EXSIT); return result; } TaskGroup taskGroup = new TaskGroup(name, projectcode, description, groupSize, loginUser.getId(), Flag.YES.getCode()); if (taskGroupMapper.insert(taskGroup) > 0) { putMsg(result, Status.SUCCESS); } else {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
putMsg(result, Status.CREATE_TASK_GROUP_ERROR); return result; } return result; } /** * update the task group * * @param loginUser login user * @param name task group name * @param description task group description * @param groupSize task group total size * @return the result code and msg */ @Override public Map<String, Object> updateTaskGroup(User loginUser, int id, String name, String description, int groupSize) { Map<String, Object> result = new HashMap<>(); if (isNotAdmin(loginUser, result)) { return result; } TaskGroup taskGroup = taskGroupMapper.selectById(id); if (taskGroup.getStatus() != Flag.YES.getCode()) { putMsg(result, Status.TASK_GROUP_STATUS_ERROR); return result; } taskGroup.setGroupSize(groupSize); taskGroup.setDescription(description); if (StringUtils.isNotEmpty(name)) { taskGroup.setName(name); }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
int i = taskGroupMapper.updateById(taskGroup); logger.info("update result:{}", i); putMsg(result, Status.SUCCESS); return result; } /** * get task group status * * @param id task group id * @return is the task group available */ @Override public boolean isTheTaskGroupAvailable(int id) { return taskGroupMapper.selectCountByIdStatus(id, Flag.YES.getCode()) == 1; } /** * query all task group by user id * * @param loginUser login user * @param pageNo page no * @param pageSize page size * @return the result code and msg */ @Override public Map<String, Object> queryAllTaskGroup(User loginUser, String name, Integer status, int pageNo, int pageSize) { return this.doQuery(loginUser, pageNo, pageSize, loginUser.getId(), name, status); } /** * query all task group by status *
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
* @param loginUser login user * @param pageNo page no * @param pageSize page size * @param status status * @return the result code and msg */ @Override public Map<String, Object> queryTaskGroupByStatus(User loginUser, int pageNo, int pageSize, int status) { return this.doQuery(loginUser, pageNo, pageSize, loginUser.getId(), null, status); } /** * query all task group by name * * @param loginUser login user * @param pageNo page no * @param pageSize page size * @param name name * @return the result code and msg */ @Override public Map<String, Object> queryTaskGroupByProjectCode(User loginUser, int pageNo, int pageSize, Long projectCode) { Map<String, Object> result = new HashMap<>(); if (isNotAdmin(loginUser, result)) { return result; } Page<TaskGroup> page = new Page<>(pageNo, pageSize); IPage<TaskGroup> taskGroupPaging = taskGroupMapper.queryTaskGroupPagingByProjectCode(page, projectCode); return getStringObjectMap(pageNo, pageSize, result, taskGroupPaging); } private Map<String, Object> getStringObjectMap(int pageNo, int pageSize, Map<String, Object> result, IPage<TaskGroup> taskGroupPaging) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
PageInfo<TaskGroup> pageInfo = new PageInfo<>(pageNo, pageSize); int total = taskGroupPaging == null ? 0 : (int) taskGroupPaging.getTotal(); List<TaskGroup> list = taskGroupPaging == null ? new ArrayList<TaskGroup>() : taskGroupPaging.getRecords(); pageInfo.setTotal(total); pageInfo.setTotalList(list); result.put(Constants.DATA_LIST, pageInfo); logger.info("select result:{}", taskGroupPaging); putMsg(result, Status.SUCCESS); return result; } /** * query all task group by id * * @param loginUser login user * @param id id * @return the result code and msg */ @Override public Map<String, Object> queryTaskGroupById(User loginUser, int id) { Map<String, Object> result = new HashMap<>(); if (isNotAdmin(loginUser, result)) { return result; } TaskGroup taskGroup = taskGroupMapper.selectById(id); result.put(Constants.DATA_LIST, taskGroup); putMsg(result, Status.SUCCESS); return result; } /** * query
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
* * @param pageNo page no * @param pageSize page size * @param userId user id * @param name name * @param status status * @return the result code and msg */ @Override public Map<String, Object> doQuery(User loginUser, int pageNo, int pageSize, int userId, String name, Integer status) { Map<String, Object> result = new HashMap<>(); if (isNotAdmin(loginUser, result)) { return result; } Page<TaskGroup> page = new Page<>(pageNo, pageSize); IPage<TaskGroup> taskGroupPaging = taskGroupMapper.queryTaskGroupPaging(page, userId, name, status); return getStringObjectMap(pageNo, pageSize, result, taskGroupPaging); } /** * close a task group * * @param loginUser login user * @param id task group id * @return the result code and msg */ @Override public Map<String, Object> closeTaskGroup(User loginUser, int id) { Map<String, Object> result = new HashMap<>(); if (isNotAdmin(loginUser, result)) { return result;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
} TaskGroup taskGroup = taskGroupMapper.selectById(id); taskGroup.setStatus(Flag.NO.getCode()); taskGroupMapper.updateById(taskGroup); putMsg(result, Status.SUCCESS); return result; } /** * start a task group * * @param loginUser login user * @param id task group id * @return the result code and msg */ @Override public Map<String, Object> startTaskGroup(User loginUser, int id) { Map<String, Object> result = new HashMap<>(); if (isNotAdmin(loginUser, result)) { return result; } TaskGroup taskGroup = taskGroupMapper.selectById(id); if (taskGroup.getStatus() == 1) { putMsg(result, Status.TASK_GROUP_STATUS_ERROR); return result; } taskGroup.setStatus(1); taskGroup.setUpdateTime(new Date(System.currentTimeMillis())); int update = taskGroupMapper.updateById(taskGroup); putMsg(result, Status.SUCCESS); return result;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
} /** * wake a task manually * * @param loginUser * @param queueId task group queue id * @return result */ @Override public Map<String, Object> forceStartTask(User loginUser, int queueId) { Map<String, Object> result = new HashMap<>(); if (isNotAdmin(loginUser, result)) { return result; } taskGroupQueueService.forceStartTask(queueId, Flag.YES.getCode()); putMsg(result, Status.SUCCESS); return result; } @Override public Map<String, Object> modifyPriority(User loginUser, Integer queueId, Integer priority) { Map<String, Object> result = new HashMap<>(); if (isNotAdmin(loginUser, result)) { return result; } taskGroupQueueService.modifyPriority(queueId, priority); putMsg(result, Status.SUCCESS); return result; } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.service.process;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
import static org.apache.dolphinscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_END_DATE; import static org.apache.dolphinscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_START_DATE; import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_EMPTY_SUB_PROCESS; import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_FATHER_PARAMS; import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING; import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS; import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_DEFINE_CODE; import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID; import static org.apache.dolphinscheduler.common.Constants.LOCAL_PARAMS; import static java.util.stream.Collectors.toSet; import org.apache.dolphinscheduler.common.Constants; import org.apache.dolphinscheduler.common.enums.AuthorizationType; import org.apache.dolphinscheduler.common.enums.CommandType; import org.apache.dolphinscheduler.common.enums.Direct; import org.apache.dolphinscheduler.common.enums.ExecutionStatus; import org.apache.dolphinscheduler.common.enums.FailureStrategy; import org.apache.dolphinscheduler.common.enums.Flag; import org.apache.dolphinscheduler.common.enums.ReleaseState; import org.apache.dolphinscheduler.common.enums.TaskDependType; import org.apache.dolphinscheduler.common.enums.TaskGroupQueueStatus; import org.apache.dolphinscheduler.common.enums.TimeoutFlag; import org.apache.dolphinscheduler.common.enums.WarningType; import org.apache.dolphinscheduler.common.graph.DAG; import org.apache.dolphinscheduler.common.model.DateInterval; import org.apache.dolphinscheduler.common.model.TaskNode; import org.apache.dolphinscheduler.common.model.TaskNodeRelation; import org.apache.dolphinscheduler.common.process.ProcessDag; import org.apache.dolphinscheduler.common.process.Property; import org.apache.dolphinscheduler.common.process.ResourceInfo; import org.apache.dolphinscheduler.common.task.AbstractParameters;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
import org.apache.dolphinscheduler.common.task.TaskTimeoutParameter; import org.apache.dolphinscheduler.common.task.subprocess.SubProcessParameters; import org.apache.dolphinscheduler.common.utils.CodeGenerateUtils; import org.apache.dolphinscheduler.common.utils.CodeGenerateUtils.CodeGenerateException; import org.apache.dolphinscheduler.common.utils.DateUtils; import org.apache.dolphinscheduler.common.utils.JSONUtils; import org.apache.dolphinscheduler.common.utils.ParameterUtils; import org.apache.dolphinscheduler.common.utils.PropertyUtils; import org.apache.dolphinscheduler.common.utils.TaskParametersUtils; import org.apache.dolphinscheduler.dao.entity.Command; import org.apache.dolphinscheduler.dao.entity.DagData; import org.apache.dolphinscheduler.dao.entity.DataSource; import org.apache.dolphinscheduler.dao.entity.Environment; import org.apache.dolphinscheduler.dao.entity.ErrorCommand; import org.apache.dolphinscheduler.dao.entity.ProcessDefinition; import org.apache.dolphinscheduler.dao.entity.ProcessDefinitionLog; import org.apache.dolphinscheduler.dao.entity.ProcessInstance; import org.apache.dolphinscheduler.dao.entity.ProcessInstanceMap; import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelation; import org.apache.dolphinscheduler.dao.entity.ProcessTaskRelationLog; import org.apache.dolphinscheduler.dao.entity.Project; import org.apache.dolphinscheduler.dao.entity.ProjectUser; import org.apache.dolphinscheduler.dao.entity.Resource; import org.apache.dolphinscheduler.dao.entity.Schedule; import org.apache.dolphinscheduler.dao.entity.TaskDefinition; import org.apache.dolphinscheduler.dao.entity.TaskDefinitionLog; import org.apache.dolphinscheduler.dao.entity.TaskGroup; import org.apache.dolphinscheduler.dao.entity.TaskGroupQueue; import org.apache.dolphinscheduler.dao.entity.TaskInstance; import org.apache.dolphinscheduler.dao.entity.Tenant;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
import org.apache.dolphinscheduler.dao.entity.UdfFunc; import org.apache.dolphinscheduler.dao.entity.User; import org.apache.dolphinscheduler.dao.mapper.CommandMapper; import org.apache.dolphinscheduler.dao.mapper.DataSourceMapper; import org.apache.dolphinscheduler.dao.mapper.EnvironmentMapper; import org.apache.dolphinscheduler.dao.mapper.ErrorCommandMapper; import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionLogMapper; import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapper; import org.apache.dolphinscheduler.dao.mapper.ProcessInstanceMapMapper; import org.apache.dolphinscheduler.dao.mapper.ProcessInstanceMapper; import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationLogMapper; import org.apache.dolphinscheduler.dao.mapper.ProcessTaskRelationMapper; import org.apache.dolphinscheduler.dao.mapper.ProjectMapper; import org.apache.dolphinscheduler.dao.mapper.ResourceMapper; import org.apache.dolphinscheduler.dao.mapper.ResourceUserMapper; import org.apache.dolphinscheduler.dao.mapper.ScheduleMapper; import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionLogMapper; import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionMapper; import org.apache.dolphinscheduler.dao.mapper.TaskGroupMapper; import org.apache.dolphinscheduler.dao.mapper.TaskGroupQueueMapper; import org.apache.dolphinscheduler.dao.mapper.TaskInstanceMapper; import org.apache.dolphinscheduler.dao.mapper.TenantMapper; import org.apache.dolphinscheduler.dao.mapper.UdfFuncMapper; import org.apache.dolphinscheduler.dao.mapper.UserMapper; import org.apache.dolphinscheduler.dao.utils.DagHelper; import org.apache.dolphinscheduler.remote.command.StateEventChangeCommand; import org.apache.dolphinscheduler.remote.command.TaskEventChangeCommand; import org.apache.dolphinscheduler.remote.processor.StateEventCallbackService; import org.apache.dolphinscheduler.remote.utils.Host; import org.apache.dolphinscheduler.service.bean.SpringApplicationContext;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
import org.apache.dolphinscheduler.service.exceptions.ServiceException; import org.apache.dolphinscheduler.service.log.LogClientService; import org.apache.dolphinscheduler.service.quartz.cron.CronUtils; import org.apache.dolphinscheduler.spi.enums.ResourceType; import org.apache.commons.collections.CollectionUtils; import org.apache.commons.lang.StringUtils; import java.util.ArrayList; import java.util.Arrays; import java.util.Date; import java.util.EnumMap; import java.util.HashMap; import java.util.HashSet; import java.util.List; import java.util.Map; import java.util.Map.Entry; import java.util.Objects; import java.util.Set; import java.util.stream.Collectors; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Component; import org.springframework.transaction.annotation.Transactional; import com.fasterxml.jackson.core.type.TypeReference; import com.fasterxml.jackson.databind.node.ObjectNode; import com.google.common.collect.Lists; /** * process relative dao that some mappers in this. */ @Component
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
public class ProcessService { private final Logger logger = LoggerFactory.getLogger(getClass()); private final int[] stateArray = new int[]{ExecutionStatus.SUBMITTED_SUCCESS.ordinal(), ExecutionStatus.RUNNING_EXECUTION.ordinal(), ExecutionStatus.DELAY_EXECUTION.ordinal(), ExecutionStatus.READY_PAUSE.ordinal(), ExecutionStatus.READY_STOP.ordinal()}; @Autowired private UserMapper userMapper; @Autowired private ProcessDefinitionMapper processDefineMapper; @Autowired private ProcessDefinitionLogMapper processDefineLogMapper; @Autowired private ProcessInstanceMapper processInstanceMapper; @Autowired
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
private DataSourceMapper dataSourceMapper; @Autowired private ProcessInstanceMapMapper processInstanceMapMapper; @Autowired private TaskInstanceMapper taskInstanceMapper; @Autowired private CommandMapper commandMapper; @Autowired private ScheduleMapper scheduleMapper; @Autowired private UdfFuncMapper udfFuncMapper; @Autowired private ResourceMapper resourceMapper; @Autowired private ResourceUserMapper resourceUserMapper; @Autowired private ErrorCommandMapper errorCommandMapper; @Autowired private TenantMapper tenantMapper; @Autowired private ProjectMapper projectMapper; @Autowired private TaskDefinitionMapper taskDefinitionMapper; @Autowired private TaskDefinitionLogMapper taskDefinitionLogMapper; @Autowired private ProcessTaskRelationMapper processTaskRelationMapper; @Autowired private ProcessTaskRelationLogMapper processTaskRelationLogMapper; @Autowired
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
StateEventCallbackService stateEventCallbackService; @Autowired private EnvironmentMapper environmentMapper; @Autowired private TaskGroupQueueMapper taskGroupQueueMapper; @Autowired private TaskGroupMapper taskGroupMapper; /** * handle Command (construct ProcessInstance from Command) , wrapped in transaction * * @param logger logger * @param host host * @param command found command * @return process instance */ @Transactional public ProcessInstance handleCommand(Logger logger, String host, Command command) { ProcessInstance processInstance = constructProcessInstance(command, host); if (processInstance == null) { logger.error("scan command, command parameter is error: {}", command); moveToErrorCommand(command, "process instance is null"); return null; } processInstance.setCommandType(command.getCommandType()); processInstance.addHistoryCmd(command.getCommandType()); ProcessDefinition processDefinition = this.findProcessDefinition(processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion()); if (processDefinition.getExecutionType().typeIsSerial()) { saveSerialProcess(processInstance, processDefinition);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
if (processInstance.getState() != ExecutionStatus.SUBMITTED_SUCCESS) { setSubProcessParam(processInstance); deleteCommandWithCheck(command.getId()); return null; } } else { saveProcessInstance(processInstance); } setSubProcessParam(processInstance); deleteCommandWithCheck(command.getId()); return processInstance; } private void saveSerialProcess(ProcessInstance processInstance, ProcessDefinition processDefinition) { processInstance.setState(ExecutionStatus.SERIAL_WAIT); saveProcessInstance(processInstance); if (processDefinition.getExecutionType().typeIsSerialWait()) { while (true) { List<ProcessInstance> runningProcessInstances = this.processInstanceMapper.queryByProcessDefineCodeAndStatusAndNextId(processInstance.getProcessDefinitionCode(), Constants.RUNNING_PROCESS_STATE, processInstance.getId()); if (CollectionUtils.isEmpty(runningProcessInstances)) { processInstance.setState(ExecutionStatus.SUBMITTED_SUCCESS); saveProcessInstance(processInstance); return; } ProcessInstance runningProcess = runningProcessInstances.get(0); if (this.processInstanceMapper.updateNextProcessIdById(processInstance.getId(), runningProcess.getId())) { return; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} } else if (processDefinition.getExecutionType().typeIsSerialDiscard()) { List<ProcessInstance> runningProcessInstances = this.processInstanceMapper.queryByProcessDefineCodeAndStatusAndNextId(processInstance.getProcessDefinitionCode(), Constants.RUNNING_PROCESS_STATE, processInstance.getId()); if (CollectionUtils.isEmpty(runningProcessInstances)) { processInstance.setState(ExecutionStatus.STOP); saveProcessInstance(processInstance); } } else if (processDefinition.getExecutionType().typeIsSerialPriority()) { List<ProcessInstance> runningProcessInstances = this.processInstanceMapper.queryByProcessDefineCodeAndStatusAndNextId(processInstance.getProcessDefinitionCode(), Constants.RUNNING_PROCESS_STATE, processInstance.getId()); if (CollectionUtils.isNotEmpty(runningProcessInstances)) { for (ProcessInstance info : runningProcessInstances) { info.setCommandType(CommandType.STOP); info.addHistoryCmd(CommandType.STOP); info.setState(ExecutionStatus.READY_STOP); int update = updateProcessInstance(info); if (update > 0) { String host = info.getHost(); String address = host.split(":")[0]; int port = Integer.parseInt(host.split(":")[1]); StateEventChangeCommand stateEventChangeCommand = new StateEventChangeCommand( info.getId(), 0, info.getState(), info.getId(), 0 ); try { stateEventCallbackService.sendResult(address, port, stateEventChangeCommand.convert2Command()); } catch (Exception e) { logger.error("sendResultError"); }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} } } } } /** * save error command, and delete original command * * @param command command * @param message message */ public void moveToErrorCommand(Command command, String message) { ErrorCommand errorCommand = new ErrorCommand(command, message); this.errorCommandMapper.insert(errorCommand); this.commandMapper.deleteById(command.getId()); } /** * set process waiting thread * * @param command command * @param processInstance processInstance * @return process instance */ private ProcessInstance setWaitingThreadProcess(Command command, ProcessInstance processInstance) { processInstance.setState(ExecutionStatus.WAITING_THREAD); if (command.getCommandType() != CommandType.RECOVER_WAITING_THREAD) { processInstance.addHistoryCmd(command.getCommandType()); } saveProcessInstance(processInstance); this.setSubProcessParam(processInstance);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
createRecoveryWaitingThreadCommand(command, processInstance); return null; } /** * insert one command * * @param command command * @return create result */ public int createCommand(Command command) { int result = 0; if (command != null) { result = commandMapper.insert(command); } return result; } /** * get command page */ public List<Command> findCommandPage(int pageSize, int pageNumber) { return commandMapper.queryCommandPage(pageSize, pageNumber * pageSize); } /** * check the input command exists in queue list * * @param command command * @return create command result */ public boolean verifyIsNeedCreateCommand(Command command) { boolean isNeedCreate = true;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
EnumMap<CommandType, Integer> cmdTypeMap = new EnumMap<>(CommandType.class); cmdTypeMap.put(CommandType.REPEAT_RUNNING, 1); cmdTypeMap.put(CommandType.RECOVER_SUSPENDED_PROCESS, 1); cmdTypeMap.put(CommandType.START_FAILURE_TASK_PROCESS, 1); CommandType commandType = command.getCommandType(); if (cmdTypeMap.containsKey(commandType)) { ObjectNode cmdParamObj = JSONUtils.parseObject(command.getCommandParam()); int processInstanceId = cmdParamObj.path(CMD_PARAM_RECOVER_PROCESS_ID_STRING).asInt(); List<Command> commands = commandMapper.selectList(null); for (Command tmpCommand : commands) { if (cmdTypeMap.containsKey(tmpCommand.getCommandType())) { ObjectNode tempObj = JSONUtils.parseObject(tmpCommand.getCommandParam()); if (tempObj != null && processInstanceId == tempObj.path(CMD_PARAM_RECOVER_PROCESS_ID_STRING).asInt()) { isNeedCreate = false; break; } } } } return isNeedCreate; } /** * find process instance detail by id * * @param processId processId * @return process instance */ public ProcessInstance findProcessInstanceDetailById(int processId) { return processInstanceMapper.queryDetailById(processId);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} /** * get task node list by definitionId */ public List<TaskDefinition> getTaskNodeListByDefinition(long defineCode) { ProcessDefinition processDefinition = processDefineMapper.queryByCode(defineCode); if (processDefinition == null) { logger.error("process define not exists"); return Lists.newArrayList(); } List<ProcessTaskRelationLog> processTaskRelations = processTaskRelationLogMapper.queryByProcessCodeAndVersion(processDefinition.getCode(), processDefinition.getVersion()); Set<TaskDefinition> taskDefinitionSet = new HashSet<>(); for (ProcessTaskRelationLog processTaskRelation : processTaskRelations) { if (processTaskRelation.getPostTaskCode() > 0) { taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPostTaskCode(), processTaskRelation.getPostTaskVersion())); } } if (taskDefinitionSet.isEmpty()) { return Lists.newArrayList(); } List<TaskDefinitionLog> taskDefinitionLogs = taskDefinitionLogMapper.queryByTaskDefinitions(taskDefinitionSet); return Lists.newArrayList(taskDefinitionLogs); } /** * find process instance by id * * @param processId processId * @return process instance */ public ProcessInstance findProcessInstanceById(int processId) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
return processInstanceMapper.selectById(processId); } /** * find process define by id. * * @param processDefinitionId processDefinitionId * @return process definition */ public ProcessDefinition findProcessDefineById(int processDefinitionId) { return processDefineMapper.selectById(processDefinitionId); } /** * find process define by code and version. * * @param processDefinitionCode processDefinitionCode * @return process definition */ public ProcessDefinition findProcessDefinition(Long processDefinitionCode, int version) { ProcessDefinition processDefinition = processDefineMapper.queryByCode(processDefinitionCode); if (processDefinition == null || processDefinition.getVersion() != version) { processDefinition = processDefineLogMapper.queryByDefinitionCodeAndVersion(processDefinitionCode, version); if (processDefinition != null) { processDefinition.setId(0); } } return processDefinition; } /** * find process define by code. *
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* @param processDefinitionCode processDefinitionCode * @return process definition */ public ProcessDefinition findProcessDefinitionByCode(Long processDefinitionCode) { return processDefineMapper.queryByCode(processDefinitionCode); } /** * delete work process instance by id * * @param processInstanceId processInstanceId * @return delete process instance result */ public int deleteWorkProcessInstanceById(int processInstanceId) { return processInstanceMapper.deleteById(processInstanceId); } /** * delete all sub process by parent instance id * * @param processInstanceId processInstanceId * @return delete all sub process instance result */ public int deleteAllSubWorkProcessByParentId(int processInstanceId) { List<Integer> subProcessIdList = processInstanceMapMapper.querySubIdListByParentId(processInstanceId); for (Integer subId : subProcessIdList) { deleteAllSubWorkProcessByParentId(subId); deleteWorkProcessMapByParentId(subId); removeTaskLogFile(subId); deleteWorkProcessInstanceById(subId); } return 1;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} /** * remove task log file * * @param processInstanceId processInstanceId */ public void removeTaskLogFile(Integer processInstanceId) { List<TaskInstance> taskInstanceList = findValidTaskListByProcessId(processInstanceId); if (CollectionUtils.isEmpty(taskInstanceList)) { return; } try (LogClientService logClient = new LogClientService()) { for (TaskInstance taskInstance : taskInstanceList) { String taskLogPath = taskInstance.getLogPath(); if (StringUtils.isEmpty(taskInstance.getHost())) { continue; } int port = PropertyUtils.getInt(Constants.RPC_PORT, 50051); String ip = ""; try { ip = Host.of(taskInstance.getHost()).getIp(); } catch (Exception e) { ip = taskInstance.getHost(); } logClient.removeTaskLog(ip, port, taskLogPath); } } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
/** * recursive query sub process definition id by parent id. * * @param parentCode parentCode * @param ids ids */ public void recurseFindSubProcess(long parentCode, List<Long> ids) { List<TaskDefinition> taskNodeList = this.getTaskNodeListByDefinition(parentCode); if (taskNodeList != null && !taskNodeList.isEmpty()) { for (TaskDefinition taskNode : taskNodeList) { String parameter = taskNode.getTaskParams(); ObjectNode parameterJson = JSONUtils.parseObject(parameter); if (parameterJson.get(CMD_PARAM_SUB_PROCESS_DEFINE_CODE) != null) { SubProcessParameters subProcessParam = JSONUtils.parseObject(parameter, SubProcessParameters.class); ids.add(subProcessParam.getProcessDefinitionCode()); recurseFindSubProcess(subProcessParam.getProcessDefinitionCode(), ids); } } } } /** * create recovery waiting thread command when thread pool is not enough for the process instance. * sub work process instance need not to create recovery command. * create recovery waiting thread command and delete origin command at the same time. * if the recovery command is exists, only update the field update_time * * @param originCommand originCommand * @param processInstance processInstance */ public void createRecoveryWaitingThreadCommand(Command originCommand, ProcessInstance processInstance) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
if (processInstance.getIsSubProcess() == Flag.YES) { if (originCommand != null) { commandMapper.deleteById(originCommand.getId()); } return; } Map<String, String> cmdParam = new HashMap<>(); cmdParam.put(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD, String.valueOf(processInstance.getId())); if (originCommand == null) { Command command = new Command( CommandType.RECOVER_WAITING_THREAD, processInstance.getTaskDependType(), processInstance.getFailureStrategy(), processInstance.getExecutorId(), processInstance.getProcessDefinition().getCode(), JSONUtils.toJsonString(cmdParam), processInstance.getWarningType(), processInstance.getWarningGroupId(), processInstance.getScheduleTime(), processInstance.getWorkerGroup(), processInstance.getEnvironmentCode(), processInstance.getProcessInstancePriority(), processInstance.getDryRun(), processInstance.getId(), processInstance.getProcessDefinitionVersion() ); saveCommand(command); return;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} if (originCommand.getCommandType() == CommandType.RECOVER_WAITING_THREAD) { originCommand.setUpdateTime(new Date()); saveCommand(originCommand); } else { commandMapper.deleteById(originCommand.getId()); originCommand.setId(0); originCommand.setCommandType(CommandType.RECOVER_WAITING_THREAD); originCommand.setUpdateTime(new Date()); originCommand.setCommandParam(JSONUtils.toJsonString(cmdParam)); originCommand.setProcessInstancePriority(processInstance.getProcessInstancePriority()); saveCommand(originCommand); } } /** * get schedule time from command * * @param command command * @param cmdParam cmdParam map * @return date */ private Date getScheduleTime(Command command, Map<String, String> cmdParam) { Date scheduleTime = command.getScheduleTime(); if (scheduleTime == null && cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) { Date start = DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE)); Date end = DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE));
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
List<Schedule> schedules = queryReleaseSchedulerListByProcessDefinitionCode(command.getProcessDefinitionCode()); List<Date> complementDateList = CronUtils.getSelfFireDateList(start, end, schedules); if (complementDateList.size() > 0) { scheduleTime = complementDateList.get(0); } else { logger.error("set scheduler time error: complement date list is empty, command: {}", command.toString()); } } return scheduleTime; } /** * generate a new work process instance from command. * * @param processDefinition processDefinition * @param command command * @param cmdParam cmdParam map * @return process instance */ private ProcessInstance generateNewProcessInstance(ProcessDefinition processDefinition, Command command, Map<String, String> cmdParam) { ProcessInstance processInstance = new ProcessInstance(processDefinition); processInstance.setProcessDefinitionCode(processDefinition.getCode()); processInstance.setProcessDefinitionVersion(processDefinition.getVersion()); processInstance.setState(ExecutionStatus.RUNNING_EXECUTION); processInstance.setRecovery(Flag.NO); processInstance.setStartTime(new Date()); processInstance.setRestartTime(processInstance.getStartTime()); processInstance.setRunTimes(1);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
processInstance.setMaxTryTimes(0); processInstance.setCommandParam(command.getCommandParam()); processInstance.setCommandType(command.getCommandType()); processInstance.setIsSubProcess(Flag.NO); processInstance.setTaskDependType(command.getTaskDependType()); processInstance.setFailureStrategy(command.getFailureStrategy()); processInstance.setExecutorId(command.getExecutorId()); WarningType warningType = command.getWarningType() == null ? WarningType.NONE : command.getWarningType(); processInstance.setWarningType(warningType); Integer warningGroupId = command.getWarningGroupId() == null ? 0 : command.getWarningGroupId(); processInstance.setWarningGroupId(warningGroupId); processInstance.setDryRun(command.getDryRun()); if (command.getScheduleTime() != null) { processInstance.setScheduleTime(command.getScheduleTime()); } processInstance.setCommandStartTime(command.getStartTime()); processInstance.setLocations(processDefinition.getLocations()); setGlobalParamIfCommanded(processDefinition, cmdParam); processInstance.setGlobalParams(ParameterUtils.curingGlobalParams( processDefinition.getGlobalParamMap(), processDefinition.getGlobalParamList(), getCommandTypeIfComplement(processInstance, command), processInstance.getScheduleTime())); processInstance.setProcessInstancePriority(command.getProcessInstancePriority()); String workerGroup = StringUtils.isBlank(command.getWorkerGroup()) ? Constants.DEFAULT_WORKER_GROUP : command.getWorkerGroup(); processInstance.setWorkerGroup(workerGroup); processInstance.setEnvironmentCode(Objects.isNull(command.getEnvironmentCode()) ? -1 : command.getEnvironmentCode());
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
processInstance.setTimeout(processDefinition.getTimeout()); processInstance.setTenantId(processDefinition.getTenantId()); return processInstance; } private void setGlobalParamIfCommanded(ProcessDefinition processDefinition, Map<String, String> cmdParam) { Map<String, String> startParamMap = new HashMap<>(); if (cmdParam != null && cmdParam.containsKey(Constants.CMD_PARAM_START_PARAMS)) { String startParamJson = cmdParam.get(Constants.CMD_PARAM_START_PARAMS); startParamMap = JSONUtils.toMap(startParamJson); } Map<String, String> fatherParamMap = new HashMap<>(); if (cmdParam != null && cmdParam.containsKey(Constants.CMD_PARAM_FATHER_PARAMS)) { String fatherParamJson = cmdParam.get(Constants.CMD_PARAM_FATHER_PARAMS); fatherParamMap = JSONUtils.toMap(fatherParamJson); } startParamMap.putAll(fatherParamMap); if (startParamMap.size() > 0 && processDefinition.getGlobalParamMap() != null) { for (Map.Entry<String, String> param : processDefinition.getGlobalParamMap().entrySet()) { String val = startParamMap.get(param.getKey()); if (val != null) { param.setValue(val); } } } } /** * get process tenant
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* there is tenant id in definition, use the tenant of the definition. * if there is not tenant id in the definiton or the tenant not exist * use definition creator's tenant. * * @param tenantId tenantId * @param userId userId * @return tenant */ public Tenant getTenantForProcess(int tenantId, int userId) { Tenant tenant = null; if (tenantId >= 0) { tenant = tenantMapper.queryById(tenantId); } if (userId == 0) { return null; } if (tenant == null) { User user = userMapper.selectById(userId); tenant = tenantMapper.queryById(user.getTenantId()); } return tenant; } /** * get an environment * use the code of the environment to find a environment. * * @param environmentCode environmentCode * @return Environment */ public Environment findEnvironmentByCode(Long environmentCode) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
Environment environment = null; if (environmentCode >= 0) { environment = environmentMapper.queryByEnvironmentCode(environmentCode); } return environment; } /** * check command parameters is valid * * @param command command * @param cmdParam cmdParam map * @return whether command param is valid */ private Boolean checkCmdParam(Command command, Map<String, String> cmdParam) { if (command.getTaskDependType() == TaskDependType.TASK_ONLY || command.getTaskDependType() == TaskDependType.TASK_PRE) { if (cmdParam == null || !cmdParam.containsKey(Constants.CMD_PARAM_START_NODES) || cmdParam.get(Constants.CMD_PARAM_START_NODES).isEmpty()) { logger.error("command node depend type is {}, but start nodes is null ", command.getTaskDependType()); return false; } } return true; } /** * construct process instance according to one command. * * @param command command * @param host host * @return process instance
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
*/ private ProcessInstance constructProcessInstance(Command command, String host) { ProcessInstance processInstance; ProcessDefinition processDefinition; CommandType commandType = command.getCommandType(); processDefinition = this.findProcessDefinition(command.getProcessDefinitionCode(), command.getProcessDefinitionVersion()); if (processDefinition == null) { logger.error("cannot find the work process define! define code : {}", command.getProcessDefinitionCode()); return null; } Map<String, String> cmdParam = JSONUtils.toMap(command.getCommandParam()); int processInstanceId = command.getProcessInstanceId(); if (processInstanceId == 0) { processInstance = generateNewProcessInstance(processDefinition, command, cmdParam); } else { processInstance = this.findProcessInstanceDetailById(processInstanceId); if (processInstance == null) { return processInstance; } } if (cmdParam != null) { CommandType commandTypeIfComplement = getCommandTypeIfComplement(processInstance, command); if (commandTypeIfComplement == CommandType.REPEAT_RUNNING) { setGlobalParamIfCommanded(processDefinition, cmdParam); } processInstance.setGlobalParams(ParameterUtils.curingGlobalParams( processDefinition.getGlobalParamMap(), processDefinition.getGlobalParamList(),
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
commandTypeIfComplement, processInstance.getScheduleTime())); processInstance.setProcessDefinition(processDefinition); } if (processInstance.getCommandParam() != null) { Map<String, String> processCmdParam = JSONUtils.toMap(processInstance.getCommandParam()); for (Map.Entry<String, String> entry : processCmdParam.entrySet()) { if (!cmdParam.containsKey(entry.getKey())) { cmdParam.put(entry.getKey(), entry.getValue()); } } } if (cmdParam != null && cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) { processInstance.setCommandParam(command.getCommandParam()); } if (Boolean.FALSE.equals(checkCmdParam(command, cmdParam))) { logger.error("command parameter check failed!"); return null; } if (command.getScheduleTime() != null) { processInstance.setScheduleTime(command.getScheduleTime()); } processInstance.setHost(host); processInstance.setRestartTime(new Date()); ExecutionStatus runStatus = ExecutionStatus.RUNNING_EXECUTION; int runTime = processInstance.getRunTimes(); switch (commandType) { case START_PROCESS:
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
break; case START_FAILURE_TASK_PROCESS: List<Integer> failedList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.FAILURE); List<Integer> toleranceList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.NEED_FAULT_TOLERANCE); List<Integer> killedList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.KILL); cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING); failedList.addAll(killedList); failedList.addAll(toleranceList); for (Integer taskId : failedList) { initTaskInstance(this.findTaskInstanceById(taskId)); } cmdParam.put(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING, String.join(Constants.COMMA, convertIntListToString(failedList))); processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam)); processInstance.setRunTimes(runTime + 1); break; case START_CURRENT_TASK_PROCESS: break; case RECOVER_WAITING_THREAD: break; case RECOVER_SUSPENDED_PROCESS: cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING); List<Integer> suspendedNodeList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.PAUSE); List<Integer> stopNodeList = findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.KILL); suspendedNodeList.addAll(stopNodeList); for (Integer taskId : suspendedNodeList) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
initTaskInstance(this.findTaskInstanceById(taskId)); } cmdParam.put(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING, String.join(",", convertIntListToString(suspendedNodeList))); processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam)); processInstance.setRunTimes(runTime + 1); break; case RECOVER_TOLERANCE_FAULT_PROCESS: processInstance.setRecovery(Flag.YES); runStatus = processInstance.getState(); break; case COMPLEMENT_DATA: if (processInstance.getId() != 0) { List<TaskInstance> taskInstanceList = this.findValidTaskListByProcessId(processInstance.getId()); for (TaskInstance taskInstance : taskInstanceList) { taskInstance.setFlag(Flag.NO); this.updateTaskInstance(taskInstance); } } break; case REPEAT_RUNNING: if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING)) { cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING); processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam)); } List<TaskInstance> validTaskList = findValidTaskListByProcessId(processInstance.getId()); for (TaskInstance taskInstance : validTaskList) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
taskInstance.setFlag(Flag.NO); updateTaskInstance(taskInstance); } processInstance.setStartTime(new Date()); processInstance.setRestartTime(processInstance.getStartTime()); processInstance.setEndTime(null); processInstance.setRunTimes(runTime + 1); initComplementDataParam(processDefinition, processInstance, cmdParam); break; case SCHEDULER: break; default: break; } processInstance.setState(runStatus); return processInstance; } /** * get process definition by command * If it is a fault-tolerant command, get the specified version of ProcessDefinition through ProcessInstance * Otherwise, get the latest version of ProcessDefinition * * @return ProcessDefinition */ private ProcessDefinition getProcessDefinitionByCommand(long processDefinitionCode, Map<String, String> cmdParam) { if (cmdParam != null) { int processInstanceId = 0; if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING)) { processInstanceId = Integer.parseInt(cmdParam.get(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING)); } else if (cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
processInstanceId = Integer.parseInt(cmdParam.get(Constants.CMD_PARAM_SUB_PROCESS)); } else if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD)) { processInstanceId = Integer.parseInt(cmdParam.get(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD)); } if (processInstanceId != 0) { ProcessInstance processInstance = this.findProcessInstanceDetailById(processInstanceId); if (processInstance == null) { return null; } return processDefineLogMapper.queryByDefinitionCodeAndVersion( processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion()); } } return processDefineMapper.queryByCode(processDefinitionCode); } /** * return complement data if the process start with complement data * * @param processInstance processInstance * @param command command * @return command type */ private CommandType getCommandTypeIfComplement(ProcessInstance processInstance, Command command) { if (CommandType.COMPLEMENT_DATA == processInstance.getCmdTypeIfComplement()) { return CommandType.COMPLEMENT_DATA; } else { return command.getCommandType(); } } /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* initialize complement data parameters * * @param processDefinition processDefinition * @param processInstance processInstance * @param cmdParam cmdParam */ private void initComplementDataParam(ProcessDefinition processDefinition, ProcessInstance processInstance, Map<String, String> cmdParam) { if (!processInstance.isComplementData()) { return; } Date start = DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE)); Date end = DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE)); List<Schedule> listSchedules = queryReleaseSchedulerListByProcessDefinitionCode(processInstance.getProcessDefinitionCode()); List<Date> complementDate = CronUtils.getSelfFireDateList(start, end, listSchedules); if (complementDate.size() > 0 && Flag.NO == processInstance.getIsSubProcess()) { processInstance.setScheduleTime(complementDate.get(0)); } processInstance.setGlobalParams(ParameterUtils.curingGlobalParams( processDefinition.getGlobalParamMap(), processDefinition.getGlobalParamList(), CommandType.COMPLEMENT_DATA, processInstance.getScheduleTime())); } /** * set sub work process parameters. * handle sub work process instance, update relation table and command parameters * set sub work process flag, extends parent work process command parameters *
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* @param subProcessInstance subProcessInstance */ public void setSubProcessParam(ProcessInstance subProcessInstance) { String cmdParam = subProcessInstance.getCommandParam(); if (StringUtils.isEmpty(cmdParam)) { return; } Map<String, String> paramMap = JSONUtils.toMap(cmdParam); if (paramMap.containsKey(CMD_PARAM_SUB_PROCESS) && CMD_PARAM_EMPTY_SUB_PROCESS.equals(paramMap.get(CMD_PARAM_SUB_PROCESS))) { paramMap.remove(CMD_PARAM_SUB_PROCESS); paramMap.put(CMD_PARAM_SUB_PROCESS, String.valueOf(subProcessInstance.getId())); subProcessInstance.setCommandParam(JSONUtils.toJsonString(paramMap)); subProcessInstance.setIsSubProcess(Flag.YES); this.saveProcessInstance(subProcessInstance); } String parentInstanceId = paramMap.get(CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID); if (StringUtils.isNotEmpty(parentInstanceId)) { ProcessInstance parentInstance = findProcessInstanceDetailById(Integer.parseInt(parentInstanceId)); if (parentInstance != null) { subProcessInstance.setGlobalParams( joinGlobalParams(parentInstance.getGlobalParams(), subProcessInstance.getGlobalParams())); this.saveProcessInstance(subProcessInstance); } else { logger.error("sub process command params error, cannot find parent instance: {} ", cmdParam); } } ProcessInstanceMap processInstanceMap = JSONUtils.parseObject(cmdParam, ProcessInstanceMap.class);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
if (processInstanceMap == null || processInstanceMap.getParentProcessInstanceId() == 0) { return; } processInstanceMap.setProcessInstanceId(subProcessInstance.getId()); this.updateWorkProcessInstanceMap(processInstanceMap); } /** * join parent global params into sub process. * only the keys doesn't in sub process global would be joined. * * @param parentGlobalParams parentGlobalParams * @param subGlobalParams subGlobalParams * @return global params join */ private String joinGlobalParams(String parentGlobalParams, String subGlobalParams) { List<Property> parentPropertyList = JSONUtils.toList(parentGlobalParams, Property.class); List<Property> subPropertyList = JSONUtils.toList(subGlobalParams, Property.class); Map<String, String> subMap = subPropertyList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue)); for (Property parent : parentPropertyList) { if (!subMap.containsKey(parent.getProp())) { subPropertyList.add(parent); } } return JSONUtils.toJsonString(subPropertyList); } /** * initialize task instance * * @param taskInstance taskInstance
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
*/ private void initTaskInstance(TaskInstance taskInstance) { if (!taskInstance.isSubProcess() && (taskInstance.getState().typeIsCancel() || taskInstance.getState().typeIsFailure())) { taskInstance.setFlag(Flag.NO); updateTaskInstance(taskInstance); return; } taskInstance.setState(ExecutionStatus.SUBMITTED_SUCCESS); updateTaskInstance(taskInstance); } /** * retry submit task to db */ public TaskInstance submitTaskWithRetry(ProcessInstance processInstance, TaskInstance taskInstance, int commitRetryTimes, int commitInterval) { int retryTimes = 1; TaskInstance task = null; while (retryTimes <= commitRetryTimes) { try { task = SpringApplicationContext.getBean(ProcessService.class).submitTask(processInstance, taskInstance); if (task != null && task.getId() != 0) { break; } logger.error("task commit to db failed , taskId {} has already retry {} times, please check the database", taskInstance.getId(), retryTimes); Thread.sleep(commitInterval); } catch (Exception e) { logger.error("task commit to mysql failed", e); } retryTimes += 1;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} return task; } /** * submit task to db * submit sub process to command * * @param processInstance processInstance * @param taskInstance taskInstance * @return task instance */ @Transactional(rollbackFor = Exception.class) public TaskInstance submitTask(ProcessInstance processInstance, TaskInstance taskInstance) { logger.info("start submit task : {}, instance id:{}, state: {}", taskInstance.getName(), taskInstance.getProcessInstanceId(), processInstance.getState()); TaskInstance task = submitTaskInstanceToDB(taskInstance, processInstance); if (task == null) { logger.error("end submit task to db error, task name:{}, process id:{} state: {} ", taskInstance.getName(), taskInstance.getProcessInstance(), processInstance.getState()); return null; } if (!task.getState().typeIsFinished()) { createSubWorkProcess(processInstance, task); } logger.info("end submit task to db successfully:{} {} state:{} complete, instance id:{} state: {} ", taskInstance.getId(), taskInstance.getName(), task.getState(), processInstance.getId(), processInstance.getState()); return task; } /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* set work process instance map * consider o * repeat running does not generate new sub process instance * set map {parent instance id, task instance id, 0(child instance id)} * * @param parentInstance parentInstance * @param parentTask parentTask * @return process instance map */ private ProcessInstanceMap setProcessInstanceMap(ProcessInstance parentInstance, TaskInstance parentTask) { ProcessInstanceMap processMap = findWorkProcessMapByParent(parentInstance.getId(), parentTask.getId()); if (processMap != null) { return processMap; } if (parentInstance.getCommandType() == CommandType.REPEAT_RUNNING) { processMap = findPreviousTaskProcessMap(parentInstance, parentTask); if (processMap != null) { processMap.setParentTaskInstanceId(parentTask.getId()); updateWorkProcessInstanceMap(processMap); return processMap; } } processMap = new ProcessInstanceMap(); processMap.setParentProcessInstanceId(parentInstance.getId()); processMap.setParentTaskInstanceId(parentTask.getId()); createWorkProcessInstanceMap(processMap); return processMap; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
/** * find previous task work process map. * * @param parentProcessInstance parentProcessInstance * @param parentTask parentTask * @return process instance map */ private ProcessInstanceMap findPreviousTaskProcessMap(ProcessInstance parentProcessInstance, TaskInstance parentTask) { Integer preTaskId = 0; List<TaskInstance> preTaskList = this.findPreviousTaskListByWorkProcessId(parentProcessInstance.getId()); for (TaskInstance task : preTaskList) { if (task.getName().equals(parentTask.getName())) { preTaskId = task.getId(); ProcessInstanceMap map = findWorkProcessMapByParent(parentProcessInstance.getId(), preTaskId); if (map != null) { return map; } } } logger.info("sub process instance is not found,parent task:{},parent instance:{}", parentTask.getId(), parentProcessInstance.getId()); return null; } /** * create sub work process command * * @param parentProcessInstance parentProcessInstance * @param task task */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
public void createSubWorkProcess(ProcessInstance parentProcessInstance, TaskInstance task) { if (!task.isSubProcess()) { return; } ProcessInstanceMap instanceMap = findWorkProcessMapByParent(parentProcessInstance.getId(), task.getId()); if (null != instanceMap && CommandType.RECOVER_TOLERANCE_FAULT_PROCESS == parentProcessInstance.getCommandType()) { return; } instanceMap = setProcessInstanceMap(parentProcessInstance, task); ProcessInstance childInstance = null; if (instanceMap.getProcessInstanceId() != 0) { childInstance = findProcessInstanceById(instanceMap.getProcessInstanceId()); } Command subProcessCommand = createSubProcessCommand(parentProcessInstance, childInstance, instanceMap, task); updateSubProcessDefinitionByParent(parentProcessInstance, subProcessCommand.getProcessDefinitionCode()); initSubInstanceState(childInstance); createCommand(subProcessCommand); logger.info("sub process command created: {} ", subProcessCommand); } /** * complement data needs transform parent parameter to child. */ private String getSubWorkFlowParam(ProcessInstanceMap instanceMap, ProcessInstance parentProcessInstance, Map<String, String> fatherParams) { String processMapStr = JSONUtils.toJsonString(instanceMap); Map<String, String> cmdParam = JSONUtils.toMap(processMapStr); if (parentProcessInstance.isComplementData()) { Map<String, String> parentParam = JSONUtils.toMap(parentProcessInstance.getCommandParam());
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
String endTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE); String startTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE); cmdParam.put(CMDPARAM_COMPLEMENT_DATA_END_DATE, endTime); cmdParam.put(CMDPARAM_COMPLEMENT_DATA_START_DATE, startTime); processMapStr = JSONUtils.toJsonString(cmdParam); } if (fatherParams.size() != 0) { cmdParam.put(CMD_PARAM_FATHER_PARAMS, JSONUtils.toJsonString(fatherParams)); processMapStr = JSONUtils.toJsonString(cmdParam); } return processMapStr; } public Map<String, String> getGlobalParamMap(String globalParams) { List<Property> propList; Map<String, String> globalParamMap = new HashMap<>(); if (StringUtils.isNotEmpty(globalParams)) { propList = JSONUtils.toList(globalParams, Property.class); globalParamMap = propList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue)); } return globalParamMap; } /** * create sub work process command */ public Command createSubProcessCommand(ProcessInstance parentProcessInstance, ProcessInstance childInstance, ProcessInstanceMap instanceMap, TaskInstance task) { CommandType commandType = getSubCommandType(parentProcessInstance, childInstance); Map<String, String> subProcessParam = JSONUtils.toMap(task.getTaskParams());
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
long childDefineCode = 0L; if (subProcessParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS_DEFINE_CODE)) { childDefineCode = Long.parseLong(subProcessParam.get(Constants.CMD_PARAM_SUB_PROCESS_DEFINE_CODE)); } ProcessDefinition subProcessDefinition = processDefineMapper.queryByCode(childDefineCode); Object localParams = subProcessParam.get(Constants.LOCAL_PARAMS); List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class); Map<String, String> globalMap = this.getGlobalParamMap(parentProcessInstance.getGlobalParams()); Map<String, String> fatherParams = new HashMap<>(); if (CollectionUtils.isNotEmpty(allParam)) { for (Property info : allParam) { fatherParams.put(info.getProp(), globalMap.get(info.getProp())); } } String processParam = getSubWorkFlowParam(instanceMap, parentProcessInstance, fatherParams); int subProcessInstanceId = childInstance == null ? 0 : childInstance.getId(); return new Command( commandType, TaskDependType.TASK_POST, parentProcessInstance.getFailureStrategy(), parentProcessInstance.getExecutorId(), subProcessDefinition.getCode(), processParam, parentProcessInstance.getWarningType(), parentProcessInstance.getWarningGroupId(), parentProcessInstance.getScheduleTime(), task.getWorkerGroup(), task.getEnvironmentCode(), parentProcessInstance.getProcessInstancePriority(), parentProcessInstance.getDryRun(),
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
subProcessInstanceId, subProcessDefinition.getVersion() ); } /** * initialize sub work flow state * child instance state would be initialized when 'recovery from pause/stop/failure' */ private void initSubInstanceState(ProcessInstance childInstance) { if (childInstance != null) { childInstance.setState(ExecutionStatus.RUNNING_EXECUTION); updateProcessInstance(childInstance); } } /** * get sub work flow command type * child instance exist: child command = fatherCommand * child instance not exists: child command = fatherCommand[0] */ private CommandType getSubCommandType(ProcessInstance parentProcessInstance, ProcessInstance childInstance) { CommandType commandType = parentProcessInstance.getCommandType(); if (childInstance == null) { String fatherHistoryCommand = parentProcessInstance.getHistoryCmd(); commandType = CommandType.valueOf(fatherHistoryCommand.split(Constants.COMMA)[0]); } return commandType; } /** * update sub process definition *
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* @param parentProcessInstance parentProcessInstance * @param childDefinitionCode childDefinitionId */ private void updateSubProcessDefinitionByParent(ProcessInstance parentProcessInstance, long childDefinitionCode) { ProcessDefinition fatherDefinition = this.findProcessDefinition(parentProcessInstance.getProcessDefinitionCode(), parentProcessInstance.getProcessDefinitionVersion()); ProcessDefinition childDefinition = this.findProcessDefinitionByCode(childDefinitionCode); if (childDefinition != null && fatherDefinition != null) { childDefinition.setWarningGroupId(fatherDefinition.getWarningGroupId()); processDefineMapper.updateById(childDefinition); } } /** * submit task to mysql * * @param taskInstance taskInstance * @param processInstance processInstance * @return task instance */ public TaskInstance submitTaskInstanceToDB(TaskInstance taskInstance, ProcessInstance processInstance) { ExecutionStatus processInstanceState = processInstance.getState(); if (taskInstance.getState().typeIsFailure()) { if (taskInstance.isSubProcess()) { taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1); } else { if (processInstanceState != ExecutionStatus.READY_STOP && processInstanceState != ExecutionStatus.READY_PAUSE) { taskInstance.setFlag(Flag.NO); updateTaskInstance(taskInstance);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
if (taskInstance.getState() != ExecutionStatus.NEED_FAULT_TOLERANCE) { taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1); } taskInstance.setSubmitTime(null); taskInstance.setLogPath(null); taskInstance.setExecutePath(null); taskInstance.setStartTime(null); taskInstance.setEndTime(null); taskInstance.setFlag(Flag.YES); taskInstance.setHost(null); taskInstance.setId(0); } } } taskInstance.setExecutorId(processInstance.getExecutorId()); taskInstance.setProcessInstancePriority(processInstance.getProcessInstancePriority()); taskInstance.setState(getSubmitTaskState(taskInstance, processInstance)); if (taskInstance.getSubmitTime() == null) { taskInstance.setSubmitTime(new Date()); } if (taskInstance.getFirstSubmitTime() == null) { taskInstance.setFirstSubmitTime(taskInstance.getSubmitTime()); } boolean saveResult = saveTaskInstance(taskInstance); if (!saveResult) { return null; } return taskInstance; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
/** * get submit task instance state by the work process state * cannot modify the task state when running/kill/submit success, or this * task instance is already exists in task queue . * return pause if work process state is ready pause * return stop if work process state is ready stop * if all of above are not satisfied, return submit success * * @param taskInstance taskInstance * @param processInstance processInstance * @return process instance state */ public ExecutionStatus getSubmitTaskState(TaskInstance taskInstance, ProcessInstance processInstance) { ExecutionStatus state = taskInstance.getState(); if ( state == ExecutionStatus.RUNNING_EXECUTION || state == ExecutionStatus.DELAY_EXECUTION || state == ExecutionStatus.KILL ) { return state; } if (processInstance.getState() == ExecutionStatus.READY_PAUSE) { state = ExecutionStatus.PAUSE; } else if (processInstance.getState() == ExecutionStatus.READY_STOP || !checkProcessStrategy(taskInstance, processInstance)) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
state = ExecutionStatus.KILL; } else { state = ExecutionStatus.SUBMITTED_SUCCESS; } return state; } /** * check process instance strategy * * @param taskInstance taskInstance * @return check strategy result */ private boolean checkProcessStrategy(TaskInstance taskInstance, ProcessInstance processInstance) { FailureStrategy failureStrategy = processInstance.getFailureStrategy(); if (failureStrategy == FailureStrategy.CONTINUE) { return true; } List<TaskInstance> taskInstances = this.findValidTaskListByProcessId(taskInstance.getProcessInstanceId()); for (TaskInstance task : taskInstances) { if (task.getState() == ExecutionStatus.FAILURE && task.getRetryTimes() >= task.getMaxRetryTimes()) { return false; } } return true; } /** * insert or update work process instance to data base * * @param processInstance processInstance
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
*/ public void saveProcessInstance(ProcessInstance processInstance) { if (processInstance == null) { logger.error("save error, process instance is null!"); return; } if (processInstance.getId() != 0) { processInstanceMapper.updateById(processInstance); } else { processInstanceMapper.insert(processInstance); } } /** * insert or update command * * @param command command * @return save command result */ public int saveCommand(Command command) { if (command.getId() != 0) { return commandMapper.updateById(command); } else { return commandMapper.insert(command); } } /** * insert or update task instance * * @param taskInstance taskInstance * @return save task instance result
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
*/ public boolean saveTaskInstance(TaskInstance taskInstance) { if (taskInstance.getId() != 0) { return updateTaskInstance(taskInstance); } else { return createTaskInstance(taskInstance); } } /** * insert task instance * * @param taskInstance taskInstance * @return create task instance result */ public boolean createTaskInstance(TaskInstance taskInstance) { int count = taskInstanceMapper.insert(taskInstance); return count > 0; } /** * update task instance * * @param taskInstance taskInstance * @return update task instance result */ public boolean updateTaskInstance(TaskInstance taskInstance) { int count = taskInstanceMapper.updateById(taskInstance); return count > 0; } /** * find task instance by id
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* * @param taskId task id * @return task intance */ public TaskInstance findTaskInstanceById(Integer taskId) { return taskInstanceMapper.selectById(taskId); } /** * package task instance */ public void packageTaskInstance(TaskInstance taskInstance, ProcessInstance processInstance) { taskInstance.setProcessInstance(processInstance); taskInstance.setProcessDefine(processInstance.getProcessDefinition()); TaskDefinition taskDefinition = this.findTaskDefinition( taskInstance.getTaskCode(), taskInstance.getTaskDefinitionVersion()); this.updateTaskDefinitionResources(taskDefinition); taskInstance.setTaskDefine(taskDefinition); } /** * Update {@link ResourceInfo} information in {@link TaskDefinition} * * @param taskDefinition the given {@link TaskDefinition} */ public void updateTaskDefinitionResources(TaskDefinition taskDefinition) { Map<String, Object> taskParameters = JSONUtils.parseObject( taskDefinition.getTaskParams(), new TypeReference<Map<String, Object>>() { }); if (taskParameters != null) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
if (taskParameters.containsKey("mainJar")) { Object mainJarObj = taskParameters.get("mainJar"); ResourceInfo mainJar = JSONUtils.parseObject( JSONUtils.toJsonString(mainJarObj), ResourceInfo.class); ResourceInfo resourceInfo = updateResourceInfo(mainJar); if (resourceInfo != null) { taskParameters.put("mainJar", resourceInfo); } } if (taskParameters.containsKey("resourceList")) { String resourceListStr = JSONUtils.toJsonString(taskParameters.get("resourceList")); List<ResourceInfo> resourceInfos = JSONUtils.toList(resourceListStr, ResourceInfo.class); List<ResourceInfo> updatedResourceInfos = resourceInfos .stream() .map(this::updateResourceInfo) .filter(Objects::nonNull) .collect(Collectors.toList()); taskParameters.put("resourceList", updatedResourceInfos); } taskDefinition.setTaskParams(JSONUtils.toJsonString(taskParameters)); } } /** * update {@link ResourceInfo} by given original ResourceInfo *
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* @param res origin resource info * @return {@link ResourceInfo} */ private ResourceInfo updateResourceInfo(ResourceInfo res) { ResourceInfo resourceInfo = null; if (res != null) { int resourceId = res.getId(); if (resourceId <= 0) { logger.error("invalid resourceId, {}", resourceId); return null; } resourceInfo = new ResourceInfo(); Resource resource = getResourceById(resourceId); resourceInfo.setId(resourceId); resourceInfo.setRes(resource.getFileName()); resourceInfo.setResourceName(resource.getFullName()); if (logger.isInfoEnabled()) { logger.info("updated resource info {}", JSONUtils.toJsonString(resourceInfo)); } } return resourceInfo; } /** * get id list by task state * * @param instanceId instanceId * @param state state
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* @return task instance states */ public List<Integer> findTaskIdByInstanceState(int instanceId, ExecutionStatus state) { return taskInstanceMapper.queryTaskByProcessIdAndState(instanceId, state.ordinal()); } /** * find valid task list by process definition id * * @param processInstanceId processInstanceId * @return task instance list */ public List<TaskInstance> findValidTaskListByProcessId(Integer processInstanceId) { return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.YES); } /** * find previous task list by work process id * * @param processInstanceId processInstanceId * @return task instance list */ public List<TaskInstance> findPreviousTaskListByWorkProcessId(Integer processInstanceId) { return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.NO); } /** * update work process instance map * * @param processInstanceMap processInstanceMap * @return update process instance result */ public int updateWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
return processInstanceMapMapper.updateById(processInstanceMap); } /** * create work process instance map * * @param processInstanceMap processInstanceMap * @return create process instance result */ public int createWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) { int count = 0; if (processInstanceMap != null) { return processInstanceMapMapper.insert(processInstanceMap); } return count; } /** * find work process map by parent process id and parent task id. * * @param parentWorkProcessId parentWorkProcessId * @param parentTaskId parentTaskId * @return process instance map */ public ProcessInstanceMap findWorkProcessMapByParent(Integer parentWorkProcessId, Integer parentTaskId) { return processInstanceMapMapper.queryByParentId(parentWorkProcessId, parentTaskId); } /** * delete work process map by parent process id * * @param parentWorkProcessId parentWorkProcessId * @return delete process map result
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
*/ public int deleteWorkProcessMapByParentId(int parentWorkProcessId) { return processInstanceMapMapper.deleteByParentProcessId(parentWorkProcessId); } /** * find sub process instance * * @param parentProcessId parentProcessId * @param parentTaskId parentTaskId * @return process instance */ public ProcessInstance findSubProcessInstance(Integer parentProcessId, Integer parentTaskId) { ProcessInstance processInstance = null; ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryByParentId(parentProcessId, parentTaskId); if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) { return processInstance; } processInstance = findProcessInstanceById(processInstanceMap.getProcessInstanceId()); return processInstance; } /** * find parent process instance * * @param subProcessId subProcessId * @return process instance */ public ProcessInstance findParentProcessInstance(Integer subProcessId) { ProcessInstance processInstance = null; ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryBySubProcessId(subProcessId); if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
return processInstance; } processInstance = findProcessInstanceById(processInstanceMap.getParentProcessInstanceId()); return processInstance; } /** * change task state * * @param state state * @param startTime startTime * @param host host * @param executePath executePath * @param logPath logPath */ public void changeTaskState(TaskInstance taskInstance, ExecutionStatus state, Date startTime, String host, String executePath, String logPath) { taskInstance.setState(state); taskInstance.setStartTime(startTime); taskInstance.setHost(host); taskInstance.setExecutePath(executePath); taskInstance.setLogPath(logPath); saveTaskInstance(taskInstance); } /** * update process instance * * @param processInstance processInstance * @return update process instance result */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
public int updateProcessInstance(ProcessInstance processInstance) { return processInstanceMapper.updateById(processInstance); } /** * change task state * * @param state state * @param endTime endTime * @param varPool varPool */ public void changeTaskState(TaskInstance taskInstance, ExecutionStatus state, Date endTime, int processId, String appIds, String varPool) { taskInstance.setPid(processId); taskInstance.setAppLink(appIds); taskInstance.setState(state); taskInstance.setEndTime(endTime); taskInstance.setVarPool(varPool); changeOutParam(taskInstance); saveTaskInstance(taskInstance); } /** * for show in page of taskInstance */ public void changeOutParam(TaskInstance taskInstance) { if (StringUtils.isEmpty(taskInstance.getVarPool())) { return; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
List<Property> properties = JSONUtils.toList(taskInstance.getVarPool(), Property.class); if (CollectionUtils.isEmpty(properties)) { return; } Map<String, Object> taskParams = JSONUtils.parseObject(taskInstance.getTaskParams(), new TypeReference<Map<String, Object>>() { }); Object localParams = taskParams.get(LOCAL_PARAMS); if (localParams == null) { return; } List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class); Map<String, String> outProperty = new HashMap<>(); for (Property info : properties) { if (info.getDirect() == Direct.OUT) { outProperty.put(info.getProp(), info.getValue()); } } for (Property info : allParam) { if (info.getDirect() == Direct.OUT) { String paramName = info.getProp(); info.setValue(outProperty.get(paramName)); } } taskParams.put(LOCAL_PARAMS, allParam); taskInstance.setTaskParams(JSONUtils.toJsonString(taskParams)); } /** * convert integer list to string list *
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* @param intList intList * @return string list */ public List<String> convertIntListToString(List<Integer> intList) { if (intList == null) { return new ArrayList<>(); } List<String> result = new ArrayList<>(intList.size()); for (Integer intVar : intList) { result.add(String.valueOf(intVar)); } return result; } /** * query schedule by id * * @param id id * @return schedule */ public Schedule querySchedule(int id) { return scheduleMapper.selectById(id); } /** * query Schedule by processDefinitionCode * * @param processDefinitionCode processDefinitionCode * @see Schedule */ public List<Schedule> queryReleaseSchedulerListByProcessDefinitionCode(long processDefinitionCode) { return scheduleMapper.queryReleaseSchedulerListByProcessDefinitionCode(processDefinitionCode);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} /** * query need failover process instance * * @param host host * @return process instance list */ public List<ProcessInstance> queryNeedFailoverProcessInstances(String host) { return processInstanceMapper.queryByHostAndStatus(host, stateArray); } public List<String> queryNeedFailoverProcessInstanceHost() { return processInstanceMapper.queryNeedFailoverProcessInstanceHost(stateArray); } /** * process need failover process instance * * @param processInstance processInstance */ @Transactional(rollbackFor = RuntimeException.class) public void processNeedFailoverProcessInstances(ProcessInstance processInstance) { processInstance.setHost(Constants.NULL); processInstanceMapper.updateById(processInstance); ProcessDefinition processDefinition = findProcessDefinition(processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion()); Command cmd = new Command(); cmd.setProcessDefinitionCode(processDefinition.getCode()); cmd.setProcessDefinitionVersion(processDefinition.getVersion()); cmd.setProcessInstanceId(processInstance.getId()); cmd.setCommandParam(String.format("{\"%s\":%d}", Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING, processInstance.getId()));
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
cmd.setExecutorId(processInstance.getExecutorId()); cmd.setCommandType(CommandType.RECOVER_TOLERANCE_FAULT_PROCESS); createCommand(cmd); } /** * query all need failover task instances by host * * @param host host * @return task instance list */ public List<TaskInstance> queryNeedFailoverTaskInstances(String host) { return taskInstanceMapper.queryByHostAndStatus(host, stateArray); } /** * find data source by id * * @param id id * @return datasource */ public DataSource findDataSourceById(int id) { return dataSourceMapper.selectById(id); } /** * update process instance state by id * * @param processInstanceId processInstanceId * @param executionStatus executionStatus * @return update process result */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
public int updateProcessInstanceState(Integer processInstanceId, ExecutionStatus executionStatus) { ProcessInstance instance = processInstanceMapper.selectById(processInstanceId); instance.setState(executionStatus); return processInstanceMapper.updateById(instance); } /** * find process instance by the task id * * @param taskId taskId * @return process instance */ public ProcessInstance findProcessInstanceByTaskId(int taskId) { TaskInstance taskInstance = taskInstanceMapper.selectById(taskId); if (taskInstance != null) { return processInstanceMapper.selectById(taskInstance.getProcessInstanceId()); } return null; } /** * find udf function list by id list string * * @param ids ids * @return udf function list */ public List<UdfFunc> queryUdfFunListByIds(int[] ids) { return udfFuncMapper.queryUdfByIdStr(ids, null); } /** * find tenant code by resource name *
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* @param resName resource name * @param resourceType resource type * @return tenant code */ public String queryTenantCodeByResName(String resName, ResourceType resourceType) { String fullName = resName.startsWith("/") ? resName : String.format("/%s", resName); List<Resource> resourceList = resourceMapper.queryResource(fullName, resourceType.ordinal()); if (CollectionUtils.isEmpty(resourceList)) { return StringUtils.EMPTY; } int userId = resourceList.get(0).getUserId(); User user = userMapper.selectById(userId); if (Objects.isNull(user)) { return StringUtils.EMPTY; } Tenant tenant = tenantMapper.queryById(user.getTenantId()); if (Objects.isNull(tenant)) { return StringUtils.EMPTY; } return tenant.getTenantCode(); } /** * find schedule list by process define codes. * * @param codes codes * @return schedule list */ public List<Schedule> selectAllByProcessDefineCode(long[] codes) { return scheduleMapper.selectAllByProcessDefineArray(codes);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} /** * find last scheduler process instance in the date interval * * @param definitionCode definitionCode * @param dateInterval dateInterval * @return process instance */ public ProcessInstance findLastSchedulerProcessInterval(Long definitionCode, DateInterval dateInterval) { return processInstanceMapper.queryLastSchedulerProcess(definitionCode, dateInterval.getStartTime(), dateInterval.getEndTime()); } /** * find last manual process instance interval * * @param definitionCode process definition code * @param dateInterval dateInterval * @return process instance */ public ProcessInstance findLastManualProcessInterval(Long definitionCode, DateInterval dateInterval) { return processInstanceMapper.queryLastManualProcess(definitionCode, dateInterval.getStartTime(), dateInterval.getEndTime()); } /** * find last running process instance * * @param definitionCode process definition code * @param startTime start time
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* @param endTime end time * @return process instance */ public ProcessInstance findLastRunningProcess(Long definitionCode, Date startTime, Date endTime) { return processInstanceMapper.queryLastRunningProcess(definitionCode, startTime, endTime, stateArray); } /** * query user queue by process instance * * @param processInstance processInstance * @return queue */ public String queryUserQueueByProcessInstance(ProcessInstance processInstance) { String queue = ""; if (processInstance == null) { return queue; } User executor = userMapper.selectById(processInstance.getExecutorId()); if (executor != null) { queue = executor.getQueue(); } return queue; } /** * query project name and user name by processInstanceId. * * @param processInstanceId processInstanceId
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* @return projectName and userName */ public ProjectUser queryProjectWithUserByProcessInstanceId(int processInstanceId) { return projectMapper.queryProjectWithUserByProcessInstanceId(processInstanceId); } /** * get task worker group * * @param taskInstance taskInstance * @return workerGroupId */ public String getTaskWorkerGroup(TaskInstance taskInstance) { String workerGroup = taskInstance.getWorkerGroup(); if (StringUtils.isNotBlank(workerGroup)) { return workerGroup; } int processInstanceId = taskInstance.getProcessInstanceId(); ProcessInstance processInstance = findProcessInstanceById(processInstanceId); if (processInstance != null) { return processInstance.getWorkerGroup(); } logger.info("task : {} will use default worker group", taskInstance.getId()); return Constants.DEFAULT_WORKER_GROUP; } /** * get have perm project list * * @param userId userId * @return project list */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
public List<Project> getProjectListHavePerm(int userId) { List<Project> createProjects = projectMapper.queryProjectCreatedByUser(userId); List<Project> authedProjects = projectMapper.queryAuthedProjectListByUserId(userId); if (createProjects == null) { createProjects = new ArrayList<>(); } if (authedProjects != null) { createProjects.addAll(authedProjects); } return createProjects; } /** * list unauthorized udf function * * @param userId user id * @param needChecks data source id array * @return unauthorized udf function list */ public <T> List<T> listUnauthorized(int userId, T[] needChecks, AuthorizationType authorizationType) { List<T> resultList = new ArrayList<>(); if (Objects.nonNull(needChecks) && needChecks.length > 0) { Set<T> originResSet = new HashSet<>(Arrays.asList(needChecks)); switch (authorizationType) { case RESOURCE_FILE_ID: case UDF_FILE: List<Resource> ownUdfResources = resourceMapper.listAuthorizedResourceById(userId, needChecks); addAuthorizedResources(ownUdfResources, userId); Set<Integer> authorizedResourceFiles = ownUdfResources.stream().map(Resource::getId).collect(toSet()); originResSet.removeAll(authorizedResourceFiles); break;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
case RESOURCE_FILE_NAME: List<Resource> ownResources = resourceMapper.listAuthorizedResource(userId, needChecks); addAuthorizedResources(ownResources, userId); Set<String> authorizedResources = ownResources.stream().map(Resource::getFullName).collect(toSet()); originResSet.removeAll(authorizedResources); break; case DATASOURCE: Set<Integer> authorizedDatasources = dataSourceMapper.listAuthorizedDataSource(userId, needChecks).stream().map(DataSource::getId).collect(toSet()); originResSet.removeAll(authorizedDatasources); break; case UDF: Set<Integer> authorizedUdfs = udfFuncMapper.listAuthorizedUdfFunc(userId, needChecks).stream().map(UdfFunc::getId).collect(toSet()); originResSet.removeAll(authorizedUdfs); break; default: break; } resultList.addAll(originResSet); } return resultList; } /** * get user by user id * * @param userId user id * @return User */ public User getUserById(int userId) { return userMapper.selectById(userId); }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
/** * get resource by resource id * * @param resourceId resource id * @return Resource */ public Resource getResourceById(int resourceId) { return resourceMapper.selectById(resourceId); } /** * list resources by ids * * @param resIds resIds * @return resource list */ public List<Resource> listResourceByIds(Integer[] resIds) { return resourceMapper.listResourceByIds(resIds); } /** * format task app id in task instance */ public String formatTaskAppId(TaskInstance taskInstance) { ProcessInstance processInstance = findProcessInstanceById(taskInstance.getProcessInstanceId()); if (processInstance == null) { return ""; } ProcessDefinition definition = findProcessDefinition(processInstance.getProcessDefinitionCode(), processInstance.getProcessDefinitionVersion()); if (definition == null) { return ""; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
return String.format("%s_%s_%s", definition.getId(), processInstance.getId(), taskInstance.getId()); } /** * switch process definition version to process definition log version */ public int switchVersion(ProcessDefinition processDefinition, ProcessDefinitionLog processDefinitionLog) { if (null == processDefinition || null == processDefinitionLog) { return Constants.DEFINITION_FAILURE; } processDefinitionLog.setId(processDefinition.getId()); processDefinitionLog.setReleaseState(ReleaseState.OFFLINE); processDefinitionLog.setFlag(Flag.YES); int result = processDefineMapper.updateById(processDefinitionLog); if (result > 0) { result = switchProcessTaskRelationVersion(processDefinitionLog); if (result <= 0) { return Constants.DEFINITION_FAILURE; } } return result; } public int switchProcessTaskRelationVersion(ProcessDefinition processDefinition) { List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode()); if (!processTaskRelationList.isEmpty()) { processTaskRelationMapper.deleteByCode(processDefinition.getProjectCode(), processDefinition.getCode()); } List<ProcessTaskRelationLog> processTaskRelationLogList = processTaskRelationLogMapper.queryByProcessCodeAndVersion(processDefinition.getCode(), processDefinition.getVersion()); return processTaskRelationMapper.batchInsert(processTaskRelationLogList); } /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
* get resource ids * * @param taskDefinition taskDefinition * @return resource ids */ public String getResourceIds(TaskDefinition taskDefinition) { Set<Integer> resourceIds = null; AbstractParameters params = TaskParametersUtils.getParameters(taskDefinition.getTaskType(), taskDefinition.getTaskParams()); if (params != null && CollectionUtils.isNotEmpty(params.getResourceFilesList())) { resourceIds = params.getResourceFilesList(). stream() .filter(t -> t.getId() != 0) .map(ResourceInfo::getId) .collect(Collectors.toSet()); } if (CollectionUtils.isEmpty(resourceIds)) { return StringUtils.EMPTY; } return StringUtils.join(resourceIds, ","); } public int saveTaskDefine(User operator, long projectCode, List<TaskDefinitionLog> taskDefinitionLogs) { Date now = new Date(); List<TaskDefinitionLog> newTaskDefinitionLogs = new ArrayList<>(); List<TaskDefinitionLog> updateTaskDefinitionLogs = new ArrayList<>(); for (TaskDefinitionLog taskDefinitionLog : taskDefinitionLogs) { taskDefinitionLog.setProjectCode(projectCode); taskDefinitionLog.setUpdateTime(now); taskDefinitionLog.setOperateTime(now); taskDefinitionLog.setOperator(operator.getId()); taskDefinitionLog.setResourceIds(getResourceIds(taskDefinitionLog));
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
if (taskDefinitionLog.getCode() > 0 && taskDefinitionLog.getVersion() > 0) { TaskDefinitionLog definitionCodeAndVersion = taskDefinitionLogMapper .queryByDefinitionCodeAndVersion(taskDefinitionLog.getCode(), taskDefinitionLog.getVersion()); if (definitionCodeAndVersion != null) { if (!taskDefinitionLog.equals(definitionCodeAndVersion)) { taskDefinitionLog.setUserId(definitionCodeAndVersion.getUserId()); Integer version = taskDefinitionLogMapper.queryMaxVersionForDefinition(taskDefinitionLog.getCode()); taskDefinitionLog.setVersion(version + 1); taskDefinitionLog.setCreateTime(definitionCodeAndVersion.getCreateTime()); updateTaskDefinitionLogs.add(taskDefinitionLog); } continue; } } taskDefinitionLog.setUserId(operator.getId()); taskDefinitionLog.setVersion(Constants.VERSION_FIRST); taskDefinitionLog.setCreateTime(now); if (taskDefinitionLog.getCode() == 0) { try { taskDefinitionLog.setCode(CodeGenerateUtils.getInstance().genCode()); } catch (CodeGenerateException e) { logger.error("Task code get error, ", e); return Constants.DEFINITION_FAILURE; } } newTaskDefinitionLogs.add(taskDefinitionLog); } int insertResult = 0; int updateResult = 0; for (TaskDefinitionLog taskDefinitionToUpdate : updateTaskDefinitionLogs) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
TaskDefinition task = taskDefinitionMapper.queryByCode(taskDefinitionToUpdate.getCode()); if (task == null) { newTaskDefinitionLogs.add(taskDefinitionToUpdate); } else { insertResult += taskDefinitionLogMapper.insert(taskDefinitionToUpdate); taskDefinitionToUpdate.setId(task.getId()); updateResult += taskDefinitionMapper.updateById(taskDefinitionToUpdate); } } if (!newTaskDefinitionLogs.isEmpty()) { updateResult += taskDefinitionMapper.batchInsert(newTaskDefinitionLogs); insertResult += taskDefinitionLogMapper.batchInsert(newTaskDefinitionLogs); } return (insertResult & updateResult) > 0 ? 1 : Constants.EXIT_CODE_SUCCESS; } /** * save processDefinition (including create or update processDefinition) */ public int saveProcessDefine(User operator, ProcessDefinition processDefinition, Boolean isFromProcessDefine) { ProcessDefinitionLog processDefinitionLog = new ProcessDefinitionLog(processDefinition); Integer version = processDefineLogMapper.queryMaxVersionForDefinition(processDefinition.getCode()); int insertVersion = version == null || version == 0 ? Constants.VERSION_FIRST : version + 1; processDefinitionLog.setVersion(insertVersion); processDefinitionLog.setReleaseState(isFromProcessDefine ? ReleaseState.OFFLINE : ReleaseState.ONLINE); processDefinitionLog.setOperator(operator.getId()); processDefinitionLog.setOperateTime(processDefinition.getUpdateTime()); int insertLog = processDefineLogMapper.insert(processDefinitionLog); int result; if (0 == processDefinition.getId()) { result = processDefineMapper.insert(processDefinitionLog);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} else { processDefinitionLog.setId(processDefinition.getId()); result = processDefineMapper.updateById(processDefinitionLog); } return (insertLog & result) > 0 ? insertVersion : 0; } /** * save task relations */ public int saveTaskRelation(User operator, long projectCode, long processDefinitionCode, int processDefinitionVersion, List<ProcessTaskRelationLog> taskRelationList, List<TaskDefinitionLog> taskDefinitionLogs) { if (taskRelationList.isEmpty()) { return Constants.EXIT_CODE_SUCCESS; } Map<Long, TaskDefinitionLog> taskDefinitionLogMap = null; if (CollectionUtils.isNotEmpty(taskDefinitionLogs)) { taskDefinitionLogMap = taskDefinitionLogs.stream() .collect(Collectors.toMap(TaskDefinition::getCode, taskDefinitionLog -> taskDefinitionLog)); } Date now = new Date(); for (ProcessTaskRelationLog processTaskRelationLog : taskRelationList) { processTaskRelationLog.setProjectCode(projectCode); processTaskRelationLog.setProcessDefinitionCode(processDefinitionCode); processTaskRelationLog.setProcessDefinitionVersion(processDefinitionVersion); if (taskDefinitionLogMap != null) { TaskDefinitionLog preTaskDefinitionLog = taskDefinitionLogMap.get(processTaskRelationLog.getPreTaskCode()); if (preTaskDefinitionLog != null) { processTaskRelationLog.setPreTaskVersion(preTaskDefinitionLog.getVersion()); } TaskDefinitionLog postTaskDefinitionLog = taskDefinitionLogMap.get(processTaskRelationLog.getPostTaskCode());
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
if (postTaskDefinitionLog != null) { processTaskRelationLog.setPostTaskVersion(postTaskDefinitionLog.getVersion()); } } processTaskRelationLog.setCreateTime(now); processTaskRelationLog.setUpdateTime(now); processTaskRelationLog.setOperator(operator.getId()); processTaskRelationLog.setOperateTime(now); } List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByProcessCode(projectCode, processDefinitionCode); if (!processTaskRelationList.isEmpty()) { Set<Integer> processTaskRelationSet = processTaskRelationList.stream().map(ProcessTaskRelation::hashCode).collect(toSet()); Set<Integer> taskRelationSet = taskRelationList.stream().map(ProcessTaskRelationLog::hashCode).collect(toSet()); boolean result = CollectionUtils.isEqualCollection(processTaskRelationSet, taskRelationSet); if (result) { return Constants.EXIT_CODE_SUCCESS; } processTaskRelationMapper.deleteByCode(projectCode, processDefinitionCode); } int result = processTaskRelationMapper.batchInsert(taskRelationList); int resultLog = processTaskRelationLogMapper.batchInsert(taskRelationList); return (result & resultLog) > 0 ? Constants.EXIT_CODE_SUCCESS : Constants.EXIT_CODE_FAILURE; } public boolean isTaskOnline(long taskCode) { List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByTaskCode(taskCode); if (!processTaskRelationList.isEmpty()) { Set<Long> processDefinitionCodes = processTaskRelationList .stream() .map(ProcessTaskRelation::getProcessDefinitionCode) .collect(Collectors.toSet());
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
List<ProcessDefinition> processDefinitionList = processDefineMapper.queryByCodes(processDefinitionCodes); for (ProcessDefinition processDefinition : processDefinitionList) { if (processDefinition.getReleaseState() == ReleaseState.ONLINE) { return true; } } } return false; } /** * Generate the DAG Graph based on the process definition id * * @param processDefinition process definition * @return dag graph */ public DAG<String, TaskNode, TaskNodeRelation> genDagGraph(ProcessDefinition processDefinition) { List<ProcessTaskRelation> processTaskRelations = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode()); List<TaskNode> taskNodeList = transformTask(processTaskRelations, Lists.newArrayList()); ProcessDag processDag = DagHelper.getProcessDag(taskNodeList, new ArrayList<>(processTaskRelations)); return DagHelper.buildDagGraph(processDag); } /** * generate DagData */ public DagData genDagData(ProcessDefinition processDefinition) { List<ProcessTaskRelation> processTaskRelations = processTaskRelationMapper.queryByProcessCode(processDefinition.getProjectCode(), processDefinition.getCode()); List<TaskDefinitionLog> taskDefinitionLogList = genTaskDefineList(processTaskRelations); List<TaskDefinition> taskDefinitions = taskDefinitionLogList.stream()
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
.map(taskDefinitionLog -> JSONUtils.parseObject(JSONUtils.toJsonString(taskDefinitionLog), TaskDefinition.class)) .collect(Collectors.toList()); return new DagData(processDefinition, processTaskRelations, taskDefinitions); } public List<TaskDefinitionLog> genTaskDefineList(List<ProcessTaskRelation> processTaskRelations) { Set<TaskDefinition> taskDefinitionSet = new HashSet<>(); for (ProcessTaskRelation processTaskRelation : processTaskRelations) { if (processTaskRelation.getPreTaskCode() > 0) { taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPreTaskCode(), processTaskRelation.getPreTaskVersion())); } if (processTaskRelation.getPostTaskCode() > 0) { taskDefinitionSet.add(new TaskDefinition(processTaskRelation.getPostTaskCode(), processTaskRelation.getPostTaskVersion())); } } if (taskDefinitionSet.isEmpty()) { return Lists.newArrayList(); } return taskDefinitionLogMapper.queryByTaskDefinitions(taskDefinitionSet); } public List<TaskDefinitionLog> getTaskDefineLogListByRelation(List<ProcessTaskRelation> processTaskRelations) { List<TaskDefinitionLog> taskDefinitionLogs = new ArrayList<>(); Map<Long, Integer> taskCodeVersionMap = new HashMap<>(); for (ProcessTaskRelation processTaskRelation : processTaskRelations) { if (processTaskRelation.getPreTaskCode() > 0) { taskCodeVersionMap.put(processTaskRelation.getPreTaskCode(), processTaskRelation.getPreTaskVersion()); } if (processTaskRelation.getPostTaskCode() > 0) { taskCodeVersionMap.put(processTaskRelation.getPostTaskCode(), processTaskRelation.getPostTaskVersion()); } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
taskCodeVersionMap.forEach((code,version) -> { taskDefinitionLogs.add((TaskDefinitionLog) this.findTaskDefinition(code, version)); }); return taskDefinitionLogs; } /** * find task definition by code and version */ public TaskDefinition findTaskDefinition(long taskCode, int taskDefinitionVersion) { return taskDefinitionLogMapper.queryByDefinitionCodeAndVersion(taskCode, taskDefinitionVersion); } /** * find process task relation list by projectCode and processDefinitionCode */ public List<ProcessTaskRelation> findRelationByCode(long projectCode, long processDefinitionCode) { return processTaskRelationMapper.queryByProcessCode(projectCode, processDefinitionCode); } /** * add authorized resources * * @param ownResources own resources * @param userId userId */ private void addAuthorizedResources(List<Resource> ownResources, int userId) { List<Integer> relationResourceIds = resourceUserMapper.queryResourcesIdListByUserIdAndPerm(userId, 7); List<Resource> relationResources = CollectionUtils.isNotEmpty(relationResourceIds) ? resourceMapper.queryResourceListById(relationResourceIds) : new ArrayList<>(); ownResources.addAll(relationResources); } /** * Use temporarily before refactoring taskNode
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
*/ public List<TaskNode> transformTask(List<ProcessTaskRelation> taskRelationList, List<TaskDefinitionLog> taskDefinitionLogs) { Map<Long, List<Long>> taskCodeMap = new HashMap<>(); for (ProcessTaskRelation processTaskRelation : taskRelationList) { taskCodeMap.compute(processTaskRelation.getPostTaskCode(), (k, v) -> { if (v == null) { v = new ArrayList<>(); } if (processTaskRelation.getPreTaskCode() != 0L) { v.add(processTaskRelation.getPreTaskCode()); } return v; }); } if (CollectionUtils.isEmpty(taskDefinitionLogs)) { taskDefinitionLogs = genTaskDefineList(taskRelationList); } Map<Long, TaskDefinitionLog> taskDefinitionLogMap = taskDefinitionLogs.stream() .collect(Collectors.toMap(TaskDefinitionLog::getCode, taskDefinitionLog -> taskDefinitionLog)); List<TaskNode> taskNodeList = new ArrayList<>(); for (Entry<Long, List<Long>> code : taskCodeMap.entrySet()) { TaskDefinitionLog taskDefinitionLog = taskDefinitionLogMap.get(code.getKey()); if (taskDefinitionLog != null) { TaskNode taskNode = new TaskNode(); taskNode.setCode(taskDefinitionLog.getCode()); taskNode.setVersion(taskDefinitionLog.getVersion()); taskNode.setName(taskDefinitionLog.getName()); taskNode.setDesc(taskDefinitionLog.getDescription()); taskNode.setType(taskDefinitionLog.getTaskType().toUpperCase()); taskNode.setRunFlag(taskDefinitionLog.getFlag() == Flag.YES ? Constants.FLOWNODE_RUN_FLAG_NORMAL : Constants.FLOWNODE_RUN_FLAG_FORBIDDEN);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
taskNode.setMaxRetryTimes(taskDefinitionLog.getFailRetryTimes()); taskNode.setRetryInterval(taskDefinitionLog.getFailRetryInterval()); Map<String, Object> taskParamsMap = taskNode.taskParamsToJsonObj(taskDefinitionLog.getTaskParams()); taskNode.setConditionResult(JSONUtils.toJsonString(taskParamsMap.get(Constants.CONDITION_RESULT))); taskNode.setSwitchResult(JSONUtils.toJsonString(taskParamsMap.get(Constants.SWITCH_RESULT))); taskNode.setDependence(JSONUtils.toJsonString(taskParamsMap.get(Constants.DEPENDENCE))); taskParamsMap.remove(Constants.CONDITION_RESULT); taskParamsMap.remove(Constants.DEPENDENCE); taskNode.setParams(JSONUtils.toJsonString(taskParamsMap)); taskNode.setTaskInstancePriority(taskDefinitionLog.getTaskPriority()); taskNode.setWorkerGroup(taskDefinitionLog.getWorkerGroup()); taskNode.setEnvironmentCode(taskDefinitionLog.getEnvironmentCode()); taskNode.setTimeout(JSONUtils.toJsonString(new TaskTimeoutParameter(taskDefinitionLog.getTimeoutFlag() == TimeoutFlag.OPEN, taskDefinitionLog.getTimeoutNotifyStrategy(), taskDefinitionLog.getTimeout()))); taskNode.setDelayTime(taskDefinitionLog.getDelayTime()); taskNode.setPreTasks(JSONUtils.toJsonString(code.getValue().stream().map(taskDefinitionLogMap::get).map(TaskDefinition::getCode).collect(Collectors.toList()))); taskNode.setTaskGroupId(taskDefinitionLog.getTaskGroupId()); taskNode.setTaskGroupPriority(taskDefinitionLog.getTaskGroupPriority()); taskNodeList.add(taskNode); } } return taskNodeList; } public Map<ProcessInstance, TaskInstance> notifyProcessList(int processId) { HashMap<ProcessInstance, TaskInstance> processTaskMap = new HashMap<>(); ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryBySubProcessId(processId); if (processInstanceMap == null) { return processTaskMap;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} ProcessInstance fatherProcess = this.findProcessInstanceById(processInstanceMap.getParentProcessInstanceId()); TaskInstance fatherTask = this.findTaskInstanceById(processInstanceMap.getParentTaskInstanceId()); if (fatherProcess != null) { processTaskMap.put(fatherProcess, fatherTask); } return processTaskMap; } /** * the first time (when submit the task ) get the resource of the task group * @param taskId task id * @param taskName * @param groupId * @param processId * @param priority * @return */ public boolean acquireTaskGroup(int taskId, String taskName, int groupId, int processId, int priority) { TaskGroup taskGroup = taskGroupMapper.selectById(groupId); if (taskGroup == null) { return true; } if (taskGroup.getStatus() == Flag.NO.getCode()) { return true; } TaskGroupQueue taskGroupQueue = this.taskGroupQueueMapper.queryByTaskId(taskId); if (taskGroupQueue == null) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
taskGroupQueue = insertIntoTaskGroupQueue(taskId, taskName, groupId, processId, priority, TaskGroupQueueStatus.WAIT_QUEUE); } else { if (taskGroupQueue.getStatus() == TaskGroupQueueStatus.ACQUIRE_SUCCESS) { return true; } taskGroupQueue.setInQueue(Flag.NO.getCode()); taskGroupQueue.setStatus(TaskGroupQueueStatus.WAIT_QUEUE); this.taskGroupQueueMapper.updateById(taskGroupQueue); } List<TaskGroupQueue> highPriorityTasks = taskGroupQueueMapper.queryHighPriorityTasks(groupId, priority, TaskGroupQueueStatus.WAIT_QUEUE.getCode()); if (CollectionUtils.isNotEmpty(highPriorityTasks)) { this.taskGroupQueueMapper.updateInQueue(Flag.NO.getCode(), taskGroupQueue.getId()); return false; } int count = taskGroupMapper.selectAvailableCountById(groupId); if (count == 1 && robTaskGroupResouce(taskGroupQueue)) { return true; } this.taskGroupQueueMapper.updateInQueue(Flag.NO.getCode(), taskGroupQueue.getId()); return false; } /** * try to get the task group resource(when other task release the resource) * @param taskGroupQueue * @return */ public boolean robTaskGroupResouce(TaskGroupQueue taskGroupQueue) { TaskGroup taskGroup = taskGroupMapper.selectById(taskGroupQueue.getGroupId());
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
int affectedCount = taskGroupMapper.updateTaskGroupResource(taskGroup.getId(),taskGroupQueue.getId(), TaskGroupQueueStatus.WAIT_QUEUE.getCode()); if (affectedCount > 0) { taskGroupQueue.setStatus(TaskGroupQueueStatus.ACQUIRE_SUCCESS); this.taskGroupQueueMapper.updateById(taskGroupQueue); this.taskGroupQueueMapper.updateInQueue(Flag.NO.getCode(), taskGroupQueue.getId()); return true; } return false; } public boolean acquireTaskGroupAgain(TaskGroupQueue taskGroupQueue) { return robTaskGroupResouce(taskGroupQueue); } public void releaseAllTaskGroup(int processInstanceId) { List<TaskInstance> taskInstances = this.taskInstanceMapper.loadAllInfosNoRelease(processInstanceId, TaskGroupQueueStatus.ACQUIRE_SUCCESS.getCode()); for (TaskInstance info : taskInstances) { releaseTaskGroup(info); } } /** * release the TGQ resource when the corresponding task is finished. * * @return the result code and msg */ public TaskInstance releaseTaskGroup(TaskInstance taskInstance) { TaskGroup taskGroup = taskGroupMapper.selectById(taskInstance.getTaskGroupId()); if (taskGroup == null) { return null; } TaskGroupQueue thisTaskGroupQueue = this.taskGroupQueueMapper.queryByTaskId(taskInstance.getId());
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
if (thisTaskGroupQueue.getStatus() == TaskGroupQueueStatus.RELEASE) { return null; } try { while (taskGroupMapper.releaseTaskGroupResource(taskGroup.getId(), taskGroup.getUseSize() , thisTaskGroupQueue.getId(), TaskGroupQueueStatus.ACQUIRE_SUCCESS.getCode()) != 1) { thisTaskGroupQueue = this.taskGroupQueueMapper.queryByTaskId(taskInstance.getId()); if (thisTaskGroupQueue.getStatus() == TaskGroupQueueStatus.RELEASE) { return null; } taskGroup = taskGroupMapper.selectById(taskInstance.getTaskGroupId()); } } catch (Exception e) { logger.error("release the task group error",e); } logger.info("updateTask:{}",taskInstance.getName()); changeTaskGroupQueueStatus(taskInstance.getId(), TaskGroupQueueStatus.RELEASE); TaskGroupQueue taskGroupQueue = this.taskGroupQueueMapper.queryTheHighestPriorityTasks(taskGroup.getId(), TaskGroupQueueStatus.WAIT_QUEUE.getCode(), Flag.NO.getCode(), Flag.NO.getCode()); if (taskGroupQueue == null) { return null; } while (this.taskGroupQueueMapper.updateInQueueCAS(Flag.NO.getCode(), Flag.YES.getCode(), taskGroupQueue.getId()) != 1) { taskGroupQueue = this.taskGroupQueueMapper.queryTheHighestPriorityTasks(taskGroup.getId(), TaskGroupQueueStatus.WAIT_QUEUE.getCode(), Flag.NO.getCode(), Flag.NO.getCode()); if (taskGroupQueue == null) { return null; } } return this.taskInstanceMapper.selectById(taskGroupQueue.getTaskId());
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
} /** * release the TGQ resource when the corresponding task is finished. * * @param taskId task id * @return the result code and msg */ public void changeTaskGroupQueueStatus(int taskId, TaskGroupQueueStatus status) { TaskGroupQueue taskGroupQueue = taskGroupQueueMapper.queryByTaskId(taskId); taskGroupQueue.setStatus(status); taskGroupQueue.setUpdateTime(new Date(System.currentTimeMillis())); taskGroupQueueMapper.updateById(taskGroupQueue); } /** * insert into task group queue * * @param taskId task id * @param taskName task name * @param groupId group id * @param processId process id * @param priority priority * @return result and msg code */ public TaskGroupQueue insertIntoTaskGroupQueue(Integer taskId, String taskName, Integer groupId, Integer processId, Integer priority, TaskGroupQueueStatus status) { TaskGroupQueue taskGroupQueue = new TaskGroupQueue(taskId, taskName, groupId, processId, priority, status); taskGroupQueueMapper.insert(taskGroupQueue); return taskGroupQueue; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,682
[Bug] [API] After creating a task group the values of both fields 'create_time' and 'update_time' are empty.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened After creating a task group the values of both fields 'create_time' and 'update_time' are empty. ![image](https://user-images.githubusercontent.com/4928204/147560349-48515489-3cac-453e-8ad9-17d54537dd29.png) ### What you expected to happen I expect that the value of both fields 'create_time' and 'update_time' can be assigned with current time. ### How to reproduce You can reproduce this issue when creating a task group in the page or through api. ![image](https://user-images.githubusercontent.com/4928204/147560389-afe6d839-da2d-43e5-8998-1cc80ebf5f8b.png) ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7682
https://github.com/apache/dolphinscheduler/pull/7683
8808c0a700d367a1d408c1ec07c2a6fbeb675d33
6b5db0ac5b1d19aa30667b7edab9573c262ecb60
2021-12-28T11:11:30Z
java
2021-12-28T12:01:46Z
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
public int updateTaskGroupQueueStatus(Integer taskId, int status) { return taskGroupQueueMapper.updateStatusByTaskId(taskId, status); } public int updateTaskGroupQueue(TaskGroupQueue taskGroupQueue) { return taskGroupQueueMapper.updateById(taskGroupQueue); } public TaskGroupQueue loadTaskGroupQueue(int taskId) { return this.taskGroupQueueMapper.queryByTaskId(taskId); } public void sendStartTask2Master(ProcessInstance processInstance,int taskId, org.apache.dolphinscheduler.remote.command.CommandType taskType) { String host = processInstance.getHost(); String address = host.split(":")[0]; int port = Integer.parseInt(host.split(":")[1]); TaskEventChangeCommand taskEventChangeCommand = new TaskEventChangeCommand( processInstance.getId(), taskId ); stateEventCallbackService.sendResult(address, port, taskEventChangeCommand.convert2Command(taskType)); } public ProcessInstance loadNextProcess4Serial(long code, int state) { return this.processInstanceMapper.loadNextProcess4Serial(code, state); } private void deleteCommandWithCheck(int commandId) { int delete = this.commandMapper.deleteById(commandId); if (delete != 1) { throw new ServiceException("delete command fail, id:" + commandId); } } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,701
[Bug] [DAO] There's an redundant field named 'project_id' in the table of 't_ds_task_group'.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened In the table of 't_ds_task_group' there's two fields of 'project_code' and 'project_id'. Each of them can identify the project, and the class of 'TaskGroup' doesn't use this field. So need to remove it from the table and improve a few wrong annotations. ![image](https://user-images.githubusercontent.com/4928204/147622409-d9407e03-a2eb-49fc-abd7-e67111027472.png) ### What you expected to happen I expect to remove the redundant field 'project_id' in the table 't_ds_task_group'. ### How to reproduce See it in the project. ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7701
https://github.com/apache/dolphinscheduler/pull/7703
5ab0135d1831c9156388d8b593417e775e2b2b84
71ccb42697e197b2668a08a83eb9bb19261b4f5a
2021-12-29T02:52:14Z
java
2021-12-29T04:57:36Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskGroupController.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.api.controller; import io.swagger.annotations.Api; import io.swagger.annotations.ApiImplicitParam; import io.swagger.annotations.ApiImplicitParams;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,701
[Bug] [DAO] There's an redundant field named 'project_id' in the table of 't_ds_task_group'.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened In the table of 't_ds_task_group' there's two fields of 'project_code' and 'project_id'. Each of them can identify the project, and the class of 'TaskGroup' doesn't use this field. So need to remove it from the table and improve a few wrong annotations. ![image](https://user-images.githubusercontent.com/4928204/147622409-d9407e03-a2eb-49fc-abd7-e67111027472.png) ### What you expected to happen I expect to remove the redundant field 'project_id' in the table 't_ds_task_group'. ### How to reproduce See it in the project. ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7701
https://github.com/apache/dolphinscheduler/pull/7703
5ab0135d1831c9156388d8b593417e775e2b2b84
71ccb42697e197b2668a08a83eb9bb19261b4f5a
2021-12-29T02:52:14Z
java
2021-12-29T04:57:36Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskGroupController.java
import io.swagger.annotations.ApiOperation; import org.apache.dolphinscheduler.api.aspect.AccessLogAnnotation; import org.apache.dolphinscheduler.api.exceptions.ApiException; import org.apache.dolphinscheduler.api.service.TaskGroupQueueService; import org.apache.dolphinscheduler.api.service.TaskGroupService; import org.apache.dolphinscheduler.api.utils.Result; import org.apache.dolphinscheduler.common.Constants; import org.apache.dolphinscheduler.dao.entity.User; import java.util.Map; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.http.HttpStatus; import org.springframework.web.bind.annotation.GetMapping; import org.springframework.web.bind.annotation.PostMapping; import org.springframework.web.bind.annotation.RequestAttribute; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RequestParam; import org.springframework.web.bind.annotation.ResponseStatus; import org.springframework.web.bind.annotation.RestController; import springfox.documentation.annotations.ApiIgnore; import java.util.Map; import static org.apache.dolphinscheduler.api.enums.Status.CLOSE_TASK_GROUP_ERROR; import static org.apache.dolphinscheduler.api.enums.Status.CREATE_TASK_GROUP_ERROR; import static org.apache.dolphinscheduler.api.enums.Status.QUERY_TASK_GROUP_LIST_ERROR; import static org.apache.dolphinscheduler.api.enums.Status.QUERY_TASK_GROUP_QUEUE_LIST_ERROR; import static org.apache.dolphinscheduler.api.enums.Status.START_TASK_GROUP_ERROR; import static org.apache.dolphinscheduler.api.enums.Status.UPDATE_TASK_GROUP_ERROR; /** * task group controller */ @Api(tags = "task group")
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
7,701
[Bug] [DAO] There's an redundant field named 'project_id' in the table of 't_ds_task_group'.
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened In the table of 't_ds_task_group' there's two fields of 'project_code' and 'project_id'. Each of them can identify the project, and the class of 'TaskGroup' doesn't use this field. So need to remove it from the table and improve a few wrong annotations. ![image](https://user-images.githubusercontent.com/4928204/147622409-d9407e03-a2eb-49fc-abd7-e67111027472.png) ### What you expected to happen I expect to remove the redundant field 'project_id' in the table 't_ds_task_group'. ### How to reproduce See it in the project. ### Anything else _No response_ ### Version dev ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
https://github.com/apache/dolphinscheduler/issues/7701
https://github.com/apache/dolphinscheduler/pull/7703
5ab0135d1831c9156388d8b593417e775e2b2b84
71ccb42697e197b2668a08a83eb9bb19261b4f5a
2021-12-29T02:52:14Z
java
2021-12-29T04:57:36Z
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskGroupController.java
@RestController @RequestMapping("/task-group") public class TaskGroupController extends BaseController { @Autowired private TaskGroupService taskGroupService; /** * query task group list * * @param loginUser login user * @param name name * @param description description * @param groupSize group size * @param name project id * @return result and msg code */ @ApiOperation(value = "create", notes = "CREATE_TAKS_GROUP_NOTE")