status
stringclasses 1
value | repo_name
stringclasses 31
values | repo_url
stringclasses 31
values | issue_id
int64 1
104k
| title
stringlengths 4
233
| body
stringlengths 0
186k
⌀ | issue_url
stringlengths 38
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[us, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] | updated_file
stringlengths 7
188
| chunk_content
stringlengths 1
1.03M
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
|
return startNodeNameLst;
}
/**
* generate start node code lst from parsng command param;
* f "StartNodeIdLst" exsts n command param, return StartNodeIdLst
*
* @return recovery node code lst
*/
prvate Lst<Strng> getRecoveryNodeCodeLst(Lst<TaskInstance> recoverNodeLst) {
Lst<Strng> recoveryNodeCodeLst = new ArrayLst<>();
f (CollectonUtls.sNotEmpty(recoverNodeLst)) {
for (TaskInstance task : recoverNodeLst) {
recoveryNodeCodeLst.add(Long.toStrng(task.getTaskCode()));
}
}
return recoveryNodeCodeLst;
}
/**
* generate flow dag
*
* @param totalTaskNodeLst total task node lst
* @param startNodeNameLst start node name lst
* @param recoveryNodeCodeLst recovery node code lst
* @param depNodeType depend node type
* @return ProcessDag process dag
* @throws Excepton excepton
*/
publc ProcessDag generateFlowDag(Lst<TaskNode> totalTaskNodeLst,
Lst<Strng> startNodeNameLst,
Lst<Strng> recoveryNodeCodeLst,
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
|
TaskDependType depNodeType) throws Excepton {
return DagHelper.generateFlowDag(totalTaskNodeLst, startNodeNameLst, recoveryNodeCodeLst, depNodeType);
}
/**
* check task queue
*/
prvate boolean checkTaskQueue() {
AtomcBoolean result = new AtomcBoolean(false);
taskInstanceMap.forEach((d, taskInstance) -> {
f (taskInstance != null && taskInstance.getTaskGroupId() > 0) {
result.set(true);
}
});
return result.get();
}
/**
* s new process nstance
*/
prvate boolean sNewProcessInstance() {
f (Flag.YES.equals(processInstance.getRecovery())) {
logger.nfo("Ths workInstance wll be recover by ths executon");
return false;
}
f (WorkflowExecutonStatus.RUNNING_EXECUTION == processInstance.getState()
&& processInstance.getRunTmes() == 1) {
return true;
}
logger.nfo(
"The workflowInstance has been executed before, ths executon s to reRun, processInstance status: {}, runTmes: {}",
processInstance.getState(),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
|
processInstance.getRunTmes());
return false;
}
publc vod resubmt(long taskCode) throws Excepton {
ITaskProcessor taskProcessor = actveTaskProcessorMaps.get(taskCode);
f (taskProcessor != null) {
taskProcessor.acton(TaskActon.RESUBMIT);
logger.debug("RESUBMIT: task code:{}", taskCode);
} else {
throw new Excepton("resubmt error, taskProcessor s null, task code: " + taskCode);
}
}
publc Map<Long, Integer> getCompleteTaskMap() {
return completeTaskMap;
}
publc Map<Long, ITaskProcessor> getActveTaskProcessMap() {
return actveTaskProcessorMaps;
}
publc Map<Long, TaskInstance> getWatToRetryTaskInstanceMap() {
return watToRetryTaskInstanceMap;
}
prvate vod setGlobalParamIfCommanded(ProcessDefnton processDefnton, Map<Strng, Strng> cmdParam) {
// get start params from command param
Map<Strng, Strng> startParamMap = new HashMap<>();
f (cmdParam.contansKey(Constants.CMD_PARAM_START_PARAMS)) {
Strng startParamJson = cmdParam.get(Constants.CMD_PARAM_START_PARAMS);
startParamMap = JSONUtls.toMap(startParamJson);
}
Map<Strng, Strng> fatherParamMap = new HashMap<>();
f (cmdParam.contansKey(Constants.CMD_PARAM_FATHER_PARAMS)) {
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
|
Strng fatherParamJson = cmdParam.get(Constants.CMD_PARAM_FATHER_PARAMS);
fatherParamMap = JSONUtls.toMap(fatherParamJson);
}
startParamMap.putAll(fatherParamMap);
// set start param nto global params
Map<Strng, Strng> globalMap = processDefnton.getGlobalParamMap();
Lst<Property> globalParamLst = processDefnton.getGlobalParamLst();
f (startParamMap.sze() > 0 && globalMap != null) {
// start p
for (Map.Entry<Strng, Strng> param : globalMap.entrySet()) {
Strng val = startParamMap.get(param.getKey());
f (val != null) {
param.setValue(val);
}
}
// start p
for (Map.Entry<Strng, Strng> startParam : startParamMap.entrySet()) {
f (!globalMap.contansKey(startParam.getKey())) {
globalMap.put(startParam.getKey(), startParam.getValue());
globalParamLst.add(new Property(startParam.getKey(), IN, VARCHAR, startParam.getValue()));
}
}
}
}
prvate enum WorkflowRunnableStatus {
CREATED, INITIALIZE_DAG, INITIALIZE_QUEUE, STARTED,
;
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.service.alert;
import org.apache.dolphinscheduler.common.enums.AlertType;
import org.apache.dolphinscheduler.common.enums.CommandType;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
import org.apache.dolphinscheduler.common.enums.Flag;
import org.apache.dolphinscheduler.common.enums.WarningType;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.dao.AlertDao;
import org.apache.dolphinscheduler.dao.entity.Alert;
import org.apache.dolphinscheduler.dao.entity.DqExecuteResult;
import org.apache.dolphinscheduler.dao.entity.DqExecuteResultAlertContent;
import org.apache.dolphinscheduler.dao.entity.ProcessAlertContent;
import org.apache.dolphinscheduler.dao.entity.ProcessInstance;
import org.apache.dolphinscheduler.dao.entity.ProjectUser;
import org.apache.dolphinscheduler.dao.entity.TaskAlertContent;
import org.apache.dolphinscheduler.dao.entity.TaskInstance;
import org.apache.dolphinscheduler.plugin.task.api.enums.dp.DqTaskState;
import org.apache.commons.collections4.CollectionUtils;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
/**
* process alert manager
*/
@Component
public class ProcessAlertManager {
/**
* logger of AlertManager
*/
private static final Logger logger = LoggerFactory.getLogger(ProcessAlertManager.class);
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
/**
* alert dao
*/
@Autowired
private AlertDao alertDao;
/**
* command type convert chinese
*
* @param commandType command type
* @return command name
*/
private String getCommandCnName(CommandType commandType) {
switch (commandType) {
case RECOVER_TOLERANCE_FAULT_PROCESS:
return "recover tolerance fault process";
case RECOVER_SUSPENDED_PROCESS:
return "recover suspended process";
case START_CURRENT_TASK_PROCESS:
return "start current task process";
case START_FAILURE_TASK_PROCESS:
return "start failure task process";
case START_PROCESS:
return "start process";
case REPEAT_RUNNING:
return "repeat running";
case SCHEDULER:
return "scheduler";
case COMPLEMENT_DATA:
return "complement data";
case PAUSE:
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
return "pause";
case STOP:
return "stop";
default:
return "unknown type";
}
}
/**
* get process instance content
*
* @param processInstance process instance
* @param taskInstances task instance list
* @return process instance format content
*/
public String getContentProcessInstance(ProcessInstance processInstance,
List<TaskInstance> taskInstances,
ProjectUser projectUser) {
String res = "";
if (processInstance.getState().isSuccess()) {
List<ProcessAlertContent> successTaskList = new ArrayList<>(1);
ProcessAlertContent processAlertContent = ProcessAlertContent.builder()
.projectCode(projectUser.getProjectCode())
.projectName(projectUser.getProjectName())
.owner(projectUser.getUserName())
.processId(processInstance.getId())
.processDefinitionCode(processInstance.getProcessDefinitionCode())
.processName(processInstance.getName())
.processType(processInstance.getCommandType())
.processState(processInstance.getState())
.recovery(processInstance.getRecovery())
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
.runTimes(processInstance.getRunTimes())
.processStartTime(processInstance.getStartTime())
.processEndTime(processInstance.getEndTime())
.processHost(processInstance.getHost())
.build();
successTaskList.add(processAlertContent);
res = JSONUtils.toJsonString(successTaskList);
} else if (processInstance.getState().isFailure()) {
List<ProcessAlertContent> failedTaskList = new ArrayList<>();
for (TaskInstance task : taskInstances) {
if (task.getState().isSuccess()) {
continue;
}
ProcessAlertContent processAlertContent = ProcessAlertContent.builder()
.projectCode(projectUser.getProjectCode())
.projectName(projectUser.getProjectName())
.owner(projectUser.getUserName())
.processId(processInstance.getId())
.processDefinitionCode(processInstance.getProcessDefinitionCode())
.processName(processInstance.getName())
.taskCode(task.getTaskCode())
.taskName(task.getName())
.taskType(task.getTaskType())
.taskState(task.getState())
.taskStartTime(task.getStartTime())
.taskEndTime(task.getEndTime())
.taskHost(task.getHost())
.logPath(task.getLogPath())
.build();
failedTaskList.add(processAlertContent);
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
}
res = JSONUtils.toJsonString(failedTaskList);
}
return res;
}
/**
* getting worker fault tolerant content
*
* @param processInstance process instance
* @param toleranceTaskList tolerance task list
* @return worker tolerance content
*/
private String getWorkerToleranceContent(ProcessInstance processInstance, List<TaskInstance> toleranceTaskList) {
List<ProcessAlertContent> toleranceTaskInstanceList = new ArrayList<>();
for (TaskInstance taskInstance : toleranceTaskList) {
ProcessAlertContent processAlertContent = ProcessAlertContent.builder()
.processId(processInstance.getId())
.processDefinitionCode(processInstance.getProcessDefinitionCode())
.processName(processInstance.getName())
.taskCode(taskInstance.getTaskCode())
.taskName(taskInstance.getName())
.taskHost(taskInstance.getHost())
.retryTimes(taskInstance.getRetryTimes())
.build();
toleranceTaskInstanceList.add(processAlertContent);
}
return JSONUtils.toJsonString(toleranceTaskInstanceList);
}
/**
* send worker alert fault tolerance
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
*
* @param processInstance process instance
* @param toleranceTaskList tolerance task list
*/
public void sendAlertWorkerToleranceFault(ProcessInstance processInstance, List<TaskInstance> toleranceTaskList) {
try {
Alert alert = new Alert();
alert.setTitle("worker fault tolerance");
String content = getWorkerToleranceContent(processInstance, toleranceTaskList);
alert.setContent(content);
alert.setWarningType(WarningType.FAILURE);
alert.setCreateTime(new Date());
alert.setAlertGroupId(
processInstance.getWarningGroupId() == null ? 1 : processInstance.getWarningGroupId());
alert.setAlertType(AlertType.FAULT_TOLERANCE_WARNING);
alertDao.addAlert(alert);
logger.info("add alert to db , alert : {}", alert);
} catch (Exception e) {
logger.error("send alert failed:{} ", e.getMessage());
}
}
/**
* send process instance alert
*
* @param processInstance process instance
* @param taskInstances task instance list
*/
public void sendAlertProcessInstance(ProcessInstance processInstance,
List<TaskInstance> taskInstances,
ProjectUser projectUser) {
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
if (!isNeedToSendWarning(processInstance)) {
return;
}
Alert alert = new Alert();
String cmdName = getCommandCnName(processInstance.getCommandType());
String success = processInstance.getState().isSuccess() ? "success" : "failed";
alert.setTitle(cmdName + " " + success);
alert.setWarningType(processInstance.getState().isSuccess() ? WarningType.SUCCESS : WarningType.FAILURE);
String content = getContentProcessInstance(processInstance, taskInstances, projectUser);
alert.setContent(content);
alert.setAlertGroupId(processInstance.getWarningGroupId());
alert.setCreateTime(new Date());
alert.setProjectCode(projectUser.getProjectCode());
alert.setProcessDefinitionCode(processInstance.getProcessDefinitionCode());
alert.setProcessInstanceId(processInstance.getId());
alert.setAlertType(processInstance.getState().isSuccess() ? AlertType.PROCESS_INSTANCE_SUCCESS
: AlertType.PROCESS_INSTANCE_FAILURE);
alertDao.addAlert(alert);
logger.info("add alert to db , alert: {}", alert);
}
/**
* check if need to be send warning
*
* @param processInstance
* @return
*/
public boolean isNeedToSendWarning(ProcessInstance processInstance) {
if (Flag.YES == processInstance.getIsSubProcess()) {
return false;
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
boolean sendWarning = false;
WarningType warningType = processInstance.getWarningType();
switch (warningType) {
case ALL:
if (processInstance.getState().isFinished()) {
sendWarning = true;
}
break;
case SUCCESS:
if (processInstance.getState().isSuccess()) {
sendWarning = true;
}
break;
case FAILURE:
if (processInstance.getState().isFailure()) {
sendWarning = true;
}
break;
default:
}
return sendWarning;
}
/**
* Send a close alert event, if the processInstance has sent alert before, then will insert a closed event.
*
* @param processInstance success process instance
*/
public void closeAlert(ProcessInstance processInstance) {
List<Alert> alerts = alertDao.listAlerts(processInstance.getId());
if (CollectionUtils.isEmpty(alerts)) {
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
return;
}
Alert alert = new Alert();
alert.setAlertGroupId(processInstance.getWarningGroupId());
alert.setUpdateTime(new Date());
alert.setCreateTime(new Date());
alert.setProjectCode(processInstance.getProcessDefinition().getProjectCode());
alert.setProcessDefinitionCode(processInstance.getProcessDefinitionCode());
alert.setProcessInstanceId(processInstance.getId());
alert.setAlertType(AlertType.CLOSE_ALERT);
alertDao.addAlert(alert);
}
/**
* send process timeout alert
*
* @param processInstance process instance
* @param projectUser projectUser
*/
public void sendProcessTimeoutAlert(ProcessInstance processInstance, ProjectUser projectUser) {
alertDao.sendProcessTimeoutAlert(processInstance, projectUser);
}
/**
* send data quality task alert
*/
public void sendDataQualityTaskExecuteResultAlert(DqExecuteResult result, ProcessInstance processInstance) {
Alert alert = new Alert();
String state = DqTaskState.of(result.getState()).getDescription();
alert.setTitle("DataQualityResult [" + result.getTaskName() + "] " + state);
String content = getDataQualityAlterContent(result);
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
alert.setContent(content);
alert.setAlertGroupId(processInstance.getWarningGroupId());
alert.setCreateTime(new Date());
alert.setProjectCode(result.getProjectCode());
alert.setProcessDefinitionCode(processInstance.getProcessDefinitionCode());
alert.setProcessInstanceId(processInstance.getId());
alert.setAlertType(processInstance.getState().isSuccess() ? AlertType.PROCESS_INSTANCE_SUCCESS
: AlertType.PROCESS_INSTANCE_FAILURE);
alertDao.addAlert(alert);
logger.info("add alert to db , alert: {}", alert);
}
/**
* send data quality task error alert
*/
public void sendTaskErrorAlert(TaskInstance taskInstance, ProcessInstance processInstance) {
Alert alert = new Alert();
alert.setTitle("Task [" + taskInstance.getName() + "] Failure Warning");
String content = getTaskAlterContent(taskInstance);
alert.setContent(content);
alert.setAlertGroupId(processInstance.getWarningGroupId());
alert.setCreateTime(new Date());
alert.setProcessDefinitionCode(processInstance.getProcessDefinitionCode());
alert.setProcessInstanceId(processInstance.getId());
alert.setAlertType(AlertType.TASK_FAILURE);
alertDao.addAlert(alert);
logger.info("add alert to db , alert: {}", alert);
}
/**
* getDataQualityAlterContent
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
* @param result DqExecuteResult
* @return String String
*/
public String getDataQualityAlterContent(DqExecuteResult result) {
DqExecuteResultAlertContent content = DqExecuteResultAlertContent.newBuilder()
.processDefinitionId(result.getProcessDefinitionId())
.processDefinitionName(result.getProcessDefinitionName())
.processInstanceId(result.getProcessInstanceId())
.processInstanceName(result.getProcessInstanceName())
.taskInstanceId(result.getTaskInstanceId())
.taskName(result.getTaskName())
.ruleType(result.getRuleType())
.ruleName(result.getRuleName())
.statisticsValue(result.getStatisticsValue())
.comparisonValue(result.getComparisonValue())
.checkType(result.getCheckType())
.threshold(result.getThreshold())
.operator(result.getOperator())
.failureStrategy(result.getFailureStrategy())
.userId(result.getUserId())
.userName(result.getUserName())
.state(result.getState())
.errorDataPath(result.getErrorOutputPath())
.build();
return JSONUtils.toJsonString(content);
}
/**
* getTaskAlterContent
* @param taskInstance TaskInstance
* @return String String
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
*/
public String getTaskAlterContent(TaskInstance taskInstance) {
TaskAlertContent content = TaskAlertContent.builder()
.processInstanceName(taskInstance.getProcessInstanceName())
.processInstanceId(taskInstance.getProcessInstanceId())
.taskInstanceId(taskInstance.getId())
.taskName(taskInstance.getName())
.taskType(taskInstance.getTaskType())
.state(taskInstance.getState())
.startTime(taskInstance.getStartTime())
.endTime(taskInstance.getEndTime())
.host(taskInstance.getHost())
.logPath(taskInstance.getLogPath())
.build();
return JSONUtils.toJsonString(content);
}
public void sendTaskTimeoutAlert(ProcessInstance processInstance, TaskInstance taskInstance,
ProjectUser projectUser) {
alertDao.sendTaskTimeoutAlert(processInstance, taskInstance, projectUser);
}
/**
*
* check node type and process blocking flag, then insert a block record into db
*
* @param processInstance process instance
* @param projectUser the project owner
*/
public void sendProcessBlockingAlert(ProcessInstance processInstance,
ProjectUser projectUser) {
Alert alert = new Alert();
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,753 |
[Bug] [Alert Server] send alert error alert data id
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
when I want to test Email send when a task finish , I get a error :
[INFO] 2022-09-02 08:00:11.268 +0000 org.apache.dolphinscheduler.alert.AlertRequestProcessor:[52] - Received command : AlertSendRequestCommand{groupId=0, title='sql_hive query result sets', content='[{"_c0":36816}]', warnType=1}
[ERROR] 2022-09-02 08:00:11.270 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[148] - Alert GroupId 0 send error : not found alert instance
[ERROR] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[244] - send alert error alert data id :57,
java.lang.NullPointerException: User must not be null
at java.util.Objects.requireNonNull(Objects.java:228)
at org.apache.dolphinscheduler.plugin.alert.email.MailSender.<init>(MailSender.java:109)
at org.apache.dolphinscheduler.plugin.alert.email.EmailAlertChannel.process(EmailAlertChannel.java:41)
at org.apache.dolphinscheduler.alert.AlertSenderService.alertResultHandler(AlertSenderService.java:232)
at org.apache.dolphinscheduler.alert.AlertSenderService.send(AlertSenderService.java:105)
at org.apache.dolphinscheduler.alert.AlertSenderService.run(AlertSenderService.java:76)
[INFO] 2022-09-02 08:00:14.699 +0000 org.apache.dolphinscheduler.alert.AlertSenderService:[255] - Alert Plugin Email-Alert send error : User must not be null
### What you expected to happen
I should got a Email when a task finish
### How to reproduce
create a Email group , smtp then I create a test task , run It with a Email group ,then will get the same error
### Anything else
dolphin 3.0 pseudo-cluster install
### Version
3.0.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11753
|
https://github.com/apache/dolphinscheduler/pull/11774
|
57fafe42567b434d5a8ef4673ca5d9796cc4dd05
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
| 2022-09-02T08:19:12Z |
java
| 2022-09-29T07:34:40Z |
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java
|
String cmdName = getCommandCnName(processInstance.getCommandType());
List<ProcessAlertContent> blockingNodeList = new ArrayList<>(1);
ProcessAlertContent processAlertContent = ProcessAlertContent.builder()
.projectCode(projectUser.getProjectCode())
.projectName(projectUser.getProjectName())
.owner(projectUser.getUserName())
.processId(processInstance.getId())
.processName(processInstance.getName())
.processType(processInstance.getCommandType())
.processState(processInstance.getState())
.runTimes(processInstance.getRunTimes())
.processStartTime(processInstance.getStartTime())
.processEndTime(processInstance.getEndTime())
.processHost(processInstance.getHost())
.build();
blockingNodeList.add(processAlertContent);
String content = JSONUtils.toJsonString(blockingNodeList);
alert.setTitle(cmdName + " Blocked");
alert.setContent(content);
alert.setAlertGroupId(processInstance.getWarningGroupId());
alert.setCreateTime(new Date());
alert.setProjectCode(projectUser.getProjectCode());
alert.setProcessDefinitionCode(processInstance.getProcessDefinitionCode());
alert.setProcessInstanceId(processInstance.getId());
alert.setAlertType(AlertType.PROCESS_INSTANCE_BLOCKED);
alertDao.addAlert(alert);
logger.info("add alert to db, alert: {}", alert);
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.processor;
import com.google.common.base.Preconditions;
import io.micrometer.core.annotation.Counted;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
import io.micrometer.core.annotation.Timed;
import io.netty.channel.Channel;
import org.apache.dolphinscheduler.common.storage.StorageOperate;
import org.apache.dolphinscheduler.common.utils.DateUtils;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.LoggerUtils;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContext;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContextCacheManager;
import org.apache.dolphinscheduler.plugin.task.api.enums.TaskExecutionStatus;
import org.apache.dolphinscheduler.remote.command.Command;
import org.apache.dolphinscheduler.remote.command.CommandType;
import org.apache.dolphinscheduler.remote.command.TaskDispatchCommand;
import org.apache.dolphinscheduler.remote.processor.NettyRequestProcessor;
import org.apache.dolphinscheduler.server.utils.LogUtils;
import org.apache.dolphinscheduler.server.worker.config.WorkerConfig;
import org.apache.dolphinscheduler.server.worker.metrics.TaskMetrics;
import org.apache.dolphinscheduler.server.worker.rpc.WorkerMessageSender;
import org.apache.dolphinscheduler.server.worker.runner.WorkerDelayTaskExecuteRunnable;
import org.apache.dolphinscheduler.server.worker.runner.WorkerManagerThread;
import org.apache.dolphinscheduler.server.worker.runner.WorkerTaskExecuteRunnableFactoryBuilder;
import org.apache.dolphinscheduler.service.alert.AlertClientService;
import org.apache.dolphinscheduler.service.task.TaskPluginManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
/**
* Used to handle {@link CommandType#TASK_DISPATCH_REQUEST}
*/
@Component
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
public class TaskDispatchProcessor implements NettyRequestProcessor {
private static final Logger logger = LoggerFactory.getLogger(TaskDispatchProcessor.class);
@Autowired
private WorkerConfig workerConfig;
/**
* task callback service
*/
@Autowired
private WorkerMessageSender workerMessageSender;
/**
* alert client service
*/
@Autowired
private AlertClientService alertClientService;
@Autowired
private TaskPluginManager taskPluginManager;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
/**
* task execute manager
*/
@Autowired
private WorkerManagerThread workerManager;
@Autowired(required = false)
private StorageOperate storageOperate;
@Counted(value = "ds.task.execution.count", description = "task execute total count")
@Timed(value = "ds.task.execution.duration", percentiles = {0.5, 0.75, 0.95, 0.99}, histogram = true)
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_DISPATCH_REQUEST == command.getType(),
String.format("invalid command type : %s", command.getType()));
TaskDispatchCommand taskDispatchCommand = JSONUtils.parseObject(command.getBody(), TaskDispatchCommand.class);
if (taskDispatchCommand == null) {
logger.error("task execute request command content is null");
return;
}
final String workflowMasterAddress = taskDispatchCommand.getMessageSenderAddress();
logger.info("task execute request message: {}", taskDispatchCommand);
TaskExecutionContext taskExecutionContext = taskDispatchCommand.getTaskExecutionContext();
if (taskExecutionContext == null) {
logger.error("task execution context is null");
return;
}
try {
LoggerUtils.setWorkflowAndTaskInstanceIDMDC(taskExecutionContext.getProcessInstanceId(), taskExecutionContext.getTaskInstanceId());
TaskMetrics.incrTaskTypeExecuteCount(taskExecutionContext.getTaskType());
TaskExecutionContextCacheManager.cacheTaskExecutionContext(taskExecutionContext);
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
taskExecutionContext.setHost(workerConfig.getWorkerAddress());
taskExecutionContext.setLogPath(LogUtils.getTaskLogPath(taskExecutionContext));
long remainTime = DateUtils.getRemainTime(taskExecutionContext.getFirstSubmitTime(), taskExecutionContext.getDelayTime() * 60L);
if (remainTime > 0) {
logger.info("Current taskInstance is choose delay execution, delay time: {}s", remainTime);
taskExecutionContext.setCurrentExecutionStatus(TaskExecutionStatus.DELAY_EXECUTION);
workerMessageSender.sendMessage(taskExecutionContext, workflowMasterAddress, CommandType.TASK_EXECUTE_RESULT);
}
WorkerDelayTaskExecuteRunnable workerTaskExecuteRunnable = WorkerTaskExecuteRunnableFactoryBuilder.createWorkerDelayTaskExecuteRunnableFactory(
taskExecutionContext,
workerConfig,
workflowMasterAddress,
workerMessageSender,
alertClientService,
taskPluginManager,
storageOperate)
.createWorkerTaskExecuteRunnable();
boolean offer = workerManager.offer(workerTaskExecuteRunnable);
if (!offer) {
logger.warn("submit task to wait queue error, queue is full, current queue size is {}, will send a task reject message to master", workerManager.getWaitSubmitQueueSize());
workerMessageSender.sendMessageWithRetry(taskExecutionContext, workflowMasterAddress, CommandType.TASK_REJECT);
}
} finally {
LoggerUtils.removeWorkflowAndTaskInstanceIdMDC();
}
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteResultAckProcessor.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteResultAckProcessor.java
|
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.processor;
import com.google.common.base.Preconditions;
import io.netty.channel.Channel;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.LoggerUtils;
import org.apache.dolphinscheduler.remote.command.Command;
import org.apache.dolphinscheduler.remote.command.CommandType;
import org.apache.dolphinscheduler.remote.command.TaskExecuteAckCommand;
import org.apache.dolphinscheduler.remote.processor.NettyRequestProcessor;
import org.apache.dolphinscheduler.server.worker.message.MessageRetryRunner;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
/**
* task execute running ack, from master to worker
*/
@Component
public class TaskExecuteResultAckProcessor implements NettyRequestProcessor {
private final Logger logger = LoggerFactory.getLogger(TaskExecuteResultAckProcessor.class);
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteResultAckProcessor.java
|
@Autowired
private MessageRetryRunner messageRetryRunner;
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_EXECUTE_RESULT_ACK == command.getType(),
String.format("invalid command type : %s", command.getType()));
TaskExecuteAckCommand taskExecuteAckMessage = JSONUtils.parseObject(command.getBody(),
TaskExecuteAckCommand.class);
if (taskExecuteAckMessage == null) {
logger.error("task execute response ack command is null");
return;
}
logger.info("task execute response ack command : {}", taskExecuteAckMessage);
try {
LoggerUtils.setTaskInstanceIdMDC(taskExecuteAckMessage.getTaskInstanceId());
if (taskExecuteAckMessage.isSuccess()) {
messageRetryRunner.removeRetryMessage(taskExecuteAckMessage.getTaskInstanceId(),
CommandType.TASK_EXECUTE_RESULT);
logger.debug("remove REMOTE_CHANNELS, task instance id:{}", taskExecuteAckMessage.getTaskInstanceId());
} else {
logger.error("Receive task execute result ack message, the message status is not success, message: {}",
taskExecuteAckMessage);
}
} finally {
LoggerUtils.removeTaskInstanceIdMDC();
}
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskRejectAckProcessor.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.processor;
import com.google.common.base.Preconditions;
import io.netty.channel.Channel;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.LoggerUtils;
import org.apache.dolphinscheduler.remote.command.Command;
import org.apache.dolphinscheduler.remote.command.CommandType;
import org.apache.dolphinscheduler.remote.command.TaskRejectAckCommand;
import org.apache.dolphinscheduler.remote.processor.NettyRequestProcessor;
import org.apache.dolphinscheduler.server.worker.message.MessageRetryRunner;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskRejectAckProcessor.java
|
@Component
public class TaskRejectAckProcessor implements NettyRequestProcessor {
private final Logger logger = LoggerFactory.getLogger(TaskRejectAckProcessor.class);
@Autowired
private MessageRetryRunner messageRetryRunner;
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_REJECT_ACK == command.getType(),
String.format("invalid command type : %s", command.getType()));
TaskRejectAckCommand taskRejectAckMessage = JSONUtils.parseObject(command.getBody(),
TaskRejectAckCommand.class);
if (taskRejectAckMessage == null) {
return;
}
try {
LoggerUtils.setTaskInstanceIdMDC(taskRejectAckMessage.getTaskInstanceId());
if (taskRejectAckMessage.isSuccess()) {
messageRetryRunner.removeRetryMessage(taskRejectAckMessage.getTaskInstanceId(),
CommandType.TASK_REJECT);
logger.debug("removeRecallCache: task instance id:{}", taskRejectAckMessage.getTaskInstanceId());
} else {
logger.error("Receive task reject ack message, the message status is not success, message: {}",
taskRejectAckMessage);
}
} finally {
LoggerUtils.removeTaskInstanceIdMDC();
}
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskSavePointProcessor.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.processor;
import com.google.common.base.Preconditions;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskSavePointProcessor.java
|
import io.netty.channel.Channel;
import io.netty.channel.ChannelFuture;
import io.netty.channel.ChannelFutureListener;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.plugin.task.api.AbstractTask;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContext;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContextCacheManager;
import org.apache.dolphinscheduler.plugin.task.api.stream.StreamTask;
import org.apache.dolphinscheduler.remote.command.Command;
import org.apache.dolphinscheduler.remote.command.CommandType;
import org.apache.dolphinscheduler.remote.command.TaskSavePointRequestCommand;
import org.apache.dolphinscheduler.remote.command.TaskSavePointResponseCommand;
import org.apache.dolphinscheduler.remote.processor.NettyRequestProcessor;
import org.apache.dolphinscheduler.server.worker.runner.WorkerManagerThread;
import org.apache.dolphinscheduler.server.worker.runner.WorkerTaskExecuteRunnable;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
/**
* task save point processor
*/
@Component
public class TaskSavePointProcessor implements NettyRequestProcessor {
private final Logger logger = LoggerFactory.getLogger(TaskSavePointProcessor.class);
/**
* task execute manager
*/
@Autowired
private WorkerManagerThread workerManager;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskSavePointProcessor.java
|
/**
* task save point process
*
* @param channel channel channel
* @param command command command
*/
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_SAVEPOINT_REQUEST == command.getType(),
String.format("invalid command type : %s", command.getType()));
TaskSavePointRequestCommand taskSavePointRequestCommand = JSONUtils.parseObject(command.getBody(), TaskSavePointRequestCommand.class);
if (taskSavePointRequestCommand == null) {
logger.error("task savepoint request command is null");
return;
}
logger.info("task savepoint command : {}", taskSavePointRequestCommand);
int taskInstanceId = taskSavePointRequestCommand.getTaskInstanceId();
TaskExecutionContext taskExecutionContext = TaskExecutionContextCacheManager.getByTaskInstanceId(taskInstanceId);
if (taskExecutionContext == null) {
logger.error("taskRequest cache is null, taskInstanceId: {}", taskSavePointRequestCommand.getTaskInstanceId());
return;
}
doSavePoint(taskInstanceId);
sendTaskSavePointResponseCommand(channel, taskExecutionContext);
}
private void sendTaskSavePointResponseCommand(Channel channel, TaskExecutionContext taskExecutionContext) {
TaskSavePointResponseCommand taskSavePointResponseCommand = new TaskSavePointResponseCommand();
taskSavePointResponseCommand.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
channel.writeAndFlush(taskSavePointResponseCommand.convert2Command()).addListener(new ChannelFutureListener() {
@Override
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskSavePointProcessor.java
|
public void operationComplete(ChannelFuture future) throws Exception {
if (!future.isSuccess()) {
logger.error("Submit kill response to master error, kill command: {}", taskSavePointResponseCommand);
}
}
});
}
protected void doSavePoint(int taskInstanceId) {
WorkerTaskExecuteRunnable workerTaskExecuteRunnable = workerManager.getTaskExecuteThread(taskInstanceId);
if (workerTaskExecuteRunnable == null) {
logger.warn("taskExecuteThread not found, taskInstanceId:{}", taskInstanceId);
return;
}
AbstractTask task = workerTaskExecuteRunnable.getTask();
if (task == null) {
logger.warn("task not found, taskInstanceId:{}", taskInstanceId);
return;
}
if (!(task instanceof StreamTask)) {
logger.warn("task is not stream task");
return;
}
try {
((StreamTask)task).savePoint();
} catch (Exception e) {
logger.error("task save point error", e);
}
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
package org.apache.dolphinscheduler.server.worker.runner;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.lifecycle.ServerLifeCycleManager;
import org.apache.dolphinscheduler.common.thread.ThreadUtils;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContextCacheManager;
import org.apache.dolphinscheduler.server.worker.config.WorkerConfig;
import org.apache.dolphinscheduler.server.worker.metrics.WorkerServerMetrics;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.stereotype.Component;
import javax.annotation.Nullable;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.DelayQueue;
/**
* Manage tasks
*/
@Component
public class WorkerManagerThread implements Runnable {
private final Logger logger = LoggerFactory.getLogger(WorkerManagerThread.class);
private final DelayQueue<WorkerDelayTaskExecuteRunnable> waitSubmitQueue;
private final WorkerExecService workerExecService;
private final int workerExecThreads;
/**
* running task
*/
private final ConcurrentHashMap<Integer, WorkerTaskExecuteRunnable> taskExecuteThreadMap = new ConcurrentHashMap<>();
public WorkerManagerThread(WorkerConfig workerConfig) {
workerExecThreads = workerConfig.getExecThreads();
this.waitSubmitQueue = new DelayQueue<>();
workerExecService = new WorkerExecService(
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
ThreadUtils.newDaemonFixedThreadExecutor("Worker-Execute-Thread", workerConfig.getExecThreads()),
taskExecuteThreadMap);
}
public @Nullable WorkerTaskExecuteRunnable getTaskExecuteThread(Integer taskInstanceId) {
return taskExecuteThreadMap.get(taskInstanceId);
}
/**
* get wait submit queue size
*
* @return queue size
*/
public int getWaitSubmitQueueSize() {
return waitSubmitQueue.size();
}
/**
* get thread pool queue size
*
* @return queue size
*/
public int getThreadPoolQueueSize() {
return workerExecService.getThreadPoolQueueSize();
}
/**
* Kill tasks that have not been executed, like delay task
* then send Response to Master, update the execution status of task instance
*/
public void killTaskBeforeExecuteByInstanceId(Integer taskInstanceId) {
waitSubmitQueue.stream()
.filter(taskExecuteThread -> taskExecuteThread.getTaskExecutionContext()
.getTaskInstanceId() == taskInstanceId)
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
.forEach(waitSubmitQueue::remove);
}
public boolean offer(WorkerDelayTaskExecuteRunnable workerDelayTaskExecuteRunnable) {
if (waitSubmitQueue.size() > workerExecThreads) {
WorkerServerMetrics.incWorkerSubmitQueueIsFullCount();
ThreadUtils.sleep(Constants.SLEEP_TIME_MILLIS);
if (waitSubmitQueue.size() > workerExecThreads) {
return false;
}
}
return waitSubmitQueue.offer(workerDelayTaskExecuteRunnable);
}
public void start() {
logger.info("Worker manager thread starting");
Thread thread = new Thread(this, this.getClass().getName());
thread.setDaemon(true);
thread.start();
logger.info("Worker manager thread started");
}
@Override
public void run() {
Thread.currentThread().setName("Worker-Execute-Manager-Thread");
while (!ServerLifeCycleManager.isStopped()) {
try {
if (!ServerLifeCycleManager.isRunning()) {
Thread.sleep(Constants.SLEEP_TIME_MILLIS);
}
if (this.getThreadPoolQueueSize() <= workerExecThreads) {
final WorkerDelayTaskExecuteRunnable workerDelayTaskExecuteRunnable = waitSubmitQueue.take();
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,154 |
[Improvement][worker] Optimize the log printing of the worker module according to the log specification.
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
The log printing in the worker module has been optimized in [#10516](https://github.com/apache/dolphinscheduler/pull/10516) by using MDC, and there are still some other non-standard parts.
According to the log specification in pr [#11484](https://github.com/apache/dolphinscheduler/pull/11484), I will improve the log printing of the worker module.
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12154
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T18:24:12Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
workerExecService.submit(workerDelayTaskExecuteRunnable);
} else {
WorkerServerMetrics.incWorkerOverloadCount();
logger.info("Exec queue is full, waiting submit queue {}, waiting exec queue size {}",
this.getWaitSubmitQueueSize(), this.getThreadPoolQueueSize());
ThreadUtils.sleep(Constants.SLEEP_TIME_MILLIS);
}
} catch (Exception e) {
logger.error("An unexpected interrupt is happened, "
+ "the exception will be ignored and this thread will continue to run", e);
}
}
}
public void clearTask() {
waitSubmitQueue.clear();
workerExecService.getTaskExecuteThreadMap().values().forEach(workerTaskExecuteRunnable -> {
int taskInstanceId = workerTaskExecuteRunnable.getTaskExecutionContext().getTaskInstanceId();
try {
workerTaskExecuteRunnable.cancelTask();
logger.info("Cancel the taskInstance in worker {}", taskInstanceId);
} catch (Exception ex) {
logger.error("Cancel the taskInstance error {}", taskInstanceId, ex);
} finally {
TaskExecutionContextCacheManager.removeByTaskInstanceId(taskInstanceId);
}
});
workerExecService.getTaskExecuteThreadMap().clear();
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.processor;
import com.google.common.base.Preconditions;
import io.micrometer.core.annotation.Counted;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
import io.micrometer.core.annotation.Timed;
import io.netty.channel.Channel;
import org.apache.dolphinscheduler.common.storage.StorageOperate;
import org.apache.dolphinscheduler.common.utils.DateUtils;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.LoggerUtils;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContext;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContextCacheManager;
import org.apache.dolphinscheduler.plugin.task.api.enums.TaskExecutionStatus;
import org.apache.dolphinscheduler.remote.command.Command;
import org.apache.dolphinscheduler.remote.command.CommandType;
import org.apache.dolphinscheduler.remote.command.TaskDispatchCommand;
import org.apache.dolphinscheduler.remote.processor.NettyRequestProcessor;
import org.apache.dolphinscheduler.server.utils.LogUtils;
import org.apache.dolphinscheduler.server.worker.config.WorkerConfig;
import org.apache.dolphinscheduler.server.worker.metrics.TaskMetrics;
import org.apache.dolphinscheduler.server.worker.rpc.WorkerMessageSender;
import org.apache.dolphinscheduler.server.worker.runner.WorkerDelayTaskExecuteRunnable;
import org.apache.dolphinscheduler.server.worker.runner.WorkerManagerThread;
import org.apache.dolphinscheduler.server.worker.runner.WorkerTaskExecuteRunnableFactoryBuilder;
import org.apache.dolphinscheduler.service.alert.AlertClientService;
import org.apache.dolphinscheduler.service.task.TaskPluginManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
/**
* Used to handle {@link CommandType#TASK_DISPATCH_REQUEST}
*/
@Component
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
public class TaskDispatchProcessor implements NettyRequestProcessor {
private static final Logger logger = LoggerFactory.getLogger(TaskDispatchProcessor.class);
@Autowired
private WorkerConfig workerConfig;
/**
* task callback service
*/
@Autowired
private WorkerMessageSender workerMessageSender;
/**
* alert client service
*/
@Autowired
private AlertClientService alertClientService;
@Autowired
private TaskPluginManager taskPluginManager;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
/**
* task execute manager
*/
@Autowired
private WorkerManagerThread workerManager;
@Autowired(required = false)
private StorageOperate storageOperate;
@Counted(value = "ds.task.execution.count", description = "task execute total count")
@Timed(value = "ds.task.execution.duration", percentiles = {0.5, 0.75, 0.95, 0.99}, histogram = true)
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_DISPATCH_REQUEST == command.getType(),
String.format("invalid command type : %s", command.getType()));
TaskDispatchCommand taskDispatchCommand = JSONUtils.parseObject(command.getBody(), TaskDispatchCommand.class);
if (taskDispatchCommand == null) {
logger.error("task execute request command content is null");
return;
}
final String workflowMasterAddress = taskDispatchCommand.getMessageSenderAddress();
logger.info("task execute request message: {}", taskDispatchCommand);
TaskExecutionContext taskExecutionContext = taskDispatchCommand.getTaskExecutionContext();
if (taskExecutionContext == null) {
logger.error("task execution context is null");
return;
}
try {
LoggerUtils.setWorkflowAndTaskInstanceIDMDC(taskExecutionContext.getProcessInstanceId(), taskExecutionContext.getTaskInstanceId());
TaskMetrics.incrTaskTypeExecuteCount(taskExecutionContext.getTaskType());
TaskExecutionContextCacheManager.cacheTaskExecutionContext(taskExecutionContext);
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskDispatchProcessor.java
|
taskExecutionContext.setHost(workerConfig.getWorkerAddress());
taskExecutionContext.setLogPath(LogUtils.getTaskLogPath(taskExecutionContext));
long remainTime = DateUtils.getRemainTime(taskExecutionContext.getFirstSubmitTime(), taskExecutionContext.getDelayTime() * 60L);
if (remainTime > 0) {
logger.info("Current taskInstance is choose delay execution, delay time: {}s", remainTime);
taskExecutionContext.setCurrentExecutionStatus(TaskExecutionStatus.DELAY_EXECUTION);
workerMessageSender.sendMessage(taskExecutionContext, workflowMasterAddress, CommandType.TASK_EXECUTE_RESULT);
}
WorkerDelayTaskExecuteRunnable workerTaskExecuteRunnable = WorkerTaskExecuteRunnableFactoryBuilder.createWorkerDelayTaskExecuteRunnableFactory(
taskExecutionContext,
workerConfig,
workflowMasterAddress,
workerMessageSender,
alertClientService,
taskPluginManager,
storageOperate)
.createWorkerTaskExecuteRunnable();
boolean offer = workerManager.offer(workerTaskExecuteRunnable);
if (!offer) {
logger.warn("submit task to wait queue error, queue is full, current queue size is {}, will send a task reject message to master", workerManager.getWaitSubmitQueueSize());
workerMessageSender.sendMessageWithRetry(taskExecutionContext, workflowMasterAddress, CommandType.TASK_REJECT);
}
} finally {
LoggerUtils.removeWorkflowAndTaskInstanceIdMDC();
}
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteResultAckProcessor.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteResultAckProcessor.java
|
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.processor;
import com.google.common.base.Preconditions;
import io.netty.channel.Channel;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.LoggerUtils;
import org.apache.dolphinscheduler.remote.command.Command;
import org.apache.dolphinscheduler.remote.command.CommandType;
import org.apache.dolphinscheduler.remote.command.TaskExecuteAckCommand;
import org.apache.dolphinscheduler.remote.processor.NettyRequestProcessor;
import org.apache.dolphinscheduler.server.worker.message.MessageRetryRunner;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
/**
* task execute running ack, from master to worker
*/
@Component
public class TaskExecuteResultAckProcessor implements NettyRequestProcessor {
private final Logger logger = LoggerFactory.getLogger(TaskExecuteResultAckProcessor.class);
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteResultAckProcessor.java
|
@Autowired
private MessageRetryRunner messageRetryRunner;
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_EXECUTE_RESULT_ACK == command.getType(),
String.format("invalid command type : %s", command.getType()));
TaskExecuteAckCommand taskExecuteAckMessage = JSONUtils.parseObject(command.getBody(),
TaskExecuteAckCommand.class);
if (taskExecuteAckMessage == null) {
logger.error("task execute response ack command is null");
return;
}
logger.info("task execute response ack command : {}", taskExecuteAckMessage);
try {
LoggerUtils.setTaskInstanceIdMDC(taskExecuteAckMessage.getTaskInstanceId());
if (taskExecuteAckMessage.isSuccess()) {
messageRetryRunner.removeRetryMessage(taskExecuteAckMessage.getTaskInstanceId(),
CommandType.TASK_EXECUTE_RESULT);
logger.debug("remove REMOTE_CHANNELS, task instance id:{}", taskExecuteAckMessage.getTaskInstanceId());
} else {
logger.error("Receive task execute result ack message, the message status is not success, message: {}",
taskExecuteAckMessage);
}
} finally {
LoggerUtils.removeTaskInstanceIdMDC();
}
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskRejectAckProcessor.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.processor;
import com.google.common.base.Preconditions;
import io.netty.channel.Channel;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.LoggerUtils;
import org.apache.dolphinscheduler.remote.command.Command;
import org.apache.dolphinscheduler.remote.command.CommandType;
import org.apache.dolphinscheduler.remote.command.TaskRejectAckCommand;
import org.apache.dolphinscheduler.remote.processor.NettyRequestProcessor;
import org.apache.dolphinscheduler.server.worker.message.MessageRetryRunner;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskRejectAckProcessor.java
|
@Component
public class TaskRejectAckProcessor implements NettyRequestProcessor {
private final Logger logger = LoggerFactory.getLogger(TaskRejectAckProcessor.class);
@Autowired
private MessageRetryRunner messageRetryRunner;
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_REJECT_ACK == command.getType(),
String.format("invalid command type : %s", command.getType()));
TaskRejectAckCommand taskRejectAckMessage = JSONUtils.parseObject(command.getBody(),
TaskRejectAckCommand.class);
if (taskRejectAckMessage == null) {
return;
}
try {
LoggerUtils.setTaskInstanceIdMDC(taskRejectAckMessage.getTaskInstanceId());
if (taskRejectAckMessage.isSuccess()) {
messageRetryRunner.removeRetryMessage(taskRejectAckMessage.getTaskInstanceId(),
CommandType.TASK_REJECT);
logger.debug("removeRecallCache: task instance id:{}", taskRejectAckMessage.getTaskInstanceId());
} else {
logger.error("Receive task reject ack message, the message status is not success, message: {}",
taskRejectAckMessage);
}
} finally {
LoggerUtils.removeTaskInstanceIdMDC();
}
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskSavePointProcessor.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.processor;
import com.google.common.base.Preconditions;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskSavePointProcessor.java
|
import io.netty.channel.Channel;
import io.netty.channel.ChannelFuture;
import io.netty.channel.ChannelFutureListener;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.plugin.task.api.AbstractTask;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContext;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContextCacheManager;
import org.apache.dolphinscheduler.plugin.task.api.stream.StreamTask;
import org.apache.dolphinscheduler.remote.command.Command;
import org.apache.dolphinscheduler.remote.command.CommandType;
import org.apache.dolphinscheduler.remote.command.TaskSavePointRequestCommand;
import org.apache.dolphinscheduler.remote.command.TaskSavePointResponseCommand;
import org.apache.dolphinscheduler.remote.processor.NettyRequestProcessor;
import org.apache.dolphinscheduler.server.worker.runner.WorkerManagerThread;
import org.apache.dolphinscheduler.server.worker.runner.WorkerTaskExecuteRunnable;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
/**
* task save point processor
*/
@Component
public class TaskSavePointProcessor implements NettyRequestProcessor {
private final Logger logger = LoggerFactory.getLogger(TaskSavePointProcessor.class);
/**
* task execute manager
*/
@Autowired
private WorkerManagerThread workerManager;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskSavePointProcessor.java
|
/**
* task save point process
*
* @param channel channel channel
* @param command command command
*/
@Override
public void process(Channel channel, Command command) {
Preconditions.checkArgument(CommandType.TASK_SAVEPOINT_REQUEST == command.getType(),
String.format("invalid command type : %s", command.getType()));
TaskSavePointRequestCommand taskSavePointRequestCommand = JSONUtils.parseObject(command.getBody(), TaskSavePointRequestCommand.class);
if (taskSavePointRequestCommand == null) {
logger.error("task savepoint request command is null");
return;
}
logger.info("task savepoint command : {}", taskSavePointRequestCommand);
int taskInstanceId = taskSavePointRequestCommand.getTaskInstanceId();
TaskExecutionContext taskExecutionContext = TaskExecutionContextCacheManager.getByTaskInstanceId(taskInstanceId);
if (taskExecutionContext == null) {
logger.error("taskRequest cache is null, taskInstanceId: {}", taskSavePointRequestCommand.getTaskInstanceId());
return;
}
doSavePoint(taskInstanceId);
sendTaskSavePointResponseCommand(channel, taskExecutionContext);
}
private void sendTaskSavePointResponseCommand(Channel channel, TaskExecutionContext taskExecutionContext) {
TaskSavePointResponseCommand taskSavePointResponseCommand = new TaskSavePointResponseCommand();
taskSavePointResponseCommand.setTaskInstanceId(taskExecutionContext.getTaskInstanceId());
channel.writeAndFlush(taskSavePointResponseCommand.convert2Command()).addListener(new ChannelFutureListener() {
@Override
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskSavePointProcessor.java
|
public void operationComplete(ChannelFuture future) throws Exception {
if (!future.isSuccess()) {
logger.error("Submit kill response to master error, kill command: {}", taskSavePointResponseCommand);
}
}
});
}
protected void doSavePoint(int taskInstanceId) {
WorkerTaskExecuteRunnable workerTaskExecuteRunnable = workerManager.getTaskExecuteThread(taskInstanceId);
if (workerTaskExecuteRunnable == null) {
logger.warn("taskExecuteThread not found, taskInstanceId:{}", taskInstanceId);
return;
}
AbstractTask task = workerTaskExecuteRunnable.getTask();
if (task == null) {
logger.warn("task not found, taskInstanceId:{}", taskInstanceId);
return;
}
if (!(task instanceof StreamTask)) {
logger.warn("task is not stream task");
return;
}
try {
((StreamTask)task).savePoint();
} catch (Exception e) {
logger.error("task save point error", e);
}
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
package org.apache.dolphinscheduler.server.worker.runner;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.lifecycle.ServerLifeCycleManager;
import org.apache.dolphinscheduler.common.thread.ThreadUtils;
import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContextCacheManager;
import org.apache.dolphinscheduler.server.worker.config.WorkerConfig;
import org.apache.dolphinscheduler.server.worker.metrics.WorkerServerMetrics;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.stereotype.Component;
import javax.annotation.Nullable;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.DelayQueue;
/**
* Manage tasks
*/
@Component
public class WorkerManagerThread implements Runnable {
private final Logger logger = LoggerFactory.getLogger(WorkerManagerThread.class);
private final DelayQueue<WorkerDelayTaskExecuteRunnable> waitSubmitQueue;
private final WorkerExecService workerExecService;
private final int workerExecThreads;
/**
* running task
*/
private final ConcurrentHashMap<Integer, WorkerTaskExecuteRunnable> taskExecuteThreadMap = new ConcurrentHashMap<>();
public WorkerManagerThread(WorkerConfig workerConfig) {
workerExecThreads = workerConfig.getExecThreads();
this.waitSubmitQueue = new DelayQueue<>();
workerExecService = new WorkerExecService(
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
ThreadUtils.newDaemonFixedThreadExecutor("Worker-Execute-Thread", workerConfig.getExecThreads()),
taskExecuteThreadMap);
}
public @Nullable WorkerTaskExecuteRunnable getTaskExecuteThread(Integer taskInstanceId) {
return taskExecuteThreadMap.get(taskInstanceId);
}
/**
* get wait submit queue size
*
* @return queue size
*/
public int getWaitSubmitQueueSize() {
return waitSubmitQueue.size();
}
/**
* get thread pool queue size
*
* @return queue size
*/
public int getThreadPoolQueueSize() {
return workerExecService.getThreadPoolQueueSize();
}
/**
* Kill tasks that have not been executed, like delay task
* then send Response to Master, update the execution status of task instance
*/
public void killTaskBeforeExecuteByInstanceId(Integer taskInstanceId) {
waitSubmitQueue.stream()
.filter(taskExecuteThread -> taskExecuteThread.getTaskExecutionContext()
.getTaskInstanceId() == taskInstanceId)
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
.forEach(waitSubmitQueue::remove);
}
public boolean offer(WorkerDelayTaskExecuteRunnable workerDelayTaskExecuteRunnable) {
if (waitSubmitQueue.size() > workerExecThreads) {
WorkerServerMetrics.incWorkerSubmitQueueIsFullCount();
ThreadUtils.sleep(Constants.SLEEP_TIME_MILLIS);
if (waitSubmitQueue.size() > workerExecThreads) {
return false;
}
}
return waitSubmitQueue.offer(workerDelayTaskExecuteRunnable);
}
public void start() {
logger.info("Worker manager thread starting");
Thread thread = new Thread(this, this.getClass().getName());
thread.setDaemon(true);
thread.start();
logger.info("Worker manager thread started");
}
@Override
public void run() {
Thread.currentThread().setName("Worker-Execute-Manager-Thread");
while (!ServerLifeCycleManager.isStopped()) {
try {
if (!ServerLifeCycleManager.isRunning()) {
Thread.sleep(Constants.SLEEP_TIME_MILLIS);
}
if (this.getThreadPoolQueueSize() <= workerExecThreads) {
final WorkerDelayTaskExecuteRunnable workerDelayTaskExecuteRunnable = waitSubmitQueue.take();
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 12,145 |
[Bug] [server] NPE when depend node is forbidden
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
the process instance keep in runing state. and from the master node I can see the error log :
```
[INFO] 2022-09-26 15:07:56.915 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1276] - add task to stand by list, task name:写入数据, task id:0, task code:6963664984578
[ERROR] 2022-09-26 15:07:56.923 org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread:[1420] - submit standby task error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:981)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.setIndirectDepList(WorkflowExecuteThread.java:984)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.isTaskDepsComplete(WorkflowExecuteThread.java:948)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.getDependResultForTask(WorkflowExecuteThread.java:1243)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitStandByTask(WorkflowExecuteThread.java:1394)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.submitPostNode(WorkflowExecuteThread.java:930)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskFinished(WorkflowExecuteThread.java:409)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.taskStateChangeHandler(WorkflowExecuteThread.java:362)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.stateEventHandler(WorkflowExecuteThread.java:312)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.handleEvents(WorkflowExecuteThread.java:260)
at org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteThread.run(WorkflowExecuteThread.java:241)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:125)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:57)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:78)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
after remove the connection between the forbidden node and should run node , things goes well.
### What you expected to happen
no error should throw out
### How to reproduce
I also can't reproduce it.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/12145
|
https://github.com/apache/dolphinscheduler/pull/12183
|
e27c79974d93d0d4181a0f5dbe45159084e224d3
|
962fa6dbd51c232b3b45243b408c5f19c1913879
| 2022-09-26T07:46:19Z |
java
| 2022-09-29T08:01:29Z |
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/WorkerManagerThread.java
|
workerExecService.submit(workerDelayTaskExecuteRunnable);
} else {
WorkerServerMetrics.incWorkerOverloadCount();
logger.info("Exec queue is full, waiting submit queue {}, waiting exec queue size {}",
this.getWaitSubmitQueueSize(), this.getThreadPoolQueueSize());
ThreadUtils.sleep(Constants.SLEEP_TIME_MILLIS);
}
} catch (Exception e) {
logger.error("An unexpected interrupt is happened, "
+ "the exception will be ignored and this thread will continue to run", e);
}
}
}
public void clearTask() {
waitSubmitQueue.clear();
workerExecService.getTaskExecuteThreadMap().values().forEach(workerTaskExecuteRunnable -> {
int taskInstanceId = workerTaskExecuteRunnable.getTaskExecutionContext().getTaskInstanceId();
try {
workerTaskExecuteRunnable.cancelTask();
logger.info("Cancel the taskInstance in worker {}", taskInstanceId);
} catch (Exception ex) {
logger.error("Cancel the taskInstance error {}", taskInstanceId, ex);
} finally {
TaskExecutionContextCacheManager.removeByTaskInstanceId(taskInstanceId);
}
});
workerExecService.getTaskExecuteThreadMap().clear();
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.api.controller;
import static org.apache.dolphinscheduler.api.enums.Status.BATCH_COPY_PROCESS_DEFINITION_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.BATCH_DELETE_PROCESS_DEFINE_BY_CODES_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.BATCH_MOVE_PROCESS_DEFINITION_ERROR;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
import static org.apache.dolphinscheduler.api.enums.Status.CREATE_PROCESS_DEFINITION_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.DELETE_PROCESS_DEFINE_BY_CODE_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.DELETE_PROCESS_DEFINITION_VERSION_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.ENCAPSULATION_TREEVIEW_STRUCTURE_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.GET_TASKS_LIST_BY_PROCESS_DEFINITION_ID_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.IMPORT_PROCESS_DEFINE_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.QUERY_DETAIL_OF_PROCESS_DEFINITION_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.QUERY_PROCESS_DEFINITION_LIST;
import static org.apache.dolphinscheduler.api.enums.Status.QUERY_PROCESS_DEFINITION_LIST_PAGING_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.QUERY_PROCESS_DEFINITION_VERSIONS_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.RELEASE_PROCESS_DEFINITION_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.SWITCH_PROCESS_DEFINITION_VERSION_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.UPDATE_PROCESS_DEFINITION_ERROR;
import static org.apache.dolphinscheduler.api.enums.Status.VERIFY_PROCESS_DEFINITION_NAME_UNIQUE_ERROR;
import org.apache.dolphinscheduler.api.aspect.AccessLogAnnotation;
import org.apache.dolphinscheduler.api.enums.Status;
import org.apache.dolphinscheduler.api.exceptions.ApiException;
import org.apache.dolphinscheduler.api.exceptions.ServiceException;
import org.apache.dolphinscheduler.api.service.ProcessDefinitionService;
import org.apache.dolphinscheduler.api.utils.PageInfo;
import org.apache.dolphinscheduler.api.utils.Result;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.enums.ProcessExecutionTypeEnum;
import org.apache.dolphinscheduler.common.enums.ReleaseState;
import org.apache.dolphinscheduler.common.utils.ParameterUtils;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinition;
import org.apache.dolphinscheduler.dao.entity.User;
import springfox.documentation.annotations.ApiIgnore;
import org.apache.commons.lang3.StringUtils;
import java.text.MessageFormat;
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;
import javax.servlet.http.HttpServletResponse;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.HttpStatus;
import org.springframework.web.bind.annotation.DeleteMapping;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.PutMapping;
import org.springframework.web.bind.annotation.RequestAttribute;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.ResponseBody;
import org.springframework.web.bind.annotation.ResponseStatus;
import org.springframework.web.bind.annotation.RestController;
import org.springframework.web.multipart.MultipartFile;
import io.swagger.annotations.Api;
import io.swagger.annotations.ApiImplicitParam;
import io.swagger.annotations.ApiImplicitParams;
import io.swagger.annotations.ApiOperation;
import io.swagger.annotations.ApiParam;
/**
* process definition controller
*/
@Api(tags = "PROCESS_DEFINITION_TAG")
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@RestController
@RequestMapping("projects/{projectCode}/process-definition")
public class ProcessDefinitionController extends BaseController {
private static final Logger logger = LoggerFactory.getLogger(ProcessDefinitionController.class);
@Autowired
private ProcessDefinitionService processDefinitionService;
/**
* create process definition
*
* @param loginUser login user
* @param projectCode project code
* @param name process definition name
* @param description description
* @param globalParams globalParams
* @param locations locations for nodes
* @param timeout timeout
* @param tenantCode tenantCode
* @param taskRelationJson relation json for nodes
* @param taskDefinitionJson taskDefinitionJson
* @param otherParamsJson otherParamsJson handle other params
* @return create result code
*/
@ApiOperation(value = "createProcessDefinition", notes = "CREATE_PROCESS_DEFINITION_NOTES")
@ApiImplicitParams({
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@ApiImplicitParam(name = "name", value = "PROCESS_DEFINITION_NAME", required = true, dataTypeClass = String.class),
@ApiImplicitParam(name = "locations", value = "PROCESS_DEFINITION_LOCATIONS", required = true, dataTypeClass = String.class),
@ApiImplicitParam(name = "description", value = "PROCESS_DEFINITION_DESC", required = false, dataTypeClass = String.class),
@ApiImplicitParam(name = "otherParamsJson", value = "OTHER_PARAMS_JSON", required = false, dataTypeClass = String.class)
})
@PostMapping()
@ResponseStatus(HttpStatus.CREATED)
@ApiException(CREATE_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result createProcessDefinition(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "name", required = true) String name,
@RequestParam(value = "description", required = false) String description,
@RequestParam(value = "globalParams", required = false, defaultValue = "[]") String globalParams,
@RequestParam(value = "locations", required = false) String locations,
@RequestParam(value = "timeout", required = false, defaultValue = "0") int timeout,
@RequestParam(value = "tenantCode", required = true) String tenantCode,
@RequestParam(value = "taskRelationJson", required = true) String taskRelationJson,
@RequestParam(value = "taskDefinitionJson", required = true) String taskDefinitionJson,
@RequestParam(value = "otherParamsJson", required = false) String otherParamsJson,
@RequestParam(value = "executionType", defaultValue = "PARALLEL") ProcessExecutionTypeEnum executionType) {
Map<String, Object> result = processDefinitionService.createProcessDefinition(loginUser, projectCode, name,
description, globalParams,
locations, timeout, tenantCode, taskRelationJson, taskDefinitionJson, otherParamsJson, executionType);
return returnDataList(result);
}
/**
* copy process definition
*
* @param loginUser login user
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
* @param projectCode project code
* @param codes process definition codes
* @param targetProjectCode target project code
* @return copy result code
*/
@ApiOperation(value = "batchCopyByCodes", notes = "COPY_PROCESS_DEFINITION_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "codes", value = "PROCESS_DEFINITION_CODES", required = true, dataTypeClass = String.class, example = "3,4"),
@ApiImplicitParam(name = "targetProjectCode", value = "TARGET_PROJECT_CODE", required = true, dataTypeClass = long.class, example = "123")
})
@PostMapping(value = "/batch-copy")
@ResponseStatus(HttpStatus.OK)
@ApiException(BATCH_COPY_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result copyProcessDefinition(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "codes", required = true) String codes,
@RequestParam(value = "targetProjectCode", required = true) long targetProjectCode) {
return returnDataList(
processDefinitionService.batchCopyProcessDefinition(loginUser, projectCode, codes, targetProjectCode));
}
/**
* move process definition
*
* @param loginUser login user
* @param projectCode project code
* @param codes process definition codes
* @param targetProjectCode target project code
* @return move result code
*/
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@ApiOperation(value = "batchMoveByCodes", notes = "MOVE_PROCESS_DEFINITION_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "codes", value = "PROCESS_DEFINITION_CODES", required = true, dataTypeClass = String.class, example = "3,4"),
@ApiImplicitParam(name = "targetProjectCode", value = "TARGET_PROJECT_CODE", required = true, dataTypeClass = long.class, example = "123")
})
@PostMapping(value = "/batch-move")
@ResponseStatus(HttpStatus.OK)
@ApiException(BATCH_MOVE_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result moveProcessDefinition(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "codes", required = true) String codes,
@RequestParam(value = "targetProjectCode", required = true) long targetProjectCode) {
return returnDataList(
processDefinitionService.batchMoveProcessDefinition(loginUser, projectCode, codes, targetProjectCode));
}
/**
* verify process definition name unique
*
* @param loginUser login user
* @param projectCode project code
* @param name name
* @return true if process definition name not exists, otherwise false
*/
@ApiOperation(value = "verify-name", notes = "VERIFY_PROCESS_DEFINITION_NAME_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "name", value = "PROCESS_DEFINITION_NAME", required = true, dataTypeClass = String.class),
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = false, dataTypeClass = Long.class),
})
@GetMapping(value = "/verify-name")
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@ResponseStatus(HttpStatus.OK)
@ApiException(VERIFY_PROCESS_DEFINITION_NAME_UNIQUE_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result verifyProcessDefinitionName(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "name", required = true) String name,
@RequestParam(value = "code", required = false, defaultValue = "0") long processDefinitionCode) {
Map<String, Object> result = processDefinitionService.verifyProcessDefinitionName(loginUser, projectCode, name,
processDefinitionCode);
return returnDataList(result);
}
/**
* update process definition, with whole process definition object including task definition, task relation and location.
*
* @param loginUser login user
* @param projectCode project code
* @param name process definition name
* @param code process definition code
* @param description description
* @param globalParams globalParams
* @param locations locations for nodes
* @param timeout timeout
* @param tenantCode tenantCode
* @param taskRelationJson relation json for nodes
* @param taskDefinitionJson taskDefinitionJson
* @param otherParamsJson otherParamsJson handle other params
* @return update result code
*/
@ApiOperation(value = "update", notes = "UPDATE_PROCESS_DEFINITION_NOTES")
@ApiImplicitParams({
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@ApiImplicitParam(name = "name", value = "PROCESS_DEFINITION_NAME", required = true, dataTypeClass = String.class),
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "123456789"),
@ApiImplicitParam(name = "locations", value = "PROCESS_DEFINITION_LOCATIONS", required = true, dataTypeClass = String.class),
@ApiImplicitParam(name = "description", value = "PROCESS_DEFINITION_DESC", required = false, dataTypeClass = String.class),
@ApiImplicitParam(name = "releaseState", value = "RELEASE_PROCESS_DEFINITION_NOTES", required = false, dataTypeClass = ReleaseState.class),
@ApiImplicitParam(name = "otherParamsJson", value = "OTHER_PARAMS_JSON", required = false, dataTypeClass = String.class)
})
@PutMapping(value = "/{code}")
@ResponseStatus(HttpStatus.OK)
@ApiException(UPDATE_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result updateProcessDefinition(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "name", required = true) String name,
@PathVariable(value = "code", required = true) long code,
@RequestParam(value = "description", required = false) String description,
@RequestParam(value = "globalParams", required = false, defaultValue = "[]") String globalParams,
@RequestParam(value = "locations", required = false) String locations,
@RequestParam(value = "timeout", required = false, defaultValue = "0") int timeout,
@RequestParam(value = "tenantCode", required = true) String tenantCode,
@RequestParam(value = "taskRelationJson", required = true) String taskRelationJson,
@RequestParam(value = "taskDefinitionJson", required = true) String taskDefinitionJson,
@RequestParam(value = "otherParamsJson", required = false) String otherParamsJson,
@RequestParam(value = "executionType", defaultValue = "PARALLEL") ProcessExecutionTypeEnum executionType,
@RequestParam(value = "releaseState", required = false, defaultValue = "OFFLINE") ReleaseState releaseState) {
Map<String, Object> result = processDefinitionService.updateProcessDefinition(loginUser, projectCode, name,
code, description, globalParams,
locations, timeout, tenantCode, taskRelationJson, taskDefinitionJson, otherParamsJson, executionType);
if (result.get(Constants.STATUS) != Status.SUCCESS) {
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
return returnDataList(result);
}
if (releaseState == ReleaseState.ONLINE) {
result = processDefinitionService.releaseProcessDefinition(loginUser, projectCode, code, releaseState);
}
return returnDataList(result);
}
/**
* query process definition version paging list info
*
* @param loginUser login user info
* @param projectCode project code
* @param pageNo the process definition version list current page number
* @param pageSize the process definition version list page size
* @param code the process definition code
* @return the process definition version list
*/
@ApiOperation(value = "queryVersions", notes = "QUERY_PROCESS_DEFINITION_VERSIONS_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "pageNo", value = "PAGE_NO", required = true, dataTypeClass = int.class, example = "1"),
@ApiImplicitParam(name = "pageSize", value = "PAGE_SIZE", required = true, dataTypeClass = int.class, example = "10"),
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "1")
})
@GetMapping(value = "/{code}/versions")
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_PROCESS_DEFINITION_VERSIONS_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result queryProcessDefinitionVersions(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@RequestParam(value = "pageNo") int pageNo,
@RequestParam(value = "pageSize") int pageSize,
@PathVariable(value = "code") long code) {
Result result = checkPageParams(pageNo, pageSize);
if (!result.checkResult()) {
return result;
}
result = processDefinitionService.queryProcessDefinitionVersions(loginUser, projectCode, pageNo, pageSize,
code);
return result;
}
/**
* switch certain process definition version
*
* @param loginUser login user info
* @param projectCode project code
* @param code the process definition code
* @param version the version user want to switch
* @return switch version result code
*/
@ApiOperation(value = "switchVersion", notes = "SWITCH_PROCESS_DEFINITION_VERSION_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "1"),
@ApiImplicitParam(name = "version", value = "VERSION", required = true, dataTypeClass = int.class, example = "100")
})
@GetMapping(value = "/{code}/versions/{version}")
@ResponseStatus(HttpStatus.OK)
@ApiException(SWITCH_PROCESS_DEFINITION_VERSION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result switchProcessDefinitionVersion(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@PathVariable(value = "code") long code,
@PathVariable(value = "version") int version) {
Map<String, Object> result =
processDefinitionService.switchProcessDefinitionVersion(loginUser, projectCode, code, version);
return returnDataList(result);
}
/**
* delete the certain process definition version by version and process definition code
*
* @param loginUser login user info
* @param projectCode project code
* @param code the process definition code
* @param version the process definition version user want to delete
* @return delete version result code
*/
@ApiOperation(value = "deleteVersion", notes = "DELETE_PROCESS_DEFINITION_VERSION_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "1"),
@ApiImplicitParam(name = "version", value = "VERSION", required = true, dataTypeClass = int.class, example = "100")
})
@DeleteMapping(value = "/{code}/versions/{version}")
@ResponseStatus(HttpStatus.OK)
@ApiException(DELETE_PROCESS_DEFINITION_VERSION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result deleteProcessDefinitionVersion(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@PathVariable(value = "code") long code,
@PathVariable(value = "version") int version) {
Map<String, Object> result =
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
processDefinitionService.deleteProcessDefinitionVersion(loginUser, projectCode, code, version);
return returnDataList(result);
}
/**
* release process definition
*
* @param loginUser login user
* @param projectCode project code
* @param code process definition code
* @param releaseState release state
* @return release result code
*/
@ApiOperation(value = "release", notes = "RELEASE_PROCESS_DEFINITION_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "name", value = "PROCESS_DEFINITION_NAME", required = true, dataTypeClass = String.class),
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "123456789"),
@ApiImplicitParam(name = "releaseState", value = "PROCESS_DEFINITION_RELEASE", required = true, dataTypeClass = ReleaseState.class),
})
@PostMapping(value = "/{code}/release")
@ResponseStatus(HttpStatus.OK)
@ApiException(RELEASE_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result releaseProcessDefinition(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@PathVariable(value = "code", required = true) long code,
@RequestParam(value = "releaseState", required = true) ReleaseState releaseState) {
Map<String, Object> result =
processDefinitionService.releaseProcessDefinition(loginUser, projectCode, code, releaseState);
return returnDataList(result);
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
/**
* query detail of process definition by code
*
* @param loginUser login user
* @param projectCode project code
* @param code process definition code
* @return process definition detail
*/
@ApiOperation(value = "queryProcessDefinitionByCode", notes = "QUERY_PROCESS_DEFINITION_BY_CODE_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "123456789")
})
@GetMapping(value = "/{code}")
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_DETAIL_OF_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result queryProcessDefinitionByCode(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@PathVariable(value = "code", required = true) long code) {
Map<String, Object> result =
processDefinitionService.queryProcessDefinitionByCode(loginUser, projectCode, code);
return returnDataList(result);
}
/**
* query detail of process definition by name
*
* @param loginUser login user
* @param projectCode project code
* @param name process definition name
* @return process definition detail
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
*/
@ApiOperation(value = "queryProcessDefinitionByName", notes = "QUERY_PROCESS_DEFINITION_BY_NAME_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "name", value = "PROCESS_DEFINITION_NAME", required = true, dataTypeClass = String.class)
})
@GetMapping(value = "/query-by-name")
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_DETAIL_OF_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result<ProcessDefinition> queryProcessDefinitionByName(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("name") String name) {
Map<String, Object> result =
processDefinitionService.queryProcessDefinitionByName(loginUser, projectCode, name);
return returnDataList(result);
}
/**
* query Process definition list
*
* @param loginUser login user
* @param projectCode project code
* @return process definition list
*/
@ApiOperation(value = "queryList", notes = "QUERY_PROCESS_DEFINITION_LIST_NOTES")
@GetMapping(value = "/list")
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_PROCESS_DEFINITION_LIST)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result queryProcessDefinitionList(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode) {
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
Map<String, Object> result = processDefinitionService.queryProcessDefinitionList(loginUser, projectCode);
return returnDataList(result);
}
/**
* query Process definition simple list
*
* @param loginUser login user
* @param projectCode project code
* @return process definition list
*/
@ApiOperation(value = "querySimpleList", notes = "QUERY_PROCESS_DEFINITION_SIMPLE_LIST_NOTES")
@GetMapping(value = "/simple-list")
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_PROCESS_DEFINITION_LIST)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result queryProcessDefinitionSimpleList(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode) {
Map<String, Object> result = processDefinitionService.queryProcessDefinitionSimpleList(loginUser, projectCode);
return returnDataList(result);
}
/**
* query process definition list paging
*
* @param loginUser login user
* @param projectCode project code
* @param searchVal search value
* @param otherParamsJson otherParamsJson handle other params
* @param pageNo page number
* @param pageSize page size
* @param userId user id
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
* @return process definition page
*/
@ApiOperation(value = "queryListPaging", notes = "QUERY_PROCESS_DEFINITION_LIST_PAGING_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "searchVal", value = "SEARCH_VAL", required = false, dataTypeClass = String.class),
@ApiImplicitParam(name = "userId", value = "USER_ID", required = false, dataTypeClass = int.class, example = "100"),
@ApiImplicitParam(name = "pageNo", value = "PAGE_NO", required = true, dataTypeClass = int.class, example = "1"),
@ApiImplicitParam(name = "pageSize", value = "PAGE_SIZE", required = true, dataTypeClass = int.class, example = "10"),
@ApiImplicitParam(name = "otherParamsJson", value = "OTHER_PARAMS_JSON", required = false, dataTypeClass = String.class)
})
@GetMapping()
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_PROCESS_DEFINITION_LIST_PAGING_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result<PageInfo<ProcessDefinition>> queryProcessDefinitionListPaging(
@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "searchVal", required = false) String searchVal,
@RequestParam(value = "otherParamsJson", required = false) String otherParamsJson,
@RequestParam(value = "userId", required = false, defaultValue = "0") Integer userId,
@RequestParam("pageNo") Integer pageNo,
@RequestParam("pageSize") Integer pageSize) {
Result<PageInfo<ProcessDefinition>> result = checkPageParams(pageNo, pageSize);
if (!result.checkResult()) {
return result;
}
searchVal = ParameterUtils.handleEscapes(searchVal);
PageInfo<ProcessDefinition> pageInfo = processDefinitionService.queryProcessDefinitionListPaging(
loginUser, projectCode, searchVal, otherParamsJson, userId, pageNo, pageSize);
return Result.success(pageInfo);
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
}
/**
* encapsulation tree view structure
*
* @param loginUser login user
* @param projectCode project code
* @param code process definition code
* @param limit limit
* @return tree view json data
*/
@ApiOperation(value = "viewTree", notes = "VIEW_TREE_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "100"),
@ApiImplicitParam(name = "limit", value = "LIMIT", required = true, dataTypeClass = int.class, example = "100")
})
@GetMapping(value = "/{code}/view-tree")
@ResponseStatus(HttpStatus.OK)
@ApiException(ENCAPSULATION_TREEVIEW_STRUCTURE_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result viewTree(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@PathVariable("code") long code,
@RequestParam("limit") Integer limit) {
Map<String, Object> result = processDefinitionService.viewTree(loginUser, projectCode, code, limit);
return returnDataList(result);
}
/**
* get tasks list by process definition code
*
* @param loginUser login user
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
* @param projectCode project code
* @param code process definition code
* @return task list
*/
@ApiOperation(value = "getTasksByDefinitionCode", notes = "GET_TASK_LIST_BY_DEFINITION_CODE_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "100")
})
@GetMapping(value = "/{code}/tasks")
@ResponseStatus(HttpStatus.OK)
@ApiException(GET_TASKS_LIST_BY_PROCESS_DEFINITION_ID_ERROR)
public Result getNodeListByDefinitionCode(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@PathVariable("code") long code) {
Map<String, Object> result =
processDefinitionService.getTaskNodeListByDefinitionCode(loginUser, projectCode, code);
return returnDataList(result);
}
/**
* get tasks list map by process definition multiple code
*
* @param loginUser login user
* @param projectCode project code
* @param codes process definition codes
* @return node list data
*/
@ApiOperation(value = "getTaskListByDefinitionCodes", notes = "GET_TASK_LIST_BY_DEFINITION_CODE_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "codes", value = "PROCESS_DEFINITION_CODES", required = true, dataTypeClass = String.class, example = "100,200,300")
})
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@GetMapping(value = "/batch-query-tasks")
@ResponseStatus(HttpStatus.OK)
@ApiException(GET_TASKS_LIST_BY_PROCESS_DEFINITION_ID_ERROR)
public Result getNodeListMapByDefinitionCodes(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes) {
Map<String, Object> result =
processDefinitionService.getNodeListMapByDefinitionCodes(loginUser, projectCode, codes);
return returnDataList(result);
}
/**
* get process definition list map by project code
*
* @param loginUser login user
* @param projectCode project code
* @return process definition list data
*/
@ApiOperation(value = "getProcessListByProjectCode", notes = "GET_PROCESS_LIST_BY_PROCESS_CODE_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "projectCode", value = "PROJECT_CODE", required = true, dataTypeClass = long.class, example = "100")
})
@GetMapping(value = "/query-process-definition-list")
@ResponseStatus(HttpStatus.OK)
@ApiException(GET_TASKS_LIST_BY_PROCESS_DEFINITION_ID_ERROR)
public Result getProcessListByProjectCodes(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode) {
Map<String, Object> result = processDefinitionService.queryProcessDefinitionListByProjectCode(projectCode);
return returnDataList(result);
}
/**
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
* get task definition list by process definition code
*
* @param loginUser login user
* @param projectCode project code
* @return process definition list data
*/
@ApiOperation(value = "getTaskListByProcessDefinitionCode", notes = "GET_TASK_LIST_BY_PROCESS_CODE_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "projectCode", value = "PROJECT_CODE", required = true, dataTypeClass = long.class, example = "100"),
@ApiImplicitParam(name = "processDefinitionCode", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "100"),
})
@GetMapping(value = "/query-task-definition-list")
@ResponseStatus(HttpStatus.OK)
@ApiException(GET_TASKS_LIST_BY_PROCESS_DEFINITION_ID_ERROR)
public Result getTaskListByProcessDefinitionCode(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "processDefinitionCode") Long processDefinitionCode) {
Map<String, Object> result = processDefinitionService
.queryTaskDefinitionListByProcessDefinitionCode(projectCode, processDefinitionCode);
return returnDataList(result);
}
/**
* delete process definition by code
*
* @param loginUser login user
* @param projectCode project code
* @param code process definition code
* @return delete result code
*/
@ApiOperation(value = "deleteByCode", notes = "DELETE_PROCESS_DEFINITION_BY_ID_NOTES")
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@ApiImplicitParams({
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", dataTypeClass = int.class, example = "100")
})
@DeleteMapping(value = "/{code}")
@ResponseStatus(HttpStatus.OK)
@ApiException(DELETE_PROCESS_DEFINE_BY_CODE_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result deleteProcessDefinitionByCode(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@PathVariable("code") long code) {
processDefinitionService.deleteProcessDefinitionByCode(loginUser, code);
return new Result(Status.SUCCESS);
}
/**
* batch delete process definition by codes
*
* @param loginUser login user
* @param projectCode project code
* @param codes process definition code list
* @return delete result code
*/
@ApiOperation(value = "batchDeleteByCodes", notes = "BATCH_DELETE_PROCESS_DEFINITION_BY_IDS_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "codes", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = String.class)
})
@PostMapping(value = "/batch-delete")
@ResponseStatus(HttpStatus.OK)
@ApiException(BATCH_DELETE_PROCESS_DEFINE_BY_CODES_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result batchDeleteProcessDefinitionByCodes(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes) {
Map<String, Object> result = new HashMap<>();
Set<String> deleteFailedCodeSet = new HashSet<>();
if (!StringUtils.isEmpty(codes)) {
String[] processDefinitionCodeArray = codes.split(",");
for (String strProcessDefinitionCode : processDefinitionCodeArray) {
long code = Long.parseLong(strProcessDefinitionCode);
try {
processDefinitionService.deleteProcessDefinitionByCode(loginUser, code);
} catch (ServiceException e) {
deleteFailedCodeSet.add(MessageFormat.format(Status.DELETE_PROCESS_DEFINE_BY_CODES_ERROR.getMsg(),
strProcessDefinitionCode));
}
}
}
if (!deleteFailedCodeSet.isEmpty()) {
putMsg(result, BATCH_DELETE_PROCESS_DEFINE_BY_CODES_ERROR, String.join("\n", deleteFailedCodeSet));
} else {
putMsg(result, Status.SUCCESS);
}
return returnDataList(result);
}
/**
* batch export process definition by codes
*
* @param loginUser login user
* @param projectCode project code
* @param codes process definition codes
* @param response response
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
*/
@ApiOperation(value = "batchExportByCodes", notes = "BATCH_EXPORT_PROCESS_DEFINITION_BY_CODES_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "codes", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = String.class)
})
@PostMapping(value = "/batch-export")
@ResponseBody
@AccessLogAnnotation(ignoreRequestArgs = {"loginUser", "response"})
public void batchExportProcessDefinitionByCodes(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes,
HttpServletResponse response) {
try {
processDefinitionService.batchExportProcessDefinitionByCodes(loginUser, projectCode, codes, response);
} catch (Exception e) {
logger.error(Status.BATCH_EXPORT_PROCESS_DEFINE_BY_IDS_ERROR.getMsg(), e);
}
}
/**
* query all process definition by project code
*
* @param loginUser login user
* @param projectCode project code
* @return process definition list
*/
@ApiOperation(value = "queryAllByProjectCode", notes = "QUERY_PROCESS_DEFINITION_All_BY_PROJECT_CODE_NOTES")
@GetMapping(value = "/all")
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_PROCESS_DEFINITION_LIST)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
public Result queryAllProcessDefinitionByProjectCode(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode) {
Map<String, Object> result =
processDefinitionService.queryAllProcessDefinitionByProjectCode(loginUser, projectCode);
return returnDataList(result);
}
/**
* import process definition
*
* @param loginUser login user
* @param projectCode project code
* @param file resource file
* @return import result code
*/
@ApiOperation(value = "importProcessDefinition", notes = "IMPORT_PROCESS_DEFINITION_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "file", value = "RESOURCE_FILE", required = true, dataTypeClass = MultipartFile.class)
})
@PostMapping(value = "/import")
@ApiException(IMPORT_PROCESS_DEFINE_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = {"loginUser", "file"})
public Result importProcessDefinition(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("file") MultipartFile file) {
Map<String, Object> result;
if ("application/zip".equals(file.getContentType())) {
result = processDefinitionService.importSqlProcessDefinition(loginUser, projectCode, file);
} else {
result = processDefinitionService.importProcessDefinition(loginUser, projectCode, file);
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
return returnDataList(result);
}
/**
* create empty process definition
*
* @param loginUser login user
* @param projectCode project code
* @param name process definition name
* @param description description
* @param globalParams globalParams
* @param timeout timeout
* @param tenantCode tenantCode
* @param scheduleJson scheduleJson
* @return process definition code
*/
@ApiOperation(value = "createEmptyProcessDefinition", notes = "CREATE_EMPTY_PROCESS_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "name", value = "PROCESS_DEFINITION_NAME", required = true, dataTypeClass = String.class),
@ApiImplicitParam(name = "projectCode", value = "PROJECT_CODE", required = true, dataTypeClass = long.class, example = "123456789"),
@ApiImplicitParam(name = "description", value = "PROCESS_DEFINITION_DESC", required = false, dataTypeClass = String.class)
})
@PostMapping(value = "/empty")
@ResponseStatus(HttpStatus.OK)
@ApiException(CREATE_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result createEmptyProcessDefinition(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "name", required = true) String name,
@RequestParam(value = "description", required = false) String description,
@RequestParam(value = "globalParams", required = false, defaultValue = "[]") String globalParams,
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@RequestParam(value = "timeout", required = false, defaultValue = "0") int timeout,
@RequestParam(value = "tenantCode", required = true) String tenantCode,
@RequestParam(value = "scheduleJson", required = false) String scheduleJson,
@RequestParam(value = "executionType", defaultValue = "PARALLEL") ProcessExecutionTypeEnum executionType) {
return returnDataList(processDefinitionService.createEmptyProcessDefinition(loginUser, projectCode, name,
description, globalParams,
timeout, tenantCode, scheduleJson, executionType));
}
/**
* update process definition basic info, not including task definition, task relation and location.
*
* @param loginUser login user
* @param projectCode project code
* @param name process definition name
* @param code process definition code
* @param description description
* @param globalParams globalParams
* @param timeout timeout
* @param tenantCode tenantCode
* @param scheduleJson scheduleJson
* @param executionType executionType
* @param releaseState releaseState
* @param otherParamsJson otherParamsJson handle other params
* @return update result code
*/
@ApiOperation(value = "updateBasicInfo", notes = "UPDATE_PROCESS_DEFINITION_BASIC_INFO_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "name", value = "PROCESS_DEFINITION_NAME", required = true, dataTypeClass = String.class),
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "123456789"),
@ApiImplicitParam(name = "description", value = "PROCESS_DEFINITION_DESC", required = false, dataTypeClass = String.class),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
@ApiImplicitParam(name = "releaseState", value = "RELEASE_PROCESS_DEFINITION_NOTES", required = false, dataTypeClass = ReleaseState.class),
@ApiImplicitParam(name = "otherParamsJson", value = "OTHER_PARAMS_JSON", required = false, dataTypeClass = String.class)
})
@PutMapping(value = "/{code}/basic-info")
@ResponseStatus(HttpStatus.OK)
@ApiException(UPDATE_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result updateProcessDefinitionBasicInfo(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam(value = "name", required = true) String name,
@PathVariable(value = "code", required = true) long code,
@RequestParam(value = "description", required = false) String description,
@RequestParam(value = "globalParams", required = false, defaultValue = "[]") String globalParams,
@RequestParam(value = "timeout", required = false, defaultValue = "0") int timeout,
@RequestParam(value = "tenantCode", required = true) String tenantCode,
@RequestParam(value = "scheduleJson", required = false) String scheduleJson,
@RequestParam(value = "otherParamsJson", required = false) String otherParamsJson,
@RequestParam(value = "executionType", defaultValue = "PARALLEL") ProcessExecutionTypeEnum executionType,
@RequestParam(value = "releaseState", required = false, defaultValue = "OFFLINE") ReleaseState releaseState) {
Map<String, Object> result = processDefinitionService.updateProcessDefinitionBasicInfo(loginUser, projectCode,
name, code, description, globalParams,
timeout, tenantCode, scheduleJson, otherParamsJson, executionType);
if (result.get(Constants.STATUS) != Status.SUCCESS) {
return returnDataList(result);
}
if (releaseState == ReleaseState.ONLINE) {
result = processDefinitionService.releaseWorkflowAndSchedule(loginUser, projectCode, code, releaseState);
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
|
return returnDataList(result);
}
/**
* release process definition and schedule
*
* @param loginUser login user
* @param projectCode project code
* @param code process definition code
* @param releaseState releaseState
* @return update result code
*/
@ApiOperation(value = "releaseWorkflowAndSchedule", notes = "RELEASE_WORKFLOW_SCHEDULE_NOTES")
@ApiImplicitParams({
@ApiImplicitParam(name = "projectCode", value = "PROCESS_DEFINITION_NAME", required = true, dataTypeClass = long.class),
@ApiImplicitParam(name = "code", value = "PROCESS_DEFINITION_CODE", required = true, dataTypeClass = long.class, example = "123456789"),
@ApiImplicitParam(name = "releaseState", value = "RELEASE_PROCESS_DEFINITION_NOTES", required = true, dataTypeClass = ReleaseState.class)
})
@PostMapping(value = "/{code}/release-workflow")
@ResponseStatus(HttpStatus.OK)
@ApiException(RELEASE_PROCESS_DEFINITION_ERROR)
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result releaseWorkflowAndSchedule(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@PathVariable(value = "code", required = true) long code,
@RequestParam(value = "releaseState", required = true, defaultValue = "OFFLINE") ReleaseState releaseState) {
return returnDataList(
processDefinitionService.releaseWorkflowAndSchedule(loginUser, projectCode, code, releaseState));
}
}
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.api.enums;
import java.util.Locale;
import java.util.Optional;
import org.springframework.context.i18n.LocaleContextHolder;
/**
* status enum // todo #4855 One category one interval
*/
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
public enum Status {
SUCCESS(0, "success", "成功"),
INTERNAL_SERVER_ERROR_ARGS(10000, "Internal Server Error: {0}", "服务端异常: {0}"),
REQUEST_PARAMS_NOT_VALID_ERROR(10001, "request parameter {0} is not valid", "请求参数[{0}]无效"),
TASK_TIMEOUT_PARAMS_ERROR(10002, "task timeout parameter is not valid", "任务超时参数无效"),
USER_NAME_EXIST(10003, "user name already exists", "用户名已存在"),
USER_NAME_NULL(10004, "user name is null", "用户名不能为空"),
HDFS_OPERATION_ERROR(10006, "hdfs operation error", "hdfs操作错误"),
TASK_INSTANCE_NOT_FOUND(10008, "task instance not found", "任务实例不存在"),
OS_TENANT_CODE_EXIST(10009, "os tenant code {0} already exists", "操作系统租户[{0}]已存在"),
USER_NOT_EXIST(10010, "user {0} not exists", "用户[{0}]不存在"),
ALERT_GROUP_NOT_EXIST(10011, "alarm group not found", "告警组不存在"),
ALERT_GROUP_EXIST(10012, "alarm group already exists", "告警组名称已存在"),
USER_NAME_PASSWD_ERROR(10013, "user name or password error", "用户名或密码错误"),
LOGIN_SESSION_FAILED(10014, "create session failed!", "创建session失败"),
DATASOURCE_EXIST(10015, "data source name already exists", "数据源名称已存在"),
DATASOURCE_CONNECT_FAILED(10016, "data source connection failed", "建立数据源连接失败"),
TENANT_NOT_EXIST(10017, "tenant not exists", "租户不存在"),
PROJECT_NOT_FOUND(10018, "project {0} not found ", "项目[{0}]不存在"),
PROJECT_ALREADY_EXISTS(10019, "project {0} already exists", "项目名称[{0}]已存在"),
TASK_INSTANCE_NOT_EXISTS(10020, "task instance {0} does not exist", "任务实例[{0}]不存在"),
TASK_INSTANCE_NOT_SUB_WORKFLOW_INSTANCE(10021, "task instance {0} is not sub process instance", "任务实例[{0}]不是子流程实例"),
SCHEDULE_CRON_NOT_EXISTS(10022, "scheduler crontab {0} does not exist", "调度配置定时表达式[{0}]不存在"),
SCHEDULE_CRON_ONLINE_FORBID_UPDATE(10023, "online status does not allow update operations", "调度配置上线状态不允许修改"),
SCHEDULE_CRON_CHECK_FAILED(10024, "scheduler crontab expression validation failure: {0}", "调度配置定时表达式验证失败: {0}"),
MASTER_NOT_EXISTS(10025, "master does not exist", "无可用master节点"),
SCHEDULE_STATUS_UNKNOWN(10026, "unknown status: {0}", "未知状态: {0}"),
CREATE_ALERT_GROUP_ERROR(10027, "create alert group error", "创建告警组错误"),
QUERY_ALL_ALERTGROUP_ERROR(10028, "query all alertgroup error", "查询告警组错误"),
LIST_PAGING_ALERT_GROUP_ERROR(10029, "list paging alert group error", "分页查询告警组错误"),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
UPDATE_ALERT_GROUP_ERROR(10030, "update alert group error", "更新告警组错误"),
DELETE_ALERT_GROUP_ERROR(10031, "delete alert group error", "删除告警组错误"),
ALERT_GROUP_GRANT_USER_ERROR(10032, "alert group grant user error", "告警组授权用户错误"),
CREATE_DATASOURCE_ERROR(10033, "create datasource error", "创建数据源错误"),
UPDATE_DATASOURCE_ERROR(10034, "update datasource error", "更新数据源错误"),
QUERY_DATASOURCE_ERROR(10035, "query datasource error", "查询数据源错误"),
CONNECT_DATASOURCE_FAILURE(10036, "connect datasource failure", "建立数据源连接失败"),
CONNECTION_TEST_FAILURE(10037, "connection test failure", "测试数据源连接失败"),
DELETE_DATA_SOURCE_FAILURE(10038, "delete data source failure", "删除数据源失败"),
VERIFY_DATASOURCE_NAME_FAILURE(10039, "verify datasource name failure", "验证数据源名称失败"),
UNAUTHORIZED_DATASOURCE(10040, "unauthorized datasource", "未经授权的数据源"),
AUTHORIZED_DATA_SOURCE(10041, "authorized data source", "授权数据源失败"),
LOGIN_SUCCESS(10042, "login success", "登录成功"),
USER_LOGIN_FAILURE(10043, "user login failure", "用户登录失败"),
LIST_WORKERS_ERROR(10044, "list workers error", "查询worker列表错误"),
LIST_MASTERS_ERROR(10045, "list masters error", "查询master列表错误"),
UPDATE_PROJECT_ERROR(10046, "update project error", "更新项目信息错误"),
QUERY_PROJECT_DETAILS_BY_CODE_ERROR(10047, "query project details by code error", "查询项目详细信息错误"),
CREATE_PROJECT_ERROR(10048, "create project error", "创建项目错误"),
LOGIN_USER_QUERY_PROJECT_LIST_PAGING_ERROR(10049, "login user query project list paging error", "分页查询项目列表错误"),
DELETE_PROJECT_ERROR(10050, "delete project error", "删除项目错误"),
QUERY_UNAUTHORIZED_PROJECT_ERROR(10051, "query unauthorized project error", "查询未授权项目错误"),
QUERY_AUTHORIZED_PROJECT(10052, "query authorized project", "查询授权项目错误"),
QUERY_QUEUE_LIST_ERROR(10053, "query queue list error", "查询队列列表错误"),
CREATE_RESOURCE_ERROR(10054, "create resource error", "创建资源错误"),
UPDATE_RESOURCE_ERROR(10055, "update resource error", "更新资源错误"),
QUERY_RESOURCES_LIST_ERROR(10056, "query resources list error", "查询资源列表错误"),
QUERY_RESOURCES_LIST_PAGING(10057, "query resources list paging", "分页查询资源列表错误"),
DELETE_RESOURCE_ERROR(10058, "delete resource error", "删除资源错误"),
VERIFY_RESOURCE_BY_NAME_AND_TYPE_ERROR(10059, "verify resource by name and type error", "资源名称或类型验证错误"),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
VIEW_RESOURCE_FILE_ON_LINE_ERROR(10060, "view resource file online error", "查看资源文件错误"),
CREATE_RESOURCE_FILE_ON_LINE_ERROR(10061, "create resource file online error", "创建资源文件错误"),
RESOURCE_FILE_IS_EMPTY(10062, "resource file is empty", "资源文件内容不能为空"),
EDIT_RESOURCE_FILE_ON_LINE_ERROR(10063, "edit resource file online error", "更新资源文件错误"),
DOWNLOAD_RESOURCE_FILE_ERROR(10064, "download resource file error", "下载资源文件错误"),
CREATE_UDF_FUNCTION_ERROR(10065, "create udf function error", "创建UDF函数错误"),
VIEW_UDF_FUNCTION_ERROR(10066, "view udf function error", "查询UDF函数错误"),
UPDATE_UDF_FUNCTION_ERROR(10067, "update udf function error", "更新UDF函数错误"),
QUERY_UDF_FUNCTION_LIST_PAGING_ERROR(10068, "query udf function list paging error", "分页查询UDF函数列表错误"),
QUERY_DATASOURCE_BY_TYPE_ERROR(10069, "query datasource by type error", "查询数据源信息错误"),
VERIFY_UDF_FUNCTION_NAME_ERROR(10070, "verify udf function name error", "UDF函数名称验证错误"),
DELETE_UDF_FUNCTION_ERROR(10071, "delete udf function error", "删除UDF函数错误"),
AUTHORIZED_FILE_RESOURCE_ERROR(10072, "authorized file resource error", "授权资源文件错误"),
AUTHORIZE_RESOURCE_TREE(10073, "authorize resource tree display error", "授权资源目录树错误"),
UNAUTHORIZED_UDF_FUNCTION_ERROR(10074, "unauthorized udf function error", "查询未授权UDF函数错误"),
AUTHORIZED_UDF_FUNCTION_ERROR(10075, "authorized udf function error", "授权UDF函数错误"),
CREATE_SCHEDULE_ERROR(10076, "create schedule error", "创建调度配置错误"),
UPDATE_SCHEDULE_ERROR(10077, "update schedule error", "更新调度配置错误"),
PUBLISH_SCHEDULE_ONLINE_ERROR(10078, "publish schedule online error", "上线调度配置错误"),
OFFLINE_SCHEDULE_ERROR(10079, "offline schedule error", "下线调度配置错误"),
QUERY_SCHEDULE_LIST_PAGING_ERROR(10080, "query schedule list paging error", "分页查询调度配置列表错误"),
QUERY_SCHEDULE_LIST_ERROR(10081, "query schedule list error", "查询调度配置列表错误"),
QUERY_TASK_LIST_PAGING_ERROR(10082, "query task list paging error", "分页查询任务列表错误"),
QUERY_TASK_RECORD_LIST_PAGING_ERROR(10083, "query task record list paging error", "分页查询任务记录错误"),
CREATE_TENANT_ERROR(10084, "create tenant error", "创建租户错误"),
QUERY_TENANT_LIST_PAGING_ERROR(10085, "query tenant list paging error", "分页查询租户列表错误"),
QUERY_TENANT_LIST_ERROR(10086, "query tenant list error", "查询租户列表错误"),
UPDATE_TENANT_ERROR(10087, "update tenant error", "更新租户错误"),
DELETE_TENANT_BY_ID_ERROR(10088, "delete tenant by id error", "删除租户错误"),
VERIFY_OS_TENANT_CODE_ERROR(10089, "verify os tenant code error", "操作系统租户验证错误"),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
CREATE_USER_ERROR(10090, "create user error", "创建用户错误"),
QUERY_USER_LIST_PAGING_ERROR(10091, "query user list paging error", "分页查询用户列表错误"),
UPDATE_USER_ERROR(10092, "update user error", "更新用户错误"),
DELETE_USER_BY_ID_ERROR(10093, "delete user by id error", "删除用户错误"),
GRANT_PROJECT_ERROR(10094, "grant project error", "授权项目错误"),
GRANT_RESOURCE_ERROR(10095, "grant resource error", "授权资源错误"),
GRANT_UDF_FUNCTION_ERROR(10096, "grant udf function error", "授权UDF函数错误"),
GRANT_DATASOURCE_ERROR(10097, "grant datasource error", "授权数据源错误"),
GET_USER_INFO_ERROR(10098, "get user info error", "获取用户信息错误"),
USER_LIST_ERROR(10099, "user list error", "查询用户列表错误"),
VERIFY_USERNAME_ERROR(10100, "verify username error", "用户名验证错误"),
UNAUTHORIZED_USER_ERROR(10101, "unauthorized user error", "查询未授权用户错误"),
AUTHORIZED_USER_ERROR(10102, "authorized user error", "查询授权用户错误"),
QUERY_TASK_INSTANCE_LOG_ERROR(10103, "view task instance log error", "查询任务实例日志错误"),
DOWNLOAD_TASK_INSTANCE_LOG_FILE_ERROR(10104, "download task instance log file error", "下载任务日志文件错误"),
CREATE_PROCESS_DEFINITION_ERROR(10105, "create process definition error", "创建工作流错误"),
VERIFY_PROCESS_DEFINITION_NAME_UNIQUE_ERROR(10106, "verify process definition name unique error", "工作流定义名称验证错误"),
UPDATE_PROCESS_DEFINITION_ERROR(10107, "update process definition error", "更新工作流定义错误"),
RELEASE_PROCESS_DEFINITION_ERROR(10108, "release process definition error", "上线工作流错误"),
QUERY_DETAIL_OF_PROCESS_DEFINITION_ERROR(10109, "query detail of process definition error", "查询工作流详细信息错误"),
QUERY_PROCESS_DEFINITION_LIST(10110, "query process definition list", "查询工作流列表错误"),
ENCAPSULATION_TREEVIEW_STRUCTURE_ERROR(10111, "encapsulation treeview structure error", "查询工作流树形图数据错误"),
GET_TASKS_LIST_BY_PROCESS_DEFINITION_ID_ERROR(10112, "get tasks list by process definition id error",
"查询工作流定义节点信息错误"),
QUERY_PROCESS_INSTANCE_LIST_PAGING_ERROR(10113, "query process instance list paging error", "分页查询工作流实例列表错误"),
QUERY_TASK_LIST_BY_PROCESS_INSTANCE_ID_ERROR(10114, "query task list by process instance id error", "查询任务实例列表错误"),
UPDATE_PROCESS_INSTANCE_ERROR(10115, "update process instance error", "更新工作流实例错误"),
QUERY_PROCESS_INSTANCE_BY_ID_ERROR(10116, "query process instance by id error", "查询工作流实例错误"),
DELETE_PROCESS_INSTANCE_BY_ID_ERROR(10117, "delete process instance by id error", "删除工作流实例错误"),
QUERY_SUB_PROCESS_INSTANCE_DETAIL_INFO_BY_TASK_ID_ERROR(10118,
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
"query sub process instance detail info by task id error", "查询子流程任务实例错误"),
QUERY_PARENT_PROCESS_INSTANCE_DETAIL_INFO_BY_SUB_PROCESS_INSTANCE_ID_ERROR(10119,
"query parent process instance detail info by sub process instance id error", "查询子流程该工作流实例错误"),
QUERY_PROCESS_INSTANCE_ALL_VARIABLES_ERROR(10120, "query process instance all variables error", "查询工作流自定义变量信息错误"),
ENCAPSULATION_PROCESS_INSTANCE_GANTT_STRUCTURE_ERROR(10121, "encapsulation process instance gantt structure error",
"查询工作流实例甘特图数据错误"),
QUERY_PROCESS_DEFINITION_LIST_PAGING_ERROR(10122, "query process definition list paging error", "分页查询工作流定义列表错误"),
SIGN_OUT_ERROR(10123, "sign out error", "退出错误"),
OS_TENANT_CODE_HAS_ALREADY_EXISTS(10124, "os tenant code has already exists", "操作系统租户已存在"),
IP_IS_EMPTY(10125, "ip is empty", "IP地址不能为空"),
SCHEDULE_CRON_REALEASE_NEED_NOT_CHANGE(10126, "schedule release is already {0}", "调度配置上线错误[{0}]"),
CREATE_QUEUE_ERROR(10127, "create queue error", "创建队列错误"),
QUEUE_NOT_EXIST(10128, "queue {0} not exists", "队列ID[{0}]不存在"),
QUEUE_VALUE_EXIST(10129, "queue value {0} already exists", "队列值[{0}]已存在"),
QUEUE_NAME_EXIST(10130, "queue name {0} already exists", "队列名称[{0}]已存在"),
UPDATE_QUEUE_ERROR(10131, "update queue error", "更新队列信息错误"),
NEED_NOT_UPDATE_QUEUE(10132, "no content changes, no updates are required", "数据未变更，不需要更新队列信息"),
VERIFY_QUEUE_ERROR(10133, "verify queue error", "验证队列信息错误"),
NAME_NULL(10134, "name must be not null", "名称不能为空"),
NAME_EXIST(10135, "name {0} already exists", "名称[{0}]已存在"),
SAVE_ERROR(10136, "save error", "保存错误"),
DELETE_PROJECT_ERROR_DEFINES_NOT_NULL(10137, "please delete the process definitions in project first!",
"请先删除全部工作流定义"),
BATCH_DELETE_PROCESS_INSTANCE_BY_IDS_ERROR(10117, "batch delete process instance by ids {0} error",
"批量删除工作流实例错误: {0}"),
PREVIEW_SCHEDULE_ERROR(10139, "preview schedule error", "预览调度配置错误"),
PARSE_TO_CRON_EXPRESSION_ERROR(10140, "parse cron to cron expression error", "解析调度表达式错误"),
SCHEDULE_START_TIME_END_TIME_SAME(10141, "The start time must not be the same as the end", "开始时间不能和结束时间一样"),
DELETE_TENANT_BY_ID_FAIL(10142,
"delete tenant by id fail, for there are {0} process instances in executing using it",
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
"删除租户失败，有[{0}]个运行中的工作流实例正在使用"),
DELETE_TENANT_BY_ID_FAIL_DEFINES(10143, "delete tenant by id fail, for there are {0} process definitions using it",
"删除租户失败，有[{0}]个工作流定义正在使用"),
DELETE_TENANT_BY_ID_FAIL_USERS(10144, "delete tenant by id fail, for there are {0} users using it",
"删除租户失败，有[{0}]个用户正在使用"),
DELETE_WORKER_GROUP_BY_ID_FAIL(10145,
"delete worker group by id fail, for there are {0} process instances in executing using it",
"删除Worker分组失败，有[{0}]个运行中的工作流实例正在使用"),
QUERY_WORKER_GROUP_FAIL(10146, "query worker group fail ", "查询worker分组失败"),
DELETE_WORKER_GROUP_FAIL(10147, "delete worker group fail ", "删除worker分组失败"),
USER_DISABLED(10148, "The current user is disabled", "当前用户已停用"),
COPY_PROCESS_DEFINITION_ERROR(10149, "copy process definition from {0} to {1} error : {2}",
"从{0}复制工作流到{1}错误 : {2}"),
MOVE_PROCESS_DEFINITION_ERROR(10150, "move process definition from {0} to {1} error : {2}",
"从{0}移动工作流到{1}错误 : {2}"),
SWITCH_PROCESS_DEFINITION_VERSION_ERROR(10151, "Switch process definition version error", "切换工作流版本出错"),
SWITCH_PROCESS_DEFINITION_VERSION_NOT_EXIST_PROCESS_DEFINITION_ERROR(10152,
"Switch process definition version error: not exists process definition, [process definition id {0}]",
"切换工作流版本出错：工作流不存在，[工作流id {0}]"),
SWITCH_PROCESS_DEFINITION_VERSION_NOT_EXIST_PROCESS_DEFINITION_VERSION_ERROR(10153,
"Switch process definition version error: not exists process definition version, [process definition id {0}] [version number {1}]",
"切换工作流版本出错：工作流版本信息不存在，[工作流id {0}] [版本号 {1}]"),
QUERY_PROCESS_DEFINITION_VERSIONS_ERROR(10154, "query process definition versions error", "查询工作流历史版本信息出错"),
DELETE_PROCESS_DEFINITION_VERSION_ERROR(10156, "delete process definition version error", "删除工作流历史版本出错"),
QUERY_USER_CREATED_PROJECT_ERROR(10157, "query user created project error error", "查询用户创建的项目错误"),
PROCESS_DEFINITION_CODES_IS_EMPTY(10158, "process definition codes is empty", "工作流CODES不能为空"),
BATCH_COPY_PROCESS_DEFINITION_ERROR(10159, "batch copy process definition error", "复制工作流错误"),
BATCH_MOVE_PROCESS_DEFINITION_ERROR(10160, "batch move process definition error", "移动工作流错误"),
QUERY_WORKFLOW_LINEAGE_ERROR(10161, "query workflow lineage error", "查询血缘失败"),
QUERY_AUTHORIZED_AND_USER_CREATED_PROJECT_ERROR(10162, "query authorized and user created project error error",
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
"查询授权的和用户创建的项目错误"),
DELETE_PROCESS_DEFINITION_EXECUTING_FAIL(10163,
"delete process definition by code fail, for there are {0} process instances in executing using it",
"删除工作流定义失败，有[{0}]个运行中的工作流实例正在使用"),
CHECK_OS_TENANT_CODE_ERROR(10164, "Tenant code invalid, should follow linux's users naming conventions",
"非法的租户名，需要遵守 Linux 用户命名规范"),
FORCE_TASK_SUCCESS_ERROR(10165, "force task success error", "强制成功任务实例错误"),
TASK_INSTANCE_STATE_OPERATION_ERROR(10166,
"the status of task instance {0} is {1},Cannot perform force success operation",
"任务实例[{0}]的状态是[{1}]，无法执行强制成功操作"),
DATASOURCE_TYPE_NOT_EXIST(10167, "data source type not exist", "数据源类型不存在"),
PROCESS_DEFINITION_NAME_EXIST(10168, "process definition name {0} already exists", "工作流定义名称[{0}]已存在"),
DATASOURCE_DB_TYPE_ILLEGAL(10169, "datasource type illegal", "数据源类型参数不合法"),
DATASOURCE_PORT_ILLEGAL(10170, "datasource port illegal", "数据源端口参数不合法"),
DATASOURCE_OTHER_PARAMS_ILLEGAL(10171, "datasource other params illegal", "数据源其他参数不合法"),
DATASOURCE_NAME_ILLEGAL(10172, "datasource name illegal", "数据源名称不合法"),
DATASOURCE_HOST_ILLEGAL(10173, "datasource host illegal", "数据源HOST不合法"),
DELETE_WORKER_GROUP_NOT_EXIST(10174, "delete worker group not exist ", "删除worker分组不存在"),
CREATE_WORKER_GROUP_FORBIDDEN_IN_DOCKER(10175, "create worker group forbidden in docker ", "创建worker分组在docker中禁止"),
DELETE_WORKER_GROUP_FORBIDDEN_IN_DOCKER(10176, "delete worker group forbidden in docker ", "删除worker分组在docker中禁止"),
WORKER_ADDRESS_INVALID(10177, "worker address {0} invalid", "worker地址[{0}]无效"),
QUERY_WORKER_ADDRESS_LIST_FAIL(10178, "query worker address list fail ", "查询worker地址列表失败"),
TRANSFORM_PROJECT_OWNERSHIP(10179, "Please transform project ownership [{0}]", "请先转移项目所有权[{0}]"),
QUERY_ALERT_GROUP_ERROR(10180, "query alert group error", "查询告警组错误"),
CURRENT_LOGIN_USER_TENANT_NOT_EXIST(10181, "the tenant of the currently login user is not specified",
"未指定当前登录用户的租户"),
REVOKE_PROJECT_ERROR(10182, "revoke project error", "撤销项目授权错误"),
QUERY_AUTHORIZED_USER(10183, "query authorized user error", "查询拥有项目权限的用户错误"),
PROJECT_NOT_EXIST(10190, "This project was not found. Please refresh page.", "该项目不存在,请刷新页面"),
TASK_INSTANCE_HOST_IS_NULL(10191, "task instance host is null", "任务实例host为空"),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
QUERY_EXECUTING_WORKFLOW_ERROR(10192, "query executing workflow error", "查询运行的工作流实例错误"),
DELETE_PROCESS_DEFINITION_USE_BY_OTHER_FAIL(10193, "delete process definition fail, cause used by other tasks: {0}",
"删除工作流定时失败，被其他任务引用：{0}"),
DELETE_TASK_USE_BY_OTHER_FAIL(10194, "delete task {0} fail, cause used by other tasks: {1}",
"删除任务 {0} 失败，被其他任务引用：{1}"),
TASK_WITH_DEPENDENT_ERROR(10195, "task used in other tasks", "删除被其他任务引用"),
TASK_SAVEPOINT_ERROR(10196, "task savepoint error", "任务实例savepoint错误"),
TASK_STOP_ERROR(10197, "task stop error", "任务实例停止错误"),
LIST_TASK_TYPE_ERROR(10200, "list task type error", "查询任务类型列表错误"),
DELETE_TASK_TYPE_ERROR(10200, "delete task type error", "删除任务类型错误"),
ADD_TASK_TYPE_ERROR(10200, "add task type error", "添加任务类型错误"),
CREATE_PROCESS_DEFINITION_LOG_ERROR(10201, "Create process definition log error", "创建 process definition log 对象失败"),
PARSE_SCHEDULE_PARAM_ERROR(10202, "Parse schedule parameter error, {0}", "解析 schedule 参数错误, {0}"),
SCHEDULE_NOT_EXISTS(10023, "schedule {0} does not exist", "调度 id {0} 不存在"),
SCHEDULE_ALREADY_EXISTS(10024, "workflow {0} schedule {1} already exist, please update or delete it",
"工作流 {0} 的定时 {1} 已经存在，请更新或删除"),
UDF_FUNCTION_NOT_EXIST(20001, "UDF function not found", "UDF函数不存在"),
UDF_FUNCTION_EXISTS(20002, "UDF function already exists", "UDF函数已存在"),
RESOURCE_NOT_EXIST(20004, "resource not exist", "资源不存在"),
RESOURCE_EXIST(20005, "resource already exists", "资源已存在"),
RESOURCE_SUFFIX_NOT_SUPPORT_VIEW(20006, "resource suffix do not support online viewing", "资源文件后缀不支持查看"),
RESOURCE_SIZE_EXCEED_LIMIT(20007, "upload resource file size exceeds limit", "上传资源文件大小超过限制"),
RESOURCE_SUFFIX_FORBID_CHANGE(20008, "resource suffix not allowed to be modified", "资源文件后缀不支持修改"),
UDF_RESOURCE_SUFFIX_NOT_JAR(20009, "UDF resource suffix name must be jar", "UDF资源文件后缀名只支持[jar]"),
HDFS_COPY_FAIL(20010, "hdfs copy {0} -> {1} fail", "hdfs复制失败：[{0}] -> [{1}]"),
RESOURCE_FILE_EXIST(20011, "resource file {0} already exists in hdfs,please delete it or change name!",
"资源文件[{0}]在hdfs中已存在，请删除或修改资源名"),
RESOURCE_FILE_NOT_EXIST(20012, "resource file {0} not exists !", "资源文件[{0}]不存在"),
UDF_RESOURCE_IS_BOUND(20013, "udf resource file is bound by UDF functions:{0}", "udf函数绑定了资源文件[{0}]"),
RESOURCE_IS_USED(20014, "resource file is used by process definition", "资源文件被上线的流程定义使用了"),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
PARENT_RESOURCE_NOT_EXIST(20015, "parent resource not exist", "父资源文件不存在"),
RESOURCE_NOT_EXIST_OR_NO_PERMISSION(20016,
"resource not exist or no permission,please view the task node and remove error resource",
"请检查任务节点并移除无权限或者已删除的资源"),
RESOURCE_IS_AUTHORIZED(20017, "resource is authorized to user {0},suffix not allowed to be modified",
"资源文件已授权其他用户[{0}],后缀不允许修改"),
RESOURCE_HAS_FOLDER(20018, "There are files or folders in the current directory:{0}", "当前目录下有文件或文件夹[{0}]"),
USER_NO_OPERATION_PERM(30001, "user has no operation privilege", "当前用户没有操作权限"),
USER_NO_OPERATION_PROJECT_PERM(30002, "user {0} is not has project {1} permission", "当前用户[{0}]没有[{1}]项目的操作权限"),
PROCESS_INSTANCE_NOT_EXIST(50001, "process instance {0} does not exist", "工作流实例[{0}]不存在"),
PROCESS_INSTANCE_EXIST(50002, "process instance {0} already exists", "工作流实例[{0}]已存在"),
PROCESS_DEFINE_NOT_EXIST(50003, "process definition {0} does not exist", "工作流定义[{0}]不存在"),
PROCESS_DEFINE_NOT_RELEASE(50004, "process definition {0} process version {1} not online",
"工作流定义[{0}] 工作流版本[{1}]不是上线状态"),
SUB_PROCESS_DEFINE_NOT_RELEASE(50004, "exist sub process definition not online", "存在子工作流定义不是上线状态"),
PROCESS_INSTANCE_ALREADY_CHANGED(5e status of process instance {0} is already {1}",
"工作流实例[{0}]的状态已经是[{1}]"),
PROCESS_INSTANCE_STATE_OPERATION_ERROR(50006,
"the status of process instance {0} is {1},Cannot perform {2} operation",
"工作流实例[{0}]的状态是[{1}]，无法执行[{2}]操作"),
SUB_PROCESS_INSTANCE_NOT_EXIST(50007, "the task belong to process instance does not exist", "子工作流实例不存在"),
PROCESS_DEFINE_NOT_ALLOWED_EDIT(50008, "process definition {0} does not allow edit", "工作流定义[{0}]不允许修改"),
PROCESS_INSTANCE_EXECUTING_COMMAND(50009, "process instance {0} is executing the command, please wait ...",
"工作流实例[{0}]正在执行命令，请稍等..."),
PROCESS_INSTANCE_NOT_SUB_PROCESS_INSTANCE(50010, "process instance {0} is not sub process instance",
"工作流实例[{0}]不是子工作流实例"),
TASK_INSTANCE_STATE_COUNT_ERROR(50011, "task instance state count error", "查询各状态任务实例数错误"),
COUNT_PROCESS_INSTANCE_STATE_ERROR(50012, "count process instance state error", "查询各状态流程实例数错误"),
COUNT_PROCESS_DEFINITION_USER_ERROR(50013, "count process definition user error", "查询各用户流程定义数错误"),
START_PROCESS_INSTANCE_ERROR(50014, "start process instance error", "运行工作流实例错误"),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
BATCH_START_PROCESS_INSTANCE_ERROR(50014, "batch start process instance error: {0}", "批量运行工作流实例错误: {0}"),
PROCESS_INSTANCE_ERROR(50014, "process instance delete error: {0}", "工作流实例删除[{0}]错误"),
EXECUTE_PROCESS_INSTANCE_ERROR(50015, "execute process instance error", "操作工作流实例错误"),
CHECK_PROCESS_DEFINITION_ERROR(50016, "check process definition error", "工作流定义错误"),
QUERY_RECIPIENTS_AND_COPYERS_BY_PROCESS_DEFINITION_ERROR(50017,
"query recipients and copyers by process definition error", "查询收件人和抄送人错误"),
DATA_IS_NOT_VALID(50017, "data {0} not valid", "数据[{0}]无效"),
DATA_IS_NULL(50018, "data {0} is null", "数据[{0}]不能为空"),
PROCESS_NODE_HAS_CYCLE(50019, "process node has cycle", "流程节点间存在循环依赖"),
PROCESS_NODE_S_PARAMETER_INVALID(50020, "process node {0} parameter invalid", "流程节点[{0}]参数无效"),
PROCESS_DEFINE_STATE_ONLINE(50021, "process definition [{0}] is already online", "工作流定义[{0}]已上线"),
DELETE_PROCESS_DEFINE_BY_CODE_ERROR(50022, "delete process definition by code error", "删除工作流定义错误"),
SCHEDULE_STATE_ONLINE(50023, "the status of schedule {0} is already online", "调度配置[{0}]已上线"),
DELETE_SCHEDULE_BY_ID_ERROR(50024, "delete schedule by id error", "删除调度配置错误"),
BATCH_DELETE_PROCESS_DEFINE_ERROR(50025, "batch delete process definition error", "批量删除工作流定义错误"),
BATCH_DELETE_PROCESS_DEFINE_BY_CODES_ERROR(50026, "batch delete process definition by codes {0} error",
"批量删除工作流定义[{0}]错误"),
DELETE_PROCESS_DEFINE_BY_CODES_ERROR(50026, "delete process definition by codes {0} error", "删除工作流定义[{0}]错误"),
TENANT_NOT_SUITABLE(50027, "there is not any tenant suitable, please choose a tenant available.",
"没有合适的租户，请选择可用的租户"),
EXPORT_PROCESS_DEFINE_BY_ID_ERROR(50028, "export process definition by id error", "导出工作流定义错误"),
BATCH_EXPORT_PROCESS_DEFINE_BY_IDS_ERROR(50028, "batch export process definition by ids error", "批量导出工作流定义错误"),
IMPORT_PROCESS_DEFINE_ERROR(50029, "import process definition error", "导入工作流定义错误"),
TASK_DEFINE_NOT_EXIST(50030, "task definition [{0}] does not exist", "任务定义[{0}]不存在"),
CREATE_PROCESS_TASK_RELATION_ERROR(50032, "create process task relation error", "创建工作流任务关系错误"),
PROCESS_TASK_RELATION_NOT_EXIST(50033, "process task relation [{0}] does not exist", "工作流任务关系[{0}]不存在"),
PROCESS_TASK_RELATION_EXIST(50034, "process task relation is already exist, processCode:[{0}]",
"工作流任务关系已存在, processCode:[{0}]"),
PROCESS_DAG_IS_EMPTY(50035, "process dag is empty", "工作流dag是空"),
CHECK_PROCESS_TASK_RELATION_ERROR(50036, "check process task relation error", "工作流任务关系参数错误"),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
CREATE_TASK_DEFINITION_ERROR(50037, "create task definition error", "创建任务错误"),
UPDATE_TASK_DEFINITION_ERROR(50038, "update task definition error", "更新任务定义错误"),
QUERY_TASK_DEFINITION_VERSIONS_ERROR(50039, "query task definition versions error", "查询任务历史版本信息出错"),
SWITCH_TASK_DEFINITION_VERSION_ERROR(50040, "Switch task definition version error", "切换任务版本出错"),
DELETE_TASK_DEFINITION_VERSION_ERROR(50041, "delete task definition version error", "删除任务历史版本出错"),
DELETE_TASK_DEFINE_BY_CODE_ERROR(50042, "delete task definition by code error", "删除任务定义错误"),
QUERY_DETAIL_OF_TASK_DEFINITION_ERROR(50043, "query detail of task definition error", "查询任务详细信息错误"),
QUERY_TASK_DEFINITION_LIST_PAGING_ERROR(50044, "query task definition list paging error", "分页查询任务定义列表错误"),
TASK_DEFINITION_NAME_EXISTED(50045, "task definition name [{0}] already exists", "任务定义名称[{0}]已经存在"),
RELEASE_TASK_DEFINITION_ERROR(50046, "release task definition error", "上线任务错误"),
MOVE_PROCESS_TASK_RELATION_ERROR(50047, "move process task relation error", "移动任务到其他工作流错误"),
DELETE_TASK_PROCESS_RELATION_ERROR(50048, "delete process task relation error", "删除工作流任务关系错误"),
QUERY_TASK_PROCESS_RELATION_ERROR(50049, "query process task relation error", "查询工作流任务关系错误"),
TASK_DEFINE_STATE_ONLINE(50050, "task definition [{0}] is already online", "任务定义[{0}]已上线"),
TASK_HAS_DOWNSTREAM(50051, "Task exists downstream [{0}] dependence", "任务存在下游[{0}]依赖"),
TASK_HAS_UPSTREAM(50052, "Task [{0}] exists upstream dependence", "任务[{0}]存在上游依赖"),
MAIN_TABLE_USING_VERSION(50053, "the version that the master table is using", "主表正在使用该版本"),
PROJECT_PROCESS_NOT_MATCH(50054, "the project and the process is not match", "项目和工作流不匹配"),
DELETE_EDGE_ERROR(50055, "delete edge error", "删除工作流任务连接线错误"),
NOT_SUPPORT_UPDATE_TASK_DEFINITION(50056, "task state does not support modification", "当前任务不支持修改"),
NOT_SUPPORT_COPY_TASK_TYPE(50057, "task type [{0}] does not support copy", "不支持复制的任务类型[{0}]"),
BATCH_EXECUTE_PROCESS_INSTANCE_ERROR(50058, "change process instance : {0}", "修改工作实例状态错误: {0}"),
START_TASK_INSTANCE_ERROR(50059, "start task instance error", "运行任务流实例错误"),
HDFS_NOT_STARTUP(60001, "hdfs not startup", "hdfs未启用"),
STORAGE_NOT_STARTUP(60002, "storage not startup", "存储未启用"),
S3_CANNOT_RENAME(60003, "directory cannot be renamed", "S3无法重命名文件夹"),
/**
* for monitor
*/
QUERY_DATABASE_STATE_ERROR(70001, "query database state error", "查询数据库状态错误"),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
CREATE_ACCESS_TOKEN_ERROR(70010, "create access token error", "创建访问token错误"),
GENERATE_TOKEN_ERROR(70011, "generate token error", "生成token错误"),
QUERY_ACCESSTOKEN_LIST_PAGING_ERROR(70012, "query access token list paging error", "分页查询访问token列表错误"),
UPDATE_ACCESS_TOKEN_ERROR(70013, "update access token error", "更新访问token错误"),
DELETE_ACCESS_TOKEN_ERROR(70014, "delete access token error", "删除访问token错误"),
ACCESS_TOKEN_NOT_EXIST(70015, "access token not exist", "访问token不存在"),
QUERY_ACCESSTOKEN_BY_USER_ERROR(70016, "query access token by user error", "查询访问指定用户的token错误"),
COMMAND_STATE_COUNT_ERROR(80001, "task instance state count error", "查询各状态任务实例数错误"),
NEGTIVE_SIZE_NUMBER_ERROR(80002, "query size number error", "查询size错误"),
START_TIME_BIGGER_THAN_END_TIME_ERROR(80003, "start time bigger than end time error", "开始时间在结束时间之后错误"),
QUEUE_COUNT_ERROR(90001, "queue count error", "查询队列数据错误"),
KERBEROS_STARTUP_STATE(100001, "get kerberos startup state error", "获取kerberos启动状态错误"),
// audit log
QUERY_AUDIT_LOG_LIST_PAGING(10057, "query resources list paging", "分页查询资源列表错误"),
// plugin
PLUGIN_NOT_A_UI_COMPONENT(110001, "query plugin error, this plugin has no UI component", "查询插件错误，此插件无UI组件"),
QUERY_PLUGINS_RESULT_IS_NULL(110002,
"query alarm plugins result is empty, please check the startup status of the alarm component and confirm that the relevant alarm plugin is successfully registered",
"查询告警插件为空, 请检查告警组件启动状态并确认相关告警插件已注册成功"),
QUERY_PLUGINS_ERROR(110003, "query plugins error", "查询插件错误"),
QUERY_PLUGIN_DETAIL_RESULT_IS_NULL(110004, "query plugin detail result is null", "查询插件详情结果为空"),
UPDATE_ALERT_PLUGIN_INSTANCE_ERROR(110005, "update alert plugin instance error", "更新告警组和告警组插件实例错误"),
DELETE_ALERT_PLUGIN_INSTANCE_ERROR(110006, "delete alert plugin instance error", "删除告警组和告警组插件实例错误"),
GET_ALERT_PLUGIN_INSTANCE_ERROR(110007, "get alert plugin instance error", "获取告警组和告警组插件实例错误"),
CREATE_ALERT_PLUGIN_INSTANCE_ERROR(110008, "create alert plugin instance error", "创建告警组和告警组插件实例错误"),
QUERY_ALL_ALERT_PLUGIN_INSTANCE_ERROR(110009, "query all alert plugin instance error", "查询所有告警实例失败"),
PLUGIN_INSTANCE_ALREADY_EXIT(110010, "plugin instance already exit", "该告警插件实例已存在"),
LIST_PAGING_ALERT_PLUGIN_INSTANCE_ERROR(110011, "query plugin instance page error", "分页查询告警实例失败"),
DELETE_ALERT_PLUGIN_INSTANCE_ERROR_HAS_ALERT_GROUP_ASSOCIATED(110012,
"failed to delete the alert instance, there is an alarm group associated with this alert instance",
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
"删除告警实例失败，存在与此告警实例关联的警报组"),
PROCESS_DEFINITION_VERSION_IS_USED(110013, "this process definition version is used", "此工作流定义版本被使用"),
CREATE_ENVIRONMENT_ERROR(120001, "create environment error", "创建环境失败"),
ENVIRONMENT_NAME_EXISTS(120002, "this environment name [{0}] already exists", "环境名称[{0}]已经存在"),
ENVIRONMENT_NAME_IS_NULL(120003, "this environment name shouldn't be empty.", "环境名称不能为空"),
ENVIRONMENT_CONFIG_IS_NULL(120004, "this environment config shouldn't be empty.", "环境配置信息不能为空"),
UPDATE_ENVIRONMENT_ERROR(120005, "update environment [{0}] info error", "更新环境[{0}]信息失败"),
DELETE_ENVIRONMENT_ERROR(120006, "delete environment error", "删除环境信息失败"),
DELETE_ENVIRONMENT_RELATED_TASK_EXISTS(120007, "this environment has been used in tasks,so you can't delete it.",
"该环境已经被任务使用，所以不能删除该环境信息"),
QUERY_ENVIRONMENT_BY_NAME_ERROR(1200008, "not found environment name [{0}] ", "查询环境名称[{0}]不存在"),
QUERY_ENVIRONMENT_BY_CODE_ERROR(1200009, "not found environment code [{0}] ", "查询环境编码[{0}]不存在"),
QUERY_ENVIRONMENT_ERROR(1200010, "login user query environment error", "分页查询环境列表错误"),
VERIFY_ENVIRONMENT_ERROR(1200011, "verify environment error", "验证环境信息错误"),
GET_RULE_FORM_CREATE_JSON_ERROR(1200012, "get rule form create json error", "获取规则 FROM-CREATE-JSON 错误"),
QUERY_RULE_LIST_PAGING_ERROR(1200013, "query rule list paging error", "获取规则分页列表错误"),
QUERY_RULE_LIST_ERROR(1200014, "query rule list error", "获取规则列表错误"),
QUERY_RULE_INPUT_ENTRY_LIST_ERROR(1200015, "query rule list error", "获取规则列表错误"),
QUERY_EXECUTE_RESULT_LIST_PAGING_ERROR(1200016, "query execute result list paging error", "获取数据质量任务结果分页错误"),
GET_DATASOURCE_OPTIONS_ERROR(1200017, "get datasource options error", "获取数据源Options错误"),
GET_DATASOURCE_TABLES_ERROR(1200018, "get datasource tables error", "获取数据源表列表错误"),
GET_DATASOURCE_TABLE_COLUMNS_ERROR(1200019, "get datasource table columns error", "获取数据源表列名错误"),
CREATE_CLUSTER_ERROR(120020, "create cluster error", "创建集群失败"),
CLUSTER_NAME_EXISTS(120021, "this cluster name [{0}] already exists", "集群名称[{0}]已经存在"),
CLUSTER_NAME_IS_NULL(120022, "this cluster name shouldn't be empty.", "集群名称不能为空"),
CLUSTER_CONFIG_IS_NULL(120023, "this cluster config shouldn't be empty.", "集群配置信息不能为空"),
UPDATE_CLUSTER_ERROR(120024, "update cluster [{0}] info error", "更新集群[{0}]信息失败"),
DELETE_CLUSTER_ERROR(120025, "delete cluster error", "删除集群信息失败"),
K_EXISTS(120026, "this cluster has been used in tasks,so you can't delete it.",
"该集群已经被任务使用，所以不能删除该集群信息"),
|
closed
|
apache/dolphinscheduler
|
https://github.com/apache/dolphinscheduler
| 11,678 |
[Improvement][API] Improvement the error message when batch delete workflow
|
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When I batch delete workflows, any workflow fails, I get not friendly error message.
- We should display the workflow name rather then code
- We should display the reason why it delete failed
link #11554
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
|
https://github.com/apache/dolphinscheduler/issues/11678
|
https://github.com/apache/dolphinscheduler/pull/11682
|
962fa6dbd51c232b3b45243b408c5f19c1913879
|
1a4d7a842663574752bcabc222d2d0d778089fb7
| 2022-08-27T11:14:31Z |
java
| 2022-09-29T11:08:26Z |
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
|
QUERY_CLUSTER_BY_NAME_ERROR(1200027, "not found cluster [{0}] ", "查询集群名称[{0}]信息不存在"),
QUERY_CLUSTER_BY_CODE_ERROR(1200028, "not found cluster [{0}] ", "查询集群编码[{0}]不存在"),
QUERY_CLUSTER_ERROR(1200029, "login user query cluster error", "分页查询集群列表错误"),
VERIFY_CLUSTER_ERROR(1200030, "verify cluster error", "验证集群信息错误"),
CLUSTER_PROCESS_DEFINITIONS_IS_INVALID(1200031, "cluster worker groups is invalid format", "集群关联的工作组参数解析错误"),
UPDATE_CLUSTER_PROCESS_DEFINITION_RELATION_ERROR(1200032,
"You can't modify the process definition, because the process definition [{0}] and this cluster [{1}] already be used in the task [{2}]",
"您不能修改集群选项，因为该工作流组 [{0}] 和 该集群 [{1}] 已经被用在任务 [{2}] 中"),
CLUSTER_NOT_EXISTS(120033, "this cluster can not found in db.", "集群配置数据库里查询不到为空"),
DELETE_CLUSTER_RELATED_NAMESPACE_EXISTS(120034, "this cluster has been used in namespace,so you can't delete it.",
"该集群已经被命名空间使用，所以不能删除该集群信息"),
TASK_GROUP_NAME_EXSIT(130001, "this task group name is repeated in a project", "该任务组名称在一个项目中已经使用"),
TASK_GROUP_SIZE_ERROR(130002, "task group size error", "任务组大小应该为大于1的整数"),
TASK_GROUP_STATUS_ERROR(130003, "task group ", "任务组已经被关闭"),
TASK_GROUP_FULL(130004, "task group is full", "任务组已经满了"),
TASK_GROUP_USED_SIZE_ERROR(13e used size number of task group is dirty", "任务组使用的容量发生了变化"),
TASK_GROUP_QUEUE_RELEASE_ERROR(130006, "failed to release task group queue", "任务组资源释放时出现了错误"),
TASK_GROUP_QUEUE_AWAKE_ERROR(130007, "awake waiting task failed", "任务组使唤醒等待任务时发生了错误"),
CREATE_TASK_GROUP_ERROR(130008, "create task group error", "创建任务组错误"),
UPDATE_TASK_GROUP_ERROR(130009, "update task group list error", "更新任务组错误"),
QUERY_TASK_GROUP_LIST_ERROR(130010, "query task group list error", "查询任务组列表错误"),
CLOSE_TASK_GROUP_ERROR(130011, "close task group error", "关闭任务组错误"),
START_TASK_GROUP_ERROR(130012, "start task group error", "启动任务组错误"),
QUERY_TASK_GROUP_QUEUE_LIST_ERROR(130013, "query task group queue list error", "查询任务组队列列表错误"),
TASK_GROUP_CACHE_START_FAILED(130014, "cache start failed", "任务组相关的缓存启动失败"),
ENVIRONMENT_WORKER_GROUPS_IS_INVALID(130015, "environment worker groups is invalid format", "环境关联的工作组参数解析错误"),
UPDATE_ENVIRONMENT_WORKER_GROUP_RELATION_ERROR(130016,
"You can't modify the worker group, because the worker group [{0}] and this environment [{1}] already be used in the task [{2}]",
"您不能修改工作组选项，因为该工作组 [{0}] 和 该环境 [{1}] 已经被用在任务 [{2}] 中"),
TASK_GROUP_QUEUE_ALREADY_START(130017, "task group queue already start", "节点已经获取任务组资源"),
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.