status
stringclasses 1
value | repo_name
stringclasses 31
values | repo_url
stringclasses 31
values | issue_id
int64 1
104k
| title
stringlengths 4
233
| body
stringlengths 0
186k
⌀ | issue_url
stringlengths 38
56
| pull_url
stringlengths 37
54
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
unknown | language
stringclasses 5
values | commit_datetime
unknown | updated_file
stringlengths 7
188
| chunk_content
stringlengths 1
1.03M
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,261 | [Bug][server-api] copy the node ,the preTasks is error | When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node will not execute. | https://github.com/apache/dolphinscheduler/issues/5261 | https://github.com/apache/dolphinscheduler/pull/5264 | f82da57277c825d4588a6a0654b7730d333a5b18 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | "2021-04-12T12:33:58Z" | java | "2021-04-20T07:17:17Z" | dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java | TaskNode node3 = dag.getNode("3");
node3.setRunFlag(Constants.FLOWNODE_RUN_FLAG_FORBIDDEN);
TaskNode node8 = dag.getNode("8");
node8.setRunFlag(Constants.FLOWNODE_RUN_FLAG_FORBIDDEN);
TaskNode node5 = dag.getNode("5");
canSubmit = DagHelper.allDependsForbiddenOrEnd(node5, dag, skipNodeList, completeTaskList);
Assert.assertEquals(canSubmit, true);
}
/**
* test parse post node list
*/
@Test
public void testParsePostNodeList() throws JsonProcessingException {
DAG<String, TaskNode, TaskNodeRelation> dag = generateDag();
Map<String, TaskInstance> completeTaskList = new HashMap<>();
Map<String, TaskNode> skipNodeList = new HashMap<>();
Set<String> postNodes = null;
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(2, postNodes.size());
Assert.assertTrue(postNodes.contains("1"));
Assert.assertTrue(postNodes.contains("4"));
completeTaskList.put("1", new TaskInstance());
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(2, postNodes.size());
Assert.assertTrue(postNodes.contains("2")); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,261 | [Bug][server-api] copy the node ,the preTasks is error | When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node will not execute. | https://github.com/apache/dolphinscheduler/issues/5261 | https://github.com/apache/dolphinscheduler/pull/5264 | f82da57277c825d4588a6a0654b7730d333a5b18 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | "2021-04-12T12:33:58Z" | java | "2021-04-20T07:17:17Z" | dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java | Assert.assertTrue(postNodes.contains("4"));
completeTaskList.put("2", new TaskInstance());
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(2, postNodes.size());
Assert.assertTrue(postNodes.contains("4"));
Assert.assertTrue(postNodes.contains("8"));
completeTaskList.put("4", new TaskInstance());
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(2, postNodes.size());
Assert.assertTrue(postNodes.contains("3"));
Assert.assertTrue(postNodes.contains("8"));
completeTaskList.put("3", new TaskInstance());
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(2, postNodes.size());
Assert.assertTrue(postNodes.contains("8"));
Assert.assertTrue(postNodes.contains("6"));
completeTaskList.put("8", new TaskInstance());
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(2, postNodes.size());
Assert.assertTrue(postNodes.contains("5"));
Assert.assertTrue(postNodes.contains("6")); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,261 | [Bug][server-api] copy the node ,the preTasks is error | When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node will not execute. | https://github.com/apache/dolphinscheduler/issues/5261 | https://github.com/apache/dolphinscheduler/pull/5264 | f82da57277c825d4588a6a0654b7730d333a5b18 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | "2021-04-12T12:33:58Z" | java | "2021-04-20T07:17:17Z" | dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java | completeTaskList.put("6", new TaskInstance());
completeTaskList.put("5", new TaskInstance());
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(1, postNodes.size());
Assert.assertTrue(postNodes.contains("7"));
}
/**
* test forbidden post node
*
* @throws JsonProcessingException
*/
@Test
public void testForbiddenPostNode() throws JsonProcessingException {
DAG<String, TaskNode, TaskNodeRelation> dag = generateDag();
Map<String, TaskInstance> completeTaskList = new HashMap<>();
Map<String, TaskNode> skipNodeList = new HashMap<>();
Set<String> postNodes = null;
completeTaskList.put("1", new TaskInstance());
TaskNode node2 = dag.getNode("2");
node2.setRunFlag(Constants.FLOWNODE_RUN_FLAG_FORBIDDEN);
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(2, postNodes.size());
Assert.assertTrue(postNodes.contains("4"));
Assert.assertTrue(postNodes.contains("8"));
TaskNode node4 = dag.getNode("4");
node4.setRunFlag(Constants.FLOWNODE_RUN_FLAG_FORBIDDEN); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,261 | [Bug][server-api] copy the node ,the preTasks is error | When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node will not execute. | https://github.com/apache/dolphinscheduler/issues/5261 | https://github.com/apache/dolphinscheduler/pull/5264 | f82da57277c825d4588a6a0654b7730d333a5b18 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | "2021-04-12T12:33:58Z" | java | "2021-04-20T07:17:17Z" | dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java | postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(2, postNodes.size());
Assert.assertTrue(postNodes.contains("3"));
Assert.assertTrue(postNodes.contains("8"));
completeTaskList.put("8", new TaskInstance());
TaskNode node5 = dag.getNode("5");
node5.setRunFlag(Constants.FLOWNODE_RUN_FLAG_FORBIDDEN);
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(1, postNodes.size());
Assert.assertTrue(postNodes.contains("3"));
}
/**
* test condition post node
*
* @throws JsonProcessingException
*/
@Test
public void testConditionPostNode() throws JsonProcessingException {
DAG<String, TaskNode, TaskNodeRelation> dag = generateDag();
Map<String, TaskInstance> completeTaskList = new HashMap<>();
Map<String, TaskNode> skipNodeList = new HashMap<>();
Set<String> postNodes = null;
completeTaskList.put("1", new TaskInstance());
completeTaskList.put("2", new TaskInstance());
completeTaskList.put("4", new TaskInstance());
TaskNode node3 = dag.getNode("3");
node3.setType("CONDITIONS"); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,261 | [Bug][server-api] copy the node ,the preTasks is error | When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node will not execute. | https://github.com/apache/dolphinscheduler/issues/5261 | https://github.com/apache/dolphinscheduler/pull/5264 | f82da57277c825d4588a6a0654b7730d333a5b18 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | "2021-04-12T12:33:58Z" | java | "2021-04-20T07:17:17Z" | dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java | node3.setConditionResult("{\n"
+
" \"successNode\": [5\n"
+
" ],\n"
+
" \"failedNode\": [6\n"
+
" ]\n"
+
" }");
completeTaskList.remove("3");
TaskInstance taskInstance = new TaskInstance();
taskInstance.setState(ExecutionStatus.SUCCESS);
completeTaskList.put("3", taskInstance);
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(1, postNodes.size());
Assert.assertTrue(postNodes.contains("8"));
completeTaskList.put("8", new TaskInstance());
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertTrue(postNodes.contains("5"));
Assert.assertEquals(1, skipNodeList.size());
Assert.assertTrue(skipNodeList.containsKey("6"));
skipNodeList.clear();
TaskInstance taskInstance1 = new TaskInstance();
taskInstance.setState(ExecutionStatus.SUCCESS);
completeTaskList.put("5", taskInstance1); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,261 | [Bug][server-api] copy the node ,the preTasks is error | When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node will not execute. | https://github.com/apache/dolphinscheduler/issues/5261 | https://github.com/apache/dolphinscheduler/pull/5264 | f82da57277c825d4588a6a0654b7730d333a5b18 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | "2021-04-12T12:33:58Z" | java | "2021-04-20T07:17:17Z" | dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java | postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(1, postNodes.size());
Assert.assertTrue(postNodes.contains("7"));
Assert.assertEquals(1, skipNodeList.size());
Assert.assertTrue(skipNodeList.containsKey("6"));
skipNodeList.clear();
completeTaskList.remove("3");
taskInstance = new TaskInstance();
taskInstance.setState(ExecutionStatus.FAILURE);
completeTaskList.put("3", taskInstance);
postNodes = DagHelper.parsePostNodes(null, skipNodeList, dag, completeTaskList);
Assert.assertEquals(1, postNodes.size());
Assert.assertTrue(postNodes.contains("6"));
Assert.assertEquals(2, skipNodeList.size());
Assert.assertTrue(skipNodeList.containsKey("5"));
Assert.assertTrue(skipNodeList.containsKey("7"));
}
/**
* 1->2->3->5->7
* 4->3->6
* 2->8->5->7
*
* @return dag
* @throws JsonProcessingException if error throws JsonProcessingException
*/
private DAG<String, TaskNode, TaskNodeRelation> generateDag() throws JsonProcessingException {
List<TaskNode> taskNodeList = new ArrayList<>(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,261 | [Bug][server-api] copy the node ,the preTasks is error | When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node will not execute. | https://github.com/apache/dolphinscheduler/issues/5261 | https://github.com/apache/dolphinscheduler/pull/5264 | f82da57277c825d4588a6a0654b7730d333a5b18 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | "2021-04-12T12:33:58Z" | java | "2021-04-20T07:17:17Z" | dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java | TaskNode node1 = new TaskNode();
node1.setId("1");
node1.setName("1");
node1.setType("SHELL");
taskNodeList.add(node1);
TaskNode node2 = new TaskNode();
node2.setId("2");
node2.setName("2");
node2.setType("SHELL");
List<String> dep2 = new ArrayList<>();
dep2.add("1");
node2.setDepList(dep2);
taskNodeList.add(node2);
TaskNode node4 = new TaskNode();
node4.setId("4");
node4.setName("4");
node4.setType("SHELL");
taskNodeList.add(node4);
TaskNode node3 = new TaskNode();
node3.setId("3");
node3.setName("3");
node3.setType("SHELL");
List<String> dep3 = new ArrayList<>();
dep3.add("2");
dep3.add("4");
node3.setDepList(dep3);
taskNodeList.add(node3);
TaskNode node5 = new TaskNode();
node5.setId("5");
node5.setName("5"); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,261 | [Bug][server-api] copy the node ,the preTasks is error | When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node will not execute. | https://github.com/apache/dolphinscheduler/issues/5261 | https://github.com/apache/dolphinscheduler/pull/5264 | f82da57277c825d4588a6a0654b7730d333a5b18 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | "2021-04-12T12:33:58Z" | java | "2021-04-20T07:17:17Z" | dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java | node5.setType("SHELL");
List<String> dep5 = new ArrayList<>();
dep5.add("3");
dep5.add("8");
node5.setDepList(dep5);
taskNodeList.add(node5);
TaskNode node6 = new TaskNode();
node6.setId("6");
node6.setName("6");
node6.setType("SHELL");
List<String> dep6 = new ArrayList<>();
dep6.add("3");
node6.setDepList(dep6);
taskNodeList.add(node6);
TaskNode node7 = new TaskNode();
node7.setId("7");
node7.setName("7");
node7.setType("SHELL");
List<String> dep7 = new ArrayList<>();
dep7.add("5");
node7.setDepList(dep7);
taskNodeList.add(node7);
TaskNode node8 = new TaskNode();
node8.setId("8");
node8.setName("8");
node8.setType("SHELL");
List<String> dep8 = new ArrayList<>();
dep8.add("2");
node8.setDepList(dep8);
taskNodeList.add(node8); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,261 | [Bug][server-api] copy the node ,the preTasks is error | When we copy a node form process definition,the value preTasks is the source node .when we link the noe previous node ,this value would't change .when start a process instance from fail node ,this error may cause that some copy node which agter the failed node will not execute. | https://github.com/apache/dolphinscheduler/issues/5261 | https://github.com/apache/dolphinscheduler/pull/5264 | f82da57277c825d4588a6a0654b7730d333a5b18 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | "2021-04-12T12:33:58Z" | java | "2021-04-20T07:17:17Z" | dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/utils/DagHelperTest.java | List<String> startNodes = new ArrayList<>();
List<String> recoveryNodes = new ArrayList<>();
List<TaskNode> destTaskNodeList = DagHelper.generateFlowNodeListByStartNode(taskNodeList,
startNodes, recoveryNodes, TaskDependType.TASK_POST);
List<TaskNodeRelation> taskNodeRelations = DagHelper.generateRelationListByFlowNodes(destTaskNodeList);
ProcessDag processDag = new ProcessDag();
processDag.setEdges(taskNodeRelations);
processDag.setNodes(destTaskNodeList);
return DagHelper.buildDagGraph(processDag);
}
@Test
public void testBuildDagGraph() {
String shellJson = "{\"globalParams\":[],\"tasks\":[{\"type\":\"SHELL\",\"id\":\"tasks-9527\",\"name\":\"shell-1\","
+
"\"params\":{\"resourceList\":[],\"localParams\":[],\"rawScript\":\"#!/bin/bash\\necho \\\"shell-1\\\"\"},"
+
"\"description\":\"\",\"runFlag\":\"NORMAL\",\"dependence\":{},\"maxRetryTimes\":\"0\",\"retryInterval\":\"1\","
+
"\"timeout\":{\"strategy\":\"\",\"interval\":1,\"enable\":false},\"taskInstancePriority\":\"MEDIUM\","
+
"\"workerGroupId\":-1,\"preTasks\":[]}],\"tenantId\":1,\"timeout\":0}";
ProcessData processData = JSONUtils.parseObject(shellJson, ProcessData.class);
assert processData != null;
List<TaskNode> taskNodeList = processData.getTasks();
ProcessDag processDag = DagHelper.getProcessDag(taskNodeList);
DAG<String, TaskNode, TaskNodeRelation> dag = DagHelper.buildDagGraph(processDag);
Assert.assertNotNull(dag);
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.service.process;
import static org.apache.dolphinscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_END_DATE;
import static org.apache.dolphinscheduler.common.Constants.CMDPARAM_COMPLEMENT_DATA_START_DATE;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_EMPTY_SUB_PROCESS; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_FATHER_PARAMS;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_DEFINE_ID;
import static org.apache.dolphinscheduler.common.Constants.CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID;
import static org.apache.dolphinscheduler.common.Constants.LOCAL_PARAMS;
import static org.apache.dolphinscheduler.common.Constants.YYYY_MM_DD_HH_MM_SS;
import static java.util.stream.Collectors.toSet;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.enums.AuthorizationType;
import org.apache.dolphinscheduler.common.enums.CommandType;
import org.apache.dolphinscheduler.common.enums.CycleEnum;
import org.apache.dolphinscheduler.common.enums.Direct;
import org.apache.dolphinscheduler.common.enums.ExecutionStatus;
import org.apache.dolphinscheduler.common.enums.FailureStrategy;
import org.apache.dolphinscheduler.common.enums.Flag;
import org.apache.dolphinscheduler.common.enums.ResourceType;
import org.apache.dolphinscheduler.common.enums.TaskDependType;
import org.apache.dolphinscheduler.common.enums.TaskType;
import org.apache.dolphinscheduler.common.enums.WarningType;
import org.apache.dolphinscheduler.common.model.DateInterval;
import org.apache.dolphinscheduler.common.model.TaskNode;
import org.apache.dolphinscheduler.common.process.Property;
import org.apache.dolphinscheduler.common.task.conditions.ConditionsParameters;
import org.apache.dolphinscheduler.common.task.subprocess.SubProcessParameters;
import org.apache.dolphinscheduler.common.utils.CollectionUtils;
import org.apache.dolphinscheduler.common.utils.DateUtils;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.ParameterUtils;
import org.apache.dolphinscheduler.common.utils.StringUtils; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import org.apache.dolphinscheduler.dao.entity.Command;
import org.apache.dolphinscheduler.dao.entity.CycleDependency;
import org.apache.dolphinscheduler.dao.entity.DataSource;
import org.apache.dolphinscheduler.dao.entity.ErrorCommand;
import org.apache.dolphinscheduler.dao.entity.ProcessData;
import org.apache.dolphinscheduler.dao.entity.ProcessDefinition;
import org.apache.dolphinscheduler.dao.entity.ProcessInstance;
import org.apache.dolphinscheduler.dao.entity.ProcessInstanceMap;
import org.apache.dolphinscheduler.dao.entity.Project;
import org.apache.dolphinscheduler.dao.entity.ProjectUser;
import org.apache.dolphinscheduler.dao.entity.Resource;
import org.apache.dolphinscheduler.dao.entity.Schedule;
import org.apache.dolphinscheduler.dao.entity.TaskInstance;
import org.apache.dolphinscheduler.dao.entity.Tenant;
import org.apache.dolphinscheduler.dao.entity.UdfFunc;
import org.apache.dolphinscheduler.dao.entity.User;
import org.apache.dolphinscheduler.dao.mapper.CommandMapper;
import org.apache.dolphinscheduler.dao.mapper.DataSourceMapper;
import org.apache.dolphinscheduler.dao.mapper.ErrorCommandMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessDefinitionMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessInstanceMapMapper;
import org.apache.dolphinscheduler.dao.mapper.ProcessInstanceMapper;
import org.apache.dolphinscheduler.dao.mapper.ProjectMapper;
import org.apache.dolphinscheduler.dao.mapper.ResourceMapper;
import org.apache.dolphinscheduler.dao.mapper.ResourceUserMapper;
import org.apache.dolphinscheduler.dao.mapper.ScheduleMapper;
import org.apache.dolphinscheduler.dao.mapper.TaskInstanceMapper;
import org.apache.dolphinscheduler.dao.mapper.TenantMapper;
import org.apache.dolphinscheduler.dao.mapper.UdfFuncMapper;
import org.apache.dolphinscheduler.dao.mapper.UserMapper; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | import org.apache.dolphinscheduler.remote.utils.Host;
import org.apache.dolphinscheduler.service.log.LogClientService;
import org.apache.dolphinscheduler.service.quartz.cron.CronUtils;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Calendar;
import java.util.Date;
import java.util.EnumMap;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Set;
import java.util.stream.Collectors;
import org.quartz.CronExpression;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;
import org.springframework.transaction.annotation.Transactional;
import com.cronutils.model.Cron;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.node.ArrayNode;
import com.fasterxml.jackson.databind.node.ObjectNode;
/**
* process relative dao that some mappers in this.
*/
@Component |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public class ProcessService {
private final Logger logger = LoggerFactory.getLogger(getClass());
private final int[] stateArray = new int[]{ExecutionStatus.SUBMITTED_SUCCESS.ordinal(),
ExecutionStatus.RUNNING_EXECUTION.ordinal(),
ExecutionStatus.DELAY_EXECUTION.ordinal(),
ExecutionStatus.READY_PAUSE.ordinal(),
ExecutionStatus.READY_STOP.ordinal()};
@Autowired
private UserMapper userMapper;
@Autowired
private ProcessDefinitionMapper processDefineMapper;
@Autowired
private ProcessInstanceMapper processInstanceMapper;
@Autowired
private DataSourceMapper dataSourceMapper;
@Autowired
private ProcessInstanceMapMapper processInstanceMapMapper;
@Autowired
private TaskInstanceMapper taskInstanceMapper;
@Autowired
private CommandMapper commandMapper;
@Autowired
private ScheduleMapper scheduleMapper;
@Autowired
private UdfFuncMapper udfFuncMapper; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | @Autowired
private ResourceMapper resourceMapper;
@Autowired
private ResourceUserMapper resourceUserMapper;
@Autowired
private ErrorCommandMapper errorCommandMapper;
@Autowired
private TenantMapper tenantMapper;
@Autowired
private ProjectMapper projectMapper;
/**
* handle Command (construct ProcessInstance from Command) , wrapped in transaction
*
* @param logger logger
* @param host host
* @param validThreadNum validThreadNum
* @param command found command
* @return process instance
*/
@Transactional(rollbackFor = Exception.class)
public ProcessInstance handleCommand(Logger logger, String host, int validThreadNum, Command command) {
ProcessInstance processInstance = constructProcessInstance(command, host);
if (processInstance == null) {
logger.error("scan command, command parameter is error: {}", command);
moveToErrorCommand(command, "process instance is null");
return null;
}
if (!checkThreadNum(command, validThreadNum)) {
logger.info("there is not enough thread for this command: {}", command); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return setWaitingThreadProcess(command, processInstance);
}
processInstance.setCommandType(command.getCommandType());
processInstance.addHistoryCmd(command.getCommandType());
saveProcessInstance(processInstance);
this.setSubProcessParam(processInstance);
delCommandById(command.getId());
return processInstance;
}
/**
* save error command, and delete original command
*
* @param command command
* @param message message
*/
@Transactional(rollbackFor = Exception.class)
public void moveToErrorCommand(Command command, String message) {
ErrorCommand errorCommand = new ErrorCommand(command, message);
this.errorCommandMapper.insert(errorCommand);
delCommandById(command.getId());
}
/**
* set process waiting thread
*
* @param command command
* @param processInstance processInstance
* @return process instance
*/
private ProcessInstance setWaitingThreadProcess(Command command, ProcessInstance processInstance) {
processInstance.setState(ExecutionStatus.WAITTING_THREAD); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (command.getCommandType() != CommandType.RECOVER_WAITTING_THREAD) {
processInstance.addHistoryCmd(command.getCommandType());
}
saveProcessInstance(processInstance);
this.setSubProcessParam(processInstance);
createRecoveryWaitingThreadCommand(command, processInstance);
return null;
}
/**
* check thread num
*
* @param command command
* @param validThreadNum validThreadNum
* @return if thread is enough
*/
private boolean checkThreadNum(Command command, int validThreadNum) {
int commandThreadCount = this.workProcessThreadNumCount(command.getProcessDefinitionId());
return validThreadNum >= commandThreadCount;
}
/**
* insert one command
*
* @param command command
* @return create result
*/
public int createCommand(Command command) {
int result = 0;
if (command != null) {
result = commandMapper.insert(command);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return result;
}
/**
* find one command from queue list
*
* @return command
*/
public Command findOneCommand() {
return commandMapper.getOneToRun();
}
/**
* check the input command exists in queue list
*
* @param command command
* @return create command result
*/
public boolean verifyIsNeedCreateCommand(Command command) {
boolean isNeedCreate = true;
EnumMap<CommandType, Integer> cmdTypeMap = new EnumMap<>(CommandType.class);
cmdTypeMap.put(CommandType.REPEAT_RUNNING, 1);
cmdTypeMap.put(CommandType.RECOVER_SUSPENDED_PROCESS, 1);
cmdTypeMap.put(CommandType.START_FAILURE_TASK_PROCESS, 1);
CommandType commandType = command.getCommandType();
if (cmdTypeMap.containsKey(commandType)) {
ObjectNode cmdParamObj = JSONUtils.parseObject(command.getCommandParam());
int processInstanceId = cmdParamObj.path(CMD_PARAM_RECOVER_PROCESS_ID_STRING).asInt();
List<Command> commands = commandMapper.selectList(null);
for (Command tmpCommand : commands) {
if (cmdTypeMap.containsKey(tmpCommand.getCommandType())) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ObjectNode tempObj = JSONUtils.parseObject(tmpCommand.getCommandParam());
if (tempObj != null && processInstanceId == tempObj.path(CMD_PARAM_RECOVER_PROCESS_ID_STRING).asInt()) {
isNeedCreate = false;
break;
}
}
}
}
return isNeedCreate;
}
/**
* find process instance detail by id
*
* @param processId processId
* @return process instance
*/
public ProcessInstance findProcessInstanceDetailById(int processId) {
return processInstanceMapper.queryDetailById(processId);
}
/**
* get task node list by definitionId
*/
public List<TaskNode> getTaskNodeListByDefinitionId(Integer defineId) {
ProcessDefinition processDefinition = processDefineMapper.selectById(defineId);
if (processDefinition == null) {
logger.info("process define not exists");
return null;
}
String processDefinitionJson = processDefinition.getProcessDefinitionJson();
ProcessData processData = JSONUtils.parseObject(processDefinitionJson, ProcessData.class); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (null == processData) {
logger.error("process data is null");
return new ArrayList<>();
}
return processData.getTasks();
}
/**
* find process instance by id
*
* @param processId processId
* @return process instance
*/
public ProcessInstance findProcessInstanceById(int processId) {
return processInstanceMapper.selectById(processId);
}
/**
* find process define by id.
*
* @param processDefinitionId processDefinitionId
* @return process definition
*/
public ProcessDefinition findProcessDefineById(int processDefinitionId) {
return processDefineMapper.selectById(processDefinitionId);
}
/**
* delete work process instance by id
*
* @param processInstanceId processInstanceId
* @return delete process instance result |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | */
public int deleteWorkProcessInstanceById(int processInstanceId) {
return processInstanceMapper.deleteById(processInstanceId);
}
/**
* delete all sub process by parent instance id
*
* @param processInstanceId processInstanceId
* @return delete all sub process instance result
*/
public int deleteAllSubWorkProcessByParentId(int processInstanceId) {
List<Integer> subProcessIdList = processInstanceMapMapper.querySubIdListByParentId(processInstanceId);
for (Integer subId : subProcessIdList) {
deleteAllSubWorkProcessByParentId(subId);
deleteWorkProcessMapByParentId(subId);
removeTaskLogFile(subId);
deleteWorkProcessInstanceById(subId);
}
return 1;
}
/**
* remove task log file
*
* @param processInstanceId processInstanceId
*/
public void removeTaskLogFile(Integer processInstanceId) {
List<TaskInstance> taskInstanceList = findValidTaskListByProcessId(processInstanceId);
if (CollectionUtils.isEmpty(taskInstanceList)) {
return;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | try (LogClientService logClient = new LogClientService()) {
for (TaskInstance taskInstance : taskInstanceList) {
String taskLogPath = taskInstance.getLogPath();
if (StringUtils.isEmpty(taskInstance.getHost())) {
continue;
}
int port = Constants.RPC_PORT;
String ip = "";
try {
ip = Host.of(taskInstance.getHost()).getIp();
} catch (Exception e) {
ip = taskInstance.getHost();
}
logClient.removeTaskLog(ip, port, taskLogPath);
}
}
}
/**
* calculate sub process number in the process define.
*
* @param processDefinitionId processDefinitionId
* @return process thread num count
*/
private Integer workProcessThreadNumCount(Integer processDefinitionId) {
List<Integer> ids = new ArrayList<>();
recurseFindSubProcessId(processDefinitionId, ids);
return ids.size() + 1;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /**
* recursive query sub process definition id by parent id.
*
* @param parentId parentId
* @param ids ids
*/
public void recurseFindSubProcessId(int parentId, List<Integer> ids) {
ProcessDefinition processDefinition = processDefineMapper.selectById(parentId);
String processDefinitionJson = processDefinition.getProcessDefinitionJson();
ProcessData processData = JSONUtils.parseObject(processDefinitionJson, ProcessData.class);
List<TaskNode> taskNodeList = processData.getTasks();
if (taskNodeList != null && !taskNodeList.isEmpty()) {
for (TaskNode taskNode : taskNodeList) {
String parameter = taskNode.getParams();
ObjectNode parameterJson = JSONUtils.parseObject(parameter);
if (parameterJson.get(CMD_PARAM_SUB_PROCESS_DEFINE_ID) != null) {
SubProcessParameters subProcessParam = JSONUtils.parseObject(parameter, SubProcessParameters.class);
ids.add(subProcessParam.getProcessDefinitionId());
recurseFindSubProcessId(subProcessParam.getProcessDefinitionId(), ids);
}
}
}
}
/**
* create recovery waiting thread command when thread pool is not enough for the process instance.
* sub work process instance need not to create recovery command.
* create recovery waiting thread command and delete origin command at the same time.
* if the recovery command is exists, only update the field update_time
*
* @param originCommand originCommand |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param processInstance processInstance
*/
public void createRecoveryWaitingThreadCommand(Command originCommand, ProcessInstance processInstance) {
if (processInstance.getIsSubProcess() == Flag.YES) {
if (originCommand != null) {
commandMapper.deleteById(originCommand.getId());
}
return;
}
Map<String, String> cmdParam = new HashMap<>();
cmdParam.put(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD, String.valueOf(processInstance.getId()));
if (originCommand == null) {
Command command = new Command(
CommandType.RECOVER_WAITTING_THREAD,
processInstance.getTaskDependType(),
processInstance.getFailureStrategy(),
processInstance.getExecutorId(),
processInstance.getProcessDefinitionId(),
JSONUtils.toJsonString(cmdParam),
processInstance.getWarningType(),
processInstance.getWarningGroupId(),
processInstance.getScheduleTime(),
processInstance.getWorkerGroup(),
processInstance.getProcessInstancePriority()
);
saveCommand(command);
return;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (originCommand.getCommandType() == CommandType.RECOVER_WAITTING_THREAD) {
originCommand.setUpdateTime(new Date());
saveCommand(originCommand);
} else {
commandMapper.deleteById(originCommand.getId());
originCommand.setId(0);
originCommand.setCommandType(CommandType.RECOVER_WAITTING_THREAD);
originCommand.setUpdateTime(new Date());
originCommand.setCommandParam(JSONUtils.toJsonString(cmdParam));
originCommand.setProcessInstancePriority(processInstance.getProcessInstancePriority());
saveCommand(originCommand);
}
}
/**
* get schedule time from command
*
* @param command command
* @param cmdParam cmdParam map
* @return date
*/
private Date getScheduleTime(Command command, Map<String, String> cmdParam) {
Date scheduleTime = command.getScheduleTime();
if (scheduleTime == null && cmdParam != null && cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {
scheduleTime = DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE));
}
return scheduleTime;
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * generate a new work process instance from command.
*
* @param processDefinition processDefinition
* @param command command
* @param cmdParam cmdParam map
* @return process instance
*/
private ProcessInstance generateNewProcessInstance(ProcessDefinition processDefinition,
Command command,
Map<String, String> cmdParam) {
ProcessInstance processInstance = new ProcessInstance(processDefinition);
processInstance.setState(ExecutionStatus.RUNNING_EXECUTION);
processInstance.setRecovery(Flag.NO);
processInstance.setStartTime(new Date());
processInstance.setRunTimes(1);
processInstance.setMaxTryTimes(0);
processInstance.setProcessDefinitionId(command.getProcessDefinitionId());
processInstance.setCommandParam(command.getCommandParam());
processInstance.setCommandType(command.getCommandType());
processInstance.setIsSubProcess(Flag.NO);
processInstance.setTaskDependType(command.getTaskDependType());
processInstance.setFailureStrategy(command.getFailureStrategy());
processInstance.setExecutorId(command.getExecutorId());
WarningType warningType = command.getWarningType() == null ? WarningType.NONE : command.getWarningType();
processInstance.setWarningType(warningType);
Integer warningGroupId = command.getWarningGroupId() == null ? 0 : command.getWarningGroupId();
processInstance.setWarningGroupId(warningGroupId);
Date scheduleTime = getScheduleTime(command, cmdParam);
if (scheduleTime != null) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processInstance.setScheduleTime(scheduleTime);
}
processInstance.setCommandStartTime(command.getStartTime());
processInstance.setLocations(processDefinition.getLocations());
processInstance.setConnects(processDefinition.getConnects());
setGlobalParamIfCommanded(processDefinition, cmdParam);
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
processDefinition.getGlobalParamMap(),
processDefinition.getGlobalParamList(),
getCommandTypeIfComplement(processInstance, command),
processInstance.getScheduleTime()));
processInstance.setProcessInstanceJson(processDefinition.getProcessDefinitionJson());
processInstance.setProcessInstancePriority(command.getProcessInstancePriority());
String workerGroup = StringUtils.isBlank(command.getWorkerGroup()) ? Constants.DEFAULT_WORKER_GROUP : command.getWorkerGroup();
processInstance.setWorkerGroup(workerGroup);
processInstance.setTimeout(processDefinition.getTimeout());
processInstance.setTenantId(processDefinition.getTenantId());
return processInstance;
}
private void setGlobalParamIfCommanded(ProcessDefinition processDefinition, Map<String, String> cmdParam) {
Map<String, String> startParamMap = new HashMap<>();
if (cmdParam != null && cmdParam.containsKey(Constants.CMD_PARAM_START_PARAMS)) {
String startParamJson = cmdParam.get(Constants.CMD_PARAM_START_PARAMS);
startParamMap = JSONUtils.toMap(startParamJson);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | Map<String, String> fatherParamMap = new HashMap<>();
if (cmdParam != null && cmdParam.containsKey(Constants.CMD_PARAM_FATHER_PARAMS)) {
String fatherParamJson = cmdParam.get(Constants.CMD_PARAM_FATHER_PARAMS);
fatherParamMap = JSONUtils.toMap(fatherParamJson);
}
startParamMap.putAll(fatherParamMap);
if (startParamMap.size() > 0
&& processDefinition.getGlobalParamMap() != null) {
for (Map.Entry<String, String> param : processDefinition.getGlobalParamMap().entrySet()) {
String val = startParamMap.get(param.getKey());
if (val != null) {
param.setValue(val);
}
}
}
}
/**
* get process tenant
* there is tenant id in definition, use the tenant of the definition.
* if there is not tenant id in the definiton or the tenant not exist
* use definition creator's tenant.
*
* @param tenantId tenantId
* @param userId userId
* @return tenant
*/
public Tenant getTenantForProcess(int tenantId, int userId) {
Tenant tenant = null;
if (tenantId >= 0) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | tenant = tenantMapper.queryById(tenantId);
}
if (userId == 0) {
return null;
}
if (tenant == null) {
User user = userMapper.selectById(userId);
tenant = tenantMapper.queryById(user.getTenantId());
}
return tenant;
}
/**
* check command parameters is valid
*
* @param command command
* @param cmdParam cmdParam map
* @return whether command param is valid
*/
private Boolean checkCmdParam(Command command, Map<String, String> cmdParam) {
if (command.getTaskDependType() == TaskDependType.TASK_ONLY || command.getTaskDependType() == TaskDependType.TASK_PRE) {
if (cmdParam == null
|| !cmdParam.containsKey(Constants.CMD_PARAM_START_NODE_NAMES)
|| cmdParam.get(Constants.CMD_PARAM_START_NODE_NAMES).isEmpty()) {
logger.error("command node depend type is {}, but start nodes is null ", command.getTaskDependType());
return false;
}
}
return true;
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * construct process instance according to one command.
*
* @param command command
* @param host host
* @return process instance
*/
private ProcessInstance constructProcessInstance(Command command, String host) {
ProcessInstance processInstance = null;
CommandType commandType = command.getCommandType();
Map<String, String> cmdParam = JSONUtils.toMap(command.getCommandParam());
ProcessDefinition processDefinition = null;
if (command.getProcessDefinitionId() != 0) {
processDefinition = processDefineMapper.selectById(command.getProcessDefinitionId());
if (processDefinition == null) {
logger.error("cannot find the work process define! define id : {}", command.getProcessDefinitionId());
return null;
}
}
if (cmdParam != null) {
Integer processInstanceId = 0;
if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING)) {
String processId = cmdParam.get(Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING);
processInstanceId = Integer.parseInt(processId);
if (processInstanceId == 0) {
logger.error("command parameter is error, [ ProcessInstanceId ] is 0");
return null;
}
} else if (cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | String pId = cmdParam.get(Constants.CMD_PARAM_SUB_PROCESS);
processInstanceId = Integer.parseInt(pId);
} else if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD)) {
String pId = cmdParam.get(Constants.CMD_PARAM_RECOVERY_WAITING_THREAD);
processInstanceId = Integer.parseInt(pId);
}
if (processInstanceId == 0) {
processInstance = generateNewProcessInstance(processDefinition, command, cmdParam);
} else {
processInstance = this.findProcessInstanceDetailById(processInstanceId);
CommandType commandTypeIfComplement = getCommandTypeIfComplement(processInstance, command);
if (commandTypeIfComplement == CommandType.REPEAT_RUNNING) {
setGlobalParamIfCommanded(processDefinition, cmdParam);
}
}
processDefinition = processDefineMapper.selectById(processInstance.getProcessDefinitionId());
processInstance.setProcessDefinition(processDefinition);
if (processInstance.getCommandParam() != null) {
Map<String, String> processCmdParam = JSONUtils.toMap(processInstance.getCommandParam());
for (Map.Entry<String, String> entry : processCmdParam.entrySet()) {
if (!cmdParam.containsKey(entry.getKey())) {
cmdParam.put(entry.getKey(), entry.getValue());
}
}
}
if (cmdParam.containsKey(Constants.CMD_PARAM_SUB_PROCESS)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processInstance.setCommandParam(command.getCommandParam());
}
} else {
processInstance = generateNewProcessInstance(processDefinition, command, cmdParam);
}
if (Boolean.FALSE.equals(checkCmdParam(command, cmdParam))) {
logger.error("command parameter check failed!");
return null;
}
if (command.getScheduleTime() != null) {
processInstance.setScheduleTime(command.getScheduleTime());
}
processInstance.setHost(host);
ExecutionStatus runStatus = ExecutionStatus.RUNNING_EXECUTION;
int runTime = processInstance.getRunTimes();
switch (commandType) {
case START_PROCESS:
break;
case START_FAILURE_TASK_PROCESS:
List<Integer> failedList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.FAILURE);
List<Integer> toleranceList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.NEED_FAULT_TOLERANCE);
List<Integer> killedList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.KILL);
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING);
failedList.addAll(killedList);
failedList.addAll(toleranceList);
for (Integer taskId : failedList) {
initTaskInstance(this.findTaskInstanceById(taskId));
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | cmdParam.put(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING,
String.join(Constants.COMMA, convertIntListToString(failedList)));
processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam));
processInstance.setRunTimes(runTime + 1);
break;
case START_CURRENT_TASK_PROCESS:
break;
case RECOVER_WAITTING_THREAD:
break;
case RECOVER_SUSPENDED_PROCESS:
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING);
List<Integer> suspendedNodeList = this.findTaskIdByInstanceState(processInstance.getId(), ExecutionStatus.PAUSE);
List<Integer> stopNodeList = findTaskIdByInstanceState(processInstance.getId(),
ExecutionStatus.KILL);
suspendedNodeList.addAll(stopNodeList);
for (Integer taskId : suspendedNodeList) {
initTaskInstance(this.findTaskInstanceById(taskId));
}
cmdParam.put(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING, String.join(",", convertIntListToString(suspendedNodeList)));
processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam));
processInstance.setRunTimes(runTime + 1);
break;
case RECOVER_TOLERANCE_FAULT_PROCESS:
processInstance.setRecovery(Flag.YES);
runStatus = processInstance.getState();
break;
case COMPLEMENT_DATA: |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | List<TaskInstance> taskInstanceList = this.findValidTaskListByProcessId(processInstance.getId());
for (TaskInstance taskInstance : taskInstanceList) {
taskInstance.setFlag(Flag.NO);
this.updateTaskInstance(taskInstance);
}
initComplementDataParam(processDefinition, processInstance, cmdParam);
break;
case REPEAT_RUNNING:
if (cmdParam.containsKey(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING)) {
cmdParam.remove(Constants.CMD_PARAM_RECOVERY_START_NODE_STRING);
processInstance.setCommandParam(JSONUtils.toJsonString(cmdParam));
}
List<TaskInstance> validTaskList = findValidTaskListByProcessId(processInstance.getId());
for (TaskInstance taskInstance : validTaskList) {
taskInstance.setFlag(Flag.NO);
updateTaskInstance(taskInstance);
}
processInstance.setStartTime(new Date());
processInstance.setEndTime(null);
processInstance.setRunTimes(runTime + 1);
initComplementDataParam(processDefinition, processInstance, cmdParam);
break;
case SCHEDULER:
break;
default:
break;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processInstance.setState(runStatus);
return processInstance;
}
/**
* return complement data if the process start with complement data
*
* @param processInstance processInstance
* @param command command
* @return command type
*/
private CommandType getCommandTypeIfComplement(ProcessInstance processInstance, Command command) {
if (CommandType.COMPLEMENT_DATA == processInstance.getCmdTypeIfComplement()) {
return CommandType.COMPLEMENT_DATA;
} else {
return command.getCommandType();
}
}
/**
* initialize complement data parameters
*
* @param processDefinition processDefinition
* @param processInstance processInstance
* @param cmdParam cmdParam
*/
private void initComplementDataParam(ProcessDefinition processDefinition,
ProcessInstance processInstance,
Map<String, String> cmdParam) {
if (!processInstance.isComplementData()) {
return;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | Date startComplementTime = DateUtils.parse(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE),
YYYY_MM_DD_HH_MM_SS);
if (Flag.NO == processInstance.getIsSubProcess()) {
processInstance.setScheduleTime(startComplementTime);
}
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
processDefinition.getGlobalParamMap(),
processDefinition.getGlobalParamList(),
CommandType.COMPLEMENT_DATA, processInstance.getScheduleTime()));
}
/**
* set sub work process parameters.
* handle sub work process instance, update relation table and command parameters
* set sub work process flag, extends parent work process command parameters
*
* @param subProcessInstance subProcessInstance
* @return process instance
*/
public ProcessInstance setSubProcessParam(ProcessInstance subProcessInstance) {
String cmdParam = subProcessInstance.getCommandParam();
if (StringUtils.isEmpty(cmdParam)) {
return subProcessInstance;
}
Map<String, String> paramMap = JSONUtils.toMap(cmdParam);
if (paramMap.containsKey(CMD_PARAM_SUB_PROCESS)
&& CMD_PARAM_EMPTY_SUB_PROCESS.equals(paramMap.get(CMD_PARAM_SUB_PROCESS))) {
paramMap.remove(CMD_PARAM_SUB_PROCESS);
paramMap.put(CMD_PARAM_SUB_PROCESS, String.valueOf(subProcessInstance.getId()));
subProcessInstance.setCommandParam(JSONUtils.toJsonString(paramMap)); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | subProcessInstance.setIsSubProcess(Flag.YES);
this.saveProcessInstance(subProcessInstance);
}
String parentInstanceId = paramMap.get(CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID);
if (StringUtils.isNotEmpty(parentInstanceId)) {
ProcessInstance parentInstance = findProcessInstanceDetailById(Integer.parseInt(parentInstanceId));
if (parentInstance != null) {
subProcessInstance.setGlobalParams(
joinGlobalParams(parentInstance.getGlobalParams(), subProcessInstance.getGlobalParams()));
this.saveProcessInstance(subProcessInstance);
} else {
logger.error("sub process command params error, cannot find parent instance: {} ", cmdParam);
}
}
ProcessInstanceMap processInstanceMap = JSONUtils.parseObject(cmdParam, ProcessInstanceMap.class);
if (processInstanceMap == null || processInstanceMap.getParentProcessInstanceId() == 0) {
return subProcessInstance;
}
processInstanceMap.setProcessInstanceId(subProcessInstance.getId());
this.updateWorkProcessInstanceMap(processInstanceMap);
return subProcessInstance;
}
/**
* join parent global params into sub process.
* only the keys doesn't in sub process global would be joined.
*
* @param parentGlobalParams parentGlobalParams
* @param subGlobalParams subGlobalParams |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @return global params join
*/
private String joinGlobalParams(String parentGlobalParams, String subGlobalParams) {
List<Property> parentPropertyList = JSONUtils.toList(parentGlobalParams, Property.class);
List<Property> subPropertyList = JSONUtils.toList(subGlobalParams, Property.class);
Map<String, String> subMap = subPropertyList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue));
for (Property parent : parentPropertyList) {
if (!subMap.containsKey(parent.getProp())) {
subPropertyList.add(parent);
}
}
return JSONUtils.toJsonString(subPropertyList);
}
/**
* initialize task instance
*
* @param taskInstance taskInstance
*/
private void initTaskInstance(TaskInstance taskInstance) {
if (!taskInstance.isSubProcess()
&& (taskInstance.getState().typeIsCancel() || taskInstance.getState().typeIsFailure())) {
taskInstance.setFlag(Flag.NO);
updateTaskInstance(taskInstance);
return;
}
taskInstance.setState(ExecutionStatus.SUBMITTED_SUCCESS);
updateTaskInstance(taskInstance);
}
/**
* submit task to db |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * submit sub process to command
*
* @param taskInstance taskInstance
* @return task instance
*/
@Transactional(rollbackFor = Exception.class)
public TaskInstance submitTask(TaskInstance taskInstance) {
ProcessInstance processInstance = this.findProcessInstanceDetailById(taskInstance.getProcessInstanceId());
logger.info("start submit task : {}, instance id:{}, state: {}",
taskInstance.getName(), taskInstance.getProcessInstanceId(), processInstance.getState());
TaskInstance task = submitTaskInstanceToDB(taskInstance, processInstance);
if (task == null) {
logger.error("end submit task to db error, task name:{}, process id:{} state: {} ",
taskInstance.getName(), taskInstance.getProcessInstance(), processInstance.getState());
return task;
}
if (!task.getState().typeIsFinished()) {
createSubWorkProcess(processInstance, task);
}
logger.info("end submit task to db successfully:{} state:{} complete, instance id:{} state: {} ",
taskInstance.getName(), task.getState(), processInstance.getId(), processInstance.getState());
return task;
}
/**
* set work process instance map
* consider o
* repeat running does not generate new sub process instance
* set map {parent instance id, task instance id, 0(child instance id)}
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param parentInstance parentInstance
* @param parentTask parentTask
* @return process instance map
*/
private ProcessInstanceMap setProcessInstanceMap(ProcessInstance parentInstance, TaskInstance parentTask) {
ProcessInstanceMap processMap = findWorkProcessMapByParent(parentInstance.getId(), parentTask.getId());
if (processMap != null) {
return processMap;
}
if (parentInstance.getCommandType() == CommandType.REPEAT_RUNNING) {
processMap = findPreviousTaskProcessMap(parentInstance, parentTask);
if (processMap != null) {
processMap.setParentTaskInstanceId(parentTask.getId());
updateWorkProcessInstanceMap(processMap);
return processMap;
}
}
processMap = new ProcessInstanceMap();
processMap.setParentProcessInstanceId(parentInstance.getId());
processMap.setParentTaskInstanceId(parentTask.getId());
createWorkProcessInstanceMap(processMap);
return processMap;
}
/**
* find previous task work process map.
*
* @param parentProcessInstance parentProcessInstance
* @param parentTask parentTask |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @return process instance map
*/
private ProcessInstanceMap findPreviousTaskProcessMap(ProcessInstance parentProcessInstance,
TaskInstance parentTask) {
Integer preTaskId = 0;
List<TaskInstance> preTaskList = this.findPreviousTaskListByWorkProcessId(parentProcessInstance.getId());
for (TaskInstance task : preTaskList) {
if (task.getName().equals(parentTask.getName())) {
preTaskId = task.getId();
ProcessInstanceMap map = findWorkProcessMapByParent(parentProcessInstance.getId(), preTaskId);
if (map != null) {
return map;
}
}
}
logger.info("sub process instance is not found,parent task:{},parent instance:{}",
parentTask.getId(), parentProcessInstance.getId());
return null;
}
/**
* create sub work process command
*
* @param parentProcessInstance parentProcessInstance
* @param task task
*/
public void createSubWorkProcess(ProcessInstance parentProcessInstance, TaskInstance task) {
if (!task.isSubProcess()) {
return;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | ProcessInstanceMap instanceMap = findWorkProcessMapByParent(parentProcessInstance.getId(), task.getId());
if (null != instanceMap && CommandType.RECOVER_TOLERANCE_FAULT_PROCESS == parentProcessInstance.getCommandType()) {
return;
}
instanceMap = setProcessInstanceMap(parentProcessInstance, task);
ProcessInstance childInstance = null;
if (instanceMap.getProcessInstanceId() != 0) {
childInstance = findProcessInstanceById(instanceMap.getProcessInstanceId());
}
Command subProcessCommand = createSubProcessCommand(parentProcessInstance, childInstance, instanceMap, task);
updateSubProcessDefinitionByParent(parentProcessInstance, subProcessCommand.getProcessDefinitionId());
initSubInstanceState(childInstance);
createCommand(subProcessCommand);
logger.info("sub process command created: {} ", subProcessCommand);
}
/**
* complement data needs transform parent parameter to child.
*/
private String getSubWorkFlowParam(ProcessInstanceMap instanceMap, ProcessInstance parentProcessInstance, Map<String, String> fatherParams) {
String processMapStr = JSONUtils.toJsonString(instanceMap);
Map<String, String> cmdParam = JSONUtils.toMap(processMapStr);
if (parentProcessInstance.isComplementData()) {
Map<String, String> parentParam = JSONUtils.toMap(parentProcessInstance.getCommandParam());
String endTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE);
String startTime = parentParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE);
cmdParam.put(CMDPARAM_COMPLEMENT_DATA_END_DATE, endTime);
cmdParam.put(CMDPARAM_COMPLEMENT_DATA_START_DATE, startTime);
processMapStr = JSONUtils.toJsonString(cmdParam); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
if (fatherParams.size() != 0) {
cmdParam.put(CMD_PARAM_FATHER_PARAMS, JSONUtils.toJsonString(fatherParams));
processMapStr = JSONUtils.toJsonString(cmdParam);
}
return processMapStr;
}
public Map<String, String> getGlobalParamMap(String globalParams) {
List<Property> propList;
Map<String, String> globalParamMap = new HashMap<>();
if (StringUtils.isNotEmpty(globalParams)) {
propList = JSONUtils.toList(globalParams, Property.class);
globalParamMap = propList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue));
}
return globalParamMap;
}
/**
* create sub work process command
*/
public Command createSubProcessCommand(ProcessInstance parentProcessInstance,
ProcessInstance childInstance,
ProcessInstanceMap instanceMap,
TaskInstance task) {
CommandType commandType = getSubCommandType(parentProcessInstance, childInstance);
TaskNode taskNode = JSONUtils.parseObject(task.getTaskJson(), TaskNode.class);
Map<String, Object> subProcessParam = JSONUtils.toMap(taskNode.getParams(), String.class, Object.class);
Integer childDefineId = Integer.parseInt(String.valueOf(subProcessParam.get(Constants.CMD_PARAM_SUB_PROCESS_DEFINE_ID)));
Object localParams = subProcessParam.get(Constants.LOCAL_PARAMS);
List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class);
Map<String, String> globalMap = this.getGlobalParamMap(parentProcessInstance.getGlobalParams()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | Map<String, String> fatherParams = new HashMap<>();
if (CollectionUtils.isNotEmpty(allParam)) {
for (Property info : allParam) {
fatherParams.put(info.getProp(), globalMap.get(info.getProp()));
}
}
String processParam = getSubWorkFlowParam(instanceMap, parentProcessInstance, fatherParams);
return new Command(
commandType,
TaskDependType.TASK_POST,
parentProcessInstance.getFailureStrategy(),
parentProcessInstance.getExecutorId(),
childDefineId,
processParam,
parentProcessInstance.getWarningType(),
parentProcessInstance.getWarningGroupId(),
parentProcessInstance.getScheduleTime(),
task.getWorkerGroup(),
parentProcessInstance.getProcessInstancePriority()
);
}
/**
* initialize sub work flow state
* child instance state would be initialized when 'recovery from pause/stop/failure'
*/
private void initSubInstanceState(ProcessInstance childInstance) {
if (childInstance != null) {
childInstance.setState(ExecutionStatus.RUNNING_EXECUTION);
updateProcessInstance(childInstance);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
/**
* get sub work flow command type
* child instance exist: child command = fatherCommand
* child instance not exists: child command = fatherCommand[0]
*/
private CommandType getSubCommandType(ProcessInstance parentProcessInstance, ProcessInstance childInstance) {
CommandType commandType = parentProcessInstance.getCommandType();
if (childInstance == null) {
String fatherHistoryCommand = parentProcessInstance.getHistoryCmd();
commandType = CommandType.valueOf(fatherHistoryCommand.split(Constants.COMMA)[0]);
}
return commandType;
}
/**
* update sub process definition
*
* @param parentProcessInstance parentProcessInstance
* @param childDefinitionId childDefinitionId
*/
private void updateSubProcessDefinitionByParent(ProcessInstance parentProcessInstance, int childDefinitionId) {
ProcessDefinition fatherDefinition = this.findProcessDefineById(parentProcessInstance.getProcessDefinitionId());
ProcessDefinition childDefinition = this.findProcessDefineById(childDefinitionId);
if (childDefinition != null && fatherDefinition != null) {
childDefinition.setWarningGroupId(fatherDefinition.getWarningGroupId());
processDefineMapper.updateById(childDefinition);
}
}
/**
* submit task to mysql |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | *
* @param taskInstance taskInstance
* @param processInstance processInstance
* @return task instance
*/
public TaskInstance submitTaskInstanceToDB(TaskInstance taskInstance, ProcessInstance processInstance) {
ExecutionStatus processInstanceState = processInstance.getState();
if (taskInstance.getState().typeIsFailure()) {
if (taskInstance.isSubProcess()) {
taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1);
} else {
if (processInstanceState != ExecutionStatus.READY_STOP
&& processInstanceState != ExecutionStatus.READY_PAUSE) {
taskInstance.setFlag(Flag.NO);
updateTaskInstance(taskInstance);
if (taskInstance.getState() != ExecutionStatus.NEED_FAULT_TOLERANCE) {
taskInstance.setRetryTimes(taskInstance.getRetryTimes() + 1);
}
taskInstance.setSubmitTime(null);
taskInstance.setStartTime(null);
taskInstance.setEndTime(null);
taskInstance.setFlag(Flag.YES);
taskInstance.setHost(null);
taskInstance.setId(0);
}
}
}
taskInstance.setExecutorId(processInstance.getExecutorId()); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | taskInstance.setProcessInstancePriority(processInstance.getProcessInstancePriority());
taskInstance.setState(getSubmitTaskState(taskInstance, processInstanceState));
if (taskInstance.getSubmitTime() == null) {
taskInstance.setSubmitTime(new Date());
}
if (taskInstance.getFirstSubmitTime() == null) {
taskInstance.setFirstSubmitTime(taskInstance.getSubmitTime());
}
boolean saveResult = saveTaskInstance(taskInstance);
if (!saveResult) {
return null;
}
return taskInstance;
}
/**
* get submit task instance state by the work process state
* cannot modify the task state when running/kill/submit success, or this
* task instance is already exists in task queue .
* return pause if work process state is ready pause
* return stop if work process state is ready stop
* if all of above are not satisfied, return submit success
*
* @param taskInstance taskInstance
* @param processInstanceState processInstanceState
* @return process instance state
*/
public ExecutionStatus getSubmitTaskState(TaskInstance taskInstance, ExecutionStatus processInstanceState) {
ExecutionStatus state = taskInstance.getState(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (
state == ExecutionStatus.RUNNING_EXECUTION
|| state == ExecutionStatus.DELAY_EXECUTION
|| state == ExecutionStatus.KILL
) {
return state;
}
if (processInstanceState == ExecutionStatus.READY_PAUSE) {
state = ExecutionStatus.PAUSE;
} else if (processInstanceState == ExecutionStatus.READY_STOP
|| !checkProcessStrategy(taskInstance)) {
state = ExecutionStatus.KILL;
} else {
state = ExecutionStatus.SUBMITTED_SUCCESS;
}
return state;
}
/**
* check process instance strategy
*
* @param taskInstance taskInstance
* @return check strategy result
*/
private boolean checkProcessStrategy(TaskInstance taskInstance) {
ProcessInstance processInstance = this.findProcessInstanceById(taskInstance.getProcessInstanceId());
FailureStrategy failureStrategy = processInstance.getFailureStrategy();
if (failureStrategy == FailureStrategy.CONTINUE) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return true;
}
List<TaskInstance> taskInstances = this.findValidTaskListByProcessId(taskInstance.getProcessInstanceId());
for (TaskInstance task : taskInstances) {
if (task.getState() == ExecutionStatus.FAILURE) {
return false;
}
}
return true;
}
/**
* create a new process instance
*
* @param processInstance processInstance
*/
public void createProcessInstance(ProcessInstance processInstance) {
if (processInstance != null) {
processInstanceMapper.insert(processInstance);
}
}
/**
* insert or update work process instance to data base
*
* @param processInstance processInstance
*/
public void saveProcessInstance(ProcessInstance processInstance) {
if (processInstance == null) {
logger.error("save error, process instance is null!");
return;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (processInstance.getId() != 0) {
processInstanceMapper.updateById(processInstance);
} else {
createProcessInstance(processInstance);
}
}
/**
* insert or update command
*
* @param command command
* @return save command result
*/
public int saveCommand(Command command) {
if (command.getId() != 0) {
return commandMapper.updateById(command);
} else {
return commandMapper.insert(command);
}
}
/**
* insert or update task instance
*
* @param taskInstance taskInstance
* @return save task instance result
*/
public boolean saveTaskInstance(TaskInstance taskInstance) {
if (taskInstance.getId() != 0) {
return updateTaskInstance(taskInstance);
} else {
return createTaskInstance(taskInstance); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
}
/**
* insert task instance
*
* @param taskInstance taskInstance
* @return create task instance result
*/
public boolean createTaskInstance(TaskInstance taskInstance) {
int count = taskInstanceMapper.insert(taskInstance);
return count > 0;
}
/**
* update task instance
*
* @param taskInstance taskInstance
* @return update task instance result
*/
public boolean updateTaskInstance(TaskInstance taskInstance) {
int count = taskInstanceMapper.updateById(taskInstance);
return count > 0;
}
/**
* delete a command by id
*
* @param id id
*/
public void delCommandById(int id) {
commandMapper.deleteById(id);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /**
* find task instance by id
*
* @param taskId task id
* @return task intance
*/
public TaskInstance findTaskInstanceById(Integer taskId) {
return taskInstanceMapper.selectById(taskId);
}
/**
* package task instance，associate processInstance and processDefine
*
* @param taskInstId taskInstId
* @return task instance
*/
public TaskInstance getTaskInstanceDetailByTaskId(int taskInstId) {
//
TaskInstance taskInstance = findTaskInstanceById(taskInstId);
if (taskInstance == null) {
return taskInstance;
}
//
ProcessInstance processInstance = findProcessInstanceDetailById(taskInstance.getProcessInstanceId());
//
ProcessDefinition processDefine = findProcessDefineById(taskInstance.getProcessDefinitionId());
taskInstance.setProcessInstance(processInstance);
taskInstance.setProcessDefine(processDefine);
return taskInstance;
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * get id list by task state
*
* @param instanceId instanceId
* @param state state
* @return task instance states
*/
public List<Integer> findTaskIdByInstanceState(int instanceId, ExecutionStatus state) {
return taskInstanceMapper.queryTaskByProcessIdAndState(instanceId, state.ordinal());
}
/**
* find valid task list by process definition id
*
* @param processInstanceId processInstanceId
* @return task instance list
*/
public List<TaskInstance> findValidTaskListByProcessId(Integer processInstanceId) {
return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.YES);
}
/**
* find previous task list by work process id
*
* @param processInstanceId processInstanceId
* @return task instance list
*/
public List<TaskInstance> findPreviousTaskListByWorkProcessId(Integer processInstanceId) {
return taskInstanceMapper.findValidTaskListByProcessId(processInstanceId, Flag.NO);
}
/**
* update work process instance map
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param processInstanceMap processInstanceMap
* @return update process instance result
*/
public int updateWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) {
return processInstanceMapMapper.updateById(processInstanceMap);
}
/**
* create work process instance map
*
* @param processInstanceMap processInstanceMap
* @return create process instance result
*/
public int createWorkProcessInstanceMap(ProcessInstanceMap processInstanceMap) {
int count = 0;
if (processInstanceMap != null) {
return processInstanceMapMapper.insert(processInstanceMap);
}
return count;
}
/**
* find work process map by parent process id and parent task id.
*
* @param parentWorkProcessId parentWorkProcessId
* @param parentTaskId parentTaskId
* @return process instance map
*/
public ProcessInstanceMap findWorkProcessMapByParent(Integer parentWorkProcessId, Integer parentTaskId) {
return processInstanceMapMapper.queryByParentId(parentWorkProcessId, parentTaskId);
}
/** |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * delete work process map by parent process id
*
* @param parentWorkProcessId parentWorkProcessId
* @return delete process map result
*/
public int deleteWorkProcessMapByParentId(int parentWorkProcessId) {
return processInstanceMapMapper.deleteByParentProcessId(parentWorkProcessId);
}
/**
* find sub process instance
*
* @param parentProcessId parentProcessId
* @param parentTaskId parentTaskId
* @return process instance
*/
public ProcessInstance findSubProcessInstance(Integer parentProcessId, Integer parentTaskId) {
ProcessInstance processInstance = null;
ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryByParentId(parentProcessId, parentTaskId);
if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) {
return processInstance;
}
processInstance = findProcessInstanceById(processInstanceMap.getProcessInstanceId());
return processInstance;
}
/**
* find parent process instance
*
* @param subProcessId subProcessId
* @return process instance
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public ProcessInstance findParentProcessInstance(Integer subProcessId) {
ProcessInstance processInstance = null;
ProcessInstanceMap processInstanceMap = processInstanceMapMapper.queryBySubProcessId(subProcessId);
if (processInstanceMap == null || processInstanceMap.getProcessInstanceId() == 0) {
return processInstance;
}
processInstance = findProcessInstanceById(processInstanceMap.getParentProcessInstanceId());
return processInstance;
}
/**
* change task state
*
* @param state state
* @param startTime startTime
* @param host host
* @param executePath executePath
* @param logPath logPath
* @param taskInstId taskInstId
*/
public void changeTaskState(TaskInstance taskInstance, ExecutionStatus state, Date startTime, String host,
String executePath,
String logPath,
int taskInstId) {
taskInstance.setState(state);
taskInstance.setStartTime(startTime);
taskInstance.setHost(host);
taskInstance.setExecutePath(executePath);
taskInstance.setLogPath(logPath);
saveTaskInstance(taskInstance);
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | /**
* update process instance
*
* @param processInstance processInstance
* @return update process instance result
*/
public int updateProcessInstance(ProcessInstance processInstance) {
return processInstanceMapper.updateById(processInstance);
}
/**
* update the process instance
*
* @param processInstanceId processInstanceId
* @param processJson processJson
* @param globalParams globalParams
* @param scheduleTime scheduleTime
* @param flag flag
* @param locations locations
* @param connects connects
* @return update process instance result
*/
public int updateProcessInstance(Integer processInstanceId, String processJson,
String globalParams, Date scheduleTime, Flag flag,
String locations, String connects) {
ProcessInstance processInstance = processInstanceMapper.queryDetailById(processInstanceId);
if (processInstance != null) {
processInstance.setProcessInstanceJson(processJson);
processInstance.setGlobalParams(globalParams);
processInstance.setScheduleTime(scheduleTime);
processInstance.setLocations(locations); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | processInstance.setConnects(connects);
return processInstanceMapper.updateById(processInstance);
}
return 0;
}
/**
* change task state
*
* @param state state
* @param endTime endTime
* @param taskInstId taskInstId
* @param varPool varPool
*/
public void changeTaskState(TaskInstance taskInstance, ExecutionStatus state,
Date endTime,
int processId,
String appIds,
int taskInstId,
String varPool,
String result) {
taskInstance.setPid(processId);
taskInstance.setAppLink(appIds);
taskInstance.setState(state);
taskInstance.setEndTime(endTime);
taskInstance.setVarPool(varPool);
changeOutParam(result, taskInstance);
saveTaskInstance(taskInstance);
}
public void changeOutParam(String result, TaskInstance taskInstance) {
if (StringUtils.isEmpty(result)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return;
}
List<Map<String, String>> workerResultParam = getListMapByString(result);
if (CollectionUtils.isEmpty(workerResultParam)) {
return;
}
//
Map<String, String> row = workerResultParam.get(0);
if (row == null || row.size() == 0) {
return;
}
TaskNode taskNode = JSONUtils.parseObject(taskInstance.getTaskJson(), TaskNode.class);
Map<String, Object> taskParams = JSONUtils.toMap(taskNode.getParams(), String.class, Object.class);
Object localParams = taskParams.get(LOCAL_PARAMS);
if (localParams == null) {
return;
}
ProcessInstance processInstance = this.processInstanceMapper.queryDetailById(taskInstance.getProcessInstanceId());
List<Property> params4Property = JSONUtils.toList(processInstance.getGlobalParams(), Property.class);
Map<String, Property> allParamMap = params4Property.stream().collect(Collectors.toMap(Property::getProp, Property -> Property));
List<Property> allParam = JSONUtils.toList(JSONUtils.toJsonString(localParams), Property.class);
for (Property info : allParam) {
if (info.getDirect() == Direct.OUT) {
String paramName = info.getProp();
Property property = allParamMap.get(paramName);
if (property == null) {
continue;
}
String value = String.valueOf(row.get(paramName));
if (StringUtils.isNotEmpty(value)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | property.setValue(value);
info.setValue(value);
}
}
}
taskParams.put(LOCAL_PARAMS, allParam);
taskNode.setParams(JSONUtils.toJsonString(taskParams));
//
taskInstance.setTaskJson(JSONUtils.toJsonString(taskNode));
String params4ProcessString = JSONUtils.toJsonString(params4Property);
int updateCount = this.processInstanceMapper.updateGlobalParamsById(params4ProcessString, processInstance.getId());
logger.info("updateCount:{}, params4Process:{}, processInstanceId:{}", updateCount, params4ProcessString, processInstance.getId());
}
public List<Map<String, String>> getListMapByString(String json) {
List<Map<String, String>> allParams = new ArrayList<>();
ArrayNode paramsByJson = JSONUtils.parseArray(json);
Iterator<JsonNode> listIterator = paramsByJson.iterator();
while (listIterator.hasNext()) {
Map<String, String> param = JSONUtils.toMap(listIterator.next().toString(), String.class, String.class);
allParams.add(param);
}
return allParams;
}
/**
* convert integer list to string list
*
* @param intList intList
* @return string list
*/
public List<String> convertIntListToString(List<Integer> intList) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (intList == null) {
return new ArrayList<>();
}
List<String> result = new ArrayList<>(intList.size());
for (Integer intVar : intList) {
result.add(String.valueOf(intVar));
}
return result;
}
/**
* query schedule by id
*
* @param id id
* @return schedule
*/
public Schedule querySchedule(int id) {
return scheduleMapper.selectById(id);
}
/**
* query Schedule by processDefinitionId
*
* @param processDefinitionId processDefinitionId
* @see Schedule
*/
public List<Schedule> queryReleaseSchedulerListByProcessDefinitionId(int processDefinitionId) {
return scheduleMapper.queryReleaseSchedulerListByProcessDefinitionId(processDefinitionId);
}
/**
* query need failover process instance
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | * @param host host
* @return process instance list
*/
public List<ProcessInstance> queryNeedFailoverProcessInstances(String host) {
return processInstanceMapper.queryByHostAndStatus(host, stateArray);
}
/**
* process need failover process instance
*
* @param processInstance processInstance
*/
@Transactional(rollbackFor = RuntimeException.class)
public void processNeedFailoverProcessInstances(ProcessInstance processInstance) {
//
processInstance.setHost(Constants.NULL);
processInstanceMapper.updateById(processInstance);
//
Command cmd = new Command();
cmd.setProcessDefinitionId(processInstance.getProcessDefinitionId());
cmd.setCommandParam(String.format("{\"%s\":%d}", Constants.CMD_PARAM_RECOVER_PROCESS_ID_STRING, processInstance.getId()));
cmd.setExecutorId(processInstance.getExecutorId());
cmd.setCommandType(CommandType.RECOVER_TOLERANCE_FAULT_PROCESS);
createCommand(cmd);
}
/**
* query all need failover task instances by host
*
* @param host host
* @return task instance list
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public List<TaskInstance> queryNeedFailoverTaskInstances(String host) {
return taskInstanceMapper.queryByHostAndStatus(host,
stateArray);
}
/**
* find data source by id
*
* @param id id
* @return datasource
*/
public DataSource findDataSourceById(int id) {
return dataSourceMapper.selectById(id);
}
/**
* update process instance state by id
*
* @param processInstanceId processInstanceId
* @param executionStatus executionStatus
* @return update process result
*/
public int updateProcessInstanceState(Integer processInstanceId, ExecutionStatus executionStatus) {
ProcessInstance instance = processInstanceMapper.selectById(processInstanceId);
instance.setState(executionStatus);
return processInstanceMapper.updateById(instance);
}
/**
* find process instance by the task id
*
* @param taskId taskId
* @return process instance |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | */
public ProcessInstance findProcessInstanceByTaskId(int taskId) {
TaskInstance taskInstance = taskInstanceMapper.selectById(taskId);
if (taskInstance != null) {
return processInstanceMapper.selectById(taskInstance.getProcessInstanceId());
}
return null;
}
/**
* find udf function list by id list string
*
* @param ids ids
* @return udf function list
*/
public List<UdfFunc> queryUdfFunListByIds(int[] ids) {
return udfFuncMapper.queryUdfByIdStr(ids, null);
}
/**
* find tenant code by resource name
*
* @param resName resource name
* @param resourceType resource type
* @return tenant code
*/
public String queryTenantCodeByResName(String resName, ResourceType resourceType) {
//
String fullName = resName.startsWith("/") ? resName : String.format("/%s", resName);
List<Resource> resourceList = resourceMapper.queryResource(fullName, resourceType.ordinal());
if (CollectionUtils.isEmpty(resourceList)) {
return StringUtils.EMPTY; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
int userId = resourceList.get(0).getUserId();
User user = userMapper.selectById(userId);
if (Objects.isNull(user)) {
return StringUtils.EMPTY;
}
Tenant tenant = tenantMapper.selectById(user.getTenantId());
if (Objects.isNull(tenant)) {
return StringUtils.EMPTY;
}
return tenant.getTenantCode();
}
/**
* find schedule list by process define id.
*
* @param ids ids
* @return schedule list
*/
public List<Schedule> selectAllByProcessDefineId(int[] ids) {
return scheduleMapper.selectAllByProcessDefineArray(
ids);
}
/**
* get dependency cycle by work process define id and scheduler fire time
*
* @param masterId masterId
* @param processDefinitionId processDefinitionId
* @param scheduledFireTime the time the task schedule is expected to trigger
* @return CycleDependency
* @throws Exception if error throws Exception |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | */
public CycleDependency getCycleDependency(int masterId, int processDefinitionId, Date scheduledFireTime) throws Exception {
List<CycleDependency> list = getCycleDependencies(masterId, new int[]{processDefinitionId}, scheduledFireTime);
return !list.isEmpty() ? list.get(0) : null;
}
/**
* get dependency cycle list by work process define id list and scheduler fire time
*
* @param masterId masterId
* @param ids ids
* @param scheduledFireTime the time the task schedule is expected to trigger
* @return CycleDependency list
* @throws Exception if error throws Exception
*/
public List<CycleDependency> getCycleDependencies(int masterId, int[] ids, Date scheduledFireTime) throws Exception {
List<CycleDependency> cycleDependencyList = new ArrayList<>();
if (null == ids || ids.length == 0) {
logger.warn("ids[] is empty!is invalid!");
return cycleDependencyList;
}
if (scheduledFireTime == null) {
logger.warn("scheduledFireTime is null!is invalid!");
return cycleDependencyList;
}
String strCrontab = "";
CronExpression depCronExpression;
Cron depCron;
List<Date> list;
List<Schedule> schedules = this.selectAllByProcessDefineId(ids);
// |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | for (Schedule depSchedule : schedules) {
strCrontab = depSchedule.getCrontab();
depCronExpression = CronUtils.parse2CronExpression(strCrontab);
depCron = CronUtils.parse2Cron(strCrontab);
CycleEnum cycleEnum = CronUtils.getMiniCycle(depCron);
if (cycleEnum == null) {
logger.error("{} is not valid", strCrontab);
continue;
}
Calendar calendar = Calendar.getInstance();
switch (cycleEnum) {
case HOUR:
calendar.add(Calendar.HOUR, -25);
break;
case DAY:
case WEEK:
calendar.add(Calendar.DATE, -32);
break;
case MONTH:
calendar.add(Calendar.MONTH, -13);
break;
default:
String cycleName = cycleEnum.name();
logger.warn("Dependent process definition's cycleEnum is {},not support!!", cycleName);
continue;
}
Date start = calendar.getTime();
if (depSchedule.getProcessDefinitionId() == masterId) {
list = CronUtils.getSelfFireDateList(start, scheduledFireTime, depCronExpression);
} else { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | list = CronUtils.getFireDateList(start, scheduledFireTime, depCronExpression);
}
if (!list.isEmpty()) {
start = list.get(list.size() - 1);
CycleDependency dependency = new CycleDependency(depSchedule.getProcessDefinitionId(), start, CronUtils.getExpirationTime(start, cycleEnum), cycleEnum);
cycleDependencyList.add(dependency);
}
}
return cycleDependencyList;
}
/**
* find last scheduler process instance in the date interval
*
* @param definitionId definitionId
* @param dateInterval dateInterval
* @return process instance
*/
public ProcessInstance findLastSchedulerProcessInterval(int definitionId, DateInterval dateInterval) {
return processInstanceMapper.queryLastSchedulerProcess(definitionId,
dateInterval.getStartTime(),
dateInterval.getEndTime());
}
/**
* find last manual process instance interval
*
* @param definitionId process definition id
* @param dateInterval dateInterval
* @return process instance
*/
public ProcessInstance findLastManualProcessInterval(int definitionId, DateInterval dateInterval) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return processInstanceMapper.queryLastManualProcess(definitionId,
dateInterval.getStartTime(),
dateInterval.getEndTime());
}
/**
* find last running process instance
*
* @param definitionId process definition id
* @param startTime start time
* @param endTime end time
* @return process instance
*/
public ProcessInstance findLastRunningProcess(int definitionId, Date startTime, Date endTime) {
return processInstanceMapper.queryLastRunningProcess(definitionId,
startTime,
endTime,
stateArray);
}
/**
* query user queue by process instance id
*
* @param processInstanceId processInstanceId
* @return queue
*/
public String queryUserQueueByProcessInstanceId(int processInstanceId) {
String queue = "";
ProcessInstance processInstance = processInstanceMapper.selectById(processInstanceId);
if (processInstance == null) {
return queue;
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | User executor = userMapper.selectById(processInstance.getExecutorId());
if (executor != null) {
queue = executor.getQueue();
}
return queue;
}
/**
* query project name and user name by processInstanceId.
*
* @param processInstanceId processInstanceId
* @return projectName and userName
*/
public ProjectUser queryProjectWithUserByProcessInstanceId(int processInstanceId) {
return projectMapper.queryProjectWithUserByProcessInstanceId(processInstanceId);
}
/**
* get task worker group
*
* @param taskInstance taskInstance
* @return workerGroupId
*/
public String getTaskWorkerGroup(TaskInstance taskInstance) {
String workerGroup = taskInstance.getWorkerGroup();
if (StringUtils.isNotBlank(workerGroup)) {
return workerGroup;
}
int processInstanceId = taskInstance.getProcessInstanceId();
ProcessInstance processInstance = findProcessInstanceById(processInstanceId);
if (processInstance != null) {
return processInstance.getWorkerGroup(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | }
logger.info("task : {} will use default worker group", taskInstance.getId());
return Constants.DEFAULT_WORKER_GROUP;
}
/**
* get have perm project list
*
* @param userId userId
* @return project list
*/
public List<Project> getProjectListHavePerm(int userId) {
List<Project> createProjects = projectMapper.queryProjectCreatedByUser(userId);
List<Project> authedProjects = projectMapper.queryAuthedProjectListByUserId(userId);
if (createProjects == null) {
createProjects = new ArrayList<>();
}
if (authedProjects != null) {
createProjects.addAll(authedProjects);
}
return createProjects;
}
/**
* get have perm project ids
*
* @param userId userId
* @return project ids
*/
public List<Integer> getProjectIdListHavePerm(int userId) {
List<Integer> projectIdList = new ArrayList<>();
for (Project project : getProjectListHavePerm(userId)) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | projectIdList.add(project.getId());
}
return projectIdList;
}
/**
* list unauthorized udf function
*
* @param userId user id
* @param needChecks data source id array
* @return unauthorized udf function list
*/
public <T> List<T> listUnauthorized(int userId, T[] needChecks, AuthorizationType authorizationType) {
List<T> resultList = new ArrayList<>();
if (Objects.nonNull(needChecks) && needChecks.length > 0) {
Set<T> originResSet = new HashSet<>(Arrays.asList(needChecks));
switch (authorizationType) {
case RESOURCE_FILE_ID:
case UDF_FILE:
List<Resource> ownUdfResources = resourceMapper.listAuthorizedResourceById(userId, needChecks);
addAuthorizedResources(ownUdfResources, userId);
Set<Integer> authorizedResourceFiles = ownUdfResources.stream().map(Resource::getId).collect(toSet());
originResSet.removeAll(authorizedResourceFiles);
break;
case RESOURCE_FILE_NAME:
List<Resource> ownResources = resourceMapper.listAuthorizedResource(userId, needChecks);
addAuthorizedResources(ownResources, userId);
Set<String> authorizedResources = ownResources.stream().map(Resource::getFullName).collect(toSet());
originResSet.removeAll(authorizedResources);
break;
case DATASOURCE: |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | Set<Integer> authorizedDatasources = dataSourceMapper.listAuthorizedDataSource(userId, needChecks).stream().map(DataSource::getId).collect(toSet());
originResSet.removeAll(authorizedDatasources);
break;
case UDF:
Set<Integer> authorizedUdfs = udfFuncMapper.listAuthorizedUdfFunc(userId, needChecks).stream().map(UdfFunc::getId).collect(toSet());
originResSet.removeAll(authorizedUdfs);
break;
default:
break;
}
resultList.addAll(originResSet);
}
return resultList;
}
/**
* get user by user id
*
* @param userId user id
* @return User
*/
public User getUserById(int userId) {
return userMapper.selectById(userId);
}
/**
* get resource by resoruce id
*
* @param resoruceId resource id
* @return Resource
*/
public Resource getResourceById(int resoruceId) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | return resourceMapper.selectById(resoruceId);
}
/**
* list resources by ids
*
* @param resIds resIds
* @return resource list
*/
public List<Resource> listResourceByIds(Integer[] resIds) {
return resourceMapper.listResourceByIds(resIds);
}
/**
* format task app id in task instance
*/
public String formatTaskAppId(TaskInstance taskInstance) {
ProcessDefinition definition = this.findProcessDefineById(taskInstance.getProcessDefinitionId());
ProcessInstance processInstanceById = this.findProcessInstanceById(taskInstance.getProcessInstanceId());
if (definition == null || processInstanceById == null) {
return "";
}
return String.format("%s_%s_%s",
definition.getId(),
processInstanceById.getId(),
taskInstance.getId());
}
/**
* solve the branch rename bug
*
* @return String
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | public String changeJson(ProcessData processData, String oldJson) {
ProcessData oldProcessData = JSONUtils.parseObject(oldJson, ProcessData.class);
HashMap<String, String> oldNameTaskId = new HashMap<>();
List<TaskNode> oldTasks = oldProcessData.getTasks();
for (int i = 0; i < oldTasks.size(); i++) {
TaskNode taskNode = oldTasks.get(i);
String oldName = taskNode.getName();
String oldId = taskNode.getId();
oldNameTaskId.put(oldName, oldId);
}
//
HashMap<String, String> newNameTaskId = new HashMap<>();
List<TaskNode> newTasks = processData.getTasks();
for (int i = 0; i < newTasks.size(); i++) {
TaskNode taskNode = newTasks.get(i);
String newId = taskNode.getId();
String newName = taskNode.getName();
newNameTaskId.put(newId, newName);
}
//
List<TaskNode> tasks = processData.getTasks();
for (int i = 0; i < tasks.size(); i++) {
TaskNode taskNode = newTasks.get(i);
String type = taskNode.getType();
if (TaskType.CONDITIONS.getDescp().equalsIgnoreCase(type)) {
ConditionsParameters conditionsParameters = JSONUtils.parseObject(taskNode.getConditionResult(), ConditionsParameters.class);
String oldSuccessNodeName = conditionsParameters.getSuccessNode().get(0);
String oldFailedNodeName = conditionsParameters.getFailedNode().get(0);
String newSuccessNodeName = newNameTaskId.get(oldNameTaskId.get(oldSuccessNodeName));
String newFailedNodeName = newNameTaskId.get(oldNameTaskId.get(oldFailedNodeName)); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,328 | [Bug][MasterServer] process contain depend task is always running | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
A clear and concise description of what the bug is.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Will the process scheduling up regularly, and must be "failed policies" to "end"
2. The first mission there is no corresponding directory file (for the first time this failure) (namely the execution of the catalog file to a certain consensus ikkkk and fb both task execution of the same file)
3. Then retry the second time, in the corresponding directory to create executable files, so that it was successful
4. Observe the state of the process
| https://github.com/apache/dolphinscheduler/issues/5328 | https://github.com/apache/dolphinscheduler/pull/5344 | 5f1fc462c9ba321736f9fe9a1bfc057d1da894d0 | e12a26289bce0b38bd65ac74a3349ecadd8a9141 | "2021-04-20T06:07:08Z" | java | "2021-04-21T14:29:53Z" | dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java | if (newSuccessNodeName != null) {
ArrayList<String> successNode = new ArrayList<>();
successNode.add(newSuccessNodeName);
conditionsParameters.setSuccessNode(successNode);
}
if (newFailedNodeName != null) {
ArrayList<String> failedNode = new ArrayList<>();
failedNode.add(newFailedNodeName);
conditionsParameters.setFailedNode(failedNode);
}
String conditionResultStr = conditionsParameters.getConditionResult();
taskNode.setConditionResult(conditionResultStr);
tasks.set(i, taskNode);
}
}
return JSONUtils.toJsonString(processData);
}
/**
* add authorized resources
*
* @param ownResources own resources
* @param userId userId
*/
private void addAuthorizedResources(List<Resource> ownResources, int userId) {
List<Integer> relationResourceIds = resourceUserMapper.queryResourcesIdListByUserIdAndPerm(userId, 7);
List<Resource> relationResources = CollectionUtils.isNotEmpty(relationResourceIds) ? resourceMapper.queryResourceListById(relationResourceIds) : new ArrayList<>();
ownResources.addAll(relationResources);
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.task.sql;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.enums.CommandType;
import org.apache.dolphinscheduler.common.enums.DbType;
import org.apache.dolphinscheduler.common.enums.Direct;
import org.apache.dolphinscheduler.common.enums.TaskTimeoutStrategy; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | import org.apache.dolphinscheduler.common.process.Property;
import org.apache.dolphinscheduler.common.task.AbstractParameters;
import org.apache.dolphinscheduler.common.task.sql.SqlBinds;
import org.apache.dolphinscheduler.common.task.sql.SqlParameters;
import org.apache.dolphinscheduler.common.task.sql.SqlType;
import org.apache.dolphinscheduler.common.utils.CollectionUtils;
import org.apache.dolphinscheduler.common.utils.JSONUtils;
import org.apache.dolphinscheduler.common.utils.ParameterUtils;
import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.apache.dolphinscheduler.dao.AlertDao;
import org.apache.dolphinscheduler.dao.datasource.BaseDataSource;
import org.apache.dolphinscheduler.dao.datasource.DataSourceFactory;
import org.apache.dolphinscheduler.remote.command.alert.AlertSendResponseCommand;
import org.apache.dolphinscheduler.server.entity.SQLTaskExecutionContext;
import org.apache.dolphinscheduler.server.entity.TaskExecutionContext;
import org.apache.dolphinscheduler.server.utils.ParamUtils;
import org.apache.dolphinscheduler.server.utils.UDFUtils;
import org.apache.dolphinscheduler.server.worker.task.AbstractTask;
import org.apache.dolphinscheduler.service.alert.AlertClientService;
import org.apache.dolphinscheduler.service.bean.SpringApplicationContext;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.ResultSetMetaData;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | import java.util.Optional;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import org.slf4j.Logger;
import com.fasterxml.jackson.databind.node.ArrayNode;
import com.fasterxml.jackson.databind.node.ObjectNode;
/**
* sql task
*/
public class SqlTask extends AbstractTask {
/**
* sql parameters
*/
private SqlParameters sqlParameters;
/**
* alert dao
*/
private AlertDao alertDao;
/**
* base datasource
*/
private BaseDataSource baseDataSource;
/**
* taskExecutionContext
*/
private TaskExecutionContext taskExecutionContext;
/**
* default query sql limit
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | private static final int LIMIT = 10000;
private AlertClientService alertClientService;
public SqlTask(TaskExecutionContext taskExecutionContext, Logger logger, AlertClientService alertClientService) {
super(taskExecutionContext, logger);
this.taskExecutionContext = taskExecutionContext;
logger.info("sql task params {}", taskExecutionContext.getTaskParams());
this.sqlParameters = JSONUtils.parseObject(taskExecutionContext.getTaskParams(), SqlParameters.class);
if (!sqlParameters.checkParameters()) {
throw new RuntimeException("sql task params is not valid");
}
this.alertClientService = alertClientService;
this.alertDao = SpringApplicationContext.getBean(AlertDao.class);
}
@Override
public void handle() throws Exception {
String threadLoggerInfoName = String.format(Constants.TASK_LOG_INFO_FORMAT, taskExecutionContext.getTaskAppId());
Thread.currentThread().setName(threadLoggerInfoName);
logger.info("Full sql parameters: {}", sqlParameters);
logger.info("sql type : {}, datasource : {}, sql : {} , localParams : {},udfs : {},showType : {},connParams : {}",
sqlParameters.getType(),
sqlParameters.getDatasource(),
sqlParameters.getSql(),
sqlParameters.getLocalParams(),
sqlParameters.getUdfs(),
sqlParameters.getShowType(),
sqlParameters.getConnParams());
try {
SQLTaskExecutionContext sqlTaskExecutionContext = taskExecutionContext.getSqlTaskExecutionContext(); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | baseDataSource = DataSourceFactory.getDatasource(DbType.valueOf(sqlParameters.getType()),
sqlTaskExecutionContext.getConnectionParams());
SqlBinds mainSqlBinds = getSqlAndSqlParamsMap(sqlParameters.getSql());
List<SqlBinds> preStatementSqlBinds = Optional.ofNullable(sqlParameters.getPreStatements())
.orElse(new ArrayList<>())
.stream()
.map(this::getSqlAndSqlParamsMap)
.collect(Collectors.toList());
List<SqlBinds> postStatementSqlBinds = Optional.ofNullable(sqlParameters.getPostStatements())
.orElse(new ArrayList<>())
.stream()
.map(this::getSqlAndSqlParamsMap)
.collect(Collectors.toList());
List<String> createFuncs = UDFUtils.createFuncs(sqlTaskExecutionContext.getUdfFuncTenantCodeMap(),
logger);
executeFuncAndSql(mainSqlBinds, preStatementSqlBinds, postStatementSqlBinds, createFuncs);
setExitStatusCode(Constants.EXIT_CODE_SUCCESS);
} catch (Exception e) {
setExitStatusCode(Constants.EXIT_CODE_FAILURE);
logger.error("sql task error: {}", e.toString());
throw e;
}
}
/**
* ready to execute SQL and parameter entity Map
*
* @return SqlBinds
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | private SqlBinds getSqlAndSqlParamsMap(String sql) {
Map<Integer, Property> sqlParamsMap = new HashMap<>();
StringBuilder sqlBuilder = new StringBuilder();
Map<String, Property> paramsMap = ParamUtils.convert(ParamUtils.getUserDefParamsMap(taskExecutionContext.getDefinedParams()),
taskExecutionContext.getDefinedParams(),
sqlParameters.getLocalParametersMap(),
CommandType.of(taskExecutionContext.getCmdTypeIfComplement()),
taskExecutionContext.getScheduleTime());
if (paramsMap == null) {
sqlBuilder.append(sql);
return new SqlBinds(sqlBuilder.toString(), sqlParamsMap);
}
if (StringUtils.isNotEmpty(sqlParameters.getTitle())) {
String title = ParameterUtils.convertParameterPlaceholders(sqlParameters.getTitle(),
ParamUtils.convert(paramsMap));
logger.info("SQL title : {}", title);
sqlParameters.setTitle(title);
}
sql = ParameterUtils.replaceScheduleTime(sql, taskExecutionContext.getScheduleTime());
String rgex = "['\"]*\\$\\{(.*?)\\}['\"]*";
setSqlParamsMap(sql, rgex, sqlParamsMap, paramsMap);
String rgexo = "['\"]*\\!\\{(.*?)\\}['\"]*";
sql = replaceOriginalValue(sql, rgexo, paramsMap);
// r |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | String formatSql = sql.replaceAll(rgex, "?");
sqlBuilder.append(formatSql);
// p
printReplacedSql(sql, formatSql, rgex, sqlParamsMap);
return new SqlBinds(sqlBuilder.toString(), sqlParamsMap);
}
public String replaceOriginalValue(String content, String rgex, Map<String, Property> sqlParamsMap) {
Pattern pattern = Pattern.compile(rgex);
while (true) {
Matcher m = pattern.matcher(content);
if (!m.find()) {
break;
}
String paramName = m.group(1);
String paramValue = sqlParamsMap.get(paramName).getValue();
content = m.replaceFirst(paramValue);
}
return content;
}
@Override
public AbstractParameters getParameters() {
return this.sqlParameters;
}
/**
* execute function and sql
*
* @param mainSqlBinds main sql binds
* @param preStatementsBinds pre statements binds
* @param postStatementsBinds post statements binds
* @param createFuncs create functions |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | */
public void executeFuncAndSql(SqlBinds mainSqlBinds,
List<SqlBinds> preStatementsBinds,
List<SqlBinds> postStatementsBinds,
List<String> createFuncs) throws Exception {
Connection connection = null;
PreparedStatement stmt = null;
ResultSet resultSet = null;
try {
baseDataSource.setConnParams(sqlParameters.getConnParams());
// c
connection = baseDataSource.getConnection();
// c
if (CollectionUtils.isNotEmpty(createFuncs)) {
createTempFunction(connection, createFuncs);
}
// p
preSql(connection, preStatementsBinds);
stmt = prepareStatementAndBind(connection, mainSqlBinds);
String result = null;
// d
if (sqlParameters.getSqlType() == SqlType.QUERY.ordinal()) {
// q
resultSet = stmt.executeQuery();
result = resultProcess(resultSet);
} else if (sqlParameters.getSqlType() == SqlType.NON_QUERY.ordinal()) {
// n
String updateResult = String.valueOf(stmt.executeUpdate());
result = setNonQuerySqlReturn(updateResult, sqlParameters.getLocalParams());
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | postSql(connection, postStatementsBinds);
this.setResultString(result);
} catch (Exception e) {
logger.error("execute sql error: {}", e.getMessage());
throw e;
} finally {
close(resultSet, stmt, connection);
}
}
public String setNonQuerySqlReturn(String updateResult, List<Property> properties) {
String result = null;
for (Property info :properties) {
if (Direct.OUT == info.getDirect()) {
List<Map<String,String>> updateRL = new ArrayList<>();
Map<String,String> updateRM = new HashMap<>();
updateRM.put(info.getProp(),updateResult);
updateRL.add(updateRM);
result = JSONUtils.toJsonString(updateRL);
break;
}
}
return result;
}
/**
* result process
*
* @param resultSet resultSet
* @throws Exception Exception
*/
private String resultProcess(ResultSet resultSet) throws Exception { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | ArrayNode resultJSONArray = JSONUtils.createArrayNode();
ResultSetMetaData md = resultSet.getMetaData();
int num = md.getColumnCount();
int rowCount = 0;
while (rowCount < LIMIT && resultSet.next()) {
ObjectNode mapOfColValues = JSONUtils.createObjectNode();
for (int i = 1; i <= num; i++) {
mapOfColValues.set(md.getColumnLabel(i), JSONUtils.toJsonNode(resultSet.getObject(i)));
}
resultJSONArray.add(mapOfColValues);
rowCount++;
}
String result = JSONUtils.toJsonString(resultJSONArray);
logger.debug("execute sql result : {}", result);
int displayRows = sqlParameters.getDisplayRows() > 0 ? sqlParameters.getDisplayRows() : Constants.DEFAULT_DISPLAY_ROWS;
displayRows = Math.min(displayRows, resultJSONArray.size());
logger.info("display sql result {} rows as follows:", displayRows);
for (int i = 0; i < displayRows; i++) {
String row = JSONUtils.toJsonString(resultJSONArray.get(i));
logger.info("row {} : {}", i + 1, row);
}
if (sqlParameters.getSendEmail() == null || sqlParameters.getSendEmail()) {
sendAttachment(sqlParameters.getGroupId(), StringUtils.isNotEmpty(sqlParameters.getTitle()) ? sqlParameters.getTitle() : taskExecutionContext.getTaskName() + " query result sets",
JSONUtils.toJsonString(resultJSONArray));
}
return result;
}
/**
* p
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | * @param connection connection
* @param preStatementsBinds preStatementsBinds
*/
private void preSql(Connection connection,
List<SqlBinds> preStatementsBinds) throws Exception {
for (SqlBinds sqlBind : preStatementsBinds) {
try (PreparedStatement pstmt = prepareStatementAndBind(connection, sqlBind)) {
int result = pstmt.executeUpdate();
logger.info("pre statement execute result: {}, for sql: {}", result, sqlBind.getSql());
}
}
}
/**
* post sql
*
* @param connection connection
* @param postStatementsBinds postStatementsBinds
*/
private void postSql(Connection connection,
List<SqlBinds> postStatementsBinds) throws Exception {
for (SqlBinds sqlBind : postStatementsBinds) {
try (PreparedStatement pstmt = prepareStatementAndBind(connection, sqlBind)) {
int result = pstmt.executeUpdate();
logger.info("post statement execute result: {},for sql: {}", result, sqlBind.getSql());
}
}
}
/**
* c
* |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | * @param connection connection
* @param createFuncs createFuncs
*/
private void createTempFunction(Connection connection,
List<String> createFuncs) throws Exception {
try (Statement funcStmt = connection.createStatement()) {
for (String createFunc : createFuncs) {
logger.info("hive create function sql: {}", createFunc);
funcStmt.execute(createFunc);
}
}
}
/**
* close jdbc resource
*
* @param resultSet resultSet
* @param pstmt pstmt
* @param connection connection
*/
private void close(ResultSet resultSet,
PreparedStatement pstmt,
Connection connection) {
if (resultSet != null) {
try {
resultSet.close();
} catch (SQLException e) {
logger.error("close result set error : {}", e.getMessage(), e);
}
}
if (pstmt != null) { |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | try {
pstmt.close();
} catch (SQLException e) {
logger.error("close prepared statement error : {}", e.getMessage(), e);
}
}
if (connection != null) {
try {
connection.close();
} catch (SQLException e) {
logger.error("close connection error : {}", e.getMessage(), e);
}
}
}
/**
* preparedStatement bind
*
* @param connection connection
* @param sqlBinds sqlBinds
* @return PreparedStatement
* @throws Exception Exception
*/
private PreparedStatement prepareStatementAndBind(Connection connection, SqlBinds sqlBinds) throws Exception {
// i
boolean timeoutFlag = TaskTimeoutStrategy.of(taskExecutionContext.getTaskTimeoutStrategy()) == TaskTimeoutStrategy.FAILED
|| TaskTimeoutStrategy.of(taskExecutionContext.getTaskTimeoutStrategy()) == TaskTimeoutStrategy.WARNFAILED;
PreparedStatement stmt = connection.prepareStatement(sqlBinds.getSql());
if (timeoutFlag) {
stmt.setQueryTimeout(taskExecutionContext.getTaskTimeout());
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | Map<Integer, Property> params = sqlBinds.getParamsMap();
if (params != null) {
for (Map.Entry<Integer, Property> entry : params.entrySet()) {
Property prop = entry.getValue();
ParameterUtils.setInParameter(entry.getKey(), stmt, prop.getType(), prop.getValue());
}
}
logger.info("prepare statement replace sql : {} ", stmt);
return stmt;
}
/**
* send mail as an attachment
*
* @param title title
* @param content content
*/
public void sendAttachment(int groupId, String title, String content) {
AlertSendResponseCommand alertSendResponseCommand = alertClientService.sendAlert(groupId, title, content);
if (!alertSendResponseCommand.getResStatus()) {
throw new RuntimeException("send mail failed!");
}
}
/**
* regular expressions match the contents between two specified strings
*
* @param content content
* @param rgex rgex
* @param sqlParamsMap sql params map
* @param paramsPropsMap params props map
*/ |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java | public void setSqlParamsMap(String content, String rgex, Map<Integer, Property> sqlParamsMap, Map<String, Property> paramsPropsMap) {
Pattern pattern = Pattern.compile(rgex);
Matcher m = pattern.matcher(content);
int index = 1;
while (m.find()) {
String paramName = m.group(1);
Property prop = paramsPropsMap.get(paramName);
sqlParamsMap.put(index, prop);
index++;
}
}
/**
* print replace sql
*
* @param content content
* @param formatSql format sql
* @param rgex rgex
* @param sqlParamsMap sql params map
*/
public void printReplacedSql(String content, String formatSql, String rgex, Map<Integer, Property> sqlParamsMap) {
//pa
logger.info("after replace sql , preparing : {}", formatSql);
StringBuilder logPrint = new StringBuilder("replaced sql , parameters:");
for (int i = 1; i <= sqlParamsMap.size(); i++) {
logPrint.append(sqlParamsMap.get(i).getValue() + "(" + sqlParamsMap.get(i).getType() + ")");
}
logger.info("Sql Params are {}", logPrint);
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTaskTest.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTaskTest.java | * See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.server.worker.task.sql;
import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.ParameterUtils;
import org.apache.dolphinscheduler.dao.AlertDao;
import org.apache.dolphinscheduler.server.entity.SQLTaskExecutionContext;
import org.apache.dolphinscheduler.server.entity.TaskExecutionContext;
import org.apache.dolphinscheduler.server.worker.task.TaskProps;
import org.apache.dolphinscheduler.service.alert.AlertClientService;
import org.apache.dolphinscheduler.service.bean.SpringApplicationContext;
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.util.Date;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mockito;
import org.powermock.api.mockito.PowerMockito;
import org.powermock.core.classloader.annotations.PrepareForTest;
import org.powermock.modules.junit4.PowerMockRunner;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* sql task test
*/
@RunWith(PowerMockRunner.class) |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTaskTest.java | @PrepareForTest(value = {SqlTask.class, DriverManager.class, SpringApplicationContext.class, ParameterUtils.class})
public class SqlTaskTest {
private static final Logger logger = LoggerFactory.getLogger(SqlTaskTest.class);
private static final String CONNECTION_PARAMS = "{\"user\":\"root\",\"password\":\"123456\",\"address\":\"jdbc:mysql://127.0.0.1:3306\","
+ "\"database\":\"test\",\"jdbcUrl\":\"jdbc:mysql://127.0.0.1:3306/test\"}";
private SqlTask sqlTask;
private TaskExecutionContext taskExecutionContext;
private AlertClientService alertClientService;
@Before
public void before() throws Exception {
taskExecutionContext = new TaskExecutionContext();
TaskProps props = new TaskProps();
props.setExecutePath("/tmp");
props.setTaskAppId(String.valueOf(System.currentTimeMillis()));
props.setTaskInstanceId(1);
props.setTenantCode("1");
props.setEnvFile(".dolphinscheduler_env.sh");
props.setTaskStartTime(new Date());
props.setTaskTimeout(0);
props.setTaskParams(
"{\"localParams\":[{\"prop\":\"ret\", \"direct\":\"OUT\", \"type\":\"VARCHAR\", \"value\":\"\"}],"
+ "\"type\":\"POSTGRESQL\",\"datasource\":1,\"sql\":\"insert into tb_1 values('1','2')\","
+ "\"sqlType\":1}");
taskExecutionContext = PowerMockito.mock(TaskExecutionContext.class);
PowerMockito.when(taskExecutionContext.getTaskParams()).thenReturn(props.getTaskParams());
PowerMockito.when(taskExecutionContext.getExecutePath()).thenReturn("/tmp");
PowerMockito.when(taskExecutionContext.getTaskAppId()).thenReturn("1");
PowerMockito.when(taskExecutionContext.getTenantCode()).thenReturn("root"); |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,322 | [Bug][worker] Insert into clickhouse table successfully but process status turn to failed and log exception | **For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append the description in Chinese(just for Mandarin(CN)), thx! **
**Describe the bug**
DATASORUCE: clickhouse
My process only has one SQL like:
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
The process failed but the data has been successfully inserted into the table.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a new process with only one SQL
`INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt`
2. Save and run it.
3. See error below
[INFO] 2021-04-19 17:49:57.364 - [taskAppId=TASK-2-9-10]:[115] - create dir success /tmp/dolphinscheduler/exec/process/1/2/9/10
[INFO] 2021-04-19 17:49:57.367 - [taskAppId=TASK-2-9-10]:[88] - sql task params {"postStatements":[],"connParams":"","receiversCc":"","udfs":"","type":"CLICKHOUSE","title":"test","sql":"INSERT INTO test\nSELECT dt, count(1) as c\n FROM dau\n GROUP BY dt\n ORDER BY dt\n","preStatements":[],"sqlType":"0","receivers":"[email protected]","datasource":1,"showType":"TABLE","localParams":[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[104] - Full sql parameters: SqlParameters{type='CLICKHOUSE', datasource=1, sql='INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
', sqlType=0, udfs='', showType='TABLE', connParams='', title='test', receivers='[email protected]', receiversCc='', preStatements=[], postStatements=[]}
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[105] - sql type : CLICKHOUSE, datasource : 1, sql : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
, localParams : [],udfs : ,showType : TABLE,connParams :
[INFO] 2021-04-19 17:49:57.369 - [taskAppId=TASK-2-9-10]:[176] - SQL title : test
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[498] - after replace sql , preparing : INSERT INTO test
SELECT dt, count(1) as c
FROM dau
GROUP BY dt
ORDER BY dt
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[503] - Sql Params are replaced sql , parameters:
[INFO] 2021-04-19 17:49:57.370 - [taskAppId=TASK-2-9-10]:[52] - can't find udf function resource
[INFO] 2021-04-19 17:49:57.381 - [taskAppId=TASK-2-9-10]:[414] - prepare statement replace sql : ru.yandex.clickhouse.ClickHousePreparedStatementImpl@65fc3a50
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[243] - execute sql error
java.lang.NullPointerException: null
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.resultProcess(SqlTask.java:258)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:233)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
[ERROR] 2021-04-19 17:49:57.388 - [taskAppId=TASK-2-9-10]:[145] - sql task error
java.lang.RuntimeException: execute sql error
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.executeFuncAndSql(SqlTask.java:244)
at org.apache.dolphinscheduler.server.worker.task.sql.SqlTask.handle(SqlTask.java:139)
at org.apache.dolphinscheduler.server.worker.runner.TaskExecuteThread.run(TaskExecuteThread.java:133)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
**Expected behavior**
A clear and concise description of what you expected to happen.
Data inserted into the table and process status should be successful.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-1.3.5
**Additional context**
Add any other context about the problem here.
No matter deployed by docker or k8s, both met this problem.
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/5322 | https://github.com/apache/dolphinscheduler/pull/5324 | e57ee658e842ab8c5cd111f35cd6c71ed7065ecd | abdd2337b144df149a2031c3b26862ae41b4e936 | "2021-04-19T10:13:44Z" | java | "2021-04-22T04:02:32Z" | dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTaskTest.java | PowerMockito.when(taskExecutionContext.getStartTime()).thenReturn(new Date());
PowerMockito.when(taskExecutionContext.getTaskTimeout()).thenReturn(10000);
PowerMockito.when(taskExecutionContext.getLogPath()).thenReturn("/tmp/dx");
SQLTaskExecutionContext sqlTaskExecutionContext = new SQLTaskExecutionContext();
sqlTaskExecutionContext.setConnectionParams(CONNECTION_PARAMS);
PowerMockito.when(taskExecutionContext.getSqlTaskExecutionContext()).thenReturn(sqlTaskExecutionContext);
PowerMockito.mockStatic(SpringApplicationContext.class);
PowerMockito.when(SpringApplicationContext.getBean(Mockito.any())).thenReturn(new AlertDao());
alertClientService = PowerMockito.mock(AlertClientService.class);
sqlTask = new SqlTask(taskExecutionContext, logger, alertClientService);
sqlTask.init();
}
@Test
public void testGetParameters() {
Assert.assertNotNull(sqlTask.getParameters());
}
@Test
public void testHandle() throws Exception {
Connection connection = PowerMockito.mock(Connection.class);
PowerMockito.mockStatic(DriverManager.class);
PowerMockito.when(DriverManager.getConnection(Mockito.any(), Mockito.any(), Mockito.any())).thenReturn(connection);
PreparedStatement preparedStatement = PowerMockito.mock(PreparedStatement.class);
PowerMockito.when(connection.prepareStatement(Mockito.any())).thenReturn(preparedStatement);
PowerMockito.mockStatic(ParameterUtils.class);
PowerMockito.when(ParameterUtils.replaceScheduleTime(Mockito.any(), Mockito.any())).thenReturn("insert into tb_1 values('1','2')");
sqlTask.handle();
Assert.assertEquals(Constants.EXIT_CODE_SUCCESS,sqlTask.getExitStatusCode());
}
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,349 | [Bug][master] Manually kill the task that fails to be retried. After the parallel task succeeds, the workflow status is always running | 1. The configuration of task 2 fails to be retried. When the failure is retried for the second time, manually kill the process ID of task 2
2. After task 3 is successfully executed, a task will be added to the master, resulting in the workflow status running all the time
**Which version of Dolphin Scheduler:**
-[1.3.6-prepare]
| https://github.com/apache/dolphinscheduler/issues/5349 | https://github.com/apache/dolphinscheduler/pull/5362 | 3a7006a79649df4f45397f125c2e9665f9659c0b | 75d1ad645c994feadf157fb2343141b3d9ec49bf | "2021-04-22T03:56:30Z" | java | "2021-04-23T06:29:26Z" | dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/DependResult.java | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dolphinscheduler.common.enums;
/**
* depend result
*/
public enum DependResult {
/**
* 0 success
* 1 waiting
* 2 failed
*/
SUCCESS, WAITING, FAILED
} |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,349 | [Bug][master] Manually kill the task that fails to be retried. After the parallel task succeeds, the workflow status is always running | 1. The configuration of task 2 fails to be retried. When the failure is retried for the second time, manually kill the process ID of task 2
2. After task 3 is successfully executed, a task will be added to the master, resulting in the workflow status running all the time
**Which version of Dolphin Scheduler:**
-[1.3.6-prepare]
| https://github.com/apache/dolphinscheduler/issues/5349 | https://github.com/apache/dolphinscheduler/pull/5362 | 3a7006a79649df4f45397f125c2e9665f9659c0b | 75d1ad645c994feadf157fb2343141b3d9ec49bf | "2021-04-22T03:56:30Z" | java | "2021-04-23T06:29:26Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java | /*
* Licnsd o h Apach Sofwar Foundaion (ASF) undr on or mor
* conribuor licns agrmns. S h NOTICE fil disribud wih
* his work for addiional informaion rgarding copyrigh ownrship.
* Th ASF licnss his fil o You undr h Apach Licns, Vrsion 2.0
* (h "Licns"); you may no us his fil xcp in complianc wih
* h Licns. You may obain a copy of h Licns a
*
* hp://www.apach.org/licnss/LICENSE-2.0
*
* Unlss rquird by applicabl law or agrd o in wriing, sofwar
* disribud undr h Licns is disribud on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, ihr xprss or implid.
* S h Licns for h spcic languag govrning prmissions and
* limiaions undr h Licns.
*/
packag org.apach.dolphinschdulr.srvr.masr.runnr;
impor saic org.apach.dolphinschdulr.common.Consans.CMDPARAM_COMPLEMENT_DATA_END_DATE;
impor saic org.apach.dolphinschdulr.common.Consans.CMDPARAM_COMPLEMENT_DATA_START_DATE;
impor saic org.apach.dolphinschdulr.common.Consans.CMD_PARAM_RECOVERY_START_NODE_STRING;
impor saic org.apach.dolphinschdulr.common.Consans.CMD_PARAM_START_NODE_NAMES;
impor saic org.apach.dolphinschdulr.common.Consans.DEFAULT_WORKER_GROUP;
impor saic org.apach.dolphinschdulr.common.Consans.LOCAL_PARAMS;
impor saic org.apach.dolphinschdulr.common.Consans.SEC_2_MINUTES_TIME_UNIT;
impor org.apach.dolphinschdulr.common.Consans;
impor org.apach.dolphinschdulr.common.nums.CommandTyp;
impor org.apach.dolphinschdulr.common.nums.DpndRsul;
impor org.apach.dolphinschdulr.common.nums.Dirc;
impor org.apach.dolphinschdulr.common.nums.ExcuionSaus; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,349 | [Bug][master] Manually kill the task that fails to be retried. After the parallel task succeeds, the workflow status is always running | 1. The configuration of task 2 fails to be retried. When the failure is retried for the second time, manually kill the process ID of task 2
2. After task 3 is successfully executed, a task will be added to the master, resulting in the workflow status running all the time
**Which version of Dolphin Scheduler:**
-[1.3.6-prepare]
| https://github.com/apache/dolphinscheduler/issues/5349 | https://github.com/apache/dolphinscheduler/pull/5362 | 3a7006a79649df4f45397f125c2e9665f9659c0b | 75d1ad645c994feadf157fb2343141b3d9ec49bf | "2021-04-22T03:56:30Z" | java | "2021-04-23T06:29:26Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java | impor org.apach.dolphinschdulr.common.nums.FailurSragy;
impor org.apach.dolphinschdulr.common.nums.Flag;
impor org.apach.dolphinschdulr.common.nums.Prioriy;
impor org.apach.dolphinschdulr.common.nums.TaskDpndTyp;
impor org.apach.dolphinschdulr.common.graph.DAG;
impor org.apach.dolphinschdulr.common.modl.TaskNod;
impor org.apach.dolphinschdulr.common.modl.TaskNodRlaion;
impor org.apach.dolphinschdulr.common.procss.ProcssDag;
impor org.apach.dolphinschdulr.common.procss.Propry;
impor org.apach.dolphinschdulr.common.hrad.Soppr;
impor org.apach.dolphinschdulr.common.hrad.ThradUils;
impor org.apach.dolphinschdulr.common.uils.CollcionUils;
impor org.apach.dolphinschdulr.common.uils.DaUils;
impor org.apach.dolphinschdulr.common.uils.JSONUils;
impor org.apach.dolphinschdulr.common.uils.OSUils;
impor org.apach.dolphinschdulr.common.uils.ParamrUils;
impor org.apach.dolphinschdulr.common.uils.SringUils;
impor org.apach.dolphinschdulr.common.uils.VarPoolUils;
impor org.apach.dolphinschdulr.dao.niy.ProcssInsanc;
impor org.apach.dolphinschdulr.dao.niy.ProjcUsr;
impor org.apach.dolphinschdulr.dao.niy.Schdul;
impor org.apach.dolphinschdulr.dao.niy.TaskInsanc;
impor org.apach.dolphinschdulr.dao.uils.DagHlpr;
impor org.apach.dolphinschdulr.rmo.NyRmoingClin;
impor org.apach.dolphinschdulr.srvr.masr.config.MasrConfig;
impor org.apach.dolphinschdulr.srvr.uils.AlrManagr;
impor org.apach.dolphinschdulr.srvic.procss.ProcssSrvic;
impor org.apach.dolphinschdulr.srvic.quarz.cron.CronUils;
impor org.apach.dolphinschdulr.srvic.quu.PrTaskInsancPrioriyQuu;
impor java.x.ParsExcpion; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,349 | [Bug][master] Manually kill the task that fails to be retried. After the parallel task succeeds, the workflow status is always running | 1. The configuration of task 2 fails to be retried. When the failure is retried for the second time, manually kill the process ID of task 2
2. After task 3 is successfully executed, a task will be added to the master, resulting in the workflow status running all the time
**Which version of Dolphin Scheduler:**
-[1.3.6-prepare]
| https://github.com/apache/dolphinscheduler/issues/5349 | https://github.com/apache/dolphinscheduler/pull/5362 | 3a7006a79649df4f45397f125c2e9665f9659c0b | 75d1ad645c994feadf157fb2343141b3d9ec49bf | "2021-04-22T03:56:30Z" | java | "2021-04-23T06:29:26Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java | impor java.uil.ArrayLis;
impor java.uil.Arrays;
impor java.uil.Collcion;
impor java.uil.Da;
impor java.uil.Iraor;
impor java.uil.Lis;
impor java.uil.Map;
impor java.uil.S;
impor java.uil.concurrn.ConcurrnHashMap;
impor java.uil.concurrn.ExcuorSrvic;
impor java.uil.concurrn.Fuur;
impor org.slf4j.Loggr;
impor org.slf4j.LoggrFacory;
impor com.googl.common.collc.Liss;
/**
* masr xc hrad,spli dag
*/
public class MasrExcThrad implmns Runnabl {
/**
* loggr of MasrExcThrad
*/
priva saic final Loggr loggr = LoggrFacory.gLoggr(MasrExcThrad.class);
/**
* runing TaskNod
*/
priva final Map<MasrBasTaskExcThrad, Fuur<Boolan>> acivTaskNod = nw ConcurrnHashMap<>();
/**
* ask xc srvic
*/
priva final ExcuorSrvic askExcSrvic; |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 5,349 | [Bug][master] Manually kill the task that fails to be retried. After the parallel task succeeds, the workflow status is always running | 1. The configuration of task 2 fails to be retried. When the failure is retried for the second time, manually kill the process ID of task 2
2. After task 3 is successfully executed, a task will be added to the master, resulting in the workflow status running all the time
**Which version of Dolphin Scheduler:**
-[1.3.6-prepare]
| https://github.com/apache/dolphinscheduler/issues/5349 | https://github.com/apache/dolphinscheduler/pull/5362 | 3a7006a79649df4f45397f125c2e9665f9659c0b | 75d1ad645c994feadf157fb2343141b3d9ec49bf | "2021-04-22T03:56:30Z" | java | "2021-04-23T06:29:26Z" | dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java | /**
* procss insanc
*/
priva ProcssInsanc procssInsanc;
/**
* submi failur nods
*/
priva boolan askFaildSubmi = fals;
/**
* rcovr nod id lis
*/
priva Lis<TaskInsanc> rcovrNodIdLis = nw ArrayLis<>();
/**
* rror ask lis
*/
priva Map<Sring, TaskInsanc> rrorTaskLis = nw ConcurrnHashMap<>();
/**
* compl ask lis
*/
priva Map<Sring, TaskInsanc> complTaskLis = nw ConcurrnHashMap<>();
/**
* rady o submi ask quu
*/
priva PrTaskInsancPrioriyQuu radyToSubmiTaskQuu = nw PrTaskInsancPrioriyQuu();
/**
* dpnd faild ask map
*/
priva Map<Sring, TaskInsanc> dpndFaildTask = nw ConcurrnHashMap<>();
/**
* forbiddn ask map |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.