status
stringclasses
1 value
repo_name
stringclasses
31 values
repo_url
stringclasses
31 values
issue_id
int64
1
104k
title
stringlengths
4
233
body
stringlengths
0
186k
issue_url
stringlengths
38
56
pull_url
stringlengths
37
54
before_fix_sha
stringlengths
40
40
after_fix_sha
stringlengths
40
40
report_datetime
unknown
language
stringclasses
5 values
commit_datetime
unknown
updated_file
stringlengths
7
188
chunk_content
stringlengths
1
1.03M
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
List<TaskNode> taskNodes = processData.getTasks(); if (CollectionUtils.isEmpty(taskNodes)) { logger.error("process node info is empty"); putMsg(result, Status.PROCESS_DAG_IS_EMPTY); return result; } if (graphHasCycle(taskNodes)) { logger.error("process DAG has cycle"); putMsg(result, Status.PROCESS_NODE_HAS_CYCLE); return result; } for (TaskNode taskNode : taskNodes) { if (!CheckUtils.checkTaskNodeParameters(taskNode)) { logger.error("task node {} parameter invalid", taskNode.getName()); putMsg(result, Status.PROCESS_NODE_S_PARAMETER_INVALID, taskNode.getName()); return result; } CheckUtils.checkOtherParams(taskNode.getExtras()); } putMsg(result, Status.SUCCESS); } catch (Exception e) { result.put(Constants.STATUS, Status.REQUEST_PARAMS_NOT_VALID_ERROR); result.put(Constants.MSG, e.getMessage()); } return result; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
/** * get task node details based on process definition * * @param defineCode define code * @return task node list */ public Map<String, Object> getTaskNodeListByDefinitionCode(Long defineCode) { Map<String, Object> result = new HashMap<>(); ProcessDefinition processDefinition = processDefinitionMapper.queryByCode(defineCode); if (processDefinition == null) { logger.info("process define not exists"); putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, defineCode); return result; } ProcessData processData = processService.genProcessData(processDefinition); if (null == processData) { logger.error("process data is null"); putMsg(result, Status.DATA_IS_NOT_VALID, JSONUtils.toJsonString(processData)); return result; } List<TaskNode> taskNodeList = (processData.getTasks() == null) ? new ArrayList<>() : processData.getTasks(); result.put(Constants.DATA_LIST, taskNodeList); putMsg(result, Status.SUCCESS); return result; } /** * get task node details based on process definition * * @param defineCodeList define code list
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
* @return task node list */ @Override public Map<String, Object> getTaskNodeListByDefinitionCodeList(String defineCodeList) { Map<String, Object> result = new HashMap<>(); Map<Integer, List<TaskNode>> taskNodeMap = new HashMap<>(); String[] codeArr = defineCodeList.split(","); List<Long> codeList = new ArrayList<>(); for (String definitionCode : codeArr) { codeList.add(Long.parseLong(definitionCode)); } List<ProcessDefinition> processDefinitionList = processDefinitionMapper.queryByCodes(codeList); if (CollectionUtils.isEmpty(processDefinitionList)) { logger.info("process definition not exists"); putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, defineCodeList); return result; } for (ProcessDefinition processDefinition : processDefinitionList) { ProcessData processData = processService.genProcessData(processDefinition); List<TaskNode> taskNodeList = (processData.getTasks() == null) ? new ArrayList<>() : processData.getTasks(); taskNodeMap.put(processDefinition.getId(), taskNodeList); } result.put(Constants.DATA_LIST, taskNodeMap); putMsg(result, Status.SUCCESS); return result; } /** * query process definition all by project id * * @param projectId project id
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
* @return process definitions in the project */ @Override public Map<String, Object> queryProcessDefinitionAllByProjectId(Integer projectId) { HashMap<String, Object> result = new HashMap<>(); Project project = projectMapper.selectById(projectId); List<ProcessDefinition> resourceList = processDefinitionMapper.queryAllDefinitionList(project.getCode()); resourceList.forEach(processDefinition -> { ProcessData processData = processService.genProcessData(processDefinition); processDefinition.setProcessDefinitionJson(JSONUtils.toJsonString(processData)); }); result.put(Constants.DATA_LIST, resourceList); putMsg(result, Status.SUCCESS); return result; } /** * Encapsulates the TreeView structure * * @param processId process definition id * @param limit limit * @return tree view json data * @throws Exception exception */ @Override public Map<String, Object> viewTree(Integer processId, Integer limit) throws Exception { Map<String, Object> result = new HashMap<>(); ProcessDefinition processDefinition = processDefinitionMapper.selectById(processId); if (null == processDefinition) { logger.info("process define not exists"); putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, processDefinition);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
return result; } DAG<String, TaskNode, TaskNodeRelation> dag = processService.genDagGraph(processDefinition); /** * nodes that is running */ Map<String, List<TreeViewDto>> runningNodeMap = new ConcurrentHashMap<>(); /** * nodes that is waiting torun */ Map<String, List<TreeViewDto>> waitingRunningNodeMap = new ConcurrentHashMap<>(); /** * List of process instances */ List<ProcessInstance> processInstanceList = processInstanceService.queryByProcessDefineCode(processDefinition.getCode(), limit); List<TaskDefinitionLog> taskDefinitionList = processService.queryTaskDefinitionList(processDefinition.getCode(), processDefinition.getVersion()); Map<Long, TaskDefinition> taskDefinitionMap = new HashedMap(); taskDefinitionList.forEach(taskDefinitionLog -> taskDefinitionMap.put(taskDefinitionLog.getCode(), taskDefinitionLog)); for (ProcessInstance processInstance : processInstanceList) { processInstance.setDuration(DateUtils.format2Duration(processInstance.getStartTime(), processInstance.getEndTime())); } if (limit > processInstanceList.size()) { limit = processInstanceList.size(); } TreeViewDto parentTreeViewDto = new TreeViewDto(); parentTreeViewDto.setName("DAG"); parentTreeViewDto.setType(""); for (int i = limit - 1; i >= 0; i--) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
ProcessInstance processInstance = processInstanceList.get(i); Date endTime = processInstance.getEndTime() == null ? new Date() : processInstance.getEndTime(); parentTreeViewDto.getInstances().add(new Instance(processInstance.getId(), processInstance.getName(), "", processInstance.getState().toString() , processInstance.getStartTime(), endTime, processInstance.getHost(), DateUtils.format2Readable(endTime.getTime() - processInstance.getStartTime().getTime()))); } List<TreeViewDto> parentTreeViewDtoList = new ArrayList<>(); parentTreeViewDtoList.add(parentTreeViewDto); for (String startNode : dag.getBeginNode()) { runningNodeMap.put(startNode, parentTreeViewDtoList); } while (Stopper.isRunning()) { Set<String> postNodeList = null; Iterator<Map.Entry<String, List<TreeViewDto>>> iter = runningNodeMap.entrySet().iterator(); while (iter.hasNext()) { Map.Entry<String, List<TreeViewDto>> en = iter.next(); String nodeName = en.getKey(); parentTreeViewDtoList = en.getValue(); TreeViewDto treeViewDto = new TreeViewDto(); treeViewDto.setName(nodeName); TaskNode taskNode = dag.getNode(nodeName); treeViewDto.setType(taskNode.getType()); for (int i = limit - 1; i >= 0; i--) { ProcessInstance processInstance = processInstanceList.get(i); TaskInstance taskInstance = taskInstanceMapper.queryByInstanceIdAndName(processInstance.getId(), nodeName); if (taskInstance == null) { treeViewDto.getInstances().add(new Instance(-1, "not running", "null")); } else { Date startTime = taskInstance.getStartTime() == null ? new Date() : taskInstance.getStartTime();
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Date endTime = taskInstance.getEndTime() == null ? new Date() : taskInstance.getEndTime(); int subProcessId = 0; /** * if process is sub process, the return sub id, or sub id=0 */ if (taskInstance.isSubProcess()) { TaskDefinition taskDefinition = taskDefinitionMap.get(taskInstance.getTaskCode()); subProcessId = Integer.parseInt(JSONUtils.parseObject( taskDefinition.getTaskParams()).path(CMD_PARAM_SUB_PROCESS_DEFINE_ID).asText()); } treeViewDto.getInstances().add(new Instance(taskInstance.getId(), taskInstance.getName(), taskInstance.getTaskType(), taskInstance.getState().toString() , taskInstance.getStartTime(), taskInstance.getEndTime(), taskInstance.getHost(), DateUtils.format2Readable(endTime.getTime() - startTime.getTime()), subProcessId)); } } for (TreeViewDto pTreeViewDto : parentTreeViewDtoList) { pTreeViewDto.getChildren().add(treeViewDto); } postNodeList = dag.getSubsequentNodes(nodeName); if (CollectionUtils.isNotEmpty(postNodeList)) { for (String nextNodeName : postNodeList) { List<TreeViewDto> treeViewDtoList = waitingRunningNodeMap.get(nextNodeName); if (CollectionUtils.isEmpty(treeViewDtoList)) { treeViewDtoList = new ArrayList<>(); } treeViewDtoList.add(treeViewDto); waitingRunningNodeMap.put(nextNodeName, treeViewDtoList); } } runningNodeMap.remove(nodeName); }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
if (waitingRunningNodeMap.size() == 0) { break; } else { runningNodeMap.putAll(waitingRunningNodeMap); waitingRunningNodeMap.clear(); } } result.put(Constants.DATA_LIST, parentTreeViewDto); result.put(Constants.STATUS, Status.SUCCESS); result.put(Constants.MSG, Status.SUCCESS.getMsg()); return result; } /** * whether the graph has a ring * * @param taskNodeResponseList task node response list * @return if graph has cycle flag */ private boolean graphHasCycle(List<TaskNode> taskNodeResponseList) { DAG<String, TaskNode, String> graph = new DAG<>(); for (TaskNode taskNodeResponse : taskNodeResponseList) { graph.addNode(taskNodeResponse.getName(), taskNodeResponse); } for (TaskNode taskNodeResponse : taskNodeResponseList) { List<String> preTasks = JSONUtils.toList(taskNodeResponse.getPreTasks(), String.class); if (CollectionUtils.isNotEmpty(preTasks)) { for (String preTask : preTasks) { if (!graph.addEdge(preTask, taskNodeResponse.getName())) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
return true; } } } } return graph.hasCycle(); } private String recursionProcessDefinitionName(Long projectCode, String processDefinitionName, int num) { ProcessDefinition processDefinition = processDefinitionMapper.queryByDefineName(projectCode, processDefinitionName); if (processDefinition != null) { if (num > 1) { String str = processDefinitionName.substring(0, processDefinitionName.length() - 3); processDefinitionName = str + "(" + num + ")"; } else { processDefinitionName = processDefinition.getName() + "(" + num + ")"; } } else { return processDefinitionName; } return recursionProcessDefinitionName(projectCode, processDefinitionName, num + 1); } private Map<String, Object> copyProcessDefinition(User loginUser, Integer processId, Project targetProject) throws JsonProcessingException { Map<String, Object> result = new HashMap<>(); String currentTimeStamp = DateUtils.getCurrentTimeStamp(); ProcessDefinition processDefinition = processDefinitionMapper.selectById(processId); if (processDefinition == null) { putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, processId); return result;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
} else { ProcessData processData = processService.genProcessData(processDefinition); List<TaskNode> taskNodeList = processData.getTasks(); String locations = processDefinition.getLocations(); ObjectNode locationsJN = JSONUtils.parseObject(locations); for (TaskNode taskNode : taskNodeList) { String suffix = "_copy_" + currentTimeStamp; String id = taskNode.getId(); String newName = locationsJN.path(id).path("name").asText() + suffix; ((ObjectNode) locationsJN.get(id)).put("name", newName); List<String> depList = taskNode.getDepList(); List<String> newDepList = depList.stream() .map(s -> s + suffix) .collect(Collectors.toList()); taskNode.setDepList(newDepList); taskNode.setName(taskNode.getName() + suffix); taskNode.setCode(0L); } processData.setTasks(taskNodeList); String processDefinitionJson = JSONUtils.toJsonString(processData); return createProcessDefinition( loginUser, targetProject.getName(), processDefinition.getName() + "_copy_" + currentTimeStamp, processDefinitionJson, processDefinition.getDescription(), locationsJN.toString(), processDefinition.getConnects()); } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
/** * batch copy process definition * * @param loginUser loginUser * @param projectName projectName * @param processDefinitionIds processDefinitionIds * @param targetProjectId targetProjectId */ @Override public Map<String, Object> batchCopyProcessDefinition(User loginUser, String projectName, String processDefinitionIds, int targetProjectId) { Map<String, Object> result = new HashMap<>(); List<String> failedProcessList = new ArrayList<>(); if (StringUtils.isEmpty(processDefinitionIds)) { putMsg(result, Status.PROCESS_DEFINITION_IDS_IS_EMPTY, processDefinitionIds); return result; } Map<String, Object> checkResult = checkProjectAndAuth(loginUser, projectName); if (checkResult != null) { return checkResult; } Project targetProject = projectMapper.queryDetailById(targetProjectId); if (targetProject == null) { putMsg(result, Status.PROJECT_NOT_FOUNT, targetProjectId); return result; } if (!(targetProject.getName()).equals(projectName)) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Map<String, Object> checkTargetProjectResult = checkProjectAndAuth(loginUser, targetProject.getName()); if (checkTargetProjectResult != null) { return checkTargetProjectResult; } } String[] processDefinitionIdList = processDefinitionIds.split(Constants.COMMA); doBatchCopyProcessDefinition(loginUser, targetProject, failedProcessList, processDefinitionIdList); checkBatchOperateResult(projectName, targetProject.getName(), result, failedProcessList, true); return result; } /** * batch move process definition * * @param loginUser loginUser * @param projectName projectName * @param processDefinitionIds processDefinitionIds * @param targetProjectId targetProjectId */ @Override public Map<String, Object> batchMoveProcessDefinition(User loginUser, String projectName, String processDefinitionIds, int targetProjectId) { Map<String, Object> result = new HashMap<>(); List<String> failedProcessList = new ArrayList<>(); Map<String, Object> checkResult = checkProjectAndAuth(loginUser, projectName); if (checkResult != null) { return checkResult; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
if (StringUtils.isEmpty(processDefinitionIds)) { putMsg(result, Status.PROCESS_DEFINITION_IDS_IS_EMPTY, processDefinitionIds); return result; } Project targetProject = projectMapper.queryDetailById(targetProjectId); if (targetProject == null) { putMsg(result, Status.PROJECT_NOT_FOUNT, targetProjectId); return result; } if (!(targetProject.getName()).equals(projectName)) { Map<String, Object> checkTargetProjectResult = checkProjectAndAuth(loginUser, targetProject.getName()); if (checkTargetProjectResult != null) { return checkTargetProjectResult; } } Integer[] definitionIds = Arrays.stream(processDefinitionIds.split(Constants.COMMA)).map(Integer::parseInt).toArray(Integer[]::new); List<ProcessDefinition> processDefinitionList = processDefinitionMapper.queryDefinitionListByIdList(definitionIds); for (ProcessDefinition processDefinition : processDefinitionList) { ProcessDefinitionLog processDefinitionLog = moveProcessDefinition(loginUser, targetProject.getCode(), processDefinition, result, failedProcessList); if (processDefinitionLog != null) { moveTaskRelation(loginUser, processDefinition.getProjectCode(), processDefinitionLog); } } checkBatchOperateResult(projectName, targetProject.getName(), result, failedProcessList, false); return result; } private ProcessDefinitionLog moveProcessDefinition(User loginUser, Long targetProjectCode, ProcessDefinition processDefinition, Map<String, Object> result, List<String> failedProcessList) { try { Integer version = processDefinitionLogMapper.queryMaxVersionForDefinition(processDefinition.getCode());
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
ProcessDefinitionLog processDefinitionLog = new ProcessDefinitionLog(processDefinition); processDefinitionLog.setVersion(version == null || version == 0 ? 1 : version + 1); processDefinitionLog.setProjectCode(targetProjectCode); processDefinitionLog.setOperator(loginUser.getId()); Date now = new Date(); processDefinitionLog.setOperateTime(now); processDefinitionLog.setUpdateTime(now); processDefinitionLog.setCreateTime(now); int update = processDefinitionMapper.updateById(processDefinitionLog); int insertLog = processDefinitionLogMapper.insert(processDefinitionLog); if ((insertLog & update) > 0) { putMsg(result, Status.SUCCESS); } else { failedProcessList.add(processDefinition.getId() + "[" + processDefinition.getName() + "]"); putMsg(result, Status.UPDATE_PROCESS_DEFINITION_ERROR); } return processDefinitionLog; } catch (Exception e) { putMsg(result, Status.UPDATE_PROCESS_DEFINITION_ERROR); failedProcessList.add(processDefinition.getId() + "[" + processDefinition.getName() + "]"); logger.error("move processDefinition error: {}", e.getMessage(), e); } return null; } private void moveTaskRelation(User loginUser, Long projectCode, ProcessDefinitionLog processDefinition) { List<ProcessTaskRelation> processTaskRelationList = processTaskRelationMapper.queryByProcessCode(projectCode, processDefinition.getCode()); if (!processTaskRelationList.isEmpty()) { processTaskRelationMapper.deleteByCode(projectCode, processDefinition.getCode()); } Date now = new Date();
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
for (ProcessTaskRelation processTaskRelation : processTaskRelationList) { processTaskRelation.setProjectCode(processDefinition.getProjectCode()); processTaskRelation.setProcessDefinitionVersion(processDefinition.getVersion()); processTaskRelation.setCreateTime(now); processTaskRelation.setUpdateTime(now); processService.saveTaskRelation(loginUser, processTaskRelation); } } /** * switch the defined process definition verison * * @param loginUser login user * @param projectName project name * @param processDefinitionId process definition id * @param version the version user want to switch * @return switch process definition version result code */ @Override public Map<String, Object> switchProcessDefinitionVersion(User loginUser, String projectName , int processDefinitionId, long version) { Map<String, Object> result = new HashMap<>(); Project project = projectMapper.queryByName(projectName); Map<String, Object> checkResult = projectService.checkProjectAndAuth(loginUser, project, projectName); Status resultStatus = (Status) checkResult.get(Constants.STATUS); if (resultStatus != Status.SUCCESS) { return checkResult; } ProcessDefinition processDefinition = processDefinitionMapper.queryByDefineId(processDefinitionId); if (Objects.isNull(processDefinition)) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
putMsg(result , Status.SWITCH_PROCESS_DEFINITION_VERSION_NOT_EXIST_PROCESS_DEFINITION_ERROR , processDefinitionId); return result; } ProcessDefinitionLog processDefinitionLog = processDefinitionLogMapper .queryByDefinitionCodeAndVersion(processDefinition.getCode(), version); if (Objects.isNull(processDefinitionLog)) { putMsg(result , Status.SWITCH_PROCESS_DEFINITION_VERSION_NOT_EXIST_PROCESS_DEFINITION_VERSION_ERROR , processDefinition.getCode() , version); return result; } int switchVersion = processService.switchVersion(processDefinition, processDefinitionLog); if (switchVersion > 0) { putMsg(result, Status.SUCCESS); } else { putMsg(result, Status.SWITCH_PROCESS_DEFINITION_VERSION_ERROR); } return result; } /** * batch copy process definition * * @param loginUser loginUser * @param targetProject targetProject * @param failedProcessList failedProcessList * @param processDefinitionIdList processDefinitionIdList */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
private void doBatchCopyProcessDefinition(User loginUser, Project targetProject, List<String> failedProcessList, String[] processDefinitionIdList) { for (String processDefinitionId : processDefinitionIdList) { try { Map<String, Object> copyProcessDefinitionResult = copyProcessDefinition(loginUser, Integer.valueOf(processDefinitionId), targetProject); if (!Status.SUCCESS.equals(copyProcessDefinitionResult.get(Constants.STATUS))) { setFailedProcessList(failedProcessList, processDefinitionId); logger.error((String) copyProcessDefinitionResult.get(Constants.MSG)); } } catch (Exception e) { setFailedProcessList(failedProcessList, processDefinitionId); logger.error("copy processDefinition error: {}", e.getMessage(), e); } } } /** * set failed processList * * @param failedProcessList failedProcessList * @param processDefinitionId processDefinitionId */ private void setFailedProcessList(List<String> failedProcessList, String processDefinitionId) { ProcessDefinition processDefinition = processDefinitionMapper.queryByDefineId(Integer.parseInt(processDefinitionId)); if (processDefinition != null) { failedProcessList.add(processDefinitionId + "[" + processDefinition.getName() + "]"); } else { failedProcessList.add(processDefinitionId + "[null]"); } } /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
* check project and auth * * @param loginUser loginUser * @param projectName projectName */ private Map<String, Object> checkProjectAndAuth(User loginUser, String projectName) { Project project = projectMapper.queryByName(projectName); Map<String, Object> checkResult = projectService.checkProjectAndAuth(loginUser, project, projectName); Status resultStatus = (Status) checkResult.get(Constants.STATUS); if (resultStatus != Status.SUCCESS) { return checkResult; } return null; } /** * check batch operate result * * @param srcProjectName srcProjectName * @param targetProjectName targetProjectName * @param result result * @param failedProcessList failedProcessList * @param isCopy isCopy */ private void checkBatchOperateResult(String srcProjectName, String targetProjectName, Map<String, Object> result, List<String> failedProcessList, boolean isCopy) { if (!failedProcessList.isEmpty()) { if (isCopy) { putMsg(result, Status.COPY_PROCESS_DEFINITION_ERROR, srcProjectName, targetProjectName, String.join(",", failedProcessList)); } else {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
putMsg(result, Status.MOVE_PROCESS_DEFINITION_ERROR, srcProjectName, targetProjectName, String.join(",", failedProcessList)); } } else { putMsg(result, Status.SUCCESS); } } /** * check has associated process definition * * @param processDefinitionId process definition id * @param version version * @return The query result has a specific process definition return true */ @Override public boolean checkHasAssociatedProcessDefinition(int processDefinitionId, long version) { Integer hasAssociatedDefinitionId = processDefinitionMapper.queryHasAssociatedDefinitionByIdAndVersion(processDefinitionId, version); return Objects.nonNull(hasAssociatedDefinitionId); } /** * query the pagination versions info by one certain process definition code * * @param loginUser login user info to check auth * @param projectName process definition project name * @param pageNo page number * @param pageSize page size * @param processDefinitionCode process definition code * @return the pagination process definition versions info of the certain process definition */ @Override public Map<String, Object> queryProcessDefinitionVersions(User loginUser, String projectName, int pageNo, int pageSize, long processDefinitionCode) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
Map<String, Object> result = new HashMap<>(); if (pageNo <= 0 || pageSize <= 0) { putMsg(result , Status.QUERY_PROCESS_DEFINITION_VERSIONS_PAGE_NO_OR_PAGE_SIZE_LESS_THAN_1_ERROR , pageNo , pageSize); return result; } Project project = projectMapper.queryByName(projectName); Map<String, Object> checkResult = projectService.checkProjectAndAuth(loginUser, project, projectName); Status resultStatus = (Status) checkResult.get(Constants.STATUS); if (resultStatus != Status.SUCCESS) { return checkResult; } ProcessDefinition processDefinition = processDefinitionMapper.queryByCode(processDefinitionCode); PageInfo<ProcessDefinitionLog> pageInfo = new PageInfo<>(pageNo, pageSize); Page<ProcessDefinitionLog> page = new Page<>(pageNo, pageSize); IPage<ProcessDefinitionLog> processDefinitionVersionsPaging = processDefinitionLogMapper.queryProcessDefinitionVersionsPaging(page, processDefinition.getCode()); List<ProcessDefinitionLog> processDefinitionLogs = processDefinitionVersionsPaging.getRecords(); ProcessData processData = processService.genProcessData(processDefinition); processDefinition.setProcessDefinitionJson(JSONUtils.toJsonString(processData)); pageInfo.setLists(processDefinitionLogs); pageInfo.setTotalCount((int) processDefinitionVersionsPaging.getTotal()); return ImmutableMap.of( Constants.MSG, Status.SUCCESS.getMsg() , Constants.STATUS, Status.SUCCESS , Constants.DATA_LIST, pageInfo); }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,569
[Bug][dolphinscheduler-api] verify proccess definition name fail
**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! ** **Describe the bug** when use spaces in proccess definition name, it will check fail! **To Reproduce** Steps to reproduce the behavior, for example: 1. Go to create a process, edit a simple task; 2. Save process definition name as “new_process”; 3. Go to create a new process, edit a simple task; 4. Save process definition name as “ new_process”. This time, the name verification will also succeed; 5. Then two process definitions with the same name are generated. **Which version of Dolphin Scheduler:** -[1.3.5] **Requirement or improvement** - Name verification can be solved by adding and removing the first and last spaces.
https://github.com/apache/dolphinscheduler/issues/5569
https://github.com/apache/dolphinscheduler/pull/5574
a5a0c7c5f8885b31e18bbf3e2d8567104ba38b57
cc9e5d5d34fcf2279b267cca7df37a9e80eeba07
"2021-06-01T11:46:21Z"
java
"2021-06-02T04:01:01Z"
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java
/** * delete one certain process definition by version number and process definition id * * @param loginUser login user info to check auth * @param projectName process definition project name * @param processDefinitionId process definition id * @param version version number * @return delele result code */ @Override public Map<String, Object> deleteByProcessDefinitionIdAndVersion(User loginUser, String projectName, int processDefinitionId, long version) { Map<String, Object> result = new HashMap<>(); Project project = projectMapper.queryByName(projectName); Map<String, Object> checkResult = projectService.checkProjectAndAuth(loginUser, project, projectName); Status resultStatus = (Status) checkResult.get(Constants.STATUS); if (resultStatus != Status.SUCCESS) { return checkResult; } ProcessDefinition processDefinition = processDefinitionMapper.queryByDefineId(processDefinitionId); if (processDefinition == null) { putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, processDefinitionId); } else { processDefinitionLogMapper.deleteByProcessDefinitionCodeAndVersion(processDefinition.getCode(), version); putMsg(result, Status.SUCCESS); } return result; } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.server.master; import org.apache.dolphinscheduler.common.Constants; import org.apache.dolphinscheduler.common.IStoppable; import org.apache.dolphinscheduler.common.thread.Stopper; import org.apache.dolphinscheduler.remote.NettyRemotingServer; import org.apache.dolphinscheduler.remote.command.CommandType;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
import org.apache.dolphinscheduler.remote.config.NettyServerConfig; import org.apache.dolphinscheduler.server.master.config.MasterConfig; import org.apache.dolphinscheduler.server.master.processor.TaskAckProcessor; import org.apache.dolphinscheduler.server.master.processor.TaskKillResponseProcessor; import org.apache.dolphinscheduler.server.master.processor.TaskResponseProcessor; import org.apache.dolphinscheduler.server.master.runner.MasterSchedulerService; import org.apache.dolphinscheduler.server.master.zk.ZKMasterClient; import org.apache.dolphinscheduler.service.bean.SpringApplicationContext; import org.apache.dolphinscheduler.service.quartz.QuartzExecutors; import javax.annotation.PostConstruct; import org.quartz.SchedulerException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.WebApplicationType; import org.springframework.boot.builder.SpringApplicationBuilder; import org.springframework.context.annotation.ComponentScan; import org.springframework.context.annotation.FilterType; import org.springframework.transaction.annotation.EnableTransactionManagement; /** * master server */ @ComponentScan(value = "org.apache.dolphinscheduler", excludeFilters = { @ComponentScan.Filter(type = FilterType.REGEX, pattern = { "org.apache.dolphinscheduler.server.worker.*", "org.apache.dolphinscheduler.server.monitor.*", "org.apache.dolphinscheduler.server.log.*" }) }) @EnableTransactionManagement
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
public class MasterServer implements IStoppable { /** * logger of MasterServer */ private static final Logger logger = LoggerFactory.getLogger(MasterServer.class); /** * master config */ @Autowired private MasterConfig masterConfig; /** * spring application context * only use it for initialization */ @Autowired private SpringApplicationContext springApplicationContext; /** * netty remote server */ private NettyRemotingServer nettyRemotingServer; /** * zk master client */ @Autowired private ZKMasterClient zkMasterClient; /** * scheduler service */ @Autowired private MasterSchedulerService masterSchedulerService;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
/** * master server startup, not use web service * * @param args arguments */ public static void main(String[] args) { Thread.currentThread().setName(Constants.THREAD_NAME_MASTER_SERVER); new SpringApplicationBuilder(MasterServer.class).web(WebApplicationType.NONE).run(args); } /** * run master server */ @PostConstruct public void run() { NettyServerConfig serverConfig = new NettyServerConfig(); serverConfig.setListenPort(masterConfig.getListenPort()); this.nettyRemotingServer = new NettyRemotingServer(serverConfig); this.nettyRemotingServer.registerProcessor(CommandType.TASK_EXECUTE_RESPONSE, new TaskResponseProcessor()); this.nettyRemotingServer.registerProcessor(CommandType.TASK_EXECUTE_ACK, new TaskAckProcessor()); this.nettyRemotingServer.registerProcessor(CommandType.TASK_KILL_RESPONSE, new TaskKillResponseProcessor()); this.nettyRemotingServer.start(); this.zkMasterClient.start(); this.zkMasterClient.setStoppable(this); this.masterSchedulerService.start(); try {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
logger.info("start Quartz server..."); QuartzExecutors.getInstance().start(); } catch (Exception e) { try { QuartzExecutors.getInstance().shutdown(); } catch (SchedulerException e1) { logger.error("QuartzExecutors shutdown failed : " + e1.getMessage(), e1); } logger.error("start Quartz failed", e); } /** * register hooks, which are called before the process exits */ Runtime.getRuntime().addShutdownHook(new Thread(() -> { if (Stopper.isRunning()) { close("shutdownHook"); } })); } /** * gracefully close * * @param cause close cause */ public void close(String cause) { try { if (Stopper.isStopped()) { return; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
logger.info("master server is stopping ..., cause : {}", cause); Stopper.stop(); try { Thread.sleep(3000L); } catch (Exception e) { logger.warn("thread sleep exception ", e); } this.masterSchedulerService.close(); this.nettyRemotingServer.close(); this.zkMasterClient.close(); try { QuartzExecutors.getInstance().shutdown(); logger.info("Quartz service stopped"); } catch (Exception e) { logger.warn("Quartz service stopped exception:{}", e.getMessage()); } } catch (Exception e) { logger.error("master server stop exception ", e); } } @Override public void stop(String cause) { close(cause); } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/bean/SpringApplicationContext.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.service.bean; import org.springframework.beans.BeansException; import org.springframework.context.ApplicationContext; import org.springframework.context.ApplicationContextAware; import org.springframework.stereotype.Component; @Component
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/bean/SpringApplicationContext.java
public class SpringApplicationContext implements ApplicationContextAware { private static ApplicationContext applicationContext; @Override public void setApplicationContext(ApplicationContext applicationContext) throws BeansException { SpringApplicationContext.applicationContext = applicationContext; } public static <T> T getBean(Class<T> requiredType) { return applicationContext.getBean(requiredType); } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/CuratorZookeeperClient.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.service.zk; import static org.apache.dolphinscheduler.common.utils.Preconditions.checkNotNull;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/CuratorZookeeperClient.java
import org.apache.dolphinscheduler.common.utils.StringUtils; import org.apache.dolphinscheduler.service.exceptions.ServiceException; import org.apache.curator.framework.CuratorFramework; import org.apache.curator.framework.CuratorFrameworkFactory; import org.apache.curator.framework.api.ACLProvider; import org.apache.curator.framework.state.ConnectionState; import org.apache.curator.retry.ExponentialBackoffRetry; import org.apache.zookeeper.ZooDefs; import org.apache.zookeeper.data.ACL; import java.nio.charset.StandardCharsets; import java.util.List; import java.util.concurrent.TimeUnit; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.InitializingBean; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Component; /** * Shared Curator zookeeper client */ @Component public class CuratorZookeeperClient implements InitializingBean { private final Logger logger = LoggerFactory.getLogger(CuratorZookeeperClient.class); @Autowired private ZookeeperConfig zookeeperConfig; private CuratorFramework zkClient; @Override public void afterPropertiesSet() throws Exception { this.zkClient = buildClient(); initStateLister();
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/CuratorZookeeperClient.java
} private CuratorFramework buildClient() { logger.info("zookeeper registry center init, server lists is: [{}]", zookeeperConfig.getServerList()); CuratorFrameworkFactory.Builder builder = CuratorFrameworkFactory.builder() .ensembleProvider(new DefaultEnsembleProvider(checkNotNull(zookeeperConfig.getServerList(), "zookeeper quorum can't be null"))) .retryPolicy(new ExponentialBackoffRetry(zookeeperConfig.getBaseSleepTimeMs(), zookeeperConfig.getMaxRetries(), zookeeperConfig.getMaxSleepMs())); if (0 != zookeeperConfig.getSessionTimeoutMs()) { builder.sessionTimeoutMs(zookeeperConfig.getSessionTimeoutMs()); } if (0 != zookeeperConfig.getConnectionTimeoutMs()) { builder.connectionTimeoutMs(zookeeperConfig.getConnectionTimeoutMs()); } if (StringUtils.isNotBlank(zookeeperConfig.getDigest())) { builder.authorization("digest", zookeeperConfig.getDigest().getBytes(StandardCharsets.UTF_8)).aclProvider(new ACLProvider() { @Override public List<ACL> getDefaultAcl() { return ZooDefs.Ids.CREATOR_ALL_ACL; } @Override public List<ACL> getAclForPath(final String path) { return ZooDefs.Ids.CREATOR_ALL_ACL; } }); } zkClient = builder.build(); zkClient.start(); try { logger.info("trying to connect zookeeper server list:{}", zookeeperConfig.getServerList()); zkClient.blockUntilConnected(30, TimeUnit.SECONDS);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,586
[Question] the cluster hangs up caused by failing to obtain JDBC Connection
I cannot see any master or worker on the Monitor page when the backend process instance is still alive on the ds server. ```[ERROR] 2021-06-02 08:53:16.176 org.apache.dolphinscheduler.server.master.registry.ServerNodeManager:[230] - WorkerGroupListener capture data change and get data failed org.mybatis.spring.MyBatisSystemException: nested exception is org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:78) at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:440) at com.sun.proxy.$Proxy84.insert(Unknown Source) at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:271) at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:58) at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) at com.sun.proxy.$Proxy108.insert(Unknown Source) at org.apache.dolphinscheduler.dao.AlertDao.saveTaskTimeoutAlert(AlertDao.java:135) at org.apache.dolphinscheduler.dao.AlertDao.sendServerStopedAlert(AlertDao.java:102) at org.apache.dolphinscheduler.server.master.registry.ServerNodeManager$WorkerGroupNodeListener.dataChanged(ServerNodeManager.java:225) at org.apache.dolphinscheduler.service.zk.AbstractListener.childEvent(AbstractListener.java:32) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:760) at org.apache.curator.framework.recipes.cache.TreeCache$2.apply(TreeCache.java:754) at org.apache.curator.framework.listen.ListenerContainer$1.run(ListenerContainer.java:100) at org.apache.curator.shaded.com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:30) at org.apache.curator.framework.listen.ListenerContainer.forEach(ListenerContainer.java:92) at org.apache.curator.framework.recipes.cache.TreeCache.callListeners(TreeCache.java:753) at org.apache.curator.framework.recipes.cache.TreeCache.access$1900(TreeCache.java:75) at org.apache.curator.framework.recipes.cache.TreeCache$4.run(TreeCache.java:865) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at `java.lang.Thread.run(Thread.java:748)` Caused by: org.apache.ibatis.exceptions.PersistenceException: ### Error updating database. Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is com.alibaba.druid.pool.DataSourceClosedException: dataSource already closed at Wed Jun 02 08:52:57 CST 2021 ### The error may exist in org/apache/dolphinscheduler/dao/mapper/AlertMapper.java (best guess) ### The error may involve org.apache.dolphinscheduler.dao.mapper.AlertMapper.insert ### The error occurred while executing an update ```
https://github.com/apache/dolphinscheduler/issues/5586
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-06-03T01:39:35Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/CuratorZookeeperClient.java
} catch (final Exception ex) { throw new ServiceException(ex); } return zkClient; } public void initStateLister() { checkNotNull(zkClient); zkClient.getConnectionStateListenable().addListener((client, newState) -> { if (newState == ConnectionState.LOST) { logger.error("connection lost from zookeeper"); } else if (newState == ConnectionState.RECONNECTED) { logger.info("reconnected to zookeeper"); } else if (newState == ConnectionState.SUSPENDED) { logger.warn("connection SUSPENDED to zookeeper"); } else if (newState == ConnectionState.CONNECTED) { logger.info("connected to zookeeper server list:[{}]", zookeeperConfig.getServerList()); } }); } public ZookeeperConfig getZookeeperConfig() { return zookeeperConfig; } public void setZookeeperConfig(ZookeeperConfig zookeeperConfig) { this.zookeeperConfig = zookeeperConfig; } public CuratorFramework getZkClient() { return zkClient; } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.server.master; import org.apache.dolphinscheduler.common.Constants; import org.apache.dolphinscheduler.common.IStoppable; import org.apache.dolphinscheduler.common.thread.Stopper; import org.apache.dolphinscheduler.remote.NettyRemotingServer; import org.apache.dolphinscheduler.remote.command.CommandType;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
import org.apache.dolphinscheduler.remote.config.NettyServerConfig; import org.apache.dolphinscheduler.server.master.config.MasterConfig; import org.apache.dolphinscheduler.server.master.processor.TaskAckProcessor; import org.apache.dolphinscheduler.server.master.processor.TaskKillResponseProcessor; import org.apache.dolphinscheduler.server.master.processor.TaskResponseProcessor; import org.apache.dolphinscheduler.server.master.runner.MasterSchedulerService; import org.apache.dolphinscheduler.server.master.zk.ZKMasterClient; import org.apache.dolphinscheduler.service.bean.SpringApplicationContext; import org.apache.dolphinscheduler.service.quartz.QuartzExecutors; import javax.annotation.PostConstruct; import org.quartz.SchedulerException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.WebApplicationType; import org.springframework.boot.builder.SpringApplicationBuilder; import org.springframework.context.annotation.ComponentScan; import org.springframework.context.annotation.FilterType; import org.springframework.transaction.annotation.EnableTransactionManagement; /** * master server */ @ComponentScan(value = "org.apache.dolphinscheduler", excludeFilters = { @ComponentScan.Filter(type = FilterType.REGEX, pattern = { "org.apache.dolphinscheduler.server.worker.*", "org.apache.dolphinscheduler.server.monitor.*", "org.apache.dolphinscheduler.server.log.*" }) }) @EnableTransactionManagement
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
public class MasterServer implements IStoppable { /** * logger of MasterServer */ private static final Logger logger = LoggerFactory.getLogger(MasterServer.class); /** * master config */ @Autowired private MasterConfig masterConfig; /** * spring application context * only use it for initialization */ @Autowired private SpringApplicationContext springApplicationContext; /** * netty remote server */ private NettyRemotingServer nettyRemotingServer; /** * zk master client */ @Autowired private ZKMasterClient zkMasterClient; /** * scheduler service */ @Autowired private MasterSchedulerService masterSchedulerService;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
/** * master server startup, not use web service * * @param args arguments */ public static void main(String[] args) { Thread.currentThread().setName(Constants.THREAD_NAME_MASTER_SERVER); new SpringApplicationBuilder(MasterServer.class).web(WebApplicationType.NONE).run(args); } /** * run master server */ @PostConstruct public void run() { NettyServerConfig serverConfig = new NettyServerConfig(); serverConfig.setListenPort(masterConfig.getListenPort()); this.nettyRemotingServer = new NettyRemotingServer(serverConfig); this.nettyRemotingServer.registerProcessor(CommandType.TASK_EXECUTE_RESPONSE, new TaskResponseProcessor()); this.nettyRemotingServer.registerProcessor(CommandType.TASK_EXECUTE_ACK, new TaskAckProcessor()); this.nettyRemotingServer.registerProcessor(CommandType.TASK_KILL_RESPONSE, new TaskKillResponseProcessor()); this.nettyRemotingServer.start(); this.zkMasterClient.start(); this.zkMasterClient.setStoppable(this); this.masterSchedulerService.start(); try {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
logger.info("start Quartz server..."); QuartzExecutors.getInstance().start(); } catch (Exception e) { try { QuartzExecutors.getInstance().shutdown(); } catch (SchedulerException e1) { logger.error("QuartzExecutors shutdown failed : " + e1.getMessage(), e1); } logger.error("start Quartz failed", e); } /** * register hooks, which are called before the process exits */ Runtime.getRuntime().addShutdownHook(new Thread(() -> { if (Stopper.isRunning()) { close("shutdownHook"); } })); } /** * gracefully close * * @param cause close cause */ public void close(String cause) { try { if (Stopper.isStopped()) { return; }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
logger.info("master server is stopping ..., cause : {}", cause); Stopper.stop(); try { Thread.sleep(3000L); } catch (Exception e) { logger.warn("thread sleep exception ", e); } this.masterSchedulerService.close(); this.nettyRemotingServer.close(); this.zkMasterClient.close(); try { QuartzExecutors.getInstance().shutdown(); logger.info("Quartz service stopped"); } catch (Exception e) { logger.warn("Quartz service stopped exception:{}", e.getMessage()); } } catch (Exception e) { logger.error("master server stop exception ", e); } } @Override public void stop(String cause) { close(cause); } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/bean/SpringApplicationContext.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.service.bean; import org.springframework.beans.BeansException; import org.springframework.context.ApplicationContext; import org.springframework.context.ApplicationContextAware; import org.springframework.stereotype.Component; @Component
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/bean/SpringApplicationContext.java
public class SpringApplicationContext implements ApplicationContextAware { private static ApplicationContext applicationContext; @Override public void setApplicationContext(ApplicationContext applicationContext) throws BeansException { SpringApplicationContext.applicationContext = applicationContext; } public static <T> T getBean(Class<T> requiredType) { return applicationContext.getBean(requiredType); } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/CuratorZookeeperClient.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.service.zk; import static org.apache.dolphinscheduler.common.utils.Preconditions.checkNotNull;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/CuratorZookeeperClient.java
import org.apache.dolphinscheduler.common.utils.StringUtils; import org.apache.dolphinscheduler.service.exceptions.ServiceException; import org.apache.curator.framework.CuratorFramework; import org.apache.curator.framework.CuratorFrameworkFactory; import org.apache.curator.framework.api.ACLProvider; import org.apache.curator.framework.state.ConnectionState; import org.apache.curator.retry.ExponentialBackoffRetry; import org.apache.zookeeper.ZooDefs; import org.apache.zookeeper.data.ACL; import java.nio.charset.StandardCharsets; import java.util.List; import java.util.concurrent.TimeUnit; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.InitializingBean; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Component; /** * Shared Curator zookeeper client */ @Component public class CuratorZookeeperClient implements InitializingBean { private final Logger logger = LoggerFactory.getLogger(CuratorZookeeperClient.class); @Autowired private ZookeeperConfig zookeeperConfig; private CuratorFramework zkClient; @Override public void afterPropertiesSet() throws Exception { this.zkClient = buildClient(); initStateLister();
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/CuratorZookeeperClient.java
} private CuratorFramework buildClient() { logger.info("zookeeper registry center init, server lists is: [{}]", zookeeperConfig.getServerList()); CuratorFrameworkFactory.Builder builder = CuratorFrameworkFactory.builder() .ensembleProvider(new DefaultEnsembleProvider(checkNotNull(zookeeperConfig.getServerList(), "zookeeper quorum can't be null"))) .retryPolicy(new ExponentialBackoffRetry(zookeeperConfig.getBaseSleepTimeMs(), zookeeperConfig.getMaxRetries(), zookeeperConfig.getMaxSleepMs())); if (0 != zookeeperConfig.getSessionTimeoutMs()) { builder.sessionTimeoutMs(zookeeperConfig.getSessionTimeoutMs()); } if (0 != zookeeperConfig.getConnectionTimeoutMs()) { builder.connectionTimeoutMs(zookeeperConfig.getConnectionTimeoutMs()); } if (StringUtils.isNotBlank(zookeeperConfig.getDigest())) { builder.authorization("digest", zookeeperConfig.getDigest().getBytes(StandardCharsets.UTF_8)).aclProvider(new ACLProvider() { @Override public List<ACL> getDefaultAcl() { return ZooDefs.Ids.CREATOR_ALL_ACL; } @Override public List<ACL> getAclForPath(final String path) { return ZooDefs.Ids.CREATOR_ALL_ACL; } }); } zkClient = builder.build(); zkClient.start(); try { logger.info("trying to connect zookeeper server list:{}", zookeeperConfig.getServerList()); zkClient.blockUntilConnected(30, TimeUnit.SECONDS);
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,559
[Bug][Master Server] Master Server was shutdown but the process still in system
Master Server was shutdown but the process still in system when i restart zookeeper cluster version:1.3.6 1.stop all the zookeeper servers , then start. 2. use jps command,will find the Master Server process 3. the dolphinscheduler-master log: scheduler DolphinScheduler_$_slave.. shutdown complete. Quartz service stopped, and halt all task Quartz service stopped
https://github.com/apache/dolphinscheduler/issues/5559
https://github.com/apache/dolphinscheduler/pull/5588
87604b7a3df17dcfc5cc9087340d06b0d8930ddc
75be09735a29469ef5169550239c65a5a27af3ba
"2021-05-31T09:40:24Z"
java
"2021-06-04T05:27:18Z"
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/CuratorZookeeperClient.java
} catch (final Exception ex) { throw new ServiceException(ex); } return zkClient; } public void initStateLister() { checkNotNull(zkClient); zkClient.getConnectionStateListenable().addListener((client, newState) -> { if (newState == ConnectionState.LOST) { logger.error("connection lost from zookeeper"); } else if (newState == ConnectionState.RECONNECTED) { logger.info("reconnected to zookeeper"); } else if (newState == ConnectionState.SUSPENDED) { logger.warn("connection SUSPENDED to zookeeper"); } else if (newState == ConnectionState.CONNECTED) { logger.info("connected to zookeeper server list:[{}]", zookeeperConfig.getServerList()); } }); } public ZookeeperConfig getZookeeperConfig() { return zookeeperConfig; } public void setZookeeperConfig(ZookeeperConfig zookeeperConfig) { this.zookeeperConfig = zookeeperConfig; } public CuratorFramework getZkClient() { return zkClient; } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.common; import org.apache.dolphinscheduler.common.enums.ExecutionStatus; import org.apache.dolphinscheduler.common.utils.OSUtils; import org.apache.dolphinscheduler.common.utils.StringUtils; import java.util.regex.Pattern; /** * Constants */ public final class Constants {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
private Constants() { throw new UnsupportedOperationException("Construct Constants"); } /** * quartz config */ public static final String ORG_QUARTZ_JOBSTORE_DRIVERDELEGATECLASS = "org.quartz.jobStore.driverDelegateClass"; public static final String ORG_QUARTZ_SCHEDULER_INSTANCENAME = "org.quartz.scheduler.instanceName"; public static final String ORG_QUARTZ_SCHEDULER_INSTANCEID = "org.quartz.scheduler.instanceId"; public static final String ORG_QUARTZ_SCHEDULER_MAKESCHEDULERTHREADDAEMON = "org.quartz.scheduler.makeSchedulerThreadDaemon"; public static final String ORG_QUARTZ_JOBSTORE_USEPROPERTIES = "org.quartz.jobStore.useProperties"; public static final String ORG_QUARTZ_THREADPOOL_CLASS = "org.quartz.threadPool.class"; public static final String ORG_QUARTZ_THREADPOOL_THREADCOUNT = "org.quartz.threadPool.threadCount"; public static final String ORG_QUARTZ_THREADPOOL_MAKETHREADSDAEMONS = "org.quartz.threadPool.makeThreadsDaemons"; public static final String ORG_QUARTZ_THREADPOOL_THREADPRIORITY = "org.quartz.threadPool.threadPriority"; public static final String ORG_QUARTZ_JOBSTORE_CLASS = "org.quartz.jobStore.class"; public static final String ORG_QUARTZ_JOBSTORE_TABLEPREFIX = "org.quartz.jobStore.tablePrefix"; public static final String ORG_QUARTZ_JOBSTORE_ISCLUSTERED = "org.quartz.jobStore.isClustered"; public static final String ORG_QUARTZ_JOBSTORE_MISFIRETHRESHOLD = "org.quartz.jobStore.misfireThreshold"; public static final String ORG_QUARTZ_JOBSTORE_CLUSTERCHECKININTERVAL = "org.quartz.jobStore.clusterCheckinInterval"; public static final String ORG_QUARTZ_JOBSTORE_ACQUIRETRIGGERSWITHINLOCK = "org.quartz.jobStore.acquireTriggersWithinLock"; public static final String ORG_QUARTZ_JOBSTORE_DATASOURCE = "org.quartz.jobStore.dataSource"; public static final String ORG_QUARTZ_DATASOURCE_MYDS_CONNECTIONPROVIDER_CLASS = "org.quartz.dataSource.myDs.connectionProvider.class";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
/** * quartz config default value */ public static final String QUARTZ_TABLE_PREFIX = "QRTZ_"; public static final String QUARTZ_MISFIRETHRESHOLD = "60000"; public static final String QUARTZ_CLUSTERCHECKININTERVAL = "5000"; public static final String QUARTZ_DATASOURCE = "myDs"; public static final String QUARTZ_THREADCOUNT = "25"; public static final String QUARTZ_THREADPRIORITY = "5"; public static final String QUARTZ_INSTANCENAME = "DolphinScheduler"; public static final String QUARTZ_INSTANCEID = "AUTO"; public static final String QUARTZ_ACQUIRETRIGGERSWITHINLOCK = "true"; /** * common properties path */ public static final String COMMON_PROPERTIES_PATH = "/common.properties"; /** * fs.defaultFS */ public static final String FS_DEFAULTFS = "fs.defaultFS"; /** * fs s3a endpoint */ public static final String FS_S3A_ENDPOINT = "fs.s3a.endpoint"; /** * fs s3a access key */ public static final String FS_S3A_ACCESS_KEY = "fs.s3a.access.key"; /** * fs s3a secret key
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
*/ public static final String FS_S3A_SECRET_KEY = "fs.s3a.secret.key"; /** * hadoop configuration */ public static final String HADOOP_RM_STATE_ACTIVE = "ACTIVE"; public static final String HADOOP_RM_STATE_STANDBY = "STANDBY"; public static final String HADOOP_RESOURCE_MANAGER_HTTPADDRESS_PORT = "resource.manager.httpaddress.port"; /** * yarn.resourcemanager.ha.rm.ids */ public static final String YARN_RESOURCEMANAGER_HA_RM_IDS = "yarn.resourcemanager.ha.rm.ids"; /** * yarn.application.status.address */ public static final String YARN_APPLICATION_STATUS_ADDRESS = "yarn.application.status.address"; /** * yarn.job.history.status.address */ public static final String YARN_JOB_HISTORY_STATUS_ADDRESS = "yarn.job.history.status.address"; /** * hdfs configuration * hdfs.root.user */ public static final String HDFS_ROOT_USER = "hdfs.root.user"; /** * hdfs/s3 configuration * resource.upload.path */ public static final String RESOURCE_UPLOAD_PATH = "resource.upload.path";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
/** * data basedir path */ public static final String DATA_BASEDIR_PATH = "data.basedir.path"; /** * dolphinscheduler.env.path */ public static final String DOLPHINSCHEDULER_ENV_PATH = "dolphinscheduler.env.path"; /** * environment properties default path */ public static final String ENV_PATH = "env/dolphinscheduler_env.sh"; /** * python home */ public static final String PYTHON_HOME = "PYTHON_HOME"; /** * resource.view.suffixs */ public static final String RESOURCE_VIEW_SUFFIXS = "resource.view.suffixs"; public static final String RESOURCE_VIEW_SUFFIXS_DEFAULT_VALUE = "txt,log,sh,bat,conf,cfg,py,java,sql,xml,hql,properties,json,yml,yaml,ini,js"; /** * development.state */ public static final String DEVELOPMENT_STATE = "development.state"; /** * sudo enable */ public static final String SUDO_ENABLE = "sudo.enable"; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* string true */ public static final String STRING_TRUE = "true"; /** * string false */ public static final String STRING_FALSE = "false"; /** * resource storage type */ public static final String RESOURCE_STORAGE_TYPE = "resource.storage.type"; /** * MasterServer directory registered in zookeeper */ public static final String ZOOKEEPER_DOLPHINSCHEDULER_MASTERS = "/nodes/master"; /** * WorkerServer directory registered in zookeeper */ public static final String ZOOKEEPER_DOLPHINSCHEDULER_WORKERS = "/nodes/worker"; /** * all servers directory registered in zookeeper */ public static final String ZOOKEEPER_DOLPHINSCHEDULER_DEAD_SERVERS = "/dead-servers"; /** * MasterServer lock directory registered in zookeeper */ public static final String ZOOKEEPER_DOLPHINSCHEDULER_LOCK_MASTERS = "/lock/masters"; /** * MasterServer failover directory registered in zookeeper */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String ZOOKEEPER_DOLPHINSCHEDULER_LOCK_FAILOVER_MASTERS = "/lock/failover/masters"; /** * WorkerServer failover directory registered in zookeeper */ public static final String ZOOKEEPER_DOLPHINSCHEDULER_LOCK_FAILOVER_WORKERS = "/lock/failover/workers"; /** * MasterServer startup failover runing and fault tolerance process */ public static final String ZOOKEEPER_DOLPHINSCHEDULER_LOCK_FAILOVER_STARTUP_MASTERS = "/lock/failover/startup-masters"; /** * comma , */ public static final String COMMA = ","; /** * slash / */ public static final String SLASH = "/"; /** * COLON : */ public static final String COLON = ":"; /** * SPACE " " */ public static final String SPACE = " "; /** * SINGLE_SLASH / */ public static final String SINGLE_SLASH = "/"; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* DOUBLE_SLASH // */ public static final String DOUBLE_SLASH = "//"; /** * SINGLE_QUOTES "'" */ public static final String SINGLE_QUOTES = "'"; /** * DOUBLE_QUOTES "\"" */ public static final String DOUBLE_QUOTES = "\""; /** * SEMICOLON ; */ public static final String SEMICOLON = ";"; /** * EQUAL SIGN */ public static final String EQUAL_SIGN = "="; /** * AT SIGN */ public static final String AT_SIGN = "@"; /** * date format of yyyy-MM-dd HH:mm:ss */ public static final String YYYY_MM_DD_HH_MM_SS = "yyyy-MM-dd HH:mm:ss"; /** * date format of yyyyMMddHHmmss */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String YYYYMMDDHHMMSS = "yyyyMMddHHmmss"; /** * date format of yyyyMMddHHmmssSSS */ public static final String YYYYMMDDHHMMSSSSS = "yyyyMMddHHmmssSSS"; /** * http connect time out */ public static final int HTTP_CONNECT_TIMEOUT = 60 * 1000; /** * http connect request time out */ public static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 60 * 1000; /** * httpclient soceket time out */ public static final int SOCKET_TIMEOUT = 60 * 1000; /** * http header */ public static final String HTTP_HEADER_UNKNOWN = "unKnown"; /** * http X-Forwarded-For */ public static final String HTTP_X_FORWARDED_FOR = "X-Forwarded-For"; /** * http X-Real-IP */ public static final String HTTP_X_REAL_IP = "X-Real-IP"; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* UTF-8 */ public static final String UTF_8 = "UTF-8"; /** * user name regex */ public static final Pattern REGEX_USER_NAME = Pattern.compile("^[a-zA-Z0-9._-]{3,39}$"); /** * email regex */ public static final Pattern REGEX_MAIL_NAME = Pattern.compile("^([a-z0-9A-Z]+[_|\\-|\\.]?)+[a-z0-9A-Z]@([a-z0-9A-Z]+(-[a-z0-9A-Z]+)?\\.)+[a-zA-Z]{2,}$"); /** * default display rows */ public static final int DEFAULT_DISPLAY_ROWS = 10; /** * read permission */ public static final int READ_PERMISSION = 2 * 1; /** * write permission */ public static final int WRITE_PERMISSION = 2 * 2; /** * execute permission */ public static final int EXECUTE_PERMISSION = 1; /** * default admin permission */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final int DEFAULT_ADMIN_PERMISSION = 7; /** * all permissions */ public static final int ALL_PERMISSIONS = READ_PERMISSION | WRITE_PERMISSION | EXECUTE_PERMISSION; /** * max task timeout */ public static final int MAX_TASK_TIMEOUT = 24 * 3600; /** * master cpu load */ public static final int DEFAULT_MASTER_CPU_LOAD = Runtime.getRuntime().availableProcessors() * 2; /** * worker cpu load */ public static final int DEFAULT_WORKER_CPU_LOAD = Runtime.getRuntime().availableProcessors() * 2; /** * worker host weight */ public static final int DEFAULT_WORKER_HOST_WEIGHT = 100; /** * default log cache rows num,output when reach the number */ public static final int DEFAULT_LOG_ROWS_NUM = 4 * 16; /** * log flush interval?output when reach the interval */ public static final int DEFAULT_LOG_FLUSH_INTERVAL = 1000; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* time unit secong to minutes */ public static final int SEC_2_MINUTES_TIME_UNIT = 60; /*** * * rpc port */ public static final int RPC_PORT = 50051; /*** * alert rpc port */ public static final int ALERT_RPC_PORT = 50052; /** * forbid running task */ public static final String FLOWNODE_RUN_FLAG_FORBIDDEN = "FORBIDDEN"; /** * normal running task */ public static final String FLOWNODE_RUN_FLAG_NORMAL = "NORMAL"; /** * datasource configuration path */ public static final String DATASOURCE_PROPERTIES = "/datasource.properties"; public static final String DEFAULT = "Default"; public static final String USER = "user"; public static final String PASSWORD = "password"; public static final String XXXXXX = "******"; public static final String NULL = "NULL"; public static final String THREAD_NAME_MASTER_SERVER = "Master-Server";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String THREAD_NAME_WORKER_SERVER = "Worker-Server"; /** * command parameter keys */ public static final String CMD_PARAM_RECOVER_PROCESS_ID_STRING = "ProcessInstanceId"; public static final String CMD_PARAM_RECOVERY_START_NODE_STRING = "StartNodeIdList"; public static final String CMD_PARAM_RECOVERY_WAITING_THREAD = "WaitingThreadInstanceId"; public static final String CMD_PARAM_SUB_PROCESS = "processInstanceId"; public static final String CMD_PARAM_EMPTY_SUB_PROCESS = "0"; public static final String CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID = "parentProcessInstanceId"; public static final String CMD_PARAM_SUB_PROCESS_DEFINE_ID = "processDefinitionId"; public static final String CMD_PARAM_START_NODE_NAMES = "StartNodeNameList"; public static final String CMD_PARAM_START_PARAMS = "StartParams"; public static final String CMD_PARAM_FATHER_PARAMS = "fatherParams"; /** * complement data start date */ public static final String CMDPARAM_COMPLEMENT_DATA_START_DATE = "complementStartDate"; /** * complement data end date */ public static final String CMDPARAM_COMPLEMENT_DATA_END_DATE = "complementEndDate"; /** * data source config */ public static final String SPRING_DATASOURCE_DRIVER_CLASS_NAME = "spring.datasource.driver-class-name"; public static final String SPRING_DATASOURCE_URL = "spring.datasource.url"; public static final String SPRING_DATASOURCE_USERNAME = "spring.datasource.username"; public static final String SPRING_DATASOURCE_PASSWORD = "spring.datasource.password"; public static final String SPRING_DATASOURCE_VALIDATION_QUERY_TIMEOUT = "spring.datasource.validationQueryTimeout";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String SPRING_DATASOURCE_INITIAL_SIZE = "spring.datasource.initialSize"; public static final String SPRING_DATASOURCE_MIN_IDLE = "spring.datasource.minIdle"; public static final String SPRING_DATASOURCE_MAX_ACTIVE = "spring.datasource.maxActive"; public static final String SPRING_DATASOURCE_MAX_WAIT = "spring.datasource.maxWait"; public static final String SPRING_DATASOURCE_TIME_BETWEEN_EVICTION_RUNS_MILLIS = "spring.datasource.timeBetweenEvictionRunsMillis"; public static final String SPRING_DATASOURCE_TIME_BETWEEN_CONNECT_ERROR_MILLIS = "spring.datasource.timeBetweenConnectErrorMillis"; public static final String SPRING_DATASOURCE_MIN_EVICTABLE_IDLE_TIME_MILLIS = "spring.datasource.minEvictableIdleTimeMillis"; public static final String SPRING_DATASOURCE_VALIDATION_QUERY = "spring.datasource.validationQuery"; public static final String SPRING_DATASOURCE_TEST_WHILE_IDLE = "spring.datasource.testWhileIdle"; public static final String SPRING_DATASOURCE_TEST_ON_BORROW = "spring.datasource.testOnBorrow"; public static final String SPRING_DATASOURCE_TEST_ON_RETURN = "spring.datasource.testOnReturn"; public static final String SPRING_DATASOURCE_POOL_PREPARED_STATEMENTS = "spring.datasource.poolPreparedStatements"; public static final String SPRING_DATASOURCE_DEFAULT_AUTO_COMMIT = "spring.datasource.defaultAutoCommit"; public static final String SPRING_DATASOURCE_KEEP_ALIVE = "spring.datasource.keepAlive"; public static final String SPRING_DATASOURCE_MAX_POOL_PREPARED_STATEMENT_PER_CONNECTION_SIZE = "spring.datasource.maxPoolPreparedStatementPerConnectionSize"; public static final String DEVELOPMENT = "development"; public static final String QUARTZ_PROPERTIES_PATH = "quartz.properties"; /** * sleep time */ public static final int SLEEP_TIME_MILLIS = 1000; /** * heartbeat for zk info length */ public static final int HEARTBEAT_FOR_ZOOKEEPER_INFO_LENGTH = 10; public static final int HEARTBEAT_WITH_WEIGHT_FOR_ZOOKEEPER_INFO_LENGTH = 11; /** * jar */ public static final String JAR = "jar";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
/** * hadoop */ public static final String HADOOP = "hadoop"; /** * -D <property>=<value> */ public static final String D = "-D"; /** * -D mapreduce.job.name=name */ public static final String MR_NAME = "mapreduce.job.name"; /** * -D mapreduce.job.queuename=queuename */ public static final String MR_QUEUE = "mapreduce.job.queuename"; /** * spark params constant */ public static final String MASTER = "--master"; public static final String DEPLOY_MODE = "--deploy-mode"; /** * --class CLASS_NAME */ public static final String MAIN_CLASS = "--class"; /** * --driver-cores NUM */ public static final String DRIVER_CORES = "--driver-cores"; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* --driver-memory MEM */ public static final String DRIVER_MEMORY = "--driver-memory"; /** * --num-executors NUM */ public static final String NUM_EXECUTORS = "--num-executors"; /** * --executor-cores NUM */ public static final String EXECUTOR_CORES = "--executor-cores"; /** * --executor-memory MEM */ public static final String EXECUTOR_MEMORY = "--executor-memory"; /** * --name NAME */ public static final String SPARK_NAME = "--name"; /** * --queue QUEUE */ public static final String SPARK_QUEUE = "--queue"; /** * exit code success */ public static final int EXIT_CODE_SUCCESS = 0; /** * exit code kill */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final int EXIT_CODE_KILL = 137; /** * exit code failure */ public static final int EXIT_CODE_FAILURE = -1; /** * process or task definition failure */ public static final int DEFINITION_FAILURE = -1; /** * date format of yyyyMMdd */ public static final String PARAMETER_FORMAT_DATE = "yyyyMMdd"; /** * date format of yyyyMMddHHmmss */ public static final String PARAMETER_FORMAT_TIME = "yyyyMMddHHmmss"; /** * system date(yyyyMMddHHmmss) */ public static final String PARAMETER_DATETIME = "system.datetime"; /** * system date(yyyymmdd) today */ public static final String PARAMETER_CURRENT_DATE = "system.biz.curdate"; /** * system date(yyyymmdd) yesterday */ public static final String PARAMETER_BUSINESS_DATE = "system.biz.date"; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* ACCEPTED */ public static final String ACCEPTED = "ACCEPTED"; /** * SUCCEEDED */ public static final String SUCCEEDED = "SUCCEEDED"; /** * NEW */ public static final String NEW = "NEW"; /** * NEW_SAVING */ public static final String NEW_SAVING = "NEW_SAVING"; /** * SUBMITTED */ public static final String SUBMITTED = "SUBMITTED"; /** * FAILED */ public static final String FAILED = "FAILED"; /** * KILLED */ public static final String KILLED = "KILLED"; /** * RUNNING */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String RUNNING = "RUNNING"; /** * underline "_" */ public static final String UNDERLINE = "_"; /** * quartz job prifix */ public static final String QUARTZ_JOB_PRIFIX = "job"; /** * quartz job group prifix */ public static final String QUARTZ_JOB_GROUP_PRIFIX = "jobgroup"; /** * projectId */ public static final String PROJECT_ID = "projectId"; /** * processId */ public static final String SCHEDULE_ID = "scheduleId"; /** * schedule */ public static final String SCHEDULE = "schedule"; /** * application regex */ public static final String APPLICATION_REGEX = "application_\\d+_\\d+"; public static final String PID = OSUtils.isWindows() ? "handle" : "pid";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
/** * month_begin */ public static final String MONTH_BEGIN = "month_begin"; /** * add_months */ public static final String ADD_MONTHS = "add_months"; /** * month_end */ public static final String MONTH_END = "month_end"; /** * week_begin */ public static final String WEEK_BEGIN = "week_begin"; /** * week_end */ public static final String WEEK_END = "week_end"; /** * timestamp */ public static final String TIMESTAMP = "timestamp"; public static final char SUBTRACT_CHAR = '-'; public static final char ADD_CHAR = '+'; public static final char MULTIPLY_CHAR = '*'; public static final char DIVISION_CHAR = '/'; public static final char LEFT_BRACE_CHAR = '('; public static final char RIGHT_BRACE_CHAR = ')';
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String ADD_STRING = "+"; public static final String MULTIPLY_STRING = "*"; public static final String DIVISION_STRING = "/"; public static final String LEFT_BRACE_STRING = "("; public static final char P = 'P'; public static final char N = 'N'; public static final String SUBTRACT_STRING = "-"; public static final String GLOBAL_PARAMS = "globalParams"; public static final String LOCAL_PARAMS = "localParams"; public static final String LOCAL_PARAMS_LIST = "localParamsList"; public static final String SUBPROCESS_INSTANCE_ID = "subProcessInstanceId"; public static final String PROCESS_INSTANCE_STATE = "processInstanceState"; public static final String PARENT_WORKFLOW_INSTANCE = "parentWorkflowInstance"; public static final String CONDITION_RESULT = "conditionResult"; public static final String DEPENDENCE = "dependence"; public static final String TASK_TYPE = "taskType"; public static final String TASK_LIST = "taskList"; public static final String RWXR_XR_X = "rwxr-xr-x"; public static final String QUEUE = "queue"; public static final String QUEUE_NAME = "queueName"; public static final int LOG_QUERY_SKIP_LINE_NUMBER = 0; public static final int LOG_QUERY_LIMIT = 4096; /** * master/worker server use for zk */ public static final String MASTER_TYPE = "master"; public static final String WORKER_TYPE = "worker"; public static final String DELETE_ZK_OP = "delete"; public static final String ADD_ZK_OP = "add"; public static final String ALIAS = "alias";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String CONTENT = "content"; public static final String DEPENDENT_SPLIT = ":||"; public static final String DEPENDENT_ALL = "ALL"; /** * preview schedule execute count */ public static final int PREVIEW_SCHEDULE_EXECUTE_COUNT = 5; /** * kerberos */ public static final String KERBEROS = "kerberos"; /** * kerberos expire time */ public static final String KERBEROS_EXPIRE_TIME = "kerberos.expire.time"; /** * java.security.krb5.conf */ public static final String JAVA_SECURITY_KRB5_CONF = "java.security.krb5.conf"; /** * java.security.krb5.conf.path */ public static final String JAVA_SECURITY_KRB5_CONF_PATH = "java.security.krb5.conf.path"; /** * hadoop.security.authentication */ public static final String HADOOP_SECURITY_AUTHENTICATION = "hadoop.security.authentication"; /** * hadoop.security.authentication */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String HADOOP_SECURITY_AUTHENTICATION_STARTUP_STATE = "hadoop.security.authentication.startup.state"; /** * com.amazonaws.services.s3.enableV4 */ public static final String AWS_S3_V4 = "com.amazonaws.services.s3.enableV4"; /** * loginUserFromKeytab user */ public static final String LOGIN_USER_KEY_TAB_USERNAME = "login.user.keytab.username"; /** * loginUserFromKeytab path */ public static final String LOGIN_USER_KEY_TAB_PATH = "login.user.keytab.path"; /** * task log info format */ public static final String TASK_LOG_INFO_FORMAT = "TaskLogInfo-%s"; /** * hive conf */ public static final String HIVE_CONF = "hiveconf:"; /** * flink */ public static final String FLINK_YARN_CLUSTER = "yarn-cluster"; public static final String FLINK_RUN_MODE = "-m"; public static final String FLINK_YARN_SLOT = "-ys"; public static final String FLINK_APP_NAME = "-ynm"; public static final String FLINK_QUEUE = "-yqu"; public static final String FLINK_TASK_MANAGE = "-yn";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String FLINK_JOB_MANAGE_MEM = "-yjm"; public static final String FLINK_TASK_MANAGE_MEM = "-ytm"; public static final String FLINK_MAIN_CLASS = "-c"; public static final String FLINK_PARALLELISM = "-p"; public static final String FLINK_SHUTDOWN_ON_ATTACHED_EXIT = "-sae"; public static final int[] NOT_TERMINATED_STATES = new int[] { ExecutionStatus.SUBMITTED_SUCCESS.ordinal(), ExecutionStatus.RUNNING_EXECUTION.ordinal(), ExecutionStatus.DELAY_EXECUTION.ordinal(), ExecutionStatus.READY_PAUSE.ordinal(), ExecutionStatus.READY_STOP.ordinal(), ExecutionStatus.NEED_FAULT_TOLERANCE.ordinal(), ExecutionStatus.WAITTING_THREAD.ordinal(), ExecutionStatus.WAITTING_DEPEND.ordinal() }; /** * status */ public static final String STATUS = "status"; /** * message */ public static final String MSG = "msg"; /** * data total */ public static final String COUNT = "count"; /** * page size */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String PAGE_SIZE = "pageSize"; /** * current page no */ public static final String PAGE_NUMBER = "pageNo"; /** * */ public static final String DATA_LIST = "data"; public static final String TOTAL_LIST = "totalList"; public static final String CURRENT_PAGE = "currentPage"; public static final String TOTAL_PAGE = "totalPage"; public static final String TOTAL = "total"; /** * workflow */ public static final String WORKFLOW_LIST = "workFlowList"; public static final String WORKFLOW_RELATION_LIST = "workFlowRelationList"; /** * session user */ public static final String SESSION_USER = "session.user"; public static final String SESSION_ID = "sessionId"; public static final String PASSWORD_DEFAULT = "******"; /** * locale */ public static final String LOCALE_LANGUAGE = "language"; /** * driver
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
*/ public static final String ORG_POSTGRESQL_DRIVER = "org.postgresql.Driver"; public static final String COM_MYSQL_JDBC_DRIVER = "com.mysql.jdbc.Driver"; public static final String ORG_APACHE_HIVE_JDBC_HIVE_DRIVER = "org.apache.hive.jdbc.HiveDriver"; public static final String COM_CLICKHOUSE_JDBC_DRIVER = "ru.yandex.clickhouse.ClickHouseDriver"; public static final String COM_ORACLE_JDBC_DRIVER = "oracle.jdbc.driver.OracleDriver"; public static final String COM_SQLSERVER_JDBC_DRIVER = "com.microsoft.sqlserver.jdbc.SQLServerDriver"; public static final String COM_DB2_JDBC_DRIVER = "com.ibm.db2.jcc.DB2Driver"; public static final String COM_PRESTO_JDBC_DRIVER = "com.facebook.presto.jdbc.PrestoDriver"; /** * database type */ public static final String MYSQL = "MYSQL"; public static final String POSTGRESQL = "POSTGRESQL"; public static final String HIVE = "HIVE"; public static final String SPARK = "SPARK"; public static final String CLICKHOUSE = "CLICKHOUSE"; public static final String ORACLE = "ORACLE"; public static final String SQLSERVER = "SQLSERVER"; public static final String DB2 = "DB2"; public static final String PRESTO = "PRESTO"; /** * jdbc url */ public static final String JDBC_MYSQL = "jdbc:mysql://"; public static final String JDBC_POSTGRESQL = "jdbc:postgresql://"; public static final String JDBC_HIVE_2 = "jdbc:hive2://"; public static final String JDBC_CLICKHOUSE = "jdbc:clickhouse://"; public static final String JDBC_ORACLE_SID = "jdbc:oracle:thin:@"; public static final String JDBC_ORACLE_SERVICE_NAME = "jdbc:oracle:thin:@//";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String JDBC_SQLSERVER = "jdbc:sqlserver://"; public static final String JDBC_DB2 = "jdbc:db2://"; public static final String JDBC_PRESTO = "jdbc:presto://"; public static final String ADDRESS = "address"; public static final String DATABASE = "database"; public static final String JDBC_URL = "jdbcUrl"; public static final String PRINCIPAL = "principal"; public static final String OTHER = "other"; public static final String ORACLE_DB_CONNECT_TYPE = "connectType"; public static final String KERBEROS_KRB5_CONF_PATH = "javaSecurityKrb5Conf"; public static final String KERBEROS_KEY_TAB_USERNAME = "loginUserKeytabUsername"; public static final String KERBEROS_KEY_TAB_PATH = "loginUserKeytabPath"; /** * session timeout */ public static final int SESSION_TIME_OUT = 7200; public static final int MAX_FILE_SIZE = 1024 * 1024 * 1024; public static final String UDF = "UDF"; public static final String CLASS = "class"; public static final String RECEIVERS = "receivers"; public static final String RECEIVERS_CC = "receiversCc"; /** * dataSource sensitive param */ public static final String DATASOURCE_PASSWORD_REGEX = "(?<=(\"password\":\")).*?(?=(\"))"; /** * default worker group */ public static final String DEFAULT_WORKER_GROUP = "default"; public static final Integer TASK_INFO_LENGTH = 5;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
/** * new * schedule time */ public static final String PARAMETER_SHECDULE_TIME = "schedule.time"; /** * authorize writable perm */ public static final int AUTHORIZE_WRITABLE_PERM = 7; /** * authorize readable perm */ public static final int AUTHORIZE_READABLE_PERM = 4; /** * plugin configurations */ public static final String PLUGIN_JAR_SUFFIX = ".jar"; public static final int NORMAL_NODE_STATUS = 0; public static final int ABNORMAL_NODE_STATUS = 1; public static final String START_TIME = "start time"; public static final String END_TIME = "end time"; public static final String START_END_DATE = "startDate,endDate"; /** * system line separator */ public static final String SYSTEM_LINE_SEPARATOR = System.getProperty("line.separator"); /** * net system properties */ public static final String DOLPHIN_SCHEDULER_PREFERRED_NETWORK_INTERFACE = "dolphin.scheduler.network.interface.preferred";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String EXCEL_SUFFIX_XLS = ".xls"; /** * datasource encryption salt */ public static final String DATASOURCE_ENCRYPTION_SALT_DEFAULT = "!@#$%^&*"; public static final String DATASOURCE_ENCRYPTION_ENABLE = "datasource.encryption.enable"; public static final String DATASOURCE_ENCRYPTION_SALT = "datasource.encryption.salt"; /** * Network IP gets priority, default inner outer */ public static final String NETWORK_PRIORITY_STRATEGY = "dolphin.scheduler.network.priority.strategy"; /** * exec shell scripts */ public static final String SH = "sh"; /** * pstree, get pud and sub pid */ public static final String PSTREE = "pstree"; /** * snow flake, data center id, this id must be greater than 0 and less than 32 */ public static final String SNOW_FLAKE_DATA_CENTER_ID = "data.center.id"; /** * docker & kubernetes */ public static final boolean DOCKER_MODE = StringUtils.isNotEmpty(System.getenv("DOCKER")); public static final boolean KUBERNETES_MODE = StringUtils.isNotEmpty(System.getenv("KUBERNETES_SERVICE_HOST")) && StringUtils.isNotEmpty(System.getenv("KUBERNETES_SERVICE_PORT")); }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.common.utils; import static org.apache.dolphinscheduler.common.Constants.DOLPHIN_SCHEDULER_PREFERRED_NETWORK_INTERFACE; import static java.util.Collections.emptyList; import org.apache.dolphinscheduler.common.Constants; import java.io.IOException; import java.net.Inet6Address; import java.net.InetAddress; import java.net.NetworkInterface; import java.net.SocketException; import java.net.UnknownHostException;
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
import java.util.Enumeration; import java.util.LinkedList; import java.util.List; import java.util.Objects; import java.util.Optional; import java.util.regex.Pattern; import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** * NetUtils */ public class NetUtils { private static final Pattern IP_PATTERN = Pattern.compile("\\d{1,3}(\\.\\d{1,3}){3,5}$"); private static final String NETWORK_PRIORITY_DEFAULT = "default"; private static final String NETWORK_PRIORITY_INNER = "inner"; private static final String NETWORK_PRIORITY_OUTER = "outer"; private static final Logger logger = LoggerFactory.getLogger(NetUtils.class); private static InetAddress LOCAL_ADDRESS = null; private static volatile String HOST_ADDRESS; private NetUtils() { throw new UnsupportedOperationException("Construct NetUtils"); } /** * get addr like host:port * @return addr */ public static String getAddr(String host, int port) { return String.format("%s:%d", host, port); } /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
* get addr like host:port * @return addr */ public static String getAddr(int port) { return getAddr(getHost(), port); } /** * get host * @return host */ public static String getHost(InetAddress inetAddress) { if (inetAddress != null) { if (Constants.KUBERNETES_MODE) { String canonicalHost = inetAddress.getCanonicalHostName(); String[] items = canonicalHost.split("\\."); if (items.length == 6 && "svc".equals(items[3])) { return String.format("%s.%s", items[0], items[1]); } return canonicalHost; } return inetAddress.getHostAddress(); } return null; } public static String getHost() { if (HOST_ADDRESS != null) { return HOST_ADDRESS; } InetAddress address = getLocalAddress(); if (address != null) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
HOST_ADDRESS = getHost(address); return HOST_ADDRESS; } return Constants.KUBERNETES_MODE ? "localhost" : "127.0.0.1"; } private static InetAddress getLocalAddress() { if (null != LOCAL_ADDRESS) { return LOCAL_ADDRESS; } return getLocalAddress0(); } /** * Find first valid IP from local network card * * @return first valid local IP */ private static synchronized InetAddress getLocalAddress0() { if (null != LOCAL_ADDRESS) { return LOCAL_ADDRESS; } InetAddress localAddress = null; try { NetworkInterface networkInterface = findNetworkInterface(); if (networkInterface != null) { Enumeration<InetAddress> addresses = networkInterface.getInetAddresses(); while (addresses.hasMoreElements()) { Optional<InetAddress> addressOp = toValidAddress(addresses.nextElement()); if (addressOp.isPresent()) { try { if (addressOp.get().isReachable(100)) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
LOCAL_ADDRESS = addressOp.get(); return LOCAL_ADDRESS; } } catch (IOException e) { logger.warn("test address id reachable io exception", e); } } } } localAddress = InetAddress.getLocalHost(); } catch (UnknownHostException e) { logger.warn("InetAddress get LocalHost exception", e); } Optional<InetAddress> addressOp = toValidAddress(localAddress); if (addressOp.isPresent()) { LOCAL_ADDRESS = addressOp.get(); } return LOCAL_ADDRESS; } private static Optional<InetAddress> toValidAddress(InetAddress address) { if (address instanceof Inet6Address) { Inet6Address v6Address = (Inet6Address) address; if (isPreferIPV6Address()) { return Optional.ofNullable(normalizeV6Address(v6Address)); } } if (isValidV4Address(address)) { return Optional.of(address); } return Optional.empty();
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
} private static InetAddress normalizeV6Address(Inet6Address address) { String addr = address.getHostAddress(); int i = addr.lastIndexOf('%'); if (i > 0) { try { return InetAddress.getByName(addr.substring(0, i) + '%' + address.getScopeId()); } catch (UnknownHostException e) { logger.debug("Unknown IPV6 address: ", e); } } return address; } public static boolean isValidV4Address(InetAddress address) { if (address == null || address.isLoopbackAddress()) { return false; } String name = address.getHostAddress(); return (name != null && IP_PATTERN.matcher(name).matches() && !address.isAnyLocalAddress() && !address.isLoopbackAddress()); } /** * Check if an ipv6 address * * @return true if it is reachable */ private static boolean isPreferIPV6Address() { return Boolean.getBoolean("java.net.preferIPv6Addresses");
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
} /** * Get the suitable {@link NetworkInterface} * * @return If no {@link NetworkInterface} is available , return <code>null</code> */ private static NetworkInterface findNetworkInterface() { List<NetworkInterface> validNetworkInterfaces = emptyList(); try { validNetworkInterfaces = getValidNetworkInterfaces(); } catch (SocketException e) { logger.warn("ValidNetworkInterfaces exception", e); } NetworkInterface result = null; for (NetworkInterface networkInterface : validNetworkInterfaces) { if (isSpecifyNetworkInterface(networkInterface)) { result = networkInterface; break; } } if (null != result) { return result; } return findAddress(validNetworkInterfaces); } /** * Get the valid {@link NetworkInterface network interfaces} * * @throws SocketException SocketException if an I/O error occurs.
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
*/ private static List<NetworkInterface> getValidNetworkInterfaces() throws SocketException { List<NetworkInterface> validNetworkInterfaces = new LinkedList<>(); Enumeration<NetworkInterface> interfaces = NetworkInterface.getNetworkInterfaces(); while (interfaces.hasMoreElements()) { NetworkInterface networkInterface = interfaces.nextElement(); if (ignoreNetworkInterface(networkInterface)) { continue; } validNetworkInterfaces.add(networkInterface); } return validNetworkInterfaces; } /** * @param networkInterface {@link NetworkInterface} * @return if the specified {@link NetworkInterface} should be ignored, return <code>true</code> * @throws SocketException SocketException if an I/O error occurs. */ public static boolean ignoreNetworkInterface(NetworkInterface networkInterface) throws SocketException { return networkInterface == null || networkInterface.isLoopback() || networkInterface.isVirtual() || !networkInterface.isUp(); } private static boolean isSpecifyNetworkInterface(NetworkInterface networkInterface) { String preferredNetworkInterface = System.getProperty(DOLPHIN_SCHEDULER_PREFERRED_NETWORK_INTERFACE); return Objects.equals(networkInterface.getDisplayName(), preferredNetworkInterface); } private static NetworkInterface findAddress(List<NetworkInterface> validNetworkInterfaces) { if (validNetworkInterfaces.isEmpty()) {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
return null; } String networkPriority = PropertyUtils.getString(Constants.NETWORK_PRIORITY_STRATEGY, NETWORK_PRIORITY_DEFAULT); if (NETWORK_PRIORITY_DEFAULT.equalsIgnoreCase(networkPriority)) { return findAddressByDefaultPolicy(validNetworkInterfaces); } else if (NETWORK_PRIORITY_INNER.equalsIgnoreCase(networkPriority)) { return findInnerAddress(validNetworkInterfaces); } else if (NETWORK_PRIORITY_OUTER.equalsIgnoreCase(networkPriority)) { return findOuterAddress(validNetworkInterfaces); } else { logger.error("There is no matching network card acquisition policy!"); return null; } } private static NetworkInterface findAddressByDefaultPolicy(List<NetworkInterface> validNetworkInterfaces) { NetworkInterface networkInterface; networkInterface = findInnerAddress(validNetworkInterfaces); if (networkInterface == null) { networkInterface = findOuterAddress(validNetworkInterfaces); if (networkInterface == null) { networkInterface = validNetworkInterfaces.get(0); } } return networkInterface; } /** * Get the Intranet IP * * @return If no {@link NetworkInterface} is available , return <code>null</code> */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,468
[Bug][Common] Obtaining IP is incorrect
**To Reproduce** In some scenarios, obtaining IP is incorrect **Expected behavior** Bug fixed **Screenshots** If applicable, add screenshots to help explain your problem. **Scenario 1: IP is null** ![image](https://user-images.githubusercontent.com/4902714/118223662-5f3edb80-b4b4-11eb-9046-3565f6fe1a2c.png) **Scenario 2: IP incorrect order** ![image](https://user-images.githubusercontent.com/4902714/118223277-92cd3600-b4b3-11eb-920c-46c3bfe1cc2f.png) ![image](https://user-images.githubusercontent.com/4902714/118223548-230b7b00-b4b4-11eb-8775-57abc66abf41.png) **Scenario 3: IP is 127.0.0.1** ![image](https://user-images.githubusercontent.com/4902714/118223722-7e3d6d80-b4b4-11eb-8cec-a3d408be41a3.png) ![image](https://user-images.githubusercontent.com/4902714/118223725-81d0f480-b4b4-11eb-95aa-0c1a0add8560.png) **Scenario 4: IP is 0.0.0.0.0.0** ![image](https://user-images.githubusercontent.com/4902714/119919935-07b56b00-bf9e-11eb-9972-00d73be4f381.png) ![image](https://user-images.githubusercontent.com/4902714/119919948-0e43e280-bf9e-11eb-8947-9eccfac17b47.png) ![image](https://user-images.githubusercontent.com/4902714/119920051-3895a000-bf9e-11eb-87dc-efc7d6181d64.png) **Which version of Dolphin Scheduler:** -[1.3.x] -[dev] **Additional context** Add any other context about the problem here. **Requirement or improvement** - Please describe about your requirements or improvement suggestions.
https://github.com/apache/dolphinscheduler/issues/5468
https://github.com/apache/dolphinscheduler/pull/5594
75be09735a29469ef5169550239c65a5a27af3ba
281b5aea6b85df86b279eb3377ff6851c560bcbd
"2021-05-14T05:04:32Z"
java
"2021-06-07T14:12:49Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java
private static NetworkInterface findInnerAddress(List<NetworkInterface> validNetworkInterfaces) { NetworkInterface networkInterface = null; for (NetworkInterface ni : validNetworkInterfaces) { Enumeration<InetAddress> address = ni.getInetAddresses(); while (address.hasMoreElements()) { InetAddress ip = address.nextElement(); if (ip.isSiteLocalAddress() && !ip.isLoopbackAddress()) { networkInterface = ni; } } } return networkInterface; } private static NetworkInterface findOuterAddress(List<NetworkInterface> validNetworkInterfaces) { NetworkInterface networkInterface = null; for (NetworkInterface ni : validNetworkInterfaces) { Enumeration<InetAddress> address = ni.getInetAddresses(); while (address.hasMoreElements()) { InetAddress ip = address.nextElement(); if (!ip.isSiteLocalAddress() && !ip.isLoopbackAddress()) { networkInterface = ni; } } } return networkInterface; } }
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.dolphinscheduler.common; import org.apache.dolphinscheduler.common.enums.ExecutionStatus; import org.apache.dolphinscheduler.common.utils.OSUtils; import org.apache.dolphinscheduler.common.utils.StringUtils; import java.util.regex.Pattern; /** * Constants */ public final class Constants {
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
private Constants() { throw new UnsupportedOperationException("Construct Constants"); } /** * quartz config */ public static final String ORG_QUARTZ_JOBSTORE_DRIVERDELEGATECLASS = "org.quartz.jobStore.driverDelegateClass"; public static final String ORG_QUARTZ_SCHEDULER_INSTANCENAME = "org.quartz.scheduler.instanceName"; public static final String ORG_QUARTZ_SCHEDULER_INSTANCEID = "org.quartz.scheduler.instanceId"; public static final String ORG_QUARTZ_SCHEDULER_MAKESCHEDULERTHREADDAEMON = "org.quartz.scheduler.makeSchedulerThreadDaemon"; public static final String ORG_QUARTZ_JOBSTORE_USEPROPERTIES = "org.quartz.jobStore.useProperties"; public static final String ORG_QUARTZ_THREADPOOL_CLASS = "org.quartz.threadPool.class"; public static final String ORG_QUARTZ_THREADPOOL_THREADCOUNT = "org.quartz.threadPool.threadCount"; public static final String ORG_QUARTZ_THREADPOOL_MAKETHREADSDAEMONS = "org.quartz.threadPool.makeThreadsDaemons"; public static final String ORG_QUARTZ_THREADPOOL_THREADPRIORITY = "org.quartz.threadPool.threadPriority"; public static final String ORG_QUARTZ_JOBSTORE_CLASS = "org.quartz.jobStore.class"; public static final String ORG_QUARTZ_JOBSTORE_TABLEPREFIX = "org.quartz.jobStore.tablePrefix"; public static final String ORG_QUARTZ_JOBSTORE_ISCLUSTERED = "org.quartz.jobStore.isClustered"; public static final String ORG_QUARTZ_JOBSTORE_MISFIRETHRESHOLD = "org.quartz.jobStore.misfireThreshold"; public static final String ORG_QUARTZ_JOBSTORE_CLUSTERCHECKININTERVAL = "org.quartz.jobStore.clusterCheckinInterval"; public static final String ORG_QUARTZ_JOBSTORE_ACQUIRETRIGGERSWITHINLOCK = "org.quartz.jobStore.acquireTriggersWithinLock"; public static final String ORG_QUARTZ_JOBSTORE_DATASOURCE = "org.quartz.jobStore.dataSource"; public static final String ORG_QUARTZ_DATASOURCE_MYDS_CONNECTIONPROVIDER_CLASS = "org.quartz.dataSource.myDs.connectionProvider.class"; /** * quartz config default value */ public static final String QUARTZ_TABLE_PREFIX = "QRTZ_";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String QUARTZ_MISFIRETHRESHOLD = "60000"; public static final String QUARTZ_CLUSTERCHECKININTERVAL = "5000"; public static final String QUARTZ_DATASOURCE = "myDs"; public static final String QUARTZ_THREADCOUNT = "25"; public static final String QUARTZ_THREADPRIORITY = "5"; public static final String QUARTZ_INSTANCENAME = "DolphinScheduler"; public static final String QUARTZ_INSTANCEID = "AUTO"; public static final String QUARTZ_ACQUIRETRIGGERSWITHINLOCK = "true"; /** * common properties path */ public static final String COMMON_PROPERTIES_PATH = "/common.properties"; /** * fs.defaultFS */ public static final String FS_DEFAULTFS = "fs.defaultFS"; /** * fs s3a endpoint */ public static final String FS_S3A_ENDPOINT = "fs.s3a.endpoint"; /** * fs s3a access key */ public static final String FS_S3A_ACCESS_KEY = "fs.s3a.access.key"; /** * fs s3a secret key */ public static final String FS_S3A_SECRET_KEY = "fs.s3a.secret.key"; /** * hadoop configuration
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
*/ public static final String HADOOP_RM_STATE_ACTIVE = "ACTIVE"; public static final String HADOOP_RM_STATE_STANDBY = "STANDBY"; public static final String HADOOP_RESOURCE_MANAGER_HTTPADDRESS_PORT = "resource.manager.httpaddress.port"; /** * yarn.resourcemanager.ha.rm.ids */ public static final String YARN_RESOURCEMANAGER_HA_RM_IDS = "yarn.resourcemanager.ha.rm.ids"; /** * yarn.application.status.address */ public static final String YARN_APPLICATION_STATUS_ADDRESS = "yarn.application.status.address"; /** * yarn.job.history.status.address */ public static final String YARN_JOB_HISTORY_STATUS_ADDRESS = "yarn.job.history.status.address"; /** * hdfs configuration * hdfs.root.user */ public static final String HDFS_ROOT_USER = "hdfs.root.user"; /** * hdfs/s3 configuration * resource.upload.path */ public static final String RESOURCE_UPLOAD_PATH = "resource.upload.path"; /** * data basedir path */ public static final String DATA_BASEDIR_PATH = "data.basedir.path";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
/** * dolphinscheduler.env.path */ public static final String DOLPHINSCHEDULER_ENV_PATH = "dolphinscheduler.env.path"; /** * environment properties default path */ public static final String ENV_PATH = "env/dolphinscheduler_env.sh"; /** * python home */ public static final String PYTHON_HOME = "PYTHON_HOME"; /** * resource.view.suffixs */ public static final String RESOURCE_VIEW_SUFFIXS = "resource.view.suffixs"; public static final String RESOURCE_VIEW_SUFFIXS_DEFAULT_VALUE = "txt,log,sh,bat,conf,cfg,py,java,sql,xml,hql,properties,json,yml,yaml,ini,js"; /** * development.state */ public static final String DEVELOPMENT_STATE = "development.state"; /** * sudo enable */ public static final String SUDO_ENABLE = "sudo.enable"; /** * string true */ public static final String STRING_TRUE = "true"; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* string false */ public static final String STRING_FALSE = "false"; /** * resource storage type */ public static final String RESOURCE_STORAGE_TYPE = "resource.storage.type"; /** * MasterServer directory registered in zookeeper */ public static final String REGISTRY_DOLPHINSCHEDULER_MASTERS = "/nodes/master"; /** * WorkerServer directory registered in zookeeper */ public static final String REGISTRY_DOLPHINSCHEDULER_WORKERS = "/nodes/worker"; /** * all servers directory registered in zookeeper */ public static final String REGISTRY_DOLPHINSCHEDULER_DEAD_SERVERS = "/dead-servers"; /** * registry node prefix */ public static final String REGISTRY_DOLPHINSCHEDULER_NODE = "/nodes"; /** * MasterServer lock directory registered in zookeeper */ public static final String REGISTRY_DOLPHINSCHEDULER_LOCK_MASTERS = "/lock/masters"; /** * MasterServer failover directory registered in zookeeper */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String REGISTRY_DOLPHINSCHEDULER_LOCK_FAILOVER_MASTERS = "/lock/failover/masters"; /** * WorkerServer failover directory registered in zookeeper */ public static final String REGISTRY_DOLPHINSCHEDULER_LOCK_FAILOVER_WORKERS = "/lock/failover/workers"; /** * MasterServer startup failover runing and fault tolerance process */ public static final String REGISTRY_DOLPHINSCHEDULER_LOCK_FAILOVER_STARTUP_MASTERS = "/lock/failover/startup-masters"; /** * comma , */ public static final String COMMA = ","; /** * slash / */ public static final String SLASH = "/"; /** * COLON : */ public static final String COLON = ":"; /** * SPACE " " */ public static final String SPACE = " "; /** * SINGLE_SLASH / */ public static final String SINGLE_SLASH = "/"; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* DOUBLE_SLASH // */ public static final String DOUBLE_SLASH = "//"; /** * SINGLE_QUOTES "'" */ public static final String SINGLE_QUOTES = "'"; /** * DOUBLE_QUOTES "\"" */ public static final String DOUBLE_QUOTES = "\""; /** * SEMICOLON ; */ public static final String SEMICOLON = ";"; /** * EQUAL SIGN */ public static final String EQUAL_SIGN = "="; /** * AT SIGN */ public static final String AT_SIGN = "@"; /** * date format of yyyy-MM-dd HH:mm:ss */ public static final String YYYY_MM_DD_HH_MM_SS = "yyyy-MM-dd HH:mm:ss"; /** * date format of yyyyMMddHHmmss */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String YYYYMMDDHHMMSS = "yyyyMMddHHmmss"; /** * date format of yyyyMMddHHmmssSSS */ public static final String YYYYMMDDHHMMSSSSS = "yyyyMMddHHmmssSSS"; /** * http connect time out */ public static final int HTTP_CONNECT_TIMEOUT = 60 * 1000; /** * http connect request time out */ public static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 60 * 1000; /** * httpclient soceket time out */ public static final int SOCKET_TIMEOUT = 60 * 1000; /** * http header */ public static final String HTTP_HEADER_UNKNOWN = "unKnown"; /** * http X-Forwarded-For */ public static final String HTTP_X_FORWARDED_FOR = "X-Forwarded-For"; /** * http X-Real-IP */ public static final String HTTP_X_REAL_IP = "X-Real-IP"; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* UTF-8 */ public static final String UTF_8 = "UTF-8"; /** * user name regex */ public static final Pattern REGEX_USER_NAME = Pattern.compile("^[a-zA-Z0-9._-]{3,39}$"); /** * email regex */ public static final Pattern REGEX_MAIL_NAME = Pattern.compile("^([a-z0-9A-Z]+[_|\\-|\\.]?)+[a-z0-9A-Z]@([a-z0-9A-Z]+(-[a-z0-9A-Z]+)?\\.)+[a-zA-Z]{2,}$"); /** * default display rows */ public static final int DEFAULT_DISPLAY_ROWS = 10; /** * read permission */ public static final int READ_PERMISSION = 2 * 1; /** * write permission */ public static final int WRITE_PERMISSION = 2 * 2; /** * execute permission */ public static final int EXECUTE_PERMISSION = 1; /** * default admin permission */
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final int DEFAULT_ADMIN_PERMISSION = 7; /** * all permissions */ public static final int ALL_PERMISSIONS = READ_PERMISSION | WRITE_PERMISSION | EXECUTE_PERMISSION; /** * max task timeout */ public static final int MAX_TASK_TIMEOUT = 24 * 3600; /** * master cpu load */ public static final int DEFAULT_MASTER_CPU_LOAD = Runtime.getRuntime().availableProcessors() * 2; /** * worker cpu load */ public static final int DEFAULT_WORKER_CPU_LOAD = Runtime.getRuntime().availableProcessors() * 2; /** * worker host weight */ public static final int DEFAULT_WORKER_HOST_WEIGHT = 100; /** * default log cache rows num,output when reach the number */ public static final int DEFAULT_LOG_ROWS_NUM = 4 * 16; /** * log flush interval?output when reach the interval */ public static final int DEFAULT_LOG_FLUSH_INTERVAL = 1000; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* time unit secong to minutes */ public static final int SEC_2_MINUTES_TIME_UNIT = 60; /*** * * rpc port */ public static final int RPC_PORT = 50051; /*** * alert rpc port */ public static final int ALERT_RPC_PORT = 50052; /** * forbid running task */ public static final String FLOWNODE_RUN_FLAG_FORBIDDEN = "FORBIDDEN"; /** * normal running task */ public static final String FLOWNODE_RUN_FLAG_NORMAL = "NORMAL"; /** * datasource configuration path */ public static final String DATASOURCE_PROPERTIES = "/datasource.properties"; public static final String DEFAULT = "Default"; public static final String USER = "user"; public static final String PASSWORD = "password"; public static final String XXXXXX = "******"; public static final String NULL = "NULL"; public static final String THREAD_NAME_MASTER_SERVER = "Master-Server";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String THREAD_NAME_WORKER_SERVER = "Worker-Server"; /** * command parameter keys */ public static final String CMD_PARAM_RECOVER_PROCESS_ID_STRING = "ProcessInstanceId"; public static final String CMD_PARAM_RECOVERY_START_NODE_STRING = "StartNodeIdList"; public static final String CMD_PARAM_RECOVERY_WAITING_THREAD = "WaitingThreadInstanceId"; public static final String CMD_PARAM_SUB_PROCESS = "processInstanceId"; public static final String CMD_PARAM_EMPTY_SUB_PROCESS = "0"; public static final String CMD_PARAM_SUB_PROCESS_PARENT_INSTANCE_ID = "parentProcessInstanceId"; public static final String CMD_PARAM_SUB_PROCESS_DEFINE_ID = "processDefinitionId"; public static final String CMD_PARAM_START_NODE_NAMES = "StartNodeNameList"; public static final String CMD_PARAM_START_PARAMS = "StartParams"; public static final String CMD_PARAM_FATHER_PARAMS = "fatherParams"; /** * complement data start date */ public static final String CMDPARAM_COMPLEMENT_DATA_START_DATE = "complementStartDate"; /** * complement data end date */ public static final String CMDPARAM_COMPLEMENT_DATA_END_DATE = "complementEndDate"; /** * data source config */ public static final String SPRING_DATASOURCE_DRIVER_CLASS_NAME = "spring.datasource.driver-class-name"; public static final String SPRING_DATASOURCE_URL = "spring.datasource.url"; public static final String SPRING_DATASOURCE_USERNAME = "spring.datasource.username"; public static final String SPRING_DATASOURCE_PASSWORD = "spring.datasource.password"; public static final String SPRING_DATASOURCE_VALIDATION_QUERY_TIMEOUT = "spring.datasource.validationQueryTimeout";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
public static final String SPRING_DATASOURCE_INITIAL_SIZE = "spring.datasource.initialSize"; public static final String SPRING_DATASOURCE_MIN_IDLE = "spring.datasource.minIdle"; public static final String SPRING_DATASOURCE_MAX_ACTIVE = "spring.datasource.maxActive"; public static final String SPRING_DATASOURCE_MAX_WAIT = "spring.datasource.maxWait"; public static final String SPRING_DATASOURCE_TIME_BETWEEN_EVICTION_RUNS_MILLIS = "spring.datasource.timeBetweenEvictionRunsMillis"; public static final String SPRING_DATASOURCE_TIME_BETWEEN_CONNECT_ERROR_MILLIS = "spring.datasource.timeBetweenConnectErrorMillis"; public static final String SPRING_DATASOURCE_MIN_EVICTABLE_IDLE_TIME_MILLIS = "spring.datasource.minEvictableIdleTimeMillis"; public static final String SPRING_DATASOURCE_VALIDATION_QUERY = "spring.datasource.validationQuery"; public static final String SPRING_DATASOURCE_TEST_WHILE_IDLE = "spring.datasource.testWhileIdle"; public static final String SPRING_DATASOURCE_TEST_ON_BORROW = "spring.datasource.testOnBorrow"; public static final String SPRING_DATASOURCE_TEST_ON_RETURN = "spring.datasource.testOnReturn"; public static final String SPRING_DATASOURCE_POOL_PREPARED_STATEMENTS = "spring.datasource.poolPreparedStatements"; public static final String SPRING_DATASOURCE_DEFAULT_AUTO_COMMIT = "spring.datasource.defaultAutoCommit"; public static final String SPRING_DATASOURCE_KEEP_ALIVE = "spring.datasource.keepAlive"; public static final String SPRING_DATASOURCE_MAX_POOL_PREPARED_STATEMENT_PER_CONNECTION_SIZE = "spring.datasource.maxPoolPreparedStatementPerConnectionSize"; public static final String DEVELOPMENT = "development"; public static final String QUARTZ_PROPERTIES_PATH = "quartz.properties"; /** * sleep time */ public static final int SLEEP_TIME_MILLIS = 1000; /** * heartbeat for zk info length */ public static final int HEARTBEAT_FOR_ZOOKEEPER_INFO_LENGTH = 10; public static final int HEARTBEAT_WITH_WEIGHT_FOR_ZOOKEEPER_INFO_LENGTH = 11; /** * jar */ public static final String JAR = "jar";
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
/** * hadoop */ public static final String HADOOP = "hadoop"; /** * -D <property>=<value> */ public static final String D = "-D"; /** * -D mapreduce.job.name=name */ public static final String MR_NAME = "mapreduce.job.name"; /** * -D mapreduce.job.queuename=queuename */ public static final String MR_QUEUE = "mapreduce.job.queuename"; /** * spark params constant */ public static final String MASTER = "--master"; public static final String DEPLOY_MODE = "--deploy-mode"; /** * --class CLASS_NAME */ public static final String MAIN_CLASS = "--class"; /** * --driver-cores NUM */ public static final String DRIVER_CORES = "--driver-cores"; /**
closed
apache/dolphinscheduler
https://github.com/apache/dolphinscheduler
5,539
[Improvement][Master] Check status of taskInstance from cache
**Describe the question** After the master submit a task, the master will wait for the task execution to end, and it will loop to query the task status from database. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java#L123-L164 Why doesn't it query the status from the taskInstanceCacheManager? When the master receive the response from worker, it will also update the cache. https://github.com/apache/dolphinscheduler/blob/8a1d849701671544327a1d4e7852575af6872017/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/TaskResponseProcessor.java#L68-L87 I think if we query the status from cache, we can reduce the pressure of the database. The main risk is that after the worker crashed, we need to send a response to the master when doing worker tolerance. So as a compromise, can we query the cache 9 times and then query the database once? Or we get task status from cache, and the cache query the task status from database periodically(the schedule interval can be longer). **Which version of DolphinScheduler:** -[dev]
https://github.com/apache/dolphinscheduler/issues/5539
https://github.com/apache/dolphinscheduler/pull/5572
e2243d63bee789b96d8ceeb302261564c5a28ce7
79eb2e85d78f380bb9b8f812d874f1143b661e76
"2021-05-22T07:08:34Z"
java
"2021-06-10T01:39:12Z"
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
* --driver-memory MEM */ public static final String DRIVER_MEMORY = "--driver-memory"; /** * --num-executors NUM */ public static final String NUM_EXECUTORS = "--num-executors"; /** * --executor-cores NUM */ public static final String EXECUTOR_CORES = "--executor-cores"; /** * --executor-memory MEM */ public static final String EXECUTOR_MEMORY = "--executor-memory"; /** * --name NAME */ public static final String SPARK_NAME = "--name"; /** * --queue QUEUE */ public static final String SPARK_QUEUE = "--queue"; /** * exit code success */ public static final int EXIT_CODE_SUCCESS = 0; /** * exit code kill */