url
stringlengths 50
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 64
67
| comments_url
stringlengths 59
62
| events_url
stringlengths 57
60
| html_url
stringlengths 38
43
| id
int64 597k
2.65B
| node_id
stringlengths 18
32
| number
int64 1
6.83k
| title
stringlengths 1
296
| user
dict | labels
listlengths 0
5
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
4
| milestone
dict | comments
int64 0
211
| created_at
stringlengths 20
20
| updated_at
stringlengths 20
20
| closed_at
stringlengths 20
20
⌀ | author_association
stringclasses 3
values | active_lock_reason
stringclasses 4
values | body
stringlengths 0
65.6k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 59
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | draft
bool 2
classes | pull_request
dict | is_pull_request
bool 2
classes | issue_comments
listlengths 0
30
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/4161
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4161/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4161/comments
|
https://api.github.com/repos/psf/requests/issues/4161/events
|
https://github.com/psf/requests/issues/4161
| 236,249,215 |
MDU6SXNzdWUyMzYyNDkyMTU=
| 4,161 |
Content-Length header issue
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/29462250?v=4",
"events_url": "https://api.github.com/users/Lsup27/events{/privacy}",
"followers_url": "https://api.github.com/users/Lsup27/followers",
"following_url": "https://api.github.com/users/Lsup27/following{/other_user}",
"gists_url": "https://api.github.com/users/Lsup27/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lsup27",
"id": 29462250,
"login": "Lsup27",
"node_id": "MDQ6VXNlcjI5NDYyMjUw",
"organizations_url": "https://api.github.com/users/Lsup27/orgs",
"received_events_url": "https://api.github.com/users/Lsup27/received_events",
"repos_url": "https://api.github.com/users/Lsup27/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lsup27/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lsup27/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lsup27",
"user_view_type": "public"
}
|
[
{
"color": "fef2c0",
"default": false,
"description": null,
"id": 298537994,
"name": "Needs More Information",
"node_id": "MDU6TGFiZWwyOTg1Mzc5OTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20More%20Information"
}
] |
closed
| true | null |
[] | null | 2 |
2017-06-15T16:37:42Z
|
2021-09-08T08:00:31Z
|
2017-07-29T22:46:29Z
|
NONE
|
resolved
|
I have used remove property for the header property Content-Length as I dont want to have the response from the backend truncated. But curious enough when I call the API, sometimes the content-length property is removed and sometimes it is not. Why is this behavior observed. I included the remove property line after the call is made to backend and we get the response.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4161/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4161/timeline
| null |
completed
| null | null | false |
[
"Can you show me some sample code and what you expect to see, vs what you actually see?",
"This hasn't been updated in well over a month. Without further detail, there's nothing we can do. I'm closing this for now but if you have the extra detail that can help us help you, then we'll reopen it."
] |
https://api.github.com/repos/psf/requests/issues/4160
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4160/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4160/comments
|
https://api.github.com/repos/psf/requests/issues/4160/events
|
https://github.com/psf/requests/issues/4160
| 235,944,582 |
MDU6SXNzdWUyMzU5NDQ1ODI=
| 4,160 |
requests 2.18.0 breaks docker-py
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3217783?v=4",
"events_url": "https://api.github.com/users/chenww/events{/privacy}",
"followers_url": "https://api.github.com/users/chenww/followers",
"following_url": "https://api.github.com/users/chenww/following{/other_user}",
"gists_url": "https://api.github.com/users/chenww/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/chenww",
"id": 3217783,
"login": "chenww",
"node_id": "MDQ6VXNlcjMyMTc3ODM=",
"organizations_url": "https://api.github.com/users/chenww/orgs",
"received_events_url": "https://api.github.com/users/chenww/received_events",
"repos_url": "https://api.github.com/users/chenww/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/chenww/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chenww/subscriptions",
"type": "User",
"url": "https://api.github.com/users/chenww",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 12 |
2017-06-14T16:54:51Z
|
2018-06-27T19:05:34Z
|
2017-06-14T17:52:39Z
|
NONE
|
resolved
|
Summary.
Got bitten right after this new requests version released. When I run with docker-py, it is fine before. now it is complaining :
Error while fetching server API version: Timeout value connect was Timeout(connect=60, read=60, total=None), but it must be an int, float or None.
## Expected Result
backward compatibility should be maintained from requests module
What you expected.
## Actual Result
# python
Python 2.7.5 (default, Nov 6 2016, 00:28:07)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-11)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import docker
>>> c = docker.Client(base_url='unix://var/run/docker.sock', version='1.15', timeout=2.0)
>>> l = c.containers(all=True)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python2.7/site-packages/docker/api/container.py", line 85, in containers
res = self._result(self._get(u, params=params), True)
File "/usr/lib/python2.7/site-packages/docker/utils/decorators.py", line 47, in inner
return f(self, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/docker/client.py", line 139, in _get
return self.get(url, **self._set_request_timeout(kwargs))
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 515, in get
return self.request('GET', url, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 502, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 612, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 440, in send
timeout=timeout
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 587, in urlopen
timeout_obj = self._get_timeout(timeout)
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 302, in _get_timeout
return Timeout.from_float(timeout)
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/util/timeout.py", line 154, in from_float
return Timeout(read=timeout, connect=timeout)
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/util/timeout.py", line 94, in __init__
self._connect = self._validate_timeout(connect, 'connect')
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/util/timeout.py", line 127, in _validate_timeout
"int, float or None." % (name, value))
ValueError: Timeout value connect was Timeout(connect=2.0, read=2.0, total=None), but it must be an int, float or None.
## Reproduction Steps
# pip install requests==2.17.3
Collecting requests==2.17.3
Using cached requests-2.17.3-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): chardet<3.1.0,>=3.0.2 in /usr/lib/python2.7/site-packages (from requests==2.17.3)
Requirement already satisfied (use --upgrade to upgrade): certifi>=2017.4.17 in /usr/lib/python2.7/site-packages (from requests==2.17.3)
Requirement already satisfied (use --upgrade to upgrade): idna<2.6,>=2.5 in /usr/lib/python2.7/site-packages (from requests==2.17.3)
Requirement already satisfied (use --upgrade to upgrade): urllib3<1.22,>=1.21.1 in /usr/lib/python2.7/site-packages (from requests==2.17.3)
Installing collected packages: requests
Found existing installation: requests 2.18.0
Uninstalling requests-2.18.0:
Successfully uninstalled requests-2.18.0
Successfully installed requests-2.17.3
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
[root@bootserver-do-not-delete ~]# python
Python 2.7.5 (default, Nov 6 2016, 00:28:07)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-11)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import docker
>>> c = docker.Client(base_url='unix://var/run/docker.sock', version='1.15', timeout=2.0)
>>> l = c.containers(all=True)
this works
## System Information
$ python -m requests.help
$ python -m requests.help
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "2.7.5"
},
"platform": {
"release": "3.10.0-514.21.1.el7.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.18.0"
},
"system_ssl": {
"version": "1000105f"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": false
}
```
<paste here>
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4160/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4160/timeline
| null |
completed
| null | null | false |
[
"Well this is *extremely* perplexing. It seems like the fix that landed in 2.17.3 to resolve the packages problem is not present in 2.18. I have *no idea* what has happened here, because none of the diff between the 2.17.3 tag and the 2.18 tag contains anything that looks like it'd affect this.",
"Ok, got it. This is a problem with having old data left behind in my copy of the repo, which means when I did the release we broke the wheel. I'm sorry about that, I'll push out a v2.18.1 shortly.",
"2.18.1 has been released that should fix this problem. There's no need for code changes: this was purely an issue with my on-disk copy of the code. Sorry about that!",
"that fixes the issue. thanks for quick turnaround",
"I still have this problem....\r\n\r\nmy versions are:\r\n\r\nrancher@RancherOS1_SRV:~$ pip freeze\r\nbackports.ssl-match-hostname==3.5.0.1\r\ncertifi==2017.7.27.1\r\nchardet==3.0.4\r\ncryptography==1.7.1\r\ndocker-py==1.10.6\r\ndocker-pycreds==0.2.1\r\nenum34==1.1.6\r\nidna==2.6\r\nipaddress==1.0.18\r\nkeyring==10.1\r\nkeyrings.alt==1.3\r\npyasn1==0.1.9\r\npycrypto==2.6.1\r\npygobject==3.22.0\r\npython-apt==1.4.0b3\r\npyxdg==0.25\r\nrequests==2.18.4\r\nSecretStorage==2.3.1\r\nsix==1.11.0\r\nurllib3==1.22\r\nwebsocket-client==0.44.0\r\n",
"Same here with requests 2.18.4, fixed with 2.18.1",
"Same ! got this problem with 2.18.4 and fixed with 2.18.1 !",
"@oussemos @titilambert, could you please confirm that 2.18.1 is the latest version that works for you? (i.e. 2.18.2 and 2.18.3 don't work either?)",
"Same issue with 2.18.4",
"With Docker Compose `1.17.1` the latest requests that work for me is `2.15.1`...",
"@butla same here. 2.15.1 is only version that works with docker compose 1.17.1",
"Updated pip and saw this error ```Error connecting: Error while fetching server API version: Timeout value connect was Timeout(connect=60, read=60, total=None), but it must be an int or float.```\r\npip freeze\r\nCheetah==2.4.4\r\nLandscape-Client==14.12\r\nPAM==0.4.2\r\nPyYAML==3.10\r\nTwisted-Core==13.2.0\r\nTwisted-Names==13.2.0\r\nTwisted-Web==13.2.0\r\napt-xapian-index==0.45\r\nargparse==1.2.1\r\nbackports.ssl-match-hostname==3.5.0.1\r\ncertifi==2018.4.16\r\nchardet==3.0.4\r\ncloud-init==0.7.5\r\ncolorama==0.2.5\r\nconfigobj==4.7.2\r\ndocker-py==1.8.1\r\nhtml5lib==0.999\r\nidna==2.7\r\njsonpatch==1.3\r\njsonpointer==1.0\r\noauth==1.0.1\r\nprettytable==0.7.2\r\npsycopg2==2.4.5\r\npyOpenSSL==0.13\r\npycrypto==2.6.1\r\npycurl==7.19.3\r\npyserial==2.6\r\npython-apt===0.9.3.5ubuntu2\r\npython-debian===0.1.21-nmu2ubuntu2\r\nrequests==2.19.1\r\nsix==1.9.0\r\nssh-import-id==3.21\r\nurllib3==1.23\r\nwebsocket-client==0.35.0\r\nwheel==0.24.0\r\nwsgiref==0.1.2\r\nzope.interface==4.0.5\r\n"
] |
https://api.github.com/repos/psf/requests/issues/4159
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4159/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4159/comments
|
https://api.github.com/repos/psf/requests/issues/4159/events
|
https://github.com/psf/requests/issues/4159
| 235,943,752 |
MDU6SXNzdWUyMzU5NDM3NTI=
| 4,159 |
requests 2.18.0 installation with easy-install
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/244702?v=4",
"events_url": "https://api.github.com/users/papachoco/events{/privacy}",
"followers_url": "https://api.github.com/users/papachoco/followers",
"following_url": "https://api.github.com/users/papachoco/following{/other_user}",
"gists_url": "https://api.github.com/users/papachoco/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/papachoco",
"id": 244702,
"login": "papachoco",
"node_id": "MDQ6VXNlcjI0NDcwMg==",
"organizations_url": "https://api.github.com/users/papachoco/orgs",
"received_events_url": "https://api.github.com/users/papachoco/received_events",
"repos_url": "https://api.github.com/users/papachoco/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/papachoco/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/papachoco/subscriptions",
"type": "User",
"url": "https://api.github.com/users/papachoco",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-06-14T16:51:39Z
|
2021-09-08T08:00:31Z
|
2017-07-29T22:41:12Z
|
NONE
|
resolved
|
Summary.
For legacy (easy-install / buildout) installations the egg and / or source for requests 2.18.0 is not being pick up. Not sure if this an issue with pypi since the source is listed
e.g.
easy_install-2.7 -U requests==2.18.0
Searching for requests==2.18.0
Reading https://pypi.python.org/simple/requests/
No local packages or working download links found for requests==2.18.0
error: Could not find suitable distribution for Requirement.parse('requests==2.18.0')
Thanks
Carlos
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4159/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4159/timeline
| null |
completed
| null | null | false |
[
"This seems like it's an issue with PyPI caching. @dstufft?",
"pip works fine",
"This isn't an issue with Requests. The source distribution is on PyPI: https://pypi.org/project/requests/2.18.0/#files\r\n\r\nI genuinely think this is an issue with setuptools and this hasn't ben updated in over a month. I'm closing this."
] |
https://api.github.com/repos/psf/requests/issues/4158
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4158/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4158/comments
|
https://api.github.com/repos/psf/requests/issues/4158/events
|
https://github.com/psf/requests/issues/4158
| 235,843,523 |
MDU6SXNzdWUyMzU4NDM1MjM=
| 4,158 |
Making requests to URLs with username and password does not respect no_proxy evironment settings
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/19623656?v=4",
"events_url": "https://api.github.com/users/hodossy/events{/privacy}",
"followers_url": "https://api.github.com/users/hodossy/followers",
"following_url": "https://api.github.com/users/hodossy/following{/other_user}",
"gists_url": "https://api.github.com/users/hodossy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hodossy",
"id": 19623656,
"login": "hodossy",
"node_id": "MDQ6VXNlcjE5NjIzNjU2",
"organizations_url": "https://api.github.com/users/hodossy/orgs",
"received_events_url": "https://api.github.com/users/hodossy/received_events",
"repos_url": "https://api.github.com/users/hodossy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hodossy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hodossy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hodossy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-14T11:08:55Z
|
2021-09-08T04:00:51Z
|
2018-01-16T14:07:27Z
|
NONE
|
resolved
|
## Summary
When determining whether proxies should be bypassed or not, netloc is considered, however it contains the username and password separated by a colon, thus proxy settings cannot be applied, as the either username or host[:port] is checked among the no_proxy hosts.
## Expected Result
Proxy settings are respected
## Actual Result
Following errors are thrown:
```
OSError: Tunnel connection failed: 504 Gateway Timeout
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='localhost', port=8080): Max retries exceeded with url: / (Caused by ProxyError('Cannot connect to proxy.', OSError('Tunnel connection failed: 504 Gateway Timeout',)))
```
## Reproduction Steps
```python
import requests
import os
os.environ['https_proxy'] = #insert your proxy here
os.environ['no_proxy'] = 'localhost,127.0.0.1'
requests.get('https://username:password@localhost:8080/')
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "3.0.3"
},
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "3.6.0"
},
"platform": {
"release": "3.16.0-4-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.17.3"
},
"system_ssl": {
"version": "1000114f"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": false
}
```
## Workaround
proxies kwarg can be used to bypass this issue, e.g. by setting {'https': None}. Should be used with caution.
### Problem in my opinion:
should_bypass_proxies(url, no_proxy) function in utils.py:
network location is used, which matches the following pattern: [user[:password]@]host[:port]
- ip is determined based on ':' position, which is not valid in this case, as ip will be the username: `ip = netloc.split(':')[0]`
- when checking if proxy should be applied, two things are checked: `if netloc.endswith(host) or netloc.split(':')[0].endswith(host):`, neither of which will be true, as host may not contain port, and username surely does not end with the host.
I propose to use `domain = urlparse(url).hostname` instead of `netloc = urlparse(url).netloc` when checking against the no_proxy environment variable.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4158/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4158/timeline
| null |
completed
| null | null | false |
[
"Yup, this seems incorrect to me. I'd welcome a patch to resolve this problem."
] |
https://api.github.com/repos/psf/requests/issues/4157
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4157/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4157/comments
|
https://api.github.com/repos/psf/requests/issues/4157/events
|
https://github.com/psf/requests/issues/4157
| 235,781,796 |
MDU6SXNzdWUyMzU3ODE3OTY=
| 4,157 |
with requests.get(url, stream=True) as r AttributeError('__exit__',)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/7598892?v=4",
"events_url": "https://api.github.com/users/beruhan/events{/privacy}",
"followers_url": "https://api.github.com/users/beruhan/followers",
"following_url": "https://api.github.com/users/beruhan/following{/other_user}",
"gists_url": "https://api.github.com/users/beruhan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/beruhan",
"id": 7598892,
"login": "beruhan",
"node_id": "MDQ6VXNlcjc1OTg4OTI=",
"organizations_url": "https://api.github.com/users/beruhan/orgs",
"received_events_url": "https://api.github.com/users/beruhan/received_events",
"repos_url": "https://api.github.com/users/beruhan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/beruhan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/beruhan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/beruhan",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-14T07:05:55Z
|
2021-09-08T08:00:44Z
|
2017-06-14T07:13:33Z
|
NONE
|
resolved
|
I read the python-requests doc,[http://docs.python-requests.org/en/master/user/advanced/#body-content-workflow](url),I run the example`with requests.get('http://httpbin.org/get', stream=True) as r:
pass`,I get the exception 'AttributeError('__exit__',)',is the example left closing clause?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4157/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4157/timeline
| null |
completed
| null | null | false |
[
"Sorry, no: that feature is going to be released today."
] |
https://api.github.com/repos/psf/requests/issues/4156
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4156/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4156/comments
|
https://api.github.com/repos/psf/requests/issues/4156/events
|
https://github.com/psf/requests/issues/4156
| 235,692,900 |
MDU6SXNzdWUyMzU2OTI5MDA=
| 4,156 |
http2 protocol support?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1790880?v=4",
"events_url": "https://api.github.com/users/kgk/events{/privacy}",
"followers_url": "https://api.github.com/users/kgk/followers",
"following_url": "https://api.github.com/users/kgk/following{/other_user}",
"gists_url": "https://api.github.com/users/kgk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kgk",
"id": 1790880,
"login": "kgk",
"node_id": "MDQ6VXNlcjE3OTA4ODA=",
"organizations_url": "https://api.github.com/users/kgk/orgs",
"received_events_url": "https://api.github.com/users/kgk/received_events",
"repos_url": "https://api.github.com/users/kgk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kgk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kgk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kgk",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-06-13T21:06:33Z
|
2021-09-08T08:00:44Z
|
2017-06-14T06:02:14Z
|
NONE
|
resolved
|
Some servers are moving http2 for better performance.
What would it take to have that in the requests library?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4156/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4156/timeline
| null |
completed
| null | null | false |
[
"In the works!",
"ETA: 1.5 years-ish. ",
"The TL;DR here is that HTTP/2 is appallingly unpleasant to work with from synchronous codebases like Requests. This means to add support requires substantial architectural changes. "
] |
https://api.github.com/repos/psf/requests/issues/4155
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4155/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4155/comments
|
https://api.github.com/repos/psf/requests/issues/4155/events
|
https://github.com/psf/requests/issues/4155
| 235,689,020 |
MDU6SXNzdWUyMzU2ODkwMjA=
| 4,155 |
Multiple values in a single param as list
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10487167?v=4",
"events_url": "https://api.github.com/users/mayukh18/events{/privacy}",
"followers_url": "https://api.github.com/users/mayukh18/followers",
"following_url": "https://api.github.com/users/mayukh18/following{/other_user}",
"gists_url": "https://api.github.com/users/mayukh18/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mayukh18",
"id": 10487167,
"login": "mayukh18",
"node_id": "MDQ6VXNlcjEwNDg3MTY3",
"organizations_url": "https://api.github.com/users/mayukh18/orgs",
"received_events_url": "https://api.github.com/users/mayukh18/received_events",
"repos_url": "https://api.github.com/users/mayukh18/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mayukh18/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mayukh18/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mayukh18",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-13T20:51:59Z
|
2021-09-08T08:00:45Z
|
2017-06-13T21:11:52Z
|
NONE
|
resolved
|
I don't know if this has already been discussed earlier.
### What happens now
`GET "https://graph.facebook.com/v2.6/USER_ID?fields=first_name,last_name,gender&access_token=PAGE_ACCESS_TOKEN"`
is done with the help using requests by
`r = requests.get('https://graph.facebook.com/v2.6/' + USER_ID, params={
'fields': 'first_name,last_name,gender',
'access_token': PAGE_ACCESS_TOKEN )})`
### Preferred way of doing it
`r = requests.get('https://graph.facebook.com/v2.6/' + USER_ID, params={
'fields': [ 'first_name', 'last_name', 'gender'],
'access_token': PAGE_ACCESS_TOKEN )})`
I feel this will be a more pythonic way to do it if that is even a word. When I was working on it I found the existing solution not so user friendly. I would love to take this up and contribute.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4155/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4155/timeline
| null |
completed
| null | null | false |
[
"Thanks for your enthusiasm! Unfortunately there is no standard for handling a list of values, and multiple possible ways to represent them. For this reason Requests largely remains neutral on them: if you pass us a list, we'll just encode them all separately. Given that we have a pre-existing behaviour for this syntax, I don't think we can accept this kind of change. "
] |
https://api.github.com/repos/psf/requests/issues/4154
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4154/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4154/comments
|
https://api.github.com/repos/psf/requests/issues/4154/events
|
https://github.com/psf/requests/issues/4154
| 235,365,747 |
MDU6SXNzdWUyMzUzNjU3NDc=
| 4,154 |
urllib3.exceptions.SSLError: ("bad handshake: SysCallError(-1, 'Unexpected EOF')",)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/29382637?v=4",
"events_url": "https://api.github.com/users/MisterE0/events{/privacy}",
"followers_url": "https://api.github.com/users/MisterE0/followers",
"following_url": "https://api.github.com/users/MisterE0/following{/other_user}",
"gists_url": "https://api.github.com/users/MisterE0/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/MisterE0",
"id": 29382637,
"login": "MisterE0",
"node_id": "MDQ6VXNlcjI5MzgyNjM3",
"organizations_url": "https://api.github.com/users/MisterE0/orgs",
"received_events_url": "https://api.github.com/users/MisterE0/received_events",
"repos_url": "https://api.github.com/users/MisterE0/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/MisterE0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MisterE0/subscriptions",
"type": "User",
"url": "https://api.github.com/users/MisterE0",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2017-06-12T21:06:34Z
|
2021-09-08T08:00:45Z
|
2017-06-13T05:49:05Z
|
NONE
|
resolved
|
I am receiving a bad handshake error when attempting to access a specific site. From my very limited understanding, I am assuming that this error arises during hello message phase, however, I am having difficulties understanding the error and how to proceed with resolving this error.
Using Chrome the selected cipher suite is:
Cipher Suite: TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (0xc030)
I have tried doing pip install -U requests[security] but the error persists.
## Actual Result
Traceback (most recent call last):
File "E:\Miniconda3\lib\site-packages\urllib3\connectionpool.py", line 600, in urlopen
chunked=chunked)
File "E:\Miniconda3\lib\site-packages\urllib3\connectionpool.py", line 345, in _make_request
self._validate_conn(conn)
File "E:\Miniconda3\lib\site-packages\urllib3\connectionpool.py", line 844, in _validate_conn
conn.connect()
File "E:\Miniconda3\lib\site-packages\urllib3\connection.py", line 326, in connect
ssl_context=context)
File "E:\Miniconda3\lib\site-packages\urllib3\util\ssl_.py", line 325, in ssl_wrap_socket
return context.wrap_socket(sock, server_hostname=server_hostname)
File "E:\Miniconda3\lib\site-packages\urllib3\contrib\pyopenssl.py", line 445, in wrap_socket
raise ssl.SSLError('bad handshake: %r' % e)
ssl.SSLError: ("bad handshake: SysCallError(-1, 'Unexpected EOF')",)
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": "1.9"
},
"implementation": {
"name": "CPython",
"version": "3.6.0"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "1010006f",
"version": "17.0.0"
},
"requests": {
"version": "2.17.3"
},
"system_ssl": {
"version": "100020af"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": true
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4154/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4154/timeline
| null |
completed
| null | null | false |
[
"Huh, this is quite a surprise: it looks like your environment is fine. Can you try installing literally *just* Requests in an environment (no PyOpenSSL) and see if that can reach the host?",
"Thank you kindly for the reply. \r\n\r\nWithout PyOpenSSL I receive the following error:\r\nssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:749)\r\n\r\nThe website I am attempting to access is:\r\nhttps://www.superiorjobs.com/Default.aspx\r\n",
"Are you sure Chrome negotiates that cipher suite? [SSLLabs says the server doesn't support it](https://www.ssllabs.com/ssltest/analyze.html?d=www.superiorjobs.com)",
"Chrome for me loads it fine.\r\n\r\nDoes give an \"Obsolete\" warning in the Dev tools though.\r\n\r\n\r\n\r\n",
"Server hello says that it is using version TLS 1.2. \r\n\r\nWhat would be my next step to trying to resolve this error if there happens to be one?",
"The server hello is accurate: the server nominally supports TLSv1.2, it just doesn't support any of the cipher suites. \r\n\r\nWe removed 3DES support. You can re-add it for this host [as shown in this blog post](https://lukasa.co.uk/2017/02/Configuring_TLS_With_Requests/)"
] |
https://api.github.com/repos/psf/requests/issues/4153
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4153/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4153/comments
|
https://api.github.com/repos/psf/requests/issues/4153/events
|
https://github.com/psf/requests/issues/4153
| 235,101,481 |
MDU6SXNzdWUyMzUxMDE0ODE=
| 4,153 |
how to post multi same name k-v to website?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/15062548?v=4",
"events_url": "https://api.github.com/users/cxgreat2014/events{/privacy}",
"followers_url": "https://api.github.com/users/cxgreat2014/followers",
"following_url": "https://api.github.com/users/cxgreat2014/following{/other_user}",
"gists_url": "https://api.github.com/users/cxgreat2014/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cxgreat2014",
"id": 15062548,
"login": "cxgreat2014",
"node_id": "MDQ6VXNlcjE1MDYyNTQ4",
"organizations_url": "https://api.github.com/users/cxgreat2014/orgs",
"received_events_url": "https://api.github.com/users/cxgreat2014/received_events",
"repos_url": "https://api.github.com/users/cxgreat2014/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cxgreat2014/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cxgreat2014/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cxgreat2014",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-12T00:14:23Z
|
2021-09-08T09:00:34Z
|
2017-06-12T01:04:31Z
|
NONE
|
resolved
|
like this:
this post data have 3 key name 'tags[]' and value is not same, how to use requests post data like this?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/15062548?v=4",
"events_url": "https://api.github.com/users/cxgreat2014/events{/privacy}",
"followers_url": "https://api.github.com/users/cxgreat2014/followers",
"following_url": "https://api.github.com/users/cxgreat2014/following{/other_user}",
"gists_url": "https://api.github.com/users/cxgreat2014/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cxgreat2014",
"id": 15062548,
"login": "cxgreat2014",
"node_id": "MDQ6VXNlcjE1MDYyNTQ4",
"organizations_url": "https://api.github.com/users/cxgreat2014/orgs",
"received_events_url": "https://api.github.com/users/cxgreat2014/received_events",
"repos_url": "https://api.github.com/users/cxgreat2014/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cxgreat2014/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cxgreat2014/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cxgreat2014",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4153/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4153/timeline
| null |
completed
| null | null | false |
[
"find answer in https://stackoverflow.com/questions/26444557/how-to-submit-multiple-files-with-the-same-post-name-with-requests\r\n\r\n```\r\ndata = {'raw','this is a test', 'title':'test test test', 'tags[]': ['test', 'submit', 'tool']}\r\nrequests.post('example.com', data)\r\n```\r\nwish add it to docs"
] |
https://api.github.com/repos/psf/requests/issues/4152
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4152/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4152/comments
|
https://api.github.com/repos/psf/requests/issues/4152/events
|
https://github.com/psf/requests/pull/4152
| 235,079,597 |
MDExOlB1bGxSZXF1ZXN0MTI1MDMzNDU2
| 4,152 |
Fix a typo: paramters -> parameters
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1006477?v=4",
"events_url": "https://api.github.com/users/felixonmars/events{/privacy}",
"followers_url": "https://api.github.com/users/felixonmars/followers",
"following_url": "https://api.github.com/users/felixonmars/following{/other_user}",
"gists_url": "https://api.github.com/users/felixonmars/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/felixonmars",
"id": 1006477,
"login": "felixonmars",
"node_id": "MDQ6VXNlcjEwMDY0Nzc=",
"organizations_url": "https://api.github.com/users/felixonmars/orgs",
"received_events_url": "https://api.github.com/users/felixonmars/received_events",
"repos_url": "https://api.github.com/users/felixonmars/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/felixonmars/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/felixonmars/subscriptions",
"type": "User",
"url": "https://api.github.com/users/felixonmars",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-06-11T17:27:19Z
|
2021-09-05T00:07:13Z
|
2017-06-11T17:34:36Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4152/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4152/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4152.diff",
"html_url": "https://github.com/psf/requests/pull/4152",
"merged_at": "2017-06-11T17:34:36Z",
"patch_url": "https://github.com/psf/requests/pull/4152.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4152"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4151
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4151/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4151/comments
|
https://api.github.com/repos/psf/requests/issues/4151/events
|
https://github.com/psf/requests/pull/4151
| 235,033,448 |
MDExOlB1bGxSZXF1ZXN0MTI1MDA4MDk3
| 4,151 |
Remove exec permission from files that shouldn't have it
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1441325?v=4",
"events_url": "https://api.github.com/users/justinmayhew/events{/privacy}",
"followers_url": "https://api.github.com/users/justinmayhew/followers",
"following_url": "https://api.github.com/users/justinmayhew/following{/other_user}",
"gists_url": "https://api.github.com/users/justinmayhew/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/justinmayhew",
"id": 1441325,
"login": "justinmayhew",
"node_id": "MDQ6VXNlcjE0NDEzMjU=",
"organizations_url": "https://api.github.com/users/justinmayhew/orgs",
"received_events_url": "https://api.github.com/users/justinmayhew/received_events",
"repos_url": "https://api.github.com/users/justinmayhew/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/justinmayhew/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/justinmayhew/subscriptions",
"type": "User",
"url": "https://api.github.com/users/justinmayhew",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-06-10T23:47:57Z
|
2021-09-05T00:07:14Z
|
2017-06-11T09:26:52Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4151/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4151/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4151.diff",
"html_url": "https://github.com/psf/requests/pull/4151",
"merged_at": "2017-06-11T09:26:52Z",
"patch_url": "https://github.com/psf/requests/pull/4151.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4151"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4150
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4150/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4150/comments
|
https://api.github.com/repos/psf/requests/issues/4150/events
|
https://github.com/psf/requests/pull/4150
| 234,989,049 |
MDExOlB1bGxSZXF1ZXN0MTI0OTgzMjYw
| 4,150 |
delete prepare_auth func uless param
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10242001?v=4",
"events_url": "https://api.github.com/users/phantooom/events{/privacy}",
"followers_url": "https://api.github.com/users/phantooom/followers",
"following_url": "https://api.github.com/users/phantooom/following{/other_user}",
"gists_url": "https://api.github.com/users/phantooom/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/phantooom",
"id": 10242001,
"login": "phantooom",
"node_id": "MDQ6VXNlcjEwMjQyMDAx",
"organizations_url": "https://api.github.com/users/phantooom/orgs",
"received_events_url": "https://api.github.com/users/phantooom/received_events",
"repos_url": "https://api.github.com/users/phantooom/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/phantooom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/phantooom/subscriptions",
"type": "User",
"url": "https://api.github.com/users/phantooom",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-10T08:27:18Z
|
2021-09-05T00:07:12Z
|
2017-06-10T08:49:18Z
|
NONE
|
resolved
|
url is a useless param.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4150/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4150/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4150.diff",
"html_url": "https://github.com/psf/requests/pull/4150",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4150.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4150"
}
| true |
[
"Thanks for this!\r\n\r\nHowever, while we don't use this it's possible that anyone subclassing might. I'm very reluctant to remove this with no good reason, as it's definitely a breaking change."
] |
https://api.github.com/repos/psf/requests/issues/4149
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4149/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4149/comments
|
https://api.github.com/repos/psf/requests/issues/4149/events
|
https://github.com/psf/requests/issues/4149
| 234,978,301 |
MDU6SXNzdWUyMzQ5NzgzMDE=
| 4,149 |
Cannot find reference 'urllib3' in packages.py
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/26851112?v=4",
"events_url": "https://api.github.com/users/arthur17/events{/privacy}",
"followers_url": "https://api.github.com/users/arthur17/followers",
"following_url": "https://api.github.com/users/arthur17/following{/other_user}",
"gists_url": "https://api.github.com/users/arthur17/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/arthur17",
"id": 26851112,
"login": "arthur17",
"node_id": "MDQ6VXNlcjI2ODUxMTEy",
"organizations_url": "https://api.github.com/users/arthur17/orgs",
"received_events_url": "https://api.github.com/users/arthur17/received_events",
"repos_url": "https://api.github.com/users/arthur17/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/arthur17/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arthur17/subscriptions",
"type": "User",
"url": "https://api.github.com/users/arthur17",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-06-10T04:05:08Z
|
2021-08-30T00:06:13Z
|
2017-06-10T07:01:17Z
|
NONE
|
resolved
|
**Summary**.
Can not find urllib3 when using latest `PyCharm` and `requests` from versions 2.17.1 to 2.17.3
**What you expected.**
Expected `urllib3` to be found on `packages.py`
**What happened instead.**
**Steps to reproduce**
+ Open (or create) any project in PyCharm
+ You can use the systems Python or a virtualenv
+ Install requests 2.17.3 (by using pip on terminal or by going to project interpreter settings)
+ Try to import urllib3
+ `from requests.packages.urllib3.exceptions import InsecureRequestWarning`
Maybe it has something to do with db076c098e962b5096f6b0c77d69b80396228464?
**System Information**
```
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "3.5.3"
},
"platform": {
"release": "4.4.0-79-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.17.3"
},
"system_ssl": {
"version": "1000207f"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4149/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4149/timeline
| null |
completed
| null | null | false |
[
"Hrm. So PyCharm is wrong here: this path does exist. But it's added dynamically, which may cause PyCharm some problems. I recommend opening a bug report with PyCharm. ",
"Copy the urllib3 folder into the package. because it doesn't install it dependency itself.",
"try installing urllib3 and then.\r\nfrom urllib3.exceptions import InsecureRequestWarning\r\n"
] |
https://api.github.com/repos/psf/requests/issues/4148
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4148/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4148/comments
|
https://api.github.com/repos/psf/requests/issues/4148/events
|
https://github.com/psf/requests/issues/4148
| 234,913,602 |
MDU6SXNzdWUyMzQ5MTM2MDI=
| 4,148 |
http response is not decoded when encoding is missing from the response header, even if decode_unicode is set
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11225761?v=4",
"events_url": "https://api.github.com/users/mx237/events{/privacy}",
"followers_url": "https://api.github.com/users/mx237/followers",
"following_url": "https://api.github.com/users/mx237/following{/other_user}",
"gists_url": "https://api.github.com/users/mx237/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mx237",
"id": 11225761,
"login": "mx237",
"node_id": "MDQ6VXNlcjExMjI1NzYx",
"organizations_url": "https://api.github.com/users/mx237/orgs",
"received_events_url": "https://api.github.com/users/mx237/received_events",
"repos_url": "https://api.github.com/users/mx237/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mx237/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mx237/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mx237",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-09T19:06:15Z
|
2021-09-08T08:00:44Z
|
2017-06-09T19:15:41Z
|
NONE
|
resolved
|
Platform: Win7 Pro SP1
Python: 3.6.1 64 bit
package:
requests==2.17.3
requests-file==1.4.2
requests-ftp==0.3.1
urllib3==1.21.1
When I try to request [http://www.google.com/finance/historical?q=NASDAQ%3AAAPL&startdate=Jun+1%2C+2017&enddate=Jun+2%2C+2017&output=csv](http://www.google.com/finance/historical?q=NASDAQ%3AAAPL&startdate=Jun+1%2C+2017&enddate=Jun+2%2C+2017&output=csv), the http response has no encoding info. However, the response is utf-8 encoded with utf-8 BOM.
Even if I set `decode_unicode=True` in `iter_content`, it does not try to decode the content and simply gives the raw bytes.
I wonder if this is a designed feature or could you add a feature to peek the few bytes in the beginning and try to guess the encoding from BOM when `decode_unicode` is set and the encoding is not available?
Thank you very much!
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4148/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4148/timeline
| null |
completed
| null | null | false |
[
"This behaviour of `iter_content` is unfortunately well-known: see #3574 for a PR that fixed this issue as reported in #3359 and #3481. Unfortunately, to resolve it we have to turn this into an error condition, which is a breaking change and so this change is not making it into the v2 series: it'll land in v3.\r\n\r\nTo work around the problem, you can set the encoding yourself via `response.encoding`:\r\n\r\n```python\r\nresponse.encoding = 'utf-8'\r\n```\r\n\r\nSorry we can't do more to help!"
] |
https://api.github.com/repos/psf/requests/issues/4147
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4147/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4147/comments
|
https://api.github.com/repos/psf/requests/issues/4147/events
|
https://github.com/psf/requests/issues/4147
| 234,894,812 |
MDU6SXNzdWUyMzQ4OTQ4MTI=
| 4,147 |
Urllib3 ConnectionError exception passing through requests API
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3619262?v=4",
"events_url": "https://api.github.com/users/aJetHorn/events{/privacy}",
"followers_url": "https://api.github.com/users/aJetHorn/followers",
"following_url": "https://api.github.com/users/aJetHorn/following{/other_user}",
"gists_url": "https://api.github.com/users/aJetHorn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aJetHorn",
"id": 3619262,
"login": "aJetHorn",
"node_id": "MDQ6VXNlcjM2MTkyNjI=",
"organizations_url": "https://api.github.com/users/aJetHorn/orgs",
"received_events_url": "https://api.github.com/users/aJetHorn/received_events",
"repos_url": "https://api.github.com/users/aJetHorn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aJetHorn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aJetHorn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aJetHorn",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-06-09T17:44:20Z
|
2021-09-06T00:06:46Z
|
2017-06-09T20:58:28Z
|
NONE
|
resolved
|
I am using Requests Version: 2.11.1 catching all request exceptions like this:
except requests.exceptions.RequestException as e:
logger.debug("%s", str(e))
However, this does not catch a NewConnectionError thrown by requests.packages.urllib3.connection.HTTPConnection
The full error statement is:
ConnectionError: HTTPConnectionPool(host='REDACTED', port=27001): Max retries exceeded with url: /REDACTED (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x6bf5a50>: Failed to establish a new connection: [Errno 111] ECONNREFUSED',))
Based off [https://github.com/requests/requests/issues/1572](https://github.com/requests/requests/issues/1572), it appears that all urllib3 exceptions should be caught by requests.exceptions.RequestException and that this falls into the category of an exception leak.
Full trace:
Traceback (most recent call last):
...
File "REDACTED/app/process.py", line 399, in REDACTED
r = requests.post(url, data=json.dumps(payload), headers=headers)
File "/usr/lib/python2.7/site-packages/requests/api.py", line 110, in post
return request('post', url, data=data, json=json, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/api.py", line 56, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 475, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 596, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 487, in send
raise ConnectionError(e, request=request)
ConnectionError: HTTPConnectionPool(host='REDACTED', port=27000): Max retries exceeded with url: REDACTED (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x6bf5a50>: Failed to establish a new connection: [Errno 111] ECONNREFUSED',))
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3619262?v=4",
"events_url": "https://api.github.com/users/aJetHorn/events{/privacy}",
"followers_url": "https://api.github.com/users/aJetHorn/followers",
"following_url": "https://api.github.com/users/aJetHorn/following{/other_user}",
"gists_url": "https://api.github.com/users/aJetHorn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aJetHorn",
"id": 3619262,
"login": "aJetHorn",
"node_id": "MDQ6VXNlcjM2MTkyNjI=",
"organizations_url": "https://api.github.com/users/aJetHorn/orgs",
"received_events_url": "https://api.github.com/users/aJetHorn/received_events",
"repos_url": "https://api.github.com/users/aJetHorn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aJetHorn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aJetHorn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aJetHorn",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4147/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4147/timeline
| null |
completed
| null | null | false |
[
"Hey @aJetHorn, it looks like this is a `ConnectionError` wrapping a `NewConnectionError` in your traceback. The `ConnectionError` inherits from `RequestsException`, so it should be caught. Do you have an example domain you're experiencing this on?\r\n\r\nThis is the repro I used to test this:\r\n\r\n```python\r\nimport requests\r\n\r\ntry:\r\n requests.get('https://not_a_real_domain.com')\r\nexcept requests.exceptions.RequestException as e:\r\n print('exception caught', e)\r\n```\r\n\r\nIt is a slightly different underlying error message, but the same type of Exception object.",
"@nateprewitt I just realized that the environment where I was running this had not been updated to handle all exceptions (the try catch wasn't what I mistakenly stated above). Sorry about that.",
"No worries, glad you got it sorted 😊"
] |
https://api.github.com/repos/psf/requests/issues/4146
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4146/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4146/comments
|
https://api.github.com/repos/psf/requests/issues/4146/events
|
https://github.com/psf/requests/pull/4146
| 234,884,349 |
MDExOlB1bGxSZXF1ZXN0MTI0OTA5NDAy
| 4,146 |
Revert "Convert version compatibility checks to warnings"
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2017-06-09T16:55:15Z
|
2021-09-02T00:07:46Z
|
2018-02-27T17:11:36Z
|
CONTRIBUTOR
|
resolved
|
Reverts requests/requests#4144
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4146/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4146/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4146.diff",
"html_url": "https://github.com/psf/requests/pull/4146",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4146.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4146"
}
| true |
[
"continuation of https://github.com/requests/requests/pull/4144#issuecomment-307426091",
"restarting for windows",
"So we definitely don't want a complete revert of this. I do think we we want a selective revert though. We absolutely want to be more resilient to versions we can't parse. I don't think we want to emit warnings though.",
"windows passed!",
"Alright, I'd like to wrap this up so these commits aren't stuck in limbo. @sigmavirus24, my take away from the discussion is you'd still like to see exceptions over the warnings but allow for more resilient checks. What do you see happening when we can't parse a dependency? Is that still an exception with the unparsed version included in the message? How would we allow something like `python-telegram-bot` to work if they force a vendored copy of urllib3 onto the path?\r\n\r\nYou also said you'd rather not use `assert` statements to the `python -O` concerns. I'm assuming you'd rather see this as a conditional check that raises the exception?\r\n\r\nIf that all sounds correct, and @Lukasa/@kennethreitz are on board, I'll put the follow-up together.",
"> How would we allow something like python-telegram-bot to work if they force a vendored copy of urllib3 onto the path?\r\n\r\nBriefly responding to one question here: The point is to not allow that. I have to wonder if the exception shouldn't also include the location to the module so people can see \"Hey, telegram bot is doing something real stupid and it's breaking requests.\""
] |
https://api.github.com/repos/psf/requests/issues/4145
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4145/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4145/comments
|
https://api.github.com/repos/psf/requests/issues/4145/events
|
https://github.com/psf/requests/pull/4145
| 234,763,275 |
MDExOlB1bGxSZXF1ZXN0MTI0ODIwMzA4
| 4,145 |
typo
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/15275188?v=4",
"events_url": "https://api.github.com/users/elliotgao2/events{/privacy}",
"followers_url": "https://api.github.com/users/elliotgao2/followers",
"following_url": "https://api.github.com/users/elliotgao2/following{/other_user}",
"gists_url": "https://api.github.com/users/elliotgao2/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/elliotgao2",
"id": 15275188,
"login": "elliotgao2",
"node_id": "MDQ6VXNlcjE1Mjc1MTg4",
"organizations_url": "https://api.github.com/users/elliotgao2/orgs",
"received_events_url": "https://api.github.com/users/elliotgao2/received_events",
"repos_url": "https://api.github.com/users/elliotgao2/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/elliotgao2/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/elliotgao2/subscriptions",
"type": "User",
"url": "https://api.github.com/users/elliotgao2",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-06-09T08:56:31Z
|
2021-09-05T00:07:15Z
|
2017-06-09T09:04:40Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4145/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4145/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4145.diff",
"html_url": "https://github.com/psf/requests/pull/4145",
"merged_at": "2017-06-09T09:04:40Z",
"patch_url": "https://github.com/psf/requests/pull/4145.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4145"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4144
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4144/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4144/comments
|
https://api.github.com/repos/psf/requests/issues/4144/events
|
https://github.com/psf/requests/pull/4144
| 234,656,705 |
MDExOlB1bGxSZXF1ZXN0MTI0NzQ0ODEw
| 4,144 |
Convert version compatibility checks to warnings
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 12 |
2017-06-08T21:07:53Z
|
2021-09-05T00:07:15Z
|
2017-06-09T01:40:08Z
|
MEMBER
|
resolved
|
This patch will convert the dependency exceptions into warnings, preventing the forced halt while importing Requests. I condensed the message into a single response, but we can expand that out if needed. It just seemed like another place for updates to be forgotten.
I'd also like to test this function, but due to the requirements changing with each release, it's hard to write something that won't need to be updated in parallel. We could look at parsing the requirements out of `requires` but that seems less than ideal. If I'm being honest, I'm not crazy about expanding the code around this any more than we absolutely have to.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4144/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4144/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4144.diff",
"html_url": "https://github.com/psf/requests/pull/4144",
"merged_at": "2017-06-09T01:40:08Z",
"patch_url": "https://github.com/psf/requests/pull/4144.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4144"
}
| true |
[
"Err, force pushing dismisses reviews now? I took care of the flake8 issue with a `# noqa` because we will likely want to use `patch` in the future. Removing it creates a lot of clutter.",
"Alright, I'm going to merge this then since everything except the broken windows tests are passing.",
"Did @sigmavirus24 have any thoughts on this? Hard exceptions was his idea. ",
"Yeah, warnings are going to get missed by people in their log messages. People already tend to silence our warnings because our warnings and urllib3's warnings are far too noisy as it is. This is just going to cause us a headache. Yes. People are raising issues because someone shipped a version of a dependency using `dev` as the string, but that's no justification to switch away from exceptions.",
"Well, hang on then. What, exactly, is our intention here? I don't think we should be in the business of checking the versions of our dependencies: if we're going to specify dependencies let's just do that. This code is error-prone and requires constant updating, and any error we encounter in doing this causes us weird errors that we have to debug. I don't know that I see any value in having this code in \"hard-fail\" mode. I don't believe it's sensible for Requests to go on strike just because it's not happy with the version of urllib3 present in the environment: we should just try to use it and if it blows up at least we emitted some text that says what was wrong.",
"> at least we emitted some text that says what was wrong.\r\n\r\nThat's not reasonable. We emitted that at start up and by the time this might blow up those logs will have been rotated out. If we're going to start not restricting what versions of urllib3 we want to rely on (outside of pip or whatever package manager a user installs Requests with) then we need to start testing a much larger swath of urllib3 versions. Otherwise, we're now opening ourselves up to issues where someone has urllib3 1.2.1 installed, they see no warning because their version of Python silences them by default, they have no logs, and everything's blowing up in their face. We can tell people to upgrade urllib3 until we're blue in the face or we can just blow up in their face with a clear exception telling them why Requests won't function as they expect it to. I prefer the former. Preferably with an exception message that links to documentation.",
"> Otherwise, we're now opening ourselves up to issues where someone has urllib3 1.2.1 installed, they see no warning because their version of Python silences them by default, they have no logs, and everything's blowing up in their face\r\n\r\nAre there any versions of Python that silence all warnings by default? I don't think there are: there are plenty that silence *deprecation* warnings, but I don't know any that silence all warnings. If not, I don't consider this a particularly meaningful example.\r\n\r\nLet's consider the less extreme example: someone uses Requests with an out-of-support urllib3. There are two options: either it works, or it does not. If it does not, and they have lost the errors, we ask them to provide the output of `python -m requests.help` *at which point they see the warning again*. Even if they don't, and persist through the warning, we'll have an immediate issue close because of the unsupported version.\r\n\r\nHell, we could even have `python -m requests.help` print messages when run that say \"your urllib3 is outside the acceptable version range, maybe deal with that\".\r\n\r\nIf we're wedded to the idea of doing this, then we should discuss how resilient we should be. Should we be writing this code ourselves or should we use the packaging library to handle this? Should we be productising it and writing tests for it rather than YOLOing it into a `__init__.py` file?\r\n\r\nAdditionally, we should probably have a policy: what do we actually support? More importantly, if we're throwing exceptions, what do we *outright forbid*? Do we outright forbid running with an install from github? What about for development or testing purposes?\r\n\r\nBecause that's what the hard-fail policy is: it's saying that we know better than you to the extent that we simply will not allow you to run a non-supported configuration at all. I think that's a pretty strong position to take. I'd much rather take a position that running a non-supported configuration is non-supported, give ourselves a bunch of tools to diagnose such configurations and warn in the face of them, and then let people who choose to run outside of support to do so.",
"Sorry, if I'd know this was a contentious issue, I wouldn't have merged so quickly.\r\n\r\nAs I said in the initial PR message, I'm not excited about this block of code in general, it seems prone to unintentional failure. If we're going to hardline on which versions Requests will and won't work with, this should be built out more robustly and thoroughly tested. I'm not sure I am in favor of that approach though.\r\n\r\nAt the very least, we need to be catching exceptions like `ValueError` during unpacking and giving the user useful information. The amount of circling we did to determine `python-telegram-bot` was vendoring a copy of urllib3 was unnecessary. We should be outputting what version Requests is seeing when it fails to at least narrow down the issue. I also feel like refusing to allow projects to vendor copies of urllib3, or worse, forcing those vendoring to fake the version number is asking for more trouble.",
"> I also feel like refusing to allow projects to vendor copies of urllib3, or worse, forcing those vendoring to fake the version number is asking for more trouble.\r\n\r\nI don't believe the issue was solely in their vendoring of urllib3. I don't think any of us dug in quite far, but they were almost certainly injecting their `urllib3` into `sys.modules` as *the* urllib3 which is a horrible thing to do at all. That was interfering with us only if we were imported after that `python-telegram-bot`. This is why `python -m requests.help` was useless. Run in isolation, it shows no information about what the user is experiencing. If we didn't have the version checking logic, we'd never have caught this and would have had a far harder bug to debug for the users that saw this.\r\n\r\nHere's my main concern: Requests has likely wildly de-stabilized its users by unvendoring without a version of pip that has a real dependency resolver (which wouldn't have caught the `python-telegram-bot` issue or made it easier to debug). Except on some distros, we had some good guarantees about known good versions of our dependencies being there. With however million downloads we've hit, we should be considering the stability of the project. Raising exceptions like this is *ugly* but it's the next best thing.\r\n\r\nSo far, we've had little problem with users providing `python -m requests.help` but based on my experiences with similar utilities in other projects, some users will just refuse to provide it. Are we all in agreement that we just won't help those users? I doubt it. We already have a policy not to answer questions here and to instead refer people to StackOverflow but we rarely even enforce that anymore.\r\n\r\n---\r\n\r\n> Let's consider the less extreme example: someone uses Requests with an out-of-support urllib3. There are two options: either it works, or it does not.\r\n\r\nI honestly think that's overly simplistic. How about a user using a version of urllib3 with older less secure cipher suite preferences that appears to work but is now compromising their security? Do we not care about that? We like to claim we're secure by default, and certainly, that's a minor issue overall in most of the cases we've removed cipher suites, but do we want to open ourselves up to that? On one machine 2.17.4 will negotiate with a stronger suite of ciphers while the same version on another will negotiate with subtly weaker ones? Don't we care about being secure and consistently secure for our users?\r\n\r\n> Are there any versions of Python that silence all warnings by default?\r\n\r\nYou're right. The caffeine had not yet kicked in.",
"Created a new PR to revert this, further discussion can take place there (as it's an open issue instead of a closed one) https://github.com/requests/requests/pull/4146",
"> How about a user using a version of urllib3 with older less secure cipher suite preferences that appears to work but is now compromising their security?\r\n\r\nHow about it? This is a problem we need to tackle *anyway*: the simple act of unvendoring urllib3 means that presumably *at some point* we're going to start widening the version pin, and if that's the case then we need to tackle this problem at some point anyway. Why not now?\r\n\r\nIf Requests is responsible for its users security then it should take that responsibility. Before, because we vendored urllib3, the cipher string was within our codebase. Now it's not. We need to live with the reality that we don't own the cipher string anymore, and if we want to make assertions about security separate from the ones urllib3 provides then it's our responsibility to actually do that, rather than treat urllib3 version as a proxy for it.\r\n\r\nRegardless, I don't care about warnings vs errors really: reasonable people can disagree. What I care about is that right now we've spent a bunch of dev cycles chasing our tails because this code errors out when it shouldn't. `\"dev\"` is a perfectly valid urllib3 version identifier, and if we can't handle it then our code is broken. More generally any failure to parse the version identifier shoudn't lead to a mystery error, it should say *very clearly* that we were unable to parse the version identifier.\r\n\r\nWhile we're here, this code should have tests. Actual tests that actually confirm that it actually does what we think it does. It's mildly horrifying that we shipped this code without it.",
"@Lukasa, I completely agree on tests. That was something I brought up in the original PR but it wasn't addressed. The problem is we're testing a moving target, so what constitutes a valid version will not necessarily remain true between each release, breaking the tests. We need a way to dynamically retrieve \"good\" versions which would probably involved something like parsing the `requires` field. We also need to choose failing test values that will always fail but match expected formats."
] |
https://api.github.com/repos/psf/requests/issues/4143
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4143/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4143/comments
|
https://api.github.com/repos/psf/requests/issues/4143/events
|
https://github.com/psf/requests/issues/4143
| 234,632,262 |
MDU6SXNzdWUyMzQ2MzIyNjI=
| 4,143 |
Can't parse version information, urllib3 returns "['dev']"
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/21175939?v=4",
"events_url": "https://api.github.com/users/Ichicoro/events{/privacy}",
"followers_url": "https://api.github.com/users/Ichicoro/followers",
"following_url": "https://api.github.com/users/Ichicoro/following{/other_user}",
"gists_url": "https://api.github.com/users/Ichicoro/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Ichicoro",
"id": 21175939,
"login": "Ichicoro",
"node_id": "MDQ6VXNlcjIxMTc1OTM5",
"organizations_url": "https://api.github.com/users/Ichicoro/orgs",
"received_events_url": "https://api.github.com/users/Ichicoro/received_events",
"repos_url": "https://api.github.com/users/Ichicoro/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Ichicoro/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Ichicoro/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Ichicoro",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 10 |
2017-06-08T19:30:42Z
|
2021-09-08T08:00:46Z
|
2017-06-08T20:06:01Z
|
NONE
|
resolved
|
I wrote a script and tried to execute it. The python interpreter stopped the execution with a traceback saying that
```
Traceback (most recent call last):
File ".\main.py", line 3, in <module>
import lyricsgetter
File "C:\Users\smart\Documents\Projects\telegram-lyrics-bot\lyricsgetter.py", line 1, in <module>
import requests
File "C:\Users\smart\AppData\Local\Programs\Python\Python36\lib\site-packages\requests\__init__.py", line 53, in <module>
major, minor, patch = urllib3_version
ValueError: not enough values to unpack (expected 3, got 1)
```
I then tried adding a `print(urllib3_version)` before line 53 in `__init__.py`.
## Expected Result
`print(urllib3_version)` should have returned the version, and my script should have executed fine.
## Actual Result
`print(urllib3_version)` printed `['dev']` and stopped the execution of my script with a `ValueError`
## Reproduction Steps
```python
import requests
```
## System Information
$ python -m requests.help
```
['1', '21', '1']
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "3.6.0"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.17.3"
},
"system_ssl": {
"version": "100020af"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4143/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4143/timeline
| null |
completed
| null | null | false |
[
"That's quite fascinating especially given the output of `python -m requests.help` as you printed it which shows `urllib3` at version 1.21.1 and even `urllib3_version` as `['1', '21', '1']`.",
"Hey @Ichicoro, this is actually a duplicate of #4076. I'm in the process of finishing a PR to address this so it should be fixed in an upcoming release. Thanks for taking the time to make sure this was documented.",
"Can you share any of your code in the traceback?\r\n\r\n@nateprewitt this is related but different I think",
"`telegram-lyrics-bot` is using `python-telegram-bot` which vendors a custom version of urllib3. The vendored version has a `__version__` of `dev` which is what's causing this.",
"@sigmavirus24 Do you mean the code from my install of `requests` or from my project?",
"Ah I see @nateprewitt. @Ichicoro, @nateprewitt is in fact correct that this is a duplicate.",
"I am also getting this error at the moment. I don't understand why there is defintly urllib3 in version 1.21.1 installed, but in my code requests wants to import urllib3 in version ['dev']. I just don't get it. There is just one version of urllib3 installed in my virtualenv. \r\n",
"@fuuman Are you using anything that patches or overrides urllib3, e.g. `telegram`?",
"Yeah, I am using the [python-telegram-bot wrapper](https://github.com/python-telegram-bot/python-telegram-bot).",
"@fuuman Ok, see #4076, which reveals that telegram is aliasing your copy of urllib3."
] |
https://api.github.com/repos/psf/requests/issues/4142
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4142/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4142/comments
|
https://api.github.com/repos/psf/requests/issues/4142/events
|
https://github.com/psf/requests/issues/4142
| 234,357,629 |
MDU6SXNzdWUyMzQzNTc2Mjk=
| 4,142 |
No method to retrieve cookie object by name
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5554910?v=4",
"events_url": "https://api.github.com/users/lordjabez/events{/privacy}",
"followers_url": "https://api.github.com/users/lordjabez/followers",
"following_url": "https://api.github.com/users/lordjabez/following{/other_user}",
"gists_url": "https://api.github.com/users/lordjabez/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lordjabez",
"id": 5554910,
"login": "lordjabez",
"node_id": "MDQ6VXNlcjU1NTQ5MTA=",
"organizations_url": "https://api.github.com/users/lordjabez/orgs",
"received_events_url": "https://api.github.com/users/lordjabez/received_events",
"repos_url": "https://api.github.com/users/lordjabez/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lordjabez/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lordjabez/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lordjabez",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2017-06-07T22:09:39Z
|
2021-09-08T09:00:36Z
|
2017-06-08T17:37:49Z
|
NONE
|
resolved
|
I would like to be able to get a cookie object out of the cookie jar by name and inspect its attributes (e.g. domain, expires, secure flag). My use case is a test script that ensures my webserver is configuring cookies properly.
I expect to have some kind of function like `get` that returns the whole cookie object, not just the value, but no function seems to exist.
## Reproduction Steps
```python
import requests
response = requests.get('http://google.com')
response.cookies.get('NID') # Only returns cookie value
for c in response.cookies:
print(c) # c is entire cookie object
```
If this is a desired feature, I'd be happy to code it up myself. My suggestion is a simple `get_cookie` function, but am open to other ideas.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4142/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4142/timeline
| null |
completed
| null | null | false |
[
"You're right, this is not a feature that exists currently. I don't think we want it though: I'm reluctant to expand `RequestsCookieJar` too far, especially when we have some pretty mixed (ie. negative) feelings about cookielib. My inclination is that the best thing to do is for you to write a helper function that iterates over the cookiejar and does the search by name (this is how `RequestsCookieJar.get` works).",
"I agree, mostly because there's a possible future were were we remove Cookielib entirely from the equation, and want to keep it as abstract as possible. ",
"Thanks for the suggestion, though, @lordjabez! ✨🍰✨",
"A consideration for the future, however you decide to manage cookies, is the ability to inspect all cookie attributes, not just the value. This is a common use case for me writing automated tests to ensure web servers are doing the right things with their session cookies.\r\n\r\nAnd thank _you_ for a fantastic library."
] |
https://api.github.com/repos/psf/requests/issues/4141
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4141/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4141/comments
|
https://api.github.com/repos/psf/requests/issues/4141/events
|
https://github.com/psf/requests/issues/4141
| 234,202,579 |
MDU6SXNzdWUyMzQyMDI1Nzk=
| 4,141 |
Windows Jenkins CI failing on master
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/501702?v=4",
"events_url": "https://api.github.com/users/edmorley/events{/privacy}",
"followers_url": "https://api.github.com/users/edmorley/followers",
"following_url": "https://api.github.com/users/edmorley/following{/other_user}",
"gists_url": "https://api.github.com/users/edmorley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/edmorley",
"id": 501702,
"login": "edmorley",
"node_id": "MDQ6VXNlcjUwMTcwMg==",
"organizations_url": "https://api.github.com/users/edmorley/orgs",
"received_events_url": "https://api.github.com/users/edmorley/received_events",
"repos_url": "https://api.github.com/users/edmorley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/edmorley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/edmorley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/edmorley",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-07T13:05:29Z
|
2021-09-08T08:00:33Z
|
2017-07-27T14:53:44Z
|
CONTRIBUTOR
|
resolved
|
As spotted in #4136 and elsewhere, the Windows Jenkins CI job is failing on master:
http://jenkins.kennethreitz.org:8080/job/requests/job/requests-windows/buildTimeTrend
...with:
```
j:\jenkins\workspace\requests\requests-windows>.env\Scripts\pip install -r requirements.txt
Obtaining file:///J:/jenkins/workspace/requests/requests-windows (from -r requirements.txt (line 1))
Complete output from command python setup.py egg_info:
running egg_info
...
File "j:\jenkins\workspace\requests\requests-windows\.env\lib\site-packages\setuptools\command\egg_info.py", line 470, in append
if self._safe_path(path):
File "j:\jenkins\workspace\requests\requests-windows\.env\lib\site-packages\setuptools\command\egg_info.py", line 503, in _safe_path
if os.path.exists(u_path) or os.path.exists(utf8_path):
File "j:\jenkins\workspace\requests\requests-windows\.env\lib\genericpath.py", line 26, in exists
os.stat(path)
TypeError: stat() argument 1 must be encoded string without null bytes, not unicode
```
In addition, the script that reports the result to GitHub appears to be broken, since the GitHub status for the windows job says "Epic Fail! No test results found.", rather than "Failed" or similar.
cc @kennethreitz
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4141/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4141/timeline
| null |
completed
| null | null | false |
[
"Closing this out since the Windows CI issues seem to have been resolved."
] |
https://api.github.com/repos/psf/requests/issues/4140
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4140/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4140/comments
|
https://api.github.com/repos/psf/requests/issues/4140/events
|
https://github.com/psf/requests/pull/4140
| 234,198,383 |
MDExOlB1bGxSZXF1ZXN0MTI0NDEyMTUw
| 4,140 |
Clearer makefile for building README.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-06-07T12:50:46Z
|
2021-09-05T00:07:13Z
|
2017-06-09T17:30:57Z
|
MEMBER
|
resolved
|
Resolves #4138.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4140/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4140/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4140.diff",
"html_url": "https://github.com/psf/requests/pull/4140",
"merged_at": "2017-06-09T17:30:57Z",
"patch_url": "https://github.com/psf/requests/pull/4140.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4140"
}
| true |
[
"I'm not really thrilled with it, but I'm kinda short of other options. Short of actually improving the package in question to provide better errors, which it can't really do, this is kinda the best we can do. =(",
"Many thanks!"
] |
https://api.github.com/repos/psf/requests/issues/4139
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4139/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4139/comments
|
https://api.github.com/repos/psf/requests/issues/4139/events
|
https://github.com/psf/requests/issues/4139
| 234,088,546 |
MDU6SXNzdWUyMzQwODg1NDY=
| 4,139 |
why don't wrapper urllib3 LocationValueError("No host specified.")
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1680805?v=4",
"events_url": "https://api.github.com/users/dading/events{/privacy}",
"followers_url": "https://api.github.com/users/dading/followers",
"following_url": "https://api.github.com/users/dading/following{/other_user}",
"gists_url": "https://api.github.com/users/dading/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dading",
"id": 1680805,
"login": "dading",
"node_id": "MDQ6VXNlcjE2ODA4MDU=",
"organizations_url": "https://api.github.com/users/dading/orgs",
"received_events_url": "https://api.github.com/users/dading/received_events",
"repos_url": "https://api.github.com/users/dading/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dading/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dading/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dading",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-06-07T04:20:38Z
|
2021-09-08T09:00:37Z
|
2017-06-07T13:08:21Z
|
NONE
|
resolved
|
Summary.
## Expected Result
i can import exception from requests.
## Actual Result
when i catch LocationValueError, i need import LocationValueError from urllib3.exceptions, not from requests....
## System Information
$ python v2.7.0
```
<paste here>
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1680805?v=4",
"events_url": "https://api.github.com/users/dading/events{/privacy}",
"followers_url": "https://api.github.com/users/dading/followers",
"following_url": "https://api.github.com/users/dading/following{/other_user}",
"gists_url": "https://api.github.com/users/dading/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dading",
"id": 1680805,
"login": "dading",
"node_id": "MDQ6VXNlcjE2ODA4MDU=",
"organizations_url": "https://api.github.com/users/dading/orgs",
"received_events_url": "https://api.github.com/users/dading/received_events",
"repos_url": "https://api.github.com/users/dading/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dading/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dading/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dading",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4139/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4139/timeline
| null |
completed
| null | null | false |
[
"Hey @dading, it looks like this may be a duplicate of #3220. Could you please provide some more information on when you're encountering this exception? Is it occurring with a specific domain, or is this failure periodic?\r\n\r\nCould you also provide the version of Requests you're currently using? Thank you!",
"I am wrong, thanks"
] |
https://api.github.com/repos/psf/requests/issues/4138
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4138/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4138/comments
|
https://api.github.com/repos/psf/requests/issues/4138/events
|
https://github.com/psf/requests/issues/4138
| 234,047,498 |
MDU6SXNzdWUyMzQwNDc0OTg=
| 4,138 |
Log output for `make test-readme` failures is not clear
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/501702?v=4",
"events_url": "https://api.github.com/users/edmorley/events{/privacy}",
"followers_url": "https://api.github.com/users/edmorley/followers",
"following_url": "https://api.github.com/users/edmorley/following{/other_user}",
"gists_url": "https://api.github.com/users/edmorley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/edmorley",
"id": 501702,
"login": "edmorley",
"node_id": "MDQ6VXNlcjUwMTcwMg==",
"organizations_url": "https://api.github.com/users/edmorley/orgs",
"received_events_url": "https://api.github.com/users/edmorley/received_events",
"repos_url": "https://api.github.com/users/edmorley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/edmorley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/edmorley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/edmorley",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-06T22:49:47Z
|
2021-09-08T09:00:35Z
|
2017-06-09T17:30:57Z
|
CONTRIBUTOR
|
resolved
|
The first round of CI for #4137 failed in the `readme` Jenkins job:
http://jenkins.kennethreitz.org:8080/job/requests/job/requests-readme/67/
The console output for the failure was:
```
...
Installing collected packages: requests
Found existing installation: requests 2.17.3
Uninstalling requests-2.17.3:
Successfully uninstalled requests-2.17.3
Running setup.py develop for requests
Successfully installed requests
+ make test-readme
python setup.py check -r -s
running check
warning: Check: :128: (WARNING/2) Bullet list ends without a blank line; unexpected unindent.
warning: Check: Invalid markup which will not be rendered on PyPI.
error: Please correct your package.
Makefile:11: recipe for target 'test-readme' failed
make: *** [test-readme] Error 1
Build step 'Virtualenv Builder' marked build as failure
```
(http://jenkins.kennethreitz.org:8080/job/requests/job/requests-readme/67/console)
This confused me initially, since the log output doesn't mention a particular filename, so all I had to go on was the name of the test (`test-readme`) - but the PR only modified `AUTHORS.rst`, `HISTORY.rst` and `docs/user/advanced.rst` - and not `README.rst`.
Not being familiar with `setup.py check`, and the functionality `docutils` adds to it, it took me a while to figure out it was validating the value passed to `long_description` in setup.py's `setup()`, which is:
```python
long_description=readme + '\n\n' + history,
```
...and therefore in my case the bad syntax was actually from `HISTORY.rst`.
Things that might make this more clear:
* The Makefile command being renamed to say `test-readme-history` or similar
* Leaving the makefile command named as-is, but in case of failure make it output "Validation of setup.py metadata failed! Check markup in X and Y"
* Using another way to validate the markup that scans individual files (rather than the concatenated text in setup.py) and can give specific filenames and line numbers
Many thanks :-)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4138/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4138/timeline
| null |
completed
| null | null | false |
[
"Also, currently the `test-readme` make command calls `python setup.py check -r -s` which isn't clear for someone who isn't familiar with the check command. Perhaps `python setup.py check --restructuredtext --strict` would make the purpose clearer?"
] |
https://api.github.com/repos/psf/requests/issues/4137
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4137/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4137/comments
|
https://api.github.com/repos/psf/requests/issues/4137/events
|
https://github.com/psf/requests/pull/4137
| 234,043,285 |
MDExOlB1bGxSZXF1ZXN0MTI0MzAxNzU0
| 4,137 |
Allow Requests.Response to be used as a context manager
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/501702?v=4",
"events_url": "https://api.github.com/users/edmorley/events{/privacy}",
"followers_url": "https://api.github.com/users/edmorley/followers",
"following_url": "https://api.github.com/users/edmorley/following{/other_user}",
"gists_url": "https://api.github.com/users/edmorley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/edmorley",
"id": 501702,
"login": "edmorley",
"node_id": "MDQ6VXNlcjUwMTcwMg==",
"organizations_url": "https://api.github.com/users/edmorley/orgs",
"received_events_url": "https://api.github.com/users/edmorley/received_events",
"repos_url": "https://api.github.com/users/edmorley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/edmorley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/edmorley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/edmorley",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-06T22:27:04Z
|
2021-09-05T00:07:15Z
|
2017-06-07T07:51:42Z
|
CONTRIBUTOR
|
resolved
|
This saves having to wrap the call to requests with `contextlib.closing()`, allowing it to be used directly in a `with` statement, like so:
```python
with requests.get('http://httpbin.org/get', stream=True) as r:
# Do things with the response here.
```
Fixes #4136.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4137/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4137/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4137.diff",
"html_url": "https://github.com/psf/requests/pull/4137",
"merged_at": "2017-06-07T07:51:42Z",
"patch_url": "https://github.com/psf/requests/pull/4137.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4137"
}
| true |
[
"FYI, @kennethreitz, as you can see here the master branch *is* failing on the Windows builder. @requests/core for the moment we can ignore that failing Windows test and continue to merge until @kennethreitz works out what's going on with the builder. ;)"
] |
https://api.github.com/repos/psf/requests/issues/4136
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4136/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4136/comments
|
https://api.github.com/repos/psf/requests/issues/4136/events
|
https://github.com/psf/requests/issues/4136
| 234,042,418 |
MDU6SXNzdWUyMzQwNDI0MTg=
| 4,136 |
Allow Requests.Response to be used as a context manager in `with` statements
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/501702?v=4",
"events_url": "https://api.github.com/users/edmorley/events{/privacy}",
"followers_url": "https://api.github.com/users/edmorley/followers",
"following_url": "https://api.github.com/users/edmorley/following{/other_user}",
"gists_url": "https://api.github.com/users/edmorley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/edmorley",
"id": 501702,
"login": "edmorley",
"node_id": "MDQ6VXNlcjUwMTcwMg==",
"organizations_url": "https://api.github.com/users/edmorley/orgs",
"received_events_url": "https://api.github.com/users/edmorley/received_events",
"repos_url": "https://api.github.com/users/edmorley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/edmorley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/edmorley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/edmorley",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-06-06T22:23:00Z
|
2021-09-08T09:00:38Z
|
2017-06-07T07:51:42Z
|
CONTRIBUTOR
|
resolved
|
The [docs for streaming responses](http://docs.python-requests.org/en/master/user/advanced/#body-content-workflow) currently state:
> If you find yourself partially reading request bodies (or not reading them at all) while using stream=True, you should consider using contextlib.closing ([documented here](http://docs.python.org/2/library/contextlib.html#contextlib.closing)), like this:
> ```python
> from contextlib import closing
>
> with closing(requests.get('http://httpbin.org/get', stream=True)) as r:
> # Do things with the response here.
> ```
It would be great to be able to omit `contextlib.closing()` entirely, and use the call to requests directly within a `with` statement, like so:
```python
with requests.get('http://httpbin.org/get', stream=True) as r:
# Do things with the response here.
```
However that currently results in `AttributeError: __exit__`, since [`Requests.Response`](https://github.com/requests/requests/blob/v2.17.3/requests/models.py#L576-L942) doesn't have the `__enter__` and `__exit__` methods expected of a context manager:
https://docs.python.org/3/reference/datamodel.html#context-managers
I think it would be worthwhile to add them, to allow safe streaming without the extra boilerplate. (There's also prior art - `Requests.Session()` [can be used as a context-manager](https://github.com/requests/requests/blob/v2.17.3/requests/sessions.py#L389-L393).)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 4,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 4,
"url": "https://api.github.com/repos/psf/requests/issues/4136/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4136/timeline
| null |
completed
| null | null | false |
[] |
https://api.github.com/repos/psf/requests/issues/4135
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4135/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4135/comments
|
https://api.github.com/repos/psf/requests/issues/4135/events
|
https://github.com/psf/requests/pull/4135
| 234,034,254 |
MDExOlB1bGxSZXF1ZXN0MTI0Mjk1MTU1
| 4,135 |
Add the pytest .cache/ directory to .gitignore
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/501702?v=4",
"events_url": "https://api.github.com/users/edmorley/events{/privacy}",
"followers_url": "https://api.github.com/users/edmorley/followers",
"following_url": "https://api.github.com/users/edmorley/following{/other_user}",
"gists_url": "https://api.github.com/users/edmorley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/edmorley",
"id": 501702,
"login": "edmorley",
"node_id": "MDQ6VXNlcjUwMTcwMg==",
"organizations_url": "https://api.github.com/users/edmorley/orgs",
"received_events_url": "https://api.github.com/users/edmorley/received_events",
"repos_url": "https://api.github.com/users/edmorley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/edmorley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/edmorley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/edmorley",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-06T21:44:41Z
|
2021-09-05T00:07:12Z
|
2017-06-06T22:00:39Z
|
CONTRIBUTOR
|
resolved
|
For example, when a pytest run fails, it saves failure metadata to:
`.cache/v/cache/lastfailed`
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4135/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4135/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4135.diff",
"html_url": "https://github.com/psf/requests/pull/4135",
"merged_at": "2017-06-06T22:00:39Z",
"patch_url": "https://github.com/psf/requests/pull/4135.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4135"
}
| true |
[
"✨🍰✨"
] |
https://api.github.com/repos/psf/requests/issues/4134
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4134/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4134/comments
|
https://api.github.com/repos/psf/requests/issues/4134/events
|
https://github.com/psf/requests/pull/4134
| 234,030,731 |
MDExOlB1bGxSZXF1ZXN0MTI0MjkyNjMy
| 4,134 |
Raise exceptions in utils.set_environ
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/8541468?v=4",
"events_url": "https://api.github.com/users/mlcrazy/events{/privacy}",
"followers_url": "https://api.github.com/users/mlcrazy/followers",
"following_url": "https://api.github.com/users/mlcrazy/following{/other_user}",
"gists_url": "https://api.github.com/users/mlcrazy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mlcrazy",
"id": 8541468,
"login": "mlcrazy",
"node_id": "MDQ6VXNlcjg1NDE0Njg=",
"organizations_url": "https://api.github.com/users/mlcrazy/orgs",
"received_events_url": "https://api.github.com/users/mlcrazy/received_events",
"repos_url": "https://api.github.com/users/mlcrazy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mlcrazy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mlcrazy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mlcrazy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-06-06T21:30:12Z
|
2021-09-05T00:07:14Z
|
2017-06-09T18:34:57Z
|
CONTRIBUTOR
|
resolved
|
fixes #4127
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4134/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4134/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4134.diff",
"html_url": "https://github.com/psf/requests/pull/4134",
"merged_at": "2017-06-09T18:34:56Z",
"patch_url": "https://github.com/psf/requests/pull/4134.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4134"
}
| true |
[
"@Lukasa @nateprewitt, did some commit fixups, not sure if I did the HISTORY.rst part correctly",
"There are conflicts in the AUTHORS.rst file. :smile:"
] |
https://api.github.com/repos/psf/requests/issues/4133
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4133/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4133/comments
|
https://api.github.com/repos/psf/requests/issues/4133/events
|
https://github.com/psf/requests/issues/4133
| 234,022,831 |
MDU6SXNzdWUyMzQwMjI4MzE=
| 4,133 |
POST converts request data from UTF-8 to ISO-Latin
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4348479?v=4",
"events_url": "https://api.github.com/users/rhoerbe/events{/privacy}",
"followers_url": "https://api.github.com/users/rhoerbe/followers",
"following_url": "https://api.github.com/users/rhoerbe/following{/other_user}",
"gists_url": "https://api.github.com/users/rhoerbe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rhoerbe",
"id": 4348479,
"login": "rhoerbe",
"node_id": "MDQ6VXNlcjQzNDg0Nzk=",
"organizations_url": "https://api.github.com/users/rhoerbe/orgs",
"received_events_url": "https://api.github.com/users/rhoerbe/received_events",
"repos_url": "https://api.github.com/users/rhoerbe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rhoerbe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rhoerbe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rhoerbe",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-06T20:59:17Z
|
2021-09-08T09:00:37Z
|
2017-06-07T07:55:27Z
|
NONE
|
resolved
|
Posting a chunk of XML in utf-8 encoding arrives garbled (iso-latin) at the target server.
It should arrive as encoded.
## Reproduction Steps
```python
import requests
request = '''
<?xml version="1.0" encoding="UTF-8"?>
<Requ>
<GivenName>Özdemam</GivenName>
<FamilyNameGrünzl</FamilyName>
</Requ>
'''
print(request)
headers = {'Content-Type': 'text/xml; charset=utf-8', }
req = requests.Request('POST', 'http://192.168.1.5:8888/api',
headers=headers,
data=request)
prepped_requ = req.prepare()
s = requests.Session()
http_response = s.send(prepped_requ)
```
Running `nc -l 8888' will show the garbled Umlaut characters, whereas print or command-line curl will produce the expected result.
## System Information
Tested on CentOS7/ Python 3.4.6 (EPEL) and OSX 10.12 MacPorts Python 3.5.3
Seems to be similar to #3476, but is unresolved.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4133/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4133/timeline
| null |
completed
| null | null | false |
[
"You haven't encoded it. ;)\r\n\r\nOn Python 3 the native string type is unicode: it has no encoding. We have to auto-encode the data, and in practice that's done by httplib with no reference to whatever you put in your header field. Try changing your code to this:\r\n\r\n```python\r\nimport requests\r\n\r\nrequest = '''\r\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n<Requ>\r\n<GivenName>Özdemam</GivenName>\r\n<FamilyNameGrünzl</FamilyName>\r\n</Requ>\r\n'''.encode('utf-8')\r\nheaders = {'Content-Type': 'text/xml; charset=utf-8', }\r\nreq = requests.Request('POST', 'http://192.168.1.5:8888/api',\r\n headers=headers,\r\n data=request)\r\nprepped_requ = req.prepare()\r\ns = requests.Session()\r\nhttp_response = s.send(prepped_requ)\r\n```"
] |
https://api.github.com/repos/psf/requests/issues/4132
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4132/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4132/comments
|
https://api.github.com/repos/psf/requests/issues/4132/events
|
https://github.com/psf/requests/pull/4132
| 234,020,147 |
MDExOlB1bGxSZXF1ZXN0MTI0Mjg0OTE1
| 4,132 |
Update README.rst (just a test)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-06-06T20:49:25Z
|
2021-09-05T00:07:15Z
|
2017-06-07T15:07:01Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4132/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4132/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4132.diff",
"html_url": "https://github.com/psf/requests/pull/4132",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4132.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4132"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4131
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4131/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4131/comments
|
https://api.github.com/repos/psf/requests/issues/4131/events
|
https://github.com/psf/requests/issues/4131
| 233,869,974 |
MDU6SXNzdWUyMzM4Njk5NzQ=
| 4,131 |
Error when using pip install requests - SyntaxError in setup.py?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18332543?v=4",
"events_url": "https://api.github.com/users/nathrun/events{/privacy}",
"followers_url": "https://api.github.com/users/nathrun/followers",
"following_url": "https://api.github.com/users/nathrun/following{/other_user}",
"gists_url": "https://api.github.com/users/nathrun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nathrun",
"id": 18332543,
"login": "nathrun",
"node_id": "MDQ6VXNlcjE4MzMyNTQz",
"organizations_url": "https://api.github.com/users/nathrun/orgs",
"received_events_url": "https://api.github.com/users/nathrun/received_events",
"repos_url": "https://api.github.com/users/nathrun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nathrun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nathrun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nathrun",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-06-06T12:06:10Z
|
2021-09-08T09:00:38Z
|
2017-06-06T12:07:39Z
|
NONE
|
resolved
|
Hi,
I am not sure if I am just doing something stupid but I can't seem to install requests on my raspberry pi which is running raspbian.
## Expected Result
Install requests for python
## Actual Result
When trying to install i got this:
`Downloading/unpacking requests
Downloading requests-2.17.3.tar.gz (123Kb): 123Kb downloaded
Running setup.py egg_info for package requests
Traceback (most recent call last):
File "<string>", line 14, in <module>
File "/home/pi/build/requests/setup.py", line 52, in <module>
exec(f.read(), about)
File "<string>", line 14
__cake__ = u'\u2728 \U0001f370 \u2728'
^
SyntaxError: invalid syntax
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 14, in <module>
File "/home/pi/build/requests/setup.py", line 52, in <module>
exec(f.read(), about)
File "<string>", line 14
__cake__ = u'\u2728 \U0001f370 \u2728'
^
SyntaxError: invalid syntax
----------------------------------------
Command python setup.py egg_info failed with error code 1 in /home/pi/build/requests
Storing complete log in /home/pi/.pip/pip.log`
## Reproduction Steps
pip-3.2 install requests
## System Information
I am trying to install this on a Raspberry Pi 2 B+ running Rasbian.
python version 3.2.3
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4131/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4131/timeline
| null |
completed
| null | null | false |
[
"Requests does not support Python 3.2, and has not for more than a year."
] |
https://api.github.com/repos/psf/requests/issues/4130
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4130/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4130/comments
|
https://api.github.com/repos/psf/requests/issues/4130/events
|
https://github.com/psf/requests/issues/4130
| 233,787,894 |
MDU6SXNzdWUyMzM3ODc4OTQ=
| 4,130 |
German signs äÄöÖüÜß presented not correctly
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 12 |
2017-06-06T06:07:11Z
|
2021-09-08T09:00:38Z
|
2017-06-06T11:54:01Z
|
NONE
|
resolved
|
Sending a response with special german signs and encoded as utf-8 does not really help
to get special german signs like äÄöÖüÜß in response.
Sending such signs results in empty response.
The answer object has as text field an empty field and can not use json(...) function member, ending with an exception.
## Expected Result
Was expecting responsed text in response object with german signs.
## Actual Result
Getting following exception:
File "C:\Python27\lib\site-packages\requests\models.py", line 886, in json
return complexjson.loads(self.text, **kwargs)
File "C:\Python27\lib\json\__init__.py", line 338, in loads
return _default_decoder.decode(s)
File "C:\Python27\lib\json\decoder.py", line 365, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "C:\Python27\lib\json\decoder.py", line 383, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
## Reproduction Steps
Code that i use in parts:
For headers using following structure:
headers = {
'Content-Type' : 'application/json; encoding="utf-8"',
'Authorization' : 'authorization '
}
Sending request with:
response = requests.post(
url,
headers = headers
)
response.close()
Trying to get text from response with:
response.text (But it is empty!) or a json object, because getting json in response
response.json() (But getting an exception described in ## Actual result)
## System Information
Python 2.7.5
requests 2.17.3
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4130/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4130/timeline
| null |
completed
| null | null | false |
[
"Are you actually sending any JSON data at all? You don't appear to be in your request: you only seem to be setting the url and the headers.",
"Hello Lukasa, it was just an example. I send JSON.\r\nIf you like to test encoding, that should be utf-8 per default =>\r\npython =>\r\nimport requests\r\nresponse = requests.get('https://www.tagesschau.de')\r\nprint(response.text)\r\n\r\nSetting response.encoding='utf-8' explicitly does not help\r\n\r\nprint(response.text) still shows the following exception:\r\n\r\n>>> print(response.text)\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"C:\\Python27\\lib\\encodings\\cp850.py\", line 12, in encode\r\n return codecs.charmap_encode(input,errors,encoding_map)\r\nUnicodeEncodeError: 'charmap' codec can't encode character u'\\u2019' in position 99816: character maps to <undefined>\r\n>>>\r\n\r\nbest regards \r\nAleksey",
"This is not a Requests issue: it’s a Python one. If you remove the call to “print” and just access response.text you’ll encounter no error. The problem is that the text encoding your interpreter or shell is using, or rather that Python thinks it’s using, is not able to render all the characters in the decoded data. Python seems to think you’re using CP850. If you change that, you’ll be fine.\n\n\n\n> On 6 Jun 2017, at 10:46, ashumilin <[email protected]> wrote:\n> \n> Hello Lukasa, it was just an example. I send JSON.\n> If you like to test encoding, that should be utf-8 per default =>\n> python =>\n> import requests\n> response = requests.get('https://www.tagesschau.de <https://www.tagesschau.de/>')\n> print(response.text)\n> \n> Setting response.encoding='utf-8' explicitly does not help\n> \n> print(response.text) still shows the following exception:\n> \n> print(response.text)\n> Traceback (most recent call last):\n> File \"\", line 1, in \n> File \"C:\\Python27\\lib\\encodings\\cp850.py\", line 12, in encode\n> return codecs.charmap_encode(input,errors,encoding_map)\n> UnicodeEncodeError: 'charmap' codec can't encode character u'\\u2019' in position 99816: character maps to\n> \n> best regards\n> Aleksey\n> \n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub <https://github.com/requests/requests/issues/4130#issuecomment-306436303>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUYnHDNb5ZoJanoqldtMjD10reOnOjqks5sBSASgaJpZM4Nw5ZB>.\n> \n\n",
"I see, but your suggestion does not really help :-).\r\nAt a particular time in code i have to load response.text as json(now it does not matter that i accept no json) - so i get an exception beacause of encoding.\r\nIs there any solution to this problem(probably migration to another python version)? ",
"@ashumilin Sorry, again, there is a lack of clarity here.\r\n\r\nCan you give an example of the actual code you're running that fails to work? I need to see what the actual data is.",
"of course, i get the following json structure(it should be available in response.text or provided by response.json)\r\n\r\n{\r\n\t\"kompott\" : [\r\n\t\t{\r\n\t\t\t\"zutat_1\" : \"äpfel\",\r\n\t\t\t\"zutat_1\" : \"pflaumen\"\r\n\t\t}\r\n\t],\r\n\t\"sorte\" : [\r\n\t\t{\r\n\t\t\t\"zutat_1\" : \"zimnije\",\r\n\t\t\t\"zutat_2\" : \"weiße\"\r\n\t\t}\r\n\t]\r\n}\r\n\r\nresponse.text is empty, response.json() shows an exception,\r\nif i replace ä with ae and ß with ss, i get the data without problems",
"This is not really what I need. What I need is a way to see the complete response, with the binary data exactly as it came from the server.",
"So basically, I think it's highly unlikely that Requests is barfing on *valid* JSON data. It seems much more likely that the data is not quite correct.",
"where do i get the binary data for response? \r\nthe response is send as utf-8, an as i said without german signs, the code do the thing",
"The easiest way is to use tcpdump/wireshark.",
"Takes too much time, i replace them with Umlaute-Replacement-Algorithm ae, Ae, Oe, oe, ue, Ue, ss.\r\nThank you for your suggestions!\r\nAleksey",
"Sounds to me like we can close this now. If I'm mistaken, let us know and I'll reopen it."
] |
https://api.github.com/repos/psf/requests/issues/4129
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4129/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4129/comments
|
https://api.github.com/repos/psf/requests/issues/4129/events
|
https://github.com/psf/requests/pull/4129
| 233,773,448 |
MDExOlB1bGxSZXF1ZXN0MTI0MTA1NDk4
| 4,129 |
Fix a typo: verison -> version
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1006477?v=4",
"events_url": "https://api.github.com/users/felixonmars/events{/privacy}",
"followers_url": "https://api.github.com/users/felixonmars/followers",
"following_url": "https://api.github.com/users/felixonmars/following{/other_user}",
"gists_url": "https://api.github.com/users/felixonmars/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/felixonmars",
"id": 1006477,
"login": "felixonmars",
"node_id": "MDQ6VXNlcjEwMDY0Nzc=",
"organizations_url": "https://api.github.com/users/felixonmars/orgs",
"received_events_url": "https://api.github.com/users/felixonmars/received_events",
"repos_url": "https://api.github.com/users/felixonmars/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/felixonmars/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/felixonmars/subscriptions",
"type": "User",
"url": "https://api.github.com/users/felixonmars",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-06-06T04:03:35Z
|
2021-09-05T00:07:16Z
|
2017-06-06T04:07:28Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4129/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4129/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4129.diff",
"html_url": "https://github.com/psf/requests/pull/4129",
"merged_at": "2017-06-06T04:07:28Z",
"patch_url": "https://github.com/psf/requests/pull/4129.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4129"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4128
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4128/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4128/comments
|
https://api.github.com/repos/psf/requests/issues/4128/events
|
https://github.com/psf/requests/issues/4128
| 233,647,572 |
MDU6SXNzdWUyMzM2NDc1NzI=
| 4,128 |
investigate pytest-timeout plugin
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-06-05T16:52:18Z
|
2021-09-08T08:00:31Z
|
2017-07-29T22:41:49Z
|
CONTRIBUTOR
|
resolved
|
will increase the reliability of tests on windows, perhaps.
- [ ] identify tests that hang on windows
https://pypi.python.org/pypi/pytest-timeout
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4128/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4128/timeline
| null |
completed
| null | null | false |
[
"I want to work on this issue! Can I take this issue as a beginner in OSS?",
"I don't think this will help much with the Windows tests. Thanks for the interest @vikramcse "
] |
https://api.github.com/repos/psf/requests/issues/4127
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4127/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4127/comments
|
https://api.github.com/repos/psf/requests/issues/4127/events
|
https://github.com/psf/requests/issues/4127
| 233,614,531 |
MDU6SXNzdWUyMzM2MTQ1MzE=
| 4,127 |
UnboundLocalError: local variable 'bypass' referenced before assignment
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/8541468?v=4",
"events_url": "https://api.github.com/users/mlcrazy/events{/privacy}",
"followers_url": "https://api.github.com/users/mlcrazy/followers",
"following_url": "https://api.github.com/users/mlcrazy/following{/other_user}",
"gists_url": "https://api.github.com/users/mlcrazy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mlcrazy",
"id": 8541468,
"login": "mlcrazy",
"node_id": "MDQ6VXNlcjg1NDE0Njg=",
"organizations_url": "https://api.github.com/users/mlcrazy/orgs",
"received_events_url": "https://api.github.com/users/mlcrazy/received_events",
"repos_url": "https://api.github.com/users/mlcrazy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mlcrazy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mlcrazy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mlcrazy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 15 |
2017-06-05T14:52:56Z
|
2021-09-08T09:00:35Z
|
2017-06-09T18:34:56Z
|
CONTRIBUTOR
|
resolved
|
When using requests with GAE dev_appserver sandbox, this variable gets referenced before assignment when making requests to the FB graph API
UnboundLocalError: local variable 'bypass' referenced before assignment
https://github.com/requests/requests/blob/master/requests/utils.py#L680
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4127/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4127/timeline
| null |
completed
| null | null | false |
[
"Uh...this bug appears to be fixed in the current release, if it was present at all. There is no way to that code unless `set_environ` does something absolutely horrifying in GAE, such as swallowing exceptions it hits in` __enter__`.",
"Using requests==2.17.3, oddly enough this works fine for making requests to numerous other services, only get this error when making requests to https://graph.facebook.com",
"I have to agree with @Lukasa. `bypass` is defined either in the `try` or `except` block prior to our usage of that. I think we should ping @jonparrott because this doesn't seem like a Requests issue but one can never be certain.",
"Also, @jonparrott I don't think there's a rush here and I know you spend most of your F/OSS time on Warehouse these days.",
"I am getting the same error in Python 3.5, Python 3.6 on OS X.\r\nNot getting it on Python 2.7.\r\n\r\nI'm doing a post with a URL along the lines of https://apikey:password@hostname/path\r\n\r\nAn exception is raised in line 2502 of request.py - `hostIP = socket.gethostbyname(hostonly)`\r\n\r\nThe exception is:\r\n`UnicodeError`,\r\n`encoding with 'idna' codec failed (UnicodeError: label empty or too long)`\r\n\r\nI have no proxies set up.\r\n",
"@jbasko Wait, what? Can you print all your traceback output please?",
"So it *looks like* `set_environ` may be swallowing all exceptions in this [try/finally block](https://github.com/requests/requests/blob/500fe3ee0373c5c0b0e6d80c0fd57142771f89cb/requests/utils.py#L618-L626). If something is raised outside of the two exceptions we're catching, it doesn't surface outside of the context manager and `bypass` isn't set.\r\n\r\n```python\r\nfrom requests.utils import set_environ\r\n\r\nwith set_environ('no_proxy', None):\r\n raise AssertionError\r\n```",
"Yeah, that code seems weird. What's with the `return` statement inside the `finally` block? What, exactly, were we thinking when we merged that?",
"Apologies, I didn't realise that was urllib request.py, not requests code.\r\n\r\nYes, as @nateprewitt says.\r\n\r\nThe actual traceback I get is useless as it is just about that bypass being referenced before assignment.\r\n\r\nI got the underlying exception by adding another except clause in the code mentioned and then inspecting exception with a debugger.",
"Ok cool so the actual bug is as @nateprewitt identified. Want to lead getting this fixed Nate?",
"@Lukasa, sure thing. I'll throw something together later today unless someone else would like to pick this up. It looks like it should be a quick fix.",
"Is this one also not my fault? You guys can feel free to keep pinging me on bugs that end up not being my fault. :)\r\n\r\n(In all seriousness let me know if there's anything I can do to help here)",
"@jonparrott I think you're in the clear here, this is just bad exception handling on our part 😅.",
"This change seems to get me past the variable assignment issue(and except the actual error), let me know if you want this in a PR\r\n\r\n```\r\[email protected]\r\ndef set_environ(env_name, value):\r\n \"\"\"Set the environment variable 'env_name' to 'value'\r\n\r\n Save previous value, yield, and then restore the previous value stored in\r\n the environment variable 'env_name'.\r\n\r\n If 'value' is None, do nothing\"\"\"\r\n if value is None:\r\n yield\r\n else:\r\n old_value = os.environ.get(env_name)\r\n os.environ[env_name] = value\r\n try:\r\n yield\r\n finally:\r\n if old_value is None:\r\n del os.environ[env_name]\r\n else:\r\n os.environ[env_name] = old_value\r\n```",
"@mlcrazy, this is definitely a workable approach. My initial pass was the inverse of this, so we yield in the else and match the docstring. I'm not terribly excited about the additional level of nesting, but I'm not sure it's avoidable here.\r\n\r\nFeel free to open the PR and we'll see if any of the other maintainers have thoughts."
] |
https://api.github.com/repos/psf/requests/issues/4126
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4126/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4126/comments
|
https://api.github.com/repos/psf/requests/issues/4126/events
|
https://github.com/psf/requests/issues/4126
| 233,487,271 |
MDU6SXNzdWUyMzM0ODcyNzE=
| 4,126 |
digest auth with netrc
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/14829854?v=4",
"events_url": "https://api.github.com/users/fstefanov/events{/privacy}",
"followers_url": "https://api.github.com/users/fstefanov/followers",
"following_url": "https://api.github.com/users/fstefanov/following{/other_user}",
"gists_url": "https://api.github.com/users/fstefanov/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/fstefanov",
"id": 14829854,
"login": "fstefanov",
"node_id": "MDQ6VXNlcjE0ODI5ODU0",
"organizations_url": "https://api.github.com/users/fstefanov/orgs",
"received_events_url": "https://api.github.com/users/fstefanov/received_events",
"repos_url": "https://api.github.com/users/fstefanov/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/fstefanov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fstefanov/subscriptions",
"type": "User",
"url": "https://api.github.com/users/fstefanov",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-06-05T03:42:21Z
|
2021-09-08T09:00:40Z
|
2017-06-05T13:36:33Z
|
NONE
|
resolved
|
According to the documentation:
netrc Authentication
If no authentication method is given with the auth argument, Requests will attempt to get the authentication credentials for the URL's hostname from the user's netrc file. The netrc file overrides raw HTTP authentication headers set with headers=.
If credentials for the hostname are found, the request is sent with HTTP Basic Auth.
How can i use then Digest with ~/.netrc ?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4126/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4126/timeline
| null |
completed
| null | null | false |
[
"At this time Requests does not enable the use of Digest Auth with `~/.netrc`. This would be a feature worth having, though it's a difficult one to add because right now Requests does not have any kind of multi-auth support. The toolbelt does though.",
"@PhilipStefanov \"the toolbelt\" = https://github.com/requests/toolbelt. Feel free to move this issue over there. 😃 "
] |
https://api.github.com/repos/psf/requests/issues/4125
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4125/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4125/comments
|
https://api.github.com/repos/psf/requests/issues/4125/events
|
https://github.com/psf/requests/issues/4125
| 233,463,634 |
MDU6SXNzdWUyMzM0NjM2MzQ=
| 4,125 |
chardet version check in >=2.16.0 is breaking our tox tests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/606038?v=4",
"events_url": "https://api.github.com/users/cas--/events{/privacy}",
"followers_url": "https://api.github.com/users/cas--/followers",
"following_url": "https://api.github.com/users/cas--/following{/other_user}",
"gists_url": "https://api.github.com/users/cas--/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cas--",
"id": 606038,
"login": "cas--",
"node_id": "MDQ6VXNlcjYwNjAzOA==",
"organizations_url": "https://api.github.com/users/cas--/orgs",
"received_events_url": "https://api.github.com/users/cas--/received_events",
"repos_url": "https://api.github.com/users/cas--/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cas--/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cas--/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cas--",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2017-06-04T22:12:30Z
|
2021-09-08T09:00:39Z
|
2017-06-05T05:29:46Z
|
NONE
|
resolved
|
The latest update (2.16.0 and 2.17.3) to version check chardet has broken one of our sphinx docs tox tests on travis.
```
File "/home/travis/build/cas--/Deluge/.tox/docs/local/lib/python2.7/site-packages/requests/__init__.py", line 66, in <module>
major, minor, patch = chardet.__version__.split('.')[:3]
AttributeError: type object '__version__' has no attribute 'split'
```
I have no idea how/why this is occurring but it's your new code in `__init__.py` that is breaking when version checking chardet.
Commit that introduced the issue: 2b34880e2fa3fe6006bf64517e036f5ed74478d6
Full details of OS and versions: https://travis-ci.org/cas--/Deluge/jobs/239401586
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/606038?v=4",
"events_url": "https://api.github.com/users/cas--/events{/privacy}",
"followers_url": "https://api.github.com/users/cas--/followers",
"following_url": "https://api.github.com/users/cas--/following{/other_user}",
"gists_url": "https://api.github.com/users/cas--/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cas--",
"id": 606038,
"login": "cas--",
"node_id": "MDQ6VXNlcjYwNjAzOA==",
"organizations_url": "https://api.github.com/users/cas--/orgs",
"received_events_url": "https://api.github.com/users/cas--/received_events",
"repos_url": "https://api.github.com/users/cas--/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cas--/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cas--/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cas--",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4125/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4125/timeline
| null |
completed
| null | null | false |
[
"Is this reproducible for you outside of Travis CI? I cannot reproduce it.",
"@cas-- It looks like this is directly related to the [`conf.py`](https://github.com/deluge-torrent/deluge/blob/6743b0c813769bd1fd6e3b0c96e2f037adc78dd0/docs/source/conf.py) file in Deluge's `docs/source` directory. It's replacing `chardet` with a Mock object which has an attr `__version__` of type `type`. Are modern versions of `chardet` using C extensions? I can't seem to find anything that points to that, so I'm not sure why this extension is being mocked out.",
"So sorry, recently been dealing lots of failing tests due to module changes and completely forgot about mock in docs test!",
"> Are modern versions of chardet using C extensions?\r\n\r\nTo answer the question: No.",
"@sigmavirus24 thanks! 😊\r\n\r\n@cas-- No need to apologize, glad you got it worked out."
] |
https://api.github.com/repos/psf/requests/issues/4124
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4124/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4124/comments
|
https://api.github.com/repos/psf/requests/issues/4124/events
|
https://github.com/psf/requests/pull/4124
| 233,365,921 |
MDExOlB1bGxSZXF1ZXN0MTIzODQwNjUw
| 4,124 |
Add support for MessagePack
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/116473?v=4",
"events_url": "https://api.github.com/users/suzaku/events{/privacy}",
"followers_url": "https://api.github.com/users/suzaku/followers",
"following_url": "https://api.github.com/users/suzaku/following{/other_user}",
"gists_url": "https://api.github.com/users/suzaku/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/suzaku",
"id": 116473,
"login": "suzaku",
"node_id": "MDQ6VXNlcjExNjQ3Mw==",
"organizations_url": "https://api.github.com/users/suzaku/orgs",
"received_events_url": "https://api.github.com/users/suzaku/received_events",
"repos_url": "https://api.github.com/users/suzaku/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/suzaku/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suzaku/subscriptions",
"type": "User",
"url": "https://api.github.com/users/suzaku",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2017-06-03T12:15:30Z
|
2021-09-05T00:07:16Z
|
2017-06-03T21:11:20Z
|
NONE
|
resolved
| null |
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4124/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4124/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4124.diff",
"html_url": "https://github.com/psf/requests/pull/4124",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4124.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4124"
}
| true |
[
"Hi there @suzaku!\r\n\r\nThanks for sending this pull request! We're so glad you've chosen to contribute to Requests and we appreciate all the time and effort you've put in to get to the point of sending this PR.\r\n\r\nSadly, however, it's highly unlikely that we will accept this pull request. Here's why:\r\n\r\nRequests focuses on satisfying the needs of 98% of its users. As it stands, roughly that percentage of our users will utilize and take advantage of the `json` keyword. Sadly, we've not received nearly as much feedback about providing the same functionality for `msgpack`.\r\n\r\nI'll leave this open for other core reviewers to comment on, but I wanted to set your expectations appropriately.\r\n\r\nCheers,\r\nIan",
"Ian is correct. This would make a great extension module, however!",
"Thanks again @suzaku ",
"@sigmavirus24 Thanks. I will handle msgpack in my application then.\r\n@kennethreitz Good idea."
] |
https://api.github.com/repos/psf/requests/issues/4123
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4123/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4123/comments
|
https://api.github.com/repos/psf/requests/issues/4123/events
|
https://github.com/psf/requests/issues/4123
| 232,804,149 |
MDU6SXNzdWUyMzI4MDQxNDk=
| 4,123 |
Make response.next lazily computable.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
open
| false | null |
[] | null | 17 |
2017-06-01T08:35:46Z
|
2024-05-19T18:54:54Z
| null |
MEMBER
| null |
When attempting to debug #4122 I attempted to use the standard method for debugging this, which is to set `allow_redirects=False` and to manually check the headers. Unfortunately, this no longer works since @kennethreitz shipped 2.15.0, as Requests now *always* computes the first redirect target in order to write it into `Response.next`. This makes it very frustrating to debug problems with Requests redirect following because it cannot be disabled, meaning that monkeypatching is required to prevent Requests blowing up.
I propose that we should either make `response.next` lazily computable, such that it is only calculated when actually requested, or we should remove it.
## Expected Result
I expected that if `allow_redirects=False` was provided Requests would not run any of its redirect handling code.
## Actual Result
It did.
## Reproduction Steps
```python
import requests
url = 'http://www.yftxt.com/plus/xiazai_yfx.php?open=2&id=12914&uhash=7fadfdb165fadc7362f9dc90'
requests.get(url, allow_redirects=False)
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "3.0.3"
},
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "3.6.0"
},
"platform": {
"release": "16.7.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.17.3"
},
"system_ssl": {
"version": "100020cf"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": false
}
```
| null |
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4123/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4123/timeline
| null | null | null | null | false |
[
"> we should remove it.\r\n\r\n+1\r\n\r\nI don't think the implementation is good and I don't think having this on a Response object is the right place for it. There's no way for people to use that Request object with anything other than a Session and if they're already using a Session they have what they need.",
"We should confirm though: @kennethreitz, what was the rationale for adding it? I assume you had a use-case in mind when you did. If so, it might be better to consider whether there is an alternative factoring of the code that doesn't run into this problem.",
"I added it to make it simple for people to follow redirect chains manually when `allow_redirects=False`. ",
"Sure, and that makes sense. The question is: why not have them just call `resolve_redirects` themselves? This doesn't avoid any of the logic of `resolve_redirects`, so most of the reasons for manually following redirects go away.\r\n\r\nMore generally, this breaks `allow_redirects=False`, because it automatically always follows the first redirect up to just before sending. If we have any errors in that code, it becomes impossible to *not* hit them, as I've now discovered.",
"I'm not against removing it, I don't think anyone will be missing out, but if we can find another way to add this API that is cleaner, I'd be for it (for example, changing it to just returning the next url perhaps?). \r\n\r\nShould have put more though into it perhaps before pushing it out. ",
"> (for example, changing it to just returning the next url perhaps?).\r\n\r\nDoesn't resolve the issue: literally the concern is executing the code in `resolve_redirects` in any form.",
"Well, I think it's nice to have, but if it's problematic, i'm fine with removing it. I just think it's a nice touch. ",
"I'm not opposed to having it, but it has to be built in a way that doesn't auto-run the code in `resolve_redirects`. If it computes lazily, that's fine, but it means the `Response` holds a reference to the `Session`. Assuming we're ok with that, I'm ok with it as an alternative.",
"+1 to lazy evaluation",
"torn about holding onto the session...",
"I absolutely am *against* the Response object holding onto the session. Let me explain it from this perspective:\r\n\r\nCurrently Requests can _appear_ to leak sockets/memory when users pass `stream=True` and refuse to consume the socket or return it to the connection pool. This is because the Response has a reference to a urllib3.Response which in turn has references to the connection pool and underlying httplib response & socket. The Session also has references to the connection pool. Now Responses, even those created via `requests.get`, will have a Session instance attached so they can maybe follow redirects? Uh, that's gross. That's especially gross since users will now have all the extra allocation of a session who are just using the functional API. And if they're using it enough, they could build up something awful (depending on how long their Response objects live of course). This just seems like a recipe for disaster.",
"i don't disagree",
"I'm with @sigmavirus24 on this. Hanging the Session instance on a Response conceptually seems pretty bizarre and prone to causing bugs. We also have tests suggesting we guarantee a Response object to be pickleable. Would that still hold true with the Session object attached?\r\n\r\nIf there's a way to maintain the interface without persisting the Session, then great. If not, it may be worth looking at alternatives/removing this method. ",
"There's too much knowledge specific to a Session object for us to move the logic to the Response object, in my opinion, and I don't see a better way than the suggestions provided above, but I haven't thought too hard about how to preserve the interface, frankly.",
"I have decided to defer to @Lukasa as to what to do here. Either:\r\n\r\n1. Make it lazily computable. \r\n2. Remove it completely (no one's likely using it yet, so no harm done), replace with documentation. \r\n\r\nIf needed, I'll make the decision. ",
"I suspect my inclination is to replace it completely. More generally we can reconsider how we handle redirects for 3.0. For example, `resolve_redirects` could be turned into an iterator of `Request` objects and the `Session` can handle sending those requests.",
"That sounds nice! I'm a big fan of the SessionRedirectMixin, but it could use some love. "
] |
https://api.github.com/repos/psf/requests/issues/4122
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4122/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4122/comments
|
https://api.github.com/repos/psf/requests/issues/4122/events
|
https://github.com/psf/requests/issues/4122
| 232,791,488 |
MDU6SXNzdWUyMzI3OTE0ODg=
| 4,122 |
UnicodeDecodeError in requests.get(url) method
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/6891304?v=4",
"events_url": "https://api.github.com/users/zhuifengshen/events{/privacy}",
"followers_url": "https://api.github.com/users/zhuifengshen/followers",
"following_url": "https://api.github.com/users/zhuifengshen/following{/other_user}",
"gists_url": "https://api.github.com/users/zhuifengshen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zhuifengshen",
"id": 6891304,
"login": "zhuifengshen",
"node_id": "MDQ6VXNlcjY4OTEzMDQ=",
"organizations_url": "https://api.github.com/users/zhuifengshen/orgs",
"received_events_url": "https://api.github.com/users/zhuifengshen/received_events",
"repos_url": "https://api.github.com/users/zhuifengshen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zhuifengshen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhuifengshen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zhuifengshen",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-06-01T07:41:16Z
|
2021-09-08T09:00:40Z
|
2017-06-02T09:11:32Z
|
NONE
|
resolved
|
## Code: test.py
```
#!/usr/bin/env python
# _*_ coding:utf-8 _*_
import requests
url = 'http://www.yftxt.com/plus/xiazai_yfx.php?open=2&id=12914&uhash=7fadfdb165fadc7362f9dc90'
requests.get(url)
```
## System Information
ubuntu 16.04
python3.6.1
requests2.14.2
## Run
$ python test.py
## Result
```
Traceback (most recent call last):
File "/home/devin/Project/github/pythonic/Py3Demo/demo.py", line 71, in <module>
requests.get(url)
File "/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/api.py", line 72, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/api.py", line 58, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py", line 518, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py", line 661, in send
history = [resp for resp in gen] if allow_redirects else []
File "/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py", line 661, in <listcomp>
history = [resp for resp in gen] if allow_redirects else []
File "/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py", line 122, in resolve_redirects
url = self.get_redirect_target(resp)
File "/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py", line 113, in get_redirect_target
return to_native_string(location, 'utf8')
File "/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/_internal_utils.py", line 25, in to_native_string
out = string.decode(encoding)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb3 in position 39: invalid start byte
```
##Help
Does anyone knows this problem? Thanks
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/6891304?v=4",
"events_url": "https://api.github.com/users/zhuifengshen/events{/privacy}",
"followers_url": "https://api.github.com/users/zhuifengshen/followers",
"following_url": "https://api.github.com/users/zhuifengshen/following{/other_user}",
"gists_url": "https://api.github.com/users/zhuifengshen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zhuifengshen",
"id": 6891304,
"login": "zhuifengshen",
"node_id": "MDQ6VXNlcjY4OTEzMDQ=",
"organizations_url": "https://api.github.com/users/zhuifengshen/orgs",
"received_events_url": "https://api.github.com/users/zhuifengshen/received_events",
"repos_url": "https://api.github.com/users/zhuifengshen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zhuifengshen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhuifengshen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zhuifengshen",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4122/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4122/timeline
| null |
completed
| null | null | false |
[
"Looks like the redirect location isn't encoded correct. Try it with\n`allow_redirects=false` and look at the response's `Location` header\n\nOn Thu, 1 Jun 2017, 5:41 PM Devin <[email protected]> wrote:\n\n> Code: test.py\n>\n> #!/usr/bin/env python\n> # _*_ coding:utf-8 _*_\n> import requests\n> url = 'http://www.yftxt.com/plus/xiazai_yfx.php?open=2&id=12914&uhash=7fadfdb165fadc7362f9dc90'\n> requests.get(url)\n>\n> System Information\n>\n> ubuntu 16.04\n> python3.6.1\n> requests2.14.2\n> Run\n>\n> $ python test.py\n> Result\n>\n> Traceback (most recent call last):\n> File \"/home/devin/Project/github/pythonic/Py3Demo/demo.py\", line 71, in <module>\n> requests.get(url)\n> File \"/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/api.py\", line 72, in get\n> return request('get', url, params=params, **kwargs)\n> File \"/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/api.py\", line 58, in request\n> return session.request(method=method, url=url, **kwargs)\n> File \"/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py\", line 518, in request\n> resp = self.send(prep, **send_kwargs)\n> File \"/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py\", line 661, in send\n> history = [resp for resp in gen] if allow_redirects else []\n> File \"/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py\", line 661, in <listcomp>\n> history = [resp for resp in gen] if allow_redirects else []\n> File \"/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py\", line 122, in resolve_redirects\n> url = self.get_redirect_target(resp)\n> File \"/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/sessions.py\", line 113, in get_redirect_target\n> return to_native_string(location, 'utf8')\n> File \"/usr/local/lib/python3.6.1/lib/python3.6/site-packages/requests/_internal_utils.py\", line 25, in to_native_string\n> out = string.decode(encoding)\n> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb3 in position 39: invalid start byte\n>\n> ##Help\n> Does anyone knows this problem? Thanks\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/requests/requests/issues/4122>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AGk_7Rwkd1OCbffvylFojnViIS_H-w98ks5r_msqgaJpZM4Nsmld>\n> .\n>\n",
"@TetraEtc thank you for your help to solve my problem^&^"
] |
https://api.github.com/repos/psf/requests/issues/4121
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4121/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4121/comments
|
https://api.github.com/repos/psf/requests/issues/4121/events
|
https://github.com/psf/requests/issues/4121
| 232,686,555 |
MDU6SXNzdWUyMzI2ODY1NTU=
| 4,121 |
iter_lines gives different results depending on chunk_size
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/16595115?v=4",
"events_url": "https://api.github.com/users/a-p-f/events{/privacy}",
"followers_url": "https://api.github.com/users/a-p-f/followers",
"following_url": "https://api.github.com/users/a-p-f/following{/other_user}",
"gists_url": "https://api.github.com/users/a-p-f/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/a-p-f",
"id": 16595115,
"login": "a-p-f",
"node_id": "MDQ6VXNlcjE2NTk1MTE1",
"organizations_url": "https://api.github.com/users/a-p-f/orgs",
"received_events_url": "https://api.github.com/users/a-p-f/received_events",
"repos_url": "https://api.github.com/users/a-p-f/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/a-p-f/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/a-p-f/subscriptions",
"type": "User",
"url": "https://api.github.com/users/a-p-f",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-05-31T20:30:24Z
|
2021-09-08T09:00:41Z
|
2017-05-31T20:40:31Z
|
NONE
|
resolved
|
When using iter_lines with chunk_size other than None, it can generate an extra blank line if the end of a chunk lands on a delimiter.
## Reproduction Steps
```python
import StringIO
import requests
def getTestFile():
f = StringIO.StringIO()
f.write('a-b')
f.seek(0)
return f
r = requests.Response()
r.raw = getTestFile()
print [l for l in r.iter_lines(delimiter='-')]
r = requests.Response()
r.raw = getTestFile()
print [l for l in r.iter_lines(delimiter='-', chunk_size=2)]
```
## Expected Result
['a', 'b']
['a', 'b']
## Actual Result
['a', 'b']
['a', '', 'b']
## Proposed Fix
I modified iter_lines as follows, and the above test passes:
```python
def iter_lines(self, chunk_size=ITER_CHUNK_SIZE, decode_unicode=None, delimiter=None):
"""Iterates over the response data, one line at a time. When
stream=True is set on the request, this avoids reading the
content at once into memory for large responses.
.. note:: This method is not reentrant safe.
"""
pending = None
for chunk in self.iter_content(chunk_size=chunk_size, decode_unicode=decode_unicode):
if pending is not None:
chunk = pending + chunk
if delimiter:
lines = chunk.split(delimiter)
else:
lines = chunk.splitlines()
if lines and lines[-1] and chunk and lines[-1][-1] == chunk[-1]:
pending = lines.pop()
elif lines and lines[-1] == '':
pending = lines.pop()
else:
pending = None
for line in lines:
yield line
if pending is not None:
yield pending
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "3.0.3"
},
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "2.7.13"
},
"platform": {
"release": "16.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.17.3"
},
"system_ssl": {
"version": "100020bf"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": false
}
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4121/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4121/timeline
| null |
completed
| null | null | false |
[
"Hey @a-p-f, thanks for putting together such a detailed issue. This is actually a duplicate of #3980 and addressed by #3984. This is a breaking change though, so it won't be available until 3.0.0 is released.\r\n\r\nI'm going to close this out as a dupe, but please let us know if you have any further questions.",
"Sorry about that. I searched the issues for 'iter_lines', but I had the 'is:open' filter on so it didn't pop up.",
"No worries! 😄 "
] |
https://api.github.com/repos/psf/requests/issues/4120
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4120/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4120/comments
|
https://api.github.com/repos/psf/requests/issues/4120/events
|
https://github.com/psf/requests/pull/4120
| 232,508,242 |
MDExOlB1bGxSZXF1ZXN0MTIzMjMwOTYy
| 4,120 |
Bring 3.0 up-to-date with master.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 15 |
2017-05-31T09:30:42Z
|
2021-09-05T00:07:14Z
|
2017-06-10T06:57:24Z
|
MEMBER
|
resolved
|
This was a gnarly merge, and the odds of it going right first time are pretty low, so let's have the CI prove or disprove the success of it for me.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4120/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4120/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4120.diff",
"html_url": "https://github.com/psf/requests/pull/4120",
"merged_at": "2017-06-10T06:57:24Z",
"patch_url": "https://github.com/psf/requests/pull/4120.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4120"
}
| true |
[
"@Lukasa you're merging this into master?",
"Other than definitely not wanting to merge this into master, this looks like it's right. It would be nice to see a smaller diff against proposed/3.0.0 though.",
"Okay, I updated the branch for you",
"FYI, the windows tests won't finish because they're blocked. I pinged @kennethreitz about this in IRC.",
"Ok, the Windows CI won't get working any time soon as @kennethreitz is on the road. I suggest we move on without it to unblock #4118.",
"@Lukasa, we have a [successful run](http://jenkins.kennethreitz.org:8080/job/requests/job/requests-windows/lastSuccessfulBuild/) of master on Windows from yesterday. Since nothing has changed on master, and I don't see anything directly related to Windows in the 3.0.0 merge, I think it's probably OK to merge this.\r\n",
"Kenneth restarted the builder, so we should get a result shortly.",
"windows had a failure!",
"It did, that's true, but that failure seems to be related to having had something wacky happen with the environment build. I'm restarting the builder.",
"Yeah, I don't know that I trust the output of this Windows builder. It seems to not really be working properly.",
"@kennethreitz What are we doing about this Windows builder?",
"@Lukasa not sure why the build is hanging on Windows. I'll take a peek around. It runs fine on master. ",
"Looks like we're good to go here.",
"I've rebased #4118 onto this locally, should I push that update?",
"@hobarrera Go for it"
] |
https://api.github.com/repos/psf/requests/issues/4119
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4119/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4119/comments
|
https://api.github.com/repos/psf/requests/issues/4119/events
|
https://github.com/psf/requests/issues/4119
| 232,493,981 |
MDU6SXNzdWUyMzI0OTM5ODE=
| 4,119 |
TypeError when using a custom HTTPSConnectionPool
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/29090022?v=4",
"events_url": "https://api.github.com/users/amatyukhin0/events{/privacy}",
"followers_url": "https://api.github.com/users/amatyukhin0/followers",
"following_url": "https://api.github.com/users/amatyukhin0/following{/other_user}",
"gists_url": "https://api.github.com/users/amatyukhin0/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/amatyukhin0",
"id": 29090022,
"login": "amatyukhin0",
"node_id": "MDQ6VXNlcjI5MDkwMDIy",
"organizations_url": "https://api.github.com/users/amatyukhin0/orgs",
"received_events_url": "https://api.github.com/users/amatyukhin0/received_events",
"repos_url": "https://api.github.com/users/amatyukhin0/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/amatyukhin0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/amatyukhin0/subscriptions",
"type": "User",
"url": "https://api.github.com/users/amatyukhin0",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-05-31T08:38:35Z
|
2021-09-08T09:00:41Z
|
2017-05-31T08:59:42Z
|
NONE
|
resolved
|
An issue #4010 was closed, but this error
```python
TypeError: _new_pool() got an unexpected keyword argument 'request_context'
```
still appears in requests 2.17.3. Details are in the issue #4010.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/29090022?v=4",
"events_url": "https://api.github.com/users/amatyukhin0/events{/privacy}",
"followers_url": "https://api.github.com/users/amatyukhin0/followers",
"following_url": "https://api.github.com/users/amatyukhin0/following{/other_user}",
"gists_url": "https://api.github.com/users/amatyukhin0/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/amatyukhin0",
"id": 29090022,
"login": "amatyukhin0",
"node_id": "MDQ6VXNlcjI5MDkwMDIy",
"organizations_url": "https://api.github.com/users/amatyukhin0/orgs",
"received_events_url": "https://api.github.com/users/amatyukhin0/received_events",
"repos_url": "https://api.github.com/users/amatyukhin0/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/amatyukhin0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/amatyukhin0/subscriptions",
"type": "User",
"url": "https://api.github.com/users/amatyukhin0",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4119/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4119/timeline
| null |
completed
| null | null | false |
[
"@amatyukhin0 Did you read [this comment](https://github.com/requests/requests/issues/4010#issuecomment-300352930)? I believe it explains your concern.",
"@Lukasa Sorry, i was inattentive, it works after the fix."
] |
https://api.github.com/repos/psf/requests/issues/4118
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4118/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4118/comments
|
https://api.github.com/repos/psf/requests/issues/4118/events
|
https://github.com/psf/requests/pull/4118
| 232,401,613 |
MDExOlB1bGxSZXF1ZXN0MTIzMTU4MDM4
| 4,118 |
Drop python2.6 support
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/730811?v=4",
"events_url": "https://api.github.com/users/WhyNotHugo/events{/privacy}",
"followers_url": "https://api.github.com/users/WhyNotHugo/followers",
"following_url": "https://api.github.com/users/WhyNotHugo/following{/other_user}",
"gists_url": "https://api.github.com/users/WhyNotHugo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/WhyNotHugo",
"id": 730811,
"login": "WhyNotHugo",
"node_id": "MDQ6VXNlcjczMDgxMQ==",
"organizations_url": "https://api.github.com/users/WhyNotHugo/orgs",
"received_events_url": "https://api.github.com/users/WhyNotHugo/received_events",
"repos_url": "https://api.github.com/users/WhyNotHugo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/WhyNotHugo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/WhyNotHugo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/WhyNotHugo",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 16 |
2017-05-30T22:33:15Z
|
2021-09-05T00:07:08Z
|
2017-07-26T19:59:40Z
|
CONTRIBUTOR
|
resolved
|
Drop support for python2.6. Fixes #3928
Note that this targets the 3.0.0 branch, not master.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4118/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4118/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4118.diff",
"html_url": "https://github.com/psf/requests/pull/4118",
"merged_at": "2017-07-26T19:59:40Z",
"patch_url": "https://github.com/psf/requests/pull/4118.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4118"
}
| true |
[
"Not entirely sure why CI is failing -- is this branch not updated for it?\r\n```\r\n+ make ci\r\nmake: *** No rule to make target 'ci'. Stop.\r\n```",
"@hobarrera No, it looks like it isn't. I'll try to resolve that problem today.",
"Thanks!",
"Hey @hobarrera, it looks like 2.6 is still in the tox.ini file. If we can pull that out, I think this should be good to go.",
"Tests are \"passing\". Just 2.6 failed, as expected.",
"Whoops! There we go. Jenkins is still configured to run 2.6 though.",
"@kennethreitz, are the versions running on Jenkins hardcoded for the server? Do we have any way to delegate this to something like tox?",
"@nateprewitt they are currently pinned",
"\"work around\" is a bit tricky here, because they're required builds. I think we need a way to turn them off for this branch.",
"The only workarounds I can think of are extremely hacky things, like raising a \"SkipTest\" exception before most imports run, or things like that.",
"@Lukasa 😕 well that's unfortunate. I talked briefly with Kenneth last night and it seemed like there was some difficulty differing build requirements between branches. We'll probably need to investigate configuration options for [Jenkins with tox](https://tox.readthedocs.io/en/latest/example/jenkins.html), or sit on this branch until we're ready to shut off 2.6 tests across the board.\r\n\r\n@hobarrera this is definitely an infrastructure issue on our end. I'd *really* like to avoid making any code changes in Requests' tests to deal with a CI server.",
"so, i have a solution to this — we just need a separate job for the 3.0.0 branch, which removes python 2.6. I'll see if I can get to this today. ",
"I guess I'll just leave this here until Jenkins is ready? I don't think there's anything else I can do. 🙂 ",
"The \"workaround\"' here is to allow administrators to merge anyway. I'll turn that on now. ",
"there, that was easy. ",
"Thanks!"
] |
https://api.github.com/repos/psf/requests/issues/4117
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4117/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4117/comments
|
https://api.github.com/repos/psf/requests/issues/4117/events
|
https://github.com/psf/requests/issues/4117
| 232,395,252 |
MDU6SXNzdWUyMzIzOTUyNTI=
| 4,117 |
Looks like dependency mismatch for chardet lib.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/27700867?v=4",
"events_url": "https://api.github.com/users/synchr-darnold/events{/privacy}",
"followers_url": "https://api.github.com/users/synchr-darnold/followers",
"following_url": "https://api.github.com/users/synchr-darnold/following{/other_user}",
"gists_url": "https://api.github.com/users/synchr-darnold/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/synchr-darnold",
"id": 27700867,
"login": "synchr-darnold",
"node_id": "MDQ6VXNlcjI3NzAwODY3",
"organizations_url": "https://api.github.com/users/synchr-darnold/orgs",
"received_events_url": "https://api.github.com/users/synchr-darnold/received_events",
"repos_url": "https://api.github.com/users/synchr-darnold/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/synchr-darnold/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/synchr-darnold/subscriptions",
"type": "User",
"url": "https://api.github.com/users/synchr-darnold",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 18 |
2017-05-30T22:02:34Z
|
2021-09-08T07:00:24Z
|
2017-05-31T01:00:30Z
|
NONE
|
resolved
|
Version: requests-2.17.3
Exception: Requests dependency 'chardet' must be version >= 3.0.2, < 3.1.0
```
cd /usr/local/lib/python2.7/site-packages/pip-9.0.1-py2.7.egg/pip/_vendor/requests/packages/
[root@ip-10-0-11-136 packages]# python
Python 2.7.12 (default, Sep 1 2016, 22:14:00)
[GCC 4.8.3 20140911 (Red Hat 4.8.3-9)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import chardet
>>> import os
>>> print os.path.abspath(chardet.__file__)
/usr/local/lib/python2.7/site-packages/pip-9.0.1-py2.7.egg/pip/_vendor/requests/packages/chardet/__init__.pyc
>>> chardet.__version__
'2.3.0'
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4117/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4117/timeline
| null |
completed
| null | null | false |
[
"looks like you need to update your chardet to the versions specified :)",
"Exactly what @kennethreitz. `pip install -U 'chardet >= 3.0.2, < 3.1.0'` will fix this up for you.",
"The chardet that is included with requests is broken. ",
"No chardet is included with the new versions of Requests: they depend on it via pip.",
"If requests depends on it, and running pip install requests is broken because the version is not pinned for requests dependencies, shouldn't the version be pinned? Having to fix the installation of requests seems to mean that it's broken.",
"The version [is pinned](https://github.com/requests/requests/blob/master/setup.py#L45). This is a known problem due to `pip`'s lack of a dependency solver, which we're hoping will get resolved this summer when pip gets a proper dependency solver.",
"The automation that I've been using to deploy services using Ansible was working last Friday, ceased to work on Monday. Are we sure that nothing else is changed? Seems like the pip problem is a bit older than last Friday. This was on a new Amazon Linux ec2 instance.\r\n\r\nThere were a few releases that went out over this last weekend.",
"No, to be clear, Requests stopped vendoring chardet on Friday and started requiring it as an explicit dependency. That is what changed. See the 2.16.0 release notes.",
"Ah, didn't quite catch that... ```Unvendor ALL the things!``` so, basically just wait until pip is fixed. Thanks for your patience @Lukasa ",
"You shouldn't need to wait: you can just make sure you install Requests with all its dependencies by doing a `pip install -U requests`, which should bring in anything new it needs.",
"(Let me know if this should be a new issue - thought it was related enough.) @Lukasa @kennethreitz based on https://github.com/requests/requests/issues/4069#issuecomment-304432367, it seems like the rationale behind unvendoring isn't super clear. Is it just to conform better with how Python packages tend to operate?\r\n\r\nIs there any chance we can consider reverting back to vendoring?\r\n\r\nIn our specific case, chardet>=3.0.2 (which requests now requires) is causing problems with our usage of `UnicodeDammit` (https://www.crummy.com/software/BeautifulSoup/bs4/doc/#unicode-dammit), which relies on chardet. (This is a whole other nasty rabbit hole, but basically it seems like chardet 3 incorrectly detects some UTF-8 strings as ISO-8859-1, which chardet 2 was correct on.)\r\n\r\nMy current workaround is to downgrade to `requests==2.15.1`, before the great unvendoring, so we can keep chardet 2.",
"I'm afraid it's not very likely: the reality is that the great unvendoring helped many more users than it inconvenienced. I appreciate that it has caused problems here, but the better solution may be to see if we can widen the pin to support the older chardet version. ",
"@Lukasa widening would work great, if possible!\r\n\r\n(out of curiosity, how did unvendoring help? was it to lower package sizes?)",
"@joshma it was a decision I made, for a multitude of reasons, including security concerns. ",
"Heh, there are lots of issues in the back catalogue caused by vendoring. The core issue is that for various reasons the vendored packages were unpopular and removed, which led to subtle difficult bugs depending on install source. ",
"e.g. the less code we ship, the better. especially `certifi`.",
"Cool, thanks all for the context. Is there anything I can do to help determine if we can widen the chardet pin? :crossed_fingers: ",
"I don't think we can widen the chardet pin. For most every other user, the newer version is better. I know Dan is working on retraining the models for some of the newer bugs, but chardet 3.x should be faster than 2.x and more accurate on most any other encoding."
] |
https://api.github.com/repos/psf/requests/issues/4116
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4116/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4116/comments
|
https://api.github.com/repos/psf/requests/issues/4116/events
|
https://github.com/psf/requests/pull/4116
| 232,374,129 |
MDExOlB1bGxSZXF1ZXN0MTIzMTM3ODMy
| 4,116 |
Add editorconfig for easier styling
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/12768035?v=4",
"events_url": "https://api.github.com/users/ishvad/events{/privacy}",
"followers_url": "https://api.github.com/users/ishvad/followers",
"following_url": "https://api.github.com/users/ishvad/following{/other_user}",
"gists_url": "https://api.github.com/users/ishvad/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ishvad",
"id": 12768035,
"login": "ishvad",
"node_id": "MDQ6VXNlcjEyNzY4MDM1",
"organizations_url": "https://api.github.com/users/ishvad/orgs",
"received_events_url": "https://api.github.com/users/ishvad/received_events",
"repos_url": "https://api.github.com/users/ishvad/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ishvad/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ishvad/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ishvad",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-05-30T20:36:20Z
|
2021-09-01T00:11:41Z
|
2017-05-30T20:52:43Z
|
NONE
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4116/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4116/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4116.diff",
"html_url": "https://github.com/psf/requests/pull/4116",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4116.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4116"
}
| true |
[
"I don't think this is needed.",
"Thanks for opening your first pull request, @ishvad! We appreciate your effort in trying to improve the Requests project.\r\n\r\nWe try to keep the code inside the Requests repository to minimum essentials. While this will likely be useful for some developers, I don't know if this qualifies as essential. This is something that is likely best left to the user to decide.\r\n\r\nYou could consider publishing this in a [gist](https://gist.github.com/) for others to reference. Feel free to leave a link to it here if you wish."
] |
|
https://api.github.com/repos/psf/requests/issues/4115
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4115/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4115/comments
|
https://api.github.com/repos/psf/requests/issues/4115/events
|
https://github.com/psf/requests/pull/4115
| 232,269,728 |
MDExOlB1bGxSZXF1ZXN0MTIzMDYyMzg2
| 4,115 |
add cchardet support and use chardet as fallback
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4757825?v=4",
"events_url": "https://api.github.com/users/2mf/events{/privacy}",
"followers_url": "https://api.github.com/users/2mf/followers",
"following_url": "https://api.github.com/users/2mf/following{/other_user}",
"gists_url": "https://api.github.com/users/2mf/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/2mf",
"id": 4757825,
"login": "2mf",
"node_id": "MDQ6VXNlcjQ3NTc4MjU=",
"organizations_url": "https://api.github.com/users/2mf/orgs",
"received_events_url": "https://api.github.com/users/2mf/received_events",
"repos_url": "https://api.github.com/users/2mf/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/2mf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/2mf/subscriptions",
"type": "User",
"url": "https://api.github.com/users/2mf",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 14 |
2017-05-30T14:21:56Z
|
2021-09-05T00:07:18Z
|
2017-05-30T19:45:53Z
|
NONE
|
resolved
|
I created this pull-request for #4112
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4757825?v=4",
"events_url": "https://api.github.com/users/2mf/events{/privacy}",
"followers_url": "https://api.github.com/users/2mf/followers",
"following_url": "https://api.github.com/users/2mf/following{/other_user}",
"gists_url": "https://api.github.com/users/2mf/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/2mf",
"id": 4757825,
"login": "2mf",
"node_id": "MDQ6VXNlcjQ3NTc4MjU=",
"organizations_url": "https://api.github.com/users/2mf/orgs",
"received_events_url": "https://api.github.com/users/2mf/received_events",
"repos_url": "https://api.github.com/users/2mf/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/2mf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/2mf/subscriptions",
"type": "User",
"url": "https://api.github.com/users/2mf",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4115/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4115/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4115.diff",
"html_url": "https://github.com/psf/requests/pull/4115",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4115.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4115"
}
| true |
[
"sure :-)\r\nI have to update the test settings as well to ensure chardet and cchardet run both",
"This whole thing scares me. ",
"I for one am not wedded to doing it: I'm nervous about the amount of code it adds as well.",
"@2mf do you have any metrics on how much faster cchardet is than chardet? e.g. is it worth the trouble?",
"@kennethreitz a benchmark can be seen at https://pypi.python.org/pypi/cchardet\r\n\r\n> Python 2.7.12\r\n> \tRequest (call/s)\r\n> chardet\t 0.26\r\n> cchardet\t1341.81\r\n>\r\n> Python 3.6.0\r\n> \tRequest (call/s)\r\n> chardet\t 0.26\r\n> cchardet\t1472.43\r\n",
"@kennethreitz @Lukasa \r\nIf you both don't like the idea of including cchardet. I don't have a problem with that but then there must be a possibility to use cchardet by monkey patching but this is prevented by other things like:\r\n\r\nshouldn't be the version matching in the requirements of setup.py?\r\n```\r\n# Check chardet for compatibility.\r\nimport chardet\r\nmajor, minor, patch = chardet.__version__.split('.')[:3]\r\nmajor, minor, patch = int(major), int(minor), int(patch)\r\n# chardet >= 3.0.2, < 3.1.0\r\ntry:\r\n assert major == 3\r\n assert minor < 1\r\n assert patch >= 2\r\nexcept AssertionError:\r\n raise RuntimeError('Requests dependency \\'chardet\\' must be version >= 3.0.2, < 3.1.0!')\r\n```\r\nand\r\n```\r\nfor package in ('urllib3', 'idna', 'chardet'):\r\n locals()[package] = __import__(package)\r\n # This traversal is apparently necessary such that the identities are\r\n # preserved (requests.packages.urllib3.* is urllib3.*)\r\n for mod in list(sys.modules):\r\n if mod == package or mod.startswith(package + '.'):\r\n sys.modules['requests.packages.' + mod] = sys.modules[mod]\r\n```",
"That is significantly faster! ",
"> shouldn't be the version matching in the requirements of setup.py?\r\n\r\nNo, @2mf it shouldn't. Requests needs *very* specific versions of dependencies. Some of those dependencies are popular and we need a way to tell the user \"You're using a version that will horribly break your version of Requests\"",
"> That is significantly faster!\r\n\r\nAnd harder to install and the benchmark, as I understand it, is based off a *very* old version of chardet and hasn't been updated since.",
"It sounds like we're against this change overall. Sorry @2mf. ",
"I'm on board with doing this, but the current methodology isn't 100% correct and I'm merely pointing out that those benchmarks are older and potentially misleading. @dan-blanchard has done a lot of fantastic work on chardet recently",
"I feel the need to point out that chardet is in the midst of gaining support for more codecs and languages than cchardet supports. I'm retraining all the models for greater accuracy too. Speed isn't everything with encoding detection.",
"Just for the sake of a recent benchmark\r\nI did the same benchmark for chardet and cchardet that where done by @PyYoshi (on my machine) and the difference is still in the same dimension.\r\n\r\n> Python 3.6.1\r\n> chardet 3.0.3\r\n> cchardet 2.1.0\r\n\r\n> python test_chardet.py \r\n> chardet: 0.24908731023612882 call(s)/s\r\n> \r\n> python test_cchardet.py \r\n> chardet: 1161.9214360906421 call(s)/s\r\n> \r\n\r\nanyway, It is not worth to continue on this one while running against so many walls",
"I hadn't actually looked at the benchmark code cChardet uses before, but it just [runs the same small SJIS text file through both modules 100 times](https://github.com/PyYoshi/cChardet/blob/master/src/tests/bench.py#L9). I know cChardet will pretty much always be faster than chardet—in fact, if you look at old chardet issues, you'll even see that I once toyed with the idea of trying to merge the projects—but that is not an accurate benchmark, especially for something like requests where a good amount of the time is spent downloading the page content anyway. A requests-based benchmark would make sense for deciding if it makes a difference here."
] |
https://api.github.com/repos/psf/requests/issues/4114
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4114/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4114/comments
|
https://api.github.com/repos/psf/requests/issues/4114/events
|
https://github.com/psf/requests/pull/4114
| 232,202,449 |
MDExOlB1bGxSZXF1ZXN0MTIzMDEzMjgz
| 4,114 |
Catch error if multiprocessing is not available or is unable to determine the number of CPUs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/161093?v=4",
"events_url": "https://api.github.com/users/girlpunk/events{/privacy}",
"followers_url": "https://api.github.com/users/girlpunk/followers",
"following_url": "https://api.github.com/users/girlpunk/following{/other_user}",
"gists_url": "https://api.github.com/users/girlpunk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/girlpunk",
"id": 161093,
"login": "girlpunk",
"node_id": "MDQ6VXNlcjE2MTA5Mw==",
"organizations_url": "https://api.github.com/users/girlpunk/orgs",
"received_events_url": "https://api.github.com/users/girlpunk/received_events",
"repos_url": "https://api.github.com/users/girlpunk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/girlpunk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/girlpunk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/girlpunk",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2017-05-30T10:03:05Z
|
2021-09-05T00:07:18Z
|
2017-05-30T12:54:32Z
|
CONTRIBUTOR
|
resolved
|
resolves #4113
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4114/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4114/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4114.diff",
"html_url": "https://github.com/psf/requests/pull/4114",
"merged_at": "2017-05-30T12:54:32Z",
"patch_url": "https://github.com/psf/requests/pull/4114.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4114"
}
| true |
[
"FYI @kennethreitz, it seems only one check is running here: I have no idea why.",
"add to whitelist",
"(Taking a shot in the dark)",
"There we go, spelling was never my forte (but the comment box here has spell check :)",
"no rush from me, I'm stuck with 2.15.1 until chardet/chardet#127 is sorted.",
"@sigmavirus24 was a configuration issue, i fixed the problem. Sorry for the issues!"
] |
https://api.github.com/repos/psf/requests/issues/4113
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4113/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4113/comments
|
https://api.github.com/repos/psf/requests/issues/4113/events
|
https://github.com/psf/requests/issues/4113
| 232,199,143 |
MDU6SXNzdWUyMzIxOTkxNDM=
| 4,113 |
Installation fails on platforms without multiprocessing
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/161093?v=4",
"events_url": "https://api.github.com/users/girlpunk/events{/privacy}",
"followers_url": "https://api.github.com/users/girlpunk/followers",
"following_url": "https://api.github.com/users/girlpunk/following{/other_user}",
"gists_url": "https://api.github.com/users/girlpunk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/girlpunk",
"id": 161093,
"login": "girlpunk",
"node_id": "MDQ6VXNlcjE2MTA5Mw==",
"organizations_url": "https://api.github.com/users/girlpunk/orgs",
"received_events_url": "https://api.github.com/users/girlpunk/received_events",
"repos_url": "https://api.github.com/users/girlpunk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/girlpunk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/girlpunk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/girlpunk",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-05-30T09:50:23Z
|
2021-09-08T09:00:42Z
|
2017-05-30T12:54:32Z
|
CONTRIBUTOR
|
resolved
|
On the latest version of requests in pypi, requests requires the multiprocessing module to install correctly, even though it is not used in the installation, only in the unit tests. This means it is no longer possible to install requests on platforms that lack multiprocessing support (such as Android or IoT devices)
## Expected Result
Requests is installed and available for use
## Actual Result
Installation fails with the following:
```
Downloading/unpacking requests
Downloading requests-2.17.3.tar.gz (123Kb): 123Kb downloaded
Running setup.py egg_info for package requests
Traceback (most recent call last):
File "<string>", line 14, in <module>
File "/tmp/build/requests/setup.py", line 11, in <module>
from multiprocessing import cpu_count
ImportError: No module named multiprocessing
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 14, in <module>
File "/tmp/build/requests/setup.py", line 11, in <module>
from multiprocessing import cpu_count
ImportError: No module named multiprocessing
----------------------------------------
Command python setup.py egg_info failed with error code 1
Storing complete log in /sdcard/com.hipipal.qpyplus/.pip/pip.log
```
## Reproduction Steps
From a platform without multiprocessing:
```
pip install requests
```
## System Information
For obvious reasons, requests.help is not available, but I've tried to piece together the information that it would produce:
- platform.system() Linux
- platform.release() 3.14.29
- implementation CPython
- implementation_version 2.7.2
- ssl.OPENSSL_VERSION_NUMBER 268443727L
- requests_version 2.17.3
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4113/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4113/timeline
| null |
completed
| null | null | false |
[
"Appears to be since e6e3589, I'll see if I can do a fix for it",
"Thanks for this report. It should be entirely possible to pull the multiprocessing import into a tighter scope."
] |
https://api.github.com/repos/psf/requests/issues/4112
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4112/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4112/comments
|
https://api.github.com/repos/psf/requests/issues/4112/events
|
https://github.com/psf/requests/issues/4112
| 232,186,491 |
MDU6SXNzdWUyMzIxODY0OTE=
| 4,112 |
please support cchardet as alternative to chardet
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4757825?v=4",
"events_url": "https://api.github.com/users/2mf/events{/privacy}",
"followers_url": "https://api.github.com/users/2mf/followers",
"following_url": "https://api.github.com/users/2mf/following{/other_user}",
"gists_url": "https://api.github.com/users/2mf/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/2mf",
"id": 4757825,
"login": "2mf",
"node_id": "MDQ6VXNlcjQ3NTc4MjU=",
"organizations_url": "https://api.github.com/users/2mf/orgs",
"received_events_url": "https://api.github.com/users/2mf/received_events",
"repos_url": "https://api.github.com/users/2mf/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/2mf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/2mf/subscriptions",
"type": "User",
"url": "https://api.github.com/users/2mf",
"user_view_type": "public"
}
|
[
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] |
closed
| true | null |
[] | null | 0 |
2017-05-30T09:03:47Z
|
2021-09-08T09:00:41Z
|
2017-05-30T19:46:12Z
|
NONE
|
resolved
|
aiohttp is supporting cchardet as alternative to chardet as it is faster
please do the same in requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4757825?v=4",
"events_url": "https://api.github.com/users/2mf/events{/privacy}",
"followers_url": "https://api.github.com/users/2mf/followers",
"following_url": "https://api.github.com/users/2mf/following{/other_user}",
"gists_url": "https://api.github.com/users/2mf/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/2mf",
"id": 4757825,
"login": "2mf",
"node_id": "MDQ6VXNlcjQ3NTc4MjU=",
"organizations_url": "https://api.github.com/users/2mf/orgs",
"received_events_url": "https://api.github.com/users/2mf/received_events",
"repos_url": "https://api.github.com/users/2mf/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/2mf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/2mf/subscriptions",
"type": "User",
"url": "https://api.github.com/users/2mf",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4112/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4112/timeline
| null |
completed
| null | null | false |
[] |
https://api.github.com/repos/psf/requests/issues/4111
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4111/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4111/comments
|
https://api.github.com/repos/psf/requests/issues/4111/events
|
https://github.com/psf/requests/pull/4111
| 232,142,905 |
MDExOlB1bGxSZXF1ZXN0MTIyOTcxOTE3
| 4,111 |
support urllib3-dev
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-30T04:56:03Z
|
2021-08-28T00:06:24Z
|
2017-05-30T06:52:35Z
|
CONTRIBUTOR
|
resolved
|
A user complained about this this weekend. Open to review / comments.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4111/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4111/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4111.diff",
"html_url": "https://github.com/psf/requests/pull/4111",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4111.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4111"
}
| true |
[
"Feature request revoked"
] |
https://api.github.com/repos/psf/requests/issues/4110
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4110/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4110/comments
|
https://api.github.com/repos/psf/requests/issues/4110/events
|
https://github.com/psf/requests/issues/4110
| 232,142,250 |
MDU6SXNzdWUyMzIxNDIyNTA=
| 4,110 |
Removed Myself from PyPi (security concerns, and otherwise)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-30T04:50:09Z
|
2021-09-08T09:00:42Z
|
2017-05-30T04:50:34Z
|
CONTRIBUTOR
|
resolved
|
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4110/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4110/timeline
| null |
completed
| null | null | false |
[
"Posting here as a matter of record. "
] |
https://api.github.com/repos/psf/requests/issues/4109
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4109/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4109/comments
|
https://api.github.com/repos/psf/requests/issues/4109/events
|
https://github.com/psf/requests/issues/4109
| 232,141,308 |
MDU6SXNzdWUyMzIxNDEzMDg=
| 4,109 |
Concerns about 3.0.0 Plans (cryptography)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "fef2c0",
"default": false,
"description": null,
"id": 60669570,
"name": "Please Review",
"node_id": "MDU6TGFiZWw2MDY2OTU3MA==",
"url": "https://api.github.com/repos/psf/requests/labels/Please%20Review"
}
] |
closed
| true | null |
[] | null | 7 |
2017-05-30T04:40:13Z
|
2021-09-08T09:00:42Z
|
2017-05-30T15:23:33Z
|
CONTRIBUTOR
|
resolved
|
As @Lukasa and I discussed at PyCon, `twisted[tls]`, as it stands, would be a dependency of Requests for version 3.0.0.
I have major concerns for this, as I struggled a lot to get `crypography` to install properly on Linux this weekend.
We need to ensure that if we plan to to do this, before we put all the work in, that zero installation issues will be had by any of our users.
One of the reasons we are popular and well-loved is the fact that we have no installation pains, compared to some other libraries. I think we may need to contribute to `cryptography` (potentially by just making suggestions, or otherwise) in order for this to be a tenable plan for us.
-----------------
Correct me, of course, if I'm unfounded in any of my concern @Lukasa.
Any thoughts?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4109/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4109/timeline
| null |
completed
| null | null | false |
[
"/cc @alex (potentially)",
"So, the biggest thing we're planning to improve this is that we're looking into shipping Linux wheels. /cc @reaperhulk\r\n\r\nThe major blocker for doing that is making pyOpenSSL able to find certificates (not relevant for requests, because `certifi`, but still needed for other consumers). Once that happens we can ship wheels which will help anywhere that can use `manylinux1` wheels.\r\n\r\nWe already have wheels on macOS and Windows, so both of those should be good.",
"fantastic news!",
"So, yes: in the current climate `twisted[tls]` would be mandatory. That may not remain true: there are some rumblings in python-dev about the possibility of backporting the `SSLObject` class from the standard library to 2.7: if that happened, Twisted could be updated to provide TLS using the standard library instead of or as well as with PyOpenSSL, which would resolve our concerns.\r\n\r\nLonger term, we'd like to use platform-native TLS implementations where possible, which requires a bunch of other code.\r\n\r\nAs a general note, I don't think we're likely to be able to do anything that @alex and @reaperhulk can't. They've been worrying about this problem a lot more than we have.",
"As @alex said we're planning on shipping a `manylinux1` wheel soon-ish. This will make it an easy install under these conditions:\r\n\r\n* A sufficiently new `pip` (8.1+)\r\n* The linux distribution is manylinux1 compatible (excludes Alpine linux and any other distribution using musl libc)\r\n\r\nSo it's a big improvement but there will still be users not covered.\r\n\r\nAnd just for fun, here's the statistics on pip major version for the last month out of PyPI:\r\n\r\n",
"PEP for the `ssl` module backport: https://github.com/python/peps/blob/master/pep-0546.txt",
"Concerns resolved :)"
] |
https://api.github.com/repos/psf/requests/issues/4108
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4108/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4108/comments
|
https://api.github.com/repos/psf/requests/issues/4108/events
|
https://github.com/psf/requests/pull/4108
| 232,128,756 |
MDExOlB1bGxSZXF1ZXN0MTIyOTYyODAy
| 4,108 |
flake8 improvements
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-30T02:35:48Z
|
2021-09-05T00:07:19Z
|
2017-05-30T03:08:03Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4108/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4108/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4108.diff",
"html_url": "https://github.com/psf/requests/pull/4108",
"merged_at": "2017-05-30T03:08:03Z",
"patch_url": "https://github.com/psf/requests/pull/4108.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4108"
}
| true |
[
"man, that tool catches some great stuff. thanks for maintaining it, @sigmavirus24!"
] |
|
https://api.github.com/repos/psf/requests/issues/4107
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4107/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4107/comments
|
https://api.github.com/repos/psf/requests/issues/4107/events
|
https://github.com/psf/requests/pull/4107
| 232,107,557 |
MDExOlB1bGxSZXF1ZXN0MTIyOTQ5OTk5
| 4,107 |
windows ci test
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-05-29T22:32:44Z
|
2021-09-05T00:07:20Z
|
2017-05-29T22:35:43Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4107/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4107/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4107.diff",
"html_url": "https://github.com/psf/requests/pull/4107",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4107.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4107"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4106
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4106/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4106/comments
|
https://api.github.com/repos/psf/requests/issues/4106/events
|
https://github.com/psf/requests/pull/4106
| 232,100,900 |
MDExOlB1bGxSZXF1ZXN0MTIyOTQ2MDA4
| 4,106 |
Fix requests.packages not having package attributes
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2896066?v=4",
"events_url": "https://api.github.com/users/ryanpineo/events{/privacy}",
"followers_url": "https://api.github.com/users/ryanpineo/followers",
"following_url": "https://api.github.com/users/ryanpineo/following{/other_user}",
"gists_url": "https://api.github.com/users/ryanpineo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ryanpineo",
"id": 2896066,
"login": "ryanpineo",
"node_id": "MDQ6VXNlcjI4OTYwNjY=",
"organizations_url": "https://api.github.com/users/ryanpineo/orgs",
"received_events_url": "https://api.github.com/users/ryanpineo/received_events",
"repos_url": "https://api.github.com/users/ryanpineo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ryanpineo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ryanpineo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ryanpineo",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-05-29T21:28:15Z
|
2021-09-05T00:07:20Z
|
2017-05-29T21:31:49Z
|
CONTRIBUTOR
|
resolved
|
Fixes #4104
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4106/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4106/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4106.diff",
"html_url": "https://github.com/psf/requests/pull/4106",
"merged_at": "2017-05-29T21:31:49Z",
"patch_url": "https://github.com/psf/requests/pull/4106.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4106"
}
| true |
[
"Im not entirely sure if this is the best way to solve the problem but it looks like it works and causes the tests to pass",
"exactly what i was going to do!",
"Released as 2.17.2!"
] |
https://api.github.com/repos/psf/requests/issues/4105
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4105/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4105/comments
|
https://api.github.com/repos/psf/requests/issues/4105/events
|
https://github.com/psf/requests/issues/4105
| 232,100,274 |
MDU6SXNzdWUyMzIxMDAyNzQ=
| 4,105 |
Since 2.17.1, urllib3 is no longer in requests.packages
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/8939758?v=4",
"events_url": "https://api.github.com/users/andy-maier/events{/privacy}",
"followers_url": "https://api.github.com/users/andy-maier/followers",
"following_url": "https://api.github.com/users/andy-maier/following{/other_user}",
"gists_url": "https://api.github.com/users/andy-maier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/andy-maier",
"id": 8939758,
"login": "andy-maier",
"node_id": "MDQ6VXNlcjg5Mzk3NTg=",
"organizations_url": "https://api.github.com/users/andy-maier/orgs",
"received_events_url": "https://api.github.com/users/andy-maier/received_events",
"repos_url": "https://api.github.com/users/andy-maier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/andy-maier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andy-maier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/andy-maier",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-29T21:22:38Z
|
2021-09-08T09:00:43Z
|
2017-05-29T21:26:53Z
|
NONE
|
resolved
|
The newly released v2.17.1 of the requests package introduced an issue in that `urllib3` is no longer in `requests.packages`:
```
python -c "import zhmcclient; print('Import: ok')"
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "zhmcclient/__init__.py", line 30, in <module>
from ._session import * # noqa: F401
File "zhmcclient/_session.py", line 29, in <module>
from requests.packages import urllib3
ImportError: cannot import name urllib3
```
Version 2.17.0 and before worked fine.
We circumvented this issue by fixing the version of requests to 2.17.0, for now.
## Expected Result
`urllib3` is again in `requests.packages`.
## Actual Result
`urllib3` is no longer in `requests.packages`.
## Reproduction Steps
```python
from requests.packages import urllib3
```
## System Information
This could be reproduced on Python 2.7, 3.4, 3.5, 3.6 and on all OS platforms that we test on (Ubuntu, OS-X and Windows).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4105/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4105/timeline
| null |
completed
| null | null | false |
[
"Closing for #4104"
] |
https://api.github.com/repos/psf/requests/issues/4104
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4104/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4104/comments
|
https://api.github.com/repos/psf/requests/issues/4104/events
|
https://github.com/psf/requests/issues/4104
| 232,098,975 |
MDU6SXNzdWUyMzIwOTg5NzU=
| 4,104 |
AttributeError: module 'requests.packages' has no attribute 'urllib3'
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2896066?v=4",
"events_url": "https://api.github.com/users/ryanpineo/events{/privacy}",
"followers_url": "https://api.github.com/users/ryanpineo/followers",
"following_url": "https://api.github.com/users/ryanpineo/following{/other_user}",
"gists_url": "https://api.github.com/users/ryanpineo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ryanpineo",
"id": 2896066,
"login": "ryanpineo",
"node_id": "MDQ6VXNlcjI4OTYwNjY=",
"organizations_url": "https://api.github.com/users/ryanpineo/orgs",
"received_events_url": "https://api.github.com/users/ryanpineo/received_events",
"repos_url": "https://api.github.com/users/ryanpineo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ryanpineo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ryanpineo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ryanpineo",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 11 |
2017-05-29T21:10:40Z
|
2021-09-08T07:00:26Z
|
2017-05-29T21:31:49Z
|
CONTRIBUTOR
|
resolved
|
This [commit](https://github.com/requests/requests/commit/588e8f7f640f774e71d61b53ccb34d310172e0ad) seems to have broken requests.packages.
## Expected Result
requests.packages.urllib3 to be the urllib3 package
## Actual Result
AttributeError: module 'requests.packages' has no attribute 'urllib3'
## Reproduction Steps
```python
import requests
requests.packages.urllib3
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "3.0.3"
},
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "3.6.1"
},
"platform": {
"release": "4.11.2-1-ARCH",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.17.1"
},
"system_ssl": {
"version": "1010006f"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/4104/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4104/timeline
| null |
completed
| null | null | false |
[
"Interesting, I am unable to reproduce locally",
"nevermind!",
"I'm able to reproduce this locally. It looks like this may be the product of removing the actual `import` statements.",
"fix released in 2.17.2!",
"Thanks for the speedy resolution!",
"Thanks for the speedy release, but it does not work for us.\r\n\r\nOn OS-X, it fails (see the end of this Travis log: https://travis-ci.org/zhmcclient/python-zhmcclient/jobs/237306514\r\n\r\nUpdate: I restarted that run. Maybe it interfered with the release. Let's see how it works.\r\n\r\nUpdate: 2.17.2 fails with the same symptom as in 2.17.1:\r\n```\r\nSuccessfully installed certifi-2017.4.17 chardet-3.0.3 click-6.7 click-repl-0.1.2 click-spinner-0.1.7 decorator-4.0.11 idna-2.5 pbr-3.0.1 progressbar2-3.20.2 prompt-toolkit-1.0.14 python-utils-2.1.0 requests-2.17.2 stomp.py-4.1.17 tabulate-0.7.7 urllib3-1.21.1 wcwidth-0.1.7 zhmcclient-0.13.1.dev39\r\npython -c \"import zhmcclient; print('Import: ok')\"\r\nTraceback (most recent call last):\r\n File \"<string>\", line 1, in <module>\r\n File \"zhmcclient/__init__.py\", line 30, in <module>\r\n from ._session import * # noqa: F401\r\n File \"zhmcclient/_session.py\", line 29, in <module>\r\n from requests.packages import urllib3\r\nImportError: cannot import name urllib3\r\n```",
"It seems like although the latest version is now 2.17.2 the release doesn't actually contain the fix.",
"@ryanpineo 2.17.3",
"All good now, thanks!",
"I can confirm that requests 2.17.3 worked fine again on Py 2.7 on Ubuntu. I'll update our requirements.txt file to exclude requests 2.17.1 and 2.17.2, and re-run all other environments and if you don't hear from me, they were fine.\r\n\r\nAgain, thanks much for the speedy fix!!",
"\\o/"
] |
https://api.github.com/repos/psf/requests/issues/4103
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4103/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4103/comments
|
https://api.github.com/repos/psf/requests/issues/4103/events
|
https://github.com/psf/requests/pull/4103
| 232,087,196 |
MDExOlB1bGxSZXF1ZXN0MTIyOTM3OTU0
| 4,103 |
Preserve identity of unbundled deps
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/837573?v=4",
"events_url": "https://api.github.com/users/untitaker/events{/privacy}",
"followers_url": "https://api.github.com/users/untitaker/followers",
"following_url": "https://api.github.com/users/untitaker/following{/other_user}",
"gists_url": "https://api.github.com/users/untitaker/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/untitaker",
"id": 837573,
"login": "untitaker",
"node_id": "MDQ6VXNlcjgzNzU3Mw==",
"organizations_url": "https://api.github.com/users/untitaker/orgs",
"received_events_url": "https://api.github.com/users/untitaker/received_events",
"repos_url": "https://api.github.com/users/untitaker/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/untitaker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/untitaker/subscriptions",
"type": "User",
"url": "https://api.github.com/users/untitaker",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-29T19:43:03Z
|
2021-09-05T00:07:21Z
|
2017-05-29T19:45:39Z
|
CONTRIBUTOR
|
resolved
|
Fix #4102
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4103/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4103/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4103.diff",
"html_url": "https://github.com/psf/requests/pull/4103",
"merged_at": "2017-05-29T19:45:39Z",
"patch_url": "https://github.com/psf/requests/pull/4103.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4103"
}
| true |
[
"interesting. I didn't know you could use `__import__` usefully without an assignment. "
] |
https://api.github.com/repos/psf/requests/issues/4102
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4102/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4102/comments
|
https://api.github.com/repos/psf/requests/issues/4102/events
|
https://github.com/psf/requests/issues/4102
| 232,086,285 |
MDU6SXNzdWUyMzIwODYyODU=
| 4,102 |
submodules of requests.packages.urllib3 are not equal to urllib3's
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/837573?v=4",
"events_url": "https://api.github.com/users/untitaker/events{/privacy}",
"followers_url": "https://api.github.com/users/untitaker/followers",
"following_url": "https://api.github.com/users/untitaker/following{/other_user}",
"gists_url": "https://api.github.com/users/untitaker/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/untitaker",
"id": 837573,
"login": "untitaker",
"node_id": "MDQ6VXNlcjgzNzU3Mw==",
"organizations_url": "https://api.github.com/users/untitaker/orgs",
"received_events_url": "https://api.github.com/users/untitaker/received_events",
"repos_url": "https://api.github.com/users/untitaker/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/untitaker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/untitaker/subscriptions",
"type": "User",
"url": "https://api.github.com/users/untitaker",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
] | null | 3 |
2017-05-29T19:35:46Z
|
2021-09-08T09:00:44Z
|
2017-05-29T19:45:39Z
|
CONTRIBUTOR
|
resolved
|
See title. Caused by the unbundling and related to e.g. #4072
## Reproduction Steps
```python
import requests.packages.urllib3
import urllib3
from requests.packages.urllib3.connectionpool import HTTPConnection as old
from urllib3.connectionpool import HTTPConnection as new
assert old is new
```
The assertion should not fail, but does on my machine
## System Information
```
{
"chardet": {
"version": "3.0.3"
},
"cryptography": {
"version": "1.8.1"
},
"implementation": {
"name": "CPython",
"version": "3.6.1"
},
"platform": {
"release": "4.10.13-1-ARCH",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "100020bf",
"version": "16.2.0"
},
"requests": {
"version": "2.17.0"
},
"system_ssl": {
"version": "1010005f"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": true
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4102/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4102/timeline
| null |
completed
| null | null | false |
[
"Thank you for bringing such a reproducible case. I'll see what I can do. ",
"I have a clue what might help, let me see.",
"<3"
] |
https://api.github.com/repos/psf/requests/issues/4101
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4101/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4101/comments
|
https://api.github.com/repos/psf/requests/issues/4101/events
|
https://github.com/psf/requests/issues/4101
| 232,076,714 |
MDU6SXNzdWUyMzIwNzY3MTQ=
| 4,101 |
Connection pool is full, discarding connection: localhost in 2.17.0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/499317?v=4",
"events_url": "https://api.github.com/users/bedge/events{/privacy}",
"followers_url": "https://api.github.com/users/bedge/followers",
"following_url": "https://api.github.com/users/bedge/following{/other_user}",
"gists_url": "https://api.github.com/users/bedge/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bedge",
"id": 499317,
"login": "bedge",
"node_id": "MDQ6VXNlcjQ5OTMxNw==",
"organizations_url": "https://api.github.com/users/bedge/orgs",
"received_events_url": "https://api.github.com/users/bedge/received_events",
"repos_url": "https://api.github.com/users/bedge/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bedge/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bedge/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bedge",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-05-29T18:21:59Z
|
2021-09-08T09:00:43Z
|
2017-05-29T23:16:39Z
|
NONE
|
resolved
|
Summary.
After upgrading to 2.17.0 (from 2.14.2) I got an immediate failure on all apps using the requests lib.
Given the fact that no one else has seen this, I expect it's an incompatibility between other libs.
Filing here first to track.
## Expected Result
No exception in normal use case.
What you expected.
No exception in normal use case.
## Actual Result
```
u'25177330-cf2a-3943-af3b-86582902a2cc', u'f296a708-e02c-393, resp:None, <type 'exceptions.ValueError'> Timeout value connect was Timeout(connect=None, read=None, total=None), but it must be an int, float or None.
Traceback (most recent call last):
File "/opt/nim/ur-api/mlutil/sdk/nimsdk.py", line 154, in _GET
params=arguments
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 526, in get
return self.request('GET', url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 513, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 623, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 440, in send
timeout=timeout
File "/usr/local/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 587, in urlopen
timeout_obj = self._get_timeout(timeout)
File "/usr/local/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 302, in _get_timeout
return Timeout.from_float(timeout)
File "/usr/local/lib/python2.7/dist-packages/urllib3/util/timeout.py", line 154, in from_float
return Timeout(read=timeout, connect=timeout)
File "/usr/local/lib/python2.7/dist-packages/urllib3/util/timeout.py", line 94, in __init__
self._connect = self._validate_timeout(connect, 'connect')
File "/usr/local/lib/python2.7/dist-packages/urllib3/util/timeout.py", line 127, in _validate_timeout
"int, float or None." % (name, value))
ValueError: Timeout value connect was Timeout(connect=None, read=None, total=None), but it must be an int, float or None.
```
What happened instead.
See exception above
## Reproduction Steps
Have not tried to isolate or narrow focus.
## System Information
$ python -m requests.help
```
ubuntu@ip-10-200-17-89:~$ python --version
Python 2.7.12
ubuntu@ip-10-200-17-89:~$ pip --version
pip 9.0.1 from /usr/local/lib/python2.7/dist-packages (python 2.7)
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/499317?v=4",
"events_url": "https://api.github.com/users/bedge/events{/privacy}",
"followers_url": "https://api.github.com/users/bedge/followers",
"following_url": "https://api.github.com/users/bedge/following{/other_user}",
"gists_url": "https://api.github.com/users/bedge/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bedge",
"id": 499317,
"login": "bedge",
"node_id": "MDQ6VXNlcjQ5OTMxNw==",
"organizations_url": "https://api.github.com/users/bedge/orgs",
"received_events_url": "https://api.github.com/users/bedge/received_events",
"repos_url": "https://api.github.com/users/bedge/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bedge/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bedge/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bedge",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4101/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4101/timeline
| null |
completed
| null | null | false |
[
"Thanks for taking the time to open this ticket, @bedge. I've got a feeling this is related to the unvendoring of Requests' dependencies. It looks like this *should* be solved in 2.17.1. Would you mind upgrading before we continue debugging here?",
"Confirmed fixed in:\r\n```\r\nrequests==2.17.3\r\n```\r\nThanks for the rapid response.",
"\\o/"
] |
https://api.github.com/repos/psf/requests/issues/4100
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4100/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4100/comments
|
https://api.github.com/repos/psf/requests/issues/4100/events
|
https://github.com/psf/requests/pull/4100
| 232,065,915 |
MDExOlB1bGxSZXF1ZXN0MTIyOTI0NDAy
| 4,100 |
Remove session redirect cache
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/706257?v=4",
"events_url": "https://api.github.com/users/bcongdon/events{/privacy}",
"followers_url": "https://api.github.com/users/bcongdon/followers",
"following_url": "https://api.github.com/users/bcongdon/following{/other_user}",
"gists_url": "https://api.github.com/users/bcongdon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bcongdon",
"id": 706257,
"login": "bcongdon",
"node_id": "MDQ6VXNlcjcwNjI1Nw==",
"organizations_url": "https://api.github.com/users/bcongdon/orgs",
"received_events_url": "https://api.github.com/users/bcongdon/received_events",
"repos_url": "https://api.github.com/users/bcongdon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bcongdon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bcongdon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bcongdon",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-29T16:56:29Z
|
2021-09-05T00:07:22Z
|
2017-05-29T17:14:43Z
|
CONTRIBUTOR
|
resolved
|
Addresses #4055. Essentially, this just strips out the redirect cache in `sessions.py`.
I ran the tests and didn't find any side effects of removing the cache. This is my first PR to requests, so let me know if there's any additional steps that need to be done.
Thanks!
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4100/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4100/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4100.diff",
"html_url": "https://github.com/psf/requests/pull/4100",
"merged_at": "2017-05-29T17:14:43Z",
"patch_url": "https://github.com/psf/requests/pull/4100.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4100"
}
| true |
[
"This looks great! If the tests pass, we can release this as v0.17.0"
] |
https://api.github.com/repos/psf/requests/issues/4099
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4099/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4099/comments
|
https://api.github.com/repos/psf/requests/issues/4099/events
|
https://github.com/psf/requests/pull/4099
| 232,059,459 |
MDExOlB1bGxSZXF1ZXN0MTIyOTIwMDU3
| 4,099 |
Requests namespace
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-29T16:12:09Z
|
2021-09-05T00:07:21Z
|
2017-05-29T17:15:21Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4099/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4099/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4099.diff",
"html_url": "https://github.com/psf/requests/pull/4099",
"merged_at": "2017-05-29T17:15:21Z",
"patch_url": "https://github.com/psf/requests/pull/4099.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4099"
}
| true |
[
"🍰 🎉 "
] |
|
https://api.github.com/repos/psf/requests/issues/4098
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4098/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4098/comments
|
https://api.github.com/repos/psf/requests/issues/4098/events
|
https://github.com/psf/requests/pull/4098
| 231,986,398 |
MDExOlB1bGxSZXF1ZXN0MTIyODY5MTU2
| 4,098 |
move functionlocal imports in utils.py and models.py to global scope
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1318438?v=4",
"events_url": "https://api.github.com/users/NiklasRosenstein/events{/privacy}",
"followers_url": "https://api.github.com/users/NiklasRosenstein/followers",
"following_url": "https://api.github.com/users/NiklasRosenstein/following{/other_user}",
"gists_url": "https://api.github.com/users/NiklasRosenstein/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/NiklasRosenstein",
"id": 1318438,
"login": "NiklasRosenstein",
"node_id": "MDQ6VXNlcjEzMTg0Mzg=",
"organizations_url": "https://api.github.com/users/NiklasRosenstein/orgs",
"received_events_url": "https://api.github.com/users/NiklasRosenstein/received_events",
"repos_url": "https://api.github.com/users/NiklasRosenstein/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/NiklasRosenstein/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NiklasRosenstein/subscriptions",
"type": "User",
"url": "https://api.github.com/users/NiklasRosenstein",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-05-29T10:33:18Z
|
2021-09-05T00:07:21Z
|
2017-05-29T17:24:48Z
|
NONE
|
resolved
|
This avoids runtime warnings when using the `requests` module for the first time when it is no longer in `sys.modules`.
```
[...]\Lib\site-packages\requests\utils.py:164: RuntimeWarning: Parent module 'requests' not found while handling absolute import
from netrc import netrc, NetrcParseError
[...]\Lib\site-packages\requests\utils.py:49: RuntimeWarning: Parent module 'requests' not found while handling absolute import
import _winreg as winreg
```
Seeing this warning is very common for me, since I develop Python plugins for an application that embeds Python. To ensure that no dependencies between plugins are conflicting, every plugin develiers its own dependencies and makes sure they leave no trace in `sys.modules` and `sys.path`.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4098/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4098/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4098.diff",
"html_url": "https://github.com/psf/requests/pull/4098",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4098.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4098"
}
| true |
[
"Hrm, I'm pretty nervous about this. It's hard for us to avoid regressing this behaviour and it's extremely likely that we'd add it somewhere else. Is it not more advisable to silence the warning?",
"While that is possible, eg. by wrapping the requests API, the [`warnings` \"Temporarily Suppressing Warnings\"][0] documentation states that the behaviour is undefined in multithreaded applications.\r\n\r\n [0]: https://docs.python.org/2/library/warnings.html#temporarily-suppressing-warnings\r\n\r\nSuppressing all warnings, always, is definitely not an option.\r\n\r\n```python\r\ndef requests_get(*args, **kwargs):\r\n with warnings.catch_warnings(): # UB in multithreaded applications\r\n warnings.simplefilter('ignore')\r\n return requests.get(*args, **kwargs)\r\n```\r\n",
"I'm going to close this. "
] |
https://api.github.com/repos/psf/requests/issues/4097
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4097/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4097/comments
|
https://api.github.com/repos/psf/requests/issues/4097/events
|
https://github.com/psf/requests/issues/4097
| 231,963,667 |
MDU6SXNzdWUyMzE5NjM2Njc=
| 4,097 |
Allow passing a JSONEncoder and JSONDecoder
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/779047?v=4",
"events_url": "https://api.github.com/users/remcohaszing/events{/privacy}",
"followers_url": "https://api.github.com/users/remcohaszing/followers",
"following_url": "https://api.github.com/users/remcohaszing/following{/other_user}",
"gists_url": "https://api.github.com/users/remcohaszing/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/remcohaszing",
"id": 779047,
"login": "remcohaszing",
"node_id": "MDQ6VXNlcjc3OTA0Nw==",
"organizations_url": "https://api.github.com/users/remcohaszing/orgs",
"received_events_url": "https://api.github.com/users/remcohaszing/received_events",
"repos_url": "https://api.github.com/users/remcohaszing/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/remcohaszing/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/remcohaszing/subscriptions",
"type": "User",
"url": "https://api.github.com/users/remcohaszing",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2017-05-29T08:53:37Z
|
2021-09-08T08:00:42Z
|
2017-05-29T08:59:41Z
|
NONE
|
resolved
|
The python json module supports a custom [JSONEncoder] and [JSONDecoder]. This enables to serialize / deserialize custom data formats. Since requests just passes JSON data directly to `json.dumps` and `json.loads`, it is not possible to customize JSON serialization at all. As a result one must configure configure the JSON request manually, meaning the content type needs to be set manually.
I suggest to add the ability to pass custom `json_encoder` and `json_decoder` properties to requests. This handles pretty much all other arguments that could be passed to `json.dumps` and `json.loads` as well.
This example:
```python
response = requests.post(
'https://www.example.com',
content_type='application/json',
data=json.dumps(data, cls=MyEncoder))
result = json.loads(response.text, cls=MyDecoder)
```
would become:
```python
response = requests.post(
'https://www.example.com',
json=data,
json_encoder=MyEncoder,
json_decoder=MyDecoder)
result = response.json()
```
I could even imagine that it's useful to pass these arguments to the session constructor, because data from one session might often contain the same types of data serialization.
```python
session = requests.Session(json_encoder=MyEncoder, json_decoder=MyDecoder)
response = session.post('https://www.example.com', json=data)
result = response.json()
```
[JSONDecoder]: https://docs.python.org/3.6/library/json.html#json.JSONDecoder
[JSONEncoder]: https://docs.python.org/3.6/library/json.html#json.JSONEncoder
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4097/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4097/timeline
| null |
completed
| null | null | false |
[
"Thanks for this suggestion!\r\n\r\nIt's been provided before and was rejected (see #2755): the same argument applies here, I'm afraid. This is just too minor in utility to justify adding the extra kwargs: `json=` triggers only a tiny amount of code that can easily be replicated in your own application. :smile:",
"Agreed!",
"@Lukasa @kennethreitz I have to disagree. It is probably simple workaround for **request** JSON. But what about **response** JSON? `requests` uses built-in decoder and if you want later inspect and transform that JSON response - it will require recursively analyze and convert them (in case of complex nested json objects) - what is definitely not what we want . \r\nConsider following scenario:\r\n\r\n1. `POST` JSON object to server, which contains strings with zoned datetime\r\n2. Database does know nothing about timezone of user and convert to internal representation (`UTC`)\r\n3. `GET` JSON object from server, zoned datetime will be the same, but with different string representation\r\n4. Compare that two JSON objects are identical\r\nStep 4 will require some kind of normalization of JSONs - for example convert strings to datetime or [Arrow](http://arrow.readthedocs.io/en/latest/) object and compare that objects.\r\nIf `requests` doesn't provide custom decoders - user have recursively (and safe, without stack overflow) walk over JSON tree structure (same job done twice).\r\n _I think it greatly complicates things._",
"@likern Not really. Just use `response.content` instead of `response.json()` and pass to your own custom decoder instead. One extra line of code. Doesn't seem to be a great increase in complexity to me. :wink:"
] |
https://api.github.com/repos/psf/requests/issues/4096
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4096/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4096/comments
|
https://api.github.com/repos/psf/requests/issues/4096/events
|
https://github.com/psf/requests/issues/4096
| 231,952,326 |
MDU6SXNzdWUyMzE5NTIzMjY=
| 4,096 |
Requests > 2.16.1 breaks urllib3's Retry functionality
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/372783?v=4",
"events_url": "https://api.github.com/users/thomir/events{/privacy}",
"followers_url": "https://api.github.com/users/thomir/followers",
"following_url": "https://api.github.com/users/thomir/following{/other_user}",
"gists_url": "https://api.github.com/users/thomir/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/thomir",
"id": 372783,
"login": "thomir",
"node_id": "MDQ6VXNlcjM3Mjc4Mw==",
"organizations_url": "https://api.github.com/users/thomir/orgs",
"received_events_url": "https://api.github.com/users/thomir/received_events",
"repos_url": "https://api.github.com/users/thomir/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/thomir/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thomir/subscriptions",
"type": "User",
"url": "https://api.github.com/users/thomir",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 7 |
2017-05-29T07:59:52Z
|
2021-09-08T09:00:44Z
|
2017-05-29T20:40:19Z
|
NONE
|
resolved
|
Hi,
We had code that used the vendorised urllib3 Retry functionality like so:
```python
from requests.packages.urllib3.util import Retry
session = requests.Session()
retries = Retry(
total=2, method_whitelist=['GET', 'POST', 'PATCH'],
status_forcelist=[500, 502, 503, 504])
retryable_adapter = HTTPAdapter(max_retries=retries)
session.mount('http://', retryable_adapter)
session.mount('https://', retryable_adapter)
```
When we were running requests 2.13.0 this worked fine. However, today we upgraded to 2.16.5 and found that while the above code does not error, it now silently does nothing.
This is because:
`HTTPAdapter.__init__` calls `self.max_retries = Retry.from_int(max_retries)`, passing my Retry instance into Retry.from_int. `Retry.from_int` has this snippet of code:
```python
if isinstance(retries, Retry):
return retries
```
In earlier versions of requests this returned my `Retry` instance unchanged. However now the `isinstance` check fails because:
```
>>> type(retries)
<class 'requests.packages.urllib3.util.retry.Retry'>
>>> Retry
<class 'urllib3.util.retry.Retry'>
```
I note that in 2.16.1 the release notes mentioned this exact problem, and provided a workaround (that works!). However, the release notes for [2.16.2](https://github.com/kennethreitz/requests/blob/master/HISTORY.rst#2162-2017-05-27) say that the workaround is no longer necessary.
I'm happy with the workaround documented in the 2.16.1 release notes, but wanted to file this bug so you're aware that the advice in the 2.16.2 release notes is misleading, and leads to subtle bugs.
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "3.0.3"
},
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "3.4.3"
},
"platform": {
"release": "4.10.0-21-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.16.5"
},
"system_ssl": {
"version": "1000106f"
},
"urllib3": {
"version": "1.21.1"
},
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4096/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4096/timeline
| null |
completed
| null | null | false |
[
"Thanks for this report! I think this is for @kennethreitz to deal with. 😁",
"Can you confirm for me that you don't have any older Requests `*.pyc` files in your environment? I can't reproduce this with the current master branch:\r\n\r\n```pycon\r\n>>> import requests\r\n>>> import urllib3\r\n>>> x = urllib3.util.retry.Retry.from_int(5)\r\n>>> isinstance(x, urllib3.util.retry.Retry)\r\nTrue\r\n>>> isinstance(x, requests.packages.urllib3.util.retry.Retry)\r\nTrue\r\n>>> y = requests.packages.urllib3.util.retry.Retry.from_int(5)\r\n>>> isinstance(y, urllib3.util.Retry)\r\nTrue\r\n>>> type(x)\r\n<class 'urllib3.util.retry.Retry'>\r\n>>> type(y)\r\n<class 'urllib3.util.retry.Retry'>\r\n>>> requests.__version__\r\n'2.16.5'\r\n```",
"@thomir congratulations for being the first person to use `$ python -m requests.help`!",
"Can you try v2.17.1?",
"I've created a minimal script that reproduces the problem:\r\n\r\nhttps://gist.github.com/thomir/f032c0fd56dbbad258b9ca99a2b15740\r\n\r\nNo doubt you have simpler methods than this, but I think it demonstrates the issue. \r\n\r\nI'll try running 2.17.1 now.",
"@kennethreitz 2.17.1 does indeed work for me. Thanks!",
"\\o/\r\n\r\nSorry for the issue!"
] |
https://api.github.com/repos/psf/requests/issues/4095
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4095/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4095/comments
|
https://api.github.com/repos/psf/requests/issues/4095/events
|
https://github.com/psf/requests/pull/4095
| 231,933,534 |
MDExOlB1bGxSZXF1ZXN0MTIyODMyNDE4
| 4,095 |
test
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-05-29T06:01:26Z
|
2021-09-05T00:07:22Z
|
2017-05-29T15:40:06Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4095/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4095/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4095.diff",
"html_url": "https://github.com/psf/requests/pull/4095",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4095.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4095"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4094
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4094/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4094/comments
|
https://api.github.com/repos/psf/requests/issues/4094/events
|
https://github.com/psf/requests/pull/4094
| 231,930,372 |
MDExOlB1bGxSZXF1ZXN0MTIyODMwMjY3
| 4,094 |
Flake8
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-05-29T05:32:02Z
|
2021-09-05T00:07:22Z
|
2017-05-29T05:53:27Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4094/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4094/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4094.diff",
"html_url": "https://github.com/psf/requests/pull/4094",
"merged_at": "2017-05-29T05:53:27Z",
"patch_url": "https://github.com/psf/requests/pull/4094.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4094"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4093
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4093/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4093/comments
|
https://api.github.com/repos/psf/requests/issues/4093/events
|
https://github.com/psf/requests/pull/4093
| 231,929,892 |
MDExOlB1bGxSZXF1ZXN0MTIyODMwMDAx
| 4,093 |
More Testing
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/208567?v=4",
"events_url": "https://api.github.com/users/erinxocon/events{/privacy}",
"followers_url": "https://api.github.com/users/erinxocon/followers",
"following_url": "https://api.github.com/users/erinxocon/following{/other_user}",
"gists_url": "https://api.github.com/users/erinxocon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/erinxocon",
"id": 208567,
"login": "erinxocon",
"node_id": "MDQ6VXNlcjIwODU2Nw==",
"organizations_url": "https://api.github.com/users/erinxocon/orgs",
"received_events_url": "https://api.github.com/users/erinxocon/received_events",
"repos_url": "https://api.github.com/users/erinxocon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/erinxocon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erinxocon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/erinxocon",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-05-29T05:27:48Z
|
2021-09-05T00:07:23Z
|
2017-05-29T05:53:09Z
|
NONE
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4093/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4093/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4093.diff",
"html_url": "https://github.com/psf/requests/pull/4093",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4093.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4093"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4092
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4092/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4092/comments
|
https://api.github.com/repos/psf/requests/issues/4092/events
|
https://github.com/psf/requests/pull/4092
| 231,927,544 |
MDExOlB1bGxSZXF1ZXN0MTIyODI4NTQ0
| 4,092 |
testing
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/208567?v=4",
"events_url": "https://api.github.com/users/erinxocon/events{/privacy}",
"followers_url": "https://api.github.com/users/erinxocon/followers",
"following_url": "https://api.github.com/users/erinxocon/following{/other_user}",
"gists_url": "https://api.github.com/users/erinxocon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/erinxocon",
"id": 208567,
"login": "erinxocon",
"node_id": "MDQ6VXNlcjIwODU2Nw==",
"organizations_url": "https://api.github.com/users/erinxocon/orgs",
"received_events_url": "https://api.github.com/users/erinxocon/received_events",
"repos_url": "https://api.github.com/users/erinxocon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/erinxocon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erinxocon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/erinxocon",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-29T05:02:57Z
|
2021-09-06T00:06:47Z
|
2017-05-29T05:26:49Z
|
NONE
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4092/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4092/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4092.diff",
"html_url": "https://github.com/psf/requests/pull/4092",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4092.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4092"
}
| true |
[
"add to whitelist"
] |
|
https://api.github.com/repos/psf/requests/issues/4091
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4091/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4091/comments
|
https://api.github.com/repos/psf/requests/issues/4091/events
|
https://github.com/psf/requests/pull/4091
| 231,925,602 |
MDExOlB1bGxSZXF1ZXN0MTIyODI3MjQ1
| 4,091 |
test
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/208567?v=4",
"events_url": "https://api.github.com/users/erinxocon/events{/privacy}",
"followers_url": "https://api.github.com/users/erinxocon/followers",
"following_url": "https://api.github.com/users/erinxocon/following{/other_user}",
"gists_url": "https://api.github.com/users/erinxocon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/erinxocon",
"id": 208567,
"login": "erinxocon",
"node_id": "MDQ6VXNlcjIwODU2Nw==",
"organizations_url": "https://api.github.com/users/erinxocon/orgs",
"received_events_url": "https://api.github.com/users/erinxocon/received_events",
"repos_url": "https://api.github.com/users/erinxocon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/erinxocon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erinxocon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/erinxocon",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-29T04:41:12Z
|
2021-09-06T00:06:48Z
|
2017-05-29T05:01:47Z
|
NONE
|
resolved
|
changed humans to human
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4091/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4091/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4091.diff",
"html_url": "https://github.com/psf/requests/pull/4091",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4091.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4091"
}
| true |
[
"# [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4091?src=pr&el=h1) Report\n> Merging [#4091](https://codecov.io/gh/kennethreitz/requests/pull/4091?src=pr&el=desc) into [master](https://codecov.io/gh/kennethreitz/requests/commit/78349914c818db5f904f630e3614e488260772ef?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/kennethreitz/requests/pull/4091?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #4091 +/- ##\n=======================================\n Coverage 87.45% 87.45% \n=======================================\n Files 18 18 \n Lines 2025 2025 \n=======================================\n Hits 1771 1771 \n Misses 254 254\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4091?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4091?src=pr&el=footer). Last update [7834991...4e56506](https://codecov.io/gh/kennethreitz/requests/pull/4091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"
] |
https://api.github.com/repos/psf/requests/issues/4090
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4090/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4090/comments
|
https://api.github.com/repos/psf/requests/issues/4090/events
|
https://github.com/psf/requests/pull/4090
| 231,920,046 |
MDExOlB1bGxSZXF1ZXN0MTIyODIzNjU4
| 4,090 |
just testing
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-05-29T03:36:35Z
|
2021-09-05T00:07:19Z
|
2017-05-29T05:01:35Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4090/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4090/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4090.diff",
"html_url": "https://github.com/psf/requests/pull/4090",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4090.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4090"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4089
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4089/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4089/comments
|
https://api.github.com/repos/psf/requests/issues/4089/events
|
https://github.com/psf/requests/pull/4089
| 231,909,363 |
MDExOlB1bGxSZXF1ZXN0MTIyODE3MDQ2
| 4,089 |
test 4
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-29T01:29:45Z
|
2021-09-06T00:06:48Z
|
2017-05-29T03:36:01Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4089/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4089/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4089.diff",
"html_url": "https://github.com/psf/requests/pull/4089",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4089.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4089"
}
| true |
[
"# [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4089?src=pr&el=h1) Report\n> Merging [#4089](https://codecov.io/gh/kennethreitz/requests/pull/4089?src=pr&el=desc) into [master](https://codecov.io/gh/kennethreitz/requests/commit/78349914c818db5f904f630e3614e488260772ef?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/kennethreitz/requests/pull/4089?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #4089 +/- ##\n=======================================\n Coverage 87.45% 87.45% \n=======================================\n Files 18 18 \n Lines 2025 2025 \n=======================================\n Hits 1771 1771 \n Misses 254 254\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4089?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4089?src=pr&el=footer). Last update [7834991...8ddba46](https://codecov.io/gh/kennethreitz/requests/pull/4089?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"
] |
|
https://api.github.com/repos/psf/requests/issues/4088
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4088/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4088/comments
|
https://api.github.com/repos/psf/requests/issues/4088/events
|
https://github.com/psf/requests/pull/4088
| 231,904,827 |
MDExOlB1bGxSZXF1ZXN0MTIyODE0NTYx
| 4,088 |
test 3
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 8 |
2017-05-29T00:18:28Z
|
2021-09-06T00:06:48Z
|
2017-05-29T01:51:22Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4088/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4088/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4088.diff",
"html_url": "https://github.com/psf/requests/pull/4088",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4088.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4088"
}
| true |
[
"Can one of the admins verify this patch?",
"Can one of the admins verify this patch?",
"Can one of the admins verify this patch?",
"Can one of the admins verify this patch?",
"add to whitelist",
"ok to test",
"ok to test",
"ok to test"
] |
|
https://api.github.com/repos/psf/requests/issues/4087
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4087/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4087/comments
|
https://api.github.com/repos/psf/requests/issues/4087/events
|
https://github.com/psf/requests/pull/4087
| 231,904,253 |
MDExOlB1bGxSZXF1ZXN0MTIyODE0MjQx
| 4,087 |
test 2
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-05-29T00:07:12Z
|
2021-09-06T00:06:49Z
|
2017-05-29T00:17:04Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4087/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4087/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4087.diff",
"html_url": "https://github.com/psf/requests/pull/4087",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4087.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4087"
}
| true |
[
"test",
"Can one of the admins verify this patch?"
] |
|
https://api.github.com/repos/psf/requests/issues/4086
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4086/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4086/comments
|
https://api.github.com/repos/psf/requests/issues/4086/events
|
https://github.com/psf/requests/pull/4086
| 231,880,507 |
MDExOlB1bGxSZXF1ZXN0MTIyODAxNTY5
| 4,086 |
try this travis file
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-28T16:54:31Z
|
2021-09-05T00:07:19Z
|
2017-05-28T18:38:52Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4086/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4086/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4086.diff",
"html_url": "https://github.com/psf/requests/pull/4086",
"merged_at": "2017-05-28T18:38:52Z",
"patch_url": "https://github.com/psf/requests/pull/4086.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4086"
}
| true |
[
"# [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4086?src=pr&el=h1) Report\n> Merging [#4086](https://codecov.io/gh/kennethreitz/requests/pull/4086?src=pr&el=desc) into [master](https://codecov.io/gh/kennethreitz/requests/commit/303eca03f31741571fe2025d792ca3db28687078?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/kennethreitz/requests/pull/4086?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #4086 +/- ##\n=======================================\n Coverage 87.45% 87.45% \n=======================================\n Files 18 18 \n Lines 2025 2025 \n=======================================\n Hits 1771 1771 \n Misses 254 254\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4086?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4086?src=pr&el=footer). Last update [303eca0...2ccecf6](https://codecov.io/gh/kennethreitz/requests/pull/4086?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"
] |
|
https://api.github.com/repos/psf/requests/issues/4085
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4085/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4085/comments
|
https://api.github.com/repos/psf/requests/issues/4085/events
|
https://github.com/psf/requests/issues/4085
| 231,872,723 |
MDU6SXNzdWUyMzE4NzI3MjM=
| 4,085 |
AttributeError using socks5 support [socks]
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/17954776?v=4",
"events_url": "https://api.github.com/users/dorazouri/events{/privacy}",
"followers_url": "https://api.github.com/users/dorazouri/followers",
"following_url": "https://api.github.com/users/dorazouri/following{/other_user}",
"gists_url": "https://api.github.com/users/dorazouri/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dorazouri",
"id": 17954776,
"login": "dorazouri",
"node_id": "MDQ6VXNlcjE3OTU0Nzc2",
"organizations_url": "https://api.github.com/users/dorazouri/orgs",
"received_events_url": "https://api.github.com/users/dorazouri/received_events",
"repos_url": "https://api.github.com/users/dorazouri/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dorazouri/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dorazouri/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dorazouri",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-28T14:31:58Z
|
2021-09-08T09:00:50Z
|
2017-05-28T14:40:25Z
|
NONE
|
resolved
|
Using requests with a socks5 proxy fails on:
AttributeError: 'super' object has no attribute 'settimeout'
## Reproduction Steps
`pip install requests[socks]==2.14.2`
(this installs PySocks v1.6.7)
run a socks proxy on port 9050. I use Tor for that matter.
Simplified code I use is:
```python
import requests
proxies={'http': 'socks5://127.0.0.1:9050'}
url = 'http://www.whatismyip.org/'
requests.get(url, proxies=proxies)
```
## System Information
```
Windows 7 (x64): 6.1.7601
Python 2.7.12 64bit
```
## Full Traceback
File "c:\Python27\lib\site-packages\requests\api.py", line 72, in get
return request('get', url, params=params, **kwargs)
File "c:\Python27\lib\site-packages\requests\api.py", line 58, in request
return session.request(method=method, url=url, **kwargs)
File "c:\Python27\lib\site-packages\requests\sessions.py", line 518, in request
resp = self.send(prep, **send_kwargs)
File "c:\Python27\lib\site-packages\requests\sessions.py", line 639, in send
r = adapter.send(request, **kwargs)
File "c:\Python27\lib\site-packages\requests\adapters.py", line 438, in send
timeout=timeout
File "c:\Python27\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 600, in urlopen
chunked=chunked)
File "c:\Python27\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 356, in _make_request
conn.request(method, url, **httplib_request_kw)
File "c:\python27\Lib\httplib.py", line 1057,in request
self._send_request(method, url, body, headers)
File "c:\python27\Lib\httplib.py", line 1097, in _send_request
self.endheaders(body)
File "c:\python27\Lib\httplib.py",line 1053, in endheaders
self._send_output(message_body)
File "c:\python27\Lib\httplib.py", line 897, in _send_output
self.send(msg)
File "c:\python27\Lib\httplib.py", line 859,in send
self.connect()
File "c:\Python27\lib\site-packages\requests\packages\urllib3\connection.py", line 166, in connect
conn = self._new_conn()
File "c:\Python27\lib\site-packages\requests\packages\urllib3\contrib\socks.py", line 88, in _new_conn
**extra_kw
File "c:\Python27\lib\site-packages\socks.py", line 229, in create_connection
sock.connect((remote_host, remote_port))
File "c:\Python27\lib\site-packages\socks.py", line 96, in wrapper
return function(*args, **kwargs)
File "c:\Python27\lib\site-packages\socks.py", line 781, in connect
super(socksocket, self).settimeout(self._timeout)
AttributeError: 'super' object has no attribute 'settimeout'
## Extras
I want to suggest the closest issue I have found, that is on **gevent**:
https://github.com/gevent/gevent/issues/937
Replacing all occurences of (in socks.py):
`super(socksocket, self).settimeout`
with:
`self.settimeout`
solves the issue, but I don't know if there are any other side effects
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4085/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4085/timeline
| null |
completed
| null | null | false |
[
"This error comes from PySocks, not from Requests: you'll need to open your issue on [this repository](https://github.com/anorov/pysocks)."
] |
https://api.github.com/repos/psf/requests/issues/4084
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4084/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4084/comments
|
https://api.github.com/repos/psf/requests/issues/4084/events
|
https://github.com/psf/requests/pull/4084
| 231,844,750 |
MDExOlB1bGxSZXF1ZXN0MTIyNzgyNzgw
| 4,084 |
attempt circle
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-05-28T04:03:02Z
|
2021-09-06T00:06:49Z
|
2017-05-28T04:11:40Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4084/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4084/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4084.diff",
"html_url": "https://github.com/psf/requests/pull/4084",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4084.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4084"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4083
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4083/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4083/comments
|
https://api.github.com/repos/psf/requests/issues/4083/events
|
https://github.com/psf/requests/pull/4083
| 231,842,435 |
MDExOlB1bGxSZXF1ZXN0MTIyNzgxNjcy
| 4,083 |
faster ci (test)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-05-28T02:55:39Z
|
2021-09-06T00:06:50Z
|
2017-05-28T03:37:38Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4083/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4083/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4083.diff",
"html_url": "https://github.com/psf/requests/pull/4083",
"merged_at": "2017-05-28T03:37:38Z",
"patch_url": "https://github.com/psf/requests/pull/4083.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4083"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4082
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4082/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4082/comments
|
https://api.github.com/repos/psf/requests/issues/4082/events
|
https://github.com/psf/requests/pull/4082
| 231,840,737 |
MDExOlB1bGxSZXF1ZXN0MTIyNzgwNzkw
| 4,082 |
Jenkins (tesT)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-28T02:02:38Z
|
2021-09-06T00:06:49Z
|
2017-05-28T02:05:29Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4082/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4082/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4082.diff",
"html_url": "https://github.com/psf/requests/pull/4082",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4082.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4082"
}
| true |
[
"# [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4082?src=pr&el=h1) Report\n> Merging [#4082](https://codecov.io/gh/kennethreitz/requests/pull/4082?src=pr&el=desc) into [master](https://codecov.io/gh/kennethreitz/requests/commit/03944f4cd62fb906cb20eebda86b150358923564?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/kennethreitz/requests/pull/4082?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #4082 +/- ##\n=======================================\n Coverage 87.65% 87.65% \n=======================================\n Files 18 18 \n Lines 2025 2025 \n=======================================\n Hits 1775 1775 \n Misses 250 250\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4082?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4082?src=pr&el=footer). Last update [03944f4...3e5498e](https://codecov.io/gh/kennethreitz/requests/pull/4082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"
] |
|
https://api.github.com/repos/psf/requests/issues/4081
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4081/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4081/comments
|
https://api.github.com/repos/psf/requests/issues/4081/events
|
https://github.com/psf/requests/pull/4081
| 231,833,721 |
MDExOlB1bGxSZXF1ZXN0MTIyNzc3NDA4
| 4,081 |
TEST Update README.rst
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-27T23:05:01Z
|
2021-09-06T00:06:50Z
|
2017-05-28T02:05:42Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4081/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4081/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4081.diff",
"html_url": "https://github.com/psf/requests/pull/4081",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/4081.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4081"
}
| true |
[
"# [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4081?src=pr&el=h1) Report\n> Merging [#4081](https://codecov.io/gh/kennethreitz/requests/pull/4081?src=pr&el=desc) into [master](https://codecov.io/gh/kennethreitz/requests/commit/03944f4cd62fb906cb20eebda86b150358923564?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/kennethreitz/requests/pull/4081?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #4081 +/- ##\n=======================================\n Coverage 86.07% 86.07% \n=======================================\n Files 18 18 \n Lines 2025 2025 \n=======================================\n Hits 1743 1743 \n Misses 282 282\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4081?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4081?src=pr&el=footer). Last update [03944f4...6cf0962](https://codecov.io/gh/kennethreitz/requests/pull/4081?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"
] |
|
https://api.github.com/repos/psf/requests/issues/4080
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4080/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4080/comments
|
https://api.github.com/repos/psf/requests/issues/4080/events
|
https://github.com/psf/requests/issues/4080
| 231,828,458 |
MDU6SXNzdWUyMzE4Mjg0NTg=
| 4,080 |
test
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 7 |
2017-05-27T21:13:32Z
|
2021-09-08T09:00:51Z
|
2017-05-27T21:13:53Z
|
CONTRIBUTOR
|
resolved
|
Summary.
## Expected Result
What you expected.
## Actual Result
What happened instead.
## Reproduction Steps
```python
import requests
```
### System Information
$ python -m requests.help
```
{
"chardet": "3.0.3",
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "3.6.0"
},
"platform": {
"release": "16.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.16.4"
},
"system_ssl": {
"version": "100020bf"
},
"urllib3": "1.21.1",
"using_pyopenssl": false
}
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4080/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4080/timeline
| null |
completed
| null | null | false |
[
"Any reason for the inconsistency with the `urllib3` and `chardet` keys not having `version` sub-keys?",
"@SethMichaelLarson looks like those two were added after the other original definitions. Perhaps `urllib3_info = {'version': urllib3.__version__}` [here](https://github.com/kennethreitz/requests/blob/7ce5ca853db84601fe61209428085bac2b79309b/requests/help.py#L72-L73) would be more consistent, @kennethreitz?",
"Also noticed we're not saying anything about OS information/version here? Might be worthwhile.",
"@SethMichaelLarson I believe that's what the `platform` key is representing. I'm not sure if there's more specific information we can get out of the `platform` package. I haven't looked too hard though.",
"@nateprewitt Disregard me, just didn't see that field.",
"ah, good catch",
"updated :)"
] |
https://api.github.com/repos/psf/requests/issues/4079
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4079/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4079/comments
|
https://api.github.com/repos/psf/requests/issues/4079/events
|
https://github.com/psf/requests/pull/4079
| 231,827,015 |
MDExOlB1bGxSZXF1ZXN0MTIyNzc0MTE0
| 4,079 |
$ python -m requests.help
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-27T20:46:10Z
|
2021-09-06T00:06:50Z
|
2017-05-27T20:58:19Z
|
CONTRIBUTOR
|
resolved
|
Related: #3937
Example Usage:
```shell
$ python -m requests.help Sat May 27 16:43:57 2017
{
"cryptography": {
"version": ""
},
"implementation": {
"name": "CPython",
"version": "2.7.13"
},
"platform": {
"release": "16.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.16.3"
},
"system_ssl": {
"version": "100020bf"
},
"using_pyopenssl": false
}
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4079/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4079/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4079.diff",
"html_url": "https://github.com/psf/requests/pull/4079",
"merged_at": "2017-05-27T20:58:19Z",
"patch_url": "https://github.com/psf/requests/pull/4079.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4079"
}
| true |
[
"# [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=h1) Report\n> Merging [#4079](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=desc) into [master](https://codecov.io/gh/kennethreitz/requests/commit/a44284c045b43d728c2a07d4f0a064bf8714f4af?src=pr&el=desc) will **decrease** coverage by `3.81%`.\n> The diff coverage is `0%`.\n\n[](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #4079 +/- ##\n==========================================\n- Coverage 89.73% 85.92% -3.82% \n==========================================\n Files 17 18 +1 \n Lines 1978 2025 +47 \n==========================================\n- Hits 1775 1740 -35 \n- Misses 203 285 +82\n```\n\n\n| [Impacted Files](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [requests/help.py](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=tree#diff-cmVxdWVzdHMvaGVscC5weQ==) | `0% <0%> (ø)` | |\n| [requests/utils.py](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=tree#diff-cmVxdWVzdHMvdXRpbHMucHk=) | `79.25% <0%> (-7%)` | :arrow_down: |\n| [tests/testserver/\\_\\_init\\_\\_.py](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=tree#diff-dGVzdHMvdGVzdHNlcnZlci9fX2luaXRfXy5weQ==) | `79.59% <0%> (-6.13%)` | :arrow_down: |\n| [requests/sessions.py](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=tree#diff-cmVxdWVzdHMvc2Vzc2lvbnMucHk=) | `92.7% <0%> (-1.39%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=footer). Last update [a44284c...0ae8524](https://codecov.io/gh/kennethreitz/requests/pull/4079?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"
] |
https://api.github.com/repos/psf/requests/issues/4078
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4078/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4078/comments
|
https://api.github.com/repos/psf/requests/issues/4078/events
|
https://github.com/psf/requests/issues/4078
| 231,825,197 |
MDU6SXNzdWUyMzE4MjUxOTc=
| 4,078 |
GAE fails with v2.16.3 | error: required argument is not a float
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/484487?v=4",
"events_url": "https://api.github.com/users/anotherstarburst/events{/privacy}",
"followers_url": "https://api.github.com/users/anotherstarburst/followers",
"following_url": "https://api.github.com/users/anotherstarburst/following{/other_user}",
"gists_url": "https://api.github.com/users/anotherstarburst/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/anotherstarburst",
"id": 484487,
"login": "anotherstarburst",
"node_id": "MDQ6VXNlcjQ4NDQ4Nw==",
"organizations_url": "https://api.github.com/users/anotherstarburst/orgs",
"received_events_url": "https://api.github.com/users/anotherstarburst/received_events",
"repos_url": "https://api.github.com/users/anotherstarburst/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/anotherstarburst/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/anotherstarburst/subscriptions",
"type": "User",
"url": "https://api.github.com/users/anotherstarburst",
"user_view_type": "public"
}
|
[
{
"color": "fbca04",
"default": false,
"description": null,
"id": 615414998,
"name": "GAE Support",
"node_id": "MDU6TGFiZWw2MTU0MTQ5OTg=",
"url": "https://api.github.com/repos/psf/requests/labels/GAE%20Support"
}
] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
] | null | 29 |
2017-05-27T20:12:13Z
|
2021-09-08T06:00:40Z
|
2017-06-02T13:18:03Z
|
NONE
|
resolved
|
I have just installed the requests library in my appengine app following the instructions at https://cloud.google.com/appengine/docs/standard/python/issue-requests . When making the following request (within the app or within the interactive console)
```
import requests
import requests_toolbelt.adapters.appengine
# Use the App Engine Requests adapter. This makes sure that Requests uses
# URLFetch.
requests_toolbelt.adapters.appengine.monkeypatch()
r = requests.get('https://api.github.com/events')
```
I get the following error
```
> Traceback (most recent call last):
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/appengine/tools/devappserver2/python/request_handler.py", line 226, in handle_interactive_request
> exec(compiled_code, self._command_globals)
> File "<string>", line 8, in <module>
> File "/Users/developer/Desktop/myapp-web/libraries/requests/api.py", line 72, in get
> return request('get', url, params=params, **kwargs)
> File "/Users/developer/Desktop/myapp-web/libraries/requests/api.py", line 58, in request
> return session.request(method=method, url=url, **kwargs)
> File "/Users/developer/Desktop/myapp-web/libraries/requests/sessions.py", line 523, in request
> resp = self.send(prep, **send_kwargs)
> File "/Users/developer/Desktop/myapp-web/libraries/requests/sessions.py", line 643, in send
> r = adapter.send(request, **kwargs)
> File "/Users/developer/Desktop/myapp-web/libraries/requests/adapters.py", line 440, in send
> timeout=timeout
> File "/Users/developer/Desktop/myapp-web/libraries/requests_toolbelt/adapters/appengine.py", line 172, in urlopen
> **response_kw)
> File "/Users/developer/Desktop/myapp-web/libraries/urllib3/contrib/appengine.py", line 149, in urlopen
> validate_certificate=self.validate_certificate,
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/appengine/api/urlfetch.py", line 293, in fetch
> return rpc.get_result()
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/appengine/api/apiproxy_stub_map.py", line 613, in get_result
> return self.__get_result_hook(self)
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/appengine/api/urlfetch.py", line 413, in _get_fetch_result
> rpc.check_success()
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/appengine/api/apiproxy_stub_map.py", line 579, in check_success
> self.__rpc.CheckSuccess()
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/appengine/api/apiproxy_rpc.py", line 157, in _WaitImpl
> self.request, self.response)
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/appengine/ext/remote_api/remote_api_stub.py", line 206, in MakeSyncCall
> self._MakeRealSyncCall(service, call, request, response)
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/appengine/ext/remote_api/remote_api_stub.py", line 255, in _MakeRealSyncCall
> request_pb.set_request(request.Encode())
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/net/proto/ProtocolBuffer.py", line 103, in Encode
> self.Output(e)
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/net/proto/ProtocolBuffer.py", line 347, in Output
> self.OutputUnchecked(e)
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/appengine/api/urlfetch_service_pb.py", line 484, in OutputUnchecked
> out.putDouble(self.deadline_)
> File "/usr/local/y/google-cloud-sdk/platform/google_appengine/google/net/proto/ProtocolBuffer.py", line 592, in putDouble
> a.fromstring(struct.pack("<d", v))
> error: required argument is not a float
```
I have the following packages installed (along with dependencies) via pip
```
requests-2.16.3.dist-info
requests_toolbelt-0.8.0.dist-info
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4078/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4078/timeline
| null |
completed
| null | null | false |
[
"Wow, this looks like it involves a lot of GAE code here. @jonparrott any ideas?",
"Just a further comment. I did the same thing using the simple hello world app (set up as per https://cloud.google.com/appengine/docs/standard/python/quickstart ) to ensure there weren't any errors introduced by my own code. Same issue. I tested previous versions of requests, and the last version that seems to work was 2.16.1",
"I'll take a look at this first thing Tuesday when I get back in the office.\nThanks!\n\nOn Sat, May 27, 2017, 1:22 PM A <[email protected]> wrote:\n\n> Just a further comment. I did the same thing using the simple hello world\n> app (set up as per\n> https://cloud.google.com/appengine/docs/standard/python/quickstart ) to\n> ensure there weren't any errors introduced by my own code. Same issue.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kennethreitz/requests/issues/4078#issuecomment-304474528>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAPUcwCsf7nzMQ_plRUJda_YkI3tUedOks5r-IYLgaJpZM4NodTG>\n> .\n>\n",
"Hey Guys!\r\n\r\nI've spent some time investigating this issue. It's been caused by the refactoring of requests.packages in version 2.16.2. \r\n\r\n**The quick fix is to downgrade to requests 2.16.0.**\r\n\r\nWhat I've found being broken:\r\n\r\nIn `urllib3/contrib/appengine.py` at `AppEngineManager._get_absolute_timeout()` is not returning a number as expected.\r\n\r\nIt's because the Timeout class imported from urllib3.timeout is not the same as what it receives as a timeout object.\r\n\r\nI've put a couple brutal prints in the function:\r\n\r\n def _get_absolute_timeout(self, timeout):\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"0000\", self\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"timeout\", timeout\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"timeout.__class__\", timeout.__class__\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"Timeout\", Timeout\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"Timeout.DEFAULT_TIMEOUT.__class__\", Timeout.DEFAULT_TIMEOUT.__class__\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"timeout is Timeout.DEFAULT_TIMEOUT\", timeout is Timeout.DEFAULT_TIMEOUT\r\n if timeout is Timeout.DEFAULT_TIMEOUT:\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"2222\"\r\n return None # Defer to URLFetch's default.\r\n if isinstance(timeout, Timeout):\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"3333\"\r\n if timeout._read is not None or timeout._connect is not None:\r\n warnings.warn(\r\n \"URLFetch does not support granular timeout settings, \"\r\n \"reverting to total or default URLFetch timeout.\",\r\n AppEnginePlatformWarning)\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"4444\"\r\n return timeout.total\r\n print \"\\n\\n\", \"AppEngineManager._get_absolute_timeout\", \"5555\"\r\n return timeout\r\n\r\nWhen it's executed with requests 2.16.0, it gives the following output: \r\n\r\n```AppEngineManager._get_absolute_timeout 0000 <urllib3.contrib.appengine.AppEngineManager object at 0x114f7d6d0>\r\nAppEngineManager._get_absolute_timeout timeout Timeout(connect=None, read=None, total=None)\r\nAppEngineManager._get_absolute_timeout timeout.__class__ <class 'urllib3.util.timeout.Timeout'>\r\nAppEngineManager._get_absolute_timeout Timeout <class 'urllib3.util.timeout.Timeout'>\r\nAppEngineManager._get_absolute_timeout Timeout.DEFAULT_TIMEOUT.__class__ <type 'object'>\r\nAppEngineManager._get_absolute_timeout timeout is Timeout.DEFAULT_TIMEOUT False\r\nAppEngineManager._get_absolute_timeout 3333\r\nAppEngineManager._get_absolute_timeout 4444\r\n```\r\n\r\nIt works as expected, returns an integer number.\r\n\r\nBut when it's executed with requests>=2.16.2, the same code returns:\r\n```\r\nAppEngineManager._get_absolute_timeout 0000 <requests.packages.urllib3.contrib.appengine.AppEngineManager object at 0x10df5a1d0>\r\nAppEngineManager._get_absolute_timeout timeout Timeout(connect=None, read=None, total=None)\r\nAppEngineManager._get_absolute_timeout timeout.__class__ <class 'urllib3.util.timeout.Timeout'>\r\nAppEngineManager._get_absolute_timeout Timeout <class 'requests.packages.urllib3.util.timeout.Timeout'>\r\nAppEngineManager._get_absolute_timeout Timeout.DEFAULT_TIMEOUT.__class__ <type 'object'>\r\nAppEngineManager._get_absolute_timeout timeout is Timeout.DEFAULT_TIMEOUT False\r\nAppEngineManager._get_absolute_timeout 5555\r\n```\r\n\r\nAs you can see the **timeout argument's class is != the Timeout class it's being compared to**. Because of this `isinstance(timeout, Timeout):` returns `False`, so the function **returns the timeout object instead of the integer value of the timeout**.\r\n\r\nI'm not sure where to fix this, but I hope these findings will help.\r\n",
"Hrm, this looks very similar to #4096. Can you both try creating clean virtual environments and installing the newest release of Requests to see if the problem persists?",
"I've recreated the whole virtualenv from scratch. The problem persist with Request 2.16.5.\r\n\r\nIt's happening when it's used under google app engine with the adaptor from requests-toolbelt package. \r\n\r\nThe actual code that breaks is in urllib3 package, as per my previous comment.\r\n\r\nHowever, I believe the reason why it's breaking is related to the hack in the requests/packages.py file\r\n\r\nHere is the full call-stack for an example of a breaking HTTPS request:\r\n\r\n```self.request('PATCH', url, data=data, **kwargs)\r\n File \"/Volumes/Data/Documents/Ride/repos/rideapp/virtualenv/lib/python2.7/site-packages/requests/sessions.py\", line 523, in request\r\n resp = self.send(prep, **send_kwargs)\r\n File \"/Volumes/Data/Documents/Ride/repos/rideapp/virtualenv/lib/python2.7/site-packages/requests/sessions.py\", line 643, in send\r\n r = adapter.send(request, **kwargs)\r\n File \"/Volumes/Data/Documents/Ride/repos/rideapp/virtualenv/lib/python2.7/site-packages/requests/adapters.py\", line 440, in send\r\n timeout=timeout\r\n File \"/Volumes/Data/Documents/Ride/repos/rideapp/virtualenv/lib/python2.7/site-packages/requests_toolbelt/adapters/appengine.py\", line 172, in urlopen\r\n **response_kw)\r\n File \"/Volumes/Data/Documents/Ride/repos/rideapp/virtualenv/lib/python2.7/site-packages/urllib3/contrib/appengine.py\", line 149, in urlopen\r\n validate_certificate=self.validate_certificate,\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/appengine/api/urlfetch.py\", line 293, in fetch\r\n return rpc.get_result()\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/appengine/api/apiproxy_stub_map.py\", line 613, in get_result\r\n return self.__get_result_hook(self)\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/appengine/api/urlfetch.py\", line 413, in _get_fetch_result\r\n rpc.check_success()\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/appengine/api/apiproxy_stub_map.py\", line 579, in check_success\r\n self.__rpc.CheckSuccess()\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/appengine/api/apiproxy_rpc.py\", line 157, in _WaitImpl\r\n self.request, self.response)\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/appengine/ext/remote_api/remote_api_stub.py\", line 206, in MakeSyncCall\r\n self._MakeRealSyncCall(service, call, request, response)\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/appengine/ext/remote_api/remote_api_stub.py\", line 255, in _MakeRealSyncCall\r\n request_pb.set_request(request.Encode())\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/net/proto/ProtocolBuffer.py\", line 103, in Encode\r\n self.Output(e)\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/net/proto/ProtocolBuffer.py\", line 347, in Output\r\n self.OutputUnchecked(e)\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/appengine/api/urlfetch_service_pb.py\", line 484, in OutputUnchecked\r\n out.putDouble(self.deadline_)\r\n File \"/Users/dana/Downloads/google-cloud-sdk/platform/google_appengine/google/net/proto/ProtocolBuffer.py\", line 592, in putDouble\r\n a.fromstring(struct.pack(\"<d\", v))\r\nerror: required argument is not a float\r\n",
"@neonihil Do the problems with identity persist though?",
"@Lukasa Yes it does. \r\n\r\nWhat happens is that in `lib/python2.7/site-packages/urllib3/contrib/appengine.py` there is: AppEngineManager.urlopen, which has the following block:\r\n\r\n```\r\n response = urlfetch.fetch(\r\n url,\r\n payload=body,\r\n method=method,\r\n headers=headers or {},\r\n allow_truncated=False,\r\n follow_redirects=self.urlfetch_retries and follow_redirects,\r\n deadline=self._get_absolute_timeout(timeout),\r\n validate_certificate=self.validate_certificate,\r\n )\r\n```\r\n\r\nThe problem is that `self._get_absolute_timeout(timeout)` returns a `urllib3.utils.Timeout` object instead of an `int`. **This is the breaking call.**\r\n\r\nIt returns a `Timeout` object is because in `_get_absolute_timeout(timeout)` the following `isinstance()` call returns `False`: `if isinstance(timeout, Timeout):` \r\n\r\nThe module `lib/python2.7/site-packages/urllib3/contrib/appengine.py` is importing the `Timeout` object with the following statement: `from ..util.timeout import Timeout`. \r\n\r\nInterestingly, the imported class is `<class 'requests.packages.urllib3.util.timeout.Timeout'>`. That is different from what `_get_absolute_timeout(timeout)` receives as the `timeout` argument. It's receiving `<class 'urllib3.util.timeout.Timeout'>`.\r\n\r\nIt's not a typo, it's really this way. I've confirmed it with the prints in my previous comment.\r\n\r\n\r\n\r\n\r\n\r\n\r\n",
"I appreciate that you confirmed it, but I wanted to try to confirm it again with the clean virtualenv. A very similar problem appeared elsewhere that I cannot reproduce with the current master, and I was wondering if any holdovers from the old installation may be affecting this. ",
"So my new theory is that the grafting done in 2.16.2 only works for anything imported as part of `import urllib3`. This will *not* include contrib modules, so they get their namespaces messed up when they eventually are imported. ",
"I've re-created the virtualenv from scratch, starting with `rm -rf virtualenv`.",
"Yeah, so I think that @kennethreitz has some work to do to ensure that the contrib modules are *also* imported and grafted into the namespace, if possible. ",
"This work had been done to support downstream redistributor unvendoring but I don't know what broke that. What @kennethreitz needs to do is go back to an older version of `requests/packages/__init__.py` to clean this up and see what was being done there. This was a fixed issue for downstream redistributor unvendoring.",
"@sigmavirus24 our code now is almost identical to the code we were using there, but i'll double check. ",
"The entirety of our old `__init__.py` was as follows:\r\n\r\n```python\r\nfrom __future__ import absolute_import\r\nimport sys\r\n\r\ntry:\r\n from . import urllib3\r\nexcept ImportError:\r\n import urllib3\r\n sys.modules['%s.urllib3' % __name__] = urllib3\r\n\r\ntry:\r\n from . import chardet\r\nexcept ImportError:\r\n import chardet\r\n sys.modules['%s.chardet' % __name__] = chardet\r\n```\r\n\r\nWhat we're doing now is identical, save for the `__name__` stuff. ",
"It's quite possible that the fallback code never worked either; and we didn't notice because the people who used the contrib modules never used the distribution-unbundled code ",
"I know how to make it work, it's just a matter of identifying all the un-imported namespaces in the urllib3 codebase.",
"I'll start with contrib.",
"Here's a report of the monkeypatching not working with Requests v2.14.2 https://github.com/sigmavirus24/requests-toolbelt/issues/184. Related?",
"@kennethreitz: Have been watching this issue today (thanks for collecting info here).\r\n\r\nWe have 2.14.2 working fine on our end with `requests_toolbelt` on GAE Standard. We hit this issue this morning on new CI builds, and pinned to 2.14.2 to solve it (after reading what you found out).\r\n\r\nI believe the issue at sigmavirus24/requests-toolbelt#184 is specifically because the user was vendoring in a separate (un-patched) copy of the code in a different import path after the monkey patching took place. So, probably un-related.",
"@bsmithyman can you try 2.17.3?",
"@kennethreitz: Can do; will hit it first thing in the morning (EDT) with one of our build servers. Setting a reminder for myself now.",
"Testing looks pretty solid so far with 2.17.3. Definitely we aren't hitting the same issue as before. We are using the global monkey patching in `requests_toolbelt`. Confirmed that it's working both with our own code and with vendored libraries that don't know about GAE (e.g., `braintree`). This is on App Engine Standard.",
"@bsmithyman excellent news!",
"Oh, good deal. I'm glad this wasn't my fault for once! :D",
"You guys are freaking awesome! Thanks for looking at this!",
"🍰 Closing this",
"This issue happened again for 2.18. I used 2.17.3 instead per the comment above. ",
"@robincrlee if this has regressed, please open a new issue with more detail than you've already provided."
] |
https://api.github.com/repos/psf/requests/issues/4077
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4077/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4077/comments
|
https://api.github.com/repos/psf/requests/issues/4077/events
|
https://github.com/psf/requests/issues/4077
| 231,810,789 |
MDU6SXNzdWUyMzE4MTA3ODk=
| 4,077 |
UnicodeDecodeError when trying to install requests on Windows (using Appveyor)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1405370?v=4",
"events_url": "https://api.github.com/users/ErikBjare/events{/privacy}",
"followers_url": "https://api.github.com/users/ErikBjare/followers",
"following_url": "https://api.github.com/users/ErikBjare/following{/other_user}",
"gists_url": "https://api.github.com/users/ErikBjare/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ErikBjare",
"id": 1405370,
"login": "ErikBjare",
"node_id": "MDQ6VXNlcjE0MDUzNzA=",
"organizations_url": "https://api.github.com/users/ErikBjare/orgs",
"received_events_url": "https://api.github.com/users/ErikBjare/received_events",
"repos_url": "https://api.github.com/users/ErikBjare/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ErikBjare/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ErikBjare/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ErikBjare",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 12 |
2017-05-27T16:05:54Z
|
2021-09-08T09:00:40Z
|
2017-06-05T13:37:08Z
|
NONE
|
resolved
|
**Version:** 2.16.1
Works fine on [Linux and macOS](https://travis-ci.org/ActivityWatch/activitywatch/builds/236669653).
Has also worked on Windows [in the past (2.14.1)](https://ci.appveyor.com/project/ErikBjare/activitywatch/build/1.0.144/job/5c46bk2929htjn2r).
I'll be attempting a installation of requests 2.14.1 specifically to see if there has indeed been any regression, the [build is here](https://ci.appveyor.com/project/ErikBjare/activitywatch/build/1.0.152/job/fwm5saa4mm0dso5d).
The related issue in my repo: https://github.com/ActivityWatch/activitywatch/issues/52
<details>
<summary>Stacktrace</summary>
```
Searching for requests
Reading https://pypi.python.org/simple/requests/
Downloading https://pypi.python.org/packages/4c/54/1d3abddbd4c7544138b88e8329ef5294ffdc6c5d7ea965bf42e3cc4c9c39/requests-2.16.1.tar.gz#md5=4acb351824461eb3ae1f74ec3a65ff28
Best match: requests 2.16.1
Processing requests-2.16.1.tar.gz
Writing C:\Users\appveyor\AppData\Local\Temp\1\easy_install-qoyp00fn\requests-2.16.1\setup.cfg
Running requests-2.16.1\setup.py -q bdist_egg --dist-dir C:\Users\appveyor\AppData\Local\Temp\1\easy_install-qoyp00fn\requests-2.16.1\egg-dist-tmp-rqjnti7r
Traceback (most recent call last):
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 157, in save_modules
yield saved
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 198, in setup_context
yield
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 255, in run_setup
DirectorySandbox(setup_dir).run(runner)
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 285, in run
return func()
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 253, in runner
_execfile(setup_script, ns)
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 47, in _execfile
exec(code, globals, locals)
File "C:\Users\appveyor\AppData\Local\Temp\1\easy_install-qoyp00fn\requests-2.16.1\setup.py", line 51, in <module>
File "C:\Python35\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8d in position 441: character maps to <undefined>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "setup.py", line 18, in <module>
'https://github.com/ActivityWatch/aw-core/tarball/master#egg=aw-core'
File "C:\Python35\lib\distutils\core.py", line 148, in setup
dist.run_commands()
File "C:\Python35\lib\distutils\dist.py", line 955, in run_commands
self.run_command(cmd)
File "C:\Python35\lib\distutils\dist.py", line 974, in run_command
cmd_obj.run()
File "C:\Python35\lib\site-packages\setuptools\command\install.py", line 67, in run
self.do_egg_install()
File "C:\Python35\lib\site-packages\setuptools\command\install.py", line 117, in do_egg_install
cmd.run()
File "C:\Python35\lib\site-packages\setuptools\command\easy_install.py", line 411, in run
self.easy_install(spec, not self.no_deps)
File "C:\Python35\lib\site-packages\setuptools\command\easy_install.py", line 654, in easy_install
return self.install_item(None, spec, tmpdir, deps, True)
File "C:\Python35\lib\site-packages\setuptools\command\easy_install.py", line 701, in install_item
self.process_distribution(spec, dist, deps)
File "C:\Python35\lib\site-packages\setuptools\command\easy_install.py", line 746, in process_distribution
[requirement], self.local_index, self.easy_install
File "C:\Python35\lib\site-packages\pkg_resources\__init__.py", line 851, in resolve
dist = best[req.key] = env.best_match(req, ws, installer)
File "C:\Python35\lib\site-packages\pkg_resources\__init__.py", line 1123, in best_match
return self.obtain(req, installer)
File "C:\Python35\lib\site-packages\pkg_resources\__init__.py", line 1135, in obtain
return installer(requirement)
File "C:\Python35\lib\site-packages\setuptools\command\easy_install.py", line 673, in easy_install
return self.install_item(spec, dist.location, tmpdir, deps)
File "C:\Python35\lib\site-packages\setuptools\command\easy_install.py", line 699, in install_item
dists = self.install_eggs(spec, download, tmpdir)
File "C:\Python35\lib\site-packages\setuptools\command\easy_install.py", line 880, in install_eggs
return self.build_and_install(setup_script, setup_base)
File "C:\Python35\lib\site-packages\setuptools\command\easy_install.py", line 1119, in build_and_install
self.run_setup(setup_script, setup_base, args)
File "C:\Python35\lib\site-packages\setuptools\command\easy_install.py", line 1105, in run_setup
run_setup(setup_script, args)
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 258, in run_setup
raise
File "C:\Python35\lib\contextlib.py", line 77, in __exit__
self.gen.throw(type, value, traceback)
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 198, in setup_context
yield
File "C:\Python35\lib\contextlib.py", line 77, in __exit__
self.gen.throw(type, value, traceback)
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 169, in save_modules
saved_exc.resume()
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 144, in resume
six.reraise(type, exc, self._tb)
File "C:\Python35\lib\site-packages\six.py", line 685, in reraise
raise value.with_traceback(tb)
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 157, in save_modules
yield saved
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 198, in setup_context
yield
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 255, in run_setup
DirectorySandbox(setup_dir).run(runner)
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 285, in run
return func()
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 253, in runner
_execfile(setup_script, ns)
File "C:\Python35\lib\site-packages\setuptools\sandbox.py", line 47, in _execfile
exec(code, globals, locals)
File "C:\Users\appveyor\AppData\Local\Temp\1\easy_install-qoyp00fn\requests-2.16.1\setup.py", line 51, in <module>
File "C:\Python35\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8d in position 441: character maps to <undefined>
```
</details>
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4077/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4077/timeline
| null |
completed
| null | null | false |
[
"The build has now progressed beyond the place where it erred previously, so 2.14.1 seems to work fine.",
"I think the fix from f3d310b299af587d668493f09d82c84c197d00fd needs to be adapted to the change in 3e32356716572e59c9f10c6c2622bedf5f48b07e.",
"@tdsmith we no longer load that file that way any longer. ",
"https://github.com/kennethreitz/requests/blob/master/setup.py#L50-L51 appears to still be loading a file with some unicode in it.",
"Unfortunately, \"You can't use a PEP 263 declaration in Unicode text passed to exec\". It results in a SyntaxError. `SyntaxError: encoding declaration in Unicode string`. Quite frustrating. ",
"I'll see if I can drop the PEP 263 declaration and have things still work alright on most systems. ",
"Does anyone have the unicode literals for these emojis? ✨🍰✨ :P",
"It looks like you can pass bytes to exec() in 3.6; maybe opening the file in binary mode with the PEP 263 declaration intact is good?\r\n\r\nAlso '\\u2728\\U0001f370\\u2728' I think",
"@tdsmith lifesaver!",
"I'm going to try passing it as unicode and see if that fixes up things for appveyor over here",
"k, changes landed in master for this. not sure if they'll actually effect anything, but... ",
"No further reports of this being an issue, so I'm going to close this until we hear otherwise."
] |
https://api.github.com/repos/psf/requests/issues/4076
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4076/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4076/comments
|
https://api.github.com/repos/psf/requests/issues/4076/events
|
https://github.com/psf/requests/issues/4076
| 231,805,805 |
MDU6SXNzdWUyMzE4MDU4MDU=
| 4,076 |
ValueError: not enough values to unpack (expected 3, got 1)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/25952165?v=4",
"events_url": "https://api.github.com/users/Javinator9889/events{/privacy}",
"followers_url": "https://api.github.com/users/Javinator9889/followers",
"following_url": "https://api.github.com/users/Javinator9889/following{/other_user}",
"gists_url": "https://api.github.com/users/Javinator9889/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Javinator9889",
"id": 25952165,
"login": "Javinator9889",
"node_id": "MDQ6VXNlcjI1OTUyMTY1",
"organizations_url": "https://api.github.com/users/Javinator9889/orgs",
"received_events_url": "https://api.github.com/users/Javinator9889/received_events",
"repos_url": "https://api.github.com/users/Javinator9889/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Javinator9889/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Javinator9889/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Javinator9889",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 38 |
2017-05-27T14:47:31Z
|
2021-09-08T09:00:36Z
|
2017-05-27T15:22:56Z
|
NONE
|
resolved
|
When using requests, I've just upgraded and I'm having the following error:
`import requests as rq`
`File "C:\Users\_HOME_\AppData\Local\Programs\Python\Python36\lib\site-packages\requests\__init__.py", line 53, in <module>`
`major, minor, patch= urllib3_version`
`ValueError: not enough values to unpack (expected 3, got 1)`
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4076/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4076/timeline
| null |
completed
| null | null | false |
[
"can you give me the output of `pip freeze`?",
"I would like to know the answer to this, but the solution to this problem should be:\r\n\r\n $ pip install --upgrade requests",
"```\r\nappdirs==1.4.3\r\nbeautifulsoup4==4.6.0\r\ncachetools==2.0.0\r\ncertifi==2017.4.17\r\ncffi==1.10.0\r\nchardet==3.0.3\r\nclick==6.7\r\ncolorclass==2.2.0\r\ndecorator==4.0.11\r\ndocopt==0.6.2\r\nenum-compat==0.0.2\r\nenum34==1.1.6\r\neventlet==0.21.0\r\nfirst==2.0.1\r\nfuture==0.16.0\r\ngmusicapi==10.1.2\r\ngnp==0.0.4\r\ngoogle-assistant-sdk==0.3.1\r\ngoogle-auth==1.0.1\r\ngoogle-auth-oauthlib==0.1.0\r\ngoogle-search==1.0.2\r\ngoogleapis-common-protos==1.5.2\r\ngpsoauth==0.4.1\r\ngreenlet==0.4.12\r\ngrpcio==1.3.5\r\nhtml5lib==0.999999999\r\nhttplib2==0.10.3\r\nidna==2.5\r\ninterruptingcow==0.6\r\nisodate==0.5.4\r\nlxml==3.7.3\r\nMechanicalSoup==0.7.0\r\nmock==2.0.0\r\nmutagen==1.37\r\noauth2client==4.1.0\r\noauthlib==2.0.2\r\npackaging==16.8\r\npafy==0.5.3.1\r\npbr==3.0.1\r\npip-tools==1.9.0\r\npip-upgrader==1.4.0\r\nproboscis==1.2.6.0\r\nprotobuf==3.3.0\r\npy-GSearch-API==1.31\r\npy-web-search==0.2.4\r\npyasn1==0.2.3\r\npyasn1-modules==0.0.8\r\npycparser==2.17\r\npycryptodomex==3.4.6\r\npydub==0.19.0\r\nPyMySQL==0.7.11\r\npyparsing==2.2.0\r\npython-dateutil==2.6.0\r\npython-telegram-bot==6.0.1\r\npytz==2017.2\r\nrequests==2.14.1\r\nrequests-oauthlib==0.8.0\r\nrsa==3.4.2\r\nschedule==0.4.2\r\nsix==1.10.0\r\nsounddevice==0.3.7\r\nstevedore==1.21.0\r\ntelegram==0.0.1\r\nterminaltables==3.1.0\r\nujson==1.35\r\nUnidecode==0.4.20\r\nurllib3==1.21.1\r\nvalidictory==1.1.1\r\nvirtualenv==15.1.0\r\nvirtualenv-clone==0.2.6\r\nvirtualenvwrapper==4.7.2\r\nwebencodings==0.5.1\r\nyoutube-dl==2017.5.26\r\n```\r\n\r\nI have just downgraded requests and it's working (it fails with requests 2.16.1)",
"can you try `$ pip install --upgrade requests`?",
"```C:\\Users\\HOME\\PycharmProjects\\NewsBot>pip install --upgrade requests\r\nCollecting requests\r\n Downloading requests-2.16.2-py2.py3-none-any.whl (86kB)\r\n 100% |████████████████████████████████| 92kB 566kB/s\r\nRequirement already up-to-date: idna<2.6,>=2.5 in c:\\users\\javier alonso silva\\appdata\\local\\programs\\python\\python36\\lib\\site-packages (from requests)\r\nRequirement already up-to-date: certifi>=2017.4.17 in c:\\users\\javier alonso silva\\appdata\\local\\programs\\python\\python36\\lib\\site-packages (from requests)\r\nRequirement already up-to-date: urllib3<1.22,>=1.21.1 in c:\\users\\javier alonso silva\\appdata\\local\\programs\\python\\python36\\lib\\site-packages (from requests)\r\nRequirement already up-to-date: chardet<3.1.0,>=3.0.2 in c:\\users\\javier alonso silva\\appdata\\local\\programs\\python\\python36\\lib\\site-packages (from requests)\r\nInstalling collected packages: requests\r\n Found existing installation: requests 2.14.1\r\n Uninstalling requests-2.14.1:\r\n Successfully uninstalled requests-2.14.1\r\nSuccessfully installed requests-2.16.2_\r\n\r\n_C:\\Users\\HOME\\PycharmProjects\\NewsBot>python bot.py\r\nTraceback (most recent call last):\r\n File \"bot.py\", line 6, in <module>\r\n import functions.start_handler as st\r\n File \"C:\\Users\\HOME\\PycharmProjects\\NewsBot\\functions\\start_handler.py\", line 3, in <module>\r\n import functions.look_for_news as lfn\r\n File \"C:\\Users\\HOME\\PycharmProjects\\NewsBot\\functions\\look_for_news.py\", line 4, in <module>\r\n import gsearch\r\n File \"C:\\Users\\HOME\\AppData\\Local\\Programs\\Python\\Python36\\lib\\site-packages\\gsearch\\__init__._py\", line 1, in <module>\r\n from gsearch.gsearch import search\r\n File \"C:\\Users\\HOME\\AppData\\Local\\Programs\\Python\\Python36\\lib\\site-packages\\gsearch\\gsearch.py\", line 2, in <module>\r\n import requests as rq\r\n File \"C:\\Users\\HOME\\AppData\\Local\\Programs\\Python\\Python36\\lib\\site-packages\\requests\\__init__._py\", line 53, in <module>\r\n major, minor, patch= urllib3_version\r\nValueError: not enough values to unpack (expected 3, got 1)\r\n```\r\n\r\nNope, it's not working...",
"can you run the following code for me?\r\n\r\n```pycon\r\n>>> import urllib3\r\n>>> urllib3.__version__\r\n```\r\n\r\nand tell me what that string is?",
"`Python 3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 18:41:36) [MSC v.1900 64 bit (AMD64)] on win32`\r\n`Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.`\r\n`>>> import urllib3`\r\n`>>> urllib3.__version__`\r\n`'1.21.1'`\r\n`exit()`",
"well, i can confidently say i cannot reproduce. ",
"Don't mind :)\r\nrequests 2.14.1 is working fine for me\r\nMaybe is because Windows",
"shouldn't be. i have a windows machine i can test against though, just in case.\r\n\r\nDo you, by chance, have a file in your project called `urllib3.py`?",
"well, thanks for opening this issue. very strange behavior. \r\n\r\nI'm going to close this for now, and see if any one else runs into this. if it's a problem, i'm sure it'll come up rather quickly. ",
"I was talking to more people and seem to be the same problem with `urllib3`",
"This issue happens if you have development (git) version of urllib3 installed.\r\n```\r\n>>> import urllib3\r\n>>> print urllib3.__version__.split('.')\r\n['dev']\r\n>>> print urllib3.__version__\r\ndev\r\n```\r\n\r\nMaybe add a check for \"dev\" and assume it's 1.21.1 or higher?",
"Want to send a pull request?",
"After thinking about it - now I don't think that adding a hack for \"dev\" urllib3 version is goog idea, \r\nif urllib3 api changes it could lead to problems in requests, those (like me) who use git stuff shouldn't have problem hacking version string in urllib3/__init__.py . \r\nSorry for the noise.",
"Hi, having the same error, it just won't work on heroku\r\n\r\nlatest version of urllib3 - `1.2.1` \r\n\r\n```\r\n2017-06-08T12:17:41.764078+00:00 app[process.1]: import requests\r\n2017-06-08T12:17:41.764079+00:00 app[process.1]: File \"/app/.heroku/python/lib/python2.7/site-packages/requests/init.py\", line 53, in \r\n2017-06-08T12:17:41.764116+00:00 app[process.1]: major, minor, patch = urllib3_version\r\n2017-06-08T12:17:41.764149+00:00 app[process.1]: ValueError: need more than 1 value to unpack\r\n```\r\n\r\nRequests library\r\n\r\n```\r\n~ $ pip install --upgrade requests\r\nRequirement already up-to-date: requests in ./.heroku/python/lib/python2.7/site-packages\r\nRequirement already up-to-date: chardet<3.1.0,>=3.0.2 in ./.heroku/python/lib/python2.7/site-packages (from requests)\r\nRequirement already up-to-date: certifi>=2017.4.17 in ./.heroku/python/lib/python2.7/site-packages (from requests)\r\nRequirement already up-to-date: urllib3<1.22,>=1.21.1 in ./.heroku/python/lib/python2.7/site-packages (from requests)\r\nRequirement already up-to-date: idna<2.6,>=2.5 in ./.heroku/python/lib/python2.7/site-packages (from requests)\r\n\r\n```\r\n",
"Please upgrade your Requests.",
"@Lukasa done, please see edited comment",
"oh wow :( This is the exact same error output i have, can't `import requests`",
"What does your requirements file look like? How are you getting urllib3?",
"Wasn't this an issue with the version in urllib3 being the string \"dev\"? Are you installing urllib3 from git or a distribution repository?",
"@nateprewitt @Lukasa the version in urllib3 is the string \"1.2.1\" but i've narrowed down replicating the problem in my case,\r\n\r\ni'm using python-telegram-bot -> `pip install python-telegram-bot`\r\nurllib3 & requests are installed with pip\r\n\r\n\r\n**This is where the issue is replicated**\r\n\r\n```\r\nfrom telegram.ext import Updater\r\nimport requests\r\n```\r\n\r\n```\r\n2017-06-08T14:39:18.555808+00:00 app[process.1]: File \"test_app.py\", line 6, in <module>\r\n2017-06-08T14:39:18.555847+00:00 app[process.1]: import requests\r\n2017-06-08T14:39:18.555871+00:00 app[process.1]: File \"/app/.heroku/python/lib/python2.7/site-packages/requests/__init__.py\", line 53, in <module>\r\n2017-06-08T14:39:18.555916+00:00 app[process.1]: major, minor, patch = urllib3_version\r\n2017-06-08T14:39:18.556018+00:00 app[process.1]: ValueError: need more than 1 value to unpack\r\n```\r\n",
"Sorry, to clarify, but `urllib3.__version__` is the string \"1.2.1\"?",
"@lukasa yes, that's correct",
"Well, apropos of nothing, but that will not work: Requests does not support urllib3 v1.2.1. However, that raises a very real question about what's going on. Can you run under pdb and use it to work out what the value of `urllib3_version` is at the time of the exception?",
"@lukasa the `urllib3_version` variable has the value `['dev']` in this case",
"@Samuel1123 Ok, so that doesn't entirely square with your position that `urllib3.__version__` is \"1.2.1\". This sounds like you are testing in a different environment to the one that you're hitting the problem in. Regardless, that makes this a duplicate of this bug: right now Requests does not support having a urllib3 installed directly from the master branch on GitHub.",
"@Lukasa \r\nWhen i do \r\n```\r\nimport requests\r\nprint urllib3.__version__\r\n```\r\n\r\nit is 1.2.1",
"@Samuel1123 Those two lines of code aren't going to execute. They will throw a `NameError`.",
"`pip install requests --upgrade`\r\n\r\nSorry @Lukasa \r\n```\r\nimport requests.packages.urllib3 as urllib3\r\nurllib3.__version__\r\n```\r\noutputs - `1.2.1`"
] |
https://api.github.com/repos/psf/requests/issues/4075
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4075/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4075/comments
|
https://api.github.com/repos/psf/requests/issues/4075/events
|
https://github.com/psf/requests/issues/4075
| 231,801,653 |
MDU6SXNzdWUyMzE4MDE2NTM=
| 4,075 |
error after upgrading from 2.14.2 to 2.16.0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/131535?v=4",
"events_url": "https://api.github.com/users/pierrre/events{/privacy}",
"followers_url": "https://api.github.com/users/pierrre/followers",
"following_url": "https://api.github.com/users/pierrre/following{/other_user}",
"gists_url": "https://api.github.com/users/pierrre/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pierrre",
"id": 131535,
"login": "pierrre",
"node_id": "MDQ6VXNlcjEzMTUzNQ==",
"organizations_url": "https://api.github.com/users/pierrre/orgs",
"received_events_url": "https://api.github.com/users/pierrre/received_events",
"repos_url": "https://api.github.com/users/pierrre/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pierrre/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pierrre/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pierrre",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2017-05-27T13:34:53Z
|
2021-09-08T10:00:36Z
|
2017-05-27T13:44:39Z
|
NONE
|
resolved
|
(I'm not a Python dev, I don't even know what this project does)
I have an automated Travis CI build that requires `ansible-tower-cli`.
I install it with `pip install --user ansible-tower-cli`.
It began to fail recently:
```
$ tower-cli --help
Traceback (most recent call last):
File "/home/travis/.local/bin/tower-cli", line 90, in <module>
cli()
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 722, in __call__
return self.main(*args, **kwargs)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 696, in main
with self.make_context(prog_name, args, **extra) as ctx:
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 621, in make_context
self.parse_args(ctx, args)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 1018, in parse_args
rest = Command.parse_args(self, ctx, args)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 880, in parse_args
value, args = param.handle_parse_result(ctx, opts, args)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 1404, in handle_parse_result
self.callback, ctx, self, value)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 78, in invoke_param_callback
return callback(ctx, param, value)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 809, in show_help
echo(ctx.get_help(), color=ctx.color)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 496, in get_help
return self.command.get_help(self)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 830, in get_help
self.format_help(ctx, formatter)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 845, in format_help
self.format_options(ctx, formatter)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 956, in format_options
self.format_commands(ctx, formatter)
File "/home/travis/.local/lib/python2.7/site-packages/click/core.py", line 1000, in format_commands
for subcommand in self.list_commands(ctx):
File "/home/travis/.local/bin/tower-cli", line 46, in list_commands
res = tower_cli.get_resource(filename[:-3])
File "/home/travis/.local/lib/python2.7/site-packages/tower_cli/__init__.py", line 32, in get_resource
module = importlib.import_module('tower_cli.resources.%s' % name)
File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
__import__(name)
File "/home/travis/.local/lib/python2.7/site-packages/tower_cli/resources/user.py", line 16, in <module>
from tower_cli import models
File "/home/travis/.local/lib/python2.7/site-packages/tower_cli/models/__init__.py", line 20, in <module>
from tower_cli.models.base import Resource, MonitorableResource, ExeResource, \
File "/home/travis/.local/lib/python2.7/site-packages/tower_cli/models/base.py", line 36, in <module>
from tower_cli.api import client
File "/home/travis/.local/lib/python2.7/site-packages/tower_cli/api.py", line 25, in <module>
from requests.packages import urllib3
ImportError: No module named packages
```
It looks like this issues is caused by the recent `requests` update.
`ansible-tower-cli` requires `requests>=2.3.0`.
Previously it was installing `2.14.2`, now it's installing `2.16.0`.
If I force the `request` version with `pip install --user requests==2.14.2`
it works.
Is this issue related to all the other recent issue ?
Thanks
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4075/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4075/timeline
| null |
completed
| null | null | false |
[
"this is now fixed in the master branch",
"Related: #4073",
"2.16.1 released, which fixes this. ",
"thank you very much for your quick reply ! 👍 "
] |
https://api.github.com/repos/psf/requests/issues/4074
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4074/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4074/comments
|
https://api.github.com/repos/psf/requests/issues/4074/events
|
https://github.com/psf/requests/issues/4074
| 231,801,207 |
MDU6SXNzdWUyMzE4MDEyMDc=
| 4,074 |
urllib3 can report only only "16.1" instead of "16.1.0"
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
] | null | 1 |
2017-05-27T13:27:35Z
|
2021-09-08T10:00:36Z
|
2017-05-27T13:45:36Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4074/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4074/timeline
| null |
completed
| null | null | false |
[
"fixed!"
] |
|
https://api.github.com/repos/psf/requests/issues/4073
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4073/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4073/comments
|
https://api.github.com/repos/psf/requests/issues/4073/events
|
https://github.com/psf/requests/issues/4073
| 231,801,177 |
MDU6SXNzdWUyMzE4MDExNzc=
| 4,073 |
Restore "packages" namespace for backwards compatibility
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 21 |
2017-05-27T13:26:57Z
|
2021-09-08T09:00:52Z
|
2017-05-27T14:54:57Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4073/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4073/timeline
| null |
completed
| null | null | false |
[
"shipped. ",
"I'm afraid this doesn't resolve the problem with many libraries, such as the official Dropbox and Keen clients, which do\r\n\r\n`from requests.packages.urllib3.poolmanager import PoolManager`\r\n\r\nThis results in the following error:\r\n\r\n`ModuleNotFoundError: No module named 'requests.packages.urllib3'; 'requests.packages' is not a package`\r\n",
"I'm trying to find a solution for them too @raicheff. I'm open to suggestions. \r\n\r\nCurrently, code that was written to import against the `requests.packages` namespace previously will have to import code that rests at this module-level now.\r\n\r\nFor example:\r\n\r\n from requests.packages.urllib3.poolmanager import PoolManager\r\n\r\nWill need to be re-written to be:\r\n\r\n from requests.packages import urllib3\r\n urllib3.poolmanager.PoolManager\r\n\r\nOr, even better:\r\n\r\n from urllib3.poolmanager import PoolManager",
"If we really want backwards compatibility, we may have to stub out the whole library as an empty imported package. I'm willing to do that, if needed. ",
"solution found!",
"https://github.com/kennethreitz/requests/commit/c952e9e4e07ebaf579aaf8924ff6f7c61710c8c8",
"@raicheff care to test against master and see if that solves the issue for you, for the next release?",
"@kennethreitz Yes, just tested it and it works!",
"\\o/ ",
"will cut a release shortly",
"Thanks Kenneth, that's awesome!\r\n\r\nThis solution is ugly is hell, but I guess it will do the job for now. I would suggest you add a deprecation warning on import of these modules (similar to how Flask does it with the `ext` package), and remove the shimmed packages in the next major release.",
"I came up with a much better solution. ",
"https://github.com/kennethreitz/requests/commit/28666e5d3ae04fede9a9078aba937b0ce6380adc",
"going to cut a release",
"shipped 2.16.2!",
"Tested – works!",
"With 2.16.2, coala's core tests are down to only one error, in an emulated read timeout test.\r\nhttps://circleci.com/gh/jayvdb/coala/296\r\nWe still have a few other issues which have strangely popped up, and probably some version conflicts for `chardet`. Still investigating.",
"@jayvdb keep us up to date!",
"@kennethreitz , I haven't found the cause of https://github.com/coala/coala/issues/4282 (and it is 3am so I'm off) , but the workaround was simple : https://github.com/coala/coala/pull/4283\r\n",
"excellent @jayvdb!",
"@kennethreitz , my workaround shows there is a significant breaking change somewhere."
] |
|
https://api.github.com/repos/psf/requests/issues/4072
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4072/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4072/comments
|
https://api.github.com/repos/psf/requests/issues/4072/events
|
https://github.com/psf/requests/issues/4072
| 231,789,127 |
MDU6SXNzdWUyMzE3ODkxMjc=
| 4,072 |
"Packages" module is missing in Requests 2.16.0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/20154889?v=4",
"events_url": "https://api.github.com/users/velmurugan17/events{/privacy}",
"followers_url": "https://api.github.com/users/velmurugan17/followers",
"following_url": "https://api.github.com/users/velmurugan17/following{/other_user}",
"gists_url": "https://api.github.com/users/velmurugan17/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/velmurugan17",
"id": 20154889,
"login": "velmurugan17",
"node_id": "MDQ6VXNlcjIwMTU0ODg5",
"organizations_url": "https://api.github.com/users/velmurugan17/orgs",
"received_events_url": "https://api.github.com/users/velmurugan17/received_events",
"repos_url": "https://api.github.com/users/velmurugan17/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/velmurugan17/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/velmurugan17/subscriptions",
"type": "User",
"url": "https://api.github.com/users/velmurugan17",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2017-05-27T09:22:26Z
|
2021-09-08T09:00:54Z
|
2017-05-27T09:29:54Z
|
NONE
|
resolved
|
Description
We are using requests package for our application development and the framework picks up latest version of requests whenever it builds.Today we noticed that our app broken due to new version of Requests 2.16.0.The "Packages" module is completely missing and it leads to our delivery blocking,Could you please check and let us know if we can expect any quick fix for this issue?
Working version:
2.14.2 and 2.15.1
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4072/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4072/timeline
| null |
completed
| null | null | false |
[
"This is a duplicate of #4069, please check open issues before raising bug reports. This goes double for emailing maintainers directly: it would have taken you 5 seconds to see your issue on the issue tracker. ",
"Sorry for the duplicate",
"2.16.1 released, which fixes this!",
"Note: code that was written to import against the requests.packages namespace previously will have to import code that rests at this module-level now.\r\n\r\nFor example:\r\n\r\n from requests.packages.urllib3.poolmanager import PoolManager\r\n\r\nWill need to be re-written to be:\r\n\r\n from requests.packages import urllib3\r\n urllib3.poolmanager.PoolManager\r\n\r\nOr, even better:\r\n\r\n from urllib3.poolmanager import PoolManager",
"Requests v2.16.2 is now out, which makes the above code no longer necessary. "
] |
https://api.github.com/repos/psf/requests/issues/4071
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4071/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4071/comments
|
https://api.github.com/repos/psf/requests/issues/4071/events
|
https://github.com/psf/requests/issues/4071
| 231,788,356 |
MDU6SXNzdWUyMzE3ODgzNTY=
| 4,071 |
ImportError: No module named 'requests.packages' for version 2.16.0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/14862976?v=4",
"events_url": "https://api.github.com/users/yash-nisar/events{/privacy}",
"followers_url": "https://api.github.com/users/yash-nisar/followers",
"following_url": "https://api.github.com/users/yash-nisar/following{/other_user}",
"gists_url": "https://api.github.com/users/yash-nisar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yash-nisar",
"id": 14862976,
"login": "yash-nisar",
"node_id": "MDQ6VXNlcjE0ODYyOTc2",
"organizations_url": "https://api.github.com/users/yash-nisar/orgs",
"received_events_url": "https://api.github.com/users/yash-nisar/received_events",
"repos_url": "https://api.github.com/users/yash-nisar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yash-nisar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yash-nisar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yash-nisar",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2017-05-27T09:07:41Z
|
2021-09-08T09:00:53Z
|
2017-05-27T09:17:17Z
|
NONE
|
resolved
|
```
Python 3.5.2 (default, Nov 17 2016, 17:05:23)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from requests.packages.urllib3.poolmanager import PoolManager
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: No module named 'requests.packages'
```
The following import statement used to work for the older version `2.14.2` but fails for the latest version `2.16.0`
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4071/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4071/timeline
| null |
completed
| null | null | false |
[
"This is a duplicate of #4069: please check open issues before reporting bugs. 😉",
"My bad.",
"Note: code that was written to import against the requests.packages namespace previously will have to import code that rests at this module-level now.\r\n\r\nFor example:\r\n\r\n from requests.packages.urllib3.poolmanager import PoolManager\r\n\r\nWill need to be re-written to be:\r\n\r\n from requests.packages import urllib3\r\n urllib3.poolmanager.PoolManager\r\n\r\nOr, even better:\r\n\r\n from urllib3.poolmanager import PoolManager",
"Requests v2.16.2 is now out, which makes the above code no longer necessary. "
] |
https://api.github.com/repos/psf/requests/issues/4070
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4070/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4070/comments
|
https://api.github.com/repos/psf/requests/issues/4070/events
|
https://github.com/psf/requests/issues/4070
| 231,782,772 |
MDU6SXNzdWUyMzE3ODI3NzI=
| 4,070 |
Error on importing Session object
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5862289?v=4",
"events_url": "https://api.github.com/users/MahdiZareie/events{/privacy}",
"followers_url": "https://api.github.com/users/MahdiZareie/followers",
"following_url": "https://api.github.com/users/MahdiZareie/following{/other_user}",
"gists_url": "https://api.github.com/users/MahdiZareie/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/MahdiZareie",
"id": 5862289,
"login": "MahdiZareie",
"node_id": "MDQ6VXNlcjU4NjIyODk=",
"organizations_url": "https://api.github.com/users/MahdiZareie/orgs",
"received_events_url": "https://api.github.com/users/MahdiZareie/received_events",
"repos_url": "https://api.github.com/users/MahdiZareie/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/MahdiZareie/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MahdiZareie/subscriptions",
"type": "User",
"url": "https://api.github.com/users/MahdiZareie",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-05-27T07:22:48Z
|
2021-09-08T10:00:37Z
|
2017-05-27T13:40:17Z
|
NONE
|
resolved
|
Hi guys
I'm using requests (2.16.0) and I'm seeing an error which wasn't here before :
```
Python 3.5.2 (default, Jul 17 2016, 00:00:00)
[GCC 4.8.4] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import urllib3
>>> urllib3.__version__
'1.16'
>>> from requests import Session
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/jenkins/env/lib/python3.5/site-packages/requests/__init__.py", line 49, in <module>
major, minor, patch = urllib3.__version__.split('.')[:3]
ValueError: not enough values to unpack (expected 3, got 2)
>>>
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4070/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4070/timeline
| null |
completed
| null | null | false |
[
"Yup, this looks like another error introduced by #4067, which appears to assume urllib3 uses three part version numbers (it does not always do that). You can resolve this by typing `pip install -U urllib3`, though that may break something else in your environment. \r\n\r\nPlease watch #4069, as we may well revert the change in 2.16.",
"Incidentally @kennethreitz, this is why I didnt want to do this before pip gets a dependency solver: a whole bunch of people who could use Requests before now cannot. ",
"this should now be fixed to provide a proper error on the master branch"
] |
https://api.github.com/repos/psf/requests/issues/4069
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4069/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4069/comments
|
https://api.github.com/repos/psf/requests/issues/4069/events
|
https://github.com/psf/requests/issues/4069
| 231,777,405 |
MDU6SXNzdWUyMzE3Nzc0MDU=
| 4,069 |
2.16.0 Release Breaking Changes if you relied on Vendored packages
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2430381?v=4",
"events_url": "https://api.github.com/users/audiolion/events{/privacy}",
"followers_url": "https://api.github.com/users/audiolion/followers",
"following_url": "https://api.github.com/users/audiolion/following{/other_user}",
"gists_url": "https://api.github.com/users/audiolion/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/audiolion",
"id": 2430381,
"login": "audiolion",
"node_id": "MDQ6VXNlcjI0MzAzODE=",
"organizations_url": "https://api.github.com/users/audiolion/orgs",
"received_events_url": "https://api.github.com/users/audiolion/received_events",
"repos_url": "https://api.github.com/users/audiolion/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/audiolion/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/audiolion/subscriptions",
"type": "User",
"url": "https://api.github.com/users/audiolion",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 12 |
2017-05-27T05:32:38Z
|
2021-09-08T09:00:53Z
|
2017-05-27T13:45:14Z
|
NONE
|
resolved
|
Hey so the 2.16.0 release broke all of the vendored things I am assuming. I have [issued](https://github.com/tomchristie/apistar/pull/189) two [PRs](https://github.com/encode/django-rest-framework/pull/5185) to two frameworks I use that rely on the vendored packages in requests.
The `changelog` was a bit obscure about this
> 2.16.0
> Unvendor ALL the things!
Something like `BREAKING CHANGE: Vendor packages have been removed, if you relied on these you will need to modify your code` would be nice in a 2.16.1 changelog update maybe?
I realize that it can be said these vendored packages are internal and should not be relied on but at least these packages had a use case for using requests and some of the underlying libs and used the vendor packages to ensure everything worked as expected with requests.
Anyone who was relying on these will have their code break upon upgrade, so perhaps a bigger version bump would have been welcome, but at least this can be a warning to people coming here wondering why stuff broke. My solution was a `compat.py` that conditionally imported `urllib3` (works the same for other vendored packages), see my PRs for that fix.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 7,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 7,
"url": "https://api.github.com/repos/psf/requests/issues/4069/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4069/timeline
| null |
completed
| null | null | false |
[
"Yeah, I don't know why @kennethreitz released that: it was pretty obviously going to break a lot of software. Not sure what I can say here: this is ultimately @kennethreitz's software and he can do what he wants, and I'm not going to revert his changes. But there was simply no reason that unvendoring needed to be shipped prior to v3, so I really hope @kennethreitz reverts and pushes a release containing that revert.",
"Related: #4073",
"@audiolion can you provide a sample of the code you were importing to utilize the internal packaged code? I'd like to test that I'm brining back the namespace properly. ",
"2.16.1 released, which restores the `packages` namespace. Sorry for the hiccup!",
"@kennethreitz hey! its the two PRs that I have in my first comment, you can check either for how I did it, worked for both of those libs",
"v2.16.2 of requests fixes the backwards incompatibility completely :)",
"Sorry to ruin your Saturday! thanks for all you do",
"No, sorry for ruining yours! :)",
"This still does not work with 2.16.2.\r\n```python\r\n>>> import requests\r\n>>> requests.packages\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\nAttributeError: module 'requests' has no attribute 'packages'\r\n```\r\n\r\nWas trying out the apistar project today and ran into this issue since it uses that way of accessing the module.",
"ah, I can fix that. ",
"@thrawny v2.16.3 released, which restores this. ",
"Thanks for the report!"
] |
https://api.github.com/repos/psf/requests/issues/4068
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4068/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4068/comments
|
https://api.github.com/repos/psf/requests/issues/4068/events
|
https://github.com/psf/requests/issues/4068
| 231,774,040 |
MDU6SXNzdWUyMzE3NzQwNDA=
| 4,068 |
⚠️ RuntimeError: requests dependency 'urllib3' or 'chardet'
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-05-27T04:19:25Z
|
2021-09-08T09:00:52Z
|
2017-05-27T16:43:21Z
|
CONTRIBUTOR
|
resolved
|
## Solution
$ pip install --upgrade requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 1,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/4068/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4068/timeline
| null |
completed
| null | null | false |
[] |
https://api.github.com/repos/psf/requests/issues/4067
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4067/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4067/comments
|
https://api.github.com/repos/psf/requests/issues/4067/events
|
https://github.com/psf/requests/pull/4067
| 231,769,417 |
MDExOlB1bGxSZXF1ZXN0MTIyNzQzNTU1
| 4,067 |
Deps (work in progress)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2017-05-27T02:45:50Z
|
2021-09-06T00:06:52Z
|
2017-05-27T03:33:28Z
|
CONTRIBUTOR
|
resolved
|
This pull request works on removing all vendored dependencies from Requests.
Targeting v2.16.0.
✨🍰✨
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 2,
"laugh": 0,
"rocket": 0,
"total_count": 3,
"url": "https://api.github.com/repos/psf/requests/issues/4067/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4067/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4067.diff",
"html_url": "https://github.com/psf/requests/pull/4067",
"merged_at": "2017-05-27T03:33:28Z",
"patch_url": "https://github.com/psf/requests/pull/4067.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4067"
}
| true |
[
"all tests passing (on python 3 at least!)",
"# [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=h1) Report\n> Merging [#4067](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=desc) into [master](https://codecov.io/gh/kennethreitz/requests/commit/282b01a7c9feae30feccbd54e33afcc06197df62?src=pr&el=desc) will **increase** coverage by `0.09%`.\n> The diff coverage is `100%`.\n\n[](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #4067 +/- ##\n==========================================\n+ Coverage 88.1% 88.19% +0.09% \n==========================================\n Files 16 16 \n Lines 1958 1949 -9 \n==========================================\n- Hits 1725 1719 -6 \n+ Misses 233 230 -3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [requests/sessions.py](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=tree#diff-cmVxdWVzdHMvc2Vzc2lvbnMucHk=) | `92.7% <100%> (ø)` | :arrow_up: |\n| [requests/exceptions.py](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=tree#diff-cmVxdWVzdHMvZXhjZXB0aW9ucy5weQ==) | `100% <100%> (ø)` | |\n| [requests/adapters.py](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=tree#diff-cmVxdWVzdHMvYWRhcHRlcnMucHk=) | `92.92% <100%> (ø)` | :arrow_up: |\n| [requests/models.py](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=tree#diff-cmVxdWVzdHMvbW9kZWxzLnB5) | `93.63% <100%> (+0.61%)` | :arrow_up: |\n| [requests/compat.py](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=tree#diff-cmVxdWVzdHMvY29tcGF0LnB5) | `100% <100%> (ø)` | |\n| [requests/certs.py](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=tree#diff-cmVxdWVzdHMvY2VydHMucHk=) | `75% <100%> (-13.89%)` | :arrow_down: |\n| [tests/testserver/\\_\\_init\\_\\_.py](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=tree#diff-dGVzdHMvdGVzdHNlcnZlci9fX2luaXRfXy5weQ==) | `92.59% <0%> (ø)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=footer). Last update [282b01a...d271341](https://codecov.io/gh/kennethreitz/requests/pull/4067?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n",
"Remembering now why I hated Travis CI when it first launched. ",
"YOLO!",
"👍 "
] |
https://api.github.com/repos/psf/requests/issues/4066
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4066/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4066/comments
|
https://api.github.com/repos/psf/requests/issues/4066/events
|
https://github.com/psf/requests/pull/4066
| 231,764,523 |
MDExOlB1bGxSZXF1ZXN0MTIyNzQwNjY2
| 4,066 |
API improvements
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2017-05-27T01:15:12Z
|
2021-09-05T00:07:18Z
|
2017-05-27T01:33:29Z
|
CONTRIBUTOR
|
resolved
|
- `Response.next`
Related: #4065.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4066/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4066/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4066.diff",
"html_url": "https://github.com/psf/requests/pull/4066",
"merged_at": "2017-05-27T01:33:29Z",
"patch_url": "https://github.com/psf/requests/pull/4066.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4066"
}
| true |
[
"# [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=h1) Report\n> Merging [#4066](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=desc) into [master](https://codecov.io/gh/kennethreitz/requests/commit/60041f51693fd6107ad91337222aa3dc125720ac?src=pr&el=desc) will **decrease** coverage by `2.83%`.\n> The diff coverage is `82.35%`.\n\n[](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #4066 +/- ##\n==========================================\n- Coverage 89.78% 86.94% -2.84% \n==========================================\n Files 16 16 \n Lines 1948 1961 +13 \n==========================================\n- Hits 1749 1705 -44 \n- Misses 199 256 +57\n```\n\n\n| [Impacted Files](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [requests/sessions.py](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree#diff-cmVxdWVzdHMvc2Vzc2lvbnMucHk=) | `92.36% <100%> (-1.59%)` | :arrow_down: |\n| [requests/models.py](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree#diff-cmVxdWVzdHMvbW9kZWxzLnB5) | `92.17% <50%> (-1.26%)` | :arrow_down: |\n| [requests/packages/chardet/compat.py](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree#diff-cmVxdWVzdHMvcGFja2FnZXMvY2hhcmRldC9jb21wYXQucHk=) | `64.86% <0%> (-35.14%)` | :arrow_down: |\n| [requests/utils.py](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree#diff-cmVxdWVzdHMvdXRpbHMucHk=) | `79.25% <0%> (-7%)` | :arrow_down: |\n| [requests/\\_internal\\_utils.py](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree#diff-cmVxdWVzdHMvX2ludGVybmFsX3V0aWxzLnB5) | `93.75% <0%> (-6.25%)` | :arrow_down: |\n| [requests/cookies.py](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree#diff-cmVxdWVzdHMvY29va2llcy5weQ==) | `76.27% <0%> (-0.85%)` | :arrow_down: |\n| [requests/auth.py](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree#diff-cmVxdWVzdHMvYXV0aC5weQ==) | `85.8% <0%> (-0.62%)` | :arrow_down: |\n| [requests/adapters.py](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=tree#diff-cmVxdWVzdHMvYWRhcHRlcnMucHk=) | `92.45% <0%> (-0.48%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=footer). Last update [60041f5...c3367d1](https://codecov.io/gh/kennethreitz/requests/pull/4066?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"
] |
https://api.github.com/repos/psf/requests/issues/4065
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4065/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4065/comments
|
https://api.github.com/repos/psf/requests/issues/4065/events
|
https://github.com/psf/requests/issues/4065
| 231,762,266 |
MDU6SXNzdWUyMzE3NjIyNjY=
| 4,065 |
Idea: Response.next() method, for when allow_redirects=False
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2017-05-27T00:39:38Z
|
2021-09-08T10:00:38Z
|
2017-05-27T02:17:29Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4065/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4065/timeline
| null |
completed
| null | null | false |
[
"I really don't like this. Responses will only keep a connection when you're streaming and that's it. If you're planning on attaching a session, that seems really ill-considered.",
"I really need to figure out why all my Requests notifications are going to spam",
"its possible you once put a previous request notification to spam and your email service may have assumed all subsequent requests notifications to spam"
] |
|
https://api.github.com/repos/psf/requests/issues/4064
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4064/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4064/comments
|
https://api.github.com/repos/psf/requests/issues/4064/events
|
https://github.com/psf/requests/pull/4064
| 231,489,666 |
MDExOlB1bGxSZXF1ZXN0MTIyNTQ4MzYw
| 4,064 |
Avoid breaking people using requests.__version__
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
] | null | 4 |
2017-05-25T23:45:24Z
|
2021-09-06T00:06:53Z
|
2017-05-25T23:46:09Z
|
CONTRIBUTOR
|
resolved
|
Using __version__ as a module breaks users who expect
requests.__version__ to be the version string.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4064/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4064/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4064.diff",
"html_url": "https://github.com/psf/requests/pull/4064",
"merged_at": "2017-05-25T23:46:09Z",
"patch_url": "https://github.com/psf/requests/pull/4064.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4064"
}
| true |
[
"Thanks!",
"i think `requests.__version__` would have worked fine before, but it just wasn't importable.",
"this required some additional work, but we should be all set now",
"this was actually a problem with `import *`, not the name of the file"
] |
https://api.github.com/repos/psf/requests/issues/4063
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4063/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4063/comments
|
https://api.github.com/repos/psf/requests/issues/4063/events
|
https://github.com/psf/requests/pull/4063
| 231,486,606 |
MDExOlB1bGxSZXF1ZXN0MTIyNTQ2MTI3
| 4,063 |
fix rtd
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2017-05-25T23:23:57Z
|
2021-09-06T00:06:52Z
|
2017-05-25T23:24:02Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4063/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4063/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/4063.diff",
"html_url": "https://github.com/psf/requests/pull/4063",
"merged_at": "2017-05-25T23:24:02Z",
"patch_url": "https://github.com/psf/requests/pull/4063.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/4063"
}
| true |
[] |
|
https://api.github.com/repos/psf/requests/issues/4062
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/4062/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/4062/comments
|
https://api.github.com/repos/psf/requests/issues/4062/events
|
https://github.com/psf/requests/issues/4062
| 231,437,745 |
MDU6SXNzdWUyMzE0Mzc3NDU=
| 4,062 |
Requests library raises ConnectionError if web-server returns error but only when uploading large file
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/7551586?v=4",
"events_url": "https://api.github.com/users/jhallard/events{/privacy}",
"followers_url": "https://api.github.com/users/jhallard/followers",
"following_url": "https://api.github.com/users/jhallard/following{/other_user}",
"gists_url": "https://api.github.com/users/jhallard/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jhallard",
"id": 7551586,
"login": "jhallard",
"node_id": "MDQ6VXNlcjc1NTE1ODY=",
"organizations_url": "https://api.github.com/users/jhallard/orgs",
"received_events_url": "https://api.github.com/users/jhallard/received_events",
"repos_url": "https://api.github.com/users/jhallard/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jhallard/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jhallard/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jhallard",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2017-05-25T19:39:08Z
|
2021-09-08T10:00:40Z
|
2017-05-25T20:21:02Z
|
NONE
|
resolved
|
Version: requests (2.12.4)
I'm running a webserver based on the Bottle framework. This framework exposes an endpoint where you can upload a file. Sometimes, if the disk is full, the webserver is supposed to return a code 429 without reading the file. For some reason, when I'm uploading a file, if the server tries to return a 429 status code the following exception is raised:
```python
File "../hooks.py", line 325, in post_video_content
response = requests.post(url, data=fh)
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 110, in post
return request('post', url, data=data, json=json, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 56, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 488, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 609, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/adapters.py", line 473, in send
raise ConnectionError(err, request=request)
ConnectionError: ('Connection aborted.', error(32, 'Broken pipe'))
```
But if try the exact same post but instead of posting a file I simply post some small amount of data, I actually get a response object back from the request and I can inspect the status code.
To reproduce:
webserver.py
```python
from bottle import Bottle, route, run, request, response, get, post, put, abort
@post('/content')
@authenticate
def content():
response.status = 429
return "failed to write incoming movie to temp file (space might be full temporarily)"
run(host="127.0.0.1", port=8080, debug=True)
```
send_request.py
```python
import requests
# this works and prints the status code
ret = requests.post("127.0.0.1:8080/content", data="sdfsdfsdfsdf")
print ret.status_code
# this part will throw an exception
try:
with open("~/some_large_video_file.mp4", 'rb') as fh:
ret = requests.post('127.0.0.1:8080/content', data=fh)
except:
print traceback.format_exc()
```
I've found out that it depends on the amount of data. If you try and post something like 10KB of data we get the 429 return code. So it looks like the magic filesize is somewhere between 104K and 117K. If I try the former it works as intended, I get the response from the request and can access the status code. If I try the former I get the exception raised.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/4062/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/4062/timeline
| null |
completed
| null | null | false |
[
"Unfortunately, this is a known problem with Requests that boils down to our use of httplib. We can't do much about it right now, but we're planning to abandon httplib sometime this year, so hopefully we'll resolve that then. ",
"thanks for letting me know, I'll have to figure out some workaround. "
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.