url
stringlengths 50
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 64
67
| comments_url
stringlengths 59
62
| events_url
stringlengths 57
60
| html_url
stringlengths 38
43
| id
int64 597k
2.65B
| node_id
stringlengths 18
32
| number
int64 1
6.83k
| title
stringlengths 1
296
| user
dict | labels
listlengths 0
5
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
4
| milestone
dict | comments
int64 0
211
| created_at
stringlengths 20
20
| updated_at
stringlengths 20
20
| closed_at
stringlengths 20
20
⌀ | author_association
stringclasses 3
values | active_lock_reason
stringclasses 4
values | body
stringlengths 0
65.6k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 59
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | draft
bool 2
classes | pull_request
dict | is_pull_request
bool 2
classes | issue_comments
listlengths 0
30
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/6007
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/6007/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/6007/comments
|
https://api.github.com/repos/psf/requests/issues/6007/events
|
https://github.com/psf/requests/issues/6007
| 1,080,553,603 |
I_kwDOABTKOs5AZ_CD
| 6,007 |
No Error when iteration over streamed content randomly stops
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/62714929?v=4",
"events_url": "https://api.github.com/users/AlphaSlayer1964/events{/privacy}",
"followers_url": "https://api.github.com/users/AlphaSlayer1964/followers",
"following_url": "https://api.github.com/users/AlphaSlayer1964/following{/other_user}",
"gists_url": "https://api.github.com/users/AlphaSlayer1964/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AlphaSlayer1964",
"id": 62714929,
"login": "AlphaSlayer1964",
"node_id": "MDQ6VXNlcjYyNzE0OTI5",
"organizations_url": "https://api.github.com/users/AlphaSlayer1964/orgs",
"received_events_url": "https://api.github.com/users/AlphaSlayer1964/received_events",
"repos_url": "https://api.github.com/users/AlphaSlayer1964/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AlphaSlayer1964/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlphaSlayer1964/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AlphaSlayer1964",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-12-15T04:31:41Z
|
2022-03-17T02:21:45Z
|
2021-12-17T02:19:12Z
|
NONE
|
resolved
|
<!-- Summary. -->
## Expected Result
An error is thrown when iterating over streamed content and the connection is closed/timed out by server.
<!-- What you expected. -->
## Actual Result
Iterating over streamed content randomly think it has all the content when it doesn't.
<!-- What happened instead. -->
## Reproduction Steps
If you try to use this function to download a large file with and the download speed is slow it will sometimes eventually just think it has completed writing all the content when it has not. I have tried including different headers and it didn't prevent this from happening. Sorry if this doesn't count as a bug, I can not find any similar issues online.
edit: found that setting chunk_size=1 on a large video file will have the same effect as a slow connection.
```python
import requests
def requests_download(url:str, file_name:str):
responce = requests.get(url=url, stream=True)
with open(file_name, 'wb') as f:
for chunk in responce.iter_content(chunk_size=1024):
f.write(chunk)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "4.0.0"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "2.10"
},
"implementation": {
"name": "CPython",
"version": "3.9.5"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.25.1"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.26.4"
},
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6007/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/6007/timeline
| null |
completed
| null | null | false |
[
"In no case do we raise an error when a server sends less data than they promised, streaming or otherwise. Further, we don't raise an error when it sends more than it promised. Case in point, if a server compresses its response, the Content-Length header will be the length of the compressed response. If we raised an error after decompressing that the lengths were different, that would be nonsensical."
] |
https://api.github.com/repos/psf/requests/issues/6006
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/6006/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/6006/comments
|
https://api.github.com/repos/psf/requests/issues/6006/events
|
https://github.com/psf/requests/issues/6006
| 1,078,909,667 |
I_kwDOABTKOs5ATtrj
| 6,006 |
UnicodeDecodeError after following a chain of redirects
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1001553?v=4",
"events_url": "https://api.github.com/users/wodim/events{/privacy}",
"followers_url": "https://api.github.com/users/wodim/followers",
"following_url": "https://api.github.com/users/wodim/following{/other_user}",
"gists_url": "https://api.github.com/users/wodim/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wodim",
"id": 1001553,
"login": "wodim",
"node_id": "MDQ6VXNlcjEwMDE1NTM=",
"organizations_url": "https://api.github.com/users/wodim/orgs",
"received_events_url": "https://api.github.com/users/wodim/received_events",
"repos_url": "https://api.github.com/users/wodim/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wodim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wodim/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wodim",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2021-12-13T19:38:10Z
|
2022-01-01T16:26:53Z
|
2021-12-19T14:01:46Z
|
NONE
| null |
Something confuses requests (or urllib3?) along the way
## Actual Result
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf1 in position 92: invalid continuation byte
## Reproduction Steps
```python
import requests
requests.get("https://www.lavozdegalicia.es/noticia/deportes/2021/12/13/psg-juve-united-nuevos-rivales-espa%C3%B1oles-champions/00031639396272418389372.htm")
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "4.0.0"
},
"charset_normalizer": {
"version": "2.0.9"
},
"cryptography": {
"version": "36.0.0"
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.8.10"
},
"platform": {
"release": "4.4.0-17763-Microsoft",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "101010cf",
"version": "21.0.0"
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010106f"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": false,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6006/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/6006/timeline
| null |
completed
| null | null | false |
[
"This isn't a full traceback and this it's impossible to tell if this is a big in requests, urllib3, http.client, or the socket module (three of which aren't this library)",
"Have you, you know, tried the reproduction steps?",
"I am going to reproduce a comment that was cowardly deleted by someone using the \"psf\" moniker:\r\n\r\n> @sigmavirus24 you have been too harsh on this one.\r\n> \r\n> Traceback (most recent call last):\r\n> File \"<stdin>\", line 1, in <module>\r\n> File \"C:\\Users\\Ahmed\\AppData\\Local\\Programs\\Python\\Python37\\lib\\site-packages\\requests\\api.py\", line 76, in get\r\n> return request('get', url, params=params, **kwargs)\r\n> File \"C:\\Users\\Ahmed\\AppData\\Local\\Programs\\Python\\Python37\\lib\\site-packages\\requests\\api.py\", line 61, in request\r\n> return session.request(method=method, url=url, **kwargs)\r\n> File \"C:\\Users\\Ahmed\\AppData\\Local\\Programs\\Python\\Python37\\lib\\site-packages\\requests\\sessions.py\", line 542, in request\r\n> resp = self.send(prep, **send_kwargs)\r\n> File \"C:\\Users\\Ahmed\\AppData\\Local\\Programs\\Python\\Python37\\lib\\site-packages\\requests\\sessions.py\", line 677, in send\r\n> history = [resp for resp in gen]\r\n> File \"C:\\Users\\Ahmed\\AppData\\Local\\Programs\\Python\\Python37\\lib\\site-packages\\requests\\sessions.py\", line 677, in <listcomp>\r\n> history = [resp for resp in gen]\r\n> File \"C:\\Users\\Ahmed\\AppData\\Local\\Programs\\Python\\Python37\\lib\\site-packages\\requests\\sessions.py\", line 150, in resolve_redirects\r\n> url = self.get_redirect_target(resp)\r\n> File \"C:\\Users\\Ahmed\\AppData\\Local\\Programs\\Python\\Python37\\lib\\site-packages\\requests\\sessions.py\", line 116, in get_redirect_target\r\n> return to_native_string(location, 'utf8')\r\n> File \"C:\\Users\\Ahmed\\AppData\\Local\\Programs\\Python\\Python37\\lib\\site-packages\\requests\\_internal_utils.py\", line 25, in to_native_string\r\n> out = string.decode(encoding)\r\n> UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf1 in position 92: invalid continuation byte\r\n>\r\n> The guilty part there is return to_native_string(location, 'utf8') Trying to decode the URL to native utf8 when it should rather \"URL encode\" it. I am not an HTTP expert, but this exception should be handled more gracefully anyway.\r\n> \r\n> The location given by the remote for redirection is as follow:\r\n> \r\n> b'http://www.lavozdegalicia.es/noticia/deportes/2021/12/13/psg-juve-united-nuevos-rivales-espa\\xf1oles-champions/00031639396272418389372.htm'\r\n>\r\n> Should the \\xf1 be decoded as follow %F1 ?\r\n>\r\n> I can see that this behavior is already followed by Chrome.\r\n> \r\n> ",
"Not cowardly. I have automation because that person consistently harasses me and the PSF code of conduct group rarely bothers to take action. any time they mention me the automation will delete it for me because they aren't in my experience contributing with any purpose other than to misinterpret me and antagonize me. They've also refused to act upon repeated feedback on their actions.Further GitHub decides how that is displayed to non organization members. "
] |
https://api.github.com/repos/psf/requests/issues/6005
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/6005/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/6005/comments
|
https://api.github.com/repos/psf/requests/issues/6005/events
|
https://github.com/psf/requests/issues/6005
| 1,078,778,017 |
I_kwDOABTKOs5ATNih
| 6,005 |
Python requests library call works on Windows but not Linux... WHY?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/27786802?v=4",
"events_url": "https://api.github.com/users/doverradio/events{/privacy}",
"followers_url": "https://api.github.com/users/doverradio/followers",
"following_url": "https://api.github.com/users/doverradio/following{/other_user}",
"gists_url": "https://api.github.com/users/doverradio/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/doverradio",
"id": 27786802,
"login": "doverradio",
"node_id": "MDQ6VXNlcjI3Nzg2ODAy",
"organizations_url": "https://api.github.com/users/doverradio/orgs",
"received_events_url": "https://api.github.com/users/doverradio/received_events",
"repos_url": "https://api.github.com/users/doverradio/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/doverradio/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/doverradio/subscriptions",
"type": "User",
"url": "https://api.github.com/users/doverradio",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-12-13T17:10:28Z
|
2022-03-13T18:00:24Z
|
2021-12-13T17:15:47Z
|
NONE
|
resolved
|
Long time user of python requests here. Trying to do a simple call to this endpoint:
`https://www.overstock.com/api/product.json?prod_id=10897789`
My current code:
```
import requests
headers = { 'User-Agent': 'Mozilla/5.0', 'Accept': 'application/json' }
url = 'https://www.overstock.com/api/product.json?prod_id=10897789'
r = requests.get( url, headers=headers )
result = r.json()
print( result )
```
## Expected Result
(Shortened)
```
{'categoryId': 244, 'subCategoryId': 31446, 'altSubCategoryId': 0, 'taxonomy': {'store': {'id': 1, 'name': 'Rugs', 'apiUrl': 'https://www.overstock.com/api/search.json?taxonomy=sto1', 'htmlUrl': 'https://www.overstock.com/Home-Garden/1/store.html'}, 'department': {'id': 3, 'name': 'Casual Rugs'...
```
## Actual Result
Unfortunately, from that same script on Linux, I am not getting the identical result. So far I am stumped as to why this is happening...
Here is the ugly Linux error:
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/root/.local/share/virtualenvs/online-project-7j1lNF7P/lib/python3.6/site-packages/requests/models.py", line 900, in json
return complexjson.loads(self.text, **kwargs)
File "/usr/lib/python3.6/json/__init__.py", line 354, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3.6/json/decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python3.6/json/decoder.py", line 357, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 2 column 1 (char 1)
```
## Reproduction Steps
```
import requests
headers = { 'User-Agent': 'Mozilla/5.0', 'Accept': 'application/json' }
url = 'https://www.overstock.com/api/product.json?prod_id=10897789'
r = requests.get( url, headers=headers )
result = r.json()
print( result )
```
## System Information
1. Windows 10
2. Ubuntu 18.04.6 LTS (GNU/Linux 4.15.0-163-generic x86_64)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6005/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/6005/timeline
| null |
completed
| null | null | false |
[
"Hi @doverradio,\r\n\r\nSomething is triggering the server to return a non-JSON response when calling the service on Linux. Using the `json()` api requires that the payload be valid json, and you may need to add code to verify that before invoking `json()`. You're likely encountering some form of bot detection which is changing the response for Linux.\r\n\r\nUnfortunately this isn't an issue with Requests. We'd recommend opening an issue on StackOverflow if you're interested in finding alternative solutions to your issue. Thanks!"
] |
https://api.github.com/repos/psf/requests/issues/6004
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/6004/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/6004/comments
|
https://api.github.com/repos/psf/requests/issues/6004/events
|
https://github.com/psf/requests/issues/6004
| 1,077,668,422 |
I_kwDOABTKOs5AO-pG
| 6,004 |
For Morsel cookies requests expects wrong Expires time format
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/43011904?v=4",
"events_url": "https://api.github.com/users/druid8/events{/privacy}",
"followers_url": "https://api.github.com/users/druid8/followers",
"following_url": "https://api.github.com/users/druid8/following{/other_user}",
"gists_url": "https://api.github.com/users/druid8/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/druid8",
"id": 43011904,
"login": "druid8",
"node_id": "MDQ6VXNlcjQzMDExOTA0",
"organizations_url": "https://api.github.com/users/druid8/orgs",
"received_events_url": "https://api.github.com/users/druid8/received_events",
"repos_url": "https://api.github.com/users/druid8/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/druid8/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/druid8/subscriptions",
"type": "User",
"url": "https://api.github.com/users/druid8",
"user_view_type": "public"
}
|
[] |
open
| false | null |
[] | null | 9 |
2021-12-11T22:49:51Z
|
2023-09-28T09:09:55Z
| null |
NONE
| null |
I'm not sure about this, but it looks that requests is expecting invalid date format in Expires section in Cookies passed as Morsel objects.
`morsel_to_cookie` (from `requests/cookie.py`) function parse `expires` attr if there is no `max-age` (which is OK) using format from `time_template`. However this format is set as `'%a, %d-%b-%Y %H:%M:%S GMT'` which is none of allowed expires section date value described in RFC (https://www.rfc-editor.org/rfc/rfc6265#section-4.1.1).
The nearest format is the first choice from https://www.rfc-editor.org/rfc/rfc2616#section-3.3.1. The difference is that between date parts there should be a space, but requests expects dash.
See Reproduction Steps for very simple example which bases on Python std libs only and crashes.
## Expected Result
It's expected that requests properly accepts Morsel cookies when expires follows RFC https://www.rfc-editor.org/rfc/rfc2616#section-3.3.1.
## Actual Result
There is `ValueError` raised by strptime that passed value does not match format.
Example:
`ValueError: time data 'Thu, 01 Jan 1970 00:00:00 GMT' does not match format '%a, %d-%b-%Y %H:%M:%S GMT'`
## Reproduction Steps
```python
from http.cookies import SimpleCookie
from requests.cookies import RequestsCookieJar
cookies = SimpleCookie()
cookies.load('auth_session=null; path=/; expires=Thu, 01 Jan 1970 00:00:00 GMT; httponly; samesite=strict')
jar = RequestsCookieJar()
jar.update(cookies)
```
Example above is a simplified case of using [`async_asgi_testclient`](https://github.com/vinissimus/async-asgi-testclient) to test application written with [`Starlette`](https://www.starlette.io/) with `SessionMiddleware`. The `async_asgi_testclient` collects cookies using `SimpleCookie` class from standard `http` lib and then pass them to `requests` lib which is used to perform client test requests.
But this issue is not related to these packages as I reproduced it using only Python standard `http` lib and `requests` as above.
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "4.0.0"
},
"charset_normalizer": {
"version": "2.0.9"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.9.9"
},
"platform": {
"release": "5.15.0-1-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "101010cf"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
| null |
{
"+1": 3,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 3,
"url": "https://api.github.com/repos/psf/requests/issues/6004/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/6004/timeline
| null | null | null | null | false |
[
"@druid8, I am no expert but after searching for a bit it seems that **http.cookies.Morsel** follows rfc2109 attributes which expects `'%a, %d-%b-%Y %H:%M:%S GMT'` as to be its `expires` attr format\r\n\r\nReferences: [https://docs.python.org/3/library/http.cookies.html]()\r\n[https://datatracker.ietf.org/doc/html/rfc2109.html#section-10.1.2]()",
"> @druid8, I am no expert but after searching for a bit it seems that **http.cookies.Morsel** (python `Morsel module` - parent of `morsel_to_cookie`) follows rfc2109 attributes which expects `'%a, %d-%b-%Y %H:%M:%S GMT'` as to be its `expires` attr format\r\n> \r\n> References: https://docs.python.org/3/library/http.cookies.html https://datatracker.ietf.org/doc/html/rfc2109.html#section-10.1.2\r\n\r\nDo correct me if am wrong somewhere :)",
"Correct, however RFC2109 is obsolete and many frameworks and browsers follows RFC2616, none of new async-based web frameworks which I've seen supports old format - all of them generate cookie `expire` in one of RFC2616 format.\r\nWeb browsers also expects a 'spaced' format, but old one is and probably for a long time still will be supported: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#permanent_cookie.\r\n\r\nHowever this issue cause that if someone is using requests library to talk with software which sends cookies in RFC2616 it won't work. Maybe as a fix there should be a set of formats, and library should convert all allowed formats to the one expected by Morsel.",
"And one more thing, in my reproduction steps the code works as expected until\r\n```python\r\n jar = RequestsCookieJar()\r\n jar.update(cookies)\r\n```\r\nStandard library `SimpleCookie` accepts passed cookie value and parse it correctly.\r\nThe issue is later, when RequestsCookieJar() is updated, so maybe conversion is not needed at all.\r\n",
"> And one more thing, in my reproduction steps the code works as expected until\r\n> \r\n> ```python\r\n> jar = RequestsCookieJar()\r\n> jar.update(cookies)\r\n> ```\r\n> \r\n> Standard library `SimpleCookie` accepts passed cookie value and parse it correctly. The issue is later, when RequestsCookieJar() is updated, so maybe conversion is not needed at all.\r\n\r\nCorrect, `SimpleCookie.load()` already parses the cookie value into morse format whereas when passed to `RequestCookieJar` all RFC2109 cookies are parsed as RFC2965 or Netscape which I think is causing the issue, this indeed implies conversion is not at all needed.",
"@druid8 Running into the same issue. Did you find a workaround?",
"@mrgrain I have only a monkey-patch for this. Below is my workaround for pytest, however it can be easily integrated with any other code.\r\n\r\n```python\r\n\r\[email protected](scope='session')\r\ndef patch_requests():\r\n from requests import cookies\r\n org_mtc = cookies.morsel_to_cookie\r\n\r\n def _patch(value):\r\n if value['expires']:\r\n # requests accept invalid datetime format in cookies expires part\r\n # convert valid RFC formats to expected by requests\r\n # bug reported: https://github.com/psf/requests/issues/6004\r\n dt = time.strptime(value['expires'], '%a, %d %b %Y %H:%M:%S GMT')\r\n value['expires'] = time.strftime('%a, %d-%b-%Y %H:%M:%S GMT', dt)\r\n return org_mtc(value)\r\n\r\n try:\r\n cookies.morsel_to_cookie = _patch\r\n yield\r\n finally:\r\n cookies.morsel_to_cookie = org_mtc\r\n\r\n```",
"I just ran into this issue yesterday and was confused as to why this has been a long-standing issue. I think for the sake of backwards compatibility we should try parsing both the new format first, then fallback to the older rfc version upon failure. This will allow older applications to function as expected. Right now I'm doing the following in my code.\r\n\r\n```python\r\nimport contextlib\r\nfrom datetime import datetime\r\nfrom http.cookies import SimpleCookie\r\nimport requests\r\n\r\nsess = requests.Session()\r\n...\r\nresp = sess.get(...)\r\n# all cookies are stored in a singular Set-Cookie header, so we need to massage them out\r\n# http.cookies.SimpleCookie to the rescue!\r\ncookies = SimpleCookie(resp.headers[\"set-cookie\"])\r\nfor item in cookies.items():\r\n if \"expires\" in item[1]:\r\n # account for newer, superseding RFC2616#section-14.21 over RFC2109#section-10.1.2\r\n with contextlib.suppress(ValueError):\r\n # if this fails, the application/server is using older RFC2109 expires date standard\r\n # therefore, we can silently suppress the error.\r\n item[1][\"expires\"] = (\r\n datetime.strptime(item[1][\"expires\"], \"%a, %d %b %Y %H:%M:%S GMT\")\r\n ).strftime(\"%a, %d-%b-%Y %H:%M:%S GMT\")\r\n sess.cookies.set(*item)\r\n```",
"I know this doesn't help, but it's not even correct for RFC2109 by the looks of it. From [section 10.1.2](https://datatracker.ietf.org/doc/html/rfc2109.html#section-10.1.2):\r\n> Wdy, DD-Mon-YY HH:MM:SS GMT\r\n\r\nRequests [is using](https://github.com/psf/requests/blob/ee93fac6b2f715151f1aa9a1a06ddba9f7dcc59a/src/requests/cookies.py#L502C9-L502C52):\r\n```\r\n time_template = \"%a, %d-%b-%Y %H:%M:%S GMT\"\r\n```\r\n\r\nThe directives for these are defined [here](https://docs.python.org/3/library/time.html#time.strftime) which states:\r\n> %y Year without century as a decimal number [00,99].\r\n> %Y Year with century as a decimal number.\r\n\r\nI wonder if this has ever worked?\r\n\r\n```\r\n$ python3\r\nPython 3.11.5 (main, Sep 2 2023, 14:16:33) [GCC 13.2.1 20230801] on linux\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\n>>> from http.cookies import SimpleCookie\r\n>>> from requests.cookies import RequestsCookieJar\r\n>>> cookies = SimpleCookie()\r\n>>> cookies.load('__cf_bm=truncated_jibberish; path=/; expires=Thu, 28-Sep-23 09:34:34 GMT; domain=.sstatic.net; HttpOnly; Secure; SameSite=None')\r\n>>> jar = RequestsCookieJar()\r\n>>> jar.update(cookies)\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/usr/lib/python3.11/site-packages/requests/cookies.py\", line 364, in update\r\n super().update(other)\r\n File \"<frozen _collections_abc>\", line 949, in update\r\n File \"/usr/lib/python3.11/site-packages/requests/cookies.py\", line 341, in __setitem__\r\n self.set(name, value)\r\n File \"/usr/lib/python3.11/site-packages/requests/cookies.py\", line 219, in set\r\n c = morsel_to_cookie(value)\r\n ^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/usr/lib/python3.11/site-packages/requests/cookies.py\", line 503, in morsel_to_cookie\r\n expires = calendar.timegm(time.strptime(morsel[\"expires\"], time_template))\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/usr/lib/python3.11/_strptime.py\", line 562, in _strptime_time\r\n tt = _strptime(data_string, format)[0]\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/usr/lib/python3.11/_strptime.py\", line 349, in _strptime\r\n raise ValueError(\"time data %r does not match format %r\" %\r\nValueError: time data 'Thu, 28-Sep-23 09:34:34 GMT' does not match format '%a, %d-%b-%Y %H:%M:%S GMT'\r\n>>> \r\n```"
] |
https://api.github.com/repos/psf/requests/issues/6003
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/6003/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/6003/comments
|
https://api.github.com/repos/psf/requests/issues/6003/events
|
https://github.com/psf/requests/pull/6003
| 1,075,108,195 |
PR_kwDOABTKOs4vlvVM
| 6,003 |
Rejecting URLs with Unverified SSL Certs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10689849?v=4",
"events_url": "https://api.github.com/users/Mr1Vgy/events{/privacy}",
"followers_url": "https://api.github.com/users/Mr1Vgy/followers",
"following_url": "https://api.github.com/users/Mr1Vgy/following{/other_user}",
"gists_url": "https://api.github.com/users/Mr1Vgy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Mr1Vgy",
"id": 10689849,
"login": "Mr1Vgy",
"node_id": "MDQ6VXNlcjEwNjg5ODQ5",
"organizations_url": "https://api.github.com/users/Mr1Vgy/orgs",
"received_events_url": "https://api.github.com/users/Mr1Vgy/received_events",
"repos_url": "https://api.github.com/users/Mr1Vgy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Mr1Vgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Mr1Vgy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Mr1Vgy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-12-09T03:40:19Z
|
2022-03-29T05:00:44Z
|
2021-12-29T04:57:40Z
|
NONE
|
resolved
|
Fixes an issue with unverified SSL certificates not being rejected
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6003/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/6003/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/6003.diff",
"html_url": "https://github.com/psf/requests/pull/6003",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6003.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6003"
}
| true |
[
"Non-TLS URLs will not send certificates to verify. Why do you think this library should reject those URLs no matter what?\n\nSpoiler: We will *not* be accepting this PR",
"Thanks for the proposal @Mr1Vgy, but unfortunately this breaks all non-https URIs, which is not something we intend to change. I'm resolving since we won't be able to accept this."
] |
https://api.github.com/repos/psf/requests/issues/6002
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/6002/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/6002/comments
|
https://api.github.com/repos/psf/requests/issues/6002/events
|
https://github.com/psf/requests/pull/6002
| 1,074,537,346 |
PR_kwDOABTKOs4vj6D5
| 6,002 |
Upstream2226 merge
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/15229879?v=4",
"events_url": "https://api.github.com/users/lmvlmv/events{/privacy}",
"followers_url": "https://api.github.com/users/lmvlmv/followers",
"following_url": "https://api.github.com/users/lmvlmv/following{/other_user}",
"gists_url": "https://api.github.com/users/lmvlmv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lmvlmv",
"id": 15229879,
"login": "lmvlmv",
"node_id": "MDQ6VXNlcjE1MjI5ODc5",
"organizations_url": "https://api.github.com/users/lmvlmv/orgs",
"received_events_url": "https://api.github.com/users/lmvlmv/received_events",
"repos_url": "https://api.github.com/users/lmvlmv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lmvlmv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lmvlmv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lmvlmv",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-12-08T15:32:17Z
|
2022-03-08T16:02:04Z
|
2021-12-08T15:33:29Z
|
CONTRIBUTOR
|
resolved
| null |
{
"avatar_url": "https://avatars.githubusercontent.com/u/15229879?v=4",
"events_url": "https://api.github.com/users/lmvlmv/events{/privacy}",
"followers_url": "https://api.github.com/users/lmvlmv/followers",
"following_url": "https://api.github.com/users/lmvlmv/following{/other_user}",
"gists_url": "https://api.github.com/users/lmvlmv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lmvlmv",
"id": 15229879,
"login": "lmvlmv",
"node_id": "MDQ6VXNlcjE1MjI5ODc5",
"organizations_url": "https://api.github.com/users/lmvlmv/orgs",
"received_events_url": "https://api.github.com/users/lmvlmv/received_events",
"repos_url": "https://api.github.com/users/lmvlmv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lmvlmv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lmvlmv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lmvlmv",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6002/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/6002/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/6002.diff",
"html_url": "https://github.com/psf/requests/pull/6002",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6002.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6002"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/6001
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/6001/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/6001/comments
|
https://api.github.com/repos/psf/requests/issues/6001/events
|
https://github.com/psf/requests/pull/6001
| 1,074,420,827 |
PR_kwDOABTKOs4vjhjK
| 6,001 |
Merge upstream from v2.26.0 requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/15229879?v=4",
"events_url": "https://api.github.com/users/lmvlmv/events{/privacy}",
"followers_url": "https://api.github.com/users/lmvlmv/followers",
"following_url": "https://api.github.com/users/lmvlmv/following{/other_user}",
"gists_url": "https://api.github.com/users/lmvlmv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lmvlmv",
"id": 15229879,
"login": "lmvlmv",
"node_id": "MDQ6VXNlcjE1MjI5ODc5",
"organizations_url": "https://api.github.com/users/lmvlmv/orgs",
"received_events_url": "https://api.github.com/users/lmvlmv/received_events",
"repos_url": "https://api.github.com/users/lmvlmv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lmvlmv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lmvlmv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lmvlmv",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-12-08T13:37:14Z
|
2022-03-08T15:05:29Z
|
2021-12-08T15:03:49Z
|
CONTRIBUTOR
|
resolved
| null |
{
"avatar_url": "https://avatars.githubusercontent.com/u/15229879?v=4",
"events_url": "https://api.github.com/users/lmvlmv/events{/privacy}",
"followers_url": "https://api.github.com/users/lmvlmv/followers",
"following_url": "https://api.github.com/users/lmvlmv/following{/other_user}",
"gists_url": "https://api.github.com/users/lmvlmv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lmvlmv",
"id": 15229879,
"login": "lmvlmv",
"node_id": "MDQ6VXNlcjE1MjI5ODc5",
"organizations_url": "https://api.github.com/users/lmvlmv/orgs",
"received_events_url": "https://api.github.com/users/lmvlmv/received_events",
"repos_url": "https://api.github.com/users/lmvlmv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lmvlmv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lmvlmv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lmvlmv",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6001/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/6001/timeline
| null | null | true |
{
"diff_url": "https://github.com/psf/requests/pull/6001.diff",
"html_url": "https://github.com/psf/requests/pull/6001",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/6001.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/6001"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/6000
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/6000/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/6000/comments
|
https://api.github.com/repos/psf/requests/issues/6000/events
|
https://github.com/psf/requests/issues/6000
| 1,073,962,636 |
I_kwDOABTKOs5AA16M
| 6,000 |
Requests throws "Value Error: too many values to unpack (expected 2)"
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/494783?v=4",
"events_url": "https://api.github.com/users/riyadparvez/events{/privacy}",
"followers_url": "https://api.github.com/users/riyadparvez/followers",
"following_url": "https://api.github.com/users/riyadparvez/following{/other_user}",
"gists_url": "https://api.github.com/users/riyadparvez/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/riyadparvez",
"id": 494783,
"login": "riyadparvez",
"node_id": "MDQ6VXNlcjQ5NDc4Mw==",
"organizations_url": "https://api.github.com/users/riyadparvez/orgs",
"received_events_url": "https://api.github.com/users/riyadparvez/received_events",
"repos_url": "https://api.github.com/users/riyadparvez/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/riyadparvez/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/riyadparvez/subscriptions",
"type": "User",
"url": "https://api.github.com/users/riyadparvez",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-12-08T03:11:10Z
|
2022-03-09T04:00:34Z
|
2021-12-09T03:14:21Z
|
CONTRIBUTOR
|
resolved
|
<!-- Summary. -->
Requests is throwing exception.
## Expected Result
<!-- What you expected. -->
## Actual Result
This is the stack trace of the exception
```
Traceback (most recent call last):
File "test.py", line 65, in <module>
get_data(lat, lon, start_timestamp, end_timestamp)
File "test.py", line 35, in get_data
result = requests.get(
File "/usr/src/app/weather_provider/.venv/lib/python3.8/site-packages/requests/api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "/usr/src/app/weather_provider/.venv/lib/python3.8/site-packages/requests/api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/src/app/weather_provider/.venv/lib/python3.8/site-packages/requests/sessions.py", line 528, in request
prep = self.prepare_request(req)
File "/usr/src/app/weather_provider/.venv/lib/python3.8/site-packages/requests/sessions.py", line 456, in prepare_request
p.prepare(
File "/usr/src/app/weather_provider/.venv/lib/python3.8/site-packages/requests/models.py", line 316, in prepare
self.prepare_url(url, params)
File "/usr/src/app/weather_provider/.venv/lib/python3.8/site-packages/requests/models.py", line 434, in prepare_url
enc_params = self._encode_params(params)
File "/usr/src/app/weather_provider/.venv/lib/python3.8/site-packages/requests/models.py", line 97, in _encode_params
for k, vs in to_key_val_list(data):
ValueError: too many values to unpack (expected 2)
```
## Reproduction Steps
Minimal script to reproduce error:
```python
import os
import pandas as pd
import requests
import sys
from dotenv import load_dotenv
load_dotenv()
from datetime import datetime, timedelta, timezone
NEW_IBM_DATETIME_FORMAT = '%Y-%m-%dT%H:%M:%SZ'
URL_BACKFILL = "https://api.weather.com/v3/wx/hod/r1/direct"
HISTORICAL_WEATHER_API_KEY = os.getenv("HISTORICAL_WEATHER_API_KEY")
request_headers = {
"User-Agent": "Request-Promise",
"Accept": "application/json",
"Accept-Encoding": "gzip",
}
def get_data(lat, lon, start_timestamp, end_timestamp=None):
params_d = {
"geocode": f"{lat},{lon}",
"startDateTime": start_timestamp.strftime(NEW_IBM_DATETIME_FORMAT),
"endDateTime": end_timestamp.strftime(NEW_IBM_DATETIME_FORMAT),
"units": "m",
"format": "json",
"apiKey": HISTORICAL_WEATHER_API_KEY,
},
# This throws exception
result = requests.get(
URL_BACKFILL,
params=params_d,
timeout=15
)
# This works just fine
result = requests.get(
URL_BACKFILL,
params={
"geocode": f"{lat},{lon}",
"startDateTime": start_timestamp.strftime(NEW_IBM_DATETIME_FORMAT),
"endDateTime": end_timestamp.strftime(NEW_IBM_DATETIME_FORMAT),
"units": "m",
"format": "json",
"apiKey": HISTORICAL_WEATHER_API_KEY,
},
)
print(result)
if __name__ == '__main__':
lat = 41.636947
lon = -74.403541
start_timestamp = datetime(2021, 8, 28, 0, tzinfo=timezone.utc)
end_timestamp = datetime(2021, 8, 31, 0, tzinfo=timezone.utc)
get_data(lat, lon, start_timestamp, end_timestamp)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.9"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.8.12"
},
"platform": {
"release": "4.15.0-163-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/494783?v=4",
"events_url": "https://api.github.com/users/riyadparvez/events{/privacy}",
"followers_url": "https://api.github.com/users/riyadparvez/followers",
"following_url": "https://api.github.com/users/riyadparvez/following{/other_user}",
"gists_url": "https://api.github.com/users/riyadparvez/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/riyadparvez",
"id": 494783,
"login": "riyadparvez",
"node_id": "MDQ6VXNlcjQ5NDc4Mw==",
"organizations_url": "https://api.github.com/users/riyadparvez/orgs",
"received_events_url": "https://api.github.com/users/riyadparvez/received_events",
"repos_url": "https://api.github.com/users/riyadparvez/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/riyadparvez/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/riyadparvez/subscriptions",
"type": "User",
"url": "https://api.github.com/users/riyadparvez",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/6000/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/6000/timeline
| null |
completed
| null | null | false |
[
"You're passing a single tuple to params. You're giving requests garbage.\n\nUnfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here.",
"My bad. It's a python gotcha I was not aware of. Thank you."
] |
https://api.github.com/repos/psf/requests/issues/5999
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5999/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5999/comments
|
https://api.github.com/repos/psf/requests/issues/5999/events
|
https://github.com/psf/requests/issues/5999
| 1,073,404,234 |
I_kwDOABTKOs4_-tlK
| 5,999 |
Working proxies throwing error in requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/64457507?v=4",
"events_url": "https://api.github.com/users/analogaio/events{/privacy}",
"followers_url": "https://api.github.com/users/analogaio/followers",
"following_url": "https://api.github.com/users/analogaio/following{/other_user}",
"gists_url": "https://api.github.com/users/analogaio/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/analogaio",
"id": 64457507,
"login": "analogaio",
"node_id": "MDQ6VXNlcjY0NDU3NTA3",
"organizations_url": "https://api.github.com/users/analogaio/orgs",
"received_events_url": "https://api.github.com/users/analogaio/received_events",
"repos_url": "https://api.github.com/users/analogaio/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/analogaio/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/analogaio/subscriptions",
"type": "User",
"url": "https://api.github.com/users/analogaio",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-12-07T14:15:45Z
|
2021-12-07T22:16:45Z
|
2021-12-07T22:16:36Z
|
NONE
|
resolved
|
I gave my friends my exact code with the same proxy, it works for 4 different people, but fails for me and another.
## Expected Result
For the request to give a valid response / not fail
## Actual Result
Traceback (most recent call last):
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connectionpool.py", line 696, in urlopen
self._prepare_proxy(conn)
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connectionpool.py", line 964, in _prepare_proxy
conn.connect()
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connection.py", line 371, in connect
self._tunnel()
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\http\client.py", line 922, in _tunnel
(version, code, message) = response._read_status()
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\http\client.py", line 279, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\adapters.py", line 449, in send
timeout=timeout
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\connectionpool.py", line 756, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\urllib3\util\retry.py", line 574, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: / (Caused by ProxyError('Cannot connect to proxy.', RemoteDisconnected('Remote end closed connection without response')))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:/Users/Allen/Desktop/AnalogAIO CLI/ProxyTest.py", line 15, in <module>
res = session.get("https://httpbin.org/")
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\sessions.py", line 555, in get
return self.request('GET', url, **kwargs)
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "C:\Users\Allen\AppData\Local\Programs\Python\Python37\lib\site-packages\requests\adapters.py", line 510, in send
raise ProxyError(e, request=request)
requests.exceptions.ProxyError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: / (Caused by ProxyError('Cannot connect to proxy.', RemoteDisconnected('Remote end closed connection without response')))
## Reproduction Steps
```python
import requests
session = requests.Session()
proxy = "ip:port:user:pass" # Put an actual proxy here
# split proxy into host and port and user and password
host, port, user, password = proxy.split(":")
proxies = {
"http": "http://{}:{}@{}:{}".format(user, password, host, port),
"https": "http://{}:{}@{}:{}".format(user, password, host, port)
}
session.proxies.update(proxies)
response = session.get("https://httpbin.org/")
print(response.status_code)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "3.0.4"
},
"charset_normalizer": {
"version": "2.0.9"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.7.9"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010107f"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
Running on Python 3.7.9 and Windows 11.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5999/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5999/timeline
| null |
completed
| null | null | false |
[
"您好，您的邮件我已收到，我会尽快给您回复。",
"> ProxyError('Cannot connect to proxy.', RemoteDisconnected('Remote end closed connection without response')))\r\n\r\nIndicates that your proxy isn't accepting connections from you or your other friend. That's a networking issue between you and the proxy.\r\n\r\nIn the future, please use StackOverflow for questions and technical support like this"
] |
https://api.github.com/repos/psf/requests/issues/5998
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5998/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5998/comments
|
https://api.github.com/repos/psf/requests/issues/5998/events
|
https://github.com/psf/requests/pull/5998
| 1,071,394,317 |
PR_kwDOABTKOs4vZnhL
| 5,998 |
Update README.md
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/89785800?v=4",
"events_url": "https://api.github.com/users/vashisthabhinav/events{/privacy}",
"followers_url": "https://api.github.com/users/vashisthabhinav/followers",
"following_url": "https://api.github.com/users/vashisthabhinav/following{/other_user}",
"gists_url": "https://api.github.com/users/vashisthabhinav/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vashisthabhinav",
"id": 89785800,
"login": "vashisthabhinav",
"node_id": "MDQ6VXNlcjg5Nzg1ODAw",
"organizations_url": "https://api.github.com/users/vashisthabhinav/orgs",
"received_events_url": "https://api.github.com/users/vashisthabhinav/received_events",
"repos_url": "https://api.github.com/users/vashisthabhinav/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vashisthabhinav/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vashisthabhinav/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vashisthabhinav",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-12-05T07:40:13Z
|
2022-03-05T11:00:22Z
|
2021-12-05T10:52:10Z
|
CONTRIBUTOR
|
resolved
|
Grammatical errors corrected.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5998/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5998/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5998.diff",
"html_url": "https://github.com/psf/requests/pull/5998",
"merged_at": "2021-12-05T10:52:10Z",
"patch_url": "https://github.com/psf/requests/pull/5998.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5998"
}
| true |
[
"\"Allows\" -> \"Allow\" has the same issue. \r\n\r\nOnly the \"package\" error was actually an error I think."
] |
https://api.github.com/repos/psf/requests/issues/5997
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5997/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5997/comments
|
https://api.github.com/repos/psf/requests/issues/5997/events
|
https://github.com/psf/requests/issues/5997
| 1,071,256,103 |
I_kwDOABTKOs4_2hIn
| 5,997 |
ssl handshake fail for timing out
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/94951207?v=4",
"events_url": "https://api.github.com/users/Long199for/events{/privacy}",
"followers_url": "https://api.github.com/users/Long199for/followers",
"following_url": "https://api.github.com/users/Long199for/following{/other_user}",
"gists_url": "https://api.github.com/users/Long199for/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Long199for",
"id": 94951207,
"login": "Long199for",
"node_id": "U_kgDOBajXJw",
"organizations_url": "https://api.github.com/users/Long199for/orgs",
"received_events_url": "https://api.github.com/users/Long199for/received_events",
"repos_url": "https://api.github.com/users/Long199for/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Long199for/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Long199for/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Long199for",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-12-04T17:26:12Z
|
2022-03-04T20:00:25Z
|
2021-12-04T19:06:10Z
|
NONE
|
resolved
|
My sample is this:
import requests
host = "https://api.kucoin.com/api/v1/market/candles?symbol=BTC-USDT&type=1min"
r = requests.request('GET', host, timeout=30)
print(r.json())
I expect that the candle data would be returned as json. While I got this each time:
Traceback (most recent call last):
File "C:\Users\xxxxx\AppData\Roaming\Python\Python37\site-packages\requests\adapters.py", line 449, in send
timeout=timeout
File "C:\Users\xxxxx\AppData\Roaming\Python\Python37\site-packages\urllib3\connectionpool.py", line 756, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "C:\Users\xxxxx\AppData\Roaming\Python\Python37\site-packages\urllib3\util\retry.py", line 574, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='api.kucoin.com', port=443): Max retries exceeded with url: /api/v1/market/candles?symbol=BTC-USDT&type=1min (Caused by ProxyError('Cannot connect to proxy.', timeout('_ssl.c:1074: The handshake operation timed out')))
While if I use:
import urllib.request
web = 'https://api.kucoin.com/api/v1/market/candles?symbol=BTC-USDT&type=1min'
req = urllib.request.Request(web)
data = urllib.request.urlopen(req).read().decode("utf-8",'ignore')
print(data)
I could get these candle data (time is about 10 seconds, if you wonder).
This web site could be open and returned data on chrome or with urllib. Since the market data could NOT need the auth parts. I wonder why I got this for requests. Same issues happened for me on website: https://api.bybit.com/spot/quote/v1/kline?symbol=ETHUSDT&interval=1m
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5997/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5997/timeline
| null |
completed
| null | null | false |
[
"You have a proxy configured, ostensibly in your environment, that we can't connect to. It's in your exception message.\r\n\r\nThis is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/5996
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5996/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5996/comments
|
https://api.github.com/repos/psf/requests/issues/5996/events
|
https://github.com/psf/requests/issues/5996
| 1,070,937,333 |
I_kwDOABTKOs4_1TT1
| 5,996 |
How to prevent requests from encoding a comma?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/81590614?v=4",
"events_url": "https://api.github.com/users/razorblade23/events{/privacy}",
"followers_url": "https://api.github.com/users/razorblade23/followers",
"following_url": "https://api.github.com/users/razorblade23/following{/other_user}",
"gists_url": "https://api.github.com/users/razorblade23/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/razorblade23",
"id": 81590614,
"login": "razorblade23",
"node_id": "MDQ6VXNlcjgxNTkwNjE0",
"organizations_url": "https://api.github.com/users/razorblade23/orgs",
"received_events_url": "https://api.github.com/users/razorblade23/received_events",
"repos_url": "https://api.github.com/users/razorblade23/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/razorblade23/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/razorblade23/subscriptions",
"type": "User",
"url": "https://api.github.com/users/razorblade23",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-12-03T20:20:58Z
|
2021-12-04T01:12:07Z
|
2021-12-04T01:11:43Z
|
NONE
| null |
Please refer to our [Stack Overflow tag](https://stackoverflow.com/questions/tagged/python-requests) for guidance.
I have an API which uses comma separated string `'en,fr'` for english and france for example. Requests encode this comma to `%2C` and response failes.
Is there some way to escape encoding of comma, or mark it as safe to use unchanged?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5996/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5996/timeline
| null |
completed
| null | null | false |
[
"Please refer to our [Stack Overflow tag](https://stackoverflow.com/questions/tagged/python-requests) for guidance.\r\n\r\nAlternatively, refer to our [documentation](https://docs.python-requests.org/en/latest/user/advanced/?highlight=prepared%20request#prepared-requests)"
] |
https://api.github.com/repos/psf/requests/issues/5995
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5995/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5995/comments
|
https://api.github.com/repos/psf/requests/issues/5995/events
|
https://github.com/psf/requests/pull/5995
| 1,068,190,390 |
PR_kwDOABTKOs4vPNM2
| 5,995 |
Add Access Token Authorization class
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1691815?v=4",
"events_url": "https://api.github.com/users/kleszcz/events{/privacy}",
"followers_url": "https://api.github.com/users/kleszcz/followers",
"following_url": "https://api.github.com/users/kleszcz/following{/other_user}",
"gists_url": "https://api.github.com/users/kleszcz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kleszcz",
"id": 1691815,
"login": "kleszcz",
"node_id": "MDQ6VXNlcjE2OTE4MTU=",
"organizations_url": "https://api.github.com/users/kleszcz/orgs",
"received_events_url": "https://api.github.com/users/kleszcz/received_events",
"repos_url": "https://api.github.com/users/kleszcz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kleszcz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kleszcz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kleszcz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-12-01T09:52:17Z
|
2022-03-02T01:26:27Z
|
2021-12-02T01:21:46Z
|
NONE
|
resolved
|
Added class for attaching access token to request object as an alternative for basic auth. I find it useful for services where OAuth is not an option.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5995/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5995/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5995.diff",
"html_url": "https://github.com/psf/requests/pull/5995",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5995.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5995"
}
| true |
[
"We're not accepting new features at this time"
] |
https://api.github.com/repos/psf/requests/issues/5994
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5994/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5994/comments
|
https://api.github.com/repos/psf/requests/issues/5994/events
|
https://github.com/psf/requests/issues/5994
| 1,067,789,019 |
I_kwDOABTKOs4_pSrb
| 5,994 |
ca_certs zip file extraction permission issue with multiple users on Python 3.6
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/152634?v=4",
"events_url": "https://api.github.com/users/Peter200lx/events{/privacy}",
"followers_url": "https://api.github.com/users/Peter200lx/followers",
"following_url": "https://api.github.com/users/Peter200lx/following{/other_user}",
"gists_url": "https://api.github.com/users/Peter200lx/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Peter200lx",
"id": 152634,
"login": "Peter200lx",
"node_id": "MDQ6VXNlcjE1MjYzNA==",
"organizations_url": "https://api.github.com/users/Peter200lx/orgs",
"received_events_url": "https://api.github.com/users/Peter200lx/received_events",
"repos_url": "https://api.github.com/users/Peter200lx/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Peter200lx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Peter200lx/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Peter200lx",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-12-01T00:00:05Z
|
2022-04-02T17:01:56Z
|
2022-01-02T16:56:38Z
|
NONE
|
resolved
|
When you have multiple users on a machine that each use `requests` from zipapps with `certifi`, one user running a request should not block other users from successfully performing requests. This issue only appears when using a zipapp on python3.6. For python3.7+ the certifi library handles the tempfile and `requests.util.extract_zipped_paths` never sees the zipapp. https://github.com/certifi/python-certifi/blob/2021.10.08/certifi/core.py#L43-L44
## Expected Result
```
user1 # python3.6 zipapp.2.26.zip
get file
user2 # python3.6 zipapp.2.26.zip
get file
```
## Actual Result
```
user1 # python3.6 zipapp.2.26.zip
get file
user2 # python3.6 zipapp.2.26.zip
Traceback (most recent call last):
File "/tmp/zipapp.2.26.zip/urllib3/util/ssl_.py", line 402, in ssl_wrap_socket
PermissionError: [Errno 13] Permission denied
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/tmp/zipapp.2.26.zip/urllib3/connectionpool.py", line 706, in urlopen
File "/tmp/zipapp.2.26.zip/urllib3/connectionpool.py", line 382, in _make_request
File "/tmp/zipapp.2.26.zip/urllib3/connectionpool.py", line 1010, in _validate_conn
File "/tmp/zipapp.2.26.zip/urllib3/connection.py", line 421, in connect
File "/tmp/zipapp.2.26.zip/urllib3/util/ssl_.py", line 404, in ssl_wrap_socket
urllib3.exceptions.SSLError: [Errno 13] Permission denied
During the handling the above ....... <a bunch of MaxRetryError tracebacks>
```
### Behaviors on versions:
The core issue is that the changes in #5707 result in different file permissions on disk. Prior to that change, the file would be extracted with `0o664` permissions, but afterwords it is generated with `0o600` permissions from [mkstemp](https://docs.python.org/3/library/tempfile.html#tempfile.mkstemp), which means that users other than the first runner couldn't access the certfille.
https://github.com/psf/requests/blob/c193d9742ed58d41252e65a4f57a936683bb8dbd/requests/utils.py#L275-L276
https://github.com/psf/requests/blob/c193d9742ed58d41252e65a4f57a936683bb8dbd/requests/utils.py#L283-L288
#### Python3.6 w/ requests==2.25.1
```
$ PYTHONPATH=zipapp.2.25.zip python3.6
>>> import certifi, requests
>>> certifi.where()
'/tmp/zipapp.2.25.zip/certifi/cacert.pem'
>>> requests.utils.extract_zipped_paths(certifi.where())
'/tmp/certifi/cacert.pem'
```
```
$ ls -lah /tmp/certifi/cacert.pem
-rw-rw-r--. 1 user1 user1 278K May 7 2020 /tmp/certifi/cacert.pem
```
#### Python3.6 w/ requests==2.26.0
```
$ PYTHONPATH=zipapp.2.26.zip python3.6
>>> import certifi, requests
>>> certifi.where()
'/tmp/zipapp.2.26.zip/certifi/cacert.pem'
>>> requests.utils.extract_zipped_paths(certifi.where())
'/tmp/cacert.pem'
```
```
$ ls -lah /tmp/cacert.pem
-rw-------. 1 user1 user1 254K Sep 23 23:34 /tmp/cacert.pem
```
#### Python3.7 w/ requests==2.26.0
```
$ PYTHONPATH=zipapp.2.26.zip python3.7
>>> import certifi, requests
>>> certifi.where()
'/tmp/tmpuwsvnshl'
>>> requests.utils.extract_zipped_paths(certifi.where())
'/tmp/tmpuwsvnshl'
```
```
$ ls -lah /tmp/tmpuwsvnshl
-rw------- 1 user1 user1 260K Nov 30 15:46 /tmp/tmpuwsvnshl
```
## System Information
$ PYTHONPATH=zipapp.2.26.zip python3.6 -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.8"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.6.8"
},
"platform": {
"release": "3.10.0-862.3.2.el7.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "100020bf"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
Ideally I'd prefer the `extract_zipped_paths` writer use a temporary file like `certifi` which gets cleaned up at the end of the program, but as a fallback the writer could be updated to save with `0o664` permissions again so that it doesn't matter which user first runs.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5994/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5994/timeline
| null |
completed
| null | null | false |
[
"Hi @Peter200lx, thanks for the detailed write up!\r\n\r\nAdding read permissions (`0o644`) seems like a possibility, I'm not sure we want to return group write perms. Given [3.6](https://www.python.org/dev/peps/pep-0494/#id34) reaches end of life in ~10 days (2021-12-23), I'm not certain it's worth the effort though. It's likely we'll see support for Python 3.6 drop early next year which may be before we push out a release that has the code fix for this.\r\n\r\n",
"Given tomorrow's release will be the last to support Python 3.6 and we don't have any candidate solutions, I'm going to resolve this as won't fix. The support floor for the next non-hotfix release after 2.27.0 will have Python 3.7 as the floor for Python version support."
] |
https://api.github.com/repos/psf/requests/issues/5993
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5993/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5993/comments
|
https://api.github.com/repos/psf/requests/issues/5993/events
|
https://github.com/psf/requests/pull/5993
| 1,066,744,922 |
PR_kwDOABTKOs4vKdy-
| 5,993 |
Run tox in parallel using -p instead of detox
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/49014?v=4",
"events_url": "https://api.github.com/users/davisagli/events{/privacy}",
"followers_url": "https://api.github.com/users/davisagli/followers",
"following_url": "https://api.github.com/users/davisagli/following{/other_user}",
"gists_url": "https://api.github.com/users/davisagli/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davisagli",
"id": 49014,
"login": "davisagli",
"node_id": "MDQ6VXNlcjQ5MDE0",
"organizations_url": "https://api.github.com/users/davisagli/orgs",
"received_events_url": "https://api.github.com/users/davisagli/received_events",
"repos_url": "https://api.github.com/users/davisagli/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davisagli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davisagli/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davisagli",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-11-30T03:25:51Z
|
2022-02-28T15:05:48Z
|
2021-11-30T14:07:59Z
|
CONTRIBUTOR
|
resolved
|
This updates `make test` to run tests in parallel using `tox -p` instead of `detox`. This has been supported since tox 3.7.0 and detox's PyPI page recommends switching to it.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5993/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5993/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5993.diff",
"html_url": "https://github.com/psf/requests/pull/5993",
"merged_at": "2021-11-30T14:07:59Z",
"patch_url": "https://github.com/psf/requests/pull/5993.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5993"
}
| true |
[
"@davisagli is this the fork you wanted to target?",
"@sigmavirus24 for this one, yes"
] |
https://api.github.com/repos/psf/requests/issues/5990
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5990/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5990/comments
|
https://api.github.com/repos/psf/requests/issues/5990/events
|
https://github.com/psf/requests/pull/5990
| 1,064,949,235 |
PR_kwDOABTKOs4vFPp2
| 5,990 |
Skip the test requiring trustme when it is not available
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/110765?v=4",
"events_url": "https://api.github.com/users/mgorny/events{/privacy}",
"followers_url": "https://api.github.com/users/mgorny/followers",
"following_url": "https://api.github.com/users/mgorny/following{/other_user}",
"gists_url": "https://api.github.com/users/mgorny/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mgorny",
"id": 110765,
"login": "mgorny",
"node_id": "MDQ6VXNlcjExMDc2NQ==",
"organizations_url": "https://api.github.com/users/mgorny/orgs",
"received_events_url": "https://api.github.com/users/mgorny/received_events",
"repos_url": "https://api.github.com/users/mgorny/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mgorny/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mgorny/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mgorny",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2021-11-27T09:35:55Z
|
2022-02-26T07:00:18Z
|
2021-11-28T01:20:18Z
|
CONTRIBUTOR
|
resolved
|
Modify the nosan_server fixture to cause test_https_warnings to be
skipped when trustme is not installed on the system, rather than causing
the whole test suite to fail unconditionally. This makes it possible
to run all the remaining tests on systems where trustme cannot be
installed due to its dependencies.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5990/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5990/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5990.diff",
"html_url": "https://github.com/psf/requests/pull/5990",
"merged_at": "2021-11-28T01:20:18Z",
"patch_url": "https://github.com/psf/requests/pull/5990.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5990"
}
| true |
[
"If one cannot install `idna` or `cryptography`, I suspect there are bigger issues that will prevent requests from working as securely or reliably as users expect. I'm not inclined to skip this test and give those users a false sense of security.",
"Don't requests work well with the Python stdlib OpenSSL support? My grep-foo may be weak here but I don't really see any actual code referencing cryptography (besides some version check and info), and idna doesn't seem to require cryptography.\r\n\r\nIn other words, I can't find anything requiring it but this one test.",
"_Right now_ we only use the standard library. That isn't a guarantee going into the future. Generally speaking, architectures that can't install cryptography seem to have limited security support in general. That is a good indicator that use of relatively modern cipher suites won't continue to work and our tests passing on those platforms and architectures are going to end up being a lie. \r\n\r\nAlso, this project doesn't claim to support those architectures or platforms meaning we don't need to skip tests on them because we can't even test easily on them. `alpha, hppa, ia64, m68k, s390 (not -x)` are highly niche architectures, we don't skip tests for downstreams because they attempt to support more than we can reasonably support.",
"Would it work for you if I changed the PR to just move the `import` inside the fixture, so that we would be able to skip that test via command-line without changing the default test suite behavior?",
"@mgorny that would work",
"Ok, done! I've added a comment to explain why it's not in global scope."
] |
https://api.github.com/repos/psf/requests/issues/5985
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5985/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5985/comments
|
https://api.github.com/repos/psf/requests/issues/5985/events
|
https://github.com/psf/requests/issues/5985
| 1,062,418,797 |
I_kwDOABTKOs4_Uzlt
| 5,985 |
Response hook does not accept user supplied arguments
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/83110?v=4",
"events_url": "https://api.github.com/users/abelcheung/events{/privacy}",
"followers_url": "https://api.github.com/users/abelcheung/followers",
"following_url": "https://api.github.com/users/abelcheung/following{/other_user}",
"gists_url": "https://api.github.com/users/abelcheung/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/abelcheung",
"id": 83110,
"login": "abelcheung",
"node_id": "MDQ6VXNlcjgzMTEw",
"organizations_url": "https://api.github.com/users/abelcheung/orgs",
"received_events_url": "https://api.github.com/users/abelcheung/received_events",
"repos_url": "https://api.github.com/users/abelcheung/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/abelcheung/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/abelcheung/subscriptions",
"type": "User",
"url": "https://api.github.com/users/abelcheung",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-11-24T13:17:07Z
|
2022-02-22T16:00:32Z
|
2021-11-24T15:03:30Z
|
NONE
|
resolved
|
Currently response hook does not accept any user supplied arguments. The keyword argument supplied to response hook is a dict of fixed keys generated by `Session.request()`:
https://github.com/psf/requests/blob/590350f8d094c216051510ed1dd18fe871b53b72/requests/sessions.py#L537-L544
It would be more versatile if user supplied data can be made available to response hooks, without resorting to global variables or subclassing (both Session and HTTPAdapter), only because method signatures don't have `**kwargs`.
About use cases... for example, validation on request body/file is done before sending request, and response hook behaves differently according to such validation result. It doesn't make sense to repeat such validation again from within response hooks, especially when it is expensive.
I can try working on a PR if it's desirable.
## System Information
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.7"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.8.12"
},
"platform": {
"release": "7",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "101010cf"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5985/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5985/timeline
| null |
completed
| null | null | false |
[
"Quoting https://github.com/psf/requests/blob/main/.github/ISSUE_TEMPLATE/Feature_request.md\r\n\r\n> Requests is not accepting feature requests at this time."
] |
https://api.github.com/repos/psf/requests/issues/5984
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5984/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5984/comments
|
https://api.github.com/repos/psf/requests/issues/5984/events
|
https://github.com/psf/requests/issues/5984
| 1,061,826,018 |
I_kwDOABTKOs4_Si3i
| 5,984 |
url "schema" should be "scheme"
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/578773?v=4",
"events_url": "https://api.github.com/users/DanLipsitt/events{/privacy}",
"followers_url": "https://api.github.com/users/DanLipsitt/followers",
"following_url": "https://api.github.com/users/DanLipsitt/following{/other_user}",
"gists_url": "https://api.github.com/users/DanLipsitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DanLipsitt",
"id": 578773,
"login": "DanLipsitt",
"node_id": "MDQ6VXNlcjU3ODc3Mw==",
"organizations_url": "https://api.github.com/users/DanLipsitt/orgs",
"received_events_url": "https://api.github.com/users/DanLipsitt/received_events",
"repos_url": "https://api.github.com/users/DanLipsitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DanLipsitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DanLipsitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DanLipsitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] |
{
"closed_at": "2021-12-30T21:48:07Z",
"closed_issues": 11,
"created_at": "2021-09-02T07:23:33Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/29",
"id": 7115399,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/29/labels",
"node_id": "MI_kwDOABTKOs4AbJKH",
"number": 29,
"open_issues": 0,
"state": "closed",
"title": "2.27.0",
"updated_at": "2021-12-30T21:48:07Z",
"url": "https://api.github.com/repos/psf/requests/milestones/29"
}
| 2 |
2021-11-23T23:49:06Z
|
2022-03-29T02:29:06Z
|
2021-12-29T01:39:08Z
|
NONE
|
resolved
|
https://github.com/psf/requests/blob/590350f8d094c216051510ed1dd18fe871b53b72/requests/models.py#L388-L392
I don't believe the first part of a URL is ever called a "schema." Exceptions and error messages referring to an incorrect schema are confusing, especially in contexts where actual schema errors are possible. If it isn't possible to change the `MissingSchema` exception (it looks like it is slated to be fixed in 3.x) please consider at least changing the error message.
References:
https://www.w3.org/Addressing/URL/url-spec.txt
https://github.com/psf/requests/issues/4495
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5984/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5984/timeline
| null |
completed
| null | null | false |
[
"Hi @DanLipsitt,\r\n\r\nWe agree the minomer isn't great and did address this in #2961 as you've noted. I'm open to reviewing a PR, although that too has an argument for whether it's \"breaking\". I'm not sure how the other maintainers feel on the subject.\r\n",
"There's a backwards compatible way to change the exception class that's not great. The message is definitely safe to change though"
] |
https://api.github.com/repos/psf/requests/issues/5983
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5983/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5983/comments
|
https://api.github.com/repos/psf/requests/issues/5983/events
|
https://github.com/psf/requests/pull/5983
| 1,061,399,116 |
PR_kwDOABTKOs4u6cDf
| 5,983 |
Update docs with for passing an array as a param
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/31387795?v=4",
"events_url": "https://api.github.com/users/yashshah1/events{/privacy}",
"followers_url": "https://api.github.com/users/yashshah1/followers",
"following_url": "https://api.github.com/users/yashshah1/following{/other_user}",
"gists_url": "https://api.github.com/users/yashshah1/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yashshah1",
"id": 31387795,
"login": "yashshah1",
"node_id": "MDQ6VXNlcjMxMzg3Nzk1",
"organizations_url": "https://api.github.com/users/yashshah1/orgs",
"received_events_url": "https://api.github.com/users/yashshah1/received_events",
"repos_url": "https://api.github.com/users/yashshah1/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yashshah1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yashshah1/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yashshah1",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-11-23T15:09:54Z
|
2022-02-21T16:00:24Z
|
2021-11-23T15:22:46Z
|
NONE
|
resolved
|
When passing an array for a `GET` request, some servers expect the key to be suffixed with a `[]`
to parse the URL correctly. Adding a note in the documentation for this case.
Further, Is it a good idea to make this behavior a default one? Concatenate a `[]` to the end of all keys
whose value is an array. Would love to hear your thoughts!
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5983/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5983/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5983.diff",
"html_url": "https://github.com/psf/requests/pull/5983",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5983.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5983"
}
| true |
[
"> When passing an array for a `GET` request, some servers expect the key to be suffixed with a `[]`\r\n> to parse the URL correctly. Adding a note in the documentation for this case.\r\n\r\nWe can't and won't document every non-standard edge case that exists. We expect users to understand the services they're talking to and cater to them directly.\r\n\r\n\r\n\r\n> Further, Is it a good idea to make this behavior a default one?\r\n\r\nNo. It's not a good idea to change behaviour in completely backwards incompatible ways"
] |
https://api.github.com/repos/psf/requests/issues/5982
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5982/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5982/comments
|
https://api.github.com/repos/psf/requests/issues/5982/events
|
https://github.com/psf/requests/pull/5982
| 1,060,998,169 |
PR_kwDOABTKOs4u5Si_
| 5,982 |
Update sessions.py
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/23016078?v=4",
"events_url": "https://api.github.com/users/junqfisica/events{/privacy}",
"followers_url": "https://api.github.com/users/junqfisica/followers",
"following_url": "https://api.github.com/users/junqfisica/following{/other_user}",
"gists_url": "https://api.github.com/users/junqfisica/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/junqfisica",
"id": 23016078,
"login": "junqfisica",
"node_id": "MDQ6VXNlcjIzMDE2MDc4",
"organizations_url": "https://api.github.com/users/junqfisica/orgs",
"received_events_url": "https://api.github.com/users/junqfisica/received_events",
"repos_url": "https://api.github.com/users/junqfisica/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/junqfisica/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/junqfisica/subscriptions",
"type": "User",
"url": "https://api.github.com/users/junqfisica",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-11-23T09:14:16Z
|
2021-11-23T15:53:17Z
|
2021-11-23T11:46:36Z
|
NONE
|
resolved
|
This change will make the hierarchy request **kwargs -> Session args -> environment to be respected. This also solves problems with pip as discussed [here](https://github.com/pypa/pip/issues/9691#issuecomment-791608247) and #5735
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5982/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5982/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5982.diff",
"html_url": "https://github.com/psf/requests/pull/5982",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5982.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5982"
}
| true |
[
"Read #5735 more closely please. There are certainly people who are unknowingly relying on this behaviour in 2.x and we cannot break them suddenly. It's worse because even if we document this they will still be surprised as they likely have no understanding that they're affected",
"@sigmavirus24 Thank you for the comment but I disagree this is a wanted behavior. The current status of Session breaks the usage of pip when behind a proxy and the change I proposed is not the same as in #5735. My change keeps the hierarchy the way it should be as already mentioned in the documentation.\r\n\r\nThe biggest problem right now is that when you use \r\n\r\n `pip install package --proxy=http\\\\:proxy_url` \r\n\r\nThe way they inject proxy to request is by creating a session object and setting the proprety proxies to it:\r\n```\r\nfrom requests import Request, Session\r\n\r\nproxies = { \"http\" : http_proxy, \"https\" : https_proxy}\r\nsession = Session()\r\nsession.proxies = proxies\r\nsession.request(url)\r\n````\r\n\r\nThe piece of code above doesn't work as expected in many proxy environments, because Request is actually overriding the given proxies by the system proxies and due to changes in urlib3 it doesn't work if you are doing an HTTPS request using an HTTP proxy server. Many developers can't directly change environment proxy. Thus, due to this problem newer versions of pip (> 20.2.x) can't install packages using the proxy. \r\n\r\nI agree that pip could solve that by giving the proxy directly to request like: \r\n\r\n```\r\nfrom requests import Request, Session\r\n\r\nproxies = { \"http\" : http_proxy, \"https\" : https_proxy}\r\nsession = Session()\r\nsession.proxies = proxies\r\nsession.request(url, proxies)\r\n````\r\n\r\nAlthough, since you allow to set proxies like: `session.proxies = proxies` that SHOULD be respected. \r\nSaying that I don't see how my proposed change would break anything, since I pinpoint the problem of overriding the proxy. I would please ask for careful consideration on this change.",
"> Thank you for the comment but I disagree this is a wanted behavior.\r\n\r\nNever said wanted. I said unknowingly relied upon. An application is working today that very well may break in confusing and unexpected ways after releasing this. The behaviour is wrong, we intend to fix it in a deliberately breaking release when we can dedicate time towards such a development effort. It's not something we can fix in the 2.x release series.\r\n\r\nThis change has been carefully considered for as long as the original PR has been open."
] |
https://api.github.com/repos/psf/requests/issues/5981
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5981/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5981/comments
|
https://api.github.com/repos/psf/requests/issues/5981/events
|
https://github.com/psf/requests/issues/5981
| 1,057,478,341 |
I_kwDOABTKOs4_B9bF
| 5,981 |
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/74422652?v=4",
"events_url": "https://api.github.com/users/skakarl2/events{/privacy}",
"followers_url": "https://api.github.com/users/skakarl2/followers",
"following_url": "https://api.github.com/users/skakarl2/following{/other_user}",
"gists_url": "https://api.github.com/users/skakarl2/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/skakarl2",
"id": 74422652,
"login": "skakarl2",
"node_id": "MDQ6VXNlcjc0NDIyNjUy",
"organizations_url": "https://api.github.com/users/skakarl2/orgs",
"received_events_url": "https://api.github.com/users/skakarl2/received_events",
"repos_url": "https://api.github.com/users/skakarl2/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/skakarl2/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skakarl2/subscriptions",
"type": "User",
"url": "https://api.github.com/users/skakarl2",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-11-18T15:19:09Z
|
2021-11-18T17:40:04Z
|
2021-11-18T17:40:03Z
|
NONE
| null |
When running a python program, I see the following error: It is only happening sometimes, not sure why.
One thing I found is using requests 2.5.3, fixes this issue - but using latest versions like 2.22.0 throws the above error.
I looked into code difference and found there's no else condition in adapters.py in latest versions of requests (it is present in 2.5.3). It looks like a bug to me. Is that intentional? If so, how can I solve this issue?
This is the error and else condition that's missing:
```
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python3/dist-packages/requests/sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python3/dist-packages/requests/sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python3/dist-packages/requests/adapters.py", line 498, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
```
```
else:
# All is well, return the connection to the pool.
conn._put_conn(low_conn)
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5981/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5981/timeline
| null |
completed
| null | null | false |
[
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/5980
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5980/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5980/comments
|
https://api.github.com/repos/psf/requests/issues/5980/events
|
https://github.com/psf/requests/issues/5980
| 1,055,764,314 |
I_kwDOABTKOs4-7a9a
| 5,980 |
requests error
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/84902162?v=4",
"events_url": "https://api.github.com/users/ABIRHOSSAIN10/events{/privacy}",
"followers_url": "https://api.github.com/users/ABIRHOSSAIN10/followers",
"following_url": "https://api.github.com/users/ABIRHOSSAIN10/following{/other_user}",
"gists_url": "https://api.github.com/users/ABIRHOSSAIN10/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ABIRHOSSAIN10",
"id": 84902162,
"login": "ABIRHOSSAIN10",
"node_id": "MDQ6VXNlcjg0OTAyMTYy",
"organizations_url": "https://api.github.com/users/ABIRHOSSAIN10/orgs",
"received_events_url": "https://api.github.com/users/ABIRHOSSAIN10/received_events",
"repos_url": "https://api.github.com/users/ABIRHOSSAIN10/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ABIRHOSSAIN10/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ABIRHOSSAIN10/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ABIRHOSSAIN10",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-11-17T06:37:10Z
|
2022-02-15T07:00:19Z
|
2021-11-17T06:57:10Z
|
NONE
|
resolved
|
File "/storage/emulated/0/fb-vedio.py", line 3, in <module>
import requests
File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/requests/__init__.py", line 133, in <module>
from . import utils
File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/requests/utils.py", line 28, in <module>
from ._internal_utils import to_native_string
File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/requests/_internal_utils.py", line 11, in <module>
from .compat import is_py2, builtin_str, str
File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/requests/compat.py", line 63, in <module>
from http import cookiejar as cookielib
File "/data/data/com.termux/files/usr/lib/python3.10/http/cookiejar.py", line 32, in <module>
import copy
File "/storage/emulated/0/copy.py", line 2, in <module>
from uncompyle6.main import decompile
File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/uncompyle6/__init__.py", line 50, in <module>
import uncompyle6.semantics.pysource
File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/uncompyle6/semantics/pysource.py", line 138, in <module>
from xdis import iscode, COMPILER_FLAG_BIT
File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/xdis/__init__.py", line 48, in <module>
from xdis.codetype import (
File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/xdis/codetype/__init__.py", line 21, in <module>
from xdis.codetype.code13 import *
File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/xdis/codetype/code13.py", line 19, in <module>
from copy import deepcopy
ImportError: cannot import name 'deepcopy' from partially initialized module 'copy' (most likely due to a circular import) (/storage/emulated/0/copy.py)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5980/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5980/timeline
| null |
completed
| null | null | false |
[
"Hi there @ABIRHOSSAIN10. This is not a defect with Requests, you have a local file overriding the stdlib copy module."
] |
https://api.github.com/repos/psf/requests/issues/5979
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5979/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5979/comments
|
https://api.github.com/repos/psf/requests/issues/5979/events
|
https://github.com/psf/requests/issues/5979
| 1,053,579,849 |
I_kwDOABTKOs4-zFpJ
| 5,979 |
#homedesign
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/93985775?v=4",
"events_url": "https://api.github.com/users/jimmysisonlucas/events{/privacy}",
"followers_url": "https://api.github.com/users/jimmysisonlucas/followers",
"following_url": "https://api.github.com/users/jimmysisonlucas/following{/other_user}",
"gists_url": "https://api.github.com/users/jimmysisonlucas/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jimmysisonlucas",
"id": 93985775,
"login": "jimmysisonlucas",
"node_id": "U_kgDOBZob7w",
"organizations_url": "https://api.github.com/users/jimmysisonlucas/orgs",
"received_events_url": "https://api.github.com/users/jimmysisonlucas/received_events",
"repos_url": "https://api.github.com/users/jimmysisonlucas/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jimmysisonlucas/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimmysisonlucas/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jimmysisonlucas",
"user_view_type": "public"
}
|
[
{
"color": "d16014",
"default": false,
"description": "",
"id": 2392364523,
"name": "spam",
"node_id": "MDU6TGFiZWwyMzkyMzY0NTIz",
"url": "https://api.github.com/repos/psf/requests/labels/spam"
}
] |
closed
| true | null |
[] | null | 1 |
2021-11-15T11:57:15Z
|
2021-11-15T12:26:57Z
|
2021-11-15T12:26:39Z
|
NONE
|
spam
|
<!-- Summary. -->
## Expected Result
<!-- What you expected. -->
## Actual Result
<!-- What happened instead. -->
## Reproduction Steps
```python
import requests
```
## System Information
$ python -m requests.help
```json
{
"paste": "here"
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5979/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5979/timeline
| null |
completed
| null | null | false |
[
"I hope i fix this issues"
] |
https://api.github.com/repos/psf/requests/issues/5978
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5978/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5978/comments
|
https://api.github.com/repos/psf/requests/issues/5978/events
|
https://github.com/psf/requests/pull/5978
| 1,052,831,266 |
PR_kwDOABTKOs4uffvF
| 5,978 |
mention all_proxy env variable in Proxies section
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/92833633?v=4",
"events_url": "https://api.github.com/users/sha016/events{/privacy}",
"followers_url": "https://api.github.com/users/sha016/followers",
"following_url": "https://api.github.com/users/sha016/following{/other_user}",
"gists_url": "https://api.github.com/users/sha016/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sha016",
"id": 92833633,
"login": "sha016",
"node_id": "U_kgDOBYiHYQ",
"organizations_url": "https://api.github.com/users/sha016/orgs",
"received_events_url": "https://api.github.com/users/sha016/received_events",
"repos_url": "https://api.github.com/users/sha016/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sha016/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sha016/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sha016",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-11-14T03:03:25Z
|
2022-05-03T18:05:37Z
|
2022-02-02T18:03:26Z
|
CONTRIBUTOR
|
resolved
|
Closes #5558
I also clarified that only one of those environment variables needs to be set.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5978/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5978/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5978.diff",
"html_url": "https://github.com/psf/requests/pull/5978",
"merged_at": "2022-02-02T18:03:26Z",
"patch_url": "https://github.com/psf/requests/pull/5978.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5978"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5977
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5977/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5977/comments
|
https://api.github.com/repos/psf/requests/issues/5977/events
|
https://github.com/psf/requests/issues/5977
| 1,052,750,596 |
I_kwDOABTKOs4-v7ME
| 5,977 |
Not getting cookies from `localhost`
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/56031107?v=4",
"events_url": "https://api.github.com/users/kraktus/events{/privacy}",
"followers_url": "https://api.github.com/users/kraktus/followers",
"following_url": "https://api.github.com/users/kraktus/following{/other_user}",
"gists_url": "https://api.github.com/users/kraktus/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kraktus",
"id": 56031107,
"login": "kraktus",
"node_id": "MDQ6VXNlcjU2MDMxMTA3",
"organizations_url": "https://api.github.com/users/kraktus/orgs",
"received_events_url": "https://api.github.com/users/kraktus/received_events",
"repos_url": "https://api.github.com/users/kraktus/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kraktus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kraktus/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kraktus",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2021-11-13T19:14:27Z
|
2022-03-14T22:00:36Z
|
2021-12-14T21:27:13Z
|
NONE
|
resolved
|
Hello,
This is a follow up on https://github.com/psf/requests/issues/4643, which was closed without a fix. The issue is that `requests` does not get cookies from `localhost`. I could reproduce on `2.26.0`.
I'm reposting the POC from https://github.com/psf/requests/issues/4643#issuecomment-744409050, which was added after the issue was closed.
```py
import pytest
import threading
import requests
from tests.testserver.server import Server, consume_socket_content
def test_cookie_set_for_localhost():
def response_handler(sock):
consume_socket_content(sock, timeout=0.5)
host, port = sock.getsockname()
sock.send(
b'HTTP/1.1 200 OK\r\n'
b'Content-Length: 0\r\n'
b'Set-Cookie: foo=bar; Max-Age=86400; Domain=localhost; Secure; HttpOnly\r\n\r\n'
# b'Set-Cookie: foo=bar; Max-Age=86400; Domain=localhost:' + str(port).encode('ascii') + b'; Secure; HttpOnly\r\n\r\n' # does not help
)
close_server = threading.Event()
server = Server(response_handler, wait_to_close_event=close_server)
with server as (host, port):
url = 'http://{0}:{1}/'.format(host, port)
r = requests.get(url)
assert r.status_code == 200
print(host, port)
# Verify we received our expected cookie
assert r.cookies
assert r.cookies.get('foo') == 'bar'
close_server.set()
```
It is unclear how https://github.com/psf/requests/issues/5388 could get them.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5977/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5977/timeline
| null |
completed
| null | null | false |
[
"I don't think this is actually request's bug. It looks like Python's [CookieJar.extract_cookies](https://docs.python.org/3/library/http.cookiejar.html#http.cookiejar.CookieJar.extract_cookies) doesn't parse them properly.",
"Ok, this is not a bug, this is a feature: https://stackoverflow.com/questions/1134290/cookies-on-localhost-with-explicit-domain/32210291#32210291",
"Thanks for looking into the issue.\r\n\r\nI doubt it’s a feature or the SoF answer is largely inaccurate since latest version of Chrome/FireFox andSafari stored the cookies on the website I had tested but requests did not.",
"I've opened a bug report and wrote a possible solution: https://bugs.python.org/issue46075\r\nHowever, since this is, definitely not a requests bug, this issue should probably be closed",
"Thank you 👍 \r\n"
] |
https://api.github.com/repos/psf/requests/issues/5976
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5976/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5976/comments
|
https://api.github.com/repos/psf/requests/issues/5976/events
|
https://github.com/psf/requests/issues/5976
| 1,052,643,410 |
I_kwDOABTKOs4-vhBS
| 5,976 |
Proxy with authentication does not halt after upgrading to latest version
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/35755741?v=4",
"events_url": "https://api.github.com/users/adrian-kong/events{/privacy}",
"followers_url": "https://api.github.com/users/adrian-kong/followers",
"following_url": "https://api.github.com/users/adrian-kong/following{/other_user}",
"gists_url": "https://api.github.com/users/adrian-kong/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/adrian-kong",
"id": 35755741,
"login": "adrian-kong",
"node_id": "MDQ6VXNlcjM1NzU1NzQx",
"organizations_url": "https://api.github.com/users/adrian-kong/orgs",
"received_events_url": "https://api.github.com/users/adrian-kong/received_events",
"repos_url": "https://api.github.com/users/adrian-kong/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/adrian-kong/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adrian-kong/subscriptions",
"type": "User",
"url": "https://api.github.com/users/adrian-kong",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-11-13T09:53:37Z
|
2022-02-11T14:00:35Z
|
2021-11-13T13:50:51Z
|
NONE
|
resolved
|
I'm not sure if this is a bug but when I upgraded to 2.26.0 proxy doesn't authenticate or something
The code works fine on 2.6.0 but when I have it on 2.26.0, it doesn't give any output or crash.
One thing that I found was urllib3 version 1.24.3 works fine but 1.26.6 doesn't.
## Expected Result
An output / termination of the program
## Actual Result
Nothing outputs and looks like it runs forever
## Reproduction Steps
```python
import requests
# the proxy with authentication
p = "user:pass@ip:port"
proxy = {
"http": "http://" + p,
"https": "https://" + p
}
# any url
url = ""
# this statement doesn't halt
requests.get(url, proxies=proxy)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.4"
},
"cryptography": {
"version": "3.4.7"
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.8.6"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "101010bf",
"version": "20.0.1"
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010107f"
},
"urllib3": {
"version": "1.26.6"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5976/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5976/timeline
| null |
completed
| null | null | false |
[
"Try\r\n\r\n```py\r\n\r\nproxy = {\r\n \"http\": \"http://\" + p,\r\n \"https\": \"http://\" + p\r\n}\r\n```",
"See also #5843 and issues linked from there"
] |
https://api.github.com/repos/psf/requests/issues/5975
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5975/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5975/comments
|
https://api.github.com/repos/psf/requests/issues/5975/events
|
https://github.com/psf/requests/issues/5975
| 1,052,405,538 |
I_kwDOABTKOs4-um8i
| 5,975 |
Request doesn't provide a way to refresh headers for each retry, making it impossible to regenerate expired Authorization headers
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1441066?v=4",
"events_url": "https://api.github.com/users/vitaly-krugl/events{/privacy}",
"followers_url": "https://api.github.com/users/vitaly-krugl/followers",
"following_url": "https://api.github.com/users/vitaly-krugl/following{/other_user}",
"gists_url": "https://api.github.com/users/vitaly-krugl/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vitaly-krugl",
"id": 1441066,
"login": "vitaly-krugl",
"node_id": "MDQ6VXNlcjE0NDEwNjY=",
"organizations_url": "https://api.github.com/users/vitaly-krugl/orgs",
"received_events_url": "https://api.github.com/users/vitaly-krugl/received_events",
"repos_url": "https://api.github.com/users/vitaly-krugl/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vitaly-krugl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vitaly-krugl/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vitaly-krugl",
"user_view_type": "public"
}
|
[] |
open
| false | null |
[] | null | 10 |
2021-11-12T21:02:34Z
|
2023-07-18T02:03:47Z
| null |
NONE
| null |
I am using requests 2.23.0 with Python 3.8.
My app configures the `requests.packages.urllib3.util.retry.Retry` instance and then passes it via the `max_retries` arg to `requests.adapters.HTTPAdapter` constructor and then mounts the adapter as follows:
```
class RetriableSslSession(requests.Session):
def __init__(self):
super(RetriableSslSession, self).__init__()
self.mount('https://', create_default_ssl_adapter())
```
Then before making a request, my app sets `session.auth` to an instance of [EdgeGridAuth](https://github.com/akamai/AkamaiOPEN-edgegrid-python/blob/master/akamai/edgegrid/edgegrid.py) that is derived from `requests.auth.AuthBase`.
Since EdgeGridAuth implements the [AuthBase.\_\_call\_\_](https://github.com/akamai/AkamaiOPEN-edgegrid-python/blob/bbfd58b75a61684ef72e29d2dab2e81492b3f4cb/akamai/edgegrid/edgegrid.py#L257) method, I expected that the Authorization header would be generated for each retry. However, in our apache proxy logs, we're seeing the same Authorization header reused from time to time, which suggests that retries are not causing the Authorization header to be generated.
Could you please let me know what I may be doing wrong and explain how to cause the Authorization header to be re-generated for each Retry?
| null |
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5975/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5975/timeline
| null | null | null | null | false |
[
"Hi @vitaly-krugl, to clarify your issue, you're seeing the same Authorization reused in _all_ retries or is the issue intermittent?\r\n\r\nIf it's consistent, can you provide a simple reproduction using only code from Requests and urllib3? That will help rule out issues in your Auth, Session, and Retry implementations. If it's intermittent, we'll need more info around the retries and what triggered them. That will help identify if this is in fact a bug in Requests.",
"@nateprewitt - per your understanding, is the auth hook (`AuthBase.__call__()`) supposed to be called for each retry attempt?",
"I believe your auth hook should only be invoked [here](https://github.com/psf/requests/blob/main/requests/models.py#L557-L558) which happens during request preparation unless otherwise invoked directly.\r\n\r\nIf your Adapter isn't handling anything with retries and relies solely on urllib3, I wouldn't expect auth to be recomputed.",
"> If your Adapter isn't handling anything with retries and relies solely on urllib3, I wouldn't expect auth to be recomputed.\r\n\r\nThis is 100% correct. You're operating at 2 different levels",
"Thank you all for confirming that my current retry configuration approach doesn't facilitate re-computation of auth upon each retry. In this case, what is the correct way to configure retries and auth so that auth will be recomputed upon each retry?\r\n\r\nKnown working doc links/example links would be much appreciated! Thank you in advance.",
"I also added the [comment](https://github.com/urllib3/urllib3/issues/1172#issuecomment-969509640) in the urllib3 [issue](https://github.com/urllib3/urllib3/issues/1172) asking for additional hooks in urllib3 that would enable python-requests to add support for updating auth during retries.",
"Without knowing what you're telling urllib3 to retry or what the exact behavior is of your service we can't help you and support requests are best asked on Stack overflow. ",
"(cc @sigmavirus24)\r\n\r\nI need the `AuthBase.__call__` method of the [EdgeGridAuth](https://github.com/akamai/AkamaiOPEN-edgegrid-python/blob/master/akamai/edgegrid/edgegrid.py) instance which I assign to `session.auth` to be called for each retry attempt that is attempted as the result of the urllib3 Retry instance that I assigned as outlined in the description section of this issue in order to re-generate the Authorization header.\r\n\r\nThe reason for this requirement is that the Authorization header value has a short TTL, so it needs to be regenerated for **each** retry attempt and the new value of the Authorization header needs to be used by urllib3 when it's sending the corresponding retry request to the server.\r\n\r\nThe Retry instance is configured as follows:\r\n```\r\nurllib3_retry.Retry(\r\n total=DEFAULT_MAX_TOTAL_RETRIES,\r\n connect=DEFAULT_MAX_CONNECTION_RETRIES,\r\n read=DEFAULT_MAX_READ_RETRIES,\r\n redirect=0,\r\n method_whitelist= frozenset(\r\n {'PUT', 'GET', 'OPTIONS', 'HEAD', 'DELETE', 'TRACE'}),\r\n status_forcelist= frozenset(\r\n {429, 500, 501, 502, 503, 504, 505, 506, 507, 509, 510, 598}),\r\n backoff_factor=1/10000,\r\n raise_on_redirect=False,\r\n raise_on_status=False)\r\n```",
"I have the same problem. I'm hitting an API that requires an `Auth-Signature` header, which is a signed hexdigest using a nonce based on the UNIX value of now. In the last retry, the signature is already expired. It would be great if there was a way to recalculate a header value on each retry. ",
"Dear maintainers, is there a solution in the works for this?\r\n"
] |
https://api.github.com/repos/psf/requests/issues/5974
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5974/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5974/comments
|
https://api.github.com/repos/psf/requests/issues/5974/events
|
https://github.com/psf/requests/pull/5974
| 1,050,796,592 |
PR_kwDOABTKOs4uZcEf
| 5,974 |
[Preview] Pyodide shimming of requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2715782?v=4",
"events_url": "https://api.github.com/users/bartbroere/events{/privacy}",
"followers_url": "https://api.github.com/users/bartbroere/followers",
"following_url": "https://api.github.com/users/bartbroere/following{/other_user}",
"gists_url": "https://api.github.com/users/bartbroere/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bartbroere",
"id": 2715782,
"login": "bartbroere",
"node_id": "MDQ6VXNlcjI3MTU3ODI=",
"organizations_url": "https://api.github.com/users/bartbroere/orgs",
"received_events_url": "https://api.github.com/users/bartbroere/received_events",
"repos_url": "https://api.github.com/users/bartbroere/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bartbroere/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bartbroere/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bartbroere",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-11-11T09:55:24Z
|
2022-02-09T11:07:21Z
|
2021-11-11T09:55:37Z
|
NONE
|
resolved
| null |
{
"avatar_url": "https://avatars.githubusercontent.com/u/2715782?v=4",
"events_url": "https://api.github.com/users/bartbroere/events{/privacy}",
"followers_url": "https://api.github.com/users/bartbroere/followers",
"following_url": "https://api.github.com/users/bartbroere/following{/other_user}",
"gists_url": "https://api.github.com/users/bartbroere/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bartbroere",
"id": 2715782,
"login": "bartbroere",
"node_id": "MDQ6VXNlcjI3MTU3ODI=",
"organizations_url": "https://api.github.com/users/bartbroere/orgs",
"received_events_url": "https://api.github.com/users/bartbroere/received_events",
"repos_url": "https://api.github.com/users/bartbroere/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bartbroere/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bartbroere/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bartbroere",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5974/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5974/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5974.diff",
"html_url": "https://github.com/psf/requests/pull/5974",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5974.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5974"
}
| true |
[
"Apologies, I meant to create this on my own fork",
"Very nice"
] |
https://api.github.com/repos/psf/requests/issues/5973
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5973/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5973/comments
|
https://api.github.com/repos/psf/requests/issues/5973/events
|
https://github.com/psf/requests/issues/5973
| 1,047,455,137 |
I_kwDOABTKOs4-buWh
| 5,973 |
Possible to use pycryptodome rather than pycrypto 2.6.1?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/93924643?v=4",
"events_url": "https://api.github.com/users/githubber1971/events{/privacy}",
"followers_url": "https://api.github.com/users/githubber1971/followers",
"following_url": "https://api.github.com/users/githubber1971/following{/other_user}",
"gists_url": "https://api.github.com/users/githubber1971/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/githubber1971",
"id": 93924643,
"login": "githubber1971",
"node_id": "U_kgDOBZktIw",
"organizations_url": "https://api.github.com/users/githubber1971/orgs",
"received_events_url": "https://api.github.com/users/githubber1971/received_events",
"repos_url": "https://api.github.com/users/githubber1971/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/githubber1971/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/githubber1971/subscriptions",
"type": "User",
"url": "https://api.github.com/users/githubber1971",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-11-08T13:32:02Z
|
2022-02-06T15:00:25Z
|
2021-11-08T13:47:49Z
|
NONE
|
resolved
|
Requests seems to be installing the dependency pycrypto 2.6.1.
I'd rather use pycryptodome. Is this possible?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5973/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5973/timeline
| null |
completed
| null | null | false |
[
"Requests doesn't use [pycrypto](https://github.com/psf/requests/blob/main/setup.py#L43) as a dependency. We use \"cryptography\" indirectly through pyOpenSSL in old versions of Requests. Closing this as N/A.",
"Thanks @sethmlarson \r\n\r\nIt must be coming from somewhere else…\r\n\r\n```\r\nroot@ba2d298de6ea:/src# cat /tmp/requirements.txt \r\nrequests\r\nroot@ba2d298de6ea:/src# pip3 freeze\r\nasn1crypto==0.24.0\r\ncertifi==2021.10.8\r\ncharset-normalizer==2.0.7\r\ncryptography==2.1.4\r\nidna==2.6\r\nkeyring==10.6.0\r\nkeyrings.alt==3.0\r\npycrypto==2.6.1\r\npygobject==3.26.1\r\npyxdg==0.25\r\nrequests==2.26.0\r\nSecretStorage==2.3.1\r\nsix==1.11.0\r\nurllib3==1.26.7\r\nroot@ba2d298de6ea:/src# \r\n```",
"For anyone else that thought it came from requests...\r\n\r\n```\r\nroot@ ba2d298de6ea:/src# apt remove python3-crypto\r\nReading package lists... Done\r\nBuilding dependency tree \r\nReading state information... Done\r\nThe following packages will be REMOVED:\r\n python3-crypto python3-keyrings.alt\r\n0 upgraded, 0 newly installed, 2 to remove and 0 not upgraded.\r\nAfter this operation, 1507 kB disk space will be freed.\r\nDo you want to continue? [Y/n] Y\r\n(Reading database ... 33231 files and directories currently installed.)\r\nRemoving python3-keyrings.alt (3.0-1) ...\r\nRemoving python3-crypto (2.6.1-8ubuntu2) ...\r\nroot@ ba2d298de6ea:/src# exit\r\n```"
] |
https://api.github.com/repos/psf/requests/issues/5972
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5972/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5972/comments
|
https://api.github.com/repos/psf/requests/issues/5972/events
|
https://github.com/psf/requests/issues/5972
| 1,043,737,517 |
I_kwDOABTKOs4-Niut
| 5,972 |
support TLS Encrypted ClientHello (ECH) and HTTPS/SVCB
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/143465?v=4",
"events_url": "https://api.github.com/users/eighthave/events{/privacy}",
"followers_url": "https://api.github.com/users/eighthave/followers",
"following_url": "https://api.github.com/users/eighthave/following{/other_user}",
"gists_url": "https://api.github.com/users/eighthave/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eighthave",
"id": 143465,
"login": "eighthave",
"node_id": "MDQ6VXNlcjE0MzQ2NQ==",
"organizations_url": "https://api.github.com/users/eighthave/orgs",
"received_events_url": "https://api.github.com/users/eighthave/received_events",
"repos_url": "https://api.github.com/users/eighthave/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eighthave/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eighthave/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eighthave",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-11-03T15:21:59Z
|
2022-02-02T08:00:34Z
|
2021-11-03T17:16:31Z
|
NONE
|
resolved
|
The next version of the IETF-standardized TLS protocol is known as Encrypted ClientHello (ECH) [0] formerly known as Encrypted SNI (ESNI). There is a related standard known a SVCB or DNS HTTPS RR Type [8]. This ticket is to collect information for what (if anything) is required for Requests to support ECH and HTTPS/SVCB. The Python `ssl` module will handle the core bits of ECH. ECH adds a new key to the TLS exchange, and the recommended way to get that key is from HTTPS/SVCB DNS queries. It is not yet clear where the right place to handle that DNS is [1]. ECH works in conjunction with the new DNS RR Types HTTPS and SVCB. This means that DNS needs to be handled a bit differently for connections that use HTTPS/SVCB.
ECH is built on top of TLSv1.3 and completes the unfinished work from the TLSv1.3 effort. It is now in draft-13 and there are many implementations that are interoperating. ECH is working for openssl[2], boringssl[3], nginx, Apache HTTPD, lighttpd, HAProxy, Conscrypt[4], curl, and more. There is work underway in Firefox [5] and Chromium [6]. It has been sketched out for OkHTTP [7]. Draft versions of ESNI and ECH have been deployed in Firefox releases and some production web services.
One approach would be to implement the DNS pieces in Requests, and the ECH pieces in the `ssl` module. That means potentially implementing:
* HTTPS/SVCB DNS queries for getting ECH Config Lists.
* A way to provide ECH Config Lists as bytes directly to the `ssl` module.
* A method to ensure encrypted DNS is used so all metadata is encrypted.
* A callback that gets called whenever ECH negotiation fails and the server offers a "Retry Config".
FYI, the TLS WG maintain a page with information about other implementations:
https://github.com/tlswg/draft-ietf-tls-esni/wiki/Implementations
[0] https://www.ietf.org/archive/id/draft-ietf-tls-esni-13.html
[1] https://bugs.python.org/issue45567
[2] https://github.com/openssl/openssl/issues/7482
[3] https://bugs.chromium.org/p/boringssl/issues/detail?id=275
[5] https://bugzilla.mozilla.org/show_bug.cgi?id=1725938
[6] https://bugs.chromium.org/p/chromium/issues/detail?id=1091403
[6] https://github.com/google/conscrypt/issues/730
[7] https://github.com/square/okhttp/issues/6539
[8] https://www.ietf.org/archive/id/draft-ietf-dnsop-svcb-https-07.html
[9] https://github.com/sftcd/openssl
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 2,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/5972/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5972/timeline
| null |
completed
| null | null | false |
[
"Thanks for opening this issue. Unfortunately this is likely not the correct location to open this issue at this time. Requests uses urllib3 under the hood which uses Python's TLS stack which is built on OpenSSL. For us to take advantage of any of these features we'd need:\r\n\r\n- Support in OpenSSL\r\n- Support in Python's `ssl` module\r\n- Likely explicit support in urllib3\r\n- Then finally can add support in Requests.\r\n\r\nYou can start advocating for these features' inclusion in the projects listed above in order, but without support in the project above it the project below cannot do anything yet. Hope this makes sense, closing for now.",
"Makes sense. openssl has been implemented with some review from openssl \nmaintainers. They want to support ECH, but won't merge until its RFC. Python \nssl wants to support ECH and is waiting on openssl. I opened this here because \nin the Python ssl issue, they said that clients should handle the DNS. The IETF \nprocess is at the point where we need feedback on interoperability, that's why \nI'm bringing this up even though the RFC hasn't been issued and the other pieces \nare not yet in place.\n\nShould I open an issue in urllib3 now?\n"
] |
https://api.github.com/repos/psf/requests/issues/5971
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5971/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5971/comments
|
https://api.github.com/repos/psf/requests/issues/5971/events
|
https://github.com/psf/requests/pull/5971
| 1,043,038,792 |
PR_kwDOABTKOs4uA4KW
| 5,971 |
Reusing SSLContext in a session
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/69120418?v=4",
"events_url": "https://api.github.com/users/echo4eva/events{/privacy}",
"followers_url": "https://api.github.com/users/echo4eva/followers",
"following_url": "https://api.github.com/users/echo4eva/following{/other_user}",
"gists_url": "https://api.github.com/users/echo4eva/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/echo4eva",
"id": 69120418,
"login": "echo4eva",
"node_id": "MDQ6VXNlcjY5MTIwNDE4",
"organizations_url": "https://api.github.com/users/echo4eva/orgs",
"received_events_url": "https://api.github.com/users/echo4eva/received_events",
"repos_url": "https://api.github.com/users/echo4eva/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/echo4eva/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/echo4eva/subscriptions",
"type": "User",
"url": "https://api.github.com/users/echo4eva",
"user_view_type": "public"
}
|
[] |
closed
| false | null |
[] | null | 1 |
2021-11-03T03:13:54Z
|
2024-05-19T19:06:42Z
|
2024-05-19T19:06:41Z
|
NONE
| null |
A pull request to take a hit at fixing issue #4322
Worked with my team and we made it so that HTTPAdapter has a default SSLContext initialized when the adapter is constructed. SSLContext is made by using urllib3's function to create context. The context is passed into the poolmanager as pool_kwargs which can take in SSLContext.
Tested the reuse of SSLContext by using jmcackle's test functions they've made for adapters.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/5971/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5971/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5971.diff",
"html_url": "https://github.com/psf/requests/pull/5971",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5971.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5971"
}
| true |
[
"I believe this ended up addressed in 9a40d1277807f0a4f26c9a37eea8ec90faa8aadc."
] |
https://api.github.com/repos/psf/requests/issues/5970
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5970/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5970/comments
|
https://api.github.com/repos/psf/requests/issues/5970/events
|
https://github.com/psf/requests/pull/5970
| 1,042,925,793 |
PR_kwDOABTKOs4uAhIv
| 5,970 |
test
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/16504844?v=4",
"events_url": "https://api.github.com/users/YNathan/events{/privacy}",
"followers_url": "https://api.github.com/users/YNathan/followers",
"following_url": "https://api.github.com/users/YNathan/following{/other_user}",
"gists_url": "https://api.github.com/users/YNathan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/YNathan",
"id": 16504844,
"login": "YNathan",
"node_id": "MDQ6VXNlcjE2NTA0ODQ0",
"organizations_url": "https://api.github.com/users/YNathan/orgs",
"received_events_url": "https://api.github.com/users/YNathan/received_events",
"repos_url": "https://api.github.com/users/YNathan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/YNathan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/YNathan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/YNathan",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-11-02T23:07:20Z
|
2022-02-01T00:00:43Z
|
2021-11-02T23:11:33Z
|
NONE
|
resolved
| null |
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5970/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5970/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5970.diff",
"html_url": "https://github.com/psf/requests/pull/5970",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5970.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5970"
}
| true |
[
"Looks like this was opened in error."
] |
https://api.github.com/repos/psf/requests/issues/5969
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5969/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5969/comments
|
https://api.github.com/repos/psf/requests/issues/5969/events
|
https://github.com/psf/requests/issues/5969
| 1,042,735,190 |
I_kwDOABTKOs4-JuBW
| 5,969 |
"OverflowError: signed integer is greater than maximum" when streaming download
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/667076?v=4",
"events_url": "https://api.github.com/users/Pilen/events{/privacy}",
"followers_url": "https://api.github.com/users/Pilen/followers",
"following_url": "https://api.github.com/users/Pilen/following{/other_user}",
"gists_url": "https://api.github.com/users/Pilen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Pilen",
"id": 667076,
"login": "Pilen",
"node_id": "MDQ6VXNlcjY2NzA3Ng==",
"organizations_url": "https://api.github.com/users/Pilen/orgs",
"received_events_url": "https://api.github.com/users/Pilen/received_events",
"repos_url": "https://api.github.com/users/Pilen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Pilen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Pilen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Pilen",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2021-11-02T19:30:51Z
|
2022-04-02T18:00:18Z
|
2022-01-02T17:44:28Z
|
NONE
|
resolved
|
I was trying to download a 3GB using requests, to avoid having it all in memory i wanted to stream it and save the chunks to a file manually.
Unfortunately I got the following exception
```
---------------------------------------------------------------------------
OverflowError Traceback (most recent call last)
<ipython-input-7-bc1ab118995a> in <module>
----> 1 next(it)
/opt/venvs/venv2/lib/python3.8/site-packages/requests/models.py in generate()
756 if hasattr(self.raw, 'stream'):
757 try:
--> 758 for chunk in self.raw.stream(chunk_size, decode_content=True):
759 yield chunk
760 except ProtocolError as e:
/opt/venvs/venv2/lib/python3.8/site-packages/urllib3/response.py in stream(self, amt, decode_content)
574 else:
575 while not is_fp_closed(self._fp):
--> 576 data = self.read(amt=amt, decode_content=decode_content)
577
578 if data:
/opt/venvs/venv2/lib/python3.8/site-packages/urllib3/response.py in read(self, amt, decode_content, cache_content)
513 if amt is None:
514 # cStringIO doesn't like amt=None
--> 515 data = self._fp.read() if not fp_closed else b""
516 flush_decoder = True
517 else:
/usr/lib/python3.8/http/client.py in read(self, amt)
469 else:
470 try:
--> 471 s = self._safe_read(self.length)
472 except IncompleteRead:
473 self._close_conn()
/usr/lib/python3.8/http/client.py in _safe_read(self, amt)
610 IncompleteRead exception can be used to detect the problem.
611 """
--> 612 data = self.fp.read(amt)
613 if len(data) < amt:
614 raise IncompleteRead(data, amt-len(data))
/usr/lib/python3.8/socket.py in readinto(self, b)
667 while True:
668 try:
--> 669 return self._sock.recv_into(b)
670 except timeout:
671 self._timeout_occurred = True
/usr/lib/python3.8/ssl.py in recv_into(self, buffer, nbytes, flags)
1239 "non-zero flags not allowed in calls to recv_into() on %s" %
1240 self.__class__)
-> 1241 return self.read(nbytes, buffer)
1242 else:
1243 return super().recv_into(buffer, nbytes, flags)
/usr/lib/python3.8/ssl.py in read(self, len, buffer)
1097 try:
1098 if buffer is not None:
-> 1099 return self._sslobj.read(len, buffer)
1100 else:
1101 return self._sslobj.read(len)
OverflowError: signed integer is greater than maximum
```
My guess is that it has to do with 'Content-Length': '3221020463' being larger than 2**31\
combined with a file served over https, and using streaming and a `chunk_size = None`
## Reproduction Steps
```python
import requests
url = "https://dailymed-data.nlm.nih.gov/public-release-files/dm_spl_release_human_rx_part1.zip"
r = requests.get(url, stream=True)
it = r.iter_content(chunk_size=None)
next(it)
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.7"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.8.5"
},
"platform": {
"release": "5.4.0-48-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010106f"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5969/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5969/timeline
| null |
completed
| null | null | false |
[
"This seems like a bug, Requests and urllib3 should only ask for a maximum number of bytes that OpenSSL is capable of handling at once. Perhaps we need a cap on the resolved `chunk_size` to be `max(sys.maxsize, content_length)`?",
"Yeah, this one kind of surprises me, I'd expect OpenSSL to be buffering input here. I think your solution makes sense @sethmlarson, but where do you think it should live? Requests is just passing `None` which has `read()` return as many bytes as possible. We'd need to start \"chunking\" the chunk inside `urllib3/response.py` to actually be safe in these situations. Otherwise, we'll be implementing the fix at both layers.",
"@nateprewitt Yeah this should be fixed in urllib3, not Requests. Wish we could transfer issues to repositories in different organizations! I'll open a new issue and point to this one.",
"Created: https://github.com/urllib3/urllib3/issues/2513",
"Thanks @sethmlarson! I'll resolve this in favor of the urllib3 tracking ticket."
] |
https://api.github.com/repos/psf/requests/issues/5968
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5968/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5968/comments
|
https://api.github.com/repos/psf/requests/issues/5968/events
|
https://github.com/psf/requests/pull/5968
| 1,041,919,262 |
PR_kwDOABTKOs4t9kkR
| 5,968 |
Create PULL_REQUEST_TEMPLATE.md
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/91319186?v=4",
"events_url": "https://api.github.com/users/mjvbz/events{/privacy}",
"followers_url": "https://api.github.com/users/mjvbz/followers",
"following_url": "https://api.github.com/users/mjvbz/following{/other_user}",
"gists_url": "https://api.github.com/users/mjvbz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mjvbz",
"id": 91319186,
"login": "mjvbz",
"node_id": "MDQ6VXNlcjkxMzE5MTg2",
"organizations_url": "https://api.github.com/users/mjvbz/orgs",
"received_events_url": "https://api.github.com/users/mjvbz/received_events",
"repos_url": "https://api.github.com/users/mjvbz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mjvbz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mjvbz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mjvbz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-11-02T06:12:41Z
|
2022-01-31T14:00:37Z
|
2021-11-02T11:04:28Z
|
NONE
|
resolved
|
You have issue temaplet but i think you also need a pull request template so i created one oull request template at .github it may help you i commented some of the lines of the pull request template you can remove it from comment to code.
I think it may help you ☺☺
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5968/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5968/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5968.diff",
"html_url": "https://github.com/psf/requests/pull/5968",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5968.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5968"
}
| true |
[
"Hi @itsMeShon \r\n\r\nThanks for sending this but it doesn't fit our needs and the maintainers need to make a decision on what information we actually want in a PR template. We don't have a lot of time right now to discuss that and provide you that feedback, so I'm going to close this.",
"Welcome! If ypu say what type of template the maintainers need i will help you with that!! ☺☺"
] |
https://api.github.com/repos/psf/requests/issues/5967
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5967/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5967/comments
|
https://api.github.com/repos/psf/requests/issues/5967/events
|
https://github.com/psf/requests/issues/5967
| 1,041,083,137 |
I_kwDOABTKOs4-DasB
| 5,967 |
Disable url encoding for multipart/form data
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/26345930?v=4",
"events_url": "https://api.github.com/users/ogre2007/events{/privacy}",
"followers_url": "https://api.github.com/users/ogre2007/followers",
"following_url": "https://api.github.com/users/ogre2007/following{/other_user}",
"gists_url": "https://api.github.com/users/ogre2007/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ogre2007",
"id": 26345930,
"login": "ogre2007",
"node_id": "MDQ6VXNlcjI2MzQ1OTMw",
"organizations_url": "https://api.github.com/users/ogre2007/orgs",
"received_events_url": "https://api.github.com/users/ogre2007/received_events",
"repos_url": "https://api.github.com/users/ogre2007/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ogre2007/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ogre2007/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ogre2007",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-11-01T11:44:34Z
|
2022-02-27T17:01:07Z
|
2021-11-01T12:11:32Z
|
NONE
|
resolved
|
curl -F allows to upload multipart for raw data w/o encoding - as bytes
how to disable it for files being sent via `request.post(..., files = files)`?
I know that one can send it with `request.post(...data=data)`, but if you do so, there will be no special `Content-Disposition` and boundaries data, and you should put them on your own, thats not handy at all.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5967/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5967/timeline
| null |
completed
| null | null | false |
[
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here.",
"`Unfortunately, it seems this is a request for help instead of a report of a defect in the project`\r\nI tried to find answer there, but seems like requests lib lacks this feature, so in fact his is not only a request for help, but feature request too.",
"I'm very interested in a clarifacation or a better documentation regarding such cases. I ran into some problems exactly because of this issue.\r\nEDIT:\r\nFound this one: https://franklingu.github.io/programming/2017/10/30/post-multipart-form-data-using-requests/"
] |
https://api.github.com/repos/psf/requests/issues/5966
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5966/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5966/comments
|
https://api.github.com/repos/psf/requests/issues/5966/events
|
https://github.com/psf/requests/issues/5966
| 1,036,480,745 |
I_kwDOABTKOs49x3Dp
| 5,966 |
`requests.certs.where()` is inacurate
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/14947575?v=4",
"events_url": "https://api.github.com/users/nniehoff/events{/privacy}",
"followers_url": "https://api.github.com/users/nniehoff/followers",
"following_url": "https://api.github.com/users/nniehoff/following{/other_user}",
"gists_url": "https://api.github.com/users/nniehoff/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nniehoff",
"id": 14947575,
"login": "nniehoff",
"node_id": "MDQ6VXNlcjE0OTQ3NTc1",
"organizations_url": "https://api.github.com/users/nniehoff/orgs",
"received_events_url": "https://api.github.com/users/nniehoff/received_events",
"repos_url": "https://api.github.com/users/nniehoff/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nniehoff/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nniehoff/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nniehoff",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-10-26T15:58:05Z
|
2022-01-24T17:08:27Z
|
2021-10-26T16:27:33Z
|
NONE
|
resolved
|
Using a custom CA bundle as described in the docs I created an environment variable `REQUESTS_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt` and requests correctly uses this variable. However, `python3 -c "import requests; print(requests.certs.where())"` still returns the ca bundled with certifi. This is misleading
## Expected Result
I expected `python3 -c "import requests; print(requests.certs.where())"` to return `/etc/ssl/certs/ca-certificates.crt`.
## Actual Result
`python3 -c "import requests; print(requests.certs.where())"` returned `/usr/local/lib/python3.6/site-packages/certifi/cacert.pem`
## Reproduction Steps
```bash
export REQUESTS_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt
```
```python
import requests
print(requests.certs.where())
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.7"
},
"cryptography": {
"version": "35.0.0"
},
"idna": {
"version": "3.3"
},
"implementation": {
"name": "CPython",
"version": "3.6.13"
},
"platform": {
"release": "5.11.0-1019-aws",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "101010cf",
"version": "21.0.0"
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010104f"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
```
<!-- This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c). -->
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5966/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5966/timeline
| null |
completed
| null | null | false |
[
"Hi @nniehoff, \r\n\r\nCould you clarify what you find misleading? The docstring at the top of the certs module reads:\r\n\r\n> This module returns the preferred default CA certificate bundle. There is only one — the one from the certifi package.\r\n\r\nThe functionality is pretty clearly documented and `requests.certs.where` is just an alias for certifi's `where`. That method is only intended to find the certifi cacert.pem file and doesn't provide any functionality for looking up other certs.",
"Sure, I completely expect the certifi package to return the cacerts bundle that is bundled with it. However, IMO `requests.certs.where` isn't querying the certifi package but it is querying the requests package. I would expect `requests.certs.where` to return the actual path the requests module is using. In my case the value of the `REQUESTS_CA_BUNDLE` but looking at [this](https://github.com/psf/requests/blob/b0e025ade7ed30ed53ab61f542779af7e024932e/requests/sessions.py#L718-L719) I believe it could also be the value of the `CURL_CA_BUNDLE` environment variable. \r\n\r\nI guess my suggestion would be `requests.certs.where` should override `certifi.where` and return either of the variables if set or default to the value of `certifi.where`",
"Ok, thanks for clarifying. So it seems our documentation and the functionality is consistent, this is just a feature request for additional behavior. The proposal is a deviation from the current documented behavior that will likely negatively affect anyone using this specifically for `certifi`'s location.\r\n\r\nGiven that the feature is easily done with ~5 lines of Python locally, I'd advise writing a quick helper function for that for the time being. We may reconsider this if we release a new major version, but I'm going to close this for now since I don't think we'll see a change to this in the near future."
] |
https://api.github.com/repos/psf/requests/issues/5965
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5965/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5965/comments
|
https://api.github.com/repos/psf/requests/issues/5965/events
|
https://github.com/psf/requests/pull/5965
| 1,032,778,675 |
PR_kwDOABTKOs4tgmEE
| 5,965 |
Update Bug_report.md
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1873994?v=4",
"events_url": "https://api.github.com/users/alanyee/events{/privacy}",
"followers_url": "https://api.github.com/users/alanyee/followers",
"following_url": "https://api.github.com/users/alanyee/following{/other_user}",
"gists_url": "https://api.github.com/users/alanyee/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alanyee",
"id": 1873994,
"login": "alanyee",
"node_id": "MDQ6VXNlcjE4NzM5OTQ=",
"organizations_url": "https://api.github.com/users/alanyee/orgs",
"received_events_url": "https://api.github.com/users/alanyee/received_events",
"repos_url": "https://api.github.com/users/alanyee/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alanyee/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alanyee/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alanyee",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-10-21T18:00:47Z
|
2022-01-19T20:00:35Z
|
2021-10-21T18:06:33Z
|
CONTRIBUTOR
|
resolved
|
Add some highlighting and comment out the instructions so that the submitter can see it but it is not displayed in the GitHub issue
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5965/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5965/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5965.diff",
"html_url": "https://github.com/psf/requests/pull/5965",
"merged_at": "2021-10-21T18:06:33Z",
"patch_url": "https://github.com/psf/requests/pull/5965.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5965"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5964
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5964/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5964/comments
|
https://api.github.com/repos/psf/requests/issues/5964/events
|
https://github.com/psf/requests/issues/5964
| 1,032,766,258 |
I_kwDOABTKOs49jsMy
| 5,964 |
Cannot prevent requests library from encoding `|`
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1873994?v=4",
"events_url": "https://api.github.com/users/alanyee/events{/privacy}",
"followers_url": "https://api.github.com/users/alanyee/followers",
"following_url": "https://api.github.com/users/alanyee/following{/other_user}",
"gists_url": "https://api.github.com/users/alanyee/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alanyee",
"id": 1873994,
"login": "alanyee",
"node_id": "MDQ6VXNlcjE4NzM5OTQ=",
"organizations_url": "https://api.github.com/users/alanyee/orgs",
"received_events_url": "https://api.github.com/users/alanyee/received_events",
"repos_url": "https://api.github.com/users/alanyee/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alanyee/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alanyee/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alanyee",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-10-21T17:49:58Z
|
2022-04-07T12:00:22Z
|
2021-10-21T21:21:50Z
|
CONTRIBUTOR
|
resolved
|
There are various workarounds to ensure that there is no encoding for certain other characters like `:+`. Some of which involve passing the URL directly. But `|` seems to encoded regardless whether I pass in the url directly or prepare via `prepare_url`.
## Expected Result
```python
base_url = 'https://www.example.com/search?'
query = 'date_range=2017-01-01|2017-03-01'
r = requests.get(base_url + query)
print(r.url)
# output: 'http://www.example.com/search?date_range=2017-01-01|2017-03-01'
```
## Actual Result
```python
base_url = 'https://www.example.com/search?'
query = 'date_range=2017-01-01|2017-03-01'
r = requests.get(base_url + query)
print(r.url)
# output: 'https://www.example.com/search?date_range=2017-01-01%7C2017-03-01'
```
## Reproduction Steps
```python
import requests
base_url = 'https://www.example.com/search?'
query = 'date_range=2017-01-01|2017-03-01'
r = requests.get(base_url + query)
print(r.url)
```
You can try substituting `www.example.com` for a domain/website you own in order see what can happen from the web backend.
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": "3.0.4"
},
"charset_normalizer": {
"version": "2.0.7"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "2.10"
},
"implementation": {
"name": "CPython",
"version": "3.8.5"
},
"platform": {
"release": "4.4.0-19041-Microsoft",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010107f"
},
"urllib3": {
"version": "1.26.5"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5964/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5964/timeline
| null |
completed
| null | null | false |
[
"Hi @alanyee, this should be possible with the [PreparedRequest](https://docs.python-requests.org/en/master/user/advanced/#prepared-requests) workflow. You'll need to update the URL after preparation. I would note what you're doing violates the HTTP spec though and it may be worth reaching out to the service in question to correct the behavior.\r\n\r\n\r\n```\r\nimport requests\r\n\r\nbase_url = 'https://www.example.com/search'\r\nquery = '?date_range=2017-01-01|2017-03-01'\r\n\r\ns = requests.Session()\r\nreq = requests.Request('GET', base_url)\r\np = req.prepare()\r\np.url += query\r\nresp = s.send(p)\r\nprint(resp.request.url)\r\n```\r\n\r\n\r\n"
] |
https://api.github.com/repos/psf/requests/issues/5963
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5963/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5963/comments
|
https://api.github.com/repos/psf/requests/issues/5963/events
|
https://github.com/psf/requests/issues/5963
| 1,032,387,199 |
I_kwDOABTKOs49iPp_
| 5,963 |
what't the equivalance of "curl -T" in requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/8018334?v=4",
"events_url": "https://api.github.com/users/sicklife/events{/privacy}",
"followers_url": "https://api.github.com/users/sicklife/followers",
"following_url": "https://api.github.com/users/sicklife/following{/other_user}",
"gists_url": "https://api.github.com/users/sicklife/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sicklife",
"id": 8018334,
"login": "sicklife",
"node_id": "MDQ6VXNlcjgwMTgzMzQ=",
"organizations_url": "https://api.github.com/users/sicklife/orgs",
"received_events_url": "https://api.github.com/users/sicklife/received_events",
"repos_url": "https://api.github.com/users/sicklife/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sicklife/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sicklife/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sicklife",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-10-21T11:38:02Z
|
2022-01-19T13:03:36Z
|
2021-10-21T12:34:08Z
|
NONE
|
resolved
|
I have a torchserver api that recieve image files to generate result.
I can use the curl command `curl -T "dog[1-6].jpg" http://my-torchserver/address ` to put multiple files to the server and get the right result.
what's the equivalance expression of this curl command using requests?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5963/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5963/timeline
| null |
completed
| null | null | false |
[
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/5962
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5962/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5962/comments
|
https://api.github.com/repos/psf/requests/issues/5962/events
|
https://github.com/psf/requests/pull/5962
| 1,031,986,408 |
PR_kwDOABTKOs4teA9m
| 5,962 |
guess_filename: Use attribute 'filename' and then try 'name'
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4681718?v=4",
"events_url": "https://api.github.com/users/zferentz/events{/privacy}",
"followers_url": "https://api.github.com/users/zferentz/followers",
"following_url": "https://api.github.com/users/zferentz/following{/other_user}",
"gists_url": "https://api.github.com/users/zferentz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zferentz",
"id": 4681718,
"login": "zferentz",
"node_id": "MDQ6VXNlcjQ2ODE3MTg=",
"organizations_url": "https://api.github.com/users/zferentz/orgs",
"received_events_url": "https://api.github.com/users/zferentz/received_events",
"repos_url": "https://api.github.com/users/zferentz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zferentz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zferentz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zferentz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-10-21T02:18:13Z
|
2022-01-19T13:03:36Z
|
2021-10-21T12:36:35Z
|
NONE
|
resolved
|
I've created a Flask server that accepts multipart data (uploaded file) and simply proxy it to another server using Requests .
I found that the upload works perfectly except the fact that Requests loses the filename. The uploaded filename is replaced with the field-name of the of the multipart data.
It seems that in Flask, multipart arrive as type `werkzeug.datastructures.FileStorage` .
The FileStorage instance includes the "name" attribute which is the field-name of the multipart as well as the "filename" attribute which includes the filename.
The `requests.utils.guess_filename` currently using just the `name` attribute to determine (guess) the filename however in order to be compatible with Flask (and possible other libraries) it would probably be better to try first the "filename" attribute.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5962/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5962/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5962.diff",
"html_url": "https://github.com/psf/requests/pull/5962",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5962.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5962"
}
| true |
[
"This works fine for any object that implements the file like object API as it's intended. If there's a problem with flask, that's not our responsibility to paper over here and the files parameter supports overriding the filename so this is unneeded complexity"
] |
https://api.github.com/repos/psf/requests/issues/5961
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5961/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5961/comments
|
https://api.github.com/repos/psf/requests/issues/5961/events
|
https://github.com/psf/requests/issues/5961
| 1,030,190,438 |
I_kwDOABTKOs49Z3Vm
| 5,961 |
HTTPS proxies not working with Python's requests module
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/52484243?v=4",
"events_url": "https://api.github.com/users/Temp666-b/events{/privacy}",
"followers_url": "https://api.github.com/users/Temp666-b/followers",
"following_url": "https://api.github.com/users/Temp666-b/following{/other_user}",
"gists_url": "https://api.github.com/users/Temp666-b/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Temp666-b",
"id": 52484243,
"login": "Temp666-b",
"node_id": "MDQ6VXNlcjUyNDg0MjQz",
"organizations_url": "https://api.github.com/users/Temp666-b/orgs",
"received_events_url": "https://api.github.com/users/Temp666-b/received_events",
"repos_url": "https://api.github.com/users/Temp666-b/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Temp666-b/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Temp666-b/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Temp666-b",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-10-19T11:29:53Z
|
2022-01-17T13:07:15Z
|
2021-10-19T12:27:36Z
|
NONE
|
resolved
|
Summary
We try request module with below code spinet
Our Proxy srver running on https
```
import requests
url = 'https://google.com'
roxies = {'https': '10.x.x.x:443'}
if __name__ == '__main__':
print(url)
print(roxies)
response = requests.get(url, proxies=roxies)
if response.status_code == 200:
print(response.text)
else:
print ('Response ERROR', response.status_code)
```
Same connection we tried from curl its working fine.
` curl -v -x https://10.x.x.x:443 https://google.com
`
## Expected Result
Request module should connect to proxy server over https
What you expected.
Request module should connect to proxy server over https
## Actual Result
Request module giving following error while connecting to proxy server over https
OSError('Tunnel connection failed: 400 Bad Request')))
What happened instead.
## Reproduction Steps
```python
import requests
```
## System Information
$ python -m requests.help
```
<paste here>
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5961/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5961/timeline
| null |
completed
| null | null | false |
[
" python --version\r\nPython 3.7.7\r\n",
"Hi there,\r\n\r\nThanks for reaching out. Unfortunately, there's too little detail in this issue to be able to help you and it's not reproducible. That indicates a likely problem in your environment which we are not responsible for debugging and which the maintainers of this project do not have the time to help you with. As a result, I'm closing this issue.\n\nIn the future, please search **closed and** open issues before creating new ones that are duplicates."
] |
https://api.github.com/repos/psf/requests/issues/5960
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5960/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5960/comments
|
https://api.github.com/repos/psf/requests/issues/5960/events
|
https://github.com/psf/requests/issues/5960
| 1,028,034,385 |
I_kwDOABTKOs49Ro9R
| 5,960 |
requests.exceptions.ChunkedEncodingError: ("Connection broken: InvalidChunkLength(got length b'', 0 bytes read)", InvalidChunkLength(got length b'', 0 bytes read))
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/63039413?v=4",
"events_url": "https://api.github.com/users/wyhhyw123/events{/privacy}",
"followers_url": "https://api.github.com/users/wyhhyw123/followers",
"following_url": "https://api.github.com/users/wyhhyw123/following{/other_user}",
"gists_url": "https://api.github.com/users/wyhhyw123/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wyhhyw123",
"id": 63039413,
"login": "wyhhyw123",
"node_id": "MDQ6VXNlcjYzMDM5NDEz",
"organizations_url": "https://api.github.com/users/wyhhyw123/orgs",
"received_events_url": "https://api.github.com/users/wyhhyw123/received_events",
"repos_url": "https://api.github.com/users/wyhhyw123/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wyhhyw123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wyhhyw123/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wyhhyw123",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-10-16T12:14:48Z
|
2022-01-14T13:06:44Z
|
2021-10-16T13:01:51Z
|
NONE
|
resolved
|
I am trying to download 100GB+ files using requests.get. To avoid out of memory, i set stream = True, and read data from response using iter_content。 For example:
but i got this error, requests.exceptions.ChunkedEncodingError: ("Connection broken: InvalidChunkLength(got length b'', 0 bytes read)", InvalidChunkLength(got length b'', 0 bytes read)).
How to solve this problem
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5960/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5960/timeline
| null |
completed
| null | null | false |
[
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/5959
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5959/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5959/comments
|
https://api.github.com/repos/psf/requests/issues/5959/events
|
https://github.com/psf/requests/issues/5959
| 1,024,970,545 |
I_kwDOABTKOs49F88x
| 5,959 |
TypeError: __init__() got an unexpected keyword argument 'strict'
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/44804291?v=4",
"events_url": "https://api.github.com/users/half-of-a-glazier/events{/privacy}",
"followers_url": "https://api.github.com/users/half-of-a-glazier/followers",
"following_url": "https://api.github.com/users/half-of-a-glazier/following{/other_user}",
"gists_url": "https://api.github.com/users/half-of-a-glazier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/half-of-a-glazier",
"id": 44804291,
"login": "half-of-a-glazier",
"node_id": "MDQ6VXNlcjQ0ODA0Mjkx",
"organizations_url": "https://api.github.com/users/half-of-a-glazier/orgs",
"received_events_url": "https://api.github.com/users/half-of-a-glazier/received_events",
"repos_url": "https://api.github.com/users/half-of-a-glazier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/half-of-a-glazier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/half-of-a-glazier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/half-of-a-glazier",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-10-13T08:51:27Z
|
2022-01-11T10:05:51Z
|
2021-10-13T09:07:26Z
|
NONE
|
resolved
|
Request generates error TypeError: __init__() got an unexpected keyword argument 'strict'.
## Problem
This is the line of code that is erroring out:
*connectionpool.py line 560*
```python
connection = VerifiedHTTPSConnection(host=self.host,
port=self.port,
strict=self.strict) # this is error line
```
And this is the `VerifiedHTTPSConnection` class that it is trying to instantiate:
*connectionpool.py line 74*
```python
class VerifiedHTTPSConnection(HTTPSConnection): # class that is being instantiated
```
The problem is the `strict` parameter being passed through.
According to the [HTTPSConnection docs](https://docs.python.org/3/library/http.client.html#http.client.HTTPSConnection):
> class http.client.HTTPSConnection(host, port=None, key_file=None, cert_file=None, [timeout, ]source_address=None, *, context=None, check_hostname=None, blocksize=8192)
> ...
> Changed in version 3.4: The strict parameter was removed. HTTP 0.9-style “Simple Responses” are no longer supported.
Removing `strict=self.strict` fixes the error, but is not a long-term solution.
## Reproduction Steps
```python
import requests
requests.get(url='https://httpbin.org/get')
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "4.0.0"
},
"cryptography": {
"version": "3.4.7"
},
"idna": {
"version": "2.10"
},
"implementation": {
"name": "CPython",
"version": "3.9.5"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "101010bf",
"version": "20.0.1"
},
"requests": {
"version": "2.25.1"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.26.4"
},
"using_pyopenssl": true
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/44804291?v=4",
"events_url": "https://api.github.com/users/half-of-a-glazier/events{/privacy}",
"followers_url": "https://api.github.com/users/half-of-a-glazier/followers",
"following_url": "https://api.github.com/users/half-of-a-glazier/following{/other_user}",
"gists_url": "https://api.github.com/users/half-of-a-glazier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/half-of-a-glazier",
"id": 44804291,
"login": "half-of-a-glazier",
"node_id": "MDQ6VXNlcjQ0ODA0Mjkx",
"organizations_url": "https://api.github.com/users/half-of-a-glazier/orgs",
"received_events_url": "https://api.github.com/users/half-of-a-glazier/received_events",
"repos_url": "https://api.github.com/users/half-of-a-glazier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/half-of-a-glazier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/half-of-a-glazier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/half-of-a-glazier",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5959/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5959/timeline
| null |
completed
| null | null | false |
[
"I am using conda as opposed to pip, wondering if that would make a difference?",
"**Cause of problem: [xmla package](https://pypi.org/project/xmla/) forcing requests to install lower version**\r\n\r\nAfter running\r\n```bash\r\npip uninstall requests\r\nconda uninstall requests\r\npip install requests=2.26.0\r\n```\r\nThe following error was shown\r\n```bash\r\nERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.\r\nxmla 0.7.2 requires requests==1.2.3, but you have requests 2.26.0 which is incompatible.\r\n```\r\nI ran\r\n```bash\r\npip uninstall xmla\r\n```\r\nand all requests work as expected."
] |
https://api.github.com/repos/psf/requests/issues/5958
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5958/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5958/comments
|
https://api.github.com/repos/psf/requests/issues/5958/events
|
https://github.com/psf/requests/issues/5958
| 1,024,476,621 |
I_kwDOABTKOs49EEXN
| 5,958 |
Connect Error 10054 Starts Happening Randomly
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/70380275?v=4",
"events_url": "https://api.github.com/users/technodragon253/events{/privacy}",
"followers_url": "https://api.github.com/users/technodragon253/followers",
"following_url": "https://api.github.com/users/technodragon253/following{/other_user}",
"gists_url": "https://api.github.com/users/technodragon253/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/technodragon253",
"id": 70380275,
"login": "technodragon253",
"node_id": "MDQ6VXNlcjcwMzgwMjc1",
"organizations_url": "https://api.github.com/users/technodragon253/orgs",
"received_events_url": "https://api.github.com/users/technodragon253/received_events",
"repos_url": "https://api.github.com/users/technodragon253/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/technodragon253/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/technodragon253/subscriptions",
"type": "User",
"url": "https://api.github.com/users/technodragon253",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2021-10-12T21:59:58Z
|
2022-01-11T01:24:15Z
|
2021-10-12T22:05:57Z
|
NONE
|
resolved
|
When using requests it was working fine for about a week, but then it started randomly throwing 10054 errors. At first it was only when I would debug it with VSCode and it would work fine form the terminal. But then it started happening even when running from the terminal.
## Expected Result
Any actual response code and data.
## Actual Result
"ConnectionResetError" was thrown.
## Reproduction Steps
```python
import requests
print(requests.get("https://google.com"))
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.6"
},
"cryptography": {
"version": "3.4.8"
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.9.7"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "101010cf",
"version": "21.0.0"
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "101010cf"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": true
}
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
The full error is attached in a .txt file.
[error.txt](https://github.com/psf/requests/files/7333369/error.txt)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5958/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5958/timeline
| null |
completed
| null | null | false |
[
"Hi @technodragon253,\r\n\r\nThis isn't an issue with Requests. A 10054 error causing a connection reset is due to either the server or an intermediary in your network forcibly closing the connection. You're either being throttled for abuse or encountering an issue in your network. We'd recommend checking proxies and ensuring you're calling the server responsibly.",
"You sure? 'Cause everything works fine in IDLE. Also I have tried reinstalling the package.",
"@nateprewitt Can you reopen the issue?",
"I would recommend ensuring nothing is intercepting your requests locally. If the issue persists, the best option is to open a question on StackOverflow. We cannot control the actions of an external server and the fact it's inconsistent points to a configuration/environment issue. We can't provide troubleshooting support in this issue tracker.",
"Okay cool. Thanks for your help!"
] |
https://api.github.com/repos/psf/requests/issues/5957
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5957/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5957/comments
|
https://api.github.com/repos/psf/requests/issues/5957/events
|
https://github.com/psf/requests/issues/5957
| 1,021,840,073 |
I_kwDOABTKOs486ArJ
| 5,957 |
Post file upload Content-Length always 0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1448950?v=4",
"events_url": "https://api.github.com/users/MPW1412/events{/privacy}",
"followers_url": "https://api.github.com/users/MPW1412/followers",
"following_url": "https://api.github.com/users/MPW1412/following{/other_user}",
"gists_url": "https://api.github.com/users/MPW1412/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/MPW1412",
"id": 1448950,
"login": "MPW1412",
"node_id": "MDQ6VXNlcjE0NDg5NTA=",
"organizations_url": "https://api.github.com/users/MPW1412/orgs",
"received_events_url": "https://api.github.com/users/MPW1412/received_events",
"repos_url": "https://api.github.com/users/MPW1412/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/MPW1412/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MPW1412/subscriptions",
"type": "User",
"url": "https://api.github.com/users/MPW1412",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-10-10T00:14:39Z
|
2021-10-10T13:55:49Z
|
2021-10-10T00:48:50Z
|
NONE
|
resolved
|
When uploading a file via post, the content-length is always zero, which might cause problems.
## Expected Result
Properly calculate content-length as e. g. `pycurl` does.
## Actual Result
`Header Content-Length 0`
## Reproduction Steps
```python
import requests
heads = { 'Authoriziation': 'Bearer ...'
'Content-Type': 'multipart/form-data',
'Accept': 'application/json'
}
files = { 'file': ('dummpy.pdf', open(filename, 'rb'), 'application/pdf') }
ret = requests.post('https://my.apiendpoint.io/jadajadajada',
files=files, headers=heads)
```
## System Information
```
$ python3 --version
Python 3.8.10
$ pip3 list|grep requests
requests 2.23.0
```
Best,
Matthias
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5957/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5957/timeline
| null |
completed
| null | null | false |
[
"This works for me. Although, i don't specify the `Content-Type` header because Requests must manage that.\r\n\r\nPleas elet us know if you have additional information about how to reproduce this",
"Thanks for the hint about leaving out `Content-Type`. Surprisingly to me that works, contradicting the API documentation:\r\n\r\nhttps://developers.lexoffice.io/docs/#vouchers-endpoint-upload-a-file-to-a-voucher",
"That API documentation is poorly written. `multipart/form-data` requires a boundary. Curl may add it to the header for you (I don't care to verify that theory) but Requests assumes that you know better and doesn't modify it, so it generates the content and your server can't handle it."
] |
https://api.github.com/repos/psf/requests/issues/5956
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5956/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5956/comments
|
https://api.github.com/repos/psf/requests/issues/5956/events
|
https://github.com/psf/requests/pull/5956
| 1,021,813,547 |
PR_kwDOABTKOs4s-hpa
| 5,956 |
Add doc build requirements for RTD
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2021-10-09T21:43:23Z
|
2022-01-22T13:02:31Z
|
2021-10-09T22:03:34Z
|
MEMBER
|
resolved
|
Adding a requirements.txt file under the doc directory to specify our doc generation requirements. The only current requirement is Sphinx>4, for #5954. Once this is merged, this can be wired up to Read The Docs to be used when auto-building changes. We're currently relying on the default which is Sphinx 1.8.2 and missing some more recent features.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5956/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5956/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5956.diff",
"html_url": "https://github.com/psf/requests/pull/5956",
"merged_at": "2021-10-09T22:03:34Z",
"patch_url": "https://github.com/psf/requests/pull/5956.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5956"
}
| true |
[
"FYI @sigmavirus24 this relates back to https://github.com/pypa/twine/pull/810#discussion_r707236656.",
"@nateprewitt Could y'all enable [Preview Documentation from Pull Requests](https://docs.readthedocs.io/en/stable/pull-requests.html) for RTD? Beyond being an additional helpful check for documentation-oriented PR's, I think it might let me test my projects to see if this change resolves the intersphinx issue.",
"I don't have access to the project on RTD and I'm thinking that @nateprewitt doesn't either. This certainly won't break things, so we'll merge it since we can't do PR changes",
"@bhrutledge I'm looking at options to enable the preview builds. This change is probably worth doing regardless. I've enabled building with the new requirements, so the live docs should be set to test."
] |
https://api.github.com/repos/psf/requests/issues/5955
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5955/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5955/comments
|
https://api.github.com/repos/psf/requests/issues/5955/events
|
https://github.com/psf/requests/issues/5955
| 1,021,764,178 |
I_kwDOABTKOs485uJS
| 5,955 |
Change the Repo Description (short) on GitHub
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/67826352?v=4",
"events_url": "https://api.github.com/users/http-samc/events{/privacy}",
"followers_url": "https://api.github.com/users/http-samc/followers",
"following_url": "https://api.github.com/users/http-samc/following{/other_user}",
"gists_url": "https://api.github.com/users/http-samc/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/http-samc",
"id": 67826352,
"login": "http-samc",
"node_id": "MDQ6VXNlcjY3ODI2MzUy",
"organizations_url": "https://api.github.com/users/http-samc/orgs",
"received_events_url": "https://api.github.com/users/http-samc/received_events",
"repos_url": "https://api.github.com/users/http-samc/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/http-samc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/http-samc/subscriptions",
"type": "User",
"url": "https://api.github.com/users/http-samc",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-10-09T17:39:34Z
|
2022-01-07T21:00:31Z
|
2021-10-09T20:52:42Z
|
NONE
|
resolved
|
The GitHub repository description (homepage, top left) has a small but noticeable grammatical error.
Currently, it is "A simple, yet elegant HTTP library." However, in the README, you can see the grammatically correct version "A simple, yet elegant, HTTP library."
Please add the comma after "elegant" and save my sanity.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5955/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5955/timeline
| null |
completed
| null | null | false |
[
"Hi @http-samc, I've updated the description to keep ourselves consistent. I'll preface this by stating I'm not a professional editor, but I'm not certain the original change in the README was \"more correct\". These are coordinating adjectives, and have no strict requirement to be followed by another comma.\r\n\r\nEither way, rest easy, I hope there wasn't too much distress ;)",
"Thanks! 💯"
] |
https://api.github.com/repos/psf/requests/issues/5954
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5954/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5954/comments
|
https://api.github.com/repos/psf/requests/issues/5954/events
|
https://github.com/psf/requests/issues/5954
| 1,021,680,992 |
I_kwDOABTKOs485Z1g
| 5,954 |
autodoc type hints and intersphinx aren't working with the `requests` public API
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1326704?v=4",
"events_url": "https://api.github.com/users/bhrutledge/events{/privacy}",
"followers_url": "https://api.github.com/users/bhrutledge/followers",
"following_url": "https://api.github.com/users/bhrutledge/following{/other_user}",
"gists_url": "https://api.github.com/users/bhrutledge/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bhrutledge",
"id": 1326704,
"login": "bhrutledge",
"node_id": "MDQ6VXNlcjEzMjY3MDQ=",
"organizations_url": "https://api.github.com/users/bhrutledge/orgs",
"received_events_url": "https://api.github.com/users/bhrutledge/received_events",
"repos_url": "https://api.github.com/users/bhrutledge/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bhrutledge/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bhrutledge/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bhrutledge",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2021-10-09T11:09:56Z
|
2022-01-08T07:00:21Z
|
2021-10-10T00:50:40Z
|
NONE
|
resolved
|
It looks like autodoc is resolving type hints like `requests.Response` to their internal definition, e.g. `requests.models.Response`. This means the intersphinx references to the [Requests API docs](https://docs.python-requests.org/en/latest/api/) don’t work, resulting in build messages like `WARNING: py:class reference target not found: requests.models.Response`.
Originally reported as https://github.com/sphinx-doc/sphinx/issues/9653, but reported here as suggested in https://github.com/sphinx-doc/sphinx/issues/9653#issuecomment-939272975:
> It seems the document of requests was built by Sphinx-1.8.5. So an index entry for `requests.models.Reponse` is not generated. This problem will be resolved by upgrading Sphinx to 4.0 or newer. https://readthedocs.org/projects/requests/builds/14778070/
## Expected Result
It'd be nice if the types for `requests` classes in argument defaults and parameters were linked to the Requests documentation.
## Reproduction Steps
I put an example repo with instructions up at https://github.com/bhrutledge/sphinx-requests-typehints, generated via [sphinx-apidoc](https://www.sphinx-doc.org/en/master/man/sphinx-apidoc.html). The rendered docs are at https://sphinx-requests-typehints.readthedocs.io/en/latest/example_package.html.
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.5"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.9.7"
},
"platform": {
"release": "20.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "101010cf"
},
"urllib3": {
"version": "1.26.6"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5954/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5954/timeline
| null |
completed
| null | null | false |
[
"Hi @bhrutledge, it looks like we're just using the versions provided out of the box by RTD. I've put up a PR (#5956) to add a requirements.txt file for the docs using the latest version (4.2.0). It builds fine locally, so it appears fine for us to move.",
"Closing with #5956",
"Confirmed that this is working as desired:\r\n\r\nhttps://sphinx-requests-typehints.readthedocs.io/en/latest/example_package.html\r\nhttps://twine.readthedocs.io/en/latest/internal/twine.commands.upload.html\r\n\r\nThank you!",
"Good to know :-)"
] |
https://api.github.com/repos/psf/requests/issues/5953
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5953/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5953/comments
|
https://api.github.com/repos/psf/requests/issues/5953/events
|
https://github.com/psf/requests/pull/5953
| 1,021,171,999 |
PR_kwDOABTKOs4s8rEb
| 5,953 |
Add ipv6 support to should_bypass_proxies
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/883848?v=4",
"events_url": "https://api.github.com/users/derekhiggins/events{/privacy}",
"followers_url": "https://api.github.com/users/derekhiggins/followers",
"following_url": "https://api.github.com/users/derekhiggins/following{/other_user}",
"gists_url": "https://api.github.com/users/derekhiggins/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/derekhiggins",
"id": 883848,
"login": "derekhiggins",
"node_id": "MDQ6VXNlcjg4Mzg0OA==",
"organizations_url": "https://api.github.com/users/derekhiggins/orgs",
"received_events_url": "https://api.github.com/users/derekhiggins/received_events",
"repos_url": "https://api.github.com/users/derekhiggins/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/derekhiggins/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/derekhiggins/subscriptions",
"type": "User",
"url": "https://api.github.com/users/derekhiggins",
"user_view_type": "public"
}
|
[] |
open
| false | null |
[] | null | 10 |
2021-10-08T14:38:07Z
|
2024-05-17T15:14:30Z
| null |
NONE
| null |
Add support to should_bypass_proxies to support
IPv6 ipaddresses and CIDRs in no_proxy. Includes
adding IPv6 support to various other helper functions.
| null |
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5953/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5953/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5953.diff",
"html_url": "https://github.com/psf/requests/pull/5953",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5953.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5953"
}
| true |
[
"Hi @nateprewitt @sethmlarson , is this something you'd consider merging ? ",
"I'm facing this same issue. @nateprewitt @sethmlarson Any update on your thoughts?",
"Running into the same problem with this, it sure would be nice to have the ability to specify IPv6 CIDRs in no_proxy. What's holding this up?",
"@nateprewitt @sigmavirus24 @sethmlarson would you have a chance to look at this please, its been hanging around for over 2 years and still causing me problems. ",
"It'd be nice to have this implemented. Is there any way I can help?",
"Hi @frenzymadness , if you can review or confirm that this works for your use case then that would be appreciated but\r\nultimately this PR has been waiting on reviews from one of the maintainers I'm not sure how best to get it some traction besides pinging them on here.",
"We are going to test this change internally to get some confidence.",
"Derek tested the package in OpenShift 4.15 and the functionality proposed here works as expected. Is there any chance to merge this?",
"During additional testing, my colleague raised an interesting question: Are `::/0` and `0.0.0.0/0` valid values for `no_proxy`? The current implementation for IPv4 does not allow masks to be lower than 1 and the new implementation for IPv6 does the same.\r\n\r\nI see a use-case for `::/0` - let's say I have a proxy running on both protocols but I want it to be used only for IPv4 - then it might make sense to use `NO_PROXY` for all IPv6 addresses. What do you think?",
"What can I do to get this merged? We've reviewed the change and tested it in a real environment with real use cases. Is there anything else we can do?"
] |
https://api.github.com/repos/psf/requests/issues/5952
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5952/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5952/comments
|
https://api.github.com/repos/psf/requests/issues/5952/events
|
https://github.com/psf/requests/issues/5952
| 1,021,070,796 |
I_kwDOABTKOs483E3M
| 5,952 |
Requests verify cannot take multiple ssl_ca certs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/33820064?v=4",
"events_url": "https://api.github.com/users/pghole/events{/privacy}",
"followers_url": "https://api.github.com/users/pghole/followers",
"following_url": "https://api.github.com/users/pghole/following{/other_user}",
"gists_url": "https://api.github.com/users/pghole/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pghole",
"id": 33820064,
"login": "pghole",
"node_id": "MDQ6VXNlcjMzODIwMDY0",
"organizations_url": "https://api.github.com/users/pghole/orgs",
"received_events_url": "https://api.github.com/users/pghole/received_events",
"repos_url": "https://api.github.com/users/pghole/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pghole/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pghole/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pghole",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-10-08T12:59:27Z
|
2022-02-26T06:00:24Z
|
2021-11-28T05:28:15Z
|
NONE
|
resolved
|
Summary.
Like the ```http.client``` library, in which we can use the ```load_verify_locations()``` multiple times for multiple ca certs can be added. The python requests cannot take multiple certs for the ```verify``` parameter
## Expected Result
All the certs should be taken in account for SSL verification.
What you expected - I expected to verify against multiple certs.
## Actual Result
What happened instead -SSL verify failed.
## Reproduction Steps
```python
import requests
crt1 = '/path_to_cert1'
crt2 = 'path_to_cert2'
requests.get(url, verify=crt1)
or requests.get(url, verify=crt2)
# Cannot give both paths somehow.
```
## System Information
$ python -m requests.help
```
I am using a linux machine.
```
**If this is not supported, is there any way to do that ??**
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/5952/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5952/timeline
| null |
completed
| null | null | false |
[
"How is this \"Add doc build requirements for RTD # 5956\" related to this issue ?",
"This is a restriction of urllib3 which only allows configuring TLS on pool creation, not per request. Closing this issue as we can't do anything here."
] |
https://api.github.com/repos/psf/requests/issues/5951
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5951/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5951/comments
|
https://api.github.com/repos/psf/requests/issues/5951/events
|
https://github.com/psf/requests/issues/5951
| 1,018,862,840 |
I_kwDOABTKOs48upz4
| 5,951 |
SSLError - CERTIFICATE_VERIFY_FAILED
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/37031426?v=4",
"events_url": "https://api.github.com/users/mimansa-dev/events{/privacy}",
"followers_url": "https://api.github.com/users/mimansa-dev/followers",
"following_url": "https://api.github.com/users/mimansa-dev/following{/other_user}",
"gists_url": "https://api.github.com/users/mimansa-dev/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mimansa-dev",
"id": 37031426,
"login": "mimansa-dev",
"node_id": "MDQ6VXNlcjM3MDMxNDI2",
"organizations_url": "https://api.github.com/users/mimansa-dev/orgs",
"received_events_url": "https://api.github.com/users/mimansa-dev/received_events",
"repos_url": "https://api.github.com/users/mimansa-dev/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mimansa-dev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mimansa-dev/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mimansa-dev",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-10-06T17:50:51Z
|
2022-01-04T21:00:33Z
|
2021-10-06T20:33:38Z
|
NONE
|
resolved
|
## Summary
Started getting SSLError when invoking API using requests module.
SSLError: HTTPSConnectionPool(host='<HOST URL>, port=443): Max retries exceeded with url: /oauth/token (Caused by SSLError(SSLError(1, u'[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581)'),))
Just to add that this is on RHEL
>>> ssl.OPENSSL_VERSION
'OpenSSL 1.0.1e-fips 11 Feb 2013'
The system openssl is
Version : 1.0.1e,
Release : 58.el6_10
python was built using source.
## Expected Result
Was not expecting an SSLError. This is not a problem with the source website as the same call works fine using postman. Could this have anything to do with letsencryt root certificate expiration?
## Actual Result
SSLError: HTTPSConnectionPool(host='<HOST URL>, port=443): Max retries exceeded with url: /oauth/token (Caused by SSLError(SSLError(1, u'[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581)'),))
## Reproduction Steps
```
Invoke API using python requests and without verify=False
```
## System Information
Just to add that this is on RHEL
>>> ssl.OPENSSL_VERSION
'OpenSSL 1.0.1e-fips 11 Feb 2013'
The system openssl is
Version : 1.0.1e,
Release : 58.el6_10
python was built using source.
$ python -m requests.help
```
{
"chardet": {
"version": "4.0.0"
},
"charset_normalizer": {
"version": null
},
"cryptography": {
"version": ""
},
"idna": {
"version": "2.10"
},
"implementation": {
"name": "CPython",
"version": "2.7.9"
},
"platform": {
"release": "2.6.32-754.9.1.el6.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1000105f"
},
"urllib3": {
"version": "1.26.6"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5951/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5951/timeline
| null |
completed
| null | null | false |
[
"Might be getting hit by LetsEncrypt's old root CA expiring. Try upgrading certifi or whatever certificates you're using on the OS.",
"Duplicate of https://github.com/certifi/python-certifi/issues/164"
] |
https://api.github.com/repos/psf/requests/issues/5950
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5950/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5950/comments
|
https://api.github.com/repos/psf/requests/issues/5950/events
|
https://github.com/psf/requests/issues/5950
| 1,016,443,852 |
I_kwDOABTKOs48lbPM
| 5,950 |
RequestsCookieJar._find_on_duplicates wrongly fails on cookie with empty value
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/61288277?v=4",
"events_url": "https://api.github.com/users/alexpostolache/events{/privacy}",
"followers_url": "https://api.github.com/users/alexpostolache/followers",
"following_url": "https://api.github.com/users/alexpostolache/following{/other_user}",
"gists_url": "https://api.github.com/users/alexpostolache/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alexpostolache",
"id": 61288277,
"login": "alexpostolache",
"node_id": "MDQ6VXNlcjYxMjg4Mjc3",
"organizations_url": "https://api.github.com/users/alexpostolache/orgs",
"received_events_url": "https://api.github.com/users/alexpostolache/received_events",
"repos_url": "https://api.github.com/users/alexpostolache/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alexpostolache/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexpostolache/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alexpostolache",
"user_view_type": "public"
}
|
[] |
open
| false | null |
[] | null | 2 |
2021-10-05T15:06:09Z
|
2022-08-31T12:03:33Z
| null |
NONE
| null |
Getting the value of a cookie which is set without a value by a website raises a `KeyError`. I don't know if this is by design. Browsers seem to accept these kind of cookies, even though this behaviour seems like bad practice.
## Expected Result
An empty string.
## Actual Result
`RequestsCookieJar._find_no_duplicates` raises a `KeyError`
## Reproduction Steps
In `ipython`:
```python
import requests
resp = requests.get("https://www.pib-insurance.com/")
resp.cookies.get_dict() # pretty print cookies
resp.cookies["firstname"]
```
## Fix
I think last `if` in `_find_no_duplicates` (line **397** of `cookies.py`) should be `if toReturn is not None:` to accommodate for cookies without values.
Thanks!
| null |
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5950/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5950/timeline
| null | null | null | null | false |
[
"Mark，the same problem ",
"Mark, the same problem"
] |
https://api.github.com/repos/psf/requests/issues/5949
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5949/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5949/comments
|
https://api.github.com/repos/psf/requests/issues/5949/events
|
https://github.com/psf/requests/issues/5949
| 1,016,260,364 |
I_kwDOABTKOs48kucM
| 5,949 |
Wrong JSON output!
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/78355409?v=4",
"events_url": "https://api.github.com/users/kransk/events{/privacy}",
"followers_url": "https://api.github.com/users/kransk/followers",
"following_url": "https://api.github.com/users/kransk/following{/other_user}",
"gists_url": "https://api.github.com/users/kransk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kransk",
"id": 78355409,
"login": "kransk",
"node_id": "MDQ6VXNlcjc4MzU1NDA5",
"organizations_url": "https://api.github.com/users/kransk/orgs",
"received_events_url": "https://api.github.com/users/kransk/received_events",
"repos_url": "https://api.github.com/users/kransk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kransk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kransk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kransk",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-10-05T12:22:14Z
|
2022-01-03T16:00:24Z
|
2021-10-05T13:56:18Z
|
NONE
|
resolved
|
If I make a request using Python3 requests lib - the JSON output is completely wrong. But if I make the same response using other language or cURL or Postman or others.. All is good.
I think it's the body decoding trouble in Python3, because all is good using JavaScript request or others...
## Expected Result
```python
print(r.json().get('offer').get('state').get('mileage')) # Should be 170000
```
## Actual Result
```python
print(r.json().get('offer').get('state').get('mileage')) # But its 199000! Wtf?
```
## Reproduction Steps
```python
import requests
url = {
'url': 'https://apiauto.ru/1.0/offer/cars/1105235269-6558d30b?rid=225',
'headers': {
"X-Authorization": "Vertis ios-62ca2575df9c74b3958d118afcbb7602",
},
}
r = requests.get(**url)
print(r.json().get('offer').get('state').get('mileage')) # Try make this the same request in e.g. Postman, the mileage should be 170000
```
## System Information
```
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "2.10"
},
"implementation": {
"name": "CPython",
"version": "3.9.6"
},
"platform": {
"release": "19.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.24.0"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.25.11"
},
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5949/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5949/timeline
| null |
completed
| null | null | false |
[
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here.\r\n\r\nYou can confirm what is being returned to you by looking at `r.text`. I suspect you'll see `199000` in the response making this an issue with the server.",
"@sigmavirus24 No. Its not the easy-fix problem. I tried a lot of stuff - from requests headers to response raw bytes. Moreover if python version is 3.4 - everything is ok. I think there is an error in decoding, but I dont know where ",
"@kransk you've given no details to actually prove this is a requests bug. We rely heavily on the standard library. If there's actually an issue decoding somewhere it's likely there. "
] |
https://api.github.com/repos/psf/requests/issues/5948
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5948/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5948/comments
|
https://api.github.com/repos/psf/requests/issues/5948/events
|
https://github.com/psf/requests/issues/5948
| 1,016,238,879 |
I_kwDOABTKOs48kpMf
| 5,948 |
Retrying errors during chunked-encoded body reading is not supported
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/39103632?v=4",
"events_url": "https://api.github.com/users/alexdrydew/events{/privacy}",
"followers_url": "https://api.github.com/users/alexdrydew/followers",
"following_url": "https://api.github.com/users/alexdrydew/following{/other_user}",
"gists_url": "https://api.github.com/users/alexdrydew/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alexdrydew",
"id": 39103632,
"login": "alexdrydew",
"node_id": "MDQ6VXNlcjM5MTAzNjMy",
"organizations_url": "https://api.github.com/users/alexdrydew/orgs",
"received_events_url": "https://api.github.com/users/alexdrydew/received_events",
"repos_url": "https://api.github.com/users/alexdrydew/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alexdrydew/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alexdrydew/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alexdrydew",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-10-05T12:00:54Z
|
2022-01-03T15:00:26Z
|
2021-10-05T14:15:08Z
|
NONE
|
resolved
|
In case of headers being correctly received if an error occurs during response body read (when chunked transfer-encoding is enabled) retries are completely ignored even in case of `stream=False` argument passed.
## Expected Result
Requests library supports specifying `stream=False` argument in methods so I would expect the library to apply retries if request fails in any scenario. I believe that content being loaded after the initial urllib3 request is being made should be considered an implementation detail and this logic should be handled by high-level `request` method.
## Actual Result
Currently retries are applied only during first urllib3 level request with `preload_content=False`. If an error occurs during body read an exception wrapper is passed to user.
In case of following example the stack trace is:
<details>
<summary>
Stack trace
</summary>
```
Traceback (most recent call last):
File ".../python3.9/site-packages/urllib3/response.py", line 439, in _error_catcher
yield
File ".../python3.9/site-packages/urllib3/response.py", line 767, in read_chunked
self._update_chunk_length()
File ".../python/toloka_client/venv/lib/python3.9/site-packages/urllib3/response.py", line 697, in _update_chunk_length
line = self._fp.fp.readline()
File "/usr/local/Cellar/[email protected]/3.9.6/Frameworks/Python.framework/Versions/3.9/lib/python3.9/socket.py", line 704, in readinto
return self._sock.recv_into(b)
socket.timeout: timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File ".../python3.9/site-packages/requests/models.py", line 758, in generate
for chunk in self.raw.stream(chunk_size, decode_content=True):
File ".../python3.9/site-packages/urllib3/response.py", line 573, in stream
for line in self.read_chunked(amt, decode_content=decode_content):
File ".../python3.9/site-packages/urllib3/response.py", line 796, in read_chunked
self._original_response.close()
File "/usr/local/Cellar/[email protected]/3.9.6/Frameworks/Python.framework/Versions/3.9/lib/python3.9/contextlib.py", line 135, in __exit__
self.gen.throw(type, value, traceback)
File ".../python3.9/site-packages/urllib3/response.py", line 444, in _error_catcher
raise ReadTimeoutError(self._pool, None, "Read timed out.")
urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='localhost', port=62510): Read timed out.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "scratch.py", line 98, in <module>
main()
File "scratch.py", line 93, in main
print(session.get(f'{url}/response', timeout=0.1).text, stream=False)
File ".../python3.9/site-packages/requests/sessions.py", line 555, in get
return self.request('GET', url, **kwargs)
File ".../python3.9/site-packages/requests/sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File ".../python3.9/site-packages/requests/sessions.py", line 697, in send
r.content
File ".../python3.9/site-packages/requests/models.py", line 836, in content
self._content = b''.join(self.iter_content(CONTENT_CHUNK_SIZE)) or b''
File ".../python3.9/site-packages/requests/models.py", line 765, in generate
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=62510): Read timed out.
```
</details>
## Reproduction Steps
Here is an example with local server implemented using aiohttp. In this case aiohttp server can be replaced with any other server that supports chunked encoding without changing the final behaviour (I used aiohttp for implementation just because it is easy to implement chunked-encoding transfer using this library).
```python
import asyncio
import time
import requests
from requests.adapters import HTTPAdapter
from urllib3.util import Retry
from aiohttp import web
from aiohttp.test_utils import unused_port
from multiprocessing import Process
from functools import wraps
class RetryCountingHandler:
def __init__(self, retries_before_response):
self.retries_left = retries_before_response
async def get_response(self, request):
response = web.StreamResponse()
response.enable_chunked_encoding()
await response.prepare(request)
self.retries_left -= 1
if self.retries_left >= 0:
await asyncio.sleep(10)
await response.write('Hello world'.encode('utf-8'))
return response
async def get_retries_left(self, request):
return web.Response(text=str(self.retries_left))
async def ping(self, request):
return web.Response(text='OK')
def run_server(url, port):
app = web.Application()
handler = RetryCountingHandler(retries_before_response=10)
app.add_routes([
web.get('/response', handler.get_response),
web.get('/retries_left', handler.get_retries_left),
web.get('/ping', handler.ping)
])
web.run_app(app, host=url, port=port)
def main():
port = unused_port()
url = f'http://localhost:{port}'
server_process = Process(target=run_server, args=('localhost', port))
server_process.daemon = True
server_process.start()
for _ in range(30):
try:
if requests.get(f'{url}/ping', timeout=0.1).status_code == 200:
break
except requests.exceptions.ConnectionError:
pass
print('Server is not started... sleeping for 1s')
time.sleep(1)
else:
raise RuntimeError("Can't start server")
adapter = HTTPAdapter(max_retries=Retry(11, backoff_factor=0))
session = requests.Session()
session.mount(url, adapter)
print(session.get(f'{url}/response', timeout=0.1).text, stream=False)
if __name__ == "__main__":
main()
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "4.0.0"
},
"charset_normalizer": {
"version": "2.0.2"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.9.6"
},
"platform": {
"release": "19.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.26.6"
},
"using_charset_normalizer": false,
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5948/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5948/timeline
| null |
completed
| null | null | false |
[
"Currently this issue can be fixed be writing custom `HTTPAdapter`:\r\n```\r\nclass PreloadingHTTPAdapter(HTTPAdapter):\r\n @staticmethod\r\n def _override_preload_content(func):\r\n @functools.wraps(func)\r\n def wrapper(*args, **kwargs):\r\n kwargs['preload_content'] = True\r\n kwargs['decode_content'] = True\r\n resp = func(*args, **kwargs)\r\n return resp\r\n\r\n return wrapper\r\n\r\n def build_response(self, req, resp):\r\n response = super().build_response(req, resp)\r\n if resp._body:\r\n response._content = resp.data\r\n return response\r\n\r\n def get_connection(self, *args, **kwargs):\r\n connection = super().get_connection(*args, **kwargs)\r\n connection.urlopen = self._override_preload_content(connection.urlopen)\r\n return connection\r\n```\r\n\r\nbut I believe that it is an extremely hacky solution and it is very vulnerable to changing implementation details of both urllib3 and requests libraries.\r\n\r\n",
"I haven't double-checked, but I'm fairly certain we do not promise the behaviour you are expecting. Given that we're under a feature freeze, this would be a net-new feature and would not be implemented. (Also we've never supported this particular case.)\r\n\r\nBecause I had trouble understanding your circuitous statements, I'm going to also simplify what I think you're saying for myself and others.\r\n\r\n1. You've sent a request and received the headers of the response. This means that the first `read` has completed and urllib3's retry logic no longer applies (that only applies to errors from the first `read()` call).\r\n2. After receiving that, a read error occurs and you expect Requests to resend your initial request and try again without telling you. This is especially problematic because you've configured 11 total retries, some of which may have been used and we have no way of determining how many retries urllib3 used, so now we have to guess(?) how many are left in order to perform behaviour we've never promised\r\n\r\n"
] |
https://api.github.com/repos/psf/requests/issues/5946
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5946/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5946/comments
|
https://api.github.com/repos/psf/requests/issues/5946/events
|
https://github.com/psf/requests/issues/5946
| 1,006,800,785 |
I_kwDOABTKOs48Ao-R
| 5,946 |
requests with Retry, unexpected kwarg allowed_methods
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/33426811?v=4",
"events_url": "https://api.github.com/users/jly36963/events{/privacy}",
"followers_url": "https://api.github.com/users/jly36963/followers",
"following_url": "https://api.github.com/users/jly36963/following{/other_user}",
"gists_url": "https://api.github.com/users/jly36963/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jly36963",
"id": 33426811,
"login": "jly36963",
"node_id": "MDQ6VXNlcjMzNDI2ODEx",
"organizations_url": "https://api.github.com/users/jly36963/orgs",
"received_events_url": "https://api.github.com/users/jly36963/received_events",
"repos_url": "https://api.github.com/users/jly36963/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jly36963/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jly36963/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jly36963",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-09-24T20:24:23Z
|
2021-12-23T21:00:23Z
|
2021-09-24T20:32:34Z
|
NONE
|
resolved
|
I want to retry on failed POST requests (questionable pattern, I know). I tried using the `allowed_methods` kwarg in Retry and got an error.
## Expected Result
I expect the `allowed_methods` to work, and to allow for retries on POST requests.
## Actual Result
I tried the kwarg with both `requests.packages.urllib3.util.retry.Retry` and `urllib3.util.retry.Retry`. both resulted in the same error:
```
TypeError: __init__() got an unexpected keyword argument 'allowed_methods'
```
## Reproduction Steps
```python
import requests
from requests.adapters import HTTPAdapter
from requests.packages.urllib3.util.retry import Retry
# from urllib3.util.retry import Retry
with requests.Session() as r:
max_retries: Retry = Retry(
total=3,
backoff_factor=240, # factor * (2 ** (num_of_retries - 1))
status_forcelist=[500, 502, 503, 504, 520, 524],
allowed_methods=frozenset(['GET', 'POST'])
)
r.mount('http://', HTTPAdapter(max_retries=max_retries))
r.mount('https://', HTTPAdapter(max_retries=max_retries))
# make request
# raise for status
# etc
```
## System Information
Mac, Big Sur, Version 11.5.2
### relevant Pipfile details
requests = "==2.22.0"
python_version = "3.6"
### python -m requests.help
```
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "2.8"
},
"implementation": {
"name": "CPython",
"version": "3.6.12"
},
"platform": {
"release": "20.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.22.0"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.25.11"
},
"using_pyopenssl": false
}
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5946/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5946/timeline
| null |
completed
| null | null | false |
[
"You need to be using urllib3 1.26+ to use `allowed_methods`. I recommend upgrading your Requests and urllib3 versions.",
"Thank you for the prompt response! I'm using a cloud environment with locked versions, so I can't upgrade. I found the old parameter, so all is well."
] |
https://api.github.com/repos/psf/requests/issues/5945
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5945/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5945/comments
|
https://api.github.com/repos/psf/requests/issues/5945/events
|
https://github.com/psf/requests/issues/5945
| 1,006,150,306 |
I_kwDOABTKOs47-KKi
| 5,945 |
how to get the dict in server ?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/35590066?v=4",
"events_url": "https://api.github.com/users/ucasiggcas/events{/privacy}",
"followers_url": "https://api.github.com/users/ucasiggcas/followers",
"following_url": "https://api.github.com/users/ucasiggcas/following{/other_user}",
"gists_url": "https://api.github.com/users/ucasiggcas/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ucasiggcas",
"id": 35590066,
"login": "ucasiggcas",
"node_id": "MDQ6VXNlcjM1NTkwMDY2",
"organizations_url": "https://api.github.com/users/ucasiggcas/orgs",
"received_events_url": "https://api.github.com/users/ucasiggcas/received_events",
"repos_url": "https://api.github.com/users/ucasiggcas/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ucasiggcas/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ucasiggcas/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ucasiggcas",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-09-24T07:05:09Z
|
2021-12-23T15:00:24Z
|
2021-09-24T14:09:00Z
|
NONE
|
resolved
|
server:
```
app = flask.Flask(__name__)
@app.route("/http/",methods=['GET','POST'])
def tryOnce():
params = flask.request.data.decode("utf-8")
print(params)
```
request:
```
params={'appid': '123', 'checkin_type': '6', 'role': '1', 'stunum': '158122','keys':{"k1":'1',"k2":'2',"k4":4}}
requests.post(url3,params,headers={"Content-Type":"application/json"}).json()
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5945/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5945/timeline
| null |
completed
| null | null | false |
[
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here."
] |
https://api.github.com/repos/psf/requests/issues/5944
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5944/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5944/comments
|
https://api.github.com/repos/psf/requests/issues/5944/events
|
https://github.com/psf/requests/issues/5944
| 1,005,316,356 |
I_kwDOABTKOs476-kE
| 5,944 |
TypeError when mocking requests.Response
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/48517?v=4",
"events_url": "https://api.github.com/users/jaap3/events{/privacy}",
"followers_url": "https://api.github.com/users/jaap3/followers",
"following_url": "https://api.github.com/users/jaap3/following{/other_user}",
"gists_url": "https://api.github.com/users/jaap3/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaap3",
"id": 48517,
"login": "jaap3",
"node_id": "MDQ6VXNlcjQ4NTE3",
"organizations_url": "https://api.github.com/users/jaap3/orgs",
"received_events_url": "https://api.github.com/users/jaap3/received_events",
"repos_url": "https://api.github.com/users/jaap3/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaap3/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaap3/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaap3",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-09-23T11:26:28Z
|
2021-12-22T12:00:24Z
|
2021-09-23T11:40:26Z
|
CONTRIBUTOR
|
resolved
|
I'm upgrading a project from Python 3.6 to 3.8 and am encountering some test failures because the following works in Python 3.6, but doesn't work in Python 3.8+ anymore.
## Expected Result
```python
>>> from unittest import mock
>>> import requests
>>> mock.MagicMock(spec=requests.Response())
<MagicMock spec='Response' id='140154342612104'>
```
(Python 3.6.14)
## Actual Result
```python
>>> from unittest import mock
>>> import requests
>>> mock.MagicMock(spec=requests.Response())
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.8/unittest/mock.py", line 2006, in __init__
_safe_super(MagicMixin, self).__init__(*args, **kw)
File "/usr/local/lib/python3.8/unittest/mock.py", line 1063, in __init__
_safe_super(CallableMixin, self).__init__(
File "/usr/local/lib/python3.8/unittest/mock.py", line 444, in __init__
self._mock_add_spec(spec, spec_set, _spec_as_instance, _eat_self)
File "/usr/local/lib/python3.8/unittest/mock.py", line 499, in _mock_add_spec
if asyncio.iscoroutinefunction(getattr(spec, attr, None)):
File "/usr/local/lib/python3.8/site-packages/requests/models.py", line 735, in apparent_encoding
return chardet.detect(self.content)['encoding']
File "/usr/local/lib/python3.8/site-packages/chardet/__init__.py", line 36, in detect
raise TypeError('Expected object of type bytes or bytearray, got: '
TypeError: Expected object of type bytes or bytearray, got: <class 'NoneType'>
```
(Python 3.8.12)
## Reproduction Steps
```python
from unittest import mock
import requests
mock.MagicMock(spec=requests.Response())
```
## System Information
On docker image `python:3.6`
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.6"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.6.14"
},
"platform": {
"release": "5.10.47-linuxkit",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010104f"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
On docker image `python:3.8`
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.6"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.8.12"
},
"platform": {
"release": "5.10.47-linuxkit",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.26.7"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5944/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5944/timeline
| null |
completed
| null | null | false |
[
"I believe you want `mock.MagicMock(spec=requests.Response)` which is the safe way to always use mocking - especially with objects known to have side-effects"
] |
https://api.github.com/repos/psf/requests/issues/5943
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5943/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5943/comments
|
https://api.github.com/repos/psf/requests/issues/5943/events
|
https://github.com/psf/requests/issues/5943
| 1,005,261,968 |
I_kwDOABTKOs476xSQ
| 5,943 |
urllib3 v1.26.7 break Session Object with Proxy
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5131271?v=4",
"events_url": "https://api.github.com/users/achapkowski/events{/privacy}",
"followers_url": "https://api.github.com/users/achapkowski/followers",
"following_url": "https://api.github.com/users/achapkowski/following{/other_user}",
"gists_url": "https://api.github.com/users/achapkowski/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/achapkowski",
"id": 5131271,
"login": "achapkowski",
"node_id": "MDQ6VXNlcjUxMzEyNzE=",
"organizations_url": "https://api.github.com/users/achapkowski/orgs",
"received_events_url": "https://api.github.com/users/achapkowski/received_events",
"repos_url": "https://api.github.com/users/achapkowski/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/achapkowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/achapkowski/subscriptions",
"type": "User",
"url": "https://api.github.com/users/achapkowski",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 20 |
2021-09-23T10:25:37Z
|
2021-12-23T14:00:19Z
|
2021-09-24T13:06:21Z
|
NONE
|
resolved
|
The urllib3 library has released `1.26.7` and the changes have caused some additional issues with proxies and SSL certificates.
#### Version with issue
requests (latest)
urllib3 - 1.26.7 (latest)
#### Problem
Any port forwarding proxy breaks with code change.
#### Code to Reproduce
To reproduce:
1. Open fiddler
2. Run the following
```python
import requests
s = requests.Session()
s.verify=False
s.trust_env=True
try:
s.get("https://httpbin.org/get?a=1&b=2").json()
except Exception as e:
print(e)
raise e
```
You get the following error:
```
requests.exceptions.SSLError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1091)')))
```
So now the type name mismatch isn't happening like with `1.26.6` now this is being bubbled up. This means `verify` still isn't being honored because `verify=False` should just ignore any SSL certificate.
Now let's specify the proxy for the session:
```
import urllib.request
s.proxies = urllib.request.getproxies()
s.get("https://httpbin.org/get?a=1&b=2").json()
```
This results in the following:
```
requests.exceptions.SSLError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1091)')))
```
Same issue.
Outside of a session:
```
proxy = urllib.request.getproxies()
requests.get("https://httpbin.org/get?a=1&b=2", proxies=proxy, verify=False).json()
```
Result:
```
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\envs\pro-dev\lib\site-packages\requests\api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "C:\envs\pro-dev\lib\site-packages\requests\api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "C:\envs\pro-dev\lib\site-packages\requests\sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File "C:\envs\pro-dev\lib\site-packages\requests\sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "C:\envs\pro-dev\lib\site-packages\requests\adapters.py", line 573, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1091)')))
```
#### Solution:
TBD
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5943/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5943/timeline
| null |
completed
| null | null | false |
[
"It appears the issue is here: HTTPConnection.set_cert() in urllib3 gets set to REQUIRED when verify is set to False.",
"@achapkowski What is the last urllib3 version that works for you? That would help us pinpoint and fix the issue.",
"@pquentin let me know if this helps.\r\n\r\n\r\n### Setup\r\n1. Manually install urllib3 with latest of requests\r\n2. Open fiddler\r\n3. Run the code below\r\n4. close fiddler GOTO: 1\r\n\r\n### Test code:\r\n\r\n```python\r\nimport requests\r\nimport urllib.request\r\nimport urllib3\r\n\r\nprint(urllib3.__version__)\r\ns = requests.Session()\r\ns.verify = False\r\ns.trust_env = True\r\ns.proxies = urllib.request.getproxies()\r\ns.get(\"https://httpbin.org/get?a=1&b=2\").json()\r\n```\r\n\r\nHere is the urllib3 versions I tested with:\r\n\r\n- **1.25.11** - No issue\r\n- **1.26.0** - requests.exceptions.SSLError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1091)')))\r\n- **1.26.1** - requests.exceptions.SSLError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1091)')))\r\n- **1.26.2** - requests.exceptions.SSLError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1091)')))\r\n- **1.26.3** - requests.exceptions.SSLError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1091)')))\r\n- **1.26.4** - builtins.ValueError: check_hostname requires server_hostname\r\n- **1.26.5** - builtins.ValueError: check_hostname requires server_hostname\r\n- **1.26.6** - builtins.ValueError: check_hostname requires server_hostname\r\n- **1.26.7** - requests.exceptions.SSLError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1091)')))\r\n\r\n\r\n",
"Yes, that's helpful! My suspicion is that your proxy is actually an HTTP proxy (not HTTPS) but you configure it using an \"https://\" URL instead of an \"http://\" one.",
"@pquentin \r\n\r\nI set the proxies to be both http, and I get the same result as I show above.\r\n\r\n```python\r\n{'http': 'http://127.0.0.1:8888', 'https': 'http://127.0.0.1:8888'}\r\n```",
"@achapkowski Now this is confusing. The error means that we're speaking HTTPS to an HTTP endpoint, which should not be possible based on what you're showing me. Can you please try pure urllib3?\r\n\r\n```python3\r\nimport urllib3\r\n\r\nhttp = urllib3.ProxyManager(\"http://127.0.0.1:8888\")\r\nhttp.request(\"GET\", \"https://example.com\", timeout=5, retries=0)\r\n```\r\n\r\nAnd this version (notice the https proxy) which should reproduce the error you're seeing:\r\n\r\n```python3\r\nimport urllib3\r\n\r\nhttp = urllib3.ProxyManager(\"https://127.0.0.1:8888\")\r\nhttp.request(\"GET\", \"https://example.com\", timeout=5, retries=0)\r\n```",
"At urllib3 v1.25.11 I do not get an error either way and I get back the payload.\r\n\r\nFYI, the urllib.request.getproxies() returns: ```{'http': 'http://127.0.0.1:8888', 'https': 'https://127.0.0.1:8888'}``` and that fails too in requests.\r\n\r\nAt the 1.26.7, it seems to enter and endless loop and after a few minutes returns:\r\n\r\n```requests.exceptions.SSLError: HTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1091)')))```",
"@pquentin I think the best way for you to see what I'm seeing is to just try the reproducible code with fiddler open. ",
"Can you please clarify what the output of each of those two scripts is, using urllib3 1.26.7? I can't tell from your comment.\r\n\r\n> @pquentin I think the best way for you to see what I'm seeing is to just try the reproducible code with fiddler open.\r\n\r\nI considered that, but from what I've seen it's proprietary and requires an account.",
"> FYI, the urllib.request.getproxies() returns: `{'http': 'http://127.0.0.1:8888', 'https': 'https://127.0.0.1:8888'}` and that fails too in requests.\r\n\r\n@achapkowski This is your problem, your proxy for HTTPS URLs is returning `https://...` for the proxy URL instead of `http://`. However these proxies are configured in your environment should be fixed and then everything will work as you expect.\r\n\r\nBasically `urllib.request.getproxies()` should return `{'http': 'http://127.0.0.1:8888', 'https': 'http://127.0.0.1:8888'}` not `{'http': 'http://127.0.0.1:8888', 'https': 'https://127.0.0.1:8888'}`",
"I’ve tested it both ways. If I use the getproxies(), it still fails with the SSL error listed above.\r\n",
"You still haven't provided the output of the two urllib3-only snippets above in a way that I can understand. This would help us help you!",
"@pquentin I'm working on it today. When I use the urllib3 version it take a large amount of time to timeout.\r\n\r\n",
"@achapkowski Oh! I updated my snippets to avoid this.",
"Ok here are the results:\r\n- ```Proxy Schema http------------------------``` means I used: http = urllib3.ProxyManager(\"http://127.0.0.1:8888\") was used.\r\n- ```Proxy Schema https------------------------``` means I used: http = urllib3.ProxyManager(\"https://127.0.0.1:8888\") was used\r\n\r\nHere is the summary of what I am finding:\r\n\r\n- 1.26.7, 1.26.0 to 1.26.3 throw ProxyError with https proxy\r\n- 1.26.4 to 1.26.6 throw ```check_hostname requires server_hostname``` with https proxy\r\n- 1.25.11 sends up a warning with https proxy\r\n```\r\n1.26.7\r\nProxy Schema http------------------------\r\nNo issue\r\nProxy Schema https------------------------\r\nHTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by ProxyError('Cannot connect to proxy.', timeout('_ssl.c:1074: The handshake operation timed out')))\r\n\r\n1.26.6\r\nProxy Schema http------------------------\r\nNo issue\r\nProxy Schema https------------------------\r\ncheck_hostname requires server_hostname\r\n\r\n\r\n1.26.5\r\nProxy Schema http------------------------\r\nNo issue\r\nProxy Schema https------------------------\r\ncheck_hostname requires server_hostname\r\n\r\n1.26.4\r\nProxy Schema http------------------------\r\nNo issue\r\nProxy Schema https------------------------\r\ncheck_hostname requires server_hostname\r\n\r\n1.26.3\r\nProxy Schema http------------------------\r\nNo issue\r\nProxy Schema https------------------------\r\nHTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by ProxyError('Cannot connect to proxy.', timeout('_ssl.c:1074: The handshake operation timed out')))\r\n\r\n1.26.2\r\nProxy Schema http------------------------\r\nNo issue\r\nProxy Schema https------------------------\r\nHTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by ProxyError('Cannot connect to proxy.', timeout('_ssl.c:1074: The handshake operation timed out')))\r\n\r\n1.26.1\r\nProxy Schema http------------------------\r\nNo issue\r\nProxy Schema https------------------------\r\nHTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by ProxyError('Cannot connect to proxy.', timeout('_ssl.c:1074: The handshake operation timed out')))\r\n\r\n1.26.0\r\nProxy Schema http------------------------\r\nNo issue\r\nProxy Schema https------------------------\r\nHTTPSConnectionPool(host='httpbin.org', port=443): Max retries exceeded with url: /get?a=1&b=2 (Caused by ProxyError('Cannot connect to proxy.', timeout('_ssl.c:1074: The handshake operation timed out')))\r\n\r\n1.25.11\r\nProxy Schema http------------------------\r\nNo issue\r\nProxy Schema https------------------------\r\nC:\\envs\\mytestenv\\lib\\site-packages\\urllib3\\request.py:97: InvalidProxyConfigurationWarning: Your proxy configuration specified an HTTPS scheme for the proxy. Are you sure you want to use HTTPS to contact the proxy? This most likely indicates an error in your configuration. Read this issue for more info: https://github.com/urllib3/urllib3/issues/1850\r\n return self.urlopen(method, url, **extra_kw)\r\nNo issue\r\n```",
"Sorry, I wasn't clear, but testing the latest version was enough.\r\n\r\nWhat is the value of `HTTPS_PROXY`? It should be `http://127.0.0.1:8888` in your case, and I think you have `https://127.0.0.1:8888` instead.",
"I've testing both http and https:\r\n\r\n```\r\nport = \"8888\"\r\ndef call_http(port):\r\n try:\r\n http = urllib3.ProxyManager(f\"http://127.0.0.1:{port}\")\r\n r = http.request(\"GET\", \"https://httpbin.org/get?a=1&b=2\", timeout=5, retries=0)\r\n r.data\r\n return \"No issue\"\r\n except Exception as e:\r\n return str(e)\r\n\r\ndef call_https(port):\r\n try:\r\n http = urllib3.ProxyManager(f\"https://127.0.0.1:{port}\")\r\n r = http.request(\"GET\", \"https://httpbin.org/get?a=1&b=2\", timeout=5, retries=0)\r\n r.data\r\n return \"No issue\"\r\n except Exception as e:\r\n return str(e)\r\n```\r\n\r\nWhat is wrong with the test?\r\n",
"Quentin and I are trying to show you that your proxy only speaks HTTP, not HTTPS. Your tests above prove this fact. So any time you specify that your proxy URL is \"https\" you will have issues.\n\nThis is only a problem with your configuration and not with urllib3 or Requests. Set `HTTPS_PROXY=http://127.0.0.1:8888` and things should work.\n\nSome advice for future troubleshooting: when a maintainer asks you directly for a piece of information, provide that first and don't wait until we ask 2 or more times. We're trying to help you and that information is critical for us to do that.\n\nSince this isn't a defect I'm closing this issue. ",
"(Before 1.26 we were ignoring the scheme, which is why your test used to pass.)",
"Thank you for the help"
] |
https://api.github.com/repos/psf/requests/issues/5942
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5942/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5942/comments
|
https://api.github.com/repos/psf/requests/issues/5942/events
|
https://github.com/psf/requests/pull/5942
| 1,004,986,267 |
PR_kwDOABTKOs4sK0s0
| 5,942 |
Pass `chunk_size` to `Response.iter_*` methods in a consistent way
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/9677399?v=4",
"events_url": "https://api.github.com/users/ofek/events{/privacy}",
"followers_url": "https://api.github.com/users/ofek/followers",
"following_url": "https://api.github.com/users/ofek/following{/other_user}",
"gists_url": "https://api.github.com/users/ofek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ofek",
"id": 9677399,
"login": "ofek",
"node_id": "MDQ6VXNlcjk2NzczOTk=",
"organizations_url": "https://api.github.com/users/ofek/orgs",
"received_events_url": "https://api.github.com/users/ofek/received_events",
"repos_url": "https://api.github.com/users/ofek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ofek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ofek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ofek",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2021-09-23T04:00:41Z
|
2021-12-24T00:00:46Z
|
2021-09-24T23:02:00Z
|
CONTRIBUTOR
|
resolved
|
Use case: we would like to set a default `chunk_size` as shown in the new test.
Current behavior errors (as shown in the first test-only commit):
```
> self._content = b''.join(self.iter_content(CONTENT_CHUNK_SIZE)) or b''
E TypeError: iter_content() got multiple values for argument 'chunk_size'
.tox\default\lib\site-packages\requests\models.py:838: TypeError
```
The alternative would be adding a new instance attribute to serve as a fallback but I doubt new features are being considered before the next major release and we are currently blocked on this https://github.com/DataDog/integrations-core/pull/10183
cc @nateprewitt WDYT?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/9677399?v=4",
"events_url": "https://api.github.com/users/ofek/events{/privacy}",
"followers_url": "https://api.github.com/users/ofek/followers",
"following_url": "https://api.github.com/users/ofek/following{/other_user}",
"gists_url": "https://api.github.com/users/ofek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ofek",
"id": 9677399,
"login": "ofek",
"node_id": "MDQ6VXNlcjk2NzczOTk=",
"organizations_url": "https://api.github.com/users/ofek/orgs",
"received_events_url": "https://api.github.com/users/ofek/received_events",
"repos_url": "https://api.github.com/users/ofek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ofek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ofek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ofek",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5942/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5942/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5942.diff",
"html_url": "https://github.com/psf/requests/pull/5942",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5942.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5942"
}
| true |
[
"I'm actually quite hesitant to accept this. In the past when we've changed how we're invoking a method on a class that people interact a lot with it always breaks someone who is doing something quite like what's happening in the associated PR. It's happened countless times in the past to the point we've rejected PRs like this out of hand without further discussion or elaboration. (We take backwards compatibility a bit more seriously given how much of an impact even the slightest change can have on the wider ecosystem.)\n\nPeople assume the best way to get their custom behavior is to rely on the underlying library to almost never change and we do need to make changes from time to time.\n\nAs a rule, I prefer using named arguments but I don't think accepting this change will go well and there's nothing to prevent it from regressing that explains why we want to keep this behaviour this making it an easy test to delete.\n\nDatadog is already providing a wrapper around requests today. I'd argue that folks that want to change the default chunk size should be providing a wrapper around responses too. Think collaboration over inheritance or monkey-patching.\n",
"Would the addition of an instance attribute that serves as a fallback be accepted? If not, is there an existing mechanism for requests to return custom response objects?",
"Chunk size isn't a session-level property. It's a per-response property.\r\n\r\nAs I said, a Response wrapper that takes care of this for you is the right way to go. Think collaboration over inheritance.",
"> Chunk size isn't a session-level property. It's a per-response property.\r\n\r\nYes I mean e.g.:\r\n\r\n```python\r\nclass Response(object):\r\n def __init__(self):\r\n ...\r\n self.default_chunk_size = None\r\n\r\n def iter_lines(self, chunk_size=None, decode_unicode=False, delimiter=None):\r\n if chunk_size is None:\r\n if self.default_chunk_size is None:\r\n chunk_size = ITER_CHUNK_SIZE\r\n else:\r\n chunk_size = self.default_chunk_size\r\n\r\n for chunk in self.iter_content(chunk_size=chunk_size, decode_unicode=decode_unicode):\r\n ...\r\n```\r\n\r\n> As I said, a Response wrapper that takes care of this for you is the right way to go. Think collaboration over inheritance.\r\n\r\nDo you mean composition like this?\r\n\r\n```python\r\nclass CustomResponse:\r\n def __init__(self, response):\r\n self.__response = response\r\n\r\n def __getattr__(self, name):\r\n attr = getattr(self.__response, name)\r\n setattr(self, name, attr)\r\n return attr\r\n```",
"> Do you mean composition like this?\r\n\r\nYes. You can then override `iter_content` with logic to wrap the `__response` logic. That will also be your most reliable solution across versions of Requests that DataDog is supporting as well",
"I'm not a huge fan of adding a dependency (the aforementioned naïve approach was insufficient) but it does work: https://github.com/DataDog/integrations-core/pull/10183/commits/b57857c6c88592d245471f91fd780134c2f95de0\r\n\r\nThank you both for your time!"
] |
https://api.github.com/repos/psf/requests/issues/5941
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5941/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5941/comments
|
https://api.github.com/repos/psf/requests/issues/5941/events
|
https://github.com/psf/requests/pull/5941
| 1,004,218,756 |
PR_kwDOABTKOs4sIad5
| 5,941 |
doc: Include rmax github username
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/86386352?v=4",
"events_url": "https://api.github.com/users/Sousamba/events{/privacy}",
"followers_url": "https://api.github.com/users/Sousamba/followers",
"following_url": "https://api.github.com/users/Sousamba/following{/other_user}",
"gists_url": "https://api.github.com/users/Sousamba/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Sousamba",
"id": 86386352,
"login": "Sousamba",
"node_id": "MDQ6VXNlcjg2Mzg2MzUy",
"organizations_url": "https://api.github.com/users/Sousamba/orgs",
"received_events_url": "https://api.github.com/users/Sousamba/received_events",
"repos_url": "https://api.github.com/users/Sousamba/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Sousamba/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Sousamba/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Sousamba",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-09-22T12:09:32Z
|
2021-12-22T12:00:25Z
|
2021-09-23T11:44:33Z
|
NONE
|
resolved
|
Teste #5
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5941/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5941/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5941.diff",
"html_url": "https://github.com/psf/requests/pull/5941",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5941.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5941"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5940
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5940/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5940/comments
|
https://api.github.com/repos/psf/requests/issues/5940/events
|
https://github.com/psf/requests/pull/5940
| 1,003,407,174 |
PR_kwDOABTKOs4sFv1_
| 5,940 |
Don't mention pip as the reason for supporting py2
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5687998?v=4",
"events_url": "https://api.github.com/users/verhovsky/events{/privacy}",
"followers_url": "https://api.github.com/users/verhovsky/followers",
"following_url": "https://api.github.com/users/verhovsky/following{/other_user}",
"gists_url": "https://api.github.com/users/verhovsky/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/verhovsky",
"id": 5687998,
"login": "verhovsky",
"node_id": "MDQ6VXNlcjU2ODc5OTg=",
"organizations_url": "https://api.github.com/users/verhovsky/orgs",
"received_events_url": "https://api.github.com/users/verhovsky/received_events",
"repos_url": "https://api.github.com/users/verhovsky/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/verhovsky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/verhovsky/subscriptions",
"type": "User",
"url": "https://api.github.com/users/verhovsky",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-09-21T22:34:57Z
|
2021-12-21T00:00:43Z
|
2021-09-21T23:22:12Z
|
CONTRIBUTOR
|
resolved
|
since pip no longer supports Python 2
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5940/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5940/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5940.diff",
"html_url": "https://github.com/psf/requests/pull/5940",
"merged_at": "2021-09-21T23:22:12Z",
"patch_url": "https://github.com/psf/requests/pull/5940.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5940"
}
| true |
[
"I don't know if that is actually the official plan, but I get the impression that that's what's going to happen from this comment https://github.com/psf/requests/pull/5660#issuecomment-729236559",
"Hi @verhovsky, thanks for the PR. I'm not sure that comment was related to Python 2.7's deprecation. We had initially kept it as a requirement for `pip` but now that that's gone, we don't have a strong reason to keep it. It's just a matter of figuring out when we decide to formally stop Python 2.7 support. That likely won't happen before a major version bump of Requests.\r\n\r\nIf you'd like to replace the reference to `pip` with something more general like \"and intend to maintain Python 2.7 support within Requests until otherwise announced.\", I'm fine merging that.",
"@nateprewitt how about just removing that part? \"We do not have immediate plans\" and \"[we] intend to maintain Python 2.7 support within Requests until otherwise announced\" are basically saying the same thing twice."
] |
https://api.github.com/repos/psf/requests/issues/5939
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5939/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5939/comments
|
https://api.github.com/repos/psf/requests/issues/5939/events
|
https://github.com/psf/requests/issues/5939
| 1,002,355,217 |
I_kwDOABTKOs47vroR
| 5,939 |
Unable to connect to HTTPS proxy
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5839808?v=4",
"events_url": "https://api.github.com/users/MaysaMacedo/events{/privacy}",
"followers_url": "https://api.github.com/users/MaysaMacedo/followers",
"following_url": "https://api.github.com/users/MaysaMacedo/following{/other_user}",
"gists_url": "https://api.github.com/users/MaysaMacedo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/MaysaMacedo",
"id": 5839808,
"login": "MaysaMacedo",
"node_id": "MDQ6VXNlcjU4Mzk4MDg=",
"organizations_url": "https://api.github.com/users/MaysaMacedo/orgs",
"received_events_url": "https://api.github.com/users/MaysaMacedo/received_events",
"repos_url": "https://api.github.com/users/MaysaMacedo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/MaysaMacedo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MaysaMacedo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/MaysaMacedo",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2021-09-21T12:13:30Z
|
2021-12-20T18:00:23Z
|
2021-09-21T15:01:54Z
|
NONE
|
resolved
|
Unable to connect to HTTPS proxy using requests lib. The request works fine when using curl. Does requests support proxy with https?
## Expected Result
Able to connect to proxy regardless of the scheme used.
## Actual Result
Unable to connect to proxy with requests lib with HTTPS.
## Reproduction Steps
When using requests **2.20.0** and urllib3 **1.24.2**, The following traceback is seen:
```>>> import requests; requests.get('https://xxxx:13000', auth=('xx', 'yy'),proxies={'https': "https://x.x.x.x:3130"})
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/urllib3/connectionpool.py", line 594, in urlopen
self._prepare_proxy(conn)
File "/usr/lib/python3.6/site-packages/urllib3/connectionpool.py", line 805, in _prepare_proxy
conn.connect()
File "/usr/lib/python3.6/site-packages/urllib3/connection.py", line 322, in connect
self._tunnel()
File "/usr/lib64/python3.6/http/client.py", line 928, in _tunnel
(version, code, message) = response._read_status()
File "/usr/lib64/python3.6/http/client.py", line 272, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/lib64/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
ConnectionResetError: [Errno 104] Connection reset by peer
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/usr/lib/python3.6/site-packages/urllib3/connectionpool.py", line 638, in urlopen
_stacktrace=sys.exc_info()[2])
File "/usr/lib/python3.6/site-packages/urllib3/util/retry.py", line 399, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='xxxx', port=13000): Max retries exceeded with url: / (Caused by ProxyError('Cannot connect to proxy.', ConnectionResetError(104, 'Connection reset by peer')))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.6/site-packages/requests/api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "/usr/lib/python3.6/site-packages/requests/api.py", line 60, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python3.6/site-packages/requests/sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python3.6/site-packages/requests/sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python3.6/site-packages/requests/adapters.py", line 510, in send
raise ProxyError(e, request=request)
requests.exceptions.ProxyError: HTTPSConnectionPool(host='xxxx', port=13000): Max retries exceeded with url: / (Caused by ProxyError('Cannot connect to proxy.', ConnectionResetError(104, 'Connection reset by peer')))
```
When using the requests with **2.26.0** and urllib3 **1.26.6** I get the following:
`>>> import requests; requests.get('https://xxxx:13000', auth=('xx', 'yy'),proxies={'https': "https://x.x.x.x:3130"})
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.6/site-packages/requests/api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 696, in urlopen
self._prepare_proxy(conn)
File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 964, in _prepare_proxy
conn.connect()
File "/usr/local/lib/python3.6/site-packages/urllib3/connection.py", line 359, in connect
conn = self._connect_tls_proxy(hostname, conn)
File "/usr/local/lib/python3.6/site-packages/urllib3/connection.py", line 506, in _connect_tls_proxy
ssl_context=ssl_context,
File "/usr/local/lib/python3.6/site-packages/urllib3/util/ssl_.py", line 453, in ssl_wrap_socket
ssl_sock = _ssl_wrap_socket_impl(sock, context, tls_in_tls)
File "/usr/local/lib/python3.6/site-packages/urllib3/util/ssl_.py", line 495, in _ssl_wrap_socket_impl
return ssl_context.wrap_socket(sock)
File "/usr/lib64/python3.6/ssl.py", line 365, in wrap_socket
_context=self, _session=session)
File "/usr/lib64/python3.6/ssl.py", line 732, in __init__
raise ValueError("check_hostname requires server_hostname")
ValueError: check_hostname requires server_hostname`
With this same version after changing the request I still get:
`>>> import requests; requests.get(https://xxxx:13000', auth=('xx', 'yy'),proxies={'https': "x.x.x.x:3130"})
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.6/site-packages/requests/api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.6/site-packages/requests/adapters.py", line 510, in send
raise ProxyError(e, request=request)
requests.exceptions.ProxyError: HTTPSConnectionPool(host='xxxx, port=13000): Max retries exceeded with url: / (Caused by ProxyError('Cannot connect to proxy.', ConnectionResetError(104, 'Connection reset by peer')))`
The following curl command works fine:
`
curl -U xx:yy -x https://x.x.x.x:3130 https://xxxx:13000`
The Proxy is configured with:
```
acl localnet src all
acl Safe_ports port 80
acl Safe_ports port 443
acl Safe_ports port 1025-65535
http_port 3128
https_port 3130 cert=/etc/squid/certs/squid-ca-cert-key.pem
coredump_dir /var/spool/squid
auth_param basic program /usr/lib64/squid/basic_ncsa_auth /etc/squid/htpasswd
auth_param basic children 5
auth_param basic realm Squid Basic Authentication
auth_param basic credentialsttl 2 hours
acl auth_users proxy_auth REQUIRED
http_access deny !auth_users
http_access deny !Safe_ports
http_access allow localnet
http_access deny all
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5939/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5939/timeline
| null |
completed
| null | null | false |
[
"Requests and urllib3 didn't support HTTPS proxies before urllib3 v1.26+, your example above was connecting to the [proxy via HTTP instead of HTTPS](https://github.com/urllib3/urllib3/issues/1850). So now when you install urllib3 v1.26+ it's actually trying to connect to the proxy via HTTPS but two things:\r\n\r\n- I'm not sure Requests explicitly supports HTTPS proxies yet? Might just work / barely work on chance (@nateprewitt can you confirm?)\r\n- If you try connecting to the proxy only via urllib3 and it doesn't work I'd love if you could [open an issue on urllib3](https://github.com/urllib3/urllib3/issues). If you could also try installing the latest dev version of urllib3 via `$ python -m pip install git+https://github.com/urllib3/[email protected]` that'd be extra helpful.",
"@sethmlarson Thank you for the reply.\r\n\r\nYou're right, with 1.26.x it worked fine:\r\n```\r\nfrom urllib3 import ProxyManager, make_headers\r\ndefault_headers = make_headers(proxy_basic_auth='xx:yy')\r\nhttp = ProxyManager(\"https://xxxx:3130\", proxy_headers=default_headers)\r\nhttp.request('GET', 'https://x.x.x.x:13000/v3').status\r\n200\r\n```\r\n\r\nMaybe this [commit](https://github.com/urllib3/urllib3/commit/906d982ab079ecf7c541e6fd8beb17c84bcc02c1) helped with the issue. Do you know when it will be available?",
"@MaysaMacedo Awesome, thanks for testing this. That appears to be the case, we're working on one more blocker for a 1.26.7 release but once that lands hopefully we'll be able to make a release afterwards. No exact timelines though, all volunteer time :)\r\n\r\nClosing this as it's not an issue in the Requests library.",
"@sethmlarson Thank you."
] |
https://api.github.com/repos/psf/requests/issues/5938
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5938/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5938/comments
|
https://api.github.com/repos/psf/requests/issues/5938/events
|
https://github.com/psf/requests/pull/5938
| 1,000,005,027 |
PR_kwDOABTKOs4r7AQA
| 5,938 |
Update README Logos
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/76828314?v=4",
"events_url": "https://api.github.com/users/FayasNoushad/events{/privacy}",
"followers_url": "https://api.github.com/users/FayasNoushad/followers",
"following_url": "https://api.github.com/users/FayasNoushad/following{/other_user}",
"gists_url": "https://api.github.com/users/FayasNoushad/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/FayasNoushad",
"id": 76828314,
"login": "FayasNoushad",
"node_id": "MDQ6VXNlcjc2ODI4MzE0",
"organizations_url": "https://api.github.com/users/FayasNoushad/orgs",
"received_events_url": "https://api.github.com/users/FayasNoushad/received_events",
"repos_url": "https://api.github.com/users/FayasNoushad/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/FayasNoushad/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/FayasNoushad/subscriptions",
"type": "User",
"url": "https://api.github.com/users/FayasNoushad",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-09-18T10:59:48Z
|
2021-12-17T12:00:26Z
|
2021-09-18T11:10:19Z
|
NONE
|
resolved
|
- Updated logos to center
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5938/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5938/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5938.diff",
"html_url": "https://github.com/psf/requests/pull/5938",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5938.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5938"
}
| true |
[
"Hi there, thanks for sending a pull request! As a rule we don't accept minor cosmetic updates like this. ",
"> Hi there, thanks for sending a pull request! As a rule we don't accept minor cosmetic updates like this.\r\n\r\nOk, No problem."
] |
https://api.github.com/repos/psf/requests/issues/5937
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5937/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5937/comments
|
https://api.github.com/repos/psf/requests/issues/5937/events
|
https://github.com/psf/requests/issues/5937
| 999,116,673 |
I_kwDOABTKOs47jU-B
| 5,937 |
request and response to bytearrray and back
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/47860780?v=4",
"events_url": "https://api.github.com/users/mijosch/events{/privacy}",
"followers_url": "https://api.github.com/users/mijosch/followers",
"following_url": "https://api.github.com/users/mijosch/following{/other_user}",
"gists_url": "https://api.github.com/users/mijosch/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mijosch",
"id": 47860780,
"login": "mijosch",
"node_id": "MDQ6VXNlcjQ3ODYwNzgw",
"organizations_url": "https://api.github.com/users/mijosch/orgs",
"received_events_url": "https://api.github.com/users/mijosch/received_events",
"repos_url": "https://api.github.com/users/mijosch/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mijosch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mijosch/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mijosch",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-09-17T08:58:04Z
|
2021-12-16T11:00:36Z
|
2021-09-17T10:55:11Z
|
NONE
|
resolved
|
Hi,
i want to make a encrypted tunnel and therefore I need to convert request/response to a bytearray, encrypt the bytearray, transport it, decrypt it and then recreate the request/response from bytearray.
So i need a to_bytearray() and a from_bytearray() for both, request and response
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5937/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5937/timeline
| null |
completed
| null | null | false |
[
"Start with #969 this library is under a feature-freeze. New features and API surface area are not being added"
] |
https://api.github.com/repos/psf/requests/issues/5936
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5936/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5936/comments
|
https://api.github.com/repos/psf/requests/issues/5936/events
|
https://github.com/psf/requests/issues/5936
| 998,380,556 |
I_kwDOABTKOs47ghQM
| 5,936 |
`cert` parameter does not accept a single `pathlib.Path` object as argument
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
}
|
[
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] |
open
| false | null |
[] | null | 7 |
2021-09-16T16:01:24Z
|
2023-02-01T04:49:33Z
| null |
NONE
| null |
requests seems to have special handling for when the `cert` parameter is a single `str`, but does not extend the same special handling to `pathlib.Path`, meaning currently you either have to do `cert=str(path)` or `cert=(path, path)`.
## Expected Result
`Path` objects should be handled just like `str`.
## Actual Result
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/nyuszika7h/test/.venv/lib/python3.9/site-packages/requests/api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "/home/nyuszika7h/test/.venv/lib/python3.9/site-packages/requests/api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "/home/nyuszika7h/test/.venv/lib/python3.9/site-packages/requests/sessions.py", line 542, in request
resp = self.send(prep, **send_kwargs)
File "/home/nyuszika7h/test/.venv/lib/python3.9/site-packages/requests/sessions.py", line 655, in send
r = adapter.send(request, **kwargs)
File "/home/nyuszika7h/test/.venv/lib/python3.9/site-packages/requests/adapters.py", line 416, in send
self.cert_verify(conn, request.url, verify, cert)
File "/home/nyuszika7h/test/.venv/lib/python3.9/site-packages/requests/adapters.py", line 243, in cert_verify
conn.cert_file = cert[0]
TypeError: 'PosixPath' object is not subscriptable
```
## Reproduction Steps
```python
from pathlib import Path
import requests
requests.get('https://example.com', cert=Path('cert.pem'))
```
## System Information
$ python -m requests.help
```json
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.5"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.9.2"
},
"platform": {
"release": "5.10.0-8-amd64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.26.6"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
| null |
{
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/5936/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5936/timeline
| null | null | null | null | false |
[
"Hi @nyuszika7h, this seems like a reasonable request but is going to be somewhat difficult to implement prior to dropping 2.7 support. We don't intend to add backports as a dependency, so we'll leave this a todo for when the project finally moves to only Python 3 support. Thanks!",
"I don't think this is entirely reasonable as pathlib is garabage. Expecting it to just work in places clearly documented as accepting either `str` or `Tuple[str, str]` isn't reasonable. ",
"How exactly is it \"garbage\"? It has existed since Python 3.4 and is becoming a standard, take it up with the Python maintainers, not me. If you're developing a standalone program you have every right to not use pathlib if you don't like it, but developers of a major library used by thousands of other developers should consider supporting it regardless of their personal views. It doesn't really add any undue maintenance burden either.\r\n\r\n`tuple[Path, Path]` already works fine with requests today, and if type hints are a concern, it can be done with an union type which is the officially recommended way if you need backwards compatibility with `str`. (In an ideal world, maybe we'd *only* accept `Path` objects, but that's not quite feasible yet – backwards compatibility is a concern and I would at least like `p''` literals in that case – so a simple type alias can be created instead to keep function signatures simple.)",
"It makes sense that it would be a good idea to allow some sort of path-like object, even without specifying examples of path-like object types with type hinting. If you look at https://docs.python.org/3/glossary.html#term-path-like-object and https://docs.python.org/3/library/os.html#os.PathLike, it shouldn't be unreasonable to check if an object is path-like.\r\n\r\nThe docs do mention [here](https://docs.python.org/3/library/os.html#os.PathLike) that `os.PathLike` is new in version 3.6. So, to preserve backwards compatibility we can check for `hasattr(cert, '__fspath__')` rather than checking `isinstance(cert, os.PathLike)`. I recommend doing a similar check for if the object is subscriptable `hasattr(cert, '__getitem__')`, to prevent subscriptable-related `TypeError`s that could otherwise be handled.\r\n\r\nWe can replace...\r\n\r\nhttps://github.com/psf/requests/blob/e8a9bd7415986278fe41736a3c224232b9f98c39/requests/adapters.py#L241-L247\r\n\r\nWith...\r\n\r\n```python3\r\nif cert:\r\n if not isinstance(cert, basestring):\r\n # a subscriptable object\r\n if hasattr(cert, '__getitem__'):\r\n conn.cert_file = cert[0]\r\n conn.key_file = cert[1]\r\n elif hasattr(cert, '__fspath__'):\r\n # a path-like object implements __fspath__\r\n # see https://docs.python.org/3/library/os.html#os.PathLike\r\n conn.cert_file = cert.__fspath__()\r\n else:\r\n conn.cert_file = str(cert)\r\n else:\r\n conn.cert_file = cert\r\n conn.key_file = None\r\n```\r\n\r\nThough I've never used `pathlib` yet, if it is being mentioned in Python's stdlib docs and is becoming more standard, it may be good to start looking into backwards-compatible ways to support it, like in the example above. We can handle more types this way, and if errors occur, they should be because the string provided was an invalid path to a certificate, rather than because the type provided wasn't acceptable.\r\n\r\n**If `os.path` is allowing path-like objects, Requests should, too** ",
"While requests still supports Python 2, it's probably better to use `getattr()` rather than `hasattr()` as the latter catches all exceptions, not just AttributeError. But hopefully in the next major release that won't be a problem anymore as Python 2 is EOL.",
"Hi all,\r\n\r\nJust combing through issues in some of my favorite python libs looking for ways to contribute. \r\n\r\nSeems y'all have dropped support for Python 2 in the requests library, so this might be a great thing to implement at this time, unless there's something I'm not understanding fully. I'm looking for issues good for a GitHub newbie to tackle. And, while I would love to help with this, it seems @steveberdy has a solution in the notes above, so I wouldn't want to steal thunder by patching in code they've written.\r\n\r\nSorry for any misunderstandings and hope this helps.\r\nThanks.",
"This issue is still ongoing with v2.28.2. I think I'll make a PR since this doesn't exactly break the rules for the indefinite feature-freeze."
] |
https://api.github.com/repos/psf/requests/issues/5935
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5935/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5935/comments
|
https://api.github.com/repos/psf/requests/issues/5935/events
|
https://github.com/psf/requests/issues/5935
| 998,107,820 |
I_kwDOABTKOs47feqs
| 5,935 |
I hope the send method of the Session Object can support the Request Object
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/23182601?v=4",
"events_url": "https://api.github.com/users/MengMengDeLiLaoShi/events{/privacy}",
"followers_url": "https://api.github.com/users/MengMengDeLiLaoShi/followers",
"following_url": "https://api.github.com/users/MengMengDeLiLaoShi/following{/other_user}",
"gists_url": "https://api.github.com/users/MengMengDeLiLaoShi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/MengMengDeLiLaoShi",
"id": 23182601,
"login": "MengMengDeLiLaoShi",
"node_id": "MDQ6VXNlcjIzMTgyNjAx",
"organizations_url": "https://api.github.com/users/MengMengDeLiLaoShi/orgs",
"received_events_url": "https://api.github.com/users/MengMengDeLiLaoShi/received_events",
"repos_url": "https://api.github.com/users/MengMengDeLiLaoShi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/MengMengDeLiLaoShi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MengMengDeLiLaoShi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/MengMengDeLiLaoShi",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-09-16T11:36:14Z
|
2021-12-16T03:00:19Z
|
2021-09-16T11:41:36Z
|
NONE
|
resolved
|
I will define multiple Request objects in advance, define the request data and parameters in the Request object, and then want to send the Request through the send method of session, but the send method requires preparedrequests object.
Why not convert the Requests object into a PreparedRequests object when sending
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5935/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5935/timeline
| null |
completed
| null | null | false |
[
"Because there's a different API that's been explicitly defined and well-documented for this and we're not changing it. This project is under a feature-freeze and the API is quite stable. Changing this would destabilize it.",
"Thank you for your quick reply. Can you clarify what \"a different API\" is？"
] |
https://api.github.com/repos/psf/requests/issues/5934
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5934/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5934/comments
|
https://api.github.com/repos/psf/requests/issues/5934/events
|
https://github.com/psf/requests/pull/5934
| 996,975,290 |
PR_kwDOABTKOs4rx0NB
| 5,934 |
fix: minor typos
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/947110?v=4",
"events_url": "https://api.github.com/users/kkirsche/events{/privacy}",
"followers_url": "https://api.github.com/users/kkirsche/followers",
"following_url": "https://api.github.com/users/kkirsche/following{/other_user}",
"gists_url": "https://api.github.com/users/kkirsche/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kkirsche",
"id": 947110,
"login": "kkirsche",
"node_id": "MDQ6VXNlcjk0NzExMA==",
"organizations_url": "https://api.github.com/users/kkirsche/orgs",
"received_events_url": "https://api.github.com/users/kkirsche/received_events",
"repos_url": "https://api.github.com/users/kkirsche/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kkirsche/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kkirsche/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kkirsche",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-09-15T11:33:32Z
|
2021-12-14T12:00:36Z
|
2021-09-15T11:43:13Z
|
CONTRIBUTOR
|
resolved
|
Fix a few minor typos located throughout the package.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5934/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5934/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5934.diff",
"html_url": "https://github.com/psf/requests/pull/5934",
"merged_at": "2021-09-15T11:43:13Z",
"patch_url": "https://github.com/psf/requests/pull/5934.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5934"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5933
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5933/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5933/comments
|
https://api.github.com/repos/psf/requests/issues/5933/events
|
https://github.com/psf/requests/pull/5933
| 996,689,394 |
PR_kwDOABTKOs4rw6yE
| 5,933 |
ci: optimize ci workflow
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1890238?v=4",
"events_url": "https://api.github.com/users/willin/events{/privacy}",
"followers_url": "https://api.github.com/users/willin/followers",
"following_url": "https://api.github.com/users/willin/following{/other_user}",
"gists_url": "https://api.github.com/users/willin/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/willin",
"id": 1890238,
"login": "willin",
"node_id": "MDQ6VXNlcjE4OTAyMzg=",
"organizations_url": "https://api.github.com/users/willin/orgs",
"received_events_url": "https://api.github.com/users/willin/received_events",
"repos_url": "https://api.github.com/users/willin/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/willin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/willin/subscriptions",
"type": "User",
"url": "https://api.github.com/users/willin",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-09-15T05:58:52Z
|
2021-12-15T01:22:24Z
|
2021-09-16T01:04:34Z
|
NONE
|
resolved
|
ignore paths that do not need to be tested.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5933/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5933/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5933.diff",
"html_url": "https://github.com/psf/requests/pull/5933",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5933.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5933"
}
| true |
[
"Thank you for sending this but we'll likely not accept this. We used to have CI jobs that verified docs built properly. We'll likely reinstate that in the future"
] |
https://api.github.com/repos/psf/requests/issues/5932
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5932/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5932/comments
|
https://api.github.com/repos/psf/requests/issues/5932/events
|
https://github.com/psf/requests/issues/5932
| 996,468,550 |
I_kwDOABTKOs47ZOdG
| 5,932 |
Stuck on starting a HTTPS connection
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/29289434?v=4",
"events_url": "https://api.github.com/users/CyanBook/events{/privacy}",
"followers_url": "https://api.github.com/users/CyanBook/followers",
"following_url": "https://api.github.com/users/CyanBook/following{/other_user}",
"gists_url": "https://api.github.com/users/CyanBook/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/CyanBook",
"id": 29289434,
"login": "CyanBook",
"node_id": "MDQ6VXNlcjI5Mjg5NDM0",
"organizations_url": "https://api.github.com/users/CyanBook/orgs",
"received_events_url": "https://api.github.com/users/CyanBook/received_events",
"repos_url": "https://api.github.com/users/CyanBook/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/CyanBook/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CyanBook/subscriptions",
"type": "User",
"url": "https://api.github.com/users/CyanBook",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-09-14T21:48:21Z
|
2021-12-14T12:00:35Z
|
2021-09-15T11:38:00Z
|
NONE
|
resolved
|
Hi, seems a stupid problem but i cannot figure it out.
This issue seems to happen only with this URL, but i cannot be sure.
Using a different HTTPX on my machine or Requests client on another machine works.
Although i wasn't able to replicate it on another machine, i think it's a good idea to try and resolve the problem.
URL: https://nominatim.openstreetmap.org/search?q=Milan&format=json&polygon=0
## Expected Result
Get the body of the URL using requests.get.
## Actual Result
It gets stuck and seems to be in an infinite loop.
With logging on DEBUG, the only info it prints is:
`[14-Sep-21 23:17:30] [DEBUG] - Starting new HTTPS connection (1): nominatim.openstreetmap.org:443`
and nothing more.
## Reproduction Steps
```python
import requests
url = "https://nominatim.openstreetmap.org/search?q=Milan&format=json&polygon=0"
response = requests.get(url)
print(response.text)
```
## System Information
```
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.5"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.9.5"
},
"platform": {
"release": "5.11.0-7633-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "101010af"
},
"urllib3": {
"version": "1.26.6"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
```
Note:
I know that issues which are hard to replicate are usually not that helpful, but i also know that reporting a bug (that is happening on my machine) is better than doing nothing.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5932/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5932/timeline
| null |
completed
| null | null | false |
[
"Have you tried setting a connect timeout?\r\n\r\nI can not reproduce this either. The DNS seems to only have 1 entry, so if that server is unreachable via your network or overloaded for some period of time, retrying might work.\r\n\r\nI also noted that the response I got back was that I was blocked for abusing the service. Maybe it's seeing your headers (which include the `python-requests` name and version) and throttling you to disincline you from abusing the service? A different client with different `User-Agent` headers and a different machine (with a different IP) would not trigger the abuse detection.\r\n\r\nEither way, this isn't a bug in Requests but a problem between you and OpenStreetMap"
] |
https://api.github.com/repos/psf/requests/issues/5931
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5931/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5931/comments
|
https://api.github.com/repos/psf/requests/issues/5931/events
|
https://github.com/psf/requests/issues/5931
| 991,144,077 |
MDU6SXNzdWU5OTExNDQwNzc=
| 5,931 |
How pass urllib3 assert_hostname in Requests Adapter?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5131271?v=4",
"events_url": "https://api.github.com/users/achapkowski/events{/privacy}",
"followers_url": "https://api.github.com/users/achapkowski/followers",
"following_url": "https://api.github.com/users/achapkowski/following{/other_user}",
"gists_url": "https://api.github.com/users/achapkowski/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/achapkowski",
"id": 5131271,
"login": "achapkowski",
"node_id": "MDQ6VXNlcjUxMzEyNzE=",
"organizations_url": "https://api.github.com/users/achapkowski/orgs",
"received_events_url": "https://api.github.com/users/achapkowski/received_events",
"repos_url": "https://api.github.com/users/achapkowski/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/achapkowski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/achapkowski/subscriptions",
"type": "User",
"url": "https://api.github.com/users/achapkowski",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-09-08T13:32:07Z
|
2021-12-08T10:00:22Z
|
2021-09-08T22:44:59Z
|
NONE
|
resolved
|
Hello,
What do I need to customize to prevent host name checking? I am assuming it's the HTTPSConnectionPool's assert_hostname=False bit of code.
Since I cannot find any documentation on this, I was wondering if the developers can help me decide where to implement this customization?
My guess was by inheriting from `HTTPAdapter` then modifying the `__init__()` to allow a user to pass in the assert_hostname=True/False.
Once that is done, would I overload the `verify_cert` method?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5931/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5931/timeline
| null |
completed
| null | null | false |
[
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here. Please be sure to include what you've tried, what you saw as a result, and what you were expecting.",
"@sigmavirus24 I did try stack exchange, posted code and got down voted. I came here for help, because I can't find the documentation on where/how this should be done. \r\n\r\nhttps://stackoverflow.com/questions/69102923/python-requests-setting-assert-hostname-to-false"
] |
https://api.github.com/repos/psf/requests/issues/5930
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5930/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5930/comments
|
https://api.github.com/repos/psf/requests/issues/5930/events
|
https://github.com/psf/requests/pull/5930
| 990,422,421 |
MDExOlB1bGxSZXF1ZXN0NzI5MDEzODQx
| 5,930 |
Update lock-issues.yml
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
] | null | 0 |
2021-09-07T23:18:14Z
|
2021-12-07T00:00:34Z
|
2021-09-08T00:00:31Z
|
CONTRIBUTOR
|
resolved
|
Run this hourly. I'm not seeing any effects, let's see if
running it more frequently will allow it to avoid the GitHub ratelimit
https://github.com/dessant/lock-threads#why-are-only-some-issues-and-pull-requests-processed
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5930/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5930/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5930.diff",
"html_url": "https://github.com/psf/requests/pull/5930",
"merged_at": "2021-09-08T00:00:31Z",
"patch_url": "https://github.com/psf/requests/pull/5930.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5930"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5929
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5929/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5929/comments
|
https://api.github.com/repos/psf/requests/issues/5929/events
|
https://github.com/psf/requests/issues/5929
| 988,554,714 |
MDU6SXNzdWU5ODg1NTQ3MTQ=
| 5,929 |
latest version of requests is not backwards compatible
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/17232670?v=4",
"events_url": "https://api.github.com/users/jbrepogmailcom/events{/privacy}",
"followers_url": "https://api.github.com/users/jbrepogmailcom/followers",
"following_url": "https://api.github.com/users/jbrepogmailcom/following{/other_user}",
"gists_url": "https://api.github.com/users/jbrepogmailcom/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jbrepogmailcom",
"id": 17232670,
"login": "jbrepogmailcom",
"node_id": "MDQ6VXNlcjE3MjMyNjcw",
"organizations_url": "https://api.github.com/users/jbrepogmailcom/orgs",
"received_events_url": "https://api.github.com/users/jbrepogmailcom/received_events",
"repos_url": "https://api.github.com/users/jbrepogmailcom/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jbrepogmailcom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbrepogmailcom/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jbrepogmailcom",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-09-05T17:07:36Z
|
2021-12-04T19:00:24Z
|
2021-09-05T18:29:39Z
|
NONE
|
resolved
|
Summary.
## Expected Result
requests(URL, headers, payload) returns payload
What you expected.
## Actual Result
Error, because new version of requests does not accept 3 parameters, only 2. It causes all python programs that use requests with 3 parameters to crash and need to be reprogrammed.
What happened instead.
## Reproduction Steps
```python
import requests
r = requests.get(URL, headers=headers, params=payload)
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "2.8"
},
"implementation": {
"name": "CPython",
"version": "3.8.10"
},
"platform": {
"release": "5.11.0-27-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.22.0"
},
"system_ssl": {
"version": "1010106f"
},
"urllib3": {
"version": "1.25.8"
},
"using_pyopenssl": false
}
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/17232670?v=4",
"events_url": "https://api.github.com/users/jbrepogmailcom/events{/privacy}",
"followers_url": "https://api.github.com/users/jbrepogmailcom/followers",
"following_url": "https://api.github.com/users/jbrepogmailcom/following{/other_user}",
"gists_url": "https://api.github.com/users/jbrepogmailcom/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jbrepogmailcom",
"id": 17232670,
"login": "jbrepogmailcom",
"node_id": "MDQ6VXNlcjE3MjMyNjcw",
"organizations_url": "https://api.github.com/users/jbrepogmailcom/orgs",
"received_events_url": "https://api.github.com/users/jbrepogmailcom/received_events",
"repos_url": "https://api.github.com/users/jbrepogmailcom/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jbrepogmailcom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jbrepogmailcom/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jbrepogmailcom",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5929/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5929/timeline
| null |
completed
| null | null | false |
[
"Hi @jbrepogmailcom, could you elaborate more on what the actual issue you're hitting is. Nothing changed in v2.x for Requests around this behavior and the example works without issue. I'd recommend checking to see if you have a requests.py file that's overwriting the namespace.",
"Hello, I am very sorry but I corrected the script and I do not have original error message.\r\n\r\nWhat I know for sure is that `r=requests.get(URL, headers=headers, payload=payload)` worked for years until few days (or weeks?) ago. It may have been some automatic linux update that I got recently, but the script stopped working. When I debugged it manually, I was getting error that `r` does not exist on next line. So I ran `r=requests.get(URL, headers, payload)` and I got error message like requests.get accepts only 2 parameters, but not 3.\r\n\r\nWhen I deleted `headers` and changed command to `r=requests.get(URL, payload=payload)` then it worked normally.\r\n\r\n(headers and payload were variables)\r\n\r\nJan",
"I tried it for second time manually with all 3 parameters and it worked, so I do not know what was the cause. I am sorry and thanks for your time. You can mark issue as invalid."
] |
https://api.github.com/repos/psf/requests/issues/5928
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5928/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5928/comments
|
https://api.github.com/repos/psf/requests/issues/5928/events
|
https://github.com/psf/requests/pull/5928
| 987,943,190 |
MDExOlB1bGxSZXF1ZXN0NzI2OTU0MzAy
| 5,928 |
Add support for 3.10
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-09-03T16:41:45Z
|
2021-12-03T02:11:50Z
|
2021-09-04T02:03:16Z
|
MEMBER
|
resolved
|
This will make sure we don't introduce any regressions into the code base prior to the official 3.10 release. At that point, we'll promote this to the normal test runner on all platforms.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5928/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5928/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5928.diff",
"html_url": "https://github.com/psf/requests/pull/5928",
"merged_at": "2021-09-04T02:03:16Z",
"patch_url": "https://github.com/psf/requests/pull/5928.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5928"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5927
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5927/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5927/comments
|
https://api.github.com/repos/psf/requests/issues/5927/events
|
https://github.com/psf/requests/pull/5927
| 986,734,837 |
MDExOlB1bGxSZXF1ZXN0NzI1OTEyNTQw
| 5,927 |
Add back logo
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/291575?v=4",
"events_url": "https://api.github.com/users/flying-sheep/events{/privacy}",
"followers_url": "https://api.github.com/users/flying-sheep/followers",
"following_url": "https://api.github.com/users/flying-sheep/following{/other_user}",
"gists_url": "https://api.github.com/users/flying-sheep/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/flying-sheep",
"id": 291575,
"login": "flying-sheep",
"node_id": "MDQ6VXNlcjI5MTU3NQ==",
"organizations_url": "https://api.github.com/users/flying-sheep/orgs",
"received_events_url": "https://api.github.com/users/flying-sheep/received_events",
"repos_url": "https://api.github.com/users/flying-sheep/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/flying-sheep/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/flying-sheep/subscriptions",
"type": "User",
"url": "https://api.github.com/users/flying-sheep",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2021-09-02T13:32:25Z
|
2021-12-02T08:00:32Z
|
2021-09-02T15:52:11Z
|
NONE
|
resolved
|
Fixes #5926
I’m not a web designer, so the positioning might be adjusted.
However, the logo’s restoration should take priority over bikeshedding.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5927/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5927/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5927.diff",
"html_url": "https://github.com/psf/requests/pull/5927",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5927.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5927"
}
| true |
[
"Should we add it to README.md also?",
"I think so, and this PR does it (I updated the title to reflect that). Some people will never see the sphinx docs page, so it makes sense to have it in both locations.",
"Hi @flying-sheep, we already have a PR open for this in #5923. Thanks for the contribution though.",
"Oh, sorry, didn’t see that one!"
] |
https://api.github.com/repos/psf/requests/issues/5926
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5926/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5926/comments
|
https://api.github.com/repos/psf/requests/issues/5926/events
|
https://github.com/psf/requests/issues/5926
| 986,726,075 |
MDU6SXNzdWU5ODY3MjYwNzU=
| 5,926 |
Restore logo
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/291575?v=4",
"events_url": "https://api.github.com/users/flying-sheep/events{/privacy}",
"followers_url": "https://api.github.com/users/flying-sheep/followers",
"following_url": "https://api.github.com/users/flying-sheep/following{/other_user}",
"gists_url": "https://api.github.com/users/flying-sheep/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/flying-sheep",
"id": 291575,
"login": "flying-sheep",
"node_id": "MDQ6VXNlcjI5MTU3NQ==",
"organizations_url": "https://api.github.com/users/flying-sheep/orgs",
"received_events_url": "https://api.github.com/users/flying-sheep/received_events",
"repos_url": "https://api.github.com/users/flying-sheep/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/flying-sheep/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/flying-sheep/subscriptions",
"type": "User",
"url": "https://api.github.com/users/flying-sheep",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-09-02T13:25:33Z
|
2021-12-01T16:06:01Z
|
2021-09-02T15:51:18Z
|
NONE
|
resolved
|
@kennethreitz mentioned he had a single condition for transferring stewardship for this repository:
> When I transferred the project to the PSF, per textual agreement with @ewdurbin, my only requirement was that the logo stayed in place.
I therefore assume that the removal in #5562 (along other images) was accidental and this will swiftly rectified. I’ll do a PR.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5926/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5926/timeline
| null |
completed
| null | null | false |
[
"Hi @flying-sheep, we're aware and this has already been addressed in #5923. Thanks."
] |
https://api.github.com/repos/psf/requests/issues/5925
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5925/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5925/comments
|
https://api.github.com/repos/psf/requests/issues/5925/events
|
https://github.com/psf/requests/issues/5925
| 986,229,385 |
MDU6SXNzdWU5ODYyMjkzODU=
| 5,925 |
Python 3.10 Readiness
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] |
{
"closed_at": "2021-12-30T21:48:07Z",
"closed_issues": 11,
"created_at": "2021-09-02T07:23:33Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/29",
"id": 7115399,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/29/labels",
"node_id": "MI_kwDOABTKOs4AbJKH",
"number": 29,
"open_issues": 0,
"state": "closed",
"title": "2.27.0",
"updated_at": "2021-12-30T21:48:07Z",
"url": "https://api.github.com/repos/psf/requests/milestones/29"
}
| 6 |
2021-09-02T06:37:24Z
|
2021-12-03T02:11:50Z
|
2021-09-04T02:03:27Z
|
MEMBER
|
resolved
|
Python 3.10 is just a little over a month away and we have some issues that need to be addressed in Requests. Currently our test suite relies heavily on `httpbin` which has been largely unmaintained since 2017. As a dependency, it relies on `brotlipy` which has since migrated to a new package [`brotlicffi`](https://github.com/python-hyper/brotlicffi). Given these are both C-based, we can't compile them in CI environments and rely on wheels being available.
It looks unlikely that we'll get a new wheel for `brotlipy`, so we'll need to either find a way to migrate `httpbin` to `brotlicffi`, or work out another alternative for the test suite. I still have PyPI credentials for `httpbin` to cut a new release, but there's a matter of ownership to be worked out now that it's under [Postmanlabs](https://github.com/postmanlabs/httpbin). It also appears to have several versions in the commit history that have never been published that we'll need to consider.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5925/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5925/timeline
| null |
completed
| null | null | false |
[
"I was removed from `httpbin` when it was sold/transferred to Postman. Maybe it's time to fork/use something different? #5915 has the start of something we might be able to use instead",
"@nateprewitt I can get you a new wheel of brotlipy for Python 3.10. I've never built a wheel from a build candidate however. Is the way to go there to build a wheel from a build candidate and then once Python 3.10 is officially released upload a new wheel for 3.10 with an incremented build number? If that works for you I can take care of that step.",
"If we can push a new wheel from the brotlipy tag, that may be _much_ easier than the alternatives in the short term. I would assume the wheels would be virtually identical between the rc and official release. If we have issues though, we can definitely revisit updating the build number with a wheel from the official 3.10 release. Thank you!!",
"Uploaded `abi3` wheels for brotlipy which are compatible with Python 3.10 and all future Python 3 versions: https://twitter.com/sethmlarson/status/1433488043529359369",
"Now that @sethmlarson has been kind enough to get us unblocked, I think we should be set with #5928.",
"@sigmavirus24 If it's decided that #5915 is the future of requests' testing, I will refactor all of the tests to use it and then remove the existing test server."
] |
https://api.github.com/repos/psf/requests/issues/5924
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5924/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5924/comments
|
https://api.github.com/repos/psf/requests/issues/5924/events
|
https://github.com/psf/requests/pull/5924
| 986,194,487 |
MDExOlB1bGxSZXF1ZXN0NzI1NDI0NzEx
| 5,924 |
Refactor rebuild_proxies to separate resolution and auth handling
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2021-09-02T06:01:26Z
|
2022-02-22T20:00:23Z
|
2021-11-24T19:21:01Z
|
MEMBER
|
resolved
|
This is a proposal for handling #5888 that's come out of discussion in an alternative PR (#5893). Given that we've stalled out on progress there for a few weeks, this PR is to help drive a conclusion. The approach taken here is to mitigate the incorrect behavior of stripping `Proxy-Authorization` headers off all requests sent with `Session.send`. This will not address the performance concerns from #5891 as that's a more significant problem without a clear answer.
The goal of driving this separately from #5891 is that one is an unintended breakage in basic behavior of the library and the second is an unfortunate performance regression. I'd like to address the former more quickly if possible instead of letting the problem fester.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5924/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5924/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5924.diff",
"html_url": "https://github.com/psf/requests/pull/5924",
"merged_at": "2021-11-24T19:21:01Z",
"patch_url": "https://github.com/psf/requests/pull/5924.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5924"
}
| true |
[
"When can we merge this @nateprewitt ?",
"I believe we're waiting on either some consensus with this proposal or feedback for another direction. @sigmavirus24 or @sethmlarson, do you have any thoughts on how we proceed with #5888?"
] |
https://api.github.com/repos/psf/requests/issues/5923
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5923/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5923/comments
|
https://api.github.com/repos/psf/requests/issues/5923/events
|
https://github.com/psf/requests/pull/5923
| 986,045,665 |
MDExOlB1bGxSZXF1ZXN0NzI1Mjg4MjAy
| 5,923 |
General doc updates
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-09-02T03:20:46Z
|
2021-09-02T15:53:50Z
|
2021-09-02T15:53:46Z
|
MEMBER
|
too heated
|
General fixes for documentation including:
* Adding alt tags to images
* Fixing doc compilation errors
* Updating broken links
* Updating info in README.md
* Updating target branch for repo URLs
* Adding logo back to docs sidebar per Kenneth's request
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5923/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5923/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5923.diff",
"html_url": "https://github.com/psf/requests/pull/5923",
"merged_at": "2021-09-02T15:53:46Z",
"patch_url": "https://github.com/psf/requests/pull/5923.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5923"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5922
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5922/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5922/comments
|
https://api.github.com/repos/psf/requests/issues/5922/events
|
https://github.com/psf/requests/pull/5922
| 985,083,834 |
MDExOlB1bGxSZXF1ZXN0NzI0NDM4NjY0
| 5,922 |
Always use value of session.verify when set, fixes #5921
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/795841?v=4",
"events_url": "https://api.github.com/users/brmzkw/events{/privacy}",
"followers_url": "https://api.github.com/users/brmzkw/followers",
"following_url": "https://api.github.com/users/brmzkw/following{/other_user}",
"gists_url": "https://api.github.com/users/brmzkw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/brmzkw",
"id": 795841,
"login": "brmzkw",
"node_id": "MDQ6VXNlcjc5NTg0MQ==",
"organizations_url": "https://api.github.com/users/brmzkw/orgs",
"received_events_url": "https://api.github.com/users/brmzkw/received_events",
"repos_url": "https://api.github.com/users/brmzkw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/brmzkw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brmzkw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/brmzkw",
"user_view_type": "public"
}
|
[] |
open
| false | null |
[] | null | 0 |
2021-09-01T12:20:19Z
|
2021-09-01T12:47:59Z
| null |
NONE
| null |
This fixes https://github.com/psf/requests/issues/5921 where the value of REQUESTS_CA_BUNDLE is read even when certificate verification is disabled through the session.
| null |
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5922/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5922/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5922.diff",
"html_url": "https://github.com/psf/requests/pull/5922",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5922.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5922"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5921
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5921/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5921/comments
|
https://api.github.com/repos/psf/requests/issues/5921/events
|
https://github.com/psf/requests/issues/5921
| 985,081,901 |
MDU6SXNzdWU5ODUwODE5MDE=
| 5,921 |
requests should ignore REQUESTS_CA_BUNDLE when session.verify is False
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/795841?v=4",
"events_url": "https://api.github.com/users/brmzkw/events{/privacy}",
"followers_url": "https://api.github.com/users/brmzkw/followers",
"following_url": "https://api.github.com/users/brmzkw/following{/other_user}",
"gists_url": "https://api.github.com/users/brmzkw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/brmzkw",
"id": 795841,
"login": "brmzkw",
"node_id": "MDQ6VXNlcjc5NTg0MQ==",
"organizations_url": "https://api.github.com/users/brmzkw/orgs",
"received_events_url": "https://api.github.com/users/brmzkw/received_events",
"repos_url": "https://api.github.com/users/brmzkw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/brmzkw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brmzkw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/brmzkw",
"user_view_type": "public"
}
|
[
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "eb6420",
"default": false,
"description": null,
"id": 44501256,
"name": "Breaking API Change",
"node_id": "MDU6TGFiZWw0NDUwMTI1Ng==",
"url": "https://api.github.com/repos/psf/requests/labels/Breaking%20API%20Change"
}
] |
closed
| true | null |
[] | null | 4 |
2021-09-01T12:18:14Z
|
2021-12-03T22:00:27Z
|
2021-09-04T21:37:49Z
|
NONE
|
resolved
|
The argument `session.verify` set to False is ignored when the environment variable `REQUESTS_CA_BUNDLE` is set.
## Reproduction Steps
✅ empty `REQUESTS_CA_BUNDLE` and `session.verify = True` : exception is raised
```bash
$> REQUESTS_CA_BUNDLE= python -c 'import requests; session = requests.Session(); session.verify = True; session.get("https://expired.badssl.com")'
...
requests.exceptions.SSLError: HTTPSConnectionPool(host='expired.badssl.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)')))
```
✅ empty `REQUESTS_CA_BUNDLE` and `session.verify = False`: no exception raised
```bash
$> REQUESTS_CA_BUNDLE= python -c 'import requests; session = requests.Session(); session.verify = False; session.get("https://expired.badssl.com")'
```
✅ `REQUESTS_CA_BUNDLE` is invalid, and no `verify` is given to `requests.get` (defaults to `True`): exception is raised because `REQUESTS_CA_BUNDLE` is invalid
```bash
$> REQUESTS_CA_BUNDLE=invalid python -c 'import requests; requests.get("https://expired.badssl.com")'
...
OSError: Could not find a suitable TLS CA certificate bundle, invalid path: invalid
```
✅ `REQUESTS_CA_BUNDLE` is invalid and `verify=False` is given to `requests.get`: no exception raised
```bash
$> REQUESTS_CA_BUNDLE=invalid python -c 'import requests; requests.get("https://expired.badssl.com", verify=False)'
```
✅ `REQUESTS_CA_BUNDLE` is invalid and `session.verify = True` : exception is raised
```bash
$> REQUESTS_CA_BUNDLE=invalid python -c 'import requests; session = requests.Session(); session.verify = True; session.get("https://expired.badssl.com")'
...
OSError: Could not find a suitable TLS CA certificate bundle, invalid path: invalid
```
❌ `REQUESTS_CA_BUNDLE` is invalid and `session.verify = False` : exception is raised
```bash
$> REQUESTS_CA_BUNDLE=invalid python -c 'import requests; session = requests.Session(); session.verify = False; session.get("https://expired.badssl.com")'
...
OSError: Could not find a suitable TLS CA certificate bundle, invalid path: invalid
```
The problem comes from https://github.com/psf/requests/blob/b0e025ade7ed30ed53ab61f542779af7e024932e/requests/sessions.py#L717 which ignores the value of `self.verify`.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5921/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5921/timeline
| null |
completed
| null | null | false |
[
"Hey @brmzkw, thanks for the detailed rundown! I agree this behavior seems wrong and I'd be inclined to treat it as a bug. I've got some general feedback on the PR, but before we start that, I'd like to make sure we map this out completely.\r\n\r\n`Session` has two interfaces for sending requests, either the `request` method (base for `get`, `post`, etc.) and the `send` method. It looks like you have `request` functionality well mapped, but I'd like to make sure we understand how `send` works in these cases. If you have a moment to put together a table your test cases above for both methods, that would be greatly appreciated. Otherwise, I'll work on getting one together.\r\n\r\nOnce we have that, it'll help us inform the eventual change. In general we try to adhere to a precedence order of method kwargs > Request > Session > Environment. We'll want to make sure we're maintaining that to the best of our ability.",
"Hello and thanks for your quick review!\r\n\r\nThe tests below should cover what you asked. They have been run with and without the patch from my pull request, and all the results are similar in both cases.\r\n\r\n✅ REQUESTS_CA_BUNDLE is empty, using prepped request: exception is raised\r\n\r\n```\r\n$> REQUESTS_CA_BUNDLE= python -c \"from requests import Request, Session; s = Session(); req = Request('GET', 'https://expired.badssl.com'); prepped = req.prepare(); s.send(prepped)\"\r\n...\r\nrequests.exceptions.SSLError: HTTPSConnectionPool(host='expired.badssl.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)')))\r\n```\r\n\r\n⁉️ REQUESTS_CA_BUNDLE is invalid, using prepped request:\r\n\r\n```\r\n$> REQUESTS_CA_BUNDLE=invalid python -c \"from requests import Request, Session; s = Session(); req = Request('GET', 'https://expired.badssl.com'); prepped = req.prepare(); s.send(prepped)\"\r\n...\r\nrequests.exceptions.SSLError: HTTPSConnectionPool(host='expired.badssl.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1131)')))\r\n```\r\n\r\nI don't understand why this exception. REQUESTS_CA_BUNDLE isn't used. This is likely a problem, but not related to this issue.\r\n\r\n✅ REQUESTS_CA_BUNDLE is invalid, using prepped request, set verify=False in session.send(): no exception\r\n\r\n```\r\n$> REQUESTS_CA_BUNDLE=invalid python -c \"from requests import Request, Session; s = Session(); req = Request('GET', 'https://expired.badssl.com'); prepped = req.prepare(); s.send(prepped, verify=False)\"\r\n```\r\n\r\n✅ REQUESTS_CA_BUNDLE is invalid, using prepped request, set session.verify = False: no exception\r\n\r\n```\r\n$> REQUESTS_CA_BUNDLE=invalid python -c \"from requests import Request, Session; s = Session(); req = Request('GET', 'https://expired.badssl.com'); prepped = req.prepare(); s.verify = False; s.send(prepped)\"\r\n```\r\n",
"Thanks for checking on those, @brmzkw! I agree the invalid bundle for `send` is likely wrong behavior, but this helps us get a better view of current behavior.\r\n\r\nUnfortunately, I started leaving feedback on the PR and realized I'd oversimplified the problem yesterday. Fixing this introduces some breakages into `merge_environment_settings` that I'm not sure we can do outside of a major version bump. As a standalone interface it has long standing precedent for how it should behave with `Session.verify`. That will mean we have to push off changing this for the time being.\r\n\r\nWhen we do come around to fixing this, I'll try to layout what things _should_ look like with an invalid REQUESTS_CA_BUNDLE or CURL_CA_BUNDLE:\r\n\r\n### Requests 2.26.0 (Wrong):\r\n| | verify : True | verify : None | verify : False |\r\n|----------|:-------------:|------:|------:|\r\n| self.verify : True | ❌ | ❌ | ✅ |\r\n| self.verify : None | ❌ | ❌ | ✅ |\r\n| self.verify : False | ❌ | ❌ | ✅ |\r\n\r\n### #5922 PR (Better):\r\n| | verify : True | verify : None | verify : False |\r\n|----------|:-------------:|------:|------:|\r\n| self.verify : True | ❌ | ❌ | ✅ |\r\n| self.verify : None | ❌ | ❌ | ✅ |\r\n| self.verify : False | ✅ | ✅ | ✅ |\r\n\r\n### Desired Behavior (method kwargs > Session):\r\n| | verify : True | verify : None | verify : False |\r\n|----------|:-------------:|------:|------:|\r\n| self.verify : True | ❌ | ❌ | ✅ |\r\n| self.verify : None | ❌ | ❌ | ✅ |\r\n| self.verify : False | ❌ | ✅ | ✅ |\r\n\r\nThis gets a bit more nuanced when we look at `Session.send` and `Session.request` because `send` ignores those environment variables entirely (which is the behavior you saw). I wrote up a quick test suite [here](https://gist.github.com/nateprewitt/e15ed5590004525f833703384e9cab45) that we could probably code against in the future to make sure we're getting the desired behavior. These methods have seen considerable drift over the years and neither does what it actually should. There's a larger discussion to be had about what role each fills and a in-depth rework to minimize future drift.\r\n\r\nSo to summarize, I'll mark this as a bug but it may be a considerable amount of time before it can be addressed in a new major version. Thanks for the report though, we do truly appreciate it!",
"It looks like this was actually identified several years ago in #3829 but has been sitting since with the same conclusion. I think we've got some more useful information here that wasn't part of the initial ticket. We'll leave this here as a bread crumb on the initial ticket but I'm going to resolve this in favor of the original to consolidate tracking. Thanks again, @brmzkw!"
] |
https://api.github.com/repos/psf/requests/issues/5920
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5920/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5920/comments
|
https://api.github.com/repos/psf/requests/issues/5920/events
|
https://github.com/psf/requests/issues/5920
| 983,921,503 |
MDU6SXNzdWU5ODM5MjE1MDM=
| 5,920 |
Adapter uses 0 for max_retries instead of the explicit value in DEFAULT_RETRIES
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/21009189?v=4",
"events_url": "https://api.github.com/users/Monal5031/events{/privacy}",
"followers_url": "https://api.github.com/users/Monal5031/followers",
"following_url": "https://api.github.com/users/Monal5031/following{/other_user}",
"gists_url": "https://api.github.com/users/Monal5031/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Monal5031",
"id": 21009189,
"login": "Monal5031",
"node_id": "MDQ6VXNlcjIxMDA5MTg5",
"organizations_url": "https://api.github.com/users/Monal5031/orgs",
"received_events_url": "https://api.github.com/users/Monal5031/received_events",
"repos_url": "https://api.github.com/users/Monal5031/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Monal5031/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Monal5031/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Monal5031",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-08-31T14:21:15Z
|
2021-11-30T01:20:29Z
|
2021-09-01T01:01:37Z
|
NONE
|
resolved
|
Summary.
## Expected Result
I'm using a package that uses requests under the hood but doesn't support max_retry config.
So to get around that I came across the constant `DEFAULT_RETRIES` which is used in the initialization of HttpAdapter here:
https://github.com/psf/requests/blob/main/requests/adapters.py#L117
I expected the Adapters to be initialized with the explicit value in the retry constant.
## Actual Result
I explicitly set this constant to some value in my code, which didn't make any difference to the adapters being initialized in the Session. This is due to the next line in above link which uses `0` instead of the constant to create a Retry object.
## Reproduction Steps
```python
import requests
requests.adapters.DEFAULT_RETRIES = 3
for _, adapter in requests.session().adapters:
print(adapter.max_retries)
```
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "2.8"
},
"implementation": {
"name": "CPython",
"version": "3.9.6"
},
"platform": {
"release": "20.6.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.22.0"
},
"system_ssl": {
"version": "101010bf"
},
"urllib3": {
"version": "1.25.11"
},
"using_pyopenssl": false
}
```
This command is only available on Requests v2.16.4 and greater. Otherwise,
please provide some basic information about your system (Python version,
operating system, &c).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5920/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5920/timeline
| null |
completed
| null | null | false |
[
"This is how Python works, unfortunately. That variable isn't intended for you to change as a way of changing other package's behaviour. The signature for `__init__` has `max_retries=DEFAULT_RETRIES` which may as well be `max_retries=0`. This isn't a Requests bug. We don't advertise this as functionality."
] |
https://api.github.com/repos/psf/requests/issues/5919
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5919/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5919/comments
|
https://api.github.com/repos/psf/requests/issues/5919/events
|
https://github.com/psf/requests/issues/5919
| 983,645,699 |
MDU6SXNzdWU5ODM2NDU2OTk=
| 5,919 |
Hack
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/89839697?v=4",
"events_url": "https://api.github.com/users/DxddySal/events{/privacy}",
"followers_url": "https://api.github.com/users/DxddySal/followers",
"following_url": "https://api.github.com/users/DxddySal/following{/other_user}",
"gists_url": "https://api.github.com/users/DxddySal/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DxddySal",
"id": 89839697,
"login": "DxddySal",
"node_id": "MDQ6VXNlcjg5ODM5Njk3",
"organizations_url": "https://api.github.com/users/DxddySal/orgs",
"received_events_url": "https://api.github.com/users/DxddySal/received_events",
"repos_url": "https://api.github.com/users/DxddySal/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DxddySal/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DxddySal/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DxddySal",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-08-31T09:28:56Z
|
2021-08-31T11:57:40Z
|
2021-08-31T11:57:39Z
|
NONE
| null |
Ok
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5919/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5919/timeline
| null |
completed
| null | null | false |
[] |
https://api.github.com/repos/psf/requests/issues/5918
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5918/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5918/comments
|
https://api.github.com/repos/psf/requests/issues/5918/events
|
https://github.com/psf/requests/issues/5918
| 983,144,358 |
MDU6SXNzdWU5ODMxNDQzNTg=
| 5,918 |
Only one header is shown if there are multiple headers of the same name in response.headers
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/67868381?v=4",
"events_url": "https://api.github.com/users/thefakequake/events{/privacy}",
"followers_url": "https://api.github.com/users/thefakequake/followers",
"following_url": "https://api.github.com/users/thefakequake/following{/other_user}",
"gists_url": "https://api.github.com/users/thefakequake/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/thefakequake",
"id": 67868381,
"login": "thefakequake",
"node_id": "MDQ6VXNlcjY3ODY4Mzgx",
"organizations_url": "https://api.github.com/users/thefakequake/orgs",
"received_events_url": "https://api.github.com/users/thefakequake/received_events",
"repos_url": "https://api.github.com/users/thefakequake/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/thefakequake/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thefakequake/subscriptions",
"type": "User",
"url": "https://api.github.com/users/thefakequake",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-08-30T19:51:26Z
|
2021-11-28T21:00:25Z
|
2021-08-30T20:16:08Z
|
NONE
|
resolved
|
Summary.
## Expected Result
That the library would automatically change the name of one of the headers in order to store it in response.headers, or have some alternative way to get response headers that allows for duplicate header names.
## Actual Result
Only one of the headers is shown, due to Python not allowing duplicat keys.
## Reproduction Steps
```python
import requests
# fetch some website that sends a response with multiple headers of the same name
response = requests.get("some url")
# {"set-token": "foo", "set-token": "baz"}
# only shows one of the headers
response.headers
# {"set-token": "foo"}
```
## System Information
```
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.4"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.8.7"
},
"platform": {
"release": "10",
"system": "Windows"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010107f"
},
"urllib3": {
"version": "1.26.6"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/67868381?v=4",
"events_url": "https://api.github.com/users/thefakequake/events{/privacy}",
"followers_url": "https://api.github.com/users/thefakequake/followers",
"following_url": "https://api.github.com/users/thefakequake/following{/other_user}",
"gists_url": "https://api.github.com/users/thefakequake/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/thefakequake",
"id": 67868381,
"login": "thefakequake",
"node_id": "MDQ6VXNlcjY3ODY4Mzgx",
"organizations_url": "https://api.github.com/users/thefakequake/orgs",
"received_events_url": "https://api.github.com/users/thefakequake/received_events",
"repos_url": "https://api.github.com/users/thefakequake/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/thefakequake/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thefakequake/subscriptions",
"type": "User",
"url": "https://api.github.com/users/thefakequake",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5918/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5918/timeline
| null |
completed
| null | null | false |
[] |
https://api.github.com/repos/psf/requests/issues/5917
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5917/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5917/comments
|
https://api.github.com/repos/psf/requests/issues/5917/events
|
https://github.com/psf/requests/pull/5917
| 981,521,878 |
MDExOlB1bGxSZXF1ZXN0NzIxNTU0MjI5
| 5,917 |
Move from urlparse to parse_url for prepending schemes
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-08-27T19:10:24Z
|
2022-04-03T17:01:54Z
|
2021-12-29T13:31:40Z
|
MEMBER
|
resolved
|
This addresses the base problem raised in #5855 with the `urlparse` changes in Python 3.9 and potential issues in future 3.7/3.8 releases. We've avoided changing other uses of `urlparse` for now due to issues with `parse_url`'s strict validation requirements when performing parsing.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5917/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5917/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5917.diff",
"html_url": "https://github.com/psf/requests/pull/5917",
"merged_at": "2021-12-29T13:31:40Z",
"patch_url": "https://github.com/psf/requests/pull/5917.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5917"
}
| true |
[
"Thanks for this! I've pulled in this patch into our internal monorepo and some preliminary testing shows that it's working (I can `export https_proxy=some-proxy.example.com:3128`, like a lot of our scripts do, and things work again under Python 3.9). I'll hopefully get it deployed today and can report on whether our users can successfully switch to 3.9.",
"We've rolled this out and it works in prod.",
"Thanks for checking, @geofft! I think we just need another maintainer to give this a glance and we can look at moving the review forward."
] |
https://api.github.com/repos/psf/requests/issues/5916
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5916/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5916/comments
|
https://api.github.com/repos/psf/requests/issues/5916/events
|
https://github.com/psf/requests/pull/5916
| 981,485,973 |
MDExOlB1bGxSZXF1ZXN0NzIxNTI2MjM5
| 5,916 |
Time out requests' tests after 10 minutes.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1411050?v=4",
"events_url": "https://api.github.com/users/theGOTOguy/events{/privacy}",
"followers_url": "https://api.github.com/users/theGOTOguy/followers",
"following_url": "https://api.github.com/users/theGOTOguy/following{/other_user}",
"gists_url": "https://api.github.com/users/theGOTOguy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/theGOTOguy",
"id": 1411050,
"login": "theGOTOguy",
"node_id": "MDQ6VXNlcjE0MTEwNTA=",
"organizations_url": "https://api.github.com/users/theGOTOguy/orgs",
"received_events_url": "https://api.github.com/users/theGOTOguy/received_events",
"repos_url": "https://api.github.com/users/theGOTOguy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/theGOTOguy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/theGOTOguy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/theGOTOguy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-08-27T18:19:09Z
|
2021-11-25T21:00:30Z
|
2021-08-27T18:49:51Z
|
CONTRIBUTOR
|
resolved
|
Currently, tests running on #5915 are timing out after GitHub's default of 6 hours. No requests test should ever take that long, so set a more realistic timeout to prevent a single faulty PR from holding up everybody's work for 6 hours.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5916/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5916/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5916.diff",
"html_url": "https://github.com/psf/requests/pull/5916",
"merged_at": "2021-08-27T18:49:51Z",
"patch_url": "https://github.com/psf/requests/pull/5916.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5916"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5915
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5915/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5915/comments
|
https://api.github.com/repos/psf/requests/issues/5915/events
|
https://github.com/psf/requests/pull/5915
| 980,930,645 |
MDExOlB1bGxSZXF1ZXN0NzIxMDc0NDc1
| 5,915 |
Adds a Realistic WSGI Server for Testing
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1411050?v=4",
"events_url": "https://api.github.com/users/theGOTOguy/events{/privacy}",
"followers_url": "https://api.github.com/users/theGOTOguy/followers",
"following_url": "https://api.github.com/users/theGOTOguy/following{/other_user}",
"gists_url": "https://api.github.com/users/theGOTOguy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/theGOTOguy",
"id": 1411050,
"login": "theGOTOguy",
"node_id": "MDQ6VXNlcjE0MTEwNTA=",
"organizations_url": "https://api.github.com/users/theGOTOguy/orgs",
"received_events_url": "https://api.github.com/users/theGOTOguy/received_events",
"repos_url": "https://api.github.com/users/theGOTOguy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/theGOTOguy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/theGOTOguy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/theGOTOguy",
"user_view_type": "public"
}
|
[] |
open
| false | null |
[] | null | 6 |
2021-08-27T06:49:12Z
|
2023-09-12T02:53:52Z
| null |
CONTRIBUTOR
| null |
Sending of chunked-encoded data is not currently tested to be correct anywhere in requests' tests, and is called out as a needed improvement in #5906. This is a hurdle to accepting #5664, a change which would both simplify requests' code and consistently use [urllib3 for retrying errors](https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html).
The [existing test server](https://github.com/psf/requests/blob/main/tests/testserver/server.py) is a simple socket that can send and receive data and is not aware of HTTP protocols. Therefore, using it to verify correct sending of chunked-encoded data, for instance, would ultimately become a change-detector test.
This change seeks to remedy that while also taking a step towards both simplifying and strengthening requests' tests.
We strengthen requests' tests by introducing the popular [Werkzeug library](https://github.com/pallets/werkzeug) as an explicit test dependency ([Flask](https://github.com/pallets/flask), which uses Werkzeug, is already a test dependency). By doing so, we leverage their authority as an implementer of [PEP 3333](https://www.python.org/dev/peps/pep-3333/) to validate our own implementation of chunked encoding. This implicitly future-proofs against any hypothetical breaking changes to the standard by testing against Werkzeug's trusted implementation.
We also simplify requests' tests, since the implementation of the test [WerkzeugServer](https://github.com/psf/requests/commit/f1f838e36bc24fb40d7121e72298da3e5a7149ff#diff-a53b39ec2e425dad0c8387f8402839b2ec328e93494086ed66abb4b49708deeb) here is substantially more concise than the [current test server](https://github.com/psf/requests/blob/main/tests/testserver/server.py). If this change is accepted, in another pull request I will refactor all of requests' tests to use the WerkzeugServer rather than the current test server.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1411050?v=4",
"events_url": "https://api.github.com/users/theGOTOguy/events{/privacy}",
"followers_url": "https://api.github.com/users/theGOTOguy/followers",
"following_url": "https://api.github.com/users/theGOTOguy/following{/other_user}",
"gists_url": "https://api.github.com/users/theGOTOguy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/theGOTOguy",
"id": 1411050,
"login": "theGOTOguy",
"node_id": "MDQ6VXNlcjE0MTEwNTA=",
"organizations_url": "https://api.github.com/users/theGOTOguy/orgs",
"received_events_url": "https://api.github.com/users/theGOTOguy/received_events",
"repos_url": "https://api.github.com/users/theGOTOguy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/theGOTOguy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/theGOTOguy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/theGOTOguy",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5915/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5915/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5915.diff",
"html_url": "https://github.com/psf/requests/pull/5915",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5915.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5915"
}
| true |
[
"Finally got the test server to verify that it is actually ready to accept connections in a robust way! Sorry about holding the test queue up for so long. ",
"This PR has been sitting here for a while and I'm wondering if there's still any interest from the maintainers with regard to improving your tests.\r\n\r\nIf I can get some feedback that you would prefer to test against a realistic WSGI server instead of the existing simple socket and that you'd accept the PR, I'll refactor all of your tests to use the `WerkzeugServer` implemented here, simplify your code, and hopefully make it easier to make forward progress in the future because of the greater confidence imparted by more realistic tests.\r\n\r\nIf there is no interest, I'll close this PR.",
"There's interest in _adding_ a WSGI server not in _replacing_ it entirely. There are tests that a socket server is still incredibly valuable for and tests that a higher level server would be better suited to.",
"@sigmavirus24 Sure, I buy that. In the interest of closing this PR and making things better, I need clarification on how you want to proceed:\r\n\r\n- We could merge this as a body of work and proceed to add WSGI tests piecemeal going forward on a case-by-case basis.\r\n- I could make a separate WSGI version of all tests, so that there would be both a socket and WSGI version of every existing test.\r\n- You could clarify which specific tests you would prefer a WSGI version of and I can refactor only that subset.",
"I'd still like to see requests move towards more realistic testing against an actual implementation of PEP 3333. If any specific guidance can be provided on what the expectations are in order to merge this PR, I will make the necessary modifications or refactor additional tests. \r\n\r\n",
"Hello! This pull request is very old, but I still feel that adding realistic tests against a reference implementation of PEP 3333 would be worthwhile.\r\n\r\nIf any guidance can be provided as to what the maintainers' expectations are in order to merge this change, then I will be happy to conform to those expectations and also to refactor any desired subset of the existing tests."
] |
https://api.github.com/repos/psf/requests/issues/5914
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5914/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5914/comments
|
https://api.github.com/repos/psf/requests/issues/5914/events
|
https://github.com/psf/requests/pull/5914
| 980,763,337 |
MDExOlB1bGxSZXF1ZXN0NzIwOTQxNDk4
| 5,914 |
Appropriately handle urllib3's InvalidHeader exception
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-08-27T00:55:45Z
|
2021-11-25T01:21:40Z
|
2021-08-27T01:11:30Z
|
MEMBER
|
resolved
|
#4306 raised an issue in our initial integration with urllib3's InvalidHeader implementation. We've been leaking an unwrapped exception in _some_ occasions through our HTTPAdapter. This patch should consolidate to the single Requests exception in all cases.
This may technically be considered breaking as we're changing the exception type, but Requests `InvalidHeader` was already raised through this API in the common case, so I would consider this as more of a bug.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5914/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5914/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5914.diff",
"html_url": "https://github.com/psf/requests/pull/5914",
"merged_at": "2021-08-27T01:11:30Z",
"patch_url": "https://github.com/psf/requests/pull/5914.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5914"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5913
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5913/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5913/comments
|
https://api.github.com/repos/psf/requests/issues/5913/events
|
https://github.com/psf/requests/pull/5913
| 979,865,579 |
MDExOlB1bGxSZXF1ZXN0NzIwMjA2MDI1
| 5,913 |
Update codeql branch target
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-08-26T05:59:23Z
|
2021-12-14T09:00:27Z
|
2021-08-26T10:58:35Z
|
MEMBER
|
resolved
|
It looks like our CodeQL workflow has been disabled since swapping the default branch. This patch should fix that.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5913/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5913/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5913.diff",
"html_url": "https://github.com/psf/requests/pull/5913",
"merged_at": "2021-08-26T10:58:35Z",
"patch_url": "https://github.com/psf/requests/pull/5913.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5913"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5912
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5912/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5912/comments
|
https://api.github.com/repos/psf/requests/issues/5912/events
|
https://github.com/psf/requests/pull/5912
| 979,721,728 |
MDExOlB1bGxSZXF1ZXN0NzIwMDkyNDgy
| 5,912 |
Fix syntax error in lock action
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-08-26T00:38:55Z
|
2021-11-24T01:21:24Z
|
2021-08-26T01:04:43Z
|
MEMBER
|
resolved
|
I missed this in the last review 😔 Looks like the job is failing with a syntax error because of the missing `with` clause.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5912/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5912/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5912.diff",
"html_url": "https://github.com/psf/requests/pull/5912",
"merged_at": "2021-08-26T01:04:43Z",
"patch_url": "https://github.com/psf/requests/pull/5912.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5912"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5911
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5911/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5911/comments
|
https://api.github.com/repos/psf/requests/issues/5911/events
|
https://github.com/psf/requests/pull/5911
| 979,505,578 |
MDExOlB1bGxSZXF1ZXN0NzE5OTA4MzMw
| 5,911 |
Shorten the window before we lock threads
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
] | null | 0 |
2021-08-25T18:24:18Z
|
2021-11-23T20:00:49Z
|
2021-08-25T18:44:57Z
|
CONTRIBUTOR
|
resolved
|
Per Nate's recommendation, let's lock things after 90 days rather than
360
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5911/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5911/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5911.diff",
"html_url": "https://github.com/psf/requests/pull/5911",
"merged_at": "2021-08-25T18:44:57Z",
"patch_url": "https://github.com/psf/requests/pull/5911.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5911"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5910
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5910/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5910/comments
|
https://api.github.com/repos/psf/requests/issues/5910/events
|
https://github.com/psf/requests/pull/5910
| 979,395,550 |
MDExOlB1bGxSZXF1ZXN0NzE5ODE2NjQx
| 5,910 |
Formatting
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5687998?v=4",
"events_url": "https://api.github.com/users/verhovsky/events{/privacy}",
"followers_url": "https://api.github.com/users/verhovsky/followers",
"following_url": "https://api.github.com/users/verhovsky/following{/other_user}",
"gists_url": "https://api.github.com/users/verhovsky/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/verhovsky",
"id": 5687998,
"login": "verhovsky",
"node_id": "MDQ6VXNlcjU2ODc5OTg=",
"organizations_url": "https://api.github.com/users/verhovsky/orgs",
"received_events_url": "https://api.github.com/users/verhovsky/received_events",
"repos_url": "https://api.github.com/users/verhovsky/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/verhovsky/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/verhovsky/subscriptions",
"type": "User",
"url": "https://api.github.com/users/verhovsky",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-08-25T16:16:07Z
|
2021-11-23T17:09:19Z
|
2021-08-25T16:48:30Z
|
CONTRIBUTOR
|
resolved
| null |
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5910/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5910/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5910.diff",
"html_url": "https://github.com/psf/requests/pull/5910",
"merged_at": "2021-08-25T16:48:30Z",
"patch_url": "https://github.com/psf/requests/pull/5910.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5910"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5909
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5909/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5909/comments
|
https://api.github.com/repos/psf/requests/issues/5909/events
|
https://github.com/psf/requests/pull/5909
| 978,584,201 |
MDExOlB1bGxSZXF1ZXN0NzE5MTQ5ODI2
| 5,909 |
Add thread locker workflow
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
},
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
] | null | 0 |
2021-08-25T00:23:19Z
|
2021-11-23T19:00:25Z
|
2021-08-25T18:21:36Z
|
CONTRIBUTOR
|
resolved
| null |
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5909/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5909/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5909.diff",
"html_url": "https://github.com/psf/requests/pull/5909",
"merged_at": "2021-08-25T18:21:36Z",
"patch_url": "https://github.com/psf/requests/pull/5909.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5909"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5908
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5908/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5908/comments
|
https://api.github.com/repos/psf/requests/issues/5908/events
|
https://github.com/psf/requests/pull/5908
| 976,329,998 |
MDExOlB1bGxSZXF1ZXN0NzE3Mjc4MTAz
| 5,908 |
fix typo
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/20257094?v=4",
"events_url": "https://api.github.com/users/hongkuancn/events{/privacy}",
"followers_url": "https://api.github.com/users/hongkuancn/followers",
"following_url": "https://api.github.com/users/hongkuancn/following{/other_user}",
"gists_url": "https://api.github.com/users/hongkuancn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hongkuancn",
"id": 20257094,
"login": "hongkuancn",
"node_id": "MDQ6VXNlcjIwMjU3MDk0",
"organizations_url": "https://api.github.com/users/hongkuancn/orgs",
"received_events_url": "https://api.github.com/users/hongkuancn/received_events",
"repos_url": "https://api.github.com/users/hongkuancn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hongkuancn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hongkuancn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hongkuancn",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2021-08-22T09:23:45Z
|
2021-11-20T16:00:35Z
|
2021-08-22T13:45:52Z
|
NONE
|
resolved
|
byte string is `b'test'`, while unicode string is `'test'`
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5908/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5908/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5908.diff",
"html_url": "https://github.com/psf/requests/pull/5908",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/5908.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5908"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/5907
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5907/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5907/comments
|
https://api.github.com/repos/psf/requests/issues/5907/events
|
https://github.com/psf/requests/issues/5907
| 975,486,021 |
MDU6SXNzdWU5NzU0ODYwMjE=
| 5,907 |
Prepared Requests: Replaced url still gets encoded
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/49884593?v=4",
"events_url": "https://api.github.com/users/dankgen-tobias/events{/privacy}",
"followers_url": "https://api.github.com/users/dankgen-tobias/followers",
"following_url": "https://api.github.com/users/dankgen-tobias/following{/other_user}",
"gists_url": "https://api.github.com/users/dankgen-tobias/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dankgen-tobias",
"id": 49884593,
"login": "dankgen-tobias",
"node_id": "MDQ6VXNlcjQ5ODg0NTkz",
"organizations_url": "https://api.github.com/users/dankgen-tobias/orgs",
"received_events_url": "https://api.github.com/users/dankgen-tobias/received_events",
"repos_url": "https://api.github.com/users/dankgen-tobias/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dankgen-tobias/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dankgen-tobias/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dankgen-tobias",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2021-08-20T10:35:09Z
|
2021-11-20T14:00:29Z
|
2021-08-20T11:46:10Z
|
NONE
|
resolved
|
As suggested in #1454, #5739 and #3077, if one wants to stop `requests` from encoding request query parameters, the [PreparedRequest-flow](https://docs.python-requests.org/en/master/user/advanced/#prepared-requests) should be used. Replacing the url works, but when actually performing the request, the URL still gets encoded.
## Expected Result
Calling `Session.send` for an instance of `PreparedRequest` uses exactly the specified URL of the prepared request and not further encodes it.
## Actual Result
Calling `Session.send` for an instance of `PreparedRequest` automatically encodes the URL of the prepared request.
## Reproduction Steps
```python
from requests import Request, Session
# use requestcatcher to see which url got called
url = "https://tm97.requestcatcher.com/test/"
weird_characters = "[]%$"
s = Session()
req = Request('GET', url)
prepped = req.prepare()
prepped.url = url + weird_characters
resp = s.send(prepped)
```
```python
>>> print(prepped.url)
https://tm97.requestcatcher.com/test/[]%$
```
```
# actual observed URL on requestcatcher
GET /test/%5B%5D%25$ HTTP/1.1
Host: tm97.requestcatcher.com
Accept-Encoding: identity
User-Agent: python-urllib3/1.26.6
```
As you can see the special characters get encoded automatically. To make sure that requestcatcher itself does not do any encoding, I sent the same request using `wget` and it did not encode anything there.
## System Information
$ python -m requests.help
```
{
"chardet": {
"version": null
},
"charset_normalizer": {
"version": "2.0.4"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "3.2"
},
"implementation": {
"name": "CPython",
"version": "3.8.10"
},
"platform": {
"release": "5.11.0-27-generic",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.26.0"
},
"system_ssl": {
"version": "1010106f"
},
"urllib3": {
"version": "1.26.6"
},
"using_charset_normalizer": true,
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5907/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5907/timeline
| null |
completed
| null | null | false |
[
"Let's look through the flow at the point at which you're entering.\r\n\r\n[`Session.send`](https://github.com/psf/requests/blob/b0e025ade7ed30ed53ab61f542779af7e024932e/requests/sessions.py#L626) off-loads the request to the HTTPAdapter it's found to use and doesn't normalize URLs: https://github.com/psf/requests/blob/b0e025ade7ed30ed53ab61f542779af7e024932e/requests/sessions.py#L655 . [`HTTPAdapter.send`](https://github.com/psf/requests/blob/b0e025ade7ed30ed53ab61f542779af7e024932e/requests/adapters.py#L394) uses the standard library to [parse](https://github.com/psf/requests/blob/b0e025ade7ed30ed53ab61f542779af7e024932e/requests/adapters.py#L329) the URL to pass onto urllib3 which you can verify locally doesn't normalize anything to an RFC3986 valid URI\r\n\r\n```\r\n>>> url = \"https://tm97.requestcatcher.com/test/\"\r\n>>> weird_characters = \"[]%$\"\r\n>>> import urllib.parse\r\n>>> urllib.parse.urlparse(url + weird_characters)\r\nParseResult(scheme='https', netloc='tm97.requestcatcher.com', path='/test/[]%$', params='', query='', fragment='')\r\n>>> scheme, netloc, path, params, query, fragment = _\r\n>>> path\r\n'/test/[]%$'\r\n>>> urllib.parse.urlunparse((scheme, netloc, path, params, query, ''))\r\n'https://tm97.requestcatcher.com/test/[]%$'\r\n```\r\n\r\nAnd then after that, the rest of [`send`](https://github.com/psf/requests/blob/b0e025ade7ed30ed53ab61f542779af7e024932e/requests/adapters.py#L422-L533) is passing the request information to urllib3 to handle. At that point, you can see that [urllib3](https://github.com/urllib3/urllib3/blob/dbd0b85b3a9d852c817e5c33f1ff9b0af8d0aae9/src/urllib3/connectionpool.py#L649) ensures it's a valid path per all specifications (WHAT-WG's latest specifications, RFC 3986 before it, etc.). This is not a bug strictly in Requests at this point",
"@sigmavirus24 Thank you for the explanantion. While I agree that is not a bug of requests specifically, you closed #5739 with the suggestion to use the prepared request flow. However, as demonstrated in this issue, the prepared request flow does not work for urls.\r\n\r\nSo I guess this cannot be handled by requests right now and I have to switch to another library? As this issue is rightfully closed, I would suggest re-opening #5739 and continuing the discussion there. ",
"> . While I agree that is not a bug of requests specifically, you closed #5739 with the suggestion to use the prepared request flow. However, as demonstrated in this issue, the prepared request flow does not work for urls.\r\n\r\nIt did work in #5739. The bug should be opened with urllib3 to provide an escape hatch here if desired."
] |
https://api.github.com/repos/psf/requests/issues/5906
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5906/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5906/comments
|
https://api.github.com/repos/psf/requests/issues/5906/events
|
https://github.com/psf/requests/pull/5906
| 975,430,853 |
MDExOlB1bGxSZXF1ZXN0NzE2NTgxNDI0
| 5,906 |
Test verifying that ChunkedEncodingError is raised on an invalid Transfer-Encoding: chunked response.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1411050?v=4",
"events_url": "https://api.github.com/users/theGOTOguy/events{/privacy}",
"followers_url": "https://api.github.com/users/theGOTOguy/followers",
"following_url": "https://api.github.com/users/theGOTOguy/following{/other_user}",
"gists_url": "https://api.github.com/users/theGOTOguy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/theGOTOguy",
"id": 1411050,
"login": "theGOTOguy",
"node_id": "MDQ6VXNlcjE0MTEwNTA=",
"organizations_url": "https://api.github.com/users/theGOTOguy/orgs",
"received_events_url": "https://api.github.com/users/theGOTOguy/received_events",
"repos_url": "https://api.github.com/users/theGOTOguy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/theGOTOguy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/theGOTOguy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/theGOTOguy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-08-20T09:22:40Z
|
2021-11-23T07:00:27Z
|
2021-08-25T02:00:18Z
|
CONTRIBUTOR
|
resolved
|
This logic is not currently exercised anywhere in requests' tests.
For context, most errors that occur during the process of handling a request can be retried through [urllib3's Retry](https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html). Currently, chunked encoding bypasses this, leading to a situation where users of requests are left to roll their own custom error handling for chunked encoding. #5664 seeks to remedy that, but there are two issues:
First, the current logic around chunked encoding has limited tests, and there is concern that accepting #5664 would introduce a regression.
Second, switching from requests' internal exceptions to urllib3's exceptions is a breaking change that will require appropriate notification to existing users.
This is a first step towards addressing both issues by exercising the chunked encoding logic internally, introducing a test that will break when requests switches to using urllib3's exceptions for chunked encoding, and providing a simple example to start with for any who seek to write further tests for the chunked encoding logic.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5906/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5906/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/5906.diff",
"html_url": "https://github.com/psf/requests/pull/5906",
"merged_at": "2021-08-25T02:00:17Z",
"patch_url": "https://github.com/psf/requests/pull/5906.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/5906"
}
| true |
[
"I appreciate the feedback on what tests are needed, @nateprewitt. I will look into request serialization tests next."
] |
https://api.github.com/repos/psf/requests/issues/5905
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5905/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5905/comments
|
https://api.github.com/repos/psf/requests/issues/5905/events
|
https://github.com/psf/requests/issues/5905
| 972,277,549 |
MDU6SXNzdWU5NzIyNzc1NDk=
| 5,905 |
If the length of the response header is less than the actual length of the body, a read timeout occurs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3919733?v=4",
"events_url": "https://api.github.com/users/sihan-bit/events{/privacy}",
"followers_url": "https://api.github.com/users/sihan-bit/followers",
"following_url": "https://api.github.com/users/sihan-bit/following{/other_user}",
"gists_url": "https://api.github.com/users/sihan-bit/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sihan-bit",
"id": 3919733,
"login": "sihan-bit",
"node_id": "MDQ6VXNlcjM5MTk3MzM=",
"organizations_url": "https://api.github.com/users/sihan-bit/orgs",
"received_events_url": "https://api.github.com/users/sihan-bit/received_events",
"repos_url": "https://api.github.com/users/sihan-bit/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sihan-bit/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sihan-bit/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sihan-bit",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-08-17T04:00:46Z
|
2021-11-15T17:07:00Z
|
2021-08-17T17:01:52Z
|
NONE
|
resolved
|
If the length of the response header is less than the actual length of the body, a read timeout occurs.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5905/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5905/timeline
| null |
completed
| null | null | false |
[
"Hi @sihan-bit, this is expected behavior. If the server tells us there is more data coming, Requests will wait until it arrives or until we reach our read timeout. There's no way for Requests to disambiguate between the two situations, and it likely shouldn't."
] |
https://api.github.com/repos/psf/requests/issues/5904
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5904/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5904/comments
|
https://api.github.com/repos/psf/requests/issues/5904/events
|
https://github.com/psf/requests/issues/5904
| 971,099,132 |
MDU6SXNzdWU5NzEwOTkxMzI=
| 5,904 |
strange behavior in python request library
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2021-08-15T10:12:02Z
|
2021-08-15T13:38:28Z
|
2021-08-15T13:22:23Z
|
NONE
|
resolved
|
I ran the following code on Mac and Linux but got different results. Does anyone know why? both systems have the same request version "2.23.0"
```
import requests
page = requests.get("https://legacy.haraj.com.sa/city/%D8%A7%D9%84%D8%A8%D8%A7%D8%AD%D8%A9")
print(page.text)
```
Mac result :
```
<html lang="ar-sa" dir="rtl">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>
حراج الباحة </title>
<link
rel="stylesheet"
href="https://haraj.azureedge.net/static/style7/normalize.min.css"
/>
<meta
name="viewport"
content="width=device-width, initial-scale=1.0 , maximum-scale=3.0, user-scalable=yes"
/>
<link
rel="stylesheet"
href="https://stackpath.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css"
/>
<link
```
Linux result :
```
<!doctype html><html dir="rtl" lang="ar"><head><link rel="dns-prefetch" href="https://betacdn.haraj.com.sa"/><link rel="dns-prefetch" href="https://graphql.haraj.com.sa"/><link rel="dns-prefetch" href="https://imgcdn.haraj.com.sa"/><meta http-equiv="Content-Type" content="text/html; charset=utf-8"/><title>موقع حراج</title><meta name="viewport" content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no"/><meta name="theme-color" content="#0473c0"/><meta name="format-detection" content="telephone=yes"/><meta property="twitter:account_id" content="4503599629495409"/><meta name="twitter:card" id="twitter-card" content="summary"/><meta name="twitter:site" content="@haraj"/><meta id="meta-twitter-image" name="twitter:image:media" content="https://v8-cdn.haraj.com.sa/assets/images/1024_icon.png"/><meta name="twitter:site:id" content="131885812"/><meta name="twitter:app:name:iphone" content="حراج"/><meta name="twitter:app:id:iphone" content="662557215"/><meta name="twitter:app:name:ipad" content="حراج"/><meta name="twitter:app:id:ipad" content="662557215"/><meta name="twitter:app:name:googleplay" content="حراج"/><meta name="twitter:app:id:googleplay" content="com.haraj.app"/><meta property="og:country-name" content="Saudi Arabia"/><meta <link rel="icon" href="https://graphql.haraj.com.sa"/><link rel="preconnect" href="https://www.google-analytics.com"/><link rel="manifest" href="/manifest.webmanifest"/><script async defer="defer" src="https://www.googleoptimize.com/optimize.js?id="></script><script>(function (w, d, s, l, i) {
w[l] = w[l] || [];
w[l].push({
'gtm.start': new Date().getTime(),
event: 'gtm.js'
});
var f = d.getElementsByTagName(s)[0],
j = d.createElement(s),
</html>
```
I asked in StackOverflow and tagged python-requests but no answers. Your help is much appreciated.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5904/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5904/timeline
| null |
completed
| null | null | false |
[
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here.\r\n\r\nNot receiving answers on StackOverflow doesn't justify opening a new issue here",
"it is not a request for help. it is strange behaviour in the library (a defect ). There should be a solution to this issue. ",
"That means the library gives different results on different OS's. ",
"It's not a defect in the library. Many websites, CDNs, etc. detect things about your request (originating IP address, user-agent, etc.) and have different behaviour. On your last issue you were using Amazon Linux which has a predictable IP range of addresses. You're likely encountering something preventing a scraping attack. This client library can't force the server to behave identically."
] |
https://api.github.com/repos/psf/requests/issues/5903
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5903/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5903/comments
|
https://api.github.com/repos/psf/requests/issues/5903/events
|
https://github.com/psf/requests/issues/5903
| 970,873,186 |
MDU6SXNzdWU5NzA4NzMxODY=
| 5,903 |
request gives different result
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-08-14T09:31:28Z
|
2021-08-15T13:38:51Z
|
2021-08-14T11:01:24Z
|
NONE
|
resolved
|
When running this code on mac:
```
import requests
page = requests.get("https://legacy.haraj.com.sa/city/%D8%A7%D9%84%D8%A8%D8%A7%D8%AD%D8%A9")
print(page.text)
```
the result is different from running the same script on Linux. Any idea?
Systems:
```
Mac system info:
Model Name: MacBook Pro
Model Identifier: MacBookPro12,1
Processor Name: Intel Core i5
Processor Speed: 2.7 GHz
Number of Processors: 1
Total Number of Cores: 2
L2 Cache (per Core): 256 KB
L3 Cache: 3 MB
Memory: 8 GB
Boot ROM Version: 182.0.0.0.0
SMC Version (system): 2.28f7
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": "3.3.1"
},
"idna": {
"version": "2.10"
},
"implementation": {
"name": "CPython",
"version": "3.8.0"
},
"platform": {
"release": "18.2.0",
"system": "Darwin"
},
"pyOpenSSL": {
"openssl_version": "1010109f",
"version": "20.0.1"
},
"requests": {
"version": "2.23.0"
},
"system_ssl": {
"version": "1010109f"
},
"urllib3": {
"version": "1.25.11"
},
"using_pyopenssl": true
}
--------------------------------------------------------------------------------------------
Linux:
OS: Debian
Kernel: x86_64 Linux 4.14.238-182.422.amzn2.x86_64
Uptime: 11d 9h 59m
Packages: 439
Shell: bash 5.0.3
CPU: Intel Xeon E5-2676 v3 @ 2.4GHz
GPU:
RAM: 342MiB / 983MiB
{
"chardet": {
"version": "3.0.4"
},
"cryptography": {
"version": ""
},
"idna": {
"version": "2.10"
},
"implementation": {
"name": "CPython",
"version": "3.9.4"
},
"platform": {
"release": "4.14.238-182.422.amzn2.x86_64",
"system": "Linux"
},
"pyOpenSSL": {
"openssl_version": "",
"version": null
},
"requests": {
"version": "2.23.0"
},
"system_ssl": {
"version": "1010104f"
},
"urllib3": {
"version": "1.25.11"
},
"using_pyopenssl": false
}
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5903/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5903/timeline
| null |
completed
| null | null | false |
[
"Hi there! Thanks for opening this issue. Unfortunately, it seems this is a request for help instead of a report of a defect in the project. Please use [StackOverflow](https://stackoverflow.com) for general usage questions instead and only report defects here. You haven't provided enough information to help either"
] |
https://api.github.com/repos/psf/requests/issues/5902
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5902/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5902/comments
|
https://api.github.com/repos/psf/requests/issues/5902/events
|
https://github.com/psf/requests/issues/5902
| 968,408,061 |
MDU6SXNzdWU5Njg0MDgwNjE=
| 5,902 |
DOC,BUG: 404: Spanish translation links require .html
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/50891?v=4",
"events_url": "https://api.github.com/users/westurner/events{/privacy}",
"followers_url": "https://api.github.com/users/westurner/followers",
"following_url": "https://api.github.com/users/westurner/following{/other_user}",
"gists_url": "https://api.github.com/users/westurner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/westurner",
"id": 50891,
"login": "westurner",
"node_id": "MDQ6VXNlcjUwODkx",
"organizations_url": "https://api.github.com/users/westurner/orgs",
"received_events_url": "https://api.github.com/users/westurner/received_events",
"repos_url": "https://api.github.com/users/westurner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/westurner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/westurner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/westurner",
"user_view_type": "public"
}
|
[
{
"color": "fad8c7",
"default": false,
"description": null,
"id": 136616769,
"name": "Documentation",
"node_id": "MDU6TGFiZWwxMzY2MTY3Njk=",
"url": "https://api.github.com/repos/psf/requests/labels/Documentation"
}
] |
closed
| true | null |
[] | null | 5 |
2021-08-12T09:07:53Z
|
2021-12-12T07:00:26Z
|
2021-09-12T22:42:57Z
|
NONE
|
resolved
|
At least the Spanish translation links in the RTD widget are 404'ing.
1. https://docs.python-requests.org/en/master/user/quickstart/
2. Click 'es' under Languages in the RTD widget
3. 404
From @astrojuanlu
https://twitter.com/juanluisback/status/1425742688595464200 :
> It is indeed available, but notice the .html at the end of the URL https://docs.python-requests.org/es/latest/user/quickstart.html
>
> Looks like the configuration of the projects is not uniform. Would you open an issue on the requests tracker? Feel free to ping me, happy to help!
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/5902/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5902/timeline
| null |
completed
| null | null | false |
[
"Thanks for the ping @westurner!\r\n\r\nI see that https://github.com/requests/requests-docs-es has not received any attention in 5 years, not sure about the other translations. In any case, even if those docs are very outdated, I wonder if some config changes on the RTD or Sphinx side can at least amend the most obvious issues, like this one.",
"> I wonder if some config changes on the RTD or Sphinx side can at least amend the most obvious issues, like this one.\r\n\r\nI believe the configuration is literally in the sphinx conf file in that translation repo which I do not have access to merge things to. I don't believe RTD can just fix this",
"What's interesting here is the pages are actually live. You can see that the prefixed domains in the sidebar work fine (i.e. https://de.python-requests.org redirects to https://docs.python-requests.org/de/latest/).\r\n\r\nIt looks like the primary docs for Requests are using `/en/master` instead of `/en/latest`. This is breaking the language navigator because the translations only exist at `/<language code>/latest`. If you navigate [here](https://docs.python-requests.org/en/latest/), the widget works correctly. This is almost certainly a bad configuration in [RTD](https://readthedocs.org/projects/requests/).\r\n\r\nI don't think any maintainers have had access to that account since at least 2018, so we'll need @ewdurbin or @kennethreitz to help with this.",
"Alright, it looks like we’ve got the pointers sorted. https://docs.python-requests.org should now point to “latest” renabling the correct behavior in the nav widget.\r\n\r\nThanks again for the report!",
"Thanks!\n\nOn Sun, Sep 12, 2021, 18:43 Nate Prewitt ***@***.***> wrote:\n\n> Alright, it looks like we’ve got the pointers sorted.\n> https://docs.python-requests.org should now point to “latest” renabling\n> the correct behavior in the nav widget.\n>\n> Thanks again for the report!\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/psf/requests/issues/5902#issuecomment-917723958>, or\n> unsubscribe\n> <https://github.com/notifications/unsubscribe-auth/AAAMNS7H6QJREW35Q35RHYLUBUUHZANCNFSM5CAU4WOA>\n> .\n> Triage notifications on the go with GitHub Mobile for iOS\n> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>\n> or Android\n> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.\n>\n>\n"
] |
https://api.github.com/repos/psf/requests/issues/5901
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/5901/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/5901/comments
|
https://api.github.com/repos/psf/requests/issues/5901/events
|
https://github.com/psf/requests/issues/5901
| 964,609,531 |
MDU6SXNzdWU5NjQ2MDk1MzE=
| 5,901 |
Cannot import requests on python 3.10 rc1
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/511154?v=4",
"events_url": "https://api.github.com/users/rkhwaja/events{/privacy}",
"followers_url": "https://api.github.com/users/rkhwaja/followers",
"following_url": "https://api.github.com/users/rkhwaja/following{/other_user}",
"gists_url": "https://api.github.com/users/rkhwaja/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rkhwaja",
"id": 511154,
"login": "rkhwaja",
"node_id": "MDQ6VXNlcjUxMTE1NA==",
"organizations_url": "https://api.github.com/users/rkhwaja/orgs",
"received_events_url": "https://api.github.com/users/rkhwaja/received_events",
"repos_url": "https://api.github.com/users/rkhwaja/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rkhwaja/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rkhwaja/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rkhwaja",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2021-08-10T05:28:16Z
|
2021-11-08T08:00:24Z
|
2021-08-10T07:36:56Z
|
NONE
|
resolved
|
Cannot import requests on python 3.10. The problem is that python 3.10 requires urllib3 >= 1.26.
## Expected Result
I expected the module to import without errors.
## Actual Result
Import failed due to urllib3 version. You get the following callstack:
``` from requests import Session
.../site-packages/requests/__init__.py:43: in <module>
import urllib3
.../site-packages/urllib3/__init__.py:8: in <module>
from .connectionpool import (
.../site-packages/urllib3/connectionpool.py:29: in <module>
from .connection import (
.../site-packages/urllib3/connection.py:39: in <module>
from .util.ssl_ import (
.../site-packages/urllib3/util/__init__.py:3: in <module>
from .connection import is_connection_dropped
.../site-packages/urllib3/util/connection.py:3: in <module>
from .wait import wait_for_read
.../site-packages/urllib3/util/wait.py:1: in <module>
from .selectors import (
.../site-packages/urllib3/util/selectors.py:14: in <module>
from collections import namedtuple, Mapping
ImportError: cannot import name 'Mapping' from 'collections' (.../Python/3.10.0-rc.1/x64/lib/python3.10/collections/__init__.py)
```
## Reproduction Steps
```python
import requests
```
## System Information
GitHub CI ubuntu-latest with python version 3.10.0-rc.1
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/5901/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/5901/timeline
| null |
completed
| null | null | false |
[
"Hi @rkhwaja, the failure you’re receiving is for a code path that hasn’t existed in urllib3 for over 4 years, so the solution would be to update to a newer version (>1.23 at the minimum).\r\n\r\nThis isn’t an issue with Requests and we can’t raise our pin version range without breaking a large portion of the Python ecosystem. There shouldn’t be anything inhibiting you from installing the correct version of urllib3 though."
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.