Datasets:

RajkNakka

/

github-issues-comments

like 0

{ "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rkc007", "id": 22396042, "login": "rkc007", "node_id": "MDQ6VXNlcjIyMzk2MDQy", "organizations_url": "https://api.github.com/users/rkc007/orgs", "received_events_url": "https://api.github.com/users/rkc007/received_events", "repos_url": "https://api.github.com/users/rkc007/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "type": "User", "url": "https://api.github.com/users/rkc007" }

[]

[]

[ "@lhoestq I saw some common changes you made on the other PR's (Similar Opus Datasets). I fixed those changes here. Can you please review it once ? \r\nThanks.", "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1555/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1555.diff", "html_url": "https://github.com/huggingface/datasets/pull/1555", "merged_at": "2020-12-18T09:44:43Z", "patch_url": "https://github.com/huggingface/datasets/pull/1555.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1555" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rkc007", "id": 22396042, "login": "rkc007", "node_id": "MDQ6VXNlcjIyMzk2MDQy", "organizations_url": "https://api.github.com/users/rkc007/orgs", "received_events_url": "https://api.github.com/users/rkc007/received_events", "repos_url": "https://api.github.com/users/rkc007/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "type": "User", "url": "https://api.github.com/users/rkc007" }

[]

[]

[ "@lhoestq I saw some common changes you made on the other PR's (Similar Opus Datasets). I fixed those changes here. Can you please review it once ? \r\nThanks.", "Hi @rkc007 , thanks for the contribution.\r\nUnfortunately, the CAPES dataset has already been added here: #1307\r\nI'm closing the PR ", "@lhoestq FYI" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1554/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1554.diff", "html_url": "https://github.com/huggingface/datasets/pull/1554", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1554.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1554" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/9033954?v=4", "events_url": "https://api.github.com/users/skyprince999/events{/privacy}", "followers_url": "https://api.github.com/users/skyprince999/followers", "following_url": "https://api.github.com/users/skyprince999/following{/other_user}", "gists_url": "https://api.github.com/users/skyprince999/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/skyprince999", "id": 9033954, "login": "skyprince999", "node_id": "MDQ6VXNlcjkwMzM5NTQ=", "organizations_url": "https://api.github.com/users/skyprince999/orgs", "received_events_url": "https://api.github.com/users/skyprince999/received_events", "repos_url": "https://api.github.com/users/skyprince999/repos", "site_admin": false, "starred_url": "https://api.github.com/users/skyprince999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/skyprince999/subscriptions", "type": "User", "url": "https://api.github.com/users/skyprince999" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1553/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1553.diff", "html_url": "https://github.com/huggingface/datasets/pull/1553", "merged_at": "2020-12-23T11:20:39Z", "patch_url": "https://github.com/huggingface/datasets/pull/1553.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1553" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rkc007", "id": 22396042, "login": "rkc007", "node_id": "MDQ6VXNlcjIyMzk2MDQy", "organizations_url": "https://api.github.com/users/rkc007/orgs", "received_events_url": "https://api.github.com/users/rkc007/received_events", "repos_url": "https://api.github.com/users/rkc007/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "type": "User", "url": "https://api.github.com/users/rkc007" }

[]

[]

[ "@lhoestq I saw some common changes you made on the other PR's (Similar Opus Datasets). I fixed those changes here. Can you please review it once ? \r\nThanks.", "@rkc007 @lhoestq just noticed a dataset named para_crawl has been added a long time ago: #91.", "They're not exactly the same so it's ok to have both.\r\n\r\nEspecially the `para_crawl` that already exists only uses the text from the ParaCrawl release 4.", "Could you regenerate the dataset_infos.json @rkc007 please ?\r\nIt looks like it has some issues due to the dataset class name change", "@SBrandeis Thank you for suggesting changes. I made the changes you suggested. \r\n\r\n@lhoestq I generated `dataset_infos.json` again. I ran both tests(Dummy & Real data) and it passed. Can you please review it again?", "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1552/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1552.diff", "html_url": "https://github.com/huggingface/datasets/pull/1552", "merged_at": "2020-12-21T09:50:25Z", "patch_url": "https://github.com/huggingface/datasets/pull/1552.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1552" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/2815308?v=4", "events_url": "https://api.github.com/users/iliemihai/events{/privacy}", "followers_url": "https://api.github.com/users/iliemihai/followers", "following_url": "https://api.github.com/users/iliemihai/following{/other_user}", "gists_url": "https://api.github.com/users/iliemihai/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/iliemihai", "id": 2815308, "login": "iliemihai", "node_id": "MDQ6VXNlcjI4MTUzMDg=", "organizations_url": "https://api.github.com/users/iliemihai/orgs", "received_events_url": "https://api.github.com/users/iliemihai/received_events", "repos_url": "https://api.github.com/users/iliemihai/repos", "site_admin": false, "starred_url": "https://api.github.com/users/iliemihai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iliemihai/subscriptions", "type": "User", "url": "https://api.github.com/users/iliemihai" }

[ { "color": "0e8a16", "default": false, "description": "Contribution to a dataset script", "id": 4564477500, "name": "dataset contribution", "node_id": "LA_kwDODunzps8AAAABEBBmPA", "url": "https://api.github.com/repos/huggingface/datasets/labels/dataset%20contribution" } ]

[]

[ "Hi @iliemihai - you need to add the Readme file! Otherwise seems good. \r\nAlso don't forget to run `make style` & `flake8 datasets` locally, from the datasets folder", "@skyprince999 I will add the README.d for it. Thank you :D ", "Thanks for your contribution, @iliemihai. Are you still interested in adding this dataset?\r\n\r\nWe are removing the dataset scripts from this GitHub repo and moving them to the Hugging Face Hub: https://huggingface.co/datasets\r\n\r\nWe would suggest you create this dataset there. Please, feel free to tell us if you need some help." ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1551/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1551.diff", "html_url": "https://github.com/huggingface/datasets/pull/1551", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1551.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1551" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/7421838?v=4", "events_url": "https://api.github.com/users/jamespaultg/events{/privacy}", "followers_url": "https://api.github.com/users/jamespaultg/followers", "following_url": "https://api.github.com/users/jamespaultg/following{/other_user}", "gists_url": "https://api.github.com/users/jamespaultg/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jamespaultg", "id": 7421838, "login": "jamespaultg", "node_id": "MDQ6VXNlcjc0MjE4Mzg=", "organizations_url": "https://api.github.com/users/jamespaultg/orgs", "received_events_url": "https://api.github.com/users/jamespaultg/received_events", "repos_url": "https://api.github.com/users/jamespaultg/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jamespaultg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jamespaultg/subscriptions", "type": "User", "url": "https://api.github.com/users/jamespaultg" }

[]

[]

[ "Thanks much!" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1550/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1550.diff", "html_url": "https://github.com/huggingface/datasets/pull/1550", "merged_at": "2020-12-18T14:25:30Z", "patch_url": "https://github.com/huggingface/datasets/pull/1550.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1550" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/12439573?v=4", "events_url": "https://api.github.com/users/bpatidar/events{/privacy}", "followers_url": "https://api.github.com/users/bpatidar/followers", "following_url": "https://api.github.com/users/bpatidar/following{/other_user}", "gists_url": "https://api.github.com/users/bpatidar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/bpatidar", "id": 12439573, "login": "bpatidar", "node_id": "MDQ6VXNlcjEyNDM5NTcz", "organizations_url": "https://api.github.com/users/bpatidar/orgs", "received_events_url": "https://api.github.com/users/bpatidar/received_events", "repos_url": "https://api.github.com/users/bpatidar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/bpatidar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bpatidar/subscriptions", "type": "User", "url": "https://api.github.com/users/bpatidar" }

[]

[]

[]

{ "+1": 1, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 1, "url": "https://api.github.com/repos/huggingface/datasets/issues/1549/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1549.diff", "html_url": "https://github.com/huggingface/datasets/pull/1549", "merged_at": "2020-12-21T13:55:09Z", "patch_url": "https://github.com/huggingface/datasets/pull/1549.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1549" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22171622?v=4", "events_url": "https://api.github.com/users/VIVelev/events{/privacy}", "followers_url": "https://api.github.com/users/VIVelev/followers", "following_url": "https://api.github.com/users/VIVelev/following{/other_user}", "gists_url": "https://api.github.com/users/VIVelev/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/VIVelev", "id": 22171622, "login": "VIVelev", "node_id": "MDQ6VXNlcjIyMTcxNjIy", "organizations_url": "https://api.github.com/users/VIVelev/orgs", "received_events_url": "https://api.github.com/users/VIVelev/received_events", "repos_url": "https://api.github.com/users/VIVelev/repos", "site_admin": false, "starred_url": "https://api.github.com/users/VIVelev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VIVelev/subscriptions", "type": "User", "url": "https://api.github.com/users/VIVelev" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1548/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1548.diff", "html_url": "https://github.com/huggingface/datasets/pull/1548", "merged_at": "2020-12-15T12:55:27Z", "patch_url": "https://github.com/huggingface/datasets/pull/1548.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1548" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/16264631?v=4", "events_url": "https://api.github.com/users/vrindaprabhu/events{/privacy}", "followers_url": "https://api.github.com/users/vrindaprabhu/followers", "following_url": "https://api.github.com/users/vrindaprabhu/following{/other_user}", "gists_url": "https://api.github.com/users/vrindaprabhu/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/vrindaprabhu", "id": 16264631, "login": "vrindaprabhu", "node_id": "MDQ6VXNlcjE2MjY0NjMx", "organizations_url": "https://api.github.com/users/vrindaprabhu/orgs", "received_events_url": "https://api.github.com/users/vrindaprabhu/received_events", "repos_url": "https://api.github.com/users/vrindaprabhu/repos", "site_admin": false, "starred_url": "https://api.github.com/users/vrindaprabhu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vrindaprabhu/subscriptions", "type": "User", "url": "https://api.github.com/users/vrindaprabhu" }

[]

[]

[ "**NOTE:**\r\n\r\n- Train and Dev: Manually downloaded (auto download is repeatedly giving `ConnectionError` for one of the files), Test: Auto Download\r\n- Dummy test is passing\r\n- The json file has been created with hard-coded paths for the manual downloads _(hardcoding has been removed from the final uploaded script)_\r\n- datasets-cli is still **failing** . It is not picking the right directory for the config. For instance, my folder structure is as below:\r\n ```\r\n ~/Downloads/Data/\r\n |--- English-to-Polish\r\n |--- (corresponding files) \r\n |--- Russian-Polish\r\n |--- (corresponding files) \r\n```\r\n\r\nWhen ru-pl is selected, ideally it has to search in Russian-Polish folder, but it is searching in '/Downloads/Data/' folder and hence getting a FileNotFound error.\r\n\r\nThe command run is \r\n`python datasets-cli test datasets/poleval2019_mt/ --save_infos --all_configs --data_dir ~/Downloads/Data/\r\n`\r\n", "Hi !\r\nThanks for the changes :)\r\n\r\nThe only error left is the dummy data. Since we changed for standard downloads instead of manual downloads its structure changed. Fortunately you can auto-generate the dummy data with this command:\r\n\r\n```\r\ndatasets-cli dummy_data ./datasets/poleval2019_mt --auto_generate --match_text_files \"*\"\r\n```\r\n\r\nCan you regenerate the dummy data using this command please ?", "Thank you for the help @lhoestq !! I was generating the dummy dataset in a wrong way! That _--match_text_files \"*\"_ did the trick! Now all the tests have passed! :-)", "Hi @vrindaprabhu ! Do you still have the Poleval2019 data files somewhere by any chance ? It appears the google drive URLs are not working anymore", "Hi @lhoestq. Just checked. I do not have the backup of the data anywhere. It also appears that PolEval does not repeat its tasks, the data seem to have gone forever. Do you think I should try contacting the organizers for more info?", "We tried already and they don't have the data anymore :(" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1547/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1547.diff", "html_url": "https://github.com/huggingface/datasets/pull/1547", "merged_at": "2020-12-21T16:13:21Z", "patch_url": "https://github.com/huggingface/datasets/pull/1547.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1547" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/35491698?v=4", "events_url": "https://api.github.com/users/KMFODA/events{/privacy}", "followers_url": "https://api.github.com/users/KMFODA/followers", "following_url": "https://api.github.com/users/KMFODA/following{/other_user}", "gists_url": "https://api.github.com/users/KMFODA/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/KMFODA", "id": 35491698, "login": "KMFODA", "node_id": "MDQ6VXNlcjM1NDkxNjk4", "organizations_url": "https://api.github.com/users/KMFODA/orgs", "received_events_url": "https://api.github.com/users/KMFODA/received_events", "repos_url": "https://api.github.com/users/KMFODA/repos", "site_admin": false, "starred_url": "https://api.github.com/users/KMFODA/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KMFODA/subscriptions", "type": "User", "url": "https://api.github.com/users/KMFODA" }

[]

[]

[ "HI @SBrandeis. Thanks for all the comments - very helpful. I realised that the tests had failed and had been trying to figure out what was causing them to do so. All the tests pass when I run the load_real_dataset test however when I run `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_persian_ner` I get the below error. One thing to note is that the automated dummy data file generation failed when I tried to run it so I manually created the dummy data and ensured that the last line in the file was an empty line as per your comments. Would appreciate your thoughts on what might be causing this:\r\n\r\n```\r\n__________________________________________________ LocalDatasetTest.test_load_dataset_all_configs_persian_ner __________________________________________________\r\n\r\nself = <tests.test_dataset_common.LocalDatasetTest testMethod=test_load_dataset_all_configs_persian_ner>, dataset_name = 'persian_ner'\r\n\r\n @slow\r\n def test_load_dataset_all_configs(self, dataset_name):\r\n configs = self.dataset_tester.load_all_configs(dataset_name, is_local=True)\r\n> self.dataset_tester.check_load_dataset(dataset_name, configs, is_local=True)\r\n\r\ntests/test_dataset_common.py:237: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\ntests/test_dataset_common.py:198: in check_load_dataset\r\n self.parent.assertTrue(len(dataset[split]) > 0)\r\nE AssertionError: False is not true\r\n--------------------------------------------------------------------- Captured stdout call ---------------------------------------------------------------------\r\nDownloading and preparing dataset persian_ner/fold1 (download: 1.00 MiB, generated: 1.00 MiB, post-processed: Unknown size, total: 2.00 MiB) to /var/folders/nk/yp5_m5c95cnc0cm_vbd7h7g80000gn/T/tmpzh495aac/persian_ner/fold1/1.1.0...\r\nDataset persian_ner downloaded and prepared to /var/folders/nk/yp5_m5c95cnc0cm_vbd7h7g80000gn/T/tmpzh495aac/persian_ner/fold1/1.1.0. Subsequent calls will reuse this data.\r\n--------------------------------------------------------------------- Captured stderr call ---------------------------------------------------------------------\r\n \r\n======================================================================= warnings summary =======================================================================\r\nenv/lib/python3.7/site-packages/tensorflow/python/autograph/utils/testing.py:21\r\n /Users/karimfoda/Documents/STUDIES/PYTHON/DATASETS/env/lib/python3.7/site-packages/tensorflow/python/autograph/utils/testing.py:21: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses\r\n import imp\r\n\r\nenv/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:693\r\n /Users/karimfoda/Documents/STUDIES/PYTHON/DATASETS/env/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:693: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working\r\n if not isinstance(type_params, collections.Iterable):\r\n\r\nenv/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:532\r\n /Users/karimfoda/Documents/STUDIES/PYTHON/DATASETS/env/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:532: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working\r\n if not isinstance(type_params, (collections.Sequence, set)):\r\n\r\nenv/lib/python3.7/site-packages/elasticsearch/compat.py:38\r\n /Users/karimfoda/Documents/STUDIES/PYTHON/DATASETS/env/lib/python3.7/site-packages/elasticsearch/compat.py:38: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working\r\n from collections import Mapping\r\n\r\n-- Docs: https://docs.pytest.org/en/stable/warnings.html\r\n=================================================================== short test summary info ====================================================================\r\nFAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_persian_ner - AssertionError: False is not true\r\n```", "Thanks @SBrandeis. It turns out the error was because I had to manually increase the n_lines variable to get the dummy data generation to cover at least one example. Should all be working okay now.", "Great, thanks!\r\nIt looks good to me, I'll let @lhoestq take over" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1546/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1546.diff", "html_url": "https://github.com/huggingface/datasets/pull/1546", "merged_at": "2020-12-23T09:53:03Z", "patch_url": "https://github.com/huggingface/datasets/pull/1546.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1546" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/11391118?v=4", "events_url": "https://api.github.com/users/IvanZidov/events{/privacy}", "followers_url": "https://api.github.com/users/IvanZidov/followers", "following_url": "https://api.github.com/users/IvanZidov/following{/other_user}", "gists_url": "https://api.github.com/users/IvanZidov/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/IvanZidov", "id": 11391118, "login": "IvanZidov", "node_id": "MDQ6VXNlcjExMzkxMTE4", "organizations_url": "https://api.github.com/users/IvanZidov/orgs", "received_events_url": "https://api.github.com/users/IvanZidov/received_events", "repos_url": "https://api.github.com/users/IvanZidov/repos", "site_admin": false, "starred_url": "https://api.github.com/users/IvanZidov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IvanZidov/subscriptions", "type": "User", "url": "https://api.github.com/users/IvanZidov" }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1545/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1545.diff", "html_url": "https://github.com/huggingface/datasets/pull/1545", "merged_at": "2020-12-18T13:35:17Z", "patch_url": "https://github.com/huggingface/datasets/pull/1545.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1545" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/33005287?v=4", "events_url": "https://api.github.com/users/tanmoyio/events{/privacy}", "followers_url": "https://api.github.com/users/tanmoyio/followers", "following_url": "https://api.github.com/users/tanmoyio/following{/other_user}", "gists_url": "https://api.github.com/users/tanmoyio/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/tanmoyio", "id": 33005287, "login": "tanmoyio", "node_id": "MDQ6VXNlcjMzMDA1Mjg3", "organizations_url": "https://api.github.com/users/tanmoyio/orgs", "received_events_url": "https://api.github.com/users/tanmoyio/received_events", "repos_url": "https://api.github.com/users/tanmoyio/repos", "site_admin": false, "starred_url": "https://api.github.com/users/tanmoyio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tanmoyio/subscriptions", "type": "User", "url": "https://api.github.com/users/tanmoyio" }

[]

[]

[ "@lhoestq why my tests are not running?", "Maybe an issue with CircleCI, let me try to make them run", "The CI error `tests/test_file_utils.py::TempSeedTest::test_tensorflow` is not related to this dataset and is fixed on master, you can ignore it", "what I need to do now", "Now the delimiter of the csv reader is fixed, thanks :) \r\n\r\nI just added a comment suggesting to try using actual URLS instead of a manual download if possible.\r\nThis would make things more convenient for the users. Can you try using the `dl_manager` to download the train/dev/test csv files instead of requiring manual download ?", "Also pinging @m3hrdadfi , since I just noticed that there's already a dataset script that was created 3 weeks ago for this dataset here: https://github.com/m3hrdadfi/wiki-summary/tree/master/datasets/wiki_summary_persian", "@lhoestq I am getting this error while generating the dummy data\r\n\r\n", "Can you try by adding the flag `--match_text_files \"*\"` ?", "now it worked", "@lhoestq pytest on dummy data passed, but on real data raising this issue\r\n\r\nhow to resolve it\r\n", "I see ! This is because the library did some verification to make sure it downloads the same files as in the first time you ran the `datasets-cli test` command with `--save_infos`. Since we're now downloading files, the verification fails. \r\n\r\nTo fix that you just need to regenerate the dataset_infos.json file:\r\n```\r\ndatasets-cli test ./datasets/wiki_summary --save_infos --all_configs --ignore_verifications\r\n```", "@lhoestq I have modified everything and It worked fine, dont know why it is not passing the tests ", "Awesome thank you !\r\n\r\nThe CI error `tests/test_file_utils.py::TempSeedTest::test_tensorflow` is not related to your dataset and is fixed on master.\r\nYou can ignore it :) ", "@lhoestq anything left to do ?", "The dataset script is all good now ! The dummy data and the dataset_infos.json file are good too :) ", "@lhoestq yay, thanks for helping me out , ", "merging since the CI is fixed on master", "@tanmoyio @lhoestq \r\n\r\nThank you both!" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1544/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1544.diff", "html_url": "https://github.com/huggingface/datasets/pull/1544", "merged_at": "2020-12-18T16:17:18Z", "patch_url": "https://github.com/huggingface/datasets/pull/1544.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1544" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/56379013?v=4", "events_url": "https://api.github.com/users/rahul-art/events{/privacy}", "followers_url": "https://api.github.com/users/rahul-art/followers", "following_url": "https://api.github.com/users/rahul-art/following{/other_user}", "gists_url": "https://api.github.com/users/rahul-art/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rahul-art", "id": 56379013, "login": "rahul-art", "node_id": "MDQ6VXNlcjU2Mzc5MDEz", "organizations_url": "https://api.github.com/users/rahul-art/orgs", "received_events_url": "https://api.github.com/users/rahul-art/received_events", "repos_url": "https://api.github.com/users/rahul-art/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rahul-art/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rahul-art/subscriptions", "type": "User", "url": "https://api.github.com/users/rahul-art" }

[]

[]

[ "@lhoestq I have created a new PR by reforking and creating a new branch ", "@rahul-art unfortunately this didn't quite work, here's how you can try again:\r\n- `git checkout master` to go back to the main branch\r\n- `git pull upstream master` to make it up to date\r\n- `git checkout -b add_hind_encorp` to create a new branch\r\n\r\nThen add the dataset script, `README.md`, `dummy_data.zip`, and `dataset_infos.json` to the tracked files for the branch with `git add` (please add all of these files individually, NOT the whole directory as we don't want the other data files)\r\nThen after you have passed the style checks and the local tests, do:\r\n- `git commit . -m initial_commit`\r\n- `git push --set-upstream origin add_hind_encorp`\r\n\r\nThen you can go to this branch on the WebApp and open a new PR", "@yjernite #1557 created new PR" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1543/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1543.diff", "html_url": "https://github.com/huggingface/datasets/pull/1543", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1543.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1543" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/821155?v=4", "events_url": "https://api.github.com/users/clmnt/events{/privacy}", "followers_url": "https://api.github.com/users/clmnt/followers", "following_url": "https://api.github.com/users/clmnt/following{/other_user}", "gists_url": "https://api.github.com/users/clmnt/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/clmnt", "id": 821155, "login": "clmnt", "node_id": "MDQ6VXNlcjgyMTE1NQ==", "organizations_url": "https://api.github.com/users/clmnt/orgs", "received_events_url": "https://api.github.com/users/clmnt/received_events", "repos_url": "https://api.github.com/users/clmnt/repos", "site_admin": false, "starred_url": "https://api.github.com/users/clmnt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clmnt/subscriptions", "type": "User", "url": "https://api.github.com/users/clmnt" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1542/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1542.diff", "html_url": "https://github.com/huggingface/datasets/pull/1542", "merged_at": "2020-12-13T17:16:40Z", "patch_url": "https://github.com/huggingface/datasets/pull/1542.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1542" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/73364383?v=4", "events_url": "https://api.github.com/users/rabeehkarimimahabadi/events{/privacy}", "followers_url": "https://api.github.com/users/rabeehkarimimahabadi/followers", "following_url": "https://api.github.com/users/rabeehkarimimahabadi/following{/other_user}", "gists_url": "https://api.github.com/users/rabeehkarimimahabadi/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rabeehkarimimahabadi", "id": 73364383, "login": "rabeehkarimimahabadi", "node_id": "MDQ6VXNlcjczMzY0Mzgz", "organizations_url": "https://api.github.com/users/rabeehkarimimahabadi/orgs", "received_events_url": "https://api.github.com/users/rabeehkarimimahabadi/received_events", "repos_url": "https://api.github.com/users/rabeehkarimimahabadi/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rabeehkarimimahabadi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rabeehkarimimahabadi/subscriptions", "type": "User", "url": "https://api.github.com/users/rabeehkarimimahabadi" }

[]

[]

[ "could you tell me how I can avoid download, by pre-downloading the data first, put them in a folder so the code does not try to redownload? could you tell me the path to put the downloaded data, and how to do it? thanks\r\n@lhoestq ", "Does your instance have an internet connection ?\r\n\r\nIf you don't have an internet connection you'll need to have the dataset on the instance disk.\r\nTo do so first download the dataset on another machine using `load_dataset` and then you can save it in a folder using `my_dataset.save_to_disk(\"path/to/folder\")`. Once the folder is copied on your instance you can reload the dataset with `datasets.load_from_disk(\"path/to/folder\")`" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1541/reactions" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/5150963?v=4", "events_url": "https://api.github.com/users/yavuzKomecoglu/events{/privacy}", "followers_url": "https://api.github.com/users/yavuzKomecoglu/followers", "following_url": "https://api.github.com/users/yavuzKomecoglu/following{/other_user}", "gists_url": "https://api.github.com/users/yavuzKomecoglu/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/yavuzKomecoglu", "id": 5150963, "login": "yavuzKomecoglu", "node_id": "MDQ6VXNlcjUxNTA5NjM=", "organizations_url": "https://api.github.com/users/yavuzKomecoglu/orgs", "received_events_url": "https://api.github.com/users/yavuzKomecoglu/received_events", "repos_url": "https://api.github.com/users/yavuzKomecoglu/repos", "site_admin": false, "starred_url": "https://api.github.com/users/yavuzKomecoglu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yavuzKomecoglu/subscriptions", "type": "User", "url": "https://api.github.com/users/yavuzKomecoglu" }

[]

[]

[ "@lhoestq, can you help with creating dummy_data?\r\n", "Hi @yavuzKomecoglu did you manage to build the dummy data ?", "> Hi @yavuzKomecoglu did you manage to build the dummy data ?\r\n\r\nHi, sorry for the return. I've created dummy_data.zip manually.", "> Nice thank you !\r\n> \r\n> Before we merge can you fill the two sections of the dataset card I suggested ?\r\n> And also remove one remaining print statement\r\n\r\nI updated your suggestions. Thank you very much for your support.", "I think you accidentally pushed the readme of another dataset (name_to_nation).\r\nI removed it so you have to `git pull`\r\n\r\nBecause of that I guess your changes about the ttc4900 was not included.\r\nFeel free to ping me once they're added\r\n\r\n\r\n", "> I think you accidentally pushed the readme of another dataset (name_to_nation).\r\n> I removed it so you have to `git pull`\r\n> \r\n> Because of that I guess your changes about the ttc4900 was not included.\r\n> Feel free to ping me once they're added\r\n\r\nI did `git pull` and updated readme **ttc4900**.", "merging since the Ci is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1540/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1540.diff", "html_url": "https://github.com/huggingface/datasets/pull/1540", "merged_at": "2020-12-18T10:09:01Z", "patch_url": "https://github.com/huggingface/datasets/pull/1540.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1540" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/7674948?v=4", "events_url": "https://api.github.com/users/katnoria/events{/privacy}", "followers_url": "https://api.github.com/users/katnoria/followers", "following_url": "https://api.github.com/users/katnoria/following{/other_user}", "gists_url": "https://api.github.com/users/katnoria/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/katnoria", "id": 7674948, "login": "katnoria", "node_id": "MDQ6VXNlcjc2NzQ5NDg=", "organizations_url": "https://api.github.com/users/katnoria/orgs", "received_events_url": "https://api.github.com/users/katnoria/received_events", "repos_url": "https://api.github.com/users/katnoria/repos", "site_admin": false, "starred_url": "https://api.github.com/users/katnoria/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/katnoria/subscriptions", "type": "User", "url": "https://api.github.com/users/katnoria" }

[]

[]

[ "> Awesome thank you !\r\n> \r\n> I just left one comment.\r\n> \r\n> Also it looks like the dummy_data.zip files are quite big (around 500KB each)\r\n> Can you try to reduce their sizes please ? Ideally they should be <20KB each\r\n> \r\n> To do so feel free to take a look inside them and in the jsonl files only keep 1 or 2 samples instead of 5 and also remove big chunks of text to only keep a few passages.\r\n\r\nThanks, I have updated the dummy data to keep each domain <20/30KB.", "> > Awesome thank you !\r\n> > I just left one comment.\r\n> > Also it looks like the dummy_data.zip files are quite big (around 500KB each)\r\n> > Can you try to reduce their sizes please ? Ideally they should be <20KB each\r\n> > To do so feel free to take a look inside them and in the jsonl files only keep 1 or 2 samples instead of 5 and also remove big chunks of text to only keep a few passages.\r\n> \r\n> Thanks, I have updated the dummy data to keep each domain <20/30KB.\r\n\r\nLooks like this branch has other commits. I will open a new PR with suggested changes.", "opened a new PR #1612 " ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1539/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1539.diff", "html_url": "https://github.com/huggingface/datasets/pull/1539", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1539.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1539" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/44197177?v=4", "events_url": "https://api.github.com/users/darshan-gandhi/events{/privacy}", "followers_url": "https://api.github.com/users/darshan-gandhi/followers", "following_url": "https://api.github.com/users/darshan-gandhi/following{/other_user}", "gists_url": "https://api.github.com/users/darshan-gandhi/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/darshan-gandhi", "id": 44197177, "login": "darshan-gandhi", "node_id": "MDQ6VXNlcjQ0MTk3MTc3", "organizations_url": "https://api.github.com/users/darshan-gandhi/orgs", "received_events_url": "https://api.github.com/users/darshan-gandhi/received_events", "repos_url": "https://api.github.com/users/darshan-gandhi/repos", "site_admin": false, "starred_url": "https://api.github.com/users/darshan-gandhi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/darshan-gandhi/subscriptions", "type": "User", "url": "https://api.github.com/users/darshan-gandhi" }

[]

[]

[ "Hi @lhoestq I have added this new dataset for tweet's hate speech detection. \r\n\r\nPlease if u could review it. \r\n\r\nThank you", "Hi @darshan-gandhi have you add a chance to take a look at my suggestions ?\r\n\r\nFeel free to ping me when you're ready for the final review", "Closing in favor of #1607" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1538/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1538.diff", "html_url": "https://github.com/huggingface/datasets/pull/1538", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1538.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1538" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/9033954?v=4", "events_url": "https://api.github.com/users/skyprince999/events{/privacy}", "followers_url": "https://api.github.com/users/skyprince999/followers", "following_url": "https://api.github.com/users/skyprince999/following{/other_user}", "gists_url": "https://api.github.com/users/skyprince999/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/skyprince999", "id": 9033954, "login": "skyprince999", "node_id": "MDQ6VXNlcjkwMzM5NTQ=", "organizations_url": "https://api.github.com/users/skyprince999/orgs", "received_events_url": "https://api.github.com/users/skyprince999/received_events", "repos_url": "https://api.github.com/users/skyprince999/repos", "site_admin": false, "starred_url": "https://api.github.com/users/skyprince999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/skyprince999/subscriptions", "type": "User", "url": "https://api.github.com/users/skyprince999" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1537/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1537.diff", "html_url": "https://github.com/huggingface/datasets/pull/1537", "merged_at": "2020-12-17T18:28:16Z", "patch_url": "https://github.com/huggingface/datasets/pull/1537.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1537" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/6687858?v=4", "events_url": "https://api.github.com/users/manandey/events{/privacy}", "followers_url": "https://api.github.com/users/manandey/followers", "following_url": "https://api.github.com/users/manandey/following{/other_user}", "gists_url": "https://api.github.com/users/manandey/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/manandey", "id": 6687858, "login": "manandey", "node_id": "MDQ6VXNlcjY2ODc4NTg=", "organizations_url": "https://api.github.com/users/manandey/orgs", "received_events_url": "https://api.github.com/users/manandey/received_events", "repos_url": "https://api.github.com/users/manandey/repos", "site_admin": false, "starred_url": "https://api.github.com/users/manandey/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manandey/subscriptions", "type": "User", "url": "https://api.github.com/users/manandey" }

[]

[]

[ "> Before we merge can you try to reduce the size of the dummy_data.zip file ?\r\n> \r\n> To do so feel free to only keep a few lines of the csv files ans also remove unnecessary chunks of texts (for example keep only the first sentences of a story).\r\n\r\nHi @lhoestq, I have reduced the size of the dummy_data.zip file by making the necessary changes you had suggested. ", "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1536/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1536.diff", "html_url": "https://github.com/huggingface/datasets/pull/1536", "merged_at": "2020-12-15T13:40:11Z", "patch_url": "https://github.com/huggingface/datasets/pull/1536.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1536" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22298787?v=4", "events_url": "https://api.github.com/users/purvimisal/events{/privacy}", "followers_url": "https://api.github.com/users/purvimisal/followers", "following_url": "https://api.github.com/users/purvimisal/following{/other_user}", "gists_url": "https://api.github.com/users/purvimisal/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/purvimisal", "id": 22298787, "login": "purvimisal", "node_id": "MDQ6VXNlcjIyMjk4Nzg3", "organizations_url": "https://api.github.com/users/purvimisal/orgs", "received_events_url": "https://api.github.com/users/purvimisal/received_events", "repos_url": "https://api.github.com/users/purvimisal/repos", "site_admin": false, "starred_url": "https://api.github.com/users/purvimisal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/purvimisal/subscriptions", "type": "User", "url": "https://api.github.com/users/purvimisal" }

[]

[]

[ "@lhoestq Thank you for the review. I have made all the changes you mentioned. PTAL! " ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1535/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1535.diff", "html_url": "https://github.com/huggingface/datasets/pull/1535", "merged_at": "2020-12-21T14:39:48Z", "patch_url": "https://github.com/huggingface/datasets/pull/1535.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1535" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/MisbahKhan789", "id": 15351802, "login": "MisbahKhan789", "node_id": "MDQ6VXNlcjE1MzUxODAy", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "site_admin": false, "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "type": "User", "url": "https://api.github.com/users/MisbahKhan789" }

[]

[]

[ "Requested changes made and new PR submitted here: https://github.com/huggingface/datasets/pull/1580 " ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1534/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1534.diff", "html_url": "https://github.com/huggingface/datasets/pull/1534", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1534.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1534" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/7669893?v=4", "events_url": "https://api.github.com/users/cahya-wirawan/events{/privacy}", "followers_url": "https://api.github.com/users/cahya-wirawan/followers", "following_url": "https://api.github.com/users/cahya-wirawan/following{/other_user}", "gists_url": "https://api.github.com/users/cahya-wirawan/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cahya-wirawan", "id": 7669893, "login": "cahya-wirawan", "node_id": "MDQ6VXNlcjc2Njk4OTM=", "organizations_url": "https://api.github.com/users/cahya-wirawan/orgs", "received_events_url": "https://api.github.com/users/cahya-wirawan/received_events", "repos_url": "https://api.github.com/users/cahya-wirawan/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cahya-wirawan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cahya-wirawan/subscriptions", "type": "User", "url": "https://api.github.com/users/cahya-wirawan" }

[]

[]

[ "Hi @lhoestq, thanks for the review. I will have a look and update it accordingly.", "Strange error message :-)\r\n\r\n```\r\n> tf_context = tf.python.context.context() # eager mode context\r\nE AttributeError: module 'tensorflow' has no attribute 'python'\r\n```\r\n" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1533/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1533.diff", "html_url": "https://github.com/huggingface/datasets/pull/1533", "merged_at": "2020-12-21T10:40:36Z", "patch_url": "https://github.com/huggingface/datasets/pull/1533.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1533" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/MisbahKhan789", "id": 15351802, "login": "MisbahKhan789", "node_id": "MDQ6VXNlcjE1MzUxODAy", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "site_admin": false, "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "type": "User", "url": "https://api.github.com/users/MisbahKhan789" }

[]

[]

[ "made suggested changes and a new PR created here : https://github.com/huggingface/datasets/pull/1597" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1532/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1532.diff", "html_url": "https://github.com/huggingface/datasets/pull/1532", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1532.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1532" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/MisbahKhan789", "id": 15351802, "login": "MisbahKhan789", "node_id": "MDQ6VXNlcjE1MzUxODAy", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "site_admin": false, "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "type": "User", "url": "https://api.github.com/users/MisbahKhan789" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1531/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1531.diff", "html_url": "https://github.com/huggingface/datasets/pull/1531", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1531.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1531" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/6518504?v=4", "events_url": "https://api.github.com/users/yasirabd/events{/privacy}", "followers_url": "https://api.github.com/users/yasirabd/followers", "following_url": "https://api.github.com/users/yasirabd/following{/other_user}", "gists_url": "https://api.github.com/users/yasirabd/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/yasirabd", "id": 6518504, "login": "yasirabd", "node_id": "MDQ6VXNlcjY1MTg1MDQ=", "organizations_url": "https://api.github.com/users/yasirabd/orgs", "received_events_url": "https://api.github.com/users/yasirabd/received_events", "repos_url": "https://api.github.com/users/yasirabd/repos", "site_admin": false, "starred_url": "https://api.github.com/users/yasirabd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yasirabd/subscriptions", "type": "User", "url": "https://api.github.com/users/yasirabd" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1530/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1530.diff", "html_url": "https://github.com/huggingface/datasets/pull/1530", "merged_at": "2020-12-16T11:11:43Z", "patch_url": "https://github.com/huggingface/datasets/pull/1530.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1530" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/2815308?v=4", "events_url": "https://api.github.com/users/iliemihai/events{/privacy}", "followers_url": "https://api.github.com/users/iliemihai/followers", "following_url": "https://api.github.com/users/iliemihai/following{/other_user}", "gists_url": "https://api.github.com/users/iliemihai/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/iliemihai", "id": 2815308, "login": "iliemihai", "node_id": "MDQ6VXNlcjI4MTUzMDg=", "organizations_url": "https://api.github.com/users/iliemihai/orgs", "received_events_url": "https://api.github.com/users/iliemihai/received_events", "repos_url": "https://api.github.com/users/iliemihai/repos", "site_admin": false, "starred_url": "https://api.github.com/users/iliemihai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iliemihai/subscriptions", "type": "User", "url": "https://api.github.com/users/iliemihai" }

[]

[]

[ "Hi @iliemihai, it looks like this PR holds changes from your previous PR #1493 .\r\nWould you mind removing them from the branch please ?", "@SBrandeis I am sorry. Yes I will remove them. Thank you :D ", "Hi @lhoestq @SBrandeis @iliemihai\r\n\r\nIs this still in progress or can I take over this one?\r\n\r\nThanks,\r\nGunjan", "Hi,\r\nWhile trying to add this dataset, I found some potential issues. \r\nThe homepage mentioned is : https://github.com/katakonst/sentiment-analysis-tensorflow/tree/master/datasets/ro/, where the dataset is different from the URLs: https://raw.githubusercontent.com/dumitrescustefan/Romanian-Transformers/examples/examples/sentiment_analysis/ro/train.csv. It is unclear which dataset is \"correct\". I checked the total examples (train+test) in both places and they do not match.", "We should use the data from dumitrescustefan and set the homepage to his repo IMO, since he's first author of the paper of the dataset.", "Hi @lhoestq,\r\n\r\nCool, I'll get working on it.\r\n\r\nThanks", "Hi @lhoestq, \r\n\r\nThis PR can be closed.", "Closing in favor of #2011 \r\nThanks again for adding it !" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1529/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1529.diff", "html_url": "https://github.com/huggingface/datasets/pull/1529", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1529.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1529" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/13200370?v=4", "events_url": "https://api.github.com/users/Karthik-Bhaskar/events{/privacy}", "followers_url": "https://api.github.com/users/Karthik-Bhaskar/followers", "following_url": "https://api.github.com/users/Karthik-Bhaskar/following{/other_user}", "gists_url": "https://api.github.com/users/Karthik-Bhaskar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Karthik-Bhaskar", "id": 13200370, "login": "Karthik-Bhaskar", "node_id": "MDQ6VXNlcjEzMjAwMzcw", "organizations_url": "https://api.github.com/users/Karthik-Bhaskar/orgs", "received_events_url": "https://api.github.com/users/Karthik-Bhaskar/received_events", "repos_url": "https://api.github.com/users/Karthik-Bhaskar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Karthik-Bhaskar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthik-Bhaskar/subscriptions", "type": "User", "url": "https://api.github.com/users/Karthik-Bhaskar" }

[]

[]

[ "Thank you :)" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1528/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1528.diff", "html_url": "https://github.com/huggingface/datasets/pull/1528", "merged_at": "2020-12-18T10:22:32Z", "patch_url": "https://github.com/huggingface/datasets/pull/1528.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1528" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rkc007", "id": 22396042, "login": "rkc007", "node_id": "MDQ6VXNlcjIyMzk2MDQy", "organizations_url": "https://api.github.com/users/rkc007/orgs", "received_events_url": "https://api.github.com/users/rkc007/received_events", "repos_url": "https://api.github.com/users/rkc007/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "type": "User", "url": "https://api.github.com/users/rkc007" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1527/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1527.diff", "html_url": "https://github.com/huggingface/datasets/pull/1527", "merged_at": "2020-12-13T19:14:24Z", "patch_url": "https://github.com/huggingface/datasets/pull/1527.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1527" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/10088963?v=4", "events_url": "https://api.github.com/users/imvladikon/events{/privacy}", "followers_url": "https://api.github.com/users/imvladikon/followers", "following_url": "https://api.github.com/users/imvladikon/following{/other_user}", "gists_url": "https://api.github.com/users/imvladikon/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/imvladikon", "id": 10088963, "login": "imvladikon", "node_id": "MDQ6VXNlcjEwMDg4OTYz", "organizations_url": "https://api.github.com/users/imvladikon/orgs", "received_events_url": "https://api.github.com/users/imvladikon/received_events", "repos_url": "https://api.github.com/users/imvladikon/repos", "site_admin": false, "starred_url": "https://api.github.com/users/imvladikon/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imvladikon/subscriptions", "type": "User", "url": "https://api.github.com/users/imvladikon" }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1526/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1526.diff", "html_url": "https://github.com/huggingface/datasets/pull/1526", "merged_at": "2020-12-18T10:47:30Z", "patch_url": "https://github.com/huggingface/datasets/pull/1526.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1526" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/8900094?v=4", "events_url": "https://api.github.com/users/ontocord/events{/privacy}", "followers_url": "https://api.github.com/users/ontocord/followers", "following_url": "https://api.github.com/users/ontocord/following{/other_user}", "gists_url": "https://api.github.com/users/ontocord/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ontocord", "id": 8900094, "login": "ontocord", "node_id": "MDQ6VXNlcjg5MDAwOTQ=", "organizations_url": "https://api.github.com/users/ontocord/orgs", "received_events_url": "https://api.github.com/users/ontocord/received_events", "repos_url": "https://api.github.com/users/ontocord/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ontocord/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ontocord/subscriptions", "type": "User", "url": "https://api.github.com/users/ontocord" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1525/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1525.diff", "html_url": "https://github.com/huggingface/datasets/pull/1525", "merged_at": "2020-12-28T15:51:11Z", "patch_url": "https://github.com/huggingface/datasets/pull/1525.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1525" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/29649801?v=4", "events_url": "https://api.github.com/users/akshayb7/events{/privacy}", "followers_url": "https://api.github.com/users/akshayb7/followers", "following_url": "https://api.github.com/users/akshayb7/following{/other_user}", "gists_url": "https://api.github.com/users/akshayb7/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/akshayb7", "id": 29649801, "login": "akshayb7", "node_id": "MDQ6VXNlcjI5NjQ5ODAx", "organizations_url": "https://api.github.com/users/akshayb7/orgs", "received_events_url": "https://api.github.com/users/akshayb7/received_events", "repos_url": "https://api.github.com/users/akshayb7/repos", "site_admin": false, "starred_url": "https://api.github.com/users/akshayb7/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akshayb7/subscriptions", "type": "User", "url": "https://api.github.com/users/akshayb7" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1524/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1524.diff", "html_url": "https://github.com/huggingface/datasets/pull/1524", "merged_at": "2020-12-17T16:37:16Z", "patch_url": "https://github.com/huggingface/datasets/pull/1524.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1524" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/57645283?v=4", "events_url": "https://api.github.com/users/mariagrandury/events{/privacy}", "followers_url": "https://api.github.com/users/mariagrandury/followers", "following_url": "https://api.github.com/users/mariagrandury/following{/other_user}", "gists_url": "https://api.github.com/users/mariagrandury/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mariagrandury", "id": 57645283, "login": "mariagrandury", "node_id": "MDQ6VXNlcjU3NjQ1Mjgz", "organizations_url": "https://api.github.com/users/mariagrandury/orgs", "received_events_url": "https://api.github.com/users/mariagrandury/received_events", "repos_url": "https://api.github.com/users/mariagrandury/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mariagrandury/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mariagrandury/subscriptions", "type": "User", "url": "https://api.github.com/users/mariagrandury" }

[]

[]

[ "Thank you very much for your review @lewtun ! \r\n\r\nI've updated the script metadata, created the README and fixed the two details you commented.\r\n\r\nReady for another review! 🤗 ", "I've updated the task tag as we discussed and also added a couple of lines of code to make sure I include all the available examples.\r\n\r\nThank you again!" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1523/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1523.diff", "html_url": "https://github.com/huggingface/datasets/pull/1523", "merged_at": "2020-12-17T16:48:56Z", "patch_url": "https://github.com/huggingface/datasets/pull/1523.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1523" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/7950786?v=4", "events_url": "https://api.github.com/users/ZacharySBrown/events{/privacy}", "followers_url": "https://api.github.com/users/ZacharySBrown/followers", "following_url": "https://api.github.com/users/ZacharySBrown/following{/other_user}", "gists_url": "https://api.github.com/users/ZacharySBrown/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ZacharySBrown", "id": 7950786, "login": "ZacharySBrown", "node_id": "MDQ6VXNlcjc5NTA3ODY=", "organizations_url": "https://api.github.com/users/ZacharySBrown/orgs", "received_events_url": "https://api.github.com/users/ZacharySBrown/received_events", "repos_url": "https://api.github.com/users/ZacharySBrown/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ZacharySBrown/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ZacharySBrown/subscriptions", "type": "User", "url": "https://api.github.com/users/ZacharySBrown" }

[]

[]

[ "@SBrandeis : Thanks for the feedback! Just updated to use context manager for the `open`s and removed the placeholder text from the `README`!", "Great, thanks @ZacharySBrown !\r\nFailing tests seem to be unrelated to your changes, merging the current master branch into yours should fix them.\r\n" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1522/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1522.diff", "html_url": "https://github.com/huggingface/datasets/pull/1522", "merged_at": "2020-12-15T16:48:52Z", "patch_url": "https://github.com/huggingface/datasets/pull/1522.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1522" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/8900094?v=4", "events_url": "https://api.github.com/users/ontocord/events{/privacy}", "followers_url": "https://api.github.com/users/ontocord/followers", "following_url": "https://api.github.com/users/ontocord/following{/other_user}", "gists_url": "https://api.github.com/users/ontocord/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ontocord", "id": 8900094, "login": "ontocord", "node_id": "MDQ6VXNlcjg5MDAwOTQ=", "organizations_url": "https://api.github.com/users/ontocord/orgs", "received_events_url": "https://api.github.com/users/ontocord/received_events", "repos_url": "https://api.github.com/users/ontocord/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ontocord/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ontocord/subscriptions", "type": "User", "url": "https://api.github.com/users/ontocord" }

[]

[]

[ "I had to create a new PR to fix git errors. See: https://github.com/huggingface/datasets/pull/1525\r\n\r\nI'm closing this PR. " ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1521/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1521.diff", "html_url": "https://github.com/huggingface/datasets/pull/1521", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1521.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1521" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/44197177?v=4", "events_url": "https://api.github.com/users/darshan-gandhi/events{/privacy}", "followers_url": "https://api.github.com/users/darshan-gandhi/followers", "following_url": "https://api.github.com/users/darshan-gandhi/following{/other_user}", "gists_url": "https://api.github.com/users/darshan-gandhi/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/darshan-gandhi", "id": 44197177, "login": "darshan-gandhi", "node_id": "MDQ6VXNlcjQ0MTk3MTc3", "organizations_url": "https://api.github.com/users/darshan-gandhi/orgs", "received_events_url": "https://api.github.com/users/darshan-gandhi/received_events", "repos_url": "https://api.github.com/users/darshan-gandhi/repos", "site_admin": false, "starred_url": "https://api.github.com/users/darshan-gandhi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/darshan-gandhi/subscriptions", "type": "User", "url": "https://api.github.com/users/darshan-gandhi" }

[ { "color": "0e8a16", "default": false, "description": "Contribution to a dataset script", "id": 4564477500, "name": "dataset contribution", "node_id": "LA_kwDODunzps8AAAABEBBmPA", "url": "https://api.github.com/repos/huggingface/datasets/labels/dataset%20contribution" } ]

[]

[ "Hi @lhoestq \r\n\r\nI have added the readme as well \r\n\r\nPlease do have a look at it when suitable ", "Chatted with @darshan-gandhi on Slack about parsing examples into a separate text and sentiment field", "Thanks for your contribution, @darshan-gandhi. Are you still interested in adding this dataset?\r\n\r\nWe are removing the dataset scripts from this GitHub repo and moving them to the Hugging Face Hub: https://huggingface.co/datasets\r\n\r\nWe would suggest you create this dataset there. Please, feel free to tell us if you need some help." ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1520/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1520.diff", "html_url": "https://github.com/huggingface/datasets/pull/1520", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1520.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1520" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/13200370?v=4", "events_url": "https://api.github.com/users/Karthik-Bhaskar/events{/privacy}", "followers_url": "https://api.github.com/users/Karthik-Bhaskar/followers", "following_url": "https://api.github.com/users/Karthik-Bhaskar/following{/other_user}", "gists_url": "https://api.github.com/users/Karthik-Bhaskar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Karthik-Bhaskar", "id": 13200370, "login": "Karthik-Bhaskar", "node_id": "MDQ6VXNlcjEzMjAwMzcw", "organizations_url": "https://api.github.com/users/Karthik-Bhaskar/orgs", "received_events_url": "https://api.github.com/users/Karthik-Bhaskar/received_events", "repos_url": "https://api.github.com/users/Karthik-Bhaskar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Karthik-Bhaskar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthik-Bhaskar/subscriptions", "type": "User", "url": "https://api.github.com/users/Karthik-Bhaskar" }

[]

[]

[ "@yjernite Thank you for your help, generating the dummy data 🤗 Having that all the tests have passed 👍🏻", "merging since the CI is fixed on master", "Thank you :)" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1519/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1519.diff", "html_url": "https://github.com/huggingface/datasets/pull/1519", "merged_at": "2020-12-17T17:03:30Z", "patch_url": "https://github.com/huggingface/datasets/pull/1519.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1519" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dadelani", "id": 23586676, "login": "dadelani", "node_id": "MDQ6VXNlcjIzNTg2Njc2", "organizations_url": "https://api.github.com/users/dadelani/orgs", "received_events_url": "https://api.github.com/users/dadelani/received_events", "repos_url": "https://api.github.com/users/dadelani/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "type": "User", "url": "https://api.github.com/users/dadelani" }

[]

[]

[ "Hii please follow me", "thank you" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1518/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1518.diff", "html_url": "https://github.com/huggingface/datasets/pull/1518", "merged_at": "2020-12-13T18:53:37Z", "patch_url": "https://github.com/huggingface/datasets/pull/1518.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1518" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/13534540?v=4", "events_url": "https://api.github.com/users/pacman100/events{/privacy}", "followers_url": "https://api.github.com/users/pacman100/followers", "following_url": "https://api.github.com/users/pacman100/following{/other_user}", "gists_url": "https://api.github.com/users/pacman100/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/pacman100", "id": 13534540, "login": "pacman100", "node_id": "MDQ6VXNlcjEzNTM0NTQw", "organizations_url": "https://api.github.com/users/pacman100/orgs", "received_events_url": "https://api.github.com/users/pacman100/received_events", "repos_url": "https://api.github.com/users/pacman100/repos", "site_admin": false, "starred_url": "https://api.github.com/users/pacman100/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pacman100/subscriptions", "type": "User", "url": "https://api.github.com/users/pacman100" }

[]

[]

[ "Hii please follow me", "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1517/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1517.diff", "html_url": "https://github.com/huggingface/datasets/pull/1517", "merged_at": "2020-12-16T14:56:14Z", "patch_url": "https://github.com/huggingface/datasets/pull/1517.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1517" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/15803781?v=4", "events_url": "https://api.github.com/users/kldarek/events{/privacy}", "followers_url": "https://api.github.com/users/kldarek/followers", "following_url": "https://api.github.com/users/kldarek/following{/other_user}", "gists_url": "https://api.github.com/users/kldarek/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kldarek", "id": 15803781, "login": "kldarek", "node_id": "MDQ6VXNlcjE1ODAzNzgx", "organizations_url": "https://api.github.com/users/kldarek/orgs", "received_events_url": "https://api.github.com/users/kldarek/received_events", "repos_url": "https://api.github.com/users/kldarek/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kldarek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kldarek/subscriptions", "type": "User", "url": "https://api.github.com/users/kldarek" }

[]

[]

[ "@lhoestq thanks for the comments! Should be fixed in the latest commit, I assume the CI errors are unrelated. ", "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1516/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1516.diff", "html_url": "https://github.com/huggingface/datasets/pull/1516", "merged_at": "2020-12-18T09:41:33Z", "patch_url": "https://github.com/huggingface/datasets/pull/1516.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1516" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dadelani", "id": 23586676, "login": "dadelani", "node_id": "MDQ6VXNlcjIzNTg2Njc2", "organizations_url": "https://api.github.com/users/dadelani/orgs", "received_events_url": "https://api.github.com/users/dadelani/received_events", "repos_url": "https://api.github.com/users/dadelani/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "type": "User", "url": "https://api.github.com/users/dadelani" }

[]

[]

[ "closing since #1379 got merged" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1515/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1515.diff", "html_url": "https://github.com/huggingface/datasets/pull/1515", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1515.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1515" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/6278280?v=4", "events_url": "https://api.github.com/users/rabeehk/events{/privacy}", "followers_url": "https://api.github.com/users/rabeehk/followers", "following_url": "https://api.github.com/users/rabeehk/following{/other_user}", "gists_url": "https://api.github.com/users/rabeehk/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rabeehk", "id": 6278280, "login": "rabeehk", "node_id": "MDQ6VXNlcjYyNzgyODA=", "organizations_url": "https://api.github.com/users/rabeehk/orgs", "received_events_url": "https://api.github.com/users/rabeehk/received_events", "repos_url": "https://api.github.com/users/rabeehk/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rabeehk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rabeehk/subscriptions", "type": "User", "url": "https://api.github.com/users/rabeehk" }

[ { "color": "d876e3", "default": true, "description": "Further information is requested", "id": 1935892912, "name": "question", "node_id": "MDU6TGFiZWwxOTM1ODkyOTEy", "url": "https://api.github.com/repos/huggingface/datasets/labels/question" } ]

[]

[ "In a dataset, labels correspond to the `ClassLabel` feature that has the `names` property that returns string represenation of the integer classes (or `num_classes` to get the number of different classes).", "I think the `features` attribute of the dataset object is what you are looking for:\r\n```\r\n>>> dataset.features\r\n{'sentence1': Value(dtype='string', id=None),\r\n 'sentence2': Value(dtype='string', id=None),\r\n 'label': ClassLabel(num_classes=2, names=['not_equivalent', 'equivalent'], names_file=None, id=None),\r\n 'idx': Value(dtype='int32', id=None)\r\n}\r\n>>> dataset.features[\"label\"].names\r\n['not_equivalent', 'equivalent']\r\n```\r\n\r\nFor reference: https://huggingface.co/docs/datasets/exploring.html" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1514/reactions" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/44197177?v=4", "events_url": "https://api.github.com/users/darshan-gandhi/events{/privacy}", "followers_url": "https://api.github.com/users/darshan-gandhi/followers", "following_url": "https://api.github.com/users/darshan-gandhi/following{/other_user}", "gists_url": "https://api.github.com/users/darshan-gandhi/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/darshan-gandhi", "id": 44197177, "login": "darshan-gandhi", "node_id": "MDQ6VXNlcjQ0MTk3MTc3", "organizations_url": "https://api.github.com/users/darshan-gandhi/orgs", "received_events_url": "https://api.github.com/users/darshan-gandhi/received_events", "repos_url": "https://api.github.com/users/darshan-gandhi/repos", "site_admin": false, "starred_url": "https://api.github.com/users/darshan-gandhi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/darshan-gandhi/subscriptions", "type": "User", "url": "https://api.github.com/users/darshan-gandhi" }

[]

[]

[ "Hi @lhoestq \r\n\r\nI have added the readme file as well, please if you could check it once \r\n\r\nThank you " ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1513/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1513.diff", "html_url": "https://github.com/huggingface/datasets/pull/1513", "merged_at": "2020-12-14T20:45:24Z", "patch_url": "https://github.com/huggingface/datasets/pull/1513.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1513" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/6687858?v=4", "events_url": "https://api.github.com/users/manandey/events{/privacy}", "followers_url": "https://api.github.com/users/manandey/followers", "following_url": "https://api.github.com/users/manandey/following{/other_user}", "gists_url": "https://api.github.com/users/manandey/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/manandey", "id": 6687858, "login": "manandey", "node_id": "MDQ6VXNlcjY2ODc4NTg=", "organizations_url": "https://api.github.com/users/manandey/orgs", "received_events_url": "https://api.github.com/users/manandey/received_events", "repos_url": "https://api.github.com/users/manandey/repos", "site_admin": false, "starred_url": "https://api.github.com/users/manandey/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manandey/subscriptions", "type": "User", "url": "https://api.github.com/users/manandey" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1512/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1512.diff", "html_url": "https://github.com/huggingface/datasets/pull/1512", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1512.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1512" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/75574105?v=4", "events_url": "https://api.github.com/users/czabo/events{/privacy}", "followers_url": "https://api.github.com/users/czabo/followers", "following_url": "https://api.github.com/users/czabo/following{/other_user}", "gists_url": "https://api.github.com/users/czabo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/czabo", "id": 75574105, "login": "czabo", "node_id": "MDQ6VXNlcjc1NTc0MTA1", "organizations_url": "https://api.github.com/users/czabo/orgs", "received_events_url": "https://api.github.com/users/czabo/received_events", "repos_url": "https://api.github.com/users/czabo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/czabo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/czabo/subscriptions", "type": "User", "url": "https://api.github.com/users/czabo" }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1511/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1511.diff", "html_url": "https://github.com/huggingface/datasets/pull/1511", "merged_at": "2020-12-17T16:19:58Z", "patch_url": "https://github.com/huggingface/datasets/pull/1511.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1511" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/12439573?v=4", "events_url": "https://api.github.com/users/bpatidar/events{/privacy}", "followers_url": "https://api.github.com/users/bpatidar/followers", "following_url": "https://api.github.com/users/bpatidar/following{/other_user}", "gists_url": "https://api.github.com/users/bpatidar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/bpatidar", "id": 12439573, "login": "bpatidar", "node_id": "MDQ6VXNlcjEyNDM5NTcz", "organizations_url": "https://api.github.com/users/bpatidar/orgs", "received_events_url": "https://api.github.com/users/bpatidar/received_events", "repos_url": "https://api.github.com/users/bpatidar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/bpatidar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bpatidar/subscriptions", "type": "User", "url": "https://api.github.com/users/bpatidar" }

[]

[]

[ "Hii please follow me", "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1510/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1510.diff", "html_url": "https://github.com/huggingface/datasets/pull/1510", "merged_at": "2020-12-17T16:06:22Z", "patch_url": "https://github.com/huggingface/datasets/pull/1510.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1510" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/14899066?v=4", "events_url": "https://api.github.com/users/arkhalid/events{/privacy}", "followers_url": "https://api.github.com/users/arkhalid/followers", "following_url": "https://api.github.com/users/arkhalid/following{/other_user}", "gists_url": "https://api.github.com/users/arkhalid/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/arkhalid", "id": 14899066, "login": "arkhalid", "node_id": "MDQ6VXNlcjE0ODk5MDY2", "organizations_url": "https://api.github.com/users/arkhalid/orgs", "received_events_url": "https://api.github.com/users/arkhalid/received_events", "repos_url": "https://api.github.com/users/arkhalid/repos", "site_admin": false, "starred_url": "https://api.github.com/users/arkhalid/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arkhalid/subscriptions", "type": "User", "url": "https://api.github.com/users/arkhalid" }

[]

[]

[ "The only CI error comes from \r\n```\r\nFAILED tests/test_file_utils.py::TempSeedTest::test_tensorflow\r\n```\r\n\r\nwhich is not related to your PR and is fixed on master.\r\n\r\nYou can ignore it", "@lhoestq I've made the changes. Please review and merge. \r\n\r\nI have a similar PR https://github.com/huggingface/datasets/pull/1562 for another dataset. I'll incorporate your comment about sorting and reducing dummy dataset size there.", "The CI raises an error `FAILED tests/test_file_utils.py::TempSeedTest::test_tensorflow` but it's not related to this dataset.\r\nThis issue is fixed on master", "You did all the work ;) thanks\r\n\r\nmerging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1509/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1509.diff", "html_url": "https://github.com/huggingface/datasets/pull/1509", "merged_at": "2020-12-16T15:04:51Z", "patch_url": "https://github.com/huggingface/datasets/pull/1509.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1509" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4", "events_url": "https://api.github.com/users/mariosasko/events{/privacy}", "followers_url": "https://api.github.com/users/mariosasko/followers", "following_url": "https://api.github.com/users/mariosasko/following{/other_user}", "gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mariosasko", "id": 47462742, "login": "mariosasko", "node_id": "MDQ6VXNlcjQ3NDYyNzQy", "organizations_url": "https://api.github.com/users/mariosasko/orgs", "received_events_url": "https://api.github.com/users/mariosasko/received_events", "repos_url": "https://api.github.com/users/mariosasko/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions", "type": "User", "url": "https://api.github.com/users/mariosasko" }

[]

[]

[ "Hii please follow me", "Thanks @mariosasko!" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1508/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1508.diff", "html_url": "https://github.com/huggingface/datasets/pull/1508", "merged_at": "2020-12-15T12:57:48Z", "patch_url": "https://github.com/huggingface/datasets/pull/1508.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1508" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/13381361?v=4", "events_url": "https://api.github.com/users/Bharat123rox/events{/privacy}", "followers_url": "https://api.github.com/users/Bharat123rox/followers", "following_url": "https://api.github.com/users/Bharat123rox/following{/other_user}", "gists_url": "https://api.github.com/users/Bharat123rox/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Bharat123rox", "id": 13381361, "login": "Bharat123rox", "node_id": "MDQ6VXNlcjEzMzgxMzYx", "organizations_url": "https://api.github.com/users/Bharat123rox/orgs", "received_events_url": "https://api.github.com/users/Bharat123rox/received_events", "repos_url": "https://api.github.com/users/Bharat123rox/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Bharat123rox/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Bharat123rox/subscriptions", "type": "User", "url": "https://api.github.com/users/Bharat123rox" }

[]

[]

[ "Hii please follow me", "The CI error `FAILED tests/test_file_utils.py::TempSeedTest::test_tensorflow` is not related with this dataset and is fixed on master. You can ignore it", "merging since the Ci is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1507/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1507.diff", "html_url": "https://github.com/huggingface/datasets/pull/1507", "merged_at": "2020-12-16T16:49:23Z", "patch_url": "https://github.com/huggingface/datasets/pull/1507.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1507" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/28673745?v=4", "events_url": "https://api.github.com/users/Nilanshrajput/events{/privacy}", "followers_url": "https://api.github.com/users/Nilanshrajput/followers", "following_url": "https://api.github.com/users/Nilanshrajput/following{/other_user}", "gists_url": "https://api.github.com/users/Nilanshrajput/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Nilanshrajput", "id": 28673745, "login": "Nilanshrajput", "node_id": "MDQ6VXNlcjI4NjczNzQ1", "organizations_url": "https://api.github.com/users/Nilanshrajput/orgs", "received_events_url": "https://api.github.com/users/Nilanshrajput/received_events", "repos_url": "https://api.github.com/users/Nilanshrajput/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Nilanshrajput/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Nilanshrajput/subscriptions", "type": "User", "url": "https://api.github.com/users/Nilanshrajput" }

[]

[]

[ "@SBrandeis thanks for the review, I applied your suggested changes, but CI is failing now not sure about the error.", "Many thanks @Nilanshrajput !\r\nThe failing tests on CI are not related to your changes, merging master on your branch should fix them :)\r\nIf you're interested in what causes the CI to fail, checkout [this commit](https://github.com/huggingface/datasets/commit/9a0f1e20ca1e783cb14c1ab1cc2f54b0b5b201e8)", "@SBrandeis done!\r\n", "Hello @Nilanshrajput, your PR includes changes from other branches too now (485 files changed)\r\nWould you mind creating another branch from master with your changes and opening a new PR?", "@SBrandeis sorry i messed up the git history, #1587 I opened this new pr! ", "closing in favor of #1587 " ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1506/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1506.diff", "html_url": "https://github.com/huggingface/datasets/pull/1506", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1506.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1506" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/53136577?v=4", "events_url": "https://api.github.com/users/thevasudevgupta/events{/privacy}", "followers_url": "https://api.github.com/users/thevasudevgupta/followers", "following_url": "https://api.github.com/users/thevasudevgupta/following{/other_user}", "gists_url": "https://api.github.com/users/thevasudevgupta/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/thevasudevgupta", "id": 53136577, "login": "thevasudevgupta", "node_id": "MDQ6VXNlcjUzMTM2NTc3", "organizations_url": "https://api.github.com/users/thevasudevgupta/orgs", "received_events_url": "https://api.github.com/users/thevasudevgupta/received_events", "repos_url": "https://api.github.com/users/thevasudevgupta/repos", "site_admin": false, "starred_url": "https://api.github.com/users/thevasudevgupta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thevasudevgupta/subscriptions", "type": "User", "url": "https://api.github.com/users/thevasudevgupta" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1505/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1505.diff", "html_url": "https://github.com/huggingface/datasets/pull/1505", "merged_at": "2020-12-17T15:43:07Z", "patch_url": "https://github.com/huggingface/datasets/pull/1505.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1505" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/24206326?v=4", "events_url": "https://api.github.com/users/harshalmittal4/events{/privacy}", "followers_url": "https://api.github.com/users/harshalmittal4/followers", "following_url": "https://api.github.com/users/harshalmittal4/following{/other_user}", "gists_url": "https://api.github.com/users/harshalmittal4/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/harshalmittal4", "id": 24206326, "login": "harshalmittal4", "node_id": "MDQ6VXNlcjI0MjA2MzI2", "organizations_url": "https://api.github.com/users/harshalmittal4/orgs", "received_events_url": "https://api.github.com/users/harshalmittal4/received_events", "repos_url": "https://api.github.com/users/harshalmittal4/repos", "site_admin": false, "starred_url": "https://api.github.com/users/harshalmittal4/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/harshalmittal4/subscriptions", "type": "User", "url": "https://api.github.com/users/harshalmittal4" }

[]

[]

[ "Hi @lhoestq @yjernite, requesting you to review this for any changes needed. Thanks! :)", "Hi @lhoestq , I have updated the PR" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1504/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1504.diff", "html_url": "https://github.com/huggingface/datasets/pull/1504", "merged_at": "2020-12-15T18:32:38Z", "patch_url": "https://github.com/huggingface/datasets/pull/1504.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1504" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/16264631?v=4", "events_url": "https://api.github.com/users/vrindaprabhu/events{/privacy}", "followers_url": "https://api.github.com/users/vrindaprabhu/followers", "following_url": "https://api.github.com/users/vrindaprabhu/following{/other_user}", "gists_url": "https://api.github.com/users/vrindaprabhu/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/vrindaprabhu", "id": 16264631, "login": "vrindaprabhu", "node_id": "MDQ6VXNlcjE2MjY0NjMx", "organizations_url": "https://api.github.com/users/vrindaprabhu/orgs", "received_events_url": "https://api.github.com/users/vrindaprabhu/received_events", "repos_url": "https://api.github.com/users/vrindaprabhu/repos", "site_admin": false, "starred_url": "https://api.github.com/users/vrindaprabhu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vrindaprabhu/subscriptions", "type": "User", "url": "https://api.github.com/users/vrindaprabhu" }

[]

[]

[ "Changed the pre-processing based on the comments raised in [PR-1482](https://github.com/huggingface/datasets/pull/1482).The below command is passing in my local environment:\r\n\r\n`python datasets-cli test datasets/covid_qa_ucsd/ --save_infos --all_configs --data_dir ~/Downloads/Medical-Dialogue-Dataset/CovidDailogue/`\r\n\r\n" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1503/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1503.diff", "html_url": "https://github.com/huggingface/datasets/pull/1503", "merged_at": "2020-12-17T15:29:26Z", "patch_url": "https://github.com/huggingface/datasets/pull/1503.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1503" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/35491698?v=4", "events_url": "https://api.github.com/users/KMFODA/events{/privacy}", "followers_url": "https://api.github.com/users/KMFODA/followers", "following_url": "https://api.github.com/users/KMFODA/following{/other_user}", "gists_url": "https://api.github.com/users/KMFODA/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/KMFODA", "id": 35491698, "login": "KMFODA", "node_id": "MDQ6VXNlcjM1NDkxNjk4", "organizations_url": "https://api.github.com/users/KMFODA/orgs", "received_events_url": "https://api.github.com/users/KMFODA/received_events", "repos_url": "https://api.github.com/users/KMFODA/repos", "site_admin": false, "starred_url": "https://api.github.com/users/KMFODA/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KMFODA/subscriptions", "type": "User", "url": "https://api.github.com/users/KMFODA" }

[]

[]

[ "Better will be if you close this PR and make a fresh PR", "Feel free to ping me if you also have questions about the dummy data", "also it looks like this PR includes changes about dummy_data.zip files in the ./datasets//un_pc folder. Can you remove them ?", "Thanks for all the advice @lhoestq. I've implemented the changes you kindly highlighted and have made sure the scripts pass all the test. I've also marked this as ready for review as I believe it's in a good place to be merged now.", "Great suggestion I fixed the dummy data and the file paths." ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1502/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1502.diff", "html_url": "https://github.com/huggingface/datasets/pull/1502", "merged_at": "2020-12-28T14:01:12Z", "patch_url": "https://github.com/huggingface/datasets/pull/1502.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1502" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/24206326?v=4", "events_url": "https://api.github.com/users/harshalmittal4/events{/privacy}", "followers_url": "https://api.github.com/users/harshalmittal4/followers", "following_url": "https://api.github.com/users/harshalmittal4/following{/other_user}", "gists_url": "https://api.github.com/users/harshalmittal4/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/harshalmittal4", "id": 24206326, "login": "harshalmittal4", "node_id": "MDQ6VXNlcjI0MjA2MzI2", "organizations_url": "https://api.github.com/users/harshalmittal4/orgs", "received_events_url": "https://api.github.com/users/harshalmittal4/received_events", "repos_url": "https://api.github.com/users/harshalmittal4/repos", "site_admin": false, "starred_url": "https://api.github.com/users/harshalmittal4/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/harshalmittal4/subscriptions", "type": "User", "url": "https://api.github.com/users/harshalmittal4" }

[]

[]

[ "Hi @lhoestq @yjernite, requesting you to review this for any changes needed. Thanks! :)" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1501/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1501.diff", "html_url": "https://github.com/huggingface/datasets/pull/1501", "merged_at": "2020-12-14T21:20:59Z", "patch_url": "https://github.com/huggingface/datasets/pull/1501.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1501" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/15803781?v=4", "events_url": "https://api.github.com/users/kldarek/events{/privacy}", "followers_url": "https://api.github.com/users/kldarek/followers", "following_url": "https://api.github.com/users/kldarek/following{/other_user}", "gists_url": "https://api.github.com/users/kldarek/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kldarek", "id": 15803781, "login": "kldarek", "node_id": "MDQ6VXNlcjE1ODAzNzgx", "organizations_url": "https://api.github.com/users/kldarek/orgs", "received_events_url": "https://api.github.com/users/kldarek/received_events", "repos_url": "https://api.github.com/users/kldarek/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kldarek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kldarek/subscriptions", "type": "User", "url": "https://api.github.com/users/kldarek" }

[]

[]

[ "@lhoestq thanks for the comments! Should be fixed in the latest commit, I assume the CI errors are unrelated." ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1500/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1500.diff", "html_url": "https://github.com/huggingface/datasets/pull/1500", "merged_at": "2020-12-18T09:43:43Z", "patch_url": "https://github.com/huggingface/datasets/pull/1500.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1500" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/7669893?v=4", "events_url": "https://api.github.com/users/cahya-wirawan/events{/privacy}", "followers_url": "https://api.github.com/users/cahya-wirawan/followers", "following_url": "https://api.github.com/users/cahya-wirawan/following{/other_user}", "gists_url": "https://api.github.com/users/cahya-wirawan/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cahya-wirawan", "id": 7669893, "login": "cahya-wirawan", "node_id": "MDQ6VXNlcjc2Njk4OTM=", "organizations_url": "https://api.github.com/users/cahya-wirawan/orgs", "received_events_url": "https://api.github.com/users/cahya-wirawan/received_events", "repos_url": "https://api.github.com/users/cahya-wirawan/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cahya-wirawan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cahya-wirawan/subscriptions", "type": "User", "url": "https://api.github.com/users/cahya-wirawan" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1499/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1499.diff", "html_url": "https://github.com/huggingface/datasets/pull/1499", "merged_at": "2020-12-14T15:28:07Z", "patch_url": "https://github.com/huggingface/datasets/pull/1499.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1499" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/15519308?v=4", "events_url": "https://api.github.com/users/cstorm125/events{/privacy}", "followers_url": "https://api.github.com/users/cstorm125/followers", "following_url": "https://api.github.com/users/cstorm125/following{/other_user}", "gists_url": "https://api.github.com/users/cstorm125/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cstorm125", "id": 15519308, "login": "cstorm125", "node_id": "MDQ6VXNlcjE1NTE5MzA4", "organizations_url": "https://api.github.com/users/cstorm125/orgs", "received_events_url": "https://api.github.com/users/cstorm125/received_events", "repos_url": "https://api.github.com/users/cstorm125/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cstorm125/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cstorm125/subscriptions", "type": "User", "url": "https://api.github.com/users/cstorm125" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1498/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1498.diff", "html_url": "https://github.com/huggingface/datasets/pull/1498", "merged_at": "2020-12-18T10:03:53Z", "patch_url": "https://github.com/huggingface/datasets/pull/1498.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1498" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/MisbahKhan789", "id": 15351802, "login": "MisbahKhan789", "node_id": "MDQ6VXNlcjE1MzUxODAy", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "site_admin": false, "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "type": "User", "url": "https://api.github.com/users/MisbahKhan789" }

[]

[]

[ "made suggested changes and created a PR here: https://github.com/huggingface/datasets/pull/1598" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1497/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1497.diff", "html_url": "https://github.com/huggingface/datasets/pull/1497", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1497.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1497" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/10469459?v=4", "events_url": "https://api.github.com/users/yjernite/events{/privacy}", "followers_url": "https://api.github.com/users/yjernite/followers", "following_url": "https://api.github.com/users/yjernite/following{/other_user}", "gists_url": "https://api.github.com/users/yjernite/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/yjernite", "id": 10469459, "login": "yjernite", "node_id": "MDQ6VXNlcjEwNDY5NDU5", "organizations_url": "https://api.github.com/users/yjernite/orgs", "received_events_url": "https://api.github.com/users/yjernite/received_events", "repos_url": "https://api.github.com/users/yjernite/repos", "site_admin": false, "starred_url": "https://api.github.com/users/yjernite/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yjernite/subscriptions", "type": "User", "url": "https://api.github.com/users/yjernite" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1496/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1496.diff", "html_url": "https://github.com/huggingface/datasets/pull/1496", "merged_at": "2020-12-14T21:14:55Z", "patch_url": "https://github.com/huggingface/datasets/pull/1496.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1496" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rkc007", "id": 22396042, "login": "rkc007", "node_id": "MDQ6VXNlcjIyMzk2MDQy", "organizations_url": "https://api.github.com/users/rkc007/orgs", "received_events_url": "https://api.github.com/users/rkc007/received_events", "repos_url": "https://api.github.com/users/rkc007/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "type": "User", "url": "https://api.github.com/users/rkc007" }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1495/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1495.diff", "html_url": "https://github.com/huggingface/datasets/pull/1495", "merged_at": "2020-12-17T14:38:41Z", "patch_url": "https://github.com/huggingface/datasets/pull/1495.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1495" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rkc007", "id": 22396042, "login": "rkc007", "node_id": "MDQ6VXNlcjIyMzk2MDQy", "organizations_url": "https://api.github.com/users/rkc007/orgs", "received_events_url": "https://api.github.com/users/rkc007/received_events", "repos_url": "https://api.github.com/users/rkc007/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "type": "User", "url": "https://api.github.com/users/rkc007" }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1494/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1494.diff", "html_url": "https://github.com/huggingface/datasets/pull/1494", "merged_at": "2020-12-17T14:38:28Z", "patch_url": "https://github.com/huggingface/datasets/pull/1494.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1494" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/2815308?v=4", "events_url": "https://api.github.com/users/iliemihai/events{/privacy}", "followers_url": "https://api.github.com/users/iliemihai/followers", "following_url": "https://api.github.com/users/iliemihai/following{/other_user}", "gists_url": "https://api.github.com/users/iliemihai/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/iliemihai", "id": 2815308, "login": "iliemihai", "node_id": "MDQ6VXNlcjI4MTUzMDg=", "organizations_url": "https://api.github.com/users/iliemihai/orgs", "received_events_url": "https://api.github.com/users/iliemihai/received_events", "repos_url": "https://api.github.com/users/iliemihai/repos", "site_admin": false, "starred_url": "https://api.github.com/users/iliemihai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iliemihai/subscriptions", "type": "User", "url": "https://api.github.com/users/iliemihai" }

[]

[]

[ "Thanks for the PR @iliemihai . \r\n\r\nFew comments - \r\n\r\nCan you run - \r\n`python datasets-cli dummy_data ./datasets/ronec --auto_generate` to generate dummy data.\r\n\r\nAlso, before committing files run : \r\n`make style`\r\n`flake8 datasets`\r\nthen you can add and commit files.", "> Thanks for the PR @iliemihai .\r\n> \r\n> Few comments -\r\n> \r\n> Can you run -\r\n> `python datasets-cli dummy_data ./datasets/ronec --auto_generate` to generate dummy data.\r\n> \r\n> Also, before committing files run :\r\n> `make style`\r\n> `flake8 datasets`\r\n> then you can add and commit files.\r\n\r\nSorry, forgot to generate dummy data. I will do it now :D", "Awesome, good job @iliemihai !\r\nI think the PR is ready to merge.\r\n@lhoestq would you mind double-checking this ?", "Had to regenerate the dummy data since I just found out they were empty files" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1493/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1493.diff", "html_url": "https://github.com/huggingface/datasets/pull/1493", "merged_at": "2020-12-21T14:48:56Z", "patch_url": "https://github.com/huggingface/datasets/pull/1493.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1493" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rkc007", "id": 22396042, "login": "rkc007", "node_id": "MDQ6VXNlcjIyMzk2MDQy", "organizations_url": "https://api.github.com/users/rkc007/orgs", "received_events_url": "https://api.github.com/users/rkc007/received_events", "repos_url": "https://api.github.com/users/rkc007/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "type": "User", "url": "https://api.github.com/users/rkc007" }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1492/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1492.diff", "html_url": "https://github.com/huggingface/datasets/pull/1492", "merged_at": "2020-12-17T14:38:15Z", "patch_url": "https://github.com/huggingface/datasets/pull/1492.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1492" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rkc007", "id": 22396042, "login": "rkc007", "node_id": "MDQ6VXNlcjIyMzk2MDQy", "organizations_url": "https://api.github.com/users/rkc007/orgs", "received_events_url": "https://api.github.com/users/rkc007/received_events", "repos_url": "https://api.github.com/users/rkc007/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "type": "User", "url": "https://api.github.com/users/rkc007" }

[]

[]

[ "merging since the Ci is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1491/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1491.diff", "html_url": "https://github.com/huggingface/datasets/pull/1491", "merged_at": "2020-12-17T14:20:23Z", "patch_url": "https://github.com/huggingface/datasets/pull/1491.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1491" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/29649801?v=4", "events_url": "https://api.github.com/users/akshayb7/events{/privacy}", "followers_url": "https://api.github.com/users/akshayb7/followers", "following_url": "https://api.github.com/users/akshayb7/following{/other_user}", "gists_url": "https://api.github.com/users/akshayb7/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/akshayb7", "id": 29649801, "login": "akshayb7", "node_id": "MDQ6VXNlcjI5NjQ5ODAx", "organizations_url": "https://api.github.com/users/akshayb7/orgs", "received_events_url": "https://api.github.com/users/akshayb7/received_events", "repos_url": "https://api.github.com/users/akshayb7/repos", "site_admin": false, "starred_url": "https://api.github.com/users/akshayb7/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akshayb7/subscriptions", "type": "User", "url": "https://api.github.com/users/akshayb7" }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1490/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1490.diff", "html_url": "https://github.com/huggingface/datasets/pull/1490", "merged_at": "2020-12-13T19:12:24Z", "patch_url": "https://github.com/huggingface/datasets/pull/1490.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1490" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/15351802?v=4", "events_url": "https://api.github.com/users/MisbahKhan789/events{/privacy}", "followers_url": "https://api.github.com/users/MisbahKhan789/followers", "following_url": "https://api.github.com/users/MisbahKhan789/following{/other_user}", "gists_url": "https://api.github.com/users/MisbahKhan789/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/MisbahKhan789", "id": 15351802, "login": "MisbahKhan789", "node_id": "MDQ6VXNlcjE1MzUxODAy", "organizations_url": "https://api.github.com/users/MisbahKhan789/orgs", "received_events_url": "https://api.github.com/users/MisbahKhan789/received_events", "repos_url": "https://api.github.com/users/MisbahKhan789/repos", "site_admin": false, "starred_url": "https://api.github.com/users/MisbahKhan789/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MisbahKhan789/subscriptions", "type": "User", "url": "https://api.github.com/users/MisbahKhan789" }

[]

[]

[ "Thanks for the PR @MisbahKhan789 !\r\n\r\nFew comments to help you along (I'm NOT a maintainer, just offering help to unblock the process) :-\r\n - Could you re-run `make style` and fix the errors related to code quality specific to your dataset in the `datasets/fake_news_english` folder?\r\n(These seem to show errors that need manual fixes on running `flake8 datasets/fake_news_english`)\r\n- Please run the local tests and check if they pass\r\n`RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_<your-dataset-name>`\r\n `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<your-dataset-name>`\r\n(If not, you may have to regenerate the dummy data and the `dataset_infos.json` files)\r\n\r\n", "Hii please follow me", "> Thanks for the PR @MisbahKhan789 !\r\n> \r\n> Few comments to help you along (I'm NOT a maintainer, just offering help to unblock the process) :-\r\n> \r\n> * Could you re-run `make style` and fix the errors related to code quality specific to your dataset in the `datasets/fake_news_english` folder?\r\n> (These seem to show errors that need manual fixes on running `flake8 datasets/fake_news_english`)\r\n> * Please run the local tests and check if they pass\r\n> `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_<your-dataset-name>`\r\n> `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<your-dataset-name>`\r\n> (If not, you may have to regenerate the dummy data and the `dataset_infos.json` files)\r\n\r\nHey Bharat, thanks for the reply. I actually submitted a new PR with the changes that are required :)\r\n" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1489/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1489.diff", "html_url": "https://github.com/huggingface/datasets/pull/1489", "merged_at": null, "patch_url": "https://github.com/huggingface/datasets/pull/1489.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1489" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/8900094?v=4", "events_url": "https://api.github.com/users/ontocord/events{/privacy}", "followers_url": "https://api.github.com/users/ontocord/followers", "following_url": "https://api.github.com/users/ontocord/following{/other_user}", "gists_url": "https://api.github.com/users/ontocord/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ontocord", "id": 8900094, "login": "ontocord", "node_id": "MDQ6VXNlcjg5MDAwOTQ=", "organizations_url": "https://api.github.com/users/ontocord/orgs", "received_events_url": "https://api.github.com/users/ontocord/received_events", "repos_url": "https://api.github.com/users/ontocord/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ontocord/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ontocord/subscriptions", "type": "User", "url": "https://api.github.com/users/ontocord" }

[]

[]

[ "hi @lhoestq, I wanted to push another change to this branch b/c I found a bug in the parsing. I need to swap arg1 and arg2. I tried to git push -u origin nell but it didn't work. So I tried to do git push --force -u origin nell which seems to work, but nothing is happening to this branch. I think this is because it's closed. Do I need to open another PR?\r\n\r\nThe change should be below in _generate_examples:\r\n best_arg1 = row[9]\r\n best_arg2 = row[8]\r\n", "Hi @ontocord !\r\n\r\nYup the easiest thing to do is to open a new PR with a title like \"Fix NELL dataset argument order\". If it's a simple fix we can look at it pretty fast :) " ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1488/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1488.diff", "html_url": "https://github.com/huggingface/datasets/pull/1488", "merged_at": "2020-12-21T14:44:59Z", "patch_url": "https://github.com/huggingface/datasets/pull/1488.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1488" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rkc007", "id": 22396042, "login": "rkc007", "node_id": "MDQ6VXNlcjIyMzk2MDQy", "organizations_url": "https://api.github.com/users/rkc007/orgs", "received_events_url": "https://api.github.com/users/rkc007/received_events", "repos_url": "https://api.github.com/users/rkc007/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "type": "User", "url": "https://api.github.com/users/rkc007" }

[]

[]

[ "@lhoestq Thank you for suggesting changes. I fixed all the changes you suggested. Can you please review it again? ", "@lhoestq Thank you for reviewing and suggesting changes. I made the requested changes. Can you please review it again?", "Thanks @lhoestq for reviewing it again. I made the required changes. Can you please have a look ?", "merging since the CI is fixed on master" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1487/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1487.diff", "html_url": "https://github.com/huggingface/datasets/pull/1487", "merged_at": "2020-12-28T09:38:39Z", "patch_url": "https://github.com/huggingface/datasets/pull/1487.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1487" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/75574105?v=4", "events_url": "https://api.github.com/users/czabo/events{/privacy}", "followers_url": "https://api.github.com/users/czabo/followers", "following_url": "https://api.github.com/users/czabo/following{/other_user}", "gists_url": "https://api.github.com/users/czabo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/czabo", "id": 75574105, "login": "czabo", "node_id": "MDQ6VXNlcjc1NTc0MTA1", "organizations_url": "https://api.github.com/users/czabo/orgs", "received_events_url": "https://api.github.com/users/czabo/received_events", "repos_url": "https://api.github.com/users/czabo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/czabo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/czabo/subscriptions", "type": "User", "url": "https://api.github.com/users/czabo" }

[]

[]

[ "The error `tests/test_file_utils.py::TempSeedTest::test_tensorflow` just appeared because of tensorflow's update.\r\nOnce it's fixed on master we'll be free to merge this one", "It's fixed on master now :) \r\n\r\nmerging this once" ]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1486/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1486.diff", "html_url": "https://github.com/huggingface/datasets/pull/1486", "merged_at": "2020-12-14T19:43:18Z", "patch_url": "https://github.com/huggingface/datasets/pull/1486.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1486" }

{ "avatar_url": "https://avatars.githubusercontent.com/u/53267795?v=4", "events_url": "https://api.github.com/users/aclifton314/events{/privacy}", "followers_url": "https://api.github.com/users/aclifton314/followers", "following_url": "https://api.github.com/users/aclifton314/following{/other_user}", "gists_url": "https://api.github.com/users/aclifton314/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/aclifton314", "id": 53267795, "login": "aclifton314", "node_id": "MDQ6VXNlcjUzMjY3Nzk1", "organizations_url": "https://api.github.com/users/aclifton314/orgs", "received_events_url": "https://api.github.com/users/aclifton314/received_events", "repos_url": "https://api.github.com/users/aclifton314/repos", "site_admin": false, "starred_url": "https://api.github.com/users/aclifton314/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aclifton314/subscriptions", "type": "User", "url": "https://api.github.com/users/aclifton314" }

[]

[]

[]

{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/huggingface/datasets/issues/1485/reactions" }

{ "diff_url": "https://github.com/huggingface/datasets/pull/1485.diff", "html_url": "https://github.com/huggingface/datasets/pull/1485", "merged_at": "2020-12-14T14:08:22Z", "patch_url": "https://github.com/huggingface/datasets/pull/1485.patch", "url": "https://api.github.com/repos/huggingface/datasets/pulls/1485" }