input
stringlengths
205
73.3k
output
stringlengths
64
73.2k
instruction
stringclasses
1 value
#vulnerable code private static List<String> getWorldGuardRegionNames(User user) { Location location = user.getPlayer().getLocation(); if (location != null) { List<String> regionNames = WorldGuardHook.getRegionNames(location); if (regionNames != null && !regionNames.isEmpty()) { return regionNames; } } return null; } #location 2 #vulnerability type NULL_DEREFERENCE
#fixed code private static List<String> getWorldGuardRegionNames(User user) { if (user == null || user.getPlayer() == null) { return Collections.emptyList(); } Location location = user.getPlayer().getLocation(); if (location != null) { List<String> regionNames = WorldGuardHook.getRegionNames(location); if (regionNames != null && !regionNames.isEmpty()) { return regionNames; } } return null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); if (args.length < 1) { sender.sendMessage(messages.generalNoTagGiven); return; } else if (args.length < 2) { sender.sendMessage(messages.adminNoBanTimeGiven); return; } else if (args.length < 3) { sender.sendMessage(messages.adminNoReasonGiven); return; } if (!GuildUtils.tagExists(args[0])) { sender.sendMessage(messages.generalNoGuildFound); return; } Guild guild = GuildUtils.byTag(args[0]); if (guild.isBanned()) { sender.sendMessage(messages.adminGuildBanned); return; } long time = Parser.parseTime(args[1]); if (time < 1) { sender.sendMessage(messages.adminTimeError); return; } StringBuilder sb = new StringBuilder(); for (int i = 2; i < args.length; i++) { sb.append(args[i]); sb.append(" "); } String reason = sb.toString(); BanUtils.ban(guild, time, reason); sender.sendMessage(messages.adminGuildBan.replace("{GUILD}", guild.getName()).replace("{TIME}", args[1])); Bukkit.broadcastMessage(Messages.getInstance().broadcastBan.replace("{GUILD}", guild.getName()) .replace("{TAG}", guild.getTag()).replace("{REASON}", StringUtils.colored(reason)).replace("{TIME}", args[1])); } #location 22 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); if (args.length < 1) { sender.sendMessage(messages.generalNoTagGiven); return; } else if (args.length < 2) { sender.sendMessage(messages.adminNoBanTimeGiven); return; } else if (args.length < 3) { sender.sendMessage(messages.adminNoReasonGiven); return; } Guild guild = GuildUtils.get(args[0]); if (guild == null) { sender.sendMessage(messages.generalNoGuildFound); return; } if (guild.isBanned()) { sender.sendMessage(messages.adminGuildBanned); return; } long time = Parser.parseTime(args[1]); if (time < 1) { sender.sendMessage(messages.adminTimeError); return; } StringBuilder reasonBuilder = new StringBuilder(); for (int i = 2; i < args.length; i++) { reasonBuilder.append(args[i]); reasonBuilder.append(" "); } String reason = reasonBuilder.toString(); BanUtils.ban(guild, time, reason); MessageTranslator translator = new MessageTranslator() .register("{GUILD", guild.getName()) .register("{TAG}", guild.getTag()) .register("{TIME}", args[1]) .register("{REASON}", StringUtils.colored(reason)); sender.sendMessage(translator.translate(messages.adminGuildBan)); Bukkit.broadcastMessage(translator.translate(messages.broadcastBan)); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void remove(User user) { this.users.remove(user.getRank()); synchronized (users) { Collections.sort(this.users); } } #location 2 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code public void remove(User user) { this.users.remove(user.getRank()); Collections.sort(this.users); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig m = Messages.getInstance(); Player p = (Player) sender; User u = User.get(p); if (!u.hasGuild()) { p.sendMessage(m.kickHasNotGuild); return; } if (!u.isOwner() && !u.isDeputy()) { p.sendMessage(m.kickIsNotOwner); return; } if (args.length < 1) { p.sendMessage(m.kickPlayer); return; } User uk = User.get(args[0]); OfflineUser up = uk.getOfflineUser(); if (!uk.hasGuild()) { p.sendMessage(m.kickToHasNotGuild); return; } if (!u.getGuild().equals(uk.getGuild())) { p.sendMessage(m.kickOtherGuild); return; } if (uk.isOwner()) { p.sendMessage(m.kickOwner); return; } Guild guild = u.getGuild(); IndependentThread.action(ActionType.PREFIX_GLOBAL_REMOVE_PLAYER, up); guild.removeMember(uk); uk.removeGuild(); if (up.isOnline()) { IndependentThread.action(ActionType.PREFIX_GLOBAL_UPDATE_PLAYER, p); } p.sendMessage(m.kickToOwner.replace("{PLAYER}", uk.getName())); Player pk = uk.getPlayer(); if (pk != null) { pk.sendMessage(m.kickToPlayer.replace("{GUILD}", guild.getName())); } Bukkit.broadcastMessage(m.broadcastKick.replace("{PLAYER}", uk.getName()).replace("{GUILD}", guild.getName()).replace("{TAG}", guild.getTag())); } #location 8 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; User user = User.get(player); if (!user.hasGuild()) { player.sendMessage(messages.kickHasNotGuild); return; } if (!user.isOwner() && !user.isDeputy()) { player.sendMessage(messages.kickIsNotOwner); return; } if (args.length < 1) { player.sendMessage(messages.kickPlayer); return; } User formerUser = User.get(args[0]); OfflineUser formerOffline = formerUser.getOfflineUser(); if (!formerUser.hasGuild()) { player.sendMessage(messages.kickToHasNotGuild); return; } if (!user.getGuild().equals(formerUser.getGuild())) { player.sendMessage(messages.kickOtherGuild); return; } if (formerUser.isOwner()) { player.sendMessage(messages.kickOwner); return; } Guild guild = user.getGuild(); IndependentThread.action(ActionType.PREFIX_GLOBAL_REMOVE_PLAYER, formerOffline); guild.removeMember(formerUser); formerUser.removeGuild(); if (formerOffline.isOnline()) { IndependentThread.action(ActionType.PREFIX_GLOBAL_UPDATE_PLAYER, player); } MessageTranslator translator = new MessageTranslator() .register("{PLAYER}", formerUser.getName()) .register("{GUILD}", guild.getName()) .register("{TAG}", guild.getTag()); player.sendMessage(translator.translate(messages.kickToOwner)); Bukkit.broadcastMessage(translator.translate(messages.broadcastKick)); Player formerPlayer = formerUser.getPlayer(); if (formerPlayer != null) { formerPlayer.sendMessage(translator.translate(messages.kickToPlayer)); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig m = Messages.getInstance(); User user = User.get((Player) sender); if (user.isSpy()) { user.setSpy(false); sender.sendMessage(m.adminStopSpy); } else { user.setSpy(true); sender.sendMessage(m.adminStartSpy); } } #location 11 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); User user = User.get((Player) sender); if (user.isSpy()) { user.setSpy(false); sender.sendMessage(messages.adminStopSpy); } else { user.setSpy(true); sender.sendMessage(messages.adminStartSpy); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static List<String> getRegionNames(Location location) { if (!isInRegion(location)) { return null; } List<String> regionNames = new ArrayList<>(); getRegionSet(location).getRegions().forEach(r -> regionNames.add(r.getId())); return regionNames; } #location 7 #vulnerability type NULL_DEREFERENCE
#fixed code public static List<String> getRegionNames(Location location) { ApplicableRegionSet regionSet = getRegionSet(location); return regionSet != null ? regionSet.getRegions().stream().map(ProtectedRegion::getId) .collect(Collectors.toList()) : null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void remove(Guild guild) { this.guilds.remove(guild.getRank()); synchronized (guilds) { Collections.sort(this.guilds); } } #location 2 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code public void remove(Guild guild) { this.guilds.remove(guild.getRank()); Collections.sort(this.guilds); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @EventHandler public void onDamage(EntityDamageByEntityEvent event) { Entity entity = event.getEntity(); Entity damager = event.getDamager(); if (! (entity instanceof Player)) { return; } Player attacker = null; if (damager instanceof Player) { attacker = (Player) damager; } else if (damager instanceof Projectile) { ProjectileSource shooter = ((Projectile) damager).getShooter(); if (shooter instanceof Player) { attacker = (Player) shooter; } } if (attacker == null) { return; } PluginConfiguration config = FunnyGuilds.getInstance().getPluginConfiguration(); User victimUser = User.get((Player) event.getEntity()); User attackerUser = User.get(attacker); if (victimUser.hasGuild() && attackerUser.hasGuild()) { if (victimUser.getUUID().equals(attackerUser.getUUID())) { return; } if (victimUser.getGuild().equals(attackerUser.getGuild())) { if (!victimUser.getGuild().getPvP()) { event.setCancelled(true); return; } } if (victimUser.getGuild().getAllies().contains(attackerUser.getGuild())) { if (!config.damageAlly) { event.setCancelled(true); return; } if (! (attackerUser.getGuild().getPvP(victimUser.getGuild()) && victimUser.getGuild().getPvP(attackerUser.getGuild()))) { event.setCancelled(true); return; } } } if (attacker.equals(entity)) { return; } if (config.assistEnable && !event.isCancelled()) { if (PluginHook.isPresent(PluginHook.PLUGIN_WORLDGUARD) && PluginHook.WORLD_GUARD.isInIgnoredRegion(entity.getLocation())) { return; } victimUser.getCache().addDamage(attackerUser, event.getDamage()); } } #location 65 #vulnerability type NULL_DEREFERENCE
#fixed code @EventHandler public void onDamage(EntityDamageByEntityEvent event) { EntityUtils.getAttacker(event.getDamager()).peek(attacker -> { PluginConfiguration config = FunnyGuilds.getInstance().getPluginConfiguration(); User attackerUser = User.get(attacker); Entity victim = event.getEntity(); if (config.animalsProtection && (victim instanceof Animals || victim instanceof Villager)) { RegionUtils.getAtOpt(victim.getLocation()) .map(Region::getGuild) .filterNot(guild -> guild.equals(attackerUser.getGuild())) .peek(guild -> event.setCancelled(true)); return; } if (!(victim instanceof Player)) { return; } User victimUser = User.get((Player) event.getEntity()); if (victimUser.hasGuild() && attackerUser.hasGuild()) { if (victimUser.getUUID().equals(attackerUser.getUUID())) { return; } if (victimUser.getGuild().equals(attackerUser.getGuild())) { if (!victimUser.getGuild().getPvP()) { event.setCancelled(true); return; } } if (victimUser.getGuild().getAllies().contains(attackerUser.getGuild())) { if (!config.damageAlly) { event.setCancelled(true); return; } if (! (attackerUser.getGuild().getPvP(victimUser.getGuild()) && victimUser.getGuild().getPvP(attackerUser.getGuild()))) { event.setCancelled(true); return; } } } if (attacker.equals(victim)) { return; } if (config.assistEnable && !event.isCancelled()) { if (PluginHook.isPresent(PluginHook.PLUGIN_WORLDGUARD) && PluginHook.WORLD_GUARD.isInIgnoredRegion(victim.getLocation())) { return; } victimUser.getCache().addDamage(attackerUser, event.getDamage()); } }); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { PluginConfig pc = Settings.getConfig(); MessagesConfig m = Messages.getInstance(); Player p = (Player) sender; User user = User.get(p); Guild guild = user.getGuild(); if (!user.hasGuild()) { p.sendMessage(m.validityHasNotGuild); return; } if (!user.isOwner() && !user.isDeputy()) { p.sendMessage(m.validityIsNotOwner); return; } if (pc.validityWhen != 0) { long c = guild.getValidity(); long d = c - System.currentTimeMillis(); if (d > pc.validityWhen) { long when = d - pc.validityWhen; p.sendMessage(m.validityWhen.replace("{TIME}", TimeUtils.getDurationBreakdown(when))); return; } } List<ItemStack> itemsList = pc.validityItems; for (ItemStack itemStack : itemsList) { if (!p.getInventory().containsAtLeast(itemStack, itemStack.getAmount())) { String msg = m.validityItems; if (msg.contains("{ITEM}")) { StringBuilder sb = new StringBuilder(); sb.append(itemStack.getAmount()); sb.append(" "); sb.append(itemStack.getType().toString().toLowerCase()); msg = msg.replace("{ITEM}", sb.toString()); } if (msg.contains("{ITEMS}")) { ArrayList<String> list = new ArrayList<String>(); for (ItemStack it : itemsList) { StringBuilder sb = new StringBuilder(); sb.append(it.getAmount()); sb.append(" "); sb.append(it.getType().toString().toLowerCase()); list.add(sb.toString()); } msg = msg.replace("{ITEMS}", StringUtils.toString(list, true)); } p.sendMessage(msg); return; } p.getInventory().removeItem(itemStack); } long c = guild.getValidity(); if (c == 0) { c = System.currentTimeMillis(); } c += pc.validityTime; guild.setValidity(c); p.sendMessage(m.validityDone.replace("{DATE}", pc.dateFormat.format(new Date(c)))); } #location 15 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { PluginConfig config = Settings.getConfig(); MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; User user = User.get(player); Guild guild = user.getGuild(); if (!user.hasGuild()) { player.sendMessage(messages.validityHasNotGuild); return; } if (!user.isOwner() && !user.isDeputy()) { player.sendMessage(messages.validityIsNotOwner); return; } if (config.validityWhen != 0) { long c = guild.getValidity(); long d = c - System.currentTimeMillis(); if (d > config.validityWhen) { long when = d - config.validityWhen; player.sendMessage(messages.validityWhen.replace("{TIME}", TimeUtils.getDurationBreakdown(when))); return; } } List<ItemStack> itemsList = config.validityItems; for (ItemStack itemStack : itemsList) { if (!player.getInventory().containsAtLeast(itemStack, itemStack.getAmount())) { String msg = messages.validityItems; if (msg.contains("{ITEM}")) { StringBuilder sb = new StringBuilder(); sb.append(itemStack.getAmount()); sb.append(" "); sb.append(itemStack.getType().toString().toLowerCase()); msg = msg.replace("{ITEM}", sb.toString()); } if (msg.contains("{ITEMS}")) { ArrayList<String> list = new ArrayList<String>(); for (ItemStack it : itemsList) { StringBuilder sb = new StringBuilder(); sb.append(it.getAmount()); sb.append(" "); sb.append(it.getType().toString().toLowerCase()); list.add(sb.toString()); } msg = msg.replace("{ITEMS}", StringUtils.toString(list, true)); } player.sendMessage(msg); return; } player.getInventory().removeItem(itemStack); } long c = guild.getValidity(); if (c == 0) { c = System.currentTimeMillis(); } c += config.validityTime; guild.setValidity(c); player.sendMessage(messages.validityDone.replace("{DATE}", config.dateFormat.format(new Date(c)))); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { PluginConfig c = Settings.getConfig(); MessagesConfig m = Messages.getInstance(); Player p = (Player) sender; User user = User.get(p); if (!c.baseEnable) { p.sendMessage(m.baseTeleportationDisabled); return; } if (!user.hasGuild()) { p.sendMessage(m.baseHasNotGuild); return; } Guild guild = user.getGuild(); if (user.getTeleportation() != null) { p.sendMessage(m.baseIsTeleportation); return; } ItemStack[] items = Settings.getConfig().baseItems.toArray(new ItemStack[0]); for (ItemStack is : items) { if (!p.getInventory().containsAtLeast(is, is.getAmount())) { String msg = m.baseItems; if (msg.contains("{ITEM}")) { StringBuilder sb = new StringBuilder(); sb.append(is.getAmount()); sb.append(" "); sb.append(is.getType().toString().toLowerCase()); msg = msg.replace("{ITEM}", sb.toString()); } if (msg.contains("{ITEMS}")) { ArrayList<String> list = new ArrayList<String>(); for (ItemStack it : items) { StringBuilder sb = new StringBuilder(); sb.append(it.getAmount()); sb.append(" "); sb.append(it.getType().toString().toLowerCase()); list.add(sb.toString()); } msg = msg.replace("{ITEMS}", StringUtils.toString(list, true)); } p.sendMessage(msg); return; } } p.getInventory().removeItem(items); int time = Settings.getConfig().baseDelay; if (time < 1) { p.teleport(guild.getHome()); p.sendMessage(m.baseTeleport); return; } p.sendMessage(m.baseDontMove.replace("{TIME}", Integer.toString(time))); Location before = p.getLocation(); AtomicInteger i = new AtomicInteger(1); user.setTeleportation(Bukkit.getScheduler().runTaskTimer(FunnyGuilds.getInstance(), () -> { if (!p.isOnline()) { user.getTeleportation().cancel(); user.setTeleportation(null); return; } if (!LocationUtils.equals(p.getLocation(), before)) { user.getTeleportation().cancel(); p.sendMessage(m.baseMove); user.setTeleportation(null); p.getInventory().addItem(items); return; } if (i.getAndIncrement() > time) { user.getTeleportation().cancel(); p.sendMessage(m.baseTeleport); p.teleport(guild.getHome()); user.setTeleportation(null); } }, 0L, 20L)); } #location 14 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { PluginConfig config = Settings.getConfig(); MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; User user = User.get(player); if (!config.baseEnable) { player.sendMessage(messages.baseTeleportationDisabled); return; } if (!user.hasGuild()) { player.sendMessage(messages.baseHasNotGuild); return; } Guild guild = user.getGuild(); if (user.getTeleportation() != null) { player.sendMessage(messages.baseIsTeleportation); return; } ItemStack[] items = Settings.getConfig().baseItems.toArray(new ItemStack[0]); for (ItemStack is : items) { if (!player.getInventory().containsAtLeast(is, is.getAmount())) { String msg = messages.baseItems; if (msg.contains("{ITEM}")) { StringBuilder sb = new StringBuilder(); sb.append(is.getAmount()); sb.append(" "); sb.append(is.getType().toString().toLowerCase()); msg = msg.replace("{ITEM}", sb.toString()); } if (msg.contains("{ITEMS}")) { ArrayList<String> list = new ArrayList<String>(); for (ItemStack it : items) { StringBuilder sb = new StringBuilder(); sb.append(it.getAmount()); sb.append(" "); sb.append(it.getType().toString().toLowerCase()); list.add(sb.toString()); } msg = msg.replace("{ITEMS}", StringUtils.toString(list, true)); } player.sendMessage(msg); return; } } player.getInventory().removeItem(items); int time = Settings.getConfig().baseDelay; if (time < 1) { player.teleport(guild.getHome()); player.sendMessage(messages.baseTeleport); return; } player.sendMessage(messages.baseDontMove.replace("{TIME}", Integer.toString(time))); Location before = player.getLocation(); AtomicInteger i = new AtomicInteger(1); user.setTeleportation(Bukkit.getScheduler().runTaskTimer(FunnyGuilds.getInstance(), () -> { if (!player.isOnline()) { user.getTeleportation().cancel(); user.setTeleportation(null); return; } if (!LocationUtils.equals(player.getLocation(), before)) { user.getTeleportation().cancel(); player.sendMessage(messages.baseMove); user.setTeleportation(null); player.getInventory().addItem(items); return; } if (i.getAndIncrement() > time) { user.getTeleportation().cancel(); player.sendMessage(messages.baseTeleport); player.teleport(guild.getHome()); user.setTeleportation(null); } }, 0L, 20L)); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; if (args.length < 1) { player.sendMessage(messages.generalNoTagGiven); return; } if (!GuildUtils.tagExists(args[0])) { player.sendMessage(messages.generalNoGuildFound); return; } Region region = RegionUtils.get(GuildUtils.byTag(args[0]).getRegion()); if (region == null || region.getCenter() == null) { player.sendMessage(messages.adminNoRegionFound); return; } player.sendMessage(messages.baseTeleport); player.teleport(region.getCenter()); } #location 16 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; if (args.length < 1) { player.sendMessage(messages.generalNoTagGiven); return; } Guild guild = GuildUtils.byTag(args[0]); if (guild == null) { player.sendMessage(messages.generalNoGuildFound); return; } Region region = RegionUtils.get(guild.getRegion()); if (region == null || region.getCenter() == null) { player.sendMessage(messages.adminNoRegionFound); return; } player.sendMessage(messages.baseTeleport); player.teleport(region.getCenter()); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void update(Guild guild) { if (!this.guilds.contains(guild.getRank())) { this.guilds.add(guild.getRank()); } else { synchronized (guilds) { Collections.sort(guilds); } for (int i = 0; i < guilds.size(); i++) { Rank rank = guilds.get(i); rank.setPosition(i + 1); } } } #location 11 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code public void update(Guild guild) { if (! this.guilds.contains(guild.getRank())) { this.guilds.add(guild.getRank()); } Collections.sort(guilds); for (int i = 0; i < guilds.size(); i++) { Rank rank = guilds.get(i); rank.setPosition(i + 1); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; if (args.length < 1) { player.sendMessage(messages.generalNoTagGiven); return; } if (!GuildUtils.tagExists(args[0])) { player.sendMessage(messages.generalNoGuildFound); return; } PluginConfig config = Settings.getConfig(); Location location = player.getLocation(); if (config.createCenterY != 0) { location.setY(config.createCenterY); } int d = config.regionSize + config.createDistance; if (config.enlargeItems != null) { d = config.enlargeItems.size() * config.enlargeSize + d; } if (d > player.getWorld().getSpawnLocation().distance(location)) { player.sendMessage(messages.createSpawn.replace("{DISTANCE}", Integer.toString(d))); return; } if (RegionUtils.isNear(location)) { player.sendMessage(messages.createIsNear); return; } Guild guild = GuildUtils.byTag(args[0]); Region region = RegionUtils.get(guild.getRegion()); if (region == null) { region = new Region(guild, location, config.regionSize); } else { if (config.createStringMaterial.equalsIgnoreCase("ender crystal")) { EntityUtil.despawn(guild); } else { Block block = region.getCenter().getBlock().getRelative(BlockFace.DOWN); if (block.getLocation().getBlockY() > 1) { block.setType(Material.AIR); } } region.setCenter(location); } if (config.createCenterSphere) { List<Location> sphere = SpaceUtils.sphere(location, 3, 3, false, true, 0); for (Location l : sphere) { if (l.getBlock().getType() != Material.BEDROCK) { l.getBlock().setType(Material.AIR); } } } if (config.createMaterial != null && config.createMaterial != Material.AIR) { location.getBlock().getRelative(BlockFace.DOWN).setType(config.createMaterial); } else if (config.createStringMaterial.equalsIgnoreCase("ender crystal")) { EntityUtil.spawn(guild); } player.sendMessage(messages.adminGuildRelocated.replace("{GUILD}", guild.getName())); } #location 38 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); PluginConfig config = Settings.getConfig(); Player player = (Player) sender; if (args.length < 1) { player.sendMessage(messages.generalNoTagGiven); return; } Guild guild = GuildUtils.byTag(args[0]); if (guild == null) { player.sendMessage(messages.generalNoGuildFound); return; } Location location = player.getLocation(); if (config.createCenterY != 0) { location.setY(config.createCenterY); } int d = config.regionSize + config.createDistance; if (config.enlargeItems != null) { d = config.enlargeItems.size() * config.enlargeSize + d; } if (d > player.getWorld().getSpawnLocation().distance(location)) { player.sendMessage(messages.createSpawn.replace("{DISTANCE}", Integer.toString(d))); return; } if (RegionUtils.isNear(location)) { player.sendMessage(messages.createIsNear); return; } Region region = RegionUtils.get(guild.getRegion()); if (region == null) { region = new Region(guild, location, config.regionSize); } else { if (config.createStringMaterial.equalsIgnoreCase("ender crystal")) { EntityUtil.despawn(guild); } else { Block block = region.getCenter().getBlock().getRelative(BlockFace.DOWN); if (block.getLocation().getBlockY() > 1) { block.setType(Material.AIR); } } region.setCenter(location); } if (config.createCenterSphere) { List<Location> sphere = SpaceUtils.sphere(location, 3, 3, false, true, 0); for (Location l : sphere) { if (l.getBlock().getType() != Material.BEDROCK) { l.getBlock().setType(Material.AIR); } } } if (config.createMaterial != null && config.createMaterial != Material.AIR) { location.getBlock().getRelative(BlockFace.DOWN).setType(config.createMaterial); } else if (config.createStringMaterial.equalsIgnoreCase("ender crystal")) { EntityUtil.spawn(guild); } player.sendMessage(messages.adminGuildRelocated.replace("{GUILD}", guild.getName()).replace("{REGION}", region.getName())); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public boolean checkPlayer(Player player, SecurityType type, Object... values) { if (!Settings.getConfig().regionsEnabled) { return false; } if (isBanned(User.get(player))) { return true; } switch (type) { case FREECAM: Guild guild = null; for (int i = 0; i < values.length; i++) { if (values[i] instanceof Guild) { guild = (Guild) values[i]; } } int dis = (int) RegionUtils.get(guild.getRegion()).getCenter().distance(player.getLocation()); if (dis < 6) { return false; } for (Player w : Bukkit.getOnlinePlayers()) { if (w.isOp()) { w.sendMessage(SecurityUtils.getBustedMessage(player.getName(), "FreeCam")); w.sendMessage(SecurityUtils.getNoteMessage("Zaatakowal krysztal z odleglosci &c" + dis + " kratek")); } } blocked.add(User.get(player)); return true; case EVERYTHING: break; default: break; } return false; } #location 19 #vulnerability type NULL_DEREFERENCE
#fixed code public boolean checkPlayer(Player player, SecurityType type, Object... values) { if (!Settings.getConfig().regionsEnabled) { return false; } if (isBanned(User.get(player))) { return true; } switch (type) { case FREECAM: Guild guild = null; for (Object value : values) { if (value instanceof Guild) { guild = (Guild) value; } } if (guild == null) { return false; } Region region = RegionUtils.get(guild.getRegion()); if (region == null) { return false; } int dis = (int) region.getCenter().distance(player.getLocation()); if (dis < 6) { return false; } for (Player w : Bukkit.getOnlinePlayers()) { if (w.isOp()) { w.sendMessage(SecurityUtils.getBustedMessage(player.getName(), "FreeCam")); w.sendMessage(SecurityUtils.getNoteMessage("Zaatakowal krysztal z odleglosci &c" + dis + " kratek")); } } blocked.add(User.get(player)); return true; case EVERYTHING: break; default: break; } return false; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void remove(Player player) { if (has(player)) { sendPacket(player, bars.get(player).getDestroyPacket()); bars.remove(player); } } #location 3 #vulnerability type NULL_DEREFERENCE
#fixed code public static void remove(Player player) { if (has(player)) { sendPacket(player, DRAGONBAR_CACHE.get(player).getDestroyPacket()); DRAGONBAR_CACHE.remove(player); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { PluginConfig config = Settings.getConfig(); MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; User user = User.get(player); if (!config.baseEnable) { player.sendMessage(messages.baseTeleportationDisabled); return; } if (!user.hasGuild()) { player.sendMessage(messages.baseHasNotGuild); return; } Guild guild = user.getGuild(); if (user.getTeleportation() != null) { player.sendMessage(messages.baseIsTeleportation); return; } ItemStack[] items = Settings.getConfig().baseItems.toArray(new ItemStack[0]); for (ItemStack is : items) { if (!player.getInventory().containsAtLeast(is, is.getAmount())) { String msg = messages.baseItems; if (msg.contains("{ITEM}")) { StringBuilder sb = new StringBuilder(); sb.append(is.getAmount()); sb.append(" "); sb.append(is.getType().toString().toLowerCase()); msg = msg.replace("{ITEM}", sb.toString()); } if (msg.contains("{ITEMS}")) { ArrayList<String> list = new ArrayList<String>(); for (ItemStack it : items) { StringBuilder sb = new StringBuilder(); sb.append(it.getAmount()); sb.append(" "); sb.append(it.getType().toString().toLowerCase()); list.add(sb.toString()); } msg = msg.replace("{ITEMS}", StringUtils.toString(list, true)); } player.sendMessage(msg); return; } } player.getInventory().removeItem(items); int time = Settings.getConfig().baseDelay; if (time < 1) { player.teleport(guild.getHome()); player.sendMessage(messages.baseTeleport); return; } player.sendMessage(messages.baseDontMove.replace("{TIME}", Integer.toString(time))); Location before = player.getLocation(); AtomicInteger i = new AtomicInteger(1); user.setTeleportation(Bukkit.getScheduler().runTaskTimer(FunnyGuilds.getInstance(), () -> { if (!player.isOnline()) { user.getTeleportation().cancel(); user.setTeleportation(null); return; } if (!LocationUtils.equals(player.getLocation(), before)) { user.getTeleportation().cancel(); player.sendMessage(messages.baseMove); user.setTeleportation(null); player.getInventory().addItem(items); return; } if (i.getAndIncrement() > time) { user.getTeleportation().cancel(); player.sendMessage(messages.baseTeleport); player.teleport(guild.getHome()); user.setTeleportation(null); } }, 0L, 20L)); } #location 21 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { PluginConfig config = Settings.getConfig(); MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; User user = User.get(player); if (!config.baseEnable) { player.sendMessage(messages.baseTeleportationDisabled); return; } if (!user.hasGuild()) { player.sendMessage(messages.baseHasNotGuild); return; } Guild guild = user.getGuild(); if (user.getTeleportation() != null) { player.sendMessage(messages.baseIsTeleportation); return; } Collection<ItemStack> requiredItems = config.baseItems; for (ItemStack requiredItem : requiredItems) { if (player.getInventory().containsAtLeast(requiredItem, requiredItem.getAmount())) { continue; } String msg = ItemUtils.translatePlaceholder(messages.baseItems, requiredItems, requiredItem); player.sendMessage(msg); return; } ItemStack[] items = ItemUtils.toArray(requiredItems); player.getInventory().removeItem(items); if (config.baseDelay < 1) { player.teleport(guild.getHome()); player.sendMessage(messages.baseTeleport); return; } int time = config.baseDelay; Location before = player.getLocation(); AtomicInteger i = new AtomicInteger(1); user.setTeleportation(Bukkit.getScheduler().runTaskTimer(FunnyGuilds.getInstance(), () -> { if (!player.isOnline()) { user.getTeleportation().cancel(); user.setTeleportation(null); return; } if (!LocationUtils.equals(player.getLocation(), before)) { user.getTeleportation().cancel(); player.sendMessage(messages.baseMove); user.setTeleportation(null); player.getInventory().addItem(items); return; } if (i.getAndIncrement() > time) { user.getTeleportation().cancel(); player.sendMessage(messages.baseTeleport); player.teleport(guild.getHome()); user.setTeleportation(null); } }, 0L, 20L)); player.sendMessage(messages.baseDontMove.replace("{TIME}", Integer.toString(time))); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig m = Messages.getInstance(); Player p = (Player) sender; User u = User.get(p); if (!u.hasGuild()) { p.sendMessage(m.kickHasNotGuild); return; } if (!u.isOwner() && !u.isDeputy()) { p.sendMessage(m.kickIsNotOwner); return; } if (args.length < 1) { p.sendMessage(m.kickPlayer); return; } User uk = User.get(args[0]); OfflineUser up = uk.getOfflineUser(); if (!uk.hasGuild()) { p.sendMessage(m.kickToHasNotGuild); return; } if (!u.getGuild().equals(uk.getGuild())) { p.sendMessage(m.kickOtherGuild); return; } if (uk.isOwner()) { p.sendMessage(m.kickOwner); return; } Guild guild = u.getGuild(); IndependentThread.action(ActionType.PREFIX_GLOBAL_REMOVE_PLAYER, up); guild.removeMember(uk); uk.removeGuild(); if (up.isOnline()) { IndependentThread.action(ActionType.PREFIX_GLOBAL_UPDATE_PLAYER, p); } p.sendMessage(m.kickToOwner.replace("{PLAYER}", uk.getName())); Player pk = uk.getPlayer(); if (pk != null) { pk.sendMessage(m.kickToPlayer.replace("{GUILD}", guild.getName())); } Bukkit.broadcastMessage(m.broadcastKick.replace("{PLAYER}", uk.getName()).replace("{GUILD}", guild.getName()).replace("{TAG}", guild.getTag())); } #location 13 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; User user = User.get(player); if (!user.hasGuild()) { player.sendMessage(messages.kickHasNotGuild); return; } if (!user.isOwner() && !user.isDeputy()) { player.sendMessage(messages.kickIsNotOwner); return; } if (args.length < 1) { player.sendMessage(messages.kickPlayer); return; } User formerUser = User.get(args[0]); OfflineUser formerOffline = formerUser.getOfflineUser(); if (!formerUser.hasGuild()) { player.sendMessage(messages.kickToHasNotGuild); return; } if (!user.getGuild().equals(formerUser.getGuild())) { player.sendMessage(messages.kickOtherGuild); return; } if (formerUser.isOwner()) { player.sendMessage(messages.kickOwner); return; } Guild guild = user.getGuild(); IndependentThread.action(ActionType.PREFIX_GLOBAL_REMOVE_PLAYER, formerOffline); guild.removeMember(formerUser); formerUser.removeGuild(); if (formerOffline.isOnline()) { IndependentThread.action(ActionType.PREFIX_GLOBAL_UPDATE_PLAYER, player); } MessageTranslator translator = new MessageTranslator() .register("{PLAYER}", formerUser.getName()) .register("{GUILD}", guild.getName()) .register("{TAG}", guild.getTag()); player.sendMessage(translator.translate(messages.kickToOwner)); Bukkit.broadcastMessage(translator.translate(messages.broadcastKick)); Player formerPlayer = formerUser.getPlayer(); if (formerPlayer != null) { formerPlayer.sendMessage(translator.translate(messages.kickToPlayer)); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { PluginConfig c = Settings.getConfig(); MessagesConfig m = Messages.getInstance(); Player p = (Player) sender; User user = User.get(p); if (!c.baseEnable) { p.sendMessage(m.baseTeleportationDisabled); return; } if (!user.hasGuild()) { p.sendMessage(m.baseHasNotGuild); return; } Guild guild = user.getGuild(); if (user.getTeleportation() != null) { p.sendMessage(m.baseIsTeleportation); return; } ItemStack[] items = Settings.getConfig().baseItems.toArray(new ItemStack[0]); for (ItemStack is : items) { if (!p.getInventory().containsAtLeast(is, is.getAmount())) { String msg = m.baseItems; if (msg.contains("{ITEM}")) { StringBuilder sb = new StringBuilder(); sb.append(is.getAmount()); sb.append(" "); sb.append(is.getType().toString().toLowerCase()); msg = msg.replace("{ITEM}", sb.toString()); } if (msg.contains("{ITEMS}")) { ArrayList<String> list = new ArrayList<String>(); for (ItemStack it : items) { StringBuilder sb = new StringBuilder(); sb.append(it.getAmount()); sb.append(" "); sb.append(it.getType().toString().toLowerCase()); list.add(sb.toString()); } msg = msg.replace("{ITEMS}", StringUtils.toString(list, true)); } p.sendMessage(msg); return; } } p.getInventory().removeItem(items); int time = Settings.getConfig().baseDelay; if (time < 1) { p.teleport(guild.getHome()); p.sendMessage(m.baseTeleport); return; } p.sendMessage(m.baseDontMove.replace("{TIME}", Integer.toString(time))); Location before = p.getLocation(); AtomicInteger i = new AtomicInteger(1); user.setTeleportation(Bukkit.getScheduler().runTaskTimer(FunnyGuilds.getInstance(), () -> { if (!p.isOnline()) { user.getTeleportation().cancel(); user.setTeleportation(null); return; } if (!LocationUtils.equals(p.getLocation(), before)) { user.getTeleportation().cancel(); p.sendMessage(m.baseMove); user.setTeleportation(null); p.getInventory().addItem(items); return; } if (i.getAndIncrement() > time) { user.getTeleportation().cancel(); p.sendMessage(m.baseTeleport); p.teleport(guild.getHome()); user.setTeleportation(null); } }, 0L, 20L)); } #location 9 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { PluginConfig config = Settings.getConfig(); MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; User user = User.get(player); if (!config.baseEnable) { player.sendMessage(messages.baseTeleportationDisabled); return; } if (!user.hasGuild()) { player.sendMessage(messages.baseHasNotGuild); return; } Guild guild = user.getGuild(); if (user.getTeleportation() != null) { player.sendMessage(messages.baseIsTeleportation); return; } ItemStack[] items = Settings.getConfig().baseItems.toArray(new ItemStack[0]); for (ItemStack is : items) { if (!player.getInventory().containsAtLeast(is, is.getAmount())) { String msg = messages.baseItems; if (msg.contains("{ITEM}")) { StringBuilder sb = new StringBuilder(); sb.append(is.getAmount()); sb.append(" "); sb.append(is.getType().toString().toLowerCase()); msg = msg.replace("{ITEM}", sb.toString()); } if (msg.contains("{ITEMS}")) { ArrayList<String> list = new ArrayList<String>(); for (ItemStack it : items) { StringBuilder sb = new StringBuilder(); sb.append(it.getAmount()); sb.append(" "); sb.append(it.getType().toString().toLowerCase()); list.add(sb.toString()); } msg = msg.replace("{ITEMS}", StringUtils.toString(list, true)); } player.sendMessage(msg); return; } } player.getInventory().removeItem(items); int time = Settings.getConfig().baseDelay; if (time < 1) { player.teleport(guild.getHome()); player.sendMessage(messages.baseTeleport); return; } player.sendMessage(messages.baseDontMove.replace("{TIME}", Integer.toString(time))); Location before = player.getLocation(); AtomicInteger i = new AtomicInteger(1); user.setTeleportation(Bukkit.getScheduler().runTaskTimer(FunnyGuilds.getInstance(), () -> { if (!player.isOnline()) { user.getTeleportation().cancel(); user.setTeleportation(null); return; } if (!LocationUtils.equals(player.getLocation(), before)) { user.getTeleportation().cancel(); player.sendMessage(messages.baseMove); user.setTeleportation(null); player.getInventory().addItem(items); return; } if (i.getAndIncrement() > time) { user.getTeleportation().cancel(); player.sendMessage(messages.baseTeleport); player.teleport(guild.getHome()); user.setTeleportation(null); } }, 0L, 20L)); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static int getPing(Player player) { int ping = 0; if (player == null) { return ping; } try { Class<?> craftPlayer = Reflections.getCraftBukkitClass("entity.CraftPlayer"); Object cp = craftPlayer.cast(player); Object handle = craftPlayer.getMethod("getHandle").invoke(cp); ping = (int) handle.getClass().getField("ping").get(handle); } catch (Exception e) { if (FunnyGuildsLogger.exception(e.getCause())) { e.printStackTrace(); } } return ping; } #location 10 #vulnerability type NULL_DEREFERENCE
#fixed code public static int getPing(Player player) { int ping = 0; if (player == null) { return ping; } try { Object cp = craftPlayerClass.cast(player); Object handle = getHandleMethod.invoke(cp); ping = (int) pingField.get(handle); } catch (Exception e) { if (FunnyGuildsLogger.exception(e.getCause())) { e.printStackTrace(); } } return ping; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public boolean isInNonPointsRegion(Location location) { if (! isInRegion(location)) { return false; } for (ProtectedRegion region : getRegionSet(location)) { if (region.getFlag(noPointsFlag) == StateFlag.State.ALLOW) { return true; } } return false; } #location 7 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public boolean isInNonPointsRegion(Location location) { ApplicableRegionSet regionSet = getRegionSet(location); if (regionSet == null) { return false; } for (ProtectedRegion region : regionSet) { if (region.getFlag(noPointsFlag) == StateFlag.State.ALLOW) { return true; } } return false; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public synchronized Scoreboard getScoreboard() { if (this.scoreboard == null) { this.scoreboard = Bukkit.getScoreboardManager().getNewScoreboard(); } return this.scoreboard; } #location 3 #vulnerability type NULL_DEREFERENCE
#fixed code public synchronized Scoreboard getScoreboard() { return this.scoreboard; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static String parseRank(User source, String var) { if (! var.contains("TOP-")) { return null; } int i = getIndex(var); if (i <= 0) { FunnyGuilds.getInstance().getPluginLogger().error("Index in TOP- must be greater or equal to 1!"); return null; } PluginConfiguration config = FunnyGuilds.getInstance().getPluginConfiguration(); if (var.contains("GTOP")) { List<Guild> rankedGuilds = new ArrayList<>(); for (int in = 1; in <= RankManager.getInstance().guilds(); in++) { Guild guild = RankManager.getInstance().getGuild(in); if (guild != null && guild.getMembers().size() >= config.minMembersToInclude) { rankedGuilds.add(guild); } } if (rankedGuilds.isEmpty() || i - 1 >= rankedGuilds.size()) { return StringUtils.replace(var, "{GTOP-" + i + '}', FunnyGuilds.getInstance().getMessageConfiguration().gtopNoValue); } else { Guild guild = rankedGuilds.get(i - 1); int points = guild.getRank().getPoints(); String pointsFormat = config.gtopPoints; if (!pointsFormat.isEmpty()) { pointsFormat = pointsFormat.replace("{POINTS-FORMAT}", IntegerRange.inRange(points, config.pointsFormat, "POINTS")); pointsFormat = pointsFormat.replace("{POINTS}", String.valueOf(points)); } String guildTag = guild.getTag(); if (config.playerListUseRelationshipColors) { guildTag = StringUtils.replace(config.prefixOther, "{TAG}", guild.getTag()); if (source != null && source.hasGuild()) { Guild sourceGuild = source.getGuild(); if (sourceGuild.getAllies().contains(guild)) { guildTag = StringUtils.replace(config.prefixAllies, "{TAG}", guild.getTag()); } else if (sourceGuild.getUUID().equals(guild.getUUID())) { guildTag = StringUtils.replace(config.prefixOur, "{TAG}", guild.getTag()); } } } return StringUtils.replace(var, "{GTOP-" + i + '}', guildTag + pointsFormat); } } else if (var.contains("PTOP")) { User user = RankManager.getInstance().getUser(i); if (user != null) { int points = user.getRank().getPoints(); String pointsFormat = config.ptopPoints; if (!pointsFormat.isEmpty()) { pointsFormat = pointsFormat.replace("{POINTS-FORMAT}", IntegerRange.inRange(points, config.pointsFormat, "POINTS")); pointsFormat = pointsFormat.replace("{POINTS}", String.valueOf(points)); } return StringUtils.replace(var, "{PTOP-" + i + '}', (user.isOnline() ? config.ptopOnline : config.ptopOffline) + user.getName() + pointsFormat); } else { return StringUtils.replace(var, "{PTOP-" + i + '}', FunnyGuilds.getInstance().getMessageConfiguration().ptopNoValue); } } return null; } #location 27 #vulnerability type NULL_DEREFERENCE
#fixed code public static String parseRank(User source, String var) { if (! var.contains("TOP-")) { return null; } int i = getIndex(var); if (i <= 0) { FunnyGuilds.getInstance().getPluginLogger().error("Index in TOP- must be greater or equal to 1!"); return null; } PluginConfiguration config = FunnyGuilds.getInstance().getPluginConfiguration(); if (var.contains("GTOP")) { Guild guild; int positionIdx = i; do { guild = RankManager.getInstance().getGuild(positionIdx++); if (guild == null) { return StringUtils.replace(var, "{GTOP-" + i + '}', FunnyGuilds.getInstance().getMessageConfiguration().gtopNoValue); } } while (guild.getMembers().size() < config.minMembersToInclude); int points = guild.getRank().getPoints(); String pointsFormat = config.gtopPoints; if (!pointsFormat.isEmpty()) { pointsFormat = pointsFormat.replace("{POINTS-FORMAT}", IntegerRange.inRange(points, config.pointsFormat, "POINTS")); pointsFormat = pointsFormat.replace("{POINTS}", String.valueOf(points)); } String guildTag = guild.getTag(); if (config.playerListUseRelationshipColors) { guildTag = StringUtils.replace(config.prefixOther, "{TAG}", guild.getTag()); if (source != null && source.hasGuild()) { Guild sourceGuild = source.getGuild(); if (sourceGuild.getAllies().contains(guild)) { guildTag = StringUtils.replace(config.prefixAllies, "{TAG}", guild.getTag()); } else if (sourceGuild.getUUID().equals(guild.getUUID())) { guildTag = StringUtils.replace(config.prefixOur, "{TAG}", guild.getTag()); } } } return StringUtils.replace(var, "{GTOP-" + i + '}', guildTag + pointsFormat); } else if (var.contains("PTOP")) { User user = RankManager.getInstance().getUser(i); if (user == null) { return StringUtils.replace(var, "{PTOP-" + i + '}', FunnyGuilds.getInstance().getMessageConfiguration().ptopNoValue); } int points = user.getRank().getPoints(); String pointsFormat = config.ptopPoints; if (!pointsFormat.isEmpty()) { pointsFormat = pointsFormat.replace("{POINTS-FORMAT}", IntegerRange.inRange(points, config.pointsFormat, "POINTS")); pointsFormat = pointsFormat.replace("{POINTS}", String.valueOf(points)); } return StringUtils.replace(var, "{PTOP-" + i + '}', (user.isOnline() ? config.ptopOnline : config.ptopOffline) + user.getName() + pointsFormat); } return null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void patch() { PluginConfiguration config = FunnyGuilds.getInstance().getPluginConfiguration(); for (Player player : this.getServer().getOnlinePlayers()) { this.getServer().getScheduler().runTask(this, () -> PacketExtension.registerPlayer(player)); User user = User.get(player); if (user.getCache().getScoreboard() == null) { user.getCache().setScoreboard(Bukkit.getScoreboardManager().getNewScoreboard()); } user.getCache().getDummy(); user.getRank(); if (config.playerListEnable) { AbstractTablist.createTablist(config.playerList, config.playerListHeader, config.playerListFooter, config.playerListPing, player); } } for (Guild guild : GuildUtils.getGuilds()) { if (config.createEntityType != null) { GuildEntityHelper.spawnGuildHeart(guild); } guild.updateRank(); } } #location 14 #vulnerability type NULL_DEREFERENCE
#fixed code private void patch() { for (Player player : this.getServer().getOnlinePlayers()) { this.getServer().getScheduler().runTask(this, () -> PacketExtension.registerPlayer(player)); User user = User.get(player); if (user.getCache().getScoreboard() == null) { user.getCache().setScoreboard(Bukkit.getScoreboardManager().getNewScoreboard()); } user.getCache().getDummy(); user.getRank(); if (!pluginConfiguration.playerListEnable) { continue; } AbstractTablist.createTablist(pluginConfiguration.playerList, pluginConfiguration.playerListHeader, pluginConfiguration.playerListFooter, pluginConfiguration.playerListPing, player); } for (Guild guild : GuildUtils.getGuilds()) { if (pluginConfiguration.createEntityType != null) { GuildEntityHelper.spawnGuildHeart(guild); } guild.updateRank(); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void broadcast(String message) { for (User user : this.getOnlineMembers()) { user.getPlayer().sendMessage(message); } } #location 3 #vulnerability type NULL_DEREFERENCE
#fixed code public void broadcast(String message) { for (User user : this.getOnlineMembers()) { if (user.getPlayer() == null) { continue; } user.getPlayer().sendMessage(message); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void load() { Database db = Database.getInstance(); PluginConfig config = Settings.getConfig(); usersTable(db); regionsTable(db); guildsTable(db); Database.getInstance().executeQuery("SELECT * FROM `" + config.mysql.usersTableName + "`", usersResult -> { try { while (usersResult.next()) { User user = DatabaseUser.deserialize(usersResult); if (user != null) { user.changed(); } } FunnyLogger.info("Loaded users: " + UserUtils.getUsers().size()); } catch (Exception e) { if (FunnyLogger.exception(e.getCause())) { e.printStackTrace(); } } }); if (Settings.getConfig().regionsEnabled) { Database.getInstance().executeQuery("SELECT * FROM `" + config.mysql.regionsTableName + "`", regionsResult -> { try { while (regionsResult.next()) { Region region = DatabaseRegion.deserialize(regionsResult); if (region != null) { region.changed(); } } FunnyLogger.info("Loaded regions: " + RegionUtils.getRegions().size()); } catch (Exception e) { if (FunnyLogger.exception(e.getCause())) { e.printStackTrace(); } } }); } else { FunnyLogger.info("Regions are disabled and thus - not loaded"); } Database.getInstance().executeQuery("SELECT * FROM `" + config.mysql.guildsTableName + "`", guildsResult -> { try { while (guildsResult.next()) { Guild guild = DatabaseGuild.deserialize(guildsResult); if (guild != null) { guild.changed(); } } FunnyLogger.info("Loaded guilds: " + GuildUtils.getGuilds().size()); } catch (Exception e) { if (FunnyLogger.exception(e.getCause())) { e.printStackTrace(); } } }); // TODO for (Guild guild : GuildUtils.getGuilds()) { if (guild.getOwner() != null) { continue; } GuildUtils.deleteGuild(guild); } ConcurrencyManager concurrencyManager = FunnyGuilds.getInstance().getConcurrencyManager(); concurrencyManager.postRequests(new PrefixGlobalUpdateRequest()); } #location 76 #vulnerability type NULL_DEREFERENCE
#fixed code public void load() { Database db = Database.getInstance(); PluginConfig config = Settings.getConfig(); usersTable(db); regionsTable(db); guildsTable(db); Database.getInstance().executeQuery("SELECT * FROM `" + config.mysql.usersTableName + "`", usersResult -> { try { while (usersResult.next()) { User user = DatabaseUser.deserialize(usersResult); if (user != null) { user.changed(); } } FunnyLogger.info("Loaded users: " + UserUtils.getUsers().size()); } catch (Exception e) { if (FunnyLogger.exception(e.getCause())) { e.printStackTrace(); } } }); if (Settings.getConfig().regionsEnabled) { Database.getInstance().executeQuery("SELECT * FROM `" + config.mysql.regionsTableName + "`", regionsResult -> { try { while (regionsResult.next()) { Region region = DatabaseRegion.deserialize(regionsResult); if (region != null) { region.changed(); } } FunnyLogger.info("Loaded regions: " + RegionUtils.getRegions().size()); } catch (Exception e) { if (FunnyLogger.exception(e.getCause())) { e.printStackTrace(); } } }); } else { FunnyLogger.info("Regions are disabled and thus - not loaded"); } Database.getInstance().executeQuery("SELECT * FROM `" + config.mysql.guildsTableName + "`", guildsResult -> { try { while (guildsResult.next()) { Guild guild = DatabaseGuild.deserialize(guildsResult); if (guild != null) { guild.changed(); } } FunnyLogger.info("Loaded guilds: " + GuildUtils.getGuilds().size()); } catch (Exception e) { if (FunnyLogger.exception(e.getCause())) { e.printStackTrace(); } } }); Database.getInstance().executeQuery("SELECT `tag`, `allies`, `enemies` FROM `" + config.mysql.guildsTableName + "`", result -> { try { while (result.next()) { Guild guild = GuildUtils.getByTag(result.getString("tag")); if (guild == null) { continue; } String alliesList = result.getString("allies"); String enemiesList = result.getString("enemies"); List<Guild> allies = new ArrayList<>(); if (alliesList != null && !alliesList.equals("")) { allies = GuildUtils.getGuilds(ChatUtils.fromString(alliesList)); } List<Guild> enemies = new ArrayList<>(); if (enemiesList != null && !enemiesList.equals("")) { enemies = GuildUtils.getGuilds(ChatUtils.fromString(enemiesList)); } guild.setAllies(allies); guild.setEnemies(enemies); } } catch (Exception ex) { if (FunnyLogger.exception(ex.getCause())) { ex.printStackTrace(); } } }); // TODO for (Guild guild : GuildUtils.getGuilds()) { if (guild.getOwner() != null) { continue; } GuildUtils.deleteGuild(guild); } ConcurrencyManager concurrencyManager = FunnyGuilds.getInstance().getConcurrencyManager(); concurrencyManager.postRequests(new PrefixGlobalUpdateRequest()); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { PluginConfig config = Settings.getConfig(); MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; User user = User.get(player); if (!config.baseEnable) { player.sendMessage(messages.baseTeleportationDisabled); return; } if (!user.hasGuild()) { player.sendMessage(messages.baseHasNotGuild); return; } Guild guild = user.getGuild(); if (user.getTeleportation() != null) { player.sendMessage(messages.baseIsTeleportation); return; } ItemStack[] items = Settings.getConfig().baseItems.toArray(new ItemStack[0]); for (ItemStack is : items) { if (!player.getInventory().containsAtLeast(is, is.getAmount())) { String msg = messages.baseItems; if (msg.contains("{ITEM}")) { StringBuilder sb = new StringBuilder(); sb.append(is.getAmount()); sb.append(" "); sb.append(is.getType().toString().toLowerCase()); msg = msg.replace("{ITEM}", sb.toString()); } if (msg.contains("{ITEMS}")) { ArrayList<String> list = new ArrayList<String>(); for (ItemStack it : items) { StringBuilder sb = new StringBuilder(); sb.append(it.getAmount()); sb.append(" "); sb.append(it.getType().toString().toLowerCase()); list.add(sb.toString()); } msg = msg.replace("{ITEMS}", StringUtils.toString(list, true)); } player.sendMessage(msg); return; } } player.getInventory().removeItem(items); int time = Settings.getConfig().baseDelay; if (time < 1) { player.teleport(guild.getHome()); player.sendMessage(messages.baseTeleport); return; } player.sendMessage(messages.baseDontMove.replace("{TIME}", Integer.toString(time))); Location before = player.getLocation(); AtomicInteger i = new AtomicInteger(1); user.setTeleportation(Bukkit.getScheduler().runTaskTimer(FunnyGuilds.getInstance(), () -> { if (!player.isOnline()) { user.getTeleportation().cancel(); user.setTeleportation(null); return; } if (!LocationUtils.equals(player.getLocation(), before)) { user.getTeleportation().cancel(); player.sendMessage(messages.baseMove); user.setTeleportation(null); player.getInventory().addItem(items); return; } if (i.getAndIncrement() > time) { user.getTeleportation().cancel(); player.sendMessage(messages.baseTeleport); player.teleport(guild.getHome()); user.setTeleportation(null); } }, 0L, 20L)); } #location 14 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { PluginConfig config = Settings.getConfig(); MessagesConfig messages = Messages.getInstance(); Player player = (Player) sender; User user = User.get(player); if (!config.baseEnable) { player.sendMessage(messages.baseTeleportationDisabled); return; } if (!user.hasGuild()) { player.sendMessage(messages.baseHasNotGuild); return; } Guild guild = user.getGuild(); if (user.getTeleportation() != null) { player.sendMessage(messages.baseIsTeleportation); return; } Collection<ItemStack> requiredItems = config.baseItems; for (ItemStack requiredItem : requiredItems) { if (player.getInventory().containsAtLeast(requiredItem, requiredItem.getAmount())) { continue; } String msg = ItemUtils.translatePlaceholder(messages.baseItems, requiredItems, requiredItem); player.sendMessage(msg); return; } ItemStack[] items = ItemUtils.toArray(requiredItems); player.getInventory().removeItem(items); if (config.baseDelay < 1) { player.teleport(guild.getHome()); player.sendMessage(messages.baseTeleport); return; } int time = config.baseDelay; Location before = player.getLocation(); AtomicInteger i = new AtomicInteger(1); user.setTeleportation(Bukkit.getScheduler().runTaskTimer(FunnyGuilds.getInstance(), () -> { if (!player.isOnline()) { user.getTeleportation().cancel(); user.setTeleportation(null); return; } if (!LocationUtils.equals(player.getLocation(), before)) { user.getTeleportation().cancel(); player.sendMessage(messages.baseMove); user.setTeleportation(null); player.getInventory().addItem(items); return; } if (i.getAndIncrement() > time) { user.getTeleportation().cancel(); player.sendMessage(messages.baseTeleport); player.teleport(guild.getHome()); user.setTeleportation(null); } }, 0L, 20L)); player.sendMessage(messages.baseDontMove.replace("{TIME}", Integer.toString(time))); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); if (args.length < 1) { sender.sendMessage(messages.generalNoTagGiven); return; } if (!GuildUtils.tagExists(args[0])) { sender.sendMessage(messages.generalNoGuildFound); return; } if (args.length < 2) { sender.sendMessage(messages.generalNoNickGiven); return; } if (!UserUtils.playedBefore(args[1])) { sender.sendMessage(messages.generalNotPlayedBefore); return; } Guild guild = GuildUtils.byTag(args[0]); User user = User.get(args[1]); if (!guild.getMembers().contains(user)) { sender.sendMessage(messages.adminUserNotMemberOf); return; } if (guild.getOwner().equals(user)) { sender.sendMessage(messages.adminAlreadyLeader); return; } Player leaderPlayer = user.getPlayer(); guild.setOwner(user); sender.sendMessage(messages.leaderSet); if (leaderPlayer != null) { leaderPlayer.sendMessage(messages.leaderOwner); } for (User member : guild.getOnlineMembers()) { member.getPlayer().sendMessage(messages.leaderMembers.replace("{PLAYER}", user.getName())); } } #location 28 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); if (args.length < 1) { sender.sendMessage(messages.generalNoTagGiven); return; } Guild guild = GuildUtils.byTag(args[0]); if (guild == null) { sender.sendMessage(messages.generalNoGuildFound); return; } if (args.length < 2) { sender.sendMessage(messages.generalNoNickGiven); return; } if (!UserUtils.playedBefore(args[1])) { sender.sendMessage(messages.generalNotPlayedBefore); return; } User user = User.get(args[1]); if (!guild.getMembers().contains(user)) { sender.sendMessage(messages.adminUserNotMemberOf); return; } if (guild.getOwner().equals(user)) { sender.sendMessage(messages.adminAlreadyLeader); return; } Player leaderPlayer = user.getPlayer(); guild.setOwner(user); sender.sendMessage(messages.leaderSet); if (leaderPlayer != null) { leaderPlayer.sendMessage(messages.leaderOwner); } String message = messages.leaderMembers.replace("{PLAYER}", user.getName()); for (User member : guild.getOnlineMembers()) { member.getPlayer().sendMessage(message); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static IndependentThread getInstance() { if (instance == null) { new IndependentThread().start(); } return instance; } #location 5 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code public static IndependentThread getInstance() { if (instance == null) { new IndependentThread().start(); } return instance; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig m = Messages.getInstance(); User user = User.get((Player) sender); if (user.isSpy()) { user.setSpy(false); sender.sendMessage(m.adminStopSpy); } else { user.setSpy(true); sender.sendMessage(m.adminStartSpy); } } #location 8 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void execute(CommandSender sender, String[] args) { MessagesConfig messages = Messages.getInstance(); User user = User.get((Player) sender); if (user.isSpy()) { user.setSpy(false); sender.sendMessage(messages.adminStopSpy); } else { user.setSpy(true); sender.sendMessage(messages.adminStartSpy); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public boolean checkPlayer(Player player, SecurityType type, Object... values) { if (!Settings.getConfig().regionsEnabled) { return false; } if (isBanned(User.get(player))) { return true; } switch (type) { case FREECAM: Guild guild = null; for (int i = 0; i < values.length; i++) { if (values[i] instanceof Guild) { guild = (Guild) values[i]; } } int dis = (int) RegionUtils.get(guild.getRegion()).getCenter().distance(player.getLocation()); if (dis < 6) { return false; } for (Player w : Bukkit.getOnlinePlayers()) { if (w.isOp()) { w.sendMessage(SecurityUtils.getBustedMessage(player.getName(), "FreeCam")); w.sendMessage(SecurityUtils.getNoteMessage("Zaatakowal krysztal z odleglosci &c" + dis + " kratek")); } } blocked.add(User.get(player)); return true; case EVERYTHING: break; default: break; } return false; } #location 19 #vulnerability type NULL_DEREFERENCE
#fixed code public boolean checkPlayer(Player player, SecurityType type, Object... values) { if (!Settings.getConfig().regionsEnabled) { return false; } if (isBanned(User.get(player))) { return true; } switch (type) { case FREECAM: Guild guild = null; for (Object value : values) { if (value instanceof Guild) { guild = (Guild) value; } } if (guild == null) { return false; } Region region = RegionUtils.get(guild.getRegion()); if (region == null) { return false; } int dis = (int) region.getCenter().distance(player.getLocation()); if (dis < 6) { return false; } for (Player w : Bukkit.getOnlinePlayers()) { if (w.isOp()) { w.sendMessage(SecurityUtils.getBustedMessage(player.getName(), "FreeCam")); w.sendMessage(SecurityUtils.getNoteMessage("Zaatakowal krysztal z odleglosci &c" + dis + " kratek")); } } blocked.add(User.get(player)); return true; case EVERYTHING: break; default: break; } return false; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected final boolean sendStopToPostgresqlInstance() { final boolean result = shutdownPostgres(getConfig()); if (runtimeConfig.getArtifactStore() instanceof PostgresArtifactStore) { final IDirectory tempDir = ((PostgresArtifactStore) runtimeConfig.getArtifactStore()).getTempDir(); if (tempDir != null && tempDir.asFile() != null) { logger.log(Level.INFO, format("Cleaning up after the embedded process (removing %s)...", tempDir.asFile().getAbsolutePath())); } forceDelete(tempDir.asFile()); } return result; } #location 9 #vulnerability type NULL_DEREFERENCE
#fixed code protected final boolean sendStopToPostgresqlInstance() { final boolean result = shutdownPostgres(getConfig()); if (runtimeConfig.getArtifactStore() instanceof PostgresArtifactStore) { final IDirectory tempDir = ((PostgresArtifactStore) runtimeConfig.getArtifactStore()).getTempDir(); if (tempDir != null && tempDir.asFile() != null) { logger.log(Level.INFO, format("Cleaning up after the embedded process (removing %s)...", tempDir.asFile().getAbsolutePath())); forceDelete(tempDir.asFile()); } } return result; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private double testModel() { try { double runningLoss = 0; double runningWeightOfValidationSet = 0; boolean gotNextCycle = false; int cycle = 0; while (dataCycler.hasMore() || gotNextCycle) { BufferedWriter trainingWriter = new BufferedWriter(new FileWriter("training" + cycle)); trainingWriter.write("FileNo"); for (T instance : dataCycler.getValidationSet()) { trainingWriter.write("" + ((RegressionInstance) instance).id + "\n"); } BufferedWriter testWriter = new BufferedWriter(new FileWriter("test" + cycle)); testWriter.write("FileNo,actual,predicted\n"); testWriter = new BufferedWriter(new FileWriter("validation" + cycle)); List<T> validationSet = dataCycler.getValidationSet(); double validationSetWeight = getInstanceWeights(validationSet); PM predictiveModel = modelBuilder.buildPredictiveModel(dataCycler.getTrainingSet()); runningLoss += ((RegressionLossChecker) lossChecker).calculateLoss(predictiveModel, validationSet, testWriter) * validationSetWeight; runningWeightOfValidationSet += validationSetWeight; gotNextCycle = dataCycler.nextCycle(); cycle++; testWriter.flush(); trainingWriter.flush(); testWriter.close(); trainingWriter.close(); } return runningLoss / runningWeightOfValidationSet; } catch (IOException e) { logger.error("couldn't write"); } return 0.0; } #location 32 #vulnerability type RESOURCE_LEAK
#fixed code private double testModel() { double runningLoss = 0; double runningWeightOfValidationSet = 0; boolean gotNextCycle= false; while (dataCycler.hasMore() || gotNextCycle){ List<T> validationSet = dataCycler.getValidationSet(); double validationSetWeight = getInstanceWeights(validationSet); PM predictiveModel = modelBuilder.buildPredictiveModel(dataCycler.getTrainingSet()); runningLoss += lossChecker.calculateLoss(predictiveModel, validationSet) * validationSetWeight; runningWeightOfValidationSet += validationSetWeight; gotNextCycle = dataCycler.nextCycle(); } return runningLoss / runningWeightOfValidationSet; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void simpleBmiTestSplit() throws Exception { final List<Instance> instances = TreeBuilderTestUtils.getIntegerInstances(1000); final TreeBuilder tb = new TreeBuilder(new SplitDiffScorer()); final RandomForestBuilder rfb = new RandomForestBuilder(tb); final PAVCalibratedPredictiveModelBuilder cpmb = new PAVCalibratedPredictiveModelBuilder(rfb); final UpdatablePAVCalibratedPredictiveModelBuilder ucpmb = new UpdatablePAVCalibratedPredictiveModelBuilder(cpmb, null, 1); final long startTime = System.currentTimeMillis(); final CalibratedPredictiveModel calibratedPredictiveModel = ucpmb.buildPredictiveModel(instances); final RandomForest randomForest = (RandomForest) calibratedPredictiveModel.predictiveModel; TreeBuilderTestUtils.serializeDeserialize(randomForest); final List<Tree> trees = randomForest.trees; final int treeSize = trees.size(); final int firstTreeNodeSize = trees.get(0).node.size(); Assert.assertTrue(treeSize < 400, "Forest size should be less than 400"); Assert.assertTrue((System.currentTimeMillis() - startTime) < 20000,"Building this node should take far less than 20 seconds"); final List<Instance> newInstances = TreeBuilderTestUtils.getIntegerInstances(1000); final CalibratedPredictiveModel newCalibratedPredictiveModel = ucpmb.buildPredictiveModel(newInstances); final RandomForest newRandomForest = (RandomForest) newCalibratedPredictiveModel.predictiveModel; Assert.assertTrue(calibratedPredictiveModel == newCalibratedPredictiveModel, "Expect same tree to be updated"); Assert.assertEquals(treeSize, newRandomForest.trees.size(), "Expected same number of trees"); Assert.assertNotEquals(firstTreeNodeSize, newRandomForest.trees.get(0).node.size(), "Expected new nodes"); } #location 9 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void simpleBmiTestSplit() throws Exception { final List<Instance> instances = TreeBuilderTestUtils.getIntegerInstances(1000); final TreeBuilder tb = new TreeBuilder(new SplitDiffScorer()); final RandomForestBuilder rfb = new RandomForestBuilder(tb); final PAVCalibratedPredictiveModelBuilder cpmb = new PAVCalibratedPredictiveModelBuilder(rfb); final UpdatablePAVCalibratedPredictiveModelBuilder ucpmb = new UpdatablePAVCalibratedPredictiveModelBuilder(cpmb); final long startTime = System.currentTimeMillis(); final CalibratedPredictiveModel calibratedPredictiveModel = ucpmb.buildPredictiveModel(instances); final RandomForest randomForest = (RandomForest) calibratedPredictiveModel.predictiveModel; TreeBuilderTestUtils.serializeDeserialize(randomForest); final List<Tree> trees = randomForest.trees; final int treeSize = trees.size(); final int firstTreeNodeSize = trees.get(0).node.size(); Assert.assertTrue(treeSize < 400, "Forest size should be less than 400"); Assert.assertTrue((System.currentTimeMillis() - startTime) < 20000,"Building this node should take far less than 20 seconds"); final List<Instance> newInstances = TreeBuilderTestUtils.getIntegerInstances(1000); final CalibratedPredictiveModel newCalibratedPredictiveModel = ucpmb.buildPredictiveModel(newInstances); final RandomForest newRandomForest = (RandomForest) newCalibratedPredictiveModel.predictiveModel; Assert.assertTrue(calibratedPredictiveModel == newCalibratedPredictiveModel, "Expect same tree to be updated"); Assert.assertEquals(treeSize, newRandomForest.trees.size(), "Expected same number of trees"); Assert.assertNotEquals(firstTreeNodeSize, newRandomForest.trees.get(0).node.size(), "Expected new nodes"); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private double testModel() { try { double runningLoss = 0; double runningWeightOfValidationSet = 0; boolean gotNextCycle = false; int cycle = 0; while (dataCycler.hasMore() || gotNextCycle) { BufferedWriter trainingWriter = new BufferedWriter(new FileWriter("training" + cycle)); trainingWriter.write("FileNo"); for (T instance : dataCycler.getValidationSet()) { trainingWriter.write("" + ((RegressionInstance) instance).id + "\n"); } BufferedWriter testWriter = new BufferedWriter(new FileWriter("test" + cycle)); testWriter.write("FileNo,actual,predicted\n"); testWriter = new BufferedWriter(new FileWriter("validation" + cycle)); List<T> validationSet = dataCycler.getValidationSet(); double validationSetWeight = getInstanceWeights(validationSet); PM predictiveModel = modelBuilder.buildPredictiveModel(dataCycler.getTrainingSet()); runningLoss += ((RegressionLossChecker) lossChecker).calculateLoss(predictiveModel, validationSet, testWriter) * validationSetWeight; runningWeightOfValidationSet += validationSetWeight; gotNextCycle = dataCycler.nextCycle(); cycle++; testWriter.flush(); trainingWriter.flush(); testWriter.close(); trainingWriter.close(); } return runningLoss / runningWeightOfValidationSet; } catch (IOException e) { logger.error("couldn't write"); } return 0.0; } #location 16 #vulnerability type RESOURCE_LEAK
#fixed code private double testModel() { double runningLoss = 0; double runningWeightOfValidationSet = 0; boolean gotNextCycle= false; while (dataCycler.hasMore() || gotNextCycle){ List<T> validationSet = dataCycler.getValidationSet(); double validationSetWeight = getInstanceWeights(validationSet); PM predictiveModel = modelBuilder.buildPredictiveModel(dataCycler.getTrainingSet()); runningLoss += lossChecker.calculateLoss(predictiveModel, validationSet) * validationSetWeight; runningWeightOfValidationSet += validationSetWeight; gotNextCycle = dataCycler.nextCycle(); } return runningLoss / runningWeightOfValidationSet; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static String exportToHtml(Option option, String folderPath, String fileName) { if (fileName == null || fileName.length() == 0) { return exportToHtml(option, folderPath); } String optionStr = GsonUtil.format(option); File folder = new File(folderPath); if (folder.exists() && folder.isFile()) { String tempPath = folder.getParent(); folder = new File(tempPath); } if (!folder.exists()) { folder.mkdirs(); } InputStream is = null; InputStreamReader iReader = null; BufferedReader bufferedReader = null; FileWriter writer = null; List<String> lines = new ArrayList<String>(); String line; //写入文件 File html = new File(folder.getPath() + "/" + fileName); try { is = OptionUtil.class.getResourceAsStream("/template"); iReader = new InputStreamReader(is); bufferedReader = new BufferedReader(iReader); while ((line = bufferedReader.readLine()) != null) { if (line.contains("##option##")) { line = line.replace("##option##", optionStr); } lines.add(line); } writer = new FileWriter(html); for (String l : lines) { writer.write(l + "\n"); } } catch (Exception e) { e.printStackTrace(); } finally { if (is != null) { try { is.close(); } catch (IOException e) { //ignore } } if (writer != null) { try { writer.close(); } catch (IOException e) { //ignore } } } //处理 try { return html.getAbsolutePath(); } catch (Exception e) { return null; } } #location 38 #vulnerability type RESOURCE_LEAK
#fixed code public static String exportToHtml(Option option, String folderPath, String fileName) { if (fileName == null || fileName.length() == 0) { return exportToHtml(option, folderPath); } FileWriter writer = null; List<String> lines = readLines(option); //写入文件 File html = new File(getFolderPath(folderPath) + "/" + fileName); try { writer = new FileWriter(html); for (String l : lines) { writer.write(l + "\n"); } } catch (Exception e) { } finally { if (writer != null) { try { writer.close(); } catch (IOException e) { //ignore } } } //处理 try { return html.getAbsolutePath(); } catch (Exception e) { return null; } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private static List<String> readLines(Option option) { String optionStr = GsonUtil.format(option); InputStream is = null; InputStreamReader iReader = null; BufferedReader bufferedReader = null; List<String> lines = new ArrayList<String>(); String line; try { is = OptionUtil.class.getResourceAsStream("/template"); iReader = new InputStreamReader(is); bufferedReader = new BufferedReader(iReader); while ((line = bufferedReader.readLine()) != null) { if (line.contains("##option##")) { line = line.replace("##option##", optionStr); } lines.add(line); } } catch (Exception e) { } finally { if (is != null) { try { is.close(); } catch (IOException e) { //ignore } } } return lines; } #location 18 #vulnerability type RESOURCE_LEAK
#fixed code private static List<String> readLines(Option option) { String optionStr = GsonUtil.format(option); InputStream is = null; InputStreamReader iReader = null; BufferedReader bufferedReader = null; List<String> lines = new ArrayList<String>(); String line; try { is = OptionUtil.class.getResourceAsStream("/template"); iReader = new InputStreamReader(is, "UTF-8"); bufferedReader = new BufferedReader(iReader); while ((line = bufferedReader.readLine()) != null) { if (line.contains("##option##")) { line = line.replace("##option##", optionStr); } lines.add(line); } } catch (Exception e) { } finally { if (is != null) { try { is.close(); } catch (IOException e) { //ignore } } } return lines; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static Geometry loadGeometryFromWKTFileDbg(String file_name) { if (file_name == null) { throw new IllegalArgumentException(); } String s = null; try { FileInputStream stream = new FileInputStream(file_name); Reader reader = new BufferedReader(new InputStreamReader(stream)); StringBuilder builder = new StringBuilder(); char[] buffer = new char[8192]; int read; while ((read = reader.read(buffer, 0, buffer.length)) > 0) { builder.append(buffer, 0, read); } stream.close(); s = builder.toString(); } catch (Exception ex) { } return OperatorImportFromWkt.local().execute(0, Geometry.Type.Unknown, s, null); } #location 16 #vulnerability type RESOURCE_LEAK
#fixed code public static Geometry loadGeometryFromWKTFileDbg(String file_name) { if (file_name == null) { throw new IllegalArgumentException(); } String s = null; Reader reader = null; try { FileInputStream stream = new FileInputStream(file_name); reader = new BufferedReader(new InputStreamReader(stream)); StringBuilder builder = new StringBuilder(); char[] buffer = new char[8192]; int read; while ((read = reader.read(buffer, 0, buffer.length)) > 0) { builder.append(buffer, 0, read); } s = builder.toString(); } catch (Exception ex) { } finally { if (reader != null) { try { reader.close(); } catch (IOException e) { } } } return OperatorImportFromWkt.local().execute(0, Geometry.Type.Unknown, s, null); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static MapGeometry loadGeometryFromJSONFileDbg(String file_name) { if (file_name == null) { throw new IllegalArgumentException(); } String jsonString = null; try { FileInputStream stream = new FileInputStream(file_name); Reader reader = new BufferedReader(new InputStreamReader(stream)); StringBuilder builder = new StringBuilder(); char[] buffer = new char[8192]; int read; while ((read = reader.read(buffer, 0, buffer.length)) > 0) { builder.append(buffer, 0, read); } stream.close(); jsonString = builder.toString(); } catch (Exception ex) { } MapGeometry mapGeom = OperatorImportFromJson.local().execute(Geometry.Type.Unknown, jsonString); return mapGeom; } #location 16 #vulnerability type RESOURCE_LEAK
#fixed code public static MapGeometry loadGeometryFromJSONFileDbg(String file_name) { if (file_name == null) { throw new IllegalArgumentException(); } String jsonString = null; Reader reader = null; try { FileInputStream stream = new FileInputStream(file_name); reader = new BufferedReader(new InputStreamReader(stream)); StringBuilder builder = new StringBuilder(); char[] buffer = new char[8192]; int read; while ((read = reader.read(buffer, 0, buffer.length)) > 0) { builder.append(buffer, 0, read); } jsonString = builder.toString(); } catch (Exception ex) { } finally { if (reader != null) { try { reader.close(); } catch (IOException e) { } } } MapGeometry mapGeom = OperatorImportFromJson.local().execute(Geometry.Type.Unknown, jsonString); return mapGeom; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static Geometry loadGeometryFromWKTFileDbg(String file_name) { if (file_name == null) { throw new IllegalArgumentException(); } String s = null; try { FileInputStream stream = new FileInputStream(file_name); Reader reader = new BufferedReader(new InputStreamReader(stream)); StringBuilder builder = new StringBuilder(); char[] buffer = new char[8192]; int read; while ((read = reader.read(buffer, 0, buffer.length)) > 0) { builder.append(buffer, 0, read); } stream.close(); s = builder.toString(); } catch (Exception ex) { } return OperatorImportFromWkt.local().execute(0, Geometry.Type.Unknown, s, null); } #location 19 #vulnerability type RESOURCE_LEAK
#fixed code public static Geometry loadGeometryFromWKTFileDbg(String file_name) { if (file_name == null) { throw new IllegalArgumentException(); } String s = null; Reader reader = null; try { FileInputStream stream = new FileInputStream(file_name); reader = new BufferedReader(new InputStreamReader(stream)); StringBuilder builder = new StringBuilder(); char[] buffer = new char[8192]; int read; while ((read = reader.read(buffer, 0, buffer.length)) > 0) { builder.append(buffer, 0, read); } s = builder.toString(); } catch (Exception ex) { } finally { if (reader != null) { try { reader.close(); } catch (IOException e) { } } } return OperatorImportFromWkt.local().execute(0, Geometry.Type.Unknown, s, null); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static MapGeometry loadGeometryFromJSONFileDbg(String file_name) { if (file_name == null) { throw new IllegalArgumentException(); } String jsonString = null; try { FileInputStream stream = new FileInputStream(file_name); Reader reader = new BufferedReader(new InputStreamReader(stream)); StringBuilder builder = new StringBuilder(); char[] buffer = new char[8192]; int read; while ((read = reader.read(buffer, 0, buffer.length)) > 0) { builder.append(buffer, 0, read); } stream.close(); jsonString = builder.toString(); } catch (Exception ex) { } MapGeometry mapGeom = OperatorImportFromJson.local().execute(Geometry.Type.Unknown, jsonString); return mapGeom; } #location 19 #vulnerability type RESOURCE_LEAK
#fixed code public static MapGeometry loadGeometryFromJSONFileDbg(String file_name) { if (file_name == null) { throw new IllegalArgumentException(); } String jsonString = null; Reader reader = null; try { FileInputStream stream = new FileInputStream(file_name); reader = new BufferedReader(new InputStreamReader(stream)); StringBuilder builder = new StringBuilder(); char[] buffer = new char[8192]; int read; while ((read = reader.read(buffer, 0, buffer.length)) > 0) { builder.append(buffer, 0, read); } jsonString = builder.toString(); } catch (Exception ex) { } finally { if (reader != null) { try { reader.close(); } catch (IOException e) { } } } MapGeometry mapGeom = OperatorImportFromJson.local().execute(Geometry.Type.Unknown, jsonString); return mapGeom; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testGetSingleFileGzip() throws Exception { final DefaultHttpClient client = new DefaultHttpClient(); client.addResponseInterceptor(new HttpResponseInterceptor() { public void process(final HttpResponse r, final HttpContext context) throws HttpException, IOException { assertEquals(200, r.getStatusLine().getStatusCode()); assertNotNull(r.getHeaders(HttpHeaders.CONTENT_ENCODING)); assertEquals(1, r.getHeaders(HttpHeaders.CONTENT_ENCODING).length); assertEquals("gzip", r.getHeaders(HttpHeaders.CONTENT_ENCODING)[0].getValue()); client.removeResponseInterceptorByClass(this.getClass()); } }); Sardine sardine = new SardineImpl(client); sardine.enableCompression(); // final String url = "http://sardine.googlecode.com/svn/trunk/README.html"; final String url = "http://sudo.ch/dav/anon/sardine/single/file"; final InputStream in = sardine.get(url); assertNotNull(in); assertNotNull(in.read()); try { in.close(); } catch (EOFException e) { fail("Issue https://issues.apache.org/jira/browse/HTTPCLIENT-1075 pending"); } } #location 20 #vulnerability type RESOURCE_LEAK
#fixed code @Test public void testGetSingleFileGzip() throws Exception { final HttpClientBuilder client = HttpClientBuilder.create(); client.addInterceptorFirst(new HttpResponseInterceptor() { public void process(final HttpResponse r, final HttpContext context) throws HttpException, IOException { assertEquals(200, r.getStatusLine().getStatusCode()); assertNotNull(r.getHeaders(HttpHeaders.CONTENT_ENCODING)); assertEquals(1, r.getHeaders(HttpHeaders.CONTENT_ENCODING).length); assertEquals("gzip", r.getHeaders(HttpHeaders.CONTENT_ENCODING)[0].getValue()); } }); Sardine sardine = new SardineImpl(client); sardine.enableCompression(); // final String url = "http://sardine.googlecode.com/svn/trunk/README.html"; final String url = "http://sudo.ch/dav/anon/sardine/single/file"; final InputStream in = sardine.get(url); assertNotNull(in); assertNotNull(in.read()); try { in.close(); } catch (EOFException e) { fail("Issue https://issues.apache.org/jira/browse/HTTPCLIENT-1075 pending"); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testGetRange() throws Exception { final DefaultHttpClient client = new DefaultHttpClient(); client.addResponseInterceptor(new HttpResponseInterceptor() { public void process(final HttpResponse r, final HttpContext context) throws HttpException, IOException { // Verify partial content response assertEquals(206, r.getStatusLine().getStatusCode()); assertNotNull(r.getHeaders(HttpHeaders.CONTENT_RANGE)); assertEquals(1, r.getHeaders(HttpHeaders.CONTENT_RANGE).length); client.removeResponseInterceptorByClass(this.getClass()); } }); Sardine sardine = new SardineImpl(client); // mod_dav supports Range headers for GET final String url = "http://sudo.ch/dav/anon/sardine/single/file"; // Resume final Map<String, String> header = Collections.singletonMap(HttpHeaders.RANGE, "bytes=" + 1 + "-"); final InputStream in = sardine.get(url, header); assertNotNull(in); } #location 21 #vulnerability type RESOURCE_LEAK
#fixed code @Test public void testGetRange() throws Exception { final HttpClientBuilder client = HttpClientBuilder.create(); client.addInterceptorFirst(new HttpResponseInterceptor() { public void process(final HttpResponse r, final HttpContext context) throws HttpException, IOException { // Verify partial content response assertEquals(206, r.getStatusLine().getStatusCode()); assertNotNull(r.getHeaders(HttpHeaders.CONTENT_RANGE)); assertEquals(1, r.getHeaders(HttpHeaders.CONTENT_RANGE).length); } }); Sardine sardine = new SardineImpl(client); // mod_dav supports Range headers for GET final String url = "http://sudo.ch/dav/anon/sardine/single/file"; // Resume final Map<String, String> header = Collections.singletonMap(HttpHeaders.RANGE, "bytes=" + 1 + "-"); final InputStream in = sardine.get(url, header); assertNotNull(in); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testBasicPreemptiveAuth() throws Exception { final DefaultHttpClient client = new DefaultHttpClient(); final CountDownLatch count = new CountDownLatch(1); client.setCredentialsProvider(new BasicCredentialsProvider() { @Override public Credentials getCredentials(AuthScope authscope) { // Set flag that credentials have been used indicating preemptive authentication count.countDown(); return new Credentials() { public Principal getUserPrincipal() { return new BasicUserPrincipal("anonymous"); } public String getPassword() { return "invalid"; } }; } }); SardineImpl sardine = new SardineImpl(client); URI url = URI.create("http://sudo.ch/dav/basic/"); //Send basic authentication header in initial request sardine.enablePreemptiveAuthentication(url.getHost()); try { sardine.list(url.toString()); fail("Expected authorization failure"); } catch (SardineException e) { // Expect Authorization Failed assertEquals(401, e.getStatusCode()); // Make sure credentials have been queried assertEquals("No preemptive authentication attempt", 0, count.getCount()); } } #location 33 #vulnerability type RESOURCE_LEAK
#fixed code @Test public void testBasicPreemptiveAuth() throws Exception { final HttpClientBuilder client = HttpClientBuilder.create(); final CountDownLatch count = new CountDownLatch(1); client.setDefaultCredentialsProvider(new BasicCredentialsProvider() { @Override public Credentials getCredentials(AuthScope authscope) { // Set flag that credentials have been used indicating preemptive authentication count.countDown(); return new Credentials() { public Principal getUserPrincipal() { return new BasicUserPrincipal("anonymous"); } public String getPassword() { return "invalid"; } }; } }); SardineImpl sardine = new SardineImpl(client); URI url = URI.create("http://sudo.ch/dav/basic/"); //Send basic authentication header in initial request sardine.enablePreemptiveAuthentication(url.getHost()); try { sardine.list(url.toString()); fail("Expected authorization failure"); } catch (SardineException e) { // Expect Authorization Failed assertEquals(401, e.getStatusCode()); // Make sure credentials have been queried assertEquals("No preemptive authentication attempt", 0, count.getCount()); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testPutRange() throws Exception { final DefaultHttpClient client = new DefaultHttpClient(); Sardine sardine = new SardineImpl(client); // mod_dav supports Range headers for PUT final String url = "http://sudo.ch/dav/anon/sardine/" + UUID.randomUUID().toString(); client.addResponseInterceptor(new HttpResponseInterceptor() { public void process(final HttpResponse r, final HttpContext context) throws HttpException, IOException { assertEquals(201, r.getStatusLine().getStatusCode()); client.removeResponseInterceptorByClass(this.getClass()); } }); sardine.put(url, new ByteArrayInputStream("Te".getBytes("UTF-8"))); try { // Append to existing file final Map<String, String> header = Collections.singletonMap(HttpHeaders.CONTENT_RANGE, "bytes " + 2 + "-" + 3 + "/" + 4); client.addRequestInterceptor(new HttpRequestInterceptor() { public void process(final HttpRequest r, final HttpContext context) throws HttpException, IOException { assertNotNull(r.getHeaders(HttpHeaders.CONTENT_RANGE)); assertEquals(1, r.getHeaders(HttpHeaders.CONTENT_RANGE).length); client.removeRequestInterceptorByClass(this.getClass()); } }); client.addResponseInterceptor(new HttpResponseInterceptor() { public void process(final HttpResponse r, final HttpContext context) throws HttpException, IOException { assertEquals(204, r.getStatusLine().getStatusCode()); client.removeResponseInterceptorByClass(this.getClass()); } }); sardine.put(url, new ByteArrayInputStream("st".getBytes("UTF-8")), header); assertEquals("Test", new BufferedReader(new InputStreamReader(sardine.get(url), "UTF-8")).readLine()); } finally { sardine.delete(url); } } #location 47 #vulnerability type RESOURCE_LEAK
#fixed code @Test public void testPutRange() throws Exception { final HttpClientBuilder client = HttpClientBuilder.create(); client.addInterceptorFirst(new HttpResponseInterceptor() { public void process(final HttpResponse r, final HttpContext context) throws HttpException, IOException { assertEquals(201, r.getStatusLine().getStatusCode()); } }); Sardine sardine = new SardineImpl(client); // mod_dav supports Range headers for PUT final String url = "http://sudo.ch/dav/anon/sardine/" + UUID.randomUUID().toString(); sardine.put(url, new ByteArrayInputStream("Te".getBytes("UTF-8"))); try { // Append to existing file final Map<String, String> header = Collections.singletonMap(HttpHeaders.CONTENT_RANGE, "bytes " + 2 + "-" + 3 + "/" + 4); client.addInterceptorFirst(new HttpRequestInterceptor() { public void process(final HttpRequest r, final HttpContext context) throws HttpException, IOException { assertNotNull(r.getHeaders(HttpHeaders.CONTENT_RANGE)); assertEquals(1, r.getHeaders(HttpHeaders.CONTENT_RANGE).length); } }); client.addInterceptorFirst(new HttpResponseInterceptor() { public void process(final HttpResponse r, final HttpContext context) throws HttpException, IOException { assertEquals(204, r.getStatusLine().getStatusCode()); } }); sardine.put(url, new ByteArrayInputStream("st".getBytes("UTF-8")), header); assertEquals("Test", new BufferedReader(new InputStreamReader(sardine.get(url), "UTF-8")).readLine()); } finally { sardine.delete(url); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testBasicPreemptiveAuthHeader() throws Exception { final DefaultHttpClient client = new DefaultHttpClient(); client.addRequestInterceptor(new HttpRequestInterceptor() { public void process(final HttpRequest r, final HttpContext context) throws HttpException, IOException { assertNotNull(r.getHeaders(HttpHeaders.AUTHORIZATION)); assertEquals(1, r.getHeaders(HttpHeaders.AUTHORIZATION).length); client.removeRequestInterceptorByClass(this.getClass()); } }); Sardine sardine = new SardineImpl(client); sardine.setCredentials("anonymous", null); // mod_dav supports Range headers for PUT final URI url = URI.create("http://sardine.googlecode.com/svn/trunk/README.html"); sardine.enablePreemptiveAuthentication(url.getHost()); assertTrue(sardine.exists(url.toString())); } #location 19 #vulnerability type RESOURCE_LEAK
#fixed code @Test public void testBasicPreemptiveAuthHeader() throws Exception { final HttpClientBuilder client = HttpClientBuilder.create(); client.addInterceptorFirst(new HttpRequestInterceptor() { public void process(final HttpRequest r, final HttpContext context) throws HttpException, IOException { assertNotNull(r.getHeaders(HttpHeaders.AUTHORIZATION)); assertEquals(1, r.getHeaders(HttpHeaders.AUTHORIZATION).length); } }); Sardine sardine = new SardineImpl(client); sardine.setCredentials("anonymous", null); // mod_dav supports Range headers for PUT final URI url = URI.create("http://sardine.googlecode.com/svn/trunk/README.html"); sardine.enablePreemptiveAuthentication(url.getHost()); assertTrue(sardine.exists(url.toString())); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void TestEmptyDefaultsConfig(){ String expectedConfigDirectory = "."; ServerPaths serverPaths = mock(ServerPaths.class); when(serverPaths.getConfigDir()).thenReturn(expectedConfigDirectory); SlackNotificationMainSettings whms = new SlackNotificationMainSettings(server, serverPaths); whms.register(); whms.readFrom(getEmptyDefaultsConfigElement()); String proxy = whms.getProxyForUrl("http://something.somecompany.com"); SlackNotificationProxyConfig whpc = whms.getProxyConfigForUrl("http://something.somecompany.com"); assertTrue(proxy.equals(this.proxyHost)); assertTrue(whpc.getProxyHost().equals(this.proxyHost )); assertTrue(whpc.getProxyPort().equals(this.proxyPort)); assertTrue(whms.getDefaultChannel().equals(this.defaultChannel)); assertTrue(whms.getTeamName().equals(this.teamName)); assertTrue(whms.getToken().equals(this.token)); assertTrue(whms.getIconUrl().equals(this.iconUrl)); assertTrue(whms.getBotName().equals(this.botName)); assertNull(whms.getShowBuildAgent()); assertNull(whms.getShowElapsedBuildTime()); assertTrue(whms.getShowCommits()); assertEquals(5, whms.getMaxCommitsToDisplay()); } #location 13 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void TestEmptyDefaultsConfig(){ String expectedConfigDirectory = "."; ServerPaths serverPaths = mock(ServerPaths.class); when(serverPaths.getConfigDir()).thenReturn(expectedConfigDirectory); SlackNotificationMainSettings whms = new SlackNotificationMainSettings(server, serverPaths); whms.register(); whms.readFrom(getEmptyDefaultsConfigElement()); String proxy = whms.getProxy(); SlackNotificationProxyConfig whpc = whms.getProxyConfig(); assertTrue(proxy.equals(this.proxyHost)); assertTrue(whpc.getProxyHost().equals(this.proxyHost )); assertTrue(whpc.getProxyPort().equals(this.proxyPort)); assertTrue(whms.getDefaultChannel().equals(this.defaultChannel)); assertTrue(whms.getTeamName().equals(this.teamName)); assertTrue(whms.getToken().equals(this.token)); assertTrue(whms.getIconUrl().equals(this.iconUrl)); assertTrue(whms.getBotName().equals(this.botName)); assertNull(whms.getShowBuildAgent()); assertNull(whms.getShowElapsedBuildTime()); assertTrue(whms.getShowCommits()); assertEquals(5, whms.getMaxCommitsToDisplay()); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public SlackNotification createMockNotification(String teamName, String defaultChannel, String botName, String token, String iconUrl, Integer maxCommitsToDisplay, Boolean showElapsedBuildTime, Boolean showBuildAgent, Boolean showCommits, Boolean showCommitters) { SlackNotification notification = new SlackNotificationImpl(defaultChannel); notification.setTeamName(teamName); notification.setBotName(botName); notification.setToken(token); notification.setIconUrl(iconUrl); notification.setMaxCommitsToDisplay(maxCommitsToDisplay); notification.setShowElapsedBuildTime(showElapsedBuildTime); notification.setShowBuildAgent(showBuildAgent); notification.setShowCommits(showCommits); notification.setShowCommitters(showCommitters); notification.setPayload(payloadManager.buildFinished(null, null)); return notification; } #location 16 #vulnerability type NULL_DEREFERENCE
#fixed code public SlackNotification createMockNotification(String teamName, String defaultChannel, String botName, String token, String iconUrl, Integer maxCommitsToDisplay, Boolean showElapsedBuildTime, Boolean showBuildAgent, Boolean showCommits, Boolean showCommitters) { SlackNotification notification = new SlackNotificationImpl(defaultChannel); notification.setTeamName(teamName); notification.setBotName(botName); notification.setToken(token); notification.setIconUrl(iconUrl); notification.setMaxCommitsToDisplay(maxCommitsToDisplay); notification.setShowElapsedBuildTime(showElapsedBuildTime); notification.setShowBuildAgent(showBuildAgent); notification.setShowCommits(showCommits); notification.setShowCommitters(showCommitters); SlackNotificationPayloadContent payload = new SlackNotificationPayloadContent(); payload.setAgentName("Build Agent 1"); payload.setBranchDisplayName("master"); payload.setBranchIsDefault(true); payload.setBuildDescriptionWithLinkSyntax(String.format("<http://buildserver/builds/|Failed - My Awesome Build #5>")); payload.setBuildFullName("The Awesome Build"); payload.setBuildId("b123"); payload.setBuildName("My Awesome Build"); payload.setBuildResult("Failed"); payload.setBuildStatusUrl("http://buildserver/builds"); payload.setBuildTypeId("b123"); payload.setColor("danger"); List<Commit> commits = new ArrayList<Commit>(); commits.add(new Commit("a5bdc78", "Bug fix for that awful thing", "jbloggs", "jbloggs")); commits.add(new Commit("cc4500d", "New feature that rocks", "bbrave", "bbrave")); commits.add(new Commit("abb23b4", "Merge of branch xyz", "ddruff", "ddruff")); payload.setCommits(commits); payload.setElapsedTime(13452); payload.setFirstFailedBuild(true); payload.setIsComplete(true); payload.setText("My Awesome build"); notification.setPayload(payload); return notification; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void doPost(SlackNotification notification){ try { if (notification.isEnabled()){ notification.post(); if (notification.getResponse() != null && !notification.getResponse().getOk()) { Loggers.SERVER.error(this.getClass().getSimpleName() + " :: SlackNotification failed : " + notification.getChannel() + " returned error " + notification.getResponse().getError() + " " + notification.getErrorReason()); } else { Loggers.SERVER.info(this.getClass().getSimpleName() + " :: SlackNotification delivered : " + notification.getChannel() + " returned " + notification.getStatus() + " " + notification.getErrorReason()); } Loggers.SERVER.debug(this.getClass().getSimpleName() + ":doPost :: content dump: " + notification.getPayload()); if (notification.isErrored()){ Loggers.SERVER.error(notification.getErrorReason()); } if ((notification.getStatus() == null || notification.getStatus() > HttpStatus.SC_OK)) Loggers.ACTIVITIES.warn("SlackNotificationListener :: " + notification.getParam("projectId") + " SlackNotification (url: " + notification.getChannel() + " proxy: " + notification.getProxyHost() + ":" + notification.getProxyPort()+") returned HTTP status " + notification.getStatus().toString()); } else { Loggers.SERVER.debug("SlackNotification NOT triggered: " + notification.getParam("buildStatus") + " " + notification.getChannel()); } } catch (FileNotFoundException e) { Loggers.SERVER.warn(this.getClass().getName() + ":doPost :: " + "A FileNotFoundException occurred while attempting to execute SlackNotification (" + notification.getChannel() + "). See the following stacktrace"); Loggers.SERVER.warn(e); } catch (IOException e) { Loggers.SERVER.warn(this.getClass().getName() + ":doPost :: " + "An IOException occurred while attempting to execute SlackNotification (" + notification.getChannel() + "). See the following stacktrace"); Loggers.SERVER.warn(e); } } #location 22 #vulnerability type NULL_DEREFERENCE
#fixed code public void doPost(SlackNotification notification){ try { if (notification.isEnabled() && ( notification.getFilterBranchName().equalsIgnoreCase(notification.getBranchDisplayName()) || notification.getFilterBranchName().equalsIgnoreCase("<default>") && notification.getPayload() != null && notification.getPayload().getBranchIsDefault() )) { notification.post(); if (notification.getResponse() != null && !notification.getResponse().getOk()) { Loggers.SERVER.error(this.getClass().getSimpleName() + " :: SlackNotification failed : " + notification.getChannel() + " returned error " + notification.getResponse().getError() + " " + notification.getErrorReason()); } else { Loggers.SERVER.info(this.getClass().getSimpleName() + " :: SlackNotification delivered : " + notification.getChannel() + " returned " + notification.getStatus() + " " + notification.getErrorReason()); } Loggers.SERVER.debug(this.getClass().getSimpleName() + ":doPost :: content dump: " + notification.getPayload()); if (notification.isErrored()){ Loggers.SERVER.error(notification.getErrorReason()); } if ((notification.getStatus() == null || notification.getStatus() > HttpStatus.SC_OK)) Loggers.ACTIVITIES.warn("SlackNotificationListener :: " + notification.getParam("projectId") + " SlackNotification (url: " + notification.getChannel() + " proxy: " + notification.getProxyHost() + ":" + notification.getProxyPort()+") returned HTTP status " + notification.getStatus()); } else { Loggers.SERVER.info("SlackNotification NOT triggered: " + notification.getParam("buildStatus") + " " + notification.getChannel() + " isEnabled: " + notification.isEnabled() + " filterBranchName: " + notification.getFilterBranchName() + " branchDisplayName: " + notification.getBranchDisplayName()); } } catch (FileNotFoundException e) { Loggers.SERVER.warn(this.getClass().getName() + ":doPost :: " + "A FileNotFoundException occurred while attempting to execute SlackNotification (" + notification.getChannel() + "). See the following stacktrace"); Loggers.SERVER.warn(e); } catch (IOException e) { Loggers.SERVER.warn(this.getClass().getName() + ":doPost :: " + "An IOException occurred while attempting to execute SlackNotification (" + notification.getChannel() + "). See the following stacktrace"); Loggers.SERVER.warn(e); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void TestFullConfig(){ String expectedConfigDirectory = "."; ServerPaths serverPaths = mock(ServerPaths.class); when(serverPaths.getConfigDir()).thenReturn(expectedConfigDirectory); SlackNotificationMainSettings whms = new SlackNotificationMainSettings(server, serverPaths); whms.register(); whms.readFrom(getFullConfigElement()); String proxy = whms.getProxyForUrl("http://something.somecompany.com"); SlackNotificationProxyConfig whpc = whms.getProxyConfigForUrl("http://something.somecompany.com"); assertTrue(proxy.equals(this.proxyHost)); assertTrue(whpc.getProxyHost().equals(this.proxyHost )); assertTrue(whpc.getProxyPort().equals(this.proxyPort)); assertTrue(whms.getDefaultChannel().equals(this.defaultChannel)); assertTrue(whms.getTeamName().equals(this.teamName)); assertTrue(whms.getToken().equals(this.token)); assertTrue(whms.getIconUrl().equals(this.iconUrl)); assertTrue(whms.getBotName().equals(this.botName)); assertTrue(whms.getShowBuildAgent()); assertTrue(whms.getShowElapsedBuildTime()); assertFalse(whms.getShowCommits()); assertEquals(15, whms.getMaxCommitsToDisplay()); Credentials credentials = whpc.getCreds(); assertEquals("some-username", credentials.getUserPrincipal().getName()); assertEquals("some-password", credentials.getPassword()); } #location 13 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void TestFullConfig(){ String expectedConfigDirectory = "."; ServerPaths serverPaths = mock(ServerPaths.class); when(serverPaths.getConfigDir()).thenReturn(expectedConfigDirectory); SlackNotificationMainSettings whms = new SlackNotificationMainSettings(server, serverPaths); whms.register(); whms.readFrom(getFullConfigElement()); String proxy = whms.getProxy(); SlackNotificationProxyConfig whpc = whms.getProxyConfig(); assertTrue(proxy.equals(this.proxyHost)); assertTrue(whpc.getProxyHost().equals(this.proxyHost )); assertTrue(whpc.getProxyPort().equals(this.proxyPort)); assertTrue(whms.getDefaultChannel().equals(this.defaultChannel)); assertTrue(whms.getTeamName().equals(this.teamName)); assertTrue(whms.getToken().equals(this.token)); assertTrue(whms.getIconUrl().equals(this.iconUrl)); assertTrue(whms.getBotName().equals(this.botName)); assertTrue(whms.getShowBuildAgent()); assertTrue(whms.getShowElapsedBuildTime()); assertFalse(whms.getShowCommits()); assertEquals(15, whms.getMaxCommitsToDisplay()); Credentials credentials = whpc.getCreds(); assertEquals("some-username", credentials.getUserPrincipal().getName()); assertEquals("some-password", credentials.getPassword()); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code RleWeightedInput[] prepareRleWeights(List<Map<String, Object>> data, long degreeCutoff, Double skipValue) { RleWeightedInput[] inputs = new RleWeightedInput[data.size()]; int idx = 0; for (Map<String, Object> row : data) { List<Number> weightList = extractValues(row.get("weights")); int size = weightList.size(); if (size > degreeCutoff) { double[] weights = Weights.buildRleWeights(weightList, REPEAT_CUTOFF); inputs[idx++] = skipValue == null ? new RleWeightedInput((Long) row.get("item"), weights, size) : new RleWeightedInput((Long) row.get("item"), weights, size, skipValue); } } if (idx != inputs.length) inputs = Arrays.copyOf(inputs, idx); Arrays.sort(inputs); return inputs; } #location 11 #vulnerability type NULL_DEREFERENCE
#fixed code Long getDegreeCutoff(ProcedureConfiguration configuration) { return configuration.get("degreeCutoff", 0L); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void onRunEnd() { try { final long duration = (System.currentTimeMillis() - this.startTime) / 1000; final StringTemplateGroup group = new StringTemplateGroup("mutation_test"); final StringTemplate st = group .getInstanceOf("templates/mutation/mutation_index"); final BufferedWriter bw = new BufferedWriter(new FileWriter( this.reportDir.getAbsolutePath() + File.separatorChar + "index.html")); st.setAttribute("summaryList", this.summaryData); st.setAttribute("errors", this.errors); st.setAttribute("numberOfMutations", this.mutatorScores.getTotalMutations()); st.setAttribute("numberOfDetectedMutations", this.mutatorScores.getTotalDetectedMutations()); st.setAttribute("duration", duration); st.setAttribute("mutatorScores", this.mutatorScores); bw.write(st.toString()); bw.close(); } catch (final IOException e) { // TODO Auto-generated catch block e.printStackTrace(); } } #location 21 #vulnerability type RESOURCE_LEAK
#fixed code public void onRunEnd() { try { final long duration = (System.currentTimeMillis() - this.startTime) / 1000; final StringTemplateGroup group = new StringTemplateGroup("mutation_test"); final StringTemplate st = group .getInstanceOf("templates/mutation/mutation_index"); final Writer writer = this.outputStrategy .createWriterForFile("index.html"); st.setAttribute("summaryList", this.summaryData); st.setAttribute("errors", this.errors); st.setAttribute("numberOfMutations", this.mutatorScores.getTotalMutations()); st.setAttribute("numberOfDetectedMutations", this.mutatorScores.getTotalDetectedMutations()); st.setAttribute("duration", duration); st.setAttribute("mutatorScores", this.mutatorScores); writer.write(st.toString()); writer.close(); } catch (final IOException e) { e.printStackTrace(); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void run() { ServerSocket socket = null; try { socket = new ServerSocket(this.port); final Socket clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); final DataInputStream is = new DataInputStream(bif); Description d = null; final CoverageStatistics cs = new CoverageStatistics(); byte control = is.readByte(); while (control != CoveragePipe.DONE) { switch (control) { case CoveragePipe.CLAZZ: final int id = is.readInt(); final String name = is.readUTF(); final int newId = cs.registerClass(name); if (id != newId) { throw new PitError("Coverage id out of sync"); } break; case CoveragePipe.LINE: final int classId = is.readInt(); final int lineId = is.readInt(); cs.visitLine(classId, lineId); break; case CoveragePipe.OUTCOME: final boolean isGreen = is.readBoolean(); final long executionTime = is.readLong(); final CoverageResult cr = new CoverageResult(d, executionTime, isGreen, cs.getClassStatistics()); this.handler.apply(cr); cs.clearCoverageStats(); break; case CoveragePipe.TEST_CHANGE: final int index = is.readInt(); d = this.tus.get(index).getDescription(); break; case CoveragePipe.DONE: } control = is.readByte(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { if (socket != null) { try { socket.close(); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } } } #location 25 #vulnerability type RESOURCE_LEAK
#fixed code @Override public void run() { ServerSocket socket = null; Socket clientSocket = null; try { socket = new ServerSocket(this.port); clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); sendTests(clientSocket); final DataInputStream is = new DataInputStream(bif); receiveCoverage(is); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { try { if (clientSocket != null) { clientSocket.close(); } if (socket != null) { socket.close(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void run() { ServerSocket socket = null; try { socket = new ServerSocket(this.port); final Socket clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); final DataInputStream is = new DataInputStream(bif); Description d = null; final CoverageStatistics cs = new CoverageStatistics(); byte control = is.readByte(); while (control != CoveragePipe.DONE) { switch (control) { case CoveragePipe.CLAZZ: final int id = is.readInt(); final String name = is.readUTF(); final int newId = cs.registerClass(name); if (id != newId) { throw new PitError("Coverage id out of sync"); } break; case CoveragePipe.LINE: final int classId = is.readInt(); final int lineId = is.readInt(); cs.visitLine(classId, lineId); break; case CoveragePipe.OUTCOME: final boolean isGreen = is.readBoolean(); final long executionTime = is.readLong(); final CoverageResult cr = new CoverageResult(d, executionTime, isGreen, cs.getClassStatistics()); this.handler.apply(cr); cs.clearCoverageStats(); break; case CoveragePipe.TEST_CHANGE: final int index = is.readInt(); d = this.tus.get(index).getDescription(); break; case CoveragePipe.DONE: } control = is.readByte(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { if (socket != null) { try { socket.close(); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } } } #location 63 #vulnerability type RESOURCE_LEAK
#fixed code @Override public void run() { ServerSocket socket = null; Socket clientSocket = null; try { socket = new ServerSocket(this.port); clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); sendTests(clientSocket); final DataInputStream is = new DataInputStream(bif); receiveCoverage(is); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { try { if (clientSocket != null) { clientSocket.close(); } if (socket != null) { socket.close(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private String findPathToJarFileFromClasspath() { final String[] classPath = System.getProperty("java.class.path").split( File.pathSeparator); for (final String root : classPath) { if (JAR_REGEX.matcher(root).matches()) { return root; } } return null; } #location 2 #vulnerability type NULL_DEREFERENCE
#fixed code private String findPathToJarFileFromClasspath() { final String[] classPath = getClassPath().split(File.pathSeparator); for (final String root : classPath) { if (JAR_REGEX.matcher(root).matches()) { return root; } } return null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void processMetaData(final MutationMetaData value) { try { this.mutatorScores.registerResults(value.getMutations()); final String css = FileUtil.readToString(IsolationUtils .getContextClassLoader().getResourceAsStream( "templates/mutation/style.css")); final int lineCoverage = calculateLineCoverage(value); final MutationTestSummaryData summaryData = new MutationTestSummaryData( value.getMutatedClass(), value.getTestClasses(), value.getPercentageMutationCoverage(), lineCoverage); collectSummaryData(summaryData); final String fileName = summaryData.getFileName(); final BufferedWriter bf = new BufferedWriter(new FileWriter( this.reportDir.getAbsolutePath() + File.separatorChar + fileName)); final StringTemplateGroup group = new StringTemplateGroup("mutation_test"); final StringTemplate st = group .getInstanceOf("templates/mutation/mutation_report"); st.setAttribute("css", css); st.setAttribute("summary", summaryData); st.setAttribute("tests", value.getTargettedTests()); st.setAttribute("mutators", value.getConfig().getMutatorNames()); final Collection<SourceFile> sourceFiles = createAnnotatedSoureFiles(value); st.setAttribute("sourceFiles", sourceFiles); st.setAttribute("mutatedClasses", value.getMutatedClass()); // st.setAttribute("groups", groups); bf.write(st.toString()); bf.close(); } catch (final IOException ex) { ex.printStackTrace(); } } #location 41 #vulnerability type RESOURCE_LEAK
#fixed code private void processMetaData(final MutationMetaData value) { try { this.mutatorScores.registerResults(value.getMutations()); final String css = FileUtil.readToString(IsolationUtils .getContextClassLoader().getResourceAsStream( "templates/mutation/style.css")); final int lineCoverage = calculateLineCoverage(value); final MutationTestSummaryData summaryData = new MutationTestSummaryData( value.getMutatedClass(), value.getTestClasses(), value.getPercentageMutationCoverage(), lineCoverage); collectSummaryData(summaryData); final String fileName = summaryData.getFileName(); final Writer writer = this.outputStrategy.createWriterForFile(fileName); final StringTemplateGroup group = new StringTemplateGroup("mutation_test"); final StringTemplate st = group .getInstanceOf("templates/mutation/mutation_report"); st.setAttribute("css", css); st.setAttribute("summary", summaryData); st.setAttribute("tests", value.getTargettedTests()); st.setAttribute("mutators", value.getConfig().getMutatorNames()); final Collection<SourceFile> sourceFiles = createAnnotatedSoureFiles(value); st.setAttribute("sourceFiles", sourceFiles); st.setAttribute("mutatedClasses", value.getMutatedClass()); // st.setAttribute("groups", groups); writer.write(st.toString()); writer.close(); } catch (final IOException ex) { ex.printStackTrace(); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void run() { ServerSocket socket = null; try { socket = new ServerSocket(this.port); final Socket clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); final DataInputStream is = new DataInputStream(bif); Description d = null; final CoverageStatistics cs = new CoverageStatistics(); byte control = is.readByte(); while (control != CoveragePipe.DONE) { switch (control) { case CoveragePipe.CLAZZ: final int id = is.readInt(); final String name = is.readUTF(); final int newId = cs.registerClass(name); if (id != newId) { throw new PitError("Coverage id out of sync"); } break; case CoveragePipe.LINE: final int classId = is.readInt(); final int lineId = is.readInt(); cs.visitLine(classId, lineId); break; case CoveragePipe.OUTCOME: final boolean isGreen = is.readBoolean(); final long executionTime = is.readLong(); final CoverageResult cr = new CoverageResult(d, executionTime, isGreen, cs.getClassStatistics()); this.handler.apply(cr); cs.clearCoverageStats(); break; case CoveragePipe.TEST_CHANGE: final int index = is.readInt(); d = this.tus.get(index).getDescription(); break; case CoveragePipe.DONE: } control = is.readByte(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { if (socket != null) { try { socket.close(); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } } } #location 60 #vulnerability type RESOURCE_LEAK
#fixed code @Override public void run() { ServerSocket socket = null; Socket clientSocket = null; try { socket = new ServerSocket(this.port); clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); sendTests(clientSocket); final DataInputStream is = new DataInputStream(bif); receiveCoverage(is); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { try { if (clientSocket != null) { clientSocket.close(); } if (socket != null) { socket.close(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void run(final Class<?> clazz, final Class<?> test, final MethodMutatorFactory... mutators) { final ReportOptions data = new ReportOptions(); final Set<Predicate<String>> tests = Collections.singleton(Prelude .isEqualTo(test.getName())); data.setTargetTests(tests); data.setDependencyAnalysisMaxDistance(-1); final Set<Predicate<String>> mutees = Collections.singleton(Prelude .isEqualTo(clazz.getName())); data.setTargetClasses(mutees); data.setTimeoutConstant(PercentAndConstantTimeoutStrategy.DEFAULT_CONSTANT); data.setTimeoutFactor(PercentAndConstantTimeoutStrategy.DEFAULT_FACTOR); final ArrayList<Predicate<String>> inScope = new ArrayList<Predicate<String>>(); inScope.addAll(mutees); inScope.addAll(tests); data.setClassesInScope(inScope); final CoverageDatabase coverageDatabase = new DefaultCoverageDatabase( this.config, new ClassPath(), new JavaAgentJarFinder(), data); coverageDatabase.initialise(); final Collection<ClassGrouping> codeClasses = coverageDatabase .getGroupedClasses(); final MutationEngine engine = DefaultMutationConfigFactory.createEngine( false, False.<String> instance(), Collections.<String> emptyList(), mutators); final MutationConfig mutationConfig = new MutationConfig(engine, Collections.<String> emptyList()); final MutationTestBuilder builder = new MutationTestBuilder(mutationConfig, UnfilteredMutationFilter.factory(), this.config, data, new JavaAgentJarFinder()); final List<TestUnit> tus = builder.createMutationTestUnits(codeClasses, this.config, coverageDatabase); this.pit.run(this.container, tus); } #location 42 #vulnerability type NULL_DEREFERENCE
#fixed code private void run(final Class<?> clazz, final Class<?> test, final MethodMutatorFactory... mutators) { final ReportOptions data = new ReportOptions(); final Set<Predicate<String>> tests = Collections.singleton(Prelude .isEqualTo(test.getName())); data.setTargetTests(tests); data.setDependencyAnalysisMaxDistance(-1); final Set<Predicate<String>> mutees = Collections.singleton(Prelude .isEqualTo(clazz.getName())); data.setTargetClasses(mutees); data.setTimeoutConstant(PercentAndConstantTimeoutStrategy.DEFAULT_CONSTANT); data.setTimeoutFactor(PercentAndConstantTimeoutStrategy.DEFAULT_FACTOR); final ArrayList<Predicate<String>> inScope = new ArrayList<Predicate<String>>(); inScope.addAll(mutees); inScope.addAll(tests); data.setClassesInScope(inScope); final JavaAgent agent = new JarCreatingJarFinder(); try { createEngineAndRun(data, agent, mutators); } finally { agent.close(); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void runTestInSeperateProcessForMutationRange( final MutationStatusMap mutations, final Collection<ClassName> tests) throws IOException { Collection<MutationDetails> remainingMutations = mutations .getUnrunMutations(); final MutationTestProcess worker = createWorker(tests, remainingMutations); worker.start(); setFirstMutationToStatusOfStartedInCaseSlaveFailsAtBoot(mutations, remainingMutations); final ExitCode exitCode = waitForSlaveToDie(worker); worker.results(mutations); correctResultForProcessExitCode(mutations, exitCode); } #location 16 #vulnerability type NULL_DEREFERENCE
#fixed code private void runTestInSeperateProcessForMutationRange( final MutationStatusMap mutations, final Collection<ClassName> tests) throws IOException, InterruptedException { Collection<MutationDetails> remainingMutations = mutations .getUnrunMutations(); final MutationTestProcess worker = createWorker(tests, remainingMutations); worker.start(); setFirstMutationToStatusOfStartedInCaseSlaveFailsAtBoot(mutations, remainingMutations); final ExitCode exitCode = waitForSlaveToDie(worker); worker.results(mutations); correctResultForProcessExitCode(mutations, exitCode); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void main(final String[] args) { ExitCode exitCode = ExitCode.OK; Socket s = null; CoveragePipe invokeQueue = null; try { final int port = Integer.valueOf(args[0]); s = new Socket("localhost", port); final SafeDataInputStream dis = new SafeDataInputStream( s.getInputStream()); final SlaveArguments paramsFromParent = dis.read(SlaveArguments.class); Log.setVerbose(paramsFromParent.isVerbose()); final DataOutputStream dos = new DataOutputStream( new BufferedOutputStream(s.getOutputStream())); invokeQueue = new CoveragePipe(dos); CodeCoverageStore.init(invokeQueue); HotSwapAgent.addTransformer(new CoverageTransformer(paramsFromParent .getFilter())); final List<TestUnit> tus = getTestsFromParent(dis); LOG.info(tus.size() + " tests received"); final CoverageWorker worker = new CoverageWorker(invokeQueue, tus); worker.run(); } catch (final Throwable ex) { LOG.log(Level.SEVERE, "Error calculating coverage. Process will exit.", ex); ex.printStackTrace(); exitCode = ExitCode.UNKNOWN_ERROR; } finally { if (invokeQueue != null) { invokeQueue.end(); } try { if (s != null) { s.close(); } } catch (final IOException e) { throw translateCheckedException(e); } } System.exit(exitCode.getCode()); } #location 44 #vulnerability type RESOURCE_LEAK
#fixed code public static void main(final String[] args) { ExitCode exitCode = ExitCode.OK; Socket s = null; CoveragePipe invokeQueue = null; try { final int port = Integer.valueOf(args[0]); s = new Socket("localhost", port); final SafeDataInputStream dis = new SafeDataInputStream( s.getInputStream()); final SlaveArguments paramsFromParent = dis.read(SlaveArguments.class); Log.setVerbose(paramsFromParent.isVerbose()); final DataOutputStream dos = new DataOutputStream( new BufferedOutputStream(s.getOutputStream())); invokeQueue = new CoveragePipe(dos); CodeCoverageStore.init(invokeQueue); HotSwapAgent.addTransformer(new CoverageTransformer(paramsFromParent .getFilter())); final List<TestUnit> tus = getTestsFromParent(dis, paramsFromParent); LOG.info(tus.size() + " tests received"); final CoverageWorker worker = new CoverageWorker(invokeQueue, tus); worker.run(); } catch (final Throwable ex) { LOG.log(Level.SEVERE, "Error calculating coverage. Process will exit.", ex); ex.printStackTrace(); exitCode = ExitCode.UNKNOWN_ERROR; } finally { if (invokeQueue != null) { invokeQueue.end(); } try { if (s != null) { s.close(); } } catch (final IOException e) { throw translateCheckedException(e); } } System.exit(exitCode.getCode()); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void testDetectsMixOfKilledSurvivingAndUncoveredMutants() throws Exception { executeTarget("mutationCoverage"); FileInputStream fis = new FileInputStream(findOutput()); String actual = FileUtil.readToString(fis); assertXpathExists("//mutation[@status='KILLED']", actual); assertXpathExists("//mutation[@status='NO_COVERAGE']", actual); assertXpathExists("//mutation[@status='SURVIVED']", actual); } #location 5 #vulnerability type RESOURCE_LEAK
#fixed code public void testDetectsMixOfKilledSurvivingAndUncoveredMutants() throws Exception { // executeTarget("mutationCoverage"); // FileInputStream fis = new FileInputStream(findOutput()); // String actual = FileUtil.readToString(fis); // assertXpathExists("//mutation[@status='KILLED']", actual); // assertXpathExists("//mutation[@status='NO_COVERAGE']", actual); // assertXpathExists("//mutation[@status='SURVIVED']", actual); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void main(final String[] args) { ExitCode exitCode = ExitCode.OK; Socket s = null; try { final File input = new File(args[0]); LOG.fine("Input file is " + input); final BufferedReader br = new BufferedReader(new InputStreamReader( new FileInputStream(input))); final SlaveArguments paramsFromParent = (SlaveArguments) IsolationUtils .fromTransportString(br.readLine()); System.setProperties(paramsFromParent.getSystemProperties()); Log.setVerbose(paramsFromParent.isVerbose()); br.close(); HotSwapAgent.addTransformer(new CoverageTransformer(paramsFromParent .getFilter())); s = new Socket("localhost", paramsFromParent.getPort()); final List<TestUnit> tus = getTestsFromParent(s); LOG.info(tus.size() + " tests received"); final CoverageWorker worker = new CoverageWorker(s.getOutputStream(), tus); worker.run(); } catch (final Throwable ex) { LOG.log(Level.SEVERE, "Error calculating coverage. Process will exit.", ex); ex.printStackTrace(); exitCode = ExitCode.UNKNOWN_ERROR; } finally { try { if (s != null) { s.close(); } } catch (final IOException e) { throw translateCheckedException(e); } } System.exit(exitCode.getCode()); } #location 35 #vulnerability type RESOURCE_LEAK
#fixed code public static void main(final String[] args) { ExitCode exitCode = ExitCode.OK; Socket s = null; try { final int port = Integer.valueOf(args[0]); s = new Socket("localhost", port); final SafeDataInputStream dis = new SafeDataInputStream( s.getInputStream()); final SlaveArguments paramsFromParent = dis.read(SlaveArguments.class); System.setProperties(paramsFromParent.getSystemProperties()); Log.setVerbose(paramsFromParent.isVerbose()); HotSwapAgent.addTransformer(new CoverageTransformer(paramsFromParent .getFilter())); final List<TestUnit> tus = getTestsFromParent(dis); LOG.info(tus.size() + " tests received"); final CoverageWorker worker = new CoverageWorker(s.getOutputStream(), tus); worker.run(); } catch (final Throwable ex) { LOG.log(Level.SEVERE, "Error calculating coverage. Process will exit.", ex); ex.printStackTrace(); exitCode = ExitCode.UNKNOWN_ERROR; } finally { try { if (s != null) { s.close(); } } catch (final IOException e) { throw translateCheckedException(e); } } System.exit(exitCode.getCode()); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void main(final String[] args) { ExitCode exitCode = ExitCode.OK; Socket s = null; CoveragePipe invokeQueue = null; try { final int port = Integer.valueOf(args[0]); s = new Socket("localhost", port); final SafeDataInputStream dis = new SafeDataInputStream( s.getInputStream()); final CoverageOptions paramsFromParent = dis.read(CoverageOptions.class); Log.setVerbose(paramsFromParent.isVerbose()); final DataOutputStream dos = new DataOutputStream( new BufferedOutputStream(s.getOutputStream())); invokeQueue = new CoveragePipe(dos); CodeCoverageStore.init(invokeQueue); HotSwapAgent.addTransformer(new CoverageTransformer( convertToJVMClassFilter(paramsFromParent.getFilter()))); final List<TestUnit> tus = getTestsFromParent(dis, paramsFromParent); LOG.info(tus.size() + " tests received"); final CoverageWorker worker = new CoverageWorker(invokeQueue, tus); worker.run(); } catch (final Throwable ex) { LOG.log(Level.SEVERE, "Error calculating coverage. Process will exit.", ex); ex.printStackTrace(); exitCode = ExitCode.UNKNOWN_ERROR; } finally { if (invokeQueue != null) { invokeQueue.end(); } try { if (s != null) { s.close(); } } catch (final IOException e) { throw translateCheckedException(e); } } System.exit(exitCode.getCode()); } #location 44 #vulnerability type RESOURCE_LEAK
#fixed code public static void main(final String[] args) { ExitCode exitCode = ExitCode.OK; Socket s = null; CoveragePipe invokeQueue = null; try { final int port = Integer.valueOf(args[0]); s = new Socket("localhost", port); final SafeDataInputStream dis = new SafeDataInputStream( s.getInputStream()); final CoverageOptions paramsFromParent = dis.read(CoverageOptions.class); Log.setVerbose(paramsFromParent.isVerbose()); if (paramsFromParent.getPitConfig().verifyEnvironment().hasSome()) { throw paramsFromParent.getPitConfig().verifyEnvironment().value(); } final DataOutputStream dos = new DataOutputStream( new BufferedOutputStream(s.getOutputStream())); invokeQueue = new CoveragePipe(dos); CodeCoverageStore.init(invokeQueue); HotSwapAgent.addTransformer(new CoverageTransformer( convertToJVMClassFilter(paramsFromParent.getFilter()))); final List<TestUnit> tus = getTestsFromParent(dis, paramsFromParent); LOG.info(tus.size() + " tests received"); final CoverageWorker worker = new CoverageWorker(invokeQueue, tus); worker.run(); } catch (final Throwable ex) { LOG.log(Level.SEVERE, "Error calculating coverage. Process will exit.", ex); ex.printStackTrace(); exitCode = ExitCode.UNKNOWN_ERROR; } finally { if (invokeQueue != null) { invokeQueue.end(); } try { if (s != null) { s.close(); } } catch (final IOException e) { throw translateCheckedException(e); } } System.exit(exitCode.getCode()); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void runTestInSeperateProcessForMutationRange( final MutationStatusMap mutations, final Collection<ClassName> tests) throws IOException { Collection<MutationDetails> remainingMutations = mutations .getUnrunMutations(); final MutationTestProcess worker = createWorker(tests, remainingMutations); worker.start(); setFirstMutationToStatusOfStartedInCaseSlaveFailsAtBoot(mutations, remainingMutations); final ExitCode exitCode = waitForSlaveToDie(worker); worker.results(mutations); correctResultForProcessExitCode(mutations, exitCode); } #location 14 #vulnerability type RESOURCE_LEAK
#fixed code private void runTestInSeperateProcessForMutationRange( final MutationStatusMap mutations, final Collection<ClassName> tests) throws IOException, InterruptedException { Collection<MutationDetails> remainingMutations = mutations .getUnrunMutations(); final MutationTestProcess worker = createWorker(tests, remainingMutations); worker.start(); setFirstMutationToStatusOfStartedInCaseSlaveFailsAtBoot(mutations, remainingMutations); final ExitCode exitCode = waitForSlaveToDie(worker); worker.results(mutations); correctResultForProcessExitCode(mutations, exitCode); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static byte[] classAsBytes(final String className) throws ClassNotFoundException { try { final URL resource = ClassUtils.class.getClassLoader().getResource( convertClassNameToFileName(className)); final BufferedInputStream stream = new BufferedInputStream( resource.openStream()); final byte[] result = new byte[resource.openConnection() .getContentLength()]; int i; int counter = 0; while ((i = stream.read()) != -1) { result[counter] = (byte) i; counter++; } return result; } catch (final IOException e) { throw new ClassNotFoundException("", e); } } #location 18 #vulnerability type RESOURCE_LEAK
#fixed code public static byte[] classAsBytes(final String className) throws ClassNotFoundException { try { final URL resource = ClassUtils.class.getClassLoader().getResource( convertClassNameToFileName(className)); final BufferedInputStream stream = new BufferedInputStream( resource.openStream()); final byte[] result = new byte[resource.openConnection() .getContentLength()]; int i; int counter = 0; while ((i = stream.read()) != -1) { result[counter] = (byte) i; counter++; } stream.close(); return result; } catch (final IOException e) { throw new ClassNotFoundException("", e); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void run() { ServerSocket socket = null; try { socket = new ServerSocket(this.port); final Socket clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); final DataInputStream is = new DataInputStream(bif); Description d = null; final CoverageStatistics cs = new CoverageStatistics(); byte control = is.readByte(); while (control != CoveragePipe.DONE) { switch (control) { case CoveragePipe.CLAZZ: final int id = is.readInt(); final String name = is.readUTF(); final int newId = cs.registerClass(name); if (id != newId) { throw new PitError("Coverage id out of sync"); } break; case CoveragePipe.LINE: final int classId = is.readInt(); final int lineId = is.readInt(); cs.visitLine(classId, lineId); break; case CoveragePipe.OUTCOME: final boolean isGreen = is.readBoolean(); final long executionTime = is.readLong(); final CoverageResult cr = new CoverageResult(d, executionTime, isGreen, cs.getClassStatistics()); this.handler.apply(cr); cs.clearCoverageStats(); break; case CoveragePipe.TEST_CHANGE: final int index = is.readInt(); d = this.tus.get(index).getDescription(); break; case CoveragePipe.DONE: } control = is.readByte(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { if (socket != null) { try { socket.close(); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } } } #location 65 #vulnerability type RESOURCE_LEAK
#fixed code @Override public void run() { ServerSocket socket = null; Socket clientSocket = null; try { socket = new ServerSocket(this.port); clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); sendTests(clientSocket); final DataInputStream is = new DataInputStream(bif); receiveCoverage(is); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { try { if (clientSocket != null) { clientSocket.close(); } if (socket != null) { socket.close(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private String getGeneratedManifestAttribute(final String key) throws IOException, FileNotFoundException { final Option<String> actual = this.testee.getJarLocation(); final File f = new File(actual.value()); final JarInputStream jis = new JarInputStream(new FileInputStream(f)); final Manifest m = jis.getManifest(); final Attributes a = m.getMainAttributes(); final String am = a.getValue(key); return am; } #location 6 #vulnerability type RESOURCE_LEAK
#fixed code private String getGeneratedManifestAttribute(final String key) throws IOException, FileNotFoundException { final Option<String> actual = this.testee.getJarLocation(); final File f = new File(actual.value()); final JarInputStream jis = new JarInputStream(new FileInputStream(f)); final Manifest m = jis.getManifest(); final Attributes a = m.getMainAttributes(); final String am = a.getValue(key); jis.close(); return am; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void shouldPrintScoresFourToALine() { final ByteArrayOutputStream s = new ByteArrayOutputStream(); final PrintStream out = new PrintStream(s); this.testee.report(out); final String actual = new String(s.toByteArray()); final String[] ss = actual.split(StringUtil.newLine()); assertEquals("> foo", ss[0]); assertEquals("> KILLED 0 SURVIVED 0 TIMED_OUT 0 NON_VIABLE 0 ", ss[1]); } #location 5 #vulnerability type RESOURCE_LEAK
#fixed code @Test public void shouldPrintScoresFourToALine() { final String[] ss = generateReportLines(); assertEquals("> KILLED 0 SURVIVED 0 TIMED_OUT 0 NON_VIABLE 0 ", ss[2]); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void main(final String[] args) { addMemoryWatchDog(); Writer w = null; try { final File input = new File(args[0]); LOG.fine("Input file is " + input); final BufferedReader br = new BufferedReader(new InputStreamReader( new FileInputStream(input))); final SlaveArguments paramsFromParent = (SlaveArguments) IsolationUtils .fromTransportString(br.readLine()); Log.setVerbose(paramsFromParent.isVerbose()); final File outputFile = new File(paramsFromParent.outputFileName); w = new OutputStreamWriter(new FileOutputStream(outputFile)); LOG.fine("Output file is " + outputFile); System.setProperties(paramsFromParent.systemProperties); br.close(); final F2<Class<?>, byte[], Boolean> hotswap = new F2<Class<?>, byte[], Boolean>() { public Boolean apply(final Class<?> a, final byte[] b) { return HotSwapAgent.hotSwap(a, b); } }; final Reporter r = new DefaultReporter(w); final MutationTestWorker worker = new MutationTestWorker(hotswap, paramsFromParent.config.createMutator(IsolationUtils .getContextClassLoader()), IsolationUtils.getContextClassLoader()); worker.run(paramsFromParent.mutations, r, new TimeOutDecoratedTestSource( paramsFromParent.timeoutStrategy, paramsFromParent.tests)); } catch (final Exception ex) { LOG.log(Level.WARNING, "Error during mutation test", ex); safelyCloseWriter(w); System.exit(ExitCode.UNKNOWN_ERROR.getCode()); } finally { safelyCloseWriter(w); } } #location 44 #vulnerability type RESOURCE_LEAK
#fixed code public static void main(final String[] args) { addMemoryWatchDog(); Writer w = null; Socket s = null; try { final int port = Integer.valueOf(args[0]); s = new Socket("localhost", port); final SafeDataInputStream dis = new SafeDataInputStream( s.getInputStream()); final SlaveArguments paramsFromParent = dis.read(SlaveArguments.class); Log.setVerbose(paramsFromParent.isVerbose()); final File outputFile = new File(paramsFromParent.outputFileName); w = new OutputStreamWriter(new FileOutputStream(outputFile)); LOG.fine("Output file is " + outputFile); System.setProperties(paramsFromParent.systemProperties); dis.close(); final F2<Class<?>, byte[], Boolean> hotswap = new F2<Class<?>, byte[], Boolean>() { public Boolean apply(final Class<?> a, final byte[] b) { return HotSwapAgent.hotSwap(a, b); } }; final Reporter r = new DefaultReporter(w); final MutationTestWorker worker = new MutationTestWorker(hotswap, paramsFromParent.config.createMutator(IsolationUtils .getContextClassLoader()), IsolationUtils.getContextClassLoader()); worker.run(paramsFromParent.mutations, r, new TimeOutDecoratedTestSource( paramsFromParent.timeoutStrategy, paramsFromParent.tests)); } catch (final Exception ex) { LOG.log(Level.WARNING, "Error during mutation test", ex); safelyCloseSocket(s); safelyCloseWriter(w); System.exit(ExitCode.UNKNOWN_ERROR.getCode()); } finally { safelyCloseWriter(w); safelyCloseSocket(s); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void main(final String[] args) { enablePowerMockSupport(); Socket s = null; Reporter r = null; try { final int port = Integer.valueOf(args[0]); s = new Socket("localhost", port); final SafeDataInputStream dis = new SafeDataInputStream( s.getInputStream()); final SlaveArguments paramsFromParent = dis.read(SlaveArguments.class); Log.setVerbose(paramsFromParent.isVerbose()); final F3<String, ClassLoader,byte[], Boolean> hotswap = new F3<String, ClassLoader, byte[], Boolean>() { public Boolean apply(final String clazzName, ClassLoader loader, final byte[] b) { Class<?> clazz; try { clazz = Class.forName(clazzName, false, loader); return HotSwapAgent.hotSwap(clazz, b); } catch (ClassNotFoundException e) { throw Unchecked.translateCheckedException(e); } } }; r = new DefaultReporter(s.getOutputStream()); addMemoryWatchDog(r); final ClassLoader loader = IsolationUtils.getContextClassLoader(); final MutationTestWorker worker = new MutationTestWorker(hotswap, paramsFromParent.config.createMutator(new ClassloaderByteArraySource( loader)), loader); final List<TestUnit> tests = findTestsForTestClasses(loader, paramsFromParent.testClasses, paramsFromParent.pitConfig); worker.run(paramsFromParent.mutations, r, new TimeOutDecoratedTestSource( paramsFromParent.timeoutStrategy, tests, r)); } catch (final Exception ex) { LOG.log(Level.WARNING, "Error during mutation test", ex); if (r != null) { r.done(ExitCode.UNKNOWN_ERROR); } safelyCloseSocket(s); } finally { if (r != null) { r.done(ExitCode.OK); } safelyCloseSocket(s); } } #location 29 #vulnerability type RESOURCE_LEAK
#fixed code public static void main(final String[] args) { enablePowerMockSupport(); final int port = Integer.valueOf(args[0]); Socket s = null; try { s = new Socket("localhost", port); final SafeDataInputStream dis = new SafeDataInputStream( s.getInputStream()); Reporter reporter = new DefaultReporter(s.getOutputStream()); addMemoryWatchDog(reporter); final MutationTestSlave instance = new MutationTestSlave(dis, reporter); instance.run(); } catch (final UnknownHostException ex) { LOG.log(Level.WARNING, "Error during mutation test", ex); } catch (final IOException ex) { LOG.log(Level.WARNING, "Error during mutation test", ex); } finally { if ( s != null ) { safelyCloseSocket(s); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void run() { ServerSocket socket = null; try { socket = new ServerSocket(this.port); final Socket clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); final DataInputStream is = new DataInputStream(bif); Description d = null; final CoverageStatistics cs = new CoverageStatistics(); byte control = is.readByte(); while (control != CoveragePipe.DONE) { switch (control) { case CoveragePipe.CLAZZ: final int id = is.readInt(); final String name = is.readUTF(); final int newId = cs.registerClass(name); if (id != newId) { throw new PitError("Coverage id out of sync"); } break; case CoveragePipe.LINE: final int classId = is.readInt(); final int lineId = is.readInt(); cs.visitLine(classId, lineId); break; case CoveragePipe.OUTCOME: final boolean isGreen = is.readBoolean(); final long executionTime = is.readLong(); final CoverageResult cr = new CoverageResult(d, executionTime, isGreen, cs.getClassStatistics()); this.handler.apply(cr); cs.clearCoverageStats(); break; case CoveragePipe.TEST_CHANGE: final int index = is.readInt(); d = this.tus.get(index).getDescription(); break; case CoveragePipe.DONE: } control = is.readByte(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { if (socket != null) { try { socket.close(); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } } } #location 9 #vulnerability type RESOURCE_LEAK
#fixed code @Override public void run() { ServerSocket socket = null; Socket clientSocket = null; try { socket = new ServerSocket(this.port); clientSocket = socket.accept(); final BufferedInputStream bif = new BufferedInputStream( clientSocket.getInputStream()); sendTests(clientSocket); final DataInputStream is = new DataInputStream(bif); receiveCoverage(is); } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } finally { try { if (clientSocket != null) { clientSocket.close(); } if (socket != null) { socket.close(); } } catch (final IOException e) { throw Unchecked.translateCheckedException(e); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void capitalizeTest() { assertEquals(capitalize("hola mundo abc"), "Hola mundo abc"); assertEquals(capitalize("HOLA mundO AbC"), "Hola mundo abc"); assertEquals(capitalize("Hola Mundo abC"), "Hola mundo abc"); assertEquals(capitalize(""), ""); assertEquals(capitalize("* Hola Mundo aBC"), "* hola mundo abc"); assertEquals(capitalize("iyi akşamlar", new Locale("tr")), "İyi akşamlar"); try { capitalize(null); fail("handles null?"); } catch (NullPointerException ex) { } } #location 15 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void capitalizeTest() { assertEquals(capitalize("hola mundo abc"), "Hola mundo abc"); assertEquals(capitalize("HOLA mundO AbC"), "Hola mundo abc"); assertEquals(capitalize("Hola Mundo abC"), "Hola mundo abc"); assertEquals(capitalize(" Hola Mundo abC "), "Hola mundo abc"); assertEquals(capitalize(" (hola Mundo abC) "), "(Hola mundo abc)"); assertEquals(capitalize("[HOLA Mundo abC]"), "[Hola mundo abc]"); assertEquals(capitalize("-HOLA Mundo abC-"), "-Hola mundo abc-"); assertEquals(capitalize(" ~.-(HOLA Mundo abC)-.~"), "~.-(Hola mundo abc)-.~"); assertEquals(capitalize(""), ""); assertEquals(capitalize("* Hola Mundo aBC"), "* Hola mundo abc"); assertEquals(capitalize("2020"), "2020"); assertEquals(capitalize("iyi akşamlar", new Locale("tr")), "İyi akşamlar"); try { capitalize(null); fail("handles null?"); } catch (NullPointerException ex) { } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void addProductImage(ProductImage productImage, ImageContentFile contentImage) throws ServiceException { try { /** copy to input stream **/ ByteArrayOutputStream baos = new ByteArrayOutputStream(); // Fake code simulating the copy // You can generally do better with nio if you need... // And please, unlike me, do something about the Exceptions :D byte[] buffer = new byte[1024]; int len; while ((len = contentImage.getFile().read(buffer)) > -1) { baos.write(buffer, 0, len); } baos.flush(); // Open new InputStreams using the recorded bytes // Can be repeated as many times as you wish InputStream is1 = new ByteArrayInputStream(baos.toByteArray()); InputStream is2 = new ByteArrayInputStream(baos.toByteArray()); BufferedImage bufferedImage = ImageIO.read(is2); if (bufferedImage == null) { LOGGER.error("Cannot read image format for " + productImage.getProductImage()); throw new Exception("Cannot read image format " + productImage.getProductImage()); } // contentImage.setBufferedImage(bufferedImage); contentImage.setFile(is1); // upload original -- L contentImage.setFileContentType(FileContentType.PRODUCTLG); uploadImage.addProductImage(productImage, contentImage); /* * //default large InputContentImage largeContentImage = new * InputContentImage(ImageContentType.PRODUCT); * largeContentImage.setFile(contentImage.getFile()); * largeContentImage.setDefaultImage(productImage.isDefaultImage()); * largeContentImage.setImageName(new * StringBuilder().append("L-").append(productImage.getProductImage()).toString()); * * * uploadImage.uploadProductImage(configuration, productImage, largeContentImage); */ /* * //default small InputContentImage smallContentImage = new * InputContentImage(ImageContentType.PRODUCT); * smallContentImage.setFile(contentImage.getFile()); * smallContentImage.setDefaultImage(productImage.isDefaultImage()); * smallContentImage.setImageName(new * StringBuilder().append("S-").append(productImage.getProductImage()).toString()); * * uploadImage.uploadProductImage(configuration, productImage, smallContentImage); */ // get template properties file String slargeImageHeight = configuration.getProperty(PRODUCT_IMAGE_HEIGHT_SIZE); String slargeImageWidth = configuration.getProperty(PRODUCT_IMAGE_WIDTH_SIZE); // String ssmallImageHeight = configuration.getProperty("SMALL_IMAGE_HEIGHT_SIZE"); // String ssmallImageWidth = configuration.getProperty("SMALL_IMAGE_WIDTH_SIZE"); //Resizes if (!StringUtils.isBlank(slargeImageHeight) && !StringUtils.isBlank(slargeImageWidth)) { // && // !StringUtils.isBlank(ssmallImageHeight) // && // !StringUtils.isBlank(ssmallImageWidth)) // { FileNameMap fileNameMap = URLConnection.getFileNameMap(); String contentType = fileNameMap.getContentTypeFor(contentImage.getFileName()); String extension = null; if (contentType != null) { extension = contentType.substring(contentType.indexOf("/") + 1, contentType.length()); } if (extension == null) { extension = "jpeg"; } int largeImageHeight = Integer.parseInt(slargeImageHeight); int largeImageWidth = Integer.parseInt(slargeImageWidth); if (largeImageHeight <= 0 || largeImageWidth <= 0) { String sizeMsg = "Image configuration set to an invalid value [PRODUCT_IMAGE_HEIGHT_SIZE] " + largeImageHeight + " , [PRODUCT_IMAGE_WIDTH_SIZE] " + largeImageWidth; LOGGER.error(sizeMsg); throw new ServiceException(sizeMsg); } if (!StringUtils.isBlank(configuration.getProperty(CROP_UPLOADED_IMAGES)) && configuration.getProperty(CROP_UPLOADED_IMAGES).equals(Constants.TRUE)) { // crop image ProductImageCropUtils utils = new ProductImageCropUtils(bufferedImage, largeImageWidth, largeImageHeight); if (utils.isCropeable()) { bufferedImage = utils.getCroppedImage(); } } // do not keep a large image for now, just take care of the regular image and a small image // resize large // ByteArrayOutputStream output = new ByteArrayOutputStream(); BufferedImage largeResizedImage = ProductImageSizeUtils.resizeWithRatio(bufferedImage, largeImageWidth, largeImageHeight); File tempLarge = File.createTempFile(new StringBuilder().append(productImage.getProduct().getId()) .append("tmpLarge").toString(), "." + extension); ImageIO.write(largeResizedImage, extension, tempLarge); FileInputStream isLarge = new FileInputStream(tempLarge); // IOUtils.copy(isLarge, output); ImageContentFile largeContentImage = new ImageContentFile(); largeContentImage.setFileContentType(FileContentType.PRODUCT); largeContentImage.setFileName(productImage.getProductImage()); largeContentImage.setFile(isLarge); // largeContentImage.setBufferedImage(bufferedImage); // largeContentImage.setFile(output); // largeContentImage.setDefaultImage(false); // largeContentImage.setImageName(new // StringBuilder().append("L-").append(productImage.getProductImage()).toString()); uploadImage.addProductImage(productImage, largeContentImage); // output.flush(); // output.close(); tempLarge.delete(); // now upload original /* * //resize small BufferedImage smallResizedImage = ProductImageSizeUtils.resize(cropped, * smallImageWidth, smallImageHeight); File tempSmall = File.createTempFile(new * StringBuilder().append(productImage.getProduct().getId()).append("tmpSmall").toString(), * "." + extension ); ImageIO.write(smallResizedImage, extension, tempSmall); * * //byte[] is = IOUtils.toByteArray(new FileInputStream(tempSmall)); * * FileInputStream isSmall = new FileInputStream(tempSmall); * * output = new ByteArrayOutputStream(); IOUtils.copy(isSmall, output); * * * smallContentImage = new InputContentImage(ImageContentType.PRODUCT); * smallContentImage.setFile(output); smallContentImage.setDefaultImage(false); * smallContentImage.setImageName(new * StringBuilder().append("S-").append(productImage.getProductImage()).toString()); * * uploadImage.uploadProductImage(configuration, productImage, smallContentImage); * * output.flush(); output.close(); * * tempSmall.delete(); */ } else { // small will be the same as the original contentImage.setFileContentType(FileContentType.PRODUCT); uploadImage.addProductImage(productImage, contentImage); } } catch (Exception e) { throw new ServiceException(e); } finally { try { productImage.getImage().close(); } catch (Exception ignore) { } } } #location 147 #vulnerability type RESOURCE_LEAK
#fixed code public void addProductImage(ProductImage productImage, ImageContentFile contentImage) throws ServiceException { try { /** copy to input stream **/ ByteArrayOutputStream baos = new ByteArrayOutputStream(); // Fake code simulating the copy // You can generally do better with nio if you need... // And please, unlike me, do something about the Exceptions :D byte[] buffer = new byte[1024]; int len; while ((len = contentImage.getFile().read(buffer)) > -1) { baos.write(buffer, 0, len); } baos.flush(); // Open new InputStreams using the recorded bytes // Can be repeated as many times as you wish InputStream is1 = new ByteArrayInputStream(baos.toByteArray()); InputStream is2 = new ByteArrayInputStream(baos.toByteArray()); BufferedImage bufferedImage = ImageIO.read(is2); if (bufferedImage == null) { LOGGER.error("Cannot read image format for " + productImage.getProductImage()); throw new Exception("Cannot read image format " + productImage.getProductImage()); } // contentImage.setBufferedImage(bufferedImage); contentImage.setFile(is1); // upload original -- L contentImage.setFileContentType(FileContentType.PRODUCTLG); uploadImage.addProductImage(productImage, contentImage); /* * //default large InputContentImage largeContentImage = new * InputContentImage(ImageContentType.PRODUCT); * largeContentImage.setFile(contentImage.getFile()); * largeContentImage.setDefaultImage(productImage.isDefaultImage()); * largeContentImage.setImageName(new * StringBuilder().append("L-").append(productImage.getProductImage()).toString()); * * * uploadImage.uploadProductImage(configuration, productImage, largeContentImage); */ /* * //default small InputContentImage smallContentImage = new * InputContentImage(ImageContentType.PRODUCT); * smallContentImage.setFile(contentImage.getFile()); * smallContentImage.setDefaultImage(productImage.isDefaultImage()); * smallContentImage.setImageName(new * StringBuilder().append("S-").append(productImage.getProductImage()).toString()); * * uploadImage.uploadProductImage(configuration, productImage, smallContentImage); */ // get template properties file String slargeImageHeight = configuration.getProperty(PRODUCT_IMAGE_HEIGHT_SIZE); String slargeImageWidth = configuration.getProperty(PRODUCT_IMAGE_WIDTH_SIZE); // String ssmallImageHeight = configuration.getProperty("SMALL_IMAGE_HEIGHT_SIZE"); // String ssmallImageWidth = configuration.getProperty("SMALL_IMAGE_WIDTH_SIZE"); //Resizes if (!StringUtils.isBlank(slargeImageHeight) && !StringUtils.isBlank(slargeImageWidth)) { // && // !StringUtils.isBlank(ssmallImageHeight) // && // !StringUtils.isBlank(ssmallImageWidth)) // { FileNameMap fileNameMap = URLConnection.getFileNameMap(); String contentType = fileNameMap.getContentTypeFor(contentImage.getFileName()); String extension = null; if (contentType != null) { extension = contentType.substring(contentType.indexOf('/') + 1, contentType.length()); } if (extension == null) { extension = "jpeg"; } int largeImageHeight = Integer.parseInt(slargeImageHeight); int largeImageWidth = Integer.parseInt(slargeImageWidth); if (largeImageHeight <= 0 || largeImageWidth <= 0) { String sizeMsg = "Image configuration set to an invalid value [PRODUCT_IMAGE_HEIGHT_SIZE] " + largeImageHeight + " , [PRODUCT_IMAGE_WIDTH_SIZE] " + largeImageWidth; LOGGER.error(sizeMsg); throw new ServiceException(sizeMsg); } if (!StringUtils.isBlank(configuration.getProperty(CROP_UPLOADED_IMAGES)) && configuration.getProperty(CROP_UPLOADED_IMAGES).equals(Constants.TRUE)) { // crop image ProductImageCropUtils utils = new ProductImageCropUtils(bufferedImage, largeImageWidth, largeImageHeight); if (utils.isCropeable()) { bufferedImage = utils.getCroppedImage(); } } // do not keep a large image for now, just take care of the regular image and a small image // resize large // ByteArrayOutputStream output = new ByteArrayOutputStream(); BufferedImage largeResizedImage = ProductImageSizeUtils.resizeWithRatio(bufferedImage, largeImageWidth, largeImageHeight); File tempLarge = File.createTempFile(new StringBuilder().append(productImage.getProduct().getId()) .append("tmpLarge").toString(), "." + extension); ImageIO.write(largeResizedImage, extension, tempLarge); try(FileInputStream isLarge = new FileInputStream(tempLarge)) { // IOUtils.copy(isLarge, output); ImageContentFile largeContentImage = new ImageContentFile(); largeContentImage.setFileContentType(FileContentType.PRODUCT); largeContentImage.setFileName(productImage.getProductImage()); largeContentImage.setFile(isLarge); // largeContentImage.setBufferedImage(bufferedImage); // largeContentImage.setFile(output); // largeContentImage.setDefaultImage(false); // largeContentImage.setImageName(new // StringBuilder().append("L-").append(productImage.getProductImage()).toString()); uploadImage.addProductImage(productImage, largeContentImage); // output.flush(); // output.close(); tempLarge.delete(); // now upload original /* * //resize small BufferedImage smallResizedImage = ProductImageSizeUtils.resize(cropped, * smallImageWidth, smallImageHeight); File tempSmall = File.createTempFile(new * StringBuilder().append(productImage.getProduct().getId()).append("tmpSmall").toString(), * "." + extension ); ImageIO.write(smallResizedImage, extension, tempSmall); * * //byte[] is = IOUtils.toByteArray(new FileInputStream(tempSmall)); * * FileInputStream isSmall = new FileInputStream(tempSmall); * * output = new ByteArrayOutputStream(); IOUtils.copy(isSmall, output); * * * smallContentImage = new InputContentImage(ImageContentType.PRODUCT); * smallContentImage.setFile(output); smallContentImage.setDefaultImage(false); * smallContentImage.setImageName(new * StringBuilder().append("S-").append(productImage.getProductImage()).toString()); * * uploadImage.uploadProductImage(configuration, productImage, smallContentImage); * * output.flush(); output.close(); * * tempSmall.delete(); */ } } else { // small will be the same as the original contentImage.setFileContentType(FileContentType.PRODUCT); uploadImage.addProductImage(productImage, contentImage); } } catch (Exception e) { throw new ServiceException(e); } finally { try { productImage.getImage().close(); } catch (Exception ignore) { } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public ReadableProduct populate(Product source, ReadableProduct target, MerchantStore store, Language language) throws ConversionException { Validate.notNull(pricingService, "Requires to set PricingService"); Validate.notNull(imageUtils, "Requires to set imageUtils"); Validate.notNull(language, "Language cannot be null"); try { ProductDescription description = source.getProductDescription(); Set<ProductDescription> descriptions = source.getDescriptions(); for(ProductDescription desc : descriptions) { if(desc.getLanguage()!=null && desc.getLanguage().getId().intValue() == language.getId().intValue()) { description = desc; break; } } target.setId(source.getId()); target.setAvailable(source.isAvailable()); ProductSpecification specifications = new ProductSpecification(); specifications.setHeight(source.getProductHeight()); specifications.setLength(source.getProductLength()); specifications.setWeight(source.getProductWeight()); specifications.setWidth(source.getProductWidth()); target.setProductSpecifications(specifications); target.setPreOrder(source.isPreOrder()); target.setRefSku(source.getRefSku()); target.setSortOrder(source.getSortOrder()); target.setCondition(source.getCondition()); //RENTAL if(source.getRentalDuration()!=null) { target.setRentalDuration(source.getRentalDuration()); } if(source.getRentalPeriod()!=null) { target.setRentalPeriod(source.getRentalPeriod()); } target.setRentalStatus(source.getRentalStatus()); /** * END RENTAL */ if(source.getOwner() != null) { RentalOwner owner = new RentalOwner(); owner.setId(source.getOwner().getId()); owner.setEmailAddress(source.getOwner().getEmailAddress()); owner.setFirstName(source.getOwner().getBilling().getFirstName()); owner.setLastName(source.getOwner().getBilling().getLastName()); com.salesmanager.shop.model.customer.address.Address address = new com.salesmanager.shop.model.customer.address.Address(); address.setAddress(source.getOwner().getBilling().getAddress()); address.setBillingAddress(true); address.setCity(source.getOwner().getBilling().getCity()); address.setCompany(source.getOwner().getBilling().getCompany()); address.setCountry(source.getOwner().getBilling().getCountry().getIsoCode()); address.setZone(source.getOwner().getBilling().getZone().getCode()); address.setLatitude(source.getOwner().getBilling().getLatitude()); address.setLongitude(source.getOwner().getBilling().getLongitude()); address.setPhone(source.getOwner().getBilling().getTelephone()); address.setPostalCode(source.getOwner().getBilling().getPostalCode()); owner.setAddress(address); target.setOwner(owner); } if(source.getDateAvailable() != null) { target.setDateAvailable(DateUtil.formatDate(source.getDateAvailable())); } if(source.getAuditSection()!=null) { target.setCreationDate(DateUtil.formatDate(source.getAuditSection().getDateCreated())); } if(source.getProductReviewAvg()!=null) { double avg = source.getProductReviewAvg().doubleValue(); double rating = Math.round(avg * 2) / 2.0f; target.setRating(rating); } target.setProductVirtual(source.getProductVirtual()); if(source.getProductReviewCount()!=null) { target.setRatingCount(source.getProductReviewCount().intValue()); } if(description!=null) { com.salesmanager.shop.model.catalog.product.ProductDescription tragetDescription = new com.salesmanager.shop.model.catalog.product.ProductDescription(); tragetDescription.setFriendlyUrl(description.getSeUrl()); tragetDescription.setName(description.getName()); tragetDescription.setId(description.getId()); if(!StringUtils.isBlank(description.getMetatagTitle())) { tragetDescription.setTitle(description.getMetatagTitle()); } else { tragetDescription.setTitle(description.getName()); } tragetDescription.setMetaDescription(description.getMetatagDescription()); tragetDescription.setDescription(description.getDescription()); tragetDescription.setHighlights(description.getProductHighlight()); tragetDescription.setLanguage(description.getLanguage().getCode()); target.setDescription(tragetDescription); } if(source.getManufacturer()!=null) { ManufacturerDescription manufacturer = source.getManufacturer().getDescriptions().iterator().next(); ReadableManufacturer manufacturerEntity = new ReadableManufacturer(); com.salesmanager.shop.model.catalog.manufacturer.ManufacturerDescription d = new com.salesmanager.shop.model.catalog.manufacturer.ManufacturerDescription(); d.setName(manufacturer.getName()); manufacturerEntity.setDescription(d); manufacturerEntity.setId(source.getManufacturer().getId()); manufacturerEntity.setOrder(source.getManufacturer().getOrder()); manufacturerEntity.setCode(source.getManufacturer().getCode()); target.setManufacturer(manufacturerEntity); } if(source.getType() != null) { ReadableProductType type = new ReadableProductType(); type.setId(source.getType().getId()); type.setCode(source.getType().getCode()); type.setName(source.getType().getCode());//need name target.setType(type); } Set<ProductImage> images = source.getImages(); if(images!=null && images.size()>0) { List<ReadableImage> imageList = new ArrayList<ReadableImage>(); String contextPath = imageUtils.getContextPath(); for(ProductImage img : images) { ReadableImage prdImage = new ReadableImage(); prdImage.setImageName(img.getProductImage()); prdImage.setDefaultImage(img.isDefaultImage()); StringBuilder imgPath = new StringBuilder(); imgPath.append(contextPath).append(imageUtils.buildProductImageUtils(store, source.getSku(), img.getProductImage())); prdImage.setImageUrl(imgPath.toString()); prdImage.setId(img.getId()); prdImage.setImageType(img.getImageType()); if(img.getProductImageUrl()!=null){ prdImage.setExternalUrl(img.getProductImageUrl()); } if(img.getImageType()==1 && img.getProductImageUrl()!=null) {//video prdImage.setVideoUrl(img.getProductImageUrl()); } if(prdImage.isDefaultImage()) { target.setImage(prdImage); } imageList.add(prdImage); } target .setImages(imageList); } if(!CollectionUtils.isEmpty(source.getCategories())) { ReadableCategoryPopulator categoryPopulator = new ReadableCategoryPopulator(); List<ReadableCategory> categoryList = new ArrayList<ReadableCategory>(); for(Category category : source.getCategories()) { ReadableCategory readableCategory = new ReadableCategory(); categoryPopulator.populate(category, readableCategory, store, language); categoryList.add(readableCategory); } target.setCategories(categoryList); } if(!CollectionUtils.isEmpty(source.getAttributes())) { Set<ProductAttribute> attributes = source.getAttributes(); //split read only and options Map<Long,ReadableProductAttribute> readOnlyAttributes = null; Map<Long,ReadableProductOption> selectableOptions = null; if(!CollectionUtils.isEmpty(attributes)) { for(ProductAttribute attribute : attributes) { ReadableProductOption opt = null; ReadableProductAttribute attr = null; ReadableProductOptionValue optValue = new ReadableProductOptionValue(); ReadableProductAttributeValue attrValue = new ReadableProductAttributeValue(); ProductOptionValue optionValue = attribute.getProductOptionValue(); if(attribute.getAttributeDisplayOnly()) {//read only attribute if(readOnlyAttributes==null) { readOnlyAttributes = new TreeMap<Long,ReadableProductAttribute>(); } attr = readOnlyAttributes.get(attribute.getProductOption().getId()); if(attr==null) { attr = createAttribute(attribute, language); } if(attr!=null) { readOnlyAttributes.put(attribute.getProductOption().getId(), attr); } attrValue.setDefaultValue(attribute.getAttributeDefault()); if(attribute.getProductOptionValue()!=null) { attrValue.setId(attribute.getProductOptionValue().getId());//id of the option value } else { attrValue.setId(attribute.getId()); } attrValue.setLang(language.getCode()); attrValue.setSortOrder(0); if(attribute.getProductOptionSortOrder()!=null) { attrValue.setSortOrder(attribute.getProductOptionSortOrder().intValue()); } List<ProductOptionValueDescription> podescriptions = optionValue.getDescriptionsSettoList(); ProductOptionValueDescription podescription = null; if(podescriptions!=null && podescriptions.size()>0) { podescription = podescriptions.get(0); if(descriptions.size()>1) { for(ProductOptionValueDescription optionValueDescription : podescriptions) { if(optionValueDescription.getLanguage().getId().intValue()==language.getId().intValue()) { podescription = optionValueDescription; break; } } } } attrValue.setName(podescription.getName()); attrValue.setDescription(podescription.getDescription()); if(attr!=null) { attr.getAttributeValues().add(attrValue); } } else {//selectable option if(selectableOptions==null) { selectableOptions = new TreeMap<Long,ReadableProductOption>(); } opt = selectableOptions.get(attribute.getProductOption().getId()); if(opt==null) { opt = createOption(attribute, language); } if(opt!=null) { selectableOptions.put(attribute.getProductOption().getId(), opt); } optValue.setDefaultValue(attribute.getAttributeDefault()); optValue.setId(attribute.getProductOptionValue().getId()); optValue.setLang(language.getCode()); if(attribute.getProductAttributePrice()!=null && attribute.getProductAttributePrice().doubleValue()>0) { String formatedPrice = pricingService.getDisplayAmount(attribute.getProductAttributePrice(), store); optValue.setPrice(formatedPrice); } if(!StringUtils.isBlank(attribute.getProductOptionValue().getProductOptionValueImage())) { optValue.setImage(imageUtils.buildProductPropertyImageUtils(store, attribute.getProductOptionValue().getProductOptionValueImage())); } optValue.setSortOrder(0); if(attribute.getProductOptionSortOrder()!=null) { optValue.setSortOrder(attribute.getProductOptionSortOrder().intValue()); } List<ProductOptionValueDescription> podescriptions = optionValue.getDescriptionsSettoList(); ProductOptionValueDescription podescription = null; if(podescriptions!=null && podescriptions.size()>0) { podescription = podescriptions.get(0); if(descriptions.size()>1) { for(ProductOptionValueDescription optionValueDescription : podescriptions) { if(optionValueDescription.getLanguage().getId().intValue()==language.getId().intValue()) { podescription = optionValueDescription; break; } } } } optValue.setName(podescription.getName()); optValue.setDescription(podescription.getDescription()); if(opt!=null) { opt.getOptionValues().add(optValue); } } } } if(selectableOptions != null) { List<ReadableProductOption> options = new ArrayList<ReadableProductOption>(selectableOptions.values()); target.setOptions(options); } } //remove products from invisible category -> set visible = false /* Set<Category> categories = source.getCategories(); boolean isVisible = true; if(!CollectionUtils.isEmpty(categories)) { for(Category c : categories) { if(c.isVisible()) { isVisible = true; break; } else { isVisible = false; } } }*/ //target.setVisible(isVisible); target.setSku(source.getSku()); FinalPrice price = pricingService.calculateProductPrice(source); target.setFinalPrice(pricingService.getDisplayAmount(price.getFinalPrice(), store)); target.setPrice(price.getFinalPrice()); target.setOriginalPrice(pricingService.getDisplayAmount(price.getOriginalPrice(), store)); if(price.isDiscounted()) { target.setDiscounted(true); } //availability for(ProductAvailability availability : source.getAvailabilities()) { if(availability.getRegion().equals(Constants.ALL_REGIONS)) {//TODO REL 2.1 accept a region target.setQuantity(availability.getProductQuantity()); target.setQuantityOrderMaximum(availability.getProductQuantityOrderMax()); target.setQuantityOrderMinimum(availability.getProductQuantityOrderMin()); if(availability.getProductQuantity().intValue() > 0 && target.isAvailable()) { target.setCanBePurchased(true); } } } return target; } catch (Exception e) { throw new ConversionException(e); } } #location 15 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public ReadableProduct populate(Product source, ReadableProduct target, MerchantStore store, Language language) throws ConversionException { Validate.notNull(pricingService, "Requires to set PricingService"); Validate.notNull(imageUtils, "Requires to set imageUtils"); //Validate.notNull(language, "Language cannot be null"); try { List<com.salesmanager.shop.model.catalog.product.ProductDescription> fulldescriptions = new ArrayList<com.salesmanager.shop.model.catalog.product.ProductDescription>(); if(language == null) { target = new ReadableProductFull(); } ProductDescription description = source.getProductDescription(); if(source.getDescriptions()!=null && source.getDescriptions().size()>0) { for(ProductDescription desc : source.getDescriptions()) { if(language != null && desc.getLanguage()!=null && desc.getLanguage().getId().intValue() == language.getId().intValue()) { description = desc; break; } else { fulldescriptions.add(populateDescription(desc)); } } } target.setId(source.getId()); target.setAvailable(source.isAvailable()); ProductSpecification specifications = new ProductSpecification(); specifications.setHeight(source.getProductHeight()); specifications.setLength(source.getProductLength()); specifications.setWeight(source.getProductWeight()); specifications.setWidth(source.getProductWidth()); target.setProductSpecifications(specifications); target.setPreOrder(source.isPreOrder()); target.setRefSku(source.getRefSku()); target.setSortOrder(source.getSortOrder()); target.setCondition(source.getCondition()); //RENTAL if(source.getRentalDuration()!=null) { target.setRentalDuration(source.getRentalDuration()); } if(source.getRentalPeriod()!=null) { target.setRentalPeriod(source.getRentalPeriod()); } target.setRentalStatus(source.getRentalStatus()); /** * END RENTAL */ if(source.getOwner() != null) { RentalOwner owner = new RentalOwner(); owner.setId(source.getOwner().getId()); owner.setEmailAddress(source.getOwner().getEmailAddress()); owner.setFirstName(source.getOwner().getBilling().getFirstName()); owner.setLastName(source.getOwner().getBilling().getLastName()); com.salesmanager.shop.model.customer.address.Address address = new com.salesmanager.shop.model.customer.address.Address(); address.setAddress(source.getOwner().getBilling().getAddress()); address.setBillingAddress(true); address.setCity(source.getOwner().getBilling().getCity()); address.setCompany(source.getOwner().getBilling().getCompany()); address.setCountry(source.getOwner().getBilling().getCountry().getIsoCode()); address.setZone(source.getOwner().getBilling().getZone().getCode()); address.setLatitude(source.getOwner().getBilling().getLatitude()); address.setLongitude(source.getOwner().getBilling().getLongitude()); address.setPhone(source.getOwner().getBilling().getTelephone()); address.setPostalCode(source.getOwner().getBilling().getPostalCode()); owner.setAddress(address); target.setOwner(owner); } if(source.getDateAvailable() != null) { target.setDateAvailable(DateUtil.formatDate(source.getDateAvailable())); } if(source.getAuditSection()!=null) { target.setCreationDate(DateUtil.formatDate(source.getAuditSection().getDateCreated())); } if(source.getProductReviewAvg()!=null) { double avg = source.getProductReviewAvg().doubleValue(); double rating = Math.round(avg * 2) / 2.0f; target.setRating(rating); } target.setProductVirtual(source.getProductVirtual()); if(source.getProductReviewCount()!=null) { target.setRatingCount(source.getProductReviewCount().intValue()); } if(description!=null) { //com.salesmanager.shop.model.catalog.product.ProductDescription tragetDescription = new com.salesmanager.shop.model.catalog.product.ProductDescription(); com.salesmanager.shop.model.catalog.product.ProductDescription tragetDescription = populateDescription(description); /* tragetDescription.setFriendlyUrl(description.getSeUrl()); tragetDescription.setName(description.getName()); tragetDescription.setId(description.getId()); if(!StringUtils.isBlank(description.getMetatagTitle())) { tragetDescription.setTitle(description.getMetatagTitle()); } else { tragetDescription.setTitle(description.getName()); } tragetDescription.setMetaDescription(description.getMetatagDescription()); tragetDescription.setDescription(description.getDescription()); tragetDescription.setHighlights(description.getProductHighlight()); tragetDescription.setLanguage(description.getLanguage().getCode());*/ target.setDescription(tragetDescription); } if(source.getManufacturer()!=null) { ManufacturerDescription manufacturer = source.getManufacturer().getDescriptions().iterator().next(); ReadableManufacturer manufacturerEntity = new ReadableManufacturer(); com.salesmanager.shop.model.catalog.manufacturer.ManufacturerDescription d = new com.salesmanager.shop.model.catalog.manufacturer.ManufacturerDescription(); d.setName(manufacturer.getName()); manufacturerEntity.setDescription(d); manufacturerEntity.setId(source.getManufacturer().getId()); manufacturerEntity.setOrder(source.getManufacturer().getOrder()); manufacturerEntity.setCode(source.getManufacturer().getCode()); target.setManufacturer(manufacturerEntity); } if(source.getType() != null) { ReadableProductType type = new ReadableProductType(); type.setId(source.getType().getId()); type.setCode(source.getType().getCode()); type.setName(source.getType().getCode());//need name target.setType(type); } Set<ProductImage> images = source.getImages(); if(images!=null && images.size()>0) { List<ReadableImage> imageList = new ArrayList<ReadableImage>(); String contextPath = imageUtils.getContextPath(); for(ProductImage img : images) { ReadableImage prdImage = new ReadableImage(); prdImage.setImageName(img.getProductImage()); prdImage.setDefaultImage(img.isDefaultImage()); StringBuilder imgPath = new StringBuilder(); imgPath.append(contextPath).append(imageUtils.buildProductImageUtils(store, source.getSku(), img.getProductImage())); prdImage.setImageUrl(imgPath.toString()); prdImage.setId(img.getId()); prdImage.setImageType(img.getImageType()); if(img.getProductImageUrl()!=null){ prdImage.setExternalUrl(img.getProductImageUrl()); } if(img.getImageType()==1 && img.getProductImageUrl()!=null) {//video prdImage.setVideoUrl(img.getProductImageUrl()); } if(prdImage.isDefaultImage()) { target.setImage(prdImage); } imageList.add(prdImage); } target .setImages(imageList); } if(!CollectionUtils.isEmpty(source.getCategories())) { ReadableCategoryPopulator categoryPopulator = new ReadableCategoryPopulator(); List<ReadableCategory> categoryList = new ArrayList<ReadableCategory>(); for(Category category : source.getCategories()) { ReadableCategory readableCategory = new ReadableCategory(); categoryPopulator.populate(category, readableCategory, store, language); categoryList.add(readableCategory); } target.setCategories(categoryList); } if(!CollectionUtils.isEmpty(source.getAttributes())) { Set<ProductAttribute> attributes = source.getAttributes(); //split read only and options Map<Long,ReadableProductAttribute> readOnlyAttributes = null; Map<Long,ReadableProductOption> selectableOptions = null; if(!CollectionUtils.isEmpty(attributes)) { for(ProductAttribute attribute : attributes) { ReadableProductOption opt = null; ReadableProductAttribute attr = null; ReadableProductOptionValue optValue = new ReadableProductOptionValue(); ReadableProductAttributeValue attrValue = new ReadableProductAttributeValue(); ProductOptionValue optionValue = attribute.getProductOptionValue(); if(attribute.getAttributeDisplayOnly()) {//read only attribute if(readOnlyAttributes==null) { readOnlyAttributes = new TreeMap<Long,ReadableProductAttribute>(); } attr = readOnlyAttributes.get(attribute.getProductOption().getId()); if(attr==null) { attr = createAttribute(attribute, language); } if(attr!=null) { readOnlyAttributes.put(attribute.getProductOption().getId(), attr); } attrValue.setDefaultValue(attribute.getAttributeDefault()); if(attribute.getProductOptionValue()!=null) { attrValue.setId(attribute.getProductOptionValue().getId());//id of the option value } else { attrValue.setId(attribute.getId()); } attrValue.setLang(language.getCode()); attrValue.setSortOrder(0); if(attribute.getProductOptionSortOrder()!=null) { attrValue.setSortOrder(attribute.getProductOptionSortOrder().intValue()); } List<ProductOptionValueDescription> podescriptions = optionValue.getDescriptionsSettoList(); ProductOptionValueDescription podescription = null; if(podescriptions!=null && podescriptions.size()>0) { podescription = podescriptions.get(0); if(podescriptions.size()>1) { for(ProductOptionValueDescription optionValueDescription : podescriptions) { if(optionValueDescription.getLanguage().getId().intValue()==language.getId().intValue()) { podescription = optionValueDescription; break; } } } } attrValue.setName(podescription.getName()); attrValue.setDescription(podescription.getDescription()); if(attr!=null) { attr.getAttributeValues().add(attrValue); } } else {//selectable option if(selectableOptions==null) { selectableOptions = new TreeMap<Long,ReadableProductOption>(); } opt = selectableOptions.get(attribute.getProductOption().getId()); if(opt==null) { opt = createOption(attribute, language); } if(opt!=null) { selectableOptions.put(attribute.getProductOption().getId(), opt); } optValue.setDefaultValue(attribute.getAttributeDefault()); optValue.setId(attribute.getProductOptionValue().getId()); optValue.setLang(language.getCode()); if(attribute.getProductAttributePrice()!=null && attribute.getProductAttributePrice().doubleValue()>0) { String formatedPrice = pricingService.getDisplayAmount(attribute.getProductAttributePrice(), store); optValue.setPrice(formatedPrice); } if(!StringUtils.isBlank(attribute.getProductOptionValue().getProductOptionValueImage())) { optValue.setImage(imageUtils.buildProductPropertyImageUtils(store, attribute.getProductOptionValue().getProductOptionValueImage())); } optValue.setSortOrder(0); if(attribute.getProductOptionSortOrder()!=null) { optValue.setSortOrder(attribute.getProductOptionSortOrder().intValue()); } List<ProductOptionValueDescription> podescriptions = optionValue.getDescriptionsSettoList(); ProductOptionValueDescription podescription = null; if(podescriptions!=null && podescriptions.size()>0) { podescription = podescriptions.get(0); if(podescriptions.size()>1) { for(ProductOptionValueDescription optionValueDescription : podescriptions) { if(optionValueDescription.getLanguage().getId().intValue()==language.getId().intValue()) { podescription = optionValueDescription; break; } } } } optValue.setName(podescription.getName()); optValue.setDescription(podescription.getDescription()); if(opt!=null) { opt.getOptionValues().add(optValue); } } } } if(selectableOptions != null) { List<ReadableProductOption> options = new ArrayList<ReadableProductOption>(selectableOptions.values()); target.setOptions(options); } } //remove products from invisible category -> set visible = false /* Set<Category> categories = source.getCategories(); boolean isVisible = true; if(!CollectionUtils.isEmpty(categories)) { for(Category c : categories) { if(c.isVisible()) { isVisible = true; break; } else { isVisible = false; } } }*/ //target.setVisible(isVisible); target.setSku(source.getSku()); FinalPrice price = pricingService.calculateProductPrice(source); target.setFinalPrice(pricingService.getDisplayAmount(price.getFinalPrice(), store)); target.setPrice(price.getFinalPrice()); target.setOriginalPrice(pricingService.getDisplayAmount(price.getOriginalPrice(), store)); if(price.isDiscounted()) { target.setDiscounted(true); } //availability for(ProductAvailability availability : source.getAvailabilities()) { if(availability.getRegion().equals(Constants.ALL_REGIONS)) {//TODO REL 2.1 accept a region target.setQuantity(availability.getProductQuantity()); target.setQuantityOrderMaximum(availability.getProductQuantityOrderMax()); target.setQuantityOrderMinimum(availability.getProductQuantityOrderMin()); if(availability.getProductQuantity().intValue() > 0 && target.isAvailable()) { target.setCanBePurchased(true); } } } if(target instanceof ReadableProductFull) { ((ReadableProductFull)target).setDescriptions(fulldescriptions); } return target; } catch (Exception e) { throw new ConversionException(e); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public JSONObject actionReadFile(HttpServletRequest request, HttpServletResponse response) throws Exception { String path = getPath(request, "path"); File file = new File(docRoot.getPath() + path); if (!file.exists()) { return getErrorResponse(dictionnary.getProperty("INVALID_DIRECTORY_OR_FILE")); } if (file.isDirectory()) { return getErrorResponse(dictionnary.getProperty("FORBIDDEN_ACTION_DIR")); } if (!isAllowedName(file.getName(), false)) { return getErrorResponse(dictionnary.getProperty("INVALID_DIRECTORY_OR_FILE")); } // check if file is readable if (!file.canRead()) { return getErrorResponse(dictionnary.getProperty("NOT_ALLOWED_SYSTEM")); } String filename = file.getName(); String fileExt = filename.substring(filename.lastIndexOf(".") + 1); String mimeType = FileManagerUtils.getMimeTypeByExt(fileExt); long fileSize = file.length(); //TO DO : IMPLEMENT HTTP RANGE FOR STREAM FILE (AUDIO/VIDEO) response.setContentType(mimeType); response.setHeader("Content-Length", Long.toString(fileSize)); response.setHeader("Content-Transfer-Encoding", "binary"); response.setHeader("Content-Disposition", "inline; filename=\"" + filename + "\""); try { FileUtils.copy(new BufferedInputStream(new FileInputStream(file)), response.getOutputStream()); } catch (IOException e) { throw new Exception("Read file error: " + path, e); } return null; } #location 37 #vulnerability type RESOURCE_LEAK
#fixed code public JSONObject actionReadFile(HttpServletRequest request, HttpServletResponse response) throws Exception { String path = getPath(request, "path"); File file = new File(docRoot.getPath() + path); if (!file.exists()) { return getErrorResponse(dictionnary.getProperty("INVALID_DIRECTORY_OR_FILE")); } if (file.isDirectory()) { return getErrorResponse(dictionnary.getProperty("FORBIDDEN_ACTION_DIR")); } if (!isAllowedName(file.getName(), false)) { return getErrorResponse(dictionnary.getProperty("INVALID_DIRECTORY_OR_FILE")); } // check if file is readable if (!file.canRead()) { return getErrorResponse(dictionnary.getProperty("NOT_ALLOWED_SYSTEM")); } String filename = file.getName(); String fileExt = filename.substring(filename.lastIndexOf(".") + 1); String mimeType = FileManagerUtils.getMimeTypeByExt(fileExt); long fileSize = file.length(); //TO DO : IMPLEMENT HTTP RANGE FOR STREAM FILE (AUDIO/VIDEO) response.setContentType(mimeType); response.setHeader("Content-Length", Long.toString(fileSize)); response.setHeader("Content-Transfer-Encoding", "binary"); response.setHeader("Content-Disposition", "inline; filename=\"" + filename + "\""); try(BufferedInputStream bufferedInputStream = new BufferedInputStream(new FileInputStream(file))) { FileUtils.copy(bufferedInputStream, response.getOutputStream()); } catch (IOException e) { throw new Exception("Read file error: " + path, e); } return null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private Customer convertPersistableCustomerToCustomer(PersistableCustomer customer, MerchantStore store) { Customer cust = new Customer(); CustomerPopulator populator = new CustomerPopulator(); populator.setCountryService(countryService); populator.setCustomerOptionService(customerOptionService); populator.setCustomerOptionValueService(customerOptionValueService); populator.setLanguageService(languageService); populator.setLanguageService(languageService); populator.setZoneService(zoneService); populator.setGroupService(groupService); try{ populator.populate(customer, cust, store, store.getDefaultLanguage()); } catch (ConversionException e) { throw new ConversionRuntimeException(e); } List<Group> groups = getListOfGroups(GroupType.CUSTOMER); cust.setGroups(groups); Locale customerLocale = LocaleUtils.getLocale(cust.getDefaultLanguage()); String password = customer.getClearPassword(); if (StringUtils.isBlank(password)) { password = UserReset.generateRandomString(); customer.setClearPassword(password); } @SuppressWarnings("deprecation") String encodedPassword = passwordEncoder.encode(password); if (!StringUtils.isBlank(customer.getEncodedPassword())) { encodedPassword = customer.getEncodedPassword(); // customer.setClearPassword(""); } cust.setPassword(encodedPassword); return cust; } #location 23 #vulnerability type NULL_DEREFERENCE
#fixed code private Customer convertPersistableCustomerToCustomer(PersistableCustomer customer, MerchantStore store) { Customer cust = new Customer(); CustomerPopulator populator = new CustomerPopulator(); populator.setCountryService(countryService); populator.setCustomerOptionService(customerOptionService); populator.setCustomerOptionValueService(customerOptionValueService); populator.setLanguageService(languageService); populator.setLanguageService(languageService); populator.setZoneService(zoneService); populator.setGroupService(groupService); try{ populator.populate(customer, cust, store, store.getDefaultLanguage()); } catch (ConversionException e) { throw new ConversionRuntimeException(e); } List<Group> groups = getListOfGroups(GroupType.CUSTOMER); cust.setGroups(groups); String password = customer.getClearPassword(); if (StringUtils.isBlank(password)) { password = UserReset.generateRandomString(); customer.setClearPassword(password); } String encodedPassword = passwordEncoder.encode(password); if (!StringUtils.isBlank(customer.getEncodedPassword())) { encodedPassword = customer.getEncodedPassword(); // customer.setClearPassword(""); } cust.setPassword(encodedPassword); return cust; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @SuppressWarnings({"rawtypes", "unchecked"}) @Override public GenericEntityList listByCriteria(MerchantStoreCriteria criteria) throws ServiceException { try { StringBuilder req = new StringBuilder(); req.append( "select distinct m from MerchantStore m left join fetch m.country mc left join fetch m.parent cp left join fetch m.currency mc left join fetch m.zone mz left join fetch m.defaultLanguage md left join fetch m.languages mls"); StringBuilder countBuilder = new StringBuilder(); countBuilder.append("select count(distinct m) from MerchantStore m"); if (criteria.getCode() != null) { req.append(" where lower(m.code) like:code"); countBuilder.append(" where lower(m.code) like:code"); } if (criteria.getName() != null) { if (criteria.getCode() == null) { req.append(" where"); countBuilder.append(" where "); } else { req.append(" or"); countBuilder.append(" or "); } req.append(" lower(m.storename) like:name"); countBuilder.append(" lower(m.storename) like:name"); } if (!StringUtils.isBlank(criteria.getCriteriaOrderByField())) { req.append(" order by m." + criteria.getCriteriaOrderByField() + " " + criteria.getOrderBy().name().toLowerCase()); } Query countQ = this.em.createQuery(countBuilder.toString()); String hql = req.toString(); Query q = this.em.createQuery(hql); if (criteria.getCode() != null) { countQ.setParameter("code", "%" + criteria.getCode().toLowerCase() + "%"); q.setParameter("code", "%" + criteria.getCode().toLowerCase() + "%"); } if (criteria.getName() != null) { countQ.setParameter("name", "%" + criteria.getCode().toLowerCase() + "%"); q.setParameter("name", "%" + criteria.getCode().toLowerCase() + "%"); } if (criteria.getUser() != null) { } Number count = (Number) countQ.getSingleResult(); GenericEntityList entityList = new GenericEntityList(); entityList.setTotalCount(count.intValue()); q = RepositoryHelper.paginateQuery(q, count, entityList, criteria); /* if(criteria.isLegacyPagination()) { if (criteria.getMaxCount() > 0) { q.setFirstResult(criteria.getStartIndex()); if (criteria.getMaxCount() < count.intValue()) { q.setMaxResults(criteria.getMaxCount()); } else { q.setMaxResults(count.intValue()); } } } else { q.setFirstResult((criteria.getStartPage()-1) * criteria.getPageSize()); q.setMaxResults(criteria.getPageSize()); int lastPageNumber = (int) ((count.intValue() / criteria.getPageSize()) + 1); entityList.setTotalPage(lastPageNumber); }*/ List<MerchantStore> stores = q.getResultList(); entityList.setList(stores); return entityList; } catch (javax.persistence.NoResultException ers) { } catch (Exception e) { LOGGER.error(e.getMessage()); throw new ServiceException(e); } return null; } #location 41 #vulnerability type NULL_DEREFERENCE
#fixed code @SuppressWarnings({"rawtypes", "unchecked"}) @Override public GenericEntityList listByCriteria(MerchantStoreCriteria criteria) throws ServiceException { try { StringBuilder req = new StringBuilder(); req.append( "select distinct m from MerchantStore m left join fetch m.country mc left join fetch m.parent cp left join fetch m.currency mc left join fetch m.zone mz left join fetch m.defaultLanguage md left join fetch m.languages mls"); StringBuilder countBuilder = new StringBuilder(); countBuilder.append("select count(distinct m) from MerchantStore m"); if (criteria.getCode() != null) { req.append(" where lower(m.code) like:code"); countBuilder.append(" where lower(m.code) like:code"); } if (criteria.getName() != null) { if (criteria.getCode() == null) { req.append(" where"); countBuilder.append(" where "); } else { req.append(" or"); countBuilder.append(" or "); } req.append(" lower(m.storename) like:name"); countBuilder.append(" lower(m.storename) like:name"); } if (!StringUtils.isBlank(criteria.getCriteriaOrderByField())) { req.append(" order by m." + criteria.getCriteriaOrderByField() + " " + criteria.getOrderBy().name().toLowerCase()); } Query countQ = this.em.createQuery(countBuilder.toString()); String hql = req.toString(); Query q = this.em.createQuery(hql); if (criteria.getCode() != null) { countQ.setParameter("code", "%" + criteria.getCode().toLowerCase() + "%"); q.setParameter("code", "%" + criteria.getCode().toLowerCase() + "%"); } if (criteria.getName() != null) { countQ.setParameter("name", "%" + criteria.getCode().toLowerCase() + "%"); q.setParameter("name", "%" + criteria.getCode().toLowerCase() + "%"); } if (criteria.getUser() != null) { } Number count = (Number) countQ.getSingleResult(); GenericEntityList entityList = new GenericEntityList(); entityList.setTotalCount(count.intValue()); q = RepositoryHelper.paginateQuery(q, count, entityList, criteria); List<MerchantStore> stores = q.getResultList(); entityList.setList(stores); return entityList; } catch (javax.persistence.NoResultException ers) { } catch (Exception e) { LOGGER.error(e.getMessage()); throw new ServiceException(e); } return null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public ReadableContentPage getContentPage(String code, MerchantStore store, Language language) { Validate.notNull(code, "Content code cannot be null"); Validate.notNull(store, "MerchantStore cannot be null"); try { Content content = null; if(language == null) { Optional.ofNullable(contentService.getByCode(code, store)) .orElseThrow(() -> new ResourceNotFoundException("No page found : " + code)); } else { Optional.ofNullable(contentService.getByCode(code, store, language)) .orElseThrow(() -> new ResourceNotFoundException("No page found : " + code)); } return convertContentToReadableContentPage(store, language, content); } catch (ServiceException e) { throw new ServiceRuntimeException("Error while getting page " + e.getMessage(), e); } } #location 18 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public ReadableContentPage getContentPage(String code, MerchantStore store, Language language) { Validate.notNull(code, "Content code cannot be null"); Validate.notNull(store, "MerchantStore cannot be null"); try { Content content = null; if(language == null) { content = Optional.ofNullable(contentService.getByCode(code, store)) .orElseThrow(() -> new ResourceNotFoundException("No page found : " + code)); } else { content = Optional.ofNullable(contentService.getByCode(code, store, language)) .orElseThrow(() -> new ResourceNotFoundException("No page found : " + code)); } return convertContentToReadableContentPage(store, language, content); } catch (ServiceException e) { throw new ServiceRuntimeException("Error while getting page " + e.getMessage(), e); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void prePostProcessShippingQuotes( ShippingQuote quote, List<PackageDetails> packages, BigDecimal orderTotal, Delivery delivery, ShippingOrigin origin, MerchantStore store, IntegrationConfiguration globalShippingConfiguration, IntegrationModule currentModule, ShippingConfiguration shippingConfiguration, List<IntegrationModule> allModules, Locale locale) throws IntegrationException { Validate.notNull(delivery, "Delivery cannot be null"); Validate.notNull(currentModule, "IntegrationModule cannot be null"); Validate.notNull(delivery.getCountry(), "Delivery.country cannot be null"); Validate.notNull(allModules, "List<IntegrationModule> cannot be null"); Validate.notNull(packages, "packages cannot be null"); Validate.notEmpty(packages, "packages cannot be empty"); Double distance = null; if(quote!=null) { //look if distance has been calculated if(quote.getQuoteInformations()!=null) { if(quote.getQuoteInformations().containsKey(Constants.DISTANCE_KEY)) { distance = (Double)quote.getQuoteInformations().get(Constants.DISTANCE_KEY); } } } //calculate volume (L x W x H) Double volume = null; Double weight = 0D; Double size = null; //calculate weight, volume and largest size for(PackageDetails pack : packages) { weight = weight + pack.getShippingWeight(); Double tmpVolume = pack.getShippingHeight() * pack.getShippingLength() * pack.getShippingWidth(); if(volume == null || tmpVolume.doubleValue() > volume.doubleValue()) { //take the largest volume volume = tmpVolume; } //largest size List<Double> sizeList = new ArrayList<Double>(); sizeList.add(pack.getShippingHeight()); sizeList.add(pack.getShippingLength()); sizeList.add(pack.getShippingWidth()); Double maxSize = (Double)Collections.max(sizeList); if(size==null || maxSize.doubleValue() > size.doubleValue()) { size = maxSize.doubleValue(); } } //Build a ShippingInputParameters ShippingInputParameters inputParameters = new ShippingInputParameters(); inputParameters.setWeight((long)weight.doubleValue()); inputParameters.setCountry(delivery.getCountry().getIsoCode()); if(delivery.getZone()!=null) { inputParameters.setProvince(delivery.getZone().getCode()); } else { inputParameters.setProvince(delivery.getState()); } //inputParameters.setModuleName(currentModule.getCode()); if(delivery.getZone().getCode()!=null) { inputParameters.setProvince(delivery.getZone().getCode()); } if(size!=null) { inputParameters.setSize((long)size.doubleValue()); } if(distance!=null) { double ddistance = distance.doubleValue(); long ldistance = (long)ddistance; inputParameters.setDistance(ldistance); } if(volume!=null) { inputParameters.setVolume((long)volume.doubleValue()); } LOGGER.debug("Setting input parameters " + inputParameters.toString()); System.out.println(inputParameters.toString()); /** * New code */ KieSession kieSession=droolsBeanFactory.getKieSession(ResourceFactory.newClassPathResource("com/salesmanager/drools/rules/ShippingDecision.drl")); DecisionResponse resp = new DecisionResponse(); kieSession.insert(inputParameters); kieSession.setGlobal("decision",resp); kieSession.fireAllRules(); //System.out.println(resp.getModuleName()); inputParameters.setModuleName(resp.getModuleName()); LOGGER.debug("Using shipping nodule " + inputParameters.getModuleName()); if(!StringUtils.isBlank(inputParameters.getModuleName())) { for(IntegrationModule toBeUsed : allModules) { if(toBeUsed.getCode().equals(inputParameters.getModuleName())) { quote.setCurrentShippingModule(toBeUsed); break; } } } } #location 69 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void prePostProcessShippingQuotes( ShippingQuote quote, List<PackageDetails> packages, BigDecimal orderTotal, Delivery delivery, ShippingOrigin origin, MerchantStore store, IntegrationConfiguration globalShippingConfiguration, IntegrationModule currentModule, ShippingConfiguration shippingConfiguration, List<IntegrationModule> allModules, Locale locale) throws IntegrationException { Validate.notNull(delivery, "Delivery cannot be null"); Validate.notNull(currentModule, "IntegrationModule cannot be null"); Validate.notNull(delivery.getCountry(), "Delivery.country cannot be null"); Validate.notNull(allModules, "List<IntegrationModule> cannot be null"); Validate.notNull(packages, "packages cannot be null"); Validate.notEmpty(packages, "packages cannot be empty"); Double distance = null; if(quote!=null) { //look if distance has been calculated if(quote.getQuoteInformations()!=null) { if(quote.getQuoteInformations().containsKey(Constants.DISTANCE_KEY)) { distance = (Double)quote.getQuoteInformations().get(Constants.DISTANCE_KEY); } } } //calculate volume (L x W x H) Double volume = null; Double weight = 0D; Double size = null; //calculate weight, volume and largest size for(PackageDetails pack : packages) { weight = weight + pack.getShippingWeight(); Double tmpVolume = pack.getShippingHeight() * pack.getShippingLength() * pack.getShippingWidth(); if(volume == null || tmpVolume.doubleValue() > volume.doubleValue()) { //take the largest volume volume = tmpVolume; } //largest size List<Double> sizeList = new ArrayList<Double>(); sizeList.add(pack.getShippingHeight()); sizeList.add(pack.getShippingLength()); sizeList.add(pack.getShippingWidth()); Double maxSize = (Double)Collections.max(sizeList); if(size==null || maxSize.doubleValue() > size.doubleValue()) { size = maxSize.doubleValue(); } } //Build a ShippingInputParameters ShippingInputParameters inputParameters = new ShippingInputParameters(); inputParameters.setWeight((long)weight.doubleValue()); inputParameters.setCountry(delivery.getCountry().getIsoCode()); if(delivery.getZone()!=null && delivery.getZone().getCode()!=null) { inputParameters.setProvince(delivery.getZone().getCode()); } else { inputParameters.setProvince(delivery.getState()); } //inputParameters.setModuleName(currentModule.getCode()); if(size!=null) { inputParameters.setSize((long)size.doubleValue()); } if(distance!=null) { double ddistance = distance.doubleValue(); long ldistance = (long)ddistance; inputParameters.setDistance(ldistance); } if(volume!=null) { inputParameters.setVolume((long)volume.doubleValue()); } LOGGER.debug("Setting input parameters " + inputParameters.toString()); System.out.println(inputParameters.toString()); /** * New code */ KieSession kieSession=droolsBeanFactory.getKieSession(ResourceFactory.newClassPathResource("com/salesmanager/drools/rules/ShippingDecision.drl")); DecisionResponse resp = new DecisionResponse(); kieSession.insert(inputParameters); kieSession.setGlobal("decision",resp); kieSession.fireAllRules(); //System.out.println(resp.getModuleName()); inputParameters.setModuleName(resp.getModuleName()); LOGGER.debug("Using shipping nodule " + inputParameters.getModuleName()); if(!StringUtils.isBlank(inputParameters.getModuleName())) { for(IntegrationModule toBeUsed : allModules) { if(toBeUsed.getCode().equals(inputParameters.getModuleName())) { quote.setCurrentShippingModule(toBeUsed); break; } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @SuppressWarnings("unchecked") public JSONObject actionSaveFile(HttpServletRequest request) throws Exception { String path = getPath(request, "path"); String content = request.getParameter("content"); File file = getFile(path); if (!file.exists()) { return getErrorResponse(dictionnary.getProperty("INVALID_DIRECTORY_OR_FILE")); } if (file.isDirectory()) { return getErrorResponse(dictionnary.getProperty("NOT_ALLOWED")); } if (!hasPermission("edit") || !isEditable(file.getName())) { return getErrorResponse(dictionnary.getProperty("FORBIDDEN_ACTION_DIR")); } if (!file.canWrite()) { return getErrorResponse(dictionnary.getProperty("NOT_ALLOWED_SYSTEM")); } if (!isAllowedName(file.getName(), false)) { return getErrorResponse(dictionnary.getProperty("INVALID_DIRECTORY_OR_FILE")); } try { FileOutputStream oldFile = new FileOutputStream(file, false); oldFile.write(content.getBytes()); oldFile.close(); } catch (IOException e) { throw new Exception("Error writing modified file", e); } JSONObject result = new JSONObject(); JSONObject o = new JSONObject(getFileInfo(path)); result.put("data", o); return result; //return new JSONObject().put("data", new JSONObject(getFileInfo(path))); } #location 31 #vulnerability type RESOURCE_LEAK
#fixed code @SuppressWarnings("unchecked") public JSONObject actionSaveFile(HttpServletRequest request) throws Exception { String path = getPath(request, "path"); String content = request.getParameter("content"); File file = getFile(path); if (!file.exists()) { return getErrorResponse(dictionnary.getProperty("INVALID_DIRECTORY_OR_FILE")); } if (file.isDirectory()) { return getErrorResponse(dictionnary.getProperty("NOT_ALLOWED")); } if (!hasPermission("edit") || !isEditable(file.getName())) { return getErrorResponse(dictionnary.getProperty("FORBIDDEN_ACTION_DIR")); } if (!file.canWrite()) { return getErrorResponse(dictionnary.getProperty("NOT_ALLOWED_SYSTEM")); } if (!isAllowedName(file.getName(), false)) { return getErrorResponse(dictionnary.getProperty("INVALID_DIRECTORY_OR_FILE")); } try(FileOutputStream oldFile = new FileOutputStream(file, false)) { oldFile.write(content.getBytes()); } catch (IOException e) { throw new Exception("Error writing modified file", e); } JSONObject result = new JSONObject(); JSONObject o = new JSONObject(getFileInfo(path)); result.put("data", o); return result; //return new JSONObject().put("data", new JSONObject(getFileInfo(path))); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public Response index(LindenIndexRequest request) throws IOException { if (request.getType().equals(IndexRequestType.SWAP_INDEX)) { Response response; try { response = swapIndex(request.getIndexName()); } catch (Exception e) { LOGGER.error("Swapping index " + request.getIndexName() + " failed, " + e); throw new IOException("Swapping index " + request.getIndexName() + " failed!", e); } return response; } String indexName = request.getIndexName(); LindenCore core = currentLindenCore; if (indexName != null && !indexName.equals(currentIndexName)) { if (indexName.startsWith(NEXT_INDEX_NAME_PREFIX)) { // Accept bootstrap index request after swap is done in case something unexpected happened // that swap command is executed before bootstrap is done if (!indexName.substring(NEXT_INDEX_NAME_PREFIX.length()).equals(currentIndexTimeStamp)) { core = getLindenCore(indexName); } } else { throw new IOException("Bad index name " + indexName + " in HotSwapLindenCoreImpl."); } } return core.index(request); } #location 19 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public Response index(LindenIndexRequest request) throws IOException { if (request.getType().equals(IndexRequestType.SWAP_INDEX)) { Response response; try { response = swapIndex(request.getIndexName()); } catch (Exception e) { LOGGER.error("Swapping index " + request.getIndexName() + " failed, " + e); throw new IOException("Swapping index " + request.getIndexName() + " failed!", e); } return response; } String indexName = request.getIndexName(); LindenCore core = currentLindenCore; if (indexName != null && !indexName.equals(currentIndexName)) { if (indexName.startsWith(NEXT_INDEX_NAME_PREFIX)) { // Accept bootstrap index request after swap is done in case something unexpected happened // that swap command is executed before bootstrap is done if (!indexName.substring(NEXT_INDEX_NAME_PREFIX.length()).equals(currentIndexVersion)) { core = getLindenCore(indexName); } } else { throw new IOException("Bad index name " + indexName + " in HotSwapLindenCoreImpl."); } } return core.index(request); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void standard_syntax() throws Exception { IfStatementTree tree = parse("if ($a) {} else {}", PHPLexicalGrammar.IF_STATEMENT); assertThat(tree.is(Kind.IF_STATEMENT)).isTrue(); assertThat(tree.ifToken().text()).isEqualTo("if"); assertThat(tree.condition()).isNotNull(); assertThat(tree.statements()).hasSize(1); ElseClauseTree elseClause = tree.elseClause(); assertThat(elseClause).isNotNull(); assertThat(elseClause.is(Kind.ELSE_CLAUSE)).isTrue(); assertThat(elseClause.statements()).hasSize(1); assertThat(tree.elseifClauses()).hasSize(0); assertThat(tree.colonToken()).isNull(); assertThat(tree.endifToken()).isNull(); assertThat(tree.eosToken()).isNull(); } #location 11 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void standard_syntax() throws Exception { IfStatementTree tree = parse("if ($a) {}", PHPLexicalGrammar.IF_STATEMENT); assertThat(tree.ifToken().text()).isEqualTo("if"); assertThat(expressionToString(tree.condition())).isEqualTo("($a)"); assertThat(tree.statements()).hasSize(1); assertThat(tree.elseClause()).isNull(); assertThat(tree.elseifClauses()).hasSize(0); assertThat(tree.endifToken()).isNull(); assertThat(tree.eosToken()).isNull(); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void test_global_scope(Scope scope) { assertThat(globalSymbolA.usages()).hasSize(4); assertThat(globalSymbolB.usages()).hasSize(1); Symbol arraySymbol = scope.getSymbol("$array"); assertThat(arraySymbol.usages()).hasSize(1); assertThat(scope.getSymbol("$f").usages()).hasSize(1); assertThat(scope.getSymbol("h").usages()).hasSize(1); assertThat(scope.getSymbol("j").usages()).hasSize(1); assertThat(scope.getSymbol("$compoundVar").usages()).hasSize(2); assertThat(scope.getSymbol("$heredocVar").usages()).hasSize(2); assertThat(scope.getSymbol("$var").usages()).hasSize(2); Symbol classSymbol = scope.getSymbol("A"); assertThat(classSymbol).isNotNull(); assertThat(classSymbol.is(Kind.CLASS)).isTrue(); assertThat(classSymbol.usages()).hasSize(2); } #location 6 #vulnerability type NULL_DEREFERENCE
#fixed code private void test_global_scope(Scope scope) { assertThat(globalSymbolA.usages()).hasSize(4); assertThat(globalSymbolB.usages()).hasSize(1); Symbol arraySymbol = scope.getSymbol("$array"); assertThat(arraySymbol.usages()).hasSize(1); assertThat(scope.getSymbol("$f").usages()).hasSize(1); assertThat(scope.getSymbol("h").usages()).hasSize(1); assertThat(scope.getSymbol("j").usages()).hasSize(1); assertThat(scope.getSymbol("$compoundVar").usages()).hasSize(2); assertThat(scope.getSymbol("$heredocVar").usages()).hasSize(2); assertThat(scope.getSymbol("$var").usages()).hasSize(2); Symbol classSymbol = scope.getSymbol("A"); assertThat(classSymbol).isNotNull(); assertThat(classSymbol.is(Kind.CLASS)).isTrue(); assertThat(classSymbol.usages()).hasSize(3); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void execute() { try { // Gets the tool command line List<String> commandLine = getCommandLine(); ProcessBuilder builder = new ProcessBuilder(commandLine); LOG.info("Executing " + getExecutedTool() + " with command '{}'", prettyPrint(commandLine)); // Starts the process Process p = builder.start(); // And handles it's normal and error stream in separated threads. ByteArrayOutputStream output = new ByteArrayOutputStream(DEFAUT_BUFFER_INITIAL_SIZE); AsyncPipe outputStreamThread = new AsyncPipe(p.getInputStream(), output); outputStreamThread.start(); ByteArrayOutputStream error = new ByteArrayOutputStream(DEFAUT_BUFFER_INITIAL_SIZE); AsyncPipe errorStreamThread = new AsyncPipe(p.getErrorStream(), error); errorStreamThread.start(); LOG.info(getExecutedTool() + " ended with returned code '{}'.", p.waitFor()); } catch (IOException e) { LOG.error("Can't execute the external tool", e); throw new PhpPluginExecutionException(e); } catch (InterruptedException e) { LOG.error("Async pipe interrupted: ", e); throw new PhpPluginExecutionException(e); } } #location 13 #vulnerability type RESOURCE_LEAK
#fixed code public void execute() { List<String> commandLine = getCommandLine(); LOG.info("Executing " + getExecutedTool() + " with command '{}'", prettyPrint(commandLine)); Iterator<String> commandLineIterator = commandLine.iterator(); Command command = Command.create(commandLineIterator.next()); while (commandLineIterator.hasNext()) { command.addArgument(commandLineIterator.next()); } int exitCode = CommandExecutor.create().execute(command, configuration.getTimeout() * MINUTES_TO_MILLISECONDS); if ( !acceptedExitCodes.contains(exitCode)) { throw new SonarException(getExecutedTool() + " execution failed with returned code '" + exitCode + "'. Please check the documentation of " + getExecutedTool() + " to know more about this failure."); } else { LOG.info(getExecutedTool() + " succeeded with returned code '{}'.", exitCode); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private static boolean isArgumentOfSafeFunctionCall(Tree tree) { Tree parent = tree.getParent(); if (parent.is(Tree.Kind.FUNCTION_CALL)) { FunctionCallTree functionCall = (FunctionCallTree) parent; ExpressionTree callee = functionCall.callee(); if (callee.is(Tree.Kind.NAMESPACE_NAME)) { String qualifiedName = ((NamespaceNameTree) callee).qualifiedName(); return SAFE_FUNCTIONS.stream().anyMatch(qualifiedName::equalsIgnoreCase); } } return false; } #location 3 #vulnerability type NULL_DEREFERENCE
#fixed code private static boolean isArgumentOfSafeFunctionCall(Tree tree) { if (!tree.getParent().is(Tree.Kind.CALL_ARGUMENT) || !tree.getParent().getParent().is(Tree.Kind.FUNCTION_CALL)) { return false; } FunctionCallTree functionCall = (FunctionCallTree) tree.getParent().getParent(); ExpressionTree callee = functionCall.callee(); if (callee.is(Tree.Kind.NAMESPACE_NAME)) { String qualifiedName = ((NamespaceNameTree) callee).qualifiedName(); return SAFE_FUNCTIONS.stream().anyMatch(qualifiedName::equalsIgnoreCase); } return false; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void visitClassDeclaration(ClassDeclarationTree tree) { stringLiterals.clear(); super.visitClassDeclaration(tree); if (tree.is(Tree.Kind.CLASS_DECLARATION)) { Scope classScope = context().symbolTable().getScopeFor(tree); for (Symbol methodSymbol : classScope.getSymbols(Kind.FUNCTION)) { boolean ruleConditions = methodSymbol.hasModifier("private") && methodSymbol.usages().isEmpty(); if (ruleConditions && !isConstructor(methodSymbol.declaration(), tree) && !isMagicMethod(methodSymbol.name()) && !isUsedInStringLiteral(methodSymbol)) { context().newIssue(this, methodSymbol.declaration(), String.format(MESSAGE, methodSymbol.name())); } } } } #location 8 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void visitClassDeclaration(ClassDeclarationTree tree) { stringLiterals.clear(); super.visitClassDeclaration(tree); if (tree.is(Tree.Kind.CLASS_DECLARATION)) { checkClass(tree); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static Map<ClassSymbolData, ClassSymbol> createSymbols(Set<ClassSymbolData> fileDeclarations, ProjectSymbolData projectSymbolData) { Map<ClassSymbolData, ClassSymbolImpl> symbolsByData = new HashMap<>(); Map<ClassSymbolData, ClassSymbol> result = new HashMap<>(); Deque<ClassSymbolData> toComplete = new ArrayDeque<>(); Map<QualifiedName, ClassSymbolImpl> symbolsByQualifiedName = new HashMap<>(); fileDeclarations.forEach(data -> { ClassSymbolImpl symbol = new ClassSymbolImpl(data.location(), data.qualifiedName()); result.put(data, symbol); toComplete.push(data); symbolsByQualifiedName.put(symbol.qualifiedName, symbol); symbolsByData.put(data, symbol); }); while (!toComplete.isEmpty()) { ClassSymbolData data = toComplete.pop(); Optional<QualifiedName> superClassName = data.superClass(); if (superClassName.isPresent()) { ClassSymbolImpl superClass = symbolsByQualifiedName.get(superClassName.get()); if (superClass == null) { Optional<ClassSymbolData> superClassData = projectSymbolData.classSymbolData(superClassName.get()); if (superClassData.isPresent()) { superClass = new ClassSymbolImpl(superClassData.get().location(), superClassName.get()); toComplete.push(superClassData.get()); symbolsByQualifiedName.put(superClassName.get(), superClass); symbolsByData.put(superClassData.get(), superClass); } } symbolsByData.get(data).superClass = superClass == null ? UnknownClassSymbol.UNKNOWN : superClass; } } return result; } #location 28 #vulnerability type NULL_DEREFERENCE
#fixed code public static Map<ClassSymbolData, ClassSymbol> createSymbols(Set<ClassSymbolData> fileDeclarations, ProjectSymbolData projectSymbolData) { Map<ClassSymbolData, ClassSymbolImpl> symbolsByData = new HashMap<>(); Map<ClassSymbolData, ClassSymbol> result = new HashMap<>(); Deque<ClassSymbolData> toComplete = new ArrayDeque<>(); Map<QualifiedName, ClassSymbol> symbolsByQualifiedName = new HashMap<>(); fileDeclarations.forEach(data -> { ClassSymbolImpl symbol = new ClassSymbolImpl(data.location(), data.qualifiedName()); result.put(data, symbol); toComplete.push(data); symbolsByQualifiedName.put(symbol.qualifiedName, symbol); symbolsByData.put(data, symbol); }); while (!toComplete.isEmpty()) { ClassSymbolData data = toComplete.pop(); Optional<QualifiedName> superClassName = data.superClass(); if (superClassName.isPresent()) { ClassSymbol superClass = symbolsByQualifiedName.get(superClassName.get()); if (superClass == null) { Optional<ClassSymbolData> superClassData = projectSymbolData.classSymbolData(superClassName.get()); if (superClassData.isPresent()) { ClassSymbolImpl knownSuperClass = new ClassSymbolImpl(superClassData.get().location(), superClassName.get()); toComplete.push(superClassData.get()); symbolsByData.put(superClassData.get(), knownSuperClass); superClass = knownSuperClass; } else { superClass = new UnknownClassSymbol(superClassName.get()); } symbolsByQualifiedName.put(superClassName.get(), superClass); } symbolsByData.get(data).superClass = superClass; } } return result; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void checkCfg(ControlFlowGraph cfg) { for (CfgBlock cfgBlock : cfg.blocks()) { if (cfgBlock.successors().size() == 1 && cfgBlock.successors().contains(cfgBlock.syntacticSuccessor())) { Tree lastElement = cfgBlock.elements().get(cfgBlock.elements().size() - 1); if (lastElement.is(Kind.RETURN_STATEMENT) && (((ReturnStatementTree) lastElement).expression() != null || lastElement.getParent().is(Kind.CASE_CLAUSE, Kind.DEFAULT_CLAUSE))) { continue; } if (lastElement.is(Kind.RETURN_STATEMENT, Kind.CONTINUE_STATEMENT, Kind.GOTO_STATEMENT)) { context().newIssue(this, lastElement, MESSAGE); } } } } #location 7 #vulnerability type NULL_DEREFERENCE
#fixed code private void checkCfg(ControlFlowGraph cfg) { for (CfgBlock cfgBlock : cfg.blocks()) { if (cfgBlock.successors().size() == 1 && cfgBlock.successors().contains(cfgBlock.syntacticSuccessor())) { Tree lastElement = Iterables.getLast(cfgBlock.elements()); if (isIgnoredReturn(lastElement)) { continue; } if (lastElement.is(Kind.RETURN_STATEMENT, Kind.CONTINUE_STATEMENT, Kind.GOTO_STATEMENT)) { context().newIssue(this, lastElement, MESSAGE); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void test() throws Exception { IssueLocation issueLocation = new IssueLocation(TOKEN1, "Test message"); assertThat(issueLocation.message()).isEqualTo("Test message"); assertThat(issueLocation.startLine()).isEqualTo(5); assertThat(issueLocation.startLineOffset()).isEqualTo(10); assertThat(issueLocation.endLine()).isEqualTo(5); assertThat(issueLocation.endLineOffset()).isEqualTo(16); } #location 8 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void test() throws Exception { IssueLocation issueLocation = new IssueLocation(TOKEN1, "Test message"); assertThat(issueLocation.message()).isEqualTo("Test message"); assertThat(issueLocation.startLine()).isEqualTo(5); assertThat(issueLocation.startLineOffset()).isEqualTo(10); assertThat(issueLocation.endLine()).isEqualTo(5); assertThat(issueLocation.endLineOffset()).isEqualTo(16); assertThat(issueLocation.filePath()).isNull(); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void visitAssignmentExpression(AssignmentExpressionTree assignment) { SyntaxToken lastToken = ((PHPTree) assignment.variable()).getLastToken(); String variableName = lastToken.text(); checkVariable(lastToken, variableName, assignment.value()); super.visitAssignmentExpression(assignment); } #location 4 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void visitAssignmentExpression(AssignmentExpressionTree assignment) { checkVariable(((PHPTree) assignment.variable()).getLastToken(), assignment.value()); super.visitAssignmentExpression(assignment); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static Map<ClassSymbolData, ClassSymbol> createSymbols(Set<ClassSymbolData> fileDeclarations, ProjectSymbolData projectSymbolData) { Map<ClassSymbolData, ClassSymbolImpl> symbolsByData = new HashMap<>(); Map<ClassSymbolData, ClassSymbol> result = new HashMap<>(); Deque<ClassSymbolData> toComplete = new ArrayDeque<>(); Map<QualifiedName, ClassSymbolImpl> symbolsByQualifiedName = new HashMap<>(); fileDeclarations.forEach(data -> { ClassSymbolImpl symbol = new ClassSymbolImpl(data.qualifiedName()); result.put(data, symbol); toComplete.push(data); symbolsByQualifiedName.put(symbol.qualifiedName, symbol); symbolsByData.put(data, symbol); }); while (!toComplete.isEmpty()) { ClassSymbolData data = toComplete.pop(); Optional<QualifiedName> superClassName = data.superClass(); if (superClassName.isPresent()) { ClassSymbolImpl superClass = symbolsByQualifiedName.get(superClassName.get()); if (superClass == null) { Optional<ClassSymbolData> superClassData = projectSymbolData.classSymbolData(superClassName.get()); if (superClassData.isPresent()) { superClass = new ClassSymbolImpl(superClassName.get()); toComplete.push(superClassData.get()); symbolsByQualifiedName.put(superClassName.get(), superClass); symbolsByData.put(superClassData.get(), superClass); } } symbolsByData.get(data).superClass = superClass == null ? UnknownClassSymbol.UNKNOWN : superClass; } } return result; } #location 28 #vulnerability type NULL_DEREFERENCE
#fixed code public static Map<ClassSymbolData, ClassSymbol> createSymbols(Set<ClassSymbolData> fileDeclarations, ProjectSymbolData projectSymbolData) { Map<ClassSymbolData, ClassSymbolImpl> symbolsByData = new HashMap<>(); Map<ClassSymbolData, ClassSymbol> result = new HashMap<>(); Deque<ClassSymbolData> toComplete = new ArrayDeque<>(); Map<QualifiedName, ClassSymbolImpl> symbolsByQualifiedName = new HashMap<>(); fileDeclarations.forEach(data -> { ClassSymbolImpl symbol = new ClassSymbolImpl(data.location(), data.qualifiedName()); result.put(data, symbol); toComplete.push(data); symbolsByQualifiedName.put(symbol.qualifiedName, symbol); symbolsByData.put(data, symbol); }); while (!toComplete.isEmpty()) { ClassSymbolData data = toComplete.pop(); Optional<QualifiedName> superClassName = data.superClass(); if (superClassName.isPresent()) { ClassSymbolImpl superClass = symbolsByQualifiedName.get(superClassName.get()); if (superClass == null) { Optional<ClassSymbolData> superClassData = projectSymbolData.classSymbolData(superClassName.get()); if (superClassData.isPresent()) { superClass = new ClassSymbolImpl(superClassData.get().location(), superClassName.get()); toComplete.push(superClassData.get()); symbolsByQualifiedName.put(superClassName.get(), superClass); symbolsByData.put(superClassData.get(), superClass); } } symbolsByData.get(data).superClass = superClass == null ? UnknownClassSymbol.UNKNOWN : superClass; } } return result; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void execute() { try { // Gets the tool command line List<String> commandLine = getCommandLine(); ProcessBuilder builder = new ProcessBuilder(commandLine); LOG.info("Executing " + getExecutedTool() + " with command '{}'", prettyPrint(commandLine)); // Starts the process Process p = builder.start(); // And handles it's normal and error stream in separated threads. ByteArrayOutputStream output = new ByteArrayOutputStream(DEFAUT_BUFFER_INITIAL_SIZE); AsyncPipe outputStreamThread = new AsyncPipe(p.getInputStream(), output); outputStreamThread.start(); ByteArrayOutputStream error = new ByteArrayOutputStream(DEFAUT_BUFFER_INITIAL_SIZE); AsyncPipe errorStreamThread = new AsyncPipe(p.getErrorStream(), error); errorStreamThread.start(); LOG.info(getExecutedTool() + " ended with returned code '{}'.", p.waitFor()); } catch (IOException e) { LOG.error("Can't execute the external tool", e); throw new PhpPluginExecutionException(e); } catch (InterruptedException e) { LOG.error("Async pipe interrupted: ", e); throw new PhpPluginExecutionException(e); } } #location 17 #vulnerability type RESOURCE_LEAK
#fixed code public void execute() { List<String> commandLine = getCommandLine(); LOG.info("Executing " + getExecutedTool() + " with command '{}'", prettyPrint(commandLine)); Iterator<String> commandLineIterator = commandLine.iterator(); Command command = Command.create(commandLineIterator.next()); while (commandLineIterator.hasNext()) { command.addArgument(commandLineIterator.next()); } int exitCode = CommandExecutor.create().execute(command, configuration.getTimeout() * MINUTES_TO_MILLISECONDS); if ( !acceptedExitCodes.contains(exitCode)) { throw new SonarException(getExecutedTool() + " execution failed with returned code '" + exitCode + "'. Please check the documentation of " + getExecutedTool() + " to know more about this failure."); } else { LOG.info(getExecutedTool() + " succeeded with returned code '{}'.", exitCode); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void createTemplateParameters(File outputDir, Template template, File templatesDir) throws MojoExecutionException { JsonNodeFactory nodeFactory = JsonNodeFactory.instance; ObjectNode values = nodeFactory.objectNode(); List<io.fabric8.openshift.api.model.Parameter> parameters = template.getParameters(); if (parameters == null && parameters.isEmpty()) { return; } List<HelmParameter> helmParameters = new ArrayList<>(); for (io.fabric8.openshift.api.model.Parameter parameter : parameters) { HelmParameter helmParameter = new HelmParameter(parameter); helmParameter.addToValue(values); helmParameters.add(helmParameter); } File outputChartFile = new File(outputDir, "values.yaml"); try { saveYaml(values, outputChartFile); } catch (IOException e) { throw new MojoExecutionException("Failed to save chart values " + outputChartFile + ": " + e, e); } // now lets replace all the parameter expressions in each template File[] files = templatesDir.listFiles(); if (files != null) { for (File file : files) { if (file.isFile()) { String extension = Files.getExtension(file.getName()).toLowerCase(); if (extension.equals("yaml") || extension.equals("yml")) { convertTemplateParameterExpressionsWithHelmExpressions(file, helmParameters); } } } } } #location 5 #vulnerability type NULL_DEREFERENCE
#fixed code private void createTemplateParameters(File outputDir, Template template, File templatesDir) throws MojoExecutionException { JsonNodeFactory nodeFactory = JsonNodeFactory.instance; ObjectNode values = nodeFactory.objectNode(); List<io.fabric8.openshift.api.model.Parameter> parameters = template.getParameters(); if (parameters == null || parameters.isEmpty()) { return; } List<HelmParameter> helmParameters = new ArrayList<>(); for (io.fabric8.openshift.api.model.Parameter parameter : parameters) { HelmParameter helmParameter = new HelmParameter(parameter); helmParameter.addToValue(values); helmParameters.add(helmParameter); } File outputChartFile = new File(outputDir, "values.yaml"); try { saveYaml(values, outputChartFile); } catch (IOException e) { throw new MojoExecutionException("Failed to save chart values " + outputChartFile + ": " + e, e); } // now lets replace all the parameter expressions in each template File[] files = templatesDir.listFiles(); if (files != null) { for (File file : files) { if (file.isFile()) { String extension = Files.getExtension(file.getName()).toLowerCase(); if (extension.equals("yaml") || extension.equals("yml")) { convertTemplateParameterExpressionsWithHelmExpressions(file, helmParameters); } } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private KubernetesList convertToOpenShiftResources(KubernetesList resources) throws MojoExecutionException { KubernetesListBuilder builder = new KubernetesListBuilder(); builder.withMetadata(resources.getMetadata()); List<HasMetadata> items = resources.getItems(); List<HasMetadata> objects = new ArrayList<>(); if (items != null) { for (HasMetadata item : items) { if (item instanceof Deployment) { // if we have a Deployment and a DeploymentConfig of the same name // since we have a different manifest for OpenShift then lets filter out // the Kubernetes specific Deployment String name = KubernetesHelper.getName(item); if (hasDeploymentConfigNamed(items, name)) { continue; } } HasMetadata converted = convertKubernetesItemToOpenShift(item); if (converted != null) { objects.add(converted); } } } openshiftDependencyResources.addMissingResources(objects); if (openshiftManifest != null && openshiftManifest.isFile() && openshiftManifest.exists()) { // lets add any ImageStream / ImageStreamTag objects which are already on disk // from a previous `BuildMojo` execution KubernetesClient client = clusterAccess.createDefaultClient(log); Set<HasMetadata> oldEntities; try { oldEntities = KubernetesResourceUtil.loadResources(openshiftManifest); } catch (Exception e) { throw new MojoExecutionException("Failed to load openshift manifest " + openshiftManifest + ". " + e, e); } for (HasMetadata entity : oldEntities) { if (entity instanceof ImageStream || entity instanceof ImageStreamTag) { if (KubernetesResourceUtil.findResourceByName(objects, entity.getClass(), KubernetesHelper.getName(entity)) == null) { objects.add(entity); } } } } moveTemplatesToTopLevel(builder, objects); return builder.build(); } #location 29 #vulnerability type RESOURCE_LEAK
#fixed code private KubernetesList convertToOpenShiftResources(KubernetesList resources) throws MojoExecutionException { KubernetesListBuilder builder = new KubernetesListBuilder(); builder.withMetadata(resources.getMetadata()); List<HasMetadata> items = resources.getItems(); List<HasMetadata> objects = new ArrayList<>(); if (items != null) { for (HasMetadata item : items) { if (item instanceof Deployment) { // if we have a Deployment and a DeploymentConfig of the same name // since we have a different manifest for OpenShift then lets filter out // the Kubernetes specific Deployment String name = KubernetesHelper.getName(item); if (hasDeploymentConfigNamed(items, name)) { continue; } } HasMetadata converted = convertKubernetesItemToOpenShift(item); if (converted != null) { objects.add(converted); } } } openshiftDependencyResources.addMissingResources(objects); moveTemplatesToTopLevel(builder, objects); // TODO: Remove this ASAP when https://github.com/fabric8io/fabric8-maven-plugin/issues/678 is fixed removeInitContainers(builder, VolumePermissionEnricher.ENRICHER_NAME); return builder.build(); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void addProfiledResourcesFromSubirectories(KubernetesListBuilder builder, File resourceDir, EnricherManager enricherManager) throws IOException, MojoExecutionException { File[] profileDirs = resourceDir.listFiles(new FileFilter() { @Override public boolean accept(File pathname) { return pathname.isDirectory(); } }); for (File profileDir : profileDirs) { Profile profile = ProfileUtil.findProfile(profileDir.getName(), resourceDir); ProcessorConfig enricherConfig = profile.getEnricherConfig(); if (profile == null) { throw new MojoExecutionException(String.format("Invalid profile '%s' given as directory in %s. " + "Please either define a profile of this name or move this directory away", profileDir.getName(), resourceDir)); } File[] resourceFiles = KubernetesResourceUtil.listResourceFragments(profileDir); if (resourceFiles.length > 0) { KubernetesListBuilder profileBuilder = readResourceFragments(resourceFiles); enricherManager.createDefaultResources(enricherConfig, profileBuilder); enricherManager.enrich(enricherConfig, profileBuilder); KubernetesList profileItems = profileBuilder.build(); for (HasMetadata item : profileItems.getItems()) { builder.addToItems(item); } } } } #location 10 #vulnerability type NULL_DEREFERENCE
#fixed code private void addProfiledResourcesFromSubirectories(KubernetesListBuilder builder, File resourceDir, EnricherManager enricherManager) throws IOException, MojoExecutionException { File[] profileDirs = resourceDir.listFiles(new FileFilter() { @Override public boolean accept(File pathname) { return pathname.isDirectory(); } }); for (File profileDir : profileDirs) { Profile profile = ProfileUtil.findProfile(profileDir.getName(), resourceDir); if (profile == null) { throw new MojoExecutionException(String.format("Invalid profile '%s' given as directory in %s. " + "Please either define a profile of this name or move this directory away", profileDir.getName(), resourceDir)); } ProcessorConfig enricherConfig = profile.getEnricherConfig(); File[] resourceFiles = KubernetesResourceUtil.listResourceFragments(profileDir); if (resourceFiles.length > 0) { KubernetesListBuilder profileBuilder = readResourceFragments(resourceFiles); enricherManager.createDefaultResources(enricherConfig, profileBuilder); enricherManager.enrich(enricherConfig, profileBuilder); KubernetesList profileItems = profileBuilder.build(); for (HasMetadata item : profileItems.getItems()) { builder.addToItems(item); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void portForward(Controller controller, String podName) throws MojoExecutionException { File file = getKubeCtlExecutable(controller); String command = file.getName(); log.info("Port forwarding to port " + remoteDebugPort + " on pod " + podName + " using command: " + command); String arguments = " port-forward " + podName + " " + localDebugPort + ":" + remoteDebugPort; String commands = command + arguments; log.info("Executing command: " + commands); final String message = "port forward"; final Process process; try { process = Runtime.getRuntime().exec(file.getAbsolutePath() + arguments); Runtime.getRuntime().addShutdownHook(new Thread("mvn fabric8:run-interactive shutdown hook") { @Override public void run() { if (process != null) { log.info("Terminating port forward process:"); try { process.destroy(); } catch (Exception e) { log.error("Failed to terminate process " + message); } try { if (process != null && process.isAlive()) { process.destroyForcibly(); } } catch (Exception e) { log.error("Failed to forcibly terminate process " + message); } } } }); log.info(""); log.info("Now you can start a Remote debug execution in your IDE by using localhost and the debug port " + localDebugPort); log.info(""); processCommandAsync(process, createExternalProcessLogger("[[B]]" + command + "[[B]] "), commands, message); } catch (Exception e) { throw new MojoExecutionException("Failed to execute process " + commands + " for " + message + ": " + e, e); } } #location 38 #vulnerability type RESOURCE_LEAK
#fixed code private void portForward(Controller controller, String podName) throws MojoExecutionException { File command = getKubeCtlExecutable(controller); log.info("Port forwarding to port " + remoteDebugPort + " on pod " + podName + " using command " + command); List<String> args = new ArrayList<>(); args.add("port-forward"); args.add(podName); args.add(localDebugPort + ":" + remoteDebugPort); String commandLine = command + " " + Strings.join(args, " "); log.verbose("Executing command " + commandLine); try { log.info(""); log.info("Now you can start a Remote debug execution in your IDE by using localhost and the debug port " + localDebugPort); log.info(""); ProcessUtil.runCommand(createExternalProcessLogger("[[B]]" + command.getName() + "[[B]] "), command, args, true); } catch (Exception e) { throw new MojoExecutionException("Failed to start port forwarding with " + commandLine + ": " + e, e); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void execute() throws MojoExecutionException, MojoFailureException { File manifest = kubernetesManifest; if (!Files.isFile(manifest)) { if (failOnNoKubernetesJson) { throw new MojoFailureException("No such generated kubernetes YAML file: " + manifest); } else { getLog().warn("No such generated kubernetes YAML file: " + manifest + " for this project so ignoring"); return; } } KubernetesClient kubernetes = createKubernetesClient(); if (kubernetes.getMasterUrl() == null || Strings.isNullOrBlank(kubernetes.getMasterUrl().toString())) { throw new MojoFailureException("Cannot find Kubernetes master URL"); } getLog().info("Using kubernetes at: " + kubernetes.getMasterUrl() + " in namespace " + getNamespace() + " Kubernetes manifest: " + manifest); try { Controller controller = createController(); controller.setAllowCreate(createNewResources); controller.setServicesOnlyMode(servicesOnly); controller.setIgnoreServiceMode(ignoreServices); controller.setLogJsonDir(jsonLogDir); controller.setBasedir(getRootProjectFolder()); controller.setIgnoreRunningOAuthClients(ignoreRunningOAuthClients); controller.setProcessTemplatesLocally(processTemplatesLocally); controller.setDeletePodsOnReplicationControllerUpdate(deletePodsOnReplicationControllerUpdate); controller.setRollingUpgrade(rollingUpgrades); controller.setRollingUpgradePreserveScale(isRollingUpgradePreserveScale()); boolean openShift = KubernetesHelper.isOpenShift(kubernetes); if (openShift) { getLog().info("OpenShift platform detected"); } else { disableOpenShiftFeatures(controller); } String fileName = manifest.getName(); Object dto = KubernetesHelper.loadYaml(manifest, KubernetesResource.class); if (dto == null) { throw new MojoFailureException("Cannot load kubernetes YAML: " + manifest); } // lets check we have created the namespace String namespace = getNamespace(); controller.applyNamespace(namespace); controller.setNamespace(namespace); if (dto instanceof Template) { Template template = (Template) dto; dto = applyTemplates(template, kubernetes, controller, fileName); } Set<KubernetesResource> resources = new LinkedHashSet<>(); Set<HasMetadata> entities = new TreeSet<>(new HasMetadataComparator()); for (KubernetesResource resource : resources) { entities.addAll(KubernetesHelper.toItemList(resource)); } entities.addAll(KubernetesHelper.toItemList(dto)); if (createExternalUrls) { if (controller.getOpenShiftClientOrNull() != null) { createRoutes(controller, entities); } else { createIngress(controller, kubernetes, entities); } } // Apply all items for (HasMetadata entity : entities) { if (entity instanceof Pod) { Pod pod = (Pod) entity; controller.applyPod(pod, fileName); } else if (entity instanceof Service) { Service service = (Service) entity; controller.applyService(service, fileName); } else if (entity instanceof ReplicationController) { ReplicationController replicationController = (ReplicationController) entity; controller.applyReplicationController(replicationController, fileName); } else if (entity != null) { controller.apply(entity, fileName); } } } catch (Exception e) { throw new MojoExecutionException(e.getMessage(), e); } } #location 14 #vulnerability type RESOURCE_LEAK
#fixed code @Override public void execute() throws MojoExecutionException, MojoFailureException { KubernetesClient kubernetes = createKubernetesClient(); File manifest; String clusterKind = "Kubernetes"; if (KubernetesHelper.isOpenShift(kubernetes)) { manifest = openshiftManifest; clusterKind = "OpenShift"; } else { manifest = kubernetesManifest; } if (!Files.isFile(manifest)) { if (failOnNoKubernetesJson) { throw new MojoFailureException("No such generated manifest file: " + manifest); } else { getLog().warn("No such generated manifest file: " + manifest + " for this project so ignoring"); return; } } if (kubernetes.getMasterUrl() == null || Strings.isNullOrBlank(kubernetes.getMasterUrl().toString())) { throw new MojoFailureException("Cannot find Kubernetes master URL"); } log.info("Using " + clusterKind +" at: " + kubernetes.getMasterUrl() + " in namespace " + getNamespace() + " with manifest: " + manifest); try { Controller controller = createController(); controller.setAllowCreate(createNewResources); controller.setServicesOnlyMode(servicesOnly); controller.setIgnoreServiceMode(ignoreServices); controller.setLogJsonDir(jsonLogDir); controller.setBasedir(getRootProjectFolder()); controller.setIgnoreRunningOAuthClients(ignoreRunningOAuthClients); controller.setProcessTemplatesLocally(processTemplatesLocally); controller.setDeletePodsOnReplicationControllerUpdate(deletePodsOnReplicationControllerUpdate); controller.setRollingUpgrade(rollingUpgrades); controller.setRollingUpgradePreserveScale(isRollingUpgradePreserveScale()); boolean openShift = KubernetesHelper.isOpenShift(kubernetes); if (openShift) { getLog().info("OpenShift platform detected"); } else { disableOpenShiftFeatures(controller); } String fileName = manifest.getName(); Object dto = KubernetesHelper.loadYaml(manifest, KubernetesResource.class); if (dto == null) { throw new MojoFailureException("Cannot load kubernetes YAML: " + manifest); } // lets check we have created the namespace String namespace = getNamespace(); controller.applyNamespace(namespace); controller.setNamespace(namespace); if (dto instanceof Template) { Template template = (Template) dto; dto = applyTemplates(template, kubernetes, controller, fileName); } Set<KubernetesResource> resources = new LinkedHashSet<>(); Set<HasMetadata> entities = new TreeSet<>(new HasMetadataComparator()); for (KubernetesResource resource : resources) { entities.addAll(KubernetesHelper.toItemList(resource)); } entities.addAll(KubernetesHelper.toItemList(dto)); if (createExternalUrls) { if (controller.getOpenShiftClientOrNull() != null) { createRoutes(controller, entities); } else { createIngress(controller, kubernetes, entities); } } // Apply all items for (HasMetadata entity : entities) { if (entity instanceof Pod) { Pod pod = (Pod) entity; controller.applyPod(pod, fileName); } else if (entity instanceof Service) { Service service = (Service) entity; controller.applyService(service, fileName); } else if (entity instanceof ReplicationController) { ReplicationController replicationController = (ReplicationController) entity; controller.applyReplicationController(replicationController, fileName); } else if (entity != null) { controller.apply(entity, fileName); } } } catch (Exception e) { throw new MojoExecutionException(e.getMessage(), e); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private KubernetesList convertToOpenShiftResources(KubernetesList resources) throws MojoExecutionException { KubernetesListBuilder builder = new KubernetesListBuilder(); builder.withMetadata(resources.getMetadata()); List<HasMetadata> items = resources.getItems(); List<HasMetadata> objects = new ArrayList<>(); if (items != null) { for (HasMetadata item : items) { if (item instanceof Deployment) { // if we have a Deployment and a DeploymentConfig of the same name // since we have a different manifest for OpenShift then lets filter out // the Kubernetes specific Deployment String name = KubernetesHelper.getName(item); if (hasDeploymentConfigNamed(items, name)) { continue; } } HasMetadata converted = convertKubernetesItemToOpenShift(item); if (converted != null) { objects.add(converted); } } } openshiftDependencyResources.addMissingResources(objects); if (openshiftManifest != null && openshiftManifest.isFile() && openshiftManifest.exists()) { // lets add any ImageStream / ImageStreamTag objects which are already on disk // from a previous `BuildMojo` execution KubernetesClient client = clusterAccess.createDefaultClient(log); Set<HasMetadata> oldEntities; try { oldEntities = KubernetesResourceUtil.loadResources(openshiftManifest); } catch (Exception e) { throw new MojoExecutionException("Failed to load openshift manifest " + openshiftManifest + ". " + e, e); } for (HasMetadata entity : oldEntities) { if (entity instanceof ImageStream || entity instanceof ImageStreamTag) { if (KubernetesResourceUtil.findResourceByName(objects, entity.getClass(), KubernetesHelper.getName(entity)) == null) { objects.add(entity); } } } } moveTemplatesToTopLevel(builder, objects); return builder.build(); } #location 29 #vulnerability type RESOURCE_LEAK
#fixed code private KubernetesList convertToOpenShiftResources(KubernetesList resources) throws MojoExecutionException { KubernetesListBuilder builder = new KubernetesListBuilder(); builder.withMetadata(resources.getMetadata()); List<HasMetadata> items = resources.getItems(); List<HasMetadata> objects = new ArrayList<>(); if (items != null) { for (HasMetadata item : items) { if (item instanceof Deployment) { // if we have a Deployment and a DeploymentConfig of the same name // since we have a different manifest for OpenShift then lets filter out // the Kubernetes specific Deployment String name = KubernetesHelper.getName(item); if (hasDeploymentConfigNamed(items, name)) { continue; } } HasMetadata converted = convertKubernetesItemToOpenShift(item); if (converted != null) { objects.add(converted); } } } openshiftDependencyResources.addMissingResources(objects); moveTemplatesToTopLevel(builder, objects); // TODO: Remove this ASAP when https://github.com/fabric8io/fabric8-maven-plugin/issues/678 is fixed removeInitContainers(builder, VolumePermissionEnricher.ENRICHER_NAME); return builder.build(); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected void downloadGoFabric8(File destFile) throws MojoExecutionException { File file = null; try { file = File.createTempFile("fabric8", ".bin"); } catch (IOException e) { throw new MojoExecutionException("Failed to create a temporary file for the download"); } log.debug("Downloading gofabric8 to temporary file: " + file.getAbsolutePath()); String version; try { version = IOHelpers.readFully(new URL(gofabric8VersionURL)); log.info("Downloading version " + version + " of gofabric8 to " + destFile + " ..."); } catch (IOException e) { throw new MojoExecutionException("Failed to load gofabric8 version from: " + gofabric8VersionURL + ". " + e, e); } String platform = getPlatform(); String osArch = System.getProperty("os.arch"); String arch = Architectures.AMD64; if (osArch.toLowerCase().contains("arm")) { arch = Architectures.ARM; } String releaseUrl = "https://github.com/fabric8io/gofabric8/releases/download/v" + version + "/gofabric8-" + platform + "-" + arch; if (platform.equals("windows")) { releaseUrl += ".exe"; } URL downloadUrl; try { downloadUrl = new URL(releaseUrl); } catch (MalformedURLException e) { throw new MojoExecutionException("Failed to create URL: " + releaseUrl + ". " + e, e); } InputStream inputStream; try { inputStream = downloadUrl.openStream(); } catch (IOException e) { throw new MojoExecutionException("Failed to open URL: " + releaseUrl + ". " + e, e); } try (OutputStream out = new FileOutputStream(file)) { IOHelpers.copy(inputStream, out); } catch (IOException e) { throw new MojoExecutionException("Failed to download URL: " + releaseUrl + " to file: " + file + ". " + e, e); } file.setExecutable(true); // TODO: Very checksum and potentially signature // lets check we can execute the binary before we try to replace it if it already exists runCommand(file.getAbsolutePath() + " version" + batchModeArgument, "gofabric8 version" + batchModeArgument, "gofabric8"); boolean result = file.renameTo(destFile); if (!result) { // lets try copy it instead as this could be an odd linux issue with renaming files try { IOHelpers.copy(new FileInputStream(file), new FileOutputStream(destFile)); destFile.setExecutable(true); } catch (IOException e) { throw new MojoExecutionException("Failed to copy temporary file " + file + " to " + destFile + ": " + e, e); } } log.info("Downloaded gofabric8 version " + version + " platform: " + platform + " arch:" + arch + " on: " + System.getProperty("os.name") + " " + arch + " to: " + destFile); } #location 21 #vulnerability type NULL_DEREFERENCE
#fixed code protected void downloadGoFabric8(File destFile) throws MojoExecutionException { // Download to a temporary file File tempFile = downloadToTempFile(); // Move into it's destination place in ~/.fabric8/bin moveGofabric8InPlace(tempFile, destFile); // Make some noise runGofabric8(destFile + " version"); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public Probe getProbe(ProbeConfig probeConfig) { if (probeConfig == null) { return null; } Probe probe = new Probe(); Integer initialDelaySeconds = probeConfig.getInitialDelaySeconds(); if (initialDelaySeconds != null) { probe.setInitialDelaySeconds(initialDelaySeconds); } Integer timeoutSeconds = probeConfig.getTimeoutSeconds(); if (timeoutSeconds != null) { probe.setTimeoutSeconds(timeoutSeconds); } HTTPGetAction getAction = getHTTPGetAction(probeConfig.getGetUrl()); if(StringUtils.isEmpty(getAction.getHost())) { getAction.setHost(null); } if (getAction != null) { probe.setHttpGet(getAction); return probe; } ExecAction execAction = getExecAction(probeConfig.getExec()); if (execAction != null) { probe.setExec(execAction); return probe; } TCPSocketAction tcpSocketAction = getTCPSocketAction(probeConfig.getTcpPort()); if (tcpSocketAction != null) { probe.setTcpSocket(tcpSocketAction); return probe; } return null; } #location 16 #vulnerability type NULL_DEREFERENCE
#fixed code public Probe getProbe(ProbeConfig probeConfig) { if (probeConfig == null) { return null; } Probe probe = new Probe(); Integer initialDelaySeconds = probeConfig.getInitialDelaySeconds(); if (initialDelaySeconds != null) { probe.setInitialDelaySeconds(initialDelaySeconds); } Integer timeoutSeconds = probeConfig.getTimeoutSeconds(); if (timeoutSeconds != null) { probe.setTimeoutSeconds(timeoutSeconds); } HTTPGetAction getAction = getHTTPGetAction(probeConfig.getGetUrl()); if (getAction != null) { probe.setHttpGet(getAction); return probe; } ExecAction execAction = getExecAction(probeConfig.getExec()); if (execAction != null) { probe.setExec(execAction); return probe; } TCPSocketAction tcpSocketAction = getTCPSocketAction(probeConfig.getTcpPort()); if (tcpSocketAction != null) { probe.setTcpSocket(tcpSocketAction); return probe; } return null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void portForward(Controller controller, String podName) throws MojoExecutionException { try { getFabric8ServiceHub().getPortForwardService() .forwardPort(controller, createExternalProcessLogger("[[B]]port-forward[[B]] "), podName, portToInt(remoteDebugPort, "remoteDebugPort"), portToInt(localDebugPort, "localDebugPort")); log.info(""); log.info("Now you can start a Remote debug execution in your IDE by using localhost and the debug port " + localDebugPort); log.info(""); } catch (Fabric8ServiceException e) { throw new MojoExecutionException("Failed to start port forwarding" + e, e); } } #location 3 #vulnerability type RESOURCE_LEAK
#fixed code private void portForward(Controller controller, String podName) throws MojoExecutionException { try { getFabric8ServiceHub(controller).getPortForwardService() .forwardPort(createExternalProcessLogger("[[B]]port-forward[[B]] "), podName, portToInt(remoteDebugPort, "remoteDebugPort"), portToInt(localDebugPort, "localDebugPort")); log.info(""); log.info("Now you can start a Remote debug execution in your IDE by using localhost and the debug port " + localDebugPort); log.info(""); } catch (Fabric8ServiceException e) { throw new MojoExecutionException("Failed to start port forwarding" + e, e); } }
Below is the vulnerable code, please generate the patch based on the following information.