input
stringlengths 205
73.3k
| output
stringlengths 64
73.2k
| instruction
stringclasses 1
value |
|---|---|---|
#vulnerable code
@Override
public ExtractedFileSet extractFileSet(Distribution distribution)
throws IOException {
Directory withDistribution = withDistribution(extraction.getDirectory(), distribution);
ArtifactStore baseStore = store(withDistribution, extraction.getExecutableNaming());
boolean foundExecutable=false;
File destinationDir = withDistribution.asFile();
Builder fileSetBuilder = ExtractedFileSet.builder(destinationDir)
.baseDirIsGenerated(withDistribution.isGenerated());
FilesToExtract filesToExtract = baseStore.filesToExtract(distribution);
for (FileSet.Entry file : filesToExtract.files()) {
if (file.type()==FileType.Executable) {
String executableName = FilesToExtract.executableName(extraction.getExecutableNaming(), file);
File executableFile = new File(executableName);
File resolvedExecutableFile = new File(destinationDir, executableName);
if (resolvedExecutableFile.isFile()) {
foundExecutable=true;
}
fileSetBuilder.executable(executableFile);
} else {
fileSetBuilder.addLibraryFiles(new File(FilesToExtract.fileName(file)));
}
}
if (!foundExecutable) {
// we found no executable, so we trigger extraction and hope for the best
try {
baseStore.extractFileSet(distribution);
} catch (FileAlreadyExistsException fx) {
throw new RuntimeException("extraction to "+destinationDir+" has failed", fx);
}
}
ExtractedFileSet extractedFileSet = fileSetBuilder.build();
return ExtractedFileSets.copy(extractedFileSet, temp.getDirectory(), temp.getExecutableNaming());
}
#location 39
#vulnerability type NULL_DEREFERENCE | #fixed code
@Override
public ExtractedFileSet extractFileSet(Distribution distribution)
throws IOException {
Directory withDistribution = withDistribution(extraction.getDirectory(), distribution);
ArtifactStore baseStore = store(withDistribution, extraction.getExecutableNaming());
boolean foundExecutable=false;
File destinationDir = withDistribution.asFile();
Builder fileSetBuilder = ExtractedFileSet.builder(destinationDir)
.baseDirIsGenerated(withDistribution.isGenerated());
FilesToExtract filesToExtract = baseStore.filesToExtract(distribution);
for (FileSet.Entry file : filesToExtract.files()) {
if (file.type()==FileType.Executable) {
String executableName = FilesToExtract.executableName(extraction.getExecutableNaming(), file);
File executableFile = new File(executableName);
File resolvedExecutableFile = new File(destinationDir, executableName);
if (resolvedExecutableFile.isFile()) {
foundExecutable=true;
}
fileSetBuilder.executable(executableFile);
} else {
fileSetBuilder.addLibraryFiles(new File(FilesToExtract.fileName(file)));
}
}
ExtractedFileSet extractedFileSet;
if (!foundExecutable) {
// we found no executable, so we trigger extraction and hope for the best
try {
extractedFileSet = baseStore.extractFileSet(distribution);
} catch (FileAlreadyExistsException fx) {
throw new RuntimeException("extraction to "+destinationDir+" has failed", fx);
}
} else {
extractedFileSet = fileSetBuilder.build();
}
return ExtractedFileSets.copy(extractedFileSet, temp.getDirectory(), temp.getExecutableNaming());
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public static void write(String content, File output) throws IOException {
FileOutputStream out = new FileOutputStream(output);
OutputStreamWriter w = new OutputStreamWriter(out);
try {
w.write(content);
w.flush();
} finally {
out.close();
}
}
#location 7
#vulnerability type RESOURCE_LEAK | #fixed code
public static void write(String content, File output) throws IOException {
try (final FileOutputStream out = new FileOutputStream(output);
final OutputStreamWriter w = new OutputStreamWriter(out)) {
w.write(content);
w.flush();
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void constructorOpensConnection(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection(mockUrl, (HttpMethod) any);
}
};
}
#location 15
#vulnerability type RESOURCE_LEAK | #fixed code
@Test
public void constructorOpensConnection(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection(mockUrl, (HttpMethod) any, (Proxy) any);
}
};
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void onLinkRemoteOpen(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_041: [The connection state shall be considered OPEN when the sender link is open remotely.]
Link link = event.getLink();
if (link.getName().equals(SENDER_TAG))
{
this.state = State.OPEN;
// Codes_SRS_AMQPSIOTHUBCONNECTION_99_001: [All server listeners shall be notified when that the connection has been established.]
for(ServerListener listener : listeners)
{
listener.connectionEstablished();
}
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
#location 9
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void onLinkRemoteOpen(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_041: [The connection state shall be considered OPEN when the sender link is open remotely.]
Link link = event.getLink();
if (link.getName().equals(SENDER_TAG))
{
this.state = State.OPEN;
// Codes_SRS_AMQPSIOTHUBCONNECTION_99_001: [All server listeners shall be notified when that the connection has been established.]
for(ServerListener listener : listeners)
{
listener.connectionEstablished();
}
// Codes_SRS_AMQPSIOTHUBCONNECTION_21_051 [The open lock shall be notified when that the connection has been established.]
synchronized (openLock)
{
openLock.notifyLock();
}
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void getRequestIdGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5";
TopicParser testParser = new TopicParser(validString);
//act
String status = testParser.getRequestId(3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
}
#location 13
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void getRequestIdGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5";
TopicParser testParser = new TopicParser(validString);
//act
String status = Deencapsulation.invoke(testParser, "getRequestId", 3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void getRequestIdOnTopicWithVersionBeforeRidGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5&$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String status = testParser.getRequestId(3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
}
#location 13
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void getRequestIdOnTopicWithVersionBeforeRidGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5&$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String status = Deencapsulation.invoke(testParser, "getRequestId", 3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void parsePayloadReturnsBytesForSpecifiedTopic(@Mocked final Mqtt mockMqtt) throws IOException
{
//arrange
MqttDeviceTwin testTwin = new MqttDeviceTwin();
String insertTopic = "$iothub/twin/"+ anyString;
final byte[] insertMessage = {0x61, 0x62, 0x63};
ConcurrentSkipListMap<String, byte[]> testMap = new ConcurrentSkipListMap<String, byte[]>();
testMap.put(insertTopic, insertMessage);
Deencapsulation.setField(mockMqtt, "allReceivedMessages", testMap);
//act
byte[] parsedPayload = testTwin.parsePayload(insertTopic);
//assert
assertNotNull(parsedPayload);
assertEquals(insertMessage.length, parsedPayload.length);
for (int i = 0 ; i < parsedPayload.length; i++)
{
assertEquals(parsedPayload[i], insertMessage[i]);
}
}
#location 18
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void parsePayloadReturnsBytesForSpecifiedTopic(@Mocked final Mqtt mockMqtt) throws IOException
{
//arrange
MqttDeviceTwin testTwin = new MqttDeviceTwin();
String insertTopic = "$iothub/twin/"+ anyString;
final byte[] insertMessage = {0x61, 0x62, 0x63};
ConcurrentSkipListMap<String, byte[]> testMap = new ConcurrentSkipListMap<String, byte[]>();
testMap.put(insertTopic, insertMessage);
Deencapsulation.setField(mockMqtt, "allReceivedMessages", testMap);
//act
byte[] parsedPayload = Deencapsulation.invoke(testTwin, "parsePayload", insertTopic);
//assert
assertNotNull(parsedPayload);
assertEquals(insertMessage.length, parsedPayload.length);
for (int i = 0 ; i < parsedPayload.length; i++)
{
assertEquals(parsedPayload[i], insertMessage[i]);
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void onConnectionBound(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_030: [The event handler shall get the Transport (Proton) object from the event.]
Transport transport = event.getConnection().getTransport();
if(transport != null){
if (this.useWebSockets)
{
WebSocketImpl webSocket = new WebSocketImpl();
webSocket.configure(this.hostName, WEB_SOCKET_PATH, 0, WEB_SOCKET_SUB_PROTOCOL, null, null);
((TransportInternal)transport).addTransportLayer(webSocket);
}
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_031: [The event handler shall set the SASL_PLAIN authentication on the transport using the given user name and sas token.]
Sasl sasl = transport.sasl();
sasl.plain(this.userName, this.sasToken);
SslDomain domain = makeDomain();
transport.ssl(domain);
}
synchronized (openLock)
{
openLock.notifyLock();
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
#location 18
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void onConnectionBound(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_030: [The event handler shall get the Transport (Proton) object from the event.]
Transport transport = event.getConnection().getTransport();
if(transport != null){
if (this.useWebSockets)
{
WebSocketImpl webSocket = new WebSocketImpl();
webSocket.configure(this.hostName, WEB_SOCKET_PATH, 0, WEB_SOCKET_SUB_PROTOCOL, null, null);
((TransportInternal)transport).addTransportLayer(webSocket);
}
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_031: [The event handler shall set the SASL_PLAIN authentication on the transport using the given user name and sas token.]
Sasl sasl = transport.sasl();
sasl.plain(this.userName, this.sasToken);
SslDomain domain = makeDomain();
transport.ssl(domain);
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
log.info("Client connection closed successfully");
}
#location 34
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
log.info("Client connection closed successfully");
}
#location 29
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public HttpsResponse send() throws TransportException
{
if (this.url == null)
{
throw new IllegalArgumentException("url cannot be null");
}
HttpsConnection connection = new HttpsConnection(url, method, this.proxySettings);
for (String headerKey : headers.keySet())
{
for (String headerValue : this.headers.get(headerKey))
{
connection.setRequestHeader(headerKey, headerValue);
}
}
connection.writeOutput(this.body);
if (this.sslContext != null)
{
connection.setSSLContext(this.sslContext);
}
if (this.readTimeout != 0)
{
connection.setReadTimeout(this.readTimeout);
}
if (this.connectTimeout != 0)
{
connection.setConnectTimeout(this.connectTimeout);
}
int responseStatus = -1;
byte[] responseBody = new byte[0];
byte[] errorReason = new byte[0];
Map<String, List<String>> headerFields;
// Codes_SRS_HTTPSREQUEST_11_008: [The function shall send an HTTPS request as formatted in the constructor.]
connection.connect();
responseStatus = connection.getResponseStatus();
headerFields = connection.getResponseHeaders();
if (responseStatus == 200)
{
responseBody = connection.readInput();
}
// Codes_SRS_HTTPSREQUEST_11_009: [The function shall return the HTTPS response received, including the status code, body (if 200 status code), header fields, and error reason (if any).]
return new HttpsResponse(responseStatus, responseBody, headerFields, errorReason);
}
#location 46
#vulnerability type RESOURCE_LEAK | #fixed code
public HttpsResponse send() throws TransportException
{
return send(true);
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void getRequestIdOnTopicWithVersionGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$version=7&$rid=5";
TopicParser testParser = new TopicParser(validString);
//act
String status = testParser.getRequestId(3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
}
#location 13
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void getRequestIdOnTopicWithVersionGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$version=7&$rid=5";
TopicParser testParser = new TopicParser(validString);
//act
String status = Deencapsulation.invoke(testParser, "getRequestId", 3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test (expected = IllegalArgumentException.class)
public void request_nullHttpMethod_failed() throws Exception
{
//arrange
//act
HttpResponse response = DeviceOperations.request(
IOT_HUB_CONNECTION_STRING,
new URL(STANDARD_URL),
null,
STANDARD_PAYLOAD,
STANDARD_REQUEST_ID);
//assert
}
#location 7
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test (expected = IllegalArgumentException.class)
public void request_nullHttpMethod_failed() throws Exception
{
//arrange
//act
HttpResponse response = DeviceOperations.request(
IOT_HUB_CONNECTION_STRING,
new URL(STANDARD_URL),
null,
STANDARD_PAYLOAD,
STANDARD_REQUEST_ID,
0);
//assert
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
@ConditionalIgnoreRule.ConditionalIgnore(condition = StandardTierOnlyRule.class)
public void testRawQueryTwin() throws IOException, InterruptedException, IotHubException, NoSuchAlgorithmException, URISyntaxException, ModuleClientException
{
addMultipleDevices(MAX_DEVICES);
Gson gson = new GsonBuilder().enableComplexMapKeySerialization().serializeNulls().create();
// Add same desired on multiple devices
final String queryProperty = PROPERTY_KEY_QUERY + UUID.randomUUID().toString();
final String queryPropertyValue = PROPERTY_VALUE_QUERY + UUID.randomUUID().toString();
final double actualNumOfDevices = MAX_DEVICES;
setDesiredProperties(queryProperty, queryPropertyValue, MAX_DEVICES);
Thread.sleep(DESIRED_PROPERTIES_PROPAGATION_TIME_MILLIS);
// Raw Query for multiple devices having same property
final String select = "properties.desired." + queryProperty + " AS " + queryProperty + "," + " COUNT() AS numberOfDevices";
final String groupBy = "properties.desired." + queryProperty;
final SqlQuery sqlQuery = SqlQuery.createSqlQuery(select, SqlQuery.FromType.DEVICES, null, groupBy);
Query rawTwinQuery = scRawTwinQueryClient.query(sqlQuery.getQuery(), PAGE_SIZE);
while (scRawTwinQueryClient.hasNext(rawTwinQuery))
{
String result = scRawTwinQueryClient.next(rawTwinQuery);
assertNotNull(result);
Map map = gson.fromJson(result, Map.class);
if (map.containsKey("numberOfDevices") && map.containsKey(queryProperty))
{
double value = (double) map.get("numberOfDevices");
assertEquals(value, actualNumOfDevices, 0);
}
}
removeMultipleDevices(MAX_DEVICES);
}
#location 23
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
@ConditionalIgnoreRule.ConditionalIgnore(condition = StandardTierOnlyRule.class)
public void testRawQueryTwin() throws IOException, InterruptedException, IotHubException, GeneralSecurityException, URISyntaxException, ModuleClientException
{
addMultipleDevices(MAX_DEVICES);
Gson gson = new GsonBuilder().enableComplexMapKeySerialization().serializeNulls().create();
// Add same desired on multiple devices
final String queryProperty = PROPERTY_KEY_QUERY + UUID.randomUUID().toString();
final String queryPropertyValue = PROPERTY_VALUE_QUERY + UUID.randomUUID().toString();
final double actualNumOfDevices = MAX_DEVICES;
setDesiredProperties(queryProperty, queryPropertyValue, MAX_DEVICES);
Thread.sleep(DESIRED_PROPERTIES_PROPAGATION_TIME_MILLIS);
// Raw Query for multiple devices having same property
final String select = "properties.desired." + queryProperty + " AS " + queryProperty + "," + " COUNT() AS numberOfDevices";
final String groupBy = "properties.desired." + queryProperty;
final SqlQuery sqlQuery = SqlQuery.createSqlQuery(select, SqlQuery.FromType.DEVICES, null, groupBy);
Query rawTwinQuery = scRawTwinQueryClient.query(sqlQuery.getQuery(), PAGE_SIZE);
while (scRawTwinQueryClient.hasNext(rawTwinQuery))
{
String result = scRawTwinQueryClient.next(rawTwinQuery);
assertNotNull(result);
Map map = gson.fromJson(result, Map.class);
if (map.containsKey("numberOfDevices") && map.containsKey(queryProperty))
{
double value = (double) map.get("numberOfDevices");
assertEquals(value, actualNumOfDevices, 0);
}
}
removeMultipleDevices(MAX_DEVICES);
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
}
#location 22
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void onReactorFinal(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_011: [The function shall call notify lock on close lock.]
synchronized (closeLock)
{
closeLock.notifyLock();
}
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_012: [The function shall set the reactor member variable to null.]
this.reactor = null;
if (reconnectCall)
{
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_013: [The function shall call openAsync and disable reconnection if it is a reconnection attempt.]
reconnectCall = false;
try
{
openAsync();
}
catch (IOException e)
{
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_014: [The function shall log the error if openAsync failed.]
logger.LogDebug("onReactorFinal has thrown exception: %s", e.getMessage());
}
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
#location 21
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void onReactorFinal(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_011: [The function shall call notify lock on close lock.]
synchronized (closeLock)
{
closeLock.notifyLock();
}
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_012: [The function shall set the reactor member variable to null.]
this.reactor = null;
if (reconnectCall)
{
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_013: [The function shall call openAsync and disable reconnection if it is a reconnection attempt.]
reconnectCall = false;
for (ServerListener listener : listeners)
{
listener.reconnect();
}
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public HttpsResponse send() throws TransportException
{
if (this.url == null)
{
throw new IllegalArgumentException("url cannot be null");
}
HttpsConnection connection = new HttpsConnection(url, method, this.proxySettings);
for (String headerKey : headers.keySet())
{
for (String headerValue : this.headers.get(headerKey))
{
connection.setRequestHeader(headerKey, headerValue);
}
}
connection.writeOutput(this.body);
if (this.sslContext != null)
{
connection.setSSLContext(this.sslContext);
}
if (this.readTimeout != 0)
{
connection.setReadTimeout(this.readTimeout);
}
if (this.connectTimeout != 0)
{
connection.setConnectTimeout(this.connectTimeout);
}
int responseStatus = -1;
byte[] responseBody = new byte[0];
byte[] errorReason = new byte[0];
Map<String, List<String>> headerFields;
// Codes_SRS_HTTPSREQUEST_11_008: [The function shall send an HTTPS request as formatted in the constructor.]
connection.connect();
responseStatus = connection.getResponseStatus();
headerFields = connection.getResponseHeaders();
if (responseStatus == 200)
{
responseBody = connection.readInput();
}
// Codes_SRS_HTTPSREQUEST_11_009: [The function shall return the HTTPS response received, including the status code, body (if 200 status code), header fields, and error reason (if any).]
return new HttpsResponse(responseStatus, responseBody, headerFields, errorReason);
}
#location 48
#vulnerability type RESOURCE_LEAK | #fixed code
public HttpsResponse send() throws TransportException
{
return send(true);
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test(expected = IOException.class)
public void constructorThrowsIoExceptionIfCannotSetupConnection(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
new HttpConnection(mockUrl, httpsMethod);
result = new IOException();
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
}
#location 17
#vulnerability type RESOURCE_LEAK | #fixed code
@Test(expected = IOException.class)
public void constructorThrowsIoExceptionIfCannotSetupConnection(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
new HttpConnection(mockUrl, httpsMethod, (Proxy) any);
result = new IOException();
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void constructorWritesBodyToConnection(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = { 1, 2, 3 };
final byte[] expectedBody = body;
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection(mockUrl, (HttpMethod) any)
.writeOutput(expectedBody);
}
};
}
#location 16
#vulnerability type RESOURCE_LEAK | #fixed code
@Test
public void constructorWritesBodyToConnection(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = { 1, 2, 3 };
final byte[] expectedBody = body;
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection(mockUrl, (HttpMethod) any, (Proxy) any)
.writeOutput(expectedBody);
}
};
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
protected void setSslDomain(Transport transport) throws TransportException
{
// Codes_SRS_AMQPSDEVICEAUTHENTICATIONCBS_12_011: [The function shall set get the sasl layer from the transport.]
Sasl sasl = transport.sasl();
// Codes_SRS_AMQPSDEVICEAUTHENTICATIONCBS_12_012: [The function shall set the sasl mechanism to PLAIN.]
sasl.setMechanisms("ANONYMOUS");
// Codes_SRS_AMQPSDEVICEAUTHENTICATIONCBS_12_013: [The function shall set the SslContext on the domain.]
SslDomain domain = null;
try
{
domain = makeDomain(this.deviceClientConfig.getSasTokenAuthentication().getSSLContext());
}
catch (IOException e)
{
logger.LogDebug("setSslDomain has thrown exception: %s", e.getMessage());
throw new TransportException(e);
}
// Codes_SRS_AMQPSDEVICEAUTHENTICATIONCBS_12_014: [The function shall set the domain on the transport.]
transport.ssl(domain);
}
#location 13
#vulnerability type NULL_DEREFERENCE | #fixed code
@Override
protected void setSslDomain(Transport transport) throws TransportException
{
// Codes_SRS_AMQPSDEVICEAUTHENTICATIONCBS_12_011: [The function shall set get the sasl layer from the transport.]
Sasl sasl = transport.sasl();
// Codes_SRS_AMQPSDEVICEAUTHENTICATIONCBS_12_012: [The function shall set the sasl mechanism to PLAIN.]
sasl.setMechanisms("ANONYMOUS");
// Codes_SRS_AMQPSDEVICEAUTHENTICATIONCBS_12_013: [The function shall set the SslContext on the domain.]
SslDomain domain = null;
try
{
domain = makeDomain(this.deviceClientConfig.getAuthenticationProvider().getSSLContext());
}
catch (IOException e)
{
logger.LogDebug("setSslDomain has thrown exception: %s", e.getMessage());
throw new TransportException(e);
}
// Codes_SRS_AMQPSDEVICEAUTHENTICATIONCBS_12_014: [The function shall set the domain on the transport.]
transport.ssl(domain);
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void getVersionOnTopicWithRIDGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5&$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String version = testParser.getVersion(3);
//assert
assertNotNull(version);
assertTrue(version.equals(String.valueOf(7)));
}
#location 13
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void getVersionOnTopicWithRIDGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5&$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String version = Deencapsulation.invoke(testParser, "getVersion", 3);
//assert
assertNotNull(version);
assertTrue(version.equals(String.valueOf(7)));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
@StandardTierHubOnlyTest
public void invokeMethodSucceed() throws Exception
{
testInstance.transportClient.open();
for (int i = 0; i < testInstance.clientArrayList.size(); i++)
{
((DeviceClient)testInstance.clientArrayList.get(i)).subscribeToDeviceMethod(new SampleDeviceMethodCallback(), null, new DeviceMethodStatusCallBack(), null);
CountDownLatch countDownLatch = new CountDownLatch(1);
RunnableInvoke runnableInvoke = new RunnableInvoke(methodServiceClient, testInstance.devicesList[i].getDeviceId(), METHOD_NAME, METHOD_PAYLOAD, countDownLatch);
new Thread(runnableInvoke).start();
countDownLatch.await(3, TimeUnit.MINUTES);
MethodResult result = runnableInvoke.getResult();
Assert.assertNotNull(buildExceptionMessage(runnableInvoke.getException() == null ? "Runnable returns null without exception information" : runnableInvoke.getException().getMessage(), testInstance.clientArrayList.get(i)), result);
Assert.assertEquals(buildExceptionMessage("result was not success, but was: " + result.getStatus(), testInstance.clientArrayList.get(i)), (long)METHOD_SUCCESS,(long)result.getStatus());
Assert.assertEquals(buildExceptionMessage("Received unexpected payload", testInstance.clientArrayList.get(i)), runnableInvoke.getExpectedPayload(), METHOD_NAME + ":" + result.getPayload().toString());
}
testInstance.transportClient.closeNow();
}
#location 18
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
@StandardTierHubOnlyTest
public void invokeMethodSucceed() throws Exception
{
testInstance.transportClient.open();
for (int i = 0; i < testInstance.clientArrayList.size(); i++)
{
DeviceMethodStatusCallBack subscribedCallback = new DeviceMethodStatusCallBack();
((DeviceClient)testInstance.clientArrayList.get(i)).subscribeToDeviceMethod(new SampleDeviceMethodCallback(), null, subscribedCallback, null);
long startTime = System.currentTimeMillis();
while (!subscribedCallback.isSubscribed)
{
Thread.sleep(200);
if (System.currentTimeMillis() - startTime > METHOD_SUBSCRIBE_TIMEOUT_MILLISECONDS)
{
fail(buildExceptionMessage("Timed out waiting for device to subscribe to methods", testInstance.clientArrayList.get(i)));
}
}
CountDownLatch countDownLatch = new CountDownLatch(1);
RunnableInvoke runnableInvoke = new RunnableInvoke(methodServiceClient, testInstance.devicesList[i].getDeviceId(), METHOD_NAME, METHOD_PAYLOAD, countDownLatch);
new Thread(runnableInvoke).start();
countDownLatch.await(3, TimeUnit.MINUTES);
MethodResult result = runnableInvoke.getResult();
Assert.assertNotNull(buildExceptionMessage(runnableInvoke.getException() == null ? "Runnable returns null without exception information" : runnableInvoke.getException().getMessage(), testInstance.clientArrayList.get(i)), result);
Assert.assertEquals(buildExceptionMessage("result was not success, but was: " + result.getStatus(), testInstance.clientArrayList.get(i)), (long)METHOD_SUCCESS,(long)result.getStatus());
Assert.assertEquals(buildExceptionMessage("Received unexpected payload", testInstance.clientArrayList.get(i)), runnableInvoke.getExpectedPayload(), METHOD_NAME + ":" + result.getPayload().toString());
}
testInstance.transportClient.closeNow();
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
void doConnect() {
// Device client does not have retry on the initial open() call. Will need to be re-opened by the calling application
while (connectionStatus == ConnectionStatus.CONNECTING) {
synchronized (lock) {
if(connectionStatus == ConnectionStatus.CONNECTING) {
try {
log.debug("[connect] - Opening the device client instance...");
client.open();
connectionStatus = ConnectionStatus.CONNECTED;
break;
}
catch (Exception ex) {
log.error("[connect] - Exception thrown while opening DeviceClient instance: ", ex);
}
}
}
try {
log.debug("[connect] - Sleeping for 10 secs before attempting another open()");
Thread.sleep(SLEEP_TIME_BEFORE_RECONNECTING_IN_SECONDS * 1000);
}
catch (InterruptedException ex) {
log.error("[connect] - Exception in thread sleep: ", ex);
}
}
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
DeviceClientManager(DeviceClient deviceClient, boolean autoReconnectOnDisconnected) {
this.connectionStatus = ConnectionStatus.DISCONNECTED;
this.client = deviceClient;
this.client.registerConnectionStatusChangeCallback(this, this);
this.autoReconnectOnDisconnected = autoReconnectOnDisconnected;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void onLinkRemoteClose(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
this.state = State.CLOSED;
String linkName = event.getLink().getName();
if (this.amqpsSessionManager.isLinkFound(linkName))
{
logger.LogInfo("Starting to reconnect to IotHub, method name is %s ", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_048: [The event handler shall attempt to startReconnect to IoTHub.]
startReconnect();
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
#location 12
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void onLinkRemoteClose(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
this.state = State.CLOSED;
String linkName = event.getLink().getName();
if (this.amqpsSessionManager.isLinkFound(linkName))
{
logger.LogInfo("Starting to reconnect to IotHub, method name is %s ", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_048: [The event handler shall attempt to startReconnect to IoTHub.]
startReconnect();
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
log.info("Client connection closed successfully");
}
#location 22
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public HttpsResponse send() throws TransportException
{
if (this.url == null)
{
throw new IllegalArgumentException("url cannot be null");
}
HttpsConnection connection = new HttpsConnection(url, method, this.proxySettings);
for (String headerKey : headers.keySet())
{
for (String headerValue : this.headers.get(headerKey))
{
connection.setRequestHeader(headerKey, headerValue);
}
}
connection.writeOutput(this.body);
if (this.sslContext != null)
{
connection.setSSLContext(this.sslContext);
}
if (this.readTimeout != 0)
{
connection.setReadTimeout(this.readTimeout);
}
if (this.connectTimeout != 0)
{
connection.setConnectTimeout(this.connectTimeout);
}
int responseStatus = -1;
byte[] responseBody = new byte[0];
byte[] errorReason = new byte[0];
Map<String, List<String>> headerFields;
// Codes_SRS_HTTPSREQUEST_11_008: [The function shall send an HTTPS request as formatted in the constructor.]
connection.connect();
responseStatus = connection.getResponseStatus();
headerFields = connection.getResponseHeaders();
if (responseStatus == 200)
{
responseBody = connection.readInput();
}
// Codes_SRS_HTTPSREQUEST_11_009: [The function shall return the HTTPS response received, including the status code, body (if 200 status code), header fields, and error reason (if any).]
return new HttpsResponse(responseStatus, responseBody, headerFields, errorReason);
}
#location 48
#vulnerability type RESOURCE_LEAK | #fixed code
public HttpsResponse send() throws TransportException
{
return send(true);
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void tokenExpiredAfterOpenButBeforeSendHttp() throws InvalidKeyException, IOException, InterruptedException, URISyntaxException
{
final long SECONDS_FOR_SAS_TOKEN_TO_LIVE = 3;
final long MILLISECONDS_TO_WAIT_FOR_TOKEN_TO_EXPIRE = 5000;
if (testInstance.protocol != HTTPS || testInstance.authenticationType != SAS)
{
//This scenario only applies to HTTP since MQTT and AMQP allow expired sas tokens for 30 minutes after open
// as long as token did not expire before open. X509 doesn't apply either
return;
}
String soonToBeExpiredSASToken = generateSasTokenForIotDevice(hostName, testInstance.identity.getDeviceId(), testInstance.identity.getPrimaryKey(), SECONDS_FOR_SAS_TOKEN_TO_LIVE);
DeviceClient client = new DeviceClient(soonToBeExpiredSASToken, testInstance.protocol);
IotHubServicesCommon.openClientWithRetry(client);
//Force the SAS token to expire before sending messages
Thread.sleep(MILLISECONDS_TO_WAIT_FOR_TOKEN_TO_EXPIRE);
IotHubServicesCommon.sendMessagesExpectingSASTokenExpiration(client, testInstance.protocol.toString(), 1, RETRY_MILLISECONDS, SEND_TIMEOUT_MILLISECONDS, testInstance.authenticationType);
client.closeNow();
}
#location 14
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void tokenExpiredAfterOpenButBeforeSendHttp() throws Exception
{
final long SECONDS_FOR_SAS_TOKEN_TO_LIVE = 3;
final long MILLISECONDS_TO_WAIT_FOR_TOKEN_TO_EXPIRE = 5000;
if (testInstance.protocol != HTTPS || testInstance.authenticationType != SAS)
{
//This scenario only applies to HTTP since MQTT and AMQP allow expired sas tokens for 30 minutes after open
// as long as token did not expire before open. X509 doesn't apply either
return;
}
this.testInstance.setup();
String soonToBeExpiredSASToken = generateSasTokenForIotDevice(hostName, testInstance.identity.getDeviceId(), testInstance.identity.getPrimaryKey(), SECONDS_FOR_SAS_TOKEN_TO_LIVE);
DeviceClient client = new DeviceClient(soonToBeExpiredSASToken, testInstance.protocol);
IotHubServicesCommon.openClientWithRetry(client);
//Force the SAS token to expire before sending messages
Thread.sleep(MILLISECONDS_TO_WAIT_FOR_TOKEN_TO_EXPIRE);
IotHubServicesCommon.sendMessagesExpectingSASTokenExpiration(client, testInstance.protocol.toString(), 1, RETRY_MILLISECONDS, SEND_TIMEOUT_MILLISECONDS, testInstance.authenticationType);
client.closeNow();
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
protected void disconnect() throws IOException
{
synchronized (Mqtt.MQTT_LOCK)
{
try
{
/*
**Codes_SRS_Mqtt_25_010: [**If the MQTT connection is closed, the function shall do nothing.**]**
*/
if (Mqtt.info.mqttAsyncClient.isConnected())
{
/*
** Codes_SRS_Mqtt_25_009: [**The function shall close the MQTT connection.**]**
*/
IMqttToken disconnectToken = Mqtt.info.mqttAsyncClient.disconnect();
disconnectToken.waitForCompletion();
}
Mqtt.info.mqttAsyncClient = null;
}
catch (MqttException e)
{
/*
** SRS_Mqtt_25_011: [**If an MQTT connection is unable to be closed for any reason, the function shall throw an IOException.**]**
*/
throw new IOException("Unable to disconnect" + "because " + e.getMessage() );
}
}
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
protected void disconnect() throws IOException
{
try
{
/*
**Codes_SRS_Mqtt_25_010: [**If the MQTT connection is closed, the function shall do nothing.**]**
*/
if (Mqtt.info.mqttAsyncClient.isConnected())
{
/*
** Codes_SRS_Mqtt_25_009: [**The function shall close the MQTT connection.**]**
*/
IMqttToken disconnectToken = Mqtt.info.mqttAsyncClient.disconnect();
disconnectToken.waitForCompletion();
}
Mqtt.info.mqttAsyncClient = null;
}
catch (MqttException e)
{
/*
** SRS_Mqtt_25_011: [**If an MQTT connection is unable to be closed for any reason, the function shall throw an IOException.**]**
*/
throw new IOException("Unable to disconnect" + "because " + e.getMessage() );
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
log.info("Client connection closed successfully");
}
#location 23
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
boolean onLinkRemoteOpen(String linkName)
{
// Codes_SRS_AMQPSESSIONDEVICEOPERATION_12_024: [The function shall return true if any of the operation's link name is a match and return false otherwise.]
if (this.amqpsAuthenticatorState == AmqpsDeviceAuthenticationState.AUTHENTICATED)
{
for (Map.Entry<MessageType, AmqpsDeviceOperations> entry : amqpsDeviceOperationsMap.entrySet())
{
if (entry.getValue().onLinkRemoteOpen(linkName))
{
// If the link that is being opened is a sender link and the operation is a DeviceTwin operation, we will send a subscribe message on the opened link
if (entry.getKey() == MessageType.DEVICE_TWIN && linkName.equals(entry.getValue().getSenderLinkTag()))
{
// since we have already checked the message type, we can safely cast it
AmqpsDeviceTwin deviceTwinOperations = (AmqpsDeviceTwin)entry.getValue();
sendMessage(deviceTwinOperations.buildSubscribeToDesiredPropertiesProtonMessage(), entry.getKey(), deviceClientConfig.getDeviceId());
}
return true;
}
}
}
return false;
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
void openLinks(Session session)
{
// Codes_SRS_AMQPSESSIONDEVICEOPERATION_12_042: [The function shall do nothing if the session parameter is null.]
if (session != null)
{
if (this.amqpsAuthenticatorState == AmqpsDeviceAuthenticationState.AUTHENTICATED)
{
synchronized (this.openLock)
{
for (AmqpsDeviceOperations amqpDeviceOperation : this.amqpsDeviceOperationsMap.values())
{
amqpDeviceOperation.openLinks(session);
}
}
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public HttpsResponse send() throws TransportException
{
if (this.url == null)
{
throw new IllegalArgumentException("url cannot be null");
}
HttpsConnection connection = new HttpsConnection(url, method, this.proxySettings);
for (String headerKey : headers.keySet())
{
for (String headerValue : this.headers.get(headerKey))
{
connection.setRequestHeader(headerKey, headerValue);
}
}
connection.writeOutput(this.body);
if (this.sslContext != null)
{
connection.setSSLContext(this.sslContext);
}
if (this.readTimeout != 0)
{
connection.setReadTimeout(this.readTimeout);
}
if (this.connectTimeout != 0)
{
connection.setConnectTimeout(this.connectTimeout);
}
int responseStatus = -1;
byte[] responseBody = new byte[0];
byte[] errorReason = new byte[0];
Map<String, List<String>> headerFields;
// Codes_SRS_HTTPSREQUEST_11_008: [The function shall send an HTTPS request as formatted in the constructor.]
connection.connect();
responseStatus = connection.getResponseStatus();
headerFields = connection.getResponseHeaders();
if (responseStatus == 200)
{
responseBody = connection.readInput();
}
// Codes_SRS_HTTPSREQUEST_11_009: [The function shall return the HTTPS response received, including the status code, body (if 200 status code), header fields, and error reason (if any).]
return new HttpsResponse(responseStatus, responseBody, headerFields, errorReason);
}
#location 46
#vulnerability type RESOURCE_LEAK | #fixed code
public HttpsResponse send() throws TransportException
{
return send(true);
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void getVersionGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String version = testParser.getVersion(3);
//assert
assertNotNull(version);
assertTrue(version.equals(String.valueOf(7)));
}
#location 13
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void getVersionGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String version = Deencapsulation.invoke(testParser, "getVersion", 3);
//assert
assertNotNull(version);
assertTrue(version.equals(String.valueOf(7)));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
void disconnect() {
try {
log.debug("[disconnect] - Closing the device client instance...");
client.closeNow();
}
catch (IOException e) {
log.error("[disconnect] - Exception thrown while closing DeviceClient instance: ", e);
}
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
DeviceClientManager(DeviceClient deviceClient, boolean autoReconnectOnDisconnected) {
this.connectionStatus = ConnectionStatus.DISCONNECTED;
this.client = deviceClient;
this.client.registerConnectionStatusChangeCallback(this, this);
this.autoReconnectOnDisconnected = autoReconnectOnDisconnected;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void handleMessageReturnsNoReceivedMessage() throws IOException
{
new NonStrictExpectations()
{
{
new AmqpsIotHubConnection(mockConfig);
result = mockConnection;
mockConfig.getDeviceTelemetryMessageCallback();
result = mockMessageCallback;
mockConfig.getDeviceId();
result = "deviceId";
}
};
AmqpsTransport transport = new AmqpsTransport(mockConfig);
transport.open();
transport.handleMessage();
Queue<AmqpsMessage> receivedMessages = Deencapsulation.getField(transport, "receivedMessages");
Assert.assertEquals(0, receivedMessages.size());
new Verifications()
{
{
mockMessageCallback.execute((Message) any, any);
times = 0;
}
};
}
#location 15
#vulnerability type RESOURCE_LEAK | #fixed code
@Test
public void handleMessageReturnsNoReceivedMessage() throws IOException
{
new NonStrictExpectations()
{
{
new AmqpsIotHubConnection(mockConfig, 1);
result = mockConnection;
mockConfig.getDeviceTelemetryMessageCallback();
result = mockMessageCallback;
mockConfig.getDeviceId();
result = "deviceId";
}
};
AmqpsTransport transport = new AmqpsTransport(mockConfig);
transport.open();
transport.handleMessage();
Queue<AmqpsMessage> receivedMessages = Deencapsulation.getField(transport, "receivedMessages");
Assert.assertEquals(0, receivedMessages.size());
new Verifications()
{
{
mockMessageCallback.execute((Message) any, any);
times = 0;
}
};
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void getVersionOnTopicWithVersionBeforeRIDGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$version=7&$rid=5";
TopicParser testParser = new TopicParser(validString);
//act
String version = testParser.getVersion(3);
//assert
assertNotNull(version);
assertTrue(version.equals(String.valueOf(7)));
}
#location 13
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void getVersionOnTopicWithVersionBeforeRIDGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$version=7&$rid=5";
TopicParser testParser = new TopicParser(validString);
//act
String version = Deencapsulation.invoke(testParser, "getVersion", 3);
//assert
assertNotNull(version);
assertTrue(version.equals(String.valueOf(7)));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
}
#location 23
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
@ConditionalIgnoreRule.ConditionalIgnore(condition = StandardTierOnlyRule.class)
public void testQueryTwin() throws IOException, InterruptedException, IotHubException, NoSuchAlgorithmException, URISyntaxException, ModuleClientException
{
addMultipleDevices(MAX_DEVICES);
// Add same desired on multiple devices
final String queryProperty = PROPERTY_KEY_QUERY + UUID.randomUUID().toString();
final String queryPropertyValue = PROPERTY_VALUE_QUERY + UUID.randomUUID().toString();
setDesiredProperties(queryProperty, queryPropertyValue, MAX_DEVICES);
// Query multiple devices having same property
final String where = "is_defined(properties.desired." + queryProperty + ")";
SqlQuery sqlQuery = SqlQuery.createSqlQuery("*", SqlQuery.FromType.DEVICES, where, null);
Thread.sleep(MAXIMUM_TIME_FOR_IOTHUB_PROPAGATION_BETWEEN_DEVICE_SERVICE_CLIENTS);
Query twinQuery = sCDeviceTwin.queryTwin(sqlQuery.getQuery(), PAGE_SIZE);
for (int i = 0; i < MAX_DEVICES; i++)
{
if (sCDeviceTwin.hasNextDeviceTwin(twinQuery))
{
DeviceTwinDevice d = sCDeviceTwin.getNextDeviceTwin(twinQuery);
assertNotNull(d.getVersion());
assertEquals(TwinConnectionState.DISCONNECTED.toString(), d.getConnectionState());
for (Pair dp : d.getDesiredProperties())
{
assertEquals(buildExceptionMessage("Unexpected desired property key, expected " + queryProperty + " but was " + dp.getKey(), internalClient), queryProperty, dp.getKey());
assertEquals(buildExceptionMessage("Unexpected desired property value, expected " + queryPropertyValue + " but was " + dp.getValue(), internalClient), queryPropertyValue, dp.getValue());
}
}
}
assertFalse(sCDeviceTwin.hasNextDeviceTwin(twinQuery));
removeMultipleDevices(MAX_DEVICES);
}
#location 35
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
@ConditionalIgnoreRule.ConditionalIgnore(condition = StandardTierOnlyRule.class)
public void testQueryTwin() throws IOException, InterruptedException, IotHubException, GeneralSecurityException, URISyntaxException, ModuleClientException
{
addMultipleDevices(MAX_DEVICES);
// Add same desired on multiple devices
final String queryProperty = PROPERTY_KEY_QUERY + UUID.randomUUID().toString();
final String queryPropertyValue = PROPERTY_VALUE_QUERY + UUID.randomUUID().toString();
setDesiredProperties(queryProperty, queryPropertyValue, MAX_DEVICES);
// Query multiple devices having same property
final String where = "is_defined(properties.desired." + queryProperty + ")";
SqlQuery sqlQuery = SqlQuery.createSqlQuery("*", SqlQuery.FromType.DEVICES, where, null);
Thread.sleep(MAXIMUM_TIME_FOR_IOTHUB_PROPAGATION_BETWEEN_DEVICE_SERVICE_CLIENTS);
Query twinQuery = sCDeviceTwin.queryTwin(sqlQuery.getQuery(), PAGE_SIZE);
for (int i = 0; i < MAX_DEVICES; i++)
{
if (sCDeviceTwin.hasNextDeviceTwin(twinQuery))
{
DeviceTwinDevice d = sCDeviceTwin.getNextDeviceTwin(twinQuery);
assertNotNull(d.getVersion());
assertEquals(TwinConnectionState.DISCONNECTED.toString(), d.getConnectionState());
for (Pair dp : d.getDesiredProperties())
{
assertEquals(buildExceptionMessage("Unexpected desired property key, expected " + queryProperty + " but was " + dp.getKey(), internalClient), queryProperty, dp.getKey());
assertEquals(buildExceptionMessage("Unexpected desired property value, expected " + queryPropertyValue + " but was " + dp.getValue(), internalClient), queryPropertyValue, dp.getValue());
}
}
}
assertFalse(sCDeviceTwin.hasNextDeviceTwin(twinQuery));
removeMultipleDevices(MAX_DEVICES);
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void constructorSetsHttpsMethodCorrectly(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection((URL) any, httpsMethod);
}
};
}
#location 15
#vulnerability type RESOURCE_LEAK | #fixed code
@Test
public void constructorSetsHttpsMethodCorrectly(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection((URL) any, httpsMethod, (Proxy) any);
}
};
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void parsePayloadLooksForValueWithGivenKeyTopic(@Mocked final Mqtt mockMqtt) throws IOException
{
MqttMessaging testMqttMessaging = new MqttMessaging(serverUri, clientId, userName, password);
final String insertTopic = "devices/" + clientId + "/messages/devicebound/abc";
final byte[] insertMessage = {0x61, 0x62, 0x63};
ConcurrentSkipListMap<String, byte[]> testMap = new ConcurrentSkipListMap<String, byte[]>();
testMap.put(insertTopic, insertMessage);
Deencapsulation.setField(mockMqtt, "allReceivedMessages", testMap);
byte[] retrieveMessage = testMqttMessaging.parsePayload(insertTopic);
assertEquals(insertMessage.length, retrieveMessage.length);
for (int i = 0 ; i < retrieveMessage.length; i++)
{
assertEquals(retrieveMessage[i], insertMessage[i]);
}
}
#location 14
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void parsePayloadLooksForValueWithGivenKeyTopic(@Mocked final Mqtt mockMqtt) throws IOException
{
MqttMessaging testMqttMessaging = new MqttMessaging(serverUri, clientId, userName, password);
final String insertTopic = "devices/" + clientId + "/messages/devicebound/abc";
final byte[] insertMessage = {0x61, 0x62, 0x63};
ConcurrentSkipListMap<String, byte[]> testMap = new ConcurrentSkipListMap<String, byte[]>();
testMap.put(insertTopic, insertMessage);
Deencapsulation.setField(mockMqtt, "allReceivedMessages", testMap);
byte[] retrieveMessage = Deencapsulation.invoke(testMqttMessaging, "parsePayload", insertTopic);
assertEquals(insertMessage.length, retrieveMessage.length);
for (int i = 0 ; i < retrieveMessage.length; i++)
{
assertEquals(retrieveMessage[i], insertMessage[i]);
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
log.info("Client connection closed successfully");
}
#location 10
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
private static void uploadFile(DeviceClient client, String baseDirectory, String relativeFileName) throws FileNotFoundException, IOException
{
File file = new File(baseDirectory, relativeFileName);
InputStream inputStream = new FileInputStream(file);
long streamLength = file.length();
if(relativeFileName.startsWith("\\"))
{
relativeFileName = relativeFileName.substring(1);
}
int index = fileNameList.size();
fileNameList.add(relativeFileName);
client.uploadToBlobAsync(relativeFileName, inputStream, streamLength, new FileUploadStatusCallBack(), index);
}
#location 14
#vulnerability type RESOURCE_LEAK | #fixed code
private static void uploadFile(DeviceClient client, String baseDirectory, String relativeFileName) throws FileNotFoundException, IOException, URISyntaxException {
File file = new File(baseDirectory, relativeFileName);
try (InputStream inputStream = new FileInputStream(file))
{
long streamLength = file.length();
if(relativeFileName.startsWith("\\"))
{
relativeFileName = relativeFileName.substring(1);
}
int index = fileNameList.size();
fileNameList.add(relativeFileName);
System.out.println("Getting SAS URI for upload file " + fileNameList.get(index));
FileUploadSasUriResponse sasUriResponse = client.getFileUploadSasUri(new FileUploadSasUriRequest(file.getName()));
try
{
// Note that other versions of the Azure Storage SDK can be used here instead. The latest can be found here:
// https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/storage#azure-storage-sdk-client-library-for-java
System.out.println("Uploading file " + fileNameList.get(index) + " with the retrieved SAS URI...");
CloudBlockBlob blob = new CloudBlockBlob(sasUriResponse.getBlobUri());
blob.upload(inputStream, streamLength);
}
catch (Exception e)
{
// Note that this is done even when the file upload fails. IoT Hub has a fixed number of SAS URIs allowed active
// at any given time. Once you are done with the file upload, you should free your SAS URI so that other
// SAS URIs can be generated. If a SAS URI is not freed through this API, then it will free itself eventually
// based on how long SAS URIs are configured to live on your IoT Hub.
FileUploadCompletionNotification completionNotification = new FileUploadCompletionNotification(sasUriResponse.getCorrelationId(), false);
client.completeFileUploadAsync(completionNotification);
System.out.println("Failed to upload file " + fileNameList.get(index));
e.printStackTrace();
return;
}
finally
{
inputStream.close();
}
FileUploadCompletionNotification completionNotification = new FileUploadCompletionNotification(sasUriResponse.getCorrelationId(), true);
client.completeFileUploadAsync(completionNotification);
System.out.println("Finished file upload for file " + fileNameList.get(index));
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
protected boolean connect() throws IOException {
if (isConnected()) {
return false;
}
if (!channel().isOpen()) {
Closer.close(channel());
setChannel(createSocketChannel(readTimeoutMs, keepAlive));
}
InetSocketAddress inetSocketAddress = new InetSocketAddress(getHost(), getPort());
if (channel().connect(inetSocketAddress)) {
return true;
}
long connectTimeoutLeft = TimeUnit.MILLISECONDS.toNanos(connectTimeoutMs);
long waitTimeoutMs = 10;
long waitTimeoutNs = TimeUnit.MILLISECONDS.toNanos(waitTimeoutMs);
boolean connected;
try {
while (!(connected = channel().finishConnect())) {
Thread.sleep(waitTimeoutMs);
connectTimeoutLeft -= waitTimeoutNs;
if (connectTimeoutLeft <= 0) {
break;
}
}
if (!connected) {
throw new ConnectException("Connection timed out. Cannot connect to " + inetSocketAddress + " within "
+ TimeUnit.NANOSECONDS.toMillis(connectTimeoutLeft) + "ms");
}
return connected;
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new IOException("Connection interrupted", e);
}
}
#location 7
#vulnerability type NULL_DEREFERENCE | #fixed code
protected boolean connect() throws IOException {
if (isConnected()) {
return false;
}
Closer.close(channel());
setChannel(createSocketChannel(readTimeoutMs, keepAlive));
InetSocketAddress inetSocketAddress = new InetSocketAddress(getHost(), getPort());
if (channel().connect(inetSocketAddress)) {
return true;
}
long connectTimeoutLeft = TimeUnit.MILLISECONDS.toNanos(connectTimeoutMs);
long waitTimeoutMs = 10;
long waitTimeoutNs = TimeUnit.MILLISECONDS.toNanos(waitTimeoutMs);
boolean connected;
try {
while (!(connected = channel().finishConnect())) {
Thread.sleep(waitTimeoutMs);
connectTimeoutLeft -= waitTimeoutNs;
if (connectTimeoutLeft <= 0) {
break;
}
}
if (!connected) {
throw new ConnectException("Connection timed out. Cannot connect to " + inetSocketAddress + " within "
+ TimeUnit.NANOSECONDS.toMillis(connectTimeoutLeft) + "ms");
}
return connected;
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new IOException("Connection interrupted", e);
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public boolean sendMessage(GelfMessage message) {
if (isShutdown()) {
return false;
}
IOException exception = null;
for (int i = 0; i < deliveryAttempts; i++) {
try {
// (re)-connect if necessary
if (!isConnected()) {
synchronized (ioLock) {
connect();
}
}
ByteBuffer buffer;
if (INITIAL_BUFFER_SIZE == 0) {
buffer = message.toTCPBuffer();
} else {
buffer = GelfBuffers.toTCPBuffer(message, writeBuffers);
}
synchronized (ioLock) {
write(buffer);
}
return true;
} catch (IOException e) {
Closer.close(channel());
exception = e;
}
}
if (exception != null) {
reportError(exception.getMessage(),
new IOException("Cannot send data to " + getHost() + ":" + getPort(), exception));
}
return false;
}
#location 13
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public boolean sendMessage(GelfMessage message) {
if (isShutdown()) {
return false;
}
IOException exception = null;
for (int i = 0; i < deliveryAttempts; i++) {
try {
// (re)-connect if necessary
if (!isConnected()) {
synchronized (ioLock) {
connect();
}
}
ByteBuffer buffer;
if (INITIAL_BUFFER_SIZE == 0) {
buffer = message.toTCPBuffer();
} else {
buffer = GelfBuffers.toTCPBuffer(message, writeBuffers);
}
try {
synchronized (ioLock) {
write(buffer);
}
} catch (InterruptedException e) {
reportError(e.getMessage(), new IOException("Cannot send data to " + getHost() + ":" + getPort(), e));
Thread.currentThread().interrupt();
return false;
}
return true;
} catch (IOException e) {
Closer.close(channel());
exception = e;
}
}
if (exception != null) {
reportError(exception.getMessage(),
new IOException("Cannot send data to " + getHost() + ":" + getPort(), exception));
}
return false;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public boolean sendMessage(GelfMessage message) {
if (shutdown) {
return false;
}
try {
// reconnect if necessary
if (socket == null) {
socket = new Socket(host, port);
}
socket.getOutputStream().write(message.toTCPBuffer().array());
return true;
} catch (IOException e) {
errorReporter.reportError(e.getMessage(), new IOException("Cannot send data to " + host + ":" + port, e));
// if an error occours, signal failure
socket = null;
return false;
}
}
#location 12
#vulnerability type NULL_DEREFERENCE | #fixed code
public boolean sendMessage(GelfMessage message) {
if (shutdown) {
return false;
}
try {
// reconnect if necessary
if (socket == null) {
socket = createSocket();
}
socket.getOutputStream().write(message.toTCPBuffer().array());
return true;
} catch (IOException e) {
errorReporter.reportError(e.getMessage(), new IOException("Cannot send data to " + host + ":" + port, e));
// if an error occours, signal failure
socket = null;
return false;
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public ByteBuffer[] toUDPBuffers() {
byte[] messageBytes = gzipMessage(toJsonByteArray("_"));
if (messageBytes.length > maximumMessageSize) {
// calculate the length of the datagrams array
int datagrams_length = messageBytes.length / maximumMessageSize;
// In case of a remainder, due to the integer division, add a extra datagram
if (messageBytes.length % maximumMessageSize != 0) {
datagrams_length++;
}
ByteBuffer targetBuffer = ByteBuffer.allocate(messageBytes.length + (datagrams_length * 12));
return sliceDatagrams(ByteBuffer.wrap(messageBytes), datagrams_length, targetBuffer);
}
ByteBuffer[] datagrams = new ByteBuffer[1];
datagrams[0] = ByteBuffer.allocate(messageBytes.length);
datagrams[0].put(messageBytes);
datagrams[0].flip();
return datagrams;
}
#location 5
#vulnerability type NULL_DEREFERENCE | #fixed code
public ByteBuffer[] toUDPBuffers() {
byte[] messageBytes = gzipMessage(toJsonByteArray("_"));
if (messageBytes.length > maximumMessageSize) {
// calculate the length of the datagrams array
int datagramsLength = messageBytes.length / maximumMessageSize;
// In case of a remainder, due to the integer division, add a extra datagram
if (messageBytes.length % maximumMessageSize != 0) {
datagramsLength++;
}
ByteBuffer targetBuffer = ByteBuffer.allocate(messageBytes.length + (datagramsLength * 12));
return sliceDatagrams(ByteBuffer.wrap(messageBytes), datagramsLength, targetBuffer);
}
ByteBuffer[] datagrams = new ByteBuffer[1];
datagrams[0] = ByteBuffer.allocate(messageBytes.length);
datagrams[0].put(messageBytes);
datagrams[0].flip();
return datagrams;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public boolean sendMessage(GelfMessage message) {
if (shutdown) {
return false;
}
try {
// reconnect if necessary
if (socket == null) {
socket = createSocket();
}
socket.getOutputStream().write(message.toTCPBuffer().array());
return true;
} catch (IOException e) {
errorReporter.reportError(e.getMessage(), new IOException("Cannot send data to " + host + ":" + port, e));
// if an error occours, signal failure
socket = null;
return false;
}
}
#location 18
#vulnerability type RESOURCE_LEAK | #fixed code
public boolean sendMessage(GelfMessage message) {
if (shutdown) {
return false;
}
IOException exception = null;
for (int i = 0; i < deliveryAttempts; i++) {
try {
// reconnect if necessary
if (socket == null) {
socket = createSocket();
}
socket.getOutputStream().write(message.toTCPBuffer().array());
return true;
} catch (IOException e) {
exception = e;
// if an error occours, signal failure
socket = null;
}
}
if (exception != null) {
errorReporter.reportError(exception.getMessage(), new IOException("Cannot send data to " + host + ":" + port,
exception));
}
return false;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public synchronized void put(String key, Entry entry) {
pruneIfNeeded(entry.data.length);
File file = getFileForKey(key);
try {
FileOutputStream fos = new FileOutputStream(file);
CacheHeader e = new CacheHeader(key, entry);
boolean success = e.writeHeader(fos);
if (!success) {
fos.close();
VolleyLog.d("Failed to write header for %s", file.getAbsolutePath());
throw new IOException();
}
fos.write(entry.data);
fos.close();
putEntry(key, e);
return;
} catch (IOException e) {
}
boolean deleted = file.delete();
if (!deleted) {
VolleyLog.d("Could not clean up file %s", file.getAbsolutePath());
}
}
#location 18
#vulnerability type RESOURCE_LEAK | #fixed code
@Override
public synchronized void put(String key, Entry entry) {
pruneIfNeeded(entry.data.length);
File file = getFileForKey(key);
try {
BufferedOutputStream fos = new BufferedOutputStream(new FileOutputStream(file));
CacheHeader e = new CacheHeader(key, entry);
boolean success = e.writeHeader(fos);
if (!success) {
fos.close();
VolleyLog.d("Failed to write header for %s", file.getAbsolutePath());
throw new IOException();
}
fos.write(entry.data);
fos.close();
putEntry(key, e);
return;
} catch (IOException e) {
}
boolean deleted = file.delete();
if (!deleted) {
VolleyLog.d("Could not clean up file %s", file.getAbsolutePath());
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public synchronized Entry get(String key) {
CacheHeader entry = mEntries.get(key);
// if the entry does not exist, return.
if (entry == null) {
return null;
}
File file = getFileForKey(key);
CountingInputStream cis = null;
try {
cis = new CountingInputStream(new FileInputStream(file));
CacheHeader.readHeader(cis); // eat header
byte[] data = streamToBytes(cis, (int) (file.length() - cis.bytesRead));
return entry.toCacheEntry(data);
} catch (IOException e) {
VolleyLog.d("%s: %s", file.getAbsolutePath(), e.toString());
remove(key);
return null;
} finally {
if (cis != null) {
try {
cis.close();
} catch (IOException ioe) {
return null;
}
}
}
}
#location 12
#vulnerability type RESOURCE_LEAK | #fixed code
@Override
public synchronized Entry get(String key) {
CacheHeader entry = mEntries.get(key);
// if the entry does not exist, return.
if (entry == null) {
return null;
}
File file = getFileForKey(key);
CountingInputStream cis = null;
try {
cis = new CountingInputStream(new BufferedInputStream(new FileInputStream(file)));
CacheHeader.readHeader(cis); // eat header
byte[] data = streamToBytes(cis, (int) (file.length() - cis.bytesRead));
return entry.toCacheEntry(data);
} catch (IOException e) {
VolleyLog.d("%s: %s", file.getAbsolutePath(), e.toString());
remove(key);
return null;
} finally {
if (cis != null) {
try {
cis.close();
} catch (IOException ioe) {
return null;
}
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public SourceEntry buildEntry(File sourceDir, String path) {
path = FilenameUtils.separatorsToUnix(path);
String[] arr = StringUtils.split(path, "/");
SourceEntry entry = null;
int i = 0;
for(String s: arr){
System.out.println("[" + (i++) + "]: " + s);
sourceDir = new File(sourceDir, s);
entry = new SourceEntry(entry, sourceDir);
}
System.out.println(entry.getPath());
System.out.println(entry.getName());
System.out.println(entry.getFile().getAbsolutePath());
System.out.println(entry.getParent().getFile().getAbsolutePath());
return entry;
}
#location 14
#vulnerability type NULL_DEREFERENCE | #fixed code
@Override
public SourceEntry buildEntry(File sourceDir, String path) {
path = FilenameUtils.separatorsToUnix(path);
String[] arr = StringUtils.split(path, "/");
SourceEntry entry = null;
for(String s: arr){
sourceDir = new File(sourceDir, s);
entry = new SourceEntry(entry, sourceDir);
}
return entry;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse respone = client.execute(request);
parseResponse(respone);
} catch (LogCallback.DoneException e) {
finish();
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse response = client.execute(request);
parseResponse(response);
} catch (LogCallback.DoneException e) {
// Signifies we're finished with the log stream.
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void testSystemProperty() throws Exception {
System.setProperty("docker.username","roland");
System.setProperty("docker.password", "secret");
System.setProperty("docker.email", "[email protected]");
try {
AuthConfig config = factory.createAuthConfig(null,settings, null, null);
verifyAuthConfig(config,"roland","secret","[email protected]");
} finally {
System.clearProperty("docker.username");
System.clearProperty("docker.password");
System.clearProperty("docker.email");
}
}
#location 8
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void testSystemProperty() throws Exception {
System.setProperty("docker.push.username","roland");
System.setProperty("docker.push.password", "secret");
System.setProperty("docker.push.email", "[email protected]");
try {
AuthConfig config = factory.createAuthConfig(true, null, settings, null, null);
verifyAuthConfig(config,"roland","secret","[email protected]");
} finally {
System.clearProperty("docker.push.username");
System.clearProperty("docker.push.password");
System.clearProperty("docker.push.email");
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void variableReplacement() throws MojoExecutionException {
PortMapping mapping = createPortMapping("jolokia.port:8080","18181:8181","127.0.0.1:9090:9090", "127.0.0.1:other.port:5678");
updateDynamicMapping(mapping, 8080, 49900);
updateDynamicMapping(mapping, 5678, 49901);
mapAndVerifyReplacement(mapping,
"http://localhost:49900/", "http://localhost:${jolokia.port}/",
"http://pirx:49900/", "http://pirx:${ jolokia.port}/");
mapAndVerifyReplacement(mapping,
"http://localhost:49901/", "http://localhost:${other.port}/",
"http://pirx:49901/", "http://pirx:${ other.port}/");
assertEquals((int) mapping.getPortVariables().get("jolokia.port"), 49900);
assertEquals((int) mapping.getPortVariables().get("other.port"), 49901);
assertTrue(mapping.containsDynamicPorts());
assertEquals(4, mapping.getContainerPorts().size());
assertEquals(4, mapping.getPortsMap().size());
assertEquals(2, mapping.getBindToHostMap().size());
assertEquals(49900, (long) mapping.getPortVariables().get("jolokia.port"));
assertEquals(49901, (long) mapping.getPortVariables().get("other.port"));
Map<String,Integer> p = mapping.getPortsMap();
assertEquals(p.size(),4);
assertNull(p.get("8080/tcp"));
assertNull(p.get("5678/tcp"));
assertEquals(18181, (long) p.get("8181/tcp"));
assertEquals(9090, (long) p.get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("5678/tcp"));
}
#location 18
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void variableReplacement() throws MojoExecutionException {
PortMapping mapping = createPortMapping("jolokia.port:8080","18181:8181","127.0.0.1:9090:9090", "127.0.0.1:other.port:5678");
updateDynamicMapping(mapping, 8080, 49900);
updateDynamicMapping(mapping, 5678, 49901);
mapAndVerifyReplacement(mapping,
"http://localhost:49900/", "http://localhost:${jolokia.port}/",
"http://pirx:49900/", "http://pirx:${ jolokia.port}/");
mapAndVerifyReplacement(mapping,
"http://localhost:49901/", "http://localhost:${other.port}/",
"http://pirx:49901/", "http://pirx:${ other.port}/",
"http://49900/49901","http://${jolokia.port}/${other.port}");
assertEquals((int) mapping.getPortVariables().get("jolokia.port"), 49900);
assertEquals((int) mapping.getPortVariables().get("other.port"), 49901);
assertTrue(mapping.containsDynamicPorts());
assertEquals(4, mapping.getContainerPorts().size());
assertEquals(4, mapping.getPortsMap().size());
assertEquals(2, mapping.getBindToHostMap().size());
assertEquals(49900, (long) mapping.getPortVariables().get("jolokia.port"));
assertEquals(49901, (long) mapping.getPortVariables().get("other.port"));
Map<String,Integer> p = mapping.getPortsMap();
assertEquals(p.size(),4);
assertNull(p.get("8080/tcp"));
assertNull(p.get("5678/tcp"));
assertEquals(18181, (long) p.get("8181/tcp"));
assertEquals(9090, (long) p.get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("5678/tcp"));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public BuildService getBuildService() {
checkInitialization();
return buildService;
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public BuildService getBuildService() {
checkDockerAccessInitialization();
return buildService;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
private String convert(HttpEntity entity) {
try {
if (entity.isStreaming()) {
return entity.toString();
}
InputStreamReader is = new InputStreamReader(entity.getContent());
StringBuilder sb = new StringBuilder();
BufferedReader br = new BufferedReader(is);
String read = br.readLine();
while (read != null) {
//System.out.println(read);
sb.append(read);
read = br.readLine();
}
return sb.toString();
} catch (IOException e) {
return "[error serializing inputstream for debugging]";
}
}
#location 17
#vulnerability type RESOURCE_LEAK | #fixed code
private String convert(HttpEntity entity) {
try {
if (entity.isStreaming()) {
return entity.toString();
}
InputStreamReader is = new InputStreamReader(entity.getContent(),"UTF-8");
StringBuilder sb = new StringBuilder();
try (BufferedReader br = new BufferedReader(is)) {
String read = br.readLine();
while (read != null) {
//System.out.println(read);
sb.append(read);
read = br.readLine();
}
return sb.toString();
}
} catch (IOException e) {
return "[error serializing inputstream for debugging]";
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public ArchiveService getArchiveService() {
checkBaseInitialization();
return archiveService;
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public ArchiveService getArchiveService() {
return archiveService;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public File createDockerTarArchive(String imageName, MojoParameters params, BuildImageConfiguration buildConfig) throws MojoExecutionException {
AssemblyConfiguration assemblyConfig = buildConfig.getAssemblyConfiguration();
BuildDirs buildDirs = createBuildDirs(imageName, params);
try {
if (assemblyConfig != null &&
(assemblyConfig.getInline() != null ||
assemblyConfig.getDescriptor() != null ||
assemblyConfig.getDescriptorRef() != null)) {
createAssemblyArchive(assemblyConfig, params, buildDirs);
}
File extraDir = null;
String dockerFileDir = assemblyConfig != null ? assemblyConfig.getDockerFileDir() : null;
if (dockerFileDir != null) {
// Use specified docker directory which must include a Dockerfile.
extraDir = validateDockerDir(params, dockerFileDir);
} else {
// Create custom docker file in output dir
DockerFileBuilder builder = createDockerFileBuilder(buildConfig, assemblyConfig);
builder.write(buildDirs.getOutputDirectory());
}
return createTarball(buildDirs, extraDir, assemblyConfig.getMode());
} catch (IOException e) {
throw new MojoExecutionException(String.format("Cannot create Dockerfile in %s", buildDirs.getOutputDirectory()), e);
}
}
#location 23
#vulnerability type NULL_DEREFERENCE | #fixed code
public File createDockerTarArchive(String imageName, MojoParameters params, BuildImageConfiguration buildConfig) throws MojoExecutionException {
BuildDirs buildDirs = createBuildDirs(imageName, params);
AssemblyConfiguration assemblyConfig = buildConfig.getAssemblyConfiguration();
AssemblyMode assemblyMode = (assemblyConfig == null) ? AssemblyMode.dir : assemblyConfig.getMode();
if (hasAssemblyConfiguration(assemblyConfig)) {
createAssemblyArchive(assemblyConfig, params, buildDirs);
}
try {
File extraDir = null;
String dockerFileDir = assemblyConfig != null ? assemblyConfig.getDockerFileDir() : null;
if (dockerFileDir != null) {
// Use specified docker directory which must include a Dockerfile.
extraDir = validateDockerDir(params, dockerFileDir);
} else {
// Create custom docker file in output dir
DockerFileBuilder builder = createDockerFileBuilder(buildConfig, assemblyConfig);
builder.write(buildDirs.getOutputDirectory());
}
return createTarball(buildDirs, extraDir, assemblyMode);
} catch (IOException e) {
throw new MojoExecutionException(String.format("Cannot create Dockerfile in %s", buildDirs.getOutputDirectory()), e);
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public ArchiveService getArchiveService() {
checkBaseInitialization();
return archiveService;
}
#location 2
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public ArchiveService getArchiveService() {
return archiveService;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
protected void executeInternal(ServiceHub hub) throws MojoExecutionException, DockerAccessException {
QueryService queryService = hub.getQueryService();
LogDispatcher logDispatcher = getLogDispatcher(hub);
for (ImageConfiguration image : getResolvedImages()) {
String imageName = image.getName();
if (logAll) {
for (Container container : queryService.getContainersForImage(imageName)) {
doLogging(logDispatcher, image, container.getId());
}
} else {
Container container = queryService.getLatestContainerForImage(imageName);
doLogging(logDispatcher, image, container.getId());
}
}
if (follow) {
// Block forever ....
waitForEver();
}
}
#location 10
#vulnerability type NULL_DEREFERENCE | #fixed code
@Override
protected void executeInternal(ServiceHub hub) throws MojoExecutionException, DockerAccessException {
QueryService queryService = hub.getQueryService();
LogDispatcher logDispatcher = getLogDispatcher(hub);
for (ImageConfiguration image : getResolvedImages()) {
String imageName = image.getName();
if (logAll) {
for (Container container : queryService.getContainersForImage(imageName)) {
doLogging(logDispatcher, image, container.getId());
}
} else {
Container container = queryService.getLatestContainerForImage(imageName);
if (container != null) {
doLogging(logDispatcher, image, container.getId());
}
}
}
if (follow) {
// Block forever ....
waitForEver();
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
private void checkDockerLogin(File homeDir,String configRegistry, String lookupRegistry) throws IOException,
MojoExecutionException {
createDockerConfig(homeDir, "roland", "secret", "[email protected]", configRegistry);
AuthConfig config = factory.createAuthConfig(null, settings, "roland", lookupRegistry);
verifyAuthConfig(config,"roland","secret","[email protected]");
}
#location 5
#vulnerability type NULL_DEREFERENCE | #fixed code
private void checkDockerLogin(File homeDir,String configRegistry, String lookupRegistry)
throws IOException, MojoExecutionException {
createDockerConfig(homeDir, "roland", "secret", "[email protected]", configRegistry);
AuthConfig config = factory.createAuthConfig(isPush, null, settings, "roland", lookupRegistry);
verifyAuthConfig(config,"roland","secret","[email protected]");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
protected WatchService.WatchContext getWatchContext(ServiceHub hub) throws MojoExecutionException {
return new WatchService.WatchContext.Builder()
.watchInterval(watchInterval)
.watchMode(watchMode)
.watchPostGoal(watchPostGoal)
.watchPostExec(watchPostExec)
.autoCreateCustomNetworks(autoCreateCustomNetworks)
.keepContainer(keepContainer)
.keepRunning(keepRunning)
.removeVolumes(removeVolumes)
.containerNamePattern(containerNamePattern)
.buildTimestamp(getBuildTimestamp())
.pomLabel(getPomLabel())
.mojoParameters(createMojoParameters())
.follow(follow())
.showLogs(showLogs())
.serviceHubFactory(serviceHubFactory)
.hub(hub)
.dispatcher(getLogDispatcher(hub))
.build();
}
#location 13
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
protected WatchService.WatchContext getWatchContext(ServiceHub hub) throws IOException {
return new WatchService.WatchContext.Builder()
.watchInterval(watchInterval)
.watchMode(watchMode)
.watchPostGoal(watchPostGoal)
.watchPostExec(watchPostExec)
.autoCreateCustomNetworks(autoCreateCustomNetworks)
.keepContainer(keepContainer)
.keepRunning(keepRunning)
.removeVolumes(removeVolumes)
.containerNamePattern(containerNamePattern)
.buildTimestamp(getBuildTimestamp())
.pomLabel(getGavLabel())
.mojoParameters(createMojoParameters())
.follow(follow())
.showLogs(showLogs())
.serviceHubFactory(serviceHubFactory)
.hub(hub)
.dispatcher(getLogDispatcher(hub))
.build();
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse respone = client.execute(request);
parseResponse(respone);
} catch (LogCallback.DoneException e) {
finish();
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
}
#location 5
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse response = client.execute(request);
parseResponse(response);
} catch (LogCallback.DoneException e) {
// Signifies we're finished with the log stream.
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void testFromSettingsDefault() throws MojoExecutionException {
setupServers();
AuthConfig config = factory.createAuthConfig(null,settings, "rhuss", "test.org");
assertNotNull(config);
verifyAuthConfig(config, "rhuss", "secret2", "[email protected]");
}
#location 6
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void testFromSettingsDefault() throws MojoExecutionException {
setupServers();
AuthConfig config = factory.createAuthConfig(isPush, null, settings, "rhuss", "test.org");
assertNotNull(config);
verifyAuthConfig(config, "rhuss", "secret2", "[email protected]");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public RunService getRunService() {
checkInitialization();
return runService;
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public RunService getRunService() {
checkDockerAccessInitialization();
return runService;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
protected void executeInternal(ServiceHub serviceHub) throws DockerAccessException, MojoExecutionException {
if (file == null) {
throw new MojoExecutionException("'file' is required.");
}
if (name == null && alias == null) {
throw new MojoExecutionException("'name' or 'alias' is required.");
}
// specify image by name or alias
if (name != null && alias != null) {
throw new MojoExecutionException("Cannot specify both name and alias.");
}
List<ImageConfiguration> images = getResolvedImages();
ImageConfiguration image = null;
for (ImageConfiguration ic : images) {
if (name != null && name.equals(ic.getName())) {
image = ic;
break;
}
if (alias != null && alias.equals(ic.getAlias())) {
image = ic;
break;
}
}
if (serviceHub.getQueryService().getImageId(image.getName()) == null) {
throw new MojoExecutionException("No image found for " + image.getName());
}
serviceHub.getDockerAccess().saveImage(image.getName(), file, detectCompression(file));
if (attach) {
File fileObj = new File(file);
if (fileObj.exists()) {
String type = FilenameUtils.getExtension(file);
if (classifier != null) {
projectHelper.attachArtifact(project, type, classifier, fileObj);
} else {
projectHelper.attachArtifact(project, type, fileObj);
}
}
}
}
#location 27
#vulnerability type NULL_DEREFERENCE | #fixed code
@Override
protected void executeInternal(ServiceHub serviceHub) throws DockerAccessException, MojoExecutionException {
if (skip) {
return;
}
String imageName = getImageName();
String fileName = getFileName(imageName);
log.info("Saving image %s to %s", imageName, fileName);
if (!serviceHub.getQueryService().hasImage(imageName)) {
throw new MojoExecutionException("No image " + imageName + " exists");
}
serviceHub.getDockerAccess().saveImage(imageName, fileName, ArchiveCompression.fromFileName(fileName));
if (attach) {
attachSaveArchive();
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void testFromPluginConfiguration() throws MojoExecutionException {
Map pluginConfig = new HashMap();
pluginConfig.put("username", "roland");
pluginConfig.put("password", "secret");
pluginConfig.put("email", "[email protected]");
AuthConfig config = factory.createAuthConfig(pluginConfig,settings,null,null);
verifyAuthConfig(config, "roland", "secret", "[email protected]");
}
#location 9
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void testFromPluginConfiguration() throws MojoExecutionException {
Map pluginConfig = new HashMap();
pluginConfig.put("username", "roland");
pluginConfig.put("password", "secret");
pluginConfig.put("email", "[email protected]");
AuthConfig config = factory.createAuthConfig(isPush, pluginConfig, settings, null, null);
verifyAuthConfig(config, "roland", "secret", "[email protected]");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void testFromSettingsDefault2() throws MojoExecutionException {
setupServers();
AuthConfig config = factory.createAuthConfig(null,settings,"tanja",null);
assertNotNull(config);
verifyAuthConfig(config,"tanja","doublesecret","[email protected]");
}
#location 6
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void testFromSettingsDefault2() throws MojoExecutionException {
setupServers();
AuthConfig config = factory.createAuthConfig(isPush, null, settings, "tanja", null);
assertNotNull(config);
verifyAuthConfig(config,"tanja","doublesecret","[email protected]");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public MojoExecutionService getMojoExecutionService() {
checkBaseInitialization();
return mojoExecutionService;
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public MojoExecutionService getMojoExecutionService() {
return mojoExecutionService;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void filter() throws Exception {
List<ImageConfiguration> configs = Arrays.asList(new ImageConfiguration.Builder().name("test").build());
CatchingLog logCatcher = new CatchingLog();
List<ImageConfiguration> result = ConfigHelper.resolveImages(
new AnsiLogger(logCatcher, true, true),
configs, createResolver(), "bla", createCustomizer());
assertEquals(0,result.size());
assertTrue(resolverCalled);
assertTrue(customizerCalled);
assertTrue(logCatcher.getWarnMessage().contains("test"));
assertTrue(logCatcher.getWarnMessage().contains("bla"));
}
#location 11
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void filter() throws Exception {
List<ImageConfiguration> configs = Arrays.asList(new ImageConfiguration.Builder().name("test").build());
CatchingLog logCatcher = new CatchingLog();
List<ImageConfiguration> result = ConfigHelper.resolveImages(
new AnsiLogger(logCatcher, true, "build"),
configs, createResolver(), "bla", createCustomizer());
assertEquals(0,result.size());
assertTrue(resolverCalled);
assertTrue(customizerCalled);
assertTrue(logCatcher.getWarnMessage().contains("test"));
assertTrue(logCatcher.getWarnMessage().contains("bla"));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public QueryService getQueryService() {
checkInitialization();
return queryService;
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public QueryService getQueryService() {
checkDockerAccessInitialization();
return queryService;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public synchronized void fetchContainerLog(String containerId, LogOutputSpec spec) throws FileNotFoundException {
dockerAccess.getLogSync(containerId, new DefaultLogCallback(spec));
}
#location 2
#vulnerability type RESOURCE_LEAK | #fixed code
public synchronized void fetchContainerLog(String containerId, LogOutputSpec spec) throws FileNotFoundException {
dockerAccess.getLogSync(containerId, createLogCallback(spec));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void testFromSettingsSimple() throws MojoExecutionException {
setupServers();
AuthConfig config = factory.createAuthConfig(null,settings, "roland", "test.org");
assertNotNull(config);
verifyAuthConfig(config, "roland", "secret", "[email protected]");
}
#location 6
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void testFromSettingsSimple() throws MojoExecutionException {
setupServers();
AuthConfig config = factory.createAuthConfig(isPush, null, settings, "roland", "test.org");
assertNotNull(config);
verifyAuthConfig(config, "roland", "secret", "[email protected]");
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public MojoExecutionService getMojoExecutionService() {
checkBaseInitialization();
return mojoExecutionService;
}
#location 2
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public MojoExecutionService getMojoExecutionService() {
return mojoExecutionService;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public synchronized void trackContainerLog(String containerId, LogOutputSpec spec) throws FileNotFoundException {
LogGetHandle handle = dockerAccess.getLogAsync(containerId, new DefaultLogCallback(spec));
logHandles.put(containerId, handle);
}
#location 2
#vulnerability type RESOURCE_LEAK | #fixed code
public synchronized void trackContainerLog(String containerId, LogOutputSpec spec) throws FileNotFoundException {
LogGetHandle handle = dockerAccess.getLogAsync(containerId, createLogCallback(spec));
logHandles.put(containerId, handle);
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse respone = client.execute(request);
parseResponse(respone);
} catch (LogCallback.DoneException e) {
finish();
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
}
#location 6
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse response = client.execute(request);
parseResponse(response);
} catch (LogCallback.DoneException e) {
// Signifies we're finished with the log stream.
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Test
public void variableReplacement() throws MojoExecutionException {
PortMapping mapping = createPortMapping("jolokia.port:8080","18181:8181","127.0.0.1:9090:9090", "127.0.0.1:other.port:5678");
updateDynamicMapping(mapping, 8080, 49900);
updateDynamicMapping(mapping, 5678, 49901);
mapAndVerifyReplacement(mapping,
"http://localhost:49900/", "http://localhost:${jolokia.port}/",
"http://pirx:49900/", "http://pirx:${ jolokia.port}/");
mapAndVerifyReplacement(mapping,
"http://localhost:49901/", "http://localhost:${other.port}/",
"http://pirx:49901/", "http://pirx:${ other.port}/");
assertEquals((int) mapping.getPortVariables().get("jolokia.port"), 49900);
assertEquals((int) mapping.getPortVariables().get("other.port"), 49901);
assertTrue(mapping.containsDynamicPorts());
assertEquals(4, mapping.getContainerPorts().size());
assertEquals(4, mapping.getPortsMap().size());
assertEquals(2, mapping.getBindToHostMap().size());
assertEquals(49900, (long) mapping.getPortVariables().get("jolokia.port"));
assertEquals(49901, (long) mapping.getPortVariables().get("other.port"));
Map<String,Integer> p = mapping.getPortsMap();
assertEquals(p.size(),4);
assertNull(p.get("8080/tcp"));
assertNull(p.get("5678/tcp"));
assertEquals(18181, (long) p.get("8181/tcp"));
assertEquals(9090, (long) p.get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("5678/tcp"));
}
#location 17
#vulnerability type NULL_DEREFERENCE | #fixed code
@Test
public void variableReplacement() throws MojoExecutionException {
PortMapping mapping = createPortMapping("jolokia.port:8080","18181:8181","127.0.0.1:9090:9090", "127.0.0.1:other.port:5678");
updateDynamicMapping(mapping, 8080, 49900);
updateDynamicMapping(mapping, 5678, 49901);
mapAndVerifyReplacement(mapping,
"http://localhost:49900/", "http://localhost:${jolokia.port}/",
"http://pirx:49900/", "http://pirx:${ jolokia.port}/");
mapAndVerifyReplacement(mapping,
"http://localhost:49901/", "http://localhost:${other.port}/",
"http://pirx:49901/", "http://pirx:${ other.port}/",
"http://49900/49901","http://${jolokia.port}/${other.port}");
assertEquals((int) mapping.getPortVariables().get("jolokia.port"), 49900);
assertEquals((int) mapping.getPortVariables().get("other.port"), 49901);
assertTrue(mapping.containsDynamicPorts());
assertEquals(4, mapping.getContainerPorts().size());
assertEquals(4, mapping.getPortsMap().size());
assertEquals(2, mapping.getBindToHostMap().size());
assertEquals(49900, (long) mapping.getPortVariables().get("jolokia.port"));
assertEquals(49901, (long) mapping.getPortVariables().get("other.port"));
Map<String,Integer> p = mapping.getPortsMap();
assertEquals(p.size(),4);
assertNull(p.get("8080/tcp"));
assertNull(p.get("5678/tcp"));
assertEquals(18181, (long) p.get("8181/tcp"));
assertEquals(9090, (long) p.get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("5678/tcp"));
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public static String getVersion() {
final InputStream is = Version.class
.getResourceAsStream("/META-INF/maven/com.github.cflint/CFLint/pom.properties");
try {
final BufferedReader reader = new BufferedReader(new InputStreamReader(is));
String line = reader.readLine();
while (line != null && !line.startsWith("version=")) {
line = reader.readLine();
}
if (line != null) {
return line.replaceAll("version=", "");
}
} catch (final Exception e) {
try {
if (is != null) {
is.close();
}
} catch (final IOException e1) {
e1.printStackTrace();
}
}
return "";
}
#location 13
#vulnerability type RESOURCE_LEAK | #fixed code
public static String getVersion() {
try {
return CFLintMain.class.getPackage().getImplementationVersion();
} catch (Exception e) {
return "";
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
private void execute() throws IOException, TransformerException, JAXBException {
CFLintConfig config = null;
if(configfile != null){
if(configfile.toLowerCase().endsWith(".xml")){
config = ConfigUtils.unmarshal(new FileInputStream(configfile), CFLintConfig.class);
}else{
config = ConfigUtils.unmarshalJson(new FileInputStream(configfile), CFLintConfig.class);
}
}
final CFLint cflint = new CFLint(config);
cflint.setVerbose(verbose);
cflint.setLogError(logerror);
cflint.setQuiet(quiet);
cflint.setShowProgress(showprogress);
cflint.setProgressUsesThread(progressUsesThread);
if(extensions != null && extensions.trim().length() > 0){
try{
cflint.setAllowedExtensions(Arrays.asList(extensions.trim().split(",")));
}catch(Exception e){
System.err.println("Unable to use extensions (" + extensions + ") using default instead. " + e.getMessage());
}
}
CFLintFilter filter = CFLintFilter.createFilter(verbose);
if(filterFile != null){
File ffile = new File(filterFile);
if(ffile.exists()){
FileInputStream fis = new FileInputStream(ffile);
byte b[] = new byte[fis.available()];
fis.read(b);
filter = CFLintFilter.createFilter(new String(b),verbose);
}
}
if (excludeCodes != null && excludeCodes.length > 0) {
filter.excludeCode(excludeCodes);
}
if (includeCodes != null && includeCodes.length > 0) {
filter.includeCode(includeCodes);
}
cflint.getBugs().setFilter(filter);
for (final String scanfolder : folder) {
cflint.scan(scanfolder);
}
if (stdIn) {
StringBuilder source = new StringBuilder();
Scanner scanner = new Scanner(System.in);
while (scanner.hasNextLine()) {
String nextLine = scanner.nextLine();
source.append(nextLine);
source.append(System.lineSeparator());
}
scanner.close();
cflint.process(source.toString(), stdInFile);
}
if (xmlOutput) {
Writer xmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(xmlOutFile);
if ("findbugs".equalsIgnoreCase(xmlstyle)) {
if(verbose) {
display("Writing XML findbugs style" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().outputFindBugs(cflint.getBugs(), xmlwriter);
} else {
if(verbose) {
display("Writing XML" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().output(cflint.getBugs(), xmlwriter);
}
}
if (textOutput) {
if(textOutFile != null){
if(verbose) {
display("Writing text" + (stdOut ? "." : " to " + textOutFile));
}
}
Writer textwriter = stdOut || textOutFile==null ? new OutputStreamWriter(System.out) : new FileWriter(textOutFile);
new TextOutput().output(cflint.getBugs(), textwriter);
}
if (htmlOutput) {
try {
if(verbose) {
display("Writing HTML" + (stdOut ? "." : " to " + htmlOutFile));
}
Writer htmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(htmlOutFile);
new HTMLOutput(htmlStyle).output(cflint.getBugs(), htmlwriter);
} catch (final TransformerException e) {
throw new IOException(e);
}
}
if (jsonOutput) {
if(verbose) {
display("Writing JSON" + (stdOut ? "." : " to " + jsonOutFile));
}
Writer jsonwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(jsonOutFile);
new JSONOutput().output(cflint.getBugs(), jsonwriter);
}
if (includeCodes != null) {
cflint.getBugs().getFilter().includeCode(includeCodes);
}
if (excludeCodes != null) {
cflint.getBugs().getFilter().excludeCode(excludeCodes);
}
}
#location 30
#vulnerability type RESOURCE_LEAK | #fixed code
private void execute() throws IOException, TransformerException, JAXBException {
final CFLint cflint = new CFLint(loadConfig(configfile));
cflint.setVerbose(verbose);
cflint.setLogError(logerror);
cflint.setQuiet(quiet);
cflint.setShowProgress(showprogress);
cflint.setProgressUsesThread(progressUsesThread);
if(extensions != null && extensions.trim().length() > 0){
try{
cflint.setAllowedExtensions(Arrays.asList(extensions.trim().split(",")));
}catch(Exception e){
System.err.println("Unable to use extensions (" + extensions + ") using default instead. " + e.getMessage());
}
}
CFLintFilter filter = CFLintFilter.createFilter(verbose);
if(filterFile != null){
File ffile = new File(filterFile);
if(ffile.exists()){
FileInputStream fis = new FileInputStream(ffile);
byte b[] = new byte[fis.available()];
fis.read(b);
filter = CFLintFilter.createFilter(new String(b),verbose);
}
}
if (excludeCodes != null && excludeCodes.length > 0) {
filter.excludeCode(excludeCodes);
}
if (includeCodes != null && includeCodes.length > 0) {
filter.includeCode(includeCodes);
}
cflint.getBugs().setFilter(filter);
for (final String scanfolder : folder) {
cflint.scan(scanfolder);
}
if (stdIn) {
StringBuilder source = new StringBuilder();
Scanner scanner = new Scanner(System.in);
while (scanner.hasNextLine()) {
String nextLine = scanner.nextLine();
source.append(nextLine);
source.append(System.lineSeparator());
}
scanner.close();
cflint.process(source.toString(), stdInFile);
}
if (xmlOutput) {
Writer xmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(xmlOutFile);
if ("findbugs".equalsIgnoreCase(xmlstyle)) {
if(verbose) {
display("Writing XML findbugs style" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().outputFindBugs(cflint.getBugs(), xmlwriter);
} else {
if(verbose) {
display("Writing XML" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().output(cflint.getBugs(), xmlwriter);
}
}
if (textOutput) {
if(textOutFile != null){
if(verbose) {
display("Writing text" + (stdOut ? "." : " to " + textOutFile));
}
}
Writer textwriter = stdOut || textOutFile==null ? new OutputStreamWriter(System.out) : new FileWriter(textOutFile);
new TextOutput().output(cflint.getBugs(), textwriter);
}
if (htmlOutput) {
try {
if(verbose) {
display("Writing HTML" + (stdOut ? "." : " to " + htmlOutFile));
}
Writer htmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(htmlOutFile);
new HTMLOutput(htmlStyle).output(cflint.getBugs(), htmlwriter);
} catch (final TransformerException e) {
throw new IOException(e);
}
}
if (jsonOutput) {
if(verbose) {
display("Writing JSON" + (stdOut ? "." : " to " + jsonOutFile));
}
Writer jsonwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(jsonOutFile);
new JSONOutput().output(cflint.getBugs(), jsonwriter);
}
if (includeCodes != null) {
cflint.getBugs().getFilter().includeCode(includeCodes);
}
if (excludeCodes != null) {
cflint.getBugs().getFilter().excludeCode(excludeCodes);
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
static String load(final File file) {
FileInputStream fis;
try {
fis = new FileInputStream(file);
final byte[] b = new byte[fis.available()];
fis.read(b);
return new String(b);
} catch (final Exception e) {
return null;
}
}
#location 6
#vulnerability type RESOURCE_LEAK | #fixed code
static String load(final File file) {
FileInputStream fis = null;
try {
fis = new FileInputStream(file);
final byte[] b = new byte[fis.available()];
fis.read(b);
return new String(b);
} catch (final Exception e) {
return null;
} finally {
try {
if (fis != null)
fis.close();
} catch (IOException e) {
return null;
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public boolean include(final BugInfo bugInfo) {
if (includeCodes != null && !includeCodes.contains(bugInfo.getMessageCode())){
return false;
}
if (data != null) {
for (final Object item : data) {
final JSONObject jsonObj = (JSONObject) item;
if (jsonObj.containsKey("file")) {
if (!bugInfo.getFilename().matches(jsonObj.get("file").toString())) {
continue;
}
}
if (jsonObj.containsKey("code")) {
if (!bugInfo.getMessageCode().matches(jsonObj.get("code").toString())) {
continue;
}
}
if (jsonObj.containsKey("function")) {
if (bugInfo.getFunction() == null
|| !bugInfo.getFunction().matches(jsonObj.get("function").toString())) {
continue;
}
}
if (jsonObj.containsKey("variable")) {
if (bugInfo.getVariable() == null
|| !bugInfo.getFunction().matches(jsonObj.get("function").toString())) {
continue;
}
}
if (jsonObj.containsKey("line")) {
if (bugInfo.getLine() > 0
|| !new Integer(bugInfo.getLine()).toString().matches(jsonObj.get("line").toString())) {
continue;
}
}
if (jsonObj.containsKey("expression")) {
if (bugInfo.getExpression() == null
|| !bugInfo.getExpression().matches(jsonObj.get("expression").toString())) {
continue;
}
}
return false;
}
}
return true;
}
#location 20
#vulnerability type NULL_DEREFERENCE | #fixed code
public boolean include(final BugInfo bugInfo) {
if (includeCodes != null && !includeCodes.contains(bugInfo.getMessageCode())){
return false;
}
if (data != null) {
for (final Object item : data) {
final JSONObject jsonObj = (JSONObject) item;
if (jsonObj.containsKey("file")) {
if (!bugInfo.getFilename().matches(jsonObj.get("file").toString())) {
continue;
}else if (verbose){
System.out.println("Exclude matched file " + bugInfo.getFilename());
}
}
if (jsonObj.containsKey("code")) {
if (!bugInfo.getMessageCode().matches(jsonObj.get("code").toString())) {
continue;
}else if (verbose){
System.out.println("Exclude matched message code " + bugInfo.getMessageCode());
}
}
if (jsonObj.containsKey("function")) {
if (bugInfo.getFunction() == null
|| !bugInfo.getFunction().matches(jsonObj.get("function").toString())) {
continue;
}else if (verbose){
System.out.println("Exclude matched function name " + bugInfo.getFunction());
}
}
if (jsonObj.containsKey("variable")) {
if (bugInfo.getVariable() == null
|| !bugInfo.getVariable().matches(jsonObj.get("variable").toString())) {
continue;
}else if (verbose){
System.out.println("Exclude matched variable name " + bugInfo.getVariable());
}
}
if (jsonObj.containsKey("line")) {
if (bugInfo.getLine() > 0
|| !new Integer(bugInfo.getLine()).toString().matches(jsonObj.get("line").toString())) {
continue;
}else if (verbose){
System.out.println("Exclude matched line " + bugInfo.getLine());
}
}
if (jsonObj.containsKey("expression")) {
if (bugInfo.getExpression() == null
|| !bugInfo.getExpression().matches(jsonObj.get("expression").toString())) {
continue;
}else if (verbose){
System.out.println("Exclude matched expression " + bugInfo.getExpression());
}
}
return false;
}
}
return true;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public static String getVersion() {
final InputStream is = Version.class
.getResourceAsStream("/META-INF/maven/com.github.cflint/CFLint/pom.properties");
try {
final BufferedReader reader = new BufferedReader(new InputStreamReader(is));
String line = reader.readLine();
while (line != null && !line.startsWith("version=")) {
line = reader.readLine();
}
if (line != null) {
return line.replaceAll("version=", "");
}
} catch (final Exception e) {
try {
if (is != null) {
is.close();
}
} catch (final IOException e1) {
e1.printStackTrace();
}
}
return "";
}
#location 11
#vulnerability type RESOURCE_LEAK | #fixed code
public static String getVersion() {
try {
return CFLintMain.class.getPackage().getImplementationVersion();
} catch (Exception e) {
return "";
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
private void execute() throws IOException, TransformerException, JAXBException {
CFLintConfig config = null;
if(configfile != null){
if(configfile.toLowerCase().endsWith(".xml")){
config = ConfigUtils.unmarshal(new FileInputStream(configfile), CFLintConfig.class);
}else{
config = ConfigUtils.unmarshalJson(new FileInputStream(configfile), CFLintConfig.class);
}
}
final CFLint cflint = new CFLint(config);
cflint.setVerbose(verbose);
cflint.setLogError(logerror);
cflint.setQuiet(quiet);
cflint.setShowProgress(showprogress);
cflint.setProgressUsesThread(progressUsesThread);
if(extensions != null && extensions.trim().length() > 0){
try{
cflint.setAllowedExtensions(Arrays.asList(extensions.trim().split(",")));
}catch(Exception e){
System.err.println("Unable to use extensions (" + extensions + ") using default instead. " + e.getMessage());
}
}
CFLintFilter filter = CFLintFilter.createFilter(verbose);
if(filterFile != null){
File ffile = new File(filterFile);
if(ffile.exists()){
FileInputStream fis = new FileInputStream(ffile);
byte b[] = new byte[fis.available()];
fis.read(b);
filter = CFLintFilter.createFilter(new String(b),verbose);
}
}
if (excludeCodes != null && excludeCodes.length > 0) {
filter.excludeCode(excludeCodes);
}
if (includeCodes != null && includeCodes.length > 0) {
filter.includeCode(includeCodes);
}
cflint.getBugs().setFilter(filter);
for (final String scanfolder : folder) {
cflint.scan(scanfolder);
}
if (stdIn) {
StringBuilder source = new StringBuilder();
Scanner scanner = new Scanner(System.in);
while (scanner.hasNextLine()) {
String nextLine = scanner.nextLine();
source.append(nextLine);
source.append(System.lineSeparator());
}
scanner.close();
cflint.process(source.toString(), stdInFile);
}
if (xmlOutput) {
Writer xmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(xmlOutFile);
if ("findbugs".equalsIgnoreCase(xmlstyle)) {
if(verbose) {
display("Writing XML findbugs style" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().outputFindBugs(cflint.getBugs(), xmlwriter);
} else {
if(verbose) {
display("Writing XML" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().output(cflint.getBugs(), xmlwriter);
}
}
if (textOutput) {
if(textOutFile != null){
if(verbose) {
display("Writing text" + (stdOut ? "." : " to " + textOutFile));
}
}
Writer textwriter = stdOut || textOutFile==null ? new OutputStreamWriter(System.out) : new FileWriter(textOutFile);
new TextOutput().output(cflint.getBugs(), textwriter);
}
if (htmlOutput) {
try {
if(verbose) {
display("Writing HTML" + (stdOut ? "." : " to " + htmlOutFile));
}
Writer htmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(htmlOutFile);
new HTMLOutput(htmlStyle).output(cflint.getBugs(), htmlwriter);
} catch (final TransformerException e) {
throw new IOException(e);
}
}
if (jsonOutput) {
if(verbose) {
display("Writing JSON" + (stdOut ? "." : " to " + jsonOutFile));
}
Writer jsonwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(jsonOutFile);
new JSONOutput().output(cflint.getBugs(), jsonwriter);
}
if (includeCodes != null) {
cflint.getBugs().getFilter().includeCode(includeCodes);
}
if (excludeCodes != null) {
cflint.getBugs().getFilter().excludeCode(excludeCodes);
}
}
#location 41
#vulnerability type NULL_DEREFERENCE | #fixed code
private void execute() throws IOException, TransformerException, JAXBException {
final CFLint cflint = new CFLint(loadConfig(configfile));
cflint.setVerbose(verbose);
cflint.setLogError(logerror);
cflint.setQuiet(quiet);
cflint.setShowProgress(showprogress);
cflint.setProgressUsesThread(progressUsesThread);
if(extensions != null && extensions.trim().length() > 0){
try{
cflint.setAllowedExtensions(Arrays.asList(extensions.trim().split(",")));
}catch(Exception e){
System.err.println("Unable to use extensions (" + extensions + ") using default instead. " + e.getMessage());
}
}
CFLintFilter filter = CFLintFilter.createFilter(verbose);
if(filterFile != null){
File ffile = new File(filterFile);
if(ffile.exists()){
FileInputStream fis = new FileInputStream(ffile);
byte b[] = new byte[fis.available()];
fis.read(b);
filter = CFLintFilter.createFilter(new String(b),verbose);
}
}
if (excludeCodes != null && excludeCodes.length > 0) {
filter.excludeCode(excludeCodes);
}
if (includeCodes != null && includeCodes.length > 0) {
filter.includeCode(includeCodes);
}
cflint.getBugs().setFilter(filter);
for (final String scanfolder : folder) {
cflint.scan(scanfolder);
}
if (stdIn) {
StringBuilder source = new StringBuilder();
Scanner scanner = new Scanner(System.in);
while (scanner.hasNextLine()) {
String nextLine = scanner.nextLine();
source.append(nextLine);
source.append(System.lineSeparator());
}
scanner.close();
cflint.process(source.toString(), stdInFile);
}
if (xmlOutput) {
Writer xmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(xmlOutFile);
if ("findbugs".equalsIgnoreCase(xmlstyle)) {
if(verbose) {
display("Writing XML findbugs style" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().outputFindBugs(cflint.getBugs(), xmlwriter);
} else {
if(verbose) {
display("Writing XML" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().output(cflint.getBugs(), xmlwriter);
}
}
if (textOutput) {
if(textOutFile != null){
if(verbose) {
display("Writing text" + (stdOut ? "." : " to " + textOutFile));
}
}
Writer textwriter = stdOut || textOutFile==null ? new OutputStreamWriter(System.out) : new FileWriter(textOutFile);
new TextOutput().output(cflint.getBugs(), textwriter);
}
if (htmlOutput) {
try {
if(verbose) {
display("Writing HTML" + (stdOut ? "." : " to " + htmlOutFile));
}
Writer htmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(htmlOutFile);
new HTMLOutput(htmlStyle).output(cflint.getBugs(), htmlwriter);
} catch (final TransformerException e) {
throw new IOException(e);
}
}
if (jsonOutput) {
if(verbose) {
display("Writing JSON" + (stdOut ? "." : " to " + jsonOutFile));
}
Writer jsonwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(jsonOutFile);
new JSONOutput().output(cflint.getBugs(), jsonwriter);
}
if (includeCodes != null) {
cflint.getBugs().getFilter().includeCode(includeCodes);
}
if (excludeCodes != null) {
cflint.getBugs().getFilter().excludeCode(excludeCodes);
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public static String getVersion() {
final InputStream is = Version.class
.getResourceAsStream("/META-INF/maven/com.github.cflint/CFLint/pom.properties");
try {
final BufferedReader reader = new BufferedReader(new InputStreamReader(is));
String line = reader.readLine();
while (line != null && !line.startsWith("version=")) {
line = reader.readLine();
}
if (line != null) {
return line.replaceAll("version=", "");
}
} catch (final Exception e) {
try {
if (is != null) {
is.close();
}
} catch (final IOException e1) {
e1.printStackTrace();
}
}
return "";
}
#location 10
#vulnerability type RESOURCE_LEAK | #fixed code
public static String getVersion() {
try {
return CFLintMain.class.getPackage().getImplementationVersion();
} catch (Exception e) {
return "";
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
private static CFLintConfig loadConfig(final String configfile) {
if (configfile != null) {
try {
CFLintPluginInfo pluginInfo=null;
if (configfile.toLowerCase().endsWith(".xml")) {
final Object configObj = ConfigUtils.unmarshal(new FileInputStream(configfile));
if (configObj instanceof CFLintPluginInfo)
pluginInfo= (CFLintPluginInfo) configObj;
else if(configObj instanceof CFLintConfig ){
return (CFLintConfig) configObj;
}
} else {
return ConfigUtils.unmarshalJson(new FileInputStream(configfile), CFLintConfig.class);
}
CFLintConfig returnVal = new CFLintConfig();
returnVal.setRules(pluginInfo.getRules());
return returnVal;
} catch (final Exception e) {
System.err.println("Unable to load config file. " + e.getMessage());
}
}
return null;
}
#location 16
#vulnerability type NULL_DEREFERENCE | #fixed code
private static CFLintConfig loadConfig(final String configfile) {
if (configfile != null) {
try {
CFLintPluginInfo pluginInfo = null;
if (configfile.toLowerCase().endsWith(".xml")) {
final Object configObj = ConfigUtils.unmarshal(new FileInputStream(configfile));
if (configObj instanceof CFLintPluginInfo)
pluginInfo = (CFLintPluginInfo) configObj;
else if(configObj instanceof CFLintConfig ){
return (CFLintConfig) configObj;
}
} else {
return ConfigUtils.unmarshalJson(new FileInputStream(configfile), CFLintConfig.class);
}
CFLintConfig returnVal = new CFLintConfig();
if (pluginInfo != null)
returnVal.setRules(pluginInfo.getRules());
return returnVal;
} catch (final Exception e) {
System.err.println("Unable to load config file. " + e.getMessage());
}
}
return null;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
protected void registerRuleOverrides(Context context, final Token functionToken) {
Iterable<Token> tokens = context.beforeTokens(functionToken);
for (Token currentTok : tokens) {
if (currentTok.getChannel() == Token.HIDDEN_CHANNEL && currentTok.getType() == CFSCRIPTLexer.ML_COMMENT) {
String mlText = currentTok.getText();
Pattern pattern = Pattern.compile(".*\\s*@CFLintIgnore\\s+([\\w,_]+)\\s*.*", Pattern.DOTALL);
Matcher matcher = pattern.matcher(mlText);
if (matcher.matches()) {
String ignoreCodes = matcher.group(1);
context.ignore(Arrays.asList(ignoreCodes.split(",\\s*")));
}
} else if (currentTok.getLine() < functionToken.getLine()) {
break;
}
}
}
#location 4
#vulnerability type NULL_DEREFERENCE | #fixed code
protected void registerRuleOverrides(Context context, final Token functionToken) {
final String mlText = PrecedingCommentReader.getMultiLine(context, functionToken);
if(mlText != null && !mlText.isEmpty()){
final Pattern pattern = Pattern.compile(".*\\s*@CFLintIgnore\\s+([\\w,_]+)\\s*.*", Pattern.DOTALL);
final Matcher matcher = pattern.matcher(mlText);
if (matcher.matches()) {
String ignoreCodes = matcher.group(1);
context.ignore(Arrays.asList(ignoreCodes.split(",\\s*")));
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
private void execute() throws IOException, TransformerException, JAXBException, MarshallerException {
final CFLint cflint = new CFLint(buildConfigChain());
cflint.setVerbose(verbose);
cflint.setLogError(logerror);
cflint.setQuiet(quiet);
cflint.setStrictIncludes(strictInclude);
cflint.setShowProgress(showprogress);
cflint.setProgressUsesThread(progressUsesThread);
if (extensions != null && extensions.trim().length() > 0) {
try {
cflint.setAllowedExtensions(Arrays.asList(extensions.trim().split(",")));
} catch (final Exception e) {
System.err.println(
"Unable to use extensions (" + extensions + ") using default instead. " + e.getMessage());
}
}
final CFLintFilter filter = createBaseFilter();
cflint.getBugs().setFilter(filter);
for (final String scanfolder : folder) {
cflint.scan(scanfolder);
}
if (stdIn) {
final StringBuilder source = new StringBuilder();
final Scanner scanner = new Scanner(System.in);
while (scanner.hasNextLine()) {
final String nextLine = scanner.nextLine();
source.append(nextLine);
source.append(System.lineSeparator());
}
scanner.close();
cflint.process(source.toString(), stdInFile);
}
if (xmlOutput) {
final Writer xmlwriter = stdOut ? new OutputStreamWriter(System.out)
: createWriter(xmlOutFile, StandardCharsets.UTF_8);
if ("findbugs".equalsIgnoreCase(xmlstyle)) {
if (verbose) {
display("Writing XML findbugs style" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().outputFindBugs(cflint.getBugs(), xmlwriter, showStats);
} else {
if (verbose) {
display("Writing XML" + (stdOut ? "." : " to " + xmlOutFile));
}
new DefaultCFlintResultMarshaller().output(cflint.getBugs(), xmlwriter, showStats);
}
}
if (textOutput) {
if (textOutFile != null && verbose) {
display("Writing text" + (stdOut ? "." : " to " + textOutFile));
}
final Writer textwriter = stdOut || textOutFile == null ? new OutputStreamWriter(System.out)
: new FileWriter(textOutFile);
new TextOutput().output(cflint.getBugs(), textwriter, showStats);
}
if (htmlOutput) {
try {
if (verbose) {
display("Writing HTML" + (stdOut ? "." : " to " + htmlOutFile));
}
final Writer htmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(htmlOutFile);
new HTMLOutput(htmlStyle).output(cflint.getBugs(), htmlwriter, showStats);
} catch (final TransformerException e) {
throw new IOException(e);
}
}
if (jsonOutput) {
if (verbose) {
display("Writing JSON" + (stdOut ? "." : " to " + jsonOutFile));
}
final Writer jsonwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(jsonOutFile);
new JSONOutput().output(cflint.getBugs(), jsonwriter, showStats);
}
if (verbose) {
display("Total files scanned: " + cflint.getStats().getFileCount());
display("Total size: " + cflint.getStats().getTotalSize());
}
}
#location 18
#vulnerability type NULL_DEREFERENCE | #fixed code
private void execute() throws IOException, TransformerException, JAXBException, MarshallerException {
final CFLint cflint = new CFLint(buildConfigChain());
cflint.setVerbose(verbose);
cflint.setLogError(logerror);
cflint.setQuiet(quiet);
cflint.setStrictIncludes(strictInclude);
cflint.setShowProgress(showprogress);
cflint.setProgressUsesThread(progressUsesThread);
if (extensions != null && extensions.trim().length() > 0) {
try {
cflint.setAllowedExtensions(Arrays.asList(extensions.trim().split(",")));
} catch (final Exception e) {
System.err.println(
"Unable to use extensions (" + extensions + ") using default instead. " + e.getMessage());
}
}
final CFLintFilter filter = createBaseFilter();
cflint.getBugs().setFilter(filter);
for (final String scanfolder : folder) {
cflint.scan(scanfolder);
}
if (stdIn) {
final StringBuilder source = new StringBuilder();
final Scanner scanner = new Scanner(System.in);
while (scanner.hasNextLine()) {
final String nextLine = scanner.nextLine();
source.append(nextLine);
source.append(System.lineSeparator());
}
scanner.close();
cflint.process(source.toString(), stdInFile);
}
if (xmlOutput) {
final Writer xmlwriter = stdOut ? new OutputStreamWriter(System.out)
: createWriter(xmlOutFile, StandardCharsets.UTF_8);
if ("findbugs".equalsIgnoreCase(xmlstyle)) {
if (verbose) {
display("Writing XML findbugs style" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().outputFindBugs(cflint.getBugs(), xmlwriter, showStats, cflint.getStats());
} else {
if (verbose) {
display("Writing XML" + (stdOut ? "." : " to " + xmlOutFile));
}
new DefaultCFlintResultMarshaller().output(cflint.getBugs(), xmlwriter, showStats);
}
}
if (textOutput) {
if (textOutFile != null && verbose) {
display("Writing text" + (stdOut ? "." : " to " + textOutFile));
}
final Writer textwriter = stdOut || textOutFile == null ? new OutputStreamWriter(System.out)
: new FileWriter(textOutFile);
new TextOutput().output(cflint.getBugs(), textwriter, showStats);
}
if (htmlOutput) {
try {
if (verbose) {
display("Writing HTML" + (stdOut ? "." : " to " + htmlOutFile));
}
final Writer htmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(htmlOutFile);
new HTMLOutput(htmlStyle).output(cflint.getBugs(), htmlwriter, showStats, cflint.getStats());
} catch (final TransformerException e) {
throw new IOException(e);
}
}
if (jsonOutput) {
if (verbose) {
display("Writing JSON" + (stdOut ? "." : " to " + jsonOutFile));
}
final Writer jsonwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(jsonOutFile);
new JSONOutput().output(cflint.getBugs(), jsonwriter, showStats);
}
if (verbose) {
display("Total files scanned: " + cflint.getStats().getFileCount());
display("Total size: " + cflint.getStats().getTotalSize());
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
static String load(final File file) {
FileInputStream fis;
try {
fis = new FileInputStream(file);
final byte[] b = new byte[fis.available()];
fis.read(b);
return new String(b);
} catch (final Exception e) {
return null;
}
}
#location 8
#vulnerability type RESOURCE_LEAK | #fixed code
static String load(final File file) {
FileInputStream fis = null;
try {
fis = new FileInputStream(file);
final byte[] b = new byte[fis.available()];
fis.read(b);
return new String(b);
} catch (final Exception e) {
return null;
} finally {
try {
if (fis != null)
fis.close();
} catch (IOException e) {
return null;
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
private void mergeConfigFileInFilter(CFLintFilter filter)
{
CFLintConfig cfg = loadConfig(configfile);
for(PluginMessage message : cfg.getIncludes())
{
filter.includeCode(message.getCode());
}
for(PluginMessage message : cfg.getExcludes())
{
filter.excludeCode(message.getCode());
}
}
#location 4
#vulnerability type NULL_DEREFERENCE | #fixed code
private void mergeConfigFileInFilter(CFLintFilter filter)
{
CFLintConfig cfg = loadConfig(configfile);
if(cfg != null){
for(PluginMessage message : cfg.getIncludes())
{
filter.includeCode(message.getCode());
}
for(PluginMessage message : cfg.getExcludes())
{
filter.excludeCode(message.getCode());
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void expression(final CFExpression expression, final Context context, final BugList bugs) {
String repeatThreshold = getParameter("maximum");
int threshold = REPEAT_THRESHOLD;
if (repeatThreshold != null) {
threshold = Integer.parseInt(repeatThreshold);
}
if (expression instanceof CFLiteral) {
CFLiteral literal = (CFLiteral) expression;
String name = literal.Decompile(0).replace("'","");
int count = 1;
if (isCommon(name)) {
return;
}
if (literals.get(name) == null) {
literals.put(name, count);
done.put(name, false);
}
else {
count = literals.get(name);
count++;
literals.put(name, count);
}
if (count > threshold && !done.get(name)) {
int lineNo = literal.getLine() + context.startLine() - 1;
magicValue(name, lineNo, context, bugs);
done.put(name, true);
}
}
}
#location 29
#vulnerability type NULL_DEREFERENCE | #fixed code
@Override
public void expression(final CFExpression expression, final Context context, final BugList bugs) {
String repeatThreshold = getParameter("maximum");
String maxWarnings = getParameter("maxWarnings");
String warningScope = getParameter("warningScope");
if (repeatThreshold != null) {
threshold = Integer.parseInt(repeatThreshold);
}
if (maxWarnings != null) {
warningThreshold = Integer.parseInt(maxWarnings);
}
if (expression instanceof CFLiteral) {
CFLiteral literal = (CFLiteral) expression;
String name = literal.Decompile(0).replace("'","");
if (isCommon(name)) {
return;
}
int lineNo = literal.getLine() + context.startLine() - 1;
if (warningScope == null || warningScope.equals("global")) {
literalCount(name, lineNo, globalLiterals, true, context, bugs);
}
else if (warningScope.equals("local")) {
literalCount(name, lineNo, functionListerals, false, context, bugs);
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public AsyncIOWriter write(AtmosphereResponse r, byte[] data, int offset, int length) throws IOException {
boolean transform = filters.size() > 0 && r.getStatus() < 400;
if (transform) {
data = transform(r, data, offset, length);
offset = 0;
length = data.length;
}
logger.trace("About to write to {}", r.resource() != null ? r.resource().uuid() : "null");
if (channel.isOpen()) {
final ChannelBuffer buffer = ChannelBuffers.dynamicBuffer();
pendingWrite.incrementAndGet();
if (writeHeader && !headerWritten) {
buffer.writeBytes(constructStatusAndHeaders(r).getBytes("UTF-8"));
headerWritten = true;
}
ChannelBufferOutputStream c = new ChannelBufferOutputStream(buffer);
if (headerWritten) {
c.write(Integer.toHexString(length - offset).getBytes("UTF-8"));
c.write(CHUNK_DELIMITER);
}
c.write(data, offset, length);
if (headerWritten) {
c.write(CHUNK_DELIMITER);
}
channel.write(c.buffer()).addListener(listener);
byteWritten = true;
lastWrite = System.currentTimeMillis();
} else {
logger.debug("Trying to write on a closed channel {}", channel);
throw new IOException("Channel closed");
}
headerWritten = true;
return this;
}
#location 32
#vulnerability type RESOURCE_LEAK | #fixed code
@Override
public AsyncIOWriter write(AtmosphereResponse r, byte[] data, int offset, int length) throws IOException {
boolean transform = filters.size() > 0 && r.getStatus() < 400;
if (transform) {
data = transform(r, data, offset, length);
offset = 0;
length = data.length;
}
logger.trace("About to write to {}", r.resource() != null ? r.resource().uuid() : "null");
if (channel.isOpen()) {
final ChannelBuffer buffer = ChannelBuffers.dynamicBuffer();
pendingWrite.incrementAndGet();
if (writeHeader && !headerWritten) {
buffer.writeBytes(constructStatusAndHeaders(r).getBytes("UTF-8"));
headerWritten = true;
}
if (headerWritten) {
buffer.writeBytes(Integer.toHexString(length - offset).getBytes("UTF-8"));
buffer.writeBytes(CHUNK_DELIMITER);
}
buffer.writeBytes(data, offset, length);
if (headerWritten) {
buffer.writeBytes(CHUNK_DELIMITER);
}
channel.write(buffer).addListener(listener);
byteWritten = true;
lastWrite = System.currentTimeMillis();
} else {
logger.debug("Trying to write on a closed channel {}", channel);
throw new IOException("Channel closed");
}
headerWritten = true;
return this;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
void _close() {
if (!isClosed.getAndSet(true)) {
headerWritten = false;
final ChannelBuffer buffer = ChannelBuffers.dynamicBuffer();
ChannelBufferOutputStream c = new ChannelBufferOutputStream(buffer);
try {
c.write(ENDCHUNK);
channel.write(buffer).addListener(new ChannelFutureListener() {
@Override
public void operationComplete(ChannelFuture future) throws Exception {
if (!keepAlive) {
channel.close().awaitUninterruptibly();
}
}
});
} catch (IOException e) {
logger.trace("Close error", e);
}
}
}
#location 7
#vulnerability type RESOURCE_LEAK | #fixed code
void _close() {
if (!isClosed.getAndSet(true)) {
headerWritten = false;
final ChannelBuffer buffer = ChannelBuffers.dynamicBuffer();
buffer.writeBytes(ENDCHUNK);
channel.write(buffer).addListener(new ChannelFutureListener() {
@Override
public void operationComplete(ChannelFuture future) throws Exception {
if (!keepAlive) {
channel.close().awaitUninterruptibly();
}
}
});
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void open() {
if (!open.compareAndSet(false, true)) {
return;
}
LOG.debug("Opening GStreamer device");
init();
starting.set(true);
Dimension size = getResolution();
image = new BufferedImage(size.width, size.height, BufferedImage.TYPE_INT_RGB);
image.setAccelerationPriority(0);
image.flush();
if (caps != null) {
caps.dispose();
}
caps = Caps.fromString(String.format("%s,width=%d,height=%d", format, size.width, size.height));
filter.setCaps(caps);
LOG.debug("Link elements");
pipe.addMany(source, filter, sink);
Element.linkMany(source, filter, sink);
pipe.setState(State.PLAYING);
// wait max 20s for image to appear
synchronized (this) {
LOG.debug("Wait for device to be ready");
try {
this.wait(20000);
} catch (InterruptedException e) {
return;
}
}
}
#location 30
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void open() {
if (!open.compareAndSet(false, true)) {
return;
}
LOG.debug("Opening GStreamer device");
init();
starting.set(true);
Dimension size = getResolution();
image = new BufferedImage(size.width, size.height, BufferedImage.TYPE_INT_RGB);
image.setAccelerationPriority(0);
image.flush();
if (caps != null) {
caps.dispose();
}
caps = Caps.fromString(String.format("%s,framerate=30/1,width=%d,height=%d", format, size.width, size.height));
filter.setCaps(caps);
LOG.debug("Using filter caps: {}", caps);
pipelinePlay();
LOG.debug("Wait for device to be ready");
// wait max 20s for image to appear
synchronized (this) {
try {
this.wait(20000);
} catch (InterruptedException e) {
return;
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
image = null;
LOG.debug("Unlink elements");
pipe.setState(State.NULL);
Element.unlinkMany(source, filter, sink);
pipe.removeMany(source, filter, sink);
}
#location 14
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
pipelineStop();
image = null;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
public void resume() {
if (!paused) {
return;
}
synchronized (repainter) {
repainter.notifyAll();
}
paused = false;
}
#location 5
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
public void resume() {
if (!paused) {
return;
}
paused = false;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void open() {
if (!open.compareAndSet(false, true)) {
return;
}
LOG.debug("Opening GStreamer device");
init();
starting.set(true);
Dimension size = getResolution();
image = new BufferedImage(size.width, size.height, BufferedImage.TYPE_INT_RGB);
image.setAccelerationPriority(0);
image.flush();
if (caps != null) {
caps.dispose();
}
caps = Caps.fromString(String.format("%s,width=%d,height=%d", format, size.width, size.height));
filter.setCaps(caps);
LOG.debug("Link elements");
pipe.addMany(source, filter, sink);
Element.linkMany(source, filter, sink);
pipe.setState(State.PLAYING);
// wait max 20s for image to appear
synchronized (this) {
LOG.debug("Wait for device to be ready");
try {
this.wait(20000);
} catch (InterruptedException e) {
return;
}
}
}
#location 32
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void open() {
if (!open.compareAndSet(false, true)) {
return;
}
LOG.debug("Opening GStreamer device");
init();
starting.set(true);
Dimension size = getResolution();
image = new BufferedImage(size.width, size.height, BufferedImage.TYPE_INT_RGB);
image.setAccelerationPriority(0);
image.flush();
if (caps != null) {
caps.dispose();
}
caps = Caps.fromString(String.format("%s,framerate=30/1,width=%d,height=%d", format, size.width, size.height));
filter.setCaps(caps);
LOG.debug("Using filter caps: {}", caps);
pipelinePlay();
LOG.debug("Wait for device to be ready");
// wait max 20s for image to appear
synchronized (this) {
try {
this.wait(20000);
} catch (InterruptedException e) {
return;
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
source.dispose();
filter.dispose();
jpegparse.dispose();
jpegdec.dispose();
caps.dispose();
sink.dispose();
pipe.dispose();
}
#location 14
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
source.dispose();
filter.dispose();
jpegdec.dispose();
caps.dispose();
sink.dispose();
pipe.dispose();
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
image = null;
LOG.debug("Unlink elements");
pipe.setState(State.NULL);
Element.unlinkMany(source, filter, sink);
pipe.removeMany(source, filter, sink);
}
#location 16
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
pipelineStop();
image = null;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
source.dispose();
filter.dispose();
jpegpar.dispose();
jpegdec.dispose();
caps.dispose();
sink.dispose();
pipe.dispose();
}
#location 14
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
source.dispose();
filter.dispose();
jpegparse.dispose();
jpegdec.dispose();
caps.dispose();
sink.dispose();
pipe.dispose();
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
image = null;
LOG.debug("Unlink elements");
pipe.setState(State.NULL);
Element.unlinkMany(source, filter, sink);
pipe.removeMany(source, filter, sink);
}
#location 15
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
pipelineStop();
image = null;
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
filter.dispose();
source.dispose();
sink.dispose();
pipe.dispose();
caps.dispose();
}
#location 10
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
source.dispose();
filter.dispose();
jpegpar.dispose();
jpegdec.dispose();
caps.dispose();
sink.dispose();
pipe.dispose();
} | Below is the vulnerable code, please generate the patch based on the following information. |
#vulnerable code
@Override
public void open() {
if (!open.compareAndSet(false, true)) {
return;
}
LOG.debug("Opening GStreamer device");
init();
starting.set(true);
Dimension size = getResolution();
image = new BufferedImage(size.width, size.height, BufferedImage.TYPE_INT_RGB);
image.setAccelerationPriority(0);
image.flush();
if (caps != null) {
caps.dispose();
}
caps = Caps.fromString(String.format("%s,width=%d,height=%d", format, size.width, size.height));
filter.setCaps(caps);
LOG.debug("Link elements");
pipe.addMany(source, filter, sink);
Element.linkMany(source, filter, sink);
pipe.setState(State.PLAYING);
// wait max 20s for image to appear
synchronized (this) {
LOG.debug("Wait for device to be ready");
try {
this.wait(20000);
} catch (InterruptedException e) {
return;
}
}
}
#location 24
#vulnerability type THREAD_SAFETY_VIOLATION | #fixed code
@Override
public void open() {
if (!open.compareAndSet(false, true)) {
return;
}
LOG.debug("Opening GStreamer device");
init();
starting.set(true);
Dimension size = getResolution();
image = new BufferedImage(size.width, size.height, BufferedImage.TYPE_INT_RGB);
image.setAccelerationPriority(0);
image.flush();
if (caps != null) {
caps.dispose();
}
caps = Caps.fromString(String.format("%s,framerate=30/1,width=%d,height=%d", format, size.width, size.height));
filter.setCaps(caps);
LOG.debug("Using filter caps: {}", caps);
pipelinePlay();
LOG.debug("Wait for device to be ready");
// wait max 20s for image to appear
synchronized (this) {
try {
this.wait(20000);
} catch (InterruptedException e) {
return;
}
}
} | Below is the vulnerable code, please generate the patch based on the following information. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.