docstring_tokens
stringlengths 18
16.9k
| code_tokens
stringlengths 75
1.81M
| html_url
stringlengths 74
116
| file_name
stringlengths 3
311
|
|---|---|---|---|
keep keep keep keep replace keep keep keep keep keep
|
<mask> s.subspec "cxxReactABI28_0_0" do |ss|
<mask> ss.dependency "ReactABI28_0_0/ABI28_0_0jschelpers"
<mask> ss.dependency "ReactABI28_0_0/ABI28_0_0jsinspector"
<mask> ss.dependency "boost-for-react-native", "1.63.0"
<mask> ss.dependency "Folly", "2016.09.26.00"
<mask> ss.compiler_flags = folly_compiler_flags
<mask> ss.source_files = "ReactCommon/cxxReactABI28_0_0/*.{cpp,h}"
<mask> ss.exclude_files = "ReactCommon/cxxReactABI28_0_0/ABI28_0_0SampleCxxModule.*"
<mask> ss.private_header_files = "ReactCommon/cxxReactABI28_0_0/*.h"
<mask> ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/ReactCommon\" \"$(PODS_ROOT)/boost-for-react-native\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/Folly\"" }
</s> [sdk31] Update CocoaPods with RN SDK 31 files
Folly was updated, so I went back to the Podspec files for older RN versions and made them use the slightly newer version of Folly used with RN 0.57. </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00"
|
https://github.com/expo/expo/commit/4ac77874d024d32c5f0121f2f6d5c864eabbb1d7
|
ios/versioned-react-native/ABI28_0_0/ReactABI28_0_0.podspec
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> ss.source_files = "Expo/Optional/**/*.{h,m}"
<mask> end
<mask>
<mask> s.subspec "CxxBridge" do |ss|
<mask> ss.dependency "Folly", "2016.09.26.00"
<mask> ss.dependency "ReactABI29_0_0/Core"
<mask> ss.dependency "ReactABI29_0_0/cxxReactABI29_0_0"
<mask> ss.compiler_flags = folly_compiler_flags
<mask> ss.private_header_files = "React/Cxx*/*.h"
<mask> ss.source_files = "React/Cxx*/*.{h,m,mm}"
</s> [sdk31] Update CocoaPods with RN SDK 31 files
Folly was updated, so I went back to the Podspec files for older RN versions and made them use the slightly newer version of Folly used with RN 0.57. </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00"
|
https://github.com/expo/expo/commit/4ac77874d024d32c5f0121f2f6d5c864eabbb1d7
|
ios/versioned-react-native/ABI29_0_0/ReactABI29_0_0.podspec
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> ss.source_files = "React/**/RCTTV*.{h, m}"
<mask> end
<mask>
<mask> s.subspec "ABI29_0_0jschelpers" do |ss|
<mask> ss.dependency "Folly", "2016.09.26.00"
<mask> ss.dependency "ReactABI29_0_0/ABI29_0_0PrivateDatabase"
<mask> ss.compiler_flags = folly_compiler_flags
<mask> ss.source_files = "ReactCommon/ABI29_0_0jschelpers/*.{cpp,h}"
<mask> ss.private_header_files = "ReactCommon/ABI29_0_0jschelpers/*.h"
<mask> ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/ReactCommon\"" }
</s> [sdk31] Update CocoaPods with RN SDK 31 files
Folly was updated, so I went back to the Podspec files for older RN versions and made them use the slightly newer version of Folly used with RN 0.57. </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00"
|
https://github.com/expo/expo/commit/4ac77874d024d32c5f0121f2f6d5c864eabbb1d7
|
ios/versioned-react-native/ABI29_0_0/ReactABI29_0_0.podspec
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> s.subspec "cxxReactABI29_0_0" do |ss|
<mask> ss.dependency "ReactABI29_0_0/ABI29_0_0jschelpers"
<mask> ss.dependency "ReactABI29_0_0/ABI29_0_0jsinspector"
<mask> ss.dependency "boost-for-react-native", "1.63.0"
<mask> ss.dependency "Folly", "2016.09.26.00"
<mask> ss.compiler_flags = folly_compiler_flags
<mask> ss.source_files = "ReactCommon/cxxReactABI29_0_0/*.{cpp,h}"
<mask> ss.exclude_files = "ReactCommon/cxxReactABI29_0_0/ABI29_0_0SampleCxxModule.*"
<mask> ss.private_header_files = "ReactCommon/cxxReactABI29_0_0/*.h"
<mask> ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/ReactCommon\" \"$(PODS_ROOT)/boost-for-react-native\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/Folly\"" }
</s> [sdk31] Update CocoaPods with RN SDK 31 files
Folly was updated, so I went back to the Podspec files for older RN versions and made them use the slightly newer version of Folly used with RN 0.57. </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00"
|
https://github.com/expo/expo/commit/4ac77874d024d32c5f0121f2f6d5c864eabbb1d7
|
ios/versioned-react-native/ABI29_0_0/ReactABI29_0_0.podspec
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> ss.source_files = "Expo/Optional/**/*.{h,m}"
<mask> end
<mask>
<mask> s.subspec "CxxBridge" do |ss|
<mask> ss.dependency "Folly", "2016.09.26.00"
<mask> ss.dependency "ReactABI30_0_0/Core"
<mask> ss.dependency "ReactABI30_0_0/cxxReactABI30_0_0"
<mask> ss.compiler_flags = folly_compiler_flags
<mask> ss.private_header_files = "React/Cxx*/*.h"
<mask> ss.source_files = "React/Cxx*/*.{h,m,mm}"
</s> [sdk31] Update CocoaPods with RN SDK 31 files
Folly was updated, so I went back to the Podspec files for older RN versions and made them use the slightly newer version of Folly used with RN 0.57. </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00"
|
https://github.com/expo/expo/commit/4ac77874d024d32c5f0121f2f6d5c864eabbb1d7
|
ios/versioned-react-native/ABI30_0_0/ReactABI30_0_0.podspec
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> ss.source_files = "React/**/RCTTV*.{h, m}"
<mask> end
<mask>
<mask> s.subspec "ABI30_0_0jschelpers" do |ss|
<mask> ss.dependency "Folly", "2016.09.26.00"
<mask> ss.dependency "ReactABI30_0_0/PrivateDatabase"
<mask> ss.compiler_flags = folly_compiler_flags
<mask> ss.source_files = "ReactCommon/ABI30_0_0jschelpers/*.{cpp,h}"
<mask> ss.private_header_files = "ReactCommon/ABI30_0_0jschelpers/*.h"
<mask> ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/ReactCommon\"" }
</s> [sdk31] Update CocoaPods with RN SDK 31 files
Folly was updated, so I went back to the Podspec files for older RN versions and made them use the slightly newer version of Folly used with RN 0.57. </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00"
|
https://github.com/expo/expo/commit/4ac77874d024d32c5f0121f2f6d5c864eabbb1d7
|
ios/versioned-react-native/ABI30_0_0/ReactABI30_0_0.podspec
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> s.subspec "cxxReactABI30_0_0" do |ss|
<mask> ss.dependency "ReactABI30_0_0/ABI30_0_0jschelpers"
<mask> ss.dependency "ReactABI30_0_0/ABI30_0_0jsinspector"
<mask> ss.dependency "boost-for-react-native", "1.63.0"
<mask> ss.dependency "Folly", "2016.09.26.00"
<mask> ss.compiler_flags = folly_compiler_flags
<mask> ss.source_files = "ReactCommon/cxxReactABI30_0_0/*.{cpp,h}"
<mask> ss.exclude_files = "ReactCommon/cxxReactABI30_0_0/SampleCxxModule.*"
<mask> ss.private_header_files = "ReactCommon/cxxReactABI30_0_0/*.h"
<mask> ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/ReactCommon\" \"$(PODS_ROOT)/boost-for-react-native\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/Folly\"" }
</s> [sdk31] Update CocoaPods with RN SDK 31 files
Folly was updated, so I went back to the Podspec files for older RN versions and made them use the slightly newer version of Folly used with RN 0.57. </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00" </s> remove ss.dependency "Folly", "2016.09.26.00"
</s> add ss.dependency "Folly", "2016.10.31.00"
|
https://github.com/expo/expo/commit/4ac77874d024d32c5f0121f2f6d5c864eabbb1d7
|
ios/versioned-react-native/ABI30_0_0/ReactABI30_0_0.podspec
|
keep replace keep keep keep keep keep
|
<mask> import { iconSize, OpenInternalIcon } from '@expo/styleguide-native';
<mask> import { View, Text, Spacer, Row, useExpoTheme } from 'expo-dev-client-components';
<mask> import * as WebBrowser from 'expo-web-browser';
<mask> import * as React from 'react';
<mask> import { Linking, Platform } from 'react-native';
<mask> import { TouchableOpacity } from 'react-native-gesture-handler';
<mask> import semver from 'semver';
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove import { useExpoTheme, Text, Spacer, Row, View } from 'expo-dev-client-components';
</s> add import { useExpoTheme, Text, Spacer, View } from 'expo-dev-client-components'; </s> remove import { Platform } from 'react-native';
</s> add </s> remove import { Ionicons } from '../../components/Icons';
</s> add </s> remove title,
</s> add </s> remove title="Unsupported SDK version"
message={`This project's SDK version (${legacyUpdatesSDKMajorVersion}) is no longer supported.`}
</s> add message={`The latest classic update on the 'default' release channel uses SDK (${legacyUpdatesSDKMajorVersion}), which is no longer supported.`} </s> remove title: string;
</s> add
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/LegacyLaunchSection.tsx
|
keep keep keep keep replace replace keep keep keep keep keep
|
<mask> let warning: JSX.Element | null = null;
<mask> if (doesLatestLegacyPublishHaveRuntimeVersion) {
<mask> warning = (
<mask> <WarningBox
<mask> title="Incompatible update"
<mask> message="The latest update uses a runtime version that is not compatible with Expo Go. To continue, create a custom dev client."
<mask> showLearnMore
<mask> onLearnMorePress={() => {
<mask> WebBrowser.openBrowserAsync('https://docs.expo.dev/clients/getting-started/');
<mask> }}
<mask> />
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove title="Unsupported SDK version"
message={`This project's SDK version (${legacyUpdatesSDKMajorVersion}) is no longer supported.`}
</s> add message={`The latest classic update on the 'default' release channel uses SDK (${legacyUpdatesSDKMajorVersion}), which is no longer supported.`} </s> remove title: string;
</s> add </s> remove <View>
<SectionHeader header="Classic Release Channels" style={{ paddingTop: 0 }} />
<View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity>
</View>
<View padding="medium">
<Text size="small" color="secondary" type="InterRegular">
{moreLegacyBranchesText}
</Text>
</View>
</s> add <View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity> </s> remove <View bg="warning" border="warning" rounded="medium" padding="medium">
<Row align="center">
<Ionicons
name={Platform.select({ ios: 'ios-warning', default: 'md-warning' })}
size={18}
lightColor={theme.text.warning}
darkColor={theme.text.warning}
style={{
marginRight: 4,
}}
/>
<Text color="warning" type="InterSemiBold">
{title}
</Text>
</Row>
<Spacer.Vertical size="small" />
<Text color="warning" type="InterRegular">
</s> add <View bg="warning" border="warning" rounded="large" padding="medium">
<Text color="warning" type="InterRegular" size="medium"> </s> remove <>
</s> add <View>
<SectionHeader header="Classic release channels" style={{ paddingTop: 0 }} /> </s> remove {appHasLegacyUpdate(app) && <LegacyLaunchSection app={app} />}
{appHasEASUpdates(app) && <EASUpdateLaunchSection app={app} />}
{!appHasLegacyUpdate(app) && !appHasEASUpdates(app) && <EmptySection />}
<Spacer.Vertical size="xl" />
</s> add {appHasEASUpdates(app) && (
<>
<EASUpdateLaunchSection app={app} />
<Spacer.Vertical size="xl" />
</>
)}
{appHasLegacyUpdate(app) && (
<>
<LegacyLaunchSection app={app} />
<Spacer.Vertical size="xl" />
</>
)}
{!appHasLegacyUpdate(app) && !appHasEASUpdates(app) && (
<>
<EmptySection />
<Spacer.Vertical size="xl" />
</>
)}
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/LegacyLaunchSection.tsx
|
keep keep keep keep replace replace keep keep keep keep keep
|
<mask> );
<mask> } else if (isLatestLegacyPublishDeprecated) {
<mask> warning = (
<mask> <WarningBox
<mask> title="Unsupported SDK version"
<mask> message={`This project's SDK version (${legacyUpdatesSDKMajorVersion}) is no longer supported.`}
<mask> />
<mask> );
<mask> }
<mask>
<mask> const theme = useExpoTheme();
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove title="Incompatible update"
message="The latest update uses a runtime version that is not compatible with Expo Go. To continue, create a custom dev client."
</s> add message="The latest classic update on the 'default' release channel uses a runtime version that is not compatible with Expo Go. To continue, create a development build." </s> remove title: string;
</s> add </s> remove <>
</s> add <View>
<SectionHeader header="Classic release channels" style={{ paddingTop: 0 }} /> </s> remove <Spacer.Vertical size="medium" />
</>
</s> add <View padding="medium">
<Text size="small" color="secondary" type="InterRegular">
{moreLegacyBranchesText}
</Text>
</View>
</View> </s> remove import { useExpoTheme, Text, Spacer, Row, View } from 'expo-dev-client-components';
</s> add import { useExpoTheme, Text, Spacer, View } from 'expo-dev-client-components'; </s> remove import { Platform } from 'react-native';
</s> add
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/LegacyLaunchSection.tsx
|
keep keep keep replace keep replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace keep keep
|
<mask> const theme = useExpoTheme();
<mask>
<mask> return (
<mask> <>
<mask> {warning ?? (
<mask> <View>
<mask> <SectionHeader header="Classic Release Channels" style={{ paddingTop: 0 }} />
<mask> <View bg="default" overflow="hidden" rounded="large" border="default">
<mask> <TouchableOpacity
<mask> onPress={() => {
<mask> Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
<mask> }}>
<mask> <Row padding="medium" justify="between" align="center" bg="default">
<mask> <Text size="medium" type="InterRegular">
<mask> default
<mask> </Text>
<mask> <OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
<mask> </Row>
<mask> </TouchableOpacity>
<mask> </View>
<mask> <View padding="medium">
<mask> <Text size="small" color="secondary" type="InterRegular">
<mask> {moreLegacyBranchesText}
<mask> </Text>
<mask> </View>
<mask> </View>
<mask> )}
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove <Spacer.Vertical size="medium" />
</>
</s> add <View padding="medium">
<Text size="small" color="secondary" type="InterRegular">
{moreLegacyBranchesText}
</Text>
</View>
</View> </s> remove <View bg="warning" border="warning" rounded="medium" padding="medium">
<Row align="center">
<Ionicons
name={Platform.select({ ios: 'ios-warning', default: 'md-warning' })}
size={18}
lightColor={theme.text.warning}
darkColor={theme.text.warning}
style={{
marginRight: 4,
}}
/>
<Text color="warning" type="InterSemiBold">
{title}
</Text>
</Row>
<Spacer.Vertical size="small" />
<Text color="warning" type="InterRegular">
</s> add <View bg="warning" border="warning" rounded="large" padding="medium">
<Text color="warning" type="InterRegular" size="medium"> </s> remove {appHasLegacyUpdate(app) && <LegacyLaunchSection app={app} />}
{appHasEASUpdates(app) && <EASUpdateLaunchSection app={app} />}
{!appHasLegacyUpdate(app) && !appHasEASUpdates(app) && <EmptySection />}
<Spacer.Vertical size="xl" />
</s> add {appHasEASUpdates(app) && (
<>
<EASUpdateLaunchSection app={app} />
<Spacer.Vertical size="xl" />
</>
)}
{appHasLegacyUpdate(app) && (
<>
<LegacyLaunchSection app={app} />
<Spacer.Vertical size="xl" />
</>
)}
{!appHasLegacyUpdate(app) && !appHasEASUpdates(app) && (
<>
<EmptySection />
<Spacer.Vertical size="xl" />
</>
)} </s> remove title: string;
</s> add </s> remove title="Unsupported SDK version"
message={`This project's SDK version (${legacyUpdatesSDKMajorVersion}) is no longer supported.`}
</s> add message={`The latest classic update on the 'default' release channel uses SDK (${legacyUpdatesSDKMajorVersion}), which is no longer supported.`}
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/LegacyLaunchSection.tsx
|
keep keep keep keep replace replace keep keep
|
<mask> </Text>
<mask> </View>
<mask> </View>
<mask> )}
<mask> <Spacer.Vertical size="medium" />
<mask> </>
<mask> );
<mask> }
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove <View>
<SectionHeader header="Classic Release Channels" style={{ paddingTop: 0 }} />
<View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity>
</View>
<View padding="medium">
<Text size="small" color="secondary" type="InterRegular">
{moreLegacyBranchesText}
</Text>
</View>
</s> add <View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity> </s> remove <View bg="warning" border="warning" rounded="medium" padding="medium">
<Row align="center">
<Ionicons
name={Platform.select({ ios: 'ios-warning', default: 'md-warning' })}
size={18}
lightColor={theme.text.warning}
darkColor={theme.text.warning}
style={{
marginRight: 4,
}}
/>
<Text color="warning" type="InterSemiBold">
{title}
</Text>
</Row>
<Spacer.Vertical size="small" />
<Text color="warning" type="InterRegular">
</s> add <View bg="warning" border="warning" rounded="large" padding="medium">
<Text color="warning" type="InterRegular" size="medium"> </s> remove {appHasLegacyUpdate(app) && <LegacyLaunchSection app={app} />}
{appHasEASUpdates(app) && <EASUpdateLaunchSection app={app} />}
{!appHasLegacyUpdate(app) && !appHasEASUpdates(app) && <EmptySection />}
<Spacer.Vertical size="xl" />
</s> add {appHasEASUpdates(app) && (
<>
<EASUpdateLaunchSection app={app} />
<Spacer.Vertical size="xl" />
</>
)}
{appHasLegacyUpdate(app) && (
<>
<LegacyLaunchSection app={app} />
<Spacer.Vertical size="xl" />
</>
)}
{!appHasLegacyUpdate(app) && !appHasEASUpdates(app) && (
<>
<EmptySection />
<Spacer.Vertical size="xl" />
</>
)} </s> remove title="Unsupported SDK version"
message={`This project's SDK version (${legacyUpdatesSDKMajorVersion}) is no longer supported.`}
</s> add message={`The latest classic update on the 'default' release channel uses SDK (${legacyUpdatesSDKMajorVersion}), which is no longer supported.`} </s> remove import { useExpoTheme, Text, Spacer, Row, View } from 'expo-dev-client-components';
</s> add import { useExpoTheme, Text, Spacer, View } from 'expo-dev-client-components'; </s> remove import { Platform } from 'react-native';
</s> add
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/LegacyLaunchSection.tsx
|
keep keep keep keep replace replace replace replace keep keep keep keep keep
|
<mask> contents = (
<mask> <ScrollView style={{ flex: 1 }}>
<mask> <ProjectHeader app={app} />
<mask> <View padding="medium">
<mask> {appHasLegacyUpdate(app) && <LegacyLaunchSection app={app} />}
<mask> {appHasEASUpdates(app) && <EASUpdateLaunchSection app={app} />}
<mask> {!appHasLegacyUpdate(app) && !appHasEASUpdates(app) && <EmptySection />}
<mask> <Spacer.Vertical size="xl" />
<mask> <View bg="default" border="default" overflow="hidden" rounded="large">
<mask> <ConstantItem title="Owner" value={app.username} />
<mask> {app.sdkVersion !== '0.0.0' && (
<mask> <>
<mask> <Divider style={{ height: 1 }} />
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove <View>
<SectionHeader header="Classic Release Channels" style={{ paddingTop: 0 }} />
<View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity>
</View>
<View padding="medium">
<Text size="small" color="secondary" type="InterRegular">
{moreLegacyBranchesText}
</Text>
</View>
</s> add <View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity> </s> remove <>
</s> add <View>
<SectionHeader header="Classic release channels" style={{ paddingTop: 0 }} /> </s> remove <View bg="warning" border="warning" rounded="medium" padding="medium">
<Row align="center">
<Ionicons
name={Platform.select({ ios: 'ios-warning', default: 'md-warning' })}
size={18}
lightColor={theme.text.warning}
darkColor={theme.text.warning}
style={{
marginRight: 4,
}}
/>
<Text color="warning" type="InterSemiBold">
{title}
</Text>
</Row>
<Spacer.Vertical size="small" />
<Text color="warning" type="InterRegular">
</s> add <View bg="warning" border="warning" rounded="large" padding="medium">
<Text color="warning" type="InterRegular" size="medium"> </s> remove <Spacer.Vertical size="medium" />
</>
</s> add <View padding="medium">
<Text size="small" color="secondary" type="InterRegular">
{moreLegacyBranchesText}
</Text>
</View>
</View> </s> remove title="Unsupported SDK version"
message={`This project's SDK version (${legacyUpdatesSDKMajorVersion}) is no longer supported.`}
</s> add message={`The latest classic update on the 'default' release channel uses SDK (${legacyUpdatesSDKMajorVersion}), which is no longer supported.`} </s> remove title="Incompatible update"
message="The latest update uses a runtime version that is not compatible with Expo Go. To continue, create a custom dev client."
</s> add message="The latest classic update on the 'default' release channel uses a runtime version that is not compatible with Expo Go. To continue, create a development build."
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/ProjectView.tsx
|
keep replace keep replace keep keep
|
<mask> import { spacing } from '@expo/styleguide-native';
<mask> import { useExpoTheme, Text, Spacer, Row, View } from 'expo-dev-client-components';
<mask> import * as React from 'react';
<mask> import { Platform } from 'react-native';
<mask> import { TouchableOpacity } from 'react-native-gesture-handler';
<mask>
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove import { View, Text, Spacer, Row, useExpoTheme } from 'expo-dev-client-components';
</s> add import { View, Text, Row, useExpoTheme } from 'expo-dev-client-components'; </s> remove import { Ionicons } from '../../components/Icons';
</s> add </s> remove title,
</s> add </s> remove title="Unsupported SDK version"
message={`This project's SDK version (${legacyUpdatesSDKMajorVersion}) is no longer supported.`}
</s> add message={`The latest classic update on the 'default' release channel uses SDK (${legacyUpdatesSDKMajorVersion}), which is no longer supported.`} </s> remove title: string;
</s> add
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/WarningBox.tsx
|
keep keep keep keep replace replace keep keep keep keep keep
|
<mask> import * as React from 'react';
<mask> import { Platform } from 'react-native';
<mask> import { TouchableOpacity } from 'react-native-gesture-handler';
<mask>
<mask> import { Ionicons } from '../../components/Icons';
<mask>
<mask> export function WarningBox({
<mask> title,
<mask> message,
<mask> showLearnMore,
<mask> onLearnMorePress,
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove import { Platform } from 'react-native';
</s> add </s> remove title,
</s> add </s> remove import { useExpoTheme, Text, Spacer, Row, View } from 'expo-dev-client-components';
</s> add import { useExpoTheme, Text, Spacer, View } from 'expo-dev-client-components'; </s> remove import { View, Text, Spacer, Row, useExpoTheme } from 'expo-dev-client-components';
</s> add import { View, Text, Row, useExpoTheme } from 'expo-dev-client-components'; </s> remove title: string;
</s> add </s> remove title="Unsupported SDK version"
message={`This project's SDK version (${legacyUpdatesSDKMajorVersion}) is no longer supported.`}
</s> add message={`The latest classic update on the 'default' release channel uses SDK (${legacyUpdatesSDKMajorVersion}), which is no longer supported.`}
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/WarningBox.tsx
|
keep keep replace keep keep keep keep replace keep keep keep
|
<mask>
<mask> export function WarningBox({
<mask> title,
<mask> message,
<mask> showLearnMore,
<mask> onLearnMorePress,
<mask> }: {
<mask> title: string;
<mask> message: string;
<mask> showLearnMore?: boolean;
<mask> onLearnMorePress?: () => void;
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove import { Ionicons } from '../../components/Icons';
</s> add </s> remove import { Platform } from 'react-native';
</s> add </s> remove <View>
<SectionHeader header="Classic Release Channels" style={{ paddingTop: 0 }} />
<View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity>
</View>
<View padding="medium">
<Text size="small" color="secondary" type="InterRegular">
{moreLegacyBranchesText}
</Text>
</View>
</s> add <View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity> </s> remove title="Incompatible update"
message="The latest update uses a runtime version that is not compatible with Expo Go. To continue, create a custom dev client."
</s> add message="The latest classic update on the 'default' release channel uses a runtime version that is not compatible with Expo Go. To continue, create a development build." </s> remove import { useExpoTheme, Text, Spacer, Row, View } from 'expo-dev-client-components';
</s> add import { useExpoTheme, Text, Spacer, View } from 'expo-dev-client-components';
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/WarningBox.tsx
|
keep keep keep keep replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace keep keep keep keep keep
|
<mask> </TouchableOpacity>
<mask> </>
<mask> ) : null;
<mask> return (
<mask> <View bg="warning" border="warning" rounded="medium" padding="medium">
<mask> <Row align="center">
<mask> <Ionicons
<mask> name={Platform.select({ ios: 'ios-warning', default: 'md-warning' })}
<mask> size={18}
<mask> lightColor={theme.text.warning}
<mask> darkColor={theme.text.warning}
<mask> style={{
<mask> marginRight: 4,
<mask> }}
<mask> />
<mask> <Text color="warning" type="InterSemiBold">
<mask> {title}
<mask> </Text>
<mask> </Row>
<mask> <Spacer.Vertical size="small" />
<mask> <Text color="warning" type="InterRegular">
<mask> {message}
<mask> </Text>
<mask> {learnMoreButton}
<mask> </View>
<mask> );
</s> [home] make outdated classic update warning more informative (#18790)
* [home] make outdated classic update warning more informative
* Update home/screens/ProjectScreen/LegacyLaunchSection.tsx
Co-authored-by: Jon Samp <[email protected]>
Co-authored-by: Jon Samp <[email protected]> </s> remove <View>
<SectionHeader header="Classic Release Channels" style={{ paddingTop: 0 }} />
<View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity>
</View>
<View padding="medium">
<Text size="small" color="secondary" type="InterRegular">
{moreLegacyBranchesText}
</Text>
</View>
</s> add <View bg="default" overflow="hidden" rounded="large" border="default">
<TouchableOpacity
onPress={() => {
Linking.openURL(UrlUtils.normalizeUrl(app.fullName));
}}>
<Row padding="medium" justify="between" align="center" bg="default">
<Text size="medium" type="InterRegular">
default
</Text>
<OpenInternalIcon color={theme.icon.default} size={iconSize.tiny} />
</Row>
</TouchableOpacity> </s> remove <Spacer.Vertical size="medium" />
</>
</s> add <View padding="medium">
<Text size="small" color="secondary" type="InterRegular">
{moreLegacyBranchesText}
</Text>
</View>
</View> </s> remove {appHasLegacyUpdate(app) && <LegacyLaunchSection app={app} />}
{appHasEASUpdates(app) && <EASUpdateLaunchSection app={app} />}
{!appHasLegacyUpdate(app) && !appHasEASUpdates(app) && <EmptySection />}
<Spacer.Vertical size="xl" />
</s> add {appHasEASUpdates(app) && (
<>
<EASUpdateLaunchSection app={app} />
<Spacer.Vertical size="xl" />
</>
)}
{appHasLegacyUpdate(app) && (
<>
<LegacyLaunchSection app={app} />
<Spacer.Vertical size="xl" />
</>
)}
{!appHasLegacyUpdate(app) && !appHasEASUpdates(app) && (
<>
<EmptySection />
<Spacer.Vertical size="xl" />
</>
)} </s> remove <>
</s> add <View>
<SectionHeader header="Classic release channels" style={{ paddingTop: 0 }} /> </s> remove title="Incompatible update"
message="The latest update uses a runtime version that is not compatible with Expo Go. To continue, create a custom dev client."
</s> add message="The latest classic update on the 'default' release channel uses a runtime version that is not compatible with Expo Go. To continue, create a development build." </s> remove title="Unsupported SDK version"
message={`This project's SDK version (${legacyUpdatesSDKMajorVersion}) is no longer supported.`}
</s> add message={`The latest classic update on the 'default' release channel uses SDK (${legacyUpdatesSDKMajorVersion}), which is no longer supported.`}
|
https://github.com/expo/expo/commit/5392f6d44752172d58efb6234daa8f556e4768bc
|
home/screens/ProjectScreen/WarningBox.tsx
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> // TODO: Reduce layers of indirection
<mask> export async function createBundlesAsync(
<mask> projectRoot: string,
<mask> publishOptions: PublishOptions = {},
<mask> bundleOptions: { platforms: Platform[]; dev?: boolean; useDevServer: boolean }
<mask> ): Promise<Partial<Record<Platform, BundleOutput>>> {
<mask> const { exp } = getConfig(projectRoot, { skipSDKVersionRequirement: true });
<mask>
<mask> const bundles = await bundleAsync(
<mask> projectRoot,
</s> Close config file watchers to ensure process can exit. (#21199)
# Why
This was a bug and now it's fixed.
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
Start and stop the dev server in `expo start`, this should now
completely close and not hang open.
---------
Co-authored-by: Expo Bot <[email protected]> </s> remove const notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
notifier.startObserving();
</s> add this.notifier?.stopObserving();
this.notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
this.notifier.startObserving(); </s> remove useDevServer: true,
</s> add </s> add private notifier: FileNotifier | null = null;
</s> remove
if (this.devSession) {
this.devSession.stopNotifying();
}
</s> add this.devSession?.stopNotifying?.(); </s> add // Stop file watching.
this.notifier?.stopObserving();
|
https://github.com/expo/expo/commit/5404abc1cd083b0a244ab6094f413c6d1b141fdc
|
packages/@expo/cli/src/export/createBundles.ts
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> { resetCache: !!clear },
<mask> {
<mask> platforms,
<mask> dev,
<mask> useDevServer: true,
<mask> // TODO: Disable source map generation if we aren't outputting them.
<mask> }
<mask> );
<mask>
<mask> // Log bundle size info to the user
</s> Close config file watchers to ensure process can exit. (#21199)
# Why
This was a bug and now it's fixed.
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
Start and stop the dev server in `expo start`, this should now
completely close and not hang open.
---------
Co-authored-by: Expo Bot <[email protected]> </s> remove bundleOptions: { platforms: Platform[]; dev?: boolean; useDevServer: boolean }
</s> add bundleOptions: { platforms: Platform[]; dev?: boolean } </s> remove
if (this.devSession) {
this.devSession.stopNotifying();
}
</s> add this.devSession?.stopNotifying?.(); </s> add // Stop file watching.
this.notifier?.stopObserving();
</s> remove const notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
notifier.startObserving();
</s> add this.notifier?.stopObserving();
this.notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
this.notifier.startObserving(); </s> add private notifier: FileNotifier | null = null;
|
https://github.com/expo/expo/commit/5404abc1cd083b0a244ab6094f413c6d1b141fdc
|
packages/@expo/cli/src/export/exportApp.ts
|
keep keep keep add keep keep keep keep
|
<mask> private platformManagers: Record<string, PlatformManager<any>> = {};
<mask> /** Manages the creation of dev server URLs. */
<mask> protected urlCreator?: UrlCreator | null = null;
<mask>
<mask> constructor(
<mask> /** Project root folder. */
<mask> public projectRoot: string,
<mask> /** A mapping of bundlers to platforms. */
</s> Close config file watchers to ensure process can exit. (#21199)
# Why
This was a bug and now it's fixed.
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
Start and stop the dev server in `expo start`, this should now
completely close and not hang open.
---------
Co-authored-by: Expo Bot <[email protected]> </s> remove bundleOptions: { platforms: Platform[]; dev?: boolean; useDevServer: boolean }
</s> add bundleOptions: { platforms: Platform[]; dev?: boolean } </s> add // Stop file watching.
this.notifier?.stopObserving();
</s> remove const notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
notifier.startObserving();
</s> add this.notifier?.stopObserving();
this.notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
this.notifier.startObserving(); </s> remove
if (this.devSession) {
this.devSession.stopNotifying();
}
</s> add this.devSession?.stopNotifying?.(); </s> remove useDevServer: true,
</s> add
|
https://github.com/expo/expo/commit/5404abc1cd083b0a244ab6094f413c6d1b141fdc
|
packages/@expo/cli/src/start/server/BundlerDevServer.ts
|
keep keep keep keep replace replace keep keep keep keep keep
|
<mask>
<mask> protected abstract getConfigModuleIds(): string[];
<mask>
<mask> protected watchConfig() {
<mask> const notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
<mask> notifier.startObserving();
<mask> }
<mask>
<mask> /** Create ngrok instance and start the tunnel server. Exposed for testing. */
<mask> public async _startTunnelAsync(): Promise<AsyncNgrok | null> {
<mask> const port = this.getInstance()?.location.port;
</s> Close config file watchers to ensure process can exit. (#21199)
# Why
This was a bug and now it's fixed.
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
Start and stop the dev server in `expo start`, this should now
completely close and not hang open.
---------
Co-authored-by: Expo Bot <[email protected]> </s> remove bundleOptions: { platforms: Platform[]; dev?: boolean; useDevServer: boolean }
</s> add bundleOptions: { platforms: Platform[]; dev?: boolean } </s> remove
if (this.devSession) {
this.devSession.stopNotifying();
}
</s> add this.devSession?.stopNotifying?.(); </s> add private notifier: FileNotifier | null = null;
</s> add // Stop file watching.
this.notifier?.stopObserving();
</s> remove useDevServer: true,
</s> add
|
https://github.com/expo/expo/commit/5404abc1cd083b0a244ab6094f413c6d1b141fdc
|
packages/@expo/cli/src/start/server/BundlerDevServer.ts
|
keep keep keep keep replace replace replace replace replace keep keep keep keep keep
|
<mask>
<mask> protected async startDevSessionAsync() {
<mask> // This is used to make Expo Go open the project in either Expo Go, or the web browser.
<mask> // Must come after ngrok (`startTunnelAsync`) setup.
<mask>
<mask> if (this.devSession) {
<mask> this.devSession.stopNotifying();
<mask> }
<mask>
<mask> this.devSession = new DevelopmentSession(
<mask> this.projectRoot,
<mask> // This URL will be used on external devices so the computer IP won't be relevant.
<mask> this.isTargetingNative()
<mask> ? this.getNativeRuntimeUrl()
</s> Close config file watchers to ensure process can exit. (#21199)
# Why
This was a bug and now it's fixed.
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
Start and stop the dev server in `expo start`, this should now
completely close and not hang open.
---------
Co-authored-by: Expo Bot <[email protected]> </s> add // Stop file watching.
this.notifier?.stopObserving();
</s> remove useDevServer: true,
</s> add </s> remove const notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
notifier.startObserving();
</s> add this.notifier?.stopObserving();
this.notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
this.notifier.startObserving(); </s> remove bundleOptions: { platforms: Platform[]; dev?: boolean; useDevServer: boolean }
</s> add bundleOptions: { platforms: Platform[]; dev?: boolean } </s> add private notifier: FileNotifier | null = null;
|
https://github.com/expo/expo/commit/5404abc1cd083b0a244ab6094f413c6d1b141fdc
|
packages/@expo/cli/src/start/server/BundlerDevServer.ts
|
keep keep add keep keep keep keep
|
<mask>
<mask> /** Stop the running dev server instance. */
<mask> async stopAsync() {
<mask> // Stop the dev session timer and tell Expo API to remove dev session.
<mask> await this.devSession?.closeAsync();
<mask>
<mask> // Stop ngrok if running.
</s> Close config file watchers to ensure process can exit. (#21199)
# Why
This was a bug and now it's fixed.
# How
<!--
How did you build this feature or fix this bug and why?
-->
# Test Plan
Start and stop the dev server in `expo start`, this should now
completely close and not hang open.
---------
Co-authored-by: Expo Bot <[email protected]> </s> remove
if (this.devSession) {
this.devSession.stopNotifying();
}
</s> add this.devSession?.stopNotifying?.(); </s> add private notifier: FileNotifier | null = null;
</s> remove useDevServer: true,
</s> add </s> remove bundleOptions: { platforms: Platform[]; dev?: boolean; useDevServer: boolean }
</s> add bundleOptions: { platforms: Platform[]; dev?: boolean } </s> remove const notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
notifier.startObserving();
</s> add this.notifier?.stopObserving();
this.notifier = new FileNotifier(this.projectRoot, this.getConfigModuleIds());
this.notifier.startObserving();
|
https://github.com/expo/expo/commit/5404abc1cd083b0a244ab6094f413c6d1b141fdc
|
packages/@expo/cli/src/start/server/BundlerDevServer.ts
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> return <P>No API data file found, sorry!</P>;
<mask> }
<mask> };
<mask>
<mask> const APISection: React.FC<Props> = ({ packageName, apiName, forceVersion }) => {
<mask> const { version } = useContext(DocumentationPageContext);
<mask> const resolvedVersion =
<mask> forceVersion ||
<mask> (version === 'unversioned' ? version : version === 'latest' ? LATEST_VERSION : version);
<mask> return renderAPI(packageName, resolvedVersion, apiName, !!forceVersion);
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
</s> add const APISectionTypes = ({ data }: APISectionTypesProps) => </s> remove const APISectionMethods: React.FC<APISectionMethodsProps> = ({
data,
apiName,
header = 'Methods',
}) =>
</s> add const APISectionMethods = ({ data, apiName, header = 'Methods' }: APISectionMethodsProps) => </s> remove export const CommentTextBlock: React.FC<CommentTextBlockProps> = ({
</s> add export const CommentTextBlock = ({ </s> remove return <InlineCode>{resolveTypeName(type)}</InlineCode>;
</s> add return <InlineCode key={`signature-type-${type.name}`}>{resolveTypeName(type)}</InlineCode>; </s> remove const APISectionProps: React.FC<APISectionPropsProps> = ({
data,
defaultProps,
header = 'Props',
}) =>
</s> add const APISectionProps = ({ data, defaultProps, header = 'Props' }: APISectionPropsProps) => </s> remove }) => {
</s> add }: CommentTextBlockProps) => {
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/APISection.tsx
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> ) : null}
<mask> </div>
<mask> );
<mask>
<mask> const APISectionComponents: React.FC<APISectionComponentsProps> = ({ data, componentsProps }) =>
<mask> data?.length ? (
<mask> <>
<mask> <H2 key="components-header">Components</H2>
<mask> {data.map(component =>
<mask> renderComponent(
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISectionConstants: React.FC<APISectionConstantsProps> = ({ data, apiName }) =>
</s> add const APISectionConstants = ({ data, apiName }: APISectionConstantsProps) => </s> remove const APISectionProps: React.FC<APISectionPropsProps> = ({
data,
defaultProps,
header = 'Props',
}) =>
</s> add const APISectionProps = ({ data, defaultProps, header = 'Props' }: APISectionPropsProps) => </s> remove const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
</s> add const APISectionEnums = ({ data }: APISectionEnumsProps) => </s> remove const APISectionInterfaces: React.FC<APISectionInterfacesProps> = ({ data }) =>
</s> add const APISectionInterfaces = ({ data }: APISectionInterfacesProps) => </s> remove const APISectionMethods: React.FC<APISectionMethodsProps> = ({
data,
apiName,
header = 'Methods',
}) =>
</s> add const APISectionMethods = ({ data, apiName, header = 'Methods' }: APISectionMethodsProps) => </s> remove const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
</s> add const APISectionTypes = ({ data }: APISectionTypesProps) =>
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionComponents.tsx
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> <CommentTextBlock comment={comment} />
<mask> </div>
<mask> );
<mask>
<mask> const APISectionConstants: React.FC<APISectionConstantsProps> = ({ data, apiName }) =>
<mask> data?.length ? (
<mask> <>
<mask> <H2 key="constants-header">Constants</H2>
<mask> {data.map(constant => renderConstant(constant, apiName))}
<mask> </>
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISectionProps: React.FC<APISectionPropsProps> = ({
data,
defaultProps,
header = 'Props',
}) =>
</s> add const APISectionProps = ({ data, defaultProps, header = 'Props' }: APISectionPropsProps) => </s> remove const APISectionComponents: React.FC<APISectionComponentsProps> = ({ data, componentsProps }) =>
</s> add const APISectionComponents = ({ data, componentsProps }: APISectionComponentsProps) => </s> remove const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
</s> add const APISectionEnums = ({ data }: APISectionEnumsProps) => </s> remove const APISectionMethods: React.FC<APISectionMethodsProps> = ({
data,
apiName,
header = 'Methods',
}) =>
</s> add const APISectionMethods = ({ data, apiName, header = 'Methods' }: APISectionMethodsProps) => </s> remove const APISectionInterfaces: React.FC<APISectionInterfacesProps> = ({ data }) =>
</s> add const APISectionInterfaces = ({ data }: APISectionInterfacesProps) => </s> remove const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
</s> add const APISectionTypes = ({ data }: APISectionTypesProps) =>
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionConstants.tsx
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> </UL>
<mask> </div>
<mask> );
<mask>
<mask> const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
<mask> data?.length ? (
<mask> <>
<mask> <H2 key="enums-header">Enums</H2>
<mask> {data.map(renderEnum)}
<mask> </>
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISectionInterfaces: React.FC<APISectionInterfacesProps> = ({ data }) =>
</s> add const APISectionInterfaces = ({ data }: APISectionInterfacesProps) => </s> remove const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
</s> add const APISectionTypes = ({ data }: APISectionTypesProps) => </s> remove const APISectionConstants: React.FC<APISectionConstantsProps> = ({ data, apiName }) =>
</s> add const APISectionConstants = ({ data, apiName }: APISectionConstantsProps) => </s> remove const APISectionComponents: React.FC<APISectionComponentsProps> = ({ data, componentsProps }) =>
</s> add const APISectionComponents = ({ data, componentsProps }: APISectionComponentsProps) => </s> remove const APISectionProps: React.FC<APISectionPropsProps> = ({
data,
defaultProps,
header = 'Props',
}) =>
</s> add const APISectionProps = ({ data, defaultProps, header = 'Props' }: APISectionPropsProps) => </s> remove const APISectionMethods: React.FC<APISectionMethodsProps> = ({
data,
apiName,
header = 'Methods',
}) =>
</s> add const APISectionMethods = ({ data, apiName, header = 'Methods' }: APISectionMethodsProps) =>
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionEnums.tsx
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> </table>
<mask> </div>
<mask> ) : null;
<mask>
<mask> const APISectionInterfaces: React.FC<APISectionInterfacesProps> = ({ data }) =>
<mask> data?.length ? (
<mask> <>
<mask> <H2 key="interfaces-header">Interfaces</H2>
<mask> {data.map(renderInterface)}
<mask> </>
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
</s> add const APISectionEnums = ({ data }: APISectionEnumsProps) => </s> remove const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
</s> add const APISectionTypes = ({ data }: APISectionTypesProps) => </s> remove const APISectionComponents: React.FC<APISectionComponentsProps> = ({ data, componentsProps }) =>
</s> add const APISectionComponents = ({ data, componentsProps }: APISectionComponentsProps) => </s> remove const APISectionConstants: React.FC<APISectionConstantsProps> = ({ data, apiName }) =>
</s> add const APISectionConstants = ({ data, apiName }: APISectionConstantsProps) => </s> remove const APISectionProps: React.FC<APISectionPropsProps> = ({
data,
defaultProps,
header = 'Props',
}) =>
</s> add const APISectionProps = ({ data, defaultProps, header = 'Props' }: APISectionPropsProps) => </s> remove }) => {
</s> add }: CommentTextBlockProps) => {
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionInterfaces.tsx
|
keep keep keep keep replace replace replace replace replace keep keep keep keep keep
|
<mask> {index + 1 !== dataLength && <hr />}
<mask> </div>
<mask> ));
<mask>
<mask> const APISectionMethods: React.FC<APISectionMethodsProps> = ({
<mask> data,
<mask> apiName,
<mask> header = 'Methods',
<mask> }) =>
<mask> data?.length ? (
<mask> <>
<mask> <H2 key="methods-header">{header}</H2>
<mask> {data.map((method, index) => renderMethod(method, index, data.length, apiName, header))}
<mask> </>
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISectionProps: React.FC<APISectionPropsProps> = ({
data,
defaultProps,
header = 'Props',
}) =>
</s> add const APISectionProps = ({ data, defaultProps, header = 'Props' }: APISectionPropsProps) => </s> remove const APISection: React.FC<Props> = ({ packageName, apiName, forceVersion }) => {
</s> add const APISection = ({ packageName, apiName, forceVersion }: Props) => { </s> remove const APISectionConstants: React.FC<APISectionConstantsProps> = ({ data, apiName }) =>
</s> add const APISectionConstants = ({ data, apiName }: APISectionConstantsProps) => </s> remove const APISectionComponents: React.FC<APISectionComponentsProps> = ({ data, componentsProps }) =>
</s> add const APISectionComponents = ({ data, componentsProps }: APISectionComponentsProps) => </s> remove const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
</s> add const APISectionEnums = ({ data }: APISectionEnumsProps) => </s> remove const APISectionInterfaces: React.FC<APISectionInterfacesProps> = ({ data }) =>
</s> add const APISectionInterfaces = ({ data }: APISectionInterfacesProps) =>
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionMethods.tsx
|
keep keep keep keep replace replace replace replace replace keep keep keep keep keep
|
<mask> <CommentTextBlock comment={getCommentOrSignatureComment(comment, signatures)} />
<mask> </LI>
<mask> );
<mask>
<mask> const APISectionProps: React.FC<APISectionPropsProps> = ({
<mask> data,
<mask> defaultProps,
<mask> header = 'Props',
<mask> }) =>
<mask> data?.length ? (
<mask> <>
<mask> {header === 'Props' ? (
<mask> <H2 key="props-header">{header}</H2>
<mask> ) : (
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISectionConstants: React.FC<APISectionConstantsProps> = ({ data, apiName }) =>
</s> add const APISectionConstants = ({ data, apiName }: APISectionConstantsProps) => </s> remove const APISectionComponents: React.FC<APISectionComponentsProps> = ({ data, componentsProps }) =>
</s> add const APISectionComponents = ({ data, componentsProps }: APISectionComponentsProps) => </s> remove const APISectionMethods: React.FC<APISectionMethodsProps> = ({
data,
apiName,
header = 'Methods',
}) =>
</s> add const APISectionMethods = ({ data, apiName, header = 'Methods' }: APISectionMethodsProps) => </s> remove const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
</s> add const APISectionEnums = ({ data }: APISectionEnumsProps) => </s> remove const APISectionInterfaces: React.FC<APISectionInterfacesProps> = ({ data }) =>
</s> add const APISectionInterfaces = ({ data }: APISectionInterfacesProps) => </s> remove const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
</s> add const APISectionTypes = ({ data }: APISectionTypesProps) =>
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionProps.tsx
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> }
<mask> return undefined;
<mask> };
<mask>
<mask> const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
<mask> data?.length ? (
<mask> <>
<mask> <H2 key="types-header">Types</H2>
<mask> {data.map(renderType)}
<mask> </>
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISection: React.FC<Props> = ({ packageName, apiName, forceVersion }) => {
</s> add const APISection = ({ packageName, apiName, forceVersion }: Props) => { </s> remove const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
</s> add const APISectionEnums = ({ data }: APISectionEnumsProps) => </s> remove const APISectionInterfaces: React.FC<APISectionInterfacesProps> = ({ data }) =>
</s> add const APISectionInterfaces = ({ data }: APISectionInterfacesProps) => </s> remove const APISectionConstants: React.FC<APISectionConstantsProps> = ({ data, apiName }) =>
</s> add const APISectionConstants = ({ data, apiName }: APISectionConstantsProps) => </s> remove const APISectionProps: React.FC<APISectionPropsProps> = ({
data,
defaultProps,
header = 'Props',
}) =>
</s> add const APISectionProps = ({ data, defaultProps, header = 'Props' }: APISectionPropsProps) => </s> remove const APISectionComponents: React.FC<APISectionComponentsProps> = ({ data, componentsProps }) =>
</s> add const APISectionComponents = ({ data, componentsProps }: APISectionComponentsProps) =>
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionTypes.tsx
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> signatures?: MethodSignatureData[],
<mask> includeParamType: boolean = false
<mask> ) => {
<mask> if (type) {
<mask> return <InlineCode>{resolveTypeName(type)}</InlineCode>;
<mask> } else if (signatures && signatures.length) {
<mask> return signatures.map(({ name, type, parameters }) => (
<mask> <InlineCode key={`signature-type-${name}`}>
<mask> (
<mask> {parameters && includeParamType
</s> [docs] display see annotations in APISection components (#14495) </s> remove <>
</s> add <span key={`signature-param-${param.name}`}> </s> remove const APISection: React.FC<Props> = ({ packageName, apiName, forceVersion }) => {
</s> add const APISection = ({ packageName, apiName, forceVersion }: Props) => { </s> remove }) => {
</s> add }: CommentTextBlockProps) => { </s> remove const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
</s> add const APISectionTypes = ({ data }: APISectionTypesProps) => </s> remove export const CommentTextBlock: React.FC<CommentTextBlockProps> = ({
</s> add export const CommentTextBlock = ({ </s> add const see = getTagData('see', comment);
const seeText = see ? (
<Quote>
<B>See: </B>
<ReactMarkdown components={mdInlineComponents}>{see.text}</ReactMarkdown>
</Quote>
) : null;
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionUtils.tsx
|
keep replace keep keep replace keep keep keep keep
|
<mask> ? parameters.map(param => (
<mask> <>
<mask> {param.name}
<mask> {param.flags?.isOptional && '?'}: {resolveTypeName(param.type)}
<mask> </>
<mask> ))
<mask> : listParams(parameters)}
<mask> ) => {resolveTypeName(type)}
<mask> </InlineCode>
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISectionInterfaces: React.FC<APISectionInterfacesProps> = ({ data }) =>
</s> add const APISectionInterfaces = ({ data }: APISectionInterfacesProps) => </s> add const see = getTagData('see', comment);
const seeText = see ? (
<Quote>
<B>See: </B>
<ReactMarkdown components={mdInlineComponents}>{see.text}</ReactMarkdown>
</Quote>
) : null;
</s> remove const APISectionProps: React.FC<APISectionPropsProps> = ({
data,
defaultProps,
header = 'Props',
}) =>
</s> add const APISectionProps = ({ data, defaultProps, header = 'Props' }: APISectionPropsProps) => </s> remove const APISectionComponents: React.FC<APISectionComponentsProps> = ({ data, componentsProps }) =>
</s> add const APISectionComponents = ({ data, componentsProps }: APISectionComponentsProps) => </s> remove const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
</s> add const APISectionEnums = ({ data }: APISectionEnumsProps) =>
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionUtils.tsx
|
keep keep keep keep replace keep keep keep keep replace keep
|
<mask>
<mask> export const getTagData = (tagName: string, comment?: CommentData) =>
<mask> comment?.tags?.filter(tag => tag.tag === tagName)[0];
<mask>
<mask> export const CommentTextBlock: React.FC<CommentTextBlockProps> = ({
<mask> comment,
<mask> components = mdComponents,
<mask> withDash,
<mask> beforeContent,
<mask> }) => {
<mask> const shortText = comment?.shortText?.trim().length ? (
</s> [docs] display see annotations in APISection components (#14495) </s> remove const APISection: React.FC<Props> = ({ packageName, apiName, forceVersion }) => {
</s> add const APISection = ({ packageName, apiName, forceVersion }: Props) => { </s> remove const APISectionProps: React.FC<APISectionPropsProps> = ({
data,
defaultProps,
header = 'Props',
}) =>
</s> add const APISectionProps = ({ data, defaultProps, header = 'Props' }: APISectionPropsProps) => </s> remove const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
</s> add const APISectionEnums = ({ data }: APISectionEnumsProps) => </s> remove const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
</s> add const APISectionTypes = ({ data }: APISectionTypesProps) => </s> remove const APISectionComponents: React.FC<APISectionComponentsProps> = ({ data, componentsProps }) =>
</s> add const APISectionComponents = ({ data, componentsProps }: APISectionComponentsProps) =>
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionUtils.tsx
|
keep add keep keep keep keep keep
|
<mask> ) : null;
<mask>
<mask> return (
<mask> <>
<mask> {deprecationNote}
<mask> {beforeContent}
<mask> {withDash && (shortText || text) && ' - '}
</s> [docs] display see annotations in APISection components (#14495) </s> add {seeText} </s> remove return <InlineCode>{resolveTypeName(type)}</InlineCode>;
</s> add return <InlineCode key={`signature-type-${type.name}`}>{resolveTypeName(type)}</InlineCode>; </s> remove <>
</s> add <span key={`signature-param-${param.name}`}> </s> remove const APISectionInterfaces: React.FC<APISectionInterfacesProps> = ({ data }) =>
</s> add const APISectionInterfaces = ({ data }: APISectionInterfacesProps) => </s> remove </>
</s> add </span> </s> remove }) => {
</s> add }: CommentTextBlockProps) => {
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionUtils.tsx
|
keep keep add keep keep keep keep keep keep
|
<mask> {withDash && (shortText || text) && ' - '}
<mask> {shortText}
<mask> {text}
<mask> {exampleText}
<mask> </>
<mask> );
<mask> };
<mask>
<mask> export const STYLES_OPTIONAL = css`
</s> [docs] display see annotations in APISection components (#14495) </s> add const see = getTagData('see', comment);
const seeText = see ? (
<Quote>
<B>See: </B>
<ReactMarkdown components={mdInlineComponents}>{see.text}</ReactMarkdown>
</Quote>
) : null;
</s> remove export const CommentTextBlock: React.FC<CommentTextBlockProps> = ({
</s> add export const CommentTextBlock = ({ </s> remove const APISection: React.FC<Props> = ({ packageName, apiName, forceVersion }) => {
</s> add const APISection = ({ packageName, apiName, forceVersion }: Props) => { </s> remove const APISectionTypes: React.FC<APISectionTypesProps> = ({ data }) =>
</s> add const APISectionTypes = ({ data }: APISectionTypesProps) => </s> remove const APISectionEnums: React.FC<APISectionEnumsProps> = ({ data }) =>
</s> add const APISectionEnums = ({ data }: APISectionEnumsProps) => </s> remove const APISectionConstants: React.FC<APISectionConstantsProps> = ({ data, apiName }) =>
</s> add const APISectionConstants = ({ data, apiName }: APISectionConstantsProps) =>
|
https://github.com/expo/expo/commit/558a63fea09123ba4d3cabbb4862f540198804a9
|
docs/components/plugins/api/APISectionUtils.tsx
|
keep add keep keep keep keep keep
|
<mask> "npm-package-arg": "^7.0.0",
<mask> "ora": "3.4.0",
<mask> "progress": "2.0.3",
<mask> "prompts": "^2.3.2",
<mask> "qrcode-terminal": "0.11.0",
<mask> "requireg": "^0.2.2",
<mask> "resolve-from": "^5.0.0",
</s> fix(cli): add missing `pretty-bytes` dependency (#17235)
* fix(cli): add missing `pretty-bytes` dependency
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Expo Bot <[email protected]> </s> add "@types/uuid": "^3.4.7", </s> remove "@types/uuid": "^3.4.7",
</s> add </s> add "text-table": "^0.2.0", </s> remove "text-table": "^0.2.0",
</s> add
|
https://github.com/expo/expo/commit/5637a6912a53cd89e004e8755b1867bcfa3c2c45
|
packages/@expo/cli/package.json
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> "semver": "^6.3.0",
<mask> "slugify": "^1.3.4",
<mask> "structured-headers": "^0.4.1",
<mask> "tar": "^6.0.5",
<mask> "text-table": "^0.2.0",
<mask> "tempy": "^0.7.1",
<mask> "terminal-link": "^2.1.1",
<mask> "url-join": "4.0.0",
<mask> "uuid": "^3.4.0",
<mask> "wrap-ansi": "^7.0.0"
</s> fix(cli): add missing `pretty-bytes` dependency (#17235)
* fix(cli): add missing `pretty-bytes` dependency
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Expo Bot <[email protected]> </s> add "text-table": "^0.2.0", </s> add "@types/uuid": "^3.4.7", </s> remove "@types/uuid": "^3.4.7",
</s> add </s> add "pretty-bytes": "5.6.0",
|
https://github.com/expo/expo/commit/5637a6912a53cd89e004e8755b1867bcfa3c2c45
|
packages/@expo/cli/package.json
|
keep keep add keep keep keep keep
|
<mask> "tar": "^6.0.5",
<mask> "tempy": "^0.7.1",
<mask> "terminal-link": "^2.1.1",
<mask> "url-join": "4.0.0",
<mask> "uuid": "^3.4.0",
<mask> "wrap-ansi": "^7.0.0"
<mask> },
</s> fix(cli): add missing `pretty-bytes` dependency (#17235)
* fix(cli): add missing `pretty-bytes` dependency
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Expo Bot <[email protected]> </s> remove "text-table": "^0.2.0",
</s> add </s> add "@types/uuid": "^3.4.7", </s> remove "@types/uuid": "^3.4.7",
</s> add </s> add "pretty-bytes": "5.6.0",
|
https://github.com/expo/expo/commit/5637a6912a53cd89e004e8755b1867bcfa3c2c45
|
packages/@expo/cli/package.json
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> "@types/progress": "^2.0.5",
<mask> "@types/prompts": "^2.0.6",
<mask> "@types/tar": "^6.1.1",
<mask> "@types/text-table": "^0.2.1",
<mask> "@types/uuid": "^3.4.7",
<mask> "@types/url-join": "^4.0.0",
<mask> "@types/webpack": "~4.41.32",
<mask> "@types/webpack-dev-server": "3.11.0",
<mask> "@types/wrap-ansi": "^8.0.1",
<mask> "expo-module-scripts": "^2.0.0",
</s> fix(cli): add missing `pretty-bytes` dependency (#17235)
* fix(cli): add missing `pretty-bytes` dependency
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Expo Bot <[email protected]> </s> add "@types/uuid": "^3.4.7", </s> add "text-table": "^0.2.0", </s> remove "text-table": "^0.2.0",
</s> add </s> add "pretty-bytes": "5.6.0",
|
https://github.com/expo/expo/commit/5637a6912a53cd89e004e8755b1867bcfa3c2c45
|
packages/@expo/cli/package.json
|
keep add keep keep keep keep
|
<mask> "@types/text-table": "^0.2.1",
<mask> "@types/url-join": "^4.0.0",
<mask> "@types/webpack": "~4.41.32",
<mask> "@types/webpack-dev-server": "3.11.0",
<mask> "@types/wrap-ansi": "^8.0.1",
<mask> "expo-module-scripts": "^2.0.0",
</s> fix(cli): add missing `pretty-bytes` dependency (#17235)
* fix(cli): add missing `pretty-bytes` dependency
* Update packages/@expo/cli/CHANGELOG.md
Co-authored-by: Expo Bot <[email protected]>
Co-authored-by: Expo Bot <[email protected]> </s> remove "@types/uuid": "^3.4.7",
</s> add </s> add "text-table": "^0.2.0", </s> remove "text-table": "^0.2.0",
</s> add </s> add "pretty-bytes": "5.6.0",
|
https://github.com/expo/expo/commit/5637a6912a53cd89e004e8755b1867bcfa3c2c45
|
packages/@expo/cli/package.json
|
keep keep keep keep replace replace replace replace replace replace keep keep keep keep keep
|
<mask>
<mask> public func definition() -> ModuleDefinition {
<mask> Name("ExpoKeepAwake")
<mask>
<mask> AsyncFunction("activate", activate)
<mask> AsyncFunction("deactivate", deactivate)
<mask> AsyncFunction("isActivated", isActivated)
<mask>
<mask> OnAppEntersForeground {
<mask> if !self.activeTags.isEmpty {
<mask> setActivated(true)
<mask> }
<mask> }
<mask> OnAppEntersBackground {
<mask> if !self.activeTags.isEmpty {
</s> [keep-awake] Attempt to fix the crash by not referencing the function (#18553) </s> remove private func deactivate(tag: String) -> Bool {
activeTags.remove(tag)
if activeTags.isEmpty {
setActivated(false)
</s> add OnAppEntersForeground {
if !self.activeTags.isEmpty {
setActivated(true)
} </s> remove OnAppEntersBackground {
if !self.activeTags.isEmpty {
</s> add AsyncFunction("deactivate") { (tag: String) -> Bool in
self.activeTags.remove(tag)
if self.activeTags.isEmpty { </s> remove private func isActivated() -> Bool {
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
</s> add OnAppEntersBackground {
if !self.activeTags.isEmpty {
setActivated(false)
}
} </s> remove }
</s> add </s> remove activeTags.insert(tag)
return true
}
</s> add </s> remove private func activate(tag: String) -> Bool {
if activeTags.isEmpty {
setActivated(true)
</s> add AsyncFunction("isActivated") { () -> Bool in
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
}
|
https://github.com/expo/expo/commit/574835a40d1224af523ee7ef9442647f32828cd6
|
packages/expo-keep-awake/ios/KeepAwakeModule.swift
|
keep keep add keep keep keep keep
|
<mask> if self.activeTags.isEmpty {
<mask> setActivated(true)
<mask> }
<mask> }
<mask>
<mask> AsyncFunction("deactivate") { (tag: String) -> Bool in
<mask> self.activeTags.remove(tag)
</s> [keep-awake] Attempt to fix the crash by not referencing the function (#18553) </s> remove OnAppEntersBackground {
if !self.activeTags.isEmpty {
</s> add AsyncFunction("deactivate") { (tag: String) -> Bool in
self.activeTags.remove(tag)
if self.activeTags.isEmpty { </s> remove AsyncFunction("activate", activate)
AsyncFunction("deactivate", deactivate)
AsyncFunction("isActivated", isActivated)
OnAppEntersForeground {
if !self.activeTags.isEmpty {
</s> add AsyncFunction("activate") { (tag: String) -> Bool in
if self.activeTags.isEmpty { </s> remove }
</s> add </s> add return true </s> remove activeTags.insert(tag)
return true
}
</s> add </s> remove private func activate(tag: String) -> Bool {
if activeTags.isEmpty {
setActivated(true)
</s> add AsyncFunction("isActivated") { () -> Bool in
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
}
|
https://github.com/expo/expo/commit/574835a40d1224af523ee7ef9442647f32828cd6
|
packages/expo-keep-awake/ios/KeepAwakeModule.swift
|
keep keep keep keep replace replace keep keep keep keep keep
|
<mask> if !self.activeTags.isEmpty {
<mask> setActivated(true)
<mask> }
<mask> }
<mask> OnAppEntersBackground {
<mask> if !self.activeTags.isEmpty {
<mask> setActivated(false)
<mask> }
<mask> }
<mask> }
<mask>
</s> [keep-awake] Attempt to fix the crash by not referencing the function (#18553) </s> remove private func isActivated() -> Bool {
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
</s> add OnAppEntersBackground {
if !self.activeTags.isEmpty {
setActivated(false)
}
} </s> remove AsyncFunction("activate", activate)
AsyncFunction("deactivate", deactivate)
AsyncFunction("isActivated", isActivated)
OnAppEntersForeground {
if !self.activeTags.isEmpty {
</s> add AsyncFunction("activate") { (tag: String) -> Bool in
if self.activeTags.isEmpty { </s> remove }
</s> add </s> remove private func deactivate(tag: String) -> Bool {
activeTags.remove(tag)
if activeTags.isEmpty {
setActivated(false)
</s> add OnAppEntersForeground {
if !self.activeTags.isEmpty {
setActivated(true)
} </s> remove return true
}
}
</s> add </s> remove private func activate(tag: String) -> Bool {
if activeTags.isEmpty {
setActivated(true)
</s> add AsyncFunction("isActivated") { () -> Bool in
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
}
|
https://github.com/expo/expo/commit/574835a40d1224af523ee7ef9442647f32828cd6
|
packages/expo-keep-awake/ios/KeepAwakeModule.swift
|
keep keep add keep keep keep keep keep
|
<mask> if self.activeTags.isEmpty {
<mask> setActivated(false)
<mask> }
<mask> }
<mask>
<mask> AsyncFunction("isActivated") { () -> Bool in
<mask> return DispatchQueue.main.sync {
<mask> return UIApplication.shared.isIdleTimerDisabled
</s> [keep-awake] Attempt to fix the crash by not referencing the function (#18553) </s> remove private func activate(tag: String) -> Bool {
if activeTags.isEmpty {
setActivated(true)
</s> add AsyncFunction("isActivated") { () -> Bool in
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
} </s> remove return true
}
}
</s> add </s> remove private func isActivated() -> Bool {
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
</s> add OnAppEntersBackground {
if !self.activeTags.isEmpty {
setActivated(false)
}
} </s> add self.activeTags.insert(tag)
return true </s> remove OnAppEntersBackground {
if !self.activeTags.isEmpty {
</s> add AsyncFunction("deactivate") { (tag: String) -> Bool in
self.activeTags.remove(tag)
if self.activeTags.isEmpty { </s> remove private func deactivate(tag: String) -> Bool {
activeTags.remove(tag)
if activeTags.isEmpty {
setActivated(false)
</s> add OnAppEntersForeground {
if !self.activeTags.isEmpty {
setActivated(true)
}
|
https://github.com/expo/expo/commit/574835a40d1224af523ee7ef9442647f32828cd6
|
packages/expo-keep-awake/ios/KeepAwakeModule.swift
|
keep keep keep keep replace keep replace replace replace keep
|
<mask> if !self.activeTags.isEmpty {
<mask> setActivated(false)
<mask> }
<mask> }
<mask> }
<mask>
<mask> private func activate(tag: String) -> Bool {
<mask> if activeTags.isEmpty {
<mask> setActivated(true)
<mask> }
</s> [keep-awake] Attempt to fix the crash by not referencing the function (#18553) </s> remove activeTags.insert(tag)
return true
}
</s> add </s> remove private func deactivate(tag: String) -> Bool {
activeTags.remove(tag)
if activeTags.isEmpty {
setActivated(false)
</s> add OnAppEntersForeground {
if !self.activeTags.isEmpty {
setActivated(true)
} </s> remove OnAppEntersBackground {
if !self.activeTags.isEmpty {
</s> add AsyncFunction("deactivate") { (tag: String) -> Bool in
self.activeTags.remove(tag)
if self.activeTags.isEmpty { </s> remove private func isActivated() -> Bool {
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
</s> add OnAppEntersBackground {
if !self.activeTags.isEmpty {
setActivated(false)
}
} </s> remove return true
}
}
</s> add
|
https://github.com/expo/expo/commit/574835a40d1224af523ee7ef9442647f32828cd6
|
packages/expo-keep-awake/ios/KeepAwakeModule.swift
|
keep keep keep replace replace replace keep replace replace replace replace keep keep keep
|
<mask> if activeTags.isEmpty {
<mask> setActivated(true)
<mask> }
<mask> activeTags.insert(tag)
<mask> return true
<mask> }
<mask>
<mask> private func deactivate(tag: String) -> Bool {
<mask> activeTags.remove(tag)
<mask> if activeTags.isEmpty {
<mask> setActivated(false)
<mask> }
<mask> return true
<mask> }
</s> [keep-awake] Attempt to fix the crash by not referencing the function (#18553) </s> remove return true
}
}
</s> add </s> remove private func activate(tag: String) -> Bool {
if activeTags.isEmpty {
setActivated(true)
</s> add AsyncFunction("isActivated") { () -> Bool in
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
} </s> remove private func isActivated() -> Bool {
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
</s> add OnAppEntersBackground {
if !self.activeTags.isEmpty {
setActivated(false)
}
} </s> remove }
</s> add </s> add return true
|
https://github.com/expo/expo/commit/574835a40d1224af523ee7ef9442647f32828cd6
|
packages/expo-keep-awake/ios/KeepAwakeModule.swift
|
keep keep replace replace replace keep replace replace replace keep keep keep keep
|
<mask> setActivated(false)
<mask> }
<mask> return true
<mask> }
<mask> }
<mask>
<mask> private func isActivated() -> Bool {
<mask> return DispatchQueue.main.sync {
<mask> return UIApplication.shared.isIdleTimerDisabled
<mask> }
<mask> }
<mask>
<mask> private func setActivated(_ activated: Bool) {
</s> [keep-awake] Attempt to fix the crash by not referencing the function (#18553) </s> remove private func activate(tag: String) -> Bool {
if activeTags.isEmpty {
setActivated(true)
</s> add AsyncFunction("isActivated") { () -> Bool in
return DispatchQueue.main.sync {
return UIApplication.shared.isIdleTimerDisabled
} </s> add return true </s> remove private func deactivate(tag: String) -> Bool {
activeTags.remove(tag)
if activeTags.isEmpty {
setActivated(false)
</s> add OnAppEntersForeground {
if !self.activeTags.isEmpty {
setActivated(true)
} </s> remove activeTags.insert(tag)
return true
}
</s> add </s> remove }
</s> add
|
https://github.com/expo/expo/commit/574835a40d1224af523ee7ef9442647f32828cd6
|
packages/expo-keep-awake/ios/KeepAwakeModule.swift
|
keep add keep keep keep keep keep
|
<mask> B5678C5F1DB6D65B00380A6E /* EXFrame.m in Sources */ = {isa = PBXBuildFile; fileRef = B5678C5C1DB6D65B00380A6E /* EXFrame.m */; };
<mask> B5678C601DB6D65B00380A6E /* EXFrameManager.m in Sources */ = {isa = PBXBuildFile; fileRef = B5678C5E1DB6D65B00380A6E /* EXFrameManager.m */; };
<mask> B56FACA21D4AB279009FC106 /* EXAppState.m in Sources */ = {isa = PBXBuildFile; fileRef = B56FACA11D4AB279009FC106 /* EXAppState.m */; };
<mask> B56FACAD1D4C0266009FC106 /* EXFingerprint.m in Sources */ = {isa = PBXBuildFile; fileRef = B56FACAC1D4C0266009FC106 /* EXFingerprint.m */; };
<mask> B575EE9A1D53E0AB00DCABBC /* EXCachedResource.m in Sources */ = {isa = PBXBuildFile; fileRef = B575EE991D53E0AB00DCABBC /* EXCachedResource.m */; };
<mask> B575EE9E1D53EEC300DCABBC /* EXJavaScriptResource.m in Sources */ = {isa = PBXBuildFile; fileRef = B575EE9D1D53EEC300DCABBC /* EXJavaScriptResource.m */; };
<mask> B575EEA11D54053500DCABBC /* EXManifestResource.m in Sources */ = {isa = PBXBuildFile; fileRef = B575EEA01D54053500DCABBC /* EXManifestResource.m */; };
</s> Capture shake gesture in EXKernel
fbshipit-source-id: 4d2378b </s> add B56D0A3A1E8058E600504DD2 /* EXKernelDevMotionHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EXKernelDevMotionHandler.h; sourceTree = "<group>"; };
B56D0A3B1E8058E600504DD2 /* EXKernelDevMotionHandler.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = EXKernelDevMotionHandler.m; sourceTree = "<group>"; }; </s> add B56D0A3A1E8058E600504DD2 /* EXKernelDevMotionHandler.h */,
B56D0A3B1E8058E600504DD2 /* EXKernelDevMotionHandler.m */, </s> add B56D0A3C1E8058E600504DD2 /* EXKernelDevMotionHandler.m in Sources */,
|
https://github.com/expo/expo/commit/57a9d10fc9784e35a9d0ef95b702960ff89c1715
|
ios/Exponent.xcodeproj/project.pbxproj
|
keep keep add keep keep keep keep keep keep
|
<mask> B5678C5C1DB6D65B00380A6E /* EXFrame.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = EXFrame.m; sourceTree = "<group>"; };
<mask> B5678C5D1DB6D65B00380A6E /* EXFrameManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EXFrameManager.h; sourceTree = "<group>"; };
<mask> B5678C5E1DB6D65B00380A6E /* EXFrameManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = EXFrameManager.m; sourceTree = "<group>"; };
<mask> B56FACA01D4AB279009FC106 /* EXAppState.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EXAppState.h; sourceTree = "<group>"; };
<mask> B56FACA11D4AB279009FC106 /* EXAppState.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = EXAppState.m; sourceTree = "<group>"; };
<mask> B56FACAB1D4C0266009FC106 /* EXFingerprint.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EXFingerprint.h; sourceTree = "<group>"; };
<mask> B56FACAC1D4C0266009FC106 /* EXFingerprint.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = EXFingerprint.m; sourceTree = "<group>"; };
<mask> B5722ACA1DFB36440084848F /* EXKeys.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EXKeys.h; sourceTree = "<group>"; };
<mask> B575EE981D53E0AB00DCABBC /* EXCachedResource.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EXCachedResource.h; sourceTree = "<group>"; };
</s> Capture shake gesture in EXKernel
fbshipit-source-id: 4d2378b </s> add B56D0A3C1E8058E600504DD2 /* EXKernelDevMotionHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = B56D0A3B1E8058E600504DD2 /* EXKernelDevMotionHandler.m */; }; </s> add B56D0A3A1E8058E600504DD2 /* EXKernelDevMotionHandler.h */,
B56D0A3B1E8058E600504DD2 /* EXKernelDevMotionHandler.m */, </s> add B56D0A3C1E8058E600504DD2 /* EXKernelDevMotionHandler.m in Sources */,
|
https://github.com/expo/expo/commit/57a9d10fc9784e35a9d0ef95b702960ff89c1715
|
ios/Exponent.xcodeproj/project.pbxproj
|
keep add keep keep keep keep
|
<mask> B5ACA2D71E650AF700867095 /* EXKernelDevMenuViewController.h */,
<mask> B5ACA2D81E650AF700867095 /* EXKernelDevMenuViewController.m */,
<mask> );
<mask> path = DevSupport;
<mask> sourceTree = "<group>";
<mask> };
</s> Capture shake gesture in EXKernel
fbshipit-source-id: 4d2378b </s> add B56D0A3C1E8058E600504DD2 /* EXKernelDevMotionHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = B56D0A3B1E8058E600504DD2 /* EXKernelDevMotionHandler.m */; }; </s> add B56D0A3A1E8058E600504DD2 /* EXKernelDevMotionHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EXKernelDevMotionHandler.h; sourceTree = "<group>"; };
B56D0A3B1E8058E600504DD2 /* EXKernelDevMotionHandler.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = EXKernelDevMotionHandler.m; sourceTree = "<group>"; }; </s> add B56D0A3C1E8058E600504DD2 /* EXKernelDevMotionHandler.m in Sources */,
|
https://github.com/expo/expo/commit/57a9d10fc9784e35a9d0ef95b702960ff89c1715
|
ios/Exponent.xcodeproj/project.pbxproj
|
keep keep add keep keep keep keep keep keep
|
<mask> B51C2AFD1DC7BB2000120834 /* EXGoogle.m in Sources */,
<mask> B5E4DB621E566614007D43DD /* AIRGoogleMapPolygonManager.m in Sources */,
<mask> 193601151D67ABCF007C0EE0 /* RNSVGGroupManager.m in Sources */,
<mask> 1936010A1D67ABCF007C0EE0 /* RNSVGBrush.m in Sources */,
<mask> 1936012F1D67ABCF007C0EE0 /* RNSVGViewBox.m in Sources */,
<mask> B50625FF1E4B9E6100AC2748 /* EXAnimationViewManager.m in Sources */,
<mask> 841AB1171DA6F56D008C0720 /* EXBarCodeScannerManager.m in Sources */,
<mask> B597EF1E1CD98654004A48AD /* EXLog.m in Sources */,
<mask> 88E089AB1D6BCF5800562FA1 /* EXSegment.m in Sources */,
</s> Capture shake gesture in EXKernel
fbshipit-source-id: 4d2378b </s> add B56D0A3C1E8058E600504DD2 /* EXKernelDevMotionHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = B56D0A3B1E8058E600504DD2 /* EXKernelDevMotionHandler.m */; }; </s> add B56D0A3A1E8058E600504DD2 /* EXKernelDevMotionHandler.h */,
B56D0A3B1E8058E600504DD2 /* EXKernelDevMotionHandler.m */, </s> add B56D0A3A1E8058E600504DD2 /* EXKernelDevMotionHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EXKernelDevMotionHandler.h; sourceTree = "<group>"; };
B56D0A3B1E8058E600504DD2 /* EXKernelDevMotionHandler.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = EXKernelDevMotionHandler.m; sourceTree = "<group>"; };
|
https://github.com/expo/expo/commit/57a9d10fc9784e35a9d0ef95b702960ff89c1715
|
ios/Exponent.xcodeproj/project.pbxproj
|
keep keep keep add keep keep keep keep keep keep
|
<mask> private Launcher mLauncher;
<mask> private boolean mIsEmergencyLaunch = false;
<mask> private boolean mIsUpToDate = true;
<mask> private AppLoaderStatus mStatus;
<mask>
<mask> private boolean isStarted = false;
<mask>
<mask> public interface AppLoaderCallback {
<mask> void onOptimisticManifest(JSONObject optimisticManifest);
<mask> void onManifestCompleted(JSONObject manifest);
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> add public boolean shouldShowAppLoaderStatus() {
return mShouldShowAppLoaderStatus;
}
</s> add private void setShouldShowAppLoaderStatus(JSONObject manifest) {
try {
mShouldShowAppLoaderStatus = !(manifest.has(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY) &&
manifest.getJSONObject(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY)
.optBoolean(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_SILENT_LAUNCH_KEY, false));
} catch (JSONException e) {
mShouldShowAppLoaderStatus = true;
}
}
</s> remove private void maybeSetLoadingProgressStatus() {
</s> add public void setLoadingProgressStatusIfEnabled() { </s> add setShouldShowAppLoaderStatus(update.metadata); </s> add setShouldShowAppLoaderStatus(manifest.getRawManifestJson()); </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus());
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/ExpoUpdatesAppLoader.java
|
keep keep add keep keep keep keep keep keep
|
<mask> return mStatus;
<mask> }
<mask>
<mask> private void updateStatus(AppLoaderStatus status) {
<mask> mStatus = status;
<mask> mCallback.updateStatus(status);
<mask> }
<mask>
<mask> public void start(Context context) {
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> remove public void setLoadingProgressStatus(ExpoUpdatesAppLoader.AppLoaderStatus status) {
</s> add public void setLoadingProgressStatusIfEnabled(ExpoUpdatesAppLoader.AppLoaderStatus status) { </s> remove private void maybeSetLoadingProgressStatus() {
</s> add public void setLoadingProgressStatusIfEnabled() { </s> remove setLoadingProgressStatus(status);
</s> add setLoadingProgressStatusIfEnabled(status); </s> remove return null;
</s> add </s> add private boolean mShouldShowAppLoaderStatus = true;
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/ExpoUpdatesAppLoader.java
|
keep keep keep add keep keep keep keep
|
<mask> }
<mask>
<mask> @Override
<mask> public boolean onCachedUpdateLoaded(UpdateEntity update) {
<mask> if (isUsingDeveloperTool(update.metadata)) {
<mask> return false;
<mask> } else {
<mask> try {
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> add setShouldShowAppLoaderStatus(manifest.getRawManifestJson()); </s> remove setLoadingProgressStatus(status);
</s> add setLoadingProgressStatusIfEnabled(status); </s> add private void setShouldShowAppLoaderStatus(JSONObject manifest) {
try {
mShouldShowAppLoaderStatus = !(manifest.has(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY) &&
manifest.getJSONObject(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY)
.optBoolean(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_SILENT_LAUNCH_KEY, false));
} catch (JSONException e) {
mShouldShowAppLoaderStatus = true;
}
}
</s> add public boolean shouldShowAppLoaderStatus() {
return mShouldShowAppLoaderStatus;
}
</s> remove return null;
</s> add </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus());
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/ExpoUpdatesAppLoader.java
|
keep keep add keep keep keep keep keep keep
|
<mask>
<mask> @Override
<mask> public void onRemoteManifestLoaded(Manifest manifest) {
<mask> mCallback.onOptimisticManifest(manifest.getRawManifestJson());
<mask> updateStatus(AppLoaderStatus.DOWNLOADING_NEW_UPDATE);
<mask> }
<mask>
<mask> @Override
<mask> public void onSuccess(Launcher launcher, boolean isUpToDate) {
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove setLoadingProgressStatus(status);
</s> add setLoadingProgressStatusIfEnabled(status); </s> add setShouldShowAppLoaderStatus(update.metadata); </s> add public boolean shouldShowAppLoaderStatus() {
return mShouldShowAppLoaderStatus;
}
</s> remove public void setLoadingProgressStatus(ExpoUpdatesAppLoader.AppLoaderStatus status) {
</s> add public void setLoadingProgressStatusIfEnabled(ExpoUpdatesAppLoader.AppLoaderStatus status) { </s> remove private void maybeSetLoadingProgressStatus() {
</s> add public void setLoadingProgressStatusIfEnabled() { </s> add private boolean mShouldShowAppLoaderStatus = true;
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/ExpoUpdatesAppLoader.java
|
keep keep keep add keep keep keep keep keep
|
<mask> return false;
<mask> }
<mask> }
<mask>
<mask> private Map<String, String> getRequestHeaders() {
<mask> HashMap<String, String> headers = new HashMap<>();
<mask> headers.put("Expo-Updates-Environment", getClientEnvironment());
<mask> headers.put("Expo-Client-Environment", getClientEnvironment());
<mask>
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> add setShouldShowAppLoaderStatus(update.metadata); </s> add public boolean shouldShowAppLoaderStatus() {
return mShouldShowAppLoaderStatus;
}
</s> remove "Checking for new release..."
</s> add "Checking for new update..." </s> add private boolean mShouldShowAppLoaderStatus = true; </s> remove return null;
</s> add
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/ExpoUpdatesAppLoader.java
|
keep add keep keep keep keep keep keep
|
<mask> public static final String MANIFEST_UPDATES_CHECK_AUTOMATICALLY_ON_ERROR = "ON_ERROR_RECOVERY";
<mask>
<mask> public static final String DEEP_LINK_SEPARATOR = "--";
<mask> public static final String DEEP_LINK_SEPARATOR_WITH_SLASH = "--/";
<mask> public static final String QUERY_PARAM_KEY_RELEASE_CHANNEL = "release-channel";
<mask>
<mask> private static final int MAX_BITMAP_SIZE = 192;
<mask> private static final String REDIRECT_SNIPPET = "exp.host/--/to-exp/";
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove maybeSetLoadingProgressStatus();
</s> add setLoadingProgressStatusIfEnabled(); </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> add private boolean mShouldShowAppLoaderStatus = true; </s> add public boolean shouldShowAppLoaderStatus() {
return mShouldShowAppLoaderStatus;
}
</s> remove maybeSetLoadingProgressStatus();
</s> add setLoadingProgressStatusIfEnabled(); </s> remove private void maybeSetLoadingProgressStatus() {
</s> add public void setLoadingProgressStatusIfEnabled() {
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/ExponentManifest.java
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> }
<mask>
<mask> @Override
<mask> public void updateStatus(ExpoUpdatesAppLoader.AppLoaderStatus status) {
<mask> setLoadingProgressStatus(status);
<mask> }
<mask>
<mask> @Override
<mask> public void onError(Exception e) {
<mask> Exponent.getInstance().runOnUiThread(() -> {
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> add setShouldShowAppLoaderStatus(manifest.getRawManifestJson()); </s> add setShouldShowAppLoaderStatus(update.metadata); </s> remove public void setLoadingProgressStatus(ExpoUpdatesAppLoader.AppLoaderStatus status) {
</s> add public void setLoadingProgressStatusIfEnabled(ExpoUpdatesAppLoader.AppLoaderStatus status) { </s> remove UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.updateProgress(getLoadingProgressText(status), null, null));
</s> add ExpoUpdatesAppLoader appLoader = mKernel.getAppLoaderForManifestUrl(mManifestUrl);
if (appLoader != null && appLoader.shouldShowAppLoaderStatus()) {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.setLoadingProgressStatus(status));
} else {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.hide());
} </s> add public boolean shouldShowAppLoaderStatus() {
return mShouldShowAppLoaderStatus;
}
</s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus());
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/experience/ExperienceActivity.java
|
keep keep keep keep replace keep keep keep keep keep
|
<mask>
<mask> public void startLoading() {
<mask> mIsLoading = true;
<mask> showOrReconfigureManagedAppSplashScreen(mManifest);
<mask> maybeSetLoadingProgressStatus();
<mask> }
<mask>
<mask> /**
<mask> * This method is being called twice:
<mask> * - first time for optimistic manifest
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> add private boolean mShouldShowAppLoaderStatus = true; </s> add private void setShouldShowAppLoaderStatus(JSONObject manifest) {
try {
mShouldShowAppLoaderStatus = !(manifest.has(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY) &&
manifest.getJSONObject(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY)
.optBoolean(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_SILENT_LAUNCH_KEY, false));
} catch (JSONException e) {
mShouldShowAppLoaderStatus = true;
}
}
</s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> remove "Checking for new release..."
</s> add "Checking for new update..." </s> add public boolean shouldShowAppLoaderStatus() {
return mShouldShowAppLoaderStatus;
}
</s> remove return null;
</s> add
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/experience/ExperienceActivity.java
|
keep replace keep keep replace replace replace replace replace replace replace replace replace keep keep keep
|
<mask>
<mask> private void maybeSetLoadingProgressStatus() {
<mask> ExpoUpdatesAppLoader appLoader = mKernel.getAppLoaderForManifestUrl(mManifestUrl);
<mask> if (appLoader != null) {
<mask> setLoadingProgressStatus(appLoader.getStatus());
<mask> }
<mask> }
<mask>
<mask> private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
<mask> if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
<mask> return "Checking for new release...";
<mask> } else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
<mask> return "New release available, downloading...";
<mask> }
<mask> return null;
<mask> }
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove return null;
</s> add </s> remove public void setLoadingProgressStatus(ExpoUpdatesAppLoader.AppLoaderStatus status) {
</s> add public void setLoadingProgressStatusIfEnabled(ExpoUpdatesAppLoader.AppLoaderStatus status) { </s> remove UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.updateProgress(getLoadingProgressText(status), null, null));
</s> add ExpoUpdatesAppLoader appLoader = mKernel.getAppLoaderForManifestUrl(mManifestUrl);
if (appLoader != null && appLoader.shouldShowAppLoaderStatus()) {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.setLoadingProgressStatus(status));
} else {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.hide());
} </s> remove "Checking for new release..."
</s> add "Checking for new update..." </s> add public boolean shouldShowAppLoaderStatus() {
return mShouldShowAppLoaderStatus;
}
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/experience/ExperienceActivity.java
|
keep replace keep keep replace keep keep keep
|
<mask> }
<mask> return null;
<mask> }
<mask>
<mask> public void setLoadingProgressStatus(ExpoUpdatesAppLoader.AppLoaderStatus status) {
<mask> if (Constants.isStandaloneApp()) {
<mask> return;
<mask> }
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> add public boolean shouldShowAppLoaderStatus() {
return mShouldShowAppLoaderStatus;
}
</s> remove setLoadingProgressStatus(status);
</s> add setLoadingProgressStatusIfEnabled(status); </s> remove UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.updateProgress(getLoadingProgressText(status), null, null));
</s> add ExpoUpdatesAppLoader appLoader = mKernel.getAppLoaderForManifestUrl(mManifestUrl);
if (appLoader != null && appLoader.shouldShowAppLoaderStatus()) {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.setLoadingProgressStatus(status));
} else {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.hide());
} </s> remove private void maybeSetLoadingProgressStatus() {
</s> add public void setLoadingProgressStatusIfEnabled() {
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/experience/ExperienceActivity.java
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> }
<mask> if (status == null) {
<mask> return;
<mask> }
<mask> UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.updateProgress(getLoadingProgressText(status), null, null));
<mask> }
<mask>
<mask> public void setOptimisticManifest(final JSONObject optimisticManifest) {
<mask> runOnUiThread(() -> {
<mask> if (!isInForeground()) {
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove public void setLoadingProgressStatus(ExpoUpdatesAppLoader.AppLoaderStatus status) {
</s> add public void setLoadingProgressStatusIfEnabled(ExpoUpdatesAppLoader.AppLoaderStatus status) { </s> remove setLoadingProgressStatus(status);
</s> add setLoadingProgressStatusIfEnabled(status); </s> remove return null;
</s> add </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> remove "Checking for new release..."
</s> add "Checking for new update..." </s> remove maybeSetLoadingProgressStatus();
</s> add setLoadingProgressStatusIfEnabled();
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/experience/ExperienceActivity.java
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> ExperienceActivityUtils.configureStatusBar(optimisticManifest, ExperienceActivity.this);
<mask> ExperienceActivityUtils.setNavigationBar(optimisticManifest, ExperienceActivity.this);
<mask> ExperienceActivityUtils.setTaskDescription(mExponentManifest, optimisticManifest, ExperienceActivity.this);
<mask> showOrReconfigureManagedAppSplashScreen(optimisticManifest);
<mask> maybeSetLoadingProgressStatus();
<mask> });
<mask> }
<mask>
<mask> public void setManifest(String manifestUrl, final JSONObject manifest, final String bundleUrl, final JSONObject kernelOptions) {
<mask> if (!isInForeground()) {
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove maybeSetLoadingProgressStatus();
</s> add setLoadingProgressStatusIfEnabled(); </s> add // Development client
public static final String MANIFEST_DEVELOPMENT_CLIENT_KEY = "developmentClient";
public static final String MANIFEST_DEVELOPMENT_CLIENT_SILENT_LAUNCH_KEY = "silentLaunch";
</s> remove UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.updateProgress(getLoadingProgressText(status), null, null));
</s> add ExpoUpdatesAppLoader appLoader = mKernel.getAppLoaderForManifestUrl(mManifestUrl);
if (appLoader != null && appLoader.shouldShowAppLoaderStatus()) {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.setLoadingProgressStatus(status));
} else {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.hide());
} </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> remove public void setLoadingProgressStatus(ExpoUpdatesAppLoader.AppLoaderStatus status) {
</s> add public void setLoadingProgressStatusIfEnabled(ExpoUpdatesAppLoader.AppLoaderStatus status) { </s> remove setLoadingProgressStatus(status);
</s> add setLoadingProgressStatusIfEnabled(status);
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/experience/ExperienceActivity.java
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> ExperienceActivityUtils.configureStatusBar(manifest, ExperienceActivity.this);
<mask> ExperienceActivityUtils.setNavigationBar(manifest, ExperienceActivity.this);
<mask> ExperienceActivityUtils.setTaskDescription(mExponentManifest, manifest, ExperienceActivity.this);
<mask> showOrReconfigureManagedAppSplashScreen(manifest);
<mask> maybeSetLoadingProgressStatus();
<mask> });
<mask> }
<mask>
<mask> public void setBundle(final String localBundlePath) {
<mask> // by this point, setManifest should have also been called, so prevent
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove maybeSetLoadingProgressStatus();
</s> add setLoadingProgressStatusIfEnabled(); </s> remove
if (!Constants.isStandaloneApp()) {
ExpoUpdatesAppLoader appLoader = mKernel.getAppLoaderForManifestUrl(mManifestUrl);
if (appLoader != null && !appLoader.isUpToDate()) {
new AlertDialog.Builder(this)
.setTitle("Loading app from cache")
.setMessage("Expo was unable to fetch the latest version of this app. A previously downloaded version has been launched. To ensure you're up-to-date, check your network connection and reload the app.")
.setPositiveButton(android.R.string.ok, null)
.show();
}
}
</s> add </s> add // Development client
public static final String MANIFEST_DEVELOPMENT_CLIENT_KEY = "developmentClient";
public static final String MANIFEST_DEVELOPMENT_CLIENT_SILENT_LAUNCH_KEY = "silentLaunch";
</s> remove maybeSetLoadingProgressStatus();
</s> add setLoadingProgressStatusIfEnabled(); </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> remove setLoadingProgressStatus(status);
</s> add setLoadingProgressStatusIfEnabled(status);
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/experience/ExperienceActivity.java
|
keep keep keep keep replace replace replace replace replace replace replace replace replace replace replace keep keep keep keep keep
|
<mask> AsyncCondition.remove(READY_FOR_BUNDLE);
<mask> }
<mask> });
<mask> }
<mask>
<mask> if (!Constants.isStandaloneApp()) {
<mask> ExpoUpdatesAppLoader appLoader = mKernel.getAppLoaderForManifestUrl(mManifestUrl);
<mask> if (appLoader != null && !appLoader.isUpToDate()) {
<mask> new AlertDialog.Builder(this)
<mask> .setTitle("Loading app from cache")
<mask> .setMessage("Expo was unable to fetch the latest version of this app. A previously downloaded version has been launched. To ensure you're up-to-date, check your network connection and reload the app.")
<mask> .setPositiveButton(android.R.string.ok, null)
<mask> .show();
<mask> }
<mask> }
<mask> }
<mask>
<mask> public void onEventMainThread(ReceivedNotificationEvent event) {
<mask> if (event.experienceId.equals(mExperienceIdString)) {
<mask> try {
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.updateProgress(getLoadingProgressText(status), null, null));
</s> add ExpoUpdatesAppLoader appLoader = mKernel.getAppLoaderForManifestUrl(mManifestUrl);
if (appLoader != null && appLoader.shouldShowAppLoaderStatus()) {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.setLoadingProgressStatus(status));
} else {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.hide());
} </s> remove private void maybeSetLoadingProgressStatus() {
</s> add public void setLoadingProgressStatusIfEnabled() { </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> add private void setShouldShowAppLoaderStatus(JSONObject manifest) {
try {
mShouldShowAppLoaderStatus = !(manifest.has(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY) &&
manifest.getJSONObject(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY)
.optBoolean(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_SILENT_LAUNCH_KEY, false));
} catch (JSONException e) {
mShouldShowAppLoaderStatus = true;
}
}
</s> remove public void setLoadingProgressStatus(ExpoUpdatesAppLoader.AppLoaderStatus status) {
</s> add public void setLoadingProgressStatusIfEnabled(ExpoUpdatesAppLoader.AppLoaderStatus status) { </s> add setShouldShowAppLoaderStatus(update.metadata);
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/experience/ExperienceActivity.java
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> }
<mask>
<mask> val text = when (status) {
<mask> ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE -> {
<mask> "Checking for new release..."
<mask> }
<mask> ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE -> {
<mask> "New release available, downloading..."
<mask> }
<mask> }
</s> [android][ios] add option to load without extra dialogs (#9827)
# Why
See discussion in #platform-ios. This PR implements the ability to turn off the extra loading dialogs implemented in #9785 with the manifest `developmentClient.silentLaunch` key, and also re-implements the loading progress bar in the iOS client.
This PR also adds a "Reload" option to the cached project alert.
# How
- Add support for the `developmentClient.silentLaunch` key and set a property on AppLoader as soon as we receive a manifest. Check the AppLoader property before showing a progress bar or alert dialog. (We actually already show a UIActivityIndicatorView in the period of time before the manifest is loaded.)
- Add reload option to alert dialog. (see screenshot)
# Test Plan
- Tested by inverting the logic for `developmentClient.silentLaunch` and ensuring the loading progress bar and alert dialogs do not show up.
- Also manually tested the "Reload" option on the alert dialog on both platforms </s> remove return null;
</s> add </s> remove setLoadingProgressStatus(appLoader.getStatus());
}
}
private String getLoadingProgressText(ExpoUpdatesAppLoader.AppLoaderStatus status) {
if (status == ExpoUpdatesAppLoader.AppLoaderStatus.CHECKING_FOR_UPDATE) {
return "Checking for new release...";
} else if (status == ExpoUpdatesAppLoader.AppLoaderStatus.DOWNLOADING_NEW_UPDATE) {
return "New release available, downloading...";
</s> add setLoadingProgressStatusIfEnabled(appLoader.getStatus()); </s> remove UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.updateProgress(getLoadingProgressText(status), null, null));
</s> add ExpoUpdatesAppLoader appLoader = mKernel.getAppLoaderForManifestUrl(mManifestUrl);
if (appLoader != null && appLoader.shouldShowAppLoaderStatus()) {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.setLoadingProgressStatus(status));
} else {
UiThreadUtil.runOnUiThread(() -> mLoadingProgressPopupController.hide());
} </s> remove setLoadingProgressStatus(status);
</s> add setLoadingProgressStatusIfEnabled(status); </s> add private void setShouldShowAppLoaderStatus(JSONObject manifest) {
try {
mShouldShowAppLoaderStatus = !(manifest.has(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY) &&
manifest.getJSONObject(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_KEY)
.optBoolean(ExponentManifest.MANIFEST_DEVELOPMENT_CLIENT_SILENT_LAUNCH_KEY, false));
} catch (JSONException e) {
mShouldShowAppLoaderStatus = true;
}
}
</s> remove private void maybeSetLoadingProgressStatus() {
</s> add public void setLoadingProgressStatusIfEnabled() {
|
https://github.com/expo/expo/commit/57bba33f10f37ca641236f70b573adadf066f17c
|
android/expoview/src/main/java/host/exp/exponent/experience/loading/LoadingProgressPopupController.kt
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> # Swift/Objective-C compatibility
<mask> s.pod_target_xcconfig = {
<mask> 'USE_HEADERMAP' => 'YES',
<mask> 'DEFINES_MODULE' => 'YES',
<mask> 'CLANG_CXX_LANGUAGE_STANDARD' => 'c++14'
<mask> }
<mask>
<mask> s.dependency 'React-Core'
<mask> s.dependency 'ReactCommon/turbomodule/core'
<mask>
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class SwiftInteropBridge: NSObject {
</s> add public final class SwiftInteropBridge: NSObject { </s> remove public class ConcreteMethod<Args, ReturnType>: AnyMethod {
</s> add public final class ConcreteMethod<Args, ReturnType>: AnyMethod { </s> remove internal class Conversions {
</s> add internal final class Conversions { </s> remove public class ModuleRegistry: Sequence {
</s> add public final class ModuleRegistry: Sequence { </s> remove public class ModuleHolder {
</s> add public final class ModuleHolder { </s> remove public class AppContext {
</s> add public final class AppContext {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/ExpoModulesCore.podspec
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> import UIKit
<mask> /**
<mask> The app context is an interface to a single Expo app.
<mask> */
<mask> public class AppContext {
<mask> /**
<mask> The module registry for the app context.
<mask> */
<mask> public private(set) lazy var moduleRegistry: ModuleRegistry = ModuleRegistry(appContext: self)
<mask>
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class ModuleHolder {
</s> add public final class ModuleHolder { </s> remove public class ModuleDefinition: AnyDefinition {
</s> add public final class ModuleDefinition: AnyDefinition { </s> remove public class SwiftInteropBridge: NSObject {
</s> add public final class SwiftInteropBridge: NSObject { </s> remove public class Field<Type>: AnyFieldInternal {
</s> add public final class Field<Type>: AnyFieldInternal { </s> remove public class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp {
</s> add public final class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp { </s> remove public class ConcreteMethod<Args, ReturnType>: AnyMethod {
</s> add public final class ConcreteMethod<Args, ReturnType>: AnyMethod {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/Swift/AppContext.swift
|
keep replace keep keep keep keep keep
|
<mask>
<mask> internal class Conversions {
<mask> /**
<mask> Converts an array to tuple. Because of tuples nature, it's not possible to convert an array of any size, so we can support only up to some fixed size.
<mask> */
<mask> static func toTuple(_ array: [Any?]) throws -> Any? {
<mask> switch (array.count) {
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class AppContext {
</s> add public final class AppContext { </s> remove public class ModuleDefinition: AnyDefinition {
</s> add public final class ModuleDefinition: AnyDefinition { </s> remove public class ModuleHolder {
</s> add public final class ModuleHolder { </s> remove public class Field<Type>: AnyFieldInternal {
</s> add public final class Field<Type>: AnyFieldInternal { </s> remove public class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp {
</s> add public final class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp { </s> remove public class ConcreteMethod<Args, ReturnType>: AnyMethod {
</s> add public final class ConcreteMethod<Args, ReturnType>: AnyMethod {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/Swift/Conversions.swift
|
keep keep replace keep keep keep keep keep
|
<mask> import Dispatch
<mask>
<mask> public class ConcreteMethod<Args, ReturnType>: AnyMethod {
<mask> public typealias ClosureType = (Args) -> ReturnType
<mask>
<mask> public let name: String
<mask>
<mask> public var takesPromise: Bool {
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp {
</s> add public final class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp { </s> remove public class SwiftInteropBridge: NSObject {
</s> add public final class SwiftInteropBridge: NSObject { </s> remove public class ModuleRegistry: Sequence {
</s> add public final class ModuleRegistry: Sequence { </s> remove public class AppContext {
</s> add public final class AppContext { </s> remove public class ModuleHolder {
</s> add public final class ModuleHolder { </s> remove public class Field<Type>: AnyFieldInternal {
</s> add public final class Field<Type>: AnyFieldInternal {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/Swift/Methods/ConcreteMethod.swift
|
keep keep keep keep replace keep keep keep keep keep
|
<mask>
<mask> /**
<mask> Holds a reference to the module instance and caches its definition.
<mask> */
<mask> public class ModuleHolder {
<mask> /**
<mask> Instance of the module.
<mask> */
<mask> private(set) var module: AnyModule
<mask>
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class AppContext {
</s> add public final class AppContext { </s> remove public class ModuleDefinition: AnyDefinition {
</s> add public final class ModuleDefinition: AnyDefinition { </s> remove public class Field<Type>: AnyFieldInternal {
</s> add public final class Field<Type>: AnyFieldInternal { </s> remove public class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp {
</s> add public final class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp { </s> remove public class ModuleRegistry: Sequence {
</s> add public final class ModuleRegistry: Sequence { </s> remove internal class Conversions {
</s> add internal final class Conversions {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/Swift/ModuleHolder.swift
|
keep replace keep keep keep keep keep
|
<mask>
<mask> public class ModuleRegistry: Sequence {
<mask> public typealias Element = ModuleHolder
<mask>
<mask> private weak var appContext: AppContext?
<mask>
<mask> private var registry: [String: ModuleHolder] = [:]
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class SwiftInteropBridge: NSObject {
</s> add public final class SwiftInteropBridge: NSObject { </s> remove public class ModuleHolder {
</s> add public final class ModuleHolder { </s> remove public class ConcreteMethod<Args, ReturnType>: AnyMethod {
</s> add public final class ConcreteMethod<Args, ReturnType>: AnyMethod { </s> remove public class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp {
</s> add public final class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp { </s> remove public class AppContext {
</s> add public final class AppContext { </s> remove public class Field<Type>: AnyFieldInternal {
</s> add public final class Field<Type>: AnyFieldInternal {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/Swift/ModuleRegistry.swift
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> The definition of the module. It is used to define some parameters
<mask> of the module and what it exports to the JavaScript world.
<mask> See `ModuleDefinitionBuilder` for more details on how to create it.
<mask> */
<mask> public class ModuleDefinition: AnyDefinition {
<mask> /**
<mask> The module's type associated with the definition. It's used to create the module instance.
<mask> */
<mask> var type: AnyModule.Type?
<mask>
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class ModuleHolder {
</s> add public final class ModuleHolder { </s> remove public class AppContext {
</s> add public final class AppContext { </s> remove public class Field<Type>: AnyFieldInternal {
</s> add public final class Field<Type>: AnyFieldInternal { </s> remove internal class Conversions {
</s> add internal final class Conversions { </s> remove public class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp {
</s> add public final class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp { </s> remove public class ModuleRegistry: Sequence {
</s> add public final class ModuleRegistry: Sequence {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/Swift/Modules/ModuleDefinition.swift
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> /**
<mask> Property wrapper for `Record`'s data members that takes part in the process of serialization to and deserialization from the dictionary.
<mask> */
<mask> @propertyWrapper
<mask> public class Field<Type>: AnyFieldInternal {
<mask> /**
<mask> The wrapped value.
<mask> */
<mask> public var wrappedValue: Type
<mask>
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class AppContext {
</s> add public final class AppContext { </s> remove public class ModuleHolder {
</s> add public final class ModuleHolder { </s> remove public class ModuleDefinition: AnyDefinition {
</s> add public final class ModuleDefinition: AnyDefinition { </s> remove public class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp {
</s> add public final class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp { </s> remove public class ConcreteMethod<Args, ReturnType>: AnyMethod {
</s> add public final class ConcreteMethod<Args, ReturnType>: AnyMethod { </s> remove public class ModuleRegistry: Sequence {
</s> add public final class ModuleRegistry: Sequence {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/Swift/Records/Field.swift
|
keep keep keep keep replace keep keep keep keep keep
|
<mask>
<mask> import Foundation
<mask>
<mask> @objc
<mask> public class SwiftInteropBridge: NSObject {
<mask> let appContext: AppContext
<mask>
<mask> var registry: ModuleRegistry {
<mask> appContext.moduleRegistry
<mask> }
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class AppContext {
</s> add public final class AppContext { </s> remove public class ModuleRegistry: Sequence {
</s> add public final class ModuleRegistry: Sequence { </s> remove public class ConcreteMethod<Args, ReturnType>: AnyMethod {
</s> add public final class ConcreteMethod<Args, ReturnType>: AnyMethod { </s> remove public class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp {
</s> add public final class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp { </s> remove public class ModuleHolder {
</s> add public final class ModuleHolder { </s> remove public class Field<Type>: AnyFieldInternal {
</s> add public final class Field<Type>: AnyFieldInternal {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/Swift/SwiftInteropBridge.swift
|
keep keep keep keep replace keep keep keep keep keep
|
<mask>
<mask> /**
<mask> Specialized class for the view prop. Specifies the prop name and its setter.
<mask> */
<mask> public class ConcreteViewProp<ViewType: UIView, PropType>: AnyViewProp {
<mask> public typealias SetterType = (ViewType, PropType) -> Void
<mask>
<mask> public let name: String
<mask>
<mask> let setter: SetterType
</s> [ios] Optimize compiling Swift files (#15025) </s> remove public class ConcreteMethod<Args, ReturnType>: AnyMethod {
</s> add public final class ConcreteMethod<Args, ReturnType>: AnyMethod { </s> remove public class ModuleHolder {
</s> add public final class ModuleHolder { </s> remove public class SwiftInteropBridge: NSObject {
</s> add public final class SwiftInteropBridge: NSObject { </s> remove public class Field<Type>: AnyFieldInternal {
</s> add public final class Field<Type>: AnyFieldInternal { </s> remove public class AppContext {
</s> add public final class AppContext { </s> remove public class ModuleRegistry: Sequence {
</s> add public final class ModuleRegistry: Sequence {
|
https://github.com/expo/expo/commit/5801db0accacaa92d963a21efcd6a67b644d4f15
|
packages/expo-modules-core/ios/Swift/Views/ConcreteViewProp.swift
|
keep add keep keep keep keep keep keep
|
<mask> headers: {
<mask> 'Content-Type': 'text/plain;charset=UTF-8',
<mask> },
<mask> body,
<mask> });
<mask> }
<mask> async addEvent(event) {
<mask> const { userId, userProperties, screenName, options } = this;
</s> [firebase-analytics] Fix failed network requests on Android (#10606)
* [firebase-analytics] Fix failed network requests on Android
* changelog </s> add ...(options.headers || {}), </s> remove ...(options.headers
? {
headers: options.headers,
}
: {}),
</s> add </s> remove ...(options.headers
? {
headers: options.headers,
}
: {}),
</s> add
|
https://github.com/expo/expo/commit/5adf215d1d24790da7223758f5d078380761c7b1
|
packages/expo-firebase-analytics/build/FirebaseAnalyticsJS.js
|
keep keep keep keep replace replace replace replace replace keep keep keep keep keep
|
<mask> cache: 'no-cache',
<mask> headers: {
<mask> 'Content-Type': 'text/plain;charset=UTF-8',
<mask> },
<mask> ...(options.headers
<mask> ? {
<mask> headers: options.headers,
<mask> }
<mask> : {}),
<mask> body,
<mask> });
<mask> }
<mask> async addEvent(event) {
<mask> const { userId, userProperties, screenName, options } = this;
</s> [firebase-analytics] Fix failed network requests on Android (#10606)
* [firebase-analytics] Fix failed network requests on Android
* changelog </s> add ...(options.headers || {}), </s> add ...(options.headers || {}), </s> remove ...(options.headers
? {
headers: options.headers,
}
: {}),
</s> add
|
https://github.com/expo/expo/commit/5adf215d1d24790da7223758f5d078380761c7b1
|
packages/expo-firebase-analytics/build/FirebaseAnalyticsJS.js
|
keep keep keep add keep keep keep keep keep keep
|
<mask> mode: 'no-cors',
<mask> cache: 'no-cache',
<mask> headers: {
<mask> 'Content-Type': 'text/plain;charset=UTF-8',
<mask> },
<mask> body,
<mask> });
<mask> }
<mask>
<mask> private async addEvent(event: FirebaseAnalyticsJSCodedEvent) {
</s> [firebase-analytics] Fix failed network requests on Android (#10606)
* [firebase-analytics] Fix failed network requests on Android
* changelog </s> add ...(options.headers || {}), </s> remove ...(options.headers
? {
headers: options.headers,
}
: {}),
</s> add </s> remove ...(options.headers
? {
headers: options.headers,
}
: {}),
</s> add
|
https://github.com/expo/expo/commit/5adf215d1d24790da7223758f5d078380761c7b1
|
packages/expo-firebase-analytics/src/FirebaseAnalyticsJS.ts
|
keep keep keep keep replace replace replace replace replace keep keep keep keep keep
|
<mask> cache: 'no-cache',
<mask> headers: {
<mask> 'Content-Type': 'text/plain;charset=UTF-8',
<mask> },
<mask> ...(options.headers
<mask> ? {
<mask> headers: options.headers,
<mask> }
<mask> : {}),
<mask> body,
<mask> });
<mask> }
<mask>
<mask> private async addEvent(event: FirebaseAnalyticsJSCodedEvent) {
</s> [firebase-analytics] Fix failed network requests on Android (#10606)
* [firebase-analytics] Fix failed network requests on Android
* changelog </s> add ...(options.headers || {}), </s> add ...(options.headers || {}), </s> remove ...(options.headers
? {
headers: options.headers,
}
: {}),
</s> add
|
https://github.com/expo/expo/commit/5adf215d1d24790da7223758f5d078380761c7b1
|
packages/expo-firebase-analytics/src/FirebaseAnalyticsJS.ts
|
keep keep keep keep replace replace replace replace replace replace replace replace keep replace replace replace replace replace replace replace replace replace
|
<mask> import com.swmansion.gesturehandler.react.RNGestureHandlerEnabledRootView;
<mask>
<mask> public class MainActivity extends ReactActivity {
<mask>
<mask> /**
<mask> * Returns the name of the main component registered from JavaScript.
<mask> * This is used to schedule rendering of the component.
<mask> */
<mask> @Override
<mask> protected String getMainComponentName() {
<mask> return "BareExpo";
<mask> }
<mask>
<mask> @Override
<mask> protected ReactActivityDelegate createReactActivityDelegate() {
<mask> return new ReactActivityDelegate(this, getMainComponentName()) {
<mask> @Override
<mask> protected ReactRootView createRootView() {
<mask> return new RNGestureHandlerEnabledRootView(MainActivity.this);
<mask> }
<mask> };
<mask> }
</s> [bare-expo] Fix MainApplication configuration (#7372)
# Why
- Contrary to what I believed, `ExpoImagePackage` is properly discovered by `react-native` autolinking so we don't need to add it manually too.
- We want to have neat prettified files at all times.
# How
- Removed `ExpoImagePackage` from among manually added packages
- Prettified files with Android Studio
# Test Plan
- generated `PackageList` contains `ExpoImagePackage` </s> remove packages.add(new ExpoImagePackage());
</s> add </s> remove new BasePackageList().getPackageList(),
null
</s> add new BasePackageList().getPackageList(),
null </s> remove import java.util.Arrays;
</s> add </s> remove import org.unimodules.core.interfaces.Package;
import org.unimodules.core.interfaces.SingletonModule;
import expo.modules.constants.ConstantsPackage;
import expo.modules.image.ExpoImagePackage;
import expo.modules.permissions.PermissionsPackage;
import expo.modules.filesystem.FileSystemPackage;
</s> add </s> remove import org.unimodules.adapters.react.ReactAdapterPackage;
</s> add
|
https://github.com/expo/expo/commit/5b1f4c2722b38ef3cf693f79ced295bc8de99087
|
apps/bare-expo/android/app/src/main/java/dev/expo/payments/MainActivity.java
|
keep keep keep keep replace keep keep replace
|
<mask> import com.facebook.react.PackageList;
<mask> import com.facebook.react.ReactApplication;
<mask> import com.facebook.react.ReactNativeHost;
<mask> import com.facebook.react.ReactPackage;
<mask> import com.facebook.react.shell.MainReactPackage;
<mask> import com.facebook.soloader.SoLoader;
<mask>
<mask> import org.unimodules.adapters.react.ReactAdapterPackage;
</s> [bare-expo] Fix MainApplication configuration (#7372)
# Why
- Contrary to what I believed, `ExpoImagePackage` is properly discovered by `react-native` autolinking so we don't need to add it manually too.
- We want to have neat prettified files at all times.
# How
- Removed `ExpoImagePackage` from among manually added packages
- Prettified files with Android Studio
# Test Plan
- generated `PackageList` contains `ExpoImagePackage` </s> remove import org.unimodules.core.interfaces.Package;
import org.unimodules.core.interfaces.SingletonModule;
import expo.modules.constants.ConstantsPackage;
import expo.modules.image.ExpoImagePackage;
import expo.modules.permissions.PermissionsPackage;
import expo.modules.filesystem.FileSystemPackage;
</s> add </s> remove import java.util.Arrays;
</s> add </s> remove new BasePackageList().getPackageList(),
null
</s> add new BasePackageList().getPackageList(),
null </s> remove /**
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "BareExpo";
}
</s> add /**
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "BareExpo";
} </s> remove packages.add(new ExpoImagePackage());
</s> add
|
https://github.com/expo/expo/commit/5b1f4c2722b38ef3cf693f79ced295bc8de99087
|
apps/bare-expo/android/app/src/main/java/dev/expo/payments/MainApplication.java
|
keep keep keep keep replace replace replace replace replace replace keep replace keep keep
|
<mask>
<mask> import org.unimodules.adapters.react.ReactAdapterPackage;
<mask> import org.unimodules.adapters.react.ModuleRegistryAdapter;
<mask> import org.unimodules.adapters.react.ReactModuleRegistryProvider;
<mask> import org.unimodules.core.interfaces.Package;
<mask> import org.unimodules.core.interfaces.SingletonModule;
<mask> import expo.modules.constants.ConstantsPackage;
<mask> import expo.modules.image.ExpoImagePackage;
<mask> import expo.modules.permissions.PermissionsPackage;
<mask> import expo.modules.filesystem.FileSystemPackage;
<mask>
<mask> import java.util.Arrays;
<mask> import java.util.List;
<mask>
</s> [bare-expo] Fix MainApplication configuration (#7372)
# Why
- Contrary to what I believed, `ExpoImagePackage` is properly discovered by `react-native` autolinking so we don't need to add it manually too.
- We want to have neat prettified files at all times.
# How
- Removed `ExpoImagePackage` from among manually added packages
- Prettified files with Android Studio
# Test Plan
- generated `PackageList` contains `ExpoImagePackage` </s> remove import org.unimodules.adapters.react.ReactAdapterPackage;
</s> add </s> remove import com.facebook.react.shell.MainReactPackage;
</s> add </s> remove new BasePackageList().getPackageList(),
null
</s> add new BasePackageList().getPackageList(),
null </s> remove /**
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "BareExpo";
}
</s> add /**
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "BareExpo";
} </s> remove packages.add(new ExpoImagePackage());
</s> add
|
https://github.com/expo/expo/commit/5b1f4c2722b38ef3cf693f79ced295bc8de99087
|
apps/bare-expo/android/app/src/main/java/dev/expo/payments/MainApplication.java
|
keep keep keep keep replace replace keep keep keep keep keep
|
<mask> import dev.expo.payments.generated.BasePackageList;
<mask>
<mask> public class MainApplication extends Application implements ReactApplication {
<mask> private final ReactModuleRegistryProvider mModuleRegistryProvider = new ReactModuleRegistryProvider(
<mask> new BasePackageList().getPackageList(),
<mask> null
<mask> );
<mask>
<mask> private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
<mask> @Override
<mask> public boolean getUseDeveloperSupport() {
</s> [bare-expo] Fix MainApplication configuration (#7372)
# Why
- Contrary to what I believed, `ExpoImagePackage` is properly discovered by `react-native` autolinking so we don't need to add it manually too.
- We want to have neat prettified files at all times.
# How
- Removed `ExpoImagePackage` from among manually added packages
- Prettified files with Android Studio
# Test Plan
- generated `PackageList` contains `ExpoImagePackage` </s> remove import java.util.Arrays;
</s> add </s> remove packages.add(new ExpoImagePackage());
</s> add </s> remove /**
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "BareExpo";
}
</s> add /**
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "BareExpo";
} </s> remove @Override
protected ReactActivityDelegate createReactActivityDelegate() {
return new ReactActivityDelegate(this, getMainComponentName()) {
@Override
protected ReactRootView createRootView() {
return new RNGestureHandlerEnabledRootView(MainActivity.this);
}
};
}
</s> add @Override
protected ReactActivityDelegate createReactActivityDelegate() {
return new ReactActivityDelegate(this, getMainComponentName()) {
@Override
protected ReactRootView createRootView() {
return new RNGestureHandlerEnabledRootView(MainActivity.this);
}
};
} </s> remove import org.unimodules.core.interfaces.Package;
import org.unimodules.core.interfaces.SingletonModule;
import expo.modules.constants.ConstantsPackage;
import expo.modules.image.ExpoImagePackage;
import expo.modules.permissions.PermissionsPackage;
import expo.modules.filesystem.FileSystemPackage;
</s> add </s> remove import org.unimodules.adapters.react.ReactAdapterPackage;
</s> add
|
https://github.com/expo/expo/commit/5b1f4c2722b38ef3cf693f79ced295bc8de99087
|
apps/bare-expo/android/app/src/main/java/dev/expo/payments/MainApplication.java
|
keep keep keep keep replace keep keep keep keep keep
|
<mask>
<mask> @Override
<mask> protected List<ReactPackage> getPackages() {
<mask> List<ReactPackage> packages = new PackageList(this).getPackages();
<mask> packages.add(new ExpoImagePackage());
<mask> packages.add(new ModuleRegistryAdapter(mModuleRegistryProvider));
<mask> return packages;
<mask> }
<mask>
<mask>
</s> [bare-expo] Fix MainApplication configuration (#7372)
# Why
- Contrary to what I believed, `ExpoImagePackage` is properly discovered by `react-native` autolinking so we don't need to add it manually too.
- We want to have neat prettified files at all times.
# How
- Removed `ExpoImagePackage` from among manually added packages
- Prettified files with Android Studio
# Test Plan
- generated `PackageList` contains `ExpoImagePackage` </s> remove @Override
protected ReactActivityDelegate createReactActivityDelegate() {
return new ReactActivityDelegate(this, getMainComponentName()) {
@Override
protected ReactRootView createRootView() {
return new RNGestureHandlerEnabledRootView(MainActivity.this);
}
};
}
</s> add @Override
protected ReactActivityDelegate createReactActivityDelegate() {
return new ReactActivityDelegate(this, getMainComponentName()) {
@Override
protected ReactRootView createRootView() {
return new RNGestureHandlerEnabledRootView(MainActivity.this);
}
};
} </s> remove /**
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "BareExpo";
}
</s> add /**
* Returns the name of the main component registered from JavaScript.
* This is used to schedule rendering of the component.
*/
@Override
protected String getMainComponentName() {
return "BareExpo";
} </s> remove new BasePackageList().getPackageList(),
null
</s> add new BasePackageList().getPackageList(),
null </s> remove import java.util.Arrays;
</s> add </s> remove import org.unimodules.core.interfaces.Package;
import org.unimodules.core.interfaces.SingletonModule;
import expo.modules.constants.ConstantsPackage;
import expo.modules.image.ExpoImagePackage;
import expo.modules.permissions.PermissionsPackage;
import expo.modules.filesystem.FileSystemPackage;
</s> add </s> remove import org.unimodules.adapters.react.ReactAdapterPackage;
</s> add
|
https://github.com/expo/expo/commit/5b1f4c2722b38ef3cf693f79ced295bc8de99087
|
apps/bare-expo/android/app/src/main/java/dev/expo/payments/MainApplication.java
|
keep keep add keep keep
|
<mask> import { BrowserResult, OpenBrowserOptions } from './WebBrowser.types';
<mask> declare const _default: {
<mask> readonly name: string;
<mask> };
<mask> export default _default;
</s> [web] WebBrowser.openBrowserAsync (#4283)
* Create WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.ts
* Update ExpoWebBrowser.web.ts
* Create WebBrowser.types.js.map
* Create WebBrowser.types.js
* Create WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js
* Update ExpoWebBrowser.web.d.ts
* Update WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.js.map
* Update WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.d.ts
* Update ExpoWebBrowser.web.js.map
* Removed `replace` type
* Update WebBrowser.types.d.ts
* Update WebBrowser.types.js.map
* Removed `replace` prop
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js </s> remove type RedirectEvent = {
url: string;
};
type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
type AuthSessionResult = RedirectResult | BrowserResult;
type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
</s> add import {
RedirectEvent,
OpenBrowserOptions,
AuthSessionResult,
CustomTabsBrowsersResults,
BrowserResult,
RedirectResult,
ServiceActionResult,
MayInitWithUrlResult,
WarmUpResult,
CoolDownResult,
} from './WebBrowser.types'; </s> remove declare type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
declare type AuthSessionResult = RedirectResult | BrowserResult;
declare type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
declare type BrowserResult = {
type: 'cancel' | 'dismiss';
};
declare type RedirectResult = {
type: 'success';
url: string;
};
declare type ServiceActionResult = {
servicePackage?: string;
};
declare type MayInitWithUrlResult = ServiceActionResult;
declare type WarmUpResult = ServiceActionResult;
declare type CoolDownResult = ServiceActionResult;
</s> add import { OpenBrowserOptions, AuthSessionResult, CustomTabsBrowsersResults, BrowserResult, MayInitWithUrlResult, WarmUpResult, CoolDownResult } from './WebBrowser.types'; </s> add async openBrowserAsync(
url: string,
browserParams: OpenBrowserOptions = {}
): Promise<BrowserResult> {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> add async openBrowserAsync(url, browserParams = {}) {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> remove browserParams: OpenBrowserParams = {}
</s> add browserParams: OpenBrowserOptions = {} </s> remove type BrowserResult = {
type: 'cancel' | 'dismiss';
};
type RedirectResult = {
type: 'success';
url: string;
};
type ServiceActionResult = {
servicePackage?: string;
};
type MayInitWithUrlResult = ServiceActionResult;
type WarmUpResult = ServiceActionResult;
type CoolDownResult = ServiceActionResult;
</s> add
|
https://github.com/expo/expo/commit/5c4f21408e8fe720c6d47b628431c34f513b8128
|
packages/expo-web-browser/build/ExpoWebBrowser.web.d.ts
|
keep keep keep add keep keep
|
<mask> export default {
<mask> get name() {
<mask> return 'ExpoWebBrowser';
<mask> },
<mask> };
<mask> //# sourceMappingURL=ExpoWebBrowser.web.js.map </s> [web] WebBrowser.openBrowserAsync (#4283)
* Create WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.ts
* Update ExpoWebBrowser.web.ts
* Create WebBrowser.types.js.map
* Create WebBrowser.types.js
* Create WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js
* Update ExpoWebBrowser.web.d.ts
* Update WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.js.map
* Update WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.d.ts
* Update ExpoWebBrowser.web.js.map
* Removed `replace` type
* Update WebBrowser.types.d.ts
* Update WebBrowser.types.js.map
* Removed `replace` prop
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js </s> add async openBrowserAsync(
url: string,
browserParams: OpenBrowserOptions = {}
): Promise<BrowserResult> {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> add openBrowserAsync(url: string, browserParams?: OpenBrowserOptions): Promise<BrowserResult>; </s> remove browserParams: OpenBrowserParams = {}
</s> add browserParams: OpenBrowserOptions = {} </s> remove type BrowserResult = {
type: 'cancel' | 'dismiss';
};
type RedirectResult = {
type: 'success';
url: string;
};
type ServiceActionResult = {
servicePackage?: string;
};
type MayInitWithUrlResult = ServiceActionResult;
type WarmUpResult = ServiceActionResult;
type CoolDownResult = ServiceActionResult;
</s> add </s> remove declare type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
declare type AuthSessionResult = RedirectResult | BrowserResult;
declare type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
declare type BrowserResult = {
type: 'cancel' | 'dismiss';
};
declare type RedirectResult = {
type: 'success';
url: string;
};
declare type ServiceActionResult = {
servicePackage?: string;
};
declare type MayInitWithUrlResult = ServiceActionResult;
declare type WarmUpResult = ServiceActionResult;
declare type CoolDownResult = ServiceActionResult;
</s> add import { OpenBrowserOptions, AuthSessionResult, CustomTabsBrowsersResults, BrowserResult, MayInitWithUrlResult, WarmUpResult, CoolDownResult } from './WebBrowser.types'; </s> remove type RedirectEvent = {
url: string;
};
type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
type AuthSessionResult = RedirectResult | BrowserResult;
type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
</s> add import {
RedirectEvent,
OpenBrowserOptions,
AuthSessionResult,
CustomTabsBrowsersResults,
BrowserResult,
RedirectResult,
ServiceActionResult,
MayInitWithUrlResult,
WarmUpResult,
CoolDownResult,
} from './WebBrowser.types';
|
https://github.com/expo/expo/commit/5c4f21408e8fe720c6d47b628431c34f513b8128
|
packages/expo-web-browser/build/ExpoWebBrowser.web.js
|
replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace keep keep keep keep replace keep keep keep keep
|
<mask> declare type OpenBrowserParams = {
<mask> toolbarColor?: string;
<mask> browserPackage?: string;
<mask> enableBarCollapsing?: boolean;
<mask> showTitle?: boolean;
<mask> };
<mask> declare type AuthSessionResult = RedirectResult | BrowserResult;
<mask> declare type CustomTabsBrowsersResults = {
<mask> defaultBrowserPackage?: string;
<mask> preferredBrowserPackage?: string;
<mask> browserPackages: string[];
<mask> servicePackages: string[];
<mask> };
<mask> declare type BrowserResult = {
<mask> type: 'cancel' | 'dismiss';
<mask> };
<mask> declare type RedirectResult = {
<mask> type: 'success';
<mask> url: string;
<mask> };
<mask> declare type ServiceActionResult = {
<mask> servicePackage?: string;
<mask> };
<mask> declare type MayInitWithUrlResult = ServiceActionResult;
<mask> declare type WarmUpResult = ServiceActionResult;
<mask> declare type CoolDownResult = ServiceActionResult;
<mask> export declare function getCustomTabsSupportingBrowsersAsync(): Promise<CustomTabsBrowsersResults>;
<mask> export declare function warmUpAsync(browserPackage?: string): Promise<WarmUpResult>;
<mask> export declare function mayInitWithUrlAsync(url: string, browserPackage?: string): Promise<MayInitWithUrlResult>;
<mask> export declare function coolDownAsync(browserPackage?: string): Promise<CoolDownResult>;
<mask> export declare function openBrowserAsync(url: string, browserParams?: OpenBrowserParams): Promise<BrowserResult>;
<mask> export declare function dismissBrowser(): void;
<mask> export declare function openAuthSessionAsync(url: string, redirectUrl: string): Promise<AuthSessionResult>;
<mask> export declare function dismissAuthSession(): void;
<mask> export {};
</s> [web] WebBrowser.openBrowserAsync (#4283)
* Create WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.ts
* Update ExpoWebBrowser.web.ts
* Create WebBrowser.types.js.map
* Create WebBrowser.types.js
* Create WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js
* Update ExpoWebBrowser.web.d.ts
* Update WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.js.map
* Update WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.d.ts
* Update ExpoWebBrowser.web.js.map
* Removed `replace` type
* Update WebBrowser.types.d.ts
* Update WebBrowser.types.js.map
* Removed `replace` prop
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js </s> remove type BrowserResult = {
type: 'cancel' | 'dismiss';
};
type RedirectResult = {
type: 'success';
url: string;
};
type ServiceActionResult = {
servicePackage?: string;
};
type MayInitWithUrlResult = ServiceActionResult;
type WarmUpResult = ServiceActionResult;
type CoolDownResult = ServiceActionResult;
</s> add </s> remove type RedirectEvent = {
url: string;
};
type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
type AuthSessionResult = RedirectResult | BrowserResult;
type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
</s> add import {
RedirectEvent,
OpenBrowserOptions,
AuthSessionResult,
CustomTabsBrowsersResults,
BrowserResult,
RedirectResult,
ServiceActionResult,
MayInitWithUrlResult,
WarmUpResult,
CoolDownResult,
} from './WebBrowser.types'; </s> remove export {};
</s> add </s> add openBrowserAsync(url: string, browserParams?: OpenBrowserOptions): Promise<BrowserResult>; </s> remove browserParams: OpenBrowserParams = {}
</s> add browserParams: OpenBrowserOptions = {}
|
https://github.com/expo/expo/commit/5c4f21408e8fe720c6d47b628431c34f513b8128
|
packages/expo-web-browser/build/WebBrowser.d.ts
|
keep keep keep keep replace
|
<mask> export declare function openBrowserAsync(url: string, browserParams?: OpenBrowserParams): Promise<BrowserResult>;
<mask> export declare function dismissBrowser(): void;
<mask> export declare function openAuthSessionAsync(url: string, redirectUrl: string): Promise<AuthSessionResult>;
<mask> export declare function dismissAuthSession(): void;
<mask> export {};
</s> [web] WebBrowser.openBrowserAsync (#4283)
* Create WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.ts
* Update ExpoWebBrowser.web.ts
* Create WebBrowser.types.js.map
* Create WebBrowser.types.js
* Create WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js
* Update ExpoWebBrowser.web.d.ts
* Update WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.js.map
* Update WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.d.ts
* Update ExpoWebBrowser.web.js.map
* Removed `replace` type
* Update WebBrowser.types.d.ts
* Update WebBrowser.types.js.map
* Removed `replace` prop
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js </s> remove export declare function openBrowserAsync(url: string, browserParams?: OpenBrowserParams): Promise<BrowserResult>;
</s> add export declare function openBrowserAsync(url: string, browserParams?: OpenBrowserOptions): Promise<BrowserResult>; </s> remove declare type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
declare type AuthSessionResult = RedirectResult | BrowserResult;
declare type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
declare type BrowserResult = {
type: 'cancel' | 'dismiss';
};
declare type RedirectResult = {
type: 'success';
url: string;
};
declare type ServiceActionResult = {
servicePackage?: string;
};
declare type MayInitWithUrlResult = ServiceActionResult;
declare type WarmUpResult = ServiceActionResult;
declare type CoolDownResult = ServiceActionResult;
</s> add import { OpenBrowserOptions, AuthSessionResult, CustomTabsBrowsersResults, BrowserResult, MayInitWithUrlResult, WarmUpResult, CoolDownResult } from './WebBrowser.types'; </s> add openBrowserAsync(url: string, browserParams?: OpenBrowserOptions): Promise<BrowserResult>; </s> remove browserParams: OpenBrowserParams = {}
</s> add browserParams: OpenBrowserOptions = {} </s> remove type BrowserResult = {
type: 'cancel' | 'dismiss';
};
type RedirectResult = {
type: 'success';
url: string;
};
type ServiceActionResult = {
servicePackage?: string;
};
type MayInitWithUrlResult = ServiceActionResult;
type WarmUpResult = ServiceActionResult;
type CoolDownResult = ServiceActionResult;
</s> add </s> add async openBrowserAsync(
url: string,
browserParams: OpenBrowserOptions = {}
): Promise<BrowserResult> {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
},
|
https://github.com/expo/expo/commit/5c4f21408e8fe720c6d47b628431c34f513b8128
|
packages/expo-web-browser/build/WebBrowser.d.ts
|
keep keep keep add keep
|
<mask> export default {
<mask> get name() {
<mask> return 'ExpoWebBrowser';
<mask> },
<mask> };
</s> [web] WebBrowser.openBrowserAsync (#4283)
* Create WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.ts
* Update ExpoWebBrowser.web.ts
* Create WebBrowser.types.js.map
* Create WebBrowser.types.js
* Create WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js
* Update ExpoWebBrowser.web.d.ts
* Update WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.js.map
* Update WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.d.ts
* Update ExpoWebBrowser.web.js.map
* Removed `replace` type
* Update WebBrowser.types.d.ts
* Update WebBrowser.types.js.map
* Removed `replace` prop
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js </s> add async openBrowserAsync(url, browserParams = {}) {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> add openBrowserAsync(url: string, browserParams?: OpenBrowserOptions): Promise<BrowserResult>; </s> remove browserParams: OpenBrowserParams = {}
</s> add browserParams: OpenBrowserOptions = {} </s> remove type BrowserResult = {
type: 'cancel' | 'dismiss';
};
type RedirectResult = {
type: 'success';
url: string;
};
type ServiceActionResult = {
servicePackage?: string;
};
type MayInitWithUrlResult = ServiceActionResult;
type WarmUpResult = ServiceActionResult;
type CoolDownResult = ServiceActionResult;
</s> add </s> remove declare type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
declare type AuthSessionResult = RedirectResult | BrowserResult;
declare type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
declare type BrowserResult = {
type: 'cancel' | 'dismiss';
};
declare type RedirectResult = {
type: 'success';
url: string;
};
declare type ServiceActionResult = {
servicePackage?: string;
};
declare type MayInitWithUrlResult = ServiceActionResult;
declare type WarmUpResult = ServiceActionResult;
declare type CoolDownResult = ServiceActionResult;
</s> add import { OpenBrowserOptions, AuthSessionResult, CustomTabsBrowsersResults, BrowserResult, MayInitWithUrlResult, WarmUpResult, CoolDownResult } from './WebBrowser.types'; </s> remove type RedirectEvent = {
url: string;
};
type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
type AuthSessionResult = RedirectResult | BrowserResult;
type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
</s> add import {
RedirectEvent,
OpenBrowserOptions,
AuthSessionResult,
CustomTabsBrowsersResults,
BrowserResult,
RedirectResult,
ServiceActionResult,
MayInitWithUrlResult,
WarmUpResult,
CoolDownResult,
} from './WebBrowser.types';
|
https://github.com/expo/expo/commit/5c4f21408e8fe720c6d47b628431c34f513b8128
|
packages/expo-web-browser/src/ExpoWebBrowser.web.ts
|
keep keep keep keep replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace keep keep keep keep keep
|
<mask> import { Linking, Platform } from 'react-native';
<mask> import { UnavailabilityError } from '@unimodules/core';
<mask> import ExponentWebBrowser from './ExpoWebBrowser';
<mask>
<mask> type RedirectEvent = {
<mask> url: string;
<mask> };
<mask>
<mask> type OpenBrowserParams = {
<mask> toolbarColor?: string;
<mask> browserPackage?: string;
<mask> enableBarCollapsing?: boolean;
<mask> showTitle?: boolean;
<mask> };
<mask>
<mask> type AuthSessionResult = RedirectResult | BrowserResult;
<mask>
<mask> type CustomTabsBrowsersResults = {
<mask> defaultBrowserPackage?: string;
<mask> preferredBrowserPackage?: string;
<mask> browserPackages: string[];
<mask> servicePackages: string[];
<mask> };
<mask>
<mask> const emptyCustomTabsPackages: CustomTabsBrowsersResults = {
<mask> defaultBrowserPackage: undefined,
<mask> preferredBrowserPackage: undefined,
<mask> browserPackages: [],
</s> [web] WebBrowser.openBrowserAsync (#4283)
* Create WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.ts
* Update ExpoWebBrowser.web.ts
* Create WebBrowser.types.js.map
* Create WebBrowser.types.js
* Create WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js
* Update ExpoWebBrowser.web.d.ts
* Update WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.js.map
* Update WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.d.ts
* Update ExpoWebBrowser.web.js.map
* Removed `replace` type
* Update WebBrowser.types.d.ts
* Update WebBrowser.types.js.map
* Removed `replace` prop
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js </s> remove declare type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
declare type AuthSessionResult = RedirectResult | BrowserResult;
declare type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
declare type BrowserResult = {
type: 'cancel' | 'dismiss';
};
declare type RedirectResult = {
type: 'success';
url: string;
};
declare type ServiceActionResult = {
servicePackage?: string;
};
declare type MayInitWithUrlResult = ServiceActionResult;
declare type WarmUpResult = ServiceActionResult;
declare type CoolDownResult = ServiceActionResult;
</s> add import { OpenBrowserOptions, AuthSessionResult, CustomTabsBrowsersResults, BrowserResult, MayInitWithUrlResult, WarmUpResult, CoolDownResult } from './WebBrowser.types'; </s> remove type BrowserResult = {
type: 'cancel' | 'dismiss';
};
type RedirectResult = {
type: 'success';
url: string;
};
type ServiceActionResult = {
servicePackage?: string;
};
type MayInitWithUrlResult = ServiceActionResult;
type WarmUpResult = ServiceActionResult;
type CoolDownResult = ServiceActionResult;
</s> add </s> add openBrowserAsync(url: string, browserParams?: OpenBrowserOptions): Promise<BrowserResult>; </s> add async openBrowserAsync(
url: string,
browserParams: OpenBrowserOptions = {}
): Promise<BrowserResult> {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> add async openBrowserAsync(url, browserParams = {}) {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> remove browserParams: OpenBrowserParams = {}
</s> add browserParams: OpenBrowserOptions = {}
|
https://github.com/expo/expo/commit/5c4f21408e8fe720c6d47b628431c34f513b8128
|
packages/expo-web-browser/src/WebBrowser.ts
|
keep keep keep keep replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace replace keep keep keep keep keep
|
<mask> browserPackages: [],
<mask> servicePackages: [],
<mask> };
<mask>
<mask> type BrowserResult = {
<mask> type: 'cancel' | 'dismiss';
<mask> };
<mask>
<mask> type RedirectResult = {
<mask> type: 'success';
<mask> url: string;
<mask> };
<mask>
<mask> type ServiceActionResult = {
<mask> servicePackage?: string;
<mask> };
<mask>
<mask> type MayInitWithUrlResult = ServiceActionResult;
<mask> type WarmUpResult = ServiceActionResult;
<mask> type CoolDownResult = ServiceActionResult;
<mask>
<mask> export async function getCustomTabsSupportingBrowsersAsync(): Promise<CustomTabsBrowsersResults> {
<mask> if (!ExponentWebBrowser.getCustomTabsSupportingBrowsersAsync) {
<mask> throw new UnavailabilityError('WebBrowser', 'getCustomTabsSupportingBrowsersAsync');
<mask> }
<mask> if (Platform.OS !== 'android') {
</s> [web] WebBrowser.openBrowserAsync (#4283)
* Create WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.ts
* Update ExpoWebBrowser.web.ts
* Create WebBrowser.types.js.map
* Create WebBrowser.types.js
* Create WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js
* Update ExpoWebBrowser.web.d.ts
* Update WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.js.map
* Update WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.d.ts
* Update ExpoWebBrowser.web.js.map
* Removed `replace` type
* Update WebBrowser.types.d.ts
* Update WebBrowser.types.js.map
* Removed `replace` prop
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js </s> remove declare type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
declare type AuthSessionResult = RedirectResult | BrowserResult;
declare type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
declare type BrowserResult = {
type: 'cancel' | 'dismiss';
};
declare type RedirectResult = {
type: 'success';
url: string;
};
declare type ServiceActionResult = {
servicePackage?: string;
};
declare type MayInitWithUrlResult = ServiceActionResult;
declare type WarmUpResult = ServiceActionResult;
declare type CoolDownResult = ServiceActionResult;
</s> add import { OpenBrowserOptions, AuthSessionResult, CustomTabsBrowsersResults, BrowserResult, MayInitWithUrlResult, WarmUpResult, CoolDownResult } from './WebBrowser.types'; </s> remove type RedirectEvent = {
url: string;
};
type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
type AuthSessionResult = RedirectResult | BrowserResult;
type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
</s> add import {
RedirectEvent,
OpenBrowserOptions,
AuthSessionResult,
CustomTabsBrowsersResults,
BrowserResult,
RedirectResult,
ServiceActionResult,
MayInitWithUrlResult,
WarmUpResult,
CoolDownResult,
} from './WebBrowser.types'; </s> remove browserParams: OpenBrowserParams = {}
</s> add browserParams: OpenBrowserOptions = {} </s> add async openBrowserAsync(
url: string,
browserParams: OpenBrowserOptions = {}
): Promise<BrowserResult> {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> add async openBrowserAsync(url, browserParams = {}) {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> add openBrowserAsync(url: string, browserParams?: OpenBrowserOptions): Promise<BrowserResult>;
|
https://github.com/expo/expo/commit/5c4f21408e8fe720c6d47b628431c34f513b8128
|
packages/expo-web-browser/src/WebBrowser.ts
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> }
<mask>
<mask> export async function openBrowserAsync(
<mask> url: string,
<mask> browserParams: OpenBrowserParams = {}
<mask> ): Promise<BrowserResult> {
<mask> if (!ExponentWebBrowser.openBrowserAsync) {
<mask> throw new UnavailabilityError('WebBrowser', 'openBrowserAsync');
<mask> }
<mask> return await ExponentWebBrowser.openBrowserAsync(url, browserParams);
</s> [web] WebBrowser.openBrowserAsync (#4283)
* Create WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.ts
* Update ExpoWebBrowser.web.ts
* Create WebBrowser.types.js.map
* Create WebBrowser.types.js
* Create WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js
* Update ExpoWebBrowser.web.d.ts
* Update WebBrowser.types.ts
* Update WebBrowser.ts
* Update ExpoWebBrowser.web.ts
* Update WebBrowser.types.js.map
* Update WebBrowser.types.d.ts
* Update WebBrowser.js.map
* Update WebBrowser.d.ts
* Update ExpoWebBrowser.web.d.ts
* Update ExpoWebBrowser.web.js.map
* Removed `replace` type
* Update WebBrowser.types.d.ts
* Update WebBrowser.types.js.map
* Removed `replace` prop
* Update ExpoWebBrowser.web.js.map
* Update ExpoWebBrowser.web.js </s> add async openBrowserAsync(
url: string,
browserParams: OpenBrowserOptions = {}
): Promise<BrowserResult> {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> remove type BrowserResult = {
type: 'cancel' | 'dismiss';
};
type RedirectResult = {
type: 'success';
url: string;
};
type ServiceActionResult = {
servicePackage?: string;
};
type MayInitWithUrlResult = ServiceActionResult;
type WarmUpResult = ServiceActionResult;
type CoolDownResult = ServiceActionResult;
</s> add </s> add async openBrowserAsync(url, browserParams = {}) {
const { windowName = '_blank', windowFeatures } = browserParams;
window.open(url, windowName, windowFeatures);
return { type: 'dismiss' };
}, </s> remove declare type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
declare type AuthSessionResult = RedirectResult | BrowserResult;
declare type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
declare type BrowserResult = {
type: 'cancel' | 'dismiss';
};
declare type RedirectResult = {
type: 'success';
url: string;
};
declare type ServiceActionResult = {
servicePackage?: string;
};
declare type MayInitWithUrlResult = ServiceActionResult;
declare type WarmUpResult = ServiceActionResult;
declare type CoolDownResult = ServiceActionResult;
</s> add import { OpenBrowserOptions, AuthSessionResult, CustomTabsBrowsersResults, BrowserResult, MayInitWithUrlResult, WarmUpResult, CoolDownResult } from './WebBrowser.types'; </s> remove type RedirectEvent = {
url: string;
};
type OpenBrowserParams = {
toolbarColor?: string;
browserPackage?: string;
enableBarCollapsing?: boolean;
showTitle?: boolean;
};
type AuthSessionResult = RedirectResult | BrowserResult;
type CustomTabsBrowsersResults = {
defaultBrowserPackage?: string;
preferredBrowserPackage?: string;
browserPackages: string[];
servicePackages: string[];
};
</s> add import {
RedirectEvent,
OpenBrowserOptions,
AuthSessionResult,
CustomTabsBrowsersResults,
BrowserResult,
RedirectResult,
ServiceActionResult,
MayInitWithUrlResult,
WarmUpResult,
CoolDownResult,
} from './WebBrowser.types'; </s> add openBrowserAsync(url: string, browserParams?: OpenBrowserOptions): Promise<BrowserResult>;
|
https://github.com/expo/expo/commit/5c4f21408e8fe720c6d47b628431c34f513b8128
|
packages/expo-web-browser/src/WebBrowser.ts
|
keep keep replace keep keep keep replace keep keep keep
|
<mask> import { NotificationFeedbackType, ImpactFeedbackStyle } from './Haptics.types';
<mask> /**
<mask> * Triggers notification feedback.
<mask> */
<mask> export declare function notificationAsync(type?: NotificationFeedbackType): Promise<void>;
<mask> /**
<mask> * Triggers impact feedback.
<mask> */
<mask> export declare function impactAsync(style?: ImpactFeedbackStyle): Promise<void>;
<mask> /**
</s> [haptics] add doc comments in source (#13288) </s> remove * Triggers selection feedback.
</s> add * Used to let a user know when a selection change has been registered.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> add // @needsAudit </s> add // @needsAudit
|
https://github.com/expo/expo/commit/5df607a0a146e1131e49c6721a9955d7887db2ce
|
packages/expo-haptics/build/Haptics.d.ts
|
keep keep keep keep replace keep keep keep
|
<mask> * Triggers impact feedback.
<mask> */
<mask> export declare function impactAsync(style?: ImpactFeedbackStyle): Promise<void>;
<mask> /**
<mask> * Triggers selection feedback.
<mask> */
<mask> export declare function selectionAsync(): Promise<void>;
<mask> export { NotificationFeedbackType, ImpactFeedbackStyle };
</s> [haptics] add doc comments in source (#13288) </s> remove * Triggers impact feedback.
</s> add * @param style A collision indicator that on iOS is directly mapped to [`UIImpactFeedbackStyle`](https://developer.apple.com/documentation/uikit/uiimpactfeedbackstyle),
* while on Android these are simulated using [Vibrator](vibrator). You can use one of `Haptics.ImpactFeedbackStyle.{Light, Medium, Heavy}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers selection feedback.
</s> add * Used to let a user know when a selection change has been registered.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers selection feedback.
</s> add * Used to let a user know when a selection change has been registered.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers impact feedback.
</s> add * @param style A collision indicator that on iOS is directly mapped to [`UIImpactFeedbackStyle`](https://developer.apple.com/documentation/uikit/uiimpactfeedbackstyle),
* while on Android these are simulated using [Vibrator](vibrator). You can use one of `Haptics.ImpactFeedbackStyle.{Light, Medium, Heavy}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered.
|
https://github.com/expo/expo/commit/5df607a0a146e1131e49c6721a9955d7887db2ce
|
packages/expo-haptics/build/Haptics.d.ts
|
keep add keep keep keep keep
|
<mask> import ExpoHaptics from './ExpoHaptics';
<mask> import { NotificationFeedbackType, ImpactFeedbackStyle } from './Haptics.types';
<mask> /**
<mask> * The kind of notification response used in the feedback.
<mask> * @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
<mask> * while on Android these are simulated using [Vibrator](vibrator).
</s> [haptics] add doc comments in source (#13288) </s> add // @needsAudit </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers impact feedback.
</s> add * @param style A collision indicator that on iOS is directly mapped to [`UIImpactFeedbackStyle`](https://developer.apple.com/documentation/uikit/uiimpactfeedbackstyle),
* while on Android these are simulated using [Vibrator](vibrator). You can use one of `Haptics.ImpactFeedbackStyle.{Light, Medium, Heavy}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> add // @needsAudit
|
https://github.com/expo/expo/commit/5df607a0a146e1131e49c6721a9955d7887db2ce
|
packages/expo-haptics/build/Haptics.js
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> import { UnavailabilityError } from '@unimodules/core';
<mask> import ExpoHaptics from './ExpoHaptics';
<mask> import { NotificationFeedbackType, ImpactFeedbackStyle } from './Haptics.types';
<mask> /**
<mask> * Triggers notification feedback.
<mask> */
<mask> export async function notificationAsync(type = NotificationFeedbackType.Success) {
<mask> if (!ExpoHaptics.notificationAsync) {
<mask> throw new UnavailabilityError('Haptics', 'notificationAsync');
<mask> }
</s> [haptics] add doc comments in source (#13288) </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> add // @needsAudit </s> add // @needsAudit </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers selection feedback.
</s> add * Used to let a user know when a selection change has been registered.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers selection feedback.
</s> add * Used to let a user know when a selection change has been registered.
* @return A `Promise` which fulfils once native size haptics functionality is triggered.
|
https://github.com/expo/expo/commit/5df607a0a146e1131e49c6721a9955d7887db2ce
|
packages/expo-haptics/build/Haptics.js
|
keep add keep keep keep keep keep keep
|
<mask> await ExpoHaptics.notificationAsync(type);
<mask> }
<mask> /**
<mask> * @param style A collision indicator that on iOS is directly mapped to [`UIImpactFeedbackStyle`](https://developer.apple.com/documentation/uikit/uiimpactfeedbackstyle),
<mask> * while on Android these are simulated using [Vibrator](vibrator). You can use one of `Haptics.ImpactFeedbackStyle.{Light, Medium, Heavy}`.
<mask> * @return A `Promise` which fulfils once native size haptics functionality is triggered.
<mask> */
<mask> export async function impactAsync(style = ImpactFeedbackStyle.Medium) {
</s> [haptics] add doc comments in source (#13288) </s> remove * Triggers impact feedback.
</s> add * @param style A collision indicator that on iOS is directly mapped to [`UIImpactFeedbackStyle`](https://developer.apple.com/documentation/uikit/uiimpactfeedbackstyle),
* while on Android these are simulated using [Vibrator](vibrator). You can use one of `Haptics.ImpactFeedbackStyle.{Light, Medium, Heavy}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> add // @needsAudit </s> remove * Triggers impact feedback.
</s> add * @param style A collision indicator that on iOS is directly mapped to [`UIImpactFeedbackStyle`](https://developer.apple.com/documentation/uikit/uiimpactfeedbackstyle),
* while on Android these are simulated using [Vibrator](vibrator). You can use one of `Haptics.ImpactFeedbackStyle.{Light, Medium, Heavy}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers impact feedback.
</s> add * @param style A collision indicator that on iOS is directly mapped to [`UIImpactFeedbackStyle`](https://developer.apple.com/documentation/uikit/uiimpactfeedbackstyle),
* while on Android these are simulated using [Vibrator](vibrator). You can use one of `Haptics.ImpactFeedbackStyle.{Light, Medium, Heavy}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered.
|
https://github.com/expo/expo/commit/5df607a0a146e1131e49c6721a9955d7887db2ce
|
packages/expo-haptics/build/Haptics.js
|
keep keep keep keep replace keep keep keep keep keep
|
<mask> }
<mask> await ExpoHaptics.notificationAsync(type);
<mask> }
<mask> /**
<mask> * Triggers impact feedback.
<mask> */
<mask> export async function impactAsync(style = ImpactFeedbackStyle.Medium) {
<mask> if (!ExpoHaptics.impactAsync) {
<mask> throw new UnavailabilityError('Haptic', 'impactAsync');
<mask> }
</s> [haptics] add doc comments in source (#13288) </s> remove * Triggers selection feedback.
</s> add * Used to let a user know when a selection change has been registered.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers selection feedback.
</s> add * Used to let a user know when a selection change has been registered.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers impact feedback.
</s> add * @param style A collision indicator that on iOS is directly mapped to [`UIImpactFeedbackStyle`](https://developer.apple.com/documentation/uikit/uiimpactfeedbackstyle),
* while on Android these are simulated using [Vibrator](vibrator). You can use one of `Haptics.ImpactFeedbackStyle.{Light, Medium, Heavy}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> add // @needsAudit </s> remove * Triggers notification feedback.
</s> add * The kind of notification response used in the feedback.
* @param type A notification feedback type that on iOS is directly mapped to [UINotificationFeedbackType](https://developer.apple.com/documentation/uikit/uinotificationfeedbacktype),
* while on Android these are simulated using [Vibrator](vibrator).
* You can use one of `Haptics.NotificationFeedbackType.{Success, Warning, Error}`.
* @return A `Promise` which fulfils once native size haptics functionality is triggered. </s> remove * Triggers selection feedback.
</s> add * Used to let a user know when a selection change has been registered.
* @return A `Promise` which fulfils once native size haptics functionality is triggered.
|
https://github.com/expo/expo/commit/5df607a0a146e1131e49c6721a9955d7887db2ce
|
packages/expo-haptics/build/Haptics.js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.