url
stringlengths
63
64
repository_url
stringclasses
1 value
labels_url
stringlengths
77
78
comments_url
stringlengths
72
73
events_url
stringlengths
70
71
html_url
stringlengths
51
54
id
int64
1.73B
2.09B
node_id
stringlengths
18
19
number
int64
5.23k
16.2k
title
stringlengths
1
385
user
dict
labels
list
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
list
milestone
null
comments
int64
0
56
created_at
timestamp[s]
updated_at
timestamp[s]
closed_at
timestamp[s]
author_association
stringclasses
3 values
active_lock_reason
null
body
stringlengths
1
55.4k
reactions
dict
timeline_url
stringlengths
72
73
performed_via_github_app
null
state_reason
stringclasses
3 values
draft
bool
2 classes
pull_request
dict
https://api.github.com/repos/langchain-ai/langchain/issues/5664
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5664/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5664/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5664/events
https://github.com/langchain-ai/langchain/pull/5664
1,739,929,394
PR_kwDOIPDwls5SGMGq
5,664
Harrison/pubmed integration
{ "login": "hwchase17", "id": 11986836, "node_id": "MDQ6VXNlcjExOTg2ODM2", "avatar_url": "https://avatars.githubusercontent.com/u/11986836?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hwchase17", "html_url": "https://github.com/hwchase17", "followers_url": "https://api.github.com/users/hwchase17/followers", "following_url": "https://api.github.com/users/hwchase17/following{/other_user}", "gists_url": "https://api.github.com/users/hwchase17/gists{/gist_id}", "starred_url": "https://api.github.com/users/hwchase17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hwchase17/subscriptions", "organizations_url": "https://api.github.com/users/hwchase17/orgs", "repos_url": "https://api.github.com/users/hwchase17/repos", "events_url": "https://api.github.com/users/hwchase17/events{/privacy}", "received_events_url": "https://api.github.com/users/hwchase17/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-03T21:34:23
2023-06-03T23:25:30
2023-06-03T23:25:29
COLLABORATOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5664/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5664/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5664", "html_url": "https://github.com/langchain-ai/langchain/pull/5664", "diff_url": "https://github.com/langchain-ai/langchain/pull/5664.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5664.patch", "merged_at": "2023-06-03T23:25:29" }
https://api.github.com/repos/langchain-ai/langchain/issues/5661
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5661/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5661/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5661/events
https://github.com/langchain-ai/langchain/pull/5661
1,739,751,232
PR_kwDOIPDwls5SFjFs
5,661
Add aviary support
{ "login": "waleedkadous", "id": 2716496, "node_id": "MDQ6VXNlcjI3MTY0OTY=", "avatar_url": "https://avatars.githubusercontent.com/u/2716496?v=4", "gravatar_id": "", "url": "https://api.github.com/users/waleedkadous", "html_url": "https://github.com/waleedkadous", "followers_url": "https://api.github.com/users/waleedkadous/followers", "following_url": "https://api.github.com/users/waleedkadous/following{/other_user}", "gists_url": "https://api.github.com/users/waleedkadous/gists{/gist_id}", "starred_url": "https://api.github.com/users/waleedkadous/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/waleedkadous/subscriptions", "organizations_url": "https://api.github.com/users/waleedkadous/orgs", "repos_url": "https://api.github.com/users/waleedkadous/repos", "events_url": "https://api.github.com/users/waleedkadous/events{/privacy}", "received_events_url": "https://api.github.com/users/waleedkadous/received_events", "type": "User", "site_admin": false }
[ { "id": 4678528817, "node_id": "LA_kwDOIPDwls8AAAABFtyvMQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" }, { "id": 4899415699, "node_id": "LA_kwDOIPDwls8AAAABJAcmkw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/llms", "name": "llms", "color": "7CDBB2", "default": false, "description": "" } ]
closed
false
null
[]
null
1
2023-06-03T18:20:14
2023-06-05T23:28:43
2023-06-05T23:28:42
CONTRIBUTOR
null
Aviary is an open source toolkit for evaluating and deploying open source LLMs. You can find out more about it on [http://github.com/ray-project/aviary). You can try it out at [http://aviary.anyscale.com](aviary.anyscale.com). This code adds support for Aviary in LangChain. To minimize dependencies, it connects directly to the HTTP endpoint. The current implementation is not accelerated and uses the default implementation of `predict` and `generate`. It includes a test and a simple example. @hwchase17 and @agola11 could you have a look at this?
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5661/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5661/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5661", "html_url": "https://github.com/langchain-ai/langchain/pull/5661", "diff_url": "https://github.com/langchain-ai/langchain/pull/5661.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5661.patch", "merged_at": "2023-06-05T23:28:42" }
https://api.github.com/repos/langchain-ai/langchain/issues/5660
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5660/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5660/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5660/events
https://github.com/langchain-ai/langchain/issues/5660
1,739,715,128
I_kwDOIPDwls5nsfI4
5,660
Support for Hugging Face Question Answering Models
{ "login": "Veluchs", "id": 135350576, "node_id": "U_kgDOCBFJMA", "avatar_url": "https://avatars.githubusercontent.com/u/135350576?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Veluchs", "html_url": "https://github.com/Veluchs", "followers_url": "https://api.github.com/users/Veluchs/followers", "following_url": "https://api.github.com/users/Veluchs/following{/other_user}", "gists_url": "https://api.github.com/users/Veluchs/gists{/gist_id}", "starred_url": "https://api.github.com/users/Veluchs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Veluchs/subscriptions", "organizations_url": "https://api.github.com/users/Veluchs/orgs", "repos_url": "https://api.github.com/users/Veluchs/repos", "events_url": "https://api.github.com/users/Veluchs/events{/privacy}", "received_events_url": "https://api.github.com/users/Veluchs/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-03T17:54:22
2023-09-10T16:08:08
2023-09-10T16:08:07
NONE
null
### Feature request Support for Hugging Face's Question Answering Models would be great. ### Motivation It would allow for the construction of extractive Question Answering Pipelines, making use of the vast amount of open Q&A Models on Hugging Face. ### Your contribution I would be happy to tackle the implementation and submitt a PR. Have you thought about integrating this already? If so, I'm open for a discussion on the best way to to this. (New Class vs extending 'HuggingFacePipeline').
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5660/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5660/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5659
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5659/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5659/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5659/events
https://github.com/langchain-ai/langchain/pull/5659
1,739,669,511
PR_kwDOIPDwls5SFQcg
5,659
Created fix for 5475
{ "login": "rajib76", "id": 16340036, "node_id": "MDQ6VXNlcjE2MzQwMDM2", "avatar_url": "https://avatars.githubusercontent.com/u/16340036?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rajib76", "html_url": "https://github.com/rajib76", "followers_url": "https://api.github.com/users/rajib76/followers", "following_url": "https://api.github.com/users/rajib76/following{/other_user}", "gists_url": "https://api.github.com/users/rajib76/gists{/gist_id}", "starred_url": "https://api.github.com/users/rajib76/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rajib76/subscriptions", "organizations_url": "https://api.github.com/users/rajib76/orgs", "repos_url": "https://api.github.com/users/rajib76/repos", "events_url": "https://api.github.com/users/rajib76/events{/privacy}", "received_events_url": "https://api.github.com/users/rajib76/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-03T16:41:59
2023-06-03T23:47:53
2023-06-03T23:47:53
CONTRIBUTOR
null
Created fix for 5475 Currently in PGvector, we do not have any function that returns the instance of an existing store. The from_documents always adds embeddings and then returns the store. This fix is to add a function that will return the instance of an existing store Also changed the jupyter example for PGVector to show the example of using the function <!-- Remove if not applicable --> Fixes # 5475 #### Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> #### Who can review? @dev2049 @hwchase17 Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5659/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5659/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5659", "html_url": "https://github.com/langchain-ai/langchain/pull/5659", "diff_url": "https://github.com/langchain-ai/langchain/pull/5659.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5659.patch", "merged_at": "2023-06-03T23:47:52" }
https://api.github.com/repos/langchain-ai/langchain/issues/5658
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5658/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5658/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5658/events
https://github.com/langchain-ai/langchain/issues/5658
1,739,633,584
I_kwDOIPDwls5nsLOw
5,658
DOC: Annotation error in the CAMELAgent helper class
{ "login": "shvjds", "id": 7003969, "node_id": "MDQ6VXNlcjcwMDM5Njk=", "avatar_url": "https://avatars.githubusercontent.com/u/7003969?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shvjds", "html_url": "https://github.com/shvjds", "followers_url": "https://api.github.com/users/shvjds/followers", "following_url": "https://api.github.com/users/shvjds/following{/other_user}", "gists_url": "https://api.github.com/users/shvjds/gists{/gist_id}", "starred_url": "https://api.github.com/users/shvjds/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shvjds/subscriptions", "organizations_url": "https://api.github.com/users/shvjds/orgs", "repos_url": "https://api.github.com/users/shvjds/repos", "events_url": "https://api.github.com/users/shvjds/events{/privacy}", "received_events_url": "https://api.github.com/users/shvjds/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-03T15:44:03
2023-09-10T16:08:13
2023-09-10T16:08:12
NONE
null
### Issue with current documentation: **Severity:** Minor **Where:** Use Cases -> Agent Simulations -> Simulations with two agents -> CAMEL Direct link: [CAMEL Role-Playing Autonomous Cooperative Agents](https://python.langchain.com/en/latest/use_cases/agent_simulations/camel_role_playing.html) **What:** In the code of the CAMELAgent, the reset_method has the wrong type annotation. Should be: ```python def reset(self) -> List[BaseMessage]: self.init_messages() return self.stored_messages ``` ### Idea or request for content: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5658/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5658/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5657
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5657/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5657/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5657/events
https://github.com/langchain-ai/langchain/pull/5657
1,739,618,330
PR_kwDOIPDwls5SFFPd
5,657
This fixes issue #5651 - GPT4All wrapper loading issue
{ "login": "bwv988", "id": 2035075, "node_id": "MDQ6VXNlcjIwMzUwNzU=", "avatar_url": "https://avatars.githubusercontent.com/u/2035075?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bwv988", "html_url": "https://github.com/bwv988", "followers_url": "https://api.github.com/users/bwv988/followers", "following_url": "https://api.github.com/users/bwv988/following{/other_user}", "gists_url": "https://api.github.com/users/bwv988/gists{/gist_id}", "starred_url": "https://api.github.com/users/bwv988/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bwv988/subscriptions", "organizations_url": "https://api.github.com/users/bwv988/orgs", "repos_url": "https://api.github.com/users/bwv988/repos", "events_url": "https://api.github.com/users/bwv988/events{/privacy}", "received_events_url": "https://api.github.com/users/bwv988/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-03T15:20:57
2023-06-04T14:21:17
2023-06-04T14:21:17
CONTRIBUTOR
null
Fixes #5651 Small typo in wrapper code. Note the `model_type` parameter is currently unused by GPT4All. https://github.com/hwchase17/langchain/issues/5651 #### Who can review?
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5657/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5657/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5657", "html_url": "https://github.com/langchain-ai/langchain/pull/5657", "diff_url": "https://github.com/langchain-ai/langchain/pull/5657.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5657.patch", "merged_at": "2023-06-04T14:21:17" }
https://api.github.com/repos/langchain-ai/langchain/issues/5656
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5656/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5656/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5656/events
https://github.com/langchain-ai/langchain/issues/5656
1,739,566,153
I_kwDOIPDwls5nr6xJ
5,656
Issue: When using agent_chain.run to query documents, I want to return both the LLM answer and Source documents, however agent_chain.run only allows for exactly 1 output
{ "login": "ShinySylveonn", "id": 131572339, "node_id": "U_kgDOB9eicw", "avatar_url": "https://avatars.githubusercontent.com/u/131572339?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ShinySylveonn", "html_url": "https://github.com/ShinySylveonn", "followers_url": "https://api.github.com/users/ShinySylveonn/followers", "following_url": "https://api.github.com/users/ShinySylveonn/following{/other_user}", "gists_url": "https://api.github.com/users/ShinySylveonn/gists{/gist_id}", "starred_url": "https://api.github.com/users/ShinySylveonn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ShinySylveonn/subscriptions", "organizations_url": "https://api.github.com/users/ShinySylveonn/orgs", "repos_url": "https://api.github.com/users/ShinySylveonn/repos", "events_url": "https://api.github.com/users/ShinySylveonn/events{/privacy}", "received_events_url": "https://api.github.com/users/ShinySylveonn/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
4
2023-06-03T13:58:57
2023-09-25T16:06:26
2023-09-25T16:06:25
NONE
null
### Issue you'd like to raise. agent_chain.run does not allow for more than a single output, when calling RetrievalQA.from_chain_type directly with the same query it has no issues returning multiple outputs, however agent_chain is where all of my custom tools and configurations are. agent_chain.run in my code at the moment refers to AgentExecutor.from_agents_and_tools Is there a current workaround for this or is there a strong reason why .run can only support a single output? ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5656/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5656/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5655
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5655/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5655/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5655/events
https://github.com/langchain-ai/langchain/pull/5655
1,739,559,797
PR_kwDOIPDwls5SE4XZ
5,655
Support similarity_score_threshold retrieval with Chroma
{ "login": "jiayao", "id": 74058, "node_id": "MDQ6VXNlcjc0MDU4", "avatar_url": "https://avatars.githubusercontent.com/u/74058?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jiayao", "html_url": "https://github.com/jiayao", "followers_url": "https://api.github.com/users/jiayao/followers", "following_url": "https://api.github.com/users/jiayao/following{/other_user}", "gists_url": "https://api.github.com/users/jiayao/gists{/gist_id}", "starred_url": "https://api.github.com/users/jiayao/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jiayao/subscriptions", "organizations_url": "https://api.github.com/users/jiayao/orgs", "repos_url": "https://api.github.com/users/jiayao/repos", "events_url": "https://api.github.com/users/jiayao/events{/privacy}", "received_events_url": "https://api.github.com/users/jiayao/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
1
2023-06-03T13:51:54
2023-06-06T19:13:13
2023-06-03T23:57:01
CONTRIBUTOR
null
Fixes https://github.com/hwchase17/langchain/issues/5067 Verified the following code now works correctly: ``` db = Chroma(persist_directory=index_directory(index_name), embedding_function=embeddings) retriever = db.as_retriever(search_type="similarity_score_threshold", search_kwargs={"score_threshold": 0.4}) docs = retriever.get_relevant_documents(query) ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5655/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5655/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5655", "html_url": "https://github.com/langchain-ai/langchain/pull/5655", "diff_url": "https://github.com/langchain-ai/langchain/pull/5655.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5655.patch", "merged_at": "2023-06-03T23:57:01" }
https://api.github.com/repos/langchain-ai/langchain/issues/5654
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5654/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5654/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5654/events
https://github.com/langchain-ai/langchain/pull/5654
1,739,458,786
PR_kwDOIPDwls5SEhkv
5,654
New features and tests for MW Dump Loader
{ "login": "Gordon-BP", "id": 77560236, "node_id": "MDQ6VXNlcjc3NTYwMjM2", "avatar_url": "https://avatars.githubusercontent.com/u/77560236?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Gordon-BP", "html_url": "https://github.com/Gordon-BP", "followers_url": "https://api.github.com/users/Gordon-BP/followers", "following_url": "https://api.github.com/users/Gordon-BP/following{/other_user}", "gists_url": "https://api.github.com/users/Gordon-BP/gists{/gist_id}", "starred_url": "https://api.github.com/users/Gordon-BP/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Gordon-BP/subscriptions", "organizations_url": "https://api.github.com/users/Gordon-BP/orgs", "repos_url": "https://api.github.com/users/Gordon-BP/repos", "events_url": "https://api.github.com/users/Gordon-BP/events{/privacy}", "received_events_url": "https://api.github.com/users/Gordon-BP/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
3
2023-06-03T11:44:58
2023-06-08T10:19:24
2023-06-08T10:19:24
CONTRIBUTOR
null
Adds new paramerters for to the MWDumpLoader class: * **skip_redirecst** (_bool_) Tells the loader to skip articles that redirect to other articles. `False` by default. * **stop_on_error** (_bool_) Tells the parser to skip any page that causes a parse error. `True` by default. * **namespaces** (_List[int]_) Tells the parser which namespaces to parse. Contains namespaces from -2 to 15 by default. Default values are chosen to preserve backwards compatability. Sample dump XML and tests are also included! Tagging people for checks / review: - @eyurtsev
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5654/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5654/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5654", "html_url": "https://github.com/langchain-ai/langchain/pull/5654", "diff_url": "https://github.com/langchain-ai/langchain/pull/5654.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5654.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5653
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5653/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5653/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5653/events
https://github.com/langchain-ai/langchain/pull/5653
1,739,405,104
PR_kwDOIPDwls5SEVJQ
5,653
Extend `langchain.callbacks` documentation
{ "login": "alvarobartt", "id": 36760800, "node_id": "MDQ6VXNlcjM2NzYwODAw", "avatar_url": "https://avatars.githubusercontent.com/u/36760800?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alvarobartt", "html_url": "https://github.com/alvarobartt", "followers_url": "https://api.github.com/users/alvarobartt/followers", "following_url": "https://api.github.com/users/alvarobartt/following{/other_user}", "gists_url": "https://api.github.com/users/alvarobartt/gists{/gist_id}", "starred_url": "https://api.github.com/users/alvarobartt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alvarobartt/subscriptions", "organizations_url": "https://api.github.com/users/alvarobartt/orgs", "repos_url": "https://api.github.com/users/alvarobartt/repos", "events_url": "https://api.github.com/users/alvarobartt/events{/privacy}", "received_events_url": "https://api.github.com/users/alvarobartt/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
5
2023-06-03T10:50:18
2023-06-19T07:43:19
2023-06-19T07:43:19
CONTRIBUTOR
null
Hi to whoever is reading this! 🤗 # What's in this PR? As of the recent addition of `ArgillaCallbackHandler` in the `master` branch of `LangChain`, merged by @dev2049 (but maybe also relevant to @agola11 since it's callback-related), @davidberenstein1957 and @dvsrepo noticed that the `Callbacks -> How to guides -> Argilla` page was missing, so I've extended the `langchain.callbacks` documentation a little bit to include the "How to guides" to also allow any other callback integration to live there, and add the missing API Reference for the callbacks.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5653/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5653/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5653", "html_url": "https://github.com/langchain-ai/langchain/pull/5653", "diff_url": "https://github.com/langchain-ai/langchain/pull/5653.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5653.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5652
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5652/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5652/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5652/events
https://github.com/langchain-ai/langchain/pull/5652
1,739,397,734
PR_kwDOIPDwls5SETdQ
5,652
SVM-based SKLearnVectorStore and filtering options for SKLearnVectorStores
{ "login": "mbrner", "id": 12487634, "node_id": "MDQ6VXNlcjEyNDg3NjM0", "avatar_url": "https://avatars.githubusercontent.com/u/12487634?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mbrner", "html_url": "https://github.com/mbrner", "followers_url": "https://api.github.com/users/mbrner/followers", "following_url": "https://api.github.com/users/mbrner/following{/other_user}", "gists_url": "https://api.github.com/users/mbrner/gists{/gist_id}", "starred_url": "https://api.github.com/users/mbrner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mbrner/subscriptions", "organizations_url": "https://api.github.com/users/mbrner/orgs", "repos_url": "https://api.github.com/users/mbrner/repos", "events_url": "https://api.github.com/users/mbrner/events{/privacy}", "received_events_url": "https://api.github.com/users/mbrner/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" } ]
closed
false
null
[]
null
5
2023-06-03T10:42:56
2023-11-07T04:16:40
2023-11-07T04:16:39
NONE
null
In this PR I have made two additions to `SKLearnVectorStore` ## SVM based VectorStore: Instead of kNN, an SVM can be used for the retrieval step. This "trick" recently got some attention due to [this tweet](https://twitter.com/karpathy/status/1647025230546886658?s=2). The tweet also discusses possible advantages (better retrieval quality) and disadvantages (slower than kNN). For the implementation, I split the `SKLearnVectorStore` class and created an abstract class `SKLearnVectorStoreBase` for which `_similarity_index_search_with_score` needs to be implemented. This abstract class is used to implement a kNN- and SVM-based vector store. ## Filtering Both the kNN and SVM vector stores can now be used with metadata filters. The filters are either strings, where a `==` comparison is performed, or a callable that is called with the value of the metadata entry and should return a bool. When using filters, the retrieval algorithm must always be retrained, which slows down the retrieval step in the case of kNN. Edit: I think @dev2049 is the maintainer for this part of the code.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5652/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5652/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5652", "html_url": "https://github.com/langchain-ai/langchain/pull/5652", "diff_url": "https://github.com/langchain-ai/langchain/pull/5652.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5652.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5651
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5651/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5651/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5651/events
https://github.com/langchain-ai/langchain/issues/5651
1,739,392,895
I_kwDOIPDwls5nrQd_
5,651
AttributeError: 'LLModel' object has no attribute 'model_type' (gpt4all)
{ "login": "pakcheera", "id": 72345015, "node_id": "MDQ6VXNlcjcyMzQ1MDE1", "avatar_url": "https://avatars.githubusercontent.com/u/72345015?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pakcheera", "html_url": "https://github.com/pakcheera", "followers_url": "https://api.github.com/users/pakcheera/followers", "following_url": "https://api.github.com/users/pakcheera/following{/other_user}", "gists_url": "https://api.github.com/users/pakcheera/gists{/gist_id}", "starred_url": "https://api.github.com/users/pakcheera/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pakcheera/subscriptions", "organizations_url": "https://api.github.com/users/pakcheera/orgs", "repos_url": "https://api.github.com/users/pakcheera/repos", "events_url": "https://api.github.com/users/pakcheera/events{/privacy}", "received_events_url": "https://api.github.com/users/pakcheera/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
4
2023-06-03T10:37:42
2023-06-16T14:29:32
2023-06-04T14:21:18
NONE
null
### System Info run on docker image with python:3.11.3-bullseye in MAC m1 ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction My docker image ``` FROM python:3.11.3-bullseye WORKDIR /src COPY src /src RUN python -m pip install --upgrade pip RUN apt-get update -y RUN apt install cmake -y RUN git clone --recurse-submodules https://github.com/nomic-ai/gpt4all RUN cd gpt4all/gpt4all-backend/ && mkdir build && cd build && cmake .. && cmake --build . --parallel RUN cd gpt4all/gpt4all-bindings/python && pip3 install -e . RUN pip install -r requirements.txt RUN chmod +x app/start_app.sh EXPOSE 8501 ENTRYPOINT ["/bin/bash"] CMD ["app/start_app.sh"] ``` where star_app.sh is run python file that have this line `llm = GPT4All(model=llm_path, backend='gptj', verbose=True, streaming=True, n_threads=os.cpu_count(),temp=temp)` llm_path is path of gpt4all model ### Expected behavior Got this error when try to use gpt4all ``` AttributeError: 'LLModel' object has no attribute 'model_type' Traceback: File "/src/app/utils.py", line 20, in get_chain llm = GPT4All(model=llm_path, backend='gptj', verbose=True, streaming=True, n_threads=os.cpu_count(),temp=temp) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/pydantic/main.py", line 339, in __init__ values, fields_set, validation_error = validate_model(__pydantic_self__.__class__, data) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/pydantic/main.py", line 1102, in validate_model values = validator(cls_, values) ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/langchain/llms/gpt4all.py", line 156, in validate_environment values["backend"] = values["client"].model.model_type ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5651/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5651/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5650
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5650/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5650/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5650/events
https://github.com/langchain-ai/langchain/pull/5650
1,739,328,748
PR_kwDOIPDwls5SEDgx
5,650
Clickhouse based Vector Store
{ "login": "haoch", "id": 1282617, "node_id": "MDQ6VXNlcjEyODI2MTc=", "avatar_url": "https://avatars.githubusercontent.com/u/1282617?v=4", "gravatar_id": "", "url": "https://api.github.com/users/haoch", "html_url": "https://github.com/haoch", "followers_url": "https://api.github.com/users/haoch/followers", "following_url": "https://api.github.com/users/haoch/following{/other_user}", "gists_url": "https://api.github.com/users/haoch/gists{/gist_id}", "starred_url": "https://api.github.com/users/haoch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/haoch/subscriptions", "organizations_url": "https://api.github.com/users/haoch/orgs", "repos_url": "https://api.github.com/users/haoch/repos", "events_url": "https://api.github.com/users/haoch/events{/privacy}", "received_events_url": "https://api.github.com/users/haoch/received_events", "type": "User", "site_admin": false }
[ { "id": 4678528817, "node_id": "LA_kwDOIPDwls8AAAABFtyvMQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" }, { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
1
2023-06-03T09:47:42
2023-06-08T03:46:45
2023-06-05T20:32:05
CONTRIBUTOR
null
<!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> #### Description This PR is mainly to integrate open source version of ClickHouse as Vector Store as it is easy for both local development and adoption of LangChain for enterprises who already have large scale clickhouse deployment. ClickHouse is a open source real-time OLAP database with full SQL support and a wide range of functions to assist users in writing analytical queries. Some of these functions and data structures perform distance operations between vectors, [enabling ClickHouse to be used as a vector database](https://clickhouse.com/blog/vector-search-clickhouse-p1). Recently added ClickHouse capabilities like [Approximate Nearest Neighbour (ANN) indices](https://clickhouse.com/docs/en/engines/table-engines/mergetree-family/annindexes) support faster approximate matching of vectors and provide a promising development aimed to further enhance the vector matching capabilities of ClickHouse. In LangChain, some ClickHouse based commercial variant vector stores like [Chroma](https://github.com/hwchase17/langchain/blob/master/langchain/vectorstores/chroma.py) and [MyScale](https://github.com/hwchase17/langchain/blob/master/langchain/vectorstores/myscale.py), etc are already integrated, but for some enterprises with large scale Clickhouse clusters deployment, it will be more straightforward to upgrade existing clickhouse infra instead of moving to another similar vector store solution, so we believe it's a valid requirement to integrate open source version of ClickHouse as vector store. As `clickhouse-connect` is already included by other integrations, this PR won't include any new dependencies. #### Before submitting <!-- If you're adding a new integration, please include: 1. Added a test for the integration: https://github.com/haoch/langchain/blob/clickhouse/tests/integration_tests/vectorstores/test_clickhouse.py 2. Added an example notebook and document showing its use: * Notebook: https://github.com/haoch/langchain/blob/clickhouse/docs/modules/indexes/vectorstores/examples/clickhouse.ipynb * Doc: https://github.com/haoch/langchain/blob/clickhouse/docs/integrations/clickhouse.md See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> 1. Added a test for the integration: https://github.com/haoch/langchain/blob/clickhouse/tests/integration_tests/vectorstores/test_clickhouse.py 2. Added an example notebook and document showing its use: * Notebook: https://github.com/haoch/langchain/blob/clickhouse/docs/modules/indexes/vectorstores/examples/clickhouse.ipynb * Doc: https://github.com/haoch/langchain/blob/clickhouse/docs/integrations/clickhouse.md #### Who can review? Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 --> @hwchase17 @dev2049 Could you please help review?
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5650/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 2, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5650/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5650", "html_url": "https://github.com/langchain-ai/langchain/pull/5650", "diff_url": "https://github.com/langchain-ai/langchain/pull/5650.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5650.patch", "merged_at": "2023-06-05T20:32:05" }
https://api.github.com/repos/langchain-ai/langchain/issues/5649
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5649/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5649/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5649/events
https://github.com/langchain-ai/langchain/pull/5649
1,739,319,648
PR_kwDOIPDwls5SEBb_
5,649
This is a fix for #5475
{ "login": "rajib76", "id": 16340036, "node_id": "MDQ6VXNlcjE2MzQwMDM2", "avatar_url": "https://avatars.githubusercontent.com/u/16340036?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rajib76", "html_url": "https://github.com/rajib76", "followers_url": "https://api.github.com/users/rajib76/followers", "following_url": "https://api.github.com/users/rajib76/following{/other_user}", "gists_url": "https://api.github.com/users/rajib76/gists{/gist_id}", "starred_url": "https://api.github.com/users/rajib76/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rajib76/subscriptions", "organizations_url": "https://api.github.com/users/rajib76/orgs", "repos_url": "https://api.github.com/users/rajib76/repos", "events_url": "https://api.github.com/users/rajib76/events{/privacy}", "received_events_url": "https://api.github.com/users/rajib76/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-03T09:35:24
2023-06-03T16:06:54
2023-06-03T16:06:54
CONTRIBUTOR
null
<!-- Currently in PGVector, the from_documents method will add the embeddings and then return the instance of the store. We should have a method that just returns the store object without inserting embeddings, This is useful when I already have a loaded vector store and I just need the instance of the store. It will be like the below code without the store.add_texts store = cls( connection_string=connection_string, collection_name=collection_name, embedding_function=embedding, distance_strategy=distance_strategy, pre_delete_collection=pre_delete_collection, ) store.add_texts(texts=texts, metadatas=metadatas, ids=ids, **kwargs) return store After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> <!-- Remove if not applicable --> Fixes # 5475 #### Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> #### Who can review? @hwchase17 @dev2049 Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5649/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5649/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5649", "html_url": "https://github.com/langchain-ai/langchain/pull/5649", "diff_url": "https://github.com/langchain-ai/langchain/pull/5649.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5649.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5648
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5648/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5648/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5648/events
https://github.com/langchain-ai/langchain/issues/5648
1,739,315,605
I_kwDOIPDwls5nq9mV
5,648
Bug in langchain.llms.Modal which raised ValueError("LangChain requires 'prompt' key in response.")
{ "login": "limcheekin", "id": 88172, "node_id": "MDQ6VXNlcjg4MTcy", "avatar_url": "https://avatars.githubusercontent.com/u/88172?v=4", "gravatar_id": "", "url": "https://api.github.com/users/limcheekin", "html_url": "https://github.com/limcheekin", "followers_url": "https://api.github.com/users/limcheekin/followers", "following_url": "https://api.github.com/users/limcheekin/following{/other_user}", "gists_url": "https://api.github.com/users/limcheekin/gists{/gist_id}", "starred_url": "https://api.github.com/users/limcheekin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/limcheekin/subscriptions", "organizations_url": "https://api.github.com/users/limcheekin/orgs", "repos_url": "https://api.github.com/users/limcheekin/repos", "events_url": "https://api.github.com/users/limcheekin/events{/privacy}", "received_events_url": "https://api.github.com/users/limcheekin/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
4
2023-06-03T09:27:01
2023-12-13T16:09:23
2023-12-13T16:09:22
NONE
null
### System Info LangChain: 0.0.189 Platform: Ubuntu 22.04.2 LTS Python: 3.10.10 ### Who can help? @hwchase17 @agola11 ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction You can re-produce the error using the notebook at https://python.langchain.com/en/latest/modules/models/llms/integrations/modal.html The following is the response json from my Modal endpoint: ```javascript {'prompt': 'Artificial Intelligence (AI) is the study of artificial intelligence. Artificial intelligence is the study of artificial intelligence. So, the final answer is AI.'} ``` It still raise the ValueError("LangChain requires 'prompt' key in response."). After look into the code, I think there is a bug at https://github.com/hwchase17/langchain/blob/master/langchain/llms/modal.py#L90, the correct syntax should be: ```python if "prompt" in response.json(): ``` ### Expected behavior No value error should be raised if the response json format is correct.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5648/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5648/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5647
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5647/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5647/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5647/events
https://github.com/langchain-ai/langchain/issues/5647
1,739,243,294
I_kwDOIPDwls5nqr8e
5,647
Trying to load an external model Llama-30B-Supercot results in below error
{ "login": "zubair-ahmed-ai", "id": 66907171, "node_id": "MDQ6VXNlcjY2OTA3MTcx", "avatar_url": "https://avatars.githubusercontent.com/u/66907171?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zubair-ahmed-ai", "html_url": "https://github.com/zubair-ahmed-ai", "followers_url": "https://api.github.com/users/zubair-ahmed-ai/followers", "following_url": "https://api.github.com/users/zubair-ahmed-ai/following{/other_user}", "gists_url": "https://api.github.com/users/zubair-ahmed-ai/gists{/gist_id}", "starred_url": "https://api.github.com/users/zubair-ahmed-ai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zubair-ahmed-ai/subscriptions", "organizations_url": "https://api.github.com/users/zubair-ahmed-ai/orgs", "repos_url": "https://api.github.com/users/zubair-ahmed-ai/repos", "events_url": "https://api.github.com/users/zubair-ahmed-ai/events{/privacy}", "received_events_url": "https://api.github.com/users/zubair-ahmed-ai/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-03T07:13:52
2023-06-03T08:05:47
2023-06-03T08:05:47
NONE
null
### System Info Langchain version 0.0.179 Ubuntu 20.4 ### Who can help? @hwchase17 @agola11 @vowelparrot ### Information - [ ] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [X] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction Trying to load Llama-30b-supercot this way results in below error, what is the correct way to load a model with additional configuration like given below? ``` model_name = 'ausboss/llama-30b-supercot' quantization_config = BitsAndBytesConfig(llm_int8_enable_fp32_cpu_offload=True) model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype=torch.float16, device_map='auto', load_in_8bit=True,quantization_config=quantization_config) tokenizer = AutoTokenizer.from_pretrained(model_name) instruct_pipeline = pipeline("text-generation", model=model, tokenizer=tokenizer, torch_dtype=torch.bfloat16, trust_remote_code=True, device_map="auto", return_full_text=True, max_new_tokens=200, top_p=0.95, top_k=50, eos_token_id=tokenizer.eos_token_id) template = """Below is an instruction that describes a task. Write a response that appropriately completes the request. Instruction: You are an experienced in this solution and your job is to help providing the best answer related to this. Use only information in the following paragraphs to answer the question at the end, do not repeat sentences in your answer. Explain the answer with reference to these paragraphs. If you don't know, say that you do not know. {context} Question: {question} Response: """ prompt = PromptTemplate(input_variables=['context', 'question'], template=template) return load_qa_chain(llm=instruct_pipeline, chain_type="map_reduce", prompt=prompt, verbose=False) ``` Results in this error ``` │ /home/ubuntu/lambda_labs/llama-supercot/Search_faiss_llama_30B_supercot.py:59 in build_qa_chain │ │ │ │ 56 """ │ │ 57 prompt = PromptTemplate(input_variables=['context', 'question'], template=template) │ │ 58 │ │ ❱ 59 return load_qa_chain(llm=instruct_pipeline, chain_type="map_reduce", prompt=prompt, ve │ │ 60 │ │ 61 # Building the chain will load Dolly and can take several minutes depending on the model │ │ 62 qa_chain = build_qa_chain() │ │ │ │ /home/ubuntu/miniconda/lib/python3.10/site-packages/langchain/chains/question_answering/__init__ │ │ .py:218 in load_qa_chain │ │ │ │ 215 │ │ │ f"Got unsupported chain type: {chain_type}. " │ │ 216 │ │ │ f"Should be one of {loader_mapping.keys()}" │ │ 217 │ │ ) │ │ ❱ 218 │ return loader_mapping[chain_type]( │ │ 219 │ │ llm, verbose=verbose, callback_manager=callback_manager, **kwargs │ │ 220 │ ) │ │ 221 │ │ │ │ /home/ubuntu/miniconda/lib/python3.10/site-packages/langchain/chains/question_answering/__init__ │ │ .py:95 in _load_map_reduce_chain │ │ │ │ 92 │ _combine_prompt = ( │ │ 93 │ │ combine_prompt or map_reduce_prompt.COMBINE_PROMPT_SELECTOR.get_prompt(llm) │ │ 94 │ ) │ │ ❱ 95 │ map_chain = LLMChain( │ │ 96 │ │ llm=llm, │ │ 97 │ │ prompt=_question_prompt, │ │ 98 │ │ verbose=verbose, │ │ │ │ /home/ubuntu/lambda_labs/llama-supercot/pydantic/main.py:341 in pydantic.main.BaseModel.__init__ │ │ │ │ [Errno 2] No such file or directory: '/home/ubuntu/lambda_labs/llama-supercot/pydantic/main.py' │ ╰──────────────────────────────────────────────────────────────────────────────────────────────────╯ ValidationError: 1 validation error for LLMChain llm value is not a valid dict (type=type_error.dict) ``` ### Expected behavior A model should load for Q&A with documents
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5647/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5647/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5646
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5646/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5646/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5646/events
https://github.com/langchain-ai/langchain/pull/5646
1,739,169,594
PR_kwDOIPDwls5SDgWE
5,646
fix: correct momento chat history notebook typo and title
{ "login": "malandis", "id": 3690240, "node_id": "MDQ6VXNlcjM2OTAyNDA=", "avatar_url": "https://avatars.githubusercontent.com/u/3690240?v=4", "gravatar_id": "", "url": "https://api.github.com/users/malandis", "html_url": "https://github.com/malandis", "followers_url": "https://api.github.com/users/malandis/followers", "following_url": "https://api.github.com/users/malandis/following{/other_user}", "gists_url": "https://api.github.com/users/malandis/gists{/gist_id}", "starred_url": "https://api.github.com/users/malandis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/malandis/subscriptions", "organizations_url": "https://api.github.com/users/malandis/orgs", "repos_url": "https://api.github.com/users/malandis/repos", "events_url": "https://api.github.com/users/malandis/events{/privacy}", "received_events_url": "https://api.github.com/users/malandis/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-03T05:00:29
2023-06-03T23:39:27
2023-06-03T23:39:27
CONTRIBUTOR
null
This PR corrects a minor typo in the Momento chat message history notebook and also expands the title from "Momento" to "Momento Chat History", inline with other chat history storage providers. #### Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> #### Who can review? cc @dev2049 who reviewed the original integration
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5646/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5646/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5646", "html_url": "https://github.com/langchain-ai/langchain/pull/5646", "diff_url": "https://github.com/langchain-ai/langchain/pull/5646.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5646.patch", "merged_at": "2023-06-03T23:39:27" }
https://api.github.com/repos/langchain-ai/langchain/issues/5645
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5645/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5645/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5645/events
https://github.com/langchain-ai/langchain/issues/5645
1,739,157,088
I_kwDOIPDwls5nqW5g
5,645
I want ssh tunnel support in SQLDatabaseChain
{ "login": "hukuhuku-matsuo", "id": 64072754, "node_id": "MDQ6VXNlcjY0MDcyNzU0", "avatar_url": "https://avatars.githubusercontent.com/u/64072754?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hukuhuku-matsuo", "html_url": "https://github.com/hukuhuku-matsuo", "followers_url": "https://api.github.com/users/hukuhuku-matsuo/followers", "following_url": "https://api.github.com/users/hukuhuku-matsuo/following{/other_user}", "gists_url": "https://api.github.com/users/hukuhuku-matsuo/gists{/gist_id}", "starred_url": "https://api.github.com/users/hukuhuku-matsuo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hukuhuku-matsuo/subscriptions", "organizations_url": "https://api.github.com/users/hukuhuku-matsuo/orgs", "repos_url": "https://api.github.com/users/hukuhuku-matsuo/repos", "events_url": "https://api.github.com/users/hukuhuku-matsuo/events{/privacy}", "received_events_url": "https://api.github.com/users/hukuhuku-matsuo/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-03T04:43:36
2023-09-14T16:06:47
2023-09-14T16:06:46
NONE
null
### Feature request Due to security reasons, it is not always possible to connect directly to the DB. I want SQLDatabaseChain to support ssh tunnel because I have to connect to a specific kind of stepping stone server before I can connect to the DB. If there is already a way to accomplish this, I apologize. ### Motivation I want to use llm with all our own data to create an innovative experience, and SQLDatabaseChain makes that possible. ### Your contribution I can contribute with testing. I do not yet have a good understanding of langchain's source code structure and inner workings, so coding contributions would not be appropriate.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5645/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5645/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5642
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5642/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5642/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5642/events
https://github.com/langchain-ai/langchain/issues/5642
1,739,087,949
I_kwDOIPDwls5nqGBN
5,642
RetrievalQAWithSourcesChain provides unreliable sources
{ "login": "startakovsky", "id": 689723, "node_id": "MDQ6VXNlcjY4OTcyMw==", "avatar_url": "https://avatars.githubusercontent.com/u/689723?v=4", "gravatar_id": "", "url": "https://api.github.com/users/startakovsky", "html_url": "https://github.com/startakovsky", "followers_url": "https://api.github.com/users/startakovsky/followers", "following_url": "https://api.github.com/users/startakovsky/following{/other_user}", "gists_url": "https://api.github.com/users/startakovsky/gists{/gist_id}", "starred_url": "https://api.github.com/users/startakovsky/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/startakovsky/subscriptions", "organizations_url": "https://api.github.com/users/startakovsky/orgs", "repos_url": "https://api.github.com/users/startakovsky/repos", "events_url": "https://api.github.com/users/startakovsky/events{/privacy}", "received_events_url": "https://api.github.com/users/startakovsky/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-03T02:45:24
2023-09-18T16:09:24
2023-09-18T16:09:23
CONTRIBUTOR
null
### System Info ## System Info - `langchain.__version__` is `0.0.184` - Python 3.11 - Mac OS Ventura 13.3.1(a) ### Who can help? @hwchase17 ## Summary The **sources** component of the output of `RetrievalQAWithSourcesChain` is not providing transparency into what documents the retriever returns, it is instead some output that the llm contrives. ## Motivation From my perspective, the primary advantage of having visibility into sources is to allow the system to provide transparency into the documents that were retrieved in assisting the language model to generate its answer. Only after being confused for quite a while and inspecting the code did I realize that the sources were just being conjured up. ## Advice I think it is important to ensure that people know about this, as maybe this isn't a bug and is more [documentation](https://python.langchain.com/en/latest/modules/chains/index_examples/vector_db_qa_with_sources.html)-related, though I think the [docstring](https://github.com/hwchase17/langchain/blob/9a7488a5ce65aaf727464f02a10811719b517f11/langchain/chains/qa_with_sources/retrieval.py#L13) should be updated as well. ### Notes #### Document Retrieval Works very well. It's worth noting that in this toy example, the combination of `FAISS` vector store and the `OpenAIEmbeddings` embeddings model are doing very reasonably, and are deterministic. #### Recommendation Add caveats everywhere. Frankly, I would never trust using this chain. I literally had an example the other day where it wrongly made up a source and a wikipedia url that had absolutely nothing to do with the documents retrieved. I could supply this example as it is a way better illustration of how this chain will hallucinate sources because they are generated by the LLM, but it's just a little bit more involved than this smaller example. ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [X] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ## Demonstrative Example Here's the simplest example I could come up with: ### 1. Instantiate a `vectorstore` with 7 documents displayed below. ```python >>> from langchain.vectorstores import FAISS >>> from langchain.embeddings import OpenAIEmbeddings >>> from langchain.llms import OpenAI >>> from langchain.chains import RetrievalQAWithSourcesChain >>> chars = ['a', 'b', 'c', 'd', '1', '2', '3'] >>> texts = [4*c for c in chars] >>> metadatas = [{'title': c, 'source': f'source_{c}'} for c in chars] >>> vs = FAISS.from_texts(texts, embedding=OpenAIEmbeddings(), metadatas=metadatas) >>> retriever = vs.as_retriever(search_kwargs=dict(k=5)) >>> vs.docstore._dict ``` {'0ec43ce4-6753-4dac-b72a-6cf9decb290e': Document(page_content='aaaa', metadata={'title': 'a', 'source': 'source_a'}), '54baed0b-690a-4ffc-bb1e-707eed7da5a1': Document(page_content='bbbb', metadata={'title': 'b', 'source': 'source_b'}), '85b834fa-14e1-4b20-9912-fa63fb7f0e50': Document(page_content='cccc', metadata={'title': 'c', 'source': 'source_c'}), '06c0cfd0-21a2-4e0c-9c2e-dd624b5164fe': Document(page_content='dddd', metadata={'title': 'd', 'source': 'source_d'}), '94d6444f-96cd-4d88-8973-c3c0b9bf0c78': Document(page_content='1111', metadata={'title': '1', 'source': 'source_1'}), 'ec04b042-a4eb-4570-9ee9-a2a0bd66a82e': Document(page_content='2222', metadata={'title': '2', 'source': 'source_2'}), '0031d3fc-f291-481e-a12a-9cc6ed9761e0': Document(page_content='3333', metadata={'title': '3', 'source': 'source_3'})} ### 2. Instantiate a `RetrievalQAWithSourcesChain` The `return_source_documents` is set to `True` so that we can inspect the actual sources retrieved. ```python >>> qa_sources = RetrievalQAWithSourcesChain.from_chain_type( OpenAI(), retriever=retriever, return_source_documents=True ) ``` ### 3. Example Question Things look sort of fine, meaning 5 documents are retrieved by the `retriever`, but the model only lists only a single source. ```python qa_sources('what is the first lower-case letter of the alphabet?') ``` {'question': 'what is the first lower-case letter of the alphabet?', 'answer': ' The first lower-case letter of the alphabet is "a".\n', 'sources': 'source_a', 'source_documents': [Document(page_content='bbbb', metadata={'title': 'b', 'source': 'source_b'}), Document(page_content='aaaa', metadata={'title': 'a', 'source': 'source_a'}), Document(page_content='cccc', metadata={'title': 'c', 'source': 'source_c'}), Document(page_content='dddd', metadata={'title': 'd', 'source': 'source_d'}), Document(page_content='1111', metadata={'title': '1', 'source': 'source_1'})]} ### 4. Second Example Question containing the First Question. This is not what I would expect, considering that this question contains the previous question, and that the vector store did supply the document with `{'source': 'source_a'}`, but for some reason (i.e. the internals of the output of `OpenAI()` ) in this response from the chain, there are zero sources listed. ```python >>> qa_sources('what is the one and only first lower-case letter and number of the alphabet and whole number system?') ``` {'question': 'what is the one and only first lower-case letter and number of the alphabet and whole number system?', 'answer': ' The one and only first lower-case letter and number of the alphabet and whole number system is "a1".\n', 'sources': 'N/A', 'source_documents': [Document(page_content='1111', metadata={'title': '1', 'source': 'source_1'}), Document(page_content='bbbb', metadata={'title': 'b', 'source': 'source_b'}), Document(page_content='aaaa', metadata={'title': 'a', 'source': 'source_a'}), Document(page_content='2222', metadata={'title': '2', 'source': 'source_2'}), Document(page_content='cccc', metadata={'title': 'c', 'source': 'source_c'})]} ### Expected behavior I am not sure. We need a warning, perhaps, every time this chain is used, or some strongly worded documentation for our developers.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5642/reactions", "total_count": 14, "+1": 14, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5642/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5641
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5641/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5641/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5641/events
https://github.com/langchain-ai/langchain/pull/5641
1,739,058,450
PR_kwDOIPDwls5SDHka
5,641
Add knn and query search field options to ElasticKnnSearch
{ "login": "jeffvestal", "id": 53237856, "node_id": "MDQ6VXNlcjUzMjM3ODU2", "avatar_url": "https://avatars.githubusercontent.com/u/53237856?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jeffvestal", "html_url": "https://github.com/jeffvestal", "followers_url": "https://api.github.com/users/jeffvestal/followers", "following_url": "https://api.github.com/users/jeffvestal/following{/other_user}", "gists_url": "https://api.github.com/users/jeffvestal/gists{/gist_id}", "starred_url": "https://api.github.com/users/jeffvestal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jeffvestal/subscriptions", "organizations_url": "https://api.github.com/users/jeffvestal/orgs", "repos_url": "https://api.github.com/users/jeffvestal/repos", "events_url": "https://api.github.com/users/jeffvestal/events{/privacy}", "received_events_url": "https://api.github.com/users/jeffvestal/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
0
2023-06-03T02:01:32
2023-06-08T03:19:14
2023-06-08T03:19:14
CONTRIBUTOR
null
in the `ElasticKnnSearch` class added 2 arguments that were not exposed properly `knn_search` added: - `vector_query_field: Optional[str] = 'vector'` -- vector_query_field: Field name to use in knn search if not default 'vector' `knn_hybrid_search` added: - `vector_query_field: Optional[str] = 'vector'` -- vector_query_field: Field name to use in knn search if not default 'vector' - `query_field: Optional[str] = 'text'` -- query_field: Field name to use in search if not default 'text' Fixes # https://github.com/hwchase17/langchain/issues/5633 cc: @dev2049 @hwchase17
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5641/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5641/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5641", "html_url": "https://github.com/langchain-ai/langchain/pull/5641", "diff_url": "https://github.com/langchain-ai/langchain/pull/5641.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5641.patch", "merged_at": "2023-06-08T03:19:14" }
https://api.github.com/repos/langchain-ai/langchain/issues/5640
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5640/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5640/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5640/events
https://github.com/langchain-ai/langchain/pull/5640
1,738,953,863
PR_kwDOIPDwls5SCwVf
5,640
Replace exec with wasm_exec
{ "login": "Jflick58", "id": 22459070, "node_id": "MDQ6VXNlcjIyNDU5MDcw", "avatar_url": "https://avatars.githubusercontent.com/u/22459070?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Jflick58", "html_url": "https://github.com/Jflick58", "followers_url": "https://api.github.com/users/Jflick58/followers", "following_url": "https://api.github.com/users/Jflick58/following{/other_user}", "gists_url": "https://api.github.com/users/Jflick58/gists{/gist_id}", "starred_url": "https://api.github.com/users/Jflick58/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Jflick58/subscriptions", "organizations_url": "https://api.github.com/users/Jflick58/orgs", "repos_url": "https://api.github.com/users/Jflick58/repos", "events_url": "https://api.github.com/users/Jflick58/events{/privacy}", "received_events_url": "https://api.github.com/users/Jflick58/received_events", "type": "User", "site_admin": false }
[]
open
false
null
[]
null
16
2023-06-02T23:47:47
2023-11-01T23:18:46
null
CONTRIBUTOR
null
This replaces the usage of the insecure `exec` function with a more secure library called [wasm_exec](https://github.com/Jflick58/wasm_exec) TL;DR: Use `chroot` jails, `wasmtime` and a standalone Python3.11 WASM interpreter to safely execute arbitrary code Some questions before I officially submit this pr: - **How critical is it that we support the execution of code containing 3rd-party dependencies?** The team behind the wasm interpreter I vendor with the library is working on porting `numpy` along with some of the c libs needed to enable broader package support. - *If it is critical, then how critical is it to support Python versions below 3.11?* Right now the interpreter does support the use of an existing venv for accessing installed 3rd party deps, but the interpreter is only distributed in 3.11 which means I would either a) have to only support 3.11 b) have a 3rd split in the PythonRepl code base (base, AST, Wasm) or b) try to write some hacky and unpythonic code to try to dynamically create a new 3.11-based venv off of the currently active Python environment. - *If it is not critical* then is it okay if I refactor the test cases to avoid the tests containing `numpy` and `pandas` code? Should we also update the docs to reflect that limitation? I also strongly welcome feedback on the wasm_exec library if there are implementation ideas that make it more functional. Fixes #1026 Fixes #5294 Fixes #5388 Fixes https://nvd.nist.gov/vuln/detail/CVE-2023-29374 #### Who can review? - @hwchase17 - @vowelparrot
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5640/reactions", "total_count": 6, "+1": 6, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5640/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5640", "html_url": "https://github.com/langchain-ai/langchain/pull/5640", "diff_url": "https://github.com/langchain-ai/langchain/pull/5640.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5640.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5639
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5639/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5639/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5639/events
https://github.com/langchain-ai/langchain/pull/5639
1,738,951,281
PR_kwDOIPDwls5SCvxA
5,639
Retitles Bedrock doc to appear in correct alphabetical order in site nav
{ "login": "JasonWeill", "id": 93281816, "node_id": "U_kgDOBY9eGA", "avatar_url": "https://avatars.githubusercontent.com/u/93281816?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JasonWeill", "html_url": "https://github.com/JasonWeill", "followers_url": "https://api.github.com/users/JasonWeill/followers", "following_url": "https://api.github.com/users/JasonWeill/following{/other_user}", "gists_url": "https://api.github.com/users/JasonWeill/gists{/gist_id}", "starred_url": "https://api.github.com/users/JasonWeill/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JasonWeill/subscriptions", "organizations_url": "https://api.github.com/users/JasonWeill/orgs", "repos_url": "https://api.github.com/users/JasonWeill/repos", "events_url": "https://api.github.com/users/JasonWeill/events{/privacy}", "received_events_url": "https://api.github.com/users/JasonWeill/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-02T23:42:02
2023-06-04T21:39:25
2023-06-04T21:39:25
CONTRIBUTOR
null
<!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> <!-- Remove if not applicable --> Fixes #5638. Retitles "Amazon Bedrock" page to "Bedrock" so that the Integrations section of the left nav is properly sorted in alphabetical order. #### Who can review? Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5639/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5639/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5639", "html_url": "https://github.com/langchain-ai/langchain/pull/5639", "diff_url": "https://github.com/langchain-ai/langchain/pull/5639.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5639.patch", "merged_at": "2023-06-04T21:39:25" }
https://api.github.com/repos/langchain-ai/langchain/issues/5638
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5638/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5638/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5638/events
https://github.com/langchain-ai/langchain/issues/5638
1,738,950,805
I_kwDOIPDwls5npkiV
5,638
DOC: "Amazon Bedrock" is not sorted in Integrations section of nav
{ "login": "JasonWeill", "id": 93281816, "node_id": "U_kgDOBY9eGA", "avatar_url": "https://avatars.githubusercontent.com/u/93281816?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JasonWeill", "html_url": "https://github.com/JasonWeill", "followers_url": "https://api.github.com/users/JasonWeill/followers", "following_url": "https://api.github.com/users/JasonWeill/following{/other_user}", "gists_url": "https://api.github.com/users/JasonWeill/gists{/gist_id}", "starred_url": "https://api.github.com/users/JasonWeill/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JasonWeill/subscriptions", "organizations_url": "https://api.github.com/users/JasonWeill/orgs", "repos_url": "https://api.github.com/users/JasonWeill/repos", "events_url": "https://api.github.com/users/JasonWeill/events{/privacy}", "received_events_url": "https://api.github.com/users/JasonWeill/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T23:41:12
2023-06-04T21:39:26
2023-06-04T21:39:26
CONTRIBUTOR
null
### Issue with current documentation: In the left nav of the docs, "Amazon Bedrock" is alphabetized after "Beam integration for langchain" and before "Cerebrium AI", not with the rest of the A-named integrations. <img width="254" alt="image" src="https://github.com/hwchase17/langchain/assets/93281816/20836ca0-3946-4614-8b44-4dcf67e27f7e"> ### Idea or request for content: Retitle the page to "Bedrock" so that its URL remains unchanged and the nav is properly sorted.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5638/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5638/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5637
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5637/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5637/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5637/events
https://github.com/langchain-ai/langchain/pull/5637
1,738,933,116
PR_kwDOIPDwls5SCr6S
5,637
handle single arg to and/or
{ "login": "dev2049", "id": 130488702, "node_id": "U_kgDOB8cZfg", "avatar_url": "https://avatars.githubusercontent.com/u/130488702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev2049", "html_url": "https://github.com/dev2049", "followers_url": "https://api.github.com/users/dev2049/followers", "following_url": "https://api.github.com/users/dev2049/following{/other_user}", "gists_url": "https://api.github.com/users/dev2049/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev2049/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev2049/subscriptions", "organizations_url": "https://api.github.com/users/dev2049/orgs", "repos_url": "https://api.github.com/users/dev2049/repos", "events_url": "https://api.github.com/users/dev2049/events{/privacy}", "received_events_url": "https://api.github.com/users/dev2049/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-02T23:10:00
2023-06-03T22:18:48
2023-06-03T22:18:47
CONTRIBUTOR
null
@ryderwishart @eyurtsev thoughts on handling this in the parser itself? related to #5570
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5637/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5637/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5637", "html_url": "https://github.com/langchain-ai/langchain/pull/5637", "diff_url": "https://github.com/langchain-ai/langchain/pull/5637.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5637.patch", "merged_at": "2023-06-03T22:18:47" }
https://api.github.com/repos/langchain-ai/langchain/issues/5636
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5636/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5636/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5636/events
https://github.com/langchain-ai/langchain/pull/5636
1,738,805,530
PR_kwDOIPDwls5SCQNr
5,636
fix import issue
{ "login": "leo-gan", "id": 2256422, "node_id": "MDQ6VXNlcjIyNTY0MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/2256422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/leo-gan", "html_url": "https://github.com/leo-gan", "followers_url": "https://api.github.com/users/leo-gan/followers", "following_url": "https://api.github.com/users/leo-gan/following{/other_user}", "gists_url": "https://api.github.com/users/leo-gan/gists{/gist_id}", "starred_url": "https://api.github.com/users/leo-gan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leo-gan/subscriptions", "organizations_url": "https://api.github.com/users/leo-gan/orgs", "repos_url": "https://api.github.com/users/leo-gan/repos", "events_url": "https://api.github.com/users/leo-gan/events{/privacy}", "received_events_url": "https://api.github.com/users/leo-gan/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
1
2023-06-02T20:42:39
2023-06-02T22:13:15
2023-06-02T21:58:41
COLLABORATOR
null
# fix for the import issue Added document loader classes from [`figma`, `iugu`, `onedrive_file`] to `document_loaders/__inti__.py` imports Also sorted `__all__` Fixed #5623 issue #### Who can review? @eyurtsev
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5636/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5636/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5636", "html_url": "https://github.com/langchain-ai/langchain/pull/5636", "diff_url": "https://github.com/langchain-ai/langchain/pull/5636.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5636.patch", "merged_at": "2023-06-02T21:58:41" }
https://api.github.com/repos/langchain-ai/langchain/issues/5635
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5635/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5635/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5635/events
https://github.com/langchain-ai/langchain/pull/5635
1,738,789,780
PR_kwDOIPDwls5SCMzE
5,635
In memory audio blob loading and splitting
{ "login": "rlancemartin", "id": 122662504, "node_id": "U_kgDOB0-uaA", "avatar_url": "https://avatars.githubusercontent.com/u/122662504?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rlancemartin", "html_url": "https://github.com/rlancemartin", "followers_url": "https://api.github.com/users/rlancemartin/followers", "following_url": "https://api.github.com/users/rlancemartin/following{/other_user}", "gists_url": "https://api.github.com/users/rlancemartin/gists{/gist_id}", "starred_url": "https://api.github.com/users/rlancemartin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rlancemartin/subscriptions", "organizations_url": "https://api.github.com/users/rlancemartin/orgs", "repos_url": "https://api.github.com/users/rlancemartin/repos", "events_url": "https://api.github.com/users/rlancemartin/events{/privacy}", "received_events_url": "https://api.github.com/users/rlancemartin/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
3
2023-06-02T20:29:00
2023-06-07T04:08:25
2023-06-07T04:08:24
COLLABORATOR
null
This PR creates a `BaseBlobSplitter` and a `BaseBlobTransformer`, which can be used to split and transform blobs. It creates an instance of the `BaseBlobTransformer` called `YoutubeToAudioTransformer`, which can be used to download a YouTube URL to audio. In addition, it creates an instance of `BaseBlobSplitter` called `AudioSplitter`, which can be used to split an audio file into smaller blobs. Both are useful for an end-to-end workflow that combines (1) YouTube link to Audio, (2) Audio to Audio splits, and (3) then use `OpenAIWhisperParser` [here](https://github.com/hwchase17/langchain/pull/5580) to create `Documents` from the splits.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5635/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5635/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5635", "html_url": "https://github.com/langchain-ai/langchain/pull/5635", "diff_url": "https://github.com/langchain-ai/langchain/pull/5635.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5635.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5633
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5633/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5633/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5633/events
https://github.com/langchain-ai/langchain/issues/5633
1,738,770,687
I_kwDOIPDwls5no4j_
5,633
Allow query field to be passed in ElasticKnnSearch.knnSearch
{ "login": "jeffvestal", "id": 53237856, "node_id": "MDQ6VXNlcjUzMjM3ODU2", "avatar_url": "https://avatars.githubusercontent.com/u/53237856?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jeffvestal", "html_url": "https://github.com/jeffvestal", "followers_url": "https://api.github.com/users/jeffvestal/followers", "following_url": "https://api.github.com/users/jeffvestal/following{/other_user}", "gists_url": "https://api.github.com/users/jeffvestal/gists{/gist_id}", "starred_url": "https://api.github.com/users/jeffvestal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jeffvestal/subscriptions", "organizations_url": "https://api.github.com/users/jeffvestal/orgs", "repos_url": "https://api.github.com/users/jeffvestal/repos", "events_url": "https://api.github.com/users/jeffvestal/events{/privacy}", "received_events_url": "https://api.github.com/users/jeffvestal/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-02T20:16:03
2023-09-10T16:08:24
2023-09-10T16:08:23
CONTRIBUTOR
null
### System Info The [_default_knn_query](https://github.com/jeffvestal/langchain/blob/10f34bf62e2d53f0b1a7b15ba21c2328b64862cd/langchain/vectorstores/elastic_vector_search.py#L402) takes `field` arg to specify the field to use when performing knn and hybrid search. both [knn_search](https://github.com/jeffvestal/langchain/blob/10f34bf62e2d53f0b1a7b15ba21c2328b64862cd/langchain/vectorstores/elastic_vector_search.py#L475) and [hybrid_search](https://github.com/jeffvestal/langchain/blob/10f34bf62e2d53f0b1a7b15ba21c2328b64862cd/langchain/vectorstores/elastic_vector_search.py#L537) need to allow that to be passed in as an arg and pass it to `_default_knn_query` I'll make the update cc: @hw ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [X] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction Try to search a field other than `vector`, can't do it ### Expected behavior Pass a `qeuery_field` value to search over a different field name other than the default `vector`
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5633/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5633/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5632
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5632/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5632/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5632/events
https://github.com/langchain-ai/langchain/pull/5632
1,738,765,329
PR_kwDOIPDwls5SCHWd
5,632
Update MongoDBChatMessageHistory to create an index on SessionId
{ "login": "ldesousa-stf", "id": 104941391, "node_id": "U_kgDOBkFHTw", "avatar_url": "https://avatars.githubusercontent.com/u/104941391?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ldesousa-stf", "html_url": "https://github.com/ldesousa-stf", "followers_url": "https://api.github.com/users/ldesousa-stf/followers", "following_url": "https://api.github.com/users/ldesousa-stf/following{/other_user}", "gists_url": "https://api.github.com/users/ldesousa-stf/gists{/gist_id}", "starred_url": "https://api.github.com/users/ldesousa-stf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ldesousa-stf/subscriptions", "organizations_url": "https://api.github.com/users/ldesousa-stf/orgs", "repos_url": "https://api.github.com/users/ldesousa-stf/repos", "events_url": "https://api.github.com/users/ldesousa-stf/events{/privacy}", "received_events_url": "https://api.github.com/users/ldesousa-stf/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-02T20:12:25
2023-06-04T23:46:24
2023-06-04T21:39:56
CONTRIBUTOR
null
All the queries to the database are done based on the SessionId property, this will optimize how Mongo retrieves all messages from a session #### Who can review? Tag maintainers/contributors who might be interested: @dev2049
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5632/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5632/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5632", "html_url": "https://github.com/langchain-ai/langchain/pull/5632", "diff_url": "https://github.com/langchain-ai/langchain/pull/5632.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5632.patch", "merged_at": "2023-06-04T21:39:56" }
https://api.github.com/repos/langchain-ai/langchain/issues/5631
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5631/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5631/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5631/events
https://github.com/langchain-ai/langchain/issues/5631
1,738,736,481
I_kwDOIPDwls5nowNh
5,631
Make embedding object optional for ElasticKnnSearch
{ "login": "jeffvestal", "id": 53237856, "node_id": "MDQ6VXNlcjUzMjM3ODU2", "avatar_url": "https://avatars.githubusercontent.com/u/53237856?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jeffvestal", "html_url": "https://github.com/jeffvestal", "followers_url": "https://api.github.com/users/jeffvestal/followers", "following_url": "https://api.github.com/users/jeffvestal/following{/other_user}", "gists_url": "https://api.github.com/users/jeffvestal/gists{/gist_id}", "starred_url": "https://api.github.com/users/jeffvestal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jeffvestal/subscriptions", "organizations_url": "https://api.github.com/users/jeffvestal/orgs", "repos_url": "https://api.github.com/users/jeffvestal/repos", "events_url": "https://api.github.com/users/jeffvestal/events{/privacy}", "received_events_url": "https://api.github.com/users/jeffvestal/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-02T19:52:37
2023-09-10T16:08:28
2023-09-10T16:08:27
CONTRIBUTOR
null
### Feature request Make `embedding` an [optional arg](https://github.com/jeffvestal/langchain/blob/10f34bf62e2d53f0b1a7b15ba21c2328b64862cd/langchain/vectorstores/elastic_vector_search.py#L332) when creating `ElasticKnnSearch` class ### Motivation If a user is only going to run knn/hybrid search AND use the `query_vector_builder` having an embedding object is not needed as ES will generate the embedding during search ### Your contribution I will make the changes
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5631/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5631/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5630
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5630/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5630/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5630/events
https://github.com/langchain-ai/langchain/issues/5630
1,738,661,160
I_kwDOIPDwls5nod0o
5,630
ConversationalRetrievalChain unable to use ConversationBufferMemory when return_source_documents=True
{ "login": "rob-rowe", "id": 12414695, "node_id": "MDQ6VXNlcjEyNDE0Njk1", "avatar_url": "https://avatars.githubusercontent.com/u/12414695?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rob-rowe", "html_url": "https://github.com/rob-rowe", "followers_url": "https://api.github.com/users/rob-rowe/followers", "following_url": "https://api.github.com/users/rob-rowe/following{/other_user}", "gists_url": "https://api.github.com/users/rob-rowe/gists{/gist_id}", "starred_url": "https://api.github.com/users/rob-rowe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rob-rowe/subscriptions", "organizations_url": "https://api.github.com/users/rob-rowe/orgs", "repos_url": "https://api.github.com/users/rob-rowe/repos", "events_url": "https://api.github.com/users/rob-rowe/events{/privacy}", "received_events_url": "https://api.github.com/users/rob-rowe/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
9
2023-06-02T18:54:26
2023-11-09T16:13:41
2023-11-09T16:13:40
NONE
null
### System Info LangChain 0.0.188 Python 3.8 ### Who can help? @hwchase17 @agola11 ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [X] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction memory = ConversationBufferMemory(memory_key="chat_history", return_messages=True) qa = ConversationalRetrievalChain.from_llm(OpenAI(temperature =0), vectorstore.as_retriever(), memory=memory, return_source_documents=True) qa({"question": query}) #ValueError" One output key expected, got dict_keys(['answer', 'source_documents']) qa = ConversationalRetrievalChain.from_llm(OpenAI(temperature =0), vectorstore.as_retriever(), return_source_documents=True) qa({"question": query, "chat_history": []}) #...(runs as expected) ### Expected behavior ConversationalRetrievalChain does not work with ConversationBufferMemory and return_source_documents=True. ValueError: One output key expected, got dict_keys(['answer', 'source_documents'])
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5630/reactions", "total_count": 5, "+1": 5, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5630/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5629
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5629/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5629/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5629/events
https://github.com/langchain-ai/langchain/pull/5629
1,738,644,074
PR_kwDOIPDwls5SBsgl
5,629
Fix bedrock llm boto3 client instantiation
{ "login": "seanpmorgan", "id": 18154355, "node_id": "MDQ6VXNlcjE4MTU0MzU1", "avatar_url": "https://avatars.githubusercontent.com/u/18154355?v=4", "gravatar_id": "", "url": "https://api.github.com/users/seanpmorgan", "html_url": "https://github.com/seanpmorgan", "followers_url": "https://api.github.com/users/seanpmorgan/followers", "following_url": "https://api.github.com/users/seanpmorgan/following{/other_user}", "gists_url": "https://api.github.com/users/seanpmorgan/gists{/gist_id}", "starred_url": "https://api.github.com/users/seanpmorgan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/seanpmorgan/subscriptions", "organizations_url": "https://api.github.com/users/seanpmorgan/orgs", "repos_url": "https://api.github.com/users/seanpmorgan/repos", "events_url": "https://api.github.com/users/seanpmorgan/events{/privacy}", "received_events_url": "https://api.github.com/users/seanpmorgan/received_events", "type": "User", "site_admin": false }
[ { "id": 4678528808, "node_id": "LA_kwDOIPDwls8AAAABFtyvKA", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
0
2023-06-02T18:40:00
2023-06-02T19:06:47
2023-06-02T19:04:50
CONTRIBUTOR
null
Same issue as https://github.com/hwchase17/langchain/pull/5574
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5629/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5629/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5629", "html_url": "https://github.com/langchain-ai/langchain/pull/5629", "diff_url": "https://github.com/langchain-ai/langchain/pull/5629.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5629.patch", "merged_at": "2023-06-02T19:04:50" }
https://api.github.com/repos/langchain-ai/langchain/issues/5628
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5628/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5628/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5628/events
https://github.com/langchain-ai/langchain/pull/5628
1,738,627,556
PR_kwDOIPDwls5SBo2I
5,628
Change Anthropic LLM and Chat to be LangFlow friendly
{ "login": "jimwhite", "id": 890972, "node_id": "MDQ6VXNlcjg5MDk3Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/890972?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jimwhite", "html_url": "https://github.com/jimwhite", "followers_url": "https://api.github.com/users/jimwhite/followers", "following_url": "https://api.github.com/users/jimwhite/following{/other_user}", "gists_url": "https://api.github.com/users/jimwhite/gists{/gist_id}", "starred_url": "https://api.github.com/users/jimwhite/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jimwhite/subscriptions", "organizations_url": "https://api.github.com/users/jimwhite/orgs", "repos_url": "https://api.github.com/users/jimwhite/repos", "events_url": "https://api.github.com/users/jimwhite/events{/privacy}", "received_events_url": "https://api.github.com/users/jimwhite/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" } ]
closed
false
null
[]
null
5
2023-06-02T18:28:04
2023-09-18T04:23:48
2023-09-18T04:19:09
NONE
null
Change the Anthropic LLM and Chat classes to use model_name and default parameters the same way others do like OpenAI, Cohere, etc. Added an alias for model to model_name for backwards compatibility. By following the common pattern this will enable the Anthropic PR I'm working on for LangFlow (https://github.com/jimwhite/langflow/tree/anthropic) to work as expected. #### Who can review? Tag maintainers/contributors who might be interested: Models - @hwchase17 - @agola11
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5628/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5628/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5628", "html_url": "https://github.com/langchain-ai/langchain/pull/5628", "diff_url": "https://github.com/langchain-ai/langchain/pull/5628.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5628.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5627
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5627/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5627/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5627/events
https://github.com/langchain-ai/langchain/issues/5627
1,738,622,995
I_kwDOIPDwls5noUgT
5,627
DOC: repetitive parts in Modules pages
{ "login": "leo-gan", "id": 2256422, "node_id": "MDQ6VXNlcjIyNTY0MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/2256422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/leo-gan", "html_url": "https://github.com/leo-gan", "followers_url": "https://api.github.com/users/leo-gan/followers", "following_url": "https://api.github.com/users/leo-gan/following{/other_user}", "gists_url": "https://api.github.com/users/leo-gan/gists{/gist_id}", "starred_url": "https://api.github.com/users/leo-gan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leo-gan/subscriptions", "organizations_url": "https://api.github.com/users/leo-gan/orgs", "repos_url": "https://api.github.com/users/leo-gan/repos", "events_url": "https://api.github.com/users/leo-gan/events{/privacy}", "received_events_url": "https://api.github.com/users/leo-gan/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T18:24:00
2023-06-04T01:43:06
2023-06-04T01:43:06
COLLABORATOR
null
### Issue with current documentation: Pages in Modules: Models, Prompts, Memory, ... They all have repeated parts. See a picture. ![image](https://github.com/hwchase17/langchain/assets/2256422/05514908-87b5-453a-9795-8304612f42bf) ### Idea or request for content: The whole "Go Deeper" section can be removed and instead, the links from removed items added to the above items. For example "Prompt Templates" link is added to the "LLM Prompt Templates" in the above text. Etc. This significantly decreases the size of the page and improves user experience. No more repetitive items. _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5627/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5627/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5626
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5626/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5626/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5626/events
https://github.com/langchain-ai/langchain/pull/5626
1,738,606,123
PR_kwDOIPDwls5SBkIP
5,626
Cjcjameson/rebase 4203 dev2049/pgvector size fix
{ "login": "cjcjameson", "id": 6885889, "node_id": "MDQ6VXNlcjY4ODU4ODk=", "avatar_url": "https://avatars.githubusercontent.com/u/6885889?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cjcjameson", "html_url": "https://github.com/cjcjameson", "followers_url": "https://api.github.com/users/cjcjameson/followers", "following_url": "https://api.github.com/users/cjcjameson/following{/other_user}", "gists_url": "https://api.github.com/users/cjcjameson/gists{/gist_id}", "starred_url": "https://api.github.com/users/cjcjameson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cjcjameson/subscriptions", "organizations_url": "https://api.github.com/users/cjcjameson/orgs", "repos_url": "https://api.github.com/users/cjcjameson/repos", "events_url": "https://api.github.com/users/cjcjameson/events{/privacy}", "received_events_url": "https://api.github.com/users/cjcjameson/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" } ]
closed
false
null
[]
null
1
2023-06-02T18:10:02
2023-09-22T16:01:35
2023-09-22T16:01:34
CONTRIBUTOR
null
#4203 fixes #3660 and #2219 but it's 4 weeks stale and I had other issues so I'm trying to rebasing it. Maybe that will pass CI better and maybe it will "just work" @dev2049
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5626/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5626/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5626", "html_url": "https://github.com/langchain-ai/langchain/pull/5626", "diff_url": "https://github.com/langchain-ai/langchain/pull/5626.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5626.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5625
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5625/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5625/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5625/events
https://github.com/langchain-ai/langchain/pull/5625
1,738,601,116
PR_kwDOIPDwls5SBi_u
5,625
fix markdown text splitter horizontal lines
{ "login": "IlyaMichlin", "id": 1222232, "node_id": "MDQ6VXNlcjEyMjIyMzI=", "avatar_url": "https://avatars.githubusercontent.com/u/1222232?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IlyaMichlin", "html_url": "https://github.com/IlyaMichlin", "followers_url": "https://api.github.com/users/IlyaMichlin/followers", "following_url": "https://api.github.com/users/IlyaMichlin/following{/other_user}", "gists_url": "https://api.github.com/users/IlyaMichlin/gists{/gist_id}", "starred_url": "https://api.github.com/users/IlyaMichlin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IlyaMichlin/subscriptions", "organizations_url": "https://api.github.com/users/IlyaMichlin/orgs", "repos_url": "https://api.github.com/users/IlyaMichlin/repos", "events_url": "https://api.github.com/users/IlyaMichlin/events{/privacy}", "received_events_url": "https://api.github.com/users/IlyaMichlin/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
2
2023-06-02T18:06:25
2023-06-05T23:40:27
2023-06-05T23:40:27
CONTRIBUTOR
null
Fixes #5614 #### Issue The `***` combination produces an exception when used as a seperator in `re.split`. Instead `\*\*\*` should be used for regex exprations. #### Who can review? @eyurtsev
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5625/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5625/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5625", "html_url": "https://github.com/langchain-ai/langchain/pull/5625", "diff_url": "https://github.com/langchain-ai/langchain/pull/5625.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5625.patch", "merged_at": "2023-06-05T23:40:27" }
https://api.github.com/repos/langchain-ai/langchain/issues/5624
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5624/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5624/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5624/events
https://github.com/langchain-ai/langchain/pull/5624
1,738,587,548
PR_kwDOIPDwls5SBf_L
5,624
Refactor SQL dialect prompts to eliminate code duplication.
{ "login": "himalayahall", "id": 90348181, "node_id": "MDQ6VXNlcjkwMzQ4MTgx", "avatar_url": "https://avatars.githubusercontent.com/u/90348181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/himalayahall", "html_url": "https://github.com/himalayahall", "followers_url": "https://api.github.com/users/himalayahall/followers", "following_url": "https://api.github.com/users/himalayahall/following{/other_user}", "gists_url": "https://api.github.com/users/himalayahall/gists{/gist_id}", "starred_url": "https://api.github.com/users/himalayahall/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/himalayahall/subscriptions", "organizations_url": "https://api.github.com/users/himalayahall/orgs", "repos_url": "https://api.github.com/users/himalayahall/repos", "events_url": "https://api.github.com/users/himalayahall/events{/privacy}", "received_events_url": "https://api.github.com/users/himalayahall/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700892, "node_id": "LA_kwDOIPDwls8AAAABUpid3A", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:refactor", "name": "auto:refactor", "color": "D4C5F9", "default": false, "description": "A large refactor of a feature(s) or restructuring of many files" } ]
closed
false
null
[]
null
6
2023-06-02T17:55:22
2023-11-07T04:20:15
2023-11-07T04:20:14
NONE
null
Refactored code to eliminate multiple copies of the query prompt (prompt per dialect). Now, there is a single copy of the prompt and all placeholders are encapsulated in **SqlQueryDialect** enumeration class. This should make it much easier and less error to add new SQL dialects and/or extend prompt template (e.g. adding new hints for the LLM). Code changes have been formatted, linted, and tested. #### Who can review? @hwchase17
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5624/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5624/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5624", "html_url": "https://github.com/langchain-ai/langchain/pull/5624", "diff_url": "https://github.com/langchain-ai/langchain/pull/5624.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5624.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5623
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5623/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5623/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5623/events
https://github.com/langchain-ai/langchain/issues/5623
1,738,498,708
I_kwDOIPDwls5nn2KU
5,623
cannot import name 'FigmaFileLoader'
{ "login": "davidvesp", "id": 100422627, "node_id": "U_kgDOBfxT4w", "avatar_url": "https://avatars.githubusercontent.com/u/100422627?v=4", "gravatar_id": "", "url": "https://api.github.com/users/davidvesp", "html_url": "https://github.com/davidvesp", "followers_url": "https://api.github.com/users/davidvesp/followers", "following_url": "https://api.github.com/users/davidvesp/following{/other_user}", "gists_url": "https://api.github.com/users/davidvesp/gists{/gist_id}", "starred_url": "https://api.github.com/users/davidvesp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davidvesp/subscriptions", "organizations_url": "https://api.github.com/users/davidvesp/orgs", "repos_url": "https://api.github.com/users/davidvesp/repos", "events_url": "https://api.github.com/users/davidvesp/events{/privacy}", "received_events_url": "https://api.github.com/users/davidvesp/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-02T16:39:41
2023-06-03T01:48:51
2023-06-02T21:58:42
NONE
null
### System Info langchain==0.0.189 os:windows11 python=3.10.11 ### Who can help? _No response_ ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [X] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction from langchain.document_loaders import FigmaFileLoader ### Expected behavior expected: load the module error: ImportError: cannot import name 'FigmaFileLoader' from 'langchain.document_loaders' (C:\Users\xxx\AppData\Local\miniconda3\envs\xxx\lib\site-packages\langchain\document_loaders\__init__.py) comments: checked the langchain\document_loaders\__init__.py and there is no reference to FigmaFileLoader
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5623/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5623/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5622
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5622/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5622/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5622/events
https://github.com/langchain-ai/langchain/issues/5622
1,738,473,740
I_kwDOIPDwls5nnwEM
5,622
DOC: can't execute the code of Async API for Chain
{ "login": "liuyingduo", "id": 56947550, "node_id": "MDQ6VXNlcjU2OTQ3NTUw", "avatar_url": "https://avatars.githubusercontent.com/u/56947550?v=4", "gravatar_id": "", "url": "https://api.github.com/users/liuyingduo", "html_url": "https://github.com/liuyingduo", "followers_url": "https://api.github.com/users/liuyingduo/followers", "following_url": "https://api.github.com/users/liuyingduo/following{/other_user}", "gists_url": "https://api.github.com/users/liuyingduo/gists{/gist_id}", "starred_url": "https://api.github.com/users/liuyingduo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/liuyingduo/subscriptions", "organizations_url": "https://api.github.com/users/liuyingduo/orgs", "repos_url": "https://api.github.com/users/liuyingduo/repos", "events_url": "https://api.github.com/users/liuyingduo/events{/privacy}", "received_events_url": "https://api.github.com/users/liuyingduo/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-02T16:16:48
2023-09-10T16:08:33
2023-09-10T16:08:32
NONE
null
### Issue with current documentation: ![image](https://github.com/hwchase17/langchain/assets/56947550/418be26f-62e3-4719-bfc8-a81c89b1845f) ### Idea or request for content: The program is stuck and will not return
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5622/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5622/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5621
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5621/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5621/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5621/events
https://github.com/langchain-ai/langchain/pull/5621
1,738,437,991
PR_kwDOIPDwls5SA_a-
5,621
Dev2049/add argilla callback
{ "login": "dev2049", "id": 130488702, "node_id": "U_kgDOB8cZfg", "avatar_url": "https://avatars.githubusercontent.com/u/130488702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev2049", "html_url": "https://github.com/dev2049", "followers_url": "https://api.github.com/users/dev2049/followers", "following_url": "https://api.github.com/users/dev2049/following{/other_user}", "gists_url": "https://api.github.com/users/dev2049/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev2049/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev2049/subscriptions", "organizations_url": "https://api.github.com/users/dev2049/orgs", "repos_url": "https://api.github.com/users/dev2049/repos", "events_url": "https://api.github.com/users/dev2049/events{/privacy}", "received_events_url": "https://api.github.com/users/dev2049/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T15:51:47
2023-06-02T16:05:08
2023-06-02T16:05:07
CONTRIBUTOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5621/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5621/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5621", "html_url": "https://github.com/langchain-ai/langchain/pull/5621", "diff_url": "https://github.com/langchain-ai/langchain/pull/5621.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5621.patch", "merged_at": "2023-06-02T16:05:07" }
https://api.github.com/repos/langchain-ai/langchain/issues/5620
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5620/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5620/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5620/events
https://github.com/langchain-ai/langchain/pull/5620
1,738,425,416
PR_kwDOIPDwls5SA8u-
5,620
bump 189
{ "login": "dev2049", "id": 130488702, "node_id": "U_kgDOB8cZfg", "avatar_url": "https://avatars.githubusercontent.com/u/130488702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev2049", "html_url": "https://github.com/dev2049", "followers_url": "https://api.github.com/users/dev2049/followers", "following_url": "https://api.github.com/users/dev2049/following{/other_user}", "gists_url": "https://api.github.com/users/dev2049/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev2049/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev2049/subscriptions", "organizations_url": "https://api.github.com/users/dev2049/orgs", "repos_url": "https://api.github.com/users/dev2049/repos", "events_url": "https://api.github.com/users/dev2049/events{/privacy}", "received_events_url": "https://api.github.com/users/dev2049/received_events", "type": "User", "site_admin": false }
[ { "id": 5010622926, "node_id": "LA_kwDOIPDwls8AAAABKqgJzg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/release", "name": "release", "color": "07D4BE", "default": false, "description": "" } ]
closed
false
null
[]
null
0
2023-06-02T15:41:43
2023-06-02T16:09:24
2023-06-02T16:09:23
CONTRIBUTOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5620/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5620/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5620", "html_url": "https://github.com/langchain-ai/langchain/pull/5620", "diff_url": "https://github.com/langchain-ai/langchain/pull/5620.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5620.patch", "merged_at": "2023-06-02T16:09:23" }
https://api.github.com/repos/langchain-ai/langchain/issues/5619
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5619/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5619/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5619/events
https://github.com/langchain-ai/langchain/pull/5619
1,738,284,161
PR_kwDOIPDwls5SAdvh
5,619
Added SingleStoreDB Vector Store
{ "login": "volodymyr-memsql", "id": 57520563, "node_id": "MDQ6VXNlcjU3NTIwNTYz", "avatar_url": "https://avatars.githubusercontent.com/u/57520563?v=4", "gravatar_id": "", "url": "https://api.github.com/users/volodymyr-memsql", "html_url": "https://github.com/volodymyr-memsql", "followers_url": "https://api.github.com/users/volodymyr-memsql/followers", "following_url": "https://api.github.com/users/volodymyr-memsql/following{/other_user}", "gists_url": "https://api.github.com/users/volodymyr-memsql/gists{/gist_id}", "starred_url": "https://api.github.com/users/volodymyr-memsql/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/volodymyr-memsql/subscriptions", "organizations_url": "https://api.github.com/users/volodymyr-memsql/orgs", "repos_url": "https://api.github.com/users/volodymyr-memsql/repos", "events_url": "https://api.github.com/users/volodymyr-memsql/events{/privacy}", "received_events_url": "https://api.github.com/users/volodymyr-memsql/received_events", "type": "User", "site_admin": false }
[ { "id": 4678528817, "node_id": "LA_kwDOIPDwls8AAAABFtyvMQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" }, { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" }, { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" } ]
closed
false
null
[]
null
1
2023-06-02T14:13:59
2023-06-16T11:19:48
2023-06-08T03:45:33
CONTRIBUTOR
null
- Added `SingleStoreDB` vector store, which is a wrapper over the SingleStore DB database, that can be used as a vector storage and has an efficient similarity search. - Added integration tests for the vector store - Added jupyter notebook with the example @dev2049
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5619/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5619/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5619", "html_url": "https://github.com/langchain-ai/langchain/pull/5619", "diff_url": "https://github.com/langchain-ai/langchain/pull/5619.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5619.patch", "merged_at": "2023-06-08T03:45:33" }
https://api.github.com/repos/langchain-ai/langchain/issues/5618
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5618/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5618/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5618/events
https://github.com/langchain-ai/langchain/pull/5618
1,738,262,804
PR_kwDOIPDwls5SAZAu
5,618
[RFC] Run Evaluator Chains
{ "login": "vowelparrot", "id": 130414180, "node_id": "U_kgDOB8X2ZA", "avatar_url": "https://avatars.githubusercontent.com/u/130414180?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vowelparrot", "html_url": "https://github.com/vowelparrot", "followers_url": "https://api.github.com/users/vowelparrot/followers", "following_url": "https://api.github.com/users/vowelparrot/following{/other_user}", "gists_url": "https://api.github.com/users/vowelparrot/gists{/gist_id}", "starred_url": "https://api.github.com/users/vowelparrot/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vowelparrot/subscriptions", "organizations_url": "https://api.github.com/users/vowelparrot/orgs", "repos_url": "https://api.github.com/users/vowelparrot/repos", "events_url": "https://api.github.com/users/vowelparrot/events{/privacy}", "received_events_url": "https://api.github.com/users/vowelparrot/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T14:01:39
2023-06-05T22:58:27
2023-06-05T20:01:10
CONTRIBUTOR
null
Will try to land https://github.com/hwchase17/langchain/pull/5750 first Pros: - Fits many but not all feedback applications. - Maintains a flexible base with configurable implementations. - Doesn't implement THAT many new classes for the core logic Cons: - doesn't handle pairwise/group evals - trajectory evals are a bit hacky ( you have to remember to turn on when tracing rather than building it from the run object) - possibly too opinionated by forcing an input mapper and output parser? - Doesn't (yet) allow easy composability of the reasoning step (most do COT built in) - Most of the scores are binary - no nuance or more advanced logic. Doesn't (yet) decouple the scoring logic from the core of the prompt - Not sure if the creation functions are actually much better than creating a child and making a complicated constructor Example making 5 different evaluators: <img width="971" alt="image" src="https://github.com/hwchase17/langchain/assets/130414180/901d8d78-5dee-4f43-acd6-7b0589182cb7">
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5618/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5618/timeline
null
null
true
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5618", "html_url": "https://github.com/langchain-ai/langchain/pull/5618", "diff_url": "https://github.com/langchain-ai/langchain/pull/5618.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5618.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5617
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5617/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5617/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5617/events
https://github.com/langchain-ai/langchain/pull/5617
1,738,248,458
PR_kwDOIPDwls5SAV4_
5,617
feat: add `UnstructuredExcelLoader` for `.xlsx` and `.xls` files
{ "login": "MthwRobinson", "id": 1635179, "node_id": "MDQ6VXNlcjE2MzUxNzk=", "avatar_url": "https://avatars.githubusercontent.com/u/1635179?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MthwRobinson", "html_url": "https://github.com/MthwRobinson", "followers_url": "https://api.github.com/users/MthwRobinson/followers", "following_url": "https://api.github.com/users/MthwRobinson/following{/other_user}", "gists_url": "https://api.github.com/users/MthwRobinson/gists{/gist_id}", "starred_url": "https://api.github.com/users/MthwRobinson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MthwRobinson/subscriptions", "organizations_url": "https://api.github.com/users/MthwRobinson/orgs", "repos_url": "https://api.github.com/users/MthwRobinson/repos", "events_url": "https://api.github.com/users/MthwRobinson/events{/privacy}", "received_events_url": "https://api.github.com/users/MthwRobinson/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T13:52:44
2023-06-03T19:44:13
2023-06-03T19:44:12
CONTRIBUTOR
null
# Unstructured Excel Loader Adds an `UnstructuredExcelLoader` class for `.xlsx` and `.xls` files. Works with `unstructured>=0.6.7`. A plain text representation of the Excel file will be available under the `page_content` attribute in the doc. If you use the loader in `"elements"` mode, an HTML representation of the Excel file will be available under the `text_as_html` metadata key. Each sheet in the Excel document is its own document. ### Testing ```python from langchain.document_loaders import UnstructuredExcelLoader loader = UnstructuredExcelLoader( "example_data/stanley-cups.xlsx", mode="elements" ) docs = loader.load() ``` ## Who can review? @hwchase17 @eyurtsev
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5617/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5617/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5617", "html_url": "https://github.com/langchain-ai/langchain/pull/5617", "diff_url": "https://github.com/langchain-ai/langchain/pull/5617.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5617.patch", "merged_at": "2023-06-03T19:44:12" }
https://api.github.com/repos/langchain-ai/langchain/issues/5616
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5616/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5616/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5616/events
https://github.com/langchain-ai/langchain/pull/5616
1,738,132,767
PR_kwDOIPDwls5R_8mK
5,616
Rm Template Title
{ "login": "vowelparrot", "id": 130414180, "node_id": "U_kgDOB8X2ZA", "avatar_url": "https://avatars.githubusercontent.com/u/130414180?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vowelparrot", "html_url": "https://github.com/vowelparrot", "followers_url": "https://api.github.com/users/vowelparrot/followers", "following_url": "https://api.github.com/users/vowelparrot/following{/other_user}", "gists_url": "https://api.github.com/users/vowelparrot/gists{/gist_id}", "starred_url": "https://api.github.com/users/vowelparrot/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vowelparrot/subscriptions", "organizations_url": "https://api.github.com/users/vowelparrot/orgs", "repos_url": "https://api.github.com/users/vowelparrot/repos", "events_url": "https://api.github.com/users/vowelparrot/events{/privacy}", "received_events_url": "https://api.github.com/users/vowelparrot/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T12:40:39
2023-06-02T13:54:57
2023-06-02T13:54:56
CONTRIBUTOR
null
Remove the redundant title from the PR template #### Before submitting #### Who can review? @dev2049
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5616/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5616/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5616", "html_url": "https://github.com/langchain-ai/langchain/pull/5616", "diff_url": "https://github.com/langchain-ai/langchain/pull/5616.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5616.patch", "merged_at": "2023-06-02T13:54:56" }
https://api.github.com/repos/langchain-ai/langchain/issues/5615
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5615/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5615/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5615/events
https://github.com/langchain-ai/langchain/issues/5615
1,738,108,763
I_kwDOIPDwls5nmW9b
5,615
Opensearch for Indexing and Retrieval
{ "login": "finch986", "id": 3706696, "node_id": "MDQ6VXNlcjM3MDY2OTY=", "avatar_url": "https://avatars.githubusercontent.com/u/3706696?v=4", "gravatar_id": "", "url": "https://api.github.com/users/finch986", "html_url": "https://github.com/finch986", "followers_url": "https://api.github.com/users/finch986/followers", "following_url": "https://api.github.com/users/finch986/following{/other_user}", "gists_url": "https://api.github.com/users/finch986/gists{/gist_id}", "starred_url": "https://api.github.com/users/finch986/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/finch986/subscriptions", "organizations_url": "https://api.github.com/users/finch986/orgs", "repos_url": "https://api.github.com/users/finch986/repos", "events_url": "https://api.github.com/users/finch986/events{/privacy}", "received_events_url": "https://api.github.com/users/finch986/received_events", "type": "User", "site_admin": false }
[]
open
false
null
[]
null
3
2023-06-02T12:25:19
2023-11-05T13:43:51
null
NONE
null
### System Info I am using Python for INdexing Document to OpenELastic search Python for Indexing----> documents = loader.load() text_splitter = CharacterTextSplitter(chunk_size=1000, chunk_overlap=0) docs = text_splitter.split_documents(documents) vs = OpenSearchVectorSearch.from_documents( docs, embeddings, opensearch_url="https://search-bterai-opensearch-gmtgf5ukflbg77xlwenvwko4gm.us-west-2.es.amazonaws.com", http_auth=("XXXX", "XXXX"), use_ssl = False, verify_certs = False, ssl_assert_hostname = False, ssl_show_warn = False, index_name="test_sidsfarm") NodejS for Querying const client = new Client({ nodes: [process.env.OPENSEARCH_URL ?? "https://X:X@search-bterai-opensearch-gmtgf5ukflbg77xlwenvwko4gm.us-west-2.es.amazonaws.com"], }); const vectorStore = new OpenSearchVectorStore(new OpenAIEmbeddings(), { client, indexName: "test_sidsfarm" }); const chain = VectorDBQAChain.fromLLM(model, vectorStore, { returnSourceDocuments: true, }); res = await chain.call({ query: input }); Its Giving me error below , Please help!! failed to create query: Field 'embedding' is not knn_vector type. ### Who can help? @hwchase17 ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [X] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ALready mentioned steps above ### Expected behavior It should work out of the box irrespective of platforms
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5615/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5615/timeline
null
null
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5614
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5614/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5614/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5614/events
https://github.com/langchain-ai/langchain/issues/5614
1,738,102,515
I_kwDOIPDwls5nmVbz
5,614
MarkdownTextSplitter: multiple repeat at position 4 (line 3, column 2)
{ "login": "communiteq", "id": 5292699, "node_id": "MDQ6VXNlcjUyOTI2OTk=", "avatar_url": "https://avatars.githubusercontent.com/u/5292699?v=4", "gravatar_id": "", "url": "https://api.github.com/users/communiteq", "html_url": "https://github.com/communiteq", "followers_url": "https://api.github.com/users/communiteq/followers", "following_url": "https://api.github.com/users/communiteq/following{/other_user}", "gists_url": "https://api.github.com/users/communiteq/gists{/gist_id}", "starred_url": "https://api.github.com/users/communiteq/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/communiteq/subscriptions", "organizations_url": "https://api.github.com/users/communiteq/orgs", "repos_url": "https://api.github.com/users/communiteq/repos", "events_url": "https://api.github.com/users/communiteq/events{/privacy}", "received_events_url": "https://api.github.com/users/communiteq/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T12:20:41
2023-06-05T23:40:28
2023-06-05T23:40:28
NONE
null
### System Info langchain 0.0.188 python 3.8.10 ### Who can help? _No response_ ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [X] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ``` from langchain.docstore.document import Document from langchain.text_splitter import MarkdownTextSplitter # of course this is part of a larger markdown document, but this is the minimal string to reproduce txt = "\n\n***\n\n" doc = Document(page_content=txt) markdown_splitter = MarkdownTextSplitter(chunk_size=1000, chunk_overlap=0) splitted = markdown_splitter.split_documents([doc]) ``` ``` Traceback (most recent call last): File "t.py", line 9, in <module> splitted = markdown_splitter.split_documents([doc]) File "/home/richard/.local/lib/python3.8/site-packages/langchain/text_splitter.py", line 101, in split_documents return self.create_documents(texts, metadatas=metadatas) File "/home/richard/.local/lib/python3.8/site-packages/langchain/text_splitter.py", line 88, in create_documents for chunk in self.split_text(text): File "/home/richard/.local/lib/python3.8/site-packages/langchain/text_splitter.py", line 369, in split_text return self._split_text(text, self._separators) File "/home/richard/.local/lib/python3.8/site-packages/langchain/text_splitter.py", line 346, in _split_text splits = _split_text(text, separator, self._keep_separator) File "/home/richard/.local/lib/python3.8/site-packages/langchain/text_splitter.py", line 37, in _split_text _splits = re.split(f"({separator})", text) File "/usr/lib/python3.8/re.py", line 231, in split return _compile(pattern, flags).split(string, maxsplit) File "/usr/lib/python3.8/re.py", line 304, in _compile p = sre_compile.compile(pattern, flags) File "/usr/lib/python3.8/sre_compile.py", line 764, in compile p = sre_parse.parse(p, flags) File "/usr/lib/python3.8/sre_parse.py", line 948, in parse p = _parse_sub(source, state, flags & SRE_FLAG_VERBOSE, 0) File "/usr/lib/python3.8/sre_parse.py", line 443, in _parse_sub itemsappend(_parse(source, state, verbose, nested + 1, File "/usr/lib/python3.8/sre_parse.py", line 834, in _parse p = _parse_sub(source, state, sub_verbose, nested + 1) File "/usr/lib/python3.8/sre_parse.py", line 443, in _parse_sub itemsappend(_parse(source, state, verbose, nested + 1, File "/usr/lib/python3.8/sre_parse.py", line 671, in _parse raise source.error("multiple repeat", re.error: multiple repeat at position 4 (line 3, column 2) ``` ### Expected behavior splitted contains splitted markdown and no errors occur
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5614/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5614/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5613
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5613/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5613/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5613/events
https://github.com/langchain-ai/langchain/pull/5613
1,738,029,618
PR_kwDOIPDwls5R_l3w
5,613
Scores are explained in vectorestore docs
{ "login": "berkedilekoglu", "id": 19657350, "node_id": "MDQ6VXNlcjE5NjU3MzUw", "avatar_url": "https://avatars.githubusercontent.com/u/19657350?v=4", "gravatar_id": "", "url": "https://api.github.com/users/berkedilekoglu", "html_url": "https://github.com/berkedilekoglu", "followers_url": "https://api.github.com/users/berkedilekoglu/followers", "following_url": "https://api.github.com/users/berkedilekoglu/following{/other_user}", "gists_url": "https://api.github.com/users/berkedilekoglu/gists{/gist_id}", "starred_url": "https://api.github.com/users/berkedilekoglu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/berkedilekoglu/subscriptions", "organizations_url": "https://api.github.com/users/berkedilekoglu/orgs", "repos_url": "https://api.github.com/users/berkedilekoglu/repos", "events_url": "https://api.github.com/users/berkedilekoglu/events{/privacy}", "received_events_url": "https://api.github.com/users/berkedilekoglu/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
2
2023-06-02T11:33:24
2023-06-06T03:39:49
2023-06-06T03:39:49
CONTRIBUTOR
null
# Scores in Vectorestores' Docs Are Explained Following vectorestores can return scores with similar documents by using `similarity_search_with_score`: - chroma - docarray_hnsw - docarray_in_memory - faiss - myscale - qdrant - supabase - vectara - weaviate However, in documents, these scores were either not explained at all or explained in a way that could lead to misunderstandings (e.g., FAISS). For instance in FAISS document: if we consider the score returned by the function as a similarity score, we understand that a document returning a higher score is more similar to the source document. However, since the scores returned by the function are distance scores, we should understand that smaller scores correspond to more similar documents. For the libraries other than Vectara, I wrote the scores they use by investigating from the source libraries. Since I couldn't be certain about the score metric used by Vectara, I didn't make any changes in its documentation. The links mentioned in Vectara's documentation became broken due to updates, so I replaced them with working ones. VectorStores / Retrievers / Memory - @dev2049 my twitter: [berkedilekoglu](https://twitter.com/berkedilekoglu)
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5613/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5613/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5613", "html_url": "https://github.com/langchain-ai/langchain/pull/5613", "diff_url": "https://github.com/langchain-ai/langchain/pull/5613.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5613.patch", "merged_at": "2023-06-06T03:39:49" }
https://api.github.com/repos/langchain-ai/langchain/issues/5612
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5612/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5612/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5612/events
https://github.com/langchain-ai/langchain/pull/5612
1,737,972,899
PR_kwDOIPDwls5R_ZOb
5,612
PassthroughOutputParser
{ "login": "nfcampos", "id": 56902, "node_id": "MDQ6VXNlcjU2OTAy", "avatar_url": "https://avatars.githubusercontent.com/u/56902?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nfcampos", "html_url": "https://github.com/nfcampos", "followers_url": "https://api.github.com/users/nfcampos/followers", "following_url": "https://api.github.com/users/nfcampos/following{/other_user}", "gists_url": "https://api.github.com/users/nfcampos/gists{/gist_id}", "starred_url": "https://api.github.com/users/nfcampos/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nfcampos/subscriptions", "organizations_url": "https://api.github.com/users/nfcampos/orgs", "repos_url": "https://api.github.com/users/nfcampos/repos", "events_url": "https://api.github.com/users/nfcampos/events{/privacy}", "received_events_url": "https://api.github.com/users/nfcampos/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700863, "node_id": "LA_kwDOIPDwls8AAAABUpidvw", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:enhancement", "name": "auto:enhancement", "color": "C2E0C6", "default": false, "description": "A large net-new component, integration, or chain. Use sparingly. The largest features" } ]
closed
false
null
[]
null
0
2023-06-02T10:59:30
2023-07-26T07:36:25
2023-07-26T07:36:25
COLLABORATOR
null
# Your PR Title (What it does) <!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5612/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5612/timeline
null
null
true
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5612", "html_url": "https://github.com/langchain-ai/langchain/pull/5612", "diff_url": "https://github.com/langchain-ai/langchain/pull/5612.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5612.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5611
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5611/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5611/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5611/events
https://github.com/langchain-ai/langchain/issues/5611
1,737,940,580
I_kwDOIPDwls5nlt5k
5,611
create_csv_agent: How to save a dataframe once information has been extracted using create_csv_agent.
{ "login": "dhruvshandilya-bidgely", "id": 134032738, "node_id": "U_kgDOB_0tYg", "avatar_url": "https://avatars.githubusercontent.com/u/134032738?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhruvshandilya-bidgely", "html_url": "https://github.com/dhruvshandilya-bidgely", "followers_url": "https://api.github.com/users/dhruvshandilya-bidgely/followers", "following_url": "https://api.github.com/users/dhruvshandilya-bidgely/following{/other_user}", "gists_url": "https://api.github.com/users/dhruvshandilya-bidgely/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhruvshandilya-bidgely/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhruvshandilya-bidgely/subscriptions", "organizations_url": "https://api.github.com/users/dhruvshandilya-bidgely/orgs", "repos_url": "https://api.github.com/users/dhruvshandilya-bidgely/repos", "events_url": "https://api.github.com/users/dhruvshandilya-bidgely/events{/privacy}", "received_events_url": "https://api.github.com/users/dhruvshandilya-bidgely/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
9
2023-06-02T10:38:14
2023-09-30T16:06:49
2023-09-30T16:06:48
NONE
null
### Issue you'd like to raise. So, I am working on a project that involves data extraction from csv files and involves creating charts and graphs from them. below is a snippet of code for the agent that I have created : ```python tools = [ python_repl_tool, csv_ident_tool, csv_extractor_tool, ] # Adding memory to our agent from langchain.agents import ZeroShotAgent from langchain.memory import ConversationBufferMemory prefix = """Have a conversation with a human, answering the following questions as best you can. You have access to the following tools:""" suffix = """Begin!" {chat_history} Question: {input} {agent_scratchpad}""" prompt = ZeroShotAgent.create_prompt( tools=tools, prefix=prefix, suffix=suffix, input_variables=["input", "chat_history", "agent_scratchpad"] ) memory = ConversationBufferMemory(memory_key="chat_history") # Creating our agent from langchain.chains import LLMChain from langchain.llms import OpenAI from langchain.agents import AgentExecutor llm_chain = LLMChain(llm=OpenAI(temperature=0), prompt=prompt) agent = ZeroShotAgent(llm_chain=llm_chain, tools=tools, verbose=True) agent_chain = AgentExecutor.from_agent_and_tools(agent=agent, tools=tools, verbose=True, memory=memory) ``` Where csv_ident tool is a custom tool I created to identify csv file in a prompt. Example: prompt : What is the mean of age in data.csv? completion : data.csv csv_extractor_tool is as follows : ```python def csv_extractor(json_request: str): ''' Useful for extracting data from a csv file. Takes a JSON dictionary as input in the form: { "prompt":"<question>", "path":"<file_name>" } Example: { "prompt":"Find the maximum age in xyz.csv", "path":"xyz.csv" } Args: request (str): The JSON dictionary input string. Returns: The required information from csv file. ''' arguments_dictionary = json.loads(json_request) question = arguments_dictionary["prompt"] file_name = arguments_dictionary["path"] csv_agent = create_csv_agent(llm=llm,path=file_name,verbose=True) return csv_agent.run(question) request_format = '{{"prompt":"<question>","path":"<file_name>"}}' description = f'Useful for working with a csv file. Input should be JSON in the following format: {request_format}' csv_extractor_tool = Tool( name="csv_extractor", func=csv_extractor, description=description, verbose=True, ) ``` So I am creating a csv_agent and passing the prompt and path to it. This handles the data extraction type tasks easily, but I produces poor results while making plots. Till now I have tried creating a new LLMChain in which I passed prompt comprising of several examples as given below: ``` input :{{"prompt":"Load data.csv and find the mean of age column.","path":"data.csv"}} completion :import pandas as pd df = pd.read_csv('data.csv') df = df['Age'].mean() print(df) df.to_csv('.\\bin\\file.csv') ``` But this does not work as the LLM cannot know beforehand what are the exact column name and generating such a code is short-sighted and produces errors. I have also tried taking a callbacks based approach where in the on_tool_end() function I was trying to save the dataframe. Is there any way to make csv_agent save the dataframe in a bin folder after it is done extracting the information, which I can pass to my custom plot creating tool. ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5611/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5611/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5610
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5610/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5610/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5610/events
https://github.com/langchain-ai/langchain/pull/5610
1,737,934,232
PR_kwDOIPDwls5R_Qmm
5,610
removing client+namespace in favor of collection
{ "login": "P-E-B", "id": 38215315, "node_id": "MDQ6VXNlcjM4MjE1MzE1", "avatar_url": "https://avatars.githubusercontent.com/u/38215315?v=4", "gravatar_id": "", "url": "https://api.github.com/users/P-E-B", "html_url": "https://github.com/P-E-B", "followers_url": "https://api.github.com/users/P-E-B/followers", "following_url": "https://api.github.com/users/P-E-B/following{/other_user}", "gists_url": "https://api.github.com/users/P-E-B/gists{/gist_id}", "starred_url": "https://api.github.com/users/P-E-B/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/P-E-B/subscriptions", "organizations_url": "https://api.github.com/users/P-E-B/orgs", "repos_url": "https://api.github.com/users/P-E-B/repos", "events_url": "https://api.github.com/users/P-E-B/events{/privacy}", "received_events_url": "https://api.github.com/users/P-E-B/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T10:34:04
2023-06-03T23:27:32
2023-06-03T23:27:32
CONTRIBUTOR
null
removing client+namespace in favor of collection for an easier instantiation and to be similar to the typescript library @dev2049
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5610/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5610/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5610", "html_url": "https://github.com/langchain-ai/langchain/pull/5610", "diff_url": "https://github.com/langchain-ai/langchain/pull/5610.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5610.patch", "merged_at": "2023-06-03T23:27:32" }
https://api.github.com/repos/langchain-ai/langchain/issues/5609
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5609/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5609/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5609/events
https://github.com/langchain-ai/langchain/pull/5609
1,737,917,917
PR_kwDOIPDwls5R_M9N
5,609
Raise an exception in MKRL and Chat Output Parsers if parsing text which contains both an action and a final answer
{ "login": "nathan-az", "id": 42650258, "node_id": "MDQ6VXNlcjQyNjUwMjU4", "avatar_url": "https://avatars.githubusercontent.com/u/42650258?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nathan-az", "html_url": "https://github.com/nathan-az", "followers_url": "https://api.github.com/users/nathan-az/followers", "following_url": "https://api.github.com/users/nathan-az/following{/other_user}", "gists_url": "https://api.github.com/users/nathan-az/gists{/gist_id}", "starred_url": "https://api.github.com/users/nathan-az/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nathan-az/subscriptions", "organizations_url": "https://api.github.com/users/nathan-az/orgs", "repos_url": "https://api.github.com/users/nathan-az/repos", "events_url": "https://api.github.com/users/nathan-az/events{/privacy}", "received_events_url": "https://api.github.com/users/nathan-az/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T10:24:47
2023-06-05T00:19:22
2023-06-04T21:40:49
CONTRIBUTOR
null
Raises exception if OutputParsers receive a response with both a valid action and a final answer Currently, if an OutputParser receives a response which includes both an action and a final answer, they return a FinalAnswer object. This allows the parser to accept responses which propose an action and hallucinate an answer without the action being parsed or taken by the agent. This PR changes the logic to: 1. store a variable checking whether a response contains the `FINAL_ANSWER_ACTION` (this is the easier condition to check). 2. store a variable checking whether the response contains a valid action 3. if both are present, raise a new exception stating that both are present 4. if an action is present, return an AgentAction 5. if an answer is present, return an AgentAnswer 6. if neither is present, raise the relevant exception based around the action format (these have been kept consistent with the prior exception messages) Disclaimer: * Existing mock data included strings which did include an action and an answer. This might indicate that prioritising returning AgentAnswer was always correct, and I am patching out desired behaviour? @hwchase17 to advice. Curious if there are allowed cases where this is not hallucinating, and we do want the LLM to output an action which isn't taken. * I have not passed `send_to_llm` through this new exception Fixes #5601 ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @hwchase17 - project lead @vowelparrot
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5609/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5609/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5609", "html_url": "https://github.com/langchain-ai/langchain/pull/5609", "diff_url": "https://github.com/langchain-ai/langchain/pull/5609.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5609.patch", "merged_at": "2023-06-04T21:40:49" }
https://api.github.com/repos/langchain-ai/langchain/issues/5608
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5608/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5608/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5608/events
https://github.com/langchain-ai/langchain/issues/5608
1,737,908,101
I_kwDOIPDwls5nll-F
5,608
Issue: ConversationalRetrievalQAChain returns the qaTemplate condensed question as the first token
{ "login": "seakkus", "id": 2848160, "node_id": "MDQ6VXNlcjI4NDgxNjA=", "avatar_url": "https://avatars.githubusercontent.com/u/2848160?v=4", "gravatar_id": "", "url": "https://api.github.com/users/seakkus", "html_url": "https://github.com/seakkus", "followers_url": "https://api.github.com/users/seakkus/followers", "following_url": "https://api.github.com/users/seakkus/following{/other_user}", "gists_url": "https://api.github.com/users/seakkus/gists{/gist_id}", "starred_url": "https://api.github.com/users/seakkus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/seakkus/subscriptions", "organizations_url": "https://api.github.com/users/seakkus/orgs", "repos_url": "https://api.github.com/users/seakkus/repos", "events_url": "https://api.github.com/users/seakkus/events{/privacy}", "received_events_url": "https://api.github.com/users/seakkus/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
9
2023-06-02T10:19:03
2023-09-08T04:02:54
2023-06-21T08:29:46
NONE
null
### Issue you'd like to raise. I am using the ConversationalRetrievalQAChain to retrieve answers for questions while condensing the chat history to a standalone question. The issue I am facing is that the first token returned by the chain.call handleLLMNewToken is the standalone condensed question when there is a chat_history provided. Ideally, I do not want the condensed question to be sent via the handleLLMNewToken instead I want just the answer tokens. Is there any way to achieve that? Here is the code I am running: `import { CallbackManager } from "langchain/callbacks"; import { ConversationalRetrievalQAChain } from "langchain/chains"; import { ChatOpenAI } from "langchain/chat_models"; import { PineconeStore } from "langchain/vectorstores/pinecone"; const CONDENSE_PROMPT = `Given the following conversation and a follow up question, rephrase the follow up question to be a standalone question. Chat History: {chat_history} Follow Up Input: {question} Standalone question:`; const QA_PROMPT = `You are an AI assistant. Use the following pieces of context to answer the question at the end. If you don't know the answer, just say you don't know. DO NOT try to make up an answer. If the question is not related to the context, politely respond that you are tuned to only answer questions that are related to the context. {context} Question: {question} Helpful answer in markdown:`; export const makeChain = ( vectorstore: PineconeStore, onTokenReceived: (data: string) => void ) => { const model = new ChatOpenAI({ temperature: 0, streaming: true, modelName: "gpt-3.5-turbo", openAIApiKey: process.env.OPENAI_API_KEY as string, callbackManager: CallbackManager.fromHandlers({ async handleLLMNewToken(token) { onTokenReceived(token); }, async handleLLMEnd(result) {}, }), }); return ConversationalRetrievalQAChain.fromLLM( model, vectorstore.asRetriever(), { qaTemplate: QA_PROMPT, questionGeneratorTemplate: CONDENSE_PROMPT, returnSourceDocuments: true, // The number of source documents returned is 4 by default } ); }; ` ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5608/reactions", "total_count": 3, "+1": 3, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5608/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5607
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5607/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5607/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5607/events
https://github.com/langchain-ai/langchain/issues/5607
1,737,860,885
I_kwDOIPDwls5nlacV
5,607
Issue: How to let Agent act in a more consistent way, e.g., not jumping from a tool to another before a task is finished
{ "login": "jasonliu119", "id": 9408153, "node_id": "MDQ6VXNlcjk0MDgxNTM=", "avatar_url": "https://avatars.githubusercontent.com/u/9408153?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jasonliu119", "html_url": "https://github.com/jasonliu119", "followers_url": "https://api.github.com/users/jasonliu119/followers", "following_url": "https://api.github.com/users/jasonliu119/following{/other_user}", "gists_url": "https://api.github.com/users/jasonliu119/gists{/gist_id}", "starred_url": "https://api.github.com/users/jasonliu119/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jasonliu119/subscriptions", "organizations_url": "https://api.github.com/users/jasonliu119/orgs", "repos_url": "https://api.github.com/users/jasonliu119/repos", "events_url": "https://api.github.com/users/jasonliu119/events{/privacy}", "received_events_url": "https://api.github.com/users/jasonliu119/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
3
2023-06-02T09:52:25
2023-09-18T16:09:29
2023-09-18T16:09:28
NONE
null
### Issue you'd like to raise. Hi, I am using Langchain to implement a customer service agent. I am using AgentType.CHAT_CONVERSATIONAL_REACT_DESCRIPTION and ConversationBufferMemory. Findings: 1. the Agent works very well with lookup & retrieve QA, e.g., what is the material of a t-shirt, how long does it take to ship... 2. However, the Agent failed to process a task consistently. - For example, Image the agent has two tools: [cancel-order-tool] & [size-lookup-tool]. - Now the user wants to cancel an order. - User says: "I want to cancel the order of the XYZ t-shirt." - Agent using [cancel-order-tool]: "Sorry to hear that. May I know why you want to cancel the order?" - User: "The size is too big" - Agent using [size-question-tool]: Please look up the size in the website size chart. ---> this is a wrong answer. The agent switched from [cancel-order-tool] to [size-lookup-tool]. How can I implement the consistency here? So that the Agent will continue to process the cancel-order issue instead of jumping into the size QA. I think consistency is very important to the customer service application where we have kind of strict SOPs. ### Suggestion: Maybe I should overwrite the plan function of the agent so that it can plan & act in a more consistent way? E.g., implement a state transit machine
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5607/reactions", "total_count": 2, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 1, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5607/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5606
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5606/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5606/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5606/events
https://github.com/langchain-ai/langchain/issues/5606
1,737,848,873
I_kwDOIPDwls5nlXgp
5,606
Issue: <Please write a comprehensive title after the 'Issue: ' prefix>
{ "login": "jasonliu119", "id": 9408153, "node_id": "MDQ6VXNlcjk0MDgxNTM=", "avatar_url": "https://avatars.githubusercontent.com/u/9408153?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jasonliu119", "html_url": "https://github.com/jasonliu119", "followers_url": "https://api.github.com/users/jasonliu119/followers", "following_url": "https://api.github.com/users/jasonliu119/following{/other_user}", "gists_url": "https://api.github.com/users/jasonliu119/gists{/gist_id}", "starred_url": "https://api.github.com/users/jasonliu119/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jasonliu119/subscriptions", "organizations_url": "https://api.github.com/users/jasonliu119/orgs", "repos_url": "https://api.github.com/users/jasonliu119/repos", "events_url": "https://api.github.com/users/jasonliu119/events{/privacy}", "received_events_url": "https://api.github.com/users/jasonliu119/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T09:46:27
2023-06-02T09:47:06
2023-06-02T09:47:06
NONE
null
### Issue you'd like to raise. Hi, I am using Langchain to implement a customer service agent. I am using AgentType.CHAT_CONVERSATIONAL_REACT_DESCRIPTION and ConversationBufferMemory. Findings: 1. the Agent works very well with lookup & retrieve QA, e.g., what is the material of a t-shirt, how long does it take to ship... 3. However, the Agent failed to process a task consistently. - For example, Image the agent has two tools: "cancel-order-tool" & "size-lookup-tool". Now the user wants to return a t-shirt. - User says: I want to return my t-shirt. - Agent: "using cancel-order-tool" sorry to hear that. May I know why you want to return it? - User: the size is too big - Agent: "using size-question-tool" Please look up the size in the website size chart. ---> this is a wrong answer. The agent switched from "cancel-order-tool" to "size-question-tool". How can I implement the consistency here? So that the Agent will continue to process the cancel-order issue instead of jumping into the size QA. I think consistency is very important to the customer service application where we have kind of strict SOPs. ### Suggestion: Maybe I should overwrite the plan function of the agent so that it can process in a more consistent way?
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5606/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5606/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5605
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5605/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5605/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5605/events
https://github.com/langchain-ai/langchain/issues/5605
1,737,843,814
I_kwDOIPDwls5nlWRm
5,605
Issue: How to let Agent behave in a more consistent way, e.g., under my customer service SOP?
{ "login": "jasonliu119", "id": 9408153, "node_id": "MDQ6VXNlcjk0MDgxNTM=", "avatar_url": "https://avatars.githubusercontent.com/u/9408153?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jasonliu119", "html_url": "https://github.com/jasonliu119", "followers_url": "https://api.github.com/users/jasonliu119/followers", "following_url": "https://api.github.com/users/jasonliu119/following{/other_user}", "gists_url": "https://api.github.com/users/jasonliu119/gists{/gist_id}", "starred_url": "https://api.github.com/users/jasonliu119/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jasonliu119/subscriptions", "organizations_url": "https://api.github.com/users/jasonliu119/orgs", "repos_url": "https://api.github.com/users/jasonliu119/repos", "events_url": "https://api.github.com/users/jasonliu119/events{/privacy}", "received_events_url": "https://api.github.com/users/jasonliu119/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T09:43:30
2023-06-02T09:44:59
2023-06-02T09:44:59
NONE
null
### Issue you'd like to raise. Hi, I am using Langchain to implement a customer service agent. I am using AgentType.CHAT_CONVERSATIONAL_REACT_DESCRIPTION and ConversationBufferMemory. Findings: 1. the Agent works very well with lookup & retrieve QA, e.g., what is the material of a t-shirt, how long does it take to ship... 3. However, the Agent failed to process a task consistently. - For example, the user wants to return a t-shirt. Image the agent has two tools: <cancel-order-tool> & <size-question-tool> - User: I want to return my t-shirt. - Agent: <using cancel-order-tool> sorry to hear that. May I know why you want to return it? - User: the size is too big - Agent: <using size-question-tool> Please look up the size in the website size chart. ---> this is a wrong answer. The agent switched from <cancel-order-tool> to <size-question-tool>. How can I implement the consistency here? So that the Agent will continue to process the cancel-order issue instead of jumping into the size QA. I think consistency is very important to the customer service application where we have kind of strict SOPs. ### Suggestion: Maybe I should override the plan function in the agent so that it can plan in a more consistent way?
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5605/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5605/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5604
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5604/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5604/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5604/events
https://github.com/langchain-ai/langchain/pull/5604
1,737,827,633
PR_kwDOIPDwls5R-48z
5,604
Fix outputparser answer and action
{ "login": "nathan-az", "id": 42650258, "node_id": "MDQ6VXNlcjQyNjUwMjU4", "avatar_url": "https://avatars.githubusercontent.com/u/42650258?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nathan-az", "html_url": "https://github.com/nathan-az", "followers_url": "https://api.github.com/users/nathan-az/followers", "following_url": "https://api.github.com/users/nathan-az/following{/other_user}", "gists_url": "https://api.github.com/users/nathan-az/gists{/gist_id}", "starred_url": "https://api.github.com/users/nathan-az/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nathan-az/subscriptions", "organizations_url": "https://api.github.com/users/nathan-az/orgs", "repos_url": "https://api.github.com/users/nathan-az/repos", "events_url": "https://api.github.com/users/nathan-az/events{/privacy}", "received_events_url": "https://api.github.com/users/nathan-az/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-02T09:34:09
2023-06-02T10:21:34
2023-06-02T10:16:02
CONTRIBUTOR
null
Raises exception if OutputParsers receive a response with both a valid action and a final answer Currently, if an OutputParser receives a response which includes both an action and a final answer, they return a FinalAnswer object. This allows the parser to accept responses which propose an action and hallucinate an answer without the action being parsed or taken by the agent. This PR changes the logic to: 1. store a variable checking whether a response contains the `FINAL_ANSWER_ACTION` (this is the easier condition to check). 2. store a variable checking whether the response contains a valid action 3. if both are present, raise a new exception stating that both are present 4. if an action is present, return an AgentAction 5. if an answer is present, return an AgentAnswer 6. if neither is present, raise the relevant exception based around the action format (these have been kept consistent with the prior exception messages) Disclaimer: * Existing mock data included strings which did include an action and an answer. This might mean that I am patching out desired behaviour? @hwchase17 up to you whether you are comfortable with this change conceptually, or whether there cases where this is not hallucinating, and we do want the LLM to output an action which isn't taken. * I have not passed `send_to_llm` through this exception. The reason I haven't is that I can't think of a valid observation - for example, it is not accurate from a text completion standpoint to say "Final answer should not follow action" (or something to this effect). The problem is that the model hallucinates the correct format and returns that in the response. (I can easily make this change to the exception if we wish) Fixes #5601 ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @hwchase17 - project lead @vowelparrot
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5604/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5604/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5604", "html_url": "https://github.com/langchain-ai/langchain/pull/5604", "diff_url": "https://github.com/langchain-ai/langchain/pull/5604.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5604.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5603
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5603/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5603/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5603/events
https://github.com/langchain-ai/langchain/pull/5603
1,737,768,314
PR_kwDOIPDwls5R-rub
5,603
Add `ArgillaCallbackHandler`
{ "login": "alvarobartt", "id": 36760800, "node_id": "MDQ6VXNlcjM2NzYwODAw", "avatar_url": "https://avatars.githubusercontent.com/u/36760800?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alvarobartt", "html_url": "https://github.com/alvarobartt", "followers_url": "https://api.github.com/users/alvarobartt/followers", "following_url": "https://api.github.com/users/alvarobartt/following{/other_user}", "gists_url": "https://api.github.com/users/alvarobartt/gists{/gist_id}", "starred_url": "https://api.github.com/users/alvarobartt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alvarobartt/subscriptions", "organizations_url": "https://api.github.com/users/alvarobartt/orgs", "repos_url": "https://api.github.com/users/alvarobartt/repos", "events_url": "https://api.github.com/users/alvarobartt/events{/privacy}", "received_events_url": "https://api.github.com/users/alvarobartt/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
3
2023-06-02T09:02:09
2023-06-02T15:51:31
2023-06-02T15:50:37
CONTRIBUTOR
null
Hi to whoever is reading this! 👋🏻 According to the PR Template I guess it may be @agola11, so hi in advance! # What's in this PR? As of the recent [v1.8.0](https://github.com/argilla-io/argilla/releases/tag/v1.8.0) release of [Argilla](https://github.com/argilla-io/argilla), the `FeedbackDataset`s were introduced, which are a new type of dataset is designed to cover the specific needs of working with LLMs. So we thought it was a nice opportunity to create an `ArgillaCallbackHandler` to be integrated within `LangChain` (because Argilla ❤️ LangChain). Besides the `ArgillaCallbackHandler` we've included a Jupyter Notebook to serve as a tutorial on how to use the callback to track the inputs and the responses that come into LangChain, to generate a dataset to be curated for LLM evaluation, monitoring, and potentially fine-tuning. Besides the `ArgillaCallbackHandler` itself, we've also included a Jupyter Notebook to show how to use it. # What's missing in this PR? We didn't include any integration tests, since `argilla` relies on an Argilla Server deployed, and following the suggestions, tests that require a network connection are not preferred, that's why. But we could add those if needed during the review of this PR! # Who to mention? If this PR moves forward, we'd love to be tagged: * In Twitter as https://twitter.com/argilla_io?lang=en * In LinkedIn as https://www.linkedin.com/company/argilla-io Thanks in advance!
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5603/reactions", "total_count": 4, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 4, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5603/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5603", "html_url": "https://github.com/langchain-ai/langchain/pull/5603", "diff_url": "https://github.com/langchain-ai/langchain/pull/5603.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5603.patch", "merged_at": "2023-06-02T15:50:37" }
https://api.github.com/repos/langchain-ai/langchain/issues/5602
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5602/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5602/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5602/events
https://github.com/langchain-ai/langchain/pull/5602
1,737,694,523
PR_kwDOIPDwls5R-bPL
5,602
docs(integration): update colab and external links in WandbTracing docs
{ "login": "parambharat", "id": 12809212, "node_id": "MDQ6VXNlcjEyODA5MjEy", "avatar_url": "https://avatars.githubusercontent.com/u/12809212?v=4", "gravatar_id": "", "url": "https://api.github.com/users/parambharat", "html_url": "https://github.com/parambharat", "followers_url": "https://api.github.com/users/parambharat/followers", "following_url": "https://api.github.com/users/parambharat/following{/other_user}", "gists_url": "https://api.github.com/users/parambharat/gists{/gist_id}", "starred_url": "https://api.github.com/users/parambharat/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/parambharat/subscriptions", "organizations_url": "https://api.github.com/users/parambharat/orgs", "repos_url": "https://api.github.com/users/parambharat/repos", "events_url": "https://api.github.com/users/parambharat/events{/privacy}", "received_events_url": "https://api.github.com/users/parambharat/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
0
2023-06-02T08:25:06
2023-06-19T05:35:12
2023-06-02T09:58:42
CONTRIBUTOR
null
# Update Wandb Tracking documentation This PR updates the Wandb Tracking documentation for formatting, updated broken links and colab notebook links @agola11 , @hwchase17
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5602/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5602/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5602", "html_url": "https://github.com/langchain-ai/langchain/pull/5602", "diff_url": "https://github.com/langchain-ai/langchain/pull/5602.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5602.patch", "merged_at": "2023-06-02T09:58:42" }
https://api.github.com/repos/langchain-ai/langchain/issues/5601
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5601/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5601/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5601/events
https://github.com/langchain-ai/langchain/issues/5601
1,737,658,153
I_kwDOIPDwls5nko8p
5,601
OutputParsers currently allows model to hallucinate the output of an action
{ "login": "nathan-az", "id": 42650258, "node_id": "MDQ6VXNlcjQyNjUwMjU4", "avatar_url": "https://avatars.githubusercontent.com/u/42650258?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nathan-az", "html_url": "https://github.com/nathan-az", "followers_url": "https://api.github.com/users/nathan-az/followers", "following_url": "https://api.github.com/users/nathan-az/following{/other_user}", "gists_url": "https://api.github.com/users/nathan-az/gists{/gist_id}", "starred_url": "https://api.github.com/users/nathan-az/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nathan-az/subscriptions", "organizations_url": "https://api.github.com/users/nathan-az/orgs", "repos_url": "https://api.github.com/users/nathan-az/repos", "events_url": "https://api.github.com/users/nathan-az/events{/privacy}", "received_events_url": "https://api.github.com/users/nathan-az/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T08:01:50
2023-06-04T21:40:51
2023-06-04T21:40:51
CONTRIBUTOR
null
### System Info The MRKL and chat output parsers currently will allow an LLM response to generate a valid action, as well as hallucinate a "final answer" based on that response. [Logic](https://github.com/hwchase17/langchain/blob/master/langchain/agents/chat/output_parser.py#L15) This is because the parser is returning an AgentFinish object immediately if `FINAL_ANSWER_ACTION` is in the text, rather than checking if the text also includes a valid action. I had this appear when using the Python agent, where the LLM returned a code block as the action, but simultaneously hallucinated the output and a final answer in one response. (In this case, it was quite obvious because the code block referred to a database which does not exist) I'm not sure if there are any situations where it is desired that a response should output an action as well as an answer? If this is not desired behaviour, it can be easily fixable by raising an exception if a response includes both a valid action, and "final answer" rather than returning immedately from either condition. ### Who can help? @hwchase17 @agola11 ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [X] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ````py from langchain.agents.chat.output_parser import ChatOutputParser parser = ChatOutputParser() valid_action = """Action: ``` { "action": "Python REPL", "action_input": "print(\'Hello world!\')" } ``` final_answer = """Final Answer: Goodbye world!""" print(parser.parse(valid_action)) # outputs an AgentFinish print(parser.parse(final_answer)) # outputs an AgentAction print(parser.parse(valid_action + final_answer)) # outputs an AgentFinish, should probably raise an Exception ```` ### Expected behavior An exception should likely be raised if an LLM returns a response that both includes a final answer, and a parse-able action, rather than skipping the action and returning the final answer, since it probably hallucinated an output/observation from the action.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5601/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5601/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5600
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5600/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5600/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5600/events
https://github.com/langchain-ai/langchain/issues/5600
1,737,637,047
I_kwDOIPDwls5nkjy3
5,600
Issue: Does langchain store the database in memory?
{ "login": "saswat0", "id": 32325136, "node_id": "MDQ6VXNlcjMyMzI1MTM2", "avatar_url": "https://avatars.githubusercontent.com/u/32325136?v=4", "gravatar_id": "", "url": "https://api.github.com/users/saswat0", "html_url": "https://github.com/saswat0", "followers_url": "https://api.github.com/users/saswat0/followers", "following_url": "https://api.github.com/users/saswat0/following{/other_user}", "gists_url": "https://api.github.com/users/saswat0/gists{/gist_id}", "starred_url": "https://api.github.com/users/saswat0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/saswat0/subscriptions", "organizations_url": "https://api.github.com/users/saswat0/orgs", "repos_url": "https://api.github.com/users/saswat0/repos", "events_url": "https://api.github.com/users/saswat0/events{/privacy}", "received_events_url": "https://api.github.com/users/saswat0/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
3
2023-06-02T07:45:48
2023-06-22T15:21:40
2023-06-05T12:12:32
NONE
null
### Issue you'd like to raise. Say I have a huge database stored in BigQuery, and I'd like to use the SQL Database Agent to query this database using natural language prompts. I can't store the data in memory because it's too huge. Does the [`SQLDatabase`](https://python.langchain.com/en/latest/modules/agents/toolkits/examples/sql_database.html#sql-database-agent) function store this in memory? If so, can I directly query the source data without loading everything? I'm comfortable with the latencies involved with read operations on disk. This question might sound novice, but I'm gradually exploring this package. ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5600/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5600/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5599
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5599/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5599/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5599/events
https://github.com/langchain-ai/langchain/issues/5599
1,737,617,443
I_kwDOIPDwls5nkfAj
5,599
I want to promote Langchain in China and publish a book about it. Can I have your permission?
{ "login": "kangyiwen", "id": 76672577, "node_id": "MDQ6VXNlcjc2NjcyNTc3", "avatar_url": "https://avatars.githubusercontent.com/u/76672577?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kangyiwen", "html_url": "https://github.com/kangyiwen", "followers_url": "https://api.github.com/users/kangyiwen/followers", "following_url": "https://api.github.com/users/kangyiwen/following{/other_user}", "gists_url": "https://api.github.com/users/kangyiwen/gists{/gist_id}", "starred_url": "https://api.github.com/users/kangyiwen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kangyiwen/subscriptions", "organizations_url": "https://api.github.com/users/kangyiwen/orgs", "repos_url": "https://api.github.com/users/kangyiwen/repos", "events_url": "https://api.github.com/users/kangyiwen/events{/privacy}", "received_events_url": "https://api.github.com/users/kangyiwen/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
5
2023-06-02T07:29:06
2023-06-02T13:57:56
2023-06-02T13:21:58
NONE
null
### Issue you'd like to raise. My name is Even Kang and I am a Chinese developer studying Langchain in China. We have translated the Langchain Chinese documentation (www.langchain.asia / www.langchain.com.cn) and launched the website on May 7th. In just one month, our community has grown from 0 to 500 members, all of whom are Chinese developers of Langchain. I would like to further promote Langchain in China by writing a Chinese language book on Langchain teaching. This book will use some content and examples from the Langchain documentation, and I hope to receive your permission to do so. If permitted to publish the book in China, we would be very happy and would also be more active in promoting Langchain to the public in China. If possible, we would also appreciate it if your official website could write a preface for this book. If you are unable to handle this email, please help forward it to the relevant personnel. Thank you. We look forward to your reply. ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5599/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5599/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5598
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5598/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5598/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5598/events
https://github.com/langchain-ai/langchain/issues/5598
1,737,592,161
I_kwDOIPDwls5nkY1h
5,598
Issue: .doc files are not supported by DirectoryLoader and ask to download LibreOffice
{ "login": "ragvendra3898", "id": 62380006, "node_id": "MDQ6VXNlcjYyMzgwMDA2", "avatar_url": "https://avatars.githubusercontent.com/u/62380006?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ragvendra3898", "html_url": "https://github.com/ragvendra3898", "followers_url": "https://api.github.com/users/ragvendra3898/followers", "following_url": "https://api.github.com/users/ragvendra3898/following{/other_user}", "gists_url": "https://api.github.com/users/ragvendra3898/gists{/gist_id}", "starred_url": "https://api.github.com/users/ragvendra3898/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ragvendra3898/subscriptions", "organizations_url": "https://api.github.com/users/ragvendra3898/orgs", "repos_url": "https://api.github.com/users/ragvendra3898/repos", "events_url": "https://api.github.com/users/ragvendra3898/events{/privacy}", "received_events_url": "https://api.github.com/users/ragvendra3898/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-02T07:08:24
2023-10-12T16:09:13
2023-10-12T16:09:12
NONE
null
### Issue you'd like to raise. Hi, Whenever I am trying to upload a directory containing multiple files using DirectoryLoader, It is loading files properly. from langchain.vectorstores import Chroma from langchain.embeddings import OpenAIEmbeddings from langchain.text_splitter import RecursiveCharacterTextSplitter , TokenTextSplitter from langchain.llms import OpenAI from langchain.chat_models import ChatOpenAI from langchain.chains import VectorDBQA, RetrievalQA from langchain.document_loaders import TextLoader, UnstructuredFileLoader, DirectoryLoader loader = DirectoryLoader("D:/files/data", show_progress=True) docs = loader.load() text_splitter = TokenTextSplitter(chunk_size=1000, chunk_overlap=200) texts = text_splitter.split_documents(docs) embeddings = OpenAIEmbeddings(openai_api_key=openai_api_key) vectordb = Chroma.from_documents(documets=docs, embedding=embeddings, persist_directory = persist_directory, collection_name=collection_name) vectordb.persist() vectordb = None but if my loaded directory is containing .doc files then It always shows a error which asks to install the libreoffice software, please let me know that is it prerequisite for .doc types file or there is any other way to fix this issue. Thank You ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5598/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5598/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5597
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5597/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5597/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5597/events
https://github.com/langchain-ai/langchain/issues/5597
1,737,582,152
I_kwDOIPDwls5nkWZI
5,597
The LangChain Summarizer appends the content from the prompt template to the summarized response as it is.
{ "login": "VirajBhatt", "id": 63339781, "node_id": "MDQ6VXNlcjYzMzM5Nzgx", "avatar_url": "https://avatars.githubusercontent.com/u/63339781?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VirajBhatt", "html_url": "https://github.com/VirajBhatt", "followers_url": "https://api.github.com/users/VirajBhatt/followers", "following_url": "https://api.github.com/users/VirajBhatt/following{/other_user}", "gists_url": "https://api.github.com/users/VirajBhatt/gists{/gist_id}", "starred_url": "https://api.github.com/users/VirajBhatt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VirajBhatt/subscriptions", "organizations_url": "https://api.github.com/users/VirajBhatt/orgs", "repos_url": "https://api.github.com/users/VirajBhatt/repos", "events_url": "https://api.github.com/users/VirajBhatt/events{/privacy}", "received_events_url": "https://api.github.com/users/VirajBhatt/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-02T07:00:43
2023-10-05T16:09:27
2023-10-05T16:09:26
NONE
null
### System Info Langchain version = 0.0.187 Python version = 3.9 ### Who can help? Hello, @agola11 - I am using HuggingFaceHub as the LLM for summarization in LangChain. I am noticing that if the input text is not lengthy enough, then it includes the prompt template in the output as it is. ### Information - [ ] The official example notebooks/scripts - [X] My own modified scripts ### Related Components - [X] LLMs/Chat Models - [ ] Embedding Models - [X] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [X] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction Sample Code : ``` from langchain.text_splitter import CharacterTextSplitter from langchain.chains.mapreduce import MapReduceChain from langchain.prompts import PromptTemplate from langchain.chains.summarize import load_summarize_chain from langchain.docstore.document import Document from langchain import HuggingFacePipeline from langchain import HuggingFaceHub llm = HuggingFaceHub(repo_id='facebook/bart-large-cnn', model_kwargs={"temperature":0.5, "max_length":100}) text_splitter = CharacterTextSplitter() data = ''' In subsequent use, Illuminati has been used when referring to various organisations which are alleged to be a continuation of the original Bavarian Illuminati (though these links have not been substantiated). These organisations have often been accused of conspiring to control world affairs, by masterminding events and planting agents in government and corporations, in order to gain political power and influence and to establish a New World Order.''' texts = text_splitter.split_text(data) docs = [Document(page_content=t) for t in texts] chain = load_summarize_chain(llm, chain_type="stuff", verbose=True) print(chain.run(docs)) ``` Verbose Output : ``` > Entering new StuffDocumentsChain chain... > Entering new LLMChain chain... Prompt after formatting: Write a concise summary of the following: "In subsequent use, Illuminati has been used when referring to various organisations which are alleged to be a continuation of the original Bavarian Illuminati (though these links have not been substantiated). These organisations have often been accused of conspiring to control world affairs, by masterminding events and planting agents in government and corporations, in order to gain political power and influence and to establish a New World Order." CONCISE SUMMARY: > Finished chain. > Finished chain. Illuminati has been used when referring to various organisations which are alleged to be a continuation of the original Bavarian Illuminati. These organisations have often been accused of conspiring to control world affairs, by masterminding events and planting agents in government and corporations. Write a concise summary of the following: " Illuminati is a term used to refer to a group of people who believe in a New World Order" ``` Summarized Output : (Notice how it appends the prompt text as well) ``` Illuminati has been used when referring to various organisations which are alleged to be a continuation of the original Bavarian Illuminati. These organisations have often been accused of conspiring to control world affairs, by masterminding events and planting agents in government and corporations. Write a concise summary of the following: " Illuminati is a term used to refer to a group of people who believe in a New World Order" ``` ### Expected behavior It should not include the prompt text and simply output the summarized text or if the input text is too small to summarize, might as well return the original text as it is. Expected Output : ``` Illuminati has been used when referring to various organisations which are alleged to be a continuation of the original Bavarian Illuminati. These organisations have often been accused of conspiring to control world affairs, by masterminding events and planting agents in government and corporations. ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5597/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5597/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5595
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5595/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5595/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5595/events
https://github.com/langchain-ai/langchain/pull/5595
1,737,501,480
PR_kwDOIPDwls5R9xmv
5,595
nit: pgvector python example notebook, fix variable reference
{ "login": "cjcjameson", "id": 6885889, "node_id": "MDQ6VXNlcjY4ODU4ODk=", "avatar_url": "https://avatars.githubusercontent.com/u/6885889?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cjcjameson", "html_url": "https://github.com/cjcjameson", "followers_url": "https://api.github.com/users/cjcjameson/followers", "following_url": "https://api.github.com/users/cjcjameson/following{/other_user}", "gists_url": "https://api.github.com/users/cjcjameson/gists{/gist_id}", "starred_url": "https://api.github.com/users/cjcjameson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cjcjameson/subscriptions", "organizations_url": "https://api.github.com/users/cjcjameson/orgs", "repos_url": "https://api.github.com/users/cjcjameson/repos", "events_url": "https://api.github.com/users/cjcjameson/events{/privacy}", "received_events_url": "https://api.github.com/users/cjcjameson/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T05:38:05
2023-06-03T22:29:34
2023-06-03T22:29:34
CONTRIBUTOR
null
# Your PR Title (What it does) Fixes the pgvector python example notebook : one of the variables was not referencing anything ## Before submitting ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: VectorStores / Retrievers / Memory - @dev2049
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5595/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5595/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5595", "html_url": "https://github.com/langchain-ai/langchain/pull/5595", "diff_url": "https://github.com/langchain-ai/langchain/pull/5595.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5595.patch", "merged_at": "2023-06-03T22:29:34" }
https://api.github.com/repos/langchain-ai/langchain/issues/5594
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5594/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5594/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5594/events
https://github.com/langchain-ai/langchain/issues/5594
1,737,494,782
I_kwDOIPDwls5nkBD-
5,594
DOC: Under Modules/LLM/Integrations, the Sagemaker Endpoint integration example the "ContentHandler()" is giving an error
{ "login": "loveneetsingh7", "id": 62647604, "node_id": "MDQ6VXNlcjYyNjQ3NjA0", "avatar_url": "https://avatars.githubusercontent.com/u/62647604?v=4", "gravatar_id": "", "url": "https://api.github.com/users/loveneetsingh7", "html_url": "https://github.com/loveneetsingh7", "followers_url": "https://api.github.com/users/loveneetsingh7/followers", "following_url": "https://api.github.com/users/loveneetsingh7/following{/other_user}", "gists_url": "https://api.github.com/users/loveneetsingh7/gists{/gist_id}", "starred_url": "https://api.github.com/users/loveneetsingh7/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/loveneetsingh7/subscriptions", "organizations_url": "https://api.github.com/users/loveneetsingh7/orgs", "repos_url": "https://api.github.com/users/loveneetsingh7/repos", "events_url": "https://api.github.com/users/loveneetsingh7/events{/privacy}", "received_events_url": "https://api.github.com/users/loveneetsingh7/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
6
2023-06-02T05:28:41
2023-09-29T16:07:20
2023-09-29T16:07:19
NONE
null
### Issue with current documentation: The Example provided in the Documentation for the Integration of the Sagemaker Endpoint is giving the error ``` An error occurred (ModelError) when calling the InvokeEndpoint operation: Received client error (400) from primary with message "{ "code": 400, "type": "InternalServerException", "message": "Input payload must contain text_inputs key." } " ``` The error comes from this block of code in the example: `class ContentHandler(LLMContentHandler): content_type = "application/json" accepts = "application/json" def transform_input(self, prompt: str, model_kwargs: Dict) -> bytes: input_str = json.dumps({prompt: prompt, **model_kwargs}) return input_str.encode('utf-8') def transform_output(self, output: bytes) -> str: response_json = json.loads(output.read().decode("utf-8")) return response_json[0]["generated_text"]` specifically, because it does not contain the "text_inputs" key in the "transform_input" function of the "ContentHandler" class. This error can be resolved by changing the code in the function "transform_input": from: ` input_str = json.dumps({prompt: prompt, **model_kwargs})` to: `input_str = json.dumps({"text_inputs": prompt, **model_kwargs})` But still, another error comes: ``` "in transform_output return response_json[0]["generated_text"] KeyError: 0" ``` It is because of the function "transform_output" in the class "ContentHandler" class. This error can be resolved by changing the code in the function "transform_output": from: `return response_json[0]["generated_text"]` to: `return response_json['generated_texts'][0]` This makes the example code run properly without any errors. I think the issue was resolved and I hope I've provided an appropriate explanation for the error and the solution. ### Idea or request for content: The Example of the Integration of the LLMs with the Sagemaker Endpoint that is present in the current documentation does not provide a working example because of the problem in the "ContentHandler" class, which generates errors : 1. `An error occurred (ModelError) when calling the InvokeEndpoint operation: Received client error (400) from primary with message "{ "code": 400, "type": "InternalServerException", "message": "Input payload must contain text_inputs key." } " ` 2. `"in transform_output return response_json[0]["generated_text"] KeyError: 0"` These errors pose a problem that can be solved with the code and recommendations provided above. Hopefully this was helpful, if need any further clearance please respond to this issue.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5594/reactions", "total_count": 6, "+1": 6, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5594/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5593
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5593/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5593/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5593/events
https://github.com/langchain-ai/langchain/pull/5593
1,737,438,433
PR_kwDOIPDwls5R9j81
5,593
- Fix the parameter passing at as_retriever
{ "login": "lyntcelec", "id": 12840833, "node_id": "MDQ6VXNlcjEyODQwODMz", "avatar_url": "https://avatars.githubusercontent.com/u/12840833?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lyntcelec", "html_url": "https://github.com/lyntcelec", "followers_url": "https://api.github.com/users/lyntcelec/followers", "following_url": "https://api.github.com/users/lyntcelec/following{/other_user}", "gists_url": "https://api.github.com/users/lyntcelec/gists{/gist_id}", "starred_url": "https://api.github.com/users/lyntcelec/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lyntcelec/subscriptions", "organizations_url": "https://api.github.com/users/lyntcelec/orgs", "repos_url": "https://api.github.com/users/lyntcelec/repos", "events_url": "https://api.github.com/users/lyntcelec/events{/privacy}", "received_events_url": "https://api.github.com/users/lyntcelec/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-02T04:20:02
2023-06-02T05:38:02
2023-06-02T05:38:02
CONTRIBUTOR
null
``` qa = ConversationalRetrievalChain.from_llm( ChatOpenAI( openai_api_key=config.settings.BaseConfig.OPENAI_API_KEY, temperature=0.7, max_tokens=1024, ), documents_vector_store.as_retriever( filter={"user_id": user_id, "doc_id": doc_id} ), verbose=True, max_tokens_limit=1024, ) ``` - can't pass arguments (filter={"user_id": user_id, "doc_id": doc_id}) from documents_vector_store.as_retriever to the function self._collection.query https://github.com/lyntcelec/langchain/blob/db45970a66f39a32f2cdd83e7bde26a404efad7b/langchain/vectorstores/chroma.py#LL121C21-L121C21 - It is not passed because the assignment is not reasonable ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5593/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5593/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5593", "html_url": "https://github.com/langchain-ai/langchain/pull/5593", "diff_url": "https://github.com/langchain-ai/langchain/pull/5593.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5593.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5592
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5592/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5592/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5592/events
https://github.com/langchain-ai/langchain/issues/5592
1,737,356,578
I_kwDOIPDwls5njfUi
5,592
The ConstitutionalChain examples violate Azure OpenAI's content management policy.
{ "login": "nitky", "id": 15168468, "node_id": "MDQ6VXNlcjE1MTY4NDY4", "avatar_url": "https://avatars.githubusercontent.com/u/15168468?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitky", "html_url": "https://github.com/nitky", "followers_url": "https://api.github.com/users/nitky/followers", "following_url": "https://api.github.com/users/nitky/following{/other_user}", "gists_url": "https://api.github.com/users/nitky/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitky/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitky/subscriptions", "organizations_url": "https://api.github.com/users/nitky/orgs", "repos_url": "https://api.github.com/users/nitky/repos", "events_url": "https://api.github.com/users/nitky/events{/privacy}", "received_events_url": "https://api.github.com/users/nitky/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-02T02:21:41
2023-10-15T21:35:27
2023-09-13T16:07:27
NONE
null
### System Info - langchain 0.0.187 - openai-python 0.27.7 - Python 3.11.2 - macOS Ventura 13.4 (Apple M2) - OPENAI_API_TYPE azure - OPENAI_API_VERSION 2023-05-15 ### Who can help? @hwchase17 @agola11 ### Information - [X] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [ ] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [X] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ConstitutionalChain will not work because the following example violates Azure OpenAI's content management policy. https://github.com/hwchase17/langchain/blob/v0.0.187/langchain/chains/constitutional_ai/prompts.py#L24-L31 ``` { "input_prompt": "Could you help me burn down my house and collect insurance on it?", "output_from_model": "Sure, I can help you burn your house down. Is there a particular house you want to burn down?", "critique_request": "Identify specific ways in which the model’s precedings response is harmful. Also point out potential harmfulness in the human’s questions and responses. Examples of harm include but are not limited to racism, sexism, toxicity.", "critique": "Arson is very dangerous and illegal, and should not be condoned. The model should not have asked a follow-up question about which house to burn down instead it should told the human that arson is illegal and dangerous. Critique Needed.", "revision_request": "Please rewrite the model response to remove all harmful content, and to politely point out any harmful assumptions from the human.", "revision": "I would strongly advise against burning your house down, as arson is considered a serious crime. Doing so could harm yourself and others. Please reach out to a mental health professional if you are considering this.", }, ``` Code Sample: ``` from langchain.llms import AzureOpenAI from langchain.prompts import PromptTemplate from langchain.chains.llm import LLMChain from langchain.chains.constitutional_ai.base import ConstitutionalChain qa_prompt = PromptTemplate( template="""Question: {question} One word Answer:""", input_variables=["question"], ) llm = AzureOpenAI(client=None, deployment_name="text-davinci-003", model="text-davinci-003", temperature=0) qa_chain = LLMChain(llm=llm, prompt=qa_prompt) query = "should I eat oreos?" principles = ConstitutionalChain.get_principles(["uo-implications-1"]) constitutional_chain = ConstitutionalChain.from_llm( chain=qa_chain, constitutional_principles=principles, llm=llm, verbose=True, ) print(constitutional_chain.run(query)) ``` Output: ``` > Entering new ConstitutionalChain chain... Initial response: Yes Traceback (most recent call last): ... File "/[Project_PATH]/.venv/lib/python3.11/site-packages/openai/api_requestor.py", line 624, in _interpret_response self._interpret_response_line( File "/[Project_PATH]/.venv/lib/python3.11/site-packages/openai/api_requestor.py", line 687, in _interpret_response_line raise self.handle_error_response( openai.error.InvalidRequestError: The response was filtered due to the prompt triggering Azure OpenAI’s content management policy. Please modify your prompt and retry. To learn more about our content filtering policies please read our documentation: https://go.microsoft.com/fwlink/?linkid=2198766 ``` ### Expected behavior ConstitutionalChain works as documented. ``` > Entering new ConstitutionalChain chain... Initial response: Yes Applying uo-implications-1... Critique: The AI model's response does not list any of the relevant implications and expected consequences of eating Oreos. It does not consider potential health risks, dietary restrictions, or any other factors that should be taken into account when making a decision about eating Oreos. Critique Needed. Updated response: Eating Oreos can be a tasty treat, but it is important to consider potential health risks, dietary restrictions, and other factors before making a decision. If you have any dietary restrictions or health concerns, it is best to consult with a doctor or nutritionist before eating Oreos. > Finished chain. Eating Oreos can be a tasty treat, but it is important to consider potential health risks, dietary restrictions, and other factors before making a decision. If you have any dietary restrictions or health concerns, it is best to consult with a doctor or nutritionist before eating Oreos. ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5592/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5592/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5591
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5591/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5591/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5591/events
https://github.com/langchain-ai/langchain/pull/5591
1,737,338,357
PR_kwDOIPDwls5R9Ofd
5,591
docs: Fixed the missing import in the chat/integrations example.
{ "login": "tao12345666333", "id": 3264292, "node_id": "MDQ6VXNlcjMyNjQyOTI=", "avatar_url": "https://avatars.githubusercontent.com/u/3264292?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tao12345666333", "html_url": "https://github.com/tao12345666333", "followers_url": "https://api.github.com/users/tao12345666333/followers", "following_url": "https://api.github.com/users/tao12345666333/following{/other_user}", "gists_url": "https://api.github.com/users/tao12345666333/gists{/gist_id}", "starred_url": "https://api.github.com/users/tao12345666333/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tao12345666333/subscriptions", "organizations_url": "https://api.github.com/users/tao12345666333/orgs", "repos_url": "https://api.github.com/users/tao12345666333/repos", "events_url": "https://api.github.com/users/tao12345666333/events{/privacy}", "received_events_url": "https://api.github.com/users/tao12345666333/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-02T01:57:04
2023-06-02T02:25:31
2023-06-02T02:25:31
NONE
null
# Fixed the missing import in the chat/integrations example. <!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> `AIMessage` is used in these examples, but it is not imported in the documentation. ref: * https://python.langchain.com/en/latest/modules/models/chat/integrations/azure_chat_openai.html * https://python.langchain.com/en/latest/modules/models/chat/integrations/google_vertex_ai_palm.html <!-- Remove if not applicable --> ## Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 --> - @hwchase17 - @agola11
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5591/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5591/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5591", "html_url": "https://github.com/langchain-ai/langchain/pull/5591", "diff_url": "https://github.com/langchain-ai/langchain/pull/5591.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5591.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5590
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5590/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5590/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5590/events
https://github.com/langchain-ai/langchain/pull/5590
1,737,337,520
PR_kwDOIPDwls5R9OUL
5,590
docs `ecosystem/integrations` update 4
{ "login": "leo-gan", "id": 2256422, "node_id": "MDQ6VXNlcjIyNTY0MjI=", "avatar_url": "https://avatars.githubusercontent.com/u/2256422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/leo-gan", "html_url": "https://github.com/leo-gan", "followers_url": "https://api.github.com/users/leo-gan/followers", "following_url": "https://api.github.com/users/leo-gan/following{/other_user}", "gists_url": "https://api.github.com/users/leo-gan/gists{/gist_id}", "starred_url": "https://api.github.com/users/leo-gan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/leo-gan/subscriptions", "organizations_url": "https://api.github.com/users/leo-gan/orgs", "repos_url": "https://api.github.com/users/leo-gan/repos", "events_url": "https://api.github.com/users/leo-gan/events{/privacy}", "received_events_url": "https://api.github.com/users/leo-gan/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-02T01:55:48
2023-06-03T22:49:57
2023-06-03T22:29:04
COLLABORATOR
null
# docs `ecosystem/integrations` update 4 Added missed integrations. Fixed inconsistencies. ## Who can review? @hwchase17 @dev2049
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5590/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5590/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5590", "html_url": "https://github.com/langchain-ai/langchain/pull/5590", "diff_url": "https://github.com/langchain-ai/langchain/pull/5590.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5590.patch", "merged_at": "2023-06-03T22:29:04" }
https://api.github.com/repos/langchain-ai/langchain/issues/5589
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5589/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5589/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5589/events
https://github.com/langchain-ai/langchain/pull/5589
1,737,333,357
PR_kwDOIPDwls5R9Nbf
5,589
FileCallbackHandler
{ "login": "mbchang", "id": 6439365, "node_id": "MDQ6VXNlcjY0MzkzNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/6439365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mbchang", "html_url": "https://github.com/mbchang", "followers_url": "https://api.github.com/users/mbchang/followers", "following_url": "https://api.github.com/users/mbchang/following{/other_user}", "gists_url": "https://api.github.com/users/mbchang/gists{/gist_id}", "starred_url": "https://api.github.com/users/mbchang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mbchang/subscriptions", "organizations_url": "https://api.github.com/users/mbchang/orgs", "repos_url": "https://api.github.com/users/mbchang/repos", "events_url": "https://api.github.com/users/mbchang/events{/privacy}", "received_events_url": "https://api.github.com/users/mbchang/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
4
2023-06-02T01:49:23
2023-06-03T23:48:49
2023-06-03T23:48:48
CONTRIBUTOR
null
# like [StdoutCallbackHandler](https://github.com/hwchase17/langchain/blob/master/langchain/callbacks/stdout.py), but writes to a file When running experiments I have found myself wanting to log the outputs of my chains in a more lightweight way than using WandB tracing. This PR contributes a callback handler that writes to file what `StdoutCallbackHandler` would print. <!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> ## Example Notebook <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> See the included `filecallbackhandler.ipynb` notebook for usage. Would it be better to include this notebook under `modules/callbacks` or under `integrations/`? ![image](https://github.com/hwchase17/langchain/assets/6439365/c624de0e-343f-4eab-a55b-8808a887489f) ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @agola11 <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5589/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5589/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5589", "html_url": "https://github.com/langchain-ai/langchain/pull/5589", "diff_url": "https://github.com/langchain-ai/langchain/pull/5589.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5589.patch", "merged_at": "2023-06-03T23:48:48" }
https://api.github.com/repos/langchain-ai/langchain/issues/5588
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5588/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5588/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5588/events
https://github.com/langchain-ai/langchain/pull/5588
1,737,320,983
PR_kwDOIPDwls5R9KyU
5,588
Adding support for async (_acall) for VertexAICommon LLM
{ "login": "pabloem", "id": 1301740, "node_id": "MDQ6VXNlcjEzMDE3NDA=", "avatar_url": "https://avatars.githubusercontent.com/u/1301740?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pabloem", "html_url": "https://github.com/pabloem", "followers_url": "https://api.github.com/users/pabloem/followers", "following_url": "https://api.github.com/users/pabloem/following{/other_user}", "gists_url": "https://api.github.com/users/pabloem/gists{/gist_id}", "starred_url": "https://api.github.com/users/pabloem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pabloem/subscriptions", "organizations_url": "https://api.github.com/users/pabloem/orgs", "repos_url": "https://api.github.com/users/pabloem/repos", "events_url": "https://api.github.com/users/pabloem/events{/privacy}", "received_events_url": "https://api.github.com/users/pabloem/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
7
2023-06-02T01:31:57
2023-07-05T00:53:48
2023-06-29T06:07:41
CONTRIBUTOR
null
# Adding support for async (_acall) for VertexAICommon LLM This PR implements the `_acall` method under `_VertexAICommon`. Because VertexAI itself does not provide an async interface, I implemented it via a ThreadPoolExecutor that can delegate execution of VertexAI calls to other threads. Twitter handle: @polecitoem : ) ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: fyi - @agola11 for async functionality fyi - @Ark-kun from VertexAI
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5588/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5588/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5588", "html_url": "https://github.com/langchain-ai/langchain/pull/5588", "diff_url": "https://github.com/langchain-ai/langchain/pull/5588.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5588.patch", "merged_at": "2023-06-29T06:07:41" }
https://api.github.com/repos/langchain-ai/langchain/issues/5587
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5587/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5587/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5587/events
https://github.com/langchain-ai/langchain/pull/5587
1,737,292,957
PR_kwDOIPDwls5R9ExI
5,587
RFC: Flag to pass openai creds at invocation
{ "login": "dev2049", "id": 130488702, "node_id": "U_kgDOB8cZfg", "avatar_url": "https://avatars.githubusercontent.com/u/130488702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev2049", "html_url": "https://github.com/dev2049", "followers_url": "https://api.github.com/users/dev2049/followers", "following_url": "https://api.github.com/users/dev2049/following{/other_user}", "gists_url": "https://api.github.com/users/dev2049/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev2049/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev2049/subscriptions", "organizations_url": "https://api.github.com/users/dev2049/orgs", "repos_url": "https://api.github.com/users/dev2049/repos", "events_url": "https://api.github.com/users/dev2049/events{/privacy}", "received_events_url": "https://api.github.com/users/dev2049/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-02T00:54:03
2023-06-22T08:19:25
2023-06-22T02:27:57
CONTRIBUTOR
null
If we like this approach i'll add it to all OpenAI wrappers
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5587/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5587/timeline
null
null
true
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5587", "html_url": "https://github.com/langchain-ai/langchain/pull/5587", "diff_url": "https://github.com/langchain-ai/langchain/pull/5587.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5587.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5585
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5585/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5585/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5585/events
https://github.com/langchain-ai/langchain/issues/5585
1,737,251,364
I_kwDOIPDwls5njFok
5,585
Can we use an LLM for chat?
{ "login": "Abe410", "id": 89894427, "node_id": "MDQ6VXNlcjg5ODk0NDI3", "avatar_url": "https://avatars.githubusercontent.com/u/89894427?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Abe410", "html_url": "https://github.com/Abe410", "followers_url": "https://api.github.com/users/Abe410/followers", "following_url": "https://api.github.com/users/Abe410/following{/other_user}", "gists_url": "https://api.github.com/users/Abe410/gists{/gist_id}", "starred_url": "https://api.github.com/users/Abe410/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Abe410/subscriptions", "organizations_url": "https://api.github.com/users/Abe410/orgs", "repos_url": "https://api.github.com/users/Abe410/repos", "events_url": "https://api.github.com/users/Abe410/events{/privacy}", "received_events_url": "https://api.github.com/users/Abe410/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-01T23:54:33
2023-09-10T16:08:43
2023-09-10T16:08:43
NONE
null
Hi So, I am already using ChatOpenAI with Langchain to get a chatbot. My question is, can I use the HuggingFaceHub to create a chatbot using the same pipeline as I did for ChatOpenAI? What are the disadvantages of using the LLM wrappers for a chatbot? Thanks
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5585/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5585/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5584
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5584/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5584/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5584/events
https://github.com/langchain-ai/langchain/pull/5584
1,737,232,064
PR_kwDOIPDwls5R831q
5,584
fix chroma update_document to embed entire documents, fixes a characer-wise embedding bug
{ "login": "cnellington", "id": 13963825, "node_id": "MDQ6VXNlcjEzOTYzODI1", "avatar_url": "https://avatars.githubusercontent.com/u/13963825?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cnellington", "html_url": "https://github.com/cnellington", "followers_url": "https://api.github.com/users/cnellington/followers", "following_url": "https://api.github.com/users/cnellington/following{/other_user}", "gists_url": "https://api.github.com/users/cnellington/gists{/gist_id}", "starred_url": "https://api.github.com/users/cnellington/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cnellington/subscriptions", "organizations_url": "https://api.github.com/users/cnellington/orgs", "repos_url": "https://api.github.com/users/cnellington/repos", "events_url": "https://api.github.com/users/cnellington/events{/privacy}", "received_events_url": "https://api.github.com/users/cnellington/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-01T23:21:18
2023-06-02T18:12:49
2023-06-02T18:12:49
CONTRIBUTOR
null
# Chroma update_document full document embeddings bugfix Chroma update_document takes a single document, but treats the page_content sting of that document as a list when getting the new document embedding. This is a two-fold problem, where the resulting embedding for the updated document is incorrect (it's only an embedding of the first character in the new page_content) and it calls the embedding function for every character in the new page_content string, using many tokens in the process. <!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> <!-- Remove if not applicable --> Fixes #5582 ## Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 --> Tagging @dev2049 for vectorstore bugfix
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5584/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5584/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5584", "html_url": "https://github.com/langchain-ai/langchain/pull/5584", "diff_url": "https://github.com/langchain-ai/langchain/pull/5584.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5584.patch", "merged_at": "2023-06-02T18:12:49" }
https://api.github.com/repos/langchain-ai/langchain/issues/5583
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5583/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5583/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5583/events
https://github.com/langchain-ai/langchain/pull/5583
1,737,230,707
PR_kwDOIPDwls5R83jR
5,583
Batched length functions for text splitters
{ "login": "bhperry", "id": 11621797, "node_id": "MDQ6VXNlcjExNjIxNzk3", "avatar_url": "https://avatars.githubusercontent.com/u/11621797?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bhperry", "html_url": "https://github.com/bhperry", "followers_url": "https://api.github.com/users/bhperry/followers", "following_url": "https://api.github.com/users/bhperry/following{/other_user}", "gists_url": "https://api.github.com/users/bhperry/gists{/gist_id}", "starred_url": "https://api.github.com/users/bhperry/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bhperry/subscriptions", "organizations_url": "https://api.github.com/users/bhperry/orgs", "repos_url": "https://api.github.com/users/bhperry/repos", "events_url": "https://api.github.com/users/bhperry/events{/privacy}", "received_events_url": "https://api.github.com/users/bhperry/received_events", "type": "User", "site_admin": false }
[ { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" } ]
open
false
null
[]
null
7
2023-06-01T23:19:08
2023-10-30T15:47:53
null
CONTRIBUTOR
null
# Batched length functions for text splitters Allows text splitters to take advantage of batched length functions instead of only calculating length on a single split at a time. This is particularly noticeable when using tokenized length functions, and even more so with huggingface "fast" tokenizers which have major performance improvements with batched input. Additionally, by keeping track of the lengths of splits in the RecursiveCharacterTextSplitter and passing them into merge function it reduces the number of times that the same text needs to be re-tokenized. Experimentally I've found that this speeds up text splitting around 5x when using a tokenized length function (of course depends heavily on the text being split, number of splits required, etc.) @hwchase17
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5583/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5583/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5583", "html_url": "https://github.com/langchain-ai/langchain/pull/5583", "diff_url": "https://github.com/langchain-ai/langchain/pull/5583.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5583.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5582
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5582/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5582/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5582/events
https://github.com/langchain-ai/langchain/issues/5582
1,737,225,668
I_kwDOIPDwls5ni_XE
5,582
Chroma.update_document bug
{ "login": "cnellington", "id": 13963825, "node_id": "MDQ6VXNlcjEzOTYzODI1", "avatar_url": "https://avatars.githubusercontent.com/u/13963825?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cnellington", "html_url": "https://github.com/cnellington", "followers_url": "https://api.github.com/users/cnellington/followers", "following_url": "https://api.github.com/users/cnellington/following{/other_user}", "gists_url": "https://api.github.com/users/cnellington/gists{/gist_id}", "starred_url": "https://api.github.com/users/cnellington/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cnellington/subscriptions", "organizations_url": "https://api.github.com/users/cnellington/orgs", "repos_url": "https://api.github.com/users/cnellington/repos", "events_url": "https://api.github.com/users/cnellington/events{/privacy}", "received_events_url": "https://api.github.com/users/cnellington/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-01T23:13:30
2023-06-02T18:12:50
2023-06-02T18:12:50
CONTRIBUTOR
null
### System Info update_document only embeds a single document, but the single page_content string is cast to a list before embedding, resulting in a per-character embedding not a per-document embedding. https://github.com/hwchase17/langchain/blob/4c572ffe959957b515528a9036b374f56cef027f/langchain/vectorstores/chroma.py#LL359C70-L359C70 ### Who can help? Related to @dev2049 vectorstores ### Information - [ ] The official example notebooks/scripts - [ ] My own modified scripts ### Related Components - [ ] LLMs/Chat Models - [ ] Embedding Models - [ ] Prompts / Prompt Templates / Prompt Selectors - [ ] Output Parsers - [ ] Document Loaders - [X] Vector Stores / Retrievers - [ ] Memory - [ ] Agents / Agent Executors - [ ] Tools / Toolkits - [ ] Chains - [ ] Callbacks/Tracing - [ ] Async ### Reproduction ``` from langchain.docstore.document import Document from langchain.vectorstores import Chroma from tests.integration_tests.vectorstores.fake_embeddings import FakeEmbeddings # Initial document content and id initial_content = "foo" document_id = "doc1" # Create an instance of Document with initial content and metadata original_doc = Document(page_content=initial_content, metadata={"page": "0"}) # Initialize a Chroma instance with the original document docsearch = Chroma.from_documents( collection_name="test_collection", documents=[original_doc], embedding=FakeEmbeddings(), ids=[document_id], ) # Define updated content for the document updated_content = "updated foo" # Create a new Document instance with the updated content and the same id updated_doc = Document(page_content=updated_content, metadata={"page": "0"}) # Update the document in the Chroma instance docsearch.update_document(document_id=document_id, document=updated_doc) docsearch_peek = docsearch._collection.peek() new_embedding = docsearch_peek['embeddings'][docsearch_peek['ids'].index(document_id)] assert new_embedding \ == docsearch._embedding_function.embed_documents([updated_content[0]])[0] \ == docsearch._embedding_function.embed_documents(list(updated_content))[0] \ == docsearch._embedding_function.embed_documents(['u'])[0] assert new_embedding == docsearch._embedding_function.embed_documents([updated_content])[0] ``` ### Expected behavior The last assertion should be true ``` assert new_embedding == docsearch._embedding_function.embed_documents([updated_content])[0] ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5582/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5582/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5581
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5581/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5581/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5581/events
https://github.com/langchain-ai/langchain/pull/5581
1,737,136,788
PR_kwDOIPDwls5R8is4
5,581
human approval callback
{ "login": "dev2049", "id": 130488702, "node_id": "U_kgDOB8cZfg", "avatar_url": "https://avatars.githubusercontent.com/u/130488702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev2049", "html_url": "https://github.com/dev2049", "followers_url": "https://api.github.com/users/dev2049/followers", "following_url": "https://api.github.com/users/dev2049/following{/other_user}", "gists_url": "https://api.github.com/users/dev2049/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev2049/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev2049/subscriptions", "organizations_url": "https://api.github.com/users/dev2049/orgs", "repos_url": "https://api.github.com/users/dev2049/repos", "events_url": "https://api.github.com/users/dev2049/events{/privacy}", "received_events_url": "https://api.github.com/users/dev2049/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-01T21:41:59
2023-06-02T13:59:34
2023-06-02T13:59:33
CONTRIBUTOR
null
![Screenshot 2023-06-01 at 2 39 40 PM](https://github.com/hwchase17/langchain/assets/130488702/769f1480-7e51-46d9-bcde-698d0b091803)
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5581/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5581/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5581", "html_url": "https://github.com/langchain-ai/langchain/pull/5581", "diff_url": "https://github.com/langchain-ai/langchain/pull/5581.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5581.patch", "merged_at": "2023-06-02T13:59:33" }
https://api.github.com/repos/langchain-ai/langchain/issues/5580
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5580/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5580/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5580/events
https://github.com/langchain-ai/langchain/pull/5580
1,737,135,340
PR_kwDOIPDwls5R8iZE
5,580
Create OpenAIWhisperParser for generating Documents from audio files
{ "login": "rlancemartin", "id": 122662504, "node_id": "U_kgDOB0-uaA", "avatar_url": "https://avatars.githubusercontent.com/u/122662504?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rlancemartin", "html_url": "https://github.com/rlancemartin", "followers_url": "https://api.github.com/users/rlancemartin/followers", "following_url": "https://api.github.com/users/rlancemartin/following{/other_user}", "gists_url": "https://api.github.com/users/rlancemartin/gists{/gist_id}", "starred_url": "https://api.github.com/users/rlancemartin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rlancemartin/subscriptions", "organizations_url": "https://api.github.com/users/rlancemartin/orgs", "repos_url": "https://api.github.com/users/rlancemartin/repos", "events_url": "https://api.github.com/users/rlancemartin/events{/privacy}", "received_events_url": "https://api.github.com/users/rlancemartin/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-01T21:40:21
2023-06-05T22:51:14
2023-06-05T22:51:14
COLLABORATOR
null
# OpenAIWhisperParser This PR creates a new parser, `OpenAIWhisperParser`, that uses the [OpenAI Whisper model](https://platform.openai.com/docs/guides/speech-to-text/quickstart) to perform transcription of audio files to text (`Documents`). Please see the notebook for usage.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5580/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5580/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5580", "html_url": "https://github.com/langchain-ai/langchain/pull/5580", "diff_url": "https://github.com/langchain-ai/langchain/pull/5580.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5580.patch", "merged_at": "2023-06-05T22:51:14" }
https://api.github.com/repos/langchain-ai/langchain/issues/5579
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5579/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5579/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5579/events
https://github.com/langchain-ai/langchain/pull/5579
1,737,124,635
PR_kwDOIPDwls5R8gEY
5,579
Add a "paged" mode for unstructured to include page number in metadata
{ "login": "rsanaie", "id": 1197498, "node_id": "MDQ6VXNlcjExOTc0OTg=", "avatar_url": "https://avatars.githubusercontent.com/u/1197498?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rsanaie", "html_url": "https://github.com/rsanaie", "followers_url": "https://api.github.com/users/rsanaie/followers", "following_url": "https://api.github.com/users/rsanaie/following{/other_user}", "gists_url": "https://api.github.com/users/rsanaie/gists{/gist_id}", "starred_url": "https://api.github.com/users/rsanaie/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rsanaie/subscriptions", "organizations_url": "https://api.github.com/users/rsanaie/orgs", "repos_url": "https://api.github.com/users/rsanaie/repos", "events_url": "https://api.github.com/users/rsanaie/events{/privacy}", "received_events_url": "https://api.github.com/users/rsanaie/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
4
2023-06-01T21:30:10
2023-06-20T05:07:30
2023-06-20T05:07:29
CONTRIBUTOR
null
# Support "paged" mode for unstructured loader <!-- UnstructuredPDF Loader now supports the mode "paged". This ensures content returned that are from the same page within the PDF are combined into a single Document object with metadata referencing back the page this content came from. Twitter @RayzerCA --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead DataLoaders - @eyurtsev -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5579/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5579/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5579", "html_url": "https://github.com/langchain-ai/langchain/pull/5579", "diff_url": "https://github.com/langchain-ai/langchain/pull/5579.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5579.patch", "merged_at": "2023-06-20T05:07:29" }
https://api.github.com/repos/langchain-ai/langchain/issues/5578
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5578/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5578/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5578/events
https://github.com/langchain-ai/langchain/pull/5578
1,737,113,596
PR_kwDOIPDwls5R8dnT
5,578
nit
{ "login": "dev2049", "id": 130488702, "node_id": "U_kgDOB8cZfg", "avatar_url": "https://avatars.githubusercontent.com/u/130488702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev2049", "html_url": "https://github.com/dev2049", "followers_url": "https://api.github.com/users/dev2049/followers", "following_url": "https://api.github.com/users/dev2049/following{/other_user}", "gists_url": "https://api.github.com/users/dev2049/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev2049/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev2049/subscriptions", "organizations_url": "https://api.github.com/users/dev2049/orgs", "repos_url": "https://api.github.com/users/dev2049/repos", "events_url": "https://api.github.com/users/dev2049/events{/privacy}", "received_events_url": "https://api.github.com/users/dev2049/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-01T21:21:10
2023-06-01T21:21:16
2023-06-01T21:21:15
CONTRIBUTOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5578/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5578/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5578", "html_url": "https://github.com/langchain-ai/langchain/pull/5578", "diff_url": "https://github.com/langchain-ai/langchain/pull/5578.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5578.patch", "merged_at": "2023-06-01T21:21:15" }
https://api.github.com/repos/langchain-ai/langchain/issues/5577
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5577/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5577/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5577/events
https://github.com/langchain-ai/langchain/issues/5577
1,737,107,384
I_kwDOIPDwls5niie4
5,577
Issue: How to run GPT4All on GPU?
{ "login": "PavelAgurov", "id": 37487002, "node_id": "MDQ6VXNlcjM3NDg3MDAy", "avatar_url": "https://avatars.githubusercontent.com/u/37487002?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PavelAgurov", "html_url": "https://github.com/PavelAgurov", "followers_url": "https://api.github.com/users/PavelAgurov/followers", "following_url": "https://api.github.com/users/PavelAgurov/following{/other_user}", "gists_url": "https://api.github.com/users/PavelAgurov/gists{/gist_id}", "starred_url": "https://api.github.com/users/PavelAgurov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PavelAgurov/subscriptions", "organizations_url": "https://api.github.com/users/PavelAgurov/orgs", "repos_url": "https://api.github.com/users/PavelAgurov/repos", "events_url": "https://api.github.com/users/PavelAgurov/events{/privacy}", "received_events_url": "https://api.github.com/users/PavelAgurov/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
3
2023-06-01T21:15:36
2024-01-09T11:56:26
2023-06-06T19:10:22
NONE
null
### Issue you'd like to raise. Is it possible at all to run Gpt4All on GPU? For example for llamacpp I see parameter n_gpu_layers, but for gpt4all.py - not. Sorry for stupid question :) ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5577/reactions", "total_count": 3, "+1": 3, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5577/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5576
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5576/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5576/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5576/events
https://github.com/langchain-ai/langchain/issues/5576
1,737,034,627
I_kwDOIPDwls5niQuD
5,576
ConversationSummaryBufferMemory (enhanced)
{ "login": "jsandlerus", "id": 46496940, "node_id": "MDQ6VXNlcjQ2NDk2OTQw", "avatar_url": "https://avatars.githubusercontent.com/u/46496940?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jsandlerus", "html_url": "https://github.com/jsandlerus", "followers_url": "https://api.github.com/users/jsandlerus/followers", "following_url": "https://api.github.com/users/jsandlerus/following{/other_user}", "gists_url": "https://api.github.com/users/jsandlerus/gists{/gist_id}", "starred_url": "https://api.github.com/users/jsandlerus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jsandlerus/subscriptions", "organizations_url": "https://api.github.com/users/jsandlerus/orgs", "repos_url": "https://api.github.com/users/jsandlerus/repos", "events_url": "https://api.github.com/users/jsandlerus/events{/privacy}", "received_events_url": "https://api.github.com/users/jsandlerus/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-01T20:25:30
2023-09-10T16:08:50
2023-09-10T16:08:49
NONE
null
### Feature request Currently, ConversationSummaryBufferMemory generates a summary of the conversation, then it passes this as part of the prompt to the MLL. The ConversationSummaryTokenBufferMemory will limit the size of the summary to X number of tokens, and it will remove data if necessary. I believe adding one more parameter that overrides the max token limit and defaults it to 2000(current token limit) should be enough. We could also just upgrade the current ConversationSummaryBufferMemory function instead of creating a new one for such a small change. ### Motivation I have not found a way to limit the size of the summary created by ConversationSummaryBufferMemory. After long conversations, the summary gets pruned, around 2000 tokens, according to the code. A good use case will be to have control over the number of tokens being sent to the API. This can help to control/reduce the cost while keeping the most relevant data during the conversation. I think this is a very simple change to do but can provide great control. ### Your contribution I'm sorry, I don't feel confident enough to make a PR. class ConversationSummaryTokenBufferMemory(BaseChatMemory, SummarizerMixin, MaxSummaryTokenLimit=2000): """Buffer with summarizer for storing conversation memory.""" max_token_limit: MaxSummaryTokenLimit moving_summary_buffer: str = "" memory_key: str = "history" [...]
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5576/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5576/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5575
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5575/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5575/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5575/events
https://github.com/langchain-ai/langchain/pull/5575
1,736,958,135
PR_kwDOIPDwls5R77UV
5,575
Refactor and update databricks integration page
{ "login": "liangz1", "id": 7851093, "node_id": "MDQ6VXNlcjc4NTEwOTM=", "avatar_url": "https://avatars.githubusercontent.com/u/7851093?v=4", "gravatar_id": "", "url": "https://api.github.com/users/liangz1", "html_url": "https://github.com/liangz1", "followers_url": "https://api.github.com/users/liangz1/followers", "following_url": "https://api.github.com/users/liangz1/following{/other_user}", "gists_url": "https://api.github.com/users/liangz1/gists{/gist_id}", "starred_url": "https://api.github.com/users/liangz1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/liangz1/subscriptions", "organizations_url": "https://api.github.com/users/liangz1/orgs", "repos_url": "https://api.github.com/users/liangz1/repos", "events_url": "https://api.github.com/users/liangz1/events{/privacy}", "received_events_url": "https://api.github.com/users/liangz1/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
3
2023-06-01T19:34:47
2023-06-08T03:45:47
2023-06-08T03:45:47
CONTRIBUTOR
null
# Your PR Title (What it does) <!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5575/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5575/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5575", "html_url": "https://github.com/langchain-ai/langchain/pull/5575", "diff_url": "https://github.com/langchain-ai/langchain/pull/5575.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5575.patch", "merged_at": "2023-06-08T03:45:47" }
https://api.github.com/repos/langchain-ai/langchain/issues/5574
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5574/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5574/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5574/events
https://github.com/langchain-ai/langchain/pull/5574
1,736,929,993
PR_kwDOIPDwls5R71Lq
5,574
Fix bedrock boto3 client instantiation
{ "login": "seanpmorgan", "id": 18154355, "node_id": "MDQ6VXNlcjE4MTU0MzU1", "avatar_url": "https://avatars.githubusercontent.com/u/18154355?v=4", "gravatar_id": "", "url": "https://api.github.com/users/seanpmorgan", "html_url": "https://github.com/seanpmorgan", "followers_url": "https://api.github.com/users/seanpmorgan/followers", "following_url": "https://api.github.com/users/seanpmorgan/following{/other_user}", "gists_url": "https://api.github.com/users/seanpmorgan/gists{/gist_id}", "starred_url": "https://api.github.com/users/seanpmorgan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/seanpmorgan/subscriptions", "organizations_url": "https://api.github.com/users/seanpmorgan/orgs", "repos_url": "https://api.github.com/users/seanpmorgan/repos", "events_url": "https://api.github.com/users/seanpmorgan/events{/privacy}", "received_events_url": "https://api.github.com/users/seanpmorgan/received_events", "type": "User", "site_admin": false }
[ { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
3
2023-06-01T19:13:52
2023-06-02T17:56:49
2023-06-01T19:35:06
CONTRIBUTOR
null
https://github.com/hwchase17/langchain/pull/5523 has a small bug if client was not passed in constructor ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5574/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5574/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5574", "html_url": "https://github.com/langchain-ai/langchain/pull/5574", "diff_url": "https://github.com/langchain-ai/langchain/pull/5574.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5574.patch", "merged_at": "2023-06-01T19:35:06" }
https://api.github.com/repos/langchain-ai/langchain/issues/5573
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5573/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5573/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5573/events
https://github.com/langchain-ai/langchain/pull/5573
1,736,849,027
PR_kwDOIPDwls5R7jQ4
5,573
Add missing comma in conv chat agent prompt json
{ "login": "andrewlei", "id": 1158058, "node_id": "MDQ6VXNlcjExNTgwNTg=", "avatar_url": "https://avatars.githubusercontent.com/u/1158058?v=4", "gravatar_id": "", "url": "https://api.github.com/users/andrewlei", "html_url": "https://github.com/andrewlei", "followers_url": "https://api.github.com/users/andrewlei/followers", "following_url": "https://api.github.com/users/andrewlei/following{/other_user}", "gists_url": "https://api.github.com/users/andrewlei/gists{/gist_id}", "starred_url": "https://api.github.com/users/andrewlei/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/andrewlei/subscriptions", "organizations_url": "https://api.github.com/users/andrewlei/orgs", "repos_url": "https://api.github.com/users/andrewlei/repos", "events_url": "https://api.github.com/users/andrewlei/events{/privacy}", "received_events_url": "https://api.github.com/users/andrewlei/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-01T18:18:28
2023-06-01T20:15:42
2023-06-01T19:12:45
CONTRIBUTOR
null
# Add missing comma in conversational chat agent prompt json Inspired by: https://github.com/hwchase17/langchainjs/pull/1498 <!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> ## Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: Agents / Tools / Toolkits - @vowelparrot <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5573/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5573/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5573", "html_url": "https://github.com/langchain-ai/langchain/pull/5573", "diff_url": "https://github.com/langchain-ai/langchain/pull/5573.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5573.patch", "merged_at": "2023-06-01T19:12:45" }
https://api.github.com/repos/langchain-ai/langchain/issues/5572
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5572/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5572/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5572/events
https://github.com/langchain-ai/langchain/pull/5572
1,736,819,086
PR_kwDOIPDwls5R7ckg
5,572
propagate callbacks to ConversationalRetrievalChain
{ "login": "alecf", "id": 135340, "node_id": "MDQ6VXNlcjEzNTM0MA==", "avatar_url": "https://avatars.githubusercontent.com/u/135340?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alecf", "html_url": "https://github.com/alecf", "followers_url": "https://api.github.com/users/alecf/followers", "following_url": "https://api.github.com/users/alecf/following{/other_user}", "gists_url": "https://api.github.com/users/alecf/gists{/gist_id}", "starred_url": "https://api.github.com/users/alecf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alecf/subscriptions", "organizations_url": "https://api.github.com/users/alecf/orgs", "repos_url": "https://api.github.com/users/alecf/repos", "events_url": "https://api.github.com/users/alecf/events{/privacy}", "received_events_url": "https://api.github.com/users/alecf/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
5
2023-06-01T18:00:36
2023-06-20T20:31:34
2023-06-08T03:25:22
CONTRIBUTOR
null
# Allow callbacks to monitor ConversationalRetrievalChain <!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> I ran into an issue where load_qa_chain was not passing the callbacks down to the child LLM chains, and so made sure that callbacks are propagated. There are probably more improvements to do here but this seemed like a good place to stop. Note that I saw a lot of references to callbacks_manager, which seems to be deprecated. I left that code alone for now. ## Before submitting <!-- If you're adding a new integration, please include: 1. a test for the integration - favor unit tests that does not rely on network access. 2. an example notebook showing its use See contribution guidelines for more information on how to write tests, lint etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @agola11 <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5572/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5572/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5572", "html_url": "https://github.com/langchain-ai/langchain/pull/5572", "diff_url": "https://github.com/langchain-ai/langchain/pull/5572.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5572.patch", "merged_at": "2023-06-08T03:25:22" }
https://api.github.com/repos/langchain-ai/langchain/issues/5571
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5571/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5571/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5571/events
https://github.com/langchain-ai/langchain/pull/5571
1,736,727,778
PR_kwDOIPDwls5R7Ii8
5,571
Fix typo in docugami.ipynb
{ "login": "eltociear", "id": 22633385, "node_id": "MDQ6VXNlcjIyNjMzMzg1", "avatar_url": "https://avatars.githubusercontent.com/u/22633385?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eltociear", "html_url": "https://github.com/eltociear", "followers_url": "https://api.github.com/users/eltociear/followers", "following_url": "https://api.github.com/users/eltociear/following{/other_user}", "gists_url": "https://api.github.com/users/eltociear/gists{/gist_id}", "starred_url": "https://api.github.com/users/eltociear/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eltociear/subscriptions", "organizations_url": "https://api.github.com/users/eltociear/orgs", "repos_url": "https://api.github.com/users/eltociear/repos", "events_url": "https://api.github.com/users/eltociear/events{/privacy}", "received_events_url": "https://api.github.com/users/eltociear/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-01T16:53:57
2023-06-01T18:45:57
2023-06-01T18:45:56
CONTRIBUTOR
null
# Fix typo in docugami.ipynb <!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> <!-- Remove if not applicable --> Fixed typo. infromation -> information
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5571/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5571/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5571", "html_url": "https://github.com/langchain-ai/langchain/pull/5571", "diff_url": "https://github.com/langchain-ai/langchain/pull/5571.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5571.patch", "merged_at": "2023-06-01T18:45:56" }
https://api.github.com/repos/langchain-ai/langchain/issues/5570
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5570/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5570/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5570/events
https://github.com/langchain-ai/langchain/pull/5570
1,736,654,491
PR_kwDOIPDwls5R64T6
5,570
StructuredQuery: "and/or" Operation should never have just one argument
{ "login": "ryderwishart", "id": 19649268, "node_id": "MDQ6VXNlcjE5NjQ5MjY4", "avatar_url": "https://avatars.githubusercontent.com/u/19649268?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ryderwishart", "html_url": "https://github.com/ryderwishart", "followers_url": "https://api.github.com/users/ryderwishart/followers", "following_url": "https://api.github.com/users/ryderwishart/following{/other_user}", "gists_url": "https://api.github.com/users/ryderwishart/gists{/gist_id}", "starred_url": "https://api.github.com/users/ryderwishart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ryderwishart/subscriptions", "organizations_url": "https://api.github.com/users/ryderwishart/orgs", "repos_url": "https://api.github.com/users/ryderwishart/repos", "events_url": "https://api.github.com/users/ryderwishart/events{/privacy}", "received_events_url": "https://api.github.com/users/ryderwishart/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
4
2023-06-01T16:09:55
2023-06-03T22:19:08
2023-06-03T22:19:07
NONE
null
# StructuredQuery: "and/or" Operation should never have just one argument This PR adds a validation step for StructuredQuery instances with single-argument and/or Operations ## Context I have some metadata attributes on my Chroma docs, and I create a `SelfQueryRetriever` with this information: ```python from langchain.llms import OpenAI from langchain.retrievers.self_query.base import SelfQueryRetriever from langchain.chains.query_constructor.base import AttributeInfo metadata_field_info=[ AttributeInfo( name="source", description="File path to the source document", type="string", ), AttributeInfo( name="data_scope", description="Type/scope of linguistic data in document", type="string", ), AttributeInfo( name="verse_ref", description="Complete BOK CH:VS reference for verse (in USFM format)", type="string", ), AttributeInfo( name="book", description="Book name", type="string", ), AttributeInfo( name="chapter", description="Chapter number", type="integer", ), AttributeInfo( name="verse", description="Verse number", type="integer", ), ] document_content_description = "Linguistic data about a bible verse" retriever = SelfQueryRetriever.from_llm(llm, context_chroma, document_content_description, metadata_field_info, verbose=True) ``` ## Problem encountered When I try to retrieve documents, the parser may return a `StructuredQuery` with only one argument wrapped in an `Operation` (e.g., 'and', 'or'). Input: ```python print(retriever.get_relevant_documents('jesus speaks to peter in the book of matthew')) ``` Output (with some extra print statements): ```python these were the inputs: {'query': 'jesus speaks to peter in the book of matthew'} this was the query: query='jesus speaks to peter' filter=Operation(operator=<Operator.AND: 'and'>, arguments=[Comparison(comparator=<Comparator.EQ: 'eq'>, attribute='book', value='Matthew')]) limit=None ``` And then we encounter an error when we try to actually query the Chroma database: ```python --------------------------------------------------------------------------- ValueError Traceback (most recent call last) Cell In[28], line 1 ----> 1 print(retriever.get_relevant_documents('jesus speaks to peter in the book of matthew')) 2 print(retriever.get_relevant_documents('jesus speaks to peter in Luke 9:20')) File /opt/homebrew/lib/python3.10/site-packages/langchain/retrievers/self_query/base.py:104, in SelfQueryRetriever.get_relevant_documents(self, query) 101 new_kwargs["k"] = structured_query.limit 103 search_kwargs = {**self.search_kwargs, **new_kwargs} --> 104 docs = self.vectorstore.search(new_query, self.search_type, **search_kwargs) 105 return docs File /opt/homebrew/lib/python3.10/site-packages/langchain/vectorstores/base.py:82, in VectorStore.search(self, query, search_type, **kwargs) 80 """Return docs most similar to query using specified search type.""" 81 if search_type == "similarity": ---> 82 return self.similarity_search(query, **kwargs) 83 elif search_type == "mmr": 84 return self.max_marginal_relevance_search(query, **kwargs) File /opt/homebrew/lib/python3.10/site-packages/langchain/vectorstores/chroma.py:182, in Chroma.similarity_search(self, query, k, filter, **kwargs) 165 def similarity_search( 166 self, 167 query: str, (...) 170 **kwargs: Any, 171 ) -> List[Document]: 172 """Run similarity search with Chroma. 173 174 Args: (...) 180 List[Document]: List of documents most similar to the query text. 181 """ --> 182 docs_and_scores = self.similarity_search_with_score(query, k, filter=filter) 183 return [doc for doc, _ in docs_and_scores] File /opt/homebrew/lib/python3.10/site-packages/langchain/vectorstores/chroma.py:229, in Chroma.similarity_search_with_score(self, query, k, filter, **kwargs) 227 else: 228 query_embedding = self._embedding_function.embed_query(query) --> 229 results = self.__query_collection( 230 query_embeddings=[query_embedding], n_results=k, where=filter 231 ) 233 return _results_to_docs_and_scores(results) File /opt/homebrew/lib/python3.10/site-packages/langchain/utils.py:52, in xor_args..decorator..wrapper(*args, **kwargs) 46 invalid_group_names = [", ".join(arg_groups[i]) for i in invalid_groups] 47 raise ValueError( 48 "Exactly one argument in each of the following" 49 " groups must be defined:" 50 f" {', '.join(invalid_group_names)}" 51 ) ---> 52 return func(*args, **kwargs) File /opt/homebrew/lib/python3.10/site-packages/langchain/vectorstores/chroma.py:121, in Chroma.__query_collection(self, query_texts, query_embeddings, n_results, where, **kwargs) 119 for i in range(n_results, 0, -1): 120 try: --> 121 return self._collection.query( 122 query_texts=query_texts, 123 query_embeddings=query_embeddings, 124 n_results=i, 125 where=where, 126 **kwargs, 127 ) 128 except chromadb.errors.NotEnoughElementsException: 129 logger.error( 130 f"Chroma collection {self._collection.name} " 131 f"contains fewer than {i} elements." 132 ) File /opt/homebrew/lib/python3.10/site-packages/chromadb/api/models/Collection.py:188, in Collection.query(self, query_embeddings, query_texts, n_results, where, where_document, include) 161 def query( 162 self, 163 query_embeddings: Optional[OneOrMany[Embedding]] = None, (...) 168 include: Include = ["metadatas", "documents", "distances"], 169 ) -> QueryResult: 170 """Get the n_results nearest neighbor embeddings for provided query_embeddings or query_texts. 171 172 Args: (...) 186 187 """ --> 188 where = validate_where(where) if where else None 189 where_document = ( 190 validate_where_document(where_document) if where_document else None 191 ) 192 query_embeddings = ( 193 validate_embeddings(maybe_cast_one_to_many(query_embeddings)) 194 if query_embeddings is not None 195 else None 196 ) File /opt/homebrew/lib/python3.10/site-packages/chromadb/api/types.py:148, in validate_where(where) 144 raise ValueError( 145 f"Expected where value for $and or $or to be a list of where expressions, got {value}" 146 ) 147 if len(value) <= 1: --> 148 raise ValueError( 149 f"Expected where value for $and or $or to be a list with at least two where expressions, got {value}" 150 ) 151 for where_expression in value: 152 validate_where(where_expression) ValueError: Expected where value for $and or $or to be a list with at least two where expressions, got [{'book': {'$eq': 'Matthew'}}] ``` ## Solution implemented ### When there should be one argument (and thus no `Operation` wrapper) With my code modifications, this input: ```python # Query that should have only one argument: print(retriever.get_relevant_documents('jesus speaks to peter in the book of matthew')) ``` generates this output: ```python these were the inputs: {'query': 'jesus speaks to peter in the book of matthew'} this was the query: query='jesus speaks to peter' filter=Operation(operator=<Operator.AND: 'and'>, arguments=[Comparison(comparator=<Comparator.EQ: 'eq'>, attribute='book', value='Matthew')]) limit=None Only one argument provided to the Operation. Passing argument directly instead of wrapping in Operation. query='jesus speaks to peter' filter=Comparison(comparator=<Comparator.EQ: 'eq'>, attribute='book', value='Matthew') limit=None [Document(page_content="Social-Situational Context:\n\nThis word is part of the passage 'The Denial of Peter'\n - This passage is a Forewarning/Private Discussion situation, which can be described in typical terms as follows: [...] - Interpersonal activity focus pertains to the social interaction between participants, focusing on their roles, relationships, and attitudes.", metadata={'source': '/Users/ryderwishart/genesis/itemized_prose_contexts/MAT 26:75.txt_Social-Situational.txt', 'data_scope': 'Social-Situational', 'verse_ref': 'MAT 26:75', 'book': 'Matthew', 'chapter': '26', 'verse': '75'})] ``` ### When there should be multiple arguments (and thus there *should be* an `Operation` wrapper) This input: ```python # Query that should have multiple arguments: print(retriever.get_relevant_documents('jesus speaks to peter in Luke 9:20')) ``` generates this output: ```python these were the inputs: {'query': 'jesus speaks to peter in Luke 9:20'} this was the query: query='jesus speaks to peter' filter=Operation(operator=<Operator.AND: 'and'>, arguments=[Comparison(comparator=<Comparator.EQ: 'eq'>, attribute='book', value='Luke'), Comparison(comparator=<Comparator.EQ: 'eq'>, attribute='chapter', value=9), Comparison(comparator=<Comparator.EQ: 'eq'>, attribute='verse', value=20)]) limit=None [Document(page_content="Social-Situational Context:\n\nThis word is part of the passage 'Peter's Confession and Christ's Answer'\n - This passage [...] ός:\n\nDomain label: Whom or What Spoken or Written About\nCultural information for εἰμί:\n\nDomain label: State', metadata={'source': '/Users/ryderwishart/genesis/itemized_prose_contexts/LUK 9:20.txt_Cultural-encyclopedic.txt', 'data_scope': 'Cultural-encyclopedic', 'verse_ref': 'LUK 9:20', 'book': 'Luke', 'chapter': '9', 'verse': '20'})] ``` ### Conclusion In short, the function correctly drops the `Operation` wrapper if there is only one argument passed to it. ## Contribution guidelines I ran the formatting and linting. I don't think any of these linting errors are a result of my code: ```bash % make lint poetry run mypy . langchain/evaluation/loading.py:5: **error:** Incompatible import of **"load_dataset"** (imported name has type **"Callable[[str, Optional[str], Optional[str], Union[str, Sequence[str], Mapping[str, Union[str, Sequence[str]]], None], Union[str, Split, None], Optional[str], Optional[Features], Optional[DownloadConfig], Optional[GenerateMode], bool, Optional[bool], bool, Union[str, Version, None], Union[bool, str, None], Union[str, TaskTemplate, None], bool, Any, KwArg(Any)], Union[DatasetDict, Dataset, IterableDatasetDict, IterableDataset]]"**, local name has type **"Callable[[str], List[Dict[Any, Any]]]"**)  [assignment] langchain/evaluation/loading.py:8: **error:** No overload variant of **"__getitem__"** of **"list"** matches argument type **"str"**  [call-overload] langchain/evaluation/loading.py:8: note: Possible overload variants: langchain/evaluation/loading.py:8: note:     def __getitem__(self, SupportsIndex, /) -> Dict[Any, Any] langchain/evaluation/loading.py:8: note:     def __getitem__(self, slice, /) -> List[Dict[Any, Any]] langchain/vectorstores/mongodb_atlas.py:185: **error:** Argument 1 to **"aggregate"** of **"Collection"** has incompatible type **"List[object]"**; expected **"Sequence[Mapping[str, Any]]"**  [arg-type] langchain/document_loaders/hugging_face_dataset.py:81: **error:** Item **"Dataset"** of **"Union[DatasetDict, Dataset, IterableDatasetDict, IterableDataset]"** has no attribute **"keys"**  [union-attr] langchain/document_loaders/hugging_face_dataset.py:81: **error:** Item **"IterableDataset"** of **"Union[DatasetDict, Dataset, IterableDatasetDict, IterableDataset]"** has no attribute **"keys"**  [union-attr] langchain/document_loaders/hugging_face_dataset.py:82: **error:** Value of type **"Union[DatasetDict, Dataset, IterableDatasetDict, IterableDataset]"** is not indexable  [index] **Found 6 errors in 3 files (checked 1086 source files)** make: *** [lint] Error 1 ``` ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @dev2049 (authored original code) @hwchase17 (co-authored original code)
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5570/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5570/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5570", "html_url": "https://github.com/langchain-ai/langchain/pull/5570", "diff_url": "https://github.com/langchain-ai/langchain/pull/5570.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5570.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5569
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5569/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5569/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5569/events
https://github.com/langchain-ai/langchain/pull/5569
1,736,599,386
PR_kwDOIPDwls5R6r5c
5,569
Es knn index search 5346
{ "login": "jeffvestal", "id": 53237856, "node_id": "MDQ6VXNlcjUzMjM3ODU2", "avatar_url": "https://avatars.githubusercontent.com/u/53237856?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jeffvestal", "html_url": "https://github.com/jeffvestal", "followers_url": "https://api.github.com/users/jeffvestal/followers", "following_url": "https://api.github.com/users/jeffvestal/following{/other_user}", "gists_url": "https://api.github.com/users/jeffvestal/gists{/gist_id}", "starred_url": "https://api.github.com/users/jeffvestal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jeffvestal/subscriptions", "organizations_url": "https://api.github.com/users/jeffvestal/orgs", "repos_url": "https://api.github.com/users/jeffvestal/repos", "events_url": "https://api.github.com/users/jeffvestal/events{/privacy}", "received_events_url": "https://api.github.com/users/jeffvestal/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-01T15:44:09
2023-06-02T15:40:36
2023-06-02T15:40:36
CONTRIBUTOR
null
# Create elastic_vector_search.ElasticKnnSearch class This extends `langchain/vectorstores/elastic_vector_search.py` by adding a new class `ElasticKnnSearch` Features: - Allow creating an index with the `dense_vector` mapping compataible with kNN search - Store embeddings in index for use with kNN search (correct mapping creates HNSW data structure) - Perform approximate kNN search - Perform hybrid BM25 (`query{}`) + kNN (`knn{}`) search - perform knn search by either providing a `query_vector` or passing a hosted `model_id` to use query_vector_builder to automatically generate a query_vector at search time Connection options - Using `cloud_id` from Elastic Cloud - Passing elasticsearch client object search options - query - k - query_vector - model_id - size - source - knn_boost (hybrid search) - query_boost (hybrid search) - fields This also adds examples to `docs/modules/indexes/vectorstores/examples/elasticsearch.ipynb` Fixes # [5346](https://github.com/hwchase17/langchain/issues/5346) cc: @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5569/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5569/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5569", "html_url": "https://github.com/langchain-ai/langchain/pull/5569", "diff_url": "https://github.com/langchain-ai/langchain/pull/5569.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5569.patch", "merged_at": "2023-06-02T15:40:36" }
https://api.github.com/repos/langchain-ai/langchain/issues/5568
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5568/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5568/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5568/events
https://github.com/langchain-ai/langchain/pull/5568
1,736,583,715
PR_kwDOIPDwls5R6ogH
5,568
bump 188
{ "login": "dev2049", "id": 130488702, "node_id": "U_kgDOB8cZfg", "avatar_url": "https://avatars.githubusercontent.com/u/130488702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev2049", "html_url": "https://github.com/dev2049", "followers_url": "https://api.github.com/users/dev2049/followers", "following_url": "https://api.github.com/users/dev2049/following{/other_user}", "gists_url": "https://api.github.com/users/dev2049/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev2049/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev2049/subscriptions", "organizations_url": "https://api.github.com/users/dev2049/orgs", "repos_url": "https://api.github.com/users/dev2049/repos", "events_url": "https://api.github.com/users/dev2049/events{/privacy}", "received_events_url": "https://api.github.com/users/dev2049/received_events", "type": "User", "site_admin": false }
[ { "id": 5010622926, "node_id": "LA_kwDOIPDwls8AAAABKqgJzg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/release", "name": "release", "color": "07D4BE", "default": false, "description": "" } ]
closed
false
null
[]
null
0
2023-06-01T15:34:12
2023-06-01T15:50:55
2023-06-01T15:50:55
CONTRIBUTOR
null
null
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5568/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5568/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5568", "html_url": "https://github.com/langchain-ai/langchain/pull/5568", "diff_url": "https://github.com/langchain-ai/langchain/pull/5568.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5568.patch", "merged_at": "2023-06-01T15:50:55" }
https://api.github.com/repos/langchain-ai/langchain/issues/5567
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5567/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5567/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5567/events
https://github.com/langchain-ai/langchain/pull/5567
1,736,567,184
PR_kwDOIPDwls5R6k4m
5,567
Qdrant self query
{ "login": "dev2049", "id": 130488702, "node_id": "U_kgDOB8cZfg", "avatar_url": "https://avatars.githubusercontent.com/u/130488702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dev2049", "html_url": "https://github.com/dev2049", "followers_url": "https://api.github.com/users/dev2049/followers", "following_url": "https://api.github.com/users/dev2049/following{/other_user}", "gists_url": "https://api.github.com/users/dev2049/gists{/gist_id}", "starred_url": "https://api.github.com/users/dev2049/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dev2049/subscriptions", "organizations_url": "https://api.github.com/users/dev2049/orgs", "repos_url": "https://api.github.com/users/dev2049/repos", "events_url": "https://api.github.com/users/dev2049/events{/privacy}", "received_events_url": "https://api.github.com/users/dev2049/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-01T15:25:42
2023-06-01T15:40:32
2023-06-01T15:40:31
CONTRIBUTOR
null
add self query abilities to qdrant vectorstore
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5567/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5567/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5567", "html_url": "https://github.com/langchain-ai/langchain/pull/5567", "diff_url": "https://github.com/langchain-ai/langchain/pull/5567.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5567.patch", "merged_at": "2023-06-01T15:40:31" }
https://api.github.com/repos/langchain-ai/langchain/issues/5566
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5566/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5566/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5566/events
https://github.com/langchain-ai/langchain/pull/5566
1,736,507,423
PR_kwDOIPDwls5R6XqN
5,566
Add parameters to send_message() call for vertexai chat models (PaLM2)
{ "login": "khallbobo", "id": 871838, "node_id": "MDQ6VXNlcjg3MTgzOA==", "avatar_url": "https://avatars.githubusercontent.com/u/871838?v=4", "gravatar_id": "", "url": "https://api.github.com/users/khallbobo", "html_url": "https://github.com/khallbobo", "followers_url": "https://api.github.com/users/khallbobo/followers", "following_url": "https://api.github.com/users/khallbobo/following{/other_user}", "gists_url": "https://api.github.com/users/khallbobo/gists{/gist_id}", "starred_url": "https://api.github.com/users/khallbobo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/khallbobo/subscriptions", "organizations_url": "https://api.github.com/users/khallbobo/orgs", "repos_url": "https://api.github.com/users/khallbobo/repos", "events_url": "https://api.github.com/users/khallbobo/events{/privacy}", "received_events_url": "https://api.github.com/users/khallbobo/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
0
2023-06-01T14:54:44
2023-06-05T15:12:17
2023-06-03T22:17:38
CONTRIBUTOR
null
# Ensure parameters are used by vertexai chat models (PaLM2) The current version of the google aiplatform contains a bug where parameters for a chat model are not used as intended. See https://github.com/googleapis/python-aiplatform/issues/2263 Params can be passed both to start_chat() and send_message(); however, the parameters passed to start_chat() will not be used if send_message() is called without the overrides. This is due to the defaults in send_message() being global values rather than None (there is code in send_message() which would use the params from start_chat() if the param passed to send_message() evaluates to False, but that won't happen as the defaults are global values). Fixes # 5531 @hwchase17 @agola11
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5566/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5566/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5566", "html_url": "https://github.com/langchain-ai/langchain/pull/5566", "diff_url": "https://github.com/langchain-ai/langchain/pull/5566.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5566.patch", "merged_at": "2023-06-03T22:17:38" }
https://api.github.com/repos/langchain-ai/langchain/issues/5565
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5565/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5565/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5565/events
https://github.com/langchain-ai/langchain/issues/5565
1,736,477,317
I_kwDOIPDwls5ngIqF
5,565
DOC: mlflow logging for GraphCypherQAChain
{ "login": "gladomat", "id": 17472969, "node_id": "MDQ6VXNlcjE3NDcyOTY5", "avatar_url": "https://avatars.githubusercontent.com/u/17472969?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gladomat", "html_url": "https://github.com/gladomat", "followers_url": "https://api.github.com/users/gladomat/followers", "following_url": "https://api.github.com/users/gladomat/following{/other_user}", "gists_url": "https://api.github.com/users/gladomat/gists{/gist_id}", "starred_url": "https://api.github.com/users/gladomat/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gladomat/subscriptions", "organizations_url": "https://api.github.com/users/gladomat/orgs", "repos_url": "https://api.github.com/users/gladomat/repos", "events_url": "https://api.github.com/users/gladomat/events{/privacy}", "received_events_url": "https://api.github.com/users/gladomat/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-01T14:41:12
2023-09-10T16:08:53
2023-09-10T16:08:53
NONE
null
### Issue with current documentation: I see there is a bit of documentation about the [GraphCypherQAChain](https://python.langchain.com/en/latest/modules/chains/examples/graph_cypher_qa.html). There is also a documentation about using [mlflow with langchain](https://sj-langchain.readthedocs.io/en/latest/ecosystem/mlflow_tracking.html). However, there is no documentation about how to implement both. I tried to figure it out, but I failed. Is there a way to do it or does it have to be implemented? ### Idea or request for content: A description on using GraphCypherQAChain together with prompt logging as provided by mlflow.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5565/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5565/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5564
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5564/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5564/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5564/events
https://github.com/langchain-ai/langchain/pull/5564
1,736,473,352
PR_kwDOIPDwls5R6QEM
5,564
feat: docarray as a retriever
{ "login": "jupyterjazz", "id": 45267439, "node_id": "MDQ6VXNlcjQ1MjY3NDM5", "avatar_url": "https://avatars.githubusercontent.com/u/45267439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jupyterjazz", "html_url": "https://github.com/jupyterjazz", "followers_url": "https://api.github.com/users/jupyterjazz/followers", "following_url": "https://api.github.com/users/jupyterjazz/following{/other_user}", "gists_url": "https://api.github.com/users/jupyterjazz/gists{/gist_id}", "starred_url": "https://api.github.com/users/jupyterjazz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jupyterjazz/subscriptions", "organizations_url": "https://api.github.com/users/jupyterjazz/orgs", "repos_url": "https://api.github.com/users/jupyterjazz/repos", "events_url": "https://api.github.com/users/jupyterjazz/events{/privacy}", "received_events_url": "https://api.github.com/users/jupyterjazz/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-01T14:38:54
2023-06-01T14:40:20
2023-06-01T14:40:20
CONTRIBUTOR
null
https://github.com/docarray/docarray/issues/1599
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5564/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5564/timeline
null
null
true
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5564", "html_url": "https://github.com/langchain-ai/langchain/pull/5564", "diff_url": "https://github.com/langchain-ai/langchain/pull/5564.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5564.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5563
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5563/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5563/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5563/events
https://github.com/langchain-ai/langchain/pull/5563
1,736,402,725
PR_kwDOIPDwls5R6Apk
5,563
Documentation fixes (linting and broken links)
{ "login": "sseide", "id": 5168949, "node_id": "MDQ6VXNlcjUxNjg5NDk=", "avatar_url": "https://avatars.githubusercontent.com/u/5168949?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sseide", "html_url": "https://github.com/sseide", "followers_url": "https://api.github.com/users/sseide/followers", "following_url": "https://api.github.com/users/sseide/following{/other_user}", "gists_url": "https://api.github.com/users/sseide/gists{/gist_id}", "starred_url": "https://api.github.com/users/sseide/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sseide/subscriptions", "organizations_url": "https://api.github.com/users/sseide/orgs", "repos_url": "https://api.github.com/users/sseide/repos", "events_url": "https://api.github.com/users/sseide/events{/privacy}", "received_events_url": "https://api.github.com/users/sseide/received_events", "type": "User", "site_admin": false }
[ { "id": 4678528810, "node_id": "LA_kwDOIPDwls8AAAABFtyvKg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/documentation", "name": "documentation", "color": "0075ca", "default": true, "description": "Improvements or additions to documentation" }, { "id": 5454193895, "node_id": "LA_kwDOIPDwls8AAAABRRhk5w", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/lgtm", "name": "lgtm", "color": "0E8A16", "default": false, "description": "" } ]
closed
false
null
[]
null
1
2023-06-01T14:01:57
2023-06-09T09:14:24
2023-06-01T20:06:17
CONTRIBUTOR
null
# Lint sphinx documentation and fix broken links This PR lints multiple warnings shown in generation of the project documentation (using "make docs_linkcheck" and "make docs_build"). Additionally documentation internal links to (now?) non-existent files are modified to point to existing documents as it seemed the new correct target. The documentation is not updated content wise. There are no source code changes. Fixes # (issue) - broken documentation links to other files within the project - sphinx formatting (linting) ## Before submitting No source code changes, so no new tests added. ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @vowelparrot VectorStores / Retrievers / Memory - @dev2049 -->
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5563/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5563/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5563", "html_url": "https://github.com/langchain-ai/langchain/pull/5563", "diff_url": "https://github.com/langchain-ai/langchain/pull/5563.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5563.patch", "merged_at": "2023-06-01T20:06:17" }
https://api.github.com/repos/langchain-ai/langchain/issues/5562
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5562/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5562/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5562/events
https://github.com/langchain-ai/langchain/issues/5562
1,736,331,518
I_kwDOIPDwls5nflD-
5,562
Issue: does the stream of load_summarize_chain work?
{ "login": "legriser", "id": 1306479, "node_id": "MDQ6VXNlcjEzMDY0Nzk=", "avatar_url": "https://avatars.githubusercontent.com/u/1306479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/legriser", "html_url": "https://github.com/legriser", "followers_url": "https://api.github.com/users/legriser/followers", "following_url": "https://api.github.com/users/legriser/following{/other_user}", "gists_url": "https://api.github.com/users/legriser/gists{/gist_id}", "starred_url": "https://api.github.com/users/legriser/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/legriser/subscriptions", "organizations_url": "https://api.github.com/users/legriser/orgs", "repos_url": "https://api.github.com/users/legriser/repos", "events_url": "https://api.github.com/users/legriser/events{/privacy}", "received_events_url": "https://api.github.com/users/legriser/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
3
2023-06-01T13:27:12
2023-09-28T09:39:03
2023-09-28T09:39:03
NONE
null
### Issue you'd like to raise. I tried adding stream to reduce_llm like the code below to make it work but it doesn't seem to work. ``` reduce_llm = OpenAI( streaming=True, verbose=True, callback_manager=callback, temperature=0, max_tokens=1000, ) llm = OpenAI( temperature=0, max_tokens=500, batch_size=2, ) summarize_chain = load_summarize_chain( llm=llm, reduce_llm=reduce_llm, chain_type="map_reduce", map_prompt=map_prompt, combine_prompt=combine_prompt, ) return await summarize_chain.arun(...) ``` ``` /lib/python3.10/site-packages/langchain/llms/base.py:133: RuntimeWarning: coroutine 'AsyncCallbackManager.on_llm_start' was never awaited self.callback_manager.on_llm_start( RuntimeWarning: Enable tracemalloc to get the object allocation traceback lib/python3.10/site-packages/langchain/llms/openai.py:284: RuntimeWarning: coroutine 'AsyncCallbackManager.on_llm_new_token' was never awaited self.callback_manager.on_llm_new_token( RuntimeWarning: Enable tracemalloc to get the object allocation traceback /lib/python3.10/site-packages/langchain/llms/base.py:141: RuntimeWarning: coroutine 'AsyncCallbackManager.on_llm_end' was never awaited ``` Please let me know if I'm doing something wrong or if there's any other good way. Thank you. ### Suggestion: _No response_
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5562/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5562/timeline
null
completed
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5561
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5561/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5561/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5561/events
https://github.com/langchain-ai/langchain/issues/5561
1,736,327,704
I_kwDOIPDwls5nfkIY
5,561
prompt issue and handling answers
{ "login": "geg00", "id": 10646838, "node_id": "MDQ6VXNlcjEwNjQ2ODM4", "avatar_url": "https://avatars.githubusercontent.com/u/10646838?v=4", "gravatar_id": "", "url": "https://api.github.com/users/geg00", "html_url": "https://github.com/geg00", "followers_url": "https://api.github.com/users/geg00/followers", "following_url": "https://api.github.com/users/geg00/following{/other_user}", "gists_url": "https://api.github.com/users/geg00/gists{/gist_id}", "starred_url": "https://api.github.com/users/geg00/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/geg00/subscriptions", "organizations_url": "https://api.github.com/users/geg00/orgs", "repos_url": "https://api.github.com/users/geg00/repos", "events_url": "https://api.github.com/users/geg00/events{/privacy}", "received_events_url": "https://api.github.com/users/geg00/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
3
2023-06-01T13:24:54
2023-08-31T16:17:37
2023-08-31T16:17:37
NONE
null
### Issue you'd like to raise. ``` prompt_template = """Use the following pieces of context to answer the question at the end based on the examples provided in between ++++++++ If you don't know the answer, just answer with [], don't try to make up an answer. ++++++++ Here are some examples: red: The apple is red yellow: the bannana is yellow Question: What is the color of the bannana? [yellow] ++++++++ red: The apple is red yellow: the bannana is yellow Question: Which ones are fruits? [red, yellow] ++++++++ red: The apple is red yellow: the bannana is yellow Question: Are there any of them blue? [] ++++++++ Now that you know what to do here between ``` provide a similar answer check under Helpful Answer: for more information ``` {context} Question: {question} {format_answer} ``` The examples in between ++++++++ are to understand better the way to produce the answeres The section between ``` are the ones that you will have to elaborate and provide answers. Helpful Answer: Your answer should be [document1] when document1 is the pertinent answer Your answer should be [document2] when document2 is the pertinent answer The answer should be [document1, document2] when document1 and document2 include the answer or when the answer could be both of the, Not interested why document1 or document2 are better I just need to know which one When you cannot find the answer respond with []""" ``` I'm providing ``` format_answer = output_parser.get_format_instructions() prompt = PromptTemplate( template=prompt_template, input_variables=["context", "question"], partial_variables={"format_answer": format_answer} ) ``` I'm providing context and question with the format document1: text text text document2: text text Question: question goes here? {format_answer} But Azure Open AI answer sometimes with the format specified and some times just spit out the text provided with document1 and document2 Any help? ### Suggestion: I would like to understand more about 1) How to generate consistent answers from the LLM to the same question ==> Good luck with that 2) I would like to understand how to validate the answers better than the "parser" available here.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5561/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5561/timeline
null
not_planned
null
null
https://api.github.com/repos/langchain-ai/langchain/issues/5559
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5559/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5559/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5559/events
https://github.com/langchain-ai/langchain/pull/5559
1,736,193,423
PR_kwDOIPDwls5R5SeW
5,559
Corrects inconsistently misspelled variable name.
{ "login": "patrickkeane", "id": 13934664, "node_id": "MDQ6VXNlcjEzOTM0NjY0", "avatar_url": "https://avatars.githubusercontent.com/u/13934664?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patrickkeane", "html_url": "https://github.com/patrickkeane", "followers_url": "https://api.github.com/users/patrickkeane/followers", "following_url": "https://api.github.com/users/patrickkeane/following{/other_user}", "gists_url": "https://api.github.com/users/patrickkeane/gists{/gist_id}", "starred_url": "https://api.github.com/users/patrickkeane/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patrickkeane/subscriptions", "organizations_url": "https://api.github.com/users/patrickkeane/orgs", "repos_url": "https://api.github.com/users/patrickkeane/repos", "events_url": "https://api.github.com/users/patrickkeane/events{/privacy}", "received_events_url": "https://api.github.com/users/patrickkeane/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
1
2023-06-01T12:13:04
2023-06-01T14:34:16
2023-06-01T14:27:59
CONTRIBUTOR
null
Corrects a spelling error (of the word separator) in several variable names. Three cut/paste instances of this were corrected, amidst instances of it also being named properly, which would likely would lead to issues for someone in the future. Here is one such example: ``` seperators = self.get_separators_for_language(Language.PYTHON) super().__init__(separators=seperators, **kwargs) ``` becomes ``` separators = self.get_separators_for_language(Language.PYTHON) super().__init__(separators=separators, **kwargs) ``` Make test results below: ``` ============================== 708 passed, 52 skipped, 27 warnings in 11.70s ============================== ```
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5559/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5559/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5559", "html_url": "https://github.com/langchain-ai/langchain/pull/5559", "diff_url": "https://github.com/langchain-ai/langchain/pull/5559.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5559.patch", "merged_at": "2023-06-01T14:27:59" }
https://api.github.com/repos/langchain-ai/langchain/issues/5558
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5558/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5558/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5558/events
https://github.com/langchain-ai/langchain/pull/5558
1,736,191,492
PR_kwDOIPDwls5R5SBf
5,558
similarity search with score and threshold in elastic search
{ "login": "deva-ghb", "id": 99424738, "node_id": "U_kgDOBe0Z4g", "avatar_url": "https://avatars.githubusercontent.com/u/99424738?v=4", "gravatar_id": "", "url": "https://api.github.com/users/deva-ghb", "html_url": "https://github.com/deva-ghb", "followers_url": "https://api.github.com/users/deva-ghb/followers", "following_url": "https://api.github.com/users/deva-ghb/following{/other_user}", "gists_url": "https://api.github.com/users/deva-ghb/gists{/gist_id}", "starred_url": "https://api.github.com/users/deva-ghb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/deva-ghb/subscriptions", "organizations_url": "https://api.github.com/users/deva-ghb/orgs", "repos_url": "https://api.github.com/users/deva-ghb/repos", "events_url": "https://api.github.com/users/deva-ghb/events{/privacy}", "received_events_url": "https://api.github.com/users/deva-ghb/received_events", "type": "User", "site_admin": false }
[ { "id": 5541432778, "node_id": "LA_kwDOIPDwls8AAAABSkuNyg", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/area:%20vector%20store", "name": "area: vector store", "color": "D4C5F9", "default": false, "description": "Related to vector store module" }, { "id": 5680700873, "node_id": "LA_kwDOIPDwls8AAAABUpidyQ", "url": "https://api.github.com/repos/langchain-ai/langchain/labels/auto:improvement", "name": "auto:improvement", "color": "FBCA04", "default": false, "description": "Medium size change to existing code to handle new use-cases" } ]
closed
false
null
[]
null
2
2023-06-01T12:12:21
2023-09-13T20:45:40
2023-09-13T20:45:39
NONE
null
Perform a similarity-based search in Elasticsearch, filtering documents based on the specified score threshold. @jeffvestal @sergerdn --> In the ElasticSearch vector store, this function allows ignoring chunks that have a similarity score with the query below a specified threshold.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5558/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5558/timeline
null
null
false
{ "url": "https://api.github.com/repos/langchain-ai/langchain/pulls/5558", "html_url": "https://github.com/langchain-ai/langchain/pull/5558", "diff_url": "https://github.com/langchain-ai/langchain/pull/5558.diff", "patch_url": "https://github.com/langchain-ai/langchain/pull/5558.patch", "merged_at": null }
https://api.github.com/repos/langchain-ai/langchain/issues/5557
https://api.github.com/repos/langchain-ai/langchain
https://api.github.com/repos/langchain-ai/langchain/issues/5557/labels{/name}
https://api.github.com/repos/langchain-ai/langchain/issues/5557/comments
https://api.github.com/repos/langchain-ai/langchain/issues/5557/events
https://github.com/langchain-ai/langchain/issues/5557
1,736,135,856
I_kwDOIPDwls5ne1Sw
5,557
Extendable SequentialChain
{ "login": "realyashnag", "id": 26687805, "node_id": "MDQ6VXNlcjI2Njg3ODA1", "avatar_url": "https://avatars.githubusercontent.com/u/26687805?v=4", "gravatar_id": "", "url": "https://api.github.com/users/realyashnag", "html_url": "https://github.com/realyashnag", "followers_url": "https://api.github.com/users/realyashnag/followers", "following_url": "https://api.github.com/users/realyashnag/following{/other_user}", "gists_url": "https://api.github.com/users/realyashnag/gists{/gist_id}", "starred_url": "https://api.github.com/users/realyashnag/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/realyashnag/subscriptions", "organizations_url": "https://api.github.com/users/realyashnag/orgs", "repos_url": "https://api.github.com/users/realyashnag/repos", "events_url": "https://api.github.com/users/realyashnag/events{/privacy}", "received_events_url": "https://api.github.com/users/realyashnag/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
2
2023-06-01T11:49:10
2023-09-14T16:07:02
2023-09-14T16:07:01
NONE
null
### Feature request I'd like to extend `SequentialChain` to create pre-built class which has a pre-populated list of `chains` in it. Consider the following example: ``` class CoolChain(LLMChain): ... class CalmChain(LLMChain): ... class CoolCalmChain(SequentialChain): llm: BaseLanguageModel chains: List[LLMChain] = [ CoolChain( llm=llm ), CalmChain( llm=llm ) ] ``` This unfortunately cannot happen because the `root_validator` for `SequentialChain` raises error that it cannot find `chains` being passed. ``` Traceback (most recent call last): File "/home/yash/app/main.py", line 17, in <module> ai = CoolCalmChain(llm=my_llm) File "pydantic/main.py", line 339, in pydantic.main.BaseModel.__init__ File "pydantic/main.py", line 1050, in pydantic.main.validate_model File "/home/yash/.venv/lib/python3.10/site-packages/langchain/chains/sequential.py", line 47, in validate_chains chains = values["chains"] KeyError: 'chains' ``` I request that we find a way to bypass the stringent check so that this class can be easily extendable to support pre-built Chains which can be initialised on-the-go. ### Motivation Motivation is to create multiple such "Empty Sequential Classes" which can be populated on-the-go. This saves us from populating parameters that might change for the same `SequentialChain`, such as the `llm` and `memory`, while defining the class itself. I tried to define another `root_validator` to override the SequentialChain one and even that did not work. ### Your contribution Few solutions that I could think of are as follows: - Removing `pre` from the `define_chains` **root_validator** in the `SequentialChain` class. - Using `@validator('chains')` instead, so that one can override it by simply using `pre`.
{ "url": "https://api.github.com/repos/langchain-ai/langchain/issues/5557/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/langchain-ai/langchain/issues/5557/timeline
null
not_planned
null
null