type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/angular/preboot/issues/75","repository_url":"https://api.github.com/repos/angular/preboot","labels_url":"https://api.github.com/repos/angular/preboot/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/angular/preboot/issues/75/comments","events_url":"https://api.github.com/repos/angular/preboot/issues/75/events","html_url":"https://github.com/angular/preboot/issues/75","id":297457206,"node_id":"MDU6SXNzdWUyOTc0NTcyMDY=","number":75,"title":"Big FOUC as server side styles removed before the switch to client side","user":{"login":"mgol","id":1758366,"node_id":"MDQ6VXNlcjE3NTgzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"labels":[{"id":841036243,"node_id":"MDU6TGFiZWw4NDEwMzYyNDM=","url":"https://api.github.com/repos/angular/preboot/labels/related:%20angular-core","name":"related: angular-core","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-02-15T14:05:13Z","updated_at":"2018-09-14T08:06:16Z","closed_at":null,"author_association":"MEMBER","body":"**Note: for support questions, please use the Universal Slack Channcel or https://gitter.im/angular/universal** \r\n\r\n* **I'm submitting a ...**\r\n- [x] bug report\r\n- [ ] feature request\r\n\r\n* **Which parts of preboot are affected by this issue?**\r\n- [ ] server side\r\n- [x] client side\r\n- [ ] inline\r\n- [ ] build process\r\n- [ ] docs\r\n- [ ] tests\r\n\r\n\r\n* **Do you want to request a *feature* or report a *bug*?**\r\n\r\nA bug.\r\n\r\n* **What is the current behavior?**\r\n\r\nServer-side styles are in some scenarios removed by Angular before Preboot switches the app to the client-side one, causing a potentially huge flash of unstyled content.\r\n\r\n* **If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem** by creating a github repo.\r\n\r\n1. Clone https://github.com/mgol/angular-server-bug and follow README instructions to run the app.\r\n2. Load the page & observe it (it may take ~15 seconds).\r\n\r\n* **What is the expected behavior?**\r\n\r\nThere should be no visible app swap. Styles shouldn't disappear before the app is switched to the client side one.\r\n\r\n* **What is the motivation / use case for changing the behavior?**\r\n\r\nCurrent behavior looks really broken to the end user.\r\n\r\n* **Please tell us about your environment:**\r\n\r\n- Browser: Chrome 64\r\n- Language: TypeScript 2.6.2\r\n- OS: macOS\r\n- Platform: Node.js\r\n\r\n\r\n* **Other information** (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)\r\n\r\nThis issue happens if a component is hidden behind `*ngIf` and the condition is set to a truthy one only after some time - in particular, when waiting for a specific HTTP request to finish. Angular thinks the client side app is ready as it bootstrapped correctly and it just waits for the HTTP request to finish to swap the flag. However, Preboot still waits for the app to get stable so it shows the server-side generated one. Unfortunately, its inline styles are already removed and the new ones are not loaded yet as Angular haven't created the component yet client side."},"comment":{"url":"https://api.github.com/repos/angular/preboot/issues/comments/421266570","html_url":"https://github.com/angular/preboot/issues/75#issuecomment-421266570","issue_url":"https://api.github.com/repos/angular/preboot/issues/75","id":421266570,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTI2NjU3MA==","user":{"login":"malengrin","id":216432,"node_id":"MDQ6VXNlcjIxNjQzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/216432?v=4","gravatar_id":"","url":"https://api.github.com/users/malengrin","html_url":"https://github.com/malengrin","followers_url":"https://api.github.com/users/malengrin/followers","following_url":"https://api.github.com/users/malengrin/following{/other_user}","gists_url":"https://api.github.com/users/malengrin/gists{/gist_id}","starred_url":"https://api.github.com/users/malengrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malengrin/subscriptions","organizations_url":"https://api.github.com/users/malengrin/orgs","repos_url":"https://api.github.com/users/malengrin/repos","events_url":"https://api.github.com/users/malengrin/events{/privacy}","received_events_url":"https://api.github.com/users/malengrin/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T08:06:16Z","updated_at":"2018-09-14T08:06:16Z","author_association":"NONE","body":"Thanks for the workaround @Willovent. It's solving this issue, but it breaks the Angular server transfer state. Because `TRANSITION_ID` is not properly provided, Angular generates a random one different from server and browser.\r\nIt's generating a html that looks like:\r\n```html\r\n<html>\r\n <head>\r\n [...]\r\n <style ng-transition=\"my-app\">.foo[_ngcontent-sc0] {}</style>\r\n [...]\r\n </head>\r\n <body>\r\n [...]\r\n <script id=\"gmx-state\" type=\"application/json\">{&q;G.https://...}</script>\r\n ^-> gmx is randomly generated. It should be my-app-state\r\n </body>\r\n</html>\r\n```\r\n\r\nI fixed it by keeping the `BrowserModule.withServerTransition(...)`import and adding this provider to the app module:\r\n```typescript\r\n{\r\n provide: APP_INITIALIZER,\r\n useFactory: function(document: HTMLDocument, platformId: Object): Function {\r\n return () => {\r\n if (isPlatformBrowser(platformId)) {\r\n const dom = ɵgetDOM();\r\n const styles: any[] = Array.prototype.slice.apply(dom.querySelectorAll(document, `style[ng-transition]`));\r\n styles.forEach(el => {\r\n // Remove ng-transition attribute to prevent Angular appInitializerFactory\r\n // to remove server styles before preboot complete\r\n el.removeAttribute('ng-transition');\r\n });\r\n document.addEventListener('PrebootComplete', () => {\r\n // After preboot complete, remove the server scripts\r\n setTimeout(() => styles.forEach(el => dom.remove(el)));\r\n });\r\n }\r\n };\r\n },\r\n deps: [DOCUMENT, PLATFORM_ID],\r\n multi: true\r\n}\r\n```\r\n"}}
|
{
"id": 62827997,
"name": "angular/preboot",
"url": "https://api.github.com/repos/angular/preboot"
}
|
{
"id": 216432,
"login": "malengrin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/216432?",
"url": "https://api.github.com/users/malengrin"
}
|
{
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
}
| 2018-09-14T08:06:16 |
8264520982
|
{"actor":{"display_login":"malengrin"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/angular/material2/issues/12846","repository_url":"https://api.github.com/repos/angular/material2","labels_url":"https://api.github.com/repos/angular/material2/issues/12846/labels{/name}","comments_url":"https://api.github.com/repos/angular/material2/issues/12846/comments","events_url":"https://api.github.com/repos/angular/material2/issues/12846/events","html_url":"https://github.com/angular/material2/issues/12846","id":354248843,"node_id":"MDU6SXNzdWUzNTQyNDg4NDM=","number":12846,"title":"<mat-icon> some icons do not show (e.g. cellular bars)","user":{"login":"RANSoftRA","id":8775880,"node_id":"MDQ6VXNlcjg3NzU4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8775880?v=4","gravatar_id":"","url":"https://api.github.com/users/RANSoftRA","html_url":"https://github.com/RANSoftRA","followers_url":"https://api.github.com/users/RANSoftRA/followers","following_url":"https://api.github.com/users/RANSoftRA/following{/other_user}","gists_url":"https://api.github.com/users/RANSoftRA/gists{/gist_id}","starred_url":"https://api.github.com/users/RANSoftRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RANSoftRA/subscriptions","organizations_url":"https://api.github.com/users/RANSoftRA/orgs","repos_url":"https://api.github.com/users/RANSoftRA/repos","events_url":"https://api.github.com/users/RANSoftRA/events{/privacy}","received_events_url":"https://api.github.com/users/RANSoftRA/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-27T09:35:43Z","updated_at":"2018-08-28T07:39:35Z","closed_at":"2018-08-28T04:32:53Z","author_association":"NONE","body":"#### Bug, feature request, or proposal:\r\nUsing the <mat-icon> component some icons are not being displayed\r\n\r\n`<mat-icon>signal_cellular_2_bar</mat-icon>`\r\n\r\n#### What is the expected behavior?\r\nIcon should be displayed\r\n\r\n#### What is the current behavior?\r\nThe icon does not show\r\n\r\n#### What are the steps to reproduce?\r\nhttps://stackblitz.com/edit/angular-material2-issue-t4adjm?file=app%2Fapp.component.html\r\n\r\n\r\n#### What is the use-case or motivation for changing an existing behavior?\r\nUsers expect that all icons in https://material.io/tools/icons/ are supported.\r\n\r\n#### Which versions of Angular, Material, OS, TypeScript, browsers are affected?\r\nAngular-CLI: 6.1.4\r\nMaterial: 6.4.6 (installed via ng add @angular/material)\r\nOS: Windows 10\r\nTypeScript: 2.7.2\r\nBrowsers: Chrome v68"},"comment":{"url":"https://api.github.com/repos/angular/material2/issues/comments/416482674","html_url":"https://github.com/angular/material2/issues/12846#issuecomment-416482674","issue_url":"https://api.github.com/repos/angular/material2/issues/12846","id":416482674,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjQ4MjY3NA==","user":{"login":"RANSoftRA","id":8775880,"node_id":"MDQ6VXNlcjg3NzU4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8775880?v=4","gravatar_id":"","url":"https://api.github.com/users/RANSoftRA","html_url":"https://github.com/RANSoftRA","followers_url":"https://api.github.com/users/RANSoftRA/followers","following_url":"https://api.github.com/users/RANSoftRA/following{/other_user}","gists_url":"https://api.github.com/users/RANSoftRA/gists{/gist_id}","starred_url":"https://api.github.com/users/RANSoftRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RANSoftRA/subscriptions","organizations_url":"https://api.github.com/users/RANSoftRA/orgs","repos_url":"https://api.github.com/users/RANSoftRA/repos","events_url":"https://api.github.com/users/RANSoftRA/events{/privacy}","received_events_url":"https://api.github.com/users/RANSoftRA/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T07:39:35Z","updated_at":"2018-08-28T07:39:35Z","author_association":"NONE","body":"OK, just found out that the iconfonts have not been updated for a while.\r\n\r\nIssue https://github.com/google/material-design-icons/issues/786"}}
|
{
"id": 49016322,
"name": "angular/material2",
"url": "https://api.github.com/repos/angular/material2"
}
|
{
"id": 8775880,
"login": "RANSoftRA",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8775880?",
"url": "https://api.github.com/users/RANSoftRA"
}
|
{
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
}
| 2018-08-28T07:39:35 |
8176469398
|
{"actor":{"display_login":"RANSoftRA"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular-cli/issues/10322","repository_url":"https://api.github.com/repos/angular/angular-cli","labels_url":"https://api.github.com/repos/angular/angular-cli/issues/10322/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular-cli/issues/10322/comments","events_url":"https://api.github.com/repos/angular/angular-cli/issues/10322/events","html_url":"https://github.com/angular/angular-cli/issues/10322","id":314073402,"number":10322,"title":"registerLocaleData in prod mode causes runtime error with angular 6.0.0-rc.4 and angular-cli 6.0.0-rc.4","user":{"login":"jnizet","id":1608223,"avatar_url":"https://avatars3.githubusercontent.com/u/1608223?v=4","gravatar_id":"","url":"https://api.github.com/users/jnizet","html_url":"https://github.com/jnizet","followers_url":"https://api.github.com/users/jnizet/followers","following_url":"https://api.github.com/users/jnizet/following{/other_user}","gists_url":"https://api.github.com/users/jnizet/gists{/gist_id}","starred_url":"https://api.github.com/users/jnizet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnizet/subscriptions","organizations_url":"https://api.github.com/users/jnizet/orgs","repos_url":"https://api.github.com/users/jnizet/repos","events_url":"https://api.github.com/users/jnizet/events{/privacy}","received_events_url":"https://api.github.com/users/jnizet/received_events","type":"User","site_admin":false},"labels":[{"id":372202272,"url":"https://api.github.com/repos/angular/angular-cli/labels/priority:%202%20(required)","name":"priority: 2 (required)","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":{"login":"filipesilva","id":4172079,"avatar_url":"https://avatars2.githubusercontent.com/u/4172079?v=4","gravatar_id":"","url":"https://api.github.com/users/filipesilva","html_url":"https://github.com/filipesilva","followers_url":"https://api.github.com/users/filipesilva/followers","following_url":"https://api.github.com/users/filipesilva/following{/other_user}","gists_url":"https://api.github.com/users/filipesilva/gists{/gist_id}","starred_url":"https://api.github.com/users/filipesilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipesilva/subscriptions","organizations_url":"https://api.github.com/users/filipesilva/orgs","repos_url":"https://api.github.com/users/filipesilva/repos","events_url":"https://api.github.com/users/filipesilva/events{/privacy}","received_events_url":"https://api.github.com/users/filipesilva/received_events","type":"User","site_admin":false},"assignees":[{"login":"filipesilva","id":4172079,"avatar_url":"https://avatars2.githubusercontent.com/u/4172079?v=4","gravatar_id":"","url":"https://api.github.com/users/filipesilva","html_url":"https://github.com/filipesilva","followers_url":"https://api.github.com/users/filipesilva/followers","following_url":"https://api.github.com/users/filipesilva/following{/other_user}","gists_url":"https://api.github.com/users/filipesilva/gists{/gist_id}","starred_url":"https://api.github.com/users/filipesilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipesilva/subscriptions","organizations_url":"https://api.github.com/users/filipesilva/orgs","repos_url":"https://api.github.com/users/filipesilva/repos","events_url":"https://api.github.com/users/filipesilva/events{/privacy}","received_events_url":"https://api.github.com/users/filipesilva/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular-cli/milestones/9","html_url":"https://github.com/angular/angular-cli/milestone/9","labels_url":"https://api.github.com/repos/angular/angular-cli/milestones/9/labels","id":3260732,"number":9,"title":"v6.0.0","description":"6.0.0 Final Blocking issues.","creator":{"login":"hansl","id":681969,"avatar_url":"https://avatars1.githubusercontent.com/u/681969?v=4","gravatar_id":"","url":"https://api.github.com/users/hansl","html_url":"https://github.com/hansl","followers_url":"https://api.github.com/users/hansl/followers","following_url":"https://api.github.com/users/hansl/following{/other_user}","gists_url":"https://api.github.com/users/hansl/gists{/gist_id}","starred_url":"https://api.github.com/users/hansl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansl/subscriptions","organizations_url":"https://api.github.com/users/hansl/orgs","repos_url":"https://api.github.com/users/hansl/repos","events_url":"https://api.github.com/users/hansl/events{/privacy}","received_events_url":"https://api.github.com/users/hansl/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":60,"state":"open","created_at":"2018-04-12T03:46:52Z","updated_at":"2018-04-30T03:45:56Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-04-13T11:37:19Z","updated_at":"2018-04-30T08:52:54Z","closed_at":"2018-04-24T18:16:11Z","author_association":"CONTRIBUTOR","body":"<!--\r\nWe will close this issue if you don't provide the needed information.\r\nFor feature requests, delete the form below and describe the requirements and use case.\r\n-->\r\n\r\n### Versions\r\n```\r\nAngular CLI: 6.0.0-rc.4\r\nNode: 8.11.1\r\nOS: darwin x64\r\nAngular: 6.0.0-rc.4\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... http, language-service, platform-browser\r\n... platform-browser-dynamic, router\r\n\r\nPackage Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect 0.5.6\r\n@angular-devkit/build-angular 0.5.6\r\n@angular-devkit/build-optimizer 0.5.6\r\n@angular-devkit/core 0.5.6\r\n@angular-devkit/schematics 0.5.6\r\n@ngtools/json-schema 1.1.0\r\n@ngtools/webpack 6.0.0-rc.4\r\n@schematics/angular 0.5.6\r\n@schematics/update 0.5.6\r\nrxjs 6.0.0-turbo-rc.4\r\ntypescript 2.7.2\r\nwebpack 4.5.0\r\n```\r\n\r\n### Repro steps\r\n* create a new project with `ng new`, and make sure to use angular 6.0.0-rc.4 and angular-cli 6.0.0-rc.4 (see versions above)\r\n* Replace app.module.ts by the following file, registering locale data:\r\n```\r\nimport { BrowserModule } from '@angular/platform-browser';\r\nimport { LOCALE_ID, NgModule } from '@angular/core';\r\nimport { registerLocaleData } from '@angular/common';\r\nimport localeFr from '@angular/common/locales/fr';\r\n\r\nimport { AppComponent } from './app.component';\r\n\r\nregisterLocaleData(localeFr);\r\n\r\n@NgModule({\r\n declarations: [\r\n AppComponent\r\n ],\r\n imports: [\r\n BrowserModule\r\n ],\r\n providers: [\r\n { provide: LOCALE_ID, useValue: 'fr' }\r\n ],\r\n bootstrap: [AppComponent]\r\n})\r\nexport class AppModule { }\r\n```\r\n\r\n* Run `ng serve --prod`\r\n* Open a browser at `http://localhost:4200`\r\n\r\nYou can also directly use the repro project at https://github.com/jnizet/clibug.\r\n\r\n### Observed behavior\r\nWhite page, with an error in the console:\r\n```\r\nUncaught TypeError: Cannot read property 'toLowerCase' of undefined\r\n at Object.zUnb (main.ef58e17b9c50a35d8c7e.js:1)\r\n at p (runtime.5f9d33fb31487f0fdbf1.js:1)\r\n at Object.3 (main.ef58e17b9c50a35d8c7e.js:1)\r\n at p (runtime.5f9d33fb31487f0fdbf1.js:1)\r\n at n (runtime.5f9d33fb31487f0fdbf1.js:1)\r\n at Array.e [as push] (runtime.5f9d33fb31487f0fdbf1.js:1)\r\n at main.ef58e17b9c50a35d8c7e.js:1\r\n```\r\n\r\n### Desired behavior\r\nThe page should work fine\r\n\r\n### Mention any other details that might be useful (optional)\r\n\r\n- It works fine when not using `--prod`. \r\n- It works fine with version 1.7.4 of the CLI.\r\n "},"comment":{"url":"https://api.github.com/repos/angular/angular-cli/issues/comments/385343081","html_url":"https://github.com/angular/angular-cli/issues/10322#issuecomment-385343081","issue_url":"https://api.github.com/repos/angular/angular-cli/issues/10322","id":385343081,"user":{"login":"istiti","id":2789203,"avatar_url":"https://avatars1.githubusercontent.com/u/2789203?v=4","gravatar_id":"","url":"https://api.github.com/users/istiti","html_url":"https://github.com/istiti","followers_url":"https://api.github.com/users/istiti/followers","following_url":"https://api.github.com/users/istiti/following{/other_user}","gists_url":"https://api.github.com/users/istiti/gists{/gist_id}","starred_url":"https://api.github.com/users/istiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istiti/subscriptions","organizations_url":"https://api.github.com/users/istiti/orgs","repos_url":"https://api.github.com/users/istiti/repos","events_url":"https://api.github.com/users/istiti/events{/privacy}","received_events_url":"https://api.github.com/users/istiti/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T08:52:54Z","updated_at":"2018-04-30T08:52:54Z","author_association":"NONE","body":"@ocombe im already on angular rc6 after running `ng update --next --all --force` but I follow your advice, I remove node_modules folder, this is my version now : \r\n```\r\nAngular CLI: 6.0.0-rc.7\r\nNode: 10.0.0\r\nOS: win32 x64\r\nAngular: 6.0.0-rc.6\r\n... common, compiler, compiler-cli, core, forms, http\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\n\r\nPackage Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect 0.5.10\r\n@angular-devkit/build-angular 0.5.10\r\n@angular-devkit/build-optimizer 0.5.10\r\n@angular-devkit/core 0.5.10\r\n@angular-devkit/schematics 0.5.10\r\n@angular/cli 6.0.0-rc.7\r\n@ngtools/json-schema 1.1.0\r\n@ngtools/webpack 6.0.0-rc.8\r\n@schematics/angular 0.5.10\r\n@schematics/update 0.5.10\r\nrxjs 6.0.0\r\ntypescript 2.7.2\r\nwebpack 4.6.0\r\n```\r\n\r\nand I confirm it works ! "}}
|
{
"id": 36891867,
"name": "angular/angular-cli",
"url": "https://api.github.com/repos/angular/angular-cli"
}
|
{
"id": 2789203,
"login": "istiti",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2789203?",
"url": "https://api.github.com/users/istiti"
}
|
{
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
}
| 2018-04-30T08:52:54 |
7605413457
|
{"actor":{"display_login":"istiti"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/21456","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/21456/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/21456/comments","events_url":"https://api.github.com/repos/angular/angular/issues/21456/events","html_url":"https://github.com/angular/angular/issues/21456","id":287595170,"number":21456,"title":"Cannot build 5.2 with bazel","user":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"labels":[{"id":698221504,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20bazel","name":"comp: bazel","color":"c5def5","default":false},{"id":375500771,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20router","name":"comp: router","color":"c7def8","default":false},{"id":317126348,"url":"https://api.github.com/repos/angular/angular/labels/flag:%20can%20be%20closed?","name":"flag: can be closed?","color":"bfdadc","default":false},{"id":346386781,"url":"https://api.github.com/repos/angular/angular/labels/hotlist:%20angular-core-team","name":"hotlist: angular-core-team","color":"d4c5f9","default":false},{"id":335954385,"url":"https://api.github.com/repos/angular/angular/labels/hotlist:%20material2","name":"hotlist: material2","color":"d4c5f9","default":false},{"id":375498262,"url":"https://api.github.com/repos/angular/angular/labels/severity5:%20regression","name":"severity5: regression","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars3.githubusercontent.com/u/216296?v=4","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"assignees":[{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars3.githubusercontent.com/u/216296?v=4","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/83","html_url":"https://github.com/angular/angular/milestone/83","labels_url":"https://api.github.com/repos/angular/angular/milestones/83/labels","id":3143880,"number":83,"title":"needsTriage","description":"Milestone for all issues that haven't been triaged yet","creator":{"login":"ocombe","id":265378,"avatar_url":"https://avatars0.githubusercontent.com/u/265378?v=4","gravatar_id":"","url":"https://api.github.com/users/ocombe","html_url":"https://github.com/ocombe","followers_url":"https://api.github.com/users/ocombe/followers","following_url":"https://api.github.com/users/ocombe/following{/other_user}","gists_url":"https://api.github.com/users/ocombe/gists{/gist_id}","starred_url":"https://api.github.com/users/ocombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocombe/subscriptions","organizations_url":"https://api.github.com/users/ocombe/orgs","repos_url":"https://api.github.com/users/ocombe/repos","events_url":"https://api.github.com/users/ocombe/events{/privacy}","received_events_url":"https://api.github.com/users/ocombe/received_events","type":"User","site_admin":false},"open_issues":404,"closed_issues":232,"state":"open","created_at":"2018-02-26T14:22:18Z","updated_at":"2018-04-10T23:01:03Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2018-01-10T22:11:30Z","updated_at":"2018-04-10T23:01:56Z","closed_at":null,"author_association":"MEMBER","body":"PR #20678 introduced [`ParamsInheritanceStrategy` to `router_state.ts`](https://github.com/angular/angular/blob/master/packages/router/src/router_state.ts#L178-L179) marked as `@internal`. The tsconfig config is set to `stripInternal`, so the symbol is removed from the published d.t.s, but the type is [still referenced from `pre_activation.ts`](https://github.com/angular/angular/blob/master/packages/router/src/pre_activation.ts#L24), causing a compilation error if you try to compile with Angular's d.ts files.\r\n\r\nTo reproduce, simply try to compile anything that's using the problematic d.ts files\r\n(e.g., using Angular Material's [angular.tsconfig.build](https://github.com/angular/material2/blob/master/angular.tsconfig.json), which is needed for bazel)."},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/380274445","html_url":"https://github.com/angular/angular/issues/21456#issuecomment-380274445","issue_url":"https://api.github.com/repos/angular/angular/issues/21456","id":380274445,"user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars2.githubusercontent.com/u/47395?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T23:01:56Z","updated_at":"2018-04-10T23:01:56Z","author_association":"CONTRIBUTOR","body":"I don't think we should close this until\r\n- the integration tests run against bazel output\r\n- the bazel integration test uses `@angular/router` like in the report above"}}
|
{
"id": 24195339,
"name": "angular/angular",
"url": "https://api.github.com/repos/angular/angular"
}
|
{
"id": 47395,
"login": "alexeagle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47395?",
"url": "https://api.github.com/users/alexeagle"
}
|
{
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
}
| 2018-04-10T23:01:57 |
7510141209
|
{"actor":{"display_login":"alexeagle"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/24546","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/24546/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/24546/comments","events_url":"https://api.github.com/repos/angular/angular/issues/24546/events","html_url":"https://github.com/angular/angular/issues/24546","id":332982453,"node_id":"MDU6SXNzdWUzMzI5ODI0NTM=","number":24546,"title":"[Suggestion] Lazy load module using service","user":{"login":"piernik","id":420691,"node_id":"MDQ6VXNlcjQyMDY5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/420691?v=4","gravatar_id":"","url":"https://api.github.com/users/piernik","html_url":"https://github.com/piernik","followers_url":"https://api.github.com/users/piernik/followers","following_url":"https://api.github.com/users/piernik/following{/other_user}","gists_url":"https://api.github.com/users/piernik/gists{/gist_id}","starred_url":"https://api.github.com/users/piernik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piernik/subscriptions","organizations_url":"https://api.github.com/users/piernik/orgs","repos_url":"https://api.github.com/users/piernik/repos","events_url":"https://api.github.com/users/piernik/events{/privacy}","received_events_url":"https://api.github.com/users/piernik/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-16T11:58:21Z","updated_at":"2018-06-21T23:52:40Z","closed_at":"2018-06-21T23:52:40Z","author_association":"NONE","body":"## I'm submitting a...\r\n<!-- Check one of the following options with \"x\" -->\r\n<pre><code>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n</code></pre>\r\n\r\nIn angular we can lazy load module using router. It's a common example.\r\n\r\nBut is it possible to lazy load module from service or component?\r\n\r\nWhy do I need it?\r\n\r\nI have two lazy loaded modules: clients and invoices. Both with it's add/edit view component. But in invoice add component I want to give possibility to add client in modal, so user don't have to abandon current form. So I have to lazy load ClientModule."},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/399278253","html_url":"https://github.com/angular/angular/issues/24546#issuecomment-399278253","issue_url":"https://api.github.com/repos/angular/angular/issues/24546","id":399278253,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTI3ODI1Mw==","user":{"login":"jasonaden","id":516168,"node_id":"MDQ6VXNlcjUxNjE2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/516168?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonaden","html_url":"https://github.com/jasonaden","followers_url":"https://api.github.com/users/jasonaden/followers","following_url":"https://api.github.com/users/jasonaden/following{/other_user}","gists_url":"https://api.github.com/users/jasonaden/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonaden/subscriptions","organizations_url":"https://api.github.com/users/jasonaden/orgs","repos_url":"https://api.github.com/users/jasonaden/repos","events_url":"https://api.github.com/users/jasonaden/events{/privacy}","received_events_url":"https://api.github.com/users/jasonaden/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T23:52:40Z","updated_at":"2018-06-21T23:52:40Z","author_association":"CONTRIBUTOR","body":"This is a duplicate, but it should also be solved with the new Ivy project. Because Ivy changes how decorators compile so they only require local knowledge, lazy loading at any time shouldn't be an issue as the AOT compiler doesn't need the same global knowledge it previously did."}}
|
{
"id": 24195339,
"name": "angular/angular",
"url": "https://api.github.com/repos/angular/angular"
}
|
{
"id": 516168,
"login": "jasonaden",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/516168?",
"url": "https://api.github.com/users/jasonaden"
}
|
{
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
}
| 2018-06-21T23:52:40 |
7861352188
|
{"actor":{"display_login":"jasonaden"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular-cli/issues/10751","repository_url":"https://api.github.com/repos/angular/angular-cli","labels_url":"https://api.github.com/repos/angular/angular-cli/issues/10751/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular-cli/issues/10751/comments","events_url":"https://api.github.com/repos/angular/angular-cli/issues/10751/events","html_url":"https://github.com/angular/angular-cli/issues/10751","id":321580824,"number":10751,"title":"Angular 6+ library development workflow should follow npm development conventions","user":{"login":"nfriend","id":1638631,"avatar_url":"https://avatars0.githubusercontent.com/u/1638631?v=4","gravatar_id":"","url":"https://api.github.com/users/nfriend","html_url":"https://github.com/nfriend","followers_url":"https://api.github.com/users/nfriend/followers","following_url":"https://api.github.com/users/nfriend/following{/other_user}","gists_url":"https://api.github.com/users/nfriend/gists{/gist_id}","starred_url":"https://api.github.com/users/nfriend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfriend/subscriptions","organizations_url":"https://api.github.com/users/nfriend/orgs","repos_url":"https://api.github.com/users/nfriend/repos","events_url":"https://api.github.com/users/nfriend/events{/privacy}","received_events_url":"https://api.github.com/users/nfriend/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-09T13:55:43Z","updated_at":"2018-05-09T17:00:43Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nWe will close this issue if you don't provide the needed information.\r\nFor feature requests, delete the form below and describe the requirements and use case.\r\n-->\r\n\r\n### Versions\r\n```\r\nAngular CLI: 6.0.0\r\nNode: 8.9.1\r\nOS: win32 x64\r\nAngular: 6.0.0\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... http, language-service, platform-browser\r\n... platform-browser-dynamic, router\r\n\r\nPackage Version\r\n------------------------------------------------------------\r\n@angular-devkit/architect 0.6.0\r\n@angular-devkit/build-angular 0.6.0\r\n@angular-devkit/build-ng-packagr 0.6.0\r\n@angular-devkit/build-optimizer 0.6.0\r\n@angular-devkit/core 0.6.0\r\n@angular-devkit/schematics 0.6.0\r\n@ngtools/json-schema 1.1.0\r\n@ngtools/webpack 6.0.0\r\n@schematics/angular 0.6.0\r\n@schematics/update 0.6.0\r\nng-packagr 3.0.0-rc.3\r\nrxjs 6.1.0\r\ntypescript 2.7.2\r\nwebpack 4.6.0\r\n```\r\n\r\n### Observed behavior\r\n[With the release of Angular 6, the CLI now supports the concept of creating Angular 6+ libraries.](https://github.com/angular/angular-cli/wiki/stories-create-library) However, the workflow imposed by the CLI does not line up with a typical npm module development workflow:\r\n\r\n- A library cannot be generated without first generating an app.\r\n- Building the library creates an _entirely new module_ in the `dist` directory, complete with its own `package.json`. As a result, publishing the module requires the developer to run `npm publish` from within the `dist` folder, rather than at the root of the project.\r\n- In the same vein, linking an Angular library for local development requires the `npm link` command to be run from within the `dist` folder.\r\n- Because the library has its own `package.json`, it's unclear where library dependencies should be installed. If dependencies are installed into the root `package.json`, the dependencies don't get included in the package published to npm. However, if the dependencies are instead installed into the library's `package.json` (i.e. `./projects/my-module/package.json`), an error is thrown when `ng build my-module` is run (`BUILD ERROR: Dependency XXX must be explicitly whitelisted`).\r\n- After a library is built, a total of **five** package-related files exist in the project directory. This has the potential to be very confusing:\r\n - `./package.json`\r\n - `./projects/package.json` \r\n - `./projects/ng-package.json` \r\n - `./projects/ng-package.prod.json` \r\n - `./dist/my-module/package.json` \r\n\r\n### Desired behavior\r\nThe Angular 6+ library development experience should match that of developing a typical npm module:\r\n\r\n- An Angular 6+ library should be able to be generated without first creating an app.\r\n- Building an Angular library should not create a new module (e.g. a new `package.json`).\r\n- The `npm publish` and `npm link` commands should be able to be run from the root of the project."},"comment":{"url":"https://api.github.com/repos/angular/angular-cli/issues/comments/387806592","html_url":"https://github.com/angular/angular-cli/issues/10751#issuecomment-387806592","issue_url":"https://api.github.com/repos/angular/angular-cli/issues/10751","id":387806592,"user":{"login":"maxtacco","id":22544447,"avatar_url":"https://avatars1.githubusercontent.com/u/22544447?v=4","gravatar_id":"","url":"https://api.github.com/users/maxtacco","html_url":"https://github.com/maxtacco","followers_url":"https://api.github.com/users/maxtacco/followers","following_url":"https://api.github.com/users/maxtacco/following{/other_user}","gists_url":"https://api.github.com/users/maxtacco/gists{/gist_id}","starred_url":"https://api.github.com/users/maxtacco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxtacco/subscriptions","organizations_url":"https://api.github.com/users/maxtacco/orgs","repos_url":"https://api.github.com/users/maxtacco/repos","events_url":"https://api.github.com/users/maxtacco/events{/privacy}","received_events_url":"https://api.github.com/users/maxtacco/received_events","type":"User","site_admin":false},"created_at":"2018-05-09T17:00:43Z","updated_at":"2018-05-09T17:00:43Z","author_association":"NONE","body":"@nfriend, I'm not sure if you consider the fact that people build Angular libraries that are used by multiple Angular projects and are published to NPM as separate packages. So, it would be nice to support the generation of Angular libraries without creating an app first, but I don't see how the other 2 points make sense.\r\n\r\nAlso, you can try using \"devDependencies\" combined with \"peerDependencies\" when building a library. "}}
|
{
"id": 36891867,
"name": "angular/angular-cli",
"url": "https://api.github.com/repos/angular/angular-cli"
}
|
{
"id": 22544447,
"login": "maxtacco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22544447?",
"url": "https://api.github.com/users/maxtacco"
}
|
{
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
}
| 2018-05-09T17:00:44 |
7651001649
|
{"actor":{"display_login":"maxtacco"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular-cli/issues/10965","repository_url":"https://api.github.com/repos/angular/angular-cli","labels_url":"https://api.github.com/repos/angular/angular-cli/issues/10965/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular-cli/issues/10965/comments","events_url":"https://api.github.com/repos/angular/angular-cli/issues/10965/events","html_url":"https://github.com/angular/angular-cli/issues/10965","id":325587710,"number":10965,"title":"'ng update @angular/cli' throws 'no elements in sequence' error","user":{"login":"micobarac","id":16001837,"avatar_url":"https://avatars3.githubusercontent.com/u/16001837?v=4","gravatar_id":"","url":"https://api.github.com/users/micobarac","html_url":"https://github.com/micobarac","followers_url":"https://api.github.com/users/micobarac/followers","following_url":"https://api.github.com/users/micobarac/following{/other_user}","gists_url":"https://api.github.com/users/micobarac/gists{/gist_id}","starred_url":"https://api.github.com/users/micobarac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micobarac/subscriptions","organizations_url":"https://api.github.com/users/micobarac/orgs","repos_url":"https://api.github.com/users/micobarac/repos","events_url":"https://api.github.com/users/micobarac/events{/privacy}","received_events_url":"https://api.github.com/users/micobarac/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-23T07:48:44Z","updated_at":"2018-05-24T08:18:42Z","closed_at":null,"author_association":"NONE","body":"### Versions\r\n```\r\nAngular CLI: 6.0.3\r\nNode: 9.8.0\r\nOS: darwin x64\r\nAngular: 5.2.11\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... http, language-service, platform-browser\r\n... platform-browser-dynamic, router\r\n\r\nPackage Version\r\n------------------------------------------------------\r\n@angular-devkit/architect 0.6.3\r\n@angular-devkit/core 0.6.3\r\n@angular-devkit/schematics 0.6.3\r\n@angular/cdk 5.2.5\r\n@angular/cli 6.0.3\r\n@angular/flex-layout 5.0.0-beta.14\r\n@angular/material 5.2.5\r\n@schematics/angular 0.6.3\r\n@schematics/update 0.6.3\r\nrxjs 5.5.11\r\ntypescript 2.8.3\r\n```\r\n\r\n### Repro steps\r\nI followed the official update guide on [Angular Update Guide](https://update.angular.io/):\r\n* `yarn global add @angular/cli` - OK\r\n* `yarn add @angular/cli` - OK\r\n* `ng update @angular/cli` - ERROR: `no elements in sequence\r\n`\r\n\r\n### Observed behavior\r\nERROR: `no elements in sequence`\r\n\r\nBtw, `ng update` throws the same error message with any dependency mentioned in update guide:\r\n\r\n`ng update @angular/core` - ERROR: `no elements in sequence`\r\n`ng update @angular/material` - ERROR: `no elements in sequence`\r\n`ng update` - ERROR: `no elements in sequence`\r\n\r\nThe same error gets thrown even with a new Angular 6 project generated with:\r\n\r\n`ng new ng6`\r\n`ng update` - ERROR: `no elements in sequence`\r\n\r\nWhen I downgraded Angular Cli from `6.0.3`, which is the latest, to version `6.0.0`, `ng update @angular/cli` worked well, with no errors. \r\n\r\nThe problem is that with version `6.0.0` `ng update @angular/core` throws error:\r\n\r\n`Invalid range: \">=2.3.0 <3.0.0||>=4.0.0\"`\r\n\r\n**And there we are again in a magical loop of versions, which do not work as they should!**\r\n\r\n**Any version higher than 6.0.0 is throwing the `no elements in sequence` error!**\r\n\r\n### Desired behavior\r\nUpdated Angular Cli and other dependencies.\r\n\r\n\r\n### Mention any other details that might be useful (optional)\r\n`package.json` contents:\r\n\r\n```json\r\n{\r\n \"name\": \"myapp\",\r\n \"version\": \"0.0.0\",\r\n \"license\": \"MIT\",\r\n \"scripts\": {\r\n \"ng\": \"ng\",\r\n \"start\": \"ng serve --verbose -o --proxy-config=proxy.config.json\",\r\n \"build\": \"ng build --prod --bh /myapp/\",\r\n \"test\": \"ng test\",\r\n \"lint\": \"ng lint\",\r\n \"e2e\": \"ng e2e\"\r\n },\r\n \"private\": true,\r\n \"dependencies\": {\r\n \"@angular/animations\": \"^5.2.8\",\r\n \"@angular/cdk\": \"^5.2.0\",\r\n \"@angular/common\": \"^5.2.8\",\r\n \"@angular/compiler\": \"^5.2.8\",\r\n \"@angular/core\": \"^5.2.8\",\r\n \"@angular/flex-layout\": \"^5.0.0-beta.13\",\r\n \"@angular/forms\": \"^5.2.8\",\r\n \"@angular/http\": \"^5.2.8\",\r\n \"@angular/material\": \"^5.2.0\",\r\n \"@angular/platform-browser\": \"^5.2.8\",\r\n \"@angular/platform-browser-dynamic\": \"^5.2.8\",\r\n \"@angular/router\": \"^5.2.8\",\r\n \"@covalent/core\": \"^1.0.0\",\r\n \"@covalent/dynamic-forms\": \"^1.0.0\",\r\n \"@covalent/highlight\": \"^1.0.0\",\r\n \"@covalent/http\": \"^1.0.0\",\r\n \"@covalent/markdown\": \"^1.0.0\",\r\n \"@ngx-translate/core\": \"^9.1.1\",\r\n \"@ngx-translate/http-loader\": \"^2.0.1\",\r\n \"chart.js\": \"^2.7.2\",\r\n \"chartjs-plugin-annotation\": \"^0.5.7\",\r\n \"codelyzer\": \"^4.1.0\",\r\n \"core-js\": \"^2.5.3\",\r\n \"file-saver\": \"^1.3.3\",\r\n \"hammerjs\": \"^2.0.8\",\r\n \"moment\": \"^2.22.1\",\r\n \"ng2-charts\": \"^1.6.0\",\r\n \"rxjs\": \"^5.5.6\",\r\n \"ts-node\": \"^4.1.0\",\r\n \"tslint\": \"^5.9.1\",\r\n \"typescript\": \"^2.7.2\",\r\n \"zone.js\": \"^0.8.20\"\r\n },\r\n \"devDependencies\": {\r\n \"@angular/cli\": \"^6.0.3\",\r\n \"@angular/compiler-cli\": \"^5.2.8\",\r\n \"@angular/language-service\": \"^5.2.8\",\r\n \"@types/jasmine\": \"~2.6.0\",\r\n \"@types/node\": \"~8.0.32\",\r\n \"jasmine-core\": \"~2.8.0\",\r\n \"jasmine-spec-reporter\": \"~4.2.1\",\r\n \"karma\": \"~1.7.0\",\r\n \"karma-chrome-launcher\": \"~2.2.0\",\r\n \"karma-cli\": \"~1.0.1\",\r\n \"karma-coverage-istanbul-reporter\": \"~1.3.0\",\r\n \"karma-jasmine\": \"~1.1.0\",\r\n \"karma-jasmine-html-reporter\": \"~0.2.2\",\r\n \"protractor\": \"~5.1.2\"\r\n }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/angular/angular-cli/issues/comments/391630015","html_url":"https://github.com/angular/angular-cli/issues/10965#issuecomment-391630015","issue_url":"https://api.github.com/repos/angular/angular-cli/issues/10965","id":391630015,"user":{"login":"trojanc","id":7879229,"avatar_url":"https://avatars1.githubusercontent.com/u/7879229?v=4","gravatar_id":"","url":"https://api.github.com/users/trojanc","html_url":"https://github.com/trojanc","followers_url":"https://api.github.com/users/trojanc/followers","following_url":"https://api.github.com/users/trojanc/following{/other_user}","gists_url":"https://api.github.com/users/trojanc/gists{/gist_id}","starred_url":"https://api.github.com/users/trojanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trojanc/subscriptions","organizations_url":"https://api.github.com/users/trojanc/orgs","repos_url":"https://api.github.com/users/trojanc/repos","events_url":"https://api.github.com/users/trojanc/events{/privacy}","received_events_url":"https://api.github.com/users/trojanc/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T08:18:42Z","updated_at":"2018-05-24T08:18:42Z","author_association":"NONE","body":"The above did not work for me, all packages updated to 6.0.3, but still same error \r\n\r\n```\r\nAngular CLI: 6.0.3\r\nNode: 8.11.1\r\nOS: win32 x64\r\nAngular: 6.0.3\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... http, language-service, platform-browser\r\n... platform-browser-dynamic, router\r\n\r\nPackage Version\r\n------------------------------------------------------\r\n@angular-devkit/architect 0.6.3\r\n@angular-devkit/core 0.6.3\r\n@angular-devkit/schematics 0.6.3\r\n@schematics/angular 0.6.3\r\n@schematics/update 0.6.3\r\nrxjs 6.2.0\r\ntypescript 2.8.3\r\n```\r\n\r\n\r\n```\r\nng update @angular/cli\r\nno elements in sequence\r\n```"}}
|
{
"id": 36891867,
"name": "angular/angular-cli",
"url": "https://api.github.com/repos/angular/angular-cli"
}
|
{
"id": 7879229,
"login": "trojanc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7879229?",
"url": "https://api.github.com/users/trojanc"
}
|
{
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
}
| 2018-05-24T08:18:42 |
7722124388
|
{"actor":{"display_login":"trojanc"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/angular/webdriver-manager/issues/330","repository_url":"https://api.github.com/repos/angular/webdriver-manager","labels_url":"https://api.github.com/repos/angular/webdriver-manager/issues/330/labels{/name}","comments_url":"https://api.github.com/repos/angular/webdriver-manager/issues/330/comments","events_url":"https://api.github.com/repos/angular/webdriver-manager/issues/330/events","html_url":"https://github.com/angular/webdriver-manager/issues/330","id":376667398,"node_id":"MDU6SXNzdWUzNzY2NjczOTg=","number":330,"title":"webdriver jettyThreads option","user":{"login":"archagy","id":4847289,"node_id":"MDQ6VXNlcjQ4NDcyODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4847289?v=4","gravatar_id":"","url":"https://api.github.com/users/archagy","html_url":"https://github.com/archagy","followers_url":"https://api.github.com/users/archagy/followers","following_url":"https://api.github.com/users/archagy/following{/other_user}","gists_url":"https://api.github.com/users/archagy/gists{/gist_id}","starred_url":"https://api.github.com/users/archagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archagy/subscriptions","organizations_url":"https://api.github.com/users/archagy/orgs","repos_url":"https://api.github.com/users/archagy/repos","events_url":"https://api.github.com/users/archagy/events{/privacy}","received_events_url":"https://api.github.com/users/archagy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-02T04:39:54Z","updated_at":"2018-11-08T17:06:21Z","closed_at":"2018-11-08T17:06:21Z","author_association":"NONE","body":"Recently from jenkins I was getting this error.\r\n\r\n`01:34:25 [01:34:25] 01:34:25.560 INFO [WebDriverServlet.<init>] - Initialising WebDriverServlet\r\n01:34:25 \r\n01:34:25 [01:34:25] Exception in thread \"main\" \r\n01:34:25 [01:34:25] java.lang.IllegalStateException: Insufficient configured threads: required=3 < max=3 for QueuedThreadPool[qtp1734161410]@675d3402{STARTED,3<=3<=3,i=3,q=0}[ReservedThreadExecutor@1c93084c{s=0/1,p=0}]\r\n01:34:25 [01:34:25] \r\n01:34:25 \r\n01:34:25 [01:34:25] \tat org.seleniumhq.jetty9.util.thread.ThreadPoolBudget.check(ThreadPoolBudget.java:155)`\r\n\r\n\r\nI could solve it adding on the build/lib/start.js ->start function the option to set the jettyThreads value.\r\n\r\nI don't know if there are other way to add it or other way to solve my original problem (lol)\r\nbut at least it's working and running my tests well.\r\n\r\n\r\nP.S if this option is helpful I could try to add the change on a PR."},"comment":{"url":"https://api.github.com/repos/angular/webdriver-manager/issues/comments/437079119","html_url":"https://github.com/angular/webdriver-manager/issues/330#issuecomment-437079119","issue_url":"https://api.github.com/repos/angular/webdriver-manager/issues/330","id":437079119,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzA3OTExOQ==","user":{"login":"archagy","id":4847289,"node_id":"MDQ6VXNlcjQ4NDcyODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4847289?v=4","gravatar_id":"","url":"https://api.github.com/users/archagy","html_url":"https://github.com/archagy","followers_url":"https://api.github.com/users/archagy/followers","following_url":"https://api.github.com/users/archagy/following{/other_user}","gists_url":"https://api.github.com/users/archagy/gists{/gist_id}","starred_url":"https://api.github.com/users/archagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archagy/subscriptions","organizations_url":"https://api.github.com/users/archagy/orgs","repos_url":"https://api.github.com/users/archagy/repos","events_url":"https://api.github.com/users/archagy/events{/privacy}","received_events_url":"https://api.github.com/users/archagy/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T17:06:20Z","updated_at":"2018-11-08T17:06:20Z","author_association":"NONE","body":"@kevinip-zingbox \r\nGreat news, I didn't test it yet but for now I will close the issue.\r\n\r\nThanks for keep it up this error."}}
|
{
"id": 55717035,
"name": "angular/webdriver-manager",
"url": "https://api.github.com/repos/angular/webdriver-manager"
}
|
{
"id": 4847289,
"login": "archagy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4847289?",
"url": "https://api.github.com/users/archagy"
}
|
{
"id": 139426,
"login": "angular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/139426?",
"url": "https://api.github.com/orgs/angular"
}
| 2018-11-08T17:06:21 |
8558034441
|
{"actor":{"display_login":"archagy"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/27086","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/27086/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/27086/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/27086/events","html_url":"https://github.com/symfony/symfony/pull/27086","id":318698994,"number":27086,"title":"[PHPUnitBridge] Add an implementation just for php 7.0","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"labels":[{"id":237550465,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Reviewed","name":"Status: Reviewed","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"number":10,"title":"3.4","description":"https://symfony.com/roadmap?version=3.4#checker","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":770,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2018-04-30T00:59:51Z","due_on":"2020-11-30T08:00:00Z","closed_at":null},"comments":2,"created_at":"2018-04-29T08:12:45Z","updated_at":"2018-04-30T01:00:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/27086","html_url":"https://github.com/symfony/symfony/pull/27086","diff_url":"https://github.com/symfony/symfony/pull/27086.diff","patch_url":"https://github.com/symfony/symfony/pull/27086.patch"},"body":"| Q | A\r\n| ------------- | ---\r\n| Branch? | 3.4, because the bug only appears on that branch and up\r\n| Bug fix? | yes\r\n| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->\r\n| BC breaks? | no <!-- see https://symfony.com/bc -->\r\n| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->\r\n| Tests pass? | yes <!-- please add some, will be required by reviewers -->\r\n| Fixed tickets | none\r\n| License | MIT\r\n| Doc PR | symfony/symfony-docs#... <!-- required for new features -->\r\n\r\nphp 7 does not have the void return type, which means we have to have a specific class for the php 7.0 + phpunit 6 combination."},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/385296550","html_url":"https://github.com/symfony/symfony/pull/27086#issuecomment-385296550","issue_url":"https://api.github.com/repos/symfony/symfony/issues/27086","id":385296550,"user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T01:00:46Z","updated_at":"2018-04-30T01:00:46Z","author_association":"OWNER","body":"Thank you @greg0ire."}}
|
{
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
}
|
{
"id": 243674,
"login": "nicolas-grekas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/243674?",
"url": "https://api.github.com/users/nicolas-grekas"
}
|
{
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?",
"url": "https://api.github.com/orgs/symfony"
}
| 2018-04-30T01:00:46 |
7604424448
|
{"actor":{"display_login":"nicolas-grekas"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/28179","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/28179/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/28179/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/28179/events","html_url":"https://github.com/symfony/symfony/issues/28179","id":349191245,"node_id":"MDU6SXNzdWUzNDkxOTEyNDU=","number":28179,"title":"[DomCrawler] Fails in PHP7.2 for same name fields, different types","user":{"login":"Michal-sk","id":2051648,"node_id":"MDQ6VXNlcjIwNTE2NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/2051648?v=4","gravatar_id":"","url":"https://api.github.com/users/Michal-sk","html_url":"https://github.com/Michal-sk","followers_url":"https://api.github.com/users/Michal-sk/followers","following_url":"https://api.github.com/users/Michal-sk/following{/other_user}","gists_url":"https://api.github.com/users/Michal-sk/gists{/gist_id}","starred_url":"https://api.github.com/users/Michal-sk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michal-sk/subscriptions","organizations_url":"https://api.github.com/users/Michal-sk/orgs","repos_url":"https://api.github.com/users/Michal-sk/repos","events_url":"https://api.github.com/users/Michal-sk/events{/privacy}","received_events_url":"https://api.github.com/users/Michal-sk/received_events","type":"User","site_admin":false},"labels":[{"id":100079,"node_id":"MDU6TGFiZWwxMDAwNzk=","url":"https://api.github.com/repos/symfony/symfony/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":149840,"node_id":"MDU6TGFiZWwxNDk4NDA=","url":"https://api.github.com/repos/symfony/symfony/labels/DomCrawler","name":"DomCrawler","color":"DDDDDD","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-09T16:00:37Z","updated_at":"2018-08-09T16:41:02Z","closed_at":null,"author_association":"NONE","body":"**Symfony version(s) affected**: x.y.z\r\n\"name\": \"symfony/dom-crawler\",\r\n\"version\": \"v2.7.49\",\r\n\r\n**Description** \r\nhttps://github.com/Codeception/Codeception/issues/5119\r\nhttps://github.com/symfony/symfony/issues/11689\r\nhttps://github.com/symfony/symfony/pull/11692\r\n\r\n```\r\n<form id=\"form\" action=\"/index.php\" method=\"post\">\r\n<input type=\"text\" id=\"originator\" class=\"alpha form-control\" name=\"form[origin]\" value=\"thisshouldbeinpost\" placeholder=\"Afzender\" maxLength=\"18\">\r\n<select id=\"originator\" name=\"form[origin]\" disabled>\r\n<option value=\"one\">one</option>\r\n<option value=\"two\">two</option>\r\n<option value=\"tree\">tree</option>\r\n</select>\r\n<input type=\"submit\">\r\n</form>\r\n```\r\n\r\nSo it seems that the fix mentioned above does not work for PHP7.2. In the above example. The field of the disabled `select` is chosen over the `input` field. This is not what PHP would do. Because the field is disabled, the `POST` does not contain the field.\r\n\r\n**Possible Solution** \r\nInvestigate on how to allow different types to be used as well in \\Symfony\\Component\\DomCrawler\\Form::addField\r\n"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/411821411","html_url":"https://github.com/symfony/symfony/issues/28179#issuecomment-411821411","issue_url":"https://api.github.com/repos/symfony/symfony/issues/28179","id":411821411,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTgyMTQxMQ==","user":{"login":"Michal-sk","id":2051648,"node_id":"MDQ6VXNlcjIwNTE2NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/2051648?v=4","gravatar_id":"","url":"https://api.github.com/users/Michal-sk","html_url":"https://github.com/Michal-sk","followers_url":"https://api.github.com/users/Michal-sk/followers","following_url":"https://api.github.com/users/Michal-sk/following{/other_user}","gists_url":"https://api.github.com/users/Michal-sk/gists{/gist_id}","starred_url":"https://api.github.com/users/Michal-sk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michal-sk/subscriptions","organizations_url":"https://api.github.com/users/Michal-sk/orgs","repos_url":"https://api.github.com/users/Michal-sk/repos","events_url":"https://api.github.com/users/Michal-sk/events{/privacy}","received_events_url":"https://api.github.com/users/Michal-sk/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T16:41:02Z","updated_at":"2018-08-09T16:41:02Z","author_association":"NONE","body":"So changing\r\n`vendor/symfony/dom-crawler/Form.php:456`\r\n\r\nto ignore the disabled fields. Just like PHP would do, and just like we do when requesting the values in `getValues`. Fixes this issue. Since the correct input value is not overwritten with the disabled field.\r\n```\r\n if (!$node->hasAttribute('name') || !$node->getAttribute('name') || $node->hasAttribute('disabled')) {\r\n return;\r\n }\r\n```"}}
|
{
"id": 458058,
"name": "symfony/symfony",
"url": "https://api.github.com/repos/symfony/symfony"
}
|
{
"id": 2051648,
"login": "Michal-sk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2051648?",
"url": "https://api.github.com/users/Michal-sk"
}
|
{
"id": 143937,
"login": "symfony",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/143937?",
"url": "https://api.github.com/orgs/symfony"
}
| 2018-08-09T16:41:03 |
8091375894
|
{"actor":{"display_login":"Michal-sk"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/akvo/akvo-flow/issues/2626","repository_url":"https://api.github.com/repos/akvo/akvo-flow","labels_url":"https://api.github.com/repos/akvo/akvo-flow/issues/2626/labels{/name}","comments_url":"https://api.github.com/repos/akvo/akvo-flow/issues/2626/comments","events_url":"https://api.github.com/repos/akvo/akvo-flow/issues/2626/events","html_url":"https://github.com/akvo/akvo-flow/issues/2626","id":318848387,"node_id":"MDU6SXNzdWUzMTg4NDgzODc=","number":2626,"title":"Combine Data analysis and Comprehensive exports ","user":{"login":"janagombitova","id":12456965,"node_id":"MDQ6VXNlcjEyNDU2OTY1","avatar_url":"https://avatars2.githubusercontent.com/u/12456965?v=4","gravatar_id":"","url":"https://api.github.com/users/janagombitova","html_url":"https://github.com/janagombitova","followers_url":"https://api.github.com/users/janagombitova/followers","following_url":"https://api.github.com/users/janagombitova/following{/other_user}","gists_url":"https://api.github.com/users/janagombitova/gists{/gist_id}","starred_url":"https://api.github.com/users/janagombitova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janagombitova/subscriptions","organizations_url":"https://api.github.com/users/janagombitova/orgs","repos_url":"https://api.github.com/users/janagombitova/repos","events_url":"https://api.github.com/users/janagombitova/events{/privacy}","received_events_url":"https://api.github.com/users/janagombitova/received_events","type":"User","site_admin":false},"labels":[{"id":620900468,"node_id":"MDU6TGFiZWw2MjA5MDA0Njg=","url":"https://api.github.com/repos/akvo/akvo-flow/labels/1%20-%20Reports","name":"1 - Reports","color":"c2e0c6","default":false},{"id":873138362,"node_id":"MDU6TGFiZWw4NzMxMzgzNjI=","url":"https://api.github.com/repos/akvo/akvo-flow/labels/Discovery","name":"Discovery","color":"e6e6e6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-30T10:38:19Z","updated_at":"2018-07-09T08:17:40Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"# Context \r\n\r\nWith the large export changes we created separate Data cleaning export, Data analysis export and Comprehensive report. The Cleaning and Analysis one export data in a different structure (multiple sheets or rows for repeated groups, options in one or multiple columns). \r\n\r\nIn the further research we learned that Salim prefers the Comprehensive one as it holds the data and the summary sheet. The data in the Comprehensive report is of the same structure as Analysis. \r\n\r\nThen we fixed the submission date filter on Cleaning and Analysis resulting in the Comprehensive report not being filterable by date anymore (was actually a bug rather than a decided functionality). A partner shared how they used the date filter bug on the Comprehensive report: \r\n\r\n\"For us being able to download comprehensive reports according to period specific is very important. We collect data cumulatively and previously this feature worked so good. Some of my colleagues in the country programmes use the summary report so once I download data and simply filter according to when it was collected I will only have a raw data report and miss out on the summary report for that period.\" Link:https://flowhelp.reamaze.com/admin/conversations/re-akvo-report-downloads\r\n\r\n\r\n\r\n# Opportunity\r\n\r\nWe can consider \"combining\" the Analysis export and Comprehensive report into one, by removing the Analysis one fully. The Comprehensive report already holds the data structure of the Analysis one. We can then allow to filter out based on submission date on the Comprehensive report. To make it clear that we actually did not remove the Analysis export, just combined it - we can rename the Comprehensive report to Comprehensive Analysis report (for example) and change the description to make it clear what the export contains. \r\n\r\nThis change can help us: \r\n- **simplify**: We can remove the Data analysis export as it is a piece of the Comprehensive report \r\n- **enhance the value of Comprehensive**: By adding the submission date filter to the Comprehensive report we will make this most commonly used export option even more valuable. \r\n\r\n# Next steps \r\nWhat do you think? @muloem @stellanl @Kiarii and @loicsans \r\nMake Go - No Go decision\r\n"},"comment":{"url":"https://api.github.com/repos/akvo/akvo-flow/issues/comments/403398249","html_url":"https://github.com/akvo/akvo-flow/issues/2626#issuecomment-403398249","issue_url":"https://api.github.com/repos/akvo/akvo-flow/issues/2626","id":403398249,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzM5ODI0OQ==","user":{"login":"janagombitova","id":12456965,"node_id":"MDQ6VXNlcjEyNDU2OTY1","avatar_url":"https://avatars2.githubusercontent.com/u/12456965?v=4","gravatar_id":"","url":"https://api.github.com/users/janagombitova","html_url":"https://github.com/janagombitova","followers_url":"https://api.github.com/users/janagombitova/followers","following_url":"https://api.github.com/users/janagombitova/following{/other_user}","gists_url":"https://api.github.com/users/janagombitova/gists{/gist_id}","starred_url":"https://api.github.com/users/janagombitova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janagombitova/subscriptions","organizations_url":"https://api.github.com/users/janagombitova/orgs","repos_url":"https://api.github.com/users/janagombitova/repos","events_url":"https://api.github.com/users/janagombitova/events{/privacy}","received_events_url":"https://api.github.com/users/janagombitova/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T08:17:40Z","updated_at":"2018-07-09T08:17:40Z","author_association":"CONTRIBUTOR","body":"Created via Reamaze:\r\n\r\nLink: /admin/conversations/akvoflow-support-request-number-124092-from-nikki-at-akvo-dot-org\r\nAssignee: Jana Gombitova\r\n"}}
|
{
"id": 3843585,
"name": "akvo/akvo-flow",
"url": "https://api.github.com/repos/akvo/akvo-flow"
}
|
{
"id": 12456965,
"login": "janagombitova",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12456965?",
"url": "https://api.github.com/users/janagombitova"
}
|
{
"id": 159843,
"login": "akvo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/159843?",
"url": "https://api.github.com/orgs/akvo"
}
| 2018-07-09T08:17:40 |
7936089392
|
{"actor":{"display_login":"janagombitova"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/19597","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/19597/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/19597/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/19597/events","html_url":"https://github.com/guardian/frontend/pull/19597","id":318969638,"number":19597,"title":"Remove mention to 30 April in the opt in alert","user":{"login":"walaura","id":11539094,"avatar_url":"https://avatars1.githubusercontent.com/u/11539094?v=4","gravatar_id":"","url":"https://api.github.com/users/walaura","html_url":"https://github.com/walaura","followers_url":"https://api.github.com/users/walaura/followers","following_url":"https://api.github.com/users/walaura/following{/other_user}","gists_url":"https://api.github.com/users/walaura/gists{/gist_id}","starred_url":"https://api.github.com/users/walaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walaura/subscriptions","organizations_url":"https://api.github.com/users/walaura/orgs","repos_url":"https://api.github.com/users/walaura/repos","events_url":"https://api.github.com/users/walaura/events{/privacy}","received_events_url":"https://api.github.com/users/walaura/received_events","type":"User","site_admin":false},"labels":[{"id":512259700,"url":"https://api.github.com/repos/guardian/frontend/labels/Seen-on-PROD","name":"Seen-on-PROD","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-30T17:27:05Z","updated_at":"2018-04-30T17:50:44Z","closed_at":"2018-04-30T17:37:35Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/19597","html_url":"https://github.com/guardian/frontend/pull/19597","diff_url":"https://github.com/guardian/frontend/pull/19597.diff","patch_url":"https://github.com/guardian/frontend/pull/19597.patch"},"body":"Requested by mydata because, well, it's 30 April today and this is not really a very convincing argument for users to opt in anymore.\r\n\r\n<img width=\"358\" alt=\"screen shot 2018-04-30 at 6 27 41 pm\" src=\"https://user-images.githubusercontent.com/11539094/39440865-36544564-4ca4-11e8-86d7-83589b7a90bf.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/385476181","html_url":"https://github.com/guardian/frontend/pull/19597#issuecomment-385476181","issue_url":"https://api.github.com/repos/guardian/frontend/issues/19597","id":385476181,"user":{"login":"prout-bot","id":8896019,"avatar_url":"https://avatars2.githubusercontent.com/u/8896019?v=4","gravatar_id":"","url":"https://api.github.com/users/prout-bot","html_url":"https://github.com/prout-bot","followers_url":"https://api.github.com/users/prout-bot/followers","following_url":"https://api.github.com/users/prout-bot/following{/other_user}","gists_url":"https://api.github.com/users/prout-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/prout-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prout-bot/subscriptions","organizations_url":"https://api.github.com/users/prout-bot/orgs","repos_url":"https://api.github.com/users/prout-bot/repos","events_url":"https://api.github.com/users/prout-bot/events{/privacy}","received_events_url":"https://api.github.com/users/prout-bot/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T17:50:43Z","updated_at":"2018-04-30T17:50:43Z","author_association":"COLLABORATOR","body":"Seen on [PROD](https://frontend.gutools.co.uk/deploys?stage=PROD&pageSize=50) (merged by @walaura 13 minutes and 8 seconds ago) \n- Check your changes on [www.theguardian.com](https://www.theguardian.com) ✔️ \n- Keep an eye on the [deploy dashboard](https://kibana.gu-web.net/app/kibana#/dashboard/8730df10-49fd-11e7-b778-ebbe55169b8f) 📉 \n"}}
|
{
"id": 4370755,
"name": "guardian/frontend",
"url": "https://api.github.com/repos/guardian/frontend"
}
|
{
"id": 8896019,
"login": "prout-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8896019?",
"url": "https://api.github.com/users/prout-bot"
}
|
{
"id": 164318,
"login": "guardian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/164318?",
"url": "https://api.github.com/orgs/guardian"
}
| 2018-04-30T17:50:44 |
7607839825
|
{"actor":{"display_login":"prout-bot"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/liip/LiipMonitorBundle/issues/182","repository_url":"https://api.github.com/repos/liip/LiipMonitorBundle","labels_url":"https://api.github.com/repos/liip/LiipMonitorBundle/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/liip/LiipMonitorBundle/issues/182/comments","events_url":"https://api.github.com/repos/liip/LiipMonitorBundle/issues/182/events","html_url":"https://github.com/liip/LiipMonitorBundle/pull/182","id":336370752,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODQwMjY2","number":182,"title":"Drop support for PHP 5.x and update travis config","user":{"login":"kbond","id":127811,"node_id":"MDQ6VXNlcjEyNzgxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/127811?v=4","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-06-27T20:12:31Z","updated_at":"2018-07-22T19:59:59Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/liip/LiipMonitorBundle/pulls/182","html_url":"https://github.com/liip/LiipMonitorBundle/pull/182","diff_url":"https://github.com/liip/LiipMonitorBundle/pull/182.diff","patch_url":"https://github.com/liip/LiipMonitorBundle/pull/182.patch"},"body":"Looks like the prefer-lowest problem was caused by https://github.com/composer/composer/issues/5355\r\n\r\nThis config has been adapted from the FOSUserBundle."},"comment":{"url":"https://api.github.com/repos/liip/LiipMonitorBundle/issues/comments/406892509","html_url":"https://github.com/liip/LiipMonitorBundle/pull/182#issuecomment-406892509","issue_url":"https://api.github.com/repos/liip/LiipMonitorBundle/issues/182","id":406892509,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg5MjUwOQ==","user":{"login":"lsmith77","id":300279,"node_id":"MDQ6VXNlcjMwMDI3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/300279?v=4","gravatar_id":"","url":"https://api.github.com/users/lsmith77","html_url":"https://github.com/lsmith77","followers_url":"https://api.github.com/users/lsmith77/followers","following_url":"https://api.github.com/users/lsmith77/following{/other_user}","gists_url":"https://api.github.com/users/lsmith77/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmith77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmith77/subscriptions","organizations_url":"https://api.github.com/users/lsmith77/orgs","repos_url":"https://api.github.com/users/lsmith77/repos","events_url":"https://api.github.com/users/lsmith77/events{/privacy}","received_events_url":"https://api.github.com/users/lsmith77/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T19:59:59Z","updated_at":"2018-07-22T19:59:59Z","author_association":"MEMBER","body":"interesting https://travis-ci.org/liip/LiipMonitorBundle"}}
|
{
"id": 3639633,
"name": "liip/LiipMonitorBundle",
"url": "https://api.github.com/repos/liip/LiipMonitorBundle"
}
|
{
"id": 300279,
"login": "lsmith77",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/300279?",
"url": "https://api.github.com/users/lsmith77"
}
|
{
"id": 166102,
"login": "liip",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/166102?",
"url": "https://api.github.com/orgs/liip"
}
| 2018-07-22T19:59:59 |
8000776762
|
{"actor":{"display_login":"lsmith77"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/atlassian/ctrl/issues/12","repository_url":"https://api.github.com/repos/atlassian/ctrl","labels_url":"https://api.github.com/repos/atlassian/ctrl/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/atlassian/ctrl/issues/12/comments","events_url":"https://api.github.com/repos/atlassian/ctrl/issues/12/events","html_url":"https://github.com/atlassian/ctrl/pull/12","id":328388390,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTM4ODEx","number":12,"title":"Recover from panic after processing single key","user":{"login":"kopper","id":2266864,"node_id":"MDQ6VXNlcjIyNjY4NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2266864?v=4","gravatar_id":"","url":"https://api.github.com/users/kopper","html_url":"https://github.com/kopper","followers_url":"https://api.github.com/users/kopper/followers","following_url":"https://api.github.com/users/kopper/following{/other_user}","gists_url":"https://api.github.com/users/kopper/gists{/gist_id}","starred_url":"https://api.github.com/users/kopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopper/subscriptions","organizations_url":"https://api.github.com/users/kopper/orgs","repos_url":"https://api.github.com/users/kopper/repos","events_url":"https://api.github.com/users/kopper/events{/privacy}","received_events_url":"https://api.github.com/users/kopper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-01T05:39:41Z","updated_at":"2018-06-03T23:39:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/atlassian/ctrl/pulls/12","html_url":"https://github.com/atlassian/ctrl/pull/12","diff_url":"https://github.com/atlassian/ctrl/pull/12.diff","patch_url":"https://github.com/atlassian/ctrl/pull/12.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/atlassian/ctrl/issues/comments/394201155","html_url":"https://github.com/atlassian/ctrl/pull/12#issuecomment-394201155","issue_url":"https://api.github.com/repos/atlassian/ctrl/issues/12","id":394201155,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDIwMTE1NQ==","user":{"login":"kopper","id":2266864,"node_id":"MDQ6VXNlcjIyNjY4NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2266864?v=4","gravatar_id":"","url":"https://api.github.com/users/kopper","html_url":"https://github.com/kopper","followers_url":"https://api.github.com/users/kopper/followers","following_url":"https://api.github.com/users/kopper/following{/other_user}","gists_url":"https://api.github.com/users/kopper/gists{/gist_id}","starred_url":"https://api.github.com/users/kopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopper/subscriptions","organizations_url":"https://api.github.com/users/kopper/orgs","repos_url":"https://api.github.com/users/kopper/repos","events_url":"https://api.github.com/users/kopper/events{/privacy}","received_events_url":"https://api.github.com/users/kopper/received_events","type":"User","site_admin":false},"created_at":"2018-06-03T23:39:38Z","updated_at":"2018-06-03T23:39:38Z","author_association":"NONE","body":"> You are assuming that it is this item that have caused the panic. It may be something else that will keep causing panics for all items.\r\n\r\nWhat do you mean? What else could it be except some RuntimeErrors?\r\n\r\n> I was trying to say that status quo does not require any additional monitoring\r\n\r\nI'm pretty sure any production system will have to monitor for \"Dropping object out of the queue\" failures anyway. The only thing I did is converting panic errors to regular errors."}}
|
{
"id": 131583350,
"name": "atlassian/ctrl",
"url": "https://api.github.com/repos/atlassian/ctrl"
}
|
{
"id": 2266864,
"login": "kopper",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2266864?",
"url": "https://api.github.com/users/kopper"
}
|
{
"id": 168166,
"login": "atlassian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168166?",
"url": "https://api.github.com/orgs/atlassian"
}
| 2018-06-03T23:39:38 |
7768938092
|
{"actor":{"display_login":"kopper"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/6426","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/6426/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/6426/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/6426/events","html_url":"https://github.com/magento/magento2/issues/6426","id":174360082,"number":6426,"title":"update to 2.1.1 can not deploy content files ","user":{"login":"knidie","id":16149504,"avatar_url":"https://avatars2.githubusercontent.com/u/16149504?v=4","gravatar_id":"","url":"https://api.github.com/users/knidie","html_url":"https://github.com/knidie","followers_url":"https://api.github.com/users/knidie/followers","following_url":"https://api.github.com/users/knidie/following{/other_user}","gists_url":"https://api.github.com/users/knidie/gists{/gist_id}","starred_url":"https://api.github.com/users/knidie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knidie/subscriptions","organizations_url":"https://api.github.com/users/knidie/orgs","repos_url":"https://api.github.com/users/knidie/repos","events_url":"https://api.github.com/users/knidie/events{/privacy}","received_events_url":"https://api.github.com/users/knidie/received_events","type":"User","site_admin":false},"labels":[{"id":686477690,"url":"https://api.github.com/repos/magento/magento2/labels/Cannot%20Reproduce","name":"Cannot Reproduce","color":"d93f0b","default":false},{"id":394366531,"url":"https://api.github.com/repos/magento/magento2/labels/Frontend","name":"Frontend","color":"1d76db","default":false},{"id":689434599,"url":"https://api.github.com/repos/magento/magento2/labels/G1%20Failed","name":"G1 Failed","color":"d93f0b","default":false},{"id":21716835,"url":"https://api.github.com/repos/magento/magento2/labels/acknowledged","name":"acknowledged","color":"02d7e1","default":false},{"id":147131376,"url":"https://api.github.com/repos/magento/magento2/labels/bug%20report","name":"bug report","color":"d93f0b","default":false},{"id":161563561,"url":"https://api.github.com/repos/magento/magento2/labels/needs%20update","name":"needs update","color":"b60205","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":40,"created_at":"2016-08-31T19:39:39Z","updated_at":"2018-02-28T07:39:44Z","closed_at":"2018-02-13T12:40:13Z","author_association":"NONE","body":"update to 2.1.1 can not deploy static content because missing deployed_version.txt, \n\n [UnexpectedValueException] \n Unable to retrieve deployment version of static files from the file system. \n\n [UnexpectedValueException] \n Unable to retrieve deployment version of static files from the file system. \n\n [Magento\\Framework\\Exception\\FileSystemException] \n Cannot read contents from file \"/var/www/html/magento2/pub/static/deployed_version.txt\" Warning!file_get_contents(/var/www/html \n /magento2/pub/static/deployed_version.txt): failed to open stream: No such file or directory \n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/369148299","html_url":"https://github.com/magento/magento2/issues/6426#issuecomment-369148299","issue_url":"https://api.github.com/repos/magento/magento2/issues/6426","id":369148299,"user":{"login":"ihor-sviziev","id":1873745,"avatar_url":"https://avatars1.githubusercontent.com/u/1873745?v=4","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T07:39:44Z","updated_at":"2018-02-28T07:39:44Z","author_association":"CONTRIBUTOR","body":"@gjportegies could you prepare actual steps to reproduce on clean magento installation?"}}
|
{
"id": 2884111,
"name": "magento/magento2",
"url": "https://api.github.com/repos/magento/magento2"
}
|
{
"id": 1873745,
"login": "ihor-sviziev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1873745?",
"url": "https://api.github.com/users/ihor-sviziev"
}
|
{
"id": 168457,
"login": "magento",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168457?",
"url": "https://api.github.com/orgs/magento"
}
| 2018-02-28T07:39:44 |
7308281381
|
{"actor":{"display_login":"ihor-sviziev"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/magento/graphql-ce/issues/152","repository_url":"https://api.github.com/repos/magento/graphql-ce","labels_url":"https://api.github.com/repos/magento/graphql-ce/issues/152/labels{/name}","comments_url":"https://api.github.com/repos/magento/graphql-ce/issues/152/comments","events_url":"https://api.github.com/repos/magento/graphql-ce/issues/152/events","html_url":"https://github.com/magento/graphql-ce/issues/152","id":352201996,"node_id":"MDU6SXNzdWUzNTIyMDE5OTY=","number":152,"title":"Allow scalars as resolver return type","user":{"login":"paliarush","id":10828073,"node_id":"MDQ6VXNlcjEwODI4MDcz","avatar_url":"https://avatars0.githubusercontent.com/u/10828073?v=4","gravatar_id":"","url":"https://api.github.com/users/paliarush","html_url":"https://github.com/paliarush","followers_url":"https://api.github.com/users/paliarush/followers","following_url":"https://api.github.com/users/paliarush/following{/other_user}","gists_url":"https://api.github.com/users/paliarush/gists{/gist_id}","starred_url":"https://api.github.com/users/paliarush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paliarush/subscriptions","organizations_url":"https://api.github.com/users/paliarush/orgs","repos_url":"https://api.github.com/users/paliarush/repos","events_url":"https://api.github.com/users/paliarush/events{/privacy}","received_events_url":"https://api.github.com/users/paliarush/received_events","type":"User","site_admin":false},"labels":[{"id":890387001,"node_id":"MDU6TGFiZWw4OTAzODcwMDE=","url":"https://api.github.com/repos/magento/graphql-ce/labels/framework","name":"framework","color":"006b75","default":false},{"id":890027903,"node_id":"MDU6TGFiZWw4OTAwMjc5MDM=","url":"https://api.github.com/repos/magento/graphql-ce/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true},{"id":942643549,"node_id":"MDU6TGFiZWw5NDI2NDM1NDk=","url":"https://api.github.com/repos/magento/graphql-ce/labels/medium","name":"medium","color":"eadd4b","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-20T16:10:03Z","updated_at":"2018-09-12T13:03:34Z","closed_at":"2018-09-12T13:03:34Z","author_association":"CONTRIBUTOR","body":"**Problem statement**\r\n All resolvers in Magento must implement Resolver interface, which in its turn forces the instance of `\\GraphQL\\Deferred` to be returned by each resolver. To be precise, Magento wrapper for *deferred*, `\\Magento\\Framework\\GraphQl\\Query\\Resolver\\Value`, must be returned. \r\n ```php\r\n/**\r\n * Fetches the data from persistence models and format it according to the GraphQL schema.\r\n *\r\n * @param \\Magento\\Framework\\GraphQl\\Config\\Element\\Field $field\r\n * @param $context\r\n * @param ResolveInfo $info\r\n * @param array|null $value\r\n * @param array|null $args\r\n * @throws \\Exception\r\n * @return Value\r\n */\r\npublic function resolve(\r\n Field $field,\r\n $context,\r\n ResolveInfo $info,\r\n array $value = null,\r\n array $args = null\r\n) : Value;\r\n```\r\n The main reason for using *deferred* in GraphQL is to optimize performance by solving [N+1 problem](http://webonyx.github.io/graphql-php/data-fetching/#solving-n1-problem) where it exists.\r\n An example of valid *deferred* usage in Magento can be found in [`\\Magento\\CatalogGraphQl\\Model\\Resolver\\Product::resolve`](https://github.com/magento/graphql-ce/blob/5a570b8b674b04eb36930aa73f92d1e789b8843a/app/code/Magento/CatalogGraphQl/Model/Resolver/Product.php#L57).\r\n In all other cases, when there is no need to solve N+1 problem, we end up with boilerplate code like:\r\n```php\r\n$result = function () use ($data) {\r\n return $data;\r\n};\r\n return $this->valueFactory->create($result);\r\n```\r\n Response type unification is one of the reasons why *deferred* was made the only possible return type for resolvers. However, after implementing more resolvers it became obvious that current design just adds unnecessary complexity to the resolver implementations. \r\n **Proposed solution**\r\n In addition to *deferred*, allow scalars and arrays of scalars as return types for `\\Magento\\CatalogGraphQl\\Model\\Resolver\\Product::resolve`.\r\n It will also be easier to customize resolver with plugins, if it returns array/scalar instead of `deferred` object.\r\n **Action items**\r\n 1. Modify existing resolvers, which have boilerplate code and do not require solving N+1 problem\r\n Change \r\n ```php\r\n public function resolve(\r\n Field $field,\r\n $context,\r\n ResolveInfo $info,\r\n array $value = null,\r\n array $args = null\r\n ) : Value;\r\n ```\r\n to \r\n ```php\r\n public function resolve(\r\n Field $field,\r\n $context,\r\n ResolveInfo $info,\r\n array $value = null,\r\n array $args = null\r\n );\r\n ```\r\n Also, replace boilerplate code in resolvers\r\n ```php\r\n $result = function () use ($data) {\r\n return $data;\r\n };\r\n \r\n return $this->valueFactory->create($result);\r\n ```\r\n with \r\n ```php\r\n return $data;\r\n ```\r\n\r\n2. Document the decision and make sure that all new resolvers return *deferred* only when necessary. Can just mark PR with \"requires-documentation\" label to leave this part for Magento's documentation team."},"comment":{"url":"https://api.github.com/repos/magento/graphql-ce/issues/comments/420640106","html_url":"https://github.com/magento/graphql-ce/issues/152#issuecomment-420640106","issue_url":"https://api.github.com/repos/magento/graphql-ce/issues/152","id":420640106,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDY0MDEwNg==","user":{"login":"naydav","id":537688,"node_id":"MDQ6VXNlcjUzNzY4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/537688?v=4","gravatar_id":"","url":"https://api.github.com/users/naydav","html_url":"https://github.com/naydav","followers_url":"https://api.github.com/users/naydav/followers","following_url":"https://api.github.com/users/naydav/following{/other_user}","gists_url":"https://api.github.com/users/naydav/gists{/gist_id}","starred_url":"https://api.github.com/users/naydav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naydav/subscriptions","organizations_url":"https://api.github.com/users/naydav/orgs","repos_url":"https://api.github.com/users/naydav/repos","events_url":"https://api.github.com/users/naydav/events{/privacy}","received_events_url":"https://api.github.com/users/naydav/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T13:03:34Z","updated_at":"2018-09-12T13:03:34Z","author_association":"CONTRIBUTOR","body":"https://github.com/magento/graphql-ce/pull/179"}}
|
{
"id": 128075669,
"name": "magento/graphql-ce",
"url": "https://api.github.com/repos/magento/graphql-ce"
}
|
{
"id": 537688,
"login": "naydav",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/537688?",
"url": "https://api.github.com/users/naydav"
}
|
{
"id": 168457,
"login": "magento",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168457?",
"url": "https://api.github.com/orgs/magento"
}
| 2018-09-12T13:03:34 |
8253147143
|
{"actor":{"display_login":"naydav"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/16322","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/16322/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/16322/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/16322/events","html_url":"https://github.com/magento/magento2/pull/16322","id":334799770,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Njc3MTk5","number":16322,"title":"Update Magento logo & copyright adding to add Adobe","user":{"login":"osrecio","id":1510831,"node_id":"MDQ6VXNlcjE1MTA4MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1510831?v=4","gravatar_id":"","url":"https://api.github.com/users/osrecio","html_url":"https://github.com/osrecio","followers_url":"https://api.github.com/users/osrecio/followers","following_url":"https://api.github.com/users/osrecio/following{/other_user}","gists_url":"https://api.github.com/users/osrecio/gists{/gist_id}","starred_url":"https://api.github.com/users/osrecio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osrecio/subscriptions","organizations_url":"https://api.github.com/users/osrecio/orgs","repos_url":"https://api.github.com/users/osrecio/repos","events_url":"https://api.github.com/users/osrecio/events{/privacy}","received_events_url":"https://api.github.com/users/osrecio/received_events","type":"User","site_admin":false},"labels":[{"id":956032057,"node_id":"MDU6TGFiZWw5NTYwMzIwNTc=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Design/Frontend","name":"Area: Design/Frontend","color":"1d76db","default":false},{"id":394366531,"node_id":"MDU6TGFiZWwzOTQzNjY1MzE=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Frontend","name":"Area: Frontend","color":"1d76db","default":false},{"id":944451978,"node_id":"MDU6TGFiZWw5NDQ0NTE5Nzg=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Lib/Frontend","name":"Area: Lib/Frontend","color":"1d76db","default":false},{"id":944577042,"node_id":"MDU6TGFiZWw5NDQ1NzcwNDI=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Backend","name":"Component: Backend","color":"7fb703","default":false},{"id":883455843,"node_id":"MDU6TGFiZWw4ODM0NTU4NDM=","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Interactiv4","name":"Partner: Interactiv4","color":"f9d0c4","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-22T08:58:38Z","updated_at":"2018-06-22T08:58:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/16322","html_url":"https://github.com/magento/magento2/pull/16322","diff_url":"https://github.com/magento/magento2/pull/16322.diff","patch_url":"https://github.com/magento/magento2/pull/16322.patch"},"body":"<!---\r\n Thank you for contributing to Magento.\r\n To help us process this pull request we recommend that you add the following information:\r\n - Summary of the pull request,\r\n - Issue(s) related to the changes made,\r\n - Manual testing scenarios,\r\n-->\r\nAdd new Magento logo with Claim: \"an Adobe company\"\r\nAdd new Copyright with claim: \"an Adobe company\"\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\n<!---\r\n Please provide a description of the changes proposed in the pull request.\r\n Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\n\r\n### Manual testing scenarios\r\n<!---\r\n Please provide a set of unambiguous steps to test the proposed code change.\r\n Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. Go to Admin\r\n2. Check Logo\r\n3. Check CopyRight\r\n4. Change Theme for Blank\r\n5. Check Logo\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [x] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/399373282","html_url":"https://github.com/magento/magento2/pull/16322#issuecomment-399373282","issue_url":"https://api.github.com/repos/magento/magento2/issues/16322","id":399373282,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTM3MzI4Mg==","user":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"created_at":"2018-06-22T08:58:44Z","updated_at":"2018-06-22T08:58:44Z","author_association":"CONTRIBUTOR","body":"Hi @osrecio. Thank you for your contribution \nHere is some useful tips how you can test your changes using Magento test environment.\nAdd the comment under your pull request to deploy test or vanilla Magento instance:\n- `@magento-engcom-team give me test instance` - deploy test instance based on PR changes\n- `@magento-engcom-team give me {$VERSION} instance` - deploy vanilla Magento instance\n\nFor more details, please, review the [Magento Contributor Assistant](https://github.com/magento/magento2/wiki/Magento-Contributor-Assistant) documentation"}}
|
{
"id": 2884111,
"name": "magento/magento2",
"url": "https://api.github.com/repos/magento/magento2"
}
|
{
"id": 31669971,
"login": "magento-engcom-team",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31669971?",
"url": "https://api.github.com/users/magento-engcom-team"
}
|
{
"id": 168457,
"login": "magento",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168457?",
"url": "https://api.github.com/orgs/magento"
}
| 2018-06-22T08:58:44 |
7862944087
|
{"actor":{"display_login":"magento-engcom-team"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/magento/devdocs/issues/2328","repository_url":"https://api.github.com/repos/magento/devdocs","labels_url":"https://api.github.com/repos/magento/devdocs/issues/2328/labels{/name}","comments_url":"https://api.github.com/repos/magento/devdocs/issues/2328/comments","events_url":"https://api.github.com/repos/magento/devdocs/issues/2328/events","html_url":"https://github.com/magento/devdocs/pull/2328","id":334558935,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTAxODIy","number":2328,"title":"Convert html to markdown on message queues page","user":{"login":"leviv","id":9153379,"node_id":"MDQ6VXNlcjkxNTMzNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/9153379?v=4","gravatar_id":"","url":"https://api.github.com/users/leviv","html_url":"https://github.com/leviv","followers_url":"https://api.github.com/users/leviv/followers","following_url":"https://api.github.com/users/leviv/following{/other_user}","gists_url":"https://api.github.com/users/leviv/gists{/gist_id}","starred_url":"https://api.github.com/users/leviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leviv/subscriptions","organizations_url":"https://api.github.com/users/leviv/orgs","repos_url":"https://api.github.com/users/leviv/repos","events_url":"https://api.github.com/users/leviv/events{/privacy}","received_events_url":"https://api.github.com/users/leviv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"keharper","id":11652541,"node_id":"MDQ6VXNlcjExNjUyNTQx","avatar_url":"https://avatars3.githubusercontent.com/u/11652541?v=4","gravatar_id":"","url":"https://api.github.com/users/keharper","html_url":"https://github.com/keharper","followers_url":"https://api.github.com/users/keharper/followers","following_url":"https://api.github.com/users/keharper/following{/other_user}","gists_url":"https://api.github.com/users/keharper/gists{/gist_id}","starred_url":"https://api.github.com/users/keharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keharper/subscriptions","organizations_url":"https://api.github.com/users/keharper/orgs","repos_url":"https://api.github.com/users/keharper/repos","events_url":"https://api.github.com/users/keharper/events{/privacy}","received_events_url":"https://api.github.com/users/keharper/received_events","type":"User","site_admin":false},"assignees":[{"login":"keharper","id":11652541,"node_id":"MDQ6VXNlcjExNjUyNTQx","avatar_url":"https://avatars3.githubusercontent.com/u/11652541?v=4","gravatar_id":"","url":"https://api.github.com/users/keharper","html_url":"https://github.com/keharper","followers_url":"https://api.github.com/users/keharper/followers","following_url":"https://api.github.com/users/keharper/following{/other_user}","gists_url":"https://api.github.com/users/keharper/gists{/gist_id}","starred_url":"https://api.github.com/users/keharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keharper/subscriptions","organizations_url":"https://api.github.com/users/keharper/orgs","repos_url":"https://api.github.com/users/keharper/repos","events_url":"https://api.github.com/users/keharper/events{/privacy}","received_events_url":"https://api.github.com/users/keharper/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-21T16:02:56Z","updated_at":"2018-07-24T20:59:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/devdocs/pulls/2328","html_url":"https://github.com/magento/devdocs/pull/2328","diff_url":"https://github.com/magento/devdocs/pull/2328.diff","patch_url":"https://github.com/magento/devdocs/pull/2328.patch"},"body":"<!-- (REQUIRED) What is the nature of this PR? -->\r\n## This PR is a:\r\n- [ ] New topic\r\n- [x] Content fix or rewrite\r\n- [ ] Bug fix or improvement\r\n \r\n<!-- (REQUIRED) What does this PR change? -->\r\n## Summary\r\nConverts HTML to markdown on message queues page \r\n\r\nWhen this pull request is merged, it will...\r\nImprove the readability of the source code"},"comment":{"url":"https://api.github.com/repos/magento/devdocs/issues/comments/407550255","html_url":"https://github.com/magento/devdocs/pull/2328#issuecomment-407550255","issue_url":"https://api.github.com/repos/magento/devdocs/issues/2328","id":407550255,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzU1MDI1NQ==","user":{"login":"leviv","id":9153379,"node_id":"MDQ6VXNlcjkxNTMzNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/9153379?v=4","gravatar_id":"","url":"https://api.github.com/users/leviv","html_url":"https://github.com/leviv","followers_url":"https://api.github.com/users/leviv/followers","following_url":"https://api.github.com/users/leviv/following{/other_user}","gists_url":"https://api.github.com/users/leviv/gists{/gist_id}","starred_url":"https://api.github.com/users/leviv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leviv/subscriptions","organizations_url":"https://api.github.com/users/leviv/orgs","repos_url":"https://api.github.com/users/leviv/repos","events_url":"https://api.github.com/users/leviv/events{/privacy}","received_events_url":"https://api.github.com/users/leviv/received_events","type":"User","site_admin":false},"created_at":"2018-07-24T20:59:36Z","updated_at":"2018-07-24T20:59:36Z","author_association":"CONTRIBUTOR","body":"Updated for 2.1 and 2.3"}}
|
{
"id": 17608126,
"name": "magento/devdocs",
"url": "https://api.github.com/repos/magento/devdocs"
}
|
{
"id": 9153379,
"login": "leviv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9153379?",
"url": "https://api.github.com/users/leviv"
}
|
{
"id": 168457,
"login": "magento",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168457?",
"url": "https://api.github.com/orgs/magento"
}
| 2018-07-24T20:59:36 |
8012733958
|
{"actor":{"display_login":"leviv"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/7739","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/7739/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/7739/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/7739/events","html_url":"https://github.com/magento/magento2/issues/7739","id":194582610,"node_id":"MDU6SXNzdWUxOTQ1ODI2MTA=","number":7739,"title":"\"From Header set twice\" when sending an email","user":{"login":"RishabhRkRai","id":20873227,"node_id":"MDQ6VXNlcjIwODczMjI3","avatar_url":"https://avatars3.githubusercontent.com/u/20873227?v=4","gravatar_id":"","url":"https://api.github.com/users/RishabhRkRai","html_url":"https://github.com/RishabhRkRai","followers_url":"https://api.github.com/users/RishabhRkRai/followers","following_url":"https://api.github.com/users/RishabhRkRai/following{/other_user}","gists_url":"https://api.github.com/users/RishabhRkRai/gists{/gist_id}","starred_url":"https://api.github.com/users/RishabhRkRai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RishabhRkRai/subscriptions","organizations_url":"https://api.github.com/users/RishabhRkRai/orgs","repos_url":"https://api.github.com/users/RishabhRkRai/repos","events_url":"https://api.github.com/users/RishabhRkRai/events{/privacy}","received_events_url":"https://api.github.com/users/RishabhRkRai/received_events","type":"User","site_admin":false},"labels":[{"id":686477690,"node_id":"MDU6TGFiZWw2ODY0Nzc2OTA=","url":"https://api.github.com/repos/magento/magento2/labels/Cannot%20Reproduce","name":"Cannot Reproduce","color":"d93f0b","default":false},{"id":688811200,"node_id":"MDU6TGFiZWw2ODg4MTEyMDA=","url":"https://api.github.com/repos/magento/magento2/labels/G1%20Passed","name":"G1 Passed","color":"0e8a16","default":false},{"id":686420665,"node_id":"MDU6TGFiZWw2ODY0MjA2NjU=","url":"https://api.github.com/repos/magento/magento2/labels/G2%20Passed","name":"G2 Passed","color":"0e8a16","default":false},{"id":147131376,"node_id":"MDU6TGFiZWwxNDcxMzEzNzY=","url":"https://api.github.com/repos/magento/magento2/labels/bug%20report","name":"bug report","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-09T12:13:36Z","updated_at":"2018-08-22T08:47:49Z","closed_at":null,"author_association":"NONE","body":"<!--- Provide a general summary of the issue in the Title above -->\r\n<!--- Before adding new issues, please, check this article https://github.com/magento/magento2/wiki/Issue-reporting-guidelines-->\r\n\r\n### Preconditions\r\n<!--- Provide a more detailed information of environment you use -->\r\n<!--- Magento version, tag, HEAD, etc., PHP & MySQL version, etc.. -->\r\n1. I use v2.1.1 of Magento and MySQL 5.6.x\r\n2. I make a custom module which send an email to person more like subscription, when new varients of an item is come.\r\n\r\n### Steps to reproduce\r\n<!--- Provide a set of unambiguous steps to reproduce this bug include code, if relevant -->\r\n1. Make a custom module, which store email and product id in a custom database.\r\n2. Whenever something new new book edition of that product id will came. It checks for that custom table and send email to that saved email id.\r\n3. I use Magento \"TransportBuilder\" to send mails.\r\n\r\n### Expected result\r\n<!--- Tell us what should happen -->\r\n1. Emails have been send to all the saved mails in custom table without any error.\r\n\r\n### Actual result\r\n<!--- Tell us what happens instead -->\r\n\r\n1. My category page have no product for the product id belongs to.\r\n2. Email for the first data found send but for the rest it gives an error in which throw in exception.log.\r\n2. There is an log in exception.log\r\n**main.CRITICAL: exception 'Zend_Mail_Exception' with message 'From Header set twice' in /../../../../vendor/magento/zendframework1/library/Zend/Mail.php:680**\r\n\r\n<!--- (This may be platform independent comment) -->\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/414959904","html_url":"https://github.com/magento/magento2/issues/7739#issuecomment-414959904","issue_url":"https://api.github.com/repos/magento/magento2/issues/7739","id":414959904,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDk1OTkwNA==","user":{"login":"stephan-cream","id":12713337,"node_id":"MDQ6VXNlcjEyNzEzMzM3","avatar_url":"https://avatars0.githubusercontent.com/u/12713337?v=4","gravatar_id":"","url":"https://api.github.com/users/stephan-cream","html_url":"https://github.com/stephan-cream","followers_url":"https://api.github.com/users/stephan-cream/followers","following_url":"https://api.github.com/users/stephan-cream/following{/other_user}","gists_url":"https://api.github.com/users/stephan-cream/gists{/gist_id}","starred_url":"https://api.github.com/users/stephan-cream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephan-cream/subscriptions","organizations_url":"https://api.github.com/users/stephan-cream/orgs","repos_url":"https://api.github.com/users/stephan-cream/repos","events_url":"https://api.github.com/users/stephan-cream/events{/privacy}","received_events_url":"https://api.github.com/users/stephan-cream/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T08:47:49Z","updated_at":"2018-08-22T08:47:49Z","author_association":"NONE","body":"I found out how to reproduce this.\r\nWhen sending multiple mails in the same process.\r\nA cronjob would be a good example.\r\nAnother good example would be a mass action like the one provided by Mageworx's module-ordersgrid module to resend order emails, invoice emails and shipment emails.\r\n\r\nThe main cause is that a singleton is being used in the following files:\r\n- `vendor/magento/framework/Mail/Template/TransportBuilder.php`\r\n- `vendor/magento/framework/Mail/Template/TransportBuilderByStore.php`\r\nThis singleton is the message singleton (an instance of `Magento\\Framework\\Mail\\MessageInterface`).\r\n`Zend_Mail` gives an error when the header is set twice, subject, date, recipients, etc.\r\nSince a singleton is being used, once one of them is set, during the next mail attempt it will try to configure the above headers and will give an error message.\r\nThis is because the singleton instance is never properly 'cleared/reset'.\r\n\r\nThere is a reset function that is called on the TransportBuilder but a simple mistake is made here.\r\nInstead of clearing the message singleton's headers / variables it is created anew with the following code: `$this->message = $this->objectManager->create(\\Magento\\Framework\\Mail\\Message::class);`.\r\nHowever the singleton that was loaded in TransportBuilderByStore is not reset with this, only the one within TransportBuilder.\r\nAs such the from header and variable is still set.\r\n\r\n`$this->message->clearDate();\r\n$this->message->clearFrom();\r\n$this->message->clearMessageId();\r\n$this->message->clearRecipients();\r\n$this->message->clearReplyTo();\r\n$this->message->clearReturnPath();\r\n$this->message->clearSubject();`\r\n\r\nThis fix works for me at least.\r\nIf i am missing something please let me know."}}
|
{
"id": 2884111,
"name": "magento/magento2",
"url": "https://api.github.com/repos/magento/magento2"
}
|
{
"id": 12713337,
"login": "stephan-cream",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12713337?",
"url": "https://api.github.com/users/stephan-cream"
}
|
{
"id": 168457,
"login": "magento",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168457?",
"url": "https://api.github.com/orgs/magento"
}
| 2018-08-22T08:47:49 |
8149171647
|
{"actor":{"display_login":"stephan-cream"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/magento/devdocs/issues/3423","repository_url":"https://api.github.com/repos/magento/devdocs","labels_url":"https://api.github.com/repos/magento/devdocs/issues/3423/labels{/name}","comments_url":"https://api.github.com/repos/magento/devdocs/issues/3423/comments","events_url":"https://api.github.com/repos/magento/devdocs/issues/3423/events","html_url":"https://github.com/magento/devdocs/pull/3423","id":389150379,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjA0OTA5","number":3423,"title":"Updated interface link in document","user":{"login":"gelanivishal","id":12389799,"node_id":"MDQ6VXNlcjEyMzg5Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/12389799?v=4","gravatar_id":"","url":"https://api.github.com/users/gelanivishal","html_url":"https://github.com/gelanivishal","followers_url":"https://api.github.com/users/gelanivishal/followers","following_url":"https://api.github.com/users/gelanivishal/following{/other_user}","gists_url":"https://api.github.com/users/gelanivishal/gists{/gist_id}","starred_url":"https://api.github.com/users/gelanivishal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelanivishal/subscriptions","organizations_url":"https://api.github.com/users/gelanivishal/orgs","repos_url":"https://api.github.com/users/gelanivishal/repos","events_url":"https://api.github.com/users/gelanivishal/events{/privacy}","received_events_url":"https://api.github.com/users/gelanivishal/received_events","type":"User","site_admin":false},"labels":[{"id":661803120,"node_id":"MDU6TGFiZWw2NjE4MDMxMjA=","url":"https://api.github.com/repos/magento/devdocs/labels/2.x","name":"2.x","color":"c5def5","default":false},{"id":184691489,"node_id":"MDU6TGFiZWwxODQ2OTE0ODk=","url":"https://api.github.com/repos/magento/devdocs/labels/Editorial","name":"Editorial","color":"fef2c0","default":false},{"id":184692110,"node_id":"MDU6TGFiZWwxODQ2OTIxMTA=","url":"https://api.github.com/repos/magento/devdocs/labels/Waiting%20for%20response","name":"Waiting for response","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"jeff-matthews","id":13662379,"node_id":"MDQ6VXNlcjEzNjYyMzc5","avatar_url":"https://avatars2.githubusercontent.com/u/13662379?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff-matthews","html_url":"https://github.com/jeff-matthews","followers_url":"https://api.github.com/users/jeff-matthews/followers","following_url":"https://api.github.com/users/jeff-matthews/following{/other_user}","gists_url":"https://api.github.com/users/jeff-matthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-matthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-matthews/subscriptions","organizations_url":"https://api.github.com/users/jeff-matthews/orgs","repos_url":"https://api.github.com/users/jeff-matthews/repos","events_url":"https://api.github.com/users/jeff-matthews/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-matthews/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeff-matthews","id":13662379,"node_id":"MDQ6VXNlcjEzNjYyMzc5","avatar_url":"https://avatars2.githubusercontent.com/u/13662379?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff-matthews","html_url":"https://github.com/jeff-matthews","followers_url":"https://api.github.com/users/jeff-matthews/followers","following_url":"https://api.github.com/users/jeff-matthews/following{/other_user}","gists_url":"https://api.github.com/users/jeff-matthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-matthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-matthews/subscriptions","organizations_url":"https://api.github.com/users/jeff-matthews/orgs","repos_url":"https://api.github.com/users/jeff-matthews/repos","events_url":"https://api.github.com/users/jeff-matthews/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-matthews/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-12-10T05:50:12Z","updated_at":"2018-12-12T04:34:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/devdocs/pulls/3423","html_url":"https://github.com/magento/devdocs/pull/3423","diff_url":"https://github.com/magento/devdocs/pull/3423.diff","patch_url":"https://github.com/magento/devdocs/pull/3423.patch"},"body":"## This PR is a:\r\n\r\n- [ ] New topic\r\n- [X] Content update\r\n- [X] Content fix or rewrite\r\n- [X] Bug fix or improvement\r\n\r\n## Summary\r\nUpdated interface link on Magento document.\r\nWhen this pull request is merged, it will...\r\n\r\n<!-- (REQUIRED) What does this PR change? -->\r\n\r\n## Additional information\r\n\r\nList all affected URLs \r\n- https://devdocs.magento.com/guides/v2.3/config-guide/config/config-create.html\r\n- https://devdocs.magento.com/guides/v2.2/config-guide/config/config-create.html\r\n- https://devdocs.magento.com/guides/v2.1/config-guide/config/config-create.html\r\n\r\n<!-- (REQUIRED) The Url that this PR will modify -->\r\n\r\n<!-- (OPTIONAL) What other information can you provide about this PR? -->\r\n\r\n<!--\r\nThank you for your contribution!\r\n\r\nBefore submitting this pull request, please make sure you have read our Contribution Guidelines and your PR meets our contribution standards:\r\nhttps://github.com/magento/devdocs/blob/master/.github/CONTRIBUTING.md\r\n\r\nPlease fill out as much information as you can about your PR to help speed up the review process.\r\nIf your PR addresses an existing GitHub Issue, please refer to it in the title or Additional Information section to make the connection.\r\n\r\nWe may ask you for changes in your PR in order to meet the standards set in our Contribution Guidelines. PR's that do not comply with our guidelines may be closed at the maintainers' discretion.\r\n\r\nFeel free to remove this section before creating this PR.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/magento/devdocs/issues/comments/446459008","html_url":"https://github.com/magento/devdocs/pull/3423#issuecomment-446459008","issue_url":"https://api.github.com/repos/magento/devdocs/issues/3423","id":446459008,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjQ1OTAwOA==","user":{"login":"gelanivishal","id":12389799,"node_id":"MDQ6VXNlcjEyMzg5Nzk5","avatar_url":"https://avatars1.githubusercontent.com/u/12389799?v=4","gravatar_id":"","url":"https://api.github.com/users/gelanivishal","html_url":"https://github.com/gelanivishal","followers_url":"https://api.github.com/users/gelanivishal/followers","following_url":"https://api.github.com/users/gelanivishal/following{/other_user}","gists_url":"https://api.github.com/users/gelanivishal/gists{/gist_id}","starred_url":"https://api.github.com/users/gelanivishal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelanivishal/subscriptions","organizations_url":"https://api.github.com/users/gelanivishal/orgs","repos_url":"https://api.github.com/users/gelanivishal/repos","events_url":"https://api.github.com/users/gelanivishal/events{/privacy}","received_events_url":"https://api.github.com/users/gelanivishal/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T04:34:37Z","updated_at":"2018-12-12T04:34:37Z","author_association":"CONTRIBUTOR","body":"@jeff-matthews I haven't idea about it so I have copied 2.1 content to 2.2 file and replace appropriate things same thing I have done for 2.3 file."}}
|
{
"id": 17608126,
"name": "magento/devdocs",
"url": "https://api.github.com/repos/magento/devdocs"
}
|
{
"id": 12389799,
"login": "gelanivishal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12389799?",
"url": "https://api.github.com/users/gelanivishal"
}
|
{
"id": 168457,
"login": "magento",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168457?",
"url": "https://api.github.com/orgs/magento"
}
| 2018-12-12T04:34:37 |
8738691234
|
{"actor":{"display_login":"gelanivishal"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/14034","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/14034/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/14034/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/14034/events","html_url":"https://github.com/magento/magento2/pull/14034","id":303872760,"number":14034,"title":"[BACKPORT 2.3] Remove not used and empty template","user":{"login":"Coderimus","id":5318512,"avatar_url":"https://avatars2.githubusercontent.com/u/5318512?v=4","gravatar_id":"","url":"https://api.github.com/users/Coderimus","html_url":"https://github.com/Coderimus","followers_url":"https://api.github.com/users/Coderimus/followers","following_url":"https://api.github.com/users/Coderimus/following{/other_user}","gists_url":"https://api.github.com/users/Coderimus/gists{/gist_id}","starred_url":"https://api.github.com/users/Coderimus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coderimus/subscriptions","organizations_url":"https://api.github.com/users/Coderimus/orgs","repos_url":"https://api.github.com/users/Coderimus/repos","events_url":"https://api.github.com/users/Coderimus/events{/privacy}","received_events_url":"https://api.github.com/users/Coderimus/received_events","type":"User","site_admin":false},"labels":[{"id":721429227,"url":"https://api.github.com/repos/magento/magento2/labels/2.3-develop","name":"2.3-develop","color":"fbca04","default":false},{"id":588329930,"url":"https://api.github.com/repos/magento/magento2/labels/backport","name":"backport","color":"e99695","default":false}],"state":"open","locked":false,"assignee":{"login":"sidolov","id":11355520,"avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false},"assignees":[{"login":"sidolov","id":11355520,"avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/14","html_url":"https://github.com/magento/magento2/milestone/14","labels_url":"https://api.github.com/repos/magento/magento2/milestones/14/labels","id":3152085,"number":14,"title":"March 2018","description":"Pull Requests processed in March 2018","creator":{"login":"okorshenko","id":7325075,"avatar_url":"https://avatars1.githubusercontent.com/u/7325075?v=4","gravatar_id":"","url":"https://api.github.com/users/okorshenko","html_url":"https://github.com/okorshenko","followers_url":"https://api.github.com/users/okorshenko/followers","following_url":"https://api.github.com/users/okorshenko/following{/other_user}","gists_url":"https://api.github.com/users/okorshenko/gists{/gist_id}","starred_url":"https://api.github.com/users/okorshenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okorshenko/subscriptions","organizations_url":"https://api.github.com/users/okorshenko/orgs","repos_url":"https://api.github.com/users/okorshenko/repos","events_url":"https://api.github.com/users/okorshenko/events{/privacy}","received_events_url":"https://api.github.com/users/okorshenko/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":40,"state":"open","created_at":"2018-03-01T00:46:51Z","updated_at":"2018-03-09T15:13:07Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-03-09T15:11:04Z","updated_at":"2018-03-09T15:22:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/14034","html_url":"https://github.com/magento/magento2/pull/14034","diff_url":"https://github.com/magento/magento2/pull/14034.diff","patch_url":"https://github.com/magento/magento2/pull/14034.patch"},"body":"### Description\r\nHello,\r\nThis is a backport of the [#14030](https://github.com/magento/magento2/pull/14030) where not used template was deleted.\r\n\r\n### Fixed Issues (if relevant)\r\nN/A\r\n\r\n### Manual testing scenarios\r\nN/A\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/371843080","html_url":"https://github.com/magento/magento2/pull/14034#issuecomment-371843080","issue_url":"https://api.github.com/repos/magento/magento2/issues/14034","id":371843080,"user":{"login":"Coderimus","id":5318512,"avatar_url":"https://avatars2.githubusercontent.com/u/5318512?v=4","gravatar_id":"","url":"https://api.github.com/users/Coderimus","html_url":"https://github.com/Coderimus","followers_url":"https://api.github.com/users/Coderimus/followers","following_url":"https://api.github.com/users/Coderimus/following{/other_user}","gists_url":"https://api.github.com/users/Coderimus/gists{/gist_id}","starred_url":"https://api.github.com/users/Coderimus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coderimus/subscriptions","organizations_url":"https://api.github.com/users/Coderimus/orgs","repos_url":"https://api.github.com/users/Coderimus/repos","events_url":"https://api.github.com/users/Coderimus/events{/privacy}","received_events_url":"https://api.github.com/users/Coderimus/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T15:22:08Z","updated_at":"2018-03-09T15:22:08Z","author_association":"CONTRIBUTOR","body":"Hi @sidolov thank you for your review and assistance! Sure, will combine such things for future. I found them today separately during my work on the internal issue :)"}}
|
{
"id": 2884111,
"name": "magento/magento2",
"url": "https://api.github.com/repos/magento/magento2"
}
|
{
"id": 5318512,
"login": "Coderimus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5318512?",
"url": "https://api.github.com/users/Coderimus"
}
|
{
"id": 168457,
"login": "magento",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/168457?",
"url": "https://api.github.com/orgs/magento"
}
| 2018-03-09T15:22:09 |
7356594602
|
{"actor":{"display_login":"Coderimus"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/mirumee/saleor/issues/2564","repository_url":"https://api.github.com/repos/mirumee/saleor","labels_url":"https://api.github.com/repos/mirumee/saleor/issues/2564/labels{/name}","comments_url":"https://api.github.com/repos/mirumee/saleor/issues/2564/comments","events_url":"https://api.github.com/repos/mirumee/saleor/issues/2564/events","html_url":"https://github.com/mirumee/saleor/issues/2564","id":350413989,"node_id":"MDU6SXNzdWUzNTA0MTM5ODk=","number":2564,"title":"Mockups for model translations interface","user":{"login":"maarcingebala","id":5421321,"node_id":"MDQ6VXNlcjU0MjEzMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/5421321?v=4","gravatar_id":"","url":"https://api.github.com/users/maarcingebala","html_url":"https://github.com/maarcingebala","followers_url":"https://api.github.com/users/maarcingebala/followers","following_url":"https://api.github.com/users/maarcingebala/following{/other_user}","gists_url":"https://api.github.com/users/maarcingebala/gists{/gist_id}","starred_url":"https://api.github.com/users/maarcingebala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maarcingebala/subscriptions","organizations_url":"https://api.github.com/users/maarcingebala/orgs","repos_url":"https://api.github.com/users/maarcingebala/repos","events_url":"https://api.github.com/users/maarcingebala/events{/privacy}","received_events_url":"https://api.github.com/users/maarcingebala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pwgryglak","id":40759237,"node_id":"MDQ6VXNlcjQwNzU5MjM3","avatar_url":"https://avatars1.githubusercontent.com/u/40759237?v=4","gravatar_id":"","url":"https://api.github.com/users/pwgryglak","html_url":"https://github.com/pwgryglak","followers_url":"https://api.github.com/users/pwgryglak/followers","following_url":"https://api.github.com/users/pwgryglak/following{/other_user}","gists_url":"https://api.github.com/users/pwgryglak/gists{/gist_id}","starred_url":"https://api.github.com/users/pwgryglak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwgryglak/subscriptions","organizations_url":"https://api.github.com/users/pwgryglak/orgs","repos_url":"https://api.github.com/users/pwgryglak/repos","events_url":"https://api.github.com/users/pwgryglak/events{/privacy}","received_events_url":"https://api.github.com/users/pwgryglak/received_events","type":"User","site_admin":false},"assignees":[{"login":"pwgryglak","id":40759237,"node_id":"MDQ6VXNlcjQwNzU5MjM3","avatar_url":"https://avatars1.githubusercontent.com/u/40759237?v=4","gravatar_id":"","url":"https://api.github.com/users/pwgryglak","html_url":"https://github.com/pwgryglak","followers_url":"https://api.github.com/users/pwgryglak/followers","following_url":"https://api.github.com/users/pwgryglak/following{/other_user}","gists_url":"https://api.github.com/users/pwgryglak/gists{/gist_id}","starred_url":"https://api.github.com/users/pwgryglak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwgryglak/subscriptions","organizations_url":"https://api.github.com/users/pwgryglak/orgs","repos_url":"https://api.github.com/users/pwgryglak/repos","events_url":"https://api.github.com/users/pwgryglak/events{/privacy}","received_events_url":"https://api.github.com/users/pwgryglak/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-08-14T12:50:38Z","updated_at":"2018-12-03T16:21:28Z","closed_at":null,"author_association":"MEMBER","body":"We need mockups for the model translations views. I'm not sure how other platforms approach this problem, but here is the scenario that seems to me most reasonable:\r\n\r\n1. Go to a \"model translations\" section in the dashboard.\r\n2. Select a language to edit.\r\n3. Display a list of all translatable strings in a more or less this form:\r\n Context - Field name - Original value - Input\r\ne.g.\r\n Product - description - \"Description in the original language.\" - \"Description in a different language.\"\r\n\r\nThe biggest advantage of this approach is that we have all translations in one place and can easily give access to this section only to translators with proper permissions.\r\n\r\nAny ideas are welcomed. Also, let me know if there are better approaches to this problem."},"comment":{"url":"https://api.github.com/repos/mirumee/saleor/issues/comments/443770275","html_url":"https://github.com/mirumee/saleor/issues/2564#issuecomment-443770275","issue_url":"https://api.github.com/repos/mirumee/saleor/issues/2564","id":443770275,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mzc3MDI3NQ==","user":{"login":"diramazioni","id":682046,"node_id":"MDQ6VXNlcjY4MjA0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/682046?v=4","gravatar_id":"","url":"https://api.github.com/users/diramazioni","html_url":"https://github.com/diramazioni","followers_url":"https://api.github.com/users/diramazioni/followers","following_url":"https://api.github.com/users/diramazioni/following{/other_user}","gists_url":"https://api.github.com/users/diramazioni/gists{/gist_id}","starred_url":"https://api.github.com/users/diramazioni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diramazioni/subscriptions","organizations_url":"https://api.github.com/users/diramazioni/orgs","repos_url":"https://api.github.com/users/diramazioni/repos","events_url":"https://api.github.com/users/diramazioni/events{/privacy}","received_events_url":"https://api.github.com/users/diramazioni/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T16:21:28Z","updated_at":"2018-12-03T16:21:28Z","author_association":"NONE","body":"I was thinking something very simple and intuitive like\r\n\r\n\r\n"}}
|
{
"id": 8162715,
"name": "mirumee/saleor",
"url": "https://api.github.com/repos/mirumee/saleor"
}
|
{
"id": 682046,
"login": "diramazioni",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/682046?",
"url": "https://api.github.com/users/diramazioni"
}
|
{
"id": 170574,
"login": "mirumee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/170574?",
"url": "https://api.github.com/orgs/mirumee"
}
| 2018-12-03T16:21:28 |
8688540738
|
{"actor":{"display_login":"diramazioni"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/640","repository_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal","labels_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/640/labels{/name}","comments_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/640/comments","events_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/640/events","html_url":"https://github.com/unicef/etools-partner-reporting-portal/issues/640","id":319374157,"node_id":"MDU6SXNzdWUzMTkzNzQxNTc=","number":640,"title":"Should not be able to add the wrong Partner to a Project","user":{"login":"sethgold8","id":31295242,"node_id":"MDQ6VXNlcjMxMjk1MjQy","avatar_url":"https://avatars1.githubusercontent.com/u/31295242?v=4","gravatar_id":"","url":"https://api.github.com/users/sethgold8","html_url":"https://github.com/sethgold8","followers_url":"https://api.github.com/users/sethgold8/followers","following_url":"https://api.github.com/users/sethgold8/following{/other_user}","gists_url":"https://api.github.com/users/sethgold8/gists{/gist_id}","starred_url":"https://api.github.com/users/sethgold8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethgold8/subscriptions","organizations_url":"https://api.github.com/users/sethgold8/orgs","repos_url":"https://api.github.com/users/sethgold8/repos","events_url":"https://api.github.com/users/sethgold8/events{/privacy}","received_events_url":"https://api.github.com/users/sethgold8/received_events","type":"User","site_admin":false},"labels":[{"id":805754227,"node_id":"MDU6TGFiZWw4MDU3NTQyMjc=","url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/labels/cluster%20reporting","name":"cluster reporting","color":"0e8a16","default":false},{"id":601406949,"node_id":"MDU6TGFiZWw2MDE0MDY5NDk=","url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/labels/delivered","name":"delivered","color":"00e600","default":false}],"state":"open","locked":false,"assignee":{"login":"dfryta","id":778559,"node_id":"MDQ6VXNlcjc3ODU1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/778559?v=4","gravatar_id":"","url":"https://api.github.com/users/dfryta","html_url":"https://github.com/dfryta","followers_url":"https://api.github.com/users/dfryta/followers","following_url":"https://api.github.com/users/dfryta/following{/other_user}","gists_url":"https://api.github.com/users/dfryta/gists{/gist_id}","starred_url":"https://api.github.com/users/dfryta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfryta/subscriptions","organizations_url":"https://api.github.com/users/dfryta/orgs","repos_url":"https://api.github.com/users/dfryta/repos","events_url":"https://api.github.com/users/dfryta/events{/privacy}","received_events_url":"https://api.github.com/users/dfryta/received_events","type":"User","site_admin":false},"assignees":[{"login":"dfryta","id":778559,"node_id":"MDQ6VXNlcjc3ODU1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/778559?v=4","gravatar_id":"","url":"https://api.github.com/users/dfryta","html_url":"https://github.com/dfryta","followers_url":"https://api.github.com/users/dfryta/followers","following_url":"https://api.github.com/users/dfryta/following{/other_user}","gists_url":"https://api.github.com/users/dfryta/gists{/gist_id}","starred_url":"https://api.github.com/users/dfryta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfryta/subscriptions","organizations_url":"https://api.github.com/users/dfryta/orgs","repos_url":"https://api.github.com/users/dfryta/repos","events_url":"https://api.github.com/users/dfryta/events{/privacy}","received_events_url":"https://api.github.com/users/dfryta/received_events","type":"User","site_admin":false},{"login":"momimomo","id":21158922,"node_id":"MDQ6VXNlcjIxMTU4OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/21158922?v=4","gravatar_id":"","url":"https://api.github.com/users/momimomo","html_url":"https://github.com/momimomo","followers_url":"https://api.github.com/users/momimomo/followers","following_url":"https://api.github.com/users/momimomo/following{/other_user}","gists_url":"https://api.github.com/users/momimomo/gists{/gist_id}","starred_url":"https://api.github.com/users/momimomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momimomo/subscriptions","organizations_url":"https://api.github.com/users/momimomo/orgs","repos_url":"https://api.github.com/users/momimomo/repos","events_url":"https://api.github.com/users/momimomo/events{/privacy}","received_events_url":"https://api.github.com/users/momimomo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-05-02T00:40:13Z","updated_at":"2018-06-22T17:43:06Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Technical Notes**\n#Frontend - pass in PRP partner ID back to backend when getting list of projects.\n\n#Backend - Call OCHA as per usual (don't think they support partner filtering and that is fine, we'll do the filtering in-memory in PRP), when response comes back filter out projects that belong to the PRP partner id and return response. Filtering will be done for the ocha partner id in PRP. If ocha partner id is not set for this partner id sent by frontend, then well no need to call OCHA even, return a \"blank response\" (no projects).\n\n\n**Requirement**\n\n- [ ] Acting as an IMO:\n\n After a partner is selected, only show projects that the partner has registered to them in OCHA's OPS/Projects Module pertaining to that workspace.\n\n\n\n- [ ] Acting as a partner: when you are adding Projects, only Only show projects that the partner has registered to them in OCHA's OPS/Projects Module pertaining to that workspace."},"comment":{"url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/comments/399522772","html_url":"https://github.com/unicef/etools-partner-reporting-portal/issues/640#issuecomment-399522772","issue_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/640","id":399522772,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTUyMjc3Mg==","user":{"login":"sethgold8","id":31295242,"node_id":"MDQ6VXNlcjMxMjk1MjQy","avatar_url":"https://avatars1.githubusercontent.com/u/31295242?v=4","gravatar_id":"","url":"https://api.github.com/users/sethgold8","html_url":"https://github.com/sethgold8","followers_url":"https://api.github.com/users/sethgold8/followers","following_url":"https://api.github.com/users/sethgold8/following{/other_user}","gists_url":"https://api.github.com/users/sethgold8/gists{/gist_id}","starred_url":"https://api.github.com/users/sethgold8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethgold8/subscriptions","organizations_url":"https://api.github.com/users/sethgold8/orgs","repos_url":"https://api.github.com/users/sethgold8/repos","events_url":"https://api.github.com/users/sethgold8/events{/privacy}","received_events_url":"https://api.github.com/users/sethgold8/received_events","type":"User","site_admin":false},"created_at":"2018-06-22T17:43:06Z","updated_at":"2018-06-22T17:43:06Z","author_association":"CONTRIBUTOR","body":"Looks great. \n\nOnly item is if I select a project from OCHA for a specific Partner, and then change the partner, It allows me to still save that project.\n\nFor example, I selected Action CONTRE LA FAIM, and choose ' Strengthening Nutrition Surveillance for appropriate emergency response.' Then I change the partner to ACTED, and was able to save ' Strengthening Nutrition Surveillance for appropriate emergency response.' for them.\n\n"}}
|
{
"id": 85220489,
"name": "unicef/etools-partner-reporting-portal",
"url": "https://api.github.com/repos/unicef/etools-partner-reporting-portal"
}
|
{
"id": 31295242,
"login": "sethgold8",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31295242?",
"url": "https://api.github.com/users/sethgold8"
}
|
{
"id": 175849,
"login": "unicef",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/175849?",
"url": "https://api.github.com/orgs/unicef"
}
| 2018-06-22T17:43:06 |
7865458001
|
{"actor":{"display_login":"sethgold8"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/intermine/bluegenes/issues/306","repository_url":"https://api.github.com/repos/intermine/bluegenes","labels_url":"https://api.github.com/repos/intermine/bluegenes/issues/306/labels{/name}","comments_url":"https://api.github.com/repos/intermine/bluegenes/issues/306/comments","events_url":"https://api.github.com/repos/intermine/bluegenes/issues/306/events","html_url":"https://github.com/intermine/bluegenes/pull/306","id":388158898,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NDg2MzUy","number":306,"title":"Fix Region Area","user":{"login":"sehgalvibhor","id":10993808,"node_id":"MDQ6VXNlcjEwOTkzODA4","avatar_url":"https://avatars3.githubusercontent.com/u/10993808?v=4","gravatar_id":"","url":"https://api.github.com/users/sehgalvibhor","html_url":"https://github.com/sehgalvibhor","followers_url":"https://api.github.com/users/sehgalvibhor/followers","following_url":"https://api.github.com/users/sehgalvibhor/following{/other_user}","gists_url":"https://api.github.com/users/sehgalvibhor/gists{/gist_id}","starred_url":"https://api.github.com/users/sehgalvibhor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sehgalvibhor/subscriptions","organizations_url":"https://api.github.com/users/sehgalvibhor/orgs","repos_url":"https://api.github.com/users/sehgalvibhor/repos","events_url":"https://api.github.com/users/sehgalvibhor/events{/privacy}","received_events_url":"https://api.github.com/users/sehgalvibhor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-06T10:53:16Z","updated_at":"2018-12-21T14:47:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/intermine/bluegenes/pulls/306","html_url":"https://github.com/intermine/bluegenes/pull/306","diff_url":"https://github.com/intermine/bluegenes/pull/306.diff","patch_url":"https://github.com/intermine/bluegenes/pull/306.patch"},"body":"## PR authors: Vibhor S.\r\n### Please describe your PR:\r\nCloses #305 \r\nPartially Resolves #304 \r\n\r\nChanging position of the Textarea to `relative` solves the issue. However, moving the cross button along the expansion/contraction of the textarea is still unresolved.\r\n\r\n## Reviewers:\r\n### Review checklist: \r\n\r\n Before merging, confirm the following tasks have been executed\r\n\r\n- [x] review a _minified_ build (e.g. `lein prod`, _not_ `lein figwheel`). \r\n\r\nChecked the following pages load results successfully and allow you to proceed to the results or report page:\r\n\r\n- [ ] ID resolver + results preview\r\n- [ ] Templates execute and show results\r\n- [ ] Templates allow you to select lists AND type in identifiers\r\n- [ ] Search (dropdown preview version)\r\n- [ ] Search (full results page)\r\n- [ ] Report page loads, including homologues and tools\r\n- [ ] Region search\r\n- [ ] Login and logout works for more than one user (use test user [email protected] pw demo if needed)\r\n\r\nThis is not an exhaustive list - if you spot something else strange please bring it up!\r\n"},"comment":{"url":"https://api.github.com/repos/intermine/bluegenes/issues/comments/449407034","html_url":"https://github.com/intermine/bluegenes/pull/306#issuecomment-449407034","issue_url":"https://api.github.com/repos/intermine/bluegenes/issues/306","id":449407034,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQwNzAzNA==","user":{"login":"yochannah","id":9271438,"node_id":"MDQ6VXNlcjkyNzE0Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/9271438?v=4","gravatar_id":"","url":"https://api.github.com/users/yochannah","html_url":"https://github.com/yochannah","followers_url":"https://api.github.com/users/yochannah/followers","following_url":"https://api.github.com/users/yochannah/following{/other_user}","gists_url":"https://api.github.com/users/yochannah/gists{/gist_id}","starred_url":"https://api.github.com/users/yochannah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yochannah/subscriptions","organizations_url":"https://api.github.com/users/yochannah/orgs","repos_url":"https://api.github.com/users/yochannah/repos","events_url":"https://api.github.com/users/yochannah/events{/privacy}","received_events_url":"https://api.github.com/users/yochannah/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T14:47:22Z","updated_at":"2018-12-21T14:47:22Z","author_association":"MEMBER","body":"@sehgalvibhor thanks for this PR! One question - in order to test this I need to replicate the issue, but it doesn't seem to occur for me. What browser are you using?"}}
|
{
"id": 64344503,
"name": "intermine/bluegenes",
"url": "https://api.github.com/repos/intermine/bluegenes"
}
|
{
"id": 9271438,
"login": "yochannah",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9271438?",
"url": "https://api.github.com/users/yochannah"
}
|
{
"id": 179399,
"login": "intermine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/179399?",
"url": "https://api.github.com/orgs/intermine"
}
| 2018-12-21T14:47:22 |
8792022289
|
{"actor":{"display_login":"yochannah"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/adafruit/circuitpython/issues/635","repository_url":"https://api.github.com/repos/adafruit/circuitpython","labels_url":"https://api.github.com/repos/adafruit/circuitpython/issues/635/labels{/name}","comments_url":"https://api.github.com/repos/adafruit/circuitpython/issues/635/comments","events_url":"https://api.github.com/repos/adafruit/circuitpython/issues/635/events","html_url":"https://github.com/adafruit/circuitpython/issues/635","id":299516082,"number":635,"title":"CircuitPython Quick Start Unification","user":{"login":"kattni","id":7865090,"avatar_url":"https://avatars2.githubusercontent.com/u/7865090?v=4","gravatar_id":"","url":"https://api.github.com/users/kattni","html_url":"https://github.com/kattni","followers_url":"https://api.github.com/users/kattni/followers","following_url":"https://api.github.com/users/kattni/following{/other_user}","gists_url":"https://api.github.com/users/kattni/gists{/gist_id}","starred_url":"https://api.github.com/users/kattni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kattni/subscriptions","organizations_url":"https://api.github.com/users/kattni/orgs","repos_url":"https://api.github.com/users/kattni/repos","events_url":"https://api.github.com/users/kattni/events{/privacy}","received_events_url":"https://api.github.com/users/kattni/received_events","type":"User","site_admin":false},"labels":[{"id":825374436,"url":"https://api.github.com/repos/adafruit/circuitpython/labels/learn%20guide","name":"learn guide","color":"1d9ca5","default":false}],"state":"open","locked":false,"assignee":{"login":"ladyada","id":1214161,"avatar_url":"https://avatars2.githubusercontent.com/u/1214161?v=4","gravatar_id":"","url":"https://api.github.com/users/ladyada","html_url":"https://github.com/ladyada","followers_url":"https://api.github.com/users/ladyada/followers","following_url":"https://api.github.com/users/ladyada/following{/other_user}","gists_url":"https://api.github.com/users/ladyada/gists{/gist_id}","starred_url":"https://api.github.com/users/ladyada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ladyada/subscriptions","organizations_url":"https://api.github.com/users/ladyada/orgs","repos_url":"https://api.github.com/users/ladyada/repos","events_url":"https://api.github.com/users/ladyada/events{/privacy}","received_events_url":"https://api.github.com/users/ladyada/received_events","type":"User","site_admin":false},"assignees":[{"login":"ladyada","id":1214161,"avatar_url":"https://avatars2.githubusercontent.com/u/1214161?v=4","gravatar_id":"","url":"https://api.github.com/users/ladyada","html_url":"https://github.com/ladyada","followers_url":"https://api.github.com/users/ladyada/followers","following_url":"https://api.github.com/users/ladyada/following{/other_user}","gists_url":"https://api.github.com/users/ladyada/gists{/gist_id}","starred_url":"https://api.github.com/users/ladyada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ladyada/subscriptions","organizations_url":"https://api.github.com/users/ladyada/orgs","repos_url":"https://api.github.com/users/ladyada/repos","events_url":"https://api.github.com/users/ladyada/events{/privacy}","received_events_url":"https://api.github.com/users/ladyada/received_events","type":"User","site_admin":false},{"login":"kattni","id":7865090,"avatar_url":"https://avatars2.githubusercontent.com/u/7865090?v=4","gravatar_id":"","url":"https://api.github.com/users/kattni","html_url":"https://github.com/kattni","followers_url":"https://api.github.com/users/kattni/followers","following_url":"https://api.github.com/users/kattni/following{/other_user}","gists_url":"https://api.github.com/users/kattni/gists{/gist_id}","starred_url":"https://api.github.com/users/kattni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kattni/subscriptions","organizations_url":"https://api.github.com/users/kattni/orgs","repos_url":"https://api.github.com/users/kattni/repos","events_url":"https://api.github.com/users/kattni/events{/privacy}","received_events_url":"https://api.github.com/users/kattni/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-02-22T21:33:18Z","updated_at":"2018-02-22T22:50:23Z","closed_at":null,"author_association":"MEMBER","body":"Unify the CircuitPython quick starts for mirroring across all the board guides!\r\n\r\nFor CircuitPython Expectations, see issue #583 \r\n\r\n**QUICK START PAGES:**\r\n\r\n- [x] CircuitPython Built-Ins\r\n\r\n- [ ] CircuitPython Digital In & Out\r\n\r\n- [ ] CircuitPython Analog In\r\n\r\n- [ ] CircuitPython Analog Out\r\n\r\n- [ ] CircuitPython Internal Dotstar (NeoPixel)\r\n\r\n- [ ] CircuitPython Cap Touch\r\n\r\n- [ ] CircuitPython I2C Scan\r\n\r\n- [ ] CircuitPython I2C Sensor\r\n\r\n- [ ] CircuitPython UART Serial\r\n\r\n- [ ] CircuitPython NeoPixel\r\n\r\n- [ ] CircuitPython DotStar\r\n\r\n- [ ] CircuitPython PWM\r\n\r\n- [ ] CircuitPython HID Keyboard\r\n\r\n- [ ] CircuitPython CPU Temp\r\n\r\n- [ ] CircuitPython SPI & SD Card\r\n\r\n- [ ] CircuitPython Storage"},"comment":{"url":"https://api.github.com/repos/adafruit/circuitpython/issues/comments/367849936","html_url":"https://github.com/adafruit/circuitpython/issues/635#issuecomment-367849936","issue_url":"https://api.github.com/repos/adafruit/circuitpython/issues/635","id":367849936,"user":{"login":"kattni","id":7865090,"avatar_url":"https://avatars2.githubusercontent.com/u/7865090?v=4","gravatar_id":"","url":"https://api.github.com/users/kattni","html_url":"https://github.com/kattni","followers_url":"https://api.github.com/users/kattni/followers","following_url":"https://api.github.com/users/kattni/following{/other_user}","gists_url":"https://api.github.com/users/kattni/gists{/gist_id}","starred_url":"https://api.github.com/users/kattni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kattni/subscriptions","organizations_url":"https://api.github.com/users/kattni/orgs","repos_url":"https://api.github.com/users/kattni/repos","events_url":"https://api.github.com/users/kattni/events{/privacy}","received_events_url":"https://api.github.com/users/kattni/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T22:50:23Z","updated_at":"2018-02-22T22:50:23Z","author_association":"MEMBER","body":"Is D2 on the ItsyBitsy the 2 in the corner or is it the alternate of A2?"}}
|
{
"id": 66166069,
"name": "adafruit/circuitpython",
"url": "https://api.github.com/repos/adafruit/circuitpython"
}
|
{
"id": 7865090,
"login": "kattni",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7865090?",
"url": "https://api.github.com/users/kattni"
}
|
{
"id": 181069,
"login": "adafruit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/181069?",
"url": "https://api.github.com/orgs/adafruit"
}
| 2018-02-22T22:50:23 |
7284488858
|
{"actor":{"display_login":"kattni"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/adafruit/circuitpython/issues/622","repository_url":"https://api.github.com/repos/adafruit/circuitpython","labels_url":"https://api.github.com/repos/adafruit/circuitpython/issues/622/labels{/name}","comments_url":"https://api.github.com/repos/adafruit/circuitpython/issues/622/comments","events_url":"https://api.github.com/repos/adafruit/circuitpython/issues/622/events","html_url":"https://github.com/adafruit/circuitpython/issues/622","id":296622954,"node_id":"MDU6SXNzdWUyOTY2MjI5NTQ=","number":622,"title":"Consistency in unified sensor driver property naming","user":{"login":"tuupola","id":21913,"node_id":"MDQ6VXNlcjIxOTEz","avatar_url":"https://avatars0.githubusercontent.com/u/21913?v=4","gravatar_id":"","url":"https://api.github.com/users/tuupola","html_url":"https://github.com/tuupola","followers_url":"https://api.github.com/users/tuupola/followers","following_url":"https://api.github.com/users/tuupola/following{/other_user}","gists_url":"https://api.github.com/users/tuupola/gists{/gist_id}","starred_url":"https://api.github.com/users/tuupola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuupola/subscriptions","organizations_url":"https://api.github.com/users/tuupola/orgs","repos_url":"https://api.github.com/users/tuupola/repos","events_url":"https://api.github.com/users/tuupola/events{/privacy}","received_events_url":"https://api.github.com/users/tuupola/received_events","type":"User","site_admin":false},"labels":[{"id":704634923,"node_id":"MDU6TGFiZWw3MDQ2MzQ5MjM=","url":"https://api.github.com/repos/adafruit/circuitpython/labels/driver","name":"driver","color":"006b75","default":false},{"id":685344940,"node_id":"MDU6TGFiZWw2ODUzNDQ5NDA=","url":"https://api.github.com/repos/adafruit/circuitpython/labels/good%20first%20issue","name":"good first issue","color":"e80080","default":true}],"state":"closed","locked":false,"assignee":{"login":"brentru","id":322428,"node_id":"MDQ6VXNlcjMyMjQyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/322428?v=4","gravatar_id":"","url":"https://api.github.com/users/brentru","html_url":"https://github.com/brentru","followers_url":"https://api.github.com/users/brentru/followers","following_url":"https://api.github.com/users/brentru/following{/other_user}","gists_url":"https://api.github.com/users/brentru/gists{/gist_id}","starred_url":"https://api.github.com/users/brentru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentru/subscriptions","organizations_url":"https://api.github.com/users/brentru/orgs","repos_url":"https://api.github.com/users/brentru/repos","events_url":"https://api.github.com/users/brentru/events{/privacy}","received_events_url":"https://api.github.com/users/brentru/received_events","type":"User","site_admin":false},"assignees":[{"login":"brentru","id":322428,"node_id":"MDQ6VXNlcjMyMjQyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/322428?v=4","gravatar_id":"","url":"https://api.github.com/users/brentru","html_url":"https://github.com/brentru","followers_url":"https://api.github.com/users/brentru/followers","following_url":"https://api.github.com/users/brentru/following{/other_user}","gists_url":"https://api.github.com/users/brentru/gists{/gist_id}","starred_url":"https://api.github.com/users/brentru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentru/subscriptions","organizations_url":"https://api.github.com/users/brentru/orgs","repos_url":"https://api.github.com/users/brentru/repos","events_url":"https://api.github.com/users/brentru/events{/privacy}","received_events_url":"https://api.github.com/users/brentru/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/adafruit/circuitpython/milestones/5","html_url":"https://github.com/adafruit/circuitpython/milestone/5","labels_url":"https://api.github.com/repos/adafruit/circuitpython/milestones/5/labels","id":2674476,"node_id":"MDk6TWlsZXN0b25lMjY3NDQ3Ng==","number":5,"title":"3.0","description":"These are issues that need to be handled before we launch a Release Candidate of 3.0.0. We'll release beta versions while we work through these issues. Once this list has no entries, we'll do a release candidate and the issues on this list will then trigger further release candidates.","creator":{"login":"tannewt","id":52649,"node_id":"MDQ6VXNlcjUyNjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/52649?v=4","gravatar_id":"","url":"https://api.github.com/users/tannewt","html_url":"https://github.com/tannewt","followers_url":"https://api.github.com/users/tannewt/followers","following_url":"https://api.github.com/users/tannewt/following{/other_user}","gists_url":"https://api.github.com/users/tannewt/gists{/gist_id}","starred_url":"https://api.github.com/users/tannewt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannewt/subscriptions","organizations_url":"https://api.github.com/users/tannewt/orgs","repos_url":"https://api.github.com/users/tannewt/repos","events_url":"https://api.github.com/users/tannewt/events{/privacy}","received_events_url":"https://api.github.com/users/tannewt/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":97,"state":"open","created_at":"2017-08-01T16:57:26Z","updated_at":"2018-06-04T20:15:53Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2018-02-13T05:59:24Z","updated_at":"2018-06-04T20:15:53Z","closed_at":"2018-06-04T20:15:53Z","author_association":"NONE","body":"To avoid hijacking an [unrelated thread](https://github.com/adafruit/circuitpython/pull/600) I move this here. Currently there is [mixed capitalization](https://github.com/tannewt/circuitpython/blob/09bf06bc6bf4eba0ad03916425ad45ebab9f0025/docs/design_guide.rst#L470-L472) in the design guide concerning unified sensor driver property naming.\r\n\r\nConsistency is usually good thing. If everything is lowercased there is no need to remember whether one should use capital letters or not. For example lux might be confusing. Is it acronym or word? Should it be `sensor.lux` or `sensor.LUX`? Also when seeing `sensor.TVOC` one is not really sure if it is a constant or property.\r\n\r\nI do not have strong feelings about this, but my choice would be lowercased acronyms `sensor.tvoc` and `sensor.eco2`."},"comment":{"url":"https://api.github.com/repos/adafruit/circuitpython/issues/comments/394484165","html_url":"https://github.com/adafruit/circuitpython/issues/622#issuecomment-394484165","issue_url":"https://api.github.com/repos/adafruit/circuitpython/issues/622","id":394484165,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDQ4NDE2NQ==","user":{"login":"tannewt","id":52649,"node_id":"MDQ6VXNlcjUyNjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/52649?v=4","gravatar_id":"","url":"https://api.github.com/users/tannewt","html_url":"https://github.com/tannewt","followers_url":"https://api.github.com/users/tannewt/followers","following_url":"https://api.github.com/users/tannewt/following{/other_user}","gists_url":"https://api.github.com/users/tannewt/gists{/gist_id}","starred_url":"https://api.github.com/users/tannewt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannewt/subscriptions","organizations_url":"https://api.github.com/users/tannewt/orgs","repos_url":"https://api.github.com/users/tannewt/repos","events_url":"https://api.github.com/users/tannewt/events{/privacy}","received_events_url":"https://api.github.com/users/tannewt/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T20:15:53Z","updated_at":"2018-06-04T20:15:53Z","author_association":"COLLABORATOR","body":"Awesome! I think this is done then. Please reopen if not."}}
|
{
"id": 66166069,
"name": "adafruit/circuitpython",
"url": "https://api.github.com/repos/adafruit/circuitpython"
}
|
{
"id": 52649,
"login": "tannewt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/52649?",
"url": "https://api.github.com/users/tannewt"
}
|
{
"id": 181069,
"login": "adafruit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/181069?",
"url": "https://api.github.com/orgs/adafruit"
}
| 2018-06-04T20:15:54 |
7774106611
|
{"actor":{"display_login":"tannewt"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/adafruit/circuitpython/issues/841","repository_url":"https://api.github.com/repos/adafruit/circuitpython","labels_url":"https://api.github.com/repos/adafruit/circuitpython/issues/841/labels{/name}","comments_url":"https://api.github.com/repos/adafruit/circuitpython/issues/841/comments","events_url":"https://api.github.com/repos/adafruit/circuitpython/issues/841/events","html_url":"https://github.com/adafruit/circuitpython/pull/841","id":323322458,"number":841,"title":"Feature: shortcut I2C support for atmel-samd boards","user":{"login":"matt-land","id":4174972,"avatar_url":"https://avatars3.githubusercontent.com/u/4174972?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-land","html_url":"https://github.com/matt-land","followers_url":"https://api.github.com/users/matt-land/followers","following_url":"https://api.github.com/users/matt-land/following{/other_user}","gists_url":"https://api.github.com/users/matt-land/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-land/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-land/subscriptions","organizations_url":"https://api.github.com/users/matt-land/orgs","repos_url":"https://api.github.com/users/matt-land/repos","events_url":"https://api.github.com/users/matt-land/events{/privacy}","received_events_url":"https://api.github.com/users/matt-land/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-15T17:58:35Z","updated_at":"2018-05-16T20:50:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/adafruit/circuitpython/pulls/841","html_url":"https://github.com/adafruit/circuitpython/pull/841","diff_url":"https://github.com/adafruit/circuitpython/pull/841.diff","patch_url":"https://github.com/adafruit/circuitpython/pull/841.patch"},"body":"Feature: Add default I2C buses to boards\r\nFollowing a maintainer [discussion](https://github.com/adafruit/circuitpython/issues/340) in Oct '17, there was a desire to have a standardized way to initialize I2C devices when using micropython. \r\n\r\nThis PR implements a standard way to initialize I2C. It does not remove any existing methods that perform the same. \r\n\r\n```python\r\nimport board\r\nmy_i2c = board.I2C()\r\n```\r\n The defaults are assigned following the SDA/SCL definitions of the ~~'Pinout' section in /ports/amtel-sand/boards/README.rst (when available) and best effort otherwise.~~ pins.h file of each board. A few of the boards do not have MP_QSTR_SDA/MP_QSTR_SCL defined, so I2C support was not added.\r\n\r\n\r\nThanks to Scott\r\n\r\nSuppored:\r\n- Arduino Zero\r\n- Circuitplayground Express\r\n- Feather M0 Adalogger\r\n- Feather M0 Basic\r\n- Feather M0 Express\r\n- Feather M0 RFM69\r\n- Feather M0 RFM9X\r\n- Feather M0 Supersized\r\n- Feather M4 Express\r\n- Gemma M0\r\n- Itsybitsy M0 Express\r\n- Itsybitsy M4 Express\r\n- Metro M0 Express\r\n- Metro M4 Express\r\n- Metro M4 Express Rev B\r\n- Trinket M0\r\n- Trinket M0 haxpress\r\n\r\nNot Supported:\r\n- UGame\r\n- PirKey"},"comment":{"url":"https://api.github.com/repos/adafruit/circuitpython/issues/comments/389661136","html_url":"https://github.com/adafruit/circuitpython/pull/841#issuecomment-389661136","issue_url":"https://api.github.com/repos/adafruit/circuitpython/issues/841","id":389661136,"user":{"login":"jerryneedell","id":15856834,"avatar_url":"https://avatars0.githubusercontent.com/u/15856834?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryneedell","html_url":"https://github.com/jerryneedell","followers_url":"https://api.github.com/users/jerryneedell/followers","following_url":"https://api.github.com/users/jerryneedell/following{/other_user}","gists_url":"https://api.github.com/users/jerryneedell/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryneedell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryneedell/subscriptions","organizations_url":"https://api.github.com/users/jerryneedell/orgs","repos_url":"https://api.github.com/users/jerryneedell/repos","events_url":"https://api.github.com/users/jerryneedell/events{/privacy}","received_events_url":"https://api.github.com/users/jerryneedell/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T20:50:30Z","updated_at":"2018-05-16T20:50:30Z","author_association":"COLLABORATOR","body":"These failures are due to PR #829 there needs to be dummy argument for the timeout.It is ignored for busio, but needed for bitbangio. "}}
|
{
"id": 66166069,
"name": "adafruit/circuitpython",
"url": "https://api.github.com/repos/adafruit/circuitpython"
}
|
{
"id": 15856834,
"login": "jerryneedell",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15856834?",
"url": "https://api.github.com/users/jerryneedell"
}
|
{
"id": 181069,
"login": "adafruit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/181069?",
"url": "https://api.github.com/orgs/adafruit"
}
| 2018-05-16T20:50:30 |
7685842897
|
{"actor":{"display_login":"jerryneedell"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/sendgrid/sendgrid-php/issues/596","repository_url":"https://api.github.com/repos/sendgrid/sendgrid-php","labels_url":"https://api.github.com/repos/sendgrid/sendgrid-php/issues/596/labels{/name}","comments_url":"https://api.github.com/repos/sendgrid/sendgrid-php/issues/596/comments","events_url":"https://api.github.com/repos/sendgrid/sendgrid-php/issues/596/events","html_url":"https://github.com/sendgrid/sendgrid-php/issues/596","id":311704565,"number":596,"title":"Percent Symbol in html message causing Json Encoding Error when using postRequest to create a new Sendgrid campaign","user":{"login":"rbalassa","id":38111720,"avatar_url":"https://avatars3.githubusercontent.com/u/38111720?v=4","gravatar_id":"","url":"https://api.github.com/users/rbalassa","html_url":"https://github.com/rbalassa","followers_url":"https://api.github.com/users/rbalassa/followers","following_url":"https://api.github.com/users/rbalassa/following{/other_user}","gists_url":"https://api.github.com/users/rbalassa/gists{/gist_id}","starred_url":"https://api.github.com/users/rbalassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbalassa/subscriptions","organizations_url":"https://api.github.com/users/rbalassa/orgs","repos_url":"https://api.github.com/users/rbalassa/repos","events_url":"https://api.github.com/users/rbalassa/events{/privacy}","received_events_url":"https://api.github.com/users/rbalassa/received_events","type":"User","site_admin":false},"labels":[{"id":733723763,"url":"https://api.github.com/repos/sendgrid/sendgrid-php/labels/difficulty:%20unknown%20or%20n/a","name":"difficulty: unknown or n/a","color":"ffffff","default":false},{"id":378656146,"url":"https://api.github.com/repos/sendgrid/sendgrid-php/labels/status:%20help%20wanted","name":"status: help wanted","color":"cccccc","default":false},{"id":23680158,"url":"https://api.github.com/repos/sendgrid/sendgrid-php/labels/type:%20question","name":"type: question","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-05T17:38:24Z","updated_at":"2018-04-05T20:58:15Z","closed_at":null,"author_association":"NONE","body":"When I try to create a new Sendgrid campaign by sending a postRequest, I get a system error \"Unable to parse response body into JSON\" in \"sendgrid-php/lib/SendGrid.php(140):\"\r\n\r\nAfter several hours of debugging, I noticed that this only happened when I had % signs into the html code of the email. When I remove the html code, the JSON is parsed without any issue.\r\n\r\nHere is a sample code I'm using to reproduce the error:\r\n\r\n`<html><head><title></title></head><body><div style=\"width:100%\">Check out our spring line!</div></body></html>`\r\n\r\nAny idea how to resolve this, other than removing the % symbols from the html code?\r\n\r\nThanks!\r\n\r\n* sendgrid-php Version: 3\r\n* PHP Version: 7.2\r\n"},"comment":{"url":"https://api.github.com/repos/sendgrid/sendgrid-php/issues/comments/379074518","html_url":"https://github.com/sendgrid/sendgrid-php/issues/596#issuecomment-379074518","issue_url":"https://api.github.com/repos/sendgrid/sendgrid-php/issues/596","id":379074518,"user":{"login":"rbalassa","id":38111720,"avatar_url":"https://avatars3.githubusercontent.com/u/38111720?v=4","gravatar_id":"","url":"https://api.github.com/users/rbalassa","html_url":"https://github.com/rbalassa","followers_url":"https://api.github.com/users/rbalassa/followers","following_url":"https://api.github.com/users/rbalassa/following{/other_user}","gists_url":"https://api.github.com/users/rbalassa/gists{/gist_id}","starred_url":"https://api.github.com/users/rbalassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbalassa/subscriptions","organizations_url":"https://api.github.com/users/rbalassa/orgs","repos_url":"https://api.github.com/users/rbalassa/repos","events_url":"https://api.github.com/users/rbalassa/events{/privacy}","received_events_url":"https://api.github.com/users/rbalassa/received_events","type":"User","site_admin":false},"created_at":"2018-04-05T20:58:14Z","updated_at":"2018-04-05T20:58:14Z","author_association":"NONE","body":"Thanks Elmer for the reply.\r\n\r\nI tested the htmlspecialchars function, and the result is not what is expected. The html is converted completely, but the % stay the same.\r\n\r\n`<html><head><title></title></head><body><div style="width:100**%**">Check out our spring line!</div></body></html>`\r\n\r\nSo still the same problem.\r\n\r\nAny other idea?\r\n\r\nThanks."}}
|
{
"id": 3348788,
"name": "sendgrid/sendgrid-php",
"url": "https://api.github.com/repos/sendgrid/sendgrid-php"
}
|
{
"id": 38111720,
"login": "rbalassa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38111720?",
"url": "https://api.github.com/users/rbalassa"
}
|
{
"id": 181234,
"login": "sendgrid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/181234?",
"url": "https://api.github.com/orgs/sendgrid"
}
| 2018-04-05T20:58:15 |
7487584797
|
{"actor":{"display_login":"rbalassa"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/sendgrid/docs/issues/3751","repository_url":"https://api.github.com/repos/sendgrid/docs","labels_url":"https://api.github.com/repos/sendgrid/docs/issues/3751/labels{/name}","comments_url":"https://api.github.com/repos/sendgrid/docs/issues/3751/comments","events_url":"https://api.github.com/repos/sendgrid/docs/issues/3751/events","html_url":"https://github.com/sendgrid/docs/issues/3751","id":344196426,"node_id":"MDU6SXNzdWUzNDQxOTY0MjY=","number":3751,"title":"Authentication","user":{"login":"asi851","id":40003267,"node_id":"MDQ6VXNlcjQwMDAzMjY3","avatar_url":"https://avatars0.githubusercontent.com/u/40003267?v=4","gravatar_id":"","url":"https://api.github.com/users/asi851","html_url":"https://github.com/asi851","followers_url":"https://api.github.com/users/asi851/followers","following_url":"https://api.github.com/users/asi851/following{/other_user}","gists_url":"https://api.github.com/users/asi851/gists{/gist_id}","starred_url":"https://api.github.com/users/asi851/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asi851/subscriptions","organizations_url":"https://api.github.com/users/asi851/orgs","repos_url":"https://api.github.com/users/asi851/repos","events_url":"https://api.github.com/users/asi851/events{/privacy}","received_events_url":"https://api.github.com/users/asi851/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-24T20:43:58Z","updated_at":"2018-07-25T15:20:14Z","closed_at":null,"author_association":"NONE","body":"https://sendgrid.com/docs/API_Reference/Web_API_v3/How_To_Use_The_Web_API_v3/authentication.html\r\n\r\nDiscovered the param `-H 'on-behalf-of: subuser_username' \\` is case sensitive. The header is ignored and returns the parent account stats instead of the subuser. I was able to get it to work with the snippet below, also provided a screenshot of the location. \r\n\r\n```\r\ncurl \"https://api.sendgrid.com/v3/stats?start_date=2018-07-01&end_date=2018-08-01&aggregated_by=month\" \\\r\n -H 'On-Behalf-Of: subuser_name' \\\r\n -H 'Authorization: Bearer {api key}' \\\r\n -H 'Content-Type: application/json'\r\n```\r\n\r\n\r\n\r\n[Screenshot of doc location](https://cl.ly/0N342O170k43)"},"comment":{"url":"https://api.github.com/repos/sendgrid/docs/issues/comments/407792408","html_url":"https://github.com/sendgrid/docs/issues/3751#issuecomment-407792408","issue_url":"https://api.github.com/repos/sendgrid/docs/issues/3751","id":407792408,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzc5MjQwOA==","user":{"login":"ksigler7","id":28788585,"node_id":"MDQ6VXNlcjI4Nzg4NTg1","avatar_url":"https://avatars0.githubusercontent.com/u/28788585?v=4","gravatar_id":"","url":"https://api.github.com/users/ksigler7","html_url":"https://github.com/ksigler7","followers_url":"https://api.github.com/users/ksigler7/followers","following_url":"https://api.github.com/users/ksigler7/following{/other_user}","gists_url":"https://api.github.com/users/ksigler7/gists{/gist_id}","starred_url":"https://api.github.com/users/ksigler7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksigler7/subscriptions","organizations_url":"https://api.github.com/users/ksigler7/orgs","repos_url":"https://api.github.com/users/ksigler7/repos","events_url":"https://api.github.com/users/ksigler7/events{/privacy}","received_events_url":"https://api.github.com/users/ksigler7/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T15:20:14Z","updated_at":"2018-07-25T15:20:14Z","author_association":"COLLABORATOR","body":"@asi851 - this is a really good catch! Thanks for letting us know about it. \r\n\r\nThe to-do here is to double check all of the `On-Behalf-Of` parameter examples and make sure they are all capitalized. Also probably worth adding a note [here](https://sendgrid.api-docs.io/v3.0/how-to-use-the-sendgrid-v3-api/on-behalf-of) specifically calling out that it's case sensitive."}}
|
{
"id": 4679626,
"name": "sendgrid/docs",
"url": "https://api.github.com/repos/sendgrid/docs"
}
|
{
"id": 28788585,
"login": "ksigler7",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28788585?",
"url": "https://api.github.com/users/ksigler7"
}
|
{
"id": 181234,
"login": "sendgrid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/181234?",
"url": "https://api.github.com/orgs/sendgrid"
}
| 2018-07-25T15:20:14 |
8017210113
|
{"actor":{"display_login":"ksigler7"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/sendgrid/dx-automator/issues/33","repository_url":"https://api.github.com/repos/sendgrid/dx-automator","labels_url":"https://api.github.com/repos/sendgrid/dx-automator/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/sendgrid/dx-automator/issues/33/comments","events_url":"https://api.github.com/repos/sendgrid/dx-automator/issues/33/events","html_url":"https://github.com/sendgrid/dx-automator/pull/33","id":367620032,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTkwNjI3","number":33,"title":"WIP: Run code through style guide checks","user":{"login":"uLan08","id":14162336,"node_id":"MDQ6VXNlcjE0MTYyMzM2","avatar_url":"https://avatars3.githubusercontent.com/u/14162336?v=4","gravatar_id":"","url":"https://api.github.com/users/uLan08","html_url":"https://github.com/uLan08","followers_url":"https://api.github.com/users/uLan08/followers","following_url":"https://api.github.com/users/uLan08/following{/other_user}","gists_url":"https://api.github.com/users/uLan08/gists{/gist_id}","starred_url":"https://api.github.com/users/uLan08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uLan08/subscriptions","organizations_url":"https://api.github.com/users/uLan08/orgs","repos_url":"https://api.github.com/users/uLan08/repos","events_url":"https://api.github.com/users/uLan08/events{/privacy}","received_events_url":"https://api.github.com/users/uLan08/received_events","type":"User","site_admin":false},"labels":[{"id":850617686,"node_id":"MDU6TGFiZWw4NTA2MTc2ODY=","url":"https://api.github.com/repos/sendgrid/dx-automator/labels/status:%20code%20review%20request","name":"status: code review request","color":"cccccc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-08T02:17:11Z","updated_at":"2018-10-08T02:17:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sendgrid/dx-automator/pulls/33","html_url":"https://github.com/sendgrid/dx-automator/pull/33","diff_url":"https://github.com/sendgrid/dx-automator/pull/33.diff","patch_url":"https://github.com/sendgrid/dx-automator/pull/33.patch"},"body":"<!--\r\nWe appreciate the effort for this pull request but before that please make sure you read the contribution guidelines given above, then fill out the blanks below.\r\n\r\n\r\nPlease enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged!\r\ne.g. \r\nFixes #1\r\nCloses #2\r\n-->\r\n# Fixes # \r\n\r\nAddresses #30 \r\n\r\nThis is still WIP. I just want to know if I am on the right track. \r\n\r\n### Checklist\r\n- [ ] I have made a material change to the repo (functionality, testing, spelling, grammar)\r\n- [ ] I have read the [Contribution Guide] and my PR follows them.\r\n- [ ] I updated my branch with the master branch.\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation about the functionality in the appropriate .md file\r\n- [ ] I have added in line documentation to the code I modified\r\n\r\n### Short description of what this PR does:\r\n- \r\n- \r\n\r\n<!--\r\nIf you have questions, please file a Github Issue in this repository!\r\n-->"},"comment":{"url":"https://api.github.com/repos/sendgrid/dx-automator/issues/comments/427707608","html_url":"https://github.com/sendgrid/dx-automator/pull/33#issuecomment-427707608","issue_url":"https://api.github.com/repos/sendgrid/dx-automator/issues/33","id":427707608,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzcwNzYwOA==","user":{"login":"SendGridDX","id":22159041,"node_id":"MDQ6VXNlcjIyMTU5MDQx","avatar_url":"https://avatars2.githubusercontent.com/u/22159041?v=4","gravatar_id":"","url":"https://api.github.com/users/SendGridDX","html_url":"https://github.com/SendGridDX","followers_url":"https://api.github.com/users/SendGridDX/followers","following_url":"https://api.github.com/users/SendGridDX/following{/other_user}","gists_url":"https://api.github.com/users/SendGridDX/gists{/gist_id}","starred_url":"https://api.github.com/users/SendGridDX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SendGridDX/subscriptions","organizations_url":"https://api.github.com/users/SendGridDX/orgs","repos_url":"https://api.github.com/users/SendGridDX/repos","events_url":"https://api.github.com/users/SendGridDX/events{/privacy}","received_events_url":"https://api.github.com/users/SendGridDX/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T02:17:27Z","updated_at":"2018-10-08T02:17:27Z","author_association":"NONE","body":"[](https://cla.sendgrid.com/sendgrid/dx-automator?pullRequest=33) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla.sendgrid.com/sendgrid/dx-automator?pullRequest=33) before we can accept your contribution.<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla.sendgrid.com/check/sendgrid/dx-automator?pullRequest=33) it.</sub>"}}
|
{
"id": 116304760,
"name": "sendgrid/dx-automator",
"url": "https://api.github.com/repos/sendgrid/dx-automator"
}
|
{
"id": 22159041,
"login": "SendGridDX",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22159041?",
"url": "https://api.github.com/users/SendGridDX"
}
|
{
"id": 181234,
"login": "sendgrid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/181234?",
"url": "https://api.github.com/orgs/sendgrid"
}
| 2018-10-08T02:17:27 |
8381571112
|
{"actor":{"display_login":"SendGridDX"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/geoserver/geoserver/issues/2856","repository_url":"https://api.github.com/repos/geoserver/geoserver","labels_url":"https://api.github.com/repos/geoserver/geoserver/issues/2856/labels{/name}","comments_url":"https://api.github.com/repos/geoserver/geoserver/issues/2856/comments","events_url":"https://api.github.com/repos/geoserver/geoserver/issues/2856/events","html_url":"https://github.com/geoserver/geoserver/pull/2856","id":317979226,"number":2856,"title":"Fix geofence integration with the feedback panels","user":{"login":"pvalsecc","id":1180608,"avatar_url":"https://avatars2.githubusercontent.com/u/1180608?v=4","gravatar_id":"","url":"https://api.github.com/users/pvalsecc","html_url":"https://github.com/pvalsecc","followers_url":"https://api.github.com/users/pvalsecc/followers","following_url":"https://api.github.com/users/pvalsecc/following{/other_user}","gists_url":"https://api.github.com/users/pvalsecc/gists{/gist_id}","starred_url":"https://api.github.com/users/pvalsecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvalsecc/subscriptions","organizations_url":"https://api.github.com/users/pvalsecc/orgs","repos_url":"https://api.github.com/users/pvalsecc/repos","events_url":"https://api.github.com/users/pvalsecc/events{/privacy}","received_events_url":"https://api.github.com/users/pvalsecc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"etj","id":717359,"avatar_url":"https://avatars3.githubusercontent.com/u/717359?v=4","gravatar_id":"","url":"https://api.github.com/users/etj","html_url":"https://github.com/etj","followers_url":"https://api.github.com/users/etj/followers","following_url":"https://api.github.com/users/etj/following{/other_user}","gists_url":"https://api.github.com/users/etj/gists{/gist_id}","starred_url":"https://api.github.com/users/etj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etj/subscriptions","organizations_url":"https://api.github.com/users/etj/orgs","repos_url":"https://api.github.com/users/etj/repos","events_url":"https://api.github.com/users/etj/events{/privacy}","received_events_url":"https://api.github.com/users/etj/received_events","type":"User","site_admin":false},"assignees":[{"login":"etj","id":717359,"avatar_url":"https://avatars3.githubusercontent.com/u/717359?v=4","gravatar_id":"","url":"https://api.github.com/users/etj","html_url":"https://github.com/etj","followers_url":"https://api.github.com/users/etj/followers","following_url":"https://api.github.com/users/etj/following{/other_user}","gists_url":"https://api.github.com/users/etj/gists{/gist_id}","starred_url":"https://api.github.com/users/etj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etj/subscriptions","organizations_url":"https://api.github.com/users/etj/orgs","repos_url":"https://api.github.com/users/etj/repos","events_url":"https://api.github.com/users/etj/events{/privacy}","received_events_url":"https://api.github.com/users/etj/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-04-26T11:02:29Z","updated_at":"2018-04-28T12:04:39Z","closed_at":"2018-04-26T15:24:26Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/geoserver/geoserver/pulls/2856","html_url":"https://github.com/geoserver/geoserver/pull/2856","diff_url":"https://github.com/geoserver/geoserver/pull/2856.diff","patch_url":"https://github.com/geoserver/geoserver/pull/2856.patch"},"body":"After 4bf80182d5f97a0a0d1aabe127791783f63c1907, geofence was broken. The feedback panel has been split into the top and bottom panels."},"comment":{"url":"https://api.github.com/repos/geoserver/geoserver/issues/comments/385170063","html_url":"https://github.com/geoserver/geoserver/pull/2856#issuecomment-385170063","issue_url":"https://api.github.com/repos/geoserver/geoserver/issues/2856","id":385170063,"user":{"login":"bencaradocdavies","id":1900866,"avatar_url":"https://avatars3.githubusercontent.com/u/1900866?v=4","gravatar_id":"","url":"https://api.github.com/users/bencaradocdavies","html_url":"https://github.com/bencaradocdavies","followers_url":"https://api.github.com/users/bencaradocdavies/followers","following_url":"https://api.github.com/users/bencaradocdavies/following{/other_user}","gists_url":"https://api.github.com/users/bencaradocdavies/gists{/gist_id}","starred_url":"https://api.github.com/users/bencaradocdavies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bencaradocdavies/subscriptions","organizations_url":"https://api.github.com/users/bencaradocdavies/orgs","repos_url":"https://api.github.com/users/bencaradocdavies/repos","events_url":"https://api.github.com/users/bencaradocdavies/events{/privacy}","received_events_url":"https://api.github.com/users/bencaradocdavies/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T12:04:39Z","updated_at":"2018-04-28T12:04:39Z","author_association":"OWNER","body":"No problem @pvalsecc. Thank you for the fix. Note that changing the title at this stage has no effect on the git repo as the PR is already merged. Nonetheless, thanks.\r\n\r\nThe geofence plugins are \"community\" plugins which means we do not run their unit tests and do not include them in releases, only nightly builds. Plugins that have a maintainer and meet minimum quality criteria can get promoted to to \"extension\" status, which means unit tests and Travis CI coverage that would hopefully prevent the regression you fixed."}}
|
{
"id": 2751199,
"name": "geoserver/geoserver",
"url": "https://api.github.com/repos/geoserver/geoserver"
}
|
{
"id": 1900866,
"login": "bencaradocdavies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1900866?",
"url": "https://api.github.com/users/bencaradocdavies"
}
|
{
"id": 186522,
"login": "geoserver",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/186522?",
"url": "https://api.github.com/orgs/geoserver"
}
| 2018-04-28T12:04:39 |
7601309597
|
{"actor":{"display_login":"bencaradocdavies"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/14428","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/14428/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/14428/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/14428/events","html_url":"https://github.com/xbmc/xbmc/pull/14428","id":359747181,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTY3OTc1","number":14428,"title":"AEBitstreamPacker: Differentiate between DTS-HD-MA and DTS-HD-HR","user":{"login":"fritsch","id":1089309,"node_id":"MDQ6VXNlcjEwODkzMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1089309?v=4","gravatar_id":"","url":"https://api.github.com/users/fritsch","html_url":"https://github.com/fritsch","followers_url":"https://api.github.com/users/fritsch/followers","following_url":"https://api.github.com/users/fritsch/following{/other_user}","gists_url":"https://api.github.com/users/fritsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fritsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritsch/subscriptions","organizations_url":"https://api.github.com/users/fritsch/orgs","repos_url":"https://api.github.com/users/fritsch/repos","events_url":"https://api.github.com/users/fritsch/events{/privacy}","received_events_url":"https://api.github.com/users/fritsch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-09-13T05:25:29Z","updated_at":"2018-09-13T08:13:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/14428","html_url":"https://github.com/xbmc/xbmc/pull/14428","diff_url":"https://github.com/xbmc/xbmc/pull/14428.diff","patch_url":"https://github.com/xbmc/xbmc/pull/14428.patch"},"body":"Recent AVRs produce crackling and noise when DTS-HD-HR is sent via 8 channels / 192 khz. A solution investigated and found by the colleagues of lavfilters is to transmit this content via 192 khz / 2 channels.\r\n\r\nThe core part of this solution was implemented by the OSMC team. I adapted it and tried to keep ownership as the original commit was only in patchform.\r\n\r\nSuccesfully tested on:\r\n- ALSA\r\n- Audiotrack (Nvidia Shield)"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/420922420","html_url":"https://github.com/xbmc/xbmc/pull/14428#issuecomment-420922420","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/14428","id":420922420,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDkyMjQyMA==","user":{"login":"afedchin","id":2063885,"node_id":"MDQ6VXNlcjIwNjM4ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/2063885?v=4","gravatar_id":"","url":"https://api.github.com/users/afedchin","html_url":"https://github.com/afedchin","followers_url":"https://api.github.com/users/afedchin/followers","following_url":"https://api.github.com/users/afedchin/following{/other_user}","gists_url":"https://api.github.com/users/afedchin/gists{/gist_id}","starred_url":"https://api.github.com/users/afedchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afedchin/subscriptions","organizations_url":"https://api.github.com/users/afedchin/orgs","repos_url":"https://api.github.com/users/afedchin/repos","events_url":"https://api.github.com/users/afedchin/events{/privacy}","received_events_url":"https://api.github.com/users/afedchin/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T08:13:37Z","updated_at":"2018-09-13T08:13:37Z","author_association":"MEMBER","body":"> @afedchin should I remove the XAudio changes or keep them?\r\n\r\nkeep them, mb someday MS will allow PT on xbox ^^"}}
|
{
"id": 1217614,
"name": "xbmc/xbmc",
"url": "https://api.github.com/repos/xbmc/xbmc"
}
|
{
"id": 2063885,
"login": "afedchin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2063885?",
"url": "https://api.github.com/users/afedchin"
}
|
{
"id": 199122,
"login": "xbmc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/199122?",
"url": "https://api.github.com/orgs/xbmc"
}
| 2018-09-13T08:13:37 |
8258124126
|
{"actor":{"display_login":"afedchin"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/repo-scripts/issues/867","repository_url":"https://api.github.com/repos/xbmc/repo-scripts","labels_url":"https://api.github.com/repos/xbmc/repo-scripts/issues/867/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/repo-scripts/issues/867/comments","events_url":"https://api.github.com/repos/xbmc/repo-scripts/issues/867/events","html_url":"https://github.com/xbmc/repo-scripts/pull/867","id":340719211,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDY0Mjk0","number":867,"title":"[script.module.pyserial] 3.4.0","user":{"login":"fredrik-eriksson","id":580318,"node_id":"MDQ6VXNlcjU4MDMxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/580318?v=4","gravatar_id":"","url":"https://api.github.com/users/fredrik-eriksson","html_url":"https://github.com/fredrik-eriksson","followers_url":"https://api.github.com/users/fredrik-eriksson/followers","following_url":"https://api.github.com/users/fredrik-eriksson/following{/other_user}","gists_url":"https://api.github.com/users/fredrik-eriksson/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrik-eriksson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrik-eriksson/subscriptions","organizations_url":"https://api.github.com/users/fredrik-eriksson/orgs","repos_url":"https://api.github.com/users/fredrik-eriksson/repos","events_url":"https://api.github.com/users/fredrik-eriksson/events{/privacy}","received_events_url":"https://api.github.com/users/fredrik-eriksson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-12T16:54:13Z","updated_at":"2018-07-18T16:31:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/xbmc/repo-scripts/pulls/867","html_url":"https://github.com/xbmc/repo-scripts/pull/867","diff_url":"https://github.com/xbmc/repo-scripts/pull/867.diff","patch_url":"https://github.com/xbmc/repo-scripts/pull/867.patch"},"body":"### Description\r\nThe pyserial python module packaged for kodi. This package will be required for my projcontrol service addon.\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the [add-on rules](http://kodi.wiki/view/Add-on_rules) and [piracy stance](http://kodi.wiki/view/Official:Forum_rules#Piracy_Policy) of this project. \r\n- [X] I have read the [CONTRIBUTING](https://github.com/xbmc/repo-scripts/blob/master/CONTRIBUTING.md) document\r\n- [X] Each add-on submission should be a single commit with using the following style: [script.foo.bar] v1.0.0\r\n\r\nAdditional information :\r\n- Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.\r\n- [add-on development](http://kodi.wiki/view/Add-on_development) wiki page.\r\n- Kodi [pydocs](http://kodi.wiki/view/PyDocs) provide information about the Python API\r\n- [PEP8](https://www.python.org/dev/peps/pep-0008/) codingstyle which is considered best practise but not mandatory.\r\n- This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at [Codacy](https://www.codacy.com/app/Kodi/repo-scripts/dashboard). You can create your own account as well to continuously monitor your python coding before submitting to repo.\r\n- Development questions can be asked in the [add-on development](http://forum.kodi.tv/forumdisplay.php?fid=26) section on the Kodi forum.\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/repo-scripts/issues/comments/405994008","html_url":"https://github.com/xbmc/repo-scripts/pull/867#issuecomment-405994008","issue_url":"https://api.github.com/repos/xbmc/repo-scripts/issues/867","id":405994008,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTk5NDAwOA==","user":{"login":"TravisBuddy","id":33237381,"node_id":"MDQ6VXNlcjMzMjM3Mzgx","avatar_url":"https://avatars0.githubusercontent.com/u/33237381?v=4","gravatar_id":"","url":"https://api.github.com/users/TravisBuddy","html_url":"https://github.com/TravisBuddy","followers_url":"https://api.github.com/users/TravisBuddy/followers","following_url":"https://api.github.com/users/TravisBuddy/following{/other_user}","gists_url":"https://api.github.com/users/TravisBuddy/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisBuddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisBuddy/subscriptions","organizations_url":"https://api.github.com/users/TravisBuddy/orgs","repos_url":"https://api.github.com/users/TravisBuddy/repos","events_url":"https://api.github.com/users/TravisBuddy/events{/privacy}","received_events_url":"https://api.github.com/users/TravisBuddy/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T16:31:44Z","updated_at":"2018-07-18T16:31:44Z","author_association":"NONE","body":"## Travis Buddy\nHey **Fredrik Eriksson**, \nwe found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.\n\n"}}
|
{
"id": 25119390,
"name": "xbmc/repo-scripts",
"url": "https://api.github.com/repos/xbmc/repo-scripts"
}
|
{
"id": 33237381,
"login": "TravisBuddy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33237381?",
"url": "https://api.github.com/users/TravisBuddy"
}
|
{
"id": 199122,
"login": "xbmc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/199122?",
"url": "https://api.github.com/orgs/xbmc"
}
| 2018-07-18T16:31:44 |
7984109282
|
{"actor":{"display_login":"TravisBuddy"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/neo4j/neo4j/issues/9541","repository_url":"https://api.github.com/repos/neo4j/neo4j","labels_url":"https://api.github.com/repos/neo4j/neo4j/issues/9541/labels{/name}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/9541/comments","events_url":"https://api.github.com/repos/neo4j/neo4j/issues/9541/events","html_url":"https://github.com/neo4j/neo4j/issues/9541","id":237245162,"node_id":"MDU6SXNzdWUyMzcyNDUxNjI=","number":9541,"title":"TransactionAccessedConcurrently Exception on some nodes after the server throws a Java concurrent timeout exception","user":{"login":"jschmidtWK","id":25074666,"node_id":"MDQ6VXNlcjI1MDc0NjY2","avatar_url":"https://avatars1.githubusercontent.com/u/25074666?v=4","gravatar_id":"","url":"https://api.github.com/users/jschmidtWK","html_url":"https://github.com/jschmidtWK","followers_url":"https://api.github.com/users/jschmidtWK/followers","following_url":"https://api.github.com/users/jschmidtWK/following{/other_user}","gists_url":"https://api.github.com/users/jschmidtWK/gists{/gist_id}","starred_url":"https://api.github.com/users/jschmidtWK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschmidtWK/subscriptions","organizations_url":"https://api.github.com/users/jschmidtWK/orgs","repos_url":"https://api.github.com/users/jschmidtWK/repos","events_url":"https://api.github.com/users/jschmidtWK/events{/privacy}","received_events_url":"https://api.github.com/users/jschmidtWK/received_events","type":"User","site_admin":false},"labels":[{"id":647068027,"node_id":"MDU6TGFiZWw2NDcwNjgwMjc=","url":"https://api.github.com/repos/neo4j/neo4j/labels/team-drivers","name":"team-drivers","color":"cc0044","default":false}],"state":"open","locked":false,"assignee":{"login":"zhenlineo","id":4190164,"node_id":"MDQ6VXNlcjQxOTAxNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4190164?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenlineo","html_url":"https://github.com/zhenlineo","followers_url":"https://api.github.com/users/zhenlineo/followers","following_url":"https://api.github.com/users/zhenlineo/following{/other_user}","gists_url":"https://api.github.com/users/zhenlineo/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenlineo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenlineo/subscriptions","organizations_url":"https://api.github.com/users/zhenlineo/orgs","repos_url":"https://api.github.com/users/zhenlineo/repos","events_url":"https://api.github.com/users/zhenlineo/events{/privacy}","received_events_url":"https://api.github.com/users/zhenlineo/received_events","type":"User","site_admin":false},"assignees":[{"login":"zhenlineo","id":4190164,"node_id":"MDQ6VXNlcjQxOTAxNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4190164?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenlineo","html_url":"https://github.com/zhenlineo","followers_url":"https://api.github.com/users/zhenlineo/followers","following_url":"https://api.github.com/users/zhenlineo/following{/other_user}","gists_url":"https://api.github.com/users/zhenlineo/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenlineo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenlineo/subscriptions","organizations_url":"https://api.github.com/users/zhenlineo/orgs","repos_url":"https://api.github.com/users/zhenlineo/repos","events_url":"https://api.github.com/users/zhenlineo/events{/privacy}","received_events_url":"https://api.github.com/users/zhenlineo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-06-20T15:08:09Z","updated_at":"2018-12-03T11:11:16Z","closed_at":null,"author_association":"NONE","body":"During use of a Neo4J HA Cluster, the cluster will sometime throw a Java java.util.concurrent.TimeoutException when handling a Transaction. After this, the nodes locked during this particular transaction are in an abnormal state and will throw a Neo.ClientError.Transaction.TransactionAccessedConcurrently Exception when subsequently updated with a query like `MATCH (record:Label) WHERE (record.Id = {p0}) SET record += {updatedRecord}`. The blocking transaction will never expire and keep throwing exceptions, even by new clients or new instances of the app connecting to the cluster.\r\n\r\nHowever, on the same blocked node, a query like `MATCH (node:Label) WHERE (node.Id = {p0}) SET node._WriteLock = 1`, followed by `MATCH (node:Label) WHERE (node.Id = {p0}) SET node._WriteLock = 0` will execute successfully, as will any pure MATCH-RETURN reading queries.\r\n\r\nRestarting the master to force a master re-election solves the problem until the next java.util.concurrent.TimeoutException is thrown.\r\n\r\nThe problem happens randomly, about once every 36 hours, sometimes less than 12 hours of uptime of a particular master. This cluster is under a fairly constant load of 10-100 reads and/or writes per second. So far, issues have been happening regardless of current I/O load on the cluster.\r\n\r\nThis cluster has been operating under this average load for more than a year, the incident began to appear about five days ago.\r\n\r\n**Neo4j Version:** 3.0.0 \r\n**Operating System:** Ubuntu 14.04.4 \r\n**API:** C# Community Driver\r\n\r\nJava stacktrace for java.util.concurrent.TimeoutException :\r\n\r\n`2017-06-20 12:32:07.742+0000 WARN /db/data/transaction/2552350 java.io.IOException: java.util.concurrent.TimeoutException: Idle timeout expired: 30001/30000 ms\r\njava.lang.RuntimeException: java.io.IOException: java.util.concurrent.TimeoutException: Idle timeout expired: 30001/30000 ms\r\n at org.neo4j.server.rest.transactional.StatementDeserializer.<init>(StatementDeserializer.java:77)\r\n at org.neo4j.server.rest.transactional.TransactionFacade.deserializer(TransactionFacade.java:86)\r\n at org.neo4j.server.rest.web.TransactionalService.lambda$executeStatements$28(TransactionalService.java:190)\r\n at com.sun.jersey.core.impl.provider.entity.StreamingOutputProvider.writeTo(StreamingOutputProvider.java:71)\r\n at com.sun.jersey.core.impl.provider.entity.StreamingOutputProvider.writeTo(StreamingOutputProvider.java:57)\r\n at com.sun.jersey.spi.container.ContainerResponse.write(ContainerResponse.java:302)\r\n at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1510)\r\n at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)\r\n at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)\r\n at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)\r\n at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)\r\n at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)\r\n at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)\r\n at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:808)\r\n at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)\r\n at org.neo4j.server.rest.dbms.AuthorizationFilter.doFilter(AuthorizationFilter.java:121)\r\n at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)\r\n at org.neo4j.server.rest.web.CollectUserAgentFilter.doFilter(CollectUserAgentFilter.java:69)\r\n at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)\r\n at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)\r\n at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:221)\r\n at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)\r\n at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)\r\n at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)\r\n at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)\r\n at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)\r\n at org.eclipse.jetty.server.handler.HandlerList.handle(HandlerList.java:52)\r\n at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)\r\n at org.eclipse.jetty.server.Server.handle(Server.java:497)\r\n at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)\r\n at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)\r\n at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)\r\n at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)\r\n at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)\r\n at java.lang.Thread.run(Thread.java:745)\r\nCaused by: java.io.IOException: java.util.concurrent.TimeoutException: Idle timeout expired: 30001/30000 ms\r\n at org.eclipse.jetty.util.SharedBlockingCallback$Blocker.block(SharedBlockingCallback.java:234)\r\n at org.eclipse.jetty.server.HttpInputOverHTTP.blockForContent(HttpInputOverHTTP.java:66)\r\n at org.eclipse.jetty.server.HttpInput$1.waitForContent(HttpInput.java:475)\r\n at org.eclipse.jetty.server.HttpInput.read(HttpInput.java:121)\r\n at org.codehaus.jackson.impl.ByteSourceBootstrapper.ensureLoaded(ByteSourceBootstrapper.java:507)\r\n at org.codehaus.jackson.impl.ByteSourceBootstrapper.detectEncoding(ByteSourceBootstrapper.java:129)\r\n at org.codehaus.jackson.impl.ByteSourceBootstrapper.constructParser(ByteSourceBootstrapper.java:224)\r\n at org.codehaus.jackson.JsonFactory._createJsonParser(JsonFactory.java:785)\r\n at org.codehaus.jackson.JsonFactory.createJsonParser(JsonFactory.java:561)\r\n at org.neo4j.server.rest.transactional.StatementDeserializer.<init>(StatementDeserializer.java:72)\r\n ... 34 more\r\nCaused by: java.util.concurrent.TimeoutException: Idle timeout expired: 30001/30000 ms\r\n at org.eclipse.jetty.io.IdleTimeout.checkIdleTimeout(IdleTimeout.java:161)\r\n at org.eclipse.jetty.io.IdleTimeout$1.run(IdleTimeout.java:50)\r\n at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)\r\n at java.util.concurrent.FutureTask.run(FutureTask.java:266)\r\n at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)\r\n at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)\r\n at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\r\n at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\r\n ... 1 more`"},"comment":{"url":"https://api.github.com/repos/neo4j/neo4j/issues/comments/443673865","html_url":"https://github.com/neo4j/neo4j/issues/9541#issuecomment-443673865","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/9541","id":443673865,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzY3Mzg2NQ==","user":{"login":"jschmidtWK","id":25074666,"node_id":"MDQ6VXNlcjI1MDc0NjY2","avatar_url":"https://avatars1.githubusercontent.com/u/25074666?v=4","gravatar_id":"","url":"https://api.github.com/users/jschmidtWK","html_url":"https://github.com/jschmidtWK","followers_url":"https://api.github.com/users/jschmidtWK/followers","following_url":"https://api.github.com/users/jschmidtWK/following{/other_user}","gists_url":"https://api.github.com/users/jschmidtWK/gists{/gist_id}","starred_url":"https://api.github.com/users/jschmidtWK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschmidtWK/subscriptions","organizations_url":"https://api.github.com/users/jschmidtWK/orgs","repos_url":"https://api.github.com/users/jschmidtWK/repos","events_url":"https://api.github.com/users/jschmidtWK/events{/privacy}","received_events_url":"https://api.github.com/users/jschmidtWK/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T11:11:16Z","updated_at":"2018-12-03T11:11:16Z","author_association":"NONE","body":"Hi Zhen,\r\nWe are using the Neo4J community client (https://github.com/Readify/Neo4jClient/) which, AFAIK, targets the transaction endpoint.\r\n\r\nUnder normal circumstances, no transaction is left open, they are either committed or rolled-back.\r\n\r\nI've only seen this error on an HA cluster, never on a standalone server.\r\n\r\nBest Regards,\r\nJonathan"}}
|
{
"id": 6650539,
"name": "neo4j/neo4j",
"url": "https://api.github.com/repos/neo4j/neo4j"
}
|
{
"id": 25074666,
"login": "jschmidtWK",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25074666?",
"url": "https://api.github.com/users/jschmidtWK"
}
|
{
"id": 201120,
"login": "neo4j",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/201120?",
"url": "https://api.github.com/orgs/neo4j"
}
| 2018-12-03T11:11:16 |
8686570252
|
{"actor":{"display_login":"jschmidtWK"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/ruby-no-kai/official/issues/302","repository_url":"https://api.github.com/repos/ruby-no-kai/official","labels_url":"https://api.github.com/repos/ruby-no-kai/official/issues/302/labels{/name}","comments_url":"https://api.github.com/repos/ruby-no-kai/official/issues/302/comments","events_url":"https://api.github.com/repos/ruby-no-kai/official/issues/302/events","html_url":"https://github.com/ruby-no-kai/official/issues/302","id":289513750,"number":302,"title":"Ruby25イベント：ポスター参加","user":{"login":"takahashim","id":10401,"avatar_url":"https://avatars2.githubusercontent.com/u/10401?v=4","gravatar_id":"","url":"https://api.github.com/users/takahashim","html_url":"https://github.com/takahashim","followers_url":"https://api.github.com/users/takahashim/followers","following_url":"https://api.github.com/users/takahashim/following{/other_user}","gists_url":"https://api.github.com/users/takahashim/gists{/gist_id}","starred_url":"https://api.github.com/users/takahashim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahashim/subscriptions","organizations_url":"https://api.github.com/users/takahashim/orgs","repos_url":"https://api.github.com/users/takahashim/repos","events_url":"https://api.github.com/users/takahashim/events{/privacy}","received_events_url":"https://api.github.com/users/takahashim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-01-18T05:59:07Z","updated_at":"2018-02-01T10:51:18Z","closed_at":null,"author_association":"OWNER","body":"http://25.ruby.or.jp/posters.html の件です。\r\nRubyの会の活動についてもポスターがあるとよさそうです。締切は2/4。"},"comment":{"url":"https://api.github.com/repos/ruby-no-kai/official/issues/comments/362229741","html_url":"https://github.com/ruby-no-kai/official/issues/302#issuecomment-362229741","issue_url":"https://api.github.com/repos/ruby-no-kai/official/issues/302","id":362229741,"user":{"login":"kakutani","id":2160,"avatar_url":"https://avatars1.githubusercontent.com/u/2160?v=4","gravatar_id":"","url":"https://api.github.com/users/kakutani","html_url":"https://github.com/kakutani","followers_url":"https://api.github.com/users/kakutani/followers","following_url":"https://api.github.com/users/kakutani/following{/other_user}","gists_url":"https://api.github.com/users/kakutani/gists{/gist_id}","starred_url":"https://api.github.com/users/kakutani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakutani/subscriptions","organizations_url":"https://api.github.com/users/kakutani/orgs","repos_url":"https://api.github.com/users/kakutani/repos","events_url":"https://api.github.com/users/kakutani/events{/privacy}","received_events_url":"https://api.github.com/users/kakutani/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T10:51:18Z","updated_at":"2018-02-01T10:51:18Z","author_association":"OWNER","body":"📝 インターシティにキンコーズがある http://www.kinkos.co.jp/store/t029.html"}}
|
{
"id": 2104233,
"name": "ruby-no-kai/official",
"url": "https://api.github.com/repos/ruby-no-kai/official"
}
|
{
"id": 2160,
"login": "kakutani",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2160?",
"url": "https://api.github.com/users/kakutani"
}
|
{
"id": 207834,
"login": "ruby-no-kai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/207834?",
"url": "https://api.github.com/orgs/ruby-no-kai"
}
| 2018-02-01T10:51:18 |
7182749489
|
{"actor":{"display_login":"kakutani"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/doctrine/doctrine2/issues/7259","repository_url":"https://api.github.com/repos/doctrine/doctrine2","labels_url":"https://api.github.com/repos/doctrine/doctrine2/issues/7259/labels{/name}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/issues/7259/comments","events_url":"https://api.github.com/repos/doctrine/doctrine2/issues/7259/events","html_url":"https://github.com/doctrine/doctrine2/issues/7259","id":332719450,"node_id":"MDU6SXNzdWUzMzI3MTk0NTA=","number":7259,"title":"Broken commit order in 2.6","user":{"login":"stof","id":439401,"node_id":"MDQ6VXNlcjQzOTQwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/439401?v=4","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"labels":[{"id":296201252,"node_id":"MDU6TGFiZWwyOTYyMDEyNTI=","url":"https://api.github.com/repos/doctrine/doctrine2/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":169872368,"node_id":"MDU6TGFiZWwxNjk4NzIzNjg=","url":"https://api.github.com/repos/doctrine/doctrine2/labels/Failing%20Test","name":"Failing Test","color":"eb6420","default":false}],"state":"closed","locked":false,"assignee":{"login":"guilhermeblanco","id":208883,"node_id":"MDQ6VXNlcjIwODg4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/208883?v=4","gravatar_id":"","url":"https://api.github.com/users/guilhermeblanco","html_url":"https://github.com/guilhermeblanco","followers_url":"https://api.github.com/users/guilhermeblanco/followers","following_url":"https://api.github.com/users/guilhermeblanco/following{/other_user}","gists_url":"https://api.github.com/users/guilhermeblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhermeblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhermeblanco/subscriptions","organizations_url":"https://api.github.com/users/guilhermeblanco/orgs","repos_url":"https://api.github.com/users/guilhermeblanco/repos","events_url":"https://api.github.com/users/guilhermeblanco/events{/privacy}","received_events_url":"https://api.github.com/users/guilhermeblanco/received_events","type":"User","site_admin":false},"assignees":[{"login":"guilhermeblanco","id":208883,"node_id":"MDQ6VXNlcjIwODg4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/208883?v=4","gravatar_id":"","url":"https://api.github.com/users/guilhermeblanco","html_url":"https://github.com/guilhermeblanco","followers_url":"https://api.github.com/users/guilhermeblanco/followers","following_url":"https://api.github.com/users/guilhermeblanco/following{/other_user}","gists_url":"https://api.github.com/users/guilhermeblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/guilhermeblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guilhermeblanco/subscriptions","organizations_url":"https://api.github.com/users/guilhermeblanco/orgs","repos_url":"https://api.github.com/users/guilhermeblanco/repos","events_url":"https://api.github.com/users/guilhermeblanco/events{/privacy}","received_events_url":"https://api.github.com/users/guilhermeblanco/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/doctrine/doctrine2/milestones/71","html_url":"https://github.com/doctrine/doctrine2/milestone/71","labels_url":"https://api.github.com/repos/doctrine/doctrine2/milestones/71/labels","id":3508699,"node_id":"MDk6TWlsZXN0b25lMzUwODY5OQ==","number":71,"title":"2.6.3","description":null,"creator":{"login":"Ocramius","id":154256,"node_id":"MDQ6VXNlcjE1NDI1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":10,"state":"open","created_at":"2018-07-19T09:52:40Z","updated_at":"2018-09-23T04:02:17Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-06-15T10:12:28Z","updated_at":"2018-09-23T04:02:17Z","closed_at":"2018-09-23T04:02:17Z","author_association":"MEMBER","body":"### BC Break Report\r\n\r\n\r\n| Q | A\r\n|------------ | ------\r\n| BC Break | yes\r\n| Version | 2.6\r\n\r\n#### Summary\r\n\r\nCommit order is wrong in some cases, leading to broken inserts (inserting without the id for the foreign key). this is dependant on the order of `persist()` calls.\r\n\r\n#### Previous behavior\r\n\r\nFlushing was working fine\r\n\r\n#### Current behavior\r\n\r\nFlush is failing by trying to insert `NULL` in a non-nullable foreign key (probably planning to update the field later).\r\n\r\n#### How to reproduce\r\n\r\nSee #7260 which provides some tests reproducing the issue.\r\n"},"comment":{"url":"https://api.github.com/repos/doctrine/doctrine2/issues/comments/423790225","html_url":"https://github.com/doctrine/doctrine2/issues/7259#issuecomment-423790225","issue_url":"https://api.github.com/repos/doctrine/doctrine2/issues/7259","id":423790225,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzc5MDIyNQ==","user":{"login":"Majkl578","id":144181,"node_id":"MDQ6VXNlcjE0NDE4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/144181?v=4","gravatar_id":"","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"created_at":"2018-09-23T04:02:17Z","updated_at":"2018-09-23T04:02:17Z","author_association":"MEMBER","body":"Fixed in #7260."}}
|
{
"id": 597887,
"name": "doctrine/doctrine2",
"url": "https://api.github.com/repos/doctrine/doctrine2"
}
|
{
"id": 144181,
"login": "Majkl578",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/144181?",
"url": "https://api.github.com/users/Majkl578"
}
|
{
"id": 209254,
"login": "doctrine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/209254?",
"url": "https://api.github.com/orgs/doctrine"
}
| 2018-09-23T04:02:17 |
8307096396
|
{"actor":{"display_login":"Majkl578"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1887","repository_url":"https://api.github.com/repos/doctrine/mongodb-odm","labels_url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1887/labels{/name}","comments_url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1887/comments","events_url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1887/events","html_url":"https://github.com/doctrine/mongodb-odm/pull/1887","id":375631702,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDMyOTk4","number":1887,"title":"Exception when persisting class unlisted in disciminator map (Issue 867)","user":{"login":"watari","id":35221762,"node_id":"MDQ6VXNlcjM1MjIxNzYy","avatar_url":"https://avatars0.githubusercontent.com/u/35221762?v=4","gravatar_id":"","url":"https://api.github.com/users/watari","html_url":"https://github.com/watari","followers_url":"https://api.github.com/users/watari/followers","following_url":"https://api.github.com/users/watari/following{/other_user}","gists_url":"https://api.github.com/users/watari/gists{/gist_id}","starred_url":"https://api.github.com/users/watari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watari/subscriptions","organizations_url":"https://api.github.com/users/watari/orgs","repos_url":"https://api.github.com/users/watari/repos","events_url":"https://api.github.com/users/watari/events{/privacy}","received_events_url":"https://api.github.com/users/watari/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-30T18:25:24Z","updated_at":"2018-11-09T06:07:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/doctrine/mongodb-odm/pulls/1887","html_url":"https://github.com/doctrine/mongodb-odm/pull/1887","diff_url":"https://github.com/doctrine/mongodb-odm/pull/1887.diff","patch_url":"https://github.com/doctrine/mongodb-odm/pull/1887.patch"},"body":"\r\n<!-- Fill in the relevant information below to help triage your pull request. -->\r\n\r\n| Q | A\r\n|------------- | -----------\r\n| Type | feature/improvement\r\n| BC Break | yes\r\n| Fixed issues | https://github.com/doctrine/mongodb-odm/issues/867\r\n\r\n#### Summary\r\nUpdated persisting logic to throw exception of class is not listed in discriminator map.\r\n\r\nThere is no new tests is added since library have a set of old tests that is cover most of the cases.\r\n\r\nRight now exception message contain information only about unlisted class without parent class since in the places of the checks I don't find a way of extracting parent class info.\r\n"},"comment":{"url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/comments/437260305","html_url":"https://github.com/doctrine/mongodb-odm/pull/1887#issuecomment-437260305","issue_url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1887","id":437260305,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzI2MDMwNQ==","user":{"login":"watari","id":35221762,"node_id":"MDQ6VXNlcjM1MjIxNzYy","avatar_url":"https://avatars0.githubusercontent.com/u/35221762?v=4","gravatar_id":"","url":"https://api.github.com/users/watari","html_url":"https://github.com/watari","followers_url":"https://api.github.com/users/watari/followers","following_url":"https://api.github.com/users/watari/following{/other_user}","gists_url":"https://api.github.com/users/watari/gists{/gist_id}","starred_url":"https://api.github.com/users/watari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watari/subscriptions","organizations_url":"https://api.github.com/users/watari/orgs","repos_url":"https://api.github.com/users/watari/repos","events_url":"https://api.github.com/users/watari/events{/privacy}","received_events_url":"https://api.github.com/users/watari/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T06:07:03Z","updated_at":"2018-11-09T06:07:03Z","author_association":"CONTRIBUTOR","body":"@malarzm , it was not so hard revert partially changes and introduce only exception in this PR). Also I updated PR description. Can you, please, check all again?"}}
|
{
"id": 677781,
"name": "doctrine/mongodb-odm",
"url": "https://api.github.com/repos/doctrine/mongodb-odm"
}
|
{
"id": 35221762,
"login": "watari",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35221762?",
"url": "https://api.github.com/users/watari"
}
|
{
"id": 209254,
"login": "doctrine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/209254?",
"url": "https://api.github.com/orgs/doctrine"
}
| 2018-11-09T06:07:03 |
8561285291
|
{"actor":{"display_login":"watari"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7341","repository_url":"https://api.github.com/repos/matplotlib/matplotlib","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7341/labels{/name}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7341/comments","events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7341/events","html_url":"https://github.com/matplotlib/matplotlib/issues/7341","id":184969521,"number":7341,"title":"slightly imprecise tick positioning","user":{"login":"anntzer","id":1322974,"avatar_url":"https://avatars0.githubusercontent.com/u/1322974?v=4","gravatar_id":"","url":"https://api.github.com/users/anntzer","html_url":"https://github.com/anntzer","followers_url":"https://api.github.com/users/anntzer/followers","following_url":"https://api.github.com/users/anntzer/following{/other_user}","gists_url":"https://api.github.com/users/anntzer/gists{/gist_id}","starred_url":"https://api.github.com/users/anntzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anntzer/subscriptions","organizations_url":"https://api.github.com/users/anntzer/orgs","repos_url":"https://api.github.com/users/anntzer/repos","events_url":"https://api.github.com/users/anntzer/events{/privacy}","received_events_url":"https://api.github.com/users/anntzer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/25","html_url":"https://github.com/matplotlib/matplotlib/milestone/25","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/25/labels","id":2189521,"number":25,"title":"needs sorting","description":"Milestone that was used for working towards v2.2.\r\n\r\nThese issues need to be sorted between v3.0 (new features, non-critical bug fis), v2.2.1 (regressions and critical bug fixes), v2.2-doc (prose and example changes only).","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":732,"closed_issues":7,"state":"open","created_at":"2016-12-11T20:54:18Z","updated_at":"2018-03-28T23:41:47Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2016-10-24T22:17:22Z","updated_at":"2018-03-29T01:08:09Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"```\nplt.gca().set(xlim=(1e-2, 50), ylim=(3e-3, 1), aspect=1, xscale=\"log\", yscale=\"log\", xlabel=\"foo\", ylabel=\"bar\")\ntight_layout(rect=(0, 0, .85, 1))\n```\n\nsave as png.\n\n2.0b4:\n\nAll the y ticks overlap with the spine, and one at the very bottom seems misaligned.\nThe leftmost and rightmost x ticks seem misaligned.\n\nmaster:\n\nThe y tick at the very bottom and the rightmost x tick seem misaligned.\n"},"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/377088227","html_url":"https://github.com/matplotlib/matplotlib/issues/7341#issuecomment-377088227","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7341","id":377088227,"user":{"login":"ImportanceOfBeingErnest","id":23121882,"avatar_url":"https://avatars2.githubusercontent.com/u/23121882?v=4","gravatar_id":"","url":"https://api.github.com/users/ImportanceOfBeingErnest","html_url":"https://github.com/ImportanceOfBeingErnest","followers_url":"https://api.github.com/users/ImportanceOfBeingErnest/followers","following_url":"https://api.github.com/users/ImportanceOfBeingErnest/following{/other_user}","gists_url":"https://api.github.com/users/ImportanceOfBeingErnest/gists{/gist_id}","starred_url":"https://api.github.com/users/ImportanceOfBeingErnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImportanceOfBeingErnest/subscriptions","organizations_url":"https://api.github.com/users/ImportanceOfBeingErnest/orgs","repos_url":"https://api.github.com/users/ImportanceOfBeingErnest/repos","events_url":"https://api.github.com/users/ImportanceOfBeingErnest/events{/privacy}","received_events_url":"https://api.github.com/users/ImportanceOfBeingErnest/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T01:08:09Z","updated_at":"2018-03-29T01:08:09Z","author_association":"CONTRIBUTOR","body":"I deliberately used the standard dpi here and as can be seen those plots do not look good on screen. \r\nAre you proposing that in order to get a 400 pixel wide figure one should first save with 300 dpi and than (externally to matplotlib) resize the figure from 1200 pixels back to 400? Or take a screenshot of a saved pdf file? "}}
|
{
"id": 1385122,
"name": "matplotlib/matplotlib",
"url": "https://api.github.com/repos/matplotlib/matplotlib"
}
|
{
"id": 23121882,
"login": "ImportanceOfBeingErnest",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23121882?",
"url": "https://api.github.com/users/ImportanceOfBeingErnest"
}
|
{
"id": 215947,
"login": "matplotlib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/215947?",
"url": "https://api.github.com/orgs/matplotlib"
}
| 2018-03-29T01:08:09 |
7451143840
|
{"actor":{"display_login":"ImportanceOfBeingErnest"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9528","repository_url":"https://api.github.com/repos/matplotlib/matplotlib","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9528/labels{/name}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9528/comments","events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9528/events","html_url":"https://github.com/matplotlib/matplotlib/pull/9528","id":267492146,"number":9528,"title":"MEP32: matplotlibrc/mplstyle with Python syntax.","user":{"login":"anntzer","id":1322974,"avatar_url":"https://avatars0.githubusercontent.com/u/1322974?v=4","gravatar_id":"","url":"https://api.github.com/users/anntzer","html_url":"https://github.com/anntzer","followers_url":"https://api.github.com/users/anntzer/followers","following_url":"https://api.github.com/users/anntzer/following{/other_user}","gists_url":"https://api.github.com/users/anntzer/gists{/gist_id}","starred_url":"https://api.github.com/users/anntzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anntzer/subscriptions","organizations_url":"https://api.github.com/users/anntzer/orgs","repos_url":"https://api.github.com/users/anntzer/repos","events_url":"https://api.github.com/users/anntzer/events{/privacy}","received_events_url":"https://api.github.com/users/anntzer/received_events","type":"User","site_admin":false},"labels":[{"id":126095603,"url":"https://api.github.com/repos/matplotlib/matplotlib/labels/rcparams","name":"rcparams","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/23","html_url":"https://github.com/matplotlib/matplotlib/milestone/23","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/23/labels","id":1542657,"number":23,"title":"v3.0","description":"Big ticket items:\r\n\r\n - drop support for python 2","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":160,"closed_issues":76,"state":"open","created_at":"2016-01-25T21:06:49Z","updated_at":"2018-03-08T14:37:45Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"comments":13,"created_at":"2017-10-22T19:35:58Z","updated_at":"2018-03-08T18:35:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/9528","html_url":"https://github.com/matplotlib/matplotlib/pull/9528","diff_url":"https://github.com/matplotlib/matplotlib/pull/9528.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/9528.patch"},"body":"See proposed MEP text in the PR. The rendered version is available by clicking on `view` at the top right of the \"files changed\" tab.\r\n\r\nI had this written for a while but was hoping to push this a bit later (I don't really have the time to work on it now). https://github.com/matplotlib/matplotlib/pull/6157#issuecomment-338501557 made me consider at least publishing my current thoughts.\r\n\r\nattn @matplotlib/developers "},"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/371580743","html_url":"https://github.com/matplotlib/matplotlib/pull/9528#issuecomment-371580743","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/9528","id":371580743,"user":{"login":"dopplershift","id":221526,"avatar_url":"https://avatars2.githubusercontent.com/u/221526?v=4","gravatar_id":"","url":"https://api.github.com/users/dopplershift","html_url":"https://github.com/dopplershift","followers_url":"https://api.github.com/users/dopplershift/followers","following_url":"https://api.github.com/users/dopplershift/following{/other_user}","gists_url":"https://api.github.com/users/dopplershift/gists{/gist_id}","starred_url":"https://api.github.com/users/dopplershift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopplershift/subscriptions","organizations_url":"https://api.github.com/users/dopplershift/orgs","repos_url":"https://api.github.com/users/dopplershift/repos","events_url":"https://api.github.com/users/dopplershift/events{/privacy}","received_events_url":"https://api.github.com/users/dopplershift/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T18:35:22Z","updated_at":"2018-03-08T18:35:22Z","author_association":"CONTRIBUTOR","body":"Given how it shows up in my conda updates, I think ruamel is used by conda for parsing its config.\r\n\r\nI agree some with @WeatherGod here--as a library, we need to tread differently than an application. In theory, the same level of permissions required to modify the config would be used to run the script (baring misconfiguration), so no security risk. On the other hand, we're literally talking about adding a hook to trigger arbitrary code execution, which screams out CVE to me (as irrational as that might be). (I think I've changed my feeling from in the past.)"}}
|
{
"id": 1385122,
"name": "matplotlib/matplotlib",
"url": "https://api.github.com/repos/matplotlib/matplotlib"
}
|
{
"id": 221526,
"login": "dopplershift",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/221526?",
"url": "https://api.github.com/users/dopplershift"
}
|
{
"id": 215947,
"login": "matplotlib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/215947?",
"url": "https://api.github.com/orgs/matplotlib"
}
| 2018-03-08T18:35:22 |
7351847418
|
{"actor":{"display_login":"dopplershift"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/12583","repository_url":"https://api.github.com/repos/matplotlib/matplotlib","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/12583/labels{/name}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/12583/comments","events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/12583/events","html_url":"https://github.com/matplotlib/matplotlib/pull/12583","id":372340685,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTU4MzE4","number":12583,"title":"Building docs has issues with ipython version 7.0.0. Created a condition in the docs-requirements.txt to not allow installing the specific version.","user":{"login":"Anirudhsekar96","id":20457332,"node_id":"MDQ6VXNlcjIwNDU3MzMy","avatar_url":"https://avatars0.githubusercontent.com/u/20457332?v=4","gravatar_id":"","url":"https://api.github.com/users/Anirudhsekar96","html_url":"https://github.com/Anirudhsekar96","followers_url":"https://api.github.com/users/Anirudhsekar96/followers","following_url":"https://api.github.com/users/Anirudhsekar96/following{/other_user}","gists_url":"https://api.github.com/users/Anirudhsekar96/gists{/gist_id}","starred_url":"https://api.github.com/users/Anirudhsekar96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anirudhsekar96/subscriptions","organizations_url":"https://api.github.com/users/Anirudhsekar96/orgs","repos_url":"https://api.github.com/users/Anirudhsekar96/repos","events_url":"https://api.github.com/users/Anirudhsekar96/events{/privacy}","received_events_url":"https://api.github.com/users/Anirudhsekar96/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/38","html_url":"https://github.com/matplotlib/matplotlib/milestone/38","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/38/labels","id":3663931,"node_id":"MDk6TWlsZXN0b25lMzY2MzkzMQ==","number":38,"title":"v3.0.0-doc","description":"Documentation branch for the 3.0.0 \r\n\r\non-merge: safe_backport to v3.0.x\r\n\r\non-merge: safe_backport to v3.0.0-doc","creator":{"login":"tacaswell","id":199813,"node_id":"MDQ6VXNlcjE5OTgxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":58,"state":"open","created_at":"2018-09-18T03:20:20Z","updated_at":"2018-10-22T12:45:20Z","due_on":null,"closed_at":null},"comments":16,"created_at":"2018-10-21T18:05:12Z","updated_at":"2018-10-22T19:30:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/12583","html_url":"https://github.com/matplotlib/matplotlib/pull/12583","diff_url":"https://github.com/matplotlib/matplotlib/pull/12583.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/12583.patch"},"body":"I have included a condition to not install ipython version 7.0.0 in the docs-requirement.txt file. This is because Ipython version 7.0.0 wasn't allowing the make html command to build the doc files.\r\n"},"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/431949892","html_url":"https://github.com/matplotlib/matplotlib/pull/12583#issuecomment-431949892","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/12583","id":431949892,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTk0OTg5Mg==","user":{"login":"tacaswell","id":199813,"node_id":"MDQ6VXNlcjE5OTgxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T19:30:25Z","updated_at":"2018-10-22T19:30:25Z","author_association":"MEMBER","body":"If this was an intentional change to IPython, lets try and fix the offending codeblock"}}
|
{
"id": 1385122,
"name": "matplotlib/matplotlib",
"url": "https://api.github.com/repos/matplotlib/matplotlib"
}
|
{
"id": 199813,
"login": "tacaswell",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/199813?",
"url": "https://api.github.com/users/tacaswell"
}
|
{
"id": 215947,
"login": "matplotlib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/215947?",
"url": "https://api.github.com/orgs/matplotlib"
}
| 2018-10-22T19:30:26 |
8460663183
|
{"actor":{"display_login":"tacaswell"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/863","repository_url":"https://api.github.com/repos/cosmos/cosmos-sdk","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/863/labels{/name}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/863/comments","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/863/events","html_url":"https://github.com/cosmos/cosmos-sdk/issues/863","id":314339443,"number":863,"title":"Netmon UI should allow to easily be run over HTTPS","user":{"login":"adrianbrink","id":11320251,"avatar_url":"https://avatars0.githubusercontent.com/u/11320251?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianbrink","html_url":"https://github.com/adrianbrink","followers_url":"https://api.github.com/users/adrianbrink/followers","following_url":"https://api.github.com/users/adrianbrink/following{/other_user}","gists_url":"https://api.github.com/users/adrianbrink/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianbrink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianbrink/subscriptions","organizations_url":"https://api.github.com/users/adrianbrink/orgs","repos_url":"https://api.github.com/users/adrianbrink/repos","events_url":"https://api.github.com/users/adrianbrink/events{/privacy}","received_events_url":"https://api.github.com/users/adrianbrink/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-14T15:53:21Z","updated_at":"2018-04-21T04:10:49Z","closed_at":"2018-04-21T04:10:49Z","author_association":"MEMBER","body":"@greg-szabo "},"comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments/383266248","html_url":"https://github.com/cosmos/cosmos-sdk/issues/863#issuecomment-383266248","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/863","id":383266248,"user":{"login":"ebuchman","id":2300911,"avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},"created_at":"2018-04-21T04:10:49Z","updated_at":"2018-04-21T04:10:49Z","author_association":"CONTRIBUTOR","body":"Thanks for the explanation Greg.\r\n\r\nI agree this is more of an ops concern. Also doesn't seem to belong in this repo."}}
|
{
"id": 51193526,
"name": "cosmos/cosmos-sdk",
"url": "https://api.github.com/repos/cosmos/cosmos-sdk"
}
|
{
"id": 2300911,
"login": "ebuchman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2300911?",
"url": "https://api.github.com/users/ebuchman"
}
|
{
"id": 228843,
"login": "cosmos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/228843?",
"url": "https://api.github.com/orgs/cosmos"
}
| 2018-04-21T04:10:49 |
7564998957
|
{"actor":{"display_login":"ebuchman"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/1222","repository_url":"https://api.github.com/repos/cosmos/cosmos-sdk","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/1222/labels{/name}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/1222/comments","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/1222/events","html_url":"https://github.com/cosmos/cosmos-sdk/issues/1222","id":331766415,"node_id":"MDU6SXNzdWUzMzE3NjY0MTU=","number":1222,"title":"Add MsgType in Context","user":{"login":"mossid","id":18329646,"node_id":"MDQ6VXNlcjE4MzI5NjQ2","avatar_url":"https://avatars0.githubusercontent.com/u/18329646?v=4","gravatar_id":"","url":"https://api.github.com/users/mossid","html_url":"https://github.com/mossid","followers_url":"https://api.github.com/users/mossid/followers","following_url":"https://api.github.com/users/mossid/following{/other_user}","gists_url":"https://api.github.com/users/mossid/gists{/gist_id}","starred_url":"https://api.github.com/users/mossid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossid/subscriptions","organizations_url":"https://api.github.com/users/mossid/orgs","repos_url":"https://api.github.com/users/mossid/repos","events_url":"https://api.github.com/users/mossid/events{/privacy}","received_events_url":"https://api.github.com/users/mossid/received_events","type":"User","site_admin":false},"labels":[{"id":908833716,"node_id":"MDU6TGFiZWw5MDg4MzM3MTY=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/prelaunch","name":"prelaunch","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-12T21:48:59Z","updated_at":"2018-06-13T01:13:28Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Add the following methods in sdk.Context\r\n\r\n```\r\nfunc (c Context) MsgType() string {}\r\nfunc (c Context) WithMsgType(ty string) Context {}\r\n```\r\n\r\nbaseapp will initialize MsgType to msg.Type() before it pass the msg to the router. It is useful to the modules that handle inter-module communication."},"comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments/396782471","html_url":"https://github.com/cosmos/cosmos-sdk/issues/1222#issuecomment-396782471","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/1222","id":396782471,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Njc4MjQ3MQ==","user":{"login":"mossid","id":18329646,"node_id":"MDQ6VXNlcjE4MzI5NjQ2","avatar_url":"https://avatars0.githubusercontent.com/u/18329646?v=4","gravatar_id":"","url":"https://api.github.com/users/mossid","html_url":"https://github.com/mossid","followers_url":"https://api.github.com/users/mossid/followers","following_url":"https://api.github.com/users/mossid/following{/other_user}","gists_url":"https://api.github.com/users/mossid/gists{/gist_id}","starred_url":"https://api.github.com/users/mossid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossid/subscriptions","organizations_url":"https://api.github.com/users/mossid/orgs","repos_url":"https://api.github.com/users/mossid/repos","events_url":"https://api.github.com/users/mossid/events{/privacy}","received_events_url":"https://api.github.com/users/mossid/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T01:13:28Z","updated_at":"2018-06-13T01:13:28Z","author_association":"CONTRIBUTOR","body":"For example, IBC module needs to check payload's validity. If a malicious module sends a `SendPayload`, which only bank module has authority to send, IBC module should panic. We can check it through whether the MsgType and the SendPayload.Type match or not."}}
|
{
"id": 51193526,
"name": "cosmos/cosmos-sdk",
"url": "https://api.github.com/repos/cosmos/cosmos-sdk"
}
|
{
"id": 18329646,
"login": "mossid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18329646?",
"url": "https://api.github.com/users/mossid"
}
|
{
"id": 228843,
"login": "cosmos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/228843?",
"url": "https://api.github.com/orgs/cosmos"
}
| 2018-06-13T01:13:28 |
7815908202
|
{"actor":{"display_login":"mossid"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2735","repository_url":"https://api.github.com/repos/cosmos/cosmos-sdk","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2735/labels{/name}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2735/comments","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2735/events","html_url":"https://github.com/cosmos/cosmos-sdk/issues/2735","id":378813666,"node_id":"MDU6SXNzdWUzNzg4MTM2NjY=","number":2735,"title":"move mock tendermint logic to tendermint ","user":{"login":"rigelrozanski","id":20132176,"node_id":"MDQ6VXNlcjIwMTMyMTc2","avatar_url":"https://avatars1.githubusercontent.com/u/20132176?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelrozanski","html_url":"https://github.com/rigelrozanski","followers_url":"https://api.github.com/users/rigelrozanski/followers","following_url":"https://api.github.com/users/rigelrozanski/following{/other_user}","gists_url":"https://api.github.com/users/rigelrozanski/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelrozanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelrozanski/subscriptions","organizations_url":"https://api.github.com/users/rigelrozanski/orgs","repos_url":"https://api.github.com/users/rigelrozanski/repos","events_url":"https://api.github.com/users/rigelrozanski/events{/privacy}","received_events_url":"https://api.github.com/users/rigelrozanski/received_events","type":"User","site_admin":false},"labels":[{"id":852962338,"node_id":"MDU6TGFiZWw4NTI5NjIzMzg=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/post-launch","name":"post-launch","color":"bfdadc","default":false},{"id":1113089032,"node_id":"MDU6TGFiZWwxMTEzMDg5MDMy","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/simulation","name":"simulation","color":"fcef00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-08T16:28:38Z","updated_at":"2018-11-09T14:32:17Z","closed_at":null,"author_association":"MEMBER","body":"Within the simulation we provide a q+d to simulate tendermint - ultimately this logic should probably persist in the Tendermint repo as to be updated as Tendermint protocol changes (instead of needing to be adapted to in the SDK) "},"comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments/437376574","html_url":"https://github.com/cosmos/cosmos-sdk/issues/2735#issuecomment-437376574","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2735","id":437376574,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzM3NjU3NA==","user":{"login":"cwgoes","id":24760279,"node_id":"MDQ6VXNlcjI0NzYwMjc5","avatar_url":"https://avatars2.githubusercontent.com/u/24760279?v=4","gravatar_id":"","url":"https://api.github.com/users/cwgoes","html_url":"https://github.com/cwgoes","followers_url":"https://api.github.com/users/cwgoes/followers","following_url":"https://api.github.com/users/cwgoes/following{/other_user}","gists_url":"https://api.github.com/users/cwgoes/gists{/gist_id}","starred_url":"https://api.github.com/users/cwgoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwgoes/subscriptions","organizations_url":"https://api.github.com/users/cwgoes/orgs","repos_url":"https://api.github.com/users/cwgoes/repos","events_url":"https://api.github.com/users/cwgoes/events{/privacy}","received_events_url":"https://api.github.com/users/cwgoes/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T14:32:17Z","updated_at":"2018-11-09T14:32:17Z","author_association":"CONTRIBUTOR","body":"I'm not really convinced this belongs in Tendermint, unless we want to simulate the whole `ABCIApp` (maybe, but it would be slower - less effective for state machine fuzzing). We can separate the SDK part more clearly into a subpackage though."}}
|
{
"id": 51193526,
"name": "cosmos/cosmos-sdk",
"url": "https://api.github.com/repos/cosmos/cosmos-sdk"
}
|
{
"id": 24760279,
"login": "cwgoes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24760279?",
"url": "https://api.github.com/users/cwgoes"
}
|
{
"id": 228843,
"login": "cosmos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/228843?",
"url": "https://api.github.com/orgs/cosmos"
}
| 2018-11-09T14:32:17 |
8563605288
|
{"actor":{"display_login":"cwgoes"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/725","repository_url":"https://api.github.com/repos/puppetlabs/pxp-agent","labels_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/725/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/725/comments","events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/725/events","html_url":"https://github.com/puppetlabs/pxp-agent/pull/725","id":360416302,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjgxMzA3","number":725,"title":"(PCP-856) Update invalid_ssl_config to use new ca command","user":{"login":"MikaelSmith","id":8162496,"node_id":"MDQ6VXNlcjgxNjI0OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/8162496?v=4","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-14T18:52:57Z","updated_at":"2018-09-17T17:05:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/725","html_url":"https://github.com/puppetlabs/pxp-agent/pull/725","diff_url":"https://github.com/puppetlabs/pxp-agent/pull/725.diff","patch_url":"https://github.com/puppetlabs/pxp-agent/pull/725.patch"},"body":"Re-enable the `invalid_ssl_config` test, and update it to use the new\r\n`puppetserver ca` command to generate a CA and certs. Uses only\r\n`puppetserver ca setup` because other commands require a running CA\r\nservice."},"comment":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/comments/422094495","html_url":"https://github.com/puppetlabs/pxp-agent/pull/725#issuecomment-422094495","issue_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/725","id":422094495,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjA5NDQ5NQ==","user":{"login":"donoghuc","id":15354214,"node_id":"MDQ6VXNlcjE1MzU0MjE0","avatar_url":"https://avatars3.githubusercontent.com/u/15354214?v=4","gravatar_id":"","url":"https://api.github.com/users/donoghuc","html_url":"https://github.com/donoghuc","followers_url":"https://api.github.com/users/donoghuc/followers","following_url":"https://api.github.com/users/donoghuc/following{/other_user}","gists_url":"https://api.github.com/users/donoghuc/gists{/gist_id}","starred_url":"https://api.github.com/users/donoghuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donoghuc/subscriptions","organizations_url":"https://api.github.com/users/donoghuc/orgs","repos_url":"https://api.github.com/users/donoghuc/repos","events_url":"https://api.github.com/users/donoghuc/events{/privacy}","received_events_url":"https://api.github.com/users/donoghuc/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T17:05:54Z","updated_at":"2018-09-17T17:05:54Z","author_association":"CONTRIBUTOR","body":"jenkins please test this"}}
|
{
"id": 23231786,
"name": "puppetlabs/pxp-agent",
"url": "https://api.github.com/repos/puppetlabs/pxp-agent"
}
|
{
"id": 15354214,
"login": "donoghuc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15354214?",
"url": "https://api.github.com/users/donoghuc"
}
|
{
"id": 234268,
"login": "puppetlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/234268?",
"url": "https://api.github.com/orgs/puppetlabs"
}
| 2018-09-17T17:05:55 |
8276967099
|
{"actor":{"display_login":"donoghuc"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-package/issues/79","repository_url":"https://api.github.com/repos/puppetlabs/puppetlabs-package","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-package/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-package/issues/79/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-package/issues/79/events","html_url":"https://github.com/puppetlabs/puppetlabs-package/pull/79","id":361359204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzQ4Njk5","number":79,"title":"WIP - Testing beaker-task_helper","user":{"login":"pmcmaw","id":20774767,"node_id":"MDQ6VXNlcjIwNzc0NzY3","avatar_url":"https://avatars2.githubusercontent.com/u/20774767?v=4","gravatar_id":"","url":"https://api.github.com/users/pmcmaw","html_url":"https://github.com/pmcmaw","followers_url":"https://api.github.com/users/pmcmaw/followers","following_url":"https://api.github.com/users/pmcmaw/following{/other_user}","gists_url":"https://api.github.com/users/pmcmaw/gists{/gist_id}","starred_url":"https://api.github.com/users/pmcmaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmcmaw/subscriptions","organizations_url":"https://api.github.com/users/pmcmaw/orgs","repos_url":"https://api.github.com/users/pmcmaw/repos","events_url":"https://api.github.com/users/pmcmaw/events{/privacy}","received_events_url":"https://api.github.com/users/pmcmaw/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-18T15:22:53Z","updated_at":"2018-09-20T10:21:08Z","closed_at":"2018-09-20T10:21:08Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-package/pulls/79","html_url":"https://github.com/puppetlabs/puppetlabs-package/pull/79","diff_url":"https://github.com/puppetlabs/puppetlabs-package/pull/79.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-package/pull/79.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-package/issues/comments/423129265","html_url":"https://github.com/puppetlabs/puppetlabs-package/pull/79#issuecomment-423129265","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-package/issues/79","id":423129265,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzEyOTI2NQ==","user":{"login":"pmcmaw","id":20774767,"node_id":"MDQ6VXNlcjIwNzc0NzY3","avatar_url":"https://avatars2.githubusercontent.com/u/20774767?v=4","gravatar_id":"","url":"https://api.github.com/users/pmcmaw","html_url":"https://github.com/pmcmaw","followers_url":"https://api.github.com/users/pmcmaw/followers","following_url":"https://api.github.com/users/pmcmaw/following{/other_user}","gists_url":"https://api.github.com/users/pmcmaw/gists{/gist_id}","starred_url":"https://api.github.com/users/pmcmaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmcmaw/subscriptions","organizations_url":"https://api.github.com/users/pmcmaw/orgs","repos_url":"https://api.github.com/users/pmcmaw/repos","events_url":"https://api.github.com/users/pmcmaw/events{/privacy}","received_events_url":"https://api.github.com/users/pmcmaw/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T10:21:08Z","updated_at":"2018-09-20T10:21:08Z","author_association":"MEMBER","body":"No longer necessary was used for testing purposes.\r\nClosing. "}}
|
{
"id": 101296659,
"name": "puppetlabs/puppetlabs-package",
"url": "https://api.github.com/repos/puppetlabs/puppetlabs-package"
}
|
{
"id": 20774767,
"login": "pmcmaw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20774767?",
"url": "https://api.github.com/users/pmcmaw"
}
|
{
"id": 234268,
"login": "puppetlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/234268?",
"url": "https://api.github.com/orgs/puppetlabs"
}
| 2018-09-20T10:21:08 |
8294601976
|
{"actor":{"display_login":"pmcmaw"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-docker/issues/151","repository_url":"https://api.github.com/repos/puppetlabs/puppetlabs-docker","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-docker/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-docker/issues/151/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-docker/issues/151/events","html_url":"https://github.com/puppetlabs/puppetlabs-docker/issues/151","id":295417595,"number":151,"title":"Wrong systemd access level on RHEL","user":{"login":"Thorndike","id":10463352,"avatar_url":"https://avatars2.githubusercontent.com/u/10463352?v=4","gravatar_id":"","url":"https://api.github.com/users/Thorndike","html_url":"https://github.com/Thorndike","followers_url":"https://api.github.com/users/Thorndike/followers","following_url":"https://api.github.com/users/Thorndike/following{/other_user}","gists_url":"https://api.github.com/users/Thorndike/gists{/gist_id}","starred_url":"https://api.github.com/users/Thorndike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thorndike/subscriptions","organizations_url":"https://api.github.com/users/Thorndike/orgs","repos_url":"https://api.github.com/users/Thorndike/repos","events_url":"https://api.github.com/users/Thorndike/events{/privacy}","received_events_url":"https://api.github.com/users/Thorndike/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-08T08:03:07Z","updated_at":"2018-02-08T09:19:29Z","closed_at":"2018-02-08T09:19:29Z","author_association":"NONE","body":"I am using docker plugin 1.0.4 on RHEL 7.4. In /var/log/messages the system is complaining about incorrect access levels to the puppet generated service files. \r\n\r\nFeb 8 08:58:23 rhscpm015 systemd[1]: Configuration file /etc/systemd/system/docker-verzeichnisMock_inst1.service is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.\r\n\r\nPleas change the file attributes to make them world-accessible."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-docker/issues/comments/364050255","html_url":"https://github.com/puppetlabs/puppetlabs-docker/issues/151#issuecomment-364050255","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-docker/issues/151","id":364050255,"user":{"login":"davejrt","id":2067825,"avatar_url":"https://avatars1.githubusercontent.com/u/2067825?v=4","gravatar_id":"","url":"https://api.github.com/users/davejrt","html_url":"https://github.com/davejrt","followers_url":"https://api.github.com/users/davejrt/followers","following_url":"https://api.github.com/users/davejrt/following{/other_user}","gists_url":"https://api.github.com/users/davejrt/gists{/gist_id}","starred_url":"https://api.github.com/users/davejrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davejrt/subscriptions","organizations_url":"https://api.github.com/users/davejrt/orgs","repos_url":"https://api.github.com/users/davejrt/repos","events_url":"https://api.github.com/users/davejrt/events{/privacy}","received_events_url":"https://api.github.com/users/davejrt/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T09:19:29Z","updated_at":"2018-02-08T09:19:29Z","author_association":"COLLABORATOR","body":"I don't see this as being an actual issue, or presently any problem in functionality of docker or the module. "}}
|
{
"id": 97579583,
"name": "puppetlabs/puppetlabs-docker",
"url": "https://api.github.com/repos/puppetlabs/puppetlabs-docker"
}
|
{
"id": 2067825,
"login": "davejrt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2067825?",
"url": "https://api.github.com/users/davejrt"
}
|
{
"id": 234268,
"login": "puppetlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/234268?",
"url": "https://api.github.com/orgs/puppetlabs"
}
| 2018-02-08T09:19:29 |
7215736344
|
{"actor":{"display_login":"davejrt"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/1719","repository_url":"https://api.github.com/repos/puppetlabs/puppetserver","labels_url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/1719/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/1719/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/1719/events","html_url":"https://github.com/puppetlabs/puppetserver/pull/1719","id":336773565,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTQ4MDg5","number":1719,"title":"(PE-24670) Add default authorization rule for status service endpoint","user":{"login":"amysahli","id":36681391,"node_id":"MDQ6VXNlcjM2NjgxMzkx","avatar_url":"https://avatars3.githubusercontent.com/u/36681391?v=4","gravatar_id":"","url":"https://api.github.com/users/amysahli","html_url":"https://github.com/amysahli","followers_url":"https://api.github.com/users/amysahli/followers","following_url":"https://api.github.com/users/amysahli/following{/other_user}","gists_url":"https://api.github.com/users/amysahli/gists{/gist_id}","starred_url":"https://api.github.com/users/amysahli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amysahli/subscriptions","organizations_url":"https://api.github.com/users/amysahli/orgs","repos_url":"https://api.github.com/users/amysahli/repos","events_url":"https://api.github.com/users/amysahli/events{/privacy}","received_events_url":"https://api.github.com/users/amysahli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-28T20:45:01Z","updated_at":"2018-06-29T18:59:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetserver/pulls/1719","html_url":"https://github.com/puppetlabs/puppetserver/pull/1719","diff_url":"https://github.com/puppetlabs/puppetserver/pull/1719.diff","patch_url":"https://github.com/puppetlabs/puppetserver/pull/1719.patch"},"body":"The status service endpoint previously did not check the puppetserver\r\nauth.conf file. Now that it does, we will give it a default rule to\r\nallow unauthenticated requests (default behavior)."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/comments/401444721","html_url":"https://github.com/puppetlabs/puppetserver/pull/1719#issuecomment-401444721","issue_url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/1719","id":401444721,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTQ0NDcyMQ==","user":{"login":"Sharpie","id":54181,"node_id":"MDQ6VXNlcjU0MTgx","avatar_url":"https://avatars2.githubusercontent.com/u/54181?v=4","gravatar_id":"","url":"https://api.github.com/users/Sharpie","html_url":"https://github.com/Sharpie","followers_url":"https://api.github.com/users/Sharpie/followers","following_url":"https://api.github.com/users/Sharpie/following{/other_user}","gists_url":"https://api.github.com/users/Sharpie/gists{/gist_id}","starred_url":"https://api.github.com/users/Sharpie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sharpie/subscriptions","organizations_url":"https://api.github.com/users/Sharpie/orgs","repos_url":"https://api.github.com/users/Sharpie/repos","events_url":"https://api.github.com/users/Sharpie/events{/privacy}","received_events_url":"https://api.github.com/users/Sharpie/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T18:59:19Z","updated_at":"2018-06-29T18:59:19Z","author_association":"MEMBER","body":"Given `/status` output from Puppet Server is something we want to restrict access to, it seems likely we'll want to do it for PuppeDB, Console Services, and Orchestration Services. `clj-parent` seems like the right spot for the update as it is shared by all TK services."}}
|
{
"id": 19546488,
"name": "puppetlabs/puppetserver",
"url": "https://api.github.com/repos/puppetlabs/puppetserver"
}
|
{
"id": 54181,
"login": "Sharpie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/54181?",
"url": "https://api.github.com/users/Sharpie"
}
|
{
"id": 234268,
"login": "puppetlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/234268?",
"url": "https://api.github.com/orgs/puppetlabs"
}
| 2018-06-29T18:59:19 |
7899461310
|
{"actor":{"display_login":"Sharpie"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/388","repository_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom","labels_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/388/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/388/comments","events_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/388/events","html_url":"https://github.com/puppetlabs/pltraining-classroom/pull/388","id":299182928,"number":388,"title":"[WIP] Remap keycodes to previous map","user":{"login":"binford2k","id":1392917,"avatar_url":"https://avatars0.githubusercontent.com/u/1392917?v=4","gravatar_id":"","url":"https://api.github.com/users/binford2k","html_url":"https://github.com/binford2k","followers_url":"https://api.github.com/users/binford2k/followers","following_url":"https://api.github.com/users/binford2k/following{/other_user}","gists_url":"https://api.github.com/users/binford2k/gists{/gist_id}","starred_url":"https://api.github.com/users/binford2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binford2k/subscriptions","organizations_url":"https://api.github.com/users/binford2k/orgs","repos_url":"https://api.github.com/users/binford2k/repos","events_url":"https://api.github.com/users/binford2k/events{/privacy}","received_events_url":"https://api.github.com/users/binford2k/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-22T00:44:07Z","updated_at":"2018-02-28T18:26:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/388","html_url":"https://github.com/puppetlabs/pltraining-classroom/pull/388","diff_url":"https://github.com/puppetlabs/pltraining-classroom/pull/388.diff","patch_url":"https://github.com/puppetlabs/pltraining-classroom/pull/388.patch"},"body":"The remote many of our presenters use sends PageUP/DOWN keycodes instead\r\nof left/right like I thought. This restores prior behaviour and is\r\nneeded when using the standard Logitech remote.\r\n\r\nTRAINTECH-1570 #resolved #time 30m"},"comment":{"url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/comments/369334880","html_url":"https://github.com/puppetlabs/pltraining-classroom/pull/388#issuecomment-369334880","issue_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/388","id":369334880,"user":{"login":"binford2k","id":1392917,"avatar_url":"https://avatars0.githubusercontent.com/u/1392917?v=4","gravatar_id":"","url":"https://api.github.com/users/binford2k","html_url":"https://github.com/binford2k","followers_url":"https://api.github.com/users/binford2k/followers","following_url":"https://api.github.com/users/binford2k/following{/other_user}","gists_url":"https://api.github.com/users/binford2k/gists{/gist_id}","starred_url":"https://api.github.com/users/binford2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binford2k/subscriptions","organizations_url":"https://api.github.com/users/binford2k/orgs","repos_url":"https://api.github.com/users/binford2k/repos","events_url":"https://api.github.com/users/binford2k/events{/privacy}","received_events_url":"https://api.github.com/users/binford2k/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T18:26:19Z","updated_at":"2018-02-28T18:26:19Z","author_association":"CONTRIBUTOR","body":"I think I will solve this a different way, so don't merge this yet."}}
|
{
"id": 32344158,
"name": "puppetlabs/pltraining-classroom",
"url": "https://api.github.com/repos/puppetlabs/pltraining-classroom"
}
|
{
"id": 1392917,
"login": "binford2k",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1392917?",
"url": "https://api.github.com/users/binford2k"
}
|
{
"id": 234268,
"login": "puppetlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/234268?",
"url": "https://api.github.com/orgs/puppetlabs"
}
| 2018-02-28T18:26:19 |
7311648484
|
{"actor":{"display_login":"binford2k"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/openlayers/openlayers/issues/6183","repository_url":"https://api.github.com/repos/openlayers/openlayers","labels_url":"https://api.github.com/repos/openlayers/openlayers/issues/6183/labels{/name}","comments_url":"https://api.github.com/repos/openlayers/openlayers/issues/6183/comments","events_url":"https://api.github.com/repos/openlayers/openlayers/issues/6183/events","html_url":"https://github.com/openlayers/openlayers/issues/6183","id":192401689,"node_id":"MDU6SXNzdWUxOTI0MDE2ODk=","number":6183,"title":"ol.source.Vector with spatial index and ol.Collection for features is broken","user":{"login":"w3rt3r","id":7523553,"node_id":"MDQ6VXNlcjc1MjM1NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/7523553?v=4","gravatar_id":"","url":"https://api.github.com/users/w3rt3r","html_url":"https://github.com/w3rt3r","followers_url":"https://api.github.com/users/w3rt3r/followers","following_url":"https://api.github.com/users/w3rt3r/following{/other_user}","gists_url":"https://api.github.com/users/w3rt3r/gists{/gist_id}","starred_url":"https://api.github.com/users/w3rt3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3rt3r/subscriptions","organizations_url":"https://api.github.com/users/w3rt3r/orgs","repos_url":"https://api.github.com/users/w3rt3r/repos","events_url":"https://api.github.com/users/w3rt3r/events{/privacy}","received_events_url":"https://api.github.com/users/w3rt3r/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-29T21:17:52Z","updated_at":"2018-09-29T16:38:54Z","closed_at":null,"author_association":"NONE","body":"I got a simple map that request geojson features dynamically based on extent of the map from a WFS (geoserver). \r\n\r\nFor some reason, I need to only load the features on the extent. So after map pan (map.on('moveend')) I clear a ol.Collection and repopulate the Collection with the new requested features. \r\n\r\nThe problem happen on the first clear (move the map). I get the error message:\r\n\r\n Cannot read property 'forEach' of undefined\r\n\r\nThe error seams to come from the event propagation of the pop event and append in the function\r\n\r\n ol.source.Vector.prototype.removeFeatureInternal\r\n\r\nHere is a sample code and the jsbin of the reproductible error\r\n\r\n```javascript\r\nvar myCollection = new ol.Collection();\r\n\r\nvar myLayer = new ol.layer.Vector({\r\n source: new ol.source.Vector({\r\n features: myCollection\r\n })\r\n})\r\n\r\nfunction myUpdateFunction() {\r\n // var url = 'https://raw.githubusercontent.com/johan/world.geo.json/master/countries/USA/WY.geo.json'\r\n var url = \"https://raw.githubusercontent.com/johan/world.geo.json/master/countries.geo.json\";\r\n $.get(url).then(function(result) {\r\n var format = new ol.format.GeoJSON({\r\n defaultDataProjection: \"EPSG:4326\",\r\n featureProjection: \"EPSG:3857\"\r\n });\r\n var features = format.readFeatures(result);\r\n\r\n myCollection.clear();\r\n myCollection.extend(features);\r\n });\r\n}\r\n\r\nvar map = new ol.Map({\r\n layers: [\r\n new ol.layer.Tile({source: new ol.source.OSM()}),\r\n myLayer\r\n ],\r\n target: 'map',\r\n controls: ol.control.defaults({\r\n attributionOptions:({collapsible: false})\r\n }),\r\n view: new ol.View({center: [0, 0],zoom: 2})\r\n});\r\n\r\nmap.on('moveend', function(e) {\r\n myUpdateFunction();\r\n});\r\n\r\n```\r\nhttps://jsbin.com/tivezamufi/1/edit?html,js,console,output"},"comment":{"url":"https://api.github.com/repos/openlayers/openlayers/issues/comments/425658269","html_url":"https://github.com/openlayers/openlayers/issues/6183#issuecomment-425658269","issue_url":"https://api.github.com/repos/openlayers/openlayers/issues/6183","id":425658269,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTY1ODI2OQ==","user":{"login":"labbitroma","id":11629814,"node_id":"MDQ6VXNlcjExNjI5ODE0","avatar_url":"https://avatars3.githubusercontent.com/u/11629814?v=4","gravatar_id":"","url":"https://api.github.com/users/labbitroma","html_url":"https://github.com/labbitroma","followers_url":"https://api.github.com/users/labbitroma/followers","following_url":"https://api.github.com/users/labbitroma/following{/other_user}","gists_url":"https://api.github.com/users/labbitroma/gists{/gist_id}","starred_url":"https://api.github.com/users/labbitroma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labbitroma/subscriptions","organizations_url":"https://api.github.com/users/labbitroma/orgs","repos_url":"https://api.github.com/users/labbitroma/repos","events_url":"https://api.github.com/users/labbitroma/events{/privacy}","received_events_url":"https://api.github.com/users/labbitroma/received_events","type":"User","site_admin":false},"created_at":"2018-09-29T16:38:54Z","updated_at":"2018-09-29T16:38:54Z","author_association":"NONE","body":"We have the same bug with interaction Select. Clearing collection `ol.interaction.Select.getFeatures()` triggers the bug randomly:\r\n\r\n```\r\nvar selectedFeatures;\r\n map.getInteractions().forEach(function (interaction) {\r\n if (interaction instanceof ol.interaction.Select) {\r\n selectedFeatures = interaction.getFeatures();\r\n selectedFeatures.clear(); //error if there are many features selected\r\n }\r\n });\r\n```"}}
|
{
"id": 4723248,
"name": "openlayers/openlayers",
"url": "https://api.github.com/repos/openlayers/openlayers"
}
|
{
"id": 11629814,
"login": "labbitroma",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11629814?",
"url": "https://api.github.com/users/labbitroma"
}
|
{
"id": 240579,
"login": "openlayers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/240579?",
"url": "https://api.github.com/orgs/openlayers"
}
| 2018-09-29T16:38:54 |
8342495169
|
{"actor":{"display_login":"labbitroma"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/openlayers/openlayers/issues/7760","repository_url":"https://api.github.com/repos/openlayers/openlayers","labels_url":"https://api.github.com/repos/openlayers/openlayers/issues/7760/labels{/name}","comments_url":"https://api.github.com/repos/openlayers/openlayers/issues/7760/comments","events_url":"https://api.github.com/repos/openlayers/openlayers/issues/7760/events","html_url":"https://github.com/openlayers/openlayers/issues/7760","id":294286349,"number":7760,"title":"Vector Label Decluttering disable in webgl","user":{"login":"treasureMoment","id":35365475,"avatar_url":"https://avatars0.githubusercontent.com/u/35365475?v=4","gravatar_id":"","url":"https://api.github.com/users/treasureMoment","html_url":"https://github.com/treasureMoment","followers_url":"https://api.github.com/users/treasureMoment/followers","following_url":"https://api.github.com/users/treasureMoment/following{/other_user}","gists_url":"https://api.github.com/users/treasureMoment/gists{/gist_id}","starred_url":"https://api.github.com/users/treasureMoment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treasureMoment/subscriptions","organizations_url":"https://api.github.com/users/treasureMoment/orgs","repos_url":"https://api.github.com/users/treasureMoment/repos","events_url":"https://api.github.com/users/treasureMoment/events{/privacy}","received_events_url":"https://api.github.com/users/treasureMoment/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-05T06:27:18Z","updated_at":"2018-02-05T08:57:25Z","closed_at":null,"author_association":"NONE","body":"http://openlayers.org/en/latest/examples/vector-label-decluttering.html?q=label\r\n\r\nWebGL \r\nrenderer:['webgl']\r\n var vectorLayer = new ol.layer.Vector({\r\n source: new ol.source.Vector({\r\n url: 'https://openlayers.org/en/v4.6.4/examples/data/geojson/countries.geojson',\r\n format: new ol.format.GeoJSON()\r\n }),\r\n style: function(feature) {\r\n labelStyle.getText().setText(feature.get('name'));\r\n return style;\r\n },\r\n declutter: true\r\n });\r\ndeclutter disable"},"comment":{"url":"https://api.github.com/repos/openlayers/openlayers/issues/comments/363019854","html_url":"https://github.com/openlayers/openlayers/issues/7760#issuecomment-363019854","issue_url":"https://api.github.com/repos/openlayers/openlayers/issues/7760","id":363019854,"user":{"login":"ahocevar","id":211514,"avatar_url":"https://avatars1.githubusercontent.com/u/211514?v=4","gravatar_id":"","url":"https://api.github.com/users/ahocevar","html_url":"https://github.com/ahocevar","followers_url":"https://api.github.com/users/ahocevar/followers","following_url":"https://api.github.com/users/ahocevar/following{/other_user}","gists_url":"https://api.github.com/users/ahocevar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocevar/subscriptions","organizations_url":"https://api.github.com/users/ahocevar/orgs","repos_url":"https://api.github.com/users/ahocevar/repos","events_url":"https://api.github.com/users/ahocevar/events{/privacy}","received_events_url":"https://api.github.com/users/ahocevar/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T08:57:25Z","updated_at":"2018-02-05T08:57:25Z","author_association":"OWNER","body":"The webgl renderer does not support decluttering."}}
|
{
"id": 4723248,
"name": "openlayers/openlayers",
"url": "https://api.github.com/repos/openlayers/openlayers"
}
|
{
"id": 211514,
"login": "ahocevar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/211514?",
"url": "https://api.github.com/users/ahocevar"
}
|
{
"id": 240579,
"login": "openlayers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/240579?",
"url": "https://api.github.com/orgs/openlayers"
}
| 2018-02-05T08:57:25 |
7197392069
|
{"actor":{"display_login":"ahocevar"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/dockerfile-maven/issues/15","repository_url":"https://api.github.com/repos/spotify/dockerfile-maven","labels_url":"https://api.github.com/repos/spotify/dockerfile-maven/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/spotify/dockerfile-maven/issues/15/comments","events_url":"https://api.github.com/repos/spotify/dockerfile-maven/issues/15/events","html_url":"https://github.com/spotify/dockerfile-maven/issues/15","id":233398500,"node_id":"MDU6SXNzdWUyMzMzOTg1MDA=","number":15,"title":"Build fails on windows 10 with Illegal char <*> at index 0: **\\\\*","user":{"login":"lucastheisen","id":1952786,"node_id":"MDQ6VXNlcjE5NTI3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1952786?v=4","gravatar_id":"","url":"https://api.github.com/users/lucastheisen","html_url":"https://github.com/lucastheisen","followers_url":"https://api.github.com/users/lucastheisen/followers","following_url":"https://api.github.com/users/lucastheisen/following{/other_user}","gists_url":"https://api.github.com/users/lucastheisen/gists{/gist_id}","starred_url":"https://api.github.com/users/lucastheisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucastheisen/subscriptions","organizations_url":"https://api.github.com/users/lucastheisen/orgs","repos_url":"https://api.github.com/users/lucastheisen/repos","events_url":"https://api.github.com/users/lucastheisen/events{/privacy}","received_events_url":"https://api.github.com/users/lucastheisen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-06-03T22:15:57Z","updated_at":"2018-09-24T15:01:50Z","closed_at":null,"author_association":"NONE","body":"Running `mvn -X install` against my [example project](https://gitlab.com/pastdev/docker-foo-service/tree/spotifypluginfail) results in the following stack trace:\r\n```\r\n[DEBUG] Auth Config null\r\n[INFO] ------------------------------------------------------------------------\r\n[INFO] BUILD FAILURE\r\n[INFO] ------------------------------------------------------------------------\r\n[INFO] Total time: 3.261 s\r\n[INFO] Finished at: 2017-06-03T18:09:35-04:00\r\n[INFO] Final Memory: 15M/249M\r\n[INFO] ------------------------------------------------------------------------\r\n[ERROR] Failed to execute goal com.spotify:dockerfile-maven-plugin:1.2.2:build (default-cli) on project docker-foo-service: Execution default-cli of goal com.spotify:dockerfi\r\nle-maven-plugin:1.2.2:build failed: Illegal char <*> at index 0: **\\\\* -> [Help 1]\r\norg.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.spotify:dockerfile-maven-plugin:1.2.2:build (default-cli) on project docker-foo-service: Ex\r\necution default-cli of goal com.spotify:dockerfile-maven-plugin:1.2.2:build failed: Illegal char <*> at index 0: **\\\\*\r\n at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)\r\n at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)\r\n at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)\r\n at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)\r\n at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)\r\n at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)\r\n at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)\r\n at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)\r\n at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)\r\n at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)\r\n at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)\r\n at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)\r\n at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)\r\n at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n at java.lang.reflect.Method.invoke(Method.java:498)\r\n at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)\r\n at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)\r\n at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)\r\n at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)\r\nCaused by: org.apache.maven.plugin.PluginExecutionException: Execution default-cli of goal com.spotify:dockerfile-maven-plugin:1.2.2:build failed: Illegal char <*> at index 0\r\n: **\\\\*\r\n at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)\r\n at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)\r\n ... 20 more\r\nCaused by: java.nio.file.InvalidPathException: Illegal char <*> at index 0: **\\\\*\r\n at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)\r\n at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)\r\n at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)\r\n at sun.nio.fs.WindowsPath.parse(WindowsPath.java:94)\r\n at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:255)\r\n at sun.nio.fs.AbstractPath.startsWith(AbstractPath.java:43)\r\n at com.spotify.docker.client.CompressedDirectory$DockerIgnorePathMatcher.matches(CompressedDirectory.java:402)\r\n at com.spotify.docker.client.CompressedDirectory$Visitor.exclude(CompressedDirectory.java:291)\r\n at com.spotify.docker.client.CompressedDirectory$Visitor.visitFile(CompressedDirectory.java:268)\r\n at com.spotify.docker.client.CompressedDirectory$Visitor.visitFile(CompressedDirectory.java:248)\r\n at java.nio.file.Files.walkFileTree(Files.java:2670)\r\n at com.spotify.docker.client.CompressedDirectory.create(CompressedDirectory.java:110)\r\n at com.spotify.docker.client.DefaultDockerClient.build(DefaultDockerClient.java:1146)\r\n at com.spotify.docker.client.DefaultDockerClient.build(DefaultDockerClient.java:1111)\r\n at com.spotify.plugin.dockerfile.BuildMojo.buildImage(BuildMojo.java:152)\r\n at com.spotify.plugin.dockerfile.BuildMojo.execute(BuildMojo.java:91)\r\n at com.spotify.plugin.dockerfile.AbstractDockerMojo.tryExecute(AbstractDockerMojo.java:206)\r\n at com.spotify.plugin.dockerfile.AbstractDockerMojo.execute(AbstractDockerMojo.java:195)\r\n at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)\r\n ... 21 more\r\n[ERROR]\r\n[ERROR]\r\n[ERROR] For more information about the errors and possible solutions, please read the following articles:\r\n[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException\r\n```\r\nJava version:\r\n```\r\nPS C:\\Users\\ltheisen\\git\\pastdev-docker-foo-service> java -version\r\nopenjdk version \"1.8.0_131-1-redhat\"\r\nOpenJDK Runtime Environment (build 1.8.0_131-1-redhat-b11)\r\nOpenJDK 64-Bit Server VM (build 25.131-b11, mixed mode)\r\n```\r\nMaven version:\r\n```\r\nPS C:\\Users\\ltheisen\\git\\pastdev-docker-foo-service> mvn --version\r\nApache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00)\r\nMaven home: C:\\Users\\ltheisen\\Tools\\apache-maven-3.3.9\r\nJava version: 1.8.0_131-1-redhat, vendor: Oracle Corporation\r\nJava home: C:\\Program Files\\RedHat\\java-1.8.0-openjdk-1.8.0.131-1\\jre\r\nDefault locale: en_US, platform encoding: Cp1252\r\nOS name: \"windows 10\", version: \"10.0\", arch: \"amd64\", family: \"dos\"\r\n```\r\nRun on Windows 10 Pro using powershell:\r\n```\r\nPS C:\\Users\\ltheisen\\git\\pastdev-docker-foo-service> $PSVersionTable.PSVersion\r\n\r\nMajor Minor Build Revision\r\n----- ----- ----- --------\r\n5 1 15063 296\r\n```"},"comment":{"url":"https://api.github.com/repos/spotify/dockerfile-maven/issues/comments/424006582","html_url":"https://github.com/spotify/dockerfile-maven/issues/15#issuecomment-424006582","issue_url":"https://api.github.com/repos/spotify/dockerfile-maven/issues/15","id":424006582,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDAwNjU4Mg==","user":{"login":"stale[bot]","id":26384082,"node_id":"MDM6Qm90MjYzODQwODI=","avatar_url":"https://avatars3.githubusercontent.com/in/1724?v=4","gravatar_id":"","url":"https://api.github.com/users/stale%5Bbot%5D","html_url":"https://github.com/apps/stale","followers_url":"https://api.github.com/users/stale%5Bbot%5D/followers","following_url":"https://api.github.com/users/stale%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/stale%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/stale%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stale%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/stale%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/stale%5Bbot%5D/repos","events_url":"https://api.github.com/users/stale%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/stale%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-24T15:01:50Z","updated_at":"2018-09-24T15:01:50Z","author_association":"NONE","body":"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"}}
|
{
"id": 54030871,
"name": "spotify/dockerfile-maven",
"url": "https://api.github.com/repos/spotify/dockerfile-maven"
}
|
{
"id": 26384082,
"login": "stale[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26384082?",
"url": "https://api.github.com/users/stale[bot]"
}
|
{
"id": 251374,
"login": "spotify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/251374?",
"url": "https://api.github.com/orgs/spotify"
}
| 2018-09-24T15:01:54 |
8311852137
|
{"actor":{"display_login":"stale"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1946","repository_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website","labels_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1946/labels{/name}","comments_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1946/comments","events_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1946/events","html_url":"https://github.com/openstreetmap/openstreetmap-website/issues/1946","id":349812501,"node_id":"MDU6SXNzdWUzNDk4MTI1MDE=","number":1946,"title":"Blocked users can still send OSM messages and raise OSM issues","user":{"login":"SomeoneElseOSM","id":5311740,"node_id":"MDQ6VXNlcjUzMTE3NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/5311740?v=4","gravatar_id":"","url":"https://api.github.com/users/SomeoneElseOSM","html_url":"https://github.com/SomeoneElseOSM","followers_url":"https://api.github.com/users/SomeoneElseOSM/followers","following_url":"https://api.github.com/users/SomeoneElseOSM/following{/other_user}","gists_url":"https://api.github.com/users/SomeoneElseOSM/gists{/gist_id}","starred_url":"https://api.github.com/users/SomeoneElseOSM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SomeoneElseOSM/subscriptions","organizations_url":"https://api.github.com/users/SomeoneElseOSM/orgs","repos_url":"https://api.github.com/users/SomeoneElseOSM/repos","events_url":"https://api.github.com/users/SomeoneElseOSM/events{/privacy}","received_events_url":"https://api.github.com/users/SomeoneElseOSM/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-12T13:24:44Z","updated_at":"2018-09-11T17:37:19Z","closed_at":null,"author_association":"NONE","body":"Given that sometimes the reason for a block is that a person may have been sending inappropriate messages, I don't think that they should be able to do this until the block expires."},"comment":{"url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/comments/420357284","html_url":"https://github.com/openstreetmap/openstreetmap-website/issues/1946#issuecomment-420357284","issue_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1946","id":420357284,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDM1NzI4NA==","user":{"login":"tomhughes","id":147741,"node_id":"MDQ6VXNlcjE0Nzc0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/147741?v=4","gravatar_id":"","url":"https://api.github.com/users/tomhughes","html_url":"https://github.com/tomhughes","followers_url":"https://api.github.com/users/tomhughes/followers","following_url":"https://api.github.com/users/tomhughes/following{/other_user}","gists_url":"https://api.github.com/users/tomhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/tomhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomhughes/subscriptions","organizations_url":"https://api.github.com/users/tomhughes/orgs","repos_url":"https://api.github.com/users/tomhughes/repos","events_url":"https://api.github.com/users/tomhughes/events{/privacy}","received_events_url":"https://api.github.com/users/tomhughes/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T17:37:19Z","updated_at":"2018-09-11T17:37:19Z","author_association":"MEMBER","body":"I can suspend an account but that makes it completely vanish from the site - it will appear much the same as a deleted account and nobody will be able login to it."}}
|
{
"id": 641512,
"name": "openstreetmap/openstreetmap-website",
"url": "https://api.github.com/repos/openstreetmap/openstreetmap-website"
}
|
{
"id": 147741,
"login": "tomhughes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/147741?",
"url": "https://api.github.com/users/tomhughes"
}
|
{
"id": 261431,
"login": "openstreetmap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/261431?",
"url": "https://api.github.com/orgs/openstreetmap"
}
| 2018-09-11T17:37:19 |
8248164733
|
{"actor":{"display_login":"tomhughes"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/7941","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/7941/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/7941/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/7941/events","html_url":"https://github.com/WordPress/gutenberg/pull/7941","id":340807600,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTMzMTI1","number":7941,"title":"Add latest comments block","user":{"login":"tofumatt","id":90871,"node_id":"MDQ6VXNlcjkwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"labels":[{"id":634645371,"node_id":"MDU6TGFiZWw2MzQ2NDUzNzE=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/New%20Block","name":"New Block","color":"62ABDB","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/WordPress/gutenberg/milestones/57","html_url":"https://github.com/WordPress/gutenberg/milestone/57","labels_url":"https://api.github.com/repos/WordPress/gutenberg/milestones/57/labels","id":3459643,"node_id":"MDk6TWlsZXN0b25lMzQ1OTY0Mw==","number":57,"title":"3.3","description":"","creator":{"login":"mtias","id":548849,"node_id":"MDQ6VXNlcjU0ODg0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/548849?v=4","gravatar_id":"","url":"https://api.github.com/users/mtias","html_url":"https://github.com/mtias","followers_url":"https://api.github.com/users/mtias/followers","following_url":"https://api.github.com/users/mtias/following{/other_user}","gists_url":"https://api.github.com/users/mtias/gists{/gist_id}","starred_url":"https://api.github.com/users/mtias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtias/subscriptions","organizations_url":"https://api.github.com/users/mtias/orgs","repos_url":"https://api.github.com/users/mtias/repos","events_url":"https://api.github.com/users/mtias/events{/privacy}","received_events_url":"https://api.github.com/users/mtias/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":72,"state":"open","created_at":"2018-06-28T14:08:24Z","updated_at":"2018-07-17T15:35:21Z","due_on":"2018-07-18T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-07-12T21:38:10Z","updated_at":"2018-07-17T17:09:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/7941","html_url":"https://github.com/WordPress/gutenberg/pull/7941","diff_url":"https://github.com/WordPress/gutenberg/pull/7941.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/7941.patch"},"body":"## Description\r\nFixes #1792. Note that this PR is based on #7369, which is based on #1931. I've made a few tweaks (mentioned in #7369).\r\n\r\nCloses #7369.\r\n\r\n---\r\n\r\n@tofumatt here:\r\n\r\nI've made some changes here from the original PR, mainly around:\r\n\r\n1. changing `get_the_title` to `_draft_or_post_title` as it's the only way to display posts with no title\r\n2. escaping the post title\r\n3. Markup changes\r\n4. CSS refactors/tweaks\r\n5. Added centre-alignment support\r\n\r\nI was going to add tests but these tests require post comments, and making them means I need a mock/test database, as the current e2e tests run against the local development URL. I'll do those in a follow-up branch as I've tested this locally a fair bit.\r\n\r\n---\r\n\r\n\r\nAdds `Latest Comments` block v1 using `ServerSideRender` component.\r\nAllows configuring the following:\r\n- Number of comments displayed;\r\n- Comment excerpt to be shown;\r\n- Permit avatar to be shown;\r\n- Permit timestamps to be shown.\r\n\r\n## Screenshots\r\n### Editor:\r\n<img width=\"1136\" alt=\"screenshot 2018-07-12 23 40 58\" src=\"https://user-images.githubusercontent.com/90871/42663349-11bfa9a6-862d-11e8-8245-bab2db447d64.png\">\r\n\r\n### Frontend:\r\n<img width=\"583\" alt=\"screenshot 2018-07-12 23 35 58\" src=\"https://user-images.githubusercontent.com/90871/42663207-811612aa-862c-11e8-9123-1d50a86421b4.png\">\r\n\r\n\r\n## Checklist:\r\n- [x] My code is tested functionally.\r\n- [x] My code follows the WordPress code style.\r\n- [x] My code has proper inline documentation."},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/405656721","html_url":"https://github.com/WordPress/gutenberg/pull/7941#issuecomment-405656721","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/7941","id":405656721,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTY1NjcyMQ==","user":{"login":"tofumatt","id":90871,"node_id":"MDQ6VXNlcjkwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T17:09:39Z","updated_at":"2018-07-17T17:09:39Z","author_association":"MEMBER","body":"Yeah, I noticed that and I have something in the pipeline, should be pushed soon."}}
|
{
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
}
|
{
"id": 90871,
"login": "tofumatt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/90871?",
"url": "https://api.github.com/users/tofumatt"
}
|
{
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
}
| 2018-07-17T17:09:39 |
7978070520
|
{"actor":{"display_login":"tofumatt"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/9207","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9207/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9207/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9207/events","html_url":"https://github.com/WordPress/gutenberg/issues/9207","id":352650045,"node_id":"MDU6SXNzdWUzNTI2NTAwNDU=","number":9207,"title":"Pictures shows differently in Gutenberg vs Classical on smartphone","user":{"login":"AstaC","id":42585130,"node_id":"MDQ6VXNlcjQyNTg1MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/42585130?v=4","gravatar_id":"","url":"https://api.github.com/users/AstaC","html_url":"https://github.com/AstaC","followers_url":"https://api.github.com/users/AstaC/followers","following_url":"https://api.github.com/users/AstaC/following{/other_user}","gists_url":"https://api.github.com/users/AstaC/gists{/gist_id}","starred_url":"https://api.github.com/users/AstaC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AstaC/subscriptions","organizations_url":"https://api.github.com/users/AstaC/orgs","repos_url":"https://api.github.com/users/AstaC/repos","events_url":"https://api.github.com/users/AstaC/events{/privacy}","received_events_url":"https://api.github.com/users/AstaC/received_events","type":"User","site_admin":false},"labels":[{"id":637003880,"node_id":"MDU6TGFiZWw2MzcwMDM4ODA=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Media","name":"Media","color":"00aa99","default":false},{"id":816933178,"node_id":"MDU6TGFiZWw4MTY5MzMxNzg=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Needs%20Testing","name":"Needs Testing","color":"67dff7","default":false},{"id":610482468,"node_id":"MDU6TGFiZWw2MTA0ODI0Njg=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Component]%20Mobile","name":"[Component] Mobile","color":"fbca04","default":false},{"id":630674253,"node_id":"MDU6TGFiZWw2MzA2NzQyNTM=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Status]%20Needs%20More%20Info","name":"[Status] Needs More Info","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-21T18:04:50Z","updated_at":"2018-08-21T18:15:15Z","closed_at":null,"author_association":"NONE","body":"**Describe the bug**\r\nWhen I attach an Image with Gutenberg and use the same size as when I use the classic texteditor the Image gets a smaller size when you look at the image on your smartphone.\r\nSee attached images.\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\nWith Gutenberg\r\nCreate image block, chose Large (would be very good if that could be a set choice like it is today) and insert image.\r\n\r\nWith Classical texteditor.\r\nInsert Image - Large.\r\n\r\n**Expected behavior**\r\nImage should have the same size when you look at them in the same browser. I don't want them smaller\r\n**Screenshots**\r\n\r\nIf applicable, add screenshots to help explain your problem.\r\n\r\n**Desktop (please complete the following information):**\r\n - OS: [e.g. iOS]\r\n - Browser [e.g. chrome, safari]\r\n - Version [e.g. 22]\r\n\r\n**Smartphone (please complete the following information):**\r\n - Device: [Note 8]\r\n - OS: [Android 8.1]\r\n - Browser [Chrome]\r\n - Version [nesest]\r\n\r\n**Additional context**\r\n- Please add the version of Gutenberg you are using in the description. 3.6.2\r\n\r\n\r\n\r\n\r\n\r\n\r\n- To report a security issue, please visit the WordPress HackerOne program: https://hackerone.com/wordpress.\r\n"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/414771290","html_url":"https://github.com/WordPress/gutenberg/issues/9207#issuecomment-414771290","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9207","id":414771290,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDc3MTI5MA==","user":{"login":"AstaC","id":42585130,"node_id":"MDQ6VXNlcjQyNTg1MTMw","avatar_url":"https://avatars0.githubusercontent.com/u/42585130?v=4","gravatar_id":"","url":"https://api.github.com/users/AstaC","html_url":"https://github.com/AstaC","followers_url":"https://api.github.com/users/AstaC/followers","following_url":"https://api.github.com/users/AstaC/following{/other_user}","gists_url":"https://api.github.com/users/AstaC/gists{/gist_id}","starred_url":"https://api.github.com/users/AstaC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AstaC/subscriptions","organizations_url":"https://api.github.com/users/AstaC/orgs","repos_url":"https://api.github.com/users/AstaC/repos","events_url":"https://api.github.com/users/AstaC/events{/privacy}","received_events_url":"https://api.github.com/users/AstaC/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T18:15:15Z","updated_at":"2018-08-21T18:15:15Z","author_association":"NONE","body":"Theme Genesis - version 2.6.1 . (childtheme Pretty Creative)"}}
|
{
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
}
|
{
"id": 42585130,
"login": "AstaC",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42585130?",
"url": "https://api.github.com/users/AstaC"
}
|
{
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
}
| 2018-08-21T18:15:15 |
8145971486
|
{"actor":{"display_login":"AstaC"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/7621","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/7621/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/7621/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/7621/events","html_url":"https://github.com/WordPress/gutenberg/pull/7621","id":336790242,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTYxMjky","number":7621,"title":"Adding date form to date picker and improving accessibility","user":{"login":"aldavigdis","id":191583,"node_id":"MDQ6VXNlcjE5MTU4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/191583?v=4","gravatar_id":"","url":"https://api.github.com/users/aldavigdis","html_url":"https://github.com/aldavigdis","followers_url":"https://api.github.com/users/aldavigdis/followers","following_url":"https://api.github.com/users/aldavigdis/following{/other_user}","gists_url":"https://api.github.com/users/aldavigdis/gists{/gist_id}","starred_url":"https://api.github.com/users/aldavigdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldavigdis/subscriptions","organizations_url":"https://api.github.com/users/aldavigdis/orgs","repos_url":"https://api.github.com/users/aldavigdis/repos","events_url":"https://api.github.com/users/aldavigdis/events{/privacy}","received_events_url":"https://api.github.com/users/aldavigdis/received_events","type":"User","site_admin":false},"labels":[{"id":644027893,"node_id":"MDU6TGFiZWw2NDQwMjc4OTM=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Needs%20Design%20Feedback","name":"Needs Design Feedback","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":34,"created_at":"2018-06-28T21:41:56Z","updated_at":"2018-08-12T23:42:01Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/7621","html_url":"https://github.com/WordPress/gutenberg/pull/7621","diff_url":"https://github.com/WordPress/gutenberg/pull/7621.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/7621.patch"},"body":"## Description\r\n\r\nFixes issues related to issue #1311. The discussion on the ticket is extensive, but this should cover most of the complaints.\r\n\r\n* Date form has been added to the date-time component, as a primary input method\r\n* Locale-dependent field order, with en-US being month-day, and the default day-month\r\n* Keyboard focus goes to the month selector first, as dates are validated based on the month (and year if leap-year)\r\n* The post-schedule sidebar widget is now more accessible, with button designated as a live object, so changes should be announced to date pickers\r\n* React-Datepicker widget has been removed from the keyboard navigation and screenreader context, as the new form fields are not the primary input method.\r\n\r\n## How has this been tested?\r\n* Unit tests added for text input fields\r\n* Manual tests for locale-depended field order\r\n\r\n## Screenshots <!-- if applicable -->\r\n\r\n\r\n## Types of changes\r\nAccessibility and UI changes\r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->\r\n- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->\r\n- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->\r\n"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/412379702","html_url":"https://github.com/WordPress/gutenberg/pull/7621#issuecomment-412379702","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/7621","id":412379702,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjM3OTcwMg==","user":{"login":"aldavigdis","id":191583,"node_id":"MDQ6VXNlcjE5MTU4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/191583?v=4","gravatar_id":"","url":"https://api.github.com/users/aldavigdis","html_url":"https://github.com/aldavigdis","followers_url":"https://api.github.com/users/aldavigdis/followers","following_url":"https://api.github.com/users/aldavigdis/following{/other_user}","gists_url":"https://api.github.com/users/aldavigdis/gists{/gist_id}","starred_url":"https://api.github.com/users/aldavigdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldavigdis/subscriptions","organizations_url":"https://api.github.com/users/aldavigdis/orgs","repos_url":"https://api.github.com/users/aldavigdis/repos","events_url":"https://api.github.com/users/aldavigdis/events{/privacy}","received_events_url":"https://api.github.com/users/aldavigdis/received_events","type":"User","site_admin":false},"created_at":"2018-08-12T23:42:01Z","updated_at":"2018-08-12T23:42:01Z","author_association":"NONE","body":"The rebase was a bit tricky. Pushing now."}}
|
{
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
}
|
{
"id": 191583,
"login": "aldavigdis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/191583?",
"url": "https://api.github.com/users/aldavigdis"
}
|
{
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
}
| 2018-08-12T23:42:01 |
8102264236
|
{"actor":{"display_login":"aldavigdis"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/9282","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9282/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9282/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9282/events","html_url":"https://github.com/WordPress/gutenberg/pull/9282","id":353479475,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTIwNTg2","number":9282,"title":"Try/block toolbar refactoring","user":{"login":"youknowriad","id":272444,"node_id":"MDQ6VXNlcjI3MjQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"labels":[{"id":644027893,"node_id":"MDU6TGFiZWw2NDQwMjc4OTM=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Needs%20Design%20Feedback","name":"Needs Design Feedback","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-23T17:26:48Z","updated_at":"2018-08-24T09:43:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/9282","html_url":"https://github.com/WordPress/gutenberg/pull/9282","diff_url":"https://github.com/WordPress/gutenberg/pull/9282.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/9282.patch"},"body":"This is an experiment that does a lot of things (probably more than necessary) to the block toolbar\r\n\r\n - It moves the block settings menu to the block toolbar\r\n - It implements a generic Responsive Toolbar component (similar to google docs toolbars where extra elements are moved to a dropdown)\r\n - Uses the ResponsiveToolbar component in the block toolbar\r\n\r\nFor testing purpose, I duplicated the alignment toolbar in the paragraph block to make it easier to test the ResponsiveToolbar behavior.\r\n\r\nAlso, this is still buggy especially in floated blocks and wide blocks, but it can be fixed, more a POC at the moment.\r\n\r\nRelated #9074 #9075 "},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/415709291","html_url":"https://github.com/WordPress/gutenberg/pull/9282#issuecomment-415709291","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/9282","id":415709291,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTcwOTI5MQ==","user":{"login":"youknowriad","id":272444,"node_id":"MDQ6VXNlcjI3MjQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T09:43:25Z","updated_at":"2018-08-24T09:43:25Z","author_association":"CONTRIBUTOR","body":"> Note that it's fine if the toolbar is technically fullwidth — could we do that, but make the empty space on the right transparent so you can see the text below?\r\n\r\nYes, that's what I'm going to try"}}
|
{
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
}
|
{
"id": 272444,
"login": "youknowriad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/272444?",
"url": "https://api.github.com/users/youknowriad"
}
|
{
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
}
| 2018-08-24T09:43:25 |
8162049486
|
{"actor":{"display_login":"youknowriad"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/4872","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4872/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4872/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4872/events","html_url":"https://github.com/WordPress/gutenberg/pull/4872","id":294379830,"number":4872,"title":"Framework: Drop the focus/setFocus props from block edit functions","user":{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"labels":[{"id":562969841,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/Framework","name":"Framework","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"assignees":[{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-02-05T12:42:59Z","updated_at":"2018-02-06T10:25:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/4872","html_url":"https://github.com/WordPress/gutenberg/pull/4872","diff_url":"https://github.com/WordPress/gutenberg/pull/4872.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/4872.patch"},"body":"The idea of this PR is simple: We only have to worry about the position of the cursor when selecting a new block, everything else should be left as uncontrolled browser behavior.\r\n\r\nBased on the above statement, this PR do:\r\n\r\n - remove the `focus` prop from the block `edit` function and replace it with an `isSelected` prop\r\n - no need for `setFocus` prop\r\n - remove focus information from the state\r\n - handle all explicit focus calls in the `WritingFlow` component: When a new block is selected, move the cursor to the right position\r\n- I kept the focus and setFocus prop for the block's `edit` function for backwards compatibility concerns now.\r\n\r\nThis should simplify the block author's work a lot, not need to handle any focus behavior inside blocks.\r\n\r\n**Testing instructions**\r\n\r\nThis needs heavy testing, all writing flow micro interactions should be tested."},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/363378642","html_url":"https://github.com/WordPress/gutenberg/pull/4872#issuecomment-363378642","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4872","id":363378642,"user":{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T10:25:30Z","updated_at":"2018-02-06T10:25:30Z","author_association":"CONTRIBUTOR","body":"@iseulde I think I'm going to rename it `showToolbar` or `showFormattingControls`, it's clearer from the Point of View of the `RichText` component and it's not always equal to the value of the block's `isSelected` prop."}}
|
{
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
}
|
{
"id": 272444,
"login": "youknowriad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/272444?",
"url": "https://api.github.com/users/youknowriad"
}
|
{
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
}
| 2018-02-06T10:25:31 |
7203805279
|
{"actor":{"display_login":"youknowriad"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/4597","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4597/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4597/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4597/events","html_url":"https://github.com/WordPress/gutenberg/issues/4597","id":289927929,"number":4597,"title":"Extensibility: Make it possible to add \"Open in a new window\", \"nofollow\" and other link options","user":{"login":"Soean","id":695201,"avatar_url":"https://avatars2.githubusercontent.com/u/695201?v=4","gravatar_id":"","url":"https://api.github.com/users/Soean","html_url":"https://github.com/Soean","followers_url":"https://api.github.com/users/Soean/followers","following_url":"https://api.github.com/users/Soean/following{/other_user}","gists_url":"https://api.github.com/users/Soean/gists{/gist_id}","starred_url":"https://api.github.com/users/Soean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soean/subscriptions","organizations_url":"https://api.github.com/users/Soean/orgs","repos_url":"https://api.github.com/users/Soean/repos","events_url":"https://api.github.com/users/Soean/events{/privacy}","received_events_url":"https://api.github.com/users/Soean/received_events","type":"User","site_admin":false},"labels":[{"id":631490822,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/Extensibility","name":"Extensibility","color":"655104","default":false},{"id":593977130,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/Priority%20Low","name":"Priority Low","color":"f9d0c4","default":false},{"id":531680825,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-01-19T10:24:59Z","updated_at":"2018-04-07T20:38:55Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Issue Overview\r\nThe \"Open in new window\" link option was removed in #4583. For plugin authors it should be possible to add this function with a plugin.\r\nThis also can be useful for a \"nofollow\" option, see #4499"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/379497643","html_url":"https://github.com/WordPress/gutenberg/issues/4597#issuecomment-379497643","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/4597","id":379497643,"user":{"login":"iseulde","id":4710635,"avatar_url":"https://avatars3.githubusercontent.com/u/4710635?v=4","gravatar_id":"","url":"https://api.github.com/users/iseulde","html_url":"https://github.com/iseulde","followers_url":"https://api.github.com/users/iseulde/followers","following_url":"https://api.github.com/users/iseulde/following{/other_user}","gists_url":"https://api.github.com/users/iseulde/gists{/gist_id}","starred_url":"https://api.github.com/users/iseulde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iseulde/subscriptions","organizations_url":"https://api.github.com/users/iseulde/orgs","repos_url":"https://api.github.com/users/iseulde/repos","events_url":"https://api.github.com/users/iseulde/events{/privacy}","received_events_url":"https://api.github.com/users/iseulde/received_events","type":"User","site_admin":false},"created_at":"2018-04-07T20:38:55Z","updated_at":"2018-04-07T20:38:55Z","author_association":"MEMBER","body":"Even though I wouldn’t recommend doing this, there are plugins that will\nautomatically add this attribute to external links. Might be easier than\nadding it manually for every link? Regardless, there’s a PR somewhere that\nadds the UI.\nOn Sat, 7 Apr 2018 at 18:35, dmccan <[email protected]> wrote:\n\n> Please consider adding the \"Open in a new tab\" option to the Gutenberg\n> link interface. It is widely used. It is just a checkbox. It is common to\n> use it on all external links.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/WordPress/gutenberg/issues/4597#issuecomment-379482253>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AEfg68sbQKtI_bxb2EMm4gl40yZ2GJ3Pks5tmOqYgaJpZM4RkRP_>\n> .\n>\n"}}
|
{
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
}
|
{
"id": 4710635,
"login": "iseulde",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4710635?",
"url": "https://api.github.com/users/iseulde"
}
|
{
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
}
| 2018-04-07T20:38:55 |
7495423667
|
{"actor":{"display_login":"iseulde"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/12965","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/12965/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/12965/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/12965/events","html_url":"https://github.com/WordPress/gutenberg/issues/12965","id":391998243,"node_id":"MDU6SXNzdWUzOTE5OTgyNDM=","number":12965,"title":"Gallery Block: Reordering doesn't work on mobile","user":{"login":"pento","id":352291,"node_id":"MDQ6VXNlcjM1MjI5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/352291?v=4","gravatar_id":"","url":"https://api.github.com/users/pento","html_url":"https://github.com/pento","followers_url":"https://api.github.com/users/pento/followers","following_url":"https://api.github.com/users/pento/following{/other_user}","gists_url":"https://api.github.com/users/pento/gists{/gist_id}","starred_url":"https://api.github.com/users/pento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pento/subscriptions","organizations_url":"https://api.github.com/users/pento/orgs","repos_url":"https://api.github.com/users/pento/repos","events_url":"https://api.github.com/users/pento/events{/privacy}","received_events_url":"https://api.github.com/users/pento/received_events","type":"User","site_admin":false},"labels":[{"id":637003880,"node_id":"MDU6TGFiZWw2MzcwMDM4ODA=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Media","name":"Media","color":"00aa99","default":false},{"id":1101518842,"node_id":"MDU6TGFiZWwxMTAxNTE4ODQy","url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Block]%20Gallery","name":"[Block] Gallery","color":"6767e5","default":false},{"id":531680823,"node_id":"MDU6TGFiZWw1MzE2ODA4MjM=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Type]%20Bug","name":"[Type] Bug","color":"d93f0b","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/WordPress/gutenberg/milestones/74","html_url":"https://github.com/WordPress/gutenberg/milestone/74","labels_url":"https://api.github.com/repos/WordPress/gutenberg/milestones/74/labels","id":3807166,"node_id":"MDk6TWlsZXN0b25lMzgwNzE2Ng==","number":74,"title":"WordPress 5.0.x Follow Ups","description":"Minor enhancements and fixes following up the 5.0 release","creator":{"login":"mtias","id":548849,"node_id":"MDQ6VXNlcjU0ODg0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/548849?v=4","gravatar_id":"","url":"https://api.github.com/users/mtias","html_url":"https://github.com/mtias","followers_url":"https://api.github.com/users/mtias/followers","following_url":"https://api.github.com/users/mtias/following{/other_user}","gists_url":"https://api.github.com/users/mtias/gists{/gist_id}","starred_url":"https://api.github.com/users/mtias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtias/subscriptions","organizations_url":"https://api.github.com/users/mtias/orgs","repos_url":"https://api.github.com/users/mtias/repos","events_url":"https://api.github.com/users/mtias/events{/privacy}","received_events_url":"https://api.github.com/users/mtias/received_events","type":"User","site_admin":false},"open_issues":127,"closed_issues":19,"state":"open","created_at":"2018-11-08T19:25:33Z","updated_at":"2018-12-18T06:20:13Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-12-18T05:05:21Z","updated_at":"2018-12-18T06:36:50Z","closed_at":"2018-12-18T06:20:12Z","author_association":"MEMBER","body":"**Describe the bug**\r\n\r\nWhen editing a gallery in the gallery modal, it's possible to drag and drop images to reorder them, when using a desktop browser. It's not possible to do the same thing on a mobile device.\r\n\r\nThis differs to classic editor behaviour, where drag and drop works on both desktop and mobile devices.\r\n\r\n**To Reproduce**\r\nRepeat these steps for the block editor on desktop and mobile, as well as the classic editor on desktop and mobile:\r\n1. Create a new post.\r\n2. Add a gallery.\r\n3. Click/tap the Edit Gallery button.\r\n4. Attempt to reorder the images by dragging and dropping.\r\n\r\n**Notes**\r\n\r\nThis was [reported in the forums](https://wordpress.org/support/topic/sort-in-gallery/) as not working on an iPad, I was able to reproduce the same inconsistency on an Android phone, it seems to be a generic touch/mobile device issue."},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/448112994","html_url":"https://github.com/WordPress/gutenberg/issues/12965#issuecomment-448112994","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/12965","id":448112994,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODExMjk5NA==","user":{"login":"pento","id":352291,"node_id":"MDQ6VXNlcjM1MjI5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/352291?v=4","gravatar_id":"","url":"https://api.github.com/users/pento","html_url":"https://github.com/pento","followers_url":"https://api.github.com/users/pento/followers","following_url":"https://api.github.com/users/pento/following{/other_user}","gists_url":"https://api.github.com/users/pento/gists{/gist_id}","starred_url":"https://api.github.com/users/pento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pento/subscriptions","organizations_url":"https://api.github.com/users/pento/orgs","repos_url":"https://api.github.com/users/pento/repos","events_url":"https://api.github.com/users/pento/events{/privacy}","received_events_url":"https://api.github.com/users/pento/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T06:36:50Z","updated_at":"2018-12-18T06:36:50Z","author_association":"MEMBER","body":"Ah, \"touchscreen\" was the search I didn't try when I was looking for a duplicate. 🙂\r\n\r\nLet's leave this one closed, as we already have an issue for it."}}
|
{
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
}
|
{
"id": 352291,
"login": "pento",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/352291?",
"url": "https://api.github.com/users/pento"
}
|
{
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
}
| 2018-12-18T06:36:50 |
8769905182
|
{"actor":{"display_login":"pento"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/11477","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/11477/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/11477/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/11477/events","html_url":"https://github.com/WordPress/gutenberg/pull/11477","id":377277650,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjYwOTgx","number":11477,"title":"Fix dropcap overlap","user":{"login":"ajitbohra","id":1039236,"node_id":"MDQ6VXNlcjEwMzkyMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1039236?v=4","gravatar_id":"","url":"https://api.github.com/users/ajitbohra","html_url":"https://github.com/ajitbohra","followers_url":"https://api.github.com/users/ajitbohra/followers","following_url":"https://api.github.com/users/ajitbohra/following{/other_user}","gists_url":"https://api.github.com/users/ajitbohra/gists{/gist_id}","starred_url":"https://api.github.com/users/ajitbohra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajitbohra/subscriptions","organizations_url":"https://api.github.com/users/ajitbohra/orgs","repos_url":"https://api.github.com/users/ajitbohra/repos","events_url":"https://api.github.com/users/ajitbohra/events{/privacy}","received_events_url":"https://api.github.com/users/ajitbohra/received_events","type":"User","site_admin":false},"labels":[{"id":1105623355,"node_id":"MDU6TGFiZWwxMTA1NjIzMzU1","url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Block]%20Paragraph","name":"[Block] Paragraph","color":"6767e5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-05T07:21:21Z","updated_at":"2018-11-05T08:05:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/11477","html_url":"https://github.com/WordPress/gutenberg/pull/11477","diff_url":"https://github.com/WordPress/gutenberg/pull/11477.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/11477.patch"},"body":"Fixes #10832 "},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/435785775","html_url":"https://github.com/WordPress/gutenberg/pull/11477#issuecomment-435785775","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/11477","id":435785775,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTc4NTc3NQ==","user":{"login":"jasmussen","id":1204802,"node_id":"MDQ6VXNlcjEyMDQ4MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1204802?v=4","gravatar_id":"","url":"https://api.github.com/users/jasmussen","html_url":"https://github.com/jasmussen","followers_url":"https://api.github.com/users/jasmussen/followers","following_url":"https://api.github.com/users/jasmussen/following{/other_user}","gists_url":"https://api.github.com/users/jasmussen/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmussen/subscriptions","organizations_url":"https://api.github.com/users/jasmussen/orgs","repos_url":"https://api.github.com/users/jasmussen/repos","events_url":"https://api.github.com/users/jasmussen/events{/privacy}","received_events_url":"https://api.github.com/users/jasmussen/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T08:05:05Z","updated_at":"2018-11-05T08:05:05Z","author_association":"CONTRIBUTOR","body":"Responded in https://github.com/WordPress/gutenberg/issues/10832."}}
|
{
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
}
|
{
"id": 1204802,
"login": "jasmussen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1204802?",
"url": "https://api.github.com/users/jasmussen"
}
|
{
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
}
| 2018-11-05T08:05:05 |
8533985424
|
{"actor":{"display_login":"jasmussen"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/6023","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6023/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6023/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6023/events","html_url":"https://github.com/WordPress/gutenberg/issues/6023","id":311766987,"node_id":"MDU6SXNzdWUzMTE3NjY5ODc=","number":6023,"title":"Allow for core block Inspector Controls to be extended and removed","user":{"login":"paulwilde","id":704594,"node_id":"MDQ6VXNlcjcwNDU5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/704594?v=4","gravatar_id":"","url":"https://api.github.com/users/paulwilde","html_url":"https://github.com/paulwilde","followers_url":"https://api.github.com/users/paulwilde/followers","following_url":"https://api.github.com/users/paulwilde/following{/other_user}","gists_url":"https://api.github.com/users/paulwilde/gists{/gist_id}","starred_url":"https://api.github.com/users/paulwilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulwilde/subscriptions","organizations_url":"https://api.github.com/users/paulwilde/orgs","repos_url":"https://api.github.com/users/paulwilde/repos","events_url":"https://api.github.com/users/paulwilde/events{/privacy}","received_events_url":"https://api.github.com/users/paulwilde/received_events","type":"User","site_admin":false},"labels":[{"id":631490822,"node_id":"MDU6TGFiZWw2MzE0OTA4MjI=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Extensibility","name":"Extensibility","color":"655104","default":false},{"id":531680828,"node_id":"MDU6TGFiZWw1MzE2ODA4Mjg=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Type]%20Question","name":"[Type] Question","color":"cc317c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-04-05T20:59:03Z","updated_at":"2018-10-04T18:47:15Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"For all client websites that I build I strip the WordPress admin down to the bare minimum as to reduce the burden and learning curve for my clients. This includes things like removing the Posts menu item if posts are not used on the site, and every meta box which aren't being used.\r\n\r\nOne big issue I'm struggling with Gutenberg at the moment in terms of extensibility, is that there's a bunch of inspector controls which I don't need, thus increasing said burden. A good example of this is the `core/paragraph` block, as that has a bunch of options allowing you to recreate a Geocities website where you can set inline background & font colours and whacky text sizes.\r\n\r\nAs there is currently no API or filter to remove the controls, I've had to resort to a bunch of sophistically CSS to simply `display: none` the Text Settings panel and recreate the options I want.\r\n\r\nAn idea for an API would be to wrap each control which gets rendered in the Text Settings panel inside a keyed array, where the value is the control component which gets rendered.\r\n\r\nUsing `core/gallery` as an example, due to it only having 3 controls currently, something like this:\r\n\r\n```\r\nlet controls = {\r\n setColumnsNumber: <RangeControl\r\n label={ __( 'Columns' ) }\r\n value={ columns }\r\n onChange={ this.setColumnsNumber }\r\n min={ 1 }\r\n max={ Math.min( MAX_COLUMNS, images.length ) }\r\n />,\r\n imageCrop: <ToggleControl\r\n label={ __( 'Crop Images' ) }\r\n checked={ !! imageCrop }\r\n onChange={ this.toggleImageCrop }\r\n />,\r\n linkTo: <SelectControl\r\n label={ __( 'Link to' ) }\r\n value={ linkTo }\r\n onChange={ this.setLinkTo }\r\n options={ linkOptions }\r\n />,\r\n};\r\ncontrols = applyFilters( 'blocks.inspectorControls', controls, this );\r\n```\r\n\r\nThen with such a pattern in place, one can easily remove controls as they desire. Assuming lodash is being used, this filter would remove the setColumnsNumber and imageCrop controls:\r\n\r\n```\r\nfunction removeGalleryControls( controls, block ) {\r\n if ( 'core/gallery' == block.props.name ) {\r\n return omit( controls, [ 'setColumnsNumber', 'imageCrop' ] );\r\n }\r\n return controls;\r\n}\r\naddFilter( 'blocks.inspectorControls', 'remove-gallery-controls', removeGalleryControls );\r\n``` \r\n\r\nThis filter would update the Columns control by changing the maximum range, and updating its label:\r\n\r\n```\r\nfunction replaceGalleryControl( controls, block ) {\r\n if ( 'core/gallery' == block.props.name ) {\r\n const { columns } = block.props.attributes\r\n \r\n controls.setColumnsNumber = <RangeControl\r\n label={ __( 'New Label!' ) }\r\n value={ columns }\r\n onChange={ block.setColumnsNumber }\r\n min={ 1 }\r\n max={ 3 }\r\n />;\r\n }\r\n return controls;\r\n}\r\naddFilter( 'blocks.inspectorControls', 'replace-gallery-control', replaceGalleryControl ); \r\n```\r\n\r\nAnd obviously reordering the controls along with adding additional ones should be quite evident at this point. Also it's easier to globally add controls to more than 1 block at a time which is an added advantage.\r\n\r\nIt's possible that there might be a cleaner or more React-like approach which allows for such extensibility, however I do believe it's quite a critical pain point prior to Gutenberg shipping."},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/427128735","html_url":"https://github.com/WordPress/gutenberg/issues/6023#issuecomment-427128735","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/6023","id":427128735,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzEyODczNQ==","user":{"login":"mrpritchett","id":3329081,"node_id":"MDQ6VXNlcjMzMjkwODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3329081?v=4","gravatar_id":"","url":"https://api.github.com/users/mrpritchett","html_url":"https://github.com/mrpritchett","followers_url":"https://api.github.com/users/mrpritchett/followers","following_url":"https://api.github.com/users/mrpritchett/following{/other_user}","gists_url":"https://api.github.com/users/mrpritchett/gists{/gist_id}","starred_url":"https://api.github.com/users/mrpritchett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrpritchett/subscriptions","organizations_url":"https://api.github.com/users/mrpritchett/orgs","repos_url":"https://api.github.com/users/mrpritchett/repos","events_url":"https://api.github.com/users/mrpritchett/events{/privacy}","received_events_url":"https://api.github.com/users/mrpritchett/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T18:47:15Z","updated_at":"2018-10-04T18:47:15Z","author_association":"NONE","body":"I honestly think having them extensible is a far better goal than a UI fix, but I guess it would be helpful in *some* cases for now?"}}
|
{
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
}
|
{
"id": 3329081,
"login": "mrpritchett",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3329081?",
"url": "https://api.github.com/users/mrpritchett"
}
|
{
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
}
| 2018-10-04T18:47:16 |
8369922561
|
{"actor":{"display_login":"mrpritchett"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/openemr/openemr/issues/1641","repository_url":"https://api.github.com/repos/openemr/openemr","labels_url":"https://api.github.com/repos/openemr/openemr/issues/1641/labels{/name}","comments_url":"https://api.github.com/repos/openemr/openemr/issues/1641/comments","events_url":"https://api.github.com/repos/openemr/openemr/issues/1641/events","html_url":"https://github.com/openemr/openemr/issues/1641","id":323666545,"number":1641,"title":"Usernames with dots.","user":{"login":"santiagosemhan","id":12011684,"avatar_url":"https://avatars0.githubusercontent.com/u/12011684?v=4","gravatar_id":"","url":"https://api.github.com/users/santiagosemhan","html_url":"https://github.com/santiagosemhan","followers_url":"https://api.github.com/users/santiagosemhan/followers","following_url":"https://api.github.com/users/santiagosemhan/following{/other_user}","gists_url":"https://api.github.com/users/santiagosemhan/gists{/gist_id}","starred_url":"https://api.github.com/users/santiagosemhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiagosemhan/subscriptions","organizations_url":"https://api.github.com/users/santiagosemhan/orgs","repos_url":"https://api.github.com/users/santiagosemhan/repos","events_url":"https://api.github.com/users/santiagosemhan/events{/privacy}","received_events_url":"https://api.github.com/users/santiagosemhan/received_events","type":"User","site_admin":false},"labels":[{"id":433468913,"url":"https://api.github.com/repos/openemr/openemr/labels/Bug","name":"Bug","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"bradymiller","id":278968,"avatar_url":"https://avatars1.githubusercontent.com/u/278968?v=4","gravatar_id":"","url":"https://api.github.com/users/bradymiller","html_url":"https://github.com/bradymiller","followers_url":"https://api.github.com/users/bradymiller/followers","following_url":"https://api.github.com/users/bradymiller/following{/other_user}","gists_url":"https://api.github.com/users/bradymiller/gists{/gist_id}","starred_url":"https://api.github.com/users/bradymiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradymiller/subscriptions","organizations_url":"https://api.github.com/users/bradymiller/orgs","repos_url":"https://api.github.com/users/bradymiller/repos","events_url":"https://api.github.com/users/bradymiller/events{/privacy}","received_events_url":"https://api.github.com/users/bradymiller/received_events","type":"User","site_admin":false},"assignees":[{"login":"bradymiller","id":278968,"avatar_url":"https://avatars1.githubusercontent.com/u/278968?v=4","gravatar_id":"","url":"https://api.github.com/users/bradymiller","html_url":"https://github.com/bradymiller","followers_url":"https://api.github.com/users/bradymiller/followers","following_url":"https://api.github.com/users/bradymiller/following{/other_user}","gists_url":"https://api.github.com/users/bradymiller/gists{/gist_id}","starred_url":"https://api.github.com/users/bradymiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradymiller/subscriptions","organizations_url":"https://api.github.com/users/bradymiller/orgs","repos_url":"https://api.github.com/users/bradymiller/repos","events_url":"https://api.github.com/users/bradymiller/events{/privacy}","received_events_url":"https://api.github.com/users/bradymiller/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openemr/openemr/milestones/2","html_url":"https://github.com/openemr/openemr/milestone/2","labels_url":"https://api.github.com/repos/openemr/openemr/milestones/2/labels","id":2395530,"number":2,"title":"5.0.1","description":"OpenEMR 5.0.1 Release","creator":{"login":"robertdown","id":1381170,"avatar_url":"https://avatars2.githubusercontent.com/u/1381170?v=4","gravatar_id":"","url":"https://api.github.com/users/robertdown","html_url":"https://github.com/robertdown","followers_url":"https://api.github.com/users/robertdown/followers","following_url":"https://api.github.com/users/robertdown/following{/other_user}","gists_url":"https://api.github.com/users/robertdown/gists{/gist_id}","starred_url":"https://api.github.com/users/robertdown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertdown/subscriptions","organizations_url":"https://api.github.com/users/robertdown/orgs","repos_url":"https://api.github.com/users/robertdown/repos","events_url":"https://api.github.com/users/robertdown/events{/privacy}","received_events_url":"https://api.github.com/users/robertdown/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":91,"state":"open","created_at":"2017-03-18T20:37:19Z","updated_at":"2018-05-18T07:25:44Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-05-16T15:14:13Z","updated_at":"2018-05-18T13:38:44Z","closed_at":null,"author_association":"NONE","body":"When you want to edit ACL's in user that have's dots in username, group lists are not showed. \r\nFor example: \r\nids generated with \"santiago.semhan\" cannot be selected with jquery. But, you can use \\\\ chars escapes. \r\n\r\nBug: $('#santiago.semhan')\r\nFix: $('#santiago\\\\.semhan')\r\n\r\nFile with bug: adminacl.php\r\nfunction: generic_click\r\n\r\nRegards."},"comment":{"url":"https://api.github.com/repos/openemr/openemr/issues/comments/390209886","html_url":"https://github.com/openemr/openemr/issues/1641#issuecomment-390209886","issue_url":"https://api.github.com/repos/openemr/openemr/issues/1641","id":390209886,"user":{"login":"santiagosemhan","id":12011684,"avatar_url":"https://avatars0.githubusercontent.com/u/12011684?v=4","gravatar_id":"","url":"https://api.github.com/users/santiagosemhan","html_url":"https://github.com/santiagosemhan","followers_url":"https://api.github.com/users/santiagosemhan/followers","following_url":"https://api.github.com/users/santiagosemhan/following{/other_user}","gists_url":"https://api.github.com/users/santiagosemhan/gists{/gist_id}","starred_url":"https://api.github.com/users/santiagosemhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiagosemhan/subscriptions","organizations_url":"https://api.github.com/users/santiagosemhan/orgs","repos_url":"https://api.github.com/users/santiagosemhan/repos","events_url":"https://api.github.com/users/santiagosemhan/events{/privacy}","received_events_url":"https://api.github.com/users/santiagosemhan/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T13:38:44Z","updated_at":"2018-05-18T13:38:44Z","author_association":"NONE","body":"Hi @bradymiller, you can commit for me. \r\nMy info: \r\n`Santiago Semhan <[email protected]>`"}}
|
{
"id": 679584,
"name": "openemr/openemr",
"url": "https://api.github.com/repos/openemr/openemr"
}
|
{
"id": 12011684,
"login": "santiagosemhan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12011684?",
"url": "https://api.github.com/users/santiagosemhan"
}
|
{
"id": 283089,
"login": "openemr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/283089?",
"url": "https://api.github.com/orgs/openemr"
}
| 2018-05-18T13:38:44 |
7695843118
|
{"actor":{"display_login":"santiagosemhan"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/numpy/numpy/issues/11805","repository_url":"https://api.github.com/repos/numpy/numpy","labels_url":"https://api.github.com/repos/numpy/numpy/issues/11805/labels{/name}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/11805/comments","events_url":"https://api.github.com/repos/numpy/numpy/issues/11805/events","html_url":"https://github.com/numpy/numpy/pull/11805","id":353174662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzAwMzc5","number":11805,"title":"BUG: add type cast check for ediff1d","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"labels":[{"id":6359214,"node_id":"MDU6TGFiZWw2MzU5MjE0","url":"https://api.github.com/repos/numpy/numpy/labels/00%20-%20Bug","name":"00 - Bug","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-08-23T00:33:26Z","updated_at":"2018-08-27T17:30:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/11805","html_url":"https://github.com/numpy/numpy/pull/11805","diff_url":"https://github.com/numpy/numpy/pull/11805.diff","patch_url":"https://github.com/numpy/numpy/pull/11805.patch"},"body":"Fixes #11490.\r\n\r\nThis is surprisingly tricky, because `ediff1d` is subject to certain constraints in the unit tests. And indeed, we'd need to be cautious with any kind of behavior change to fix that issue.\r\n\r\nConsider `test_ediff1d`:\r\n\r\n```Python\r\nzero_elem = np.array([]) # this defaults to float64\r\nassert_array_equal([0], ediff1d(zero_elem, to_begin=0))\r\n# np.asanyarray([0]) and np.array([0]) are int64\r\n```\r\n\r\nIf I apply type checking preservation on `zero_elem` -> returned value there it will fail because the prepend and expected test objects are both `int64`. Maybe int->float promotion should be allowed but the reverse (which happens in the linked issue) prohibited?\r\n\r\nI thought an alternative solution might be to offload type promotion handling to `np.append()`, but that will fail unit tests because we do sometimes check for type passthrough on the input `ary` object:\r\n\r\n```Python\r\nassert(isinstance(np.ediff1d(np.matrix(1), to_begin=1), np.matrix))\r\n# np.append(np.asanyarray(1), np.matrix(1)).dtype is 'int64' for example,\r\n# although this gives a different result too\r\n# same for: np.append(np.asanyarray(1), np.ediff1d(np.matrix(1))).dtype\r\n# here the result is closer but an array instead of matrix\r\n```\r\n\r\nI wonder why `ediff1d` even has those `to_begin` and `to_end` arguments--is there actually an explicit intention to have this behave differently from i.e., `append()` as far as type handling goes? It looks like this may be cut out for matrix handling in particular maybe?\r\n\r\nThe docstring for `ediff1d` isn't so clear on matters of type handling / casting / promotion as far as I can tell, and the current unit tests don't necessarily steer me toward any single clear solution so maybe I need a bit of guidance here."},"comment":{"url":"https://api.github.com/repos/numpy/numpy/issues/comments/416303329","html_url":"https://github.com/numpy/numpy/pull/11805#issuecomment-416303329","issue_url":"https://api.github.com/repos/numpy/numpy/issues/11805","id":416303329,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjMwMzMyOQ==","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T17:30:10Z","updated_at":"2018-08-27T17:30:10Z","author_association":"CONTRIBUTOR","body":"Ok, I followed up with the mailing list & linked a similar discussion on stack overflow about np.diff vs ediff1d."}}
|
{
"id": 908607,
"name": "numpy/numpy",
"url": "https://api.github.com/repos/numpy/numpy"
}
|
{
"id": 7903078,
"login": "tylerjereddy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7903078?",
"url": "https://api.github.com/users/tylerjereddy"
}
|
{
"id": 288276,
"login": "numpy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/288276?",
"url": "https://api.github.com/orgs/numpy"
}
| 2018-08-27T17:30:10 |
8173370262
|
{"actor":{"display_login":"tylerjereddy"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/9139","repository_url":"https://api.github.com/repos/scipy/scipy","labels_url":"https://api.github.com/repos/scipy/scipy/issues/9139/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/9139/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/9139/events","html_url":"https://github.com/scipy/scipy/pull/9139","id":350123640,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDQ5Nzkw","number":9139,"title":"FIX: Doctest failure in optimize tutorial","user":{"login":"ilayn","id":1303842,"node_id":"MDQ6VXNlcjEzMDM4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1303842?v=4","gravatar_id":"","url":"https://api.github.com/users/ilayn","html_url":"https://github.com/ilayn","followers_url":"https://api.github.com/users/ilayn/followers","following_url":"https://api.github.com/users/ilayn/following{/other_user}","gists_url":"https://api.github.com/users/ilayn/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayn/subscriptions","organizations_url":"https://api.github.com/users/ilayn/orgs","repos_url":"https://api.github.com/users/ilayn/repos","events_url":"https://api.github.com/users/ilayn/events{/privacy}","received_events_url":"https://api.github.com/users/ilayn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-13T17:33:25Z","updated_at":"2018-08-13T19:18:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/9139","html_url":"https://github.com/scipy/scipy/pull/9139","diff_url":"https://github.com/scipy/scipy/pull/9139.diff","patch_url":"https://github.com/scipy/scipy/pull/9139.patch"},"body":"Fixes the doctest result for #9131 "},"comment":{"url":"https://api.github.com/repos/scipy/scipy/issues/comments/412632796","html_url":"https://github.com/scipy/scipy/pull/9139#issuecomment-412632796","issue_url":"https://api.github.com/repos/scipy/scipy/issues/9139","id":412632796,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjYzMjc5Ng==","user":{"login":"ilayn","id":1303842,"node_id":"MDQ6VXNlcjEzMDM4NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1303842?v=4","gravatar_id":"","url":"https://api.github.com/users/ilayn","html_url":"https://github.com/ilayn","followers_url":"https://api.github.com/users/ilayn/followers","following_url":"https://api.github.com/users/ilayn/following{/other_user}","gists_url":"https://api.github.com/users/ilayn/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayn/subscriptions","organizations_url":"https://api.github.com/users/ilayn/orgs","repos_url":"https://api.github.com/users/ilayn/repos","events_url":"https://api.github.com/users/ilayn/events{/privacy}","received_events_url":"https://api.github.com/users/ilayn/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T19:18:40Z","updated_at":"2018-08-13T19:18:40Z","author_association":"MEMBER","body":"Hmm, I can't really understand why things fail for the number printing part anymore."}}
|
{
"id": 1460385,
"name": "scipy/scipy",
"url": "https://api.github.com/repos/scipy/scipy"
}
|
{
"id": 1303842,
"login": "ilayn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1303842?",
"url": "https://api.github.com/users/ilayn"
}
|
{
"id": 288277,
"login": "scipy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/288277?",
"url": "https://api.github.com/orgs/scipy"
}
| 2018-08-13T19:18:40 |
8106986532
|
{"actor":{"display_login":"ilayn"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/8745","repository_url":"https://api.github.com/repos/scipy/scipy","labels_url":"https://api.github.com/repos/scipy/scipy/issues/8745/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/8745/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/8745/events","html_url":"https://github.com/scipy/scipy/issues/8745","id":314772575,"number":8745,"title":"scipy.signal.chirp problem","user":{"login":"art4206","id":38438950,"avatar_url":"https://avatars3.githubusercontent.com/u/38438950?v=4","gravatar_id":"","url":"https://api.github.com/users/art4206","html_url":"https://github.com/art4206","followers_url":"https://api.github.com/users/art4206/followers","following_url":"https://api.github.com/users/art4206/following{/other_user}","gists_url":"https://api.github.com/users/art4206/gists{/gist_id}","starred_url":"https://api.github.com/users/art4206/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/art4206/subscriptions","organizations_url":"https://api.github.com/users/art4206/orgs","repos_url":"https://api.github.com/users/art4206/repos","events_url":"https://api.github.com/users/art4206/events{/privacy}","received_events_url":"https://api.github.com/users/art4206/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-16T18:42:39Z","updated_at":"2018-04-16T19:10:46Z","closed_at":null,"author_association":"NONE","body":"Scipy.signal.chirp produces strange looking frequency sweep - see figure and example code below.\r\n\r\n\r\n\r\n Looking at the source code for Scipy.signal.chirp pasted below:\r\n # 'phase' is computed in _chirp_phase, to make testing easier.\r\n phase = _chirp_phase(t, f0, t1, f1, method, vertex_zero)\r\n # Convert phi to radians.\r\n phi *= pi / 180\r\n return cos(phase + phi)\r\n\r\nThe phase from _chirp_phase should be converted from degrees to radians for numpy.cos to work correctly.\r\n\r\n### Reproducing code example:\r\n```\r\nimport os\r\nimport numpy as N\r\nimport matplotlib.pyplot as plt\r\nfrom scipy.signal import chirp\r\n\r\nfStart = 5\r\nfStop = 10005\r\nscanTime = (8 * 60.)\r\nfCycles = (fStop-fStart)/scanTime\r\nnumPoints = 600000\r\nstepTime = scanTime/numPoints\r\nt = N.linspace(0, scanTime, numPoints)\r\npulseSeq = chirp(t, f0=fStart, f1=fStop, t1 = scanTime, method = 'linear')\r\nplt.plot(t,pulseSeq)\r\nplt.show()\r\n\r\n```\r\n\r\n### Error message:\r\n```\r\nThe phase from _chirp_phase should be converted from degrees to radians for numpy.cos to work correctly.\r\n```\r\n\r\n### Scipy/Numpy/Python version information:\r\n```\r\n('1.0.0', '1.14.0', sys.version_info(major=2, minor=7, micro=14, releaselevel='final', serial=0))\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/scipy/scipy/issues/comments/381716296","html_url":"https://github.com/scipy/scipy/issues/8745#issuecomment-381716296","issue_url":"https://api.github.com/repos/scipy/scipy/issues/8745","id":381716296,"user":{"login":"rkern","id":46135,"avatar_url":"https://avatars3.githubusercontent.com/u/46135?v=4","gravatar_id":"","url":"https://api.github.com/users/rkern","html_url":"https://github.com/rkern","followers_url":"https://api.github.com/users/rkern/followers","following_url":"https://api.github.com/users/rkern/following{/other_user}","gists_url":"https://api.github.com/users/rkern/gists{/gist_id}","starred_url":"https://api.github.com/users/rkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkern/subscriptions","organizations_url":"https://api.github.com/users/rkern/orgs","repos_url":"https://api.github.com/users/rkern/repos","events_url":"https://api.github.com/users/rkern/events{/privacy}","received_events_url":"https://api.github.com/users/rkern/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T19:10:46Z","updated_at":"2018-04-16T19:10:46Z","author_association":"OWNER","body":"The phase returned from `_chirp_phase()` is already in radians, not degrees."}}
|
{
"id": 1460385,
"name": "scipy/scipy",
"url": "https://api.github.com/repos/scipy/scipy"
}
|
{
"id": 46135,
"login": "rkern",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46135?",
"url": "https://api.github.com/users/rkern"
}
|
{
"id": 288277,
"login": "scipy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/288277?",
"url": "https://api.github.com/orgs/scipy"
}
| 2018-04-16T19:10:46 |
7538097904
|
{"actor":{"display_login":"rkern"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/652","repository_url":"https://api.github.com/repos/gooddata/gooddata-react-components","labels_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/652/labels{/name}","comments_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/652/comments","events_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/652/events","html_url":"https://github.com/gooddata/gooddata-react-components/pull/652","id":380225194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDc0NDYx","number":652,"title":"RELATED: FET-24 discarded indigo theme","user":{"login":"strouhaljan","id":11704538,"node_id":"MDQ6VXNlcjExNzA0NTM4","avatar_url":"https://avatars0.githubusercontent.com/u/11704538?v=4","gravatar_id":"","url":"https://api.github.com/users/strouhaljan","html_url":"https://github.com/strouhaljan","followers_url":"https://api.github.com/users/strouhaljan/followers","following_url":"https://api.github.com/users/strouhaljan/following{/other_user}","gists_url":"https://api.github.com/users/strouhaljan/gists{/gist_id}","starred_url":"https://api.github.com/users/strouhaljan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strouhaljan/subscriptions","organizations_url":"https://api.github.com/users/strouhaljan/orgs","repos_url":"https://api.github.com/users/strouhaljan/repos","events_url":"https://api.github.com/users/strouhaljan/events{/privacy}","received_events_url":"https://api.github.com/users/strouhaljan/received_events","type":"User","site_admin":false},"labels":[{"id":600734146,"node_id":"MDU6TGFiZWw2MDA3MzQxNDY=","url":"https://api.github.com/repos/gooddata/gooddata-react-components/labels/do%20not%20merge","name":"do not merge","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-11-13T13:27:26Z","updated_at":"2018-12-05T21:31:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/652","html_url":"https://github.com/gooddata/gooddata-react-components/pull/652","diff_url":"https://github.com/gooddata/gooddata-react-components/pull/652.diff","patch_url":"https://github.com/gooddata/gooddata-react-components/pull/652.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/comments/444656664","html_url":"https://github.com/gooddata/gooddata-react-components/pull/652#issuecomment-444656664","issue_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/652","id":444656664,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDY1NjY2NA==","user":{"login":"yenkins","id":1506393,"node_id":"MDQ6VXNlcjE1MDYzOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1506393?v=4","gravatar_id":"","url":"https://api.github.com/users/yenkins","html_url":"https://github.com/yenkins","followers_url":"https://api.github.com/users/yenkins/followers","following_url":"https://api.github.com/users/yenkins/following{/other_user}","gists_url":"https://api.github.com/users/yenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/yenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenkins/subscriptions","organizations_url":"https://api.github.com/users/yenkins/orgs","repos_url":"https://api.github.com/users/yenkins/repos","events_url":"https://api.github.com/users/yenkins/events{/privacy}","received_events_url":"https://api.github.com/users/yenkins/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T21:31:01Z","updated_at":"2018-12-05T21:31:01Z","author_association":"NONE","body":"Link to Storybook test result:\n\nhttps://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-storybook-zuul-docker/926/artifact/test-storybook/html-report/index.html\n"}}
|
{
"id": 90664084,
"name": "gooddata/gooddata-react-components",
"url": "https://api.github.com/repos/gooddata/gooddata-react-components"
}
|
{
"id": 1506393,
"login": "yenkins",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1506393?",
"url": "https://api.github.com/users/yenkins"
}
|
{
"id": 291394,
"login": "gooddata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/291394?",
"url": "https://api.github.com/orgs/gooddata"
}
| 2018-12-05T21:31:01 |
8705149339
|
{"actor":{"display_login":"yenkins"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1252","repository_url":"https://api.github.com/repos/gooddata/gooddata-ruby","labels_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1252/labels{/name}","comments_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1252/comments","events_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1252/events","html_url":"https://github.com/gooddata/gooddata-ruby/pull/1252","id":341121821,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzcwNjAz","number":1252,"title":"Isolate monkey patches","user":{"login":"henrich-m","id":3842497,"node_id":"MDQ6VXNlcjM4NDI0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3842497?v=4","gravatar_id":"","url":"https://api.github.com/users/henrich-m","html_url":"https://github.com/henrich-m","followers_url":"https://api.github.com/users/henrich-m/followers","following_url":"https://api.github.com/users/henrich-m/following{/other_user}","gists_url":"https://api.github.com/users/henrich-m/gists{/gist_id}","starred_url":"https://api.github.com/users/henrich-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrich-m/subscriptions","organizations_url":"https://api.github.com/users/henrich-m/orgs","repos_url":"https://api.github.com/users/henrich-m/repos","events_url":"https://api.github.com/users/henrich-m/events{/privacy}","received_events_url":"https://api.github.com/users/henrich-m/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-13T18:45:10Z","updated_at":"2018-07-13T19:41:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1252","html_url":"https://github.com/gooddata/gooddata-ruby/pull/1252","diff_url":"https://github.com/gooddata/gooddata-ruby/pull/1252.diff","patch_url":"https://github.com/gooddata/gooddata-ruby/pull/1252.patch"},"body":"Isolate all monkey patchs in modules so it be applied only in the needed context."},"comment":{"url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/comments/404933904","html_url":"https://github.com/gooddata/gooddata-ruby/pull/1252#issuecomment-404933904","issue_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1252","id":404933904,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDkzMzkwNA==","user":{"login":"gdgate","id":16560457,"node_id":"MDQ6VXNlcjE2NTYwNDU3","avatar_url":"https://avatars2.githubusercontent.com/u/16560457?v=4","gravatar_id":"","url":"https://api.github.com/users/gdgate","html_url":"https://github.com/gdgate","followers_url":"https://api.github.com/users/gdgate/followers","following_url":"https://api.github.com/users/gdgate/following{/other_user}","gists_url":"https://api.github.com/users/gdgate/gists{/gist_id}","starred_url":"https://api.github.com/users/gdgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdgate/subscriptions","organizations_url":"https://api.github.com/users/gdgate/orgs","repos_url":"https://api.github.com/users/gdgate/repos","events_url":"https://api.github.com/users/gdgate/events{/privacy}","received_events_url":"https://api.github.com/users/gdgate/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T19:41:24Z","updated_at":"2018-07-13T19:41:24Z","author_association":"CONTRIBUTOR","body":"Build failed (check pipeline).\n\n- https://checklist.intgdc.com/job/compliance/job/gooddata-ruby-opensource-repository-check/359/ : Tests on opensource repositories should be triggered by users in `gooddata` organization in 12s\n- gooddata-ruby-pronto-code-review-zuul : SKIPPED\n- gooddata-ruby-unit-tests-zuul : SKIPPED\n"}}
|
{
"id": 891109,
"name": "gooddata/gooddata-ruby",
"url": "https://api.github.com/repos/gooddata/gooddata-ruby"
}
|
{
"id": 16560457,
"login": "gdgate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16560457?",
"url": "https://api.github.com/users/gdgate"
}
|
{
"id": 291394,
"login": "gooddata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/291394?",
"url": "https://api.github.com/orgs/gooddata"
}
| 2018-07-13T19:41:24 |
7963999922
|
{"actor":{"display_login":"gdgate"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/595","repository_url":"https://api.github.com/repos/gooddata/gooddata-react-components","labels_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/595/labels{/name}","comments_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/595/comments","events_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/595/events","html_url":"https://github.com/gooddata/gooddata-react-components/pull/595","id":369011975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDUxNDI4","number":595,"title":"RELATED: BB-1271 Fixed tables totals popup position","user":{"login":"yanlipnican","id":5691867,"node_id":"MDQ6VXNlcjU2OTE4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/5691867?v=4","gravatar_id":"","url":"https://api.github.com/users/yanlipnican","html_url":"https://github.com/yanlipnican","followers_url":"https://api.github.com/users/yanlipnican/followers","following_url":"https://api.github.com/users/yanlipnican/following{/other_user}","gists_url":"https://api.github.com/users/yanlipnican/gists{/gist_id}","starred_url":"https://api.github.com/users/yanlipnican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanlipnican/subscriptions","organizations_url":"https://api.github.com/users/yanlipnican/orgs","repos_url":"https://api.github.com/users/yanlipnican/repos","events_url":"https://api.github.com/users/yanlipnican/events{/privacy}","received_events_url":"https://api.github.com/users/yanlipnican/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-11T08:40:17Z","updated_at":"2018-10-11T09:09:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/595","html_url":"https://github.com/gooddata/gooddata-react-components/pull/595","diff_url":"https://github.com/gooddata/gooddata-react-components/pull/595.diff","patch_url":"https://github.com/gooddata/gooddata-react-components/pull/595.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/comments/428880314","html_url":"https://github.com/gooddata/gooddata-react-components/pull/595#issuecomment-428880314","issue_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/595","id":428880314,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODg4MDMxNA==","user":{"login":"gdgate","id":16560457,"node_id":"MDQ6VXNlcjE2NTYwNDU3","avatar_url":"https://avatars2.githubusercontent.com/u/16560457?v=4","gravatar_id":"","url":"https://api.github.com/users/gdgate","html_url":"https://github.com/gdgate","followers_url":"https://api.github.com/users/gdgate/followers","following_url":"https://api.github.com/users/gdgate/following{/other_user}","gists_url":"https://api.github.com/users/gdgate/gists{/gist_id}","starred_url":"https://api.github.com/users/gdgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdgate/subscriptions","organizations_url":"https://api.github.com/users/gdgate/orgs","repos_url":"https://api.github.com/users/gdgate/repos","events_url":"https://api.github.com/users/gdgate/events{/privacy}","received_events_url":"https://api.github.com/users/gdgate/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T09:09:19Z","updated_at":"2018-10-11T09:09:19Z","author_association":"CONTRIBUTOR","body":"Build succeeded (check-extended pipeline).\n\n- https://checklist.intgdc.com/job/compliance/job/gooddata-react-components-opensource-repository-check/1732/ : SUCCESS in 12s\n- https://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-pull-request-dispatcher/377/ : SUCCESS in 19m 31s\n"}}
|
{
"id": 90664084,
"name": "gooddata/gooddata-react-components",
"url": "https://api.github.com/repos/gooddata/gooddata-react-components"
}
|
{
"id": 16560457,
"login": "gdgate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16560457?",
"url": "https://api.github.com/users/gdgate"
}
|
{
"id": 291394,
"login": "gooddata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/291394?",
"url": "https://api.github.com/orgs/gooddata"
}
| 2018-10-11T09:09:23 |
8403211427
|
{"actor":{"display_login":"gdgate"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/531","repository_url":"https://api.github.com/repos/gooddata/gooddata-react-components","labels_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/531/labels{/name}","comments_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/531/comments","events_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/531/events","html_url":"https://github.com/gooddata/gooddata-react-components/pull/531","id":358947796,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NTU3Mzg1","number":531,"title":"merge master to next 6.0.0","user":{"login":"tomasreichmann","id":10447001,"node_id":"MDQ6VXNlcjEwNDQ3MDAx","avatar_url":"https://avatars0.githubusercontent.com/u/10447001?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasreichmann","html_url":"https://github.com/tomasreichmann","followers_url":"https://api.github.com/users/tomasreichmann/followers","following_url":"https://api.github.com/users/tomasreichmann/following{/other_user}","gists_url":"https://api.github.com/users/tomasreichmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasreichmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasreichmann/subscriptions","organizations_url":"https://api.github.com/users/tomasreichmann/orgs","repos_url":"https://api.github.com/users/tomasreichmann/repos","events_url":"https://api.github.com/users/tomasreichmann/events{/privacy}","received_events_url":"https://api.github.com/users/tomasreichmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-11T08:50:08Z","updated_at":"2018-09-11T09:26:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/pulls/531","html_url":"https://github.com/gooddata/gooddata-react-components/pull/531","diff_url":"https://github.com/gooddata/gooddata-react-components/pull/531.diff","patch_url":"https://github.com/gooddata/gooddata-react-components/pull/531.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/comments/420208476","html_url":"https://github.com/gooddata/gooddata-react-components/pull/531#issuecomment-420208476","issue_url":"https://api.github.com/repos/gooddata/gooddata-react-components/issues/531","id":420208476,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDIwODQ3Ng==","user":{"login":"gdgate","id":16560457,"node_id":"MDQ6VXNlcjE2NTYwNDU3","avatar_url":"https://avatars2.githubusercontent.com/u/16560457?v=4","gravatar_id":"","url":"https://api.github.com/users/gdgate","html_url":"https://github.com/gdgate","followers_url":"https://api.github.com/users/gdgate/followers","following_url":"https://api.github.com/users/gdgate/following{/other_user}","gists_url":"https://api.github.com/users/gdgate/gists{/gist_id}","starred_url":"https://api.github.com/users/gdgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdgate/subscriptions","organizations_url":"https://api.github.com/users/gdgate/orgs","repos_url":"https://api.github.com/users/gdgate/repos","events_url":"https://api.github.com/users/gdgate/events{/privacy}","received_events_url":"https://api.github.com/users/gdgate/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T09:26:40Z","updated_at":"2018-09-11T09:26:40Z","author_association":"CONTRIBUTOR","body":"Build failed (gate pipeline).\n\n- https://checklist.intgdc.com/job/compliance/job/gooddata-react-components-merge-compliance-check/291/ : SUCCESS in 52s\n- https://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-unit-tests-zuul-docker-el7/889/ : SUCCESS in 3m 31s\n- https://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-storybook-zuul-docker/501/ : FAILURE in 5m 31s\n- https://checklist.intgdc.com/job/client-libs/job/gooddata-react-components-examples-zuul-docker/196/ : SUCCESS in 13m 06s\n"}}
|
{
"id": 90664084,
"name": "gooddata/gooddata-react-components",
"url": "https://api.github.com/repos/gooddata/gooddata-react-components"
}
|
{
"id": 16560457,
"login": "gdgate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16560457?",
"url": "https://api.github.com/users/gdgate"
}
|
{
"id": 291394,
"login": "gooddata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/291394?",
"url": "https://api.github.com/orgs/gooddata"
}
| 2018-09-11T09:26:41 |
8245351070
|
{"actor":{"display_login":"gdgate"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2447","repository_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2447/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2447/comments","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2447/events","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2447","id":360775432,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTExMzUz","number":2447,"title":"EZP-29586: Content copied by another user is still owned by original creator","user":{"login":"ViniTou","id":19517274,"node_id":"MDQ6VXNlcjE5NTE3Mjc0","avatar_url":"https://avatars1.githubusercontent.com/u/19517274?v=4","gravatar_id":"","url":"https://api.github.com/users/ViniTou","html_url":"https://github.com/ViniTou","followers_url":"https://api.github.com/users/ViniTou/followers","following_url":"https://api.github.com/users/ViniTou/following{/other_user}","gists_url":"https://api.github.com/users/ViniTou/gists{/gist_id}","starred_url":"https://api.github.com/users/ViniTou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViniTou/subscriptions","organizations_url":"https://api.github.com/users/ViniTou/orgs","repos_url":"https://api.github.com/users/ViniTou/repos","events_url":"https://api.github.com/users/ViniTou/events{/privacy}","received_events_url":"https://api.github.com/users/ViniTou/received_events","type":"User","site_admin":false},"labels":[{"id":430933236,"node_id":"MDU6TGFiZWw0MzA5MzMyMzY=","url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/labels/Ready%20for%20QA","name":"Ready for QA","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"micszo","id":13622502,"node_id":"MDQ6VXNlcjEzNjIyNTAy","avatar_url":"https://avatars1.githubusercontent.com/u/13622502?v=4","gravatar_id":"","url":"https://api.github.com/users/micszo","html_url":"https://github.com/micszo","followers_url":"https://api.github.com/users/micszo/followers","following_url":"https://api.github.com/users/micszo/following{/other_user}","gists_url":"https://api.github.com/users/micszo/gists{/gist_id}","starred_url":"https://api.github.com/users/micszo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micszo/subscriptions","organizations_url":"https://api.github.com/users/micszo/orgs","repos_url":"https://api.github.com/users/micszo/repos","events_url":"https://api.github.com/users/micszo/events{/privacy}","received_events_url":"https://api.github.com/users/micszo/received_events","type":"User","site_admin":false},"assignees":[{"login":"micszo","id":13622502,"node_id":"MDQ6VXNlcjEzNjIyNTAy","avatar_url":"https://avatars1.githubusercontent.com/u/13622502?v=4","gravatar_id":"","url":"https://api.github.com/users/micszo","html_url":"https://github.com/micszo","followers_url":"https://api.github.com/users/micszo/followers","following_url":"https://api.github.com/users/micszo/following{/other_user}","gists_url":"https://api.github.com/users/micszo/gists{/gist_id}","starred_url":"https://api.github.com/users/micszo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micszo/subscriptions","organizations_url":"https://api.github.com/users/micszo/orgs","repos_url":"https://api.github.com/users/micszo/repos","events_url":"https://api.github.com/users/micszo/events{/privacy}","received_events_url":"https://api.github.com/users/micszo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-09-17T08:55:54Z","updated_at":"2018-10-05T12:47:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2447","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2447","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2447.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2447.patch"},"body":"| Question | Answer\r\n| ------------------ | ------------------\r\n| **JIRA issue** | [EZP-29586](https://jira.ez.no/browse/EZP-29586)\r\n| **Bug/Improvement**| yes\r\n| **New feature** | no\r\n| **Target version** | `6.7`\r\n| **BC breaks** | no\r\n| **Tests pass** | yes\r\n| **Doc needed** | no\r\n\r\nNew owner is set for very copied content via `copy` or `copySubtree` method.\r\n\r\n**TODO**:\r\n- [x] Implement feature / fix a bug.\r\n- [x] Implement tests.\r\n- [x] Fix new code according to Coding Standards (`$ composer fix-cs`).\r\n- [x] Ask for Code Review.\r\n"},"comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments/427354399","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2447#issuecomment-427354399","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2447","id":427354399,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzM1NDM5OQ==","user":{"login":"andrerom","id":289757,"node_id":"MDQ6VXNlcjI4OTc1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/289757?v=4","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T12:47:16Z","updated_at":"2018-10-05T12:47:16Z","author_association":"MEMBER","body":"> @ViniTou not yet, so far have checked 1.7.8 and 1.13.4. Working on it.\r\n\r\ngood point, check 2.x. I think 1.x might be doing things in this regards quite a lot different."}}
|
{
"id": 1663890,
"name": "ezsystems/ezpublish-kernel",
"url": "https://api.github.com/repos/ezsystems/ezpublish-kernel"
}
|
{
"id": 289757,
"login": "andrerom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/289757?",
"url": "https://api.github.com/users/andrerom"
}
|
{
"id": 295311,
"login": "ezsystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/295311?",
"url": "https://api.github.com/orgs/ezsystems"
}
| 2018-10-05T12:47:16 |
8374125577
|
{"actor":{"display_login":"andrerom"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/issues/71","repository_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules","labels_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/issues/71/comments","events_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/issues/71/events","html_url":"https://github.com/ezsystems/ezplatform-admin-ui-modules/pull/71","id":333997508,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDc2NTM2","number":71,"title":"EZP-29319: I want to know that Confirmed items in UDW are clickable","user":{"login":"tischsoic","id":10233057,"node_id":"MDQ6VXNlcjEwMjMzMDU3","avatar_url":"https://avatars3.githubusercontent.com/u/10233057?v=4","gravatar_id":"","url":"https://api.github.com/users/tischsoic","html_url":"https://github.com/tischsoic","followers_url":"https://api.github.com/users/tischsoic/followers","following_url":"https://api.github.com/users/tischsoic/following{/other_user}","gists_url":"https://api.github.com/users/tischsoic/gists{/gist_id}","starred_url":"https://api.github.com/users/tischsoic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tischsoic/subscriptions","organizations_url":"https://api.github.com/users/tischsoic/orgs","repos_url":"https://api.github.com/users/tischsoic/repos","events_url":"https://api.github.com/users/tischsoic/events{/privacy}","received_events_url":"https://api.github.com/users/tischsoic/received_events","type":"User","site_admin":false},"labels":[{"id":702036673,"node_id":"MDU6TGFiZWw3MDIwMzY2NzM=","url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/labels/bug","name":"bug","color":"ee0701","default":true},{"id":702036675,"node_id":"MDU6TGFiZWw3MDIwMzY2NzU=","url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":752192148,"node_id":"MDU6TGFiZWw3NTIxOTIxNDg=","url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/labels/ready-for-review","name":"ready-for-review","color":"a2a7e5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-20T09:33:28Z","updated_at":"2018-06-20T11:32:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/pulls/71","html_url":"https://github.com/ezsystems/ezplatform-admin-ui-modules/pull/71","diff_url":"https://github.com/ezsystems/ezplatform-admin-ui-modules/pull/71.diff","patch_url":"https://github.com/ezsystems/ezplatform-admin-ui-modules/pull/71.patch"},"body":"https://jira.ez.no/browse/EZP-29319"},"comment":{"url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/issues/comments/398717855","html_url":"https://github.com/ezsystems/ezplatform-admin-ui-modules/pull/71#issuecomment-398717855","issue_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules/issues/71","id":398717855,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODcxNzg1NQ==","user":{"login":"sunpietro","id":1736658,"node_id":"MDQ6VXNlcjE3MzY2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1736658?v=4","gravatar_id":"","url":"https://api.github.com/users/sunpietro","html_url":"https://github.com/sunpietro","followers_url":"https://api.github.com/users/sunpietro/followers","following_url":"https://api.github.com/users/sunpietro/following{/other_user}","gists_url":"https://api.github.com/users/sunpietro/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpietro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpietro/subscriptions","organizations_url":"https://api.github.com/users/sunpietro/orgs","repos_url":"https://api.github.com/users/sunpietro/repos","events_url":"https://api.github.com/users/sunpietro/events{/privacy}","received_events_url":"https://api.github.com/users/sunpietro/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T11:32:54Z","updated_at":"2018-06-20T11:32:54Z","author_association":"MEMBER","body":"@tischsoic at first, you should focus only on fixing the issue making as little changes as possible. Then in the separate PR, you might do some code refactoring and there we'll discuss your new approach. Is it ok for you?"}}
|
{
"id": 104727433,
"name": "ezsystems/ezplatform-admin-ui-modules",
"url": "https://api.github.com/repos/ezsystems/ezplatform-admin-ui-modules"
}
|
{
"id": 1736658,
"login": "sunpietro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1736658?",
"url": "https://api.github.com/users/sunpietro"
}
|
{
"id": 295311,
"login": "ezsystems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/295311?",
"url": "https://api.github.com/orgs/ezsystems"
}
| 2018-06-20T11:32:54 |
7851383898
|
{"actor":{"display_login":"sunpietro"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/blueprint/issues/2874","repository_url":"https://api.github.com/repos/palantir/blueprint","labels_url":"https://api.github.com/repos/palantir/blueprint/issues/2874/labels{/name}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/2874/comments","events_url":"https://api.github.com/repos/palantir/blueprint/issues/2874/events","html_url":"https://github.com/palantir/blueprint/pull/2874","id":354800721,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDc3MTAz","number":2874,"title":"[Suggest] Added selectedItem prop","user":{"login":"danilotorrisi","id":608595,"node_id":"MDQ6VXNlcjYwODU5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/608595?v=4","gravatar_id":"","url":"https://api.github.com/users/danilotorrisi","html_url":"https://github.com/danilotorrisi","followers_url":"https://api.github.com/users/danilotorrisi/followers","following_url":"https://api.github.com/users/danilotorrisi/following{/other_user}","gists_url":"https://api.github.com/users/danilotorrisi/gists{/gist_id}","starred_url":"https://api.github.com/users/danilotorrisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilotorrisi/subscriptions","organizations_url":"https://api.github.com/users/danilotorrisi/orgs","repos_url":"https://api.github.com/users/danilotorrisi/repos","events_url":"https://api.github.com/users/danilotorrisi/events{/privacy}","received_events_url":"https://api.github.com/users/danilotorrisi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-08-28T16:06:54Z","updated_at":"2018-09-05T17:54:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/2874","html_url":"https://github.com/palantir/blueprint/pull/2874","diff_url":"https://github.com/palantir/blueprint/pull/2874.diff","patch_url":"https://github.com/palantir/blueprint/pull/2874.patch"},"body":"#### Fixes #2784\r\n\r\n#### Checklist\r\n<!-- fill this section out if necessary, remove it otherwise -->\r\n\r\n- [x] [Enable CircleCI for your fork](https://circleci.com/add-projects)\r\n- [ ] Include tests\r\n- [ ] Update documentation\r\n\r\n#### Changes proposed in this pull request:\r\n\r\nFixes #2784.\r\n\r\n#### Reviewers should focus on:\r\n\r\nThe `Suggest` component now takes an optional selectedItem prop. If defined the selectedItem state will be initialised with the given selectedItem.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/palantir/blueprint/issues/comments/418822349","html_url":"https://github.com/palantir/blueprint/pull/2874#issuecomment-418822349","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/2874","id":418822349,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODgyMjM0OQ==","user":{"login":"danilotorrisi","id":608595,"node_id":"MDQ6VXNlcjYwODU5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/608595?v=4","gravatar_id":"","url":"https://api.github.com/users/danilotorrisi","html_url":"https://github.com/danilotorrisi","followers_url":"https://api.github.com/users/danilotorrisi/followers","following_url":"https://api.github.com/users/danilotorrisi/following{/other_user}","gists_url":"https://api.github.com/users/danilotorrisi/gists{/gist_id}","starred_url":"https://api.github.com/users/danilotorrisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilotorrisi/subscriptions","organizations_url":"https://api.github.com/users/danilotorrisi/orgs","repos_url":"https://api.github.com/users/danilotorrisi/repos","events_url":"https://api.github.com/users/danilotorrisi/events{/privacy}","received_events_url":"https://api.github.com/users/danilotorrisi/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T17:54:51Z","updated_at":"2018-09-05T17:54:51Z","author_association":"NONE","body":"<h3>prop docs</h3>\n\nPreview: <strong><a href='https://79-146469272-gh.circle-artifacts.com/0/home/circleci/project/packages/docs-app/dist/index.html' target='_blank'>documentation</a> | <a href='https://79-146469272-gh.circle-artifacts.com/0/home/circleci/project/packages/landing-app/dist/index.html' target='_blank'>landing</a> | <a href='https://79-146469272-gh.circle-artifacts.com/0/home/circleci/project/packages/table-dev-app/dist/index.html' target='_blank'>table</a></strong>"}}
|
{
"id": 71939872,
"name": "palantir/blueprint",
"url": "https://api.github.com/repos/palantir/blueprint"
}
|
{
"id": 608595,
"login": "danilotorrisi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/608595?",
"url": "https://api.github.com/users/danilotorrisi"
}
|
{
"id": 303157,
"login": "palantir",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/303157?",
"url": "https://api.github.com/orgs/palantir"
}
| 2018-09-05T17:54:51 |
8219471901
|
{"actor":{"display_login":"danilotorrisi"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14492","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14492/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14492/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14492/events","html_url":"https://github.com/spring-projects/spring-boot/issues/14492","id":360870345,"node_id":"MDU6SXNzdWUzNjA4NzAzNDU=","number":14492,"title":"Starting in v1.5.3, devtools no longer works on macOS","user":{"login":"danielpgross","id":4006062,"node_id":"MDQ6VXNlcjQwMDYwNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4006062?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpgross","html_url":"https://github.com/danielpgross","followers_url":"https://api.github.com/users/danielpgross/followers","following_url":"https://api.github.com/users/danielpgross/following{/other_user}","gists_url":"https://api.github.com/users/danielpgross/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpgross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpgross/subscriptions","organizations_url":"https://api.github.com/users/danielpgross/orgs","repos_url":"https://api.github.com/users/danielpgross/repos","events_url":"https://api.github.com/users/danielpgross/events{/privacy}","received_events_url":"https://api.github.com/users/danielpgross/received_events","type":"User","site_admin":false},"labels":[{"id":97741072,"node_id":"MDU6TGFiZWw5Nzc0MTA3Mg==","url":"https://api.github.com/repos/spring-projects/spring-boot/labels/status:%20waiting-for-feedback","name":"status: waiting-for-feedback","color":"fef2c0","default":false},{"id":293438798,"node_id":"MDU6TGFiZWwyOTM0Mzg3OTg=","url":"https://api.github.com/repos/spring-projects/spring-boot/labels/status:%20waiting-for-triage","name":"status: waiting-for-triage","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-17T13:30:11Z","updated_at":"2018-09-17T16:47:22Z","closed_at":null,"author_association":"NONE","body":"Testing using a simple spring-boot starter generated by initializr: [Download starter](https://start.spring.io/starter.zip?type=maven-project&language=java&bootVersion=1.5.16.RELEASE&baseDir=demo&groupId=com.example&artifactId=demo&name=demo&description=Demo+project+for+Spring+Boot&packageName=com.example.demo&packaging=jar&javaVersion=1.8&autocomplete=&generate-project=&style=devtools)\r\n\r\nWith identical JDKs and maven versions, devtools works fine on Ubuntu 16.04 but does not work on macOS 10.13.6. The symptoms are:\r\n1. The main thread is called `main` instead of `restartedMain`.\r\n2. The application does not restart automatically (even though it should) upon changes to files in the classpath.\r\n\r\nI have tested this going back to older versions and determined that the first version in which this broke is 1.5.3.\r\n\r\nTo reproduce:\r\n1. [Download starter](https://start.spring.io/starter.zip?type=maven-project&language=java&bootVersion=1.5.16.RELEASE&baseDir=demo&groupId=com.example&artifactId=demo&name=demo&description=Demo+project+for+Spring+Boot&packageName=com.example.demo&packaging=jar&javaVersion=1.8&autocomplete=&generate-project=&style=devtools)\r\n2. Unzip the starter and cd into the unzipped directory.\r\n3. Run `mvn spring-boot:run`\r\n\r\nTestcases below:\r\n**macOS**\r\n```\r\n$ mvn -v\r\nApache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T14:33:14-04:00)\r\nMaven home: /usr/local/Cellar/maven/3.5.4/libexec\r\nJava version: 1.8.0_181, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_181.jdk/Contents/Home/jre\r\nDefault locale: en_CA, platform encoding: UTF-8\r\nOS name: \"mac os x\", version: \"10.13.6\", arch: \"x86_64\", family: \"mac\"\r\n```\r\n\r\n```\r\n[INFO] --- spring-boot-maven-plugin:1.5.16.RELEASE:run (default-cli) @ demo ---\r\n[INFO] Attaching agents: []\r\n09:24:58.767 [main] DEBUG org.springframework.boot.devtools.settings.DevToolsSettings - Included patterns for restart : []\r\n09:24:58.770 [main] DEBUG org.springframework.boot.devtools.settings.DevToolsSettings - Excluded patterns for restart : [/spring-boot-starter/target/classes/, /spring-boot-autoconfigure/target/classes/, /spring-boot-starter-[\\w-]+/, /spring-boot/target/classes/, /spring-boot-actuator/target/classes/, /spring-boot-devtools/target/classes/]\r\n09:24:58.771 [main] DEBUG org.springframework.boot.devtools.restart.ChangeableUrls - Matching URLs for reloading : [file:/Users/danielgross/volatile/Downloads/demo-1516/demo/target/classes/]\r\n\r\n . ____ _ __ _ _\r\n /\\\\ / ___'_ __ _ _(_)_ __ __ _ \\ \\ \\ \\\r\n( ( )\\___ | '_ | '_| | '_ \\/ _` | \\ \\ \\ \\\r\n \\\\/ ___)| |_)| | | | | || (_| | ) ) ) )\r\n ' |____| .__|_| |_|_| |_\\__, | / / / /\r\n =========|_|==============|___/=/_/_/_/\r\n :: Spring Boot :: (v1.5.16.RELEASE)\r\n\r\n2018-09-17 09:24:59.169 INFO 7807 --- [ main] com.example.demo.DemoApplication : Starting DemoApplication on daniel with PID 7807 (/Users/danielgross/volatile/Downloads/demo-1516/demo/target/classes started by danielgross in /Users/danielgross/volatile/Downloads/demo-1516/demo)\r\n2018-09-17 09:24:59.170 INFO 7807 --- [ main] com.example.demo.DemoApplication : No active profile set, falling back to default profiles: default\r\n2018-09-17 09:24:59.217 INFO 7807 --- [ main] s.c.a.AnnotationConfigApplicationContext : Refreshing org.springframework.context.annotation.AnnotationConfigApplicationContext@49c43f4e: startup date [Mon Sep 17 09:24:59 EDT 2018]; root of context hierarchy\r\n2018-09-17 09:24:59.694 INFO 7807 --- [ main] o.s.b.d.a.OptionalLiveReloadServer : LiveReload server is running on port 35729\r\n2018-09-17 09:24:59.717 INFO 7807 --- [ main] o.s.j.e.a.AnnotationMBeanExporter : Registering beans for JMX exposure on startup\r\n2018-09-17 09:24:59.730 INFO 7807 --- [ main] com.example.demo.DemoApplication : Started DemoApplication in 0.989 seconds (JVM running for 1.268)\r\n2018-09-17 09:24:59.731 INFO 7807 --- [ Thread-6] s.c.a.AnnotationConfigApplicationContext : Closing org.springframework.context.annotation.AnnotationConfigApplicationContext@49c43f4e: startup date [Mon Sep 17 09:24:59 EDT 2018]; root of context hierarchy\r\n2018-09-17 09:24:59.733 INFO 7807 --- [ Thread-6] o.s.j.e.a.AnnotationMBeanExporter : Unregistering JMX-exposed beans on shutdown\r\n```\r\n\r\n**Ubuntu**\r\n```\r\n$ mvn -v\r\nApache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)\r\nMaven home: /opt/apache-maven\r\nJava version: 1.8.0_181, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-oracle/jre\r\nDefault locale: en_US, platform encoding: ANSI_X3.4-1968\r\nOS name: \"linux\", version: \"4.4.0-1065-aws\", arch: \"amd64\", family: \"unix\"\r\n```\r\n\r\n```\r\n[INFO] --- spring-boot-maven-plugin:1.5.16.RELEASE:run (default-cli) @ demo ---\r\n[INFO] Attaching agents: []\r\n13:28:13.786 [main] DEBUG org.springframework.boot.devtools.settings.DevToolsSettings - Included patterns for restart : []\r\n13:28:13.795 [main] DEBUG org.springframework.boot.devtools.settings.DevToolsSettings - Excluded patterns for restart : [/spring-boot-starter/target/classes/, /spring-boot-autoconfigure/target/classes/, /spring-boot-starter-[\\w-]+/, /spring-boot/target/classes/, /spring-boot-actuator/target/classes/, /spring-boot-devtools/target/classes/]\r\n13:28:13.795 [main] DEBUG org.springframework.boot.devtools.restart.ChangeableUrls - Matching URLs for reloading : [file:/home/ubuntu/demo/target/classes/]\r\n\r\n . ____ _ __ _ _\r\n /\\\\ / ___'_ __ _ _(_)_ __ __ _ \\ \\ \\ \\\r\n( ( )\\___ | '_ | '_| | '_ \\/ _` | \\ \\ \\ \\\r\n \\\\/ ___)| |_)| | | | | || (_| | ) ) ) )\r\n ' |____| .__|_| |_|_| |_\\__, | / / / /\r\n =========|_|==============|___/=/_/_/_/\r\n :: Spring Boot :: (v1.5.16.RELEASE)\r\n\r\n2018-09-17 13:28:14.384 INFO 11885 --- [ restartedMain] com.example.demo.DemoApplication : Starting DemoApplication on demo with PID 11885 (/home/ubuntu/demo/target/classes started by ubuntu in /home/ubuntu/demo)\r\n2018-09-17 13:28:14.388 INFO 11885 --- [ restartedMain] com.example.demo.DemoApplication : No active profile set, falling back to default profiles: default\r\n2018-09-17 13:28:14.541 INFO 11885 --- [ restartedMain] s.c.a.AnnotationConfigApplicationContext : Refreshing org.springframework.context.annotation.AnnotationConfigApplicationContext@3832139c: startup date [Mon Sep 17 13:28:14 UTC 2018]; root of context hierarchy\r\n2018-09-17 13:28:15.815 INFO 11885 --- [ restartedMain] o.s.b.d.a.OptionalLiveReloadServer : LiveReload server is running on port 35729\r\n2018-09-17 13:28:15.871 INFO 11885 --- [ restartedMain] o.s.j.e.a.AnnotationMBeanExporter : Registering beans for JMX exposure on startup\r\n2018-09-17 13:28:15.909 INFO 11885 --- [ restartedMain] com.example.demo.DemoApplication : Started DemoApplication in 2.081 seconds (JVM running for 2.643)\r\n2018-09-17 13:28:15.918 INFO 11885 --- [ Thread-8] s.c.a.AnnotationConfigApplicationContext : Closing org.springframework.context.annotation.AnnotationConfigApplicationContext@3832139c: startup date [Mon Sep 17 13:28:14 UTC 2018]; root of context hierarchy\r\n2018-09-17 13:28:15.923 INFO 11885 --- [ Thread-8] o.s.j.e.a.AnnotationMBeanExporter : Unregistering JMX-exposed beans on shutdown\r\n```"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments/422088439","html_url":"https://github.com/spring-projects/spring-boot/issues/14492#issuecomment-422088439","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14492","id":422088439,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjA4ODQzOQ==","user":{"login":"danielpgross","id":4006062,"node_id":"MDQ6VXNlcjQwMDYwNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4006062?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpgross","html_url":"https://github.com/danielpgross","followers_url":"https://api.github.com/users/danielpgross/followers","following_url":"https://api.github.com/users/danielpgross/following{/other_user}","gists_url":"https://api.github.com/users/danielpgross/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpgross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpgross/subscriptions","organizations_url":"https://api.github.com/users/danielpgross/orgs","repos_url":"https://api.github.com/users/danielpgross/repos","events_url":"https://api.github.com/users/danielpgross/events{/privacy}","received_events_url":"https://api.github.com/users/danielpgross/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T16:47:22Z","updated_at":"2018-09-17T16:47:22Z","author_association":"NONE","body":"I was able to run the debugger and from what I can see, the Restarter actually is being initialized (it is not disabled). See below:\r\n\r\n"}}
|
{
"id": 6296790,
"name": "spring-projects/spring-boot",
"url": "https://api.github.com/repos/spring-projects/spring-boot"
}
|
{
"id": 4006062,
"login": "danielpgross",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4006062?",
"url": "https://api.github.com/users/danielpgross"
}
|
{
"id": 317776,
"login": "spring-projects",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/317776?",
"url": "https://api.github.com/orgs/spring-projects"
}
| 2018-09-17T16:47:22 |
8276868062
|
{"actor":{"display_login":"danielpgross"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/Topshelf/Topshelf/issues/455","repository_url":"https://api.github.com/repos/Topshelf/Topshelf","labels_url":"https://api.github.com/repos/Topshelf/Topshelf/issues/455/labels{/name}","comments_url":"https://api.github.com/repos/Topshelf/Topshelf/issues/455/comments","events_url":"https://api.github.com/repos/Topshelf/Topshelf/issues/455/events","html_url":"https://github.com/Topshelf/Topshelf/issues/455","id":331620085,"node_id":"MDU6SXNzdWUzMzE2MjAwODU=","number":455,"title":"Windows Services under .NET Core 2.1","user":{"login":"TimurZanagar","id":328135,"node_id":"MDQ6VXNlcjMyODEzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/328135?v=4","gravatar_id":"","url":"https://api.github.com/users/TimurZanagar","html_url":"https://github.com/TimurZanagar","followers_url":"https://api.github.com/users/TimurZanagar/followers","following_url":"https://api.github.com/users/TimurZanagar/following{/other_user}","gists_url":"https://api.github.com/users/TimurZanagar/gists{/gist_id}","starred_url":"https://api.github.com/users/TimurZanagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimurZanagar/subscriptions","organizations_url":"https://api.github.com/users/TimurZanagar/orgs","repos_url":"https://api.github.com/users/TimurZanagar/repos","events_url":"https://api.github.com/users/TimurZanagar/events{/privacy}","received_events_url":"https://api.github.com/users/TimurZanagar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2018-06-12T14:44:36Z","updated_at":"2018-11-08T07:00:36Z","closed_at":null,"author_association":"NONE","body":"Hi folks,\r\n\r\nI just read the article \"[Hidden Gems in .NET Core 2.1](https://www.hanselman.com/blog/ASPNETCoreArchitectDavidFowlersHiddenGemsIn21.aspx)\" and there are some gems which should help you to migrate Topshelf to .NET Core.\r\n\r\nWhy? Microsoft released an interface called IHostingService which is packed in the [NuGet](https://www.nuget.org/packages/Microsoft.AspNetCore.Hosting.WindowsServices/). \r\n\r\nI don't know if this is really useful, but I wanted to leave this information here for the issues:\r\n#https://github.com/Topshelf/Topshelf/issues/444\r\n#https://github.com/Topshelf/Topshelf/issues/393\r\n#https://github.com/Topshelf/Topshelf/issues/277 \r\n\r\nHere are some further links:\r\n- [Documentation](https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/windows-service?view=aspnetcore-2.1&tabs=aspnetcore2x)\r\n- [Samples](https://github.com/aspnet/Docs/tree/master/aspnetcore/fundamentals/host/hosted-services/samples/2.x)"},"comment":{"url":"https://api.github.com/repos/Topshelf/Topshelf/issues/comments/436893125","html_url":"https://github.com/Topshelf/Topshelf/issues/455#issuecomment-436893125","issue_url":"https://api.github.com/repos/Topshelf/Topshelf/issues/455","id":436893125,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjg5MzEyNQ==","user":{"login":"paddydev","id":44860339,"node_id":"MDQ6VXNlcjQ0ODYwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/44860339?v=4","gravatar_id":"","url":"https://api.github.com/users/paddydev","html_url":"https://github.com/paddydev","followers_url":"https://api.github.com/users/paddydev/followers","following_url":"https://api.github.com/users/paddydev/following{/other_user}","gists_url":"https://api.github.com/users/paddydev/gists{/gist_id}","starred_url":"https://api.github.com/users/paddydev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddydev/subscriptions","organizations_url":"https://api.github.com/users/paddydev/orgs","repos_url":"https://api.github.com/users/paddydev/repos","events_url":"https://api.github.com/users/paddydev/events{/privacy}","received_events_url":"https://api.github.com/users/paddydev/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T07:00:36Z","updated_at":"2018-11-08T07:00:36Z","author_association":"NONE","body":"> Version: 4.1.0.175-Desktop\r\n> .NET Core: 2.1\r\n> \r\n> ```\r\n> using System;\r\n> using Topshelf;\r\n> using Topshelf.HostConfigurators;\r\n> \r\n> namespace ConsoleApp1\r\n> {\r\n> class MyService : ServiceControl\r\n> {\r\n> public bool Start(HostControl hostControl)\r\n> {\r\n> Console.WriteLine(\"Start\");\r\n> return true;\r\n> }\r\n> \r\n> public bool Stop(HostControl hostControl)\r\n> {\r\n> Console.WriteLine(\"Stop\");\r\n> return true;\r\n> }\r\n> }\r\n> \r\n> class Program\r\n> {\r\n> public static void Main(string[] args)\r\n> {\r\n> \r\n> var host = HostFactory.New(x =>\r\n> {\r\n> x.Service<MyService>();\r\n> \r\n> ConfigureService(x, \"MyServices\");\r\n> });\r\n> \r\n> host.Run();\r\n> }\r\n> \r\n> private static void ConfigureService(HostConfigurator x, string serviceName)\r\n> {\r\n> x.StartAutomatically();\r\n> x.SetDisplayName(serviceName);\r\n> x.SetServiceName(serviceName);\r\n> \r\n> x.RunAsPrompt();\r\n> \r\n> //x.UseNLog();\r\n> \r\n> x.EnableServiceRecovery(r =>\r\n> {\r\n> r.RestartService(0);\r\n> r.OnCrashOnly();\r\n> r.SetResetPeriod(1);\r\n> });\r\n> }\r\n> }\r\n> }\r\n> ```\r\nAble to install .net core 2.1 console app as windows service . But when i try to configure Log4net using Topshelf Log4net extension nuget and call UseLog4Net using hostconfigurator, I see the files created but not writing any logs when I run as a service. But the same works fine if i run it in local. Any help is appreciated. Thanks ! \r\n"}}
|
{
"id": 778834,
"name": "Topshelf/Topshelf",
"url": "https://api.github.com/repos/Topshelf/Topshelf"
}
|
{
"id": 44860339,
"login": "paddydev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44860339?",
"url": "https://api.github.com/users/paddydev"
}
|
{
"id": 317799,
"login": "Topshelf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/317799?",
"url": "https://api.github.com/orgs/Topshelf"
}
| 2018-11-08T07:00:36 |
8554570150
|
{"actor":{"display_login":"paddydev"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/monome/norns/issues/474","repository_url":"https://api.github.com/repos/monome/norns","labels_url":"https://api.github.com/repos/monome/norns/issues/474/labels{/name}","comments_url":"https://api.github.com/repos/monome/norns/issues/474/comments","events_url":"https://api.github.com/repos/monome/norns/issues/474/events","html_url":"https://github.com/monome/norns/issues/474","id":343342006,"node_id":"MDU6SXNzdWUzNDMzNDIwMDY=","number":474,"title":"Generic i2c functions","user":{"login":"okyeron","id":1909661,"node_id":"MDQ6VXNlcjE5MDk2NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1909661?v=4","gravatar_id":"","url":"https://api.github.com/users/okyeron","html_url":"https://github.com/okyeron","followers_url":"https://api.github.com/users/okyeron/followers","following_url":"https://api.github.com/users/okyeron/following{/other_user}","gists_url":"https://api.github.com/users/okyeron/gists{/gist_id}","starred_url":"https://api.github.com/users/okyeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okyeron/subscriptions","organizations_url":"https://api.github.com/users/okyeron/orgs","repos_url":"https://api.github.com/users/okyeron/repos","events_url":"https://api.github.com/users/okyeron/events{/privacy}","received_events_url":"https://api.github.com/users/okyeron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-21T17:24:07Z","updated_at":"2018-07-21T17:29:46Z","closed_at":null,"author_association":"NONE","body":"Would it be possible to update/modify i2c.c to allow for generic i2c read/write functions (such as communicating with other devices)?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/monome/norns/issues/comments/406811455","html_url":"https://github.com/monome/norns/issues/474#issuecomment-406811455","issue_url":"https://api.github.com/repos/monome/norns/issues/474","id":406811455,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjgxMTQ1NQ==","user":{"login":"tehn","id":246896,"node_id":"MDQ6VXNlcjI0Njg5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/246896?v=4","gravatar_id":"","url":"https://api.github.com/users/tehn","html_url":"https://github.com/tehn","followers_url":"https://api.github.com/users/tehn/followers","following_url":"https://api.github.com/users/tehn/following{/other_user}","gists_url":"https://api.github.com/users/tehn/gists{/gist_id}","starred_url":"https://api.github.com/users/tehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehn/subscriptions","organizations_url":"https://api.github.com/users/tehn/orgs","repos_url":"https://api.github.com/users/tehn/repos","events_url":"https://api.github.com/users/tehn/events{/privacy}","received_events_url":"https://api.github.com/users/tehn/received_events","type":"User","site_admin":false},"created_at":"2018-07-21T17:29:46Z","updated_at":"2018-07-21T17:29:46Z","author_association":"MEMBER","body":"you could likewise just pass `os.execute` lua calls to `i2cset` or an external python script (or similar) if you're doing low-bandwidth i2c interactions."}}
|
{
"id": 75774176,
"name": "monome/norns",
"url": "https://api.github.com/repos/monome/norns"
}
|
{
"id": 246896,
"login": "tehn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/246896?",
"url": "https://api.github.com/users/tehn"
}
|
{
"id": 318048,
"login": "monome",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/318048?",
"url": "https://api.github.com/orgs/monome"
}
| 2018-07-21T17:29:46 |
7998935633
|
{"actor":{"display_login":"tehn"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/kaltura/playkit-ios/issues/280","repository_url":"https://api.github.com/repos/kaltura/playkit-ios","labels_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/280/labels{/name}","comments_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/280/comments","events_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/280/events","html_url":"https://github.com/kaltura/playkit-ios/issues/280","id":329433324,"node_id":"MDU6SXNzdWUzMjk0MzMzMjQ=","number":280,"title":"Seeking while session is connected to Airplay crashes the SDK and the app","user":{"login":"kjoneandrei","id":17949666,"node_id":"MDQ6VXNlcjE3OTQ5NjY2","avatar_url":"https://avatars2.githubusercontent.com/u/17949666?v=4","gravatar_id":"","url":"https://api.github.com/users/kjoneandrei","html_url":"https://github.com/kjoneandrei","followers_url":"https://api.github.com/users/kjoneandrei/followers","following_url":"https://api.github.com/users/kjoneandrei/following{/other_user}","gists_url":"https://api.github.com/users/kjoneandrei/gists{/gist_id}","starred_url":"https://api.github.com/users/kjoneandrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjoneandrei/subscriptions","organizations_url":"https://api.github.com/users/kjoneandrei/orgs","repos_url":"https://api.github.com/users/kjoneandrei/repos","events_url":"https://api.github.com/users/kjoneandrei/events{/privacy}","received_events_url":"https://api.github.com/users/kjoneandrei/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"x-NR-x","id":5113371,"node_id":"MDQ6VXNlcjUxMTMzNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/5113371?v=4","gravatar_id":"","url":"https://api.github.com/users/x-NR-x","html_url":"https://github.com/x-NR-x","followers_url":"https://api.github.com/users/x-NR-x/followers","following_url":"https://api.github.com/users/x-NR-x/following{/other_user}","gists_url":"https://api.github.com/users/x-NR-x/gists{/gist_id}","starred_url":"https://api.github.com/users/x-NR-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x-NR-x/subscriptions","organizations_url":"https://api.github.com/users/x-NR-x/orgs","repos_url":"https://api.github.com/users/x-NR-x/repos","events_url":"https://api.github.com/users/x-NR-x/events{/privacy}","received_events_url":"https://api.github.com/users/x-NR-x/received_events","type":"User","site_admin":false},"assignees":[{"login":"x-NR-x","id":5113371,"node_id":"MDQ6VXNlcjUxMTMzNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/5113371?v=4","gravatar_id":"","url":"https://api.github.com/users/x-NR-x","html_url":"https://github.com/x-NR-x","followers_url":"https://api.github.com/users/x-NR-x/followers","following_url":"https://api.github.com/users/x-NR-x/following{/other_user}","gists_url":"https://api.github.com/users/x-NR-x/gists{/gist_id}","starred_url":"https://api.github.com/users/x-NR-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x-NR-x/subscriptions","organizations_url":"https://api.github.com/users/x-NR-x/orgs","repos_url":"https://api.github.com/users/x-NR-x/repos","events_url":"https://api.github.com/users/x-NR-x/events{/privacy}","received_events_url":"https://api.github.com/users/x-NR-x/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-06-05T12:27:14Z","updated_at":"2018-09-14T17:13:13Z","closed_at":"2018-07-25T13:07:18Z","author_association":"NONE","body":"\r\n##### Prerequisites\r\n- [x] Which Player [version](https://github.com/kaltura/playkit-ios/releases) are you using: issue first encountered on version 3.3.5 and after updating to 3.4.1 issue still persists\r\n- [x] Can you reproduce the issue with our latest release version: Can be reproduced with 3.4.1 (latest version at the current time)\r\n- [x] Can you reproduce the issue with the latest code from master: Issue can be reproduce with code from master\r\n- [x] What devices and OS versions are you using: \r\n - iPhone X running iOS 11.3.4\r\n - iPhone X running iOS 11.4\r\n - iPhone 6S running iOS 10.3.1\r\n - iPhone 8 Plus \r\n - iPhone 7 running iOS 11\r\n\r\nIn order to trigger the crash it is needed to enable Airplay and play a video content with Airplay while seeking back and forth from the player \r\n\r\n##### Expected behavior\r\nVideo should seek to the desired position selected (seeking more than 1 time is probably needed as this seems to happen at random)\r\n\r\n##### Actual behavior\r\nPlayer tries to seek to position but crashes\r\n\r\n##### Console output\r\n\r\nOutput in console -> \r\n\r\n```\r\n***** set current time to2: 1228.6467246747\r\n2018-06-05 14:05:17.308375+0200 APPNAME[1165:317788] CMTimeMakeWithSeconds(1228.647 seconds, timescale 1): warning: error of -0.647 introduced due to very low timescale\r\n[2018-06-05 14:05:17.309] AVPlayerEngine.swift:77 DEBUG: set currentPosition: nan\r\n2018-06-05 14:05:17.309992+0200 APPNAME[1165:317788] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[AVPlayerItem seekToTime:toleranceBefore:toleranceAfter:completionHandler:] Seeking is not possible to time {INVALID}'\r\n*** First throw call stack:\r\n(0x183966d8c 0x182b205ec 0x1893ded54 0x1893c8fb0 0x105bdd1a8 0x105be15c4 0x104703728 0x1046f9330 0x18d7526e8 0x18dcbf3b4 0x18d8b4e38 0x18d751740 0x18dcb0bd4 0x18d74b4d8 0x18d74b010 0x18d74a874 0x18d7491d0 0x18df2ad1c 0x18df2d2c8 0x18df26368 0x18390f404 0x18390ec2c 0x18390c79c 0x18382cda8 0x185811020 0x18d849758 0x104620890 0x1832bdfc0)\r\nlibc++abi.dylib: terminating with uncaught exception of type NSException\r\n```\r\n\r\nOutput in crash logs ->\r\n\r\n```\r\nApplication Specific Information:\r\n*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[AVPlayerItem seekToTime:toleranceBefore:toleranceAfter:completionHandler:] Seeking is not possible to time {INVALID}'\r\n\r\nLast Exception Backtrace:\r\n0 CoreFoundation 0x000000018393ed8c __exceptionPreprocess + 228\r\n1 libobjc.A.dylib 0x0000000182af85ec objc_exception_throw + 52\r\n2 AVFoundation 0x00000001893a2fa0 -[AVPlayerItem seekToTime:toleranceBefore:toleranceAfter:completionHandler:] + 1364\r\n3 AVFoundation 0x000000018938d1fc -[AVPlayer seekToTime:toleranceBefore:toleranceAfter:completionHandler:] + 124\r\n4 PlayKit 0x0000000105645338 0x105620000 + 152376\r\n5 PlayKit 0x00000001056496a0 0x105620000 + 169632\r\n6 AppName 0x000000010509c54c 0x104fb4000 + 951628\r\n7 AppName 0x0000000105091c98 0x104fb4000 + 908440\r\n8 UIKit 0x000000018d66e6c8 -[UIApplication sendAction:to:from:forEvent:] + 92\r\n9 UIKit 0x000000018d78f8a4 -[UIControl sendAction:to:forEvent:] + 76\r\n10 UIKit 0x000000018d67477c -[UIControl _sendActionsForEvents:withEvent:] + 436\r\n11 UIKit 0x000000018da3b008 -[UISlider continueTrackingWithTouch:withEvent:] + 416\r\n12 UIKit 0x000000018d850acc -[UIControl touchesMoved:withEvent:] + 140\r\n13 UIKit 0x000000018d6f18c4 -[UIWindow _sendTouchesForEvent:] + 2036\r\n14 UIKit 0x000000018d6e68f8 -[UIWindow sendEvent:] + 3156\r\n15 UIKit 0x000000018d6e5238 -[UIApplication sendEvent:] + 336\r\n16 UIKit 0x000000018dec6c0c __dispatchPreprocessedEventFromEventQueue + 2336\r\n17 UIKit 0x000000018dec91b8 __handleEventQueueInternal + 4740\r\n18 UIKit 0x000000018dec2258 __handleHIDEventFetcherDrain + 148\r\n19 CoreFoundation 0x00000001838e7404 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 20\r\n20 CoreFoundation 0x00000001838e6c2c __CFRunLoopDoSources0 + 272\r\n21 CoreFoundation 0x00000001838e479c __CFRunLoopRun + 1200\r\n22 CoreFoundation 0x0000000183804da8 CFRunLoopRunSpecific + 548\r\n23 GraphicsServices 0x00000001857e7020 GSEventRunModal + 96\r\n24 UIKit 0x000000018d7e578c UIApplicationMain + 232\r\n25 AppName 0x0000000104fba0ac 0x104fb4000 + 24748\r\n26 libdyld.dylib 0x0000000183295fc0 start + 0\r\n\r\nThread 0 Crashed:\r\n0 libsystem_kernel.dylib 0x00000001833c52ec __pthread_kill + 8\r\n1 libsystem_pthread.dylib 0x000000018356a6a8 pthread_kill$VARIANT$armv81 + 356\r\n2 libsystem_c.dylib 0x0000000183333d0c abort + 136\r\n3 HockeySDK 0x0000000105821878 0x1057ac000 + 481400\r\n4 CoreFoundation 0x000000018393f1c8 __handleUncaughtException + 824\r\n5 libobjc.A.dylib 0x0000000182af88c8 _objc_terminate() + 108\r\n6 HockeySDK 0x000000010580b24c 0x1057ac000 + 389708\r\n7 libc++abi.dylib 0x0000000182ae937c std::__terminate(void (*)()) + 12\r\n8 libc++abi.dylib 0x0000000182ae8f78 __cxa_rethrow + 140\r\n9 libobjc.A.dylib 0x0000000182af87ac objc_exception_rethrow + 40\r\n10 CoreFoundation 0x0000000183804e18 CFRunLoopRunSpecific + 660\r\n11 GraphicsServices 0x00000001857e7020 GSEventRunModal + 96\r\n12 UIKit 0x000000018d7e578c UIApplicationMain + 232\r\n13 AppName 0x0000000104fba0ac 0x104fb4000 + 24748\r\n14 libdyld.dylib 0x0000000183295fc0 start + 0\r\n\r\nThread 1:\r\n0 libsystem_kernel.dylib 0x00000001833a3e08 mach_msg_trap + 8\r\n1 CoreFoundation 0x00000001838e6e40 __CFRunLoopServiceMachPort + 192\r\n2 CoreFoundation 0x00000001838e4908 __CFRunLoopRun + 1564\r\n3 CoreFoundation 0x0000000183804da8 CFRunLoopRunSpecific + 548\r\n4 Foundation 0x0000000184279674 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 300\r\n5 Foundation 0x000000018427951c -[NSRunLoop(NSRunLoop) runUntilDate:] + 144\r\n6 UIKit 0x000000018d4ca7e4 -[UIEventFetcher threadMain] + 132\r\n7 Foundation 0x0000000184389efc __NSThread__start__ + 1036\r\n8 libsystem_pthread.dylib 0x0000000183565220 _pthread_body + 268\r\n9 libsystem_pthread.dylib 0x0000000183565110 _pthread_start + 288\r\n10 libsystem_pthread.dylib 0x0000000183563b10 thread_start + 0\r\n\r\nThread 2:\r\n0 libsystem_kernel.dylib 0x00000001833a3e08 mach_msg_trap + 8\r\n1 CoreFoundation 0x00000001838e6e40 __CFRunLoopServiceMachPort + 192\r\n2 CoreFoundation 0x00000001838e4908 __CFRunLoopRun + 1564\r\n3 CoreFoundation 0x0000000183804da8 CFRunLoopRunSpecific + 548\r\n4 CFNetwork 0x00000001841124b0 -[__CoreSchedulingSetRunnable runForever] + 216\r\n5 Foundation 0x0000000184389efc __NSThread__start__ + 1036\r\n6 libsystem_pthread.dylib 0x0000000183565220 _pthread_body + 268\r\n7 libsystem_pthread.dylib 0x0000000183565110 _pthread_start + 288\r\n8 libsystem_pthread.dylib 0x0000000183563b10 thread_start + 0\r\n\r\nThread 3:\r\n0 libsystem_kernel.dylib 0x00000001833a3e08 mach_msg_trap + 8\r\n1 CoreFoundation 0x00000001838e6e40 __CFRunLoopServiceMachPort + 192\r\n2 CoreFoundation 0x00000001838e4908 __CFRunLoopRun + 1564\r\n3 CoreFoundation 0x0000000183804da8 CFRunLoopRunSpecific + 548\r\n4 AVFAudio 0x00000001892ea424 GenericRunLoopThread::Entry(void*) + 160\r\n5 AVFAudio 0x0000000189314834 CAPThread::Entry(CAPThread*) + 84\r\n6 libsystem_pthread.dylib 0x0000000183565220 _pthread_body + 268\r\n7 libsystem_pthread.dylib 0x0000000183565110 _pthread_start + 288\r\n8 libsystem_pthread.dylib 0x0000000183563b10 thread_start + 0\r\n\r\nThread 4:\r\n0 libsystem_kernel.dylib 0x00000001833c5538 __select + 8\r\n1 libsystem_pthread.dylib 0x0000000183565220 _pthread_body + 268\r\n2 libsystem_pthread.dylib 0x0000000183565110 _pthread_start + 288\r\n3 libsystem_pthread.dylib 0x0000000183563b10 thread_start + 0\r\n\r\nThread 5:\r\n0 libsystem_pthread.dylib 0x0000000183563b04 start_wqthread + 0\r\n\r\nThread 6:\r\n0 libsystem_kernel.dylib 0x00000001833c5d84 __workq_kernreturn + 8\r\n1 libsystem_pthread.dylib 0x0000000183563b08 start_wqthread + 0\r\n\r\nThread 7:\r\n0 libsystem_kernel.dylib 0x00000001833c50f4 __psynch_cvwait + 8\r\n1 libc++.1.dylib 0x0000000182a7c25c std::__1::condition_variable::wait(std::__1::unique_lock<std::__1::mutex>&) + 20\r\n2 JavaScriptCore 0x000000018af5b1a4 void std::__1::condition_variable_any::wait<std::__1::unique_lock<bmalloc::Mutex> >(std::__1::unique_lock<bmalloc::Mutex>&) + 100\r\n3 JavaScriptCore 0x000000018af5adb8 bmalloc::Scavenger::threadRunLoop() + 160\r\n4 JavaScriptCore 0x000000018af5ab60 bmalloc::Scavenger::threadEntryPoint(bmalloc::Scavenger*) + 8\r\n5 JavaScriptCore 0x000000018af5af7c void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(bmalloc::Scavenger*), bmalloc::Scavenger*> >(void*) + 40\r\n6 libsystem_pthread.dylib 0x0000000183565220 _pthread_body + 268\r\n7 libsystem_pthread.dylib 0x0000000183565110 _pthread_start + 288\r\n8 libsystem_pthread.dylib 0x0000000183563b10 thread_start + 0\r\n\r\nThread 8:\r\n0 libsystem_kernel.dylib 0x00000001833a3e08 mach_msg_trap + 8\r\n1 CoreFoundation 0x00000001838e6e40 __CFRunLoopServiceMachPort + 192\r\n2 CoreFoundation 0x00000001838e4908 __CFRunLoopRun + 1564\r\n3 CoreFoundation 0x0000000183804da8 CFRunLoopRunSpecific + 548\r\n4 WebCore 0x000000018ba91d9c RunWebThread(void*) + 588\r\n5 libsystem_pthread.dylib 0x0000000183565220 _pthread_body + 268\r\n6 libsystem_pthread.dylib 0x0000000183565110 _pthread_start + 288\r\n7 libsystem_pthread.dylib 0x0000000183563b10 thread_start + 0\r\n\r\nThread 9:\r\n0 libsystem_kernel.dylib 0x00000001833a3e5c semaphore_timedwait_trap + 8\r\n1 libdispatch.dylib 0x0000000183262a00 _dispatch_semaphore_wait_slow + 68\r\n2 libdispatch.dylib 0x00000001832737e4 _dispatch_worker_thread + 244\r\n3 libsystem_pthread.dylib 0x0000000183565220 _pthread_body + 268\r\n4 libsystem_pthread.dylib 0x0000000183565110 _pthread_start + 288\r\n5 libsystem_pthread.dylib 0x0000000183563b10 thread_start + 0\r\n\r\nThread 10:\r\n0 libsystem_kernel.dylib 0x00000001833a3e5c semaphore_timedwait_trap + 8\r\n1 libdispatch.dylib 0x0000000183262a00 _dispatch_semaphore_wait_slow + 68\r\n2 libdispatch.dylib 0x00000001832737e4 _dispatch_worker_thread + 244\r\n3 libsystem_pthread.dylib 0x0000000183565220 _pthread_body + 268\r\n4 libsystem_pthread.dylib 0x0000000183565110 _pthread_start + 288\r\n5 libsystem_pthread.dylib 0x0000000183563b10 thread_start + 0\r\n\r\nThread 11:\r\n0 libsystem_kernel.dylib 0x00000001833a3e5c semaphore_timedwait_trap + 8\r\n1 libdispatch.dylib 0x0000000183262a00 _dispatch_semaphore_wait_slow + 68\r\n2 libdispatch.dylib 0x00000001832737e4 _dispatch_worker_thread + 244\r\n3 libsystem_pthread.dylib 0x0000000183565220 _pthread_body + 268\r\n4 libsystem_pthread.dylib 0x0000000183565110 _pthread_start + 288\r\n5 libsystem_pthread.dylib 0x0000000183563b10 thread_start + 0\r\n\r\nThread 0 crashed with ARM-64 Thread State:\r\n pc: 0x00000001833c52ec fp: 0x000000016ae4b2b0 sp: 0x000000016ae4b280 x0: 0x0000000000000000 \r\n x1: 0x0000000000000000 x2: 0x0000000000000000 x3: 0xffffffffffffffff x4: 0x0000000000000010 \r\n x5: 0x0000000000000a1d x6: 0x00000001c81a32c0 x7: 0x0000000000000a1e x8: 0x0000000008000000 \r\n x9: 0x0000000004000000 x10: 0x0000000183566110 x11: 0x00000001b80b5f04 x12: 0x00000001b80b5f04 \r\n x13: 0x0000000000000018 x14: 0x0000000000000001 x15: 0x0000000000000881 x16: 0x0000000000000148 \r\n x17: 0x0000000000000000 x18: 0x0000000000000000 x19: 0x0000000000000006 x20: 0x00000001b5d00b40 \r\n x21: 0x00000001ae253098 x22: 0x0000000000000303 x23: 0x00000001b5d00c20 x24: 0x000000010ae2b2e0 \r\n x25: 0x00000001b5d0e000 x26: 0x00000001b440a000 x27: 0x00000001cc10ccc0 x28: 0x00000001839d539f \r\n lr: 0x000000018356a6a8 cpsr: 0x0000000000000000 \r\n\r\n```\r\n\r\nNote that `***** set current time to2: 1228.6467246747` is printed before calling `player.seek(to: player.duration * Double(slider.value))`\r\nadditionally tried replacing the above call to `player.currentTime = player.duration * Double(slider.value)` but crash still occurred\r\n"},"comment":{"url":"https://api.github.com/repos/kaltura/playkit-ios/issues/comments/421424943","html_url":"https://github.com/kaltura/playkit-ios/issues/280#issuecomment-421424943","issue_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/280","id":421424943,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTQyNDk0Mw==","user":{"login":"kjoneandrei","id":17949666,"node_id":"MDQ6VXNlcjE3OTQ5NjY2","avatar_url":"https://avatars2.githubusercontent.com/u/17949666?v=4","gravatar_id":"","url":"https://api.github.com/users/kjoneandrei","html_url":"https://github.com/kjoneandrei","followers_url":"https://api.github.com/users/kjoneandrei/followers","following_url":"https://api.github.com/users/kjoneandrei/following{/other_user}","gists_url":"https://api.github.com/users/kjoneandrei/gists{/gist_id}","starred_url":"https://api.github.com/users/kjoneandrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjoneandrei/subscriptions","organizations_url":"https://api.github.com/users/kjoneandrei/orgs","repos_url":"https://api.github.com/users/kjoneandrei/repos","events_url":"https://api.github.com/users/kjoneandrei/events{/privacy}","received_events_url":"https://api.github.com/users/kjoneandrei/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T17:13:13Z","updated_at":"2018-09-14T17:13:13Z","author_association":"NONE","body":"@x-NR-x do you know when the next release will be?"}}
|
{
"id": 70145368,
"name": "kaltura/playkit-ios",
"url": "https://api.github.com/repos/kaltura/playkit-ios"
}
|
{
"id": 17949666,
"login": "kjoneandrei",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17949666?",
"url": "https://api.github.com/users/kjoneandrei"
}
|
{
"id": 319096,
"login": "kaltura",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/319096?",
"url": "https://api.github.com/orgs/kaltura"
}
| 2018-09-14T17:13:14 |
8267377419
|
{"actor":{"display_login":"kjoneandrei"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/celery/billiard/issues/261","repository_url":"https://api.github.com/repos/celery/billiard","labels_url":"https://api.github.com/repos/celery/billiard/issues/261/labels{/name}","comments_url":"https://api.github.com/repos/celery/billiard/issues/261/comments","events_url":"https://api.github.com/repos/celery/billiard/issues/261/events","html_url":"https://github.com/celery/billiard/issues/261","id":392866405,"node_id":"MDU6SXNzdWUzOTI4NjY0MDU=","number":261,"title":"In the billiard==3.5.0.5 version, the celery worker process is closed! TypeError: can't pickle thread.lock objects","user":{"login":"yoncan","id":5858356,"node_id":"MDQ6VXNlcjU4NTgzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5858356?v=4","gravatar_id":"","url":"https://api.github.com/users/yoncan","html_url":"https://github.com/yoncan","followers_url":"https://api.github.com/users/yoncan/followers","following_url":"https://api.github.com/users/yoncan/following{/other_user}","gists_url":"https://api.github.com/users/yoncan/gists{/gist_id}","starred_url":"https://api.github.com/users/yoncan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoncan/subscriptions","organizations_url":"https://api.github.com/users/yoncan/orgs","repos_url":"https://api.github.com/users/yoncan/repos","events_url":"https://api.github.com/users/yoncan/events{/privacy}","received_events_url":"https://api.github.com/users/yoncan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-20T03:01:31Z","updated_at":"2018-12-20T14:17:47Z","closed_at":null,"author_association":"NONE","body":"When the project is in use, in the celery task, the subscription signal `worker_shutting_down` is processed before the worker is closed, and an additional task `s_worker_shutting_down` is added to process the task that the current worker has not completed.\r\n\r\n`s_worker_shutting_down` inside only made a connection redis to write a piece of data!\r\n\r\n\r\n```\r\[email protected]_shutdown.connect\r\ndef s_worker_shutdown(*args, **kwargs):\r\n \"\"\"\r\n :param args:\r\n :param kwargs:\r\n :return:\r\n \"\"\"\r\n log.warn('worker_shutdown')\r\n\r\n\r\[email protected]_shutting_down.connect\r\ndef s_worker_shutting_down(*args, **kwargs):\r\n \"\"\"\r\n :param args:\r\n :param kwargs:\r\n :return:\r\n \"\"\"\r\n log.warn(u'[cd-worker] Receiving signal [worker_shutting_down]'\r\n u'**** Will actively close all unconfirmed tasks')\r\n redis.set('__celery_worker_shutdown', 1)\r\n time.sleep(3)\r\n```\r\n\r\nThen in the process of closing the worker's log below, as long as there are unfinished tasks, the following exception will occur:\r\n\r\n\r\n```\r\n[2018-12-20 10:38:11,344: DEBUG/MainProcess] | Worker: Closing Hub...\r\n[2018-12-20 10:38:11,345: DEBUG/MainProcess] | Worker: Closing Pool...\r\n[2018-12-20 10:38:11,345: DEBUG/MainProcess] | Worker: Closing Consumer...\r\n[2018-12-20 10:38:11,346: DEBUG/MainProcess] | Worker: Stopping Consumer...\r\n[2018-12-20 10:38:11,346: DEBUG/MainProcess] | Consumer: Closing Connection...\r\n[2018-12-20 10:38:11,346: DEBUG/MainProcess] | Consumer: Closing Events...\r\n[2018-12-20 10:38:11,347: DEBUG/MainProcess] | Consumer: Closing Heart...\r\n[2018-12-20 10:38:11,347: DEBUG/MainProcess] | Consumer: Closing Mingle...\r\n[2018-12-20 10:38:11,347: DEBUG/MainProcess] | Consumer: Closing Tasks...\r\n[2018-12-20 10:38:11,348: DEBUG/MainProcess] | Consumer: Closing Control...\r\n[2018-12-20 10:38:11,348: DEBUG/MainProcess] | Consumer: Closing Gossip...\r\n[2018-12-20 10:38:11,348: DEBUG/MainProcess] | Consumer: Closing event loop...\r\n[2018-12-20 10:38:11,349: DEBUG/MainProcess] | Consumer: Stopping event loop...\r\n[2018-12-20 10:38:11,349: DEBUG/MainProcess] | Consumer: Stopping Gossip...\r\n[2018-12-20 10:38:11,352: DEBUG/MainProcess] | Consumer: Stopping Control...\r\n[2018-12-20 10:38:11,354: DEBUG/MainProcess] | Consumer: Stopping Tasks...\r\n[2018-12-20 10:38:11,355: DEBUG/MainProcess] Canceling task consumer...\r\n[2018-12-20 10:38:11,355: DEBUG/MainProcess] | Consumer: Stopping Mingle...\r\n[2018-12-20 10:38:11,355: DEBUG/MainProcess] | Consumer: Stopping Heart...\r\n[2018-12-20 10:38:11,357: DEBUG/MainProcess] | Consumer: Stopping Events...\r\n[2018-12-20 10:38:11,357: DEBUG/MainProcess] | Consumer: Stopping Connection...\r\n[2018-12-20 10:38:11,358: DEBUG/MainProcess] | Worker: Stopping Pool...\r\n\r\n> [2018-12-20 10:38:11,359: WARNING/MainProcess] self.cache: {0: <%s: 0 ack:True ready:False>}\r\n> [2018-12-20 10:38:11,359: WARNING/MainProcess] key==0, val==<%s: 0 ack:True ready:False> , type== <class 'billiard.pool.ApplyResult'>\r\n\r\n[2018-12-20 10:38:11,363: ERROR/MainProcess] Error on stopping Pool: TypeError(\"can't pickle thread.lock objects\",)\r\nTraceback (most recent call last):\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/celery/bootsteps.py\", line 151, in send_all\r\n fun(parent, *args)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/celery/bootsteps.py\", line 373, in stop\r\n return self.obj.stop()\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/celery/concurrency/base.py\", line 122, in stop\r\n self.on_stop()\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/celery/concurrency/prefork.py\", line 140, in on_stop\r\n self._pool.join()\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/billiard/pool.py\", line 1584, in join\r\n stop_if_not_current(self._result_handler)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/billiard/pool.py\", line 146, in stop_if_not_current\r\n thread.stop(timeout)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/billiard/pool.py\", line 503, in stop\r\n self.on_stop_not_started()\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/celery/concurrency/asynpool.py\", line 332, in on_stop_not_started\r\n check_timeouts()\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/billiard/pool.py\", line 750, in handle_event\r\n next(self._it)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/site-packages/billiard/pool.py\", line 703, in handle_timeouts\r\n cache = copy.deepcopy(self.cache)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 163, in deepcopy\r\n y = copier(x, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 257, in _deepcopy_dict\r\n y[deepcopy(key, memo)] = deepcopy(value, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 190, in deepcopy\r\n y = _reconstruct(x, rv, 1, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 334, in _reconstruct\r\n state = deepcopy(state, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 163, in deepcopy\r\n y = copier(x, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 257, in _deepcopy_dict\r\n y[deepcopy(key, memo)] = deepcopy(value, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 163, in deepcopy\r\n y = copier(x, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 264, in _deepcopy_method\r\n return type(x)(x.im_func, deepcopy(x.im_self, memo), x.im_class)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 190, in deepcopy\r\n y = _reconstruct(x, rv, 1, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 334, in _reconstruct\r\n state = deepcopy(state, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 163, in deepcopy\r\n y = copier(x, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 237, in _deepcopy_tuple\r\n y.append(deepcopy(a, memo))\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 163, in deepcopy\r\n y = copier(x, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 257, in _deepcopy_dict\r\n y[deepcopy(key, memo)] = deepcopy(value, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 190, in deepcopy\r\n y = _reconstruct(x, rv, 1, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 334, in _reconstruct\r\n state = deepcopy(state, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 163, in deepcopy\r\n y = copier(x, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 237, in _deepcopy_tuple\r\n y.append(deepcopy(a, memo))\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 163, in deepcopy\r\n y = copier(x, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 257, in _deepcopy_dict\r\n y[deepcopy(key, memo)] = deepcopy(value, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 190, in deepcopy\r\n y = _reconstruct(x, rv, 1, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 334, in _reconstruct\r\n state = deepcopy(state, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 163, in deepcopy\r\n y = copier(x, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 257, in _deepcopy_dict\r\n y[deepcopy(key, memo)] = deepcopy(value, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 190, in deepcopy\r\n y = _reconstruct(x, rv, 1, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 334, in _reconstruct\r\n state = deepcopy(state, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 163, in deepcopy\r\n y = copier(x, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 257, in _deepcopy_dict\r\n y[deepcopy(key, memo)] = deepcopy(value, memo)\r\n File \"/opt/edsp-assistant/python/lib/python2.7/copy.py\", line 182, in deepcopy\r\n rv = reductor(2)\r\nTypeError: can't pickle thread.lock objects\r\n[2018-12-20 10:38:11,367: DEBUG/MainProcess] | Worker: Stopping Hub...\r\n[2018-12-20 10:38:11,368: DEBUG/MainProcess] | Consumer: Shutdown Gossip...\r\n[2018-12-20 10:38:11,368: DEBUG/MainProcess] | Consumer: Shutdown Control...\r\n[2018-12-20 10:38:11,369: DEBUG/MainProcess] | Consumer: Shutdown Tasks...\r\n[2018-12-20 10:38:11,369: DEBUG/MainProcess] Canceling task consumer...\r\n[2018-12-20 10:38:11,369: DEBUG/MainProcess] Closing consumer channel...\r\n[2018-12-20 10:38:11,370: DEBUG/MainProcess] | Consumer: Shutdown Heart...\r\n[2018-12-20 10:38:11,370: DEBUG/MainProcess] | Consumer: Shutdown Events...\r\n[2018-12-20 10:38:11,371: DEBUG/MainProcess] | Consumer: Shutdown Connection...\r\n--------------------------------------------------------------------------------\r\nWARNING in tasks [/data/cd/edsp_cd/tasks/tasks.py:83]:\r\nworker_shutdown\r\n--------------------------------------------------------------------------------\r\n[2018-12-20 10:38:11,373: DEBUG/MainProcess] removing tasks from inqueue until task handler finished\r\n```\r\n\r\n\r\nThe problem arises because:\r\n\r\nIn the 3.5.0.4 version of billiard, `copy.deepcopy` is not used to copy the self.cache object.\r\n```\r\n# billiard/pool.py\r\n .....\r\n\r\n 696 def handle_timeouts(self):\r\n 697 cache = self.cache <<<<<<<<<<< here\r\n 698 t_hard, t_soft = self.t_hard, self.t_soft\r\n 699 dirty = set()\r\n 700 on_soft_timeout = self.on_soft_timeout\r\n 701 on_hard_timeout = self.on_hard_timeout\r\n ```\r\n \r\n \r\nHowever, in billiard==`3.5.0.5`, `copy.deepcopy` is used, resulting in an error.\r\n```\r\n 696 def handle_timeouts(self):\r\n 697 cache = copy.deepcopy(self.cache) <<<<<<<<<<< here\r\n 698 t_hard, t_soft = self.t_hard, self.t_soft\r\n 699 dirty = set()\r\n 700 on_soft_timeout = self.on_soft_timeout\r\n 701 on_hard_timeout = self.on_hard_timeout\r\n 702 \r\n```"},"comment":{"url":"https://api.github.com/repos/celery/billiard/issues/comments/449013479","html_url":"https://github.com/celery/billiard/issues/261#issuecomment-449013479","issue_url":"https://api.github.com/repos/celery/billiard/issues/261","id":449013479,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTAxMzQ3OQ==","user":{"login":"thedrow","id":48936,"node_id":"MDQ6VXNlcjQ4OTM2","avatar_url":"https://avatars2.githubusercontent.com/u/48936?v=4","gravatar_id":"","url":"https://api.github.com/users/thedrow","html_url":"https://github.com/thedrow","followers_url":"https://api.github.com/users/thedrow/followers","following_url":"https://api.github.com/users/thedrow/following{/other_user}","gists_url":"https://api.github.com/users/thedrow/gists{/gist_id}","starred_url":"https://api.github.com/users/thedrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedrow/subscriptions","organizations_url":"https://api.github.com/users/thedrow/orgs","repos_url":"https://api.github.com/users/thedrow/repos","events_url":"https://api.github.com/users/thedrow/events{/privacy}","received_events_url":"https://api.github.com/users/thedrow/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T14:17:47Z","updated_at":"2018-12-20T14:17:47Z","author_association":"MEMBER","body":"I'm closing this as a duplicate of #260.\r\nLet's continue the discussion there."}}
|
{
"id": 374820,
"name": "celery/billiard",
"url": "https://api.github.com/repos/celery/billiard"
}
|
{
"id": 48936,
"login": "thedrow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48936?",
"url": "https://api.github.com/users/thedrow"
}
|
{
"id": 319983,
"login": "celery",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/319983?",
"url": "https://api.github.com/orgs/celery"
}
| 2018-12-20T14:17:47 |
8785880373
|
{"actor":{"display_login":"thedrow"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/cucumber/cucumber-js/issues/1097","repository_url":"https://api.github.com/repos/cucumber/cucumber-js","labels_url":"https://api.github.com/repos/cucumber/cucumber-js/issues/1097/labels{/name}","comments_url":"https://api.github.com/repos/cucumber/cucumber-js/issues/1097/comments","events_url":"https://api.github.com/repos/cucumber/cucumber-js/issues/1097/events","html_url":"https://github.com/cucumber/cucumber-js/issues/1097","id":326110801,"number":1097,"title":"Tag Expressions link broken in Hook docs","user":{"login":"KyleFairns","id":18209178,"avatar_url":"https://avatars1.githubusercontent.com/u/18209178?v=4","gravatar_id":"","url":"https://api.github.com/users/KyleFairns","html_url":"https://github.com/KyleFairns","followers_url":"https://api.github.com/users/KyleFairns/followers","following_url":"https://api.github.com/users/KyleFairns/following{/other_user}","gists_url":"https://api.github.com/users/KyleFairns/gists{/gist_id}","starred_url":"https://api.github.com/users/KyleFairns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyleFairns/subscriptions","organizations_url":"https://api.github.com/users/KyleFairns/orgs","repos_url":"https://api.github.com/users/KyleFairns/repos","events_url":"https://api.github.com/users/KyleFairns/events{/privacy}","received_events_url":"https://api.github.com/users/KyleFairns/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-24T13:00:07Z","updated_at":"2018-05-25T15:11:17Z","closed_at":null,"author_association":"NONE","body":"### Steps to reproduce\r\n\r\n1. Visit https://github.com/cucumber/cucumber-js/blob/master/docs/support_files/hooks.md\r\n2. Scroll to \"Tagged Hooks\" header\r\n3. Follow the \"tag expressions\" documentation link\r\n4. You should see a 404 page."},"comment":{"url":"https://api.github.com/repos/cucumber/cucumber-js/issues/comments/392089013","html_url":"https://github.com/cucumber/cucumber-js/issues/1097#issuecomment-392089013","issue_url":"https://api.github.com/repos/cucumber/cucumber-js/issues/1097","id":392089013,"user":{"login":"charlierudolph","id":1676758,"avatar_url":"https://avatars2.githubusercontent.com/u/1676758?v=4","gravatar_id":"","url":"https://api.github.com/users/charlierudolph","html_url":"https://github.com/charlierudolph","followers_url":"https://api.github.com/users/charlierudolph/followers","following_url":"https://api.github.com/users/charlierudolph/following{/other_user}","gists_url":"https://api.github.com/users/charlierudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/charlierudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlierudolph/subscriptions","organizations_url":"https://api.github.com/users/charlierudolph/orgs","repos_url":"https://api.github.com/users/charlierudolph/repos","events_url":"https://api.github.com/users/charlierudolph/events{/privacy}","received_events_url":"https://api.github.com/users/charlierudolph/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T15:11:17Z","updated_at":"2018-05-25T15:11:17Z","author_association":"MEMBER","body":"I don't know about the idea of a suite tag as it appears you want it to be as if the tag is added to everything. This doesn't make sense to me as tags are used for filtering. Tags also can't be used on beforeAll / afterAll currently. I think you accomplish this today with the following:\r\n \r\n```\r\nBeforeAll(async ()=>{\r\n // always start the browser\r\n});\r\n\r\nBefore(async () => {\r\n // if the browser isn't running, start it\r\n});\r\n\r\nAfter(async function(){\r\n // if this.restartAfterEveryScenario (property the world), then quit the browser\r\n});\r\n\r\nAfterAll(async ()=>{\r\n // if the browser is running, quit it\r\n});\r\n```\r\nwhere the property on the world can be set with the [CLI](https://github.com/cucumber/cucumber-js/blob/master/docs/cli.md#world-parameters)"}}
|
{
"id": 1811965,
"name": "cucumber/cucumber-js",
"url": "https://api.github.com/repos/cucumber/cucumber-js"
}
|
{
"id": 1676758,
"login": "charlierudolph",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1676758?",
"url": "https://api.github.com/users/charlierudolph"
}
|
{
"id": 320565,
"login": "cucumber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/320565?",
"url": "https://api.github.com/orgs/cucumber"
}
| 2018-05-25T15:11:18 |
7730563117
|
{"actor":{"display_login":"charlierudolph"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/678","repository_url":"https://api.github.com/repos/cucumber/cucumber-ruby","labels_url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/678/labels{/name}","comments_url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/678/comments","events_url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/678/events","html_url":"https://github.com/cucumber/cucumber-ruby/issues/678","id":33402949,"node_id":"MDU6SXNzdWUzMzQwMjk0OQ==","number":678,"title":"Feature setup/teardown not implemented","user":{"login":"seaman1","id":7382031,"node_id":"MDQ6VXNlcjczODIwMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/7382031?v=4","gravatar_id":"","url":"https://api.github.com/users/seaman1","html_url":"https://github.com/seaman1","followers_url":"https://api.github.com/users/seaman1/followers","following_url":"https://api.github.com/users/seaman1/following{/other_user}","gists_url":"https://api.github.com/users/seaman1/gists{/gist_id}","starred_url":"https://api.github.com/users/seaman1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seaman1/subscriptions","organizations_url":"https://api.github.com/users/seaman1/orgs","repos_url":"https://api.github.com/users/seaman1/repos","events_url":"https://api.github.com/users/seaman1/events{/privacy}","received_events_url":"https://api.github.com/users/seaman1/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2014-05-13T14:25:45Z","updated_at":"2018-10-25T07:28:22Z","closed_at":"2014-05-13T17:53:17Z","author_association":"NONE","body":"Use case: I need to have a possibility to run some code when feature starts and after feature ends.\nThe purpose of this code is to setup/cofigure tested product for scenarios execution. If I will run this peace of code in every scenario setup this will increase feature execution time significantly.\n\nFor now cucumber has only setup/teardown for scenarios (implemented with After/Before hooks).\n\nGeneral work flow should look like this: \n\n```\n Feature 1 setup (implementation: don't exists)\n Scenario 1 setup (implementation: in hooks.rb - Before('@scenario1') do ...)\n Scenario1\n Scenario 1 teardown (implementation: in hooks.rb - After('@scenario1') do ...)\n Scenario 2 setup (implementation: in hooks.rb - Before('@scenario2') do ...)\n Scenario2\n Scenario 2 teardown (implementation: in hooks.rb - After('@scenario2') do ...)\n Feature 1 teardown (implementation: don't exists)\n```\n"},"comment":{"url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/comments/432944081","html_url":"https://github.com/cucumber/cucumber-ruby/issues/678#issuecomment-432944081","issue_url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/678","id":432944081,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjk0NDA4MQ==","user":{"login":"lock[bot]","id":33595554,"node_id":"MDM6Qm90MzM1OTU1NTQ=","avatar_url":"https://avatars1.githubusercontent.com/in/6672?v=4","gravatar_id":"","url":"https://api.github.com/users/lock%5Bbot%5D","html_url":"https://github.com/apps/lock","followers_url":"https://api.github.com/users/lock%5Bbot%5D/followers","following_url":"https://api.github.com/users/lock%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/lock%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/lock%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lock%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/lock%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/lock%5Bbot%5D/repos","events_url":"https://api.github.com/users/lock%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/lock%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-25T07:28:22Z","updated_at":"2018-10-25T07:28:22Z","author_association":"NONE","body":"This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.\n"}}
|
{
"id": 10664,
"name": "cucumber/cucumber-ruby",
"url": "https://api.github.com/repos/cucumber/cucumber-ruby"
}
|
{
"id": 33595554,
"login": "lock[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33595554?",
"url": "https://api.github.com/users/lock[bot]"
}
|
{
"id": 320565,
"login": "cucumber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/320565?",
"url": "https://api.github.com/orgs/cucumber"
}
| 2018-10-25T07:28:22 |
8478318734
|
{"actor":{"display_login":"lock"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/cucumber/cucumber-js/issues/664","repository_url":"https://api.github.com/repos/cucumber/cucumber-js","labels_url":"https://api.github.com/repos/cucumber/cucumber-js/issues/664/labels{/name}","comments_url":"https://api.github.com/repos/cucumber/cucumber-js/issues/664/comments","events_url":"https://api.github.com/repos/cucumber/cucumber-js/issues/664/events","html_url":"https://github.com/cucumber/cucumber-js/pull/664","id":186056751,"node_id":"MDExOlB1bGxSZXF1ZXN0OTE0NzczNTU=","number":664,"title":"Clarify some things in README.md & fix description in data_tables.fea…","user":{"login":"BurkHufnagel","id":304328,"node_id":"MDQ6VXNlcjMwNDMyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/304328?v=4","gravatar_id":"","url":"https://api.github.com/users/BurkHufnagel","html_url":"https://github.com/BurkHufnagel","followers_url":"https://api.github.com/users/BurkHufnagel/followers","following_url":"https://api.github.com/users/BurkHufnagel/following{/other_user}","gists_url":"https://api.github.com/users/BurkHufnagel/gists{/gist_id}","starred_url":"https://api.github.com/users/BurkHufnagel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurkHufnagel/subscriptions","organizations_url":"https://api.github.com/users/BurkHufnagel/orgs","repos_url":"https://api.github.com/users/BurkHufnagel/repos","events_url":"https://api.github.com/users/BurkHufnagel/events{/privacy}","received_events_url":"https://api.github.com/users/BurkHufnagel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-29T03:30:52Z","updated_at":"2018-10-25T06:16:44Z","closed_at":"2016-10-29T03:31:57Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cucumber/cucumber-js/pulls/664","html_url":"https://github.com/cucumber/cucumber-js/pull/664","diff_url":"https://github.com/cucumber/cucumber-js/pull/664.diff","patch_url":"https://github.com/cucumber/cucumber-js/pull/664.patch"},"body":"…ture\n\nThe descriptions of features that use data tables showed ‘Scenario’\ninstead of ‘Scenario Outline’ so anyone who used them as a guide would\nsee an error when they tried to execute the specs.\n"},"comment":{"url":"https://api.github.com/repos/cucumber/cucumber-js/issues/comments/432928068","html_url":"https://github.com/cucumber/cucumber-js/pull/664#issuecomment-432928068","issue_url":"https://api.github.com/repos/cucumber/cucumber-js/issues/664","id":432928068,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjkyODA2OA==","user":{"login":"lock[bot]","id":33595554,"node_id":"MDM6Qm90MzM1OTU1NTQ=","avatar_url":"https://avatars1.githubusercontent.com/in/6672?v=4","gravatar_id":"","url":"https://api.github.com/users/lock%5Bbot%5D","html_url":"https://github.com/apps/lock","followers_url":"https://api.github.com/users/lock%5Bbot%5D/followers","following_url":"https://api.github.com/users/lock%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/lock%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/lock%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lock%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/lock%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/lock%5Bbot%5D/repos","events_url":"https://api.github.com/users/lock%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/lock%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-25T06:16:44Z","updated_at":"2018-10-25T06:16:44Z","author_association":"NONE","body":"This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.\n"}}
|
{
"id": 1811965,
"name": "cucumber/cucumber-js",
"url": "https://api.github.com/repos/cucumber/cucumber-js"
}
|
{
"id": 33595554,
"login": "lock[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33595554?",
"url": "https://api.github.com/users/lock[bot]"
}
|
{
"id": 320565,
"login": "cucumber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/320565?",
"url": "https://api.github.com/orgs/cucumber"
}
| 2018-10-25T06:16:44 |
8478011968
|
{"actor":{"display_login":"lock"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/Slicer/SlicerJupyter/issues/7","repository_url":"https://api.github.com/repos/Slicer/SlicerJupyter","labels_url":"https://api.github.com/repos/Slicer/SlicerJupyter/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/Slicer/SlicerJupyter/issues/7/comments","events_url":"https://api.github.com/repos/Slicer/SlicerJupyter/issues/7/events","html_url":"https://github.com/Slicer/SlicerJupyter/issues/7","id":339283931,"node_id":"MDU6SXNzdWUzMzkyODM5MzE=","number":7,"title":"Implement auto-complete","user":{"login":"lassoan","id":307929,"node_id":"MDQ6VXNlcjMwNzkyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/307929?v=4","gravatar_id":"","url":"https://api.github.com/users/lassoan","html_url":"https://github.com/lassoan","followers_url":"https://api.github.com/users/lassoan/followers","following_url":"https://api.github.com/users/lassoan/following{/other_user}","gists_url":"https://api.github.com/users/lassoan/gists{/gist_id}","starred_url":"https://api.github.com/users/lassoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lassoan/subscriptions","organizations_url":"https://api.github.com/users/lassoan/orgs","repos_url":"https://api.github.com/users/lassoan/repos","events_url":"https://api.github.com/users/lassoan/events{/privacy}","received_events_url":"https://api.github.com/users/lassoan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lassoan","id":307929,"node_id":"MDQ6VXNlcjMwNzkyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/307929?v=4","gravatar_id":"","url":"https://api.github.com/users/lassoan","html_url":"https://github.com/lassoan","followers_url":"https://api.github.com/users/lassoan/followers","following_url":"https://api.github.com/users/lassoan/following{/other_user}","gists_url":"https://api.github.com/users/lassoan/gists{/gist_id}","starred_url":"https://api.github.com/users/lassoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lassoan/subscriptions","organizations_url":"https://api.github.com/users/lassoan/orgs","repos_url":"https://api.github.com/users/lassoan/repos","events_url":"https://api.github.com/users/lassoan/events{/privacy}","received_events_url":"https://api.github.com/users/lassoan/received_events","type":"User","site_admin":false},"assignees":[{"login":"lassoan","id":307929,"node_id":"MDQ6VXNlcjMwNzkyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/307929?v=4","gravatar_id":"","url":"https://api.github.com/users/lassoan","html_url":"https://github.com/lassoan","followers_url":"https://api.github.com/users/lassoan/followers","following_url":"https://api.github.com/users/lassoan/following{/other_user}","gists_url":"https://api.github.com/users/lassoan/gists{/gist_id}","starred_url":"https://api.github.com/users/lassoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lassoan/subscriptions","organizations_url":"https://api.github.com/users/lassoan/orgs","repos_url":"https://api.github.com/users/lassoan/repos","events_url":"https://api.github.com/users/lassoan/events{/privacy}","received_events_url":"https://api.github.com/users/lassoan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-09T02:19:41Z","updated_at":"2018-07-31T06:04:00Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"If user presses Tab key, auto-completion should be performed. Currently it just performs some hardcoded character replacement.\r\n\r\nxSlicerInterpreter::complete_request_impl needs to be implemented properly. Probably the Python console needs to provide auto-complete feature, which this interpreter class can use."},"comment":{"url":"https://api.github.com/repos/Slicer/SlicerJupyter/issues/comments/409105194","html_url":"https://github.com/Slicer/SlicerJupyter/issues/7#issuecomment-409105194","issue_url":"https://api.github.com/repos/Slicer/SlicerJupyter/issues/7","id":409105194,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTEwNTE5NA==","user":{"login":"lassoan","id":307929,"node_id":"MDQ6VXNlcjMwNzkyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/307929?v=4","gravatar_id":"","url":"https://api.github.com/users/lassoan","html_url":"https://github.com/lassoan","followers_url":"https://api.github.com/users/lassoan/followers","following_url":"https://api.github.com/users/lassoan/following{/other_user}","gists_url":"https://api.github.com/users/lassoan/gists{/gist_id}","starred_url":"https://api.github.com/users/lassoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lassoan/subscriptions","organizations_url":"https://api.github.com/users/lassoan/orgs","repos_url":"https://api.github.com/users/lassoan/repos","events_url":"https://api.github.com/users/lassoan/events{/privacy}","received_events_url":"https://api.github.com/users/lassoan/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T06:04:00Z","updated_at":"2018-07-31T06:04:00Z","author_association":"CONTRIBUTOR","body":"Thanks a lot for working on this. Could you send a pull request, even if its WIP, so that we can easily test this?\r\n\r\nUsing jedi is not an issue, especially if it's a small library with no dependencies.\r\nIt might be confusing if auto-complete results are different from what you get in the embedded Python console in Slicer, but if the results are better then nobody will mind.\r\n\r\nTo get resturn value from executeString, I think you need to run it in _EvalInput_ mode - see example in this test: https://github.com/commontk/CTK/blob/cfbb46a772584e76e1bc0dee9be44008f2e6f943/Libs/Scripting/Python/Core/Testing/Cpp/ctkAbstractPythonManagerTest.cpp#L164-L173"}}
|
{
"id": 138800067,
"name": "Slicer/SlicerJupyter",
"url": "https://api.github.com/repos/Slicer/SlicerJupyter"
}
|
{
"id": 307929,
"login": "lassoan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/307929?",
"url": "https://api.github.com/users/lassoan"
}
|
{
"id": 324362,
"login": "Slicer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/324362?",
"url": "https://api.github.com/orgs/Slicer"
}
| 2018-07-31T06:04:00 |
8041922260
|
{"actor":{"display_login":"lassoan"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/HubSpot/messenger/issues/113","repository_url":"https://api.github.com/repos/HubSpot/messenger","labels_url":"https://api.github.com/repos/HubSpot/messenger/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/HubSpot/messenger/issues/113/comments","events_url":"https://api.github.com/repos/HubSpot/messenger/issues/113/events","html_url":"https://github.com/HubSpot/messenger/issues/113","id":159677530,"number":113,"title":"can it support webpack?","user":{"login":"elvis-macak","id":5038564,"avatar_url":"https://avatars3.githubusercontent.com/u/5038564?v=4","gravatar_id":"","url":"https://api.github.com/users/elvis-macak","html_url":"https://github.com/elvis-macak","followers_url":"https://api.github.com/users/elvis-macak/followers","following_url":"https://api.github.com/users/elvis-macak/following{/other_user}","gists_url":"https://api.github.com/users/elvis-macak/gists{/gist_id}","starred_url":"https://api.github.com/users/elvis-macak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elvis-macak/subscriptions","organizations_url":"https://api.github.com/users/elvis-macak/orgs","repos_url":"https://api.github.com/users/elvis-macak/repos","events_url":"https://api.github.com/users/elvis-macak/events{/privacy}","received_events_url":"https://api.github.com/users/elvis-macak/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-10T16:53:53Z","updated_at":"2018-03-24T14:57:57Z","closed_at":"2018-03-15T15:59:28Z","author_association":"NONE","body":"I meet a problem in using webpack.\n"},"comment":{"url":"https://api.github.com/repos/HubSpot/messenger/issues/comments/375895291","html_url":"https://github.com/HubSpot/messenger/issues/113#issuecomment-375895291","issue_url":"https://api.github.com/repos/HubSpot/messenger/issues/113","id":375895291,"user":{"login":"akarelas","id":423822,"avatar_url":"https://avatars0.githubusercontent.com/u/423822?v=4","gravatar_id":"","url":"https://api.github.com/users/akarelas","html_url":"https://github.com/akarelas","followers_url":"https://api.github.com/users/akarelas/followers","following_url":"https://api.github.com/users/akarelas/following{/other_user}","gists_url":"https://api.github.com/users/akarelas/gists{/gist_id}","starred_url":"https://api.github.com/users/akarelas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarelas/subscriptions","organizations_url":"https://api.github.com/users/akarelas/orgs","repos_url":"https://api.github.com/users/akarelas/repos","events_url":"https://api.github.com/users/akarelas/events{/privacy}","received_events_url":"https://api.github.com/users/akarelas/received_events","type":"User","site_admin":false},"created_at":"2018-03-24T14:57:57Z","updated_at":"2018-03-24T14:57:57Z","author_association":"NONE","body":"Why us (the many) do that, and not you make your module to work with just: `import Messenger from 'messenger'` ?"}}
|
{
"id": 7764245,
"name": "HubSpot/messenger",
"url": "https://api.github.com/repos/HubSpot/messenger"
}
|
{
"id": 423822,
"login": "akarelas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/423822?",
"url": "https://api.github.com/users/akarelas"
}
|
{
"id": 326419,
"login": "HubSpot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/326419?",
"url": "https://api.github.com/orgs/HubSpot"
}
| 2018-03-24T14:57:58 |
7429489024
|
{"actor":{"display_login":"akarelas"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/duckduckgo/content-blocking-whitelist/issues/71","repository_url":"https://api.github.com/repos/duckduckgo/content-blocking-whitelist","labels_url":"https://api.github.com/repos/duckduckgo/content-blocking-whitelist/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/duckduckgo/content-blocking-whitelist/issues/71/comments","events_url":"https://api.github.com/repos/duckduckgo/content-blocking-whitelist/issues/71/events","html_url":"https://github.com/duckduckgo/content-blocking-whitelist/pull/71","id":342503863,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzg5NjUx","number":71,"title":"Add td to list of whitelisted bank sites","user":{"login":"dharb","id":4481594,"node_id":"MDQ6VXNlcjQ0ODE1OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4481594?v=4","gravatar_id":"","url":"https://api.github.com/users/dharb","html_url":"https://github.com/dharb","followers_url":"https://api.github.com/users/dharb/followers","following_url":"https://api.github.com/users/dharb/following{/other_user}","gists_url":"https://api.github.com/users/dharb/gists{/gist_id}","starred_url":"https://api.github.com/users/dharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharb/subscriptions","organizations_url":"https://api.github.com/users/dharb/orgs","repos_url":"https://api.github.com/users/dharb/repos","events_url":"https://api.github.com/users/dharb/events{/privacy}","received_events_url":"https://api.github.com/users/dharb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jdorweiler","id":1882892,"node_id":"MDQ6VXNlcjE4ODI4OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1882892?v=4","gravatar_id":"","url":"https://api.github.com/users/jdorweiler","html_url":"https://github.com/jdorweiler","followers_url":"https://api.github.com/users/jdorweiler/followers","following_url":"https://api.github.com/users/jdorweiler/following{/other_user}","gists_url":"https://api.github.com/users/jdorweiler/gists{/gist_id}","starred_url":"https://api.github.com/users/jdorweiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdorweiler/subscriptions","organizations_url":"https://api.github.com/users/jdorweiler/orgs","repos_url":"https://api.github.com/users/jdorweiler/repos","events_url":"https://api.github.com/users/jdorweiler/events{/privacy}","received_events_url":"https://api.github.com/users/jdorweiler/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdorweiler","id":1882892,"node_id":"MDQ6VXNlcjE4ODI4OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1882892?v=4","gravatar_id":"","url":"https://api.github.com/users/jdorweiler","html_url":"https://github.com/jdorweiler","followers_url":"https://api.github.com/users/jdorweiler/followers","following_url":"https://api.github.com/users/jdorweiler/following{/other_user}","gists_url":"https://api.github.com/users/jdorweiler/gists{/gist_id}","starred_url":"https://api.github.com/users/jdorweiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdorweiler/subscriptions","organizations_url":"https://api.github.com/users/jdorweiler/orgs","repos_url":"https://api.github.com/users/jdorweiler/repos","events_url":"https://api.github.com/users/jdorweiler/events{/privacy}","received_events_url":"https://api.github.com/users/jdorweiler/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-07-18T21:47:15Z","updated_at":"2018-07-20T19:23:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/duckduckgo/content-blocking-whitelist/pulls/71","html_url":"https://github.com/duckduckgo/content-blocking-whitelist/pull/71","diff_url":"https://github.com/duckduckgo/content-blocking-whitelist/pull/71.diff","patch_url":"https://github.com/duckduckgo/content-blocking-whitelist/pull/71.patch"},"body":"As previously mentioned, we are whitelisting banking websites for which we have received breakage reports because they use legitimate fingerprinting to verify users' authenticity. This PR simply adds td.com to the list of sites where we do not block this type of activity."},"comment":{"url":"https://api.github.com/repos/duckduckgo/content-blocking-whitelist/issues/comments/406703050","html_url":"https://github.com/duckduckgo/content-blocking-whitelist/pull/71#issuecomment-406703050","issue_url":"https://api.github.com/repos/duckduckgo/content-blocking-whitelist/issues/71","id":406703050,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjcwMzA1MA==","user":{"login":"jdorweiler","id":1882892,"node_id":"MDQ6VXNlcjE4ODI4OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1882892?v=4","gravatar_id":"","url":"https://api.github.com/users/jdorweiler","html_url":"https://github.com/jdorweiler","followers_url":"https://api.github.com/users/jdorweiler/followers","following_url":"https://api.github.com/users/jdorweiler/following{/other_user}","gists_url":"https://api.github.com/users/jdorweiler/gists{/gist_id}","starred_url":"https://api.github.com/users/jdorweiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdorweiler/subscriptions","organizations_url":"https://api.github.com/users/jdorweiler/orgs","repos_url":"https://api.github.com/users/jdorweiler/repos","events_url":"https://api.github.com/users/jdorweiler/events{/privacy}","received_events_url":"https://api.github.com/users/jdorweiler/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T19:23:40Z","updated_at":"2018-07-20T19:23:40Z","author_association":"CONTRIBUTOR","body":"👍 "}}
|
{
"id": 106460704,
"name": "duckduckgo/content-blocking-whitelist",
"url": "https://api.github.com/repos/duckduckgo/content-blocking-whitelist"
}
|
{
"id": 1882892,
"login": "jdorweiler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1882892?",
"url": "https://api.github.com/users/jdorweiler"
}
|
{
"id": 342708,
"login": "duckduckgo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/342708?",
"url": "https://api.github.com/orgs/duckduckgo"
}
| 2018-07-20T19:23:40 |
7996779138
|
{"actor":{"display_login":"jdorweiler"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/fourkitchens/emulsify/issues/282","repository_url":"https://api.github.com/repos/fourkitchens/emulsify","labels_url":"https://api.github.com/repos/fourkitchens/emulsify/issues/282/labels{/name}","comments_url":"https://api.github.com/repos/fourkitchens/emulsify/issues/282/comments","events_url":"https://api.github.com/repos/fourkitchens/emulsify/issues/282/events","html_url":"https://github.com/fourkitchens/emulsify/issues/282","id":354728206,"node_id":"MDU6SXNzdWUzNTQ3MjgyMDY=","number":282,"title":"Breakpoint Group does not exist","user":{"login":"danny-englander","id":609623,"node_id":"MDQ6VXNlcjYwOTYyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/609623?v=4","gravatar_id":"","url":"https://api.github.com/users/danny-englander","html_url":"https://github.com/danny-englander","followers_url":"https://api.github.com/users/danny-englander/followers","following_url":"https://api.github.com/users/danny-englander/following{/other_user}","gists_url":"https://api.github.com/users/danny-englander/gists{/gist_id}","starred_url":"https://api.github.com/users/danny-englander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danny-englander/subscriptions","organizations_url":"https://api.github.com/users/danny-englander/orgs","repos_url":"https://api.github.com/users/danny-englander/repos","events_url":"https://api.github.com/users/danny-englander/events{/privacy}","received_events_url":"https://api.github.com/users/danny-englander/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-28T13:20:42Z","updated_at":"2018-08-29T18:16:13Z","closed_at":"2018-08-29T15:45:07Z","author_association":"NONE","body":"I see in this merged pull request (https://github.com/fourkitchens/emulsify/pull/187) that there's a test step to \"_Add a new responsive image style and **select Emulsify** for the breakpoint group_\". However, I don't see where there are any groups defined in `emulsify.breakpoints.yml`, thus when I go to add a new responsive image style, there is no evidence of an Emulsify breakpoint group in the UI under /admin/config/media/responsive-image-style/add. Perhaps I am missing something here? Note I have my own generated emulsify theme but to test this, I switched to Emulsify itself to confirm. \r\n\r\nIn https://github.com/fourkitchens/emulsify/blob/develop/emulsify.breakpoints.yml, I don't see any [code for a group](https://www.drupal.org/docs/8/theming-drupal-8/working-with-breakpoints-in-drupal-8) which would be something like:\r\n\r\n```\r\nyourtheme.group1.mobile:\r\n label: narrow\r\n mediaQuery: ''\r\n weight: 0\r\n multipliers:\r\n - 1x\r\n group: yourtheme.group1\r\n```"},"comment":{"url":"https://api.github.com/repos/fourkitchens/emulsify/issues/comments/417052692","html_url":"https://github.com/fourkitchens/emulsify/issues/282#issuecomment-417052692","issue_url":"https://api.github.com/repos/fourkitchens/emulsify/issues/282","id":417052692,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzA1MjY5Mg==","user":{"login":"danny-englander","id":609623,"node_id":"MDQ6VXNlcjYwOTYyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/609623?v=4","gravatar_id":"","url":"https://api.github.com/users/danny-englander","html_url":"https://github.com/danny-englander","followers_url":"https://api.github.com/users/danny-englander/followers","following_url":"https://api.github.com/users/danny-englander/following{/other_user}","gists_url":"https://api.github.com/users/danny-englander/gists{/gist_id}","starred_url":"https://api.github.com/users/danny-englander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danny-englander/subscriptions","organizations_url":"https://api.github.com/users/danny-englander/orgs","repos_url":"https://api.github.com/users/danny-englander/repos","events_url":"https://api.github.com/users/danny-englander/events{/privacy}","received_events_url":"https://api.github.com/users/danny-englander/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T18:16:13Z","updated_at":"2018-08-29T18:16:13Z","author_association":"NONE","body":"@evanmwillhite Ahh, I see, thanks for the explanation! "}}
|
{
"id": 65416944,
"name": "fourkitchens/emulsify",
"url": "https://api.github.com/repos/fourkitchens/emulsify"
}
|
{
"id": 609623,
"login": "danny-englander",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/609623?",
"url": "https://api.github.com/users/danny-englander"
}
|
{
"id": 348885,
"login": "fourkitchens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/348885?",
"url": "https://api.github.com/orgs/fourkitchens"
}
| 2018-08-29T18:16:13 |
8186611133
|
{"actor":{"display_login":"danny-englander"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/ganglia/ganglia-web/issues/260","repository_url":"https://api.github.com/repos/ganglia/ganglia-web","labels_url":"https://api.github.com/repos/ganglia/ganglia-web/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/ganglia/ganglia-web/issues/260/comments","events_url":"https://api.github.com/repos/ganglia/ganglia-web/issues/260/events","html_url":"https://github.com/ganglia/ganglia-web/issues/260","id":52803946,"number":260,"title":"gmetric with --slope=positive","user":{"login":"shorman88","id":7731747,"avatar_url":"https://avatars2.githubusercontent.com/u/7731747?v=4","gravatar_id":"","url":"https://api.github.com/users/shorman88","html_url":"https://github.com/shorman88","followers_url":"https://api.github.com/users/shorman88/followers","following_url":"https://api.github.com/users/shorman88/following{/other_user}","gists_url":"https://api.github.com/users/shorman88/gists{/gist_id}","starred_url":"https://api.github.com/users/shorman88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shorman88/subscriptions","organizations_url":"https://api.github.com/users/shorman88/orgs","repos_url":"https://api.github.com/users/shorman88/repos","events_url":"https://api.github.com/users/shorman88/events{/privacy}","received_events_url":"https://api.github.com/users/shorman88/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2014-12-24T08:20:48Z","updated_at":"2018-02-16T12:33:39Z","closed_at":null,"author_association":"NONE","body":"Hello,\n\nI'm facing issue when i use --slope=positive.\ni'm using gmetric to plot counter value every 5 min.\n\nthe values are counted correctly but the the period between the checks show zeros for example:\nat 11:00 the value is 100 at 11:05 the value is 150 but the value between 11:00 and 11:05 is zero but it should be 100.\n\n./gmetric -c /etc/gmond.conf --name='check-name' --title=\"check title\" --value=`cat /tmp/file.txt` --units=\"query\" --type=int32 --slope=positive\n\nAny ideas to fix the issue?\n\nThanks\n"},"comment":{"url":"https://api.github.com/repos/ganglia/ganglia-web/issues/comments/366224011","html_url":"https://github.com/ganglia/ganglia-web/issues/260#issuecomment-366224011","issue_url":"https://api.github.com/repos/ganglia/ganglia-web/issues/260","id":366224011,"user":{"login":"wookietreiber","id":827088,"avatar_url":"https://avatars0.githubusercontent.com/u/827088?v=4","gravatar_id":"","url":"https://api.github.com/users/wookietreiber","html_url":"https://github.com/wookietreiber","followers_url":"https://api.github.com/users/wookietreiber/followers","following_url":"https://api.github.com/users/wookietreiber/following{/other_user}","gists_url":"https://api.github.com/users/wookietreiber/gists{/gist_id}","starred_url":"https://api.github.com/users/wookietreiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wookietreiber/subscriptions","organizations_url":"https://api.github.com/users/wookietreiber/orgs","repos_url":"https://api.github.com/users/wookietreiber/repos","events_url":"https://api.github.com/users/wookietreiber/events{/privacy}","received_events_url":"https://api.github.com/users/wookietreiber/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T12:33:38Z","updated_at":"2018-02-16T12:33:38Z","author_association":"NONE","body":"@shorman88 I guess you need to also specify `--tmax`."}}
|
{
"id": 3071267,
"name": "ganglia/ganglia-web",
"url": "https://api.github.com/repos/ganglia/ganglia-web"
}
|
{
"id": 827088,
"login": "wookietreiber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/827088?",
"url": "https://api.github.com/users/wookietreiber"
}
|
{
"id": 360097,
"login": "ganglia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/360097?",
"url": "https://api.github.com/orgs/ganglia"
}
| 2018-02-16T12:33:39 |
7254804923
|
{"actor":{"display_login":"wookietreiber"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/datadog-agent-boshrelease/issues/37","repository_url":"https://api.github.com/repos/DataDog/datadog-agent-boshrelease","labels_url":"https://api.github.com/repos/DataDog/datadog-agent-boshrelease/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent-boshrelease/issues/37/comments","events_url":"https://api.github.com/repos/DataDog/datadog-agent-boshrelease/issues/37/events","html_url":"https://github.com/DataDog/datadog-agent-boshrelease/issues/37","id":332503161,"node_id":"MDU6SXNzdWUzMzI1MDMxNjE=","number":37,"title":"Enabling trace-agent to start with the regular datadog agent","user":{"login":"donghoang89","id":17553637,"node_id":"MDQ6VXNlcjE3NTUzNjM3","avatar_url":"https://avatars0.githubusercontent.com/u/17553637?v=4","gravatar_id":"","url":"https://api.github.com/users/donghoang89","html_url":"https://github.com/donghoang89","followers_url":"https://api.github.com/users/donghoang89/followers","following_url":"https://api.github.com/users/donghoang89/following{/other_user}","gists_url":"https://api.github.com/users/donghoang89/gists{/gist_id}","starred_url":"https://api.github.com/users/donghoang89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donghoang89/subscriptions","organizations_url":"https://api.github.com/users/donghoang89/orgs","repos_url":"https://api.github.com/users/donghoang89/repos","events_url":"https://api.github.com/users/donghoang89/events{/privacy}","received_events_url":"https://api.github.com/users/donghoang89/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-14T17:54:28Z","updated_at":"2018-06-14T18:21:43Z","closed_at":null,"author_association":"NONE","body":"**Steps to reproduce the issue:**\r\n1. Clone DataDog/datadog-agent-boshrelease\r\n2. Run \"bosh create-release\" to build the boshrelease for datadog-agent\r\n3. Run \"bosh upload-release\" to push the newly created release to private bosh director\r\n4. Create a bosh manifest to deploy a server with datadog-agent boshrelease\r\n\r\n[sample manifest]\r\n---\r\nname: datadog-test\r\n\r\nreleases:\r\n- name: datadog-agent\r\n version: latest\r\n\r\nstemcells:\r\n- alias: trusty\r\n os: ubuntu-trusty\r\n version: 3445.2\r\n\r\ninstance_groups:\r\n- name: dd-agent\r\n instances: 1\r\n jobs:\r\n - name: dd-agent\r\n release: datadog-agent\r\n properties:\r\n dd:\r\n use_dogstatsd: yes\r\n api_key: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\r\n tags: [\"datadog\", \"bosh\", \"bosh:bosh-exp\"]\r\n vm_type: small\r\n stemcell: trusty\r\n persistent_disk: 10240\r\n networks:\r\n - name: xxxxxxxxxxxxxxxxxxxxxx\r\n azs:\r\n - aws-east-1d\r\n\r\nupdate:\r\n canaries: 1\r\n canary_watch_time: 30000-180000\r\n update_watch_time: 30000-180000\r\n max_in_flight: 1\r\n serial: false \r\n[/sample manifest]\r\n\r\n5. Run \"bosh ssh\" to log into the new server\r\n6. Run \"monit summary\" to verify that datadog-agent boshrelease has been deployed and is running\r\n7. Run \"ps -ef | grep dd\" to see which datadog process is running\r\n\r\n\r\n**Describe the results you received:**\r\n[ps output]\r\ndd-agent/4c499116-f242-49b6-9d75-c9874b700a02:~# ps -ef | grep dd\r\nroot 2 0 0 17:27 ? 00:00:00 [kthreadd]\r\nvcap 11184 1 1 17:36 ? 00:00:00 /var/vcap/jobs/dd-agent/packages/dd-agent/bin/agent/agent start -c /var/vcap/jobs/dd-agent/config/ -p /var/vcap/sys/run/dd-agent/agent.pid\r\nroot 11456 11433 0 17:37 pts/1 00:00:00 grep --color=auto dd\r\n[/ps output]\r\n\r\n**Describe the results you expected:**\r\n[ps output]\r\ndd-agent/4c499116-f242-49b6-9d75-c9874b700a02:~# ps -ef | grep dd\r\nroot 2 0 0 17:27 ? 00:00:00 [kthreadd]\r\nroot 15733 1 0 17:44 ? 00:00:00 bash /var/vcap/jobs/dd-agent/bin/agent_ctl start\r\nvcap 15765 15733 1 17:44 ? 00:00:00 /var/vcap/jobs/dd-agent/packages/dd-agent/bin/agent/agent start -c /var/vcap/jobs/dd-agent/config/ -p /var/vcap/sys/run/dd-agent/agent.pid\r\nroot 15767 15733 0 17:44 ? 00:00:00 /var/vcap/jobs/dd-agent/packages/dd-agent/embedded/bin/trace-agent --config /var/vcap/jobs/dd-agent/config/datadog.yaml --pid /var/vcap/jobs/dd-agent/run/trace-agent.pid\r\nroot 16055 15991 0 17:45 pts/1 00:00:00 grep --color=auto dd\r\n[/ps output]\r\n\r\n\r\n**Additional information you deem important (e.g. issue happens only occasionally):**\r\nThe issue is that datadog-agent startup script, agent_ctl, only start the agent binary and not the trace-agent binary.\r\n\r\nI have added the trace-agent startup portion and tested the developmental datadog-agent boshrelease on my environment. The trace-agent was able to start and make APM report to datadog server. \r\n\r\nI would like to contribute this change back to datadog-agent boshrelease. My forked repo is at https://github.com/donghoang89/datadog-agent-boshrelease . All the changes can be viewed at https://github.com/donghoang89/datadog-agent-boshrelease/commit/68f7f418dcc4d8b7222b33e2271e49471bed3df4 . "},"comment":{"url":"https://api.github.com/repos/DataDog/datadog-agent-boshrelease/issues/comments/397391690","html_url":"https://github.com/DataDog/datadog-agent-boshrelease/issues/37#issuecomment-397391690","issue_url":"https://api.github.com/repos/DataDog/datadog-agent-boshrelease/issues/37","id":397391690,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzM5MTY5MA==","user":{"login":"donghoang89","id":17553637,"node_id":"MDQ6VXNlcjE3NTUzNjM3","avatar_url":"https://avatars0.githubusercontent.com/u/17553637?v=4","gravatar_id":"","url":"https://api.github.com/users/donghoang89","html_url":"https://github.com/donghoang89","followers_url":"https://api.github.com/users/donghoang89/followers","following_url":"https://api.github.com/users/donghoang89/following{/other_user}","gists_url":"https://api.github.com/users/donghoang89/gists{/gist_id}","starred_url":"https://api.github.com/users/donghoang89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donghoang89/subscriptions","organizations_url":"https://api.github.com/users/donghoang89/orgs","repos_url":"https://api.github.com/users/donghoang89/repos","events_url":"https://api.github.com/users/donghoang89/events{/privacy}","received_events_url":"https://api.github.com/users/donghoang89/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T18:21:43Z","updated_at":"2018-06-14T18:21:43Z","author_association":"NONE","body":"{noformat}\r\n---\r\nname: datadog-test\r\n\r\nreleases:\r\n- name: datadog-agent\r\n version: latest\r\n\r\nstemcells:\r\n- alias: trusty\r\n os: ubuntu-trusty\r\n version: 3445.2\r\n\r\ninstance_groups:\r\n- name: dd-agent\r\n instances: 1\r\n jobs:\r\n - name: dd-agent\r\n release: datadog-agent\r\n properties:\r\n dd:\r\n use_dogstatsd: yes\r\n api_key: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\r\n tags: [\"datadog\", \"bosh\", \"bosh:bosh-exp\"]\r\n vm_type: small\r\n stemcell: trusty\r\n persistent_disk: 10240\r\n networks:\r\n - name: xxxxxxxxxxxxxxxxxxxxxx\r\n azs:\r\n - aws-east-1d\r\n\r\nupdate:\r\n canaries: 1\r\n canary_watch_time: 30000-180000\r\n update_watch_time: 30000-180000\r\n max_in_flight: 1\r\n serial: false\r\n{/noformat}"}}
|
{
"id": 86105058,
"name": "DataDog/datadog-agent-boshrelease",
"url": "https://api.github.com/repos/DataDog/datadog-agent-boshrelease"
}
|
{
"id": 17553637,
"login": "donghoang89",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17553637?",
"url": "https://api.github.com/users/donghoang89"
}
|
{
"id": 365230,
"login": "DataDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365230?",
"url": "https://api.github.com/orgs/DataDog"
}
| 2018-06-14T18:21:43 |
7826816574
|
{"actor":{"display_login":"donghoang89"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/344","repository_url":"https://api.github.com/repos/DataDog/dd-trace-java","labels_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/344/comments","events_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/344/events","html_url":"https://github.com/DataDog/dd-trace-java/issues/344","id":329848854,"node_id":"MDU6SXNzdWUzMjk4NDg4NTQ=","number":344,"title":"ClassCastException","user":{"login":"snusontable","id":39991576,"node_id":"MDQ6VXNlcjM5OTkxNTc2","avatar_url":"https://avatars1.githubusercontent.com/u/39991576?v=4","gravatar_id":"","url":"https://api.github.com/users/snusontable","html_url":"https://github.com/snusontable","followers_url":"https://api.github.com/users/snusontable/followers","following_url":"https://api.github.com/users/snusontable/following{/other_user}","gists_url":"https://api.github.com/users/snusontable/gists{/gist_id}","starred_url":"https://api.github.com/users/snusontable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snusontable/subscriptions","organizations_url":"https://api.github.com/users/snusontable/orgs","repos_url":"https://api.github.com/users/snusontable/repos","events_url":"https://api.github.com/users/snusontable/events{/privacy}","received_events_url":"https://api.github.com/users/snusontable/received_events","type":"User","site_admin":false},"labels":[{"id":590567356,"node_id":"MDU6TGFiZWw1OTA1NjczNTY=","url":"https://api.github.com/repos/DataDog/dd-trace-java/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"state":"open","locked":false,"assignee":{"login":"realark","id":31153155,"node_id":"MDQ6VXNlcjMxMTUzMTU1","avatar_url":"https://avatars1.githubusercontent.com/u/31153155?v=4","gravatar_id":"","url":"https://api.github.com/users/realark","html_url":"https://github.com/realark","followers_url":"https://api.github.com/users/realark/followers","following_url":"https://api.github.com/users/realark/following{/other_user}","gists_url":"https://api.github.com/users/realark/gists{/gist_id}","starred_url":"https://api.github.com/users/realark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realark/subscriptions","organizations_url":"https://api.github.com/users/realark/orgs","repos_url":"https://api.github.com/users/realark/repos","events_url":"https://api.github.com/users/realark/events{/privacy}","received_events_url":"https://api.github.com/users/realark/received_events","type":"User","site_admin":false},"assignees":[{"login":"realark","id":31153155,"node_id":"MDQ6VXNlcjMxMTUzMTU1","avatar_url":"https://avatars1.githubusercontent.com/u/31153155?v=4","gravatar_id":"","url":"https://api.github.com/users/realark","html_url":"https://github.com/realark","followers_url":"https://api.github.com/users/realark/followers","following_url":"https://api.github.com/users/realark/following{/other_user}","gists_url":"https://api.github.com/users/realark/gists{/gist_id}","starred_url":"https://api.github.com/users/realark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realark/subscriptions","organizations_url":"https://api.github.com/users/realark/orgs","repos_url":"https://api.github.com/users/realark/repos","events_url":"https://api.github.com/users/realark/events{/privacy}","received_events_url":"https://api.github.com/users/realark/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-06-06T12:36:50Z","updated_at":"2018-11-29T16:09:32Z","closed_at":null,"author_association":"NONE","body":"Following the steps in setting up apm and restarting tomcat we get a nasty exception message in our log:\r\n\r\n``\r\njava.lang.ClassCastException: datadog.trace.instrumentation.java.concurrent.ExecutorInstrumentation$CallableWrapper cannot be cast to company.common.asynchronous.immediatetasking.TaskWrapper\r\n company.common.asynchronous.immediatetasking.WrapperFutureTask.<init>(WrapperFutureTask.java:42)\r\n company.common.asynchronous.immediatetasking.TaskExecutorThreadPool.newTaskFor(TaskExecutorThreadPool.java:57)\r\n java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:133)\r\n company.common.asynchronous.immediatetasking.TaskExecutorThreadPool.submit(TaskExecutorThreadPool.java:48)\r\n company.common.asynchronous.immediatetasking.TaskExecutor.addTask(TaskExecutor.java:246)\r\n company.common.asynchronous.immediatetasking.TaskExecutor.addTask(TaskExecutor.java:218)\r\n company.common.asynchronous.immediatetasking.TaskExecutor.execute(TaskExecutor.java:99)\r\n company.service.cache.IntervalCache.updateCacheIfNecessary(IntervalCache.java:51)\r\n company.service.helptexts.HelpTextCache.getHelpLinks(HelpTextCache.java:63)\r\n company.service.helptexts.HelpTextServiceImplementation.getHelpLinks(HelpTextServiceImplementation.java:51)\r\n sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n java.lang.reflect.Method.invoke(Method.java:498)\r\n...``\r\n\r\nBefore over committing to debugging I figured maybe the problem is in datadogs end."},"comment":{"url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/comments/442891205","html_url":"https://github.com/DataDog/dd-trace-java/issues/344#issuecomment-442891205","issue_url":"https://api.github.com/repos/DataDog/dd-trace-java/issues/344","id":442891205,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mjg5MTIwNQ==","user":{"login":"tylerbenson","id":734411,"node_id":"MDQ6VXNlcjczNDQxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/734411?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerbenson","html_url":"https://github.com/tylerbenson","followers_url":"https://api.github.com/users/tylerbenson/followers","following_url":"https://api.github.com/users/tylerbenson/following{/other_user}","gists_url":"https://api.github.com/users/tylerbenson/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerbenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerbenson/subscriptions","organizations_url":"https://api.github.com/users/tylerbenson/orgs","repos_url":"https://api.github.com/users/tylerbenson/repos","events_url":"https://api.github.com/users/tylerbenson/events{/privacy}","received_events_url":"https://api.github.com/users/tylerbenson/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T16:09:32Z","updated_at":"2018-11-29T16:09:32Z","author_association":"COLLABORATOR","body":"@codylerum we made some improvements in `0.16.0` that may improve things for your specific case (https://github.com/DataDog/dd-trace-java/commit/3d78afbc2c5d9cfd2177ad75cf1d6843aa4bf8dc) but we are actively working on a longterm solution. (See latest work here: #564)\r\n\r\nEither way, you can still apply the setting that @realark mentioned to disable the executor instrumentation. That should allow you to update either way."}}
|
{
"id": 89221572,
"name": "DataDog/dd-trace-java",
"url": "https://api.github.com/repos/DataDog/dd-trace-java"
}
|
{
"id": 734411,
"login": "tylerbenson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/734411?",
"url": "https://api.github.com/users/tylerbenson"
}
|
{
"id": 365230,
"login": "DataDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365230?",
"url": "https://api.github.com/orgs/DataDog"
}
| 2018-11-29T16:09:32 |
8670281233
|
{"actor":{"display_login":"tylerbenson"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/opencensus-go-exporter-datadog/issues/18","repository_url":"https://api.github.com/repos/DataDog/opencensus-go-exporter-datadog","labels_url":"https://api.github.com/repos/DataDog/opencensus-go-exporter-datadog/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/opencensus-go-exporter-datadog/issues/18/comments","events_url":"https://api.github.com/repos/DataDog/opencensus-go-exporter-datadog/issues/18/events","html_url":"https://github.com/DataDog/opencensus-go-exporter-datadog/issues/18","id":374094400,"node_id":"MDU6SXNzdWUzNzQwOTQ0MDA=","number":18,"title":"NewExporter() exits the program if StatsAddr is invalid","user":{"login":"arguile-","id":756863,"node_id":"MDQ6VXNlcjc1Njg2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/756863?v=4","gravatar_id":"","url":"https://api.github.com/users/arguile-","html_url":"https://github.com/arguile-","followers_url":"https://api.github.com/users/arguile-/followers","following_url":"https://api.github.com/users/arguile-/following{/other_user}","gists_url":"https://api.github.com/users/arguile-/gists{/gist_id}","starred_url":"https://api.github.com/users/arguile-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arguile-/subscriptions","organizations_url":"https://api.github.com/users/arguile-/orgs","repos_url":"https://api.github.com/users/arguile-/repos","events_url":"https://api.github.com/users/arguile-/events{/privacy}","received_events_url":"https://api.github.com/users/arguile-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-25T19:20:13Z","updated_at":"2018-12-27T18:55:59Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"If you initialize the exporter with an invalid dogstatd address it exits the program instead of returning an error.\r\n\r\nEg.\r\n```go\r\ndd := datadog.NewExporter(datadog.Options{\r\n\tStatsAddr: \"invalid_address\",\r\n})\r\n```\r\n\r\nResults in a log like the below and a program exit.\r\n```\r\n2018/10/25 15:14:50 address invalid_address: missing port in address\r\n```\r\n\r\nThis is due to:\r\n\r\n```go\r\nfunc newStatsExporter(o Options) *statsExporter {\r\n\tendpoint := o.StatsAddr\r\n\tif endpoint == \"\" {\r\n\t\tendpoint = defaultStatsAddr\r\n\t}\r\n\r\n\tclient, err := statsd.New(endpoint)\r\n\tif err != nil {\r\n\t\tlog.Fatal(err) // <--- this\r\n\t}\r\n```\r\n\r\nIt's poor behaviour to terminate the program within a package. Returning an error would require a signature change though. Another option would be to just call the provided `OnError`.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/DataDog/opencensus-go-exporter-datadog/issues/comments/450209979","html_url":"https://github.com/DataDog/opencensus-go-exporter-datadog/issues/18#issuecomment-450209979","issue_url":"https://api.github.com/repos/DataDog/opencensus-go-exporter-datadog/issues/18","id":450209979,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDIwOTk3OQ==","user":{"login":"DazWilkin","id":1022400,"node_id":"MDQ6VXNlcjEwMjI0MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1022400?v=4","gravatar_id":"","url":"https://api.github.com/users/DazWilkin","html_url":"https://github.com/DazWilkin","followers_url":"https://api.github.com/users/DazWilkin/followers","following_url":"https://api.github.com/users/DazWilkin/following{/other_user}","gists_url":"https://api.github.com/users/DazWilkin/gists{/gist_id}","starred_url":"https://api.github.com/users/DazWilkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DazWilkin/subscriptions","organizations_url":"https://api.github.com/users/DazWilkin/orgs","repos_url":"https://api.github.com/users/DazWilkin/repos","events_url":"https://api.github.com/users/DazWilkin/events{/privacy}","received_events_url":"https://api.github.com/users/DazWilkin/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T18:55:59Z","updated_at":"2018-12-27T18:55:59Z","author_association":"NONE","body":"[Most] Other Exporters (Azure, AWS, Jaeger, Prometheus, Stackdriver) do return `(*Exporter, error)`.\r\n\r\nWhile it would require a signature change for Datadog, it would make the Exporter more consistent.\r\n\r\nI filed a FR against OpenCensus to correct their documentation (that assumes the returned error):\r\nhttps://github.com/census-instrumentation/opencensus-website/pull/520"}}
|
{
"id": 135628847,
"name": "DataDog/opencensus-go-exporter-datadog",
"url": "https://api.github.com/repos/DataDog/opencensus-go-exporter-datadog"
}
|
{
"id": 1022400,
"login": "DazWilkin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1022400?",
"url": "https://api.github.com/users/DazWilkin"
}
|
{
"id": 365230,
"login": "DataDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365230?",
"url": "https://api.github.com/orgs/DataDog"
}
| 2018-12-27T18:56:00 |
8809302204
|
{"actor":{"display_login":"DazWilkin"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11350","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11350/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11350/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11350/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11350","id":335242407,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTg5NTYz","number":11350,"title":"[MRG] ChainedImputer -> IterativeImputer, and documentation update","user":{"login":"sergeyf","id":1874668,"node_id":"MDQ6VXNlcjE4NzQ2Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1874668?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeyf","html_url":"https://github.com/sergeyf","followers_url":"https://api.github.com/users/sergeyf/followers","following_url":"https://api.github.com/users/sergeyf/following{/other_user}","gists_url":"https://api.github.com/users/sergeyf/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeyf/subscriptions","organizations_url":"https://api.github.com/users/sergeyf/orgs","repos_url":"https://api.github.com/users/sergeyf/repos","events_url":"https://api.github.com/users/sergeyf/events{/privacy}","received_events_url":"https://api.github.com/users/sergeyf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":52,"created_at":"2018-06-25T02:49:26Z","updated_at":"2018-07-17T19:50:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11350","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11350","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/11350.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/11350.patch"},"body":"Addresses two points as discussed in #11259:\r\n(a) Removes the \"average last `n_imputations` behavior\". Now there just one parameter `n_iter` instead of the two: `n_burn_in` and `n_imputations`.\r\n(b) New flag: `sample_after_predict`, which is `False` by default. If true it will sample from the predictive posterior after predicting during each round-robin iteration. Turning it on will make `ChainedImputer` run a single \r\n\r\n@jnothman @glemaitre: I think `ChainedImputer` needs a new check: if `sample_after_predict=True`, then the predictor needs to have `return_std` as a parameter of its `predict` method. What's best practice for checking something like that?\r\n\r\nAlso, we may want a new example of how to use `ChainedImputer` for the purpose of a MICE-type analysis, and how to use `ChainedImputer` with a `RandomForest` as the predictor instead of `BayesianRidge` to demonstrate missForest functionality. \r\n\r\nI think @RianneSchouten would be a good candidate for the MICE example as a contribution to this PR or a new one, and I can stick `ChainedImputer` + RF into `plot_missing_values.py` as another bar on the plot. Let me know how that sounds."},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/405706162","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11350#issuecomment-405706162","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11350","id":405706162,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTcwNjE2Mg==","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T19:50:54Z","updated_at":"2018-07-17T19:50:54Z","author_association":"CONTRIBUTOR","body":"OK, the revert (https://github.com/scikit-learn/scikit-learn/pull/11600) is merged. Next, I will make a branch that adds it back, and rebase this PR on top of that (but will first focus on release critical things)"}}
|
{
"id": 843222,
"name": "scikit-learn/scikit-learn",
"url": "https://api.github.com/repos/scikit-learn/scikit-learn"
}
|
{
"id": 1020496,
"login": "jorisvandenbossche",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1020496?",
"url": "https://api.github.com/users/jorisvandenbossche"
}
|
{
"id": 365630,
"login": "scikit-learn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365630?",
"url": "https://api.github.com/orgs/scikit-learn"
}
| 2018-07-17T19:50:55 |
7978891256
|
{"actor":{"display_login":"jorisvandenbossche"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12177","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12177/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12177/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12177/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12177","id":364220649,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDYyMDM2","number":12177,"title":"[WIP] sample from a truncated normal instead of clipping samples from a normal","user":{"login":"benlawson","id":7769994,"node_id":"MDQ6VXNlcjc3Njk5OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7769994?v=4","gravatar_id":"","url":"https://api.github.com/users/benlawson","html_url":"https://github.com/benlawson","followers_url":"https://api.github.com/users/benlawson/followers","following_url":"https://api.github.com/users/benlawson/following{/other_user}","gists_url":"https://api.github.com/users/benlawson/gists{/gist_id}","starred_url":"https://api.github.com/users/benlawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlawson/subscriptions","organizations_url":"https://api.github.com/users/benlawson/orgs","repos_url":"https://api.github.com/users/benlawson/repos","events_url":"https://api.github.com/users/benlawson/events{/privacy}","received_events_url":"https://api.github.com/users/benlawson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-26T21:34:40Z","updated_at":"2018-09-27T18:14:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12177","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12177","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/12177.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/12177.patch"},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\nRelated to \"Merge iterativeimputer branch into master\" #11977\r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nWhen sampling from the posterior and boundary values are given, the current implementation clips values that are sampled from normal distribution. This can lead to undesired oversampling of the boundary values. For example, if our boundaries were [0, 2] and we have a mean of 0 and standard deviation of 1, the difference between sampling from a normal and clipping and a truncated normal is shown here:\r\n\r\n```python \r\nfrom scipy.stats import norm, truncnorm\r\nimport matplotlib.pyplot as plt \r\nimport numpy as np\r\n\r\nnorm_dis = norm(loc=0, scale=1)\r\ntruc_dis = truncnorm(a=0, b=2, loc=0, scale=1)\r\ntrucs = truc_dis.rvs(10000)\r\nnorms = norm_dis.rvs(10000)\r\nnorms = np.clip(norms, 0, 2)\r\nplt.hist(norms, histtype='step')\r\nplt.hist(trucs, histtype='step')\r\nplt.legend([\"clipped normal\", \"truncated normal\"])\r\nplt.show()\r\n```\r\n\r\n\r\nWhen sampling from the posterior, this PR samples from a truncated normal distribution instead of clipping values that have been sampled from a normal distribution. \r\n\r\n#### Any other comments?\r\nTo impute values within boundaries, the `MICE` R package appears to clip values[1] while the `mi` R package uses the truncated normal to sample[2] within the user given range. Open to discussing which approach is best. \r\n\r\n\r\n[1] page 149, https://cran.r-project.org/web/packages/mice/mice.pdf \r\n[2] page 21, https://cran.r-project.org/web/packages/mi/mi.pdf\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/425192244","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12177#issuecomment-425192244","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12177","id":425192244,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTE5MjI0NA==","user":{"login":"sklearn-lgtm","id":35436680,"node_id":"MDQ6VXNlcjM1NDM2Njgw","avatar_url":"https://avatars1.githubusercontent.com/u/35436680?v=4","gravatar_id":"","url":"https://api.github.com/users/sklearn-lgtm","html_url":"https://github.com/sklearn-lgtm","followers_url":"https://api.github.com/users/sklearn-lgtm/followers","following_url":"https://api.github.com/users/sklearn-lgtm/following{/other_user}","gists_url":"https://api.github.com/users/sklearn-lgtm/gists{/gist_id}","starred_url":"https://api.github.com/users/sklearn-lgtm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sklearn-lgtm/subscriptions","organizations_url":"https://api.github.com/users/sklearn-lgtm/orgs","repos_url":"https://api.github.com/users/sklearn-lgtm/repos","events_url":"https://api.github.com/users/sklearn-lgtm/events{/privacy}","received_events_url":"https://api.github.com/users/sklearn-lgtm/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T18:14:54Z","updated_at":"2018-09-27T18:14:54Z","author_association":"NONE","body":"This pull request **introduces 2 alerts** when merging 21d7238baf1a40a1983824e0c6ac947853b69d5d into a4f2a89546a455a914a08f7e651e5e85823c0c16 - [view on LGTM.com](https://lgtm.com/projects/g/scikit-learn/scikit-learn/rev/pr-17403994b34d3e728a6ab63ad1a1fad2e8d3d1e7)\n\n**new alerts:**\n\n* 2 for Unused import\n\n---\n\n*Comment posted by [LGTM.com](https://lgtm.com)*"}}
|
{
"id": 843222,
"name": "scikit-learn/scikit-learn",
"url": "https://api.github.com/repos/scikit-learn/scikit-learn"
}
|
{
"id": 35436680,
"login": "sklearn-lgtm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35436680?",
"url": "https://api.github.com/users/sklearn-lgtm"
}
|
{
"id": 365630,
"login": "scikit-learn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365630?",
"url": "https://api.github.com/orgs/scikit-learn"
}
| 2018-09-27T18:14:54 |
8333523861
|
{"actor":{"display_login":"sklearn-lgtm"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10589","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10589/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10589/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10589/events","html_url":"https://github.com/scikit-learn/scikit-learn/issues/10589","id":294369035,"number":10589,"title":"Weighted Feature sampling in Random Forests","user":{"login":"raphaelcampos","id":3073266,"avatar_url":"https://avatars0.githubusercontent.com/u/3073266?v=4","gravatar_id":"","url":"https://api.github.com/users/raphaelcampos","html_url":"https://github.com/raphaelcampos","followers_url":"https://api.github.com/users/raphaelcampos/followers","following_url":"https://api.github.com/users/raphaelcampos/following{/other_user}","gists_url":"https://api.github.com/users/raphaelcampos/gists{/gist_id}","starred_url":"https://api.github.com/users/raphaelcampos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphaelcampos/subscriptions","organizations_url":"https://api.github.com/users/raphaelcampos/orgs","repos_url":"https://api.github.com/users/raphaelcampos/repos","events_url":"https://api.github.com/users/raphaelcampos/events{/privacy}","received_events_url":"https://api.github.com/users/raphaelcampos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-05T12:01:56Z","updated_at":"2018-02-05T12:59:55Z","closed_at":null,"author_association":"NONE","body":"Hello Scikit Comunity,\r\n\r\nIn order to validate one of my hypothesis, I want the Random Forest to be able to draw the candidate features for split using weight sampling without replacement.\r\n\r\nI wonder whether I only need to change the function on the following line:\r\nhttps://github.com/scikit-learn/scikit-learn/blob/6919a22c8023f4c2f30849c7ce05de745b6d6c1a/sklearn/tree/_splitter.pyx#L1287, and permutate the weight feature as well. Or it would be more complicated.\r\n\r\nCould someone shed a light on this issue?\r\n\r\nThanks in advance.\r\n\r\nRaphael Campos"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/363077698","html_url":"https://github.com/scikit-learn/scikit-learn/issues/10589#issuecomment-363077698","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10589","id":363077698,"user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T12:59:55Z","updated_at":"2018-02-05T12:59:55Z","author_association":"OWNER","body":"You should probably be asking this on the mailing list or similar. It is\nnot an issue with the software. However: That line only applies to\nBestSparseSplitter. You will need to find a way to pass the weight in, and\nto manage selection without replacement.\n"}}
|
{
"id": 843222,
"name": "scikit-learn/scikit-learn",
"url": "https://api.github.com/repos/scikit-learn/scikit-learn"
}
|
{
"id": 78827,
"login": "jnothman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/78827?",
"url": "https://api.github.com/users/jnothman"
}
|
{
"id": 365630,
"login": "scikit-learn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365630?",
"url": "https://api.github.com/orgs/scikit-learn"
}
| 2018-02-05T12:59:55 |
7198481513
|
{"actor":{"display_login":"jnothman"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/canoo/dolphin-platform/issues/876","repository_url":"https://api.github.com/repos/canoo/dolphin-platform","labels_url":"https://api.github.com/repos/canoo/dolphin-platform/issues/876/labels{/name}","comments_url":"https://api.github.com/repos/canoo/dolphin-platform/issues/876/comments","events_url":"https://api.github.com/repos/canoo/dolphin-platform/issues/876/events","html_url":"https://github.com/canoo/dolphin-platform/pull/876","id":306412793,"number":876,"title":"final keywords and null checks in server module","user":{"login":"hendrikebbers","id":9443847,"avatar_url":"https://avatars2.githubusercontent.com/u/9443847?v=4","gravatar_id":"","url":"https://api.github.com/users/hendrikebbers","html_url":"https://github.com/hendrikebbers","followers_url":"https://api.github.com/users/hendrikebbers/followers","following_url":"https://api.github.com/users/hendrikebbers/following{/other_user}","gists_url":"https://api.github.com/users/hendrikebbers/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikebbers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikebbers/subscriptions","organizations_url":"https://api.github.com/users/hendrikebbers/orgs","repos_url":"https://api.github.com/users/hendrikebbers/repos","events_url":"https://api.github.com/users/hendrikebbers/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikebbers/received_events","type":"User","site_admin":false},"labels":[{"id":317030247,"url":"https://api.github.com/repos/canoo/dolphin-platform/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"hendrikebbers","id":9443847,"avatar_url":"https://avatars2.githubusercontent.com/u/9443847?v=4","gravatar_id":"","url":"https://api.github.com/users/hendrikebbers","html_url":"https://github.com/hendrikebbers","followers_url":"https://api.github.com/users/hendrikebbers/followers","following_url":"https://api.github.com/users/hendrikebbers/following{/other_user}","gists_url":"https://api.github.com/users/hendrikebbers/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikebbers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikebbers/subscriptions","organizations_url":"https://api.github.com/users/hendrikebbers/orgs","repos_url":"https://api.github.com/users/hendrikebbers/repos","events_url":"https://api.github.com/users/hendrikebbers/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikebbers/received_events","type":"User","site_admin":false},"assignees":[{"login":"hendrikebbers","id":9443847,"avatar_url":"https://avatars2.githubusercontent.com/u/9443847?v=4","gravatar_id":"","url":"https://api.github.com/users/hendrikebbers","html_url":"https://github.com/hendrikebbers","followers_url":"https://api.github.com/users/hendrikebbers/followers","following_url":"https://api.github.com/users/hendrikebbers/following{/other_user}","gists_url":"https://api.github.com/users/hendrikebbers/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikebbers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikebbers/subscriptions","organizations_url":"https://api.github.com/users/hendrikebbers/orgs","repos_url":"https://api.github.com/users/hendrikebbers/repos","events_url":"https://api.github.com/users/hendrikebbers/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikebbers/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-03-19T10:50:47Z","updated_at":"2018-03-19T10:51:15Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/canoo/dolphin-platform/pulls/876","html_url":"https://github.com/canoo/dolphin-platform/pull/876","diff_url":"https://github.com/canoo/dolphin-platform/pull/876.diff","patch_url":"https://github.com/canoo/dolphin-platform/pull/876.patch"},"body":"added final keyword and null checks in server module\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/canoo/dolphin-platform/876)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/canoo/dolphin-platform/issues/comments/374172089","html_url":"https://github.com/canoo/dolphin-platform/pull/876#issuecomment-374172089","issue_url":"https://api.github.com/repos/canoo/dolphin-platform/issues/876","id":374172089,"user":{"login":"clarity-bot[bot]","id":35508252,"avatar_url":"https://avatars1.githubusercontent.com/in/8216?v=4","gravatar_id":"","url":"https://api.github.com/users/clarity-bot%5Bbot%5D","html_url":"https://github.com/apps/clarity-bot","followers_url":"https://api.github.com/users/clarity-bot%5Bbot%5D/followers","following_url":"https://api.github.com/users/clarity-bot%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/clarity-bot%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/clarity-bot%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clarity-bot%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/clarity-bot%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/clarity-bot%5Bbot%5D/repos","events_url":"https://api.github.com/users/clarity-bot%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/clarity-bot%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-19T10:51:15Z","updated_at":"2018-03-19T10:51:15Z","author_association":"NONE","body":"I generated a [structure-diff](https://medium.com/clarity-bot/reading-structure-diffs-101-3b28134d7b8f) below from pulling ```557d214``` **on canoo:server-final** into ```78ed6ae``` on **canoo:master**.\n\n"}}
|
{
"id": 44516886,
"name": "canoo/dolphin-platform",
"url": "https://api.github.com/repos/canoo/dolphin-platform"
}
|
{
"id": 35508252,
"login": "clarity-bot[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35508252?",
"url": "https://api.github.com/users/clarity-bot[bot]"
}
|
{
"id": 373257,
"login": "canoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/373257?",
"url": "https://api.github.com/orgs/canoo"
}
| 2018-03-19T10:51:15 |
7399548894
|
{"actor":{"display_login":"clarity-bot"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/remind101/empire/issues/1128","repository_url":"https://api.github.com/repos/remind101/empire","labels_url":"https://api.github.com/repos/remind101/empire/issues/1128/labels{/name}","comments_url":"https://api.github.com/repos/remind101/empire/issues/1128/comments","events_url":"https://api.github.com/repos/remind101/empire/issues/1128/events","html_url":"https://github.com/remind101/empire/issues/1128","id":340991202,"node_id":"MDU6SXNzdWUzNDA5OTEyMDI=","number":1128,"title":"ECS Task roles not working in `emp run` without patched ECS agent","user":{"login":"tyrken","id":2693365,"node_id":"MDQ6VXNlcjI2OTMzNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2693365?v=4","gravatar_id":"","url":"https://api.github.com/users/tyrken","html_url":"https://github.com/tyrken","followers_url":"https://api.github.com/users/tyrken/followers","following_url":"https://api.github.com/users/tyrken/following{/other_user}","gists_url":"https://api.github.com/users/tyrken/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrken/subscriptions","organizations_url":"https://api.github.com/users/tyrken/orgs","repos_url":"https://api.github.com/users/tyrken/repos","events_url":"https://api.github.com/users/tyrken/events{/privacy}","received_events_url":"https://api.github.com/users/tyrken/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-13T11:55:52Z","updated_at":"2018-07-13T12:10:31Z","closed_at":null,"author_association":"NONE","body":"If you use 'emp run' to get an interactive shell to an app with EMPIRE_X_TASK_ROLE_ARN set, you might expect to get the right AWS creds, especially after #1063.\r\n\r\nUnfortunately, the fix wasn't working for us - I suspect as we didn't have the Patched ECS agent nor EMPIRE_ECS_ATTACHED_ENABLED mentioned at the bottom of http://empire.readthedocs.io/en/latest/configuration/#show-attached-runs-in-emp-ps. Hence our empire install uses the Docker Client direct run method & can't set a random ARN.\r\n\r\nMaybe this could be worked around by a quick call to STS & passing in the key/secret-key/session-token environment variables, which would be good for an hour but need assume-role permissions..."},"comment":{"url":"https://api.github.com/repos/remind101/empire/issues/comments/404814942","html_url":"https://github.com/remind101/empire/issues/1128#issuecomment-404814942","issue_url":"https://api.github.com/repos/remind101/empire/issues/1128","id":404814942,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDgxNDk0Mg==","user":{"login":"tyrken","id":2693365,"node_id":"MDQ6VXNlcjI2OTMzNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2693365?v=4","gravatar_id":"","url":"https://api.github.com/users/tyrken","html_url":"https://github.com/tyrken","followers_url":"https://api.github.com/users/tyrken/followers","following_url":"https://api.github.com/users/tyrken/following{/other_user}","gists_url":"https://api.github.com/users/tyrken/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrken/subscriptions","organizations_url":"https://api.github.com/users/tyrken/orgs","repos_url":"https://api.github.com/users/tyrken/repos","events_url":"https://api.github.com/users/tyrken/events{/privacy}","received_events_url":"https://api.github.com/users/tyrken/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T12:10:31Z","updated_at":"2018-07-13T12:10:31Z","author_association":"NONE","body":"... looks like you knew this already from #1043, but I didn't find it until now! "}}
|
{
"id": 30091667,
"name": "remind101/empire",
"url": "https://api.github.com/repos/remind101/empire"
}
|
{
"id": 2693365,
"login": "tyrken",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2693365?",
"url": "https://api.github.com/users/tyrken"
}
|
{
"id": 376343,
"login": "remind101",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/376343?",
"url": "https://api.github.com/orgs/remind101"
}
| 2018-07-13T12:10:31 |
7961791877
|
{"actor":{"display_login":"tyrken"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2376","repository_url":"https://api.github.com/repos/w3c/csswg-drafts","labels_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2376/labels{/name}","comments_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2376/comments","events_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2376/events","html_url":"https://github.com/w3c/csswg-drafts/issues/2376","id":301794867,"number":2376,"title":"[css-text-decor-4] Add use-font keyword for text-decoration-width & text-decoration-offset","user":{"login":"drott","id":1021784,"avatar_url":"https://avatars0.githubusercontent.com/u/1021784?v=4","gravatar_id":"","url":"https://api.github.com/users/drott","html_url":"https://github.com/drott","followers_url":"https://api.github.com/users/drott/followers","following_url":"https://api.github.com/users/drott/following{/other_user}","gists_url":"https://api.github.com/users/drott/gists{/gist_id}","starred_url":"https://api.github.com/users/drott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drott/subscriptions","organizations_url":"https://api.github.com/users/drott/orgs","repos_url":"https://api.github.com/users/drott/repos","events_url":"https://api.github.com/users/drott/events{/privacy}","received_events_url":"https://api.github.com/users/drott/received_events","type":"User","site_admin":false},"labels":[{"id":469426704,"url":"https://api.github.com/repos/w3c/csswg-drafts/labels/Needs%20Edits","name":"Needs Edits","color":"5319e7","default":false},{"id":860104115,"url":"https://api.github.com/repos/w3c/csswg-drafts/labels/Needs%20Naming%20(Request%20to%20Bikeshed)","name":"Needs Naming (Request to Bikeshed)","color":"5319e7","default":false},{"id":381892077,"url":"https://api.github.com/repos/w3c/csswg-drafts/labels/css-text-decor-4","name":"css-text-decor-4","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-03-02T15:01:50Z","updated_at":"2018-04-10T11:33:22Z","closed_at":null,"author_association":"COLLABORATOR","body":"In [the WG minutes from February 2017](https://lists.w3.org/Archives/Public/www-style/2017Feb/0055.html) and the discussion [in issue 459](https://github.com/w3c/csswg-drafts/issues/459#issuecomment-269743354) there were references to adding a keyword to `text-decoration-width` and `text-decoration-offset`. @fantasai suggested to use `use-font` as the keyword name.\r\n\r\nQuite possibly I missed earlier discussions on this, that's why I am asking to clarify:\r\n\r\nCan we add such a keyword and specifying is as adhering to the definitions of `underlinePosition` and `underlineThickness` in the [post table of the OpenType specification](https://docs.microsoft.com/en-us/typography/opentype/spec/post)?\r\n"},"comment":{"url":"https://api.github.com/repos/w3c/csswg-drafts/issues/comments/380066953","html_url":"https://github.com/w3c/csswg-drafts/issues/2376#issuecomment-380066953","issue_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2376","id":380066953,"user":{"login":"drott","id":1021784,"avatar_url":"https://avatars0.githubusercontent.com/u/1021784?v=4","gravatar_id":"","url":"https://api.github.com/users/drott","html_url":"https://github.com/drott","followers_url":"https://api.github.com/users/drott/followers","following_url":"https://api.github.com/users/drott/following{/other_user}","gists_url":"https://api.github.com/users/drott/gists{/gist_id}","starred_url":"https://api.github.com/users/drott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drott/subscriptions","organizations_url":"https://api.github.com/users/drott/orgs","repos_url":"https://api.github.com/users/drott/repos","events_url":"https://api.github.com/users/drott/events{/privacy}","received_events_url":"https://api.github.com/users/drott/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T11:33:22Z","updated_at":"2018-04-10T11:33:22Z","author_association":"COLLABORATOR","body":"Ping about bikeshedding the name, perhaps you can agree on a keyword name while meeting in Berlin. Thanks. "}}
|
{
"id": 9252268,
"name": "w3c/csswg-drafts",
"url": "https://api.github.com/repos/w3c/csswg-drafts"
}
|
{
"id": 1021784,
"login": "drott",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1021784?",
"url": "https://api.github.com/users/drott"
}
|
{
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
}
| 2018-04-10T11:33:23 |
7506402497
|
{"actor":{"display_login":"drott"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2528","repository_url":"https://api.github.com/repos/w3c/csswg-drafts","labels_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2528/labels{/name}","comments_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2528/comments","events_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2528/events","html_url":"https://github.com/w3c/csswg-drafts/issues/2528","id":313213126,"number":2528,"title":"[css-fonts-4] Feature for making text always fit the width of its parent","user":{"login":"tobireif","id":80411,"avatar_url":"https://avatars0.githubusercontent.com/u/80411?v=4","gravatar_id":"","url":"https://api.github.com/users/tobireif","html_url":"https://github.com/tobireif","followers_url":"https://api.github.com/users/tobireif/followers","following_url":"https://api.github.com/users/tobireif/following{/other_user}","gists_url":"https://api.github.com/users/tobireif/gists{/gist_id}","starred_url":"https://api.github.com/users/tobireif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobireif/subscriptions","organizations_url":"https://api.github.com/users/tobireif/orgs","repos_url":"https://api.github.com/users/tobireif/repos","events_url":"https://api.github.com/users/tobireif/events{/privacy}","received_events_url":"https://api.github.com/users/tobireif/received_events","type":"User","site_admin":false},"labels":[{"id":381889080,"url":"https://api.github.com/repos/w3c/csswg-drafts/labels/css-fonts-4","name":"css-fonts-4","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-11T08:00:08Z","updated_at":"2018-04-14T10:01:16Z","closed_at":null,"author_association":"NONE","body":"This thread shows that it's a widely required feature:\r\nhttps://twitter.com/sindresorhus/status/979363460411609091\r\n\r\nExample of a workaround: Open https://tobireif.com/ and (eg using dev tools responsive mode) resize the page down to 250px width while watching the text \"Welcome\"."},"comment":{"url":"https://api.github.com/repos/w3c/csswg-drafts/issues/comments/381318172","html_url":"https://github.com/w3c/csswg-drafts/issues/2528#issuecomment-381318172","issue_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2528","id":381318172,"user":{"login":"litherum","id":918903,"avatar_url":"https://avatars0.githubusercontent.com/u/918903?v=4","gravatar_id":"","url":"https://api.github.com/users/litherum","html_url":"https://github.com/litherum","followers_url":"https://api.github.com/users/litherum/followers","following_url":"https://api.github.com/users/litherum/following{/other_user}","gists_url":"https://api.github.com/users/litherum/gists{/gist_id}","starred_url":"https://api.github.com/users/litherum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litherum/subscriptions","organizations_url":"https://api.github.com/users/litherum/orgs","repos_url":"https://api.github.com/users/litherum/repos","events_url":"https://api.github.com/users/litherum/events{/privacy}","received_events_url":"https://api.github.com/users/litherum/received_events","type":"User","site_admin":false},"created_at":"2018-04-14T10:01:16Z","updated_at":"2018-04-14T10:01:16Z","author_association":"CONTRIBUTOR","body":"Using a small number of passes is unlikely to work in the general case, because if we get it wrong, the text will overflow its container and wrap, which would be catastrophic. Any generalized implementation would have to iterate until the algorithm converges. Such an algorithm would be a great way to make a browser hang."}}
|
{
"id": 9252268,
"name": "w3c/csswg-drafts",
"url": "https://api.github.com/repos/w3c/csswg-drafts"
}
|
{
"id": 918903,
"login": "litherum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/918903?",
"url": "https://api.github.com/users/litherum"
}
|
{
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
}
| 2018-04-14T10:01:16 |
7529831766
|
{"actor":{"display_login":"litherum"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/respec/issues/1128","repository_url":"https://api.github.com/repos/w3c/respec","labels_url":"https://api.github.com/repos/w3c/respec/issues/1128/labels{/name}","comments_url":"https://api.github.com/repos/w3c/respec/issues/1128/comments","events_url":"https://api.github.com/repos/w3c/respec/issues/1128/events","html_url":"https://github.com/w3c/respec/issues/1128","id":211594108,"number":1128,"title":"Test process version","user":{"login":"marcoscaceres","id":870154,"avatar_url":"https://avatars1.githubusercontent.com/u/870154?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoscaceres","html_url":"https://github.com/marcoscaceres","followers_url":"https://api.github.com/users/marcoscaceres/followers","following_url":"https://api.github.com/users/marcoscaceres/following{/other_user}","gists_url":"https://api.github.com/users/marcoscaceres/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoscaceres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoscaceres/subscriptions","organizations_url":"https://api.github.com/users/marcoscaceres/orgs","repos_url":"https://api.github.com/users/marcoscaceres/repos","events_url":"https://api.github.com/users/marcoscaceres/events{/privacy}","received_events_url":"https://api.github.com/users/marcoscaceres/received_events","type":"User","site_admin":false},"labels":[{"id":4769400,"url":"https://api.github.com/repos/w3c/respec/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-03T04:41:36Z","updated_at":"2018-03-08T21:17:45Z","closed_at":null,"author_association":"MEMBER","body":"We are currently lacking tests for the processVersion, which bit us :( Just need a simple test to check that the processVersion is defaulting correctly. Should also refactor the process version to not be a boolean - that's quite terrible. "},"comment":{"url":"https://api.github.com/repos/w3c/respec/issues/comments/371627511","html_url":"https://github.com/w3c/respec/issues/1128#issuecomment-371627511","issue_url":"https://api.github.com/repos/w3c/respec/issues/1128","id":371627511,"user":{"login":"sidvishnoi","id":8426945,"avatar_url":"https://avatars0.githubusercontent.com/u/8426945?v=4","gravatar_id":"","url":"https://api.github.com/users/sidvishnoi","html_url":"https://github.com/sidvishnoi","followers_url":"https://api.github.com/users/sidvishnoi/followers","following_url":"https://api.github.com/users/sidvishnoi/following{/other_user}","gists_url":"https://api.github.com/users/sidvishnoi/gists{/gist_id}","starred_url":"https://api.github.com/users/sidvishnoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidvishnoi/subscriptions","organizations_url":"https://api.github.com/users/sidvishnoi/orgs","repos_url":"https://api.github.com/users/sidvishnoi/repos","events_url":"https://api.github.com/users/sidvishnoi/events{/privacy}","received_events_url":"https://api.github.com/users/sidvishnoi/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T21:17:45Z","updated_at":"2018-03-08T21:17:45Z","author_association":"NONE","body":"Closed by 2e838ae and #1480 ?\r\nAnd delete the wiki page for this also.\r\nI was confused where `processVersion` is being used then I checked year of this issue. Haha."}}
|
{
"id": 4287066,
"name": "w3c/respec",
"url": "https://api.github.com/repos/w3c/respec"
}
|
{
"id": 8426945,
"login": "sidvishnoi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8426945?",
"url": "https://api.github.com/users/sidvishnoi"
}
|
{
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
}
| 2018-03-08T21:17:45 |
7352633707
|
{"actor":{"display_login":"sidvishnoi"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/ttml2/issues/592","repository_url":"https://api.github.com/repos/w3c/ttml2","labels_url":"https://api.github.com/repos/w3c/ttml2/issues/592/labels{/name}","comments_url":"https://api.github.com/repos/w3c/ttml2/issues/592/comments","events_url":"https://api.github.com/repos/w3c/ttml2/issues/592/events","html_url":"https://github.com/w3c/ttml2/issues/592","id":291875682,"number":592,"title":"Possible misinterpretation of note in §11.3.1.2 Inline Regions.","user":{"login":"nigelmegitt","id":4988915,"avatar_url":"https://avatars0.githubusercontent.com/u/4988915?v=4","gravatar_id":"","url":"https://api.github.com/users/nigelmegitt","html_url":"https://github.com/nigelmegitt","followers_url":"https://api.github.com/users/nigelmegitt/followers","following_url":"https://api.github.com/users/nigelmegitt/following{/other_user}","gists_url":"https://api.github.com/users/nigelmegitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelmegitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelmegitt/subscriptions","organizations_url":"https://api.github.com/users/nigelmegitt/orgs","repos_url":"https://api.github.com/users/nigelmegitt/repos","events_url":"https://api.github.com/users/nigelmegitt/events{/privacy}","received_events_url":"https://api.github.com/users/nigelmegitt/received_events","type":"User","site_admin":false},"labels":[{"id":464315512,"url":"https://api.github.com/repos/w3c/ttml2/labels/editorial","name":"editorial","color":"c5def5","default":false},{"id":446746229,"url":"https://api.github.com/repos/w3c/ttml2/labels/pr%20merged","name":"pr merged","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/w3c/ttml2/milestones/1","html_url":"https://github.com/w3c/ttml2/milestone/1","labels_url":"https://api.github.com/repos/w3c/ttml2/milestones/1/labels","id":2713668,"number":1,"title":"Editor's CR Work List","description":"Work list for processing WR comments to attain CR draft.","creator":{"login":"skynavga","id":377455,"avatar_url":"https://avatars0.githubusercontent.com/u/377455?v=4","gravatar_id":"","url":"https://api.github.com/users/skynavga","html_url":"https://github.com/skynavga","followers_url":"https://api.github.com/users/skynavga/followers","following_url":"https://api.github.com/users/skynavga/following{/other_user}","gists_url":"https://api.github.com/users/skynavga/gists{/gist_id}","starred_url":"https://api.github.com/users/skynavga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skynavga/subscriptions","organizations_url":"https://api.github.com/users/skynavga/orgs","repos_url":"https://api.github.com/users/skynavga/repos","events_url":"https://api.github.com/users/skynavga/events{/privacy}","received_events_url":"https://api.github.com/users/skynavga/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":183,"state":"open","created_at":"2017-08-21T15:07:46Z","updated_at":"2018-02-07T23:23:03Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-01-26T11:34:22Z","updated_at":"2018-02-07T23:24:06Z","closed_at":null,"author_association":"COLLABORATOR","body":"The note:\r\n\r\n> A content element can only be associated with a single region. Consequently, if a content element specifies a region attribute, then any explicit inline region specification is ignored.\r\n\r\nis incorrect - we have established through discussion of other issues that some content elements are associated with multiple regions. I think this is about explicit association by specifying a `region` attribute. Suggest rewording to:\r\n\r\n_A content element can only **specify** a single region. Consequently, if a content element specifies a region attribute, then any explicit inline region specification is ignored._"},"comment":{"url":"https://api.github.com/repos/w3c/ttml2/issues/comments/363946068","html_url":"https://github.com/w3c/ttml2/issues/592#issuecomment-363946068","issue_url":"https://api.github.com/repos/w3c/ttml2/issues/592","id":363946068,"user":{"login":"palemieux","id":4871350,"avatar_url":"https://avatars0.githubusercontent.com/u/4871350?v=4","gravatar_id":"","url":"https://api.github.com/users/palemieux","html_url":"https://github.com/palemieux","followers_url":"https://api.github.com/users/palemieux/followers","following_url":"https://api.github.com/users/palemieux/following{/other_user}","gists_url":"https://api.github.com/users/palemieux/gists{/gist_id}","starred_url":"https://api.github.com/users/palemieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palemieux/subscriptions","organizations_url":"https://api.github.com/users/palemieux/orgs","repos_url":"https://api.github.com/users/palemieux/repos","events_url":"https://api.github.com/users/palemieux/events{/privacy}","received_events_url":"https://api.github.com/users/palemieux/received_events","type":"User","site_admin":false},"created_at":"2018-02-07T23:24:06Z","updated_at":"2018-02-07T23:24:06Z","author_association":"CONTRIBUTOR","body":"The PR was closed before the 14 day period was over. I do not have a concern with the contents of the note. It should however not be a note since it sets a normative precedence order."}}
|
{
"id": 45166834,
"name": "w3c/ttml2",
"url": "https://api.github.com/repos/w3c/ttml2"
}
|
{
"id": 4871350,
"login": "palemieux",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4871350?",
"url": "https://api.github.com/users/palemieux"
}
|
{
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
}
| 2018-02-07T23:24:06 |
7213895553
|
{"actor":{"display_login":"palemieux"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2184","repository_url":"https://api.github.com/repos/w3c/csswg-drafts","labels_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2184/labels{/name}","comments_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2184/comments","events_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2184/events","html_url":"https://github.com/w3c/csswg-drafts/issues/2184","id":288229024,"node_id":"MDU6SXNzdWUyODgyMjkwMjQ=","number":2184,"title":"[css-inline] initial-letter appliance and inheritance","user":{"login":"Loirooriol","id":7477678,"node_id":"MDQ6VXNlcjc0Nzc2Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7477678?v=4","gravatar_id":"","url":"https://api.github.com/users/Loirooriol","html_url":"https://github.com/Loirooriol","followers_url":"https://api.github.com/users/Loirooriol/followers","following_url":"https://api.github.com/users/Loirooriol/following{/other_user}","gists_url":"https://api.github.com/users/Loirooriol/gists{/gist_id}","starred_url":"https://api.github.com/users/Loirooriol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Loirooriol/subscriptions","organizations_url":"https://api.github.com/users/Loirooriol/orgs","repos_url":"https://api.github.com/users/Loirooriol/repos","events_url":"https://api.github.com/users/Loirooriol/events{/privacy}","received_events_url":"https://api.github.com/users/Loirooriol/received_events","type":"User","site_admin":false},"labels":[{"id":395791224,"node_id":"MDU6TGFiZWwzOTU3OTEyMjQ=","url":"https://api.github.com/repos/w3c/csswg-drafts/labels/Commenter%20Response%20Pending","name":"Commenter Response Pending","color":"fbca04","default":false},{"id":381889345,"node_id":"MDU6TGFiZWwzODE4ODkzNDU=","url":"https://api.github.com/repos/w3c/csswg-drafts/labels/css-inline-3","name":"css-inline-3","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":{"login":"dauwhe","id":5687700,"node_id":"MDQ6VXNlcjU2ODc3MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5687700?v=4","gravatar_id":"","url":"https://api.github.com/users/dauwhe","html_url":"https://github.com/dauwhe","followers_url":"https://api.github.com/users/dauwhe/followers","following_url":"https://api.github.com/users/dauwhe/following{/other_user}","gists_url":"https://api.github.com/users/dauwhe/gists{/gist_id}","starred_url":"https://api.github.com/users/dauwhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dauwhe/subscriptions","organizations_url":"https://api.github.com/users/dauwhe/orgs","repos_url":"https://api.github.com/users/dauwhe/repos","events_url":"https://api.github.com/users/dauwhe/events{/privacy}","received_events_url":"https://api.github.com/users/dauwhe/received_events","type":"User","site_admin":false},"assignees":[{"login":"dauwhe","id":5687700,"node_id":"MDQ6VXNlcjU2ODc3MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5687700?v=4","gravatar_id":"","url":"https://api.github.com/users/dauwhe","html_url":"https://github.com/dauwhe","followers_url":"https://api.github.com/users/dauwhe/followers","following_url":"https://api.github.com/users/dauwhe/following{/other_user}","gists_url":"https://api.github.com/users/dauwhe/gists{/gist_id}","starred_url":"https://api.github.com/users/dauwhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dauwhe/subscriptions","organizations_url":"https://api.github.com/users/dauwhe/orgs","repos_url":"https://api.github.com/users/dauwhe/repos","events_url":"https://api.github.com/users/dauwhe/events{/privacy}","received_events_url":"https://api.github.com/users/dauwhe/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-01-12T19:54:42Z","updated_at":"2018-07-27T01:29:42Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"[`initial-letter`](https://drafts.csswg.org/css-inline/#sizing-drop-initials) does not inherit and applies to\r\n\r\n> `::first-letter` pseudo-elements and inline-level first child of a block container\r\n\r\nThe problem is that the inline-level first child box of a block container is the [root inline box](https://drafts.csswg.org/css-inline/#root-inline-box), which cannot be targeted using selectors.\r\n\r\nIf the definition refers to the first child in the element tree then that's a problem with `display: contents`. And if you have `<div><b><i>Text</i></b></div>`, it's not clear why `initial-letter` applies to `b` but not to `i`.\r\n\r\nIn any case, since there is no inheritance, it's not clear what happens if you set `initial-letter` both to that first child and to the block container's `::first-letter`, or to nested `::first-letter`s.\r\n\r\nInstead, I think there are three reasonable possibilities:\r\n\r\n - `initial-letter` only applies to block containers that establish an inline formatting context, and affects the initial letter of the block container. But note that often the block container that establishes the IFC is an anonymous one, so `initial-letter` should inherit.\r\n - `initial-letter` only applies to innermost `::first-letter` pseudo-elements, but it inherits, so you can set it on a block-level, inline-level or `::first-letter` parent box.\r\n - `initial-letter` only applies to innermost `::first-letter` pseudo-elements. And that's all because it doesn't inherit."},"comment":{"url":"https://api.github.com/repos/w3c/csswg-drafts/issues/comments/408283783","html_url":"https://github.com/w3c/csswg-drafts/issues/2184#issuecomment-408283783","issue_url":"https://api.github.com/repos/w3c/csswg-drafts/issues/2184","id":408283783,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODI4Mzc4Mw==","user":{"login":"fantasai","id":725717,"node_id":"MDQ6VXNlcjcyNTcxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/725717?v=4","gravatar_id":"","url":"https://api.github.com/users/fantasai","html_url":"https://github.com/fantasai","followers_url":"https://api.github.com/users/fantasai/followers","following_url":"https://api.github.com/users/fantasai/following{/other_user}","gists_url":"https://api.github.com/users/fantasai/gists{/gist_id}","starred_url":"https://api.github.com/users/fantasai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fantasai/subscriptions","organizations_url":"https://api.github.com/users/fantasai/orgs","repos_url":"https://api.github.com/users/fantasai/repos","events_url":"https://api.github.com/users/fantasai/events{/privacy}","received_events_url":"https://api.github.com/users/fantasai/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T01:29:42Z","updated_at":"2018-07-27T01:29:42Z","author_association":"CONTRIBUTOR","body":"OK, committed changes. @Loirooriol would you mind reviewing to make sure I handled all your concerns? :)"}}
|
{
"id": 9252268,
"name": "w3c/csswg-drafts",
"url": "https://api.github.com/repos/w3c/csswg-drafts"
}
|
{
"id": 725717,
"login": "fantasai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/725717?",
"url": "https://api.github.com/users/fantasai"
}
|
{
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
}
| 2018-07-27T01:29:42 |
8026049211
|
{"actor":{"display_login":"fantasai"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/dxwg/issues/486","repository_url":"https://api.github.com/repos/w3c/dxwg","labels_url":"https://api.github.com/repos/w3c/dxwg/issues/486/labels{/name}","comments_url":"https://api.github.com/repos/w3c/dxwg/issues/486/comments","events_url":"https://api.github.com/repos/w3c/dxwg/issues/486/events","html_url":"https://github.com/w3c/dxwg/issues/486","id":373028935,"node_id":"MDU6SXNzdWUzNzMwMjg5MzU=","number":486,"title":"property profileOfTransitive","user":{"login":"riccardoAlbertoni","id":1876407,"node_id":"MDQ6VXNlcjE4NzY0MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1876407?v=4","gravatar_id":"","url":"https://api.github.com/users/riccardoAlbertoni","html_url":"https://github.com/riccardoAlbertoni","followers_url":"https://api.github.com/users/riccardoAlbertoni/followers","following_url":"https://api.github.com/users/riccardoAlbertoni/following{/other_user}","gists_url":"https://api.github.com/users/riccardoAlbertoni/gists{/gist_id}","starred_url":"https://api.github.com/users/riccardoAlbertoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riccardoAlbertoni/subscriptions","organizations_url":"https://api.github.com/users/riccardoAlbertoni/orgs","repos_url":"https://api.github.com/users/riccardoAlbertoni/repos","events_url":"https://api.github.com/users/riccardoAlbertoni/events{/privacy}","received_events_url":"https://api.github.com/users/riccardoAlbertoni/received_events","type":"User","site_admin":false},"labels":[{"id":1036878944,"node_id":"MDU6TGFiZWwxMDM2ODc4OTQ0","url":"https://api.github.com/repos/w3c/dxwg/labels/profile-description","name":"profile-description","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":63,"created_at":"2018-10-23T14:23:50Z","updated_at":"2018-11-05T19:58:47Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I guess the intention for profileOfTransitive was to replicate the modelling pattern adopted for the broaderTransitive and broader properties in SKOS. \r\nIn that case, I have two issues:\r\n\r\n- I would consider renaming this property in \"transitiveProfileOf\". Of course, I leave the last word to native speakers but while \"broaderTransitive\" works well to me, \"profileOfTransitive\" is a little confusing, probably due to the 'Of\" before \"Transitive\" which might be interpret as \"profile of transitive\" instead of \"profileOf transitive\". \r\n\r\n- In order to replicate the skos:broader /skos:broaderTransitive, the following statement might be added \r\n```\r\nprof:profileOfTransitive rdf:type owl:ObjectProperty , owl:TransitiveProperty .\r\nprof:profileOf rdfs:subPropertyOf prof:profileOfTransitive .\r\n \r\n```\r\n \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/w3c/dxwg/issues/comments/436014412","html_url":"https://github.com/w3c/dxwg/issues/486#issuecomment-436014412","issue_url":"https://api.github.com/repos/w3c/dxwg/issues/486","id":436014412,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjAxNDQxMg==","user":{"login":"makxdekkers","id":7534601,"node_id":"MDQ6VXNlcjc1MzQ2MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/7534601?v=4","gravatar_id":"","url":"https://api.github.com/users/makxdekkers","html_url":"https://github.com/makxdekkers","followers_url":"https://api.github.com/users/makxdekkers/followers","following_url":"https://api.github.com/users/makxdekkers/following{/other_user}","gists_url":"https://api.github.com/users/makxdekkers/gists{/gist_id}","starred_url":"https://api.github.com/users/makxdekkers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makxdekkers/subscriptions","organizations_url":"https://api.github.com/users/makxdekkers/orgs","repos_url":"https://api.github.com/users/makxdekkers/repos","events_url":"https://api.github.com/users/makxdekkers/events{/privacy}","received_events_url":"https://api.github.com/users/makxdekkers/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T19:58:47Z","updated_at":"2018-11-05T19:58:47Z","author_association":"CONTRIBUTOR","body":"@larsgsvensson Yes, and this was the background for the use case https://www.w3.org/TR/dcat-ucr/#ID36 and requirements https://www.w3.org/TR/dcat-ucr/#RVC and https://www.w3.org/TR/dcat-ucr/#RVM."}}
|
{
"id": 81964552,
"name": "w3c/dxwg",
"url": "https://api.github.com/repos/w3c/dxwg"
}
|
{
"id": 7534601,
"login": "makxdekkers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7534601?",
"url": "https://api.github.com/users/makxdekkers"
}
|
{
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
}
| 2018-11-05T19:58:48 |
8538143052
|
{"actor":{"display_login":"makxdekkers"}}
|
IssueCommentEvent
| true |
{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/aria-practices/issues/748","repository_url":"https://api.github.com/repos/w3c/aria-practices","labels_url":"https://api.github.com/repos/w3c/aria-practices/issues/748/labels{/name}","comments_url":"https://api.github.com/repos/w3c/aria-practices/issues/748/comments","events_url":"https://api.github.com/repos/w3c/aria-practices/issues/748/events","html_url":"https://github.com/w3c/aria-practices/pull/748","id":337078565,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Mzc4ODUw","number":748,"title":"redo: Minimal framework for regression tests of APG Examples #742 ","user":{"login":"spectranaut","id":583831,"node_id":"MDQ6VXNlcjU4MzgzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/583831?v=4","gravatar_id":"","url":"https://api.github.com/users/spectranaut","html_url":"https://github.com/spectranaut","followers_url":"https://api.github.com/users/spectranaut/followers","following_url":"https://api.github.com/users/spectranaut/following{/other_user}","gists_url":"https://api.github.com/users/spectranaut/gists{/gist_id}","starred_url":"https://api.github.com/users/spectranaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spectranaut/subscriptions","organizations_url":"https://api.github.com/users/spectranaut/orgs","repos_url":"https://api.github.com/users/spectranaut/repos","events_url":"https://api.github.com/users/spectranaut/events{/privacy}","received_events_url":"https://api.github.com/users/spectranaut/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-29T17:30:42Z","updated_at":"2018-07-02T15:16:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/w3c/aria-practices/pulls/748","html_url":"https://github.com/w3c/aria-practices/pull/748","diff_url":"https://github.com/w3c/aria-practices/pull/748.diff","patch_url":"https://github.com/w3c/aria-practices/pull/748.patch"},"body":"Hi @jessebeach and @sh0ji and @mcking65 -- thanks for your review on the the previous merge request, I've already begun digging into it.\r\n\r\nHowever, unfortunately, one of the first things I've done this morning after two days out sick is force push to the wrong branch and delete the merge created by the first PR (https://github.com/w3c/aria-practices/pull/742#pullrequestreview-132618231) on your bocoup branch. Sorry to cause any confusion!\r\n\r\nThis PR is identical to the first, except it's been rebased on w3c's master. Can you merge it?\r\n\r\nI'll submit another PR soon that implements your review feedback."},"comment":{"url":"https://api.github.com/repos/w3c/aria-practices/issues/comments/401839581","html_url":"https://github.com/w3c/aria-practices/pull/748#issuecomment-401839581","issue_url":"https://api.github.com/repos/w3c/aria-practices/issues/748","id":401839581,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTgzOTU4MQ==","user":{"login":"jessebeach","id":345913,"node_id":"MDQ6VXNlcjM0NTkxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/345913?v=4","gravatar_id":"","url":"https://api.github.com/users/jessebeach","html_url":"https://github.com/jessebeach","followers_url":"https://api.github.com/users/jessebeach/followers","following_url":"https://api.github.com/users/jessebeach/following{/other_user}","gists_url":"https://api.github.com/users/jessebeach/gists{/gist_id}","starred_url":"https://api.github.com/users/jessebeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessebeach/subscriptions","organizations_url":"https://api.github.com/users/jessebeach/orgs","repos_url":"https://api.github.com/users/jessebeach/repos","events_url":"https://api.github.com/users/jessebeach/events{/privacy}","received_events_url":"https://api.github.com/users/jessebeach/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T15:16:30Z","updated_at":"2018-07-02T15:16:30Z","author_association":"CONTRIBUTOR","body":"I'll chat with Matt today.\n\nOn Mon, Jul 2, 2018, 07:43 Valerie Young <[email protected]> wrote:\n\n> Hi @jessebeach <https://github.com/jessebeach> -- who can merge these\n> requests?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/w3c/aria-practices/pull/748#issuecomment-401829068>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAVHOf4B6OCwmiN1G3aW4ahmO28Vom1bks5uCjFygaJpZM4U9Xrd>\n> .\n>\n"}}
|
{
"id": 55698731,
"name": "w3c/aria-practices",
"url": "https://api.github.com/repos/w3c/aria-practices"
}
|
{
"id": 345913,
"login": "jessebeach",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/345913?",
"url": "https://api.github.com/users/jessebeach"
}
|
{
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
}
| 2018-07-02T15:16:31 |
7907310667
|
{"actor":{"display_login":"jessebeach"}}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.