type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
363k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/comments/225680974","pull_request_review_id":165331684,"id":225680974,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTY4MDk3NA==","diff_hunk":"@@ -0,0 +1,149 @@\n+<div class=\"content-wrapper\">\n+ <!-- Content Header (Page header) -->\n+ <section class=\"content-header\">\n+ <h1>\n+ Motifs de Suppressions","path":"frontend/src/app/admin/components/admin-content/admin-motif/admin-motif.component.html","position":5,"original_position":5,"commit_id":"734783eb2c603e4aca52a4e0e42c8c3f42141382","original_commit_id":"734783eb2c603e4aca52a4e0e42c8c3f42141382","user":{"login":"MentalistHB","id":23260207,"node_id":"MDQ6VXNlcjIzMjYwMjA3","avatar_url":"https://avatars0.githubusercontent.com/u/23260207?v=4","gravatar_id":"","url":"https://api.github.com/users/MentalistHB","html_url":"https://github.com/MentalistHB","followers_url":"https://api.github.com/users/MentalistHB/followers","following_url":"https://api.github.com/users/MentalistHB/following{/other_user}","gists_url":"https://api.github.com/users/MentalistHB/gists{/gist_id}","starred_url":"https://api.github.com/users/MentalistHB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MentalistHB/subscriptions","organizations_url":"https://api.github.com/users/MentalistHB/orgs","repos_url":"https://api.github.com/users/MentalistHB/repos","events_url":"https://api.github.com/users/MentalistHB/events{/privacy}","received_events_url":"https://api.github.com/users/MentalistHB/received_events","type":"User","site_admin":false},"body":"I don't think that 'suppression' ends with an 's'","created_at":"2018-10-16T19:38:55Z","updated_at":"2018-10-16T19:41:12Z","html_url":"https://github.com/YankevinPlacali/Ambacam2018/pull/98#discussion_r225680974","pull_request_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/98","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/comments/225680974"},"html":{"href":"https://github.com/YankevinPlacali/Ambacam2018/pull/98#discussion_r225680974"},"pull_request":{"href":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/98","id":222656285,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjU2Mjg1","html_url":"https://github.com/YankevinPlacali/Ambacam2018/pull/98","diff_url":"https://github.com/YankevinPlacali/Ambacam2018/pull/98.diff","patch_url":"https://github.com/YankevinPlacali/Ambacam2018/pull/98.patch","issue_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues/98","number":98,"state":"open","locked":false,"title":"94-implement-the-interfaces-for-motifsuppression-frontend","user":{"login":"YankevinPlacali","id":21308042,"node_id":"MDQ6VXNlcjIxMzA4MDQy","avatar_url":"https://avatars3.githubusercontent.com/u/21308042?v=4","gravatar_id":"","url":"https://api.github.com/users/YankevinPlacali","html_url":"https://github.com/YankevinPlacali","followers_url":"https://api.github.com/users/YankevinPlacali/followers","following_url":"https://api.github.com/users/YankevinPlacali/following{/other_user}","gists_url":"https://api.github.com/users/YankevinPlacali/gists{/gist_id}","starred_url":"https://api.github.com/users/YankevinPlacali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YankevinPlacali/subscriptions","organizations_url":"https://api.github.com/users/YankevinPlacali/orgs","repos_url":"https://api.github.com/users/YankevinPlacali/repos","events_url":"https://api.github.com/users/YankevinPlacali/events{/privacy}","received_events_url":"https://api.github.com/users/YankevinPlacali/received_events","type":"User","site_admin":false},"body":"Problem:\r\npas de probleème\r\n\r\nNext Steps:\r\n-terminé","created_at":"2018-10-13T15:18:01Z","updated_at":"2018-10-16T19:41:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"MentalistHB","id":23260207,"node_id":"MDQ6VXNlcjIzMjYwMjA3","avatar_url":"https://avatars0.githubusercontent.com/u/23260207?v=4","gravatar_id":"","url":"https://api.github.com/users/MentalistHB","html_url":"https://github.com/MentalistHB","followers_url":"https://api.github.com/users/MentalistHB/followers","following_url":"https://api.github.com/users/MentalistHB/following{/other_user}","gists_url":"https://api.github.com/users/MentalistHB/gists{/gist_id}","starred_url":"https://api.github.com/users/MentalistHB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MentalistHB/subscriptions","organizations_url":"https://api.github.com/users/MentalistHB/orgs","repos_url":"https://api.github.com/users/MentalistHB/repos","events_url":"https://api.github.com/users/MentalistHB/events{/privacy}","received_events_url":"https://api.github.com/users/MentalistHB/received_events","type":"User","site_admin":false},"assignees":[{"login":"MentalistHB","id":23260207,"node_id":"MDQ6VXNlcjIzMjYwMjA3","avatar_url":"https://avatars0.githubusercontent.com/u/23260207?v=4","gravatar_id":"","url":"https://api.github.com/users/MentalistHB","html_url":"https://github.com/MentalistHB","followers_url":"https://api.github.com/users/MentalistHB/followers","following_url":"https://api.github.com/users/MentalistHB/following{/other_user}","gists_url":"https://api.github.com/users/MentalistHB/gists{/gist_id}","starred_url":"https://api.github.com/users/MentalistHB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MentalistHB/subscriptions","organizations_url":"https://api.github.com/users/MentalistHB/orgs","repos_url":"https://api.github.com/users/MentalistHB/repos","events_url":"https://api.github.com/users/MentalistHB/events{/privacy}","received_events_url":"https://api.github.com/users/MentalistHB/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"wakeugit","id":19371774,"node_id":"MDQ6VXNlcjE5MzcxNzc0","avatar_url":"https://avatars0.githubusercontent.com/u/19371774?v=4","gravatar_id":"","url":"https://api.github.com/users/wakeugit","html_url":"https://github.com/wakeugit","followers_url":"https://api.github.com/users/wakeugit/followers","following_url":"https://api.github.com/users/wakeugit/following{/other_user}","gists_url":"https://api.github.com/users/wakeugit/gists{/gist_id}","starred_url":"https://api.github.com/users/wakeugit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wakeugit/subscriptions","organizations_url":"https://api.github.com/users/wakeugit/orgs","repos_url":"https://api.github.com/users/wakeugit/repos","events_url":"https://api.github.com/users/wakeugit/events{/privacy}","received_events_url":"https://api.github.com/users/wakeugit/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":966543598,"node_id":"MDU6TGFiZWw5NjY1NDM1OTg=","url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/labels/review%20pending","name":"review pending","color":"ffc9d0","default":false}],"milestone":{"url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/milestones/2","html_url":"https://github.com/YankevinPlacali/Ambacam2018/milestone/2","labels_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/milestones/2/labels","id":3615946,"node_id":"MDk6TWlsZXN0b25lMzYxNTk0Ng==","number":2,"title":"Implement the frontend system and connect it with the backend system","description":"","creator":{"login":"MentalistHB","id":23260207,"node_id":"MDQ6VXNlcjIzMjYwMjA3","avatar_url":"https://avatars0.githubusercontent.com/u/23260207?v=4","gravatar_id":"","url":"https://api.github.com/users/MentalistHB","html_url":"https://github.com/MentalistHB","followers_url":"https://api.github.com/users/MentalistHB/followers","following_url":"https://api.github.com/users/MentalistHB/following{/other_user}","gists_url":"https://api.github.com/users/MentalistHB/gists{/gist_id}","starred_url":"https://api.github.com/users/MentalistHB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MentalistHB/subscriptions","organizations_url":"https://api.github.com/users/MentalistHB/orgs","repos_url":"https://api.github.com/users/MentalistHB/repos","events_url":"https://api.github.com/users/MentalistHB/events{/privacy}","received_events_url":"https://api.github.com/users/MentalistHB/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":11,"state":"open","created_at":"2018-09-02T15:40:25Z","updated_at":"2018-10-16T19:29:16Z","due_on":"2018-12-02T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/98/commits","review_comments_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/98/comments","review_comment_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues/98/comments","statuses_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/statuses/734783eb2c603e4aca52a4e0e42c8c3f42141382","head":{"label":"YankevinPlacali:94-implement-the-interfaces-for-motifsuppression","ref":"94-implement-the-interfaces-for-motifsuppression","sha":"734783eb2c603e4aca52a4e0e42c8c3f42141382","user":{"login":"YankevinPlacali","id":21308042,"node_id":"MDQ6VXNlcjIxMzA4MDQy","avatar_url":"https://avatars3.githubusercontent.com/u/21308042?v=4","gravatar_id":"","url":"https://api.github.com/users/YankevinPlacali","html_url":"https://github.com/YankevinPlacali","followers_url":"https://api.github.com/users/YankevinPlacali/followers","following_url":"https://api.github.com/users/YankevinPlacali/following{/other_user}","gists_url":"https://api.github.com/users/YankevinPlacali/gists{/gist_id}","starred_url":"https://api.github.com/users/YankevinPlacali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YankevinPlacali/subscriptions","organizations_url":"https://api.github.com/users/YankevinPlacali/orgs","repos_url":"https://api.github.com/users/YankevinPlacali/repos","events_url":"https://api.github.com/users/YankevinPlacali/events{/privacy}","received_events_url":"https://api.github.com/users/YankevinPlacali/received_events","type":"User","site_admin":false},"repo":{"id":128656570,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2NTY1NzA=","name":"Ambacam2018","full_name":"YankevinPlacali/Ambacam2018","private":false,"owner":{"login":"YankevinPlacali","id":21308042,"node_id":"MDQ6VXNlcjIxMzA4MDQy","avatar_url":"https://avatars3.githubusercontent.com/u/21308042?v=4","gravatar_id":"","url":"https://api.github.com/users/YankevinPlacali","html_url":"https://github.com/YankevinPlacali","followers_url":"https://api.github.com/users/YankevinPlacali/followers","following_url":"https://api.github.com/users/YankevinPlacali/following{/other_user}","gists_url":"https://api.github.com/users/YankevinPlacali/gists{/gist_id}","starred_url":"https://api.github.com/users/YankevinPlacali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YankevinPlacali/subscriptions","organizations_url":"https://api.github.com/users/YankevinPlacali/orgs","repos_url":"https://api.github.com/users/YankevinPlacali/repos","events_url":"https://api.github.com/users/YankevinPlacali/events{/privacy}","received_events_url":"https://api.github.com/users/YankevinPlacali/received_events","type":"User","site_admin":false},"html_url":"https://github.com/YankevinPlacali/Ambacam2018","description":null,"fork":false,"url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018","forks_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/forks","keys_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/teams","hooks_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/hooks","issue_events_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues/events{/number}","events_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/events","assignees_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/assignees{/user}","branches_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/branches{/branch}","tags_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/tags","blobs_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/statuses/{sha}","languages_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/languages","stargazers_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/stargazers","contributors_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/contributors","subscribers_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/subscribers","subscription_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/subscription","commits_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/contents/{+path}","compare_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/merges","archive_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/downloads","issues_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues{/number}","pulls_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls{/number}","milestones_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/milestones{/number}","notifications_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/labels{/name}","releases_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/releases{/id}","deployments_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/deployments","created_at":"2018-04-08T15:43:52Z","updated_at":"2018-10-15T20:23:02Z","pushed_at":"2018-10-16T19:24:13Z","git_url":"git://github.com/YankevinPlacali/Ambacam2018.git","ssh_url":"[email protected]:YankevinPlacali/Ambacam2018.git","clone_url":"https://github.com/YankevinPlacali/Ambacam2018.git","svn_url":"https://github.com/YankevinPlacali/Ambacam2018","homepage":null,"size":63077,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":0,"default_branch":"master"}},"base":{"label":"YankevinPlacali:master","ref":"master","sha":"e1464d819b872fbc401eb1f54ab9a74340c50771","user":{"login":"YankevinPlacali","id":21308042,"node_id":"MDQ6VXNlcjIxMzA4MDQy","avatar_url":"https://avatars3.githubusercontent.com/u/21308042?v=4","gravatar_id":"","url":"https://api.github.com/users/YankevinPlacali","html_url":"https://github.com/YankevinPlacali","followers_url":"https://api.github.com/users/YankevinPlacali/followers","following_url":"https://api.github.com/users/YankevinPlacali/following{/other_user}","gists_url":"https://api.github.com/users/YankevinPlacali/gists{/gist_id}","starred_url":"https://api.github.com/users/YankevinPlacali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YankevinPlacali/subscriptions","organizations_url":"https://api.github.com/users/YankevinPlacali/orgs","repos_url":"https://api.github.com/users/YankevinPlacali/repos","events_url":"https://api.github.com/users/YankevinPlacali/events{/privacy}","received_events_url":"https://api.github.com/users/YankevinPlacali/received_events","type":"User","site_admin":false},"repo":{"id":128656570,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2NTY1NzA=","name":"Ambacam2018","full_name":"YankevinPlacali/Ambacam2018","private":false,"owner":{"login":"YankevinPlacali","id":21308042,"node_id":"MDQ6VXNlcjIxMzA4MDQy","avatar_url":"https://avatars3.githubusercontent.com/u/21308042?v=4","gravatar_id":"","url":"https://api.github.com/users/YankevinPlacali","html_url":"https://github.com/YankevinPlacali","followers_url":"https://api.github.com/users/YankevinPlacali/followers","following_url":"https://api.github.com/users/YankevinPlacali/following{/other_user}","gists_url":"https://api.github.com/users/YankevinPlacali/gists{/gist_id}","starred_url":"https://api.github.com/users/YankevinPlacali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YankevinPlacali/subscriptions","organizations_url":"https://api.github.com/users/YankevinPlacali/orgs","repos_url":"https://api.github.com/users/YankevinPlacali/repos","events_url":"https://api.github.com/users/YankevinPlacali/events{/privacy}","received_events_url":"https://api.github.com/users/YankevinPlacali/received_events","type":"User","site_admin":false},"html_url":"https://github.com/YankevinPlacali/Ambacam2018","description":null,"fork":false,"url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018","forks_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/forks","keys_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/teams","hooks_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/hooks","issue_events_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues/events{/number}","events_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/events","assignees_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/assignees{/user}","branches_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/branches{/branch}","tags_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/tags","blobs_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/statuses/{sha}","languages_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/languages","stargazers_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/stargazers","contributors_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/contributors","subscribers_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/subscribers","subscription_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/subscription","commits_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/contents/{+path}","compare_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/merges","archive_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/downloads","issues_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues{/number}","pulls_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls{/number}","milestones_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/milestones{/number}","notifications_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/labels{/name}","releases_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/releases{/id}","deployments_url":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/deployments","created_at":"2018-04-08T15:43:52Z","updated_at":"2018-10-15T20:23:02Z","pushed_at":"2018-10-16T19:24:13Z","git_url":"git://github.com/YankevinPlacali/Ambacam2018.git","ssh_url":"[email protected]:YankevinPlacali/Ambacam2018.git","clone_url":"https://github.com/YankevinPlacali/Ambacam2018.git","svn_url":"https://github.com/YankevinPlacali/Ambacam2018","homepage":null,"size":63077,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/98"},"html":{"href":"https://github.com/YankevinPlacali/Ambacam2018/pull/98"},"issue":{"href":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues/98"},"comments":{"href":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/YankevinPlacali/Ambacam2018/statuses/734783eb2c603e4aca52a4e0e42c8c3f42141382"}},"author_association":"OWNER"}} | {
"id": 128656570,
"name": "YankevinPlacali/Ambacam2018",
"url": "https://api.github.com/repos/YankevinPlacali/Ambacam2018"
} | {
"id": 23260207,
"login": "MentalistHB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23260207?",
"url": "https://api.github.com/users/MentalistHB"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-10-16T19:38:55 | 8430899462 | {"actor":{"display_login":"MentalistHB"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tuchfarber/skateboard/pulls/comments/176137089","pull_request_review_id":105787593,"id":176137089,"diff_hunk":"@@ -0,0 +1,12 @@\n+{% extends \"base.html\" %}\n+\n+{% block content %}\n+ <div id=\"home\" class=\"container\">\n+ <div class=\"row\">\n+ <div class=\"col-12\">\n+ <h2 class=\"center-text\">Welcome to Skateboard!</h2>\n+ <p class=\"center-text\">Please login to view your skateboards</p>","path":"skateboard/apps/skateboard/templates/skateboard/home.html","position":null,"original_position":8,"commit_id":"80515d0b1832cd2ca869ed930e606991abfa272b","original_commit_id":"ff8d7cae56bebb61adc8b9dadb04ce0a8823fc73","user":{"login":"tuchfarber","id":6179874,"avatar_url":"https://avatars3.githubusercontent.com/u/6179874?v=4","gravatar_id":"","url":"https://api.github.com/users/tuchfarber","html_url":"https://github.com/tuchfarber","followers_url":"https://api.github.com/users/tuchfarber/followers","following_url":"https://api.github.com/users/tuchfarber/following{/other_user}","gists_url":"https://api.github.com/users/tuchfarber/gists{/gist_id}","starred_url":"https://api.github.com/users/tuchfarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuchfarber/subscriptions","organizations_url":"https://api.github.com/users/tuchfarber/orgs","repos_url":"https://api.github.com/users/tuchfarber/repos","events_url":"https://api.github.com/users/tuchfarber/events{/privacy}","received_events_url":"https://api.github.com/users/tuchfarber/received_events","type":"User","site_admin":false},"body":"Added.","created_at":"2018-03-21T15:58:10Z","updated_at":"2018-03-21T15:58:10Z","html_url":"https://github.com/tuchfarber/skateboard/pull/7#discussion_r176137089","pull_request_url":"https://api.github.com/repos/tuchfarber/skateboard/pulls/7","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tuchfarber/skateboard/pulls/comments/176137089"},"html":{"href":"https://github.com/tuchfarber/skateboard/pull/7#discussion_r176137089"},"pull_request":{"href":"https://api.github.com/repos/tuchfarber/skateboard/pulls/7"}},"in_reply_to_id":176069371},"pull_request":{"url":"https://api.github.com/repos/tuchfarber/skateboard/pulls/7","id":175966118,"html_url":"https://github.com/tuchfarber/skateboard/pull/7","diff_url":"https://github.com/tuchfarber/skateboard/pull/7.diff","patch_url":"https://github.com/tuchfarber/skateboard/pull/7.patch","issue_url":"https://api.github.com/repos/tuchfarber/skateboard/issues/7","number":7,"state":"open","locked":false,"title":"Tuchfarber/auth flow","user":{"login":"tuchfarber","id":6179874,"avatar_url":"https://avatars3.githubusercontent.com/u/6179874?v=4","gravatar_id":"","url":"https://api.github.com/users/tuchfarber","html_url":"https://github.com/tuchfarber","followers_url":"https://api.github.com/users/tuchfarber/followers","following_url":"https://api.github.com/users/tuchfarber/following{/other_user}","gists_url":"https://api.github.com/users/tuchfarber/gists{/gist_id}","starred_url":"https://api.github.com/users/tuchfarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuchfarber/subscriptions","organizations_url":"https://api.github.com/users/tuchfarber/orgs","repos_url":"https://api.github.com/users/tuchfarber/repos","events_url":"https://api.github.com/users/tuchfarber/events{/privacy}","received_events_url":"https://api.github.com/users/tuchfarber/received_events","type":"User","site_admin":false},"body":"Adds homepage, link to CMS for staff users, and login/logout links. ","created_at":"2018-03-19T17:09:03Z","updated_at":"2018-03-21T15:58:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f9788f93205d48f5b8cbf7227e9b40e5069803a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tuchfarber/skateboard/pulls/7/commits","review_comments_url":"https://api.github.com/repos/tuchfarber/skateboard/pulls/7/comments","review_comment_url":"https://api.github.com/repos/tuchfarber/skateboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tuchfarber/skateboard/issues/7/comments","statuses_url":"https://api.github.com/repos/tuchfarber/skateboard/statuses/80515d0b1832cd2ca869ed930e606991abfa272b","head":{"label":"tuchfarber:tuchfarber/auth_flow","ref":"tuchfarber/auth_flow","sha":"80515d0b1832cd2ca869ed930e606991abfa272b","user":{"login":"tuchfarber","id":6179874,"avatar_url":"https://avatars3.githubusercontent.com/u/6179874?v=4","gravatar_id":"","url":"https://api.github.com/users/tuchfarber","html_url":"https://github.com/tuchfarber","followers_url":"https://api.github.com/users/tuchfarber/followers","following_url":"https://api.github.com/users/tuchfarber/following{/other_user}","gists_url":"https://api.github.com/users/tuchfarber/gists{/gist_id}","starred_url":"https://api.github.com/users/tuchfarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuchfarber/subscriptions","organizations_url":"https://api.github.com/users/tuchfarber/orgs","repos_url":"https://api.github.com/users/tuchfarber/repos","events_url":"https://api.github.com/users/tuchfarber/events{/privacy}","received_events_url":"https://api.github.com/users/tuchfarber/received_events","type":"User","site_admin":false},"repo":{"id":123191648,"name":"skateboard","full_name":"tuchfarber/skateboard","owner":{"login":"tuchfarber","id":6179874,"avatar_url":"https://avatars3.githubusercontent.com/u/6179874?v=4","gravatar_id":"","url":"https://api.github.com/users/tuchfarber","html_url":"https://github.com/tuchfarber","followers_url":"https://api.github.com/users/tuchfarber/followers","following_url":"https://api.github.com/users/tuchfarber/following{/other_user}","gists_url":"https://api.github.com/users/tuchfarber/gists{/gist_id}","starred_url":"https://api.github.com/users/tuchfarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuchfarber/subscriptions","organizations_url":"https://api.github.com/users/tuchfarber/orgs","repos_url":"https://api.github.com/users/tuchfarber/repos","events_url":"https://api.github.com/users/tuchfarber/events{/privacy}","received_events_url":"https://api.github.com/users/tuchfarber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuchfarber/skateboard","description":null,"fork":false,"url":"https://api.github.com/repos/tuchfarber/skateboard","forks_url":"https://api.github.com/repos/tuchfarber/skateboard/forks","keys_url":"https://api.github.com/repos/tuchfarber/skateboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuchfarber/skateboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuchfarber/skateboard/teams","hooks_url":"https://api.github.com/repos/tuchfarber/skateboard/hooks","issue_events_url":"https://api.github.com/repos/tuchfarber/skateboard/issues/events{/number}","events_url":"https://api.github.com/repos/tuchfarber/skateboard/events","assignees_url":"https://api.github.com/repos/tuchfarber/skateboard/assignees{/user}","branches_url":"https://api.github.com/repos/tuchfarber/skateboard/branches{/branch}","tags_url":"https://api.github.com/repos/tuchfarber/skateboard/tags","blobs_url":"https://api.github.com/repos/tuchfarber/skateboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuchfarber/skateboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuchfarber/skateboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuchfarber/skateboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuchfarber/skateboard/statuses/{sha}","languages_url":"https://api.github.com/repos/tuchfarber/skateboard/languages","stargazers_url":"https://api.github.com/repos/tuchfarber/skateboard/stargazers","contributors_url":"https://api.github.com/repos/tuchfarber/skateboard/contributors","subscribers_url":"https://api.github.com/repos/tuchfarber/skateboard/subscribers","subscription_url":"https://api.github.com/repos/tuchfarber/skateboard/subscription","commits_url":"https://api.github.com/repos/tuchfarber/skateboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuchfarber/skateboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuchfarber/skateboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuchfarber/skateboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuchfarber/skateboard/contents/{+path}","compare_url":"https://api.github.com/repos/tuchfarber/skateboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuchfarber/skateboard/merges","archive_url":"https://api.github.com/repos/tuchfarber/skateboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuchfarber/skateboard/downloads","issues_url":"https://api.github.com/repos/tuchfarber/skateboard/issues{/number}","pulls_url":"https://api.github.com/repos/tuchfarber/skateboard/pulls{/number}","milestones_url":"https://api.github.com/repos/tuchfarber/skateboard/milestones{/number}","notifications_url":"https://api.github.com/repos/tuchfarber/skateboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuchfarber/skateboard/labels{/name}","releases_url":"https://api.github.com/repos/tuchfarber/skateboard/releases{/id}","deployments_url":"https://api.github.com/repos/tuchfarber/skateboard/deployments","created_at":"2018-02-27T21:36:32Z","updated_at":"2018-03-20T16:33:45Z","pushed_at":"2018-03-21T15:57:10Z","git_url":"git://github.com/tuchfarber/skateboard.git","ssh_url":"[email protected]:tuchfarber/skateboard.git","clone_url":"https://github.com/tuchfarber/skateboard.git","svn_url":"https://github.com/tuchfarber/skateboard","homepage":null,"size":3196,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"tuchfarber:master","ref":"master","sha":"1e961b81a405da1f0600185ab79678a0d62b00e6","user":{"login":"tuchfarber","id":6179874,"avatar_url":"https://avatars3.githubusercontent.com/u/6179874?v=4","gravatar_id":"","url":"https://api.github.com/users/tuchfarber","html_url":"https://github.com/tuchfarber","followers_url":"https://api.github.com/users/tuchfarber/followers","following_url":"https://api.github.com/users/tuchfarber/following{/other_user}","gists_url":"https://api.github.com/users/tuchfarber/gists{/gist_id}","starred_url":"https://api.github.com/users/tuchfarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuchfarber/subscriptions","organizations_url":"https://api.github.com/users/tuchfarber/orgs","repos_url":"https://api.github.com/users/tuchfarber/repos","events_url":"https://api.github.com/users/tuchfarber/events{/privacy}","received_events_url":"https://api.github.com/users/tuchfarber/received_events","type":"User","site_admin":false},"repo":{"id":123191648,"name":"skateboard","full_name":"tuchfarber/skateboard","owner":{"login":"tuchfarber","id":6179874,"avatar_url":"https://avatars3.githubusercontent.com/u/6179874?v=4","gravatar_id":"","url":"https://api.github.com/users/tuchfarber","html_url":"https://github.com/tuchfarber","followers_url":"https://api.github.com/users/tuchfarber/followers","following_url":"https://api.github.com/users/tuchfarber/following{/other_user}","gists_url":"https://api.github.com/users/tuchfarber/gists{/gist_id}","starred_url":"https://api.github.com/users/tuchfarber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuchfarber/subscriptions","organizations_url":"https://api.github.com/users/tuchfarber/orgs","repos_url":"https://api.github.com/users/tuchfarber/repos","events_url":"https://api.github.com/users/tuchfarber/events{/privacy}","received_events_url":"https://api.github.com/users/tuchfarber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuchfarber/skateboard","description":null,"fork":false,"url":"https://api.github.com/repos/tuchfarber/skateboard","forks_url":"https://api.github.com/repos/tuchfarber/skateboard/forks","keys_url":"https://api.github.com/repos/tuchfarber/skateboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuchfarber/skateboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuchfarber/skateboard/teams","hooks_url":"https://api.github.com/repos/tuchfarber/skateboard/hooks","issue_events_url":"https://api.github.com/repos/tuchfarber/skateboard/issues/events{/number}","events_url":"https://api.github.com/repos/tuchfarber/skateboard/events","assignees_url":"https://api.github.com/repos/tuchfarber/skateboard/assignees{/user}","branches_url":"https://api.github.com/repos/tuchfarber/skateboard/branches{/branch}","tags_url":"https://api.github.com/repos/tuchfarber/skateboard/tags","blobs_url":"https://api.github.com/repos/tuchfarber/skateboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuchfarber/skateboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuchfarber/skateboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuchfarber/skateboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuchfarber/skateboard/statuses/{sha}","languages_url":"https://api.github.com/repos/tuchfarber/skateboard/languages","stargazers_url":"https://api.github.com/repos/tuchfarber/skateboard/stargazers","contributors_url":"https://api.github.com/repos/tuchfarber/skateboard/contributors","subscribers_url":"https://api.github.com/repos/tuchfarber/skateboard/subscribers","subscription_url":"https://api.github.com/repos/tuchfarber/skateboard/subscription","commits_url":"https://api.github.com/repos/tuchfarber/skateboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuchfarber/skateboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuchfarber/skateboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuchfarber/skateboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuchfarber/skateboard/contents/{+path}","compare_url":"https://api.github.com/repos/tuchfarber/skateboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuchfarber/skateboard/merges","archive_url":"https://api.github.com/repos/tuchfarber/skateboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuchfarber/skateboard/downloads","issues_url":"https://api.github.com/repos/tuchfarber/skateboard/issues{/number}","pulls_url":"https://api.github.com/repos/tuchfarber/skateboard/pulls{/number}","milestones_url":"https://api.github.com/repos/tuchfarber/skateboard/milestones{/number}","notifications_url":"https://api.github.com/repos/tuchfarber/skateboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuchfarber/skateboard/labels{/name}","releases_url":"https://api.github.com/repos/tuchfarber/skateboard/releases{/id}","deployments_url":"https://api.github.com/repos/tuchfarber/skateboard/deployments","created_at":"2018-02-27T21:36:32Z","updated_at":"2018-03-20T16:33:45Z","pushed_at":"2018-03-21T15:57:10Z","git_url":"git://github.com/tuchfarber/skateboard.git","ssh_url":"[email protected]:tuchfarber/skateboard.git","clone_url":"https://github.com/tuchfarber/skateboard.git","svn_url":"https://github.com/tuchfarber/skateboard","homepage":null,"size":3196,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tuchfarber/skateboard/pulls/7"},"html":{"href":"https://github.com/tuchfarber/skateboard/pull/7"},"issue":{"href":"https://api.github.com/repos/tuchfarber/skateboard/issues/7"},"comments":{"href":"https://api.github.com/repos/tuchfarber/skateboard/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/tuchfarber/skateboard/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/tuchfarber/skateboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tuchfarber/skateboard/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/tuchfarber/skateboard/statuses/80515d0b1832cd2ca869ed930e606991abfa272b"}},"author_association":"OWNER"}} | {
"id": 123191648,
"name": "tuchfarber/skateboard",
"url": "https://api.github.com/repos/tuchfarber/skateboard"
} | {
"id": 6179874,
"login": "tuchfarber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6179874?",
"url": "https://api.github.com/users/tuchfarber"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-03-21T15:58:10 | 7413822975 | {"actor":{"display_login":"tuchfarber"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/comments/192400876","pull_request_review_id":125173506,"id":192400876,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQwMDg3Ng==","diff_hunk":"@@ -53,7 +49,15 @@ String getCountKey() {\n @Override\n public HashMap<String, Object> getViewData() {\n HashMap<String, Object> ret = super.getViewData();\n- ret.put(Constant.SHOP_ITEM_PERFORMANCE_KEY, basePerformance);\n+ ret.put(Constant.SHOP_ITEM_PERFORMANCE_KEY, Constant.formatMoney(getUnaryPerformance()));\n return ret;\n }\n+\n+ BigInteger getTotalPerformance() {\n+ return getUnaryPerformance().multiply(BigInteger.valueOf(getCount()));\n+ }\n+\n+ BigInteger getUnaryPerformance() {\n+ return Constant.multiply(basePerformance, pow(1.15, storage.getShopItemCount(Constant.upgradeCountKey(5))));","path":"app/src/main/java/ru/sibur/android/garbagecollector/Automata.java","position":60,"original_position":60,"commit_id":"c8eba3699768db53bdc6f5e7a97cb211a07ba42e","original_commit_id":"c8eba3699768db53bdc6f5e7a97cb211a07ba42e","user":{"login":"grihabor","id":13349050,"node_id":"MDQ6VXNlcjEzMzQ5MDUw","avatar_url":"https://avatars1.githubusercontent.com/u/13349050?v=4","gravatar_id":"","url":"https://api.github.com/users/grihabor","html_url":"https://github.com/grihabor","followers_url":"https://api.github.com/users/grihabor/followers","following_url":"https://api.github.com/users/grihabor/following{/other_user}","gists_url":"https://api.github.com/users/grihabor/gists{/gist_id}","starred_url":"https://api.github.com/users/grihabor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grihabor/subscriptions","organizations_url":"https://api.github.com/users/grihabor/orgs","repos_url":"https://api.github.com/users/grihabor/repos","events_url":"https://api.github.com/users/grihabor/events{/privacy}","received_events_url":"https://api.github.com/users/grihabor/received_events","type":"User","site_admin":false},"body":"Разносим на несколько строчек","created_at":"2018-06-01T13:46:32Z","updated_at":"2018-06-01T13:55:24Z","html_url":"https://github.com/grihabor/garbage-clicker/pull/174#discussion_r192400876","pull_request_url":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/174","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/comments/192400876"},"html":{"href":"https://github.com/grihabor/garbage-clicker/pull/174#discussion_r192400876"},"pull_request":{"href":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/174","id":192033350,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDMzMzUw","html_url":"https://github.com/grihabor/garbage-clicker/pull/174","diff_url":"https://github.com/grihabor/garbage-clicker/pull/174.diff","patch_url":"https://github.com/grihabor/garbage-clicker/pull/174.patch","issue_url":"https://api.github.com/repos/grihabor/garbage-clicker/issues/174","number":174,"state":"open","locked":false,"title":"Bigger money storage","user":{"login":"RedSnail","id":36077611,"node_id":"MDQ6VXNlcjM2MDc3NjEx","avatar_url":"https://avatars0.githubusercontent.com/u/36077611?v=4","gravatar_id":"","url":"https://api.github.com/users/RedSnail","html_url":"https://github.com/RedSnail","followers_url":"https://api.github.com/users/RedSnail/followers","following_url":"https://api.github.com/users/RedSnail/following{/other_user}","gists_url":"https://api.github.com/users/RedSnail/gists{/gist_id}","starred_url":"https://api.github.com/users/RedSnail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedSnail/subscriptions","organizations_url":"https://api.github.com/users/RedSnail/orgs","repos_url":"https://api.github.com/users/RedSnail/repos","events_url":"https://api.github.com/users/RedSnail/events{/privacy}","received_events_url":"https://api.github.com/users/RedSnail/received_events","type":"User","site_admin":false},"body":"теперь если у нас Count'ы не выйдут за int, ничто не выйдет\r\nещё немножко похимичил с AutomataThread и теперь апгрейт мощности автоматов работает","created_at":"2018-06-01T13:23:20Z","updated_at":"2018-06-01T13:55:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"978bc0d384c0ca13d3a211d3030909ab0f577a4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/174/commits","review_comments_url":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/174/comments","review_comment_url":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grihabor/garbage-clicker/issues/174/comments","statuses_url":"https://api.github.com/repos/grihabor/garbage-clicker/statuses/c8eba3699768db53bdc6f5e7a97cb211a07ba42e","head":{"label":"grihabor:bigger_money_storage","ref":"bigger_money_storage","sha":"c8eba3699768db53bdc6f5e7a97cb211a07ba42e","user":{"login":"grihabor","id":13349050,"node_id":"MDQ6VXNlcjEzMzQ5MDUw","avatar_url":"https://avatars1.githubusercontent.com/u/13349050?v=4","gravatar_id":"","url":"https://api.github.com/users/grihabor","html_url":"https://github.com/grihabor","followers_url":"https://api.github.com/users/grihabor/followers","following_url":"https://api.github.com/users/grihabor/following{/other_user}","gists_url":"https://api.github.com/users/grihabor/gists{/gist_id}","starred_url":"https://api.github.com/users/grihabor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grihabor/subscriptions","organizations_url":"https://api.github.com/users/grihabor/orgs","repos_url":"https://api.github.com/users/grihabor/repos","events_url":"https://api.github.com/users/grihabor/events{/privacy}","received_events_url":"https://api.github.com/users/grihabor/received_events","type":"User","site_admin":false},"repo":{"id":122976852,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI5NzY4NTI=","name":"garbage-clicker","full_name":"grihabor/garbage-clicker","owner":{"login":"grihabor","id":13349050,"node_id":"MDQ6VXNlcjEzMzQ5MDUw","avatar_url":"https://avatars1.githubusercontent.com/u/13349050?v=4","gravatar_id":"","url":"https://api.github.com/users/grihabor","html_url":"https://github.com/grihabor","followers_url":"https://api.github.com/users/grihabor/followers","following_url":"https://api.github.com/users/grihabor/following{/other_user}","gists_url":"https://api.github.com/users/grihabor/gists{/gist_id}","starred_url":"https://api.github.com/users/grihabor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grihabor/subscriptions","organizations_url":"https://api.github.com/users/grihabor/orgs","repos_url":"https://api.github.com/users/grihabor/repos","events_url":"https://api.github.com/users/grihabor/events{/privacy}","received_events_url":"https://api.github.com/users/grihabor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grihabor/garbage-clicker","description":"Garbage Clicker = Переработка мусора + Cookie Clicker","fork":false,"url":"https://api.github.com/repos/grihabor/garbage-clicker","forks_url":"https://api.github.com/repos/grihabor/garbage-clicker/forks","keys_url":"https://api.github.com/repos/grihabor/garbage-clicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grihabor/garbage-clicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grihabor/garbage-clicker/teams","hooks_url":"https://api.github.com/repos/grihabor/garbage-clicker/hooks","issue_events_url":"https://api.github.com/repos/grihabor/garbage-clicker/issues/events{/number}","events_url":"https://api.github.com/repos/grihabor/garbage-clicker/events","assignees_url":"https://api.github.com/repos/grihabor/garbage-clicker/assignees{/user}","branches_url":"https://api.github.com/repos/grihabor/garbage-clicker/branches{/branch}","tags_url":"https://api.github.com/repos/grihabor/garbage-clicker/tags","blobs_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grihabor/garbage-clicker/statuses/{sha}","languages_url":"https://api.github.com/repos/grihabor/garbage-clicker/languages","stargazers_url":"https://api.github.com/repos/grihabor/garbage-clicker/stargazers","contributors_url":"https://api.github.com/repos/grihabor/garbage-clicker/contributors","subscribers_url":"https://api.github.com/repos/grihabor/garbage-clicker/subscribers","subscription_url":"https://api.github.com/repos/grihabor/garbage-clicker/subscription","commits_url":"https://api.github.com/repos/grihabor/garbage-clicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/grihabor/garbage-clicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/grihabor/garbage-clicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/grihabor/garbage-clicker/contents/{+path}","compare_url":"https://api.github.com/repos/grihabor/garbage-clicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grihabor/garbage-clicker/merges","archive_url":"https://api.github.com/repos/grihabor/garbage-clicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grihabor/garbage-clicker/downloads","issues_url":"https://api.github.com/repos/grihabor/garbage-clicker/issues{/number}","pulls_url":"https://api.github.com/repos/grihabor/garbage-clicker/pulls{/number}","milestones_url":"https://api.github.com/repos/grihabor/garbage-clicker/milestones{/number}","notifications_url":"https://api.github.com/repos/grihabor/garbage-clicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grihabor/garbage-clicker/labels{/name}","releases_url":"https://api.github.com/repos/grihabor/garbage-clicker/releases{/id}","deployments_url":"https://api.github.com/repos/grihabor/garbage-clicker/deployments","created_at":"2018-02-26T13:53:15Z","updated_at":"2018-06-01T11:30:14Z","pushed_at":"2018-06-01T13:50:14Z","git_url":"git://github.com/grihabor/garbage-clicker.git","ssh_url":"[email protected]:grihabor/garbage-clicker.git","clone_url":"https://github.com/grihabor/garbage-clicker.git","svn_url":"https://github.com/grihabor/garbage-clicker","homepage":"","size":771,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":25,"watchers":0,"default_branch":"master"}},"base":{"label":"grihabor:master","ref":"master","sha":"703442ae91ad4eebb28d523c4abb9e8f3f82674f","user":{"login":"grihabor","id":13349050,"node_id":"MDQ6VXNlcjEzMzQ5MDUw","avatar_url":"https://avatars1.githubusercontent.com/u/13349050?v=4","gravatar_id":"","url":"https://api.github.com/users/grihabor","html_url":"https://github.com/grihabor","followers_url":"https://api.github.com/users/grihabor/followers","following_url":"https://api.github.com/users/grihabor/following{/other_user}","gists_url":"https://api.github.com/users/grihabor/gists{/gist_id}","starred_url":"https://api.github.com/users/grihabor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grihabor/subscriptions","organizations_url":"https://api.github.com/users/grihabor/orgs","repos_url":"https://api.github.com/users/grihabor/repos","events_url":"https://api.github.com/users/grihabor/events{/privacy}","received_events_url":"https://api.github.com/users/grihabor/received_events","type":"User","site_admin":false},"repo":{"id":122976852,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI5NzY4NTI=","name":"garbage-clicker","full_name":"grihabor/garbage-clicker","owner":{"login":"grihabor","id":13349050,"node_id":"MDQ6VXNlcjEzMzQ5MDUw","avatar_url":"https://avatars1.githubusercontent.com/u/13349050?v=4","gravatar_id":"","url":"https://api.github.com/users/grihabor","html_url":"https://github.com/grihabor","followers_url":"https://api.github.com/users/grihabor/followers","following_url":"https://api.github.com/users/grihabor/following{/other_user}","gists_url":"https://api.github.com/users/grihabor/gists{/gist_id}","starred_url":"https://api.github.com/users/grihabor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grihabor/subscriptions","organizations_url":"https://api.github.com/users/grihabor/orgs","repos_url":"https://api.github.com/users/grihabor/repos","events_url":"https://api.github.com/users/grihabor/events{/privacy}","received_events_url":"https://api.github.com/users/grihabor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grihabor/garbage-clicker","description":"Garbage Clicker = Переработка мусора + Cookie Clicker","fork":false,"url":"https://api.github.com/repos/grihabor/garbage-clicker","forks_url":"https://api.github.com/repos/grihabor/garbage-clicker/forks","keys_url":"https://api.github.com/repos/grihabor/garbage-clicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grihabor/garbage-clicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grihabor/garbage-clicker/teams","hooks_url":"https://api.github.com/repos/grihabor/garbage-clicker/hooks","issue_events_url":"https://api.github.com/repos/grihabor/garbage-clicker/issues/events{/number}","events_url":"https://api.github.com/repos/grihabor/garbage-clicker/events","assignees_url":"https://api.github.com/repos/grihabor/garbage-clicker/assignees{/user}","branches_url":"https://api.github.com/repos/grihabor/garbage-clicker/branches{/branch}","tags_url":"https://api.github.com/repos/grihabor/garbage-clicker/tags","blobs_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grihabor/garbage-clicker/statuses/{sha}","languages_url":"https://api.github.com/repos/grihabor/garbage-clicker/languages","stargazers_url":"https://api.github.com/repos/grihabor/garbage-clicker/stargazers","contributors_url":"https://api.github.com/repos/grihabor/garbage-clicker/contributors","subscribers_url":"https://api.github.com/repos/grihabor/garbage-clicker/subscribers","subscription_url":"https://api.github.com/repos/grihabor/garbage-clicker/subscription","commits_url":"https://api.github.com/repos/grihabor/garbage-clicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/grihabor/garbage-clicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/grihabor/garbage-clicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/grihabor/garbage-clicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/grihabor/garbage-clicker/contents/{+path}","compare_url":"https://api.github.com/repos/grihabor/garbage-clicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grihabor/garbage-clicker/merges","archive_url":"https://api.github.com/repos/grihabor/garbage-clicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grihabor/garbage-clicker/downloads","issues_url":"https://api.github.com/repos/grihabor/garbage-clicker/issues{/number}","pulls_url":"https://api.github.com/repos/grihabor/garbage-clicker/pulls{/number}","milestones_url":"https://api.github.com/repos/grihabor/garbage-clicker/milestones{/number}","notifications_url":"https://api.github.com/repos/grihabor/garbage-clicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grihabor/garbage-clicker/labels{/name}","releases_url":"https://api.github.com/repos/grihabor/garbage-clicker/releases{/id}","deployments_url":"https://api.github.com/repos/grihabor/garbage-clicker/deployments","created_at":"2018-02-26T13:53:15Z","updated_at":"2018-06-01T11:30:14Z","pushed_at":"2018-06-01T13:50:14Z","git_url":"git://github.com/grihabor/garbage-clicker.git","ssh_url":"[email protected]:grihabor/garbage-clicker.git","clone_url":"https://github.com/grihabor/garbage-clicker.git","svn_url":"https://github.com/grihabor/garbage-clicker","homepage":"","size":771,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":25,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/174"},"html":{"href":"https://github.com/grihabor/garbage-clicker/pull/174"},"issue":{"href":"https://api.github.com/repos/grihabor/garbage-clicker/issues/174"},"comments":{"href":"https://api.github.com/repos/grihabor/garbage-clicker/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grihabor/garbage-clicker/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/grihabor/garbage-clicker/statuses/c8eba3699768db53bdc6f5e7a97cb211a07ba42e"}},"author_association":"COLLABORATOR"}} | {
"id": 122976852,
"name": "grihabor/garbage-clicker",
"url": "https://api.github.com/repos/grihabor/garbage-clicker"
} | {
"id": 13349050,
"login": "grihabor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13349050?",
"url": "https://api.github.com/users/grihabor"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-06-01T13:46:32 | 7762560853 | {"actor":{"display_login":"grihabor"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/comments/240759543","pull_request_review_id":183863543,"id":240759543,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDc1OTU0Mw==","diff_hunk":"@@ -0,0 +1,115 @@\n+import org.testng.Assert;\n+import org.testng.annotations.BeforeClass;\n+import org.testng.annotations.DataProvider;\n+import org.testng.annotations.Test;\n+\n+public class CalcUnitTests {\n+\n+\t@BeforeClass\n+\tpublic void oneTimeSetUp() {\n+\t\tSystem.out.print(\"Before Class\");\n+\t}\n+\n+ @Test(dataProvider = \"testAddDataProvider\")\n+ public void checkSum(double operand1, double operand2, double total) {\n+ Calculator calculator = new Calculator(operand1, Operator.PLUS, operand2);\n+ System.out.println(\"Test Total: \" + calculator.makeCalculation());\n+ Assert.assertEquals(calculator.makeCalculation(), total);\n+ }\n+\n+\t@DataProvider(name = \"testAddDataProvider\")\n+\tpublic Object[][] parameterAddTestProvider() {\n+\t\treturn new Object[][]{\n+\t\t\t\t{2, 2, 4},\n+\t\t\t\t{1, 0, 1},\n+\t\t\t\t{0, 0, 0},\n+\t\t\t\t{1, -1, 0},\n+\t\t\t\t{-2, -2, -4},\n+\t\t\t\t{2, 22, 24},\n+\t\t\t\t{Double.MAX_VALUE, 1, Double.MAX_VALUE}\n+\t\t};\n+\t}\n+\n+ @Test(dataProvider = \"testSubDataProvider\")\n+ public void checkDifference(double operand1, double operand2, double total) {\n+ Calculator calculator = new Calculator(operand1, Operator.MINUS, operand2);\n+ System.out.println(\"Test Total: \" + calculator.makeCalculation());\n+ Assert.assertEquals(calculator.makeCalculation(), total);\n+ }\n+\n+\t@DataProvider(name = \"testSubDataProvider\")\n+\tpublic Object[][] parameterSubTestProvider() {\n+\t\treturn new Object[][]{\n+\t\t\t\t{2, 2, 0},\n+\t\t\t\t{1, 0, 1},\n+\t\t\t\t{0, 0, 0},\n+\t\t\t\t{0, 1, -1},\n+\t\t\t\t{-2, 2, -4},\n+\t\t\t\t{-2, 22, -24},\n+\t\t\t\t{Double.MIN_VALUE, 1, -1}\n+\t\t};\n+\t}\n+\n+ @Test(dataProvider = \"testMultDataProvider\")\n+ public void checkProduct(double operand1, double operand2, double total) {\n+ Calculator calculator = new Calculator(operand1, Operator.MULTIPLY, operand2);\n+ System.out.println(\"Test Total: \" + calculator.makeCalculation());\n+ Assert.assertEquals(calculator.makeCalculation(), total);\n+ }\n+\n+\t@DataProvider(name = \"testMultDataProvider\")\n+\tpublic Object[][] parameterMultTestProvider() {\n+\t\treturn new Object[][]{\n+\t\t\t\t{2, 2, 4},\n+\t\t\t\t{1, 0, 0},\n+\t\t\t\t{0, 0, 0},\n+\t\t\t\t{0, -1, -0.0},\n+\t\t\t\t{2, -2, -4},\n+\t\t\t\t{2, 22, 44}\n+\t\t};\n+\t}\n+\n+ @Test(expectedExceptions = IllegalArgumentException.class,\n+ expectedExceptionsMessageRegExp = \"Error: Can't divide by zero!\",\n+ dataProvider = \"testDivByZeroDataProvider\")\n+ public void checkDivisionByZero(double operand1, double operand2, double total)\n+ throws IllegalArgumentException {","path":"Lecture4/src/test/java/CalcUnitTests.java","position":76,"original_position":76,"commit_id":"d93f8397433afba3996b8b08bf1d1a8bb4bbfc19","original_commit_id":"d93f8397433afba3996b8b08bf1d1a8bb4bbfc19","user":{"login":"carmenhorendum","id":20130148,"node_id":"MDQ6VXNlcjIwMTMwMTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/20130148?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenhorendum","html_url":"https://github.com/carmenhorendum","followers_url":"https://api.github.com/users/carmenhorendum/followers","following_url":"https://api.github.com/users/carmenhorendum/following{/other_user}","gists_url":"https://api.github.com/users/carmenhorendum/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenhorendum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenhorendum/subscriptions","organizations_url":"https://api.github.com/users/carmenhorendum/orgs","repos_url":"https://api.github.com/users/carmenhorendum/repos","events_url":"https://api.github.com/users/carmenhorendum/events{/privacy}","received_events_url":"https://api.github.com/users/carmenhorendum/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-12-11T19:31:13Z","updated_at":"2018-12-11T19:31:13Z","html_url":"https://github.com/carmenhorendum/AutomationSchool/pull/4#discussion_r240759543","pull_request_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/4","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/comments/240759543"},"html":{"href":"https://github.com/carmenhorendum/AutomationSchool/pull/4#discussion_r240759543"},"pull_request":{"href":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/4"}},"in_reply_to_id":240533185},"pull_request":{"url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/4","id":235291305,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjkxMzA1","html_url":"https://github.com/carmenhorendum/AutomationSchool/pull/4","diff_url":"https://github.com/carmenhorendum/AutomationSchool/pull/4.diff","patch_url":"https://github.com/carmenhorendum/AutomationSchool/pull/4.patch","issue_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues/4","number":4,"state":"open","locked":false,"title":"Lecture4","user":{"login":"carmenhorendum","id":20130148,"node_id":"MDQ6VXNlcjIwMTMwMTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/20130148?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenhorendum","html_url":"https://github.com/carmenhorendum","followers_url":"https://api.github.com/users/carmenhorendum/followers","following_url":"https://api.github.com/users/carmenhorendum/following{/other_user}","gists_url":"https://api.github.com/users/carmenhorendum/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenhorendum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenhorendum/subscriptions","organizations_url":"https://api.github.com/users/carmenhorendum/orgs","repos_url":"https://api.github.com/users/carmenhorendum/repos","events_url":"https://api.github.com/users/carmenhorendum/events{/privacy}","received_events_url":"https://api.github.com/users/carmenhorendum/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-02T22:43:40Z","updated_at":"2018-12-11T19:31:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"584df9b3b41716cbf362029bc5031136c4435521","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/4/commits","review_comments_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/4/comments","review_comment_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues/4/comments","statuses_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/statuses/d93f8397433afba3996b8b08bf1d1a8bb4bbfc19","head":{"label":"carmenhorendum:Lecture4","ref":"Lecture4","sha":"d93f8397433afba3996b8b08bf1d1a8bb4bbfc19","user":{"login":"carmenhorendum","id":20130148,"node_id":"MDQ6VXNlcjIwMTMwMTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/20130148?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenhorendum","html_url":"https://github.com/carmenhorendum","followers_url":"https://api.github.com/users/carmenhorendum/followers","following_url":"https://api.github.com/users/carmenhorendum/following{/other_user}","gists_url":"https://api.github.com/users/carmenhorendum/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenhorendum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenhorendum/subscriptions","organizations_url":"https://api.github.com/users/carmenhorendum/orgs","repos_url":"https://api.github.com/users/carmenhorendum/repos","events_url":"https://api.github.com/users/carmenhorendum/events{/privacy}","received_events_url":"https://api.github.com/users/carmenhorendum/received_events","type":"User","site_admin":false},"repo":{"id":154843598,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4NDM1OTg=","name":"AutomationSchool","full_name":"carmenhorendum/AutomationSchool","private":false,"owner":{"login":"carmenhorendum","id":20130148,"node_id":"MDQ6VXNlcjIwMTMwMTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/20130148?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenhorendum","html_url":"https://github.com/carmenhorendum","followers_url":"https://api.github.com/users/carmenhorendum/followers","following_url":"https://api.github.com/users/carmenhorendum/following{/other_user}","gists_url":"https://api.github.com/users/carmenhorendum/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenhorendum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenhorendum/subscriptions","organizations_url":"https://api.github.com/users/carmenhorendum/orgs","repos_url":"https://api.github.com/users/carmenhorendum/repos","events_url":"https://api.github.com/users/carmenhorendum/events{/privacy}","received_events_url":"https://api.github.com/users/carmenhorendum/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carmenhorendum/AutomationSchool","description":null,"fork":false,"url":"https://api.github.com/repos/carmenhorendum/AutomationSchool","forks_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/forks","keys_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/teams","hooks_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/hooks","issue_events_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues/events{/number}","events_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/events","assignees_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/assignees{/user}","branches_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/branches{/branch}","tags_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/tags","blobs_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/refs{/sha}","trees_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/statuses/{sha}","languages_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/languages","stargazers_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/stargazers","contributors_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/contributors","subscribers_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/subscribers","subscription_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/subscription","commits_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/commits{/sha}","git_commits_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/commits{/sha}","comments_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/comments{/number}","issue_comment_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues/comments{/number}","contents_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/contents/{+path}","compare_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/merges","archive_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/downloads","issues_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues{/number}","pulls_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls{/number}","milestones_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/milestones{/number}","notifications_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/labels{/name}","releases_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/releases{/id}","deployments_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/deployments","created_at":"2018-10-26T14:02:24Z","updated_at":"2018-12-11T09:30:28Z","pushed_at":"2018-12-11T09:30:26Z","git_url":"git://github.com/carmenhorendum/AutomationSchool.git","ssh_url":"[email protected]:carmenhorendum/AutomationSchool.git","clone_url":"https://github.com/carmenhorendum/AutomationSchool.git","svn_url":"https://github.com/carmenhorendum/AutomationSchool","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"carmenhorendum:master","ref":"master","sha":"ca21d003f59d672a8e7bc4ae5704cc1f2869e6e4","user":{"login":"carmenhorendum","id":20130148,"node_id":"MDQ6VXNlcjIwMTMwMTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/20130148?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenhorendum","html_url":"https://github.com/carmenhorendum","followers_url":"https://api.github.com/users/carmenhorendum/followers","following_url":"https://api.github.com/users/carmenhorendum/following{/other_user}","gists_url":"https://api.github.com/users/carmenhorendum/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenhorendum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenhorendum/subscriptions","organizations_url":"https://api.github.com/users/carmenhorendum/orgs","repos_url":"https://api.github.com/users/carmenhorendum/repos","events_url":"https://api.github.com/users/carmenhorendum/events{/privacy}","received_events_url":"https://api.github.com/users/carmenhorendum/received_events","type":"User","site_admin":false},"repo":{"id":154843598,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4NDM1OTg=","name":"AutomationSchool","full_name":"carmenhorendum/AutomationSchool","private":false,"owner":{"login":"carmenhorendum","id":20130148,"node_id":"MDQ6VXNlcjIwMTMwMTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/20130148?v=4","gravatar_id":"","url":"https://api.github.com/users/carmenhorendum","html_url":"https://github.com/carmenhorendum","followers_url":"https://api.github.com/users/carmenhorendum/followers","following_url":"https://api.github.com/users/carmenhorendum/following{/other_user}","gists_url":"https://api.github.com/users/carmenhorendum/gists{/gist_id}","starred_url":"https://api.github.com/users/carmenhorendum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carmenhorendum/subscriptions","organizations_url":"https://api.github.com/users/carmenhorendum/orgs","repos_url":"https://api.github.com/users/carmenhorendum/repos","events_url":"https://api.github.com/users/carmenhorendum/events{/privacy}","received_events_url":"https://api.github.com/users/carmenhorendum/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carmenhorendum/AutomationSchool","description":null,"fork":false,"url":"https://api.github.com/repos/carmenhorendum/AutomationSchool","forks_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/forks","keys_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/teams","hooks_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/hooks","issue_events_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues/events{/number}","events_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/events","assignees_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/assignees{/user}","branches_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/branches{/branch}","tags_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/tags","blobs_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/refs{/sha}","trees_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/statuses/{sha}","languages_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/languages","stargazers_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/stargazers","contributors_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/contributors","subscribers_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/subscribers","subscription_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/subscription","commits_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/commits{/sha}","git_commits_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/git/commits{/sha}","comments_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/comments{/number}","issue_comment_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues/comments{/number}","contents_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/contents/{+path}","compare_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/merges","archive_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/downloads","issues_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues{/number}","pulls_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls{/number}","milestones_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/milestones{/number}","notifications_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/labels{/name}","releases_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/releases{/id}","deployments_url":"https://api.github.com/repos/carmenhorendum/AutomationSchool/deployments","created_at":"2018-10-26T14:02:24Z","updated_at":"2018-12-11T09:30:28Z","pushed_at":"2018-12-11T09:30:26Z","git_url":"git://github.com/carmenhorendum/AutomationSchool.git","ssh_url":"[email protected]:carmenhorendum/AutomationSchool.git","clone_url":"https://github.com/carmenhorendum/AutomationSchool.git","svn_url":"https://github.com/carmenhorendum/AutomationSchool","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/4"},"html":{"href":"https://github.com/carmenhorendum/AutomationSchool/pull/4"},"issue":{"href":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues/4"},"comments":{"href":"https://api.github.com/repos/carmenhorendum/AutomationSchool/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carmenhorendum/AutomationSchool/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/carmenhorendum/AutomationSchool/statuses/d93f8397433afba3996b8b08bf1d1a8bb4bbfc19"}},"author_association":"OWNER"}} | {
"id": 154843598,
"name": "carmenhorendum/AutomationSchool",
"url": "https://api.github.com/repos/carmenhorendum/AutomationSchool"
} | {
"id": 20130148,
"login": "carmenhorendum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20130148?",
"url": "https://api.github.com/users/carmenhorendum"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-12-11T19:31:13 | 8736434185 | {"actor":{"display_login":"carmenhorendum"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/comments/197669001","pull_request_review_id":131455203,"id":197669001,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzY2OTAwMQ==","diff_hunk":"@@ -0,0 +1,80 @@\n+import java.util.ArrayList;\n+import java.util.HashSet;\n+import java.util.List;\n+import java.util.Set;\n+\n+public class FindAllWords {\n+ \n+ /**\n+ * Find all the words in the dictionary that can be formed in the grid.\n+ * @param grid\n+ * @param dictionary\n+ * @return\n+ */\n+ public static Set<String> findAllWords(Grid grid, Dictionary dictionary) {\n+ Set<String> totalWords = new HashSet<String>();\n+ \n+ // For each position in the grid, find all the words that can be formed starting from there\n+ for (int i = 0; i < grid.getHeight(); i++) {\n+ for (int j = 0; j < grid.getWidth(); j++) {\n+ Set<String> wordSet = FindAllWords.searchWords(\n+ grid,\n+ dictionary,\n+ new boolean[grid.getHeight()][grid.getWidth()],\n+ new HashSet<String>(),\n+ new ArrayList<String>(),\n+ i,\n+ j);\n+ totalWords.addAll(wordSet);\n+ }\n+ }\n+ \n+ return totalWords;\n+ }\n+ \n+ public static Set<String> searchWords(\n+ Grid grid,\n+ Dictionary dictionary,\n+ boolean[][] visited,\n+ Set<String> words,\n+ List<String> path,\n+ int posX,\n+ int posY) {\n+ \n+ if (posX < 0 || posX >= grid.getHeight() || posY < 0 || posY >= grid.getWidth() || visited[posX][posY]) {\n+ return new HashSet<String>();\n+ }\n+ \n+ // Update to include new position\n+ path.add(grid.getLetter(posX, posY));\n+ visited[posX][posY] = true;\n+ \n+ String pathString = String.join(\"\", path);\n+ \n+ if (!dictionary.isPrefix(pathString)) {\n+ return new HashSet<String>();\n+ }\n+ \n+ if (dictionary.isWord(pathString)) {\n+ words.add(pathString);\n+ }\n+ \n+ // Recursively search each of the 8 adjacent cells\n+ for (int i = -1; i <= 1; i++) {\n+ for (int j = -1; j <= 1; j++) {\n+ // Make copies of path and visited to search for words in different states\n+ List<String> pathCopy = new ArrayList<String>(path);\n+ boolean[][] visitedCopy = new boolean[visited.length][];\n+ for (int k = 0; k < visited.length; k++) {\n+ visitedCopy[k] = visited[k].clone();\n+ }\n+ \n+ Set<String> newWords = searchWords(grid, dictionary, visitedCopy, words, pathCopy, posX + i, posY + j);","path":"uro98/assignment3/FindAllWords.java","position":72,"original_position":72,"commit_id":"4a94deb9f743e07366a1cbbd8482c3ce8ce448f6","original_commit_id":"4a94deb9f743e07366a1cbbd8482c3ce8ce448f6","user":{"login":"uro98","id":17531269,"node_id":"MDQ6VXNlcjE3NTMxMjY5","avatar_url":"https://avatars2.githubusercontent.com/u/17531269?v=4","gravatar_id":"","url":"https://api.github.com/users/uro98","html_url":"https://github.com/uro98","followers_url":"https://api.github.com/users/uro98/followers","following_url":"https://api.github.com/users/uro98/following{/other_user}","gists_url":"https://api.github.com/users/uro98/gists{/gist_id}","starred_url":"https://api.github.com/users/uro98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uro98/subscriptions","organizations_url":"https://api.github.com/users/uro98/orgs","repos_url":"https://api.github.com/users/uro98/repos","events_url":"https://api.github.com/users/uro98/events{/privacy}","received_events_url":"https://api.github.com/users/uro98/received_events","type":"User","site_admin":false},"body":"Thank you for the detailed feedback. Just out of curiosity, why do you think the first option is the cleanest?","created_at":"2018-06-25T02:59:24Z","updated_at":"2018-06-25T02:59:25Z","html_url":"https://github.com/flerdacodeu/CodeU-2018-Group10/pull/19#discussion_r197669001","pull_request_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/19","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/comments/197669001"},"html":{"href":"https://github.com/flerdacodeu/CodeU-2018-Group10/pull/19#discussion_r197669001"},"pull_request":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/19"}},"in_reply_to_id":197037275},"pull_request":{"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/19","id":196018824,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDE4ODI0","html_url":"https://github.com/flerdacodeu/CodeU-2018-Group10/pull/19","diff_url":"https://github.com/flerdacodeu/CodeU-2018-Group10/pull/19.diff","patch_url":"https://github.com/flerdacodeu/CodeU-2018-Group10/pull/19.patch","issue_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues/19","number":19,"state":"open","locked":false,"title":"Submit Assignment 3","user":{"login":"uro98","id":17531269,"node_id":"MDQ6VXNlcjE3NTMxMjY5","avatar_url":"https://avatars2.githubusercontent.com/u/17531269?v=4","gravatar_id":"","url":"https://api.github.com/users/uro98","html_url":"https://github.com/uro98","followers_url":"https://api.github.com/users/uro98/followers","following_url":"https://api.github.com/users/uro98/following{/other_user}","gists_url":"https://api.github.com/users/uro98/gists{/gist_id}","starred_url":"https://api.github.com/users/uro98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uro98/subscriptions","organizations_url":"https://api.github.com/users/uro98/orgs","repos_url":"https://api.github.com/users/uro98/repos","events_url":"https://api.github.com/users/uro98/events{/privacy}","received_events_url":"https://api.github.com/users/uro98/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-20T04:25:39Z","updated_at":"2018-06-25T02:59:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53127560439e3ca2784898b0e73186d667887305","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/19/commits","review_comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/19/comments","review_comment_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues/19/comments","statuses_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/statuses/4a94deb9f743e07366a1cbbd8482c3ce8ce448f6","head":{"label":"flerdacodeu:uro98-3","ref":"uro98-3","sha":"4a94deb9f743e07366a1cbbd8482c3ce8ce448f6","user":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"repo":{"id":133326681,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMjY2ODE=","name":"CodeU-2018-Group10","full_name":"flerdacodeu/CodeU-2018-Group10","owner":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flerdacodeu/CodeU-2018-Group10","description":null,"fork":false,"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10","forks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/forks","keys_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/teams","hooks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/hooks","issue_events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues/events{/number}","events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/events","assignees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/assignees{/user}","branches_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/branches{/branch}","tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/tags","blobs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/refs{/sha}","trees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/statuses/{sha}","languages_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/languages","stargazers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/stargazers","contributors_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/contributors","subscribers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/subscribers","subscription_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/subscription","commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/commits{/sha}","git_commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/commits{/sha}","comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/comments{/number}","issue_comment_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues/comments{/number}","contents_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/contents/{+path}","compare_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/merges","archive_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/downloads","issues_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues{/number}","pulls_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls{/number}","milestones_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/milestones{/number}","notifications_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/labels{/name}","releases_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/releases{/id}","deployments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/deployments","created_at":"2018-05-14T08:07:24Z","updated_at":"2018-06-14T18:21:00Z","pushed_at":"2018-06-24T15:27:48Z","git_url":"git://github.com/flerdacodeu/CodeU-2018-Group10.git","ssh_url":"[email protected]:flerdacodeu/CodeU-2018-Group10.git","clone_url":"https://github.com/flerdacodeu/CodeU-2018-Group10.git","svn_url":"https://github.com/flerdacodeu/CodeU-2018-Group10","homepage":null,"size":105,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"flerdacodeu:master","ref":"master","sha":"6045ac418117dd510893c11b4953759e5f32a2ad","user":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"repo":{"id":133326681,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMjY2ODE=","name":"CodeU-2018-Group10","full_name":"flerdacodeu/CodeU-2018-Group10","owner":{"login":"flerdacodeu","id":28591648,"node_id":"MDQ6VXNlcjI4NTkxNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/28591648?v=4","gravatar_id":"","url":"https://api.github.com/users/flerdacodeu","html_url":"https://github.com/flerdacodeu","followers_url":"https://api.github.com/users/flerdacodeu/followers","following_url":"https://api.github.com/users/flerdacodeu/following{/other_user}","gists_url":"https://api.github.com/users/flerdacodeu/gists{/gist_id}","starred_url":"https://api.github.com/users/flerdacodeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flerdacodeu/subscriptions","organizations_url":"https://api.github.com/users/flerdacodeu/orgs","repos_url":"https://api.github.com/users/flerdacodeu/repos","events_url":"https://api.github.com/users/flerdacodeu/events{/privacy}","received_events_url":"https://api.github.com/users/flerdacodeu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flerdacodeu/CodeU-2018-Group10","description":null,"fork":false,"url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10","forks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/forks","keys_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/teams","hooks_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/hooks","issue_events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues/events{/number}","events_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/events","assignees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/assignees{/user}","branches_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/branches{/branch}","tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/tags","blobs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/refs{/sha}","trees_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/statuses/{sha}","languages_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/languages","stargazers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/stargazers","contributors_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/contributors","subscribers_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/subscribers","subscription_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/subscription","commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/commits{/sha}","git_commits_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/git/commits{/sha}","comments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/comments{/number}","issue_comment_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues/comments{/number}","contents_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/contents/{+path}","compare_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/merges","archive_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/downloads","issues_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues{/number}","pulls_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls{/number}","milestones_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/milestones{/number}","notifications_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/labels{/name}","releases_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/releases{/id}","deployments_url":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/deployments","created_at":"2018-05-14T08:07:24Z","updated_at":"2018-06-14T18:21:00Z","pushed_at":"2018-06-24T15:27:48Z","git_url":"git://github.com/flerdacodeu/CodeU-2018-Group10.git","ssh_url":"[email protected]:flerdacodeu/CodeU-2018-Group10.git","clone_url":"https://github.com/flerdacodeu/CodeU-2018-Group10.git","svn_url":"https://github.com/flerdacodeu/CodeU-2018-Group10","homepage":null,"size":105,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/19"},"html":{"href":"https://github.com/flerdacodeu/CodeU-2018-Group10/pull/19"},"issue":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues/19"},"comments":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10/statuses/4a94deb9f743e07366a1cbbd8482c3ce8ce448f6"}},"author_association":"COLLABORATOR"}} | {
"id": 133326681,
"name": "flerdacodeu/CodeU-2018-Group10",
"url": "https://api.github.com/repos/flerdacodeu/CodeU-2018-Group10"
} | {
"id": 17531269,
"login": "uro98",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17531269?",
"url": "https://api.github.com/users/uro98"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-06-25T02:59:24 | 7870615394 | {"actor":{"display_login":"uro98"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/radare/radare2/pulls/comments/207704674","pull_request_review_id":143378509,"id":207704674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzcwNDY3NA==","diff_hunk":"@@ -442,7 +442,112 @@ R_API int r_line_hist_chop(const char *file, int limit) {\n \treturn 0;\n }\n \n+static void draw_selection_widget () {\n+\tRCons *cons = r_cons_singleton ();\n+\tRSelWidget *sel_widget = I.sel_widget;\n+\tint y, pos_y = cons->rows, pos_x = r_str_ansi_len (I.prompt);\n+\n+\tfor (y = 0; y < sel_widget->options_len; y++) {\n+\t\tsel_widget->w = R_MAX (sel_widget->w, strlen (sel_widget->options[y]));\n+\t}\n+\tsel_widget->w = R_MIN (sel_widget->w, R_SELWIDGET_MAXW);\n+\n+\tchar *background_color = cons->color ? \"\\x1b[40m\" : Color_INVERT; // XXX colors from palette\n+\tchar *selected_color = cons->color ? \"\\x1b[41m\" : Color_INVERT_RESET; // XXX colors from palette\n+\tbool scrollbar = sel_widget->options_len > R_SELWIDGET_MAXH;\n+\tint scrollbar_y = scrollbar\n+\t\t? (R_SELWIDGET_MAXH * (sel_widget->selection - sel_widget->scroll)) / sel_widget->options_len\n+\t\t: 0;\n+\tint scrollbar_l = scrollbar\n+\t\t? (R_SELWIDGET_MAXH * R_SELWIDGET_MAXH) / sel_widget->options_len\n+\t\t: 0;\n+\n+\tfor (y = 0; y < R_MIN (sel_widget->h, R_SELWIDGET_MAXH); y++) {\n+\t\tr_cons_gotoxy (pos_x + 1, pos_y - y - 1);\n+\t\tint scroll = R_MAX (0, sel_widget->selection - sel_widget->scroll);\n+\t\tchar *option = y < sel_widget->options_len ? sel_widget->options[y + scroll] : \"\";\n+\t\tr_cons_printf (\"%s\", sel_widget->selection == y + scroll ? selected_color : background_color);\n+\t\tr_cons_printf (\"%-*.*s\", sel_widget->w, sel_widget->w, option);\n+\t\tif (scrollbar) {\n+\t\t\tr_cons_printf (\"%s\", background_color);\n+\t\t\tr_cons_printf (\"%s\", R_BETWEEN(scrollbar_y, y, scrollbar_y + scrollbar_l) ? \"█\" : \" \");\n+\t\t}\n+\t}\n+\n+\tr_cons_gotoxy (pos_x + I.buffer.length, pos_y);\n+\tr_cons_printf (\"%s\", Color_RESET_BG);\n+\tr_cons_flush();\n+}\n+\n+static void selection_widget_up () {\n+\tRSelWidget *sel_widget = I.sel_widget;\n+\tif (sel_widget && sel_widget->selection < sel_widget->options_len - 1) {\n+\t\tsel_widget->selection++;\n+\t\tsel_widget->scroll = R_MIN (sel_widget->scroll + 1, R_SELWIDGET_MAXH - 1);\n+\t}\n+}\n+\n+static void selection_widget_down () {\n+\tRSelWidget *sel_widget = I.sel_widget;\n+\tif (sel_widget && sel_widget->selection > 0) {\n+\t\tsel_widget->selection--;\n+\t\tsel_widget->scroll = R_MAX (sel_widget->scroll - 1, 0);\n+\t}\n+}\n+\n+static void print_rline_task (void *core) {\n+\tr_cons_clear_line (0);\n+\tr_cons_printf (\"%s%s%s\", Color_RESET, I.prompt, I.buffer.data); \n+\tr_cons_flush ();\n+}\n+\n+static void selection_widget_erase () {\n+\tRSelWidget *sel_widget = I.sel_widget;\n+\tif (sel_widget) {\n+\t\tsel_widget->options_len = 0;\n+\t\tsel_widget->selection = -1;\n+\t\tdraw_selection_widget ();\n+\t\tR_FREE(I.sel_widget);\n+\t\tRCons *cons = r_cons_singleton ();\n+\t\tif (cons->event_resize && cons->event_data) {\n+\t\t\tcons->event_resize (cons->event_data);\n+\t\t\tcons->cb_task_oneshot (cons->user, print_rline_task, NULL);\n+\t\t}\n+\t}\n+}\n+\n+static void selection_widget_select () {\n+\tRSelWidget *sel_widget = I.sel_widget;\n+\tif (sel_widget && sel_widget->selection < sel_widget->options_len) {\n+\t\tstrncpy (I.buffer.data, sel_widget->options[sel_widget->selection], R_LINE_BUFSIZE - 1);","path":"libr/cons/dietline.c","position":81,"original_position":81,"commit_id":"3d8d3a7023a662712ff6feea226b22559fad6516","original_commit_id":"3d8d3a7023a662712ff6feea226b22559fad6516","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"body":"Strncpy and strlen? Thats innefficient","created_at":"2018-08-04T09:49:48Z","updated_at":"2018-08-04T09:50:42Z","html_url":"https://github.com/radare/radare2/pull/10912#discussion_r207704674","pull_request_url":"https://api.github.com/repos/radare/radare2/pulls/10912","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments/207704674"},"html":{"href":"https://github.com/radare/radare2/pull/10912#discussion_r207704674"},"pull_request":{"href":"https://api.github.com/repos/radare/radare2/pulls/10912"}}},"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/10912","id":206074258,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDc0MjU4","html_url":"https://github.com/radare/radare2/pull/10912","diff_url":"https://github.com/radare/radare2/pull/10912.diff","patch_url":"https://github.com/radare/radare2/pull/10912.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/10912","number":10912,"state":"open","locked":false,"title":"[WIP] Vim-like autocompletion in visual offset prompt","user":{"login":"cyanpencil","id":3428362,"node_id":"MDQ6VXNlcjM0MjgzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3428362?v=4","gravatar_id":"","url":"https://api.github.com/users/cyanpencil","html_url":"https://github.com/cyanpencil","followers_url":"https://api.github.com/users/cyanpencil/followers","following_url":"https://api.github.com/users/cyanpencil/following{/other_user}","gists_url":"https://api.github.com/users/cyanpencil/gists{/gist_id}","starred_url":"https://api.github.com/users/cyanpencil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyanpencil/subscriptions","organizations_url":"https://api.github.com/users/cyanpencil/orgs","repos_url":"https://api.github.com/users/cyanpencil/repos","events_url":"https://api.github.com/users/cyanpencil/events{/privacy}","received_events_url":"https://api.github.com/users/cyanpencil/received_events","type":"User","site_admin":false},"body":"This is my attempt to address issue #8476\r\n\r\nIt is still a proof of concept, since for now it only works in visual offset prompt. But it works everywhere you can call the offset prompt (in visual mode, in panels mode, and in graph mode).\r\n\r\nThe idea is to make it as general as possible, so it can also be used elsewhere. \r\n\r\nThe major change here is not only in the visual representation of autocompletion, but also the fact that this offers autocompletion as-you-type.\r\n\r\nHere's a gif of how it looks:\r\n\r\n\r\n\r\nThe keybindings are more or less equal to vim's: up/down arrow keys or Ctrl-n/Ctrl-p to move selection, Enter to select item. Tab to invoke the autocompletion window \r\n\r\n**Feedbacks and code reviews are more than welcome!** I tried to make the code as clean as possible and tried my best to avoid overly hackish things. But I believe it can still be improved.\r\n\r\nI'll also move all those functions in a separate file (for now they're just all crammed in dietline.c)","created_at":"2018-08-03T16:04:38Z","updated_at":"2018-08-04T09:50:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d85efcec6eb2117ad39de0c9681721c2297a3965","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/10912/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/10912/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/10912/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/3d8d3a7023a662712ff6feea226b22559fad6516","head":{"label":"cyanpencil:selection-widget","ref":"selection-widget","sha":"3d8d3a7023a662712ff6feea226b22559fad6516","user":{"login":"cyanpencil","id":3428362,"node_id":"MDQ6VXNlcjM0MjgzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3428362?v=4","gravatar_id":"","url":"https://api.github.com/users/cyanpencil","html_url":"https://github.com/cyanpencil","followers_url":"https://api.github.com/users/cyanpencil/followers","following_url":"https://api.github.com/users/cyanpencil/following{/other_user}","gists_url":"https://api.github.com/users/cyanpencil/gists{/gist_id}","starred_url":"https://api.github.com/users/cyanpencil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyanpencil/subscriptions","organizations_url":"https://api.github.com/users/cyanpencil/orgs","repos_url":"https://api.github.com/users/cyanpencil/repos","events_url":"https://api.github.com/users/cyanpencil/events{/privacy}","received_events_url":"https://api.github.com/users/cyanpencil/received_events","type":"User","site_admin":false},"repo":{"id":123910256,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5MTAyNTY=","name":"radare2","full_name":"cyanpencil/radare2","owner":{"login":"cyanpencil","id":3428362,"node_id":"MDQ6VXNlcjM0MjgzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3428362?v=4","gravatar_id":"","url":"https://api.github.com/users/cyanpencil","html_url":"https://github.com/cyanpencil","followers_url":"https://api.github.com/users/cyanpencil/followers","following_url":"https://api.github.com/users/cyanpencil/following{/other_user}","gists_url":"https://api.github.com/users/cyanpencil/gists{/gist_id}","starred_url":"https://api.github.com/users/cyanpencil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyanpencil/subscriptions","organizations_url":"https://api.github.com/users/cyanpencil/orgs","repos_url":"https://api.github.com/users/cyanpencil/repos","events_url":"https://api.github.com/users/cyanpencil/events{/privacy}","received_events_url":"https://api.github.com/users/cyanpencil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyanpencil/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":true,"url":"https://api.github.com/repos/cyanpencil/radare2","forks_url":"https://api.github.com/repos/cyanpencil/radare2/forks","keys_url":"https://api.github.com/repos/cyanpencil/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyanpencil/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyanpencil/radare2/teams","hooks_url":"https://api.github.com/repos/cyanpencil/radare2/hooks","issue_events_url":"https://api.github.com/repos/cyanpencil/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/cyanpencil/radare2/events","assignees_url":"https://api.github.com/repos/cyanpencil/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/cyanpencil/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/cyanpencil/radare2/tags","blobs_url":"https://api.github.com/repos/cyanpencil/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyanpencil/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyanpencil/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyanpencil/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyanpencil/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/cyanpencil/radare2/languages","stargazers_url":"https://api.github.com/repos/cyanpencil/radare2/stargazers","contributors_url":"https://api.github.com/repos/cyanpencil/radare2/contributors","subscribers_url":"https://api.github.com/repos/cyanpencil/radare2/subscribers","subscription_url":"https://api.github.com/repos/cyanpencil/radare2/subscription","commits_url":"https://api.github.com/repos/cyanpencil/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyanpencil/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyanpencil/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyanpencil/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyanpencil/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/cyanpencil/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyanpencil/radare2/merges","archive_url":"https://api.github.com/repos/cyanpencil/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyanpencil/radare2/downloads","issues_url":"https://api.github.com/repos/cyanpencil/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/cyanpencil/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/cyanpencil/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/cyanpencil/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyanpencil/radare2/labels{/name}","releases_url":"https://api.github.com/repos/cyanpencil/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/cyanpencil/radare2/deployments","created_at":"2018-03-05T11:32:06Z","updated_at":"2018-08-03T14:16:27Z","pushed_at":"2018-08-03T15:44:38Z","git_url":"git://github.com/cyanpencil/radare2.git","ssh_url":"[email protected]:cyanpencil/radare2.git","clone_url":"https://github.com/cyanpencil/radare2.git","svn_url":"https://github.com/cyanpencil/radare2","homepage":"http://www.radare.org/","size":87899,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"447116022e6b5218cec0bf957912e4aeda9ec4f4","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"node_id":"MDEwOlJlcG9zaXRvcnk0ODY5Mjk0","name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools security","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2018-08-04T08:17:01Z","pushed_at":"2018-08-04T06:59:17Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"[email protected]:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":87849,"stargazers_count":7898,"watchers_count":7898,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1549,"mirror_url":null,"archived":false,"open_issues_count":951,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1549,"open_issues":951,"watchers":7898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/10912"},"html":{"href":"https://github.com/radare/radare2/pull/10912"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/10912"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/10912/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/10912/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/10912/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/3d8d3a7023a662712ff6feea226b22559fad6516"}},"author_association":"COLLABORATOR"}} | {
"id": 4869294,
"name": "radare/radare2",
"url": "https://api.github.com/repos/radare/radare2"
} | {
"id": 917142,
"login": "radare",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/917142?",
"url": "https://api.github.com/users/radare"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-08-04T09:49:48 | 8066000947 | {"actor":{"display_login":"radare"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/comments/193566988","pull_request_review_id":126564865,"id":193566988,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzU2Njk4OA==","diff_hunk":"@@ -0,0 +1,183 @@\n+\n+const DomElementActions = class {\n+ constructor() {\n+ this.defaultTab;\n+ this.lastElementClicked;\n+ this.defaultNavItem;\n+ this.changeClassValue = this.changeClassValue.bind(this);\n+ // this._changeClassValue = this._changeClassValue;\n+ }\n+ // add eventlistener to elements\n+ newEvent (elementObject, eventType, callBack, callBackArgument) {\n+ elementObject.addEventListener(eventType, function(event) {\n+ event.preventDefault(); \n+ if(callBackArgument === undefined) {\n+ callBack();\n+ } else {\n+ callBack(callBackArgument);\n+ }\n+ },\n+ false );\n+ } // end newEvent\n+\n+ // change the attribute of elements\n+ changeAttribute (eleObject, attrToChange, newAttr, removeAttr) {\n+ const eleAttr = eleObject.getAttribute(attrToChange);\n+ if (eleAttr === null || eleAttr !== newAttr) \t{\n+ //set the attribute and the image become large\n+ eleObject.setAttribute(attrToChange, newAttr);\n+ } else if (eleAttr === newAttr && removeAttr === 'yes') {\n+ eleObject.removeAttribute(attrToChange);\n+ } else if (eleAttr === newAttr && removeAttr === 'no') {\n+ //no action taken\n+ } else if(eleAttr === newAttr && (removeAttr !== 'yes' || removeAttr !== 'no' || removeAttr !== \"undefined\")){\n+ eleObject.setAttribute(attrToChange, removeAttr);\n+ } \n+ }\t\t//end changeClass\n+\n+ // change the attribute of elements\n+ changeClassValue (eleObject, valueToChange, replacement) {\n+ let eleClassValue = eleObject.getAttribute('class');\n+ eleClassValue = eleClassValue.replace(valueToChange, replacement);\n+ eleObject.setAttribute('class', eleClassValue);\n+ }\t\t//end changeClassValue\n+\n+ // display and close vertical nav button\n+ showNavigation(toggleBtn) {\n+ const verticalNav = document.getElementById('vertical-nav-bar');\n+ const classValue = verticalNav.getAttribute('class');\n+ if(classValue.indexOf('hide-item') >= 0) {\n+ this.changeClassValue (verticalNav, 'hide-item', 'show-item');\n+ } else if(classValue.indexOf('show-item') >= 0) {\n+ this.changeClassValue (verticalNav, 'show-item', 'hide-item');\n+ }\n+ }\n+\n+ tabNavigation(elem) {\n+ // deactive current activeNav\n+ const activeNav = document.getElementsByClassName('active')[0];\n+ this.changeClassValue (activeNav, 'active', 'inactive');\n+\n+ // activate elem \n+ this.changeClassValue (elem, 'inactive', 'active');\n+ \n+ // display tab elements\n+ const anchorPos = elem.href.indexOf('#');\n+ // value in href = id of the tab section\n+ const href = elem.href.substring(anchorPos + 1);\n+ const tabSection = document.getElementById(href);\n+ // const classValue = tabSection.getAttribute('class');\n+ if((!this.lastElementClicked && href !== defaultNavItem)) {\n+ this.changeClassValue (tabSection, 'hide-item', 'show-item');\n+ if(document.getElementById('view-requests')) {\n+ defaultTab = document.getElementById('view-requests');\n+ this.changeClassValue (defaultTab, 'show-item', 'hide-item')\n+ }\n+ if(document.getElementById('request-repair')) {\n+ defaultTab = document.getElementById('request-repair');\n+ this.changeClassValue (defaultTab, 'show-item', 'hide-item')\n+ }\n+ } else if(this.lastElementClicked && href !== this.lastElementClicked) {\n+ this.changeClassValue (tabSection, 'hide-item', 'show-item');\n+ const oldTabSection = document.getElementById(this.lastElementClicked);\n+ this.changeClassValue (oldTabSection, 'show-item', 'hide-item');\n+ } else {\n+ this.changeClassValue (tabSection, 'hide-item', 'show-item');\n+ }\n+ this.lastElementClicked = href;\n+ }\n+\n+ showConsoleModal (message) {\n+ if(document.getElementById('console-modal')) {\n+ const consoleModal = document.getElementById('console-modal');\n+ const messageBox = document.getElementById('message-box');\n+ messageBox.innerHTML = message;\n+ this.changeClassValue(consoleModal, 'hide-item', 'show-item');\n+ }\n+ }\n+ \n+ closeConsoleModal (self) {\n+ // self = the instance of this class\n+ if(document.getElementById('console-modal')) {\n+ const consoleModal = document.getElementById('console-modal');\n+ self.changeClassValue(consoleModal, 'show-item', 'hide-item');\n+ }\n+ }\n+}\n+\n+const StorageHandler = class {\n+ getDataFromStore (key) {\n+ if (typeof key !== 'string') {\n+ return `typeError: expecting a string but got ${typeof key}`;\n+ } \n+ if (localStorage.getItem(key)) {\n+ let data = localStorage.getItem(key);\n+ data = JSON.parse(data);\n+ return data;\n+ } else {\n+ return 'no user data stored in local storage';\n+ }\n+ }\n+ \n+ // store data to localStorage\n+ storeData(dataToStore, keyString) {\n+ if (typeof dataToStore !== 'object') {\n+ return `typeError: expecting an object but got ${typeof dataToStore}`;\n+ }\n+ if (typeof keyString !== 'string') {\n+ return `typeError: expecting an string but got ${typeof keyString}`;\n+ }\n+ if (!localStorage.getItem(keyString)) {\n+ const stringifyData = JSON.stringify(dataToStore);\n+ localStorage.setItem(keyString, stringifyData);\n+ return 'data stored';\n+ }\n+ }\n+ \n+ redirectUser(userData) {\n+ if (typeof userData !== 'object') {\n+ return `typeError: expecting an object but got ${typeof userData}`;\n+ }\n+ if (userData.isAdmin === true || userData.isAdmin === 'on') {\n+ window.location.href= '/admin/dashboard.html';\n+ } else if (userData.isAdmin === false) {\n+ window.location.href = '/users/dashboard.html';\n+ } \n+ }\n+}\n+\n+const RequestHandler = class {\n+ createRequest(ele) {","path":"client/js/utilities.js","position":150,"original_position":150,"commit_id":"1ea74d0435a12095d8bf9eb48239d1be39d74a6e","original_commit_id":"1ea74d0435a12095d8bf9eb48239d1be39d74a6e","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'ele' is defined but never used no-unused-vars","created_at":"2018-06-06T21:36:26Z","updated_at":"2018-06-06T21:36:27Z","html_url":"https://github.com/tutugodfrey/maintenance-tracker/pull/49#discussion_r193566988","pull_request_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/49","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/comments/193566988"},"html":{"href":"https://github.com/tutugodfrey/maintenance-tracker/pull/49#discussion_r193566988"},"pull_request":{"href":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/49","id":193147645,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTQ3NjQ1","html_url":"https://github.com/tutugodfrey/maintenance-tracker/pull/49","diff_url":"https://github.com/tutugodfrey/maintenance-tracker/pull/49.diff","patch_url":"https://github.com/tutugodfrey/maintenance-tracker/pull/49.patch","issue_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues/49","number":49,"state":"open","locked":false,"title":"feat(user signin client): add functionality for user to signin","user":{"login":"tutugodfrey","id":30448913,"node_id":"MDQ6VXNlcjMwNDQ4OTEz","avatar_url":"https://avatars1.githubusercontent.com/u/30448913?v=4","gravatar_id":"","url":"https://api.github.com/users/tutugodfrey","html_url":"https://github.com/tutugodfrey","followers_url":"https://api.github.com/users/tutugodfrey/followers","following_url":"https://api.github.com/users/tutugodfrey/following{/other_user}","gists_url":"https://api.github.com/users/tutugodfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/tutugodfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tutugodfrey/subscriptions","organizations_url":"https://api.github.com/users/tutugodfrey/orgs","repos_url":"https://api.github.com/users/tutugodfrey/repos","events_url":"https://api.github.com/users/tutugodfrey/events{/privacy}","received_events_url":"https://api.github.com/users/tutugodfrey/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nallow users to signin from client \r\n\r\n#### Description of Task to be completed?\r\nusers should be able to signin from the home page of the application\r\nusers should be able to signin from the signin page\r\nusers should be redirected to their dashboard upon signin\r\nuser receive console modal if for any reason signin fails\r\n\r\n#### How should this be manually tested?\r\ndownload/ clone the application and setup your development environment including db creation\r\naccess the application on http://localhost:8080\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n #157970598","created_at":"2018-06-06T21:36:13Z","updated_at":"2018-06-06T21:36:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1b31b98feada271fef59aff65f0d1692e775d1e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/49/commits","review_comments_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/49/comments","review_comment_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues/49/comments","statuses_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/statuses/1ea74d0435a12095d8bf9eb48239d1be39d74a6e","head":{"label":"tutugodfrey:ft-user-signin-157970598","ref":"ft-user-signin-157970598","sha":"1ea74d0435a12095d8bf9eb48239d1be39d74a6e","user":{"login":"tutugodfrey","id":30448913,"node_id":"MDQ6VXNlcjMwNDQ4OTEz","avatar_url":"https://avatars1.githubusercontent.com/u/30448913?v=4","gravatar_id":"","url":"https://api.github.com/users/tutugodfrey","html_url":"https://github.com/tutugodfrey","followers_url":"https://api.github.com/users/tutugodfrey/followers","following_url":"https://api.github.com/users/tutugodfrey/following{/other_user}","gists_url":"https://api.github.com/users/tutugodfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/tutugodfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tutugodfrey/subscriptions","organizations_url":"https://api.github.com/users/tutugodfrey/orgs","repos_url":"https://api.github.com/users/tutugodfrey/repos","events_url":"https://api.github.com/users/tutugodfrey/events{/privacy}","received_events_url":"https://api.github.com/users/tutugodfrey/received_events","type":"User","site_admin":false},"repo":{"id":132527472,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1Mjc0NzI=","name":"maintenance-tracker","full_name":"tutugodfrey/maintenance-tracker","owner":{"login":"tutugodfrey","id":30448913,"node_id":"MDQ6VXNlcjMwNDQ4OTEz","avatar_url":"https://avatars1.githubusercontent.com/u/30448913?v=4","gravatar_id":"","url":"https://api.github.com/users/tutugodfrey","html_url":"https://github.com/tutugodfrey","followers_url":"https://api.github.com/users/tutugodfrey/followers","following_url":"https://api.github.com/users/tutugodfrey/following{/other_user}","gists_url":"https://api.github.com/users/tutugodfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/tutugodfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tutugodfrey/subscriptions","organizations_url":"https://api.github.com/users/tutugodfrey/orgs","repos_url":"https://api.github.com/users/tutugodfrey/repos","events_url":"https://api.github.com/users/tutugodfrey/events{/privacy}","received_events_url":"https://api.github.com/users/tutugodfrey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tutugodfrey/maintenance-tracker","description":"Maintenance tracker is a platform that allows users to reach out to maintenance department for repairs and to track the progress of the process","fork":false,"url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker","forks_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/forks","keys_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/teams","hooks_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/hooks","issue_events_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/events","assignees_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/tags","blobs_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/languages","stargazers_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/stargazers","contributors_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/contributors","subscribers_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/subscribers","subscription_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/subscription","commits_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/merges","archive_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/downloads","issues_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/labels{/name}","releases_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/deployments","created_at":"2018-05-07T23:31:03Z","updated_at":"2018-06-05T11:50:22Z","pushed_at":"2018-06-06T21:36:14Z","git_url":"git://github.com/tutugodfrey/maintenance-tracker.git","ssh_url":"[email protected]:tutugodfrey/maintenance-tracker.git","clone_url":"https://github.com/tutugodfrey/maintenance-tracker.git","svn_url":"https://github.com/tutugodfrey/maintenance-tracker","homepage":null,"size":1626,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"tutugodfrey:develop","ref":"develop","sha":"72be1d922f0d93e1d3526e227641a34ef02fd501","user":{"login":"tutugodfrey","id":30448913,"node_id":"MDQ6VXNlcjMwNDQ4OTEz","avatar_url":"https://avatars1.githubusercontent.com/u/30448913?v=4","gravatar_id":"","url":"https://api.github.com/users/tutugodfrey","html_url":"https://github.com/tutugodfrey","followers_url":"https://api.github.com/users/tutugodfrey/followers","following_url":"https://api.github.com/users/tutugodfrey/following{/other_user}","gists_url":"https://api.github.com/users/tutugodfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/tutugodfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tutugodfrey/subscriptions","organizations_url":"https://api.github.com/users/tutugodfrey/orgs","repos_url":"https://api.github.com/users/tutugodfrey/repos","events_url":"https://api.github.com/users/tutugodfrey/events{/privacy}","received_events_url":"https://api.github.com/users/tutugodfrey/received_events","type":"User","site_admin":false},"repo":{"id":132527472,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1Mjc0NzI=","name":"maintenance-tracker","full_name":"tutugodfrey/maintenance-tracker","owner":{"login":"tutugodfrey","id":30448913,"node_id":"MDQ6VXNlcjMwNDQ4OTEz","avatar_url":"https://avatars1.githubusercontent.com/u/30448913?v=4","gravatar_id":"","url":"https://api.github.com/users/tutugodfrey","html_url":"https://github.com/tutugodfrey","followers_url":"https://api.github.com/users/tutugodfrey/followers","following_url":"https://api.github.com/users/tutugodfrey/following{/other_user}","gists_url":"https://api.github.com/users/tutugodfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/tutugodfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tutugodfrey/subscriptions","organizations_url":"https://api.github.com/users/tutugodfrey/orgs","repos_url":"https://api.github.com/users/tutugodfrey/repos","events_url":"https://api.github.com/users/tutugodfrey/events{/privacy}","received_events_url":"https://api.github.com/users/tutugodfrey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tutugodfrey/maintenance-tracker","description":"Maintenance tracker is a platform that allows users to reach out to maintenance department for repairs and to track the progress of the process","fork":false,"url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker","forks_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/forks","keys_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/teams","hooks_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/hooks","issue_events_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/events","assignees_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/tags","blobs_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/languages","stargazers_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/stargazers","contributors_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/contributors","subscribers_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/subscribers","subscription_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/subscription","commits_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/merges","archive_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/downloads","issues_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/labels{/name}","releases_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/deployments","created_at":"2018-05-07T23:31:03Z","updated_at":"2018-06-05T11:50:22Z","pushed_at":"2018-06-06T21:36:14Z","git_url":"git://github.com/tutugodfrey/maintenance-tracker.git","ssh_url":"[email protected]:tutugodfrey/maintenance-tracker.git","clone_url":"https://github.com/tutugodfrey/maintenance-tracker.git","svn_url":"https://github.com/tutugodfrey/maintenance-tracker","homepage":null,"size":1626,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/49"},"html":{"href":"https://github.com/tutugodfrey/maintenance-tracker/pull/49"},"issue":{"href":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues/49"},"comments":{"href":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/tutugodfrey/maintenance-tracker/statuses/1ea74d0435a12095d8bf9eb48239d1be39d74a6e"}},"author_association":"OWNER"}} | {
"id": 132527472,
"name": "tutugodfrey/maintenance-tracker",
"url": "https://api.github.com/repos/tutugodfrey/maintenance-tracker"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-06-06T21:36:26 | 7787221181 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/snow1eo/PT_internship/pulls/comments/186133181","pull_request_review_id":117584766,"id":186133181,"diff_hunk":"@@ -0,0 +1,74 @@\n+import importlib\n+from time import sleep\n+\n+import docker\n+\n+from modules.statuses import Status\n+from modules.transports import get_transport\n+import scripts # for Windows\n+\n+# Оставлю так, не нравятся мне _ в файлах\n+test0 = importlib.import_module('.000_test_file_exist', package='scripts')\n+test1 = importlib.import_module('.001_test_db_exist', package='scripts')\n+\n+\n+# Тут такая беда, mariadb не успевает от одного теста \n+# оправиться и начинает следующий, где соединения падают\n+# Может, имеет смысл сделать несколько попыток подключения\n+# с таймаутом вместо этого костыля?\n+def teardown_module():\n+ sleep(3)\n+\n+\n+def test_000_file_exist_1():\n+ with get_transport('SSH') as ssh:\n+ ssh.execute('touch /testfile')\n+ assert test0.main() == Status.COMPLIANT\n+\n+\n+def test_000_file_exist_2():\n+ with get_transport('SSH') as ssh:\n+ try:\n+ ssh.execute('rm -f /testfile')\n+ except Exception:\n+ pass\n+ assert test0.main() == Status.NOT_COMPLIANT\n+\n+\n+def test_000_file_exist_3():\n+ status = None # just for situation when container didn't start\n+ containers = docker.from_env().containers.list()\n+ for container in containers:\n+ if container.name == 'cont_ubuntu_sshd':\n+ container.stop()\n+ status = test0.main()\n+ container.start()\n+ assert status == Status.NOT_APPLICABLE\n+\n+\n+def test_001_database_exist_1():\n+ with get_transport('MySQL') as sql:\n+ sql.sqlexec('CREATE DATABASE IF NOT EXISTS test_db')\n+ sql.close()\n+ sql.connect('test_db')\n+ sql.sqlexec(\"\"\"CREATE TABLE IF NOT EXISTS test_table (\n+ name VARCHAR(20), owner VARCHAR(20))\"\"\")\n+ sql.sqlexec(\"INSERT INTO test_table VALUES ('Dolly', 'Me')\")\n+ assert test1.main() == Status.COMPLIANT\n+\n+\n+def test_001_database_exist_2():\n+ with get_transport('MySQL') as sql:\n+ sql.sqlexec('DROP DATABASE IF EXISTS test_db')\n+ assert test1.main() == Status.NOT_COMPLIANT\n+\n+\n+def test_001_database_exist_3():\n+ status = None # just for situation when container didn't start\n+ containers = docker.from_env().containers.list()\n+ for container in containers:\n+ if container.name == 'mariadb':\n+ container.stop()\n+ status = test1.main()","path":"tests/test_scripts.py","position":72,"original_position":72,"commit_id":"ccde06eb6c3a54ba30cb52569c5b74640d44d1e8","original_commit_id":"67bff0dd6ba220a18546989b4ea29671626dbf60","user":{"login":"PTinternship","id":38433278,"avatar_url":"https://avatars1.githubusercontent.com/u/38433278?v=4","gravatar_id":"","url":"https://api.github.com/users/PTinternship","html_url":"https://github.com/PTinternship","followers_url":"https://api.github.com/users/PTinternship/followers","following_url":"https://api.github.com/users/PTinternship/following{/other_user}","gists_url":"https://api.github.com/users/PTinternship/gists{/gist_id}","starred_url":"https://api.github.com/users/PTinternship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PTinternship/subscriptions","organizations_url":"https://api.github.com/users/PTinternship/orgs","repos_url":"https://api.github.com/users/PTinternship/repos","events_url":"https://api.github.com/users/PTinternship/events{/privacy}","received_events_url":"https://api.github.com/users/PTinternship/received_events","type":"User","site_admin":false},"body":"Если контейнер не будет запущен, то условие не отработает. Нужно пересмотреть логику этого теста.\r\nМожет просто создавать транспорт с неправильными настройками? \r\nПосмотри [здесь](https://docs.pytest.org/en/latest/monkeypatch.html)","created_at":"2018-05-04T16:20:15Z","updated_at":"2018-05-04T16:27:40Z","html_url":"https://github.com/snow1eo/PT_internship/pull/1#discussion_r186133181","pull_request_url":"https://api.github.com/repos/snow1eo/PT_internship/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/snow1eo/PT_internship/pulls/comments/186133181"},"html":{"href":"https://github.com/snow1eo/PT_internship/pull/1#discussion_r186133181"},"pull_request":{"href":"https://api.github.com/repos/snow1eo/PT_internship/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/snow1eo/PT_internship/pulls/1","id":184560103,"html_url":"https://github.com/snow1eo/PT_internship/pull/1","diff_url":"https://github.com/snow1eo/PT_internship/pull/1.diff","patch_url":"https://github.com/snow1eo/PT_internship/pull/1.patch","issue_url":"https://api.github.com/repos/snow1eo/PT_internship/issues/1","number":1,"state":"open","locked":false,"title":"hw 2 done","user":{"login":"snow1eo","id":38433226,"avatar_url":"https://avatars3.githubusercontent.com/u/38433226?v=4","gravatar_id":"","url":"https://api.github.com/users/snow1eo","html_url":"https://github.com/snow1eo","followers_url":"https://api.github.com/users/snow1eo/followers","following_url":"https://api.github.com/users/snow1eo/following{/other_user}","gists_url":"https://api.github.com/users/snow1eo/gists{/gist_id}","starred_url":"https://api.github.com/users/snow1eo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snow1eo/subscriptions","organizations_url":"https://api.github.com/users/snow1eo/orgs","repos_url":"https://api.github.com/users/snow1eo/repos","events_url":"https://api.github.com/users/snow1eo/events{/privacy}","received_events_url":"https://api.github.com/users/snow1eo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-27T08:48:04Z","updated_at":"2018-05-04T16:27:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08a9ffb6e579bdc703968d0274d291ee05771e10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snow1eo/PT_internship/pulls/1/commits","review_comments_url":"https://api.github.com/repos/snow1eo/PT_internship/pulls/1/comments","review_comment_url":"https://api.github.com/repos/snow1eo/PT_internship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snow1eo/PT_internship/issues/1/comments","statuses_url":"https://api.github.com/repos/snow1eo/PT_internship/statuses/ccde06eb6c3a54ba30cb52569c5b74640d44d1e8","head":{"label":"snow1eo:develop","ref":"develop","sha":"ccde06eb6c3a54ba30cb52569c5b74640d44d1e8","user":{"login":"snow1eo","id":38433226,"avatar_url":"https://avatars3.githubusercontent.com/u/38433226?v=4","gravatar_id":"","url":"https://api.github.com/users/snow1eo","html_url":"https://github.com/snow1eo","followers_url":"https://api.github.com/users/snow1eo/followers","following_url":"https://api.github.com/users/snow1eo/following{/other_user}","gists_url":"https://api.github.com/users/snow1eo/gists{/gist_id}","starred_url":"https://api.github.com/users/snow1eo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snow1eo/subscriptions","organizations_url":"https://api.github.com/users/snow1eo/orgs","repos_url":"https://api.github.com/users/snow1eo/repos","events_url":"https://api.github.com/users/snow1eo/events{/privacy}","received_events_url":"https://api.github.com/users/snow1eo/received_events","type":"User","site_admin":false},"repo":{"id":131268854,"name":"PT_internship","full_name":"snow1eo/PT_internship","owner":{"login":"snow1eo","id":38433226,"avatar_url":"https://avatars3.githubusercontent.com/u/38433226?v=4","gravatar_id":"","url":"https://api.github.com/users/snow1eo","html_url":"https://github.com/snow1eo","followers_url":"https://api.github.com/users/snow1eo/followers","following_url":"https://api.github.com/users/snow1eo/following{/other_user}","gists_url":"https://api.github.com/users/snow1eo/gists{/gist_id}","starred_url":"https://api.github.com/users/snow1eo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snow1eo/subscriptions","organizations_url":"https://api.github.com/users/snow1eo/orgs","repos_url":"https://api.github.com/users/snow1eo/repos","events_url":"https://api.github.com/users/snow1eo/events{/privacy}","received_events_url":"https://api.github.com/users/snow1eo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snow1eo/PT_internship","description":"Positive Technologies open internship 2018","fork":false,"url":"https://api.github.com/repos/snow1eo/PT_internship","forks_url":"https://api.github.com/repos/snow1eo/PT_internship/forks","keys_url":"https://api.github.com/repos/snow1eo/PT_internship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snow1eo/PT_internship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snow1eo/PT_internship/teams","hooks_url":"https://api.github.com/repos/snow1eo/PT_internship/hooks","issue_events_url":"https://api.github.com/repos/snow1eo/PT_internship/issues/events{/number}","events_url":"https://api.github.com/repos/snow1eo/PT_internship/events","assignees_url":"https://api.github.com/repos/snow1eo/PT_internship/assignees{/user}","branches_url":"https://api.github.com/repos/snow1eo/PT_internship/branches{/branch}","tags_url":"https://api.github.com/repos/snow1eo/PT_internship/tags","blobs_url":"https://api.github.com/repos/snow1eo/PT_internship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snow1eo/PT_internship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snow1eo/PT_internship/git/refs{/sha}","trees_url":"https://api.github.com/repos/snow1eo/PT_internship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snow1eo/PT_internship/statuses/{sha}","languages_url":"https://api.github.com/repos/snow1eo/PT_internship/languages","stargazers_url":"https://api.github.com/repos/snow1eo/PT_internship/stargazers","contributors_url":"https://api.github.com/repos/snow1eo/PT_internship/contributors","subscribers_url":"https://api.github.com/repos/snow1eo/PT_internship/subscribers","subscription_url":"https://api.github.com/repos/snow1eo/PT_internship/subscription","commits_url":"https://api.github.com/repos/snow1eo/PT_internship/commits{/sha}","git_commits_url":"https://api.github.com/repos/snow1eo/PT_internship/git/commits{/sha}","comments_url":"https://api.github.com/repos/snow1eo/PT_internship/comments{/number}","issue_comment_url":"https://api.github.com/repos/snow1eo/PT_internship/issues/comments{/number}","contents_url":"https://api.github.com/repos/snow1eo/PT_internship/contents/{+path}","compare_url":"https://api.github.com/repos/snow1eo/PT_internship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snow1eo/PT_internship/merges","archive_url":"https://api.github.com/repos/snow1eo/PT_internship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snow1eo/PT_internship/downloads","issues_url":"https://api.github.com/repos/snow1eo/PT_internship/issues{/number}","pulls_url":"https://api.github.com/repos/snow1eo/PT_internship/pulls{/number}","milestones_url":"https://api.github.com/repos/snow1eo/PT_internship/milestones{/number}","notifications_url":"https://api.github.com/repos/snow1eo/PT_internship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snow1eo/PT_internship/labels{/name}","releases_url":"https://api.github.com/repos/snow1eo/PT_internship/releases{/id}","deployments_url":"https://api.github.com/repos/snow1eo/PT_internship/deployments","created_at":"2018-04-27T08:30:44Z","updated_at":"2018-04-27T08:30:46Z","pushed_at":"2018-05-04T15:59:43Z","git_url":"git://github.com/snow1eo/PT_internship.git","ssh_url":"[email protected]:snow1eo/PT_internship.git","clone_url":"https://github.com/snow1eo/PT_internship.git","svn_url":"https://github.com/snow1eo/PT_internship","homepage":null,"size":136,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"snow1eo:master","ref":"master","sha":"235dc66ab21894ca8b1d7457a3e35e58c0cd272f","user":{"login":"snow1eo","id":38433226,"avatar_url":"https://avatars3.githubusercontent.com/u/38433226?v=4","gravatar_id":"","url":"https://api.github.com/users/snow1eo","html_url":"https://github.com/snow1eo","followers_url":"https://api.github.com/users/snow1eo/followers","following_url":"https://api.github.com/users/snow1eo/following{/other_user}","gists_url":"https://api.github.com/users/snow1eo/gists{/gist_id}","starred_url":"https://api.github.com/users/snow1eo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snow1eo/subscriptions","organizations_url":"https://api.github.com/users/snow1eo/orgs","repos_url":"https://api.github.com/users/snow1eo/repos","events_url":"https://api.github.com/users/snow1eo/events{/privacy}","received_events_url":"https://api.github.com/users/snow1eo/received_events","type":"User","site_admin":false},"repo":{"id":131268854,"name":"PT_internship","full_name":"snow1eo/PT_internship","owner":{"login":"snow1eo","id":38433226,"avatar_url":"https://avatars3.githubusercontent.com/u/38433226?v=4","gravatar_id":"","url":"https://api.github.com/users/snow1eo","html_url":"https://github.com/snow1eo","followers_url":"https://api.github.com/users/snow1eo/followers","following_url":"https://api.github.com/users/snow1eo/following{/other_user}","gists_url":"https://api.github.com/users/snow1eo/gists{/gist_id}","starred_url":"https://api.github.com/users/snow1eo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snow1eo/subscriptions","organizations_url":"https://api.github.com/users/snow1eo/orgs","repos_url":"https://api.github.com/users/snow1eo/repos","events_url":"https://api.github.com/users/snow1eo/events{/privacy}","received_events_url":"https://api.github.com/users/snow1eo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snow1eo/PT_internship","description":"Positive Technologies open internship 2018","fork":false,"url":"https://api.github.com/repos/snow1eo/PT_internship","forks_url":"https://api.github.com/repos/snow1eo/PT_internship/forks","keys_url":"https://api.github.com/repos/snow1eo/PT_internship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snow1eo/PT_internship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snow1eo/PT_internship/teams","hooks_url":"https://api.github.com/repos/snow1eo/PT_internship/hooks","issue_events_url":"https://api.github.com/repos/snow1eo/PT_internship/issues/events{/number}","events_url":"https://api.github.com/repos/snow1eo/PT_internship/events","assignees_url":"https://api.github.com/repos/snow1eo/PT_internship/assignees{/user}","branches_url":"https://api.github.com/repos/snow1eo/PT_internship/branches{/branch}","tags_url":"https://api.github.com/repos/snow1eo/PT_internship/tags","blobs_url":"https://api.github.com/repos/snow1eo/PT_internship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snow1eo/PT_internship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snow1eo/PT_internship/git/refs{/sha}","trees_url":"https://api.github.com/repos/snow1eo/PT_internship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snow1eo/PT_internship/statuses/{sha}","languages_url":"https://api.github.com/repos/snow1eo/PT_internship/languages","stargazers_url":"https://api.github.com/repos/snow1eo/PT_internship/stargazers","contributors_url":"https://api.github.com/repos/snow1eo/PT_internship/contributors","subscribers_url":"https://api.github.com/repos/snow1eo/PT_internship/subscribers","subscription_url":"https://api.github.com/repos/snow1eo/PT_internship/subscription","commits_url":"https://api.github.com/repos/snow1eo/PT_internship/commits{/sha}","git_commits_url":"https://api.github.com/repos/snow1eo/PT_internship/git/commits{/sha}","comments_url":"https://api.github.com/repos/snow1eo/PT_internship/comments{/number}","issue_comment_url":"https://api.github.com/repos/snow1eo/PT_internship/issues/comments{/number}","contents_url":"https://api.github.com/repos/snow1eo/PT_internship/contents/{+path}","compare_url":"https://api.github.com/repos/snow1eo/PT_internship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snow1eo/PT_internship/merges","archive_url":"https://api.github.com/repos/snow1eo/PT_internship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snow1eo/PT_internship/downloads","issues_url":"https://api.github.com/repos/snow1eo/PT_internship/issues{/number}","pulls_url":"https://api.github.com/repos/snow1eo/PT_internship/pulls{/number}","milestones_url":"https://api.github.com/repos/snow1eo/PT_internship/milestones{/number}","notifications_url":"https://api.github.com/repos/snow1eo/PT_internship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snow1eo/PT_internship/labels{/name}","releases_url":"https://api.github.com/repos/snow1eo/PT_internship/releases{/id}","deployments_url":"https://api.github.com/repos/snow1eo/PT_internship/deployments","created_at":"2018-04-27T08:30:44Z","updated_at":"2018-04-27T08:30:46Z","pushed_at":"2018-05-04T15:59:43Z","git_url":"git://github.com/snow1eo/PT_internship.git","ssh_url":"[email protected]:snow1eo/PT_internship.git","clone_url":"https://github.com/snow1eo/PT_internship.git","svn_url":"https://github.com/snow1eo/PT_internship","homepage":null,"size":136,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snow1eo/PT_internship/pulls/1"},"html":{"href":"https://github.com/snow1eo/PT_internship/pull/1"},"issue":{"href":"https://api.github.com/repos/snow1eo/PT_internship/issues/1"},"comments":{"href":"https://api.github.com/repos/snow1eo/PT_internship/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/snow1eo/PT_internship/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/snow1eo/PT_internship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snow1eo/PT_internship/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/snow1eo/PT_internship/statuses/ccde06eb6c3a54ba30cb52569c5b74640d44d1e8"}},"author_association":"OWNER"}} | {
"id": 131268854,
"name": "snow1eo/PT_internship",
"url": "https://api.github.com/repos/snow1eo/PT_internship"
} | {
"id": 38433278,
"login": "PTinternship",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38433278?",
"url": "https://api.github.com/users/PTinternship"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-05-04T16:20:15 | 7629555137 | {"actor":{"display_login":"PTinternship"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jjaniec/21sh/pulls/comments/223028517","pull_request_review_id":162063362,"id":223028517,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzAyODUxNw==","diff_hunk":"@@ -86,13 +86,14 @@ char\t\t\t**parse_options(int *ac, char **av, \\\n \tif (char_opt_index && !(i = 0))\n \t\twhile (i != CHAR_OPT_INDEX_SIZE)\n \t\t\tchar_opt_index[i++] = NULL;\n-\twhile ((*ac)-- > 1 && *ptr && **ptr == '-' && ft_strcmp(*ptr, \"--\"))\n+\twhile ((!ac || (*ac)-- > 1) && *ptr && **ptr == '-' && ft_strcmp(*ptr, \"--\"))\n \t{\n \t\tif ((*ptr)[1] == '-')\n \t\t\ttoggle_str_opt(opt_list, (*ptr) + 1, char_opt_index);\n \t\telse\n \t\t\ttoggle_char_opts(opt_list, (*ptr) + 1, char_opt_index);\n-\t\tptr = (*ac != 0) ? (&ptr[1]) : (NULL);\n+\t\tptr = ((!ac || *ac != 0)) ? (&ptr[1]) : (NULL);","path":"srcs/parse_options.c","position":25,"original_position":25,"commit_id":"534ec1edc99c1f014f9f16d74346d4ad7d8d8990","original_commit_id":"534ec1edc99c1f014f9f16d74346d4ad7d8d8990","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":" Code Smell: Remove these useless parentheses. ([c:S1110](https://sonarcloud.io/organizations/jjaniec-github/rules#rule_key=c%3AS1110))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=jjaniec_21sh&pullRequest=36&issues=AWZAmJ-PnzfF1D4Jy8Zd&open=AWZAmJ-PnzfF1D4Jy8Zd)\n\n[ISSUE_KEY]: AWZAmJ-PnzfF1D4Jy8Zd","created_at":"2018-10-05T14:34:24Z","updated_at":"2018-10-05T14:34:27Z","html_url":"https://github.com/jjaniec/21sh/pull/36#discussion_r223028517","pull_request_url":"https://api.github.com/repos/jjaniec/21sh/pulls/36","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/comments/223028517"},"html":{"href":"https://github.com/jjaniec/21sh/pull/36#discussion_r223028517"},"pull_request":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/jjaniec/21sh/pulls/36","id":220090303,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDkwMzAz","html_url":"https://github.com/jjaniec/21sh/pull/36","diff_url":"https://github.com/jjaniec/21sh/pull/36.diff","patch_url":"https://github.com/jjaniec/21sh/pull/36.patch","issue_url":"https://api.github.com/repos/jjaniec/21sh/issues/36","number":36,"state":"open","locked":false,"title":"Env handling & local/internal variables","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"body":"- Remake environnement handling w/ a linked list\r\n- Add support for local & internal variables\r\n- Remake cd, env (w/o command execution yet), (un)setenv (not posix yet)\r\n","created_at":"2018-10-03T15:55:00Z","updated_at":"2018-10-05T14:34:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76ce9f96aab5df411dba5c97cd78f43e6b791309","assignee":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"assignees":[{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Gamouche","id":22396445,"node_id":"MDQ6VXNlcjIyMzk2NDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/22396445?v=4","gravatar_id":"","url":"https://api.github.com/users/Gamouche","html_url":"https://github.com/Gamouche","followers_url":"https://api.github.com/users/Gamouche/followers","following_url":"https://api.github.com/users/Gamouche/following{/other_user}","gists_url":"https://api.github.com/users/Gamouche/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamouche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamouche/subscriptions","organizations_url":"https://api.github.com/users/Gamouche/orgs","repos_url":"https://api.github.com/users/Gamouche/repos","events_url":"https://api.github.com/users/Gamouche/events{/privacy}","received_events_url":"https://api.github.com/users/Gamouche/received_events","type":"User","site_admin":false},{"login":"SebastienBruckert","id":25817270,"node_id":"MDQ6VXNlcjI1ODE3Mjcw","avatar_url":"https://avatars2.githubusercontent.com/u/25817270?v=4","gravatar_id":"","url":"https://api.github.com/users/SebastienBruckert","html_url":"https://github.com/SebastienBruckert","followers_url":"https://api.github.com/users/SebastienBruckert/followers","following_url":"https://api.github.com/users/SebastienBruckert/following{/other_user}","gists_url":"https://api.github.com/users/SebastienBruckert/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastienBruckert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastienBruckert/subscriptions","organizations_url":"https://api.github.com/users/SebastienBruckert/orgs","repos_url":"https://api.github.com/users/SebastienBruckert/repos","events_url":"https://api.github.com/users/SebastienBruckert/events{/privacy}","received_events_url":"https://api.github.com/users/SebastienBruckert/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":934078151,"node_id":"MDU6TGFiZWw5MzQwNzgxNTE=","url":"https://api.github.com/repos/jjaniec/21sh/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/jjaniec/21sh/pulls/36/commits","review_comments_url":"https://api.github.com/repos/jjaniec/21sh/pulls/36/comments","review_comment_url":"https://api.github.com/repos/jjaniec/21sh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jjaniec/21sh/issues/36/comments","statuses_url":"https://api.github.com/repos/jjaniec/21sh/statuses/534ec1edc99c1f014f9f16d74346d4ad7d8d8990","head":{"label":"jjaniec:env_handling","ref":"env_handling","sha":"534ec1edc99c1f014f9f16d74346d4ad7d8d8990","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"repo":{"id":133548605,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NDg2MDU=","name":"21sh","full_name":"jjaniec/21sh","private":false,"owner":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjaniec/21sh","description":"Our own shell - wip","fork":false,"url":"https://api.github.com/repos/jjaniec/21sh","forks_url":"https://api.github.com/repos/jjaniec/21sh/forks","keys_url":"https://api.github.com/repos/jjaniec/21sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjaniec/21sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjaniec/21sh/teams","hooks_url":"https://api.github.com/repos/jjaniec/21sh/hooks","issue_events_url":"https://api.github.com/repos/jjaniec/21sh/issues/events{/number}","events_url":"https://api.github.com/repos/jjaniec/21sh/events","assignees_url":"https://api.github.com/repos/jjaniec/21sh/assignees{/user}","branches_url":"https://api.github.com/repos/jjaniec/21sh/branches{/branch}","tags_url":"https://api.github.com/repos/jjaniec/21sh/tags","blobs_url":"https://api.github.com/repos/jjaniec/21sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjaniec/21sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjaniec/21sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjaniec/21sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjaniec/21sh/statuses/{sha}","languages_url":"https://api.github.com/repos/jjaniec/21sh/languages","stargazers_url":"https://api.github.com/repos/jjaniec/21sh/stargazers","contributors_url":"https://api.github.com/repos/jjaniec/21sh/contributors","subscribers_url":"https://api.github.com/repos/jjaniec/21sh/subscribers","subscription_url":"https://api.github.com/repos/jjaniec/21sh/subscription","commits_url":"https://api.github.com/repos/jjaniec/21sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjaniec/21sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjaniec/21sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjaniec/21sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjaniec/21sh/contents/{+path}","compare_url":"https://api.github.com/repos/jjaniec/21sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjaniec/21sh/merges","archive_url":"https://api.github.com/repos/jjaniec/21sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjaniec/21sh/downloads","issues_url":"https://api.github.com/repos/jjaniec/21sh/issues{/number}","pulls_url":"https://api.github.com/repos/jjaniec/21sh/pulls{/number}","milestones_url":"https://api.github.com/repos/jjaniec/21sh/milestones{/number}","notifications_url":"https://api.github.com/repos/jjaniec/21sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjaniec/21sh/labels{/name}","releases_url":"https://api.github.com/repos/jjaniec/21sh/releases{/id}","deployments_url":"https://api.github.com/repos/jjaniec/21sh/deployments","created_at":"2018-05-15T17:10:47Z","updated_at":"2018-10-03T16:11:41Z","pushed_at":"2018-10-05T14:05:12Z","git_url":"git://github.com/jjaniec/21sh.git","ssh_url":"[email protected]:jjaniec/21sh.git","clone_url":"https://github.com/jjaniec/21sh.git","svn_url":"https://github.com/jjaniec/21sh","homepage":"","size":2203,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":3,"default_branch":"develop"}},"base":{"label":"jjaniec:develop","ref":"develop","sha":"10a5b62ec595be25c5540f46fd710da04c4b0075","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"repo":{"id":133548605,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NDg2MDU=","name":"21sh","full_name":"jjaniec/21sh","private":false,"owner":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjaniec/21sh","description":"Our own shell - wip","fork":false,"url":"https://api.github.com/repos/jjaniec/21sh","forks_url":"https://api.github.com/repos/jjaniec/21sh/forks","keys_url":"https://api.github.com/repos/jjaniec/21sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjaniec/21sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjaniec/21sh/teams","hooks_url":"https://api.github.com/repos/jjaniec/21sh/hooks","issue_events_url":"https://api.github.com/repos/jjaniec/21sh/issues/events{/number}","events_url":"https://api.github.com/repos/jjaniec/21sh/events","assignees_url":"https://api.github.com/repos/jjaniec/21sh/assignees{/user}","branches_url":"https://api.github.com/repos/jjaniec/21sh/branches{/branch}","tags_url":"https://api.github.com/repos/jjaniec/21sh/tags","blobs_url":"https://api.github.com/repos/jjaniec/21sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjaniec/21sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjaniec/21sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjaniec/21sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjaniec/21sh/statuses/{sha}","languages_url":"https://api.github.com/repos/jjaniec/21sh/languages","stargazers_url":"https://api.github.com/repos/jjaniec/21sh/stargazers","contributors_url":"https://api.github.com/repos/jjaniec/21sh/contributors","subscribers_url":"https://api.github.com/repos/jjaniec/21sh/subscribers","subscription_url":"https://api.github.com/repos/jjaniec/21sh/subscription","commits_url":"https://api.github.com/repos/jjaniec/21sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjaniec/21sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjaniec/21sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjaniec/21sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjaniec/21sh/contents/{+path}","compare_url":"https://api.github.com/repos/jjaniec/21sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjaniec/21sh/merges","archive_url":"https://api.github.com/repos/jjaniec/21sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjaniec/21sh/downloads","issues_url":"https://api.github.com/repos/jjaniec/21sh/issues{/number}","pulls_url":"https://api.github.com/repos/jjaniec/21sh/pulls{/number}","milestones_url":"https://api.github.com/repos/jjaniec/21sh/milestones{/number}","notifications_url":"https://api.github.com/repos/jjaniec/21sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjaniec/21sh/labels{/name}","releases_url":"https://api.github.com/repos/jjaniec/21sh/releases{/id}","deployments_url":"https://api.github.com/repos/jjaniec/21sh/deployments","created_at":"2018-05-15T17:10:47Z","updated_at":"2018-10-03T16:11:41Z","pushed_at":"2018-10-05T14:05:12Z","git_url":"git://github.com/jjaniec/21sh.git","ssh_url":"[email protected]:jjaniec/21sh.git","clone_url":"https://github.com/jjaniec/21sh.git","svn_url":"https://github.com/jjaniec/21sh","homepage":"","size":2203,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/36"},"html":{"href":"https://github.com/jjaniec/21sh/pull/36"},"issue":{"href":"https://api.github.com/repos/jjaniec/21sh/issues/36"},"comments":{"href":"https://api.github.com/repos/jjaniec/21sh/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/jjaniec/21sh/statuses/534ec1edc99c1f014f9f16d74346d4ad7d8d8990"}},"author_association":"OWNER"}} | {
"id": 133548605,
"name": "jjaniec/21sh",
"url": "https://api.github.com/repos/jjaniec/21sh"
} | {
"id": 39514782,
"login": "sonarcloud[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39514782?",
"url": "https://api.github.com/users/sonarcloud[bot]"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-10-05T14:34:24 | 8374770611 | {"actor":{"display_login":"sonarcloud"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/danMateer/sample_code/pulls/comments/234684225","pull_request_review_id":176378438,"id":234684225,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDY4NDIyNQ==","diff_hunk":"@@ -2,14 +2,12 @@ let text = \"Last weekend, I took literally the most beautiful bike ride of my li\n \n let overusedWords = [\"really\", \"very\", \"basically\"];\n let unnecessaryWords = [\"extremely\", \"literally\", \"actually\"];\n-let coolWords = [\"jazz\", \"kickflip-mctwist\"];\n+let coolWords = [\"jazz\", \"smoking\"];\n \n let textWords = text.split(\" \");\n let allLowercaseWords = textWords.toLowerCase();\n let betterWords = [];\n \n-// Testing","path":"basicLinter.js","position":11,"original_position":11,"commit_id":"74107c8cb8cb31ea1f0b1a7891dc331a1510b988","original_commit_id":"74107c8cb8cb31ea1f0b1a7891dc331a1510b988","user":{"login":"staging[bot]","id":30204859,"node_id":"MDM6Qm90MzAyMDQ4NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/27742649?v=4","gravatar_id":"","url":"https://api.github.com/users/staging%5Bbot%5D","html_url":"https://github.com/apps/staging","followers_url":"https://api.github.com/users/staging%5Bbot%5D/followers","following_url":"https://api.github.com/users/staging%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/staging%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/staging%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staging%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/staging%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/staging%5Bbot%5D/repos","events_url":"https://api.github.com/users/staging%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/staging%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"No change was made. Do you still want to remove this?","created_at":"2018-11-19T16:19:08Z","updated_at":"2018-11-19T16:19:08Z","html_url":"https://github.com/danMateer/sample_code/pull/111#discussion_r234684225","pull_request_url":"https://api.github.com/repos/danMateer/sample_code/pulls/111","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/danMateer/sample_code/pulls/comments/234684225"},"html":{"href":"https://github.com/danMateer/sample_code/pull/111#discussion_r234684225"},"pull_request":{"href":"https://api.github.com/repos/danMateer/sample_code/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/danMateer/sample_code/pulls/111","id":232029098,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDI5MDk4","html_url":"https://github.com/danMateer/sample_code/pull/111","diff_url":"https://github.com/danMateer/sample_code/pull/111.diff","patch_url":"https://github.com/danMateer/sample_code/pull/111.patch","issue_url":"https://api.github.com/repos/danMateer/sample_code/issues/111","number":111,"state":"open","locked":false,"title":"removed testing","user":{"login":"danMateer","id":34169713,"node_id":"MDQ6VXNlcjM0MTY5NzEz","avatar_url":"https://avatars2.githubusercontent.com/u/34169713?v=4","gravatar_id":"","url":"https://api.github.com/users/danMateer","html_url":"https://github.com/danMateer","followers_url":"https://api.github.com/users/danMateer/followers","following_url":"https://api.github.com/users/danMateer/following{/other_user}","gists_url":"https://api.github.com/users/danMateer/gists{/gist_id}","starred_url":"https://api.github.com/users/danMateer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danMateer/subscriptions","organizations_url":"https://api.github.com/users/danMateer/orgs","repos_url":"https://api.github.com/users/danMateer/repos","events_url":"https://api.github.com/users/danMateer/events{/privacy}","received_events_url":"https://api.github.com/users/danMateer/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-19T16:12:13Z","updated_at":"2018-11-19T16:19:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8a65283043a1231e101cfeda4f98fd9608db0ba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/danMateer/sample_code/pulls/111/commits","review_comments_url":"https://api.github.com/repos/danMateer/sample_code/pulls/111/comments","review_comment_url":"https://api.github.com/repos/danMateer/sample_code/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danMateer/sample_code/issues/111/comments","statuses_url":"https://api.github.com/repos/danMateer/sample_code/statuses/74107c8cb8cb31ea1f0b1a7891dc331a1510b988","head":{"label":"danMateer:feature-branch20","ref":"feature-branch20","sha":"74107c8cb8cb31ea1f0b1a7891dc331a1510b988","user":{"login":"danMateer","id":34169713,"node_id":"MDQ6VXNlcjM0MTY5NzEz","avatar_url":"https://avatars2.githubusercontent.com/u/34169713?v=4","gravatar_id":"","url":"https://api.github.com/users/danMateer","html_url":"https://github.com/danMateer","followers_url":"https://api.github.com/users/danMateer/followers","following_url":"https://api.github.com/users/danMateer/following{/other_user}","gists_url":"https://api.github.com/users/danMateer/gists{/gist_id}","starred_url":"https://api.github.com/users/danMateer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danMateer/subscriptions","organizations_url":"https://api.github.com/users/danMateer/orgs","repos_url":"https://api.github.com/users/danMateer/repos","events_url":"https://api.github.com/users/danMateer/events{/privacy}","received_events_url":"https://api.github.com/users/danMateer/received_events","type":"User","site_admin":false},"repo":{"id":116047014,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwNDcwMTQ=","name":"sample_code","full_name":"danMateer/sample_code","private":false,"owner":{"login":"danMateer","id":34169713,"node_id":"MDQ6VXNlcjM0MTY5NzEz","avatar_url":"https://avatars2.githubusercontent.com/u/34169713?v=4","gravatar_id":"","url":"https://api.github.com/users/danMateer","html_url":"https://github.com/danMateer","followers_url":"https://api.github.com/users/danMateer/followers","following_url":"https://api.github.com/users/danMateer/following{/other_user}","gists_url":"https://api.github.com/users/danMateer/gists{/gist_id}","starred_url":"https://api.github.com/users/danMateer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danMateer/subscriptions","organizations_url":"https://api.github.com/users/danMateer/orgs","repos_url":"https://api.github.com/users/danMateer/repos","events_url":"https://api.github.com/users/danMateer/events{/privacy}","received_events_url":"https://api.github.com/users/danMateer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danMateer/sample_code","description":"For testing.","fork":false,"url":"https://api.github.com/repos/danMateer/sample_code","forks_url":"https://api.github.com/repos/danMateer/sample_code/forks","keys_url":"https://api.github.com/repos/danMateer/sample_code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danMateer/sample_code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danMateer/sample_code/teams","hooks_url":"https://api.github.com/repos/danMateer/sample_code/hooks","issue_events_url":"https://api.github.com/repos/danMateer/sample_code/issues/events{/number}","events_url":"https://api.github.com/repos/danMateer/sample_code/events","assignees_url":"https://api.github.com/repos/danMateer/sample_code/assignees{/user}","branches_url":"https://api.github.com/repos/danMateer/sample_code/branches{/branch}","tags_url":"https://api.github.com/repos/danMateer/sample_code/tags","blobs_url":"https://api.github.com/repos/danMateer/sample_code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danMateer/sample_code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danMateer/sample_code/git/refs{/sha}","trees_url":"https://api.github.com/repos/danMateer/sample_code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danMateer/sample_code/statuses/{sha}","languages_url":"https://api.github.com/repos/danMateer/sample_code/languages","stargazers_url":"https://api.github.com/repos/danMateer/sample_code/stargazers","contributors_url":"https://api.github.com/repos/danMateer/sample_code/contributors","subscribers_url":"https://api.github.com/repos/danMateer/sample_code/subscribers","subscription_url":"https://api.github.com/repos/danMateer/sample_code/subscription","commits_url":"https://api.github.com/repos/danMateer/sample_code/commits{/sha}","git_commits_url":"https://api.github.com/repos/danMateer/sample_code/git/commits{/sha}","comments_url":"https://api.github.com/repos/danMateer/sample_code/comments{/number}","issue_comment_url":"https://api.github.com/repos/danMateer/sample_code/issues/comments{/number}","contents_url":"https://api.github.com/repos/danMateer/sample_code/contents/{+path}","compare_url":"https://api.github.com/repos/danMateer/sample_code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danMateer/sample_code/merges","archive_url":"https://api.github.com/repos/danMateer/sample_code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danMateer/sample_code/downloads","issues_url":"https://api.github.com/repos/danMateer/sample_code/issues{/number}","pulls_url":"https://api.github.com/repos/danMateer/sample_code/pulls{/number}","milestones_url":"https://api.github.com/repos/danMateer/sample_code/milestones{/number}","notifications_url":"https://api.github.com/repos/danMateer/sample_code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danMateer/sample_code/labels{/name}","releases_url":"https://api.github.com/repos/danMateer/sample_code/releases{/id}","deployments_url":"https://api.github.com/repos/danMateer/sample_code/deployments","created_at":"2018-01-02T18:57:44Z","updated_at":"2018-11-13T18:06:02Z","pushed_at":"2018-11-19T16:12:14Z","git_url":"git://github.com/danMateer/sample_code.git","ssh_url":"[email protected]:danMateer/sample_code.git","clone_url":"https://github.com/danMateer/sample_code.git","svn_url":"https://github.com/danMateer/sample_code","homepage":null,"size":146,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"danMateer:master","ref":"master","sha":"03f33014ceab5bef682fbd642806963cc3310671","user":{"login":"danMateer","id":34169713,"node_id":"MDQ6VXNlcjM0MTY5NzEz","avatar_url":"https://avatars2.githubusercontent.com/u/34169713?v=4","gravatar_id":"","url":"https://api.github.com/users/danMateer","html_url":"https://github.com/danMateer","followers_url":"https://api.github.com/users/danMateer/followers","following_url":"https://api.github.com/users/danMateer/following{/other_user}","gists_url":"https://api.github.com/users/danMateer/gists{/gist_id}","starred_url":"https://api.github.com/users/danMateer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danMateer/subscriptions","organizations_url":"https://api.github.com/users/danMateer/orgs","repos_url":"https://api.github.com/users/danMateer/repos","events_url":"https://api.github.com/users/danMateer/events{/privacy}","received_events_url":"https://api.github.com/users/danMateer/received_events","type":"User","site_admin":false},"repo":{"id":116047014,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwNDcwMTQ=","name":"sample_code","full_name":"danMateer/sample_code","private":false,"owner":{"login":"danMateer","id":34169713,"node_id":"MDQ6VXNlcjM0MTY5NzEz","avatar_url":"https://avatars2.githubusercontent.com/u/34169713?v=4","gravatar_id":"","url":"https://api.github.com/users/danMateer","html_url":"https://github.com/danMateer","followers_url":"https://api.github.com/users/danMateer/followers","following_url":"https://api.github.com/users/danMateer/following{/other_user}","gists_url":"https://api.github.com/users/danMateer/gists{/gist_id}","starred_url":"https://api.github.com/users/danMateer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danMateer/subscriptions","organizations_url":"https://api.github.com/users/danMateer/orgs","repos_url":"https://api.github.com/users/danMateer/repos","events_url":"https://api.github.com/users/danMateer/events{/privacy}","received_events_url":"https://api.github.com/users/danMateer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danMateer/sample_code","description":"For testing.","fork":false,"url":"https://api.github.com/repos/danMateer/sample_code","forks_url":"https://api.github.com/repos/danMateer/sample_code/forks","keys_url":"https://api.github.com/repos/danMateer/sample_code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danMateer/sample_code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danMateer/sample_code/teams","hooks_url":"https://api.github.com/repos/danMateer/sample_code/hooks","issue_events_url":"https://api.github.com/repos/danMateer/sample_code/issues/events{/number}","events_url":"https://api.github.com/repos/danMateer/sample_code/events","assignees_url":"https://api.github.com/repos/danMateer/sample_code/assignees{/user}","branches_url":"https://api.github.com/repos/danMateer/sample_code/branches{/branch}","tags_url":"https://api.github.com/repos/danMateer/sample_code/tags","blobs_url":"https://api.github.com/repos/danMateer/sample_code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danMateer/sample_code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danMateer/sample_code/git/refs{/sha}","trees_url":"https://api.github.com/repos/danMateer/sample_code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danMateer/sample_code/statuses/{sha}","languages_url":"https://api.github.com/repos/danMateer/sample_code/languages","stargazers_url":"https://api.github.com/repos/danMateer/sample_code/stargazers","contributors_url":"https://api.github.com/repos/danMateer/sample_code/contributors","subscribers_url":"https://api.github.com/repos/danMateer/sample_code/subscribers","subscription_url":"https://api.github.com/repos/danMateer/sample_code/subscription","commits_url":"https://api.github.com/repos/danMateer/sample_code/commits{/sha}","git_commits_url":"https://api.github.com/repos/danMateer/sample_code/git/commits{/sha}","comments_url":"https://api.github.com/repos/danMateer/sample_code/comments{/number}","issue_comment_url":"https://api.github.com/repos/danMateer/sample_code/issues/comments{/number}","contents_url":"https://api.github.com/repos/danMateer/sample_code/contents/{+path}","compare_url":"https://api.github.com/repos/danMateer/sample_code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danMateer/sample_code/merges","archive_url":"https://api.github.com/repos/danMateer/sample_code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danMateer/sample_code/downloads","issues_url":"https://api.github.com/repos/danMateer/sample_code/issues{/number}","pulls_url":"https://api.github.com/repos/danMateer/sample_code/pulls{/number}","milestones_url":"https://api.github.com/repos/danMateer/sample_code/milestones{/number}","notifications_url":"https://api.github.com/repos/danMateer/sample_code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danMateer/sample_code/labels{/name}","releases_url":"https://api.github.com/repos/danMateer/sample_code/releases{/id}","deployments_url":"https://api.github.com/repos/danMateer/sample_code/deployments","created_at":"2018-01-02T18:57:44Z","updated_at":"2018-11-13T18:06:02Z","pushed_at":"2018-11-19T16:12:14Z","git_url":"git://github.com/danMateer/sample_code.git","ssh_url":"[email protected]:danMateer/sample_code.git","clone_url":"https://github.com/danMateer/sample_code.git","svn_url":"https://github.com/danMateer/sample_code","homepage":null,"size":146,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danMateer/sample_code/pulls/111"},"html":{"href":"https://github.com/danMateer/sample_code/pull/111"},"issue":{"href":"https://api.github.com/repos/danMateer/sample_code/issues/111"},"comments":{"href":"https://api.github.com/repos/danMateer/sample_code/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/danMateer/sample_code/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/danMateer/sample_code/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danMateer/sample_code/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/danMateer/sample_code/statuses/74107c8cb8cb31ea1f0b1a7891dc331a1510b988"}},"author_association":"OWNER"}} | {
"id": 116047014,
"name": "danMateer/sample_code",
"url": "https://api.github.com/repos/danMateer/sample_code"
} | {
"id": 30204859,
"login": "staging[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30204859?",
"url": "https://api.github.com/users/staging[bot]"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-11-19T16:19:08 | 8613977123 | {"actor":{"display_login":"staging"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/comments/183218081","pull_request_review_id":114182105,"id":183218081,"diff_hunk":"@@ -0,0 +1,107 @@\n+package TailLogic;\n+\n+import java.io.*;\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+public class Tail {\n+ private List<String> lines;\n+ private List<Character> characters;\n+ public enum TypeOfInput {\n+ Console,\n+ File\n+ }\n+\n+ public Tail(TypeOfInput type, boolean isN, String inputFile) throws IOException {","path":"src/main/java/TailLogic/Tail.java","position":15,"original_position":15,"commit_id":"7f5f7161c8538d2add0f580fce07d769791c8bc1","original_commit_id":"7f5f7161c8538d2add0f580fce07d769791c8bc1","user":{"login":"poluh","id":31898927,"avatar_url":"https://avatars2.githubusercontent.com/u/31898927?v=4","gravatar_id":"","url":"https://api.github.com/users/poluh","html_url":"https://github.com/poluh","followers_url":"https://api.github.com/users/poluh/followers","following_url":"https://api.github.com/users/poluh/following{/other_user}","gists_url":"https://api.github.com/users/poluh/gists{/gist_id}","starred_url":"https://api.github.com/users/poluh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poluh/subscriptions","organizations_url":"https://api.github.com/users/poluh/orgs","repos_url":"https://api.github.com/users/poluh/repos","events_url":"https://api.github.com/users/poluh/events{/privacy}","received_events_url":"https://api.github.com/users/poluh/received_events","type":"User","site_admin":false},"body":"В данный момент вы никак не обрабатываете этот случай. Думаю, стоит завести так же переменную для ```-c```. Собственно, вы с этим столкнетесь, если будете делать парсер через одну из библиотек.","created_at":"2018-04-21T20:11:01Z","updated_at":"2018-04-21T20:11:01Z","html_url":"https://github.com/h31/ProgrammingLabTask2/pull/15#discussion_r183218081","pull_request_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/15","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/comments/183218081"},"html":{"href":"https://github.com/h31/ProgrammingLabTask2/pull/15#discussion_r183218081"},"pull_request":{"href":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/15"}},"in_reply_to_id":183186520},"pull_request":{"url":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/15","id":179198189,"html_url":"https://github.com/h31/ProgrammingLabTask2/pull/15","diff_url":"https://github.com/h31/ProgrammingLabTask2/pull/15.diff","patch_url":"https://github.com/h31/ProgrammingLabTask2/pull/15.patch","issue_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/issues/15","number":15,"state":"open","locked":false,"title":"Mасленников Владислав. Tail","user":{"login":"Vinogradnij","id":31983144,"avatar_url":"https://avatars3.githubusercontent.com/u/31983144?v=4","gravatar_id":"","url":"https://api.github.com/users/Vinogradnij","html_url":"https://github.com/Vinogradnij","followers_url":"https://api.github.com/users/Vinogradnij/followers","following_url":"https://api.github.com/users/Vinogradnij/following{/other_user}","gists_url":"https://api.github.com/users/Vinogradnij/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinogradnij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinogradnij/subscriptions","organizations_url":"https://api.github.com/users/Vinogradnij/orgs","repos_url":"https://api.github.com/users/Vinogradnij/repos","events_url":"https://api.github.com/users/Vinogradnij/events{/privacy}","received_events_url":"https://api.github.com/users/Vinogradnij/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-03T19:35:16Z","updated_at":"2018-04-21T20:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3360e1c600124c5830facf4068f46da6106afb89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/15/commits","review_comments_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/15/comments","review_comment_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/issues/15/comments","statuses_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/statuses/7f5f7161c8538d2add0f580fce07d769791c8bc1","head":{"label":"Vinogradnij:master","ref":"master","sha":"7f5f7161c8538d2add0f580fce07d769791c8bc1","user":{"login":"Vinogradnij","id":31983144,"avatar_url":"https://avatars3.githubusercontent.com/u/31983144?v=4","gravatar_id":"","url":"https://api.github.com/users/Vinogradnij","html_url":"https://github.com/Vinogradnij","followers_url":"https://api.github.com/users/Vinogradnij/followers","following_url":"https://api.github.com/users/Vinogradnij/following{/other_user}","gists_url":"https://api.github.com/users/Vinogradnij/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinogradnij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinogradnij/subscriptions","organizations_url":"https://api.github.com/users/Vinogradnij/orgs","repos_url":"https://api.github.com/users/Vinogradnij/repos","events_url":"https://api.github.com/users/Vinogradnij/events{/privacy}","received_events_url":"https://api.github.com/users/Vinogradnij/received_events","type":"User","site_admin":false},"repo":{"id":126046561,"name":"ProgrammingLabTask2","full_name":"Vinogradnij/ProgrammingLabTask2","owner":{"login":"Vinogradnij","id":31983144,"avatar_url":"https://avatars3.githubusercontent.com/u/31983144?v=4","gravatar_id":"","url":"https://api.github.com/users/Vinogradnij","html_url":"https://github.com/Vinogradnij","followers_url":"https://api.github.com/users/Vinogradnij/followers","following_url":"https://api.github.com/users/Vinogradnij/following{/other_user}","gists_url":"https://api.github.com/users/Vinogradnij/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinogradnij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinogradnij/subscriptions","organizations_url":"https://api.github.com/users/Vinogradnij/orgs","repos_url":"https://api.github.com/users/Vinogradnij/repos","events_url":"https://api.github.com/users/Vinogradnij/events{/privacy}","received_events_url":"https://api.github.com/users/Vinogradnij/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vinogradnij/ProgrammingLabTask2","description":"Programming Lab (Task 2)","fork":true,"url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2","forks_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/forks","keys_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/teams","hooks_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/hooks","issue_events_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/issues/events{/number}","events_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/events","assignees_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/assignees{/user}","branches_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/branches{/branch}","tags_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/tags","blobs_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/statuses/{sha}","languages_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/languages","stargazers_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/stargazers","contributors_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/contributors","subscribers_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/subscribers","subscription_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/subscription","commits_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/contents/{+path}","compare_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/merges","archive_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/downloads","issues_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/issues{/number}","pulls_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/pulls{/number}","milestones_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/milestones{/number}","notifications_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/labels{/name}","releases_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/releases{/id}","deployments_url":"https://api.github.com/repos/Vinogradnij/ProgrammingLabTask2/deployments","created_at":"2018-03-20T16:15:55Z","updated_at":"2018-04-20T20:33:50Z","pushed_at":"2018-04-20T20:33:49Z","git_url":"git://github.com/Vinogradnij/ProgrammingLabTask2.git","ssh_url":"[email protected]:Vinogradnij/ProgrammingLabTask2.git","clone_url":"https://github.com/Vinogradnij/ProgrammingLabTask2.git","svn_url":"https://github.com/Vinogradnij/ProgrammingLabTask2","homepage":null,"size":72,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"h31:master","ref":"master","sha":"9a392b5099b60b41db841cde3455adb79d5b54c0","user":{"login":"h31","id":3375923,"avatar_url":"https://avatars0.githubusercontent.com/u/3375923?v=4","gravatar_id":"","url":"https://api.github.com/users/h31","html_url":"https://github.com/h31","followers_url":"https://api.github.com/users/h31/followers","following_url":"https://api.github.com/users/h31/following{/other_user}","gists_url":"https://api.github.com/users/h31/gists{/gist_id}","starred_url":"https://api.github.com/users/h31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h31/subscriptions","organizations_url":"https://api.github.com/users/h31/orgs","repos_url":"https://api.github.com/users/h31/repos","events_url":"https://api.github.com/users/h31/events{/privacy}","received_events_url":"https://api.github.com/users/h31/received_events","type":"User","site_admin":false},"repo":{"id":124929991,"name":"ProgrammingLabTask2","full_name":"h31/ProgrammingLabTask2","owner":{"login":"h31","id":3375923,"avatar_url":"https://avatars0.githubusercontent.com/u/3375923?v=4","gravatar_id":"","url":"https://api.github.com/users/h31","html_url":"https://github.com/h31","followers_url":"https://api.github.com/users/h31/followers","following_url":"https://api.github.com/users/h31/following{/other_user}","gists_url":"https://api.github.com/users/h31/gists{/gist_id}","starred_url":"https://api.github.com/users/h31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h31/subscriptions","organizations_url":"https://api.github.com/users/h31/orgs","repos_url":"https://api.github.com/users/h31/repos","events_url":"https://api.github.com/users/h31/events{/privacy}","received_events_url":"https://api.github.com/users/h31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/h31/ProgrammingLabTask2","description":"Programming Lab (Task 2)","fork":false,"url":"https://api.github.com/repos/h31/ProgrammingLabTask2","forks_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/forks","keys_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/teams","hooks_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/hooks","issue_events_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/issues/events{/number}","events_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/events","assignees_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/assignees{/user}","branches_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/branches{/branch}","tags_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/tags","blobs_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/git/refs{/sha}","trees_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/statuses/{sha}","languages_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/languages","stargazers_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/stargazers","contributors_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/contributors","subscribers_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/subscribers","subscription_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/subscription","commits_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/commits{/sha}","git_commits_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/git/commits{/sha}","comments_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/comments{/number}","issue_comment_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/issues/comments{/number}","contents_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/contents/{+path}","compare_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/merges","archive_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/downloads","issues_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/issues{/number}","pulls_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls{/number}","milestones_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/milestones{/number}","notifications_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/labels{/name}","releases_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/releases{/id}","deployments_url":"https://api.github.com/repos/h31/ProgrammingLabTask2/deployments","created_at":"2018-03-12T18:01:00Z","updated_at":"2018-03-12T18:01:00Z","pushed_at":"2018-04-20T20:33:50Z","git_url":"git://github.com/h31/ProgrammingLabTask2.git","ssh_url":"[email protected]:h31/ProgrammingLabTask2.git","clone_url":"https://github.com/h31/ProgrammingLabTask2.git","svn_url":"https://github.com/h31/ProgrammingLabTask2","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":23,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/15"},"html":{"href":"https://github.com/h31/ProgrammingLabTask2/pull/15"},"issue":{"href":"https://api.github.com/repos/h31/ProgrammingLabTask2/issues/15"},"comments":{"href":"https://api.github.com/repos/h31/ProgrammingLabTask2/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/h31/ProgrammingLabTask2/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/h31/ProgrammingLabTask2/statuses/7f5f7161c8538d2add0f580fce07d769791c8bc1"}},"author_association":"NONE"}} | {
"id": 124929991,
"name": "h31/ProgrammingLabTask2",
"url": "https://api.github.com/repos/h31/ProgrammingLabTask2"
} | {
"id": 31898927,
"login": "poluh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31898927?",
"url": "https://api.github.com/users/poluh"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-04-21T20:11:01 | 7566405974 | {"actor":{"display_login":"poluh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/wolferen/if/pulls/comments/165673556","pull_request_review_id":93654580,"id":165673556,"diff_hunk":"@@ -1,8 +1,11 @@\n+# frozen_string_literal: true","path":"app/controllers/api/v1/users_controller.rb","position":1,"original_position":1,"commit_id":"8184ab457abc29e7289111479790abf9301227ed","original_commit_id":"8184ab457abc29e7289111479790abf9301227ed","user":{"login":"yuriy","id":37482,"avatar_url":"https://avatars0.githubusercontent.com/u/37482?v=4","gravatar_id":"","url":"https://api.github.com/users/yuriy","html_url":"https://github.com/yuriy","followers_url":"https://api.github.com/users/yuriy/followers","following_url":"https://api.github.com/users/yuriy/following{/other_user}","gists_url":"https://api.github.com/users/yuriy/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriy/subscriptions","organizations_url":"https://api.github.com/users/yuriy/orgs","repos_url":"https://api.github.com/users/yuriy/repos","events_url":"https://api.github.com/users/yuriy/events{/privacy}","received_events_url":"https://api.github.com/users/yuriy/received_events","type":"User","site_admin":false},"body":"Still tell me why do you decided to use this?","created_at":"2018-02-02T15:25:22Z","updated_at":"2018-02-02T15:26:20Z","html_url":"https://github.com/wolferen/if/pull/15#discussion_r165673556","pull_request_url":"https://api.github.com/repos/wolferen/if/pulls/15","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wolferen/if/pulls/comments/165673556"},"html":{"href":"https://github.com/wolferen/if/pull/15#discussion_r165673556"},"pull_request":{"href":"https://api.github.com/repos/wolferen/if/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/wolferen/if/pulls/15","id":166782075,"html_url":"https://github.com/wolferen/if/pull/15","diff_url":"https://github.com/wolferen/if/pull/15.diff","patch_url":"https://github.com/wolferen/if/pull/15.patch","issue_url":"https://api.github.com/repos/wolferen/if/issues/15","number":15,"state":"open","locked":false,"title":"16-api-update-pundit","user":{"login":"wolferen","id":8527339,"avatar_url":"https://avatars3.githubusercontent.com/u/8527339?v=4","gravatar_id":"","url":"https://api.github.com/users/wolferen","html_url":"https://github.com/wolferen","followers_url":"https://api.github.com/users/wolferen/followers","following_url":"https://api.github.com/users/wolferen/following{/other_user}","gists_url":"https://api.github.com/users/wolferen/gists{/gist_id}","starred_url":"https://api.github.com/users/wolferen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolferen/subscriptions","organizations_url":"https://api.github.com/users/wolferen/orgs","repos_url":"https://api.github.com/users/wolferen/repos","events_url":"https://api.github.com/users/wolferen/events{/privacy}","received_events_url":"https://api.github.com/users/wolferen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-02T11:42:50Z","updated_at":"2018-02-02T15:26:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb5c205de662b95695db93567420362cd023d1e2","assignee":{"login":"wolferen","id":8527339,"avatar_url":"https://avatars3.githubusercontent.com/u/8527339?v=4","gravatar_id":"","url":"https://api.github.com/users/wolferen","html_url":"https://github.com/wolferen","followers_url":"https://api.github.com/users/wolferen/followers","following_url":"https://api.github.com/users/wolferen/following{/other_user}","gists_url":"https://api.github.com/users/wolferen/gists{/gist_id}","starred_url":"https://api.github.com/users/wolferen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolferen/subscriptions","organizations_url":"https://api.github.com/users/wolferen/orgs","repos_url":"https://api.github.com/users/wolferen/repos","events_url":"https://api.github.com/users/wolferen/events{/privacy}","received_events_url":"https://api.github.com/users/wolferen/received_events","type":"User","site_admin":false},"assignees":[{"login":"wolferen","id":8527339,"avatar_url":"https://avatars3.githubusercontent.com/u/8527339?v=4","gravatar_id":"","url":"https://api.github.com/users/wolferen","html_url":"https://github.com/wolferen","followers_url":"https://api.github.com/users/wolferen/followers","following_url":"https://api.github.com/users/wolferen/following{/other_user}","gists_url":"https://api.github.com/users/wolferen/gists{/gist_id}","starred_url":"https://api.github.com/users/wolferen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolferen/subscriptions","organizations_url":"https://api.github.com/users/wolferen/orgs","repos_url":"https://api.github.com/users/wolferen/repos","events_url":"https://api.github.com/users/wolferen/events{/privacy}","received_events_url":"https://api.github.com/users/wolferen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/wolferen/if/pulls/15/commits","review_comments_url":"https://api.github.com/repos/wolferen/if/pulls/15/comments","review_comment_url":"https://api.github.com/repos/wolferen/if/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wolferen/if/issues/15/comments","statuses_url":"https://api.github.com/repos/wolferen/if/statuses/8184ab457abc29e7289111479790abf9301227ed","head":{"label":"wolferen:16-api-update-pundit","ref":"16-api-update-pundit","sha":"8184ab457abc29e7289111479790abf9301227ed","user":{"login":"wolferen","id":8527339,"avatar_url":"https://avatars3.githubusercontent.com/u/8527339?v=4","gravatar_id":"","url":"https://api.github.com/users/wolferen","html_url":"https://github.com/wolferen","followers_url":"https://api.github.com/users/wolferen/followers","following_url":"https://api.github.com/users/wolferen/following{/other_user}","gists_url":"https://api.github.com/users/wolferen/gists{/gist_id}","starred_url":"https://api.github.com/users/wolferen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolferen/subscriptions","organizations_url":"https://api.github.com/users/wolferen/orgs","repos_url":"https://api.github.com/users/wolferen/repos","events_url":"https://api.github.com/users/wolferen/events{/privacy}","received_events_url":"https://api.github.com/users/wolferen/received_events","type":"User","site_admin":false},"repo":{"id":115124893,"name":"if","full_name":"wolferen/if","owner":{"login":"wolferen","id":8527339,"avatar_url":"https://avatars3.githubusercontent.com/u/8527339?v=4","gravatar_id":"","url":"https://api.github.com/users/wolferen","html_url":"https://github.com/wolferen","followers_url":"https://api.github.com/users/wolferen/followers","following_url":"https://api.github.com/users/wolferen/following{/other_user}","gists_url":"https://api.github.com/users/wolferen/gists{/gist_id}","starred_url":"https://api.github.com/users/wolferen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolferen/subscriptions","organizations_url":"https://api.github.com/users/wolferen/orgs","repos_url":"https://api.github.com/users/wolferen/repos","events_url":"https://api.github.com/users/wolferen/events{/privacy}","received_events_url":"https://api.github.com/users/wolferen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wolferen/if","description":null,"fork":false,"url":"https://api.github.com/repos/wolferen/if","forks_url":"https://api.github.com/repos/wolferen/if/forks","keys_url":"https://api.github.com/repos/wolferen/if/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolferen/if/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolferen/if/teams","hooks_url":"https://api.github.com/repos/wolferen/if/hooks","issue_events_url":"https://api.github.com/repos/wolferen/if/issues/events{/number}","events_url":"https://api.github.com/repos/wolferen/if/events","assignees_url":"https://api.github.com/repos/wolferen/if/assignees{/user}","branches_url":"https://api.github.com/repos/wolferen/if/branches{/branch}","tags_url":"https://api.github.com/repos/wolferen/if/tags","blobs_url":"https://api.github.com/repos/wolferen/if/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolferen/if/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolferen/if/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolferen/if/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolferen/if/statuses/{sha}","languages_url":"https://api.github.com/repos/wolferen/if/languages","stargazers_url":"https://api.github.com/repos/wolferen/if/stargazers","contributors_url":"https://api.github.com/repos/wolferen/if/contributors","subscribers_url":"https://api.github.com/repos/wolferen/if/subscribers","subscription_url":"https://api.github.com/repos/wolferen/if/subscription","commits_url":"https://api.github.com/repos/wolferen/if/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolferen/if/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolferen/if/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolferen/if/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolferen/if/contents/{+path}","compare_url":"https://api.github.com/repos/wolferen/if/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolferen/if/merges","archive_url":"https://api.github.com/repos/wolferen/if/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolferen/if/downloads","issues_url":"https://api.github.com/repos/wolferen/if/issues{/number}","pulls_url":"https://api.github.com/repos/wolferen/if/pulls{/number}","milestones_url":"https://api.github.com/repos/wolferen/if/milestones{/number}","notifications_url":"https://api.github.com/repos/wolferen/if/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolferen/if/labels{/name}","releases_url":"https://api.github.com/repos/wolferen/if/releases{/id}","deployments_url":"https://api.github.com/repos/wolferen/if/deployments","created_at":"2017-12-22T14:57:36Z","updated_at":"2017-12-26T18:25:04Z","pushed_at":"2018-02-02T15:14:22Z","git_url":"git://github.com/wolferen/if.git","ssh_url":"[email protected]:wolferen/if.git","clone_url":"https://github.com/wolferen/if.git","svn_url":"https://github.com/wolferen/if","homepage":null,"size":1133,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wolferen:master","ref":"master","sha":"109ffe7d50094f70581bee642efb0c095b7e0be8","user":{"login":"wolferen","id":8527339,"avatar_url":"https://avatars3.githubusercontent.com/u/8527339?v=4","gravatar_id":"","url":"https://api.github.com/users/wolferen","html_url":"https://github.com/wolferen","followers_url":"https://api.github.com/users/wolferen/followers","following_url":"https://api.github.com/users/wolferen/following{/other_user}","gists_url":"https://api.github.com/users/wolferen/gists{/gist_id}","starred_url":"https://api.github.com/users/wolferen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolferen/subscriptions","organizations_url":"https://api.github.com/users/wolferen/orgs","repos_url":"https://api.github.com/users/wolferen/repos","events_url":"https://api.github.com/users/wolferen/events{/privacy}","received_events_url":"https://api.github.com/users/wolferen/received_events","type":"User","site_admin":false},"repo":{"id":115124893,"name":"if","full_name":"wolferen/if","owner":{"login":"wolferen","id":8527339,"avatar_url":"https://avatars3.githubusercontent.com/u/8527339?v=4","gravatar_id":"","url":"https://api.github.com/users/wolferen","html_url":"https://github.com/wolferen","followers_url":"https://api.github.com/users/wolferen/followers","following_url":"https://api.github.com/users/wolferen/following{/other_user}","gists_url":"https://api.github.com/users/wolferen/gists{/gist_id}","starred_url":"https://api.github.com/users/wolferen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolferen/subscriptions","organizations_url":"https://api.github.com/users/wolferen/orgs","repos_url":"https://api.github.com/users/wolferen/repos","events_url":"https://api.github.com/users/wolferen/events{/privacy}","received_events_url":"https://api.github.com/users/wolferen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wolferen/if","description":null,"fork":false,"url":"https://api.github.com/repos/wolferen/if","forks_url":"https://api.github.com/repos/wolferen/if/forks","keys_url":"https://api.github.com/repos/wolferen/if/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolferen/if/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolferen/if/teams","hooks_url":"https://api.github.com/repos/wolferen/if/hooks","issue_events_url":"https://api.github.com/repos/wolferen/if/issues/events{/number}","events_url":"https://api.github.com/repos/wolferen/if/events","assignees_url":"https://api.github.com/repos/wolferen/if/assignees{/user}","branches_url":"https://api.github.com/repos/wolferen/if/branches{/branch}","tags_url":"https://api.github.com/repos/wolferen/if/tags","blobs_url":"https://api.github.com/repos/wolferen/if/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolferen/if/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolferen/if/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolferen/if/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolferen/if/statuses/{sha}","languages_url":"https://api.github.com/repos/wolferen/if/languages","stargazers_url":"https://api.github.com/repos/wolferen/if/stargazers","contributors_url":"https://api.github.com/repos/wolferen/if/contributors","subscribers_url":"https://api.github.com/repos/wolferen/if/subscribers","subscription_url":"https://api.github.com/repos/wolferen/if/subscription","commits_url":"https://api.github.com/repos/wolferen/if/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolferen/if/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolferen/if/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolferen/if/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolferen/if/contents/{+path}","compare_url":"https://api.github.com/repos/wolferen/if/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolferen/if/merges","archive_url":"https://api.github.com/repos/wolferen/if/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolferen/if/downloads","issues_url":"https://api.github.com/repos/wolferen/if/issues{/number}","pulls_url":"https://api.github.com/repos/wolferen/if/pulls{/number}","milestones_url":"https://api.github.com/repos/wolferen/if/milestones{/number}","notifications_url":"https://api.github.com/repos/wolferen/if/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolferen/if/labels{/name}","releases_url":"https://api.github.com/repos/wolferen/if/releases{/id}","deployments_url":"https://api.github.com/repos/wolferen/if/deployments","created_at":"2017-12-22T14:57:36Z","updated_at":"2017-12-26T18:25:04Z","pushed_at":"2018-02-02T15:14:22Z","git_url":"git://github.com/wolferen/if.git","ssh_url":"[email protected]:wolferen/if.git","clone_url":"https://github.com/wolferen/if.git","svn_url":"https://github.com/wolferen/if","homepage":null,"size":1133,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wolferen/if/pulls/15"},"html":{"href":"https://github.com/wolferen/if/pull/15"},"issue":{"href":"https://api.github.com/repos/wolferen/if/issues/15"},"comments":{"href":"https://api.github.com/repos/wolferen/if/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/wolferen/if/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/wolferen/if/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wolferen/if/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/wolferen/if/statuses/8184ab457abc29e7289111479790abf9301227ed"}},"author_association":"OWNER"}} | {
"id": 115124893,
"name": "wolferen/if",
"url": "https://api.github.com/repos/wolferen/if"
} | {
"id": 37482,
"login": "yuriy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/37482?",
"url": "https://api.github.com/users/yuriy"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-02-02T15:25:22 | 7189867997 | {"actor":{"display_login":"yuriy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/morichi2590/chat-space/pulls/comments/234479865","pull_request_review_id":176126549,"id":234479865,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQ3OTg2NQ==","diff_hunk":"@@ -0,0 +1,12 @@\n+%div{:class => \"chat_side_lists_gruop\"}\n+ = link_to 'http://google.co.jp' do\n+ %div{:class => \"chat_side_lists_group_title\"}\n+ %h Groupタイトル\n+ %div{:class => \"chat_side_lists_group_text\"}\n+ %p グループ内のメッセージのやりとりプレビュー\n+%div{:class => \"chat_side_lists_gruop\"}","path":"app/views/messages/_group.html.haml","position":7,"original_position":7,"commit_id":"bd177e1ae24fbb263447712e8332d86b4be8bab5","original_commit_id":"bd177e1ae24fbb263447712e8332d86b4be8bab5","user":{"login":"yutakatahira","id":22128119,"node_id":"MDQ6VXNlcjIyMTI4MTE5","avatar_url":"https://avatars3.githubusercontent.com/u/22128119?v=4","gravatar_id":"","url":"https://api.github.com/users/yutakatahira","html_url":"https://github.com/yutakatahira","followers_url":"https://api.github.com/users/yutakatahira/followers","following_url":"https://api.github.com/users/yutakatahira/following{/other_user}","gists_url":"https://api.github.com/users/yutakatahira/gists{/gist_id}","starred_url":"https://api.github.com/users/yutakatahira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yutakatahira/subscriptions","organizations_url":"https://api.github.com/users/yutakatahira/orgs","repos_url":"https://api.github.com/users/yutakatahira/repos","events_url":"https://api.github.com/users/yutakatahira/events{/privacy}","received_events_url":"https://api.github.com/users/yutakatahira/received_events","type":"User","site_admin":false},"body":"%divよりいい方法があるので、調べてみましょう！","created_at":"2018-11-19T02:31:18Z","updated_at":"2018-11-19T02:41:52Z","html_url":"https://github.com/morichi2590/chat-space/pull/2#discussion_r234479865","pull_request_url":"https://api.github.com/repos/morichi2590/chat-space/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/morichi2590/chat-space/pulls/comments/234479865"},"html":{"href":"https://github.com/morichi2590/chat-space/pull/2#discussion_r234479865"},"pull_request":{"href":"https://api.github.com/repos/morichi2590/chat-space/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/morichi2590/chat-space/pulls/2","id":231726611,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzI2NjEx","html_url":"https://github.com/morichi2590/chat-space/pull/2","diff_url":"https://github.com/morichi2590/chat-space/pull/2.diff","patch_url":"https://github.com/morichi2590/chat-space/pull/2.patch","issue_url":"https://api.github.com/repos/morichi2590/chat-space/issues/2","number":2,"state":"open","locked":false,"title":"ChatUI markup","user":{"login":"morichi2590","id":44493629,"node_id":"MDQ6VXNlcjQ0NDkzNjI5","avatar_url":"https://avatars3.githubusercontent.com/u/44493629?v=4","gravatar_id":"","url":"https://api.github.com/users/morichi2590","html_url":"https://github.com/morichi2590","followers_url":"https://api.github.com/users/morichi2590/followers","following_url":"https://api.github.com/users/morichi2590/following{/other_user}","gists_url":"https://api.github.com/users/morichi2590/gists{/gist_id}","starred_url":"https://api.github.com/users/morichi2590/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morichi2590/subscriptions","organizations_url":"https://api.github.com/users/morichi2590/orgs","repos_url":"https://api.github.com/users/morichi2590/repos","events_url":"https://api.github.com/users/morichi2590/events{/privacy}","received_events_url":"https://api.github.com/users/morichi2590/received_events","type":"User","site_admin":false},"body":"lesson8のchatspeceフロント画面実装を行いましたので確認お願いいたします。\r\n<img width=\"1440\" alt=\"2018-11-19 10 08 24\" src=\"https://user-images.githubusercontent.com/44493629/48681007-1bb8ce80-ebe3-11e8-92f4-7b4cb1819c3f.png\">","created_at":"2018-11-17T12:57:58Z","updated_at":"2018-11-19T02:41:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52e1ee04f815286acc35ef307821bb446a3d38d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/morichi2590/chat-space/pulls/2/commits","review_comments_url":"https://api.github.com/repos/morichi2590/chat-space/pulls/2/comments","review_comment_url":"https://api.github.com/repos/morichi2590/chat-space/pulls/comments{/number}","comments_url":"https://api.github.com/repos/morichi2590/chat-space/issues/2/comments","statuses_url":"https://api.github.com/repos/morichi2590/chat-space/statuses/bd177e1ae24fbb263447712e8332d86b4be8bab5","head":{"label":"morichi2590:ChatUI-markup","ref":"ChatUI-markup","sha":"bd177e1ae24fbb263447712e8332d86b4be8bab5","user":{"login":"morichi2590","id":44493629,"node_id":"MDQ6VXNlcjQ0NDkzNjI5","avatar_url":"https://avatars3.githubusercontent.com/u/44493629?v=4","gravatar_id":"","url":"https://api.github.com/users/morichi2590","html_url":"https://github.com/morichi2590","followers_url":"https://api.github.com/users/morichi2590/followers","following_url":"https://api.github.com/users/morichi2590/following{/other_user}","gists_url":"https://api.github.com/users/morichi2590/gists{/gist_id}","starred_url":"https://api.github.com/users/morichi2590/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morichi2590/subscriptions","organizations_url":"https://api.github.com/users/morichi2590/orgs","repos_url":"https://api.github.com/users/morichi2590/repos","events_url":"https://api.github.com/users/morichi2590/events{/privacy}","received_events_url":"https://api.github.com/users/morichi2590/received_events","type":"User","site_admin":false},"repo":{"id":156958338,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5NTgzMzg=","name":"chat-space","full_name":"morichi2590/chat-space","private":false,"owner":{"login":"morichi2590","id":44493629,"node_id":"MDQ6VXNlcjQ0NDkzNjI5","avatar_url":"https://avatars3.githubusercontent.com/u/44493629?v=4","gravatar_id":"","url":"https://api.github.com/users/morichi2590","html_url":"https://github.com/morichi2590","followers_url":"https://api.github.com/users/morichi2590/followers","following_url":"https://api.github.com/users/morichi2590/following{/other_user}","gists_url":"https://api.github.com/users/morichi2590/gists{/gist_id}","starred_url":"https://api.github.com/users/morichi2590/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morichi2590/subscriptions","organizations_url":"https://api.github.com/users/morichi2590/orgs","repos_url":"https://api.github.com/users/morichi2590/repos","events_url":"https://api.github.com/users/morichi2590/events{/privacy}","received_events_url":"https://api.github.com/users/morichi2590/received_events","type":"User","site_admin":false},"html_url":"https://github.com/morichi2590/chat-space","description":null,"fork":false,"url":"https://api.github.com/repos/morichi2590/chat-space","forks_url":"https://api.github.com/repos/morichi2590/chat-space/forks","keys_url":"https://api.github.com/repos/morichi2590/chat-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morichi2590/chat-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morichi2590/chat-space/teams","hooks_url":"https://api.github.com/repos/morichi2590/chat-space/hooks","issue_events_url":"https://api.github.com/repos/morichi2590/chat-space/issues/events{/number}","events_url":"https://api.github.com/repos/morichi2590/chat-space/events","assignees_url":"https://api.github.com/repos/morichi2590/chat-space/assignees{/user}","branches_url":"https://api.github.com/repos/morichi2590/chat-space/branches{/branch}","tags_url":"https://api.github.com/repos/morichi2590/chat-space/tags","blobs_url":"https://api.github.com/repos/morichi2590/chat-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morichi2590/chat-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morichi2590/chat-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/morichi2590/chat-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morichi2590/chat-space/statuses/{sha}","languages_url":"https://api.github.com/repos/morichi2590/chat-space/languages","stargazers_url":"https://api.github.com/repos/morichi2590/chat-space/stargazers","contributors_url":"https://api.github.com/repos/morichi2590/chat-space/contributors","subscribers_url":"https://api.github.com/repos/morichi2590/chat-space/subscribers","subscription_url":"https://api.github.com/repos/morichi2590/chat-space/subscription","commits_url":"https://api.github.com/repos/morichi2590/chat-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/morichi2590/chat-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/morichi2590/chat-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/morichi2590/chat-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/morichi2590/chat-space/contents/{+path}","compare_url":"https://api.github.com/repos/morichi2590/chat-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morichi2590/chat-space/merges","archive_url":"https://api.github.com/repos/morichi2590/chat-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morichi2590/chat-space/downloads","issues_url":"https://api.github.com/repos/morichi2590/chat-space/issues{/number}","pulls_url":"https://api.github.com/repos/morichi2590/chat-space/pulls{/number}","milestones_url":"https://api.github.com/repos/morichi2590/chat-space/milestones{/number}","notifications_url":"https://api.github.com/repos/morichi2590/chat-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morichi2590/chat-space/labels{/name}","releases_url":"https://api.github.com/repos/morichi2590/chat-space/releases{/id}","deployments_url":"https://api.github.com/repos/morichi2590/chat-space/deployments","created_at":"2018-11-10T07:28:59Z","updated_at":"2018-11-14T05:36:50Z","pushed_at":"2018-11-17T12:57:59Z","git_url":"git://github.com/morichi2590/chat-space.git","ssh_url":"[email protected]:morichi2590/chat-space.git","clone_url":"https://github.com/morichi2590/chat-space.git","svn_url":"https://github.com/morichi2590/chat-space","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"morichi2590:master","ref":"master","sha":"4f1a52b4dc5cbb0043def73f144d34dd9fe37471","user":{"login":"morichi2590","id":44493629,"node_id":"MDQ6VXNlcjQ0NDkzNjI5","avatar_url":"https://avatars3.githubusercontent.com/u/44493629?v=4","gravatar_id":"","url":"https://api.github.com/users/morichi2590","html_url":"https://github.com/morichi2590","followers_url":"https://api.github.com/users/morichi2590/followers","following_url":"https://api.github.com/users/morichi2590/following{/other_user}","gists_url":"https://api.github.com/users/morichi2590/gists{/gist_id}","starred_url":"https://api.github.com/users/morichi2590/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morichi2590/subscriptions","organizations_url":"https://api.github.com/users/morichi2590/orgs","repos_url":"https://api.github.com/users/morichi2590/repos","events_url":"https://api.github.com/users/morichi2590/events{/privacy}","received_events_url":"https://api.github.com/users/morichi2590/received_events","type":"User","site_admin":false},"repo":{"id":156958338,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5NTgzMzg=","name":"chat-space","full_name":"morichi2590/chat-space","private":false,"owner":{"login":"morichi2590","id":44493629,"node_id":"MDQ6VXNlcjQ0NDkzNjI5","avatar_url":"https://avatars3.githubusercontent.com/u/44493629?v=4","gravatar_id":"","url":"https://api.github.com/users/morichi2590","html_url":"https://github.com/morichi2590","followers_url":"https://api.github.com/users/morichi2590/followers","following_url":"https://api.github.com/users/morichi2590/following{/other_user}","gists_url":"https://api.github.com/users/morichi2590/gists{/gist_id}","starred_url":"https://api.github.com/users/morichi2590/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morichi2590/subscriptions","organizations_url":"https://api.github.com/users/morichi2590/orgs","repos_url":"https://api.github.com/users/morichi2590/repos","events_url":"https://api.github.com/users/morichi2590/events{/privacy}","received_events_url":"https://api.github.com/users/morichi2590/received_events","type":"User","site_admin":false},"html_url":"https://github.com/morichi2590/chat-space","description":null,"fork":false,"url":"https://api.github.com/repos/morichi2590/chat-space","forks_url":"https://api.github.com/repos/morichi2590/chat-space/forks","keys_url":"https://api.github.com/repos/morichi2590/chat-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morichi2590/chat-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morichi2590/chat-space/teams","hooks_url":"https://api.github.com/repos/morichi2590/chat-space/hooks","issue_events_url":"https://api.github.com/repos/morichi2590/chat-space/issues/events{/number}","events_url":"https://api.github.com/repos/morichi2590/chat-space/events","assignees_url":"https://api.github.com/repos/morichi2590/chat-space/assignees{/user}","branches_url":"https://api.github.com/repos/morichi2590/chat-space/branches{/branch}","tags_url":"https://api.github.com/repos/morichi2590/chat-space/tags","blobs_url":"https://api.github.com/repos/morichi2590/chat-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morichi2590/chat-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morichi2590/chat-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/morichi2590/chat-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morichi2590/chat-space/statuses/{sha}","languages_url":"https://api.github.com/repos/morichi2590/chat-space/languages","stargazers_url":"https://api.github.com/repos/morichi2590/chat-space/stargazers","contributors_url":"https://api.github.com/repos/morichi2590/chat-space/contributors","subscribers_url":"https://api.github.com/repos/morichi2590/chat-space/subscribers","subscription_url":"https://api.github.com/repos/morichi2590/chat-space/subscription","commits_url":"https://api.github.com/repos/morichi2590/chat-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/morichi2590/chat-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/morichi2590/chat-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/morichi2590/chat-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/morichi2590/chat-space/contents/{+path}","compare_url":"https://api.github.com/repos/morichi2590/chat-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morichi2590/chat-space/merges","archive_url":"https://api.github.com/repos/morichi2590/chat-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morichi2590/chat-space/downloads","issues_url":"https://api.github.com/repos/morichi2590/chat-space/issues{/number}","pulls_url":"https://api.github.com/repos/morichi2590/chat-space/pulls{/number}","milestones_url":"https://api.github.com/repos/morichi2590/chat-space/milestones{/number}","notifications_url":"https://api.github.com/repos/morichi2590/chat-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morichi2590/chat-space/labels{/name}","releases_url":"https://api.github.com/repos/morichi2590/chat-space/releases{/id}","deployments_url":"https://api.github.com/repos/morichi2590/chat-space/deployments","created_at":"2018-11-10T07:28:59Z","updated_at":"2018-11-14T05:36:50Z","pushed_at":"2018-11-17T12:57:59Z","git_url":"git://github.com/morichi2590/chat-space.git","ssh_url":"[email protected]:morichi2590/chat-space.git","clone_url":"https://github.com/morichi2590/chat-space.git","svn_url":"https://github.com/morichi2590/chat-space","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/morichi2590/chat-space/pulls/2"},"html":{"href":"https://github.com/morichi2590/chat-space/pull/2"},"issue":{"href":"https://api.github.com/repos/morichi2590/chat-space/issues/2"},"comments":{"href":"https://api.github.com/repos/morichi2590/chat-space/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/morichi2590/chat-space/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/morichi2590/chat-space/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/morichi2590/chat-space/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/morichi2590/chat-space/statuses/bd177e1ae24fbb263447712e8332d86b4be8bab5"}},"author_association":"OWNER"}} | {
"id": 156958338,
"name": "morichi2590/chat-space",
"url": "https://api.github.com/repos/morichi2590/chat-space"
} | {
"id": 22128119,
"login": "yutakatahira",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22128119?",
"url": "https://api.github.com/users/yutakatahira"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-11-19T02:31:18 | 8610069495 | {"actor":{"display_login":"yutakatahira"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/meryldelpech/SWING/pulls/comments/237839624","pull_request_review_id":180238305,"id":237839624,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgzOTYyNA==","diff_hunk":"@@ -33,11 +33,15 @@\n <%= f.input :location %>\n <%= f.input :title %>\n <%= f.input :begin_date, as: :string, required: false, input_html: {class: \"datepicker\"} %>\n- <%= f.input :end_date, as: :string, required: false, input_html: {class: \"datepicker\"} %>\n+ <%= f.input :end_date, as: :string, required: false, input_html: {id: \"end-date\", class: \"datepicker\"} %>\n+ <p id=\"total-price\"></p>\n+ <p id=\"fees\"></p>\n+ <p id=\"total-net\"></p>","path":"app/views/talents/show.html.erb","position":17,"original_position":17,"commit_id":"397cd033cd52fdcb056bad7a2acee2fc1ccbf3d0","original_commit_id":"397cd033cd52fdcb056bad7a2acee2fc1ccbf3d0","user":{"login":"QLGordon","id":9365772,"node_id":"MDQ6VXNlcjkzNjU3NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/9365772?v=4","gravatar_id":"","url":"https://api.github.com/users/QLGordon","html_url":"https://github.com/QLGordon","followers_url":"https://api.github.com/users/QLGordon/followers","following_url":"https://api.github.com/users/QLGordon/following{/other_user}","gists_url":"https://api.github.com/users/QLGordon/gists{/gist_id}","starred_url":"https://api.github.com/users/QLGordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QLGordon/subscriptions","organizations_url":"https://api.github.com/users/QLGordon/orgs","repos_url":"https://api.github.com/users/QLGordon/repos","events_url":"https://api.github.com/users/QLGordon/events{/privacy}","received_events_url":"https://api.github.com/users/QLGordon/received_events","type":"User","site_admin":false},"body":"attention JS","created_at":"2018-11-30T12:09:06Z","updated_at":"2018-11-30T12:09:06Z","html_url":"https://github.com/meryldelpech/SWING/pull/38#discussion_r237839624","pull_request_url":"https://api.github.com/repos/meryldelpech/SWING/pulls/38","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/meryldelpech/SWING/pulls/comments/237839624"},"html":{"href":"https://github.com/meryldelpech/SWING/pull/38#discussion_r237839624"},"pull_request":{"href":"https://api.github.com/repos/meryldelpech/SWING/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/meryldelpech/SWING/pulls/38","id":234965431,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTY1NDMx","html_url":"https://github.com/meryldelpech/SWING/pull/38","diff_url":"https://github.com/meryldelpech/SWING/pull/38.diff","patch_url":"https://github.com/meryldelpech/SWING/pull/38.patch","issue_url":"https://api.github.com/repos/meryldelpech/SWING/issues/38","number":38,"state":"open","locked":false,"title":"calcul et affichage automatique du tarif avant de booker","user":{"login":"meryldelpech","id":41571754,"node_id":"MDQ6VXNlcjQxNTcxNzU0","avatar_url":"https://avatars1.githubusercontent.com/u/41571754?v=4","gravatar_id":"","url":"https://api.github.com/users/meryldelpech","html_url":"https://github.com/meryldelpech","followers_url":"https://api.github.com/users/meryldelpech/followers","following_url":"https://api.github.com/users/meryldelpech/following{/other_user}","gists_url":"https://api.github.com/users/meryldelpech/gists{/gist_id}","starred_url":"https://api.github.com/users/meryldelpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meryldelpech/subscriptions","organizations_url":"https://api.github.com/users/meryldelpech/orgs","repos_url":"https://api.github.com/users/meryldelpech/repos","events_url":"https://api.github.com/users/meryldelpech/events{/privacy}","received_events_url":"https://api.github.com/users/meryldelpech/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-30T12:01:49Z","updated_at":"2018-11-30T12:09:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb60733a24057c625294c29d388a87eead242f20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/meryldelpech/SWING/pulls/38/commits","review_comments_url":"https://api.github.com/repos/meryldelpech/SWING/pulls/38/comments","review_comment_url":"https://api.github.com/repos/meryldelpech/SWING/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meryldelpech/SWING/issues/38/comments","statuses_url":"https://api.github.com/repos/meryldelpech/SWING/statuses/397cd033cd52fdcb056bad7a2acee2fc1ccbf3d0","head":{"label":"meryldelpech:ajax_price","ref":"ajax_price","sha":"397cd033cd52fdcb056bad7a2acee2fc1ccbf3d0","user":{"login":"meryldelpech","id":41571754,"node_id":"MDQ6VXNlcjQxNTcxNzU0","avatar_url":"https://avatars1.githubusercontent.com/u/41571754?v=4","gravatar_id":"","url":"https://api.github.com/users/meryldelpech","html_url":"https://github.com/meryldelpech","followers_url":"https://api.github.com/users/meryldelpech/followers","following_url":"https://api.github.com/users/meryldelpech/following{/other_user}","gists_url":"https://api.github.com/users/meryldelpech/gists{/gist_id}","starred_url":"https://api.github.com/users/meryldelpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meryldelpech/subscriptions","organizations_url":"https://api.github.com/users/meryldelpech/orgs","repos_url":"https://api.github.com/users/meryldelpech/repos","events_url":"https://api.github.com/users/meryldelpech/events{/privacy}","received_events_url":"https://api.github.com/users/meryldelpech/received_events","type":"User","site_admin":false},"repo":{"id":159178697,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkxNzg2OTc=","name":"SWING","full_name":"meryldelpech/SWING","private":false,"owner":{"login":"meryldelpech","id":41571754,"node_id":"MDQ6VXNlcjQxNTcxNzU0","avatar_url":"https://avatars1.githubusercontent.com/u/41571754?v=4","gravatar_id":"","url":"https://api.github.com/users/meryldelpech","html_url":"https://github.com/meryldelpech","followers_url":"https://api.github.com/users/meryldelpech/followers","following_url":"https://api.github.com/users/meryldelpech/following{/other_user}","gists_url":"https://api.github.com/users/meryldelpech/gists{/gist_id}","starred_url":"https://api.github.com/users/meryldelpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meryldelpech/subscriptions","organizations_url":"https://api.github.com/users/meryldelpech/orgs","repos_url":"https://api.github.com/users/meryldelpech/repos","events_url":"https://api.github.com/users/meryldelpech/events{/privacy}","received_events_url":"https://api.github.com/users/meryldelpech/received_events","type":"User","site_admin":false},"html_url":"https://github.com/meryldelpech/SWING","description":null,"fork":false,"url":"https://api.github.com/repos/meryldelpech/SWING","forks_url":"https://api.github.com/repos/meryldelpech/SWING/forks","keys_url":"https://api.github.com/repos/meryldelpech/SWING/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meryldelpech/SWING/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meryldelpech/SWING/teams","hooks_url":"https://api.github.com/repos/meryldelpech/SWING/hooks","issue_events_url":"https://api.github.com/repos/meryldelpech/SWING/issues/events{/number}","events_url":"https://api.github.com/repos/meryldelpech/SWING/events","assignees_url":"https://api.github.com/repos/meryldelpech/SWING/assignees{/user}","branches_url":"https://api.github.com/repos/meryldelpech/SWING/branches{/branch}","tags_url":"https://api.github.com/repos/meryldelpech/SWING/tags","blobs_url":"https://api.github.com/repos/meryldelpech/SWING/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meryldelpech/SWING/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meryldelpech/SWING/git/refs{/sha}","trees_url":"https://api.github.com/repos/meryldelpech/SWING/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meryldelpech/SWING/statuses/{sha}","languages_url":"https://api.github.com/repos/meryldelpech/SWING/languages","stargazers_url":"https://api.github.com/repos/meryldelpech/SWING/stargazers","contributors_url":"https://api.github.com/repos/meryldelpech/SWING/contributors","subscribers_url":"https://api.github.com/repos/meryldelpech/SWING/subscribers","subscription_url":"https://api.github.com/repos/meryldelpech/SWING/subscription","commits_url":"https://api.github.com/repos/meryldelpech/SWING/commits{/sha}","git_commits_url":"https://api.github.com/repos/meryldelpech/SWING/git/commits{/sha}","comments_url":"https://api.github.com/repos/meryldelpech/SWING/comments{/number}","issue_comment_url":"https://api.github.com/repos/meryldelpech/SWING/issues/comments{/number}","contents_url":"https://api.github.com/repos/meryldelpech/SWING/contents/{+path}","compare_url":"https://api.github.com/repos/meryldelpech/SWING/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meryldelpech/SWING/merges","archive_url":"https://api.github.com/repos/meryldelpech/SWING/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meryldelpech/SWING/downloads","issues_url":"https://api.github.com/repos/meryldelpech/SWING/issues{/number}","pulls_url":"https://api.github.com/repos/meryldelpech/SWING/pulls{/number}","milestones_url":"https://api.github.com/repos/meryldelpech/SWING/milestones{/number}","notifications_url":"https://api.github.com/repos/meryldelpech/SWING/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meryldelpech/SWING/labels{/name}","releases_url":"https://api.github.com/repos/meryldelpech/SWING/releases{/id}","deployments_url":"https://api.github.com/repos/meryldelpech/SWING/deployments","created_at":"2018-11-26T14:02:13Z","updated_at":"2018-11-30T09:57:29Z","pushed_at":"2018-11-30T12:01:49Z","git_url":"git://github.com/meryldelpech/SWING.git","ssh_url":"[email protected]:meryldelpech/SWING.git","clone_url":"https://github.com/meryldelpech/SWING.git","svn_url":"https://github.com/meryldelpech/SWING","homepage":null,"size":2915,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"meryldelpech:master","ref":"master","sha":"551ccd15395fde4391178ed4865b86359f2864ef","user":{"login":"meryldelpech","id":41571754,"node_id":"MDQ6VXNlcjQxNTcxNzU0","avatar_url":"https://avatars1.githubusercontent.com/u/41571754?v=4","gravatar_id":"","url":"https://api.github.com/users/meryldelpech","html_url":"https://github.com/meryldelpech","followers_url":"https://api.github.com/users/meryldelpech/followers","following_url":"https://api.github.com/users/meryldelpech/following{/other_user}","gists_url":"https://api.github.com/users/meryldelpech/gists{/gist_id}","starred_url":"https://api.github.com/users/meryldelpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meryldelpech/subscriptions","organizations_url":"https://api.github.com/users/meryldelpech/orgs","repos_url":"https://api.github.com/users/meryldelpech/repos","events_url":"https://api.github.com/users/meryldelpech/events{/privacy}","received_events_url":"https://api.github.com/users/meryldelpech/received_events","type":"User","site_admin":false},"repo":{"id":159178697,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkxNzg2OTc=","name":"SWING","full_name":"meryldelpech/SWING","private":false,"owner":{"login":"meryldelpech","id":41571754,"node_id":"MDQ6VXNlcjQxNTcxNzU0","avatar_url":"https://avatars1.githubusercontent.com/u/41571754?v=4","gravatar_id":"","url":"https://api.github.com/users/meryldelpech","html_url":"https://github.com/meryldelpech","followers_url":"https://api.github.com/users/meryldelpech/followers","following_url":"https://api.github.com/users/meryldelpech/following{/other_user}","gists_url":"https://api.github.com/users/meryldelpech/gists{/gist_id}","starred_url":"https://api.github.com/users/meryldelpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meryldelpech/subscriptions","organizations_url":"https://api.github.com/users/meryldelpech/orgs","repos_url":"https://api.github.com/users/meryldelpech/repos","events_url":"https://api.github.com/users/meryldelpech/events{/privacy}","received_events_url":"https://api.github.com/users/meryldelpech/received_events","type":"User","site_admin":false},"html_url":"https://github.com/meryldelpech/SWING","description":null,"fork":false,"url":"https://api.github.com/repos/meryldelpech/SWING","forks_url":"https://api.github.com/repos/meryldelpech/SWING/forks","keys_url":"https://api.github.com/repos/meryldelpech/SWING/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meryldelpech/SWING/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meryldelpech/SWING/teams","hooks_url":"https://api.github.com/repos/meryldelpech/SWING/hooks","issue_events_url":"https://api.github.com/repos/meryldelpech/SWING/issues/events{/number}","events_url":"https://api.github.com/repos/meryldelpech/SWING/events","assignees_url":"https://api.github.com/repos/meryldelpech/SWING/assignees{/user}","branches_url":"https://api.github.com/repos/meryldelpech/SWING/branches{/branch}","tags_url":"https://api.github.com/repos/meryldelpech/SWING/tags","blobs_url":"https://api.github.com/repos/meryldelpech/SWING/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meryldelpech/SWING/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meryldelpech/SWING/git/refs{/sha}","trees_url":"https://api.github.com/repos/meryldelpech/SWING/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meryldelpech/SWING/statuses/{sha}","languages_url":"https://api.github.com/repos/meryldelpech/SWING/languages","stargazers_url":"https://api.github.com/repos/meryldelpech/SWING/stargazers","contributors_url":"https://api.github.com/repos/meryldelpech/SWING/contributors","subscribers_url":"https://api.github.com/repos/meryldelpech/SWING/subscribers","subscription_url":"https://api.github.com/repos/meryldelpech/SWING/subscription","commits_url":"https://api.github.com/repos/meryldelpech/SWING/commits{/sha}","git_commits_url":"https://api.github.com/repos/meryldelpech/SWING/git/commits{/sha}","comments_url":"https://api.github.com/repos/meryldelpech/SWING/comments{/number}","issue_comment_url":"https://api.github.com/repos/meryldelpech/SWING/issues/comments{/number}","contents_url":"https://api.github.com/repos/meryldelpech/SWING/contents/{+path}","compare_url":"https://api.github.com/repos/meryldelpech/SWING/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meryldelpech/SWING/merges","archive_url":"https://api.github.com/repos/meryldelpech/SWING/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meryldelpech/SWING/downloads","issues_url":"https://api.github.com/repos/meryldelpech/SWING/issues{/number}","pulls_url":"https://api.github.com/repos/meryldelpech/SWING/pulls{/number}","milestones_url":"https://api.github.com/repos/meryldelpech/SWING/milestones{/number}","notifications_url":"https://api.github.com/repos/meryldelpech/SWING/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meryldelpech/SWING/labels{/name}","releases_url":"https://api.github.com/repos/meryldelpech/SWING/releases{/id}","deployments_url":"https://api.github.com/repos/meryldelpech/SWING/deployments","created_at":"2018-11-26T14:02:13Z","updated_at":"2018-11-30T09:57:29Z","pushed_at":"2018-11-30T12:01:49Z","git_url":"git://github.com/meryldelpech/SWING.git","ssh_url":"[email protected]:meryldelpech/SWING.git","clone_url":"https://github.com/meryldelpech/SWING.git","svn_url":"https://github.com/meryldelpech/SWING","homepage":null,"size":2915,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meryldelpech/SWING/pulls/38"},"html":{"href":"https://github.com/meryldelpech/SWING/pull/38"},"issue":{"href":"https://api.github.com/repos/meryldelpech/SWING/issues/38"},"comments":{"href":"https://api.github.com/repos/meryldelpech/SWING/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/meryldelpech/SWING/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/meryldelpech/SWING/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meryldelpech/SWING/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/meryldelpech/SWING/statuses/397cd033cd52fdcb056bad7a2acee2fc1ccbf3d0"}},"author_association":"OWNER"}} | {
"id": 159178697,
"name": "meryldelpech/SWING",
"url": "https://api.github.com/repos/meryldelpech/SWING"
} | {
"id": 9365772,
"login": "QLGordon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9365772?",
"url": "https://api.github.com/users/QLGordon"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-11-30T12:09:06 | 8675820310 | {"actor":{"display_login":"QLGordon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ctlai95/python-tetris/pulls/comments/186223201","pull_request_review_id":117769206,"id":186223201,"diff_hunk":"@@ -65,7 +152,7 @@ def test_hold_current_tetromino():\n b.hold_current_tetromino()\n assert b.held_tetromino.id == last_tetromino_id\n # not dropped yet, so held tetromino should be unchanged\n- b.hold_current_tetromino()\n+ b.hold_current_tetromino() ","path":"src/board/board_test.py","position":137,"original_position":137,"commit_id":"13ae8263df0bf4aead1720adf66b3ceaaf36273a","original_commit_id":"13ae8263df0bf4aead1720adf66b3ceaaf36273a","user":{"login":"ctlai95","id":16008563,"avatar_url":"https://avatars3.githubusercontent.com/u/16008563?v=4","gravatar_id":"","url":"https://api.github.com/users/ctlai95","html_url":"https://github.com/ctlai95","followers_url":"https://api.github.com/users/ctlai95/followers","following_url":"https://api.github.com/users/ctlai95/following{/other_user}","gists_url":"https://api.github.com/users/ctlai95/gists{/gist_id}","starred_url":"https://api.github.com/users/ctlai95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctlai95/subscriptions","organizations_url":"https://api.github.com/users/ctlai95/orgs","repos_url":"https://api.github.com/users/ctlai95/repos","events_url":"https://api.github.com/users/ctlai95/events{/privacy}","received_events_url":"https://api.github.com/users/ctlai95/received_events","type":"User","site_admin":false},"body":"remove that whitespace please","created_at":"2018-05-04T21:13:08Z","updated_at":"2018-05-04T21:13:38Z","html_url":"https://github.com/ctlai95/python-tetris/pull/24#discussion_r186223201","pull_request_url":"https://api.github.com/repos/ctlai95/python-tetris/pulls/24","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ctlai95/python-tetris/pulls/comments/186223201"},"html":{"href":"https://github.com/ctlai95/python-tetris/pull/24#discussion_r186223201"},"pull_request":{"href":"https://api.github.com/repos/ctlai95/python-tetris/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/ctlai95/python-tetris/pulls/24","id":184817360,"html_url":"https://github.com/ctlai95/python-tetris/pull/24","diff_url":"https://github.com/ctlai95/python-tetris/pull/24.diff","patch_url":"https://github.com/ctlai95/python-tetris/pull/24.patch","issue_url":"https://api.github.com/repos/ctlai95/python-tetris/issues/24","number":24,"state":"open","locked":false,"title":"Henry/new line clear","user":{"login":"henrytran28","id":9893456,"avatar_url":"https://avatars2.githubusercontent.com/u/9893456?v=4","gravatar_id":"","url":"https://api.github.com/users/henrytran28","html_url":"https://github.com/henrytran28","followers_url":"https://api.github.com/users/henrytran28/followers","following_url":"https://api.github.com/users/henrytran28/following{/other_user}","gists_url":"https://api.github.com/users/henrytran28/gists{/gist_id}","starred_url":"https://api.github.com/users/henrytran28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrytran28/subscriptions","organizations_url":"https://api.github.com/users/henrytran28/orgs","repos_url":"https://api.github.com/users/henrytran28/repos","events_url":"https://api.github.com/users/henrytran28/events{/privacy}","received_events_url":"https://api.github.com/users/henrytran28/received_events","type":"User","site_admin":false},"body":"Removes new lines when it is full and drops the rest of the lines to fill the empty lines.","created_at":"2018-04-29T04:12:19Z","updated_at":"2018-05-04T21:13:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5d3cd984f83ca7f332b95bd94f1f6a7668c7bf6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ctlai95/python-tetris/pulls/24/commits","review_comments_url":"https://api.github.com/repos/ctlai95/python-tetris/pulls/24/comments","review_comment_url":"https://api.github.com/repos/ctlai95/python-tetris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ctlai95/python-tetris/issues/24/comments","statuses_url":"https://api.github.com/repos/ctlai95/python-tetris/statuses/13ae8263df0bf4aead1720adf66b3ceaaf36273a","head":{"label":"ctlai95:henry/new-line-clear","ref":"henry/new-line-clear","sha":"13ae8263df0bf4aead1720adf66b3ceaaf36273a","user":{"login":"ctlai95","id":16008563,"avatar_url":"https://avatars3.githubusercontent.com/u/16008563?v=4","gravatar_id":"","url":"https://api.github.com/users/ctlai95","html_url":"https://github.com/ctlai95","followers_url":"https://api.github.com/users/ctlai95/followers","following_url":"https://api.github.com/users/ctlai95/following{/other_user}","gists_url":"https://api.github.com/users/ctlai95/gists{/gist_id}","starred_url":"https://api.github.com/users/ctlai95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctlai95/subscriptions","organizations_url":"https://api.github.com/users/ctlai95/orgs","repos_url":"https://api.github.com/users/ctlai95/repos","events_url":"https://api.github.com/users/ctlai95/events{/privacy}","received_events_url":"https://api.github.com/users/ctlai95/received_events","type":"User","site_admin":false},"repo":{"id":96954301,"name":"python-tetris","full_name":"ctlai95/python-tetris","owner":{"login":"ctlai95","id":16008563,"avatar_url":"https://avatars3.githubusercontent.com/u/16008563?v=4","gravatar_id":"","url":"https://api.github.com/users/ctlai95","html_url":"https://github.com/ctlai95","followers_url":"https://api.github.com/users/ctlai95/followers","following_url":"https://api.github.com/users/ctlai95/following{/other_user}","gists_url":"https://api.github.com/users/ctlai95/gists{/gist_id}","starred_url":"https://api.github.com/users/ctlai95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctlai95/subscriptions","organizations_url":"https://api.github.com/users/ctlai95/orgs","repos_url":"https://api.github.com/users/ctlai95/repos","events_url":"https://api.github.com/users/ctlai95/events{/privacy}","received_events_url":"https://api.github.com/users/ctlai95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctlai95/python-tetris","description":null,"fork":false,"url":"https://api.github.com/repos/ctlai95/python-tetris","forks_url":"https://api.github.com/repos/ctlai95/python-tetris/forks","keys_url":"https://api.github.com/repos/ctlai95/python-tetris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctlai95/python-tetris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctlai95/python-tetris/teams","hooks_url":"https://api.github.com/repos/ctlai95/python-tetris/hooks","issue_events_url":"https://api.github.com/repos/ctlai95/python-tetris/issues/events{/number}","events_url":"https://api.github.com/repos/ctlai95/python-tetris/events","assignees_url":"https://api.github.com/repos/ctlai95/python-tetris/assignees{/user}","branches_url":"https://api.github.com/repos/ctlai95/python-tetris/branches{/branch}","tags_url":"https://api.github.com/repos/ctlai95/python-tetris/tags","blobs_url":"https://api.github.com/repos/ctlai95/python-tetris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctlai95/python-tetris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctlai95/python-tetris/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctlai95/python-tetris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctlai95/python-tetris/statuses/{sha}","languages_url":"https://api.github.com/repos/ctlai95/python-tetris/languages","stargazers_url":"https://api.github.com/repos/ctlai95/python-tetris/stargazers","contributors_url":"https://api.github.com/repos/ctlai95/python-tetris/contributors","subscribers_url":"https://api.github.com/repos/ctlai95/python-tetris/subscribers","subscription_url":"https://api.github.com/repos/ctlai95/python-tetris/subscription","commits_url":"https://api.github.com/repos/ctlai95/python-tetris/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctlai95/python-tetris/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctlai95/python-tetris/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctlai95/python-tetris/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctlai95/python-tetris/contents/{+path}","compare_url":"https://api.github.com/repos/ctlai95/python-tetris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctlai95/python-tetris/merges","archive_url":"https://api.github.com/repos/ctlai95/python-tetris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctlai95/python-tetris/downloads","issues_url":"https://api.github.com/repos/ctlai95/python-tetris/issues{/number}","pulls_url":"https://api.github.com/repos/ctlai95/python-tetris/pulls{/number}","milestones_url":"https://api.github.com/repos/ctlai95/python-tetris/milestones{/number}","notifications_url":"https://api.github.com/repos/ctlai95/python-tetris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctlai95/python-tetris/labels{/name}","releases_url":"https://api.github.com/repos/ctlai95/python-tetris/releases{/id}","deployments_url":"https://api.github.com/repos/ctlai95/python-tetris/deployments","created_at":"2017-07-12T01:56:44Z","updated_at":"2018-05-03T22:39:03Z","pushed_at":"2018-05-04T20:02:40Z","git_url":"git://github.com/ctlai95/python-tetris.git","ssh_url":"[email protected]:ctlai95/python-tetris.git","clone_url":"https://github.com/ctlai95/python-tetris.git","svn_url":"https://github.com/ctlai95/python-tetris","homepage":null,"size":9201,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ctlai95:master","ref":"master","sha":"7692beb20013a1c6828467acb62bbe4511c29cdf","user":{"login":"ctlai95","id":16008563,"avatar_url":"https://avatars3.githubusercontent.com/u/16008563?v=4","gravatar_id":"","url":"https://api.github.com/users/ctlai95","html_url":"https://github.com/ctlai95","followers_url":"https://api.github.com/users/ctlai95/followers","following_url":"https://api.github.com/users/ctlai95/following{/other_user}","gists_url":"https://api.github.com/users/ctlai95/gists{/gist_id}","starred_url":"https://api.github.com/users/ctlai95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctlai95/subscriptions","organizations_url":"https://api.github.com/users/ctlai95/orgs","repos_url":"https://api.github.com/users/ctlai95/repos","events_url":"https://api.github.com/users/ctlai95/events{/privacy}","received_events_url":"https://api.github.com/users/ctlai95/received_events","type":"User","site_admin":false},"repo":{"id":96954301,"name":"python-tetris","full_name":"ctlai95/python-tetris","owner":{"login":"ctlai95","id":16008563,"avatar_url":"https://avatars3.githubusercontent.com/u/16008563?v=4","gravatar_id":"","url":"https://api.github.com/users/ctlai95","html_url":"https://github.com/ctlai95","followers_url":"https://api.github.com/users/ctlai95/followers","following_url":"https://api.github.com/users/ctlai95/following{/other_user}","gists_url":"https://api.github.com/users/ctlai95/gists{/gist_id}","starred_url":"https://api.github.com/users/ctlai95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctlai95/subscriptions","organizations_url":"https://api.github.com/users/ctlai95/orgs","repos_url":"https://api.github.com/users/ctlai95/repos","events_url":"https://api.github.com/users/ctlai95/events{/privacy}","received_events_url":"https://api.github.com/users/ctlai95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctlai95/python-tetris","description":null,"fork":false,"url":"https://api.github.com/repos/ctlai95/python-tetris","forks_url":"https://api.github.com/repos/ctlai95/python-tetris/forks","keys_url":"https://api.github.com/repos/ctlai95/python-tetris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctlai95/python-tetris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctlai95/python-tetris/teams","hooks_url":"https://api.github.com/repos/ctlai95/python-tetris/hooks","issue_events_url":"https://api.github.com/repos/ctlai95/python-tetris/issues/events{/number}","events_url":"https://api.github.com/repos/ctlai95/python-tetris/events","assignees_url":"https://api.github.com/repos/ctlai95/python-tetris/assignees{/user}","branches_url":"https://api.github.com/repos/ctlai95/python-tetris/branches{/branch}","tags_url":"https://api.github.com/repos/ctlai95/python-tetris/tags","blobs_url":"https://api.github.com/repos/ctlai95/python-tetris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctlai95/python-tetris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctlai95/python-tetris/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctlai95/python-tetris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctlai95/python-tetris/statuses/{sha}","languages_url":"https://api.github.com/repos/ctlai95/python-tetris/languages","stargazers_url":"https://api.github.com/repos/ctlai95/python-tetris/stargazers","contributors_url":"https://api.github.com/repos/ctlai95/python-tetris/contributors","subscribers_url":"https://api.github.com/repos/ctlai95/python-tetris/subscribers","subscription_url":"https://api.github.com/repos/ctlai95/python-tetris/subscription","commits_url":"https://api.github.com/repos/ctlai95/python-tetris/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctlai95/python-tetris/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctlai95/python-tetris/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctlai95/python-tetris/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctlai95/python-tetris/contents/{+path}","compare_url":"https://api.github.com/repos/ctlai95/python-tetris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctlai95/python-tetris/merges","archive_url":"https://api.github.com/repos/ctlai95/python-tetris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctlai95/python-tetris/downloads","issues_url":"https://api.github.com/repos/ctlai95/python-tetris/issues{/number}","pulls_url":"https://api.github.com/repos/ctlai95/python-tetris/pulls{/number}","milestones_url":"https://api.github.com/repos/ctlai95/python-tetris/milestones{/number}","notifications_url":"https://api.github.com/repos/ctlai95/python-tetris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctlai95/python-tetris/labels{/name}","releases_url":"https://api.github.com/repos/ctlai95/python-tetris/releases{/id}","deployments_url":"https://api.github.com/repos/ctlai95/python-tetris/deployments","created_at":"2017-07-12T01:56:44Z","updated_at":"2018-05-03T22:39:03Z","pushed_at":"2018-05-04T20:02:40Z","git_url":"git://github.com/ctlai95/python-tetris.git","ssh_url":"[email protected]:ctlai95/python-tetris.git","clone_url":"https://github.com/ctlai95/python-tetris.git","svn_url":"https://github.com/ctlai95/python-tetris","homepage":null,"size":9201,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ctlai95/python-tetris/pulls/24"},"html":{"href":"https://github.com/ctlai95/python-tetris/pull/24"},"issue":{"href":"https://api.github.com/repos/ctlai95/python-tetris/issues/24"},"comments":{"href":"https://api.github.com/repos/ctlai95/python-tetris/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/ctlai95/python-tetris/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/ctlai95/python-tetris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ctlai95/python-tetris/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/ctlai95/python-tetris/statuses/13ae8263df0bf4aead1720adf66b3ceaaf36273a"}},"author_association":"COLLABORATOR"}} | {
"id": 96954301,
"name": "ctlai95/python-tetris",
"url": "https://api.github.com/repos/ctlai95/python-tetris"
} | {
"id": 16008563,
"login": "ctlai95",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16008563?",
"url": "https://api.github.com/users/ctlai95"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-05-04T21:13:08 | 7630807238 | {"actor":{"display_login":"ctlai95"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/codingjoe/django-s3file/pulls/comments/173490247","pull_request_review_id":102695310,"id":173490247,"diff_hunk":"@@ -80,15 +80,13 @@\n }\n \n function clickSubmit (e) {\n- e.preventDefault()\n let submitButton = e.target\n let form = submitButton.closest('form')\n const submitInput = document.createElement('input')\n submitInput.type = 'hidden'\n submitInput.value = submitButton.value || true\n submitInput.name = submitButton.name\n form.appendChild(submitInput)\n- uploadS3Inputs(form)","path":"s3file/static/s3file/js/s3file.js","position":12,"original_position":12,"commit_id":"ab6dbddcd5bc84c91ff6727d5f741a8f9813d913","original_commit_id":"ab6dbddcd5bc84c91ff6727d5f741a8f9813d913","user":{"login":"tilboerner","id":2019313,"avatar_url":"https://avatars2.githubusercontent.com/u/2019313?v=4","gravatar_id":"","url":"https://api.github.com/users/tilboerner","html_url":"https://github.com/tilboerner","followers_url":"https://api.github.com/users/tilboerner/followers","following_url":"https://api.github.com/users/tilboerner/following{/other_user}","gists_url":"https://api.github.com/users/tilboerner/gists{/gist_id}","starred_url":"https://api.github.com/users/tilboerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilboerner/subscriptions","organizations_url":"https://api.github.com/users/tilboerner/orgs","repos_url":"https://api.github.com/users/tilboerner/repos","events_url":"https://api.github.com/users/tilboerner/events{/privacy}","received_events_url":"https://api.github.com/users/tilboerner/received_events","type":"User","site_admin":false},"body":"It still works because with the other removed line in this patch, the default action for the click event is *not* prevented. That default action is to cause a 'submit' event on the form. (Note that the function containing the change is not handling the submit event itself, but the click event leading up to it.)\r\n\r\nThe submit event is then handled by the `form.onsubmit`, which was registered below, on 'DOMContentLoaded': \r\n\r\nhttps://github.com/codingjoe/django-s3file/blob/7e7656d31ccef881c9f31a3c54091bbba7631085/s3file/static/s3file/js/s3file.js#L111-L114\r\n\r\nIf I understand JS correctly, things proceed synchronously, and we can trust at this point that if the submit was triggered by a click, the click handler has added the hidden input to the form.\r\n\r\nI found one caveat: When manually dispatching a click event for the button, it needs to be a `MouseEvent` to trigger the submit logic; a generic `Event` triggers the click handler, but does not default to submitting the form. Without the change in this PR, any old `Event` would do. \r\n\r\nHowever, the canonical [click event *is* a MouseEvent][], and gets dispatched as such even when triggering the button by keyboard or calling `button.click()`. All things considered, I think it's better to make the proposed change and honor the expectation of other submit handlers that they will be called on submit, rather than cater to code that uses non-standard, non-`MouseEvents` to trigger submit clicks.\r\n\r\n[click event *is* a MouseEvent]: https://developer.mozilla.org/en-US/docs/Web/Events/click","created_at":"2018-03-09T15:59:16Z","updated_at":"2018-03-09T15:59:16Z","html_url":"https://github.com/codingjoe/django-s3file/pull/79#discussion_r173490247","pull_request_url":"https://api.github.com/repos/codingjoe/django-s3file/pulls/79","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/codingjoe/django-s3file/pulls/comments/173490247"},"html":{"href":"https://github.com/codingjoe/django-s3file/pull/79#discussion_r173490247"},"pull_request":{"href":"https://api.github.com/repos/codingjoe/django-s3file/pulls/79"}},"in_reply_to_id":173449305},"pull_request":{"url":"https://api.github.com/repos/codingjoe/django-s3file/pulls/79","id":173982110,"html_url":"https://github.com/codingjoe/django-s3file/pull/79","diff_url":"https://github.com/codingjoe/django-s3file/pull/79.diff","patch_url":"https://github.com/codingjoe/django-s3file/pull/79.patch","issue_url":"https://api.github.com/repos/codingjoe/django-s3file/issues/79","number":79,"state":"open","locked":false,"title":"Remove submit logic from click event handler","user":{"login":"tilboerner","id":2019313,"avatar_url":"https://avatars2.githubusercontent.com/u/2019313?v=4","gravatar_id":"","url":"https://api.github.com/users/tilboerner","html_url":"https://github.com/tilboerner","followers_url":"https://api.github.com/users/tilboerner/followers","following_url":"https://api.github.com/users/tilboerner/following{/other_user}","gists_url":"https://api.github.com/users/tilboerner/gists{/gist_id}","starred_url":"https://api.github.com/users/tilboerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilboerner/subscriptions","organizations_url":"https://api.github.com/users/tilboerner/orgs","repos_url":"https://api.github.com/users/tilboerner/repos","events_url":"https://api.github.com/users/tilboerner/events{/privacy}","received_events_url":"https://api.github.com/users/tilboerner/received_events","type":"User","site_admin":false},"body":"There is no need to have submit logic take place in the on click handler. It only deals with the mouse click event, *not* the submit event that will follow. \r\n\r\nBefore this change, blocking the default action on the click event prevents a following submit event from taking place: `form.onsubmit` and other registered listeners waiting for a 'submit' will never be called.","created_at":"2018-03-09T11:27:53Z","updated_at":"2018-03-09T15:59:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"048da87eca2845febc4ddfd31aab8d98c7f37ff9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codingjoe/django-s3file/pulls/79/commits","review_comments_url":"https://api.github.com/repos/codingjoe/django-s3file/pulls/79/comments","review_comment_url":"https://api.github.com/repos/codingjoe/django-s3file/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codingjoe/django-s3file/issues/79/comments","statuses_url":"https://api.github.com/repos/codingjoe/django-s3file/statuses/ab6dbddcd5bc84c91ff6727d5f741a8f9813d913","head":{"label":"tilboerner:patch-1","ref":"patch-1","sha":"ab6dbddcd5bc84c91ff6727d5f741a8f9813d913","user":{"login":"tilboerner","id":2019313,"avatar_url":"https://avatars2.githubusercontent.com/u/2019313?v=4","gravatar_id":"","url":"https://api.github.com/users/tilboerner","html_url":"https://github.com/tilboerner","followers_url":"https://api.github.com/users/tilboerner/followers","following_url":"https://api.github.com/users/tilboerner/following{/other_user}","gists_url":"https://api.github.com/users/tilboerner/gists{/gist_id}","starred_url":"https://api.github.com/users/tilboerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilboerner/subscriptions","organizations_url":"https://api.github.com/users/tilboerner/orgs","repos_url":"https://api.github.com/users/tilboerner/repos","events_url":"https://api.github.com/users/tilboerner/events{/privacy}","received_events_url":"https://api.github.com/users/tilboerner/received_events","type":"User","site_admin":false},"repo":{"id":124531261,"name":"django-s3file","full_name":"tilboerner/django-s3file","owner":{"login":"tilboerner","id":2019313,"avatar_url":"https://avatars2.githubusercontent.com/u/2019313?v=4","gravatar_id":"","url":"https://api.github.com/users/tilboerner","html_url":"https://github.com/tilboerner","followers_url":"https://api.github.com/users/tilboerner/followers","following_url":"https://api.github.com/users/tilboerner/following{/other_user}","gists_url":"https://api.github.com/users/tilboerner/gists{/gist_id}","starred_url":"https://api.github.com/users/tilboerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilboerner/subscriptions","organizations_url":"https://api.github.com/users/tilboerner/orgs","repos_url":"https://api.github.com/users/tilboerner/repos","events_url":"https://api.github.com/users/tilboerner/events{/privacy}","received_events_url":"https://api.github.com/users/tilboerner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tilboerner/django-s3file","description":"A lightweight file upload input for Django and Amazon S3","fork":true,"url":"https://api.github.com/repos/tilboerner/django-s3file","forks_url":"https://api.github.com/repos/tilboerner/django-s3file/forks","keys_url":"https://api.github.com/repos/tilboerner/django-s3file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilboerner/django-s3file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilboerner/django-s3file/teams","hooks_url":"https://api.github.com/repos/tilboerner/django-s3file/hooks","issue_events_url":"https://api.github.com/repos/tilboerner/django-s3file/issues/events{/number}","events_url":"https://api.github.com/repos/tilboerner/django-s3file/events","assignees_url":"https://api.github.com/repos/tilboerner/django-s3file/assignees{/user}","branches_url":"https://api.github.com/repos/tilboerner/django-s3file/branches{/branch}","tags_url":"https://api.github.com/repos/tilboerner/django-s3file/tags","blobs_url":"https://api.github.com/repos/tilboerner/django-s3file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilboerner/django-s3file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilboerner/django-s3file/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilboerner/django-s3file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilboerner/django-s3file/statuses/{sha}","languages_url":"https://api.github.com/repos/tilboerner/django-s3file/languages","stargazers_url":"https://api.github.com/repos/tilboerner/django-s3file/stargazers","contributors_url":"https://api.github.com/repos/tilboerner/django-s3file/contributors","subscribers_url":"https://api.github.com/repos/tilboerner/django-s3file/subscribers","subscription_url":"https://api.github.com/repos/tilboerner/django-s3file/subscription","commits_url":"https://api.github.com/repos/tilboerner/django-s3file/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilboerner/django-s3file/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilboerner/django-s3file/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilboerner/django-s3file/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilboerner/django-s3file/contents/{+path}","compare_url":"https://api.github.com/repos/tilboerner/django-s3file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilboerner/django-s3file/merges","archive_url":"https://api.github.com/repos/tilboerner/django-s3file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilboerner/django-s3file/downloads","issues_url":"https://api.github.com/repos/tilboerner/django-s3file/issues{/number}","pulls_url":"https://api.github.com/repos/tilboerner/django-s3file/pulls{/number}","milestones_url":"https://api.github.com/repos/tilboerner/django-s3file/milestones{/number}","notifications_url":"https://api.github.com/repos/tilboerner/django-s3file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilboerner/django-s3file/labels{/name}","releases_url":"https://api.github.com/repos/tilboerner/django-s3file/releases{/id}","deployments_url":"https://api.github.com/repos/tilboerner/django-s3file/deployments","created_at":"2018-03-09T11:20:24Z","updated_at":"2018-03-09T11:20:26Z","pushed_at":"2018-03-09T11:27:38Z","git_url":"git://github.com/tilboerner/django-s3file.git","ssh_url":"[email protected]:tilboerner/django-s3file.git","clone_url":"https://github.com/tilboerner/django-s3file.git","svn_url":"https://github.com/tilboerner/django-s3file","homepage":"","size":371,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codingjoe:master","ref":"master","sha":"7e7656d31ccef881c9f31a3c54091bbba7631085","user":{"login":"codingjoe","id":1772890,"avatar_url":"https://avatars1.githubusercontent.com/u/1772890?v=4","gravatar_id":"","url":"https://api.github.com/users/codingjoe","html_url":"https://github.com/codingjoe","followers_url":"https://api.github.com/users/codingjoe/followers","following_url":"https://api.github.com/users/codingjoe/following{/other_user}","gists_url":"https://api.github.com/users/codingjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/codingjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingjoe/subscriptions","organizations_url":"https://api.github.com/users/codingjoe/orgs","repos_url":"https://api.github.com/users/codingjoe/repos","events_url":"https://api.github.com/users/codingjoe/events{/privacy}","received_events_url":"https://api.github.com/users/codingjoe/received_events","type":"User","site_admin":false},"repo":{"id":26443516,"name":"django-s3file","full_name":"codingjoe/django-s3file","owner":{"login":"codingjoe","id":1772890,"avatar_url":"https://avatars1.githubusercontent.com/u/1772890?v=4","gravatar_id":"","url":"https://api.github.com/users/codingjoe","html_url":"https://github.com/codingjoe","followers_url":"https://api.github.com/users/codingjoe/followers","following_url":"https://api.github.com/users/codingjoe/following{/other_user}","gists_url":"https://api.github.com/users/codingjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/codingjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingjoe/subscriptions","organizations_url":"https://api.github.com/users/codingjoe/orgs","repos_url":"https://api.github.com/users/codingjoe/repos","events_url":"https://api.github.com/users/codingjoe/events{/privacy}","received_events_url":"https://api.github.com/users/codingjoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codingjoe/django-s3file","description":"A lightweight file upload input for Django and Amazon S3","fork":false,"url":"https://api.github.com/repos/codingjoe/django-s3file","forks_url":"https://api.github.com/repos/codingjoe/django-s3file/forks","keys_url":"https://api.github.com/repos/codingjoe/django-s3file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codingjoe/django-s3file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codingjoe/django-s3file/teams","hooks_url":"https://api.github.com/repos/codingjoe/django-s3file/hooks","issue_events_url":"https://api.github.com/repos/codingjoe/django-s3file/issues/events{/number}","events_url":"https://api.github.com/repos/codingjoe/django-s3file/events","assignees_url":"https://api.github.com/repos/codingjoe/django-s3file/assignees{/user}","branches_url":"https://api.github.com/repos/codingjoe/django-s3file/branches{/branch}","tags_url":"https://api.github.com/repos/codingjoe/django-s3file/tags","blobs_url":"https://api.github.com/repos/codingjoe/django-s3file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codingjoe/django-s3file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codingjoe/django-s3file/git/refs{/sha}","trees_url":"https://api.github.com/repos/codingjoe/django-s3file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codingjoe/django-s3file/statuses/{sha}","languages_url":"https://api.github.com/repos/codingjoe/django-s3file/languages","stargazers_url":"https://api.github.com/repos/codingjoe/django-s3file/stargazers","contributors_url":"https://api.github.com/repos/codingjoe/django-s3file/contributors","subscribers_url":"https://api.github.com/repos/codingjoe/django-s3file/subscribers","subscription_url":"https://api.github.com/repos/codingjoe/django-s3file/subscription","commits_url":"https://api.github.com/repos/codingjoe/django-s3file/commits{/sha}","git_commits_url":"https://api.github.com/repos/codingjoe/django-s3file/git/commits{/sha}","comments_url":"https://api.github.com/repos/codingjoe/django-s3file/comments{/number}","issue_comment_url":"https://api.github.com/repos/codingjoe/django-s3file/issues/comments{/number}","contents_url":"https://api.github.com/repos/codingjoe/django-s3file/contents/{+path}","compare_url":"https://api.github.com/repos/codingjoe/django-s3file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codingjoe/django-s3file/merges","archive_url":"https://api.github.com/repos/codingjoe/django-s3file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codingjoe/django-s3file/downloads","issues_url":"https://api.github.com/repos/codingjoe/django-s3file/issues{/number}","pulls_url":"https://api.github.com/repos/codingjoe/django-s3file/pulls{/number}","milestones_url":"https://api.github.com/repos/codingjoe/django-s3file/milestones{/number}","notifications_url":"https://api.github.com/repos/codingjoe/django-s3file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codingjoe/django-s3file/labels{/name}","releases_url":"https://api.github.com/repos/codingjoe/django-s3file/releases{/id}","deployments_url":"https://api.github.com/repos/codingjoe/django-s3file/deployments","created_at":"2014-11-10T15:57:22Z","updated_at":"2018-01-03T12:49:00Z","pushed_at":"2018-03-09T11:27:54Z","git_url":"git://github.com/codingjoe/django-s3file.git","ssh_url":"[email protected]:codingjoe/django-s3file.git","clone_url":"https://github.com/codingjoe/django-s3file.git","svn_url":"https://github.com/codingjoe/django-s3file","homepage":"","size":368,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":1,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codingjoe/django-s3file/pulls/79"},"html":{"href":"https://github.com/codingjoe/django-s3file/pull/79"},"issue":{"href":"https://api.github.com/repos/codingjoe/django-s3file/issues/79"},"comments":{"href":"https://api.github.com/repos/codingjoe/django-s3file/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/codingjoe/django-s3file/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/codingjoe/django-s3file/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codingjoe/django-s3file/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/codingjoe/django-s3file/statuses/ab6dbddcd5bc84c91ff6727d5f741a8f9813d913"}},"author_association":"NONE"}} | {
"id": 26443516,
"name": "codingjoe/django-s3file",
"url": "https://api.github.com/repos/codingjoe/django-s3file"
} | {
"id": 2019313,
"login": "tilboerner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2019313?",
"url": "https://api.github.com/users/tilboerner"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-03-09T15:59:16 | 7356795307 | {"actor":{"display_login":"tilboerner"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/comments/216220322","pull_request_review_id":153649786,"id":216220322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIyMDMyMg==","diff_hunk":"@@ -0,0 +1,15 @@\n+a='add'\n+length=(len(a))\n+print(length)\n+i=0\n+if(length>3):\n+ for i in range (length):\n+\n+ if a[length-3:length]=='ing':\n+ b=a+'ly'","path":"task1.py","position":9,"original_position":9,"commit_id":"cb57c4826f477c6a140b729bb433316fdd7f0117","original_commit_id":"cb57c4826f477c6a140b729bb433316fdd7f0117","user":{"login":"saadyousafarbi","id":30112155,"node_id":"MDQ6VXNlcjMwMTEyMTU1","avatar_url":"https://avatars3.githubusercontent.com/u/30112155?v=4","gravatar_id":"","url":"https://api.github.com/users/saadyousafarbi","html_url":"https://github.com/saadyousafarbi","followers_url":"https://api.github.com/users/saadyousafarbi/followers","following_url":"https://api.github.com/users/saadyousafarbi/following{/other_user}","gists_url":"https://api.github.com/users/saadyousafarbi/gists{/gist_id}","starred_url":"https://api.github.com/users/saadyousafarbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saadyousafarbi/subscriptions","organizations_url":"https://api.github.com/users/saadyousafarbi/orgs","repos_url":"https://api.github.com/users/saadyousafarbi/repos","events_url":"https://api.github.com/users/saadyousafarbi/events{/privacy}","received_events_url":"https://api.github.com/users/saadyousafarbi/received_events","type":"User","site_admin":false},"body":"rename variable to something meaningful","created_at":"2018-09-10T07:25:46Z","updated_at":"2018-09-10T07:30:36Z","html_url":"https://github.com/saimnaveed/APPLICATION/pull/2#discussion_r216220322","pull_request_url":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/comments/216220322"},"html":{"href":"https://github.com/saimnaveed/APPLICATION/pull/2#discussion_r216220322"},"pull_request":{"href":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/2","id":213921817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTIxODE3","html_url":"https://github.com/saimnaveed/APPLICATION/pull/2","diff_url":"https://github.com/saimnaveed/APPLICATION/pull/2.diff","patch_url":"https://github.com/saimnaveed/APPLICATION/pull/2.patch","issue_url":"https://api.github.com/repos/saimnaveed/APPLICATION/issues/2","number":2,"state":"open","locked":false,"title":"Initial Task","user":{"login":"saimnaveed","id":43000682,"node_id":"MDQ6VXNlcjQzMDAwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/43000682?v=4","gravatar_id":"","url":"https://api.github.com/users/saimnaveed","html_url":"https://github.com/saimnaveed","followers_url":"https://api.github.com/users/saimnaveed/followers","following_url":"https://api.github.com/users/saimnaveed/following{/other_user}","gists_url":"https://api.github.com/users/saimnaveed/gists{/gist_id}","starred_url":"https://api.github.com/users/saimnaveed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimnaveed/subscriptions","organizations_url":"https://api.github.com/users/saimnaveed/orgs","repos_url":"https://api.github.com/users/saimnaveed/repos","events_url":"https://api.github.com/users/saimnaveed/events{/privacy}","received_events_url":"https://api.github.com/users/saimnaveed/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-07T13:04:47Z","updated_at":"2018-09-10T07:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2be3df35143ff469d3319eacbc402046bd04c42a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/2/commits","review_comments_url":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/2/comments","review_comment_url":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saimnaveed/APPLICATION/issues/2/comments","statuses_url":"https://api.github.com/repos/saimnaveed/APPLICATION/statuses/cb57c4826f477c6a140b729bb433316fdd7f0117","head":{"label":"saimnaveed:assignment","ref":"assignment","sha":"cb57c4826f477c6a140b729bb433316fdd7f0117","user":{"login":"saimnaveed","id":43000682,"node_id":"MDQ6VXNlcjQzMDAwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/43000682?v=4","gravatar_id":"","url":"https://api.github.com/users/saimnaveed","html_url":"https://github.com/saimnaveed","followers_url":"https://api.github.com/users/saimnaveed/followers","following_url":"https://api.github.com/users/saimnaveed/following{/other_user}","gists_url":"https://api.github.com/users/saimnaveed/gists{/gist_id}","starred_url":"https://api.github.com/users/saimnaveed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimnaveed/subscriptions","organizations_url":"https://api.github.com/users/saimnaveed/orgs","repos_url":"https://api.github.com/users/saimnaveed/repos","events_url":"https://api.github.com/users/saimnaveed/events{/privacy}","received_events_url":"https://api.github.com/users/saimnaveed/received_events","type":"User","site_admin":false},"repo":{"id":147520320,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1MjAzMjA=","name":"APPLICATION","full_name":"saimnaveed/APPLICATION","owner":{"login":"saimnaveed","id":43000682,"node_id":"MDQ6VXNlcjQzMDAwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/43000682?v=4","gravatar_id":"","url":"https://api.github.com/users/saimnaveed","html_url":"https://github.com/saimnaveed","followers_url":"https://api.github.com/users/saimnaveed/followers","following_url":"https://api.github.com/users/saimnaveed/following{/other_user}","gists_url":"https://api.github.com/users/saimnaveed/gists{/gist_id}","starred_url":"https://api.github.com/users/saimnaveed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimnaveed/subscriptions","organizations_url":"https://api.github.com/users/saimnaveed/orgs","repos_url":"https://api.github.com/users/saimnaveed/repos","events_url":"https://api.github.com/users/saimnaveed/events{/privacy}","received_events_url":"https://api.github.com/users/saimnaveed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saimnaveed/APPLICATION","description":"New One","fork":false,"url":"https://api.github.com/repos/saimnaveed/APPLICATION","forks_url":"https://api.github.com/repos/saimnaveed/APPLICATION/forks","keys_url":"https://api.github.com/repos/saimnaveed/APPLICATION/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saimnaveed/APPLICATION/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saimnaveed/APPLICATION/teams","hooks_url":"https://api.github.com/repos/saimnaveed/APPLICATION/hooks","issue_events_url":"https://api.github.com/repos/saimnaveed/APPLICATION/issues/events{/number}","events_url":"https://api.github.com/repos/saimnaveed/APPLICATION/events","assignees_url":"https://api.github.com/repos/saimnaveed/APPLICATION/assignees{/user}","branches_url":"https://api.github.com/repos/saimnaveed/APPLICATION/branches{/branch}","tags_url":"https://api.github.com/repos/saimnaveed/APPLICATION/tags","blobs_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/refs{/sha}","trees_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saimnaveed/APPLICATION/statuses/{sha}","languages_url":"https://api.github.com/repos/saimnaveed/APPLICATION/languages","stargazers_url":"https://api.github.com/repos/saimnaveed/APPLICATION/stargazers","contributors_url":"https://api.github.com/repos/saimnaveed/APPLICATION/contributors","subscribers_url":"https://api.github.com/repos/saimnaveed/APPLICATION/subscribers","subscription_url":"https://api.github.com/repos/saimnaveed/APPLICATION/subscription","commits_url":"https://api.github.com/repos/saimnaveed/APPLICATION/commits{/sha}","git_commits_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/commits{/sha}","comments_url":"https://api.github.com/repos/saimnaveed/APPLICATION/comments{/number}","issue_comment_url":"https://api.github.com/repos/saimnaveed/APPLICATION/issues/comments{/number}","contents_url":"https://api.github.com/repos/saimnaveed/APPLICATION/contents/{+path}","compare_url":"https://api.github.com/repos/saimnaveed/APPLICATION/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saimnaveed/APPLICATION/merges","archive_url":"https://api.github.com/repos/saimnaveed/APPLICATION/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saimnaveed/APPLICATION/downloads","issues_url":"https://api.github.com/repos/saimnaveed/APPLICATION/issues{/number}","pulls_url":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls{/number}","milestones_url":"https://api.github.com/repos/saimnaveed/APPLICATION/milestones{/number}","notifications_url":"https://api.github.com/repos/saimnaveed/APPLICATION/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saimnaveed/APPLICATION/labels{/name}","releases_url":"https://api.github.com/repos/saimnaveed/APPLICATION/releases{/id}","deployments_url":"https://api.github.com/repos/saimnaveed/APPLICATION/deployments","created_at":"2018-09-05T13:14:49Z","updated_at":"2018-09-07T12:41:16Z","pushed_at":"2018-09-07T13:50:24Z","git_url":"git://github.com/saimnaveed/APPLICATION.git","ssh_url":"[email protected]:saimnaveed/APPLICATION.git","clone_url":"https://github.com/saimnaveed/APPLICATION.git","svn_url":"https://github.com/saimnaveed/APPLICATION","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"saimnaveed:master","ref":"master","sha":"06bad0ef7defddea63312b11e662e48b314bd193","user":{"login":"saimnaveed","id":43000682,"node_id":"MDQ6VXNlcjQzMDAwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/43000682?v=4","gravatar_id":"","url":"https://api.github.com/users/saimnaveed","html_url":"https://github.com/saimnaveed","followers_url":"https://api.github.com/users/saimnaveed/followers","following_url":"https://api.github.com/users/saimnaveed/following{/other_user}","gists_url":"https://api.github.com/users/saimnaveed/gists{/gist_id}","starred_url":"https://api.github.com/users/saimnaveed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimnaveed/subscriptions","organizations_url":"https://api.github.com/users/saimnaveed/orgs","repos_url":"https://api.github.com/users/saimnaveed/repos","events_url":"https://api.github.com/users/saimnaveed/events{/privacy}","received_events_url":"https://api.github.com/users/saimnaveed/received_events","type":"User","site_admin":false},"repo":{"id":147520320,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1MjAzMjA=","name":"APPLICATION","full_name":"saimnaveed/APPLICATION","owner":{"login":"saimnaveed","id":43000682,"node_id":"MDQ6VXNlcjQzMDAwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/43000682?v=4","gravatar_id":"","url":"https://api.github.com/users/saimnaveed","html_url":"https://github.com/saimnaveed","followers_url":"https://api.github.com/users/saimnaveed/followers","following_url":"https://api.github.com/users/saimnaveed/following{/other_user}","gists_url":"https://api.github.com/users/saimnaveed/gists{/gist_id}","starred_url":"https://api.github.com/users/saimnaveed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimnaveed/subscriptions","organizations_url":"https://api.github.com/users/saimnaveed/orgs","repos_url":"https://api.github.com/users/saimnaveed/repos","events_url":"https://api.github.com/users/saimnaveed/events{/privacy}","received_events_url":"https://api.github.com/users/saimnaveed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saimnaveed/APPLICATION","description":"New One","fork":false,"url":"https://api.github.com/repos/saimnaveed/APPLICATION","forks_url":"https://api.github.com/repos/saimnaveed/APPLICATION/forks","keys_url":"https://api.github.com/repos/saimnaveed/APPLICATION/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saimnaveed/APPLICATION/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saimnaveed/APPLICATION/teams","hooks_url":"https://api.github.com/repos/saimnaveed/APPLICATION/hooks","issue_events_url":"https://api.github.com/repos/saimnaveed/APPLICATION/issues/events{/number}","events_url":"https://api.github.com/repos/saimnaveed/APPLICATION/events","assignees_url":"https://api.github.com/repos/saimnaveed/APPLICATION/assignees{/user}","branches_url":"https://api.github.com/repos/saimnaveed/APPLICATION/branches{/branch}","tags_url":"https://api.github.com/repos/saimnaveed/APPLICATION/tags","blobs_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/refs{/sha}","trees_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saimnaveed/APPLICATION/statuses/{sha}","languages_url":"https://api.github.com/repos/saimnaveed/APPLICATION/languages","stargazers_url":"https://api.github.com/repos/saimnaveed/APPLICATION/stargazers","contributors_url":"https://api.github.com/repos/saimnaveed/APPLICATION/contributors","subscribers_url":"https://api.github.com/repos/saimnaveed/APPLICATION/subscribers","subscription_url":"https://api.github.com/repos/saimnaveed/APPLICATION/subscription","commits_url":"https://api.github.com/repos/saimnaveed/APPLICATION/commits{/sha}","git_commits_url":"https://api.github.com/repos/saimnaveed/APPLICATION/git/commits{/sha}","comments_url":"https://api.github.com/repos/saimnaveed/APPLICATION/comments{/number}","issue_comment_url":"https://api.github.com/repos/saimnaveed/APPLICATION/issues/comments{/number}","contents_url":"https://api.github.com/repos/saimnaveed/APPLICATION/contents/{+path}","compare_url":"https://api.github.com/repos/saimnaveed/APPLICATION/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saimnaveed/APPLICATION/merges","archive_url":"https://api.github.com/repos/saimnaveed/APPLICATION/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saimnaveed/APPLICATION/downloads","issues_url":"https://api.github.com/repos/saimnaveed/APPLICATION/issues{/number}","pulls_url":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls{/number}","milestones_url":"https://api.github.com/repos/saimnaveed/APPLICATION/milestones{/number}","notifications_url":"https://api.github.com/repos/saimnaveed/APPLICATION/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saimnaveed/APPLICATION/labels{/name}","releases_url":"https://api.github.com/repos/saimnaveed/APPLICATION/releases{/id}","deployments_url":"https://api.github.com/repos/saimnaveed/APPLICATION/deployments","created_at":"2018-09-05T13:14:49Z","updated_at":"2018-09-07T12:41:16Z","pushed_at":"2018-09-07T13:50:24Z","git_url":"git://github.com/saimnaveed/APPLICATION.git","ssh_url":"[email protected]:saimnaveed/APPLICATION.git","clone_url":"https://github.com/saimnaveed/APPLICATION.git","svn_url":"https://github.com/saimnaveed/APPLICATION","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/2"},"html":{"href":"https://github.com/saimnaveed/APPLICATION/pull/2"},"issue":{"href":"https://api.github.com/repos/saimnaveed/APPLICATION/issues/2"},"comments":{"href":"https://api.github.com/repos/saimnaveed/APPLICATION/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saimnaveed/APPLICATION/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/saimnaveed/APPLICATION/statuses/cb57c4826f477c6a140b729bb433316fdd7f0117"}},"author_association":"OWNER"}} | {
"id": 147520320,
"name": "saimnaveed/APPLICATION",
"url": "https://api.github.com/repos/saimnaveed/APPLICATION"
} | {
"id": 30112155,
"login": "saadyousafarbi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30112155?",
"url": "https://api.github.com/users/saadyousafarbi"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-09-10T07:25:46 | 8238227845 | {"actor":{"display_login":"saadyousafarbi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/comments/194460177","pull_request_review_id":127637018,"id":194460177,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDQ2MDE3Nw==","diff_hunk":"@@ -53,17 +63,27 @@\n <TextBlock Grid.Row=\"0\" Grid.Column=\"1\" Style=\"{StaticResource DetectorName}\" Text=\"{Binding SmartDetectorName}\" />\n \n <TextBlock Grid.Row=\"1\" Grid.Column=\"0\" Style=\"{StaticResource ControlText}\" Text=\"Filter by subcription\" Margin=\"0,5,0,0\" />\n- <ComboBox Grid.Row=\"1\" Grid.Column=\"1\" Margin=\"0,0,0,20\" HorizontalAlignment=\"Left\" MinWidth=\"130\"\n- ItemsSource=\"{Binding Path=ReadSubscriptionsTask.Result}\" SelectedItem=\"{Binding Path=SelectedSubscription}\"\n+ <ComboBox Grid.Row=\"1\" Grid.Column=\"1\" Margin=\"0,0,0,20\" x:Name=\"SubscriptionsComboBox\" ","path":"src/SDK/MonitoringApplianceEmulator/Controls/SmartDetectorConfigurationControl.xaml","position":28,"original_position":28,"commit_id":"11e56c6c8ce248b1963531759d1af93dcb565be5","original_commit_id":"11e56c6c8ce248b1963531759d1af93dcb565be5","user":{"login":"bermanguy","id":12019839,"node_id":"MDQ6VXNlcjEyMDE5ODM5","avatar_url":"https://avatars2.githubusercontent.com/u/12019839?v=4","gravatar_id":"","url":"https://api.github.com/users/bermanguy","html_url":"https://github.com/bermanguy","followers_url":"https://api.github.com/users/bermanguy/followers","following_url":"https://api.github.com/users/bermanguy/following{/other_user}","gists_url":"https://api.github.com/users/bermanguy/gists{/gist_id}","starred_url":"https://api.github.com/users/bermanguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bermanguy/subscriptions","organizations_url":"https://api.github.com/users/bermanguy/orgs","repos_url":"https://api.github.com/users/bermanguy/repos","events_url":"https://api.github.com/users/bermanguy/events{/privacy}","received_events_url":"https://api.github.com/users/bermanguy/received_events","type":"User","site_admin":false},"body":"in order to be able to bind a command to the itemsSource onChange event\r\n\r\n---\r\nIn reply to: [194324985](https://github.com/liadtal/Smart-Alerts/pull/165#discussion_r194324985) [](ancestors = 194324985)","created_at":"2018-06-11T16:10:17Z","updated_at":"2018-06-11T16:10:18Z","html_url":"https://github.com/liadtal/Smart-Alerts/pull/165#discussion_r194460177","pull_request_url":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/165","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/comments/194460177"},"html":{"href":"https://github.com/liadtal/Smart-Alerts/pull/165#discussion_r194460177"},"pull_request":{"href":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/165"}},"in_reply_to_id":194324985},"pull_request":{"url":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/165","id":193834759,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODM0NzU5","html_url":"https://github.com/liadtal/Smart-Alerts/pull/165","diff_url":"https://github.com/liadtal/Smart-Alerts/pull/165.diff","patch_url":"https://github.com/liadtal/Smart-Alerts/pull/165.patch","issue_url":"https://api.github.com/repos/liadtal/Smart-Alerts/issues/165","number":165,"state":"open","locked":false,"title":"store user settings in file and auto load in first initialization","user":{"login":"bermanguy","id":12019839,"node_id":"MDQ6VXNlcjEyMDE5ODM5","avatar_url":"https://avatars2.githubusercontent.com/u/12019839?v=4","gravatar_id":"","url":"https://api.github.com/users/bermanguy","html_url":"https://github.com/bermanguy","followers_url":"https://api.github.com/users/bermanguy/followers","following_url":"https://api.github.com/users/bermanguy/following{/other_user}","gists_url":"https://api.github.com/users/bermanguy/gists{/gist_id}","starred_url":"https://api.github.com/users/bermanguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bermanguy/subscriptions","organizations_url":"https://api.github.com/users/bermanguy/orgs","repos_url":"https://api.github.com/users/bermanguy/repos","events_url":"https://api.github.com/users/bermanguy/events{/privacy}","received_events_url":"https://api.github.com/users/bermanguy/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-10T16:32:58Z","updated_at":"2018-06-11T16:10:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1882887e544792e78f43bfe9efc1900cd49e9908","assignee":null,"assignees":[],"requested_reviewers":[{"login":"YairoR","id":7312492,"node_id":"MDQ6VXNlcjczMTI0OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/7312492?v=4","gravatar_id":"","url":"https://api.github.com/users/YairoR","html_url":"https://github.com/YairoR","followers_url":"https://api.github.com/users/YairoR/followers","following_url":"https://api.github.com/users/YairoR/following{/other_user}","gists_url":"https://api.github.com/users/YairoR/gists{/gist_id}","starred_url":"https://api.github.com/users/YairoR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YairoR/subscriptions","organizations_url":"https://api.github.com/users/YairoR/orgs","repos_url":"https://api.github.com/users/YairoR/repos","events_url":"https://api.github.com/users/YairoR/events{/privacy}","received_events_url":"https://api.github.com/users/YairoR/received_events","type":"User","site_admin":false},{"login":"liadtal","id":7619665,"node_id":"MDQ6VXNlcjc2MTk2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7619665?v=4","gravatar_id":"","url":"https://api.github.com/users/liadtal","html_url":"https://github.com/liadtal","followers_url":"https://api.github.com/users/liadtal/followers","following_url":"https://api.github.com/users/liadtal/following{/other_user}","gists_url":"https://api.github.com/users/liadtal/gists{/gist_id}","starred_url":"https://api.github.com/users/liadtal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liadtal/subscriptions","organizations_url":"https://api.github.com/users/liadtal/orgs","repos_url":"https://api.github.com/users/liadtal/repos","events_url":"https://api.github.com/users/liadtal/events{/privacy}","received_events_url":"https://api.github.com/users/liadtal/received_events","type":"User","site_admin":false},{"login":"ilaizi","id":34011385,"node_id":"MDQ6VXNlcjM0MDExMzg1","avatar_url":"https://avatars3.githubusercontent.com/u/34011385?v=4","gravatar_id":"","url":"https://api.github.com/users/ilaizi","html_url":"https://github.com/ilaizi","followers_url":"https://api.github.com/users/ilaizi/followers","following_url":"https://api.github.com/users/ilaizi/following{/other_user}","gists_url":"https://api.github.com/users/ilaizi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilaizi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilaizi/subscriptions","organizations_url":"https://api.github.com/users/ilaizi/orgs","repos_url":"https://api.github.com/users/ilaizi/repos","events_url":"https://api.github.com/users/ilaizi/events{/privacy}","received_events_url":"https://api.github.com/users/ilaizi/received_events","type":"User","site_admin":false},{"login":"efvink","id":34334677,"node_id":"MDQ6VXNlcjM0MzM0Njc3","avatar_url":"https://avatars0.githubusercontent.com/u/34334677?v=4","gravatar_id":"","url":"https://api.github.com/users/efvink","html_url":"https://github.com/efvink","followers_url":"https://api.github.com/users/efvink/followers","following_url":"https://api.github.com/users/efvink/following{/other_user}","gists_url":"https://api.github.com/users/efvink/gists{/gist_id}","starred_url":"https://api.github.com/users/efvink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efvink/subscriptions","organizations_url":"https://api.github.com/users/efvink/orgs","repos_url":"https://api.github.com/users/efvink/repos","events_url":"https://api.github.com/users/efvink/events{/privacy}","received_events_url":"https://api.github.com/users/efvink/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/165/commits","review_comments_url":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/165/comments","review_comment_url":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liadtal/Smart-Alerts/issues/165/comments","statuses_url":"https://api.github.com/repos/liadtal/Smart-Alerts/statuses/11e56c6c8ce248b1963531759d1af93dcb565be5","head":{"label":"liadtal:features/guyber/add-user-settings-to-emulator","ref":"features/guyber/add-user-settings-to-emulator","sha":"11e56c6c8ce248b1963531759d1af93dcb565be5","user":{"login":"liadtal","id":7619665,"node_id":"MDQ6VXNlcjc2MTk2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7619665?v=4","gravatar_id":"","url":"https://api.github.com/users/liadtal","html_url":"https://github.com/liadtal","followers_url":"https://api.github.com/users/liadtal/followers","following_url":"https://api.github.com/users/liadtal/following{/other_user}","gists_url":"https://api.github.com/users/liadtal/gists{/gist_id}","starred_url":"https://api.github.com/users/liadtal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liadtal/subscriptions","organizations_url":"https://api.github.com/users/liadtal/orgs","repos_url":"https://api.github.com/users/liadtal/repos","events_url":"https://api.github.com/users/liadtal/events{/privacy}","received_events_url":"https://api.github.com/users/liadtal/received_events","type":"User","site_admin":false},"repo":{"id":112164565,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIxNjQ1NjU=","name":"Smart-Alerts","full_name":"liadtal/Smart-Alerts","owner":{"login":"liadtal","id":7619665,"node_id":"MDQ6VXNlcjc2MTk2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7619665?v=4","gravatar_id":"","url":"https://api.github.com/users/liadtal","html_url":"https://github.com/liadtal","followers_url":"https://api.github.com/users/liadtal/followers","following_url":"https://api.github.com/users/liadtal/following{/other_user}","gists_url":"https://api.github.com/users/liadtal/gists{/gist_id}","starred_url":"https://api.github.com/users/liadtal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liadtal/subscriptions","organizations_url":"https://api.github.com/users/liadtal/orgs","repos_url":"https://api.github.com/users/liadtal/repos","events_url":"https://api.github.com/users/liadtal/events{/privacy}","received_events_url":"https://api.github.com/users/liadtal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liadtal/Smart-Alerts","description":"Have the ability to create custom detectors / on-board existing which works against the Azure Log Analytics","fork":false,"url":"https://api.github.com/repos/liadtal/Smart-Alerts","forks_url":"https://api.github.com/repos/liadtal/Smart-Alerts/forks","keys_url":"https://api.github.com/repos/liadtal/Smart-Alerts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liadtal/Smart-Alerts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liadtal/Smart-Alerts/teams","hooks_url":"https://api.github.com/repos/liadtal/Smart-Alerts/hooks","issue_events_url":"https://api.github.com/repos/liadtal/Smart-Alerts/issues/events{/number}","events_url":"https://api.github.com/repos/liadtal/Smart-Alerts/events","assignees_url":"https://api.github.com/repos/liadtal/Smart-Alerts/assignees{/user}","branches_url":"https://api.github.com/repos/liadtal/Smart-Alerts/branches{/branch}","tags_url":"https://api.github.com/repos/liadtal/Smart-Alerts/tags","blobs_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/refs{/sha}","trees_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liadtal/Smart-Alerts/statuses/{sha}","languages_url":"https://api.github.com/repos/liadtal/Smart-Alerts/languages","stargazers_url":"https://api.github.com/repos/liadtal/Smart-Alerts/stargazers","contributors_url":"https://api.github.com/repos/liadtal/Smart-Alerts/contributors","subscribers_url":"https://api.github.com/repos/liadtal/Smart-Alerts/subscribers","subscription_url":"https://api.github.com/repos/liadtal/Smart-Alerts/subscription","commits_url":"https://api.github.com/repos/liadtal/Smart-Alerts/commits{/sha}","git_commits_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/commits{/sha}","comments_url":"https://api.github.com/repos/liadtal/Smart-Alerts/comments{/number}","issue_comment_url":"https://api.github.com/repos/liadtal/Smart-Alerts/issues/comments{/number}","contents_url":"https://api.github.com/repos/liadtal/Smart-Alerts/contents/{+path}","compare_url":"https://api.github.com/repos/liadtal/Smart-Alerts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liadtal/Smart-Alerts/merges","archive_url":"https://api.github.com/repos/liadtal/Smart-Alerts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liadtal/Smart-Alerts/downloads","issues_url":"https://api.github.com/repos/liadtal/Smart-Alerts/issues{/number}","pulls_url":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls{/number}","milestones_url":"https://api.github.com/repos/liadtal/Smart-Alerts/milestones{/number}","notifications_url":"https://api.github.com/repos/liadtal/Smart-Alerts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liadtal/Smart-Alerts/labels{/name}","releases_url":"https://api.github.com/repos/liadtal/Smart-Alerts/releases{/id}","deployments_url":"https://api.github.com/repos/liadtal/Smart-Alerts/deployments","created_at":"2017-11-27T07:48:01Z","updated_at":"2018-06-11T15:07:26Z","pushed_at":"2018-06-11T15:07:29Z","git_url":"git://github.com/liadtal/Smart-Alerts.git","ssh_url":"[email protected]:liadtal/Smart-Alerts.git","clone_url":"https://github.com/liadtal/Smart-Alerts.git","svn_url":"https://github.com/liadtal/Smart-Alerts","homepage":null,"size":1993,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"liadtal:master","ref":"master","sha":"3189073d4048e9997ca3ec217840a6c9a2581d56","user":{"login":"liadtal","id":7619665,"node_id":"MDQ6VXNlcjc2MTk2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7619665?v=4","gravatar_id":"","url":"https://api.github.com/users/liadtal","html_url":"https://github.com/liadtal","followers_url":"https://api.github.com/users/liadtal/followers","following_url":"https://api.github.com/users/liadtal/following{/other_user}","gists_url":"https://api.github.com/users/liadtal/gists{/gist_id}","starred_url":"https://api.github.com/users/liadtal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liadtal/subscriptions","organizations_url":"https://api.github.com/users/liadtal/orgs","repos_url":"https://api.github.com/users/liadtal/repos","events_url":"https://api.github.com/users/liadtal/events{/privacy}","received_events_url":"https://api.github.com/users/liadtal/received_events","type":"User","site_admin":false},"repo":{"id":112164565,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIxNjQ1NjU=","name":"Smart-Alerts","full_name":"liadtal/Smart-Alerts","owner":{"login":"liadtal","id":7619665,"node_id":"MDQ6VXNlcjc2MTk2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7619665?v=4","gravatar_id":"","url":"https://api.github.com/users/liadtal","html_url":"https://github.com/liadtal","followers_url":"https://api.github.com/users/liadtal/followers","following_url":"https://api.github.com/users/liadtal/following{/other_user}","gists_url":"https://api.github.com/users/liadtal/gists{/gist_id}","starred_url":"https://api.github.com/users/liadtal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liadtal/subscriptions","organizations_url":"https://api.github.com/users/liadtal/orgs","repos_url":"https://api.github.com/users/liadtal/repos","events_url":"https://api.github.com/users/liadtal/events{/privacy}","received_events_url":"https://api.github.com/users/liadtal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liadtal/Smart-Alerts","description":"Have the ability to create custom detectors / on-board existing which works against the Azure Log Analytics","fork":false,"url":"https://api.github.com/repos/liadtal/Smart-Alerts","forks_url":"https://api.github.com/repos/liadtal/Smart-Alerts/forks","keys_url":"https://api.github.com/repos/liadtal/Smart-Alerts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liadtal/Smart-Alerts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liadtal/Smart-Alerts/teams","hooks_url":"https://api.github.com/repos/liadtal/Smart-Alerts/hooks","issue_events_url":"https://api.github.com/repos/liadtal/Smart-Alerts/issues/events{/number}","events_url":"https://api.github.com/repos/liadtal/Smart-Alerts/events","assignees_url":"https://api.github.com/repos/liadtal/Smart-Alerts/assignees{/user}","branches_url":"https://api.github.com/repos/liadtal/Smart-Alerts/branches{/branch}","tags_url":"https://api.github.com/repos/liadtal/Smart-Alerts/tags","blobs_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/refs{/sha}","trees_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liadtal/Smart-Alerts/statuses/{sha}","languages_url":"https://api.github.com/repos/liadtal/Smart-Alerts/languages","stargazers_url":"https://api.github.com/repos/liadtal/Smart-Alerts/stargazers","contributors_url":"https://api.github.com/repos/liadtal/Smart-Alerts/contributors","subscribers_url":"https://api.github.com/repos/liadtal/Smart-Alerts/subscribers","subscription_url":"https://api.github.com/repos/liadtal/Smart-Alerts/subscription","commits_url":"https://api.github.com/repos/liadtal/Smart-Alerts/commits{/sha}","git_commits_url":"https://api.github.com/repos/liadtal/Smart-Alerts/git/commits{/sha}","comments_url":"https://api.github.com/repos/liadtal/Smart-Alerts/comments{/number}","issue_comment_url":"https://api.github.com/repos/liadtal/Smart-Alerts/issues/comments{/number}","contents_url":"https://api.github.com/repos/liadtal/Smart-Alerts/contents/{+path}","compare_url":"https://api.github.com/repos/liadtal/Smart-Alerts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liadtal/Smart-Alerts/merges","archive_url":"https://api.github.com/repos/liadtal/Smart-Alerts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liadtal/Smart-Alerts/downloads","issues_url":"https://api.github.com/repos/liadtal/Smart-Alerts/issues{/number}","pulls_url":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls{/number}","milestones_url":"https://api.github.com/repos/liadtal/Smart-Alerts/milestones{/number}","notifications_url":"https://api.github.com/repos/liadtal/Smart-Alerts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liadtal/Smart-Alerts/labels{/name}","releases_url":"https://api.github.com/repos/liadtal/Smart-Alerts/releases{/id}","deployments_url":"https://api.github.com/repos/liadtal/Smart-Alerts/deployments","created_at":"2017-11-27T07:48:01Z","updated_at":"2018-06-11T15:07:26Z","pushed_at":"2018-06-11T15:07:29Z","git_url":"git://github.com/liadtal/Smart-Alerts.git","ssh_url":"[email protected]:liadtal/Smart-Alerts.git","clone_url":"https://github.com/liadtal/Smart-Alerts.git","svn_url":"https://github.com/liadtal/Smart-Alerts","homepage":null,"size":1993,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/165"},"html":{"href":"https://github.com/liadtal/Smart-Alerts/pull/165"},"issue":{"href":"https://api.github.com/repos/liadtal/Smart-Alerts/issues/165"},"comments":{"href":"https://api.github.com/repos/liadtal/Smart-Alerts/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liadtal/Smart-Alerts/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/liadtal/Smart-Alerts/statuses/11e56c6c8ce248b1963531759d1af93dcb565be5"}},"author_association":"COLLABORATOR"}} | {
"id": 112164565,
"name": "liadtal/Smart-Alerts",
"url": "https://api.github.com/repos/liadtal/Smart-Alerts"
} | {
"id": 12019839,
"login": "bermanguy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12019839?",
"url": "https://api.github.com/users/bermanguy"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-06-11T16:10:17 | 7807222782 | {"actor":{"display_login":"bermanguy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bmf-san/Rubel/pulls/comments/205963918","pull_request_review_id":141337754,"id":205963918,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk2MzkxOA==","diff_hunk":"@@ -0,0 +1,149 @@\n+<?php\n+\n+namespace Tests;\n+\n+use Orchestra\\Testbench\\TestCase as BaseTestCase;\n+use Carbon\\Carbon;\n+\n+class FeatureTestCase extends BaseTestCase\n+{\n+ /**\n+ * Setup the test environment.\n+ *\n+ * @return void\n+ */\n+ public function setUp()\n+ {\n+ parent::setUp();\n+ $this->loadMigrationsFrom(realpath(__DIR__.'/../../../../core-app/database/migrations'));\n+ $this->artisan('migrate:refresh');\n+ $this->setData();\n+ }\n+\n+ /**\n+ * Override the loadMigrationsFrom method.\n+ *\n+ * @param string $paths\n+ * @return void\n+ */\n+ protected function loadMigrationsFrom($paths)\n+ {\n+ $paths = (is_array($paths)) ? $paths : [$paths];\n+ $this->app->afterResolving('migrator', function ($migrator) use ($paths) {\n+ foreach ((array) $paths as $path) {\n+ $migrator->path($path);\n+ }\n+ });\n+ }\n+\n+ /**\n+ * To load service provider.\n+ *\n+ * @param Illuminate\\Foundation\\Application $app\n+ * @return void\n+ */\n+ protected function getPackageProviders($app)","path":"src/client-app/packages/bmftech/tests/FeatureTestCase.php","position":45,"original_position":45,"commit_id":"afd9f87d6bcf51b76e16e54fad72825962434da0","original_commit_id":"afd9f87d6bcf51b76e16e54fad72825962434da0","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Avoid unused parameters such as '$app'.](https://app.codacy.com/app/bmf-san/Rubel/pullRequest?prid=1958423)","created_at":"2018-07-29T07:39:19Z","updated_at":"2018-07-29T07:39:19Z","html_url":"https://github.com/bmf-san/Rubel/pull/55#discussion_r205963918","pull_request_url":"https://api.github.com/repos/bmf-san/Rubel/pulls/55","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/comments/205963918"},"html":{"href":"https://github.com/bmf-san/Rubel/pull/55#discussion_r205963918"},"pull_request":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/bmf-san/Rubel/pulls/55","id":201440953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDQwOTUz","html_url":"https://github.com/bmf-san/Rubel/pull/55","diff_url":"https://github.com/bmf-san/Rubel/pull/55.diff","patch_url":"https://github.com/bmf-san/Rubel/pull/55.patch","issue_url":"https://api.github.com/repos/bmf-san/Rubel/issues/55","number":55,"state":"open","locked":false,"title":"[WIP] Implement of a function to manage theme","user":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"body":"# Overview\r\n~~Implement of a function to manage theme.~~->Implement web app as a package\r\n\r\n# Changes\r\n- [x] set up for package\r\n- [x] fix path to js file and path to css file in template files.\r\n- [x] fix webpack.config.js in theme package\r\n- [x] fix circleci setting\r\n - npm process\r\n - vendor publish command\r\n- [x] tests\r\n - [x] add repository tests to core\r\n - [x] fix package tests to package dir\r\n - fix Integration tests\r\n- [x] fix config files\r\n- [x] fix env\r\n- [ ] add pages\r\n - profile page\r\n - contact page \r\n\r\n# Impact range\r\nclient-app\r\n\r\n# Operational Requirements\r\n\r\n# Related Issue\r\n#51 \r\n\r\n# Supplement\r\n","created_at":"2018-07-14T07:42:32Z","updated_at":"2018-07-29T07:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53c918d3286e3f24137127e1fd6b4f8125431c6b","assignee":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bmf-san/Rubel/pulls/55/commits","review_comments_url":"https://api.github.com/repos/bmf-san/Rubel/pulls/55/comments","review_comment_url":"https://api.github.com/repos/bmf-san/Rubel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bmf-san/Rubel/issues/55/comments","statuses_url":"https://api.github.com/repos/bmf-san/Rubel/statuses/afd9f87d6bcf51b76e16e54fad72825962434da0","head":{"label":"bmf-san:feature/theme","ref":"feature/theme","sha":"afd9f87d6bcf51b76e16e54fad72825962434da0","user":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"repo":{"id":75729934,"node_id":"MDEwOlJlcG9zaXRvcnk3NTcyOTkzNA==","name":"Rubel","full_name":"bmf-san/Rubel","owner":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmf-san/Rubel","description":"Rubel - An open source cms built with Laravel and React.","fork":false,"url":"https://api.github.com/repos/bmf-san/Rubel","forks_url":"https://api.github.com/repos/bmf-san/Rubel/forks","keys_url":"https://api.github.com/repos/bmf-san/Rubel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmf-san/Rubel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmf-san/Rubel/teams","hooks_url":"https://api.github.com/repos/bmf-san/Rubel/hooks","issue_events_url":"https://api.github.com/repos/bmf-san/Rubel/issues/events{/number}","events_url":"https://api.github.com/repos/bmf-san/Rubel/events","assignees_url":"https://api.github.com/repos/bmf-san/Rubel/assignees{/user}","branches_url":"https://api.github.com/repos/bmf-san/Rubel/branches{/branch}","tags_url":"https://api.github.com/repos/bmf-san/Rubel/tags","blobs_url":"https://api.github.com/repos/bmf-san/Rubel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmf-san/Rubel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmf-san/Rubel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmf-san/Rubel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmf-san/Rubel/statuses/{sha}","languages_url":"https://api.github.com/repos/bmf-san/Rubel/languages","stargazers_url":"https://api.github.com/repos/bmf-san/Rubel/stargazers","contributors_url":"https://api.github.com/repos/bmf-san/Rubel/contributors","subscribers_url":"https://api.github.com/repos/bmf-san/Rubel/subscribers","subscription_url":"https://api.github.com/repos/bmf-san/Rubel/subscription","commits_url":"https://api.github.com/repos/bmf-san/Rubel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmf-san/Rubel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmf-san/Rubel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmf-san/Rubel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmf-san/Rubel/contents/{+path}","compare_url":"https://api.github.com/repos/bmf-san/Rubel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmf-san/Rubel/merges","archive_url":"https://api.github.com/repos/bmf-san/Rubel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmf-san/Rubel/downloads","issues_url":"https://api.github.com/repos/bmf-san/Rubel/issues{/number}","pulls_url":"https://api.github.com/repos/bmf-san/Rubel/pulls{/number}","milestones_url":"https://api.github.com/repos/bmf-san/Rubel/milestones{/number}","notifications_url":"https://api.github.com/repos/bmf-san/Rubel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmf-san/Rubel/labels{/name}","releases_url":"https://api.github.com/repos/bmf-san/Rubel/releases{/id}","deployments_url":"https://api.github.com/repos/bmf-san/Rubel/deployments","created_at":"2016-12-06T12:38:21Z","updated_at":"2018-06-23T06:00:21Z","pushed_at":"2018-07-29T07:37:40Z","git_url":"git://github.com/bmf-san/Rubel.git","ssh_url":"[email protected]:bmf-san/Rubel.git","clone_url":"https://github.com/bmf-san/Rubel.git","svn_url":"https://github.com/bmf-san/Rubel","homepage":"https://rubel-admin.bmf-tech.com/login","size":69588,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":14,"watchers":57,"default_branch":"master"}},"base":{"label":"bmf-san:master","ref":"master","sha":"9db1e95c7c5753b1b2abb94618f927813b843e8a","user":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"repo":{"id":75729934,"node_id":"MDEwOlJlcG9zaXRvcnk3NTcyOTkzNA==","name":"Rubel","full_name":"bmf-san/Rubel","owner":{"login":"bmf-san","id":13291041,"node_id":"MDQ6VXNlcjEzMjkxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13291041?v=4","gravatar_id":"","url":"https://api.github.com/users/bmf-san","html_url":"https://github.com/bmf-san","followers_url":"https://api.github.com/users/bmf-san/followers","following_url":"https://api.github.com/users/bmf-san/following{/other_user}","gists_url":"https://api.github.com/users/bmf-san/gists{/gist_id}","starred_url":"https://api.github.com/users/bmf-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmf-san/subscriptions","organizations_url":"https://api.github.com/users/bmf-san/orgs","repos_url":"https://api.github.com/users/bmf-san/repos","events_url":"https://api.github.com/users/bmf-san/events{/privacy}","received_events_url":"https://api.github.com/users/bmf-san/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmf-san/Rubel","description":"Rubel - An open source cms built with Laravel and React.","fork":false,"url":"https://api.github.com/repos/bmf-san/Rubel","forks_url":"https://api.github.com/repos/bmf-san/Rubel/forks","keys_url":"https://api.github.com/repos/bmf-san/Rubel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmf-san/Rubel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmf-san/Rubel/teams","hooks_url":"https://api.github.com/repos/bmf-san/Rubel/hooks","issue_events_url":"https://api.github.com/repos/bmf-san/Rubel/issues/events{/number}","events_url":"https://api.github.com/repos/bmf-san/Rubel/events","assignees_url":"https://api.github.com/repos/bmf-san/Rubel/assignees{/user}","branches_url":"https://api.github.com/repos/bmf-san/Rubel/branches{/branch}","tags_url":"https://api.github.com/repos/bmf-san/Rubel/tags","blobs_url":"https://api.github.com/repos/bmf-san/Rubel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmf-san/Rubel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmf-san/Rubel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmf-san/Rubel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmf-san/Rubel/statuses/{sha}","languages_url":"https://api.github.com/repos/bmf-san/Rubel/languages","stargazers_url":"https://api.github.com/repos/bmf-san/Rubel/stargazers","contributors_url":"https://api.github.com/repos/bmf-san/Rubel/contributors","subscribers_url":"https://api.github.com/repos/bmf-san/Rubel/subscribers","subscription_url":"https://api.github.com/repos/bmf-san/Rubel/subscription","commits_url":"https://api.github.com/repos/bmf-san/Rubel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmf-san/Rubel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmf-san/Rubel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmf-san/Rubel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmf-san/Rubel/contents/{+path}","compare_url":"https://api.github.com/repos/bmf-san/Rubel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmf-san/Rubel/merges","archive_url":"https://api.github.com/repos/bmf-san/Rubel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmf-san/Rubel/downloads","issues_url":"https://api.github.com/repos/bmf-san/Rubel/issues{/number}","pulls_url":"https://api.github.com/repos/bmf-san/Rubel/pulls{/number}","milestones_url":"https://api.github.com/repos/bmf-san/Rubel/milestones{/number}","notifications_url":"https://api.github.com/repos/bmf-san/Rubel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmf-san/Rubel/labels{/name}","releases_url":"https://api.github.com/repos/bmf-san/Rubel/releases{/id}","deployments_url":"https://api.github.com/repos/bmf-san/Rubel/deployments","created_at":"2016-12-06T12:38:21Z","updated_at":"2018-06-23T06:00:21Z","pushed_at":"2018-07-29T07:37:40Z","git_url":"git://github.com/bmf-san/Rubel.git","ssh_url":"[email protected]:bmf-san/Rubel.git","clone_url":"https://github.com/bmf-san/Rubel.git","svn_url":"https://github.com/bmf-san/Rubel","homepage":"https://rubel-admin.bmf-tech.com/login","size":69588,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":14,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/55"},"html":{"href":"https://github.com/bmf-san/Rubel/pull/55"},"issue":{"href":"https://api.github.com/repos/bmf-san/Rubel/issues/55"},"comments":{"href":"https://api.github.com/repos/bmf-san/Rubel/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bmf-san/Rubel/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/bmf-san/Rubel/statuses/afd9f87d6bcf51b76e16e54fad72825962434da0"}},"author_association":"OWNER"}} | {
"id": 75729934,
"name": "bmf-san/Rubel",
"url": "https://api.github.com/repos/bmf-san/Rubel"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-07-29T07:39:19 | 8033547475 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yundom/Abigail/pulls/comments/213901500","pull_request_review_id":150834807,"id":213901500,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzkwMTUwMA==","diff_hunk":"@@ -0,0 +1,54 @@\n+# 曼谷上班族的午餐好去處-Amari Food Court\n+\n+你會不會好奇曼谷的上班族午餐都去吃什麼？ 今天要來介紹的是位在曼谷四面佛附近， 離 BTS Chitlom 站不遠的 **Amari Food Court**。這個在百貨公司中平價的美食廣場，是一位在曼谷工作的台灣人帶路的景點，平價實惠又多元的餐點選擇的確是上班族午餐的好選擇。\n+\n+Food Court 位在Amari的四樓，中午時段前往會看到許多上班族在這用餐，我會建議避開用餐的顛峰時間(約12:00-13:00)前往，比較容易找到座位。在泰國Food Court 一般都需要先在服務台換餐卡(Cash Card)，儲值金額到卡中才能在每個店家進行消費，店家是不收現金的。餐卡(Cash Card)在用餐完後，再至服務台進行餘額的退費，如果剛好餘額用完，店家會直接把餐卡收去。\n+\n+\n+\n+整個四樓的空間都是Amari Food Court，相較於台灣的美食街來看，這邊的空間相當的大與寬敞，餐廳品項選擇也很豐富，舉凡在地的泰式自助餐、Phad Thai 、豬腳飯、燒臘飯、甜品店、豬排店...等等，都可以在這邊找得到。 \n+\n+待在曼谷兩個月的時間裡，我造訪這個Food Court大概有20次以上，其中我最常吃也是蠻推薦的兩間店家分別是 _Hongtay Steam Duck Noodles_ 的鴨肉麵 & _Nai Muek_的雞肉Pad Thai。\n+\n+### Hongtay Steam Duck Noodles\n+ \n+首先先來介紹鴨肉麵的部分，有別於泰式料理中的冬蔭功，因湯的口味偏重鹹，久久才能嘗試一次; 我更喜歡的是鴨肉麵這種簡單調味的湯頭，喝起來不但暖胃無負擔，且更能讓人一口接著一口把湯喝完。這次選擇的是Steam Duck with Noodles，選擇好餐點品項後，店員會讓你選擇麵的種類，我個人偏好（左二跟左三的麵條) 推薦給大家囉！\n+\n+ **Step1:選擇餐點品項** \n+\n+ \n+**Step2:選擇麵條種類** \n+\n+\n+**Step3:用餐卡結帳付款** \n+將餐卡給店員後，店員會幫你結帳並給你收據，讓你知道這餐花費是多少。鴨肉麵50泰銖一碗，覺得價格相當親民與實惠。 \n+\n+\n+** Step4:享用鴨肉麵** \n+鴨肉麵中有好幾片鴨肉以及一塊鴨血及些許鴨胗，河粉麵條爽口Ｑ彈的口感配上帶有中藥味燉煮的鴨肉湯頭，吃起來可以感受到肉跟湯麵做出最恰當比例的分配，對於食量不大的女生來說，一碗鴨肉麵的份量恰恰好！ \n+\n+\n+### Nai Muek\n+ \n+接著是泰國著名的經典小吃泰式炒粿條Pad Thai，將粿條加入豆乾、蝦米及豆芽菜等材料快炒，搭配泰國的Pad Thai醬汁，讓這個簡單的料理變成豐富的一道菜。Nai Meuk這間店有種Pad Thai的選擇，我們這次點的是Pad Thai with Fried Chicken的口味\n+\n+** Pad Thai with Fried Chicken**\n+這間的粿條採用較細的麵條，剛熱炒起來的泰式粿條結合了豆乾及豆芽的嚼勁，還有醬汁甜甜的味道，再淋上新鮮檸檬，讓Pad Thai吃起來爽口不油膩，相對起來炸雞部分表現就沒有這麼突出，炸雞的皮炸得十分乾柴卻不飽滿，吃起來有一點躁感。 \n+\n+\n+\n+另外，泰國人在吃炒粿條的時候常會一口粿條一口青蔥這樣搭配吃，初次看到蠻不習慣的，入境隨俗試看看這個口感，還是比較喜歡蔥加在餐點裡的感覺啊！青蔥、豆芽、香菜及其他調味料（如辣椒＆糖）會放在店家前供消費著自行取用。 ","path":"Amari/index.md","position":40,"original_position":40,"commit_id":"f67d85eb152a09a69e5eb937fb419f51be3bccd4","original_commit_id":"e9b0b87f770dc3e5835de25c3d8d7260e720adb3","user":{"login":"yundom","id":619465,"node_id":"MDQ6VXNlcjYxOTQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/619465?v=4","gravatar_id":"","url":"https://api.github.com/users/yundom","html_url":"https://github.com/yundom","followers_url":"https://api.github.com/users/yundom/followers","following_url":"https://api.github.com/users/yundom/following{/other_user}","gists_url":"https://api.github.com/users/yundom/gists{/gist_id}","starred_url":"https://api.github.com/users/yundom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yundom/subscriptions","organizations_url":"https://api.github.com/users/yundom/orgs","repos_url":"https://api.github.com/users/yundom/repos","events_url":"https://api.github.com/users/yundom/events{/privacy}","received_events_url":"https://api.github.com/users/yundom/received_events","type":"User","site_admin":false},"body":"有毛病","created_at":"2018-08-30T04:38:09Z","updated_at":"2018-08-30T04:40:47Z","html_url":"https://github.com/yundom/Abigail/pull/4#discussion_r213901500","pull_request_url":"https://api.github.com/repos/yundom/Abigail/pulls/4","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yundom/Abigail/pulls/comments/213901500"},"html":{"href":"https://github.com/yundom/Abigail/pull/4#discussion_r213901500"},"pull_request":{"href":"https://api.github.com/repos/yundom/Abigail/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/yundom/Abigail/pulls/4","id":211953296,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTUzMjk2","html_url":"https://github.com/yundom/Abigail/pull/4","diff_url":"https://github.com/yundom/Abigail/pull/4.diff","patch_url":"https://github.com/yundom/Abigail/pull/4.patch","issue_url":"https://api.github.com/repos/yundom/Abigail/issues/4","number":4,"state":"open","locked":false,"title":"1st Article - Amari","user":{"login":"AliciaCChao","id":42812502,"node_id":"MDQ6VXNlcjQyODEyNTAy","avatar_url":"https://avatars3.githubusercontent.com/u/42812502?v=4","gravatar_id":"","url":"https://api.github.com/users/AliciaCChao","html_url":"https://github.com/AliciaCChao","followers_url":"https://api.github.com/users/AliciaCChao/followers","following_url":"https://api.github.com/users/AliciaCChao/following{/other_user}","gists_url":"https://api.github.com/users/AliciaCChao/gists{/gist_id}","starred_url":"https://api.github.com/users/AliciaCChao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliciaCChao/subscriptions","organizations_url":"https://api.github.com/users/AliciaCChao/orgs","repos_url":"https://api.github.com/users/AliciaCChao/repos","events_url":"https://api.github.com/users/AliciaCChao/events{/privacy}","received_events_url":"https://api.github.com/users/AliciaCChao/received_events","type":"User","site_admin":false},"body":"First review of Amari article.","created_at":"2018-08-30T04:36:57Z","updated_at":"2018-08-30T04:40:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19f9ced36214868f9d164226e61cc492e6d77f19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yundom/Abigail/pulls/4/commits","review_comments_url":"https://api.github.com/repos/yundom/Abigail/pulls/4/comments","review_comment_url":"https://api.github.com/repos/yundom/Abigail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yundom/Abigail/issues/4/comments","statuses_url":"https://api.github.com/repos/yundom/Abigail/statuses/f67d85eb152a09a69e5eb937fb419f51be3bccd4","head":{"label":"yundom:Amari","ref":"Amari","sha":"f67d85eb152a09a69e5eb937fb419f51be3bccd4","user":{"login":"yundom","id":619465,"node_id":"MDQ6VXNlcjYxOTQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/619465?v=4","gravatar_id":"","url":"https://api.github.com/users/yundom","html_url":"https://github.com/yundom","followers_url":"https://api.github.com/users/yundom/followers","following_url":"https://api.github.com/users/yundom/following{/other_user}","gists_url":"https://api.github.com/users/yundom/gists{/gist_id}","starred_url":"https://api.github.com/users/yundom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yundom/subscriptions","organizations_url":"https://api.github.com/users/yundom/orgs","repos_url":"https://api.github.com/users/yundom/repos","events_url":"https://api.github.com/users/yundom/events{/privacy}","received_events_url":"https://api.github.com/users/yundom/received_events","type":"User","site_admin":false},"repo":{"id":146626995,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2MjY5OTU=","name":"Abigail","full_name":"yundom/Abigail","owner":{"login":"yundom","id":619465,"node_id":"MDQ6VXNlcjYxOTQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/619465?v=4","gravatar_id":"","url":"https://api.github.com/users/yundom","html_url":"https://github.com/yundom","followers_url":"https://api.github.com/users/yundom/followers","following_url":"https://api.github.com/users/yundom/following{/other_user}","gists_url":"https://api.github.com/users/yundom/gists{/gist_id}","starred_url":"https://api.github.com/users/yundom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yundom/subscriptions","organizations_url":"https://api.github.com/users/yundom/orgs","repos_url":"https://api.github.com/users/yundom/repos","events_url":"https://api.github.com/users/yundom/events{/privacy}","received_events_url":"https://api.github.com/users/yundom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yundom/Abigail","description":null,"fork":false,"url":"https://api.github.com/repos/yundom/Abigail","forks_url":"https://api.github.com/repos/yundom/Abigail/forks","keys_url":"https://api.github.com/repos/yundom/Abigail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yundom/Abigail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yundom/Abigail/teams","hooks_url":"https://api.github.com/repos/yundom/Abigail/hooks","issue_events_url":"https://api.github.com/repos/yundom/Abigail/issues/events{/number}","events_url":"https://api.github.com/repos/yundom/Abigail/events","assignees_url":"https://api.github.com/repos/yundom/Abigail/assignees{/user}","branches_url":"https://api.github.com/repos/yundom/Abigail/branches{/branch}","tags_url":"https://api.github.com/repos/yundom/Abigail/tags","blobs_url":"https://api.github.com/repos/yundom/Abigail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yundom/Abigail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yundom/Abigail/git/refs{/sha}","trees_url":"https://api.github.com/repos/yundom/Abigail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yundom/Abigail/statuses/{sha}","languages_url":"https://api.github.com/repos/yundom/Abigail/languages","stargazers_url":"https://api.github.com/repos/yundom/Abigail/stargazers","contributors_url":"https://api.github.com/repos/yundom/Abigail/contributors","subscribers_url":"https://api.github.com/repos/yundom/Abigail/subscribers","subscription_url":"https://api.github.com/repos/yundom/Abigail/subscription","commits_url":"https://api.github.com/repos/yundom/Abigail/commits{/sha}","git_commits_url":"https://api.github.com/repos/yundom/Abigail/git/commits{/sha}","comments_url":"https://api.github.com/repos/yundom/Abigail/comments{/number}","issue_comment_url":"https://api.github.com/repos/yundom/Abigail/issues/comments{/number}","contents_url":"https://api.github.com/repos/yundom/Abigail/contents/{+path}","compare_url":"https://api.github.com/repos/yundom/Abigail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yundom/Abigail/merges","archive_url":"https://api.github.com/repos/yundom/Abigail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yundom/Abigail/downloads","issues_url":"https://api.github.com/repos/yundom/Abigail/issues{/number}","pulls_url":"https://api.github.com/repos/yundom/Abigail/pulls{/number}","milestones_url":"https://api.github.com/repos/yundom/Abigail/milestones{/number}","notifications_url":"https://api.github.com/repos/yundom/Abigail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yundom/Abigail/labels{/name}","releases_url":"https://api.github.com/repos/yundom/Abigail/releases{/id}","deployments_url":"https://api.github.com/repos/yundom/Abigail/deployments","created_at":"2018-08-29T16:19:17Z","updated_at":"2018-08-30T04:29:07Z","pushed_at":"2018-08-30T04:39:49Z","git_url":"git://github.com/yundom/Abigail.git","ssh_url":"[email protected]:yundom/Abigail.git","clone_url":"https://github.com/yundom/Abigail.git","svn_url":"https://github.com/yundom/Abigail","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"yundom:master","ref":"master","sha":"9e5e99b8e86a0723ca5cd636fdd5d246f42734ce","user":{"login":"yundom","id":619465,"node_id":"MDQ6VXNlcjYxOTQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/619465?v=4","gravatar_id":"","url":"https://api.github.com/users/yundom","html_url":"https://github.com/yundom","followers_url":"https://api.github.com/users/yundom/followers","following_url":"https://api.github.com/users/yundom/following{/other_user}","gists_url":"https://api.github.com/users/yundom/gists{/gist_id}","starred_url":"https://api.github.com/users/yundom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yundom/subscriptions","organizations_url":"https://api.github.com/users/yundom/orgs","repos_url":"https://api.github.com/users/yundom/repos","events_url":"https://api.github.com/users/yundom/events{/privacy}","received_events_url":"https://api.github.com/users/yundom/received_events","type":"User","site_admin":false},"repo":{"id":146626995,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2MjY5OTU=","name":"Abigail","full_name":"yundom/Abigail","owner":{"login":"yundom","id":619465,"node_id":"MDQ6VXNlcjYxOTQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/619465?v=4","gravatar_id":"","url":"https://api.github.com/users/yundom","html_url":"https://github.com/yundom","followers_url":"https://api.github.com/users/yundom/followers","following_url":"https://api.github.com/users/yundom/following{/other_user}","gists_url":"https://api.github.com/users/yundom/gists{/gist_id}","starred_url":"https://api.github.com/users/yundom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yundom/subscriptions","organizations_url":"https://api.github.com/users/yundom/orgs","repos_url":"https://api.github.com/users/yundom/repos","events_url":"https://api.github.com/users/yundom/events{/privacy}","received_events_url":"https://api.github.com/users/yundom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yundom/Abigail","description":null,"fork":false,"url":"https://api.github.com/repos/yundom/Abigail","forks_url":"https://api.github.com/repos/yundom/Abigail/forks","keys_url":"https://api.github.com/repos/yundom/Abigail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yundom/Abigail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yundom/Abigail/teams","hooks_url":"https://api.github.com/repos/yundom/Abigail/hooks","issue_events_url":"https://api.github.com/repos/yundom/Abigail/issues/events{/number}","events_url":"https://api.github.com/repos/yundom/Abigail/events","assignees_url":"https://api.github.com/repos/yundom/Abigail/assignees{/user}","branches_url":"https://api.github.com/repos/yundom/Abigail/branches{/branch}","tags_url":"https://api.github.com/repos/yundom/Abigail/tags","blobs_url":"https://api.github.com/repos/yundom/Abigail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yundom/Abigail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yundom/Abigail/git/refs{/sha}","trees_url":"https://api.github.com/repos/yundom/Abigail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yundom/Abigail/statuses/{sha}","languages_url":"https://api.github.com/repos/yundom/Abigail/languages","stargazers_url":"https://api.github.com/repos/yundom/Abigail/stargazers","contributors_url":"https://api.github.com/repos/yundom/Abigail/contributors","subscribers_url":"https://api.github.com/repos/yundom/Abigail/subscribers","subscription_url":"https://api.github.com/repos/yundom/Abigail/subscription","commits_url":"https://api.github.com/repos/yundom/Abigail/commits{/sha}","git_commits_url":"https://api.github.com/repos/yundom/Abigail/git/commits{/sha}","comments_url":"https://api.github.com/repos/yundom/Abigail/comments{/number}","issue_comment_url":"https://api.github.com/repos/yundom/Abigail/issues/comments{/number}","contents_url":"https://api.github.com/repos/yundom/Abigail/contents/{+path}","compare_url":"https://api.github.com/repos/yundom/Abigail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yundom/Abigail/merges","archive_url":"https://api.github.com/repos/yundom/Abigail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yundom/Abigail/downloads","issues_url":"https://api.github.com/repos/yundom/Abigail/issues{/number}","pulls_url":"https://api.github.com/repos/yundom/Abigail/pulls{/number}","milestones_url":"https://api.github.com/repos/yundom/Abigail/milestones{/number}","notifications_url":"https://api.github.com/repos/yundom/Abigail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yundom/Abigail/labels{/name}","releases_url":"https://api.github.com/repos/yundom/Abigail/releases{/id}","deployments_url":"https://api.github.com/repos/yundom/Abigail/deployments","created_at":"2018-08-29T16:19:17Z","updated_at":"2018-08-30T04:29:07Z","pushed_at":"2018-08-30T04:39:49Z","git_url":"git://github.com/yundom/Abigail.git","ssh_url":"[email protected]:yundom/Abigail.git","clone_url":"https://github.com/yundom/Abigail.git","svn_url":"https://github.com/yundom/Abigail","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yundom/Abigail/pulls/4"},"html":{"href":"https://github.com/yundom/Abigail/pull/4"},"issue":{"href":"https://api.github.com/repos/yundom/Abigail/issues/4"},"comments":{"href":"https://api.github.com/repos/yundom/Abigail/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/yundom/Abigail/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/yundom/Abigail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yundom/Abigail/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/yundom/Abigail/statuses/f67d85eb152a09a69e5eb937fb419f51be3bccd4"}},"author_association":"COLLABORATOR"}} | {
"id": 146626995,
"name": "yundom/Abigail",
"url": "https://api.github.com/repos/yundom/Abigail"
} | {
"id": 619465,
"login": "yundom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/619465?",
"url": "https://api.github.com/users/yundom"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-08-30T04:38:09 | 8188883130 | {"actor":{"display_login":"yundom"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/comments/214543097","pull_request_review_id":151623251,"id":214543097,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDU0MzA5Nw==","diff_hunk":"@@ -102,54 +103,34 @@ Now that your fonts and default shell have been set up, install [zgen](https://g\n \n The `.zshrc`, `.zsh_aliases` & `.zsh_functions` files included in this kit enable:\n \n-* Automatic periodic updates of both zgen and your plugins\n-* Cross-session shared history so commands typed in one terminal window can be seen and searched in all other windows on the same machine.\n-* Deduping your command history\n-* Many more tab completions, courtesy of the [zsh-users/zsh-completions](https://github.com/zsh-users/zsh-completions) repository, and periodic updating to tip of master of that repository so you get updates to the extra tab completions.\n-* Proper command history search\n-* Syntax highlighting at the command line\n-* Tab completion of Rakefile targets\n-* Using [oh-my-zsh](https://github.com/robbyrussell/oh-my-zsh)-compatible plugins and themes (via the [zgen](https://github.com/tarjoilija/zgen) framework)\n-* Various helper functions for interacting with macOS's clipboard, audio volume, Spotlight and Quicklook. These will only load if you are on a macOS machine.\n-\n-## Customizations\n-\n-### Functions and Aliases\n-\n-The `.zshrc` included in this kit will automatically source any files it finds in `~/.zshrc.d`. This is to make it easy for you to add extra functions and aliases without having to maintain a separate fork of this repository. The files will be sourced in alphanumeric order and I suggest you use a naming scheme of `001-onething`, `002-something-else` etc to ensure they're loaded in the order you expect.\n-\n-### ZSH options.\n-\n-The quickstart kit does an opinionated (i.e. my way) setup of ZSH options and adds some functions and aliases I like on my systems. However, `~/.zshrc.d` is processed after the quickstart sets its aliases, functions and ZSH options, so if you don't care for something set up in the quickstart, you can override the offending item in a shell fragment file there.\n-\n-### Self-update Settings\n+# Contents of the kit","path":"Readme.md","position":121,"original_position":121,"commit_id":"235160f03c7b037046396663bbf69b5928c13546","original_commit_id":"235160f03c7b037046396663bbf69b5928c13546","user":{"login":"codeclimate[bot]","id":36754821,"node_id":"MDM6Qm90MzY3NTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/in/9403?v=4","gravatar_id":"","url":"https://api.github.com/users/codeclimate%5Bbot%5D","html_url":"https://github.com/apps/codeclimate","followers_url":"https://api.github.com/users/codeclimate%5Bbot%5D/followers","following_url":"https://api.github.com/users/codeclimate%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codeclimate%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codeclimate%5Bbot%5D/repos","events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Multiple top level headers in the same document","created_at":"2018-09-02T14:39:30Z","updated_at":"2018-09-02T14:39:31Z","html_url":"https://github.com/unixorn/zsh-quickstart-kit/pull/46#discussion_r214543097","pull_request_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/46","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/comments/214543097"},"html":{"href":"https://github.com/unixorn/zsh-quickstart-kit/pull/46#discussion_r214543097"},"pull_request":{"href":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/46","id":212595925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTk1OTI1","html_url":"https://github.com/unixorn/zsh-quickstart-kit/pull/46","diff_url":"https://github.com/unixorn/zsh-quickstart-kit/pull/46.diff","patch_url":"https://github.com/unixorn/zsh-quickstart-kit/pull/46.patch","issue_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues/46","number":46,"state":"open","locked":false,"title":"Reorganize Readme","user":{"login":"unixorn","id":23920,"node_id":"MDQ6VXNlcjIzOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/23920?v=4","gravatar_id":"","url":"https://api.github.com/users/unixorn","html_url":"https://github.com/unixorn","followers_url":"https://api.github.com/users/unixorn/followers","following_url":"https://api.github.com/users/unixorn/following{/other_user}","gists_url":"https://api.github.com/users/unixorn/gists{/gist_id}","starred_url":"https://api.github.com/users/unixorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixorn/subscriptions","organizations_url":"https://api.github.com/users/unixorn/orgs","repos_url":"https://api.github.com/users/unixorn/repos","events_url":"https://api.github.com/users/unixorn/events{/privacy}","received_events_url":"https://api.github.com/users/unixorn/received_events","type":"User","site_admin":false},"body":"* Reorganize the Readme\r\n* Clean up awkward phrasing\r\n* Make capitalization of Powerline consistent throughout.\r\n* Update TOC","created_at":"2018-09-02T14:37:04Z","updated_at":"2018-09-02T14:39:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4089f8e7458fac5b6b2163481ac3ede24f3a7262","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/46/commits","review_comments_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/46/comments","review_comment_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues/46/comments","statuses_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/statuses/235160f03c7b037046396663bbf69b5928c13546","head":{"label":"unixorn:text-revisions","ref":"text-revisions","sha":"235160f03c7b037046396663bbf69b5928c13546","user":{"login":"unixorn","id":23920,"node_id":"MDQ6VXNlcjIzOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/23920?v=4","gravatar_id":"","url":"https://api.github.com/users/unixorn","html_url":"https://github.com/unixorn","followers_url":"https://api.github.com/users/unixorn/followers","following_url":"https://api.github.com/users/unixorn/following{/other_user}","gists_url":"https://api.github.com/users/unixorn/gists{/gist_id}","starred_url":"https://api.github.com/users/unixorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixorn/subscriptions","organizations_url":"https://api.github.com/users/unixorn/orgs","repos_url":"https://api.github.com/users/unixorn/repos","events_url":"https://api.github.com/users/unixorn/events{/privacy}","received_events_url":"https://api.github.com/users/unixorn/received_events","type":"User","site_admin":false},"repo":{"id":17031094,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAzMTA5NA==","name":"zsh-quickstart-kit","full_name":"unixorn/zsh-quickstart-kit","owner":{"login":"unixorn","id":23920,"node_id":"MDQ6VXNlcjIzOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/23920?v=4","gravatar_id":"","url":"https://api.github.com/users/unixorn","html_url":"https://github.com/unixorn","followers_url":"https://api.github.com/users/unixorn/followers","following_url":"https://api.github.com/users/unixorn/following{/other_user}","gists_url":"https://api.github.com/users/unixorn/gists{/gist_id}","starred_url":"https://api.github.com/users/unixorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixorn/subscriptions","organizations_url":"https://api.github.com/users/unixorn/orgs","repos_url":"https://api.github.com/users/unixorn/repos","events_url":"https://api.github.com/users/unixorn/events{/privacy}","received_events_url":"https://api.github.com/users/unixorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unixorn/zsh-quickstart-kit","description":"Simple zsh quickstart for using zsh and zgen","fork":false,"url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit","forks_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/forks","keys_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/teams","hooks_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/hooks","issue_events_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues/events{/number}","events_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/events","assignees_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/assignees{/user}","branches_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/branches{/branch}","tags_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/tags","blobs_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/languages","stargazers_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/stargazers","contributors_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/contributors","subscribers_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/subscribers","subscription_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/subscription","commits_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/contents/{+path}","compare_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/merges","archive_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/downloads","issues_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues{/number}","pulls_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/labels{/name}","releases_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/releases{/id}","deployments_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/deployments","created_at":"2014-02-20T18:38:09Z","updated_at":"2018-09-01T16:48:31Z","pushed_at":"2018-09-02T14:39:14Z","git_url":"git://github.com/unixorn/zsh-quickstart-kit.git","ssh_url":"[email protected]:unixorn/zsh-quickstart-kit.git","clone_url":"https://github.com/unixorn/zsh-quickstart-kit.git","svn_url":"https://github.com/unixorn/zsh-quickstart-kit","homepage":"","size":160,"stargazers_count":167,"watchers_count":167,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":39,"open_issues":3,"watchers":167,"default_branch":"master"}},"base":{"label":"unixorn:master","ref":"master","sha":"6c4baf5e95bb49b4a2c87693b787a650e24def07","user":{"login":"unixorn","id":23920,"node_id":"MDQ6VXNlcjIzOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/23920?v=4","gravatar_id":"","url":"https://api.github.com/users/unixorn","html_url":"https://github.com/unixorn","followers_url":"https://api.github.com/users/unixorn/followers","following_url":"https://api.github.com/users/unixorn/following{/other_user}","gists_url":"https://api.github.com/users/unixorn/gists{/gist_id}","starred_url":"https://api.github.com/users/unixorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixorn/subscriptions","organizations_url":"https://api.github.com/users/unixorn/orgs","repos_url":"https://api.github.com/users/unixorn/repos","events_url":"https://api.github.com/users/unixorn/events{/privacy}","received_events_url":"https://api.github.com/users/unixorn/received_events","type":"User","site_admin":false},"repo":{"id":17031094,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAzMTA5NA==","name":"zsh-quickstart-kit","full_name":"unixorn/zsh-quickstart-kit","owner":{"login":"unixorn","id":23920,"node_id":"MDQ6VXNlcjIzOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/23920?v=4","gravatar_id":"","url":"https://api.github.com/users/unixorn","html_url":"https://github.com/unixorn","followers_url":"https://api.github.com/users/unixorn/followers","following_url":"https://api.github.com/users/unixorn/following{/other_user}","gists_url":"https://api.github.com/users/unixorn/gists{/gist_id}","starred_url":"https://api.github.com/users/unixorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixorn/subscriptions","organizations_url":"https://api.github.com/users/unixorn/orgs","repos_url":"https://api.github.com/users/unixorn/repos","events_url":"https://api.github.com/users/unixorn/events{/privacy}","received_events_url":"https://api.github.com/users/unixorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unixorn/zsh-quickstart-kit","description":"Simple zsh quickstart for using zsh and zgen","fork":false,"url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit","forks_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/forks","keys_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/teams","hooks_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/hooks","issue_events_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues/events{/number}","events_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/events","assignees_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/assignees{/user}","branches_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/branches{/branch}","tags_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/tags","blobs_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/languages","stargazers_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/stargazers","contributors_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/contributors","subscribers_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/subscribers","subscription_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/subscription","commits_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/contents/{+path}","compare_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/merges","archive_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/downloads","issues_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues{/number}","pulls_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/labels{/name}","releases_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/releases{/id}","deployments_url":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/deployments","created_at":"2014-02-20T18:38:09Z","updated_at":"2018-09-01T16:48:31Z","pushed_at":"2018-09-02T14:39:14Z","git_url":"git://github.com/unixorn/zsh-quickstart-kit.git","ssh_url":"[email protected]:unixorn/zsh-quickstart-kit.git","clone_url":"https://github.com/unixorn/zsh-quickstart-kit.git","svn_url":"https://github.com/unixorn/zsh-quickstart-kit","homepage":"","size":160,"stargazers_count":167,"watchers_count":167,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":39,"open_issues":3,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/46"},"html":{"href":"https://github.com/unixorn/zsh-quickstart-kit/pull/46"},"issue":{"href":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues/46"},"comments":{"href":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/unixorn/zsh-quickstart-kit/statuses/235160f03c7b037046396663bbf69b5928c13546"}},"author_association":"OWNER"}} | {
"id": 17031094,
"name": "unixorn/zsh-quickstart-kit",
"url": "https://api.github.com/repos/unixorn/zsh-quickstart-kit"
} | {
"id": 36754821,
"login": "codeclimate[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36754821?",
"url": "https://api.github.com/users/codeclimate[bot]"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-09-02T14:39:30 | 8202859613 | {"actor":{"display_login":"codeclimate"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/w0rp/ale/pulls/comments/172016687","pull_request_review_id":100974820,"id":172016687,"diff_hunk":"@@ -17,9 +20,17 @@ function! ale_linters#markdown#mdl#Handle(buffer, lines) abort\n return l:output\n endfunction\n \n+function! ale_linters#markdown#mdl#GetCommand(buffer) abort\n+ let l:executable = ale#Var(a:buffer, 'markdown_mdl_executable')\n+ let l:options = ale#Var(a:buffer, 'markdown_mdl_options')\n+\n+ return l:executable . (!empty(l:options) ? ' ' . l:options : '')\n+endfunction\n+\n+\n call ale#linter#Define('markdown', {\n \\ 'name': 'mdl',\n \\ 'executable': 'mdl',","path":"ale_linters/markdown/mdl.vim","position":25,"original_position":25,"commit_id":"7e20d9c63996c9e189651bf687d921e5f20d12cf","original_commit_id":"7e20d9c63996c9e189651bf687d921e5f20d12cf","user":{"login":"w0rp","id":3518142,"avatar_url":"https://avatars2.githubusercontent.com/u/3518142?v=4","gravatar_id":"","url":"https://api.github.com/users/w0rp","html_url":"https://github.com/w0rp","followers_url":"https://api.github.com/users/w0rp/followers","following_url":"https://api.github.com/users/w0rp/following{/other_user}","gists_url":"https://api.github.com/users/w0rp/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rp/subscriptions","organizations_url":"https://api.github.com/users/w0rp/orgs","repos_url":"https://api.github.com/users/w0rp/repos","events_url":"https://api.github.com/users/w0rp/events{/privacy}","received_events_url":"https://api.github.com/users/w0rp/received_events","type":"User","site_admin":false},"body":"Also this needed to be updated, but I'll sort it out.","created_at":"2018-03-03T13:17:13Z","updated_at":"2018-03-03T13:17:13Z","html_url":"https://github.com/w0rp/ale/pull/1377#discussion_r172016687","pull_request_url":"https://api.github.com/repos/w0rp/ale/pulls/1377","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/w0rp/ale/pulls/comments/172016687"},"html":{"href":"https://github.com/w0rp/ale/pull/1377#discussion_r172016687"},"pull_request":{"href":"https://api.github.com/repos/w0rp/ale/pulls/1377"}}},"pull_request":{"url":"https://api.github.com/repos/w0rp/ale/pulls/1377","id":171314955,"html_url":"https://github.com/w0rp/ale/pull/1377","diff_url":"https://github.com/w0rp/ale/pull/1377.diff","patch_url":"https://github.com/w0rp/ale/pull/1377.patch","issue_url":"https://api.github.com/repos/w0rp/ale/issues/1377","number":1377,"state":"closed","locked":false,"title":"Add options for markdown_mdl linter","user":{"login":"joshleeb","id":2503518,"avatar_url":"https://avatars2.githubusercontent.com/u/2503518?v=4","gravatar_id":"","url":"https://api.github.com/users/joshleeb","html_url":"https://github.com/joshleeb","followers_url":"https://api.github.com/users/joshleeb/followers","following_url":"https://api.github.com/users/joshleeb/following{/other_user}","gists_url":"https://api.github.com/users/joshleeb/gists{/gist_id}","starred_url":"https://api.github.com/users/joshleeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshleeb/subscriptions","organizations_url":"https://api.github.com/users/joshleeb/orgs","repos_url":"https://api.github.com/users/joshleeb/repos","events_url":"https://api.github.com/users/joshleeb/events{/privacy}","received_events_url":"https://api.github.com/users/joshleeb/received_events","type":"User","site_admin":false},"body":"Add options to specify the executable and the command options for the Markdown `mdl` linter.","created_at":"2018-02-26T09:02:16Z","updated_at":"2018-03-03T13:17:13Z","closed_at":"2018-03-03T13:16:28Z","merged_at":"2018-03-03T13:16:28Z","merge_commit_sha":"857723e7d569c8260d95d2ce261fbf064e5bfa9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w0rp/ale/pulls/1377/commits","review_comments_url":"https://api.github.com/repos/w0rp/ale/pulls/1377/comments","review_comment_url":"https://api.github.com/repos/w0rp/ale/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w0rp/ale/issues/1377/comments","statuses_url":"https://api.github.com/repos/w0rp/ale/statuses/7e20d9c63996c9e189651bf687d921e5f20d12cf","head":{"label":"joshleeb:markdown-mdl-options","ref":"markdown-mdl-options","sha":"7e20d9c63996c9e189651bf687d921e5f20d12cf","user":{"login":"joshleeb","id":2503518,"avatar_url":"https://avatars2.githubusercontent.com/u/2503518?v=4","gravatar_id":"","url":"https://api.github.com/users/joshleeb","html_url":"https://github.com/joshleeb","followers_url":"https://api.github.com/users/joshleeb/followers","following_url":"https://api.github.com/users/joshleeb/following{/other_user}","gists_url":"https://api.github.com/users/joshleeb/gists{/gist_id}","starred_url":"https://api.github.com/users/joshleeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshleeb/subscriptions","organizations_url":"https://api.github.com/users/joshleeb/orgs","repos_url":"https://api.github.com/users/joshleeb/repos","events_url":"https://api.github.com/users/joshleeb/events{/privacy}","received_events_url":"https://api.github.com/users/joshleeb/received_events","type":"User","site_admin":false},"repo":{"id":122904549,"name":"ale","full_name":"joshleeb/ale","owner":{"login":"joshleeb","id":2503518,"avatar_url":"https://avatars2.githubusercontent.com/u/2503518?v=4","gravatar_id":"","url":"https://api.github.com/users/joshleeb","html_url":"https://github.com/joshleeb","followers_url":"https://api.github.com/users/joshleeb/followers","following_url":"https://api.github.com/users/joshleeb/following{/other_user}","gists_url":"https://api.github.com/users/joshleeb/gists{/gist_id}","starred_url":"https://api.github.com/users/joshleeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshleeb/subscriptions","organizations_url":"https://api.github.com/users/joshleeb/orgs","repos_url":"https://api.github.com/users/joshleeb/repos","events_url":"https://api.github.com/users/joshleeb/events{/privacy}","received_events_url":"https://api.github.com/users/joshleeb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshleeb/ale","description":"Asynchronous Lint Engine","fork":true,"url":"https://api.github.com/repos/joshleeb/ale","forks_url":"https://api.github.com/repos/joshleeb/ale/forks","keys_url":"https://api.github.com/repos/joshleeb/ale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshleeb/ale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshleeb/ale/teams","hooks_url":"https://api.github.com/repos/joshleeb/ale/hooks","issue_events_url":"https://api.github.com/repos/joshleeb/ale/issues/events{/number}","events_url":"https://api.github.com/repos/joshleeb/ale/events","assignees_url":"https://api.github.com/repos/joshleeb/ale/assignees{/user}","branches_url":"https://api.github.com/repos/joshleeb/ale/branches{/branch}","tags_url":"https://api.github.com/repos/joshleeb/ale/tags","blobs_url":"https://api.github.com/repos/joshleeb/ale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshleeb/ale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshleeb/ale/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshleeb/ale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshleeb/ale/statuses/{sha}","languages_url":"https://api.github.com/repos/joshleeb/ale/languages","stargazers_url":"https://api.github.com/repos/joshleeb/ale/stargazers","contributors_url":"https://api.github.com/repos/joshleeb/ale/contributors","subscribers_url":"https://api.github.com/repos/joshleeb/ale/subscribers","subscription_url":"https://api.github.com/repos/joshleeb/ale/subscription","commits_url":"https://api.github.com/repos/joshleeb/ale/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshleeb/ale/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshleeb/ale/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshleeb/ale/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshleeb/ale/contents/{+path}","compare_url":"https://api.github.com/repos/joshleeb/ale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshleeb/ale/merges","archive_url":"https://api.github.com/repos/joshleeb/ale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshleeb/ale/downloads","issues_url":"https://api.github.com/repos/joshleeb/ale/issues{/number}","pulls_url":"https://api.github.com/repos/joshleeb/ale/pulls{/number}","milestones_url":"https://api.github.com/repos/joshleeb/ale/milestones{/number}","notifications_url":"https://api.github.com/repos/joshleeb/ale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshleeb/ale/labels{/name}","releases_url":"https://api.github.com/repos/joshleeb/ale/releases{/id}","deployments_url":"https://api.github.com/repos/joshleeb/ale/deployments","created_at":"2018-02-26T02:58:05Z","updated_at":"2018-02-26T02:58:08Z","pushed_at":"2018-02-26T09:11:08Z","git_url":"git://github.com/joshleeb/ale.git","ssh_url":"[email protected]:joshleeb/ale.git","clone_url":"https://github.com/joshleeb/ale.git","svn_url":"https://github.com/joshleeb/ale","homepage":null,"size":11278,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w0rp:master","ref":"master","sha":"7ec684206c1395a940d8ad2d26d59773a432115c","user":{"login":"w0rp","id":3518142,"avatar_url":"https://avatars2.githubusercontent.com/u/3518142?v=4","gravatar_id":"","url":"https://api.github.com/users/w0rp","html_url":"https://github.com/w0rp","followers_url":"https://api.github.com/users/w0rp/followers","following_url":"https://api.github.com/users/w0rp/following{/other_user}","gists_url":"https://api.github.com/users/w0rp/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rp/subscriptions","organizations_url":"https://api.github.com/users/w0rp/orgs","repos_url":"https://api.github.com/users/w0rp/repos","events_url":"https://api.github.com/users/w0rp/events{/privacy}","received_events_url":"https://api.github.com/users/w0rp/received_events","type":"User","site_admin":false},"repo":{"id":67747748,"name":"ale","full_name":"w0rp/ale","owner":{"login":"w0rp","id":3518142,"avatar_url":"https://avatars2.githubusercontent.com/u/3518142?v=4","gravatar_id":"","url":"https://api.github.com/users/w0rp","html_url":"https://github.com/w0rp","followers_url":"https://api.github.com/users/w0rp/followers","following_url":"https://api.github.com/users/w0rp/following{/other_user}","gists_url":"https://api.github.com/users/w0rp/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rp/subscriptions","organizations_url":"https://api.github.com/users/w0rp/orgs","repos_url":"https://api.github.com/users/w0rp/repos","events_url":"https://api.github.com/users/w0rp/events{/privacy}","received_events_url":"https://api.github.com/users/w0rp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/w0rp/ale","description":"Asynchronous Lint Engine","fork":false,"url":"https://api.github.com/repos/w0rp/ale","forks_url":"https://api.github.com/repos/w0rp/ale/forks","keys_url":"https://api.github.com/repos/w0rp/ale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w0rp/ale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w0rp/ale/teams","hooks_url":"https://api.github.com/repos/w0rp/ale/hooks","issue_events_url":"https://api.github.com/repos/w0rp/ale/issues/events{/number}","events_url":"https://api.github.com/repos/w0rp/ale/events","assignees_url":"https://api.github.com/repos/w0rp/ale/assignees{/user}","branches_url":"https://api.github.com/repos/w0rp/ale/branches{/branch}","tags_url":"https://api.github.com/repos/w0rp/ale/tags","blobs_url":"https://api.github.com/repos/w0rp/ale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w0rp/ale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w0rp/ale/git/refs{/sha}","trees_url":"https://api.github.com/repos/w0rp/ale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w0rp/ale/statuses/{sha}","languages_url":"https://api.github.com/repos/w0rp/ale/languages","stargazers_url":"https://api.github.com/repos/w0rp/ale/stargazers","contributors_url":"https://api.github.com/repos/w0rp/ale/contributors","subscribers_url":"https://api.github.com/repos/w0rp/ale/subscribers","subscription_url":"https://api.github.com/repos/w0rp/ale/subscription","commits_url":"https://api.github.com/repos/w0rp/ale/commits{/sha}","git_commits_url":"https://api.github.com/repos/w0rp/ale/git/commits{/sha}","comments_url":"https://api.github.com/repos/w0rp/ale/comments{/number}","issue_comment_url":"https://api.github.com/repos/w0rp/ale/issues/comments{/number}","contents_url":"https://api.github.com/repos/w0rp/ale/contents/{+path}","compare_url":"https://api.github.com/repos/w0rp/ale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w0rp/ale/merges","archive_url":"https://api.github.com/repos/w0rp/ale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w0rp/ale/downloads","issues_url":"https://api.github.com/repos/w0rp/ale/issues{/number}","pulls_url":"https://api.github.com/repos/w0rp/ale/pulls{/number}","milestones_url":"https://api.github.com/repos/w0rp/ale/milestones{/number}","notifications_url":"https://api.github.com/repos/w0rp/ale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w0rp/ale/labels{/name}","releases_url":"https://api.github.com/repos/w0rp/ale/releases{/id}","deployments_url":"https://api.github.com/repos/w0rp/ale/deployments","created_at":"2016-09-08T23:22:45Z","updated_at":"2018-03-03T12:05:27Z","pushed_at":"2018-03-03T13:16:29Z","git_url":"git://github.com/w0rp/ale.git","ssh_url":"[email protected]:w0rp/ale.git","clone_url":"https://github.com/w0rp/ale.git","svn_url":"https://github.com/w0rp/ale","homepage":null,"size":11352,"stargazers_count":4214,"watchers_count":4214,"language":"Vim script","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":442,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":442,"open_issues":151,"watchers":4214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w0rp/ale/pulls/1377"},"html":{"href":"https://github.com/w0rp/ale/pull/1377"},"issue":{"href":"https://api.github.com/repos/w0rp/ale/issues/1377"},"comments":{"href":"https://api.github.com/repos/w0rp/ale/issues/1377/comments"},"review_comments":{"href":"https://api.github.com/repos/w0rp/ale/pulls/1377/comments"},"review_comment":{"href":"https://api.github.com/repos/w0rp/ale/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w0rp/ale/pulls/1377/commits"},"statuses":{"href":"https://api.github.com/repos/w0rp/ale/statuses/7e20d9c63996c9e189651bf687d921e5f20d12cf"}},"author_association":"CONTRIBUTOR"}} | {
"id": 67747748,
"name": "w0rp/ale",
"url": "https://api.github.com/repos/w0rp/ale"
} | {
"id": 3518142,
"login": "w0rp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3518142?",
"url": "https://api.github.com/users/w0rp"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-03-03T13:17:13 | 7325767481 | {"actor":{"display_login":"w0rp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/comments/182550017","pull_request_review_id":113368273,"id":182550017,"diff_hunk":"@@ -1,34 +1,22 @@\n .container\n .row.justify-content-center\n- .col-md-4\n- %h2.header= t(\".sign_up\")\n- = form_for(resource, as: resource_name, url: registration_path(resource_name)) do |f|\n- = devise_error_messages!\n+ .col-lg-5.col-md-6\n+ %h2.header= t('.sign_up')\n+ = simple_form_for(resource, as: resource_name, url: registration_path(resource_name), html: { novalidate: false }) do |f|\n .form-group\n- = f.label :email\n- %br\n- = f.email_field :email, autofocus: true, autocomplete: \"email\", class: \"form-control\"\n+ = f.input :email, label: 'Email', autofocus: true, autocomplete: 'email', input_html: { class: 'form-control' }, placeholder: '[email protected]', required: true\n .form-group\n- = f.label :name, t(\".name\")\n- %br\n- = f.text_field :name, class: \"form-control\"\n+ = f.input :name, label: t('.name'), input_html: { class: 'form-control', minlength: 3, maxlength: 30 }\n .form-group\n- = f.label :surname, t(\".surname\")\n- %br\n- = f.text_field :surname, class: \"form-control\"\n+ = f.input :surname, label: t('.surname'), input_html: { class: 'form-control', minlength: 3, maxlength: 30 }\n .form-group\n- = f.label :phone_number, t(\".phone_number\")\n- %br\n- = f.text_field :phone_number, class: \"form-control\"\n+ = f.input :phone_number, label: t('.phone_number'), input_html: { class: 'form-control' }, placeholder: '+XXXXXXXXXXXX', required: false","path":"app/views/devise/registrations/new.html.haml","position":29,"original_position":29,"commit_id":"488bc1c36bddfb2f6826c6e722b0cefe2e81e178","original_commit_id":"488bc1c36bddfb2f6826c6e722b0cefe2e81e178","user":{"login":"shevchukm","id":15895287,"avatar_url":"https://avatars2.githubusercontent.com/u/15895287?v=4","gravatar_id":"","url":"https://api.github.com/users/shevchukm","html_url":"https://github.com/shevchukm","followers_url":"https://api.github.com/users/shevchukm/followers","following_url":"https://api.github.com/users/shevchukm/following{/other_user}","gists_url":"https://api.github.com/users/shevchukm/gists{/gist_id}","starred_url":"https://api.github.com/users/shevchukm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shevchukm/subscriptions","organizations_url":"https://api.github.com/users/shevchukm/orgs","repos_url":"https://api.github.com/users/shevchukm/repos","events_url":"https://api.github.com/users/shevchukm/events{/privacy}","received_events_url":"https://api.github.com/users/shevchukm/received_events","type":"User","site_admin":false},"body":"yes","created_at":"2018-04-18T19:55:03Z","updated_at":"2018-04-18T19:55:03Z","html_url":"https://github.com/sashamuliar/ProDobro/pull/27#discussion_r182550017","pull_request_url":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/27","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/comments/182550017"},"html":{"href":"https://github.com/sashamuliar/ProDobro/pull/27#discussion_r182550017"},"pull_request":{"href":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/27"}},"in_reply_to_id":182414406},"pull_request":{"url":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/27","id":182102270,"html_url":"https://github.com/sashamuliar/ProDobro/pull/27","diff_url":"https://github.com/sashamuliar/ProDobro/pull/27.diff","patch_url":"https://github.com/sashamuliar/ProDobro/pull/27.patch","issue_url":"https://api.github.com/repos/sashamuliar/ProDobro/issues/27","number":27,"state":"open","locked":false,"title":"PROD-85: Add 'Simple form' + errors style + front-end validation","user":{"login":"Pavliv","id":15639895,"avatar_url":"https://avatars3.githubusercontent.com/u/15639895?v=4","gravatar_id":"","url":"https://api.github.com/users/Pavliv","html_url":"https://github.com/Pavliv","followers_url":"https://api.github.com/users/Pavliv/followers","following_url":"https://api.github.com/users/Pavliv/following{/other_user}","gists_url":"https://api.github.com/users/Pavliv/gists{/gist_id}","starred_url":"https://api.github.com/users/Pavliv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pavliv/subscriptions","organizations_url":"https://api.github.com/users/Pavliv/orgs","repos_url":"https://api.github.com/users/Pavliv/repos","events_url":"https://api.github.com/users/Pavliv/events{/privacy}","received_events_url":"https://api.github.com/users/Pavliv/received_events","type":"User","site_admin":false},"body":"# Reviewers\r\n\r\n- [ ] @vikabelous\r\n- [ ] @okohuch\r\n- [x] @anastasiabalaban\r\n- [x] @gnaizer \r\n\r\n\r\n\r\nhttps://ssu-jira.softserveinc.com/browse/PROD-85\r\n\r\n\r\n# Description\r\n\r\nAdd gem Simple form\r\nAdd translations for fields and errors\r\nAdd front-end validation\r\n\r\n\r\n\r\n# Checklist:\r\n\r\n- [x] Rubocop doesn't raise any warnings and offenses\r\n- [x] PR is approved by 2 team mates\r\n- [ ] PR is approved by 2 experts\r\n","created_at":"2018-04-17T09:20:43Z","updated_at":"2018-04-18T19:55:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"819ee9cb8352e0fe69193966c0f78bc48f7b8039","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vikabelous","id":3591865,"avatar_url":"https://avatars1.githubusercontent.com/u/3591865?v=4","gravatar_id":"","url":"https://api.github.com/users/vikabelous","html_url":"https://github.com/vikabelous","followers_url":"https://api.github.com/users/vikabelous/followers","following_url":"https://api.github.com/users/vikabelous/following{/other_user}","gists_url":"https://api.github.com/users/vikabelous/gists{/gist_id}","starred_url":"https://api.github.com/users/vikabelous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikabelous/subscriptions","organizations_url":"https://api.github.com/users/vikabelous/orgs","repos_url":"https://api.github.com/users/vikabelous/repos","events_url":"https://api.github.com/users/vikabelous/events{/privacy}","received_events_url":"https://api.github.com/users/vikabelous/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":896686618,"url":"https://api.github.com/repos/sashamuliar/ProDobro/labels/needs%20review","name":"needs review","color":"f4d6ad","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/27/commits","review_comments_url":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/27/comments","review_comment_url":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sashamuliar/ProDobro/issues/27/comments","statuses_url":"https://api.github.com/repos/sashamuliar/ProDobro/statuses/488bc1c36bddfb2f6826c6e722b0cefe2e81e178","head":{"label":"sashamuliar:develop_PROD-85","ref":"develop_PROD-85","sha":"488bc1c36bddfb2f6826c6e722b0cefe2e81e178","user":{"login":"sashamuliar","id":14817893,"avatar_url":"https://avatars0.githubusercontent.com/u/14817893?v=4","gravatar_id":"","url":"https://api.github.com/users/sashamuliar","html_url":"https://github.com/sashamuliar","followers_url":"https://api.github.com/users/sashamuliar/followers","following_url":"https://api.github.com/users/sashamuliar/following{/other_user}","gists_url":"https://api.github.com/users/sashamuliar/gists{/gist_id}","starred_url":"https://api.github.com/users/sashamuliar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashamuliar/subscriptions","organizations_url":"https://api.github.com/users/sashamuliar/orgs","repos_url":"https://api.github.com/users/sashamuliar/repos","events_url":"https://api.github.com/users/sashamuliar/events{/privacy}","received_events_url":"https://api.github.com/users/sashamuliar/received_events","type":"User","site_admin":false},"repo":{"id":127426528,"name":"ProDobro","full_name":"sashamuliar/ProDobro","owner":{"login":"sashamuliar","id":14817893,"avatar_url":"https://avatars0.githubusercontent.com/u/14817893?v=4","gravatar_id":"","url":"https://api.github.com/users/sashamuliar","html_url":"https://github.com/sashamuliar","followers_url":"https://api.github.com/users/sashamuliar/followers","following_url":"https://api.github.com/users/sashamuliar/following{/other_user}","gists_url":"https://api.github.com/users/sashamuliar/gists{/gist_id}","starred_url":"https://api.github.com/users/sashamuliar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashamuliar/subscriptions","organizations_url":"https://api.github.com/users/sashamuliar/orgs","repos_url":"https://api.github.com/users/sashamuliar/repos","events_url":"https://api.github.com/users/sashamuliar/events{/privacy}","received_events_url":"https://api.github.com/users/sashamuliar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sashamuliar/ProDobro","description":null,"fork":false,"url":"https://api.github.com/repos/sashamuliar/ProDobro","forks_url":"https://api.github.com/repos/sashamuliar/ProDobro/forks","keys_url":"https://api.github.com/repos/sashamuliar/ProDobro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sashamuliar/ProDobro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sashamuliar/ProDobro/teams","hooks_url":"https://api.github.com/repos/sashamuliar/ProDobro/hooks","issue_events_url":"https://api.github.com/repos/sashamuliar/ProDobro/issues/events{/number}","events_url":"https://api.github.com/repos/sashamuliar/ProDobro/events","assignees_url":"https://api.github.com/repos/sashamuliar/ProDobro/assignees{/user}","branches_url":"https://api.github.com/repos/sashamuliar/ProDobro/branches{/branch}","tags_url":"https://api.github.com/repos/sashamuliar/ProDobro/tags","blobs_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/refs{/sha}","trees_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sashamuliar/ProDobro/statuses/{sha}","languages_url":"https://api.github.com/repos/sashamuliar/ProDobro/languages","stargazers_url":"https://api.github.com/repos/sashamuliar/ProDobro/stargazers","contributors_url":"https://api.github.com/repos/sashamuliar/ProDobro/contributors","subscribers_url":"https://api.github.com/repos/sashamuliar/ProDobro/subscribers","subscription_url":"https://api.github.com/repos/sashamuliar/ProDobro/subscription","commits_url":"https://api.github.com/repos/sashamuliar/ProDobro/commits{/sha}","git_commits_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/commits{/sha}","comments_url":"https://api.github.com/repos/sashamuliar/ProDobro/comments{/number}","issue_comment_url":"https://api.github.com/repos/sashamuliar/ProDobro/issues/comments{/number}","contents_url":"https://api.github.com/repos/sashamuliar/ProDobro/contents/{+path}","compare_url":"https://api.github.com/repos/sashamuliar/ProDobro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sashamuliar/ProDobro/merges","archive_url":"https://api.github.com/repos/sashamuliar/ProDobro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sashamuliar/ProDobro/downloads","issues_url":"https://api.github.com/repos/sashamuliar/ProDobro/issues{/number}","pulls_url":"https://api.github.com/repos/sashamuliar/ProDobro/pulls{/number}","milestones_url":"https://api.github.com/repos/sashamuliar/ProDobro/milestones{/number}","notifications_url":"https://api.github.com/repos/sashamuliar/ProDobro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sashamuliar/ProDobro/labels{/name}","releases_url":"https://api.github.com/repos/sashamuliar/ProDobro/releases{/id}","deployments_url":"https://api.github.com/repos/sashamuliar/ProDobro/deployments","created_at":"2018-03-30T12:36:20Z","updated_at":"2018-04-17T21:21:05Z","pushed_at":"2018-04-18T19:53:55Z","git_url":"git://github.com/sashamuliar/ProDobro.git","ssh_url":"[email protected]:sashamuliar/ProDobro.git","clone_url":"https://github.com/sashamuliar/ProDobro.git","svn_url":"https://github.com/sashamuliar/ProDobro","homepage":null,"size":426,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"sashamuliar:develop","ref":"develop","sha":"74f2cc27f393a3b7efc29cd527f76cbf6b6d772a","user":{"login":"sashamuliar","id":14817893,"avatar_url":"https://avatars0.githubusercontent.com/u/14817893?v=4","gravatar_id":"","url":"https://api.github.com/users/sashamuliar","html_url":"https://github.com/sashamuliar","followers_url":"https://api.github.com/users/sashamuliar/followers","following_url":"https://api.github.com/users/sashamuliar/following{/other_user}","gists_url":"https://api.github.com/users/sashamuliar/gists{/gist_id}","starred_url":"https://api.github.com/users/sashamuliar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashamuliar/subscriptions","organizations_url":"https://api.github.com/users/sashamuliar/orgs","repos_url":"https://api.github.com/users/sashamuliar/repos","events_url":"https://api.github.com/users/sashamuliar/events{/privacy}","received_events_url":"https://api.github.com/users/sashamuliar/received_events","type":"User","site_admin":false},"repo":{"id":127426528,"name":"ProDobro","full_name":"sashamuliar/ProDobro","owner":{"login":"sashamuliar","id":14817893,"avatar_url":"https://avatars0.githubusercontent.com/u/14817893?v=4","gravatar_id":"","url":"https://api.github.com/users/sashamuliar","html_url":"https://github.com/sashamuliar","followers_url":"https://api.github.com/users/sashamuliar/followers","following_url":"https://api.github.com/users/sashamuliar/following{/other_user}","gists_url":"https://api.github.com/users/sashamuliar/gists{/gist_id}","starred_url":"https://api.github.com/users/sashamuliar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashamuliar/subscriptions","organizations_url":"https://api.github.com/users/sashamuliar/orgs","repos_url":"https://api.github.com/users/sashamuliar/repos","events_url":"https://api.github.com/users/sashamuliar/events{/privacy}","received_events_url":"https://api.github.com/users/sashamuliar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sashamuliar/ProDobro","description":null,"fork":false,"url":"https://api.github.com/repos/sashamuliar/ProDobro","forks_url":"https://api.github.com/repos/sashamuliar/ProDobro/forks","keys_url":"https://api.github.com/repos/sashamuliar/ProDobro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sashamuliar/ProDobro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sashamuliar/ProDobro/teams","hooks_url":"https://api.github.com/repos/sashamuliar/ProDobro/hooks","issue_events_url":"https://api.github.com/repos/sashamuliar/ProDobro/issues/events{/number}","events_url":"https://api.github.com/repos/sashamuliar/ProDobro/events","assignees_url":"https://api.github.com/repos/sashamuliar/ProDobro/assignees{/user}","branches_url":"https://api.github.com/repos/sashamuliar/ProDobro/branches{/branch}","tags_url":"https://api.github.com/repos/sashamuliar/ProDobro/tags","blobs_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/refs{/sha}","trees_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sashamuliar/ProDobro/statuses/{sha}","languages_url":"https://api.github.com/repos/sashamuliar/ProDobro/languages","stargazers_url":"https://api.github.com/repos/sashamuliar/ProDobro/stargazers","contributors_url":"https://api.github.com/repos/sashamuliar/ProDobro/contributors","subscribers_url":"https://api.github.com/repos/sashamuliar/ProDobro/subscribers","subscription_url":"https://api.github.com/repos/sashamuliar/ProDobro/subscription","commits_url":"https://api.github.com/repos/sashamuliar/ProDobro/commits{/sha}","git_commits_url":"https://api.github.com/repos/sashamuliar/ProDobro/git/commits{/sha}","comments_url":"https://api.github.com/repos/sashamuliar/ProDobro/comments{/number}","issue_comment_url":"https://api.github.com/repos/sashamuliar/ProDobro/issues/comments{/number}","contents_url":"https://api.github.com/repos/sashamuliar/ProDobro/contents/{+path}","compare_url":"https://api.github.com/repos/sashamuliar/ProDobro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sashamuliar/ProDobro/merges","archive_url":"https://api.github.com/repos/sashamuliar/ProDobro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sashamuliar/ProDobro/downloads","issues_url":"https://api.github.com/repos/sashamuliar/ProDobro/issues{/number}","pulls_url":"https://api.github.com/repos/sashamuliar/ProDobro/pulls{/number}","milestones_url":"https://api.github.com/repos/sashamuliar/ProDobro/milestones{/number}","notifications_url":"https://api.github.com/repos/sashamuliar/ProDobro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sashamuliar/ProDobro/labels{/name}","releases_url":"https://api.github.com/repos/sashamuliar/ProDobro/releases{/id}","deployments_url":"https://api.github.com/repos/sashamuliar/ProDobro/deployments","created_at":"2018-03-30T12:36:20Z","updated_at":"2018-04-17T21:21:05Z","pushed_at":"2018-04-18T19:53:55Z","git_url":"git://github.com/sashamuliar/ProDobro.git","ssh_url":"[email protected]:sashamuliar/ProDobro.git","clone_url":"https://github.com/sashamuliar/ProDobro.git","svn_url":"https://github.com/sashamuliar/ProDobro","homepage":null,"size":426,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/27"},"html":{"href":"https://github.com/sashamuliar/ProDobro/pull/27"},"issue":{"href":"https://api.github.com/repos/sashamuliar/ProDobro/issues/27"},"comments":{"href":"https://api.github.com/repos/sashamuliar/ProDobro/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sashamuliar/ProDobro/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/sashamuliar/ProDobro/statuses/488bc1c36bddfb2f6826c6e722b0cefe2e81e178"}},"author_association":"COLLABORATOR"}} | {
"id": 127426528,
"name": "sashamuliar/ProDobro",
"url": "https://api.github.com/repos/sashamuliar/ProDobro"
} | {
"id": 15895287,
"login": "shevchukm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15895287?",
"url": "https://api.github.com/users/shevchukm"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-04-18T19:55:03 | 7551371577 | {"actor":{"display_login":"shevchukm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/comments/242702157","pull_request_review_id":186277749,"id":242702157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjcwMjE1Nw==","diff_hunk":"@@ -75,7 +75,7 @@ \\chapter{\\textit{}Cross-Validation}\n \\label{fig:models}\n \\end{figure*}\n \n-As stated in \\cite{Kohavi1995study}, the LOO method gives a 0\\% accuracy on the test set when the number of target labels are equal to the number of instances in the dataset. It is shown that the $k$-fold CV method gives much better results, due to its lower variance, especially when $k = {10, 20}$. Furthermore, R. Kohavi et al. state that the best accuracy is achieved when using the stratified cross-validation method, since this has the least bias.\n+As stated in \\cite{kohavi1995study}, the LOO method gives a 0\\% accuracy on the test set when the number of target labels are equal to the number of instances in the dataset. It is shown that the $k$-fold CV method gives much better results, due to its lower variance, especially when $k = {10, 20}$. Furthermore, R. Kohavi et al. state that the best accuracy is achieved when using the stratified cross-validation method, since this has the least bias.","path":"terms/crossvalidation_lmd.tex","position":5,"original_position":5,"commit_id":"7cbd248e0b3b9e9f55ba3efad37059bc80ba81a7","original_commit_id":"7cbd248e0b3b9e9f55ba3efad37059bc80ba81a7","user":{"login":"laramdemajo","id":23550363,"node_id":"MDQ6VXNlcjIzNTUwMzYz","avatar_url":"https://avatars1.githubusercontent.com/u/23550363?v=4","gravatar_id":"","url":"https://api.github.com/users/laramdemajo","html_url":"https://github.com/laramdemajo","followers_url":"https://api.github.com/users/laramdemajo/followers","following_url":"https://api.github.com/users/laramdemajo/following{/other_user}","gists_url":"https://api.github.com/users/laramdemajo/gists{/gist_id}","starred_url":"https://api.github.com/users/laramdemajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laramdemajo/subscriptions","organizations_url":"https://api.github.com/users/laramdemajo/orgs","repos_url":"https://api.github.com/users/laramdemajo/repos","events_url":"https://api.github.com/users/laramdemajo/events{/privacy}","received_events_url":"https://api.github.com/users/laramdemajo/received_events","type":"User","site_admin":false},"body":"thanks","created_at":"2018-12-18T20:56:20Z","updated_at":"2018-12-18T20:56:20Z","html_url":"https://github.com/jp-um/machine_learning_handbook/pull/6#discussion_r242702157","pull_request_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/6","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/comments/242702157"},"html":{"href":"https://github.com/jp-um/machine_learning_handbook/pull/6#discussion_r242702157"},"pull_request":{"href":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/6"}},"in_reply_to_id":242004631},"pull_request":{"url":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/6","id":239002023,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDAyMDIz","html_url":"https://github.com/jp-um/machine_learning_handbook/pull/6","diff_url":"https://github.com/jp-um/machine_learning_handbook/pull/6.diff","patch_url":"https://github.com/jp-um/machine_learning_handbook/pull/6.patch","issue_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/issues/6","number":6,"state":"closed","locked":false,"title":"Fix bib errors.","user":{"login":"df-um","id":45925834,"node_id":"MDQ6VXNlcjQ1OTI1ODM0","avatar_url":"https://avatars0.githubusercontent.com/u/45925834?v=4","gravatar_id":"","url":"https://api.github.com/users/df-um","html_url":"https://github.com/df-um","followers_url":"https://api.github.com/users/df-um/followers","following_url":"https://api.github.com/users/df-um/following{/other_user}","gists_url":"https://api.github.com/users/df-um/gists{/gist_id}","starred_url":"https://api.github.com/users/df-um/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/df-um/subscriptions","organizations_url":"https://api.github.com/users/df-um/orgs","repos_url":"https://api.github.com/users/df-um/repos","events_url":"https://api.github.com/users/df-um/events{/privacy}","received_events_url":"https://api.github.com/users/df-um/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-17T00:36:25Z","updated_at":"2018-12-18T20:56:20Z","closed_at":"2018-12-17T12:58:09Z","merged_at":null,"merge_commit_sha":"8a4755c3b6d3363832a8f705889af0315735160f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/6/commits","review_comments_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/6/comments","review_comment_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/issues/6/comments","statuses_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/statuses/7cbd248e0b3b9e9f55ba3efad37059bc80ba81a7","head":{"label":"df-um:fix_bib","ref":"fix_bib","sha":"7cbd248e0b3b9e9f55ba3efad37059bc80ba81a7","user":{"login":"df-um","id":45925834,"node_id":"MDQ6VXNlcjQ1OTI1ODM0","avatar_url":"https://avatars0.githubusercontent.com/u/45925834?v=4","gravatar_id":"","url":"https://api.github.com/users/df-um","html_url":"https://github.com/df-um","followers_url":"https://api.github.com/users/df-um/followers","following_url":"https://api.github.com/users/df-um/following{/other_user}","gists_url":"https://api.github.com/users/df-um/gists{/gist_id}","starred_url":"https://api.github.com/users/df-um/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/df-um/subscriptions","organizations_url":"https://api.github.com/users/df-um/orgs","repos_url":"https://api.github.com/users/df-um/repos","events_url":"https://api.github.com/users/df-um/events{/privacy}","received_events_url":"https://api.github.com/users/df-um/received_events","type":"User","site_admin":false},"repo":{"id":162053837,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIwNTM4Mzc=","name":"machine_learning_handbook","full_name":"df-um/machine_learning_handbook","private":false,"owner":{"login":"df-um","id":45925834,"node_id":"MDQ6VXNlcjQ1OTI1ODM0","avatar_url":"https://avatars0.githubusercontent.com/u/45925834?v=4","gravatar_id":"","url":"https://api.github.com/users/df-um","html_url":"https://github.com/df-um","followers_url":"https://api.github.com/users/df-um/followers","following_url":"https://api.github.com/users/df-um/following{/other_user}","gists_url":"https://api.github.com/users/df-um/gists{/gist_id}","starred_url":"https://api.github.com/users/df-um/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/df-um/subscriptions","organizations_url":"https://api.github.com/users/df-um/orgs","repos_url":"https://api.github.com/users/df-um/repos","events_url":"https://api.github.com/users/df-um/events{/privacy}","received_events_url":"https://api.github.com/users/df-um/received_events","type":"User","site_admin":false},"html_url":"https://github.com/df-um/machine_learning_handbook","description":"A student-sourced Machine Learning handbook","fork":true,"url":"https://api.github.com/repos/df-um/machine_learning_handbook","forks_url":"https://api.github.com/repos/df-um/machine_learning_handbook/forks","keys_url":"https://api.github.com/repos/df-um/machine_learning_handbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/df-um/machine_learning_handbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/df-um/machine_learning_handbook/teams","hooks_url":"https://api.github.com/repos/df-um/machine_learning_handbook/hooks","issue_events_url":"https://api.github.com/repos/df-um/machine_learning_handbook/issues/events{/number}","events_url":"https://api.github.com/repos/df-um/machine_learning_handbook/events","assignees_url":"https://api.github.com/repos/df-um/machine_learning_handbook/assignees{/user}","branches_url":"https://api.github.com/repos/df-um/machine_learning_handbook/branches{/branch}","tags_url":"https://api.github.com/repos/df-um/machine_learning_handbook/tags","blobs_url":"https://api.github.com/repos/df-um/machine_learning_handbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/df-um/machine_learning_handbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/df-um/machine_learning_handbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/df-um/machine_learning_handbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/df-um/machine_learning_handbook/statuses/{sha}","languages_url":"https://api.github.com/repos/df-um/machine_learning_handbook/languages","stargazers_url":"https://api.github.com/repos/df-um/machine_learning_handbook/stargazers","contributors_url":"https://api.github.com/repos/df-um/machine_learning_handbook/contributors","subscribers_url":"https://api.github.com/repos/df-um/machine_learning_handbook/subscribers","subscription_url":"https://api.github.com/repos/df-um/machine_learning_handbook/subscription","commits_url":"https://api.github.com/repos/df-um/machine_learning_handbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/df-um/machine_learning_handbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/df-um/machine_learning_handbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/df-um/machine_learning_handbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/df-um/machine_learning_handbook/contents/{+path}","compare_url":"https://api.github.com/repos/df-um/machine_learning_handbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/df-um/machine_learning_handbook/merges","archive_url":"https://api.github.com/repos/df-um/machine_learning_handbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/df-um/machine_learning_handbook/downloads","issues_url":"https://api.github.com/repos/df-um/machine_learning_handbook/issues{/number}","pulls_url":"https://api.github.com/repos/df-um/machine_learning_handbook/pulls{/number}","milestones_url":"https://api.github.com/repos/df-um/machine_learning_handbook/milestones{/number}","notifications_url":"https://api.github.com/repos/df-um/machine_learning_handbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/df-um/machine_learning_handbook/labels{/name}","releases_url":"https://api.github.com/repos/df-um/machine_learning_handbook/releases{/id}","deployments_url":"https://api.github.com/repos/df-um/machine_learning_handbook/deployments","created_at":"2018-12-17T00:26:16Z","updated_at":"2018-12-17T00:26:18Z","pushed_at":"2018-12-18T20:14:44Z","git_url":"git://github.com/df-um/machine_learning_handbook.git","ssh_url":"[email protected]:df-um/machine_learning_handbook.git","clone_url":"https://github.com/df-um/machine_learning_handbook.git","svn_url":"https://github.com/df-um/machine_learning_handbook","homepage":null,"size":4625,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jp-um:master","ref":"master","sha":"3dbfd547d2cd8ccb491588db5e1c43713a5c1169","user":{"login":"jp-um","id":22983794,"node_id":"MDQ6VXNlcjIyOTgzNzk0","avatar_url":"https://avatars1.githubusercontent.com/u/22983794?v=4","gravatar_id":"","url":"https://api.github.com/users/jp-um","html_url":"https://github.com/jp-um","followers_url":"https://api.github.com/users/jp-um/followers","following_url":"https://api.github.com/users/jp-um/following{/other_user}","gists_url":"https://api.github.com/users/jp-um/gists{/gist_id}","starred_url":"https://api.github.com/users/jp-um/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jp-um/subscriptions","organizations_url":"https://api.github.com/users/jp-um/orgs","repos_url":"https://api.github.com/users/jp-um/repos","events_url":"https://api.github.com/users/jp-um/events{/privacy}","received_events_url":"https://api.github.com/users/jp-um/received_events","type":"User","site_admin":false},"repo":{"id":159342176,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzNDIxNzY=","name":"machine_learning_handbook","full_name":"jp-um/machine_learning_handbook","private":false,"owner":{"login":"jp-um","id":22983794,"node_id":"MDQ6VXNlcjIyOTgzNzk0","avatar_url":"https://avatars1.githubusercontent.com/u/22983794?v=4","gravatar_id":"","url":"https://api.github.com/users/jp-um","html_url":"https://github.com/jp-um","followers_url":"https://api.github.com/users/jp-um/followers","following_url":"https://api.github.com/users/jp-um/following{/other_user}","gists_url":"https://api.github.com/users/jp-um/gists{/gist_id}","starred_url":"https://api.github.com/users/jp-um/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jp-um/subscriptions","organizations_url":"https://api.github.com/users/jp-um/orgs","repos_url":"https://api.github.com/users/jp-um/repos","events_url":"https://api.github.com/users/jp-um/events{/privacy}","received_events_url":"https://api.github.com/users/jp-um/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jp-um/machine_learning_handbook","description":"A student-sourced Machine Learning handbook","fork":false,"url":"https://api.github.com/repos/jp-um/machine_learning_handbook","forks_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/forks","keys_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/teams","hooks_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/hooks","issue_events_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/issues/events{/number}","events_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/events","assignees_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/assignees{/user}","branches_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/branches{/branch}","tags_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/tags","blobs_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/statuses/{sha}","languages_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/languages","stargazers_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/stargazers","contributors_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/contributors","subscribers_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/subscribers","subscription_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/subscription","commits_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/contents/{+path}","compare_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/merges","archive_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/downloads","issues_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/issues{/number}","pulls_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls{/number}","milestones_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/milestones{/number}","notifications_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/labels{/name}","releases_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/releases{/id}","deployments_url":"https://api.github.com/repos/jp-um/machine_learning_handbook/deployments","created_at":"2018-11-27T13:45:47Z","updated_at":"2018-12-18T09:51:04Z","pushed_at":"2018-12-18T20:14:45Z","git_url":"git://github.com/jp-um/machine_learning_handbook.git","ssh_url":"[email protected]:jp-um/machine_learning_handbook.git","clone_url":"https://github.com/jp-um/machine_learning_handbook.git","svn_url":"https://github.com/jp-um/machine_learning_handbook","homepage":null,"size":4368,"stargazers_count":1,"watchers_count":1,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":7,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/6"},"html":{"href":"https://github.com/jp-um/machine_learning_handbook/pull/6"},"issue":{"href":"https://api.github.com/repos/jp-um/machine_learning_handbook/issues/6"},"comments":{"href":"https://api.github.com/repos/jp-um/machine_learning_handbook/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jp-um/machine_learning_handbook/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/jp-um/machine_learning_handbook/statuses/7cbd248e0b3b9e9f55ba3efad37059bc80ba81a7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 159342176,
"name": "jp-um/machine_learning_handbook",
"url": "https://api.github.com/repos/jp-um/machine_learning_handbook"
} | {
"id": 23550363,
"login": "laramdemajo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23550363?",
"url": "https://api.github.com/users/laramdemajo"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-12-18T20:56:20 | 8774788570 | {"actor":{"display_login":"laramdemajo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/comments/175371984","pull_request_review_id":104887817,"id":175371984,"diff_hunk":"@@ -13,7 +13,7 @@ class ReportTopicEvent\n public $reasons;\n public $links;\n \n- public function __construct(Topic $topic, string $reasons, string $links)\n+ public function __construct(Topic $topic, string $reasons, string $links = null)","path":"app/Events/ReportTopicEvent.php","position":5,"original_position":5,"commit_id":"dd958ca0db904efc03f6a9b1613932feb5486ffb","original_commit_id":"dd958ca0db904efc03f6a9b1613932feb5486ffb","user":{"login":"m1guelpf","id":23558090,"avatar_url":"https://avatars0.githubusercontent.com/u/23558090?v=4","gravatar_id":"","url":"https://api.github.com/users/m1guelpf","html_url":"https://github.com/m1guelpf","followers_url":"https://api.github.com/users/m1guelpf/followers","following_url":"https://api.github.com/users/m1guelpf/following{/other_user}","gists_url":"https://api.github.com/users/m1guelpf/gists{/gist_id}","starred_url":"https://api.github.com/users/m1guelpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m1guelpf/subscriptions","organizations_url":"https://api.github.com/users/m1guelpf/orgs","repos_url":"https://api.github.com/users/m1guelpf/repos","events_url":"https://api.github.com/users/m1guelpf/events{/privacy}","received_events_url":"https://api.github.com/users/m1guelpf/received_events","type":"User","site_admin":false},"body":"When would the link be nullable?","created_at":"2018-03-19T09:34:06Z","updated_at":"2018-03-19T09:34:07Z","html_url":"https://github.com/assertchris/borrow-my-topic/pull/58#discussion_r175371984","pull_request_url":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/58","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/comments/175371984"},"html":{"href":"https://github.com/assertchris/borrow-my-topic/pull/58#discussion_r175371984"},"pull_request":{"href":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/58","id":175754307,"html_url":"https://github.com/assertchris/borrow-my-topic/pull/58","diff_url":"https://github.com/assertchris/borrow-my-topic/pull/58.diff","patch_url":"https://github.com/assertchris/borrow-my-topic/pull/58.patch","issue_url":"https://api.github.com/repos/assertchris/borrow-my-topic/issues/58","number":58,"state":"open","locked":false,"title":"Improve report mail design","user":{"login":"assertchris","id":200609,"avatar_url":"https://avatars1.githubusercontent.com/u/200609?v=4","gravatar_id":"","url":"https://api.github.com/users/assertchris","html_url":"https://github.com/assertchris","followers_url":"https://api.github.com/users/assertchris/followers","following_url":"https://api.github.com/users/assertchris/following{/other_user}","gists_url":"https://api.github.com/users/assertchris/gists{/gist_id}","starred_url":"https://api.github.com/users/assertchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assertchris/subscriptions","organizations_url":"https://api.github.com/users/assertchris/orgs","repos_url":"https://api.github.com/users/assertchris/repos","events_url":"https://api.github.com/users/assertchris/events{/privacy}","received_events_url":"https://api.github.com/users/assertchris/received_events","type":"User","site_admin":false},"body":"**needs merged after https://github.com/assertchris/borrow-my-topic/pull/56**","created_at":"2018-03-18T14:36:25Z","updated_at":"2018-03-19T09:34:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3d496d5340d7ce9d3fa0310a39972eb39c72840","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/58/commits","review_comments_url":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/58/comments","review_comment_url":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/assertchris/borrow-my-topic/issues/58/comments","statuses_url":"https://api.github.com/repos/assertchris/borrow-my-topic/statuses/dd958ca0db904efc03f6a9b1613932feb5486ffb","head":{"label":"assertchris:feature/improve-report-mail-design","ref":"feature/improve-report-mail-design","sha":"dd958ca0db904efc03f6a9b1613932feb5486ffb","user":{"login":"assertchris","id":200609,"avatar_url":"https://avatars1.githubusercontent.com/u/200609?v=4","gravatar_id":"","url":"https://api.github.com/users/assertchris","html_url":"https://github.com/assertchris","followers_url":"https://api.github.com/users/assertchris/followers","following_url":"https://api.github.com/users/assertchris/following{/other_user}","gists_url":"https://api.github.com/users/assertchris/gists{/gist_id}","starred_url":"https://api.github.com/users/assertchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assertchris/subscriptions","organizations_url":"https://api.github.com/users/assertchris/orgs","repos_url":"https://api.github.com/users/assertchris/repos","events_url":"https://api.github.com/users/assertchris/events{/privacy}","received_events_url":"https://api.github.com/users/assertchris/received_events","type":"User","site_admin":false},"repo":{"id":124715930,"name":"borrow-my-topic","full_name":"assertchris/borrow-my-topic","owner":{"login":"assertchris","id":200609,"avatar_url":"https://avatars1.githubusercontent.com/u/200609?v=4","gravatar_id":"","url":"https://api.github.com/users/assertchris","html_url":"https://github.com/assertchris","followers_url":"https://api.github.com/users/assertchris/followers","following_url":"https://api.github.com/users/assertchris/following{/other_user}","gists_url":"https://api.github.com/users/assertchris/gists{/gist_id}","starred_url":"https://api.github.com/users/assertchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assertchris/subscriptions","organizations_url":"https://api.github.com/users/assertchris/orgs","repos_url":"https://api.github.com/users/assertchris/repos","events_url":"https://api.github.com/users/assertchris/events{/privacy}","received_events_url":"https://api.github.com/users/assertchris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/assertchris/borrow-my-topic","description":null,"fork":false,"url":"https://api.github.com/repos/assertchris/borrow-my-topic","forks_url":"https://api.github.com/repos/assertchris/borrow-my-topic/forks","keys_url":"https://api.github.com/repos/assertchris/borrow-my-topic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assertchris/borrow-my-topic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assertchris/borrow-my-topic/teams","hooks_url":"https://api.github.com/repos/assertchris/borrow-my-topic/hooks","issue_events_url":"https://api.github.com/repos/assertchris/borrow-my-topic/issues/events{/number}","events_url":"https://api.github.com/repos/assertchris/borrow-my-topic/events","assignees_url":"https://api.github.com/repos/assertchris/borrow-my-topic/assignees{/user}","branches_url":"https://api.github.com/repos/assertchris/borrow-my-topic/branches{/branch}","tags_url":"https://api.github.com/repos/assertchris/borrow-my-topic/tags","blobs_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/refs{/sha}","trees_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assertchris/borrow-my-topic/statuses/{sha}","languages_url":"https://api.github.com/repos/assertchris/borrow-my-topic/languages","stargazers_url":"https://api.github.com/repos/assertchris/borrow-my-topic/stargazers","contributors_url":"https://api.github.com/repos/assertchris/borrow-my-topic/contributors","subscribers_url":"https://api.github.com/repos/assertchris/borrow-my-topic/subscribers","subscription_url":"https://api.github.com/repos/assertchris/borrow-my-topic/subscription","commits_url":"https://api.github.com/repos/assertchris/borrow-my-topic/commits{/sha}","git_commits_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/commits{/sha}","comments_url":"https://api.github.com/repos/assertchris/borrow-my-topic/comments{/number}","issue_comment_url":"https://api.github.com/repos/assertchris/borrow-my-topic/issues/comments{/number}","contents_url":"https://api.github.com/repos/assertchris/borrow-my-topic/contents/{+path}","compare_url":"https://api.github.com/repos/assertchris/borrow-my-topic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assertchris/borrow-my-topic/merges","archive_url":"https://api.github.com/repos/assertchris/borrow-my-topic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assertchris/borrow-my-topic/downloads","issues_url":"https://api.github.com/repos/assertchris/borrow-my-topic/issues{/number}","pulls_url":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls{/number}","milestones_url":"https://api.github.com/repos/assertchris/borrow-my-topic/milestones{/number}","notifications_url":"https://api.github.com/repos/assertchris/borrow-my-topic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assertchris/borrow-my-topic/labels{/name}","releases_url":"https://api.github.com/repos/assertchris/borrow-my-topic/releases{/id}","deployments_url":"https://api.github.com/repos/assertchris/borrow-my-topic/deployments","created_at":"2018-03-11T02:18:22Z","updated_at":"2018-03-18T13:12:18Z","pushed_at":"2018-03-18T14:36:25Z","git_url":"git://github.com/assertchris/borrow-my-topic.git","ssh_url":"[email protected]:assertchris/borrow-my-topic.git","clone_url":"https://github.com/assertchris/borrow-my-topic.git","svn_url":"https://github.com/assertchris/borrow-my-topic","homepage":null,"size":401,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":22,"watchers":4,"default_branch":"master"}},"base":{"label":"assertchris:feature/rename-feedback-to-links","ref":"feature/rename-feedback-to-links","sha":"1719e4ca90f9119ccca09000fe9ce8cbaebb9839","user":{"login":"assertchris","id":200609,"avatar_url":"https://avatars1.githubusercontent.com/u/200609?v=4","gravatar_id":"","url":"https://api.github.com/users/assertchris","html_url":"https://github.com/assertchris","followers_url":"https://api.github.com/users/assertchris/followers","following_url":"https://api.github.com/users/assertchris/following{/other_user}","gists_url":"https://api.github.com/users/assertchris/gists{/gist_id}","starred_url":"https://api.github.com/users/assertchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assertchris/subscriptions","organizations_url":"https://api.github.com/users/assertchris/orgs","repos_url":"https://api.github.com/users/assertchris/repos","events_url":"https://api.github.com/users/assertchris/events{/privacy}","received_events_url":"https://api.github.com/users/assertchris/received_events","type":"User","site_admin":false},"repo":{"id":124715930,"name":"borrow-my-topic","full_name":"assertchris/borrow-my-topic","owner":{"login":"assertchris","id":200609,"avatar_url":"https://avatars1.githubusercontent.com/u/200609?v=4","gravatar_id":"","url":"https://api.github.com/users/assertchris","html_url":"https://github.com/assertchris","followers_url":"https://api.github.com/users/assertchris/followers","following_url":"https://api.github.com/users/assertchris/following{/other_user}","gists_url":"https://api.github.com/users/assertchris/gists{/gist_id}","starred_url":"https://api.github.com/users/assertchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assertchris/subscriptions","organizations_url":"https://api.github.com/users/assertchris/orgs","repos_url":"https://api.github.com/users/assertchris/repos","events_url":"https://api.github.com/users/assertchris/events{/privacy}","received_events_url":"https://api.github.com/users/assertchris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/assertchris/borrow-my-topic","description":null,"fork":false,"url":"https://api.github.com/repos/assertchris/borrow-my-topic","forks_url":"https://api.github.com/repos/assertchris/borrow-my-topic/forks","keys_url":"https://api.github.com/repos/assertchris/borrow-my-topic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assertchris/borrow-my-topic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assertchris/borrow-my-topic/teams","hooks_url":"https://api.github.com/repos/assertchris/borrow-my-topic/hooks","issue_events_url":"https://api.github.com/repos/assertchris/borrow-my-topic/issues/events{/number}","events_url":"https://api.github.com/repos/assertchris/borrow-my-topic/events","assignees_url":"https://api.github.com/repos/assertchris/borrow-my-topic/assignees{/user}","branches_url":"https://api.github.com/repos/assertchris/borrow-my-topic/branches{/branch}","tags_url":"https://api.github.com/repos/assertchris/borrow-my-topic/tags","blobs_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/refs{/sha}","trees_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assertchris/borrow-my-topic/statuses/{sha}","languages_url":"https://api.github.com/repos/assertchris/borrow-my-topic/languages","stargazers_url":"https://api.github.com/repos/assertchris/borrow-my-topic/stargazers","contributors_url":"https://api.github.com/repos/assertchris/borrow-my-topic/contributors","subscribers_url":"https://api.github.com/repos/assertchris/borrow-my-topic/subscribers","subscription_url":"https://api.github.com/repos/assertchris/borrow-my-topic/subscription","commits_url":"https://api.github.com/repos/assertchris/borrow-my-topic/commits{/sha}","git_commits_url":"https://api.github.com/repos/assertchris/borrow-my-topic/git/commits{/sha}","comments_url":"https://api.github.com/repos/assertchris/borrow-my-topic/comments{/number}","issue_comment_url":"https://api.github.com/repos/assertchris/borrow-my-topic/issues/comments{/number}","contents_url":"https://api.github.com/repos/assertchris/borrow-my-topic/contents/{+path}","compare_url":"https://api.github.com/repos/assertchris/borrow-my-topic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assertchris/borrow-my-topic/merges","archive_url":"https://api.github.com/repos/assertchris/borrow-my-topic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assertchris/borrow-my-topic/downloads","issues_url":"https://api.github.com/repos/assertchris/borrow-my-topic/issues{/number}","pulls_url":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls{/number}","milestones_url":"https://api.github.com/repos/assertchris/borrow-my-topic/milestones{/number}","notifications_url":"https://api.github.com/repos/assertchris/borrow-my-topic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assertchris/borrow-my-topic/labels{/name}","releases_url":"https://api.github.com/repos/assertchris/borrow-my-topic/releases{/id}","deployments_url":"https://api.github.com/repos/assertchris/borrow-my-topic/deployments","created_at":"2018-03-11T02:18:22Z","updated_at":"2018-03-18T13:12:18Z","pushed_at":"2018-03-18T14:36:25Z","git_url":"git://github.com/assertchris/borrow-my-topic.git","ssh_url":"[email protected]:assertchris/borrow-my-topic.git","clone_url":"https://github.com/assertchris/borrow-my-topic.git","svn_url":"https://github.com/assertchris/borrow-my-topic","homepage":null,"size":401,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":22,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/58"},"html":{"href":"https://github.com/assertchris/borrow-my-topic/pull/58"},"issue":{"href":"https://api.github.com/repos/assertchris/borrow-my-topic/issues/58"},"comments":{"href":"https://api.github.com/repos/assertchris/borrow-my-topic/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/assertchris/borrow-my-topic/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/assertchris/borrow-my-topic/statuses/dd958ca0db904efc03f6a9b1613932feb5486ffb"}},"author_association":"OWNER"}} | {
"id": 124715930,
"name": "assertchris/borrow-my-topic",
"url": "https://api.github.com/repos/assertchris/borrow-my-topic"
} | {
"id": 23558090,
"login": "m1guelpf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23558090?",
"url": "https://api.github.com/users/m1guelpf"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-03-19T09:34:06 | 7399162433 | {"actor":{"display_login":"m1guelpf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bernardoVale/springhello/pulls/comments/203446717","pull_request_review_id":138337707,"id":203446717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ0NjcxNw==","diff_hunk":"@@ -8,6 +8,7 @@\n \n @RequestMapping(\"/\")\n public String hello(){\n- return \"Hello World!\";\n+ String foo = \"bar\";","path":"src/main/java/com/github/bvale/helloSpring/controller/HomeController.java","position":5,"original_position":5,"commit_id":"6f3bee16972de0843df0778bc266b5764f18c307","original_commit_id":"6f3bee16972de0843df0778bc266b5764f18c307","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":" Code Smell: Remove this unused \"foo\" local variable. ([squid:S1481](https://sonarcloud.io/organizations/bernardovale-github/rules#rule_key=squid%3AS1481))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=com.github.bvale%3AhelloSpring&pullRequest=1&issues=AWSuJ7bs6dA5b-W2m-se&open=AWSuJ7bs6dA5b-W2m-se)\n\n[ISSUE_KEY]: AWSuJ7bs6dA5b-W2m-se","created_at":"2018-07-18T16:31:09Z","updated_at":"2018-07-18T16:31:09Z","html_url":"https://github.com/bernardoVale/springhello/pull/1#discussion_r203446717","pull_request_url":"https://api.github.com/repos/bernardoVale/springhello/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bernardoVale/springhello/pulls/comments/203446717"},"html":{"href":"https://github.com/bernardoVale/springhello/pull/1#discussion_r203446717"},"pull_request":{"href":"https://api.github.com/repos/bernardoVale/springhello/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/bernardoVale/springhello/pulls/1","id":202305570,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzA1NTcw","html_url":"https://github.com/bernardoVale/springhello/pull/1","diff_url":"https://github.com/bernardoVale/springhello/pull/1.diff","patch_url":"https://github.com/bernardoVale/springhello/pull/1.patch","issue_url":"https://api.github.com/repos/bernardoVale/springhello/issues/1","number":1,"state":"open","locked":false,"title":"Newbranch","user":{"login":"bernardoVale","id":1888123,"node_id":"MDQ6VXNlcjE4ODgxMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1888123?v=4","gravatar_id":"","url":"https://api.github.com/users/bernardoVale","html_url":"https://github.com/bernardoVale","followers_url":"https://api.github.com/users/bernardoVale/followers","following_url":"https://api.github.com/users/bernardoVale/following{/other_user}","gists_url":"https://api.github.com/users/bernardoVale/gists{/gist_id}","starred_url":"https://api.github.com/users/bernardoVale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernardoVale/subscriptions","organizations_url":"https://api.github.com/users/bernardoVale/orgs","repos_url":"https://api.github.com/users/bernardoVale/repos","events_url":"https://api.github.com/users/bernardoVale/events{/privacy}","received_events_url":"https://api.github.com/users/bernardoVale/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-18T16:09:16Z","updated_at":"2018-07-18T16:31:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03ec7927f4cc451ce80ba6d891185ccc486e91f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bernardoVale/springhello/pulls/1/commits","review_comments_url":"https://api.github.com/repos/bernardoVale/springhello/pulls/1/comments","review_comment_url":"https://api.github.com/repos/bernardoVale/springhello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bernardoVale/springhello/issues/1/comments","statuses_url":"https://api.github.com/repos/bernardoVale/springhello/statuses/6f3bee16972de0843df0778bc266b5764f18c307","head":{"label":"bernardoVale:newbranch","ref":"newbranch","sha":"6f3bee16972de0843df0778bc266b5764f18c307","user":{"login":"bernardoVale","id":1888123,"node_id":"MDQ6VXNlcjE4ODgxMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1888123?v=4","gravatar_id":"","url":"https://api.github.com/users/bernardoVale","html_url":"https://github.com/bernardoVale","followers_url":"https://api.github.com/users/bernardoVale/followers","following_url":"https://api.github.com/users/bernardoVale/following{/other_user}","gists_url":"https://api.github.com/users/bernardoVale/gists{/gist_id}","starred_url":"https://api.github.com/users/bernardoVale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernardoVale/subscriptions","organizations_url":"https://api.github.com/users/bernardoVale/orgs","repos_url":"https://api.github.com/users/bernardoVale/repos","events_url":"https://api.github.com/users/bernardoVale/events{/privacy}","received_events_url":"https://api.github.com/users/bernardoVale/received_events","type":"User","site_admin":false},"repo":{"id":113701113,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM3MDExMTM=","name":"springhello","full_name":"bernardoVale/springhello","owner":{"login":"bernardoVale","id":1888123,"node_id":"MDQ6VXNlcjE4ODgxMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1888123?v=4","gravatar_id":"","url":"https://api.github.com/users/bernardoVale","html_url":"https://github.com/bernardoVale","followers_url":"https://api.github.com/users/bernardoVale/followers","following_url":"https://api.github.com/users/bernardoVale/following{/other_user}","gists_url":"https://api.github.com/users/bernardoVale/gists{/gist_id}","starred_url":"https://api.github.com/users/bernardoVale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernardoVale/subscriptions","organizations_url":"https://api.github.com/users/bernardoVale/orgs","repos_url":"https://api.github.com/users/bernardoVale/repos","events_url":"https://api.github.com/users/bernardoVale/events{/privacy}","received_events_url":"https://api.github.com/users/bernardoVale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bernardoVale/springhello","description":"Learning spring boot as an exercise to apply DevOps magic on java projects","fork":false,"url":"https://api.github.com/repos/bernardoVale/springhello","forks_url":"https://api.github.com/repos/bernardoVale/springhello/forks","keys_url":"https://api.github.com/repos/bernardoVale/springhello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bernardoVale/springhello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bernardoVale/springhello/teams","hooks_url":"https://api.github.com/repos/bernardoVale/springhello/hooks","issue_events_url":"https://api.github.com/repos/bernardoVale/springhello/issues/events{/number}","events_url":"https://api.github.com/repos/bernardoVale/springhello/events","assignees_url":"https://api.github.com/repos/bernardoVale/springhello/assignees{/user}","branches_url":"https://api.github.com/repos/bernardoVale/springhello/branches{/branch}","tags_url":"https://api.github.com/repos/bernardoVale/springhello/tags","blobs_url":"https://api.github.com/repos/bernardoVale/springhello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bernardoVale/springhello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bernardoVale/springhello/git/refs{/sha}","trees_url":"https://api.github.com/repos/bernardoVale/springhello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bernardoVale/springhello/statuses/{sha}","languages_url":"https://api.github.com/repos/bernardoVale/springhello/languages","stargazers_url":"https://api.github.com/repos/bernardoVale/springhello/stargazers","contributors_url":"https://api.github.com/repos/bernardoVale/springhello/contributors","subscribers_url":"https://api.github.com/repos/bernardoVale/springhello/subscribers","subscription_url":"https://api.github.com/repos/bernardoVale/springhello/subscription","commits_url":"https://api.github.com/repos/bernardoVale/springhello/commits{/sha}","git_commits_url":"https://api.github.com/repos/bernardoVale/springhello/git/commits{/sha}","comments_url":"https://api.github.com/repos/bernardoVale/springhello/comments{/number}","issue_comment_url":"https://api.github.com/repos/bernardoVale/springhello/issues/comments{/number}","contents_url":"https://api.github.com/repos/bernardoVale/springhello/contents/{+path}","compare_url":"https://api.github.com/repos/bernardoVale/springhello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bernardoVale/springhello/merges","archive_url":"https://api.github.com/repos/bernardoVale/springhello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bernardoVale/springhello/downloads","issues_url":"https://api.github.com/repos/bernardoVale/springhello/issues{/number}","pulls_url":"https://api.github.com/repos/bernardoVale/springhello/pulls{/number}","milestones_url":"https://api.github.com/repos/bernardoVale/springhello/milestones{/number}","notifications_url":"https://api.github.com/repos/bernardoVale/springhello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bernardoVale/springhello/labels{/name}","releases_url":"https://api.github.com/repos/bernardoVale/springhello/releases{/id}","deployments_url":"https://api.github.com/repos/bernardoVale/springhello/deployments","created_at":"2017-12-09T21:04:39Z","updated_at":"2018-06-26T18:43:15Z","pushed_at":"2018-07-18T16:09:17Z","git_url":"git://github.com/bernardoVale/springhello.git","ssh_url":"[email protected]:bernardoVale/springhello.git","clone_url":"https://github.com/bernardoVale/springhello.git","svn_url":"https://github.com/bernardoVale/springhello","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bernardoVale:master","ref":"master","sha":"5d125a9a961ff89db9962f7c866648bb334cbd82","user":{"login":"bernardoVale","id":1888123,"node_id":"MDQ6VXNlcjE4ODgxMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1888123?v=4","gravatar_id":"","url":"https://api.github.com/users/bernardoVale","html_url":"https://github.com/bernardoVale","followers_url":"https://api.github.com/users/bernardoVale/followers","following_url":"https://api.github.com/users/bernardoVale/following{/other_user}","gists_url":"https://api.github.com/users/bernardoVale/gists{/gist_id}","starred_url":"https://api.github.com/users/bernardoVale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernardoVale/subscriptions","organizations_url":"https://api.github.com/users/bernardoVale/orgs","repos_url":"https://api.github.com/users/bernardoVale/repos","events_url":"https://api.github.com/users/bernardoVale/events{/privacy}","received_events_url":"https://api.github.com/users/bernardoVale/received_events","type":"User","site_admin":false},"repo":{"id":113701113,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM3MDExMTM=","name":"springhello","full_name":"bernardoVale/springhello","owner":{"login":"bernardoVale","id":1888123,"node_id":"MDQ6VXNlcjE4ODgxMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1888123?v=4","gravatar_id":"","url":"https://api.github.com/users/bernardoVale","html_url":"https://github.com/bernardoVale","followers_url":"https://api.github.com/users/bernardoVale/followers","following_url":"https://api.github.com/users/bernardoVale/following{/other_user}","gists_url":"https://api.github.com/users/bernardoVale/gists{/gist_id}","starred_url":"https://api.github.com/users/bernardoVale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernardoVale/subscriptions","organizations_url":"https://api.github.com/users/bernardoVale/orgs","repos_url":"https://api.github.com/users/bernardoVale/repos","events_url":"https://api.github.com/users/bernardoVale/events{/privacy}","received_events_url":"https://api.github.com/users/bernardoVale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bernardoVale/springhello","description":"Learning spring boot as an exercise to apply DevOps magic on java projects","fork":false,"url":"https://api.github.com/repos/bernardoVale/springhello","forks_url":"https://api.github.com/repos/bernardoVale/springhello/forks","keys_url":"https://api.github.com/repos/bernardoVale/springhello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bernardoVale/springhello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bernardoVale/springhello/teams","hooks_url":"https://api.github.com/repos/bernardoVale/springhello/hooks","issue_events_url":"https://api.github.com/repos/bernardoVale/springhello/issues/events{/number}","events_url":"https://api.github.com/repos/bernardoVale/springhello/events","assignees_url":"https://api.github.com/repos/bernardoVale/springhello/assignees{/user}","branches_url":"https://api.github.com/repos/bernardoVale/springhello/branches{/branch}","tags_url":"https://api.github.com/repos/bernardoVale/springhello/tags","blobs_url":"https://api.github.com/repos/bernardoVale/springhello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bernardoVale/springhello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bernardoVale/springhello/git/refs{/sha}","trees_url":"https://api.github.com/repos/bernardoVale/springhello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bernardoVale/springhello/statuses/{sha}","languages_url":"https://api.github.com/repos/bernardoVale/springhello/languages","stargazers_url":"https://api.github.com/repos/bernardoVale/springhello/stargazers","contributors_url":"https://api.github.com/repos/bernardoVale/springhello/contributors","subscribers_url":"https://api.github.com/repos/bernardoVale/springhello/subscribers","subscription_url":"https://api.github.com/repos/bernardoVale/springhello/subscription","commits_url":"https://api.github.com/repos/bernardoVale/springhello/commits{/sha}","git_commits_url":"https://api.github.com/repos/bernardoVale/springhello/git/commits{/sha}","comments_url":"https://api.github.com/repos/bernardoVale/springhello/comments{/number}","issue_comment_url":"https://api.github.com/repos/bernardoVale/springhello/issues/comments{/number}","contents_url":"https://api.github.com/repos/bernardoVale/springhello/contents/{+path}","compare_url":"https://api.github.com/repos/bernardoVale/springhello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bernardoVale/springhello/merges","archive_url":"https://api.github.com/repos/bernardoVale/springhello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bernardoVale/springhello/downloads","issues_url":"https://api.github.com/repos/bernardoVale/springhello/issues{/number}","pulls_url":"https://api.github.com/repos/bernardoVale/springhello/pulls{/number}","milestones_url":"https://api.github.com/repos/bernardoVale/springhello/milestones{/number}","notifications_url":"https://api.github.com/repos/bernardoVale/springhello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bernardoVale/springhello/labels{/name}","releases_url":"https://api.github.com/repos/bernardoVale/springhello/releases{/id}","deployments_url":"https://api.github.com/repos/bernardoVale/springhello/deployments","created_at":"2017-12-09T21:04:39Z","updated_at":"2018-06-26T18:43:15Z","pushed_at":"2018-07-18T16:09:17Z","git_url":"git://github.com/bernardoVale/springhello.git","ssh_url":"[email protected]:bernardoVale/springhello.git","clone_url":"https://github.com/bernardoVale/springhello.git","svn_url":"https://github.com/bernardoVale/springhello","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bernardoVale/springhello/pulls/1"},"html":{"href":"https://github.com/bernardoVale/springhello/pull/1"},"issue":{"href":"https://api.github.com/repos/bernardoVale/springhello/issues/1"},"comments":{"href":"https://api.github.com/repos/bernardoVale/springhello/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/bernardoVale/springhello/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/bernardoVale/springhello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bernardoVale/springhello/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/bernardoVale/springhello/statuses/6f3bee16972de0843df0778bc266b5764f18c307"}},"author_association":"OWNER"}} | {
"id": 113701113,
"name": "bernardoVale/springhello",
"url": "https://api.github.com/repos/bernardoVale/springhello"
} | {
"id": 39514782,
"login": "sonarcloud[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39514782?",
"url": "https://api.github.com/users/sonarcloud[bot]"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-07-18T16:31:09 | 7984106310 | {"actor":{"display_login":"sonarcloud"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Hotckiss/Java-2/pulls/comments/186269521","pull_request_review_id":117822230,"id":186269521,"diff_hunk":"@@ -0,0 +1,153 @@\n+package ru.spbau.kirilenko.hw3TicTac.controllers;\n+\n+import javafx.fxml.FXML;\n+import javafx.scene.canvas.Canvas;\n+import javafx.scene.input.MouseEvent;\n+import javafx.scene.text.Text;\n+import ru.spbau.kirilenko.hw3TicTac.CurrentGameType;\n+import ru.spbau.kirilenko.hw3TicTac.FieldPainter;\n+import ru.spbau.kirilenko.hw3TicTac.ScenesLoader;\n+import ru.spbau.kirilenko.hw3TicTac.logic.*;\n+import ru.spbau.kirilenko.hw3TicTac.statistics.Statistics;\n+\n+import java.io.IOException;\n+\n+import static ru.spbau.kirilenko.hw3TicTac.logic.GameStatus.*;\n+\n+/**\n+ * Controller of game field\n+ */\n+public class GameController {\n+ private AbstractGame game;\n+\n+ @FXML public Canvas field;\n+ @FXML public Text status;\n+ @FXML public Text result;\n+\n+ /**\n+ * Create AI that specified by game settings\n+ */\n+ public GameController() {\n+ if (CurrentGameType.getCurrentType() == 0) {\n+ game = new EasyGame();\n+ } else {\n+ game = new HardGame();\n+ }\n+ }\n+\n+ /**\n+ * Init game field to play\n+ */\n+ @FXML public void initialize() {\n+ FieldPainter.init(field, status, result);\n+ FieldPainter.initEmptyField();\n+ FieldPainter.setCurrentTurn(\"X move\");\n+ FieldPainter.setResult(\"\");\n+ if (CurrentGameType.getCurrentType() == 0) {","path":"TicTac/src/main/java/ru/spbau/kirilenko/hw3TicTac/controllers/GameController.java","position":46,"original_position":46,"commit_id":"30d7a4f37aecd479f560cc33a7a9381ce32686b7","original_commit_id":"30d7a4f37aecd479f560cc33a7a9381ce32686b7","user":{"login":"Hotckiss","id":22048102,"avatar_url":"https://avatars3.githubusercontent.com/u/22048102?v=4","gravatar_id":"","url":"https://api.github.com/users/Hotckiss","html_url":"https://github.com/Hotckiss","followers_url":"https://api.github.com/users/Hotckiss/followers","following_url":"https://api.github.com/users/Hotckiss/following{/other_user}","gists_url":"https://api.github.com/users/Hotckiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Hotckiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hotckiss/subscriptions","organizations_url":"https://api.github.com/users/Hotckiss/orgs","repos_url":"https://api.github.com/users/Hotckiss/repos","events_url":"https://api.github.com/users/Hotckiss/events{/privacy}","received_events_url":"https://api.github.com/users/Hotckiss/received_events","type":"User","site_admin":false},"body":"На самом деле тут конструктор вообще не нужен(где дублируется), автоматически вызывается initialize()","created_at":"2018-05-05T18:53:29Z","updated_at":"2018-05-05T18:53:29Z","html_url":"https://github.com/Hotckiss/Java-2/pull/4#discussion_r186269521","pull_request_url":"https://api.github.com/repos/Hotckiss/Java-2/pulls/4","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Hotckiss/Java-2/pulls/comments/186269521"},"html":{"href":"https://github.com/Hotckiss/Java-2/pull/4#discussion_r186269521"},"pull_request":{"href":"https://api.github.com/repos/Hotckiss/Java-2/pulls/4"}},"in_reply_to_id":184944501},"pull_request":{"url":"https://api.github.com/repos/Hotckiss/Java-2/pulls/4","id":176918887,"html_url":"https://github.com/Hotckiss/Java-2/pull/4","diff_url":"https://github.com/Hotckiss/Java-2/pull/4.diff","patch_url":"https://github.com/Hotckiss/Java-2/pull/4.patch","issue_url":"https://api.github.com/repos/Hotckiss/Java-2/issues/4","number":4,"state":"open","locked":false,"title":"Tic tac","user":{"login":"Hotckiss","id":22048102,"avatar_url":"https://avatars3.githubusercontent.com/u/22048102?v=4","gravatar_id":"","url":"https://api.github.com/users/Hotckiss","html_url":"https://github.com/Hotckiss","followers_url":"https://api.github.com/users/Hotckiss/followers","following_url":"https://api.github.com/users/Hotckiss/following{/other_user}","gists_url":"https://api.github.com/users/Hotckiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Hotckiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hotckiss/subscriptions","organizations_url":"https://api.github.com/users/Hotckiss/orgs","repos_url":"https://api.github.com/users/Hotckiss/repos","events_url":"https://api.github.com/users/Hotckiss/events{/privacy}","received_events_url":"https://api.github.com/users/Hotckiss/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-22T21:47:57Z","updated_at":"2018-05-05T18:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72baef82475d8a73aae9436b1aaf93c64c3e7592","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Hotckiss/Java-2/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Hotckiss/Java-2/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Hotckiss/Java-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Hotckiss/Java-2/issues/4/comments","statuses_url":"https://api.github.com/repos/Hotckiss/Java-2/statuses/30d7a4f37aecd479f560cc33a7a9381ce32686b7","head":{"label":"Hotckiss:TicTac","ref":"TicTac","sha":"30d7a4f37aecd479f560cc33a7a9381ce32686b7","user":{"login":"Hotckiss","id":22048102,"avatar_url":"https://avatars3.githubusercontent.com/u/22048102?v=4","gravatar_id":"","url":"https://api.github.com/users/Hotckiss","html_url":"https://github.com/Hotckiss","followers_url":"https://api.github.com/users/Hotckiss/followers","following_url":"https://api.github.com/users/Hotckiss/following{/other_user}","gists_url":"https://api.github.com/users/Hotckiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Hotckiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hotckiss/subscriptions","organizations_url":"https://api.github.com/users/Hotckiss/orgs","repos_url":"https://api.github.com/users/Hotckiss/repos","events_url":"https://api.github.com/users/Hotckiss/events{/privacy}","received_events_url":"https://api.github.com/users/Hotckiss/received_events","type":"User","site_admin":false},"repo":{"id":121760836,"name":"Java-2","full_name":"Hotckiss/Java-2","owner":{"login":"Hotckiss","id":22048102,"avatar_url":"https://avatars3.githubusercontent.com/u/22048102?v=4","gravatar_id":"","url":"https://api.github.com/users/Hotckiss","html_url":"https://github.com/Hotckiss","followers_url":"https://api.github.com/users/Hotckiss/followers","following_url":"https://api.github.com/users/Hotckiss/following{/other_user}","gists_url":"https://api.github.com/users/Hotckiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Hotckiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hotckiss/subscriptions","organizations_url":"https://api.github.com/users/Hotckiss/orgs","repos_url":"https://api.github.com/users/Hotckiss/repos","events_url":"https://api.github.com/users/Hotckiss/events{/privacy}","received_events_url":"https://api.github.com/users/Hotckiss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hotckiss/Java-2","description":"Java hw","fork":false,"url":"https://api.github.com/repos/Hotckiss/Java-2","forks_url":"https://api.github.com/repos/Hotckiss/Java-2/forks","keys_url":"https://api.github.com/repos/Hotckiss/Java-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hotckiss/Java-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hotckiss/Java-2/teams","hooks_url":"https://api.github.com/repos/Hotckiss/Java-2/hooks","issue_events_url":"https://api.github.com/repos/Hotckiss/Java-2/issues/events{/number}","events_url":"https://api.github.com/repos/Hotckiss/Java-2/events","assignees_url":"https://api.github.com/repos/Hotckiss/Java-2/assignees{/user}","branches_url":"https://api.github.com/repos/Hotckiss/Java-2/branches{/branch}","tags_url":"https://api.github.com/repos/Hotckiss/Java-2/tags","blobs_url":"https://api.github.com/repos/Hotckiss/Java-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hotckiss/Java-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hotckiss/Java-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hotckiss/Java-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hotckiss/Java-2/statuses/{sha}","languages_url":"https://api.github.com/repos/Hotckiss/Java-2/languages","stargazers_url":"https://api.github.com/repos/Hotckiss/Java-2/stargazers","contributors_url":"https://api.github.com/repos/Hotckiss/Java-2/contributors","subscribers_url":"https://api.github.com/repos/Hotckiss/Java-2/subscribers","subscription_url":"https://api.github.com/repos/Hotckiss/Java-2/subscription","commits_url":"https://api.github.com/repos/Hotckiss/Java-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hotckiss/Java-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hotckiss/Java-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hotckiss/Java-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hotckiss/Java-2/contents/{+path}","compare_url":"https://api.github.com/repos/Hotckiss/Java-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hotckiss/Java-2/merges","archive_url":"https://api.github.com/repos/Hotckiss/Java-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hotckiss/Java-2/downloads","issues_url":"https://api.github.com/repos/Hotckiss/Java-2/issues{/number}","pulls_url":"https://api.github.com/repos/Hotckiss/Java-2/pulls{/number}","milestones_url":"https://api.github.com/repos/Hotckiss/Java-2/milestones{/number}","notifications_url":"https://api.github.com/repos/Hotckiss/Java-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hotckiss/Java-2/labels{/name}","releases_url":"https://api.github.com/repos/Hotckiss/Java-2/releases{/id}","deployments_url":"https://api.github.com/repos/Hotckiss/Java-2/deployments","created_at":"2018-02-16T14:37:29Z","updated_at":"2018-02-23T19:24:43Z","pushed_at":"2018-05-04T15:19:07Z","git_url":"git://github.com/Hotckiss/Java-2.git","ssh_url":"[email protected]:Hotckiss/Java-2.git","clone_url":"https://github.com/Hotckiss/Java-2.git","svn_url":"https://github.com/Hotckiss/Java-2","homepage":null,"size":221,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"Hotckiss:master","ref":"master","sha":"96ea7bd33a8abaf3d76682ee93b75959e4ed9f85","user":{"login":"Hotckiss","id":22048102,"avatar_url":"https://avatars3.githubusercontent.com/u/22048102?v=4","gravatar_id":"","url":"https://api.github.com/users/Hotckiss","html_url":"https://github.com/Hotckiss","followers_url":"https://api.github.com/users/Hotckiss/followers","following_url":"https://api.github.com/users/Hotckiss/following{/other_user}","gists_url":"https://api.github.com/users/Hotckiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Hotckiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hotckiss/subscriptions","organizations_url":"https://api.github.com/users/Hotckiss/orgs","repos_url":"https://api.github.com/users/Hotckiss/repos","events_url":"https://api.github.com/users/Hotckiss/events{/privacy}","received_events_url":"https://api.github.com/users/Hotckiss/received_events","type":"User","site_admin":false},"repo":{"id":121760836,"name":"Java-2","full_name":"Hotckiss/Java-2","owner":{"login":"Hotckiss","id":22048102,"avatar_url":"https://avatars3.githubusercontent.com/u/22048102?v=4","gravatar_id":"","url":"https://api.github.com/users/Hotckiss","html_url":"https://github.com/Hotckiss","followers_url":"https://api.github.com/users/Hotckiss/followers","following_url":"https://api.github.com/users/Hotckiss/following{/other_user}","gists_url":"https://api.github.com/users/Hotckiss/gists{/gist_id}","starred_url":"https://api.github.com/users/Hotckiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hotckiss/subscriptions","organizations_url":"https://api.github.com/users/Hotckiss/orgs","repos_url":"https://api.github.com/users/Hotckiss/repos","events_url":"https://api.github.com/users/Hotckiss/events{/privacy}","received_events_url":"https://api.github.com/users/Hotckiss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hotckiss/Java-2","description":"Java hw","fork":false,"url":"https://api.github.com/repos/Hotckiss/Java-2","forks_url":"https://api.github.com/repos/Hotckiss/Java-2/forks","keys_url":"https://api.github.com/repos/Hotckiss/Java-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hotckiss/Java-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hotckiss/Java-2/teams","hooks_url":"https://api.github.com/repos/Hotckiss/Java-2/hooks","issue_events_url":"https://api.github.com/repos/Hotckiss/Java-2/issues/events{/number}","events_url":"https://api.github.com/repos/Hotckiss/Java-2/events","assignees_url":"https://api.github.com/repos/Hotckiss/Java-2/assignees{/user}","branches_url":"https://api.github.com/repos/Hotckiss/Java-2/branches{/branch}","tags_url":"https://api.github.com/repos/Hotckiss/Java-2/tags","blobs_url":"https://api.github.com/repos/Hotckiss/Java-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hotckiss/Java-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hotckiss/Java-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hotckiss/Java-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hotckiss/Java-2/statuses/{sha}","languages_url":"https://api.github.com/repos/Hotckiss/Java-2/languages","stargazers_url":"https://api.github.com/repos/Hotckiss/Java-2/stargazers","contributors_url":"https://api.github.com/repos/Hotckiss/Java-2/contributors","subscribers_url":"https://api.github.com/repos/Hotckiss/Java-2/subscribers","subscription_url":"https://api.github.com/repos/Hotckiss/Java-2/subscription","commits_url":"https://api.github.com/repos/Hotckiss/Java-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hotckiss/Java-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hotckiss/Java-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hotckiss/Java-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hotckiss/Java-2/contents/{+path}","compare_url":"https://api.github.com/repos/Hotckiss/Java-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hotckiss/Java-2/merges","archive_url":"https://api.github.com/repos/Hotckiss/Java-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hotckiss/Java-2/downloads","issues_url":"https://api.github.com/repos/Hotckiss/Java-2/issues{/number}","pulls_url":"https://api.github.com/repos/Hotckiss/Java-2/pulls{/number}","milestones_url":"https://api.github.com/repos/Hotckiss/Java-2/milestones{/number}","notifications_url":"https://api.github.com/repos/Hotckiss/Java-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hotckiss/Java-2/labels{/name}","releases_url":"https://api.github.com/repos/Hotckiss/Java-2/releases{/id}","deployments_url":"https://api.github.com/repos/Hotckiss/Java-2/deployments","created_at":"2018-02-16T14:37:29Z","updated_at":"2018-02-23T19:24:43Z","pushed_at":"2018-05-04T15:19:07Z","git_url":"git://github.com/Hotckiss/Java-2.git","ssh_url":"[email protected]:Hotckiss/Java-2.git","clone_url":"https://github.com/Hotckiss/Java-2.git","svn_url":"https://github.com/Hotckiss/Java-2","homepage":null,"size":221,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Hotckiss/Java-2/pulls/4"},"html":{"href":"https://github.com/Hotckiss/Java-2/pull/4"},"issue":{"href":"https://api.github.com/repos/Hotckiss/Java-2/issues/4"},"comments":{"href":"https://api.github.com/repos/Hotckiss/Java-2/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Hotckiss/Java-2/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Hotckiss/Java-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Hotckiss/Java-2/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Hotckiss/Java-2/statuses/30d7a4f37aecd479f560cc33a7a9381ce32686b7"}},"author_association":"OWNER"}} | {
"id": 121760836,
"name": "Hotckiss/Java-2",
"url": "https://api.github.com/repos/Hotckiss/Java-2"
} | {
"id": 22048102,
"login": "Hotckiss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22048102?",
"url": "https://api.github.com/users/Hotckiss"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-05-05T18:53:29 | 7632761038 | {"actor":{"display_login":"Hotckiss"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/comments/171921316","pull_request_review_id":100856496,"id":171921316,"diff_hunk":"@@ -0,0 +1,156 @@\n+# Installing Moonfire NVR using provided scripts\n+\n+There are no binary packages of Moonfire NVR available yet, so it must be built\n+from source. This is made easy using a few scripts that will do the job for you\n+unless you have very a different operating system. The scripts are written and\n+tested under ubuntu and raspbian but should not be hard to modify if necessary.\n+You'll start by downloading moonfire if you have not already done so.\n+\n+## Downloading\n+\n+See the [github page](https://github.com/scottlamb/moonfire-nvr) (in case\n+you're not reading this text there already). You can download the bleeding\n+edge version from the command line via git:\n+\n+ $ git clone https://github.com/scottlamb/moonfire-nvr.git\n+\n+## Preparation steps for easy install\n+\n+There are a few things to prepare if you want a truly turnkey install, but\n+they are both optional.\n+\n+### Cameras.sql preparation\n+\n+The first (optional) step is to prepare a file with information about your\n+camera setup. If you create this file with the name `cameras.sql` and place\n+it in the top of the moonfire-nvr directory, or one level above, it will be\n+used in the next step to initialize the database. If you do *not* create the\n+file, the database will still be created, but no cameras will be configured\n+and you'll have to follow up with a separate configuration step.\n+\n+### Dedicated media directory\n+\n+Teh second (optional) step is to setup a dedicated hard disk for recording\n+video.\n+Moonfire works best if the video samples are collected on a hard drive of\n+sufficient capacity and separate from the root and main file systems. This\n+is particularly important on Raspberry Pi based systems as the flash based\n+main file systems have a limited lifetime and are way too small to hold\n+any significant amount of video.\n+If a dedicated hard drive is available, set up the mount point (in this \n+example we'll use /media/nvr/samples):\n+\n+ $ sudo vim /etc/fstab\n+ $ sudo mount /mount/media/samples\n+\n+In the fstab you would add a line similar to this:\n+\n+ /dev/disk/by-uuid/23d550bc-0e38-4825-acac-1cac8a7e091f /media/nvr ext4 defaults,noatime 0 1\n+\n+You'll have to lookup the correct uuid for your disk. One way to do that is\n+to issue the following commands:\n+\n+ $ cd /dev/disk/by-uuid\n+ $ ls -l\n+\n+Locate the device where your disk will be mounted (or is mounted), for example\n+`/dev/sda1`. Net lookup the filename linked to that from the output of the\n+`ls` command. This is the uuid you need.\n+\n+The setup script (see below) will create the necessary samples dir on the mounted\n+hard disk.\n+\n+\n+## Setting everything up\n+\n+Start by executing the setup script:\n+\n+ $ cd moonfire-nr\n+ $ scripts/setup-ubuntu.sh\n+\n+If this is the very first time you run this script, a file named `prep.config`\n+will be created and the script will stop. This file is where you will set\n+or change variables that describe the moonfire installation you want. The\n+initial execution will put default values in this value, but only for the\n+most commonly changed variabled. For a full list of variables, see below.","path":"guide/easy_install.md","position":75,"original_position":75,"commit_id":"a6fc2495935e104c7aa6d103c5f0cb14e24db664","original_commit_id":"a6fc2495935e104c7aa6d103c5f0cb14e24db664","user":{"login":"scottlamb","id":8949524,"avatar_url":"https://avatars3.githubusercontent.com/u/8949524?v=4","gravatar_id":"","url":"https://api.github.com/users/scottlamb","html_url":"https://github.com/scottlamb","followers_url":"https://api.github.com/users/scottlamb/followers","following_url":"https://api.github.com/users/scottlamb/following{/other_user}","gists_url":"https://api.github.com/users/scottlamb/gists{/gist_id}","starred_url":"https://api.github.com/users/scottlamb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottlamb/subscriptions","organizations_url":"https://api.github.com/users/scottlamb/orgs","repos_url":"https://api.github.com/users/scottlamb/repos","events_url":"https://api.github.com/users/scottlamb/events{/privacy}","received_events_url":"https://api.github.com/users/scottlamb/received_events","type":"User","site_admin":false},"body":"s/variabled/variables/","created_at":"2018-03-02T18:12:59Z","updated_at":"2018-03-02T18:22:04Z","html_url":"https://github.com/scottlamb/moonfire-nvr/pull/15#discussion_r171921316","pull_request_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/15","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/comments/171921316"},"html":{"href":"https://github.com/scottlamb/moonfire-nvr/pull/15#discussion_r171921316"},"pull_request":{"href":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/15","id":172440349,"html_url":"https://github.com/scottlamb/moonfire-nvr/pull/15","diff_url":"https://github.com/scottlamb/moonfire-nvr/pull/15.diff","patch_url":"https://github.com/scottlamb/moonfire-nvr/pull/15.patch","issue_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/issues/15","number":15,"state":"open","locked":false,"title":"Rewrite of the installation script and accompanying documentation.","user":{"login":"dolfs","id":1332437,"avatar_url":"https://avatars1.githubusercontent.com/u/1332437?v=4","gravatar_id":"","url":"https://api.github.com/users/dolfs","html_url":"https://github.com/dolfs","followers_url":"https://api.github.com/users/dolfs/followers","following_url":"https://api.github.com/users/dolfs/following{/other_user}","gists_url":"https://api.github.com/users/dolfs/gists{/gist_id}","starred_url":"https://api.github.com/users/dolfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolfs/subscriptions","organizations_url":"https://api.github.com/users/dolfs/orgs","repos_url":"https://api.github.com/users/dolfs/repos","events_url":"https://api.github.com/users/dolfs/events{/privacy}","received_events_url":"https://api.github.com/users/dolfs/received_events","type":"User","site_admin":false},"body":"I have redone the prep.sh script functionality making lots of improvements with respect to installing prerequisites, building libavutil et all. as necessary, checking for minimum needed versions of various packages and causing updates to be installed as necessary.\r\nAlso updated the documentation to reflect the new usage (there are now several scripts, kept in a separate directory).","created_at":"2018-03-02T07:45:13Z","updated_at":"2018-03-02T18:22:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8216c20ef29637fa1892245125d25be8d7438a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/15/commits","review_comments_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/15/comments","review_comment_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/issues/15/comments","statuses_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/statuses/a6fc2495935e104c7aa6d103c5f0cb14e24db664","head":{"label":"dolfs:prepupdates","ref":"prepupdates","sha":"a6fc2495935e104c7aa6d103c5f0cb14e24db664","user":{"login":"dolfs","id":1332437,"avatar_url":"https://avatars1.githubusercontent.com/u/1332437?v=4","gravatar_id":"","url":"https://api.github.com/users/dolfs","html_url":"https://github.com/dolfs","followers_url":"https://api.github.com/users/dolfs/followers","following_url":"https://api.github.com/users/dolfs/following{/other_user}","gists_url":"https://api.github.com/users/dolfs/gists{/gist_id}","starred_url":"https://api.github.com/users/dolfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolfs/subscriptions","organizations_url":"https://api.github.com/users/dolfs/orgs","repos_url":"https://api.github.com/users/dolfs/repos","events_url":"https://api.github.com/users/dolfs/events{/privacy}","received_events_url":"https://api.github.com/users/dolfs/received_events","type":"User","site_admin":false},"repo":{"id":51281289,"name":"moonfire-nvr","full_name":"dolfs/moonfire-nvr","owner":{"login":"dolfs","id":1332437,"avatar_url":"https://avatars1.githubusercontent.com/u/1332437?v=4","gravatar_id":"","url":"https://api.github.com/users/dolfs","html_url":"https://github.com/dolfs","followers_url":"https://api.github.com/users/dolfs/followers","following_url":"https://api.github.com/users/dolfs/following{/other_user}","gists_url":"https://api.github.com/users/dolfs/gists{/gist_id}","starred_url":"https://api.github.com/users/dolfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolfs/subscriptions","organizations_url":"https://api.github.com/users/dolfs/orgs","repos_url":"https://api.github.com/users/dolfs/repos","events_url":"https://api.github.com/users/dolfs/events{/privacy}","received_events_url":"https://api.github.com/users/dolfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dolfs/moonfire-nvr","description":"Moonfire NVR, a security camera network video recorder","fork":true,"url":"https://api.github.com/repos/dolfs/moonfire-nvr","forks_url":"https://api.github.com/repos/dolfs/moonfire-nvr/forks","keys_url":"https://api.github.com/repos/dolfs/moonfire-nvr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolfs/moonfire-nvr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolfs/moonfire-nvr/teams","hooks_url":"https://api.github.com/repos/dolfs/moonfire-nvr/hooks","issue_events_url":"https://api.github.com/repos/dolfs/moonfire-nvr/issues/events{/number}","events_url":"https://api.github.com/repos/dolfs/moonfire-nvr/events","assignees_url":"https://api.github.com/repos/dolfs/moonfire-nvr/assignees{/user}","branches_url":"https://api.github.com/repos/dolfs/moonfire-nvr/branches{/branch}","tags_url":"https://api.github.com/repos/dolfs/moonfire-nvr/tags","blobs_url":"https://api.github.com/repos/dolfs/moonfire-nvr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolfs/moonfire-nvr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolfs/moonfire-nvr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolfs/moonfire-nvr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolfs/moonfire-nvr/statuses/{sha}","languages_url":"https://api.github.com/repos/dolfs/moonfire-nvr/languages","stargazers_url":"https://api.github.com/repos/dolfs/moonfire-nvr/stargazers","contributors_url":"https://api.github.com/repos/dolfs/moonfire-nvr/contributors","subscribers_url":"https://api.github.com/repos/dolfs/moonfire-nvr/subscribers","subscription_url":"https://api.github.com/repos/dolfs/moonfire-nvr/subscription","commits_url":"https://api.github.com/repos/dolfs/moonfire-nvr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolfs/moonfire-nvr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolfs/moonfire-nvr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolfs/moonfire-nvr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolfs/moonfire-nvr/contents/{+path}","compare_url":"https://api.github.com/repos/dolfs/moonfire-nvr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolfs/moonfire-nvr/merges","archive_url":"https://api.github.com/repos/dolfs/moonfire-nvr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolfs/moonfire-nvr/downloads","issues_url":"https://api.github.com/repos/dolfs/moonfire-nvr/issues{/number}","pulls_url":"https://api.github.com/repos/dolfs/moonfire-nvr/pulls{/number}","milestones_url":"https://api.github.com/repos/dolfs/moonfire-nvr/milestones{/number}","notifications_url":"https://api.github.com/repos/dolfs/moonfire-nvr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolfs/moonfire-nvr/labels{/name}","releases_url":"https://api.github.com/repos/dolfs/moonfire-nvr/releases{/id}","deployments_url":"https://api.github.com/repos/dolfs/moonfire-nvr/deployments","created_at":"2016-02-08T05:44:49Z","updated_at":"2016-02-08T05:44:50Z","pushed_at":"2018-03-02T07:43:33Z","git_url":"git://github.com/dolfs/moonfire-nvr.git","ssh_url":"[email protected]:dolfs/moonfire-nvr.git","clone_url":"https://github.com/dolfs/moonfire-nvr.git","svn_url":"https://github.com/dolfs/moonfire-nvr","homepage":null,"size":1175,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scottlamb:master","ref":"master","sha":"0d69f4f49bab80eefb820e95f21e8af85967cbf7","user":{"login":"scottlamb","id":8949524,"avatar_url":"https://avatars3.githubusercontent.com/u/8949524?v=4","gravatar_id":"","url":"https://api.github.com/users/scottlamb","html_url":"https://github.com/scottlamb","followers_url":"https://api.github.com/users/scottlamb/followers","following_url":"https://api.github.com/users/scottlamb/following{/other_user}","gists_url":"https://api.github.com/users/scottlamb/gists{/gist_id}","starred_url":"https://api.github.com/users/scottlamb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottlamb/subscriptions","organizations_url":"https://api.github.com/users/scottlamb/orgs","repos_url":"https://api.github.com/users/scottlamb/repos","events_url":"https://api.github.com/users/scottlamb/events{/privacy}","received_events_url":"https://api.github.com/users/scottlamb/received_events","type":"User","site_admin":false},"repo":{"id":48900514,"name":"moonfire-nvr","full_name":"scottlamb/moonfire-nvr","owner":{"login":"scottlamb","id":8949524,"avatar_url":"https://avatars3.githubusercontent.com/u/8949524?v=4","gravatar_id":"","url":"https://api.github.com/users/scottlamb","html_url":"https://github.com/scottlamb","followers_url":"https://api.github.com/users/scottlamb/followers","following_url":"https://api.github.com/users/scottlamb/following{/other_user}","gists_url":"https://api.github.com/users/scottlamb/gists{/gist_id}","starred_url":"https://api.github.com/users/scottlamb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottlamb/subscriptions","organizations_url":"https://api.github.com/users/scottlamb/orgs","repos_url":"https://api.github.com/users/scottlamb/repos","events_url":"https://api.github.com/users/scottlamb/events{/privacy}","received_events_url":"https://api.github.com/users/scottlamb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scottlamb/moonfire-nvr","description":"Moonfire NVR, a security camera network video recorder","fork":false,"url":"https://api.github.com/repos/scottlamb/moonfire-nvr","forks_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/forks","keys_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/teams","hooks_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/hooks","issue_events_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/issues/events{/number}","events_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/events","assignees_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/assignees{/user}","branches_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/branches{/branch}","tags_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/tags","blobs_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/git/refs{/sha}","trees_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/statuses/{sha}","languages_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/languages","stargazers_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/stargazers","contributors_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/contributors","subscribers_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/subscribers","subscription_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/subscription","commits_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/commits{/sha}","git_commits_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/git/commits{/sha}","comments_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/comments{/number}","issue_comment_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/issues/comments{/number}","contents_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/contents/{+path}","compare_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/merges","archive_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/downloads","issues_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/issues{/number}","pulls_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls{/number}","milestones_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/milestones{/number}","notifications_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/labels{/name}","releases_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/releases{/id}","deployments_url":"https://api.github.com/repos/scottlamb/moonfire-nvr/deployments","created_at":"2016-01-02T06:05:42Z","updated_at":"2018-02-24T06:13:32Z","pushed_at":"2018-03-02T07:45:14Z","git_url":"git://github.com/scottlamb/moonfire-nvr.git","ssh_url":"[email protected]:scottlamb/moonfire-nvr.git","clone_url":"https://github.com/scottlamb/moonfire-nvr.git","svn_url":"https://github.com/scottlamb/moonfire-nvr","homepage":null,"size":1521,"stargazers_count":29,"watchers_count":29,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":9,"open_issues":7,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/15"},"html":{"href":"https://github.com/scottlamb/moonfire-nvr/pull/15"},"issue":{"href":"https://api.github.com/repos/scottlamb/moonfire-nvr/issues/15"},"comments":{"href":"https://api.github.com/repos/scottlamb/moonfire-nvr/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scottlamb/moonfire-nvr/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/scottlamb/moonfire-nvr/statuses/a6fc2495935e104c7aa6d103c5f0cb14e24db664"}},"author_association":"CONTRIBUTOR"}} | {
"id": 48900514,
"name": "scottlamb/moonfire-nvr",
"url": "https://api.github.com/repos/scottlamb/moonfire-nvr"
} | {
"id": 8949524,
"login": "scottlamb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8949524?",
"url": "https://api.github.com/users/scottlamb"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-03-02T18:12:59 | 7323335077 | {"actor":{"display_login":"scottlamb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments/244501856","pull_request_review_id":188416238,"id":244501856,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDUwMTg1Ng==","diff_hunk":"@@ -0,0 +1,697 @@\n+import QtQuick 2.7\n+import QtQuick.Layouts 1.1\n+import QtQuick.Controls 2.0\n+import QtGraphicalEffects 1.0\n+import QtQuick.Controls.Styles 1.4\n+import QtQuick.Dialogs 1.2\n+\n+import moneroComponents.Clipboard 1.0\n+import moneroComponents.Wallet 1.0\n+import moneroComponents.WalletManager 1.0\n+import moneroComponents.TransactionHistory 1.0\n+import moneroComponents.TransactionHistoryModel 1.0\n+import moneroComponents.Subaddress 1.0\n+import moneroComponents.SubaddressModel 1.0\n+\n+import \"../../js/Windows.js\" as Windows\n+import \"../../js/TxUtils.js\" as TxUtils\n+import \"../../js/Utils.js\" as Utils\n+import \"../../components\" as MoneroComponents\n+import \"../../pages\"\n+import \".\"\n+\n+Item {\n+ id: root\n+ anchors.margins: 0\n+\n+ property int minWidth: 900 * scaleRatio\n+ property int qrCodeSize: 220 * scaleRatio\n+ property bool enableTracking: false\n+ property string trackingError: \"\" // setting this will show a message @ tracking table\n+ property alias merchantHeight: mainLayout.height\n+ property string addressLabel: \"\"\n+ property var hiddenAmounts: []\n+\n+ function onPageCompleted() {\n+ appWindow.titlebarToggleOrange();\n+ appWindow.hideMenu();\n+\n+ // prepare tracking\n+ trackingCheckbox.checked = root.enableTracking\n+ root.update();\n+ timer.running = true;\n+\n+ // set currently selected account indication\n+ var _addressLabel = appWindow.currentWallet.getSubaddressLabel(\n+ appWindow.currentWallet.currentSubaddressAccount,\n+ appWindow.current_subaddress_table_index);\n+ if(_addressLabel === \"\"){\n+ root.addressLabel = \"#\" + appWindow.current_subaddress_table_index;\n+ } else {\n+ root.addressLabel = _addressLabel;\n+ }\n+ }\n+\n+ function onPageClosed() {\n+ appWindow.titlebarToggleOrange();\n+\n+ // reset component objects\n+ timer.running = false\n+ root.enableTracking = false\n+ trackingModel.clear()\n+\n+ appWindow.showMenu();\n+ }\n+\n+ Image {\n+ anchors.top: parent.top\n+ anchors.left: parent.left\n+ anchors.right: parent.right\n+ height: 300 * scaleRatio\n+ source: \"../../images/merchant/bg.png\"\n+ smooth: false\n+ }\n+\n+ ColumnLayout {\n+ id: mainLayout\n+ visible: parent.width >= root.minWidth\n+ spacing: 0\n+\n+ // emulates max-width + center for container\n+ property int maxWidth: 1200 * scaleRatio\n+ property int defaultMargin: 50 * scaleRatio\n+ property int horizontalMargin: {\n+ if(appWindow.width >= maxWidth){\n+ return ((appWindow.width - maxWidth) / 2) + defaultMargin;\n+ } else {\n+ return defaultMargin;\n+ }\n+ }\n+\n+ anchors.leftMargin: horizontalMargin\n+ anchors.rightMargin: horizontalMargin\n+ anchors.margins: defaultMargin\n+ anchors.left: parent.left\n+ anchors.top: parent.top\n+ anchors.right: parent.right\n+\n+ Item {\n+ height: 220 * scaleRatio\n+ anchors.left: parent.left\n+ anchors.right: parent.right\n+\n+ Rectangle {\n+ id: tracker\n+ anchors.left: parent.left\n+ anchors.top: parent.top\n+ height: 220 * scaleRatio\n+ width: (parent.width - qrImg.width) - 50 * scaleRatio\n+ radius: 5\n+\n+ ColumnLayout {\n+ anchors.top: parent.top\n+ anchors.left: parent.left\n+ anchors.right: parent.right\n+ spacing: 0\n+\n+ RowLayout {\n+ spacing: 0\n+ height: 56 * scaleRatio\n+\n+ RowLayout {\n+ Layout.alignment: Qt.AlignLeft\n+ Layout.preferredWidth: 260 * scaleRatio\n+ Layout.preferredHeight: parent.height\n+ Layout.fillHeight: true\n+ spacing: 8 * scaleRatio\n+\n+ Item {\n+ Layout.preferredWidth: 10 * scaleRatio\n+ }\n+\n+ Text {\n+ font.pixelSize: 16 * scaleRatio\n+ font.bold: true\n+ color: \"#767676\"\n+ text: qsTr(\"Sales\")\n+ }\n+\n+ Item {\n+ Layout.fillWidth: true\n+ }\n+ }\n+\n+ Item {\n+ Layout.fillWidth: true\n+ }\n+ }\n+\n+ Rectangle {\n+ Layout.fillWidth: true\n+ Layout.preferredHeight: 1 * scaleRatio\n+ color: \"#d9d9d9\"\n+ }\n+\n+ MerchantTrackingList {\n+ Layout.fillWidth: true\n+ Layout.preferredHeight: 400 * scaleRatio\n+ model: trackingModel\n+ message: {\n+ if(!root.enableTracking){\n+ return qsTr(\n+ \"<style>p{font-size:14px;}</style>\" +\n+ \"<p>This page will automatically scan the blockchain and the tx pool \" +\n+ \"for incoming transactions using the QR code.</p>\" +\n+ \"<p>It's up to you whether to accept unconfirmed transactions or not. It is likely they'll be \" +\n+ \"confirmed in short order, but there is still a possibility they might not, so for larger \" +\n+ \"values you may want to wait for one or more confirmation(s).</p>\"\n+ );\n+ } else if(root.trackingError !== \"\"){\n+ return root.trackingError;\n+ } else if(trackingModel.count < 1){\n+ return qsTr(\"Currently monitoring incoming transactions, none found yet.\");\n+ } else {\n+ return \"\"\n+ }\n+ }\n+ onHideAmountToggled: {\n+ if(root.hiddenAmounts.indexOf(txid) < 0){\n+ root.hiddenAmounts.push(txid);\n+ } else {\n+ root.hiddenAmounts = root.hiddenAmounts.filter(function(_txid) { return _txid !== txid });\n+ }\n+ }\n+ }\n+ }\n+ }\n+\n+ DropShadow {\n+ anchors.fill: source\n+ cached: true\n+ horizontalOffset: 3\n+ verticalOffset: 3\n+ radius: 8.0\n+ samples: 16\n+ color: \"#20000000\"\n+ smooth: true\n+ source: tracker\n+ }\n+\n+ Rectangle {\n+ id: qrImg\n+ color: \"white\"\n+\n+ anchors.right: parent.right\n+ anchors.top: parent.top\n+\n+ height: root.qrCodeSize\n+ width: root.qrCodeSize\n+\n+ Layout.maximumWidth: root.qrCodeSize\n+ Layout.preferredHeight: width\n+ radius: 5\n+\n+ Image {\n+ id: qrCode\n+ anchors.fill: parent\n+ anchors.margins: 1 * scaleRatio\n+\n+ smooth: false\n+ fillMode: Image.PreserveAspectFit\n+ source: \"image://qrcode/\" + TxUtils.makeQRCodeString(appWindow.current_address, amountToReceive.text)\n+\n+ MouseArea {\n+ anchors.fill: parent\n+ acceptedButtons: Qt.RightButton\n+ onClicked: {\n+ if (mouse.button == Qt.RightButton){\n+ qrMenu.x = this.mouseX;\n+ qrMenu.y = this.mouseY;\n+ qrMenu.open()\n+ }\n+ }\n+ onPressAndHold: qrFileDialog.open()\n+ }\n+ }\n+\n+ Menu {\n+ id: qrMenu\n+ title: \"QrCode\"\n+\n+ MenuItem {\n+ text: qsTr(\"Save As\") + translationManager.emptyString;\n+ onTriggered: qrFileDialog.open()\n+ }\n+ }\n+ }\n+\n+ DropShadow {\n+ anchors.fill: source\n+ cached: true\n+ horizontalOffset: 3\n+ verticalOffset: 3\n+ radius: 8.0\n+ samples: 16\n+ color: \"#30000000\"","path":"pages/merchant/Merchant.qml","position":255,"original_position":255,"commit_id":"28ae10b3ec1c7bc1c544735c4e90295b523c632b","original_commit_id":"28ae10b3ec1c7bc1c544735c4e90295b523c632b","user":{"login":"xmrdsc","id":1478325,"node_id":"MDQ6VXNlcjE0NzgzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1478325?v=4","gravatar_id":"","url":"https://api.github.com/users/xmrdsc","html_url":"https://github.com/xmrdsc","followers_url":"https://api.github.com/users/xmrdsc/followers","following_url":"https://api.github.com/users/xmrdsc/following{/other_user}","gists_url":"https://api.github.com/users/xmrdsc/gists{/gist_id}","starred_url":"https://api.github.com/users/xmrdsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmrdsc/subscriptions","organizations_url":"https://api.github.com/users/xmrdsc/orgs","repos_url":"https://api.github.com/users/xmrdsc/repos","events_url":"https://api.github.com/users/xmrdsc/events{/privacy}","received_events_url":"https://api.github.com/users/xmrdsc/received_events","type":"User","site_admin":false},"body":"Slightly transparent. Try `#FF000000` and compare.","created_at":"2018-12-29T16:42:30Z","updated_at":"2018-12-29T16:42:30Z","html_url":"https://github.com/monero-project/monero-gui/pull/1793#discussion_r244501856","pull_request_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments/244501856"},"html":{"href":"https://github.com/monero-project/monero-gui/pull/1793#discussion_r244501856"},"pull_request":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793"}},"in_reply_to_id":243222905},"pull_request":{"url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793","id":237130801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTMwODAx","html_url":"https://github.com/monero-project/monero-gui/pull/1793","diff_url":"https://github.com/monero-project/monero-gui/pull/1793.diff","patch_url":"https://github.com/monero-project/monero-gui/pull/1793.patch","issue_url":"https://api.github.com/repos/monero-project/monero-gui/issues/1793","number":1793,"state":"open","locked":false,"title":"Merchant page","user":{"login":"xmrdsc","id":1478325,"node_id":"MDQ6VXNlcjE0NzgzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1478325?v=4","gravatar_id":"","url":"https://api.github.com/users/xmrdsc","html_url":"https://github.com/xmrdsc","followers_url":"https://api.github.com/users/xmrdsc/followers","following_url":"https://api.github.com/users/xmrdsc/following{/other_user}","gists_url":"https://api.github.com/users/xmrdsc/gists{/gist_id}","starred_url":"https://api.github.com/users/xmrdsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmrdsc/subscriptions","organizations_url":"https://api.github.com/users/xmrdsc/orgs","repos_url":"https://api.github.com/users/xmrdsc/repos","events_url":"https://api.github.com/users/xmrdsc/events{/privacy}","received_events_url":"https://api.github.com/users/xmrdsc/received_events","type":"User","site_admin":false},"body":"This PR introduces a dedicated merchant page. Current iteration of the merchant features present on the receive page are inadequate to be used as a point of sales system.\r\n\r\nThe changes in this PR will make it easier for merchants to accept Monero. Run the application in full-screen mode, set the amount to be received and customers scan the QR code.\r\n\r\nAlternatively you can provide a payment URL.\r\n\r\nSome notes:\r\n\r\n- Introduces a menu under Receive called Merchant.\r\n- Optimized for running in full-screen.\r\n- Transaction history shows a 'X time ago' indication. i.e: \"the transaction happened 5 minutes ago\"\r\n- Incoming transactions are monitored via tx pool.\r\n- For now, clicking on transactions takes you to the History page.\r\n- In the future merchants could optionally specify their to received amount in USD when #1714 is accepted & merged.\r\n\r\n\r\n\r\n\r\n\r\n[Video](https://i.imgur.com/xk2dlEA.mp4)","created_at":"2018-12-09T13:25:23Z","updated_at":"2018-12-29T16:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aad2d731e2f6a62816a62e245f4691a86ec8b018","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793/commits","review_comments_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793/comments","review_comment_url":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/monero-gui/issues/1793/comments","statuses_url":"https://api.github.com/repos/monero-project/monero-gui/statuses/28ae10b3ec1c7bc1c544735c4e90295b523c632b","head":{"label":"xmrdsc:receive-merchant","ref":"receive-merchant","sha":"28ae10b3ec1c7bc1c544735c4e90295b523c632b","user":{"login":"xmrdsc","id":1478325,"node_id":"MDQ6VXNlcjE0NzgzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1478325?v=4","gravatar_id":"","url":"https://api.github.com/users/xmrdsc","html_url":"https://github.com/xmrdsc","followers_url":"https://api.github.com/users/xmrdsc/followers","following_url":"https://api.github.com/users/xmrdsc/following{/other_user}","gists_url":"https://api.github.com/users/xmrdsc/gists{/gist_id}","starred_url":"https://api.github.com/users/xmrdsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmrdsc/subscriptions","organizations_url":"https://api.github.com/users/xmrdsc/orgs","repos_url":"https://api.github.com/users/xmrdsc/repos","events_url":"https://api.github.com/users/xmrdsc/events{/privacy}","received_events_url":"https://api.github.com/users/xmrdsc/received_events","type":"User","site_admin":false},"repo":{"id":110373663,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAzNzM2NjM=","name":"monero-core","full_name":"xmrdsc/monero-core","private":false,"owner":{"login":"xmrdsc","id":1478325,"node_id":"MDQ6VXNlcjE0NzgzMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1478325?v=4","gravatar_id":"","url":"https://api.github.com/users/xmrdsc","html_url":"https://github.com/xmrdsc","followers_url":"https://api.github.com/users/xmrdsc/followers","following_url":"https://api.github.com/users/xmrdsc/following{/other_user}","gists_url":"https://api.github.com/users/xmrdsc/gists{/gist_id}","starred_url":"https://api.github.com/users/xmrdsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmrdsc/subscriptions","organizations_url":"https://api.github.com/users/xmrdsc/orgs","repos_url":"https://api.github.com/users/xmrdsc/repos","events_url":"https://api.github.com/users/xmrdsc/events{/privacy}","received_events_url":"https://api.github.com/users/xmrdsc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xmrdsc/monero-core","description":"Monero: the secure, private, untraceable cryptocurrency","fork":true,"url":"https://api.github.com/repos/xmrdsc/monero-core","forks_url":"https://api.github.com/repos/xmrdsc/monero-core/forks","keys_url":"https://api.github.com/repos/xmrdsc/monero-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xmrdsc/monero-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xmrdsc/monero-core/teams","hooks_url":"https://api.github.com/repos/xmrdsc/monero-core/hooks","issue_events_url":"https://api.github.com/repos/xmrdsc/monero-core/issues/events{/number}","events_url":"https://api.github.com/repos/xmrdsc/monero-core/events","assignees_url":"https://api.github.com/repos/xmrdsc/monero-core/assignees{/user}","branches_url":"https://api.github.com/repos/xmrdsc/monero-core/branches{/branch}","tags_url":"https://api.github.com/repos/xmrdsc/monero-core/tags","blobs_url":"https://api.github.com/repos/xmrdsc/monero-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xmrdsc/monero-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xmrdsc/monero-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xmrdsc/monero-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xmrdsc/monero-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xmrdsc/monero-core/languages","stargazers_url":"https://api.github.com/repos/xmrdsc/monero-core/stargazers","contributors_url":"https://api.github.com/repos/xmrdsc/monero-core/contributors","subscribers_url":"https://api.github.com/repos/xmrdsc/monero-core/subscribers","subscription_url":"https://api.github.com/repos/xmrdsc/monero-core/subscription","commits_url":"https://api.github.com/repos/xmrdsc/monero-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xmrdsc/monero-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xmrdsc/monero-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xmrdsc/monero-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xmrdsc/monero-core/contents/{+path}","compare_url":"https://api.github.com/repos/xmrdsc/monero-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xmrdsc/monero-core/merges","archive_url":"https://api.github.com/repos/xmrdsc/monero-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xmrdsc/monero-core/downloads","issues_url":"https://api.github.com/repos/xmrdsc/monero-core/issues{/number}","pulls_url":"https://api.github.com/repos/xmrdsc/monero-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xmrdsc/monero-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xmrdsc/monero-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xmrdsc/monero-core/labels{/name}","releases_url":"https://api.github.com/repos/xmrdsc/monero-core/releases{/id}","deployments_url":"https://api.github.com/repos/xmrdsc/monero-core/deployments","created_at":"2017-11-11T19:27:58Z","updated_at":"2018-12-29T16:28:03Z","pushed_at":"2018-12-29T16:27:58Z","git_url":"git://github.com/xmrdsc/monero-core.git","ssh_url":"[email protected]:xmrdsc/monero-core.git","clone_url":"https://github.com/xmrdsc/monero-core.git","svn_url":"https://github.com/xmrdsc/monero-core","homepage":null,"size":10209,"stargazers_count":1,"watchers_count":1,"language":"QML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"bac833c1dd95666e159406f290ad334decee2810","user":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":33237663,"node_id":"MDEwOlJlcG9zaXRvcnkzMzIzNzY2Mw==","name":"monero-gui","full_name":"monero-project/monero-gui","private":false,"owner":{"login":"monero-project","id":7450663,"node_id":"MDQ6VXNlcjc0NTA2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7450663?v=4","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"html_url":"https://github.com/monero-project/monero-gui","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/monero-gui","forks_url":"https://api.github.com/repos/monero-project/monero-gui/forks","keys_url":"https://api.github.com/repos/monero-project/monero-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/monero-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/monero-gui/teams","hooks_url":"https://api.github.com/repos/monero-project/monero-gui/hooks","issue_events_url":"https://api.github.com/repos/monero-project/monero-gui/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/monero-gui/events","assignees_url":"https://api.github.com/repos/monero-project/monero-gui/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/monero-gui/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/monero-gui/tags","blobs_url":"https://api.github.com/repos/monero-project/monero-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/monero-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/monero-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/monero-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/monero-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/monero-gui/languages","stargazers_url":"https://api.github.com/repos/monero-project/monero-gui/stargazers","contributors_url":"https://api.github.com/repos/monero-project/monero-gui/contributors","subscribers_url":"https://api.github.com/repos/monero-project/monero-gui/subscribers","subscription_url":"https://api.github.com/repos/monero-project/monero-gui/subscription","commits_url":"https://api.github.com/repos/monero-project/monero-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/monero-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/monero-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/monero-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/monero-gui/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/monero-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/monero-gui/merges","archive_url":"https://api.github.com/repos/monero-project/monero-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/monero-gui/downloads","issues_url":"https://api.github.com/repos/monero-project/monero-gui/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/monero-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/monero-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/monero-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/monero-gui/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/monero-gui/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/monero-gui/deployments","created_at":"2015-04-01T09:08:42Z","updated_at":"2018-12-28T22:13:12Z","pushed_at":"2018-12-28T19:29:13Z","git_url":"git://github.com/monero-project/monero-gui.git","ssh_url":"[email protected]:monero-project/monero-gui.git","clone_url":"https://github.com/monero-project/monero-gui.git","svn_url":"https://github.com/monero-project/monero-gui","homepage":null,"size":10037,"stargazers_count":380,"watchers_count":380,"language":"QML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":492,"mirror_url":null,"archived":false,"open_issues_count":169,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":492,"open_issues":169,"watchers":380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793"},"html":{"href":"https://github.com/monero-project/monero-gui/pull/1793"},"issue":{"href":"https://api.github.com/repos/monero-project/monero-gui/issues/1793"},"comments":{"href":"https://api.github.com/repos/monero-project/monero-gui/issues/1793/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/monero-gui/pulls/1793/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/monero-gui/statuses/28ae10b3ec1c7bc1c544735c4e90295b523c632b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 33237663,
"name": "monero-project/monero-gui",
"url": "https://api.github.com/repos/monero-project/monero-gui"
} | {
"id": 1478325,
"login": "xmrdsc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1478325?",
"url": "https://api.github.com/users/xmrdsc"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-12-29T16:42:30 | 8815290313 | {"actor":{"display_login":"xmrdsc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ader1990/LISAv2/pulls/comments/227648567","pull_request_review_id":167737284,"id":227648567,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzY0ODU2Nw==","diff_hunk":"@@ -0,0 +1,223 @@\n+#!/bin/bash\n+# Copyright (c) Microsoft Corporation. All rights reserved.\n+# Licensed under the Apache License.\n+\n+. utils.sh || {\n+ echo \"Error: unable to source utils.sh!\"\n+ exit 0\n+}\n+\n+UtilsInit\n+\n+function Test_Local_Copy_File() {\n+ LogMsg \"Start to dd file\"\n+\n+ #dd 5G files\n+ dd if=/dev/zero of=/root/data bs=2048 count=2500000","path":"Testscripts/Linux/STOR-Large-CopyFile.sh","position":16,"original_position":16,"commit_id":"b6ef5d981251958cddfbc42e516a4d99cfd168bf","original_commit_id":"b6ef5d981251958cddfbc42e516a4d99cfd168bf","user":{"login":"mbivolan","id":30174925,"node_id":"MDQ6VXNlcjMwMTc0OTI1","avatar_url":"https://avatars1.githubusercontent.com/u/30174925?v=4","gravatar_id":"","url":"https://api.github.com/users/mbivolan","html_url":"https://github.com/mbivolan","followers_url":"https://api.github.com/users/mbivolan/followers","following_url":"https://api.github.com/users/mbivolan/following{/other_user}","gists_url":"https://api.github.com/users/mbivolan/gists{/gist_id}","starred_url":"https://api.github.com/users/mbivolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbivolan/subscriptions","organizations_url":"https://api.github.com/users/mbivolan/orgs","repos_url":"https://api.github.com/users/mbivolan/repos","events_url":"https://api.github.com/users/mbivolan/events{/privacy}","received_events_url":"https://api.github.com/users/mbivolan/received_events","type":"User","site_admin":false},"body":"no","created_at":"2018-10-24T05:47:22Z","updated_at":"2018-10-24T05:47:22Z","html_url":"https://github.com/ader1990/LISAv2/pull/24#discussion_r227648567","pull_request_url":"https://api.github.com/repos/ader1990/LISAv2/pulls/24","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ader1990/LISAv2/pulls/comments/227648567"},"html":{"href":"https://github.com/ader1990/LISAv2/pull/24#discussion_r227648567"},"pull_request":{"href":"https://api.github.com/repos/ader1990/LISAv2/pulls/24"}},"in_reply_to_id":227392469},"pull_request":{"url":"https://api.github.com/repos/ader1990/LISAv2/pulls/24","id":225026075,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MDI2MDc1","html_url":"https://github.com/ader1990/LISAv2/pull/24","diff_url":"https://github.com/ader1990/LISAv2/pull/24.diff","patch_url":"https://github.com/ader1990/LISAv2/pull/24.patch","issue_url":"https://api.github.com/repos/ader1990/LISAv2/issues/24","number":24,"state":"open","locked":false,"title":"Test port","user":{"login":"mbivolan","id":30174925,"node_id":"MDQ6VXNlcjMwMTc0OTI1","avatar_url":"https://avatars1.githubusercontent.com/u/30174925?v=4","gravatar_id":"","url":"https://api.github.com/users/mbivolan","html_url":"https://github.com/mbivolan","followers_url":"https://api.github.com/users/mbivolan/followers","following_url":"https://api.github.com/users/mbivolan/following{/other_user}","gists_url":"https://api.github.com/users/mbivolan/gists{/gist_id}","starred_url":"https://api.github.com/users/mbivolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbivolan/subscriptions","organizations_url":"https://api.github.com/users/mbivolan/orgs","repos_url":"https://api.github.com/users/mbivolan/repos","events_url":"https://api.github.com/users/mbivolan/events{/privacy}","received_events_url":"https://api.github.com/users/mbivolan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-23T12:52:33Z","updated_at":"2018-10-24T05:47:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c201cef3afc8d9fb5afdc63eafe0803b018300b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ader1990/LISAv2/pulls/24/commits","review_comments_url":"https://api.github.com/repos/ader1990/LISAv2/pulls/24/comments","review_comment_url":"https://api.github.com/repos/ader1990/LISAv2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ader1990/LISAv2/issues/24/comments","statuses_url":"https://api.github.com/repos/ader1990/LISAv2/statuses/b6ef5d981251958cddfbc42e516a4d99cfd168bf","head":{"label":"mbivolan:test-port","ref":"test-port","sha":"b6ef5d981251958cddfbc42e516a4d99cfd168bf","user":{"login":"mbivolan","id":30174925,"node_id":"MDQ6VXNlcjMwMTc0OTI1","avatar_url":"https://avatars1.githubusercontent.com/u/30174925?v=4","gravatar_id":"","url":"https://api.github.com/users/mbivolan","html_url":"https://github.com/mbivolan","followers_url":"https://api.github.com/users/mbivolan/followers","following_url":"https://api.github.com/users/mbivolan/following{/other_user}","gists_url":"https://api.github.com/users/mbivolan/gists{/gist_id}","starred_url":"https://api.github.com/users/mbivolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbivolan/subscriptions","organizations_url":"https://api.github.com/users/mbivolan/orgs","repos_url":"https://api.github.com/users/mbivolan/repos","events_url":"https://api.github.com/users/mbivolan/events{/privacy}","received_events_url":"https://api.github.com/users/mbivolan/received_events","type":"User","site_admin":false},"repo":{"id":137747532,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3NDc1MzI=","name":"LISAv2","full_name":"mbivolan/LISAv2","private":false,"owner":{"login":"mbivolan","id":30174925,"node_id":"MDQ6VXNlcjMwMTc0OTI1","avatar_url":"https://avatars1.githubusercontent.com/u/30174925?v=4","gravatar_id":"","url":"https://api.github.com/users/mbivolan","html_url":"https://github.com/mbivolan","followers_url":"https://api.github.com/users/mbivolan/followers","following_url":"https://api.github.com/users/mbivolan/following{/other_user}","gists_url":"https://api.github.com/users/mbivolan/gists{/gist_id}","starred_url":"https://api.github.com/users/mbivolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbivolan/subscriptions","organizations_url":"https://api.github.com/users/mbivolan/orgs","repos_url":"https://api.github.com/users/mbivolan/repos","events_url":"https://api.github.com/users/mbivolan/events{/privacy}","received_events_url":"https://api.github.com/users/mbivolan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mbivolan/LISAv2","description":null,"fork":true,"url":"https://api.github.com/repos/mbivolan/LISAv2","forks_url":"https://api.github.com/repos/mbivolan/LISAv2/forks","keys_url":"https://api.github.com/repos/mbivolan/LISAv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbivolan/LISAv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbivolan/LISAv2/teams","hooks_url":"https://api.github.com/repos/mbivolan/LISAv2/hooks","issue_events_url":"https://api.github.com/repos/mbivolan/LISAv2/issues/events{/number}","events_url":"https://api.github.com/repos/mbivolan/LISAv2/events","assignees_url":"https://api.github.com/repos/mbivolan/LISAv2/assignees{/user}","branches_url":"https://api.github.com/repos/mbivolan/LISAv2/branches{/branch}","tags_url":"https://api.github.com/repos/mbivolan/LISAv2/tags","blobs_url":"https://api.github.com/repos/mbivolan/LISAv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbivolan/LISAv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbivolan/LISAv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbivolan/LISAv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbivolan/LISAv2/statuses/{sha}","languages_url":"https://api.github.com/repos/mbivolan/LISAv2/languages","stargazers_url":"https://api.github.com/repos/mbivolan/LISAv2/stargazers","contributors_url":"https://api.github.com/repos/mbivolan/LISAv2/contributors","subscribers_url":"https://api.github.com/repos/mbivolan/LISAv2/subscribers","subscription_url":"https://api.github.com/repos/mbivolan/LISAv2/subscription","commits_url":"https://api.github.com/repos/mbivolan/LISAv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbivolan/LISAv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbivolan/LISAv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbivolan/LISAv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbivolan/LISAv2/contents/{+path}","compare_url":"https://api.github.com/repos/mbivolan/LISAv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbivolan/LISAv2/merges","archive_url":"https://api.github.com/repos/mbivolan/LISAv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbivolan/LISAv2/downloads","issues_url":"https://api.github.com/repos/mbivolan/LISAv2/issues{/number}","pulls_url":"https://api.github.com/repos/mbivolan/LISAv2/pulls{/number}","milestones_url":"https://api.github.com/repos/mbivolan/LISAv2/milestones{/number}","notifications_url":"https://api.github.com/repos/mbivolan/LISAv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbivolan/LISAv2/labels{/name}","releases_url":"https://api.github.com/repos/mbivolan/LISAv2/releases{/id}","deployments_url":"https://api.github.com/repos/mbivolan/LISAv2/deployments","created_at":"2018-06-18T12:13:19Z","updated_at":"2018-08-24T08:32:23Z","pushed_at":"2018-10-23T12:51:48Z","git_url":"git://github.com/mbivolan/LISAv2.git","ssh_url":"[email protected]:mbivolan/LISAv2.git","clone_url":"https://github.com/mbivolan/LISAv2.git","svn_url":"https://github.com/mbivolan/LISAv2","homepage":null,"size":6906,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ader1990:master","ref":"master","sha":"4d3164a87484531940d888c4c9582554943115fe","user":{"login":"ader1990","id":1412442,"node_id":"MDQ6VXNlcjE0MTI0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1412442?v=4","gravatar_id":"","url":"https://api.github.com/users/ader1990","html_url":"https://github.com/ader1990","followers_url":"https://api.github.com/users/ader1990/followers","following_url":"https://api.github.com/users/ader1990/following{/other_user}","gists_url":"https://api.github.com/users/ader1990/gists{/gist_id}","starred_url":"https://api.github.com/users/ader1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ader1990/subscriptions","organizations_url":"https://api.github.com/users/ader1990/orgs","repos_url":"https://api.github.com/users/ader1990/repos","events_url":"https://api.github.com/users/ader1990/events{/privacy}","received_events_url":"https://api.github.com/users/ader1990/received_events","type":"User","site_admin":false},"repo":{"id":139868329,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4NjgzMjk=","name":"LISAv2","full_name":"ader1990/LISAv2","private":false,"owner":{"login":"ader1990","id":1412442,"node_id":"MDQ6VXNlcjE0MTI0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1412442?v=4","gravatar_id":"","url":"https://api.github.com/users/ader1990","html_url":"https://github.com/ader1990","followers_url":"https://api.github.com/users/ader1990/followers","following_url":"https://api.github.com/users/ader1990/following{/other_user}","gists_url":"https://api.github.com/users/ader1990/gists{/gist_id}","starred_url":"https://api.github.com/users/ader1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ader1990/subscriptions","organizations_url":"https://api.github.com/users/ader1990/orgs","repos_url":"https://api.github.com/users/ader1990/repos","events_url":"https://api.github.com/users/ader1990/events{/privacy}","received_events_url":"https://api.github.com/users/ader1990/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ader1990/LISAv2","description":null,"fork":true,"url":"https://api.github.com/repos/ader1990/LISAv2","forks_url":"https://api.github.com/repos/ader1990/LISAv2/forks","keys_url":"https://api.github.com/repos/ader1990/LISAv2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ader1990/LISAv2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ader1990/LISAv2/teams","hooks_url":"https://api.github.com/repos/ader1990/LISAv2/hooks","issue_events_url":"https://api.github.com/repos/ader1990/LISAv2/issues/events{/number}","events_url":"https://api.github.com/repos/ader1990/LISAv2/events","assignees_url":"https://api.github.com/repos/ader1990/LISAv2/assignees{/user}","branches_url":"https://api.github.com/repos/ader1990/LISAv2/branches{/branch}","tags_url":"https://api.github.com/repos/ader1990/LISAv2/tags","blobs_url":"https://api.github.com/repos/ader1990/LISAv2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ader1990/LISAv2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ader1990/LISAv2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ader1990/LISAv2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ader1990/LISAv2/statuses/{sha}","languages_url":"https://api.github.com/repos/ader1990/LISAv2/languages","stargazers_url":"https://api.github.com/repos/ader1990/LISAv2/stargazers","contributors_url":"https://api.github.com/repos/ader1990/LISAv2/contributors","subscribers_url":"https://api.github.com/repos/ader1990/LISAv2/subscribers","subscription_url":"https://api.github.com/repos/ader1990/LISAv2/subscription","commits_url":"https://api.github.com/repos/ader1990/LISAv2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ader1990/LISAv2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ader1990/LISAv2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ader1990/LISAv2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ader1990/LISAv2/contents/{+path}","compare_url":"https://api.github.com/repos/ader1990/LISAv2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ader1990/LISAv2/merges","archive_url":"https://api.github.com/repos/ader1990/LISAv2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ader1990/LISAv2/downloads","issues_url":"https://api.github.com/repos/ader1990/LISAv2/issues{/number}","pulls_url":"https://api.github.com/repos/ader1990/LISAv2/pulls{/number}","milestones_url":"https://api.github.com/repos/ader1990/LISAv2/milestones{/number}","notifications_url":"https://api.github.com/repos/ader1990/LISAv2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ader1990/LISAv2/labels{/name}","releases_url":"https://api.github.com/repos/ader1990/LISAv2/releases{/id}","deployments_url":"https://api.github.com/repos/ader1990/LISAv2/deployments","created_at":"2018-07-05T15:27:23Z","updated_at":"2018-10-23T15:34:21Z","pushed_at":"2018-10-23T16:50:00Z","git_url":"git://github.com/ader1990/LISAv2.git","ssh_url":"[email protected]:ader1990/LISAv2.git","clone_url":"https://github.com/ader1990/LISAv2.git","svn_url":"https://github.com/ader1990/LISAv2","homepage":null,"size":6728,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ader1990/LISAv2/pulls/24"},"html":{"href":"https://github.com/ader1990/LISAv2/pull/24"},"issue":{"href":"https://api.github.com/repos/ader1990/LISAv2/issues/24"},"comments":{"href":"https://api.github.com/repos/ader1990/LISAv2/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/ader1990/LISAv2/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/ader1990/LISAv2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ader1990/LISAv2/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/ader1990/LISAv2/statuses/b6ef5d981251958cddfbc42e516a4d99cfd168bf"}},"author_association":"NONE"}} | {
"id": 139868329,
"name": "ader1990/LISAv2",
"url": "https://api.github.com/repos/ader1990/LISAv2"
} | {
"id": 30174925,
"login": "mbivolan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30174925?",
"url": "https://api.github.com/users/mbivolan"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-10-24T05:47:22 | 8470691803 | {"actor":{"display_login":"mbivolan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/divizdev/fintracker/pulls/comments/208289942","pull_request_review_id":144068408,"id":208289942,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODI4OTk0Mg==","diff_hunk":"@@ -0,0 +1,29 @@\n+package ru.daryasoft.fintracker.category.ui\n+\n+import android.os.Bundle\n+import android.support.v7.app.AppCompatActivity\n+import ru.daryasoft.fintracker.R\n+\n+/**\n+ * Фрагмент для отображения категорий.","path":"app/src/main/java/ru/daryasoft/fintracker/category/ui/CategoriesActivity.kt","position":8,"original_position":8,"commit_id":"a5c750c08e8b604949186494a9bc01c5677fccd8","original_commit_id":"a5c750c08e8b604949186494a9bc01c5677fccd8","user":{"login":"divizdev","id":6602576,"node_id":"MDQ6VXNlcjY2MDI1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6602576?v=4","gravatar_id":"","url":"https://api.github.com/users/divizdev","html_url":"https://github.com/divizdev","followers_url":"https://api.github.com/users/divizdev/followers","following_url":"https://api.github.com/users/divizdev/following{/other_user}","gists_url":"https://api.github.com/users/divizdev/gists{/gist_id}","starred_url":"https://api.github.com/users/divizdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divizdev/subscriptions","organizations_url":"https://api.github.com/users/divizdev/orgs","repos_url":"https://api.github.com/users/divizdev/repos","events_url":"https://api.github.com/users/divizdev/events{/privacy}","received_events_url":"https://api.github.com/users/divizdev/received_events","type":"User","site_admin":false},"body":"Мотив аналогичен предыдущему)","created_at":"2018-08-07T16:00:26Z","updated_at":"2018-08-07T16:00:26Z","html_url":"https://github.com/divizdev/fintracker/pull/1#discussion_r208289942","pull_request_url":"https://api.github.com/repos/divizdev/fintracker/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/divizdev/fintracker/pulls/comments/208289942"},"html":{"href":"https://github.com/divizdev/fintracker/pull/1#discussion_r208289942"},"pull_request":{"href":"https://api.github.com/repos/divizdev/fintracker/pulls/1"}},"in_reply_to_id":207844265},"pull_request":{"url":"https://api.github.com/repos/divizdev/fintracker/pulls/1","id":206312453,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzEyNDUz","html_url":"https://github.com/divizdev/fintracker/pull/1","diff_url":"https://github.com/divizdev/fintracker/pull/1.diff","patch_url":"https://github.com/divizdev/fintracker/pull/1.patch","issue_url":"https://api.github.com/repos/divizdev/fintracker/issues/1","number":1,"state":"open","locked":false,"title":"Task#3","user":{"login":"divizdev","id":6602576,"node_id":"MDQ6VXNlcjY2MDI1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6602576?v=4","gravatar_id":"","url":"https://api.github.com/users/divizdev","html_url":"https://github.com/divizdev","followers_url":"https://api.github.com/users/divizdev/followers","following_url":"https://api.github.com/users/divizdev/following{/other_user}","gists_url":"https://api.github.com/users/divizdev/gists{/gist_id}","starred_url":"https://api.github.com/users/divizdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divizdev/subscriptions","organizations_url":"https://api.github.com/users/divizdev/orgs","repos_url":"https://api.github.com/users/divizdev/repos","events_url":"https://api.github.com/users/divizdev/events{/privacy}","received_events_url":"https://api.github.com/users/divizdev/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-06T07:34:42Z","updated_at":"2018-08-07T16:00:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c2a23ee5b25236bb087616443883b8c77b34d49","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/divizdev/fintracker/pulls/1/commits","review_comments_url":"https://api.github.com/repos/divizdev/fintracker/pulls/1/comments","review_comment_url":"https://api.github.com/repos/divizdev/fintracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divizdev/fintracker/issues/1/comments","statuses_url":"https://api.github.com/repos/divizdev/fintracker/statuses/a5c750c08e8b604949186494a9bc01c5677fccd8","head":{"label":"divizdev:Task#3_cancel","ref":"Task#3_cancel","sha":"a5c750c08e8b604949186494a9bc01c5677fccd8","user":{"login":"divizdev","id":6602576,"node_id":"MDQ6VXNlcjY2MDI1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6602576?v=4","gravatar_id":"","url":"https://api.github.com/users/divizdev","html_url":"https://github.com/divizdev","followers_url":"https://api.github.com/users/divizdev/followers","following_url":"https://api.github.com/users/divizdev/following{/other_user}","gists_url":"https://api.github.com/users/divizdev/gists{/gist_id}","starred_url":"https://api.github.com/users/divizdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divizdev/subscriptions","organizations_url":"https://api.github.com/users/divizdev/orgs","repos_url":"https://api.github.com/users/divizdev/repos","events_url":"https://api.github.com/users/divizdev/events{/privacy}","received_events_url":"https://api.github.com/users/divizdev/received_events","type":"User","site_admin":false},"repo":{"id":143261696,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyNjE2OTY=","name":"fintracker","full_name":"divizdev/fintracker","owner":{"login":"divizdev","id":6602576,"node_id":"MDQ6VXNlcjY2MDI1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6602576?v=4","gravatar_id":"","url":"https://api.github.com/users/divizdev","html_url":"https://github.com/divizdev","followers_url":"https://api.github.com/users/divizdev/followers","following_url":"https://api.github.com/users/divizdev/following{/other_user}","gists_url":"https://api.github.com/users/divizdev/gists{/gist_id}","starred_url":"https://api.github.com/users/divizdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divizdev/subscriptions","organizations_url":"https://api.github.com/users/divizdev/orgs","repos_url":"https://api.github.com/users/divizdev/repos","events_url":"https://api.github.com/users/divizdev/events{/privacy}","received_events_url":"https://api.github.com/users/divizdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/divizdev/fintracker","description":null,"fork":true,"url":"https://api.github.com/repos/divizdev/fintracker","forks_url":"https://api.github.com/repos/divizdev/fintracker/forks","keys_url":"https://api.github.com/repos/divizdev/fintracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divizdev/fintracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divizdev/fintracker/teams","hooks_url":"https://api.github.com/repos/divizdev/fintracker/hooks","issue_events_url":"https://api.github.com/repos/divizdev/fintracker/issues/events{/number}","events_url":"https://api.github.com/repos/divizdev/fintracker/events","assignees_url":"https://api.github.com/repos/divizdev/fintracker/assignees{/user}","branches_url":"https://api.github.com/repos/divizdev/fintracker/branches{/branch}","tags_url":"https://api.github.com/repos/divizdev/fintracker/tags","blobs_url":"https://api.github.com/repos/divizdev/fintracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divizdev/fintracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divizdev/fintracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/divizdev/fintracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divizdev/fintracker/statuses/{sha}","languages_url":"https://api.github.com/repos/divizdev/fintracker/languages","stargazers_url":"https://api.github.com/repos/divizdev/fintracker/stargazers","contributors_url":"https://api.github.com/repos/divizdev/fintracker/contributors","subscribers_url":"https://api.github.com/repos/divizdev/fintracker/subscribers","subscription_url":"https://api.github.com/repos/divizdev/fintracker/subscription","commits_url":"https://api.github.com/repos/divizdev/fintracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/divizdev/fintracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/divizdev/fintracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/divizdev/fintracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/divizdev/fintracker/contents/{+path}","compare_url":"https://api.github.com/repos/divizdev/fintracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divizdev/fintracker/merges","archive_url":"https://api.github.com/repos/divizdev/fintracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divizdev/fintracker/downloads","issues_url":"https://api.github.com/repos/divizdev/fintracker/issues{/number}","pulls_url":"https://api.github.com/repos/divizdev/fintracker/pulls{/number}","milestones_url":"https://api.github.com/repos/divizdev/fintracker/milestones{/number}","notifications_url":"https://api.github.com/repos/divizdev/fintracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divizdev/fintracker/labels{/name}","releases_url":"https://api.github.com/repos/divizdev/fintracker/releases{/id}","deployments_url":"https://api.github.com/repos/divizdev/fintracker/deployments","created_at":"2018-08-02T07:54:31Z","updated_at":"2018-08-02T07:54:33Z","pushed_at":"2018-08-06T07:34:43Z","git_url":"git://github.com/divizdev/fintracker.git","ssh_url":"[email protected]:divizdev/fintracker.git","clone_url":"https://github.com/divizdev/fintracker.git","svn_url":"https://github.com/divizdev/fintracker","homepage":null,"size":534,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"divizdev:master","ref":"master","sha":"f35d0bc8540c1c402ad452fbc42b6a01555bb5c2","user":{"login":"divizdev","id":6602576,"node_id":"MDQ6VXNlcjY2MDI1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6602576?v=4","gravatar_id":"","url":"https://api.github.com/users/divizdev","html_url":"https://github.com/divizdev","followers_url":"https://api.github.com/users/divizdev/followers","following_url":"https://api.github.com/users/divizdev/following{/other_user}","gists_url":"https://api.github.com/users/divizdev/gists{/gist_id}","starred_url":"https://api.github.com/users/divizdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divizdev/subscriptions","organizations_url":"https://api.github.com/users/divizdev/orgs","repos_url":"https://api.github.com/users/divizdev/repos","events_url":"https://api.github.com/users/divizdev/events{/privacy}","received_events_url":"https://api.github.com/users/divizdev/received_events","type":"User","site_admin":false},"repo":{"id":143261696,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyNjE2OTY=","name":"fintracker","full_name":"divizdev/fintracker","owner":{"login":"divizdev","id":6602576,"node_id":"MDQ6VXNlcjY2MDI1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6602576?v=4","gravatar_id":"","url":"https://api.github.com/users/divizdev","html_url":"https://github.com/divizdev","followers_url":"https://api.github.com/users/divizdev/followers","following_url":"https://api.github.com/users/divizdev/following{/other_user}","gists_url":"https://api.github.com/users/divizdev/gists{/gist_id}","starred_url":"https://api.github.com/users/divizdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divizdev/subscriptions","organizations_url":"https://api.github.com/users/divizdev/orgs","repos_url":"https://api.github.com/users/divizdev/repos","events_url":"https://api.github.com/users/divizdev/events{/privacy}","received_events_url":"https://api.github.com/users/divizdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/divizdev/fintracker","description":null,"fork":true,"url":"https://api.github.com/repos/divizdev/fintracker","forks_url":"https://api.github.com/repos/divizdev/fintracker/forks","keys_url":"https://api.github.com/repos/divizdev/fintracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divizdev/fintracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divizdev/fintracker/teams","hooks_url":"https://api.github.com/repos/divizdev/fintracker/hooks","issue_events_url":"https://api.github.com/repos/divizdev/fintracker/issues/events{/number}","events_url":"https://api.github.com/repos/divizdev/fintracker/events","assignees_url":"https://api.github.com/repos/divizdev/fintracker/assignees{/user}","branches_url":"https://api.github.com/repos/divizdev/fintracker/branches{/branch}","tags_url":"https://api.github.com/repos/divizdev/fintracker/tags","blobs_url":"https://api.github.com/repos/divizdev/fintracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divizdev/fintracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divizdev/fintracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/divizdev/fintracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divizdev/fintracker/statuses/{sha}","languages_url":"https://api.github.com/repos/divizdev/fintracker/languages","stargazers_url":"https://api.github.com/repos/divizdev/fintracker/stargazers","contributors_url":"https://api.github.com/repos/divizdev/fintracker/contributors","subscribers_url":"https://api.github.com/repos/divizdev/fintracker/subscribers","subscription_url":"https://api.github.com/repos/divizdev/fintracker/subscription","commits_url":"https://api.github.com/repos/divizdev/fintracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/divizdev/fintracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/divizdev/fintracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/divizdev/fintracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/divizdev/fintracker/contents/{+path}","compare_url":"https://api.github.com/repos/divizdev/fintracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divizdev/fintracker/merges","archive_url":"https://api.github.com/repos/divizdev/fintracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divizdev/fintracker/downloads","issues_url":"https://api.github.com/repos/divizdev/fintracker/issues{/number}","pulls_url":"https://api.github.com/repos/divizdev/fintracker/pulls{/number}","milestones_url":"https://api.github.com/repos/divizdev/fintracker/milestones{/number}","notifications_url":"https://api.github.com/repos/divizdev/fintracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divizdev/fintracker/labels{/name}","releases_url":"https://api.github.com/repos/divizdev/fintracker/releases{/id}","deployments_url":"https://api.github.com/repos/divizdev/fintracker/deployments","created_at":"2018-08-02T07:54:31Z","updated_at":"2018-08-02T07:54:33Z","pushed_at":"2018-08-06T07:34:43Z","git_url":"git://github.com/divizdev/fintracker.git","ssh_url":"[email protected]:divizdev/fintracker.git","clone_url":"https://github.com/divizdev/fintracker.git","svn_url":"https://github.com/divizdev/fintracker","homepage":null,"size":534,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/divizdev/fintracker/pulls/1"},"html":{"href":"https://github.com/divizdev/fintracker/pull/1"},"issue":{"href":"https://api.github.com/repos/divizdev/fintracker/issues/1"},"comments":{"href":"https://api.github.com/repos/divizdev/fintracker/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/divizdev/fintracker/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/divizdev/fintracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divizdev/fintracker/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/divizdev/fintracker/statuses/a5c750c08e8b604949186494a9bc01c5677fccd8"}},"author_association":"OWNER"}} | {
"id": 143261696,
"name": "divizdev/fintracker",
"url": "https://api.github.com/repos/divizdev/fintracker"
} | {
"id": 6602576,
"login": "divizdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6602576?",
"url": "https://api.github.com/users/divizdev"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-08-07T16:00:26 | 8078651216 | {"actor":{"display_login":"divizdev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/comments/205771251","pull_request_review_id":141062956,"id":205771251,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTc3MTI1MQ==","diff_hunk":"@@ -0,0 +1,382 @@\n+package com.vroozi.service;\n+\n+import com.vroozi.model.FailedRecord;\n+import com.vroozi.model.MaterialGroupMapping;\n+import com.vroozi.model.ProcessState;\n+import com.vroozi.model.ProcessType;\n+import com.vroozi.model.Result;\n+import com.vroozi.model.SolrReindexProcess;\n+import com.vroozi.repository.MaterialGroupDao;\n+import com.vroozi.repository.SolrReindexProcessRepository;\n+import com.vroozi.util.CategoryMatcher;\n+import java.io.IOException;\n+import java.io.UnsupportedEncodingException;\n+import java.net.URLEncoder;\n+import java.util.ArrayList;\n+import java.util.Date;\n+import java.util.List;\n+import java.util.Timer;\n+import java.util.TimerTask;\n+import org.apache.commons.lang3.StringUtils;\n+import org.apache.commons.lang3.exception.ExceptionUtils;\n+import org.apache.solr.client.solrj.SolrQuery;\n+import org.apache.solr.client.solrj.SolrServerException;\n+import org.apache.solr.client.solrj.impl.HttpSolrClient;\n+import org.apache.solr.client.solrj.impl.XMLResponseParser;\n+import org.apache.solr.client.solrj.response.QueryResponse;\n+import org.apache.solr.common.SolrDocument;\n+import org.apache.solr.common.SolrInputDocument;\n+import org.apache.solr.common.params.CommonParams;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+import org.springframework.beans.factory.annotation.Autowired;\n+import org.springframework.beans.factory.annotation.Value;\n+import org.springframework.stereotype.Service;\n+import org.springframework.util.CollectionUtils;\n+\n+@Service\n+public class SolrDataReindexService {\n+\n+ private static final Logger LOGGER = LoggerFactory.getLogger(SolrDataReindexService.class);\n+\n+ @Value(\"${solr.url}\")\n+ private String solrUrl;\n+\n+ @Value(\"${records.per.page}\")\n+ int recordsPerPage;\n+\n+ @Autowired\n+ private MaterialGroupDao materialGroupDao;\n+\n+ @Autowired\n+ private SolrReindexProcessRepository solrReindexProcessRepository;\n+\n+ /**\n+ * Reindexes solr documents for given unitId\n+ *\n+ * @param unitId unique identifier for buying organization\n+ */\n+\n+ public SolrReindexProcess submitSolrReindexingProcess(Integer unitId) {\n+ SolrReindexProcess solrReindexProcess = new SolrReindexProcess(unitId);\n+ solrReindexProcess = solrReindexProcessRepository.save(solrReindexProcess);\n+ TimerTask task = new TimerTask() {\n+ public void run() {\n+ processSolrReindexing();\n+ }\n+ };\n+ Timer timer = new Timer(\"SolrReindexingTimer\");\n+ long delay = 1000L;\n+ timer.schedule(task, delay);\n+ return solrReindexProcess;\n+ }\n+\n+ public String submitRetryFailedBatchExecution(List<Integer> unitIds) {\n+ TimerTask task = new TimerTask() {\n+ public void run() {\n+ processFailedBatches(unitIds);\n+ }\n+ };\n+ Timer timer = new Timer(\"SolrRetryTimer\");\n+ long delay = 1000L;\n+ timer.schedule(task, delay);\n+ return \"success\";\n+ }\n+\n+ public void processSolrReindexing() {\n+ SolrReindexProcess solrReindexProcess = solrReindexProcessRepository\n+ .findByProcessTypeAndProcessState(ProcessType.REINDEX, ProcessState.UNPROCESSED);\n+ if (solrReindexProcess != null) {\n+ HttpSolrClient solr = new HttpSolrClient.Builder(solrUrl).build();\n+ solr.setParser(new XMLResponseParser());\n+ solrReindexProcess.setProcessState(ProcessState.PROCESSING);\n+ if (solrReindexProcess.getUnitId() != null) {\n+ reindex(solr, solrReindexProcess, solrReindexProcess.getUnitId());\n+ } else {\n+ materialGroupDao.findAllUnitIds()\n+ .forEach(unitId -> reindex(solr, solrReindexProcess, unitId));\n+ }\n+ solrReindexProcess.setProcessState(ProcessState.COMPLETED);\n+ } else {\n+ LOGGER.debug(\"Nothing to Process!\");\n+ }\n+ }\n+\n+ /* Retries the failed batches */\n+ public void processFailedBatches(List<Integer> unitIds) {\n+ List<SolrReindexProcess> solrReindexProcesses = solrReindexProcessRepository\n+ .findAllByProcessTypeAndProcessStateAndUnitIdIn(ProcessType.RETRY_FAILED,\n+ ProcessState.UNPROCESSED, unitIds);\n+\n+ if (!CollectionUtils.isEmpty(solrReindexProcesses)) {\n+ HttpSolrClient solr = new HttpSolrClient.Builder(solrUrl).build();\n+ solr.setParser(new XMLResponseParser());\n+\n+ solrReindexProcesses.forEach(solrReindexProcess -> {\n+ int unitId = solrReindexProcess.getUnitId();\n+ if (!solrReindexProcess.getFailedRecords().isEmpty()) {\n+\n+ /* Fetching list of materialGroupMapping from db */\n+ List<MaterialGroupMapping> materialGroupMappingList = materialGroupDao\n+ .findByUnitIdOrderByCatalogCategoryCodeDesc(unitId);\n+ solrReindexProcess.setProcessState(ProcessState.PROCESSING);\n+ solrReindexProcess.setStartTime(new Date());\n+ solrReindexProcessRepository.save(solrReindexProcess);\n+ processingFailedBatchForUnitId(solr, solrReindexProcess, unitId,\n+ materialGroupMappingList);\n+ }\n+\n+ solrReindexProcess.setEndTime(new Date());\n+ solrReindexProcess.setProcessState(ProcessState.COMPLETED);\n+ solrReindexProcessRepository.save(solrReindexProcess);\n+ });\n+ }\n+ }\n+\n+ private void processingFailedBatchForUnitId(HttpSolrClient solr,\n+ SolrReindexProcess solrReindexProcess, int unitId,\n+ List<MaterialGroupMapping> materialGroupMappingList) {\n+ /* Processing failed batches against a unitId */\n+ solrReindexProcess.getFailedRecords().forEach(failedRecord -> {\n+ Result result = new Result(unitId);\n+ try {\n+ QueryResponse response = getQueryResponse(solr, failedRecord.getStart(),\n+ failedRecord.getRecordsPerPage(), unitId);\n+ List<SolrInputDocument> solrInputDocumentList = processSolrDocuments(unitId,\n+ response, materialGroupMappingList, result);\n+ /* Adding solrInputDocument to solr in batches, log the batches in db if solr.commit fails */\n+ commitSolrBatch(solr, solrInputDocumentList);\n+ solrReindexProcess.getResults().add(result);\n+ } catch (Exception e) {\n+ logFailedBatch(unitId, failedRecord.getStart(), failedRecord.getRecordsPerPage(),\n+ ExceptionUtils.getStackTrace(e));\n+ LOGGER.error(\"Exception occurred while retrying failed records \", e);\n+ }\n+ });\n+ }\n+\n+ /* reindexes solr data for catalogItems against given unitId */\n+ public void reindex(HttpSolrClient solr, SolrReindexProcess solrReindexProcess, Integer unitId) {\n+ LOGGER.info(\"Going to start reindex data for unitId: {}\", unitId);\n+\n+ solrReindexProcess.setProcessState(ProcessState.PROCESSING);\n+ solrReindexProcessRepository.save(solrReindexProcess);\n+\n+ /* Fetching list of materialGroupMapping from db */\n+ List<MaterialGroupMapping> materialGroupMappingList = materialGroupDao\n+ .findByUnitIdOrderByCatalogCategoryCodeDesc(unitId);\n+\n+ int start = 0;\n+ int recordsProcessed = 0;\n+ /* Fetch totalPage count, each page will act as batch while processing */\n+ int totalPage = getTotalPage(unitId, solr);\n+ QueryResponse response;\n+ Result result = new Result(unitId);\n+\n+ for (int i = 0; i < totalPage; i++) {\n+ try {\n+ /* Fetching items from solr */\n+ response = getQueryResponse(solr, start, recordsPerPage, unitId);\n+\n+ /* Processes response solrDocuments to return List of SolrInputDocument,\n+ which will be used for solr data updation */\n+ List<SolrInputDocument> solrInputDocumentList = processSolrDocuments(unitId, response,\n+ materialGroupMappingList, result);\n+ recordsProcessed += solrInputDocumentList.size();\n+\n+ /* Adding solrInputDocument to solr in batches */\n+ commitSolrBatch(solr, solrInputDocumentList);\n+ LOGGER.info(\"Records processed from {} to {}.\", start, recordsProcessed);\n+ start = recordsProcessed;\n+ } catch (Exception e) {\n+ logFailedBatch(unitId, start, recordsPerPage, ExceptionUtils.getStackTrace(e));\n+ LOGGER.error(\"Exception occurred while reindexing \", e);\n+ }\n+ }\n+ solrReindexProcess.getResults().add(result);\n+ solrReindexProcess.setProcessState(ProcessState.COMPLETED);\n+ solrReindexProcessRepository.save(solrReindexProcess);\n+ LOGGER.info(\"Reindexing completed for unitId: {}\", unitId);\n+ }\n+\n+ private List<SolrInputDocument> processSolrDocuments(Integer unitId, QueryResponse response,\n+ List<MaterialGroupMapping> materialGroupMappingList, Result result)\n+ throws UnsupportedEncodingException {\n+ List<SolrDocument> solrDocumentList = response.getResults();\n+ List<SolrInputDocument> solrInputDocumentList = new ArrayList<>();\n+ /* Iterating over solrInputDocuments to convert it to solrInputDocuments and add the\n+ new fields like vendor_name_lowercase, mat_group_info and mat_group_label */\n+ for (SolrDocument doc : solrDocumentList) {\n+ SolrInputDocument solrInputDocument = toSolrInputDocument(doc);\n+ removeCopyFields(solrInputDocument);\n+ String solrDocumentId = solrInputDocument.get(\"id\").getValue().toString();\n+\n+ boolean recordUpdated = setMaterialGroupData(unitId, result.getErrors(),\n+ materialGroupMappingList,\n+ solrInputDocument, solrDocumentId);\n+\n+ recordUpdated = setVendorData(recordUpdated, solrInputDocument);\n+\n+ if (recordUpdated) {\n+ result.getIdsUpdated().add(solrDocumentId);\n+ }\n+\n+ solrInputDocumentList.add(solrInputDocument);\n+ }\n+ return solrInputDocumentList;\n+ }\n+\n+ private void commitSolrBatch(HttpSolrClient solr, List<SolrInputDocument> solrInputDocumentList)\n+ throws IOException, SolrServerException {\n+ if (!solrInputDocumentList.isEmpty()) {\n+ solr.add(solrInputDocumentList);\n+ solr.commit();\n+ }\n+ }\n+\n+ private void logFailedBatch(Integer unitId, int start, int recordsPerPage, String stackTrace) {\n+ SolrReindexProcess failedSolrReindexProcess = solrReindexProcessRepository\n+ .findByProcessTypeAndProcessStateAndUnitId(ProcessType.RETRY_FAILED,\n+ ProcessState.UNPROCESSED, unitId);\n+ if (failedSolrReindexProcess == null) {\n+ failedSolrReindexProcess = new SolrReindexProcess(unitId);\n+ failedSolrReindexProcess.setProcessType(ProcessType.RETRY_FAILED);\n+ failedSolrReindexProcess.setProcessState(ProcessState.UNPROCESSED);\n+ }\n+ failedSolrReindexProcess.getFailedRecords()\n+ .add(new FailedRecord(start, recordsPerPage, stackTrace));\n+ solrReindexProcessRepository.save(failedSolrReindexProcess);\n+ }\n+\n+ /* Sets vendor_name_lowercase field if there is existing vendor_name field present */\n+ private boolean setVendorData(boolean recordUpdated, SolrInputDocument solrInputDocument) {\n+ String vendorName = null;\n+ if (solrInputDocument.get(\"vendor_name\") != null) {\n+ vendorName = solrInputDocument.get(\"vendor_name\").getValue().toString();\n+ }\n+\n+ if (StringUtils.isNotBlank(vendorName)) {\n+ solrInputDocument.removeField(\"vendor_name_lowercase\");\n+ solrInputDocument.addField(\"vendor_name_lowercase\", vendorName);\n+ recordUpdated = true;\n+ }\n+ return recordUpdated;\n+ }\n+\n+ /**\n+ * Sets New Material Group Data in solrInputDocument if there is existing data, else adds an error\n+ * regarding mat group not found for that particular solrInputDocument.\n+ */\n+ private boolean setMaterialGroupData(int unitId, List<String> errors,\n+ List<MaterialGroupMapping> materialGroupMappings,\n+ SolrInputDocument solrInputDocument, String solrDocumentId)\n+ throws UnsupportedEncodingException {\n+ boolean updated = false;\n+ String matGroupLabel;\n+ String matGroupInfo;\n+ String matGroupCode = null;\n+ if (solrInputDocument.get(\"mat_group\") != null) {\n+ matGroupCode = solrInputDocument.get(\"mat_group\").getValue().toString();\n+ }\n+ if (StringUtils.isNotBlank(matGroupCode)) {\n+ MaterialGroupMapping materialGroupMapping = CategoryMatcher\n+ .findMaterialGroupMappingAgainstItemMatGroup(materialGroupMappings, matGroupCode);\n+ if (materialGroupMapping != null) {\n+ matGroupLabel = materialGroupMapping.getCompanyLabel();\n+ if (StringUtils.isNotBlank(matGroupLabel)) {\n+ matGroupInfo = materialGroupMapping.getCompanyCategoryCode() + \"|||\" + URLEncoder\n+ .encode(matGroupLabel, \"UTF-8\");\n+ solrInputDocument.removeField(\"mat_group_label\");\n+ solrInputDocument.removeField(\"mat_group_info\");\n+ solrInputDocument.addField(\"mat_group_label\", matGroupLabel);\n+ solrInputDocument.addField(\"mat_group_info\", matGroupInfo);\n+ updated = true;\n+ } else {\n+ errors.add(String\n+ .format(\"MatGroupLabel not found for unitId: %d, id: %s, matGroupCode: %s\", unitId,\n+ solrDocumentId, matGroupCode));\n+ LOGGER.error(\"MatGroupLabel not found for unitId: {}, id: {}, matGroupCode: {}\", unitId,\n+ solrDocumentId, matGroupCode);\n+ }\n+ }\n+ }\n+ return updated;\n+ }\n+\n+ /**\n+ * Gets totalPages available in solr collection\n+ *\n+ * @param unitId unique identifier for buying organization\n+ * @param solr solrClient for executing solr query\n+ */\n+ private int getTotalPage(int unitId, HttpSolrClient solr) {","path":"src/main/java/com/vroozi/service/SolrDataReindexService.java","position":312,"original_position":312,"commit_id":"00e42328cdbf75362c4573b6e0afb616b6b471a7","original_commit_id":"00e42328cdbf75362c4573b6e0afb616b6b471a7","user":{"login":"mhharis","id":4447405,"node_id":"MDQ6VXNlcjQ0NDc0MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/4447405?v=4","gravatar_id":"","url":"https://api.github.com/users/mhharis","html_url":"https://github.com/mhharis","followers_url":"https://api.github.com/users/mhharis/followers","following_url":"https://api.github.com/users/mhharis/following{/other_user}","gists_url":"https://api.github.com/users/mhharis/gists{/gist_id}","starred_url":"https://api.github.com/users/mhharis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhharis/subscriptions","organizations_url":"https://api.github.com/users/mhharis/orgs","repos_url":"https://api.github.com/users/mhharis/repos","events_url":"https://api.github.com/users/mhharis/events{/privacy}","received_events_url":"https://api.github.com/users/mhharis/received_events","type":"User","site_admin":false},"body":"Should be named as `getTotalNumberOfPages`","created_at":"2018-07-27T13:25:18Z","updated_at":"2018-07-27T13:43:15Z","html_url":"https://github.com/niranjank4523/solr-data-reindex/pull/1#discussion_r205771251","pull_request_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/comments/205771251"},"html":{"href":"https://github.com/niranjank4523/solr-data-reindex/pull/1#discussion_r205771251"},"pull_request":{"href":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/1","id":204376245,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Mzc2MjQ1","html_url":"https://github.com/niranjank4523/solr-data-reindex/pull/1","diff_url":"https://github.com/niranjank4523/solr-data-reindex/pull/1.diff","patch_url":"https://github.com/niranjank4523/solr-data-reindex/pull/1.patch","issue_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues/1","number":1,"state":"open","locked":false,"title":"VZI-32159: Vroozi: Product Category and Supplier Association Indexing Enhancements","user":{"login":"niranjank4523","id":16422886,"node_id":"MDQ6VXNlcjE2NDIyODg2","avatar_url":"https://avatars3.githubusercontent.com/u/16422886?v=4","gravatar_id":"","url":"https://api.github.com/users/niranjank4523","html_url":"https://github.com/niranjank4523","followers_url":"https://api.github.com/users/niranjank4523/followers","following_url":"https://api.github.com/users/niranjank4523/following{/other_user}","gists_url":"https://api.github.com/users/niranjank4523/gists{/gist_id}","starred_url":"https://api.github.com/users/niranjank4523/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niranjank4523/subscriptions","organizations_url":"https://api.github.com/users/niranjank4523/orgs","repos_url":"https://api.github.com/users/niranjank4523/repos","events_url":"https://api.github.com/users/niranjank4523/events{/privacy}","received_events_url":"https://api.github.com/users/niranjank4523/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-27T09:22:24Z","updated_at":"2018-07-27T13:43:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0b5b844efaddc0d6c816667077aa1dbf05c0b5f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/1/commits","review_comments_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/1/comments","review_comment_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues/1/comments","statuses_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/statuses/00e42328cdbf75362c4573b6e0afb616b6b471a7","head":{"label":"niranjank4523:VZI-32159","ref":"VZI-32159","sha":"00e42328cdbf75362c4573b6e0afb616b6b471a7","user":{"login":"niranjank4523","id":16422886,"node_id":"MDQ6VXNlcjE2NDIyODg2","avatar_url":"https://avatars3.githubusercontent.com/u/16422886?v=4","gravatar_id":"","url":"https://api.github.com/users/niranjank4523","html_url":"https://github.com/niranjank4523","followers_url":"https://api.github.com/users/niranjank4523/followers","following_url":"https://api.github.com/users/niranjank4523/following{/other_user}","gists_url":"https://api.github.com/users/niranjank4523/gists{/gist_id}","starred_url":"https://api.github.com/users/niranjank4523/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niranjank4523/subscriptions","organizations_url":"https://api.github.com/users/niranjank4523/orgs","repos_url":"https://api.github.com/users/niranjank4523/repos","events_url":"https://api.github.com/users/niranjank4523/events{/privacy}","received_events_url":"https://api.github.com/users/niranjank4523/received_events","type":"User","site_admin":false},"repo":{"id":123936792,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5MzY3OTI=","name":"solr-data-reindex","full_name":"niranjank4523/solr-data-reindex","owner":{"login":"niranjank4523","id":16422886,"node_id":"MDQ6VXNlcjE2NDIyODg2","avatar_url":"https://avatars3.githubusercontent.com/u/16422886?v=4","gravatar_id":"","url":"https://api.github.com/users/niranjank4523","html_url":"https://github.com/niranjank4523","followers_url":"https://api.github.com/users/niranjank4523/followers","following_url":"https://api.github.com/users/niranjank4523/following{/other_user}","gists_url":"https://api.github.com/users/niranjank4523/gists{/gist_id}","starred_url":"https://api.github.com/users/niranjank4523/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niranjank4523/subscriptions","organizations_url":"https://api.github.com/users/niranjank4523/orgs","repos_url":"https://api.github.com/users/niranjank4523/repos","events_url":"https://api.github.com/users/niranjank4523/events{/privacy}","received_events_url":"https://api.github.com/users/niranjank4523/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niranjank4523/solr-data-reindex","description":null,"fork":false,"url":"https://api.github.com/repos/niranjank4523/solr-data-reindex","forks_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/forks","keys_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/teams","hooks_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/hooks","issue_events_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues/events{/number}","events_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/events","assignees_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/assignees{/user}","branches_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/branches{/branch}","tags_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/tags","blobs_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/refs{/sha}","trees_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/statuses/{sha}","languages_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/languages","stargazers_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/stargazers","contributors_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/contributors","subscribers_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/subscribers","subscription_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/subscription","commits_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/commits{/sha}","git_commits_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/commits{/sha}","comments_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/comments{/number}","issue_comment_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues/comments{/number}","contents_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/contents/{+path}","compare_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/merges","archive_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/downloads","issues_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues{/number}","pulls_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls{/number}","milestones_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/milestones{/number}","notifications_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/labels{/name}","releases_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/releases{/id}","deployments_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/deployments","created_at":"2018-03-05T15:08:41Z","updated_at":"2018-07-27T07:38:52Z","pushed_at":"2018-07-27T11:47:40Z","git_url":"git://github.com/niranjank4523/solr-data-reindex.git","ssh_url":"[email protected]:niranjank4523/solr-data-reindex.git","clone_url":"https://github.com/niranjank4523/solr-data-reindex.git","svn_url":"https://github.com/niranjank4523/solr-data-reindex","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"niranjank4523:integration","ref":"integration","sha":"6d8aa6f15e0d6ba1afe3051993de5e070cf14205","user":{"login":"niranjank4523","id":16422886,"node_id":"MDQ6VXNlcjE2NDIyODg2","avatar_url":"https://avatars3.githubusercontent.com/u/16422886?v=4","gravatar_id":"","url":"https://api.github.com/users/niranjank4523","html_url":"https://github.com/niranjank4523","followers_url":"https://api.github.com/users/niranjank4523/followers","following_url":"https://api.github.com/users/niranjank4523/following{/other_user}","gists_url":"https://api.github.com/users/niranjank4523/gists{/gist_id}","starred_url":"https://api.github.com/users/niranjank4523/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niranjank4523/subscriptions","organizations_url":"https://api.github.com/users/niranjank4523/orgs","repos_url":"https://api.github.com/users/niranjank4523/repos","events_url":"https://api.github.com/users/niranjank4523/events{/privacy}","received_events_url":"https://api.github.com/users/niranjank4523/received_events","type":"User","site_admin":false},"repo":{"id":123936792,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5MzY3OTI=","name":"solr-data-reindex","full_name":"niranjank4523/solr-data-reindex","owner":{"login":"niranjank4523","id":16422886,"node_id":"MDQ6VXNlcjE2NDIyODg2","avatar_url":"https://avatars3.githubusercontent.com/u/16422886?v=4","gravatar_id":"","url":"https://api.github.com/users/niranjank4523","html_url":"https://github.com/niranjank4523","followers_url":"https://api.github.com/users/niranjank4523/followers","following_url":"https://api.github.com/users/niranjank4523/following{/other_user}","gists_url":"https://api.github.com/users/niranjank4523/gists{/gist_id}","starred_url":"https://api.github.com/users/niranjank4523/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niranjank4523/subscriptions","organizations_url":"https://api.github.com/users/niranjank4523/orgs","repos_url":"https://api.github.com/users/niranjank4523/repos","events_url":"https://api.github.com/users/niranjank4523/events{/privacy}","received_events_url":"https://api.github.com/users/niranjank4523/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niranjank4523/solr-data-reindex","description":null,"fork":false,"url":"https://api.github.com/repos/niranjank4523/solr-data-reindex","forks_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/forks","keys_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/teams","hooks_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/hooks","issue_events_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues/events{/number}","events_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/events","assignees_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/assignees{/user}","branches_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/branches{/branch}","tags_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/tags","blobs_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/refs{/sha}","trees_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/statuses/{sha}","languages_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/languages","stargazers_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/stargazers","contributors_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/contributors","subscribers_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/subscribers","subscription_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/subscription","commits_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/commits{/sha}","git_commits_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/git/commits{/sha}","comments_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/comments{/number}","issue_comment_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues/comments{/number}","contents_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/contents/{+path}","compare_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/merges","archive_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/downloads","issues_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues{/number}","pulls_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls{/number}","milestones_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/milestones{/number}","notifications_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/labels{/name}","releases_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/releases{/id}","deployments_url":"https://api.github.com/repos/niranjank4523/solr-data-reindex/deployments","created_at":"2018-03-05T15:08:41Z","updated_at":"2018-07-27T07:38:52Z","pushed_at":"2018-07-27T11:47:40Z","git_url":"git://github.com/niranjank4523/solr-data-reindex.git","ssh_url":"[email protected]:niranjank4523/solr-data-reindex.git","clone_url":"https://github.com/niranjank4523/solr-data-reindex.git","svn_url":"https://github.com/niranjank4523/solr-data-reindex","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/1"},"html":{"href":"https://github.com/niranjank4523/solr-data-reindex/pull/1"},"issue":{"href":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues/1"},"comments":{"href":"https://api.github.com/repos/niranjank4523/solr-data-reindex/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/niranjank4523/solr-data-reindex/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/niranjank4523/solr-data-reindex/statuses/00e42328cdbf75362c4573b6e0afb616b6b471a7"}},"author_association":"OWNER"}} | {
"id": 123936792,
"name": "niranjank4523/solr-data-reindex",
"url": "https://api.github.com/repos/niranjank4523/solr-data-reindex"
} | {
"id": 4447405,
"login": "mhharis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4447405?",
"url": "https://api.github.com/users/mhharis"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-07-27T13:25:18 | 8028679657 | {"actor":{"display_login":"mhharis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/comments/176221111","pull_request_review_id":105886932,"id":176221111,"diff_hunk":"@@ -0,0 +1,48 @@\n+const { exec } = require('child_process');\n+const path = require('path');\n+const { pass, fail } = require('create-jest-runner');\n+\n+class FlowtypeRunner {\n+ constructor(globalConfig) {\n+ this.globalConfig = globalConfig;\n+ }\n+\n+ runTests(tests, watcher, onStart, onResult, onFailure, options) {\n+ this.globalConfig = {};\n+ const start = +new Date();\n+ return new Promise((resolve) => {\n+ exec('flow', { stdio: 'ignore', cwd: process.cwd() }, (err, stdout) => {\n+ const errors = stdout.split('Error');\n+ const errorsPerFile = errors.reduce((previous, current) => {\n+ const firstErrorLine = current.split('\\n')[0];\n+ let fileName = firstErrorLine.split(':')[1];\n+ if (fileName) {\n+ fileName = path.join(process.cwd(), fileName.trim());\n+ const errorMessage = current.substring(current.indexOf('\\n') + 1);\n+ if (!previous[fileName]) {\n+ previous[fileName] = [];\n+ }\n+ previous[fileName].push(errorMessage);\n+ }\n+ return previous;\n+ }, {});\n+ tests.map((t) => {\n+ if (!errorsPerFile[t.path]) {\n+ const testResults = pass({ start, end: +new Date(), test: { path: t.path } });\n+ onResult(t, testResults);\n+ } else {\n+ const testResults = fail({\n+ start,\n+ end: +new Date(),\n+ test: { path: t.path, errorMessage: errorsPerFile[t.path] },\n+ });\n+ onResult(t, testResults);\n+ }\n+ });\n+ resolve();","path":"src/FlowtypeRunner.js","position":42,"original_position":42,"commit_id":"6a20572e9405444432bb4b1d922637a157061f13","original_commit_id":"6a20572e9405444432bb4b1d922637a157061f13","user":{"login":"binygal","id":17698441,"avatar_url":"https://avatars0.githubusercontent.com/u/17698441?v=4","gravatar_id":"","url":"https://api.github.com/users/binygal","html_url":"https://github.com/binygal","followers_url":"https://api.github.com/users/binygal/followers","following_url":"https://api.github.com/users/binygal/following{/other_user}","gists_url":"https://api.github.com/users/binygal/gists{/gist_id}","starred_url":"https://api.github.com/users/binygal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binygal/subscriptions","organizations_url":"https://api.github.com/users/binygal/orgs","repos_url":"https://api.github.com/users/binygal/repos","events_url":"https://api.github.com/users/binygal/events{/privacy}","received_events_url":"https://api.github.com/users/binygal/received_events","type":"User","site_admin":false},"body":"The resolve of the promise tells jest that the runner had finish his work. Calling the callbacks is telling jest that new test result is available. Actually those test results are working like generators where they yield new test results to jest when they are available.","created_at":"2018-03-21T20:07:01Z","updated_at":"2018-03-21T20:07:01Z","html_url":"https://github.com/binygal/jest-runner-flowtype/pull/3#discussion_r176221111","pull_request_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/comments/176221111"},"html":{"href":"https://github.com/binygal/jest-runner-flowtype/pull/3#discussion_r176221111"},"pull_request":{"href":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/3"}},"in_reply_to_id":175876074},"pull_request":{"url":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/3","id":175749075,"html_url":"https://github.com/binygal/jest-runner-flowtype/pull/3","diff_url":"https://github.com/binygal/jest-runner-flowtype/pull/3.diff","patch_url":"https://github.com/binygal/jest-runner-flowtype/pull/3.patch","issue_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues/3","number":3,"state":"open","locked":false,"title":"Change flow check-contents to flow command","user":{"login":"binygal","id":17698441,"avatar_url":"https://avatars0.githubusercontent.com/u/17698441?v=4","gravatar_id":"","url":"https://api.github.com/users/binygal","html_url":"https://github.com/binygal","followers_url":"https://api.github.com/users/binygal/followers","following_url":"https://api.github.com/users/binygal/following{/other_user}","gists_url":"https://api.github.com/users/binygal/gists{/gist_id}","starred_url":"https://api.github.com/users/binygal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binygal/subscriptions","organizations_url":"https://api.github.com/users/binygal/orgs","repos_url":"https://api.github.com/users/binygal/repos","events_url":"https://api.github.com/users/binygal/events{/privacy}","received_events_url":"https://api.github.com/users/binygal/received_events","type":"User","site_admin":false},"body":"As we found that flow check-contents is not suitable to some needs I replaced the flow check-contents to flow. I'm not using the create-jest-runner run on worker ability and I'm using plain Jest runner syntax. \r\nIn the new implementation flow is running once and create the single files result from common data. ","created_at":"2018-03-18T12:39:33Z","updated_at":"2018-03-21T20:07:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"860e593345d6cd25ee4637d500a8cdd263a511ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/3/commits","review_comments_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/3/comments","review_comment_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues/3/comments","statuses_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/statuses/6a20572e9405444432bb4b1d922637a157061f13","head":{"label":"binygal:initial","ref":"initial","sha":"6a20572e9405444432bb4b1d922637a157061f13","user":{"login":"binygal","id":17698441,"avatar_url":"https://avatars0.githubusercontent.com/u/17698441?v=4","gravatar_id":"","url":"https://api.github.com/users/binygal","html_url":"https://github.com/binygal","followers_url":"https://api.github.com/users/binygal/followers","following_url":"https://api.github.com/users/binygal/following{/other_user}","gists_url":"https://api.github.com/users/binygal/gists{/gist_id}","starred_url":"https://api.github.com/users/binygal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binygal/subscriptions","organizations_url":"https://api.github.com/users/binygal/orgs","repos_url":"https://api.github.com/users/binygal/repos","events_url":"https://api.github.com/users/binygal/events{/privacy}","received_events_url":"https://api.github.com/users/binygal/received_events","type":"User","site_admin":false},"repo":{"id":117512756,"name":"jest-runner-flowtype","full_name":"binygal/jest-runner-flowtype","owner":{"login":"binygal","id":17698441,"avatar_url":"https://avatars0.githubusercontent.com/u/17698441?v=4","gravatar_id":"","url":"https://api.github.com/users/binygal","html_url":"https://github.com/binygal","followers_url":"https://api.github.com/users/binygal/followers","following_url":"https://api.github.com/users/binygal/following{/other_user}","gists_url":"https://api.github.com/users/binygal/gists{/gist_id}","starred_url":"https://api.github.com/users/binygal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binygal/subscriptions","organizations_url":"https://api.github.com/users/binygal/orgs","repos_url":"https://api.github.com/users/binygal/repos","events_url":"https://api.github.com/users/binygal/events{/privacy}","received_events_url":"https://api.github.com/users/binygal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binygal/jest-runner-flowtype","description":"Jest runner for running flowtype tests using jest as a platform","fork":false,"url":"https://api.github.com/repos/binygal/jest-runner-flowtype","forks_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/forks","keys_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/teams","hooks_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/hooks","issue_events_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues/events{/number}","events_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/events","assignees_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/assignees{/user}","branches_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/branches{/branch}","tags_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/tags","blobs_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/refs{/sha}","trees_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/statuses/{sha}","languages_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/languages","stargazers_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/stargazers","contributors_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/contributors","subscribers_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/subscribers","subscription_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/subscription","commits_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/commits{/sha}","git_commits_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/commits{/sha}","comments_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/comments{/number}","issue_comment_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues/comments{/number}","contents_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/contents/{+path}","compare_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/merges","archive_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/downloads","issues_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues{/number}","pulls_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls{/number}","milestones_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/milestones{/number}","notifications_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/labels{/name}","releases_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/releases{/id}","deployments_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/deployments","created_at":"2018-01-15T07:37:41Z","updated_at":"2018-03-21T15:09:48Z","pushed_at":"2018-03-18T12:39:33Z","git_url":"git://github.com/binygal/jest-runner-flowtype.git","ssh_url":"[email protected]:binygal/jest-runner-flowtype.git","clone_url":"https://github.com/binygal/jest-runner-flowtype.git","svn_url":"https://github.com/binygal/jest-runner-flowtype","homepage":null,"size":94,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":14,"default_branch":"initial"}},"base":{"label":"binygal:master","ref":"master","sha":"7be09cb42f19472762a7b6d50d9d0f144b071871","user":{"login":"binygal","id":17698441,"avatar_url":"https://avatars0.githubusercontent.com/u/17698441?v=4","gravatar_id":"","url":"https://api.github.com/users/binygal","html_url":"https://github.com/binygal","followers_url":"https://api.github.com/users/binygal/followers","following_url":"https://api.github.com/users/binygal/following{/other_user}","gists_url":"https://api.github.com/users/binygal/gists{/gist_id}","starred_url":"https://api.github.com/users/binygal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binygal/subscriptions","organizations_url":"https://api.github.com/users/binygal/orgs","repos_url":"https://api.github.com/users/binygal/repos","events_url":"https://api.github.com/users/binygal/events{/privacy}","received_events_url":"https://api.github.com/users/binygal/received_events","type":"User","site_admin":false},"repo":{"id":117512756,"name":"jest-runner-flowtype","full_name":"binygal/jest-runner-flowtype","owner":{"login":"binygal","id":17698441,"avatar_url":"https://avatars0.githubusercontent.com/u/17698441?v=4","gravatar_id":"","url":"https://api.github.com/users/binygal","html_url":"https://github.com/binygal","followers_url":"https://api.github.com/users/binygal/followers","following_url":"https://api.github.com/users/binygal/following{/other_user}","gists_url":"https://api.github.com/users/binygal/gists{/gist_id}","starred_url":"https://api.github.com/users/binygal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binygal/subscriptions","organizations_url":"https://api.github.com/users/binygal/orgs","repos_url":"https://api.github.com/users/binygal/repos","events_url":"https://api.github.com/users/binygal/events{/privacy}","received_events_url":"https://api.github.com/users/binygal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binygal/jest-runner-flowtype","description":"Jest runner for running flowtype tests using jest as a platform","fork":false,"url":"https://api.github.com/repos/binygal/jest-runner-flowtype","forks_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/forks","keys_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/teams","hooks_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/hooks","issue_events_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues/events{/number}","events_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/events","assignees_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/assignees{/user}","branches_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/branches{/branch}","tags_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/tags","blobs_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/refs{/sha}","trees_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/statuses/{sha}","languages_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/languages","stargazers_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/stargazers","contributors_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/contributors","subscribers_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/subscribers","subscription_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/subscription","commits_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/commits{/sha}","git_commits_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/git/commits{/sha}","comments_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/comments{/number}","issue_comment_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues/comments{/number}","contents_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/contents/{+path}","compare_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/merges","archive_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/downloads","issues_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues{/number}","pulls_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls{/number}","milestones_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/milestones{/number}","notifications_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/labels{/name}","releases_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/releases{/id}","deployments_url":"https://api.github.com/repos/binygal/jest-runner-flowtype/deployments","created_at":"2018-01-15T07:37:41Z","updated_at":"2018-03-21T15:09:48Z","pushed_at":"2018-03-18T12:39:33Z","git_url":"git://github.com/binygal/jest-runner-flowtype.git","ssh_url":"[email protected]:binygal/jest-runner-flowtype.git","clone_url":"https://github.com/binygal/jest-runner-flowtype.git","svn_url":"https://github.com/binygal/jest-runner-flowtype","homepage":null,"size":94,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":14,"default_branch":"initial"}},"_links":{"self":{"href":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/3"},"html":{"href":"https://github.com/binygal/jest-runner-flowtype/pull/3"},"issue":{"href":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues/3"},"comments":{"href":"https://api.github.com/repos/binygal/jest-runner-flowtype/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binygal/jest-runner-flowtype/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/binygal/jest-runner-flowtype/statuses/6a20572e9405444432bb4b1d922637a157061f13"}},"author_association":"OWNER"}} | {
"id": 117512756,
"name": "binygal/jest-runner-flowtype",
"url": "https://api.github.com/repos/binygal/jest-runner-flowtype"
} | {
"id": 17698441,
"login": "binygal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17698441?",
"url": "https://api.github.com/users/binygal"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-03-21T20:07:01 | 7415248327 | {"actor":{"display_login":"binygal"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/comments/202472132","pull_request_review_id":137189098,"id":202472132,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ3MjEzMg==","diff_hunk":"@@ -40,8 +40,8 @@ const createTagPages = (createPage, edges) => {\n });\n };\n \n-exports.createPages = ({ boundActionCreators, graphql }) => {\n- const { createPage } = boundActionCreators;\n+exports.createPages = ({ actions, graphql }) => {\n+ const { createPage } = actions;","path":"gatsby-node.js","position":7,"original_position":7,"commit_id":"d5366bc96eaacd919675dcfa6ed223553abbe73e","original_commit_id":"d5366bc96eaacd919675dcfa6ed223553abbe73e","user":{"login":"DSchau","id":3924690,"node_id":"MDQ6VXNlcjM5MjQ2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3924690?v=4","gravatar_id":"","url":"https://api.github.com/users/DSchau","html_url":"https://github.com/DSchau","followers_url":"https://api.github.com/users/DSchau/followers","following_url":"https://api.github.com/users/DSchau/following{/other_user}","gists_url":"https://api.github.com/users/DSchau/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchau/subscriptions","organizations_url":"https://api.github.com/users/DSchau/orgs","repos_url":"https://api.github.com/users/DSchau/repos","events_url":"https://api.github.com/users/DSchau/events{/privacy}","received_events_url":"https://api.github.com/users/DSchau/received_events","type":"User","site_admin":false},"body":"`boundActionCreators` are now `actions`\r\n\r\n_Really_ nice thing is that Gatsby CLI warned of deprecated/changed key names.","created_at":"2018-07-13T21:03:07Z","updated_at":"2018-07-13T21:07:54Z","html_url":"https://github.com/DSchau/gatsby-blog-starter-kit/pull/35#discussion_r202472132","pull_request_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/35","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/comments/202472132"},"html":{"href":"https://github.com/DSchau/gatsby-blog-starter-kit/pull/35#discussion_r202472132"},"pull_request":{"href":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/35","id":201399635,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzk5NjM1","html_url":"https://github.com/DSchau/gatsby-blog-starter-kit/pull/35","diff_url":"https://github.com/DSchau/gatsby-blog-starter-kit/pull/35.diff","patch_url":"https://github.com/DSchau/gatsby-blog-starter-kit/pull/35.patch","issue_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues/35","number":35,"state":"open","locked":false,"title":"feat: upgrade to gatsby v2","user":{"login":"DSchau","id":3924690,"node_id":"MDQ6VXNlcjM5MjQ2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3924690?v=4","gravatar_id":"","url":"https://api.github.com/users/DSchau","html_url":"https://github.com/DSchau","followers_url":"https://api.github.com/users/DSchau/followers","following_url":"https://api.github.com/users/DSchau/following{/other_user}","gists_url":"https://api.github.com/users/DSchau/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchau/subscriptions","organizations_url":"https://api.github.com/users/DSchau/orgs","repos_url":"https://api.github.com/users/DSchau/repos","events_url":"https://api.github.com/users/DSchau/events{/privacy}","received_events_url":"https://api.github.com/users/DSchau/received_events","type":"User","site_admin":false},"body":"This PR serves as a simple/fairly clean upgrade from Gatsby v1 to Gatsby v2 (currently in beta).\r\n\r\nIt was pretty simple :)","created_at":"2018-07-13T21:02:11Z","updated_at":"2018-07-13T21:07:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72b39d3be7698c9fdde1b5eec98f5c9d3352da94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/35/commits","review_comments_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/35/comments","review_comment_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues/35/comments","statuses_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/statuses/d5366bc96eaacd919675dcfa6ed223553abbe73e","head":{"label":"DSchau:v2","ref":"v2","sha":"d5366bc96eaacd919675dcfa6ed223553abbe73e","user":{"login":"DSchau","id":3924690,"node_id":"MDQ6VXNlcjM5MjQ2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3924690?v=4","gravatar_id":"","url":"https://api.github.com/users/DSchau","html_url":"https://github.com/DSchau","followers_url":"https://api.github.com/users/DSchau/followers","following_url":"https://api.github.com/users/DSchau/following{/other_user}","gists_url":"https://api.github.com/users/DSchau/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchau/subscriptions","organizations_url":"https://api.github.com/users/DSchau/orgs","repos_url":"https://api.github.com/users/DSchau/repos","events_url":"https://api.github.com/users/DSchau/events{/privacy}","received_events_url":"https://api.github.com/users/DSchau/received_events","type":"User","site_admin":false},"repo":{"id":97124794,"node_id":"MDEwOlJlcG9zaXRvcnk5NzEyNDc5NA==","name":"gatsby-blog-starter-kit","full_name":"DSchau/gatsby-blog-starter-kit","owner":{"login":"DSchau","id":3924690,"node_id":"MDQ6VXNlcjM5MjQ2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3924690?v=4","gravatar_id":"","url":"https://api.github.com/users/DSchau","html_url":"https://github.com/DSchau","followers_url":"https://api.github.com/users/DSchau/followers","following_url":"https://api.github.com/users/DSchau/following{/other_user}","gists_url":"https://api.github.com/users/DSchau/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchau/subscriptions","organizations_url":"https://api.github.com/users/DSchau/orgs","repos_url":"https://api.github.com/users/DSchau/repos","events_url":"https://api.github.com/users/DSchau/events{/privacy}","received_events_url":"https://api.github.com/users/DSchau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DSchau/gatsby-blog-starter-kit","description":"A simple starter kit for a static blog created with Gatsby","fork":false,"url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit","forks_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/forks","keys_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/teams","hooks_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/events","assignees_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/tags","blobs_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/languages","stargazers_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/subscription","commits_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/merges","archive_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/downloads","issues_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/deployments","created_at":"2017-07-13T13:19:51Z","updated_at":"2018-07-11T20:30:01Z","pushed_at":"2018-07-13T21:02:12Z","git_url":"git://github.com/DSchau/gatsby-blog-starter-kit.git","ssh_url":"[email protected]:DSchau/gatsby-blog-starter-kit.git","clone_url":"https://github.com/DSchau/gatsby-blog-starter-kit.git","svn_url":"https://github.com/DSchau/gatsby-blog-starter-kit","homepage":"https://gatsby-blog-starter-kit.netlify.com/","size":28365,"stargazers_count":94,"watchers_count":94,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":7,"watchers":94,"default_branch":"master"}},"base":{"label":"DSchau:master","ref":"master","sha":"b27f464011084a0348cb7393dc1603fa625b89e0","user":{"login":"DSchau","id":3924690,"node_id":"MDQ6VXNlcjM5MjQ2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3924690?v=4","gravatar_id":"","url":"https://api.github.com/users/DSchau","html_url":"https://github.com/DSchau","followers_url":"https://api.github.com/users/DSchau/followers","following_url":"https://api.github.com/users/DSchau/following{/other_user}","gists_url":"https://api.github.com/users/DSchau/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchau/subscriptions","organizations_url":"https://api.github.com/users/DSchau/orgs","repos_url":"https://api.github.com/users/DSchau/repos","events_url":"https://api.github.com/users/DSchau/events{/privacy}","received_events_url":"https://api.github.com/users/DSchau/received_events","type":"User","site_admin":false},"repo":{"id":97124794,"node_id":"MDEwOlJlcG9zaXRvcnk5NzEyNDc5NA==","name":"gatsby-blog-starter-kit","full_name":"DSchau/gatsby-blog-starter-kit","owner":{"login":"DSchau","id":3924690,"node_id":"MDQ6VXNlcjM5MjQ2OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3924690?v=4","gravatar_id":"","url":"https://api.github.com/users/DSchau","html_url":"https://github.com/DSchau","followers_url":"https://api.github.com/users/DSchau/followers","following_url":"https://api.github.com/users/DSchau/following{/other_user}","gists_url":"https://api.github.com/users/DSchau/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchau/subscriptions","organizations_url":"https://api.github.com/users/DSchau/orgs","repos_url":"https://api.github.com/users/DSchau/repos","events_url":"https://api.github.com/users/DSchau/events{/privacy}","received_events_url":"https://api.github.com/users/DSchau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DSchau/gatsby-blog-starter-kit","description":"A simple starter kit for a static blog created with Gatsby","fork":false,"url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit","forks_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/forks","keys_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/teams","hooks_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/events","assignees_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/tags","blobs_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/languages","stargazers_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/subscription","commits_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/merges","archive_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/downloads","issues_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/deployments","created_at":"2017-07-13T13:19:51Z","updated_at":"2018-07-11T20:30:01Z","pushed_at":"2018-07-13T21:02:12Z","git_url":"git://github.com/DSchau/gatsby-blog-starter-kit.git","ssh_url":"[email protected]:DSchau/gatsby-blog-starter-kit.git","clone_url":"https://github.com/DSchau/gatsby-blog-starter-kit.git","svn_url":"https://github.com/DSchau/gatsby-blog-starter-kit","homepage":"https://gatsby-blog-starter-kit.netlify.com/","size":28365,"stargazers_count":94,"watchers_count":94,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":7,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/35"},"html":{"href":"https://github.com/DSchau/gatsby-blog-starter-kit/pull/35"},"issue":{"href":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues/35"},"comments":{"href":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/DSchau/gatsby-blog-starter-kit/statuses/d5366bc96eaacd919675dcfa6ed223553abbe73e"}},"author_association":"OWNER"}} | {
"id": 97124794,
"name": "DSchau/gatsby-blog-starter-kit",
"url": "https://api.github.com/repos/DSchau/gatsby-blog-starter-kit"
} | {
"id": 3924690,
"login": "DSchau",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3924690?",
"url": "https://api.github.com/users/DSchau"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-07-13T21:03:07 | 7964361120 | {"actor":{"display_login":"DSchau"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/seunzone/weConnect/pulls/comments/189474663","pull_request_review_id":121659562,"id":189474663,"diff_hunk":"@@ -0,0 +1,11 @@\n+import { GET_ALL_BUSINESS } from '../actions/actionType';","path":"client/reducers/allBusinessReducer.js","position":1,"original_position":1,"commit_id":"3befcabb762ba2326021cfba2d798927afd1abfe","original_commit_id":"3befcabb762ba2326021cfba2d798927afd1abfe","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Unable to resolve path to module '../actions/actionType' import/no-unresolved<br>Missing file extension for \"../actions/actionType\" import/extensions","created_at":"2018-05-20T23:51:15Z","updated_at":"2018-05-20T23:51:17Z","html_url":"https://github.com/seunzone/weConnect/pull/18#discussion_r189474663","pull_request_url":"https://api.github.com/repos/seunzone/weConnect/pulls/18","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/seunzone/weConnect/pulls/comments/189474663"},"html":{"href":"https://github.com/seunzone/weConnect/pull/18#discussion_r189474663"},"pull_request":{"href":"https://api.github.com/repos/seunzone/weConnect/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/seunzone/weConnect/pulls/18","id":189259555,"html_url":"https://github.com/seunzone/weConnect/pull/18","diff_url":"https://github.com/seunzone/weConnect/pull/18.diff","patch_url":"https://github.com/seunzone/weConnect/pull/18.patch","issue_url":"https://api.github.com/repos/seunzone/weConnect/issues/18","number":18,"state":"closed","locked":false,"title":"Ft client create business","user":{"login":"seunzone","id":22764463,"avatar_url":"https://avatars1.githubusercontent.com/u/22764463?v=4","gravatar_id":"","url":"https://api.github.com/users/seunzone","html_url":"https://github.com/seunzone","followers_url":"https://api.github.com/users/seunzone/followers","following_url":"https://api.github.com/users/seunzone/following{/other_user}","gists_url":"https://api.github.com/users/seunzone/gists{/gist_id}","starred_url":"https://api.github.com/users/seunzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seunzone/subscriptions","organizations_url":"https://api.github.com/users/seunzone/orgs","repos_url":"https://api.github.com/users/seunzone/repos","events_url":"https://api.github.com/users/seunzone/events{/privacy}","received_events_url":"https://api.github.com/users/seunzone/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nThis PR has been raised to merge the latest changes to the develop branch\r\n\r\n#### How should this be manually tested?\r\nStart app by running `npm run dev`","created_at":"2018-05-20T23:50:46Z","updated_at":"2018-05-20T23:51:17Z","closed_at":"2018-05-20T23:51:13Z","merged_at":"2018-05-20T23:51:13Z","merge_commit_sha":"599a5d4c69aa73948ae64b5efb3c049111356569","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/seunzone/weConnect/pulls/18/commits","review_comments_url":"https://api.github.com/repos/seunzone/weConnect/pulls/18/comments","review_comment_url":"https://api.github.com/repos/seunzone/weConnect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seunzone/weConnect/issues/18/comments","statuses_url":"https://api.github.com/repos/seunzone/weConnect/statuses/3befcabb762ba2326021cfba2d798927afd1abfe","head":{"label":"seunzone:ft-client-create-business","ref":"ft-client-create-business","sha":"3befcabb762ba2326021cfba2d798927afd1abfe","user":{"login":"seunzone","id":22764463,"avatar_url":"https://avatars1.githubusercontent.com/u/22764463?v=4","gravatar_id":"","url":"https://api.github.com/users/seunzone","html_url":"https://github.com/seunzone","followers_url":"https://api.github.com/users/seunzone/followers","following_url":"https://api.github.com/users/seunzone/following{/other_user}","gists_url":"https://api.github.com/users/seunzone/gists{/gist_id}","starred_url":"https://api.github.com/users/seunzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seunzone/subscriptions","organizations_url":"https://api.github.com/users/seunzone/orgs","repos_url":"https://api.github.com/users/seunzone/repos","events_url":"https://api.github.com/users/seunzone/events{/privacy}","received_events_url":"https://api.github.com/users/seunzone/received_events","type":"User","site_admin":false},"repo":{"id":122873793,"name":"weConnect","full_name":"seunzone/weConnect","owner":{"login":"seunzone","id":22764463,"avatar_url":"https://avatars1.githubusercontent.com/u/22764463?v=4","gravatar_id":"","url":"https://api.github.com/users/seunzone","html_url":"https://github.com/seunzone","followers_url":"https://api.github.com/users/seunzone/followers","following_url":"https://api.github.com/users/seunzone/following{/other_user}","gists_url":"https://api.github.com/users/seunzone/gists{/gist_id}","starred_url":"https://api.github.com/users/seunzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seunzone/subscriptions","organizations_url":"https://api.github.com/users/seunzone/orgs","repos_url":"https://api.github.com/users/seunzone/repos","events_url":"https://api.github.com/users/seunzone/events{/privacy}","received_events_url":"https://api.github.com/users/seunzone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seunzone/weConnect","description":"WeConnect is platform that allows customers to review businesses that they have interacted with","fork":false,"url":"https://api.github.com/repos/seunzone/weConnect","forks_url":"https://api.github.com/repos/seunzone/weConnect/forks","keys_url":"https://api.github.com/repos/seunzone/weConnect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seunzone/weConnect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seunzone/weConnect/teams","hooks_url":"https://api.github.com/repos/seunzone/weConnect/hooks","issue_events_url":"https://api.github.com/repos/seunzone/weConnect/issues/events{/number}","events_url":"https://api.github.com/repos/seunzone/weConnect/events","assignees_url":"https://api.github.com/repos/seunzone/weConnect/assignees{/user}","branches_url":"https://api.github.com/repos/seunzone/weConnect/branches{/branch}","tags_url":"https://api.github.com/repos/seunzone/weConnect/tags","blobs_url":"https://api.github.com/repos/seunzone/weConnect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seunzone/weConnect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seunzone/weConnect/git/refs{/sha}","trees_url":"https://api.github.com/repos/seunzone/weConnect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seunzone/weConnect/statuses/{sha}","languages_url":"https://api.github.com/repos/seunzone/weConnect/languages","stargazers_url":"https://api.github.com/repos/seunzone/weConnect/stargazers","contributors_url":"https://api.github.com/repos/seunzone/weConnect/contributors","subscribers_url":"https://api.github.com/repos/seunzone/weConnect/subscribers","subscription_url":"https://api.github.com/repos/seunzone/weConnect/subscription","commits_url":"https://api.github.com/repos/seunzone/weConnect/commits{/sha}","git_commits_url":"https://api.github.com/repos/seunzone/weConnect/git/commits{/sha}","comments_url":"https://api.github.com/repos/seunzone/weConnect/comments{/number}","issue_comment_url":"https://api.github.com/repos/seunzone/weConnect/issues/comments{/number}","contents_url":"https://api.github.com/repos/seunzone/weConnect/contents/{+path}","compare_url":"https://api.github.com/repos/seunzone/weConnect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seunzone/weConnect/merges","archive_url":"https://api.github.com/repos/seunzone/weConnect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seunzone/weConnect/downloads","issues_url":"https://api.github.com/repos/seunzone/weConnect/issues{/number}","pulls_url":"https://api.github.com/repos/seunzone/weConnect/pulls{/number}","milestones_url":"https://api.github.com/repos/seunzone/weConnect/milestones{/number}","notifications_url":"https://api.github.com/repos/seunzone/weConnect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seunzone/weConnect/labels{/name}","releases_url":"https://api.github.com/repos/seunzone/weConnect/releases{/id}","deployments_url":"https://api.github.com/repos/seunzone/weConnect/deployments","created_at":"2018-02-25T20:29:43Z","updated_at":"2018-05-20T23:51:16Z","pushed_at":"2018-05-20T23:51:13Z","git_url":"git://github.com/seunzone/weConnect.git","ssh_url":"[email protected]:seunzone/weConnect.git","clone_url":"https://github.com/seunzone/weConnect.git","svn_url":"https://github.com/seunzone/weConnect","homepage":"","size":15680,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"seunzone:develop","ref":"develop","sha":"22754d36ca1b1d109d9aa850849923baa7fcebcf","user":{"login":"seunzone","id":22764463,"avatar_url":"https://avatars1.githubusercontent.com/u/22764463?v=4","gravatar_id":"","url":"https://api.github.com/users/seunzone","html_url":"https://github.com/seunzone","followers_url":"https://api.github.com/users/seunzone/followers","following_url":"https://api.github.com/users/seunzone/following{/other_user}","gists_url":"https://api.github.com/users/seunzone/gists{/gist_id}","starred_url":"https://api.github.com/users/seunzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seunzone/subscriptions","organizations_url":"https://api.github.com/users/seunzone/orgs","repos_url":"https://api.github.com/users/seunzone/repos","events_url":"https://api.github.com/users/seunzone/events{/privacy}","received_events_url":"https://api.github.com/users/seunzone/received_events","type":"User","site_admin":false},"repo":{"id":122873793,"name":"weConnect","full_name":"seunzone/weConnect","owner":{"login":"seunzone","id":22764463,"avatar_url":"https://avatars1.githubusercontent.com/u/22764463?v=4","gravatar_id":"","url":"https://api.github.com/users/seunzone","html_url":"https://github.com/seunzone","followers_url":"https://api.github.com/users/seunzone/followers","following_url":"https://api.github.com/users/seunzone/following{/other_user}","gists_url":"https://api.github.com/users/seunzone/gists{/gist_id}","starred_url":"https://api.github.com/users/seunzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seunzone/subscriptions","organizations_url":"https://api.github.com/users/seunzone/orgs","repos_url":"https://api.github.com/users/seunzone/repos","events_url":"https://api.github.com/users/seunzone/events{/privacy}","received_events_url":"https://api.github.com/users/seunzone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seunzone/weConnect","description":"WeConnect is platform that allows customers to review businesses that they have interacted with","fork":false,"url":"https://api.github.com/repos/seunzone/weConnect","forks_url":"https://api.github.com/repos/seunzone/weConnect/forks","keys_url":"https://api.github.com/repos/seunzone/weConnect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seunzone/weConnect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seunzone/weConnect/teams","hooks_url":"https://api.github.com/repos/seunzone/weConnect/hooks","issue_events_url":"https://api.github.com/repos/seunzone/weConnect/issues/events{/number}","events_url":"https://api.github.com/repos/seunzone/weConnect/events","assignees_url":"https://api.github.com/repos/seunzone/weConnect/assignees{/user}","branches_url":"https://api.github.com/repos/seunzone/weConnect/branches{/branch}","tags_url":"https://api.github.com/repos/seunzone/weConnect/tags","blobs_url":"https://api.github.com/repos/seunzone/weConnect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seunzone/weConnect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seunzone/weConnect/git/refs{/sha}","trees_url":"https://api.github.com/repos/seunzone/weConnect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seunzone/weConnect/statuses/{sha}","languages_url":"https://api.github.com/repos/seunzone/weConnect/languages","stargazers_url":"https://api.github.com/repos/seunzone/weConnect/stargazers","contributors_url":"https://api.github.com/repos/seunzone/weConnect/contributors","subscribers_url":"https://api.github.com/repos/seunzone/weConnect/subscribers","subscription_url":"https://api.github.com/repos/seunzone/weConnect/subscription","commits_url":"https://api.github.com/repos/seunzone/weConnect/commits{/sha}","git_commits_url":"https://api.github.com/repos/seunzone/weConnect/git/commits{/sha}","comments_url":"https://api.github.com/repos/seunzone/weConnect/comments{/number}","issue_comment_url":"https://api.github.com/repos/seunzone/weConnect/issues/comments{/number}","contents_url":"https://api.github.com/repos/seunzone/weConnect/contents/{+path}","compare_url":"https://api.github.com/repos/seunzone/weConnect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seunzone/weConnect/merges","archive_url":"https://api.github.com/repos/seunzone/weConnect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seunzone/weConnect/downloads","issues_url":"https://api.github.com/repos/seunzone/weConnect/issues{/number}","pulls_url":"https://api.github.com/repos/seunzone/weConnect/pulls{/number}","milestones_url":"https://api.github.com/repos/seunzone/weConnect/milestones{/number}","notifications_url":"https://api.github.com/repos/seunzone/weConnect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seunzone/weConnect/labels{/name}","releases_url":"https://api.github.com/repos/seunzone/weConnect/releases{/id}","deployments_url":"https://api.github.com/repos/seunzone/weConnect/deployments","created_at":"2018-02-25T20:29:43Z","updated_at":"2018-05-20T23:51:16Z","pushed_at":"2018-05-20T23:51:13Z","git_url":"git://github.com/seunzone/weConnect.git","ssh_url":"[email protected]:seunzone/weConnect.git","clone_url":"https://github.com/seunzone/weConnect.git","svn_url":"https://github.com/seunzone/weConnect","homepage":"","size":15680,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/seunzone/weConnect/pulls/18"},"html":{"href":"https://github.com/seunzone/weConnect/pull/18"},"issue":{"href":"https://api.github.com/repos/seunzone/weConnect/issues/18"},"comments":{"href":"https://api.github.com/repos/seunzone/weConnect/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/seunzone/weConnect/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/seunzone/weConnect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seunzone/weConnect/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/seunzone/weConnect/statuses/3befcabb762ba2326021cfba2d798927afd1abfe"}},"author_association":"OWNER"}} | {
"id": 122873793,
"name": "seunzone/weConnect",
"url": "https://api.github.com/repos/seunzone/weConnect"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-05-20T23:51:15 | 7702167289 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/abhinaykrupa/1s/pulls/comments/195463636","pull_request_review_id":128807581,"id":195463636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTQ2MzYzNg==","diff_hunk":"@@ -4,17 +4,17 @@\n /**\n * SMTP Config Settings\n */\n- $config['protocol'] = SMTP_PROTOCOL;\n- $config['charset'] = SMTP_CHARSET;\n- $config['mailtype'] = SMTP_MAILTYPE;\n- $config['newline'] = SMTP_NEWLINE;\n+ //$config['protocol'] = SMTP_PROTOCOL;\n+ //$config['charset'] = SMTP_CHARSET;\n+ //$config['mailtype'] = SMTP_MAILTYPE;\n+ //$config['newline'] = SMTP_NEWLINE;\n \n // $config['smtp_host'] = SMTP_HOST_MXLOGIN;\n // $config['smtp_port'] = SMTP_PORT_MXLOGIN;\n // $config['smtp_user'] = SMTP_USER_MXLOGIN; \n // $config['smtp_pass'] = SMTP_PASS_MXLOGIN;\n \n- $config['smtp_host'] = SMTP_HOST_AWS_SES;\n- $config['smtp_port'] = SMTP_PORT_AWS_SES;\n- $config['smtp_user'] = SMTP_USER_AWS_SES; \n- $config['smtp_pass'] = SMTP_PASS_AWS_SES;\n\\ No newline at end of file\n+ //$config['smtp_host'] = SMTP_HOST_AWS_SES;\n+ //$config['smtp_port'] = SMTP_PORT_AWS_SES;\n+ //$config['smtp_user'] = SMTP_USER_AWS_SES; \n+ //$config['smtp_pass'] = SMTP_PASS_AWS_SES;","path":"application/config/email.php","position":26,"original_position":26,"commit_id":"0d4b2533857e6816c97d5ffd042388251012095c","original_commit_id":"0d4b2533857e6816c97d5ffd042388251012095c","user":{"login":"abhinaykrupa","id":2201321,"node_id":"MDQ6VXNlcjIyMDEzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2201321?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinaykrupa","html_url":"https://github.com/abhinaykrupa","followers_url":"https://api.github.com/users/abhinaykrupa/followers","following_url":"https://api.github.com/users/abhinaykrupa/following{/other_user}","gists_url":"https://api.github.com/users/abhinaykrupa/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinaykrupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinaykrupa/subscriptions","organizations_url":"https://api.github.com/users/abhinaykrupa/orgs","repos_url":"https://api.github.com/users/abhinaykrupa/repos","events_url":"https://api.github.com/users/abhinaykrupa/events{/privacy}","received_events_url":"https://api.github.com/users/abhinaykrupa/received_events","type":"User","site_admin":false},"body":"we need one default stmp always set. set mxlogin as default","created_at":"2018-06-14T15:17:01Z","updated_at":"2018-06-14T15:23:04Z","html_url":"https://github.com/abhinaykrupa/1s/pull/38#discussion_r195463636","pull_request_url":"https://api.github.com/repos/abhinaykrupa/1s/pulls/38","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/abhinaykrupa/1s/pulls/comments/195463636"},"html":{"href":"https://github.com/abhinaykrupa/1s/pull/38#discussion_r195463636"},"pull_request":{"href":"https://api.github.com/repos/abhinaykrupa/1s/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/abhinaykrupa/1s/pulls/38","id":194901331,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTAxMzMx","html_url":"https://github.com/abhinaykrupa/1s/pull/38","diff_url":"https://github.com/abhinaykrupa/1s/pull/38.diff","patch_url":"https://github.com/abhinaykrupa/1s/pull/38.patch","issue_url":"https://api.github.com/repos/abhinaykrupa/1s/issues/38","number":38,"state":"open","locked":false,"title":"Ses","user":{"login":"sureshpegadapelli","id":36496389,"node_id":"MDQ6VXNlcjM2NDk2Mzg5","avatar_url":"https://avatars0.githubusercontent.com/u/36496389?v=4","gravatar_id":"","url":"https://api.github.com/users/sureshpegadapelli","html_url":"https://github.com/sureshpegadapelli","followers_url":"https://api.github.com/users/sureshpegadapelli/followers","following_url":"https://api.github.com/users/sureshpegadapelli/following{/other_user}","gists_url":"https://api.github.com/users/sureshpegadapelli/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshpegadapelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshpegadapelli/subscriptions","organizations_url":"https://api.github.com/users/sureshpegadapelli/orgs","repos_url":"https://api.github.com/users/sureshpegadapelli/repos","events_url":"https://api.github.com/users/sureshpegadapelli/events{/privacy}","received_events_url":"https://api.github.com/users/sureshpegadapelli/received_events","type":"User","site_admin":false},"body":"Multiple smtp servers","created_at":"2018-06-14T13:52:56Z","updated_at":"2018-06-14T15:23:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"abhinaykrupa","id":2201321,"node_id":"MDQ6VXNlcjIyMDEzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2201321?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinaykrupa","html_url":"https://github.com/abhinaykrupa","followers_url":"https://api.github.com/users/abhinaykrupa/followers","following_url":"https://api.github.com/users/abhinaykrupa/following{/other_user}","gists_url":"https://api.github.com/users/abhinaykrupa/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinaykrupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinaykrupa/subscriptions","organizations_url":"https://api.github.com/users/abhinaykrupa/orgs","repos_url":"https://api.github.com/users/abhinaykrupa/repos","events_url":"https://api.github.com/users/abhinaykrupa/events{/privacy}","received_events_url":"https://api.github.com/users/abhinaykrupa/received_events","type":"User","site_admin":false},"assignees":[{"login":"abhinaykrupa","id":2201321,"node_id":"MDQ6VXNlcjIyMDEzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2201321?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinaykrupa","html_url":"https://github.com/abhinaykrupa","followers_url":"https://api.github.com/users/abhinaykrupa/followers","following_url":"https://api.github.com/users/abhinaykrupa/following{/other_user}","gists_url":"https://api.github.com/users/abhinaykrupa/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinaykrupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinaykrupa/subscriptions","organizations_url":"https://api.github.com/users/abhinaykrupa/orgs","repos_url":"https://api.github.com/users/abhinaykrupa/repos","events_url":"https://api.github.com/users/abhinaykrupa/events{/privacy}","received_events_url":"https://api.github.com/users/abhinaykrupa/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/abhinaykrupa/1s/pulls/38/commits","review_comments_url":"https://api.github.com/repos/abhinaykrupa/1s/pulls/38/comments","review_comment_url":"https://api.github.com/repos/abhinaykrupa/1s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abhinaykrupa/1s/issues/38/comments","statuses_url":"https://api.github.com/repos/abhinaykrupa/1s/statuses/0d4b2533857e6816c97d5ffd042388251012095c","head":{"label":"abhinaykrupa:ses","ref":"ses","sha":"0d4b2533857e6816c97d5ffd042388251012095c","user":{"login":"abhinaykrupa","id":2201321,"node_id":"MDQ6VXNlcjIyMDEzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2201321?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinaykrupa","html_url":"https://github.com/abhinaykrupa","followers_url":"https://api.github.com/users/abhinaykrupa/followers","following_url":"https://api.github.com/users/abhinaykrupa/following{/other_user}","gists_url":"https://api.github.com/users/abhinaykrupa/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinaykrupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinaykrupa/subscriptions","organizations_url":"https://api.github.com/users/abhinaykrupa/orgs","repos_url":"https://api.github.com/users/abhinaykrupa/repos","events_url":"https://api.github.com/users/abhinaykrupa/events{/privacy}","received_events_url":"https://api.github.com/users/abhinaykrupa/received_events","type":"User","site_admin":false},"repo":{"id":51018802,"node_id":"MDEwOlJlcG9zaXRvcnk1MTAxODgwMg==","name":"1s","full_name":"abhinaykrupa/1s","owner":{"login":"abhinaykrupa","id":2201321,"node_id":"MDQ6VXNlcjIyMDEzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2201321?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinaykrupa","html_url":"https://github.com/abhinaykrupa","followers_url":"https://api.github.com/users/abhinaykrupa/followers","following_url":"https://api.github.com/users/abhinaykrupa/following{/other_user}","gists_url":"https://api.github.com/users/abhinaykrupa/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinaykrupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinaykrupa/subscriptions","organizations_url":"https://api.github.com/users/abhinaykrupa/orgs","repos_url":"https://api.github.com/users/abhinaykrupa/repos","events_url":"https://api.github.com/users/abhinaykrupa/events{/privacy}","received_events_url":"https://api.github.com/users/abhinaykrupa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhinaykrupa/1s","description":null,"fork":false,"url":"https://api.github.com/repos/abhinaykrupa/1s","forks_url":"https://api.github.com/repos/abhinaykrupa/1s/forks","keys_url":"https://api.github.com/repos/abhinaykrupa/1s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhinaykrupa/1s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhinaykrupa/1s/teams","hooks_url":"https://api.github.com/repos/abhinaykrupa/1s/hooks","issue_events_url":"https://api.github.com/repos/abhinaykrupa/1s/issues/events{/number}","events_url":"https://api.github.com/repos/abhinaykrupa/1s/events","assignees_url":"https://api.github.com/repos/abhinaykrupa/1s/assignees{/user}","branches_url":"https://api.github.com/repos/abhinaykrupa/1s/branches{/branch}","tags_url":"https://api.github.com/repos/abhinaykrupa/1s/tags","blobs_url":"https://api.github.com/repos/abhinaykrupa/1s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhinaykrupa/1s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhinaykrupa/1s/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhinaykrupa/1s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhinaykrupa/1s/statuses/{sha}","languages_url":"https://api.github.com/repos/abhinaykrupa/1s/languages","stargazers_url":"https://api.github.com/repos/abhinaykrupa/1s/stargazers","contributors_url":"https://api.github.com/repos/abhinaykrupa/1s/contributors","subscribers_url":"https://api.github.com/repos/abhinaykrupa/1s/subscribers","subscription_url":"https://api.github.com/repos/abhinaykrupa/1s/subscription","commits_url":"https://api.github.com/repos/abhinaykrupa/1s/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhinaykrupa/1s/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhinaykrupa/1s/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhinaykrupa/1s/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhinaykrupa/1s/contents/{+path}","compare_url":"https://api.github.com/repos/abhinaykrupa/1s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhinaykrupa/1s/merges","archive_url":"https://api.github.com/repos/abhinaykrupa/1s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhinaykrupa/1s/downloads","issues_url":"https://api.github.com/repos/abhinaykrupa/1s/issues{/number}","pulls_url":"https://api.github.com/repos/abhinaykrupa/1s/pulls{/number}","milestones_url":"https://api.github.com/repos/abhinaykrupa/1s/milestones{/number}","notifications_url":"https://api.github.com/repos/abhinaykrupa/1s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhinaykrupa/1s/labels{/name}","releases_url":"https://api.github.com/repos/abhinaykrupa/1s/releases{/id}","deployments_url":"https://api.github.com/repos/abhinaykrupa/1s/deployments","created_at":"2016-02-03T17:54:14Z","updated_at":"2018-06-12T20:24:56Z","pushed_at":"2018-06-14T13:52:57Z","git_url":"git://github.com/abhinaykrupa/1s.git","ssh_url":"[email protected]:abhinaykrupa/1s.git","clone_url":"https://github.com/abhinaykrupa/1s.git","svn_url":"https://github.com/abhinaykrupa/1s","homepage":null,"size":5452,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"abhinaykrupa:master","ref":"master","sha":"b8906aea7f51716354836e536f96c1a67bc00f36","user":{"login":"abhinaykrupa","id":2201321,"node_id":"MDQ6VXNlcjIyMDEzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2201321?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinaykrupa","html_url":"https://github.com/abhinaykrupa","followers_url":"https://api.github.com/users/abhinaykrupa/followers","following_url":"https://api.github.com/users/abhinaykrupa/following{/other_user}","gists_url":"https://api.github.com/users/abhinaykrupa/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinaykrupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinaykrupa/subscriptions","organizations_url":"https://api.github.com/users/abhinaykrupa/orgs","repos_url":"https://api.github.com/users/abhinaykrupa/repos","events_url":"https://api.github.com/users/abhinaykrupa/events{/privacy}","received_events_url":"https://api.github.com/users/abhinaykrupa/received_events","type":"User","site_admin":false},"repo":{"id":51018802,"node_id":"MDEwOlJlcG9zaXRvcnk1MTAxODgwMg==","name":"1s","full_name":"abhinaykrupa/1s","owner":{"login":"abhinaykrupa","id":2201321,"node_id":"MDQ6VXNlcjIyMDEzMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2201321?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinaykrupa","html_url":"https://github.com/abhinaykrupa","followers_url":"https://api.github.com/users/abhinaykrupa/followers","following_url":"https://api.github.com/users/abhinaykrupa/following{/other_user}","gists_url":"https://api.github.com/users/abhinaykrupa/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinaykrupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinaykrupa/subscriptions","organizations_url":"https://api.github.com/users/abhinaykrupa/orgs","repos_url":"https://api.github.com/users/abhinaykrupa/repos","events_url":"https://api.github.com/users/abhinaykrupa/events{/privacy}","received_events_url":"https://api.github.com/users/abhinaykrupa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhinaykrupa/1s","description":null,"fork":false,"url":"https://api.github.com/repos/abhinaykrupa/1s","forks_url":"https://api.github.com/repos/abhinaykrupa/1s/forks","keys_url":"https://api.github.com/repos/abhinaykrupa/1s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhinaykrupa/1s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhinaykrupa/1s/teams","hooks_url":"https://api.github.com/repos/abhinaykrupa/1s/hooks","issue_events_url":"https://api.github.com/repos/abhinaykrupa/1s/issues/events{/number}","events_url":"https://api.github.com/repos/abhinaykrupa/1s/events","assignees_url":"https://api.github.com/repos/abhinaykrupa/1s/assignees{/user}","branches_url":"https://api.github.com/repos/abhinaykrupa/1s/branches{/branch}","tags_url":"https://api.github.com/repos/abhinaykrupa/1s/tags","blobs_url":"https://api.github.com/repos/abhinaykrupa/1s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhinaykrupa/1s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhinaykrupa/1s/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhinaykrupa/1s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhinaykrupa/1s/statuses/{sha}","languages_url":"https://api.github.com/repos/abhinaykrupa/1s/languages","stargazers_url":"https://api.github.com/repos/abhinaykrupa/1s/stargazers","contributors_url":"https://api.github.com/repos/abhinaykrupa/1s/contributors","subscribers_url":"https://api.github.com/repos/abhinaykrupa/1s/subscribers","subscription_url":"https://api.github.com/repos/abhinaykrupa/1s/subscription","commits_url":"https://api.github.com/repos/abhinaykrupa/1s/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhinaykrupa/1s/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhinaykrupa/1s/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhinaykrupa/1s/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhinaykrupa/1s/contents/{+path}","compare_url":"https://api.github.com/repos/abhinaykrupa/1s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhinaykrupa/1s/merges","archive_url":"https://api.github.com/repos/abhinaykrupa/1s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhinaykrupa/1s/downloads","issues_url":"https://api.github.com/repos/abhinaykrupa/1s/issues{/number}","pulls_url":"https://api.github.com/repos/abhinaykrupa/1s/pulls{/number}","milestones_url":"https://api.github.com/repos/abhinaykrupa/1s/milestones{/number}","notifications_url":"https://api.github.com/repos/abhinaykrupa/1s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhinaykrupa/1s/labels{/name}","releases_url":"https://api.github.com/repos/abhinaykrupa/1s/releases{/id}","deployments_url":"https://api.github.com/repos/abhinaykrupa/1s/deployments","created_at":"2016-02-03T17:54:14Z","updated_at":"2018-06-12T20:24:56Z","pushed_at":"2018-06-14T13:52:57Z","git_url":"git://github.com/abhinaykrupa/1s.git","ssh_url":"[email protected]:abhinaykrupa/1s.git","clone_url":"https://github.com/abhinaykrupa/1s.git","svn_url":"https://github.com/abhinaykrupa/1s","homepage":null,"size":5452,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abhinaykrupa/1s/pulls/38"},"html":{"href":"https://github.com/abhinaykrupa/1s/pull/38"},"issue":{"href":"https://api.github.com/repos/abhinaykrupa/1s/issues/38"},"comments":{"href":"https://api.github.com/repos/abhinaykrupa/1s/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/abhinaykrupa/1s/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/abhinaykrupa/1s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abhinaykrupa/1s/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/abhinaykrupa/1s/statuses/0d4b2533857e6816c97d5ffd042388251012095c"}},"author_association":"COLLABORATOR"}} | {
"id": 51018802,
"name": "abhinaykrupa/1s",
"url": "https://api.github.com/repos/abhinaykrupa/1s"
} | {
"id": 2201321,
"login": "abhinaykrupa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2201321?",
"url": "https://api.github.com/users/abhinaykrupa"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-06-14T15:17:01 | 7825861558 | {"actor":{"display_login":"abhinaykrupa"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/comments/209786697","pull_request_review_id":145868610,"id":209786697,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTc4NjY5Nw==","diff_hunk":"@@ -0,0 +1,22 @@\n+#!/usr/bin/env python3\n+# -*- coding: utf-8 -*-\n+\"\"\"\n+Created on Thu May 10 15:34:22 2018\n+\n+@author: amyhaddad\n+\"\"\"\n+\n+# Step 1: write constants\n+LOW_INTENSITY = 55","path":"ex_31.py","position":10,"original_position":10,"commit_id":"75a2f1cb71e5a8f9bb56c6bc584961a440e5bf8a","original_commit_id":"75a2f1cb71e5a8f9bb56c6bc584961a440e5bf8a","user":{"login":"paulghaddad","id":1412714,"node_id":"MDQ6VXNlcjE0MTI3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1412714?v=4","gravatar_id":"","url":"https://api.github.com/users/paulghaddad","html_url":"https://github.com/paulghaddad","followers_url":"https://api.github.com/users/paulghaddad/followers","following_url":"https://api.github.com/users/paulghaddad/following{/other_user}","gists_url":"https://api.github.com/users/paulghaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/paulghaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulghaddad/subscriptions","organizations_url":"https://api.github.com/users/paulghaddad/orgs","repos_url":"https://api.github.com/users/paulghaddad/repos","events_url":"https://api.github.com/users/paulghaddad/events{/privacy}","received_events_url":"https://api.github.com/users/paulghaddad/received_events","type":"User","site_admin":false},"body":"Exactly","created_at":"2018-08-13T23:08:19Z","updated_at":"2018-08-13T23:10:23Z","html_url":"https://github.com/amymhaddad/exercises_for_programmers/pull/77#discussion_r209786697","pull_request_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/77","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/comments/209786697"},"html":{"href":"https://github.com/amymhaddad/exercises_for_programmers/pull/77#discussion_r209786697"},"pull_request":{"href":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/77","id":208051395,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDUxMzk1","html_url":"https://github.com/amymhaddad/exercises_for_programmers/pull/77","diff_url":"https://github.com/amymhaddad/exercises_for_programmers/pull/77.diff","patch_url":"https://github.com/amymhaddad/exercises_for_programmers/pull/77.patch","issue_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues/77","number":77,"state":"open","locked":false,"title":"ex_31.py","user":{"login":"amymhaddad","id":39930340,"node_id":"MDQ6VXNlcjM5OTMwMzQw","avatar_url":"https://avatars1.githubusercontent.com/u/39930340?v=4","gravatar_id":"","url":"https://api.github.com/users/amymhaddad","html_url":"https://github.com/amymhaddad","followers_url":"https://api.github.com/users/amymhaddad/followers","following_url":"https://api.github.com/users/amymhaddad/following{/other_user}","gists_url":"https://api.github.com/users/amymhaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/amymhaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amymhaddad/subscriptions","organizations_url":"https://api.github.com/users/amymhaddad/orgs","repos_url":"https://api.github.com/users/amymhaddad/repos","events_url":"https://api.github.com/users/amymhaddad/events{/privacy}","received_events_url":"https://api.github.com/users/amymhaddad/received_events","type":"User","site_admin":false},"body":"When getting into a fitness program, you may want to figure out your target heart rate so you don’t overexert yourself. The Karvonen heart rate formula is one method you can use to determine your rate. Create a program that prompts for your age and your resting heart rate. Use the Karvonen for- mula to determine the target heart rate based on a range of intensities from 55% to 95%. Generate a table with the results as shown in the example output. \r\n\r\nThe formula is\r\nTargetHeartRate = (((220 − age) − restingHR) × intensity) + restingHR","created_at":"2018-08-13T17:39:54Z","updated_at":"2018-08-13T23:10:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d587347db468afb6e922d02b71db61a45751ccf0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1021328505,"node_id":"MDU6TGFiZWwxMDIxMzI4NTA1","url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/labels/loops","name":"loops","color":"abfcf8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/77/commits","review_comments_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/77/comments","review_comment_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues/77/comments","statuses_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/statuses/75a2f1cb71e5a8f9bb56c6bc584961a440e5bf8a","head":{"label":"amymhaddad:ex_31.py","ref":"ex_31.py","sha":"75a2f1cb71e5a8f9bb56c6bc584961a440e5bf8a","user":{"login":"amymhaddad","id":39930340,"node_id":"MDQ6VXNlcjM5OTMwMzQw","avatar_url":"https://avatars1.githubusercontent.com/u/39930340?v=4","gravatar_id":"","url":"https://api.github.com/users/amymhaddad","html_url":"https://github.com/amymhaddad","followers_url":"https://api.github.com/users/amymhaddad/followers","following_url":"https://api.github.com/users/amymhaddad/following{/other_user}","gists_url":"https://api.github.com/users/amymhaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/amymhaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amymhaddad/subscriptions","organizations_url":"https://api.github.com/users/amymhaddad/orgs","repos_url":"https://api.github.com/users/amymhaddad/repos","events_url":"https://api.github.com/users/amymhaddad/events{/privacy}","received_events_url":"https://api.github.com/users/amymhaddad/received_events","type":"User","site_admin":false},"repo":{"id":136092133,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwOTIxMzM=","name":"exercises_for_programmers","full_name":"amymhaddad/exercises_for_programmers","owner":{"login":"amymhaddad","id":39930340,"node_id":"MDQ6VXNlcjM5OTMwMzQw","avatar_url":"https://avatars1.githubusercontent.com/u/39930340?v=4","gravatar_id":"","url":"https://api.github.com/users/amymhaddad","html_url":"https://github.com/amymhaddad","followers_url":"https://api.github.com/users/amymhaddad/followers","following_url":"https://api.github.com/users/amymhaddad/following{/other_user}","gists_url":"https://api.github.com/users/amymhaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/amymhaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amymhaddad/subscriptions","organizations_url":"https://api.github.com/users/amymhaddad/orgs","repos_url":"https://api.github.com/users/amymhaddad/repos","events_url":"https://api.github.com/users/amymhaddad/events{/privacy}","received_events_url":"https://api.github.com/users/amymhaddad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amymhaddad/exercises_for_programmers","description":null,"fork":false,"url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers","forks_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/forks","keys_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/teams","hooks_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/hooks","issue_events_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues/events{/number}","events_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/events","assignees_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/assignees{/user}","branches_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/branches{/branch}","tags_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/tags","blobs_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/refs{/sha}","trees_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/statuses/{sha}","languages_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/languages","stargazers_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/stargazers","contributors_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/contributors","subscribers_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/subscribers","subscription_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/subscription","commits_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/commits{/sha}","git_commits_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/commits{/sha}","comments_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/comments{/number}","issue_comment_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues/comments{/number}","contents_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/contents/{+path}","compare_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/merges","archive_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/downloads","issues_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues{/number}","pulls_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls{/number}","milestones_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/milestones{/number}","notifications_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/labels{/name}","releases_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/releases{/id}","deployments_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/deployments","created_at":"2018-06-04T23:04:11Z","updated_at":"2018-08-13T17:58:30Z","pushed_at":"2018-08-13T18:48:13Z","git_url":"git://github.com/amymhaddad/exercises_for_programmers.git","ssh_url":"[email protected]:amymhaddad/exercises_for_programmers.git","clone_url":"https://github.com/amymhaddad/exercises_for_programmers.git","svn_url":"https://github.com/amymhaddad/exercises_for_programmers","homepage":null,"size":150,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"amymhaddad:master","ref":"master","sha":"e112f63338d2a0408f1289565647b55be1196c28","user":{"login":"amymhaddad","id":39930340,"node_id":"MDQ6VXNlcjM5OTMwMzQw","avatar_url":"https://avatars1.githubusercontent.com/u/39930340?v=4","gravatar_id":"","url":"https://api.github.com/users/amymhaddad","html_url":"https://github.com/amymhaddad","followers_url":"https://api.github.com/users/amymhaddad/followers","following_url":"https://api.github.com/users/amymhaddad/following{/other_user}","gists_url":"https://api.github.com/users/amymhaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/amymhaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amymhaddad/subscriptions","organizations_url":"https://api.github.com/users/amymhaddad/orgs","repos_url":"https://api.github.com/users/amymhaddad/repos","events_url":"https://api.github.com/users/amymhaddad/events{/privacy}","received_events_url":"https://api.github.com/users/amymhaddad/received_events","type":"User","site_admin":false},"repo":{"id":136092133,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwOTIxMzM=","name":"exercises_for_programmers","full_name":"amymhaddad/exercises_for_programmers","owner":{"login":"amymhaddad","id":39930340,"node_id":"MDQ6VXNlcjM5OTMwMzQw","avatar_url":"https://avatars1.githubusercontent.com/u/39930340?v=4","gravatar_id":"","url":"https://api.github.com/users/amymhaddad","html_url":"https://github.com/amymhaddad","followers_url":"https://api.github.com/users/amymhaddad/followers","following_url":"https://api.github.com/users/amymhaddad/following{/other_user}","gists_url":"https://api.github.com/users/amymhaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/amymhaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amymhaddad/subscriptions","organizations_url":"https://api.github.com/users/amymhaddad/orgs","repos_url":"https://api.github.com/users/amymhaddad/repos","events_url":"https://api.github.com/users/amymhaddad/events{/privacy}","received_events_url":"https://api.github.com/users/amymhaddad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amymhaddad/exercises_for_programmers","description":null,"fork":false,"url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers","forks_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/forks","keys_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/teams","hooks_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/hooks","issue_events_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues/events{/number}","events_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/events","assignees_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/assignees{/user}","branches_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/branches{/branch}","tags_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/tags","blobs_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/refs{/sha}","trees_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/statuses/{sha}","languages_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/languages","stargazers_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/stargazers","contributors_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/contributors","subscribers_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/subscribers","subscription_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/subscription","commits_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/commits{/sha}","git_commits_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/git/commits{/sha}","comments_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/comments{/number}","issue_comment_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues/comments{/number}","contents_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/contents/{+path}","compare_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/merges","archive_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/downloads","issues_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues{/number}","pulls_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls{/number}","milestones_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/milestones{/number}","notifications_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/labels{/name}","releases_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/releases{/id}","deployments_url":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/deployments","created_at":"2018-06-04T23:04:11Z","updated_at":"2018-08-13T17:58:30Z","pushed_at":"2018-08-13T18:48:13Z","git_url":"git://github.com/amymhaddad/exercises_for_programmers.git","ssh_url":"[email protected]:amymhaddad/exercises_for_programmers.git","clone_url":"https://github.com/amymhaddad/exercises_for_programmers.git","svn_url":"https://github.com/amymhaddad/exercises_for_programmers","homepage":null,"size":150,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/77"},"html":{"href":"https://github.com/amymhaddad/exercises_for_programmers/pull/77"},"issue":{"href":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues/77"},"comments":{"href":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/amymhaddad/exercises_for_programmers/statuses/75a2f1cb71e5a8f9bb56c6bc584961a440e5bf8a"}},"author_association":"OWNER"}} | {
"id": 136092133,
"name": "amymhaddad/exercises_for_programmers",
"url": "https://api.github.com/repos/amymhaddad/exercises_for_programmers"
} | {
"id": 1412714,
"login": "paulghaddad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1412714?",
"url": "https://api.github.com/users/paulghaddad"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-08-13T23:08:19 | 8108014154 | {"actor":{"display_login":"paulghaddad"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments/216124688","pull_request_review_id":153547966,"id":216124688,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjEyNDY4OA==","diff_hunk":"@@ -0,0 +1,63 @@\n+# coding: utf-8\n+from __future__ import unicode_literals\n+\n+from .common import InfoExtractor\n+from ..compat import (\n+ compat_urllib_parse_unquote\n+)\n+\n+\n+class MediaKlikkIE(InfoExtractor):\n+ _VALID_URL = r'https?://(?:www\\.)?mediaklikk\\.hu/video/(?:[^/]+/)'\n+ _TESTS = [\n+ {\n+ 'url': 'https://www.mediaklikk.hu/video/az-evszakok-buvoleteben-osz/',\n+ 'info_dict': {\n+ 'id': '2512015',\n+ 'title': 'Az évszakok bűvöletében, Ősz',\n+ 'series': 'Az évszakok bűvöletében',\n+ 'ext': 'mp4'\n+ }\n+ },\n+ {\n+ 'url': 'https://www.mediaklikk.hu/video/sporthirado-350-resz/',\n+ 'info_dict': {\n+ 'id': '2523053',\n+ 'title': 'Sporthíradó, 350. rész',\n+ 'series': 'Sporthíradó',\n+ 'ext': 'mp4'\n+ }\n+ },\n+ ]\n+\n+ def _real_extract(self, url):\n+ webpage = self._download_webpage(url,\n+ None,","path":"youtube_dl/extractor/mediaklikk.py","position":35,"original_position":35,"commit_id":"9184b056d0a8f0cad3ce2fb0418b1d86750c38f1","original_commit_id":"9184b056d0a8f0cad3ce2fb0418b1d86750c38f1","user":{"login":"dstftw","id":1908898,"node_id":"MDQ6VXNlcjE5MDg4OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1908898?v=4","gravatar_id":"","url":"https://api.github.com/users/dstftw","html_url":"https://github.com/dstftw","followers_url":"https://api.github.com/users/dstftw/followers","following_url":"https://api.github.com/users/dstftw/following{/other_user}","gists_url":"https://api.github.com/users/dstftw/gists{/gist_id}","starred_url":"https://api.github.com/users/dstftw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstftw/subscriptions","organizations_url":"https://api.github.com/users/dstftw/orgs","repos_url":"https://api.github.com/users/dstftw/repos","events_url":"https://api.github.com/users/dstftw/events{/privacy}","received_events_url":"https://api.github.com/users/dstftw/received_events","type":"User","site_admin":false},"body":"Capture and output display id.","created_at":"2018-09-08T08:27:23Z","updated_at":"2018-09-08T08:30:57Z","html_url":"https://github.com/rg3/youtube-dl/pull/17453#discussion_r216124688","pull_request_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/17453","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments/216124688"},"html":{"href":"https://github.com/rg3/youtube-dl/pull/17453#discussion_r216124688"},"pull_request":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/17453"}}},"pull_request":{"url":"https://api.github.com/repos/rg3/youtube-dl/pulls/17453","id":213757984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzU3OTg0","html_url":"https://github.com/rg3/youtube-dl/pull/17453","diff_url":"https://github.com/rg3/youtube-dl/pull/17453.diff","patch_url":"https://github.com/rg3/youtube-dl/pull/17453.patch","issue_url":"https://api.github.com/repos/rg3/youtube-dl/issues/17453","number":17453,"state":"open","locked":false,"title":"Mediaklikk extractor","user":{"login":"tmarki","id":143840,"node_id":"MDQ6VXNlcjE0Mzg0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/143840?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarki","html_url":"https://github.com/tmarki","followers_url":"https://api.github.com/users/tmarki/followers","following_url":"https://api.github.com/users/tmarki/following{/other_user}","gists_url":"https://api.github.com/users/tmarki/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarki/subscriptions","organizations_url":"https://api.github.com/users/tmarki/orgs","repos_url":"https://api.github.com/users/tmarki/repos","events_url":"https://api.github.com/users/tmarki/events{/privacy}","received_events_url":"https://api.github.com/users/tmarki/received_events","type":"User","site_admin":false},"body":"## Please follow the guide below\r\n\r\n- You will be asked some questions, please read them **carefully** and answer honestly\r\n- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])\r\n- Use *Preview* tab to see how your *pull request* will actually look like\r\n\r\n---\r\n\r\n### Before submitting a *pull request* make sure you have:\r\n- [x] At least skimmed through [adding new extractor tutorial](https://github.com/rg3/youtube-dl#adding-support-for-a-new-site) and [youtube-dl coding conventions](https://github.com/rg3/youtube-dl#youtube-dl-coding-conventions) sections\r\n- [x] [Searched](https://github.com/rg3/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests\r\n- [x] Checked the code with [flake8](https://pypi.python.org/pypi/flake8)\r\n\r\n### In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under [Unlicense](http://unlicense.org/). Check one of the following options:\r\n- [x] I am the original author of this code and I am willing to release it under [Unlicense](http://unlicense.org/)\r\n- [ ] I am not the original author of this code but it is in public domain or released under [Unlicense](http://unlicense.org/) (provide reliable evidence)\r\n\r\n### What is the purpose of your *pull request*?\r\n- [ ] Bug fix\r\n- [ ] Improvement\r\n- [x] New extractor\r\n- [ ] New feature\r\n\r\n---\r\n\r\n### Description of your *pull request* and other information\r\n\r\nExtractor for Hungarian state media (MTVA) video repository hosted at https://www.mediaklikk.hu/mediatar/","created_at":"2018-09-06T21:37:58Z","updated_at":"2018-09-08T08:30:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0b7d45f59d36bb914d8b9c05a219f18248fa57d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/17453/commits","review_comments_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/17453/comments","review_comment_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rg3/youtube-dl/issues/17453/comments","statuses_url":"https://api.github.com/repos/rg3/youtube-dl/statuses/9184b056d0a8f0cad3ce2fb0418b1d86750c38f1","head":{"label":"tmarki:mediaklikk","ref":"mediaklikk","sha":"9184b056d0a8f0cad3ce2fb0418b1d86750c38f1","user":{"login":"tmarki","id":143840,"node_id":"MDQ6VXNlcjE0Mzg0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/143840?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarki","html_url":"https://github.com/tmarki","followers_url":"https://api.github.com/users/tmarki/followers","following_url":"https://api.github.com/users/tmarki/following{/other_user}","gists_url":"https://api.github.com/users/tmarki/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarki/subscriptions","organizations_url":"https://api.github.com/users/tmarki/orgs","repos_url":"https://api.github.com/users/tmarki/repos","events_url":"https://api.github.com/users/tmarki/events{/privacy}","received_events_url":"https://api.github.com/users/tmarki/received_events","type":"User","site_admin":false},"repo":{"id":147036590,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcwMzY1OTA=","name":"youtube-dl","full_name":"tmarki/youtube-dl","owner":{"login":"tmarki","id":143840,"node_id":"MDQ6VXNlcjE0Mzg0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/143840?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarki","html_url":"https://github.com/tmarki","followers_url":"https://api.github.com/users/tmarki/followers","following_url":"https://api.github.com/users/tmarki/following{/other_user}","gists_url":"https://api.github.com/users/tmarki/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarki/subscriptions","organizations_url":"https://api.github.com/users/tmarki/orgs","repos_url":"https://api.github.com/users/tmarki/repos","events_url":"https://api.github.com/users/tmarki/events{/privacy}","received_events_url":"https://api.github.com/users/tmarki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmarki/youtube-dl","description":"Command-line program to download videos from YouTube.com and other video sites","fork":true,"url":"https://api.github.com/repos/tmarki/youtube-dl","forks_url":"https://api.github.com/repos/tmarki/youtube-dl/forks","keys_url":"https://api.github.com/repos/tmarki/youtube-dl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmarki/youtube-dl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmarki/youtube-dl/teams","hooks_url":"https://api.github.com/repos/tmarki/youtube-dl/hooks","issue_events_url":"https://api.github.com/repos/tmarki/youtube-dl/issues/events{/number}","events_url":"https://api.github.com/repos/tmarki/youtube-dl/events","assignees_url":"https://api.github.com/repos/tmarki/youtube-dl/assignees{/user}","branches_url":"https://api.github.com/repos/tmarki/youtube-dl/branches{/branch}","tags_url":"https://api.github.com/repos/tmarki/youtube-dl/tags","blobs_url":"https://api.github.com/repos/tmarki/youtube-dl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmarki/youtube-dl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmarki/youtube-dl/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmarki/youtube-dl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmarki/youtube-dl/statuses/{sha}","languages_url":"https://api.github.com/repos/tmarki/youtube-dl/languages","stargazers_url":"https://api.github.com/repos/tmarki/youtube-dl/stargazers","contributors_url":"https://api.github.com/repos/tmarki/youtube-dl/contributors","subscribers_url":"https://api.github.com/repos/tmarki/youtube-dl/subscribers","subscription_url":"https://api.github.com/repos/tmarki/youtube-dl/subscription","commits_url":"https://api.github.com/repos/tmarki/youtube-dl/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmarki/youtube-dl/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmarki/youtube-dl/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmarki/youtube-dl/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmarki/youtube-dl/contents/{+path}","compare_url":"https://api.github.com/repos/tmarki/youtube-dl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmarki/youtube-dl/merges","archive_url":"https://api.github.com/repos/tmarki/youtube-dl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmarki/youtube-dl/downloads","issues_url":"https://api.github.com/repos/tmarki/youtube-dl/issues{/number}","pulls_url":"https://api.github.com/repos/tmarki/youtube-dl/pulls{/number}","milestones_url":"https://api.github.com/repos/tmarki/youtube-dl/milestones{/number}","notifications_url":"https://api.github.com/repos/tmarki/youtube-dl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmarki/youtube-dl/labels{/name}","releases_url":"https://api.github.com/repos/tmarki/youtube-dl/releases{/id}","deployments_url":"https://api.github.com/repos/tmarki/youtube-dl/deployments","created_at":"2018-09-01T22:17:43Z","updated_at":"2018-09-01T22:18:00Z","pushed_at":"2018-09-06T21:34:48Z","git_url":"git://github.com/tmarki/youtube-dl.git","ssh_url":"[email protected]:tmarki/youtube-dl.git","clone_url":"https://github.com/tmarki/youtube-dl.git","svn_url":"https://github.com/tmarki/youtube-dl","homepage":"http://rg3.github.io/youtube-dl/","size":53531,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rg3:master","ref":"master","sha":"2d4fe594c64249c263d739c8094b445c67fa09f5","user":{"login":"rg3","id":53487,"node_id":"MDQ6VXNlcjUzNDg3","avatar_url":"https://avatars0.githubusercontent.com/u/53487?v=4","gravatar_id":"","url":"https://api.github.com/users/rg3","html_url":"https://github.com/rg3","followers_url":"https://api.github.com/users/rg3/followers","following_url":"https://api.github.com/users/rg3/following{/other_user}","gists_url":"https://api.github.com/users/rg3/gists{/gist_id}","starred_url":"https://api.github.com/users/rg3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rg3/subscriptions","organizations_url":"https://api.github.com/users/rg3/orgs","repos_url":"https://api.github.com/users/rg3/repos","events_url":"https://api.github.com/users/rg3/events{/privacy}","received_events_url":"https://api.github.com/users/rg3/received_events","type":"User","site_admin":false},"repo":{"id":1039520,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5NTIw","name":"youtube-dl","full_name":"rg3/youtube-dl","owner":{"login":"rg3","id":53487,"node_id":"MDQ6VXNlcjUzNDg3","avatar_url":"https://avatars0.githubusercontent.com/u/53487?v=4","gravatar_id":"","url":"https://api.github.com/users/rg3","html_url":"https://github.com/rg3","followers_url":"https://api.github.com/users/rg3/followers","following_url":"https://api.github.com/users/rg3/following{/other_user}","gists_url":"https://api.github.com/users/rg3/gists{/gist_id}","starred_url":"https://api.github.com/users/rg3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rg3/subscriptions","organizations_url":"https://api.github.com/users/rg3/orgs","repos_url":"https://api.github.com/users/rg3/repos","events_url":"https://api.github.com/users/rg3/events{/privacy}","received_events_url":"https://api.github.com/users/rg3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rg3/youtube-dl","description":"Command-line program to download videos from YouTube.com and other video sites","fork":false,"url":"https://api.github.com/repos/rg3/youtube-dl","forks_url":"https://api.github.com/repos/rg3/youtube-dl/forks","keys_url":"https://api.github.com/repos/rg3/youtube-dl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rg3/youtube-dl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rg3/youtube-dl/teams","hooks_url":"https://api.github.com/repos/rg3/youtube-dl/hooks","issue_events_url":"https://api.github.com/repos/rg3/youtube-dl/issues/events{/number}","events_url":"https://api.github.com/repos/rg3/youtube-dl/events","assignees_url":"https://api.github.com/repos/rg3/youtube-dl/assignees{/user}","branches_url":"https://api.github.com/repos/rg3/youtube-dl/branches{/branch}","tags_url":"https://api.github.com/repos/rg3/youtube-dl/tags","blobs_url":"https://api.github.com/repos/rg3/youtube-dl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rg3/youtube-dl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rg3/youtube-dl/git/refs{/sha}","trees_url":"https://api.github.com/repos/rg3/youtube-dl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rg3/youtube-dl/statuses/{sha}","languages_url":"https://api.github.com/repos/rg3/youtube-dl/languages","stargazers_url":"https://api.github.com/repos/rg3/youtube-dl/stargazers","contributors_url":"https://api.github.com/repos/rg3/youtube-dl/contributors","subscribers_url":"https://api.github.com/repos/rg3/youtube-dl/subscribers","subscription_url":"https://api.github.com/repos/rg3/youtube-dl/subscription","commits_url":"https://api.github.com/repos/rg3/youtube-dl/commits{/sha}","git_commits_url":"https://api.github.com/repos/rg3/youtube-dl/git/commits{/sha}","comments_url":"https://api.github.com/repos/rg3/youtube-dl/comments{/number}","issue_comment_url":"https://api.github.com/repos/rg3/youtube-dl/issues/comments{/number}","contents_url":"https://api.github.com/repos/rg3/youtube-dl/contents/{+path}","compare_url":"https://api.github.com/repos/rg3/youtube-dl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rg3/youtube-dl/merges","archive_url":"https://api.github.com/repos/rg3/youtube-dl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rg3/youtube-dl/downloads","issues_url":"https://api.github.com/repos/rg3/youtube-dl/issues{/number}","pulls_url":"https://api.github.com/repos/rg3/youtube-dl/pulls{/number}","milestones_url":"https://api.github.com/repos/rg3/youtube-dl/milestones{/number}","notifications_url":"https://api.github.com/repos/rg3/youtube-dl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rg3/youtube-dl/labels{/name}","releases_url":"https://api.github.com/repos/rg3/youtube-dl/releases{/id}","deployments_url":"https://api.github.com/repos/rg3/youtube-dl/deployments","created_at":"2010-10-31T14:35:07Z","updated_at":"2018-09-08T07:45:14Z","pushed_at":"2018-09-08T07:44:07Z","git_url":"git://github.com/rg3/youtube-dl.git","ssh_url":"[email protected]:rg3/youtube-dl.git","clone_url":"https://github.com/rg3/youtube-dl.git","svn_url":"https://github.com/rg3/youtube-dl","homepage":"http://rg3.github.io/youtube-dl/","size":53525,"stargazers_count":41396,"watchers_count":41396,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":7282,"mirror_url":null,"archived":false,"open_issues_count":2383,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":7282,"open_issues":2383,"watchers":41396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/17453"},"html":{"href":"https://github.com/rg3/youtube-dl/pull/17453"},"issue":{"href":"https://api.github.com/repos/rg3/youtube-dl/issues/17453"},"comments":{"href":"https://api.github.com/repos/rg3/youtube-dl/issues/17453/comments"},"review_comments":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/17453/comments"},"review_comment":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/17453/commits"},"statuses":{"href":"https://api.github.com/repos/rg3/youtube-dl/statuses/9184b056d0a8f0cad3ce2fb0418b1d86750c38f1"}},"author_association":"NONE"}} | {
"id": 1039520,
"name": "rg3/youtube-dl",
"url": "https://api.github.com/repos/rg3/youtube-dl"
} | {
"id": 1908898,
"login": "dstftw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1908898?",
"url": "https://api.github.com/users/dstftw"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-09-08T08:27:23 | 8233977225 | {"actor":{"display_login":"dstftw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/comments/229785417","pull_request_review_id":170368729,"id":229785417,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTc4NTQxNw==","diff_hunk":"@@ -0,0 +1,15 @@\n+import React from 'react';","path":"client/components/common/MobileNavbar.jsx","position":1,"original_position":1,"commit_id":"e04b70f2a810a762363f6d44a5338b66541b0d9d","original_commit_id":"e04b70f2a810a762363f6d44a5338b66541b0d9d","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Parsing error: 'import' and 'export' may appear only with 'sourceType: module'","created_at":"2018-10-31T17:05:37Z","updated_at":"2018-10-31T17:05:37Z","html_url":"https://github.com/kingsman20/ride_my_way_react/pull/24#discussion_r229785417","pull_request_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/24","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/comments/229785417"},"html":{"href":"https://github.com/kingsman20/ride_my_way_react/pull/24#discussion_r229785417"},"pull_request":{"href":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/24","id":227369278,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzY5Mjc4","html_url":"https://github.com/kingsman20/ride_my_way_react/pull/24","diff_url":"https://github.com/kingsman20/ride_my_way_react/pull/24.diff","patch_url":"https://github.com/kingsman20/ride_my_way_react/pull/24.patch","issue_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues/24","number":24,"state":"open","locked":false,"title":"Fix navbar issue on mobile","user":{"login":"kingsman20","id":20397262,"node_id":"MDQ6VXNlcjIwMzk3MjYy","avatar_url":"https://avatars2.githubusercontent.com/u/20397262?v=4","gravatar_id":"","url":"https://api.github.com/users/kingsman20","html_url":"https://github.com/kingsman20","followers_url":"https://api.github.com/users/kingsman20/followers","following_url":"https://api.github.com/users/kingsman20/following{/other_user}","gists_url":"https://api.github.com/users/kingsman20/gists{/gist_id}","starred_url":"https://api.github.com/users/kingsman20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingsman20/subscriptions","organizations_url":"https://api.github.com/users/kingsman20/orgs","repos_url":"https://api.github.com/users/kingsman20/repos","events_url":"https://api.github.com/users/kingsman20/events{/privacy}","received_events_url":"https://api.github.com/users/kingsman20/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-31T17:05:13Z","updated_at":"2018-10-31T17:05:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3816bb2bdd775a2a6b2fbd076c1ecf34bbdba5b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/24/commits","review_comments_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/24/comments","review_comment_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues/24/comments","statuses_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/statuses/e04b70f2a810a762363f6d44a5338b66541b0d9d","head":{"label":"kingsman20:ch-fix-mobile-navbar","ref":"ch-fix-mobile-navbar","sha":"e04b70f2a810a762363f6d44a5338b66541b0d9d","user":{"login":"kingsman20","id":20397262,"node_id":"MDQ6VXNlcjIwMzk3MjYy","avatar_url":"https://avatars2.githubusercontent.com/u/20397262?v=4","gravatar_id":"","url":"https://api.github.com/users/kingsman20","html_url":"https://github.com/kingsman20","followers_url":"https://api.github.com/users/kingsman20/followers","following_url":"https://api.github.com/users/kingsman20/following{/other_user}","gists_url":"https://api.github.com/users/kingsman20/gists{/gist_id}","starred_url":"https://api.github.com/users/kingsman20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingsman20/subscriptions","organizations_url":"https://api.github.com/users/kingsman20/orgs","repos_url":"https://api.github.com/users/kingsman20/repos","events_url":"https://api.github.com/users/kingsman20/events{/privacy}","received_events_url":"https://api.github.com/users/kingsman20/received_events","type":"User","site_admin":false},"repo":{"id":150415945,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0MTU5NDU=","name":"ride_my_way_react","full_name":"kingsman20/ride_my_way_react","private":false,"owner":{"login":"kingsman20","id":20397262,"node_id":"MDQ6VXNlcjIwMzk3MjYy","avatar_url":"https://avatars2.githubusercontent.com/u/20397262?v=4","gravatar_id":"","url":"https://api.github.com/users/kingsman20","html_url":"https://github.com/kingsman20","followers_url":"https://api.github.com/users/kingsman20/followers","following_url":"https://api.github.com/users/kingsman20/following{/other_user}","gists_url":"https://api.github.com/users/kingsman20/gists{/gist_id}","starred_url":"https://api.github.com/users/kingsman20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingsman20/subscriptions","organizations_url":"https://api.github.com/users/kingsman20/orgs","repos_url":"https://api.github.com/users/kingsman20/repos","events_url":"https://api.github.com/users/kingsman20/events{/privacy}","received_events_url":"https://api.github.com/users/kingsman20/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kingsman20/ride_my_way_react","description":null,"fork":false,"url":"https://api.github.com/repos/kingsman20/ride_my_way_react","forks_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/forks","keys_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/teams","hooks_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/hooks","issue_events_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues/events{/number}","events_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/events","assignees_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/assignees{/user}","branches_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/branches{/branch}","tags_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/tags","blobs_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/statuses/{sha}","languages_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/languages","stargazers_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/stargazers","contributors_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/contributors","subscribers_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/subscribers","subscription_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/subscription","commits_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/contents/{+path}","compare_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/merges","archive_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/downloads","issues_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues{/number}","pulls_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls{/number}","milestones_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/milestones{/number}","notifications_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/labels{/name}","releases_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/releases{/id}","deployments_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/deployments","created_at":"2018-09-26T11:28:12Z","updated_at":"2018-10-31T08:52:32Z","pushed_at":"2018-10-31T17:05:14Z","git_url":"git://github.com/kingsman20/ride_my_way_react.git","ssh_url":"[email protected]:kingsman20/ride_my_way_react.git","clone_url":"https://github.com/kingsman20/ride_my_way_react.git","svn_url":"https://github.com/kingsman20/ride_my_way_react","homepage":null,"size":907,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"kingsman20:develop","ref":"develop","sha":"46f0cf6d1eccef2a2c22b14a97b00c4e069d4c92","user":{"login":"kingsman20","id":20397262,"node_id":"MDQ6VXNlcjIwMzk3MjYy","avatar_url":"https://avatars2.githubusercontent.com/u/20397262?v=4","gravatar_id":"","url":"https://api.github.com/users/kingsman20","html_url":"https://github.com/kingsman20","followers_url":"https://api.github.com/users/kingsman20/followers","following_url":"https://api.github.com/users/kingsman20/following{/other_user}","gists_url":"https://api.github.com/users/kingsman20/gists{/gist_id}","starred_url":"https://api.github.com/users/kingsman20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingsman20/subscriptions","organizations_url":"https://api.github.com/users/kingsman20/orgs","repos_url":"https://api.github.com/users/kingsman20/repos","events_url":"https://api.github.com/users/kingsman20/events{/privacy}","received_events_url":"https://api.github.com/users/kingsman20/received_events","type":"User","site_admin":false},"repo":{"id":150415945,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0MTU5NDU=","name":"ride_my_way_react","full_name":"kingsman20/ride_my_way_react","private":false,"owner":{"login":"kingsman20","id":20397262,"node_id":"MDQ6VXNlcjIwMzk3MjYy","avatar_url":"https://avatars2.githubusercontent.com/u/20397262?v=4","gravatar_id":"","url":"https://api.github.com/users/kingsman20","html_url":"https://github.com/kingsman20","followers_url":"https://api.github.com/users/kingsman20/followers","following_url":"https://api.github.com/users/kingsman20/following{/other_user}","gists_url":"https://api.github.com/users/kingsman20/gists{/gist_id}","starred_url":"https://api.github.com/users/kingsman20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingsman20/subscriptions","organizations_url":"https://api.github.com/users/kingsman20/orgs","repos_url":"https://api.github.com/users/kingsman20/repos","events_url":"https://api.github.com/users/kingsman20/events{/privacy}","received_events_url":"https://api.github.com/users/kingsman20/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kingsman20/ride_my_way_react","description":null,"fork":false,"url":"https://api.github.com/repos/kingsman20/ride_my_way_react","forks_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/forks","keys_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/teams","hooks_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/hooks","issue_events_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues/events{/number}","events_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/events","assignees_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/assignees{/user}","branches_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/branches{/branch}","tags_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/tags","blobs_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/statuses/{sha}","languages_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/languages","stargazers_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/stargazers","contributors_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/contributors","subscribers_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/subscribers","subscription_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/subscription","commits_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/contents/{+path}","compare_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/merges","archive_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/downloads","issues_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues{/number}","pulls_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls{/number}","milestones_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/milestones{/number}","notifications_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/labels{/name}","releases_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/releases{/id}","deployments_url":"https://api.github.com/repos/kingsman20/ride_my_way_react/deployments","created_at":"2018-09-26T11:28:12Z","updated_at":"2018-10-31T08:52:32Z","pushed_at":"2018-10-31T17:05:14Z","git_url":"git://github.com/kingsman20/ride_my_way_react.git","ssh_url":"[email protected]:kingsman20/ride_my_way_react.git","clone_url":"https://github.com/kingsman20/ride_my_way_react.git","svn_url":"https://github.com/kingsman20/ride_my_way_react","homepage":null,"size":907,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/24"},"html":{"href":"https://github.com/kingsman20/ride_my_way_react/pull/24"},"issue":{"href":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues/24"},"comments":{"href":"https://api.github.com/repos/kingsman20/ride_my_way_react/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kingsman20/ride_my_way_react/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/kingsman20/ride_my_way_react/statuses/e04b70f2a810a762363f6d44a5338b66541b0d9d"}},"author_association":"OWNER"}} | {
"id": 150415945,
"name": "kingsman20/ride_my_way_react",
"url": "https://api.github.com/repos/kingsman20/ride_my_way_react"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-10-31T17:05:37 | 8513878616 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jjaniec/21sh/pulls/comments/224437190","pull_request_review_id":163801399,"id":224437190,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDQzNzE5MA==","diff_hunk":"@@ -0,0 +1,108 @@\n+/* ************************************************************************** */\n+/* */\n+/* ::: :::::::: */\n+/* load_backup_files.c :+: :+: :+: */\n+/* +:+ +:+ +:+ */\n+/* By: cyfermie <[email protected]> +#+ +:+ +#+ */\n+/* +#+#+#+#+#+ +#+ */\n+/* Created: 2018/10/08 16:19:04 by cyfermie #+# #+# */\n+/* Updated: 2018/10/10 17:33:26 by cyfermie ### ########.fr */\n+/* */\n+/* ************************************************************************** */\n+\n+#include <forty_two_sh.h>\n+\n+static void\tdo_the_copy(const char *separator_sign_pos, bool *first_elem, \\\n+\t\t\t\t\t\t\t\tstruct s_alias **alias, const char *line)\n+{\n+\tconst char\t*check_equal = line;\n+\twhile (*check_equal && is_separator(*check_equal))\n+\t\t++check_equal;\n+\tif (*check_equal == '=')\n+\t\treturn ;\n+\tif (*first_elem == false)\n+\t{\n+\t\t(*alias)->next = malloc(sizeof(struct s_alias));\n+\t\t(*alias) = (*alias)->next;\n+\t\t(*alias)->next = NULL;\n+\t}\n+\t(*alias)->key = malloc(separator_sign_pos - line + 1);\n+\tft_memcpy((*alias)->key, line, separator_sign_pos - line);\n+\t(*alias)->key[separator_sign_pos - line] = '\\0';\n+\t(*alias)->value = malloc(ft_strlen(separator_sign_pos));\n+\tft_memcpy((*alias)->value, separator_sign_pos + 1, \\\n+\tft_strlen(separator_sign_pos + 1));\n+\t(*alias)->value[ft_strlen(separator_sign_pos + 1)] = '\\0';\n+\t*first_elem = false;\n+}\n+\n+static void\tcopy_file_datas_in_aliases_list(struct s_alias *alias, int fd)\n+{\n+\tint\t\tret;\n+\tchar\t*line;\n+\tchar\t*separator_sign_pos;\n+\tbool\tfirst_elem;\n+\n+\tfirst_elem = true;\n+\twhile (\"there is still something to read\")\n+\t{\n+\t\tret = get_next_line(fd, &line);\n+\t\tif (ret == -1)\n+\t\t{\n+\t\t\tft_putstr_fd(\"42sh: error while loading .42sh_aliases\\n\", 2);\n+\t\t\treturn ;\n+\t\t}\n+\t\telse if (ret == 0)\n+\t\t\tbreak ;\n+\t\tseparator_sign_pos = ft_strchr(line, ' ');\n+\t\tif (separator_sign_pos != NULL)\n+\t\t\tdo_the_copy(separator_sign_pos, &first_elem, &alias, line);\n+\t\tfree(line);\n+\t}\n+}\n+\n+void\t\tload_aliases_file(struct s_alias *alias)\n+{\n+\tint\t\t\tfd;\n+\tconst char\t*alias_file_path = get_parsed_aliases_file_path();\n+\t\n+\tif (alias_file_path == NULL || check_backup_file(alias_file_path) == false\n+\t|| (fd = open(alias_file_path, O_RDONLY)) == -1)","path":"srcs/load_backup_files.c","position":70,"original_position":70,"commit_id":"e47ec736e0f21775e7bbd553e63003ab0a0f62f4","original_commit_id":"e47ec736e0f21775e7bbd553e63003ab0a0f62f4","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":" Code Smell: Remove any side effects from right hand operands of logical && or || operators. ([c:SideEffectInRightHandSideOfLogical](https://sonarcloud.io/organizations/jjaniec-github/rules#rule_key=c%3ASideEffectInRightHandSideOfLogical))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=jjaniec_21sh&pullRequest=41&issues=AWZjLzWHrFHbA8-Eo4Zr&open=AWZjLzWHrFHbA8-Eo4Zr)\n\n[ISSUE_KEY]: AWZjLzWHrFHbA8-Eo4Zr","created_at":"2018-10-11T12:59:08Z","updated_at":"2018-10-11T12:59:09Z","html_url":"https://github.com/jjaniec/21sh/pull/41#discussion_r224437190","pull_request_url":"https://api.github.com/repos/jjaniec/21sh/pulls/41","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/comments/224437190"},"html":{"href":"https://github.com/jjaniec/21sh/pull/41#discussion_r224437190"},"pull_request":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/jjaniec/21sh/pulls/41","id":221535718,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTM1NzE4","html_url":"https://github.com/jjaniec/21sh/pull/41","diff_url":"https://github.com/jjaniec/21sh/pull/41.diff","patch_url":"https://github.com/jjaniec/21sh/pull/41.patch","issue_url":"https://api.github.com/repos/jjaniec/21sh/issues/41","number":41,"state":"open","locked":false,"title":"Builtin alias","user":{"login":"Gamouche","id":22396445,"node_id":"MDQ6VXNlcjIyMzk2NDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/22396445?v=4","gravatar_id":"","url":"https://api.github.com/users/Gamouche","html_url":"https://github.com/Gamouche","followers_url":"https://api.github.com/users/Gamouche/followers","following_url":"https://api.github.com/users/Gamouche/following{/other_user}","gists_url":"https://api.github.com/users/Gamouche/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamouche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamouche/subscriptions","organizations_url":"https://api.github.com/users/Gamouche/orgs","repos_url":"https://api.github.com/users/Gamouche/repos","events_url":"https://api.github.com/users/Gamouche/events{/privacy}","received_events_url":"https://api.github.com/users/Gamouche/received_events","type":"User","site_admin":false},"body":"builtin alias :\r\n\r\n$ alias key value =>ajoute un alias temporaire pour la session courante\r\n$ alias --save => enregistre les alias dans un fichier qui est charge au lancement du shell\r\n$ alias => affiche les alias courants\r\n$ alias -d key => delete un alias de maniere temporaire (--save pour que le changement soit persistant)\r\n","created_at":"2018-10-09T18:13:49Z","updated_at":"2018-10-11T12:59:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84db5feebb75dc147d1120c38740d991ad7a0c51","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jjaniec/21sh/pulls/41/commits","review_comments_url":"https://api.github.com/repos/jjaniec/21sh/pulls/41/comments","review_comment_url":"https://api.github.com/repos/jjaniec/21sh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jjaniec/21sh/issues/41/comments","statuses_url":"https://api.github.com/repos/jjaniec/21sh/statuses/e47ec736e0f21775e7bbd553e63003ab0a0f62f4","head":{"label":"jjaniec:builtin_alias","ref":"builtin_alias","sha":"e47ec736e0f21775e7bbd553e63003ab0a0f62f4","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"repo":{"id":133548605,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NDg2MDU=","name":"21sh","full_name":"jjaniec/21sh","private":false,"owner":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjaniec/21sh","description":"Our own shell - wip","fork":false,"url":"https://api.github.com/repos/jjaniec/21sh","forks_url":"https://api.github.com/repos/jjaniec/21sh/forks","keys_url":"https://api.github.com/repos/jjaniec/21sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjaniec/21sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjaniec/21sh/teams","hooks_url":"https://api.github.com/repos/jjaniec/21sh/hooks","issue_events_url":"https://api.github.com/repos/jjaniec/21sh/issues/events{/number}","events_url":"https://api.github.com/repos/jjaniec/21sh/events","assignees_url":"https://api.github.com/repos/jjaniec/21sh/assignees{/user}","branches_url":"https://api.github.com/repos/jjaniec/21sh/branches{/branch}","tags_url":"https://api.github.com/repos/jjaniec/21sh/tags","blobs_url":"https://api.github.com/repos/jjaniec/21sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjaniec/21sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjaniec/21sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjaniec/21sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjaniec/21sh/statuses/{sha}","languages_url":"https://api.github.com/repos/jjaniec/21sh/languages","stargazers_url":"https://api.github.com/repos/jjaniec/21sh/stargazers","contributors_url":"https://api.github.com/repos/jjaniec/21sh/contributors","subscribers_url":"https://api.github.com/repos/jjaniec/21sh/subscribers","subscription_url":"https://api.github.com/repos/jjaniec/21sh/subscription","commits_url":"https://api.github.com/repos/jjaniec/21sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjaniec/21sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjaniec/21sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjaniec/21sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjaniec/21sh/contents/{+path}","compare_url":"https://api.github.com/repos/jjaniec/21sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjaniec/21sh/merges","archive_url":"https://api.github.com/repos/jjaniec/21sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjaniec/21sh/downloads","issues_url":"https://api.github.com/repos/jjaniec/21sh/issues{/number}","pulls_url":"https://api.github.com/repos/jjaniec/21sh/pulls{/number}","milestones_url":"https://api.github.com/repos/jjaniec/21sh/milestones{/number}","notifications_url":"https://api.github.com/repos/jjaniec/21sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjaniec/21sh/labels{/name}","releases_url":"https://api.github.com/repos/jjaniec/21sh/releases{/id}","deployments_url":"https://api.github.com/repos/jjaniec/21sh/deployments","created_at":"2018-05-15T17:10:47Z","updated_at":"2018-10-11T12:08:20Z","pushed_at":"2018-10-11T12:51:06Z","git_url":"git://github.com/jjaniec/21sh.git","ssh_url":"[email protected]:jjaniec/21sh.git","clone_url":"https://github.com/jjaniec/21sh.git","svn_url":"https://github.com/jjaniec/21sh","homepage":"","size":2729,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":3,"default_branch":"develop"}},"base":{"label":"jjaniec:develop","ref":"develop","sha":"5410530d38d50371adc5d00192e0dfb955b093a1","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"repo":{"id":133548605,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NDg2MDU=","name":"21sh","full_name":"jjaniec/21sh","private":false,"owner":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjaniec/21sh","description":"Our own shell - wip","fork":false,"url":"https://api.github.com/repos/jjaniec/21sh","forks_url":"https://api.github.com/repos/jjaniec/21sh/forks","keys_url":"https://api.github.com/repos/jjaniec/21sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjaniec/21sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjaniec/21sh/teams","hooks_url":"https://api.github.com/repos/jjaniec/21sh/hooks","issue_events_url":"https://api.github.com/repos/jjaniec/21sh/issues/events{/number}","events_url":"https://api.github.com/repos/jjaniec/21sh/events","assignees_url":"https://api.github.com/repos/jjaniec/21sh/assignees{/user}","branches_url":"https://api.github.com/repos/jjaniec/21sh/branches{/branch}","tags_url":"https://api.github.com/repos/jjaniec/21sh/tags","blobs_url":"https://api.github.com/repos/jjaniec/21sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjaniec/21sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjaniec/21sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjaniec/21sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjaniec/21sh/statuses/{sha}","languages_url":"https://api.github.com/repos/jjaniec/21sh/languages","stargazers_url":"https://api.github.com/repos/jjaniec/21sh/stargazers","contributors_url":"https://api.github.com/repos/jjaniec/21sh/contributors","subscribers_url":"https://api.github.com/repos/jjaniec/21sh/subscribers","subscription_url":"https://api.github.com/repos/jjaniec/21sh/subscription","commits_url":"https://api.github.com/repos/jjaniec/21sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjaniec/21sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjaniec/21sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjaniec/21sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjaniec/21sh/contents/{+path}","compare_url":"https://api.github.com/repos/jjaniec/21sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjaniec/21sh/merges","archive_url":"https://api.github.com/repos/jjaniec/21sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjaniec/21sh/downloads","issues_url":"https://api.github.com/repos/jjaniec/21sh/issues{/number}","pulls_url":"https://api.github.com/repos/jjaniec/21sh/pulls{/number}","milestones_url":"https://api.github.com/repos/jjaniec/21sh/milestones{/number}","notifications_url":"https://api.github.com/repos/jjaniec/21sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjaniec/21sh/labels{/name}","releases_url":"https://api.github.com/repos/jjaniec/21sh/releases{/id}","deployments_url":"https://api.github.com/repos/jjaniec/21sh/deployments","created_at":"2018-05-15T17:10:47Z","updated_at":"2018-10-11T12:08:20Z","pushed_at":"2018-10-11T12:51:06Z","git_url":"git://github.com/jjaniec/21sh.git","ssh_url":"[email protected]:jjaniec/21sh.git","clone_url":"https://github.com/jjaniec/21sh.git","svn_url":"https://github.com/jjaniec/21sh","homepage":"","size":2729,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/41"},"html":{"href":"https://github.com/jjaniec/21sh/pull/41"},"issue":{"href":"https://api.github.com/repos/jjaniec/21sh/issues/41"},"comments":{"href":"https://api.github.com/repos/jjaniec/21sh/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jjaniec/21sh/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/jjaniec/21sh/statuses/e47ec736e0f21775e7bbd553e63003ab0a0f62f4"}},"author_association":"COLLABORATOR"}} | {
"id": 133548605,
"name": "jjaniec/21sh",
"url": "https://api.github.com/repos/jjaniec/21sh"
} | {
"id": 39514782,
"login": "sonarcloud[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/39514782?",
"url": "https://api.github.com/users/sonarcloud[bot]"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-10-11T12:59:08 | 8404488655 | {"actor":{"display_login":"sonarcloud"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/comments/213119165","pull_request_review_id":149888950,"id":213119165,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzExOTE2NQ==","diff_hunk":"@@ -0,0 +1,131 @@\n+\\documentclass[fr]{../../../../../../eplexam}\n+\\usepackage{../../../../../../eplcommon}\n+\\usepackage{../../../../../../eplunits}\n+\n+\\newcommand{\\degree}{^{\\circ}}\n+\n+\\hypertitle[']{Automatique Linéaire}{6}{INMA}{1510}{2018}{Aout}{Majeure}\n+{Luis Tascon Gutierrez}\n+{Denis Dochain}\n+\n+\\section{}\n+\n+Vélo\n+\n+Idem question 4 de Juin 2015 mais avec plus de paramètres\\dots\n+\n+Il n'a demandé que de trouver la fonction de transfert et les conditions d'équilibre mais il y avait plus de conditions qu'en 2015.\n+\n+\\nosolution\n+\n+\\newpage\n+\\section{}\n+La dynamique d'un circuit composé d'une diode tunnel peut être représentée par:\n+\\begin{gather*}\n+\\begin{aligned}\n+\\dot{x}_1 &= x_2 -h(x_1)\\\\\n+\\dot{x}_2 &= -x_1 -ux_2 + E\n+\\end{aligned}\n+\\end{gather*}\n+\n+La variable $x_1$ représente la tension aux bornes de la capacité du circuit. $x_2$ est le courant passant dans l'inductance du circuit. $E$ représente la tension externe et $u$ la tension aux bornes de la résistance du circuit.\n+\\begin{equation*}\n+\th(x_1) = 2x_1^3-6x_1^2+5x_1\n+\\end{equation*}\n+On a également les valeurs de $E = 1,5$ et $u= 0,5$\n+\\begin{enumerate}\n+\t\\item Déterminez le(s) point(s) d'équilibre du circuit.\n+\t\\item Pour chaque état d'équilibre, analysez la stabilité.\n+\\end{enumerate}\n+\n+\\nosolution\n+\n+\\newpage\n+\\section{}\n+\n+Soit la fonction de transfert $$G(s) = \\dfrac{1}{s(s^2+0.02s+0.1)}$$\n+avec les graphes suivants:\n+\n+\\begin{figure}[!h]\n+\t\\centering\n+\t\\includegraphics[scale=0.5]{bodePlot}\n+\t\\caption{Pm = at and Gm = at }%TODO to complete\n+\\end{figure}\n+\n+Trouvez le paramètre k0 (prémultiplicateur du compensateur) et les paramètres du compensateur à avance de phase pour qu'on ait dans le système en boucle fermée:\n+\n+$\\Phi_M = \\ang{85}$ à la fréquence $w = 0.01$ rad/sec.\n+\n+\\nosolution\n+\n+\n+\\newpage\n+\\section{}\n+On a la fonction de transfert $G(s) = \\dfrac{5 e^{-2 s}}{0.25 s + 1} $.\n+\n+On souhaite n'avoir qu'un seul pôle en $-5$.\n+\\begin{enumerate}\n+\t\\item Quel contrôleur $C(s)$ faut-il employer? À quoi faut-il faire attention?\n+\t\\item En utilisant la même forme de compensateur qu'au point 1, synthétiser une loi de commande qui permette d'éliminer les effets négatifs sur le comportement en boucle fermée. Comment se nomme cette loi de commande? Quelles précautions devez-vous prendre?\n+\t\\item Analyser la stabilité en boucle fermée pour les points 1 et 2. Quelles sont vos conclusions?\n+\t\\item Pour la deuxième configuration, vous avez fait la synthèse en pensant que le retard était 0.4 (alors que sa vraie valeur est bien 2). Analysez la stabilité du système en boucle fermée dans ce cas de figure.\n+\\end{enumerate}\n+\n+Si, à un moment donné de votre démarche, vous devez approximer le retard, utilisez l'approximation de Taylor. \n+\n+Justifiez vos réponses.\n+\n+PS: idem Juin majeure 2017","path":"src/q6/autolin-INMA1510/exam/2018/Aout/Majeure/autolin-INMA1510-exam-2018-Aout-Majeure.tex","position":78,"original_position":78,"commit_id":"02046ee8bacf015ae5bcb47f229cd0ef60c4eb10","original_commit_id":"02046ee8bacf015ae5bcb47f229cd0ef60c4eb10","user":{"login":"MartinBraquet","id":25173236,"node_id":"MDQ6VXNlcjI1MTczMjM2","avatar_url":"https://avatars2.githubusercontent.com/u/25173236?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinBraquet","html_url":"https://github.com/MartinBraquet","followers_url":"https://api.github.com/users/MartinBraquet/followers","following_url":"https://api.github.com/users/MartinBraquet/following{/other_user}","gists_url":"https://api.github.com/users/MartinBraquet/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinBraquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinBraquet/subscriptions","organizations_url":"https://api.github.com/users/MartinBraquet/orgs","repos_url":"https://api.github.com/users/MartinBraquet/repos","events_url":"https://api.github.com/users/MartinBraquet/events{/privacy}","received_events_url":"https://api.github.com/users/MartinBraquet/received_events","type":"User","site_admin":false},"body":"Cette question est identique à ...\r\nTu peux peut-être le mettre en début d'énoncé.","created_at":"2018-08-27T21:19:32Z","updated_at":"2018-08-27T21:19:33Z","html_url":"https://github.com/Gp2mv3/Syntheses/pull/600#discussion_r213119165","pull_request_url":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/600","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/comments/213119165"},"html":{"href":"https://github.com/Gp2mv3/Syntheses/pull/600#discussion_r213119165"},"pull_request":{"href":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/600"}}},"pull_request":{"url":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/600","id":211106332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTA2MzMy","html_url":"https://github.com/Gp2mv3/Syntheses/pull/600","diff_url":"https://github.com/Gp2mv3/Syntheses/pull/600.diff","patch_url":"https://github.com/Gp2mv3/Syntheses/pull/600.patch","issue_url":"https://api.github.com/repos/Gp2mv3/Syntheses/issues/600","number":600,"state":"open","locked":false,"title":"Automatique linéaires Examens","user":{"login":"TGLuis","id":14812871,"node_id":"MDQ6VXNlcjE0ODEyODcx","avatar_url":"https://avatars0.githubusercontent.com/u/14812871?v=4","gravatar_id":"","url":"https://api.github.com/users/TGLuis","html_url":"https://github.com/TGLuis","followers_url":"https://api.github.com/users/TGLuis/followers","following_url":"https://api.github.com/users/TGLuis/following{/other_user}","gists_url":"https://api.github.com/users/TGLuis/gists{/gist_id}","starred_url":"https://api.github.com/users/TGLuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGLuis/subscriptions","organizations_url":"https://api.github.com/users/TGLuis/orgs","repos_url":"https://api.github.com/users/TGLuis/repos","events_url":"https://api.github.com/users/TGLuis/events{/privacy}","received_events_url":"https://api.github.com/users/TGLuis/received_events","type":"User","site_admin":false},"body":"Quelques corrections orthographiques des examens précédents.\r\nAjout de l'examen d'aout majeure 2018.","created_at":"2018-08-27T13:15:50Z","updated_at":"2018-08-27T21:19:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f467b879040d39df00bf42fddf536c2d862479d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1028299476,"node_id":"MDU6TGFiZWwxMDI4Mjk5NDc2","url":"https://api.github.com/repos/Gp2mv3/Syntheses/labels/Ajout","name":"Ajout","color":"cc7ae8","default":false},{"id":47430440,"node_id":"MDU6TGFiZWw0NzQzMDQ0MA==","url":"https://api.github.com/repos/Gp2mv3/Syntheses/labels/Am%C3%A9lioration","name":"Amélioration","color":"207de5","default":false},{"id":47430483,"node_id":"MDU6TGFiZWw0NzQzMDQ4Mw==","url":"https://api.github.com/repos/Gp2mv3/Syntheses/labels/Fautes%20d'orthographe","name":"Fautes d'orthographe","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/600/commits","review_comments_url":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/600/comments","review_comment_url":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Gp2mv3/Syntheses/issues/600/comments","statuses_url":"https://api.github.com/repos/Gp2mv3/Syntheses/statuses/02046ee8bacf015ae5bcb47f229cd0ef60c4eb10","head":{"label":"TGLuis:master","ref":"master","sha":"02046ee8bacf015ae5bcb47f229cd0ef60c4eb10","user":{"login":"TGLuis","id":14812871,"node_id":"MDQ6VXNlcjE0ODEyODcx","avatar_url":"https://avatars0.githubusercontent.com/u/14812871?v=4","gravatar_id":"","url":"https://api.github.com/users/TGLuis","html_url":"https://github.com/TGLuis","followers_url":"https://api.github.com/users/TGLuis/followers","following_url":"https://api.github.com/users/TGLuis/following{/other_user}","gists_url":"https://api.github.com/users/TGLuis/gists{/gist_id}","starred_url":"https://api.github.com/users/TGLuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGLuis/subscriptions","organizations_url":"https://api.github.com/users/TGLuis/orgs","repos_url":"https://api.github.com/users/TGLuis/repos","events_url":"https://api.github.com/users/TGLuis/events{/privacy}","received_events_url":"https://api.github.com/users/TGLuis/received_events","type":"User","site_admin":false},"repo":{"id":59489684,"node_id":"MDEwOlJlcG9zaXRvcnk1OTQ4OTY4NA==","name":"Syntheses","full_name":"TGLuis/Syntheses","owner":{"login":"TGLuis","id":14812871,"node_id":"MDQ6VXNlcjE0ODEyODcx","avatar_url":"https://avatars0.githubusercontent.com/u/14812871?v=4","gravatar_id":"","url":"https://api.github.com/users/TGLuis","html_url":"https://github.com/TGLuis","followers_url":"https://api.github.com/users/TGLuis/followers","following_url":"https://api.github.com/users/TGLuis/following{/other_user}","gists_url":"https://api.github.com/users/TGLuis/gists{/gist_id}","starred_url":"https://api.github.com/users/TGLuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGLuis/subscriptions","organizations_url":"https://api.github.com/users/TGLuis/orgs","repos_url":"https://api.github.com/users/TGLuis/repos","events_url":"https://api.github.com/users/TGLuis/events{/privacy}","received_events_url":"https://api.github.com/users/TGLuis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TGLuis/Syntheses","description":"Synthèses et travaux pour l'EPL","fork":true,"url":"https://api.github.com/repos/TGLuis/Syntheses","forks_url":"https://api.github.com/repos/TGLuis/Syntheses/forks","keys_url":"https://api.github.com/repos/TGLuis/Syntheses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TGLuis/Syntheses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TGLuis/Syntheses/teams","hooks_url":"https://api.github.com/repos/TGLuis/Syntheses/hooks","issue_events_url":"https://api.github.com/repos/TGLuis/Syntheses/issues/events{/number}","events_url":"https://api.github.com/repos/TGLuis/Syntheses/events","assignees_url":"https://api.github.com/repos/TGLuis/Syntheses/assignees{/user}","branches_url":"https://api.github.com/repos/TGLuis/Syntheses/branches{/branch}","tags_url":"https://api.github.com/repos/TGLuis/Syntheses/tags","blobs_url":"https://api.github.com/repos/TGLuis/Syntheses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TGLuis/Syntheses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TGLuis/Syntheses/git/refs{/sha}","trees_url":"https://api.github.com/repos/TGLuis/Syntheses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TGLuis/Syntheses/statuses/{sha}","languages_url":"https://api.github.com/repos/TGLuis/Syntheses/languages","stargazers_url":"https://api.github.com/repos/TGLuis/Syntheses/stargazers","contributors_url":"https://api.github.com/repos/TGLuis/Syntheses/contributors","subscribers_url":"https://api.github.com/repos/TGLuis/Syntheses/subscribers","subscription_url":"https://api.github.com/repos/TGLuis/Syntheses/subscription","commits_url":"https://api.github.com/repos/TGLuis/Syntheses/commits{/sha}","git_commits_url":"https://api.github.com/repos/TGLuis/Syntheses/git/commits{/sha}","comments_url":"https://api.github.com/repos/TGLuis/Syntheses/comments{/number}","issue_comment_url":"https://api.github.com/repos/TGLuis/Syntheses/issues/comments{/number}","contents_url":"https://api.github.com/repos/TGLuis/Syntheses/contents/{+path}","compare_url":"https://api.github.com/repos/TGLuis/Syntheses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TGLuis/Syntheses/merges","archive_url":"https://api.github.com/repos/TGLuis/Syntheses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TGLuis/Syntheses/downloads","issues_url":"https://api.github.com/repos/TGLuis/Syntheses/issues{/number}","pulls_url":"https://api.github.com/repos/TGLuis/Syntheses/pulls{/number}","milestones_url":"https://api.github.com/repos/TGLuis/Syntheses/milestones{/number}","notifications_url":"https://api.github.com/repos/TGLuis/Syntheses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TGLuis/Syntheses/labels{/name}","releases_url":"https://api.github.com/repos/TGLuis/Syntheses/releases{/id}","deployments_url":"https://api.github.com/repos/TGLuis/Syntheses/deployments","created_at":"2016-05-23T14:29:28Z","updated_at":"2018-08-27T16:31:01Z","pushed_at":"2018-08-27T16:30:58Z","git_url":"git://github.com/TGLuis/Syntheses.git","ssh_url":"[email protected]:TGLuis/Syntheses.git","clone_url":"https://github.com/TGLuis/Syntheses.git","svn_url":"https://github.com/TGLuis/Syntheses","homepage":"","size":221459,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Gp2mv3:master","ref":"master","sha":"87ab9bedca3c19c34275dd9b647fa476847a221f","user":{"login":"Gp2mv3","id":1221806,"node_id":"MDQ6VXNlcjEyMjE4MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1221806?v=4","gravatar_id":"","url":"https://api.github.com/users/Gp2mv3","html_url":"https://github.com/Gp2mv3","followers_url":"https://api.github.com/users/Gp2mv3/followers","following_url":"https://api.github.com/users/Gp2mv3/following{/other_user}","gists_url":"https://api.github.com/users/Gp2mv3/gists{/gist_id}","starred_url":"https://api.github.com/users/Gp2mv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gp2mv3/subscriptions","organizations_url":"https://api.github.com/users/Gp2mv3/orgs","repos_url":"https://api.github.com/users/Gp2mv3/repos","events_url":"https://api.github.com/users/Gp2mv3/events{/privacy}","received_events_url":"https://api.github.com/users/Gp2mv3/received_events","type":"User","site_admin":false},"repo":{"id":2855356,"node_id":"MDEwOlJlcG9zaXRvcnkyODU1MzU2","name":"Syntheses","full_name":"Gp2mv3/Syntheses","owner":{"login":"Gp2mv3","id":1221806,"node_id":"MDQ6VXNlcjEyMjE4MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1221806?v=4","gravatar_id":"","url":"https://api.github.com/users/Gp2mv3","html_url":"https://github.com/Gp2mv3","followers_url":"https://api.github.com/users/Gp2mv3/followers","following_url":"https://api.github.com/users/Gp2mv3/following{/other_user}","gists_url":"https://api.github.com/users/Gp2mv3/gists{/gist_id}","starred_url":"https://api.github.com/users/Gp2mv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gp2mv3/subscriptions","organizations_url":"https://api.github.com/users/Gp2mv3/orgs","repos_url":"https://api.github.com/users/Gp2mv3/repos","events_url":"https://api.github.com/users/Gp2mv3/events{/privacy}","received_events_url":"https://api.github.com/users/Gp2mv3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gp2mv3/Syntheses","description":"Synthèses et travaux pour l'EPL","fork":false,"url":"https://api.github.com/repos/Gp2mv3/Syntheses","forks_url":"https://api.github.com/repos/Gp2mv3/Syntheses/forks","keys_url":"https://api.github.com/repos/Gp2mv3/Syntheses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gp2mv3/Syntheses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gp2mv3/Syntheses/teams","hooks_url":"https://api.github.com/repos/Gp2mv3/Syntheses/hooks","issue_events_url":"https://api.github.com/repos/Gp2mv3/Syntheses/issues/events{/number}","events_url":"https://api.github.com/repos/Gp2mv3/Syntheses/events","assignees_url":"https://api.github.com/repos/Gp2mv3/Syntheses/assignees{/user}","branches_url":"https://api.github.com/repos/Gp2mv3/Syntheses/branches{/branch}","tags_url":"https://api.github.com/repos/Gp2mv3/Syntheses/tags","blobs_url":"https://api.github.com/repos/Gp2mv3/Syntheses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gp2mv3/Syntheses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gp2mv3/Syntheses/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gp2mv3/Syntheses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gp2mv3/Syntheses/statuses/{sha}","languages_url":"https://api.github.com/repos/Gp2mv3/Syntheses/languages","stargazers_url":"https://api.github.com/repos/Gp2mv3/Syntheses/stargazers","contributors_url":"https://api.github.com/repos/Gp2mv3/Syntheses/contributors","subscribers_url":"https://api.github.com/repos/Gp2mv3/Syntheses/subscribers","subscription_url":"https://api.github.com/repos/Gp2mv3/Syntheses/subscription","commits_url":"https://api.github.com/repos/Gp2mv3/Syntheses/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gp2mv3/Syntheses/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gp2mv3/Syntheses/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gp2mv3/Syntheses/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gp2mv3/Syntheses/contents/{+path}","compare_url":"https://api.github.com/repos/Gp2mv3/Syntheses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gp2mv3/Syntheses/merges","archive_url":"https://api.github.com/repos/Gp2mv3/Syntheses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gp2mv3/Syntheses/downloads","issues_url":"https://api.github.com/repos/Gp2mv3/Syntheses/issues{/number}","pulls_url":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls{/number}","milestones_url":"https://api.github.com/repos/Gp2mv3/Syntheses/milestones{/number}","notifications_url":"https://api.github.com/repos/Gp2mv3/Syntheses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gp2mv3/Syntheses/labels{/name}","releases_url":"https://api.github.com/repos/Gp2mv3/Syntheses/releases{/id}","deployments_url":"https://api.github.com/repos/Gp2mv3/Syntheses/deployments","created_at":"2011-11-26T12:03:05Z","updated_at":"2018-08-27T21:16:27Z","pushed_at":"2018-08-27T21:16:23Z","git_url":"git://github.com/Gp2mv3/Syntheses.git","ssh_url":"[email protected]:Gp2mv3/Syntheses.git","clone_url":"https://github.com/Gp2mv3/Syntheses.git","svn_url":"https://github.com/Gp2mv3/Syntheses","homepage":"","size":221415,"stargazers_count":61,"watchers_count":61,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":141,"open_issues":26,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/600"},"html":{"href":"https://github.com/Gp2mv3/Syntheses/pull/600"},"issue":{"href":"https://api.github.com/repos/Gp2mv3/Syntheses/issues/600"},"comments":{"href":"https://api.github.com/repos/Gp2mv3/Syntheses/issues/600/comments"},"review_comments":{"href":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/600/comments"},"review_comment":{"href":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Gp2mv3/Syntheses/pulls/600/commits"},"statuses":{"href":"https://api.github.com/repos/Gp2mv3/Syntheses/statuses/02046ee8bacf015ae5bcb47f229cd0ef60c4eb10"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2855356,
"name": "Gp2mv3/Syntheses",
"url": "https://api.github.com/repos/Gp2mv3/Syntheses"
} | {
"id": 25173236,
"login": "MartinBraquet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25173236?",
"url": "https://api.github.com/users/MartinBraquet"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-08-27T21:19:32 | 8174508542 | {"actor":{"display_login":"MartinBraquet"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/friendica/friendica/pulls/comments/209681094","pull_request_review_id":145741155,"id":209681094,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTY4MTA5NA==","diff_hunk":"@@ -251,22 +255,20 @@ private static function logIndex($query) {\n \t}\n \n \tpublic static function escape($str) {\n-\t\tif (self::$connected) {\n-\t\t\tswitch (self::$driver) {\n-\t\t\t\tcase 'pdo':\n-\t\t\t\t\treturn substr(@self::$connection->quote($str, PDO::PARAM_STR), 1, -1);\n-\t\t\t\tcase 'mysqli':\n-\t\t\t\t\treturn @self::$connection->real_escape_string($str);\n-\t\t\t}\n-\t\t} else {","path":"src/Database/DBA.php","position":43,"original_position":43,"commit_id":"3d947d384e87ff4bd7601dbe6e5968212f4a22e1","original_commit_id":"3d947d384e87ff4bd7601dbe6e5968212f4a22e1","user":{"login":"Quix0r","id":470798,"node_id":"MDQ6VXNlcjQ3MDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/470798?v=4","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"body":"And good catch!","created_at":"2018-08-13T16:48:22Z","updated_at":"2018-08-13T16:48:22Z","html_url":"https://github.com/friendica/friendica/pull/5608#discussion_r209681094","pull_request_url":"https://api.github.com/repos/friendica/friendica/pulls/5608","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments/209681094"},"html":{"href":"https://github.com/friendica/friendica/pull/5608#discussion_r209681094"},"pull_request":{"href":"https://api.github.com/repos/friendica/friendica/pulls/5608"}},"in_reply_to_id":209486233},"pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/5608","id":207841204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODQxMjA0","html_url":"https://github.com/friendica/friendica/pull/5608","diff_url":"https://github.com/friendica/friendica/pull/5608.diff","patch_url":"https://github.com/friendica/friendica/pull/5608.patch","issue_url":"https://api.github.com/repos/friendica/friendica/issues/5608","number":5608,"state":"open","locked":false,"title":"Cleanups: isResult() more used, readability improved","user":{"login":"Quix0r","id":470798,"node_id":"MDQ6VXNlcjQ3MDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/470798?v=4","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"body":"This PR is an assortment of cleanups, like adding empty lines or spaces for improving readability. It also makes more use of `DBA::isResult()` in some places.\r\n\r\nOthers:\r\n- In `src/Worker/OnePoll.php` type-hints for `updateContact` has been added\r\n- In `src/Protocol/Diaspora.php` type-hint `SimpleXMLElement` added\r\n- remaining spaces converted to tabs in `mod/repair_ostatus.php` for indenting code\r\n","created_at":"2018-08-12T21:23:16Z","updated_at":"2018-08-13T16:48:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a7f0958919a1bdf7d5779fbb27d55ddcfae1ce5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/friendica/friendica/pulls/5608/commits","review_comments_url":"https://api.github.com/repos/friendica/friendica/pulls/5608/comments","review_comment_url":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/5608/comments","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/3d947d384e87ff4bd7601dbe6e5968212f4a22e1","head":{"label":"Quix0r:cleanups/is-result-readability","ref":"cleanups/is-result-readability","sha":"3d947d384e87ff4bd7601dbe6e5968212f4a22e1","user":{"login":"Quix0r","id":470798,"node_id":"MDQ6VXNlcjQ3MDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/470798?v=4","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"repo":{"id":52880546,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg4MDU0Ng==","name":"friendica","full_name":"Quix0r/friendica","owner":{"login":"Quix0r","id":470798,"node_id":"MDQ6VXNlcjQ3MDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/470798?v=4","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Quix0r/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/Quix0r/friendica","forks_url":"https://api.github.com/repos/Quix0r/friendica/forks","keys_url":"https://api.github.com/repos/Quix0r/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quix0r/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quix0r/friendica/teams","hooks_url":"https://api.github.com/repos/Quix0r/friendica/hooks","issue_events_url":"https://api.github.com/repos/Quix0r/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/Quix0r/friendica/events","assignees_url":"https://api.github.com/repos/Quix0r/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/Quix0r/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/Quix0r/friendica/tags","blobs_url":"https://api.github.com/repos/Quix0r/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quix0r/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quix0r/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quix0r/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quix0r/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/Quix0r/friendica/languages","stargazers_url":"https://api.github.com/repos/Quix0r/friendica/stargazers","contributors_url":"https://api.github.com/repos/Quix0r/friendica/contributors","subscribers_url":"https://api.github.com/repos/Quix0r/friendica/subscribers","subscription_url":"https://api.github.com/repos/Quix0r/friendica/subscription","commits_url":"https://api.github.com/repos/Quix0r/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quix0r/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quix0r/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quix0r/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/Quix0r/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/Quix0r/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quix0r/friendica/merges","archive_url":"https://api.github.com/repos/Quix0r/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quix0r/friendica/downloads","issues_url":"https://api.github.com/repos/Quix0r/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/Quix0r/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/Quix0r/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/Quix0r/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quix0r/friendica/labels{/name}","releases_url":"https://api.github.com/repos/Quix0r/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/Quix0r/friendica/deployments","created_at":"2016-03-01T13:56:00Z","updated_at":"2018-08-12T21:32:18Z","pushed_at":"2018-08-12T21:32:15Z","git_url":"git://github.com/Quix0r/friendica.git","ssh_url":"[email protected]:Quix0r/friendica.git","clone_url":"https://github.com/Quix0r/friendica.git","svn_url":"https://github.com/Quix0r/friendica","homepage":"http://friendi.ca/","size":104546,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"friendica:develop","ref":"develop","sha":"faefafd4f8ac1874a23fbb54589471b7b59bf431","user":{"login":"friendica","id":1176581,"node_id":"MDQ6VXNlcjExNzY1ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1176581?v=4","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"repo":{"id":2722709,"node_id":"MDEwOlJlcG9zaXRvcnkyNzIyNzA5","name":"friendica","full_name":"friendica/friendica","owner":{"login":"friendica","id":1176581,"node_id":"MDQ6VXNlcjExNzY1ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1176581?v=4","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/friendica/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/friendica/friendica","forks_url":"https://api.github.com/repos/friendica/friendica/forks","keys_url":"https://api.github.com/repos/friendica/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/friendica/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/friendica/friendica/teams","hooks_url":"https://api.github.com/repos/friendica/friendica/hooks","issue_events_url":"https://api.github.com/repos/friendica/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/friendica/friendica/events","assignees_url":"https://api.github.com/repos/friendica/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/friendica/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/friendica/friendica/tags","blobs_url":"https://api.github.com/repos/friendica/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/friendica/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/friendica/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/friendica/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/friendica/friendica/languages","stargazers_url":"https://api.github.com/repos/friendica/friendica/stargazers","contributors_url":"https://api.github.com/repos/friendica/friendica/contributors","subscribers_url":"https://api.github.com/repos/friendica/friendica/subscribers","subscription_url":"https://api.github.com/repos/friendica/friendica/subscription","commits_url":"https://api.github.com/repos/friendica/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/friendica/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/friendica/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/friendica/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/friendica/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/friendica/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/friendica/friendica/merges","archive_url":"https://api.github.com/repos/friendica/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/friendica/friendica/downloads","issues_url":"https://api.github.com/repos/friendica/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/friendica/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/friendica/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/friendica/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/friendica/friendica/labels{/name}","releases_url":"https://api.github.com/repos/friendica/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/friendica/friendica/deployments","created_at":"2011-11-06T22:19:41Z","updated_at":"2018-08-13T04:42:13Z","pushed_at":"2018-08-13T04:42:09Z","git_url":"git://github.com/friendica/friendica.git","ssh_url":"[email protected]:friendica/friendica.git","clone_url":"https://github.com/friendica/friendica.git","svn_url":"https://github.com/friendica/friendica","homepage":"https://friendi.ca","size":104513,"stargazers_count":617,"watchers_count":617,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":397,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":204,"open_issues":397,"watchers":617,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/5608"},"html":{"href":"https://github.com/friendica/friendica/pull/5608"},"issue":{"href":"https://api.github.com/repos/friendica/friendica/issues/5608"},"comments":{"href":"https://api.github.com/repos/friendica/friendica/issues/5608/comments"},"review_comments":{"href":"https://api.github.com/repos/friendica/friendica/pulls/5608/comments"},"review_comment":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/friendica/friendica/pulls/5608/commits"},"statuses":{"href":"https://api.github.com/repos/friendica/friendica/statuses/3d947d384e87ff4bd7601dbe6e5968212f4a22e1"}},"author_association":"NONE"}} | {
"id": 2722709,
"name": "friendica/friendica",
"url": "https://api.github.com/repos/friendica/friendica"
} | {
"id": 470798,
"login": "Quix0r",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/470798?",
"url": "https://api.github.com/users/Quix0r"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-08-13T16:48:22 | 8106220570 | {"actor":{"display_login":"Quix0r"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/comments/235916148","pull_request_review_id":177894828,"id":235916148,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTkxNjE0OA==","diff_hunk":"@@ -44,8 +44,14 @@\n <section class=\"content-section\">\n \t<div class=\"container\">\n \t\t<div class=\"row\" id=\"category\">\n-\t\t\t{{#each model as |categoryUnit|}}\n-\t\t\t\t{{category-list category=categoryUnit}}\n+\t\t\t{{#each model.galleries as |gallery|}}\n+ <div class=\"col-xs-10 col-xs-offset-1 col-sm-6 col-md-4 col-sm-offset-0\">\n+ {{#link-to \"galleries.gallery\" gallery.id class=\"small-break no-deco\"}}\n+ <img src={{gallery.pic}} class=\"img-responsive\">\n+ <h5 class=\"small-break\">{{gallery.title}}</h5>\n+ <p class=\"text-center\">{{gallery.description}}</p>\n+ {{/link-to}}\n+ </div>","path":"app/templates/index.hbs","position":null,"original_position":13,"commit_id":"5646c696b0e410c46bcc6969ae185ded78516371","original_commit_id":"debcb6b71b34ece0437e5fd48398c3e0bcd34b66","user":{"login":"westbee","id":13553875,"node_id":"MDQ6VXNlcjEzNTUzODc1","avatar_url":"https://avatars1.githubusercontent.com/u/13553875?v=4","gravatar_id":"","url":"https://api.github.com/users/westbee","html_url":"https://github.com/westbee","followers_url":"https://api.github.com/users/westbee/followers","following_url":"https://api.github.com/users/westbee/following{/other_user}","gists_url":"https://api.github.com/users/westbee/gists{/gist_id}","starred_url":"https://api.github.com/users/westbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westbee/subscriptions","organizations_url":"https://api.github.com/users/westbee/orgs","repos_url":"https://api.github.com/users/westbee/repos","events_url":"https://api.github.com/users/westbee/events{/privacy}","received_events_url":"https://api.github.com/users/westbee/received_events","type":"User","site_admin":false},"body":"I built a category-list component, so I can re-use this part anywhere.","created_at":"2018-11-23T11:39:36Z","updated_at":"2018-11-23T11:39:36Z","html_url":"https://github.com/westbee/ember-mrtwlk/pull/4#discussion_r235916148","pull_request_url":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/4","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/comments/235916148"},"html":{"href":"https://github.com/westbee/ember-mrtwlk/pull/4#discussion_r235916148"},"pull_request":{"href":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/4"}},"in_reply_to_id":234628715},"pull_request":{"url":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/4","id":230794079,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzk0MDc5","html_url":"https://github.com/westbee/ember-mrtwlk/pull/4","diff_url":"https://github.com/westbee/ember-mrtwlk/pull/4.diff","patch_url":"https://github.com/westbee/ember-mrtwlk/pull/4.patch","issue_url":"https://api.github.com/repos/westbee/ember-mrtwlk/issues/4","number":4,"state":"open","locked":false,"title":"I created multiple models but photos are not displayed","user":{"login":"westbee","id":13553875,"node_id":"MDQ6VXNlcjEzNTUzODc1","avatar_url":"https://avatars1.githubusercontent.com/u/13553875?v=4","gravatar_id":"","url":"https://api.github.com/users/westbee","html_url":"https://github.com/westbee","followers_url":"https://api.github.com/users/westbee/followers","following_url":"https://api.github.com/users/westbee/following{/other_user}","gists_url":"https://api.github.com/users/westbee/gists{/gist_id}","starred_url":"https://api.github.com/users/westbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westbee/subscriptions","organizations_url":"https://api.github.com/users/westbee/orgs","repos_url":"https://api.github.com/users/westbee/repos","events_url":"https://api.github.com/users/westbee/events{/privacy}","received_events_url":"https://api.github.com/users/westbee/received_events","type":"User","site_admin":false},"body":"According to your requirements, I created multiple models and used a dynamic segment to load a proper gallery model. Now I need a hint on how I can display photos in a gallery because it looks like something is missing when two models are present in the same gallery page. ","created_at":"2018-11-14T11:03:25Z","updated_at":"2018-11-23T11:39:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ffc9c4e003fcd8894f777c77a37472a14a3ea90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/4/commits","review_comments_url":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/4/comments","review_comment_url":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/westbee/ember-mrtwlk/issues/4/comments","statuses_url":"https://api.github.com/repos/westbee/ember-mrtwlk/statuses/5646c696b0e410c46bcc6969ae185ded78516371","head":{"label":"westbee:feature/gallery","ref":"feature/gallery","sha":"5646c696b0e410c46bcc6969ae185ded78516371","user":{"login":"westbee","id":13553875,"node_id":"MDQ6VXNlcjEzNTUzODc1","avatar_url":"https://avatars1.githubusercontent.com/u/13553875?v=4","gravatar_id":"","url":"https://api.github.com/users/westbee","html_url":"https://github.com/westbee","followers_url":"https://api.github.com/users/westbee/followers","following_url":"https://api.github.com/users/westbee/following{/other_user}","gists_url":"https://api.github.com/users/westbee/gists{/gist_id}","starred_url":"https://api.github.com/users/westbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westbee/subscriptions","organizations_url":"https://api.github.com/users/westbee/orgs","repos_url":"https://api.github.com/users/westbee/repos","events_url":"https://api.github.com/users/westbee/events{/privacy}","received_events_url":"https://api.github.com/users/westbee/received_events","type":"User","site_admin":false},"repo":{"id":153765023,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3NjUwMjM=","name":"ember-mrtwlk","full_name":"westbee/ember-mrtwlk","private":false,"owner":{"login":"westbee","id":13553875,"node_id":"MDQ6VXNlcjEzNTUzODc1","avatar_url":"https://avatars1.githubusercontent.com/u/13553875?v=4","gravatar_id":"","url":"https://api.github.com/users/westbee","html_url":"https://github.com/westbee","followers_url":"https://api.github.com/users/westbee/followers","following_url":"https://api.github.com/users/westbee/following{/other_user}","gists_url":"https://api.github.com/users/westbee/gists{/gist_id}","starred_url":"https://api.github.com/users/westbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westbee/subscriptions","organizations_url":"https://api.github.com/users/westbee/orgs","repos_url":"https://api.github.com/users/westbee/repos","events_url":"https://api.github.com/users/westbee/events{/privacy}","received_events_url":"https://api.github.com/users/westbee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/westbee/ember-mrtwlk","description":"building an ember app","fork":false,"url":"https://api.github.com/repos/westbee/ember-mrtwlk","forks_url":"https://api.github.com/repos/westbee/ember-mrtwlk/forks","keys_url":"https://api.github.com/repos/westbee/ember-mrtwlk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/westbee/ember-mrtwlk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/westbee/ember-mrtwlk/teams","hooks_url":"https://api.github.com/repos/westbee/ember-mrtwlk/hooks","issue_events_url":"https://api.github.com/repos/westbee/ember-mrtwlk/issues/events{/number}","events_url":"https://api.github.com/repos/westbee/ember-mrtwlk/events","assignees_url":"https://api.github.com/repos/westbee/ember-mrtwlk/assignees{/user}","branches_url":"https://api.github.com/repos/westbee/ember-mrtwlk/branches{/branch}","tags_url":"https://api.github.com/repos/westbee/ember-mrtwlk/tags","blobs_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/refs{/sha}","trees_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/westbee/ember-mrtwlk/statuses/{sha}","languages_url":"https://api.github.com/repos/westbee/ember-mrtwlk/languages","stargazers_url":"https://api.github.com/repos/westbee/ember-mrtwlk/stargazers","contributors_url":"https://api.github.com/repos/westbee/ember-mrtwlk/contributors","subscribers_url":"https://api.github.com/repos/westbee/ember-mrtwlk/subscribers","subscription_url":"https://api.github.com/repos/westbee/ember-mrtwlk/subscription","commits_url":"https://api.github.com/repos/westbee/ember-mrtwlk/commits{/sha}","git_commits_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/commits{/sha}","comments_url":"https://api.github.com/repos/westbee/ember-mrtwlk/comments{/number}","issue_comment_url":"https://api.github.com/repos/westbee/ember-mrtwlk/issues/comments{/number}","contents_url":"https://api.github.com/repos/westbee/ember-mrtwlk/contents/{+path}","compare_url":"https://api.github.com/repos/westbee/ember-mrtwlk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/westbee/ember-mrtwlk/merges","archive_url":"https://api.github.com/repos/westbee/ember-mrtwlk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/westbee/ember-mrtwlk/downloads","issues_url":"https://api.github.com/repos/westbee/ember-mrtwlk/issues{/number}","pulls_url":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls{/number}","milestones_url":"https://api.github.com/repos/westbee/ember-mrtwlk/milestones{/number}","notifications_url":"https://api.github.com/repos/westbee/ember-mrtwlk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/westbee/ember-mrtwlk/labels{/name}","releases_url":"https://api.github.com/repos/westbee/ember-mrtwlk/releases{/id}","deployments_url":"https://api.github.com/repos/westbee/ember-mrtwlk/deployments","created_at":"2018-10-19T10:18:22Z","updated_at":"2018-10-26T08:41:35Z","pushed_at":"2018-11-23T10:50:20Z","git_url":"git://github.com/westbee/ember-mrtwlk.git","ssh_url":"[email protected]:westbee/ember-mrtwlk.git","clone_url":"https://github.com/westbee/ember-mrtwlk.git","svn_url":"https://github.com/westbee/ember-mrtwlk","homepage":null,"size":402,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"westbee:develop","ref":"develop","sha":"a77bbc8bd7f0cdb2ecbc8abc67cd7bf77b0c172f","user":{"login":"westbee","id":13553875,"node_id":"MDQ6VXNlcjEzNTUzODc1","avatar_url":"https://avatars1.githubusercontent.com/u/13553875?v=4","gravatar_id":"","url":"https://api.github.com/users/westbee","html_url":"https://github.com/westbee","followers_url":"https://api.github.com/users/westbee/followers","following_url":"https://api.github.com/users/westbee/following{/other_user}","gists_url":"https://api.github.com/users/westbee/gists{/gist_id}","starred_url":"https://api.github.com/users/westbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westbee/subscriptions","organizations_url":"https://api.github.com/users/westbee/orgs","repos_url":"https://api.github.com/users/westbee/repos","events_url":"https://api.github.com/users/westbee/events{/privacy}","received_events_url":"https://api.github.com/users/westbee/received_events","type":"User","site_admin":false},"repo":{"id":153765023,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3NjUwMjM=","name":"ember-mrtwlk","full_name":"westbee/ember-mrtwlk","private":false,"owner":{"login":"westbee","id":13553875,"node_id":"MDQ6VXNlcjEzNTUzODc1","avatar_url":"https://avatars1.githubusercontent.com/u/13553875?v=4","gravatar_id":"","url":"https://api.github.com/users/westbee","html_url":"https://github.com/westbee","followers_url":"https://api.github.com/users/westbee/followers","following_url":"https://api.github.com/users/westbee/following{/other_user}","gists_url":"https://api.github.com/users/westbee/gists{/gist_id}","starred_url":"https://api.github.com/users/westbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westbee/subscriptions","organizations_url":"https://api.github.com/users/westbee/orgs","repos_url":"https://api.github.com/users/westbee/repos","events_url":"https://api.github.com/users/westbee/events{/privacy}","received_events_url":"https://api.github.com/users/westbee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/westbee/ember-mrtwlk","description":"building an ember app","fork":false,"url":"https://api.github.com/repos/westbee/ember-mrtwlk","forks_url":"https://api.github.com/repos/westbee/ember-mrtwlk/forks","keys_url":"https://api.github.com/repos/westbee/ember-mrtwlk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/westbee/ember-mrtwlk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/westbee/ember-mrtwlk/teams","hooks_url":"https://api.github.com/repos/westbee/ember-mrtwlk/hooks","issue_events_url":"https://api.github.com/repos/westbee/ember-mrtwlk/issues/events{/number}","events_url":"https://api.github.com/repos/westbee/ember-mrtwlk/events","assignees_url":"https://api.github.com/repos/westbee/ember-mrtwlk/assignees{/user}","branches_url":"https://api.github.com/repos/westbee/ember-mrtwlk/branches{/branch}","tags_url":"https://api.github.com/repos/westbee/ember-mrtwlk/tags","blobs_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/refs{/sha}","trees_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/westbee/ember-mrtwlk/statuses/{sha}","languages_url":"https://api.github.com/repos/westbee/ember-mrtwlk/languages","stargazers_url":"https://api.github.com/repos/westbee/ember-mrtwlk/stargazers","contributors_url":"https://api.github.com/repos/westbee/ember-mrtwlk/contributors","subscribers_url":"https://api.github.com/repos/westbee/ember-mrtwlk/subscribers","subscription_url":"https://api.github.com/repos/westbee/ember-mrtwlk/subscription","commits_url":"https://api.github.com/repos/westbee/ember-mrtwlk/commits{/sha}","git_commits_url":"https://api.github.com/repos/westbee/ember-mrtwlk/git/commits{/sha}","comments_url":"https://api.github.com/repos/westbee/ember-mrtwlk/comments{/number}","issue_comment_url":"https://api.github.com/repos/westbee/ember-mrtwlk/issues/comments{/number}","contents_url":"https://api.github.com/repos/westbee/ember-mrtwlk/contents/{+path}","compare_url":"https://api.github.com/repos/westbee/ember-mrtwlk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/westbee/ember-mrtwlk/merges","archive_url":"https://api.github.com/repos/westbee/ember-mrtwlk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/westbee/ember-mrtwlk/downloads","issues_url":"https://api.github.com/repos/westbee/ember-mrtwlk/issues{/number}","pulls_url":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls{/number}","milestones_url":"https://api.github.com/repos/westbee/ember-mrtwlk/milestones{/number}","notifications_url":"https://api.github.com/repos/westbee/ember-mrtwlk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/westbee/ember-mrtwlk/labels{/name}","releases_url":"https://api.github.com/repos/westbee/ember-mrtwlk/releases{/id}","deployments_url":"https://api.github.com/repos/westbee/ember-mrtwlk/deployments","created_at":"2018-10-19T10:18:22Z","updated_at":"2018-10-26T08:41:35Z","pushed_at":"2018-11-23T10:50:20Z","git_url":"git://github.com/westbee/ember-mrtwlk.git","ssh_url":"[email protected]:westbee/ember-mrtwlk.git","clone_url":"https://github.com/westbee/ember-mrtwlk.git","svn_url":"https://github.com/westbee/ember-mrtwlk","homepage":null,"size":402,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/4"},"html":{"href":"https://github.com/westbee/ember-mrtwlk/pull/4"},"issue":{"href":"https://api.github.com/repos/westbee/ember-mrtwlk/issues/4"},"comments":{"href":"https://api.github.com/repos/westbee/ember-mrtwlk/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/westbee/ember-mrtwlk/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/westbee/ember-mrtwlk/statuses/5646c696b0e410c46bcc6969ae185ded78516371"}},"author_association":"OWNER"}} | {
"id": 153765023,
"name": "westbee/ember-mrtwlk",
"url": "https://api.github.com/repos/westbee/ember-mrtwlk"
} | {
"id": 13553875,
"login": "westbee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13553875?",
"url": "https://api.github.com/users/westbee"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-11-23T11:39:36 | 8637549715 | {"actor":{"display_login":"westbee"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/comments/205678571","pull_request_review_id":140996131,"id":205678571,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTY3ODU3MQ==","diff_hunk":"@@ -31,12 +34,44 @@ public void onAfter() {\n @Test\n public void getSignTextTest() {\n //Given\n- board.insertSign(PlayerSignType.X, 1, 1);\n+ board.insertSign(PlayerSignType.X, size - 1, size - 1);\n+\n //When\n- boolean result = board.getSignText(1,1) == \"X\";\n+ String result = board.getSignText(size - 1, size - 1);\n \n //Then\n- assertTrue(result);\n+ assertEquals(\"X\", result);\n+\n+ }\n+\n+ @Test\n+ public void getSignTextTestXchangedToO() {\n+ //Given\n+ board.insertSign(PlayerSignType.X, size - 1, size - 1);\n+\n+ //When\n+ board.insertSign(PlayerSignType.O, size - 1, size - 1);\n+ String result = board.getSignText(size - 1, size - 1);\n+\n+ //Then\n+ assertEquals(\"X\", result);\n+\n+ }\n+\n+ @Test\n+ public void TestListenerWhenWin() {\n+ //Given\n+ for (int i = 0; i < size - 1; i++) {\n+ board.insertSign(PlayerSignType.X, i, size - 1);\n+ }\n+\n+ //When\n+ Boolean winner = board.insertSign(PlayerSignType.X, size - 1, size - 1);\n+ String result = onEndGameListener.toString();","path":"src/com/company/tests/BoardTest.java","position":70,"original_position":68,"commit_id":"952a15887ecd972f14dd90b8ce5c48d6fd54ec96","original_commit_id":"952a15887ecd972f14dd90b8ce5c48d6fd54ec96","user":{"login":"mkruczkowski","id":24889282,"node_id":"MDQ6VXNlcjI0ODg5Mjgy","avatar_url":"https://avatars2.githubusercontent.com/u/24889282?v=4","gravatar_id":"","url":"https://api.github.com/users/mkruczkowski","html_url":"https://github.com/mkruczkowski","followers_url":"https://api.github.com/users/mkruczkowski/followers","following_url":"https://api.github.com/users/mkruczkowski/following{/other_user}","gists_url":"https://api.github.com/users/mkruczkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mkruczkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkruczkowski/subscriptions","organizations_url":"https://api.github.com/users/mkruczkowski/orgs","repos_url":"https://api.github.com/users/mkruczkowski/repos","events_url":"https://api.github.com/users/mkruczkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mkruczkowski/received_events","type":"User","site_admin":false},"body":"???? a to po co? ","created_at":"2018-07-27T06:26:41Z","updated_at":"2018-07-27T06:32:38Z","html_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross/pull/12#discussion_r205678571","pull_request_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/comments/205678571"},"html":{"href":"https://github.com/KatarzynaKruczkowska/CircleAndCross/pull/12#discussion_r205678571"},"pull_request":{"href":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/12","id":204112963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTEyOTYz","html_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross/pull/12","diff_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross/pull/12.diff","patch_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross/pull/12.patch","issue_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues/12","number":12,"state":"open","locked":false,"title":"26-07-2018 Board test","user":{"login":"KatarzynaKruczkowska","id":38396769,"node_id":"MDQ6VXNlcjM4Mzk2NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/38396769?v=4","gravatar_id":"","url":"https://api.github.com/users/KatarzynaKruczkowska","html_url":"https://github.com/KatarzynaKruczkowska","followers_url":"https://api.github.com/users/KatarzynaKruczkowska/followers","following_url":"https://api.github.com/users/KatarzynaKruczkowska/following{/other_user}","gists_url":"https://api.github.com/users/KatarzynaKruczkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/KatarzynaKruczkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KatarzynaKruczkowska/subscriptions","organizations_url":"https://api.github.com/users/KatarzynaKruczkowska/orgs","repos_url":"https://api.github.com/users/KatarzynaKruczkowska/repos","events_url":"https://api.github.com/users/KatarzynaKruczkowska/events{/privacy}","received_events_url":"https://api.github.com/users/KatarzynaKruczkowska/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-26T11:33:39Z","updated_at":"2018-07-27T06:32:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa8b01a861726b0dc6e33452cf23b3488ff95c1e","assignee":{"login":"KatarzynaKruczkowska","id":38396769,"node_id":"MDQ6VXNlcjM4Mzk2NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/38396769?v=4","gravatar_id":"","url":"https://api.github.com/users/KatarzynaKruczkowska","html_url":"https://github.com/KatarzynaKruczkowska","followers_url":"https://api.github.com/users/KatarzynaKruczkowska/followers","following_url":"https://api.github.com/users/KatarzynaKruczkowska/following{/other_user}","gists_url":"https://api.github.com/users/KatarzynaKruczkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/KatarzynaKruczkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KatarzynaKruczkowska/subscriptions","organizations_url":"https://api.github.com/users/KatarzynaKruczkowska/orgs","repos_url":"https://api.github.com/users/KatarzynaKruczkowska/repos","events_url":"https://api.github.com/users/KatarzynaKruczkowska/events{/privacy}","received_events_url":"https://api.github.com/users/KatarzynaKruczkowska/received_events","type":"User","site_admin":false},"assignees":[{"login":"KatarzynaKruczkowska","id":38396769,"node_id":"MDQ6VXNlcjM4Mzk2NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/38396769?v=4","gravatar_id":"","url":"https://api.github.com/users/KatarzynaKruczkowska","html_url":"https://github.com/KatarzynaKruczkowska","followers_url":"https://api.github.com/users/KatarzynaKruczkowska/followers","following_url":"https://api.github.com/users/KatarzynaKruczkowska/following{/other_user}","gists_url":"https://api.github.com/users/KatarzynaKruczkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/KatarzynaKruczkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KatarzynaKruczkowska/subscriptions","organizations_url":"https://api.github.com/users/KatarzynaKruczkowska/orgs","repos_url":"https://api.github.com/users/KatarzynaKruczkowska/repos","events_url":"https://api.github.com/users/KatarzynaKruczkowska/events{/privacy}","received_events_url":"https://api.github.com/users/KatarzynaKruczkowska/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"warcello","id":11767839,"node_id":"MDQ6VXNlcjExNzY3ODM5","avatar_url":"https://avatars1.githubusercontent.com/u/11767839?v=4","gravatar_id":"","url":"https://api.github.com/users/warcello","html_url":"https://github.com/warcello","followers_url":"https://api.github.com/users/warcello/followers","following_url":"https://api.github.com/users/warcello/following{/other_user}","gists_url":"https://api.github.com/users/warcello/gists{/gist_id}","starred_url":"https://api.github.com/users/warcello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warcello/subscriptions","organizations_url":"https://api.github.com/users/warcello/orgs","repos_url":"https://api.github.com/users/warcello/repos","events_url":"https://api.github.com/users/warcello/events{/privacy}","received_events_url":"https://api.github.com/users/warcello/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/12/commits","review_comments_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/12/comments","review_comment_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues/12/comments","statuses_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/statuses/952a15887ecd972f14dd90b8ce5c48d6fd54ec96","head":{"label":"KatarzynaKruczkowska:develop","ref":"develop","sha":"952a15887ecd972f14dd90b8ce5c48d6fd54ec96","user":{"login":"KatarzynaKruczkowska","id":38396769,"node_id":"MDQ6VXNlcjM4Mzk2NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/38396769?v=4","gravatar_id":"","url":"https://api.github.com/users/KatarzynaKruczkowska","html_url":"https://github.com/KatarzynaKruczkowska","followers_url":"https://api.github.com/users/KatarzynaKruczkowska/followers","following_url":"https://api.github.com/users/KatarzynaKruczkowska/following{/other_user}","gists_url":"https://api.github.com/users/KatarzynaKruczkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/KatarzynaKruczkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KatarzynaKruczkowska/subscriptions","organizations_url":"https://api.github.com/users/KatarzynaKruczkowska/orgs","repos_url":"https://api.github.com/users/KatarzynaKruczkowska/repos","events_url":"https://api.github.com/users/KatarzynaKruczkowska/events{/privacy}","received_events_url":"https://api.github.com/users/KatarzynaKruczkowska/received_events","type":"User","site_admin":false},"repo":{"id":129600993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk2MDA5OTM=","name":"CircleAndCross","full_name":"KatarzynaKruczkowska/CircleAndCross","owner":{"login":"KatarzynaKruczkowska","id":38396769,"node_id":"MDQ6VXNlcjM4Mzk2NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/38396769?v=4","gravatar_id":"","url":"https://api.github.com/users/KatarzynaKruczkowska","html_url":"https://github.com/KatarzynaKruczkowska","followers_url":"https://api.github.com/users/KatarzynaKruczkowska/followers","following_url":"https://api.github.com/users/KatarzynaKruczkowska/following{/other_user}","gists_url":"https://api.github.com/users/KatarzynaKruczkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/KatarzynaKruczkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KatarzynaKruczkowska/subscriptions","organizations_url":"https://api.github.com/users/KatarzynaKruczkowska/orgs","repos_url":"https://api.github.com/users/KatarzynaKruczkowska/repos","events_url":"https://api.github.com/users/KatarzynaKruczkowska/events{/privacy}","received_events_url":"https://api.github.com/users/KatarzynaKruczkowska/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross","description":null,"fork":false,"url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross","forks_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/forks","keys_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/teams","hooks_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/hooks","issue_events_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues/events{/number}","events_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/events","assignees_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/assignees{/user}","branches_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/branches{/branch}","tags_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/tags","blobs_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/refs{/sha}","trees_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/statuses/{sha}","languages_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/languages","stargazers_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/stargazers","contributors_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/contributors","subscribers_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/subscribers","subscription_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/subscription","commits_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/commits{/sha}","git_commits_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/commits{/sha}","comments_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/comments{/number}","issue_comment_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues/comments{/number}","contents_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/contents/{+path}","compare_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/merges","archive_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/downloads","issues_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues{/number}","pulls_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls{/number}","milestones_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/milestones{/number}","notifications_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/labels{/name}","releases_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/releases{/id}","deployments_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/deployments","created_at":"2018-04-15T10:52:04Z","updated_at":"2018-07-26T21:15:01Z","pushed_at":"2018-07-26T21:15:00Z","git_url":"git://github.com/KatarzynaKruczkowska/CircleAndCross.git","ssh_url":"[email protected]:KatarzynaKruczkowska/CircleAndCross.git","clone_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross.git","svn_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross","homepage":null,"size":64,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"KatarzynaKruczkowska:master","ref":"master","sha":"bf1d2d58abab624300d3146ed5f1b89d2999a470","user":{"login":"KatarzynaKruczkowska","id":38396769,"node_id":"MDQ6VXNlcjM4Mzk2NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/38396769?v=4","gravatar_id":"","url":"https://api.github.com/users/KatarzynaKruczkowska","html_url":"https://github.com/KatarzynaKruczkowska","followers_url":"https://api.github.com/users/KatarzynaKruczkowska/followers","following_url":"https://api.github.com/users/KatarzynaKruczkowska/following{/other_user}","gists_url":"https://api.github.com/users/KatarzynaKruczkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/KatarzynaKruczkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KatarzynaKruczkowska/subscriptions","organizations_url":"https://api.github.com/users/KatarzynaKruczkowska/orgs","repos_url":"https://api.github.com/users/KatarzynaKruczkowska/repos","events_url":"https://api.github.com/users/KatarzynaKruczkowska/events{/privacy}","received_events_url":"https://api.github.com/users/KatarzynaKruczkowska/received_events","type":"User","site_admin":false},"repo":{"id":129600993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk2MDA5OTM=","name":"CircleAndCross","full_name":"KatarzynaKruczkowska/CircleAndCross","owner":{"login":"KatarzynaKruczkowska","id":38396769,"node_id":"MDQ6VXNlcjM4Mzk2NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/38396769?v=4","gravatar_id":"","url":"https://api.github.com/users/KatarzynaKruczkowska","html_url":"https://github.com/KatarzynaKruczkowska","followers_url":"https://api.github.com/users/KatarzynaKruczkowska/followers","following_url":"https://api.github.com/users/KatarzynaKruczkowska/following{/other_user}","gists_url":"https://api.github.com/users/KatarzynaKruczkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/KatarzynaKruczkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KatarzynaKruczkowska/subscriptions","organizations_url":"https://api.github.com/users/KatarzynaKruczkowska/orgs","repos_url":"https://api.github.com/users/KatarzynaKruczkowska/repos","events_url":"https://api.github.com/users/KatarzynaKruczkowska/events{/privacy}","received_events_url":"https://api.github.com/users/KatarzynaKruczkowska/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross","description":null,"fork":false,"url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross","forks_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/forks","keys_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/teams","hooks_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/hooks","issue_events_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues/events{/number}","events_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/events","assignees_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/assignees{/user}","branches_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/branches{/branch}","tags_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/tags","blobs_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/refs{/sha}","trees_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/statuses/{sha}","languages_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/languages","stargazers_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/stargazers","contributors_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/contributors","subscribers_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/subscribers","subscription_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/subscription","commits_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/commits{/sha}","git_commits_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/git/commits{/sha}","comments_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/comments{/number}","issue_comment_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues/comments{/number}","contents_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/contents/{+path}","compare_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/merges","archive_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/downloads","issues_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues{/number}","pulls_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls{/number}","milestones_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/milestones{/number}","notifications_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/labels{/name}","releases_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/releases{/id}","deployments_url":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/deployments","created_at":"2018-04-15T10:52:04Z","updated_at":"2018-07-26T21:15:01Z","pushed_at":"2018-07-26T21:15:00Z","git_url":"git://github.com/KatarzynaKruczkowska/CircleAndCross.git","ssh_url":"[email protected]:KatarzynaKruczkowska/CircleAndCross.git","clone_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross.git","svn_url":"https://github.com/KatarzynaKruczkowska/CircleAndCross","homepage":null,"size":64,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/12"},"html":{"href":"https://github.com/KatarzynaKruczkowska/CircleAndCross/pull/12"},"issue":{"href":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues/12"},"comments":{"href":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross/statuses/952a15887ecd972f14dd90b8ce5c48d6fd54ec96"}},"author_association":"OWNER"}} | {
"id": 129600993,
"name": "KatarzynaKruczkowska/CircleAndCross",
"url": "https://api.github.com/repos/KatarzynaKruczkowska/CircleAndCross"
} | {
"id": 24889282,
"login": "mkruczkowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24889282?",
"url": "https://api.github.com/users/mkruczkowski"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-07-27T06:26:41 | 8026810717 | {"actor":{"display_login":"mkruczkowski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nachtm/atlas-checks/pulls/comments/237297784","pull_request_review_id":179562071,"id":237297784,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzI5Nzc4NA==","diff_hunk":"@@ -0,0 +1,418 @@\n+package org.openstreetmap.atlas.checks.validation.areas;\n+\n+import java.util.ArrayList;\n+import java.util.Collection;\n+import java.util.Collections;\n+import java.util.HashSet;\n+import java.util.List;\n+import java.util.Optional;\n+import java.util.Set;\n+import java.util.stream.Collectors;\n+import java.util.stream.IntStream;\n+import java.util.stream.Stream;\n+\n+import org.apache.commons.lang3.tuple.Triple;\n+import org.openstreetmap.atlas.checks.base.BaseCheck;\n+import org.openstreetmap.atlas.checks.flag.CheckFlag;\n+import org.openstreetmap.atlas.geography.Location;\n+import org.openstreetmap.atlas.geography.Polygon;\n+import org.openstreetmap.atlas.geography.Segment;\n+import org.openstreetmap.atlas.geography.atlas.items.Area;\n+import org.openstreetmap.atlas.geography.atlas.items.AtlasObject;\n+import org.openstreetmap.atlas.geography.atlas.items.ItemType;\n+import org.openstreetmap.atlas.geography.atlas.items.Relation;\n+import org.openstreetmap.atlas.geography.atlas.items.RelationMember;\n+import org.openstreetmap.atlas.tags.BuildingPartTag;\n+import org.openstreetmap.atlas.tags.BuildingTag;\n+import org.openstreetmap.atlas.tags.annotations.validation.Validators;\n+import org.openstreetmap.atlas.utilities.configuration.Configuration;\n+import org.openstreetmap.atlas.utilities.scalars.Angle;\n+import org.openstreetmap.atlas.utilities.tuples.Tuple;\n+\n+/**\n+ * This check flags all buildings with angles less than some threshold value as part of their\n+ * geometry. The purpose is to catch buildings that were automatically closed incorrectly, or\n+ * buildings that are likely to have been poorly digitized. In order to avoid flagging most\n+ * buildings with curved geometry, this check uses a configurable heuristic to detect curves and\n+ * does not flag potential spikes at the ends of a curve.\n+ *\n+ * @author nachtm\n+ */\n+public class SpikyBuildingCheck extends BaseCheck<Long>\n+{\n+ private static final long DEFAULT_MIN_HEADING_THRESHOLD = 15;\n+ private static final long DEFAULT_CIRCULAR_ANGLE_THRESHOLD = 25;\n+ private static final long DEFAULT_MINIMUM_TOTAL_CIRCULAR_ANGLE_THRESHOLD = 10;\n+ private static final long DEFAULT_MINIMUM_CIRCULAR_LINE_SEGMENTS = 4;\n+ private static final List<String> FALLBACK_INSTRUCTIONS = Collections.singletonList(\n+ \"This building has the following angle measurements under the minimum allowed angle of {0}: {1}\");\n+ private Angle headingThreshold;\n+ private Angle circularAngleThreshold;\n+ private Angle minimumTotalCircularAngleThreshold;\n+ private long minimumCircularPointsInCurve;\n+\n+ /**\n+ * Default constructor\n+ *\n+ * @param configuration\n+ * {@link Configuration} required to construct any Check\n+ */\n+ public SpikyBuildingCheck(final Configuration configuration)\n+ {\n+ super(configuration);\n+ this.headingThreshold = this.configurationValue(configuration, \"spiky.angle.maximum\",\n+ DEFAULT_MIN_HEADING_THRESHOLD, threshold -> Angle.degrees((double) threshold));\n+ this.circularAngleThreshold = this.configurationValue(configuration, \"curve.angle.maximum\",\n+ DEFAULT_CIRCULAR_ANGLE_THRESHOLD, threshold -> Angle.degrees((double) threshold));\n+ this.minimumTotalCircularAngleThreshold = this.configurationValue(configuration,\n+ \"curve.angle.total.minimum\", DEFAULT_MINIMUM_TOTAL_CIRCULAR_ANGLE_THRESHOLD,\n+ threshold -> Angle.degrees((double) threshold));\n+ this.minimumCircularPointsInCurve = this.configurationValue(configuration,\n+ \"curve.points.minimum\", DEFAULT_MINIMUM_CIRCULAR_LINE_SEGMENTS);\n+ }\n+\n+ @Override\n+ public boolean validCheckForObject(final AtlasObject object)\n+ {\n+ return (object instanceof Area\n+ || (object instanceof Relation && ((Relation) object).isMultiPolygon()))\n+ && (this.isBuildingOrPart(object));","path":"src/main/java/org/openstreetmap/atlas/checks/validation/areas/SpikyBuildingCheck.java","position":79,"original_position":79,"commit_id":"4a0e762301b8c926e979173caf0f9ca4e9303448","original_commit_id":"4a0e762301b8c926e979173caf0f9ca4e9303448","user":{"login":"danielduhh","id":1947857,"node_id":"MDQ6VXNlcjE5NDc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1947857?v=4","gravatar_id":"","url":"https://api.github.com/users/danielduhh","html_url":"https://github.com/danielduhh","followers_url":"https://api.github.com/users/danielduhh/followers","following_url":"https://api.github.com/users/danielduhh/following{/other_user}","gists_url":"https://api.github.com/users/danielduhh/gists{/gist_id}","starred_url":"https://api.github.com/users/danielduhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielduhh/subscriptions","organizations_url":"https://api.github.com/users/danielduhh/orgs","repos_url":"https://api.github.com/users/danielduhh/repos","events_url":"https://api.github.com/users/danielduhh/events{/privacy}","received_events_url":"https://api.github.com/users/danielduhh/received_events","type":"User","site_admin":false},"body":"nit: Extra `( )` here","created_at":"2018-11-28T23:08:28Z","updated_at":"2018-11-28T23:08:28Z","html_url":"https://github.com/nachtm/atlas-checks/pull/5#discussion_r237297784","pull_request_url":"https://api.github.com/repos/nachtm/atlas-checks/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nachtm/atlas-checks/pulls/comments/237297784"},"html":{"href":"https://github.com/nachtm/atlas-checks/pull/5#discussion_r237297784"},"pull_request":{"href":"https://api.github.com/repos/nachtm/atlas-checks/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/nachtm/atlas-checks/pulls/5","id":232071776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDcxNzc2","html_url":"https://github.com/nachtm/atlas-checks/pull/5","diff_url":"https://github.com/nachtm/atlas-checks/pull/5.diff","patch_url":"https://github.com/nachtm/atlas-checks/pull/5.patch","issue_url":"https://api.github.com/repos/nachtm/atlas-checks/issues/5","number":5,"state":"open","locked":false,"title":"Spiky buildings","user":{"login":"nachtm","id":12106730,"node_id":"MDQ6VXNlcjEyMTA2NzMw","avatar_url":"https://avatars3.githubusercontent.com/u/12106730?v=4","gravatar_id":"","url":"https://api.github.com/users/nachtm","html_url":"https://github.com/nachtm","followers_url":"https://api.github.com/users/nachtm/followers","following_url":"https://api.github.com/users/nachtm/following{/other_user}","gists_url":"https://api.github.com/users/nachtm/gists{/gist_id}","starred_url":"https://api.github.com/users/nachtm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nachtm/subscriptions","organizations_url":"https://api.github.com/users/nachtm/orgs","repos_url":"https://api.github.com/users/nachtm/repos","events_url":"https://api.github.com/users/nachtm/events{/privacy}","received_events_url":"https://api.github.com/users/nachtm/received_events","type":"User","site_admin":false},"body":"### Description:\r\n\r\nThe purpose of this check is to identify buildings with extremely sharp angles in their geometry. \r\nThese angles, or “spikes” are formed by two or more poly-lines and a peak node. These spikes are often hard to visually inspect as the poly-lines that create them can be very small. Spikes in building \r\ngeometry are almost always errors and should be corrected. They can be inadvertently created in the \r\ndata creation process by incorrectly closing a poly-line to create a polygon.\r\n\r\nThis check is inspired by [this help.openstreetmap.org thread](https://help.openstreetmap.org/questions/66104/is-there-a-way-to-detect-very-sharp-angles-of-buildings), which includes [this paper](https://drive.google.com/file/d/1MaLdnSnc454xKjn3eL95vDQKeoIW8zGU/view). There are a few differences, since the paper uses the Mercator projection while Atlas does not, but the idea of finding spiky angles in buildings is the same.\r\n\r\nThis check flags all Atlas objects for which the following criteria are true:\r\n * The object is a building or a building part\r\n * The angle created by the intersection of any two line segments within the building's geometry \r\n is less than some configurable value.\r\n * An angle less than 15˚ is not be flagged if it occurs at the beginning or end of a curve \r\n within the building's geometry. There are three configurable heuristics to identify curves: the minimum number of points inside of a curve, the maximum difference in heading between two consecutive segments in a curve, and the minimum difference in heading between the start segment and end segment of a curve. That is, any specific point in a curve must have a small change in direction, but the overall curve must change direction. \r\n\r\n### Potential Impact:\r\n\r\nJust a new check.\r\n\r\n### Unit Test Approach:\r\n\r\nTested a variety of cases, including buildings with curved segments, non-spiky buildings, spiky buildings, a couple of real-world buildings, and buildings with curved segments that don't fit the heuristics (and therefore should be flagged). \r\n\r\n### Test Results:\r\n\r\nAll tests passing.\r\n\r\n","created_at":"2018-11-19T18:33:27Z","updated_at":"2018-11-28T23:08:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"560a31cc22da0a8e64f2f56631bc775c98976951","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sayas01","id":42149840,"node_id":"MDQ6VXNlcjQyMTQ5ODQw","avatar_url":"https://avatars2.githubusercontent.com/u/42149840?v=4","gravatar_id":"","url":"https://api.github.com/users/sayas01","html_url":"https://github.com/sayas01","followers_url":"https://api.github.com/users/sayas01/followers","following_url":"https://api.github.com/users/sayas01/following{/other_user}","gists_url":"https://api.github.com/users/sayas01/gists{/gist_id}","starred_url":"https://api.github.com/users/sayas01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayas01/subscriptions","organizations_url":"https://api.github.com/users/sayas01/orgs","repos_url":"https://api.github.com/users/sayas01/repos","events_url":"https://api.github.com/users/sayas01/events{/privacy}","received_events_url":"https://api.github.com/users/sayas01/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nachtm/atlas-checks/pulls/5/commits","review_comments_url":"https://api.github.com/repos/nachtm/atlas-checks/pulls/5/comments","review_comment_url":"https://api.github.com/repos/nachtm/atlas-checks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nachtm/atlas-checks/issues/5/comments","statuses_url":"https://api.github.com/repos/nachtm/atlas-checks/statuses/4a0e762301b8c926e979173caf0f9ca4e9303448","head":{"label":"nachtm:SpikyBuildings","ref":"SpikyBuildings","sha":"4a0e762301b8c926e979173caf0f9ca4e9303448","user":{"login":"nachtm","id":12106730,"node_id":"MDQ6VXNlcjEyMTA2NzMw","avatar_url":"https://avatars3.githubusercontent.com/u/12106730?v=4","gravatar_id":"","url":"https://api.github.com/users/nachtm","html_url":"https://github.com/nachtm","followers_url":"https://api.github.com/users/nachtm/followers","following_url":"https://api.github.com/users/nachtm/following{/other_user}","gists_url":"https://api.github.com/users/nachtm/gists{/gist_id}","starred_url":"https://api.github.com/users/nachtm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nachtm/subscriptions","organizations_url":"https://api.github.com/users/nachtm/orgs","repos_url":"https://api.github.com/users/nachtm/repos","events_url":"https://api.github.com/users/nachtm/events{/privacy}","received_events_url":"https://api.github.com/users/nachtm/received_events","type":"User","site_admin":false},"repo":{"id":145751294,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3NTEyOTQ=","name":"atlas-checks","full_name":"nachtm/atlas-checks","private":false,"owner":{"login":"nachtm","id":12106730,"node_id":"MDQ6VXNlcjEyMTA2NzMw","avatar_url":"https://avatars3.githubusercontent.com/u/12106730?v=4","gravatar_id":"","url":"https://api.github.com/users/nachtm","html_url":"https://github.com/nachtm","followers_url":"https://api.github.com/users/nachtm/followers","following_url":"https://api.github.com/users/nachtm/following{/other_user}","gists_url":"https://api.github.com/users/nachtm/gists{/gist_id}","starred_url":"https://api.github.com/users/nachtm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nachtm/subscriptions","organizations_url":"https://api.github.com/users/nachtm/orgs","repos_url":"https://api.github.com/users/nachtm/repos","events_url":"https://api.github.com/users/nachtm/events{/privacy}","received_events_url":"https://api.github.com/users/nachtm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nachtm/atlas-checks","description":"OSM data integrity checks with Atlas","fork":true,"url":"https://api.github.com/repos/nachtm/atlas-checks","forks_url":"https://api.github.com/repos/nachtm/atlas-checks/forks","keys_url":"https://api.github.com/repos/nachtm/atlas-checks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nachtm/atlas-checks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nachtm/atlas-checks/teams","hooks_url":"https://api.github.com/repos/nachtm/atlas-checks/hooks","issue_events_url":"https://api.github.com/repos/nachtm/atlas-checks/issues/events{/number}","events_url":"https://api.github.com/repos/nachtm/atlas-checks/events","assignees_url":"https://api.github.com/repos/nachtm/atlas-checks/assignees{/user}","branches_url":"https://api.github.com/repos/nachtm/atlas-checks/branches{/branch}","tags_url":"https://api.github.com/repos/nachtm/atlas-checks/tags","blobs_url":"https://api.github.com/repos/nachtm/atlas-checks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nachtm/atlas-checks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nachtm/atlas-checks/git/refs{/sha}","trees_url":"https://api.github.com/repos/nachtm/atlas-checks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nachtm/atlas-checks/statuses/{sha}","languages_url":"https://api.github.com/repos/nachtm/atlas-checks/languages","stargazers_url":"https://api.github.com/repos/nachtm/atlas-checks/stargazers","contributors_url":"https://api.github.com/repos/nachtm/atlas-checks/contributors","subscribers_url":"https://api.github.com/repos/nachtm/atlas-checks/subscribers","subscription_url":"https://api.github.com/repos/nachtm/atlas-checks/subscription","commits_url":"https://api.github.com/repos/nachtm/atlas-checks/commits{/sha}","git_commits_url":"https://api.github.com/repos/nachtm/atlas-checks/git/commits{/sha}","comments_url":"https://api.github.com/repos/nachtm/atlas-checks/comments{/number}","issue_comment_url":"https://api.github.com/repos/nachtm/atlas-checks/issues/comments{/number}","contents_url":"https://api.github.com/repos/nachtm/atlas-checks/contents/{+path}","compare_url":"https://api.github.com/repos/nachtm/atlas-checks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nachtm/atlas-checks/merges","archive_url":"https://api.github.com/repos/nachtm/atlas-checks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nachtm/atlas-checks/downloads","issues_url":"https://api.github.com/repos/nachtm/atlas-checks/issues{/number}","pulls_url":"https://api.github.com/repos/nachtm/atlas-checks/pulls{/number}","milestones_url":"https://api.github.com/repos/nachtm/atlas-checks/milestones{/number}","notifications_url":"https://api.github.com/repos/nachtm/atlas-checks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nachtm/atlas-checks/labels{/name}","releases_url":"https://api.github.com/repos/nachtm/atlas-checks/releases{/id}","deployments_url":"https://api.github.com/repos/nachtm/atlas-checks/deployments","created_at":"2018-08-22T19:05:56Z","updated_at":"2018-11-15T18:03:25Z","pushed_at":"2018-11-27T22:10:29Z","git_url":"git://github.com/nachtm/atlas-checks.git","ssh_url":"[email protected]:nachtm/atlas-checks.git","clone_url":"https://github.com/nachtm/atlas-checks.git","svn_url":"https://github.com/nachtm/atlas-checks","homepage":null,"size":13144,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"base":{"label":"nachtm:dev","ref":"dev","sha":"7f3177aa465b934a19c295503a29326cc1ef8e35","user":{"login":"nachtm","id":12106730,"node_id":"MDQ6VXNlcjEyMTA2NzMw","avatar_url":"https://avatars3.githubusercontent.com/u/12106730?v=4","gravatar_id":"","url":"https://api.github.com/users/nachtm","html_url":"https://github.com/nachtm","followers_url":"https://api.github.com/users/nachtm/followers","following_url":"https://api.github.com/users/nachtm/following{/other_user}","gists_url":"https://api.github.com/users/nachtm/gists{/gist_id}","starred_url":"https://api.github.com/users/nachtm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nachtm/subscriptions","organizations_url":"https://api.github.com/users/nachtm/orgs","repos_url":"https://api.github.com/users/nachtm/repos","events_url":"https://api.github.com/users/nachtm/events{/privacy}","received_events_url":"https://api.github.com/users/nachtm/received_events","type":"User","site_admin":false},"repo":{"id":145751294,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3NTEyOTQ=","name":"atlas-checks","full_name":"nachtm/atlas-checks","private":false,"owner":{"login":"nachtm","id":12106730,"node_id":"MDQ6VXNlcjEyMTA2NzMw","avatar_url":"https://avatars3.githubusercontent.com/u/12106730?v=4","gravatar_id":"","url":"https://api.github.com/users/nachtm","html_url":"https://github.com/nachtm","followers_url":"https://api.github.com/users/nachtm/followers","following_url":"https://api.github.com/users/nachtm/following{/other_user}","gists_url":"https://api.github.com/users/nachtm/gists{/gist_id}","starred_url":"https://api.github.com/users/nachtm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nachtm/subscriptions","organizations_url":"https://api.github.com/users/nachtm/orgs","repos_url":"https://api.github.com/users/nachtm/repos","events_url":"https://api.github.com/users/nachtm/events{/privacy}","received_events_url":"https://api.github.com/users/nachtm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nachtm/atlas-checks","description":"OSM data integrity checks with Atlas","fork":true,"url":"https://api.github.com/repos/nachtm/atlas-checks","forks_url":"https://api.github.com/repos/nachtm/atlas-checks/forks","keys_url":"https://api.github.com/repos/nachtm/atlas-checks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nachtm/atlas-checks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nachtm/atlas-checks/teams","hooks_url":"https://api.github.com/repos/nachtm/atlas-checks/hooks","issue_events_url":"https://api.github.com/repos/nachtm/atlas-checks/issues/events{/number}","events_url":"https://api.github.com/repos/nachtm/atlas-checks/events","assignees_url":"https://api.github.com/repos/nachtm/atlas-checks/assignees{/user}","branches_url":"https://api.github.com/repos/nachtm/atlas-checks/branches{/branch}","tags_url":"https://api.github.com/repos/nachtm/atlas-checks/tags","blobs_url":"https://api.github.com/repos/nachtm/atlas-checks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nachtm/atlas-checks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nachtm/atlas-checks/git/refs{/sha}","trees_url":"https://api.github.com/repos/nachtm/atlas-checks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nachtm/atlas-checks/statuses/{sha}","languages_url":"https://api.github.com/repos/nachtm/atlas-checks/languages","stargazers_url":"https://api.github.com/repos/nachtm/atlas-checks/stargazers","contributors_url":"https://api.github.com/repos/nachtm/atlas-checks/contributors","subscribers_url":"https://api.github.com/repos/nachtm/atlas-checks/subscribers","subscription_url":"https://api.github.com/repos/nachtm/atlas-checks/subscription","commits_url":"https://api.github.com/repos/nachtm/atlas-checks/commits{/sha}","git_commits_url":"https://api.github.com/repos/nachtm/atlas-checks/git/commits{/sha}","comments_url":"https://api.github.com/repos/nachtm/atlas-checks/comments{/number}","issue_comment_url":"https://api.github.com/repos/nachtm/atlas-checks/issues/comments{/number}","contents_url":"https://api.github.com/repos/nachtm/atlas-checks/contents/{+path}","compare_url":"https://api.github.com/repos/nachtm/atlas-checks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nachtm/atlas-checks/merges","archive_url":"https://api.github.com/repos/nachtm/atlas-checks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nachtm/atlas-checks/downloads","issues_url":"https://api.github.com/repos/nachtm/atlas-checks/issues{/number}","pulls_url":"https://api.github.com/repos/nachtm/atlas-checks/pulls{/number}","milestones_url":"https://api.github.com/repos/nachtm/atlas-checks/milestones{/number}","notifications_url":"https://api.github.com/repos/nachtm/atlas-checks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nachtm/atlas-checks/labels{/name}","releases_url":"https://api.github.com/repos/nachtm/atlas-checks/releases{/id}","deployments_url":"https://api.github.com/repos/nachtm/atlas-checks/deployments","created_at":"2018-08-22T19:05:56Z","updated_at":"2018-11-15T18:03:25Z","pushed_at":"2018-11-27T22:10:29Z","git_url":"git://github.com/nachtm/atlas-checks.git","ssh_url":"[email protected]:nachtm/atlas-checks.git","clone_url":"https://github.com/nachtm/atlas-checks.git","svn_url":"https://github.com/nachtm/atlas-checks","homepage":null,"size":13144,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/nachtm/atlas-checks/pulls/5"},"html":{"href":"https://github.com/nachtm/atlas-checks/pull/5"},"issue":{"href":"https://api.github.com/repos/nachtm/atlas-checks/issues/5"},"comments":{"href":"https://api.github.com/repos/nachtm/atlas-checks/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/nachtm/atlas-checks/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/nachtm/atlas-checks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nachtm/atlas-checks/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/nachtm/atlas-checks/statuses/4a0e762301b8c926e979173caf0f9ca4e9303448"}},"author_association":"OWNER"}} | {
"id": 145751294,
"name": "nachtm/atlas-checks",
"url": "https://api.github.com/repos/nachtm/atlas-checks"
} | {
"id": 1947857,
"login": "danielduhh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1947857?",
"url": "https://api.github.com/users/danielduhh"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-11-28T23:08:28 | 8665378136 | {"actor":{"display_login":"danielduhh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/comments/201679980","pull_request_review_id":136227422,"id":201679980,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTY3OTk4MA==","diff_hunk":"@@ -64,8 +63,7 @@ component = H.parentComponent\n pure next\n \n \n-matchRoutes :: forall eff. H.HalogenIO Query Void (Aff (HA.HalogenEffects eff))\n- -> Eff (HA.HalogenEffects eff) Unit\n-matchRoutes app = matches RT.routing (redirects app)\n+matchRoutes :: forall eff. H.HalogenIO Query Void Aff -> Effect Unit\n+matchRoutes app = match RT.routing (redirects app)","path":"src/Layouts/Main.purs","position":32,"original_position":32,"commit_id":"37710e3159b4c1e5aa7e2b9d2481573a55d037cd","original_commit_id":"37710e3159b4c1e5aa7e2b9d2481573a55d037cd","user":{"login":"snackycracky","id":144498,"node_id":"MDQ6VXNlcjE0NDQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/144498?v=4","gravatar_id":"","url":"https://api.github.com/users/snackycracky","html_url":"https://github.com/snackycracky","followers_url":"https://api.github.com/users/snackycracky/followers","following_url":"https://api.github.com/users/snackycracky/following{/other_user}","gists_url":"https://api.github.com/users/snackycracky/gists{/gist_id}","starred_url":"https://api.github.com/users/snackycracky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snackycracky/subscriptions","organizations_url":"https://api.github.com/users/snackycracky/orgs","repos_url":"https://api.github.com/users/snackycracky/repos","events_url":"https://api.github.com/users/snackycracky/events{/privacy}","received_events_url":"https://api.github.com/users/snackycracky/received_events","type":"User","site_admin":false},"body":"I understand that `match` is expecting a `String` as the second argument. \r\nAlso I understand thay somewhere in the `query` of `HalogenIO` (here `driver.query`) is the information (that expected String) hidden. But I don't understand \"anything\" about `launchAff_`.","created_at":"2018-07-11T13:02:23Z","updated_at":"2018-07-11T13:02:24Z","html_url":"https://github.com/snackycracky/halogen-boilerplate/pull/1#discussion_r201679980","pull_request_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/comments/201679980"},"html":{"href":"https://github.com/snackycracky/halogen-boilerplate/pull/1#discussion_r201679980"},"pull_request":{"href":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/1"}},"in_reply_to_id":201671426},"pull_request":{"url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/1","id":200684015,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjg0MDE1","html_url":"https://github.com/snackycracky/halogen-boilerplate/pull/1","diff_url":"https://github.com/snackycracky/halogen-boilerplate/pull/1.diff","patch_url":"https://github.com/snackycracky/halogen-boilerplate/pull/1.patch","issue_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues/1","number":1,"state":"open","locked":false,"title":"wip","user":{"login":"snackycracky","id":144498,"node_id":"MDQ6VXNlcjE0NDQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/144498?v=4","gravatar_id":"","url":"https://api.github.com/users/snackycracky","html_url":"https://github.com/snackycracky","followers_url":"https://api.github.com/users/snackycracky/followers","following_url":"https://api.github.com/users/snackycracky/following{/other_user}","gists_url":"https://api.github.com/users/snackycracky/gists{/gist_id}","starred_url":"https://api.github.com/users/snackycracky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snackycracky/subscriptions","organizations_url":"https://api.github.com/users/snackycracky/orgs","repos_url":"https://api.github.com/users/snackycracky/repos","events_url":"https://api.github.com/users/snackycracky/events{/privacy}","received_events_url":"https://api.github.com/users/snackycracky/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-07-11T12:30:53Z","updated_at":"2018-07-11T13:02:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d7a43156cb2ec550c59098ff0855c5838e1be19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/1/commits","review_comments_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/1/comments","review_comment_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues/1/comments","statuses_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/statuses/37710e3159b4c1e5aa7e2b9d2481573a55d037cd","head":{"label":"snackycracky:upgrade-0.12","ref":"upgrade-0.12","sha":"37710e3159b4c1e5aa7e2b9d2481573a55d037cd","user":{"login":"snackycracky","id":144498,"node_id":"MDQ6VXNlcjE0NDQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/144498?v=4","gravatar_id":"","url":"https://api.github.com/users/snackycracky","html_url":"https://github.com/snackycracky","followers_url":"https://api.github.com/users/snackycracky/followers","following_url":"https://api.github.com/users/snackycracky/following{/other_user}","gists_url":"https://api.github.com/users/snackycracky/gists{/gist_id}","starred_url":"https://api.github.com/users/snackycracky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snackycracky/subscriptions","organizations_url":"https://api.github.com/users/snackycracky/orgs","repos_url":"https://api.github.com/users/snackycracky/repos","events_url":"https://api.github.com/users/snackycracky/events{/privacy}","received_events_url":"https://api.github.com/users/snackycracky/received_events","type":"User","site_admin":false},"repo":{"id":140571983,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1NzE5ODM=","name":"halogen-boilerplate","full_name":"snackycracky/halogen-boilerplate","owner":{"login":"snackycracky","id":144498,"node_id":"MDQ6VXNlcjE0NDQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/144498?v=4","gravatar_id":"","url":"https://api.github.com/users/snackycracky","html_url":"https://github.com/snackycracky","followers_url":"https://api.github.com/users/snackycracky/followers","following_url":"https://api.github.com/users/snackycracky/following{/other_user}","gists_url":"https://api.github.com/users/snackycracky/gists{/gist_id}","starred_url":"https://api.github.com/users/snackycracky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snackycracky/subscriptions","organizations_url":"https://api.github.com/users/snackycracky/orgs","repos_url":"https://api.github.com/users/snackycracky/repos","events_url":"https://api.github.com/users/snackycracky/events{/privacy}","received_events_url":"https://api.github.com/users/snackycracky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snackycracky/halogen-boilerplate","description":"Bootstrap Halogen Project","fork":true,"url":"https://api.github.com/repos/snackycracky/halogen-boilerplate","forks_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/forks","keys_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/teams","hooks_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/events","assignees_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/tags","blobs_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/languages","stargazers_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/subscription","commits_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/merges","archive_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/downloads","issues_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/deployments","created_at":"2018-07-11T12:28:25Z","updated_at":"2018-07-11T12:28:27Z","pushed_at":"2018-07-11T12:30:54Z","git_url":"git://github.com/snackycracky/halogen-boilerplate.git","ssh_url":"[email protected]:snackycracky/halogen-boilerplate.git","clone_url":"https://github.com/snackycracky/halogen-boilerplate.git","svn_url":"https://github.com/snackycracky/halogen-boilerplate","homepage":null,"size":74,"stargazers_count":0,"watchers_count":0,"language":"PureScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"snackycracky:master","ref":"master","sha":"d2d271736beee3c3bebb06739895f89d86fd03de","user":{"login":"snackycracky","id":144498,"node_id":"MDQ6VXNlcjE0NDQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/144498?v=4","gravatar_id":"","url":"https://api.github.com/users/snackycracky","html_url":"https://github.com/snackycracky","followers_url":"https://api.github.com/users/snackycracky/followers","following_url":"https://api.github.com/users/snackycracky/following{/other_user}","gists_url":"https://api.github.com/users/snackycracky/gists{/gist_id}","starred_url":"https://api.github.com/users/snackycracky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snackycracky/subscriptions","organizations_url":"https://api.github.com/users/snackycracky/orgs","repos_url":"https://api.github.com/users/snackycracky/repos","events_url":"https://api.github.com/users/snackycracky/events{/privacy}","received_events_url":"https://api.github.com/users/snackycracky/received_events","type":"User","site_admin":false},"repo":{"id":140571983,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1NzE5ODM=","name":"halogen-boilerplate","full_name":"snackycracky/halogen-boilerplate","owner":{"login":"snackycracky","id":144498,"node_id":"MDQ6VXNlcjE0NDQ5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/144498?v=4","gravatar_id":"","url":"https://api.github.com/users/snackycracky","html_url":"https://github.com/snackycracky","followers_url":"https://api.github.com/users/snackycracky/followers","following_url":"https://api.github.com/users/snackycracky/following{/other_user}","gists_url":"https://api.github.com/users/snackycracky/gists{/gist_id}","starred_url":"https://api.github.com/users/snackycracky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snackycracky/subscriptions","organizations_url":"https://api.github.com/users/snackycracky/orgs","repos_url":"https://api.github.com/users/snackycracky/repos","events_url":"https://api.github.com/users/snackycracky/events{/privacy}","received_events_url":"https://api.github.com/users/snackycracky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snackycracky/halogen-boilerplate","description":"Bootstrap Halogen Project","fork":true,"url":"https://api.github.com/repos/snackycracky/halogen-boilerplate","forks_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/forks","keys_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/teams","hooks_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/events","assignees_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/tags","blobs_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/languages","stargazers_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/subscription","commits_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/merges","archive_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/downloads","issues_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/snackycracky/halogen-boilerplate/deployments","created_at":"2018-07-11T12:28:25Z","updated_at":"2018-07-11T12:28:27Z","pushed_at":"2018-07-11T12:30:54Z","git_url":"git://github.com/snackycracky/halogen-boilerplate.git","ssh_url":"[email protected]:snackycracky/halogen-boilerplate.git","clone_url":"https://github.com/snackycracky/halogen-boilerplate.git","svn_url":"https://github.com/snackycracky/halogen-boilerplate","homepage":null,"size":74,"stargazers_count":0,"watchers_count":0,"language":"PureScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/1"},"html":{"href":"https://github.com/snackycracky/halogen-boilerplate/pull/1"},"issue":{"href":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues/1"},"comments":{"href":"https://api.github.com/repos/snackycracky/halogen-boilerplate/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snackycracky/halogen-boilerplate/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/snackycracky/halogen-boilerplate/statuses/37710e3159b4c1e5aa7e2b9d2481573a55d037cd"}},"author_association":"OWNER"}} | {
"id": 140571983,
"name": "snackycracky/halogen-boilerplate",
"url": "https://api.github.com/repos/snackycracky/halogen-boilerplate"
} | {
"id": 144498,
"login": "snackycracky",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/144498?",
"url": "https://api.github.com/users/snackycracky"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-07-11T13:02:23 | 7949926538 | {"actor":{"display_login":"snackycracky"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/comments/186310017","pull_request_review_id":117862824,"id":186310017,"diff_hunk":"@@ -0,0 +1,68 @@\n+import orderService from '../../services/order-service';\n+\n+import menuService from '../services/menu';\n+import { assert } from 'chai';\n+\n+const Order = require('../../models/Order');\n+\n+describe('order-services', () => {\n+ const orderarr = ['item1', 'fh'];\n+ const customer = 'customer1';\n+ const date = 'chi';\n+\n+\n+ const anOrder = new Order(orderarr, customer, date);\n+ const ObjreturnedbymakeOrder = orderService.makeOrder(anOrder);","path":"server/test/services/order-service.test.js","position":15,"original_position":15,"commit_id":"d95e3e88ecf0e93160408a36ffeb1f694da39896","original_commit_id":"d95e3e88ecf0e93160408a36ffeb1f694da39896","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).","created_at":"2018-05-07T01:02:47Z","updated_at":"2018-05-07T01:02:47Z","html_url":"https://github.com/SolutionInventors/Book-A-Meal/pull/8#discussion_r186310017","pull_request_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/comments/186310017"},"html":{"href":"https://github.com/SolutionInventors/Book-A-Meal/pull/8#discussion_r186310017"},"pull_request":{"href":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/8","id":186236607,"html_url":"https://github.com/SolutionInventors/Book-A-Meal/pull/8","diff_url":"https://github.com/SolutionInventors/Book-A-Meal/pull/8.diff","patch_url":"https://github.com/SolutionInventors/Book-A-Meal/pull/8.patch","issue_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues/8","number":8,"state":"open","locked":false,"title":"Complete Route","user":{"login":"SolutionInventors","id":30505281,"avatar_url":"https://avatars0.githubusercontent.com/u/30505281?v=4","gravatar_id":"","url":"https://api.github.com/users/SolutionInventors","html_url":"https://github.com/SolutionInventors","followers_url":"https://api.github.com/users/SolutionInventors/followers","following_url":"https://api.github.com/users/SolutionInventors/following{/other_user}","gists_url":"https://api.github.com/users/SolutionInventors/gists{/gist_id}","starred_url":"https://api.github.com/users/SolutionInventors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolutionInventors/subscriptions","organizations_url":"https://api.github.com/users/SolutionInventors/orgs","repos_url":"https://api.github.com/users/SolutionInventors/repos","events_url":"https://api.github.com/users/SolutionInventors/events{/privacy}","received_events_url":"https://api.github.com/users/SolutionInventors/received_events","type":"User","site_admin":false},"body":"## All Challenge 2 routes are working\r\n\r\nFinally confirmed all routes working. \r\nThe error messages returned for invalid requests has also been improved in this PR","created_at":"2018-05-07T01:02:29Z","updated_at":"2018-05-07T01:02:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88949c9acb89121c147a6d6bb1f03c2e333d7ce5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/8/commits","review_comments_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/8/comments","review_comment_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues/8/comments","statuses_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/statuses/d95e3e88ecf0e93160408a36ffeb1f694da39896","head":{"label":"SolutionInventors:bg-route-update-156840101","ref":"bg-route-update-156840101","sha":"d95e3e88ecf0e93160408a36ffeb1f694da39896","user":{"login":"SolutionInventors","id":30505281,"avatar_url":"https://avatars0.githubusercontent.com/u/30505281?v=4","gravatar_id":"","url":"https://api.github.com/users/SolutionInventors","html_url":"https://github.com/SolutionInventors","followers_url":"https://api.github.com/users/SolutionInventors/followers","following_url":"https://api.github.com/users/SolutionInventors/following{/other_user}","gists_url":"https://api.github.com/users/SolutionInventors/gists{/gist_id}","starred_url":"https://api.github.com/users/SolutionInventors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolutionInventors/subscriptions","organizations_url":"https://api.github.com/users/SolutionInventors/orgs","repos_url":"https://api.github.com/users/SolutionInventors/repos","events_url":"https://api.github.com/users/SolutionInventors/events{/privacy}","received_events_url":"https://api.github.com/users/SolutionInventors/received_events","type":"User","site_admin":false},"repo":{"id":130043263,"name":"Book-A-Meal","full_name":"SolutionInventors/Book-A-Meal","owner":{"login":"SolutionInventors","id":30505281,"avatar_url":"https://avatars0.githubusercontent.com/u/30505281?v=4","gravatar_id":"","url":"https://api.github.com/users/SolutionInventors","html_url":"https://github.com/SolutionInventors","followers_url":"https://api.github.com/users/SolutionInventors/followers","following_url":"https://api.github.com/users/SolutionInventors/following{/other_user}","gists_url":"https://api.github.com/users/SolutionInventors/gists{/gist_id}","starred_url":"https://api.github.com/users/SolutionInventors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolutionInventors/subscriptions","organizations_url":"https://api.github.com/users/SolutionInventors/orgs","repos_url":"https://api.github.com/users/SolutionInventors/repos","events_url":"https://api.github.com/users/SolutionInventors/events{/privacy}","received_events_url":"https://api.github.com/users/SolutionInventors/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SolutionInventors/Book-A-Meal","description":"Gh Pages ","fork":false,"url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal","forks_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/forks","keys_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/teams","hooks_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/hooks","issue_events_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues/events{/number}","events_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/events","assignees_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/assignees{/user}","branches_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/branches{/branch}","tags_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/tags","blobs_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/statuses/{sha}","languages_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/languages","stargazers_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/stargazers","contributors_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/contributors","subscribers_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/subscribers","subscription_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/subscription","commits_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/contents/{+path}","compare_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/merges","archive_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/downloads","issues_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues{/number}","pulls_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls{/number}","milestones_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/milestones{/number}","notifications_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/labels{/name}","releases_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/releases{/id}","deployments_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/deployments","created_at":"2018-04-18T10:06:20Z","updated_at":"2018-05-03T09:26:51Z","pushed_at":"2018-05-07T01:02:29Z","git_url":"git://github.com/SolutionInventors/Book-A-Meal.git","ssh_url":"[email protected]:SolutionInventors/Book-A-Meal.git","clone_url":"https://github.com/SolutionInventors/Book-A-Meal.git","svn_url":"https://github.com/SolutionInventors/Book-A-Meal","homepage":"https://solutioninventors.github.io/Book-A-Meal/","size":14162,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"SolutionInventors:master","ref":"master","sha":"c0bdc59b570e05d7539b8933688b7e669ad59bde","user":{"login":"SolutionInventors","id":30505281,"avatar_url":"https://avatars0.githubusercontent.com/u/30505281?v=4","gravatar_id":"","url":"https://api.github.com/users/SolutionInventors","html_url":"https://github.com/SolutionInventors","followers_url":"https://api.github.com/users/SolutionInventors/followers","following_url":"https://api.github.com/users/SolutionInventors/following{/other_user}","gists_url":"https://api.github.com/users/SolutionInventors/gists{/gist_id}","starred_url":"https://api.github.com/users/SolutionInventors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolutionInventors/subscriptions","organizations_url":"https://api.github.com/users/SolutionInventors/orgs","repos_url":"https://api.github.com/users/SolutionInventors/repos","events_url":"https://api.github.com/users/SolutionInventors/events{/privacy}","received_events_url":"https://api.github.com/users/SolutionInventors/received_events","type":"User","site_admin":false},"repo":{"id":130043263,"name":"Book-A-Meal","full_name":"SolutionInventors/Book-A-Meal","owner":{"login":"SolutionInventors","id":30505281,"avatar_url":"https://avatars0.githubusercontent.com/u/30505281?v=4","gravatar_id":"","url":"https://api.github.com/users/SolutionInventors","html_url":"https://github.com/SolutionInventors","followers_url":"https://api.github.com/users/SolutionInventors/followers","following_url":"https://api.github.com/users/SolutionInventors/following{/other_user}","gists_url":"https://api.github.com/users/SolutionInventors/gists{/gist_id}","starred_url":"https://api.github.com/users/SolutionInventors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolutionInventors/subscriptions","organizations_url":"https://api.github.com/users/SolutionInventors/orgs","repos_url":"https://api.github.com/users/SolutionInventors/repos","events_url":"https://api.github.com/users/SolutionInventors/events{/privacy}","received_events_url":"https://api.github.com/users/SolutionInventors/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SolutionInventors/Book-A-Meal","description":"Gh Pages ","fork":false,"url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal","forks_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/forks","keys_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/teams","hooks_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/hooks","issue_events_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues/events{/number}","events_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/events","assignees_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/assignees{/user}","branches_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/branches{/branch}","tags_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/tags","blobs_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/refs{/sha}","trees_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/statuses/{sha}","languages_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/languages","stargazers_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/stargazers","contributors_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/contributors","subscribers_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/subscribers","subscription_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/subscription","commits_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/commits{/sha}","git_commits_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/git/commits{/sha}","comments_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/comments{/number}","issue_comment_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues/comments{/number}","contents_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/contents/{+path}","compare_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/merges","archive_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/downloads","issues_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues{/number}","pulls_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls{/number}","milestones_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/milestones{/number}","notifications_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/labels{/name}","releases_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/releases{/id}","deployments_url":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/deployments","created_at":"2018-04-18T10:06:20Z","updated_at":"2018-05-03T09:26:51Z","pushed_at":"2018-05-07T01:02:29Z","git_url":"git://github.com/SolutionInventors/Book-A-Meal.git","ssh_url":"[email protected]:SolutionInventors/Book-A-Meal.git","clone_url":"https://github.com/SolutionInventors/Book-A-Meal.git","svn_url":"https://github.com/SolutionInventors/Book-A-Meal","homepage":"https://solutioninventors.github.io/Book-A-Meal/","size":14162,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/8"},"html":{"href":"https://github.com/SolutionInventors/Book-A-Meal/pull/8"},"issue":{"href":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues/8"},"comments":{"href":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/SolutionInventors/Book-A-Meal/statuses/d95e3e88ecf0e93160408a36ffeb1f694da39896"}},"author_association":"OWNER"}} | {
"id": 130043263,
"name": "SolutionInventors/Book-A-Meal",
"url": "https://api.github.com/repos/SolutionInventors/Book-A-Meal"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-05-07T01:02:47 | 7635111014 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/comments/217196465","pull_request_review_id":154851894,"id":217196465,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE5NjQ2NQ==","diff_hunk":"@@ -0,0 +1,33 @@\n+extends KinematicBody2D\n+\n+const boomerang_scene = preload(\"res://scenes/boomerang/boomerang.tscn\")\n+var mouse_down = false\n+var boo = null\n+\n+# For controlling the boomerang.\n+func _input(event):\n+\tif event.is_pressed() and event is InputEventMouseButton and event.button_index == (BUTTON_LEFT):\n+\t\tif boo == null:\n+\t\t\tboo = boomerang_scene.instance()\n+\t\t\tboo.player = self\n+\t\t\t\n+\t\t\tget_parent().add_child(boo)\n+\t\t\tvar mouse_position = get_local_mouse_position()\n+\t\t\tboo.global_position = global_position\n+\t\t\tvar direction = (mouse_position).normalized()\n+\t\t\tboo.linear_velocity = direction * 3000","path":"godot/scenes/player/player.gd","position":18,"original_position":18,"commit_id":"6e25375c604dda69559fd40a103f0b1b4a2c68dc","original_commit_id":"6e25375c604dda69559fd40a103f0b1b4a2c68dc","user":{"login":"FeralBytes","id":7874274,"node_id":"MDQ6VXNlcjc4NzQyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7874274?v=4","gravatar_id":"","url":"https://api.github.com/users/FeralBytes","html_url":"https://github.com/FeralBytes","followers_url":"https://api.github.com/users/FeralBytes/followers","following_url":"https://api.github.com/users/FeralBytes/following{/other_user}","gists_url":"https://api.github.com/users/FeralBytes/gists{/gist_id}","starred_url":"https://api.github.com/users/FeralBytes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FeralBytes/subscriptions","organizations_url":"https://api.github.com/users/FeralBytes/orgs","repos_url":"https://api.github.com/users/FeralBytes/repos","events_url":"https://api.github.com/users/FeralBytes/events{/privacy}","received_events_url":"https://api.github.com/users/FeralBytes/received_events","type":"User","site_admin":false},"body":"3000 should be an export variable to allow easier testing.","created_at":"2018-09-12T21:31:08Z","updated_at":"2018-09-12T21:32:54Z","html_url":"https://github.com/agcodes-git/Godot_Game_V1/pull/14#discussion_r217196465","pull_request_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/comments/217196465"},"html":{"href":"https://github.com/agcodes-git/Godot_Game_V1/pull/14#discussion_r217196465"},"pull_request":{"href":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/14","id":214834237,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0ODM0MjM3","html_url":"https://github.com/agcodes-git/Godot_Game_V1/pull/14","diff_url":"https://github.com/agcodes-git/Godot_Game_V1/pull/14.diff","patch_url":"https://github.com/agcodes-git/Godot_Game_V1/pull/14.patch","issue_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues/14","number":14,"state":"open","locked":false,"title":"Early teleportation, bounce extension, and faster movement.","user":{"login":"agcodes-git","id":30957496,"node_id":"MDQ6VXNlcjMwOTU3NDk2","avatar_url":"https://avatars3.githubusercontent.com/u/30957496?v=4","gravatar_id":"","url":"https://api.github.com/users/agcodes-git","html_url":"https://github.com/agcodes-git","followers_url":"https://api.github.com/users/agcodes-git/followers","following_url":"https://api.github.com/users/agcodes-git/following{/other_user}","gists_url":"https://api.github.com/users/agcodes-git/gists{/gist_id}","starred_url":"https://api.github.com/users/agcodes-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agcodes-git/subscriptions","organizations_url":"https://api.github.com/users/agcodes-git/orgs","repos_url":"https://api.github.com/users/agcodes-git/repos","events_url":"https://api.github.com/users/agcodes-git/events{/privacy}","received_events_url":"https://api.github.com/users/agcodes-git/received_events","type":"User","site_admin":false},"body":"I made the following additions:\r\n\r\n Each collision adds 0.5s to the count-down timer before the player is automatically teleported.\r\n (we might want to fiddle with this value, 0.5 might be a bit too generous)\r\n The player can click any time before the count-down timer to teleport early.\r\n\r\nAnd the following modifications/fixes:\r\n\r\n Player motion (jumping/running) is faster.\r\n UseBoomerang.gd has been removed, and the code put in player.gd to avoid over-coupling.","created_at":"2018-09-12T04:43:18Z","updated_at":"2018-09-12T21:32:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b919c0927712196c92ba96afbc67adac83929f68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/14/commits","review_comments_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/14/comments","review_comment_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues/14/comments","statuses_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/statuses/6e25375c604dda69559fd40a103f0b1b4a2c68dc","head":{"label":"agcodes-git:ag_branch_5","ref":"ag_branch_5","sha":"6e25375c604dda69559fd40a103f0b1b4a2c68dc","user":{"login":"agcodes-git","id":30957496,"node_id":"MDQ6VXNlcjMwOTU3NDk2","avatar_url":"https://avatars3.githubusercontent.com/u/30957496?v=4","gravatar_id":"","url":"https://api.github.com/users/agcodes-git","html_url":"https://github.com/agcodes-git","followers_url":"https://api.github.com/users/agcodes-git/followers","following_url":"https://api.github.com/users/agcodes-git/following{/other_user}","gists_url":"https://api.github.com/users/agcodes-git/gists{/gist_id}","starred_url":"https://api.github.com/users/agcodes-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agcodes-git/subscriptions","organizations_url":"https://api.github.com/users/agcodes-git/orgs","repos_url":"https://api.github.com/users/agcodes-git/repos","events_url":"https://api.github.com/users/agcodes-git/events{/privacy}","received_events_url":"https://api.github.com/users/agcodes-git/received_events","type":"User","site_admin":false},"repo":{"id":147539887,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1Mzk4ODc=","name":"Godot_Game_V1","full_name":"agcodes-git/Godot_Game_V1","owner":{"login":"agcodes-git","id":30957496,"node_id":"MDQ6VXNlcjMwOTU3NDk2","avatar_url":"https://avatars3.githubusercontent.com/u/30957496?v=4","gravatar_id":"","url":"https://api.github.com/users/agcodes-git","html_url":"https://github.com/agcodes-git","followers_url":"https://api.github.com/users/agcodes-git/followers","following_url":"https://api.github.com/users/agcodes-git/following{/other_user}","gists_url":"https://api.github.com/users/agcodes-git/gists{/gist_id}","starred_url":"https://api.github.com/users/agcodes-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agcodes-git/subscriptions","organizations_url":"https://api.github.com/users/agcodes-git/orgs","repos_url":"https://api.github.com/users/agcodes-git/repos","events_url":"https://api.github.com/users/agcodes-git/events{/privacy}","received_events_url":"https://api.github.com/users/agcodes-git/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agcodes-git/Godot_Game_V1","description":null,"fork":false,"url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1","forks_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/forks","keys_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/teams","hooks_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/hooks","issue_events_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues/events{/number}","events_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/events","assignees_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/assignees{/user}","branches_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/branches{/branch}","tags_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/tags","blobs_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/refs{/sha}","trees_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/statuses/{sha}","languages_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/languages","stargazers_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/stargazers","contributors_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/contributors","subscribers_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/subscribers","subscription_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/subscription","commits_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/commits{/sha}","git_commits_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/commits{/sha}","comments_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/comments{/number}","issue_comment_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues/comments{/number}","contents_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/contents/{+path}","compare_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/merges","archive_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/downloads","issues_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues{/number}","pulls_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls{/number}","milestones_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/milestones{/number}","notifications_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/labels{/name}","releases_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/releases{/id}","deployments_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/deployments","created_at":"2018-09-05T15:27:22Z","updated_at":"2018-09-11T18:10:03Z","pushed_at":"2018-09-12T04:43:18Z","git_url":"git://github.com/agcodes-git/Godot_Game_V1.git","ssh_url":"[email protected]:agcodes-git/Godot_Game_V1.git","clone_url":"https://github.com/agcodes-git/Godot_Game_V1.git","svn_url":"https://github.com/agcodes-git/Godot_Game_V1","homepage":null,"size":646,"stargazers_count":1,"watchers_count":1,"language":"GDScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"agcodes-git:master","ref":"master","sha":"3578e895da71121582c5949f3d796f02afae1ef3","user":{"login":"agcodes-git","id":30957496,"node_id":"MDQ6VXNlcjMwOTU3NDk2","avatar_url":"https://avatars3.githubusercontent.com/u/30957496?v=4","gravatar_id":"","url":"https://api.github.com/users/agcodes-git","html_url":"https://github.com/agcodes-git","followers_url":"https://api.github.com/users/agcodes-git/followers","following_url":"https://api.github.com/users/agcodes-git/following{/other_user}","gists_url":"https://api.github.com/users/agcodes-git/gists{/gist_id}","starred_url":"https://api.github.com/users/agcodes-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agcodes-git/subscriptions","organizations_url":"https://api.github.com/users/agcodes-git/orgs","repos_url":"https://api.github.com/users/agcodes-git/repos","events_url":"https://api.github.com/users/agcodes-git/events{/privacy}","received_events_url":"https://api.github.com/users/agcodes-git/received_events","type":"User","site_admin":false},"repo":{"id":147539887,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1Mzk4ODc=","name":"Godot_Game_V1","full_name":"agcodes-git/Godot_Game_V1","owner":{"login":"agcodes-git","id":30957496,"node_id":"MDQ6VXNlcjMwOTU3NDk2","avatar_url":"https://avatars3.githubusercontent.com/u/30957496?v=4","gravatar_id":"","url":"https://api.github.com/users/agcodes-git","html_url":"https://github.com/agcodes-git","followers_url":"https://api.github.com/users/agcodes-git/followers","following_url":"https://api.github.com/users/agcodes-git/following{/other_user}","gists_url":"https://api.github.com/users/agcodes-git/gists{/gist_id}","starred_url":"https://api.github.com/users/agcodes-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agcodes-git/subscriptions","organizations_url":"https://api.github.com/users/agcodes-git/orgs","repos_url":"https://api.github.com/users/agcodes-git/repos","events_url":"https://api.github.com/users/agcodes-git/events{/privacy}","received_events_url":"https://api.github.com/users/agcodes-git/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agcodes-git/Godot_Game_V1","description":null,"fork":false,"url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1","forks_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/forks","keys_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/teams","hooks_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/hooks","issue_events_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues/events{/number}","events_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/events","assignees_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/assignees{/user}","branches_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/branches{/branch}","tags_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/tags","blobs_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/refs{/sha}","trees_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/statuses/{sha}","languages_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/languages","stargazers_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/stargazers","contributors_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/contributors","subscribers_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/subscribers","subscription_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/subscription","commits_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/commits{/sha}","git_commits_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/git/commits{/sha}","comments_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/comments{/number}","issue_comment_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues/comments{/number}","contents_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/contents/{+path}","compare_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/merges","archive_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/downloads","issues_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues{/number}","pulls_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls{/number}","milestones_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/milestones{/number}","notifications_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/labels{/name}","releases_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/releases{/id}","deployments_url":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/deployments","created_at":"2018-09-05T15:27:22Z","updated_at":"2018-09-11T18:10:03Z","pushed_at":"2018-09-12T04:43:18Z","git_url":"git://github.com/agcodes-git/Godot_Game_V1.git","ssh_url":"[email protected]:agcodes-git/Godot_Game_V1.git","clone_url":"https://github.com/agcodes-git/Godot_Game_V1.git","svn_url":"https://github.com/agcodes-git/Godot_Game_V1","homepage":null,"size":646,"stargazers_count":1,"watchers_count":1,"language":"GDScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/14"},"html":{"href":"https://github.com/agcodes-git/Godot_Game_V1/pull/14"},"issue":{"href":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues/14"},"comments":{"href":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/agcodes-git/Godot_Game_V1/statuses/6e25375c604dda69559fd40a103f0b1b4a2c68dc"}},"author_association":"OWNER"}} | {
"id": 147539887,
"name": "agcodes-git/Godot_Game_V1",
"url": "https://api.github.com/repos/agcodes-git/Godot_Game_V1"
} | {
"id": 7874274,
"login": "FeralBytes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7874274?",
"url": "https://api.github.com/users/FeralBytes"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-09-12T21:31:08 | 8256091547 | {"actor":{"display_login":"FeralBytes"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ariarijp/phpixela/pulls/comments/235749776","pull_request_review_id":177687341,"id":235749776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc0OTc3Ng==","diff_hunk":"@@ -1,2 +1,4 @@\n /vendor/\n-composer.lock\n\\ No newline at end of file\n+composer.lock\n+phpunit.xml\n+.idea","path":".gitignore","position":6,"original_position":6,"commit_id":"be1deb47c81918c7cbd2b5f0f7e4fde90c0b5230","original_commit_id":"be1deb47c81918c7cbd2b5f0f7e4fde90c0b5230","user":{"login":"mitukiti11","id":10477601,"node_id":"MDQ6VXNlcjEwNDc3NjAx","avatar_url":"https://avatars3.githubusercontent.com/u/10477601?v=4","gravatar_id":"","url":"https://api.github.com/users/mitukiti11","html_url":"https://github.com/mitukiti11","followers_url":"https://api.github.com/users/mitukiti11/followers","following_url":"https://api.github.com/users/mitukiti11/following{/other_user}","gists_url":"https://api.github.com/users/mitukiti11/gists{/gist_id}","starred_url":"https://api.github.com/users/mitukiti11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitukiti11/subscriptions","organizations_url":"https://api.github.com/users/mitukiti11/orgs","repos_url":"https://api.github.com/users/mitukiti11/repos","events_url":"https://api.github.com/users/mitukiti11/events{/privacy}","received_events_url":"https://api.github.com/users/mitukiti11/received_events","type":"User","site_admin":false},"body":"Thank you, I get it. \r\nSo I will restore it.","created_at":"2018-11-22T14:46:02Z","updated_at":"2018-11-22T14:46:02Z","html_url":"https://github.com/ariarijp/phpixela/pull/7#discussion_r235749776","pull_request_url":"https://api.github.com/repos/ariarijp/phpixela/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ariarijp/phpixela/pulls/comments/235749776"},"html":{"href":"https://github.com/ariarijp/phpixela/pull/7#discussion_r235749776"},"pull_request":{"href":"https://api.github.com/repos/ariarijp/phpixela/pulls/7"}},"in_reply_to_id":235628872},"pull_request":{"url":"https://api.github.com/repos/ariarijp/phpixela/pulls/7","id":228093741,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDkzNzQx","html_url":"https://github.com/ariarijp/phpixela/pull/7","diff_url":"https://github.com/ariarijp/phpixela/pull/7.diff","patch_url":"https://github.com/ariarijp/phpixela/pull/7.patch","issue_url":"https://api.github.com/repos/ariarijp/phpixela/issues/7","number":7,"state":"open","locked":false,"title":"add testcase. (phpunit, coveralls & travisci )","user":{"login":"mitukiti11","id":10477601,"node_id":"MDQ6VXNlcjEwNDc3NjAx","avatar_url":"https://avatars3.githubusercontent.com/u/10477601?v=4","gravatar_id":"","url":"https://api.github.com/users/mitukiti11","html_url":"https://github.com/mitukiti11","followers_url":"https://api.github.com/users/mitukiti11/followers","following_url":"https://api.github.com/users/mitukiti11/following{/other_user}","gists_url":"https://api.github.com/users/mitukiti11/gists{/gist_id}","starred_url":"https://api.github.com/users/mitukiti11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitukiti11/subscriptions","organizations_url":"https://api.github.com/users/mitukiti11/orgs","repos_url":"https://api.github.com/users/mitukiti11/repos","events_url":"https://api.github.com/users/mitukiti11/events{/privacy}","received_events_url":"https://api.github.com/users/mitukiti11/received_events","type":"User","site_admin":false},"body":"sample README.md badge:\r\nhttps://github.com/mitukiti11/phpixela/tree/develop\r\n\r\ncoveralls:\r\nhttps://coveralls.io/github/mitukiti11/phpixela?branch=develop\r\n\r\ntravisci :\r\nhttps://travis-ci.org/mitukiti11/phpixela","created_at":"2018-11-03T02:12:09Z","updated_at":"2018-11-22T14:46:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6b5d2767b977b83ae8ccee9587826071c39ffeb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ariarijp/phpixela/pulls/7/commits","review_comments_url":"https://api.github.com/repos/ariarijp/phpixela/pulls/7/comments","review_comment_url":"https://api.github.com/repos/ariarijp/phpixela/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ariarijp/phpixela/issues/7/comments","statuses_url":"https://api.github.com/repos/ariarijp/phpixela/statuses/be1deb47c81918c7cbd2b5f0f7e4fde90c0b5230","head":{"label":"mitukiti11:setting_phpunit","ref":"setting_phpunit","sha":"be1deb47c81918c7cbd2b5f0f7e4fde90c0b5230","user":{"login":"mitukiti11","id":10477601,"node_id":"MDQ6VXNlcjEwNDc3NjAx","avatar_url":"https://avatars3.githubusercontent.com/u/10477601?v=4","gravatar_id":"","url":"https://api.github.com/users/mitukiti11","html_url":"https://github.com/mitukiti11","followers_url":"https://api.github.com/users/mitukiti11/followers","following_url":"https://api.github.com/users/mitukiti11/following{/other_user}","gists_url":"https://api.github.com/users/mitukiti11/gists{/gist_id}","starred_url":"https://api.github.com/users/mitukiti11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitukiti11/subscriptions","organizations_url":"https://api.github.com/users/mitukiti11/orgs","repos_url":"https://api.github.com/users/mitukiti11/repos","events_url":"https://api.github.com/users/mitukiti11/events{/privacy}","received_events_url":"https://api.github.com/users/mitukiti11/received_events","type":"User","site_admin":false},"repo":{"id":155173802,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxNzM4MDI=","name":"phpixela","full_name":"mitukiti11/phpixela","private":false,"owner":{"login":"mitukiti11","id":10477601,"node_id":"MDQ6VXNlcjEwNDc3NjAx","avatar_url":"https://avatars3.githubusercontent.com/u/10477601?v=4","gravatar_id":"","url":"https://api.github.com/users/mitukiti11","html_url":"https://github.com/mitukiti11","followers_url":"https://api.github.com/users/mitukiti11/followers","following_url":"https://api.github.com/users/mitukiti11/following{/other_user}","gists_url":"https://api.github.com/users/mitukiti11/gists{/gist_id}","starred_url":"https://api.github.com/users/mitukiti11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitukiti11/subscriptions","organizations_url":"https://api.github.com/users/mitukiti11/orgs","repos_url":"https://api.github.com/users/mitukiti11/repos","events_url":"https://api.github.com/users/mitukiti11/events{/privacy}","received_events_url":"https://api.github.com/users/mitukiti11/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mitukiti11/phpixela","description":"Pixela API client for PHP","fork":true,"url":"https://api.github.com/repos/mitukiti11/phpixela","forks_url":"https://api.github.com/repos/mitukiti11/phpixela/forks","keys_url":"https://api.github.com/repos/mitukiti11/phpixela/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitukiti11/phpixela/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitukiti11/phpixela/teams","hooks_url":"https://api.github.com/repos/mitukiti11/phpixela/hooks","issue_events_url":"https://api.github.com/repos/mitukiti11/phpixela/issues/events{/number}","events_url":"https://api.github.com/repos/mitukiti11/phpixela/events","assignees_url":"https://api.github.com/repos/mitukiti11/phpixela/assignees{/user}","branches_url":"https://api.github.com/repos/mitukiti11/phpixela/branches{/branch}","tags_url":"https://api.github.com/repos/mitukiti11/phpixela/tags","blobs_url":"https://api.github.com/repos/mitukiti11/phpixela/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitukiti11/phpixela/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitukiti11/phpixela/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitukiti11/phpixela/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitukiti11/phpixela/statuses/{sha}","languages_url":"https://api.github.com/repos/mitukiti11/phpixela/languages","stargazers_url":"https://api.github.com/repos/mitukiti11/phpixela/stargazers","contributors_url":"https://api.github.com/repos/mitukiti11/phpixela/contributors","subscribers_url":"https://api.github.com/repos/mitukiti11/phpixela/subscribers","subscription_url":"https://api.github.com/repos/mitukiti11/phpixela/subscription","commits_url":"https://api.github.com/repos/mitukiti11/phpixela/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitukiti11/phpixela/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitukiti11/phpixela/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitukiti11/phpixela/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitukiti11/phpixela/contents/{+path}","compare_url":"https://api.github.com/repos/mitukiti11/phpixela/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitukiti11/phpixela/merges","archive_url":"https://api.github.com/repos/mitukiti11/phpixela/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitukiti11/phpixela/downloads","issues_url":"https://api.github.com/repos/mitukiti11/phpixela/issues{/number}","pulls_url":"https://api.github.com/repos/mitukiti11/phpixela/pulls{/number}","milestones_url":"https://api.github.com/repos/mitukiti11/phpixela/milestones{/number}","notifications_url":"https://api.github.com/repos/mitukiti11/phpixela/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitukiti11/phpixela/labels{/name}","releases_url":"https://api.github.com/repos/mitukiti11/phpixela/releases{/id}","deployments_url":"https://api.github.com/repos/mitukiti11/phpixela/deployments","created_at":"2018-10-29T08:03:32Z","updated_at":"2018-11-20T16:01:51Z","pushed_at":"2018-11-21T16:06:04Z","git_url":"git://github.com/mitukiti11/phpixela.git","ssh_url":"[email protected]:mitukiti11/phpixela.git","clone_url":"https://github.com/mitukiti11/phpixela.git","svn_url":"https://github.com/mitukiti11/phpixela","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ariarijp:master","ref":"master","sha":"61ea32dcdf89702751b8ed25baf21308b151c6f5","user":{"login":"ariarijp","id":635649,"node_id":"MDQ6VXNlcjYzNTY0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/635649?v=4","gravatar_id":"","url":"https://api.github.com/users/ariarijp","html_url":"https://github.com/ariarijp","followers_url":"https://api.github.com/users/ariarijp/followers","following_url":"https://api.github.com/users/ariarijp/following{/other_user}","gists_url":"https://api.github.com/users/ariarijp/gists{/gist_id}","starred_url":"https://api.github.com/users/ariarijp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariarijp/subscriptions","organizations_url":"https://api.github.com/users/ariarijp/orgs","repos_url":"https://api.github.com/users/ariarijp/repos","events_url":"https://api.github.com/users/ariarijp/events{/privacy}","received_events_url":"https://api.github.com/users/ariarijp/received_events","type":"User","site_admin":false},"repo":{"id":153307901,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMDc5MDE=","name":"phpixela","full_name":"ariarijp/phpixela","private":false,"owner":{"login":"ariarijp","id":635649,"node_id":"MDQ6VXNlcjYzNTY0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/635649?v=4","gravatar_id":"","url":"https://api.github.com/users/ariarijp","html_url":"https://github.com/ariarijp","followers_url":"https://api.github.com/users/ariarijp/followers","following_url":"https://api.github.com/users/ariarijp/following{/other_user}","gists_url":"https://api.github.com/users/ariarijp/gists{/gist_id}","starred_url":"https://api.github.com/users/ariarijp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariarijp/subscriptions","organizations_url":"https://api.github.com/users/ariarijp/orgs","repos_url":"https://api.github.com/users/ariarijp/repos","events_url":"https://api.github.com/users/ariarijp/events{/privacy}","received_events_url":"https://api.github.com/users/ariarijp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ariarijp/phpixela","description":"Pixela API client for PHP","fork":false,"url":"https://api.github.com/repos/ariarijp/phpixela","forks_url":"https://api.github.com/repos/ariarijp/phpixela/forks","keys_url":"https://api.github.com/repos/ariarijp/phpixela/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariarijp/phpixela/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariarijp/phpixela/teams","hooks_url":"https://api.github.com/repos/ariarijp/phpixela/hooks","issue_events_url":"https://api.github.com/repos/ariarijp/phpixela/issues/events{/number}","events_url":"https://api.github.com/repos/ariarijp/phpixela/events","assignees_url":"https://api.github.com/repos/ariarijp/phpixela/assignees{/user}","branches_url":"https://api.github.com/repos/ariarijp/phpixela/branches{/branch}","tags_url":"https://api.github.com/repos/ariarijp/phpixela/tags","blobs_url":"https://api.github.com/repos/ariarijp/phpixela/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariarijp/phpixela/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariarijp/phpixela/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariarijp/phpixela/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariarijp/phpixela/statuses/{sha}","languages_url":"https://api.github.com/repos/ariarijp/phpixela/languages","stargazers_url":"https://api.github.com/repos/ariarijp/phpixela/stargazers","contributors_url":"https://api.github.com/repos/ariarijp/phpixela/contributors","subscribers_url":"https://api.github.com/repos/ariarijp/phpixela/subscribers","subscription_url":"https://api.github.com/repos/ariarijp/phpixela/subscription","commits_url":"https://api.github.com/repos/ariarijp/phpixela/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariarijp/phpixela/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariarijp/phpixela/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariarijp/phpixela/issues/comments{/number}","contents_url":"https://api.github.com/repos/ariarijp/phpixela/contents/{+path}","compare_url":"https://api.github.com/repos/ariarijp/phpixela/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariarijp/phpixela/merges","archive_url":"https://api.github.com/repos/ariarijp/phpixela/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariarijp/phpixela/downloads","issues_url":"https://api.github.com/repos/ariarijp/phpixela/issues{/number}","pulls_url":"https://api.github.com/repos/ariarijp/phpixela/pulls{/number}","milestones_url":"https://api.github.com/repos/ariarijp/phpixela/milestones{/number}","notifications_url":"https://api.github.com/repos/ariarijp/phpixela/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariarijp/phpixela/labels{/name}","releases_url":"https://api.github.com/repos/ariarijp/phpixela/releases{/id}","deployments_url":"https://api.github.com/repos/ariarijp/phpixela/deployments","created_at":"2018-10-16T15:18:56Z","updated_at":"2018-11-18T13:55:50Z","pushed_at":"2018-11-21T16:06:05Z","git_url":"git://github.com/ariarijp/phpixela.git","ssh_url":"[email protected]:ariarijp/phpixela.git","clone_url":"https://github.com/ariarijp/phpixela.git","svn_url":"https://github.com/ariarijp/phpixela","homepage":null,"size":15,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ariarijp/phpixela/pulls/7"},"html":{"href":"https://github.com/ariarijp/phpixela/pull/7"},"issue":{"href":"https://api.github.com/repos/ariarijp/phpixela/issues/7"},"comments":{"href":"https://api.github.com/repos/ariarijp/phpixela/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/ariarijp/phpixela/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/ariarijp/phpixela/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ariarijp/phpixela/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/ariarijp/phpixela/statuses/be1deb47c81918c7cbd2b5f0f7e4fde90c0b5230"}},"author_association":"CONTRIBUTOR"}} | {
"id": 153307901,
"name": "ariarijp/phpixela",
"url": "https://api.github.com/repos/ariarijp/phpixela"
} | {
"id": 10477601,
"login": "mitukiti11",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10477601?",
"url": "https://api.github.com/users/mitukiti11"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-11-22T14:46:02 | 8633752946 | {"actor":{"display_login":"mitukiti11"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/comments/209582351","pull_request_review_id":145620757,"id":209582351,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTU4MjM1MQ==","diff_hunk":"@@ -209,6 +209,8 @@ struct PixelShader {\n char const_refs[32][32];\n };\n \n+static QString* get_input_var(struct PixelShader *ps, struct InputInfo in, bool is_alpha);","path":"hw/xbox/nv2a/nv2a_psh.c","position":31,"original_position":4,"commit_id":"80c22f20642285ba2ea14225f8f0012c22aecfcc","original_commit_id":"bbafe70c49a6037b2d1edd3bc6f351490a79de6b","user":{"login":"JayFoxRox","id":360330,"node_id":"MDQ6VXNlcjM2MDMzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/360330?v=4","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"body":"Rename commit to `ALPHA` instead of `A`, if it fits.","created_at":"2018-08-13T11:59:59Z","updated_at":"2018-08-13T11:59:59Z","html_url":"https://github.com/JayFoxRox/xqemu/pull/16#discussion_r209582351","pull_request_url":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/16","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/comments/209582351"},"html":{"href":"https://github.com/JayFoxRox/xqemu/pull/16#discussion_r209582351"},"pull_request":{"href":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/16","id":207848150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODQ4MTUw","html_url":"https://github.com/JayFoxRox/xqemu/pull/16","diff_url":"https://github.com/JayFoxRox/xqemu/pull/16.diff","patch_url":"https://github.com/JayFoxRox/xqemu/pull/16.patch","issue_url":"https://api.github.com/repos/JayFoxRox/xqemu/issues/16","number":16,"state":"open","locked":false,"title":"Refactor register combiner code","user":{"login":"JayFoxRox","id":360330,"node_id":"MDQ6VXNlcjM2MDMzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/360330?v=4","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"body":"Does a lot of smaller changes to bring our implementation closer to [NV_register_combiners](https://www.khronos.org/registry/OpenGL/extensions/NV/NV_register_combiners.txt).\r\n\r\n- Document that variables might be overwritten before they get used as input\r\n- Create issue for `BLUE_TO_ALPHA`?\r\n\r\nTODO:\r\n\r\n- Testing\r\n- Clean history","created_at":"2018-08-13T00:15:43Z","updated_at":"2018-08-13T11:59:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10f130cbb7f74fc4cf23afd8c5424f6eac043167","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/16/commits","review_comments_url":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/16/comments","review_comment_url":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JayFoxRox/xqemu/issues/16/comments","statuses_url":"https://api.github.com/repos/JayFoxRox/xqemu/statuses/80c22f20642285ba2ea14225f8f0012c22aecfcc","head":{"label":"JayFoxRox:psh-cleanup","ref":"psh-cleanup","sha":"80c22f20642285ba2ea14225f8f0012c22aecfcc","user":{"login":"JayFoxRox","id":360330,"node_id":"MDQ6VXNlcjM2MDMzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/360330?v=4","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"repo":{"id":139089822,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwODk4MjI=","name":"xqemu","full_name":"JayFoxRox/xqemu","owner":{"login":"JayFoxRox","id":360330,"node_id":"MDQ6VXNlcjM2MDMzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/360330?v=4","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JayFoxRox/xqemu","description":"Personal development repository for XQEMU (original Xbox Emulator)","fork":true,"url":"https://api.github.com/repos/JayFoxRox/xqemu","forks_url":"https://api.github.com/repos/JayFoxRox/xqemu/forks","keys_url":"https://api.github.com/repos/JayFoxRox/xqemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JayFoxRox/xqemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JayFoxRox/xqemu/teams","hooks_url":"https://api.github.com/repos/JayFoxRox/xqemu/hooks","issue_events_url":"https://api.github.com/repos/JayFoxRox/xqemu/issues/events{/number}","events_url":"https://api.github.com/repos/JayFoxRox/xqemu/events","assignees_url":"https://api.github.com/repos/JayFoxRox/xqemu/assignees{/user}","branches_url":"https://api.github.com/repos/JayFoxRox/xqemu/branches{/branch}","tags_url":"https://api.github.com/repos/JayFoxRox/xqemu/tags","blobs_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JayFoxRox/xqemu/statuses/{sha}","languages_url":"https://api.github.com/repos/JayFoxRox/xqemu/languages","stargazers_url":"https://api.github.com/repos/JayFoxRox/xqemu/stargazers","contributors_url":"https://api.github.com/repos/JayFoxRox/xqemu/contributors","subscribers_url":"https://api.github.com/repos/JayFoxRox/xqemu/subscribers","subscription_url":"https://api.github.com/repos/JayFoxRox/xqemu/subscription","commits_url":"https://api.github.com/repos/JayFoxRox/xqemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/JayFoxRox/xqemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/JayFoxRox/xqemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/JayFoxRox/xqemu/contents/{+path}","compare_url":"https://api.github.com/repos/JayFoxRox/xqemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JayFoxRox/xqemu/merges","archive_url":"https://api.github.com/repos/JayFoxRox/xqemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JayFoxRox/xqemu/downloads","issues_url":"https://api.github.com/repos/JayFoxRox/xqemu/issues{/number}","pulls_url":"https://api.github.com/repos/JayFoxRox/xqemu/pulls{/number}","milestones_url":"https://api.github.com/repos/JayFoxRox/xqemu/milestones{/number}","notifications_url":"https://api.github.com/repos/JayFoxRox/xqemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JayFoxRox/xqemu/labels{/name}","releases_url":"https://api.github.com/repos/JayFoxRox/xqemu/releases{/id}","deployments_url":"https://api.github.com/repos/JayFoxRox/xqemu/deployments","created_at":"2018-06-29T02:14:46Z","updated_at":"2018-08-13T02:30:32Z","pushed_at":"2018-08-13T11:57:36Z","git_url":"git://github.com/JayFoxRox/xqemu.git","ssh_url":"[email protected]:JayFoxRox/xqemu.git","clone_url":"https://github.com/JayFoxRox/xqemu.git","svn_url":"https://github.com/JayFoxRox/xqemu","homepage":"","size":179652,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":6,"default_branch":"README"}},"base":{"label":"JayFoxRox:master","ref":"master","sha":"92af9ca78e7b0e599bfc9af2ca4adae9053542ab","user":{"login":"JayFoxRox","id":360330,"node_id":"MDQ6VXNlcjM2MDMzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/360330?v=4","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"repo":{"id":139089822,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwODk4MjI=","name":"xqemu","full_name":"JayFoxRox/xqemu","owner":{"login":"JayFoxRox","id":360330,"node_id":"MDQ6VXNlcjM2MDMzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/360330?v=4","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JayFoxRox/xqemu","description":"Personal development repository for XQEMU (original Xbox Emulator)","fork":true,"url":"https://api.github.com/repos/JayFoxRox/xqemu","forks_url":"https://api.github.com/repos/JayFoxRox/xqemu/forks","keys_url":"https://api.github.com/repos/JayFoxRox/xqemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JayFoxRox/xqemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JayFoxRox/xqemu/teams","hooks_url":"https://api.github.com/repos/JayFoxRox/xqemu/hooks","issue_events_url":"https://api.github.com/repos/JayFoxRox/xqemu/issues/events{/number}","events_url":"https://api.github.com/repos/JayFoxRox/xqemu/events","assignees_url":"https://api.github.com/repos/JayFoxRox/xqemu/assignees{/user}","branches_url":"https://api.github.com/repos/JayFoxRox/xqemu/branches{/branch}","tags_url":"https://api.github.com/repos/JayFoxRox/xqemu/tags","blobs_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JayFoxRox/xqemu/statuses/{sha}","languages_url":"https://api.github.com/repos/JayFoxRox/xqemu/languages","stargazers_url":"https://api.github.com/repos/JayFoxRox/xqemu/stargazers","contributors_url":"https://api.github.com/repos/JayFoxRox/xqemu/contributors","subscribers_url":"https://api.github.com/repos/JayFoxRox/xqemu/subscribers","subscription_url":"https://api.github.com/repos/JayFoxRox/xqemu/subscription","commits_url":"https://api.github.com/repos/JayFoxRox/xqemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/JayFoxRox/xqemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/JayFoxRox/xqemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/JayFoxRox/xqemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/JayFoxRox/xqemu/contents/{+path}","compare_url":"https://api.github.com/repos/JayFoxRox/xqemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JayFoxRox/xqemu/merges","archive_url":"https://api.github.com/repos/JayFoxRox/xqemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JayFoxRox/xqemu/downloads","issues_url":"https://api.github.com/repos/JayFoxRox/xqemu/issues{/number}","pulls_url":"https://api.github.com/repos/JayFoxRox/xqemu/pulls{/number}","milestones_url":"https://api.github.com/repos/JayFoxRox/xqemu/milestones{/number}","notifications_url":"https://api.github.com/repos/JayFoxRox/xqemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JayFoxRox/xqemu/labels{/name}","releases_url":"https://api.github.com/repos/JayFoxRox/xqemu/releases{/id}","deployments_url":"https://api.github.com/repos/JayFoxRox/xqemu/deployments","created_at":"2018-06-29T02:14:46Z","updated_at":"2018-08-13T02:30:32Z","pushed_at":"2018-08-13T11:57:36Z","git_url":"git://github.com/JayFoxRox/xqemu.git","ssh_url":"[email protected]:JayFoxRox/xqemu.git","clone_url":"https://github.com/JayFoxRox/xqemu.git","svn_url":"https://github.com/JayFoxRox/xqemu","homepage":"","size":179652,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":6,"default_branch":"README"}},"_links":{"self":{"href":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/16"},"html":{"href":"https://github.com/JayFoxRox/xqemu/pull/16"},"issue":{"href":"https://api.github.com/repos/JayFoxRox/xqemu/issues/16"},"comments":{"href":"https://api.github.com/repos/JayFoxRox/xqemu/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JayFoxRox/xqemu/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/JayFoxRox/xqemu/statuses/80c22f20642285ba2ea14225f8f0012c22aecfcc"}},"author_association":"OWNER"}} | {
"id": 139089822,
"name": "JayFoxRox/xqemu",
"url": "https://api.github.com/repos/JayFoxRox/xqemu"
} | {
"id": 360330,
"login": "JayFoxRox",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/360330?",
"url": "https://api.github.com/users/JayFoxRox"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-08-13T11:59:59 | 8104546555 | {"actor":{"display_login":"JayFoxRox"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/comments/194286635","pull_request_review_id":127427992,"id":194286635,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDI4NjYzNQ==","diff_hunk":"@@ -64,10 +64,11 @@ public void FadeHUDToBlack(float fadeDuration = 0.5f)\n if (fadeTargetPanel == null || !allowFade)\n return;\n \n- fadeStartColor = Color.clear;\n+ fadeStartColor = new Color(0.39f, 0, 0, 0.4f);","path":"Assets/Scripts/Game/FadeBehaviour.cs","position":5,"original_position":5,"commit_id":"a3bdee3ae99dd0aac2e1326d642c7379a0dd5f15","original_commit_id":"a3bdee3ae99dd0aac2e1326d642c7379a0dd5f15","user":{"login":"MeteoricDragon","id":6538912,"node_id":"MDQ6VXNlcjY1Mzg5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6538912?v=4","gravatar_id":"","url":"https://api.github.com/users/MeteoricDragon","html_url":"https://github.com/MeteoricDragon","followers_url":"https://api.github.com/users/MeteoricDragon/followers","following_url":"https://api.github.com/users/MeteoricDragon/following{/other_user}","gists_url":"https://api.github.com/users/MeteoricDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/MeteoricDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeteoricDragon/subscriptions","organizations_url":"https://api.github.com/users/MeteoricDragon/orgs","repos_url":"https://api.github.com/users/MeteoricDragon/repos","events_url":"https://api.github.com/users/MeteoricDragon/events{/privacy}","received_events_url":"https://api.github.com/users/MeteoricDragon/received_events","type":"User","site_admin":false},"body":"I have an alternative solution, then. But by the way, visual studio's \"Find all references\" when used on FadeHUDToBlack() yields only one occurrence in PlayerDeath. But regardless it's best to keep this method unchanged in case other code uses it.\r\n\r\nRegardless, The better solution is that I can create another method FadeHUDBloodToBlack() in FadeBehavior.cs and have PlayerDeath call that method instead.","created_at":"2018-06-11T03:32:44Z","updated_at":"2018-06-11T03:32:45Z","html_url":"https://github.com/Interkarma/daggerfall-unity/pull/793#discussion_r194286635","pull_request_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/793","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/comments/194286635"},"html":{"href":"https://github.com/Interkarma/daggerfall-unity/pull/793#discussion_r194286635"},"pull_request":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/793"}},"in_reply_to_id":194284371},"pull_request":{"url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/793","id":193856803,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODU2ODAz","html_url":"https://github.com/Interkarma/daggerfall-unity/pull/793","diff_url":"https://github.com/Interkarma/daggerfall-unity/pull/793.diff","patch_url":"https://github.com/Interkarma/daggerfall-unity/pull/793.patch","issue_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/793","number":793,"state":"open","locked":false,"title":"Make death of player show red","user":{"login":"MeteoricDragon","id":6538912,"node_id":"MDQ6VXNlcjY1Mzg5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6538912?v=4","gravatar_id":"","url":"https://api.github.com/users/MeteoricDragon","html_url":"https://github.com/MeteoricDragon","followers_url":"https://api.github.com/users/MeteoricDragon/followers","following_url":"https://api.github.com/users/MeteoricDragon/following{/other_user}","gists_url":"https://api.github.com/users/MeteoricDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/MeteoricDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeteoricDragon/subscriptions","organizations_url":"https://api.github.com/users/MeteoricDragon/orgs","repos_url":"https://api.github.com/users/MeteoricDragon/repos","events_url":"https://api.github.com/users/MeteoricDragon/events{/privacy}","received_events_url":"https://api.github.com/users/MeteoricDragon/received_events","type":"User","site_admin":false},"body":"Edits FadeBehavior.FadeHUDToBlack() to have fadeStartColor = a blood red color and fade that to black instead of clear to black. I tested it in the game and it looks better than the inconsistent behavior that occurs that when you get hit and no flash of any sort occurs and it just fades to black. Try it out. ","created_at":"2018-06-11T01:15:22Z","updated_at":"2018-06-11T03:32:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da73412125e65f1b9602d3e248f86fa8946c2999","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/793/commits","review_comments_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/793/comments","review_comment_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/793/comments","statuses_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/statuses/a3bdee3ae99dd0aac2e1326d642c7379a0dd5f15","head":{"label":"MeteoricDragon:NearDeathExperienceBackup","ref":"NearDeathExperienceBackup","sha":"a3bdee3ae99dd0aac2e1326d642c7379a0dd5f15","user":{"login":"MeteoricDragon","id":6538912,"node_id":"MDQ6VXNlcjY1Mzg5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6538912?v=4","gravatar_id":"","url":"https://api.github.com/users/MeteoricDragon","html_url":"https://github.com/MeteoricDragon","followers_url":"https://api.github.com/users/MeteoricDragon/followers","following_url":"https://api.github.com/users/MeteoricDragon/following{/other_user}","gists_url":"https://api.github.com/users/MeteoricDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/MeteoricDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeteoricDragon/subscriptions","organizations_url":"https://api.github.com/users/MeteoricDragon/orgs","repos_url":"https://api.github.com/users/MeteoricDragon/repos","events_url":"https://api.github.com/users/MeteoricDragon/events{/privacy}","received_events_url":"https://api.github.com/users/MeteoricDragon/received_events","type":"User","site_admin":false},"repo":{"id":127360760,"node_id":"MDEwOlJlcG9zaXRvcnkxMjczNjA3NjA=","name":"daggerfall-unity","full_name":"MeteoricDragon/daggerfall-unity","owner":{"login":"MeteoricDragon","id":6538912,"node_id":"MDQ6VXNlcjY1Mzg5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6538912?v=4","gravatar_id":"","url":"https://api.github.com/users/MeteoricDragon","html_url":"https://github.com/MeteoricDragon","followers_url":"https://api.github.com/users/MeteoricDragon/followers","following_url":"https://api.github.com/users/MeteoricDragon/following{/other_user}","gists_url":"https://api.github.com/users/MeteoricDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/MeteoricDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeteoricDragon/subscriptions","organizations_url":"https://api.github.com/users/MeteoricDragon/orgs","repos_url":"https://api.github.com/users/MeteoricDragon/repos","events_url":"https://api.github.com/users/MeteoricDragon/events{/privacy}","received_events_url":"https://api.github.com/users/MeteoricDragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MeteoricDragon/daggerfall-unity","description":"Open source recreation of Daggerfall in the Unity engine","fork":true,"url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity","forks_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/forks","keys_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/teams","hooks_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/hooks","issue_events_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/issues/events{/number}","events_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/events","assignees_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/assignees{/user}","branches_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/branches{/branch}","tags_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/tags","blobs_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/statuses/{sha}","languages_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/languages","stargazers_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/stargazers","contributors_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/contributors","subscribers_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/subscribers","subscription_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/subscription","commits_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/contents/{+path}","compare_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/merges","archive_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/downloads","issues_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/issues{/number}","pulls_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/pulls{/number}","milestones_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/milestones{/number}","notifications_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/labels{/name}","releases_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/releases{/id}","deployments_url":"https://api.github.com/repos/MeteoricDragon/daggerfall-unity/deployments","created_at":"2018-03-30T00:21:30Z","updated_at":"2018-06-10T00:57:56Z","pushed_at":"2018-06-11T01:07:29Z","git_url":"git://github.com/MeteoricDragon/daggerfall-unity.git","ssh_url":"[email protected]:MeteoricDragon/daggerfall-unity.git","clone_url":"https://github.com/MeteoricDragon/daggerfall-unity.git","svn_url":"https://github.com/MeteoricDragon/daggerfall-unity","homepage":"http://www.dfworkshop.net","size":92766,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Interkarma:near-death-experience","ref":"near-death-experience","sha":"9739b0ceb19786011818c63c36feb07fbc96e0f9","user":{"login":"Interkarma","id":10426244,"node_id":"MDQ6VXNlcjEwNDI2MjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/10426244?v=4","gravatar_id":"","url":"https://api.github.com/users/Interkarma","html_url":"https://github.com/Interkarma","followers_url":"https://api.github.com/users/Interkarma/followers","following_url":"https://api.github.com/users/Interkarma/following{/other_user}","gists_url":"https://api.github.com/users/Interkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/Interkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Interkarma/subscriptions","organizations_url":"https://api.github.com/users/Interkarma/orgs","repos_url":"https://api.github.com/users/Interkarma/repos","events_url":"https://api.github.com/users/Interkarma/events{/privacy}","received_events_url":"https://api.github.com/users/Interkarma/received_events","type":"User","site_admin":false},"repo":{"id":28884050,"node_id":"MDEwOlJlcG9zaXRvcnkyODg4NDA1MA==","name":"daggerfall-unity","full_name":"Interkarma/daggerfall-unity","owner":{"login":"Interkarma","id":10426244,"node_id":"MDQ6VXNlcjEwNDI2MjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/10426244?v=4","gravatar_id":"","url":"https://api.github.com/users/Interkarma","html_url":"https://github.com/Interkarma","followers_url":"https://api.github.com/users/Interkarma/followers","following_url":"https://api.github.com/users/Interkarma/following{/other_user}","gists_url":"https://api.github.com/users/Interkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/Interkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Interkarma/subscriptions","organizations_url":"https://api.github.com/users/Interkarma/orgs","repos_url":"https://api.github.com/users/Interkarma/repos","events_url":"https://api.github.com/users/Interkarma/events{/privacy}","received_events_url":"https://api.github.com/users/Interkarma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Interkarma/daggerfall-unity","description":"Open source recreation of Daggerfall in the Unity engine","fork":false,"url":"https://api.github.com/repos/Interkarma/daggerfall-unity","forks_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/forks","keys_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/teams","hooks_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/hooks","issue_events_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/events{/number}","events_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/events","assignees_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/assignees{/user}","branches_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/branches{/branch}","tags_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/tags","blobs_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/statuses/{sha}","languages_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/languages","stargazers_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/stargazers","contributors_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/contributors","subscribers_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/subscribers","subscription_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/subscription","commits_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/contents/{+path}","compare_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/merges","archive_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/downloads","issues_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues{/number}","pulls_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls{/number}","milestones_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/milestones{/number}","notifications_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/labels{/name}","releases_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/releases{/id}","deployments_url":"https://api.github.com/repos/Interkarma/daggerfall-unity/deployments","created_at":"2015-01-06T21:18:36Z","updated_at":"2018-06-11T03:06:49Z","pushed_at":"2018-06-11T03:06:47Z","git_url":"git://github.com/Interkarma/daggerfall-unity.git","ssh_url":"[email protected]:Interkarma/daggerfall-unity.git","clone_url":"https://github.com/Interkarma/daggerfall-unity.git","svn_url":"https://github.com/Interkarma/daggerfall-unity","homepage":"http://www.dfworkshop.net","size":92757,"stargazers_count":364,"watchers_count":364,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":70,"open_issues":5,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/793"},"html":{"href":"https://github.com/Interkarma/daggerfall-unity/pull/793"},"issue":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/793"},"comments":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/issues/793/comments"},"review_comments":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/793/comments"},"review_comment":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/pulls/793/commits"},"statuses":{"href":"https://api.github.com/repos/Interkarma/daggerfall-unity/statuses/a3bdee3ae99dd0aac2e1326d642c7379a0dd5f15"}},"author_association":"CONTRIBUTOR"}} | {
"id": 28884050,
"name": "Interkarma/daggerfall-unity",
"url": "https://api.github.com/repos/Interkarma/daggerfall-unity"
} | {
"id": 6538912,
"login": "MeteoricDragon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6538912?",
"url": "https://api.github.com/users/MeteoricDragon"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-06-11T03:32:44 | 7803827732 | {"actor":{"display_login":"MeteoricDragon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/comments/236214714","pull_request_review_id":178192044,"id":236214714,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjIxNDcxNA==","diff_hunk":"@@ -0,0 +1,12 @@\n+namespace EHospital.Authorization.BusinessLogic\n+{\n+ using System.Threading.Tasks;\n+\n+ public class EmailSender : IEmailSender\n+ {\n+ public Task SendEmailAsync(string email, string subject, string message)\n+ {\n+ return Task.CompletedTask;","path":"EHospital.Authorization.BusinessLogic/EmailAction/EmailSender.cs","position":9,"original_position":9,"commit_id":"f1feff4b83db0ae49db736794ed85a86a1aea4f2","original_commit_id":"f1feff4b83db0ae49db736794ed85a86a1aea4f2","user":{"login":"anton-borodulin-softserve","id":44321717,"node_id":"MDQ6VXNlcjQ0MzIxNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/44321717?v=4","gravatar_id":"","url":"https://api.github.com/users/anton-borodulin-softserve","html_url":"https://github.com/anton-borodulin-softserve","followers_url":"https://api.github.com/users/anton-borodulin-softserve/followers","following_url":"https://api.github.com/users/anton-borodulin-softserve/following{/other_user}","gists_url":"https://api.github.com/users/anton-borodulin-softserve/gists{/gist_id}","starred_url":"https://api.github.com/users/anton-borodulin-softserve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anton-borodulin-softserve/subscriptions","organizations_url":"https://api.github.com/users/anton-borodulin-softserve/orgs","repos_url":"https://api.github.com/users/anton-borodulin-softserve/repos","events_url":"https://api.github.com/users/anton-borodulin-softserve/events{/privacy}","received_events_url":"https://api.github.com/users/anton-borodulin-softserve/received_events","type":"User","site_admin":false},"body":"For such case you can just throw new NotImplementedException(); and write TODO: .....","created_at":"2018-11-26T11:21:42Z","updated_at":"2018-11-26T11:53:08Z","html_url":"https://github.com/Kropisha/eHospital.Authorization/pull/1#discussion_r236214714","pull_request_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/comments/236214714"},"html":{"href":"https://github.com/Kropisha/eHospital.Authorization/pull/1#discussion_r236214714"},"pull_request":{"href":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/1","id":233380241,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzgwMjQx","html_url":"https://github.com/Kropisha/eHospital.Authorization/pull/1","diff_url":"https://github.com/Kropisha/eHospital.Authorization/pull/1.diff","patch_url":"https://github.com/Kropisha/eHospital.Authorization/pull/1.patch","issue_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues/1","number":1,"state":"open","locked":false,"title":"Add authorization","user":{"login":"Kropisha","id":26092287,"node_id":"MDQ6VXNlcjI2MDkyMjg3","avatar_url":"https://avatars2.githubusercontent.com/u/26092287?v=4","gravatar_id":"","url":"https://api.github.com/users/Kropisha","html_url":"https://github.com/Kropisha","followers_url":"https://api.github.com/users/Kropisha/followers","following_url":"https://api.github.com/users/Kropisha/following{/other_user}","gists_url":"https://api.github.com/users/Kropisha/gists{/gist_id}","starred_url":"https://api.github.com/users/Kropisha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kropisha/subscriptions","organizations_url":"https://api.github.com/users/Kropisha/orgs","repos_url":"https://api.github.com/users/Kropisha/repos","events_url":"https://api.github.com/users/Kropisha/events{/privacy}","received_events_url":"https://api.github.com/users/Kropisha/received_events","type":"User","site_admin":false},"body":"Some general view","created_at":"2018-11-25T14:54:01Z","updated_at":"2018-11-26T11:53:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2e605d6c37bac4cca91ea01855032b042bc7501","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues/1/comments","statuses_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/statuses/f1feff4b83db0ae49db736794ed85a86a1aea4f2","head":{"label":"Kropisha:add-Authorization","ref":"add-Authorization","sha":"f1feff4b83db0ae49db736794ed85a86a1aea4f2","user":{"login":"Kropisha","id":26092287,"node_id":"MDQ6VXNlcjI2MDkyMjg3","avatar_url":"https://avatars2.githubusercontent.com/u/26092287?v=4","gravatar_id":"","url":"https://api.github.com/users/Kropisha","html_url":"https://github.com/Kropisha","followers_url":"https://api.github.com/users/Kropisha/followers","following_url":"https://api.github.com/users/Kropisha/following{/other_user}","gists_url":"https://api.github.com/users/Kropisha/gists{/gist_id}","starred_url":"https://api.github.com/users/Kropisha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kropisha/subscriptions","organizations_url":"https://api.github.com/users/Kropisha/orgs","repos_url":"https://api.github.com/users/Kropisha/repos","events_url":"https://api.github.com/users/Kropisha/events{/privacy}","received_events_url":"https://api.github.com/users/Kropisha/received_events","type":"User","site_admin":false},"repo":{"id":157126019,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcxMjYwMTk=","name":"eHospital.Authorization","full_name":"Kropisha/eHospital.Authorization","private":false,"owner":{"login":"Kropisha","id":26092287,"node_id":"MDQ6VXNlcjI2MDkyMjg3","avatar_url":"https://avatars2.githubusercontent.com/u/26092287?v=4","gravatar_id":"","url":"https://api.github.com/users/Kropisha","html_url":"https://github.com/Kropisha","followers_url":"https://api.github.com/users/Kropisha/followers","following_url":"https://api.github.com/users/Kropisha/following{/other_user}","gists_url":"https://api.github.com/users/Kropisha/gists{/gist_id}","starred_url":"https://api.github.com/users/Kropisha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kropisha/subscriptions","organizations_url":"https://api.github.com/users/Kropisha/orgs","repos_url":"https://api.github.com/users/Kropisha/repos","events_url":"https://api.github.com/users/Kropisha/events{/privacy}","received_events_url":"https://api.github.com/users/Kropisha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Kropisha/eHospital.Authorization","description":"Authorization service for eHospital","fork":false,"url":"https://api.github.com/repos/Kropisha/eHospital.Authorization","forks_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/forks","keys_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/teams","hooks_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/hooks","issue_events_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues/events{/number}","events_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/events","assignees_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/assignees{/user}","branches_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/branches{/branch}","tags_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/tags","blobs_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/statuses/{sha}","languages_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/languages","stargazers_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/stargazers","contributors_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/contributors","subscribers_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/subscribers","subscription_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/subscription","commits_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/contents/{+path}","compare_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/merges","archive_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/downloads","issues_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues{/number}","pulls_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls{/number}","milestones_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/milestones{/number}","notifications_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/labels{/name}","releases_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/releases{/id}","deployments_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/deployments","created_at":"2018-11-11T22:09:45Z","updated_at":"2018-11-11T22:15:56Z","pushed_at":"2018-11-25T14:54:02Z","git_url":"git://github.com/Kropisha/eHospital.Authorization.git","ssh_url":"[email protected]:Kropisha/eHospital.Authorization.git","clone_url":"https://github.com/Kropisha/eHospital.Authorization.git","svn_url":"https://github.com/Kropisha/eHospital.Authorization","homepage":null,"size":82,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Kropisha:master","ref":"master","sha":"92d759d86ab964e3fdb361c876b7aa8675294a0a","user":{"login":"Kropisha","id":26092287,"node_id":"MDQ6VXNlcjI2MDkyMjg3","avatar_url":"https://avatars2.githubusercontent.com/u/26092287?v=4","gravatar_id":"","url":"https://api.github.com/users/Kropisha","html_url":"https://github.com/Kropisha","followers_url":"https://api.github.com/users/Kropisha/followers","following_url":"https://api.github.com/users/Kropisha/following{/other_user}","gists_url":"https://api.github.com/users/Kropisha/gists{/gist_id}","starred_url":"https://api.github.com/users/Kropisha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kropisha/subscriptions","organizations_url":"https://api.github.com/users/Kropisha/orgs","repos_url":"https://api.github.com/users/Kropisha/repos","events_url":"https://api.github.com/users/Kropisha/events{/privacy}","received_events_url":"https://api.github.com/users/Kropisha/received_events","type":"User","site_admin":false},"repo":{"id":157126019,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcxMjYwMTk=","name":"eHospital.Authorization","full_name":"Kropisha/eHospital.Authorization","private":false,"owner":{"login":"Kropisha","id":26092287,"node_id":"MDQ6VXNlcjI2MDkyMjg3","avatar_url":"https://avatars2.githubusercontent.com/u/26092287?v=4","gravatar_id":"","url":"https://api.github.com/users/Kropisha","html_url":"https://github.com/Kropisha","followers_url":"https://api.github.com/users/Kropisha/followers","following_url":"https://api.github.com/users/Kropisha/following{/other_user}","gists_url":"https://api.github.com/users/Kropisha/gists{/gist_id}","starred_url":"https://api.github.com/users/Kropisha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kropisha/subscriptions","organizations_url":"https://api.github.com/users/Kropisha/orgs","repos_url":"https://api.github.com/users/Kropisha/repos","events_url":"https://api.github.com/users/Kropisha/events{/privacy}","received_events_url":"https://api.github.com/users/Kropisha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Kropisha/eHospital.Authorization","description":"Authorization service for eHospital","fork":false,"url":"https://api.github.com/repos/Kropisha/eHospital.Authorization","forks_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/forks","keys_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/teams","hooks_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/hooks","issue_events_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues/events{/number}","events_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/events","assignees_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/assignees{/user}","branches_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/branches{/branch}","tags_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/tags","blobs_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/statuses/{sha}","languages_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/languages","stargazers_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/stargazers","contributors_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/contributors","subscribers_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/subscribers","subscription_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/subscription","commits_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/contents/{+path}","compare_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/merges","archive_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/downloads","issues_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues{/number}","pulls_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls{/number}","milestones_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/milestones{/number}","notifications_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/labels{/name}","releases_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/releases{/id}","deployments_url":"https://api.github.com/repos/Kropisha/eHospital.Authorization/deployments","created_at":"2018-11-11T22:09:45Z","updated_at":"2018-11-11T22:15:56Z","pushed_at":"2018-11-25T14:54:02Z","git_url":"git://github.com/Kropisha/eHospital.Authorization.git","ssh_url":"[email protected]:Kropisha/eHospital.Authorization.git","clone_url":"https://github.com/Kropisha/eHospital.Authorization.git","svn_url":"https://github.com/Kropisha/eHospital.Authorization","homepage":null,"size":82,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/1"},"html":{"href":"https://github.com/Kropisha/eHospital.Authorization/pull/1"},"issue":{"href":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues/1"},"comments":{"href":"https://api.github.com/repos/Kropisha/eHospital.Authorization/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kropisha/eHospital.Authorization/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Kropisha/eHospital.Authorization/statuses/f1feff4b83db0ae49db736794ed85a86a1aea4f2"}},"author_association":"OWNER"}} | {
"id": 157126019,
"name": "Kropisha/eHospital.Authorization",
"url": "https://api.github.com/repos/Kropisha/eHospital.Authorization"
} | {
"id": 44321717,
"login": "anton-borodulin-softserve",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44321717?",
"url": "https://api.github.com/users/anton-borodulin-softserve"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-11-26T11:21:42 | 8646623542 | {"actor":{"display_login":"anton-borodulin-softserve"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/comments/181482483","pull_request_review_id":112125435,"id":181482483,"diff_hunk":"@@ -96,8 +96,13 @@ def is_http_redirect?(status)\n status >= 300 && status <= 399\n end\n \n- def rpc_path(service_full_name, rpc_method)\n- \"/#{service_full_name}/#{rpc_method}\"\n+ def make_http_request(conn, service_full_name, rpc_method, content_type, body)\n+ conn.post do |r|\n+ r.url \"#{service_full_name}/#{rpc_method}\"","path":"lib/twirp/client.rb","position":8,"original_position":8,"commit_id":"025e5d13d17c467ee3722fcd9d01e5457eac08d3","original_commit_id":"025e5d13d17c467ee3722fcd9d01e5457eac08d3","user":{"login":"KMontag42","id":1686738,"avatar_url":"https://avatars2.githubusercontent.com/u/1686738?v=4","gravatar_id":"","url":"https://api.github.com/users/KMontag42","html_url":"https://github.com/KMontag42","followers_url":"https://api.github.com/users/KMontag42/followers","following_url":"https://api.github.com/users/KMontag42/following{/other_user}","gists_url":"https://api.github.com/users/KMontag42/gists{/gist_id}","starred_url":"https://api.github.com/users/KMontag42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KMontag42/subscriptions","organizations_url":"https://api.github.com/users/KMontag42/orgs","repos_url":"https://api.github.com/users/KMontag42/repos","events_url":"https://api.github.com/users/KMontag42/events{/privacy}","received_events_url":"https://api.github.com/users/KMontag42/received_events","type":"User","site_admin":false},"body":"maybe use the class-level method `Client#rpc_name` here? Since it removes the usage of magic strings across the codebase.","created_at":"2018-04-13T19:01:49Z","updated_at":"2018-04-13T19:01:49Z","html_url":"https://github.com/cyrusaf/ruby-twirp/pull/9#discussion_r181482483","pull_request_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/9","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/comments/181482483"},"html":{"href":"https://github.com/cyrusaf/ruby-twirp/pull/9#discussion_r181482483"},"pull_request":{"href":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/9","id":181567969,"html_url":"https://github.com/cyrusaf/ruby-twirp/pull/9","diff_url":"https://github.com/cyrusaf/ruby-twirp/pull/9.diff","patch_url":"https://github.com/cyrusaf/ruby-twirp/pull/9.patch","issue_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues/9","number":9,"state":"closed","locked":false,"title":"Fix base url","user":{"login":"marioizquierdo","id":242139,"avatar_url":"https://avatars0.githubusercontent.com/u/242139?v=4","gravatar_id":"","url":"https://api.github.com/users/marioizquierdo","html_url":"https://github.com/marioizquierdo","followers_url":"https://api.github.com/users/marioizquierdo/followers","following_url":"https://api.github.com/users/marioizquierdo/following{/other_user}","gists_url":"https://api.github.com/users/marioizquierdo/gists{/gist_id}","starred_url":"https://api.github.com/users/marioizquierdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marioizquierdo/subscriptions","organizations_url":"https://api.github.com/users/marioizquierdo/orgs","repos_url":"https://api.github.com/users/marioizquierdo/repos","events_url":"https://api.github.com/users/marioizquierdo/events{/privacy}","received_events_url":"https://api.github.com/users/marioizquierdo/received_events","type":"User","site_admin":false},"body":"Using a base_url with a path prefix was not working as expected: the path prefix was being ignored. This was reported in this PR: https://github.com/cyrusaf/ruby-twirp/pull/8, but the problem was a missunderstanding of the twirp protocol v6 (still unpublished) and also a bug in the code that was preventing the right behavior.\r\n\r\nThe issue is that the client was using url: `\"/#{service_full_name}/...\"` (with a leading slash), which for Faraday means to use an absolute URL, thus ignoring the prefix (see issue https://github.com/lostisland/faraday/issues/293).\r\n\r\nThe fix was just to remove the leading slash in the url: `\"#{service_full_name}/...\" to make it a relative path, thus respecting the path prefix.\r\n\r\nIn addition, the example app and README were changed to represent the common case of using a `/twirp` prefix in the URL.","created_at":"2018-04-13T18:49:43Z","updated_at":"2018-04-13T19:01:49Z","closed_at":"2018-04-13T18:56:07Z","merged_at":"2018-04-13T18:56:07Z","merge_commit_sha":"6f2e5a52a70f2ca819af43110586fc63b435a3a0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/9/commits","review_comments_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/9/comments","review_comment_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues/9/comments","statuses_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/statuses/025e5d13d17c467ee3722fcd9d01e5457eac08d3","head":{"label":"cyrusaf:fix_base_url","ref":"fix_base_url","sha":"025e5d13d17c467ee3722fcd9d01e5457eac08d3","user":{"login":"cyrusaf","id":700894,"avatar_url":"https://avatars1.githubusercontent.com/u/700894?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrusaf","html_url":"https://github.com/cyrusaf","followers_url":"https://api.github.com/users/cyrusaf/followers","following_url":"https://api.github.com/users/cyrusaf/following{/other_user}","gists_url":"https://api.github.com/users/cyrusaf/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrusaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrusaf/subscriptions","organizations_url":"https://api.github.com/users/cyrusaf/orgs","repos_url":"https://api.github.com/users/cyrusaf/repos","events_url":"https://api.github.com/users/cyrusaf/events{/privacy}","received_events_url":"https://api.github.com/users/cyrusaf/received_events","type":"User","site_admin":false},"repo":{"id":120237979,"name":"ruby-twirp","full_name":"cyrusaf/ruby-twirp","owner":{"login":"cyrusaf","id":700894,"avatar_url":"https://avatars1.githubusercontent.com/u/700894?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrusaf","html_url":"https://github.com/cyrusaf","followers_url":"https://api.github.com/users/cyrusaf/followers","following_url":"https://api.github.com/users/cyrusaf/following{/other_user}","gists_url":"https://api.github.com/users/cyrusaf/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrusaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrusaf/subscriptions","organizations_url":"https://api.github.com/users/cyrusaf/orgs","repos_url":"https://api.github.com/users/cyrusaf/repos","events_url":"https://api.github.com/users/cyrusaf/events{/privacy}","received_events_url":"https://api.github.com/users/cyrusaf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyrusaf/ruby-twirp","description":"Twirp services in Ruby","fork":false,"url":"https://api.github.com/repos/cyrusaf/ruby-twirp","forks_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/forks","keys_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/teams","hooks_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/hooks","issue_events_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues/events{/number}","events_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/events","assignees_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/assignees{/user}","branches_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/branches{/branch}","tags_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/tags","blobs_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/statuses/{sha}","languages_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/languages","stargazers_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/stargazers","contributors_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/contributors","subscribers_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/subscribers","subscription_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/subscription","commits_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/contents/{+path}","compare_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/merges","archive_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/downloads","issues_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues{/number}","pulls_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls{/number}","milestones_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/milestones{/number}","notifications_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/labels{/name}","releases_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/releases{/id}","deployments_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/deployments","created_at":"2018-02-05T00:57:31Z","updated_at":"2018-04-13T18:56:09Z","pushed_at":"2018-04-13T18:56:08Z","git_url":"git://github.com/cyrusaf/ruby-twirp.git","ssh_url":"[email protected]:cyrusaf/ruby-twirp.git","clone_url":"https://github.com/cyrusaf/ruby-twirp.git","svn_url":"https://github.com/cyrusaf/ruby-twirp","homepage":"","size":182,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"cyrusaf:master","ref":"master","sha":"414e2b3525d5202c53401f856060f0224690ea23","user":{"login":"cyrusaf","id":700894,"avatar_url":"https://avatars1.githubusercontent.com/u/700894?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrusaf","html_url":"https://github.com/cyrusaf","followers_url":"https://api.github.com/users/cyrusaf/followers","following_url":"https://api.github.com/users/cyrusaf/following{/other_user}","gists_url":"https://api.github.com/users/cyrusaf/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrusaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrusaf/subscriptions","organizations_url":"https://api.github.com/users/cyrusaf/orgs","repos_url":"https://api.github.com/users/cyrusaf/repos","events_url":"https://api.github.com/users/cyrusaf/events{/privacy}","received_events_url":"https://api.github.com/users/cyrusaf/received_events","type":"User","site_admin":false},"repo":{"id":120237979,"name":"ruby-twirp","full_name":"cyrusaf/ruby-twirp","owner":{"login":"cyrusaf","id":700894,"avatar_url":"https://avatars1.githubusercontent.com/u/700894?v=4","gravatar_id":"","url":"https://api.github.com/users/cyrusaf","html_url":"https://github.com/cyrusaf","followers_url":"https://api.github.com/users/cyrusaf/followers","following_url":"https://api.github.com/users/cyrusaf/following{/other_user}","gists_url":"https://api.github.com/users/cyrusaf/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrusaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrusaf/subscriptions","organizations_url":"https://api.github.com/users/cyrusaf/orgs","repos_url":"https://api.github.com/users/cyrusaf/repos","events_url":"https://api.github.com/users/cyrusaf/events{/privacy}","received_events_url":"https://api.github.com/users/cyrusaf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyrusaf/ruby-twirp","description":"Twirp services in Ruby","fork":false,"url":"https://api.github.com/repos/cyrusaf/ruby-twirp","forks_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/forks","keys_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/teams","hooks_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/hooks","issue_events_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues/events{/number}","events_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/events","assignees_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/assignees{/user}","branches_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/branches{/branch}","tags_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/tags","blobs_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/statuses/{sha}","languages_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/languages","stargazers_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/stargazers","contributors_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/contributors","subscribers_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/subscribers","subscription_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/subscription","commits_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/contents/{+path}","compare_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/merges","archive_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/downloads","issues_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues{/number}","pulls_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls{/number}","milestones_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/milestones{/number}","notifications_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/labels{/name}","releases_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/releases{/id}","deployments_url":"https://api.github.com/repos/cyrusaf/ruby-twirp/deployments","created_at":"2018-02-05T00:57:31Z","updated_at":"2018-04-13T18:56:09Z","pushed_at":"2018-04-13T18:56:08Z","git_url":"git://github.com/cyrusaf/ruby-twirp.git","ssh_url":"[email protected]:cyrusaf/ruby-twirp.git","clone_url":"https://github.com/cyrusaf/ruby-twirp.git","svn_url":"https://github.com/cyrusaf/ruby-twirp","homepage":"","size":182,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/9"},"html":{"href":"https://github.com/cyrusaf/ruby-twirp/pull/9"},"issue":{"href":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues/9"},"comments":{"href":"https://api.github.com/repos/cyrusaf/ruby-twirp/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyrusaf/ruby-twirp/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/cyrusaf/ruby-twirp/statuses/025e5d13d17c467ee3722fcd9d01e5457eac08d3"}},"author_association":"COLLABORATOR"}} | {
"id": 120237979,
"name": "cyrusaf/ruby-twirp",
"url": "https://api.github.com/repos/cyrusaf/ruby-twirp"
} | {
"id": 1686738,
"login": "KMontag42",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1686738?",
"url": "https://api.github.com/users/KMontag42"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-04-13T19:01:49 | 7527987096 | {"actor":{"display_login":"KMontag42"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tsumichan/todo-app/pulls/comments/209152556","pull_request_review_id":145112544,"id":209152556,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTE1MjU1Ng==","diff_hunk":"@@ -0,0 +1,20 @@\n+class SessionsController < ApplicationController\n+ def new\n+ end\n+\n+ def create\n+ user = User.find_by(name: params[:session][:name].downcase)","path":"app/controllers/sessions_controller.rb","position":6,"original_position":6,"commit_id":"a7917a8e976b9642d0d2b525aae97668918e153d","original_commit_id":"8633b071a57dc3e88bcaa74b3d8bdc135d29b144","user":{"login":"tsumichan","id":14156156,"node_id":"MDQ6VXNlcjE0MTU2MTU2","avatar_url":"https://avatars0.githubusercontent.com/u/14156156?v=4","gravatar_id":"","url":"https://api.github.com/users/tsumichan","html_url":"https://github.com/tsumichan","followers_url":"https://api.github.com/users/tsumichan/followers","following_url":"https://api.github.com/users/tsumichan/following{/other_user}","gists_url":"https://api.github.com/users/tsumichan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsumichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsumichan/subscriptions","organizations_url":"https://api.github.com/users/tsumichan/orgs","repos_url":"https://api.github.com/users/tsumichan/repos","events_url":"https://api.github.com/users/tsumichan/events{/privacy}","received_events_url":"https://api.github.com/users/tsumichan/received_events","type":"User","site_admin":false},"body":"ログインするときに大文字が入っているとログインできないので、小文字にしてから`find_by`するようにしています","created_at":"2018-08-10T06:06:51Z","updated_at":"2018-08-10T06:06:51Z","html_url":"https://github.com/tsumichan/todo-app/pull/38#discussion_r209152556","pull_request_url":"https://api.github.com/repos/tsumichan/todo-app/pulls/38","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tsumichan/todo-app/pulls/comments/209152556"},"html":{"href":"https://github.com/tsumichan/todo-app/pull/38#discussion_r209152556"},"pull_request":{"href":"https://api.github.com/repos/tsumichan/todo-app/pulls/38"}},"in_reply_to_id":209138215},"pull_request":{"url":"https://api.github.com/repos/tsumichan/todo-app/pulls/38","id":207497073,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDk3MDcz","html_url":"https://github.com/tsumichan/todo-app/pull/38","diff_url":"https://github.com/tsumichan/todo-app/pull/38.diff","patch_url":"https://github.com/tsumichan/todo-app/pull/38.patch","issue_url":"https://api.github.com/repos/tsumichan/todo-app/issues/38","number":38,"state":"open","locked":false,"title":"ログイン・ログアウトができるようにした","user":{"login":"tsumichan","id":14156156,"node_id":"MDQ6VXNlcjE0MTU2MTU2","avatar_url":"https://avatars0.githubusercontent.com/u/14156156?v=4","gravatar_id":"","url":"https://api.github.com/users/tsumichan","html_url":"https://github.com/tsumichan","followers_url":"https://api.github.com/users/tsumichan/followers","following_url":"https://api.github.com/users/tsumichan/following{/other_user}","gists_url":"https://api.github.com/users/tsumichan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsumichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsumichan/subscriptions","organizations_url":"https://api.github.com/users/tsumichan/orgs","repos_url":"https://api.github.com/users/tsumichan/repos","events_url":"https://api.github.com/users/tsumichan/events{/privacy}","received_events_url":"https://api.github.com/users/tsumichan/received_events","type":"User","site_admin":false},"body":"## 何をやったか\r\n\r\n- ログイン・ログアウトの機能を実装しました。\r\n - ヘッダーにログイン中のユーザー名とログアウトリンクが表示されます\r\n - ログインすると、自分が作成したタスクのみが表示されます\r\n- ヘッダーのリンクたちを日本語で表示できるようにしました\r\n\r\n👇 **ログインしていない状態でトップページ（タスク一覧）にアクセスするとログインしてください！と言われます**\r\n\r\n\r\n👇 **ログインするとヘッダーにログイン中のユーザー名とログアウトリンクが表示されます**\r\n\r\n\r\n👇 **ログアウトもできます**\r\n\r\n\r\n\r\n## レビューポイント\r\n- 余計なインデント、スペースがないか\r\n- ログイン・ログアウトの処理が正しく書けているかどうか\r\n- テストが正しく書けているかどうか\r\n- 無駄な記述の仕方をしていないか\r\n\r\n特にテストがやばすぎるので助けて（？）ください。\r\n\r\n## レビュアー\r\n@shiro16 さん、 @june29 さんどちらかは必須\r\n\r\nその他どなたでもお願いします :pray:\r\n","created_at":"2018-08-10T03:21:07Z","updated_at":"2018-08-10T06:06:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72e8c76fcc9e8fd13e9ce457b502946dc00630aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":971117308,"node_id":"MDU6TGFiZWw5NzExMTczMDg=","url":"https://api.github.com/repos/tsumichan/todo-app/labels/In%20Review","name":"In Review","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tsumichan/todo-app/pulls/38/commits","review_comments_url":"https://api.github.com/repos/tsumichan/todo-app/pulls/38/comments","review_comment_url":"https://api.github.com/repos/tsumichan/todo-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tsumichan/todo-app/issues/38/comments","statuses_url":"https://api.github.com/repos/tsumichan/todo-app/statuses/a7917a8e976b9642d0d2b525aae97668918e153d","head":{"label":"tsumichan:create-log-in","ref":"create-log-in","sha":"a7917a8e976b9642d0d2b525aae97668918e153d","user":{"login":"tsumichan","id":14156156,"node_id":"MDQ6VXNlcjE0MTU2MTU2","avatar_url":"https://avatars0.githubusercontent.com/u/14156156?v=4","gravatar_id":"","url":"https://api.github.com/users/tsumichan","html_url":"https://github.com/tsumichan","followers_url":"https://api.github.com/users/tsumichan/followers","following_url":"https://api.github.com/users/tsumichan/following{/other_user}","gists_url":"https://api.github.com/users/tsumichan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsumichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsumichan/subscriptions","organizations_url":"https://api.github.com/users/tsumichan/orgs","repos_url":"https://api.github.com/users/tsumichan/repos","events_url":"https://api.github.com/users/tsumichan/events{/privacy}","received_events_url":"https://api.github.com/users/tsumichan/received_events","type":"User","site_admin":false},"repo":{"id":137708257,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MDgyNTc=","name":"todo-app","full_name":"tsumichan/todo-app","owner":{"login":"tsumichan","id":14156156,"node_id":"MDQ6VXNlcjE0MTU2MTU2","avatar_url":"https://avatars0.githubusercontent.com/u/14156156?v=4","gravatar_id":"","url":"https://api.github.com/users/tsumichan","html_url":"https://github.com/tsumichan","followers_url":"https://api.github.com/users/tsumichan/followers","following_url":"https://api.github.com/users/tsumichan/following{/other_user}","gists_url":"https://api.github.com/users/tsumichan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsumichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsumichan/subscriptions","organizations_url":"https://api.github.com/users/tsumichan/orgs","repos_url":"https://api.github.com/users/tsumichan/repos","events_url":"https://api.github.com/users/tsumichan/events{/privacy}","received_events_url":"https://api.github.com/users/tsumichan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsumichan/todo-app","description":null,"fork":false,"url":"https://api.github.com/repos/tsumichan/todo-app","forks_url":"https://api.github.com/repos/tsumichan/todo-app/forks","keys_url":"https://api.github.com/repos/tsumichan/todo-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsumichan/todo-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsumichan/todo-app/teams","hooks_url":"https://api.github.com/repos/tsumichan/todo-app/hooks","issue_events_url":"https://api.github.com/repos/tsumichan/todo-app/issues/events{/number}","events_url":"https://api.github.com/repos/tsumichan/todo-app/events","assignees_url":"https://api.github.com/repos/tsumichan/todo-app/assignees{/user}","branches_url":"https://api.github.com/repos/tsumichan/todo-app/branches{/branch}","tags_url":"https://api.github.com/repos/tsumichan/todo-app/tags","blobs_url":"https://api.github.com/repos/tsumichan/todo-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsumichan/todo-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsumichan/todo-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsumichan/todo-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsumichan/todo-app/statuses/{sha}","languages_url":"https://api.github.com/repos/tsumichan/todo-app/languages","stargazers_url":"https://api.github.com/repos/tsumichan/todo-app/stargazers","contributors_url":"https://api.github.com/repos/tsumichan/todo-app/contributors","subscribers_url":"https://api.github.com/repos/tsumichan/todo-app/subscribers","subscription_url":"https://api.github.com/repos/tsumichan/todo-app/subscription","commits_url":"https://api.github.com/repos/tsumichan/todo-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsumichan/todo-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsumichan/todo-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsumichan/todo-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsumichan/todo-app/contents/{+path}","compare_url":"https://api.github.com/repos/tsumichan/todo-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsumichan/todo-app/merges","archive_url":"https://api.github.com/repos/tsumichan/todo-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsumichan/todo-app/downloads","issues_url":"https://api.github.com/repos/tsumichan/todo-app/issues{/number}","pulls_url":"https://api.github.com/repos/tsumichan/todo-app/pulls{/number}","milestones_url":"https://api.github.com/repos/tsumichan/todo-app/milestones{/number}","notifications_url":"https://api.github.com/repos/tsumichan/todo-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsumichan/todo-app/labels{/name}","releases_url":"https://api.github.com/repos/tsumichan/todo-app/releases{/id}","deployments_url":"https://api.github.com/repos/tsumichan/todo-app/deployments","created_at":"2018-06-18T04:01:26Z","updated_at":"2018-08-08T02:58:05Z","pushed_at":"2018-08-10T04:04:07Z","git_url":"git://github.com/tsumichan/todo-app.git","ssh_url":"[email protected]:tsumichan/todo-app.git","clone_url":"https://github.com/tsumichan/todo-app.git","svn_url":"https://github.com/tsumichan/todo-app","homepage":null,"size":41627,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"tsumichan:master","ref":"master","sha":"0f4058a838f955d3de5a0250f89d441af9e768ad","user":{"login":"tsumichan","id":14156156,"node_id":"MDQ6VXNlcjE0MTU2MTU2","avatar_url":"https://avatars0.githubusercontent.com/u/14156156?v=4","gravatar_id":"","url":"https://api.github.com/users/tsumichan","html_url":"https://github.com/tsumichan","followers_url":"https://api.github.com/users/tsumichan/followers","following_url":"https://api.github.com/users/tsumichan/following{/other_user}","gists_url":"https://api.github.com/users/tsumichan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsumichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsumichan/subscriptions","organizations_url":"https://api.github.com/users/tsumichan/orgs","repos_url":"https://api.github.com/users/tsumichan/repos","events_url":"https://api.github.com/users/tsumichan/events{/privacy}","received_events_url":"https://api.github.com/users/tsumichan/received_events","type":"User","site_admin":false},"repo":{"id":137708257,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MDgyNTc=","name":"todo-app","full_name":"tsumichan/todo-app","owner":{"login":"tsumichan","id":14156156,"node_id":"MDQ6VXNlcjE0MTU2MTU2","avatar_url":"https://avatars0.githubusercontent.com/u/14156156?v=4","gravatar_id":"","url":"https://api.github.com/users/tsumichan","html_url":"https://github.com/tsumichan","followers_url":"https://api.github.com/users/tsumichan/followers","following_url":"https://api.github.com/users/tsumichan/following{/other_user}","gists_url":"https://api.github.com/users/tsumichan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsumichan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsumichan/subscriptions","organizations_url":"https://api.github.com/users/tsumichan/orgs","repos_url":"https://api.github.com/users/tsumichan/repos","events_url":"https://api.github.com/users/tsumichan/events{/privacy}","received_events_url":"https://api.github.com/users/tsumichan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsumichan/todo-app","description":null,"fork":false,"url":"https://api.github.com/repos/tsumichan/todo-app","forks_url":"https://api.github.com/repos/tsumichan/todo-app/forks","keys_url":"https://api.github.com/repos/tsumichan/todo-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsumichan/todo-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsumichan/todo-app/teams","hooks_url":"https://api.github.com/repos/tsumichan/todo-app/hooks","issue_events_url":"https://api.github.com/repos/tsumichan/todo-app/issues/events{/number}","events_url":"https://api.github.com/repos/tsumichan/todo-app/events","assignees_url":"https://api.github.com/repos/tsumichan/todo-app/assignees{/user}","branches_url":"https://api.github.com/repos/tsumichan/todo-app/branches{/branch}","tags_url":"https://api.github.com/repos/tsumichan/todo-app/tags","blobs_url":"https://api.github.com/repos/tsumichan/todo-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsumichan/todo-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsumichan/todo-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsumichan/todo-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsumichan/todo-app/statuses/{sha}","languages_url":"https://api.github.com/repos/tsumichan/todo-app/languages","stargazers_url":"https://api.github.com/repos/tsumichan/todo-app/stargazers","contributors_url":"https://api.github.com/repos/tsumichan/todo-app/contributors","subscribers_url":"https://api.github.com/repos/tsumichan/todo-app/subscribers","subscription_url":"https://api.github.com/repos/tsumichan/todo-app/subscription","commits_url":"https://api.github.com/repos/tsumichan/todo-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsumichan/todo-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsumichan/todo-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsumichan/todo-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsumichan/todo-app/contents/{+path}","compare_url":"https://api.github.com/repos/tsumichan/todo-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsumichan/todo-app/merges","archive_url":"https://api.github.com/repos/tsumichan/todo-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsumichan/todo-app/downloads","issues_url":"https://api.github.com/repos/tsumichan/todo-app/issues{/number}","pulls_url":"https://api.github.com/repos/tsumichan/todo-app/pulls{/number}","milestones_url":"https://api.github.com/repos/tsumichan/todo-app/milestones{/number}","notifications_url":"https://api.github.com/repos/tsumichan/todo-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsumichan/todo-app/labels{/name}","releases_url":"https://api.github.com/repos/tsumichan/todo-app/releases{/id}","deployments_url":"https://api.github.com/repos/tsumichan/todo-app/deployments","created_at":"2018-06-18T04:01:26Z","updated_at":"2018-08-08T02:58:05Z","pushed_at":"2018-08-10T04:04:07Z","git_url":"git://github.com/tsumichan/todo-app.git","ssh_url":"[email protected]:tsumichan/todo-app.git","clone_url":"https://github.com/tsumichan/todo-app.git","svn_url":"https://github.com/tsumichan/todo-app","homepage":null,"size":41627,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tsumichan/todo-app/pulls/38"},"html":{"href":"https://github.com/tsumichan/todo-app/pull/38"},"issue":{"href":"https://api.github.com/repos/tsumichan/todo-app/issues/38"},"comments":{"href":"https://api.github.com/repos/tsumichan/todo-app/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/tsumichan/todo-app/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/tsumichan/todo-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tsumichan/todo-app/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/tsumichan/todo-app/statuses/a7917a8e976b9642d0d2b525aae97668918e153d"}},"author_association":"OWNER"}} | {
"id": 137708257,
"name": "tsumichan/todo-app",
"url": "https://api.github.com/repos/tsumichan/todo-app"
} | {
"id": 14156156,
"login": "tsumichan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14156156?",
"url": "https://api.github.com/users/tsumichan"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-08-10T06:06:51 | 8094217956 | {"actor":{"display_login":"tsumichan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/comments/224653878","pull_request_review_id":164076942,"id":224653878,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDY1Mzg3OA==","diff_hunk":"@@ -0,0 +1,14 @@\n+package com.nicknathanjustin.streamercontracts.donations.Requests;\n+\n+import lombok.Data;\n+import lombok.NoArgsConstructor;\n+import lombok.NonNull;\n+\n+import java.util.UUID;\n+\n+@Data\n+@NoArgsConstructor\n+public class UpdateDonationRequest {\n+ @NonNull private UUID donationId;\n+ private boolean markedCompleted;","path":"api/src/main/java/com/nicknathanjustin/streamercontracts/donations/Requests/UpdateDonationRequest.java","position":13,"original_position":13,"commit_id":"d42c86c39dbf2c0b9d739311fbf84935f7e76f2d","original_commit_id":"d42c86c39dbf2c0b9d739311fbf84935f7e76f2d","user":{"login":"nckackerman","id":5905174,"node_id":"MDQ6VXNlcjU5MDUxNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5905174?v=4","gravatar_id":"","url":"https://api.github.com/users/nckackerman","html_url":"https://github.com/nckackerman","followers_url":"https://api.github.com/users/nckackerman/followers","following_url":"https://api.github.com/users/nckackerman/following{/other_user}","gists_url":"https://api.github.com/users/nckackerman/gists{/gist_id}","starred_url":"https://api.github.com/users/nckackerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nckackerman/subscriptions","organizations_url":"https://api.github.com/users/nckackerman/orgs","repos_url":"https://api.github.com/users/nckackerman/repos","events_url":"https://api.github.com/users/nckackerman/events{/privacy}","received_events_url":"https://api.github.com/users/nckackerman/received_events","type":"User","site_admin":false},"body":"yes, will be false at times. This field indicates that the donator marked there donation as completed or not.","created_at":"2018-10-12T02:11:13Z","updated_at":"2018-10-12T02:11:13Z","html_url":"https://github.com/NateMoeller/StreamerContracts/pull/26#discussion_r224653878","pull_request_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/26","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/comments/224653878"},"html":{"href":"https://github.com/NateMoeller/StreamerContracts/pull/26#discussion_r224653878"},"pull_request":{"href":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/26"}},"in_reply_to_id":224313685},"pull_request":{"url":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/26","id":221011097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDExMDk3","html_url":"https://github.com/NateMoeller/StreamerContracts/pull/26","diff_url":"https://github.com/NateMoeller/StreamerContracts/pull/26.diff","patch_url":"https://github.com/NateMoeller/StreamerContracts/pull/26.patch","issue_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues/26","number":26,"state":"open","locked":false,"title":"List users open donations","user":{"login":"nckackerman","id":5905174,"node_id":"MDQ6VXNlcjU5MDUxNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5905174?v=4","gravatar_id":"","url":"https://api.github.com/users/nckackerman","html_url":"https://github.com/nckackerman","followers_url":"https://api.github.com/users/nckackerman/followers","following_url":"https://api.github.com/users/nckackerman/following{/other_user}","gists_url":"https://api.github.com/users/nckackerman/gists{/gist_id}","starred_url":"https://api.github.com/users/nckackerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nckackerman/subscriptions","organizations_url":"https://api.github.com/users/nckackerman/orgs","repos_url":"https://api.github.com/users/nckackerman/repos","events_url":"https://api.github.com/users/nckackerman/events{/privacy}","received_events_url":"https://api.github.com/users/nckackerman/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-08T06:08:09Z","updated_at":"2018-10-12T02:11:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc292593bd32b365dcf1dce9405ca9d41190a504","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/26/commits","review_comments_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/26/comments","review_comment_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues/26/comments","statuses_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/statuses/d42c86c39dbf2c0b9d739311fbf84935f7e76f2d","head":{"label":"NateMoeller:openDonations","ref":"openDonations","sha":"d42c86c39dbf2c0b9d739311fbf84935f7e76f2d","user":{"login":"NateMoeller","id":4491271,"node_id":"MDQ6VXNlcjQ0OTEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4491271?v=4","gravatar_id":"","url":"https://api.github.com/users/NateMoeller","html_url":"https://github.com/NateMoeller","followers_url":"https://api.github.com/users/NateMoeller/followers","following_url":"https://api.github.com/users/NateMoeller/following{/other_user}","gists_url":"https://api.github.com/users/NateMoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/NateMoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateMoeller/subscriptions","organizations_url":"https://api.github.com/users/NateMoeller/orgs","repos_url":"https://api.github.com/users/NateMoeller/repos","events_url":"https://api.github.com/users/NateMoeller/events{/privacy}","received_events_url":"https://api.github.com/users/NateMoeller/received_events","type":"User","site_admin":false},"repo":{"id":134213854,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyMTM4NTQ=","name":"StreamerContracts","full_name":"NateMoeller/StreamerContracts","private":false,"owner":{"login":"NateMoeller","id":4491271,"node_id":"MDQ6VXNlcjQ0OTEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4491271?v=4","gravatar_id":"","url":"https://api.github.com/users/NateMoeller","html_url":"https://github.com/NateMoeller","followers_url":"https://api.github.com/users/NateMoeller/followers","following_url":"https://api.github.com/users/NateMoeller/following{/other_user}","gists_url":"https://api.github.com/users/NateMoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/NateMoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateMoeller/subscriptions","organizations_url":"https://api.github.com/users/NateMoeller/orgs","repos_url":"https://api.github.com/users/NateMoeller/repos","events_url":"https://api.github.com/users/NateMoeller/events{/privacy}","received_events_url":"https://api.github.com/users/NateMoeller/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NateMoeller/StreamerContracts","description":null,"fork":false,"url":"https://api.github.com/repos/NateMoeller/StreamerContracts","forks_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/forks","keys_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/teams","hooks_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/hooks","issue_events_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues/events{/number}","events_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/events","assignees_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/assignees{/user}","branches_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/branches{/branch}","tags_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/tags","blobs_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/statuses/{sha}","languages_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/languages","stargazers_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/stargazers","contributors_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/contributors","subscribers_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/subscribers","subscription_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/subscription","commits_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/contents/{+path}","compare_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/merges","archive_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/downloads","issues_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues{/number}","pulls_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls{/number}","milestones_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/milestones{/number}","notifications_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/labels{/name}","releases_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/releases{/id}","deployments_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/deployments","created_at":"2018-05-21T03:34:16Z","updated_at":"2018-10-10T03:19:53Z","pushed_at":"2018-10-10T06:37:00Z","git_url":"git://github.com/NateMoeller/StreamerContracts.git","ssh_url":"[email protected]:NateMoeller/StreamerContracts.git","clone_url":"https://github.com/NateMoeller/StreamerContracts.git","svn_url":"https://github.com/NateMoeller/StreamerContracts","homepage":null,"size":315,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NateMoeller:master","ref":"master","sha":"524862e9117c3b55fdadd46eedd4ff8478caa0c0","user":{"login":"NateMoeller","id":4491271,"node_id":"MDQ6VXNlcjQ0OTEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4491271?v=4","gravatar_id":"","url":"https://api.github.com/users/NateMoeller","html_url":"https://github.com/NateMoeller","followers_url":"https://api.github.com/users/NateMoeller/followers","following_url":"https://api.github.com/users/NateMoeller/following{/other_user}","gists_url":"https://api.github.com/users/NateMoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/NateMoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateMoeller/subscriptions","organizations_url":"https://api.github.com/users/NateMoeller/orgs","repos_url":"https://api.github.com/users/NateMoeller/repos","events_url":"https://api.github.com/users/NateMoeller/events{/privacy}","received_events_url":"https://api.github.com/users/NateMoeller/received_events","type":"User","site_admin":false},"repo":{"id":134213854,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyMTM4NTQ=","name":"StreamerContracts","full_name":"NateMoeller/StreamerContracts","private":false,"owner":{"login":"NateMoeller","id":4491271,"node_id":"MDQ6VXNlcjQ0OTEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4491271?v=4","gravatar_id":"","url":"https://api.github.com/users/NateMoeller","html_url":"https://github.com/NateMoeller","followers_url":"https://api.github.com/users/NateMoeller/followers","following_url":"https://api.github.com/users/NateMoeller/following{/other_user}","gists_url":"https://api.github.com/users/NateMoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/NateMoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateMoeller/subscriptions","organizations_url":"https://api.github.com/users/NateMoeller/orgs","repos_url":"https://api.github.com/users/NateMoeller/repos","events_url":"https://api.github.com/users/NateMoeller/events{/privacy}","received_events_url":"https://api.github.com/users/NateMoeller/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NateMoeller/StreamerContracts","description":null,"fork":false,"url":"https://api.github.com/repos/NateMoeller/StreamerContracts","forks_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/forks","keys_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/teams","hooks_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/hooks","issue_events_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues/events{/number}","events_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/events","assignees_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/assignees{/user}","branches_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/branches{/branch}","tags_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/tags","blobs_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/statuses/{sha}","languages_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/languages","stargazers_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/stargazers","contributors_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/contributors","subscribers_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/subscribers","subscription_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/subscription","commits_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/contents/{+path}","compare_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/merges","archive_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/downloads","issues_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues{/number}","pulls_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls{/number}","milestones_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/milestones{/number}","notifications_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/labels{/name}","releases_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/releases{/id}","deployments_url":"https://api.github.com/repos/NateMoeller/StreamerContracts/deployments","created_at":"2018-05-21T03:34:16Z","updated_at":"2018-10-10T03:19:53Z","pushed_at":"2018-10-10T06:37:00Z","git_url":"git://github.com/NateMoeller/StreamerContracts.git","ssh_url":"[email protected]:NateMoeller/StreamerContracts.git","clone_url":"https://github.com/NateMoeller/StreamerContracts.git","svn_url":"https://github.com/NateMoeller/StreamerContracts","homepage":null,"size":315,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/26"},"html":{"href":"https://github.com/NateMoeller/StreamerContracts/pull/26"},"issue":{"href":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues/26"},"comments":{"href":"https://api.github.com/repos/NateMoeller/StreamerContracts/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NateMoeller/StreamerContracts/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/NateMoeller/StreamerContracts/statuses/d42c86c39dbf2c0b9d739311fbf84935f7e76f2d"}},"author_association":"COLLABORATOR"}} | {
"id": 134213854,
"name": "NateMoeller/StreamerContracts",
"url": "https://api.github.com/repos/NateMoeller/StreamerContracts"
} | {
"id": 5905174,
"login": "nckackerman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5905174?",
"url": "https://api.github.com/users/nckackerman"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-10-12T02:11:13 | 8408528889 | {"actor":{"display_login":"nckackerman"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Sdernal/net-kis/pulls/comments/224972574","pull_request_review_id":164477154,"id":224972574,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk3MjU3NA==","diff_hunk":"@@ -22,31 +22,59 @@ public static class VectorExtensions\n // Нормализовать вектор\n public static Vector Normalize(this Vector v)\n {\n- throw new NotImplementedException();\n+ // не хочется писать сложные проверки с EPS\n+ // здесь и далее полагаем, что данный класс не используется\n+ // в точных математических рассчетах; также полагаем, что\n+ // пользователь \"умный\" и знает основы геометрии\n+ if (v.Length() != 0)\n+ {\n+ return v / v.Length();\n+ }\n+ return new Vector();\n }\n \n- // Получить угол между векторами в радианах\n+ /// <summary>\n+ /// Получить угол между векторами в радианах\n+ /// </summary>\n+ /// <param name=\"v\"></param>\n+ /// <param name=\"u\"></param>\n+ /// <returns></returns>\n public static double GetAngleBetween(this Vector v, Vector u)\n {\n- throw new NotImplementedException();\n+ return Math.Atan2(v.CrossProduct(u), v.DotProduct(u));\n }\n \n // Получить отношение векторов: параллельны, перпендикулярны, остальное\n public static VectorRelation GetRelation(this Vector v, Vector u)\n {\n- throw new NotImplementedException();\n+ if (Math.Abs(v.CrossProduct(u)) == 0)\n+ {\n+ return VectorRelation.Parallel;\n+ }\n+ else if (Math.Abs(v.DotProduct(u)) == 0)\n+ {\n+ return VectorRelation.Orthogonal;\n+ }\n+ return VectorRelation.General;\n }\n \n // Еденичный ортогональный вектор данному\n public static Vector GetOrthogonal(this Vector v)\n {\n- throw new NotImplementedException();\n+ return new Vector(-v.y, v.x) / v.Length();","path":"csharpTasks/task1/MyVector/MyVector/VectorExtensions.cs","position":48,"original_position":48,"commit_id":"3e805a80b82548921656f475bd94bb5cc55b824e","original_commit_id":"ea625fa2df363eff157f484ab8bf2710e6d462bf","user":{"login":"pyspice","id":26696088,"node_id":"MDQ6VXNlcjI2Njk2MDg4","avatar_url":"https://avatars3.githubusercontent.com/u/26696088?v=4","gravatar_id":"","url":"https://api.github.com/users/pyspice","html_url":"https://github.com/pyspice","followers_url":"https://api.github.com/users/pyspice/followers","following_url":"https://api.github.com/users/pyspice/following{/other_user}","gists_url":"https://api.github.com/users/pyspice/gists{/gist_id}","starred_url":"https://api.github.com/users/pyspice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyspice/subscriptions","organizations_url":"https://api.github.com/users/pyspice/orgs","repos_url":"https://api.github.com/users/pyspice/repos","events_url":"https://api.github.com/users/pyspice/events{/privacy}","received_events_url":"https://api.github.com/users/pyspice/received_events","type":"User","site_admin":false},"body":"снова, по-хорошему нужно прилагать к вектору исключения для вектора","created_at":"2018-10-13T21:28:37Z","updated_at":"2018-10-13T21:28:37Z","html_url":"https://github.com/Sdernal/net-kis/pull/2#discussion_r224972574","pull_request_url":"https://api.github.com/repos/Sdernal/net-kis/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Sdernal/net-kis/pulls/comments/224972574"},"html":{"href":"https://github.com/Sdernal/net-kis/pull/2#discussion_r224972574"},"pull_request":{"href":"https://api.github.com/repos/Sdernal/net-kis/pulls/2"}},"in_reply_to_id":220708462},"pull_request":{"url":"https://api.github.com/repos/Sdernal/net-kis/pulls/2","id":218039040,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDM5MDQw","html_url":"https://github.com/Sdernal/net-kis/pull/2","diff_url":"https://github.com/Sdernal/net-kis/pull/2.diff","patch_url":"https://github.com/Sdernal/net-kis/pull/2.patch","issue_url":"https://api.github.com/repos/Sdernal/net-kis/issues/2","number":2,"state":"open","locked":false,"title":"Винокуров Сергей, task1","user":{"login":"pyspice","id":26696088,"node_id":"MDQ6VXNlcjI2Njk2MDg4","avatar_url":"https://avatars3.githubusercontent.com/u/26696088?v=4","gravatar_id":"","url":"https://api.github.com/users/pyspice","html_url":"https://github.com/pyspice","followers_url":"https://api.github.com/users/pyspice/followers","following_url":"https://api.github.com/users/pyspice/following{/other_user}","gists_url":"https://api.github.com/users/pyspice/gists{/gist_id}","starred_url":"https://api.github.com/users/pyspice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyspice/subscriptions","organizations_url":"https://api.github.com/users/pyspice/orgs","repos_url":"https://api.github.com/users/pyspice/repos","events_url":"https://api.github.com/users/pyspice/events{/privacy}","received_events_url":"https://api.github.com/users/pyspice/received_events","type":"User","site_admin":false},"body":"Добавлены property x, y","created_at":"2018-09-25T16:12:34Z","updated_at":"2018-10-13T21:28:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2553aec9650cf8d4deb4072d3543fa9319da80d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sdernal/net-kis/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Sdernal/net-kis/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Sdernal/net-kis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sdernal/net-kis/issues/2/comments","statuses_url":"https://api.github.com/repos/Sdernal/net-kis/statuses/3e805a80b82548921656f475bd94bb5cc55b824e","head":{"label":"pyspice:task1_vinokurov","ref":"task1_vinokurov","sha":"3e805a80b82548921656f475bd94bb5cc55b824e","user":{"login":"pyspice","id":26696088,"node_id":"MDQ6VXNlcjI2Njk2MDg4","avatar_url":"https://avatars3.githubusercontent.com/u/26696088?v=4","gravatar_id":"","url":"https://api.github.com/users/pyspice","html_url":"https://github.com/pyspice","followers_url":"https://api.github.com/users/pyspice/followers","following_url":"https://api.github.com/users/pyspice/following{/other_user}","gists_url":"https://api.github.com/users/pyspice/gists{/gist_id}","starred_url":"https://api.github.com/users/pyspice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyspice/subscriptions","organizations_url":"https://api.github.com/users/pyspice/orgs","repos_url":"https://api.github.com/users/pyspice/repos","events_url":"https://api.github.com/users/pyspice/events{/privacy}","received_events_url":"https://api.github.com/users/pyspice/received_events","type":"User","site_admin":false},"repo":{"id":150002731,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwMDI3MzE=","name":"net-kis","full_name":"pyspice/net-kis","private":false,"owner":{"login":"pyspice","id":26696088,"node_id":"MDQ6VXNlcjI2Njk2MDg4","avatar_url":"https://avatars3.githubusercontent.com/u/26696088?v=4","gravatar_id":"","url":"https://api.github.com/users/pyspice","html_url":"https://github.com/pyspice","followers_url":"https://api.github.com/users/pyspice/followers","following_url":"https://api.github.com/users/pyspice/following{/other_user}","gists_url":"https://api.github.com/users/pyspice/gists{/gist_id}","starred_url":"https://api.github.com/users/pyspice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyspice/subscriptions","organizations_url":"https://api.github.com/users/pyspice/orgs","repos_url":"https://api.github.com/users/pyspice/repos","events_url":"https://api.github.com/users/pyspice/events{/privacy}","received_events_url":"https://api.github.com/users/pyspice/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pyspice/net-kis","description":null,"fork":true,"url":"https://api.github.com/repos/pyspice/net-kis","forks_url":"https://api.github.com/repos/pyspice/net-kis/forks","keys_url":"https://api.github.com/repos/pyspice/net-kis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyspice/net-kis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyspice/net-kis/teams","hooks_url":"https://api.github.com/repos/pyspice/net-kis/hooks","issue_events_url":"https://api.github.com/repos/pyspice/net-kis/issues/events{/number}","events_url":"https://api.github.com/repos/pyspice/net-kis/events","assignees_url":"https://api.github.com/repos/pyspice/net-kis/assignees{/user}","branches_url":"https://api.github.com/repos/pyspice/net-kis/branches{/branch}","tags_url":"https://api.github.com/repos/pyspice/net-kis/tags","blobs_url":"https://api.github.com/repos/pyspice/net-kis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyspice/net-kis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyspice/net-kis/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyspice/net-kis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyspice/net-kis/statuses/{sha}","languages_url":"https://api.github.com/repos/pyspice/net-kis/languages","stargazers_url":"https://api.github.com/repos/pyspice/net-kis/stargazers","contributors_url":"https://api.github.com/repos/pyspice/net-kis/contributors","subscribers_url":"https://api.github.com/repos/pyspice/net-kis/subscribers","subscription_url":"https://api.github.com/repos/pyspice/net-kis/subscription","commits_url":"https://api.github.com/repos/pyspice/net-kis/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyspice/net-kis/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyspice/net-kis/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyspice/net-kis/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyspice/net-kis/contents/{+path}","compare_url":"https://api.github.com/repos/pyspice/net-kis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyspice/net-kis/merges","archive_url":"https://api.github.com/repos/pyspice/net-kis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyspice/net-kis/downloads","issues_url":"https://api.github.com/repos/pyspice/net-kis/issues{/number}","pulls_url":"https://api.github.com/repos/pyspice/net-kis/pulls{/number}","milestones_url":"https://api.github.com/repos/pyspice/net-kis/milestones{/number}","notifications_url":"https://api.github.com/repos/pyspice/net-kis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyspice/net-kis/labels{/name}","releases_url":"https://api.github.com/repos/pyspice/net-kis/releases{/id}","deployments_url":"https://api.github.com/repos/pyspice/net-kis/deployments","created_at":"2018-09-23T16:24:23Z","updated_at":"2018-09-23T16:30:04Z","pushed_at":"2018-10-13T21:22:21Z","git_url":"git://github.com/pyspice/net-kis.git","ssh_url":"[email protected]:pyspice/net-kis.git","clone_url":"https://github.com/pyspice/net-kis.git","svn_url":"https://github.com/pyspice/net-kis","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sdernal:master","ref":"master","sha":"e38f04f2b7b3d63b1848113f3811df5f1cf35ce7","user":{"login":"Sdernal","id":8759306,"node_id":"MDQ6VXNlcjg3NTkzMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/8759306?v=4","gravatar_id":"","url":"https://api.github.com/users/Sdernal","html_url":"https://github.com/Sdernal","followers_url":"https://api.github.com/users/Sdernal/followers","following_url":"https://api.github.com/users/Sdernal/following{/other_user}","gists_url":"https://api.github.com/users/Sdernal/gists{/gist_id}","starred_url":"https://api.github.com/users/Sdernal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sdernal/subscriptions","organizations_url":"https://api.github.com/users/Sdernal/orgs","repos_url":"https://api.github.com/users/Sdernal/repos","events_url":"https://api.github.com/users/Sdernal/events{/privacy}","received_events_url":"https://api.github.com/users/Sdernal/received_events","type":"User","site_admin":false},"repo":{"id":148020808,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgwMjA4MDg=","name":"net-kis","full_name":"Sdernal/net-kis","private":false,"owner":{"login":"Sdernal","id":8759306,"node_id":"MDQ6VXNlcjg3NTkzMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/8759306?v=4","gravatar_id":"","url":"https://api.github.com/users/Sdernal","html_url":"https://github.com/Sdernal","followers_url":"https://api.github.com/users/Sdernal/followers","following_url":"https://api.github.com/users/Sdernal/following{/other_user}","gists_url":"https://api.github.com/users/Sdernal/gists{/gist_id}","starred_url":"https://api.github.com/users/Sdernal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sdernal/subscriptions","organizations_url":"https://api.github.com/users/Sdernal/orgs","repos_url":"https://api.github.com/users/Sdernal/repos","events_url":"https://api.github.com/users/Sdernal/events{/privacy}","received_events_url":"https://api.github.com/users/Sdernal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Sdernal/net-kis","description":null,"fork":false,"url":"https://api.github.com/repos/Sdernal/net-kis","forks_url":"https://api.github.com/repos/Sdernal/net-kis/forks","keys_url":"https://api.github.com/repos/Sdernal/net-kis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sdernal/net-kis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sdernal/net-kis/teams","hooks_url":"https://api.github.com/repos/Sdernal/net-kis/hooks","issue_events_url":"https://api.github.com/repos/Sdernal/net-kis/issues/events{/number}","events_url":"https://api.github.com/repos/Sdernal/net-kis/events","assignees_url":"https://api.github.com/repos/Sdernal/net-kis/assignees{/user}","branches_url":"https://api.github.com/repos/Sdernal/net-kis/branches{/branch}","tags_url":"https://api.github.com/repos/Sdernal/net-kis/tags","blobs_url":"https://api.github.com/repos/Sdernal/net-kis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sdernal/net-kis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sdernal/net-kis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sdernal/net-kis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sdernal/net-kis/statuses/{sha}","languages_url":"https://api.github.com/repos/Sdernal/net-kis/languages","stargazers_url":"https://api.github.com/repos/Sdernal/net-kis/stargazers","contributors_url":"https://api.github.com/repos/Sdernal/net-kis/contributors","subscribers_url":"https://api.github.com/repos/Sdernal/net-kis/subscribers","subscription_url":"https://api.github.com/repos/Sdernal/net-kis/subscription","commits_url":"https://api.github.com/repos/Sdernal/net-kis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sdernal/net-kis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sdernal/net-kis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sdernal/net-kis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sdernal/net-kis/contents/{+path}","compare_url":"https://api.github.com/repos/Sdernal/net-kis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sdernal/net-kis/merges","archive_url":"https://api.github.com/repos/Sdernal/net-kis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sdernal/net-kis/downloads","issues_url":"https://api.github.com/repos/Sdernal/net-kis/issues{/number}","pulls_url":"https://api.github.com/repos/Sdernal/net-kis/pulls{/number}","milestones_url":"https://api.github.com/repos/Sdernal/net-kis/milestones{/number}","notifications_url":"https://api.github.com/repos/Sdernal/net-kis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sdernal/net-kis/labels{/name}","releases_url":"https://api.github.com/repos/Sdernal/net-kis/releases{/id}","deployments_url":"https://api.github.com/repos/Sdernal/net-kis/deployments","created_at":"2018-09-09T11:55:49Z","updated_at":"2018-10-07T20:35:12Z","pushed_at":"2018-10-13T21:22:23Z","git_url":"git://github.com/Sdernal/net-kis.git","ssh_url":"[email protected]:Sdernal/net-kis.git","clone_url":"https://github.com/Sdernal/net-kis.git","svn_url":"https://github.com/Sdernal/net-kis","homepage":null,"size":39,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":6,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sdernal/net-kis/pulls/2"},"html":{"href":"https://github.com/Sdernal/net-kis/pull/2"},"issue":{"href":"https://api.github.com/repos/Sdernal/net-kis/issues/2"},"comments":{"href":"https://api.github.com/repos/Sdernal/net-kis/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Sdernal/net-kis/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Sdernal/net-kis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sdernal/net-kis/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Sdernal/net-kis/statuses/3e805a80b82548921656f475bd94bb5cc55b824e"}},"author_association":"NONE"}} | {
"id": 148020808,
"name": "Sdernal/net-kis",
"url": "https://api.github.com/repos/Sdernal/net-kis"
} | {
"id": 26696088,
"login": "pyspice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26696088?",
"url": "https://api.github.com/users/pyspice"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-10-13T21:28:37 | 8416097028 | {"actor":{"display_login":"pyspice"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/danliris/bateeq-module/pulls/comments/216156655","pull_request_review_id":153580919,"id":216156655,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE1NjY1NQ==","diff_hunk":"@@ -0,0 +1,73 @@\n+'use strict'\n+var helper = require('../../helper');\n+var UnitPaymentPriceCorrectionNote = require('../../../src/managers/purchasing/unit-payment-price-correction-note-manager');\n+var codeGenerator = require('../../../src/utils/code-generator');\n+var supplier = require('../master/supplier-data-util');\n+var unitPaymentOrder = require('./unit-payment-order-data-util');\n+\n+class UnitPaymentPriceCorrectionNoteDataUtil {\n+ getNewData() {\n+ return helper\n+ .getManager(UnitPaymentPriceCorrectionNote)\n+ .then(manager => {\n+ return Promise.all([unitPaymentOrder.getNewTestData()])\n+ .then(results => {","path":"test/data-util/purchasing/unit-payment-price-correction-note-data-util.js","position":14,"original_position":14,"commit_id":"ca998baa7e742866484bbd5f093ea20364ab0f01","original_commit_id":"ca998baa7e742866484bbd5f093ea20364ab0f01","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').","created_at":"2018-09-09T12:52:08Z","updated_at":"2018-09-09T12:52:08Z","html_url":"https://github.com/danliris/bateeq-module/pull/591#discussion_r216156655","pull_request_url":"https://api.github.com/repos/danliris/bateeq-module/pulls/591","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/danliris/bateeq-module/pulls/comments/216156655"},"html":{"href":"https://github.com/danliris/bateeq-module/pull/591#discussion_r216156655"},"pull_request":{"href":"https://api.github.com/repos/danliris/bateeq-module/pulls/591"}}},"pull_request":{"url":"https://api.github.com/repos/danliris/bateeq-module/pulls/591","id":213208137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjA4MTM3","html_url":"https://github.com/danliris/bateeq-module/pull/591","diff_url":"https://github.com/danliris/bateeq-module/pull/591.diff","patch_url":"https://github.com/danliris/bateeq-module/pull/591.patch","issue_url":"https://api.github.com/repos/danliris/bateeq-module/issues/591","number":591,"state":"open","locked":false,"title":"update module document-inventory,movement-inventory,summary-inventory","user":{"login":"andibateeq","id":28917159,"node_id":"MDQ6VXNlcjI4OTE3MTU5","avatar_url":"https://avatars0.githubusercontent.com/u/28917159?v=4","gravatar_id":"","url":"https://api.github.com/users/andibateeq","html_url":"https://github.com/andibateeq","followers_url":"https://api.github.com/users/andibateeq/followers","following_url":"https://api.github.com/users/andibateeq/following{/other_user}","gists_url":"https://api.github.com/users/andibateeq/gists{/gist_id}","starred_url":"https://api.github.com/users/andibateeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andibateeq/subscriptions","organizations_url":"https://api.github.com/users/andibateeq/orgs","repos_url":"https://api.github.com/users/andibateeq/repos","events_url":"https://api.github.com/users/andibateeq/events{/privacy}","received_events_url":"https://api.github.com/users/andibateeq/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-05T08:25:15Z","updated_at":"2018-09-09T12:52:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dfd306fd22b6cbc6cf05c096fedc8424a6cc830","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/danliris/bateeq-module/pulls/591/commits","review_comments_url":"https://api.github.com/repos/danliris/bateeq-module/pulls/591/comments","review_comment_url":"https://api.github.com/repos/danliris/bateeq-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danliris/bateeq-module/issues/591/comments","statuses_url":"https://api.github.com/repos/danliris/bateeq-module/statuses/ca998baa7e742866484bbd5f093ea20364ab0f01","head":{"label":"andibateeq:dev","ref":"dev","sha":"ca998baa7e742866484bbd5f093ea20364ab0f01","user":{"login":"andibateeq","id":28917159,"node_id":"MDQ6VXNlcjI4OTE3MTU5","avatar_url":"https://avatars0.githubusercontent.com/u/28917159?v=4","gravatar_id":"","url":"https://api.github.com/users/andibateeq","html_url":"https://github.com/andibateeq","followers_url":"https://api.github.com/users/andibateeq/followers","following_url":"https://api.github.com/users/andibateeq/following{/other_user}","gists_url":"https://api.github.com/users/andibateeq/gists{/gist_id}","starred_url":"https://api.github.com/users/andibateeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andibateeq/subscriptions","organizations_url":"https://api.github.com/users/andibateeq/orgs","repos_url":"https://api.github.com/users/andibateeq/repos","events_url":"https://api.github.com/users/andibateeq/events{/privacy}","received_events_url":"https://api.github.com/users/andibateeq/received_events","type":"User","site_admin":false},"repo":{"id":92461657,"node_id":"MDEwOlJlcG9zaXRvcnk5MjQ2MTY1Nw==","name":"bateeq-module","full_name":"andibateeq/bateeq-module","owner":{"login":"andibateeq","id":28917159,"node_id":"MDQ6VXNlcjI4OTE3MTU5","avatar_url":"https://avatars0.githubusercontent.com/u/28917159?v=4","gravatar_id":"","url":"https://api.github.com/users/andibateeq","html_url":"https://github.com/andibateeq","followers_url":"https://api.github.com/users/andibateeq/followers","following_url":"https://api.github.com/users/andibateeq/following{/other_user}","gists_url":"https://api.github.com/users/andibateeq/gists{/gist_id}","starred_url":"https://api.github.com/users/andibateeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andibateeq/subscriptions","organizations_url":"https://api.github.com/users/andibateeq/orgs","repos_url":"https://api.github.com/users/andibateeq/repos","events_url":"https://api.github.com/users/andibateeq/events{/privacy}","received_events_url":"https://api.github.com/users/andibateeq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andibateeq/bateeq-module","description":"bateeq module","fork":true,"url":"https://api.github.com/repos/andibateeq/bateeq-module","forks_url":"https://api.github.com/repos/andibateeq/bateeq-module/forks","keys_url":"https://api.github.com/repos/andibateeq/bateeq-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andibateeq/bateeq-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andibateeq/bateeq-module/teams","hooks_url":"https://api.github.com/repos/andibateeq/bateeq-module/hooks","issue_events_url":"https://api.github.com/repos/andibateeq/bateeq-module/issues/events{/number}","events_url":"https://api.github.com/repos/andibateeq/bateeq-module/events","assignees_url":"https://api.github.com/repos/andibateeq/bateeq-module/assignees{/user}","branches_url":"https://api.github.com/repos/andibateeq/bateeq-module/branches{/branch}","tags_url":"https://api.github.com/repos/andibateeq/bateeq-module/tags","blobs_url":"https://api.github.com/repos/andibateeq/bateeq-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andibateeq/bateeq-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andibateeq/bateeq-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/andibateeq/bateeq-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andibateeq/bateeq-module/statuses/{sha}","languages_url":"https://api.github.com/repos/andibateeq/bateeq-module/languages","stargazers_url":"https://api.github.com/repos/andibateeq/bateeq-module/stargazers","contributors_url":"https://api.github.com/repos/andibateeq/bateeq-module/contributors","subscribers_url":"https://api.github.com/repos/andibateeq/bateeq-module/subscribers","subscription_url":"https://api.github.com/repos/andibateeq/bateeq-module/subscription","commits_url":"https://api.github.com/repos/andibateeq/bateeq-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/andibateeq/bateeq-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/andibateeq/bateeq-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/andibateeq/bateeq-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/andibateeq/bateeq-module/contents/{+path}","compare_url":"https://api.github.com/repos/andibateeq/bateeq-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andibateeq/bateeq-module/merges","archive_url":"https://api.github.com/repos/andibateeq/bateeq-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andibateeq/bateeq-module/downloads","issues_url":"https://api.github.com/repos/andibateeq/bateeq-module/issues{/number}","pulls_url":"https://api.github.com/repos/andibateeq/bateeq-module/pulls{/number}","milestones_url":"https://api.github.com/repos/andibateeq/bateeq-module/milestones{/number}","notifications_url":"https://api.github.com/repos/andibateeq/bateeq-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andibateeq/bateeq-module/labels{/name}","releases_url":"https://api.github.com/repos/andibateeq/bateeq-module/releases{/id}","deployments_url":"https://api.github.com/repos/andibateeq/bateeq-module/deployments","created_at":"2017-05-26T02:01:28Z","updated_at":"2017-05-26T02:01:30Z","pushed_at":"2018-09-09T12:51:43Z","git_url":"git://github.com/andibateeq/bateeq-module.git","ssh_url":"[email protected]:andibateeq/bateeq-module.git","clone_url":"https://github.com/andibateeq/bateeq-module.git","svn_url":"https://github.com/andibateeq/bateeq-module","homepage":null,"size":1694,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danliris:master","ref":"master","sha":"3de8b53deb6c346909c8e01604a885584634e5f2","user":{"login":"danliris","id":20855729,"node_id":"MDQ6VXNlcjIwODU1NzI5","avatar_url":"https://avatars0.githubusercontent.com/u/20855729?v=4","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"repo":{"id":61858352,"node_id":"MDEwOlJlcG9zaXRvcnk2MTg1ODM1Mg==","name":"bateeq-module","full_name":"danliris/bateeq-module","owner":{"login":"danliris","id":20855729,"node_id":"MDQ6VXNlcjIwODU1NzI5","avatar_url":"https://avatars0.githubusercontent.com/u/20855729?v=4","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danliris/bateeq-module","description":"bateeq module","fork":false,"url":"https://api.github.com/repos/danliris/bateeq-module","forks_url":"https://api.github.com/repos/danliris/bateeq-module/forks","keys_url":"https://api.github.com/repos/danliris/bateeq-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danliris/bateeq-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danliris/bateeq-module/teams","hooks_url":"https://api.github.com/repos/danliris/bateeq-module/hooks","issue_events_url":"https://api.github.com/repos/danliris/bateeq-module/issues/events{/number}","events_url":"https://api.github.com/repos/danliris/bateeq-module/events","assignees_url":"https://api.github.com/repos/danliris/bateeq-module/assignees{/user}","branches_url":"https://api.github.com/repos/danliris/bateeq-module/branches{/branch}","tags_url":"https://api.github.com/repos/danliris/bateeq-module/tags","blobs_url":"https://api.github.com/repos/danliris/bateeq-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danliris/bateeq-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danliris/bateeq-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/danliris/bateeq-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danliris/bateeq-module/statuses/{sha}","languages_url":"https://api.github.com/repos/danliris/bateeq-module/languages","stargazers_url":"https://api.github.com/repos/danliris/bateeq-module/stargazers","contributors_url":"https://api.github.com/repos/danliris/bateeq-module/contributors","subscribers_url":"https://api.github.com/repos/danliris/bateeq-module/subscribers","subscription_url":"https://api.github.com/repos/danliris/bateeq-module/subscription","commits_url":"https://api.github.com/repos/danliris/bateeq-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/danliris/bateeq-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/danliris/bateeq-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/danliris/bateeq-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/danliris/bateeq-module/contents/{+path}","compare_url":"https://api.github.com/repos/danliris/bateeq-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danliris/bateeq-module/merges","archive_url":"https://api.github.com/repos/danliris/bateeq-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danliris/bateeq-module/downloads","issues_url":"https://api.github.com/repos/danliris/bateeq-module/issues{/number}","pulls_url":"https://api.github.com/repos/danliris/bateeq-module/pulls{/number}","milestones_url":"https://api.github.com/repos/danliris/bateeq-module/milestones{/number}","notifications_url":"https://api.github.com/repos/danliris/bateeq-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danliris/bateeq-module/labels{/name}","releases_url":"https://api.github.com/repos/danliris/bateeq-module/releases{/id}","deployments_url":"https://api.github.com/repos/danliris/bateeq-module/deployments","created_at":"2016-06-24T05:10:07Z","updated_at":"2018-09-06T16:09:41Z","pushed_at":"2018-09-09T12:51:45Z","git_url":"git://github.com/danliris/bateeq-module.git","ssh_url":"[email protected]:danliris/bateeq-module.git","clone_url":"https://github.com/danliris/bateeq-module.git","svn_url":"https://github.com/danliris/bateeq-module","homepage":null,"size":1785,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danliris/bateeq-module/pulls/591"},"html":{"href":"https://github.com/danliris/bateeq-module/pull/591"},"issue":{"href":"https://api.github.com/repos/danliris/bateeq-module/issues/591"},"comments":{"href":"https://api.github.com/repos/danliris/bateeq-module/issues/591/comments"},"review_comments":{"href":"https://api.github.com/repos/danliris/bateeq-module/pulls/591/comments"},"review_comment":{"href":"https://api.github.com/repos/danliris/bateeq-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danliris/bateeq-module/pulls/591/commits"},"statuses":{"href":"https://api.github.com/repos/danliris/bateeq-module/statuses/ca998baa7e742866484bbd5f093ea20364ab0f01"}},"author_association":"CONTRIBUTOR"}} | {
"id": 61858352,
"name": "danliris/bateeq-module",
"url": "https://api.github.com/repos/danliris/bateeq-module"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-09-09T12:52:08 | 8236050450 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/comments/212806581","pull_request_review_id":149518706,"id":212806581,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgwNjU4MQ==","diff_hunk":"@@ -48,6 +48,7 @@ debounce:function\n decapitalize:string,array\n deepClone:object,recursion\n deepFlatten:array,recursion\n+deepFreeze:object,recursion","path":"tag_database","position":4,"original_position":4,"commit_id":"f1fb6aadb530681f3ef52913c4120f0621a1c33c","original_commit_id":"f1fb6aadb530681f3ef52913c4120f0621a1c33c","user":{"login":"fejes713","id":25749162,"node_id":"MDQ6VXNlcjI1NzQ5MTYy","avatar_url":"https://avatars2.githubusercontent.com/u/25749162?v=4","gravatar_id":"","url":"https://api.github.com/users/fejes713","html_url":"https://github.com/fejes713","followers_url":"https://api.github.com/users/fejes713/followers","following_url":"https://api.github.com/users/fejes713/following{/other_user}","gists_url":"https://api.github.com/users/fejes713/gists{/gist_id}","starred_url":"https://api.github.com/users/fejes713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejes713/subscriptions","organizations_url":"https://api.github.com/users/fejes713/orgs","repos_url":"https://api.github.com/users/fejes713/repos","events_url":"https://api.github.com/users/fejes713/events{/privacy}","received_events_url":"https://api.github.com/users/fejes713/received_events","type":"User","site_admin":false},"body":"I wouldn't put it under advanced, but you might be right too. \r\n\r\nTBH I see deepFreeze as an essential snippet when writing functional JS.","created_at":"2018-08-25T19:15:11Z","updated_at":"2018-08-25T19:15:11Z","html_url":"https://github.com/Chalarangelo/30-seconds-of-code/pull/721#discussion_r212806581","pull_request_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/721","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/comments/212806581"},"html":{"href":"https://github.com/Chalarangelo/30-seconds-of-code/pull/721#discussion_r212806581"},"pull_request":{"href":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/721"}},"in_reply_to_id":212803117},"pull_request":{"url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/721","id":210909168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTA5MTY4","html_url":"https://github.com/Chalarangelo/30-seconds-of-code/pull/721","diff_url":"https://github.com/Chalarangelo/30-seconds-of-code/pull/721.diff","patch_url":"https://github.com/Chalarangelo/30-seconds-of-code/pull/721.patch","issue_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues/721","number":721,"state":"open","locked":false,"title":"[FEATURE] add deepFreeze","user":{"login":"fejes713","id":25749162,"node_id":"MDQ6VXNlcjI1NzQ5MTYy","avatar_url":"https://avatars2.githubusercontent.com/u/25749162?v=4","gravatar_id":"","url":"https://api.github.com/users/fejes713","html_url":"https://github.com/fejes713","followers_url":"https://api.github.com/users/fejes713/followers","following_url":"https://api.github.com/users/fejes713/following{/other_user}","gists_url":"https://api.github.com/users/fejes713/gists{/gist_id}","starred_url":"https://api.github.com/users/fejes713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejes713/subscriptions","organizations_url":"https://api.github.com/users/fejes713/orgs","repos_url":"https://api.github.com/users/fejes713/repos","events_url":"https://api.github.com/users/fejes713/events{/privacy}","received_events_url":"https://api.github.com/users/fejes713/received_events","type":"User","site_admin":false},"body":"## Description\r\nA very useful snippet for freezing complex objects.\r\n\r\n\r\n\r\n\r\n## What does your PR belong to?\r\n- [ ] Website\r\n- [x] Snippets\r\n- [ ] General / Things regarding the repository (like CI Integration)\r\n- [ ] Tests\r\n\r\n## Types of changes\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Enhancement (non-breaking improvement of a snippet)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I have checked that the changes are working properly\r\n- [x] I have checked that there isn't any PR doing the same\r\n- [x] I have read the **CONTRIBUTING** document.\r\n","created_at":"2018-08-25T16:04:26Z","updated_at":"2018-08-25T19:15:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"977cbff3fea69b841bb3794900d8edf6fda307ca","assignee":null,"assignees":[],"requested_reviewers":[{"login":"flxwu","id":16862997,"node_id":"MDQ6VXNlcjE2ODYyOTk3","avatar_url":"https://avatars0.githubusercontent.com/u/16862997?v=4","gravatar_id":"","url":"https://api.github.com/users/flxwu","html_url":"https://github.com/flxwu","followers_url":"https://api.github.com/users/flxwu/followers","following_url":"https://api.github.com/users/flxwu/following{/other_user}","gists_url":"https://api.github.com/users/flxwu/gists{/gist_id}","starred_url":"https://api.github.com/users/flxwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flxwu/subscriptions","organizations_url":"https://api.github.com/users/flxwu/orgs","repos_url":"https://api.github.com/users/flxwu/repos","events_url":"https://api.github.com/users/flxwu/events{/privacy}","received_events_url":"https://api.github.com/users/flxwu/received_events","type":"User","site_admin":false},{"login":"atomiks","id":22450188,"node_id":"MDQ6VXNlcjIyNDUwMTg4","avatar_url":"https://avatars3.githubusercontent.com/u/22450188?v=4","gravatar_id":"","url":"https://api.github.com/users/atomiks","html_url":"https://github.com/atomiks","followers_url":"https://api.github.com/users/atomiks/followers","following_url":"https://api.github.com/users/atomiks/following{/other_user}","gists_url":"https://api.github.com/users/atomiks/gists{/gist_id}","starred_url":"https://api.github.com/users/atomiks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomiks/subscriptions","organizations_url":"https://api.github.com/users/atomiks/orgs","repos_url":"https://api.github.com/users/atomiks/repos","events_url":"https://api.github.com/users/atomiks/events{/privacy}","received_events_url":"https://api.github.com/users/atomiks/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/721/commits","review_comments_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/721/comments","review_comment_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues/721/comments","statuses_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/statuses/f1fb6aadb530681f3ef52913c4120f0621a1c33c","head":{"label":"Chalarangelo:new-snippets","ref":"new-snippets","sha":"f1fb6aadb530681f3ef52913c4120f0621a1c33c","user":{"login":"Chalarangelo","id":8281875,"node_id":"MDQ6VXNlcjgyODE4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8281875?v=4","gravatar_id":"","url":"https://api.github.com/users/Chalarangelo","html_url":"https://github.com/Chalarangelo","followers_url":"https://api.github.com/users/Chalarangelo/followers","following_url":"https://api.github.com/users/Chalarangelo/following{/other_user}","gists_url":"https://api.github.com/users/Chalarangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/Chalarangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chalarangelo/subscriptions","organizations_url":"https://api.github.com/users/Chalarangelo/orgs","repos_url":"https://api.github.com/users/Chalarangelo/repos","events_url":"https://api.github.com/users/Chalarangelo/events{/privacy}","received_events_url":"https://api.github.com/users/Chalarangelo/received_events","type":"User","site_admin":false},"repo":{"id":112507086,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1MDcwODY=","name":"30-seconds-of-code","full_name":"Chalarangelo/30-seconds-of-code","owner":{"login":"Chalarangelo","id":8281875,"node_id":"MDQ6VXNlcjgyODE4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8281875?v=4","gravatar_id":"","url":"https://api.github.com/users/Chalarangelo","html_url":"https://github.com/Chalarangelo","followers_url":"https://api.github.com/users/Chalarangelo/followers","following_url":"https://api.github.com/users/Chalarangelo/following{/other_user}","gists_url":"https://api.github.com/users/Chalarangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/Chalarangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chalarangelo/subscriptions","organizations_url":"https://api.github.com/users/Chalarangelo/orgs","repos_url":"https://api.github.com/users/Chalarangelo/repos","events_url":"https://api.github.com/users/Chalarangelo/events{/privacy}","received_events_url":"https://api.github.com/users/Chalarangelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chalarangelo/30-seconds-of-code","description":"Curated collection of useful Javascript snippets that you can understand in 30 seconds or less.","fork":false,"url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code","forks_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/forks","keys_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/teams","hooks_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/hooks","issue_events_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues/events{/number}","events_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/events","assignees_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/assignees{/user}","branches_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/branches{/branch}","tags_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/tags","blobs_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/statuses/{sha}","languages_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/languages","stargazers_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/stargazers","contributors_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/contributors","subscribers_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/subscribers","subscription_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/subscription","commits_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/contents/{+path}","compare_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/merges","archive_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/downloads","issues_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues{/number}","pulls_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls{/number}","milestones_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/milestones{/number}","notifications_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/labels{/name}","releases_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/releases{/id}","deployments_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/deployments","created_at":"2017-11-29T17:35:03Z","updated_at":"2018-08-25T17:12:15Z","pushed_at":"2018-08-25T16:04:26Z","git_url":"git://github.com/Chalarangelo/30-seconds-of-code.git","ssh_url":"[email protected]:Chalarangelo/30-seconds-of-code.git","clone_url":"https://github.com/Chalarangelo/30-seconds-of-code.git","svn_url":"https://github.com/Chalarangelo/30-seconds-of-code","homepage":"https://30secondsofcode.org/","size":10792,"stargazers_count":21463,"watchers_count":21463,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2191,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":2191,"open_issues":7,"watchers":21463,"default_branch":"master"}},"base":{"label":"Chalarangelo:master","ref":"master","sha":"a86bd7eff915c466e7cd44ef90b7c59a617ff035","user":{"login":"Chalarangelo","id":8281875,"node_id":"MDQ6VXNlcjgyODE4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8281875?v=4","gravatar_id":"","url":"https://api.github.com/users/Chalarangelo","html_url":"https://github.com/Chalarangelo","followers_url":"https://api.github.com/users/Chalarangelo/followers","following_url":"https://api.github.com/users/Chalarangelo/following{/other_user}","gists_url":"https://api.github.com/users/Chalarangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/Chalarangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chalarangelo/subscriptions","organizations_url":"https://api.github.com/users/Chalarangelo/orgs","repos_url":"https://api.github.com/users/Chalarangelo/repos","events_url":"https://api.github.com/users/Chalarangelo/events{/privacy}","received_events_url":"https://api.github.com/users/Chalarangelo/received_events","type":"User","site_admin":false},"repo":{"id":112507086,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1MDcwODY=","name":"30-seconds-of-code","full_name":"Chalarangelo/30-seconds-of-code","owner":{"login":"Chalarangelo","id":8281875,"node_id":"MDQ6VXNlcjgyODE4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8281875?v=4","gravatar_id":"","url":"https://api.github.com/users/Chalarangelo","html_url":"https://github.com/Chalarangelo","followers_url":"https://api.github.com/users/Chalarangelo/followers","following_url":"https://api.github.com/users/Chalarangelo/following{/other_user}","gists_url":"https://api.github.com/users/Chalarangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/Chalarangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chalarangelo/subscriptions","organizations_url":"https://api.github.com/users/Chalarangelo/orgs","repos_url":"https://api.github.com/users/Chalarangelo/repos","events_url":"https://api.github.com/users/Chalarangelo/events{/privacy}","received_events_url":"https://api.github.com/users/Chalarangelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chalarangelo/30-seconds-of-code","description":"Curated collection of useful Javascript snippets that you can understand in 30 seconds or less.","fork":false,"url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code","forks_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/forks","keys_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/teams","hooks_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/hooks","issue_events_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues/events{/number}","events_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/events","assignees_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/assignees{/user}","branches_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/branches{/branch}","tags_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/tags","blobs_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/statuses/{sha}","languages_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/languages","stargazers_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/stargazers","contributors_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/contributors","subscribers_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/subscribers","subscription_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/subscription","commits_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/contents/{+path}","compare_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/merges","archive_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/downloads","issues_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues{/number}","pulls_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls{/number}","milestones_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/milestones{/number}","notifications_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/labels{/name}","releases_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/releases{/id}","deployments_url":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/deployments","created_at":"2017-11-29T17:35:03Z","updated_at":"2018-08-25T17:12:15Z","pushed_at":"2018-08-25T16:04:26Z","git_url":"git://github.com/Chalarangelo/30-seconds-of-code.git","ssh_url":"[email protected]:Chalarangelo/30-seconds-of-code.git","clone_url":"https://github.com/Chalarangelo/30-seconds-of-code.git","svn_url":"https://github.com/Chalarangelo/30-seconds-of-code","homepage":"https://30secondsofcode.org/","size":10792,"stargazers_count":21463,"watchers_count":21463,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2191,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":2191,"open_issues":7,"watchers":21463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/721"},"html":{"href":"https://github.com/Chalarangelo/30-seconds-of-code/pull/721"},"issue":{"href":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues/721"},"comments":{"href":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/issues/721/comments"},"review_comments":{"href":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/721/comments"},"review_comment":{"href":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/pulls/721/commits"},"statuses":{"href":"https://api.github.com/repos/Chalarangelo/30-seconds-of-code/statuses/f1fb6aadb530681f3ef52913c4120f0621a1c33c"}},"author_association":"COLLABORATOR"}} | {
"id": 112507086,
"name": "Chalarangelo/30-seconds-of-code",
"url": "https://api.github.com/repos/Chalarangelo/30-seconds-of-code"
} | {
"id": 25749162,
"login": "fejes713",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25749162?",
"url": "https://api.github.com/users/fejes713"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2018-08-25T19:15:11 | 8167220226 | {"actor":{"display_login":"fejes713"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sinatra/sinatra/pulls/comments/212207256","pull_request_review_id":148787303,"id":212207256,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjIwNzI1Ng==","diff_hunk":"@@ -1803,7 +1803,7 @@ class << self\n set :handler_name, nil\n set :traps, true\n set :server, %w[HTTP webrick]\n- set :bind, Proc.new { development? ? 'localhost' : '0.0.0.0' }\n+ set :bind, Proc.new { development? ? 'localhost' : '127.0.0.1' }","path":"lib/sinatra/base.rb","position":5,"original_position":5,"commit_id":"8f9135db3711bf3fd767919ce3e8ab2bb69eaefa","original_commit_id":"8f9135db3711bf3fd767919ce3e8ab2bb69eaefa","user":{"login":"dentarg","id":42626,"node_id":"MDQ6VXNlcjQyNjI2","avatar_url":"https://avatars2.githubusercontent.com/u/42626?v=4","gravatar_id":"","url":"https://api.github.com/users/dentarg","html_url":"https://github.com/dentarg","followers_url":"https://api.github.com/users/dentarg/followers","following_url":"https://api.github.com/users/dentarg/following{/other_user}","gists_url":"https://api.github.com/users/dentarg/gists{/gist_id}","starred_url":"https://api.github.com/users/dentarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dentarg/subscriptions","organizations_url":"https://api.github.com/users/dentarg/orgs","repos_url":"https://api.github.com/users/dentarg/repos","events_url":"https://api.github.com/users/dentarg/events{/privacy}","received_events_url":"https://api.github.com/users/dentarg/received_events","type":"User","site_admin":false},"body":"Uhm, this makes `127.0.0.1` the default for everything not `development`, I don't think that is something anyone want to change?\r\n\r\n#1369 (\"Change default host to 0.0.0.0 in development mode\") that you refer to is about going back to `0.0.0.0` in `development` (i.e. reverting the change from 2013: https://github.com/sinatra/sinatra/commit/0f9a959253bdf0c39422ffb9b60278df46ef0248, https://github.com/sinatra/sinatra/pull/634)","created_at":"2018-08-23T07:28:59Z","updated_at":"2018-08-23T07:29:00Z","html_url":"https://github.com/sinatra/sinatra/pull/1470#discussion_r212207256","pull_request_url":"https://api.github.com/repos/sinatra/sinatra/pulls/1470","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sinatra/sinatra/pulls/comments/212207256"},"html":{"href":"https://github.com/sinatra/sinatra/pull/1470#discussion_r212207256"},"pull_request":{"href":"https://api.github.com/repos/sinatra/sinatra/pulls/1470"}}},"pull_request":{"url":"https://api.github.com/repos/sinatra/sinatra/pulls/1470","id":210334354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzM0MzU0","html_url":"https://github.com/sinatra/sinatra/pull/1470","diff_url":"https://github.com/sinatra/sinatra/pull/1470.diff","patch_url":"https://github.com/sinatra/sinatra/pull/1470.patch","issue_url":"https://api.github.com/repos/sinatra/sinatra/issues/1470","number":1470,"state":"open","locked":false,"title":"Change default host address","user":{"login":"davidsilveira","id":10809645,"node_id":"MDQ6VXNlcjEwODA5NjQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10809645?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsilveira","html_url":"https://github.com/davidsilveira","followers_url":"https://api.github.com/users/davidsilveira/followers","following_url":"https://api.github.com/users/davidsilveira/following{/other_user}","gists_url":"https://api.github.com/users/davidsilveira/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsilveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsilveira/subscriptions","organizations_url":"https://api.github.com/users/davidsilveira/orgs","repos_url":"https://api.github.com/users/davidsilveira/repos","events_url":"https://api.github.com/users/davidsilveira/events{/privacy}","received_events_url":"https://api.github.com/users/davidsilveira/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-23T05:28:26Z","updated_at":"2018-08-23T07:29:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e8d848b2f08027f5d4b42b0bfae8808170243f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sinatra/sinatra/pulls/1470/commits","review_comments_url":"https://api.github.com/repos/sinatra/sinatra/pulls/1470/comments","review_comment_url":"https://api.github.com/repos/sinatra/sinatra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinatra/sinatra/issues/1470/comments","statuses_url":"https://api.github.com/repos/sinatra/sinatra/statuses/8f9135db3711bf3fd767919ce3e8ab2bb69eaefa","head":{"label":"davidsilveira:master","ref":"master","sha":"8f9135db3711bf3fd767919ce3e8ab2bb69eaefa","user":{"login":"davidsilveira","id":10809645,"node_id":"MDQ6VXNlcjEwODA5NjQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10809645?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsilveira","html_url":"https://github.com/davidsilveira","followers_url":"https://api.github.com/users/davidsilveira/followers","following_url":"https://api.github.com/users/davidsilveira/following{/other_user}","gists_url":"https://api.github.com/users/davidsilveira/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsilveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsilveira/subscriptions","organizations_url":"https://api.github.com/users/davidsilveira/orgs","repos_url":"https://api.github.com/users/davidsilveira/repos","events_url":"https://api.github.com/users/davidsilveira/events{/privacy}","received_events_url":"https://api.github.com/users/davidsilveira/received_events","type":"User","site_admin":false},"repo":{"id":145799640,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3OTk2NDA=","name":"sinatra","full_name":"davidsilveira/sinatra","owner":{"login":"davidsilveira","id":10809645,"node_id":"MDQ6VXNlcjEwODA5NjQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10809645?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsilveira","html_url":"https://github.com/davidsilveira","followers_url":"https://api.github.com/users/davidsilveira/followers","following_url":"https://api.github.com/users/davidsilveira/following{/other_user}","gists_url":"https://api.github.com/users/davidsilveira/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsilveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsilveira/subscriptions","organizations_url":"https://api.github.com/users/davidsilveira/orgs","repos_url":"https://api.github.com/users/davidsilveira/repos","events_url":"https://api.github.com/users/davidsilveira/events{/privacy}","received_events_url":"https://api.github.com/users/davidsilveira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidsilveira/sinatra","description":"Classy web-development dressed in a DSL (official / canonical repo)","fork":true,"url":"https://api.github.com/repos/davidsilveira/sinatra","forks_url":"https://api.github.com/repos/davidsilveira/sinatra/forks","keys_url":"https://api.github.com/repos/davidsilveira/sinatra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidsilveira/sinatra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidsilveira/sinatra/teams","hooks_url":"https://api.github.com/repos/davidsilveira/sinatra/hooks","issue_events_url":"https://api.github.com/repos/davidsilveira/sinatra/issues/events{/number}","events_url":"https://api.github.com/repos/davidsilveira/sinatra/events","assignees_url":"https://api.github.com/repos/davidsilveira/sinatra/assignees{/user}","branches_url":"https://api.github.com/repos/davidsilveira/sinatra/branches{/branch}","tags_url":"https://api.github.com/repos/davidsilveira/sinatra/tags","blobs_url":"https://api.github.com/repos/davidsilveira/sinatra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidsilveira/sinatra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidsilveira/sinatra/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidsilveira/sinatra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidsilveira/sinatra/statuses/{sha}","languages_url":"https://api.github.com/repos/davidsilveira/sinatra/languages","stargazers_url":"https://api.github.com/repos/davidsilveira/sinatra/stargazers","contributors_url":"https://api.github.com/repos/davidsilveira/sinatra/contributors","subscribers_url":"https://api.github.com/repos/davidsilveira/sinatra/subscribers","subscription_url":"https://api.github.com/repos/davidsilveira/sinatra/subscription","commits_url":"https://api.github.com/repos/davidsilveira/sinatra/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidsilveira/sinatra/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidsilveira/sinatra/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidsilveira/sinatra/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidsilveira/sinatra/contents/{+path}","compare_url":"https://api.github.com/repos/davidsilveira/sinatra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidsilveira/sinatra/merges","archive_url":"https://api.github.com/repos/davidsilveira/sinatra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidsilveira/sinatra/downloads","issues_url":"https://api.github.com/repos/davidsilveira/sinatra/issues{/number}","pulls_url":"https://api.github.com/repos/davidsilveira/sinatra/pulls{/number}","milestones_url":"https://api.github.com/repos/davidsilveira/sinatra/milestones{/number}","notifications_url":"https://api.github.com/repos/davidsilveira/sinatra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidsilveira/sinatra/labels{/name}","releases_url":"https://api.github.com/repos/davidsilveira/sinatra/releases{/id}","deployments_url":"https://api.github.com/repos/davidsilveira/sinatra/deployments","created_at":"2018-08-23T04:21:03Z","updated_at":"2018-08-23T05:24:55Z","pushed_at":"2018-08-23T05:24:51Z","git_url":"git://github.com/davidsilveira/sinatra.git","ssh_url":"[email protected]:davidsilveira/sinatra.git","clone_url":"https://github.com/davidsilveira/sinatra.git","svn_url":"https://github.com/davidsilveira/sinatra","homepage":"http://www.sinatrarb.com/","size":6292,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sinatra:master","ref":"master","sha":"b801c6b76b89eb071e2b01700273054bbe8aae05","user":{"login":"sinatra","id":8312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8312?v=4","gravatar_id":"","url":"https://api.github.com/users/sinatra","html_url":"https://github.com/sinatra","followers_url":"https://api.github.com/users/sinatra/followers","following_url":"https://api.github.com/users/sinatra/following{/other_user}","gists_url":"https://api.github.com/users/sinatra/gists{/gist_id}","starred_url":"https://api.github.com/users/sinatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinatra/subscriptions","organizations_url":"https://api.github.com/users/sinatra/orgs","repos_url":"https://api.github.com/users/sinatra/repos","events_url":"https://api.github.com/users/sinatra/events{/privacy}","received_events_url":"https://api.github.com/users/sinatra/received_events","type":"Organization","site_admin":false},"repo":{"id":106995,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY5OTU=","name":"sinatra","full_name":"sinatra/sinatra","owner":{"login":"sinatra","id":8312,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8312?v=4","gravatar_id":"","url":"https://api.github.com/users/sinatra","html_url":"https://github.com/sinatra","followers_url":"https://api.github.com/users/sinatra/followers","following_url":"https://api.github.com/users/sinatra/following{/other_user}","gists_url":"https://api.github.com/users/sinatra/gists{/gist_id}","starred_url":"https://api.github.com/users/sinatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinatra/subscriptions","organizations_url":"https://api.github.com/users/sinatra/orgs","repos_url":"https://api.github.com/users/sinatra/repos","events_url":"https://api.github.com/users/sinatra/events{/privacy}","received_events_url":"https://api.github.com/users/sinatra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sinatra/sinatra","description":"Classy web-development dressed in a DSL (official / canonical repo)","fork":false,"url":"https://api.github.com/repos/sinatra/sinatra","forks_url":"https://api.github.com/repos/sinatra/sinatra/forks","keys_url":"https://api.github.com/repos/sinatra/sinatra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinatra/sinatra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinatra/sinatra/teams","hooks_url":"https://api.github.com/repos/sinatra/sinatra/hooks","issue_events_url":"https://api.github.com/repos/sinatra/sinatra/issues/events{/number}","events_url":"https://api.github.com/repos/sinatra/sinatra/events","assignees_url":"https://api.github.com/repos/sinatra/sinatra/assignees{/user}","branches_url":"https://api.github.com/repos/sinatra/sinatra/branches{/branch}","tags_url":"https://api.github.com/repos/sinatra/sinatra/tags","blobs_url":"https://api.github.com/repos/sinatra/sinatra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinatra/sinatra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinatra/sinatra/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinatra/sinatra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinatra/sinatra/statuses/{sha}","languages_url":"https://api.github.com/repos/sinatra/sinatra/languages","stargazers_url":"https://api.github.com/repos/sinatra/sinatra/stargazers","contributors_url":"https://api.github.com/repos/sinatra/sinatra/contributors","subscribers_url":"https://api.github.com/repos/sinatra/sinatra/subscribers","subscription_url":"https://api.github.com/repos/sinatra/sinatra/subscription","commits_url":"https://api.github.com/repos/sinatra/sinatra/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinatra/sinatra/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinatra/sinatra/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinatra/sinatra/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinatra/sinatra/contents/{+path}","compare_url":"https://api.github.com/repos/sinatra/sinatra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinatra/sinatra/merges","archive_url":"https://api.github.com/repos/sinatra/sinatra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinatra/sinatra/downloads","issues_url":"https://api.github.com/repos/sinatra/sinatra/issues{/number}","pulls_url":"https://api.github.com/repos/sinatra/sinatra/pulls{/number}","milestones_url":"https://api.github.com/repos/sinatra/sinatra/milestones{/number}","notifications_url":"https://api.github.com/repos/sinatra/sinatra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinatra/sinatra/labels{/name}","releases_url":"https://api.github.com/repos/sinatra/sinatra/releases{/id}","deployments_url":"https://api.github.com/repos/sinatra/sinatra/deployments","created_at":"2009-01-14T01:27:30Z","updated_at":"2018-08-23T07:13:32Z","pushed_at":"2018-08-23T05:28:26Z","git_url":"git://github.com/sinatra/sinatra.git","ssh_url":"[email protected]:sinatra/sinatra.git","clone_url":"https://github.com/sinatra/sinatra.git","svn_url":"https://github.com/sinatra/sinatra","homepage":"http://www.sinatrarb.com/","size":6361,"stargazers_count":10126,"watchers_count":10126,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1822,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1822,"open_issues":87,"watchers":10126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinatra/sinatra/pulls/1470"},"html":{"href":"https://github.com/sinatra/sinatra/pull/1470"},"issue":{"href":"https://api.github.com/repos/sinatra/sinatra/issues/1470"},"comments":{"href":"https://api.github.com/repos/sinatra/sinatra/issues/1470/comments"},"review_comments":{"href":"https://api.github.com/repos/sinatra/sinatra/pulls/1470/comments"},"review_comment":{"href":"https://api.github.com/repos/sinatra/sinatra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinatra/sinatra/pulls/1470/commits"},"statuses":{"href":"https://api.github.com/repos/sinatra/sinatra/statuses/8f9135db3711bf3fd767919ce3e8ab2bb69eaefa"}},"author_association":"NONE"}} | {
"id": 106995,
"name": "sinatra/sinatra",
"url": "https://api.github.com/repos/sinatra/sinatra"
} | {
"id": 42626,
"login": "dentarg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42626?",
"url": "https://api.github.com/users/dentarg"
} | {
"id": 8312,
"login": "sinatra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8312?",
"url": "https://api.github.com/orgs/sinatra"
} | 2018-08-23T07:28:59 | 8155223791 | {"actor":{"display_login":"dentarg"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/samson/pulls/comments/181876934","pull_request_review_id":112578400,"id":181876934,"diff_hunk":"@@ -53,3 +53,10 @@ The recipients and subject prefix of the email are configurable, use REQUEST_ACC\n The receiving end can be a Samson admin distribution list, a JIRA email trigger which will automatically set up an access ticket, or whatever you fancy.\n \n The feature is enabled by setting REQUEST_ACCESS_FEATURE=1\n+\n+## Stagger Job Execution\n+\n+Setting the environment variable JOB_STAGGER_INTERVAL to a non-zero value will enable Samson's job staggering feature, \n+which queues jobs to be executed, and deques them at a rate of the set value in seconds. \n+\n+ex. `JOB_STAGGER_INTERVAL=10` -> one job will run every 10 seconds","path":"docs/extra_features.md","position":10,"original_position":10,"commit_id":"daba5427083f618a9d653431844a6c33351c1c3a","original_commit_id":"daba5427083f618a9d653431844a6c33351c1c3a","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars3.githubusercontent.com/u/11367?v=4","gravatar_id":"","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"body":"`run` -> `start` maybe","created_at":"2018-04-16T20:36:43Z","updated_at":"2018-04-16T20:36:43Z","html_url":"https://github.com/zendesk/samson/pull/2680#discussion_r181876934","pull_request_url":"https://api.github.com/repos/zendesk/samson/pulls/2680","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zendesk/samson/pulls/comments/181876934"},"html":{"href":"https://github.com/zendesk/samson/pull/2680#discussion_r181876934"},"pull_request":{"href":"https://api.github.com/repos/zendesk/samson/pulls/2680"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/samson/pulls/2680","id":181576326,"html_url":"https://github.com/zendesk/samson/pull/2680","diff_url":"https://github.com/zendesk/samson/pull/2680.diff","patch_url":"https://github.com/zendesk/samson/pull/2680.patch","issue_url":"https://api.github.com/repos/zendesk/samson/issues/2680","number":2680,"state":"open","locked":false,"title":"Stagger Jobs","user":{"login":"ragurney","id":15261525,"avatar_url":"https://avatars0.githubusercontent.com/u/15261525?v=4","gravatar_id":"","url":"https://api.github.com/users/ragurney","html_url":"https://github.com/ragurney","followers_url":"https://api.github.com/users/ragurney/followers","following_url":"https://api.github.com/users/ragurney/following{/other_user}","gists_url":"https://api.github.com/users/ragurney/gists{/gist_id}","starred_url":"https://api.github.com/users/ragurney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragurney/subscriptions","organizations_url":"https://api.github.com/users/ragurney/orgs","repos_url":"https://api.github.com/users/ragurney/repos","events_url":"https://api.github.com/users/ragurney/events{/privacy}","received_events_url":"https://api.github.com/users/ragurney/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2018-04-13T19:26:49Z","updated_at":"2018-04-16T20:36:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed39c1daabeb40b4d932f18645f733f2b3f97d10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/samson/pulls/2680/commits","review_comments_url":"https://api.github.com/repos/zendesk/samson/pulls/2680/comments","review_comment_url":"https://api.github.com/repos/zendesk/samson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/samson/issues/2680/comments","statuses_url":"https://api.github.com/repos/zendesk/samson/statuses/daba5427083f618a9d653431844a6c33351c1c3a","head":{"label":"zendesk:gurney/staggerJobs","ref":"gurney/staggerJobs","sha":"daba5427083f618a9d653431844a6c33351c1c3a","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars3.githubusercontent.com/u/11525?v=4","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":20208662,"name":"samson","full_name":"zendesk/samson","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars3.githubusercontent.com/u/11525?v=4","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/samson","description":"Web interface for deployments","fork":false,"url":"https://api.github.com/repos/zendesk/samson","forks_url":"https://api.github.com/repos/zendesk/samson/forks","keys_url":"https://api.github.com/repos/zendesk/samson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/samson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/samson/teams","hooks_url":"https://api.github.com/repos/zendesk/samson/hooks","issue_events_url":"https://api.github.com/repos/zendesk/samson/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/samson/events","assignees_url":"https://api.github.com/repos/zendesk/samson/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/samson/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/samson/tags","blobs_url":"https://api.github.com/repos/zendesk/samson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/samson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/samson/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/samson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/samson/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/samson/languages","stargazers_url":"https://api.github.com/repos/zendesk/samson/stargazers","contributors_url":"https://api.github.com/repos/zendesk/samson/contributors","subscribers_url":"https://api.github.com/repos/zendesk/samson/subscribers","subscription_url":"https://api.github.com/repos/zendesk/samson/subscription","commits_url":"https://api.github.com/repos/zendesk/samson/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/samson/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/samson/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/samson/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/samson/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/samson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/samson/merges","archive_url":"https://api.github.com/repos/zendesk/samson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/samson/downloads","issues_url":"https://api.github.com/repos/zendesk/samson/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/samson/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/samson/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/samson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/samson/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/samson/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/samson/deployments","created_at":"2014-05-27T05:55:57Z","updated_at":"2018-04-13T20:53:09Z","pushed_at":"2018-04-16T17:47:38Z","git_url":"git://github.com/zendesk/samson.git","ssh_url":"[email protected]:zendesk/samson.git","clone_url":"https://github.com/zendesk/samson.git","svn_url":"https://github.com/zendesk/samson","homepage":null,"size":290934,"stargazers_count":1100,"watchers_count":1100,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":192,"open_issues":63,"watchers":1100,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"81540355124a777a7bb0be40afaca650af755ba3","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars3.githubusercontent.com/u/11525?v=4","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":20208662,"name":"samson","full_name":"zendesk/samson","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars3.githubusercontent.com/u/11525?v=4","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/samson","description":"Web interface for deployments","fork":false,"url":"https://api.github.com/repos/zendesk/samson","forks_url":"https://api.github.com/repos/zendesk/samson/forks","keys_url":"https://api.github.com/repos/zendesk/samson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/samson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/samson/teams","hooks_url":"https://api.github.com/repos/zendesk/samson/hooks","issue_events_url":"https://api.github.com/repos/zendesk/samson/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/samson/events","assignees_url":"https://api.github.com/repos/zendesk/samson/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/samson/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/samson/tags","blobs_url":"https://api.github.com/repos/zendesk/samson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/samson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/samson/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/samson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/samson/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/samson/languages","stargazers_url":"https://api.github.com/repos/zendesk/samson/stargazers","contributors_url":"https://api.github.com/repos/zendesk/samson/contributors","subscribers_url":"https://api.github.com/repos/zendesk/samson/subscribers","subscription_url":"https://api.github.com/repos/zendesk/samson/subscription","commits_url":"https://api.github.com/repos/zendesk/samson/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/samson/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/samson/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/samson/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/samson/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/samson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/samson/merges","archive_url":"https://api.github.com/repos/zendesk/samson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/samson/downloads","issues_url":"https://api.github.com/repos/zendesk/samson/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/samson/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/samson/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/samson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/samson/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/samson/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/samson/deployments","created_at":"2014-05-27T05:55:57Z","updated_at":"2018-04-13T20:53:09Z","pushed_at":"2018-04-16T17:47:38Z","git_url":"git://github.com/zendesk/samson.git","ssh_url":"[email protected]:zendesk/samson.git","clone_url":"https://github.com/zendesk/samson.git","svn_url":"https://github.com/zendesk/samson","homepage":null,"size":290934,"stargazers_count":1100,"watchers_count":1100,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":192,"open_issues":63,"watchers":1100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/samson/pulls/2680"},"html":{"href":"https://github.com/zendesk/samson/pull/2680"},"issue":{"href":"https://api.github.com/repos/zendesk/samson/issues/2680"},"comments":{"href":"https://api.github.com/repos/zendesk/samson/issues/2680/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/samson/pulls/2680/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/samson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/samson/pulls/2680/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/samson/statuses/daba5427083f618a9d653431844a6c33351c1c3a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 20208662,
"name": "zendesk/samson",
"url": "https://api.github.com/repos/zendesk/samson"
} | {
"id": 11367,
"login": "grosser",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11367?",
"url": "https://api.github.com/users/grosser"
} | {
"id": 11525,
"login": "zendesk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11525?",
"url": "https://api.github.com/orgs/zendesk"
} | 2018-04-16T20:36:43 | 7538535162 | {"actor":{"display_login":"grosser"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/comments/184482770","pull_request_review_id":115689624,"id":184482770,"diff_hunk":"@@ -0,0 +1,80 @@\n+// @flow\n+/**","path":"packages/wonder-blocks-modal/components/modal-launcher/modal-launcher-portal.js","position":2,"original_position":2,"commit_id":"f0c79be2f843eeab1db8820e4a421c1e4f5b70f1","original_commit_id":"f0c79be2f843eeab1db8820e4a421c1e4f5b70f1","user":{"login":"matchu","id":59218,"avatar_url":"https://avatars3.githubusercontent.com/u/59218?v=4","gravatar_id":"","url":"https://api.github.com/users/matchu","html_url":"https://github.com/matchu","followers_url":"https://api.github.com/users/matchu/followers","following_url":"https://api.github.com/users/matchu/following{/other_user}","gists_url":"https://api.github.com/users/matchu/gists{/gist_id}","starred_url":"https://api.github.com/users/matchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matchu/subscriptions","organizations_url":"https://api.github.com/users/matchu/orgs","repos_url":"https://api.github.com/users/matchu/repos","events_url":"https://api.github.com/users/matchu/events{/privacy}","received_events_url":"https://api.github.com/users/matchu/received_events","type":"User","site_admin":false},"body":"Oh neat, thanks!","created_at":"2018-04-26T18:08:43Z","updated_at":"2018-04-26T18:08:43Z","html_url":"https://github.com/Khan/wonder-blocks/pull/51#discussion_r184482770","pull_request_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/51","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/comments/184482770"},"html":{"href":"https://github.com/Khan/wonder-blocks/pull/51#discussion_r184482770"},"pull_request":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/51"}},"in_reply_to_id":184465689},"pull_request":{"url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/51","id":183889456,"html_url":"https://github.com/Khan/wonder-blocks/pull/51","diff_url":"https://github.com/Khan/wonder-blocks/pull/51.diff","patch_url":"https://github.com/Khan/wonder-blocks/pull/51.patch","issue_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/51","number":51,"state":"open","locked":false,"title":"[modal] Create basic ModalLauncher component","user":{"login":"matchu","id":59218,"avatar_url":"https://avatars3.githubusercontent.com/u/59218?v=4","gravatar_id":"","url":"https://api.github.com/users/matchu","html_url":"https://github.com/matchu","followers_url":"https://api.github.com/users/matchu/followers","following_url":"https://api.github.com/users/matchu/following{/other_user}","gists_url":"https://api.github.com/users/matchu/gists{/gist_id}","starred_url":"https://api.github.com/users/matchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matchu/subscriptions","organizations_url":"https://api.github.com/users/matchu/orgs","repos_url":"https://api.github.com/users/matchu/repos","events_url":"https://api.github.com/users/matchu/events{/privacy}","received_events_url":"https://api.github.com/users/matchu/received_events","type":"User","site_admin":false},"body":"In this change, we create the basic `ModalLauncher` component. We're not targeting full functionality yet; just the basics of state management, mounting, and visual overlay.\r\n\r\nI broke these responsibilities into two components: the `ModalLauncher` itself, which handles opened state and communication with the caller; and `ModalLauncherPortal`, which handles mounting the `modal` into the DOM. Both have decent unit tests - I learned some Enzyme today, hooray!\r\n\r\nI also installed the `flow-typed` definition for Jest, in order to be able to Flow-check our unit test files. (I also updated button's test file, and removed a `globals` comment that seems to perhaps be old and no longer needed - was that okay?)\r\n\r\nDepends on #50, where we create the two-column layout. (I haven't updated that code in response to review yet, so there'll be some corresponding updates in this change too once I do!)\r\n\r\nhttps://khanacademy.atlassian.net/browse/WB-121\r\n\r\nTest Plan:\r\nUnit tests pass! And here's how it looks in Styleguidist:\r\n","created_at":"2018-04-24T23:18:23Z","updated_at":"2018-04-26T18:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ca05f3f0dc629dd00cb5698f9fd43ec77ae3f18","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/51/commits","review_comments_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/51/comments","review_comment_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/51/comments","statuses_url":"https://api.github.com/repos/Khan/wonder-blocks/statuses/f0c79be2f843eeab1db8820e4a421c1e4f5b70f1","head":{"label":"Khan:modal-launcher","ref":"modal-launcher","sha":"f0c79be2f843eeab1db8820e4a421c1e4f5b70f1","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":123198469,"name":"wonder-blocks","full_name":"Khan/wonder-blocks","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/wonder-blocks","description":"React components for Wonder Blocks design system.","fork":false,"url":"https://api.github.com/repos/Khan/wonder-blocks","forks_url":"https://api.github.com/repos/Khan/wonder-blocks/forks","keys_url":"https://api.github.com/repos/Khan/wonder-blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/wonder-blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/wonder-blocks/teams","hooks_url":"https://api.github.com/repos/Khan/wonder-blocks/hooks","issue_events_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/wonder-blocks/events","assignees_url":"https://api.github.com/repos/Khan/wonder-blocks/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/wonder-blocks/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/wonder-blocks/tags","blobs_url":"https://api.github.com/repos/Khan/wonder-blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/wonder-blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/wonder-blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/wonder-blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/wonder-blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/wonder-blocks/languages","stargazers_url":"https://api.github.com/repos/Khan/wonder-blocks/stargazers","contributors_url":"https://api.github.com/repos/Khan/wonder-blocks/contributors","subscribers_url":"https://api.github.com/repos/Khan/wonder-blocks/subscribers","subscription_url":"https://api.github.com/repos/Khan/wonder-blocks/subscription","commits_url":"https://api.github.com/repos/Khan/wonder-blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/wonder-blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/wonder-blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khan/wonder-blocks/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/wonder-blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/wonder-blocks/merges","archive_url":"https://api.github.com/repos/Khan/wonder-blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/wonder-blocks/downloads","issues_url":"https://api.github.com/repos/Khan/wonder-blocks/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/wonder-blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/wonder-blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/wonder-blocks/labels{/name}","releases_url":"https://api.github.com/repos/Khan/wonder-blocks/releases{/id}","deployments_url":"https://api.github.com/repos/Khan/wonder-blocks/deployments","created_at":"2018-02-27T22:50:41Z","updated_at":"2018-04-26T18:06:22Z","pushed_at":"2018-04-26T18:06:23Z","git_url":"git://github.com/Khan/wonder-blocks.git","ssh_url":"[email protected]:Khan/wonder-blocks.git","clone_url":"https://github.com/Khan/wonder-blocks.git","svn_url":"https://github.com/Khan/wonder-blocks","homepage":"https://khan.github.io/wonder-blocks","size":4340,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":13,"default_branch":"master"}},"base":{"label":"Khan:two-column-modal","ref":"two-column-modal","sha":"b9a31c9834798a9179e1bcf69698c1f5b6023040","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":123198469,"name":"wonder-blocks","full_name":"Khan/wonder-blocks","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars1.githubusercontent.com/u/15455?v=4","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/wonder-blocks","description":"React components for Wonder Blocks design system.","fork":false,"url":"https://api.github.com/repos/Khan/wonder-blocks","forks_url":"https://api.github.com/repos/Khan/wonder-blocks/forks","keys_url":"https://api.github.com/repos/Khan/wonder-blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/wonder-blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/wonder-blocks/teams","hooks_url":"https://api.github.com/repos/Khan/wonder-blocks/hooks","issue_events_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/wonder-blocks/events","assignees_url":"https://api.github.com/repos/Khan/wonder-blocks/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/wonder-blocks/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/wonder-blocks/tags","blobs_url":"https://api.github.com/repos/Khan/wonder-blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/wonder-blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/wonder-blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/wonder-blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/wonder-blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/wonder-blocks/languages","stargazers_url":"https://api.github.com/repos/Khan/wonder-blocks/stargazers","contributors_url":"https://api.github.com/repos/Khan/wonder-blocks/contributors","subscribers_url":"https://api.github.com/repos/Khan/wonder-blocks/subscribers","subscription_url":"https://api.github.com/repos/Khan/wonder-blocks/subscription","commits_url":"https://api.github.com/repos/Khan/wonder-blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/wonder-blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/wonder-blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/wonder-blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khan/wonder-blocks/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/wonder-blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/wonder-blocks/merges","archive_url":"https://api.github.com/repos/Khan/wonder-blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/wonder-blocks/downloads","issues_url":"https://api.github.com/repos/Khan/wonder-blocks/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/wonder-blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/wonder-blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/wonder-blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/wonder-blocks/labels{/name}","releases_url":"https://api.github.com/repos/Khan/wonder-blocks/releases{/id}","deployments_url":"https://api.github.com/repos/Khan/wonder-blocks/deployments","created_at":"2018-02-27T22:50:41Z","updated_at":"2018-04-26T18:06:22Z","pushed_at":"2018-04-26T18:06:23Z","git_url":"git://github.com/Khan/wonder-blocks.git","ssh_url":"[email protected]:Khan/wonder-blocks.git","clone_url":"https://github.com/Khan/wonder-blocks.git","svn_url":"https://github.com/Khan/wonder-blocks","homepage":"https://khan.github.io/wonder-blocks","size":4340,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/51"},"html":{"href":"https://github.com/Khan/wonder-blocks/pull/51"},"issue":{"href":"https://api.github.com/repos/Khan/wonder-blocks/issues/51"},"comments":{"href":"https://api.github.com/repos/Khan/wonder-blocks/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Khan/wonder-blocks/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/Khan/wonder-blocks/statuses/f0c79be2f843eeab1db8820e4a421c1e4f5b70f1"}},"author_association":"CONTRIBUTOR"}} | {
"id": 123198469,
"name": "Khan/wonder-blocks",
"url": "https://api.github.com/repos/Khan/wonder-blocks"
} | {
"id": 59218,
"login": "matchu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/59218?",
"url": "https://api.github.com/users/matchu"
} | {
"id": 15455,
"login": "Khan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15455?",
"url": "https://api.github.com/orgs/Khan"
} | 2018-04-26T18:08:43 | 7593074247 | {"actor":{"display_login":"matchu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/bullet-service/pulls/comments/175645186","pull_request_review_id":105207263,"id":175645186,"diff_hunk":"@@ -12,6 +12,8 @@\n \n @Getter\n public class QueryError {\n+ public static final QueryError INVALID_QUERY = new QueryError(\"Failed to parse query.\", \"Please provide a valid query.\");\n+ public static final QueryError UNSUPPORTED_QUERY = new QueryError(\"Doesn't support window query for this endpoint\", \"Please provide a valid query without window.\");","path":"src/main/java/com/yahoo/bullet/rest/query/QueryError.java","position":null,"original_position":5,"commit_id":"96c93a578b21741a9c1e0261b2c47221f85fcf28","original_commit_id":"74ae91e8bc5e57b30a78337188640a1b35c76c24","user":{"login":"akshaisarma","id":1041753,"avatar_url":"https://avatars0.githubusercontent.com/u/1041753?v=4","gravatar_id":"","url":"https://api.github.com/users/akshaisarma","html_url":"https://github.com/akshaisarma","followers_url":"https://api.github.com/users/akshaisarma/followers","following_url":"https://api.github.com/users/akshaisarma/following{/other_user}","gists_url":"https://api.github.com/users/akshaisarma/gists{/gist_id}","starred_url":"https://api.github.com/users/akshaisarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshaisarma/subscriptions","organizations_url":"https://api.github.com/users/akshaisarma/orgs","repos_url":"https://api.github.com/users/akshaisarma/repos","events_url":"https://api.github.com/users/akshaisarma/events{/privacy}","received_events_url":"https://api.github.com/users/akshaisarma/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2018-03-20T03:12:07Z","updated_at":"2018-03-20T03:12:07Z","html_url":"https://github.com/yahoo/bullet-service/pull/10#discussion_r175645186","pull_request_url":"https://api.github.com/repos/yahoo/bullet-service/pulls/10","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yahoo/bullet-service/pulls/comments/175645186"},"html":{"href":"https://github.com/yahoo/bullet-service/pull/10#discussion_r175645186"},"pull_request":{"href":"https://api.github.com/repos/yahoo/bullet-service/pulls/10"}},"in_reply_to_id":175643431},"pull_request":{"url":"https://api.github.com/repos/yahoo/bullet-service/pulls/10","id":176021006,"html_url":"https://github.com/yahoo/bullet-service/pull/10","diff_url":"https://github.com/yahoo/bullet-service/pull/10.diff","patch_url":"https://github.com/yahoo/bullet-service/pull/10.patch","issue_url":"https://api.github.com/repos/yahoo/bullet-service/issues/10","number":10,"state":"open","locked":false,"title":"Fail window query for http-query endpoint","user":{"login":"hbxie","id":32469795,"avatar_url":"https://avatars0.githubusercontent.com/u/32469795?v=4","gravatar_id":"","url":"https://api.github.com/users/hbxie","html_url":"https://github.com/hbxie","followers_url":"https://api.github.com/users/hbxie/followers","following_url":"https://api.github.com/users/hbxie/following{/other_user}","gists_url":"https://api.github.com/users/hbxie/gists{/gist_id}","starred_url":"https://api.github.com/users/hbxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbxie/subscriptions","organizations_url":"https://api.github.com/users/hbxie/orgs","repos_url":"https://api.github.com/users/hbxie/repos","events_url":"https://api.github.com/users/hbxie/events{/privacy}","received_events_url":"https://api.github.com/users/hbxie/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-19T20:47:36Z","updated_at":"2018-03-20T03:12:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fd5468a79b616734af0a581a9d8c93914ae1172","assignee":{"login":"akshaisarma","id":1041753,"avatar_url":"https://avatars0.githubusercontent.com/u/1041753?v=4","gravatar_id":"","url":"https://api.github.com/users/akshaisarma","html_url":"https://github.com/akshaisarma","followers_url":"https://api.github.com/users/akshaisarma/followers","following_url":"https://api.github.com/users/akshaisarma/following{/other_user}","gists_url":"https://api.github.com/users/akshaisarma/gists{/gist_id}","starred_url":"https://api.github.com/users/akshaisarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshaisarma/subscriptions","organizations_url":"https://api.github.com/users/akshaisarma/orgs","repos_url":"https://api.github.com/users/akshaisarma/repos","events_url":"https://api.github.com/users/akshaisarma/events{/privacy}","received_events_url":"https://api.github.com/users/akshaisarma/received_events","type":"User","site_admin":false},"assignees":[{"login":"akshaisarma","id":1041753,"avatar_url":"https://avatars0.githubusercontent.com/u/1041753?v=4","gravatar_id":"","url":"https://api.github.com/users/akshaisarma","html_url":"https://github.com/akshaisarma","followers_url":"https://api.github.com/users/akshaisarma/followers","following_url":"https://api.github.com/users/akshaisarma/following{/other_user}","gists_url":"https://api.github.com/users/akshaisarma/gists{/gist_id}","starred_url":"https://api.github.com/users/akshaisarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshaisarma/subscriptions","organizations_url":"https://api.github.com/users/akshaisarma/orgs","repos_url":"https://api.github.com/users/akshaisarma/repos","events_url":"https://api.github.com/users/akshaisarma/events{/privacy}","received_events_url":"https://api.github.com/users/akshaisarma/received_events","type":"User","site_admin":false},{"login":"NathanSpeidel","id":10698988,"avatar_url":"https://avatars1.githubusercontent.com/u/10698988?v=4","gravatar_id":"","url":"https://api.github.com/users/NathanSpeidel","html_url":"https://github.com/NathanSpeidel","followers_url":"https://api.github.com/users/NathanSpeidel/followers","following_url":"https://api.github.com/users/NathanSpeidel/following{/other_user}","gists_url":"https://api.github.com/users/NathanSpeidel/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanSpeidel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanSpeidel/subscriptions","organizations_url":"https://api.github.com/users/NathanSpeidel/orgs","repos_url":"https://api.github.com/users/NathanSpeidel/repos","events_url":"https://api.github.com/users/NathanSpeidel/events{/privacy}","received_events_url":"https://api.github.com/users/NathanSpeidel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/bullet-service/pulls/10/commits","review_comments_url":"https://api.github.com/repos/yahoo/bullet-service/pulls/10/comments","review_comment_url":"https://api.github.com/repos/yahoo/bullet-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/bullet-service/issues/10/comments","statuses_url":"https://api.github.com/repos/yahoo/bullet-service/statuses/96c93a578b21741a9c1e0261b2c47221f85fcf28","head":{"label":"hbxie:remove-windowing","ref":"remove-windowing","sha":"96c93a578b21741a9c1e0261b2c47221f85fcf28","user":{"login":"hbxie","id":32469795,"avatar_url":"https://avatars0.githubusercontent.com/u/32469795?v=4","gravatar_id":"","url":"https://api.github.com/users/hbxie","html_url":"https://github.com/hbxie","followers_url":"https://api.github.com/users/hbxie/followers","following_url":"https://api.github.com/users/hbxie/following{/other_user}","gists_url":"https://api.github.com/users/hbxie/gists{/gist_id}","starred_url":"https://api.github.com/users/hbxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbxie/subscriptions","organizations_url":"https://api.github.com/users/hbxie/orgs","repos_url":"https://api.github.com/users/hbxie/repos","events_url":"https://api.github.com/users/hbxie/events{/privacy}","received_events_url":"https://api.github.com/users/hbxie/received_events","type":"User","site_admin":false},"repo":{"id":123634445,"name":"bullet-service","full_name":"hbxie/bullet-service","owner":{"login":"hbxie","id":32469795,"avatar_url":"https://avatars0.githubusercontent.com/u/32469795?v=4","gravatar_id":"","url":"https://api.github.com/users/hbxie","html_url":"https://github.com/hbxie","followers_url":"https://api.github.com/users/hbxie/followers","following_url":"https://api.github.com/users/hbxie/following{/other_user}","gists_url":"https://api.github.com/users/hbxie/gists{/gist_id}","starred_url":"https://api.github.com/users/hbxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbxie/subscriptions","organizations_url":"https://api.github.com/users/hbxie/orgs","repos_url":"https://api.github.com/users/hbxie/repos","events_url":"https://api.github.com/users/hbxie/events{/privacy}","received_events_url":"https://api.github.com/users/hbxie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hbxie/bullet-service","description":"The Web Service layer for Bullet","fork":true,"url":"https://api.github.com/repos/hbxie/bullet-service","forks_url":"https://api.github.com/repos/hbxie/bullet-service/forks","keys_url":"https://api.github.com/repos/hbxie/bullet-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hbxie/bullet-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hbxie/bullet-service/teams","hooks_url":"https://api.github.com/repos/hbxie/bullet-service/hooks","issue_events_url":"https://api.github.com/repos/hbxie/bullet-service/issues/events{/number}","events_url":"https://api.github.com/repos/hbxie/bullet-service/events","assignees_url":"https://api.github.com/repos/hbxie/bullet-service/assignees{/user}","branches_url":"https://api.github.com/repos/hbxie/bullet-service/branches{/branch}","tags_url":"https://api.github.com/repos/hbxie/bullet-service/tags","blobs_url":"https://api.github.com/repos/hbxie/bullet-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hbxie/bullet-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hbxie/bullet-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/hbxie/bullet-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hbxie/bullet-service/statuses/{sha}","languages_url":"https://api.github.com/repos/hbxie/bullet-service/languages","stargazers_url":"https://api.github.com/repos/hbxie/bullet-service/stargazers","contributors_url":"https://api.github.com/repos/hbxie/bullet-service/contributors","subscribers_url":"https://api.github.com/repos/hbxie/bullet-service/subscribers","subscription_url":"https://api.github.com/repos/hbxie/bullet-service/subscription","commits_url":"https://api.github.com/repos/hbxie/bullet-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/hbxie/bullet-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/hbxie/bullet-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/hbxie/bullet-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/hbxie/bullet-service/contents/{+path}","compare_url":"https://api.github.com/repos/hbxie/bullet-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hbxie/bullet-service/merges","archive_url":"https://api.github.com/repos/hbxie/bullet-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hbxie/bullet-service/downloads","issues_url":"https://api.github.com/repos/hbxie/bullet-service/issues{/number}","pulls_url":"https://api.github.com/repos/hbxie/bullet-service/pulls{/number}","milestones_url":"https://api.github.com/repos/hbxie/bullet-service/milestones{/number}","notifications_url":"https://api.github.com/repos/hbxie/bullet-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hbxie/bullet-service/labels{/name}","releases_url":"https://api.github.com/repos/hbxie/bullet-service/releases{/id}","deployments_url":"https://api.github.com/repos/hbxie/bullet-service/deployments","created_at":"2018-03-02T21:48:01Z","updated_at":"2018-03-19T19:51:13Z","pushed_at":"2018-03-20T03:10:47Z","git_url":"git://github.com/hbxie/bullet-service.git","ssh_url":"[email protected]:hbxie/bullet-service.git","clone_url":"https://github.com/hbxie/bullet-service.git","svn_url":"https://github.com/hbxie/bullet-service","homepage":"https://yahoo.github.io/bullet-docs","size":100,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"befb8270ffb4ef211221fcdabd3b6be3d4edcdfb","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":74064816,"name":"bullet-service","full_name":"yahoo/bullet-service","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/bullet-service","description":"The Web Service layer for Bullet","fork":false,"url":"https://api.github.com/repos/yahoo/bullet-service","forks_url":"https://api.github.com/repos/yahoo/bullet-service/forks","keys_url":"https://api.github.com/repos/yahoo/bullet-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/bullet-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/bullet-service/teams","hooks_url":"https://api.github.com/repos/yahoo/bullet-service/hooks","issue_events_url":"https://api.github.com/repos/yahoo/bullet-service/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/bullet-service/events","assignees_url":"https://api.github.com/repos/yahoo/bullet-service/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/bullet-service/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/bullet-service/tags","blobs_url":"https://api.github.com/repos/yahoo/bullet-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/bullet-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/bullet-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/bullet-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/bullet-service/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/bullet-service/languages","stargazers_url":"https://api.github.com/repos/yahoo/bullet-service/stargazers","contributors_url":"https://api.github.com/repos/yahoo/bullet-service/contributors","subscribers_url":"https://api.github.com/repos/yahoo/bullet-service/subscribers","subscription_url":"https://api.github.com/repos/yahoo/bullet-service/subscription","commits_url":"https://api.github.com/repos/yahoo/bullet-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/bullet-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/bullet-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/bullet-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/bullet-service/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/bullet-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/bullet-service/merges","archive_url":"https://api.github.com/repos/yahoo/bullet-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/bullet-service/downloads","issues_url":"https://api.github.com/repos/yahoo/bullet-service/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/bullet-service/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/bullet-service/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/bullet-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/bullet-service/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/bullet-service/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/bullet-service/deployments","created_at":"2016-11-17T20:31:32Z","updated_at":"2018-03-19T19:47:31Z","pushed_at":"2018-03-20T03:10:48Z","git_url":"git://github.com/yahoo/bullet-service.git","ssh_url":"[email protected]:yahoo/bullet-service.git","clone_url":"https://github.com/yahoo/bullet-service.git","svn_url":"https://github.com/yahoo/bullet-service","homepage":"https://yahoo.github.io/bullet-docs","size":90,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/bullet-service/pulls/10"},"html":{"href":"https://github.com/yahoo/bullet-service/pull/10"},"issue":{"href":"https://api.github.com/repos/yahoo/bullet-service/issues/10"},"comments":{"href":"https://api.github.com/repos/yahoo/bullet-service/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/bullet-service/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/bullet-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/bullet-service/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/bullet-service/statuses/96c93a578b21741a9c1e0261b2c47221f85fcf28"}},"author_association":"CONTRIBUTOR"}} | {
"id": 74064816,
"name": "yahoo/bullet-service",
"url": "https://api.github.com/repos/yahoo/bullet-service"
} | {
"id": 1041753,
"login": "akshaisarma",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1041753?",
"url": "https://api.github.com/users/akshaisarma"
} | {
"id": 16574,
"login": "yahoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16574?",
"url": "https://api.github.com/orgs/yahoo"
} | 2018-03-20T03:12:07 | 7404198076 | {"actor":{"display_login":"akshaisarma"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/openstack/pulls/comments/168775497","pull_request_review_id":97200798,"id":168775497,"diff_hunk":"@@ -0,0 +1,124 @@\n+From 2fe7260df7dc6eecbc82751704840a98c860dd0e Mon Sep 17 00:00:00 2001\n+From: PiotrProkop <[email protected]>\n+Date: Thu, 11 Jan 2018 13:34:44 +0100\n+Subject: [PATCH] Bumping version of debian to stretch, adding user core to\n+ coreos IPA image. Fixing script coreos-oem-inject.py to work on machines with\n+ Python3 as default interpreter.\n+\n+---\n+ Dockerfile | 20 ++++++++++++++------\n+ get_megacli.sh | 16 ++++++++++++++++\n+ imagebuild/coreos/coreos-oem-inject.py | 3 ++-\n+ imagebuild/coreos/oem/cloud-config.yml | 5 +++++\n+ 4 files changed, 37 insertions(+), 7 deletions(-)\n+ create mode 100755 get_megacli.sh\n+\n+diff --git a/Dockerfile b/Dockerfile\n+index 8c7a56a..d8f02b4 100644\n+--- a/Dockerfile\n++++ b/Dockerfile\n+@@ -1,4 +1,4 @@\n+-FROM debian:jessie\n++FROM debian:stretch\n+ \n+ # The add is before the RUN to ensure we get the latest version of packages\n+ # Docker will cache RUN commands, but because the SHA1 of the dir will be\n+@@ -13,20 +13,25 @@ ADD . /tmp/ironic-python-agent\n+ # 1.6. Using the ARG command will be a much cleaner solution.\n+ COPY proxy.sh /usr/bin/proxy.sh\n+ \n++ADD get_megacli.sh /tmp/get_megacli.sh","path":"ironic-python-agent/0001-Bumping-version-of-debian-to-stretch-adding-user-cor.patch","position":30,"original_position":30,"commit_id":"49eb251a431b06f6b3cc3af1c1b55a0eee85befd","original_commit_id":"49eb251a431b06f6b3cc3af1c1b55a0eee85befd","user":{"login":"PiotrProkop","id":10176859,"avatar_url":"https://avatars2.githubusercontent.com/u/10176859?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrProkop","html_url":"https://github.com/PiotrProkop","followers_url":"https://api.github.com/users/PiotrProkop/followers","following_url":"https://api.github.com/users/PiotrProkop/following{/other_user}","gists_url":"https://api.github.com/users/PiotrProkop/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrProkop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrProkop/subscriptions","organizations_url":"https://api.github.com/users/PiotrProkop/orgs","repos_url":"https://api.github.com/users/PiotrProkop/repos","events_url":"https://api.github.com/users/PiotrProkop/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrProkop/received_events","type":"User","site_admin":false},"body":"OK","created_at":"2018-02-16T14:47:52Z","updated_at":"2018-02-16T14:47:52Z","html_url":"https://github.com/yahoo/openstack/pull/14#discussion_r168775497","pull_request_url":"https://api.github.com/repos/yahoo/openstack/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/yahoo/openstack/pulls/comments/168775497"},"html":{"href":"https://github.com/yahoo/openstack/pull/14#discussion_r168775497"},"pull_request":{"href":"https://api.github.com/repos/yahoo/openstack/pulls/14"}},"in_reply_to_id":168631922},"pull_request":{"url":"https://api.github.com/repos/yahoo/openstack/pulls/14","id":166809660,"html_url":"https://github.com/yahoo/openstack/pull/14","diff_url":"https://github.com/yahoo/openstack/pull/14.diff","patch_url":"https://github.com/yahoo/openstack/pull/14.patch","issue_url":"https://api.github.com/repos/yahoo/openstack/issues/14","number":14,"state":"open","locked":false,"title":"Bumping version of Debian and adding necessary tooling to IPA.","user":{"login":"PiotrProkop","id":10176859,"avatar_url":"https://avatars2.githubusercontent.com/u/10176859?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrProkop","html_url":"https://github.com/PiotrProkop","followers_url":"https://api.github.com/users/PiotrProkop/followers","following_url":"https://api.github.com/users/PiotrProkop/following{/other_user}","gists_url":"https://api.github.com/users/PiotrProkop/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrProkop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrProkop/subscriptions","organizations_url":"https://api.github.com/users/PiotrProkop/orgs","repos_url":"https://api.github.com/users/PiotrProkop/repos","events_url":"https://api.github.com/users/PiotrProkop/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrProkop/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-02T14:02:21Z","updated_at":"2018-02-16T14:47:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac9eb727b98fcba61e8921e461f5d165c48b2e90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/openstack/pulls/14/commits","review_comments_url":"https://api.github.com/repos/yahoo/openstack/pulls/14/comments","review_comment_url":"https://api.github.com/repos/yahoo/openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/openstack/issues/14/comments","statuses_url":"https://api.github.com/repos/yahoo/openstack/statuses/49eb251a431b06f6b3cc3af1c1b55a0eee85befd","head":{"label":"PiotrProkop:debian-stretch","ref":"debian-stretch","sha":"49eb251a431b06f6b3cc3af1c1b55a0eee85befd","user":{"login":"PiotrProkop","id":10176859,"avatar_url":"https://avatars2.githubusercontent.com/u/10176859?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrProkop","html_url":"https://github.com/PiotrProkop","followers_url":"https://api.github.com/users/PiotrProkop/followers","following_url":"https://api.github.com/users/PiotrProkop/following{/other_user}","gists_url":"https://api.github.com/users/PiotrProkop/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrProkop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrProkop/subscriptions","organizations_url":"https://api.github.com/users/PiotrProkop/orgs","repos_url":"https://api.github.com/users/PiotrProkop/repos","events_url":"https://api.github.com/users/PiotrProkop/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrProkop/received_events","type":"User","site_admin":false},"repo":{"id":116273873,"name":"openstack","full_name":"PiotrProkop/openstack","owner":{"login":"PiotrProkop","id":10176859,"avatar_url":"https://avatars2.githubusercontent.com/u/10176859?v=4","gravatar_id":"","url":"https://api.github.com/users/PiotrProkop","html_url":"https://github.com/PiotrProkop","followers_url":"https://api.github.com/users/PiotrProkop/followers","following_url":"https://api.github.com/users/PiotrProkop/following{/other_user}","gists_url":"https://api.github.com/users/PiotrProkop/gists{/gist_id}","starred_url":"https://api.github.com/users/PiotrProkop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiotrProkop/subscriptions","organizations_url":"https://api.github.com/users/PiotrProkop/orgs","repos_url":"https://api.github.com/users/PiotrProkop/repos","events_url":"https://api.github.com/users/PiotrProkop/events{/privacy}","received_events_url":"https://api.github.com/users/PiotrProkop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PiotrProkop/openstack","description":null,"fork":true,"url":"https://api.github.com/repos/PiotrProkop/openstack","forks_url":"https://api.github.com/repos/PiotrProkop/openstack/forks","keys_url":"https://api.github.com/repos/PiotrProkop/openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PiotrProkop/openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PiotrProkop/openstack/teams","hooks_url":"https://api.github.com/repos/PiotrProkop/openstack/hooks","issue_events_url":"https://api.github.com/repos/PiotrProkop/openstack/issues/events{/number}","events_url":"https://api.github.com/repos/PiotrProkop/openstack/events","assignees_url":"https://api.github.com/repos/PiotrProkop/openstack/assignees{/user}","branches_url":"https://api.github.com/repos/PiotrProkop/openstack/branches{/branch}","tags_url":"https://api.github.com/repos/PiotrProkop/openstack/tags","blobs_url":"https://api.github.com/repos/PiotrProkop/openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PiotrProkop/openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PiotrProkop/openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/PiotrProkop/openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PiotrProkop/openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/PiotrProkop/openstack/languages","stargazers_url":"https://api.github.com/repos/PiotrProkop/openstack/stargazers","contributors_url":"https://api.github.com/repos/PiotrProkop/openstack/contributors","subscribers_url":"https://api.github.com/repos/PiotrProkop/openstack/subscribers","subscription_url":"https://api.github.com/repos/PiotrProkop/openstack/subscription","commits_url":"https://api.github.com/repos/PiotrProkop/openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/PiotrProkop/openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/PiotrProkop/openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/PiotrProkop/openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/PiotrProkop/openstack/contents/{+path}","compare_url":"https://api.github.com/repos/PiotrProkop/openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PiotrProkop/openstack/merges","archive_url":"https://api.github.com/repos/PiotrProkop/openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PiotrProkop/openstack/downloads","issues_url":"https://api.github.com/repos/PiotrProkop/openstack/issues{/number}","pulls_url":"https://api.github.com/repos/PiotrProkop/openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/PiotrProkop/openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/PiotrProkop/openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PiotrProkop/openstack/labels{/name}","releases_url":"https://api.github.com/repos/PiotrProkop/openstack/releases{/id}","deployments_url":"https://api.github.com/repos/PiotrProkop/openstack/deployments","created_at":"2018-01-04T15:07:36Z","updated_at":"2017-12-01T19:12:48Z","pushed_at":"2018-02-05T11:26:17Z","git_url":"git://github.com/PiotrProkop/openstack.git","ssh_url":"[email protected]:PiotrProkop/openstack.git","clone_url":"https://github.com/PiotrProkop/openstack.git","svn_url":"https://github.com/PiotrProkop/openstack","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"d1891eafedd3c6f8ab2947f3ccec133a440b5bb9","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":112777164,"name":"openstack","full_name":"yahoo/openstack","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/openstack","description":null,"fork":false,"url":"https://api.github.com/repos/yahoo/openstack","forks_url":"https://api.github.com/repos/yahoo/openstack/forks","keys_url":"https://api.github.com/repos/yahoo/openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/openstack/teams","hooks_url":"https://api.github.com/repos/yahoo/openstack/hooks","issue_events_url":"https://api.github.com/repos/yahoo/openstack/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/openstack/events","assignees_url":"https://api.github.com/repos/yahoo/openstack/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/openstack/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/openstack/tags","blobs_url":"https://api.github.com/repos/yahoo/openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/openstack/languages","stargazers_url":"https://api.github.com/repos/yahoo/openstack/stargazers","contributors_url":"https://api.github.com/repos/yahoo/openstack/contributors","subscribers_url":"https://api.github.com/repos/yahoo/openstack/subscribers","subscription_url":"https://api.github.com/repos/yahoo/openstack/subscription","commits_url":"https://api.github.com/repos/yahoo/openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/openstack/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/openstack/merges","archive_url":"https://api.github.com/repos/yahoo/openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/openstack/downloads","issues_url":"https://api.github.com/repos/yahoo/openstack/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/openstack/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/openstack/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/openstack/deployments","created_at":"2017-12-01T19:12:48Z","updated_at":"2017-12-01T19:12:48Z","pushed_at":"2018-02-16T14:36:42Z","git_url":"git://github.com/yahoo/openstack.git","ssh_url":"[email protected]:yahoo/openstack.git","clone_url":"https://github.com/yahoo/openstack.git","svn_url":"https://github.com/yahoo/openstack","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":4,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/openstack/pulls/14"},"html":{"href":"https://github.com/yahoo/openstack/pull/14"},"issue":{"href":"https://api.github.com/repos/yahoo/openstack/issues/14"},"comments":{"href":"https://api.github.com/repos/yahoo/openstack/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/openstack/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/openstack/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/openstack/statuses/49eb251a431b06f6b3cc3af1c1b55a0eee85befd"}},"author_association":"COLLABORATOR"}} | {
"id": 112777164,
"name": "yahoo/openstack",
"url": "https://api.github.com/repos/yahoo/openstack"
} | {
"id": 10176859,
"login": "PiotrProkop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10176859?",
"url": "https://api.github.com/users/PiotrProkop"
} | {
"id": 16574,
"login": "yahoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16574?",
"url": "https://api.github.com/orgs/yahoo"
} | 2018-02-16T14:47:52 | 7255407717 | {"actor":{"display_login":"PiotrProkop"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/navi/pulls/comments/173292340","pull_request_review_id":102460140,"id":173292340,"diff_hunk":"@@ -0,0 +1,19 @@\n+#!/bin/bash\n+set -e # Exit with nonzero exit code if anything fails\n+\n+###############################################################################\n+# Config NPM\n+###############################################################################","path":"scripts/ci-publish.sh","position":6,"original_position":6,"commit_id":"24105a70e7dc051c6082fbcf5bd0e48f3292bea2","original_commit_id":"24105a70e7dc051c6082fbcf5bd0e48f3292bea2","user":{"login":"jkusa","id":2983409,"avatar_url":"https://avatars1.githubusercontent.com/u/2983409?v=4","gravatar_id":"","url":"https://api.github.com/users/jkusa","html_url":"https://github.com/jkusa","followers_url":"https://api.github.com/users/jkusa/followers","following_url":"https://api.github.com/users/jkusa/following{/other_user}","gists_url":"https://api.github.com/users/jkusa/gists{/gist_id}","starred_url":"https://api.github.com/users/jkusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkusa/subscriptions","organizations_url":"https://api.github.com/users/jkusa/orgs","repos_url":"https://api.github.com/users/jkusa/repos","events_url":"https://api.github.com/users/jkusa/events{/privacy}","received_events_url":"https://api.github.com/users/jkusa/received_events","type":"User","site_admin":false},"body":"The script was initially bigger and made more sense. Still, bash scripts can get unwieldy. I like setting a standard that can carry forward if/when this scripts evolves.","created_at":"2018-03-08T21:10:46Z","updated_at":"2018-03-08T21:10:46Z","html_url":"https://github.com/yahoo/navi/pull/57#discussion_r173292340","pull_request_url":"https://api.github.com/repos/yahoo/navi/pulls/57","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yahoo/navi/pulls/comments/173292340"},"html":{"href":"https://github.com/yahoo/navi/pull/57#discussion_r173292340"},"pull_request":{"href":"https://api.github.com/repos/yahoo/navi/pulls/57"}},"in_reply_to_id":173286395},"pull_request":{"url":"https://api.github.com/repos/yahoo/navi/pulls/57","id":173844601,"html_url":"https://github.com/yahoo/navi/pull/57","diff_url":"https://github.com/yahoo/navi/pull/57.diff","patch_url":"https://github.com/yahoo/navi/pull/57.patch","issue_url":"https://api.github.com/repos/yahoo/navi/issues/57","number":57,"state":"open","locked":false,"title":"Automate prerelease package publishing","user":{"login":"jkusa","id":2983409,"avatar_url":"https://avatars1.githubusercontent.com/u/2983409?v=4","gravatar_id":"","url":"https://api.github.com/users/jkusa","html_url":"https://github.com/jkusa","followers_url":"https://api.github.com/users/jkusa/followers","following_url":"https://api.github.com/users/jkusa/following{/other_user}","gists_url":"https://api.github.com/users/jkusa/gists{/gist_id}","starred_url":"https://api.github.com/users/jkusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkusa/subscriptions","organizations_url":"https://api.github.com/users/jkusa/orgs","repos_url":"https://api.github.com/users/jkusa/repos","events_url":"https://api.github.com/users/jkusa/events{/privacy}","received_events_url":"https://api.github.com/users/jkusa/received_events","type":"User","site_admin":false},"body":"- Automate prerelease package publishing\r\n- Add `travis_wait` to longer running steps","created_at":"2018-03-08T20:41:03Z","updated_at":"2018-03-08T21:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12af90bfab28769095c8bdf084d9e9aa6122531d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/navi/pulls/57/commits","review_comments_url":"https://api.github.com/repos/yahoo/navi/pulls/57/comments","review_comment_url":"https://api.github.com/repos/yahoo/navi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/navi/issues/57/comments","statuses_url":"https://api.github.com/repos/yahoo/navi/statuses/24105a70e7dc051c6082fbcf5bd0e48f3292bea2","head":{"label":"yahoo:automate-deploy","ref":"automate-deploy","sha":"24105a70e7dc051c6082fbcf5bd0e48f3292bea2","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":101244961,"name":"navi","full_name":"yahoo/navi","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/navi","description":"Navi is a production quality analytics reporting UI with out of the box support for Fili.","fork":false,"url":"https://api.github.com/repos/yahoo/navi","forks_url":"https://api.github.com/repos/yahoo/navi/forks","keys_url":"https://api.github.com/repos/yahoo/navi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/navi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/navi/teams","hooks_url":"https://api.github.com/repos/yahoo/navi/hooks","issue_events_url":"https://api.github.com/repos/yahoo/navi/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/navi/events","assignees_url":"https://api.github.com/repos/yahoo/navi/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/navi/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/navi/tags","blobs_url":"https://api.github.com/repos/yahoo/navi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/navi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/navi/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/navi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/navi/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/navi/languages","stargazers_url":"https://api.github.com/repos/yahoo/navi/stargazers","contributors_url":"https://api.github.com/repos/yahoo/navi/contributors","subscribers_url":"https://api.github.com/repos/yahoo/navi/subscribers","subscription_url":"https://api.github.com/repos/yahoo/navi/subscription","commits_url":"https://api.github.com/repos/yahoo/navi/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/navi/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/navi/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/navi/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/navi/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/navi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/navi/merges","archive_url":"https://api.github.com/repos/yahoo/navi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/navi/downloads","issues_url":"https://api.github.com/repos/yahoo/navi/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/navi/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/navi/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/navi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/navi/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/navi/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/navi/deployments","created_at":"2017-08-24T02:24:36Z","updated_at":"2018-03-06T19:38:41Z","pushed_at":"2018-03-08T21:02:57Z","git_url":"git://github.com/yahoo/navi.git","ssh_url":"[email protected]:yahoo/navi.git","clone_url":"https://github.com/yahoo/navi.git","svn_url":"https://github.com/yahoo/navi","homepage":"","size":4646,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":37,"watchers":7,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"4a69738774151433c8f66913a784de70bf941d89","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":101244961,"name":"navi","full_name":"yahoo/navi","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/navi","description":"Navi is a production quality analytics reporting UI with out of the box support for Fili.","fork":false,"url":"https://api.github.com/repos/yahoo/navi","forks_url":"https://api.github.com/repos/yahoo/navi/forks","keys_url":"https://api.github.com/repos/yahoo/navi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/navi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/navi/teams","hooks_url":"https://api.github.com/repos/yahoo/navi/hooks","issue_events_url":"https://api.github.com/repos/yahoo/navi/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/navi/events","assignees_url":"https://api.github.com/repos/yahoo/navi/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/navi/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/navi/tags","blobs_url":"https://api.github.com/repos/yahoo/navi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/navi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/navi/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/navi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/navi/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/navi/languages","stargazers_url":"https://api.github.com/repos/yahoo/navi/stargazers","contributors_url":"https://api.github.com/repos/yahoo/navi/contributors","subscribers_url":"https://api.github.com/repos/yahoo/navi/subscribers","subscription_url":"https://api.github.com/repos/yahoo/navi/subscription","commits_url":"https://api.github.com/repos/yahoo/navi/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/navi/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/navi/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/navi/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/navi/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/navi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/navi/merges","archive_url":"https://api.github.com/repos/yahoo/navi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/navi/downloads","issues_url":"https://api.github.com/repos/yahoo/navi/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/navi/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/navi/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/navi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/navi/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/navi/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/navi/deployments","created_at":"2017-08-24T02:24:36Z","updated_at":"2018-03-06T19:38:41Z","pushed_at":"2018-03-08T21:02:57Z","git_url":"git://github.com/yahoo/navi.git","ssh_url":"[email protected]:yahoo/navi.git","clone_url":"https://github.com/yahoo/navi.git","svn_url":"https://github.com/yahoo/navi","homepage":"","size":4646,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":37,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/navi/pulls/57"},"html":{"href":"https://github.com/yahoo/navi/pull/57"},"issue":{"href":"https://api.github.com/repos/yahoo/navi/issues/57"},"comments":{"href":"https://api.github.com/repos/yahoo/navi/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/navi/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/navi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/navi/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/navi/statuses/24105a70e7dc051c6082fbcf5bd0e48f3292bea2"}},"author_association":"MEMBER"}} | {
"id": 101244961,
"name": "yahoo/navi",
"url": "https://api.github.com/repos/yahoo/navi"
} | {
"id": 2983409,
"login": "jkusa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2983409?",
"url": "https://api.github.com/users/jkusa"
} | {
"id": 16574,
"login": "yahoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16574?",
"url": "https://api.github.com/orgs/yahoo"
} | 2018-03-08T21:10:46 | 7352601207 | {"actor":{"display_login":"jkusa"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/comments/172609963","pull_request_review_id":101656646,"id":172609963,"diff_hunk":"@@ -119,6 +128,10 @@ parameters:\n value: production\n name: DEPLOYMENT_ENVIRONMENT\n required: true\n+- description: \"Number of worker processes to start.\"","path":"apicast-gateway/apicast.yml","position":null,"original_position":56,"commit_id":"dedce9bb0089fb28c3993c590908fa07e885c47a","original_commit_id":"15af1a80c3f312baa676f5e81106d753f52b7f2f","user":{"login":"maneta","id":1528321,"avatar_url":"https://avatars2.githubusercontent.com/u/1528321?v=4","gravatar_id":"","url":"https://api.github.com/users/maneta","html_url":"https://github.com/maneta","followers_url":"https://api.github.com/users/maneta/followers","following_url":"https://api.github.com/users/maneta/following{/other_user}","gists_url":"https://api.github.com/users/maneta/gists{/gist_id}","starred_url":"https://api.github.com/users/maneta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maneta/subscriptions","organizations_url":"https://api.github.com/users/maneta/orgs","repos_url":"https://api.github.com/users/maneta/repos","events_url":"https://api.github.com/users/maneta/events{/privacy}","received_events_url":"https://api.github.com/users/maneta/received_events","type":"User","site_admin":false},"body":"done in dedce9bb0089fb28c3993c590908fa07e885c47a","created_at":"2018-03-06T18:14:11Z","updated_at":"2018-03-06T18:14:11Z","html_url":"https://github.com/3scale/3scale-amp-openshift-templates/pull/15#discussion_r172609963","pull_request_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/comments/172609963"},"html":{"href":"https://github.com/3scale/3scale-amp-openshift-templates/pull/15#discussion_r172609963"},"pull_request":{"href":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/15"}},"in_reply_to_id":172608323},"pull_request":{"url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/15","id":167750498,"html_url":"https://github.com/3scale/3scale-amp-openshift-templates/pull/15","diff_url":"https://github.com/3scale/3scale-amp-openshift-templates/pull/15.diff","patch_url":"https://github.com/3scale/3scale-amp-openshift-templates/pull/15.patch","issue_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues/15","number":15,"state":"open","locked":false,"title":"Adjusting apicast resources requirements [THREESCALE-598]","user":{"login":"maneta","id":1528321,"avatar_url":"https://avatars2.githubusercontent.com/u/1528321?v=4","gravatar_id":"","url":"https://api.github.com/users/maneta","html_url":"https://github.com/maneta","followers_url":"https://api.github.com/users/maneta/followers","following_url":"https://api.github.com/users/maneta/following{/other_user}","gists_url":"https://api.github.com/users/maneta/gists{/gist_id}","starred_url":"https://api.github.com/users/maneta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maneta/subscriptions","organizations_url":"https://api.github.com/users/maneta/orgs","repos_url":"https://api.github.com/users/maneta/repos","events_url":"https://api.github.com/users/maneta/events{/privacy}","received_events_url":"https://api.github.com/users/maneta/received_events","type":"User","site_admin":false},"body":"Motivated by the insertion of Apicast template in OSO.\r\n\r\n@jmprusi @mikz Do you think that those values are good for everyone or do you think that maybe we should have a separated template just for Openshift Online Starter version.\r\n\r\nCloses: https://issues.jboss.org/browse/THREESCALE-598","created_at":"2018-02-07T16:58:14Z","updated_at":"2018-03-06T18:14:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0892c22846b6c1a34feed3677dade0111b214643","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/15/commits","review_comments_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/15/comments","review_comment_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues/15/comments","statuses_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/statuses/dedce9bb0089fb28c3993c590908fa07e885c47a","head":{"label":"3scale:apicast-adjust-resources-reqs","ref":"apicast-adjust-resources-reqs","sha":"dedce9bb0089fb28c3993c590908fa07e885c47a","user":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":77024660,"name":"3scale-amp-openshift-templates","full_name":"3scale/3scale-amp-openshift-templates","owner":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3scale/3scale-amp-openshift-templates","description":"3scale AMP OpenShift Templates","fork":false,"url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates","forks_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/forks","keys_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/teams","hooks_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/hooks","issue_events_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/events","assignees_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/tags","blobs_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/languages","stargazers_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/stargazers","contributors_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/contributors","subscribers_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/subscribers","subscription_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/subscription","commits_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/merges","archive_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/downloads","issues_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/labels{/name}","releases_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/deployments","created_at":"2016-12-21T06:28:44Z","updated_at":"2018-02-23T15:46:25Z","pushed_at":"2018-03-06T18:13:44Z","git_url":"git://github.com/3scale/3scale-amp-openshift-templates.git","ssh_url":"[email protected]:3scale/3scale-amp-openshift-templates.git","clone_url":"https://github.com/3scale/3scale-amp-openshift-templates.git","svn_url":"https://github.com/3scale/3scale-amp-openshift-templates","homepage":"","size":22,"stargazers_count":7,"watchers_count":7,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":14,"open_issues":3,"watchers":7,"default_branch":"master"}},"base":{"label":"3scale:master","ref":"master","sha":"47a1c2e3ab97fc41db65c541aeffbb51f51a839f","user":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":77024660,"name":"3scale-amp-openshift-templates","full_name":"3scale/3scale-amp-openshift-templates","owner":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3scale/3scale-amp-openshift-templates","description":"3scale AMP OpenShift Templates","fork":false,"url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates","forks_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/forks","keys_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/teams","hooks_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/hooks","issue_events_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/events","assignees_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/tags","blobs_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/languages","stargazers_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/stargazers","contributors_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/contributors","subscribers_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/subscribers","subscription_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/subscription","commits_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/merges","archive_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/downloads","issues_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/labels{/name}","releases_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/deployments","created_at":"2016-12-21T06:28:44Z","updated_at":"2018-02-23T15:46:25Z","pushed_at":"2018-03-06T18:13:44Z","git_url":"git://github.com/3scale/3scale-amp-openshift-templates.git","ssh_url":"[email protected]:3scale/3scale-amp-openshift-templates.git","clone_url":"https://github.com/3scale/3scale-amp-openshift-templates.git","svn_url":"https://github.com/3scale/3scale-amp-openshift-templates","homepage":"","size":22,"stargazers_count":7,"watchers_count":7,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":14,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/15"},"html":{"href":"https://github.com/3scale/3scale-amp-openshift-templates/pull/15"},"issue":{"href":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues/15"},"comments":{"href":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/3scale/3scale-amp-openshift-templates/statuses/dedce9bb0089fb28c3993c590908fa07e885c47a"}},"author_association":"CONTRIBUTOR"}} | {
"id": 77024660,
"name": "3scale/3scale-amp-openshift-templates",
"url": "https://api.github.com/repos/3scale/3scale-amp-openshift-templates"
} | {
"id": 1528321,
"login": "maneta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1528321?",
"url": "https://api.github.com/users/maneta"
} | {
"id": 21415,
"login": "3scale",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21415?",
"url": "https://api.github.com/orgs/3scale"
} | 2018-03-06T18:14:11 | 7339424036 | {"actor":{"display_login":"maneta"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/3scale/apicast/pulls/comments/173231043","pull_request_review_id":102386673,"id":173231043,"diff_hunk":"@@ -5,12 +5,16 @@ PROJECT_PATH=\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" && cd .. && pwd )\"\n ROVER=\"/usr/local/openresty/luajit/bin/rover\"\n \n function run_busted_tests {\n+ sudo cp -R /tmp/lua_modules .","path":"script/test","position":4,"original_position":4,"commit_id":"565906b493c373ae6e510f88960c4cbf38f9865f","original_commit_id":"565906b493c373ae6e510f88960c4cbf38f9865f","user":{"login":"davidor","id":907223,"avatar_url":"https://avatars2.githubusercontent.com/u/907223?v=4","gravatar_id":"","url":"https://api.github.com/users/davidor","html_url":"https://github.com/davidor","followers_url":"https://api.github.com/users/davidor/followers","following_url":"https://api.github.com/users/davidor/following{/other_user}","gists_url":"https://api.github.com/users/davidor/gists{/gist_id}","starred_url":"https://api.github.com/users/davidor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidor/subscriptions","organizations_url":"https://api.github.com/users/davidor/orgs","repos_url":"https://api.github.com/users/davidor/repos","events_url":"https://api.github.com/users/davidor/events{/privacy}","received_events_url":"https://api.github.com/users/davidor/received_events","type":"User","site_admin":false},"body":"Not sure it's worth in this case, the time spent copying the files is _nothing_ compared to the time spent running the integration tests.","created_at":"2018-03-08T17:28:29Z","updated_at":"2018-03-08T17:28:29Z","html_url":"https://github.com/3scale/apicast/pull/649#discussion_r173231043","pull_request_url":"https://api.github.com/repos/3scale/apicast/pulls/649","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/3scale/apicast/pulls/comments/173231043"},"html":{"href":"https://github.com/3scale/apicast/pull/649#discussion_r173231043"},"pull_request":{"href":"https://api.github.com/repos/3scale/apicast/pulls/649"}},"in_reply_to_id":173226172},"pull_request":{"url":"https://api.github.com/repos/3scale/apicast/pulls/649","id":173792929,"html_url":"https://github.com/3scale/apicast/pull/649","diff_url":"https://github.com/3scale/apicast/pull/649.diff","patch_url":"https://github.com/3scale/apicast/pull/649.patch","issue_url":"https://api.github.com/repos/3scale/apicast/issues/649","number":649,"state":"open","locked":false,"title":"Dockerized dev env: ensure correct dependencies are used","user":{"login":"davidor","id":907223,"avatar_url":"https://avatars2.githubusercontent.com/u/907223?v=4","gravatar_id":"","url":"https://api.github.com/users/davidor","html_url":"https://github.com/davidor","followers_url":"https://api.github.com/users/davidor/followers","following_url":"https://api.github.com/users/davidor/following{/other_user}","gists_url":"https://api.github.com/users/davidor/gists{/gist_id}","starred_url":"https://api.github.com/users/davidor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidor/subscriptions","organizations_url":"https://api.github.com/users/davidor/orgs","repos_url":"https://api.github.com/users/davidor/repos","events_url":"https://api.github.com/users/davidor/events{/privacy}","received_events_url":"https://api.github.com/users/davidor/received_events","type":"User","site_admin":false},"body":"The problem was that when mounting the volume, ./lua_modules was used instead of the one generated inside the container.\r\n\r\nTo solve the issue, lua_modules is moved to a tmp directory when building the container and we make sure to use it when running the tests in `script/test`.","created_at":"2018-03-08T17:02:05Z","updated_at":"2018-03-08T17:28:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb91e8bd17c5e5da2aeeba44380118e92715c088","assignee":{"login":"davidor","id":907223,"avatar_url":"https://avatars2.githubusercontent.com/u/907223?v=4","gravatar_id":"","url":"https://api.github.com/users/davidor","html_url":"https://github.com/davidor","followers_url":"https://api.github.com/users/davidor/followers","following_url":"https://api.github.com/users/davidor/following{/other_user}","gists_url":"https://api.github.com/users/davidor/gists{/gist_id}","starred_url":"https://api.github.com/users/davidor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidor/subscriptions","organizations_url":"https://api.github.com/users/davidor/orgs","repos_url":"https://api.github.com/users/davidor/repos","events_url":"https://api.github.com/users/davidor/events{/privacy}","received_events_url":"https://api.github.com/users/davidor/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidor","id":907223,"avatar_url":"https://avatars2.githubusercontent.com/u/907223?v=4","gravatar_id":"","url":"https://api.github.com/users/davidor","html_url":"https://github.com/davidor","followers_url":"https://api.github.com/users/davidor/followers","following_url":"https://api.github.com/users/davidor/following{/other_user}","gists_url":"https://api.github.com/users/davidor/gists{/gist_id}","starred_url":"https://api.github.com/users/davidor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidor/subscriptions","organizations_url":"https://api.github.com/users/davidor/orgs","repos_url":"https://api.github.com/users/davidor/repos","events_url":"https://api.github.com/users/davidor/events{/privacy}","received_events_url":"https://api.github.com/users/davidor/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/3scale/apicast/pulls/649/commits","review_comments_url":"https://api.github.com/repos/3scale/apicast/pulls/649/comments","review_comment_url":"https://api.github.com/repos/3scale/apicast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3scale/apicast/issues/649/comments","statuses_url":"https://api.github.com/repos/3scale/apicast/statuses/565906b493c373ae6e510f88960c4cbf38f9865f","head":{"label":"3scale:ensure-correct-deps-development-docker","ref":"ensure-correct-deps-development-docker","sha":"565906b493c373ae6e510f88960c4cbf38f9865f","user":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":53965666,"name":"apicast","full_name":"3scale/apicast","owner":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3scale/apicast","description":"3scale api gateway reloaded","fork":false,"url":"https://api.github.com/repos/3scale/apicast","forks_url":"https://api.github.com/repos/3scale/apicast/forks","keys_url":"https://api.github.com/repos/3scale/apicast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/apicast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/apicast/teams","hooks_url":"https://api.github.com/repos/3scale/apicast/hooks","issue_events_url":"https://api.github.com/repos/3scale/apicast/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/apicast/events","assignees_url":"https://api.github.com/repos/3scale/apicast/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/apicast/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/apicast/tags","blobs_url":"https://api.github.com/repos/3scale/apicast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/apicast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/apicast/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/apicast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/apicast/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/apicast/languages","stargazers_url":"https://api.github.com/repos/3scale/apicast/stargazers","contributors_url":"https://api.github.com/repos/3scale/apicast/contributors","subscribers_url":"https://api.github.com/repos/3scale/apicast/subscribers","subscription_url":"https://api.github.com/repos/3scale/apicast/subscription","commits_url":"https://api.github.com/repos/3scale/apicast/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/apicast/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/apicast/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/apicast/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/apicast/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/apicast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/apicast/merges","archive_url":"https://api.github.com/repos/3scale/apicast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/apicast/downloads","issues_url":"https://api.github.com/repos/3scale/apicast/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/apicast/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/apicast/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/apicast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/apicast/labels{/name}","releases_url":"https://api.github.com/repos/3scale/apicast/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/apicast/deployments","created_at":"2016-03-15T17:41:51Z","updated_at":"2018-03-05T22:35:03Z","pushed_at":"2018-03-08T17:02:05Z","git_url":"git://github.com/3scale/apicast.git","ssh_url":"[email protected]:3scale/apicast.git","clone_url":"https://github.com/3scale/apicast.git","svn_url":"https://github.com/3scale/apicast","homepage":"","size":2542,"stargazers_count":74,"watchers_count":74,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":52,"open_issues":50,"watchers":74,"default_branch":"master"}},"base":{"label":"3scale:master","ref":"master","sha":"2affe4e40e268841b489cf06c229a66ac9aa9749","user":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":53965666,"name":"apicast","full_name":"3scale/apicast","owner":{"login":"3scale","id":21415,"avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3scale/apicast","description":"3scale api gateway reloaded","fork":false,"url":"https://api.github.com/repos/3scale/apicast","forks_url":"https://api.github.com/repos/3scale/apicast/forks","keys_url":"https://api.github.com/repos/3scale/apicast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/apicast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/apicast/teams","hooks_url":"https://api.github.com/repos/3scale/apicast/hooks","issue_events_url":"https://api.github.com/repos/3scale/apicast/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/apicast/events","assignees_url":"https://api.github.com/repos/3scale/apicast/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/apicast/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/apicast/tags","blobs_url":"https://api.github.com/repos/3scale/apicast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/apicast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/apicast/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/apicast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/apicast/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/apicast/languages","stargazers_url":"https://api.github.com/repos/3scale/apicast/stargazers","contributors_url":"https://api.github.com/repos/3scale/apicast/contributors","subscribers_url":"https://api.github.com/repos/3scale/apicast/subscribers","subscription_url":"https://api.github.com/repos/3scale/apicast/subscription","commits_url":"https://api.github.com/repos/3scale/apicast/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/apicast/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/apicast/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/apicast/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/apicast/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/apicast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/apicast/merges","archive_url":"https://api.github.com/repos/3scale/apicast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/apicast/downloads","issues_url":"https://api.github.com/repos/3scale/apicast/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/apicast/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/apicast/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/apicast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/apicast/labels{/name}","releases_url":"https://api.github.com/repos/3scale/apicast/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/apicast/deployments","created_at":"2016-03-15T17:41:51Z","updated_at":"2018-03-05T22:35:03Z","pushed_at":"2018-03-08T17:02:05Z","git_url":"git://github.com/3scale/apicast.git","ssh_url":"[email protected]:3scale/apicast.git","clone_url":"https://github.com/3scale/apicast.git","svn_url":"https://github.com/3scale/apicast","homepage":"","size":2542,"stargazers_count":74,"watchers_count":74,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":52,"open_issues":50,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3scale/apicast/pulls/649"},"html":{"href":"https://github.com/3scale/apicast/pull/649"},"issue":{"href":"https://api.github.com/repos/3scale/apicast/issues/649"},"comments":{"href":"https://api.github.com/repos/3scale/apicast/issues/649/comments"},"review_comments":{"href":"https://api.github.com/repos/3scale/apicast/pulls/649/comments"},"review_comment":{"href":"https://api.github.com/repos/3scale/apicast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3scale/apicast/pulls/649/commits"},"statuses":{"href":"https://api.github.com/repos/3scale/apicast/statuses/565906b493c373ae6e510f88960c4cbf38f9865f"}},"author_association":"MEMBER"}} | {
"id": 53965666,
"name": "3scale/apicast",
"url": "https://api.github.com/repos/3scale/apicast"
} | {
"id": 907223,
"login": "davidor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/907223?",
"url": "https://api.github.com/users/davidor"
} | {
"id": 21415,
"login": "3scale",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21415?",
"url": "https://api.github.com/orgs/3scale"
} | 2018-03-08T17:28:29 | 7351517107 | {"actor":{"display_login":"davidor"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/docs/pulls/comments/174784813","pull_request_review_id":104204203,"id":174784813,"diff_hunk":"@@ -118,6 +118,9 @@ It is also allowed to directly assign those properties to modify the date::\n \n $time->year = 2015;\n $time->timezone = 'Europe/Paris';\n+ \n+.. note::\n+ Starting with version 3.5, $now->timezone returned the object(DateTimeZone) ","path":"en/core-libraries/time.rst","position":6,"original_position":6,"commit_id":"13f4700617675517979f22c3fdaaa161688238cc","original_commit_id":"13f4700617675517979f22c3fdaaa161688238cc","user":{"login":"saeideng","id":8215801,"avatar_url":"https://avatars3.githubusercontent.com/u/8215801?v=4","gravatar_id":"","url":"https://api.github.com/users/saeideng","html_url":"https://github.com/saeideng","followers_url":"https://api.github.com/users/saeideng/followers","following_url":"https://api.github.com/users/saeideng/following{/other_user}","gists_url":"https://api.github.com/users/saeideng/gists{/gist_id}","starred_url":"https://api.github.com/users/saeideng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saeideng/subscriptions","organizations_url":"https://api.github.com/users/saeideng/orgs","repos_url":"https://api.github.com/users/saeideng/repos","events_url":"https://api.github.com/users/saeideng/events{/privacy}","received_events_url":"https://api.github.com/users/saeideng/received_events","type":"User","site_admin":false},"body":"not related to cake version ","created_at":"2018-03-15T13:41:59Z","updated_at":"2018-03-15T13:42:05Z","html_url":"https://github.com/cakephp/docs/pull/5662#discussion_r174784813","pull_request_url":"https://api.github.com/repos/cakephp/docs/pulls/5662","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cakephp/docs/pulls/comments/174784813"},"html":{"href":"https://github.com/cakephp/docs/pull/5662#discussion_r174784813"},"pull_request":{"href":"https://api.github.com/repos/cakephp/docs/pulls/5662"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/docs/pulls/5662","id":175233953,"html_url":"https://github.com/cakephp/docs/pull/5662","diff_url":"https://github.com/cakephp/docs/pull/5662.diff","patch_url":"https://github.com/cakephp/docs/pull/5662.patch","issue_url":"https://api.github.com/repos/cakephp/docs/issues/5662","number":5662,"state":"open","locked":false,"title":"inaccuracy in the documentation in time.rst [Eng]","user":{"login":"patsuckow","id":12321741,"avatar_url":"https://avatars1.githubusercontent.com/u/12321741?v=4","gravatar_id":"","url":"https://api.github.com/users/patsuckow","html_url":"https://github.com/patsuckow","followers_url":"https://api.github.com/users/patsuckow/followers","following_url":"https://api.github.com/users/patsuckow/following{/other_user}","gists_url":"https://api.github.com/users/patsuckow/gists{/gist_id}","starred_url":"https://api.github.com/users/patsuckow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patsuckow/subscriptions","organizations_url":"https://api.github.com/users/patsuckow/orgs","repos_url":"https://api.github.com/users/patsuckow/repos","events_url":"https://api.github.com/users/patsuckow/events{/privacy}","received_events_url":"https://api.github.com/users/patsuckow/received_events","type":"User","site_admin":false},"body":"inaccuracy in the documentation in time.rst [Eng]. \r\n$now = Time::now();\r\ndebug($now->timezone); // will return an object: object(DateTimeZone)\r\n\r\n(only I'm not sure about the version with which it was changed, but in version 3.5 exactly this result)","created_at":"2018-03-15T12:23:25Z","updated_at":"2018-03-15T13:42:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e072274b8492ab6077c8f1af608be8aee1db4118","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/docs/pulls/5662/commits","review_comments_url":"https://api.github.com/repos/cakephp/docs/pulls/5662/comments","review_comment_url":"https://api.github.com/repos/cakephp/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/docs/issues/5662/comments","statuses_url":"https://api.github.com/repos/cakephp/docs/statuses/13f4700617675517979f22c3fdaaa161688238cc","head":{"label":"patsuckow:patch-59","ref":"patch-59","sha":"13f4700617675517979f22c3fdaaa161688238cc","user":{"login":"patsuckow","id":12321741,"avatar_url":"https://avatars1.githubusercontent.com/u/12321741?v=4","gravatar_id":"","url":"https://api.github.com/users/patsuckow","html_url":"https://github.com/patsuckow","followers_url":"https://api.github.com/users/patsuckow/followers","following_url":"https://api.github.com/users/patsuckow/following{/other_user}","gists_url":"https://api.github.com/users/patsuckow/gists{/gist_id}","starred_url":"https://api.github.com/users/patsuckow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patsuckow/subscriptions","organizations_url":"https://api.github.com/users/patsuckow/orgs","repos_url":"https://api.github.com/users/patsuckow/repos","events_url":"https://api.github.com/users/patsuckow/events{/privacy}","received_events_url":"https://api.github.com/users/patsuckow/received_events","type":"User","site_admin":false},"repo":{"id":110949577,"name":"docs","full_name":"patsuckow/docs","owner":{"login":"patsuckow","id":12321741,"avatar_url":"https://avatars1.githubusercontent.com/u/12321741?v=4","gravatar_id":"","url":"https://api.github.com/users/patsuckow","html_url":"https://github.com/patsuckow","followers_url":"https://api.github.com/users/patsuckow/followers","following_url":"https://api.github.com/users/patsuckow/following{/other_user}","gists_url":"https://api.github.com/users/patsuckow/gists{/gist_id}","starred_url":"https://api.github.com/users/patsuckow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patsuckow/subscriptions","organizations_url":"https://api.github.com/users/patsuckow/orgs","repos_url":"https://api.github.com/users/patsuckow/repos","events_url":"https://api.github.com/users/patsuckow/events{/privacy}","received_events_url":"https://api.github.com/users/patsuckow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patsuckow/docs","description":"CakePHP CookBook","fork":true,"url":"https://api.github.com/repos/patsuckow/docs","forks_url":"https://api.github.com/repos/patsuckow/docs/forks","keys_url":"https://api.github.com/repos/patsuckow/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patsuckow/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patsuckow/docs/teams","hooks_url":"https://api.github.com/repos/patsuckow/docs/hooks","issue_events_url":"https://api.github.com/repos/patsuckow/docs/issues/events{/number}","events_url":"https://api.github.com/repos/patsuckow/docs/events","assignees_url":"https://api.github.com/repos/patsuckow/docs/assignees{/user}","branches_url":"https://api.github.com/repos/patsuckow/docs/branches{/branch}","tags_url":"https://api.github.com/repos/patsuckow/docs/tags","blobs_url":"https://api.github.com/repos/patsuckow/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patsuckow/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patsuckow/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/patsuckow/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patsuckow/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/patsuckow/docs/languages","stargazers_url":"https://api.github.com/repos/patsuckow/docs/stargazers","contributors_url":"https://api.github.com/repos/patsuckow/docs/contributors","subscribers_url":"https://api.github.com/repos/patsuckow/docs/subscribers","subscription_url":"https://api.github.com/repos/patsuckow/docs/subscription","commits_url":"https://api.github.com/repos/patsuckow/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/patsuckow/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/patsuckow/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/patsuckow/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/patsuckow/docs/contents/{+path}","compare_url":"https://api.github.com/repos/patsuckow/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patsuckow/docs/merges","archive_url":"https://api.github.com/repos/patsuckow/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patsuckow/docs/downloads","issues_url":"https://api.github.com/repos/patsuckow/docs/issues{/number}","pulls_url":"https://api.github.com/repos/patsuckow/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/patsuckow/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/patsuckow/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patsuckow/docs/labels{/name}","releases_url":"https://api.github.com/repos/patsuckow/docs/releases{/id}","deployments_url":"https://api.github.com/repos/patsuckow/docs/deployments","created_at":"2017-11-16T09:14:05Z","updated_at":"2017-11-16T09:14:13Z","pushed_at":"2018-03-15T12:23:00Z","git_url":"git://github.com/patsuckow/docs.git","ssh_url":"[email protected]:patsuckow/docs.git","clone_url":"https://github.com/patsuckow/docs.git","svn_url":"https://github.com/patsuckow/docs","homepage":"http://book.cakephp.org","size":59624,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.0"}},"base":{"label":"cakephp:3.0","ref":"3.0","sha":"5386814f5747c34c7736cd015620da9b0847275f","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":1514950,"name":"docs","full_name":"cakephp/docs","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/docs","description":"CakePHP CookBook","fork":false,"url":"https://api.github.com/repos/cakephp/docs","forks_url":"https://api.github.com/repos/cakephp/docs/forks","keys_url":"https://api.github.com/repos/cakephp/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/docs/teams","hooks_url":"https://api.github.com/repos/cakephp/docs/hooks","issue_events_url":"https://api.github.com/repos/cakephp/docs/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/docs/events","assignees_url":"https://api.github.com/repos/cakephp/docs/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/docs/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/docs/tags","blobs_url":"https://api.github.com/repos/cakephp/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/docs/languages","stargazers_url":"https://api.github.com/repos/cakephp/docs/stargazers","contributors_url":"https://api.github.com/repos/cakephp/docs/contributors","subscribers_url":"https://api.github.com/repos/cakephp/docs/subscribers","subscription_url":"https://api.github.com/repos/cakephp/docs/subscription","commits_url":"https://api.github.com/repos/cakephp/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/docs/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/docs/merges","archive_url":"https://api.github.com/repos/cakephp/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/docs/downloads","issues_url":"https://api.github.com/repos/cakephp/docs/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/docs/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/docs/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/docs/deployments","created_at":"2011-03-23T04:54:13Z","updated_at":"2018-03-14T20:56:14Z","pushed_at":"2018-03-15T13:25:00Z","git_url":"git://github.com/cakephp/docs.git","ssh_url":"[email protected]:cakephp/docs.git","clone_url":"https://github.com/cakephp/docs.git","svn_url":"https://github.com/cakephp/docs","homepage":"http://book.cakephp.org","size":59819,"stargazers_count":595,"watchers_count":595,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2467,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2467,"open_issues":50,"watchers":595,"default_branch":"3.0"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/docs/pulls/5662"},"html":{"href":"https://github.com/cakephp/docs/pull/5662"},"issue":{"href":"https://api.github.com/repos/cakephp/docs/issues/5662"},"comments":{"href":"https://api.github.com/repos/cakephp/docs/issues/5662/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/docs/pulls/5662/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/docs/pulls/5662/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/docs/statuses/13f4700617675517979f22c3fdaaa161688238cc"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1514950,
"name": "cakephp/docs",
"url": "https://api.github.com/repos/cakephp/docs"
} | {
"id": 8215801,
"login": "saeideng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8215801?",
"url": "https://api.github.com/users/saeideng"
} | {
"id": 23666,
"login": "cakephp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23666?",
"url": "https://api.github.com/orgs/cakephp"
} | 2018-03-15T13:41:59 | 7384719719 | {"actor":{"display_login":"saeideng"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/221421194","pull_request_review_id":160072761,"id":221421194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQyMTE5NA==","diff_hunk":"@@ -6284,6 +6309,14 @@ void zend_compile_class_decl(zend_ast *ast, zend_bool toplevel) /* {{{ */\n \t}\n \n \tCG(active_class_entry) = ce;\n+\tif (extends_ast) {\n+\t\tzend_string *extends_name = zend_ast_get_str(extends_ast);\n+\t\tCG(active_class_entry_parent_name) = zend_resolve_class_name(\n+\t\t\textends_name,\n+\t\t\textends_ast->kind == ZEND_AST_ZVAL ? extends_ast->attr : ZEND_NAME_FQ);","path":"Zend/zend_compile.c","position":89,"original_position":89,"commit_id":"351d360a6712ce9800922398da55057ce5aac525","original_commit_id":"351d360a6712ce9800922398da55057ce5aac525","user":{"login":"nikic","id":216080,"node_id":"MDQ6VXNlcjIxNjA4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/216080?v=4","gravatar_id":"","url":"https://api.github.com/users/nikic","html_url":"https://github.com/nikic","followers_url":"https://api.github.com/users/nikic/followers","following_url":"https://api.github.com/users/nikic/following{/other_user}","gists_url":"https://api.github.com/users/nikic/gists{/gist_id}","starred_url":"https://api.github.com/users/nikic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikic/subscriptions","organizations_url":"https://api.github.com/users/nikic/orgs","repos_url":"https://api.github.com/users/nikic/repos","events_url":"https://api.github.com/users/nikic/events{/privacy}","received_events_url":"https://api.github.com/users/nikic/received_events","type":"User","site_admin":false},"body":"This is no longer necessary, you can use `ce->parent_name`.","created_at":"2018-09-29T08:34:53Z","updated_at":"2018-09-29T08:34:53Z","html_url":"https://github.com/php/php-src/pull/3564#discussion_r221421194","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/3564","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/221421194"},"html":{"href":"https://github.com/php/php-src/pull/3564#discussion_r221421194"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/3564"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/3564","id":219094564,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDk0NTY0","html_url":"https://github.com/php/php-src/pull/3564","diff_url":"https://github.com/php/php-src/pull/3564.diff","patch_url":"https://github.com/php/php-src/pull/3564.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/3564","number":3564,"state":"open","locked":false,"title":"Add compile-time warning on invalid parent use","user":{"login":"morrisonlevi","id":253316,"node_id":"MDQ6VXNlcjI1MzMxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/253316?v=4","gravatar_id":"","url":"https://api.github.com/users/morrisonlevi","html_url":"https://github.com/morrisonlevi","followers_url":"https://api.github.com/users/morrisonlevi/followers","following_url":"https://api.github.com/users/morrisonlevi/following{/other_user}","gists_url":"https://api.github.com/users/morrisonlevi/gists{/gist_id}","starred_url":"https://api.github.com/users/morrisonlevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrisonlevi/subscriptions","organizations_url":"https://api.github.com/users/morrisonlevi/orgs","repos_url":"https://api.github.com/users/morrisonlevi/repos","events_url":"https://api.github.com/users/morrisonlevi/events{/privacy}","received_events_url":"https://api.github.com/users/morrisonlevi/received_events","type":"User","site_admin":false},"body":"This is a new attempt at fixing the issue from PR #3404.","created_at":"2018-09-28T21:51:44Z","updated_at":"2018-09-29T08:34:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e437c395341b050fb56196da78661f336ec1b4a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/3564/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/3564/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/3564/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/351d360a6712ce9800922398da55057ce5aac525","head":{"label":"morrisonlevi:parent","ref":"parent","sha":"351d360a6712ce9800922398da55057ce5aac525","user":{"login":"morrisonlevi","id":253316,"node_id":"MDQ6VXNlcjI1MzMxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/253316?v=4","gravatar_id":"","url":"https://api.github.com/users/morrisonlevi","html_url":"https://github.com/morrisonlevi","followers_url":"https://api.github.com/users/morrisonlevi/followers","following_url":"https://api.github.com/users/morrisonlevi/following{/other_user}","gists_url":"https://api.github.com/users/morrisonlevi/gists{/gist_id}","starred_url":"https://api.github.com/users/morrisonlevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrisonlevi/subscriptions","organizations_url":"https://api.github.com/users/morrisonlevi/orgs","repos_url":"https://api.github.com/users/morrisonlevi/repos","events_url":"https://api.github.com/users/morrisonlevi/events{/privacy}","received_events_url":"https://api.github.com/users/morrisonlevi/received_events","type":"User","site_admin":false},"repo":{"id":13503680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwMzY4MA==","name":"php-src","full_name":"morrisonlevi/php-src","private":false,"owner":{"login":"morrisonlevi","id":253316,"node_id":"MDQ6VXNlcjI1MzMxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/253316?v=4","gravatar_id":"","url":"https://api.github.com/users/morrisonlevi","html_url":"https://github.com/morrisonlevi","followers_url":"https://api.github.com/users/morrisonlevi/followers","following_url":"https://api.github.com/users/morrisonlevi/following{/other_user}","gists_url":"https://api.github.com/users/morrisonlevi/gists{/gist_id}","starred_url":"https://api.github.com/users/morrisonlevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrisonlevi/subscriptions","organizations_url":"https://api.github.com/users/morrisonlevi/orgs","repos_url":"https://api.github.com/users/morrisonlevi/repos","events_url":"https://api.github.com/users/morrisonlevi/events{/privacy}","received_events_url":"https://api.github.com/users/morrisonlevi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/morrisonlevi/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/morrisonlevi/php-src","forks_url":"https://api.github.com/repos/morrisonlevi/php-src/forks","keys_url":"https://api.github.com/repos/morrisonlevi/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morrisonlevi/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morrisonlevi/php-src/teams","hooks_url":"https://api.github.com/repos/morrisonlevi/php-src/hooks","issue_events_url":"https://api.github.com/repos/morrisonlevi/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/morrisonlevi/php-src/events","assignees_url":"https://api.github.com/repos/morrisonlevi/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/morrisonlevi/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/morrisonlevi/php-src/tags","blobs_url":"https://api.github.com/repos/morrisonlevi/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morrisonlevi/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morrisonlevi/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/morrisonlevi/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morrisonlevi/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/morrisonlevi/php-src/languages","stargazers_url":"https://api.github.com/repos/morrisonlevi/php-src/stargazers","contributors_url":"https://api.github.com/repos/morrisonlevi/php-src/contributors","subscribers_url":"https://api.github.com/repos/morrisonlevi/php-src/subscribers","subscription_url":"https://api.github.com/repos/morrisonlevi/php-src/subscription","commits_url":"https://api.github.com/repos/morrisonlevi/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/morrisonlevi/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/morrisonlevi/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/morrisonlevi/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/morrisonlevi/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/morrisonlevi/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morrisonlevi/php-src/merges","archive_url":"https://api.github.com/repos/morrisonlevi/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morrisonlevi/php-src/downloads","issues_url":"https://api.github.com/repos/morrisonlevi/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/morrisonlevi/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/morrisonlevi/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/morrisonlevi/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morrisonlevi/php-src/labels{/name}","releases_url":"https://api.github.com/repos/morrisonlevi/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/morrisonlevi/php-src/deployments","created_at":"2013-10-11T16:22:18Z","updated_at":"2018-09-28T20:21:01Z","pushed_at":"2018-09-29T01:25:59Z","git_url":"git://github.com/morrisonlevi/php-src.git","ssh_url":"[email protected]:morrisonlevi/php-src.git","clone_url":"https://github.com/morrisonlevi/php-src.git","svn_url":"https://github.com/morrisonlevi/php-src","homepage":"http://www.php.net","size":320801,"stargazers_count":9,"watchers_count":9,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":9,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"36a4f58ab9e566b014e73caa24a6fdbc3e8b8f75","user":{"login":"php","id":25158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAzNTIy","name":"php-src","full_name":"php/php-src","private":false,"owner":{"login":"php","id":25158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2018-09-29T08:26:29Z","pushed_at":"2018-09-29T07:30:28Z","git_url":"git://github.com/php/php-src.git","ssh_url":"[email protected]:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":322991,"stargazers_count":19593,"watchers_count":19593,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5010,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5010,"open_issues":166,"watchers":19593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/3564"},"html":{"href":"https://github.com/php/php-src/pull/3564"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/3564"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/3564/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/3564/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/3564/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/351d360a6712ce9800922398da55057ce5aac525"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1903522,
"name": "php/php-src",
"url": "https://api.github.com/repos/php/php-src"
} | {
"id": 216080,
"login": "nikic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/216080?",
"url": "https://api.github.com/users/nikic"
} | {
"id": 25158,
"login": "php",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25158?",
"url": "https://api.github.com/orgs/php"
} | 2018-09-29T08:34:53 | 8341773624 | {"actor":{"display_login":"nikic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments/180134830","pull_request_review_id":110502997,"id":180134830,"diff_hunk":"@@ -37,25 +36,26 @@ public class Stitch {\n * - throws: A `StitchInitializationError` if initialization fails for any reason.\n */\n public static func initialize() throws {\n- try! StitchCore.sync(self) {\n- guard !initialized else { return }\n+ objc_sync_enter(self)\n+ defer { objc_sync_exit(self) }","path":"StitchCore-iOS/StitchCore-iOS/Core/Stitch.swift","position":12,"original_position":12,"commit_id":"b9980fd27880fd4bf575c55e4a5db918077b1fec","original_commit_id":"b9980fd27880fd4bf575c55e4a5db918077b1fec","user":{"login":"jsflax","id":4356928,"avatar_url":"https://avatars3.githubusercontent.com/u/4356928?v=4","gravatar_id":"","url":"https://api.github.com/users/jsflax","html_url":"https://github.com/jsflax","followers_url":"https://api.github.com/users/jsflax/followers","following_url":"https://api.github.com/users/jsflax/following{/other_user}","gists_url":"https://api.github.com/users/jsflax/gists{/gist_id}","starred_url":"https://api.github.com/users/jsflax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsflax/subscriptions","organizations_url":"https://api.github.com/users/jsflax/orgs","repos_url":"https://api.github.com/users/jsflax/repos","events_url":"https://api.github.com/users/jsflax/events{/privacy}","received_events_url":"https://api.github.com/users/jsflax/received_events","type":"User","site_admin":false},"body":"But the same can be said if, for whatever reason, the code exits the function after `enter` but an `exit` has not been stated. That would also cause a crash or hanging lock.","created_at":"2018-04-09T15:31:38Z","updated_at":"2018-04-09T15:31:38Z","html_url":"https://github.com/mongodb/stitch-ios-sdk/pull/46#discussion_r180134830","pull_request_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/46","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments/180134830"},"html":{"href":"https://github.com/mongodb/stitch-ios-sdk/pull/46#discussion_r180134830"},"pull_request":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/46"}},"in_reply_to_id":180131615},"pull_request":{"url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/46","id":180017076,"html_url":"https://github.com/mongodb/stitch-ios-sdk/pull/46","diff_url":"https://github.com/mongodb/stitch-ios-sdk/pull/46.diff","patch_url":"https://github.com/mongodb/stitch-ios-sdk/pull/46.patch","issue_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/46","number":46,"state":"open","locked":false,"title":"STITCH-1356 Remove try notation for sync in StitchCore-iOS","user":{"login":"adamchel","id":1976694,"avatar_url":"https://avatars1.githubusercontent.com/u/1976694?v=4","gravatar_id":"","url":"https://api.github.com/users/adamchel","html_url":"https://github.com/adamchel","followers_url":"https://api.github.com/users/adamchel/followers","following_url":"https://api.github.com/users/adamchel/following{/other_user}","gists_url":"https://api.github.com/users/adamchel/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchel/subscriptions","organizations_url":"https://api.github.com/users/adamchel/orgs","repos_url":"https://api.github.com/users/adamchel/repos","events_url":"https://api.github.com/users/adamchel/events{/privacy}","received_events_url":"https://api.github.com/users/adamchel/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-06T18:08:17Z","updated_at":"2018-04-09T15:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6120dd0434a04d564d83c8256ee30e3676d90630","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/46/commits","review_comments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/46/comments","review_comment_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/46/comments","statuses_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/statuses/b9980fd27880fd4bf575c55e4a5db918077b1fec","head":{"label":"adamchel:STITCH-1356","ref":"STITCH-1356","sha":"b9980fd27880fd4bf575c55e4a5db918077b1fec","user":{"login":"adamchel","id":1976694,"avatar_url":"https://avatars1.githubusercontent.com/u/1976694?v=4","gravatar_id":"","url":"https://api.github.com/users/adamchel","html_url":"https://github.com/adamchel","followers_url":"https://api.github.com/users/adamchel/followers","following_url":"https://api.github.com/users/adamchel/following{/other_user}","gists_url":"https://api.github.com/users/adamchel/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchel/subscriptions","organizations_url":"https://api.github.com/users/adamchel/orgs","repos_url":"https://api.github.com/users/adamchel/repos","events_url":"https://api.github.com/users/adamchel/events{/privacy}","received_events_url":"https://api.github.com/users/adamchel/received_events","type":"User","site_admin":false},"repo":{"id":107455725,"name":"stitch-ios-sdk","full_name":"adamchel/stitch-ios-sdk","owner":{"login":"adamchel","id":1976694,"avatar_url":"https://avatars1.githubusercontent.com/u/1976694?v=4","gravatar_id":"","url":"https://api.github.com/users/adamchel","html_url":"https://github.com/adamchel","followers_url":"https://api.github.com/users/adamchel/followers","following_url":"https://api.github.com/users/adamchel/following{/other_user}","gists_url":"https://api.github.com/users/adamchel/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchel/subscriptions","organizations_url":"https://api.github.com/users/adamchel/orgs","repos_url":"https://api.github.com/users/adamchel/repos","events_url":"https://api.github.com/users/adamchel/events{/privacy}","received_events_url":"https://api.github.com/users/adamchel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamchel/stitch-ios-sdk","description":null,"fork":true,"url":"https://api.github.com/repos/adamchel/stitch-ios-sdk","forks_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/forks","keys_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/teams","hooks_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/events","assignees_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/tags","blobs_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/subscription","commits_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/merges","archive_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/downloads","issues_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/adamchel/stitch-ios-sdk/deployments","created_at":"2017-10-18T19:51:20Z","updated_at":"2017-10-18T19:51:22Z","pushed_at":"2018-04-06T19:48:42Z","git_url":"git://github.com/adamchel/stitch-ios-sdk.git","ssh_url":"[email protected]:adamchel/stitch-ios-sdk.git","clone_url":"https://github.com/adamchel/stitch-ios-sdk.git","svn_url":"https://github.com/adamchel/stitch-ios-sdk","homepage":null,"size":27039,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mongodb:v4-alpha","ref":"v4-alpha","sha":"48d010be79dc5530b730b73e0080a727c8a40628","user":{"login":"mongodb","id":45120,"avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":93444591,"name":"stitch-ios-sdk","full_name":"mongodb/stitch-ios-sdk","owner":{"login":"mongodb","id":45120,"avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/stitch-ios-sdk","description":null,"fork":false,"url":"https://api.github.com/repos/mongodb/stitch-ios-sdk","forks_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/forks","keys_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/teams","hooks_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/events","assignees_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/tags","blobs_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/subscription","commits_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/merges","archive_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/downloads","issues_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/deployments","created_at":"2017-06-05T20:37:29Z","updated_at":"2018-03-29T09:54:19Z","pushed_at":"2018-04-06T20:01:08Z","git_url":"git://github.com/mongodb/stitch-ios-sdk.git","ssh_url":"[email protected]:mongodb/stitch-ios-sdk.git","clone_url":"https://github.com/mongodb/stitch-ios-sdk.git","svn_url":"https://github.com/mongodb/stitch-ios-sdk","homepage":null,"size":26985,"stargazers_count":8,"watchers_count":8,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/46"},"html":{"href":"https://github.com/mongodb/stitch-ios-sdk/pull/46"},"issue":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/46"},"comments":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/statuses/b9980fd27880fd4bf575c55e4a5db918077b1fec"}},"author_association":"CONTRIBUTOR"}} | {
"id": 93444591,
"name": "mongodb/stitch-ios-sdk",
"url": "https://api.github.com/repos/mongodb/stitch-ios-sdk"
} | {
"id": 4356928,
"login": "jsflax",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4356928?",
"url": "https://api.github.com/users/jsflax"
} | {
"id": 45120,
"login": "mongodb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45120?",
"url": "https://api.github.com/orgs/mongodb"
} | 2018-04-09T15:31:38 | 7501421001 | {"actor":{"display_login":"jsflax"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/specifications/pulls/comments/180338728","pull_request_review_id":110741029,"id":180338728,"diff_hunk":"@@ -1,279 +1,344 @@\n {\n-\t\"tests\": [\n-\t\t{\n-\t\t\t\"description\": \"should use the default source and mechanism\",\n-\t\t\t\"uri\": \"mongodb://user:password@localhost\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"db\": \"admin\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should use the database when no authSource is specified\",\n-\t\t\t\"uri\": \"mongodb://user:password@localhost/foo\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"db\": \"foo\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should use the authSource when specified\",\n-\t\t\t\"uri\": \"mongodb://user:password@localhost/foo?authSource=bar\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"db\": \"bar\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize an empty password\",\n-\t\t\t\"uri\": \"mongodb://user:@localhost\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"username\": \"user\",\n-\t\t\t\t\"password\": \"\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize no password\",\n-\t\t\t\"uri\": \"mongodb://user@localhost\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"username\": \"user\",\n-\t\t\t\t\"password\": null\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize a url escaped character in the username\",\n-\t\t\t\"uri\": \"mongodb://user%40DOMAIN.COM:password@localhost\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"username\": \"[email protected]\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize the mechanism\",\n-\t\t\t\"uri\": \"mongodb://user@localhost/?authMechanism=GSSAPI\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": {\n-\t\t\t\t\"authmechanism\": \"GSSAPI\"\n-\t\t\t}\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should use $external as the source\",\n-\t\t\t\"uri\": \"mongodb://user%40DOMAIN.COM:password@localhost/?authMechanism=GSSAPI\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"db\": \"$external\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should use $external as the source when a database is specified\",\n-\t\t\t\"uri\": \"mongodb://user%40DOMAIN.COM:password@localhost/foo?authMechanism=GSSAPI\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"db\": \"$external\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should throw an exception when an authSource is specified other than $external\",\n-\t\t\t\"uri\": \"mongodb://user%40DOMAIN.COM:password@localhost/foo?authMechanism=GSSAPI&authSource=bar\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": false,\n-\t\t\t\"warning\": true,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": null\n-\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should throw an exception when an authMechanism is specified with no username\",\n-\t\t\t\"uri\": \"mongodb://localhost/?authMechanism=GSSAPI\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": false,\n-\t\t\t\"warning\": true,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should accept generic mechanism property\",\n-\t\t\t\"uri\": \"mongodb://user%40DOMAIN.COM:password@localhost/?authMechanism=GSSAPI&authMechanismProperties=SERVICE_NAME:other,CANONICALIZE_HOST_NAME:true\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": {\n-\t\t\t\t\"authmechanism\": \"GSSAPI\",\n-\t\t\t\t\"authmechanismproperties\": {\n-\t\t\t\t\t\"SERVICE_NAME\": \"other\",\n-\t\t\t\t\t\"CANONICALIZE_HOST_NAME\": true\n-\t\t\t\t}\n-\t\t\t}\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should accept legacy gssapiServiceName\",\n-\t\t\t\"uri\": \"mongodb://user%40DOMAIN.COM:password@localhost/?authMechanism=GSSAPI&gssapiServiceName=other\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": {\n-\t\t\t\t\"authmechanism\": \"GSSAPI\",\n-\t\t\t\t\"authmechanismproperties\": {\n-\t\t\t\t\t\"SERVICE_NAME\": \"other\"\n-\t\t\t\t}\n-\t\t\t}\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize the mechanism\",\n-\t\t\t\"uri\": \"mongodb://user:pass@localhost/?authMechanism=MONGODB-CR\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": {\n-\t\t\t\t\"authmechanism\": \"MONGODB-CR\"\n-\t\t\t}\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should throw an exception when an authMechanism is specified with no username\",\n-\t\t\t\"uri\": \"mongodb://localhost/?authMechanism=MONGODB-CR\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": false,\n-\t\t\t\"warning\": true,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should use $external as the source\",\n-\t\t\t\"uri\": \"mongodb://CN%3DmyName%2COU%3DmyOrgUnit%2CO%3DmyOrg%2CL%3DmyLocality%2CST%3DmyState%2CC%3DmyCountry@localhost/?authMechanism=MONGODB-X509\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"db\": \"$external\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should use $external as the source when a database is specified\",\n-\t\t\t\"uri\": \"mongodb://CN%3DmyName%2COU%3DmyOrgUnit%2CO%3DmyOrg%2CL%3DmyLocality%2CST%3DmyState%2CC%3DmyCountry@localhost/foo?authMechanism=MONGODB-X509\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"db\": \"$external\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should throw an exception when an authSource is specified other than $external\",\n-\t\t\t\"uri\": \"mongodb://CN%3DmyName%2COU%3DmyOrgUnit%2CO%3DmyOrg%2CL%3DmyLocality%2CST%3DmyState%2CC%3DmyCountry@localhost/foo?authMechanism=MONGODB-X509&authSource=bar\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": false,\n-\t\t\t\"warning\": true,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize the mechanism\",\n-\t\t\t\"uri\": \"mongodb://CN%3DmyName%2COU%3DmyOrgUnit%2CO%3DmyOrg%2CL%3DmyLocality%2CST%3DmyState%2CC%3DmyCountry@localhost/?authMechanism=MONGODB-X509\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": {\n-\t\t\t\t\"authmechanism\": \"MONGODB-X509\"\n-\t\t\t}\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize the mechanism with no username\",\n-\t\t\t\"uri\": \"mongodb://localhost/?authMechanism=MONGODB-X509\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"username\": null\n-\t\t\t},\n-\t\t\t\"options\": {\n-\t\t\t\t\"authmechanism\": \"MONGODB-X509\"\n-\t\t\t}\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize the encoded username\",\n-\t\t\t\"uri\": \"mongodb://CN%3DmyName%2COU%3DmyOrgUnit%2CO%3DmyOrg%2CL%3DmyLocality%2CST%3DmyState%2CC%3DmyCountry@localhost/?authMechanism=MONGODB-X509\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": {\n-\t\t\t\t\"username\": \"CN=myName,OU=myOrgUnit,O=myOrg,L=myLocality,ST=myState,C=myCountry\"\n-\t\t\t},\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize the mechanism\",\n-\t\t\t\"uri\": \"mongodb://user:password@localhost/?authMechanism=PLAIN\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": {\n-\t\t\t\t\"authmechanism\": \"PLAIN\"\n-\t\t\t}\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should throw an exception when an authMechanism is specified with no username\",\n-\t\t\t\"uri\": \"mongodb://localhost/?authMechanism=PLAIN\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": false,\n-\t\t\t\"warning\": true,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": null\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should recognize the mechanism\",\n-\t\t\t\"uri\": \"mongodb://user:password@localhost/?authMechanism=SCRAM-SHA-1\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": true,\n-\t\t\t\"warning\": false,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": {\n-\t\t\t\t\"authmechanism\": \"SCRAM-SHA-1\"\n-\t\t\t}\n-\t\t},\n-\t\t{\n-\t\t\t\"description\": \"should throw an exception when an authMechanism is specified with no username\",\n-\t\t\t\"uri\": \"mongodb://localhost/?authMechanism=SCRAM-SHA-1\",\n-\t\t\t\"hosts\": [],\n-\t\t\t\"valid\": false,\n-\t\t\t\"warning\": true,\n-\t\t\t\"auth\": null,\n-\t\t\t\"options\": null\n-\t\t}\n-\t]\n+ \"tests\": [\n+ {\n+ \"description\": \"should use the default source and mechanism\",\n+ \"uri\": \"mongodb://user:password@localhost\",\n+ \"hosts\": null,\n+ \"valid\": true,\n+ \"warning\": false,\n+ \"auth\": {\n+ \"username\": \"user\",\n+ \"password\": \"password\",\n+ \"db\": \"admin\"\n+ },\n+ \"options\": null\n+ },\n+ {\n+ \"description\": \"should use the database when no authSource is specified\",\n+ \"uri\": \"mongodb://user:password@localhost/foo\",\n+ \"hosts\": null,\n+ \"valid\": true,\n+ \"warning\": false,\n+ \"auth\": {\n+ \"username\": \"user\",\n+ \"password\": \"password\",\n+ \"db\": \"foo\"\n+ },\n+ \"options\": null\n+ },\n+ {\n+ \"description\": \"should use the authSource when specified\",\n+ \"uri\": \"mongodb://user:password@localhost/foo?authSource=bar\",\n+ \"hosts\": null,\n+ \"valid\": true,\n+ \"warning\": false,\n+ \"auth\": {\n+ \"username\": \"user\",\n+ \"password\": \"password\",\n+ \"db\": \"bar\"\n+ },\n+ \"options\": null\n+ },\n+ {\n+ \"description\": \"should recognise the mechanism (GSSAPI)\",\n+ \"uri\": \"mongodb://user%40DOMAIN.COM@localhost/?authMechanism=GSSAPI\",\n+ \"hosts\": null,\n+ \"valid\": true,\n+ \"warning\": false,\n+ \"auth\": {\n+ \"username\": \"[email protected]\",\n+ \"password\": null,\n+ \"db\": \"$external\"\n+ },\n+ \"options\": {\n+ \"authmechanism\": \"GSSAPI\"\n+ }\n+ },\n+ {\n+ \"description\": \"should default the auth database to $external when the mechanism is GSSAPI\",\n+ \"uri\": \"mongodb://user%40DOMAIN.COM@localhost/foo?authMechanism=GSSAPI\",\n+ \"hosts\": null,\n+ \"valid\": true,\n+ \"warning\": false,\n+ \"auth\": {\n+ \"username\": \"[email protected]\",\n+ \"password\": null,\n+ \"db\": \"$external\"\n+ },\n+ \"options\": {\n+ \"authmechanism\": \"GSSAPI\"\n+ }\n+ },\n+ {\n+ \"description\": \"should recognise the mechanism where authSource $external (GSSAPI)\",\n+ \"uri\": \"mongodb://user%40DOMAIN.COM@localhost/foo?authMechanism=GSSAPI&authSource=$external\",\n+ \"hosts\": null,\n+ \"valid\": true,\n+ \"warning\": false,\n+ \"auth\": {\n+ \"username\": \"[email protected]\",\n+ \"password\": null,\n+ \"db\": \"$external\"\n+ },\n+ \"options\": {\n+ \"authmechanism\": \"GSSAPI\"\n+ }\n+ },\n+ {\n+ \"description\": \"should accept generic mechanism property (GSSAPI)\",\n+ \"uri\": \"mongodb://user%40DOMAIN.COM@localhost/?authMechanism=GSSAPI&authMechanismProperties=SERVICE_NAME:other,CANONICALIZE_HOST_NAME:true\",\n+ \"hosts\": null,\n+ \"valid\": true,\n+ \"warning\": false,\n+ \"auth\": {\n+ \"username\": \"[email protected]\",\n+ \"password\": null,\n+ \"db\": \"$external\"\n+ },\n+ \"options\": {\n+ \"authmechanism\": \"GSSAPI\",\n+ \"authmechanismproperties\": {\n+ \"SERVICE_NAME\": \"other\",\n+ \"CANONICALIZE_HOST_NAME\": true\n+ }\n+ }\n+ },\n+ {\n+ \"description\": \"should recognise password if SSPI is supported (GSSAPI)\",\n+ \"uri\": \"mongodb://user%40DOMAIN.COM:password@localhost/foo?authMechanism=GSSAPI&authSource=$external\",\n+ \"hosts\": null,\n+ \"valid\": true,\n+ \"warning\": false,\n+ \"auth\": {\n+ \"username\": \"[email protected]\",\n+ \"password\": \"password\",\n+ \"db\": \"$external\"\n+ },\n+ \"options\": {\n+ \"authmechanism\": \"GSSAPI\"\n+ }\n+ },\n+ {\n+ \"description\": \"should accept legacy gssapiServiceName (GSSAPI)\",","path":"source/auth/tests/connection-string.json","position":399,"original_position":399,"commit_id":"dd1a1548b8c47d58a0c4e398b22cf777fa8342ae","original_commit_id":"dd1a1548b8c47d58a0c4e398b22cf777fa8342ae","user":{"login":"rozza","id":420,"avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"body":"Good idea, will clarify the name of the test to:\r\n\r\nmay support deprecated gssapiServiceName option (GSSAPI)","created_at":"2018-04-10T08:42:30Z","updated_at":"2018-04-10T08:42:30Z","html_url":"https://github.com/mongodb/specifications/pull/301#discussion_r180338728","pull_request_url":"https://api.github.com/repos/mongodb/specifications/pulls/301","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/comments/180338728"},"html":{"href":"https://github.com/mongodb/specifications/pull/301#discussion_r180338728"},"pull_request":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/301"}},"in_reply_to_id":180285162},"pull_request":{"url":"https://api.github.com/repos/mongodb/specifications/pulls/301","id":180397401,"html_url":"https://github.com/mongodb/specifications/pull/301","diff_url":"https://github.com/mongodb/specifications/pull/301.diff","patch_url":"https://github.com/mongodb/specifications/pull/301.patch","issue_url":"https://api.github.com/repos/mongodb/specifications/issues/301","number":301,"state":"open","locked":false,"title":"Clarified defaults for auth mechanisms","user":{"login":"rozza","id":420,"avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"body":"Normalized the test cases\r\nAdded yml file\r\nAdded SCRAM-SHA-256 test\r\n\r\nSPEC-1042 SPEC-818 DRIVERS-410 DRIVERS-439","created_at":"2018-04-09T19:00:52Z","updated_at":"2018-04-10T08:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9bac28e847492934b6d35f2cb803ac43093d3b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/specifications/pulls/301/commits","review_comments_url":"https://api.github.com/repos/mongodb/specifications/pulls/301/comments","review_comment_url":"https://api.github.com/repos/mongodb/specifications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/specifications/issues/301/comments","statuses_url":"https://api.github.com/repos/mongodb/specifications/statuses/dd1a1548b8c47d58a0c4e398b22cf777fa8342ae","head":{"label":"rozza:s1042","ref":"s1042","sha":"dd1a1548b8c47d58a0c4e398b22cf777fa8342ae","user":{"login":"rozza","id":420,"avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"repo":{"id":97122084,"name":"specifications","full_name":"rozza/specifications","owner":{"login":"rozza","id":420,"avatar_url":"https://avatars0.githubusercontent.com/u/420?v=4","gravatar_id":"","url":"https://api.github.com/users/rozza","html_url":"https://github.com/rozza","followers_url":"https://api.github.com/users/rozza/followers","following_url":"https://api.github.com/users/rozza/following{/other_user}","gists_url":"https://api.github.com/users/rozza/gists{/gist_id}","starred_url":"https://api.github.com/users/rozza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozza/subscriptions","organizations_url":"https://api.github.com/users/rozza/orgs","repos_url":"https://api.github.com/users/rozza/repos","events_url":"https://api.github.com/users/rozza/events{/privacy}","received_events_url":"https://api.github.com/users/rozza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rozza/specifications","description":"Specifications related to MongoDB","fork":true,"url":"https://api.github.com/repos/rozza/specifications","forks_url":"https://api.github.com/repos/rozza/specifications/forks","keys_url":"https://api.github.com/repos/rozza/specifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rozza/specifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rozza/specifications/teams","hooks_url":"https://api.github.com/repos/rozza/specifications/hooks","issue_events_url":"https://api.github.com/repos/rozza/specifications/issues/events{/number}","events_url":"https://api.github.com/repos/rozza/specifications/events","assignees_url":"https://api.github.com/repos/rozza/specifications/assignees{/user}","branches_url":"https://api.github.com/repos/rozza/specifications/branches{/branch}","tags_url":"https://api.github.com/repos/rozza/specifications/tags","blobs_url":"https://api.github.com/repos/rozza/specifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rozza/specifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rozza/specifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/rozza/specifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rozza/specifications/statuses/{sha}","languages_url":"https://api.github.com/repos/rozza/specifications/languages","stargazers_url":"https://api.github.com/repos/rozza/specifications/stargazers","contributors_url":"https://api.github.com/repos/rozza/specifications/contributors","subscribers_url":"https://api.github.com/repos/rozza/specifications/subscribers","subscription_url":"https://api.github.com/repos/rozza/specifications/subscription","commits_url":"https://api.github.com/repos/rozza/specifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/rozza/specifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/rozza/specifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/rozza/specifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/rozza/specifications/contents/{+path}","compare_url":"https://api.github.com/repos/rozza/specifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rozza/specifications/merges","archive_url":"https://api.github.com/repos/rozza/specifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rozza/specifications/downloads","issues_url":"https://api.github.com/repos/rozza/specifications/issues{/number}","pulls_url":"https://api.github.com/repos/rozza/specifications/pulls{/number}","milestones_url":"https://api.github.com/repos/rozza/specifications/milestones{/number}","notifications_url":"https://api.github.com/repos/rozza/specifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rozza/specifications/labels{/name}","releases_url":"https://api.github.com/repos/rozza/specifications/releases{/id}","deployments_url":"https://api.github.com/repos/rozza/specifications/deployments","created_at":"2017-07-13T12:50:35Z","updated_at":"2018-04-09T12:46:16Z","pushed_at":"2018-04-09T18:58:57Z","git_url":"git://github.com/rozza/specifications.git","ssh_url":"[email protected]:rozza/specifications.git","clone_url":"https://github.com/rozza/specifications.git","svn_url":"https://github.com/rozza/specifications","homepage":null,"size":3424,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mongodb:master","ref":"master","sha":"190ba24046f4078c9868ac08c2a0b56d7543a581","user":{"login":"mongodb","id":45120,"avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":19244865,"name":"specifications","full_name":"mongodb/specifications","owner":{"login":"mongodb","id":45120,"avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/specifications","description":"Specifications related to MongoDB","fork":false,"url":"https://api.github.com/repos/mongodb/specifications","forks_url":"https://api.github.com/repos/mongodb/specifications/forks","keys_url":"https://api.github.com/repos/mongodb/specifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/specifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/specifications/teams","hooks_url":"https://api.github.com/repos/mongodb/specifications/hooks","issue_events_url":"https://api.github.com/repos/mongodb/specifications/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/specifications/events","assignees_url":"https://api.github.com/repos/mongodb/specifications/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/specifications/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/specifications/tags","blobs_url":"https://api.github.com/repos/mongodb/specifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/specifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/specifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/specifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/specifications/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/specifications/languages","stargazers_url":"https://api.github.com/repos/mongodb/specifications/stargazers","contributors_url":"https://api.github.com/repos/mongodb/specifications/contributors","subscribers_url":"https://api.github.com/repos/mongodb/specifications/subscribers","subscription_url":"https://api.github.com/repos/mongodb/specifications/subscription","commits_url":"https://api.github.com/repos/mongodb/specifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/specifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/specifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/specifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/specifications/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/specifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/specifications/merges","archive_url":"https://api.github.com/repos/mongodb/specifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/specifications/downloads","issues_url":"https://api.github.com/repos/mongodb/specifications/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/specifications/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/specifications/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/specifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/specifications/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/specifications/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/specifications/deployments","created_at":"2014-04-28T16:04:56Z","updated_at":"2018-04-09T16:16:41Z","pushed_at":"2018-04-09T19:00:53Z","git_url":"git://github.com/mongodb/specifications.git","ssh_url":"[email protected]:mongodb/specifications.git","clone_url":"https://github.com/mongodb/specifications.git","svn_url":"https://github.com/mongodb/specifications","homepage":null,"size":3442,"stargazers_count":111,"watchers_count":111,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":61,"open_issues":6,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/301"},"html":{"href":"https://github.com/mongodb/specifications/pull/301"},"issue":{"href":"https://api.github.com/repos/mongodb/specifications/issues/301"},"comments":{"href":"https://api.github.com/repos/mongodb/specifications/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/specifications/statuses/dd1a1548b8c47d58a0c4e398b22cf777fa8342ae"}},"author_association":"MEMBER"}} | {
"id": 19244865,
"name": "mongodb/specifications",
"url": "https://api.github.com/repos/mongodb/specifications"
} | {
"id": 420,
"login": "rozza",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/420?",
"url": "https://api.github.com/users/rozza"
} | {
"id": 45120,
"login": "mongodb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45120?",
"url": "https://api.github.com/orgs/mongodb"
} | 2018-04-10T08:42:30 | 7505514575 | {"actor":{"display_login":"rozza"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments/241564510","pull_request_review_id":184872710,"id":241564510,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTU2NDUxMA==","diff_hunk":"@@ -25,12 +35,17 @@ class NamespaceChangeStreamDelegate: SSEStreamDelegate, NetworkStateDelegate {\n self.service = service\n self.networkMonitor = networkMonitor\n self.authMonitor = authMonitor\n+ super.init()\n+ networkMonitor.add(networkStateDelegate: self)\n }\n \n /**\n Open the event stream.\n */\n func start() throws {\n+ objc_sync_enter(self)","path":"Core/Services/StitchCoreRemoteMongoDBService/Sources/StitchCoreRemoteMongoDBService/Sync/NamespaceChangeStreamDelegate.swift","position":41,"original_position":41,"commit_id":"ecdb7494bff186813a84eca8c623e6fcbbe51354","original_commit_id":"71b37b3d3331b6f8e300a38ddb5d74799bdc0c6a","user":{"login":"jsflax","id":4356928,"node_id":"MDQ6VXNlcjQzNTY5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/4356928?v=4","gravatar_id":"","url":"https://api.github.com/users/jsflax","html_url":"https://github.com/jsflax","followers_url":"https://api.github.com/users/jsflax/followers","following_url":"https://api.github.com/users/jsflax/following{/other_user}","gists_url":"https://api.github.com/users/jsflax/gists{/gist_id}","starred_url":"https://api.github.com/users/jsflax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsflax/subscriptions","organizations_url":"https://api.github.com/users/jsflax/orgs","repos_url":"https://api.github.com/users/jsflax/repos","events_url":"https://api.github.com/users/jsflax/events{/privacy}","received_events_url":"https://api.github.com/users/jsflax/received_events","type":"User","site_admin":false},"body":"Will be handled in RWLock ticket coming later.","created_at":"2018-12-13T21:17:51Z","updated_at":"2018-12-13T21:17:51Z","html_url":"https://github.com/mongodb/stitch-ios-sdk/pull/118#discussion_r241564510","pull_request_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/118","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments/241564510"},"html":{"href":"https://github.com/mongodb/stitch-ios-sdk/pull/118#discussion_r241564510"},"pull_request":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/118"}},"in_reply_to_id":241468100},"pull_request":{"url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/118","id":238257104,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjU3MTA0","html_url":"https://github.com/mongodb/stitch-ios-sdk/pull/118","diff_url":"https://github.com/mongodb/stitch-ios-sdk/pull/118.diff","patch_url":"https://github.com/mongodb/stitch-ios-sdk/pull/118.patch","issue_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/118","number":118,"state":"open","locked":false,"title":"STITCH-2218/STITCH-2219 Swift SDK: Conflict handling in the data synchronizer - R2L/L2R","user":{"login":"jsflax","id":4356928,"node_id":"MDQ6VXNlcjQzNTY5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/4356928?v=4","gravatar_id":"","url":"https://api.github.com/users/jsflax","html_url":"https://github.com/jsflax","followers_url":"https://api.github.com/users/jsflax/followers","following_url":"https://api.github.com/users/jsflax/following{/other_user}","gists_url":"https://api.github.com/users/jsflax/gists{/gist_id}","starred_url":"https://api.github.com/users/jsflax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsflax/subscriptions","organizations_url":"https://api.github.com/users/jsflax/orgs","repos_url":"https://api.github.com/users/jsflax/repos","events_url":"https://api.github.com/users/jsflax/events{/privacy}","received_events_url":"https://api.github.com/users/jsflax/received_events","type":"User","site_admin":false},"body":"Contains both tickets and the beginning few integration tests.","created_at":"2018-12-13T03:53:47Z","updated_at":"2018-12-13T21:17:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d13dbc75b5f1a04d8701b9f924584f2d539f1016","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dkaminsky","id":15115463,"node_id":"MDQ6VXNlcjE1MTE1NDYz","avatar_url":"https://avatars2.githubusercontent.com/u/15115463?v=4","gravatar_id":"","url":"https://api.github.com/users/dkaminsky","html_url":"https://github.com/dkaminsky","followers_url":"https://api.github.com/users/dkaminsky/followers","following_url":"https://api.github.com/users/dkaminsky/following{/other_user}","gists_url":"https://api.github.com/users/dkaminsky/gists{/gist_id}","starred_url":"https://api.github.com/users/dkaminsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkaminsky/subscriptions","organizations_url":"https://api.github.com/users/dkaminsky/orgs","repos_url":"https://api.github.com/users/dkaminsky/repos","events_url":"https://api.github.com/users/dkaminsky/events{/privacy}","received_events_url":"https://api.github.com/users/dkaminsky/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/118/commits","review_comments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/118/comments","review_comment_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/118/comments","statuses_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/statuses/ecdb7494bff186813a84eca8c623e6fcbbe51354","head":{"label":"jsflax:STITCH-2218","ref":"STITCH-2218","sha":"ecdb7494bff186813a84eca8c623e6fcbbe51354","user":{"login":"jsflax","id":4356928,"node_id":"MDQ6VXNlcjQzNTY5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/4356928?v=4","gravatar_id":"","url":"https://api.github.com/users/jsflax","html_url":"https://github.com/jsflax","followers_url":"https://api.github.com/users/jsflax/followers","following_url":"https://api.github.com/users/jsflax/following{/other_user}","gists_url":"https://api.github.com/users/jsflax/gists{/gist_id}","starred_url":"https://api.github.com/users/jsflax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsflax/subscriptions","organizations_url":"https://api.github.com/users/jsflax/orgs","repos_url":"https://api.github.com/users/jsflax/repos","events_url":"https://api.github.com/users/jsflax/events{/privacy}","received_events_url":"https://api.github.com/users/jsflax/received_events","type":"User","site_admin":false},"repo":{"id":110735788,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA3MzU3ODg=","name":"stitch-ios-sdk","full_name":"jsflax/stitch-ios-sdk","private":false,"owner":{"login":"jsflax","id":4356928,"node_id":"MDQ6VXNlcjQzNTY5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/4356928?v=4","gravatar_id":"","url":"https://api.github.com/users/jsflax","html_url":"https://github.com/jsflax","followers_url":"https://api.github.com/users/jsflax/followers","following_url":"https://api.github.com/users/jsflax/following{/other_user}","gists_url":"https://api.github.com/users/jsflax/gists{/gist_id}","starred_url":"https://api.github.com/users/jsflax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsflax/subscriptions","organizations_url":"https://api.github.com/users/jsflax/orgs","repos_url":"https://api.github.com/users/jsflax/repos","events_url":"https://api.github.com/users/jsflax/events{/privacy}","received_events_url":"https://api.github.com/users/jsflax/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jsflax/stitch-ios-sdk","description":null,"fork":true,"url":"https://api.github.com/repos/jsflax/stitch-ios-sdk","forks_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/forks","keys_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/teams","hooks_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/events","assignees_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/tags","blobs_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/subscription","commits_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/merges","archive_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/downloads","issues_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/jsflax/stitch-ios-sdk/deployments","created_at":"2017-11-14T19:35:26Z","updated_at":"2018-11-16T21:30:31Z","pushed_at":"2018-12-13T20:03:19Z","git_url":"git://github.com/jsflax/stitch-ios-sdk.git","ssh_url":"[email protected]:jsflax/stitch-ios-sdk.git","clone_url":"https://github.com/jsflax/stitch-ios-sdk.git","svn_url":"https://github.com/jsflax/stitch-ios-sdk","homepage":null,"size":195826,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mongodb:sync","ref":"sync","sha":"173ecbf9e306f7bbaa8d1f7a68f1cf2425fbff2e","user":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":93444591,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NDU5MQ==","name":"stitch-ios-sdk","full_name":"mongodb/stitch-ios-sdk","private":false,"owner":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mongodb/stitch-ios-sdk","description":null,"fork":false,"url":"https://api.github.com/repos/mongodb/stitch-ios-sdk","forks_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/forks","keys_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/teams","hooks_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/events","assignees_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/tags","blobs_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/subscription","commits_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/merges","archive_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/downloads","issues_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/stitch-ios-sdk/deployments","created_at":"2017-06-05T20:37:29Z","updated_at":"2018-12-07T17:17:14Z","pushed_at":"2018-12-13T20:48:46Z","git_url":"git://github.com/mongodb/stitch-ios-sdk.git","ssh_url":"[email protected]:mongodb/stitch-ios-sdk.git","clone_url":"https://github.com/mongodb/stitch-ios-sdk.git","svn_url":"https://github.com/mongodb/stitch-ios-sdk","homepage":null,"size":28168,"stargazers_count":21,"watchers_count":21,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":3,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/118"},"html":{"href":"https://github.com/mongodb/stitch-ios-sdk/pull/118"},"issue":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/118"},"comments":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/stitch-ios-sdk/statuses/ecdb7494bff186813a84eca8c623e6fcbbe51354"}},"author_association":"CONTRIBUTOR"}} | {
"id": 93444591,
"name": "mongodb/stitch-ios-sdk",
"url": "https://api.github.com/repos/mongodb/stitch-ios-sdk"
} | {
"id": 4356928,
"login": "jsflax",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4356928?",
"url": "https://api.github.com/users/jsflax"
} | {
"id": 45120,
"login": "mongodb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45120?",
"url": "https://api.github.com/orgs/mongodb"
} | 2018-12-13T21:17:51 | 8751119398 | {"actor":{"display_login":"jsflax"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/194025399","pull_request_review_id":127121164,"id":194025399,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDAyNTM5OQ==","diff_hunk":"@@ -19,7 +19,7 @@\n \n package com.cloud.upgrade.dao;\n \n-import java.io.InputStream;\n+import java.io.*;","path":"engine/schema/src/com/cloud/upgrade/dao/Upgrade41100to41110.java","position":5,"original_position":5,"commit_id":"384bce1a97dd03c2297acd5dbada7bfaa3766074","original_commit_id":"384bce1a97dd03c2297acd5dbada7bfaa3766074","user":{"login":"DaanHoogland","id":2486961,"node_id":"MDQ6VXNlcjI0ODY5NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"body":"f(^)%$^$","created_at":"2018-06-08T11:11:44Z","updated_at":"2018-06-08T11:11:44Z","html_url":"https://github.com/apache/cloudstack/pull/2699#discussion_r194025399","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/2699","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/194025399"},"html":{"href":"https://github.com/apache/cloudstack/pull/2699#discussion_r194025399"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2699"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/2699","id":193239158,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMjM5MTU4","html_url":"https://github.com/apache/cloudstack/pull/2699","diff_url":"https://github.com/apache/cloudstack/pull/2699.diff","patch_url":"https://github.com/apache/cloudstack/pull/2699.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/2699","number":2699,"state":"open","locked":false,"title":"remove old config artifacts from update path","user":{"login":"DaanHoogland","id":2486961,"node_id":"MDQ6VXNlcjI0ODY5NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"body":"## Description\r\n<!--- Describe your changes in detail -->\r\n\r\n<!-- For new features, provide link to FS, dev ML discussion etc. -->\r\n<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Enhancement (improves an existing feature and functionality)\r\n- [x] Cleanup (Code refactoring and cleanup, that may add test cases)\r\n\r\n## GitHub Issue/PRs\r\n<!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->\r\n<!-- When \"Fixes: #<id>\" is specified, the issue/PR will automatically be closed when this PR gets merged -->\r\n<!-- For addressing multiple issues/PRs, use multiple \"Fixes: #<id>\" -->\r\n\r\nFixes: #2644\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## How Has This Been Tested?\r\n\r\n<!-- Please describe in detail how you tested your changes. -->\r\n<!-- Include details of your testing environment, and the tests you ran to -->\r\n<!-- see how your change affects other areas of the code, etc. -->\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\nTesting\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All relevant new and existing integration tests have passed.\r\n- [ ] A full integration testsuite with all test that can run on my environment has passed.\r\n\r\n","created_at":"2018-06-07T08:21:09Z","updated_at":"2018-06-08T11:11:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b7d637998c6cec6dacbd1567971331d709a1487","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rafaelweingartner","id":4129005,"node_id":"MDQ6VXNlcjQxMjkwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/4129005?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelweingartner","html_url":"https://github.com/rafaelweingartner","followers_url":"https://api.github.com/users/rafaelweingartner/followers","following_url":"https://api.github.com/users/rafaelweingartner/following{/other_user}","gists_url":"https://api.github.com/users/rafaelweingartner/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelweingartner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelweingartner/subscriptions","organizations_url":"https://api.github.com/users/rafaelweingartner/orgs","repos_url":"https://api.github.com/users/rafaelweingartner/repos","events_url":"https://api.github.com/users/rafaelweingartner/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelweingartner/received_events","type":"User","site_admin":false},{"login":"PaulAngus","id":4810220,"node_id":"MDQ6VXNlcjQ4MTAyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4810220?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulAngus","html_url":"https://github.com/PaulAngus","followers_url":"https://api.github.com/users/PaulAngus/followers","following_url":"https://api.github.com/users/PaulAngus/following{/other_user}","gists_url":"https://api.github.com/users/PaulAngus/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulAngus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulAngus/subscriptions","organizations_url":"https://api.github.com/users/PaulAngus/orgs","repos_url":"https://api.github.com/users/PaulAngus/repos","events_url":"https://api.github.com/users/PaulAngus/events{/privacy}","received_events_url":"https://api.github.com/users/PaulAngus/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/apache/cloudstack/milestones/5","html_url":"https://github.com/apache/cloudstack/milestone/5","labels_url":"https://api.github.com/repos/apache/cloudstack/milestones/5/labels","id":3033298,"node_id":"MDk6TWlsZXN0b25lMzAzMzI5OA==","number":5,"title":"4.11.1.0","description":"Milestone covering PRs for the next 4.11.1.0 release. All PRs using this milestone should send PR against the 4.11 branch.","creator":{"login":"DaanHoogland","id":2486961,"node_id":"MDQ6VXNlcjI0ODY5NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":130,"state":"open","created_at":"2018-01-13T20:06:17Z","updated_at":"2018-06-08T09:26:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/2699/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/2699/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/2699/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/384bce1a97dd03c2297acd5dbada7bfaa3766074","head":{"label":"shapeblue:ldapConfigs","ref":"ldapConfigs","sha":"384bce1a97dd03c2297acd5dbada7bfaa3766074","user":{"login":"shapeblue","id":6001764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDE3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6001764?v=4","gravatar_id":"","url":"https://api.github.com/users/shapeblue","html_url":"https://github.com/shapeblue","followers_url":"https://api.github.com/users/shapeblue/followers","following_url":"https://api.github.com/users/shapeblue/following{/other_user}","gists_url":"https://api.github.com/users/shapeblue/gists{/gist_id}","starred_url":"https://api.github.com/users/shapeblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapeblue/subscriptions","organizations_url":"https://api.github.com/users/shapeblue/orgs","repos_url":"https://api.github.com/users/shapeblue/repos","events_url":"https://api.github.com/users/shapeblue/events{/privacy}","received_events_url":"https://api.github.com/users/shapeblue/received_events","type":"Organization","site_admin":false},"repo":{"id":35481491,"node_id":"MDEwOlJlcG9zaXRvcnkzNTQ4MTQ5MQ==","name":"cloudstack","full_name":"shapeblue/cloudstack","owner":{"login":"shapeblue","id":6001764,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDE3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6001764?v=4","gravatar_id":"","url":"https://api.github.com/users/shapeblue","html_url":"https://github.com/shapeblue","followers_url":"https://api.github.com/users/shapeblue/followers","following_url":"https://api.github.com/users/shapeblue/following{/other_user}","gists_url":"https://api.github.com/users/shapeblue/gists{/gist_id}","starred_url":"https://api.github.com/users/shapeblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapeblue/subscriptions","organizations_url":"https://api.github.com/users/shapeblue/orgs","repos_url":"https://api.github.com/users/shapeblue/repos","events_url":"https://api.github.com/users/shapeblue/events{/privacy}","received_events_url":"https://api.github.com/users/shapeblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shapeblue/cloudstack","description":"The upstream repository is at http://github.com/apache/cloudstack. This is ShapeBlue's support/patch branches and Apache CloudStack™ backup","fork":true,"url":"https://api.github.com/repos/shapeblue/cloudstack","forks_url":"https://api.github.com/repos/shapeblue/cloudstack/forks","keys_url":"https://api.github.com/repos/shapeblue/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shapeblue/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shapeblue/cloudstack/teams","hooks_url":"https://api.github.com/repos/shapeblue/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/shapeblue/cloudstack/events","assignees_url":"https://api.github.com/repos/shapeblue/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/shapeblue/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/shapeblue/cloudstack/tags","blobs_url":"https://api.github.com/repos/shapeblue/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shapeblue/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shapeblue/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/shapeblue/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shapeblue/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/shapeblue/cloudstack/languages","stargazers_url":"https://api.github.com/repos/shapeblue/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/shapeblue/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/shapeblue/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/shapeblue/cloudstack/subscription","commits_url":"https://api.github.com/repos/shapeblue/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/shapeblue/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/shapeblue/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/shapeblue/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/shapeblue/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shapeblue/cloudstack/merges","archive_url":"https://api.github.com/repos/shapeblue/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shapeblue/cloudstack/downloads","issues_url":"https://api.github.com/repos/shapeblue/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/shapeblue/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/shapeblue/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/shapeblue/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shapeblue/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/shapeblue/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/shapeblue/cloudstack/deployments","created_at":"2015-05-12T10:22:21Z","updated_at":"2018-06-08T08:18:06Z","pushed_at":"2018-06-08T10:55:26Z","git_url":"git://github.com/shapeblue/cloudstack.git","ssh_url":"[email protected]:shapeblue/cloudstack.git","clone_url":"https://github.com/shapeblue/cloudstack.git","svn_url":"https://github.com/shapeblue/cloudstack","homepage":"http://shapeblue.com/packages","size":538671,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"apache:4.11","ref":"4.11","sha":"d67af8661bc11d98af4da502adb44810e8467667","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"node_id":"MDEwOlJlcG9zaXRvcnk5NzU5NDQ4","name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cloudstack/deployments","created_at":"2013-04-29T22:27:12Z","updated_at":"2018-06-08T08:16:13Z","pushed_at":"2018-06-08T10:55:28Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"[email protected]:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":524138,"stargazers_count":576,"watchers_count":576,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":637,"mirror_url":null,"archived":false,"open_issues_count":131,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":637,"open_issues":131,"watchers":576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2699"},"html":{"href":"https://github.com/apache/cloudstack/pull/2699"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/2699"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/2699/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2699/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2699/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/384bce1a97dd03c2297acd5dbada7bfaa3766074"}},"author_association":"CONTRIBUTOR"}} | {
"id": 9759448,
"name": "apache/cloudstack",
"url": "https://api.github.com/repos/apache/cloudstack"
} | {
"id": 2486961,
"login": "DaanHoogland",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2486961?",
"url": "https://api.github.com/users/DaanHoogland"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-06-08T11:11:44 | 7796334000 | {"actor":{"display_login":"DaanHoogland"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/176068333","pull_request_review_id":105704608,"id":176068333,"diff_hunk":"@@ -236,7 +236,15 @@ protected[core] object WhiskWebActionsApi extends Directives {\n // the following throws an exception if the code is\n // not a whole number or a valid code\n StatusCode.int2StatusCode(c.toIntExact)\n-\n+ case JsString(c) =>\n+ try {\n+ val intCode = c.toInt\n+ // contrast to JsNumber, already parse the string to Int instead of BigInt.\n+ StatusCode.int2StatusCode(intCode)\n+ } catch {\n+ // rethrow NumberFormatException to an unified exception\n+ case e: NumberFormatException => throw new Throwable(\"Illegal code\")","path":"core/controller/src/main/scala/whisk/core/controller/WebActions.scala","position":12,"original_position":12,"commit_id":"52e901d1aa22f3b74ebcf1cdcd072b8f0112dce9","original_commit_id":"52e901d1aa22f3b74ebcf1cdcd072b8f0112dce9","user":{"login":"rabbah","id":4959922,"avatar_url":"https://avatars3.githubusercontent.com/u/4959922?v=4","gravatar_id":"","url":"https://api.github.com/users/rabbah","html_url":"https://github.com/rabbah","followers_url":"https://api.github.com/users/rabbah/followers","following_url":"https://api.github.com/users/rabbah/following{/other_user}","gists_url":"https://api.github.com/users/rabbah/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbah/subscriptions","organizations_url":"https://api.github.com/users/rabbah/orgs","repos_url":"https://api.github.com/users/rabbah/repos","events_url":"https://api.github.com/users/rabbah/events{/privacy}","received_events_url":"https://api.github.com/users/rabbah/received_events","type":"User","site_admin":false},"body":"s/code/status code/","created_at":"2018-03-21T12:46:46Z","updated_at":"2018-03-21T12:47:43Z","html_url":"https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176068333","pull_request_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3473","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/176068333"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176068333"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3473"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3473","id":176392395,"html_url":"https://github.com/apache/incubator-openwhisk/pull/3473","diff_url":"https://github.com/apache/incubator-openwhisk/pull/3473.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/3473.patch","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3473","number":3473,"state":"open","locked":false,"title":"Support string based status code from actions.","user":{"login":"tz70s","id":13405580,"avatar_url":"https://avatars2.githubusercontent.com/u/13405580?v=4","gravatar_id":"","url":"https://api.github.com/users/tz70s","html_url":"https://github.com/tz70s","followers_url":"https://api.github.com/users/tz70s/followers","following_url":"https://api.github.com/users/tz70s/following{/other_user}","gists_url":"https://api.github.com/users/tz70s/gists{/gist_id}","starred_url":"https://api.github.com/users/tz70s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tz70s/subscriptions","organizations_url":"https://api.github.com/users/tz70s/orgs","repos_url":"https://api.github.com/users/tz70s/repos","events_url":"https://api.github.com/users/tz70s/events{/privacy}","received_events_url":"https://api.github.com/users/tz70s/received_events","type":"User","site_admin":false},"body":"Add an additional option to parse status code from string to int, throws\r\nout illegal code if parsing failed. Also, add a relevant test code.\r\n\r\nSigned-off-by: Tzu-Chiao Yeh <[email protected]>\r\n\r\n\r\n<!--- Provide a concise summary of your changes in the Title -->\r\n\r\n## Description\r\n<!--- Provide a detailed description of your changes. -->\r\n<!--- Include details of what problem you are solving and how your changes are tested. -->\r\n\r\nRefer to #2971, changes support status code written in string from an action.\r\n\r\n## Related issue and scope\r\n<!--- Please include a link to a related issue if there is one. -->\r\n- [x] Opened issue to propose and discuss this change (#2971 )\r\n\r\n## My changes affect the following components\r\n<!--- Select below all system components are affected by your change. -->\r\n<!--- Enter an `x` in all applicable boxes. -->\r\n- [ ] API\r\n- [x] Controller\r\n- [ ] Message Bus (e.g., Kafka)\r\n- [ ] Loadbalancer\r\n- [ ] Invoker\r\n- [ ] Intrinsic actions (e.g., sequences, conductors)\r\n- [ ] Data stores (e.g., CouchDB)\r\n- [ ] Tests\r\n- [ ] Deployment\r\n- [ ] CLI\r\n- [ ] General tooling\r\n- [ ] Documentation\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (generally a non-breaking change which closes an issue).\r\n- [x] Enhancement or new feature (adds new functionality).\r\n- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).\r\n\r\n## Checklist:\r\n<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->\r\n\r\n- [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).\r\n- [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).\r\n- [x] I added tests to cover my changes.\r\n- [ ] My changes require further changes to the documentation.\r\n- [ ] I updated the documentation where necessary.\r\n\r\n","created_at":"2018-03-21T06:40:20Z","updated_at":"2018-03-21T12:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"191e6e6edf8f09034ef162f7a5c77a45ced5adf3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3473/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3473/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3473/comments","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/52e901d1aa22f3b74ebcf1cdcd072b8f0112dce9","head":{"label":"tz70s:string-status-code-support","ref":"string-status-code-support","sha":"52e901d1aa22f3b74ebcf1cdcd072b8f0112dce9","user":{"login":"tz70s","id":13405580,"avatar_url":"https://avatars2.githubusercontent.com/u/13405580?v=4","gravatar_id":"","url":"https://api.github.com/users/tz70s","html_url":"https://github.com/tz70s","followers_url":"https://api.github.com/users/tz70s/followers","following_url":"https://api.github.com/users/tz70s/following{/other_user}","gists_url":"https://api.github.com/users/tz70s/gists{/gist_id}","starred_url":"https://api.github.com/users/tz70s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tz70s/subscriptions","organizations_url":"https://api.github.com/users/tz70s/orgs","repos_url":"https://api.github.com/users/tz70s/repos","events_url":"https://api.github.com/users/tz70s/events{/privacy}","received_events_url":"https://api.github.com/users/tz70s/received_events","type":"User","site_admin":false},"repo":{"id":125305424,"name":"incubator-openwhisk","full_name":"tz70s/incubator-openwhisk","owner":{"login":"tz70s","id":13405580,"avatar_url":"https://avatars2.githubusercontent.com/u/13405580?v=4","gravatar_id":"","url":"https://api.github.com/users/tz70s","html_url":"https://github.com/tz70s","followers_url":"https://api.github.com/users/tz70s/followers","following_url":"https://api.github.com/users/tz70s/following{/other_user}","gists_url":"https://api.github.com/users/tz70s/gists{/gist_id}","starred_url":"https://api.github.com/users/tz70s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tz70s/subscriptions","organizations_url":"https://api.github.com/users/tz70s/orgs","repos_url":"https://api.github.com/users/tz70s/repos","events_url":"https://api.github.com/users/tz70s/events{/privacy}","received_events_url":"https://api.github.com/users/tz70s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tz70s/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":true,"url":"https://api.github.com/repos/tz70s/incubator-openwhisk","forks_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/tz70s/incubator-openwhisk/deployments","created_at":"2018-03-15T03:08:36Z","updated_at":"2018-03-21T03:54:13Z","pushed_at":"2018-03-21T06:35:10Z","git_url":"git://github.com/tz70s/incubator-openwhisk.git","ssh_url":"[email protected]:tz70s/incubator-openwhisk.git","clone_url":"https://github.com/tz70s/incubator-openwhisk.git","svn_url":"https://github.com/tz70s/incubator-openwhisk","homepage":"http://openwhisk.org","size":60642,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c127f62c6ab5b2e9dc4fc3722ff50e94bb4dfcc1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":52039373,"name":"incubator-openwhisk","full_name":"apache/incubator-openwhisk","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":false,"url":"https://api.github.com/repos/apache/incubator-openwhisk","forks_url":"https://api.github.com/repos/apache/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/apache/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/apache/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/apache/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/apache/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-openwhisk/deployments","created_at":"2016-02-18T21:16:19Z","updated_at":"2018-03-21T12:32:24Z","pushed_at":"2018-03-21T12:32:12Z","git_url":"git://github.com/apache/incubator-openwhisk.git","ssh_url":"[email protected]:apache/incubator-openwhisk.git","clone_url":"https://github.com/apache/incubator-openwhisk.git","svn_url":"https://github.com/apache/incubator-openwhisk","homepage":"http://openwhisk.org","size":60642,"stargazers_count":2983,"watchers_count":2983,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":560,"mirror_url":null,"archived":false,"open_issues_count":380,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":560,"open_issues":380,"watchers":2983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3473"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/3473"},"issue":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3473"},"comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/3473/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3473/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/3473/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/52e901d1aa22f3b74ebcf1cdcd072b8f0112dce9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 52039373,
"name": "apache/incubator-openwhisk",
"url": "https://api.github.com/repos/apache/incubator-openwhisk"
} | {
"id": 4959922,
"login": "rabbah",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4959922?",
"url": "https://api.github.com/users/rabbah"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-03-21T12:46:46 | 7412610656 | {"actor":{"display_login":"rabbah"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/220642544","pull_request_review_id":159097146,"id":220642544,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDY0MjU0NA==","diff_hunk":"@@ -339,12 +338,26 @@ private static Request createRequest(String targetAddress, String targetUrl, Htt\n \t\t\t.thenComposeAsync(\n \t\t\t\tchannel -> {\n \t\t\t\t\tClientHandler handler = channel.pipeline().get(ClientHandler.class);\n-\t\t\t\t\tCompletableFuture<JsonResponse> future = handler.getJsonFuture();\n+\n+\t\t\t\t\tCompletableFuture<JsonResponse> future;\n+\t\t\t\t\tboolean success = false;\n+\n \t\t\t\t\ttry {\n-\t\t\t\t\t\thttpRequest.writeTo(channel);\n+\t\t\t\t\t\tif (handler == null) {","path":"flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java","position":150,"original_position":19,"commit_id":"07bcbc715bb755adf31d123a1b9f0a90154be99e","original_commit_id":"07bcbc715bb755adf31d123a1b9f0a90154be99e","user":{"login":"zentol","id":5725237,"node_id":"MDQ6VXNlcjU3MjUyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5725237?v=4","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"body":"Do we know when/why this happens?","created_at":"2018-09-26T16:51:07Z","updated_at":"2018-09-26T16:54:24Z","html_url":"https://github.com/apache/flink/pull/6763#discussion_r220642544","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6763","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/220642544"},"html":{"href":"https://github.com/apache/flink/pull/6763#discussion_r220642544"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6763"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6763","id":218217914,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MjE3OTE0","html_url":"https://github.com/apache/flink/pull/6763","diff_url":"https://github.com/apache/flink/pull/6763.diff","patch_url":"https://github.com/apache/flink/pull/6763.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6763","number":6763,"state":"open","locked":false,"title":"[FLINK-10415] Fail response future if connection closes in RestClient","user":{"login":"tillrohrmann","id":5756858,"node_id":"MDQ6VXNlcjU3NTY4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nIf the RestClient detects that a connection was closed (channel became inactive), then\r\nit now fails the json response future with a ConnectionClosedException.\r\n\r\n## Verifying this change\r\n\r\n- Added `RestClientTest#testConnectionClosedHandling` and `RestClientTest#testRestClientClosedHandling`\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n - Dependencies (does it add or upgrade a dependency): (no)\r\n - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n - The serializers: (no)\r\n - The runtime per-record code paths (performance sensitive): (no)\r\n - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n - Does this pull request introduce a new feature? (no)\r\n - If yes, how is the feature documented? (not applicable)\r\n","created_at":"2018-09-26T07:44:04Z","updated_at":"2018-09-26T16:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85dc8a80b862d9e3069380ffcc112f0eea377ad7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6763/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6763/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6763/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/07bcbc715bb755adf31d123a1b9f0a90154be99e","head":{"label":"tillrohrmann:restClientShutDown","ref":"restClientShutDown","sha":"07bcbc715bb755adf31d123a1b9f0a90154be99e","user":{"login":"tillrohrmann","id":5756858,"node_id":"MDQ6VXNlcjU3NTY4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"repo":{"id":20681108,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY4MTEwOA==","name":"flink","full_name":"tillrohrmann/flink","private":false,"owner":{"login":"tillrohrmann","id":5756858,"node_id":"MDQ6VXNlcjU3NTY4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tillrohrmann/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/tillrohrmann/flink","forks_url":"https://api.github.com/repos/tillrohrmann/flink/forks","keys_url":"https://api.github.com/repos/tillrohrmann/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tillrohrmann/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tillrohrmann/flink/teams","hooks_url":"https://api.github.com/repos/tillrohrmann/flink/hooks","issue_events_url":"https://api.github.com/repos/tillrohrmann/flink/issues/events{/number}","events_url":"https://api.github.com/repos/tillrohrmann/flink/events","assignees_url":"https://api.github.com/repos/tillrohrmann/flink/assignees{/user}","branches_url":"https://api.github.com/repos/tillrohrmann/flink/branches{/branch}","tags_url":"https://api.github.com/repos/tillrohrmann/flink/tags","blobs_url":"https://api.github.com/repos/tillrohrmann/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tillrohrmann/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tillrohrmann/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/tillrohrmann/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tillrohrmann/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/tillrohrmann/flink/languages","stargazers_url":"https://api.github.com/repos/tillrohrmann/flink/stargazers","contributors_url":"https://api.github.com/repos/tillrohrmann/flink/contributors","subscribers_url":"https://api.github.com/repos/tillrohrmann/flink/subscribers","subscription_url":"https://api.github.com/repos/tillrohrmann/flink/subscription","commits_url":"https://api.github.com/repos/tillrohrmann/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/tillrohrmann/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/tillrohrmann/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/tillrohrmann/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/tillrohrmann/flink/contents/{+path}","compare_url":"https://api.github.com/repos/tillrohrmann/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tillrohrmann/flink/merges","archive_url":"https://api.github.com/repos/tillrohrmann/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tillrohrmann/flink/downloads","issues_url":"https://api.github.com/repos/tillrohrmann/flink/issues{/number}","pulls_url":"https://api.github.com/repos/tillrohrmann/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/tillrohrmann/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/tillrohrmann/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tillrohrmann/flink/labels{/name}","releases_url":"https://api.github.com/repos/tillrohrmann/flink/releases{/id}","deployments_url":"https://api.github.com/repos/tillrohrmann/flink/deployments","created_at":"2014-06-10T10:19:35Z","updated_at":"2018-07-07T09:12:11Z","pushed_at":"2018-09-26T15:35:16Z","git_url":"git://github.com/tillrohrmann/flink.git","ssh_url":"[email protected]:tillrohrmann/flink.git","clone_url":"https://github.com/tillrohrmann/flink.git","svn_url":"https://github.com/tillrohrmann/flink","homepage":null,"size":160839,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a36d1999f743d00c4fac8fdf61ad85a4b5d5f3bc","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-09-26T16:35:12Z","pushed_at":"2018-09-26T15:35:18Z","git_url":"git://github.com/apache/flink.git","ssh_url":"[email protected]:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":165486,"stargazers_count":4474,"watchers_count":4474,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2916,"mirror_url":null,"archived":false,"open_issues_count":407,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2916,"open_issues":407,"watchers":4474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6763"},"html":{"href":"https://github.com/apache/flink/pull/6763"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6763"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6763/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6763/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6763/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/07bcbc715bb755adf31d123a1b9f0a90154be99e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 20587599,
"name": "apache/flink",
"url": "https://api.github.com/repos/apache/flink"
} | {
"id": 5725237,
"login": "zentol",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5725237?",
"url": "https://api.github.com/users/zentol"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-09-26T16:51:07 | 8326224101 | {"actor":{"display_login":"zentol"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/234815017","pull_request_review_id":176514997,"id":234815017,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDgxNTAxNw==","diff_hunk":"@@ -0,0 +1,244 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license\n+ * agreements. See the NOTICE file distributed with this work for additional information regarding\n+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance with the License. You may obtain a\n+ * copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package org.apache.geode.cache.configuration;\n+\n+import java.util.List;\n+import java.util.Optional;\n+import java.util.stream.Collectors;\n+\n+import org.apache.geode.management.internal.cli.functions.RegionFunctionArgs;","path":"geode-core/src/main/java/org/apache/geode/cache/configuration/RegionConfigFactory.java","position":21,"original_position":21,"commit_id":"41951032b9e4df815b59d3bbc22895272bcef490","original_commit_id":"41951032b9e4df815b59d3bbc22895272bcef490","user":{"login":"jinmeiliao","id":15638418,"node_id":"MDQ6VXNlcjE1NjM4NDE4","avatar_url":"https://avatars1.githubusercontent.com/u/15638418?v=4","gravatar_id":"","url":"https://api.github.com/users/jinmeiliao","html_url":"https://github.com/jinmeiliao","followers_url":"https://api.github.com/users/jinmeiliao/followers","following_url":"https://api.github.com/users/jinmeiliao/following{/other_user}","gists_url":"https://api.github.com/users/jinmeiliao/gists{/gist_id}","starred_url":"https://api.github.com/users/jinmeiliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinmeiliao/subscriptions","organizations_url":"https://api.github.com/users/jinmeiliao/orgs","repos_url":"https://api.github.com/users/jinmeiliao/repos","events_url":"https://api.github.com/users/jinmeiliao/events{/privacy}","received_events_url":"https://api.github.com/users/jinmeiliao/received_events","type":"User","site_admin":false},"body":"Generally, I would like to see us moving away from using RegionFunctionArgs. In the command, we should start creating the RegionConfig object directly from the command arguments. This RegionFunctionArgs is there before the config objects are available. If we can completely get rid of it, that would be great.\r\n\r\nIf not, this RegionConfigFactory does not belong in the config package either. It's more used in the command to convert RegionFunctionArgs to RegionConfig, the rest of the world should only work with RegionConfig. Only the command need to be aware of this \"factory\" or \"converter\".","created_at":"2018-11-19T23:02:37Z","updated_at":"2018-11-19T23:02:59Z","html_url":"https://github.com/apache/geode/pull/2875#discussion_r234815017","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/2875","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/234815017"},"html":{"href":"https://github.com/apache/geode/pull/2875#discussion_r234815017"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/2875"}}},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/2875","id":232070857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDcwODU3","html_url":"https://github.com/apache/geode/pull/2875","diff_url":"https://github.com/apache/geode/pull/2875.diff","patch_url":"https://github.com/apache/geode/pull/2875.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/2875","number":2875,"state":"open","locked":false,"title":"GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand","user":{"login":"aditya87","id":770739,"node_id":"MDQ6VXNlcjc3MDczOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/770739?v=4","gravatar_id":"","url":"https://api.github.com/users/aditya87","html_url":"https://github.com/aditya87","followers_url":"https://api.github.com/users/aditya87/followers","following_url":"https://api.github.com/users/aditya87/following{/other_user}","gists_url":"https://api.github.com/users/aditya87/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya87/subscriptions","organizations_url":"https://api.github.com/users/aditya87/orgs","repos_url":"https://api.github.com/users/aditya87/repos","events_url":"https://api.github.com/users/aditya87/events{/privacy}","received_events_url":"https://api.github.com/users/aditya87/received_events","type":"User","site_admin":false},"body":"- Store config via generating a RegionConfig object rather than an XML\r\nentity\r\n- Store config via generating a RegionConfig object rather than an XML entity\r\n- For clarity, rename getters that return a \"Boolean\" object rather than a boolean primitive as prefixed by \"get\" rather than \"is\". This communicates nullability to the caller. A bit of history here -- this code was originally generated by Lombok (https://projectlombok.org/), which we subsequently backed out. But we like the clarity of this pattern.\r\n- Create a \"RegionConfigFactory\" to generate a RegionConfig object from RegionFunctionArgs.\r\n- Reduce null-related side effects in some setters in RegionFunctionArgs.\r\n\r\nSigned-off-by: Peter Tran <[email protected]>\r\nSigned-off-by: Aditya Anchuri <[email protected]>\r\nSigned-off-by: Jens Deppe <[email protected]>\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [X] Is your initial contribution a single, squashed commit?\r\n\r\n- [X] Does `gradlew build` run cleanly?\r\n\r\n- [X] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to [email protected].\r\n","created_at":"2018-11-19T18:29:37Z","updated_at":"2018-11-19T23:02:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5767d0a3f6375c87372516dba9c83b0f27afe41f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/2875/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/2875/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/2875/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/41951032b9e4df815b59d3bbc22895272bcef490","head":{"label":"aditya87:geode-5971-createregion","ref":"geode-5971-createregion","sha":"41951032b9e4df815b59d3bbc22895272bcef490","user":{"login":"aditya87","id":770739,"node_id":"MDQ6VXNlcjc3MDczOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/770739?v=4","gravatar_id":"","url":"https://api.github.com/users/aditya87","html_url":"https://github.com/aditya87","followers_url":"https://api.github.com/users/aditya87/followers","following_url":"https://api.github.com/users/aditya87/following{/other_user}","gists_url":"https://api.github.com/users/aditya87/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya87/subscriptions","organizations_url":"https://api.github.com/users/aditya87/orgs","repos_url":"https://api.github.com/users/aditya87/repos","events_url":"https://api.github.com/users/aditya87/events{/privacy}","received_events_url":"https://api.github.com/users/aditya87/received_events","type":"User","site_admin":false},"repo":{"id":138437619,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0Mzc2MTk=","name":"geode","full_name":"aditya87/geode","private":false,"owner":{"login":"aditya87","id":770739,"node_id":"MDQ6VXNlcjc3MDczOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/770739?v=4","gravatar_id":"","url":"https://api.github.com/users/aditya87","html_url":"https://github.com/aditya87","followers_url":"https://api.github.com/users/aditya87/followers","following_url":"https://api.github.com/users/aditya87/following{/other_user}","gists_url":"https://api.github.com/users/aditya87/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya87/subscriptions","organizations_url":"https://api.github.com/users/aditya87/orgs","repos_url":"https://api.github.com/users/aditya87/repos","events_url":"https://api.github.com/users/aditya87/events{/privacy}","received_events_url":"https://api.github.com/users/aditya87/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aditya87/geode","description":"Apache Geode","fork":true,"url":"https://api.github.com/repos/aditya87/geode","forks_url":"https://api.github.com/repos/aditya87/geode/forks","keys_url":"https://api.github.com/repos/aditya87/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aditya87/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aditya87/geode/teams","hooks_url":"https://api.github.com/repos/aditya87/geode/hooks","issue_events_url":"https://api.github.com/repos/aditya87/geode/issues/events{/number}","events_url":"https://api.github.com/repos/aditya87/geode/events","assignees_url":"https://api.github.com/repos/aditya87/geode/assignees{/user}","branches_url":"https://api.github.com/repos/aditya87/geode/branches{/branch}","tags_url":"https://api.github.com/repos/aditya87/geode/tags","blobs_url":"https://api.github.com/repos/aditya87/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aditya87/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aditya87/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/aditya87/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aditya87/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/aditya87/geode/languages","stargazers_url":"https://api.github.com/repos/aditya87/geode/stargazers","contributors_url":"https://api.github.com/repos/aditya87/geode/contributors","subscribers_url":"https://api.github.com/repos/aditya87/geode/subscribers","subscription_url":"https://api.github.com/repos/aditya87/geode/subscription","commits_url":"https://api.github.com/repos/aditya87/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/aditya87/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/aditya87/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/aditya87/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/aditya87/geode/contents/{+path}","compare_url":"https://api.github.com/repos/aditya87/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aditya87/geode/merges","archive_url":"https://api.github.com/repos/aditya87/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aditya87/geode/downloads","issues_url":"https://api.github.com/repos/aditya87/geode/issues{/number}","pulls_url":"https://api.github.com/repos/aditya87/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/aditya87/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/aditya87/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aditya87/geode/labels{/name}","releases_url":"https://api.github.com/repos/aditya87/geode/releases{/id}","deployments_url":"https://api.github.com/repos/aditya87/geode/deployments","created_at":"2018-06-23T22:28:01Z","updated_at":"2018-11-19T18:15:36Z","pushed_at":"2018-11-19T18:27:54Z","git_url":"git://github.com/aditya87/geode.git","ssh_url":"[email protected]:aditya87/geode.git","clone_url":"https://github.com/aditya87/geode.git","svn_url":"https://github.com/aditya87/geode","homepage":"","size":165947,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"333cde15e7734bdbf8d760ff1d14d33f3765da90","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgzOTM4Mw==","name":"geode","full_name":"apache/geode","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2018-11-19T21:34:59Z","pushed_at":"2018-11-19T23:02:50Z","git_url":"git://github.com/apache/geode.git","ssh_url":"[email protected]:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":165613,"stargazers_count":1378,"watchers_count":1378,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":475,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":475,"open_issues":36,"watchers":1378,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/2875"},"html":{"href":"https://github.com/apache/geode/pull/2875"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/2875"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/2875/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/2875/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/2875/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/41951032b9e4df815b59d3bbc22895272bcef490"}},"author_association":"CONTRIBUTOR"}} | {
"id": 34839383,
"name": "apache/geode",
"url": "https://api.github.com/repos/apache/geode"
} | {
"id": 15638418,
"login": "jinmeiliao",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15638418?",
"url": "https://api.github.com/users/jinmeiliao"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-11-19T23:02:37 | 8616182238 | {"actor":{"display_login":"jinmeiliao"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/220564387","pull_request_review_id":158998788,"id":220564387,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDU2NDM4Nw==","diff_hunk":"@@ -637,19 +637,19 @@ Table result = left.join(right)\n {% highlight java %}\n // register function\n TableFunction<String> split = new MySplitUDTF();\n-tEnv.registerFunction(\"split\", split);\n+tableEnv.registerFunction(\"split\", split);\n \n // join\n Table orders = tableEnv.scan(\"Orders\");\n Table result = orders\n- .join(new Table(tEnv, \"split(c)\").as(\"s\", \"t\", \"v\"))\n+ .join(new Table(tableEnv, \"split(c)\").as(\"s\", \"t\", \"v\"))\n .select(\"a, b, s, t, v\");\n {% endhighlight %}\n </td>\n </tr>\n <tr>\n- \t<td>\n- <strong>TableFunction Left Outer Join</strong><br>\n+ <td>\n+ <strong>Left Outer Join with User Defined Table Functions (UDTF)</strong><br>","path":"docs/dev/table/tableApi.md","position":31,"original_position":31,"commit_id":"6954315375bc0b69935f7bac686f164803bf44b2","original_commit_id":"6954315375bc0b69935f7bac686f164803bf44b2","user":{"login":"fhueske","id":2388347,"node_id":"MDQ6VXNlcjIzODgzNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/2388347?v=4","gravatar_id":"","url":"https://api.github.com/users/fhueske","html_url":"https://github.com/fhueske","followers_url":"https://api.github.com/users/fhueske/followers","following_url":"https://api.github.com/users/fhueske/following{/other_user}","gists_url":"https://api.github.com/users/fhueske/gists{/gist_id}","starred_url":"https://api.github.com/users/fhueske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhueske/subscriptions","organizations_url":"https://api.github.com/users/fhueske/orgs","repos_url":"https://api.github.com/users/fhueske/repos","events_url":"https://api.github.com/users/fhueske/events{/privacy}","received_events_url":"https://api.github.com/users/fhueske/received_events","type":"User","site_admin":false},"body":"`User-Defined`","created_at":"2018-09-26T13:36:40Z","updated_at":"2018-09-26T13:43:00Z","html_url":"https://github.com/apache/flink/pull/6744#discussion_r220564387","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6744","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/220564387"},"html":{"href":"https://github.com/apache/flink/pull/6744#discussion_r220564387"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6744"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6744","id":217685314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Njg1MzE0","html_url":"https://github.com/apache/flink/pull/6744","diff_url":"https://github.com/apache/flink/pull/6744.diff","patch_url":"https://github.com/apache/flink/pull/6744.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6744","number":6744,"state":"open","locked":false,"title":"[FLINK-10379][docs,table] Fix Table Function docs","user":{"login":"pnowojski","id":8957547,"node_id":"MDQ6VXNlcjg5NTc1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8957547?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"body":"This is a simple documentation fix for Java Table API.\r\n\r\nOld syntax of joining with Table Functions in Java Table API:\r\n```\r\n// Register the function.\r\ntableEnv.registerFunction(\"split\", new Split(\"#\"));\r\n\r\nmyTable.join(\"split(a) as (word, length)\");\r\n```\r\nis no longer supported and this the reason why the documentation needed to be updated. Currently supported syntax is:\r\n```\r\norders.join(new Table(tEnv, \"split(a)\");\r\n```","created_at":"2018-09-24T14:55:31Z","updated_at":"2018-09-26T13:43:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b451603a90ba95dd6c7fc8e7824451e340c2771f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"twalthr","id":5746567,"node_id":"MDQ6VXNlcjU3NDY1Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/5746567?v=4","gravatar_id":"","url":"https://api.github.com/users/twalthr","html_url":"https://github.com/twalthr","followers_url":"https://api.github.com/users/twalthr/followers","following_url":"https://api.github.com/users/twalthr/following{/other_user}","gists_url":"https://api.github.com/users/twalthr/gists{/gist_id}","starred_url":"https://api.github.com/users/twalthr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalthr/subscriptions","organizations_url":"https://api.github.com/users/twalthr/orgs","repos_url":"https://api.github.com/users/twalthr/repos","events_url":"https://api.github.com/users/twalthr/events{/privacy}","received_events_url":"https://api.github.com/users/twalthr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6744/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6744/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6744/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/6954315375bc0b69935f7bac686f164803bf44b2","head":{"label":"pnowojski:f10379","ref":"f10379","sha":"6954315375bc0b69935f7bac686f164803bf44b2","user":{"login":"pnowojski","id":8957547,"node_id":"MDQ6VXNlcjg5NTc1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8957547?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"repo":{"id":94091518,"node_id":"MDEwOlJlcG9zaXRvcnk5NDA5MTUxOA==","name":"flink","full_name":"pnowojski/flink","private":false,"owner":{"login":"pnowojski","id":8957547,"node_id":"MDQ6VXNlcjg5NTc1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8957547?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pnowojski/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/pnowojski/flink","forks_url":"https://api.github.com/repos/pnowojski/flink/forks","keys_url":"https://api.github.com/repos/pnowojski/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnowojski/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnowojski/flink/teams","hooks_url":"https://api.github.com/repos/pnowojski/flink/hooks","issue_events_url":"https://api.github.com/repos/pnowojski/flink/issues/events{/number}","events_url":"https://api.github.com/repos/pnowojski/flink/events","assignees_url":"https://api.github.com/repos/pnowojski/flink/assignees{/user}","branches_url":"https://api.github.com/repos/pnowojski/flink/branches{/branch}","tags_url":"https://api.github.com/repos/pnowojski/flink/tags","blobs_url":"https://api.github.com/repos/pnowojski/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnowojski/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnowojski/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnowojski/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnowojski/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/pnowojski/flink/languages","stargazers_url":"https://api.github.com/repos/pnowojski/flink/stargazers","contributors_url":"https://api.github.com/repos/pnowojski/flink/contributors","subscribers_url":"https://api.github.com/repos/pnowojski/flink/subscribers","subscription_url":"https://api.github.com/repos/pnowojski/flink/subscription","commits_url":"https://api.github.com/repos/pnowojski/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnowojski/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnowojski/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnowojski/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnowojski/flink/contents/{+path}","compare_url":"https://api.github.com/repos/pnowojski/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnowojski/flink/merges","archive_url":"https://api.github.com/repos/pnowojski/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnowojski/flink/downloads","issues_url":"https://api.github.com/repos/pnowojski/flink/issues{/number}","pulls_url":"https://api.github.com/repos/pnowojski/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/pnowojski/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/pnowojski/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnowojski/flink/labels{/name}","releases_url":"https://api.github.com/repos/pnowojski/flink/releases{/id}","deployments_url":"https://api.github.com/repos/pnowojski/flink/deployments","created_at":"2017-06-12T12:03:15Z","updated_at":"2017-06-12T12:03:37Z","pushed_at":"2018-09-25T13:51:34Z","git_url":"git://github.com/pnowojski/flink.git","ssh_url":"[email protected]:pnowojski/flink.git","clone_url":"https://github.com/pnowojski/flink.git","svn_url":"https://github.com/pnowojski/flink","homepage":null,"size":162646,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"85f42770ea1c694139ffe84432d0070b20bdef7d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-09-26T12:06:20Z","pushed_at":"2018-09-26T12:59:20Z","git_url":"git://github.com/apache/flink.git","ssh_url":"[email protected]:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":165486,"stargazers_count":4472,"watchers_count":4472,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2915,"mirror_url":null,"archived":false,"open_issues_count":405,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2915,"open_issues":405,"watchers":4472,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6744"},"html":{"href":"https://github.com/apache/flink/pull/6744"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6744"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6744/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6744/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6744/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/6954315375bc0b69935f7bac686f164803bf44b2"}},"author_association":"CONTRIBUTOR"}} | {
"id": 20587599,
"name": "apache/flink",
"url": "https://api.github.com/repos/apache/flink"
} | {
"id": 2388347,
"login": "fhueske",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2388347?",
"url": "https://api.github.com/users/fhueske"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-09-26T13:36:40 | 8324913820 | {"actor":{"display_login":"fhueske"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/200722772","pull_request_review_id":135098975,"id":200722772,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDcyMjc3Mg==","diff_hunk":"@@ -1182,13 +1201,24 @@ public void recoveryAddEntry(ByteBuf entry, WriteCallback cb, Object ctx, byte[]\n }\n }\n \n- public void setExplicitLac(ByteBuf entry, Object ctx, byte[] masterKey)\n+ static ByteBuf createExplicitLACEntry(long ledgerId, ByteBuf explicitLac) {\n+ ByteBuf bb = Unpooled.buffer(8 + 8 + 4 + explicitLac.capacity());","path":"bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java","position":46,"original_position":46,"commit_id":"3859dc7478076432fdd3c41012ee795c81d7f578","original_commit_id":"3859dc7478076432fdd3c41012ee795c81d7f578","user":{"login":"reddycharan","id":13989266,"node_id":"MDQ6VXNlcjEzOTg5MjY2","avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"body":"hmm..i just followed createLedgerFenceEntry approach- https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java#L56","created_at":"2018-07-06T17:36:52Z","updated_at":"2018-07-06T17:36:53Z","html_url":"https://github.com/apache/bookkeeper/pull/1532#discussion_r200722772","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1532","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/200722772"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1532#discussion_r200722772"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1532"}},"in_reply_to_id":199320090},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1532","id":198188569,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTg4NTY5","html_url":"https://github.com/apache/bookkeeper/pull/1532","diff_url":"https://github.com/apache/bookkeeper/pull/1532.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1532.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1532","number":1532,"state":"open","locked":false,"title":"(WIP) ISSUE #1527: Make ExplicitLAC persistent","user":{"login":"reddycharan","id":13989266,"node_id":"MDQ6VXNlcjEzOTg5MjY2","avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"body":"\r\n\r\nDescriptions of the changes in this PR:\r\n\r\nFor persisting explicitLAC, we can follow the\r\nsame approach as followed in persisting\r\nfencing information / stateBits (d69986c)\r\nin FileInfo file and special marker entry\r\nin Journal.\r\n\r\n### Motivation\r\n\r\nExplicitLAC is kept in the memory and it can be lost in bookie reboot.\r\nThough it is an extreme corner case scenario, it can break one of the BK guarantees.\r\n\" If you read once you can always read it\".\r\nIf all the bookies of the Write stripe were rebooted, it can loose its explicitLAC value and the client\r\nwhich was able to read the entry before the reboot, can't read it anymore.\r\n\r\nMaster Issue: #1527\r\n","created_at":"2018-06-29T00:42:14Z","updated_at":"2018-07-06T17:36:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73d47a82e8d0c6b1ba0af9eb58ae8c68541374ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1532/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1532/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1532/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/3859dc7478076432fdd3c41012ee795c81d7f578","head":{"label":"reddycharan:storeexplicitlac","ref":"storeexplicitlac","sha":"3859dc7478076432fdd3c41012ee795c81d7f578","user":{"login":"reddycharan","id":13989266,"node_id":"MDQ6VXNlcjEzOTg5MjY2","avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"repo":{"id":71182574,"node_id":"MDEwOlJlcG9zaXRvcnk3MTE4MjU3NA==","name":"bookkeeper","full_name":"reddycharan/bookkeeper","owner":{"login":"reddycharan","id":13989266,"node_id":"MDQ6VXNlcjEzOTg5MjY2","avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reddycharan/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/reddycharan/bookkeeper","forks_url":"https://api.github.com/repos/reddycharan/bookkeeper/forks","keys_url":"https://api.github.com/repos/reddycharan/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddycharan/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddycharan/bookkeeper/teams","hooks_url":"https://api.github.com/repos/reddycharan/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/reddycharan/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/reddycharan/bookkeeper/events","assignees_url":"https://api.github.com/repos/reddycharan/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/reddycharan/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/reddycharan/bookkeeper/tags","blobs_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddycharan/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/reddycharan/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/reddycharan/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/reddycharan/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/reddycharan/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/reddycharan/bookkeeper/subscription","commits_url":"https://api.github.com/repos/reddycharan/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddycharan/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddycharan/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddycharan/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddycharan/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/reddycharan/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddycharan/bookkeeper/merges","archive_url":"https://api.github.com/repos/reddycharan/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddycharan/bookkeeper/downloads","issues_url":"https://api.github.com/repos/reddycharan/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/reddycharan/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/reddycharan/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/reddycharan/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddycharan/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/reddycharan/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/reddycharan/bookkeeper/deployments","created_at":"2016-10-17T21:25:32Z","updated_at":"2016-10-17T21:25:35Z","pushed_at":"2018-07-05T20:49:06Z","git_url":"git://github.com/reddycharan/bookkeeper.git","ssh_url":"[email protected]:reddycharan/bookkeeper.git","clone_url":"https://github.com/reddycharan/bookkeeper.git","svn_url":"https://github.com/reddycharan/bookkeeper","homepage":null,"size":24615,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e3884801569725283963385a35f63c5d1d8b3880","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1OTU2","name":"bookkeeper","full_name":"apache/bookkeeper","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2018-07-06T08:50:33Z","pushed_at":"2018-06-29T00:42:15Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"[email protected]:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":32889,"stargazers_count":367,"watchers_count":367,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":175,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":175,"open_issues":157,"watchers":367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1532"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1532"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1532"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1532/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1532/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1532/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/3859dc7478076432fdd3c41012ee795c81d7f578"}},"author_association":"NONE"}} | {
"id": 1575956,
"name": "apache/bookkeeper",
"url": "https://api.github.com/repos/apache/bookkeeper"
} | {
"id": 13989266,
"login": "reddycharan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13989266?",
"url": "https://api.github.com/users/reddycharan"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-07-06T17:36:52 | 7930139631 | {"actor":{"display_login":"reddycharan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/avro/pulls/comments/176557719","pull_request_review_id":106283904,"id":176557719,"diff_hunk":"@@ -34,50 +35,63 @@ protected Codec createInstance() {\n }\n }\n \n- private SnappyCodec() {}\n+ SnappyCodec() {}\n \n @Override public String getName() { return DataFileConstants.SNAPPY_CODEC; }\n \n @Override\n public ByteBuffer compress(ByteBuffer in) throws IOException {","path":"lang/java/avro/src/main/java/org/apache/avro/file/SnappyCodec.java","position":26,"original_position":26,"commit_id":"1e76913847714870ab0d142ec55a1965cbfb96bb","original_commit_id":"1e76913847714870ab0d142ec55a1965cbfb96bb","user":{"login":"scottcarey","id":1198447,"avatar_url":"https://avatars2.githubusercontent.com/u/1198447?v=4","gravatar_id":"","url":"https://api.github.com/users/scottcarey","html_url":"https://github.com/scottcarey","followers_url":"https://api.github.com/users/scottcarey/followers","following_url":"https://api.github.com/users/scottcarey/following{/other_user}","gists_url":"https://api.github.com/users/scottcarey/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcarey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcarey/subscriptions","organizations_url":"https://api.github.com/users/scottcarey/orgs","repos_url":"https://api.github.com/users/scottcarey/repos","events_url":"https://api.github.com/users/scottcarey/events{/privacy}","received_events_url":"https://api.github.com/users/scottcarey/received_events","type":"User","site_admin":false},"body":"Tests were failing on only Snappy when I made some overly strict assumptions on the returned buffer. \r\n\r\nIn the process of debugging I fixed at least one bug (not setting ByteOrder.LITTLE_ENDIAN and letting the file format depend on the CPU of the writer).\r\n\r\nThe code also was not properly accounting for arrayOffset in many cases.","created_at":"2018-03-22T20:12:28Z","updated_at":"2018-03-22T20:12:29Z","html_url":"https://github.com/apache/avro/pull/303#discussion_r176557719","pull_request_url":"https://api.github.com/repos/apache/avro/pulls/303","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/avro/pulls/comments/176557719"},"html":{"href":"https://github.com/apache/avro/pull/303#discussion_r176557719"},"pull_request":{"href":"https://api.github.com/repos/apache/avro/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/apache/avro/pulls/303","id":176893043,"html_url":"https://github.com/apache/avro/pull/303","diff_url":"https://github.com/apache/avro/pull/303.diff","patch_url":"https://github.com/apache/avro/pull/303.patch","issue_url":"https://api.github.com/repos/apache/avro/issues/303","number":303,"state":"open","locked":false,"title":"AVRO-2162 Adds Zstandard compression to the Avro File Format (Java)","user":{"login":"scottcarey","id":1198447,"avatar_url":"https://avatars2.githubusercontent.com/u/1198447?v=4","gravatar_id":"","url":"https://api.github.com/users/scottcarey","html_url":"https://github.com/scottcarey","followers_url":"https://api.github.com/users/scottcarey/followers","following_url":"https://api.github.com/users/scottcarey/following{/other_user}","gists_url":"https://api.github.com/users/scottcarey/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcarey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcarey/subscriptions","organizations_url":"https://api.github.com/users/scottcarey/orgs","repos_url":"https://api.github.com/users/scottcarey/repos","events_url":"https://api.github.com/users/scottcarey/events{/privacy}","received_events_url":"https://api.github.com/users/scottcarey/received_events","type":"User","site_admin":false},"body":" Adds TestCodecs to cover all file compression Codecs.\r\n Consolidates common code in Codecs into OutputStreamCodec\r\n and OutputInputStreamCodec abstractions.\r\n Fixes DataFileStream so that Codecs can return DirectByteBuffers\r\n or Heap ByteBuffers with non-zero offset.","created_at":"2018-03-22T19:58:36Z","updated_at":"2018-03-22T20:12:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7855b3733f05d1546531196a41d16ebaadc24961","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/avro/pulls/303/commits","review_comments_url":"https://api.github.com/repos/apache/avro/pulls/303/comments","review_comment_url":"https://api.github.com/repos/apache/avro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/avro/issues/303/comments","statuses_url":"https://api.github.com/repos/apache/avro/statuses/1e76913847714870ab0d142ec55a1965cbfb96bb","head":{"label":"scottcarey:feature/AVRO-2162-add-zstandard","ref":"feature/AVRO-2162-add-zstandard","sha":"1e76913847714870ab0d142ec55a1965cbfb96bb","user":{"login":"scottcarey","id":1198447,"avatar_url":"https://avatars2.githubusercontent.com/u/1198447?v=4","gravatar_id":"","url":"https://api.github.com/users/scottcarey","html_url":"https://github.com/scottcarey","followers_url":"https://api.github.com/users/scottcarey/followers","following_url":"https://api.github.com/users/scottcarey/following{/other_user}","gists_url":"https://api.github.com/users/scottcarey/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcarey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcarey/subscriptions","organizations_url":"https://api.github.com/users/scottcarey/orgs","repos_url":"https://api.github.com/users/scottcarey/repos","events_url":"https://api.github.com/users/scottcarey/events{/privacy}","received_events_url":"https://api.github.com/users/scottcarey/received_events","type":"User","site_admin":false},"repo":{"id":126292627,"name":"avro","full_name":"scottcarey/avro","owner":{"login":"scottcarey","id":1198447,"avatar_url":"https://avatars2.githubusercontent.com/u/1198447?v=4","gravatar_id":"","url":"https://api.github.com/users/scottcarey","html_url":"https://github.com/scottcarey","followers_url":"https://api.github.com/users/scottcarey/followers","following_url":"https://api.github.com/users/scottcarey/following{/other_user}","gists_url":"https://api.github.com/users/scottcarey/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcarey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcarey/subscriptions","organizations_url":"https://api.github.com/users/scottcarey/orgs","repos_url":"https://api.github.com/users/scottcarey/repos","events_url":"https://api.github.com/users/scottcarey/events{/privacy}","received_events_url":"https://api.github.com/users/scottcarey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scottcarey/avro","description":"Apache Avro","fork":true,"url":"https://api.github.com/repos/scottcarey/avro","forks_url":"https://api.github.com/repos/scottcarey/avro/forks","keys_url":"https://api.github.com/repos/scottcarey/avro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scottcarey/avro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scottcarey/avro/teams","hooks_url":"https://api.github.com/repos/scottcarey/avro/hooks","issue_events_url":"https://api.github.com/repos/scottcarey/avro/issues/events{/number}","events_url":"https://api.github.com/repos/scottcarey/avro/events","assignees_url":"https://api.github.com/repos/scottcarey/avro/assignees{/user}","branches_url":"https://api.github.com/repos/scottcarey/avro/branches{/branch}","tags_url":"https://api.github.com/repos/scottcarey/avro/tags","blobs_url":"https://api.github.com/repos/scottcarey/avro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scottcarey/avro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scottcarey/avro/git/refs{/sha}","trees_url":"https://api.github.com/repos/scottcarey/avro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scottcarey/avro/statuses/{sha}","languages_url":"https://api.github.com/repos/scottcarey/avro/languages","stargazers_url":"https://api.github.com/repos/scottcarey/avro/stargazers","contributors_url":"https://api.github.com/repos/scottcarey/avro/contributors","subscribers_url":"https://api.github.com/repos/scottcarey/avro/subscribers","subscription_url":"https://api.github.com/repos/scottcarey/avro/subscription","commits_url":"https://api.github.com/repos/scottcarey/avro/commits{/sha}","git_commits_url":"https://api.github.com/repos/scottcarey/avro/git/commits{/sha}","comments_url":"https://api.github.com/repos/scottcarey/avro/comments{/number}","issue_comment_url":"https://api.github.com/repos/scottcarey/avro/issues/comments{/number}","contents_url":"https://api.github.com/repos/scottcarey/avro/contents/{+path}","compare_url":"https://api.github.com/repos/scottcarey/avro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scottcarey/avro/merges","archive_url":"https://api.github.com/repos/scottcarey/avro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scottcarey/avro/downloads","issues_url":"https://api.github.com/repos/scottcarey/avro/issues{/number}","pulls_url":"https://api.github.com/repos/scottcarey/avro/pulls{/number}","milestones_url":"https://api.github.com/repos/scottcarey/avro/milestones{/number}","notifications_url":"https://api.github.com/repos/scottcarey/avro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scottcarey/avro/labels{/name}","releases_url":"https://api.github.com/repos/scottcarey/avro/releases{/id}","deployments_url":"https://api.github.com/repos/scottcarey/avro/deployments","created_at":"2018-03-22T06:54:48Z","updated_at":"2018-03-22T06:54:54Z","pushed_at":"2018-03-22T19:55:42Z","git_url":"git://github.com/scottcarey/avro.git","ssh_url":"[email protected]:scottcarey/avro.git","clone_url":"https://github.com/scottcarey/avro.git","svn_url":"https://github.com/scottcarey/avro","homepage":"","size":12273,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:branch-1.8","ref":"branch-1.8","sha":"10792f777f5a31f8c1e5d9a6f6c6d4ba2727ab58","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206459,"name":"avro","full_name":"apache/avro","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/avro","description":"Apache Avro","fork":false,"url":"https://api.github.com/repos/apache/avro","forks_url":"https://api.github.com/repos/apache/avro/forks","keys_url":"https://api.github.com/repos/apache/avro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/avro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/avro/teams","hooks_url":"https://api.github.com/repos/apache/avro/hooks","issue_events_url":"https://api.github.com/repos/apache/avro/issues/events{/number}","events_url":"https://api.github.com/repos/apache/avro/events","assignees_url":"https://api.github.com/repos/apache/avro/assignees{/user}","branches_url":"https://api.github.com/repos/apache/avro/branches{/branch}","tags_url":"https://api.github.com/repos/apache/avro/tags","blobs_url":"https://api.github.com/repos/apache/avro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/avro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/avro/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/avro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/avro/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/avro/languages","stargazers_url":"https://api.github.com/repos/apache/avro/stargazers","contributors_url":"https://api.github.com/repos/apache/avro/contributors","subscribers_url":"https://api.github.com/repos/apache/avro/subscribers","subscription_url":"https://api.github.com/repos/apache/avro/subscription","commits_url":"https://api.github.com/repos/apache/avro/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/avro/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/avro/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/avro/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/avro/contents/{+path}","compare_url":"https://api.github.com/repos/apache/avro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/avro/merges","archive_url":"https://api.github.com/repos/apache/avro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/avro/downloads","issues_url":"https://api.github.com/repos/apache/avro/issues{/number}","pulls_url":"https://api.github.com/repos/apache/avro/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/avro/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/avro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/avro/labels{/name}","releases_url":"https://api.github.com/repos/apache/avro/releases{/id}","deployments_url":"https://api.github.com/repos/apache/avro/deployments","created_at":"2009-05-21T02:48:37Z","updated_at":"2018-03-22T10:15:11Z","pushed_at":"2018-03-22T19:58:37Z","git_url":"git://github.com/apache/avro.git","ssh_url":"[email protected]:apache/avro.git","clone_url":"https://github.com/apache/avro.git","svn_url":"https://github.com/apache/avro","homepage":"","size":12273,"stargazers_count":874,"watchers_count":874,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":675,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":675,"open_issues":101,"watchers":874,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/avro/pulls/303"},"html":{"href":"https://github.com/apache/avro/pull/303"},"issue":{"href":"https://api.github.com/repos/apache/avro/issues/303"},"comments":{"href":"https://api.github.com/repos/apache/avro/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/avro/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/avro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/avro/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/apache/avro/statuses/1e76913847714870ab0d142ec55a1965cbfb96bb"}},"author_association":"CONTRIBUTOR"}} | {
"id": 206459,
"name": "apache/avro",
"url": "https://api.github.com/repos/apache/avro"
} | {
"id": 1198447,
"login": "scottcarey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1198447?",
"url": "https://api.github.com/users/scottcarey"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-03-22T20:12:28 | 7421619271 | {"actor":{"display_login":"scottcarey"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/207876647","pull_request_review_id":143573598,"id":207876647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzg3NjY0Nw==","diff_hunk":"@@ -0,0 +1,47 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.types\n+\n+import org.apache.spark.SparkFunSuite\n+\n+class MapTypeSuite extends SparkFunSuite {\n+ test(\"SPARK-25031\") {","path":"sql/catalyst/src/test/scala/org/apache/spark/sql/types/MapTypeSuite.scala","position":23,"original_position":23,"commit_id":"f1a7e29837c39f626b260af3d62d74be9d0e802f","original_commit_id":"f1a7e29837c39f626b260af3d62d74be9d0e802f","user":{"login":"HyukjinKwon","id":6477701,"node_id":"MDQ6VXNlcjY0Nzc3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6477701?v=4","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"body":"nit: `SPARK-25031: MapType should produce current formatted string for complex types`","created_at":"2018-08-06T12:40:19Z","updated_at":"2018-08-06T12:40:19Z","html_url":"https://github.com/apache/spark/pull/22006#discussion_r207876647","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/22006","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/207876647"},"html":{"href":"https://github.com/apache/spark/pull/22006#discussion_r207876647"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/22006"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22006","id":206370401,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzcwNDAx","html_url":"https://github.com/apache/spark/pull/22006","diff_url":"https://github.com/apache/spark/pull/22006.diff","patch_url":"https://github.com/apache/spark/pull/22006.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/22006","number":22006,"state":"open","locked":false,"title":"[SPARK-25031][SQL] Fix MapType schema print","user":{"login":"invkrh","id":5421623,"node_id":"MDQ6VXNlcjU0MjE2MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5421623?v=4","gravatar_id":"","url":"https://api.github.com/users/invkrh","html_url":"https://github.com/invkrh","followers_url":"https://api.github.com/users/invkrh/followers","following_url":"https://api.github.com/users/invkrh/following{/other_user}","gists_url":"https://api.github.com/users/invkrh/gists{/gist_id}","starred_url":"https://api.github.com/users/invkrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invkrh/subscriptions","organizations_url":"https://api.github.com/users/invkrh/orgs","repos_url":"https://api.github.com/users/invkrh/repos","events_url":"https://api.github.com/users/invkrh/events{/privacy}","received_events_url":"https://api.github.com/users/invkrh/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThe PR fix the bug in `buildFormattedString` function in `MapType`, which makes the printed schema misleading.\r\n\r\n## How was this patch tested?\r\n\r\nAdded UT\r\n","created_at":"2018-08-06T11:34:18Z","updated_at":"2018-08-06T12:40:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"413d0e3c0c89f32a26c7aa209bd145fd1cca57d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/22006/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/22006/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/22006/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/f1a7e29837c39f626b260af3d62d74be9d0e802f","head":{"label":"invkrh:fix-map-schema-print","ref":"fix-map-schema-print","sha":"f1a7e29837c39f626b260af3d62d74be9d0e802f","user":{"login":"invkrh","id":5421623,"node_id":"MDQ6VXNlcjU0MjE2MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5421623?v=4","gravatar_id":"","url":"https://api.github.com/users/invkrh","html_url":"https://github.com/invkrh","followers_url":"https://api.github.com/users/invkrh/followers","following_url":"https://api.github.com/users/invkrh/following{/other_user}","gists_url":"https://api.github.com/users/invkrh/gists{/gist_id}","starred_url":"https://api.github.com/users/invkrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invkrh/subscriptions","organizations_url":"https://api.github.com/users/invkrh/orgs","repos_url":"https://api.github.com/users/invkrh/repos","events_url":"https://api.github.com/users/invkrh/events{/privacy}","received_events_url":"https://api.github.com/users/invkrh/received_events","type":"User","site_admin":false},"repo":{"id":36795079,"node_id":"MDEwOlJlcG9zaXRvcnkzNjc5NTA3OQ==","name":"spark","full_name":"invkrh/spark","owner":{"login":"invkrh","id":5421623,"node_id":"MDQ6VXNlcjU0MjE2MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5421623?v=4","gravatar_id":"","url":"https://api.github.com/users/invkrh","html_url":"https://github.com/invkrh","followers_url":"https://api.github.com/users/invkrh/followers","following_url":"https://api.github.com/users/invkrh/following{/other_user}","gists_url":"https://api.github.com/users/invkrh/gists{/gist_id}","starred_url":"https://api.github.com/users/invkrh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invkrh/subscriptions","organizations_url":"https://api.github.com/users/invkrh/orgs","repos_url":"https://api.github.com/users/invkrh/repos","events_url":"https://api.github.com/users/invkrh/events{/privacy}","received_events_url":"https://api.github.com/users/invkrh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/invkrh/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/invkrh/spark","forks_url":"https://api.github.com/repos/invkrh/spark/forks","keys_url":"https://api.github.com/repos/invkrh/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/invkrh/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/invkrh/spark/teams","hooks_url":"https://api.github.com/repos/invkrh/spark/hooks","issue_events_url":"https://api.github.com/repos/invkrh/spark/issues/events{/number}","events_url":"https://api.github.com/repos/invkrh/spark/events","assignees_url":"https://api.github.com/repos/invkrh/spark/assignees{/user}","branches_url":"https://api.github.com/repos/invkrh/spark/branches{/branch}","tags_url":"https://api.github.com/repos/invkrh/spark/tags","blobs_url":"https://api.github.com/repos/invkrh/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/invkrh/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/invkrh/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/invkrh/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/invkrh/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/invkrh/spark/languages","stargazers_url":"https://api.github.com/repos/invkrh/spark/stargazers","contributors_url":"https://api.github.com/repos/invkrh/spark/contributors","subscribers_url":"https://api.github.com/repos/invkrh/spark/subscribers","subscription_url":"https://api.github.com/repos/invkrh/spark/subscription","commits_url":"https://api.github.com/repos/invkrh/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/invkrh/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/invkrh/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/invkrh/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/invkrh/spark/contents/{+path}","compare_url":"https://api.github.com/repos/invkrh/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/invkrh/spark/merges","archive_url":"https://api.github.com/repos/invkrh/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/invkrh/spark/downloads","issues_url":"https://api.github.com/repos/invkrh/spark/issues{/number}","pulls_url":"https://api.github.com/repos/invkrh/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/invkrh/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/invkrh/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/invkrh/spark/labels{/name}","releases_url":"https://api.github.com/repos/invkrh/spark/releases{/id}","deployments_url":"https://api.github.com/repos/invkrh/spark/deployments","created_at":"2015-06-03T09:53:39Z","updated_at":"2018-08-03T13:07:17Z","pushed_at":"2018-08-06T11:38:33Z","git_url":"git://github.com/invkrh/spark.git","ssh_url":"[email protected]:invkrh/spark.git","clone_url":"https://github.com/invkrh/spark.git","svn_url":"https://github.com/invkrh/spark","homepage":null,"size":258455,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c1760da5dd5576c52be4f9dd9ecd06589a6153e4","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-08-06T11:00:39Z","pushed_at":"2018-08-06T11:59:05Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":278594,"stargazers_count":18325,"watchers_count":18325,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16594,"mirror_url":null,"archived":false,"open_issues_count":490,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16594,"open_issues":490,"watchers":18325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/22006"},"html":{"href":"https://github.com/apache/spark/pull/22006"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/22006"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/22006/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/22006/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/22006/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/f1a7e29837c39f626b260af3d62d74be9d0e802f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 6477701,
"login": "HyukjinKwon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6477701?",
"url": "https://api.github.com/users/HyukjinKwon"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-08-06T12:40:19 | 8071267764 | {"actor":{"display_login":"HyukjinKwon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/220205505","pull_request_review_id":158558376,"id":220205505,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDIwNTUwNQ==","diff_hunk":"@@ -130,6 +131,13 @@ public T getDispatcher() {\n \t\t}\n \t}\n \n+\t@VisibleForTesting\n+\tpublic WebMonitorEndpoint<?> getWebMonitorEndpoint() {","path":"flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterComponent.java","position":null,"original_position":13,"commit_id":"a4f768e5095c5e6fbcbbc2707494440f6761abdd","original_commit_id":"a4f768e5095c5e6fbcbbc2707494440f6761abdd","user":{"login":"StefanRRichter","id":2128543,"node_id":"MDQ6VXNlcjIxMjg1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/2128543?v=4","gravatar_id":"","url":"https://api.github.com/users/StefanRRichter","html_url":"https://github.com/StefanRRichter","followers_url":"https://api.github.com/users/StefanRRichter/followers","following_url":"https://api.github.com/users/StefanRRichter/following{/other_user}","gists_url":"https://api.github.com/users/StefanRRichter/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanRRichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanRRichter/subscriptions","organizations_url":"https://api.github.com/users/StefanRRichter/orgs","repos_url":"https://api.github.com/users/StefanRRichter/repos","events_url":"https://api.github.com/users/StefanRRichter/events{/privacy}","received_events_url":"https://api.github.com/users/StefanRRichter/received_events","type":"User","site_admin":false},"body":"Coming back to my longer comment on #6749, I think this is only required because the collaborator is lazily created in a lifecycle method. I wonder if we could not have a building object the will create all collaborators at the place where currently `startComponent` is called because `clusterComponent = createClusterComponent(configuration)` and `clusterComponent.startComponent(...)` are even called in a straight sequence. Tests could then simply pass WebMonitorEndpoint into the component.","created_at":"2018-09-25T14:02:43Z","updated_at":"2018-09-25T14:50:03Z","html_url":"https://github.com/apache/flink/pull/6749#discussion_r220205505","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6749","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/220205505"},"html":{"href":"https://github.com/apache/flink/pull/6749#discussion_r220205505"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6749"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6749","id":217693874,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjkzODc0","html_url":"https://github.com/apache/flink/pull/6749","diff_url":"https://github.com/apache/flink/pull/6749.diff","patch_url":"https://github.com/apache/flink/pull/6749.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6749","number":6749,"state":"open","locked":false,"title":"[FLINK-10401] Port ProcessFailureCancelingITCase to new code base","user":{"login":"tillrohrmann","id":5756858,"node_id":"MDQ6VXNlcjU3NTY4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nThis PR is based on #6743 and #6742 and is part of the [removal of Flink's legacy mode](https://issues.apache.org/jira/browse/FLINK-10392).\r\n\r\nPort `ProcessFailureCancelingITCase` to new code base using the `SessionClusterComponent`.\r\n\r\n## Verifying this change\r\n\r\n- Checked manually that the test works and still tests the cancellation\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n - Dependencies (does it add or upgrade a dependency): (no)\r\n - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n - The serializers: (no)\r\n - The runtime per-record code paths (performance sensitive): (no)\r\n - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n - Does this pull request introduce a new feature? (no)\r\n - If yes, how is the feature documented? (not applicable)\r\n","created_at":"2018-09-24T15:20:20Z","updated_at":"2018-09-25T14:50:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d5cb95c2344e351203ff4f101322463f63b3ee6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6749/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6749/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6749/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/a4f768e5095c5e6fbcbbc2707494440f6761abdd","head":{"label":"tillrohrmann:portProcessFailureCancelingITCase","ref":"portProcessFailureCancelingITCase","sha":"a4f768e5095c5e6fbcbbc2707494440f6761abdd","user":{"login":"tillrohrmann","id":5756858,"node_id":"MDQ6VXNlcjU3NTY4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"repo":{"id":20681108,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY4MTEwOA==","name":"flink","full_name":"tillrohrmann/flink","private":false,"owner":{"login":"tillrohrmann","id":5756858,"node_id":"MDQ6VXNlcjU3NTY4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tillrohrmann/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/tillrohrmann/flink","forks_url":"https://api.github.com/repos/tillrohrmann/flink/forks","keys_url":"https://api.github.com/repos/tillrohrmann/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tillrohrmann/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tillrohrmann/flink/teams","hooks_url":"https://api.github.com/repos/tillrohrmann/flink/hooks","issue_events_url":"https://api.github.com/repos/tillrohrmann/flink/issues/events{/number}","events_url":"https://api.github.com/repos/tillrohrmann/flink/events","assignees_url":"https://api.github.com/repos/tillrohrmann/flink/assignees{/user}","branches_url":"https://api.github.com/repos/tillrohrmann/flink/branches{/branch}","tags_url":"https://api.github.com/repos/tillrohrmann/flink/tags","blobs_url":"https://api.github.com/repos/tillrohrmann/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tillrohrmann/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tillrohrmann/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/tillrohrmann/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tillrohrmann/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/tillrohrmann/flink/languages","stargazers_url":"https://api.github.com/repos/tillrohrmann/flink/stargazers","contributors_url":"https://api.github.com/repos/tillrohrmann/flink/contributors","subscribers_url":"https://api.github.com/repos/tillrohrmann/flink/subscribers","subscription_url":"https://api.github.com/repos/tillrohrmann/flink/subscription","commits_url":"https://api.github.com/repos/tillrohrmann/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/tillrohrmann/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/tillrohrmann/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/tillrohrmann/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/tillrohrmann/flink/contents/{+path}","compare_url":"https://api.github.com/repos/tillrohrmann/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tillrohrmann/flink/merges","archive_url":"https://api.github.com/repos/tillrohrmann/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tillrohrmann/flink/downloads","issues_url":"https://api.github.com/repos/tillrohrmann/flink/issues{/number}","pulls_url":"https://api.github.com/repos/tillrohrmann/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/tillrohrmann/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/tillrohrmann/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tillrohrmann/flink/labels{/name}","releases_url":"https://api.github.com/repos/tillrohrmann/flink/releases{/id}","deployments_url":"https://api.github.com/repos/tillrohrmann/flink/deployments","created_at":"2014-06-10T10:19:35Z","updated_at":"2018-07-07T09:12:11Z","pushed_at":"2018-09-25T14:23:31Z","git_url":"git://github.com/tillrohrmann/flink.git","ssh_url":"[email protected]:tillrohrmann/flink.git","clone_url":"https://github.com/tillrohrmann/flink.git","svn_url":"https://github.com/tillrohrmann/flink","homepage":null,"size":160596,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3c574b456dba1cf019b4f64638a992aed5b338cb","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-09-25T12:11:38Z","pushed_at":"2018-09-25T14:46:56Z","git_url":"git://github.com/apache/flink.git","ssh_url":"[email protected]:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":165412,"stargazers_count":4468,"watchers_count":4468,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2913,"mirror_url":null,"archived":false,"open_issues_count":406,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2913,"open_issues":406,"watchers":4468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6749"},"html":{"href":"https://github.com/apache/flink/pull/6749"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6749"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6749/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6749/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6749/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/a4f768e5095c5e6fbcbbc2707494440f6761abdd"}},"author_association":"CONTRIBUTOR"}} | {
"id": 20587599,
"name": "apache/flink",
"url": "https://api.github.com/repos/apache/flink"
} | {
"id": 2128543,
"login": "StefanRRichter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2128543?",
"url": "https://api.github.com/users/StefanRRichter"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-09-25T14:02:43 | 8318505477 | {"actor":{"display_login":"StefanRRichter"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/karaf/pulls/comments/224980091","pull_request_review_id":164485343,"id":224980091,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk4MDA5MQ==","diff_hunk":"@@ -0,0 +1,35 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.karaf.examples.jersey.servicedef.beans;","path":"examples/karaf-jersey-example/karaf-jersey-example.servicedef/src/main/java/org/apache/karaf/examples/jersey/servicedef/beans/Count.java","position":17,"original_position":17,"commit_id":"9be272ab92b26c4a1598e7e077a3831eab67a4a2","original_commit_id":"9be272ab92b26c4a1598e7e077a3831eab67a4a2","user":{"login":"jbonofre","id":158903,"node_id":"MDQ6VXNlcjE1ODkwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/158903?v=4","gravatar_id":"","url":"https://api.github.com/users/jbonofre","html_url":"https://github.com/jbonofre","followers_url":"https://api.github.com/users/jbonofre/followers","following_url":"https://api.github.com/users/jbonofre/following{/other_user}","gists_url":"https://api.github.com/users/jbonofre/gists{/gist_id}","starred_url":"https://api.github.com/users/jbonofre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbonofre/subscriptions","organizations_url":"https://api.github.com/users/jbonofre/orgs","repos_url":"https://api.github.com/users/jbonofre/repos","events_url":"https://api.github.com/users/jbonofre/events{/privacy}","received_events_url":"https://api.github.com/users/jbonofre/received_events","type":"User","site_admin":false},"body":"No need to put in `beans`. The POJO used by the service can be at the same service definition level aka `org.apache.karaf.examples.jersey.service`.","created_at":"2018-10-14T05:33:59Z","updated_at":"2018-10-14T05:36:38Z","html_url":"https://github.com/apache/karaf/pull/633#discussion_r224980091","pull_request_url":"https://api.github.com/repos/apache/karaf/pulls/633","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/karaf/pulls/comments/224980091"},"html":{"href":"https://github.com/apache/karaf/pull/633#discussion_r224980091"},"pull_request":{"href":"https://api.github.com/repos/apache/karaf/pulls/633"}}},"pull_request":{"url":"https://api.github.com/repos/apache/karaf/pulls/633","id":221943027,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTQzMDI3","html_url":"https://github.com/apache/karaf/pull/633","diff_url":"https://github.com/apache/karaf/pull/633.diff","patch_url":"https://github.com/apache/karaf/pull/633.patch","issue_url":"https://api.github.com/repos/apache/karaf/issues/633","number":633,"state":"open","locked":false,"title":"Add an example of using Jersey in karaf","user":{"login":"steinarb","id":691728,"node_id":"MDQ6VXNlcjY5MTcyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/691728?v=4","gravatar_id":"","url":"https://api.github.com/users/steinarb","html_url":"https://github.com/steinarb","followers_url":"https://api.github.com/users/steinarb/followers","following_url":"https://api.github.com/users/steinarb/following{/other_user}","gists_url":"https://api.github.com/users/steinarb/gists{/gist_id}","starred_url":"https://api.github.com/users/steinarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinarb/subscriptions","organizations_url":"https://api.github.com/users/steinarb/orgs","repos_url":"https://api.github.com/users/steinarb/repos","events_url":"https://api.github.com/users/steinarb/events{/privacy}","received_events_url":"https://api.github.com/users/steinarb/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-10T21:44:09Z","updated_at":"2018-10-14T05:36:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8688d7e8650fa9d1a0b9ddb8bfe84cc50592f2b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/karaf/pulls/633/commits","review_comments_url":"https://api.github.com/repos/apache/karaf/pulls/633/comments","review_comment_url":"https://api.github.com/repos/apache/karaf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/karaf/issues/633/comments","statuses_url":"https://api.github.com/repos/apache/karaf/statuses/9be272ab92b26c4a1598e7e077a3831eab67a4a2","head":{"label":"steinarb:add-karaf-jersey-example","ref":"add-karaf-jersey-example","sha":"9be272ab92b26c4a1598e7e077a3831eab67a4a2","user":{"login":"steinarb","id":691728,"node_id":"MDQ6VXNlcjY5MTcyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/691728?v=4","gravatar_id":"","url":"https://api.github.com/users/steinarb","html_url":"https://github.com/steinarb","followers_url":"https://api.github.com/users/steinarb/followers","following_url":"https://api.github.com/users/steinarb/following{/other_user}","gists_url":"https://api.github.com/users/steinarb/gists{/gist_id}","starred_url":"https://api.github.com/users/steinarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinarb/subscriptions","organizations_url":"https://api.github.com/users/steinarb/orgs","repos_url":"https://api.github.com/users/steinarb/repos","events_url":"https://api.github.com/users/steinarb/events{/privacy}","received_events_url":"https://api.github.com/users/steinarb/received_events","type":"User","site_admin":false},"repo":{"id":93932660,"node_id":"MDEwOlJlcG9zaXRvcnk5MzkzMjY2MA==","name":"karaf","full_name":"steinarb/karaf","private":false,"owner":{"login":"steinarb","id":691728,"node_id":"MDQ6VXNlcjY5MTcyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/691728?v=4","gravatar_id":"","url":"https://api.github.com/users/steinarb","html_url":"https://github.com/steinarb","followers_url":"https://api.github.com/users/steinarb/followers","following_url":"https://api.github.com/users/steinarb/following{/other_user}","gists_url":"https://api.github.com/users/steinarb/gists{/gist_id}","starred_url":"https://api.github.com/users/steinarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinarb/subscriptions","organizations_url":"https://api.github.com/users/steinarb/orgs","repos_url":"https://api.github.com/users/steinarb/repos","events_url":"https://api.github.com/users/steinarb/events{/privacy}","received_events_url":"https://api.github.com/users/steinarb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/steinarb/karaf","description":"Mirror of Apache Karaf","fork":true,"url":"https://api.github.com/repos/steinarb/karaf","forks_url":"https://api.github.com/repos/steinarb/karaf/forks","keys_url":"https://api.github.com/repos/steinarb/karaf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steinarb/karaf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steinarb/karaf/teams","hooks_url":"https://api.github.com/repos/steinarb/karaf/hooks","issue_events_url":"https://api.github.com/repos/steinarb/karaf/issues/events{/number}","events_url":"https://api.github.com/repos/steinarb/karaf/events","assignees_url":"https://api.github.com/repos/steinarb/karaf/assignees{/user}","branches_url":"https://api.github.com/repos/steinarb/karaf/branches{/branch}","tags_url":"https://api.github.com/repos/steinarb/karaf/tags","blobs_url":"https://api.github.com/repos/steinarb/karaf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steinarb/karaf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steinarb/karaf/git/refs{/sha}","trees_url":"https://api.github.com/repos/steinarb/karaf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steinarb/karaf/statuses/{sha}","languages_url":"https://api.github.com/repos/steinarb/karaf/languages","stargazers_url":"https://api.github.com/repos/steinarb/karaf/stargazers","contributors_url":"https://api.github.com/repos/steinarb/karaf/contributors","subscribers_url":"https://api.github.com/repos/steinarb/karaf/subscribers","subscription_url":"https://api.github.com/repos/steinarb/karaf/subscription","commits_url":"https://api.github.com/repos/steinarb/karaf/commits{/sha}","git_commits_url":"https://api.github.com/repos/steinarb/karaf/git/commits{/sha}","comments_url":"https://api.github.com/repos/steinarb/karaf/comments{/number}","issue_comment_url":"https://api.github.com/repos/steinarb/karaf/issues/comments{/number}","contents_url":"https://api.github.com/repos/steinarb/karaf/contents/{+path}","compare_url":"https://api.github.com/repos/steinarb/karaf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steinarb/karaf/merges","archive_url":"https://api.github.com/repos/steinarb/karaf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steinarb/karaf/downloads","issues_url":"https://api.github.com/repos/steinarb/karaf/issues{/number}","pulls_url":"https://api.github.com/repos/steinarb/karaf/pulls{/number}","milestones_url":"https://api.github.com/repos/steinarb/karaf/milestones{/number}","notifications_url":"https://api.github.com/repos/steinarb/karaf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steinarb/karaf/labels{/name}","releases_url":"https://api.github.com/repos/steinarb/karaf/releases{/id}","deployments_url":"https://api.github.com/repos/steinarb/karaf/deployments","created_at":"2017-06-10T10:38:29Z","updated_at":"2017-06-10T10:38:36Z","pushed_at":"2018-10-13T16:33:47Z","git_url":"git://github.com/steinarb/karaf.git","ssh_url":"[email protected]:steinarb/karaf.git","clone_url":"https://github.com/steinarb/karaf.git","svn_url":"https://github.com/steinarb/karaf","homepage":null,"size":59224,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9b431af781f0bdfa65385c66f0d10aee0ee7fb01","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":832676,"node_id":"MDEwOlJlcG9zaXRvcnk4MzI2NzY=","name":"karaf","full_name":"apache/karaf","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/karaf","description":"Mirror of Apache Karaf","fork":false,"url":"https://api.github.com/repos/apache/karaf","forks_url":"https://api.github.com/repos/apache/karaf/forks","keys_url":"https://api.github.com/repos/apache/karaf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/karaf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/karaf/teams","hooks_url":"https://api.github.com/repos/apache/karaf/hooks","issue_events_url":"https://api.github.com/repos/apache/karaf/issues/events{/number}","events_url":"https://api.github.com/repos/apache/karaf/events","assignees_url":"https://api.github.com/repos/apache/karaf/assignees{/user}","branches_url":"https://api.github.com/repos/apache/karaf/branches{/branch}","tags_url":"https://api.github.com/repos/apache/karaf/tags","blobs_url":"https://api.github.com/repos/apache/karaf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/karaf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/karaf/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/karaf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/karaf/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/karaf/languages","stargazers_url":"https://api.github.com/repos/apache/karaf/stargazers","contributors_url":"https://api.github.com/repos/apache/karaf/contributors","subscribers_url":"https://api.github.com/repos/apache/karaf/subscribers","subscription_url":"https://api.github.com/repos/apache/karaf/subscription","commits_url":"https://api.github.com/repos/apache/karaf/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/karaf/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/karaf/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/karaf/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/karaf/contents/{+path}","compare_url":"https://api.github.com/repos/apache/karaf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/karaf/merges","archive_url":"https://api.github.com/repos/apache/karaf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/karaf/downloads","issues_url":"https://api.github.com/repos/apache/karaf/issues{/number}","pulls_url":"https://api.github.com/repos/apache/karaf/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/karaf/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/karaf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/karaf/labels{/name}","releases_url":"https://api.github.com/repos/apache/karaf/releases{/id}","deployments_url":"https://api.github.com/repos/apache/karaf/deployments","created_at":"2010-08-12T03:32:41Z","updated_at":"2018-10-12T17:42:13Z","pushed_at":"2018-10-13T16:33:49Z","git_url":"git://github.com/apache/karaf.git","ssh_url":"[email protected]:apache/karaf.git","clone_url":"https://github.com/apache/karaf.git","svn_url":"https://github.com/apache/karaf","homepage":null,"size":60071,"stargazers_count":371,"watchers_count":371,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":432,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":432,"open_issues":8,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/karaf/pulls/633"},"html":{"href":"https://github.com/apache/karaf/pull/633"},"issue":{"href":"https://api.github.com/repos/apache/karaf/issues/633"},"comments":{"href":"https://api.github.com/repos/apache/karaf/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/karaf/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/karaf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/karaf/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/apache/karaf/statuses/9be272ab92b26c4a1598e7e077a3831eab67a4a2"}},"author_association":"CONTRIBUTOR"}} | {
"id": 832676,
"name": "apache/karaf",
"url": "https://api.github.com/repos/apache/karaf"
} | {
"id": 158903,
"login": "jbonofre",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/158903?",
"url": "https://api.github.com/users/jbonofre"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-10-14T05:33:59 | 8416664937 | {"actor":{"display_login":"jbonofre"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/214644427","pull_request_review_id":151743694,"id":214644427,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDY0NDQyNw==","diff_hunk":"@@ -0,0 +1,152 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.beam.runners.spark.translation.streaming;\n+\n+import static org.hamcrest.Matchers.containsInAnyOrder;\n+import static org.junit.Assert.assertEquals;\n+import static org.junit.Assert.assertThat;\n+import static org.junit.Assert.fail;\n+\n+import com.google.common.collect.Iterables;\n+import org.apache.beam.runners.spark.ReuseSparkContextRule;\n+import org.apache.beam.runners.spark.SparkPipelineOptions;\n+import org.apache.beam.runners.spark.StreamingTest;\n+import org.apache.beam.runners.spark.io.CreateStream;\n+import org.apache.beam.sdk.coders.KvCoder;\n+import org.apache.beam.sdk.coders.VarIntCoder;\n+import org.apache.beam.sdk.testing.PAssert;\n+import org.apache.beam.sdk.testing.TestPipeline;\n+import org.apache.beam.sdk.transforms.SerializableFunction;\n+import org.apache.beam.sdk.transforms.join.CoGbkResult;\n+import org.apache.beam.sdk.transforms.join.CoGroupByKey;\n+import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple;\n+import org.apache.beam.sdk.transforms.windowing.FixedWindows;\n+import org.apache.beam.sdk.transforms.windowing.Window;\n+import org.apache.beam.sdk.values.KV;\n+import org.apache.beam.sdk.values.PCollection;\n+import org.apache.beam.sdk.values.TimestampedValue;\n+import org.apache.beam.sdk.values.TupleTag;\n+import org.joda.time.Duration;\n+import org.joda.time.Instant;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.experimental.categories.Category;\n+\n+/** A test that verifies that CoGroupByKey works in streaming mode in spark runner. */\n+public class SparkCoGroupByKeyStreamingTest {\n+\n+ private static final TupleTag<Integer> INPUT1_TAG = new TupleTag<>(\"input1\");\n+ private static final TupleTag<Integer> INPUT2_TAG = new TupleTag<>(\"input2\");\n+\n+ @Rule public final transient ReuseSparkContextRule noContextResue = ReuseSparkContextRule.no();\n+\n+ @Rule public final TestPipeline pipeline = TestPipeline.create();\n+\n+ private Duration batchDuration() {\n+ return Duration.millis(\n+ (pipeline.getOptions().as(SparkPipelineOptions.class)).getBatchIntervalMillis());\n+ }\n+\n+ @Category(StreamingTest.class)\n+ @Test\n+ public void testInStreamingMode() throws Exception {\n+ Instant instant = new Instant(0);\n+ CreateStream<KV<Integer, Integer>> source1 =\n+ CreateStream.of(KvCoder.of(VarIntCoder.of(), VarIntCoder.of()), batchDuration())\n+ .emptyBatch()\n+ .advanceWatermarkForNextBatch(instant)\n+ .nextBatch(\n+ TimestampedValue.of(KV.of(1, 1), instant),\n+ TimestampedValue.of(KV.of(1, 2), instant),\n+ TimestampedValue.of(KV.of(1, 3), instant))\n+ .advanceWatermarkForNextBatch(instant.plus(Duration.standardSeconds(1L)))\n+ .nextBatch(\n+ TimestampedValue.of(KV.of(2, 4), instant.plus(Duration.standardSeconds(1L))),\n+ TimestampedValue.of(KV.of(2, 5), instant.plus(Duration.standardSeconds(1L))),\n+ TimestampedValue.of(KV.of(2, 6), instant.plus(Duration.standardSeconds(1L))))\n+ .advanceNextBatchWatermarkToInfinity();\n+\n+ CreateStream<KV<Integer, Integer>> source2 =\n+ CreateStream.of(KvCoder.of(VarIntCoder.of(), VarIntCoder.of()), batchDuration())\n+ .emptyBatch()\n+ .advanceWatermarkForNextBatch(instant)\n+ .nextBatch(\n+ TimestampedValue.of(KV.of(1, 11), instant),\n+ TimestampedValue.of(KV.of(1, 12), instant),\n+ TimestampedValue.of(KV.of(1, 13), instant))\n+ .advanceWatermarkForNextBatch(instant.plus(Duration.standardSeconds(1L)))\n+ .nextBatch(\n+ TimestampedValue.of(KV.of(2, 14), instant.plus(Duration.standardSeconds(1L))),\n+ TimestampedValue.of(KV.of(2, 15), instant.plus(Duration.standardSeconds(1L))),\n+ TimestampedValue.of(KV.of(2, 16), instant.plus(Duration.standardSeconds(1L))))\n+ .advanceNextBatchWatermarkToInfinity();\n+\n+ PCollection<KV<Integer, Integer>> input1 =\n+ pipeline\n+ .apply(\"create source1\", source1)\n+ .apply(\n+ \"window input1\",\n+ Window.<KV<Integer, Integer>>into(FixedWindows.of(Duration.standardSeconds(3L)))\n+ .withAllowedLateness(Duration.ZERO));\n+\n+ PCollection<KV<Integer, Integer>> input2 =\n+ pipeline\n+ .apply(\"create source2\", source2)\n+ .apply(\n+ \"window input2\",\n+ Window.<KV<Integer, Integer>>into(FixedWindows.of(Duration.standardSeconds(3L)))\n+ .withAllowedLateness(Duration.ZERO));\n+\n+ PCollection<KV<Integer, CoGbkResult>> output =\n+ KeyedPCollectionTuple.of(INPUT1_TAG, input1)\n+ .and(INPUT2_TAG, input2)\n+ .apply(CoGroupByKey.create());\n+ PAssert.that(\"Wrong output of the join using CoGroupByKey in streaming mode\", output)\n+ .satisfies(\n+ (SerializableFunction<Iterable<KV<Integer, CoGbkResult>>, Void>)\n+ input -> {\n+ assertEquals(\"Wrong size of the output PCollection\", 2, Iterables.size(input));\n+ for (KV<Integer, CoGbkResult> element : input) {\n+ if (element.getKey() == 1) {\n+ assertThat(\n+ \"Elements of PCollection input1 for key \\\"1\\\" are not present in the output PCollection\",\n+ element.getValue().getAll(INPUT1_TAG),\n+ containsInAnyOrder(1, 2, 3));\n+ assertThat(\n+ \"Elements of PCollection input2 for key \\\"1\\\" are not present in the output PCollection\",\n+ element.getValue().getAll(INPUT2_TAG),\n+ containsInAnyOrder(11, 12, 13));\n+ } else if (element.getKey() == 2) {\n+ assertThat(","path":"runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/SparkCoGroupByKeyStreamingTest.java","position":null,"original_position":136,"commit_id":"c13e48ce83cbd83dc9809a0fde2ac954e36d5208","original_commit_id":"dcf1d2925d7574f4b4f79f4e0aaad0b26c42ca92","user":{"login":"echauchot","id":8821084,"node_id":"MDQ6VXNlcjg4MjEwODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8821084?v=4","gravatar_id":"","url":"https://api.github.com/users/echauchot","html_url":"https://github.com/echauchot","followers_url":"https://api.github.com/users/echauchot/followers","following_url":"https://api.github.com/users/echauchot/following{/other_user}","gists_url":"https://api.github.com/users/echauchot/gists{/gist_id}","starred_url":"https://api.github.com/users/echauchot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echauchot/subscriptions","organizations_url":"https://api.github.com/users/echauchot/orgs","repos_url":"https://api.github.com/users/echauchot/repos","events_url":"https://api.github.com/users/echauchot/events{/privacy}","received_events_url":"https://api.github.com/users/echauchot/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2018-09-03T10:34:28Z","updated_at":"2018-09-03T10:34:29Z","html_url":"https://github.com/apache/beam/pull/5945#discussion_r214644427","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/5945","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/214644427"},"html":{"href":"https://github.com/apache/beam/pull/5945#discussion_r214644427"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/5945"}},"in_reply_to_id":214617707},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/5945","id":201317542,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzE3NTQy","html_url":"https://github.com/apache/beam/pull/5945","diff_url":"https://github.com/apache/beam/pull/5945.diff","patch_url":"https://github.com/apache/beam/pull/5945.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/5945","number":5945,"state":"open","locked":false,"title":"[BEAM-3193] Add SparkCoGroupByKeyStreaming validates runner to test CoGroupByKay bahavior in streaming mode on spark runner","user":{"login":"echauchot","id":8821084,"node_id":"MDQ6VXNlcjg4MjEwODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8821084?v=4","gravatar_id":"","url":"https://api.github.com/users/echauchot","html_url":"https://github.com/echauchot","followers_url":"https://api.github.com/users/echauchot/followers","following_url":"https://api.github.com/users/echauchot/following{/other_user}","gists_url":"https://api.github.com/users/echauchot/gists{/gist_id}","starred_url":"https://api.github.com/users/echauchot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echauchot/subscriptions","organizations_url":"https://api.github.com/users/echauchot/orgs","repos_url":"https://api.github.com/users/echauchot/repos","events_url":"https://api.github.com/users/echauchot/events{/privacy}","received_events_url":"https://api.github.com/users/echauchot/received_events","type":"User","site_admin":false},"body":"@jbonofre It seems that CoGroupByKey in streaming mode on spark runner, works fine in the end. This PR adds a validates runner test and it passes.\r\n------------------------\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.\r\n - [X] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\nIt will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.\r\n\r\nPost-Commit Tests Status (on master branch)\r\n------------------------------------------------------------------------------------------------\r\n\r\nLang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark\r\n--- | --- | --- | --- | --- | --- | --- | ---\r\nGo | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---\r\nJava | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)\r\nPython | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---\r\n\r\n\r\n\r\n\r\n","created_at":"2018-07-13T15:01:58Z","updated_at":"2018-09-03T10:34:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e61e63598804cde8da441f2e26a74b4e83e829df","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jbonofre","id":158903,"node_id":"MDQ6VXNlcjE1ODkwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/158903?v=4","gravatar_id":"","url":"https://api.github.com/users/jbonofre","html_url":"https://github.com/jbonofre","followers_url":"https://api.github.com/users/jbonofre/followers","following_url":"https://api.github.com/users/jbonofre/following{/other_user}","gists_url":"https://api.github.com/users/jbonofre/gists{/gist_id}","starred_url":"https://api.github.com/users/jbonofre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbonofre/subscriptions","organizations_url":"https://api.github.com/users/jbonofre/orgs","repos_url":"https://api.github.com/users/jbonofre/repos","events_url":"https://api.github.com/users/jbonofre/events{/privacy}","received_events_url":"https://api.github.com/users/jbonofre/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/5945/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/5945/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/5945/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/c13e48ce83cbd83dc9809a0fde2ac954e36d5208","head":{"label":"echauchot:BEAM-3193-spark-CoGroupByKey-streaming","ref":"BEAM-3193-spark-CoGroupByKey-streaming","sha":"c13e48ce83cbd83dc9809a0fde2ac954e36d5208","user":{"login":"echauchot","id":8821084,"node_id":"MDQ6VXNlcjg4MjEwODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8821084?v=4","gravatar_id":"","url":"https://api.github.com/users/echauchot","html_url":"https://github.com/echauchot","followers_url":"https://api.github.com/users/echauchot/followers","following_url":"https://api.github.com/users/echauchot/following{/other_user}","gists_url":"https://api.github.com/users/echauchot/gists{/gist_id}","starred_url":"https://api.github.com/users/echauchot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echauchot/subscriptions","organizations_url":"https://api.github.com/users/echauchot/orgs","repos_url":"https://api.github.com/users/echauchot/repos","events_url":"https://api.github.com/users/echauchot/events{/privacy}","received_events_url":"https://api.github.com/users/echauchot/received_events","type":"User","site_admin":false},"repo":{"id":68310413,"node_id":"MDEwOlJlcG9zaXRvcnk2ODMxMDQxMw==","name":"beam","full_name":"echauchot/beam","owner":{"login":"echauchot","id":8821084,"node_id":"MDQ6VXNlcjg4MjEwODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8821084?v=4","gravatar_id":"","url":"https://api.github.com/users/echauchot","html_url":"https://github.com/echauchot","followers_url":"https://api.github.com/users/echauchot/followers","following_url":"https://api.github.com/users/echauchot/following{/other_user}","gists_url":"https://api.github.com/users/echauchot/gists{/gist_id}","starred_url":"https://api.github.com/users/echauchot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echauchot/subscriptions","organizations_url":"https://api.github.com/users/echauchot/orgs","repos_url":"https://api.github.com/users/echauchot/repos","events_url":"https://api.github.com/users/echauchot/events{/privacy}","received_events_url":"https://api.github.com/users/echauchot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/echauchot/beam","description":"Mirror of Apache Beam","fork":true,"url":"https://api.github.com/repos/echauchot/beam","forks_url":"https://api.github.com/repos/echauchot/beam/forks","keys_url":"https://api.github.com/repos/echauchot/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/echauchot/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/echauchot/beam/teams","hooks_url":"https://api.github.com/repos/echauchot/beam/hooks","issue_events_url":"https://api.github.com/repos/echauchot/beam/issues/events{/number}","events_url":"https://api.github.com/repos/echauchot/beam/events","assignees_url":"https://api.github.com/repos/echauchot/beam/assignees{/user}","branches_url":"https://api.github.com/repos/echauchot/beam/branches{/branch}","tags_url":"https://api.github.com/repos/echauchot/beam/tags","blobs_url":"https://api.github.com/repos/echauchot/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/echauchot/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/echauchot/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/echauchot/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/echauchot/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/echauchot/beam/languages","stargazers_url":"https://api.github.com/repos/echauchot/beam/stargazers","contributors_url":"https://api.github.com/repos/echauchot/beam/contributors","subscribers_url":"https://api.github.com/repos/echauchot/beam/subscribers","subscription_url":"https://api.github.com/repos/echauchot/beam/subscription","commits_url":"https://api.github.com/repos/echauchot/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/echauchot/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/echauchot/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/echauchot/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/echauchot/beam/contents/{+path}","compare_url":"https://api.github.com/repos/echauchot/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/echauchot/beam/merges","archive_url":"https://api.github.com/repos/echauchot/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/echauchot/beam/downloads","issues_url":"https://api.github.com/repos/echauchot/beam/issues{/number}","pulls_url":"https://api.github.com/repos/echauchot/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/echauchot/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/echauchot/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/echauchot/beam/labels{/name}","releases_url":"https://api.github.com/repos/echauchot/beam/releases{/id}","deployments_url":"https://api.github.com/repos/echauchot/beam/deployments","created_at":"2016-09-15T16:17:29Z","updated_at":"2017-06-02T13:59:37Z","pushed_at":"2018-09-03T10:34:25Z","git_url":"git://github.com/echauchot/beam.git","ssh_url":"[email protected]:echauchot/beam.git","clone_url":"https://github.com/echauchot/beam.git","svn_url":"https://github.com/echauchot/beam","homepage":"","size":96028,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"44f21ece0d6247fbd9a7b94204287bacc1a0f199","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-09-03T09:24:25Z","pushed_at":"2018-09-03T10:34:28Z","git_url":"git://github.com/apache/beam.git","ssh_url":"[email protected]:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":101716,"stargazers_count":2109,"watchers_count":2109,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1313,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1313,"open_issues":95,"watchers":2109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/5945"},"html":{"href":"https://github.com/apache/beam/pull/5945"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/5945"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/5945/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/5945/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/5945/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/c13e48ce83cbd83dc9809a0fde2ac954e36d5208"}},"author_association":"CONTRIBUTOR"}} | {
"id": 50904245,
"name": "apache/beam",
"url": "https://api.github.com/repos/apache/beam"
} | {
"id": 8821084,
"login": "echauchot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8821084?",
"url": "https://api.github.com/users/echauchot"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-09-03T10:34:28 | 8205573500 | {"actor":{"display_login":"echauchot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/214977998","pull_request_review_id":152144467,"id":214977998,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDk3Nzk5OA==","diff_hunk":"@@ -0,0 +1,182 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.catalog.v2;\n+\n+import org.apache.spark.sql.types.DataType;\n+\n+/**\n+ * TableChange subclasses represent requested changes to a table. These are passed to\n+ * {@link TableCatalog#alterTable}. For example,\n+ * <pre>\n+ * import TableChange._\n+ * val catalog = source.asInstanceOf[TableSupport].catalog()\n+ * catalog.alterTable(ident,\n+ * addColumn(\"x\", IntegerType),\n+ * renameColumn(\"a\", \"b\"),\n+ * deleteColumn(\"c\")\n+ * )\n+ * </pre>\n+ */\n+public interface TableChange {","path":"sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableChange.java","position":35,"original_position":35,"commit_id":"6b45a119df8e6382fa2503f854b4a85aed3e3785","original_commit_id":"6b45a119df8e6382fa2503f854b4a85aed3e3785","user":{"login":"rdblue","id":87915,"node_id":"MDQ6VXNlcjg3OTE1","avatar_url":"https://avatars1.githubusercontent.com/u/87915?v=4","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"body":"No, this API covers table configuration, not data modification. If you're interested in dropping partitions, you should look at the [DeleteSupport API proposal](https://github.com/apache/spark/pull/21308).","created_at":"2018-09-04T16:14:30Z","updated_at":"2018-09-04T16:14:30Z","html_url":"https://github.com/apache/spark/pull/21306#discussion_r214977998","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/21306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/214977998"},"html":{"href":"https://github.com/apache/spark/pull/21306#discussion_r214977998"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/21306"}},"in_reply_to_id":214808418},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21306","id":187572913,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NTcyOTEz","html_url":"https://github.com/apache/spark/pull/21306","diff_url":"https://github.com/apache/spark/pull/21306.diff","patch_url":"https://github.com/apache/spark/pull/21306.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/21306","number":21306,"state":"open","locked":false,"title":"[SPARK-24252][SQL] Add catalog registration and table catalog APIs.","user":{"login":"rdblue","id":87915,"node_id":"MDQ6VXNlcjg3OTE1","avatar_url":"https://avatars1.githubusercontent.com/u/87915?v=4","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis adds a v2 API for storage implementations to provide catalog instances to Spark. There are two parts:\r\n\r\n* `CatalogProvider` is used to instantiate and initialize catalogs via reflection, similar to data sources\r\n* `TableCatalog` provides table operations proposed in the [Table Metadata API SPIP](https://docs.google.com/document/d/1zLFiA1VuaWeVxeTDXNg8bL6GP3BVoOZBkewFtEnjEoo/edit#)\r\n\r\nThis also adds helper classes:\r\n\r\n* `Catalogs` loads and initializes catalogs using configuration from a `SQLConf`\r\n* `CaseInsensitiveStringMap` is used to pass configuration to `CatalogProvider` via `initialize`\r\n* `PartitionTransform` is used to pass table partitioning without using `Expression`\r\n\r\nCatalogs are configured by adding config properties starting with `spark.sql.catalog.(name)`. The name property must specify a class that implements `CatalogProvider`. Other properties under the namespace (`spark.sql.catalog.(name).(prop)`) are passed to the provider during initialization.\r\n\r\n## How was this patch tested?\r\n\r\nThis includes a suite for `CaseInsensitiveStringMap` and one that tests loading catalog providers.","created_at":"2018-05-11T21:21:56Z","updated_at":"2018-09-04T16:14:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e3bb66f1dec2281e4915628185964c9ed0ed0f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/21306/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/21306/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/21306/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/6b45a119df8e6382fa2503f854b4a85aed3e3785","head":{"label":"rdblue:SPARK-24252-add-datasource-v2-catalog","ref":"SPARK-24252-add-datasource-v2-catalog","sha":"6b45a119df8e6382fa2503f854b4a85aed3e3785","user":{"login":"rdblue","id":87915,"node_id":"MDQ6VXNlcjg3OTE1","avatar_url":"https://avatars1.githubusercontent.com/u/87915?v=4","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"repo":{"id":26284539,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI4NDUzOQ==","name":"spark","full_name":"rdblue/spark","owner":{"login":"rdblue","id":87915,"node_id":"MDQ6VXNlcjg3OTE1","avatar_url":"https://avatars1.githubusercontent.com/u/87915?v=4","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdblue/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/rdblue/spark","forks_url":"https://api.github.com/repos/rdblue/spark/forks","keys_url":"https://api.github.com/repos/rdblue/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdblue/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdblue/spark/teams","hooks_url":"https://api.github.com/repos/rdblue/spark/hooks","issue_events_url":"https://api.github.com/repos/rdblue/spark/issues/events{/number}","events_url":"https://api.github.com/repos/rdblue/spark/events","assignees_url":"https://api.github.com/repos/rdblue/spark/assignees{/user}","branches_url":"https://api.github.com/repos/rdblue/spark/branches{/branch}","tags_url":"https://api.github.com/repos/rdblue/spark/tags","blobs_url":"https://api.github.com/repos/rdblue/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdblue/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdblue/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdblue/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdblue/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/rdblue/spark/languages","stargazers_url":"https://api.github.com/repos/rdblue/spark/stargazers","contributors_url":"https://api.github.com/repos/rdblue/spark/contributors","subscribers_url":"https://api.github.com/repos/rdblue/spark/subscribers","subscription_url":"https://api.github.com/repos/rdblue/spark/subscription","commits_url":"https://api.github.com/repos/rdblue/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdblue/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdblue/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdblue/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdblue/spark/contents/{+path}","compare_url":"https://api.github.com/repos/rdblue/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdblue/spark/merges","archive_url":"https://api.github.com/repos/rdblue/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdblue/spark/downloads","issues_url":"https://api.github.com/repos/rdblue/spark/issues{/number}","pulls_url":"https://api.github.com/repos/rdblue/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/rdblue/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/rdblue/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdblue/spark/labels{/name}","releases_url":"https://api.github.com/repos/rdblue/spark/releases{/id}","deployments_url":"https://api.github.com/repos/rdblue/spark/deployments","created_at":"2014-11-06T18:50:45Z","updated_at":"2017-09-13T03:31:54Z","pushed_at":"2018-08-27T21:31:38Z","git_url":"git://github.com/rdblue/spark.git","ssh_url":"[email protected]:rdblue/spark.git","clone_url":"https://github.com/rdblue/spark.git","svn_url":"https://github.com/rdblue/spark","homepage":null,"size":256248,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ba84bcb2c4f73baf63782ff6fad5a607008c7cd2","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-09-04T14:28:00Z","pushed_at":"2018-09-04T15:46:44Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":280711,"stargazers_count":18638,"watchers_count":18638,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16820,"mirror_url":null,"archived":false,"open_issues_count":510,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16820,"open_issues":510,"watchers":18638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/21306"},"html":{"href":"https://github.com/apache/spark/pull/21306"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/21306"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/21306/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/21306/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/21306/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/6b45a119df8e6382fa2503f854b4a85aed3e3785"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 87915,
"login": "rdblue",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/87915?",
"url": "https://api.github.com/users/rdblue"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-09-04T16:14:30 | 8212410710 | {"actor":{"display_login":"rdblue"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/243486514","pull_request_review_id":187270584,"id":243486514,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ4NjUxNA==","diff_hunk":"@@ -2937,6 +2937,13 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {\n }\n }\n }\n+\n+ test(\"SPARK-26402: GetStructField with different names are semantically equal\") {\n+ withTable(\"t\") {\n+ sql(\"create table t (s struct<i: Int>) using json\")\n+ sql(\"select s.I from t group by s.i\")","path":"sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala","position":8,"original_position":8,"commit_id":"5273c3ccc7f7993cec67f807258c4e573bb55a0c","original_commit_id":"5273c3ccc7f7993cec67f807258c4e573bb55a0c","user":{"login":"viirya","id":68855,"node_id":"MDQ6VXNlcjY4ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/68855?v=4","gravatar_id":"","url":"https://api.github.com/users/viirya","html_url":"https://github.com/viirya","followers_url":"https://api.github.com/users/viirya/followers","following_url":"https://api.github.com/users/viirya/following{/other_user}","gists_url":"https://api.github.com/users/viirya/gists{/gist_id}","starred_url":"https://api.github.com/users/viirya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viirya/subscriptions","organizations_url":"https://api.github.com/users/viirya/orgs","repos_url":"https://api.github.com/users/viirya/repos","events_url":"https://api.github.com/users/viirya/events{/privacy}","received_events_url":"https://api.github.com/users/viirya/received_events","type":"User","site_admin":false},"body":"Yes, that's better.","created_at":"2018-12-21T04:38:40Z","updated_at":"2018-12-21T04:38:40Z","html_url":"https://github.com/apache/spark/pull/23353#discussion_r243486514","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/23353","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/243486514"},"html":{"href":"https://github.com/apache/spark/pull/23353#discussion_r243486514"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/23353"}},"in_reply_to_id":243472667},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/23353","id":239935951,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTM1OTUx","html_url":"https://github.com/apache/spark/pull/23353","diff_url":"https://github.com/apache/spark/pull/23353.diff","patch_url":"https://github.com/apache/spark/pull/23353.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/23353","number":23353,"state":"open","locked":false,"title":"[SPARK-26402][SQL] Canonicalization on GetStructField ","user":{"login":"dbtsai","id":1134574,"node_id":"MDQ6VXNlcjExMzQ1NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134574?v=4","gravatar_id":"","url":"https://api.github.com/users/dbtsai","html_url":"https://github.com/dbtsai","followers_url":"https://api.github.com/users/dbtsai/followers","following_url":"https://api.github.com/users/dbtsai/following{/other_user}","gists_url":"https://api.github.com/users/dbtsai/gists{/gist_id}","starred_url":"https://api.github.com/users/dbtsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbtsai/subscriptions","organizations_url":"https://api.github.com/users/dbtsai/orgs","repos_url":"https://api.github.com/users/dbtsai/repos","events_url":"https://api.github.com/users/dbtsai/events{/privacy}","received_events_url":"https://api.github.com/users/dbtsai/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nGetStructField with different optional names should be semantically equal. We will use this as building block to compare the nested fields used in the plans to be optimized by catalyst optimizer.\r\n\r\nThis PR also fixes a bug below coincidentally\r\n```\r\nsql(\"create table t (s struct<i: Int>) using json\")\r\nsql(\"select s.I from t group by s.i\")\r\n```\r\nwhich is currently failing\r\n```\r\norg.apache.spark.sql.AnalysisException: expression 'default.t.`s`' is neither present in the group by, nor is it an aggregate function\r\n```\r\nas @cloud-fan pointed out.\r\n\r\n## How was this patch tested?\r\n\r\nNew tests are added.","created_at":"2018-12-19T18:38:33Z","updated_at":"2018-12-21T04:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e785ff7c4dd449f8fc3f3ee382fb5a44293fe441","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/23353/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/23353/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/23353/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/5273c3ccc7f7993cec67f807258c4e573bb55a0c","head":{"label":"dbtsai:nestedEqual","ref":"nestedEqual","sha":"5273c3ccc7f7993cec67f807258c4e573bb55a0c","user":{"login":"dbtsai","id":1134574,"node_id":"MDQ6VXNlcjExMzQ1NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134574?v=4","gravatar_id":"","url":"https://api.github.com/users/dbtsai","html_url":"https://github.com/dbtsai","followers_url":"https://api.github.com/users/dbtsai/followers","following_url":"https://api.github.com/users/dbtsai/following{/other_user}","gists_url":"https://api.github.com/users/dbtsai/gists{/gist_id}","starred_url":"https://api.github.com/users/dbtsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbtsai/subscriptions","organizations_url":"https://api.github.com/users/dbtsai/orgs","repos_url":"https://api.github.com/users/dbtsai/repos","events_url":"https://api.github.com/users/dbtsai/events{/privacy}","received_events_url":"https://api.github.com/users/dbtsai/received_events","type":"User","site_admin":false},"repo":{"id":34716514,"node_id":"MDEwOlJlcG9zaXRvcnkzNDcxNjUxNA==","name":"spark","full_name":"dbtsai/spark","private":false,"owner":{"login":"dbtsai","id":1134574,"node_id":"MDQ6VXNlcjExMzQ1NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134574?v=4","gravatar_id":"","url":"https://api.github.com/users/dbtsai","html_url":"https://github.com/dbtsai","followers_url":"https://api.github.com/users/dbtsai/followers","following_url":"https://api.github.com/users/dbtsai/following{/other_user}","gists_url":"https://api.github.com/users/dbtsai/gists{/gist_id}","starred_url":"https://api.github.com/users/dbtsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbtsai/subscriptions","organizations_url":"https://api.github.com/users/dbtsai/orgs","repos_url":"https://api.github.com/users/dbtsai/repos","events_url":"https://api.github.com/users/dbtsai/events{/privacy}","received_events_url":"https://api.github.com/users/dbtsai/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dbtsai/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/dbtsai/spark","forks_url":"https://api.github.com/repos/dbtsai/spark/forks","keys_url":"https://api.github.com/repos/dbtsai/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbtsai/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbtsai/spark/teams","hooks_url":"https://api.github.com/repos/dbtsai/spark/hooks","issue_events_url":"https://api.github.com/repos/dbtsai/spark/issues/events{/number}","events_url":"https://api.github.com/repos/dbtsai/spark/events","assignees_url":"https://api.github.com/repos/dbtsai/spark/assignees{/user}","branches_url":"https://api.github.com/repos/dbtsai/spark/branches{/branch}","tags_url":"https://api.github.com/repos/dbtsai/spark/tags","blobs_url":"https://api.github.com/repos/dbtsai/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbtsai/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbtsai/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbtsai/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbtsai/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/dbtsai/spark/languages","stargazers_url":"https://api.github.com/repos/dbtsai/spark/stargazers","contributors_url":"https://api.github.com/repos/dbtsai/spark/contributors","subscribers_url":"https://api.github.com/repos/dbtsai/spark/subscribers","subscription_url":"https://api.github.com/repos/dbtsai/spark/subscription","commits_url":"https://api.github.com/repos/dbtsai/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbtsai/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbtsai/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbtsai/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbtsai/spark/contents/{+path}","compare_url":"https://api.github.com/repos/dbtsai/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbtsai/spark/merges","archive_url":"https://api.github.com/repos/dbtsai/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbtsai/spark/downloads","issues_url":"https://api.github.com/repos/dbtsai/spark/issues{/number}","pulls_url":"https://api.github.com/repos/dbtsai/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/dbtsai/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/dbtsai/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbtsai/spark/labels{/name}","releases_url":"https://api.github.com/repos/dbtsai/spark/releases{/id}","deployments_url":"https://api.github.com/repos/dbtsai/spark/deployments","created_at":"2015-04-28T07:50:55Z","updated_at":"2018-11-07T22:45:43Z","pushed_at":"2018-12-20T23:43:14Z","git_url":"git://github.com/dbtsai/spark.git","ssh_url":"[email protected]:dbtsai/spark.git","clone_url":"https://github.com/dbtsai/spark.git","svn_url":"https://github.com/dbtsai/spark","homepage":null,"size":273491,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"aa0d4ca8bab08a467645080a5b8a28bf6dd8a042","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-12-21T03:59:43Z","pushed_at":"2018-12-21T03:12:38Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":"","size":289752,"stargazers_count":19960,"watchers_count":19960,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17755,"mirror_url":null,"archived":false,"open_issues_count":461,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17755,"open_issues":461,"watchers":19960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/23353"},"html":{"href":"https://github.com/apache/spark/pull/23353"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/23353"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/23353/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/23353/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/23353/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/5273c3ccc7f7993cec67f807258c4e573bb55a0c"}},"author_association":"MEMBER"}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 68855,
"login": "viirya",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/68855?",
"url": "https://api.github.com/users/viirya"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-12-21T04:38:40 | 8789590931 | {"actor":{"display_login":"viirya"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/182870720","pull_request_review_id":113759777,"id":182870720,"diff_hunk":"@@ -2820,6 +2821,7 @@ public long getMemoryOrCpuCapacityByHost(final Long hostId, final short capacity\n cmdList.add(CreateSnapshotCmd.class);\n cmdList.add(CreateSnapshotFromVMSnapshotCmd.class);\n cmdList.add(DeleteSnapshotCmd.class);\n+ cmdList.add(ArchiveSnapshotCmd.class);","path":"server/src/main/java/com/cloud/server/ManagementServerImpl.java","position":12,"original_position":12,"commit_id":"a2dd376290f34fa4365321c888391dc7e97f0fa0","original_commit_id":"a2dd376290f34fa4365321c888391dc7e97f0fa0","user":{"login":"khos2ow","id":372575,"avatar_url":"https://avatars3.githubusercontent.com/u/372575?v=4","gravatar_id":"","url":"https://api.github.com/users/khos2ow","html_url":"https://github.com/khos2ow","followers_url":"https://api.github.com/users/khos2ow/followers","following_url":"https://api.github.com/users/khos2ow/following{/other_user}","gists_url":"https://api.github.com/users/khos2ow/gists{/gist_id}","starred_url":"https://api.github.com/users/khos2ow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khos2ow/subscriptions","organizations_url":"https://api.github.com/users/khos2ow/orgs","repos_url":"https://api.github.com/users/khos2ow/repos","events_url":"https://api.github.com/users/khos2ow/events{/privacy}","received_events_url":"https://api.github.com/users/khos2ow/received_events","type":"User","site_admin":false},"body":"@syed I believe you forgot to commit `ArchiveSnapshotCmd` itself!","created_at":"2018-04-19T20:13:22Z","updated_at":"2018-04-19T20:13:33Z","html_url":"https://github.com/apache/cloudstack/pull/2585#discussion_r182870720","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/2585","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/182870720"},"html":{"href":"https://github.com/apache/cloudstack/pull/2585#discussion_r182870720"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2585"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/2585","id":182814027,"html_url":"https://github.com/apache/cloudstack/pull/2585","diff_url":"https://github.com/apache/cloudstack/pull/2585.diff","patch_url":"https://github.com/apache/cloudstack/pull/2585.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/2585","number":2585,"state":"open","locked":false,"title":"Add ability to archive snapshots on primary storage","user":{"login":"syed","id":55854,"avatar_url":"https://avatars1.githubusercontent.com/u/55854?v=4","gravatar_id":"","url":"https://api.github.com/users/syed","html_url":"https://github.com/syed","followers_url":"https://api.github.com/users/syed/followers","following_url":"https://api.github.com/users/syed/following{/other_user}","gists_url":"https://api.github.com/users/syed/gists{/gist_id}","starred_url":"https://api.github.com/users/syed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syed/subscriptions","organizations_url":"https://api.github.com/users/syed/orgs","repos_url":"https://api.github.com/users/syed/repos","events_url":"https://api.github.com/users/syed/events{/privacy}","received_events_url":"https://api.github.com/users/syed/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR adds an API call named `archiveSnapshot` which takes in a snapshot residing on primary storage and moves it to secondary storage. The main use case for this relates to the use in Managed storage where the storage supports native snapshots. Because of cost and availability reasons, it is useful to move snapshots that are taken on primary storage (native snapshots) to secondary storage. \r\n\r\nThe API takes in a `snapshotid` , creates a new snapshot on secondary storage and deletes the snapshot on primary storage. \r\n\r\n<!-- For new features, provide link to FS, dev ML discussion etc. -->\r\n<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Enhancement (improves an existing feature and functionality)\r\n- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)\r\n\r\n## GitHub Issue/PRs\r\n<!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->\r\n<!-- When \"Fixes: #<id>\" is specified, the issue/PR will automatically be closed when this PR gets merged -->\r\n<!-- For addressing multiple issues/PRs, use multiple \"Fixes: #<id>\" -->\r\n\r\n<!-- Fixes: # -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## How Has This Been Tested?\r\n\r\nTested on a local storage cluster (SolidFire) and also added unit tests.\r\n\r\n<!-- Please describe in detail how you tested your changes. -->\r\n<!-- Include details of your testing environment, and the tests you ran to -->\r\n<!-- see how your change affects other areas of the code, etc. -->\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.\r\n- [ x ] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\nTesting\r\n- [x] I have added tests to cover my changes.\r\n- [ ] All relevant new and existing integration tests have passed.\r\n- [ ] A full integration testsuite with all test that can run on my environment has passed.\r\n\r\n<!-- The following will kick a packaging job, remove if as applicable -->\r\n@blueorangutan package\r\n","created_at":"2018-04-19T15:27:44Z","updated_at":"2018-04-19T20:13:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c675c719fa18e94bcb03912761e40900a93d539","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/2585/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/2585/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/2585/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/a2dd376290f34fa4365321c888391dc7e97f0fa0","head":{"label":"syed:upstream-snapshot-archive","ref":"upstream-snapshot-archive","sha":"a2dd376290f34fa4365321c888391dc7e97f0fa0","user":{"login":"syed","id":55854,"avatar_url":"https://avatars1.githubusercontent.com/u/55854?v=4","gravatar_id":"","url":"https://api.github.com/users/syed","html_url":"https://github.com/syed","followers_url":"https://api.github.com/users/syed/followers","following_url":"https://api.github.com/users/syed/following{/other_user}","gists_url":"https://api.github.com/users/syed/gists{/gist_id}","starred_url":"https://api.github.com/users/syed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syed/subscriptions","organizations_url":"https://api.github.com/users/syed/orgs","repos_url":"https://api.github.com/users/syed/repos","events_url":"https://api.github.com/users/syed/events{/privacy}","received_events_url":"https://api.github.com/users/syed/received_events","type":"User","site_admin":false},"repo":{"id":46741864,"name":"cloudstack","full_name":"syed/cloudstack","owner":{"login":"syed","id":55854,"avatar_url":"https://avatars1.githubusercontent.com/u/55854?v=4","gravatar_id":"","url":"https://api.github.com/users/syed","html_url":"https://github.com/syed","followers_url":"https://api.github.com/users/syed/followers","following_url":"https://api.github.com/users/syed/following{/other_user}","gists_url":"https://api.github.com/users/syed/gists{/gist_id}","starred_url":"https://api.github.com/users/syed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syed/subscriptions","organizations_url":"https://api.github.com/users/syed/orgs","repos_url":"https://api.github.com/users/syed/repos","events_url":"https://api.github.com/users/syed/events{/privacy}","received_events_url":"https://api.github.com/users/syed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syed/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/syed/cloudstack","forks_url":"https://api.github.com/repos/syed/cloudstack/forks","keys_url":"https://api.github.com/repos/syed/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syed/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syed/cloudstack/teams","hooks_url":"https://api.github.com/repos/syed/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/syed/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/syed/cloudstack/events","assignees_url":"https://api.github.com/repos/syed/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/syed/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/syed/cloudstack/tags","blobs_url":"https://api.github.com/repos/syed/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syed/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syed/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/syed/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syed/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/syed/cloudstack/languages","stargazers_url":"https://api.github.com/repos/syed/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/syed/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/syed/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/syed/cloudstack/subscription","commits_url":"https://api.github.com/repos/syed/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/syed/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/syed/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/syed/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/syed/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/syed/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syed/cloudstack/merges","archive_url":"https://api.github.com/repos/syed/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syed/cloudstack/downloads","issues_url":"https://api.github.com/repos/syed/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/syed/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/syed/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/syed/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syed/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/syed/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/syed/cloudstack/deployments","created_at":"2015-11-23T19:08:38Z","updated_at":"2016-04-05T20:47:31Z","pushed_at":"2018-04-19T15:22:09Z","git_url":"git://github.com/syed/cloudstack.git","ssh_url":"[email protected]:syed/cloudstack.git","clone_url":"https://github.com/syed/cloudstack.git","svn_url":"https://github.com/syed/cloudstack","homepage":null,"size":527128,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"15afc35ff978bcedb05d0a0673f8bac9ac49743a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cloudstack/deployments","created_at":"2013-04-29T22:27:12Z","updated_at":"2018-04-19T19:25:14Z","pushed_at":"2018-04-19T19:57:11Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"[email protected]:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":522610,"stargazers_count":555,"watchers_count":555,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":628,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":628,"open_issues":136,"watchers":555,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2585"},"html":{"href":"https://github.com/apache/cloudstack/pull/2585"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/2585"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/2585/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2585/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2585/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/a2dd376290f34fa4365321c888391dc7e97f0fa0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 9759448,
"name": "apache/cloudstack",
"url": "https://api.github.com/repos/apache/cloudstack"
} | {
"id": 372575,
"login": "khos2ow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/372575?",
"url": "https://api.github.com/users/khos2ow"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-04-19T20:13:22 | 7557879414 | {"actor":{"display_login":"khos2ow"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/ignite/pulls/comments/172191897","pull_request_review_id":101165853,"id":172191897,"diff_hunk":"@@ -9438,14 +9438,40 @@ public static int capacity(int expSize) {\n }\n \n /**\n- * @param col non-null collection with one element\n- * @return a SingletonList containing the element in the original collection\n+ * Returns an immutable map if argument is singleton mutable map,\n+ * otherwise returns argument.\n+ *\n+ * @param map map\n+ * @param <K> type of map keys\n+ * @param <V> type of map values\n+ * @return argument or singleton map\n */\n- public static <T> Collection<T> convertToSingletonList(Collection<T> col) {\n- if (col.size() != 1) {\n- throw new IllegalArgumentException(\"Unexpected collection size for singleton list, expecting 1 but was: \" + col.size());\n+ public static <K,V> Map<K,V> unwrapSingletonMap(Map<K,V> map) {\n+ if(map instanceof MutableSingletonMap){\n+ return ((MutableSingletonMap<K,V>)map).singletonMap();","path":"modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java","position":19,"original_position":19,"commit_id":"7e83bee2a7039b1cd176870df13318555706d475","original_commit_id":"7e83bee2a7039b1cd176870df13318555706d475","user":{"login":"dspavlov","id":27953002,"avatar_url":"https://avatars2.githubusercontent.com/u/27953002?v=4","gravatar_id":"","url":"https://api.github.com/users/dspavlov","html_url":"https://github.com/dspavlov","followers_url":"https://api.github.com/users/dspavlov/followers","following_url":"https://api.github.com/users/dspavlov/following{/other_user}","gists_url":"https://api.github.com/users/dspavlov/gists{/gist_id}","starred_url":"https://api.github.com/users/dspavlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dspavlov/subscriptions","organizations_url":"https://api.github.com/users/dspavlov/orgs","repos_url":"https://api.github.com/users/dspavlov/repos","events_url":"https://api.github.com/users/dspavlov/events{/privacy}","received_events_url":"https://api.github.com/users/dspavlov/received_events","type":"User","site_admin":false},"body":"no braces {} needed for single line if","created_at":"2018-03-05T13:50:46Z","updated_at":"2018-03-05T13:50:46Z","html_url":"https://github.com/apache/ignite/pull/3534#discussion_r172191897","pull_request_url":"https://api.github.com/repos/apache/ignite/pulls/3534","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/ignite/pulls/comments/172191897"},"html":{"href":"https://github.com/apache/ignite/pull/3534#discussion_r172191897"},"pull_request":{"href":"https://api.github.com/repos/apache/ignite/pulls/3534"}}},"pull_request":{"url":"https://api.github.com/repos/apache/ignite/pulls/3534","id":169612580,"html_url":"https://github.com/apache/ignite/pull/3534","diff_url":"https://github.com/apache/ignite/pull/3534.diff","patch_url":"https://github.com/apache/ignite/pull/3534.patch","issue_url":"https://api.github.com/repos/apache/ignite/issues/3534","number":3534,"state":"open","locked":false,"title":"IGNITE-7718 Fixed deserialization of binary objects in singleton map …","user":{"login":"pvinokurov","id":13932611,"avatar_url":"https://avatars3.githubusercontent.com/u/13932611?v=4","gravatar_id":"","url":"https://api.github.com/users/pvinokurov","html_url":"https://github.com/pvinokurov","followers_url":"https://api.github.com/users/pvinokurov/followers","following_url":"https://api.github.com/users/pvinokurov/following{/other_user}","gists_url":"https://api.github.com/users/pvinokurov/gists{/gist_id}","starred_url":"https://api.github.com/users/pvinokurov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvinokurov/subscriptions","organizations_url":"https://api.github.com/users/pvinokurov/orgs","repos_url":"https://api.github.com/users/pvinokurov/repos","events_url":"https://api.github.com/users/pvinokurov/events{/privacy}","received_events_url":"https://api.github.com/users/pvinokurov/received_events","type":"User","site_admin":false},"body":"…and set.","created_at":"2018-02-16T12:27:51Z","updated_at":"2018-03-05T13:50:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"361c72072fc92717329b2f63624da5b68aa4e5be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/ignite/pulls/3534/commits","review_comments_url":"https://api.github.com/repos/apache/ignite/pulls/3534/comments","review_comment_url":"https://api.github.com/repos/apache/ignite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/ignite/issues/3534/comments","statuses_url":"https://api.github.com/repos/apache/ignite/statuses/7e83bee2a7039b1cd176870df13318555706d475","head":{"label":"gridgain:ignite-7718","ref":"ignite-7718","sha":"7e83bee2a7039b1cd176870df13318555706d475","user":{"login":"gridgain","id":803592,"avatar_url":"https://avatars3.githubusercontent.com/u/803592?v=4","gravatar_id":"","url":"https://api.github.com/users/gridgain","html_url":"https://github.com/gridgain","followers_url":"https://api.github.com/users/gridgain/followers","following_url":"https://api.github.com/users/gridgain/following{/other_user}","gists_url":"https://api.github.com/users/gridgain/gists{/gist_id}","starred_url":"https://api.github.com/users/gridgain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridgain/subscriptions","organizations_url":"https://api.github.com/users/gridgain/orgs","repos_url":"https://api.github.com/users/gridgain/repos","events_url":"https://api.github.com/users/gridgain/events{/privacy}","received_events_url":"https://api.github.com/users/gridgain/received_events","type":"Organization","site_admin":false},"repo":{"id":32432793,"name":"apache-ignite","full_name":"gridgain/apache-ignite","owner":{"login":"gridgain","id":803592,"avatar_url":"https://avatars3.githubusercontent.com/u/803592?v=4","gravatar_id":"","url":"https://api.github.com/users/gridgain","html_url":"https://github.com/gridgain","followers_url":"https://api.github.com/users/gridgain/followers","following_url":"https://api.github.com/users/gridgain/following{/other_user}","gists_url":"https://api.github.com/users/gridgain/gists{/gist_id}","starred_url":"https://api.github.com/users/gridgain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridgain/subscriptions","organizations_url":"https://api.github.com/users/gridgain/orgs","repos_url":"https://api.github.com/users/gridgain/repos","events_url":"https://api.github.com/users/gridgain/events{/privacy}","received_events_url":"https://api.github.com/users/gridgain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gridgain/apache-ignite","description":"Mirror of Apache Ignite","fork":true,"url":"https://api.github.com/repos/gridgain/apache-ignite","forks_url":"https://api.github.com/repos/gridgain/apache-ignite/forks","keys_url":"https://api.github.com/repos/gridgain/apache-ignite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gridgain/apache-ignite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gridgain/apache-ignite/teams","hooks_url":"https://api.github.com/repos/gridgain/apache-ignite/hooks","issue_events_url":"https://api.github.com/repos/gridgain/apache-ignite/issues/events{/number}","events_url":"https://api.github.com/repos/gridgain/apache-ignite/events","assignees_url":"https://api.github.com/repos/gridgain/apache-ignite/assignees{/user}","branches_url":"https://api.github.com/repos/gridgain/apache-ignite/branches{/branch}","tags_url":"https://api.github.com/repos/gridgain/apache-ignite/tags","blobs_url":"https://api.github.com/repos/gridgain/apache-ignite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gridgain/apache-ignite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gridgain/apache-ignite/git/refs{/sha}","trees_url":"https://api.github.com/repos/gridgain/apache-ignite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gridgain/apache-ignite/statuses/{sha}","languages_url":"https://api.github.com/repos/gridgain/apache-ignite/languages","stargazers_url":"https://api.github.com/repos/gridgain/apache-ignite/stargazers","contributors_url":"https://api.github.com/repos/gridgain/apache-ignite/contributors","subscribers_url":"https://api.github.com/repos/gridgain/apache-ignite/subscribers","subscription_url":"https://api.github.com/repos/gridgain/apache-ignite/subscription","commits_url":"https://api.github.com/repos/gridgain/apache-ignite/commits{/sha}","git_commits_url":"https://api.github.com/repos/gridgain/apache-ignite/git/commits{/sha}","comments_url":"https://api.github.com/repos/gridgain/apache-ignite/comments{/number}","issue_comment_url":"https://api.github.com/repos/gridgain/apache-ignite/issues/comments{/number}","contents_url":"https://api.github.com/repos/gridgain/apache-ignite/contents/{+path}","compare_url":"https://api.github.com/repos/gridgain/apache-ignite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gridgain/apache-ignite/merges","archive_url":"https://api.github.com/repos/gridgain/apache-ignite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gridgain/apache-ignite/downloads","issues_url":"https://api.github.com/repos/gridgain/apache-ignite/issues{/number}","pulls_url":"https://api.github.com/repos/gridgain/apache-ignite/pulls{/number}","milestones_url":"https://api.github.com/repos/gridgain/apache-ignite/milestones{/number}","notifications_url":"https://api.github.com/repos/gridgain/apache-ignite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gridgain/apache-ignite/labels{/name}","releases_url":"https://api.github.com/repos/gridgain/apache-ignite/releases{/id}","deployments_url":"https://api.github.com/repos/gridgain/apache-ignite/deployments","created_at":"2015-03-18T02:19:44Z","updated_at":"2018-02-14T11:43:58Z","pushed_at":"2018-03-05T13:37:50Z","git_url":"git://github.com/gridgain/apache-ignite.git","ssh_url":"[email protected]:gridgain/apache-ignite.git","clone_url":"https://github.com/gridgain/apache-ignite.git","svn_url":"https://github.com/gridgain/apache-ignite","homepage":"","size":314067,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":14,"watchers":17,"default_branch":"sprint-2"}},"base":{"label":"apache:master","ref":"master","sha":"4e86660dc95e32797cf8a4eb2fa2d38e09934643","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":31006158,"name":"ignite","full_name":"apache/ignite","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/ignite","description":"Mirror of Apache Ignite","fork":false,"url":"https://api.github.com/repos/apache/ignite","forks_url":"https://api.github.com/repos/apache/ignite/forks","keys_url":"https://api.github.com/repos/apache/ignite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/ignite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/ignite/teams","hooks_url":"https://api.github.com/repos/apache/ignite/hooks","issue_events_url":"https://api.github.com/repos/apache/ignite/issues/events{/number}","events_url":"https://api.github.com/repos/apache/ignite/events","assignees_url":"https://api.github.com/repos/apache/ignite/assignees{/user}","branches_url":"https://api.github.com/repos/apache/ignite/branches{/branch}","tags_url":"https://api.github.com/repos/apache/ignite/tags","blobs_url":"https://api.github.com/repos/apache/ignite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/ignite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/ignite/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/ignite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/ignite/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/ignite/languages","stargazers_url":"https://api.github.com/repos/apache/ignite/stargazers","contributors_url":"https://api.github.com/repos/apache/ignite/contributors","subscribers_url":"https://api.github.com/repos/apache/ignite/subscribers","subscription_url":"https://api.github.com/repos/apache/ignite/subscription","commits_url":"https://api.github.com/repos/apache/ignite/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/ignite/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/ignite/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/ignite/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/ignite/contents/{+path}","compare_url":"https://api.github.com/repos/apache/ignite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/ignite/merges","archive_url":"https://api.github.com/repos/apache/ignite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/ignite/downloads","issues_url":"https://api.github.com/repos/apache/ignite/issues{/number}","pulls_url":"https://api.github.com/repos/apache/ignite/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/ignite/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/ignite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/ignite/labels{/name}","releases_url":"https://api.github.com/repos/apache/ignite/releases{/id}","deployments_url":"https://api.github.com/repos/apache/ignite/deployments","created_at":"2015-02-19T08:00:05Z","updated_at":"2018-03-04T20:17:44Z","pushed_at":"2018-03-05T13:37:52Z","git_url":"git://github.com/apache/ignite.git","ssh_url":"[email protected]:apache/ignite.git","clone_url":"https://github.com/apache/ignite.git","svn_url":"https://github.com/apache/ignite","homepage":"","size":261120,"stargazers_count":1527,"watchers_count":1527,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":857,"mirror_url":null,"archived":false,"open_issues_count":1009,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":857,"open_issues":1009,"watchers":1527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/ignite/pulls/3534"},"html":{"href":"https://github.com/apache/ignite/pull/3534"},"issue":{"href":"https://api.github.com/repos/apache/ignite/issues/3534"},"comments":{"href":"https://api.github.com/repos/apache/ignite/issues/3534/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/ignite/pulls/3534/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/ignite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/ignite/pulls/3534/commits"},"statuses":{"href":"https://api.github.com/repos/apache/ignite/statuses/7e83bee2a7039b1cd176870df13318555706d475"}},"author_association":"CONTRIBUTOR"}} | {
"id": 31006158,
"name": "apache/ignite",
"url": "https://api.github.com/repos/apache/ignite"
} | {
"id": 27953002,
"login": "dspavlov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27953002?",
"url": "https://api.github.com/users/dspavlov"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-03-05T13:50:46 | 7331535558 | {"actor":{"display_login":"dspavlov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/190024351","pull_request_review_id":122280843,"id":190024351,"diff_hunk":"@@ -353,7 +354,12 @@ public void verifyHeartbeatSent() throws Exception {\n // initial fetch\n client.prepareResponseFrom(fetchResponse(tp0, 0, 0), node);\n \n- consumer.poll(0);\n+ // We need two update calls:\n+ // 1. the first call \"sends\" the metadata update requests\n+ // 2. the second one gets the response we already queued up\n+ consumer.internalUpdateAssignmentMetadataIfNeeded(Duration.ZERO);\n+ consumer.internalUpdateAssignmentMetadataIfNeeded(Duration.ZERO);\n+","path":"clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java","position":18,"original_position":18,"commit_id":"b5ce2e2c8e372aeded9e2f1cad97570361a90af6","original_commit_id":"b5ce2e2c8e372aeded9e2f1cad97570361a90af6","user":{"login":"vvcephei","id":832787,"avatar_url":"https://avatars0.githubusercontent.com/u/832787?v=4","gravatar_id":"","url":"https://api.github.com/users/vvcephei","html_url":"https://github.com/vvcephei","followers_url":"https://api.github.com/users/vvcephei/followers","following_url":"https://api.github.com/users/vvcephei/following{/other_user}","gists_url":"https://api.github.com/users/vvcephei/gists{/gist_id}","starred_url":"https://api.github.com/users/vvcephei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvcephei/subscriptions","organizations_url":"https://api.github.com/users/vvcephei/orgs","repos_url":"https://api.github.com/users/vvcephei/repos","events_url":"https://api.github.com/users/vvcephei/events{/privacy}","received_events_url":"https://api.github.com/users/vvcephei/received_events","type":"User","site_admin":false},"body":"I hope that comment makes sense. Alternatively, we could use one call with a non-zero timeout (such as 1ms), but I liked the double async call, since it seems to be a tighter bound on the behavior.","created_at":"2018-05-22T19:27:48Z","updated_at":"2018-05-22T19:35:30Z","html_url":"https://github.com/apache/kafka/pull/4855#discussion_r190024351","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4855","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/190024351"},"html":{"href":"https://github.com/apache/kafka/pull/4855#discussion_r190024351"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4855"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4855","id":181059339,"html_url":"https://github.com/apache/kafka/pull/4855","diff_url":"https://github.com/apache/kafka/pull/4855.diff","patch_url":"https://github.com/apache/kafka/pull/4855.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4855","number":4855,"state":"open","locked":false,"title":"KAFKA-5697: prevent poll() from blocking forever","user":{"login":"vvcephei","id":832787,"avatar_url":"https://avatars0.githubusercontent.com/u/832787?v=4","gravatar_id":"","url":"https://api.github.com/users/vvcephei","html_url":"https://github.com/vvcephei","followers_url":"https://api.github.com/users/vvcephei/followers","following_url":"https://api.github.com/users/vvcephei/following{/other_user}","gists_url":"https://api.github.com/users/vvcephei/gists{/gist_id}","starred_url":"https://api.github.com/users/vvcephei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvcephei/subscriptions","organizations_url":"https://api.github.com/users/vvcephei/orgs","repos_url":"https://api.github.com/users/vvcephei/repos","events_url":"https://api.github.com/users/vvcephei/events{/privacy}","received_events_url":"https://api.github.com/users/vvcephei/received_events","type":"User","site_admin":false},"body":"Add the new stricter-timeout version of `poll` proposed in KIP-266.\r\n\r\nThe pre-existing variant `poll(long timeout)` would block indefinitely for metadata\r\nupdates if they were needed, then it would issue a fetch and poll for `timeout` ms \r\nfor new records. The initial indefinite metadata block caused applications to become\r\nstuck when the brokers became unavailable. The existence of the timeout parameter\r\nmade the indefinite block especially unintuitive.\r\n\r\nThis PR adds `poll(Duration timeout)` with the semantics:\r\n1. iff a metadata update is needed:\r\n 1. send (asynchronous) metadata requests\r\n 2. poll for metadata responses (counts against timeout)\r\n - if no response within timeout, **return an empty collection immediately**\r\n2. if there is fetch data available, **return it immediately**\r\n3. if there is no fetch request in flight, send fetch requests\r\n4. poll for fetch responses (counts against timeout)\r\n - if no response within timeout, **return an empty collection** (leaving async fetch request for the next poll)\r\n - if we get a response, **return the response**\r\n\r\nThe old method, `poll(long timeout)` is deprecated, but we do not change its semantics, so it remains:\r\n1. iff a metadata update is needed:\r\n 1. send (asynchronous) metadata requests\r\n 2. poll for metadata responses *indefinitely until we get it*\r\n2. if there is fetch data available, **return it immediately**\r\n3. if there is no fetch request in flight, send fetch requests\r\n4. poll for fetch responses (counts against timeout)\r\n - if no response within timeout, **return an empty collection** (leaving async fetch request for the next poll)\r\n - if we get a response, **return the response**\r\n\r\nOne notable usage is prohibited by the new `poll`: previously, you could call `poll(0)` to block for metadata updates, for example to initialize the client, supposedly without fetching records. Note, though, that this behavior is not according to any contract, and there is no guarantee that `poll(0)` won't return records the first time it's called. Therefore, it has always been unsafe to ignore the response.\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-04-12T00:07:11Z","updated_at":"2018-05-22T19:35:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"731acc445c1d9588b187f4c670e67f833515938b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mjsax","id":8959638,"avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},{"login":"hachikuji","id":12502538,"avatar_url":"https://avatars3.githubusercontent.com/u/12502538?v=4","gravatar_id":"","url":"https://api.github.com/users/hachikuji","html_url":"https://github.com/hachikuji","followers_url":"https://api.github.com/users/hachikuji/followers","following_url":"https://api.github.com/users/hachikuji/following{/other_user}","gists_url":"https://api.github.com/users/hachikuji/gists{/gist_id}","starred_url":"https://api.github.com/users/hachikuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachikuji/subscriptions","organizations_url":"https://api.github.com/users/hachikuji/orgs","repos_url":"https://api.github.com/users/hachikuji/repos","events_url":"https://api.github.com/users/hachikuji/events{/privacy}","received_events_url":"https://api.github.com/users/hachikuji/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4855/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4855/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4855/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/b5ce2e2c8e372aeded9e2f1cad97570361a90af6","head":{"label":"vvcephei:kafka-5697-stream-thread-shutdown","ref":"kafka-5697-stream-thread-shutdown","sha":"b5ce2e2c8e372aeded9e2f1cad97570361a90af6","user":{"login":"vvcephei","id":832787,"avatar_url":"https://avatars0.githubusercontent.com/u/832787?v=4","gravatar_id":"","url":"https://api.github.com/users/vvcephei","html_url":"https://github.com/vvcephei","followers_url":"https://api.github.com/users/vvcephei/followers","following_url":"https://api.github.com/users/vvcephei/following{/other_user}","gists_url":"https://api.github.com/users/vvcephei/gists{/gist_id}","starred_url":"https://api.github.com/users/vvcephei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvcephei/subscriptions","organizations_url":"https://api.github.com/users/vvcephei/orgs","repos_url":"https://api.github.com/users/vvcephei/repos","events_url":"https://api.github.com/users/vvcephei/events{/privacy}","received_events_url":"https://api.github.com/users/vvcephei/received_events","type":"User","site_admin":false},"repo":{"id":124139257,"name":"kafka","full_name":"vvcephei/kafka","owner":{"login":"vvcephei","id":832787,"avatar_url":"https://avatars0.githubusercontent.com/u/832787?v=4","gravatar_id":"","url":"https://api.github.com/users/vvcephei","html_url":"https://github.com/vvcephei","followers_url":"https://api.github.com/users/vvcephei/followers","following_url":"https://api.github.com/users/vvcephei/following{/other_user}","gists_url":"https://api.github.com/users/vvcephei/gists{/gist_id}","starred_url":"https://api.github.com/users/vvcephei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvcephei/subscriptions","organizations_url":"https://api.github.com/users/vvcephei/orgs","repos_url":"https://api.github.com/users/vvcephei/repos","events_url":"https://api.github.com/users/vvcephei/events{/privacy}","received_events_url":"https://api.github.com/users/vvcephei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vvcephei/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/vvcephei/kafka","forks_url":"https://api.github.com/repos/vvcephei/kafka/forks","keys_url":"https://api.github.com/repos/vvcephei/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvcephei/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvcephei/kafka/teams","hooks_url":"https://api.github.com/repos/vvcephei/kafka/hooks","issue_events_url":"https://api.github.com/repos/vvcephei/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/vvcephei/kafka/events","assignees_url":"https://api.github.com/repos/vvcephei/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/vvcephei/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/vvcephei/kafka/tags","blobs_url":"https://api.github.com/repos/vvcephei/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvcephei/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvcephei/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvcephei/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvcephei/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/vvcephei/kafka/languages","stargazers_url":"https://api.github.com/repos/vvcephei/kafka/stargazers","contributors_url":"https://api.github.com/repos/vvcephei/kafka/contributors","subscribers_url":"https://api.github.com/repos/vvcephei/kafka/subscribers","subscription_url":"https://api.github.com/repos/vvcephei/kafka/subscription","commits_url":"https://api.github.com/repos/vvcephei/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvcephei/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvcephei/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvcephei/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvcephei/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/vvcephei/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvcephei/kafka/merges","archive_url":"https://api.github.com/repos/vvcephei/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvcephei/kafka/downloads","issues_url":"https://api.github.com/repos/vvcephei/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/vvcephei/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/vvcephei/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/vvcephei/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvcephei/kafka/labels{/name}","releases_url":"https://api.github.com/repos/vvcephei/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/vvcephei/kafka/deployments","created_at":"2018-03-06T21:12:33Z","updated_at":"2018-04-05T14:43:40Z","pushed_at":"2018-05-22T19:10:50Z","git_url":"git://github.com/vvcephei/kafka.git","ssh_url":"[email protected]:vvcephei/kafka.git","clone_url":"https://github.com/vvcephei/kafka.git","svn_url":"https://github.com/vvcephei/kafka","homepage":null,"size":65571,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"6281fbcb6ad3c1f7172af0ba590fa1e2605093de","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-05-22T18:25:29Z","pushed_at":"2018-05-22T19:26:03Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"[email protected]:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":65657,"stargazers_count":8408,"watchers_count":8408,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4879,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4879,"open_issues":468,"watchers":8408,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4855"},"html":{"href":"https://github.com/apache/kafka/pull/4855"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4855"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4855/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4855/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4855/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/b5ce2e2c8e372aeded9e2f1cad97570361a90af6"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2211243,
"name": "apache/kafka",
"url": "https://api.github.com/repos/apache/kafka"
} | {
"id": 832787,
"login": "vvcephei",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/832787?",
"url": "https://api.github.com/users/vvcephei"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-05-22T19:27:48 | 7712996628 | {"actor":{"display_login":"vvcephei"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-druid/pulls/comments/201891545","pull_request_review_id":136482349,"id":201891545,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTg5MTU0NQ==","diff_hunk":"@@ -240,11 +239,7 @@ public void reset(DataSourceMetadata dataSourceMetadata)\n }\n \n @Override\n- public void checkpoint(\n- @Nullable String sequenceName,\n- @Nullable DataSourceMetadata previousCheckPoint,\n- @Nullable DataSourceMetadata currentCheckPoint\n- )\n+ public void checkpoint(int taskGroupId, DataSourceMetadata previousCheckPoint, DataSourceMetadata currentCheckPoint)","path":"extensions-contrib/materialized-view-maintenance/src/main/java/io/druid/indexing/materializedview/MaterializedViewSupervisor.java","position":17,"original_position":17,"commit_id":"ba247774508fdb04de6c03a916d4b2fe59394f1b","original_commit_id":"e8f5ab5695b212a3524521124ecb3bacbe02d2cf","user":{"login":"asdf2014","id":8108788,"node_id":"MDQ6VXNlcjgxMDg3ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/8108788?v=4","gravatar_id":"","url":"https://api.github.com/users/asdf2014","html_url":"https://github.com/asdf2014","followers_url":"https://api.github.com/users/asdf2014/followers","following_url":"https://api.github.com/users/asdf2014/following{/other_user}","gists_url":"https://api.github.com/users/asdf2014/gists{/gist_id}","starred_url":"https://api.github.com/users/asdf2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asdf2014/subscriptions","organizations_url":"https://api.github.com/users/asdf2014/orgs","repos_url":"https://api.github.com/users/asdf2014/repos","events_url":"https://api.github.com/users/asdf2014/events{/privacy}","received_events_url":"https://api.github.com/users/asdf2014/received_events","type":"User","site_admin":false},"body":"I should see the latest version code when i visit [https://github.com/apache/incubator-druid/pull/5996/files](https://github.com/apache/incubator-druid/pull/5996/files) this page, right?","created_at":"2018-07-12T02:19:24Z","updated_at":"2018-07-12T02:19:25Z","html_url":"https://github.com/apache/incubator-druid/pull/5996#discussion_r201891545","pull_request_url":"https://api.github.com/repos/apache/incubator-druid/pulls/5996","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/comments/201891545"},"html":{"href":"https://github.com/apache/incubator-druid/pull/5996#discussion_r201891545"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/5996"}},"in_reply_to_id":201885338},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-druid/pulls/5996","id":200858861,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODU4ODYx","html_url":"https://github.com/apache/incubator-druid/pull/5996","diff_url":"https://github.com/apache/incubator-druid/pull/5996.diff","patch_url":"https://github.com/apache/incubator-druid/pull/5996.patch","issue_url":"https://api.github.com/repos/apache/incubator-druid/issues/5996","number":5996,"state":"open","locked":false,"title":"Fix NPE while handling CheckpointNotice in KafkaSupervisor","user":{"login":"jihoonson","id":2322288,"node_id":"MDQ6VXNlcjIzMjIyODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2322288?v=4","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/apache/incubator-druid/issues/5992.\r\n\r\nIn this PR, the supervisor has been changed to ignore inactive taskGroup (which is not in `taskGroups` map) while processing a checkpointNotice if it's a known taskGroup (which means it is in either `pendingCompletionTaskGroups` or `partitionGroups` maps). See `CheckpointNotice. isValidTaskGroup()`.\r\n\r\nAdditionally, \r\n\r\n- Removed unnecessary `sequenceTaskGroup` map from `KafkaSupervisor`. In `KafkaSupervisor`, there is a `ConcurrentHashMap` called `taskGroups` which maps a taskGroupId to an _active_ taskGroup. This is very similar to `sequenceTaskGroup` which maps a baseSequenceName to an active taskGroup because baseSequenceName is unique for a taskGroup. Also, `sequenceTaskGroup` was being changed along with `taskGroups`. We don't have to maintain two `ConcurrentHashMap`s which can even cause a race condition.\r\n- Since `sequenceTaskGroup` has been removed, the checkpoint request now contains a taskGroupId which is assigned to `KafkaIndexTask`s via `KafkaIOConfig`.\r\n- Fixed wrong `Nullable` annotation in `Supervisor.checkpoint()` method.\r\n- Changed the `map.putIfAbsent()` & `map.get()` pattern to `map.computeIfAbsent()`.","created_at":"2018-07-12T00:21:42Z","updated_at":"2018-07-12T02:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb0d354725704b05f66c689451b93c65146459e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":690563043,"node_id":"MDU6TGFiZWw2OTA1NjMwNDM=","url":"https://api.github.com/repos/apache/incubator-druid/labels/Area%20-%20Kafka%20Indexing","name":"Area - Kafka Indexing","color":"fef2c0","default":false},{"id":17287685,"node_id":"MDU6TGFiZWwxNzI4NzY4NQ==","url":"https://api.github.com/repos/apache/incubator-druid/labels/Bug","name":"Bug","color":"fc2929","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/incubator-druid/milestones/27","html_url":"https://github.com/apache/incubator-druid/milestone/27","labels_url":"https://api.github.com/repos/apache/incubator-druid/milestones/27/labels","id":3412199,"node_id":"MDk6TWlsZXN0b25lMzQxMjE5OQ==","number":27,"title":"0.12.2","description":"","creator":{"login":"jihoonson","id":2322288,"node_id":"MDQ6VXNlcjIzMjIyODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2322288?v=4","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":59,"state":"open","created_at":"2018-06-08T22:27:59Z","updated_at":"2018-07-12T00:21:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-druid/pulls/5996/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-druid/pulls/5996/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-druid/issues/5996/comments","statuses_url":"https://api.github.com/repos/apache/incubator-druid/statuses/ba247774508fdb04de6c03a916d4b2fe59394f1b","head":{"label":"jihoonson:fix-npe-supervisor","ref":"fix-npe-supervisor","sha":"ba247774508fdb04de6c03a916d4b2fe59394f1b","user":{"login":"jihoonson","id":2322288,"node_id":"MDQ6VXNlcjIzMjIyODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2322288?v=4","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"repo":{"id":71565181,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU2NTE4MQ==","name":"druid","full_name":"jihoonson/druid","owner":{"login":"jihoonson","id":2322288,"node_id":"MDQ6VXNlcjIzMjIyODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2322288?v=4","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jihoonson/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/jihoonson/druid","forks_url":"https://api.github.com/repos/jihoonson/druid/forks","keys_url":"https://api.github.com/repos/jihoonson/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jihoonson/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jihoonson/druid/teams","hooks_url":"https://api.github.com/repos/jihoonson/druid/hooks","issue_events_url":"https://api.github.com/repos/jihoonson/druid/issues/events{/number}","events_url":"https://api.github.com/repos/jihoonson/druid/events","assignees_url":"https://api.github.com/repos/jihoonson/druid/assignees{/user}","branches_url":"https://api.github.com/repos/jihoonson/druid/branches{/branch}","tags_url":"https://api.github.com/repos/jihoonson/druid/tags","blobs_url":"https://api.github.com/repos/jihoonson/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jihoonson/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jihoonson/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/jihoonson/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jihoonson/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/jihoonson/druid/languages","stargazers_url":"https://api.github.com/repos/jihoonson/druid/stargazers","contributors_url":"https://api.github.com/repos/jihoonson/druid/contributors","subscribers_url":"https://api.github.com/repos/jihoonson/druid/subscribers","subscription_url":"https://api.github.com/repos/jihoonson/druid/subscription","commits_url":"https://api.github.com/repos/jihoonson/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/jihoonson/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/jihoonson/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/jihoonson/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/jihoonson/druid/contents/{+path}","compare_url":"https://api.github.com/repos/jihoonson/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jihoonson/druid/merges","archive_url":"https://api.github.com/repos/jihoonson/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jihoonson/druid/downloads","issues_url":"https://api.github.com/repos/jihoonson/druid/issues{/number}","pulls_url":"https://api.github.com/repos/jihoonson/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/jihoonson/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/jihoonson/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jihoonson/druid/labels{/name}","releases_url":"https://api.github.com/repos/jihoonson/druid/releases{/id}","deployments_url":"https://api.github.com/repos/jihoonson/druid/deployments","created_at":"2016-10-21T13:05:19Z","updated_at":"2018-07-06T15:32:53Z","pushed_at":"2018-07-12T01:41:58Z","git_url":"git://github.com/jihoonson/druid.git","ssh_url":"[email protected]:jihoonson/druid.git","clone_url":"https://github.com/jihoonson/druid.git","svn_url":"https://github.com/jihoonson/druid","homepage":"http://druid.io","size":141550,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5f78a333ad0455ad377b1eac0e119fa3594a9d10","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"node_id":"MDEwOlJlcG9zaXRvcnk2MzU4MTg4","name":"incubator-druid","full_name":"apache/incubator-druid","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-druid","description":"Apache Druid (Incubating) - Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/apache/incubator-druid","forks_url":"https://api.github.com/repos/apache/incubator-druid/forks","keys_url":"https://api.github.com/repos/apache/incubator-druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-druid/teams","hooks_url":"https://api.github.com/repos/apache/incubator-druid/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-druid/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-druid/events","assignees_url":"https://api.github.com/repos/apache/incubator-druid/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-druid/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-druid/tags","blobs_url":"https://api.github.com/repos/apache/incubator-druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-druid/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-druid/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-druid/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-druid/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-druid/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-druid/subscription","commits_url":"https://api.github.com/repos/apache/incubator-druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-druid/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-druid/merges","archive_url":"https://api.github.com/repos/apache/incubator-druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-druid/downloads","issues_url":"https://api.github.com/repos/apache/incubator-druid/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-druid/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-druid/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-druid/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-druid/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2018-07-12T02:09:22Z","pushed_at":"2018-07-12T01:42:00Z","git_url":"git://github.com/apache/incubator-druid.git","ssh_url":"[email protected]:apache/incubator-druid.git","clone_url":"https://github.com/apache/incubator-druid.git","svn_url":"https://github.com/apache/incubator-druid","homepage":"http://druid.io","size":140639,"stargazers_count":6738,"watchers_count":6738,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1649,"mirror_url":null,"archived":false,"open_issues_count":1084,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1649,"open_issues":1084,"watchers":6738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/5996"},"html":{"href":"https://github.com/apache/incubator-druid/pull/5996"},"issue":{"href":"https://api.github.com/repos/apache/incubator-druid/issues/5996"},"comments":{"href":"https://api.github.com/repos/apache/incubator-druid/issues/5996/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/5996/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-druid/pulls/5996/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-druid/statuses/ba247774508fdb04de6c03a916d4b2fe59394f1b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 6358188,
"name": "apache/incubator-druid",
"url": "https://api.github.com/repos/apache/incubator-druid"
} | {
"id": 8108788,
"login": "asdf2014",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8108788?",
"url": "https://api.github.com/users/asdf2014"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2018-07-12T02:19:24 | 7953556943 | {"actor":{"display_login":"asdf2014"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/211085938","pull_request_review_id":147441345,"id":211085938,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA4NTkzOA==","diff_hunk":"@@ -0,0 +1,16 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!DOCTYPE pkgmetadata SYSTEM \"http://www.gentoo.org/dtd/metadata.dtd\">\n+<pkgmetadata>\n+\t<maintainer type=\"person\">\n+\t\t<email>[email protected]</email>\n+\t</maintainer>","path":"sys-fs/mergerfs/metadata.xml","position":6,"original_position":6,"commit_id":"90785178566b943971bf70133159b0033a42c0d4","original_commit_id":"90785178566b943971bf70133159b0033a42c0d4","user":{"login":"ahippo","id":1228485,"node_id":"MDQ6VXNlcjEyMjg0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1228485?v=4","gravatar_id":"","url":"https://api.github.com/users/ahippo","html_url":"https://github.com/ahippo","followers_url":"https://api.github.com/users/ahippo/followers","following_url":"https://api.github.com/users/ahippo/following{/other_user}","gists_url":"https://api.github.com/users/ahippo/gists{/gist_id}","starred_url":"https://api.github.com/users/ahippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahippo/subscriptions","organizations_url":"https://api.github.com/users/ahippo/orgs","repos_url":"https://api.github.com/users/ahippo/repos","events_url":"https://api.github.com/users/ahippo/events{/privacy}","received_events_url":"https://api.github.com/users/ahippo/received_events","type":"User","site_admin":false},"body":"I'll add proxy-maint as with the other PR.\r\nSomehow missed this in the PR/Proxy_Maint instructions.","created_at":"2018-08-18T21:17:12Z","updated_at":"2018-08-18T21:17:13Z","html_url":"https://github.com/gentoo/gentoo/pull/9544#discussion_r211085938","pull_request_url":"https://api.github.com/repos/gentoo/gentoo/pulls/9544","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments/211085938"},"html":{"href":"https://github.com/gentoo/gentoo/pull/9544#discussion_r211085938"},"pull_request":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/9544"}},"in_reply_to_id":211085435},"pull_request":{"url":"https://api.github.com/repos/gentoo/gentoo/pulls/9544","id":207805916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODA1OTE2","html_url":"https://github.com/gentoo/gentoo/pull/9544","diff_url":"https://github.com/gentoo/gentoo/pull/9544.diff","patch_url":"https://github.com/gentoo/gentoo/pull/9544.patch","issue_url":"https://api.github.com/repos/gentoo/gentoo/issues/9544","number":9544,"state":"open","locked":false,"title":"sys-fs/mergerfs: new package, version 2.24.2","user":{"login":"ahippo","id":1228485,"node_id":"MDQ6VXNlcjEyMjg0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1228485?v=4","gravatar_id":"","url":"https://api.github.com/users/ahippo","html_url":"https://github.com/ahippo","followers_url":"https://api.github.com/users/ahippo/followers","following_url":"https://api.github.com/users/ahippo/following{/other_user}","gists_url":"https://api.github.com/users/ahippo/gists{/gist_id}","starred_url":"https://api.github.com/users/ahippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahippo/subscriptions","organizations_url":"https://api.github.com/users/ahippo/orgs","repos_url":"https://api.github.com/users/ahippo/repos","events_url":"https://api.github.com/users/ahippo/events{/privacy}","received_events_url":"https://api.github.com/users/ahippo/received_events","type":"User","site_admin":false},"body":"Add sys-fs/mergerfs package -- IMHO, a superior alternative to mhddfs.\r\n\r\nFor now, I put myself as the package maintainer.\r\nI'll be glad to maintain the package although I'm not a Gentoo developer (yet).\r\n\r\nBug: https://bugs.gentoo.org/587956\r\nPackage-Manager: Portage-2.3.40, Repoman-2.3.9\r\n\r\nAnother take on mergerfs ebuild.\r\nIt's not based in [mergerfs-2.13.1.ebuild](https://bugs.gentoo.org/attachment.cgi?id=439650) and is for much newer version.","created_at":"2018-08-12T05:40:32Z","updated_at":"2018-08-18T21:17:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c94f0e9607dd2acf280980aea281d0f16a08539","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":257560845,"node_id":"MDU6TGFiZWwyNTc1NjA4NDU=","url":"https://api.github.com/repos/gentoo/gentoo/labels/assigned","name":"assigned","color":"5319e7","default":false},{"id":740393777,"node_id":"MDU6TGFiZWw3NDAzOTM3Nzc=","url":"https://api.github.com/repos/gentoo/gentoo/labels/bug%20linked","name":"bug linked","color":"f767dd","default":false},{"id":250996522,"node_id":"MDU6TGFiZWwyNTA5OTY1MjI=","url":"https://api.github.com/repos/gentoo/gentoo/labels/new%20package","name":"new package","color":"0052cc","default":false},{"id":579773424,"node_id":"MDU6TGFiZWw1Nzk3NzM0MjQ=","url":"https://api.github.com/repos/gentoo/gentoo/labels/self-maintained","name":"self-maintained","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gentoo/gentoo/pulls/9544/commits","review_comments_url":"https://api.github.com/repos/gentoo/gentoo/pulls/9544/comments","review_comment_url":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gentoo/gentoo/issues/9544/comments","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/90785178566b943971bf70133159b0033a42c0d4","head":{"label":"ahippo:sys-fs/mergerfs","ref":"sys-fs/mergerfs","sha":"90785178566b943971bf70133159b0033a42c0d4","user":{"login":"ahippo","id":1228485,"node_id":"MDQ6VXNlcjEyMjg0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1228485?v=4","gravatar_id":"","url":"https://api.github.com/users/ahippo","html_url":"https://github.com/ahippo","followers_url":"https://api.github.com/users/ahippo/followers","following_url":"https://api.github.com/users/ahippo/following{/other_user}","gists_url":"https://api.github.com/users/ahippo/gists{/gist_id}","starred_url":"https://api.github.com/users/ahippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahippo/subscriptions","organizations_url":"https://api.github.com/users/ahippo/orgs","repos_url":"https://api.github.com/users/ahippo/repos","events_url":"https://api.github.com/users/ahippo/events{/privacy}","received_events_url":"https://api.github.com/users/ahippo/received_events","type":"User","site_admin":false},"repo":{"id":143634090,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2MzQwOTA=","name":"gentoo","full_name":"ahippo/gentoo","owner":{"login":"ahippo","id":1228485,"node_id":"MDQ6VXNlcjEyMjg0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1228485?v=4","gravatar_id":"","url":"https://api.github.com/users/ahippo","html_url":"https://github.com/ahippo","followers_url":"https://api.github.com/users/ahippo/followers","following_url":"https://api.github.com/users/ahippo/following{/other_user}","gists_url":"https://api.github.com/users/ahippo/gists{/gist_id}","starred_url":"https://api.github.com/users/ahippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahippo/subscriptions","organizations_url":"https://api.github.com/users/ahippo/orgs","repos_url":"https://api.github.com/users/ahippo/repos","events_url":"https://api.github.com/users/ahippo/events{/privacy}","received_events_url":"https://api.github.com/users/ahippo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahippo/gentoo","description":"The Gentoo ebuild repository mirror","fork":true,"url":"https://api.github.com/repos/ahippo/gentoo","forks_url":"https://api.github.com/repos/ahippo/gentoo/forks","keys_url":"https://api.github.com/repos/ahippo/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahippo/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahippo/gentoo/teams","hooks_url":"https://api.github.com/repos/ahippo/gentoo/hooks","issue_events_url":"https://api.github.com/repos/ahippo/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/ahippo/gentoo/events","assignees_url":"https://api.github.com/repos/ahippo/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/ahippo/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/ahippo/gentoo/tags","blobs_url":"https://api.github.com/repos/ahippo/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahippo/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahippo/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahippo/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahippo/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/ahippo/gentoo/languages","stargazers_url":"https://api.github.com/repos/ahippo/gentoo/stargazers","contributors_url":"https://api.github.com/repos/ahippo/gentoo/contributors","subscribers_url":"https://api.github.com/repos/ahippo/gentoo/subscribers","subscription_url":"https://api.github.com/repos/ahippo/gentoo/subscription","commits_url":"https://api.github.com/repos/ahippo/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahippo/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahippo/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahippo/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahippo/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/ahippo/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahippo/gentoo/merges","archive_url":"https://api.github.com/repos/ahippo/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahippo/gentoo/downloads","issues_url":"https://api.github.com/repos/ahippo/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/ahippo/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/ahippo/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/ahippo/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahippo/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/ahippo/gentoo/releases{/id}","deployments_url":"https://api.github.com/repos/ahippo/gentoo/deployments","created_at":"2018-08-05T17:33:23Z","updated_at":"2018-08-05T17:35:12Z","pushed_at":"2018-08-14T04:35:13Z","git_url":"git://github.com/ahippo/gentoo.git","ssh_url":"[email protected]:ahippo/gentoo.git","clone_url":"https://github.com/ahippo/gentoo.git","svn_url":"https://github.com/ahippo/gentoo","homepage":"https://www.gentoo.org","size":564157,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gentoo:master","ref":"master","sha":"16cd1240a996243eed4ebc6ca93937ba7cb7cb84","user":{"login":"gentoo","id":52242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/52242?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"repo":{"id":40499714,"node_id":"MDEwOlJlcG9zaXRvcnk0MDQ5OTcxNA==","name":"gentoo","full_name":"gentoo/gentoo","owner":{"login":"gentoo","id":52242,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjQy","avatar_url":"https://avatars3.githubusercontent.com/u/52242?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gentoo/gentoo","description":"The Gentoo ebuild repository mirror","fork":false,"url":"https://api.github.com/repos/gentoo/gentoo","forks_url":"https://api.github.com/repos/gentoo/gentoo/forks","keys_url":"https://api.github.com/repos/gentoo/gentoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gentoo/gentoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gentoo/gentoo/teams","hooks_url":"https://api.github.com/repos/gentoo/gentoo/hooks","issue_events_url":"https://api.github.com/repos/gentoo/gentoo/issues/events{/number}","events_url":"https://api.github.com/repos/gentoo/gentoo/events","assignees_url":"https://api.github.com/repos/gentoo/gentoo/assignees{/user}","branches_url":"https://api.github.com/repos/gentoo/gentoo/branches{/branch}","tags_url":"https://api.github.com/repos/gentoo/gentoo/tags","blobs_url":"https://api.github.com/repos/gentoo/gentoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gentoo/gentoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gentoo/gentoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gentoo/gentoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gentoo/gentoo/statuses/{sha}","languages_url":"https://api.github.com/repos/gentoo/gentoo/languages","stargazers_url":"https://api.github.com/repos/gentoo/gentoo/stargazers","contributors_url":"https://api.github.com/repos/gentoo/gentoo/contributors","subscribers_url":"https://api.github.com/repos/gentoo/gentoo/subscribers","subscription_url":"https://api.github.com/repos/gentoo/gentoo/subscription","commits_url":"https://api.github.com/repos/gentoo/gentoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gentoo/gentoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gentoo/gentoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gentoo/gentoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gentoo/gentoo/contents/{+path}","compare_url":"https://api.github.com/repos/gentoo/gentoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gentoo/gentoo/merges","archive_url":"https://api.github.com/repos/gentoo/gentoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gentoo/gentoo/downloads","issues_url":"https://api.github.com/repos/gentoo/gentoo/issues{/number}","pulls_url":"https://api.github.com/repos/gentoo/gentoo/pulls{/number}","milestones_url":"https://api.github.com/repos/gentoo/gentoo/milestones{/number}","notifications_url":"https://api.github.com/repos/gentoo/gentoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gentoo/gentoo/labels{/name}","releases_url":"https://api.github.com/repos/gentoo/gentoo/releases{/id}","deployments_url":"https://api.github.com/repos/gentoo/gentoo/deployments","created_at":"2015-08-10T18:47:32Z","updated_at":"2018-08-18T21:02:27Z","pushed_at":"2018-08-18T21:01:40Z","git_url":"git://github.com/gentoo/gentoo.git","ssh_url":"[email protected]:gentoo/gentoo.git","clone_url":"https://github.com/gentoo/gentoo.git","svn_url":"https://github.com/gentoo/gentoo","homepage":"https://www.gentoo.org","size":566087,"stargazers_count":889,"watchers_count":889,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":800,"mirror_url":null,"archived":false,"open_issues_count":163,"license":null,"forks":800,"open_issues":163,"watchers":889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/9544"},"html":{"href":"https://github.com/gentoo/gentoo/pull/9544"},"issue":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/9544"},"comments":{"href":"https://api.github.com/repos/gentoo/gentoo/issues/9544/comments"},"review_comments":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/9544/comments"},"review_comment":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gentoo/gentoo/pulls/9544/commits"},"statuses":{"href":"https://api.github.com/repos/gentoo/gentoo/statuses/90785178566b943971bf70133159b0033a42c0d4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 40499714,
"name": "gentoo/gentoo",
"url": "https://api.github.com/repos/gentoo/gentoo"
} | {
"id": 1228485,
"login": "ahippo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1228485?",
"url": "https://api.github.com/users/ahippo"
} | {
"id": 52242,
"login": "gentoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/52242?",
"url": "https://api.github.com/orgs/gentoo"
} | 2018-08-18T21:17:12 | 8133175789 | {"actor":{"display_login":"ahippo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/232963941","pull_request_review_id":174272203,"id":232963941,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjk2Mzk0MQ==","diff_hunk":"@@ -119,20 +124,26 @@ static int UnBindRawJSObjectAndFree(int gcHandle)\n raw_to_js.Remove(raw_obj);\n }\n \n-\n obj.Dispose();\n \n var gCHandle = obj.Handle;\n obj.Handle.Free();\n obj.JSHandle = -1;\n- obj.RawObject = null;\n return (int)(IntPtr)gCHandle;\n }\n-\n return 0;\n \n }\n \n+ public static void FreeObject (object obj)\n+ {\n+ int exception = 0;","path":"sdks/wasm/bindings.cs","position":32,"original_position":32,"commit_id":"dc2c03dfbcf60d58c92ec3c96d8480501d0e30ac","original_commit_id":"dc2c03dfbcf60d58c92ec3c96d8480501d0e30ac","user":{"login":"marek-safar","id":250852,"node_id":"MDQ6VXNlcjI1MDg1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/250852?v=4","gravatar_id":"","url":"https://api.github.com/users/marek-safar","html_url":"https://github.com/marek-safar","followers_url":"https://api.github.com/users/marek-safar/followers","following_url":"https://api.github.com/users/marek-safar/following{/other_user}","gists_url":"https://api.github.com/users/marek-safar/gists{/gist_id}","starred_url":"https://api.github.com/users/marek-safar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marek-safar/subscriptions","organizations_url":"https://api.github.com/users/marek-safar/orgs","repos_url":"https://api.github.com/users/marek-safar/repos","events_url":"https://api.github.com/users/marek-safar/events{/privacy}","received_events_url":"https://api.github.com/users/marek-safar/received_events","type":"User","site_admin":false},"body":"Does not need to be initialized","created_at":"2018-11-13T09:48:48Z","updated_at":"2018-11-13T09:50:30Z","html_url":"https://github.com/mono/mono/pull/11660#discussion_r232963941","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/11660","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/232963941"},"html":{"href":"https://github.com/mono/mono/pull/11660#discussion_r232963941"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/11660"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/11660","id":230342907,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzQyOTA3","html_url":"https://github.com/mono/mono/pull/11660","diff_url":"https://github.com/mono/mono/pull/11660.diff","patch_url":"https://github.com/mono/mono/pull/11660.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/11660","number":11660,"state":"open","locked":false,"title":"[wasm][binding] Allow the cleanup of transparent/bridged marshalled objects causing leaks.","user":{"login":"kjpou1","id":640466,"node_id":"MDQ6VXNlcjY0MDQ2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/640466?v=4","gravatar_id":"","url":"https://api.github.com/users/kjpou1","html_url":"https://github.com/kjpou1","followers_url":"https://api.github.com/users/kjpou1/followers","following_url":"https://api.github.com/users/kjpou1/following{/other_user}","gists_url":"https://api.github.com/users/kjpou1/gists{/gist_id}","starred_url":"https://api.github.com/users/kjpou1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjpou1/subscriptions","organizations_url":"https://api.github.com/users/kjpou1/orgs","repos_url":"https://api.github.com/users/kjpou1/repos","events_url":"https://api.github.com/users/kjpou1/events{/privacy}","received_events_url":"https://api.github.com/users/kjpou1/received_events","type":"User","site_admin":false},"body":"- Example: When a delegate is marshalled to JS it is allocated so that it is not GC'd. Since we do not know when JS is finished with the delegate we need a way, for right now, to tell the Runtime to de-allocate the object and remove the transparent/bridged instance from JS as well. The side-effect of not doing this is that any local that is captured (used) by a lambda became heap memory and were allocated as fields on the object. Since the delegate is never a candidate for GC the local that was captured was never released either.\r\n\r\n- Fix an error with Windows Edge and Windows IE that threw an exception `Object doesn't support this action` on certain host objects. This only affected Windows Edge and IE when using the JavaScript delete operator to clean up an object after being disposed.\r\n\r\n- Cleanup marshalled Tasks after completion. The marshalled tasks and their continuation objects were never un-allocated thus not allowing them to be GC'd.\r\n","created_at":"2018-11-13T04:15:33Z","updated_at":"2018-11-13T09:50:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c303e7ab94344b5ccaab019509b48cff2e535437","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vargaz","id":186301,"node_id":"MDQ6VXNlcjE4NjMwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/186301?v=4","gravatar_id":"","url":"https://api.github.com/users/vargaz","html_url":"https://github.com/vargaz","followers_url":"https://api.github.com/users/vargaz/followers","following_url":"https://api.github.com/users/vargaz/following{/other_user}","gists_url":"https://api.github.com/users/vargaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vargaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vargaz/subscriptions","organizations_url":"https://api.github.com/users/vargaz/orgs","repos_url":"https://api.github.com/users/vargaz/repos","events_url":"https://api.github.com/users/vargaz/events{/privacy}","received_events_url":"https://api.github.com/users/vargaz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/11660/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/11660/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/11660/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/dc2c03dfbcf60d58c92ec3c96d8480501d0e30ac","head":{"label":"kjpou1:wasm-bridge-fix","ref":"wasm-bridge-fix","sha":"dc2c03dfbcf60d58c92ec3c96d8480501d0e30ac","user":{"login":"kjpou1","id":640466,"node_id":"MDQ6VXNlcjY0MDQ2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/640466?v=4","gravatar_id":"","url":"https://api.github.com/users/kjpou1","html_url":"https://github.com/kjpou1","followers_url":"https://api.github.com/users/kjpou1/followers","following_url":"https://api.github.com/users/kjpou1/following{/other_user}","gists_url":"https://api.github.com/users/kjpou1/gists{/gist_id}","starred_url":"https://api.github.com/users/kjpou1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjpou1/subscriptions","organizations_url":"https://api.github.com/users/kjpou1/orgs","repos_url":"https://api.github.com/users/kjpou1/repos","events_url":"https://api.github.com/users/kjpou1/events{/privacy}","received_events_url":"https://api.github.com/users/kjpou1/received_events","type":"User","site_admin":false},"repo":{"id":138134154,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxMzQxNTQ=","name":"mono","full_name":"kjpou1/mono","private":false,"owner":{"login":"kjpou1","id":640466,"node_id":"MDQ6VXNlcjY0MDQ2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/640466?v=4","gravatar_id":"","url":"https://api.github.com/users/kjpou1","html_url":"https://github.com/kjpou1","followers_url":"https://api.github.com/users/kjpou1/followers","following_url":"https://api.github.com/users/kjpou1/following{/other_user}","gists_url":"https://api.github.com/users/kjpou1/gists{/gist_id}","starred_url":"https://api.github.com/users/kjpou1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjpou1/subscriptions","organizations_url":"https://api.github.com/users/kjpou1/orgs","repos_url":"https://api.github.com/users/kjpou1/repos","events_url":"https://api.github.com/users/kjpou1/events{/privacy}","received_events_url":"https://api.github.com/users/kjpou1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kjpou1/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/kjpou1/mono","forks_url":"https://api.github.com/repos/kjpou1/mono/forks","keys_url":"https://api.github.com/repos/kjpou1/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjpou1/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjpou1/mono/teams","hooks_url":"https://api.github.com/repos/kjpou1/mono/hooks","issue_events_url":"https://api.github.com/repos/kjpou1/mono/issues/events{/number}","events_url":"https://api.github.com/repos/kjpou1/mono/events","assignees_url":"https://api.github.com/repos/kjpou1/mono/assignees{/user}","branches_url":"https://api.github.com/repos/kjpou1/mono/branches{/branch}","tags_url":"https://api.github.com/repos/kjpou1/mono/tags","blobs_url":"https://api.github.com/repos/kjpou1/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjpou1/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjpou1/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjpou1/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjpou1/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/kjpou1/mono/languages","stargazers_url":"https://api.github.com/repos/kjpou1/mono/stargazers","contributors_url":"https://api.github.com/repos/kjpou1/mono/contributors","subscribers_url":"https://api.github.com/repos/kjpou1/mono/subscribers","subscription_url":"https://api.github.com/repos/kjpou1/mono/subscription","commits_url":"https://api.github.com/repos/kjpou1/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjpou1/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjpou1/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjpou1/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjpou1/mono/contents/{+path}","compare_url":"https://api.github.com/repos/kjpou1/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjpou1/mono/merges","archive_url":"https://api.github.com/repos/kjpou1/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjpou1/mono/downloads","issues_url":"https://api.github.com/repos/kjpou1/mono/issues{/number}","pulls_url":"https://api.github.com/repos/kjpou1/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/kjpou1/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/kjpou1/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjpou1/mono/labels{/name}","releases_url":"https://api.github.com/repos/kjpou1/mono/releases{/id}","deployments_url":"https://api.github.com/repos/kjpou1/mono/deployments","created_at":"2018-06-21T07:19:51Z","updated_at":"2018-11-13T04:46:13Z","pushed_at":"2018-11-13T09:28:16Z","git_url":"git://github.com/kjpou1/mono.git","ssh_url":"[email protected]:kjpou1/mono.git","clone_url":"https://github.com/kjpou1/mono.git","svn_url":"https://github.com/kjpou1/mono","homepage":"http://www.mono-project.com/","size":499864,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"8e10108d9f9bece7d86aaed70dea6eb7edef5093","user":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE2MTE=","name":"mono","full_name":"mono/mono","private":false,"owner":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2018-11-13T06:54:26Z","pushed_at":"2018-11-13T09:28:22Z","git_url":"git://github.com/mono/mono.git","ssh_url":"[email protected]:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":502470,"stargazers_count":7177,"watchers_count":7177,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":3030,"mirror_url":null,"archived":false,"open_issues_count":1053,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3030,"open_issues":1053,"watchers":7177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/11660"},"html":{"href":"https://github.com/mono/mono/pull/11660"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/11660"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/11660/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/11660/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/11660/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/dc2c03dfbcf60d58c92ec3c96d8480501d0e30ac"}},"author_association":"MEMBER"}} | {
"id": 791611,
"name": "mono/mono",
"url": "https://api.github.com/repos/mono/mono"
} | {
"id": 250852,
"login": "marek-safar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/250852?",
"url": "https://api.github.com/users/marek-safar"
} | {
"id": 53395,
"login": "mono",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53395?",
"url": "https://api.github.com/orgs/mono"
} | 2018-11-13T09:48:48 | 8579679168 | {"actor":{"display_login":"marek-safar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/biopython/biopython/pulls/comments/186981964","pull_request_review_id":118666694,"id":186981964,"diff_hunk":"@@ -254,10 +256,13 @@ def main(argv):\n return 0\n if opt == \"--offline\":\n print(\"Skipping any tests requiring internet access\")\n- # This is a bit of a hack...\n- import requires_internet\n- requires_internet.check.available = False\n- # The check() function should now report internet not available\n+ # Monkey patch for urlopen()\n+ import Bio._py3k\n+\n+ def dummy_urlopen(url):\n+ raise MissingExternalDependencyError(\"internet not available\")","path":"Tests/run_tests.py","position":21,"original_position":21,"commit_id":"38ea873121123023a0503840c80c8243f1279f9f","original_commit_id":"38ea873121123023a0503840c80c8243f1279f9f","user":{"login":"peterjc","id":63959,"avatar_url":"https://avatars2.githubusercontent.com/u/63959?v=4","gravatar_id":"","url":"https://api.github.com/users/peterjc","html_url":"https://github.com/peterjc","followers_url":"https://api.github.com/users/peterjc/followers","following_url":"https://api.github.com/users/peterjc/following{/other_user}","gists_url":"https://api.github.com/users/peterjc/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjc/subscriptions","organizations_url":"https://api.github.com/users/peterjc/orgs","repos_url":"https://api.github.com/users/peterjc/repos","events_url":"https://api.github.com/users/peterjc/events{/privacy}","received_events_url":"https://api.github.com/users/peterjc/received_events","type":"User","site_admin":false},"body":"I think this should be a runtime error - if this happens it means the test did not respect the ``requires_internet`` which (assuming that bit of code remains above).","created_at":"2018-05-09T09:20:47Z","updated_at":"2018-05-09T09:20:47Z","html_url":"https://github.com/biopython/biopython/pull/1643#discussion_r186981964","pull_request_url":"https://api.github.com/repos/biopython/biopython/pulls/1643","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/biopython/biopython/pulls/comments/186981964"},"html":{"href":"https://github.com/biopython/biopython/pull/1643#discussion_r186981964"},"pull_request":{"href":"https://api.github.com/repos/biopython/biopython/pulls/1643"}}},"pull_request":{"url":"https://api.github.com/repos/biopython/biopython/pulls/1643","id":186842729,"html_url":"https://github.com/biopython/biopython/pull/1643","diff_url":"https://github.com/biopython/biopython/pull/1643.diff","patch_url":"https://github.com/biopython/biopython/pull/1643.patch","issue_url":"https://api.github.com/repos/biopython/biopython/issues/1643","number":1643,"state":"open","locked":false,"title":"Monkey patch to enforce --offline switch in run_tests.py","user":{"login":"Gasta88","id":9337563,"avatar_url":"https://avatars3.githubusercontent.com/u/9337563?v=4","gravatar_id":"","url":"https://api.github.com/users/Gasta88","html_url":"https://github.com/Gasta88","followers_url":"https://api.github.com/users/Gasta88/followers","following_url":"https://api.github.com/users/Gasta88/following{/other_user}","gists_url":"https://api.github.com/users/Gasta88/gists{/gist_id}","starred_url":"https://api.github.com/users/Gasta88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gasta88/subscriptions","organizations_url":"https://api.github.com/users/Gasta88/orgs","repos_url":"https://api.github.com/users/Gasta88/repos","events_url":"https://api.github.com/users/Gasta88/events{/privacy}","received_events_url":"https://api.github.com/users/Gasta88/received_events","type":"User","site_admin":false},"body":"This pull request addresses issue #846\r\n\r\nThis is far from being the final version because I'm not sure about the end result.\r\n\r\nMonkey patching `urlopen()` throws a `MissingExternalDependencyError` each time the method is called inside the unittest script.\r\n\r\nThe end result via a `run_tests --offline` call, is a `FAIL` flag associated to the online test.\r\n\r\nIs this informative enough or would it be better to have again a message that explain why the test has failed? (ex: like before `skipping. No internet available`)","created_at":"2018-05-09T07:48:23Z","updated_at":"2018-05-09T09:20:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a1136656cc88258a7a15b828fb20fb1ebd4b41d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/biopython/biopython/pulls/1643/commits","review_comments_url":"https://api.github.com/repos/biopython/biopython/pulls/1643/comments","review_comment_url":"https://api.github.com/repos/biopython/biopython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biopython/biopython/issues/1643/comments","statuses_url":"https://api.github.com/repos/biopython/biopython/statuses/38ea873121123023a0503840c80c8243f1279f9f","head":{"label":"Gasta88:urlopenMonkeyPatch","ref":"urlopenMonkeyPatch","sha":"38ea873121123023a0503840c80c8243f1279f9f","user":{"login":"Gasta88","id":9337563,"avatar_url":"https://avatars3.githubusercontent.com/u/9337563?v=4","gravatar_id":"","url":"https://api.github.com/users/Gasta88","html_url":"https://github.com/Gasta88","followers_url":"https://api.github.com/users/Gasta88/followers","following_url":"https://api.github.com/users/Gasta88/following{/other_user}","gists_url":"https://api.github.com/users/Gasta88/gists{/gist_id}","starred_url":"https://api.github.com/users/Gasta88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gasta88/subscriptions","organizations_url":"https://api.github.com/users/Gasta88/orgs","repos_url":"https://api.github.com/users/Gasta88/repos","events_url":"https://api.github.com/users/Gasta88/events{/privacy}","received_events_url":"https://api.github.com/users/Gasta88/received_events","type":"User","site_admin":false},"repo":{"id":84339729,"name":"biopython","full_name":"Gasta88/biopython","owner":{"login":"Gasta88","id":9337563,"avatar_url":"https://avatars3.githubusercontent.com/u/9337563?v=4","gravatar_id":"","url":"https://api.github.com/users/Gasta88","html_url":"https://github.com/Gasta88","followers_url":"https://api.github.com/users/Gasta88/followers","following_url":"https://api.github.com/users/Gasta88/following{/other_user}","gists_url":"https://api.github.com/users/Gasta88/gists{/gist_id}","starred_url":"https://api.github.com/users/Gasta88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gasta88/subscriptions","organizations_url":"https://api.github.com/users/Gasta88/orgs","repos_url":"https://api.github.com/users/Gasta88/repos","events_url":"https://api.github.com/users/Gasta88/events{/privacy}","received_events_url":"https://api.github.com/users/Gasta88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gasta88/biopython","description":"Official git repository for Biopython (converted from CVS)","fork":true,"url":"https://api.github.com/repos/Gasta88/biopython","forks_url":"https://api.github.com/repos/Gasta88/biopython/forks","keys_url":"https://api.github.com/repos/Gasta88/biopython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gasta88/biopython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gasta88/biopython/teams","hooks_url":"https://api.github.com/repos/Gasta88/biopython/hooks","issue_events_url":"https://api.github.com/repos/Gasta88/biopython/issues/events{/number}","events_url":"https://api.github.com/repos/Gasta88/biopython/events","assignees_url":"https://api.github.com/repos/Gasta88/biopython/assignees{/user}","branches_url":"https://api.github.com/repos/Gasta88/biopython/branches{/branch}","tags_url":"https://api.github.com/repos/Gasta88/biopython/tags","blobs_url":"https://api.github.com/repos/Gasta88/biopython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gasta88/biopython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gasta88/biopython/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gasta88/biopython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gasta88/biopython/statuses/{sha}","languages_url":"https://api.github.com/repos/Gasta88/biopython/languages","stargazers_url":"https://api.github.com/repos/Gasta88/biopython/stargazers","contributors_url":"https://api.github.com/repos/Gasta88/biopython/contributors","subscribers_url":"https://api.github.com/repos/Gasta88/biopython/subscribers","subscription_url":"https://api.github.com/repos/Gasta88/biopython/subscription","commits_url":"https://api.github.com/repos/Gasta88/biopython/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gasta88/biopython/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gasta88/biopython/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gasta88/biopython/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gasta88/biopython/contents/{+path}","compare_url":"https://api.github.com/repos/Gasta88/biopython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gasta88/biopython/merges","archive_url":"https://api.github.com/repos/Gasta88/biopython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gasta88/biopython/downloads","issues_url":"https://api.github.com/repos/Gasta88/biopython/issues{/number}","pulls_url":"https://api.github.com/repos/Gasta88/biopython/pulls{/number}","milestones_url":"https://api.github.com/repos/Gasta88/biopython/milestones{/number}","notifications_url":"https://api.github.com/repos/Gasta88/biopython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gasta88/biopython/labels{/name}","releases_url":"https://api.github.com/repos/Gasta88/biopython/releases{/id}","deployments_url":"https://api.github.com/repos/Gasta88/biopython/deployments","created_at":"2017-03-08T16:05:14Z","updated_at":"2018-05-08T10:10:34Z","pushed_at":"2018-05-09T07:43:17Z","git_url":"git://github.com/Gasta88/biopython.git","ssh_url":"[email protected]:Gasta88/biopython.git","clone_url":"https://github.com/Gasta88/biopython.git","svn_url":"https://github.com/Gasta88/biopython","homepage":"http://biopython.org/","size":46079,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biopython:master","ref":"master","sha":"5a13d482fabe95cdc2a34e016000841907fe69f0","user":{"login":"biopython","id":54555,"avatar_url":"https://avatars3.githubusercontent.com/u/54555?v=4","gravatar_id":"","url":"https://api.github.com/users/biopython","html_url":"https://github.com/biopython","followers_url":"https://api.github.com/users/biopython/followers","following_url":"https://api.github.com/users/biopython/following{/other_user}","gists_url":"https://api.github.com/users/biopython/gists{/gist_id}","starred_url":"https://api.github.com/users/biopython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biopython/subscriptions","organizations_url":"https://api.github.com/users/biopython/orgs","repos_url":"https://api.github.com/users/biopython/repos","events_url":"https://api.github.com/users/biopython/events{/privacy}","received_events_url":"https://api.github.com/users/biopython/received_events","type":"Organization","site_admin":false},"repo":{"id":151541,"name":"biopython","full_name":"biopython/biopython","owner":{"login":"biopython","id":54555,"avatar_url":"https://avatars3.githubusercontent.com/u/54555?v=4","gravatar_id":"","url":"https://api.github.com/users/biopython","html_url":"https://github.com/biopython","followers_url":"https://api.github.com/users/biopython/followers","following_url":"https://api.github.com/users/biopython/following{/other_user}","gists_url":"https://api.github.com/users/biopython/gists{/gist_id}","starred_url":"https://api.github.com/users/biopython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biopython/subscriptions","organizations_url":"https://api.github.com/users/biopython/orgs","repos_url":"https://api.github.com/users/biopython/repos","events_url":"https://api.github.com/users/biopython/events{/privacy}","received_events_url":"https://api.github.com/users/biopython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biopython/biopython","description":"Official git repository for Biopython (converted from CVS)","fork":false,"url":"https://api.github.com/repos/biopython/biopython","forks_url":"https://api.github.com/repos/biopython/biopython/forks","keys_url":"https://api.github.com/repos/biopython/biopython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biopython/biopython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biopython/biopython/teams","hooks_url":"https://api.github.com/repos/biopython/biopython/hooks","issue_events_url":"https://api.github.com/repos/biopython/biopython/issues/events{/number}","events_url":"https://api.github.com/repos/biopython/biopython/events","assignees_url":"https://api.github.com/repos/biopython/biopython/assignees{/user}","branches_url":"https://api.github.com/repos/biopython/biopython/branches{/branch}","tags_url":"https://api.github.com/repos/biopython/biopython/tags","blobs_url":"https://api.github.com/repos/biopython/biopython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biopython/biopython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biopython/biopython/git/refs{/sha}","trees_url":"https://api.github.com/repos/biopython/biopython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biopython/biopython/statuses/{sha}","languages_url":"https://api.github.com/repos/biopython/biopython/languages","stargazers_url":"https://api.github.com/repos/biopython/biopython/stargazers","contributors_url":"https://api.github.com/repos/biopython/biopython/contributors","subscribers_url":"https://api.github.com/repos/biopython/biopython/subscribers","subscription_url":"https://api.github.com/repos/biopython/biopython/subscription","commits_url":"https://api.github.com/repos/biopython/biopython/commits{/sha}","git_commits_url":"https://api.github.com/repos/biopython/biopython/git/commits{/sha}","comments_url":"https://api.github.com/repos/biopython/biopython/comments{/number}","issue_comment_url":"https://api.github.com/repos/biopython/biopython/issues/comments{/number}","contents_url":"https://api.github.com/repos/biopython/biopython/contents/{+path}","compare_url":"https://api.github.com/repos/biopython/biopython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biopython/biopython/merges","archive_url":"https://api.github.com/repos/biopython/biopython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biopython/biopython/downloads","issues_url":"https://api.github.com/repos/biopython/biopython/issues{/number}","pulls_url":"https://api.github.com/repos/biopython/biopython/pulls{/number}","milestones_url":"https://api.github.com/repos/biopython/biopython/milestones{/number}","notifications_url":"https://api.github.com/repos/biopython/biopython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biopython/biopython/labels{/name}","releases_url":"https://api.github.com/repos/biopython/biopython/releases{/id}","deployments_url":"https://api.github.com/repos/biopython/biopython/deployments","created_at":"2009-03-15T21:09:53Z","updated_at":"2018-05-08T00:43:54Z","pushed_at":"2018-05-09T07:48:24Z","git_url":"git://github.com/biopython/biopython.git","ssh_url":"[email protected]:biopython/biopython.git","clone_url":"https://github.com/biopython/biopython.git","svn_url":"https://github.com/biopython/biopython","homepage":"http://biopython.org/","size":45843,"stargazers_count":1361,"watchers_count":1361,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":755,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":755,"open_issues":309,"watchers":1361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biopython/biopython/pulls/1643"},"html":{"href":"https://github.com/biopython/biopython/pull/1643"},"issue":{"href":"https://api.github.com/repos/biopython/biopython/issues/1643"},"comments":{"href":"https://api.github.com/repos/biopython/biopython/issues/1643/comments"},"review_comments":{"href":"https://api.github.com/repos/biopython/biopython/pulls/1643/comments"},"review_comment":{"href":"https://api.github.com/repos/biopython/biopython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biopython/biopython/pulls/1643/commits"},"statuses":{"href":"https://api.github.com/repos/biopython/biopython/statuses/38ea873121123023a0503840c80c8243f1279f9f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 151541,
"name": "biopython/biopython",
"url": "https://api.github.com/repos/biopython/biopython"
} | {
"id": 63959,
"login": "peterjc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/63959?",
"url": "https://api.github.com/users/peterjc"
} | {
"id": 54555,
"login": "biopython",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/54555?",
"url": "https://api.github.com/orgs/biopython"
} | 2018-05-09T09:20:47 | 7648587916 | {"actor":{"display_login":"peterjc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/comments/203504057","pull_request_review_id":138407580,"id":203504057,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzUwNDA1Nw==","diff_hunk":"@@ -159,7 +158,9 @@ public function getChildWikis()\n $family = $this->getFamilyName();\n \n return $this->event->getWikis()->filter(function (EventWiki $wiki) use ($family) {\n- return substr($this->domain, 2) === $family && $wiki->getDomain() !== $this->domain;\n+ return $wiki->isChildWiki() &&\n+ substr($this->domain, 2) === $family &&","path":"src/AppBundle/Model/EventWiki.php","position":14,"original_position":14,"commit_id":"34a3b15c4041f1f65af3aebc14ef362313125268","original_commit_id":"34a3b15c4041f1f65af3aebc14ef362313125268","user":{"login":"mooeypoo","id":261238,"node_id":"MDQ6VXNlcjI2MTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/261238?v=4","gravatar_id":"","url":"https://api.github.com/users/mooeypoo","html_url":"https://github.com/mooeypoo","followers_url":"https://api.github.com/users/mooeypoo/followers","following_url":"https://api.github.com/users/mooeypoo/following{/other_user}","gists_url":"https://api.github.com/users/mooeypoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mooeypoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mooeypoo/subscriptions","organizations_url":"https://api.github.com/users/mooeypoo/orgs","repos_url":"https://api.github.com/users/mooeypoo/repos","events_url":"https://api.github.com/users/mooeypoo/events{/privacy}","received_events_url":"https://api.github.com/users/mooeypoo/received_events","type":"User","site_admin":false},"body":"You should be careful with this; we have Wikipedias whose language code is more than 2 characters, for example, ksh.wikipedia and the more outrageously-long one, http://zh-min-nan.wikipedia.org\r\n\r\n(see more here https://en.wikipedia.org/wiki/List_of_Wikipedias)\r\n\r\nMaybe split the string by periods, and check the first piece?","created_at":"2018-07-18T19:38:56Z","updated_at":"2018-07-18T19:43:38Z","html_url":"https://github.com/wikimedia/grantmetrics/pull/74#discussion_r203504057","pull_request_url":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/74","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/comments/203504057"},"html":{"href":"https://github.com/wikimedia/grantmetrics/pull/74#discussion_r203504057"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/74","id":201177585,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTc3NTg1","html_url":"https://github.com/wikimedia/grantmetrics/pull/74","diff_url":"https://github.com/wikimedia/grantmetrics/pull/74.diff","patch_url":"https://github.com/wikimedia/grantmetrics/pull/74.patch","issue_url":"https://api.github.com/repos/wikimedia/grantmetrics/issues/74","number":74,"state":"open","locked":false,"title":"Don't remove orphan wikis when generating stats","user":{"login":"MusikAnimal","id":366374,"node_id":"MDQ6VXNlcjM2NjM3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/366374?v=4","gravatar_id":"","url":"https://api.github.com/users/MusikAnimal","html_url":"https://github.com/MusikAnimal","followers_url":"https://api.github.com/users/MusikAnimal/followers","following_url":"https://api.github.com/users/MusikAnimal/following{/other_user}","gists_url":"https://api.github.com/users/MusikAnimal/gists{/gist_id}","starred_url":"https://api.github.com/users/MusikAnimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MusikAnimal/subscriptions","organizations_url":"https://api.github.com/users/MusikAnimal/orgs","repos_url":"https://api.github.com/users/MusikAnimal/repos","events_url":"https://api.github.com/users/MusikAnimal/events{/privacy}","received_events_url":"https://api.github.com/users/MusikAnimal/received_events","type":"User","site_admin":false},"body":"Bug: https://phabricator.wikimedia.org/T199289","created_at":"2018-07-13T03:18:28Z","updated_at":"2018-07-18T19:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56ff7a8d08d88d006a1400a8f23eed34bc7b0ab3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/74/commits","review_comments_url":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/74/comments","review_comment_url":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/grantmetrics/issues/74/comments","statuses_url":"https://api.github.com/repos/wikimedia/grantmetrics/statuses/34a3b15c4041f1f65af3aebc14ef362313125268","head":{"label":"wikimedia:dont-rm-orphan-wikis","ref":"dont-rm-orphan-wikis","sha":"34a3b15c4041f1f65af3aebc14ef362313125268","user":{"login":"wikimedia","id":56668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjY4","avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":108017937,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgwMTc5Mzc=","name":"grantmetrics","full_name":"wikimedia/grantmetrics","owner":{"login":"wikimedia","id":56668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjY4","avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/grantmetrics","description":"A simple, easy to use interface for reporting shared metrics on WMF wikis","fork":false,"url":"https://api.github.com/repos/wikimedia/grantmetrics","forks_url":"https://api.github.com/repos/wikimedia/grantmetrics/forks","keys_url":"https://api.github.com/repos/wikimedia/grantmetrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/grantmetrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/grantmetrics/teams","hooks_url":"https://api.github.com/repos/wikimedia/grantmetrics/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/grantmetrics/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/grantmetrics/events","assignees_url":"https://api.github.com/repos/wikimedia/grantmetrics/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/grantmetrics/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/grantmetrics/tags","blobs_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/grantmetrics/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/grantmetrics/languages","stargazers_url":"https://api.github.com/repos/wikimedia/grantmetrics/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/grantmetrics/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/grantmetrics/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/grantmetrics/subscription","commits_url":"https://api.github.com/repos/wikimedia/grantmetrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/grantmetrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/grantmetrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/grantmetrics/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/grantmetrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/grantmetrics/merges","archive_url":"https://api.github.com/repos/wikimedia/grantmetrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/grantmetrics/downloads","issues_url":"https://api.github.com/repos/wikimedia/grantmetrics/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/grantmetrics/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/grantmetrics/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/grantmetrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/grantmetrics/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/grantmetrics/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/grantmetrics/deployments","created_at":"2017-10-23T17:50:13Z","updated_at":"2018-07-12T21:09:17Z","pushed_at":"2018-07-17T22:51:15Z","git_url":"git://github.com/wikimedia/grantmetrics.git","ssh_url":"[email protected]:wikimedia/grantmetrics.git","clone_url":"https://github.com/wikimedia/grantmetrics.git","svn_url":"https://github.com/wikimedia/grantmetrics","homepage":"https://tools.wmflabs.org/grantmetrics","size":941,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"f6343b02793bdfdfce7319ce74007a481d6c8e22","user":{"login":"wikimedia","id":56668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjY4","avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":108017937,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgwMTc5Mzc=","name":"grantmetrics","full_name":"wikimedia/grantmetrics","owner":{"login":"wikimedia","id":56668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjY4","avatar_url":"https://avatars0.githubusercontent.com/u/56668?v=4","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/grantmetrics","description":"A simple, easy to use interface for reporting shared metrics on WMF wikis","fork":false,"url":"https://api.github.com/repos/wikimedia/grantmetrics","forks_url":"https://api.github.com/repos/wikimedia/grantmetrics/forks","keys_url":"https://api.github.com/repos/wikimedia/grantmetrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/grantmetrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/grantmetrics/teams","hooks_url":"https://api.github.com/repos/wikimedia/grantmetrics/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/grantmetrics/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/grantmetrics/events","assignees_url":"https://api.github.com/repos/wikimedia/grantmetrics/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/grantmetrics/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/grantmetrics/tags","blobs_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/grantmetrics/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/grantmetrics/languages","stargazers_url":"https://api.github.com/repos/wikimedia/grantmetrics/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/grantmetrics/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/grantmetrics/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/grantmetrics/subscription","commits_url":"https://api.github.com/repos/wikimedia/grantmetrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/grantmetrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/grantmetrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/grantmetrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/grantmetrics/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/grantmetrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/grantmetrics/merges","archive_url":"https://api.github.com/repos/wikimedia/grantmetrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/grantmetrics/downloads","issues_url":"https://api.github.com/repos/wikimedia/grantmetrics/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/grantmetrics/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/grantmetrics/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/grantmetrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/grantmetrics/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/grantmetrics/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/grantmetrics/deployments","created_at":"2017-10-23T17:50:13Z","updated_at":"2018-07-12T21:09:17Z","pushed_at":"2018-07-17T22:51:15Z","git_url":"git://github.com/wikimedia/grantmetrics.git","ssh_url":"[email protected]:wikimedia/grantmetrics.git","clone_url":"https://github.com/wikimedia/grantmetrics.git","svn_url":"https://github.com/wikimedia/grantmetrics","homepage":"https://tools.wmflabs.org/grantmetrics","size":941,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/74"},"html":{"href":"https://github.com/wikimedia/grantmetrics/pull/74"},"issue":{"href":"https://api.github.com/repos/wikimedia/grantmetrics/issues/74"},"comments":{"href":"https://api.github.com/repos/wikimedia/grantmetrics/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/grantmetrics/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/grantmetrics/statuses/34a3b15c4041f1f65af3aebc14ef362313125268"}},"author_association":"CONTRIBUTOR"}} | {
"id": 108017937,
"name": "wikimedia/grantmetrics",
"url": "https://api.github.com/repos/wikimedia/grantmetrics"
} | {
"id": 261238,
"login": "mooeypoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/261238?",
"url": "https://api.github.com/users/mooeypoo"
} | {
"id": 56668,
"login": "wikimedia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56668?",
"url": "https://api.github.com/orgs/wikimedia"
} | 2018-07-18T19:38:56 | 7985067821 | {"actor":{"display_login":"mooeypoo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/leshan/pulls/comments/172238722","pull_request_review_id":101221321,"id":172238722,"diff_hunk":"@@ -52,6 +57,10 @@ public UpdateRequest(String registrationId, Long lifetime, String smsNumber, Bin\n this.lifeTimeInSec = lifetime;\n this.bindingMode = binding;\n this.smsNumber = smsNumber;\n+ if (additionalAttributes == null)\n+ this.additionalAttributes = Collections.emptyMap();\n+ else\n+ this.additionalAttributes = Collections.synchronizedMap(new HashMap<>(additionalAttributes));","path":"leshan-core/src/main/java/org/eclipse/leshan/core/request/UpdateRequest.java","position":35,"original_position":35,"commit_id":"605c6e122142ab078118ea3ac5f3f83ccd104e9e","original_commit_id":"605c6e122142ab078118ea3ac5f3f83ccd104e9e","user":{"login":"sbernard31","id":840294,"avatar_url":"https://avatars2.githubusercontent.com/u/840294?v=4","gravatar_id":"","url":"https://api.github.com/users/sbernard31","html_url":"https://github.com/sbernard31","followers_url":"https://api.github.com/users/sbernard31/followers","following_url":"https://api.github.com/users/sbernard31/following{/other_user}","gists_url":"https://api.github.com/users/sbernard31/gists{/gist_id}","starred_url":"https://api.github.com/users/sbernard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbernard31/subscriptions","organizations_url":"https://api.github.com/users/sbernard31/orgs","repos_url":"https://api.github.com/users/sbernard31/repos","events_url":"https://api.github.com/users/sbernard31/events{/privacy}","received_events_url":"https://api.github.com/users/sbernard31/received_events","type":"User","site_admin":false},"body":"`UpdateRequest` should be immutable.","created_at":"2018-03-05T16:09:29Z","updated_at":"2018-03-05T16:33:18Z","html_url":"https://github.com/eclipse/leshan/pull/481#discussion_r172238722","pull_request_url":"https://api.github.com/repos/eclipse/leshan/pulls/481","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/comments/172238722"},"html":{"href":"https://github.com/eclipse/leshan/pull/481#discussion_r172238722"},"pull_request":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/481"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/leshan/pulls/481","id":172836457,"html_url":"https://github.com/eclipse/leshan/pull/481","diff_url":"https://github.com/eclipse/leshan/pull/481.diff","patch_url":"https://github.com/eclipse/leshan/pull/481.patch","issue_url":"https://api.github.com/repos/eclipse/leshan/issues/481","number":481,"state":"open","locked":false,"title":"Update the additionalRegistrationParameters when update messages are received","user":{"login":"carlosgp143","id":6625065,"avatar_url":"https://avatars0.githubusercontent.com/u/6625065?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosgp143","html_url":"https://github.com/carlosgp143","followers_url":"https://api.github.com/users/carlosgp143/followers","following_url":"https://api.github.com/users/carlosgp143/following{/other_user}","gists_url":"https://api.github.com/users/carlosgp143/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosgp143/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosgp143/subscriptions","organizations_url":"https://api.github.com/users/carlosgp143/orgs","repos_url":"https://api.github.com/users/carlosgp143/repos","events_url":"https://api.github.com/users/carlosgp143/events{/privacy}","received_events_url":"https://api.github.com/users/carlosgp143/received_events","type":"User","site_admin":false},"body":"Hi all!\r\n\r\nHere I come with a PR to update the `additionalRegistrationParameters` of the registration object when they are included in the update message. This is, among other applications, useful to use with Queue Mode to update the client awake time.\r\n\r\nI have basically treated the additional parameters as they are treated regarding the Registration, so the code is very similar to the one present in those classes. Now the Map containing this parameters has changed from the type `Collections.unmodifiableMap` to `Collections.synchronizedMap`. Then, when new parameters arrive in the update message, using the method `putAll()` the already present attributes are updated with the new values, and the new ones are added.\r\n\r\nRegarding the serialization used in the cluster, I'm not very familiar with this, but I have implemented the same code as in the serialization of the registration object, and it seems to pass correctly the JUnit test. But please check this in detail.\r\n\r\nAll feedback is welcomed :-)","created_at":"2018-03-05T11:06:39Z","updated_at":"2018-03-05T16:33:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d161103b220169e5b340a5f3e6aa4ad2688b2239","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/leshan/pulls/481/commits","review_comments_url":"https://api.github.com/repos/eclipse/leshan/pulls/481/comments","review_comment_url":"https://api.github.com/repos/eclipse/leshan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/leshan/issues/481/comments","statuses_url":"https://api.github.com/repos/eclipse/leshan/statuses/605c6e122142ab078118ea3ac5f3f83ccd104e9e","head":{"label":"carlosgp143:feature/update_additionalRegAttr","ref":"feature/update_additionalRegAttr","sha":"605c6e122142ab078118ea3ac5f3f83ccd104e9e","user":{"login":"carlosgp143","id":6625065,"avatar_url":"https://avatars0.githubusercontent.com/u/6625065?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosgp143","html_url":"https://github.com/carlosgp143","followers_url":"https://api.github.com/users/carlosgp143/followers","following_url":"https://api.github.com/users/carlosgp143/following{/other_user}","gists_url":"https://api.github.com/users/carlosgp143/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosgp143/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosgp143/subscriptions","organizations_url":"https://api.github.com/users/carlosgp143/orgs","repos_url":"https://api.github.com/users/carlosgp143/repos","events_url":"https://api.github.com/users/carlosgp143/events{/privacy}","received_events_url":"https://api.github.com/users/carlosgp143/received_events","type":"User","site_admin":false},"repo":{"id":114260147,"name":"leshan","full_name":"carlosgp143/leshan","owner":{"login":"carlosgp143","id":6625065,"avatar_url":"https://avatars0.githubusercontent.com/u/6625065?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosgp143","html_url":"https://github.com/carlosgp143","followers_url":"https://api.github.com/users/carlosgp143/followers","following_url":"https://api.github.com/users/carlosgp143/following{/other_user}","gists_url":"https://api.github.com/users/carlosgp143/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosgp143/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosgp143/subscriptions","organizations_url":"https://api.github.com/users/carlosgp143/orgs","repos_url":"https://api.github.com/users/carlosgp143/repos","events_url":"https://api.github.com/users/carlosgp143/events{/privacy}","received_events_url":"https://api.github.com/users/carlosgp143/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carlosgp143/leshan","description":"Eclipse Leshan is an OMA Lightweight M2M (LWM2M) implementation in Java.","fork":true,"url":"https://api.github.com/repos/carlosgp143/leshan","forks_url":"https://api.github.com/repos/carlosgp143/leshan/forks","keys_url":"https://api.github.com/repos/carlosgp143/leshan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlosgp143/leshan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlosgp143/leshan/teams","hooks_url":"https://api.github.com/repos/carlosgp143/leshan/hooks","issue_events_url":"https://api.github.com/repos/carlosgp143/leshan/issues/events{/number}","events_url":"https://api.github.com/repos/carlosgp143/leshan/events","assignees_url":"https://api.github.com/repos/carlosgp143/leshan/assignees{/user}","branches_url":"https://api.github.com/repos/carlosgp143/leshan/branches{/branch}","tags_url":"https://api.github.com/repos/carlosgp143/leshan/tags","blobs_url":"https://api.github.com/repos/carlosgp143/leshan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlosgp143/leshan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlosgp143/leshan/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlosgp143/leshan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlosgp143/leshan/statuses/{sha}","languages_url":"https://api.github.com/repos/carlosgp143/leshan/languages","stargazers_url":"https://api.github.com/repos/carlosgp143/leshan/stargazers","contributors_url":"https://api.github.com/repos/carlosgp143/leshan/contributors","subscribers_url":"https://api.github.com/repos/carlosgp143/leshan/subscribers","subscription_url":"https://api.github.com/repos/carlosgp143/leshan/subscription","commits_url":"https://api.github.com/repos/carlosgp143/leshan/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlosgp143/leshan/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlosgp143/leshan/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlosgp143/leshan/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlosgp143/leshan/contents/{+path}","compare_url":"https://api.github.com/repos/carlosgp143/leshan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlosgp143/leshan/merges","archive_url":"https://api.github.com/repos/carlosgp143/leshan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlosgp143/leshan/downloads","issues_url":"https://api.github.com/repos/carlosgp143/leshan/issues{/number}","pulls_url":"https://api.github.com/repos/carlosgp143/leshan/pulls{/number}","milestones_url":"https://api.github.com/repos/carlosgp143/leshan/milestones{/number}","notifications_url":"https://api.github.com/repos/carlosgp143/leshan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlosgp143/leshan/labels{/name}","releases_url":"https://api.github.com/repos/carlosgp143/leshan/releases{/id}","deployments_url":"https://api.github.com/repos/carlosgp143/leshan/deployments","created_at":"2017-12-14T14:29:02Z","updated_at":"2017-12-14T14:29:05Z","pushed_at":"2018-03-05T10:59:18Z","git_url":"git://github.com/carlosgp143/leshan.git","ssh_url":"[email protected]:carlosgp143/leshan.git","clone_url":"https://github.com/carlosgp143/leshan.git","svn_url":"https://github.com/carlosgp143/leshan","homepage":"","size":3885,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"1c322bf6efc077c433bc2cfbb6324cd2abce9571","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":30419413,"name":"leshan","full_name":"eclipse/leshan","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/leshan","description":"Eclipse Leshan is an OMA Lightweight M2M (LWM2M) implementation in Java.","fork":false,"url":"https://api.github.com/repos/eclipse/leshan","forks_url":"https://api.github.com/repos/eclipse/leshan/forks","keys_url":"https://api.github.com/repos/eclipse/leshan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/leshan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/leshan/teams","hooks_url":"https://api.github.com/repos/eclipse/leshan/hooks","issue_events_url":"https://api.github.com/repos/eclipse/leshan/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/leshan/events","assignees_url":"https://api.github.com/repos/eclipse/leshan/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/leshan/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/leshan/tags","blobs_url":"https://api.github.com/repos/eclipse/leshan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/leshan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/leshan/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/leshan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/leshan/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/leshan/languages","stargazers_url":"https://api.github.com/repos/eclipse/leshan/stargazers","contributors_url":"https://api.github.com/repos/eclipse/leshan/contributors","subscribers_url":"https://api.github.com/repos/eclipse/leshan/subscribers","subscription_url":"https://api.github.com/repos/eclipse/leshan/subscription","commits_url":"https://api.github.com/repos/eclipse/leshan/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/leshan/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/leshan/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/leshan/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/leshan/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/leshan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/leshan/merges","archive_url":"https://api.github.com/repos/eclipse/leshan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/leshan/downloads","issues_url":"https://api.github.com/repos/eclipse/leshan/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/leshan/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/leshan/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/leshan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/leshan/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/leshan/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/leshan/deployments","created_at":"2015-02-06T15:44:24Z","updated_at":"2018-02-28T08:47:36Z","pushed_at":"2018-03-05T11:06:40Z","git_url":"git://github.com/eclipse/leshan.git","ssh_url":"[email protected]:eclipse/leshan.git","clone_url":"https://github.com/eclipse/leshan.git","svn_url":"https://github.com/eclipse/leshan","homepage":"","size":3828,"stargazers_count":202,"watchers_count":202,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":165,"open_issues":41,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/481"},"html":{"href":"https://github.com/eclipse/leshan/pull/481"},"issue":{"href":"https://api.github.com/repos/eclipse/leshan/issues/481"},"comments":{"href":"https://api.github.com/repos/eclipse/leshan/issues/481/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/481/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/481/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/leshan/statuses/605c6e122142ab078118ea3ac5f3f83ccd104e9e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 30419413,
"name": "eclipse/leshan",
"url": "https://api.github.com/repos/eclipse/leshan"
} | {
"id": 840294,
"login": "sbernard31",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/840294?",
"url": "https://api.github.com/users/sbernard31"
} | {
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
} | 2018-03-05T16:09:29 | 7332521600 | {"actor":{"display_login":"sbernard31"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/hono/pulls/comments/241035650","pull_request_review_id":184204864,"id":241035650,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTAzNTY1MA==","diff_hunk":"@@ -0,0 +1,28 @@\n+/*******************************************************************************\n+ * Copyright (c) 2016, 2018 Contributors to the Eclipse Foundation\n+ *\n+ * See the NOTICE file(s) distributed with this work for additional\n+ * information regarding copyright ownership.\n+ *\n+ * This program and the accompanying materials are made available under the\n+ * terms of the Eclipse Public License 2.0 which is available at\n+ * http://www.eclipse.org/legal/epl-2.0\n+ *\n+ * SPDX-License-Identifier: EPL-2.0\n+ *******************************************************************************/\n+\n+package org.eclipse.hono.service;\n+\n+/**\n+ * Provides a server for health checks.\n+ */\n+public interface HealthCheckRegistration extends Lifecycle {","path":"service-base/src/main/java/org/eclipse/hono/service/HealthCheckRegistration.java","position":19,"original_position":19,"commit_id":"683470075e932d9da79801d7a444b26b4d5c4855","original_commit_id":"683470075e932d9da79801d7a444b26b4d5c4855","user":{"login":"b-abel","id":7031135,"node_id":"MDQ6VXNlcjcwMzExMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/7031135?v=4","gravatar_id":"","url":"https://api.github.com/users/b-abel","html_url":"https://github.com/b-abel","followers_url":"https://api.github.com/users/b-abel/followers","following_url":"https://api.github.com/users/b-abel/following{/other_user}","gists_url":"https://api.github.com/users/b-abel/gists{/gist_id}","starred_url":"https://api.github.com/users/b-abel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-abel/subscriptions","organizations_url":"https://api.github.com/users/b-abel/orgs","repos_url":"https://api.github.com/users/b-abel/repos","events_url":"https://api.github.com/users/b-abel/events{/privacy}","received_events_url":"https://api.github.com/users/b-abel/received_events","type":"User","site_admin":false},"body":"To be honest, this was a compromise because that is already the name of the class implementing it and the diff would be horror if I rename the class and give it's name to the interface. If you are willing to go through diff hell I can rename to rename both :)","created_at":"2018-12-12T14:31:45Z","updated_at":"2018-12-12T14:31:45Z","html_url":"https://github.com/eclipse/hono/pull/959#discussion_r241035650","pull_request_url":"https://api.github.com/repos/eclipse/hono/pulls/959","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments/241035650"},"html":{"href":"https://github.com/eclipse/hono/pull/959#discussion_r241035650"},"pull_request":{"href":"https://api.github.com/repos/eclipse/hono/pulls/959"}},"in_reply_to_id":241022221},"pull_request":{"url":"https://api.github.com/repos/eclipse/hono/pulls/959","id":238027280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDI3Mjgw","html_url":"https://github.com/eclipse/hono/pull/959","diff_url":"https://github.com/eclipse/hono/pull/959.diff","patch_url":"https://github.com/eclipse/hono/pull/959.patch","issue_url":"https://api.github.com/repos/eclipse/hono/issues/959","number":959,"state":"open","locked":false,"title":"[#750] Health check for all verticle instances.","user":{"login":"b-abel","id":7031135,"node_id":"MDQ6VXNlcjcwMzExMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/7031135?v=4","gravatar_id":"","url":"https://api.github.com/users/b-abel","html_url":"https://github.com/b-abel","followers_url":"https://api.github.com/users/b-abel/followers","following_url":"https://api.github.com/users/b-abel/following{/other_user}","gists_url":"https://api.github.com/users/b-abel/gists{/gist_id}","starred_url":"https://api.github.com/users/b-abel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-abel/subscriptions","organizations_url":"https://api.github.com/users/b-abel/orgs","repos_url":"https://api.github.com/users/b-abel/repos","events_url":"https://api.github.com/users/b-abel/events{/privacy}","received_events_url":"https://api.github.com/users/b-abel/received_events","type":"User","site_admin":false},"body":"This replaces the PR #873 and is based on the discussion there.\r\n\r\nVertx handles the number of instances for each Verticle.\r\n\r\nHealthCheckServer is now a bean. If the bean is present, it must be configured (port given). If the bean is not present a Noop-implementation is used.\r\n\r\nRefactor: the configuration of `ApplicationConfigProperties` beans is moved from individual protocol adapters to `AbstractAdapterConfig`.\r\n","created_at":"2018-12-12T12:55:00Z","updated_at":"2018-12-12T14:31:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b6e4b52ee69745c13bececdeab9b82f37680c02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/hono/pulls/959/commits","review_comments_url":"https://api.github.com/repos/eclipse/hono/pulls/959/comments","review_comment_url":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/hono/issues/959/comments","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/683470075e932d9da79801d7a444b26b4d5c4855","head":{"label":"bsinno:#750_healthcheck_all_vertical_instances","ref":"#750_healthcheck_all_vertical_instances","sha":"683470075e932d9da79801d7a444b26b4d5c4855","user":{"login":"bsinno","id":9215699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMTU2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":51764062,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc2NDA2Mg==","name":"hono","full_name":"bsinno/hono","private":false,"owner":{"login":"bsinno","id":9215699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMTU2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bsinno/hono","description":"Hono project","fork":true,"url":"https://api.github.com/repos/bsinno/hono","forks_url":"https://api.github.com/repos/bsinno/hono/forks","keys_url":"https://api.github.com/repos/bsinno/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/hono/teams","hooks_url":"https://api.github.com/repos/bsinno/hono/hooks","issue_events_url":"https://api.github.com/repos/bsinno/hono/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/hono/events","assignees_url":"https://api.github.com/repos/bsinno/hono/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/hono/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/hono/tags","blobs_url":"https://api.github.com/repos/bsinno/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/hono/languages","stargazers_url":"https://api.github.com/repos/bsinno/hono/stargazers","contributors_url":"https://api.github.com/repos/bsinno/hono/contributors","subscribers_url":"https://api.github.com/repos/bsinno/hono/subscribers","subscription_url":"https://api.github.com/repos/bsinno/hono/subscription","commits_url":"https://api.github.com/repos/bsinno/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/hono/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/hono/merges","archive_url":"https://api.github.com/repos/bsinno/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/hono/downloads","issues_url":"https://api.github.com/repos/bsinno/hono/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/hono/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/hono/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/hono/deployments","created_at":"2016-02-15T15:18:09Z","updated_at":"2018-12-11T16:52:43Z","pushed_at":"2018-12-12T14:07:49Z","git_url":"git://github.com/bsinno/hono.git","ssh_url":"[email protected]:bsinno/hono.git","clone_url":"https://github.com/bsinno/hono.git","svn_url":"https://github.com/bsinno/hono","homepage":null,"size":17866,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"2278cb03f26e8a1fa9c55b9445b6b1470d220854","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":51307016,"node_id":"MDEwOlJlcG9zaXRvcnk1MTMwNzAxNg==","name":"hono","full_name":"eclipse/hono","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/hono","description":"Eclipse Hono™ Project","fork":false,"url":"https://api.github.com/repos/eclipse/hono","forks_url":"https://api.github.com/repos/eclipse/hono/forks","keys_url":"https://api.github.com/repos/eclipse/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/hono/teams","hooks_url":"https://api.github.com/repos/eclipse/hono/hooks","issue_events_url":"https://api.github.com/repos/eclipse/hono/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/hono/events","assignees_url":"https://api.github.com/repos/eclipse/hono/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/hono/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/hono/tags","blobs_url":"https://api.github.com/repos/eclipse/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/hono/languages","stargazers_url":"https://api.github.com/repos/eclipse/hono/stargazers","contributors_url":"https://api.github.com/repos/eclipse/hono/contributors","subscribers_url":"https://api.github.com/repos/eclipse/hono/subscribers","subscription_url":"https://api.github.com/repos/eclipse/hono/subscription","commits_url":"https://api.github.com/repos/eclipse/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/hono/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/hono/merges","archive_url":"https://api.github.com/repos/eclipse/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/hono/downloads","issues_url":"https://api.github.com/repos/eclipse/hono/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/hono/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/hono/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/hono/deployments","created_at":"2016-02-08T15:45:28Z","updated_at":"2018-12-12T13:48:46Z","pushed_at":"2018-12-12T14:07:50Z","git_url":"git://github.com/eclipse/hono.git","ssh_url":"[email protected]:eclipse/hono.git","clone_url":"https://github.com/eclipse/hono.git","svn_url":"https://github.com/eclipse/hono","homepage":"http://www.eclipse.org/hono","size":17555,"stargazers_count":177,"watchers_count":177,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":58,"open_issues":77,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/959"},"html":{"href":"https://github.com/eclipse/hono/pull/959"},"issue":{"href":"https://api.github.com/repos/eclipse/hono/issues/959"},"comments":{"href":"https://api.github.com/repos/eclipse/hono/issues/959/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/hono/pulls/959/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/hono/pulls/959/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/hono/statuses/683470075e932d9da79801d7a444b26b4d5c4855"}},"author_association":"CONTRIBUTOR"}} | {
"id": 51307016,
"name": "eclipse/hono",
"url": "https://api.github.com/repos/eclipse/hono"
} | {
"id": 7031135,
"login": "b-abel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7031135?",
"url": "https://api.github.com/users/b-abel"
} | {
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
} | 2018-12-12T14:31:45 | 8741622137 | {"actor":{"display_login":"b-abel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/sw360/pulls/comments/206483506","pull_request_review_id":141902455,"id":206483506,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjQ4MzUwNg==","diff_hunk":"@@ -116,6 +119,20 @@ struct LicenseInfoUsage {\n 1: required set<string> excludedLicenseIds;\n }\n \n+/**\n+ * Flags an attachment when it is used for source code bundle generation.\n+ */\n+struct SourcePackageUsage {","path":"libraries/lib-datahandler/src/main/thrift/attachments.thrift","position":27,"original_position":27,"commit_id":"6fb17e7929e9d854b20732e38db303a66be0687b","original_commit_id":"6fb17e7929e9d854b20732e38db303a66be0687b","user":{"login":"alexbrdn","id":16780167,"node_id":"MDQ6VXNlcjE2NzgwMTY3","avatar_url":"https://avatars0.githubusercontent.com/u/16780167?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrdn","html_url":"https://github.com/alexbrdn","followers_url":"https://api.github.com/users/alexbrdn/followers","following_url":"https://api.github.com/users/alexbrdn/following{/other_user}","gists_url":"https://api.github.com/users/alexbrdn/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrdn/subscriptions","organizations_url":"https://api.github.com/users/alexbrdn/orgs","repos_url":"https://api.github.com/users/alexbrdn/repos","events_url":"https://api.github.com/users/alexbrdn/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrdn/received_events","type":"User","site_admin":false},"body":"As I hoped the comment explains, the field is necessary for jackson to be able to serialize instances of the generated class. When there are no fields, jackson can't generate a serializer for the class and fails with an obscure exception. Took me a long time to figure out why it failed.\r\n\r\nSo, yes, it is indeed a hack, but I couldn't come up with a cleaner version. If anyone has any ideas, I'm all ears.","created_at":"2018-07-31T11:03:11Z","updated_at":"2018-07-31T11:03:11Z","html_url":"https://github.com/eclipse/sw360/pull/324#discussion_r206483506","pull_request_url":"https://api.github.com/repos/eclipse/sw360/pulls/324","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/sw360/pulls/comments/206483506"},"html":{"href":"https://github.com/eclipse/sw360/pull/324#discussion_r206483506"},"pull_request":{"href":"https://api.github.com/repos/eclipse/sw360/pulls/324"}},"in_reply_to_id":206449372},"pull_request":{"url":"https://api.github.com/repos/eclipse/sw360/pulls/324","id":201901219,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTAxMjE5","html_url":"https://github.com/eclipse/sw360/pull/324","diff_url":"https://github.com/eclipse/sw360/pull/324.diff","patch_url":"https://github.com/eclipse/sw360/pull/324.patch","issue_url":"https://api.github.com/repos/eclipse/sw360/issues/324","number":324,"state":"open","locked":false,"title":"feature(attachments): enable viewing/editing of attachment usages","user":{"login":"alexbrdn","id":16780167,"node_id":"MDQ6VXNlcjE2NzgwMTY3","avatar_url":"https://avatars0.githubusercontent.com/u/16780167?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrdn","html_url":"https://github.com/alexbrdn","followers_url":"https://api.github.com/users/alexbrdn/followers","following_url":"https://api.github.com/users/alexbrdn/following{/other_user}","gists_url":"https://api.github.com/users/alexbrdn/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrdn/subscriptions","organizations_url":"https://api.github.com/users/alexbrdn/orgs","repos_url":"https://api.github.com/users/alexbrdn/repos","events_url":"https://api.github.com/users/alexbrdn/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrdn/received_events","type":"User","site_admin":false},"body":"- enable viewing/editing of attachment usages\r\n- lock used attachments from deletion\r\n- automatically save attachment usages on source code bundle generation\r\n\r\ncloses eclipse/sw360#153","created_at":"2018-07-17T10:53:38Z","updated_at":"2018-07-31T11:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d0bf08dfd4433f0c6073b5d216b1c448c775861","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":910986147,"node_id":"MDU6TGFiZWw5MTA5ODYxNDc=","url":"https://api.github.com/repos/eclipse/sw360/labels/needs%20code%20review","name":"needs code review","color":"006000","default":false},{"id":910986254,"node_id":"MDU6TGFiZWw5MTA5ODYyNTQ=","url":"https://api.github.com/repos/eclipse/sw360/labels/needs%20test","name":"needs test","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/sw360/pulls/324/commits","review_comments_url":"https://api.github.com/repos/eclipse/sw360/pulls/324/comments","review_comment_url":"https://api.github.com/repos/eclipse/sw360/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/sw360/issues/324/comments","statuses_url":"https://api.github.com/repos/eclipse/sw360/statuses/6fb17e7929e9d854b20732e38db303a66be0687b","head":{"label":"eclipse:alexbrdn/#153/attachment-usage-info","ref":"alexbrdn/#153/attachment-usage-info","sha":"6fb17e7929e9d854b20732e38db303a66be0687b","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":129769092,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3NjkwOTI=","name":"sw360","full_name":"eclipse/sw360","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/sw360","description":"SW360 project","fork":false,"url":"https://api.github.com/repos/eclipse/sw360","forks_url":"https://api.github.com/repos/eclipse/sw360/forks","keys_url":"https://api.github.com/repos/eclipse/sw360/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/sw360/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/sw360/teams","hooks_url":"https://api.github.com/repos/eclipse/sw360/hooks","issue_events_url":"https://api.github.com/repos/eclipse/sw360/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/sw360/events","assignees_url":"https://api.github.com/repos/eclipse/sw360/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/sw360/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/sw360/tags","blobs_url":"https://api.github.com/repos/eclipse/sw360/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/sw360/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/sw360/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/sw360/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/sw360/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/sw360/languages","stargazers_url":"https://api.github.com/repos/eclipse/sw360/stargazers","contributors_url":"https://api.github.com/repos/eclipse/sw360/contributors","subscribers_url":"https://api.github.com/repos/eclipse/sw360/subscribers","subscription_url":"https://api.github.com/repos/eclipse/sw360/subscription","commits_url":"https://api.github.com/repos/eclipse/sw360/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/sw360/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/sw360/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/sw360/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/sw360/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/sw360/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/sw360/merges","archive_url":"https://api.github.com/repos/eclipse/sw360/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/sw360/downloads","issues_url":"https://api.github.com/repos/eclipse/sw360/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/sw360/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/sw360/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/sw360/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/sw360/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/sw360/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/sw360/deployments","created_at":"2018-04-16T15:54:19Z","updated_at":"2018-07-26T08:18:22Z","pushed_at":"2018-07-30T16:39:43Z","git_url":"git://github.com/eclipse/sw360.git","ssh_url":"[email protected]:eclipse/sw360.git","clone_url":"https://github.com/eclipse/sw360.git","svn_url":"https://github.com/eclipse/sw360","homepage":null,"size":1440,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":168,"watchers":11,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"b1102322dacc39499e913267683211f9981fc90d","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":129769092,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3NjkwOTI=","name":"sw360","full_name":"eclipse/sw360","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/sw360","description":"SW360 project","fork":false,"url":"https://api.github.com/repos/eclipse/sw360","forks_url":"https://api.github.com/repos/eclipse/sw360/forks","keys_url":"https://api.github.com/repos/eclipse/sw360/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/sw360/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/sw360/teams","hooks_url":"https://api.github.com/repos/eclipse/sw360/hooks","issue_events_url":"https://api.github.com/repos/eclipse/sw360/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/sw360/events","assignees_url":"https://api.github.com/repos/eclipse/sw360/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/sw360/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/sw360/tags","blobs_url":"https://api.github.com/repos/eclipse/sw360/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/sw360/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/sw360/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/sw360/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/sw360/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/sw360/languages","stargazers_url":"https://api.github.com/repos/eclipse/sw360/stargazers","contributors_url":"https://api.github.com/repos/eclipse/sw360/contributors","subscribers_url":"https://api.github.com/repos/eclipse/sw360/subscribers","subscription_url":"https://api.github.com/repos/eclipse/sw360/subscription","commits_url":"https://api.github.com/repos/eclipse/sw360/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/sw360/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/sw360/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/sw360/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/sw360/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/sw360/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/sw360/merges","archive_url":"https://api.github.com/repos/eclipse/sw360/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/sw360/downloads","issues_url":"https://api.github.com/repos/eclipse/sw360/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/sw360/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/sw360/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/sw360/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/sw360/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/sw360/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/sw360/deployments","created_at":"2018-04-16T15:54:19Z","updated_at":"2018-07-26T08:18:22Z","pushed_at":"2018-07-30T16:39:43Z","git_url":"git://github.com/eclipse/sw360.git","ssh_url":"[email protected]:eclipse/sw360.git","clone_url":"https://github.com/eclipse/sw360.git","svn_url":"https://github.com/eclipse/sw360","homepage":null,"size":1440,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":168,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/sw360/pulls/324"},"html":{"href":"https://github.com/eclipse/sw360/pull/324"},"issue":{"href":"https://api.github.com/repos/eclipse/sw360/issues/324"},"comments":{"href":"https://api.github.com/repos/eclipse/sw360/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/sw360/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/sw360/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/sw360/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/sw360/statuses/6fb17e7929e9d854b20732e38db303a66be0687b"}},"author_association":"CONTRIBUTOR"}} | {
"id": 129769092,
"name": "eclipse/sw360",
"url": "https://api.github.com/repos/eclipse/sw360"
} | {
"id": 16780167,
"login": "alexbrdn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16780167?",
"url": "https://api.github.com/users/alexbrdn"
} | {
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
} | 2018-07-31T11:03:11 | 8043339909 | {"actor":{"display_login":"alexbrdn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/elk/pulls/comments/241947637","pull_request_review_id":185352795,"id":241947637,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTk0NzYzNw==","diff_hunk":"@@ -0,0 +1,173 @@\n+/*******************************************************************************\n+ * Copyright (c) 2018 Kiel University and others.\n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * which accompanies this distribution, and is available at\n+ * http://www.eclipse.org/legal/epl-v10.html\n+ *******************************************************************************/\n+package org.eclipse.elk.core.meta.formatting2\n+\n+import org.eclipse.xtext.formatting2.AbstractFormatter2\n+import org.eclipse.xtext.formatting2.IFormattableDocument\n+import org.eclipse.elk.core.meta.metaData.MdBundle\n+import org.eclipse.xtext.xbase.lib.Procedures.Procedure1\n+import org.eclipse.xtext.formatting2.IHiddenRegionFormatter\n+import org.eclipse.elk.core.meta.services.MetaDataGrammarAccess\n+import org.eclipse.xtext.formatting2.regionaccess.ISemanticRegion\n+import com.google.inject.Inject\n+import org.eclipse.elk.core.meta.metaData.MdGroup\n+import org.eclipse.elk.core.meta.metaData.MdOption\n+import org.eclipse.elk.core.meta.metaData.MdOptionDependency\n+import org.eclipse.elk.core.meta.metaData.MdAlgorithm\n+import org.eclipse.elk.core.meta.metaData.MdCategory\n+import org.eclipse.elk.core.meta.metaData.MdOptionSupport\n+import org.eclipse.elk.core.meta.metaData.MdBundleMember\n+import org.eclipse.elk.core.meta.metaData.MdGroupOrOption\n+\n+class MetaDataFormatter extends AbstractFormatter2 {\n+\n+ static val Procedure1<? super IHiddenRegionFormatter> one_space = [oneSpace]\n+ static val Procedure1<? super IHiddenRegionFormatter> new_line = [newLine]\n+ static val Procedure1<? super IHiddenRegionFormatter> indention = [indent]\n+\n+ @Inject extension MetaDataGrammarAccess\n+ \n+ def dispatch void format (MdBundleMember bundleMember, extension IFormattableDocument document){ \n+ if(bundleMember instanceof MdAlgorithm){","path":"plugins/org.eclipse.elk.core.meta/src/org/eclipse/elk/core/meta/formatting2/MetaDataFormatter.xtend","position":36,"original_position":36,"commit_id":"19a183f6775ee0b0cdc8807826a15b6d0a189b63","original_commit_id":"19a183f6775ee0b0cdc8807826a15b6d0a189b63","user":{"login":"uruuru","id":7552459,"node_id":"MDQ6VXNlcjc1NTI0NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7552459?v=4","gravatar_id":"","url":"https://api.github.com/users/uruuru","html_url":"https://github.com/uruuru","followers_url":"https://api.github.com/users/uruuru/followers","following_url":"https://api.github.com/users/uruuru/following{/other_user}","gists_url":"https://api.github.com/users/uruuru/gists{/gist_id}","starred_url":"https://api.github.com/users/uruuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uruuru/subscriptions","organizations_url":"https://api.github.com/users/uruuru/orgs","repos_url":"https://api.github.com/users/uruuru/repos","events_url":"https://api.github.com/users/uruuru/events{/privacy}","received_events_url":"https://api.github.com/users/uruuru/received_events","type":"User","site_admin":false},"body":"Check your formatting of xtend files please. There should be a space after `if` and one before `{` and so on.","created_at":"2018-12-15T12:10:04Z","updated_at":"2018-12-15T12:14:10Z","html_url":"https://github.com/eclipse/elk/pull/391#discussion_r241947637","pull_request_url":"https://api.github.com/repos/eclipse/elk/pulls/391","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/elk/pulls/comments/241947637"},"html":{"href":"https://github.com/eclipse/elk/pull/391#discussion_r241947637"},"pull_request":{"href":"https://api.github.com/repos/eclipse/elk/pulls/391"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/elk/pulls/391","id":238661563,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NjYxNTYz","html_url":"https://github.com/eclipse/elk/pull/391","diff_url":"https://github.com/eclipse/elk/pull/391.diff","patch_url":"https://github.com/eclipse/elk/pull/391.patch","issue_url":"https://api.github.com/repos/eclipse/elk/issues/391","number":391,"state":"open","locked":false,"title":"Meta: Implemented formatter for MetaData language.","user":{"login":"dalu2104","id":33313925,"node_id":"MDQ6VXNlcjMzMzEzOTI1","avatar_url":"https://avatars2.githubusercontent.com/u/33313925?v=4","gravatar_id":"","url":"https://api.github.com/users/dalu2104","html_url":"https://github.com/dalu2104","followers_url":"https://api.github.com/users/dalu2104/followers","following_url":"https://api.github.com/users/dalu2104/following{/other_user}","gists_url":"https://api.github.com/users/dalu2104/gists{/gist_id}","starred_url":"https://api.github.com/users/dalu2104/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalu2104/subscriptions","organizations_url":"https://api.github.com/users/dalu2104/orgs","repos_url":"https://api.github.com/users/dalu2104/repos","events_url":"https://api.github.com/users/dalu2104/events{/privacy}","received_events_url":"https://api.github.com/users/dalu2104/received_events","type":"User","site_admin":false},"body":"Implemented a formatter for the MetaData lanuage in `elk.core.meta`. Needed artifacts were created accordingly.\r\n\r\nIssue: #353\r\n\r\nSigned-off-by: Daniel Lucas <[email protected]> \r\n\r\n","created_at":"2018-12-14T09:40:15Z","updated_at":"2018-12-15T12:14:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5f6a8a73be43f929c1ef0f2ebffcaf305faf0e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/elk/pulls/391/commits","review_comments_url":"https://api.github.com/repos/eclipse/elk/pulls/391/comments","review_comment_url":"https://api.github.com/repos/eclipse/elk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/elk/issues/391/comments","statuses_url":"https://api.github.com/repos/eclipse/elk/statuses/19a183f6775ee0b0cdc8807826a15b6d0a189b63","head":{"label":"dalu2104:353_melk_autoformatting","ref":"353_melk_autoformatting","sha":"19a183f6775ee0b0cdc8807826a15b6d0a189b63","user":{"login":"dalu2104","id":33313925,"node_id":"MDQ6VXNlcjMzMzEzOTI1","avatar_url":"https://avatars2.githubusercontent.com/u/33313925?v=4","gravatar_id":"","url":"https://api.github.com/users/dalu2104","html_url":"https://github.com/dalu2104","followers_url":"https://api.github.com/users/dalu2104/followers","following_url":"https://api.github.com/users/dalu2104/following{/other_user}","gists_url":"https://api.github.com/users/dalu2104/gists{/gist_id}","starred_url":"https://api.github.com/users/dalu2104/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalu2104/subscriptions","organizations_url":"https://api.github.com/users/dalu2104/orgs","repos_url":"https://api.github.com/users/dalu2104/repos","events_url":"https://api.github.com/users/dalu2104/events{/privacy}","received_events_url":"https://api.github.com/users/dalu2104/received_events","type":"User","site_admin":false},"repo":{"id":151245451,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyNDU0NTE=","name":"elk","full_name":"dalu2104/elk","private":false,"owner":{"login":"dalu2104","id":33313925,"node_id":"MDQ6VXNlcjMzMzEzOTI1","avatar_url":"https://avatars2.githubusercontent.com/u/33313925?v=4","gravatar_id":"","url":"https://api.github.com/users/dalu2104","html_url":"https://github.com/dalu2104","followers_url":"https://api.github.com/users/dalu2104/followers","following_url":"https://api.github.com/users/dalu2104/following{/other_user}","gists_url":"https://api.github.com/users/dalu2104/gists{/gist_id}","starred_url":"https://api.github.com/users/dalu2104/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalu2104/subscriptions","organizations_url":"https://api.github.com/users/dalu2104/orgs","repos_url":"https://api.github.com/users/dalu2104/repos","events_url":"https://api.github.com/users/dalu2104/events{/privacy}","received_events_url":"https://api.github.com/users/dalu2104/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dalu2104/elk","description":"Eclipse Layout Kernel - Automatic layout for Java applications.","fork":true,"url":"https://api.github.com/repos/dalu2104/elk","forks_url":"https://api.github.com/repos/dalu2104/elk/forks","keys_url":"https://api.github.com/repos/dalu2104/elk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dalu2104/elk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dalu2104/elk/teams","hooks_url":"https://api.github.com/repos/dalu2104/elk/hooks","issue_events_url":"https://api.github.com/repos/dalu2104/elk/issues/events{/number}","events_url":"https://api.github.com/repos/dalu2104/elk/events","assignees_url":"https://api.github.com/repos/dalu2104/elk/assignees{/user}","branches_url":"https://api.github.com/repos/dalu2104/elk/branches{/branch}","tags_url":"https://api.github.com/repos/dalu2104/elk/tags","blobs_url":"https://api.github.com/repos/dalu2104/elk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dalu2104/elk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dalu2104/elk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dalu2104/elk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dalu2104/elk/statuses/{sha}","languages_url":"https://api.github.com/repos/dalu2104/elk/languages","stargazers_url":"https://api.github.com/repos/dalu2104/elk/stargazers","contributors_url":"https://api.github.com/repos/dalu2104/elk/contributors","subscribers_url":"https://api.github.com/repos/dalu2104/elk/subscribers","subscription_url":"https://api.github.com/repos/dalu2104/elk/subscription","commits_url":"https://api.github.com/repos/dalu2104/elk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dalu2104/elk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dalu2104/elk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dalu2104/elk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dalu2104/elk/contents/{+path}","compare_url":"https://api.github.com/repos/dalu2104/elk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dalu2104/elk/merges","archive_url":"https://api.github.com/repos/dalu2104/elk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dalu2104/elk/downloads","issues_url":"https://api.github.com/repos/dalu2104/elk/issues{/number}","pulls_url":"https://api.github.com/repos/dalu2104/elk/pulls{/number}","milestones_url":"https://api.github.com/repos/dalu2104/elk/milestones{/number}","notifications_url":"https://api.github.com/repos/dalu2104/elk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dalu2104/elk/labels{/name}","releases_url":"https://api.github.com/repos/dalu2104/elk/releases{/id}","deployments_url":"https://api.github.com/repos/dalu2104/elk/deployments","created_at":"2018-10-02T11:45:25Z","updated_at":"2018-11-07T14:10:09Z","pushed_at":"2018-12-12T13:54:16Z","git_url":"git://github.com/dalu2104/elk.git","ssh_url":"[email protected]:dalu2104/elk.git","clone_url":"https://github.com/dalu2104/elk.git","svn_url":"https://github.com/dalu2104/elk","homepage":"https://www.eclipse.org/elk/","size":15258,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"21cd7e47cfbd92af99b28d97493c7cc88c95823d","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":44551321,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU1MTMyMQ==","name":"elk","full_name":"eclipse/elk","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/elk","description":"Eclipse Layout Kernel - Automatic layout for Java applications.","fork":false,"url":"https://api.github.com/repos/eclipse/elk","forks_url":"https://api.github.com/repos/eclipse/elk/forks","keys_url":"https://api.github.com/repos/eclipse/elk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/elk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/elk/teams","hooks_url":"https://api.github.com/repos/eclipse/elk/hooks","issue_events_url":"https://api.github.com/repos/eclipse/elk/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/elk/events","assignees_url":"https://api.github.com/repos/eclipse/elk/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/elk/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/elk/tags","blobs_url":"https://api.github.com/repos/eclipse/elk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/elk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/elk/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/elk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/elk/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/elk/languages","stargazers_url":"https://api.github.com/repos/eclipse/elk/stargazers","contributors_url":"https://api.github.com/repos/eclipse/elk/contributors","subscribers_url":"https://api.github.com/repos/eclipse/elk/subscribers","subscription_url":"https://api.github.com/repos/eclipse/elk/subscription","commits_url":"https://api.github.com/repos/eclipse/elk/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/elk/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/elk/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/elk/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/elk/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/elk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/elk/merges","archive_url":"https://api.github.com/repos/eclipse/elk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/elk/downloads","issues_url":"https://api.github.com/repos/eclipse/elk/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/elk/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/elk/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/elk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/elk/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/elk/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/elk/deployments","created_at":"2015-10-19T17:25:32Z","updated_at":"2018-12-14T18:45:50Z","pushed_at":"2018-12-14T09:40:16Z","git_url":"git://github.com/eclipse/elk.git","ssh_url":"[email protected]:eclipse/elk.git","clone_url":"https://github.com/eclipse/elk.git","svn_url":"https://github.com/eclipse/elk","homepage":"https://www.eclipse.org/elk/","size":15204,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":29,"open_issues":69,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/elk/pulls/391"},"html":{"href":"https://github.com/eclipse/elk/pull/391"},"issue":{"href":"https://api.github.com/repos/eclipse/elk/issues/391"},"comments":{"href":"https://api.github.com/repos/eclipse/elk/issues/391/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/elk/pulls/391/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/elk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/elk/pulls/391/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/elk/statuses/19a183f6775ee0b0cdc8807826a15b6d0a189b63"}},"author_association":"NONE"}} | {
"id": 44551321,
"name": "eclipse/elk",
"url": "https://api.github.com/repos/eclipse/elk"
} | {
"id": 7552459,
"login": "uruuru",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7552459?",
"url": "https://api.github.com/users/uruuru"
} | {
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
} | 2018-12-15T12:10:04 | 8759076389 | {"actor":{"display_login":"uruuru"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/241548953","pull_request_review_id":184852116,"id":241548953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTU0ODk1Mw==","diff_hunk":"@@ -0,0 +1,292 @@\n+/*******************************************************************************\n+ * Copyright (c) 1991, 2018 IBM Corp. and others\n+ *\n+ * This program and the accompanying materials are made available under\n+ * the terms of the Eclipse Public License 2.0 which accompanies this\n+ * distribution and is available at https://www.eclipse.org/legal/epl-2.0/\n+ * or the Apache License, Version 2.0 which accompanies this distribution and\n+ * is available at https://www.apache.org/licenses/LICENSE-2.0.\n+ *\n+ * This Source Code may also be made available under the following\n+ * Secondary Licenses when the conditions for such availability set\n+ * forth in the Eclipse Public License, v. 2.0 are satisfied: GNU\n+ * General Public License, version 2 with the GNU Classpath\n+ * Exception [1] and GNU General Public License, version 2 with the\n+ * OpenJDK Assembly Exception [2].\n+ *\n+ * [1] https://www.gnu.org/software/classpath/license.html\n+ * [2] http://openjdk.java.net/legal/assembly-exception.html\n+ *\n+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 OR LicenseRef-GPL-2.0 WITH Assembly-exception\n+ *******************************************************************************/\n+\n+\n+/**\n+ * @file\n+ * @ingroup GC_Modron_Base\n+ */\n+\n+#if defined(OMR_ENV_DATA64) && !defined(OMR_GC_COMPRESSED_POINTERS)\n+\n+#include \"ReadBarrierVerifier.hpp\"\n+\n+#include \"AtomicOperations.hpp\"\n+#include \"Debug.hpp\"\n+#include \"EnvironmentStandard.hpp\"\n+#include \"HeapRegionManager.hpp\"\n+#include \"j9cfg.h\"\n+#include \"mmhook_internal.h\"\n+#include \"ModronAssertions.h\"\n+#include \"RootScannerReadBarrierVerifier.hpp\"\n+#include \"Scavenger.hpp\"\n+#include \"SublistFragment.hpp\"\n+\n+MM_ReadBarrierVerifier *\n+MM_ReadBarrierVerifier::newInstance(MM_EnvironmentBase *env)\n+{\n+\tMM_ReadBarrierVerifier *barrier;\n+\n+\tbarrier = (MM_ReadBarrierVerifier *)env->getForge()->allocate(sizeof(MM_ReadBarrierVerifier), MM_AllocationCategory::FIXED, J9_GET_CALLSITE());\n+\tif (barrier) {\n+\t\tnew(barrier) MM_ReadBarrierVerifier(env);\n+\t\tif (!barrier->initialize(env)) {\n+\t\t\tbarrier->kill(env);\n+\t\t\tbarrier = NULL;\n+\t\t}\n+\t}\n+\n+\treturn barrier;\n+}\n+\n+bool \n+MM_ReadBarrierVerifier::initialize(MM_EnvironmentBase *env)\n+{\n+#if defined(J9VM_GC_GENERATIONAL)\n+\tif (!_generationalAccessBarrierComponent.initialize(env)) {\n+\t\treturn false;\n+\t}\n+#endif /* J9VM_GC_GENERATIONAL */\n+\n+\treturn MM_StandardAccessBarrier::initialize(env);\n+}\n+\n+void \n+MM_ReadBarrierVerifier::kill(MM_EnvironmentBase *env)\n+{\n+\ttearDown(env);\n+\tenv->getForge()->free(this);\n+}\n+\n+void\n+MM_ReadBarrierVerifier::tearDown(MM_EnvironmentBase *env)\n+{\n+#if defined(J9VM_GC_GENERATIONAL)\n+\t_generationalAccessBarrierComponent.tearDown(env);\n+#endif /* J9VM_GC_GENERATIONAL */\n+\n+\tMM_StandardAccessBarrier::tearDown(env);\n+}\n+\n+bool\n+MM_ReadBarrierVerifier::preObjectRead(J9VMThread *vmThread, J9Object *srcObject, fj9object_t *srcAddress)\n+{\n+\n+\tAssert_MM_true(vmThread->javaVM->internalVMFunctions->currentVMThread(vmThread->javaVM) == vmThread);\n+\tMM_EnvironmentStandard *env = MM_EnvironmentStandard::getEnvironment(vmThread->omrVMThread);\n+\n+\tuintptr_t heapBase = (uintptr_t)_extensions->heap->getHeapBase();\n+\tuintptr_t shadowHeapBase = (uintptr_t)_extensions->shadowHeapBase;\n+\tuintptr_t shadowHeapTop = (uintptr_t)_extensions->shadowHeapTop;\n+\tuintptr_t healedAddress;\n+\n+\tfomrobject_t objectToken = *(volatile fomrobject_t *)srcAddress;\n+\tomrobjectptr_t object = convertPointerFromToken(objectToken);\n+\n+\tGC_SlotObject slotObject(env->getOmrVM(), srcAddress);\n+\n+\tif ((shadowHeapTop > (uintptr_t)object && shadowHeapBase <= (uintptr_t)object)) {\n+\t\thealedAddress = heapBase + ((uintptr_t)object - shadowHeapBase);\n+\n+\t\tGC_SlotObject slotObject(env->getOmrVM(), srcAddress);\n+\t\tslotObject.atomicWriteReferenceToSlot(object, (omrobjectptr_t)healedAddress);\n+\t}\n+\treturn true;\n+}\n+\n+void\n+MM_ReadBarrierVerifier::poisonSlot(MM_GCExtensionsBase *extensions, fomrobject_t *slot)\n+{\n+\tuintptr_t heapBase = (uintptr_t)extensions->heap->getHeapBase();\n+\tuintptr_t heapTop = (uintptr_t)extensions->heap->getHeapTop();\n+\tuintptr_t shadowHeapBase = (uintptr_t)extensions->shadowHeapBase;\n+\n+\tuintptr_t poisonedAddress;\n+\n+\tuintptr_t referenceFromSlot = (uintptr_t)*slot;\n+\tif (referenceFromSlot < heapTop && referenceFromSlot >= heapBase) {\n+\t\tpoisonedAddress = shadowHeapBase + (referenceFromSlot - heapBase);\n+\t\t*slot = (fomrobject_t)poisonedAddress;\n+\t} else {\n+\n+\t}\n+}\n+\n+void\n+MM_ReadBarrierVerifier::poisonJniWeakReferenceSlots(MM_EnvironmentBase *env)\n+{\n+\tMM_RootScannerReadBarrierVerifier scanner(env, true, true);\n+\tscanner.scanJNIWeakGlobalReferences(env);\n+}\n+\n+void\n+MM_ReadBarrierVerifier::poisonMonitorReferenceSlots(MM_EnvironmentBase *env)\n+{\n+\tMM_RootScannerReadBarrierVerifier scanner(env, true, true);\n+\tscanner.scanMonitorReferences(env);\n+}\n+\n+void\n+MM_ReadBarrierVerifier::poisonStaticClassSlots(MM_EnvironmentBase *env)\n+{\n+\tMM_RootScannerReadBarrierVerifier scanner(env, true, true);\n+\tscanner.scanClassStaticSlots(env);\n+}\n+\n+void\n+MM_ReadBarrierVerifier::poisonConstantPoolObjects(MM_EnvironmentBase *env)\n+{\n+\tMM_RootScannerReadBarrierVerifier scanner(env, true, true);\n+\tscanner.scanConstantPoolObjectSlots(env);\n+}\n+\n+void\n+MM_ReadBarrierVerifier::poisonSlots(MM_EnvironmentBase *env)\n+{\n+\tMM_GCExtensionsBase *extensions = env->getExtensions();\n+\tif (1 == extensions->fvtest_enableJNIGlobalWeakReadBarrierVerification) {\n+\t\tpoisonJniWeakReferenceSlots(env);\n+\t}\n+\tif (1 == extensions->fvtest_enableMonitorObjectsReadBarrierVerification) {\n+\t\tpoisonMonitorReferenceSlots(env);\n+\t}\n+\tif (1 == extensions->fvtest_enableClassStaticsReadBarrierVerification) {\n+\t\tpoisonStaticClassSlots(env);\n+\t\tpoisonConstantPoolObjects(env);\n+\t}\n+}\n+\n+void\n+MM_ReadBarrierVerifier::healSlot(MM_GCExtensionsBase *extensions, j9object_t *srcAddress)\n+{\n+\tuintptr_t heapBase = (uintptr_t)extensions->heap->getHeapBase();\n+\tuintptr_t shadowHeapBase = (uintptr_t)extensions->shadowHeapBase;\n+\tuintptr_t shadowHeapTop = (uintptr_t)extensions->shadowHeapTop;\n+\tuintptr_t healedAddress;\n+\tj9object_t object = *srcAddress;\n+\n+\tif (shadowHeapTop > (uintptr_t)object && (shadowHeapBase <= (uintptr_t)object)) {\n+\t\thealedAddress = heapBase + ((uintptr_t)object - shadowHeapBase);\n+\n+\t\t// TODO: instead of atomicWriteReference, write back to srcAddress. But maybe we might need it to be atomic\n+\t\t*srcAddress = (j9object_t)healedAddress;\n+\t}\n+}\n+\n+void\n+MM_ReadBarrierVerifier::healSlot(MM_GCExtensionsBase *extensions, fomrobject_t *slot)\n+{\n+\tuintptr_t heapBase = (uintptr_t)extensions->heap->getHeapBase();\n+\tuintptr_t shadowHeapBase = (uintptr_t)extensions->shadowHeapBase;\n+\tuintptr_t shadowHeapTop = (uintptr_t)extensions->shadowHeapTop;\n+\n+\tuintptr_t healedHeapAddress;\n+\n+\tuintptr_t referenceFromSlot = (uintptr_t)*slot;\n+\tif (referenceFromSlot < shadowHeapTop && (referenceFromSlot >= shadowHeapBase)) {\n+\n+\t\thealedHeapAddress = heapBase + (referenceFromSlot - shadowHeapBase);\n+\t\t*slot = (fomrobject_t)healedHeapAddress;\n+\n+\t}\n+}\n+\n+void\n+MM_ReadBarrierVerifier::healJniWeakReferenceSlots(MM_EnvironmentBase *env)\n+{\n+\tMM_RootScannerReadBarrierVerifier scanner(env, true);\n+\tscanner.scanJNIWeakGlobalReferences(env);\n+}\n+\n+void\n+MM_ReadBarrierVerifier::healMonitorReferenceSlots(MM_EnvironmentBase *env)\n+{\n+\tMM_RootScannerReadBarrierVerifier scanner(env, true);\n+\tscanner.scanMonitorReferences(env);\n+}\n+\n+void\n+MM_ReadBarrierVerifier::healStaticClassSlots(MM_EnvironmentBase *env)\n+{\n+\tMM_RootScannerReadBarrierVerifier scanner(env, true);\n+\tscanner.scanClassStaticSlots(env);\n+}\n+\n+void\n+MM_ReadBarrierVerifier::healConstantPoolObjects(MM_EnvironmentBase *env)\n+{\n+\tMM_RootScannerReadBarrierVerifier scanner(env, true);\n+\tscanner.scanConstantPoolObjectSlots(env);\n+}\n+\n+void\n+MM_ReadBarrierVerifier::healSlots(MM_EnvironmentBase *env)\n+{\n+\tMM_GCExtensionsBase *extensions = env->getExtensions();\n+\tif (1 == extensions->fvtest_enableJNIGlobalWeakReadBarrierVerification) {\n+\t\thealJniWeakReferenceSlots(env);\n+\t}\n+\tif (1 == extensions->fvtest_enableMonitorObjectsReadBarrierVerification) {\n+\t\thealMonitorReferenceSlots(env);\n+\t}\n+\tif (1 == extensions->fvtest_enableClassStaticsReadBarrierVerification) {\n+\t\thealStaticClassSlots(env);\n+\t\thealConstantPoolObjects(env);\n+\t}\n+\n+}\n+\n+bool\n+MM_ReadBarrierVerifier::preObjectRead(J9VMThread *vmThread, J9Class *srcClass, j9object_t *srcAddress)\n+{\n+\thealSlot(_extensions, srcAddress);\n+\treturn true;\n+}\n+\n+bool\n+MM_ReadBarrierVerifier::preMonitorTableSlotRead(J9VMThread *vmThread, j9object_t *srcAddress)\n+{\n+\thealSlot(_extensions, srcAddress);\n+\treturn true;\n+}\n+\n+bool\n+MM_ReadBarrierVerifier::preMonitorTableSlotRead(J9JavaVM *vm, j9object_t *srcAddress)\n+{\n+\tuintptr_t heapBase = (uintptr_t)_extensions->heap->getHeapBase();\n+\tuintptr_t shadowHeapBase = (uintptr_t)_extensions->shadowHeapBase;\n+\tuintptr_t shadowHeapTop = (uintptr_t)_extensions->shadowHeapTop;\n+\tuintptr_t healedAddress;\n+\tj9object_t object = *srcAddress;","path":"runtime/gc_modron_standard/ReadBarrierVerifier.cpp","position":279,"original_position":279,"commit_id":"4f082b1eb2346be27bcc782683b91368d5caf411","original_commit_id":"4f082b1eb2346be27bcc782683b91368d5caf411","user":{"login":"dmitripivkine","id":18148831,"node_id":"MDQ6VXNlcjE4MTQ4ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/18148831?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitripivkine","html_url":"https://github.com/dmitripivkine","followers_url":"https://api.github.com/users/dmitripivkine/followers","following_url":"https://api.github.com/users/dmitripivkine/following{/other_user}","gists_url":"https://api.github.com/users/dmitripivkine/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitripivkine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitripivkine/subscriptions","organizations_url":"https://api.github.com/users/dmitripivkine/orgs","repos_url":"https://api.github.com/users/dmitripivkine/repos","events_url":"https://api.github.com/users/dmitripivkine/events{/privacy}","received_events_url":"https://api.github.com/users/dmitripivkine/received_events","type":"User","site_admin":false},"body":"move these two definitions inside if statement","created_at":"2018-12-13T20:22:49Z","updated_at":"2018-12-13T20:22:49Z","html_url":"https://github.com/eclipse/openj9/pull/4037#discussion_r241548953","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/4037","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/241548953"},"html":{"href":"https://github.com/eclipse/openj9/pull/4037#discussion_r241548953"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/4037"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/4037","id":238455364,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDU1MzY0","html_url":"https://github.com/eclipse/openj9/pull/4037","diff_url":"https://github.com/eclipse/openj9/pull/4037.diff","patch_url":"https://github.com/eclipse/openj9/pull/4037.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/4037","number":4037,"state":"open","locked":false,"title":"WIP: Read barrier verification","user":{"login":"VermaSh","id":8346599,"node_id":"MDQ6VXNlcjgzNDY1OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/8346599?v=4","gravatar_id":"","url":"https://api.github.com/users/VermaSh","html_url":"https://github.com/VermaSh","followers_url":"https://api.github.com/users/VermaSh/followers","following_url":"https://api.github.com/users/VermaSh/following{/other_user}","gists_url":"https://api.github.com/users/VermaSh/gists{/gist_id}","starred_url":"https://api.github.com/users/VermaSh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VermaSh/subscriptions","organizations_url":"https://api.github.com/users/VermaSh/orgs","repos_url":"https://api.github.com/users/VermaSh/repos","events_url":"https://api.github.com/users/VermaSh/events{/privacy}","received_events_url":"https://api.github.com/users/VermaSh/received_events","type":"User","site_admin":false},"body":"Have introduced poisoning and healing of memory references (heap, class static objects, JNI weak references, monitor table slot objects) to single out any memory reads that don't use the access barrier","created_at":"2018-12-13T16:37:41Z","updated_at":"2018-12-13T20:22:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab449afe1514fd875e83efc191ad7b107b8c6baf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962440,"node_id":"MDU6TGFiZWw2OTc5NjI0NDA=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:gc","name":"comp:gc","color":"1d76db","default":false},{"id":709763910,"node_id":"MDU6TGFiZWw3MDk3NjM5MTA=","url":"https://api.github.com/repos/eclipse/openj9/labels/depends:omr","name":"depends:omr","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/4037/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/4037/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/4037/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/4f082b1eb2346be27bcc782683b91368d5caf411","head":{"label":"VermaSh:readBarrierVerification","ref":"readBarrierVerification","sha":"4f082b1eb2346be27bcc782683b91368d5caf411","user":{"login":"VermaSh","id":8346599,"node_id":"MDQ6VXNlcjgzNDY1OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/8346599?v=4","gravatar_id":"","url":"https://api.github.com/users/VermaSh","html_url":"https://github.com/VermaSh","followers_url":"https://api.github.com/users/VermaSh/followers","following_url":"https://api.github.com/users/VermaSh/following{/other_user}","gists_url":"https://api.github.com/users/VermaSh/gists{/gist_id}","starred_url":"https://api.github.com/users/VermaSh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VermaSh/subscriptions","organizations_url":"https://api.github.com/users/VermaSh/orgs","repos_url":"https://api.github.com/users/VermaSh/repos","events_url":"https://api.github.com/users/VermaSh/events{/privacy}","received_events_url":"https://api.github.com/users/VermaSh/received_events","type":"User","site_admin":false},"repo":{"id":147539123,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1MzkxMjM=","name":"openj9","full_name":"VermaSh/openj9","private":false,"owner":{"login":"VermaSh","id":8346599,"node_id":"MDQ6VXNlcjgzNDY1OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/8346599?v=4","gravatar_id":"","url":"https://api.github.com/users/VermaSh","html_url":"https://github.com/VermaSh","followers_url":"https://api.github.com/users/VermaSh/followers","following_url":"https://api.github.com/users/VermaSh/following{/other_user}","gists_url":"https://api.github.com/users/VermaSh/gists{/gist_id}","starred_url":"https://api.github.com/users/VermaSh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VermaSh/subscriptions","organizations_url":"https://api.github.com/users/VermaSh/orgs","repos_url":"https://api.github.com/users/VermaSh/repos","events_url":"https://api.github.com/users/VermaSh/events{/privacy}","received_events_url":"https://api.github.com/users/VermaSh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VermaSh/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":true,"url":"https://api.github.com/repos/VermaSh/openj9","forks_url":"https://api.github.com/repos/VermaSh/openj9/forks","keys_url":"https://api.github.com/repos/VermaSh/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VermaSh/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VermaSh/openj9/teams","hooks_url":"https://api.github.com/repos/VermaSh/openj9/hooks","issue_events_url":"https://api.github.com/repos/VermaSh/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/VermaSh/openj9/events","assignees_url":"https://api.github.com/repos/VermaSh/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/VermaSh/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/VermaSh/openj9/tags","blobs_url":"https://api.github.com/repos/VermaSh/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VermaSh/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VermaSh/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/VermaSh/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VermaSh/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/VermaSh/openj9/languages","stargazers_url":"https://api.github.com/repos/VermaSh/openj9/stargazers","contributors_url":"https://api.github.com/repos/VermaSh/openj9/contributors","subscribers_url":"https://api.github.com/repos/VermaSh/openj9/subscribers","subscription_url":"https://api.github.com/repos/VermaSh/openj9/subscription","commits_url":"https://api.github.com/repos/VermaSh/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/VermaSh/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/VermaSh/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/VermaSh/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/VermaSh/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/VermaSh/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VermaSh/openj9/merges","archive_url":"https://api.github.com/repos/VermaSh/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VermaSh/openj9/downloads","issues_url":"https://api.github.com/repos/VermaSh/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/VermaSh/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/VermaSh/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/VermaSh/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VermaSh/openj9/labels{/name}","releases_url":"https://api.github.com/repos/VermaSh/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/VermaSh/openj9/deployments","created_at":"2018-09-05T15:21:55Z","updated_at":"2018-12-06T20:13:09Z","pushed_at":"2018-12-13T16:36:29Z","git_url":"git://github.com/VermaSh/openj9.git","ssh_url":"[email protected]:VermaSh/openj9.git","clone_url":"https://github.com/VermaSh/openj9.git","svn_url":"https://github.com/VermaSh/openj9","homepage":"","size":37814,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"3ca6d75e9242a2f162a99c3e6aad39b3a62d0d56","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-12-13T20:03:58Z","pushed_at":"2018-12-13T20:17:40Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"[email protected]:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":40035,"stargazers_count":1558,"watchers_count":1558,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":637,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":303,"open_issues":637,"watchers":1558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/4037"},"html":{"href":"https://github.com/eclipse/openj9/pull/4037"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/4037"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/4037/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/4037/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/4037/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/4f082b1eb2346be27bcc782683b91368d5caf411"}},"author_association":"CONTRIBUTOR"}} | {
"id": 101408117,
"name": "eclipse/openj9",
"url": "https://api.github.com/repos/eclipse/openj9"
} | {
"id": 18148831,
"login": "dmitripivkine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18148831?",
"url": "https://api.github.com/users/dmitripivkine"
} | {
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
} | 2018-12-13T20:22:49 | 8750826317 | {"actor":{"display_login":"dmitripivkine"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/209073443","pull_request_review_id":145018709,"id":209073443,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTA3MzQ0Mw==","diff_hunk":"@@ -231,7 +231,7 @@ object ArraySeq extends StrictOptimizedClassTagSeqFactory[ArraySeq] { self =>\n override def hashCode = MurmurHash3.arraySeqHash(unsafeArray)\n override def equals(that: Any): Boolean = that match {\n case that: ofRef[_] =>\n- BoxesRunTime.arraysEquals(\n+ Array.equals(","path":"src/library/scala/collection/immutable/ArraySeq.scala","position":14,"original_position":14,"commit_id":"f108f714a06ee92013c114ce85de7014a4063b76","original_commit_id":"f108f714a06ee92013c114ce85de7014a4063b76","user":{"login":"plokhotnyuk","id":890289,"node_id":"MDQ6VXNlcjg5MDI4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/890289?v=4","gravatar_id":"","url":"https://api.github.com/users/plokhotnyuk","html_url":"https://github.com/plokhotnyuk","followers_url":"https://api.github.com/users/plokhotnyuk/followers","following_url":"https://api.github.com/users/plokhotnyuk/following{/other_user}","gists_url":"https://api.github.com/users/plokhotnyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/plokhotnyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plokhotnyuk/subscriptions","organizations_url":"https://api.github.com/users/plokhotnyuk/orgs","repos_url":"https://api.github.com/users/plokhotnyuk/repos","events_url":"https://api.github.com/users/plokhotnyuk/events{/privacy}","received_events_url":"https://api.github.com/users/plokhotnyuk/received_events","type":"User","site_admin":false},"body":"BTW, it also safe in comparing of uncomparable stuff, while Java version still has a bug:\r\n```\r\n$ scala\r\nWelcome to Scala 2.12.4 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_171).\r\nType in expressions for evaluation. Or try :help.\r\n\r\nscala> Float.NaN != Float.NaN\r\nres0: Boolean = true\r\n\r\nscala> !Float.NaN.equals(Float.NaN)\r\nres1: Boolean = false\r\n```","created_at":"2018-08-09T20:46:46Z","updated_at":"2018-08-09T20:46:47Z","html_url":"https://github.com/scala/scala/pull/7032#discussion_r209073443","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/7032","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/209073443"},"html":{"href":"https://github.com/scala/scala/pull/7032#discussion_r209073443"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/7032"}},"in_reply_to_id":209063434},"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/7032","id":207361219,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzYxMjE5","html_url":"https://github.com/scala/scala/pull/7032","diff_url":"https://github.com/scala/scala/pull/7032.diff","patch_url":"https://github.com/scala/scala/pull/7032.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/7032","number":7032,"state":"open","locked":false,"title":"Move arraysEquals to scala.Array out of scala.runtime","user":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-08-09T15:44:46Z","updated_at":"2018-08-09T20:46:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0c5c9f6e9dbe9c97bf654ccdf835d3415b20dc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/67","html_url":"https://github.com/scala/scala/milestone/67","labels_url":"https://api.github.com/repos/scala/scala/milestones/67/labels","id":2719691,"node_id":"MDk6TWlsZXN0b25lMjcxOTY5MQ==","number":67,"title":"2.13.0-RC1","description":"Merge to 2.13.x. Restricted to fixes directly improving the collections, their usage or the migration to 2.13.0. We will also consider fixes for important regressions since 2.12.\r\n\r\nAn exception may be made for a small addition that cannot target 2.13.1 due to binary incompatibilities.","creator":{"login":"adriaanm","id":91083,"node_id":"MDQ6VXNlcjkxMDgz","avatar_url":"https://avatars2.githubusercontent.com/u/91083?v=4","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":0,"state":"open","created_at":"2017-08-23T23:45:52Z","updated_at":"2018-08-09T20:31:32Z","due_on":"2018-09-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/7032/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/7032/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/7032/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/f108f714a06ee92013c114ce85de7014a4063b76","head":{"label":"dwijnand:move-arraysEquals","ref":"move-arraysEquals","sha":"f108f714a06ee92013c114ce85de7014a4063b76","user":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"repo":{"id":58377849,"node_id":"MDEwOlJlcG9zaXRvcnk1ODM3Nzg0OQ==","name":"scala","full_name":"dwijnand/scala","owner":{"login":"dwijnand","id":344610,"node_id":"MDQ6VXNlcjM0NDYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwijnand/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/dwijnand/scala","forks_url":"https://api.github.com/repos/dwijnand/scala/forks","keys_url":"https://api.github.com/repos/dwijnand/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwijnand/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwijnand/scala/teams","hooks_url":"https://api.github.com/repos/dwijnand/scala/hooks","issue_events_url":"https://api.github.com/repos/dwijnand/scala/issues/events{/number}","events_url":"https://api.github.com/repos/dwijnand/scala/events","assignees_url":"https://api.github.com/repos/dwijnand/scala/assignees{/user}","branches_url":"https://api.github.com/repos/dwijnand/scala/branches{/branch}","tags_url":"https://api.github.com/repos/dwijnand/scala/tags","blobs_url":"https://api.github.com/repos/dwijnand/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwijnand/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwijnand/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwijnand/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwijnand/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/dwijnand/scala/languages","stargazers_url":"https://api.github.com/repos/dwijnand/scala/stargazers","contributors_url":"https://api.github.com/repos/dwijnand/scala/contributors","subscribers_url":"https://api.github.com/repos/dwijnand/scala/subscribers","subscription_url":"https://api.github.com/repos/dwijnand/scala/subscription","commits_url":"https://api.github.com/repos/dwijnand/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwijnand/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwijnand/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwijnand/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwijnand/scala/contents/{+path}","compare_url":"https://api.github.com/repos/dwijnand/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwijnand/scala/merges","archive_url":"https://api.github.com/repos/dwijnand/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwijnand/scala/downloads","issues_url":"https://api.github.com/repos/dwijnand/scala/issues{/number}","pulls_url":"https://api.github.com/repos/dwijnand/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/dwijnand/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/dwijnand/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwijnand/scala/labels{/name}","releases_url":"https://api.github.com/repos/dwijnand/scala/releases{/id}","deployments_url":"https://api.github.com/repos/dwijnand/scala/deployments","created_at":"2016-05-09T13:16:32Z","updated_at":"2016-05-09T13:16:48Z","pushed_at":"2018-08-09T15:44:42Z","git_url":"git://github.com/dwijnand/scala.git","ssh_url":"[email protected]:dwijnand/scala.git","clone_url":"https://github.com/dwijnand/scala.git","svn_url":"https://github.com/dwijnand/scala","homepage":"http://www.scala-lang.org/","size":101352,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"z"}},"base":{"label":"scala:2.13.x","ref":"2.13.x","sha":"235ca19fc06f68200175adefcb299131bb0342bf","user":{"login":"scala","id":57059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MDU5","avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"node_id":"MDEwOlJlcG9zaXRvcnkyODg4ODE4","name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MDU5","avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","deployments_url":"https://api.github.com/repos/scala/scala/deployments","created_at":"2011-12-01T05:02:34Z","updated_at":"2018-08-09T20:11:36Z","pushed_at":"2018-08-09T19:57:50Z","git_url":"git://github.com/scala/scala.git","ssh_url":"[email protected]:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":101488,"stargazers_count":10524,"watchers_count":10524,"language":"Scala","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2489,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2489,"open_issues":63,"watchers":10524,"default_branch":"2.13.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/7032"},"html":{"href":"https://github.com/scala/scala/pull/7032"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/7032"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/7032/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/7032/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/7032/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/f108f714a06ee92013c114ce85de7014a4063b76"}},"author_association":"MEMBER"}} | {
"id": 2888818,
"name": "scala/scala",
"url": "https://api.github.com/repos/scala/scala"
} | {
"id": 890289,
"login": "plokhotnyuk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/890289?",
"url": "https://api.github.com/users/plokhotnyuk"
} | {
"id": 57059,
"login": "scala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/57059?",
"url": "https://api.github.com/orgs/scala"
} | 2018-08-09T20:46:46 | 8092583244 | {"actor":{"display_login":"plokhotnyuk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/225446856","pull_request_review_id":165044361,"id":225446856,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTQ0Njg1Ng==","diff_hunk":"@@ -26,8 +26,19 @@ object Option {\n *\n * @param x the value\n * @return Some(value) if value != null, None if value == null\n+ * @deprecated use [[ofNullable]] instead, as its meaning\n+ * is clearer\n */\n- def apply[A](x: A): Option[A] = if (x == null) None else Some(x)\n+ @deprecated(\"Use `ofNullable` instead\", since = \"2.13.0\")\n+ @inline def apply[A](x: A): Option[A] = ofNullable(x)\n+\n+ /** An Option factory which creates Some(x) if the argument is not null,\n+ * and None if it is null.\n+ *\n+ * @param a the value\n+ * @return Some(value) if value != null, None if value == null\n+ */\n+ def ofNullable[A](a: A): Option[A] = if (a == null) None else Some(a)","path":"src/library/scala/Option.scala","position":17,"original_position":17,"commit_id":"71a3b7a6f03a1528d2ddd4e88712086b8a43a4f5","original_commit_id":"71a3b7a6f03a1528d2ddd4e88712086b8a43a4f5","user":{"login":"sjrd","id":535934,"node_id":"MDQ6VXNlcjUzNTkzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/535934?v=4","gravatar_id":"","url":"https://api.github.com/users/sjrd","html_url":"https://github.com/sjrd","followers_url":"https://api.github.com/users/sjrd/followers","following_url":"https://api.github.com/users/sjrd/following{/other_user}","gists_url":"https://api.github.com/users/sjrd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjrd/subscriptions","organizations_url":"https://api.github.com/users/sjrd/orgs","repos_url":"https://api.github.com/users/sjrd/repos","events_url":"https://api.github.com/users/sjrd/events{/privacy}","received_events_url":"https://api.github.com/users/sjrd/received_events","type":"User","site_admin":false},"body":"Not useful, because the Scala type checker will just infer a lub. If you call `Option.ofNullable(5)` it will infer `A = Any` so that both `A >: Null` and `Int <: A`. Best to keep the existing type signature.","created_at":"2018-10-16T08:40:04Z","updated_at":"2018-10-16T08:40:05Z","html_url":"https://github.com/scala/scala/pull/7336#discussion_r225446856","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/7336","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/225446856"},"html":{"href":"https://github.com/scala/scala/pull/7336#discussion_r225446856"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/7336"}},"in_reply_to_id":225367663},"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/7336","id":222770152,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzcwMTUy","html_url":"https://github.com/scala/scala/pull/7336","diff_url":"https://github.com/scala/scala/pull/7336.diff","patch_url":"https://github.com/scala/scala/pull/7336.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/7336","number":7336,"state":"open","locked":false,"title":"Deprecate Option.apply","user":{"login":"NthPortal","id":7505383,"node_id":"MDQ6VXNlcjc1MDUzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7505383?v=4","gravatar_id":"","url":"https://api.github.com/users/NthPortal","html_url":"https://github.com/NthPortal","followers_url":"https://api.github.com/users/NthPortal/followers","following_url":"https://api.github.com/users/NthPortal/following{/other_user}","gists_url":"https://api.github.com/users/NthPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/NthPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NthPortal/subscriptions","organizations_url":"https://api.github.com/users/NthPortal/orgs","repos_url":"https://api.github.com/users/NthPortal/repos","events_url":"https://api.github.com/users/NthPortal/events{/privacy}","received_events_url":"https://api.github.com/users/NthPortal/received_events","type":"User","site_admin":false},"body":"Deprecate `Option.apply` and replace with `Option.ofNullable`.\r\n\r\nInspired by a comment from @sjrd [here](https://contributors.scala-lang.org/t/sip-suggestion-add-and-syntactic-sugar-for-more-convenient-option-t-usage/2413/9), as well as other discussions elsewhere.","created_at":"2018-10-15T03:17:45Z","updated_at":"2018-10-16T08:40:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"460572bb487fc0426e2f138c80432ae0fa058f81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/67","html_url":"https://github.com/scala/scala/milestone/67","labels_url":"https://api.github.com/repos/scala/scala/milestones/67/labels","id":2719691,"node_id":"MDk6TWlsZXN0b25lMjcxOTY5MQ==","number":67,"title":"2.13.0-RC1","description":"Merge to 2.13.x. A PR should have scala/bug issue. No new PRs after Dec 15. Lead: @adriaanm\r\n\r\nRestricted to fixes directly improving the collections, their usage or the migration to 2.13.0. We will also consider fixes for important regressions since 2.12. An exception may be made for a small addition that cannot target 2.13.1 due to binary incompatibilities.","creator":{"login":"adriaanm","id":91083,"node_id":"MDQ6VXNlcjkxMDgz","avatar_url":"https://avatars2.githubusercontent.com/u/91083?v=4","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":132,"state":"open","created_at":"2017-08-23T23:45:52Z","updated_at":"2018-10-15T20:19:08Z","due_on":"2019-01-11T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/7336/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/7336/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/7336/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/71a3b7a6f03a1528d2ddd4e88712086b8a43a4f5","head":{"label":"NthPortal:topic/option-of-nullable/PR","ref":"topic/option-of-nullable/PR","sha":"71a3b7a6f03a1528d2ddd4e88712086b8a43a4f5","user":{"login":"NthPortal","id":7505383,"node_id":"MDQ6VXNlcjc1MDUzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7505383?v=4","gravatar_id":"","url":"https://api.github.com/users/NthPortal","html_url":"https://github.com/NthPortal","followers_url":"https://api.github.com/users/NthPortal/followers","following_url":"https://api.github.com/users/NthPortal/following{/other_user}","gists_url":"https://api.github.com/users/NthPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/NthPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NthPortal/subscriptions","organizations_url":"https://api.github.com/users/NthPortal/orgs","repos_url":"https://api.github.com/users/NthPortal/repos","events_url":"https://api.github.com/users/NthPortal/events{/privacy}","received_events_url":"https://api.github.com/users/NthPortal/received_events","type":"User","site_admin":false},"repo":{"id":85460181,"node_id":"MDEwOlJlcG9zaXRvcnk4NTQ2MDE4MQ==","name":"scala","full_name":"NthPortal/scala","private":false,"owner":{"login":"NthPortal","id":7505383,"node_id":"MDQ6VXNlcjc1MDUzODM=","avatar_url":"https://avatars0.githubusercontent.com/u/7505383?v=4","gravatar_id":"","url":"https://api.github.com/users/NthPortal","html_url":"https://github.com/NthPortal","followers_url":"https://api.github.com/users/NthPortal/followers","following_url":"https://api.github.com/users/NthPortal/following{/other_user}","gists_url":"https://api.github.com/users/NthPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/NthPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NthPortal/subscriptions","organizations_url":"https://api.github.com/users/NthPortal/orgs","repos_url":"https://api.github.com/users/NthPortal/repos","events_url":"https://api.github.com/users/NthPortal/events{/privacy}","received_events_url":"https://api.github.com/users/NthPortal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NthPortal/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/NthPortal/scala","forks_url":"https://api.github.com/repos/NthPortal/scala/forks","keys_url":"https://api.github.com/repos/NthPortal/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NthPortal/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NthPortal/scala/teams","hooks_url":"https://api.github.com/repos/NthPortal/scala/hooks","issue_events_url":"https://api.github.com/repos/NthPortal/scala/issues/events{/number}","events_url":"https://api.github.com/repos/NthPortal/scala/events","assignees_url":"https://api.github.com/repos/NthPortal/scala/assignees{/user}","branches_url":"https://api.github.com/repos/NthPortal/scala/branches{/branch}","tags_url":"https://api.github.com/repos/NthPortal/scala/tags","blobs_url":"https://api.github.com/repos/NthPortal/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NthPortal/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NthPortal/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/NthPortal/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NthPortal/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/NthPortal/scala/languages","stargazers_url":"https://api.github.com/repos/NthPortal/scala/stargazers","contributors_url":"https://api.github.com/repos/NthPortal/scala/contributors","subscribers_url":"https://api.github.com/repos/NthPortal/scala/subscribers","subscription_url":"https://api.github.com/repos/NthPortal/scala/subscription","commits_url":"https://api.github.com/repos/NthPortal/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/NthPortal/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/NthPortal/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/NthPortal/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/NthPortal/scala/contents/{+path}","compare_url":"https://api.github.com/repos/NthPortal/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NthPortal/scala/merges","archive_url":"https://api.github.com/repos/NthPortal/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NthPortal/scala/downloads","issues_url":"https://api.github.com/repos/NthPortal/scala/issues{/number}","pulls_url":"https://api.github.com/repos/NthPortal/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/NthPortal/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/NthPortal/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NthPortal/scala/labels{/name}","releases_url":"https://api.github.com/repos/NthPortal/scala/releases{/id}","deployments_url":"https://api.github.com/repos/NthPortal/scala/deployments","created_at":"2017-03-19T08:05:23Z","updated_at":"2018-10-15T11:59:03Z","pushed_at":"2018-10-16T00:38:57Z","git_url":"git://github.com/NthPortal/scala.git","ssh_url":"[email protected]:NthPortal/scala.git","clone_url":"https://github.com/NthPortal/scala.git","svn_url":"https://github.com/NthPortal/scala","homepage":"http://www.scala-lang.org/","size":106319,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.13.x"}},"base":{"label":"scala:2.13.x","ref":"2.13.x","sha":"e57997a9cd1d7e73792cfa1a49eff6e4d7848932","user":{"login":"scala","id":57059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MDU5","avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"node_id":"MDEwOlJlcG9zaXRvcnkyODg4ODE4","name":"scala","full_name":"scala/scala","private":false,"owner":{"login":"scala","id":57059,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MDU5","avatar_url":"https://avatars2.githubusercontent.com/u/57059?v=4","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","deployments_url":"https://api.github.com/repos/scala/scala/deployments","created_at":"2011-12-01T05:02:34Z","updated_at":"2018-10-16T07:27:10Z","pushed_at":"2018-10-16T07:22:20Z","git_url":"git://github.com/scala/scala.git","ssh_url":"[email protected]:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":106278,"stargazers_count":10771,"watchers_count":10771,"language":"Scala","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2554,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2554,"open_issues":93,"watchers":10771,"default_branch":"2.13.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/7336"},"html":{"href":"https://github.com/scala/scala/pull/7336"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/7336"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/7336/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/7336/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/7336/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/71a3b7a6f03a1528d2ddd4e88712086b8a43a4f5"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2888818,
"name": "scala/scala",
"url": "https://api.github.com/repos/scala/scala"
} | {
"id": 535934,
"login": "sjrd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/535934?",
"url": "https://api.github.com/users/sjrd"
} | {
"id": 57059,
"login": "scala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/57059?",
"url": "https://api.github.com/orgs/scala"
} | 2018-10-16T08:40:04 | 8426793354 | {"actor":{"display_login":"sjrd"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/prepack/pulls/comments/169461157","pull_request_review_id":97990904,"id":169461157,"diff_hunk":"@@ -501,6 +501,12 @@ export class PropertiesImplementation {\n let key = InternalGetPropertiesKey(P);\n let map = InternalGetPropertiesMap(O, P);\n let propertyBinding = map.get(key);\n+ if (propertyBinding === undefined && O.isPartialObject()) {\n+ // if we try and delete a property that we aren't sure exists\n+ // throw a FatalError rather than an invariant\n+ AbstractValue.reportIntrospectionError(O, P);","path":"src/methods/properties.js","position":7,"original_position":7,"commit_id":"318df07805c875ba025063f30c87b68c2ee01739","original_commit_id":"318df07805c875ba025063f30c87b68c2ee01739","user":{"login":"hermanventer","id":4325251,"avatar_url":"https://avatars2.githubusercontent.com/u/4325251?v=4","gravatar_id":"","url":"https://api.github.com/users/hermanventer","html_url":"https://github.com/hermanventer","followers_url":"https://api.github.com/users/hermanventer/followers","following_url":"https://api.github.com/users/hermanventer/following{/other_user}","gists_url":"https://api.github.com/users/hermanventer/gists{/gist_id}","starred_url":"https://api.github.com/users/hermanventer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hermanventer/subscriptions","organizations_url":"https://api.github.com/users/hermanventer/orgs","repos_url":"https://api.github.com/users/hermanventer/repos","events_url":"https://api.github.com/users/hermanventer/events{/privacy}","received_events_url":"https://api.github.com/users/hermanventer/received_events","type":"User","site_admin":false},"body":"Look for places where CompilerDiagnostic is created in CallExpression.js.","created_at":"2018-02-20T21:13:16Z","updated_at":"2018-02-20T21:13:16Z","html_url":"https://github.com/facebook/prepack/pull/1472#discussion_r169461157","pull_request_url":"https://api.github.com/repos/facebook/prepack/pulls/1472","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments/169461157"},"html":{"href":"https://github.com/facebook/prepack/pull/1472#discussion_r169461157"},"pull_request":{"href":"https://api.github.com/repos/facebook/prepack/pulls/1472"}},"in_reply_to_id":169448804},"pull_request":{"url":"https://api.github.com/repos/facebook/prepack/pulls/1472","id":169963096,"html_url":"https://github.com/facebook/prepack/pull/1472","diff_url":"https://github.com/facebook/prepack/pull/1472.diff","patch_url":"https://github.com/facebook/prepack/pull/1472.patch","issue_url":"https://api.github.com/repos/facebook/prepack/issues/1472","number":1472,"state":"open","locked":false,"title":"Support abstract object property deletion recovery in pure scope","user":{"login":"trueadm","id":1519870,"avatar_url":"https://avatars0.githubusercontent.com/u/1519870?v=4","gravatar_id":"","url":"https://api.github.com/users/trueadm","html_url":"https://github.com/trueadm","followers_url":"https://api.github.com/users/trueadm/followers","following_url":"https://api.github.com/users/trueadm/following{/other_user}","gists_url":"https://api.github.com/users/trueadm/gists{/gist_id}","starred_url":"https://api.github.com/users/trueadm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueadm/subscriptions","organizations_url":"https://api.github.com/users/trueadm/orgs","repos_url":"https://api.github.com/users/trueadm/repos","events_url":"https://api.github.com/users/trueadm/events{/privacy}","received_events_url":"https://api.github.com/users/trueadm/received_events","type":"User","site_admin":false},"body":"Release notes: none\r\n\r\nThis PR does two things: \r\n\r\n- when trying to `delete` a partial object property, if the property doesn't exist, rather than throw an invariant, we throw a FatalError instead.\r\n- when in pure scope, we try and evaluate if a fatal was thrown (like we do in callExpression) in unaryExpression for the `delete` operation and recover it with an abstract temporal.","created_at":"2018-02-19T13:40:44Z","updated_at":"2018-02-20T21:13:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9753466b4166887bcf239afd0d39bd15f371d49","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars2.githubusercontent.com/u/63648?v=4","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":279345275,"url":"https://api.github.com/repos/facebook/prepack/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/prepack/pulls/1472/commits","review_comments_url":"https://api.github.com/repos/facebook/prepack/pulls/1472/comments","review_comment_url":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/prepack/issues/1472/comments","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/318df07805c875ba025063f30c87b68c2ee01739","head":{"label":"trueadm:fatal-on-delete","ref":"fatal-on-delete","sha":"318df07805c875ba025063f30c87b68c2ee01739","user":{"login":"trueadm","id":1519870,"avatar_url":"https://avatars0.githubusercontent.com/u/1519870?v=4","gravatar_id":"","url":"https://api.github.com/users/trueadm","html_url":"https://github.com/trueadm","followers_url":"https://api.github.com/users/trueadm/followers","following_url":"https://api.github.com/users/trueadm/following{/other_user}","gists_url":"https://api.github.com/users/trueadm/gists{/gist_id}","starred_url":"https://api.github.com/users/trueadm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueadm/subscriptions","organizations_url":"https://api.github.com/users/trueadm/orgs","repos_url":"https://api.github.com/users/trueadm/repos","events_url":"https://api.github.com/users/trueadm/events{/privacy}","received_events_url":"https://api.github.com/users/trueadm/received_events","type":"User","site_admin":false},"repo":{"id":101437011,"name":"prepack","full_name":"trueadm/prepack","owner":{"login":"trueadm","id":1519870,"avatar_url":"https://avatars0.githubusercontent.com/u/1519870?v=4","gravatar_id":"","url":"https://api.github.com/users/trueadm","html_url":"https://github.com/trueadm","followers_url":"https://api.github.com/users/trueadm/followers","following_url":"https://api.github.com/users/trueadm/following{/other_user}","gists_url":"https://api.github.com/users/trueadm/gists{/gist_id}","starred_url":"https://api.github.com/users/trueadm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueadm/subscriptions","organizations_url":"https://api.github.com/users/trueadm/orgs","repos_url":"https://api.github.com/users/trueadm/repos","events_url":"https://api.github.com/users/trueadm/events{/privacy}","received_events_url":"https://api.github.com/users/trueadm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trueadm/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":true,"url":"https://api.github.com/repos/trueadm/prepack","forks_url":"https://api.github.com/repos/trueadm/prepack/forks","keys_url":"https://api.github.com/repos/trueadm/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trueadm/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trueadm/prepack/teams","hooks_url":"https://api.github.com/repos/trueadm/prepack/hooks","issue_events_url":"https://api.github.com/repos/trueadm/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/trueadm/prepack/events","assignees_url":"https://api.github.com/repos/trueadm/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/trueadm/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/trueadm/prepack/tags","blobs_url":"https://api.github.com/repos/trueadm/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trueadm/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trueadm/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/trueadm/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trueadm/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/trueadm/prepack/languages","stargazers_url":"https://api.github.com/repos/trueadm/prepack/stargazers","contributors_url":"https://api.github.com/repos/trueadm/prepack/contributors","subscribers_url":"https://api.github.com/repos/trueadm/prepack/subscribers","subscription_url":"https://api.github.com/repos/trueadm/prepack/subscription","commits_url":"https://api.github.com/repos/trueadm/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/trueadm/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/trueadm/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/trueadm/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/trueadm/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/trueadm/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trueadm/prepack/merges","archive_url":"https://api.github.com/repos/trueadm/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trueadm/prepack/downloads","issues_url":"https://api.github.com/repos/trueadm/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/trueadm/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/trueadm/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/trueadm/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trueadm/prepack/labels{/name}","releases_url":"https://api.github.com/repos/trueadm/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/trueadm/prepack/deployments","created_at":"2017-08-25T19:46:20Z","updated_at":"2017-11-08T22:31:18Z","pushed_at":"2018-02-20T19:55:43Z","git_url":"git://github.com/trueadm/prepack.git","ssh_url":"[email protected]:trueadm/prepack.git","clone_url":"https://github.com/trueadm/prepack.git","svn_url":"https://github.com/trueadm/prepack","homepage":"https://prepack.io","size":6206,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f2aa5d19e5460645ff7545fbdafeeba143807b0d","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":45147841,"name":"prepack","full_name":"facebook/prepack","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":false,"url":"https://api.github.com/repos/facebook/prepack","forks_url":"https://api.github.com/repos/facebook/prepack/forks","keys_url":"https://api.github.com/repos/facebook/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/prepack/teams","hooks_url":"https://api.github.com/repos/facebook/prepack/hooks","issue_events_url":"https://api.github.com/repos/facebook/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/prepack/events","assignees_url":"https://api.github.com/repos/facebook/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/prepack/tags","blobs_url":"https://api.github.com/repos/facebook/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/prepack/languages","stargazers_url":"https://api.github.com/repos/facebook/prepack/stargazers","contributors_url":"https://api.github.com/repos/facebook/prepack/contributors","subscribers_url":"https://api.github.com/repos/facebook/prepack/subscribers","subscription_url":"https://api.github.com/repos/facebook/prepack/subscription","commits_url":"https://api.github.com/repos/facebook/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/prepack/merges","archive_url":"https://api.github.com/repos/facebook/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/prepack/downloads","issues_url":"https://api.github.com/repos/facebook/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/prepack/labels{/name}","releases_url":"https://api.github.com/repos/facebook/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/prepack/deployments","created_at":"2015-10-28T23:25:08Z","updated_at":"2018-02-20T19:13:21Z","pushed_at":"2018-02-20T20:53:45Z","git_url":"git://github.com/facebook/prepack.git","ssh_url":"[email protected]:facebook/prepack.git","clone_url":"https://github.com/facebook/prepack.git","svn_url":"https://github.com/facebook/prepack","homepage":"https://prepack.io","size":6828,"stargazers_count":11199,"watchers_count":11199,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":332,"mirror_url":null,"archived":false,"open_issues_count":150,"license":null,"forks":332,"open_issues":150,"watchers":11199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/1472"},"html":{"href":"https://github.com/facebook/prepack/pull/1472"},"issue":{"href":"https://api.github.com/repos/facebook/prepack/issues/1472"},"comments":{"href":"https://api.github.com/repos/facebook/prepack/issues/1472/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/prepack/pulls/1472/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/prepack/pulls/1472/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/prepack/statuses/318df07805c875ba025063f30c87b68c2ee01739"}},"author_association":"CONTRIBUTOR"}} | {
"id": 45147841,
"name": "facebook/prepack",
"url": "https://api.github.com/repos/facebook/prepack"
} | {
"id": 4325251,
"login": "hermanventer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4325251?",
"url": "https://api.github.com/users/hermanventer"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2018-02-20T21:13:16 | 7271902798 | {"actor":{"display_login":"hermanventer"}} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.