type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
428k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
11
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kubeedge/kubeedge/pulls/comments/276953596","pull_request_review_id":228650254,"id":276953596,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Njk1MzU5Ng==","diff_hunk":"@@ -0,0 +1,43 @@\n+package config\n+\n+import (\n+\t\"github.com/kubeedge/beehive/pkg/common/config\"\n+\t\"github.com/kubeedge/beehive/pkg/common/log\"\n+\t\"github.com/kubeedge/beehive/pkg/core/context\"\n+\t\"github.com/kubeedge/kubeedge/cloud/edgecontroller/pkg/devicecontroller/constants\"\n+)\n+\n+// ContextSendModule is the name send message to\n+var ContextSendModule string\n+\n+// ContextReceiveModule is the name receive message from\n+var ContextReceiveModule string\n+\n+// ContextResponseModule is the name response message from\n+var ContextResponseModule string\n+\n+// Context is beehive context used to send message\n+var Context *context.Context\n+\n+func init() {\n+\tif smn, err := config.CONFIG.GetValue(\"devicecontroller.context-send-module\").ToString(); err != nil {\n+\t\tContextSendModule = constants.DefaultContextSendModuleName\n+\t} else {\n+\t\tContextSendModule = smn\n+\t}\n+\tlog.LOGGER.Infof(\" send module name: %s\", ContextSendModule)\n+\n+\tif rmn, err := config.CONFIG.GetValue(\"devicecontroller.context-receive-module\").ToString(); err != nil {\n+\t\tContextReceiveModule = constants.DefaultContextReceiveModuleName\n+\t} else {\n+\t\tContextReceiveModule = rmn\n+\t}\n+\tlog.LOGGER.Infof(\"receive module name: %s\", ContextReceiveModule)","path":"cloud/edgecontroller/pkg/devicecontroller/config/context.go","position":35,"original_position":35,"commit_id":"a2fe7e86de297bedc36ba5910784ae023aac48da","original_commit_id":"a2fe7e86de297bedc36ba5910784ae023aac48da","user":{"login":"m1093782566","id":4953962,"node_id":"MDQ6VXNlcjQ5NTM5NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/4953962?v=4","gravatar_id":"","url":"https://api.github.com/users/m1093782566","html_url":"https://github.com/m1093782566","followers_url":"https://api.github.com/users/m1093782566/followers","following_url":"https://api.github.com/users/m1093782566/following{/other_user}","gists_url":"https://api.github.com/users/m1093782566/gists{/gist_id}","starred_url":"https://api.github.com/users/m1093782566/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m1093782566/subscriptions","organizations_url":"https://api.github.com/users/m1093782566/orgs","repos_url":"https://api.github.com/users/m1093782566/repos","events_url":"https://api.github.com/users/m1093782566/events{/privacy}","received_events_url":"https://api.github.com/users/m1093782566/received_events","type":"User","site_admin":false},"body":"error string should be started with upper case.","created_at":"2019-04-19T10:05:29Z","updated_at":"2019-04-19T10:07:00Z","html_url":"https://github.com/kubeedge/kubeedge/pull/363#discussion_r276953596","pull_request_url":"https://api.github.com/repos/kubeedge/kubeedge/pulls/363","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubeedge/kubeedge/pulls/comments/276953596"},"html":{"href":"https://github.com/kubeedge/kubeedge/pull/363#discussion_r276953596"},"pull_request":{"href":"https://api.github.com/repos/kubeedge/kubeedge/pulls/363"}}},"pull_request":{"url":"https://api.github.com/repos/kubeedge/kubeedge/pulls/363","id":270821543,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwODIxNTQz","html_url":"https://github.com/kubeedge/kubeedge/pull/363","diff_url":"https://github.com/kubeedge/kubeedge/pull/363.diff","patch_url":"https://github.com/kubeedge/kubeedge/pull/363.patch","issue_url":"https://api.github.com/repos/kubeedge/kubeedge/issues/363","number":363,"state":"open","locked":false,"title":"[WIP] : Add device controller implementation","user":{"login":"sids-b","id":30088497,"node_id":"MDQ6VXNlcjMwMDg4NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/30088497?v=4","gravatar_id":"","url":"https://api.github.com/users/sids-b","html_url":"https://github.com/sids-b","followers_url":"https://api.github.com/users/sids-b/followers","following_url":"https://api.github.com/users/sids-b/following{/other_user}","gists_url":"https://api.github.com/users/sids-b/gists{/gist_id}","starred_url":"https://api.github.com/users/sids-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sids-b/subscriptions","organizations_url":"https://api.github.com/users/sids-b/orgs","repos_url":"https://api.github.com/users/sids-b/repos","events_url":"https://api.github.com/users/sids-b/events{/privacy}","received_events_url":"https://api.github.com/users/sids-b/received_events","type":"User","site_admin":false},"body":"**What type of PR is this?**\r\n/kind feature\r\n\r\n**What this PR does / why we need it**:\r\nAdd device-controller for managing devices from cloud. \r\n\r\n**Which issue(s) this PR fixes**:\r\n\r\nFixes #357\r\n\r\n**Special notes for your reviewer**:\r\nBuild will fail till #358 is merged. Currently added the downstream controller needed for deviceTwin running at edge. Tested add/update/delete of device/devicetwin. Currently working on creation of config maps of each nodes.\r\n","created_at":"2019-04-16T09:18:26Z","updated_at":"2019-04-19T10:07:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"faf920a2c8d3014b7c753d4e3e970a69e71ce659","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1207811854,"node_id":"MDU6TGFiZWwxMjA3ODExODU0","url":"https://api.github.com/repos/kubeedge/kubeedge/labels/kind/feature","name":"kind/feature","color":"ffefa0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeedge/kubeedge/pulls/363/commits","review_comments_url":"https://api.github.com/repos/kubeedge/kubeedge/pulls/363/comments","review_comment_url":"https://api.github.com/repos/kubeedge/kubeedge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeedge/kubeedge/issues/363/comments","statuses_url":"https://api.github.com/repos/kubeedge/kubeedge/statuses/a2fe7e86de297bedc36ba5910784ae023aac48da","head":{"label":"sids-b:devicectrl","ref":"devicectrl","sha":"a2fe7e86de297bedc36ba5910784ae023aac48da","user":{"login":"sids-b","id":30088497,"node_id":"MDQ6VXNlcjMwMDg4NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/30088497?v=4","gravatar_id":"","url":"https://api.github.com/users/sids-b","html_url":"https://github.com/sids-b","followers_url":"https://api.github.com/users/sids-b/followers","following_url":"https://api.github.com/users/sids-b/following{/other_user}","gists_url":"https://api.github.com/users/sids-b/gists{/gist_id}","starred_url":"https://api.github.com/users/sids-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sids-b/subscriptions","organizations_url":"https://api.github.com/users/sids-b/orgs","repos_url":"https://api.github.com/users/sids-b/repos","events_url":"https://api.github.com/users/sids-b/events{/privacy}","received_events_url":"https://api.github.com/users/sids-b/received_events","type":"User","site_admin":false},"repo":{"id":163283868,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMyODM4Njg=","name":"kubeedge","full_name":"sids-b/kubeedge","private":false,"owner":{"login":"sids-b","id":30088497,"node_id":"MDQ6VXNlcjMwMDg4NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/30088497?v=4","gravatar_id":"","url":"https://api.github.com/users/sids-b","html_url":"https://github.com/sids-b","followers_url":"https://api.github.com/users/sids-b/followers","following_url":"https://api.github.com/users/sids-b/following{/other_user}","gists_url":"https://api.github.com/users/sids-b/gists{/gist_id}","starred_url":"https://api.github.com/users/sids-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sids-b/subscriptions","organizations_url":"https://api.github.com/users/sids-b/orgs","repos_url":"https://api.github.com/users/sids-b/repos","events_url":"https://api.github.com/users/sids-b/events{/privacy}","received_events_url":"https://api.github.com/users/sids-b/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sids-b/kubeedge","description":"Kubernetes Native Edge Computing Management Framework","fork":true,"url":"https://api.github.com/repos/sids-b/kubeedge","forks_url":"https://api.github.com/repos/sids-b/kubeedge/forks","keys_url":"https://api.github.com/repos/sids-b/kubeedge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sids-b/kubeedge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sids-b/kubeedge/teams","hooks_url":"https://api.github.com/repos/sids-b/kubeedge/hooks","issue_events_url":"https://api.github.com/repos/sids-b/kubeedge/issues/events{/number}","events_url":"https://api.github.com/repos/sids-b/kubeedge/events","assignees_url":"https://api.github.com/repos/sids-b/kubeedge/assignees{/user}","branches_url":"https://api.github.com/repos/sids-b/kubeedge/branches{/branch}","tags_url":"https://api.github.com/repos/sids-b/kubeedge/tags","blobs_url":"https://api.github.com/repos/sids-b/kubeedge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sids-b/kubeedge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sids-b/kubeedge/git/refs{/sha}","trees_url":"https://api.github.com/repos/sids-b/kubeedge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sids-b/kubeedge/statuses/{sha}","languages_url":"https://api.github.com/repos/sids-b/kubeedge/languages","stargazers_url":"https://api.github.com/repos/sids-b/kubeedge/stargazers","contributors_url":"https://api.github.com/repos/sids-b/kubeedge/contributors","subscribers_url":"https://api.github.com/repos/sids-b/kubeedge/subscribers","subscription_url":"https://api.github.com/repos/sids-b/kubeedge/subscription","commits_url":"https://api.github.com/repos/sids-b/kubeedge/commits{/sha}","git_commits_url":"https://api.github.com/repos/sids-b/kubeedge/git/commits{/sha}","comments_url":"https://api.github.com/repos/sids-b/kubeedge/comments{/number}","issue_comment_url":"https://api.github.com/repos/sids-b/kubeedge/issues/comments{/number}","contents_url":"https://api.github.com/repos/sids-b/kubeedge/contents/{+path}","compare_url":"https://api.github.com/repos/sids-b/kubeedge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sids-b/kubeedge/merges","archive_url":"https://api.github.com/repos/sids-b/kubeedge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sids-b/kubeedge/downloads","issues_url":"https://api.github.com/repos/sids-b/kubeedge/issues{/number}","pulls_url":"https://api.github.com/repos/sids-b/kubeedge/pulls{/number}","milestones_url":"https://api.github.com/repos/sids-b/kubeedge/milestones{/number}","notifications_url":"https://api.github.com/repos/sids-b/kubeedge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sids-b/kubeedge/labels{/name}","releases_url":"https://api.github.com/repos/sids-b/kubeedge/releases{/id}","deployments_url":"https://api.github.com/repos/sids-b/kubeedge/deployments","created_at":"2018-12-27T10:58:27Z","updated_at":"2019-03-26T05:19:07Z","pushed_at":"2019-04-18T12:33:56Z","git_url":"git://github.com/sids-b/kubeedge.git","ssh_url":"[email protected]:sids-b/kubeedge.git","clone_url":"https://github.com/sids-b/kubeedge.git","svn_url":"https://github.com/sids-b/kubeedge","homepage":"https://kubeedge.io","size":32800,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeedge:master","ref":"master","sha":"eab8e377b67a3343f7b31e09d5c2ba17b057e64e","user":{"login":"kubeedge","id":41812520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODEyNTIw","avatar_url":"https://avatars1.githubusercontent.com/u/41812520?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeedge","html_url":"https://github.com/kubeedge","followers_url":"https://api.github.com/users/kubeedge/followers","following_url":"https://api.github.com/users/kubeedge/following{/other_user}","gists_url":"https://api.github.com/users/kubeedge/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeedge/subscriptions","organizations_url":"https://api.github.com/users/kubeedge/orgs","repos_url":"https://api.github.com/users/kubeedge/repos","events_url":"https://api.github.com/users/kubeedge/events{/privacy}","received_events_url":"https://api.github.com/users/kubeedge/received_events","type":"Organization","site_admin":false},"repo":{"id":150713223,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA3MTMyMjM=","name":"kubeedge","full_name":"kubeedge/kubeedge","private":false,"owner":{"login":"kubeedge","id":41812520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODEyNTIw","avatar_url":"https://avatars1.githubusercontent.com/u/41812520?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeedge","html_url":"https://github.com/kubeedge","followers_url":"https://api.github.com/users/kubeedge/followers","following_url":"https://api.github.com/users/kubeedge/following{/other_user}","gists_url":"https://api.github.com/users/kubeedge/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeedge/subscriptions","organizations_url":"https://api.github.com/users/kubeedge/orgs","repos_url":"https://api.github.com/users/kubeedge/repos","events_url":"https://api.github.com/users/kubeedge/events{/privacy}","received_events_url":"https://api.github.com/users/kubeedge/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubeedge/kubeedge","description":"Kubernetes Native Edge Computing Framework (project under CNCF)","fork":false,"url":"https://api.github.com/repos/kubeedge/kubeedge","forks_url":"https://api.github.com/repos/kubeedge/kubeedge/forks","keys_url":"https://api.github.com/repos/kubeedge/kubeedge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeedge/kubeedge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeedge/kubeedge/teams","hooks_url":"https://api.github.com/repos/kubeedge/kubeedge/hooks","issue_events_url":"https://api.github.com/repos/kubeedge/kubeedge/issues/events{/number}","events_url":"https://api.github.com/repos/kubeedge/kubeedge/events","assignees_url":"https://api.github.com/repos/kubeedge/kubeedge/assignees{/user}","branches_url":"https://api.github.com/repos/kubeedge/kubeedge/branches{/branch}","tags_url":"https://api.github.com/repos/kubeedge/kubeedge/tags","blobs_url":"https://api.github.com/repos/kubeedge/kubeedge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeedge/kubeedge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeedge/kubeedge/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeedge/kubeedge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeedge/kubeedge/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeedge/kubeedge/languages","stargazers_url":"https://api.github.com/repos/kubeedge/kubeedge/stargazers","contributors_url":"https://api.github.com/repos/kubeedge/kubeedge/contributors","subscribers_url":"https://api.github.com/repos/kubeedge/kubeedge/subscribers","subscription_url":"https://api.github.com/repos/kubeedge/kubeedge/subscription","commits_url":"https://api.github.com/repos/kubeedge/kubeedge/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeedge/kubeedge/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeedge/kubeedge/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeedge/kubeedge/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeedge/kubeedge/contents/{+path}","compare_url":"https://api.github.com/repos/kubeedge/kubeedge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeedge/kubeedge/merges","archive_url":"https://api.github.com/repos/kubeedge/kubeedge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeedge/kubeedge/downloads","issues_url":"https://api.github.com/repos/kubeedge/kubeedge/issues{/number}","pulls_url":"https://api.github.com/repos/kubeedge/kubeedge/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeedge/kubeedge/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeedge/kubeedge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeedge/kubeedge/labels{/name}","releases_url":"https://api.github.com/repos/kubeedge/kubeedge/releases{/id}","deployments_url":"https://api.github.com/repos/kubeedge/kubeedge/deployments","created_at":"2018-09-28T08:57:49Z","updated_at":"2019-04-19T09:20:25Z","pushed_at":"2019-04-19T10:00:24Z","git_url":"git://github.com/kubeedge/kubeedge.git","ssh_url":"[email protected]:kubeedge/kubeedge.git","clone_url":"https://github.com/kubeedge/kubeedge.git","svn_url":"https://github.com/kubeedge/kubeedge","homepage":"https://kubeedge.io","size":32830,"stargazers_count":938,"watchers_count":938,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":213,"open_issues":59,"watchers":938,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeedge/kubeedge/pulls/363"},"html":{"href":"https://github.com/kubeedge/kubeedge/pull/363"},"issue":{"href":"https://api.github.com/repos/kubeedge/kubeedge/issues/363"},"comments":{"href":"https://api.github.com/repos/kubeedge/kubeedge/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeedge/kubeedge/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeedge/kubeedge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeedge/kubeedge/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/kubeedge/kubeedge/statuses/a2fe7e86de297bedc36ba5910784ae023aac48da"}},"author_association":"MEMBER"}}
|
{
"id": 150713223,
"name": "kubeedge/kubeedge",
"url": "https://api.github.com/repos/kubeedge/kubeedge"
}
|
{
"id": 4953962,
"login": "m1093782566",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4953962?",
"url": "https://api.github.com/users/m1093782566"
}
|
{
"id": 41812520,
"login": "kubeedge",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41812520?",
"url": "https://api.github.com/orgs/kubeedge"
}
| 2019-04-19T10:05:29 |
9475160504
|
{"actor":{"display_login":"m1093782566"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/comments/274861359","pull_request_review_id":226022764,"id":274861359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NDg2MTM1OQ==","diff_hunk":"@@ -309,31 +488,233 @@ contract Group is GroupI, UsingExternalStorage\n pure\n returns (bytes32)\n {\n- return keccak256(abi.encodePacked(_groupId, _role, _secretHash, _nonce));\n+ return keccak256(\n+ abi.encodePacked(\n+ _groupId, \n+ \"storeInvitation\", // for sig uniqueness\n+ _role, \n+ _secretHash, \n+ _nonce\n+ )\n+ );\n }\n \n- function inviteToCommunity(\n+ // store invitation \n+ function storeInvitation(\n uint256 _groupId, \n uint8 _role,\n bytes32 _secretHash,\n bytes memory _signature,\n uint256 _nonce\n )\n public\n- returns (bool) // the doc says return txHash, so we'll wait for tx receipt?\n+ returns (bool) \n {\n- address _signer = getSigner(_secretHash, _signature, _nonce);\n- addMember(_groupId, _signer, _role);\n+ // recover signer, and set as address\n+ storageContract.putAddressValue(keccak256(\n+ abi.encodePacked(INVITATION_KEY, _groupId, _secretHash, \"SIGNER\")), \n+ // msgHash from call to prepareInvitation()\n+ getSigner(prepareInvitation(_groupId, _role, _secretHash, _nonce), _signature, _nonce)\n+ );\n+\n+ // store secretHash so it can be checked later\n+ storageContract.putBytes32Value(keccak256(\n+ abi.encodePacked(INVITATION_KEY, _groupId, _secretHash, \"SECRET_HASH\")), \n+ _secretHash\n+ );\n+\n+ // set role\n+ storageContract.putUintValue(keccak256(\n+ abi.encodePacked(INVITATION_KEY, _groupId, _secretHash, \"ROLE\")), \n+ _role\n+ );\n+\n+ // set expiration date of 3 days\n+ storageContract.putUintValue(keccak256(\n+ abi.encodePacked(INVITATION_KEY, _groupId, _secretHash, \"EXPIRATION_DATE\")), \n+ now + expirationPeriod\n+ );\n+\n+ // put invitation into default state of pending\n+ storageContract.putUintValue(keccak256(\n+ abi.encodePacked(INVITATION_KEY, _groupId, _secretHash, \"STATE\")), \n+ uint(defaultState)\n+ );\n+\n+ // emit event\n emit InvitationPending(_groupId, _role, _secretHash);\n return true;\n }\n \n- /////////////////////////\n- //\n- // invitation events\n- //\n+ /*\n+ * Revocation of a Pending Invitation\n+ */ \n+\n+ // prepare to revoke a pending invitation\n+ function prepareRevokeInvitation(\n+ uint256 _groupId,\n+ bytes32 _secretHash,\n+ uint256 _nonce\n+ )\n+ public\n+ pure \n+ returns (bytes32)\n+ {\n+ return keccak256(\n+ abi.encodePacked(\n+ _groupId, \n+ \"revokeInvitation\",\n+ _secretHash, \n+ _nonce\n+ )\n+ );\n+ }\n+ \n+ function revokeInvitation(\n+ uint256 _groupId,\n+ bytes32 _secretHash,\n+ bytes memory _signature,\n+ uint256 _nonce\n+ )\n+ public\n+ returns (bool)\n+ {\n+ uint256 signerRole = storageContract.getUintValue(\n+ keccak256(\n+ abi.encodePacked(\n+ MEMBER_KEY, \n+ _groupId, \n+ getSigner(\n+ prepareRevokeInvitation(\n+ _groupId, \n+ _secretHash, \n+ _nonce\n+ ), \n+ _signature, \n+ _nonce\n+ )\n+ )\n+ )\n+ ); \n+\n+ require(uint8(signerRole) == admin);\n+\n+ storageContract.putUintValue(keccak256(\n+ abi.encodePacked(INVITATION_KEY, _groupId, _secretHash, \"STATE\")),\n+ uint(InvitationState.Revoked)\n+ );\n+\n+ return true;\n+ }\n+\n+ /*\n+ * Accepting an Invitation\n+ */ \n+\n+ function prepareAcceptInvitationCommit(\n+ uint256 _groupId,\n+ bytes32 _addressSecretHash,\n+ uint256 _nonce\n+ )\n+ public\n+ pure \n+ returns (bytes32)\n+ {\n+ return keccak256(\n+ abi.encodePacked(\n+ _groupId,\n+ \"acceptInvitationCommit\",\n+ _addressSecretHash,\n+ _nonce\n+ )\n+ );\n+ }\n+\n+ function acceptInvitationCommit(\n+ uint256 _groupId,\n+ bytes32 _addressSecretHash,\n+ bytes memory _signature,\n+ uint256 _nonce\n+ )\n+ public\n+ returns (bool)\n+ {\n+ // get sender by retrieving from signature\n+ address sender = getSigner(\n+ prepareAcceptInvitationCommit(\n+ _groupId,\n+ _addressSecretHash,\n+ _nonce\n+ ), \n+ _signature, \n+ _nonce\n+ );\n+\n+ commits[sender].id = _groupId;\n+ commits[sender].commit = _addressSecretHash;\n+ commits[sender].sig = _signature;\n+ commits[sender].block = uint64(block.number);\n+ commits[sender].revealed = false;\n+\n+ emit AcceptCommitted(_groupId, _addressSecretHash);\n+ return true;\n+ }\n+\n+ function acceptInvitation(\n+ uint256 _groupId,\n+ bytes32 _secret,\n+ address _sender\n+ )\n+ public\n+ returns (bool)\n+ {\n+ // assign reference to ephemeral Commit struct\n+ Commit storage tempCommit = commits[_sender];\n+ \n+ // retrieve secretHash\n+ bytes32 secretHash = storageContract.getBytes32Value(keccak256(\n+ abi.encodePacked(INVITATION_KEY, _groupId, keccak256(abi.encodePacked(_secret)), \"SECRET_HASH\")\n+ ));\n+\n+ // retrieve expiration date from ext. storage \n+ uint expirationDate = storageContract.getUintValue(keccak256(\n+ abi.encodePacked(INVITATION_KEY, _groupId, _secret, \"EXPIRATION_DATE\")","path":"sidechain/contracts/group/Group.sol","position":528,"original_position":528,"commit_id":"6e139716976ad24df29b495962467eab9b078006","original_commit_id":"6e139716976ad24df29b495962467eab9b078006","user":{"login":"gjeanmart","id":506784,"node_id":"MDQ6VXNlcjUwNjc4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/506784?v=4","gravatar_id":"","url":"https://api.github.com/users/gjeanmart","html_url":"https://github.com/gjeanmart","followers_url":"https://api.github.com/users/gjeanmart/followers","following_url":"https://api.github.com/users/gjeanmart/following{/other_user}","gists_url":"https://api.github.com/users/gjeanmart/gists{/gist_id}","starred_url":"https://api.github.com/users/gjeanmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjeanmart/subscriptions","organizations_url":"https://api.github.com/users/gjeanmart/orgs","repos_url":"https://api.github.com/users/gjeanmart/repos","events_url":"https://api.github.com/users/gjeanmart/events{/privacy}","received_events_url":"https://api.github.com/users/gjeanmart/received_events","type":"User","site_admin":false},"body":"The key to retrieve the expiration date is incorrect so I imagine the storage contract return 0.\r\n\r\nIn **storeInvitation()**, the key used is `abi.encodePacked(INVITATION_KEY, _groupId, _secretHash, \"EXPIRATION_DATE\"))`\r\n\r\nBut here it's `abi.encodePacked(INVITATION_KEY, _groupId, _secret, \"EXPIRATION_DATE\")`\r\n\r\nNeed to replace `_secret` by `keccak256(abi.encodePacked(_secret))`\r\n","created_at":"2019-04-12T11:10:30Z","updated_at":"2019-04-12T11:12:08Z","html_url":"https://github.com/kauri-io/kauri-smart-contracts/pull/28#discussion_r274861359","pull_request_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/28","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/comments/274861359"},"html":{"href":"https://github.com/kauri-io/kauri-smart-contracts/pull/28#discussion_r274861359"},"pull_request":{"href":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/28","id":268611145,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4NjExMTQ1","html_url":"https://github.com/kauri-io/kauri-smart-contracts/pull/28","diff_url":"https://github.com/kauri-io/kauri-smart-contracts/pull/28.diff","patch_url":"https://github.com/kauri-io/kauri-smart-contracts/pull/28.patch","issue_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues/28","number":28,"state":"open","locked":false,"title":"working on invitations for the sidechain","user":{"login":"wilbarnes","id":31866314,"node_id":"MDQ6VXNlcjMxODY2MzE0","avatar_url":"https://avatars1.githubusercontent.com/u/31866314?v=4","gravatar_id":"","url":"https://api.github.com/users/wilbarnes","html_url":"https://github.com/wilbarnes","followers_url":"https://api.github.com/users/wilbarnes/followers","following_url":"https://api.github.com/users/wilbarnes/following{/other_user}","gists_url":"https://api.github.com/users/wilbarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/wilbarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilbarnes/subscriptions","organizations_url":"https://api.github.com/users/wilbarnes/orgs","repos_url":"https://api.github.com/users/wilbarnes/repos","events_url":"https://api.github.com/users/wilbarnes/events{/privacy}","received_events_url":"https://api.github.com/users/wilbarnes/received_events","type":"User","site_admin":false},"body":"creating pr for ongoing review for invitations work\r\n\r\nsome goals of mine from now to friday:\r\n\r\n- finish the secretAddressHash commit and acceptance functions\r\n- include revocation functions\r\n- default acceptance window is now 3 days as i discussed with greg, though we'll include a mechanism to change that\r\n- keep adding to the test suite (and still need to lookup code coverage tool)","created_at":"2019-04-09T07:13:42Z","updated_at":"2019-04-12T11:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bde99cbfbad80bda896b70fff144e8fd83d572a8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"joshorig","id":852671,"node_id":"MDQ6VXNlcjg1MjY3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852671?v=4","gravatar_id":"","url":"https://api.github.com/users/joshorig","html_url":"https://github.com/joshorig","followers_url":"https://api.github.com/users/joshorig/followers","following_url":"https://api.github.com/users/joshorig/following{/other_user}","gists_url":"https://api.github.com/users/joshorig/gists{/gist_id}","starred_url":"https://api.github.com/users/joshorig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshorig/subscriptions","organizations_url":"https://api.github.com/users/joshorig/orgs","repos_url":"https://api.github.com/users/joshorig/repos","events_url":"https://api.github.com/users/joshorig/events{/privacy}","received_events_url":"https://api.github.com/users/joshorig/received_events","type":"User","site_admin":false},{"login":"craigwilliams84","id":11519649,"node_id":"MDQ6VXNlcjExNTE5NjQ5","avatar_url":"https://avatars2.githubusercontent.com/u/11519649?v=4","gravatar_id":"","url":"https://api.github.com/users/craigwilliams84","html_url":"https://github.com/craigwilliams84","followers_url":"https://api.github.com/users/craigwilliams84/followers","following_url":"https://api.github.com/users/craigwilliams84/following{/other_user}","gists_url":"https://api.github.com/users/craigwilliams84/gists{/gist_id}","starred_url":"https://api.github.com/users/craigwilliams84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigwilliams84/subscriptions","organizations_url":"https://api.github.com/users/craigwilliams84/orgs","repos_url":"https://api.github.com/users/craigwilliams84/repos","events_url":"https://api.github.com/users/craigwilliams84/events{/privacy}","received_events_url":"https://api.github.com/users/craigwilliams84/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/28/commits","review_comments_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/28/comments","review_comment_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues/28/comments","statuses_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/statuses/6e139716976ad24df29b495962467eab9b078006","head":{"label":"kauri-io:sidechain","ref":"sidechain","sha":"6e139716976ad24df29b495962467eab9b078006","user":{"login":"kauri-io","id":42040459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDQwNDU5","avatar_url":"https://avatars3.githubusercontent.com/u/42040459?v=4","gravatar_id":"","url":"https://api.github.com/users/kauri-io","html_url":"https://github.com/kauri-io","followers_url":"https://api.github.com/users/kauri-io/followers","following_url":"https://api.github.com/users/kauri-io/following{/other_user}","gists_url":"https://api.github.com/users/kauri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kauri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauri-io/subscriptions","organizations_url":"https://api.github.com/users/kauri-io/orgs","repos_url":"https://api.github.com/users/kauri-io/repos","events_url":"https://api.github.com/users/kauri-io/events{/privacy}","received_events_url":"https://api.github.com/users/kauri-io/received_events","type":"Organization","site_admin":false},"repo":{"id":146929600,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5Mjk2MDA=","name":"kauri-smart-contracts","full_name":"kauri-io/kauri-smart-contracts","private":false,"owner":{"login":"kauri-io","id":42040459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDQwNDU5","avatar_url":"https://avatars3.githubusercontent.com/u/42040459?v=4","gravatar_id":"","url":"https://api.github.com/users/kauri-io","html_url":"https://github.com/kauri-io","followers_url":"https://api.github.com/users/kauri-io/followers","following_url":"https://api.github.com/users/kauri-io/following{/other_user}","gists_url":"https://api.github.com/users/kauri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kauri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauri-io/subscriptions","organizations_url":"https://api.github.com/users/kauri-io/orgs","repos_url":"https://api.github.com/users/kauri-io/repos","events_url":"https://api.github.com/users/kauri-io/events{/privacy}","received_events_url":"https://api.github.com/users/kauri-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kauri-io/kauri-smart-contracts","description":null,"fork":false,"url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts","forks_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/forks","keys_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/teams","hooks_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/hooks","issue_events_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/events","assignees_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/tags","blobs_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/languages","stargazers_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/stargazers","contributors_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/contributors","subscribers_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/subscribers","subscription_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/subscription","commits_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/merges","archive_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/downloads","issues_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/labels{/name}","releases_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/deployments","created_at":"2018-08-31T18:34:32Z","updated_at":"2019-04-01T21:00:11Z","pushed_at":"2019-04-11T18:27:56Z","git_url":"git://github.com/kauri-io/kauri-smart-contracts.git","ssh_url":"[email protected]:kauri-io/kauri-smart-contracts.git","clone_url":"https://github.com/kauri-io/kauri-smart-contracts.git","svn_url":"https://github.com/kauri-io/kauri-smart-contracts","homepage":null,"size":161,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"kauri-io:dev2","ref":"dev2","sha":"564f1d1062c02689afa13cca5e69de560fc5cc17","user":{"login":"kauri-io","id":42040459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDQwNDU5","avatar_url":"https://avatars3.githubusercontent.com/u/42040459?v=4","gravatar_id":"","url":"https://api.github.com/users/kauri-io","html_url":"https://github.com/kauri-io","followers_url":"https://api.github.com/users/kauri-io/followers","following_url":"https://api.github.com/users/kauri-io/following{/other_user}","gists_url":"https://api.github.com/users/kauri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kauri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauri-io/subscriptions","organizations_url":"https://api.github.com/users/kauri-io/orgs","repos_url":"https://api.github.com/users/kauri-io/repos","events_url":"https://api.github.com/users/kauri-io/events{/privacy}","received_events_url":"https://api.github.com/users/kauri-io/received_events","type":"Organization","site_admin":false},"repo":{"id":146929600,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5Mjk2MDA=","name":"kauri-smart-contracts","full_name":"kauri-io/kauri-smart-contracts","private":false,"owner":{"login":"kauri-io","id":42040459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDQwNDU5","avatar_url":"https://avatars3.githubusercontent.com/u/42040459?v=4","gravatar_id":"","url":"https://api.github.com/users/kauri-io","html_url":"https://github.com/kauri-io","followers_url":"https://api.github.com/users/kauri-io/followers","following_url":"https://api.github.com/users/kauri-io/following{/other_user}","gists_url":"https://api.github.com/users/kauri-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kauri-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauri-io/subscriptions","organizations_url":"https://api.github.com/users/kauri-io/orgs","repos_url":"https://api.github.com/users/kauri-io/repos","events_url":"https://api.github.com/users/kauri-io/events{/privacy}","received_events_url":"https://api.github.com/users/kauri-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kauri-io/kauri-smart-contracts","description":null,"fork":false,"url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts","forks_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/forks","keys_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/teams","hooks_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/hooks","issue_events_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/events","assignees_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/tags","blobs_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/languages","stargazers_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/stargazers","contributors_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/contributors","subscribers_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/subscribers","subscription_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/subscription","commits_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/merges","archive_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/downloads","issues_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/labels{/name}","releases_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/deployments","created_at":"2018-08-31T18:34:32Z","updated_at":"2019-04-01T21:00:11Z","pushed_at":"2019-04-11T18:27:56Z","git_url":"git://github.com/kauri-io/kauri-smart-contracts.git","ssh_url":"[email protected]:kauri-io/kauri-smart-contracts.git","clone_url":"https://github.com/kauri-io/kauri-smart-contracts.git","svn_url":"https://github.com/kauri-io/kauri-smart-contracts","homepage":null,"size":161,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/28"},"html":{"href":"https://github.com/kauri-io/kauri-smart-contracts/pull/28"},"issue":{"href":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues/28"},"comments":{"href":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/kauri-io/kauri-smart-contracts/statuses/6e139716976ad24df29b495962467eab9b078006"}},"author_association":"NONE"}}
|
{
"id": 146929600,
"name": "kauri-io/kauri-smart-contracts",
"url": "https://api.github.com/repos/kauri-io/kauri-smart-contracts"
}
|
{
"id": 506784,
"login": "gjeanmart",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/506784?",
"url": "https://api.github.com/users/gjeanmart"
}
|
{
"id": 42040459,
"login": "kauri-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42040459?",
"url": "https://api.github.com/orgs/kauri-io"
}
| 2019-04-12T11:10:30 |
9431275702
|
{"actor":{"display_login":"gjeanmart"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/comments/301129418","pull_request_review_id":258918870,"id":301129418,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTEyOTQxOA==","diff_hunk":"@@ -0,0 +1,1211 @@\n+# Reproducibility {#r-reproducibility}\n+\n+## Questions\n+\n+- How do I organize my data analysis projects, my files, and my folders?\n+- How can I make sure that my code is understandable to others?\n+- How do I ensure my analyses are reproducible by others (and myself 9 months in\n+the future)?\n+\n+TODO: Add more. Ideas?\n+\n+## Objectives \n+\n+1. To become aware of and learn some \"best practices\" (or \"good enough\n+practices\") for project organization.\n+1. To use RStudio to create and manage projects in a consistent and structured\n+way.\n+1. To become aware of the importance of reproducibility in data analyses, for\n+your own productivity and for greater rigor in science.\n+1. To create reproducible documents interwoven with R code that can be easily\n+updated by changing the code or data.\n+\n+TODO: Briefly introduce functions here?\n+\n+## Introduction\n+\n+### What is reproducibility and why try to do it?\n+\n+There are several key cornerstones for doing rigorous and sound scientific\n+research, two of which are reproducibility and replicability. Replicability is\n+when a study is repeated by other independent research groups. Reproducibility\n+is when, given the same data and the same analytical/computational steps, a\n+scientific result can be verified. Both of these concepts are surprisingly\n+difficult to achieve.\n+\n+This course is about data analysis, so we'll be focusing solely on reproducibility\n+rather than replicability. At present, there is little effort in science for\n+having research be reproducible, likely due in many ways to a lack of training\n+and awareness. Being reproducible isn't also just about doing better science, it\n+can also:\n+\n+TODO: Add some reference here about definitions, lacking reproducibility, etc?\n+\n+1. Make you much more efficient and productive, as you spend less time between\n+coding and putting your results in the document.\n+1. Make you more confident in your results, since what you report and show as\n+figures or tables will be exactly what you get from your analysis. No copying\n+and pasting required!\n+\n+TODO: Add more items here.\n+\n+There are many aspects to reproducibility, such as:\n+\n+- Organized files and folder, preferably based on a standard or conventional structure.\n+- Understandable and readable code that is documented and descriptive.\n+- Results from analyses are identical to results presented in scientific output (e.g. article, poster, slides).\n+- Results from analyses are identical when code is executed on other machines (results aren't dependent on one computer).\n+- Explicit description or instruction on the order that code and scripts need to be executed.\n+\n+We'll cover the first three items in this course.\n+\n+## Project organization\n+\n+First off, what exactly does \"project\" mean? That depends a bit on the group,\n+individual, or situation, but for our purposes, a \"project\" is anything related\n+to completed one or more scientific \"products\" (e.g. poster, slides, manuscript,\n+package, teaching material) related to a specific question or goal. This could\n+be \"one manuscript publication and associated conference presentations\" per project.\n+Keeping a project confined to one \"scientific output\" ensures that the project\n+is kept reproducible, all files will relate to that \"output\", and can be easily\n+archived once the manuscript has been published. However, this definition could\n+be different depending on your own situation and goals.\n+\n+TODO: refs to rrtools, prodigenr\n+\n+The ability to read, understand, modify, and write simple pieces of code is an\n+essential skill for modern data analysis tasks and projects. Here we introduce\n+you to some of the best practices one should have while writing their code.\n+Many of these best practices were taken from published \"best practices\" articles\n+[@Nobl2009;@Tasc2017;@Wils2017]\n+\n+TODO: Other references for best practices?\n+\n+- Organise all R scripts and files in a single parent directory using a common\n+and consistent folder and file structure.\n+- Use [version control][version-control] to track changes to files.\n+- Make raw data \"read-only\" (don't edit it directly) and use code to show what\n+was done.\n+- Write and describe code for people to read by being descriptive and using a\n+[style guide][r-style-guide].\n+- Think of code as part of your research product: Write for an audience \n+or other reader.\n+- Don't repeat yourself by using and creating functions.\n+- Whenever possible, use code to create output (figures, tables) rather than\n+manualling creating or editing them.\n+\n+Managing your projects in a reproducible fashion doesn't just make your science\n+reproducible, it also makes your life easier! RStudio is here to help us with\n+that by using [R Projects][rstudio-r-projects]. RStudio projects make it\n+straightforward to divide your work into multiple contexts, each with their own\n+working directory, workspace, history, and source documents.\n+\n+It is strongly recommended that you store *all* the necessary files that will be\n+used in your code in the **same parent directory**. You can then use\n+relative file paths to access them (we'll talk about file paths below). This\n+makes the directory and R Project a \"product\" or \"bundle/package\". Like a tiny\n+machine, that needs to have all its parts in the same place.\n+\n+### Creating your first project\n+\n+There are many ways one could organise a project folder. We'll set up a project\n+directory folder using the\n+[prodigenr](http://prodigenr.lukewjohnston.com) package:\n+\n+```r\n+# prodigenr::setup_project(\"ProjectName\")\n+prodigenr::setup_project(\"learningr\")\n+```\n+\n+TODO: Use prodigenr or something else?\n+\n+When we use the `::` colon here, we are telling R \"from the prodigenr package use\n+the setup_project function\". This function will then create the following\n+folders and files:\n+\n+```\n+learningr\n+โโโ R\n+โ โโโ README.md\n+โ โโโ fetch_data.R\n+โ โโโ setup.R\n+โโโ data\n+โ โโโ README.md\n+โโโ doc\n+โ โโโ README.md\n+โโโ .gitignore\n+โโโ DESCRIPTION\n+โโโ learningr.Rproj\n+โโโ README.md\n+```\n+\n+This forces a specific, and consistent, folder structure to all your work. Think \n+of this like the \"introduction\", \"methods\", \"results\", and \"discussion\" sections \n+of your paper. Each project is then like a single manuscript or report, that\n+contains everything relevant to that specific project. There is a lot of\n+power in something as simple as a consistent structure. Projects are used to\n+make life easier. Once a project is opened within RStudio the following actions\n+are taken:\n+\n+- A new R session (process) is started.\n+- The current working directory is set to the project directory.\n+- RStudio project options are loaded.\n+\n+The README in each folder explains a bit about what should be placed there. But\n+briefly:\n+\n+1. Documents like manuscripts, abstracts, and exploration type documents should \n+be put in the `doc/` directory (including [R Markdown][r-markdown] files which\n+we will cover [later](#r-markdown)).\n+1. Data, raw data, and metadata should be in either the `data/` directory or\n+in `data-raw/` for the raw data.\n+1. All R files and code should be in the `R/` directory.\n+1. Name all new files to reflect their content or function. Follow the tidyverse \n+[style guide for file naming][r-style-guide-files].\n+\n+Note the `DESCRIPTION` file. This is used as metadata about the project and is \n+useful when working on R projects. For any project, it is **highly recommended**\n+to use [version control]. We'll be covering version control in more detail\n+[later](#version-control) in the course.\n+\n+TODO: Make sure the internal reference links are correct.\n+\n+### Exercise: Better file naming\n+\n+Look at the list of file names below. Which file names are good names and which\n+shouldn't you use? \n+\n+```\n+fit models.R\n+fit-models.R\n+foo.r\n+stuff.r\n+get_data.R\n+Manuscript version 10.docx\n+manuscript.docx\n+new version of analysis.R\n+trying.something.here.R\n+plotting-regression.R\n+utility_functions.R\n+code.R\n+```\n+\n+### Should you keep your data under version control?\n+\n+We have a `data/` folder for a reason. But you might not want to keep the data\n+under version control, for several reasons:\n+\n+1. It's a large dataset (tens or more of Mb file size)\n+2. There are sensitive or personal information in the data\n+\n+As a rule of thumb, if you can send the data by an email attachment, you could\n+probably put it into Git. Unless there is sensitive or personal data, then don't.\n+If it isn't kept under version control, make sure you include a reference to how\n+or where you got the data, either as an R script showing the code you used to \n+import/clean/download it or described in the `README.md` file.\n+\n+## Reusability\n+\n+Part of reproducibility is also making sure your scripts and file organization is\n+\"reusable\" meaning that others (or yourself) can run it again. So, for instance,\n+making sure to use \"relative file paths\" compared to \"absolute file paths\"\n+(we'll cover these in a bit). Or indicating which other R packages your code\n+depends on. So here we'll cover how to make sure your scripts and project files\n+are reusable.\n+\n+### Keeping a \"clean slate\"\n+\n+When you finish writing your R code for the day and close the session, you probably\n+will be asked about saving your session. What this does is everything kept in the\n+\"Environment\" (e.g. all objects, functions, or datasets you created and used\n+during the session) get saved to an `.RData` file. Then, the next time you open up\n+your R session, R will see this `.RData` file and load everything in that file.\n+Everything you did previously will be loaded into your \"Environment\". This seems like\n+a good thing... but it's not. Imagine eating your dinner on a really dirty plate...\n+that's not pleasant right? Loading a previous session is like that dirty plate.\n+\n+So, to make sure you always use a \"clean plate\", we'll run a handy function from \n+the [usethis][usethis] package to stop R from saving and loading this `.RData`\n+file, ensuring you have a clean working environment:\n+\n+```r\n+usethis::use_blank_slate()\n+```\n+\n+We'll use the usethis package more throughout this chapter and others, as it provides\n+several very useful functions when working with projects.\n+\n+### Packages, data, and file paths\n+\n+A major strength of R is in its ability for others to easily create packages\n+that simplify doing complex tasks (e.g. running mixed effects models with the\n+[lme4][lme4] package or creating figures with the [ggplot2][ggplot2] package)\n+and for anyone to easily install and use that package. You may encounter some\n+who say you shouldn't rely on packages and only use base R functions. However, \n+this is seriously bad advice since the ecosystem of R packages can greatly \n+simplify your life doing data analysis. Plus, packages greatly expand and enhance\n+the capability of R, so make use of packages! If someone invents a wheel, why\n+wouldn't you use it?\n+\n+You load a package by writing:\n+\n+```r\n+library(tidyverse)\n+```\n+\n+Working with multiple R scripts and files, it quickly gets tedious to always\n+write out each library function at the top of each script. A better way of\n+managing this is to create a new file, keep all package loading code in that\n+file, and sourcing that file in each R script. So, to create a new R file\n+in the `R/` folder, we'll use this `use_r()` function from the usethis package:\n+\n+```r\n+usethis::use_r(\"package-loading\")\n+```\n+\n+This creates a file called `package-loading.R` in the `R/` folder. In the\n+`package-loading.R` file, add this code to it.\n+\n+```r\n+library(tidyverse)\n+```\n+\n+Then in other R scripts in the `R/`, include this code at the top the script:\n+\n+```r\n+source(here::here(\"R/package-loading.R\"))\n+```\n+\n+There's a new thing `here`! The [here][r-here-pkg] package uses a function\n+called `here()` that makes it easier to manage file paths. What is a file path\n+and why is this necessary? A file path is the list of folders a file is found\n+in. For instance, your resume may be found in\n+`/Users/Documents/personal_things/resume.docx`. The problem with file paths in R\n+is that when you run a script interactively (e.g. what we do in class and\n+normally), the file path is located at the Project level (where the `.Rproj`\n+file is found). You can see the file path by looking at the top of the\n+\"Console\".\n+\n+But! When you `source()` an R script, it may likely run *in the\n+folder it is saved in*, e.g. in the `R/` folder. So your file path\n+`R/packages-loading.R` won't work because there isn't a folder called R in the\n+`R/` folder. Often people use the function `setwd()`, but this is *never* a good\n+idea since using it makes your script *runnable only on your computer*... which\n+makes it no longer reproducible. We use the `here()` function to tell R to go\n+to the project root (where the `.Rproj` file is found) and then use the file\n+path from that point. This simple function can make your work more reproducible\n+and easier for you to use later on.\n+\n+We also use the `here()` function when we import a dataset or save a dataset.\n+So, let's load in the NYC Dog License dataset. First, save the csv in the\n+`data/` folder. Then create a new R file:\n+\n+```r\n+usethis::use_r(\"load-data\")\n+```\n+\n+And write these lines in the file:\n+\n+```{r load-data-example, eval=FALSE}\n+source(here::here(\"R/package-loading.R\"))\n+dog_license <- read_csv(here::here(\"data/nyc-dog.....csv\"))\n+# TODO complete this file path.\n+head(dog_license)\n+```\n+\n+That is how we will load data in from now on.\n+\n+Here are a few other tips for keeping your code reusable:\n+\n+- Aggressively try keep your code as simple and concise as you can. The less code\n+you have to write, debug, and maintain, the better. If you repeat some code,\n+stop and think how to not repeat it. You will save time in the end by taking\n+time to think and plan.\n+- When encountering a difficult problem, think about how to solve it, then try\n+to find R packages or functions that do your problem for you. You may hear some\n+poeple say \"oh, don't bother with R packages, do everything in base R\"... don't \n+listen to them. Do you build a computer from scratch everytime you want to do\n+any type of work? Or a car when you want to drive somewhere? No, you don't. Make\n+use of other people's hard work to make tools that simplify your life.\n+- Split up your analyses steps into individual files (e.g. \"model\" file, \"plot\"\n+file). Then `source` those files as needed or save the output in `data/` to use \n+it in other files.\n+- Try not to have R scripts be too long (e.g. more than 500 lines of code). Keep\n+script sizes as small as necessary and as specific as possible (have a single\n+purpose). A script should have an end goal.\n+\n+## Readability\n+\n+There are two reasons we write code: to instruct the computer to do something and\n+to record the steps we took to get a particular result for us or others to\n+understand. For computers, *how* or *what* you write doesn't matter, as long as\n+the code is correct. Computers don't need to *understand* the code. But humans\n+do need to understand it. We need clear language and explicit meaning in order\n+to understand what is going on. Humans write code, humans read code, and humans\n+must maintain them and fix any errors. So, what you write and how you write it\n+is extremely important.\n+\n+Like natural human languages, R has a relaxed approached to how R code is written.\n+This has some nice advantages, but also some major disadvantages, notably that\n+writing styles can be quite different across the world or even within one's own\n+code. So, it's important to stick to some guidelines, for instance, as laid out\n+by the tidyverse [style guide][r-style-guide].\n+\n+Some tips to use when working in R:\n+\n+- Think of writing code as if you are writing in a natural language like English.\n+- Imagine that other people will be reading your code.\n+- Keep the code clear, simple, and *readable*.\n+- Stick to a *[style guide][r-style-guide]*.\n+- Use full and descriptive words when typing and creating objects.\n+- Use white space to separate concepts (empty lines between them, use spaces, and/or tabs).\n+- Use RStudio R Script Sections (`\"Code->Insert Section\"` or `Ctrl-Shift-R`) to\n+separate content in scripts.\n+\n+Even though R doesn't care about naming, spacing, and indenting, it really\n+matters how your code looks. Coding is just like writing. Even though you may go\n+through a brainstorming note-taking stage of writing, you eventually need to\n+write correctly so others can understand, *and read*, what you are trying to\n+say. Brainstorming and exploratory work is fine, but eventually you need to\n+write code that will be legible. That's why using a [style guide][r-style-guide]\n+is really important.\n+\n+### Exercise: Make the code more readable\n+\n+Using the [style guide][r-style-guide] found in the link, try to make these code\n+more readable. The code below is in some way either *wrong* or incorrectly\n+written. Edit the code so it follows the correct style and so it is easier to\n+understand and read. You don't need to understand what the code does, just\n+follow the guide.\n+\n+```{r r-repro-exercise-readable-code, eval=FALSE}\n+# Object names\n+DayOne\n+dayone\n+T <- FALSE\n+c <- 9\n+mean <- function(x) sum(x)\n+\n+# Spacing\n+x[,1]\n+x[ ,1]\n+x[ , 1]\n+mean (x, na.rm = TRUE)\n+mean( x, na.rm = TRUE )\n+function (x) {}\n+function(x){}\n+height<-feet*12+inches\n+mean(x, na.rm=10)\n+sqrt(x ^ 2 + y ^ 2)\n+df $ z\n+x <- 1 : 10\n+\n+# Indenting\n+if (y < 0 && debug)\n+message(\"Y is negative\")\n+```\n+\n+FIXME: The below \"details\" will need to be dealt with since PDF doesn't allow this\n+TODO: Maybe move to a solutions section at the end of chapter?\n+\n+<details><summary><strong>Click for a possible solution</strong></summary>\n+<p>\n+\n+The old code is in comments and the better code is below it.\n+\n+```{r r-repro-exercise-readable-code-solution, eval=FALSE}\n+# Object names\n+\n+# Should be camel case\n+# DayOne\n+day_one\n+# dayone\n+day_one\n+\n+# Should not over write existing function names\n+# T = TRUE, so don't name anything T\n+# T <- FALSE\n+false <- FALSE\n+# c is a function name already. Plus c is not descriptive\n+# c <- 9\n+number_value <- 9\n+# mean is a function, plus does not describe the function which is sum\n+# mean <- function(x) sum(x)\n+sum_vector <- function(x) sum(x)\n+\n+# Spacing\n+# Commas should be in correct place\n+# x[,1]\n+# x[ ,1]\n+# x[ , 1]\n+x[, 1]\n+# Spaces should be in correct place\n+# mean (x, na.rm = TRUE)\n+# mean( x, na.rm = TRUE )\n+mean(x, na.rm = TRUE)\n+# function (x) {}\n+# function(x){}\n+function(x) {}\n+# height<-feet*12+inches\n+height <- feet * 12 + inches\n+# mean(x, na.rm=10)\n+mean(x, na.rm = 10)\n+# sqrt(x ^ 2 + y ^ 2)\n+sqrt(x^2 + y^2)\n+# df $ z\n+df$z\n+# x <- 1 : 10\n+x <- 1:10\n+\n+# Indenting should be done after if, for, else functions\n+# if (y < 0 && debug)\n+# message(\"Y is negative\")\n+if (y < 0 && debug)\n+ message(\"Y is negative\")\n+```\n+\n+</p>\n+</details>\n+\n+### Automatic styling with styler\n+\n+You may have organised the exercise by hand, but it's possible to do it\n+automatically. The tidyverse [style guide][r-style-guide] has been implemented\n+into the [styler][styler-pkg] package to automate the process of following the\n+guide by directly re-styling selected code. The styler snippets can be found in\n+the Addins function in the RStudio \"Addins\" menu after you have installed it.\n+\n+RStudio also has its own automatic styling ability, through the menu item `\"Code ->\n+Reformat Code\"` (or `Ctrl-Shift-A`). Try both methods of styling on the exercise\n+code above. There are slight differences in how each method works and they both\n+aren't always perfect. For now, let's stick with using the styler package. The\n+styler functions work on R code within both `.R` script files as well as R code\n+within `.Rmd` documents, which we will cover later in this lesson.\n+\n+There are several styler RStudio addins, but we'll focus on the two:\n+\n+- `\"Style selection\"`: Highlight text and click this button to reformat the code.\n+- `\"Style active file\"`: Code in the `.R` or `.Rmd` file you have open and\n+visible in RStudio will be reformatted when you click this button.\n+\n+There are two other styler functions that are also useful:\n+\n+- `styler::style_file(\"path/to/filename\")`: Styles the whole file as indicated by the\n+file path in the first argument. Can be either an `.R` or `.Rmd` file.\n+- `styler::style_dir(\"directoryname\")`: Styles all files in the indicated directory\n+in the first argument.\n+\n+Let's try the `styler::style_file()` function out. Inside a file called\n+`non-styled-code.R`, it has:\n+\n+```{r r-repro-non-styled-code, eval=FALSE}\n+# Spacing\n+x[,1]\n+mean (x, na.rm = TRUE)\n+function (x) {}\n+height<-feet*12+inches\n+sqrt(x ^ 2 + y ^ 2)\n+df $ z\n+x <- 1 : 10\n+\n+# Indenting\n+if (y < 0 && debug)\n+message(\"Y is negative\")\n+```\n+\n+Then we run:\n+\n+```{r r-repro-use-styler-file, eval=FALSE}\n+styler::style_file(\"testing-styler.R\")\n+```\n+\n+```\n+Styling 1 files:\n+ testing-styler.R โน \n+โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ\n+Status\tCount\tLegend \n+โ \t0\tFile unchanged.\n+โน \t1\tFile changed.\n+โ \t0\tStyling threw an error.\n+โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ\n+Please review the changes carefully!\n+```\n+\n+Which changes the file to be styled!\n+\n+```{r r-repro-styled-code, eval=FALSE}\n+# Spacing\n+x[, 1]\n+mean(x, na.rm = TRUE)\n+function(x) {}\n+height <- feet * 12 + inches\n+sqrt(x^2 + y^2)\n+df$ z\n+x <- 1:10\n+\n+# Indenting\n+if (y < 0 && debug) {\n+ message(\"Y is negative\")\n+}\n+```\n+\n+This is more or less everything that the styler package does.\n+\n+### Exercise: Use styler to fix code formatting\n+\n+Use the styler package function on the code from the previous exercise by either\n+running `styler::style_file()` or with the `\"Style selection\"` addin when\n+highlighting the code.\n+\n+## Integrating text, code, and results\n+\n+The most obvious demonstration of reproducibility is when the results obtained\n+from executing the analysis code (by an independent entity) are indentical to\n+the results presented in the scientific output such as in an article. When there\n+is agreement between these two, reproducibility has been more or less acheived.\n+In R, there are tools available to *completely* ensure that this happens by\n+directly inserting the results from the code *into the scientific ouput*. This is\n+done by using [R Markdown][r-markdown], which interweaves R code with text.\n+So instead of, for example, manually inserting a figure, you write R code within\n+the document to insert the figure for you! Using [R Markdown][r-markdown] can\n+save so much time and get your work that much closer to being reproducible.\n+\n+There are many other advantages to using R Markdown. From the single R Markdown\n+format you can use it to create manuscripts, posters, slides, websites, books,\n+and many more from simply using R Markdown! In fact, this book was written using\n+R Markdown! As a bonus, switching between citation formats or Word templates for\n+different journals is easier than doing it with Word.\n+\n+### Markdown\n+\n+R Markdown uses, well, [Markdown][markdown] as the format to convert to multiple\n+document types. Fun fact: This website is built based on Markdown! While there\n+are many \"flavours\" of Markdown that have been developed over the years, R\n+Markdown uses the [Pandoc][pandoc-markdown] version. Pandoc is a combination of\n+pan which is Latin for \"all\" and doc which means document.\n+\n+Markdown is a \"markup language\" (like HTML, but simpler) meaning that special\n+characters mean certain things, which we will cover below. \n+\n+To format text, such as to bold or make a list, you use the special characters.\n+You write Markdown as plain text (like R code), so you don't need any special\n+software (like you do with Word documents). Most features needed for writing a\n+scientific document are available in Markdown, but not all. *Tip*: Try to fit\n+your writing and document creation around what Markdown can acheive, rather\n+than force or fight Markdown to do something it wasn't designed to do.\n+\n+Alright, let's create and save an R Markdown file. In RStudio, go to `File ->","path":"r-reproducibility.Rmd","position":null,"original_position":597,"commit_id":"bf689aab2a2a3a186e66b4e89577b0c447331b26","original_commit_id":"6a5eb4eacb91bda4c2068c146b16eaa93c60c184","user":{"login":"lwjohnst86","id":6662983,"node_id":"MDQ6VXNlcjY2NjI5ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6662983?v=4","gravatar_id":"","url":"https://api.github.com/users/lwjohnst86","html_url":"https://github.com/lwjohnst86","followers_url":"https://api.github.com/users/lwjohnst86/followers","following_url":"https://api.github.com/users/lwjohnst86/following{/other_user}","gists_url":"https://api.github.com/users/lwjohnst86/gists{/gist_id}","starred_url":"https://api.github.com/users/lwjohnst86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwjohnst86/subscriptions","organizations_url":"https://api.github.com/users/lwjohnst86/orgs","repos_url":"https://api.github.com/users/lwjohnst86/repos","events_url":"https://api.github.com/users/lwjohnst86/events{/privacy}","received_events_url":"https://api.github.com/users/lwjohnst86/received_events","type":"User","site_admin":false},"body":"Hmm, didn't know this wasn't an \"accepted\" word, but google says no... fixed.","created_at":"2019-07-08T14:37:18Z","updated_at":"2019-07-08T14:53:59Z","html_url":"https://github.com/merely-useful/merely-useful.github.io/pull/100#discussion_r301129418","pull_request_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/comments/301129418"},"html":{"href":"https://github.com/merely-useful/merely-useful.github.io/pull/100#discussion_r301129418"},"pull_request":{"href":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/100"}},"in_reply_to_id":300461658},"pull_request":{"url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/100","id":284558634,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0NTU4NjM0","html_url":"https://github.com/merely-useful/merely-useful.github.io/pull/100","diff_url":"https://github.com/merely-useful/merely-useful.github.io/pull/100.diff","patch_url":"https://github.com/merely-useful/merely-useful.github.io/pull/100.patch","issue_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/issues/100","number":100,"state":"open","locked":false,"title":"Novice R reproducibility chapter","user":{"login":"lwjohnst86","id":6662983,"node_id":"MDQ6VXNlcjY2NjI5ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6662983?v=4","gravatar_id":"","url":"https://api.github.com/users/lwjohnst86","html_url":"https://github.com/lwjohnst86","followers_url":"https://api.github.com/users/lwjohnst86/followers","following_url":"https://api.github.com/users/lwjohnst86/following{/other_user}","gists_url":"https://api.github.com/users/lwjohnst86/gists{/gist_id}","starred_url":"https://api.github.com/users/lwjohnst86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwjohnst86/subscriptions","organizations_url":"https://api.github.com/users/lwjohnst86/orgs","repos_url":"https://api.github.com/users/lwjohnst86/repos","events_url":"https://api.github.com/users/lwjohnst86/events{/privacy}","received_events_url":"https://api.github.com/users/lwjohnst86/received_events","type":"User","site_admin":false},"body":"Should fix #94 \r\n\r\nStarted creating material. Mostly copied over from [my other material](https://rqawr-course.lwjohnst.com/).\r\n","created_at":"2019-06-03T13:13:21Z","updated_at":"2019-07-08T14:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd5ea0161b4c33b9082b95b84b646dd621be078a","assignee":{"login":"gvwilson","id":911566,"node_id":"MDQ6VXNlcjkxMTU2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/911566?v=4","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"assignees":[{"login":"gvwilson","id":911566,"node_id":"MDQ6VXNlcjkxMTU2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/911566?v=4","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},{"login":"lwjohnst86","id":6662983,"node_id":"MDQ6VXNlcjY2NjI5ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6662983?v=4","gravatar_id":"","url":"https://api.github.com/users/lwjohnst86","html_url":"https://github.com/lwjohnst86","followers_url":"https://api.github.com/users/lwjohnst86/followers","following_url":"https://api.github.com/users/lwjohnst86/following{/other_user}","gists_url":"https://api.github.com/users/lwjohnst86/gists{/gist_id}","starred_url":"https://api.github.com/users/lwjohnst86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwjohnst86/subscriptions","organizations_url":"https://api.github.com/users/lwjohnst86/orgs","repos_url":"https://api.github.com/users/lwjohnst86/repos","events_url":"https://api.github.com/users/lwjohnst86/events{/privacy}","received_events_url":"https://api.github.com/users/lwjohnst86/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1347470936,"node_id":"MDU6TGFiZWwxMzQ3NDcwOTM2","url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/labels/Novice%20R","name":"Novice R","color":"d68f24","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/100/commits","review_comments_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/100/comments","review_comment_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/issues/100/comments","statuses_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/statuses/bf689aab2a2a3a186e66b4e89577b0c447331b26","head":{"label":"lwjohnst86:r-reproducibility","ref":"r-reproducibility","sha":"bf689aab2a2a3a186e66b4e89577b0c447331b26","user":{"login":"lwjohnst86","id":6662983,"node_id":"MDQ6VXNlcjY2NjI5ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6662983?v=4","gravatar_id":"","url":"https://api.github.com/users/lwjohnst86","html_url":"https://github.com/lwjohnst86","followers_url":"https://api.github.com/users/lwjohnst86/followers","following_url":"https://api.github.com/users/lwjohnst86/following{/other_user}","gists_url":"https://api.github.com/users/lwjohnst86/gists{/gist_id}","starred_url":"https://api.github.com/users/lwjohnst86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwjohnst86/subscriptions","organizations_url":"https://api.github.com/users/lwjohnst86/orgs","repos_url":"https://api.github.com/users/lwjohnst86/repos","events_url":"https://api.github.com/users/lwjohnst86/events{/privacy}","received_events_url":"https://api.github.com/users/lwjohnst86/received_events","type":"User","site_admin":false},"repo":{"id":184769092,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ3NjkwOTI=","name":"merely-useful.github.io","full_name":"lwjohnst86/merely-useful.github.io","private":false,"owner":{"login":"lwjohnst86","id":6662983,"node_id":"MDQ6VXNlcjY2NjI5ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6662983?v=4","gravatar_id":"","url":"https://api.github.com/users/lwjohnst86","html_url":"https://github.com/lwjohnst86","followers_url":"https://api.github.com/users/lwjohnst86/followers","following_url":"https://api.github.com/users/lwjohnst86/following{/other_user}","gists_url":"https://api.github.com/users/lwjohnst86/gists{/gist_id}","starred_url":"https://api.github.com/users/lwjohnst86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwjohnst86/subscriptions","organizations_url":"https://api.github.com/users/lwjohnst86/orgs","repos_url":"https://api.github.com/users/lwjohnst86/repos","events_url":"https://api.github.com/users/lwjohnst86/events{/privacy}","received_events_url":"https://api.github.com/users/lwjohnst86/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lwjohnst86/merely-useful.github.io","description":"Home page for Merely Useful","fork":true,"url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io","forks_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/forks","keys_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/teams","hooks_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/hooks","issue_events_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/events","assignees_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/tags","blobs_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/languages","stargazers_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/stargazers","contributors_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/contributors","subscribers_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/subscribers","subscription_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/subscription","commits_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/merges","archive_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/downloads","issues_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/labels{/name}","releases_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/lwjohnst86/merely-useful.github.io/deployments","created_at":"2019-05-03T14:26:55Z","updated_at":"2019-07-08T13:45:22Z","pushed_at":"2019-07-08T14:53:53Z","git_url":"git://github.com/lwjohnst86/merely-useful.github.io.git","ssh_url":"[email protected]:lwjohnst86/merely-useful.github.io.git","clone_url":"https://github.com/lwjohnst86/merely-useful.github.io.git","svn_url":"https://github.com/lwjohnst86/merely-useful.github.io","homepage":"https://merely-useful.github.io/","size":15531,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"book"}},"base":{"label":"merely-useful:book","ref":"book","sha":"07f01a867a297361e9968b4016698ce6a281c381","user":{"login":"merely-useful","id":42255088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjU1MDg4","avatar_url":"https://avatars0.githubusercontent.com/u/42255088?v=4","gravatar_id":"","url":"https://api.github.com/users/merely-useful","html_url":"https://github.com/merely-useful","followers_url":"https://api.github.com/users/merely-useful/followers","following_url":"https://api.github.com/users/merely-useful/following{/other_user}","gists_url":"https://api.github.com/users/merely-useful/gists{/gist_id}","starred_url":"https://api.github.com/users/merely-useful/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merely-useful/subscriptions","organizations_url":"https://api.github.com/users/merely-useful/orgs","repos_url":"https://api.github.com/users/merely-useful/repos","events_url":"https://api.github.com/users/merely-useful/events{/privacy}","received_events_url":"https://api.github.com/users/merely-useful/received_events","type":"Organization","site_admin":false},"repo":{"id":144218444,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyMTg0NDQ=","name":"merely-useful.github.io","full_name":"merely-useful/merely-useful.github.io","private":false,"owner":{"login":"merely-useful","id":42255088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjU1MDg4","avatar_url":"https://avatars0.githubusercontent.com/u/42255088?v=4","gravatar_id":"","url":"https://api.github.com/users/merely-useful","html_url":"https://github.com/merely-useful","followers_url":"https://api.github.com/users/merely-useful/followers","following_url":"https://api.github.com/users/merely-useful/following{/other_user}","gists_url":"https://api.github.com/users/merely-useful/gists{/gist_id}","starred_url":"https://api.github.com/users/merely-useful/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merely-useful/subscriptions","organizations_url":"https://api.github.com/users/merely-useful/orgs","repos_url":"https://api.github.com/users/merely-useful/repos","events_url":"https://api.github.com/users/merely-useful/events{/privacy}","received_events_url":"https://api.github.com/users/merely-useful/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/merely-useful/merely-useful.github.io","description":"Home page for Merely Useful","fork":false,"url":"https://api.github.com/repos/merely-useful/merely-useful.github.io","forks_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/forks","keys_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/teams","hooks_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/hooks","issue_events_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/events","assignees_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/tags","blobs_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/languages","stargazers_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/stargazers","contributors_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/contributors","subscribers_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/subscribers","subscription_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/subscription","commits_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/merges","archive_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/downloads","issues_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/labels{/name}","releases_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/merely-useful/merely-useful.github.io/deployments","created_at":"2018-08-10T00:52:26Z","updated_at":"2019-07-08T04:09:03Z","pushed_at":"2019-07-08T14:53:55Z","git_url":"git://github.com/merely-useful/merely-useful.github.io.git","ssh_url":"[email protected]:merely-useful/merely-useful.github.io.git","clone_url":"https://github.com/merely-useful/merely-useful.github.io.git","svn_url":"https://github.com/merely-useful/merely-useful.github.io","homepage":"https://merely-useful.github.io/","size":17207,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":55,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":55,"watchers":6,"default_branch":"book"}},"_links":{"self":{"href":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/100"},"html":{"href":"https://github.com/merely-useful/merely-useful.github.io/pull/100"},"issue":{"href":"https://api.github.com/repos/merely-useful/merely-useful.github.io/issues/100"},"comments":{"href":"https://api.github.com/repos/merely-useful/merely-useful.github.io/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/merely-useful/merely-useful.github.io/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/merely-useful/merely-useful.github.io/statuses/bf689aab2a2a3a186e66b4e89577b0c447331b26"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 144218444,
"name": "merely-useful/merely-useful.github.io",
"url": "https://api.github.com/repos/merely-useful/merely-useful.github.io"
}
|
{
"id": 6662983,
"login": "lwjohnst86",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6662983?",
"url": "https://api.github.com/users/lwjohnst86"
}
|
{
"id": 42255088,
"login": "merely-useful",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42255088?",
"url": "https://api.github.com/orgs/merely-useful"
}
| 2019-07-08T14:37:18 |
9968094712
|
{"actor":{"display_login":"lwjohnst86"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dexidp/dex/pulls/comments/253262962","pull_request_review_id":199344574,"id":253262962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzI2Mjk2Mg==","diff_hunk":"@@ -998,6 +1023,84 @@ func (s *Server) writeAccessToken(w http.ResponseWriter, idToken, accessToken, r\n \tw.Write(data)\n }\n \n+// Handler for the /userinfo endpoint\n+func (s *Server) handleUserInfo(w http.ResponseWriter, r *http.Request) {\n+\n+\ttoken := \"\"\n+\tif r.Header.Get(\"Authorization\") != \"\" {\n+\t\t// Extract token type and token value from Authorization header\n+\t\tauthorizationSubstrs := strings.Split(r.Header.Get(\"Authorization\"), \" \")\n+\t\ttoken = authorizationSubstrs[1]\n+\t} else if r.URL.Query().Get(\"access_token\") != \"\" {\n+\t\ttoken = r.URL.Query().Get(\"access_token\")\n+\t} else {\n+\t\ts.logger.Error(\"No token found\")\n+\t\treturn\n+\t}\n+\n+\tdecryptedToken, err := s.Decrypt(token)\n+\tif err != nil {\n+\t\ts.logger.Errorf(\"Internal server error: %v\", err)\n+\t\ts.renderError(w, http.StatusInternalServerError, \"Internal server error.\")\n+\t\treturn\n+\t}\n+\n+\taccessToken := new(internal.AccessToken)\n+\tif err := internal.Unmarshal(decryptedToken, accessToken); err != nil {\n+\t\ts.logger.Errorf(\"Failed to unmarshal access token: %v\", err)\n+\t}\n+\n+\t// Find the connector used in this auth flow\n+\tconn, err := s.getConnector(accessToken.ConnectorId)\n+\n+\tif err != nil {","path":"server/handlers.go","position":105,"original_position":105,"commit_id":"c0b256a7682a3e7f22ba84d5a15513638cf8e0d0","original_commit_id":"c0b256a7682a3e7f22ba84d5a15513638cf8e0d0","user":{"login":"JoelSpeed","id":9232216,"node_id":"MDQ6VXNlcjkyMzIyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/9232216?v=4","gravatar_id":"","url":"https://api.github.com/users/JoelSpeed","html_url":"https://github.com/JoelSpeed","followers_url":"https://api.github.com/users/JoelSpeed/followers","following_url":"https://api.github.com/users/JoelSpeed/following{/other_user}","gists_url":"https://api.github.com/users/JoelSpeed/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelSpeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelSpeed/subscriptions","organizations_url":"https://api.github.com/users/JoelSpeed/orgs","repos_url":"https://api.github.com/users/JoelSpeed/repos","events_url":"https://api.github.com/users/JoelSpeed/events{/privacy}","received_events_url":"https://api.github.com/users/JoelSpeed/received_events","type":"User","site_admin":false},"body":"Nit: as above I would expect no new line between `conn, err := ` and `if err != nil`","created_at":"2019-02-02T11:34:03Z","updated_at":"2019-02-02T11:52:30Z","html_url":"https://github.com/dexidp/dex/pull/1315#discussion_r253262962","pull_request_url":"https://api.github.com/repos/dexidp/dex/pulls/1315","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dexidp/dex/pulls/comments/253262962"},"html":{"href":"https://github.com/dexidp/dex/pull/1315#discussion_r253262962"},"pull_request":{"href":"https://api.github.com/repos/dexidp/dex/pulls/1315"}}},"pull_request":{"url":"https://api.github.com/repos/dexidp/dex/pulls/1315","id":222618477,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjE4NDc3","html_url":"https://github.com/dexidp/dex/pull/1315","diff_url":"https://github.com/dexidp/dex/pull/1315.diff","patch_url":"https://github.com/dexidp/dex/pull/1315.patch","issue_url":"https://api.github.com/repos/dexidp/dex/issues/1315","number":1315,"state":"open","locked":false,"title":"Added User Info endpoint (#1133)","user":{"login":"kalinon","id":5629164,"node_id":"MDQ6VXNlcjU2MjkxNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5629164?v=4","gravatar_id":"","url":"https://api.github.com/users/kalinon","html_url":"https://github.com/kalinon","followers_url":"https://api.github.com/users/kalinon/followers","following_url":"https://api.github.com/users/kalinon/following{/other_user}","gists_url":"https://api.github.com/users/kalinon/gists{/gist_id}","starred_url":"https://api.github.com/users/kalinon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalinon/subscriptions","organizations_url":"https://api.github.com/users/kalinon/orgs","repos_url":"https://api.github.com/users/kalinon/repos","events_url":"https://api.github.com/users/kalinon/events{/privacy}","received_events_url":"https://api.github.com/users/kalinon/received_events","type":"User","site_admin":false},"body":"Resolved merge conflicts for #1133","created_at":"2018-10-13T01:16:34Z","updated_at":"2019-02-02T11:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e209d60e5323bd928b3c7692c31428d3fc20888f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dexidp/dex/pulls/1315/commits","review_comments_url":"https://api.github.com/repos/dexidp/dex/pulls/1315/comments","review_comment_url":"https://api.github.com/repos/dexidp/dex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dexidp/dex/issues/1315/comments","statuses_url":"https://api.github.com/repos/dexidp/dex/statuses/c0b256a7682a3e7f22ba84d5a15513638cf8e0d0","head":{"label":"optanix:master","ref":"master","sha":"c0b256a7682a3e7f22ba84d5a15513638cf8e0d0","user":{"login":"optanix","id":36477160,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDc3MTYw","avatar_url":"https://avatars0.githubusercontent.com/u/36477160?v=4","gravatar_id":"","url":"https://api.github.com/users/optanix","html_url":"https://github.com/optanix","followers_url":"https://api.github.com/users/optanix/followers","following_url":"https://api.github.com/users/optanix/following{/other_user}","gists_url":"https://api.github.com/users/optanix/gists{/gist_id}","starred_url":"https://api.github.com/users/optanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optanix/subscriptions","organizations_url":"https://api.github.com/users/optanix/orgs","repos_url":"https://api.github.com/users/optanix/repos","events_url":"https://api.github.com/users/optanix/events{/privacy}","received_events_url":"https://api.github.com/users/optanix/received_events","type":"Organization","site_admin":false},"repo":{"id":151129870,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMjk4NzA=","name":"dex","full_name":"optanix/dex","private":false,"owner":{"login":"optanix","id":36477160,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDc3MTYw","avatar_url":"https://avatars0.githubusercontent.com/u/36477160?v=4","gravatar_id":"","url":"https://api.github.com/users/optanix","html_url":"https://github.com/optanix","followers_url":"https://api.github.com/users/optanix/followers","following_url":"https://api.github.com/users/optanix/following{/other_user}","gists_url":"https://api.github.com/users/optanix/gists{/gist_id}","starred_url":"https://api.github.com/users/optanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optanix/subscriptions","organizations_url":"https://api.github.com/users/optanix/orgs","repos_url":"https://api.github.com/users/optanix/repos","events_url":"https://api.github.com/users/optanix/events{/privacy}","received_events_url":"https://api.github.com/users/optanix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/optanix/dex","description":"OpenID Connect Identity (OIDC) and OAuth 2.0 Provider with Pluggable Connectors","fork":true,"url":"https://api.github.com/repos/optanix/dex","forks_url":"https://api.github.com/repos/optanix/dex/forks","keys_url":"https://api.github.com/repos/optanix/dex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optanix/dex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optanix/dex/teams","hooks_url":"https://api.github.com/repos/optanix/dex/hooks","issue_events_url":"https://api.github.com/repos/optanix/dex/issues/events{/number}","events_url":"https://api.github.com/repos/optanix/dex/events","assignees_url":"https://api.github.com/repos/optanix/dex/assignees{/user}","branches_url":"https://api.github.com/repos/optanix/dex/branches{/branch}","tags_url":"https://api.github.com/repos/optanix/dex/tags","blobs_url":"https://api.github.com/repos/optanix/dex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optanix/dex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optanix/dex/git/refs{/sha}","trees_url":"https://api.github.com/repos/optanix/dex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optanix/dex/statuses/{sha}","languages_url":"https://api.github.com/repos/optanix/dex/languages","stargazers_url":"https://api.github.com/repos/optanix/dex/stargazers","contributors_url":"https://api.github.com/repos/optanix/dex/contributors","subscribers_url":"https://api.github.com/repos/optanix/dex/subscribers","subscription_url":"https://api.github.com/repos/optanix/dex/subscription","commits_url":"https://api.github.com/repos/optanix/dex/commits{/sha}","git_commits_url":"https://api.github.com/repos/optanix/dex/git/commits{/sha}","comments_url":"https://api.github.com/repos/optanix/dex/comments{/number}","issue_comment_url":"https://api.github.com/repos/optanix/dex/issues/comments{/number}","contents_url":"https://api.github.com/repos/optanix/dex/contents/{+path}","compare_url":"https://api.github.com/repos/optanix/dex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optanix/dex/merges","archive_url":"https://api.github.com/repos/optanix/dex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optanix/dex/downloads","issues_url":"https://api.github.com/repos/optanix/dex/issues{/number}","pulls_url":"https://api.github.com/repos/optanix/dex/pulls{/number}","milestones_url":"https://api.github.com/repos/optanix/dex/milestones{/number}","notifications_url":"https://api.github.com/repos/optanix/dex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optanix/dex/labels{/name}","releases_url":"https://api.github.com/repos/optanix/dex/releases{/id}","deployments_url":"https://api.github.com/repos/optanix/dex/deployments","created_at":"2018-10-01T17:35:02Z","updated_at":"2018-10-01T18:24:30Z","pushed_at":"2018-10-01T18:24:27Z","git_url":"git://github.com/optanix/dex.git","ssh_url":"[email protected]:optanix/dex.git","clone_url":"https://github.com/optanix/dex.git","svn_url":"https://github.com/optanix/dex","homepage":"https://coreos.com/blog/announcing-dex.html","size":14203,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dexidp:master","ref":"master","sha":"e1acb6d577111af69dd919712a70f3e952205fce","user":{"login":"dexidp","id":42422344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDIyMzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/42422344?v=4","gravatar_id":"","url":"https://api.github.com/users/dexidp","html_url":"https://github.com/dexidp","followers_url":"https://api.github.com/users/dexidp/followers","following_url":"https://api.github.com/users/dexidp/following{/other_user}","gists_url":"https://api.github.com/users/dexidp/gists{/gist_id}","starred_url":"https://api.github.com/users/dexidp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexidp/subscriptions","organizations_url":"https://api.github.com/users/dexidp/orgs","repos_url":"https://api.github.com/users/dexidp/repos","events_url":"https://api.github.com/users/dexidp/events{/privacy}","received_events_url":"https://api.github.com/users/dexidp/received_events","type":"Organization","site_admin":false},"repo":{"id":40916314,"node_id":"MDEwOlJlcG9zaXRvcnk0MDkxNjMxNA==","name":"dex","full_name":"dexidp/dex","private":false,"owner":{"login":"dexidp","id":42422344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDIyMzQ0","avatar_url":"https://avatars0.githubusercontent.com/u/42422344?v=4","gravatar_id":"","url":"https://api.github.com/users/dexidp","html_url":"https://github.com/dexidp","followers_url":"https://api.github.com/users/dexidp/followers","following_url":"https://api.github.com/users/dexidp/following{/other_user}","gists_url":"https://api.github.com/users/dexidp/gists{/gist_id}","starred_url":"https://api.github.com/users/dexidp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexidp/subscriptions","organizations_url":"https://api.github.com/users/dexidp/orgs","repos_url":"https://api.github.com/users/dexidp/repos","events_url":"https://api.github.com/users/dexidp/events{/privacy}","received_events_url":"https://api.github.com/users/dexidp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dexidp/dex","description":"OpenID Connect Identity (OIDC) and OAuth 2.0 Provider with Pluggable Connectors","fork":false,"url":"https://api.github.com/repos/dexidp/dex","forks_url":"https://api.github.com/repos/dexidp/dex/forks","keys_url":"https://api.github.com/repos/dexidp/dex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dexidp/dex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dexidp/dex/teams","hooks_url":"https://api.github.com/repos/dexidp/dex/hooks","issue_events_url":"https://api.github.com/repos/dexidp/dex/issues/events{/number}","events_url":"https://api.github.com/repos/dexidp/dex/events","assignees_url":"https://api.github.com/repos/dexidp/dex/assignees{/user}","branches_url":"https://api.github.com/repos/dexidp/dex/branches{/branch}","tags_url":"https://api.github.com/repos/dexidp/dex/tags","blobs_url":"https://api.github.com/repos/dexidp/dex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dexidp/dex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dexidp/dex/git/refs{/sha}","trees_url":"https://api.github.com/repos/dexidp/dex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dexidp/dex/statuses/{sha}","languages_url":"https://api.github.com/repos/dexidp/dex/languages","stargazers_url":"https://api.github.com/repos/dexidp/dex/stargazers","contributors_url":"https://api.github.com/repos/dexidp/dex/contributors","subscribers_url":"https://api.github.com/repos/dexidp/dex/subscribers","subscription_url":"https://api.github.com/repos/dexidp/dex/subscription","commits_url":"https://api.github.com/repos/dexidp/dex/commits{/sha}","git_commits_url":"https://api.github.com/repos/dexidp/dex/git/commits{/sha}","comments_url":"https://api.github.com/repos/dexidp/dex/comments{/number}","issue_comment_url":"https://api.github.com/repos/dexidp/dex/issues/comments{/number}","contents_url":"https://api.github.com/repos/dexidp/dex/contents/{+path}","compare_url":"https://api.github.com/repos/dexidp/dex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dexidp/dex/merges","archive_url":"https://api.github.com/repos/dexidp/dex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dexidp/dex/downloads","issues_url":"https://api.github.com/repos/dexidp/dex/issues{/number}","pulls_url":"https://api.github.com/repos/dexidp/dex/pulls{/number}","milestones_url":"https://api.github.com/repos/dexidp/dex/milestones{/number}","notifications_url":"https://api.github.com/repos/dexidp/dex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dexidp/dex/labels{/name}","releases_url":"https://api.github.com/repos/dexidp/dex/releases{/id}","deployments_url":"https://api.github.com/repos/dexidp/dex/deployments","created_at":"2015-08-17T17:57:06Z","updated_at":"2019-02-01T16:15:06Z","pushed_at":"2019-02-01T11:47:57Z","git_url":"git://github.com/dexidp/dex.git","ssh_url":"[email protected]:dexidp/dex.git","clone_url":"https://github.com/dexidp/dex.git","svn_url":"https://github.com/dexidp/dex","homepage":"","size":14525,"stargazers_count":2922,"watchers_count":2922,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":610,"mirror_url":null,"archived":false,"open_issues_count":169,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":610,"open_issues":169,"watchers":2922,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dexidp/dex/pulls/1315"},"html":{"href":"https://github.com/dexidp/dex/pull/1315"},"issue":{"href":"https://api.github.com/repos/dexidp/dex/issues/1315"},"comments":{"href":"https://api.github.com/repos/dexidp/dex/issues/1315/comments"},"review_comments":{"href":"https://api.github.com/repos/dexidp/dex/pulls/1315/comments"},"review_comment":{"href":"https://api.github.com/repos/dexidp/dex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dexidp/dex/pulls/1315/commits"},"statuses":{"href":"https://api.github.com/repos/dexidp/dex/statuses/c0b256a7682a3e7f22ba84d5a15513638cf8e0d0"}},"author_association":"NONE"}}
|
{
"id": 40916314,
"name": "dexidp/dex",
"url": "https://api.github.com/repos/dexidp/dex"
}
|
{
"id": 9232216,
"login": "JoelSpeed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9232216?",
"url": "https://api.github.com/users/JoelSpeed"
}
|
{
"id": 42422344,
"login": "dexidp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42422344?",
"url": "https://api.github.com/orgs/dexidp"
}
| 2019-02-02T11:34:03 |
8997398940
|
{"actor":{"display_login":"JoelSpeed"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/comments/254689180","pull_request_review_id":201095287,"id":254689180,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDY4OTE4MA==","diff_hunk":"@@ -0,0 +1,57 @@\n+<?php\n+\n+use app\\components\\Converter;\n+use app\\models\\Rating;","path":"views/user/view.php","position":4,"original_position":4,"commit_id":"ebd155f8e9814f6785e4832fe3703b9d02e7384b","original_commit_id":"ebd155f8e9814f6785e4832fe3703b9d02e7384b","user":{"login":"codeclimate[bot]","id":36754821,"node_id":"MDM6Qm90MzY3NTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/in/9403?v=4","gravatar_id":"","url":"https://api.github.com/users/codeclimate%5Bbot%5D","html_url":"https://github.com/apps/codeclimate","followers_url":"https://api.github.com/users/codeclimate%5Bbot%5D/followers","following_url":"https://api.github.com/users/codeclimate%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codeclimate%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codeclimate%5Bbot%5D/repos","events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Possibly zero references to use statement for classlike/namespace `Rating` `(\\app\\models\\Rating)`","created_at":"2019-02-07T13:51:58Z","updated_at":"2019-02-07T13:51:59Z","html_url":"https://github.com/opensourcewebsite-org/opensourcewebsite-org/pull/157#discussion_r254689180","pull_request_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/157","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/comments/254689180"},"html":{"href":"https://github.com/opensourcewebsite-org/opensourcewebsite-org/pull/157#discussion_r254689180"},"pull_request":{"href":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/157"}}},"pull_request":{"url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/157","id":251115135,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxMTE1MTM1","html_url":"https://github.com/opensourcewebsite-org/opensourcewebsite-org/pull/157","diff_url":"https://github.com/opensourcewebsite-org/opensourcewebsite-org/pull/157.diff","patch_url":"https://github.com/opensourcewebsite-org/opensourcewebsite-org/pull/157.patch","issue_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/issues/157","number":157,"state":"open","locked":false,"title":"changes for username","user":{"login":"paramsura","id":47420950,"node_id":"MDQ6VXNlcjQ3NDIwOTUw","avatar_url":"https://avatars0.githubusercontent.com/u/47420950?v=4","gravatar_id":"","url":"https://api.github.com/users/paramsura","html_url":"https://github.com/paramsura","followers_url":"https://api.github.com/users/paramsura/followers","following_url":"https://api.github.com/users/paramsura/following{/other_user}","gists_url":"https://api.github.com/users/paramsura/gists{/gist_id}","starred_url":"https://api.github.com/users/paramsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramsura/subscriptions","organizations_url":"https://api.github.com/users/paramsura/orgs","repos_url":"https://api.github.com/users/paramsura/repos","events_url":"https://api.github.com/users/paramsura/events{/privacy}","received_events_url":"https://api.github.com/users/paramsura/received_events","type":"User","site_admin":false},"body":"first commit for the username changes.","created_at":"2019-02-07T13:30:31Z","updated_at":"2019-02-07T13:51:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dcca278b07b1763de03acf48137a2f84c658d87","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/157/commits","review_comments_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/157/comments","review_comment_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/issues/157/comments","statuses_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/statuses/ebd155f8e9814f6785e4832fe3703b9d02e7384b","head":{"label":"paramsura:master","ref":"master","sha":"ebd155f8e9814f6785e4832fe3703b9d02e7384b","user":{"login":"paramsura","id":47420950,"node_id":"MDQ6VXNlcjQ3NDIwOTUw","avatar_url":"https://avatars0.githubusercontent.com/u/47420950?v=4","gravatar_id":"","url":"https://api.github.com/users/paramsura","html_url":"https://github.com/paramsura","followers_url":"https://api.github.com/users/paramsura/followers","following_url":"https://api.github.com/users/paramsura/following{/other_user}","gists_url":"https://api.github.com/users/paramsura/gists{/gist_id}","starred_url":"https://api.github.com/users/paramsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramsura/subscriptions","organizations_url":"https://api.github.com/users/paramsura/orgs","repos_url":"https://api.github.com/users/paramsura/repos","events_url":"https://api.github.com/users/paramsura/events{/privacy}","received_events_url":"https://api.github.com/users/paramsura/received_events","type":"User","site_admin":false},"repo":{"id":169575736,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk1NzU3MzY=","name":"opensourcewebsite-org","full_name":"paramsura/opensourcewebsite-org","private":false,"owner":{"login":"paramsura","id":47420950,"node_id":"MDQ6VXNlcjQ3NDIwOTUw","avatar_url":"https://avatars0.githubusercontent.com/u/47420950?v=4","gravatar_id":"","url":"https://api.github.com/users/paramsura","html_url":"https://github.com/paramsura","followers_url":"https://api.github.com/users/paramsura/followers","following_url":"https://api.github.com/users/paramsura/following{/other_user}","gists_url":"https://api.github.com/users/paramsura/gists{/gist_id}","starred_url":"https://api.github.com/users/paramsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramsura/subscriptions","organizations_url":"https://api.github.com/users/paramsura/orgs","repos_url":"https://api.github.com/users/paramsura/repos","events_url":"https://api.github.com/users/paramsura/events{/privacy}","received_events_url":"https://api.github.com/users/paramsura/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paramsura/opensourcewebsite-org","description":"OpenSourceWebsite (OSW) is an open source website for the world's largest online social community, and is available for free on Live Website (https://opensourcewebsite.org).","fork":true,"url":"https://api.github.com/repos/paramsura/opensourcewebsite-org","forks_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/forks","keys_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/teams","hooks_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/hooks","issue_events_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/issues/events{/number}","events_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/events","assignees_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/assignees{/user}","branches_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/branches{/branch}","tags_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/tags","blobs_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/statuses/{sha}","languages_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/languages","stargazers_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/stargazers","contributors_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/contributors","subscribers_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/subscribers","subscription_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/subscription","commits_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/contents/{+path}","compare_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/merges","archive_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/downloads","issues_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/issues{/number}","pulls_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/pulls{/number}","milestones_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/milestones{/number}","notifications_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/labels{/name}","releases_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/releases{/id}","deployments_url":"https://api.github.com/repos/paramsura/opensourcewebsite-org/deployments","created_at":"2019-02-07T13:26:40Z","updated_at":"2019-02-07T13:50:03Z","pushed_at":"2019-02-07T13:50:01Z","git_url":"git://github.com/paramsura/opensourcewebsite-org.git","ssh_url":"[email protected]:paramsura/opensourcewebsite-org.git","clone_url":"https://github.com/paramsura/opensourcewebsite-org.git","svn_url":"https://github.com/paramsura/opensourcewebsite-org","homepage":null,"size":593,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opensourcewebsite-org:master","ref":"master","sha":"72fdbcaef519d1384fd7d0f10b8209630cc126eb","user":{"login":"opensourcewebsite-org","id":42433667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMzNjY3","avatar_url":"https://avatars1.githubusercontent.com/u/42433667?v=4","gravatar_id":"","url":"https://api.github.com/users/opensourcewebsite-org","html_url":"https://github.com/opensourcewebsite-org","followers_url":"https://api.github.com/users/opensourcewebsite-org/followers","following_url":"https://api.github.com/users/opensourcewebsite-org/following{/other_user}","gists_url":"https://api.github.com/users/opensourcewebsite-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensourcewebsite-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensourcewebsite-org/subscriptions","organizations_url":"https://api.github.com/users/opensourcewebsite-org/orgs","repos_url":"https://api.github.com/users/opensourcewebsite-org/repos","events_url":"https://api.github.com/users/opensourcewebsite-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensourcewebsite-org/received_events","type":"Organization","site_admin":false},"repo":{"id":144956786,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5NTY3ODY=","name":"opensourcewebsite-org","full_name":"opensourcewebsite-org/opensourcewebsite-org","private":false,"owner":{"login":"opensourcewebsite-org","id":42433667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMzNjY3","avatar_url":"https://avatars1.githubusercontent.com/u/42433667?v=4","gravatar_id":"","url":"https://api.github.com/users/opensourcewebsite-org","html_url":"https://github.com/opensourcewebsite-org","followers_url":"https://api.github.com/users/opensourcewebsite-org/followers","following_url":"https://api.github.com/users/opensourcewebsite-org/following{/other_user}","gists_url":"https://api.github.com/users/opensourcewebsite-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensourcewebsite-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensourcewebsite-org/subscriptions","organizations_url":"https://api.github.com/users/opensourcewebsite-org/orgs","repos_url":"https://api.github.com/users/opensourcewebsite-org/repos","events_url":"https://api.github.com/users/opensourcewebsite-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensourcewebsite-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opensourcewebsite-org/opensourcewebsite-org","description":"OpenSourceWebsite (OSW) is an open source website for the world's largest online social community, and is available for free on Live Website (https://opensourcewebsite.org).","fork":false,"url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org","forks_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/forks","keys_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/teams","hooks_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/hooks","issue_events_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/issues/events{/number}","events_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/events","assignees_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/assignees{/user}","branches_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/branches{/branch}","tags_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/tags","blobs_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/statuses/{sha}","languages_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/languages","stargazers_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/stargazers","contributors_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/contributors","subscribers_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/subscribers","subscription_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/subscription","commits_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/contents/{+path}","compare_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/merges","archive_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/downloads","issues_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/issues{/number}","pulls_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls{/number}","milestones_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/milestones{/number}","notifications_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/labels{/name}","releases_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/releases{/id}","deployments_url":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/deployments","created_at":"2018-08-16T08:04:10Z","updated_at":"2019-02-07T13:51:58Z","pushed_at":"2019-02-07T13:51:56Z","git_url":"git://github.com/opensourcewebsite-org/opensourcewebsite-org.git","ssh_url":"[email protected]:opensourcewebsite-org/opensourcewebsite-org.git","clone_url":"https://github.com/opensourcewebsite-org/opensourcewebsite-org.git","svn_url":"https://github.com/opensourcewebsite-org/opensourcewebsite-org","homepage":null,"size":593,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/157"},"html":{"href":"https://github.com/opensourcewebsite-org/opensourcewebsite-org/pull/157"},"issue":{"href":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/issues/157"},"comments":{"href":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org/statuses/ebd155f8e9814f6785e4832fe3703b9d02e7384b"}},"author_association":"NONE"}}
|
{
"id": 144956786,
"name": "opensourcewebsite-org/opensourcewebsite-org",
"url": "https://api.github.com/repos/opensourcewebsite-org/opensourcewebsite-org"
}
|
{
"id": 36754821,
"login": "codeclimate[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36754821?",
"url": "https://api.github.com/users/codeclimate[bot]"
}
|
{
"id": 42433667,
"login": "opensourcewebsite-org",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42433667?",
"url": "https://api.github.com/orgs/opensourcewebsite-org"
}
| 2019-02-07T13:51:58 |
9025592819
|
{"actor":{"display_login":"codeclimate"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/vesoft-inc/nebula/pulls/comments/361080004","pull_request_review_id":336100018,"id":361080004,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTA4MDAwNA==","diff_hunk":"@@ -153,7 +153,7 @@ class MetaClient {\n getSpace(std::string name);\n \n folly::Future<StatusOr<bool>>\n- dropSpace(std::string name);\n+ dropSpace(std::string name, const bool ifExist = false);","path":"src/meta/client/MetaClient.h","position":5,"original_position":5,"commit_id":"8b3784d52296d9215265b01d128291e30e9a8c78","original_commit_id":"8b3784d52296d9215265b01d128291e30e9a8c78","user":{"login":"monadbobo","id":331435,"node_id":"MDQ6VXNlcjMzMTQzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/331435?v=4","gravatar_id":"","url":"https://api.github.com/users/monadbobo","html_url":"https://github.com/monadbobo","followers_url":"https://api.github.com/users/monadbobo/followers","following_url":"https://api.github.com/users/monadbobo/following{/other_user}","gists_url":"https://api.github.com/users/monadbobo/gists{/gist_id}","starred_url":"https://api.github.com/users/monadbobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monadbobo/subscriptions","organizations_url":"https://api.github.com/users/monadbobo/orgs","repos_url":"https://api.github.com/users/monadbobo/repos","events_url":"https://api.github.com/users/monadbobo/events{/privacy}","received_events_url":"https://api.github.com/users/monadbobo/received_events","type":"User","site_admin":false},"body":"\"const\" doesn't make much sense here.","created_at":"2019-12-24T06:40:13Z","updated_at":"2019-12-24T06:40:47Z","html_url":"https://github.com/vesoft-inc/nebula/pull/1505#discussion_r361080004","pull_request_url":"https://api.github.com/repos/vesoft-inc/nebula/pulls/1505","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vesoft-inc/nebula/pulls/comments/361080004"},"html":{"href":"https://github.com/vesoft-inc/nebula/pull/1505#discussion_r361080004"},"pull_request":{"href":"https://api.github.com/repos/vesoft-inc/nebula/pulls/1505"}}},"pull_request":{"url":"https://api.github.com/repos/vesoft-inc/nebula/pulls/1505","id":356538323,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2NTM4MzIz","html_url":"https://github.com/vesoft-inc/nebula/pull/1505","diff_url":"https://github.com/vesoft-inc/nebula/pull/1505.diff","patch_url":"https://github.com/vesoft-inc/nebula/pull/1505.patch","issue_url":"https://api.github.com/repos/vesoft-inc/nebula/issues/1505","number":1505,"state":"open","locked":false,"title":"Add `IF EXISTS` support when drop schema.","user":{"login":"Shylock-Hg","id":33566796,"node_id":"MDQ6VXNlcjMzNTY2Nzk2","avatar_url":"https://avatars2.githubusercontent.com/u/33566796?v=4","gravatar_id":"","url":"https://api.github.com/users/Shylock-Hg","html_url":"https://github.com/Shylock-Hg","followers_url":"https://api.github.com/users/Shylock-Hg/followers","following_url":"https://api.github.com/users/Shylock-Hg/following{/other_user}","gists_url":"https://api.github.com/users/Shylock-Hg/gists{/gist_id}","starred_url":"https://api.github.com/users/Shylock-Hg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shylock-Hg/subscriptions","organizations_url":"https://api.github.com/users/Shylock-Hg/orgs","repos_url":"https://api.github.com/users/Shylock-Hg/repos","events_url":"https://api.github.com/users/Shylock-Hg/events{/privacy}","received_events_url":"https://api.github.com/users/Shylock-Hg/received_events","type":"User","site_admin":false},"body":"### What changes were proposed in this pull request?\r\n#1461 \r\n\r\n\r\n### Why are the changes needed?\r\nAdd `IF EXISTS` to drop space/tag/edge.\r\n\r\n\r\n### Does this PR introduce any user-facing change?\r\nYes.\r\n@Amber1990Zhang Need doc if merged.\r\n\r\n\r\n### How was this patch tested?\r\nUT passed.\r\n","created_at":"2019-12-24T06:36:25Z","updated_at":"2019-12-24T06:40:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"067ba1785db582aeaa9111cd87385d4eaab9779d","assignee":{"login":"Amber1990Zhang","id":42762957,"node_id":"MDQ6VXNlcjQyNzYyOTU3","avatar_url":"https://avatars0.githubusercontent.com/u/42762957?v=4","gravatar_id":"","url":"https://api.github.com/users/Amber1990Zhang","html_url":"https://github.com/Amber1990Zhang","followers_url":"https://api.github.com/users/Amber1990Zhang/followers","following_url":"https://api.github.com/users/Amber1990Zhang/following{/other_user}","gists_url":"https://api.github.com/users/Amber1990Zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/Amber1990Zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amber1990Zhang/subscriptions","organizations_url":"https://api.github.com/users/Amber1990Zhang/orgs","repos_url":"https://api.github.com/users/Amber1990Zhang/repos","events_url":"https://api.github.com/users/Amber1990Zhang/events{/privacy}","received_events_url":"https://api.github.com/users/Amber1990Zhang/received_events","type":"User","site_admin":false},"assignees":[{"login":"Amber1990Zhang","id":42762957,"node_id":"MDQ6VXNlcjQyNzYyOTU3","avatar_url":"https://avatars0.githubusercontent.com/u/42762957?v=4","gravatar_id":"","url":"https://api.github.com/users/Amber1990Zhang","html_url":"https://github.com/Amber1990Zhang","followers_url":"https://api.github.com/users/Amber1990Zhang/followers","following_url":"https://api.github.com/users/Amber1990Zhang/following{/other_user}","gists_url":"https://api.github.com/users/Amber1990Zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/Amber1990Zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amber1990Zhang/subscriptions","organizations_url":"https://api.github.com/users/Amber1990Zhang/orgs","repos_url":"https://api.github.com/users/Amber1990Zhang/repos","events_url":"https://api.github.com/users/Amber1990Zhang/events{/privacy}","received_events_url":"https://api.github.com/users/Amber1990Zhang/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dutor","id":440396,"node_id":"MDQ6VXNlcjQ0MDM5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/440396?v=4","gravatar_id":"","url":"https://api.github.com/users/dutor","html_url":"https://github.com/dutor","followers_url":"https://api.github.com/users/dutor/followers","following_url":"https://api.github.com/users/dutor/following{/other_user}","gists_url":"https://api.github.com/users/dutor/gists{/gist_id}","starred_url":"https://api.github.com/users/dutor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutor/subscriptions","organizations_url":"https://api.github.com/users/dutor/orgs","repos_url":"https://api.github.com/users/dutor/repos","events_url":"https://api.github.com/users/dutor/events{/privacy}","received_events_url":"https://api.github.com/users/dutor/received_events","type":"User","site_admin":false},{"login":"darionyaphet","id":4414314,"node_id":"MDQ6VXNlcjQ0MTQzMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4414314?v=4","gravatar_id":"","url":"https://api.github.com/users/darionyaphet","html_url":"https://github.com/darionyaphet","followers_url":"https://api.github.com/users/darionyaphet/followers","following_url":"https://api.github.com/users/darionyaphet/following{/other_user}","gists_url":"https://api.github.com/users/darionyaphet/gists{/gist_id}","starred_url":"https://api.github.com/users/darionyaphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darionyaphet/subscriptions","organizations_url":"https://api.github.com/users/darionyaphet/orgs","repos_url":"https://api.github.com/users/darionyaphet/repos","events_url":"https://api.github.com/users/darionyaphet/events{/privacy}","received_events_url":"https://api.github.com/users/darionyaphet/received_events","type":"User","site_admin":false},{"login":"CPWstatic","id":13495049,"node_id":"MDQ6VXNlcjEzNDk1MDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/13495049?v=4","gravatar_id":"","url":"https://api.github.com/users/CPWstatic","html_url":"https://github.com/CPWstatic","followers_url":"https://api.github.com/users/CPWstatic/followers","following_url":"https://api.github.com/users/CPWstatic/following{/other_user}","gists_url":"https://api.github.com/users/CPWstatic/gists{/gist_id}","starred_url":"https://api.github.com/users/CPWstatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPWstatic/subscriptions","organizations_url":"https://api.github.com/users/CPWstatic/orgs","repos_url":"https://api.github.com/users/CPWstatic/repos","events_url":"https://api.github.com/users/CPWstatic/events{/privacy}","received_events_url":"https://api.github.com/users/CPWstatic/received_events","type":"User","site_admin":false},{"login":"laura-ding","id":48548375,"node_id":"MDQ6VXNlcjQ4NTQ4Mzc1","avatar_url":"https://avatars2.githubusercontent.com/u/48548375?v=4","gravatar_id":"","url":"https://api.github.com/users/laura-ding","html_url":"https://github.com/laura-ding","followers_url":"https://api.github.com/users/laura-ding/followers","following_url":"https://api.github.com/users/laura-ding/following{/other_user}","gists_url":"https://api.github.com/users/laura-ding/gists{/gist_id}","starred_url":"https://api.github.com/users/laura-ding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laura-ding/subscriptions","organizations_url":"https://api.github.com/users/laura-ding/orgs","repos_url":"https://api.github.com/users/laura-ding/repos","events_url":"https://api.github.com/users/laura-ding/events{/privacy}","received_events_url":"https://api.github.com/users/laura-ding/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1355694328,"node_id":"MDU6TGFiZWwxMzU1Njk0MzI4","url":"https://api.github.com/repos/vesoft-inc/nebula/labels/ready-for-testing","name":"ready-for-testing","color":"006b75","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/vesoft-inc/nebula/pulls/1505/commits","review_comments_url":"https://api.github.com/repos/vesoft-inc/nebula/pulls/1505/comments","review_comment_url":"https://api.github.com/repos/vesoft-inc/nebula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vesoft-inc/nebula/issues/1505/comments","statuses_url":"https://api.github.com/repos/vesoft-inc/nebula/statuses/8b3784d52296d9215265b01d128291e30e9a8c78","head":{"label":"Shylock-Hg:feature/if-exists","ref":"feature/if-exists","sha":"8b3784d52296d9215265b01d128291e30e9a8c78","user":{"login":"Shylock-Hg","id":33566796,"node_id":"MDQ6VXNlcjMzNTY2Nzk2","avatar_url":"https://avatars2.githubusercontent.com/u/33566796?v=4","gravatar_id":"","url":"https://api.github.com/users/Shylock-Hg","html_url":"https://github.com/Shylock-Hg","followers_url":"https://api.github.com/users/Shylock-Hg/followers","following_url":"https://api.github.com/users/Shylock-Hg/following{/other_user}","gists_url":"https://api.github.com/users/Shylock-Hg/gists{/gist_id}","starred_url":"https://api.github.com/users/Shylock-Hg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shylock-Hg/subscriptions","organizations_url":"https://api.github.com/users/Shylock-Hg/orgs","repos_url":"https://api.github.com/users/Shylock-Hg/repos","events_url":"https://api.github.com/users/Shylock-Hg/events{/privacy}","received_events_url":"https://api.github.com/users/Shylock-Hg/received_events","type":"User","site_admin":false},"repo":{"id":204929565,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ5Mjk1NjU=","name":"nebula","full_name":"Shylock-Hg/nebula","private":false,"owner":{"login":"Shylock-Hg","id":33566796,"node_id":"MDQ6VXNlcjMzNTY2Nzk2","avatar_url":"https://avatars2.githubusercontent.com/u/33566796?v=4","gravatar_id":"","url":"https://api.github.com/users/Shylock-Hg","html_url":"https://github.com/Shylock-Hg","followers_url":"https://api.github.com/users/Shylock-Hg/followers","following_url":"https://api.github.com/users/Shylock-Hg/following{/other_user}","gists_url":"https://api.github.com/users/Shylock-Hg/gists{/gist_id}","starred_url":"https://api.github.com/users/Shylock-Hg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shylock-Hg/subscriptions","organizations_url":"https://api.github.com/users/Shylock-Hg/orgs","repos_url":"https://api.github.com/users/Shylock-Hg/repos","events_url":"https://api.github.com/users/Shylock-Hg/events{/privacy}","received_events_url":"https://api.github.com/users/Shylock-Hg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Shylock-Hg/nebula","description":"A high performance distributed Graph Database","fork":true,"url":"https://api.github.com/repos/Shylock-Hg/nebula","forks_url":"https://api.github.com/repos/Shylock-Hg/nebula/forks","keys_url":"https://api.github.com/repos/Shylock-Hg/nebula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shylock-Hg/nebula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shylock-Hg/nebula/teams","hooks_url":"https://api.github.com/repos/Shylock-Hg/nebula/hooks","issue_events_url":"https://api.github.com/repos/Shylock-Hg/nebula/issues/events{/number}","events_url":"https://api.github.com/repos/Shylock-Hg/nebula/events","assignees_url":"https://api.github.com/repos/Shylock-Hg/nebula/assignees{/user}","branches_url":"https://api.github.com/repos/Shylock-Hg/nebula/branches{/branch}","tags_url":"https://api.github.com/repos/Shylock-Hg/nebula/tags","blobs_url":"https://api.github.com/repos/Shylock-Hg/nebula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shylock-Hg/nebula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shylock-Hg/nebula/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shylock-Hg/nebula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shylock-Hg/nebula/statuses/{sha}","languages_url":"https://api.github.com/repos/Shylock-Hg/nebula/languages","stargazers_url":"https://api.github.com/repos/Shylock-Hg/nebula/stargazers","contributors_url":"https://api.github.com/repos/Shylock-Hg/nebula/contributors","subscribers_url":"https://api.github.com/repos/Shylock-Hg/nebula/subscribers","subscription_url":"https://api.github.com/repos/Shylock-Hg/nebula/subscription","commits_url":"https://api.github.com/repos/Shylock-Hg/nebula/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shylock-Hg/nebula/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shylock-Hg/nebula/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shylock-Hg/nebula/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shylock-Hg/nebula/contents/{+path}","compare_url":"https://api.github.com/repos/Shylock-Hg/nebula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shylock-Hg/nebula/merges","archive_url":"https://api.github.com/repos/Shylock-Hg/nebula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shylock-Hg/nebula/downloads","issues_url":"https://api.github.com/repos/Shylock-Hg/nebula/issues{/number}","pulls_url":"https://api.github.com/repos/Shylock-Hg/nebula/pulls{/number}","milestones_url":"https://api.github.com/repos/Shylock-Hg/nebula/milestones{/number}","notifications_url":"https://api.github.com/repos/Shylock-Hg/nebula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shylock-Hg/nebula/labels{/name}","releases_url":"https://api.github.com/repos/Shylock-Hg/nebula/releases{/id}","deployments_url":"https://api.github.com/repos/Shylock-Hg/nebula/deployments","created_at":"2019-08-28T12:44:03Z","updated_at":"2019-12-24T01:52:47Z","pushed_at":"2019-12-24T06:36:36Z","git_url":"git://github.com/Shylock-Hg/nebula.git","ssh_url":"[email protected]:Shylock-Hg/nebula.git","clone_url":"https://github.com/Shylock-Hg/nebula.git","svn_url":"https://github.com/Shylock-Hg/nebula","homepage":"","size":47617,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vesoft-inc:master","ref":"master","sha":"7da8a04122275eb5d84fe01222ebbad495fe06a0","user":{"login":"vesoft-inc","id":42441426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDQxNDI2","avatar_url":"https://avatars2.githubusercontent.com/u/42441426?v=4","gravatar_id":"","url":"https://api.github.com/users/vesoft-inc","html_url":"https://github.com/vesoft-inc","followers_url":"https://api.github.com/users/vesoft-inc/followers","following_url":"https://api.github.com/users/vesoft-inc/following{/other_user}","gists_url":"https://api.github.com/users/vesoft-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/vesoft-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vesoft-inc/subscriptions","organizations_url":"https://api.github.com/users/vesoft-inc/orgs","repos_url":"https://api.github.com/users/vesoft-inc/repos","events_url":"https://api.github.com/users/vesoft-inc/events{/privacy}","received_events_url":"https://api.github.com/users/vesoft-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":146459443,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0NTk0NDM=","name":"nebula","full_name":"vesoft-inc/nebula","private":false,"owner":{"login":"vesoft-inc","id":42441426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDQxNDI2","avatar_url":"https://avatars2.githubusercontent.com/u/42441426?v=4","gravatar_id":"","url":"https://api.github.com/users/vesoft-inc","html_url":"https://github.com/vesoft-inc","followers_url":"https://api.github.com/users/vesoft-inc/followers","following_url":"https://api.github.com/users/vesoft-inc/following{/other_user}","gists_url":"https://api.github.com/users/vesoft-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/vesoft-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vesoft-inc/subscriptions","organizations_url":"https://api.github.com/users/vesoft-inc/orgs","repos_url":"https://api.github.com/users/vesoft-inc/repos","events_url":"https://api.github.com/users/vesoft-inc/events{/privacy}","received_events_url":"https://api.github.com/users/vesoft-inc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vesoft-inc/nebula","description":"A distributed, fast open-source graph database featuring horizontal scalability and high availability","fork":false,"url":"https://api.github.com/repos/vesoft-inc/nebula","forks_url":"https://api.github.com/repos/vesoft-inc/nebula/forks","keys_url":"https://api.github.com/repos/vesoft-inc/nebula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vesoft-inc/nebula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vesoft-inc/nebula/teams","hooks_url":"https://api.github.com/repos/vesoft-inc/nebula/hooks","issue_events_url":"https://api.github.com/repos/vesoft-inc/nebula/issues/events{/number}","events_url":"https://api.github.com/repos/vesoft-inc/nebula/events","assignees_url":"https://api.github.com/repos/vesoft-inc/nebula/assignees{/user}","branches_url":"https://api.github.com/repos/vesoft-inc/nebula/branches{/branch}","tags_url":"https://api.github.com/repos/vesoft-inc/nebula/tags","blobs_url":"https://api.github.com/repos/vesoft-inc/nebula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vesoft-inc/nebula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vesoft-inc/nebula/git/refs{/sha}","trees_url":"https://api.github.com/repos/vesoft-inc/nebula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vesoft-inc/nebula/statuses/{sha}","languages_url":"https://api.github.com/repos/vesoft-inc/nebula/languages","stargazers_url":"https://api.github.com/repos/vesoft-inc/nebula/stargazers","contributors_url":"https://api.github.com/repos/vesoft-inc/nebula/contributors","subscribers_url":"https://api.github.com/repos/vesoft-inc/nebula/subscribers","subscription_url":"https://api.github.com/repos/vesoft-inc/nebula/subscription","commits_url":"https://api.github.com/repos/vesoft-inc/nebula/commits{/sha}","git_commits_url":"https://api.github.com/repos/vesoft-inc/nebula/git/commits{/sha}","comments_url":"https://api.github.com/repos/vesoft-inc/nebula/comments{/number}","issue_comment_url":"https://api.github.com/repos/vesoft-inc/nebula/issues/comments{/number}","contents_url":"https://api.github.com/repos/vesoft-inc/nebula/contents/{+path}","compare_url":"https://api.github.com/repos/vesoft-inc/nebula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vesoft-inc/nebula/merges","archive_url":"https://api.github.com/repos/vesoft-inc/nebula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vesoft-inc/nebula/downloads","issues_url":"https://api.github.com/repos/vesoft-inc/nebula/issues{/number}","pulls_url":"https://api.github.com/repos/vesoft-inc/nebula/pulls{/number}","milestones_url":"https://api.github.com/repos/vesoft-inc/nebula/milestones{/number}","notifications_url":"https://api.github.com/repos/vesoft-inc/nebula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vesoft-inc/nebula/labels{/name}","releases_url":"https://api.github.com/repos/vesoft-inc/nebula/releases{/id}","deployments_url":"https://api.github.com/repos/vesoft-inc/nebula/deployments","created_at":"2018-08-28T14:25:09Z","updated_at":"2019-12-24T03:21:58Z","pushed_at":"2019-12-24T06:36:38Z","git_url":"git://github.com/vesoft-inc/nebula.git","ssh_url":"[email protected]:vesoft-inc/nebula.git","clone_url":"https://github.com/vesoft-inc/nebula.git","svn_url":"https://github.com/vesoft-inc/nebula","homepage":"https://nebula-graph.io","size":45608,"stargazers_count":1633,"watchers_count":1633,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":224,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":276,"open_issues":224,"watchers":1633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vesoft-inc/nebula/pulls/1505"},"html":{"href":"https://github.com/vesoft-inc/nebula/pull/1505"},"issue":{"href":"https://api.github.com/repos/vesoft-inc/nebula/issues/1505"},"comments":{"href":"https://api.github.com/repos/vesoft-inc/nebula/issues/1505/comments"},"review_comments":{"href":"https://api.github.com/repos/vesoft-inc/nebula/pulls/1505/comments"},"review_comment":{"href":"https://api.github.com/repos/vesoft-inc/nebula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vesoft-inc/nebula/pulls/1505/commits"},"statuses":{"href":"https://api.github.com/repos/vesoft-inc/nebula/statuses/8b3784d52296d9215265b01d128291e30e9a8c78"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 146459443,
"name": "vesoft-inc/nebula",
"url": "https://api.github.com/repos/vesoft-inc/nebula"
}
|
{
"id": 331435,
"login": "monadbobo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/331435?",
"url": "https://api.github.com/users/monadbobo"
}
|
{
"id": 42441426,
"login": "vesoft-inc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42441426?",
"url": "https://api.github.com/orgs/vesoft-inc"
}
| 2019-12-24T06:40:13 |
11151918681
|
{"actor":{"display_login":"monadbobo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/comments/291662462","pull_request_review_id":247186127,"id":291662462,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTY2MjQ2Mg==","diff_hunk":"@@ -0,0 +1,91 @@\n+from vtk import vtkPolyDataReader, vtkStructuredPointsReader, \\\n+ vtkXMLImageDataWriter, vtkXMLPolyDataWriter\n+from girder_client import GirderClient\n+import os\n+import click\n+import re\n+\[email protected]()\[email protected]('--inputfolderid', required=True, prompt=True, help='Source Folder ID')\[email protected]('--outputfolderid', required=True, prompt=True, help='Destination Folder ID')\[email protected]('--apikey', required=True, prompt=True, help='API Key from Girder')\[email protected]('--hostname', default='https://data.computational-biology.org/api/v1/', prompt=True, help='URL, make sure to include /api/v1/ at the end')\n+def main(inputfolderid, outputfolderid, apikey, hostname):","path":"scripts/vtk_convert.py","position":13,"original_position":13,"commit_id":"7fc52c16c2be04ecd18cdf362134b211ddb60b8e","original_commit_id":"7fc52c16c2be04ecd18cdf362134b211ddb60b8e","user":{"login":"brianhelba","id":1282879,"node_id":"MDQ6VXNlcjEyODI4Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1282879?v=4","gravatar_id":"","url":"https://api.github.com/users/brianhelba","html_url":"https://github.com/brianhelba","followers_url":"https://api.github.com/users/brianhelba/followers","following_url":"https://api.github.com/users/brianhelba/following{/other_user}","gists_url":"https://api.github.com/users/brianhelba/gists{/gist_id}","starred_url":"https://api.github.com/users/brianhelba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianhelba/subscriptions","organizations_url":"https://api.github.com/users/brianhelba/orgs","repos_url":"https://api.github.com/users/brianhelba/repos","events_url":"https://api.github.com/users/brianhelba/events{/privacy}","received_events_url":"https://api.github.com/users/brianhelba/received_events","type":"User","site_admin":false},"body":"Girder doesn't follow this, but the style convention is for Python variables to use snake_case. So, this should be `input_folder_id`, etc.","created_at":"2019-06-07T16:18:53Z","updated_at":"2019-06-07T16:51:14Z","html_url":"https://github.com/LungFungalGrowth/lung-fungal-web/pull/8#discussion_r291662462","pull_request_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/comments/291662462"},"html":{"href":"https://github.com/LungFungalGrowth/lung-fungal-web/pull/8#discussion_r291662462"},"pull_request":{"href":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/8","id":285147335,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1MTQ3MzM1","html_url":"https://github.com/LungFungalGrowth/lung-fungal-web/pull/8","diff_url":"https://github.com/LungFungalGrowth/lung-fungal-web/pull/8.diff","patch_url":"https://github.com/LungFungalGrowth/lung-fungal-web/pull/8.patch","issue_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues/8","number":8,"state":"open","locked":false,"title":"VTK Converter and File Uploader","user":{"login":"joanne-tsai","id":44120066,"node_id":"MDQ6VXNlcjQ0MTIwMDY2","avatar_url":"https://avatars0.githubusercontent.com/u/44120066?v=4","gravatar_id":"","url":"https://api.github.com/users/joanne-tsai","html_url":"https://github.com/joanne-tsai","followers_url":"https://api.github.com/users/joanne-tsai/followers","following_url":"https://api.github.com/users/joanne-tsai/following{/other_user}","gists_url":"https://api.github.com/users/joanne-tsai/gists{/gist_id}","starred_url":"https://api.github.com/users/joanne-tsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joanne-tsai/subscriptions","organizations_url":"https://api.github.com/users/joanne-tsai/orgs","repos_url":"https://api.github.com/users/joanne-tsai/repos","events_url":"https://api.github.com/users/joanne-tsai/events{/privacy}","received_events_url":"https://api.github.com/users/joanne-tsai/received_events","type":"User","site_admin":false},"body":"Converts VTK to VTI files and uploads those files to Girder.\r\n\r\nThe python script retrieves the ids of all of the geometry, macrophage, and spore files from folder, based on the ID provided. It assuming they follow a hierarchy like this: root folder > geometry folder > geometry_XXX.vtk items > geometry_XXX.vtk file. Those files are then all downloaded and converted into vti files and uploaded to the provided folder ID and sorts them into a hierarchy like this: root folder > XXX timepoint folder > geometry_XXX.vti item, macrophage_XXX.vti item, spore_XXX.vti item > corresponding file. ","created_at":"2019-06-04T21:15:50Z","updated_at":"2019-06-07T16:51:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fbe6a7956868ef2230cf05e03ac173a62389ed3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/8/commits","review_comments_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/8/comments","review_comment_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues/8/comments","statuses_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/statuses/7fc52c16c2be04ecd18cdf362134b211ddb60b8e","head":{"label":"LungFungalGrowth:convertUpload","ref":"convertUpload","sha":"7fc52c16c2be04ecd18cdf362134b211ddb60b8e","user":{"login":"LungFungalGrowth","id":42449293,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDQ5Mjkz","avatar_url":"https://avatars2.githubusercontent.com/u/42449293?v=4","gravatar_id":"","url":"https://api.github.com/users/LungFungalGrowth","html_url":"https://github.com/LungFungalGrowth","followers_url":"https://api.github.com/users/LungFungalGrowth/followers","following_url":"https://api.github.com/users/LungFungalGrowth/following{/other_user}","gists_url":"https://api.github.com/users/LungFungalGrowth/gists{/gist_id}","starred_url":"https://api.github.com/users/LungFungalGrowth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LungFungalGrowth/subscriptions","organizations_url":"https://api.github.com/users/LungFungalGrowth/orgs","repos_url":"https://api.github.com/users/LungFungalGrowth/repos","events_url":"https://api.github.com/users/LungFungalGrowth/events{/privacy}","received_events_url":"https://api.github.com/users/LungFungalGrowth/received_events","type":"Organization","site_admin":false},"repo":{"id":146599963,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1OTk5NjM=","name":"lung-fungal-web","full_name":"LungFungalGrowth/lung-fungal-web","private":false,"owner":{"login":"LungFungalGrowth","id":42449293,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDQ5Mjkz","avatar_url":"https://avatars2.githubusercontent.com/u/42449293?v=4","gravatar_id":"","url":"https://api.github.com/users/LungFungalGrowth","html_url":"https://github.com/LungFungalGrowth","followers_url":"https://api.github.com/users/LungFungalGrowth/followers","following_url":"https://api.github.com/users/LungFungalGrowth/following{/other_user}","gists_url":"https://api.github.com/users/LungFungalGrowth/gists{/gist_id}","starred_url":"https://api.github.com/users/LungFungalGrowth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LungFungalGrowth/subscriptions","organizations_url":"https://api.github.com/users/LungFungalGrowth/orgs","repos_url":"https://api.github.com/users/LungFungalGrowth/repos","events_url":"https://api.github.com/users/LungFungalGrowth/events{/privacy}","received_events_url":"https://api.github.com/users/LungFungalGrowth/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LungFungalGrowth/lung-fungal-web","description":null,"fork":false,"url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web","forks_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/forks","keys_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/teams","hooks_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/hooks","issue_events_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues/events{/number}","events_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/events","assignees_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/assignees{/user}","branches_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/branches{/branch}","tags_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/tags","blobs_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/statuses/{sha}","languages_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/languages","stargazers_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/stargazers","contributors_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/contributors","subscribers_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/subscribers","subscription_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/subscription","commits_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/contents/{+path}","compare_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/merges","archive_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/downloads","issues_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues{/number}","pulls_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls{/number}","milestones_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/milestones{/number}","notifications_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/labels{/name}","releases_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/releases{/id}","deployments_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/deployments","created_at":"2018-08-29T12:57:08Z","updated_at":"2019-05-14T08:21:40Z","pushed_at":"2019-06-07T14:48:55Z","git_url":"git://github.com/LungFungalGrowth/lung-fungal-web.git","ssh_url":"[email protected]:LungFungalGrowth/lung-fungal-web.git","clone_url":"https://github.com/LungFungalGrowth/lung-fungal-web.git","svn_url":"https://github.com/LungFungalGrowth/lung-fungal-web","homepage":null,"size":287,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"LungFungalGrowth:master","ref":"master","sha":"09eb65ffb415c1113988c8adf4c4d6058f5ddf86","user":{"login":"LungFungalGrowth","id":42449293,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDQ5Mjkz","avatar_url":"https://avatars2.githubusercontent.com/u/42449293?v=4","gravatar_id":"","url":"https://api.github.com/users/LungFungalGrowth","html_url":"https://github.com/LungFungalGrowth","followers_url":"https://api.github.com/users/LungFungalGrowth/followers","following_url":"https://api.github.com/users/LungFungalGrowth/following{/other_user}","gists_url":"https://api.github.com/users/LungFungalGrowth/gists{/gist_id}","starred_url":"https://api.github.com/users/LungFungalGrowth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LungFungalGrowth/subscriptions","organizations_url":"https://api.github.com/users/LungFungalGrowth/orgs","repos_url":"https://api.github.com/users/LungFungalGrowth/repos","events_url":"https://api.github.com/users/LungFungalGrowth/events{/privacy}","received_events_url":"https://api.github.com/users/LungFungalGrowth/received_events","type":"Organization","site_admin":false},"repo":{"id":146599963,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1OTk5NjM=","name":"lung-fungal-web","full_name":"LungFungalGrowth/lung-fungal-web","private":false,"owner":{"login":"LungFungalGrowth","id":42449293,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDQ5Mjkz","avatar_url":"https://avatars2.githubusercontent.com/u/42449293?v=4","gravatar_id":"","url":"https://api.github.com/users/LungFungalGrowth","html_url":"https://github.com/LungFungalGrowth","followers_url":"https://api.github.com/users/LungFungalGrowth/followers","following_url":"https://api.github.com/users/LungFungalGrowth/following{/other_user}","gists_url":"https://api.github.com/users/LungFungalGrowth/gists{/gist_id}","starred_url":"https://api.github.com/users/LungFungalGrowth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LungFungalGrowth/subscriptions","organizations_url":"https://api.github.com/users/LungFungalGrowth/orgs","repos_url":"https://api.github.com/users/LungFungalGrowth/repos","events_url":"https://api.github.com/users/LungFungalGrowth/events{/privacy}","received_events_url":"https://api.github.com/users/LungFungalGrowth/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LungFungalGrowth/lung-fungal-web","description":null,"fork":false,"url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web","forks_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/forks","keys_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/teams","hooks_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/hooks","issue_events_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues/events{/number}","events_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/events","assignees_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/assignees{/user}","branches_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/branches{/branch}","tags_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/tags","blobs_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/statuses/{sha}","languages_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/languages","stargazers_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/stargazers","contributors_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/contributors","subscribers_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/subscribers","subscription_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/subscription","commits_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/contents/{+path}","compare_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/merges","archive_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/downloads","issues_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues{/number}","pulls_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls{/number}","milestones_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/milestones{/number}","notifications_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/labels{/name}","releases_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/releases{/id}","deployments_url":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/deployments","created_at":"2018-08-29T12:57:08Z","updated_at":"2019-05-14T08:21:40Z","pushed_at":"2019-06-07T14:48:55Z","git_url":"git://github.com/LungFungalGrowth/lung-fungal-web.git","ssh_url":"[email protected]:LungFungalGrowth/lung-fungal-web.git","clone_url":"https://github.com/LungFungalGrowth/lung-fungal-web.git","svn_url":"https://github.com/LungFungalGrowth/lung-fungal-web","homepage":null,"size":287,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/8"},"html":{"href":"https://github.com/LungFungalGrowth/lung-fungal-web/pull/8"},"issue":{"href":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues/8"},"comments":{"href":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/LungFungalGrowth/lung-fungal-web/statuses/7fc52c16c2be04ecd18cdf362134b211ddb60b8e"}},"author_association":"NONE"}}
|
{
"id": 146599963,
"name": "LungFungalGrowth/lung-fungal-web",
"url": "https://api.github.com/repos/LungFungalGrowth/lung-fungal-web"
}
|
{
"id": 1282879,
"login": "brianhelba",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1282879?",
"url": "https://api.github.com/users/brianhelba"
}
|
{
"id": 42449293,
"login": "LungFungalGrowth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42449293?",
"url": "https://api.github.com/orgs/LungFungalGrowth"
}
| 2019-06-07T16:18:53 |
9780417846
|
{"actor":{"display_login":"brianhelba"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/xi-editor/druid/pulls/comments/344468781","pull_request_review_id":314585471,"id":344468781,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDQ2ODc4MQ==","diff_hunk":"@@ -42,6 +42,12 @@ pub const BORDERED_WIDGET_HEIGHT: Key<f64> = Key::new(\"bordered_widget_height\");\n \n pub const SCROLL_BAR_COLOR: Key<Color> = Key::new(\"scroll_bar_color\");\n pub const SCROLL_BAR_BORDER_COLOR: Key<Color> = Key::new(\"scroll_bar_border_color\");\n+pub const SCROLL_BAR_MAX_OPACITY: Key<f64> = Key::new(\"scroll_bar_max_opacity\");\n+pub const SCROLL_BAR_FADE_DELAY: Key<u64> = Key::new(\"scroll_bar_fade_time\");","path":"druid/src/theme.rs","position":5,"original_position":5,"commit_id":"eff959240c913c7a546f7a1850c0de0fa25c8359","original_commit_id":"eff959240c913c7a546f7a1850c0de0fa25c8359","user":{"login":"cmyr","id":3330916,"node_id":"MDQ6VXNlcjMzMzA5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"body":"these first two items are borderline, to me, in terms of whether they should be in a theme. This basically touches on some very foundational ideas about what a theme is supposed to be and what it's supposed to do. Do we want to be tuning these things per-platform, or to generally let the user tune them? It's possible that we do, but if we really want to be 'native' feeling per-platform it's likely going to take more than this.\r\n\r\nAnyway, I'm rambling. I don't think it's bad for these to be here, per-se, I just think it's not quite clear exactly what the scope of a theme is, and this is something we're going to have to figure out. ๐ ","created_at":"2019-11-10T01:41:51Z","updated_at":"2019-11-10T01:46:52Z","html_url":"https://github.com/xi-editor/druid/pull/285#discussion_r344468781","pull_request_url":"https://api.github.com/repos/xi-editor/druid/pulls/285","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xi-editor/druid/pulls/comments/344468781"},"html":{"href":"https://github.com/xi-editor/druid/pull/285#discussion_r344468781"},"pull_request":{"href":"https://api.github.com/repos/xi-editor/druid/pulls/285"}}},"pull_request":{"url":"https://api.github.com/repos/xi-editor/druid/pulls/285","id":339095917,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5MDk1OTE3","html_url":"https://github.com/xi-editor/druid/pull/285","diff_url":"https://github.com/xi-editor/druid/pull/285.diff","patch_url":"https://github.com/xi-editor/druid/pull/285.patch","issue_url":"https://api.github.com/repos/xi-editor/druid/issues/285","number":285,"state":"open","locked":false,"title":"Add scrollbar constants and magic numbers to theme","user":{"login":"ForLoveOfCats","id":30666851,"node_id":"MDQ6VXNlcjMwNjY2ODUx","avatar_url":"https://avatars2.githubusercontent.com/u/30666851?v=4","gravatar_id":"","url":"https://api.github.com/users/ForLoveOfCats","html_url":"https://github.com/ForLoveOfCats","followers_url":"https://api.github.com/users/ForLoveOfCats/followers","following_url":"https://api.github.com/users/ForLoveOfCats/following{/other_user}","gists_url":"https://api.github.com/users/ForLoveOfCats/gists{/gist_id}","starred_url":"https://api.github.com/users/ForLoveOfCats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForLoveOfCats/subscriptions","organizations_url":"https://api.github.com/users/ForLoveOfCats/orgs","repos_url":"https://api.github.com/users/ForLoveOfCats/repos","events_url":"https://api.github.com/users/ForLoveOfCats/events{/privacy}","received_events_url":"https://api.github.com/users/ForLoveOfCats/received_events","type":"User","site_admin":false},"body":"This *should be* (:crossed_fingers:) a short and sweet patch which adds a number of scrollbar constants to the theme. I didn't add an option to enable/disable scrollbar overlap as it seemed like more discussion is required about how to handle overlap, floating, and default style on different platforms.","created_at":"2019-11-09T22:43:59Z","updated_at":"2019-11-10T01:46:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"240b6970dac33d974dd555de9e45fb9fafbff667","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xi-editor/druid/pulls/285/commits","review_comments_url":"https://api.github.com/repos/xi-editor/druid/pulls/285/comments","review_comment_url":"https://api.github.com/repos/xi-editor/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xi-editor/druid/issues/285/comments","statuses_url":"https://api.github.com/repos/xi-editor/druid/statuses/eff959240c913c7a546f7a1850c0de0fa25c8359","head":{"label":"ForLoveOfCats:ScrollbarAddToTheme","ref":"ScrollbarAddToTheme","sha":"eff959240c913c7a546f7a1850c0de0fa25c8359","user":{"login":"ForLoveOfCats","id":30666851,"node_id":"MDQ6VXNlcjMwNjY2ODUx","avatar_url":"https://avatars2.githubusercontent.com/u/30666851?v=4","gravatar_id":"","url":"https://api.github.com/users/ForLoveOfCats","html_url":"https://github.com/ForLoveOfCats","followers_url":"https://api.github.com/users/ForLoveOfCats/followers","following_url":"https://api.github.com/users/ForLoveOfCats/following{/other_user}","gists_url":"https://api.github.com/users/ForLoveOfCats/gists{/gist_id}","starred_url":"https://api.github.com/users/ForLoveOfCats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForLoveOfCats/subscriptions","organizations_url":"https://api.github.com/users/ForLoveOfCats/orgs","repos_url":"https://api.github.com/users/ForLoveOfCats/repos","events_url":"https://api.github.com/users/ForLoveOfCats/events{/privacy}","received_events_url":"https://api.github.com/users/ForLoveOfCats/received_events","type":"User","site_admin":false},"repo":{"id":218121524,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgxMjE1MjQ=","name":"druid","full_name":"ForLoveOfCats/druid","private":false,"owner":{"login":"ForLoveOfCats","id":30666851,"node_id":"MDQ6VXNlcjMwNjY2ODUx","avatar_url":"https://avatars2.githubusercontent.com/u/30666851?v=4","gravatar_id":"","url":"https://api.github.com/users/ForLoveOfCats","html_url":"https://github.com/ForLoveOfCats","followers_url":"https://api.github.com/users/ForLoveOfCats/followers","following_url":"https://api.github.com/users/ForLoveOfCats/following{/other_user}","gists_url":"https://api.github.com/users/ForLoveOfCats/gists{/gist_id}","starred_url":"https://api.github.com/users/ForLoveOfCats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForLoveOfCats/subscriptions","organizations_url":"https://api.github.com/users/ForLoveOfCats/orgs","repos_url":"https://api.github.com/users/ForLoveOfCats/repos","events_url":"https://api.github.com/users/ForLoveOfCats/events{/privacy}","received_events_url":"https://api.github.com/users/ForLoveOfCats/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ForLoveOfCats/druid","description":"Data-oriented Rust UI design toolkit.","fork":true,"url":"https://api.github.com/repos/ForLoveOfCats/druid","forks_url":"https://api.github.com/repos/ForLoveOfCats/druid/forks","keys_url":"https://api.github.com/repos/ForLoveOfCats/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ForLoveOfCats/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ForLoveOfCats/druid/teams","hooks_url":"https://api.github.com/repos/ForLoveOfCats/druid/hooks","issue_events_url":"https://api.github.com/repos/ForLoveOfCats/druid/issues/events{/number}","events_url":"https://api.github.com/repos/ForLoveOfCats/druid/events","assignees_url":"https://api.github.com/repos/ForLoveOfCats/druid/assignees{/user}","branches_url":"https://api.github.com/repos/ForLoveOfCats/druid/branches{/branch}","tags_url":"https://api.github.com/repos/ForLoveOfCats/druid/tags","blobs_url":"https://api.github.com/repos/ForLoveOfCats/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ForLoveOfCats/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ForLoveOfCats/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/ForLoveOfCats/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ForLoveOfCats/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/ForLoveOfCats/druid/languages","stargazers_url":"https://api.github.com/repos/ForLoveOfCats/druid/stargazers","contributors_url":"https://api.github.com/repos/ForLoveOfCats/druid/contributors","subscribers_url":"https://api.github.com/repos/ForLoveOfCats/druid/subscribers","subscription_url":"https://api.github.com/repos/ForLoveOfCats/druid/subscription","commits_url":"https://api.github.com/repos/ForLoveOfCats/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/ForLoveOfCats/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/ForLoveOfCats/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/ForLoveOfCats/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/ForLoveOfCats/druid/contents/{+path}","compare_url":"https://api.github.com/repos/ForLoveOfCats/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ForLoveOfCats/druid/merges","archive_url":"https://api.github.com/repos/ForLoveOfCats/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ForLoveOfCats/druid/downloads","issues_url":"https://api.github.com/repos/ForLoveOfCats/druid/issues{/number}","pulls_url":"https://api.github.com/repos/ForLoveOfCats/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/ForLoveOfCats/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/ForLoveOfCats/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ForLoveOfCats/druid/labels{/name}","releases_url":"https://api.github.com/repos/ForLoveOfCats/druid/releases{/id}","deployments_url":"https://api.github.com/repos/ForLoveOfCats/druid/deployments","created_at":"2019-10-28T18:49:16Z","updated_at":"2019-11-07T20:36:41Z","pushed_at":"2019-11-10T01:42:51Z","git_url":"git://github.com/ForLoveOfCats/druid.git","ssh_url":"[email protected]:ForLoveOfCats/druid.git","clone_url":"https://github.com/ForLoveOfCats/druid.git","svn_url":"https://github.com/ForLoveOfCats/druid","homepage":null,"size":1394,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xi-editor:master","ref":"master","sha":"d0db47cc6a481f9aee392838c121b995f9d1d2c9","user":{"login":"xi-editor","id":43351123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMzUxMTIz","avatar_url":"https://avatars3.githubusercontent.com/u/43351123?v=4","gravatar_id":"","url":"https://api.github.com/users/xi-editor","html_url":"https://github.com/xi-editor","followers_url":"https://api.github.com/users/xi-editor/followers","following_url":"https://api.github.com/users/xi-editor/following{/other_user}","gists_url":"https://api.github.com/users/xi-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/xi-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi-editor/subscriptions","organizations_url":"https://api.github.com/users/xi-editor/orgs","repos_url":"https://api.github.com/users/xi-editor/repos","events_url":"https://api.github.com/users/xi-editor/events{/privacy}","received_events_url":"https://api.github.com/users/xi-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":155783257,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3ODMyNTc=","name":"druid","full_name":"xi-editor/druid","private":false,"owner":{"login":"xi-editor","id":43351123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMzUxMTIz","avatar_url":"https://avatars3.githubusercontent.com/u/43351123?v=4","gravatar_id":"","url":"https://api.github.com/users/xi-editor","html_url":"https://github.com/xi-editor","followers_url":"https://api.github.com/users/xi-editor/followers","following_url":"https://api.github.com/users/xi-editor/following{/other_user}","gists_url":"https://api.github.com/users/xi-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/xi-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi-editor/subscriptions","organizations_url":"https://api.github.com/users/xi-editor/orgs","repos_url":"https://api.github.com/users/xi-editor/repos","events_url":"https://api.github.com/users/xi-editor/events{/privacy}","received_events_url":"https://api.github.com/users/xi-editor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xi-editor/druid","description":"Data-oriented Rust UI design toolkit.","fork":false,"url":"https://api.github.com/repos/xi-editor/druid","forks_url":"https://api.github.com/repos/xi-editor/druid/forks","keys_url":"https://api.github.com/repos/xi-editor/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xi-editor/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xi-editor/druid/teams","hooks_url":"https://api.github.com/repos/xi-editor/druid/hooks","issue_events_url":"https://api.github.com/repos/xi-editor/druid/issues/events{/number}","events_url":"https://api.github.com/repos/xi-editor/druid/events","assignees_url":"https://api.github.com/repos/xi-editor/druid/assignees{/user}","branches_url":"https://api.github.com/repos/xi-editor/druid/branches{/branch}","tags_url":"https://api.github.com/repos/xi-editor/druid/tags","blobs_url":"https://api.github.com/repos/xi-editor/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xi-editor/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xi-editor/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/xi-editor/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xi-editor/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/xi-editor/druid/languages","stargazers_url":"https://api.github.com/repos/xi-editor/druid/stargazers","contributors_url":"https://api.github.com/repos/xi-editor/druid/contributors","subscribers_url":"https://api.github.com/repos/xi-editor/druid/subscribers","subscription_url":"https://api.github.com/repos/xi-editor/druid/subscription","commits_url":"https://api.github.com/repos/xi-editor/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/xi-editor/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/xi-editor/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/xi-editor/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/xi-editor/druid/contents/{+path}","compare_url":"https://api.github.com/repos/xi-editor/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xi-editor/druid/merges","archive_url":"https://api.github.com/repos/xi-editor/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xi-editor/druid/downloads","issues_url":"https://api.github.com/repos/xi-editor/druid/issues{/number}","pulls_url":"https://api.github.com/repos/xi-editor/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/xi-editor/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/xi-editor/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xi-editor/druid/labels{/name}","releases_url":"https://api.github.com/repos/xi-editor/druid/releases{/id}","deployments_url":"https://api.github.com/repos/xi-editor/druid/deployments","created_at":"2018-11-01T22:25:17Z","updated_at":"2019-11-10T01:29:03Z","pushed_at":"2019-11-10T01:43:17Z","git_url":"git://github.com/xi-editor/druid.git","ssh_url":"[email protected]:xi-editor/druid.git","clone_url":"https://github.com/xi-editor/druid.git","svn_url":"https://github.com/xi-editor/druid","homepage":null,"size":1402,"stargazers_count":816,"watchers_count":816,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":55,"open_issues":52,"watchers":816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xi-editor/druid/pulls/285"},"html":{"href":"https://github.com/xi-editor/druid/pull/285"},"issue":{"href":"https://api.github.com/repos/xi-editor/druid/issues/285"},"comments":{"href":"https://api.github.com/repos/xi-editor/druid/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/xi-editor/druid/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/xi-editor/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xi-editor/druid/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/xi-editor/druid/statuses/eff959240c913c7a546f7a1850c0de0fa25c8359"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 155783257,
"name": "xi-editor/druid",
"url": "https://api.github.com/repos/xi-editor/druid"
}
|
{
"id": 3330916,
"login": "cmyr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3330916?",
"url": "https://api.github.com/users/cmyr"
}
|
{
"id": 43351123,
"login": "xi-editor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43351123?",
"url": "https://api.github.com/orgs/xi-editor"
}
| 2019-11-10T01:41:51 |
10826719838
|
{"actor":{"display_login":"cmyr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kudobuilder/frameworks/pulls/comments/268787045","pull_request_review_id":218505183,"id":268787045,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODc4NzA0NQ==","diff_hunk":"@@ -0,0 +1,245 @@\n+apiVersion: kudo.k8s.io/v1alpha1\n+kind: FrameworkVersion\n+metadata:\n+ labels:\n+ controller-tools.k8s.io: \"1.0\"\n+ name: flink-1.0\n+ namespace: default\n+spec:\n+ framework:\n+ name: flinkapplication\n+ kind: Framework\n+ parameters:\n+ - name: JAR_URL\n+ description: Location of JAR to run\n+ default: \"\"\n+ required: false\n+ - name: JAR_PATH\n+ description: Location of Jar inside of Flink submission container\n+ default: \"\"\n+ required: false\n+ - name: JOB_ARGUMENTS\n+ description: Arguments to pass to Job at runtime\n+ default: \"\"\n+ - name: DEPLOY_OWN_CLUSTER\n+ default: \"false\"\n+ - name: CLUSTER_NAME\n+ default: \"mycluster\"\n+ - name: CLASSNAME\n+ description: Classname to run inside the Jar.\n+ default: \"\"\n+ templates:\n+ cluster.yaml: |\n+ #need to create a rolebinding for the service account in use\n+ {{#DEPLOY_OWN_CLUSTER}}\n+ apiVersion: kudo.k8s.io/v1alpha1\n+ kind: Instance\n+ metadata:\n+ name: {{CLUSTER_NAME}}\n+ spec:\n+ frameworkVersion:\n+ name: flinkcluster-1.7\n+ namespace: default\n+ type: FrameworkVersion\n+ parameters:\n+ HIGH_AVAILABILITY: ZOOKEEPER\n+ {{/DEPLOY_OWN_CLUSTER}}\n+ config.yaml: |\n+ apiVersion: v1\n+ data:\n+ jobid: \"\"\n+ snapshot: \"\"\n+ kind: ConfigMap\n+ metadata:\n+ name: flink\n+ namespace: {{NAMESPACE}}\n+ start.yaml: |\n+ # job to start\n+ apiVersion: batch/v1\n+ kind: Job\n+ metadata:\n+ namespace: default\n+ name: submit-flink-job\n+ spec:\n+ template:\n+ metadata:\n+ name: {{PLAN_NAME}}-job\n+ spec:\n+ restartPolicy: OnFailure\n+ {{#JAR_URL}}\n+ initContainers:\n+ - name: download\n+ # Do some download things here and save to a shared Volume\n+ # TODO\n+ {{/JAR_URL}}\n+ containers:\n+ - env:\n+ - name: JAR_PATH\n+ {{#JAR_URL}}\n+ value: /volume/{{NAME}}.jar\n+ {{/JAR_URL}}\n+ {{#JAR_PATH}}\n+ value: {{JAR_PATH}}\n+ {{/JAR_PATH}}\n+ - name: JOBMANAGER\n+ {{#DEPLOY_OWN_CLUSTER}}\n+ value: {{NAME}}-{{CLUSTER_NAME}}-jobmanager\n+ {{/DEPLOY_OWN_CLUSTER}}\n+ {{^DEPLOY_OWN_CLUSTER}}\n+ value: {{CLUSTER_NAME}}-jobmanager\n+ {{/DEPLOY_OWN_CLUSTER}}\n+ - name: CONFIGMAP\n+ value: {{NAME}}-flink\n+ - name: CLASSNAME\n+ value: {{CLASSNAME}}\n+ - name: PROGRAM_ARGS\n+ value: {{JOB_ARGUMENTS}}\n+ name: {{PLAN_NAME}}\n+ image: kudobuilder/flink-submitter:1.7.2\n+ imagePullPolicy: Always\n+ restart.yaml: |\n+ # job to start\n+ apiVersion: batch/v1\n+ kind: Job\n+ metadata:\n+ namespace: default\n+ name: restart-flink-job\n+ spec:\n+ template:\n+ metadata:\n+ name: {{PLAN_NAME}}-job\n+ spec:\n+ restartPolicy: OnFailure\n+ {{#JAR_URL}}\n+ initContainers:\n+ - name: download\n+ # Do some download things here and save to a shared Volume\n+ # TODO\n+ {{/JAR_URL}}\n+ containers:\n+ - env:\n+ - name: JAR_PATH\n+ {{#JAR_URL}}\n+ value: /volume/{{NAME}}.jar\n+ {{/JAR_URL}}\n+ {{#JAR_PATH}}\n+ value: {{JAR_PATH}}\n+ {{/JAR_PATH}}\n+ - name: JOBMANAGER\n+ {{#DEPLOY_OWN_CLUSTER}}\n+ value: {{NAME}}-{{CLUSTER_NAME}}-jobmanager\n+ {{/DEPLOY_OWN_CLUSTER}}\n+ {{^DEPLOY_OWN_CLUSTER}}\n+ value: {{CLUSTER_NAME}}-jobmanager\n+ {{/DEPLOY_OWN_CLUSTER}}\n+ - name: CONFIGMAP\n+ value: {{NAME}}-flink\n+ - name: CLASSNAME\n+ value: {{CLASSNAME}}\n+ - name: PROGRAM_ARGS\n+ value: {{JOB_ARGUMENTS}}\n+ - name: SAVEPOINT_PATH\n+ valueFrom:\n+ configMapKeyRef:\n+ name: {{NAME}}-flink\n+ key: \"location\"\n+ name: {{PLAN_NAME}}\n+ image: kudobuilder/flink-submitter:1.7.2\n+ imagePullPolicy: Always\n+ stop.yaml: |\n+ # job to start\n+ apiVersion: batch/v1\n+ kind: Job\n+ metadata:\n+ namespace: default\n+ name: stop-flink-job\n+ spec:\n+ template:\n+ metadata:\n+ name: {{PLAN_NAME}}-job\n+ spec:\n+ restartPolicy: OnFailure\n+ {{#JAR_URL}}\n+ initContainers:\n+ - name: download\n+ # Do some download things here and save to a shared Volume\n+ # TODO\n+ {{/JAR_URL}}\n+ containers:\n+ - env:\n+ - name: JAR_PATH\n+ {{#JAR_URL}}\n+ value: /volume/{{NAME}}.jar\n+ {{/JAR_URL}}\n+ {{#JAR_PATH}}\n+ value: {{JAR_PATH}}\n+ {{/JAR_PATH}}\n+ - name: JOBMANAGER\n+ {{#DEPLOY_OWN_CLUSTER}}\n+ value: {{NAME}}-{{CLUSTER_NAME}}-jobmanager\n+ {{/DEPLOY_OWN_CLUSTER}}\n+ {{^DEPLOY_OWN_CLUSTER}}\n+ value: {{CLUSTER_NAME}}-jobmanager\n+ {{/DEPLOY_OWN_CLUSTER}}\n+ - name: CONFIGMAP\n+ value: {{NAME}}-flink\n+ - name: CLASSNAME\n+ value: {{CLASSNAME}}\n+ - name: PROGRAM_ARGS\n+ value: {{JOB_ARGUMENTS}}\n+ command: [\"./shutdown.sh\"]\n+ name: {{PLAN_NAME}}\n+ image: kudobuilder/flink-submitter:1.7.2\n+ imagePullPolicy: Always\n+\n+ tasks:\n+ dependencies:\n+ resources:\n+ - cluster.yaml\n+ - config.yaml\n+ run:\n+ resources:\n+ - start.yaml\n+ stop:\n+ resources:\n+ - stop.yaml\n+ restart:\n+ resources:\n+ - restart.yaml\n+ plans:\n+ deploy:\n+ strategy: serial\n+ phases:\n+ - name: dependencies\n+ strategy: serial\n+ steps:\n+ - name: dependencies\n+ tasks:\n+ - dependencies\n+ run:\n+ strategy: serial\n+ phases:\n+ - name: dependencies\n+ strategy: serial\n+ steps:\n+ - name: start\n+ tasks:\n+ - run\n+ stop:\n+ strategy: serial\n+ phases:\n+ - name: dependencies","path":"repo/incubating/flink/versions/0/flinkapplication-frameworkversion.yaml","position":231,"original_position":231,"commit_id":"258e277204c58b34131a94e1b6ab679773be3029","original_commit_id":"258e277204c58b34131a94e1b6ab679773be3029","user":{"login":"fabianbaier","id":10104582,"node_id":"MDQ6VXNlcjEwMTA0NTgy","avatar_url":"https://avatars1.githubusercontent.com/u/10104582?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianbaier","html_url":"https://github.com/fabianbaier","followers_url":"https://api.github.com/users/fabianbaier/followers","following_url":"https://api.github.com/users/fabianbaier/following{/other_user}","gists_url":"https://api.github.com/users/fabianbaier/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianbaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianbaier/subscriptions","organizations_url":"https://api.github.com/users/fabianbaier/orgs","repos_url":"https://api.github.com/users/fabianbaier/repos","events_url":"https://api.github.com/users/fabianbaier/events{/privacy}","received_events_url":"https://api.github.com/users/fabianbaier/received_events","type":"User","site_admin":false},"body":"similar to above. I think using `dependencies` as name confuses","created_at":"2019-03-25T18:18:38Z","updated_at":"2019-03-25T18:18:39Z","html_url":"https://github.com/kudobuilder/frameworks/pull/5#discussion_r268787045","pull_request_url":"https://api.github.com/repos/kudobuilder/frameworks/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kudobuilder/frameworks/pulls/comments/268787045"},"html":{"href":"https://github.com/kudobuilder/frameworks/pull/5#discussion_r268787045"},"pull_request":{"href":"https://api.github.com/repos/kudobuilder/frameworks/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/kudobuilder/frameworks/pulls/5","id":262440683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyNDQwNjgz","html_url":"https://github.com/kudobuilder/frameworks/pull/5","diff_url":"https://github.com/kudobuilder/frameworks/pull/5.diff","patch_url":"https://github.com/kudobuilder/frameworks/pull/5.patch","issue_url":"https://api.github.com/repos/kudobuilder/frameworks/issues/5","number":5,"state":"open","locked":false,"title":"WIP Flink HA","user":{"login":"runyontr","id":9200575,"node_id":"MDQ6VXNlcjkyMDA1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/9200575?v=4","gravatar_id":"","url":"https://api.github.com/users/runyontr","html_url":"https://github.com/runyontr","followers_url":"https://api.github.com/users/runyontr/followers","following_url":"https://api.github.com/users/runyontr/following{/other_user}","gists_url":"https://api.github.com/users/runyontr/gists{/gist_id}","starred_url":"https://api.github.com/users/runyontr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runyontr/subscriptions","organizations_url":"https://api.github.com/users/runyontr/orgs","repos_url":"https://api.github.com/users/runyontr/repos","events_url":"https://api.github.com/users/runyontr/events{/privacy}","received_events_url":"https://api.github.com/users/runyontr/received_events","type":"User","site_admin":false},"body":"This is still a work in Progress.\r\n\r\nCurrent work:\r\n1) TaskManagers to find Jobmanagers via ZK\r\n2) Jobmanagers to do leader election via ZK\r\n\r\n\r\nOutstanding:\r\n1) Jars get replicated between Jobmanagers when uploaded\r\n2) Test failover of Jobmanagers. They successfully elect new leaders, but we need to make sure the jobs continue to run as expected.","created_at":"2019-03-19T12:46:20Z","updated_at":"2019-03-25T18:18:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be7323998f57fdba570053bd5019f323be2a7f31","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gerred","id":365659,"node_id":"MDQ6VXNlcjM2NTY1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/365659?v=4","gravatar_id":"","url":"https://api.github.com/users/gerred","html_url":"https://github.com/gerred","followers_url":"https://api.github.com/users/gerred/followers","following_url":"https://api.github.com/users/gerred/following{/other_user}","gists_url":"https://api.github.com/users/gerred/gists{/gist_id}","starred_url":"https://api.github.com/users/gerred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerred/subscriptions","organizations_url":"https://api.github.com/users/gerred/orgs","repos_url":"https://api.github.com/users/gerred/repos","events_url":"https://api.github.com/users/gerred/events{/privacy}","received_events_url":"https://api.github.com/users/gerred/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kudobuilder/frameworks/pulls/5/commits","review_comments_url":"https://api.github.com/repos/kudobuilder/frameworks/pulls/5/comments","review_comment_url":"https://api.github.com/repos/kudobuilder/frameworks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kudobuilder/frameworks/issues/5/comments","statuses_url":"https://api.github.com/repos/kudobuilder/frameworks/statuses/258e277204c58b34131a94e1b6ab679773be3029","head":{"label":"kudobuilder:flink-ha","ref":"flink-ha","sha":"258e277204c58b34131a94e1b6ab679773be3029","user":{"login":"kudobuilder","id":43684503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjg0NTAz","avatar_url":"https://avatars0.githubusercontent.com/u/43684503?v=4","gravatar_id":"","url":"https://api.github.com/users/kudobuilder","html_url":"https://github.com/kudobuilder","followers_url":"https://api.github.com/users/kudobuilder/followers","following_url":"https://api.github.com/users/kudobuilder/following{/other_user}","gists_url":"https://api.github.com/users/kudobuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/kudobuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kudobuilder/subscriptions","organizations_url":"https://api.github.com/users/kudobuilder/orgs","repos_url":"https://api.github.com/users/kudobuilder/repos","events_url":"https://api.github.com/users/kudobuilder/events{/privacy}","received_events_url":"https://api.github.com/users/kudobuilder/received_events","type":"Organization","site_admin":false},"repo":{"id":167766667,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc3NjY2Njc=","name":"frameworks","full_name":"kudobuilder/frameworks","private":false,"owner":{"login":"kudobuilder","id":43684503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjg0NTAz","avatar_url":"https://avatars0.githubusercontent.com/u/43684503?v=4","gravatar_id":"","url":"https://api.github.com/users/kudobuilder","html_url":"https://github.com/kudobuilder","followers_url":"https://api.github.com/users/kudobuilder/followers","following_url":"https://api.github.com/users/kudobuilder/following{/other_user}","gists_url":"https://api.github.com/users/kudobuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/kudobuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kudobuilder/subscriptions","organizations_url":"https://api.github.com/users/kudobuilder/orgs","repos_url":"https://api.github.com/users/kudobuilder/repos","events_url":"https://api.github.com/users/kudobuilder/events{/privacy}","received_events_url":"https://api.github.com/users/kudobuilder/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kudobuilder/frameworks","description":"Collection of frameworks for Kudo.","fork":false,"url":"https://api.github.com/repos/kudobuilder/frameworks","forks_url":"https://api.github.com/repos/kudobuilder/frameworks/forks","keys_url":"https://api.github.com/repos/kudobuilder/frameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kudobuilder/frameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kudobuilder/frameworks/teams","hooks_url":"https://api.github.com/repos/kudobuilder/frameworks/hooks","issue_events_url":"https://api.github.com/repos/kudobuilder/frameworks/issues/events{/number}","events_url":"https://api.github.com/repos/kudobuilder/frameworks/events","assignees_url":"https://api.github.com/repos/kudobuilder/frameworks/assignees{/user}","branches_url":"https://api.github.com/repos/kudobuilder/frameworks/branches{/branch}","tags_url":"https://api.github.com/repos/kudobuilder/frameworks/tags","blobs_url":"https://api.github.com/repos/kudobuilder/frameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kudobuilder/frameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kudobuilder/frameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/kudobuilder/frameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kudobuilder/frameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/kudobuilder/frameworks/languages","stargazers_url":"https://api.github.com/repos/kudobuilder/frameworks/stargazers","contributors_url":"https://api.github.com/repos/kudobuilder/frameworks/contributors","subscribers_url":"https://api.github.com/repos/kudobuilder/frameworks/subscribers","subscription_url":"https://api.github.com/repos/kudobuilder/frameworks/subscription","commits_url":"https://api.github.com/repos/kudobuilder/frameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/kudobuilder/frameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/kudobuilder/frameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/kudobuilder/frameworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/kudobuilder/frameworks/contents/{+path}","compare_url":"https://api.github.com/repos/kudobuilder/frameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kudobuilder/frameworks/merges","archive_url":"https://api.github.com/repos/kudobuilder/frameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kudobuilder/frameworks/downloads","issues_url":"https://api.github.com/repos/kudobuilder/frameworks/issues{/number}","pulls_url":"https://api.github.com/repos/kudobuilder/frameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/kudobuilder/frameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/kudobuilder/frameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kudobuilder/frameworks/labels{/name}","releases_url":"https://api.github.com/repos/kudobuilder/frameworks/releases{/id}","deployments_url":"https://api.github.com/repos/kudobuilder/frameworks/deployments","created_at":"2019-01-27T03:48:18Z","updated_at":"2019-03-07T01:06:04Z","pushed_at":"2019-03-25T02:26:08Z","git_url":"git://github.com/kudobuilder/frameworks.git","ssh_url":"[email protected]:kudobuilder/frameworks.git","clone_url":"https://github.com/kudobuilder/frameworks.git","svn_url":"https://github.com/kudobuilder/frameworks","homepage":"","size":51,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"kudobuilder:master","ref":"master","sha":"970f2fbf68af985de034ff09c2e3f1d3b92233f0","user":{"login":"kudobuilder","id":43684503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjg0NTAz","avatar_url":"https://avatars0.githubusercontent.com/u/43684503?v=4","gravatar_id":"","url":"https://api.github.com/users/kudobuilder","html_url":"https://github.com/kudobuilder","followers_url":"https://api.github.com/users/kudobuilder/followers","following_url":"https://api.github.com/users/kudobuilder/following{/other_user}","gists_url":"https://api.github.com/users/kudobuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/kudobuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kudobuilder/subscriptions","organizations_url":"https://api.github.com/users/kudobuilder/orgs","repos_url":"https://api.github.com/users/kudobuilder/repos","events_url":"https://api.github.com/users/kudobuilder/events{/privacy}","received_events_url":"https://api.github.com/users/kudobuilder/received_events","type":"Organization","site_admin":false},"repo":{"id":167766667,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc3NjY2Njc=","name":"frameworks","full_name":"kudobuilder/frameworks","private":false,"owner":{"login":"kudobuilder","id":43684503,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjg0NTAz","avatar_url":"https://avatars0.githubusercontent.com/u/43684503?v=4","gravatar_id":"","url":"https://api.github.com/users/kudobuilder","html_url":"https://github.com/kudobuilder","followers_url":"https://api.github.com/users/kudobuilder/followers","following_url":"https://api.github.com/users/kudobuilder/following{/other_user}","gists_url":"https://api.github.com/users/kudobuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/kudobuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kudobuilder/subscriptions","organizations_url":"https://api.github.com/users/kudobuilder/orgs","repos_url":"https://api.github.com/users/kudobuilder/repos","events_url":"https://api.github.com/users/kudobuilder/events{/privacy}","received_events_url":"https://api.github.com/users/kudobuilder/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kudobuilder/frameworks","description":"Collection of frameworks for Kudo.","fork":false,"url":"https://api.github.com/repos/kudobuilder/frameworks","forks_url":"https://api.github.com/repos/kudobuilder/frameworks/forks","keys_url":"https://api.github.com/repos/kudobuilder/frameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kudobuilder/frameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kudobuilder/frameworks/teams","hooks_url":"https://api.github.com/repos/kudobuilder/frameworks/hooks","issue_events_url":"https://api.github.com/repos/kudobuilder/frameworks/issues/events{/number}","events_url":"https://api.github.com/repos/kudobuilder/frameworks/events","assignees_url":"https://api.github.com/repos/kudobuilder/frameworks/assignees{/user}","branches_url":"https://api.github.com/repos/kudobuilder/frameworks/branches{/branch}","tags_url":"https://api.github.com/repos/kudobuilder/frameworks/tags","blobs_url":"https://api.github.com/repos/kudobuilder/frameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kudobuilder/frameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kudobuilder/frameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/kudobuilder/frameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kudobuilder/frameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/kudobuilder/frameworks/languages","stargazers_url":"https://api.github.com/repos/kudobuilder/frameworks/stargazers","contributors_url":"https://api.github.com/repos/kudobuilder/frameworks/contributors","subscribers_url":"https://api.github.com/repos/kudobuilder/frameworks/subscribers","subscription_url":"https://api.github.com/repos/kudobuilder/frameworks/subscription","commits_url":"https://api.github.com/repos/kudobuilder/frameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/kudobuilder/frameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/kudobuilder/frameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/kudobuilder/frameworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/kudobuilder/frameworks/contents/{+path}","compare_url":"https://api.github.com/repos/kudobuilder/frameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kudobuilder/frameworks/merges","archive_url":"https://api.github.com/repos/kudobuilder/frameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kudobuilder/frameworks/downloads","issues_url":"https://api.github.com/repos/kudobuilder/frameworks/issues{/number}","pulls_url":"https://api.github.com/repos/kudobuilder/frameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/kudobuilder/frameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/kudobuilder/frameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kudobuilder/frameworks/labels{/name}","releases_url":"https://api.github.com/repos/kudobuilder/frameworks/releases{/id}","deployments_url":"https://api.github.com/repos/kudobuilder/frameworks/deployments","created_at":"2019-01-27T03:48:18Z","updated_at":"2019-03-07T01:06:04Z","pushed_at":"2019-03-25T02:26:08Z","git_url":"git://github.com/kudobuilder/frameworks.git","ssh_url":"[email protected]:kudobuilder/frameworks.git","clone_url":"https://github.com/kudobuilder/frameworks.git","svn_url":"https://github.com/kudobuilder/frameworks","homepage":"","size":51,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kudobuilder/frameworks/pulls/5"},"html":{"href":"https://github.com/kudobuilder/frameworks/pull/5"},"issue":{"href":"https://api.github.com/repos/kudobuilder/frameworks/issues/5"},"comments":{"href":"https://api.github.com/repos/kudobuilder/frameworks/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/kudobuilder/frameworks/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/kudobuilder/frameworks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kudobuilder/frameworks/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/kudobuilder/frameworks/statuses/258e277204c58b34131a94e1b6ab679773be3029"}},"author_association":"MEMBER"}}
|
{
"id": 167766667,
"name": "kudobuilder/frameworks",
"url": "https://api.github.com/repos/kudobuilder/frameworks"
}
|
{
"id": 10104582,
"login": "fabianbaier",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10104582?",
"url": "https://api.github.com/users/fabianbaier"
}
|
{
"id": 43684503,
"login": "kudobuilder",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43684503?",
"url": "https://api.github.com/orgs/kudobuilder"
}
| 2019-03-25T18:18:38 |
9310248175
|
{"actor":{"display_login":"fabianbaier"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/comments/318968369","pull_request_review_id":281325086,"id":318968369,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxODk2ODM2OQ==","diff_hunk":"@@ -0,0 +1,61 @@\n+#ifndef TRACE_INODE_H_\n+#define TRACE_INODE_H_\n+\n+#include \"trace.h\"\n+\n+/**\n+ * @file\n+ *\n+ * @brief inodes tracer\n+ *\n+ * It provides tracing of following inodes properties:\n+ * - Inode's name; It keeps an internal cache with information if given inode\n+ * name has been already traced. If it hasn't, the inode name is traced.\n+ */\n+\n+// Forward declarations\n+struct iotrace_inode_tracer;\n+struct inode;\n+struct iotrace_state;\n+\n+/**\n+ * Handle of inodes tracer instance\n+ */\n+typedef struct iotrace_inode_tracer *iotrace_inode_tracer_t;\n+\n+/**\n+ * @brief Creates inode tracer instance\n+ *\n+ * @note inode tracer doesn't guaranty thread safety. If you intend to use it\n+ * across many threads, you need to ensure synchronization yourself\n+ *\n+ * @param[out] inode_tracer Handle of created inodes tracer instance\n+ * @param cpu CPU on which inode tracer will be running\n+ *\n+ * @return Operation result\n+ * @retval 0 - inode tracer created successfully\n+ * @retval Non-zero error while creating inode tracer\n+ */\n+int iotrace_create_inode_tracer(iotrace_inode_tracer_t *inode_tracer, int cpu);\n+\n+/**\n+ * @brief Destroys inode tracer\n+ *\n+ * @param[in,out] iotrace_inode inode tracer to be destroyed\n+ */\n+void iotrace_destroy_inode_tracer(iotrace_inode_tracer_t *inode_tracer);\n+\n+/**\n+ * @brief Traces indoe","path":"source/kernel/trace_inode.h","position":49,"original_position":49,"commit_id":"4873f114185564c876b718624d4ad3b2026ad17f","original_commit_id":"4873f114185564c876b718624d4ad3b2026ad17f","user":{"login":"tomaszrybicki","id":28840025,"node_id":"MDQ6VXNlcjI4ODQwMDI1","avatar_url":"https://avatars1.githubusercontent.com/u/28840025?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaszrybicki","html_url":"https://github.com/tomaszrybicki","followers_url":"https://api.github.com/users/tomaszrybicki/followers","following_url":"https://api.github.com/users/tomaszrybicki/following{/other_user}","gists_url":"https://api.github.com/users/tomaszrybicki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszrybicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszrybicki/subscriptions","organizations_url":"https://api.github.com/users/tomaszrybicki/orgs","repos_url":"https://api.github.com/users/tomaszrybicki/repos","events_url":"https://api.github.com/users/tomaszrybicki/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszrybicki/received_events","type":"User","site_admin":false},"body":"inode\r\n","created_at":"2019-08-29T09:18:00Z","updated_at":"2019-08-29T09:33:55Z","html_url":"https://github.com/Open-CAS/standalone-linux-io-tracer/pull/81#discussion_r318968369","pull_request_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/81","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/comments/318968369"},"html":{"href":"https://github.com/Open-CAS/standalone-linux-io-tracer/pull/81#discussion_r318968369"},"pull_request":{"href":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/81","id":311801149,"node_id":"MDExOlB1bGxSZXF1ZXN0MzExODAxMTQ5","html_url":"https://github.com/Open-CAS/standalone-linux-io-tracer/pull/81","diff_url":"https://github.com/Open-CAS/standalone-linux-io-tracer/pull/81.diff","patch_url":"https://github.com/Open-CAS/standalone-linux-io-tracer/pull/81.patch","issue_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/issues/81","number":81,"state":"open","locked":false,"title":"Traces file name","user":{"login":"mariuszbarczak","id":4924457,"node_id":"MDQ6VXNlcjQ5MjQ0NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4924457?v=4","gravatar_id":"","url":"https://api.github.com/users/mariuszbarczak","html_url":"https://github.com/mariuszbarczak","followers_url":"https://api.github.com/users/mariuszbarczak/followers","following_url":"https://api.github.com/users/mariuszbarczak/following{/other_user}","gists_url":"https://api.github.com/users/mariuszbarczak/gists{/gist_id}","starred_url":"https://api.github.com/users/mariuszbarczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariuszbarczak/subscriptions","organizations_url":"https://api.github.com/users/mariuszbarczak/orgs","repos_url":"https://api.github.com/users/mariuszbarczak/repos","events_url":"https://api.github.com/users/mariuszbarczak/events{/privacy}","received_events_url":"https://api.github.com/users/mariuszbarczak/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Mariusz Barczak <[email protected]>","created_at":"2019-08-28T11:31:51Z","updated_at":"2019-08-29T09:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e57fddf3029f2127d0532fa45046beec6098eecf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/81/commits","review_comments_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/81/comments","review_comment_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/issues/81/comments","statuses_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/statuses/4873f114185564c876b718624d4ad3b2026ad17f","head":{"label":"mariuszbarczak:traces-file-name","ref":"traces-file-name","sha":"4873f114185564c876b718624d4ad3b2026ad17f","user":{"login":"mariuszbarczak","id":4924457,"node_id":"MDQ6VXNlcjQ5MjQ0NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4924457?v=4","gravatar_id":"","url":"https://api.github.com/users/mariuszbarczak","html_url":"https://github.com/mariuszbarczak","followers_url":"https://api.github.com/users/mariuszbarczak/followers","following_url":"https://api.github.com/users/mariuszbarczak/following{/other_user}","gists_url":"https://api.github.com/users/mariuszbarczak/gists{/gist_id}","starred_url":"https://api.github.com/users/mariuszbarczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariuszbarczak/subscriptions","organizations_url":"https://api.github.com/users/mariuszbarczak/orgs","repos_url":"https://api.github.com/users/mariuszbarczak/repos","events_url":"https://api.github.com/users/mariuszbarczak/events{/privacy}","received_events_url":"https://api.github.com/users/mariuszbarczak/received_events","type":"User","site_admin":false},"repo":{"id":188866772,"node_id":"MDEwOlJlcG9zaXRvcnkxODg4NjY3NzI=","name":"standalone-linux-io-tracer","full_name":"mariuszbarczak/standalone-linux-io-tracer","private":false,"owner":{"login":"mariuszbarczak","id":4924457,"node_id":"MDQ6VXNlcjQ5MjQ0NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4924457?v=4","gravatar_id":"","url":"https://api.github.com/users/mariuszbarczak","html_url":"https://github.com/mariuszbarczak","followers_url":"https://api.github.com/users/mariuszbarczak/followers","following_url":"https://api.github.com/users/mariuszbarczak/following{/other_user}","gists_url":"https://api.github.com/users/mariuszbarczak/gists{/gist_id}","starred_url":"https://api.github.com/users/mariuszbarczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariuszbarczak/subscriptions","organizations_url":"https://api.github.com/users/mariuszbarczak/orgs","repos_url":"https://api.github.com/users/mariuszbarczak/repos","events_url":"https://api.github.com/users/mariuszbarczak/events{/privacy}","received_events_url":"https://api.github.com/users/mariuszbarczak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mariuszbarczak/standalone-linux-io-tracer","description":null,"fork":true,"url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer","forks_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/forks","keys_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/teams","hooks_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/hooks","issue_events_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/issues/events{/number}","events_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/events","assignees_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/assignees{/user}","branches_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/branches{/branch}","tags_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/tags","blobs_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/statuses/{sha}","languages_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/languages","stargazers_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/stargazers","contributors_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/contributors","subscribers_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/subscribers","subscription_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/subscription","commits_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/contents/{+path}","compare_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/merges","archive_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/downloads","issues_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/issues{/number}","pulls_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/pulls{/number}","milestones_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/milestones{/number}","notifications_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/labels{/name}","releases_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/releases{/id}","deployments_url":"https://api.github.com/repos/mariuszbarczak/standalone-linux-io-tracer/deployments","created_at":"2019-05-27T15:18:53Z","updated_at":"2019-05-27T15:18:55Z","pushed_at":"2019-08-28T20:54:33Z","git_url":"git://github.com/mariuszbarczak/standalone-linux-io-tracer.git","ssh_url":"[email protected]:mariuszbarczak/standalone-linux-io-tracer.git","clone_url":"https://github.com/mariuszbarczak/standalone-linux-io-tracer.git","svn_url":"https://github.com/mariuszbarczak/standalone-linux-io-tracer","homepage":null,"size":139,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause-clear","name":"BSD 3-Clause Clear License","spdx_id":"BSD-3-Clause-Clear","url":"https://api.github.com/licenses/bsd-3-clause-clear","node_id":"MDc6TGljZW5zZTIx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Open-CAS:master","ref":"master","sha":"5b16807efe8249c91ee6d56fa54684c2edecac89","user":{"login":"Open-CAS","id":43686834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjg2ODM0","avatar_url":"https://avatars3.githubusercontent.com/u/43686834?v=4","gravatar_id":"","url":"https://api.github.com/users/Open-CAS","html_url":"https://github.com/Open-CAS","followers_url":"https://api.github.com/users/Open-CAS/followers","following_url":"https://api.github.com/users/Open-CAS/following{/other_user}","gists_url":"https://api.github.com/users/Open-CAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Open-CAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Open-CAS/subscriptions","organizations_url":"https://api.github.com/users/Open-CAS/orgs","repos_url":"https://api.github.com/users/Open-CAS/repos","events_url":"https://api.github.com/users/Open-CAS/events{/privacy}","received_events_url":"https://api.github.com/users/Open-CAS/received_events","type":"Organization","site_admin":false},"repo":{"id":175410945,"node_id":"MDEwOlJlcG9zaXRvcnkxNzU0MTA5NDU=","name":"standalone-linux-io-tracer","full_name":"Open-CAS/standalone-linux-io-tracer","private":false,"owner":{"login":"Open-CAS","id":43686834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjg2ODM0","avatar_url":"https://avatars3.githubusercontent.com/u/43686834?v=4","gravatar_id":"","url":"https://api.github.com/users/Open-CAS","html_url":"https://github.com/Open-CAS","followers_url":"https://api.github.com/users/Open-CAS/followers","following_url":"https://api.github.com/users/Open-CAS/following{/other_user}","gists_url":"https://api.github.com/users/Open-CAS/gists{/gist_id}","starred_url":"https://api.github.com/users/Open-CAS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Open-CAS/subscriptions","organizations_url":"https://api.github.com/users/Open-CAS/orgs","repos_url":"https://api.github.com/users/Open-CAS/repos","events_url":"https://api.github.com/users/Open-CAS/events{/privacy}","received_events_url":"https://api.github.com/users/Open-CAS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Open-CAS/standalone-linux-io-tracer","description":"Standalone Linux IO Tracer (iotrace) is a tool for block device and filesystem I/O tracing","fork":false,"url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer","forks_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/forks","keys_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/teams","hooks_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/hooks","issue_events_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/issues/events{/number}","events_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/events","assignees_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/assignees{/user}","branches_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/branches{/branch}","tags_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/tags","blobs_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/statuses/{sha}","languages_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/languages","stargazers_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/stargazers","contributors_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/contributors","subscribers_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/subscribers","subscription_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/subscription","commits_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/contents/{+path}","compare_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/merges","archive_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/downloads","issues_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/issues{/number}","pulls_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls{/number}","milestones_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/milestones{/number}","notifications_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/labels{/name}","releases_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/releases{/id}","deployments_url":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/deployments","created_at":"2019-03-13T11:52:21Z","updated_at":"2019-08-28T14:10:28Z","pushed_at":"2019-08-28T20:54:34Z","git_url":"git://github.com/Open-CAS/standalone-linux-io-tracer.git","ssh_url":"[email protected]:Open-CAS/standalone-linux-io-tracer.git","clone_url":"https://github.com/Open-CAS/standalone-linux-io-tracer.git","svn_url":"https://github.com/Open-CAS/standalone-linux-io-tracer","homepage":"","size":132,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"bsd-3-clause-clear","name":"BSD 3-Clause Clear License","spdx_id":"BSD-3-Clause-Clear","url":"https://api.github.com/licenses/bsd-3-clause-clear","node_id":"MDc6TGljZW5zZTIx"},"forks":3,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/81"},"html":{"href":"https://github.com/Open-CAS/standalone-linux-io-tracer/pull/81"},"issue":{"href":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/issues/81"},"comments":{"href":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer/statuses/4873f114185564c876b718624d4ad3b2026ad17f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 175410945,
"name": "Open-CAS/standalone-linux-io-tracer",
"url": "https://api.github.com/repos/Open-CAS/standalone-linux-io-tracer"
}
|
{
"id": 28840025,
"login": "tomaszrybicki",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28840025?",
"url": "https://api.github.com/users/tomaszrybicki"
}
|
{
"id": 43686834,
"login": "Open-CAS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43686834?",
"url": "https://api.github.com/orgs/Open-CAS"
}
| 2019-08-29T11:18:00 |
10307832454
|
{"actor":{"display_login":"tomaszrybicki"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/293165865","pull_request_review_id":249077416,"id":293165865,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzE2NTg2NQ==","diff_hunk":"@@ -71,6 +82,28 @@ gdf_column apply_boolean_mask(gdf_column const &input,\n * @return gdf_column Column containing copy of all non-null elements of @p input.\n */\n gdf_column drop_nulls(gdf_column const &input);\n+\n+\n+/**\n+ * @brief Create a new table without duplicate rows \n+ *\n+ * Given an input table, each row is copied to output table if the corresponding\n+ * row of key column table is (unique or first duplicate row) or (unique or last","path":"cpp/include/stream_compaction.hpp","position":28,"original_position":28,"commit_id":"60aafc76be984e4bd9b0d21e17aaa928564a5523","original_commit_id":"60aafc76be984e4bd9b0d21e17aaa928564a5523","user":{"login":"harrism","id":783069,"node_id":"MDQ6VXNlcjc4MzA2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/783069?v=4","gravatar_id":"","url":"https://api.github.com/users/harrism","html_url":"https://github.com/harrism","followers_url":"https://api.github.com/users/harrism/followers","following_url":"https://api.github.com/users/harrism/following{/other_user}","gists_url":"https://api.github.com/users/harrism/gists{/gist_id}","starred_url":"https://api.github.com/users/harrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrism/subscriptions","organizations_url":"https://api.github.com/users/harrism/orgs","repos_url":"https://api.github.com/users/harrism/repos","events_url":"https://api.github.com/users/harrism/events{/privacy}","received_events_url":"https://api.github.com/users/harrism/received_events","type":"User","site_admin":false},"body":"Note `KEEP_FALSE` should be renamed to the clearer `KEEP_NONE`.","created_at":"2019-06-13T00:18:37Z","updated_at":"2019-06-13T00:18:38Z","html_url":"https://github.com/rapidsai/cudf/pull/1845#discussion_r293165865","pull_request_url":"https://api.github.com/repos/rapidsai/cudf/pulls/1845","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/293165865"},"html":{"href":"https://github.com/rapidsai/cudf/pull/1845#discussion_r293165865"},"pull_request":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/1845"}},"in_reply_to_id":293164985},"pull_request":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/1845","id":281840326,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxODQwMzI2","html_url":"https://github.com/rapidsai/cudf/pull/1845","diff_url":"https://github.com/rapidsai/cudf/pull/1845.diff","patch_url":"https://github.com/rapidsai/cudf/pull/1845.patch","issue_url":"https://api.github.com/repos/rapidsai/cudf/issues/1845","number":1845,"state":"open","locked":false,"title":"[WIP] Feature drop_duplicates","user":{"login":"karthikeyann","id":6488848,"node_id":"MDQ6VXNlcjY0ODg4NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6488848?v=4","gravatar_id":"","url":"https://api.github.com/users/karthikeyann","html_url":"https://github.com/karthikeyann","followers_url":"https://api.github.com/users/karthikeyann/followers","following_url":"https://api.github.com/users/karthikeyann/following{/other_user}","gists_url":"https://api.github.com/users/karthikeyann/gists{/gist_id}","starred_url":"https://api.github.com/users/karthikeyann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthikeyann/subscriptions","organizations_url":"https://api.github.com/users/karthikeyann/orgs","repos_url":"https://api.github.com/users/karthikeyann/repos","events_url":"https://api.github.com/users/karthikeyann/events{/privacy}","received_events_url":"https://api.github.com/users/karthikeyann/received_events","type":"User","site_admin":false},"body":"Closes #1467\r\n\r\n# dataframe `drop_duplicates`\r\n- [x] drop numerical column\r\n- [x] string column\r\n- [x] Empty dataframe\r\n- [x] Null support\r\n- [x] subset columns\r\n- [x] keep='first', 'last'\r\n- [x] inplace\r\n- [x] string index\r\n- [x] numeric index\r\n- [x] datetime index\r\n- [x] datetime column\r\n- ~~[ ] tuple index~~ (not supported by cudf)\r\n\r\nImplemented with sorting method. \r\n\r\n### Method:\r\n1. Sort the indices\r\n2. Compare rows and get unique indices\r\n3. sort the unique indices to get original order\r\n4. gather the new columns using the unique indices. ","created_at":"2019-05-24T01:51:53Z","updated_at":"2019-06-13T00:18:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a6032056539308bd4288db37a698ed21da8ae6","assignee":{"login":"karthikeyann","id":6488848,"node_id":"MDQ6VXNlcjY0ODg4NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6488848?v=4","gravatar_id":"","url":"https://api.github.com/users/karthikeyann","html_url":"https://github.com/karthikeyann","followers_url":"https://api.github.com/users/karthikeyann/followers","following_url":"https://api.github.com/users/karthikeyann/following{/other_user}","gists_url":"https://api.github.com/users/karthikeyann/gists{/gist_id}","starred_url":"https://api.github.com/users/karthikeyann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthikeyann/subscriptions","organizations_url":"https://api.github.com/users/karthikeyann/orgs","repos_url":"https://api.github.com/users/karthikeyann/repos","events_url":"https://api.github.com/users/karthikeyann/events{/privacy}","received_events_url":"https://api.github.com/users/karthikeyann/received_events","type":"User","site_admin":false},"assignees":[{"login":"karthikeyann","id":6488848,"node_id":"MDQ6VXNlcjY0ODg4NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6488848?v=4","gravatar_id":"","url":"https://api.github.com/users/karthikeyann","html_url":"https://github.com/karthikeyann","followers_url":"https://api.github.com/users/karthikeyann/followers","following_url":"https://api.github.com/users/karthikeyann/following{/other_user}","gists_url":"https://api.github.com/users/karthikeyann/gists{/gist_id}","starred_url":"https://api.github.com/users/karthikeyann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthikeyann/subscriptions","organizations_url":"https://api.github.com/users/karthikeyann/orgs","repos_url":"https://api.github.com/users/karthikeyann/repos","events_url":"https://api.github.com/users/karthikeyann/events{/privacy}","received_events_url":"https://api.github.com/users/karthikeyann/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1013987503,"node_id":"MDU6TGFiZWwxMDEzOTg3NTAz","url":"https://api.github.com/repos/rapidsai/cudf/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"fef2c0","default":false},{"id":1221761547,"node_id":"MDU6TGFiZWwxMjIxNzYxNTQ3","url":"https://api.github.com/repos/rapidsai/cudf/labels/Cython","name":"Cython","color":"f4e85f","default":false},{"id":1139741213,"node_id":"MDU6TGFiZWwxMTM5NzQxMjEz","url":"https://api.github.com/repos/rapidsai/cudf/labels/cuDF%20(Python)","name":"cuDF (Python)","color":"1d76db","default":false},{"id":1139740666,"node_id":"MDU6TGFiZWwxMTM5NzQwNjY2","url":"https://api.github.com/repos/rapidsai/cudf/labels/libcudf%20(C++/CUDA)","name":"libcudf (C++/CUDA)","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rapidsai/cudf/pulls/1845/commits","review_comments_url":"https://api.github.com/repos/rapidsai/cudf/pulls/1845/comments","review_comment_url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapidsai/cudf/issues/1845/comments","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/60aafc76be984e4bd9b0d21e17aaa928564a5523","head":{"label":"karthikeyann:fea-drop_duplicates","ref":"fea-drop_duplicates","sha":"60aafc76be984e4bd9b0d21e17aaa928564a5523","user":{"login":"karthikeyann","id":6488848,"node_id":"MDQ6VXNlcjY0ODg4NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6488848?v=4","gravatar_id":"","url":"https://api.github.com/users/karthikeyann","html_url":"https://github.com/karthikeyann","followers_url":"https://api.github.com/users/karthikeyann/followers","following_url":"https://api.github.com/users/karthikeyann/following{/other_user}","gists_url":"https://api.github.com/users/karthikeyann/gists{/gist_id}","starred_url":"https://api.github.com/users/karthikeyann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthikeyann/subscriptions","organizations_url":"https://api.github.com/users/karthikeyann/orgs","repos_url":"https://api.github.com/users/karthikeyann/repos","events_url":"https://api.github.com/users/karthikeyann/events{/privacy}","received_events_url":"https://api.github.com/users/karthikeyann/received_events","type":"User","site_admin":false},"repo":{"id":185135954,"node_id":"MDEwOlJlcG9zaXRvcnkxODUxMzU5NTQ=","name":"cudf","full_name":"karthikeyann/cudf","private":false,"owner":{"login":"karthikeyann","id":6488848,"node_id":"MDQ6VXNlcjY0ODg4NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6488848?v=4","gravatar_id":"","url":"https://api.github.com/users/karthikeyann","html_url":"https://github.com/karthikeyann","followers_url":"https://api.github.com/users/karthikeyann/followers","following_url":"https://api.github.com/users/karthikeyann/following{/other_user}","gists_url":"https://api.github.com/users/karthikeyann/gists{/gist_id}","starred_url":"https://api.github.com/users/karthikeyann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthikeyann/subscriptions","organizations_url":"https://api.github.com/users/karthikeyann/orgs","repos_url":"https://api.github.com/users/karthikeyann/repos","events_url":"https://api.github.com/users/karthikeyann/events{/privacy}","received_events_url":"https://api.github.com/users/karthikeyann/received_events","type":"User","site_admin":false},"html_url":"https://github.com/karthikeyann/cudf","description":"cuDF - GPU DataFrame Library","fork":true,"url":"https://api.github.com/repos/karthikeyann/cudf","forks_url":"https://api.github.com/repos/karthikeyann/cudf/forks","keys_url":"https://api.github.com/repos/karthikeyann/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karthikeyann/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karthikeyann/cudf/teams","hooks_url":"https://api.github.com/repos/karthikeyann/cudf/hooks","issue_events_url":"https://api.github.com/repos/karthikeyann/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/karthikeyann/cudf/events","assignees_url":"https://api.github.com/repos/karthikeyann/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/karthikeyann/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/karthikeyann/cudf/tags","blobs_url":"https://api.github.com/repos/karthikeyann/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karthikeyann/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karthikeyann/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/karthikeyann/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karthikeyann/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/karthikeyann/cudf/languages","stargazers_url":"https://api.github.com/repos/karthikeyann/cudf/stargazers","contributors_url":"https://api.github.com/repos/karthikeyann/cudf/contributors","subscribers_url":"https://api.github.com/repos/karthikeyann/cudf/subscribers","subscription_url":"https://api.github.com/repos/karthikeyann/cudf/subscription","commits_url":"https://api.github.com/repos/karthikeyann/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/karthikeyann/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/karthikeyann/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/karthikeyann/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/karthikeyann/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/karthikeyann/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karthikeyann/cudf/merges","archive_url":"https://api.github.com/repos/karthikeyann/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karthikeyann/cudf/downloads","issues_url":"https://api.github.com/repos/karthikeyann/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/karthikeyann/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/karthikeyann/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/karthikeyann/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karthikeyann/cudf/labels{/name}","releases_url":"https://api.github.com/repos/karthikeyann/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/karthikeyann/cudf/deployments","created_at":"2019-05-06T06:23:42Z","updated_at":"2019-05-09T18:38:40Z","pushed_at":"2019-06-12T23:58:27Z","git_url":"git://github.com/karthikeyann/cudf.git","ssh_url":"[email protected]:karthikeyann/cudf.git","clone_url":"https://github.com/karthikeyann/cudf.git","svn_url":"https://github.com/karthikeyann/cudf","homepage":"http://rapids.ai","size":21454,"stargazers_count":0,"watchers_count":0,"language":"Cuda","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"branch-0.7"}},"base":{"label":"rapidsai:branch-0.8","ref":"branch-0.8","sha":"2c6888e097b8c4dbb45033b3a7fd12cb30c3cd86","user":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"repo":{"id":90506918,"node_id":"MDEwOlJlcG9zaXRvcnk5MDUwNjkxOA==","name":"cudf","full_name":"rapidsai/cudf","private":false,"owner":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rapidsai/cudf","description":"cuDF - GPU DataFrame Library","fork":false,"url":"https://api.github.com/repos/rapidsai/cudf","forks_url":"https://api.github.com/repos/rapidsai/cudf/forks","keys_url":"https://api.github.com/repos/rapidsai/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapidsai/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapidsai/cudf/teams","hooks_url":"https://api.github.com/repos/rapidsai/cudf/hooks","issue_events_url":"https://api.github.com/repos/rapidsai/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/rapidsai/cudf/events","assignees_url":"https://api.github.com/repos/rapidsai/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/rapidsai/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/rapidsai/cudf/tags","blobs_url":"https://api.github.com/repos/rapidsai/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapidsai/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapidsai/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapidsai/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/rapidsai/cudf/languages","stargazers_url":"https://api.github.com/repos/rapidsai/cudf/stargazers","contributors_url":"https://api.github.com/repos/rapidsai/cudf/contributors","subscribers_url":"https://api.github.com/repos/rapidsai/cudf/subscribers","subscription_url":"https://api.github.com/repos/rapidsai/cudf/subscription","commits_url":"https://api.github.com/repos/rapidsai/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapidsai/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapidsai/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapidsai/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapidsai/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/rapidsai/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapidsai/cudf/merges","archive_url":"https://api.github.com/repos/rapidsai/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapidsai/cudf/downloads","issues_url":"https://api.github.com/repos/rapidsai/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/rapidsai/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/rapidsai/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/rapidsai/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapidsai/cudf/labels{/name}","releases_url":"https://api.github.com/repos/rapidsai/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/rapidsai/cudf/deployments","created_at":"2017-05-07T03:43:37Z","updated_at":"2019-06-13T00:08:24Z","pushed_at":"2019-06-13T00:08:12Z","git_url":"git://github.com/rapidsai/cudf.git","ssh_url":"[email protected]:rapidsai/cudf.git","clone_url":"https://github.com/rapidsai/cudf.git","svn_url":"https://github.com/rapidsai/cudf","homepage":"http://rapids.ai","size":22202,"stargazers_count":1587,"watchers_count":1587,"language":"Cuda","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":231,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":360,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":231,"open_issues":360,"watchers":1587,"default_branch":"branch-0.8"}},"_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/1845"},"html":{"href":"https://github.com/rapidsai/cudf/pull/1845"},"issue":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/1845"},"comments":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/1845/comments"},"review_comments":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/1845/comments"},"review_comment":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/1845/commits"},"statuses":{"href":"https://api.github.com/repos/rapidsai/cudf/statuses/60aafc76be984e4bd9b0d21e17aaa928564a5523"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 90506918,
"name": "rapidsai/cudf",
"url": "https://api.github.com/repos/rapidsai/cudf"
}
|
{
"id": 783069,
"login": "harrism",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/783069?",
"url": "https://api.github.com/users/harrism"
}
|
{
"id": 43887749,
"login": "rapidsai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43887749?",
"url": "https://api.github.com/orgs/rapidsai"
}
| 2019-06-13T00:18:37 |
9811560904
|
{"actor":{"display_login":"harrism"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/359108592","pull_request_review_id":333678330,"id":359108592,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTEwODU5Mg==","diff_hunk":"@@ -86,6 +86,10 @@ union pair_packer<pair_type, std::enable_if_t<is_packable<pair_type>()>> {\n /**\n * Supports concurrent insert, but not concurrent insert and find.\n *\n+ * @note User is responsible for following stream semantics:","path":"cpp/src/hash/concurrent_unordered_map.cuh","position":4,"original_position":4,"commit_id":"de1f139332a1d50c9309db5d899db45d149064ec","original_commit_id":"de1f139332a1d50c9309db5d899db45d149064ec","user":{"login":"harrism","id":783069,"node_id":"MDQ6VXNlcjc4MzA2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/783069?v=4","gravatar_id":"","url":"https://api.github.com/users/harrism","html_url":"https://github.com/harrism","followers_url":"https://api.github.com/users/harrism/followers","following_url":"https://api.github.com/users/harrism/following{/other_user}","gists_url":"https://api.github.com/users/harrism/gists{/gist_id}","starred_url":"https://api.github.com/users/harrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrism/subscriptions","organizations_url":"https://api.github.com/users/harrism/orgs","repos_url":"https://api.github.com/users/harrism/repos","events_url":"https://api.github.com/users/harrism/events{/privacy}","received_events_url":"https://api.github.com/users/harrism/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n * @note The user is responsible for the following stream semantics:\r\n```","created_at":"2019-12-18T01:08:48Z","updated_at":"2019-12-18T01:18:49Z","html_url":"https://github.com/rapidsai/cudf/pull/3629#discussion_r359108592","pull_request_url":"https://api.github.com/repos/rapidsai/cudf/pulls/3629","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/359108592"},"html":{"href":"https://github.com/rapidsai/cudf/pull/3629#discussion_r359108592"},"pull_request":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/3629"}}},"pull_request":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/3629","id":354275989,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0Mjc1OTg5","html_url":"https://github.com/rapidsai/cudf/pull/3629","diff_url":"https://github.com/rapidsai/cudf/pull/3629.diff","patch_url":"https://github.com/rapidsai/cudf/pull/3629.patch","issue_url":"https://api.github.com/repos/rapidsai/cudf/issues/3629","number":3629,"state":"open","locked":false,"title":"[REVIEW] Fix hash map test failure","user":{"login":"rgsl888prabhu","id":42624703,"node_id":"MDQ6VXNlcjQyNjI0NzAz","avatar_url":"https://avatars3.githubusercontent.com/u/42624703?v=4","gravatar_id":"","url":"https://api.github.com/users/rgsl888prabhu","html_url":"https://github.com/rgsl888prabhu","followers_url":"https://api.github.com/users/rgsl888prabhu/followers","following_url":"https://api.github.com/users/rgsl888prabhu/following{/other_user}","gists_url":"https://api.github.com/users/rgsl888prabhu/gists{/gist_id}","starred_url":"https://api.github.com/users/rgsl888prabhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgsl888prabhu/subscriptions","organizations_url":"https://api.github.com/users/rgsl888prabhu/orgs","repos_url":"https://api.github.com/users/rgsl888prabhu/repos","events_url":"https://api.github.com/users/rgsl888prabhu/events{/privacy}","received_events_url":"https://api.github.com/users/rgsl888prabhu/received_events","type":"User","site_admin":false},"body":"<!--\r\n\r\nThank you for contributing to cuDF :)\r\n\r\nHere are some guidelines to help the review process go smoothly.\r\n\r\n1. Please write a description in this text box of the changes that are being\r\n made.\r\n\r\n2. Please ensure that you have written units tests for the changes made/features\r\n added.\r\n\r\n3. There are CI checks in place to enforce that committed code follows our style\r\n and syntax standards. Please see our contribution guide in `CONTRIBUTING.MD`\r\n in the project root for more information about the checks we perform and how\r\n you can run them locally.\r\n\r\n4. If you are closing an issue please use one of the automatic closing words as\r\n noted here: https://help.github.com/articles/closing-issues-using-keywords/\r\n\r\n5. If your pull request is not ready for review but you want to make use of the\r\n continuous integration testing facilities please label it with `[WIP]`.\r\n\r\n6. If your pull request is ready to be reviewed without requiring additional\r\n work on top of it, then remove the `[WIP]` label (if present) and replace\r\n it with `[REVIEW]`. If assistance is required to complete the functionality,\r\n for example when the C/C++ code of a feature is complete but Python bindings\r\n are still required, then add the label `[HELP-REQ]` so that others can triage\r\n and assist. The additional changes then can be implemented on top of the\r\n same PR. If the assistance is done by members of the rapidsAI team, then no\r\n additional actions are required by the creator of the original PR for this,\r\n otherwise the original author of the PR needs to give permission to the\r\n person(s) assisting to commit to their personal fork of the project. If that\r\n doesn't happen then a new PR based on the code of the original PR can be\r\n opened by the person assisting, which then will be the PR that will be\r\n merged.\r\n\r\n7. Once all work has been done and review has taken place please do not add\r\n features or make changes out of the scope of those requested by the reviewer\r\n (doing this just add delays as already reviewed code ends up having to be\r\n re-reviewed/it is hard to tell what is new etc!). Further, please do not\r\n rebase your branch on master/force push/rewrite history, doing any of these\r\n causes the context of any comments made by reviewers to be lost. If\r\n conflicts occur against master they should be resolved by merging master\r\n into the branch used for making the pull request.\r\n\r\nMany thanks in advance for your cooperation!\r\n\r\n-->\r\nHash map test was failing due to missing `cudaStreamSynchronize(stream)`call, this was removed in the #3548 as per the discussion https://github.com/rapidsai/cudf/pull/3548#discussion_r355078040, so calling cuda sync in test.","created_at":"2019-12-17T19:38:16Z","updated_at":"2019-12-18T01:18:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"928814f860e7ab396bbd2f5e2133a55db62dd3ae","assignee":{"login":"rgsl888prabhu","id":42624703,"node_id":"MDQ6VXNlcjQyNjI0NzAz","avatar_url":"https://avatars3.githubusercontent.com/u/42624703?v=4","gravatar_id":"","url":"https://api.github.com/users/rgsl888prabhu","html_url":"https://github.com/rgsl888prabhu","followers_url":"https://api.github.com/users/rgsl888prabhu/followers","following_url":"https://api.github.com/users/rgsl888prabhu/following{/other_user}","gists_url":"https://api.github.com/users/rgsl888prabhu/gists{/gist_id}","starred_url":"https://api.github.com/users/rgsl888prabhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgsl888prabhu/subscriptions","organizations_url":"https://api.github.com/users/rgsl888prabhu/orgs","repos_url":"https://api.github.com/users/rgsl888prabhu/repos","events_url":"https://api.github.com/users/rgsl888prabhu/events{/privacy}","received_events_url":"https://api.github.com/users/rgsl888prabhu/received_events","type":"User","site_admin":false},"assignees":[{"login":"rgsl888prabhu","id":42624703,"node_id":"MDQ6VXNlcjQyNjI0NzAz","avatar_url":"https://avatars3.githubusercontent.com/u/42624703?v=4","gravatar_id":"","url":"https://api.github.com/users/rgsl888prabhu","html_url":"https://github.com/rgsl888prabhu","followers_url":"https://api.github.com/users/rgsl888prabhu/followers","following_url":"https://api.github.com/users/rgsl888prabhu/following{/other_user}","gists_url":"https://api.github.com/users/rgsl888prabhu/gists{/gist_id}","starred_url":"https://api.github.com/users/rgsl888prabhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgsl888prabhu/subscriptions","organizations_url":"https://api.github.com/users/rgsl888prabhu/orgs","repos_url":"https://api.github.com/users/rgsl888prabhu/repos","events_url":"https://api.github.com/users/rgsl888prabhu/events{/privacy}","received_events_url":"https://api.github.com/users/rgsl888prabhu/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cwharris","id":1445368,"node_id":"MDQ6VXNlcjE0NDUzNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1445368?v=4","gravatar_id":"","url":"https://api.github.com/users/cwharris","html_url":"https://github.com/cwharris","followers_url":"https://api.github.com/users/cwharris/followers","following_url":"https://api.github.com/users/cwharris/following{/other_user}","gists_url":"https://api.github.com/users/cwharris/gists{/gist_id}","starred_url":"https://api.github.com/users/cwharris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwharris/subscriptions","organizations_url":"https://api.github.com/users/cwharris/orgs","repos_url":"https://api.github.com/users/cwharris/repos","events_url":"https://api.github.com/users/cwharris/events{/privacy}","received_events_url":"https://api.github.com/users/cwharris/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1013987606,"node_id":"MDU6TGFiZWwxMDEzOTg3NjA2","url":"https://api.github.com/repos/rapidsai/cudf/labels/3%20-%20Ready%20for%20Review","name":"3 - Ready for Review","color":"c2e0c6","default":false,"description":"Ready for review by team"},{"id":1606189448,"node_id":"MDU6TGFiZWwxNjA2MTg5NDQ4","url":"https://api.github.com/repos/rapidsai/cudf/labels/libcudf++","name":"libcudf++","color":"f7832a","default":false,"description":"Relating to porting APIs to libcudf++"}],"milestone":null,"commits_url":"https://api.github.com/repos/rapidsai/cudf/pulls/3629/commits","review_comments_url":"https://api.github.com/repos/rapidsai/cudf/pulls/3629/comments","review_comment_url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapidsai/cudf/issues/3629/comments","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/de1f139332a1d50c9309db5d899db45d149064ec","head":{"label":"rgsl888prabhu:hash_map_test_fail","ref":"hash_map_test_fail","sha":"de1f139332a1d50c9309db5d899db45d149064ec","user":{"login":"rgsl888prabhu","id":42624703,"node_id":"MDQ6VXNlcjQyNjI0NzAz","avatar_url":"https://avatars3.githubusercontent.com/u/42624703?v=4","gravatar_id":"","url":"https://api.github.com/users/rgsl888prabhu","html_url":"https://github.com/rgsl888prabhu","followers_url":"https://api.github.com/users/rgsl888prabhu/followers","following_url":"https://api.github.com/users/rgsl888prabhu/following{/other_user}","gists_url":"https://api.github.com/users/rgsl888prabhu/gists{/gist_id}","starred_url":"https://api.github.com/users/rgsl888prabhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgsl888prabhu/subscriptions","organizations_url":"https://api.github.com/users/rgsl888prabhu/orgs","repos_url":"https://api.github.com/users/rgsl888prabhu/repos","events_url":"https://api.github.com/users/rgsl888prabhu/events{/privacy}","received_events_url":"https://api.github.com/users/rgsl888prabhu/received_events","type":"User","site_admin":false},"repo":{"id":197267093,"node_id":"MDEwOlJlcG9zaXRvcnkxOTcyNjcwOTM=","name":"cudf","full_name":"rgsl888prabhu/cudf","private":false,"owner":{"login":"rgsl888prabhu","id":42624703,"node_id":"MDQ6VXNlcjQyNjI0NzAz","avatar_url":"https://avatars3.githubusercontent.com/u/42624703?v=4","gravatar_id":"","url":"https://api.github.com/users/rgsl888prabhu","html_url":"https://github.com/rgsl888prabhu","followers_url":"https://api.github.com/users/rgsl888prabhu/followers","following_url":"https://api.github.com/users/rgsl888prabhu/following{/other_user}","gists_url":"https://api.github.com/users/rgsl888prabhu/gists{/gist_id}","starred_url":"https://api.github.com/users/rgsl888prabhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgsl888prabhu/subscriptions","organizations_url":"https://api.github.com/users/rgsl888prabhu/orgs","repos_url":"https://api.github.com/users/rgsl888prabhu/repos","events_url":"https://api.github.com/users/rgsl888prabhu/events{/privacy}","received_events_url":"https://api.github.com/users/rgsl888prabhu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rgsl888prabhu/cudf","description":"cuDF - GPU DataFrame Library","fork":true,"url":"https://api.github.com/repos/rgsl888prabhu/cudf","forks_url":"https://api.github.com/repos/rgsl888prabhu/cudf/forks","keys_url":"https://api.github.com/repos/rgsl888prabhu/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgsl888prabhu/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgsl888prabhu/cudf/teams","hooks_url":"https://api.github.com/repos/rgsl888prabhu/cudf/hooks","issue_events_url":"https://api.github.com/repos/rgsl888prabhu/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/rgsl888prabhu/cudf/events","assignees_url":"https://api.github.com/repos/rgsl888prabhu/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/rgsl888prabhu/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/rgsl888prabhu/cudf/tags","blobs_url":"https://api.github.com/repos/rgsl888prabhu/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgsl888prabhu/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgsl888prabhu/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgsl888prabhu/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgsl888prabhu/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/rgsl888prabhu/cudf/languages","stargazers_url":"https://api.github.com/repos/rgsl888prabhu/cudf/stargazers","contributors_url":"https://api.github.com/repos/rgsl888prabhu/cudf/contributors","subscribers_url":"https://api.github.com/repos/rgsl888prabhu/cudf/subscribers","subscription_url":"https://api.github.com/repos/rgsl888prabhu/cudf/subscription","commits_url":"https://api.github.com/repos/rgsl888prabhu/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgsl888prabhu/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgsl888prabhu/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgsl888prabhu/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgsl888prabhu/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/rgsl888prabhu/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgsl888prabhu/cudf/merges","archive_url":"https://api.github.com/repos/rgsl888prabhu/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgsl888prabhu/cudf/downloads","issues_url":"https://api.github.com/repos/rgsl888prabhu/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/rgsl888prabhu/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/rgsl888prabhu/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/rgsl888prabhu/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgsl888prabhu/cudf/labels{/name}","releases_url":"https://api.github.com/repos/rgsl888prabhu/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/rgsl888prabhu/cudf/deployments","created_at":"2019-07-16T20:59:35Z","updated_at":"2019-12-17T20:25:34Z","pushed_at":"2019-12-17T23:33:27Z","git_url":"git://github.com/rgsl888prabhu/cudf.git","ssh_url":"[email protected]:rgsl888prabhu/cudf.git","clone_url":"https://github.com/rgsl888prabhu/cudf.git","svn_url":"https://github.com/rgsl888prabhu/cudf","homepage":"http://rapids.ai","size":40086,"stargazers_count":0,"watchers_count":0,"language":"Cuda","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"branch-0.12"}},"base":{"label":"rapidsai:branch-0.12","ref":"branch-0.12","sha":"fdd9e05edfca91ea18b4ea26ac120ffcef35bf31","user":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"repo":{"id":90506918,"node_id":"MDEwOlJlcG9zaXRvcnk5MDUwNjkxOA==","name":"cudf","full_name":"rapidsai/cudf","private":false,"owner":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rapidsai/cudf","description":"cuDF - GPU DataFrame Library","fork":false,"url":"https://api.github.com/repos/rapidsai/cudf","forks_url":"https://api.github.com/repos/rapidsai/cudf/forks","keys_url":"https://api.github.com/repos/rapidsai/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapidsai/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapidsai/cudf/teams","hooks_url":"https://api.github.com/repos/rapidsai/cudf/hooks","issue_events_url":"https://api.github.com/repos/rapidsai/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/rapidsai/cudf/events","assignees_url":"https://api.github.com/repos/rapidsai/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/rapidsai/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/rapidsai/cudf/tags","blobs_url":"https://api.github.com/repos/rapidsai/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapidsai/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapidsai/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapidsai/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/rapidsai/cudf/languages","stargazers_url":"https://api.github.com/repos/rapidsai/cudf/stargazers","contributors_url":"https://api.github.com/repos/rapidsai/cudf/contributors","subscribers_url":"https://api.github.com/repos/rapidsai/cudf/subscribers","subscription_url":"https://api.github.com/repos/rapidsai/cudf/subscription","commits_url":"https://api.github.com/repos/rapidsai/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapidsai/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapidsai/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapidsai/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapidsai/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/rapidsai/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapidsai/cudf/merges","archive_url":"https://api.github.com/repos/rapidsai/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapidsai/cudf/downloads","issues_url":"https://api.github.com/repos/rapidsai/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/rapidsai/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/rapidsai/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/rapidsai/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapidsai/cudf/labels{/name}","releases_url":"https://api.github.com/repos/rapidsai/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/rapidsai/cudf/deployments","created_at":"2017-05-07T03:43:37Z","updated_at":"2019-12-17T21:48:25Z","pushed_at":"2019-12-18T01:05:21Z","git_url":"git://github.com/rapidsai/cudf.git","ssh_url":"[email protected]:rapidsai/cudf.git","clone_url":"https://github.com/rapidsai/cudf.git","svn_url":"https://github.com/rapidsai/cudf","homepage":"http://rapids.ai","size":40081,"stargazers_count":2329,"watchers_count":2329,"language":"Cuda","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":321,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":557,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":321,"open_issues":557,"watchers":2329,"default_branch":"branch-0.12"}},"_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/3629"},"html":{"href":"https://github.com/rapidsai/cudf/pull/3629"},"issue":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/3629"},"comments":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/3629/comments"},"review_comments":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/3629/comments"},"review_comment":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/3629/commits"},"statuses":{"href":"https://api.github.com/repos/rapidsai/cudf/statuses/de1f139332a1d50c9309db5d899db45d149064ec"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 90506918,
"name": "rapidsai/cudf",
"url": "https://api.github.com/repos/rapidsai/cudf"
}
|
{
"id": 783069,
"login": "harrism",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/783069?",
"url": "https://api.github.com/users/harrism"
}
|
{
"id": 43887749,
"login": "rapidsai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43887749?",
"url": "https://api.github.com/orgs/rapidsai"
}
| 2019-12-18T01:08:48 |
11112382179
|
{"actor":{"display_login":"harrism"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/358546535","pull_request_review_id":332970971,"id":358546535,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODU0NjUzNQ==","diff_hunk":"@@ -104,15 +104,20 @@ inline void throw_cuda_error(cudaError_t error, const char* file,\n cudaGetErrorName(error) + \" \" + cudaGetErrorString(error)});\n }\n \n-inline void check_stream(cudaStream_t stream, const char* file,\n- unsigned int line) {\n+template <bool sync_on_stream>\n+inline void check_cuda(char const* file, unsigned int line,\n+ cudaStream_t stream=0) {\n cudaError_t error{cudaSuccess};\n- error = cudaStreamSynchronize(stream);\n- if (cudaSuccess != error) {\n- throw_cuda_error(error, file, line);\n+ if (sync_on_stream) {\n+ error = cudaStreamSynchronize(stream);\n+ if (cudaSuccess == error) {\n+ error = cudaGetLastError();","path":"cpp/include/cudf/utilities/error.hpp","position":16,"original_position":16,"commit_id":"af9e27b60450c4060883c997ba730a9c17d985e4","original_commit_id":"7beae5ec1a0167805183cb653908db55d13d78c1","user":{"login":"jrhemstad","id":15221289,"node_id":"MDQ6VXNlcjE1MjIxMjg5","avatar_url":"https://avatars1.githubusercontent.com/u/15221289?v=4","gravatar_id":"","url":"https://api.github.com/users/jrhemstad","html_url":"https://github.com/jrhemstad","followers_url":"https://api.github.com/users/jrhemstad/followers","following_url":"https://api.github.com/users/jrhemstad/following{/other_user}","gists_url":"https://api.github.com/users/jrhemstad/gists{/gist_id}","starred_url":"https://api.github.com/users/jrhemstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrhemstad/subscriptions","organizations_url":"https://api.github.com/users/jrhemstad/orgs","repos_url":"https://api.github.com/users/jrhemstad/repos","events_url":"https://api.github.com/users/jrhemstad/events{/privacy}","received_events_url":"https://api.github.com/users/jrhemstad/received_events","type":"User","site_admin":false},"body":"The purpose of #3510 is to add `cudaGetLastError()` to `CUDA_TRY` to reset the error code to `cudaSuccess`. I believe that addresses your concern.","created_at":"2019-12-17T01:00:57Z","updated_at":"2019-12-17T01:00:57Z","html_url":"https://github.com/rapidsai/cudf/pull/3587#discussion_r358546535","pull_request_url":"https://api.github.com/repos/rapidsai/cudf/pulls/3587","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/358546535"},"html":{"href":"https://github.com/rapidsai/cudf/pull/3587#discussion_r358546535"},"pull_request":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/3587"}},"in_reply_to_id":356917939},"pull_request":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/3587","id":352069898,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyMDY5ODk4","html_url":"https://github.com/rapidsai/cudf/pull/3587","diff_url":"https://github.com/rapidsai/cudf/pull/3587.diff","patch_url":"https://github.com/rapidsai/cudf/pull/3587.patch","issue_url":"https://api.github.com/repos/rapidsai/cudf/issues/3587","number":3587,"state":"open","locked":false,"title":"[REVIEW] Merge CHECK_STREAM & CUDA_CHECK_LAST to CHECK_CUDA_ERROR","user":{"login":"seunghwak","id":45857425,"node_id":"MDQ6VXNlcjQ1ODU3NDI1","avatar_url":"https://avatars3.githubusercontent.com/u/45857425?v=4","gravatar_id":"","url":"https://api.github.com/users/seunghwak","html_url":"https://github.com/seunghwak","followers_url":"https://api.github.com/users/seunghwak/followers","following_url":"https://api.github.com/users/seunghwak/following{/other_user}","gists_url":"https://api.github.com/users/seunghwak/gists{/gist_id}","starred_url":"https://api.github.com/users/seunghwak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seunghwak/subscriptions","organizations_url":"https://api.github.com/users/seunghwak/orgs","repos_url":"https://api.github.com/users/seunghwak/repos","events_url":"https://api.github.com/users/seunghwak/events{/privacy}","received_events_url":"https://api.github.com/users/seunghwak/received_events","type":"User","site_admin":false},"body":"This PR addresses https://github.com/rapidsai/cudf/issues/3514 and merges CHECK_STREAM & CUDA_CHECK_LAST to CHECK_CUDA_ERROR\r\n","created_at":"2019-12-11T19:09:21Z","updated_at":"2019-12-17T01:00:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1bf4bc97c8e9529aac4d7b7184c6869ec50e572","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rapidsai/cudf/pulls/3587/commits","review_comments_url":"https://api.github.com/repos/rapidsai/cudf/pulls/3587/comments","review_comment_url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapidsai/cudf/issues/3587/comments","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/af9e27b60450c4060883c997ba730a9c17d985e4","head":{"label":"seunghwak:fea_ext_check_stream","ref":"fea_ext_check_stream","sha":"af9e27b60450c4060883c997ba730a9c17d985e4","user":{"login":"seunghwak","id":45857425,"node_id":"MDQ6VXNlcjQ1ODU3NDI1","avatar_url":"https://avatars3.githubusercontent.com/u/45857425?v=4","gravatar_id":"","url":"https://api.github.com/users/seunghwak","html_url":"https://github.com/seunghwak","followers_url":"https://api.github.com/users/seunghwak/followers","following_url":"https://api.github.com/users/seunghwak/following{/other_user}","gists_url":"https://api.github.com/users/seunghwak/gists{/gist_id}","starred_url":"https://api.github.com/users/seunghwak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seunghwak/subscriptions","organizations_url":"https://api.github.com/users/seunghwak/orgs","repos_url":"https://api.github.com/users/seunghwak/repos","events_url":"https://api.github.com/users/seunghwak/events{/privacy}","received_events_url":"https://api.github.com/users/seunghwak/received_events","type":"User","site_admin":false},"repo":{"id":213706014,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM3MDYwMTQ=","name":"cudf","full_name":"seunghwak/cudf","private":false,"owner":{"login":"seunghwak","id":45857425,"node_id":"MDQ6VXNlcjQ1ODU3NDI1","avatar_url":"https://avatars3.githubusercontent.com/u/45857425?v=4","gravatar_id":"","url":"https://api.github.com/users/seunghwak","html_url":"https://github.com/seunghwak","followers_url":"https://api.github.com/users/seunghwak/followers","following_url":"https://api.github.com/users/seunghwak/following{/other_user}","gists_url":"https://api.github.com/users/seunghwak/gists{/gist_id}","starred_url":"https://api.github.com/users/seunghwak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seunghwak/subscriptions","organizations_url":"https://api.github.com/users/seunghwak/orgs","repos_url":"https://api.github.com/users/seunghwak/repos","events_url":"https://api.github.com/users/seunghwak/events{/privacy}","received_events_url":"https://api.github.com/users/seunghwak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/seunghwak/cudf","description":"cuDF - GPU DataFrame Library","fork":true,"url":"https://api.github.com/repos/seunghwak/cudf","forks_url":"https://api.github.com/repos/seunghwak/cudf/forks","keys_url":"https://api.github.com/repos/seunghwak/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seunghwak/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seunghwak/cudf/teams","hooks_url":"https://api.github.com/repos/seunghwak/cudf/hooks","issue_events_url":"https://api.github.com/repos/seunghwak/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/seunghwak/cudf/events","assignees_url":"https://api.github.com/repos/seunghwak/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/seunghwak/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/seunghwak/cudf/tags","blobs_url":"https://api.github.com/repos/seunghwak/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seunghwak/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seunghwak/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/seunghwak/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seunghwak/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/seunghwak/cudf/languages","stargazers_url":"https://api.github.com/repos/seunghwak/cudf/stargazers","contributors_url":"https://api.github.com/repos/seunghwak/cudf/contributors","subscribers_url":"https://api.github.com/repos/seunghwak/cudf/subscribers","subscription_url":"https://api.github.com/repos/seunghwak/cudf/subscription","commits_url":"https://api.github.com/repos/seunghwak/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/seunghwak/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/seunghwak/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/seunghwak/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/seunghwak/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/seunghwak/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seunghwak/cudf/merges","archive_url":"https://api.github.com/repos/seunghwak/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seunghwak/cudf/downloads","issues_url":"https://api.github.com/repos/seunghwak/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/seunghwak/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/seunghwak/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/seunghwak/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seunghwak/cudf/labels{/name}","releases_url":"https://api.github.com/repos/seunghwak/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/seunghwak/cudf/deployments","created_at":"2019-10-08T17:18:49Z","updated_at":"2019-10-08T17:18:50Z","pushed_at":"2019-12-13T23:09:25Z","git_url":"git://github.com/seunghwak/cudf.git","ssh_url":"[email protected]:seunghwak/cudf.git","clone_url":"https://github.com/seunghwak/cudf.git","svn_url":"https://github.com/seunghwak/cudf","homepage":"http://rapids.ai","size":39950,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"branch-0.10"}},"base":{"label":"rapidsai:branch-0.12","ref":"branch-0.12","sha":"493817daa94ec3c3cb26e1c61cbf8983cf459d1e","user":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"repo":{"id":90506918,"node_id":"MDEwOlJlcG9zaXRvcnk5MDUwNjkxOA==","name":"cudf","full_name":"rapidsai/cudf","private":false,"owner":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rapidsai/cudf","description":"cuDF - GPU DataFrame Library","fork":false,"url":"https://api.github.com/repos/rapidsai/cudf","forks_url":"https://api.github.com/repos/rapidsai/cudf/forks","keys_url":"https://api.github.com/repos/rapidsai/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapidsai/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapidsai/cudf/teams","hooks_url":"https://api.github.com/repos/rapidsai/cudf/hooks","issue_events_url":"https://api.github.com/repos/rapidsai/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/rapidsai/cudf/events","assignees_url":"https://api.github.com/repos/rapidsai/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/rapidsai/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/rapidsai/cudf/tags","blobs_url":"https://api.github.com/repos/rapidsai/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapidsai/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapidsai/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapidsai/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/rapidsai/cudf/languages","stargazers_url":"https://api.github.com/repos/rapidsai/cudf/stargazers","contributors_url":"https://api.github.com/repos/rapidsai/cudf/contributors","subscribers_url":"https://api.github.com/repos/rapidsai/cudf/subscribers","subscription_url":"https://api.github.com/repos/rapidsai/cudf/subscription","commits_url":"https://api.github.com/repos/rapidsai/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapidsai/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapidsai/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapidsai/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapidsai/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/rapidsai/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapidsai/cudf/merges","archive_url":"https://api.github.com/repos/rapidsai/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapidsai/cudf/downloads","issues_url":"https://api.github.com/repos/rapidsai/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/rapidsai/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/rapidsai/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/rapidsai/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapidsai/cudf/labels{/name}","releases_url":"https://api.github.com/repos/rapidsai/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/rapidsai/cudf/deployments","created_at":"2017-05-07T03:43:37Z","updated_at":"2019-12-17T00:58:27Z","pushed_at":"2019-12-17T00:58:25Z","git_url":"git://github.com/rapidsai/cudf.git","ssh_url":"[email protected]:rapidsai/cudf.git","clone_url":"https://github.com/rapidsai/cudf.git","svn_url":"https://github.com/rapidsai/cudf","homepage":"http://rapids.ai","size":40085,"stargazers_count":2324,"watchers_count":2324,"language":"Cuda","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":320,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":549,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":320,"open_issues":549,"watchers":2324,"default_branch":"branch-0.12"}},"_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/3587"},"html":{"href":"https://github.com/rapidsai/cudf/pull/3587"},"issue":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/3587"},"comments":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/3587/comments"},"review_comments":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/3587/comments"},"review_comment":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/3587/commits"},"statuses":{"href":"https://api.github.com/repos/rapidsai/cudf/statuses/af9e27b60450c4060883c997ba730a9c17d985e4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 90506918,
"name": "rapidsai/cudf",
"url": "https://api.github.com/repos/rapidsai/cudf"
}
|
{
"id": 15221289,
"login": "jrhemstad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15221289?",
"url": "https://api.github.com/users/jrhemstad"
}
|
{
"id": 43887749,
"login": "rapidsai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43887749?",
"url": "https://api.github.com/orgs/rapidsai"
}
| 2019-12-17T01:00:57 |
11102696189
|
{"actor":{"display_login":"jrhemstad"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/comments/259992211","pull_request_review_id":207600070,"id":259992211,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTk5MjIxMQ==","diff_hunk":"@@ -8,7 +8,13 @@ export class MathTests {\n @TestCase(\"Math.cos()\", \"math.cos();\")","path":"test/unit/math.spec.ts","position":1,"original_position":1,"commit_id":"7e91052f4bab0ea97417b91f7270631120e1b9b2","original_commit_id":"7e91052f4bab0ea97417b91f7270631120e1b9b2","user":{"login":"tomblind","id":26638278,"node_id":"MDQ6VXNlcjI2NjM4Mjc4","avatar_url":"https://avatars3.githubusercontent.com/u/26638278?v=4","gravatar_id":"","url":"https://api.github.com/users/tomblind","html_url":"https://github.com/tomblind","followers_url":"https://api.github.com/users/tomblind/followers","following_url":"https://api.github.com/users/tomblind/following{/other_user}","gists_url":"https://api.github.com/users/tomblind/gists{/gist_id}","starred_url":"https://api.github.com/users/tomblind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomblind/subscriptions","organizations_url":"https://api.github.com/users/tomblind/orgs","repos_url":"https://api.github.com/users/tomblind/repos","events_url":"https://api.github.com/users/tomblind/events{/privacy}","received_events_url":"https://api.github.com/users/tomblind/received_events","type":"User","site_admin":false},"body":"There are tests for `Math.PI` and `Math.E`. Should I add a test for every one?\r\n\r\nAlso, I'm not sure we should do execute tests since there could be inconsistencies with precision.","created_at":"2019-02-25T19:55:14Z","updated_at":"2019-02-25T19:55:14Z","html_url":"https://github.com/TypeScriptToLua/TypeScriptToLua/pull/450#discussion_r259992211","pull_request_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/450","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/comments/259992211"},"html":{"href":"https://github.com/TypeScriptToLua/TypeScriptToLua/pull/450#discussion_r259992211"},"pull_request":{"href":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/450"}},"in_reply_to_id":259879907},"pull_request":{"url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/450","id":255915054,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1OTE1MDU0","html_url":"https://github.com/TypeScriptToLua/TypeScriptToLua/pull/450","diff_url":"https://github.com/TypeScriptToLua/TypeScriptToLua/pull/450.diff","patch_url":"https://github.com/TypeScriptToLua/TypeScriptToLua/pull/450.patch","issue_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues/450","number":450,"state":"open","locked":false,"title":"implemented more math function and value conversions","user":{"login":"tomblind","id":26638278,"node_id":"MDQ6VXNlcjI2NjM4Mjc4","avatar_url":"https://avatars3.githubusercontent.com/u/26638278?v=4","gravatar_id":"","url":"https://api.github.com/users/tomblind","html_url":"https://github.com/tomblind","followers_url":"https://api.github.com/users/tomblind/followers","following_url":"https://api.github.com/users/tomblind/following{/other_user}","gists_url":"https://api.github.com/users/tomblind/gists{/gist_id}","starred_url":"https://api.github.com/users/tomblind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomblind/subscriptions","organizations_url":"https://api.github.com/users/tomblind/orgs","repos_url":"https://api.github.com/users/tomblind/repos","events_url":"https://api.github.com/users/tomblind/events{/privacy}","received_events_url":"https://api.github.com/users/tomblind/received_events","type":"User","site_admin":false},"body":"fixes #438 \r\n\r\nSince I had to restructure things a bit for Math.round, I went ahead and implemented some of the other low-hanging-fruit math function conversions.\r\n","created_at":"2019-02-25T14:40:30Z","updated_at":"2019-02-25T19:55:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bae9d1cad55a68acb94a0fc5c689368266257fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/450/commits","review_comments_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/450/comments","review_comment_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues/450/comments","statuses_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/statuses/7e91052f4bab0ea97417b91f7270631120e1b9b2","head":{"label":"TypeScriptToLua:math-update","ref":"math-update","sha":"7e91052f4bab0ea97417b91f7270631120e1b9b2","user":{"login":"TypeScriptToLua","id":44121206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MTIxMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/44121206?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeScriptToLua","html_url":"https://github.com/TypeScriptToLua","followers_url":"https://api.github.com/users/TypeScriptToLua/followers","following_url":"https://api.github.com/users/TypeScriptToLua/following{/other_user}","gists_url":"https://api.github.com/users/TypeScriptToLua/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeScriptToLua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeScriptToLua/subscriptions","organizations_url":"https://api.github.com/users/TypeScriptToLua/orgs","repos_url":"https://api.github.com/users/TypeScriptToLua/repos","events_url":"https://api.github.com/users/TypeScriptToLua/events{/privacy}","received_events_url":"https://api.github.com/users/TypeScriptToLua/received_events","type":"Organization","site_admin":false},"repo":{"id":115876595,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU4NzY1OTU=","name":"TypeScriptToLua","full_name":"TypeScriptToLua/TypeScriptToLua","private":false,"owner":{"login":"TypeScriptToLua","id":44121206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MTIxMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/44121206?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeScriptToLua","html_url":"https://github.com/TypeScriptToLua","followers_url":"https://api.github.com/users/TypeScriptToLua/followers","following_url":"https://api.github.com/users/TypeScriptToLua/following{/other_user}","gists_url":"https://api.github.com/users/TypeScriptToLua/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeScriptToLua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeScriptToLua/subscriptions","organizations_url":"https://api.github.com/users/TypeScriptToLua/orgs","repos_url":"https://api.github.com/users/TypeScriptToLua/repos","events_url":"https://api.github.com/users/TypeScriptToLua/events{/privacy}","received_events_url":"https://api.github.com/users/TypeScriptToLua/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TypeScriptToLua/TypeScriptToLua","description":"Typescript to lua transpiler. https://typescripttolua.github.io/","fork":false,"url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua","forks_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/forks","keys_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/teams","hooks_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/hooks","issue_events_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues/events{/number}","events_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/events","assignees_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/assignees{/user}","branches_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/branches{/branch}","tags_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/tags","blobs_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/refs{/sha}","trees_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/statuses/{sha}","languages_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/languages","stargazers_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/stargazers","contributors_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/contributors","subscribers_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/subscribers","subscription_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/subscription","commits_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/commits{/sha}","git_commits_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/commits{/sha}","comments_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/comments{/number}","issue_comment_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues/comments{/number}","contents_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/contents/{+path}","compare_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/merges","archive_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/downloads","issues_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues{/number}","pulls_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls{/number}","milestones_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/milestones{/number}","notifications_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/labels{/name}","releases_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/releases{/id}","deployments_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/deployments","created_at":"2017-12-31T17:26:03Z","updated_at":"2019-02-24T23:01:39Z","pushed_at":"2019-02-25T14:40:31Z","git_url":"git://github.com/TypeScriptToLua/TypeScriptToLua.git","ssh_url":"[email protected]:TypeScriptToLua/TypeScriptToLua.git","clone_url":"https://github.com/TypeScriptToLua/TypeScriptToLua.git","svn_url":"https://github.com/TypeScriptToLua/TypeScriptToLua","homepage":"","size":1965,"stargazers_count":137,"watchers_count":137,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":43,"watchers":137,"default_branch":"master"}},"base":{"label":"TypeScriptToLua:master","ref":"master","sha":"2a8846afb4b1421dff304b419b2db81af8ce5377","user":{"login":"TypeScriptToLua","id":44121206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MTIxMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/44121206?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeScriptToLua","html_url":"https://github.com/TypeScriptToLua","followers_url":"https://api.github.com/users/TypeScriptToLua/followers","following_url":"https://api.github.com/users/TypeScriptToLua/following{/other_user}","gists_url":"https://api.github.com/users/TypeScriptToLua/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeScriptToLua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeScriptToLua/subscriptions","organizations_url":"https://api.github.com/users/TypeScriptToLua/orgs","repos_url":"https://api.github.com/users/TypeScriptToLua/repos","events_url":"https://api.github.com/users/TypeScriptToLua/events{/privacy}","received_events_url":"https://api.github.com/users/TypeScriptToLua/received_events","type":"Organization","site_admin":false},"repo":{"id":115876595,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU4NzY1OTU=","name":"TypeScriptToLua","full_name":"TypeScriptToLua/TypeScriptToLua","private":false,"owner":{"login":"TypeScriptToLua","id":44121206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MTIxMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/44121206?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeScriptToLua","html_url":"https://github.com/TypeScriptToLua","followers_url":"https://api.github.com/users/TypeScriptToLua/followers","following_url":"https://api.github.com/users/TypeScriptToLua/following{/other_user}","gists_url":"https://api.github.com/users/TypeScriptToLua/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeScriptToLua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeScriptToLua/subscriptions","organizations_url":"https://api.github.com/users/TypeScriptToLua/orgs","repos_url":"https://api.github.com/users/TypeScriptToLua/repos","events_url":"https://api.github.com/users/TypeScriptToLua/events{/privacy}","received_events_url":"https://api.github.com/users/TypeScriptToLua/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TypeScriptToLua/TypeScriptToLua","description":"Typescript to lua transpiler. https://typescripttolua.github.io/","fork":false,"url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua","forks_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/forks","keys_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/teams","hooks_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/hooks","issue_events_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues/events{/number}","events_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/events","assignees_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/assignees{/user}","branches_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/branches{/branch}","tags_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/tags","blobs_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/refs{/sha}","trees_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/statuses/{sha}","languages_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/languages","stargazers_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/stargazers","contributors_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/contributors","subscribers_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/subscribers","subscription_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/subscription","commits_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/commits{/sha}","git_commits_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/git/commits{/sha}","comments_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/comments{/number}","issue_comment_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues/comments{/number}","contents_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/contents/{+path}","compare_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/merges","archive_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/downloads","issues_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues{/number}","pulls_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls{/number}","milestones_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/milestones{/number}","notifications_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/labels{/name}","releases_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/releases{/id}","deployments_url":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/deployments","created_at":"2017-12-31T17:26:03Z","updated_at":"2019-02-24T23:01:39Z","pushed_at":"2019-02-25T14:40:31Z","git_url":"git://github.com/TypeScriptToLua/TypeScriptToLua.git","ssh_url":"[email protected]:TypeScriptToLua/TypeScriptToLua.git","clone_url":"https://github.com/TypeScriptToLua/TypeScriptToLua.git","svn_url":"https://github.com/TypeScriptToLua/TypeScriptToLua","homepage":"","size":1965,"stargazers_count":137,"watchers_count":137,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":43,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/450"},"html":{"href":"https://github.com/TypeScriptToLua/TypeScriptToLua/pull/450"},"issue":{"href":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues/450"},"comments":{"href":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua/statuses/7e91052f4bab0ea97417b91f7270631120e1b9b2"}},"author_association":"COLLABORATOR"}}
|
{
"id": 115876595,
"name": "TypeScriptToLua/TypeScriptToLua",
"url": "https://api.github.com/repos/TypeScriptToLua/TypeScriptToLua"
}
|
{
"id": 26638278,
"login": "tomblind",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26638278?",
"url": "https://api.github.com/users/tomblind"
}
|
{
"id": 44121206,
"login": "TypeScriptToLua",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44121206?",
"url": "https://api.github.com/orgs/TypeScriptToLua"
}
| 2019-02-25T19:55:14 |
9133076961
|
{"actor":{"display_login":"tomblind"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/comments/334614586","pull_request_review_id":301478345,"id":334614586,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDYxNDU4Ng==","diff_hunk":"@@ -3,19 +3,43 @@\n # Declare variables to be passed into your templates.\n \n # Check with Flowmill for guidance on expected resource usage, if you would like to set limits.\n+\n+# Configuration for Flowmill's kernel collector\n agent:\n- repository: 966881513036.dkr.ecr.us-east-1.amazonaws.com/flowmill/flowmill-agent\n- tag: 0.7.15.c97d8410\n+ repository: docker.io/flowmill/agent\n+ tag: v0.8.0\n+ pullPolicy: IfNotPresent\n+ resources: {}\n+ args:\n+ - --config-file\n+ - /etc/flowmill/config.yaml","path":"values.yaml","position":15,"original_position":15,"commit_id":"cf63ed9b816418a5457f1056627aaf9a59e30768","original_commit_id":"cf63ed9b816418a5457f1056627aaf9a59e30768","user":{"login":"juchem","id":1767404,"node_id":"MDQ6VXNlcjE3Njc0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1767404?v=4","gravatar_id":"","url":"https://api.github.com/users/juchem","html_url":"https://github.com/juchem","followers_url":"https://api.github.com/users/juchem/followers","following_url":"https://api.github.com/users/juchem/following{/other_user}","gists_url":"https://api.github.com/users/juchem/gists{/gist_id}","starred_url":"https://api.github.com/users/juchem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juchem/subscriptions","organizations_url":"https://api.github.com/users/juchem/orgs","repos_url":"https://api.github.com/users/juchem/repos","events_url":"https://api.github.com/users/juchem/events{/privacy}","received_events_url":"https://api.github.com/users/juchem/received_events","type":"User","site_admin":false},"body":"I'm not sure it should. This file is optional and contains user defined labels.\r\nWe probably need better documentation for it. Not sure who's using it.","created_at":"2019-10-14T18:43:09Z","updated_at":"2019-10-14T18:43:09Z","html_url":"https://github.com/Flowmill/flowmill-k8s/pull/8#discussion_r334614586","pull_request_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/comments/334614586"},"html":{"href":"https://github.com/Flowmill/flowmill-k8s/pull/8#discussion_r334614586"},"pull_request":{"href":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/8"}},"in_reply_to_id":334613611},"pull_request":{"url":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/8","id":327923752,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3OTIzNzUy","html_url":"https://github.com/Flowmill/flowmill-k8s/pull/8","diff_url":"https://github.com/Flowmill/flowmill-k8s/pull/8.diff","patch_url":"https://github.com/Flowmill/flowmill-k8s/pull/8.patch","issue_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues/8","number":8,"state":"open","locked":false,"title":"Changes to support agent keys and dockerhub deployment","user":{"login":"mikecohen","id":5466196,"node_id":"MDQ6VXNlcjU0NjYxOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5466196?v=4","gravatar_id":"","url":"https://api.github.com/users/mikecohen","html_url":"https://github.com/mikecohen","followers_url":"https://api.github.com/users/mikecohen/followers","following_url":"https://api.github.com/users/mikecohen/following{/other_user}","gists_url":"https://api.github.com/users/mikecohen/gists{/gist_id}","starred_url":"https://api.github.com/users/mikecohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikecohen/subscriptions","organizations_url":"https://api.github.com/users/mikecohen/orgs","repos_url":"https://api.github.com/users/mikecohen/repos","events_url":"https://api.github.com/users/mikecohen/events{/privacy}","received_events_url":"https://api.github.com/users/mikecohen/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change isโ[<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/flowmill/flowmill-k8s/8)\n<!-- Reviewable:end -->\n","created_at":"2019-10-14T18:35:27Z","updated_at":"2019-10-14T18:43:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f99980a8fcd4a2406184f79b28a95f8f9d2e1ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues/8/comments","statuses_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/statuses/cf63ed9b816418a5457f1056627aaf9a59e30768","head":{"label":"Flowmill:mcohen-agentkey","ref":"mcohen-agentkey","sha":"cf63ed9b816418a5457f1056627aaf9a59e30768","user":{"login":"Flowmill","id":44622882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NjIyODgy","avatar_url":"https://avatars3.githubusercontent.com/u/44622882?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowmill","html_url":"https://github.com/Flowmill","followers_url":"https://api.github.com/users/Flowmill/followers","following_url":"https://api.github.com/users/Flowmill/following{/other_user}","gists_url":"https://api.github.com/users/Flowmill/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowmill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowmill/subscriptions","organizations_url":"https://api.github.com/users/Flowmill/orgs","repos_url":"https://api.github.com/users/Flowmill/repos","events_url":"https://api.github.com/users/Flowmill/events{/privacy}","received_events_url":"https://api.github.com/users/Flowmill/received_events","type":"Organization","site_admin":false},"repo":{"id":162490734,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI0OTA3MzQ=","name":"flowmill-k8s","full_name":"Flowmill/flowmill-k8s","private":false,"owner":{"login":"Flowmill","id":44622882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NjIyODgy","avatar_url":"https://avatars3.githubusercontent.com/u/44622882?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowmill","html_url":"https://github.com/Flowmill","followers_url":"https://api.github.com/users/Flowmill/followers","following_url":"https://api.github.com/users/Flowmill/following{/other_user}","gists_url":"https://api.github.com/users/Flowmill/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowmill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowmill/subscriptions","organizations_url":"https://api.github.com/users/Flowmill/orgs","repos_url":"https://api.github.com/users/Flowmill/repos","events_url":"https://api.github.com/users/Flowmill/events{/privacy}","received_events_url":"https://api.github.com/users/Flowmill/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Flowmill/flowmill-k8s","description":"Helm chart for deploying the Flowmill monitoring services to your Kubernetes cluster","fork":false,"url":"https://api.github.com/repos/Flowmill/flowmill-k8s","forks_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/forks","keys_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/teams","hooks_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/hooks","issue_events_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/events","assignees_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/tags","blobs_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/languages","stargazers_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/stargazers","contributors_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/contributors","subscribers_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/subscribers","subscription_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/subscription","commits_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/merges","archive_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/downloads","issues_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/labels{/name}","releases_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/deployments","created_at":"2018-12-19T21:05:52Z","updated_at":"2019-07-25T16:44:07Z","pushed_at":"2019-10-14T18:35:33Z","git_url":"git://github.com/Flowmill/flowmill-k8s.git","ssh_url":"[email protected]:Flowmill/flowmill-k8s.git","clone_url":"https://github.com/Flowmill/flowmill-k8s.git","svn_url":"https://github.com/Flowmill/flowmill-k8s","homepage":null,"size":26,"stargazers_count":2,"watchers_count":2,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"Flowmill:master","ref":"master","sha":"f385c5962f8b9ddc15320e9cab5eb8cbf01cc89d","user":{"login":"Flowmill","id":44622882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NjIyODgy","avatar_url":"https://avatars3.githubusercontent.com/u/44622882?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowmill","html_url":"https://github.com/Flowmill","followers_url":"https://api.github.com/users/Flowmill/followers","following_url":"https://api.github.com/users/Flowmill/following{/other_user}","gists_url":"https://api.github.com/users/Flowmill/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowmill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowmill/subscriptions","organizations_url":"https://api.github.com/users/Flowmill/orgs","repos_url":"https://api.github.com/users/Flowmill/repos","events_url":"https://api.github.com/users/Flowmill/events{/privacy}","received_events_url":"https://api.github.com/users/Flowmill/received_events","type":"Organization","site_admin":false},"repo":{"id":162490734,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI0OTA3MzQ=","name":"flowmill-k8s","full_name":"Flowmill/flowmill-k8s","private":false,"owner":{"login":"Flowmill","id":44622882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NjIyODgy","avatar_url":"https://avatars3.githubusercontent.com/u/44622882?v=4","gravatar_id":"","url":"https://api.github.com/users/Flowmill","html_url":"https://github.com/Flowmill","followers_url":"https://api.github.com/users/Flowmill/followers","following_url":"https://api.github.com/users/Flowmill/following{/other_user}","gists_url":"https://api.github.com/users/Flowmill/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowmill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowmill/subscriptions","organizations_url":"https://api.github.com/users/Flowmill/orgs","repos_url":"https://api.github.com/users/Flowmill/repos","events_url":"https://api.github.com/users/Flowmill/events{/privacy}","received_events_url":"https://api.github.com/users/Flowmill/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Flowmill/flowmill-k8s","description":"Helm chart for deploying the Flowmill monitoring services to your Kubernetes cluster","fork":false,"url":"https://api.github.com/repos/Flowmill/flowmill-k8s","forks_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/forks","keys_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/teams","hooks_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/hooks","issue_events_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/events","assignees_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/tags","blobs_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/languages","stargazers_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/stargazers","contributors_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/contributors","subscribers_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/subscribers","subscription_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/subscription","commits_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/merges","archive_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/downloads","issues_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/labels{/name}","releases_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/Flowmill/flowmill-k8s/deployments","created_at":"2018-12-19T21:05:52Z","updated_at":"2019-07-25T16:44:07Z","pushed_at":"2019-10-14T18:35:33Z","git_url":"git://github.com/Flowmill/flowmill-k8s.git","ssh_url":"[email protected]:Flowmill/flowmill-k8s.git","clone_url":"https://github.com/Flowmill/flowmill-k8s.git","svn_url":"https://github.com/Flowmill/flowmill-k8s","homepage":null,"size":26,"stargazers_count":2,"watchers_count":2,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/8"},"html":{"href":"https://github.com/Flowmill/flowmill-k8s/pull/8"},"issue":{"href":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues/8"},"comments":{"href":"https://api.github.com/repos/Flowmill/flowmill-k8s/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Flowmill/flowmill-k8s/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Flowmill/flowmill-k8s/statuses/cf63ed9b816418a5457f1056627aaf9a59e30768"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 162490734,
"name": "Flowmill/flowmill-k8s",
"url": "https://api.github.com/repos/Flowmill/flowmill-k8s"
}
|
{
"id": 1767404,
"login": "juchem",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1767404?",
"url": "https://api.github.com/users/juchem"
}
|
{
"id": 44622882,
"login": "Flowmill",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44622882?",
"url": "https://api.github.com/orgs/Flowmill"
}
| 2019-10-14T18:43:09 |
10627333874
|
{"actor":{"display_login":"juchem"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/comments/293686831","pull_request_review_id":249739481,"id":293686831,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzY4NjgzMQ==","diff_hunk":"@@ -0,0 +1,29 @@\n+import { BRAG, CONFESS, FRONT_END, BACK_END, DEV_OPS } from '../constants/buttonVariants';","path":"src/utils/generateColors.js","position":1,"original_position":1,"commit_id":"128dd6ac5f5607676bf153c52b9a25565023bb19","original_commit_id":"128dd6ac5f5607676bf153c52b9a25565023bb19","user":{"login":"mgolawski","id":9100242,"node_id":"MDQ6VXNlcjkxMDAyNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/9100242?v=4","gravatar_id":"","url":"https://api.github.com/users/mgolawski","html_url":"https://github.com/mgolawski","followers_url":"https://api.github.com/users/mgolawski/followers","following_url":"https://api.github.com/users/mgolawski/following{/other_user}","gists_url":"https://api.github.com/users/mgolawski/gists{/gist_id}","starred_url":"https://api.github.com/users/mgolawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgolawski/subscriptions","organizations_url":"https://api.github.com/users/mgolawski/orgs","repos_url":"https://api.github.com/users/mgolawski/repos","events_url":"https://api.github.com/users/mgolawski/events{/privacy}","received_events_url":"https://api.github.com/users/mgolawski/received_events","type":"User","site_admin":false},"body":"Use colour variants instead of buttonVariants, and use the same in generateTheme\r\n","created_at":"2019-06-14T07:20:56Z","updated_at":"2019-06-14T07:31:13Z","html_url":"https://github.com/BuildIt-Poland/daily-routine/pull/21#discussion_r293686831","pull_request_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/21","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/comments/293686831"},"html":{"href":"https://github.com/BuildIt-Poland/daily-routine/pull/21#discussion_r293686831"},"pull_request":{"href":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/21"}},"in_reply_to_id":293686770},"pull_request":{"url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/21","id":287931429,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3OTMxNDI5","html_url":"https://github.com/BuildIt-Poland/daily-routine/pull/21","diff_url":"https://github.com/BuildIt-Poland/daily-routine/pull/21.diff","patch_url":"https://github.com/BuildIt-Poland/daily-routine/pull/21.patch","issue_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues/21","number":21,"state":"open","locked":false,"title":"[DR-8] Roles buttons","user":{"login":"maciejhein","id":45594475,"node_id":"MDQ6VXNlcjQ1NTk0NDc1","avatar_url":"https://avatars3.githubusercontent.com/u/45594475?v=4","gravatar_id":"","url":"https://api.github.com/users/maciejhein","html_url":"https://github.com/maciejhein","followers_url":"https://api.github.com/users/maciejhein/followers","following_url":"https://api.github.com/users/maciejhein/following{/other_user}","gists_url":"https://api.github.com/users/maciejhein/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejhein/subscriptions","organizations_url":"https://api.github.com/users/maciejhein/orgs","repos_url":"https://api.github.com/users/maciejhein/repos","events_url":"https://api.github.com/users/maciejhein/events{/privacy}","received_events_url":"https://api.github.com/users/maciejhein/received_events","type":"User","site_admin":false},"body":"[#JIRAID](https://digitalrig.atlassian.net/browse/DR-8) #Roles buttons\r\n\r\n# Description \r\n\r\n\r\n\r\n## Checklist:\r\n\r\n- [ ] RoleButton\r\n- [ ] FrontEndButton\r\n- [ ] DevOpsButton\r\n- [ ] BackEndButton\r\n","created_at":"2019-06-13T13:38:42Z","updated_at":"2019-06-14T07:31:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4280e7519474c2814fef4fb652b43c5d12b0c35","assignee":null,"assignees":[],"requested_reviewers":[{"login":"blurbyte","id":20565536,"node_id":"MDQ6VXNlcjIwNTY1NTM2","avatar_url":"https://avatars0.githubusercontent.com/u/20565536?v=4","gravatar_id":"","url":"https://api.github.com/users/blurbyte","html_url":"https://github.com/blurbyte","followers_url":"https://api.github.com/users/blurbyte/followers","following_url":"https://api.github.com/users/blurbyte/following{/other_user}","gists_url":"https://api.github.com/users/blurbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/blurbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blurbyte/subscriptions","organizations_url":"https://api.github.com/users/blurbyte/orgs","repos_url":"https://api.github.com/users/blurbyte/repos","events_url":"https://api.github.com/users/blurbyte/events{/privacy}","received_events_url":"https://api.github.com/users/blurbyte/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/21/commits","review_comments_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/21/comments","review_comment_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues/21/comments","statuses_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/statuses/128dd6ac5f5607676bf153c52b9a25565023bb19","head":{"label":"BuildIt-Poland:feature/dr-8-roles-buttons","ref":"feature/dr-8-roles-buttons","sha":"128dd6ac5f5607676bf153c52b9a25565023bb19","user":{"login":"BuildIt-Poland","id":45263950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjYzOTUw","avatar_url":"https://avatars1.githubusercontent.com/u/45263950?v=4","gravatar_id":"","url":"https://api.github.com/users/BuildIt-Poland","html_url":"https://github.com/BuildIt-Poland","followers_url":"https://api.github.com/users/BuildIt-Poland/followers","following_url":"https://api.github.com/users/BuildIt-Poland/following{/other_user}","gists_url":"https://api.github.com/users/BuildIt-Poland/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildIt-Poland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildIt-Poland/subscriptions","organizations_url":"https://api.github.com/users/BuildIt-Poland/orgs","repos_url":"https://api.github.com/users/BuildIt-Poland/repos","events_url":"https://api.github.com/users/BuildIt-Poland/events{/privacy}","received_events_url":"https://api.github.com/users/BuildIt-Poland/received_events","type":"Organization","site_admin":false},"repo":{"id":190710000,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA3MTAwMDA=","name":"daily-routine","full_name":"BuildIt-Poland/daily-routine","private":false,"owner":{"login":"BuildIt-Poland","id":45263950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjYzOTUw","avatar_url":"https://avatars1.githubusercontent.com/u/45263950?v=4","gravatar_id":"","url":"https://api.github.com/users/BuildIt-Poland","html_url":"https://github.com/BuildIt-Poland","followers_url":"https://api.github.com/users/BuildIt-Poland/followers","following_url":"https://api.github.com/users/BuildIt-Poland/following{/other_user}","gists_url":"https://api.github.com/users/BuildIt-Poland/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildIt-Poland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildIt-Poland/subscriptions","organizations_url":"https://api.github.com/users/BuildIt-Poland/orgs","repos_url":"https://api.github.com/users/BuildIt-Poland/repos","events_url":"https://api.github.com/users/BuildIt-Poland/events{/privacy}","received_events_url":"https://api.github.com/users/BuildIt-Poland/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BuildIt-Poland/daily-routine","description":"An artificial intelligence dedicated to generating absurd and useful daily meeting quotes for endless enrichment of pointless developers existence.","fork":false,"url":"https://api.github.com/repos/BuildIt-Poland/daily-routine","forks_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/forks","keys_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/teams","hooks_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/hooks","issue_events_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues/events{/number}","events_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/events","assignees_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/assignees{/user}","branches_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/branches{/branch}","tags_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/tags","blobs_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/statuses/{sha}","languages_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/languages","stargazers_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/stargazers","contributors_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/contributors","subscribers_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/subscribers","subscription_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/subscription","commits_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/contents/{+path}","compare_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/merges","archive_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/downloads","issues_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues{/number}","pulls_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls{/number}","milestones_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/milestones{/number}","notifications_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/labels{/name}","releases_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/releases{/id}","deployments_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/deployments","created_at":"2019-06-07T08:14:51Z","updated_at":"2019-06-13T14:03:17Z","pushed_at":"2019-06-14T07:05:00Z","git_url":"git://github.com/BuildIt-Poland/daily-routine.git","ssh_url":"[email protected]:BuildIt-Poland/daily-routine.git","clone_url":"https://github.com/BuildIt-Poland/daily-routine.git","svn_url":"https://github.com/BuildIt-Poland/daily-routine","homepage":null,"size":658,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"BuildIt-Poland:master","ref":"master","sha":"92642e40bd0317f51679f7387faf6f8a822e8565","user":{"login":"BuildIt-Poland","id":45263950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjYzOTUw","avatar_url":"https://avatars1.githubusercontent.com/u/45263950?v=4","gravatar_id":"","url":"https://api.github.com/users/BuildIt-Poland","html_url":"https://github.com/BuildIt-Poland","followers_url":"https://api.github.com/users/BuildIt-Poland/followers","following_url":"https://api.github.com/users/BuildIt-Poland/following{/other_user}","gists_url":"https://api.github.com/users/BuildIt-Poland/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildIt-Poland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildIt-Poland/subscriptions","organizations_url":"https://api.github.com/users/BuildIt-Poland/orgs","repos_url":"https://api.github.com/users/BuildIt-Poland/repos","events_url":"https://api.github.com/users/BuildIt-Poland/events{/privacy}","received_events_url":"https://api.github.com/users/BuildIt-Poland/received_events","type":"Organization","site_admin":false},"repo":{"id":190710000,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA3MTAwMDA=","name":"daily-routine","full_name":"BuildIt-Poland/daily-routine","private":false,"owner":{"login":"BuildIt-Poland","id":45263950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MjYzOTUw","avatar_url":"https://avatars1.githubusercontent.com/u/45263950?v=4","gravatar_id":"","url":"https://api.github.com/users/BuildIt-Poland","html_url":"https://github.com/BuildIt-Poland","followers_url":"https://api.github.com/users/BuildIt-Poland/followers","following_url":"https://api.github.com/users/BuildIt-Poland/following{/other_user}","gists_url":"https://api.github.com/users/BuildIt-Poland/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildIt-Poland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildIt-Poland/subscriptions","organizations_url":"https://api.github.com/users/BuildIt-Poland/orgs","repos_url":"https://api.github.com/users/BuildIt-Poland/repos","events_url":"https://api.github.com/users/BuildIt-Poland/events{/privacy}","received_events_url":"https://api.github.com/users/BuildIt-Poland/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BuildIt-Poland/daily-routine","description":"An artificial intelligence dedicated to generating absurd and useful daily meeting quotes for endless enrichment of pointless developers existence.","fork":false,"url":"https://api.github.com/repos/BuildIt-Poland/daily-routine","forks_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/forks","keys_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/teams","hooks_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/hooks","issue_events_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues/events{/number}","events_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/events","assignees_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/assignees{/user}","branches_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/branches{/branch}","tags_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/tags","blobs_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/statuses/{sha}","languages_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/languages","stargazers_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/stargazers","contributors_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/contributors","subscribers_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/subscribers","subscription_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/subscription","commits_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/contents/{+path}","compare_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/merges","archive_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/downloads","issues_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues{/number}","pulls_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls{/number}","milestones_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/milestones{/number}","notifications_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/labels{/name}","releases_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/releases{/id}","deployments_url":"https://api.github.com/repos/BuildIt-Poland/daily-routine/deployments","created_at":"2019-06-07T08:14:51Z","updated_at":"2019-06-13T14:03:17Z","pushed_at":"2019-06-14T07:05:00Z","git_url":"git://github.com/BuildIt-Poland/daily-routine.git","ssh_url":"[email protected]:BuildIt-Poland/daily-routine.git","clone_url":"https://github.com/BuildIt-Poland/daily-routine.git","svn_url":"https://github.com/BuildIt-Poland/daily-routine","homepage":null,"size":658,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/21"},"html":{"href":"https://github.com/BuildIt-Poland/daily-routine/pull/21"},"issue":{"href":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues/21"},"comments":{"href":"https://api.github.com/repos/BuildIt-Poland/daily-routine/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BuildIt-Poland/daily-routine/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/BuildIt-Poland/daily-routine/statuses/128dd6ac5f5607676bf153c52b9a25565023bb19"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 190710000,
"name": "BuildIt-Poland/daily-routine",
"url": "https://api.github.com/repos/BuildIt-Poland/daily-routine"
}
|
{
"id": 9100242,
"login": "mgolawski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9100242?",
"url": "https://api.github.com/users/mgolawski"
}
|
{
"id": 45263950,
"login": "BuildIt-Poland",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45263950?",
"url": "https://api.github.com/orgs/BuildIt-Poland"
}
| 2019-06-14T07:20:56 |
9821539440
|
{"actor":{"display_login":"mgolawski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/memfault/interrupt/pulls/comments/363517641","pull_request_review_id":338892647,"id":363517641,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzUxNzY0MQ==","diff_hunk":"@@ -0,0 +1,698 @@\n+---\n+title: \"Managing Developer Environments with Conda\"\n+description:\n+ \"An introduction to using Conda for managing developer environments in the\n+ context of embedded software projects.\"\n+tag: [python]\n+author: tyler\n+image: /img/using-conda/using-conda-cover.png\n+---\n+\n+Every developer on a team should build, debug, and test the firmware images with\n+the **same versions** of all tools required by the project. This includes the\n+compiler, debugger, build system, system packages, Python packages, and much\n+more. Keeping all of these tools in sync among all members of a team is a\n+daunting task. Luckily there are tools to make it easy. The one we'll talk about\n+in this post is called [Conda](https://docs.conda.io/en/latest/).\n+\n+<!-- excerpt start -->\n+\n+This post gives an introduction to what Conda is, explains why you should care\n+about keeping your developer environments in sync, and finally provides a\n+walk-through on getting started with Conda to set up a GCC based developer\n+environment.\n+\n+<!-- excerpt end -->\n+\n+_Like Interrupt? [Subscribe](http://eepurl.com/gpRedv) to get our latest posts\n+straight to your mailbox_\n+\n+{:.no_toc}\n+\n+## Table of Contents\n+\n+<!-- prettier-ignore -->\n+* auto-gen TOC:\n+{:toc}\n+\n+## What is Conda\n+\n+\n+\n+Conda is a \"package, dependency and environment management for any\n+language\"[^1]. It's most popular in the world of data science, but it can easily\n+be used in any field, including firmware development! Conda has become my\n+favorite way to manage the developer and continuous integration environments for\n+my firmware projects.\n+\n+Conda is primarily used to manage Python distributions and environments. It can\n+either be used as a replacement for\n+[Virtualenv](https://virtualenv.pypa.io/en/latest/) or used alongside it if\n+necessary. It also provides `pip` so that PyPi packages can be installed as\n+well.\n+\n+The primary benefit of using Conda over Virtualenv is its ability to install and\n+manage system binary packages that one may need in a developer environment, such\n+as the `arm-none-eabi-gcc` toolchain, `wget`, or Make.\n+\n+## When to Use Conda\n+\n+Every developer should build, debug, and test the firmware using the **exact\n+same versions** of the compiler, build system, and other tools. The specific\n+tools used should also be in lock-step with the code base revision being worked\n+on. This ensures that there is one way to do all everyday tasks and they\n+**always work**. It's also a critical step towards having [reproducible\n+builds]({% post_url 2019-12-11-reproducible-firmware-builds %}).\n+\n+If you or your teammates have experienced any of the following more than once,\n+it may be time to consider using Conda or another environment manager.\n+\n+- After coming back from a 2 week vacation, you find that getting a functional\n+ development environment again takes hours or even days.\n+- Updating a package required by the firmware build is a monumental effort and\n+ requires communication in all channels, including email, slack, and various\n+ wiki pages.\n+- You find that a build from your machine works correctly but not the one from\n+ CI or your co-workers machine.\n+- You check out 6 month-old revision of your project and realize it's probably\n+ quicker to reformat your computer and start over than to try and piece\n+ together an environment to build the firmware.\n+- You use Windows, macOS, or Linux _without_ Docker.\n+\n+## How Does Conda Work?\n+\n+When a developer installs Conda on their computer, a command-line tool called\n+`conda` becomes available. `conda` is used to install, manage, and activate the\n+Conda virtual environments. There are also public repositories which host\n+packages built by Anaconda, Inc. and the community. The two most popular are the\n+self-named Anaconda and [Conda Forge](https://conda-forge.org/) repositories.\n+Conda Forge is supported by the community and developers contribute packages\n+through Github, after which they are built and released for all platforms\n+through their CI/CD system.\n+\n+When a package, Python or binary, is installed through Conda to a particular\n+environment, it is placed in a separate \"environment\" directory (e.g.\n+`~/miniconda3/envs/example`). To activate these virtual environments, Conda will\n+edit the shell's `$PATH` variable, prepending it with the directory of the\n+desired environment. For example, if we activate the `example` environment, the\n+`$PATH` variable becomes\n+\n+```\n+(example)\n+$ echo $PATH\n+/Users/tyler/miniconda3/envs/example/bin:...\n+```\n+\n+This forces the current shell to look within the above directory _first_ before\n+searching the default package paths, such as `/usr/bin` or `/usr/local/bin`. For\n+example, below we print which `make` binary and version is used by the shell,\n+before and after activating a Conda environment.\n+\n+```\n+$ which make && make --version\n+/usr/bin/make\n+GNU Make 3.81\n+\n+# Activate our Conda environment\n+$ conda activate example\n+\n+(example)\n+$ which make && make --version\n+/Users/tyler/miniconda3/envs/example/bin/make\n+GNU Make 4.2.1\n+```\n+\n+### Common Developer Environment Alternatives\n+\n+I have found Conda to be the least restrictive and easiest way for firmware\n+teams manage developer environments, but let's go through the most popular\n+alternatives.\n+\n+#### Docker\n+\n+Docker is the best way to create developer environments from scratch and for\n+temporary purposes (such as in continuous integration). A `Dockerfile`, which\n+commonly lives in a project's repo, defines any and all setup command, such as\n+downloading and install system packages, installing Python requirements, and\n+setting up permissions and volumes.\n+\n+Despite the numerous benefits, Docker is not a great fit for local developer\n+environments.\n+\n+- By using Docker, you'll have two file systems, one on the host machine and one\n+ within the container. Without a large investment in up-front tooling to help\n+ developers manage the code, build artifacts, debugging tools, and volume\n+ mounts, it is cumbersome and slow.\n+- When using macOS or Windows and Docker, shared, mounted volumes have\n+ file-sharing performance issues, which can cause build times to increase\n+ between 2-10x depending on where the files live.[^2]\n+- For developers that like the use of IDE's and other visual tools, a virtual\n+ machine using VMWare or VirtualBox may be more appropriate.\n+\n+With all that said, using Docker in your CI system is a no-brainer. Conda and\n+Docker can even be used _together_, where Docker manages the system image and\n+low-level setup, and Conda manages all of the packages required to build and\n+test the firmware.\n+\n+Check out [this previous Interrupt\n+post]({% post_url 2019-09-17-continuous-integration-for-firmware %}) for how to\n+get up and running quickly with Docker and continuous integration.\n+\n+#### Included System Package Managers\n+\n+System package managers, such as Brew, Apt, MinGW, etc., are very good at\n+installing packages and managing dependencies between them. They are also great\n+at ensuring that the modern software you use everyday works correctly, safely,\n+and is kept up-to-date. They are not good at ensuring that the software or\n+firmware that **you** build continues to work correctly. They are also not good\n+at juggling multiple versions of packages that aren't the default ones.\n+\n+It is not uncommon for firmware consultancies or companies to have multiple\n+different firmware projects in flight. This could be a legacy project and a\n+newer one. I imagine the following wouldn't be far off:\n+\n+**Old Project Dependencies:** GNU Make 4.1, GCC 5.4.1, GDB 7.11, Python 3.5\n+**New Project Dependencies:** GNU Make 4.2.1, GCC 8.3.1, GDB 8.3, Python 3.6\n+\n+In the above example, to be able to go back and forth between these two\n+projects, we'd have to uninstall and reinstall these four packages and their\n+dependencies. We'd also be taking the risky bet that doing so wouldn't affect\n+other packages that we have installed.\n+\n+In an ideal world, you should be able to use `brew upgrade` or\n+`apt update && apt upgrade` anytime and it wouldn't affect anything related to\n+the project's firmware build. This is **not possible** when using system package\n+managers and I strongly advise against using this approach.\n+\n+#### Virtualenv\n+\n+Virtualenv works well for managing Python environments and packages, but it\n+doesn't manage system binaries. It also requires that each Python version be\n+installed prior to being used in a virtual environment, such as with `pyenv` or\n+the system package manager.\n+\n+You can use Virtualenv alongside Conda as well if that is necessary, but it is\n+not required. Conda is a full replacement for Virtualenv.\n+\n+#### Virtual Machine\n+\n+Using a virtual machine is a great way to isolate the environment even more so\n+that every developer uses a similar environment and is provided with a GUI\n+and/or IDE. It's also especially useful if everyone has a Linux machine and the\n+build requires Windows, or vice-versa. However, I still find issues with this\n+approach.\n+\n+- Sharing file systems between the host and image has performance issues.\n+- Using the UI within a virtual machine is generally slower.\n+- One still would need some sort of environment management with the VM, as\n+ packages will inevitably change every couple of months.\n+\n+If a VM is chosen, I suggest using Conda **within it** to help manage the\n+packages that are used within the VM. Otherwise, the team would have to package\n+and distribute a new VM image each time a dependency changes, or hope that\n+everyone knows when and how to update the system (and does it).\n+\n+## Example Conda Walk-through\n+\n+In this part of the post, we will set up Conda on our local machine and set up\n+an environment that is able to build, flash, and debug an nRF52 device.\n+\n+If you'd like to follow along, you may download the Interrupt repo and navigate\n+to the example directory.\n+\n+```\n+$ git clone [email protected]:memfault/interrupt.git\n+$ cd interrupt/example/using-conda/\n+```\n+\n+> Before we begin, I want to bring comfort to anyone skeptical about installing\n+> yet another tool. Conda is the opposite of invasive, and everything is\n+> installed into a single directory, `$HOME/miniconda3` by default. If you want\n+> to uninstall Conda, deleting that directory will be all that is necessary.\n+\n+### Installing Conda\n+\n+To install the `conda` client on a machine, the recommended way is to download\n+the interactive\n+[Miniconda installer](https://docs.conda.io/en/latest/miniconda.html) and run it\n+through `bash`. The following steps apply to both Linux and macOS. If you are\n+using Windows, there is a Miniconda installer that can be downloaded from the\n+same page.\n+\n+```\n+$ wget https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh\n+$ bash Miniconda3-latest-MacOSX-x86_64.sh\n+```\n+\n+The final step in the installer is to make sure the\n+`$HOME/miniconda3/etc/profile.d/conda.sh` script is loaded in the shell. When\n+the following prompt is given:\n+\n+```\n+Do you wish the installer to initialize Miniconda3\n+by running conda init? [yes|no]\n+```\n+\n+I suggest saying `no` and modifying the appropriate shell startup file\n+(`.bashrc` or `.zshrc`, etc.) to contain the following.\n+\n+```\n+. \"$HOME/miniconda3/etc/profile.d/conda.sh\"\n+```\n+\n+If everything was successful, after reloading our shell, we can now run the\n+`conda` command in the shell.\n+\n+```\n+$ conda --version\n+conda 4.7.12\n+```\n+\n+### Creating the Environment\n+\n+The next step is to create an isolated environment in which we can install\n+packages into. We will create an environment called `example`.\n+\n+```\n+$ conda create -n example\n+Collecting package metadata (current_repodata.json): done\n+Solving environment: done\n+\n+## Package Plan ##\n+\n+ environment location: /Users/tyler/miniconda3/envs/example\n+\n+Proceed ([y]/n)? y\n+\n+Preparing transaction: done\n+Verifying transaction: done\n+Executing transaction: done\n+#\n+# To activate this environment, use\n+#\n+# $ conda activate example\n+#\n+# To deactivate an active environment, use\n+#\n+# $ conda deactivate\n+\n+```\n+\n+Now, we are able to load up our environment using:\n+\n+```\n+$ conda activate example\n+```\n+\n+Our current environment has zero packages installed. We can double check this by\n+running `conda list`.\n+\n+```\n+(example)\n+$ conda list\n+# packages in environment at /Users/tyler/miniconda3/envs/example:\n+#\n+# Name Version Build Channel\n+\n+```\n+\n+### Configuring the Environment\n+\n+We want to install the following packages:\n+\n+- ARM GCC Toolchain (8-2019-q3-update)\n+- Make (4.2.1)\n+- Python (3.6)\n+- nrfutil (6.0.0)\n+\n+There are two ways to install packages. The first is by installing them directly\n+with the CLI (e.g. `conda install make`), and the second is by defining them in\n+a `environment.yml` file, generally placed in the root of the project. We will\n+use the second method.\n+\n+There are also multiple repositories to install packages from. The two most\n+popular ones are \"Anaconda\" and \"Conda Forge\". We will use Conda Forge as our\n+primary repository, since it has more mainstream packages that we as firmware\n+developers use. We will also add my personal Conda repository (tyhoff17), as it\n+has the ARM GCC package.\n+\n+To search for packages that can be installed, you can navigate to the\n+[Conda Forge](https://anaconda.org/conda-forge) repository and browse around. It\n+is also possible to install community packages built by others, but mileage may\n+vary.\n+\n+Below is the `environment.yml` file that contains all of our dependencies.\n+\n+```yaml\n+channels:\n+ - tyhoff17\n+ - conda-forge\n+ - defaults\n+dependencies:\n+ - make=4.2.1\n+ - gcc-arm-none-eabi=8.2019.q3.update\n+ - python=3.6.9\n+ - pip\n+ - pip:\n+ - nrfutil==6.0.0\n+```\n+\n+If you'd rather manage your `pip` packages in a separate `requirements.txt`\n+file, the following should work for the `pip:` section.\n+\n+```\n+ - pip:\n+ - -r requirements.txt\n+```\n+\n+### Populating the Environment\n+\n+With our `environment.yml` file set with all the dependencies, we are ready to\n+install them! This is done using the `conda env update` command.\n+\n+```\n+conda env update -f environment.yml\n+```\n+\n+If successful, we'll now have all the packages we defined available on our\n+`$PATH` and stored within the `~/miniconda3/envs/example` environment directory.\n+\n+```\n+$ which make\n+/Users/tyler/miniconda3/envs/example/bin/make\n+\n+$ which arm-none-eabi-gdb-py\n+/Users/tyler/miniconda3/envs/example/bin/arm-none-eabi-gdb-py\n+```\n+\n+We are now able to build, flash, and debug as any developer should using `make`,\n+`arm-none-eabi-gcc`, and `nrfjprog`.\n+\n+> If any developer joins the team and needs to set up an environment, the only\n+> two things they would need to do is install Conda and run\n+> `conda create -n smart-sink -f environment.yml` in the project. Easy, right!?\n+\n+### Adding Another Package\n+\n+Let's assume we have 10 engineers working on our project distributed across the\n+globe. We also have a problem where our firmware builds are slowing down, and\n+we'd like to speed them up. A clever engineer realized that we could be using\n+`ccache` to locally cache built object files between subsequent builds. This\n+speeds up our firmware build by 50%, which is a huge win!\n+\n+We want _everyone_ to have `ccache` installed and to use it with ever build. We\n+could send out an email to the team, mention it in Slack, and maybe even error\n+out in the Makefile if we see the developer does not have it installed. All\n+these methods are tedious and not 100% reliable.\n+\n+Since every developer on the project is using Conda at this point, we can add an\n+entry for `ccache` in our `environment.yml` and this becomes trivial.\n+\n+```yaml\n+dependencies:\n+ # System Packages\n+ ...\n+ - ccache\n+```\n+\n+The next time a developer runs `conda env update`, they'll have `ccache`\n+available on their `PATH` and can start using it immediately.\n+\n+```\n+$ conda env update -f environment.yml\n+$ which ccache\n+/Users/tyler/miniconda3/envs/test/bin/ccache\n+```\n+\n+## Other Benefits of Using Conda\n+\n+The more I used Conda, the more I enjoyed the subtle but enormous benefits. They\n+have all saved me hours of time both for myself and my co-workers. I have\n+compiled my favorite benefits below.\n+\n+### Easily Re-Create Environments\n+\n+It's not uncommon for your build environment to stop working. Maybe a package\n+becomes corrupted, or a package is accidentally installed or uninstalled. Or\n+maybe you run into a problem locally and want to confirm that it _isn't_ your\n+build environment before reaching out to your teammates.\n+\n+With Conda, this becomes incredibly simple! You can very quickly delete and\n+re-create your environment using\n+\n+```\n+$ conda env remove -n my_env\n+$ conda env create -n my_env -f environment.yml\n+$ conda activate my_env\n+```\n+\n+This will remove the old environment **in its entirety** and re-create it. The\n+process takes about 30 seconds. In comparison, re-provisioning a virtual machine\n+or your computer's operating system could take an hour or a whole day\n+respectively.\n+\n+### Bouncing Between Projects and Commits\n+\n+If you change projects, commits, or branches often, it's simple to make sure\n+that all packages are installed and with the correct versions.\n+\n+```\n+$ git checkout <build from 9 months ago>\n+$ conda env update -f environment.yml\n+$ make\n+```\n+\n+### Easier Git Bisect\n+\n+For those who have used `git bisect` over a large date range (3+ months), you\n+might recall how difficult it can be. This is because for every commit, you need\n+install the versions of the packages that were required **at that time**. Some\n+teams do this through a revision controlled wiki page, change-log in the\n+README.md, or through a (sigh) guess-and-check method. If it builds, it works,\n+right? (No)\n+\n+With Conda, the build and test loop becomes simple!\n+\n+```\n+# Update all required packages\n+$ conda env update -f environment.yml\n+\n+# Build and flash the firmware\n+$ make && flash\n+\n+# Test the system\n+\n+# Mark as good or bad\n+$ git bisect [good|bad]\n+\n+# Repeat many times...\n+```\n+\n+### Distributing a Conda Environment\n+\n+If you want to be able to export and distribute a Conda environment, including\n+Python, pip packages, and system packages, this is possible using the official\n+Conda package called [Conda Pack](https://conda.github.io/conda-pack/).\n+\n+This is useful when you need to give a build or test environment to an end\n+customer, a vendor, or a factory in China. It is also useful where the recipient\n+has limited or no access to the Internet. These packaged environments can be\n+used **without** installing Python, Conda, or any other packages on the host\n+machine.\n+\n+## Creating Your Own Conda Packages\n+\n+There is a high chance that all packages required by your project, team, or\n+developers are not yet built for Conda and hosted on the Conda Forge repository.\n+Fret not, as building and publishing Conda packages is relatively simple. We'll\n+quickly walk through how I built and published the `gcc-arm-none-eabi` package\n+that is hosted [here](https://anaconda.org/tyhoff17/gcc-arm-none-eabi) and built\n+from the official\n+[ARM GNU Embedded Toolchain](https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm/downloads).\n+\n+Creating a package for this toolchain is straight-forward since the binaries are\n+already built for each platform. All we need to do is download the tarball,\n+extract it, and copy the contents into a Conda package.\n+\n+> If you want to jump ahead and look at the final recipe, it is hosted in\n+> Memfault's\n+> [conda-recipes Github repo](https://github.com/memfault/conda-recipes/tree/master/gcc-arm-none-eabi).\n+\n+### Creating the Build Environment\n+\n+The first thing we need to do is create an environment which has `conda-build`\n+and `anaconda-client` installed, both of which will be used to build and publish\n+our package.\n+\n+```\n+# Create the Conda Environment we'll use for building\n+$ conda create -n build\n+\n+# Activate the environment called `build`\n+$ conda activate build\n+\n+# Install the necessary packages to build and publish Conda packages\n+(build)\n+$ conda install conda-build anaconda-client\n+```\n+\n+Now we'll want to create an empty directory, with a single `meta.yaml` file\n+within it.\n+\n+```\n+$ mkdir /tmp/arm-none-eabi-gcc && cd /tmp/arm-none-eabi-gcc\n+$ touch meta.yaml\n+```\n+\n+### Defining the `meta.yaml` File\n+\n+Next, we'll set up our `meta.yaml` file with the following information, with\n+each field described below. The definition is small because we are merely\n+repackaging binaries.\n+\n+```yaml\n+package:\n+ name: gcc-arm-none-eabi\n+ version: 8.2019.q3.update\n+\n+source:\n+ url: https://developer.arm.com/-/media/Files/downloads/gnu-rm/8-2019q3/RC1.1/gcc-arm-none-eabi-8-2019-q3-update-mac.tar.bz2 # [osx]\n+ sha256: fc235ce853bf3bceba46eff4b95764c5935ca07fc4998762ef5e5b7d05f37085 # [osx]\n+\n+build:\n+ string: \"0\"\n+\n+test:\n+ commands:\n+ - arm-none-eabi-gcc --version\n+```\n+\n+- `package`: This is the Name and Version of the Conda package that we are\n+ building. e.g. if we are building Make 4.2.1 for Conda, then Name would be\n+ \"Make\" and Version would be \"4.2.1\".\n+- `source`: This is either the fields `url` and `sha256` which points to a Zip\n+ or Tarball containing the source code or binaries, or it can also reference a\n+ Git repository using the `git_url` and `git_rev` fields.\n+- `build`: This is the build number. If a user publishes a package but it was","path":"_drafts/conda.md","position":576,"original_position":576,"commit_id":"e267fb9bc936abf41159fd92502371e129b930fe","original_commit_id":"e267fb9bc936abf41159fd92502371e129b930fe","user":{"login":"franc0is","id":4192460,"node_id":"MDQ6VXNlcjQxOTI0NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/4192460?v=4","gravatar_id":"","url":"https://api.github.com/users/franc0is","html_url":"https://github.com/franc0is","followers_url":"https://api.github.com/users/franc0is/followers","following_url":"https://api.github.com/users/franc0is/following{/other_user}","gists_url":"https://api.github.com/users/franc0is/gists{/gist_id}","starred_url":"https://api.github.com/users/franc0is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franc0is/subscriptions","organizations_url":"https://api.github.com/users/franc0is/orgs","repos_url":"https://api.github.com/users/franc0is/repos","events_url":"https://api.github.com/users/franc0is/events{/privacy}","received_events_url":"https://api.github.com/users/franc0is/received_events","type":"User","site_admin":false},"body":"Can you add a note on the restriction for the `build` property? Does it need to be a monotonically increasing integer?","created_at":"2020-01-06T22:40:56Z","updated_at":"2020-01-06T22:58:01Z","html_url":"https://github.com/memfault/interrupt/pull/71#discussion_r363517641","pull_request_url":"https://api.github.com/repos/memfault/interrupt/pulls/71","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/memfault/interrupt/pulls/comments/363517641"},"html":{"href":"https://github.com/memfault/interrupt/pull/71#discussion_r363517641"},"pull_request":{"href":"https://api.github.com/repos/memfault/interrupt/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/memfault/interrupt/pulls/71","id":358536841,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU4NTM2ODQx","html_url":"https://github.com/memfault/interrupt/pull/71","diff_url":"https://github.com/memfault/interrupt/pull/71.diff","patch_url":"https://github.com/memfault/interrupt/pull/71.patch","issue_url":"https://api.github.com/repos/memfault/interrupt/issues/71","number":71,"state":"open","locked":false,"title":"Post about Conda","user":{"login":"tyhoff","id":1041679,"node_id":"MDQ6VXNlcjEwNDE2Nzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1041679?v=4","gravatar_id":"","url":"https://api.github.com/users/tyhoff","html_url":"https://github.com/tyhoff","followers_url":"https://api.github.com/users/tyhoff/followers","following_url":"https://api.github.com/users/tyhoff/following{/other_user}","gists_url":"https://api.github.com/users/tyhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/tyhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyhoff/subscriptions","organizations_url":"https://api.github.com/users/tyhoff/orgs","repos_url":"https://api.github.com/users/tyhoff/repos","events_url":"https://api.github.com/users/tyhoff/events{/privacy}","received_events_url":"https://api.github.com/users/tyhoff/received_events","type":"User","site_admin":false},"body":"","created_at":"2020-01-02T02:15:51Z","updated_at":"2020-01-06T22:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c0d8ccc81b0822aff3bd88aaba2b4fe46226675","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chrisc11","id":7494333,"node_id":"MDQ6VXNlcjc0OTQzMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7494333?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisc11","html_url":"https://github.com/chrisc11","followers_url":"https://api.github.com/users/chrisc11/followers","following_url":"https://api.github.com/users/chrisc11/following{/other_user}","gists_url":"https://api.github.com/users/chrisc11/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisc11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisc11/subscriptions","organizations_url":"https://api.github.com/users/chrisc11/orgs","repos_url":"https://api.github.com/users/chrisc11/repos","events_url":"https://api.github.com/users/chrisc11/events{/privacy}","received_events_url":"https://api.github.com/users/chrisc11/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/memfault/interrupt/pulls/71/commits","review_comments_url":"https://api.github.com/repos/memfault/interrupt/pulls/71/comments","review_comment_url":"https://api.github.com/repos/memfault/interrupt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/memfault/interrupt/issues/71/comments","statuses_url":"https://api.github.com/repos/memfault/interrupt/statuses/e267fb9bc936abf41159fd92502371e129b930fe","head":{"label":"memfault:tyler/conda","ref":"tyler/conda","sha":"e267fb9bc936abf41159fd92502371e129b930fe","user":{"login":"memfault","id":45582074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NTgyMDc0","avatar_url":"https://avatars0.githubusercontent.com/u/45582074?v=4","gravatar_id":"","url":"https://api.github.com/users/memfault","html_url":"https://github.com/memfault","followers_url":"https://api.github.com/users/memfault/followers","following_url":"https://api.github.com/users/memfault/following{/other_user}","gists_url":"https://api.github.com/users/memfault/gists{/gist_id}","starred_url":"https://api.github.com/users/memfault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memfault/subscriptions","organizations_url":"https://api.github.com/users/memfault/orgs","repos_url":"https://api.github.com/users/memfault/repos","events_url":"https://api.github.com/users/memfault/events{/privacy}","received_events_url":"https://api.github.com/users/memfault/received_events","type":"Organization","site_admin":false},"repo":{"id":180670875,"node_id":"MDEwOlJlcG9zaXRvcnkxODA2NzA4NzU=","name":"interrupt","full_name":"memfault/interrupt","private":false,"owner":{"login":"memfault","id":45582074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NTgyMDc0","avatar_url":"https://avatars0.githubusercontent.com/u/45582074?v=4","gravatar_id":"","url":"https://api.github.com/users/memfault","html_url":"https://github.com/memfault","followers_url":"https://api.github.com/users/memfault/followers","following_url":"https://api.github.com/users/memfault/following{/other_user}","gists_url":"https://api.github.com/users/memfault/gists{/gist_id}","starred_url":"https://api.github.com/users/memfault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memfault/subscriptions","organizations_url":"https://api.github.com/users/memfault/orgs","repos_url":"https://api.github.com/users/memfault/repos","events_url":"https://api.github.com/users/memfault/events{/privacy}","received_events_url":"https://api.github.com/users/memfault/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/memfault/interrupt","description":"A community for embedded software makers.","fork":false,"url":"https://api.github.com/repos/memfault/interrupt","forks_url":"https://api.github.com/repos/memfault/interrupt/forks","keys_url":"https://api.github.com/repos/memfault/interrupt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/memfault/interrupt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/memfault/interrupt/teams","hooks_url":"https://api.github.com/repos/memfault/interrupt/hooks","issue_events_url":"https://api.github.com/repos/memfault/interrupt/issues/events{/number}","events_url":"https://api.github.com/repos/memfault/interrupt/events","assignees_url":"https://api.github.com/repos/memfault/interrupt/assignees{/user}","branches_url":"https://api.github.com/repos/memfault/interrupt/branches{/branch}","tags_url":"https://api.github.com/repos/memfault/interrupt/tags","blobs_url":"https://api.github.com/repos/memfault/interrupt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/memfault/interrupt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/memfault/interrupt/git/refs{/sha}","trees_url":"https://api.github.com/repos/memfault/interrupt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/memfault/interrupt/statuses/{sha}","languages_url":"https://api.github.com/repos/memfault/interrupt/languages","stargazers_url":"https://api.github.com/repos/memfault/interrupt/stargazers","contributors_url":"https://api.github.com/repos/memfault/interrupt/contributors","subscribers_url":"https://api.github.com/repos/memfault/interrupt/subscribers","subscription_url":"https://api.github.com/repos/memfault/interrupt/subscription","commits_url":"https://api.github.com/repos/memfault/interrupt/commits{/sha}","git_commits_url":"https://api.github.com/repos/memfault/interrupt/git/commits{/sha}","comments_url":"https://api.github.com/repos/memfault/interrupt/comments{/number}","issue_comment_url":"https://api.github.com/repos/memfault/interrupt/issues/comments{/number}","contents_url":"https://api.github.com/repos/memfault/interrupt/contents/{+path}","compare_url":"https://api.github.com/repos/memfault/interrupt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/memfault/interrupt/merges","archive_url":"https://api.github.com/repos/memfault/interrupt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/memfault/interrupt/downloads","issues_url":"https://api.github.com/repos/memfault/interrupt/issues{/number}","pulls_url":"https://api.github.com/repos/memfault/interrupt/pulls{/number}","milestones_url":"https://api.github.com/repos/memfault/interrupt/milestones{/number}","notifications_url":"https://api.github.com/repos/memfault/interrupt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/memfault/interrupt/labels{/name}","releases_url":"https://api.github.com/repos/memfault/interrupt/releases{/id}","deployments_url":"https://api.github.com/repos/memfault/interrupt/deployments","created_at":"2019-04-10T22:07:35Z","updated_at":"2020-01-03T00:57:08Z","pushed_at":"2020-01-04T01:38:43Z","git_url":"git://github.com/memfault/interrupt.git","ssh_url":"[email protected]:memfault/interrupt.git","clone_url":"https://github.com/memfault/interrupt.git","svn_url":"https://github.com/memfault/interrupt","homepage":"https://interrupt.memfault.com","size":42834,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":1,"watchers":32,"default_branch":"master"}},"base":{"label":"memfault:master","ref":"master","sha":"3e3572dd39aa9762a81e898a13a89a69f5f70d0f","user":{"login":"memfault","id":45582074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NTgyMDc0","avatar_url":"https://avatars0.githubusercontent.com/u/45582074?v=4","gravatar_id":"","url":"https://api.github.com/users/memfault","html_url":"https://github.com/memfault","followers_url":"https://api.github.com/users/memfault/followers","following_url":"https://api.github.com/users/memfault/following{/other_user}","gists_url":"https://api.github.com/users/memfault/gists{/gist_id}","starred_url":"https://api.github.com/users/memfault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memfault/subscriptions","organizations_url":"https://api.github.com/users/memfault/orgs","repos_url":"https://api.github.com/users/memfault/repos","events_url":"https://api.github.com/users/memfault/events{/privacy}","received_events_url":"https://api.github.com/users/memfault/received_events","type":"Organization","site_admin":false},"repo":{"id":180670875,"node_id":"MDEwOlJlcG9zaXRvcnkxODA2NzA4NzU=","name":"interrupt","full_name":"memfault/interrupt","private":false,"owner":{"login":"memfault","id":45582074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NTgyMDc0","avatar_url":"https://avatars0.githubusercontent.com/u/45582074?v=4","gravatar_id":"","url":"https://api.github.com/users/memfault","html_url":"https://github.com/memfault","followers_url":"https://api.github.com/users/memfault/followers","following_url":"https://api.github.com/users/memfault/following{/other_user}","gists_url":"https://api.github.com/users/memfault/gists{/gist_id}","starred_url":"https://api.github.com/users/memfault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memfault/subscriptions","organizations_url":"https://api.github.com/users/memfault/orgs","repos_url":"https://api.github.com/users/memfault/repos","events_url":"https://api.github.com/users/memfault/events{/privacy}","received_events_url":"https://api.github.com/users/memfault/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/memfault/interrupt","description":"A community for embedded software makers.","fork":false,"url":"https://api.github.com/repos/memfault/interrupt","forks_url":"https://api.github.com/repos/memfault/interrupt/forks","keys_url":"https://api.github.com/repos/memfault/interrupt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/memfault/interrupt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/memfault/interrupt/teams","hooks_url":"https://api.github.com/repos/memfault/interrupt/hooks","issue_events_url":"https://api.github.com/repos/memfault/interrupt/issues/events{/number}","events_url":"https://api.github.com/repos/memfault/interrupt/events","assignees_url":"https://api.github.com/repos/memfault/interrupt/assignees{/user}","branches_url":"https://api.github.com/repos/memfault/interrupt/branches{/branch}","tags_url":"https://api.github.com/repos/memfault/interrupt/tags","blobs_url":"https://api.github.com/repos/memfault/interrupt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/memfault/interrupt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/memfault/interrupt/git/refs{/sha}","trees_url":"https://api.github.com/repos/memfault/interrupt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/memfault/interrupt/statuses/{sha}","languages_url":"https://api.github.com/repos/memfault/interrupt/languages","stargazers_url":"https://api.github.com/repos/memfault/interrupt/stargazers","contributors_url":"https://api.github.com/repos/memfault/interrupt/contributors","subscribers_url":"https://api.github.com/repos/memfault/interrupt/subscribers","subscription_url":"https://api.github.com/repos/memfault/interrupt/subscription","commits_url":"https://api.github.com/repos/memfault/interrupt/commits{/sha}","git_commits_url":"https://api.github.com/repos/memfault/interrupt/git/commits{/sha}","comments_url":"https://api.github.com/repos/memfault/interrupt/comments{/number}","issue_comment_url":"https://api.github.com/repos/memfault/interrupt/issues/comments{/number}","contents_url":"https://api.github.com/repos/memfault/interrupt/contents/{+path}","compare_url":"https://api.github.com/repos/memfault/interrupt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/memfault/interrupt/merges","archive_url":"https://api.github.com/repos/memfault/interrupt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/memfault/interrupt/downloads","issues_url":"https://api.github.com/repos/memfault/interrupt/issues{/number}","pulls_url":"https://api.github.com/repos/memfault/interrupt/pulls{/number}","milestones_url":"https://api.github.com/repos/memfault/interrupt/milestones{/number}","notifications_url":"https://api.github.com/repos/memfault/interrupt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/memfault/interrupt/labels{/name}","releases_url":"https://api.github.com/repos/memfault/interrupt/releases{/id}","deployments_url":"https://api.github.com/repos/memfault/interrupt/deployments","created_at":"2019-04-10T22:07:35Z","updated_at":"2020-01-03T00:57:08Z","pushed_at":"2020-01-04T01:38:43Z","git_url":"git://github.com/memfault/interrupt.git","ssh_url":"[email protected]:memfault/interrupt.git","clone_url":"https://github.com/memfault/interrupt.git","svn_url":"https://github.com/memfault/interrupt","homepage":"https://interrupt.memfault.com","size":42834,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":1,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/memfault/interrupt/pulls/71"},"html":{"href":"https://github.com/memfault/interrupt/pull/71"},"issue":{"href":"https://api.github.com/repos/memfault/interrupt/issues/71"},"comments":{"href":"https://api.github.com/repos/memfault/interrupt/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/memfault/interrupt/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/memfault/interrupt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/memfault/interrupt/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/memfault/interrupt/statuses/e267fb9bc936abf41159fd92502371e129b930fe"}},"author_association":"MEMBER"}}
|
{
"id": 180670875,
"name": "memfault/interrupt",
"url": "https://api.github.com/repos/memfault/interrupt"
}
|
{
"id": 4192460,
"login": "franc0is",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4192460?",
"url": "https://api.github.com/users/franc0is"
}
|
{
"id": 45582074,
"login": "memfault",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45582074?",
"url": "https://api.github.com/orgs/memfault"
}
| 2020-01-06T22:40:56 |
11214588392
|
{"actor":{"display_login":"franc0is"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/comments/308557670","pull_request_review_id":268186694,"id":308557670,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODU1NzY3MA==","diff_hunk":"@@ -0,0 +1,219 @@\n+pragma solidity ^0.5.8;\n+\n+contract ETHAtomicSwapper {","path":"ethereum/contracts/ETHAtomicSwapper.sol","position":3,"original_position":3,"commit_id":"f8a3bcf657f89a238fcf513fb64725a7ad59a85e","original_commit_id":"f8a3bcf657f89a238fcf513fb64725a7ad59a85e","user":{"login":"rickyyangz","id":38900912,"node_id":"MDQ6VXNlcjM4OTAwOTEy","avatar_url":"https://avatars1.githubusercontent.com/u/38900912?v=4","gravatar_id":"","url":"https://api.github.com/users/rickyyangz","html_url":"https://github.com/rickyyangz","followers_url":"https://api.github.com/users/rickyyangz/followers","following_url":"https://api.github.com/users/rickyyangz/following{/other_user}","gists_url":"https://api.github.com/users/rickyyangz/gists{/gist_id}","starred_url":"https://api.github.com/users/rickyyangz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickyyangz/subscriptions","organizations_url":"https://api.github.com/users/rickyyangz/orgs","repos_url":"https://api.github.com/users/rickyyangz/repos","events_url":"https://api.github.com/users/rickyyangz/events{/privacy}","received_events_url":"https://api.github.com/users/rickyyangz/received_events","type":"User","site_admin":false},"body":"what's the difference between this and the above one","created_at":"2019-07-30T06:49:07Z","updated_at":"2019-07-30T06:49:07Z","html_url":"https://github.com/binance-chain/bep3-smartcontracts/pull/2#discussion_r308557670","pull_request_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/comments/308557670"},"html":{"href":"https://github.com/binance-chain/bep3-smartcontracts/pull/2#discussion_r308557670"},"pull_request":{"href":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/2","id":301947031,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxOTQ3MDMx","html_url":"https://github.com/binance-chain/bep3-smartcontracts/pull/2","diff_url":"https://github.com/binance-chain/bep3-smartcontracts/pull/2.diff","patch_url":"https://github.com/binance-chain/bep3-smartcontracts/pull/2.patch","issue_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues/2","number":2,"state":"open","locked":false,"title":"R4R: Ethereum atomicswap contract","user":{"login":"HaoyangLiu","id":2945006,"node_id":"MDQ6VXNlcjI5NDUwMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2945006?v=4","gravatar_id":"","url":"https://api.github.com/users/HaoyangLiu","html_url":"https://github.com/HaoyangLiu","followers_url":"https://api.github.com/users/HaoyangLiu/followers","following_url":"https://api.github.com/users/HaoyangLiu/following{/other_user}","gists_url":"https://api.github.com/users/HaoyangLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoyangLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoyangLiu/subscriptions","organizations_url":"https://api.github.com/users/HaoyangLiu/orgs","repos_url":"https://api.github.com/users/HaoyangLiu/repos","events_url":"https://api.github.com/users/HaoyangLiu/events{/privacy}","received_events_url":"https://api.github.com/users/HaoyangLiu/received_events","type":"User","site_admin":false},"body":"This is the contract for atomic swap on Ethereum. Please refer to [BEP3](https://github.com/binance-chain/BEPs/pull/30) for detailed atomic swap mechanism introduction.\r\nThis PR contains two swap contracts, one is for ERC20 and another one is for ETH coin.","created_at":"2019-07-29T07:41:11Z","updated_at":"2019-07-30T06:49:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"debf38f68e3514ed3e55e7ee1a4c56458064c36a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"darren-liu","id":1475446,"node_id":"MDQ6VXNlcjE0NzU0NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1475446?v=4","gravatar_id":"","url":"https://api.github.com/users/darren-liu","html_url":"https://github.com/darren-liu","followers_url":"https://api.github.com/users/darren-liu/followers","following_url":"https://api.github.com/users/darren-liu/following{/other_user}","gists_url":"https://api.github.com/users/darren-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/darren-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darren-liu/subscriptions","organizations_url":"https://api.github.com/users/darren-liu/orgs","repos_url":"https://api.github.com/users/darren-liu/repos","events_url":"https://api.github.com/users/darren-liu/events{/privacy}","received_events_url":"https://api.github.com/users/darren-liu/received_events","type":"User","site_admin":false},{"login":"yutianwu","id":5030187,"node_id":"MDQ6VXNlcjUwMzAxODc=","avatar_url":"https://avatars1.githubusercontent.com/u/5030187?v=4","gravatar_id":"","url":"https://api.github.com/users/yutianwu","html_url":"https://github.com/yutianwu","followers_url":"https://api.github.com/users/yutianwu/followers","following_url":"https://api.github.com/users/yutianwu/following{/other_user}","gists_url":"https://api.github.com/users/yutianwu/gists{/gist_id}","starred_url":"https://api.github.com/users/yutianwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yutianwu/subscriptions","organizations_url":"https://api.github.com/users/yutianwu/orgs","repos_url":"https://api.github.com/users/yutianwu/repos","events_url":"https://api.github.com/users/yutianwu/events{/privacy}","received_events_url":"https://api.github.com/users/yutianwu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/2/commits","review_comments_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/2/comments","review_comment_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues/2/comments","statuses_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/statuses/f8a3bcf657f89a238fcf513fb64725a7ad59a85e","head":{"label":"binance-chain:ethereum-atomicswap-contract","ref":"ethereum-atomicswap-contract","sha":"f8a3bcf657f89a238fcf513fb64725a7ad59a85e","user":{"login":"binance-chain","id":45615063,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NjE1MDYz","avatar_url":"https://avatars0.githubusercontent.com/u/45615063?v=4","gravatar_id":"","url":"https://api.github.com/users/binance-chain","html_url":"https://github.com/binance-chain","followers_url":"https://api.github.com/users/binance-chain/followers","following_url":"https://api.github.com/users/binance-chain/following{/other_user}","gists_url":"https://api.github.com/users/binance-chain/gists{/gist_id}","starred_url":"https://api.github.com/users/binance-chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binance-chain/subscriptions","organizations_url":"https://api.github.com/users/binance-chain/orgs","repos_url":"https://api.github.com/users/binance-chain/repos","events_url":"https://api.github.com/users/binance-chain/events{/privacy}","received_events_url":"https://api.github.com/users/binance-chain/received_events","type":"Organization","site_admin":false},"repo":{"id":198745683,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg3NDU2ODM=","name":"bep3-smartcontracts","full_name":"binance-chain/bep3-smartcontracts","private":false,"owner":{"login":"binance-chain","id":45615063,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NjE1MDYz","avatar_url":"https://avatars0.githubusercontent.com/u/45615063?v=4","gravatar_id":"","url":"https://api.github.com/users/binance-chain","html_url":"https://github.com/binance-chain","followers_url":"https://api.github.com/users/binance-chain/followers","following_url":"https://api.github.com/users/binance-chain/following{/other_user}","gists_url":"https://api.github.com/users/binance-chain/gists{/gist_id}","starred_url":"https://api.github.com/users/binance-chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binance-chain/subscriptions","organizations_url":"https://api.github.com/users/binance-chain/orgs","repos_url":"https://api.github.com/users/binance-chain/repos","events_url":"https://api.github.com/users/binance-chain/events{/privacy}","received_events_url":"https://api.github.com/users/binance-chain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/binance-chain/bep3-smartcontracts","description":"Smart Contracts for BEP3 implementation on different blockchains.","fork":false,"url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts","forks_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/forks","keys_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/teams","hooks_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/hooks","issue_events_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues/events{/number}","events_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/events","assignees_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/assignees{/user}","branches_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/branches{/branch}","tags_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/tags","blobs_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/statuses/{sha}","languages_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/languages","stargazers_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/stargazers","contributors_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/contributors","subscribers_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/subscribers","subscription_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/subscription","commits_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/contents/{+path}","compare_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/merges","archive_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/downloads","issues_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues{/number}","pulls_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls{/number}","milestones_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/milestones{/number}","notifications_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/labels{/name}","releases_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/releases{/id}","deployments_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/deployments","created_at":"2019-07-25T02:55:05Z","updated_at":"2019-07-25T04:12:37Z","pushed_at":"2019-07-30T05:53:48Z","git_url":"git://github.com/binance-chain/bep3-smartcontracts.git","ssh_url":"[email protected]:binance-chain/bep3-smartcontracts.git","clone_url":"https://github.com/binance-chain/bep3-smartcontracts.git","svn_url":"https://github.com/binance-chain/bep3-smartcontracts","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"binance-chain:develop","ref":"develop","sha":"16d7652ff9d58cdb5d52530c1260cb3bb1df5abd","user":{"login":"binance-chain","id":45615063,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NjE1MDYz","avatar_url":"https://avatars0.githubusercontent.com/u/45615063?v=4","gravatar_id":"","url":"https://api.github.com/users/binance-chain","html_url":"https://github.com/binance-chain","followers_url":"https://api.github.com/users/binance-chain/followers","following_url":"https://api.github.com/users/binance-chain/following{/other_user}","gists_url":"https://api.github.com/users/binance-chain/gists{/gist_id}","starred_url":"https://api.github.com/users/binance-chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binance-chain/subscriptions","organizations_url":"https://api.github.com/users/binance-chain/orgs","repos_url":"https://api.github.com/users/binance-chain/repos","events_url":"https://api.github.com/users/binance-chain/events{/privacy}","received_events_url":"https://api.github.com/users/binance-chain/received_events","type":"Organization","site_admin":false},"repo":{"id":198745683,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg3NDU2ODM=","name":"bep3-smartcontracts","full_name":"binance-chain/bep3-smartcontracts","private":false,"owner":{"login":"binance-chain","id":45615063,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NjE1MDYz","avatar_url":"https://avatars0.githubusercontent.com/u/45615063?v=4","gravatar_id":"","url":"https://api.github.com/users/binance-chain","html_url":"https://github.com/binance-chain","followers_url":"https://api.github.com/users/binance-chain/followers","following_url":"https://api.github.com/users/binance-chain/following{/other_user}","gists_url":"https://api.github.com/users/binance-chain/gists{/gist_id}","starred_url":"https://api.github.com/users/binance-chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binance-chain/subscriptions","organizations_url":"https://api.github.com/users/binance-chain/orgs","repos_url":"https://api.github.com/users/binance-chain/repos","events_url":"https://api.github.com/users/binance-chain/events{/privacy}","received_events_url":"https://api.github.com/users/binance-chain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/binance-chain/bep3-smartcontracts","description":"Smart Contracts for BEP3 implementation on different blockchains.","fork":false,"url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts","forks_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/forks","keys_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/teams","hooks_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/hooks","issue_events_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues/events{/number}","events_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/events","assignees_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/assignees{/user}","branches_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/branches{/branch}","tags_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/tags","blobs_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/statuses/{sha}","languages_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/languages","stargazers_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/stargazers","contributors_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/contributors","subscribers_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/subscribers","subscription_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/subscription","commits_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/contents/{+path}","compare_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/merges","archive_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/downloads","issues_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues{/number}","pulls_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls{/number}","milestones_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/milestones{/number}","notifications_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/labels{/name}","releases_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/releases{/id}","deployments_url":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/deployments","created_at":"2019-07-25T02:55:05Z","updated_at":"2019-07-25T04:12:37Z","pushed_at":"2019-07-30T05:53:48Z","git_url":"git://github.com/binance-chain/bep3-smartcontracts.git","ssh_url":"[email protected]:binance-chain/bep3-smartcontracts.git","clone_url":"https://github.com/binance-chain/bep3-smartcontracts.git","svn_url":"https://github.com/binance-chain/bep3-smartcontracts","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/2"},"html":{"href":"https://github.com/binance-chain/bep3-smartcontracts/pull/2"},"issue":{"href":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues/2"},"comments":{"href":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/binance-chain/bep3-smartcontracts/statuses/f8a3bcf657f89a238fcf513fb64725a7ad59a85e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 198745683,
"name": "binance-chain/bep3-smartcontracts",
"url": "https://api.github.com/repos/binance-chain/bep3-smartcontracts"
}
|
{
"id": 38900912,
"login": "rickyyangz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38900912?",
"url": "https://api.github.com/users/rickyyangz"
}
|
{
"id": 45615063,
"login": "binance-chain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45615063?",
"url": "https://api.github.com/orgs/binance-chain"
}
| 2019-07-30T06:49:07 |
10108992499
|
{"actor":{"display_login":"rickyyangz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/comments/334485681","pull_request_review_id":301300542,"id":334485681,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDQ4NTY4MQ==","diff_hunk":"@@ -1,57 +1,62 @@\n package nextstep.mvc;\n \n-import nextstep.mvc.asis.Controller;\n+import nextstep.mvc.tobe.ModelAndView;\n import org.slf4j.Logger;\n import org.slf4j.LoggerFactory;\n \n-import javax.servlet.RequestDispatcher;\n import javax.servlet.ServletException;\n import javax.servlet.annotation.WebServlet;\n import javax.servlet.http.HttpServlet;\n import javax.servlet.http.HttpServletRequest;\n import javax.servlet.http.HttpServletResponse;\n import java.io.IOException;\n+import java.util.Arrays;\n+import java.util.List;\n+import java.util.Objects;\n \n @WebServlet(name = \"dispatcher\", urlPatterns = \"/\", loadOnStartup = 1)\n public class DispatcherServlet extends HttpServlet {\n private static final long serialVersionUID = 1L;\n private static final Logger logger = LoggerFactory.getLogger(DispatcherServlet.class);\n- private static final String DEFAULT_REDIRECT_PREFIX = \"redirect:\";\n \n- private HandlerMapping rm;\n+ private List<HandlerMapping> handlerMappings;\n \n- public DispatcherServlet(HandlerMapping rm) {\n- this.rm = rm;\n+ public DispatcherServlet(final HandlerMapping... handlerMappings) {\n+ this.handlerMappings = Arrays.asList(handlerMappings);\n }\n \n @Override\n- public void init() throws ServletException {\n- rm.initialize();\n+ public void init() {\n+ handlerMappings.forEach(HandlerMapping::initialize);\n }\n \n @Override\n- protected void service(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {\n- String requestUri = req.getRequestURI();\n- logger.debug(\"Method : {}, Request URI : {}\", req.getMethod(), requestUri);\n+ protected void service(final HttpServletRequest request, final HttpServletResponse response) throws ServletException, IOException {\n+ final String requestUri = request.getRequestURI();\n+ logger.debug(\"Method : {}, Request URI : {}\", request.getMethod(), requestUri);\n \n- Controller controller = rm.getHandler(requestUri);\n try {\n- String viewName = controller.execute(req, resp);\n- move(viewName, req, resp);\n- } catch (Throwable e) {\n+ final ModelAndView modelAndView = getModelAndView(request, response);\n+ modelAndView.render(request, response);\n+ } catch (final Throwable e) {\n logger.error(\"Exception : {}\", e);\n throw new ServletException(e.getMessage());\n }\n }\n \n- private void move(String viewName, HttpServletRequest req, HttpServletResponse resp)\n- throws ServletException, IOException {\n- if (viewName.startsWith(DEFAULT_REDIRECT_PREFIX)) {\n- resp.sendRedirect(viewName.substring(DEFAULT_REDIRECT_PREFIX.length()));\n- return;\n- }\n+ private ModelAndView getModelAndView(final HttpServletRequest request, final HttpServletResponse response) {","path":"nextstep-mvc/src/main/java/nextstep/mvc/DispatcherServlet.java","position":68,"original_position":68,"commit_id":"bf6b8c57a516200071dea3cb81911b1729274cc0","original_commit_id":"bf6b8c57a516200071dea3cb81911b1729274cc0","user":{"login":"jeonghoon1107","id":16200738,"node_id":"MDQ6VXNlcjE2MjAwNzM4","avatar_url":"https://avatars0.githubusercontent.com/u/16200738?v=4","gravatar_id":"","url":"https://api.github.com/users/jeonghoon1107","html_url":"https://github.com/jeonghoon1107","followers_url":"https://api.github.com/users/jeonghoon1107/followers","following_url":"https://api.github.com/users/jeonghoon1107/following{/other_user}","gists_url":"https://api.github.com/users/jeonghoon1107/gists{/gist_id}","starred_url":"https://api.github.com/users/jeonghoon1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeonghoon1107/subscriptions","organizations_url":"https://api.github.com/users/jeonghoon1107/orgs","repos_url":"https://api.github.com/users/jeonghoon1107/repos","events_url":"https://api.github.com/users/jeonghoon1107/events{/privacy}","received_events_url":"https://api.github.com/users/jeonghoon1107/received_events","type":"User","site_admin":false},"body":"ํด๋น ๋ฉ์๋์์ ํ๋ ์ผ์ด ๋๋ฌด ๋ง๋ค์. ๋ฉ์๋๊ฐ ๋ ๋ถ๋ฆฌ๋๋ฉด ์ข์ ๊ฒ ๊ฐ์์.","created_at":"2019-10-14T13:36:14Z","updated_at":"2019-10-14T13:38:57Z","html_url":"https://github.com/woowacourse/jwp-mvc/pull/83#discussion_r334485681","pull_request_url":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/83","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/comments/334485681"},"html":{"href":"https://github.com/woowacourse/jwp-mvc/pull/83#discussion_r334485681"},"pull_request":{"href":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/83","id":327685939,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3Njg1OTM5","html_url":"https://github.com/woowacourse/jwp-mvc/pull/83","diff_url":"https://github.com/woowacourse/jwp-mvc/pull/83.diff","patch_url":"https://github.com/woowacourse/jwp-mvc/pull/83.patch","issue_url":"https://api.github.com/repos/woowacourse/jwp-mvc/issues/83","number":83,"state":"open","locked":false,"title":"[MVC - Step 1] ํฐ๊ณฐ ๋ฏธ์
์ ์ถํฉ๋๋ค.","user":{"login":"kunggom","id":32009637,"node_id":"MDQ6VXNlcjMyMDA5NjM3","avatar_url":"https://avatars2.githubusercontent.com/u/32009637?v=4","gravatar_id":"","url":"https://api.github.com/users/kunggom","html_url":"https://github.com/kunggom","followers_url":"https://api.github.com/users/kunggom/followers","following_url":"https://api.github.com/users/kunggom/following{/other_user}","gists_url":"https://api.github.com/users/kunggom/gists{/gist_id}","starred_url":"https://api.github.com/users/kunggom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunggom/subscriptions","organizations_url":"https://api.github.com/users/kunggom/orgs","repos_url":"https://api.github.com/users/kunggom/repos","events_url":"https://api.github.com/users/kunggom/events{/privacy}","received_events_url":"https://api.github.com/users/kunggom/received_events","type":"User","site_admin":false},"body":"๋ฆ๊ฒ ์ ์ถ๋๋ ค ์ฃ์กํฉ๋๋ค. ์ผ๋จ ํ๋ ๋ฐ๊น์ง๋ ํด๋ดค์ต๋๋ค.","created_at":"2019-10-14T08:08:36Z","updated_at":"2019-10-14T13:38:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82eee3caea8e07958c657113f628c659f76743c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/83/commits","review_comments_url":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/83/comments","review_comment_url":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woowacourse/jwp-mvc/issues/83/comments","statuses_url":"https://api.github.com/repos/woowacourse/jwp-mvc/statuses/bf6b8c57a516200071dea3cb81911b1729274cc0","head":{"label":"kunggom:kunggom","ref":"kunggom","sha":"bf6b8c57a516200071dea3cb81911b1729274cc0","user":{"login":"kunggom","id":32009637,"node_id":"MDQ6VXNlcjMyMDA5NjM3","avatar_url":"https://avatars2.githubusercontent.com/u/32009637?v=4","gravatar_id":"","url":"https://api.github.com/users/kunggom","html_url":"https://github.com/kunggom","followers_url":"https://api.github.com/users/kunggom/followers","following_url":"https://api.github.com/users/kunggom/following{/other_user}","gists_url":"https://api.github.com/users/kunggom/gists{/gist_id}","starred_url":"https://api.github.com/users/kunggom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunggom/subscriptions","organizations_url":"https://api.github.com/users/kunggom/orgs","repos_url":"https://api.github.com/users/kunggom/repos","events_url":"https://api.github.com/users/kunggom/events{/privacy}","received_events_url":"https://api.github.com/users/kunggom/received_events","type":"User","site_admin":false},"repo":{"id":211991470,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE5OTE0NzA=","name":"jwp-mvc","full_name":"kunggom/jwp-mvc","private":false,"owner":{"login":"kunggom","id":32009637,"node_id":"MDQ6VXNlcjMyMDA5NjM3","avatar_url":"https://avatars2.githubusercontent.com/u/32009637?v=4","gravatar_id":"","url":"https://api.github.com/users/kunggom","html_url":"https://github.com/kunggom","followers_url":"https://api.github.com/users/kunggom/followers","following_url":"https://api.github.com/users/kunggom/following{/other_user}","gists_url":"https://api.github.com/users/kunggom/gists{/gist_id}","starred_url":"https://api.github.com/users/kunggom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunggom/subscriptions","organizations_url":"https://api.github.com/users/kunggom/orgs","repos_url":"https://api.github.com/users/kunggom/repos","events_url":"https://api.github.com/users/kunggom/events{/privacy}","received_events_url":"https://api.github.com/users/kunggom/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kunggom/jwp-mvc","description":"MVC ํ๋ ์์ํฌ ๋ฏธ์
์ ์ํ ์ ์ฅ์","fork":true,"url":"https://api.github.com/repos/kunggom/jwp-mvc","forks_url":"https://api.github.com/repos/kunggom/jwp-mvc/forks","keys_url":"https://api.github.com/repos/kunggom/jwp-mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kunggom/jwp-mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kunggom/jwp-mvc/teams","hooks_url":"https://api.github.com/repos/kunggom/jwp-mvc/hooks","issue_events_url":"https://api.github.com/repos/kunggom/jwp-mvc/issues/events{/number}","events_url":"https://api.github.com/repos/kunggom/jwp-mvc/events","assignees_url":"https://api.github.com/repos/kunggom/jwp-mvc/assignees{/user}","branches_url":"https://api.github.com/repos/kunggom/jwp-mvc/branches{/branch}","tags_url":"https://api.github.com/repos/kunggom/jwp-mvc/tags","blobs_url":"https://api.github.com/repos/kunggom/jwp-mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kunggom/jwp-mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kunggom/jwp-mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kunggom/jwp-mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kunggom/jwp-mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/kunggom/jwp-mvc/languages","stargazers_url":"https://api.github.com/repos/kunggom/jwp-mvc/stargazers","contributors_url":"https://api.github.com/repos/kunggom/jwp-mvc/contributors","subscribers_url":"https://api.github.com/repos/kunggom/jwp-mvc/subscribers","subscription_url":"https://api.github.com/repos/kunggom/jwp-mvc/subscription","commits_url":"https://api.github.com/repos/kunggom/jwp-mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kunggom/jwp-mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kunggom/jwp-mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kunggom/jwp-mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kunggom/jwp-mvc/contents/{+path}","compare_url":"https://api.github.com/repos/kunggom/jwp-mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kunggom/jwp-mvc/merges","archive_url":"https://api.github.com/repos/kunggom/jwp-mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kunggom/jwp-mvc/downloads","issues_url":"https://api.github.com/repos/kunggom/jwp-mvc/issues{/number}","pulls_url":"https://api.github.com/repos/kunggom/jwp-mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/kunggom/jwp-mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/kunggom/jwp-mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kunggom/jwp-mvc/labels{/name}","releases_url":"https://api.github.com/repos/kunggom/jwp-mvc/releases{/id}","deployments_url":"https://api.github.com/repos/kunggom/jwp-mvc/deployments","created_at":"2019-10-01T01:35:16Z","updated_at":"2019-10-01T01:35:17Z","pushed_at":"2019-10-14T08:01:13Z","git_url":"git://github.com/kunggom/jwp-mvc.git","ssh_url":"[email protected]:kunggom/jwp-mvc.git","clone_url":"https://github.com/kunggom/jwp-mvc.git","svn_url":"https://github.com/kunggom/jwp-mvc","homepage":null,"size":2340,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"woowacourse:kunggom","ref":"kunggom","sha":"21f74099ac2f9cba3412249c49cbf5996aa3dee7","user":{"login":"woowacourse","id":45747236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NzQ3MjM2","avatar_url":"https://avatars2.githubusercontent.com/u/45747236?v=4","gravatar_id":"","url":"https://api.github.com/users/woowacourse","html_url":"https://github.com/woowacourse","followers_url":"https://api.github.com/users/woowacourse/followers","following_url":"https://api.github.com/users/woowacourse/following{/other_user}","gists_url":"https://api.github.com/users/woowacourse/gists{/gist_id}","starred_url":"https://api.github.com/users/woowacourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woowacourse/subscriptions","organizations_url":"https://api.github.com/users/woowacourse/orgs","repos_url":"https://api.github.com/users/woowacourse/repos","events_url":"https://api.github.com/users/woowacourse/events{/privacy}","received_events_url":"https://api.github.com/users/woowacourse/received_events","type":"Organization","site_admin":false},"repo":{"id":204622561,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ2MjI1NjE=","name":"jwp-mvc","full_name":"woowacourse/jwp-mvc","private":false,"owner":{"login":"woowacourse","id":45747236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1NzQ3MjM2","avatar_url":"https://avatars2.githubusercontent.com/u/45747236?v=4","gravatar_id":"","url":"https://api.github.com/users/woowacourse","html_url":"https://github.com/woowacourse","followers_url":"https://api.github.com/users/woowacourse/followers","following_url":"https://api.github.com/users/woowacourse/following{/other_user}","gists_url":"https://api.github.com/users/woowacourse/gists{/gist_id}","starred_url":"https://api.github.com/users/woowacourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woowacourse/subscriptions","organizations_url":"https://api.github.com/users/woowacourse/orgs","repos_url":"https://api.github.com/users/woowacourse/repos","events_url":"https://api.github.com/users/woowacourse/events{/privacy}","received_events_url":"https://api.github.com/users/woowacourse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/woowacourse/jwp-mvc","description":"MVC ํ๋ ์์ํฌ ๋ฏธ์
์ ์ํ ์ ์ฅ์","fork":false,"url":"https://api.github.com/repos/woowacourse/jwp-mvc","forks_url":"https://api.github.com/repos/woowacourse/jwp-mvc/forks","keys_url":"https://api.github.com/repos/woowacourse/jwp-mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woowacourse/jwp-mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woowacourse/jwp-mvc/teams","hooks_url":"https://api.github.com/repos/woowacourse/jwp-mvc/hooks","issue_events_url":"https://api.github.com/repos/woowacourse/jwp-mvc/issues/events{/number}","events_url":"https://api.github.com/repos/woowacourse/jwp-mvc/events","assignees_url":"https://api.github.com/repos/woowacourse/jwp-mvc/assignees{/user}","branches_url":"https://api.github.com/repos/woowacourse/jwp-mvc/branches{/branch}","tags_url":"https://api.github.com/repos/woowacourse/jwp-mvc/tags","blobs_url":"https://api.github.com/repos/woowacourse/jwp-mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woowacourse/jwp-mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woowacourse/jwp-mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/woowacourse/jwp-mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woowacourse/jwp-mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/woowacourse/jwp-mvc/languages","stargazers_url":"https://api.github.com/repos/woowacourse/jwp-mvc/stargazers","contributors_url":"https://api.github.com/repos/woowacourse/jwp-mvc/contributors","subscribers_url":"https://api.github.com/repos/woowacourse/jwp-mvc/subscribers","subscription_url":"https://api.github.com/repos/woowacourse/jwp-mvc/subscription","commits_url":"https://api.github.com/repos/woowacourse/jwp-mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/woowacourse/jwp-mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/woowacourse/jwp-mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/woowacourse/jwp-mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/woowacourse/jwp-mvc/contents/{+path}","compare_url":"https://api.github.com/repos/woowacourse/jwp-mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woowacourse/jwp-mvc/merges","archive_url":"https://api.github.com/repos/woowacourse/jwp-mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woowacourse/jwp-mvc/downloads","issues_url":"https://api.github.com/repos/woowacourse/jwp-mvc/issues{/number}","pulls_url":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/woowacourse/jwp-mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/woowacourse/jwp-mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woowacourse/jwp-mvc/labels{/name}","releases_url":"https://api.github.com/repos/woowacourse/jwp-mvc/releases{/id}","deployments_url":"https://api.github.com/repos/woowacourse/jwp-mvc/deployments","created_at":"2019-08-27T04:55:24Z","updated_at":"2019-10-02T04:36:03Z","pushed_at":"2019-10-14T13:18:03Z","git_url":"git://github.com/woowacourse/jwp-mvc.git","ssh_url":"[email protected]:woowacourse/jwp-mvc.git","clone_url":"https://github.com/woowacourse/jwp-mvc.git","svn_url":"https://github.com/woowacourse/jwp-mvc","homepage":null,"size":3313,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":null,"forks":46,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/83"},"html":{"href":"https://github.com/woowacourse/jwp-mvc/pull/83"},"issue":{"href":"https://api.github.com/repos/woowacourse/jwp-mvc/issues/83"},"comments":{"href":"https://api.github.com/repos/woowacourse/jwp-mvc/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woowacourse/jwp-mvc/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/woowacourse/jwp-mvc/statuses/bf6b8c57a516200071dea3cb81911b1729274cc0"}},"author_association":"NONE"}}
|
{
"id": 204622561,
"name": "woowacourse/jwp-mvc",
"url": "https://api.github.com/repos/woowacourse/jwp-mvc"
}
|
{
"id": 16200738,
"login": "jeonghoon1107",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16200738?",
"url": "https://api.github.com/users/jeonghoon1107"
}
|
{
"id": 45747236,
"login": "woowacourse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45747236?",
"url": "https://api.github.com/orgs/woowacourse"
}
| 2019-10-14T13:36:14 |
10624991151
|
{"actor":{"display_login":"jeonghoon1107"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/outcastby/ext/pulls/comments/275946503","pull_request_review_id":227385591,"id":275946503,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTk0NjUwMw==","diff_hunk":"@@ -23,6 +23,22 @@ defmodule Ext.Ecto.Repo do\n query |> Ecto.Query.limit(1) |> one()\n end\n \n+ def where(query, {:or, params}) do\n+ previous_query = query\n+ params\n+ |> Enum.with_index()\n+ |> Enum.reduce(query, fn {expression, index}, query ->\n+ new_query = Enum.reduce(Ext.Utils.Base.atomize_keys(expression), previous_query, &compose_query/2)\n+\n+ if index == 0, do: query, else: :or\n+\n+ case index do\n+ 0 -> new_query\n+ _ -> query |> union(^new_query)","path":"lib/ext/ecto/repo.ex","position":15,"original_position":15,"commit_id":"4efd111d19b9de88d92a0b86fd67232c59a73b77","original_commit_id":"4efd111d19b9de88d92a0b86fd67232c59a73b77","user":{"login":"miheykrug","id":23484059,"node_id":"MDQ6VXNlcjIzNDg0MDU5","avatar_url":"https://avatars0.githubusercontent.com/u/23484059?v=4","gravatar_id":"","url":"https://api.github.com/users/miheykrug","html_url":"https://github.com/miheykrug","followers_url":"https://api.github.com/users/miheykrug/followers","following_url":"https://api.github.com/users/miheykrug/following{/other_user}","gists_url":"https://api.github.com/users/miheykrug/gists{/gist_id}","starred_url":"https://api.github.com/users/miheykrug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miheykrug/subscriptions","organizations_url":"https://api.github.com/users/miheykrug/orgs","repos_url":"https://api.github.com/users/miheykrug/repos","events_url":"https://api.github.com/users/miheykrug/events{/privacy}","received_events_url":"https://api.github.com/users/miheykrug/received_events","type":"User","site_admin":false},"body":"ะะพะถะตั ั ัะตะฑั ะฑัะดัั ะบะฐะบะธะต ะผััะปะธ?","created_at":"2019-04-16T18:59:04Z","updated_at":"2019-04-16T18:59:04Z","html_url":"https://github.com/outcastby/ext/pull/12#discussion_r275946503","pull_request_url":"https://api.github.com/repos/outcastby/ext/pulls/12","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/outcastby/ext/pulls/comments/275946503"},"html":{"href":"https://github.com/outcastby/ext/pull/12#discussion_r275946503"},"pull_request":{"href":"https://api.github.com/repos/outcastby/ext/pulls/12"}},"in_reply_to_id":275886929},"pull_request":{"url":"https://api.github.com/repos/outcastby/ext/pulls/12","id":270798065,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNzk4MDY1","html_url":"https://github.com/outcastby/ext/pull/12","diff_url":"https://github.com/outcastby/ext/pull/12.diff","patch_url":"https://github.com/outcastby/ext/pull/12.patch","issue_url":"https://api.github.com/repos/outcastby/ext/issues/12","number":12,"state":"open","locked":false,"title":"Add \"or\" for where method","user":{"login":"miheykrug","id":23484059,"node_id":"MDQ6VXNlcjIzNDg0MDU5","avatar_url":"https://avatars0.githubusercontent.com/u/23484059?v=4","gravatar_id":"","url":"https://api.github.com/users/miheykrug","html_url":"https://github.com/miheykrug","followers_url":"https://api.github.com/users/miheykrug/followers","following_url":"https://api.github.com/users/miheykrug/following{/other_user}","gists_url":"https://api.github.com/users/miheykrug/gists{/gist_id}","starred_url":"https://api.github.com/users/miheykrug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miheykrug/subscriptions","organizations_url":"https://api.github.com/users/miheykrug/orgs","repos_url":"https://api.github.com/users/miheykrug/repos","events_url":"https://api.github.com/users/miheykrug/events{/privacy}","received_events_url":"https://api.github.com/users/miheykrug/received_events","type":"User","site_admin":false},"body":"https://trulysocialgames.atlassian.net/browse/GM-1134","created_at":"2019-04-16T08:10:23Z","updated_at":"2019-04-16T18:59:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1fc8859fcde1c297814b51d95fab6fb702dfcb6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"atanych","id":10116909,"node_id":"MDQ6VXNlcjEwMTE2OTA5","avatar_url":"https://avatars3.githubusercontent.com/u/10116909?v=4","gravatar_id":"","url":"https://api.github.com/users/atanych","html_url":"https://github.com/atanych","followers_url":"https://api.github.com/users/atanych/followers","following_url":"https://api.github.com/users/atanych/following{/other_user}","gists_url":"https://api.github.com/users/atanych/gists{/gist_id}","starred_url":"https://api.github.com/users/atanych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atanych/subscriptions","organizations_url":"https://api.github.com/users/atanych/orgs","repos_url":"https://api.github.com/users/atanych/repos","events_url":"https://api.github.com/users/atanych/events{/privacy}","received_events_url":"https://api.github.com/users/atanych/received_events","type":"User","site_admin":false},{"login":"DenisLutski","id":11726848,"node_id":"MDQ6VXNlcjExNzI2ODQ4","avatar_url":"https://avatars3.githubusercontent.com/u/11726848?v=4","gravatar_id":"","url":"https://api.github.com/users/DenisLutski","html_url":"https://github.com/DenisLutski","followers_url":"https://api.github.com/users/DenisLutski/followers","following_url":"https://api.github.com/users/DenisLutski/following{/other_user}","gists_url":"https://api.github.com/users/DenisLutski/gists{/gist_id}","starred_url":"https://api.github.com/users/DenisLutski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenisLutski/subscriptions","organizations_url":"https://api.github.com/users/DenisLutski/orgs","repos_url":"https://api.github.com/users/DenisLutski/repos","events_url":"https://api.github.com/users/DenisLutski/events{/privacy}","received_events_url":"https://api.github.com/users/DenisLutski/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/outcastby/ext/pulls/12/commits","review_comments_url":"https://api.github.com/repos/outcastby/ext/pulls/12/comments","review_comment_url":"https://api.github.com/repos/outcastby/ext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/outcastby/ext/issues/12/comments","statuses_url":"https://api.github.com/repos/outcastby/ext/statuses/4efd111d19b9de88d92a0b86fd67232c59a73b77","head":{"label":"outcastby:feature/or-where","ref":"feature/or-where","sha":"4efd111d19b9de88d92a0b86fd67232c59a73b77","user":{"login":"outcastby","id":45963401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTYzNDAx","avatar_url":"https://avatars1.githubusercontent.com/u/45963401?v=4","gravatar_id":"","url":"https://api.github.com/users/outcastby","html_url":"https://github.com/outcastby","followers_url":"https://api.github.com/users/outcastby/followers","following_url":"https://api.github.com/users/outcastby/following{/other_user}","gists_url":"https://api.github.com/users/outcastby/gists{/gist_id}","starred_url":"https://api.github.com/users/outcastby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outcastby/subscriptions","organizations_url":"https://api.github.com/users/outcastby/orgs","repos_url":"https://api.github.com/users/outcastby/repos","events_url":"https://api.github.com/users/outcastby/events{/privacy}","received_events_url":"https://api.github.com/users/outcastby/received_events","type":"Organization","site_admin":false},"repo":{"id":162412210,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI0MTIyMTA=","name":"ext","full_name":"outcastby/ext","private":false,"owner":{"login":"outcastby","id":45963401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTYzNDAx","avatar_url":"https://avatars1.githubusercontent.com/u/45963401?v=4","gravatar_id":"","url":"https://api.github.com/users/outcastby","html_url":"https://github.com/outcastby","followers_url":"https://api.github.com/users/outcastby/followers","following_url":"https://api.github.com/users/outcastby/following{/other_user}","gists_url":"https://api.github.com/users/outcastby/gists{/gist_id}","starred_url":"https://api.github.com/users/outcastby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outcastby/subscriptions","organizations_url":"https://api.github.com/users/outcastby/orgs","repos_url":"https://api.github.com/users/outcastby/repos","events_url":"https://api.github.com/users/outcastby/events{/privacy}","received_events_url":"https://api.github.com/users/outcastby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/outcastby/ext","description":null,"fork":false,"url":"https://api.github.com/repos/outcastby/ext","forks_url":"https://api.github.com/repos/outcastby/ext/forks","keys_url":"https://api.github.com/repos/outcastby/ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/outcastby/ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/outcastby/ext/teams","hooks_url":"https://api.github.com/repos/outcastby/ext/hooks","issue_events_url":"https://api.github.com/repos/outcastby/ext/issues/events{/number}","events_url":"https://api.github.com/repos/outcastby/ext/events","assignees_url":"https://api.github.com/repos/outcastby/ext/assignees{/user}","branches_url":"https://api.github.com/repos/outcastby/ext/branches{/branch}","tags_url":"https://api.github.com/repos/outcastby/ext/tags","blobs_url":"https://api.github.com/repos/outcastby/ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/outcastby/ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/outcastby/ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/outcastby/ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/outcastby/ext/statuses/{sha}","languages_url":"https://api.github.com/repos/outcastby/ext/languages","stargazers_url":"https://api.github.com/repos/outcastby/ext/stargazers","contributors_url":"https://api.github.com/repos/outcastby/ext/contributors","subscribers_url":"https://api.github.com/repos/outcastby/ext/subscribers","subscription_url":"https://api.github.com/repos/outcastby/ext/subscription","commits_url":"https://api.github.com/repos/outcastby/ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/outcastby/ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/outcastby/ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/outcastby/ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/outcastby/ext/contents/{+path}","compare_url":"https://api.github.com/repos/outcastby/ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/outcastby/ext/merges","archive_url":"https://api.github.com/repos/outcastby/ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/outcastby/ext/downloads","issues_url":"https://api.github.com/repos/outcastby/ext/issues{/number}","pulls_url":"https://api.github.com/repos/outcastby/ext/pulls{/number}","milestones_url":"https://api.github.com/repos/outcastby/ext/milestones{/number}","notifications_url":"https://api.github.com/repos/outcastby/ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/outcastby/ext/labels{/name}","releases_url":"https://api.github.com/repos/outcastby/ext/releases{/id}","deployments_url":"https://api.github.com/repos/outcastby/ext/deployments","created_at":"2018-12-19T09:13:02Z","updated_at":"2019-04-11T15:25:14Z","pushed_at":"2019-04-16T16:26:25Z","git_url":"git://github.com/outcastby/ext.git","ssh_url":"[email protected]:outcastby/ext.git","clone_url":"https://github.com/outcastby/ext.git","svn_url":"https://github.com/outcastby/ext","homepage":null,"size":94,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"outcastby:master","ref":"master","sha":"ed0d3b3a118986262aeb2ac87cd22f41ce0c109f","user":{"login":"outcastby","id":45963401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTYzNDAx","avatar_url":"https://avatars1.githubusercontent.com/u/45963401?v=4","gravatar_id":"","url":"https://api.github.com/users/outcastby","html_url":"https://github.com/outcastby","followers_url":"https://api.github.com/users/outcastby/followers","following_url":"https://api.github.com/users/outcastby/following{/other_user}","gists_url":"https://api.github.com/users/outcastby/gists{/gist_id}","starred_url":"https://api.github.com/users/outcastby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outcastby/subscriptions","organizations_url":"https://api.github.com/users/outcastby/orgs","repos_url":"https://api.github.com/users/outcastby/repos","events_url":"https://api.github.com/users/outcastby/events{/privacy}","received_events_url":"https://api.github.com/users/outcastby/received_events","type":"Organization","site_admin":false},"repo":{"id":162412210,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI0MTIyMTA=","name":"ext","full_name":"outcastby/ext","private":false,"owner":{"login":"outcastby","id":45963401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTYzNDAx","avatar_url":"https://avatars1.githubusercontent.com/u/45963401?v=4","gravatar_id":"","url":"https://api.github.com/users/outcastby","html_url":"https://github.com/outcastby","followers_url":"https://api.github.com/users/outcastby/followers","following_url":"https://api.github.com/users/outcastby/following{/other_user}","gists_url":"https://api.github.com/users/outcastby/gists{/gist_id}","starred_url":"https://api.github.com/users/outcastby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outcastby/subscriptions","organizations_url":"https://api.github.com/users/outcastby/orgs","repos_url":"https://api.github.com/users/outcastby/repos","events_url":"https://api.github.com/users/outcastby/events{/privacy}","received_events_url":"https://api.github.com/users/outcastby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/outcastby/ext","description":null,"fork":false,"url":"https://api.github.com/repos/outcastby/ext","forks_url":"https://api.github.com/repos/outcastby/ext/forks","keys_url":"https://api.github.com/repos/outcastby/ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/outcastby/ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/outcastby/ext/teams","hooks_url":"https://api.github.com/repos/outcastby/ext/hooks","issue_events_url":"https://api.github.com/repos/outcastby/ext/issues/events{/number}","events_url":"https://api.github.com/repos/outcastby/ext/events","assignees_url":"https://api.github.com/repos/outcastby/ext/assignees{/user}","branches_url":"https://api.github.com/repos/outcastby/ext/branches{/branch}","tags_url":"https://api.github.com/repos/outcastby/ext/tags","blobs_url":"https://api.github.com/repos/outcastby/ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/outcastby/ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/outcastby/ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/outcastby/ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/outcastby/ext/statuses/{sha}","languages_url":"https://api.github.com/repos/outcastby/ext/languages","stargazers_url":"https://api.github.com/repos/outcastby/ext/stargazers","contributors_url":"https://api.github.com/repos/outcastby/ext/contributors","subscribers_url":"https://api.github.com/repos/outcastby/ext/subscribers","subscription_url":"https://api.github.com/repos/outcastby/ext/subscription","commits_url":"https://api.github.com/repos/outcastby/ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/outcastby/ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/outcastby/ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/outcastby/ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/outcastby/ext/contents/{+path}","compare_url":"https://api.github.com/repos/outcastby/ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/outcastby/ext/merges","archive_url":"https://api.github.com/repos/outcastby/ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/outcastby/ext/downloads","issues_url":"https://api.github.com/repos/outcastby/ext/issues{/number}","pulls_url":"https://api.github.com/repos/outcastby/ext/pulls{/number}","milestones_url":"https://api.github.com/repos/outcastby/ext/milestones{/number}","notifications_url":"https://api.github.com/repos/outcastby/ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/outcastby/ext/labels{/name}","releases_url":"https://api.github.com/repos/outcastby/ext/releases{/id}","deployments_url":"https://api.github.com/repos/outcastby/ext/deployments","created_at":"2018-12-19T09:13:02Z","updated_at":"2019-04-11T15:25:14Z","pushed_at":"2019-04-16T16:26:25Z","git_url":"git://github.com/outcastby/ext.git","ssh_url":"[email protected]:outcastby/ext.git","clone_url":"https://github.com/outcastby/ext.git","svn_url":"https://github.com/outcastby/ext","homepage":null,"size":94,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/outcastby/ext/pulls/12"},"html":{"href":"https://github.com/outcastby/ext/pull/12"},"issue":{"href":"https://api.github.com/repos/outcastby/ext/issues/12"},"comments":{"href":"https://api.github.com/repos/outcastby/ext/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/outcastby/ext/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/outcastby/ext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/outcastby/ext/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/outcastby/ext/statuses/4efd111d19b9de88d92a0b86fd67232c59a73b77"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 162412210,
"name": "outcastby/ext",
"url": "https://api.github.com/repos/outcastby/ext"
}
|
{
"id": 23484059,
"login": "miheykrug",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23484059?",
"url": "https://api.github.com/users/miheykrug"
}
|
{
"id": 45963401,
"login": "outcastby",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45963401?",
"url": "https://api.github.com/orgs/outcastby"
}
| 2019-04-16T18:59:04 |
9455724671
|
{"actor":{"display_login":"miheykrug"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/govinu/govinu/pulls/comments/263725404","pull_request_review_id":212215502,"id":263725404,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzcyNTQwNA==","diff_hunk":"@@ -1,8 +1,15 @@\n-import { ApolloClient, InMemoryCache } from 'apollo-boost'\n+import {\n+ ApolloClient,\n+ InMemoryCache,\n+ IntrospectionFragmentMatcher\n+} from 'apollo-boost'\n import { createHttpLink } from 'apollo-link-http'\n import { setContext } from 'apollo-link-context'\n import fetch from 'isomorphic-unfetch'\n \n+/* eslint-disable-next-line */","path":"client/lib/initApollo.js","position":11,"original_position":11,"commit_id":"9babc85b69e1cd706fcc099d7643037ddf37edd2","original_commit_id":"9babc85b69e1cd706fcc099d7643037ddf37edd2","user":{"login":"andersklenke","id":3286533,"node_id":"MDQ6VXNlcjMyODY1MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/3286533?v=4","gravatar_id":"","url":"https://api.github.com/users/andersklenke","html_url":"https://github.com/andersklenke","followers_url":"https://api.github.com/users/andersklenke/followers","following_url":"https://api.github.com/users/andersklenke/following{/other_user}","gists_url":"https://api.github.com/users/andersklenke/gists{/gist_id}","starred_url":"https://api.github.com/users/andersklenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersklenke/subscriptions","organizations_url":"https://api.github.com/users/andersklenke/orgs","repos_url":"https://api.github.com/users/andersklenke/repos","events_url":"https://api.github.com/users/andersklenke/events{/privacy}","received_events_url":"https://api.github.com/users/andersklenke/received_events","type":"User","site_admin":false},"body":"I see alot of these. Are they all needed? ","created_at":"2019-03-08T10:04:54Z","updated_at":"2019-03-08T10:04:55Z","html_url":"https://github.com/govinu/govinu/pull/134#discussion_r263725404","pull_request_url":"https://api.github.com/repos/govinu/govinu/pulls/134","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/govinu/govinu/pulls/comments/263725404"},"html":{"href":"https://github.com/govinu/govinu/pull/134#discussion_r263725404"},"pull_request":{"href":"https://api.github.com/repos/govinu/govinu/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/govinu/govinu/pulls/134","id":259398753,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5Mzk4NzUz","html_url":"https://github.com/govinu/govinu/pull/134","diff_url":"https://github.com/govinu/govinu/pull/134.diff","patch_url":"https://github.com/govinu/govinu/pull/134.patch","issue_url":"https://api.github.com/repos/govinu/govinu/issues/134","number":134,"state":"open","locked":false,"title":"Fix fragments on interfaces error","user":{"login":"madsobel","id":5732559,"node_id":"MDQ6VXNlcjU3MzI1NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5732559?v=4","gravatar_id":"","url":"https://api.github.com/users/madsobel","html_url":"https://github.com/madsobel","followers_url":"https://api.github.com/users/madsobel/followers","following_url":"https://api.github.com/users/madsobel/following{/other_user}","gists_url":"https://api.github.com/users/madsobel/gists{/gist_id}","starred_url":"https://api.github.com/users/madsobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madsobel/subscriptions","organizations_url":"https://api.github.com/users/madsobel/orgs","repos_url":"https://api.github.com/users/madsobel/repos","events_url":"https://api.github.com/users/madsobel/events{/privacy}","received_events_url":"https://api.github.com/users/madsobel/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-08T08:29:08Z","updated_at":"2019-03-08T10:04:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb6013be5785b978cafc2250114a7c7f4659e4b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/govinu/govinu/pulls/134/commits","review_comments_url":"https://api.github.com/repos/govinu/govinu/pulls/134/comments","review_comment_url":"https://api.github.com/repos/govinu/govinu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/govinu/govinu/issues/134/comments","statuses_url":"https://api.github.com/repos/govinu/govinu/statuses/9babc85b69e1cd706fcc099d7643037ddf37edd2","head":{"label":"govinu:fix-fragment-interfaces","ref":"fix-fragment-interfaces","sha":"9babc85b69e1cd706fcc099d7643037ddf37edd2","user":{"login":"govinu","id":46092538,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDkyNTM4","avatar_url":"https://avatars2.githubusercontent.com/u/46092538?v=4","gravatar_id":"","url":"https://api.github.com/users/govinu","html_url":"https://github.com/govinu","followers_url":"https://api.github.com/users/govinu/followers","following_url":"https://api.github.com/users/govinu/following{/other_user}","gists_url":"https://api.github.com/users/govinu/gists{/gist_id}","starred_url":"https://api.github.com/users/govinu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govinu/subscriptions","organizations_url":"https://api.github.com/users/govinu/orgs","repos_url":"https://api.github.com/users/govinu/repos","events_url":"https://api.github.com/users/govinu/events{/privacy}","received_events_url":"https://api.github.com/users/govinu/received_events","type":"Organization","site_admin":false},"repo":{"id":162478160,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI0NzgxNjA=","name":"govinu","full_name":"govinu/govinu","private":false,"owner":{"login":"govinu","id":46092538,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDkyNTM4","avatar_url":"https://avatars2.githubusercontent.com/u/46092538?v=4","gravatar_id":"","url":"https://api.github.com/users/govinu","html_url":"https://github.com/govinu","followers_url":"https://api.github.com/users/govinu/followers","following_url":"https://api.github.com/users/govinu/following{/other_user}","gists_url":"https://api.github.com/users/govinu/gists{/gist_id}","starred_url":"https://api.github.com/users/govinu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govinu/subscriptions","organizations_url":"https://api.github.com/users/govinu/orgs","repos_url":"https://api.github.com/users/govinu/repos","events_url":"https://api.github.com/users/govinu/events{/privacy}","received_events_url":"https://api.github.com/users/govinu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/govinu/govinu","description":null,"fork":false,"url":"https://api.github.com/repos/govinu/govinu","forks_url":"https://api.github.com/repos/govinu/govinu/forks","keys_url":"https://api.github.com/repos/govinu/govinu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/govinu/govinu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/govinu/govinu/teams","hooks_url":"https://api.github.com/repos/govinu/govinu/hooks","issue_events_url":"https://api.github.com/repos/govinu/govinu/issues/events{/number}","events_url":"https://api.github.com/repos/govinu/govinu/events","assignees_url":"https://api.github.com/repos/govinu/govinu/assignees{/user}","branches_url":"https://api.github.com/repos/govinu/govinu/branches{/branch}","tags_url":"https://api.github.com/repos/govinu/govinu/tags","blobs_url":"https://api.github.com/repos/govinu/govinu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/govinu/govinu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/govinu/govinu/git/refs{/sha}","trees_url":"https://api.github.com/repos/govinu/govinu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/govinu/govinu/statuses/{sha}","languages_url":"https://api.github.com/repos/govinu/govinu/languages","stargazers_url":"https://api.github.com/repos/govinu/govinu/stargazers","contributors_url":"https://api.github.com/repos/govinu/govinu/contributors","subscribers_url":"https://api.github.com/repos/govinu/govinu/subscribers","subscription_url":"https://api.github.com/repos/govinu/govinu/subscription","commits_url":"https://api.github.com/repos/govinu/govinu/commits{/sha}","git_commits_url":"https://api.github.com/repos/govinu/govinu/git/commits{/sha}","comments_url":"https://api.github.com/repos/govinu/govinu/comments{/number}","issue_comment_url":"https://api.github.com/repos/govinu/govinu/issues/comments{/number}","contents_url":"https://api.github.com/repos/govinu/govinu/contents/{+path}","compare_url":"https://api.github.com/repos/govinu/govinu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/govinu/govinu/merges","archive_url":"https://api.github.com/repos/govinu/govinu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/govinu/govinu/downloads","issues_url":"https://api.github.com/repos/govinu/govinu/issues{/number}","pulls_url":"https://api.github.com/repos/govinu/govinu/pulls{/number}","milestones_url":"https://api.github.com/repos/govinu/govinu/milestones{/number}","notifications_url":"https://api.github.com/repos/govinu/govinu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/govinu/govinu/labels{/name}","releases_url":"https://api.github.com/repos/govinu/govinu/releases{/id}","deployments_url":"https://api.github.com/repos/govinu/govinu/deployments","created_at":"2018-12-19T18:51:27Z","updated_at":"2019-03-07T21:06:23Z","pushed_at":"2019-03-08T08:59:36Z","git_url":"git://github.com/govinu/govinu.git","ssh_url":"[email protected]:govinu/govinu.git","clone_url":"https://github.com/govinu/govinu.git","svn_url":"https://github.com/govinu/govinu","homepage":"https://govinu.com","size":871,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"govinu:master","ref":"master","sha":"2b602e2818ec7ebf12fa806eec0433aac1acfbc5","user":{"login":"govinu","id":46092538,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDkyNTM4","avatar_url":"https://avatars2.githubusercontent.com/u/46092538?v=4","gravatar_id":"","url":"https://api.github.com/users/govinu","html_url":"https://github.com/govinu","followers_url":"https://api.github.com/users/govinu/followers","following_url":"https://api.github.com/users/govinu/following{/other_user}","gists_url":"https://api.github.com/users/govinu/gists{/gist_id}","starred_url":"https://api.github.com/users/govinu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govinu/subscriptions","organizations_url":"https://api.github.com/users/govinu/orgs","repos_url":"https://api.github.com/users/govinu/repos","events_url":"https://api.github.com/users/govinu/events{/privacy}","received_events_url":"https://api.github.com/users/govinu/received_events","type":"Organization","site_admin":false},"repo":{"id":162478160,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI0NzgxNjA=","name":"govinu","full_name":"govinu/govinu","private":false,"owner":{"login":"govinu","id":46092538,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDkyNTM4","avatar_url":"https://avatars2.githubusercontent.com/u/46092538?v=4","gravatar_id":"","url":"https://api.github.com/users/govinu","html_url":"https://github.com/govinu","followers_url":"https://api.github.com/users/govinu/followers","following_url":"https://api.github.com/users/govinu/following{/other_user}","gists_url":"https://api.github.com/users/govinu/gists{/gist_id}","starred_url":"https://api.github.com/users/govinu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govinu/subscriptions","organizations_url":"https://api.github.com/users/govinu/orgs","repos_url":"https://api.github.com/users/govinu/repos","events_url":"https://api.github.com/users/govinu/events{/privacy}","received_events_url":"https://api.github.com/users/govinu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/govinu/govinu","description":null,"fork":false,"url":"https://api.github.com/repos/govinu/govinu","forks_url":"https://api.github.com/repos/govinu/govinu/forks","keys_url":"https://api.github.com/repos/govinu/govinu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/govinu/govinu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/govinu/govinu/teams","hooks_url":"https://api.github.com/repos/govinu/govinu/hooks","issue_events_url":"https://api.github.com/repos/govinu/govinu/issues/events{/number}","events_url":"https://api.github.com/repos/govinu/govinu/events","assignees_url":"https://api.github.com/repos/govinu/govinu/assignees{/user}","branches_url":"https://api.github.com/repos/govinu/govinu/branches{/branch}","tags_url":"https://api.github.com/repos/govinu/govinu/tags","blobs_url":"https://api.github.com/repos/govinu/govinu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/govinu/govinu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/govinu/govinu/git/refs{/sha}","trees_url":"https://api.github.com/repos/govinu/govinu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/govinu/govinu/statuses/{sha}","languages_url":"https://api.github.com/repos/govinu/govinu/languages","stargazers_url":"https://api.github.com/repos/govinu/govinu/stargazers","contributors_url":"https://api.github.com/repos/govinu/govinu/contributors","subscribers_url":"https://api.github.com/repos/govinu/govinu/subscribers","subscription_url":"https://api.github.com/repos/govinu/govinu/subscription","commits_url":"https://api.github.com/repos/govinu/govinu/commits{/sha}","git_commits_url":"https://api.github.com/repos/govinu/govinu/git/commits{/sha}","comments_url":"https://api.github.com/repos/govinu/govinu/comments{/number}","issue_comment_url":"https://api.github.com/repos/govinu/govinu/issues/comments{/number}","contents_url":"https://api.github.com/repos/govinu/govinu/contents/{+path}","compare_url":"https://api.github.com/repos/govinu/govinu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/govinu/govinu/merges","archive_url":"https://api.github.com/repos/govinu/govinu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/govinu/govinu/downloads","issues_url":"https://api.github.com/repos/govinu/govinu/issues{/number}","pulls_url":"https://api.github.com/repos/govinu/govinu/pulls{/number}","milestones_url":"https://api.github.com/repos/govinu/govinu/milestones{/number}","notifications_url":"https://api.github.com/repos/govinu/govinu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/govinu/govinu/labels{/name}","releases_url":"https://api.github.com/repos/govinu/govinu/releases{/id}","deployments_url":"https://api.github.com/repos/govinu/govinu/deployments","created_at":"2018-12-19T18:51:27Z","updated_at":"2019-03-07T21:06:23Z","pushed_at":"2019-03-08T08:59:36Z","git_url":"git://github.com/govinu/govinu.git","ssh_url":"[email protected]:govinu/govinu.git","clone_url":"https://github.com/govinu/govinu.git","svn_url":"https://github.com/govinu/govinu","homepage":"https://govinu.com","size":871,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/govinu/govinu/pulls/134"},"html":{"href":"https://github.com/govinu/govinu/pull/134"},"issue":{"href":"https://api.github.com/repos/govinu/govinu/issues/134"},"comments":{"href":"https://api.github.com/repos/govinu/govinu/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/govinu/govinu/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/govinu/govinu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/govinu/govinu/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/govinu/govinu/statuses/9babc85b69e1cd706fcc099d7643037ddf37edd2"}},"author_association":"COLLABORATOR"}}
|
{
"id": 162478160,
"name": "govinu/govinu",
"url": "https://api.github.com/repos/govinu/govinu"
}
|
{
"id": 3286533,
"login": "andersklenke",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3286533?",
"url": "https://api.github.com/users/andersklenke"
}
|
{
"id": 46092538,
"login": "govinu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46092538?",
"url": "https://api.github.com/orgs/govinu"
}
| 2019-03-08T10:04:54 |
9205261752
|
{"actor":{"display_login":"andersklenke"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/digital-asset/daml/pulls/comments/290654198","pull_request_review_id":245894545,"id":290654198,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDY1NDE5OA==","diff_hunk":"@@ -23,7 +22,8 @@ import scala.collection.breakOut\n trait TransactionConversion {\n \n def acceptedToDomainFlat(","path":"ledger/sandbox/src/main/scala/com/digitalasset/platform/sandbox/stores/ledger/TransactionConversion.scala","position":25,"original_position":25,"commit_id":"6d7f85e08dd8e05e46bf1d53e5a90316c96cfad5","original_commit_id":"6d7f85e08dd8e05e46bf1d53e5a90316c96cfad5","user":{"login":"gerolf-da","id":29121423,"node_id":"MDQ6VXNlcjI5MTIxNDIz","avatar_url":"https://avatars0.githubusercontent.com/u/29121423?v=4","gravatar_id":"","url":"https://api.github.com/users/gerolf-da","html_url":"https://github.com/gerolf-da","followers_url":"https://api.github.com/users/gerolf-da/followers","following_url":"https://api.github.com/users/gerolf-da/following{/other_user}","gists_url":"https://api.github.com/users/gerolf-da/gists{/gist_id}","starred_url":"https://api.github.com/users/gerolf-da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerolf-da/subscriptions","organizations_url":"https://api.github.com/users/gerolf-da/orgs","repos_url":"https://api.github.com/users/gerolf-da/repos","events_url":"https://api.github.com/users/gerolf-da/events{/privacy}","received_events_url":"https://api.github.com/users/gerolf-da/received_events","type":"User","site_admin":false},"body":"Please rename from `acceptedToDomainFlat` to something like `ledgerEntryTxToDomainFlat`.","created_at":"2019-06-05T09:31:12Z","updated_at":"2019-06-05T09:36:50Z","html_url":"https://github.com/digital-asset/daml/pull/1524#discussion_r290654198","pull_request_url":"https://api.github.com/repos/digital-asset/daml/pulls/1524","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/comments/290654198"},"html":{"href":"https://github.com/digital-asset/daml/pull/1524#discussion_r290654198"},"pull_request":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/1524"}}},"pull_request":{"url":"https://api.github.com/repos/digital-asset/daml/pulls/1524","id":285262730,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1MjYyNzMw","html_url":"https://github.com/digital-asset/daml/pull/1524","diff_url":"https://github.com/digital-asset/daml/pull/1524.diff","patch_url":"https://github.com/digital-asset/daml/pull/1524.patch","issue_url":"https://api.github.com/repos/digital-asset/daml/issues/1524","number":1524,"state":"open","locked":false,"title":"removing ledger backend module","user":{"login":"gaboraranyossy-da","id":29858875,"node_id":"MDQ6VXNlcjI5ODU4ODc1","avatar_url":"https://avatars3.githubusercontent.com/u/29858875?v=4","gravatar_id":"","url":"https://api.github.com/users/gaboraranyossy-da","html_url":"https://github.com/gaboraranyossy-da","followers_url":"https://api.github.com/users/gaboraranyossy-da/followers","following_url":"https://api.github.com/users/gaboraranyossy-da/following{/other_user}","gists_url":"https://api.github.com/users/gaboraranyossy-da/gists{/gist_id}","starred_url":"https://api.github.com/users/gaboraranyossy-da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaboraranyossy-da/subscriptions","organizations_url":"https://api.github.com/users/gaboraranyossy-da/orgs","repos_url":"https://api.github.com/users/gaboraranyossy-da/repos","events_url":"https://api.github.com/users/gaboraranyossy-da/events{/privacy}","received_events_url":"https://api.github.com/users/gaboraranyossy-da/received_events","type":"User","site_admin":false},"body":"Removed the unnecessary `ledger-backend` module/abstraction.\r\n\r\n### Pull Request Checklist\r\n\r\n- [ ] Read and understand the [contribution guidelines](https://github.com/digital-asset/daml/blob/master/CONTRIBUTING.md)\r\n- [ ] Include appropriate tests\r\n- [ ] Set a descriptive title and thorough description\r\n- [ ] Add a reference to the [issue this PR will solve](https://github.com/digital-asset/daml/issues), if appropriate\r\n- [ ] Add a line to the [release notes](https://github.com/digital-asset/daml/blob/master/docs/source/support/release-notes.rst), if appropriate\r\n\r\nNOTE: CI is not automatically run on non-members pull-requests for security\r\nreasons. The reviewer will have to comment with `/AzurePipelines run` to\r\ntrigger the build.\r\n","created_at":"2019-06-05T07:54:06Z","updated_at":"2019-06-05T09:36:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6acfd2d1d11b5f5c755210db90f8edc65a271b67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1297954896,"node_id":"MDU6TGFiZWwxMjk3OTU0ODk2","url":"https://api.github.com/repos/digital-asset/daml/labels/component/ledger","name":"component/ledger","color":"0ef472","default":false}],"milestone":{"url":"https://api.github.com/repos/digital-asset/daml/milestones/15","html_url":"https://github.com/digital-asset/daml/milestone/15","labels_url":"https://api.github.com/repos/digital-asset/daml/milestones/15/labels","id":4296430,"node_id":"MDk6TWlsZXN0b25lNDI5NjQzMA==","number":15,"title":"Integrate DAML-on-X interfaces in sandbox codebase","description":"The DAML-on-X team has codified various interfaces to be able to implement a DAML ledger on top of existing platforms easily. Specifically: the read, write, and index service. This milestone is about integrating those interfaces in the existing sandbox codebase, so that new backends can be implemented quickly using the latest version of the Ledger API service.","creator":{"login":"bitonic","id":556090,"node_id":"MDQ6VXNlcjU1NjA5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/556090?v=4","gravatar_id":"","url":"https://api.github.com/users/bitonic","html_url":"https://github.com/bitonic","followers_url":"https://api.github.com/users/bitonic/followers","following_url":"https://api.github.com/users/bitonic/following{/other_user}","gists_url":"https://api.github.com/users/bitonic/gists{/gist_id}","starred_url":"https://api.github.com/users/bitonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitonic/subscriptions","organizations_url":"https://api.github.com/users/bitonic/orgs","repos_url":"https://api.github.com/users/bitonic/repos","events_url":"https://api.github.com/users/bitonic/events{/privacy}","received_events_url":"https://api.github.com/users/bitonic/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2019-05-08T19:14:16Z","updated_at":"2019-06-05T08:09:20Z","due_on":"2019-06-07T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/digital-asset/daml/pulls/1524/commits","review_comments_url":"https://api.github.com/repos/digital-asset/daml/pulls/1524/comments","review_comment_url":"https://api.github.com/repos/digital-asset/daml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digital-asset/daml/issues/1524/comments","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/6d7f85e08dd8e05e46bf1d53e5a90316c96cfad5","head":{"label":"digital-asset:removing-ledger-backend","ref":"removing-ledger-backend","sha":"6d7f85e08dd8e05e46bf1d53e5a90316c96cfad5","user":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"repo":{"id":178222328,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMjIzMjg=","name":"daml","full_name":"digital-asset/daml","private":false,"owner":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digital-asset/daml","description":"The DAML smart contract language","fork":false,"url":"https://api.github.com/repos/digital-asset/daml","forks_url":"https://api.github.com/repos/digital-asset/daml/forks","keys_url":"https://api.github.com/repos/digital-asset/daml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digital-asset/daml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digital-asset/daml/teams","hooks_url":"https://api.github.com/repos/digital-asset/daml/hooks","issue_events_url":"https://api.github.com/repos/digital-asset/daml/issues/events{/number}","events_url":"https://api.github.com/repos/digital-asset/daml/events","assignees_url":"https://api.github.com/repos/digital-asset/daml/assignees{/user}","branches_url":"https://api.github.com/repos/digital-asset/daml/branches{/branch}","tags_url":"https://api.github.com/repos/digital-asset/daml/tags","blobs_url":"https://api.github.com/repos/digital-asset/daml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digital-asset/daml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digital-asset/daml/git/refs{/sha}","trees_url":"https://api.github.com/repos/digital-asset/daml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/{sha}","languages_url":"https://api.github.com/repos/digital-asset/daml/languages","stargazers_url":"https://api.github.com/repos/digital-asset/daml/stargazers","contributors_url":"https://api.github.com/repos/digital-asset/daml/contributors","subscribers_url":"https://api.github.com/repos/digital-asset/daml/subscribers","subscription_url":"https://api.github.com/repos/digital-asset/daml/subscription","commits_url":"https://api.github.com/repos/digital-asset/daml/commits{/sha}","git_commits_url":"https://api.github.com/repos/digital-asset/daml/git/commits{/sha}","comments_url":"https://api.github.com/repos/digital-asset/daml/comments{/number}","issue_comment_url":"https://api.github.com/repos/digital-asset/daml/issues/comments{/number}","contents_url":"https://api.github.com/repos/digital-asset/daml/contents/{+path}","compare_url":"https://api.github.com/repos/digital-asset/daml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digital-asset/daml/merges","archive_url":"https://api.github.com/repos/digital-asset/daml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digital-asset/daml/downloads","issues_url":"https://api.github.com/repos/digital-asset/daml/issues{/number}","pulls_url":"https://api.github.com/repos/digital-asset/daml/pulls{/number}","milestones_url":"https://api.github.com/repos/digital-asset/daml/milestones{/number}","notifications_url":"https://api.github.com/repos/digital-asset/daml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digital-asset/daml/labels{/name}","releases_url":"https://api.github.com/repos/digital-asset/daml/releases{/id}","deployments_url":"https://api.github.com/repos/digital-asset/daml/deployments","created_at":"2019-03-28T14:38:37Z","updated_at":"2019-06-05T08:29:21Z","pushed_at":"2019-06-05T09:28:01Z","git_url":"git://github.com/digital-asset/daml.git","ssh_url":"[email protected]:digital-asset/daml.git","clone_url":"https://github.com/digital-asset/daml.git","svn_url":"https://github.com/digital-asset/daml","homepage":"https://daml.com/","size":24524,"stargazers_count":172,"watchers_count":172,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":308,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":31,"open_issues":308,"watchers":172,"default_branch":"master"}},"base":{"label":"digital-asset:master","ref":"master","sha":"bf5309b42e8a600f7ec0bbf05c44b1e41e3692f1","user":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"repo":{"id":178222328,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMjIzMjg=","name":"daml","full_name":"digital-asset/daml","private":false,"owner":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digital-asset/daml","description":"The DAML smart contract language","fork":false,"url":"https://api.github.com/repos/digital-asset/daml","forks_url":"https://api.github.com/repos/digital-asset/daml/forks","keys_url":"https://api.github.com/repos/digital-asset/daml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digital-asset/daml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digital-asset/daml/teams","hooks_url":"https://api.github.com/repos/digital-asset/daml/hooks","issue_events_url":"https://api.github.com/repos/digital-asset/daml/issues/events{/number}","events_url":"https://api.github.com/repos/digital-asset/daml/events","assignees_url":"https://api.github.com/repos/digital-asset/daml/assignees{/user}","branches_url":"https://api.github.com/repos/digital-asset/daml/branches{/branch}","tags_url":"https://api.github.com/repos/digital-asset/daml/tags","blobs_url":"https://api.github.com/repos/digital-asset/daml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digital-asset/daml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digital-asset/daml/git/refs{/sha}","trees_url":"https://api.github.com/repos/digital-asset/daml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/{sha}","languages_url":"https://api.github.com/repos/digital-asset/daml/languages","stargazers_url":"https://api.github.com/repos/digital-asset/daml/stargazers","contributors_url":"https://api.github.com/repos/digital-asset/daml/contributors","subscribers_url":"https://api.github.com/repos/digital-asset/daml/subscribers","subscription_url":"https://api.github.com/repos/digital-asset/daml/subscription","commits_url":"https://api.github.com/repos/digital-asset/daml/commits{/sha}","git_commits_url":"https://api.github.com/repos/digital-asset/daml/git/commits{/sha}","comments_url":"https://api.github.com/repos/digital-asset/daml/comments{/number}","issue_comment_url":"https://api.github.com/repos/digital-asset/daml/issues/comments{/number}","contents_url":"https://api.github.com/repos/digital-asset/daml/contents/{+path}","compare_url":"https://api.github.com/repos/digital-asset/daml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digital-asset/daml/merges","archive_url":"https://api.github.com/repos/digital-asset/daml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digital-asset/daml/downloads","issues_url":"https://api.github.com/repos/digital-asset/daml/issues{/number}","pulls_url":"https://api.github.com/repos/digital-asset/daml/pulls{/number}","milestones_url":"https://api.github.com/repos/digital-asset/daml/milestones{/number}","notifications_url":"https://api.github.com/repos/digital-asset/daml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digital-asset/daml/labels{/name}","releases_url":"https://api.github.com/repos/digital-asset/daml/releases{/id}","deployments_url":"https://api.github.com/repos/digital-asset/daml/deployments","created_at":"2019-03-28T14:38:37Z","updated_at":"2019-06-05T08:29:21Z","pushed_at":"2019-06-05T09:28:01Z","git_url":"git://github.com/digital-asset/daml.git","ssh_url":"[email protected]:digital-asset/daml.git","clone_url":"https://github.com/digital-asset/daml.git","svn_url":"https://github.com/digital-asset/daml","homepage":"https://daml.com/","size":24524,"stargazers_count":172,"watchers_count":172,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":308,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":31,"open_issues":308,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/1524"},"html":{"href":"https://github.com/digital-asset/daml/pull/1524"},"issue":{"href":"https://api.github.com/repos/digital-asset/daml/issues/1524"},"comments":{"href":"https://api.github.com/repos/digital-asset/daml/issues/1524/comments"},"review_comments":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/1524/comments"},"review_comment":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/1524/commits"},"statuses":{"href":"https://api.github.com/repos/digital-asset/daml/statuses/6d7f85e08dd8e05e46bf1d53e5a90316c96cfad5"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 178222328,
"name": "digital-asset/daml",
"url": "https://api.github.com/repos/digital-asset/daml"
}
|
{
"id": 29121423,
"login": "gerolf-da",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29121423?",
"url": "https://api.github.com/users/gerolf-da"
}
|
{
"id": 46327217,
"login": "digital-asset",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46327217?",
"url": "https://api.github.com/orgs/digital-asset"
}
| 2019-06-05T09:31:12 |
9761785463
|
{"actor":{"display_login":"gerolf-da"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/horovod/horovod/pulls/comments/330836127","pull_request_review_id":296607559,"id":330836127,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMDgzNjEyNw==","diff_hunk":"@@ -69,26 +69,80 @@ TensorQueue::GetTensorDataForAutotuner(const ResponseList& response_list,\n // Parse tensor names from response and generate a vector of corresponding\n // tensor entries.\n void TensorQueue::GetTensorEntriesFromResponse(\n- Response& response, std::vector<TensorTableEntry>& entries) {\n+ Response& response, std::vector<TensorTableEntry>& entries,\n+ int rank, bool joined, int join_device) {\n // Reserve to save re-allocation costs, as we know the size before.\n entries.reserve(response.tensor_names().size());\n {\n // Lock on the tensor table.\n std::lock_guard<std::mutex> guard(mutex_);\n for (auto& name : response.tensor_names()) {\n- // We should never fail at finding this key in the tensor table.\n- auto iter = tensor_table_.find(name);\n- assert(iter != tensor_table_.end());\n-\n assert(response.response_type() == Response::ALLREDUCE ||\n response.response_type() == Response::ALLGATHER ||\n response.response_type() == Response::BROADCAST ||\n response.response_type() == Response::ERROR);\n \n- entries.push_back(std::move(iter->second));\n-\n- // Clear the tensor table of this tensor.\n- tensor_table_.erase(iter);\n+ if (!joined) {\n+ // We should never fail at finding this key in the tensor table.\n+ auto iter = tensor_table_.find(name);\n+ assert(iter != tensor_table_.end());\n+\n+ entries.push_back(std::move(iter->second));\n+\n+ // Clear the tensor table of this tensor.\n+ tensor_table_.erase(iter);\n+ } else {\n+ TensorTableEntry entry;\n+ switch (response.tensor_type()) {\n+ case HOROVOD_UINT8:\n+ entry.tensor = std::make_shared<JoinTensor<HOROVOD_UINT8, uint8_t>>(\n+ join_device, response.tensor_sizes()[0]);\n+ break;\n+ case HOROVOD_INT8:\n+ entry.tensor = std::make_shared<JoinTensor<HOROVOD_INT8, int8_t>>(\n+ join_device, response.tensor_sizes()[0]);\n+ break;\n+ case HOROVOD_UINT16:\n+ entry.tensor = std::make_shared<JoinTensor<HOROVOD_UINT16, uint16_t>>(\n+ join_device, response.tensor_sizes()[0]);\n+ break;\n+ case HOROVOD_INT16:\n+ entry.tensor = std::make_shared<JoinTensor<HOROVOD_INT16, int16_t>>(\n+ join_device, response.tensor_sizes()[0]);\n+ break;\n+ case HOROVOD_INT32:\n+ entry.tensor = std::make_shared<JoinTensor<HOROVOD_INT32, int32_t>>(\n+ join_device, response.tensor_sizes()[0]);\n+ break;\n+ case HOROVOD_INT64:\n+ entry.tensor = std::make_shared<JoinTensor<HOROVOD_INT64, int64_t>>(\n+ join_device, response.tensor_sizes()[0]);\n+ break;\n+ case HOROVOD_FLOAT16:\n+ entry.tensor = std::make_shared<JoinTensor<HOROVOD_FLOAT16, float>>(","path":"horovod/common/tensor_queue.cc","position":62,"original_position":63,"commit_id":"9b399eb23ffb170d9e36f80bec2d5f6cda6e9644","original_commit_id":"47fb08f5ce338dcd8b44ee49069a56e1e96e7554","user":{"login":"kit1980","id":420184,"node_id":"MDQ6VXNlcjQyMDE4NA==","avatar_url":"https://avatars2.githubusercontent.com/u/420184?v=4","gravatar_id":"","url":"https://api.github.com/users/kit1980","html_url":"https://github.com/kit1980","followers_url":"https://api.github.com/users/kit1980/followers","following_url":"https://api.github.com/users/kit1980/following{/other_user}","gists_url":"https://api.github.com/users/kit1980/gists{/gist_id}","starred_url":"https://api.github.com/users/kit1980/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kit1980/subscriptions","organizations_url":"https://api.github.com/users/kit1980/orgs","repos_url":"https://api.github.com/users/kit1980/repos","events_url":"https://api.github.com/users/kit1980/events{/privacy}","received_events_url":"https://api.github.com/users/kit1980/received_events","type":"User","site_admin":false},"body":"Hi @tgaddair,\r\nSo I'm planning to implement it this way. Any suggestions?\r\n\r\nIn `GetTensorEntriesFromResponse` to create temporary zero tensor, call `AllocatePersistent` of the `JOIN_TENSOR_NAME` context. `AllocatePersistent` will automatically call framework-specific implementation.\r\n\r\n`AllocatePersistent` needs size in bytes, that can be computed from size in elements using `GetTypeSize()` https://github.com/horovod/horovod/blob/c5b53eca9686ba296ba3a8b3a7e25dda25065eea/horovod/common/gloo/gloo_controller.cc#L94\r\n\r\nThe newly allocated buffer needs to be filled with zeros. Not really sure how to do it best, especially for fp16.\r\n\r\nOr do you think reusing `AllocatePersistent` for this is not a good idea?","created_at":"2019-10-03T01:43:39Z","updated_at":"2019-10-03T01:43:39Z","html_url":"https://github.com/horovod/horovod/pull/1058#discussion_r330836127","pull_request_url":"https://api.github.com/repos/horovod/horovod/pulls/1058","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/horovod/horovod/pulls/comments/330836127"},"html":{"href":"https://github.com/horovod/horovod/pull/1058#discussion_r330836127"},"pull_request":{"href":"https://api.github.com/repos/horovod/horovod/pulls/1058"}},"in_reply_to_id":324878897},"pull_request":{"url":"https://api.github.com/repos/horovod/horovod/pulls/1058","id":276782233,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2NzgyMjMz","html_url":"https://github.com/horovod/horovod/pull/1058","diff_url":"https://github.com/horovod/horovod/pull/1058.diff","patch_url":"https://github.com/horovod/horovod/pull/1058.patch","issue_url":"https://api.github.com/repos/horovod/horovod/issues/1058","number":1058,"state":"open","locked":false,"title":"Add Join op (with only support for AllReduce and PyTorch for now)","user":{"login":"kit1980","id":420184,"node_id":"MDQ6VXNlcjQyMDE4NA==","avatar_url":"https://avatars2.githubusercontent.com/u/420184?v=4","gravatar_id":"","url":"https://api.github.com/users/kit1980","html_url":"https://github.com/kit1980","followers_url":"https://api.github.com/users/kit1980/followers","following_url":"https://api.github.com/users/kit1980/following{/other_user}","gists_url":"https://api.github.com/users/kit1980/gists{/gist_id}","starred_url":"https://api.github.com/users/kit1980/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kit1980/subscriptions","organizations_url":"https://api.github.com/users/kit1980/orgs","repos_url":"https://api.github.com/users/kit1980/repos","events_url":"https://api.github.com/users/kit1980/events{/privacy}","received_events_url":"https://api.github.com/users/kit1980/received_events","type":"User","site_admin":false},"body":"This is very earlier work in progress PR to add hvd.join() as described in https://github.com/horovod/horovod/issues/832\r\n\r\nThis is mostly boilerplate code, it compiles and I can call hvd.join() from the pytorch test (the Join op goes to the queue but does nothing).\r\n\r\nThe purpose of this PR for me is to understand if I'm going in the right direction.\r\nSome other questions I have (in no particular order):\r\n\r\n1. Should Join op have name?\r\n2. Join op doesn't have an input, and should have single int output (last joined rank), right?\r\n3. Does the Join op need to be implemented separately for cuda, nccl, in cuda_operations.cc, nccl_operations.cc, etc. ?\r\n4. In operation manager, should it be a vector of available Join ops or just one Join op?\r\n5. The logic for join op should track already joined ranks, this should be similar to the logic in AllReduce and AllGather ops? Any code pointers/suggestions?\r\n6. AllReduce and AllGather ops need to know already joined ranks. Is it going to be stored in global state? Any code pointers/suggestions?\r\n7. Any suggestions how to make adding Join op more granular (several smaller PRs)?","created_at":"2019-05-07T21:42:09Z","updated_at":"2019-10-03T01:43:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f109cd8ad0022789a1b2a116a4c1e28654b9f9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/horovod/horovod/pulls/1058/commits","review_comments_url":"https://api.github.com/repos/horovod/horovod/pulls/1058/comments","review_comment_url":"https://api.github.com/repos/horovod/horovod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/horovod/horovod/issues/1058/comments","statuses_url":"https://api.github.com/repos/horovod/horovod/statuses/9b399eb23ffb170d9e36f80bec2d5f6cda6e9644","head":{"label":"kit1980:master","ref":"master","sha":"9b399eb23ffb170d9e36f80bec2d5f6cda6e9644","user":{"login":"kit1980","id":420184,"node_id":"MDQ6VXNlcjQyMDE4NA==","avatar_url":"https://avatars2.githubusercontent.com/u/420184?v=4","gravatar_id":"","url":"https://api.github.com/users/kit1980","html_url":"https://github.com/kit1980","followers_url":"https://api.github.com/users/kit1980/followers","following_url":"https://api.github.com/users/kit1980/following{/other_user}","gists_url":"https://api.github.com/users/kit1980/gists{/gist_id}","starred_url":"https://api.github.com/users/kit1980/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kit1980/subscriptions","organizations_url":"https://api.github.com/users/kit1980/orgs","repos_url":"https://api.github.com/users/kit1980/repos","events_url":"https://api.github.com/users/kit1980/events{/privacy}","received_events_url":"https://api.github.com/users/kit1980/received_events","type":"User","site_admin":false},"repo":{"id":184123688,"node_id":"MDEwOlJlcG9zaXRvcnkxODQxMjM2ODg=","name":"horovod","full_name":"kit1980/horovod","private":false,"owner":{"login":"kit1980","id":420184,"node_id":"MDQ6VXNlcjQyMDE4NA==","avatar_url":"https://avatars2.githubusercontent.com/u/420184?v=4","gravatar_id":"","url":"https://api.github.com/users/kit1980","html_url":"https://github.com/kit1980","followers_url":"https://api.github.com/users/kit1980/followers","following_url":"https://api.github.com/users/kit1980/following{/other_user}","gists_url":"https://api.github.com/users/kit1980/gists{/gist_id}","starred_url":"https://api.github.com/users/kit1980/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kit1980/subscriptions","organizations_url":"https://api.github.com/users/kit1980/orgs","repos_url":"https://api.github.com/users/kit1980/repos","events_url":"https://api.github.com/users/kit1980/events{/privacy}","received_events_url":"https://api.github.com/users/kit1980/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kit1980/horovod","description":"Distributed training framework for TensorFlow, Keras, PyTorch, and Apache MXNet.","fork":true,"url":"https://api.github.com/repos/kit1980/horovod","forks_url":"https://api.github.com/repos/kit1980/horovod/forks","keys_url":"https://api.github.com/repos/kit1980/horovod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kit1980/horovod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kit1980/horovod/teams","hooks_url":"https://api.github.com/repos/kit1980/horovod/hooks","issue_events_url":"https://api.github.com/repos/kit1980/horovod/issues/events{/number}","events_url":"https://api.github.com/repos/kit1980/horovod/events","assignees_url":"https://api.github.com/repos/kit1980/horovod/assignees{/user}","branches_url":"https://api.github.com/repos/kit1980/horovod/branches{/branch}","tags_url":"https://api.github.com/repos/kit1980/horovod/tags","blobs_url":"https://api.github.com/repos/kit1980/horovod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kit1980/horovod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kit1980/horovod/git/refs{/sha}","trees_url":"https://api.github.com/repos/kit1980/horovod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kit1980/horovod/statuses/{sha}","languages_url":"https://api.github.com/repos/kit1980/horovod/languages","stargazers_url":"https://api.github.com/repos/kit1980/horovod/stargazers","contributors_url":"https://api.github.com/repos/kit1980/horovod/contributors","subscribers_url":"https://api.github.com/repos/kit1980/horovod/subscribers","subscription_url":"https://api.github.com/repos/kit1980/horovod/subscription","commits_url":"https://api.github.com/repos/kit1980/horovod/commits{/sha}","git_commits_url":"https://api.github.com/repos/kit1980/horovod/git/commits{/sha}","comments_url":"https://api.github.com/repos/kit1980/horovod/comments{/number}","issue_comment_url":"https://api.github.com/repos/kit1980/horovod/issues/comments{/number}","contents_url":"https://api.github.com/repos/kit1980/horovod/contents/{+path}","compare_url":"https://api.github.com/repos/kit1980/horovod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kit1980/horovod/merges","archive_url":"https://api.github.com/repos/kit1980/horovod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kit1980/horovod/downloads","issues_url":"https://api.github.com/repos/kit1980/horovod/issues{/number}","pulls_url":"https://api.github.com/repos/kit1980/horovod/pulls{/number}","milestones_url":"https://api.github.com/repos/kit1980/horovod/milestones{/number}","notifications_url":"https://api.github.com/repos/kit1980/horovod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kit1980/horovod/labels{/name}","releases_url":"https://api.github.com/repos/kit1980/horovod/releases{/id}","deployments_url":"https://api.github.com/repos/kit1980/horovod/deployments","created_at":"2019-04-29T18:34:30Z","updated_at":"2019-09-24T18:43:17Z","pushed_at":"2019-09-26T23:51:06Z","git_url":"git://github.com/kit1980/horovod.git","ssh_url":"[email protected]:kit1980/horovod.git","clone_url":"https://github.com/kit1980/horovod.git","svn_url":"https://github.com/kit1980/horovod","homepage":"https://eng.uber.com/horovod/","size":2081,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"horovod:master","ref":"master","sha":"317c1d9e6d57a31e42c1f674dac937efc3fbc2b2","user":{"login":"horovod","id":46361271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzYxMjcx","avatar_url":"https://avatars2.githubusercontent.com/u/46361271?v=4","gravatar_id":"","url":"https://api.github.com/users/horovod","html_url":"https://github.com/horovod","followers_url":"https://api.github.com/users/horovod/followers","following_url":"https://api.github.com/users/horovod/following{/other_user}","gists_url":"https://api.github.com/users/horovod/gists{/gist_id}","starred_url":"https://api.github.com/users/horovod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/horovod/subscriptions","organizations_url":"https://api.github.com/users/horovod/orgs","repos_url":"https://api.github.com/users/horovod/repos","events_url":"https://api.github.com/users/horovod/events{/privacy}","received_events_url":"https://api.github.com/users/horovod/received_events","type":"Organization","site_admin":false},"repo":{"id":99846383,"node_id":"MDEwOlJlcG9zaXRvcnk5OTg0NjM4Mw==","name":"horovod","full_name":"horovod/horovod","private":false,"owner":{"login":"horovod","id":46361271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzYxMjcx","avatar_url":"https://avatars2.githubusercontent.com/u/46361271?v=4","gravatar_id":"","url":"https://api.github.com/users/horovod","html_url":"https://github.com/horovod","followers_url":"https://api.github.com/users/horovod/followers","following_url":"https://api.github.com/users/horovod/following{/other_user}","gists_url":"https://api.github.com/users/horovod/gists{/gist_id}","starred_url":"https://api.github.com/users/horovod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/horovod/subscriptions","organizations_url":"https://api.github.com/users/horovod/orgs","repos_url":"https://api.github.com/users/horovod/repos","events_url":"https://api.github.com/users/horovod/events{/privacy}","received_events_url":"https://api.github.com/users/horovod/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/horovod/horovod","description":"Distributed training framework for TensorFlow, Keras, PyTorch, and Apache MXNet.","fork":false,"url":"https://api.github.com/repos/horovod/horovod","forks_url":"https://api.github.com/repos/horovod/horovod/forks","keys_url":"https://api.github.com/repos/horovod/horovod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/horovod/horovod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/horovod/horovod/teams","hooks_url":"https://api.github.com/repos/horovod/horovod/hooks","issue_events_url":"https://api.github.com/repos/horovod/horovod/issues/events{/number}","events_url":"https://api.github.com/repos/horovod/horovod/events","assignees_url":"https://api.github.com/repos/horovod/horovod/assignees{/user}","branches_url":"https://api.github.com/repos/horovod/horovod/branches{/branch}","tags_url":"https://api.github.com/repos/horovod/horovod/tags","blobs_url":"https://api.github.com/repos/horovod/horovod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/horovod/horovod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/horovod/horovod/git/refs{/sha}","trees_url":"https://api.github.com/repos/horovod/horovod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/horovod/horovod/statuses/{sha}","languages_url":"https://api.github.com/repos/horovod/horovod/languages","stargazers_url":"https://api.github.com/repos/horovod/horovod/stargazers","contributors_url":"https://api.github.com/repos/horovod/horovod/contributors","subscribers_url":"https://api.github.com/repos/horovod/horovod/subscribers","subscription_url":"https://api.github.com/repos/horovod/horovod/subscription","commits_url":"https://api.github.com/repos/horovod/horovod/commits{/sha}","git_commits_url":"https://api.github.com/repos/horovod/horovod/git/commits{/sha}","comments_url":"https://api.github.com/repos/horovod/horovod/comments{/number}","issue_comment_url":"https://api.github.com/repos/horovod/horovod/issues/comments{/number}","contents_url":"https://api.github.com/repos/horovod/horovod/contents/{+path}","compare_url":"https://api.github.com/repos/horovod/horovod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/horovod/horovod/merges","archive_url":"https://api.github.com/repos/horovod/horovod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/horovod/horovod/downloads","issues_url":"https://api.github.com/repos/horovod/horovod/issues{/number}","pulls_url":"https://api.github.com/repos/horovod/horovod/pulls{/number}","milestones_url":"https://api.github.com/repos/horovod/horovod/milestones{/number}","notifications_url":"https://api.github.com/repos/horovod/horovod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/horovod/horovod/labels{/name}","releases_url":"https://api.github.com/repos/horovod/horovod/releases{/id}","deployments_url":"https://api.github.com/repos/horovod/horovod/deployments","created_at":"2017-08-09T19:39:59Z","updated_at":"2019-10-02T19:51:56Z","pushed_at":"2019-09-28T01:06:20Z","git_url":"git://github.com/horovod/horovod.git","ssh_url":"[email protected]:horovod/horovod.git","clone_url":"https://github.com/horovod/horovod.git","svn_url":"https://github.com/horovod/horovod","homepage":"https://eng.uber.com/horovod/","size":1972,"stargazers_count":7561,"watchers_count":7561,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1162,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":425,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1162,"open_issues":425,"watchers":7561,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/horovod/horovod/pulls/1058"},"html":{"href":"https://github.com/horovod/horovod/pull/1058"},"issue":{"href":"https://api.github.com/repos/horovod/horovod/issues/1058"},"comments":{"href":"https://api.github.com/repos/horovod/horovod/issues/1058/comments"},"review_comments":{"href":"https://api.github.com/repos/horovod/horovod/pulls/1058/comments"},"review_comment":{"href":"https://api.github.com/repos/horovod/horovod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/horovod/horovod/pulls/1058/commits"},"statuses":{"href":"https://api.github.com/repos/horovod/horovod/statuses/9b399eb23ffb170d9e36f80bec2d5f6cda6e9644"}},"author_association":"NONE"}}
|
{
"id": 99846383,
"name": "horovod/horovod",
"url": "https://api.github.com/repos/horovod/horovod"
}
|
{
"id": 420184,
"login": "kit1980",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/420184?",
"url": "https://api.github.com/users/kit1980"
}
|
{
"id": 46361271,
"login": "horovod",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46361271?",
"url": "https://api.github.com/orgs/horovod"
}
| 2019-10-03T01:43:39 |
10547567675
|
{"actor":{"display_login":"kit1980"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/comments/324826239","pull_request_review_id":288823786,"id":324826239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDgyNjIzOQ==","diff_hunk":"@@ -463,3 +463,301 @@ trade_post = {\n \t\t# extra_tech_building_start = 10.0 # Never get at start of game\n \t# }\n }\n+\n+##########################################\n+#\n+# Ciphers Trade Posts mod merger buildings\n+#\n+##########################################\n+\n+trade_post = {\t\n+\t\n+#Garrison\n+\n+\t#StableMaster\n+\twc_stableMaster = {\n+\t\t desc = wc_stableMaster1_desc\n+\t\t potential = {\n+\t\t\talways = yes\n+\t\t\towner = { NOT = { trait = creature_orc } }\n+\t\t }\n+\t\t gold_cost = 650\n+\t\t build_time = 365\n+\t\t local_tax_modifier = 0.1\n+\t\t local_movement_speed = 0.2\n+\t\t trade_route_wealth = 0.5\n+\t\t ai_creation_factor = 100\n+\t}\n+\t\n+\t#FlightMaster\n+\twc_flightMaster = {\n+\t\t desc = wc_flightMaster_desc\n+\t\t potential = {\n+\t\t\talways = yes\n+\t\t\towner = { NOT = { trait = creature_orc } }\n+\t\t }\n+\t\t \n+\t\t upgrades_from = wc_stableMaster\n+\t\t gold_cost = 900\n+\t\t build_time = 365\n+\t\t local_tax_modifier = 0.2\n+\t\t local_movement_speed = 0.5\n+\t\t trade_route_wealth = 1\n+\t\t ai_creation_factor = 100\n+\t}\n+\t\n+\t#WorgBestiary\n+\twc_worgBestiary = {\n+\t\t desc = wc_worgBestiary_desc\n+\t\t potential = {\n+\t\t\talways = yes\n+\t\t\towner = { trait = creature_orc }\n+\t\t }\n+\t\t gold_cost = 650\n+\t\t build_time = 365\n+\t\t local_tax_modifier = 0.1\n+\t\t local_movement_speed = 0.2\n+\t\t trade_route_wealth = 0.5\n+\t\t ai_creation_factor = 100\n+\t}\n+\t\n+\t#Wyvern Master\n+\twc_wyvernMaster = {\n+\t\t desc = wc_wyvernMaster_desc\n+\t\t potential = {\n+\t\t\talways = yes\n+\t\t\towner = { trait = creature_orc }\n+\t\t }\n+\t\t \n+\t\t upgrades_from = wc_worgBestiary\n+\t\t gold_cost = 900\n+\t\t build_time = 365\n+\t\t local_tax_modifier = 0.2\n+\t\t local_movement_speed = 0.5\n+\t\t trade_route_wealth = 1\n+\t\t ai_creation_factor = 100\n+\t}\n+\n+\t#Bank\n+\twc_bank\t = {\n+\t\t desc = wc_bank_desc\n+\t\t potential = {\n+\t\t\talways = yes\n+\t\t }\n+\t\t \n+\t\t gold_cost = 700\n+\t\t build_time = 765\n+\t\t fort_level = 0.3\n+\t\t tax_income = 1\n+\t\t trade_route_wealth = 2\n+\t\t ai_creation_factor = 100\n+\t}\n+\t\n+\t#GuildVault\n+\twc_guildVault = {\n+\t\tdesc = wc_guildVault_desc\n+\t\tpotential = {\n+\t\t\talways = yes\n+\t\t}\n+\t\tprerequisites = { wc_bank }\t\t\n+\t\tgold_cost = 650\n+\t\tbuild_time = 650\n+\t\tarmy_reinforce_rate = 0.1\n+\t\tretinuesize = 100\n+\t\tretinue_maintenence_cost = -0.2\n+\t\tai_creation_factor = 100\n+\t}\n+\t\n+\t#GoblinGhetto\n+\twc_goblinGhetto = {\n+\t\tdesc = wc_goblinGhetto_desc\n+\t\tpotential = {\n+\t\t\talways = yes\n+\t\t\tNOT = { owner = { trait = creature_human } }\n+\t\t\tNOT = { owner = { trait = creature_high_elf } }\n+\t\t\tNOT = { owner = { trait = creature_blood_elf } }\n+\t\t\tNOT = { owner = { trait = creature_night_elf } }\n+\t\t}\n+\t\tprerequisites = { wc_bank }\t\t\n+\t\tgold_cost = 450\n+\t\tbuild_time = 650\n+\t\tretinuesize = 100\n+\t\t\n+\t\tgarrison_size = 1\n+\t}\n+\t\n+\t#GoblinDistrict\n+\twc_goblinDistrict = {\n+\t\tdesc = wc_goblinDistrict_desc\n+\t\tpotential = {\n+\t\t\talways = yes\n+\t\t\tNOT = { owner = { trait = creature_human } }\n+\t\t\tNOT = { owner = { trait = creature_high_elf } }\n+\t\t\tNOT = { owner = { trait = creature_blood_elf } }\n+\t\t\tNOT = { owner = { trait = creature_night_elf } }\n+\t\t}\n+\t\tupgrades_from = wc_goblinGhetto\t\t\n+\t\tgold_cost = 750\n+\t\tbuild_time = 750\n+\t\tretinuesize = 150\n+\t\tgarrison_size = 2\n+\t}\n+\t\n+\t\t\n+\t#RestingLounge\n+\twc_restingLounge = {\n+\t\tdesc = wc_restingLounge_desc\n+\t\tpotential = {\n+\t\t\talways = yes\n+\t\t\towner = { trait = creature_night_elf }\n+\t\t\towner = { trait = creature_high_elf }\n+\t\t\towner = { trait = creature_blood_elf }\n+\t\t}\n+\t\tgold_cost = 600\n+\t\tbuild_time = 500\n+\t\tlocal_tax_modifier = 0.5\n+\t\tgarrison_size = 1\n+\t\tmonthly_character_piety = 0.5\n+\t\tai_creation_factor = 100\n+\t}\n+\t\n+\t#Great Clan Tent\n+\twc_greatClanTent = {\n+\t\tdesc = wc_greatClanTent_desc\n+\t\tpotential = {\n+\t\t\talways = yes\n+\t\t\towner = { trait = creature_orc }\n+\t\t}\n+\t\tgold_cost = 300\n+\t\tbuild_time = 500\n+\t\tlocal_tax_modifier = 0.2\n+\t\tmonthly_character_piety = 0.3\n+\t\tai_creation_factor = 100\n+\t}\n+\t\n+\t#Kodo Breeder\n+\twc_kodoBreeder = {\n+\t\tdesc = wc_kodoBreeder_desc\n+\t\tpotential = {\n+\t\t\talways = yes\n+\t\t\towner = { trait = creature_tauren }\n+\t\t}\n+\t\tgold_cost = 500\n+\t\tbuild_time = 500\n+\t\ttrade_route_wealth = 0.2\n+\t\tlocal_movement_speed = 1\n+\t\tai_creation_factor = 100\n+\t}\n+\t\n+\t#MerchantVenue\n+\twc_merchantVenue = {\n+\t\tdesc = wc_merchantVenue_desc\n+\t\tpotential = {\n+\t\t\talways = yes\n+\t\t\towner = { trait = creature_human }\n+\t\t}\n+\t\tprerequisites = { wc_bank }\t\t\n+\t\tgold_cost = 350\n+\t\tbuild_time = 650\n+\t\tretinuesize = 100\n+\t\tgarrison_size = 1\n+\t}\n+\t\n+\t#Jewelcrafters\n+\twc_jewelcrafters = {\n+\t\tdesc = wc_jewelcrafters_desc\n+\t\tpotential = {\n+\t\t\talways = yes\n+\t\t\tport = no\n+\t\t\tOR = {\n+\t\t\towner = { trait = creature_human }\n+\t\t\towner = { trait = creature_blood_elf }\n+\t\t\towner = { trait = creature_goblin }\n+\t\t\t}\n+\t\t}\t\n+\t\tgold_cost = 750\n+\t\tbuild_time = 650\n+\t\ttax_income = 0.5\n+\t}\n+\t\n+\t#Quel'dorei Jewelcrafters\n+\twc_queldoreijewelcrafters = {\n+\t\tdesc = wc_queldoreijewelcrafters_desc\n+\t\tpotential = {\n+\t\t\talways = yes\n+\t\t\tport = no\n+\t\t\towner = { trait = creature_blood_elf }\n+\t\t}\t\n+\t\tupgrades_from = wc_jewelcrafters\t\t\n+\t\tgold_cost = 1000\n+\t\tbuild_time = 1050\n+\t\ttax_income = 1\n+\t\tmonthly_character_prestige = 1","path":"common/buildings/00_tradepost.txt","position":233,"original_position":233,"commit_id":"49b37609b36f89934e4bd9ca5ce590a5393b0667","original_commit_id":"49b37609b36f89934e4bd9ca5ce590a5393b0667","user":{"login":"mdbpr1-iscteiulpt","id":32898777,"node_id":"MDQ6VXNlcjMyODk4Nzc3","avatar_url":"https://avatars1.githubusercontent.com/u/32898777?v=4","gravatar_id":"","url":"https://api.github.com/users/mdbpr1-iscteiulpt","html_url":"https://github.com/mdbpr1-iscteiulpt","followers_url":"https://api.github.com/users/mdbpr1-iscteiulpt/followers","following_url":"https://api.github.com/users/mdbpr1-iscteiulpt/following{/other_user}","gists_url":"https://api.github.com/users/mdbpr1-iscteiulpt/gists{/gist_id}","starred_url":"https://api.github.com/users/mdbpr1-iscteiulpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdbpr1-iscteiulpt/subscriptions","organizations_url":"https://api.github.com/users/mdbpr1-iscteiulpt/orgs","repos_url":"https://api.github.com/users/mdbpr1-iscteiulpt/repos","events_url":"https://api.github.com/users/mdbpr1-iscteiulpt/events{/privacy}","received_events_url":"https://api.github.com/users/mdbpr1-iscteiulpt/received_events","type":"User","site_admin":false},"body":"Ok will nerf that down, any reccomendation?It does give the decision to create a +3 modifier so i need it expensive but how much","created_at":"2019-09-16T18:39:59Z","updated_at":"2019-09-16T18:39:59Z","html_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pull/718#discussion_r324826239","pull_request_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/718","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/comments/324826239"},"html":{"href":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pull/718#discussion_r324826239"},"pull_request":{"href":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/718"}},"in_reply_to_id":324811041},"pull_request":{"url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/718","id":317992685,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3OTkyNjg1","html_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pull/718","diff_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pull/718.diff","patch_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pull/718.patch","issue_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues/718","number":718,"state":"open","locked":false,"title":"Cipher Trade posts (Trade posts and building side) pull request n1","user":{"login":"mdbpr1-iscteiulpt","id":32898777,"node_id":"MDQ6VXNlcjMyODk4Nzc3","avatar_url":"https://avatars1.githubusercontent.com/u/32898777?v=4","gravatar_id":"","url":"https://api.github.com/users/mdbpr1-iscteiulpt","html_url":"https://github.com/mdbpr1-iscteiulpt","followers_url":"https://api.github.com/users/mdbpr1-iscteiulpt/followers","following_url":"https://api.github.com/users/mdbpr1-iscteiulpt/following{/other_user}","gists_url":"https://api.github.com/users/mdbpr1-iscteiulpt/gists{/gist_id}","starred_url":"https://api.github.com/users/mdbpr1-iscteiulpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdbpr1-iscteiulpt/subscriptions","organizations_url":"https://api.github.com/users/mdbpr1-iscteiulpt/orgs","repos_url":"https://api.github.com/users/mdbpr1-iscteiulpt/repos","events_url":"https://api.github.com/users/mdbpr1-iscteiulpt/events{/privacy}","received_events_url":"https://api.github.com/users/mdbpr1-iscteiulpt/received_events","type":"User","site_admin":false},"body":"So this is the merger commit of Ciphers submod trade routes - Containing ONLY the trade Routes, trade buildings, and trade decisions that come with the mod and excludes anything related to the money borrowing mechanic that came with said mod. I hope this contains all the nessesary files and if anyhting is missing please contact me on discord at any time\r\n\r\nThis is my first ever pull request so please do give a good look at it.\r\nPlanning on working on golden road for kalimdor side and maybe a internal \"isolated\" dwarf route threw their main regions. But kalimdor priority. Whats your opinion on na uldum egyptian river like path as well\r\n\r\nSigned-off-by: \"Cipher\" - mdbpr1-iscteiulpt <[email protected]>","created_at":"2019-09-16T17:51:01Z","updated_at":"2019-09-16T18:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9faeaff6da5466e941c9aad5395456b30108a4de","assignee":{"login":"mdbpr1-iscteiulpt","id":32898777,"node_id":"MDQ6VXNlcjMyODk4Nzc3","avatar_url":"https://avatars1.githubusercontent.com/u/32898777?v=4","gravatar_id":"","url":"https://api.github.com/users/mdbpr1-iscteiulpt","html_url":"https://github.com/mdbpr1-iscteiulpt","followers_url":"https://api.github.com/users/mdbpr1-iscteiulpt/followers","following_url":"https://api.github.com/users/mdbpr1-iscteiulpt/following{/other_user}","gists_url":"https://api.github.com/users/mdbpr1-iscteiulpt/gists{/gist_id}","starred_url":"https://api.github.com/users/mdbpr1-iscteiulpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdbpr1-iscteiulpt/subscriptions","organizations_url":"https://api.github.com/users/mdbpr1-iscteiulpt/orgs","repos_url":"https://api.github.com/users/mdbpr1-iscteiulpt/repos","events_url":"https://api.github.com/users/mdbpr1-iscteiulpt/events{/privacy}","received_events_url":"https://api.github.com/users/mdbpr1-iscteiulpt/received_events","type":"User","site_admin":false},"assignees":[{"login":"mdbpr1-iscteiulpt","id":32898777,"node_id":"MDQ6VXNlcjMyODk4Nzc3","avatar_url":"https://avatars1.githubusercontent.com/u/32898777?v=4","gravatar_id":"","url":"https://api.github.com/users/mdbpr1-iscteiulpt","html_url":"https://github.com/mdbpr1-iscteiulpt","followers_url":"https://api.github.com/users/mdbpr1-iscteiulpt/followers","following_url":"https://api.github.com/users/mdbpr1-iscteiulpt/following{/other_user}","gists_url":"https://api.github.com/users/mdbpr1-iscteiulpt/gists{/gist_id}","starred_url":"https://api.github.com/users/mdbpr1-iscteiulpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdbpr1-iscteiulpt/subscriptions","organizations_url":"https://api.github.com/users/mdbpr1-iscteiulpt/orgs","repos_url":"https://api.github.com/users/mdbpr1-iscteiulpt/repos","events_url":"https://api.github.com/users/mdbpr1-iscteiulpt/events{/privacy}","received_events_url":"https://api.github.com/users/mdbpr1-iscteiulpt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1193237520,"node_id":"MDU6TGFiZWwxMTkzMjM3NTIw","url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/labels/:grey_exclamation:%20priority%20medium","name":":grey_exclamation: priority medium","color":"E6F74D","default":false},{"id":1180559866,"node_id":"MDU6TGFiZWwxMTgwNTU5ODY2","url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/labels/:star:%20new%20feature%20:new:","name":":star: new feature :new:","color":"7057ff","default":false}],"milestone":{"url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/milestones/8","html_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/milestone/8","labels_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/milestones/8/labels","id":4474252,"node_id":"MDk6TWlsZXN0b25lNDQ3NDI1Mg==","number":8,"title":"Patch 1.6.0","description":"Military Overhaul","creator":{"login":"Velius94","id":1176163,"node_id":"MDQ6VXNlcjExNzYxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1176163?v=4","gravatar_id":"","url":"https://api.github.com/users/Velius94","html_url":"https://github.com/Velius94","followers_url":"https://api.github.com/users/Velius94/followers","following_url":"https://api.github.com/users/Velius94/following{/other_user}","gists_url":"https://api.github.com/users/Velius94/gists{/gist_id}","starred_url":"https://api.github.com/users/Velius94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Velius94/subscriptions","organizations_url":"https://api.github.com/users/Velius94/orgs","repos_url":"https://api.github.com/users/Velius94/repos","events_url":"https://api.github.com/users/Velius94/events{/privacy}","received_events_url":"https://api.github.com/users/Velius94/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":28,"state":"open","created_at":"2019-07-08T15:00:30Z","updated_at":"2019-09-16T17:56:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/718/commits","review_comments_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/718/comments","review_comment_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues/718/comments","statuses_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/statuses/49b37609b36f89934e4bd9ca5ce590a5393b0667","head":{"label":"Warcraft-GoA-Development-Team:Trade-Routes-Posts-and-Buildings","ref":"Trade-Routes-Posts-and-Buildings","sha":"49b37609b36f89934e4bd9ca5ce590a5393b0667","user":{"login":"Warcraft-GoA-Development-Team","id":46384457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Mzg0NDU3","avatar_url":"https://avatars1.githubusercontent.com/u/46384457?v=4","gravatar_id":"","url":"https://api.github.com/users/Warcraft-GoA-Development-Team","html_url":"https://github.com/Warcraft-GoA-Development-Team","followers_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/followers","following_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/following{/other_user}","gists_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/subscriptions","organizations_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/orgs","repos_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/repos","events_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/events{/privacy}","received_events_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/received_events","type":"Organization","site_admin":false},"repo":{"id":164150779,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQxNTA3Nzk=","name":"Warcraft-Guardians-of-Azeroth","full_name":"Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth","private":false,"owner":{"login":"Warcraft-GoA-Development-Team","id":46384457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Mzg0NDU3","avatar_url":"https://avatars1.githubusercontent.com/u/46384457?v=4","gravatar_id":"","url":"https://api.github.com/users/Warcraft-GoA-Development-Team","html_url":"https://github.com/Warcraft-GoA-Development-Team","followers_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/followers","following_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/following{/other_user}","gists_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/subscriptions","organizations_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/orgs","repos_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/repos","events_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/events{/privacy}","received_events_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth","description":null,"fork":false,"url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth","forks_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/forks","keys_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/teams","hooks_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/hooks","issue_events_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues/events{/number}","events_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/events","assignees_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/assignees{/user}","branches_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/branches{/branch}","tags_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/tags","blobs_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/refs{/sha}","trees_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/statuses/{sha}","languages_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/languages","stargazers_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/stargazers","contributors_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/contributors","subscribers_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/subscribers","subscription_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/subscription","commits_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/commits{/sha}","git_commits_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/commits{/sha}","comments_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/comments{/number}","issue_comment_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues/comments{/number}","contents_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/contents/{+path}","compare_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/merges","archive_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/downloads","issues_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues{/number}","pulls_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls{/number}","milestones_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/milestones{/number}","notifications_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/labels{/name}","releases_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/releases{/id}","deployments_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/deployments","created_at":"2019-01-04T20:15:39Z","updated_at":"2019-09-15T18:45:40Z","pushed_at":"2019-09-16T17:56:15Z","git_url":"git://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth.git","ssh_url":"[email protected]:Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth.git","clone_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth.git","svn_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth","homepage":"https://www.patreon.com/thesomething","size":761034,"stargazers_count":41,"watchers_count":41,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":173,"license":null,"forks":17,"open_issues":173,"watchers":41,"default_branch":"master"}},"base":{"label":"Warcraft-GoA-Development-Team:master","ref":"master","sha":"b5fc8f65612d842fe53721b673a205fdefddb143","user":{"login":"Warcraft-GoA-Development-Team","id":46384457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Mzg0NDU3","avatar_url":"https://avatars1.githubusercontent.com/u/46384457?v=4","gravatar_id":"","url":"https://api.github.com/users/Warcraft-GoA-Development-Team","html_url":"https://github.com/Warcraft-GoA-Development-Team","followers_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/followers","following_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/following{/other_user}","gists_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/subscriptions","organizations_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/orgs","repos_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/repos","events_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/events{/privacy}","received_events_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/received_events","type":"Organization","site_admin":false},"repo":{"id":164150779,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQxNTA3Nzk=","name":"Warcraft-Guardians-of-Azeroth","full_name":"Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth","private":false,"owner":{"login":"Warcraft-GoA-Development-Team","id":46384457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Mzg0NDU3","avatar_url":"https://avatars1.githubusercontent.com/u/46384457?v=4","gravatar_id":"","url":"https://api.github.com/users/Warcraft-GoA-Development-Team","html_url":"https://github.com/Warcraft-GoA-Development-Team","followers_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/followers","following_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/following{/other_user}","gists_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/subscriptions","organizations_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/orgs","repos_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/repos","events_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/events{/privacy}","received_events_url":"https://api.github.com/users/Warcraft-GoA-Development-Team/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth","description":null,"fork":false,"url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth","forks_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/forks","keys_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/teams","hooks_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/hooks","issue_events_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues/events{/number}","events_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/events","assignees_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/assignees{/user}","branches_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/branches{/branch}","tags_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/tags","blobs_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/refs{/sha}","trees_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/statuses/{sha}","languages_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/languages","stargazers_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/stargazers","contributors_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/contributors","subscribers_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/subscribers","subscription_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/subscription","commits_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/commits{/sha}","git_commits_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/git/commits{/sha}","comments_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/comments{/number}","issue_comment_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues/comments{/number}","contents_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/contents/{+path}","compare_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/merges","archive_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/downloads","issues_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues{/number}","pulls_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls{/number}","milestones_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/milestones{/number}","notifications_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/labels{/name}","releases_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/releases{/id}","deployments_url":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/deployments","created_at":"2019-01-04T20:15:39Z","updated_at":"2019-09-15T18:45:40Z","pushed_at":"2019-09-16T17:56:15Z","git_url":"git://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth.git","ssh_url":"[email protected]:Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth.git","clone_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth.git","svn_url":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth","homepage":"https://www.patreon.com/thesomething","size":761034,"stargazers_count":41,"watchers_count":41,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":173,"license":null,"forks":17,"open_issues":173,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/718"},"html":{"href":"https://github.com/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pull/718"},"issue":{"href":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues/718"},"comments":{"href":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/issues/718/comments"},"review_comments":{"href":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/718/comments"},"review_comment":{"href":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/pulls/718/commits"},"statuses":{"href":"https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth/statuses/49b37609b36f89934e4bd9ca5ce590a5393b0667"}},"author_association":"NONE"}}
|
{
"id": 164150779,
"name": "Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth",
"url": "https://api.github.com/repos/Warcraft-GoA-Development-Team/Warcraft-Guardians-of-Azeroth"
}
|
{
"id": 32898777,
"login": "mdbpr1-iscteiulpt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32898777?",
"url": "https://api.github.com/users/mdbpr1-iscteiulpt"
}
|
{
"id": 46384457,
"login": "Warcraft-GoA-Development-Team",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46384457?",
"url": "https://api.github.com/orgs/Warcraft-GoA-Development-Team"
}
| 2019-09-16T18:39:59 |
10426900345
|
{"actor":{"display_login":"mdbpr1-iscteiulpt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/comments/257817330","pull_request_review_id":204941045,"id":257817330,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzgxNzMzMA==","diff_hunk":"@@ -1,289 +0,0 @@\n-#pragma once\n-// Random comment to diff this file\n-//---------------------Classes------------------------\n-class HelperFunctions;\n-class Item;\n-class Treasure;\n-class Weapon;\n-class Monster;\n-class Princess;\n-class Player;\n-class Room;\n-class Castle;\n-class Game;\n-\n-\n-\n-\n-//---------------------Definitions------------------------\n-\n-\n-\n-\n-\n-//---------------------Helper Functions------------------------\n-class HelperFunctions\n-{\n-private:\n-\n-public:\n-\n-\t//Converts all the characters of Input to UpperCase\n-\tstatic void\tcharactersCase(char*);\n-\tstatic void color(int);\n-};\n-\n-\n-\n-\n-\n-//------------------------Item----------------------------------\n-class Item\n-{\n-protected:\n-\n-\tchar* name;\n-\n-public:\n-\n-\tItem();\n-\t~Item();\n-\n-\tinline char* getItemName();\n-\tinline virtual int getWorth() = 0;\n-\n-\n-};\n-\n-\n-\n-\n-\n-//------------------------Treasure--------------------------------\n-class Treasure : public Item\n-{\n-private:\n-\tint worth;\n-\n-public:\n-\n-\tTreasure();\n-\t~Treasure();\n-\tTreasure(char const*, int);\n-\n-\tinline int\tgetWorth();\n-\n-};\n-\n-\n-\n-\n-\n-//----------------------Weapon---------------------------------------\n-class Weapon : public Item\n-{\n-private:\n-\n-public:\n-\n-\tWeapon();\n-\t~Weapon();\n-\tWeapon(char const*);\n-\n-\tinline int getWorth();\n-\n-};\n-\n-\n-\n-\n-\n-//-----------------------Monster---------------------------------------\n-class Monster\n-{\n-private:\n-\tchar* name;\n-\tbool is_Alive;\n-\tItem* killing_weapon;\n-\n-\n-public:\n-\n-\tMonster();\n-\t~Monster();\n-\tMonster(char const*, Item*);\n-\n-\tinline Item* \tgetKillingWeapon();\n-\tinline void\t\tsetKillingWeapon(Item*);\n-\tinline bool\t\tgetLivingState();\n-\tinline void\t\tsetLivingState(bool);\n-\tinline char*\tgetMonsterName();\n-\n-};\n-\n-\n-\n-\n-\n-//---------------------Princess-------------------------------------\n-class Princess\n-{\n-private:\n-\tbool is_Alive;\n-\n-public:\n-\tPrincess();\n-\t~Princess();\n-\n-\tinline bool\t getLivingState();\n-\tinline void\t setLivingState(bool);\n-};\n-\n-\n-\n-\n-\n-//-----------------------Room------------------------------------------\n-class Room\n-{\n-private:\n-\tRoom* \t\tpaths[4];\n-\tItem* \t\titems_Present[5];\n-\tMonster* monster_Present;\n-\tPrincess* princess_Present;\n-\n-\n-\tchar*\t\tdescription;\n-\tint \t\troomNumber;\n-\n-\n-public:\n-\tRoom();\n-\t~Room();\n-\n-\tinline Room** \t\tgetPaths();\n-\tinline Item**\t\tgetItemsPresent();\n-\tinline Monster*\t\tgetMonsterPresent();\n-\tinline Princess*\tgetPrincessPresent();\n-\tinline char*\t\tgetDescription();\n-\tinline int \t\t\tgetRoomNumber();\n-\n-\tbool\t\t\t\tisRoomFull();\n-\n-\n-\tint\t\t\t\t\tdirectionIndex(char const*);\n-\tchar* \t\t\t\tdirectionName(int);","path":"Zelda/Zelda.h","position":175,"original_position":175,"commit_id":"f7d74401a5740f6fb66f292b4fd7411debdbd573","original_commit_id":"f7d74401a5740f6fb66f292b4fd7411debdbd573","user":{"login":"quasibit-wrangler","id":32142161,"node_id":"MDQ6VXNlcjMyMTQyMTYx","avatar_url":"https://avatars3.githubusercontent.com/u/32142161?v=4","gravatar_id":"","url":"https://api.github.com/users/quasibit-wrangler","html_url":"https://github.com/quasibit-wrangler","followers_url":"https://api.github.com/users/quasibit-wrangler/followers","following_url":"https://api.github.com/users/quasibit-wrangler/following{/other_user}","gists_url":"https://api.github.com/users/quasibit-wrangler/gists{/gist_id}","starred_url":"https://api.github.com/users/quasibit-wrangler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasibit-wrangler/subscriptions","organizations_url":"https://api.github.com/users/quasibit-wrangler/orgs","repos_url":"https://api.github.com/users/quasibit-wrangler/repos","events_url":"https://api.github.com/users/quasibit-wrangler/events{/privacy}","received_events_url":"https://api.github.com/users/quasibit-wrangler/received_events","type":"User","site_admin":false},"body":"these functions seem complicated and probably would be best to have them set private.","created_at":"2019-02-18T20:17:36Z","updated_at":"2019-02-18T20:17:36Z","html_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game/pull/6#discussion_r257817330","pull_request_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/comments/257817330"},"html":{"href":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game/pull/6#discussion_r257817330"},"pull_request":{"href":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/6","id":253681731,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzNjgxNzMx","html_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game/pull/6","diff_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game/pull/6.diff","patch_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game/pull/6.patch","issue_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues/6","number":6,"state":"open","locked":false,"title":"Use this pull request to review the code","user":{"login":"hiebelky","id":25038760,"node_id":"MDQ6VXNlcjI1MDM4NzYw","avatar_url":"https://avatars2.githubusercontent.com/u/25038760?v=4","gravatar_id":"","url":"https://api.github.com/users/hiebelky","html_url":"https://github.com/hiebelky","followers_url":"https://api.github.com/users/hiebelky/followers","following_url":"https://api.github.com/users/hiebelky/following{/other_user}","gists_url":"https://api.github.com/users/hiebelky/gists{/gist_id}","starred_url":"https://api.github.com/users/hiebelky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiebelky/subscriptions","organizations_url":"https://api.github.com/users/hiebelky/orgs","repos_url":"https://api.github.com/users/hiebelky/repos","events_url":"https://api.github.com/users/hiebelky/events{/privacy}","received_events_url":"https://api.github.com/users/hiebelky/received_events","type":"User","site_admin":false},"body":"Add comments to your section of the code below. Those can be screenshotted and added to the document.","created_at":"2019-02-17T02:04:18Z","updated_at":"2019-02-18T20:17:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8530ce560d2821ca6f3d6d03d5b2df93c877a80a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/6/commits","review_comments_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/6/comments","review_comment_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues/6/comments","statuses_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/statuses/f7d74401a5740f6fb66f292b4fd7411debdbd573","head":{"label":"bug-inspectors-with-a-stick:code-review","ref":"code-review","sha":"f7d74401a5740f6fb66f292b4fd7411debdbd573","user":{"login":"bug-inspectors-with-a-stick","id":46721271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NzIxMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/46721271?v=4","gravatar_id":"","url":"https://api.github.com/users/bug-inspectors-with-a-stick","html_url":"https://github.com/bug-inspectors-with-a-stick","followers_url":"https://api.github.com/users/bug-inspectors-with-a-stick/followers","following_url":"https://api.github.com/users/bug-inspectors-with-a-stick/following{/other_user}","gists_url":"https://api.github.com/users/bug-inspectors-with-a-stick/gists{/gist_id}","starred_url":"https://api.github.com/users/bug-inspectors-with-a-stick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bug-inspectors-with-a-stick/subscriptions","organizations_url":"https://api.github.com/users/bug-inspectors-with-a-stick/orgs","repos_url":"https://api.github.com/users/bug-inspectors-with-a-stick/repos","events_url":"https://api.github.com/users/bug-inspectors-with-a-stick/events{/privacy}","received_events_url":"https://api.github.com/users/bug-inspectors-with-a-stick/received_events","type":"Organization","site_admin":false},"repo":{"id":165889741,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU4ODk3NDE=","name":"Zelda-Game","full_name":"bug-inspectors-with-a-stick/Zelda-Game","private":false,"owner":{"login":"bug-inspectors-with-a-stick","id":46721271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NzIxMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/46721271?v=4","gravatar_id":"","url":"https://api.github.com/users/bug-inspectors-with-a-stick","html_url":"https://github.com/bug-inspectors-with-a-stick","followers_url":"https://api.github.com/users/bug-inspectors-with-a-stick/followers","following_url":"https://api.github.com/users/bug-inspectors-with-a-stick/following{/other_user}","gists_url":"https://api.github.com/users/bug-inspectors-with-a-stick/gists{/gist_id}","starred_url":"https://api.github.com/users/bug-inspectors-with-a-stick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bug-inspectors-with-a-stick/subscriptions","organizations_url":"https://api.github.com/users/bug-inspectors-with-a-stick/orgs","repos_url":"https://api.github.com/users/bug-inspectors-with-a-stick/repos","events_url":"https://api.github.com/users/bug-inspectors-with-a-stick/events{/privacy}","received_events_url":"https://api.github.com/users/bug-inspectors-with-a-stick/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game","description":"๐ฝ A text based adventure game made using concepts of OOP like Inheritance, Composition, Association, Polymorphism etc","fork":true,"url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game","forks_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/forks","keys_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/teams","hooks_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/hooks","issue_events_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues/events{/number}","events_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/events","assignees_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/assignees{/user}","branches_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/branches{/branch}","tags_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/tags","blobs_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/refs{/sha}","trees_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/statuses/{sha}","languages_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/languages","stargazers_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/stargazers","contributors_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/contributors","subscribers_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/subscribers","subscription_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/subscription","commits_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/commits{/sha}","git_commits_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/commits{/sha}","comments_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/comments{/number}","issue_comment_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues/comments{/number}","contents_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/contents/{+path}","compare_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/merges","archive_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/downloads","issues_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues{/number}","pulls_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls{/number}","milestones_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/milestones{/number}","notifications_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/labels{/name}","releases_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/releases{/id}","deployments_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/deployments","created_at":"2019-01-15T16:58:56Z","updated_at":"2019-02-17T01:56:44Z","pushed_at":"2019-02-17T02:04:18Z","git_url":"git://github.com/bug-inspectors-with-a-stick/Zelda-Game.git","ssh_url":"[email protected]:bug-inspectors-with-a-stick/Zelda-Game.git","clone_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game.git","svn_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game","homepage":"","size":316,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"bug-inspectors-with-a-stick:master","ref":"master","sha":"d949c206f27a6db0284241c08f3a35d84ce4ce60","user":{"login":"bug-inspectors-with-a-stick","id":46721271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NzIxMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/46721271?v=4","gravatar_id":"","url":"https://api.github.com/users/bug-inspectors-with-a-stick","html_url":"https://github.com/bug-inspectors-with-a-stick","followers_url":"https://api.github.com/users/bug-inspectors-with-a-stick/followers","following_url":"https://api.github.com/users/bug-inspectors-with-a-stick/following{/other_user}","gists_url":"https://api.github.com/users/bug-inspectors-with-a-stick/gists{/gist_id}","starred_url":"https://api.github.com/users/bug-inspectors-with-a-stick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bug-inspectors-with-a-stick/subscriptions","organizations_url":"https://api.github.com/users/bug-inspectors-with-a-stick/orgs","repos_url":"https://api.github.com/users/bug-inspectors-with-a-stick/repos","events_url":"https://api.github.com/users/bug-inspectors-with-a-stick/events{/privacy}","received_events_url":"https://api.github.com/users/bug-inspectors-with-a-stick/received_events","type":"Organization","site_admin":false},"repo":{"id":165889741,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU4ODk3NDE=","name":"Zelda-Game","full_name":"bug-inspectors-with-a-stick/Zelda-Game","private":false,"owner":{"login":"bug-inspectors-with-a-stick","id":46721271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NzIxMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/46721271?v=4","gravatar_id":"","url":"https://api.github.com/users/bug-inspectors-with-a-stick","html_url":"https://github.com/bug-inspectors-with-a-stick","followers_url":"https://api.github.com/users/bug-inspectors-with-a-stick/followers","following_url":"https://api.github.com/users/bug-inspectors-with-a-stick/following{/other_user}","gists_url":"https://api.github.com/users/bug-inspectors-with-a-stick/gists{/gist_id}","starred_url":"https://api.github.com/users/bug-inspectors-with-a-stick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bug-inspectors-with-a-stick/subscriptions","organizations_url":"https://api.github.com/users/bug-inspectors-with-a-stick/orgs","repos_url":"https://api.github.com/users/bug-inspectors-with-a-stick/repos","events_url":"https://api.github.com/users/bug-inspectors-with-a-stick/events{/privacy}","received_events_url":"https://api.github.com/users/bug-inspectors-with-a-stick/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game","description":"๐ฝ A text based adventure game made using concepts of OOP like Inheritance, Composition, Association, Polymorphism etc","fork":true,"url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game","forks_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/forks","keys_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/teams","hooks_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/hooks","issue_events_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues/events{/number}","events_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/events","assignees_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/assignees{/user}","branches_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/branches{/branch}","tags_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/tags","blobs_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/refs{/sha}","trees_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/statuses/{sha}","languages_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/languages","stargazers_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/stargazers","contributors_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/contributors","subscribers_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/subscribers","subscription_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/subscription","commits_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/commits{/sha}","git_commits_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/git/commits{/sha}","comments_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/comments{/number}","issue_comment_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues/comments{/number}","contents_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/contents/{+path}","compare_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/merges","archive_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/downloads","issues_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues{/number}","pulls_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls{/number}","milestones_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/milestones{/number}","notifications_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/labels{/name}","releases_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/releases{/id}","deployments_url":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/deployments","created_at":"2019-01-15T16:58:56Z","updated_at":"2019-02-17T01:56:44Z","pushed_at":"2019-02-17T02:04:18Z","git_url":"git://github.com/bug-inspectors-with-a-stick/Zelda-Game.git","ssh_url":"[email protected]:bug-inspectors-with-a-stick/Zelda-Game.git","clone_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game.git","svn_url":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game","homepage":"","size":316,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/6"},"html":{"href":"https://github.com/bug-inspectors-with-a-stick/Zelda-Game/pull/6"},"issue":{"href":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues/6"},"comments":{"href":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game/statuses/f7d74401a5740f6fb66f292b4fd7411debdbd573"}},"author_association":"NONE"}}
|
{
"id": 165889741,
"name": "bug-inspectors-with-a-stick/Zelda-Game",
"url": "https://api.github.com/repos/bug-inspectors-with-a-stick/Zelda-Game"
}
|
{
"id": 32142161,
"login": "quasibit-wrangler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32142161?",
"url": "https://api.github.com/users/quasibit-wrangler"
}
|
{
"id": 46721271,
"login": "bug-inspectors-with-a-stick",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46721271?",
"url": "https://api.github.com/orgs/bug-inspectors-with-a-stick"
}
| 2019-02-18T20:17:36 |
9089728599
|
{"actor":{"display_login":"quasibit-wrangler"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/comments/356163683","pull_request_review_id":329999651,"id":356163683,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NjE2MzY4Mw==","diff_hunk":"@@ -0,0 +1,55 @@\n+#region LICENSE\n+\n+/**\n+* Copyright (c) 2019 Catalyst Network\n+*\n+* This file is part of Catalyst.Node <https://github.com/catalyst-network/Catalyst.Node>\n+*\n+* Catalyst.Node is free software: you can redistribute it and/or modify\n+* it under the terms of the GNU General Public License as published by\n+* the Free Software Foundation, either version 2 of the License, or\n+* (at your option) any later version.\n+*\n+* Catalyst.Node is distributed in the hope that it will be useful,\n+* but WITHOUT ANY WARRANTY; without even the implied warranty of\n+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+* GNU General Public License for more details.\n+*\n+* You should have received a copy of the GNU General Public License\n+* along with Catalyst.Node. If not, see <https://www.gnu.org/licenses/>.\n+*/\n+\n+#endregion\n+\n+using System;\n+using System.IO;\n+using Catalyst.Abstractions.Consensus.Deltas;\n+using Catalyst.Protocol.Deltas;\n+using Serilog;\n+using Serilog.Events;\n+\n+namespace Catalyst.Core.Modules.Consensus.Deltas.Building\n+{\n+ internal sealed class PreviousDeltaResolverStep : IDeltaBuilderStep\n+ {\n+ private readonly IDeltaCache _deltaCache;\n+ private readonly ILogger _logger;\n+\n+ public PreviousDeltaResolverStep(IDeltaCache deltaCache, ILogger logger)\n+ {\n+ _deltaCache = deltaCache ?? throw new ArgumentNullException(nameof(deltaCache));\n+ _logger = logger ?? throw new ArgumentNullException(nameof(logger));","path":"src/Catalyst.Core.Modules.Consensus/Deltas/Building/PreviousDeltaResolverStep.cs","position":41,"original_position":41,"commit_id":"9e63da85354304d07e4402db9558d2085c03e2c2","original_commit_id":"9e63da85354304d07e4402db9558d2085c03e2c2","user":{"login":"nshCore","id":21375475,"node_id":"MDQ6VXNlcjIxMzc1NDc1","avatar_url":"https://avatars2.githubusercontent.com/u/21375475?v=4","gravatar_id":"","url":"https://api.github.com/users/nshCore","html_url":"https://github.com/nshCore","followers_url":"https://api.github.com/users/nshCore/followers","following_url":"https://api.github.com/users/nshCore/following{/other_user}","gists_url":"https://api.github.com/users/nshCore/gists{/gist_id}","starred_url":"https://api.github.com/users/nshCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nshCore/subscriptions","organizations_url":"https://api.github.com/users/nshCore/orgs","repos_url":"https://api.github.com/users/nshCore/repos","events_url":"https://api.github.com/users/nshCore/events{/privacy}","received_events_url":"https://api.github.com/users/nshCore/received_events","type":"User","site_admin":false},"body":" Issue found: [The parameter name '' is not declared in the argument list.](https://app.codacy.com/app/catalyst-network/Catalyst.Framework/pullRequest?prid=4585091)","created_at":"2019-12-10T17:05:49Z","updated_at":"2019-12-10T17:05:49Z","html_url":"https://github.com/catalyst-network/Catalyst/pull/1113#discussion_r356163683","pull_request_url":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/1113","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/comments/356163683"},"html":{"href":"https://github.com/catalyst-network/Catalyst/pull/1113#discussion_r356163683"},"pull_request":{"href":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/1113"}}},"pull_request":{"url":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/1113","id":346780310,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2NzgwMzEw","html_url":"https://github.com/catalyst-network/Catalyst/pull/1113","diff_url":"https://github.com/catalyst-network/Catalyst/pull/1113.diff","patch_url":"https://github.com/catalyst-network/Catalyst/pull/1113.patch","issue_url":"https://api.github.com/repos/catalyst-network/Catalyst/issues/1113","number":1113,"state":"open","locked":false,"title":"Poatruffleson","user":{"login":"tkstanczak","id":498913,"node_id":"MDQ6VXNlcjQ5ODkxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/498913?v=4","gravatar_id":"","url":"https://api.github.com/users/tkstanczak","html_url":"https://github.com/tkstanczak","followers_url":"https://api.github.com/users/tkstanczak/followers","following_url":"https://api.github.com/users/tkstanczak/following{/other_user}","gists_url":"https://api.github.com/users/tkstanczak/gists{/gist_id}","starred_url":"https://api.github.com/users/tkstanczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkstanczak/subscriptions","organizations_url":"https://api.github.com/users/tkstanczak/orgs","repos_url":"https://api.github.com/users/tkstanczak/repos","events_url":"https://api.github.com/users/tkstanczak/events{/privacy}","received_events_url":"https://api.github.com/users/tkstanczak/received_events","type":"User","site_admin":false},"body":"### New Pull Request Submissions:\r\n\r\n1. [ ] Have you followed the guidelines in our [Contributing document](https://github.com/atlascity/Community/tree/master/CONTRIBUTING.md)?\r\n2. [ ] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?\r\n3. [ ] I have added tests to cover my changes.\r\n4. [ ] All new and existing tests passed.\r\n5. [ ] Have you lint your code locally prior to submission?\r\n6. [ ] Does your code follows the code style of this project?\r\n7. [ ] Does your change require a change to the documentation.\r\n - [ ] I have updated the documentation accordingly.\r\n9. [ ] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n10. [ ] Have you inserted a keyword and link to the issues the PR closes in its descriptions (ex `closes #1`) ?\r\n11. [ ] Is you branch up to date, have you integrated all the latest changes from develop and resolved conflicts ?\r\n\r\n* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\n\r\n* **What is the current behavior?** (You can also link to an open issue here)\r\n\r\n* **What is the new behavior (if this is a feature change)?**\r\n\r\n* **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?)\r\n\r\n* **Other information**:\r\n","created_at":"2019-11-28T16:44:59Z","updated_at":"2019-12-10T17:05:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15274d6b37941e6278c0affb4fef97620c66bc9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1288445079,"node_id":"MDU6TGFiZWwxMjg4NDQ1MDc5","url":"https://api.github.com/repos/catalyst-network/Catalyst/labels/DO%20NOT%20MERGE%20%E2%9B%94","name":"DO NOT MERGE โ","color":"e2222b","default":false,"description":""}],"milestone":{"url":"https://api.github.com/repos/catalyst-network/Catalyst/milestones/9","html_url":"https://github.com/catalyst-network/Catalyst/milestone/9","labels_url":"https://api.github.com/repos/catalyst-network/Catalyst/milestones/9/labels","id":4612958,"node_id":"MDk6TWlsZXN0b25lNDYxMjk1OA==","number":9,"title":"kvm-development","description":"Development of the Katal Virtual Machine (KVM)","creator":{"login":"nshCore","id":21375475,"node_id":"MDQ6VXNlcjIxMzc1NDc1","avatar_url":"https://avatars2.githubusercontent.com/u/21375475?v=4","gravatar_id":"","url":"https://api.github.com/users/nshCore","html_url":"https://github.com/nshCore","followers_url":"https://api.github.com/users/nshCore/followers","following_url":"https://api.github.com/users/nshCore/following{/other_user}","gists_url":"https://api.github.com/users/nshCore/gists{/gist_id}","starred_url":"https://api.github.com/users/nshCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nshCore/subscriptions","organizations_url":"https://api.github.com/users/nshCore/orgs","repos_url":"https://api.github.com/users/nshCore/repos","events_url":"https://api.github.com/users/nshCore/events{/privacy}","received_events_url":"https://api.github.com/users/nshCore/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":6,"state":"open","created_at":"2019-08-29T09:00:29Z","updated_at":"2019-11-28T16:45:59Z","due_on":"2020-01-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/1113/commits","review_comments_url":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/1113/comments","review_comment_url":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/catalyst-network/Catalyst/issues/1113/comments","statuses_url":"https://api.github.com/repos/catalyst-network/Catalyst/statuses/9e63da85354304d07e4402db9558d2085c03e2c2","head":{"label":"catalyst-network:poatruffleson","ref":"poatruffleson","sha":"9e63da85354304d07e4402db9558d2085c03e2c2","user":{"login":"catalyst-network","id":46792459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NzkyNDU5","avatar_url":"https://avatars2.githubusercontent.com/u/46792459?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst-network","html_url":"https://github.com/catalyst-network","followers_url":"https://api.github.com/users/catalyst-network/followers","following_url":"https://api.github.com/users/catalyst-network/following{/other_user}","gists_url":"https://api.github.com/users/catalyst-network/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst-network/subscriptions","organizations_url":"https://api.github.com/users/catalyst-network/orgs","repos_url":"https://api.github.com/users/catalyst-network/repos","events_url":"https://api.github.com/users/catalyst-network/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst-network/received_events","type":"Organization","site_admin":false},"repo":{"id":170142194,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAxNDIxOTQ=","name":"Catalyst","full_name":"catalyst-network/Catalyst","private":false,"owner":{"login":"catalyst-network","id":46792459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NzkyNDU5","avatar_url":"https://avatars2.githubusercontent.com/u/46792459?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst-network","html_url":"https://github.com/catalyst-network","followers_url":"https://api.github.com/users/catalyst-network/followers","following_url":"https://api.github.com/users/catalyst-network/following{/other_user}","gists_url":"https://api.github.com/users/catalyst-network/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst-network/subscriptions","organizations_url":"https://api.github.com/users/catalyst-network/orgs","repos_url":"https://api.github.com/users/catalyst-network/repos","events_url":"https://api.github.com/users/catalyst-network/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalyst-network/Catalyst","description":"Fast, scalable PBFT distributed ledger","fork":false,"url":"https://api.github.com/repos/catalyst-network/Catalyst","forks_url":"https://api.github.com/repos/catalyst-network/Catalyst/forks","keys_url":"https://api.github.com/repos/catalyst-network/Catalyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalyst-network/Catalyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalyst-network/Catalyst/teams","hooks_url":"https://api.github.com/repos/catalyst-network/Catalyst/hooks","issue_events_url":"https://api.github.com/repos/catalyst-network/Catalyst/issues/events{/number}","events_url":"https://api.github.com/repos/catalyst-network/Catalyst/events","assignees_url":"https://api.github.com/repos/catalyst-network/Catalyst/assignees{/user}","branches_url":"https://api.github.com/repos/catalyst-network/Catalyst/branches{/branch}","tags_url":"https://api.github.com/repos/catalyst-network/Catalyst/tags","blobs_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalyst-network/Catalyst/statuses/{sha}","languages_url":"https://api.github.com/repos/catalyst-network/Catalyst/languages","stargazers_url":"https://api.github.com/repos/catalyst-network/Catalyst/stargazers","contributors_url":"https://api.github.com/repos/catalyst-network/Catalyst/contributors","subscribers_url":"https://api.github.com/repos/catalyst-network/Catalyst/subscribers","subscription_url":"https://api.github.com/repos/catalyst-network/Catalyst/subscription","commits_url":"https://api.github.com/repos/catalyst-network/Catalyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalyst-network/Catalyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalyst-network/Catalyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalyst-network/Catalyst/contents/{+path}","compare_url":"https://api.github.com/repos/catalyst-network/Catalyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalyst-network/Catalyst/merges","archive_url":"https://api.github.com/repos/catalyst-network/Catalyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalyst-network/Catalyst/downloads","issues_url":"https://api.github.com/repos/catalyst-network/Catalyst/issues{/number}","pulls_url":"https://api.github.com/repos/catalyst-network/Catalyst/pulls{/number}","milestones_url":"https://api.github.com/repos/catalyst-network/Catalyst/milestones{/number}","notifications_url":"https://api.github.com/repos/catalyst-network/Catalyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalyst-network/Catalyst/labels{/name}","releases_url":"https://api.github.com/repos/catalyst-network/Catalyst/releases{/id}","deployments_url":"https://api.github.com/repos/catalyst-network/Catalyst/deployments","created_at":"2019-02-11T14:25:46Z","updated_at":"2019-12-08T15:25:46Z","pushed_at":"2019-12-10T17:03:12Z","git_url":"git://github.com/catalyst-network/Catalyst.git","ssh_url":"[email protected]:catalyst-network/Catalyst.git","clone_url":"https://github.com/catalyst-network/Catalyst.git","svn_url":"https://github.com/catalyst-network/Catalyst","homepage":"https://www.catalystnet.org","size":126667,"stargazers_count":12,"watchers_count":12,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":83,"watchers":12,"default_branch":"master"}},"base":{"label":"catalyst-network:develop","ref":"develop","sha":"f972482e1e75b13bc3526e0f7ab242f4547a2da5","user":{"login":"catalyst-network","id":46792459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NzkyNDU5","avatar_url":"https://avatars2.githubusercontent.com/u/46792459?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst-network","html_url":"https://github.com/catalyst-network","followers_url":"https://api.github.com/users/catalyst-network/followers","following_url":"https://api.github.com/users/catalyst-network/following{/other_user}","gists_url":"https://api.github.com/users/catalyst-network/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst-network/subscriptions","organizations_url":"https://api.github.com/users/catalyst-network/orgs","repos_url":"https://api.github.com/users/catalyst-network/repos","events_url":"https://api.github.com/users/catalyst-network/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst-network/received_events","type":"Organization","site_admin":false},"repo":{"id":170142194,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAxNDIxOTQ=","name":"Catalyst","full_name":"catalyst-network/Catalyst","private":false,"owner":{"login":"catalyst-network","id":46792459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NzkyNDU5","avatar_url":"https://avatars2.githubusercontent.com/u/46792459?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst-network","html_url":"https://github.com/catalyst-network","followers_url":"https://api.github.com/users/catalyst-network/followers","following_url":"https://api.github.com/users/catalyst-network/following{/other_user}","gists_url":"https://api.github.com/users/catalyst-network/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst-network/subscriptions","organizations_url":"https://api.github.com/users/catalyst-network/orgs","repos_url":"https://api.github.com/users/catalyst-network/repos","events_url":"https://api.github.com/users/catalyst-network/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalyst-network/Catalyst","description":"Fast, scalable PBFT distributed ledger","fork":false,"url":"https://api.github.com/repos/catalyst-network/Catalyst","forks_url":"https://api.github.com/repos/catalyst-network/Catalyst/forks","keys_url":"https://api.github.com/repos/catalyst-network/Catalyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalyst-network/Catalyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalyst-network/Catalyst/teams","hooks_url":"https://api.github.com/repos/catalyst-network/Catalyst/hooks","issue_events_url":"https://api.github.com/repos/catalyst-network/Catalyst/issues/events{/number}","events_url":"https://api.github.com/repos/catalyst-network/Catalyst/events","assignees_url":"https://api.github.com/repos/catalyst-network/Catalyst/assignees{/user}","branches_url":"https://api.github.com/repos/catalyst-network/Catalyst/branches{/branch}","tags_url":"https://api.github.com/repos/catalyst-network/Catalyst/tags","blobs_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalyst-network/Catalyst/statuses/{sha}","languages_url":"https://api.github.com/repos/catalyst-network/Catalyst/languages","stargazers_url":"https://api.github.com/repos/catalyst-network/Catalyst/stargazers","contributors_url":"https://api.github.com/repos/catalyst-network/Catalyst/contributors","subscribers_url":"https://api.github.com/repos/catalyst-network/Catalyst/subscribers","subscription_url":"https://api.github.com/repos/catalyst-network/Catalyst/subscription","commits_url":"https://api.github.com/repos/catalyst-network/Catalyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalyst-network/Catalyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalyst-network/Catalyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalyst-network/Catalyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalyst-network/Catalyst/contents/{+path}","compare_url":"https://api.github.com/repos/catalyst-network/Catalyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalyst-network/Catalyst/merges","archive_url":"https://api.github.com/repos/catalyst-network/Catalyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalyst-network/Catalyst/downloads","issues_url":"https://api.github.com/repos/catalyst-network/Catalyst/issues{/number}","pulls_url":"https://api.github.com/repos/catalyst-network/Catalyst/pulls{/number}","milestones_url":"https://api.github.com/repos/catalyst-network/Catalyst/milestones{/number}","notifications_url":"https://api.github.com/repos/catalyst-network/Catalyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalyst-network/Catalyst/labels{/name}","releases_url":"https://api.github.com/repos/catalyst-network/Catalyst/releases{/id}","deployments_url":"https://api.github.com/repos/catalyst-network/Catalyst/deployments","created_at":"2019-02-11T14:25:46Z","updated_at":"2019-12-08T15:25:46Z","pushed_at":"2019-12-10T17:03:12Z","git_url":"git://github.com/catalyst-network/Catalyst.git","ssh_url":"[email protected]:catalyst-network/Catalyst.git","clone_url":"https://github.com/catalyst-network/Catalyst.git","svn_url":"https://github.com/catalyst-network/Catalyst","homepage":"https://www.catalystnet.org","size":126667,"stargazers_count":12,"watchers_count":12,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":83,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/1113"},"html":{"href":"https://github.com/catalyst-network/Catalyst/pull/1113"},"issue":{"href":"https://api.github.com/repos/catalyst-network/Catalyst/issues/1113"},"comments":{"href":"https://api.github.com/repos/catalyst-network/Catalyst/issues/1113/comments"},"review_comments":{"href":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/1113/comments"},"review_comment":{"href":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/catalyst-network/Catalyst/pulls/1113/commits"},"statuses":{"href":"https://api.github.com/repos/catalyst-network/Catalyst/statuses/9e63da85354304d07e4402db9558d2085c03e2c2"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 170142194,
"name": "catalyst-network/Catalyst",
"url": "https://api.github.com/repos/catalyst-network/Catalyst"
}
|
{
"id": 21375475,
"login": "nshCore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21375475?",
"url": "https://api.github.com/users/nshCore"
}
|
{
"id": 46792459,
"login": "catalyst-network",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46792459?",
"url": "https://api.github.com/orgs/catalyst-network"
}
| 2019-12-10T17:05:49 |
11056543264
|
{"actor":{"display_login":"nshCore"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/comments/305518875","pull_request_review_id":264422995,"id":305518875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTUxODg3NQ==","diff_hunk":"@@ -781,3 +782,106 @@ def single_chain_init(key, only_params=False):\n _, potential_fn, constrain_fun = single_chain_init(rng[0])\n init_params = vmap(lambda rng: single_chain_init(rng, only_params=True))(rng)\n return init_params, potential_fn, constrain_fun\n+\n+\n+# TODO: to be replaced by np.cov ddof=1 for the next JAX version\n+def _cov(samples):\n+ wc_init, wc_update, wc_final = welford_covariance(diagonal=False)\n+ state = wc_init(samples.shape[1])\n+ state = fori_loop(0, samples.shape[0], lambda i, state: wc_update(samples[i], state), state)\n+ return wc_final(state)[0]\n+\n+\n+def consensus(subposteriors, num_draws, diagonal=False, rng=None):\n+ \"\"\"\n+ Merges subposteriors following consensus Monte Carlo algorithm.\n+\n+ **References:**\n+\n+ 1. *Bayes and big data: The consensus Monte Carlo algorithm*,\n+ Steven L. Scott, Alexander W. Blocker, Fernando V. Bonassi, Hugh A. Chipman,\n+ Edward I. George, Robert E. McCulloch\n+\n+ :param list subposteriors: a list in which each element is a collection of samples.\n+ :param int num_draws: number of draws from the merged posterior.\n+ :param bool diagonal: whether to compute weights using variance or covariance, defaults to\n+ `False` (using covariance).\n+ :param jax.random.PRNGKey rng: source of the randomness, defaults to `jax.random.PRNGKey(0)`.\n+ :return: a collection of `num_draws` samples with the same data structure as each subposterior.\n+ \"\"\"\n+ rng = random.PRNGKey(0) if rng is None else rng\n+ # stack subposteriors\n+ joined_subposteriors = tree_multimap(lambda *args: np.stack(args), *subposteriors)\n+ # shape of joined_subposteriors: n_subs x n_samples x sample_shape\n+ joined_subposteriors = vmap(vmap(lambda sample: ravel_pytree(sample)[0]))(joined_subposteriors)\n+\n+ # randomly gets num_draws from subposteriors\n+ n_subs = len(subposteriors)\n+ n_samples = tree_flatten(subposteriors[0])[0][0].shape[0]\n+ # shape of draw_idxs: n_subs x num_draws x sample_shape\n+ draw_idxs = random.randint(rng, shape=(n_subs, num_draws), minval=0, maxval=n_samples)\n+ joined_subposteriors = vmap(lambda x, idx: x[idx])(joined_subposteriors, draw_idxs)\n+\n+ if diagonal:\n+ # compute weights for each subposterior (ref: Section 3.1 of [1])\n+ weights = vmap(lambda x: (1 - 1 / n_samples) / np.var(x, axis=0))(joined_subposteriors)\n+ normalized_weights = weights / np.sum(weights, axis=0)\n+ # get weighted samples\n+ samples_flat = np.einsum('ij,ikj->kj', normalized_weights, joined_subposteriors)\n+ else:\n+ weights = vmap(lambda x: np.linalg.inv(_cov(x)))(joined_subposteriors)\n+ normalized_weights = np.matmul(np.linalg.inv(np.sum(weights, axis=0)), weights)\n+ samples_flat = np.einsum('ijk,ilk->lj', normalized_weights, joined_subposteriors)\n+\n+ # unravel_fn acts on 1 sample of a subposterior\n+ _, unravel_fn = ravel_pytree(tree_map(lambda x: x[0], subposteriors[0]))\n+ return vmap(lambda x: unravel_fn(x))(samples_flat)\n+\n+\n+def parametric(subposteriors, num_draws, diagonal=False, rng=None, return_params=False):\n+ \"\"\"\n+ Merges subposteriors following (embarrassingly parallel) parametric Monte Carlo algorithm.\n+\n+ **References:**\n+\n+ 1. *Asymptotically Exact, Embarrassingly Parallel MCMC*,\n+ Willie Neiswanger, Chong Wang, Eric Xing\n+\n+ :param list subposteriors: a list in which each element is a collection of samples.\n+ :param int num_draws: number of draws from the merged posterior.\n+ :param jax.random.PRNGKey rng: source of the randomness, defaults to `jax.random.PRNGKey(0)`.\n+ :param bool return_params: whether to additionally return the estimated mean and\n+ variance/covariance parameters of the joined posterior.\n+ :return: a collection of `num_draws` samples with the same data structure as each subposterior.\n+ \"\"\"\n+ rng = random.PRNGKey(0) if rng is None else rng\n+ joined_subposteriors = tree_multimap(lambda *args: np.stack(args), *subposteriors)\n+ joined_subposteriors = vmap(vmap(lambda sample: ravel_pytree(sample)[0]))(joined_subposteriors)\n+\n+ submeans = np.mean(joined_subposteriors, axis=1)\n+ n_samples = tree_flatten(subposteriors[0])[0][0].shape[0]\n+ if diagonal:\n+ # NB: jax.numpy.var does not support ddof=1, so we do it manually\n+ weights = vmap(lambda x: (1 - 1 / n_samples) / np.var(x, axis=0))(joined_subposteriors)\n+ var = 1 / np.sum(weights, axis=0)\n+ normalized_weights = var * weights\n+\n+ # comparing to consensus implementation, we compute weighted mean here\n+ mean = np.einsum('ij,ij->j', normalized_weights, submeans)\n+ samples_flat = dist.Normal(mean, np.sqrt(var)).sample(rng, (num_draws,))\n+ cov = var\n+ else:\n+ weights = vmap(lambda x: np.linalg.inv(_cov(x)))(joined_subposteriors)\n+ cov = np.linalg.inv(np.sum(weights, axis=0))\n+ normalized_weights = np.matmul(cov, weights)\n+\n+ # comparing to consensus implementation, we compute weighted mean here\n+ mean = np.einsum('ijk,ik->j', normalized_weights, submeans)\n+ samples_flat = dist.MultivariateNormal(mean, cov).sample(rng, (num_draws,))\n+\n+ _, unravel_fn = ravel_pytree(tree_map(lambda x: x[0], subposteriors[0]))\n+ samples = vmap(lambda x: unravel_fn(x))(samples_flat)\n+ if return_params:\n+ return samples, mean, cov","path":"numpyro/hmc_util.py","position":121,"original_position":121,"commit_id":"f4f06a2f00c034909a207cf71bb5fb3ebbe9a822","original_commit_id":"f4f06a2f00c034909a207cf71bb5fb3ebbe9a822","user":{"login":"martinjankowiak","id":22105218,"node_id":"MDQ6VXNlcjIyMTA1MjE4","avatar_url":"https://avatars1.githubusercontent.com/u/22105218?v=4","gravatar_id":"","url":"https://api.github.com/users/martinjankowiak","html_url":"https://github.com/martinjankowiak","followers_url":"https://api.github.com/users/martinjankowiak/followers","following_url":"https://api.github.com/users/martinjankowiak/following{/other_user}","gists_url":"https://api.github.com/users/martinjankowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjankowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjankowiak/subscriptions","organizations_url":"https://api.github.com/users/martinjankowiak/orgs","repos_url":"https://api.github.com/users/martinjankowiak/repos","events_url":"https://api.github.com/users/martinjankowiak/events{/privacy}","received_events_url":"https://api.github.com/users/martinjankowiak/received_events","type":"User","site_admin":false},"body":"probably better to just return mean and cov by default? (or return a MultivariateNormal)?","created_at":"2019-07-19T20:45:30Z","updated_at":"2019-07-19T20:46:31Z","html_url":"https://github.com/pyro-ppl/numpyro/pull/247#discussion_r305518875","pull_request_url":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/247","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/comments/305518875"},"html":{"href":"https://github.com/pyro-ppl/numpyro/pull/247#discussion_r305518875"},"pull_request":{"href":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/247","id":298292965,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4MjkyOTY1","html_url":"https://github.com/pyro-ppl/numpyro/pull/247","diff_url":"https://github.com/pyro-ppl/numpyro/pull/247.diff","patch_url":"https://github.com/pyro-ppl/numpyro/pull/247.patch","issue_url":"https://api.github.com/repos/pyro-ppl/numpyro/issues/247","number":247,"state":"open","locked":false,"title":"Implement consensus MC and parametric MC algorithms","user":{"login":"fehiepsi","id":4736342,"node_id":"MDQ6VXNlcjQ3MzYzNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/4736342?v=4","gravatar_id":"","url":"https://api.github.com/users/fehiepsi","html_url":"https://github.com/fehiepsi","followers_url":"https://api.github.com/users/fehiepsi/followers","following_url":"https://api.github.com/users/fehiepsi/following{/other_user}","gists_url":"https://api.github.com/users/fehiepsi/gists{/gist_id}","starred_url":"https://api.github.com/users/fehiepsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fehiepsi/subscriptions","organizations_url":"https://api.github.com/users/fehiepsi/orgs","repos_url":"https://api.github.com/users/fehiepsi/repos","events_url":"https://api.github.com/users/fehiepsi/events{/privacy}","received_events_url":"https://api.github.com/users/fehiepsi/received_events","type":"User","site_admin":false},"body":"This PR adds a few simple but fast subposterior algorithms.\r\n\r\nTODO:\r\n- [x] add tests for these algorithms","created_at":"2019-07-17T03:43:21Z","updated_at":"2019-07-19T20:46:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89de9e07c4036d99a190135c15079ca9c267614f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"neerajprad","id":1762463,"node_id":"MDQ6VXNlcjE3NjI0NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1762463?v=4","gravatar_id":"","url":"https://api.github.com/users/neerajprad","html_url":"https://github.com/neerajprad","followers_url":"https://api.github.com/users/neerajprad/followers","following_url":"https://api.github.com/users/neerajprad/following{/other_user}","gists_url":"https://api.github.com/users/neerajprad/gists{/gist_id}","starred_url":"https://api.github.com/users/neerajprad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neerajprad/subscriptions","organizations_url":"https://api.github.com/users/neerajprad/orgs","repos_url":"https://api.github.com/users/neerajprad/repos","events_url":"https://api.github.com/users/neerajprad/events{/privacy}","received_events_url":"https://api.github.com/users/neerajprad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1271800695,"node_id":"MDU6TGFiZWwxMjcxODAwNjk1","url":"https://api.github.com/repos/pyro-ppl/numpyro/labels/awaiting%20review","name":"awaiting review","color":"82d642","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/247/commits","review_comments_url":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/247/comments","review_comment_url":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyro-ppl/numpyro/issues/247/comments","statuses_url":"https://api.github.com/repos/pyro-ppl/numpyro/statuses/f4f06a2f00c034909a207cf71bb5fb3ebbe9a822","head":{"label":"fehiepsi:consensus","ref":"consensus","sha":"f4f06a2f00c034909a207cf71bb5fb3ebbe9a822","user":{"login":"fehiepsi","id":4736342,"node_id":"MDQ6VXNlcjQ3MzYzNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/4736342?v=4","gravatar_id":"","url":"https://api.github.com/users/fehiepsi","html_url":"https://github.com/fehiepsi","followers_url":"https://api.github.com/users/fehiepsi/followers","following_url":"https://api.github.com/users/fehiepsi/following{/other_user}","gists_url":"https://api.github.com/users/fehiepsi/gists{/gist_id}","starred_url":"https://api.github.com/users/fehiepsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fehiepsi/subscriptions","organizations_url":"https://api.github.com/users/fehiepsi/orgs","repos_url":"https://api.github.com/users/fehiepsi/repos","events_url":"https://api.github.com/users/fehiepsi/events{/privacy}","received_events_url":"https://api.github.com/users/fehiepsi/received_events","type":"User","site_admin":false},"repo":{"id":176783350,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY3ODMzNTA=","name":"numpyro","full_name":"fehiepsi/numpyro","private":false,"owner":{"login":"fehiepsi","id":4736342,"node_id":"MDQ6VXNlcjQ3MzYzNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/4736342?v=4","gravatar_id":"","url":"https://api.github.com/users/fehiepsi","html_url":"https://github.com/fehiepsi","followers_url":"https://api.github.com/users/fehiepsi/followers","following_url":"https://api.github.com/users/fehiepsi/following{/other_user}","gists_url":"https://api.github.com/users/fehiepsi/gists{/gist_id}","starred_url":"https://api.github.com/users/fehiepsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fehiepsi/subscriptions","organizations_url":"https://api.github.com/users/fehiepsi/orgs","repos_url":"https://api.github.com/users/fehiepsi/repos","events_url":"https://api.github.com/users/fehiepsi/events{/privacy}","received_events_url":"https://api.github.com/users/fehiepsi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fehiepsi/numpyro","description":"Pyro on Numpy","fork":true,"url":"https://api.github.com/repos/fehiepsi/numpyro","forks_url":"https://api.github.com/repos/fehiepsi/numpyro/forks","keys_url":"https://api.github.com/repos/fehiepsi/numpyro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fehiepsi/numpyro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fehiepsi/numpyro/teams","hooks_url":"https://api.github.com/repos/fehiepsi/numpyro/hooks","issue_events_url":"https://api.github.com/repos/fehiepsi/numpyro/issues/events{/number}","events_url":"https://api.github.com/repos/fehiepsi/numpyro/events","assignees_url":"https://api.github.com/repos/fehiepsi/numpyro/assignees{/user}","branches_url":"https://api.github.com/repos/fehiepsi/numpyro/branches{/branch}","tags_url":"https://api.github.com/repos/fehiepsi/numpyro/tags","blobs_url":"https://api.github.com/repos/fehiepsi/numpyro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fehiepsi/numpyro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fehiepsi/numpyro/git/refs{/sha}","trees_url":"https://api.github.com/repos/fehiepsi/numpyro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fehiepsi/numpyro/statuses/{sha}","languages_url":"https://api.github.com/repos/fehiepsi/numpyro/languages","stargazers_url":"https://api.github.com/repos/fehiepsi/numpyro/stargazers","contributors_url":"https://api.github.com/repos/fehiepsi/numpyro/contributors","subscribers_url":"https://api.github.com/repos/fehiepsi/numpyro/subscribers","subscription_url":"https://api.github.com/repos/fehiepsi/numpyro/subscription","commits_url":"https://api.github.com/repos/fehiepsi/numpyro/commits{/sha}","git_commits_url":"https://api.github.com/repos/fehiepsi/numpyro/git/commits{/sha}","comments_url":"https://api.github.com/repos/fehiepsi/numpyro/comments{/number}","issue_comment_url":"https://api.github.com/repos/fehiepsi/numpyro/issues/comments{/number}","contents_url":"https://api.github.com/repos/fehiepsi/numpyro/contents/{+path}","compare_url":"https://api.github.com/repos/fehiepsi/numpyro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fehiepsi/numpyro/merges","archive_url":"https://api.github.com/repos/fehiepsi/numpyro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fehiepsi/numpyro/downloads","issues_url":"https://api.github.com/repos/fehiepsi/numpyro/issues{/number}","pulls_url":"https://api.github.com/repos/fehiepsi/numpyro/pulls{/number}","milestones_url":"https://api.github.com/repos/fehiepsi/numpyro/milestones{/number}","notifications_url":"https://api.github.com/repos/fehiepsi/numpyro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fehiepsi/numpyro/labels{/name}","releases_url":"https://api.github.com/repos/fehiepsi/numpyro/releases{/id}","deployments_url":"https://api.github.com/repos/fehiepsi/numpyro/deployments","created_at":"2019-03-20T17:23:15Z","updated_at":"2019-03-20T17:27:33Z","pushed_at":"2019-07-19T17:16:37Z","git_url":"git://github.com/fehiepsi/numpyro.git","ssh_url":"[email protected]:fehiepsi/numpyro.git","clone_url":"https://github.com/fehiepsi/numpyro.git","svn_url":"https://github.com/fehiepsi/numpyro","homepage":"","size":15295,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyro-ppl:master","ref":"master","sha":"91e2fae5b03b21007d858d35292c0dfefb4b111d","user":{"login":"pyro-ppl","id":46794900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Nzk0OTAw","avatar_url":"https://avatars3.githubusercontent.com/u/46794900?v=4","gravatar_id":"","url":"https://api.github.com/users/pyro-ppl","html_url":"https://github.com/pyro-ppl","followers_url":"https://api.github.com/users/pyro-ppl/followers","following_url":"https://api.github.com/users/pyro-ppl/following{/other_user}","gists_url":"https://api.github.com/users/pyro-ppl/gists{/gist_id}","starred_url":"https://api.github.com/users/pyro-ppl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyro-ppl/subscriptions","organizations_url":"https://api.github.com/users/pyro-ppl/orgs","repos_url":"https://api.github.com/users/pyro-ppl/repos","events_url":"https://api.github.com/users/pyro-ppl/events{/privacy}","received_events_url":"https://api.github.com/users/pyro-ppl/received_events","type":"Organization","site_admin":false},"repo":{"id":170580540,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA1ODA1NDA=","name":"numpyro","full_name":"pyro-ppl/numpyro","private":false,"owner":{"login":"pyro-ppl","id":46794900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Nzk0OTAw","avatar_url":"https://avatars3.githubusercontent.com/u/46794900?v=4","gravatar_id":"","url":"https://api.github.com/users/pyro-ppl","html_url":"https://github.com/pyro-ppl","followers_url":"https://api.github.com/users/pyro-ppl/followers","following_url":"https://api.github.com/users/pyro-ppl/following{/other_user}","gists_url":"https://api.github.com/users/pyro-ppl/gists{/gist_id}","starred_url":"https://api.github.com/users/pyro-ppl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyro-ppl/subscriptions","organizations_url":"https://api.github.com/users/pyro-ppl/orgs","repos_url":"https://api.github.com/users/pyro-ppl/repos","events_url":"https://api.github.com/users/pyro-ppl/events{/privacy}","received_events_url":"https://api.github.com/users/pyro-ppl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pyro-ppl/numpyro","description":"Probabilistic programming with NumPy powered by JAX for autograd and JIT compilation to GPU/CPU.","fork":false,"url":"https://api.github.com/repos/pyro-ppl/numpyro","forks_url":"https://api.github.com/repos/pyro-ppl/numpyro/forks","keys_url":"https://api.github.com/repos/pyro-ppl/numpyro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyro-ppl/numpyro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyro-ppl/numpyro/teams","hooks_url":"https://api.github.com/repos/pyro-ppl/numpyro/hooks","issue_events_url":"https://api.github.com/repos/pyro-ppl/numpyro/issues/events{/number}","events_url":"https://api.github.com/repos/pyro-ppl/numpyro/events","assignees_url":"https://api.github.com/repos/pyro-ppl/numpyro/assignees{/user}","branches_url":"https://api.github.com/repos/pyro-ppl/numpyro/branches{/branch}","tags_url":"https://api.github.com/repos/pyro-ppl/numpyro/tags","blobs_url":"https://api.github.com/repos/pyro-ppl/numpyro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyro-ppl/numpyro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyro-ppl/numpyro/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyro-ppl/numpyro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyro-ppl/numpyro/statuses/{sha}","languages_url":"https://api.github.com/repos/pyro-ppl/numpyro/languages","stargazers_url":"https://api.github.com/repos/pyro-ppl/numpyro/stargazers","contributors_url":"https://api.github.com/repos/pyro-ppl/numpyro/contributors","subscribers_url":"https://api.github.com/repos/pyro-ppl/numpyro/subscribers","subscription_url":"https://api.github.com/repos/pyro-ppl/numpyro/subscription","commits_url":"https://api.github.com/repos/pyro-ppl/numpyro/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyro-ppl/numpyro/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyro-ppl/numpyro/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyro-ppl/numpyro/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyro-ppl/numpyro/contents/{+path}","compare_url":"https://api.github.com/repos/pyro-ppl/numpyro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyro-ppl/numpyro/merges","archive_url":"https://api.github.com/repos/pyro-ppl/numpyro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyro-ppl/numpyro/downloads","issues_url":"https://api.github.com/repos/pyro-ppl/numpyro/issues{/number}","pulls_url":"https://api.github.com/repos/pyro-ppl/numpyro/pulls{/number}","milestones_url":"https://api.github.com/repos/pyro-ppl/numpyro/milestones{/number}","notifications_url":"https://api.github.com/repos/pyro-ppl/numpyro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyro-ppl/numpyro/labels{/name}","releases_url":"https://api.github.com/repos/pyro-ppl/numpyro/releases{/id}","deployments_url":"https://api.github.com/repos/pyro-ppl/numpyro/deployments","created_at":"2019-02-13T21:13:59Z","updated_at":"2019-07-19T18:11:58Z","pushed_at":"2019-07-19T18:11:56Z","git_url":"git://github.com/pyro-ppl/numpyro.git","ssh_url":"[email protected]:pyro-ppl/numpyro.git","clone_url":"https://github.com/pyro-ppl/numpyro.git","svn_url":"https://github.com/pyro-ppl/numpyro","homepage":"http://pyro.ai/numpyro/","size":16137,"stargazers_count":159,"watchers_count":159,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":23,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/247"},"html":{"href":"https://github.com/pyro-ppl/numpyro/pull/247"},"issue":{"href":"https://api.github.com/repos/pyro-ppl/numpyro/issues/247"},"comments":{"href":"https://api.github.com/repos/pyro-ppl/numpyro/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyro-ppl/numpyro/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/pyro-ppl/numpyro/statuses/f4f06a2f00c034909a207cf71bb5fb3ebbe9a822"}},"author_association":"COLLABORATOR"}}
|
{
"id": 170580540,
"name": "pyro-ppl/numpyro",
"url": "https://api.github.com/repos/pyro-ppl/numpyro"
}
|
{
"id": 22105218,
"login": "martinjankowiak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22105218?",
"url": "https://api.github.com/users/martinjankowiak"
}
|
{
"id": 46794900,
"login": "pyro-ppl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46794900?",
"url": "https://api.github.com/orgs/pyro-ppl"
}
| 2019-07-19T20:45:30 |
10048539587
|
{"actor":{"display_login":"martinjankowiak"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/keptn/keptn/pulls/comments/335815075","pull_request_review_id":303010378,"id":335815075,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTgxNTA3NQ==","diff_hunk":"@@ -61,6 +61,10 @@ var uninstallCmd = &cobra.Command{\n \t\t\t}\n \t\t}\n \t\tlogging.PrintLog(\"Successfully uninstalled keptn\", logging.InfoLevel)\n+\t\tlogging.PrintLog(\"Note: Some namespaces and services have not been uninstalled. Please inspect this yourself using\", logging.InfoLevel)\n+\t\tlogging.PrintLog(\" kubectl get pods --all-namespaces\", logging.InfoLevel)","path":"cli/cmd/uninstall.go","position":5,"original_position":5,"commit_id":"c0cbcb7193ed2f60047ddc0f3f45d594225dc281","original_commit_id":"c0cbcb7193ed2f60047ddc0f3f45d594225dc281","user":{"login":"agrimmer","id":10980861,"node_id":"MDQ6VXNlcjEwOTgwODYx","avatar_url":"https://avatars3.githubusercontent.com/u/10980861?v=4","gravatar_id":"","url":"https://api.github.com/users/agrimmer","html_url":"https://github.com/agrimmer","followers_url":"https://api.github.com/users/agrimmer/followers","following_url":"https://api.github.com/users/agrimmer/following{/other_user}","gists_url":"https://api.github.com/users/agrimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/agrimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrimmer/subscriptions","organizations_url":"https://api.github.com/users/agrimmer/orgs","repos_url":"https://api.github.com/users/agrimmer/repos","events_url":"https://api.github.com/users/agrimmer/events{/privacy}","received_events_url":"https://api.github.com/users/agrimmer/received_events","type":"User","site_admin":false},"body":"Same argument as above.","created_at":"2019-10-17T05:31:17Z","updated_at":"2019-10-17T05:31:17Z","html_url":"https://github.com/keptn/keptn/pull/972#discussion_r335815075","pull_request_url":"https://api.github.com/repos/keptn/keptn/pulls/972","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/keptn/keptn/pulls/comments/335815075"},"html":{"href":"https://github.com/keptn/keptn/pull/972#discussion_r335815075"},"pull_request":{"href":"https://api.github.com/repos/keptn/keptn/pulls/972"}},"in_reply_to_id":335399312},"pull_request":{"url":"https://api.github.com/repos/keptn/keptn/pulls/972","id":328263540,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4MjYzNTQw","html_url":"https://github.com/keptn/keptn/pull/972","diff_url":"https://github.com/keptn/keptn/pull/972.diff","patch_url":"https://github.com/keptn/keptn/pull/972.patch","issue_url":"https://api.github.com/repos/keptn/keptn/issues/972","number":972,"state":"open","locked":false,"title":"#971 keptn uninstall should provide a hint about services/namespaces โฆ","user":{"login":"christian-kreuzberger-dtx","id":56065213,"node_id":"MDQ6VXNlcjU2MDY1MjEz","avatar_url":"https://avatars1.githubusercontent.com/u/56065213?v=4","gravatar_id":"","url":"https://api.github.com/users/christian-kreuzberger-dtx","html_url":"https://github.com/christian-kreuzberger-dtx","followers_url":"https://api.github.com/users/christian-kreuzberger-dtx/followers","following_url":"https://api.github.com/users/christian-kreuzberger-dtx/following{/other_user}","gists_url":"https://api.github.com/users/christian-kreuzberger-dtx/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-kreuzberger-dtx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-kreuzberger-dtx/subscriptions","organizations_url":"https://api.github.com/users/christian-kreuzberger-dtx/orgs","repos_url":"https://api.github.com/users/christian-kreuzberger-dtx/repos","events_url":"https://api.github.com/users/christian-kreuzberger-dtx/events{/privacy}","received_events_url":"https://api.github.com/users/christian-kreuzberger-dtx/received_events","type":"User","site_admin":false},"body":"This is a potential fix for #971 \r\n\r\nFeel free to discuss the two proposed solutions in issue #971.","created_at":"2019-10-15T13:13:42Z","updated_at":"2019-10-17T05:31:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cf37b771c8bd9cc54028dd4fc8292811617a6cb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AloisReitbauer","id":478193,"node_id":"MDQ6VXNlcjQ3ODE5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/478193?v=4","gravatar_id":"","url":"https://api.github.com/users/AloisReitbauer","html_url":"https://github.com/AloisReitbauer","followers_url":"https://api.github.com/users/AloisReitbauer/followers","following_url":"https://api.github.com/users/AloisReitbauer/following{/other_user}","gists_url":"https://api.github.com/users/AloisReitbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/AloisReitbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AloisReitbauer/subscriptions","organizations_url":"https://api.github.com/users/AloisReitbauer/orgs","repos_url":"https://api.github.com/users/AloisReitbauer/repos","events_url":"https://api.github.com/users/AloisReitbauer/events{/privacy}","received_events_url":"https://api.github.com/users/AloisReitbauer/received_events","type":"User","site_admin":false},{"login":"danielkhan","id":2722161,"node_id":"MDQ6VXNlcjI3MjIxNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2722161?v=4","gravatar_id":"","url":"https://api.github.com/users/danielkhan","html_url":"https://github.com/danielkhan","followers_url":"https://api.github.com/users/danielkhan/followers","following_url":"https://api.github.com/users/danielkhan/following{/other_user}","gists_url":"https://api.github.com/users/danielkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielkhan/subscriptions","organizations_url":"https://api.github.com/users/danielkhan/orgs","repos_url":"https://api.github.com/users/danielkhan/repos","events_url":"https://api.github.com/users/danielkhan/events{/privacy}","received_events_url":"https://api.github.com/users/danielkhan/received_events","type":"User","site_admin":false},{"login":"dirkwall","id":15996364,"node_id":"MDQ6VXNlcjE1OTk2MzY0","avatar_url":"https://avatars3.githubusercontent.com/u/15996364?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkwall","html_url":"https://github.com/dirkwall","followers_url":"https://api.github.com/users/dirkwall/followers","following_url":"https://api.github.com/users/dirkwall/following{/other_user}","gists_url":"https://api.github.com/users/dirkwall/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkwall/subscriptions","organizations_url":"https://api.github.com/users/dirkwall/orgs","repos_url":"https://api.github.com/users/dirkwall/repos","events_url":"https://api.github.com/users/dirkwall/events{/privacy}","received_events_url":"https://api.github.com/users/dirkwall/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keptn/keptn/pulls/972/commits","review_comments_url":"https://api.github.com/repos/keptn/keptn/pulls/972/comments","review_comment_url":"https://api.github.com/repos/keptn/keptn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keptn/keptn/issues/972/comments","statuses_url":"https://api.github.com/repos/keptn/keptn/statuses/c0cbcb7193ed2f60047ddc0f3f45d594225dc281","head":{"label":"keptn:bug/971/install_uninstall","ref":"bug/971/install_uninstall","sha":"c0cbcb7193ed2f60047ddc0f3f45d594225dc281","user":{"login":"keptn","id":46796476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Nzk2NDc2","avatar_url":"https://avatars2.githubusercontent.com/u/46796476?v=4","gravatar_id":"","url":"https://api.github.com/users/keptn","html_url":"https://github.com/keptn","followers_url":"https://api.github.com/users/keptn/followers","following_url":"https://api.github.com/users/keptn/following{/other_user}","gists_url":"https://api.github.com/users/keptn/gists{/gist_id}","starred_url":"https://api.github.com/users/keptn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keptn/subscriptions","organizations_url":"https://api.github.com/users/keptn/orgs","repos_url":"https://api.github.com/users/keptn/repos","events_url":"https://api.github.com/users/keptn/events{/privacy}","received_events_url":"https://api.github.com/users/keptn/received_events","type":"Organization","site_admin":false},"repo":{"id":166831098,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY4MzEwOTg=","name":"keptn","full_name":"keptn/keptn","private":false,"owner":{"login":"keptn","id":46796476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Nzk2NDc2","avatar_url":"https://avatars2.githubusercontent.com/u/46796476?v=4","gravatar_id":"","url":"https://api.github.com/users/keptn","html_url":"https://github.com/keptn","followers_url":"https://api.github.com/users/keptn/followers","following_url":"https://api.github.com/users/keptn/following{/other_user}","gists_url":"https://api.github.com/users/keptn/gists{/gist_id}","starred_url":"https://api.github.com/users/keptn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keptn/subscriptions","organizations_url":"https://api.github.com/users/keptn/orgs","repos_url":"https://api.github.com/users/keptn/repos","events_url":"https://api.github.com/users/keptn/events{/privacy}","received_events_url":"https://api.github.com/users/keptn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keptn/keptn","description":"Keptn is a control-plane for continuous delivery and operations enable cloud-native applications to run autonomously","fork":false,"url":"https://api.github.com/repos/keptn/keptn","forks_url":"https://api.github.com/repos/keptn/keptn/forks","keys_url":"https://api.github.com/repos/keptn/keptn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keptn/keptn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keptn/keptn/teams","hooks_url":"https://api.github.com/repos/keptn/keptn/hooks","issue_events_url":"https://api.github.com/repos/keptn/keptn/issues/events{/number}","events_url":"https://api.github.com/repos/keptn/keptn/events","assignees_url":"https://api.github.com/repos/keptn/keptn/assignees{/user}","branches_url":"https://api.github.com/repos/keptn/keptn/branches{/branch}","tags_url":"https://api.github.com/repos/keptn/keptn/tags","blobs_url":"https://api.github.com/repos/keptn/keptn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keptn/keptn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keptn/keptn/git/refs{/sha}","trees_url":"https://api.github.com/repos/keptn/keptn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keptn/keptn/statuses/{sha}","languages_url":"https://api.github.com/repos/keptn/keptn/languages","stargazers_url":"https://api.github.com/repos/keptn/keptn/stargazers","contributors_url":"https://api.github.com/repos/keptn/keptn/contributors","subscribers_url":"https://api.github.com/repos/keptn/keptn/subscribers","subscription_url":"https://api.github.com/repos/keptn/keptn/subscription","commits_url":"https://api.github.com/repos/keptn/keptn/commits{/sha}","git_commits_url":"https://api.github.com/repos/keptn/keptn/git/commits{/sha}","comments_url":"https://api.github.com/repos/keptn/keptn/comments{/number}","issue_comment_url":"https://api.github.com/repos/keptn/keptn/issues/comments{/number}","contents_url":"https://api.github.com/repos/keptn/keptn/contents/{+path}","compare_url":"https://api.github.com/repos/keptn/keptn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keptn/keptn/merges","archive_url":"https://api.github.com/repos/keptn/keptn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keptn/keptn/downloads","issues_url":"https://api.github.com/repos/keptn/keptn/issues{/number}","pulls_url":"https://api.github.com/repos/keptn/keptn/pulls{/number}","milestones_url":"https://api.github.com/repos/keptn/keptn/milestones{/number}","notifications_url":"https://api.github.com/repos/keptn/keptn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keptn/keptn/labels{/name}","releases_url":"https://api.github.com/repos/keptn/keptn/releases{/id}","deployments_url":"https://api.github.com/repos/keptn/keptn/deployments","created_at":"2019-01-21T14:51:48Z","updated_at":"2019-10-16T20:22:57Z","pushed_at":"2019-10-17T05:25:11Z","git_url":"git://github.com/keptn/keptn.git","ssh_url":"[email protected]:keptn/keptn.git","clone_url":"https://github.com/keptn/keptn.git","svn_url":"https://github.com/keptn/keptn","homepage":"https://keptn.sh","size":97223,"stargazers_count":147,"watchers_count":147,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":88,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":88,"watchers":147,"default_branch":"master"}},"base":{"label":"keptn:develop","ref":"develop","sha":"51bda7b46296802aad1808491dcb5d309adab8d4","user":{"login":"keptn","id":46796476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Nzk2NDc2","avatar_url":"https://avatars2.githubusercontent.com/u/46796476?v=4","gravatar_id":"","url":"https://api.github.com/users/keptn","html_url":"https://github.com/keptn","followers_url":"https://api.github.com/users/keptn/followers","following_url":"https://api.github.com/users/keptn/following{/other_user}","gists_url":"https://api.github.com/users/keptn/gists{/gist_id}","starred_url":"https://api.github.com/users/keptn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keptn/subscriptions","organizations_url":"https://api.github.com/users/keptn/orgs","repos_url":"https://api.github.com/users/keptn/repos","events_url":"https://api.github.com/users/keptn/events{/privacy}","received_events_url":"https://api.github.com/users/keptn/received_events","type":"Organization","site_admin":false},"repo":{"id":166831098,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY4MzEwOTg=","name":"keptn","full_name":"keptn/keptn","private":false,"owner":{"login":"keptn","id":46796476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2Nzk2NDc2","avatar_url":"https://avatars2.githubusercontent.com/u/46796476?v=4","gravatar_id":"","url":"https://api.github.com/users/keptn","html_url":"https://github.com/keptn","followers_url":"https://api.github.com/users/keptn/followers","following_url":"https://api.github.com/users/keptn/following{/other_user}","gists_url":"https://api.github.com/users/keptn/gists{/gist_id}","starred_url":"https://api.github.com/users/keptn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keptn/subscriptions","organizations_url":"https://api.github.com/users/keptn/orgs","repos_url":"https://api.github.com/users/keptn/repos","events_url":"https://api.github.com/users/keptn/events{/privacy}","received_events_url":"https://api.github.com/users/keptn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keptn/keptn","description":"Keptn is a control-plane for continuous delivery and operations enable cloud-native applications to run autonomously","fork":false,"url":"https://api.github.com/repos/keptn/keptn","forks_url":"https://api.github.com/repos/keptn/keptn/forks","keys_url":"https://api.github.com/repos/keptn/keptn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keptn/keptn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keptn/keptn/teams","hooks_url":"https://api.github.com/repos/keptn/keptn/hooks","issue_events_url":"https://api.github.com/repos/keptn/keptn/issues/events{/number}","events_url":"https://api.github.com/repos/keptn/keptn/events","assignees_url":"https://api.github.com/repos/keptn/keptn/assignees{/user}","branches_url":"https://api.github.com/repos/keptn/keptn/branches{/branch}","tags_url":"https://api.github.com/repos/keptn/keptn/tags","blobs_url":"https://api.github.com/repos/keptn/keptn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keptn/keptn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keptn/keptn/git/refs{/sha}","trees_url":"https://api.github.com/repos/keptn/keptn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keptn/keptn/statuses/{sha}","languages_url":"https://api.github.com/repos/keptn/keptn/languages","stargazers_url":"https://api.github.com/repos/keptn/keptn/stargazers","contributors_url":"https://api.github.com/repos/keptn/keptn/contributors","subscribers_url":"https://api.github.com/repos/keptn/keptn/subscribers","subscription_url":"https://api.github.com/repos/keptn/keptn/subscription","commits_url":"https://api.github.com/repos/keptn/keptn/commits{/sha}","git_commits_url":"https://api.github.com/repos/keptn/keptn/git/commits{/sha}","comments_url":"https://api.github.com/repos/keptn/keptn/comments{/number}","issue_comment_url":"https://api.github.com/repos/keptn/keptn/issues/comments{/number}","contents_url":"https://api.github.com/repos/keptn/keptn/contents/{+path}","compare_url":"https://api.github.com/repos/keptn/keptn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keptn/keptn/merges","archive_url":"https://api.github.com/repos/keptn/keptn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keptn/keptn/downloads","issues_url":"https://api.github.com/repos/keptn/keptn/issues{/number}","pulls_url":"https://api.github.com/repos/keptn/keptn/pulls{/number}","milestones_url":"https://api.github.com/repos/keptn/keptn/milestones{/number}","notifications_url":"https://api.github.com/repos/keptn/keptn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keptn/keptn/labels{/name}","releases_url":"https://api.github.com/repos/keptn/keptn/releases{/id}","deployments_url":"https://api.github.com/repos/keptn/keptn/deployments","created_at":"2019-01-21T14:51:48Z","updated_at":"2019-10-16T20:22:57Z","pushed_at":"2019-10-17T05:25:11Z","git_url":"git://github.com/keptn/keptn.git","ssh_url":"[email protected]:keptn/keptn.git","clone_url":"https://github.com/keptn/keptn.git","svn_url":"https://github.com/keptn/keptn","homepage":"https://keptn.sh","size":97223,"stargazers_count":147,"watchers_count":147,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":88,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":88,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keptn/keptn/pulls/972"},"html":{"href":"https://github.com/keptn/keptn/pull/972"},"issue":{"href":"https://api.github.com/repos/keptn/keptn/issues/972"},"comments":{"href":"https://api.github.com/repos/keptn/keptn/issues/972/comments"},"review_comments":{"href":"https://api.github.com/repos/keptn/keptn/pulls/972/comments"},"review_comment":{"href":"https://api.github.com/repos/keptn/keptn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keptn/keptn/pulls/972/commits"},"statuses":{"href":"https://api.github.com/repos/keptn/keptn/statuses/c0cbcb7193ed2f60047ddc0f3f45d594225dc281"}},"author_association":"MEMBER"}}
|
{
"id": 166831098,
"name": "keptn/keptn",
"url": "https://api.github.com/repos/keptn/keptn"
}
|
{
"id": 10980861,
"login": "agrimmer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10980861?",
"url": "https://api.github.com/users/agrimmer"
}
|
{
"id": 46796476,
"login": "keptn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46796476?",
"url": "https://api.github.com/orgs/keptn"
}
| 2019-10-17T05:31:17 |
10649395193
|
{"actor":{"display_login":"agrimmer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/osstotalsoft/nbb/pulls/comments/300674733","pull_request_review_id":258393593,"id":300674733,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDY3NDczMw==","diff_hunk":"@@ -1,10 +1,9 @@\n ๏ปฟusing MediatR;\r\n using NBB.Core.Abstractions;\r\n-using System;\r\n \r\n namespace NBB.Application.DataContracts\r\n {\r\n- public abstract class Command : ICommand, IMetadataProvider<CommandMetadata>\r\n+ public abstract class Command : ICommand, IRequest, IMetadataProvider<CommandMetadata>\r\n {\r\n public CommandMetadata Metadata { get; }\r","path":"src/Application/NBB.Application.DataContracts/Command.cs","position":10,"original_position":10,"commit_id":"9770f824b05566640fae5e8aad1a5b245c9344b7","original_commit_id":"9770f824b05566640fae5e8aad1a5b245c9344b7","user":{"login":"oncicaradupopovici","id":4567203,"node_id":"MDQ6VXNlcjQ1NjcyMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4567203?v=4","gravatar_id":"","url":"https://api.github.com/users/oncicaradupopovici","html_url":"https://github.com/oncicaradupopovici","followers_url":"https://api.github.com/users/oncicaradupopovici/followers","following_url":"https://api.github.com/users/oncicaradupopovici/following{/other_user}","gists_url":"https://api.github.com/users/oncicaradupopovici/gists{/gist_id}","starred_url":"https://api.github.com/users/oncicaradupopovici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oncicaradupopovici/subscriptions","organizations_url":"https://api.github.com/users/oncicaradupopovici/orgs","repos_url":"https://api.github.com/users/oncicaradupopovici/repos","events_url":"https://api.github.com/users/oncicaradupopovici/events{/privacy}","received_events_url":"https://api.github.com/users/oncicaradupopovici/received_events","type":"User","site_admin":false},"body":"Generic command should not derive from Command. It should implement ICommand instead.\r\nAlso should not implement IRequest, but IRequest<TResponse>","created_at":"2019-07-05T13:03:53Z","updated_at":"2019-07-05T13:06:59Z","html_url":"https://github.com/osstotalsoft/nbb/pull/14#discussion_r300674733","pull_request_url":"https://api.github.com/repos/osstotalsoft/nbb/pulls/14","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/osstotalsoft/nbb/pulls/comments/300674733"},"html":{"href":"https://github.com/osstotalsoft/nbb/pull/14#discussion_r300674733"},"pull_request":{"href":"https://api.github.com/repos/osstotalsoft/nbb/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/osstotalsoft/nbb/pulls/14","id":294622549,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0NjIyNTQ5","html_url":"https://github.com/osstotalsoft/nbb/pull/14","diff_url":"https://github.com/osstotalsoft/nbb/pull/14.diff","patch_url":"https://github.com/osstotalsoft/nbb/pull/14.patch","issue_url":"https://api.github.com/repos/osstotalsoft/nbb/issues/14","number":14,"state":"open","locked":false,"title":"Removed MediatR reference from NBB.Core.Abstrations","user":{"login":"fraliv13","id":5892139,"node_id":"MDQ6VXNlcjU4OTIxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5892139?v=4","gravatar_id":"","url":"https://api.github.com/users/fraliv13","html_url":"https://github.com/fraliv13","followers_url":"https://api.github.com/users/fraliv13/followers","following_url":"https://api.github.com/users/fraliv13/following{/other_user}","gists_url":"https://api.github.com/users/fraliv13/gists{/gist_id}","starred_url":"https://api.github.com/users/fraliv13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraliv13/subscriptions","organizations_url":"https://api.github.com/users/fraliv13/orgs","repos_url":"https://api.github.com/users/fraliv13/repos","events_url":"https://api.github.com/users/fraliv13/events{/privacy}","received_events_url":"https://api.github.com/users/fraliv13/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-04T15:16:48Z","updated_at":"2019-07-05T13:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f97afd31edb9e19fa1a9b8f577219d0af722b4b","assignee":{"login":"oncicaradupopovici","id":4567203,"node_id":"MDQ6VXNlcjQ1NjcyMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4567203?v=4","gravatar_id":"","url":"https://api.github.com/users/oncicaradupopovici","html_url":"https://github.com/oncicaradupopovici","followers_url":"https://api.github.com/users/oncicaradupopovici/followers","following_url":"https://api.github.com/users/oncicaradupopovici/following{/other_user}","gists_url":"https://api.github.com/users/oncicaradupopovici/gists{/gist_id}","starred_url":"https://api.github.com/users/oncicaradupopovici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oncicaradupopovici/subscriptions","organizations_url":"https://api.github.com/users/oncicaradupopovici/orgs","repos_url":"https://api.github.com/users/oncicaradupopovici/repos","events_url":"https://api.github.com/users/oncicaradupopovici/events{/privacy}","received_events_url":"https://api.github.com/users/oncicaradupopovici/received_events","type":"User","site_admin":false},"assignees":[{"login":"oncicaradupopovici","id":4567203,"node_id":"MDQ6VXNlcjQ1NjcyMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4567203?v=4","gravatar_id":"","url":"https://api.github.com/users/oncicaradupopovici","html_url":"https://github.com/oncicaradupopovici","followers_url":"https://api.github.com/users/oncicaradupopovici/followers","following_url":"https://api.github.com/users/oncicaradupopovici/following{/other_user}","gists_url":"https://api.github.com/users/oncicaradupopovici/gists{/gist_id}","starred_url":"https://api.github.com/users/oncicaradupopovici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oncicaradupopovici/subscriptions","organizations_url":"https://api.github.com/users/oncicaradupopovici/orgs","repos_url":"https://api.github.com/users/oncicaradupopovici/repos","events_url":"https://api.github.com/users/oncicaradupopovici/events{/privacy}","received_events_url":"https://api.github.com/users/oncicaradupopovici/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1324842516,"node_id":"MDU6TGFiZWwxMzI0ODQyNTE2","url":"https://api.github.com/repos/osstotalsoft/nbb/labels/chore","name":"chore","color":"bdf9a9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/osstotalsoft/nbb/pulls/14/commits","review_comments_url":"https://api.github.com/repos/osstotalsoft/nbb/pulls/14/comments","review_comment_url":"https://api.github.com/repos/osstotalsoft/nbb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osstotalsoft/nbb/issues/14/comments","statuses_url":"https://api.github.com/repos/osstotalsoft/nbb/statuses/9770f824b05566640fae5e8aad1a5b245c9344b7","head":{"label":"osstotalsoft:feature/remove-mediatr-from-abstractions","ref":"feature/remove-mediatr-from-abstractions","sha":"9770f824b05566640fae5e8aad1a5b245c9344b7","user":{"login":"osstotalsoft","id":46810110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODEwMTEw","avatar_url":"https://avatars2.githubusercontent.com/u/46810110?v=4","gravatar_id":"","url":"https://api.github.com/users/osstotalsoft","html_url":"https://github.com/osstotalsoft","followers_url":"https://api.github.com/users/osstotalsoft/followers","following_url":"https://api.github.com/users/osstotalsoft/following{/other_user}","gists_url":"https://api.github.com/users/osstotalsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/osstotalsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osstotalsoft/subscriptions","organizations_url":"https://api.github.com/users/osstotalsoft/orgs","repos_url":"https://api.github.com/users/osstotalsoft/repos","events_url":"https://api.github.com/users/osstotalsoft/events{/privacy}","received_events_url":"https://api.github.com/users/osstotalsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":166371135,"node_id":"MDEwOlJlcG9zaXRvcnkxNjYzNzExMzU=","name":"nbb","full_name":"osstotalsoft/nbb","private":false,"owner":{"login":"osstotalsoft","id":46810110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODEwMTEw","avatar_url":"https://avatars2.githubusercontent.com/u/46810110?v=4","gravatar_id":"","url":"https://api.github.com/users/osstotalsoft","html_url":"https://github.com/osstotalsoft","followers_url":"https://api.github.com/users/osstotalsoft/followers","following_url":"https://api.github.com/users/osstotalsoft/following{/other_user}","gists_url":"https://api.github.com/users/osstotalsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/osstotalsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osstotalsoft/subscriptions","organizations_url":"https://api.github.com/users/osstotalsoft/orgs","repos_url":"https://api.github.com/users/osstotalsoft/repos","events_url":"https://api.github.com/users/osstotalsoft/events{/privacy}","received_events_url":"https://api.github.com/users/osstotalsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/osstotalsoft/nbb","description":".Net Building Blocks","fork":false,"url":"https://api.github.com/repos/osstotalsoft/nbb","forks_url":"https://api.github.com/repos/osstotalsoft/nbb/forks","keys_url":"https://api.github.com/repos/osstotalsoft/nbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osstotalsoft/nbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osstotalsoft/nbb/teams","hooks_url":"https://api.github.com/repos/osstotalsoft/nbb/hooks","issue_events_url":"https://api.github.com/repos/osstotalsoft/nbb/issues/events{/number}","events_url":"https://api.github.com/repos/osstotalsoft/nbb/events","assignees_url":"https://api.github.com/repos/osstotalsoft/nbb/assignees{/user}","branches_url":"https://api.github.com/repos/osstotalsoft/nbb/branches{/branch}","tags_url":"https://api.github.com/repos/osstotalsoft/nbb/tags","blobs_url":"https://api.github.com/repos/osstotalsoft/nbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osstotalsoft/nbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osstotalsoft/nbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/osstotalsoft/nbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osstotalsoft/nbb/statuses/{sha}","languages_url":"https://api.github.com/repos/osstotalsoft/nbb/languages","stargazers_url":"https://api.github.com/repos/osstotalsoft/nbb/stargazers","contributors_url":"https://api.github.com/repos/osstotalsoft/nbb/contributors","subscribers_url":"https://api.github.com/repos/osstotalsoft/nbb/subscribers","subscription_url":"https://api.github.com/repos/osstotalsoft/nbb/subscription","commits_url":"https://api.github.com/repos/osstotalsoft/nbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/osstotalsoft/nbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/osstotalsoft/nbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/osstotalsoft/nbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/osstotalsoft/nbb/contents/{+path}","compare_url":"https://api.github.com/repos/osstotalsoft/nbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osstotalsoft/nbb/merges","archive_url":"https://api.github.com/repos/osstotalsoft/nbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osstotalsoft/nbb/downloads","issues_url":"https://api.github.com/repos/osstotalsoft/nbb/issues{/number}","pulls_url":"https://api.github.com/repos/osstotalsoft/nbb/pulls{/number}","milestones_url":"https://api.github.com/repos/osstotalsoft/nbb/milestones{/number}","notifications_url":"https://api.github.com/repos/osstotalsoft/nbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osstotalsoft/nbb/labels{/name}","releases_url":"https://api.github.com/repos/osstotalsoft/nbb/releases{/id}","deployments_url":"https://api.github.com/repos/osstotalsoft/nbb/deployments","created_at":"2019-01-18T08:30:22Z","updated_at":"2019-06-28T13:10:36Z","pushed_at":"2019-07-04T15:16:48Z","git_url":"git://github.com/osstotalsoft/nbb.git","ssh_url":"[email protected]:osstotalsoft/nbb.git","clone_url":"https://github.com/osstotalsoft/nbb.git","svn_url":"https://github.com/osstotalsoft/nbb","homepage":null,"size":5526,"stargazers_count":11,"watchers_count":11,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":11,"default_branch":"master"}},"base":{"label":"osstotalsoft:master","ref":"master","sha":"ac2ddc9044bd1ea98f99c9834c8fbe54ac9aae49","user":{"login":"osstotalsoft","id":46810110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODEwMTEw","avatar_url":"https://avatars2.githubusercontent.com/u/46810110?v=4","gravatar_id":"","url":"https://api.github.com/users/osstotalsoft","html_url":"https://github.com/osstotalsoft","followers_url":"https://api.github.com/users/osstotalsoft/followers","following_url":"https://api.github.com/users/osstotalsoft/following{/other_user}","gists_url":"https://api.github.com/users/osstotalsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/osstotalsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osstotalsoft/subscriptions","organizations_url":"https://api.github.com/users/osstotalsoft/orgs","repos_url":"https://api.github.com/users/osstotalsoft/repos","events_url":"https://api.github.com/users/osstotalsoft/events{/privacy}","received_events_url":"https://api.github.com/users/osstotalsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":166371135,"node_id":"MDEwOlJlcG9zaXRvcnkxNjYzNzExMzU=","name":"nbb","full_name":"osstotalsoft/nbb","private":false,"owner":{"login":"osstotalsoft","id":46810110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODEwMTEw","avatar_url":"https://avatars2.githubusercontent.com/u/46810110?v=4","gravatar_id":"","url":"https://api.github.com/users/osstotalsoft","html_url":"https://github.com/osstotalsoft","followers_url":"https://api.github.com/users/osstotalsoft/followers","following_url":"https://api.github.com/users/osstotalsoft/following{/other_user}","gists_url":"https://api.github.com/users/osstotalsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/osstotalsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osstotalsoft/subscriptions","organizations_url":"https://api.github.com/users/osstotalsoft/orgs","repos_url":"https://api.github.com/users/osstotalsoft/repos","events_url":"https://api.github.com/users/osstotalsoft/events{/privacy}","received_events_url":"https://api.github.com/users/osstotalsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/osstotalsoft/nbb","description":".Net Building Blocks","fork":false,"url":"https://api.github.com/repos/osstotalsoft/nbb","forks_url":"https://api.github.com/repos/osstotalsoft/nbb/forks","keys_url":"https://api.github.com/repos/osstotalsoft/nbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osstotalsoft/nbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osstotalsoft/nbb/teams","hooks_url":"https://api.github.com/repos/osstotalsoft/nbb/hooks","issue_events_url":"https://api.github.com/repos/osstotalsoft/nbb/issues/events{/number}","events_url":"https://api.github.com/repos/osstotalsoft/nbb/events","assignees_url":"https://api.github.com/repos/osstotalsoft/nbb/assignees{/user}","branches_url":"https://api.github.com/repos/osstotalsoft/nbb/branches{/branch}","tags_url":"https://api.github.com/repos/osstotalsoft/nbb/tags","blobs_url":"https://api.github.com/repos/osstotalsoft/nbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osstotalsoft/nbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osstotalsoft/nbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/osstotalsoft/nbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osstotalsoft/nbb/statuses/{sha}","languages_url":"https://api.github.com/repos/osstotalsoft/nbb/languages","stargazers_url":"https://api.github.com/repos/osstotalsoft/nbb/stargazers","contributors_url":"https://api.github.com/repos/osstotalsoft/nbb/contributors","subscribers_url":"https://api.github.com/repos/osstotalsoft/nbb/subscribers","subscription_url":"https://api.github.com/repos/osstotalsoft/nbb/subscription","commits_url":"https://api.github.com/repos/osstotalsoft/nbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/osstotalsoft/nbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/osstotalsoft/nbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/osstotalsoft/nbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/osstotalsoft/nbb/contents/{+path}","compare_url":"https://api.github.com/repos/osstotalsoft/nbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osstotalsoft/nbb/merges","archive_url":"https://api.github.com/repos/osstotalsoft/nbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osstotalsoft/nbb/downloads","issues_url":"https://api.github.com/repos/osstotalsoft/nbb/issues{/number}","pulls_url":"https://api.github.com/repos/osstotalsoft/nbb/pulls{/number}","milestones_url":"https://api.github.com/repos/osstotalsoft/nbb/milestones{/number}","notifications_url":"https://api.github.com/repos/osstotalsoft/nbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osstotalsoft/nbb/labels{/name}","releases_url":"https://api.github.com/repos/osstotalsoft/nbb/releases{/id}","deployments_url":"https://api.github.com/repos/osstotalsoft/nbb/deployments","created_at":"2019-01-18T08:30:22Z","updated_at":"2019-06-28T13:10:36Z","pushed_at":"2019-07-04T15:16:48Z","git_url":"git://github.com/osstotalsoft/nbb.git","ssh_url":"[email protected]:osstotalsoft/nbb.git","clone_url":"https://github.com/osstotalsoft/nbb.git","svn_url":"https://github.com/osstotalsoft/nbb","homepage":null,"size":5526,"stargazers_count":11,"watchers_count":11,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osstotalsoft/nbb/pulls/14"},"html":{"href":"https://github.com/osstotalsoft/nbb/pull/14"},"issue":{"href":"https://api.github.com/repos/osstotalsoft/nbb/issues/14"},"comments":{"href":"https://api.github.com/repos/osstotalsoft/nbb/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/osstotalsoft/nbb/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/osstotalsoft/nbb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osstotalsoft/nbb/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/osstotalsoft/nbb/statuses/9770f824b05566640fae5e8aad1a5b245c9344b7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 166371135,
"name": "osstotalsoft/nbb",
"url": "https://api.github.com/repos/osstotalsoft/nbb"
}
|
{
"id": 4567203,
"login": "oncicaradupopovici",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4567203?",
"url": "https://api.github.com/users/oncicaradupopovici"
}
|
{
"id": 46810110,
"login": "osstotalsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46810110?",
"url": "https://api.github.com/orgs/osstotalsoft"
}
| 2019-07-05T13:03:53 |
9956128126
|
{"actor":{"display_login":"oncicaradupopovici"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/slack-agent/slack-agent/pulls/comments/259336784","pull_request_review_id":206811796,"id":259336784,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTMzNjc4NA==","diff_hunk":"@@ -2,7 +2,7 @@\n /* global describe it beforeEach afterEach */\n const { expect } = require('chai');\n const moxios = require('moxios');\n-const auth = require('../security/authorization.js');\n+const {oAuthRedirectUrl, authorize, isVerified} = require('../security/authorization.js');","path":"test/authorization.js","position":5,"original_position":5,"commit_id":"706f129f486196f6cbb5dc1e0e4a45404e6d31af","original_commit_id":"706f129f486196f6cbb5dc1e0e4a45404e6d31af","user":{"login":"mgolawski","id":9100242,"node_id":"MDQ6VXNlcjkxMDAyNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/9100242?v=4","gravatar_id":"","url":"https://api.github.com/users/mgolawski","html_url":"https://github.com/mgolawski","followers_url":"https://api.github.com/users/mgolawski/followers","following_url":"https://api.github.com/users/mgolawski/following{/other_user}","gists_url":"https://api.github.com/users/mgolawski/gists{/gist_id}","starred_url":"https://api.github.com/users/mgolawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgolawski/subscriptions","organizations_url":"https://api.github.com/users/mgolawski/orgs","repos_url":"https://api.github.com/users/mgolawski/repos","events_url":"https://api.github.com/users/mgolawski/events{/privacy}","received_events_url":"https://api.github.com/users/mgolawski/received_events","type":"User","site_admin":false},"body":"missing whitespaces between brackets.","created_at":"2019-02-22T13:17:00Z","updated_at":"2019-02-22T13:18:03Z","html_url":"https://github.com/slack-agent/slack-agent/pull/25#discussion_r259336784","pull_request_url":"https://api.github.com/repos/slack-agent/slack-agent/pulls/25","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/slack-agent/slack-agent/pulls/comments/259336784"},"html":{"href":"https://github.com/slack-agent/slack-agent/pull/25#discussion_r259336784"},"pull_request":{"href":"https://api.github.com/repos/slack-agent/slack-agent/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/slack-agent/slack-agent/pulls/25","id":255382309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1MzgyMzA5","html_url":"https://github.com/slack-agent/slack-agent/pull/25","diff_url":"https://github.com/slack-agent/slack-agent/pull/25.diff","patch_url":"https://github.com/slack-agent/slack-agent/pull/25.patch","issue_url":"https://api.github.com/repos/slack-agent/slack-agent/issues/25","number":25,"state":"open","locked":false,"title":"refactor authorization and add tests","user":{"login":"mheinwipro","id":45594475,"node_id":"MDQ6VXNlcjQ1NTk0NDc1","avatar_url":"https://avatars3.githubusercontent.com/u/45594475?v=4","gravatar_id":"","url":"https://api.github.com/users/mheinwipro","html_url":"https://github.com/mheinwipro","followers_url":"https://api.github.com/users/mheinwipro/followers","following_url":"https://api.github.com/users/mheinwipro/following{/other_user}","gists_url":"https://api.github.com/users/mheinwipro/gists{/gist_id}","starred_url":"https://api.github.com/users/mheinwipro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheinwipro/subscriptions","organizations_url":"https://api.github.com/users/mheinwipro/orgs","repos_url":"https://api.github.com/users/mheinwipro/repos","events_url":"https://api.github.com/users/mheinwipro/events{/privacy}","received_events_url":"https://api.github.com/users/mheinwipro/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-22T12:43:43Z","updated_at":"2019-02-22T13:18:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcae1edf58b90f435f9f4c526e87c96e4761d478","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/slack-agent/slack-agent/pulls/25/commits","review_comments_url":"https://api.github.com/repos/slack-agent/slack-agent/pulls/25/comments","review_comment_url":"https://api.github.com/repos/slack-agent/slack-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slack-agent/slack-agent/issues/25/comments","statuses_url":"https://api.github.com/repos/slack-agent/slack-agent/statuses/706f129f486196f6cbb5dc1e0e4a45404e6d31af","head":{"label":"slack-agent:refactor-authorization","ref":"refactor-authorization","sha":"706f129f486196f6cbb5dc1e0e4a45404e6d31af","user":{"login":"slack-agent","id":46817016,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODE3MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/46817016?v=4","gravatar_id":"","url":"https://api.github.com/users/slack-agent","html_url":"https://github.com/slack-agent","followers_url":"https://api.github.com/users/slack-agent/followers","following_url":"https://api.github.com/users/slack-agent/following{/other_user}","gists_url":"https://api.github.com/users/slack-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/slack-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slack-agent/subscriptions","organizations_url":"https://api.github.com/users/slack-agent/orgs","repos_url":"https://api.github.com/users/slack-agent/repos","events_url":"https://api.github.com/users/slack-agent/events{/privacy}","received_events_url":"https://api.github.com/users/slack-agent/received_events","type":"Organization","site_admin":false},"repo":{"id":166820569,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY4MjA1Njk=","name":"slack-agent","full_name":"slack-agent/slack-agent","private":false,"owner":{"login":"slack-agent","id":46817016,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODE3MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/46817016?v=4","gravatar_id":"","url":"https://api.github.com/users/slack-agent","html_url":"https://github.com/slack-agent","followers_url":"https://api.github.com/users/slack-agent/followers","following_url":"https://api.github.com/users/slack-agent/following{/other_user}","gists_url":"https://api.github.com/users/slack-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/slack-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slack-agent/subscriptions","organizations_url":"https://api.github.com/users/slack-agent/orgs","repos_url":"https://api.github.com/users/slack-agent/repos","events_url":"https://api.github.com/users/slack-agent/events{/privacy}","received_events_url":"https://api.github.com/users/slack-agent/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/slack-agent/slack-agent","description":null,"fork":false,"url":"https://api.github.com/repos/slack-agent/slack-agent","forks_url":"https://api.github.com/repos/slack-agent/slack-agent/forks","keys_url":"https://api.github.com/repos/slack-agent/slack-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slack-agent/slack-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slack-agent/slack-agent/teams","hooks_url":"https://api.github.com/repos/slack-agent/slack-agent/hooks","issue_events_url":"https://api.github.com/repos/slack-agent/slack-agent/issues/events{/number}","events_url":"https://api.github.com/repos/slack-agent/slack-agent/events","assignees_url":"https://api.github.com/repos/slack-agent/slack-agent/assignees{/user}","branches_url":"https://api.github.com/repos/slack-agent/slack-agent/branches{/branch}","tags_url":"https://api.github.com/repos/slack-agent/slack-agent/tags","blobs_url":"https://api.github.com/repos/slack-agent/slack-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slack-agent/slack-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slack-agent/slack-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/slack-agent/slack-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slack-agent/slack-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/slack-agent/slack-agent/languages","stargazers_url":"https://api.github.com/repos/slack-agent/slack-agent/stargazers","contributors_url":"https://api.github.com/repos/slack-agent/slack-agent/contributors","subscribers_url":"https://api.github.com/repos/slack-agent/slack-agent/subscribers","subscription_url":"https://api.github.com/repos/slack-agent/slack-agent/subscription","commits_url":"https://api.github.com/repos/slack-agent/slack-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/slack-agent/slack-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/slack-agent/slack-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/slack-agent/slack-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/slack-agent/slack-agent/contents/{+path}","compare_url":"https://api.github.com/repos/slack-agent/slack-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slack-agent/slack-agent/merges","archive_url":"https://api.github.com/repos/slack-agent/slack-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slack-agent/slack-agent/downloads","issues_url":"https://api.github.com/repos/slack-agent/slack-agent/issues{/number}","pulls_url":"https://api.github.com/repos/slack-agent/slack-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/slack-agent/slack-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/slack-agent/slack-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slack-agent/slack-agent/labels{/name}","releases_url":"https://api.github.com/repos/slack-agent/slack-agent/releases{/id}","deployments_url":"https://api.github.com/repos/slack-agent/slack-agent/deployments","created_at":"2019-01-21T13:40:20Z","updated_at":"2019-02-18T12:16:49Z","pushed_at":"2019-02-22T12:43:44Z","git_url":"git://github.com/slack-agent/slack-agent.git","ssh_url":"[email protected]:slack-agent/slack-agent.git","clone_url":"https://github.com/slack-agent/slack-agent.git","svn_url":"https://github.com/slack-agent/slack-agent","homepage":null,"size":151,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"slack-agent:develop","ref":"develop","sha":"431df8d1f3d1e948c5ab0fb0346a78877bb97385","user":{"login":"slack-agent","id":46817016,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODE3MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/46817016?v=4","gravatar_id":"","url":"https://api.github.com/users/slack-agent","html_url":"https://github.com/slack-agent","followers_url":"https://api.github.com/users/slack-agent/followers","following_url":"https://api.github.com/users/slack-agent/following{/other_user}","gists_url":"https://api.github.com/users/slack-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/slack-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slack-agent/subscriptions","organizations_url":"https://api.github.com/users/slack-agent/orgs","repos_url":"https://api.github.com/users/slack-agent/repos","events_url":"https://api.github.com/users/slack-agent/events{/privacy}","received_events_url":"https://api.github.com/users/slack-agent/received_events","type":"Organization","site_admin":false},"repo":{"id":166820569,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY4MjA1Njk=","name":"slack-agent","full_name":"slack-agent/slack-agent","private":false,"owner":{"login":"slack-agent","id":46817016,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODE3MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/46817016?v=4","gravatar_id":"","url":"https://api.github.com/users/slack-agent","html_url":"https://github.com/slack-agent","followers_url":"https://api.github.com/users/slack-agent/followers","following_url":"https://api.github.com/users/slack-agent/following{/other_user}","gists_url":"https://api.github.com/users/slack-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/slack-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slack-agent/subscriptions","organizations_url":"https://api.github.com/users/slack-agent/orgs","repos_url":"https://api.github.com/users/slack-agent/repos","events_url":"https://api.github.com/users/slack-agent/events{/privacy}","received_events_url":"https://api.github.com/users/slack-agent/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/slack-agent/slack-agent","description":null,"fork":false,"url":"https://api.github.com/repos/slack-agent/slack-agent","forks_url":"https://api.github.com/repos/slack-agent/slack-agent/forks","keys_url":"https://api.github.com/repos/slack-agent/slack-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slack-agent/slack-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slack-agent/slack-agent/teams","hooks_url":"https://api.github.com/repos/slack-agent/slack-agent/hooks","issue_events_url":"https://api.github.com/repos/slack-agent/slack-agent/issues/events{/number}","events_url":"https://api.github.com/repos/slack-agent/slack-agent/events","assignees_url":"https://api.github.com/repos/slack-agent/slack-agent/assignees{/user}","branches_url":"https://api.github.com/repos/slack-agent/slack-agent/branches{/branch}","tags_url":"https://api.github.com/repos/slack-agent/slack-agent/tags","blobs_url":"https://api.github.com/repos/slack-agent/slack-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slack-agent/slack-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slack-agent/slack-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/slack-agent/slack-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slack-agent/slack-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/slack-agent/slack-agent/languages","stargazers_url":"https://api.github.com/repos/slack-agent/slack-agent/stargazers","contributors_url":"https://api.github.com/repos/slack-agent/slack-agent/contributors","subscribers_url":"https://api.github.com/repos/slack-agent/slack-agent/subscribers","subscription_url":"https://api.github.com/repos/slack-agent/slack-agent/subscription","commits_url":"https://api.github.com/repos/slack-agent/slack-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/slack-agent/slack-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/slack-agent/slack-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/slack-agent/slack-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/slack-agent/slack-agent/contents/{+path}","compare_url":"https://api.github.com/repos/slack-agent/slack-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slack-agent/slack-agent/merges","archive_url":"https://api.github.com/repos/slack-agent/slack-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slack-agent/slack-agent/downloads","issues_url":"https://api.github.com/repos/slack-agent/slack-agent/issues{/number}","pulls_url":"https://api.github.com/repos/slack-agent/slack-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/slack-agent/slack-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/slack-agent/slack-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slack-agent/slack-agent/labels{/name}","releases_url":"https://api.github.com/repos/slack-agent/slack-agent/releases{/id}","deployments_url":"https://api.github.com/repos/slack-agent/slack-agent/deployments","created_at":"2019-01-21T13:40:20Z","updated_at":"2019-02-18T12:16:49Z","pushed_at":"2019-02-22T12:43:44Z","git_url":"git://github.com/slack-agent/slack-agent.git","ssh_url":"[email protected]:slack-agent/slack-agent.git","clone_url":"https://github.com/slack-agent/slack-agent.git","svn_url":"https://github.com/slack-agent/slack-agent","homepage":null,"size":151,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slack-agent/slack-agent/pulls/25"},"html":{"href":"https://github.com/slack-agent/slack-agent/pull/25"},"issue":{"href":"https://api.github.com/repos/slack-agent/slack-agent/issues/25"},"comments":{"href":"https://api.github.com/repos/slack-agent/slack-agent/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/slack-agent/slack-agent/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/slack-agent/slack-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slack-agent/slack-agent/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/slack-agent/slack-agent/statuses/706f129f486196f6cbb5dc1e0e4a45404e6d31af"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 166820569,
"name": "slack-agent/slack-agent",
"url": "https://api.github.com/repos/slack-agent/slack-agent"
}
|
{
"id": 9100242,
"login": "mgolawski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9100242?",
"url": "https://api.github.com/users/mgolawski"
}
|
{
"id": 46817016,
"login": "slack-agent",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46817016?",
"url": "https://api.github.com/orgs/slack-agent"
}
| 2019-02-22T13:17:00 |
9117914436
|
{"actor":{"display_login":"mgolawski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/comments/254096556","pull_request_review_id":200364045,"id":254096556,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDA5NjU1Ng==","diff_hunk":"@@ -3121,7 +3121,10 @@\n \"integrity\": \"sha512-56uBjw1Tph1BKMqRP0yhI136OiID+WBn9YRLjpJ6GTJ1Qwh9bt82rJBK2GiEVF/bNyWb7QkhcrgujIASStg11Q==\",\n \"requires\": {\n \"@babel/runtime\": \"^7.1.2\",\n+<<<<<<< HEAD\n+=======","path":"package-lock.json","position":5,"original_position":5,"commit_id":"9855a0b4fe84658db6240477c60c1bd6dbc90f14","original_commit_id":"9855a0b4fe84658db6240477c60c1bd6dbc90f14","user":{"login":"BUInvent","id":20247455,"node_id":"MDQ6VXNlcjIwMjQ3NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/20247455?v=4","gravatar_id":"","url":"https://api.github.com/users/BUInvent","html_url":"https://github.com/BUInvent","followers_url":"https://api.github.com/users/BUInvent/followers","following_url":"https://api.github.com/users/BUInvent/following{/other_user}","gists_url":"https://api.github.com/users/BUInvent/gists{/gist_id}","starred_url":"https://api.github.com/users/BUInvent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BUInvent/subscriptions","organizations_url":"https://api.github.com/users/BUInvent/orgs","repos_url":"https://api.github.com/users/BUInvent/repos","events_url":"https://api.github.com/users/BUInvent/events{/privacy}","received_events_url":"https://api.github.com/users/BUInvent/received_events","type":"User","site_admin":false},"body":"The merge conflict lines shouldn't be here","created_at":"2019-02-06T00:05:04Z","updated_at":"2019-02-06T00:13:22Z","html_url":"https://github.com/catcallapp/cat-call-app/pull/104#discussion_r254096556","pull_request_url":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/104","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/comments/254096556"},"html":{"href":"https://github.com/catcallapp/cat-call-app/pull/104#discussion_r254096556"},"pull_request":{"href":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/104","id":250585261,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwNTg1MjYx","html_url":"https://github.com/catcallapp/cat-call-app/pull/104","diff_url":"https://github.com/catcallapp/cat-call-app/pull/104.diff","patch_url":"https://github.com/catcallapp/cat-call-app/pull/104.patch","issue_url":"https://api.github.com/repos/catcallapp/cat-call-app/issues/104","number":104,"state":"open","locked":false,"title":"Feature conversations message notifications","user":{"login":"smlarkin","id":38188005,"node_id":"MDQ6VXNlcjM4MTg4MDA1","avatar_url":"https://avatars2.githubusercontent.com/u/38188005?v=4","gravatar_id":"","url":"https://api.github.com/users/smlarkin","html_url":"https://github.com/smlarkin","followers_url":"https://api.github.com/users/smlarkin/followers","following_url":"https://api.github.com/users/smlarkin/following{/other_user}","gists_url":"https://api.github.com/users/smlarkin/gists{/gist_id}","starred_url":"https://api.github.com/users/smlarkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlarkin/subscriptions","organizations_url":"https://api.github.com/users/smlarkin/orgs","repos_url":"https://api.github.com/users/smlarkin/repos","events_url":"https://api.github.com/users/smlarkin/events{/privacy}","received_events_url":"https://api.github.com/users/smlarkin/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-05T23:13:21Z","updated_at":"2019-02-06T00:13:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02c7bc60594cd78e9aea4ce6d9b17ae281c211c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/104/commits","review_comments_url":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/104/comments","review_comment_url":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/catcallapp/cat-call-app/issues/104/comments","statuses_url":"https://api.github.com/repos/catcallapp/cat-call-app/statuses/9855a0b4fe84658db6240477c60c1bd6dbc90f14","head":{"label":"catcallapp:FEATURE-conversations-message-notifications","ref":"FEATURE-conversations-message-notifications","sha":"9855a0b4fe84658db6240477c60c1bd6dbc90f14","user":{"login":"catcallapp","id":47032389,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDMyMzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47032389?v=4","gravatar_id":"","url":"https://api.github.com/users/catcallapp","html_url":"https://github.com/catcallapp","followers_url":"https://api.github.com/users/catcallapp/followers","following_url":"https://api.github.com/users/catcallapp/following{/other_user}","gists_url":"https://api.github.com/users/catcallapp/gists{/gist_id}","starred_url":"https://api.github.com/users/catcallapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catcallapp/subscriptions","organizations_url":"https://api.github.com/users/catcallapp/orgs","repos_url":"https://api.github.com/users/catcallapp/repos","events_url":"https://api.github.com/users/catcallapp/events{/privacy}","received_events_url":"https://api.github.com/users/catcallapp/received_events","type":"Organization","site_admin":false},"repo":{"id":168220646,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgyMjA2NDY=","name":"cat-call-app","full_name":"catcallapp/cat-call-app","private":false,"owner":{"login":"catcallapp","id":47032389,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDMyMzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47032389?v=4","gravatar_id":"","url":"https://api.github.com/users/catcallapp","html_url":"https://github.com/catcallapp","followers_url":"https://api.github.com/users/catcallapp/followers","following_url":"https://api.github.com/users/catcallapp/following{/other_user}","gists_url":"https://api.github.com/users/catcallapp/gists{/gist_id}","starred_url":"https://api.github.com/users/catcallapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catcallapp/subscriptions","organizations_url":"https://api.github.com/users/catcallapp/orgs","repos_url":"https://api.github.com/users/catcallapp/repos","events_url":"https://api.github.com/users/catcallapp/events{/privacy}","received_events_url":"https://api.github.com/users/catcallapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catcallapp/cat-call-app","description":"SERJ 1.0 is our Chat App MVP.","fork":false,"url":"https://api.github.com/repos/catcallapp/cat-call-app","forks_url":"https://api.github.com/repos/catcallapp/cat-call-app/forks","keys_url":"https://api.github.com/repos/catcallapp/cat-call-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catcallapp/cat-call-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catcallapp/cat-call-app/teams","hooks_url":"https://api.github.com/repos/catcallapp/cat-call-app/hooks","issue_events_url":"https://api.github.com/repos/catcallapp/cat-call-app/issues/events{/number}","events_url":"https://api.github.com/repos/catcallapp/cat-call-app/events","assignees_url":"https://api.github.com/repos/catcallapp/cat-call-app/assignees{/user}","branches_url":"https://api.github.com/repos/catcallapp/cat-call-app/branches{/branch}","tags_url":"https://api.github.com/repos/catcallapp/cat-call-app/tags","blobs_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catcallapp/cat-call-app/statuses/{sha}","languages_url":"https://api.github.com/repos/catcallapp/cat-call-app/languages","stargazers_url":"https://api.github.com/repos/catcallapp/cat-call-app/stargazers","contributors_url":"https://api.github.com/repos/catcallapp/cat-call-app/contributors","subscribers_url":"https://api.github.com/repos/catcallapp/cat-call-app/subscribers","subscription_url":"https://api.github.com/repos/catcallapp/cat-call-app/subscription","commits_url":"https://api.github.com/repos/catcallapp/cat-call-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/catcallapp/cat-call-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/catcallapp/cat-call-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/catcallapp/cat-call-app/contents/{+path}","compare_url":"https://api.github.com/repos/catcallapp/cat-call-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catcallapp/cat-call-app/merges","archive_url":"https://api.github.com/repos/catcallapp/cat-call-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catcallapp/cat-call-app/downloads","issues_url":"https://api.github.com/repos/catcallapp/cat-call-app/issues{/number}","pulls_url":"https://api.github.com/repos/catcallapp/cat-call-app/pulls{/number}","milestones_url":"https://api.github.com/repos/catcallapp/cat-call-app/milestones{/number}","notifications_url":"https://api.github.com/repos/catcallapp/cat-call-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catcallapp/cat-call-app/labels{/name}","releases_url":"https://api.github.com/repos/catcallapp/cat-call-app/releases{/id}","deployments_url":"https://api.github.com/repos/catcallapp/cat-call-app/deployments","created_at":"2019-01-29T20:08:13Z","updated_at":"2019-02-06T00:00:35Z","pushed_at":"2019-02-06T00:09:07Z","git_url":"git://github.com/catcallapp/cat-call-app.git","ssh_url":"[email protected]:catcallapp/cat-call-app.git","clone_url":"https://github.com/catcallapp/cat-call-app.git","svn_url":"https://github.com/catcallapp/cat-call-app","homepage":"","size":3627,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":2,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"catcallapp:master","ref":"master","sha":"58fed6b90692d5613c2c0308408b910674322581","user":{"login":"catcallapp","id":47032389,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDMyMzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47032389?v=4","gravatar_id":"","url":"https://api.github.com/users/catcallapp","html_url":"https://github.com/catcallapp","followers_url":"https://api.github.com/users/catcallapp/followers","following_url":"https://api.github.com/users/catcallapp/following{/other_user}","gists_url":"https://api.github.com/users/catcallapp/gists{/gist_id}","starred_url":"https://api.github.com/users/catcallapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catcallapp/subscriptions","organizations_url":"https://api.github.com/users/catcallapp/orgs","repos_url":"https://api.github.com/users/catcallapp/repos","events_url":"https://api.github.com/users/catcallapp/events{/privacy}","received_events_url":"https://api.github.com/users/catcallapp/received_events","type":"Organization","site_admin":false},"repo":{"id":168220646,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgyMjA2NDY=","name":"cat-call-app","full_name":"catcallapp/cat-call-app","private":false,"owner":{"login":"catcallapp","id":47032389,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDMyMzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47032389?v=4","gravatar_id":"","url":"https://api.github.com/users/catcallapp","html_url":"https://github.com/catcallapp","followers_url":"https://api.github.com/users/catcallapp/followers","following_url":"https://api.github.com/users/catcallapp/following{/other_user}","gists_url":"https://api.github.com/users/catcallapp/gists{/gist_id}","starred_url":"https://api.github.com/users/catcallapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catcallapp/subscriptions","organizations_url":"https://api.github.com/users/catcallapp/orgs","repos_url":"https://api.github.com/users/catcallapp/repos","events_url":"https://api.github.com/users/catcallapp/events{/privacy}","received_events_url":"https://api.github.com/users/catcallapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catcallapp/cat-call-app","description":"SERJ 1.0 is our Chat App MVP.","fork":false,"url":"https://api.github.com/repos/catcallapp/cat-call-app","forks_url":"https://api.github.com/repos/catcallapp/cat-call-app/forks","keys_url":"https://api.github.com/repos/catcallapp/cat-call-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catcallapp/cat-call-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catcallapp/cat-call-app/teams","hooks_url":"https://api.github.com/repos/catcallapp/cat-call-app/hooks","issue_events_url":"https://api.github.com/repos/catcallapp/cat-call-app/issues/events{/number}","events_url":"https://api.github.com/repos/catcallapp/cat-call-app/events","assignees_url":"https://api.github.com/repos/catcallapp/cat-call-app/assignees{/user}","branches_url":"https://api.github.com/repos/catcallapp/cat-call-app/branches{/branch}","tags_url":"https://api.github.com/repos/catcallapp/cat-call-app/tags","blobs_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catcallapp/cat-call-app/statuses/{sha}","languages_url":"https://api.github.com/repos/catcallapp/cat-call-app/languages","stargazers_url":"https://api.github.com/repos/catcallapp/cat-call-app/stargazers","contributors_url":"https://api.github.com/repos/catcallapp/cat-call-app/contributors","subscribers_url":"https://api.github.com/repos/catcallapp/cat-call-app/subscribers","subscription_url":"https://api.github.com/repos/catcallapp/cat-call-app/subscription","commits_url":"https://api.github.com/repos/catcallapp/cat-call-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/catcallapp/cat-call-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/catcallapp/cat-call-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/catcallapp/cat-call-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/catcallapp/cat-call-app/contents/{+path}","compare_url":"https://api.github.com/repos/catcallapp/cat-call-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catcallapp/cat-call-app/merges","archive_url":"https://api.github.com/repos/catcallapp/cat-call-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catcallapp/cat-call-app/downloads","issues_url":"https://api.github.com/repos/catcallapp/cat-call-app/issues{/number}","pulls_url":"https://api.github.com/repos/catcallapp/cat-call-app/pulls{/number}","milestones_url":"https://api.github.com/repos/catcallapp/cat-call-app/milestones{/number}","notifications_url":"https://api.github.com/repos/catcallapp/cat-call-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catcallapp/cat-call-app/labels{/name}","releases_url":"https://api.github.com/repos/catcallapp/cat-call-app/releases{/id}","deployments_url":"https://api.github.com/repos/catcallapp/cat-call-app/deployments","created_at":"2019-01-29T20:08:13Z","updated_at":"2019-02-06T00:00:35Z","pushed_at":"2019-02-06T00:09:07Z","git_url":"git://github.com/catcallapp/cat-call-app.git","ssh_url":"[email protected]:catcallapp/cat-call-app.git","clone_url":"https://github.com/catcallapp/cat-call-app.git","svn_url":"https://github.com/catcallapp/cat-call-app","homepage":"","size":3627,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":2,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/104"},"html":{"href":"https://github.com/catcallapp/cat-call-app/pull/104"},"issue":{"href":"https://api.github.com/repos/catcallapp/cat-call-app/issues/104"},"comments":{"href":"https://api.github.com/repos/catcallapp/cat-call-app/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/catcallapp/cat-call-app/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/catcallapp/cat-call-app/statuses/9855a0b4fe84658db6240477c60c1bd6dbc90f14"}},"author_association":"COLLABORATOR"}}
|
{
"id": 168220646,
"name": "catcallapp/cat-call-app",
"url": "https://api.github.com/repos/catcallapp/cat-call-app"
}
|
{
"id": 20247455,
"login": "BUInvent",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20247455?",
"url": "https://api.github.com/users/BUInvent"
}
|
{
"id": 47032389,
"login": "catcallapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47032389?",
"url": "https://api.github.com/orgs/catcallapp"
}
| 2019-02-06T00:05:04 |
9014921799
|
{"actor":{"display_login":"BUInvent"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pymedphys/pymedphys/pulls/comments/308216488","pull_request_review_id":267758101,"id":308216488,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODIxNjQ4OA==","diff_hunk":"@@ -483,6 +436,15 @@ def is_anonymised_dataset(ds, ignore_private_tags=False):\n if elem.VR == \"SQ\":\n if not (elem.value == [] or elem.value == dummy_value):\n is_anonymised = False\n+ elif elem.VR == \"DS\":\n+ if not (\n+ elem.value == \"\"\n+ or np.isclose(float(elem.value), float(dummy_value))\n+ ):\n+ is_anonymised = False\n+ elif elem.VR in (\"OB\", \"OW\"):\n+ if not (elem.value == \"\" or elem.value == (0).to_bytes(2, \"little\")):\n+ is_anonymised = False","path":"packages/pymedphys_dicom/src/pymedphys_dicom/dicom/anonymise.py","position":175,"original_position":175,"commit_id":"b9fc62e64e3ebc5598045aacbb7b0218bdbb6263","original_commit_id":"b9fc62e64e3ebc5598045aacbb7b0218bdbb6263","user":{"login":"SimonBiggs","id":6559099,"node_id":"MDQ6VXNlcjY1NTkwOTk=","avatar_url":"https://avatars1.githubusercontent.com/u/6559099?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonBiggs","html_url":"https://github.com/SimonBiggs","followers_url":"https://api.github.com/users/SimonBiggs/followers","following_url":"https://api.github.com/users/SimonBiggs/following{/other_user}","gists_url":"https://api.github.com/users/SimonBiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonBiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonBiggs/subscriptions","organizations_url":"https://api.github.com/users/SimonBiggs/orgs","repos_url":"https://api.github.com/users/SimonBiggs/repos","events_url":"https://api.github.com/users/SimonBiggs/events{/privacy}","received_events_url":"https://api.github.com/users/SimonBiggs/received_events","type":"User","site_admin":false},"body":"JAC\r\n\r\nCan't help but think there must be a neater way to step through these cases. No real issue though. It's clear enough.","created_at":"2019-07-29T13:02:27Z","updated_at":"2019-07-29T13:03:55Z","html_url":"https://github.com/pymedphys/pymedphys/pull/437#discussion_r308216488","pull_request_url":"https://api.github.com/repos/pymedphys/pymedphys/pulls/437","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pymedphys/pymedphys/pulls/comments/308216488"},"html":{"href":"https://github.com/pymedphys/pymedphys/pull/437#discussion_r308216488"},"pull_request":{"href":"https://api.github.com/repos/pymedphys/pymedphys/pulls/437"}}},"pull_request":{"url":"https://api.github.com/repos/pymedphys/pymedphys/pulls/437","id":301358577,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMzU4NTc3","html_url":"https://github.com/pymedphys/pymedphys/pull/437","diff_url":"https://github.com/pymedphys/pymedphys/pull/437.diff","patch_url":"https://github.com/pymedphys/pymedphys/pull/437.patch","issue_url":"https://api.github.com/repos/pymedphys/pymedphys/issues/437","number":437,"state":"open","locked":false,"title":"[WIP] Update anonymise with dicom supplement 142","user":{"login":"Matthew-Jennings","id":19767103,"node_id":"MDQ6VXNlcjE5NzY3MTAz","avatar_url":"https://avatars0.githubusercontent.com/u/19767103?v=4","gravatar_id":"","url":"https://api.github.com/users/Matthew-Jennings","html_url":"https://github.com/Matthew-Jennings","followers_url":"https://api.github.com/users/Matthew-Jennings/followers","following_url":"https://api.github.com/users/Matthew-Jennings/following{/other_user}","gists_url":"https://api.github.com/users/Matthew-Jennings/gists{/gist_id}","starred_url":"https://api.github.com/users/Matthew-Jennings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matthew-Jennings/subscriptions","organizations_url":"https://api.github.com/users/Matthew-Jennings/orgs","repos_url":"https://api.github.com/users/Matthew-Jennings/repos","events_url":"https://api.github.com/users/Matthew-Jennings/events{/privacy}","received_events_url":"https://api.github.com/users/Matthew-Jennings/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-26T00:55:59Z","updated_at":"2019-07-29T13:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9c21ae2e1bffeca08f7912c24bc0485d68ea7b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pymedphys/pymedphys/pulls/437/commits","review_comments_url":"https://api.github.com/repos/pymedphys/pymedphys/pulls/437/comments","review_comment_url":"https://api.github.com/repos/pymedphys/pymedphys/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pymedphys/pymedphys/issues/437/comments","statuses_url":"https://api.github.com/repos/pymedphys/pymedphys/statuses/b9fc62e64e3ebc5598045aacbb7b0218bdbb6263","head":{"label":"pymedphys:update-anonymise-with-dicom-supplement-142","ref":"update-anonymise-with-dicom-supplement-142","sha":"b9fc62e64e3ebc5598045aacbb7b0218bdbb6263","user":{"login":"pymedphys","id":47132275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MTMyMjc1","avatar_url":"https://avatars3.githubusercontent.com/u/47132275?v=4","gravatar_id":"","url":"https://api.github.com/users/pymedphys","html_url":"https://github.com/pymedphys","followers_url":"https://api.github.com/users/pymedphys/followers","following_url":"https://api.github.com/users/pymedphys/following{/other_user}","gists_url":"https://api.github.com/users/pymedphys/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedphys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedphys/subscriptions","organizations_url":"https://api.github.com/users/pymedphys/orgs","repos_url":"https://api.github.com/users/pymedphys/repos","events_url":"https://api.github.com/users/pymedphys/events{/privacy}","received_events_url":"https://api.github.com/users/pymedphys/received_events","type":"Organization","site_admin":false},"repo":{"id":168238552,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgyMzg1NTI=","name":"pymedphys","full_name":"pymedphys/pymedphys","private":false,"owner":{"login":"pymedphys","id":47132275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MTMyMjc1","avatar_url":"https://avatars3.githubusercontent.com/u/47132275?v=4","gravatar_id":"","url":"https://api.github.com/users/pymedphys","html_url":"https://github.com/pymedphys","followers_url":"https://api.github.com/users/pymedphys/followers","following_url":"https://api.github.com/users/pymedphys/following{/other_user}","gists_url":"https://api.github.com/users/pymedphys/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedphys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedphys/subscriptions","organizations_url":"https://api.github.com/users/pymedphys/orgs","repos_url":"https://api.github.com/users/pymedphys/repos","events_url":"https://api.github.com/users/pymedphys/events{/privacy}","received_events_url":"https://api.github.com/users/pymedphys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pymedphys/pymedphys","description":"A community for Medical Physicists to share, review, improve, and transparently learn off of each otherโs code.","fork":false,"url":"https://api.github.com/repos/pymedphys/pymedphys","forks_url":"https://api.github.com/repos/pymedphys/pymedphys/forks","keys_url":"https://api.github.com/repos/pymedphys/pymedphys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pymedphys/pymedphys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pymedphys/pymedphys/teams","hooks_url":"https://api.github.com/repos/pymedphys/pymedphys/hooks","issue_events_url":"https://api.github.com/repos/pymedphys/pymedphys/issues/events{/number}","events_url":"https://api.github.com/repos/pymedphys/pymedphys/events","assignees_url":"https://api.github.com/repos/pymedphys/pymedphys/assignees{/user}","branches_url":"https://api.github.com/repos/pymedphys/pymedphys/branches{/branch}","tags_url":"https://api.github.com/repos/pymedphys/pymedphys/tags","blobs_url":"https://api.github.com/repos/pymedphys/pymedphys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pymedphys/pymedphys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pymedphys/pymedphys/git/refs{/sha}","trees_url":"https://api.github.com/repos/pymedphys/pymedphys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pymedphys/pymedphys/statuses/{sha}","languages_url":"https://api.github.com/repos/pymedphys/pymedphys/languages","stargazers_url":"https://api.github.com/repos/pymedphys/pymedphys/stargazers","contributors_url":"https://api.github.com/repos/pymedphys/pymedphys/contributors","subscribers_url":"https://api.github.com/repos/pymedphys/pymedphys/subscribers","subscription_url":"https://api.github.com/repos/pymedphys/pymedphys/subscription","commits_url":"https://api.github.com/repos/pymedphys/pymedphys/commits{/sha}","git_commits_url":"https://api.github.com/repos/pymedphys/pymedphys/git/commits{/sha}","comments_url":"https://api.github.com/repos/pymedphys/pymedphys/comments{/number}","issue_comment_url":"https://api.github.com/repos/pymedphys/pymedphys/issues/comments{/number}","contents_url":"https://api.github.com/repos/pymedphys/pymedphys/contents/{+path}","compare_url":"https://api.github.com/repos/pymedphys/pymedphys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pymedphys/pymedphys/merges","archive_url":"https://api.github.com/repos/pymedphys/pymedphys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pymedphys/pymedphys/downloads","issues_url":"https://api.github.com/repos/pymedphys/pymedphys/issues{/number}","pulls_url":"https://api.github.com/repos/pymedphys/pymedphys/pulls{/number}","milestones_url":"https://api.github.com/repos/pymedphys/pymedphys/milestones{/number}","notifications_url":"https://api.github.com/repos/pymedphys/pymedphys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pymedphys/pymedphys/labels{/name}","releases_url":"https://api.github.com/repos/pymedphys/pymedphys/releases{/id}","deployments_url":"https://api.github.com/repos/pymedphys/pymedphys/deployments","created_at":"2019-01-29T22:20:04Z","updated_at":"2019-07-29T02:44:45Z","pushed_at":"2019-07-29T04:24:23Z","git_url":"git://github.com/pymedphys/pymedphys.git","ssh_url":"[email protected]:pymedphys/pymedphys.git","clone_url":"https://github.com/pymedphys/pymedphys.git","svn_url":"https://github.com/pymedphys/pymedphys","homepage":"https://docs.pymedphys.com","size":673164,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":160,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":160,"watchers":32,"default_branch":"master"}},"base":{"label":"pymedphys:master","ref":"master","sha":"b185a99b2f5983db77344e2f6a254e0c73df8eaf","user":{"login":"pymedphys","id":47132275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MTMyMjc1","avatar_url":"https://avatars3.githubusercontent.com/u/47132275?v=4","gravatar_id":"","url":"https://api.github.com/users/pymedphys","html_url":"https://github.com/pymedphys","followers_url":"https://api.github.com/users/pymedphys/followers","following_url":"https://api.github.com/users/pymedphys/following{/other_user}","gists_url":"https://api.github.com/users/pymedphys/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedphys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedphys/subscriptions","organizations_url":"https://api.github.com/users/pymedphys/orgs","repos_url":"https://api.github.com/users/pymedphys/repos","events_url":"https://api.github.com/users/pymedphys/events{/privacy}","received_events_url":"https://api.github.com/users/pymedphys/received_events","type":"Organization","site_admin":false},"repo":{"id":168238552,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgyMzg1NTI=","name":"pymedphys","full_name":"pymedphys/pymedphys","private":false,"owner":{"login":"pymedphys","id":47132275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MTMyMjc1","avatar_url":"https://avatars3.githubusercontent.com/u/47132275?v=4","gravatar_id":"","url":"https://api.github.com/users/pymedphys","html_url":"https://github.com/pymedphys","followers_url":"https://api.github.com/users/pymedphys/followers","following_url":"https://api.github.com/users/pymedphys/following{/other_user}","gists_url":"https://api.github.com/users/pymedphys/gists{/gist_id}","starred_url":"https://api.github.com/users/pymedphys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pymedphys/subscriptions","organizations_url":"https://api.github.com/users/pymedphys/orgs","repos_url":"https://api.github.com/users/pymedphys/repos","events_url":"https://api.github.com/users/pymedphys/events{/privacy}","received_events_url":"https://api.github.com/users/pymedphys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pymedphys/pymedphys","description":"A community for Medical Physicists to share, review, improve, and transparently learn off of each otherโs code.","fork":false,"url":"https://api.github.com/repos/pymedphys/pymedphys","forks_url":"https://api.github.com/repos/pymedphys/pymedphys/forks","keys_url":"https://api.github.com/repos/pymedphys/pymedphys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pymedphys/pymedphys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pymedphys/pymedphys/teams","hooks_url":"https://api.github.com/repos/pymedphys/pymedphys/hooks","issue_events_url":"https://api.github.com/repos/pymedphys/pymedphys/issues/events{/number}","events_url":"https://api.github.com/repos/pymedphys/pymedphys/events","assignees_url":"https://api.github.com/repos/pymedphys/pymedphys/assignees{/user}","branches_url":"https://api.github.com/repos/pymedphys/pymedphys/branches{/branch}","tags_url":"https://api.github.com/repos/pymedphys/pymedphys/tags","blobs_url":"https://api.github.com/repos/pymedphys/pymedphys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pymedphys/pymedphys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pymedphys/pymedphys/git/refs{/sha}","trees_url":"https://api.github.com/repos/pymedphys/pymedphys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pymedphys/pymedphys/statuses/{sha}","languages_url":"https://api.github.com/repos/pymedphys/pymedphys/languages","stargazers_url":"https://api.github.com/repos/pymedphys/pymedphys/stargazers","contributors_url":"https://api.github.com/repos/pymedphys/pymedphys/contributors","subscribers_url":"https://api.github.com/repos/pymedphys/pymedphys/subscribers","subscription_url":"https://api.github.com/repos/pymedphys/pymedphys/subscription","commits_url":"https://api.github.com/repos/pymedphys/pymedphys/commits{/sha}","git_commits_url":"https://api.github.com/repos/pymedphys/pymedphys/git/commits{/sha}","comments_url":"https://api.github.com/repos/pymedphys/pymedphys/comments{/number}","issue_comment_url":"https://api.github.com/repos/pymedphys/pymedphys/issues/comments{/number}","contents_url":"https://api.github.com/repos/pymedphys/pymedphys/contents/{+path}","compare_url":"https://api.github.com/repos/pymedphys/pymedphys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pymedphys/pymedphys/merges","archive_url":"https://api.github.com/repos/pymedphys/pymedphys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pymedphys/pymedphys/downloads","issues_url":"https://api.github.com/repos/pymedphys/pymedphys/issues{/number}","pulls_url":"https://api.github.com/repos/pymedphys/pymedphys/pulls{/number}","milestones_url":"https://api.github.com/repos/pymedphys/pymedphys/milestones{/number}","notifications_url":"https://api.github.com/repos/pymedphys/pymedphys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pymedphys/pymedphys/labels{/name}","releases_url":"https://api.github.com/repos/pymedphys/pymedphys/releases{/id}","deployments_url":"https://api.github.com/repos/pymedphys/pymedphys/deployments","created_at":"2019-01-29T22:20:04Z","updated_at":"2019-07-29T02:44:45Z","pushed_at":"2019-07-29T04:24:23Z","git_url":"git://github.com/pymedphys/pymedphys.git","ssh_url":"[email protected]:pymedphys/pymedphys.git","clone_url":"https://github.com/pymedphys/pymedphys.git","svn_url":"https://github.com/pymedphys/pymedphys","homepage":"https://docs.pymedphys.com","size":673164,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":160,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":160,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pymedphys/pymedphys/pulls/437"},"html":{"href":"https://github.com/pymedphys/pymedphys/pull/437"},"issue":{"href":"https://api.github.com/repos/pymedphys/pymedphys/issues/437"},"comments":{"href":"https://api.github.com/repos/pymedphys/pymedphys/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/pymedphys/pymedphys/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/pymedphys/pymedphys/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pymedphys/pymedphys/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/pymedphys/pymedphys/statuses/b9fc62e64e3ebc5598045aacbb7b0218bdbb6263"}},"author_association":"MEMBER"}}
|
{
"id": 168238552,
"name": "pymedphys/pymedphys",
"url": "https://api.github.com/repos/pymedphys/pymedphys"
}
|
{
"id": 6559099,
"login": "SimonBiggs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6559099?",
"url": "https://api.github.com/users/SimonBiggs"
}
|
{
"id": 47132275,
"login": "pymedphys",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47132275?",
"url": "https://api.github.com/orgs/pymedphys"
}
| 2019-07-29T13:02:27 |
10103182280
|
{"actor":{"display_login":"SimonBiggs"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/comments/302029853","pull_request_review_id":260048376,"id":302029853,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjAyOTg1Mw==","diff_hunk":"@@ -0,0 +1,50 @@\n+import React from 'react'\n+import { Text } from 'react-native'\n+","path":"src/utils/components/AppText.js","position":3,"original_position":3,"commit_id":"a3be33618362e89b5af65877daafc4d5b98d0e95","original_commit_id":"a3be33618362e89b5af65877daafc4d5b98d0e95","user":{"login":"shleeq","id":44970013,"node_id":"MDQ6VXNlcjQ0OTcwMDEz","avatar_url":"https://avatars3.githubusercontent.com/u/44970013?v=4","gravatar_id":"","url":"https://api.github.com/users/shleeq","html_url":"https://github.com/shleeq","followers_url":"https://api.github.com/users/shleeq/followers","following_url":"https://api.github.com/users/shleeq/following{/other_user}","gists_url":"https://api.github.com/users/shleeq/gists{/gist_id}","starred_url":"https://api.github.com/users/shleeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shleeq/subscriptions","organizations_url":"https://api.github.com/users/shleeq/orgs","repos_url":"https://api.github.com/users/shleeq/repos","events_url":"https://api.github.com/users/shleeq/events{/privacy}","received_events_url":"https://api.github.com/users/shleeq/received_events","type":"User","site_admin":false},"body":"On it","created_at":"2019-07-10T12:08:56Z","updated_at":"2019-07-10T12:08:57Z","html_url":"https://github.com/DevCAbuja/e-practice-mobile/pull/1#discussion_r302029853","pull_request_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/comments/302029853"},"html":{"href":"https://github.com/DevCAbuja/e-practice-mobile/pull/1#discussion_r302029853"},"pull_request":{"href":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/1"}},"in_reply_to_id":302028065},"pull_request":{"url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/1","id":295697318,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1Njk3MzE4","html_url":"https://github.com/DevCAbuja/e-practice-mobile/pull/1","diff_url":"https://github.com/DevCAbuja/e-practice-mobile/pull/1.diff","patch_url":"https://github.com/DevCAbuja/e-practice-mobile/pull/1.patch","issue_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/issues/1","number":1,"state":"open","locked":false,"title":"Project-Setup","user":{"login":"shleeq","id":44970013,"node_id":"MDQ6VXNlcjQ0OTcwMDEz","avatar_url":"https://avatars3.githubusercontent.com/u/44970013?v=4","gravatar_id":"","url":"https://api.github.com/users/shleeq","html_url":"https://github.com/shleeq","followers_url":"https://api.github.com/users/shleeq/followers","following_url":"https://api.github.com/users/shleeq/following{/other_user}","gists_url":"https://api.github.com/users/shleeq/gists{/gist_id}","starred_url":"https://api.github.com/users/shleeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shleeq/subscriptions","organizations_url":"https://api.github.com/users/shleeq/orgs","repos_url":"https://api.github.com/users/shleeq/repos","events_url":"https://api.github.com/users/shleeq/events{/privacy}","received_events_url":"https://api.github.com/users/shleeq/received_events","type":"User","site_admin":false},"body":"Project Setup using React native CLI.\r\n\r\n- Initialized project\r\n- Initialize git repository\r\n- Setup git branch and merge rules\r\n- Setup README.md and CONTRIBUTIONS guidelines\r\n- Setup redux => Redux persist and Redux\r\n- Add fonts (Roboto and Poppins) Comment if you can't get the font files => Custom fonts in Bold, Light and Regular for both font families.\r\n\r\n**Dependencies Added**\r\n\"react\": \"16.8.6\",\r\n\"react-native\": \"0.60.0\",\r\n\"react-redux\": \"^6.0.1\",\r\n\"redux\": \"^4.0.1\",\r\n\"redux-persist\": \"^5.10.0\"\r\n\r\n**DevDependencies Added**\r\n \"@babel/core\": \"7.5.0\",\r\n \"@babel/runtime\": \"7.5.2\",\r\n \"@react-native-community/eslint-config\": \"0.0.3\",\r\n \"babel-jest\": \"24.8.0\",\r\n \"eslint\": \"6.0.1\",\r\n \"jest\": \"24.8.0\",\r\n \"metro-react-native-babel-preset\": \"0.54.1\",\r\n \"react-test-renderer\": \"16.8.6\",\r\n\r\n\r\n","created_at":"2019-07-09T10:51:25Z","updated_at":"2019-07-10T12:08:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"288f9fceedabadf4e6e277416a4049977b478f14","assignee":null,"assignees":[],"requested_reviewers":[{"login":"devamaz","id":25336847,"node_id":"MDQ6VXNlcjI1MzM2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/25336847?v=4","gravatar_id":"","url":"https://api.github.com/users/devamaz","html_url":"https://github.com/devamaz","followers_url":"https://api.github.com/users/devamaz/followers","following_url":"https://api.github.com/users/devamaz/following{/other_user}","gists_url":"https://api.github.com/users/devamaz/gists{/gist_id}","starred_url":"https://api.github.com/users/devamaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devamaz/subscriptions","organizations_url":"https://api.github.com/users/devamaz/orgs","repos_url":"https://api.github.com/users/devamaz/repos","events_url":"https://api.github.com/users/devamaz/events{/privacy}","received_events_url":"https://api.github.com/users/devamaz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/1/commits","review_comments_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/1/comments","review_comment_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/issues/1/comments","statuses_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/statuses/a3be33618362e89b5af65877daafc4d5b98d0e95","head":{"label":"shleeq:projectsetup","ref":"projectsetup","sha":"a3be33618362e89b5af65877daafc4d5b98d0e95","user":{"login":"shleeq","id":44970013,"node_id":"MDQ6VXNlcjQ0OTcwMDEz","avatar_url":"https://avatars3.githubusercontent.com/u/44970013?v=4","gravatar_id":"","url":"https://api.github.com/users/shleeq","html_url":"https://github.com/shleeq","followers_url":"https://api.github.com/users/shleeq/followers","following_url":"https://api.github.com/users/shleeq/following{/other_user}","gists_url":"https://api.github.com/users/shleeq/gists{/gist_id}","starred_url":"https://api.github.com/users/shleeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shleeq/subscriptions","organizations_url":"https://api.github.com/users/shleeq/orgs","repos_url":"https://api.github.com/users/shleeq/repos","events_url":"https://api.github.com/users/shleeq/events{/privacy}","received_events_url":"https://api.github.com/users/shleeq/received_events","type":"User","site_admin":false},"repo":{"id":195880658,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU4ODA2NTg=","name":"e-practice-mobile","full_name":"shleeq/e-practice-mobile","private":false,"owner":{"login":"shleeq","id":44970013,"node_id":"MDQ6VXNlcjQ0OTcwMDEz","avatar_url":"https://avatars3.githubusercontent.com/u/44970013?v=4","gravatar_id":"","url":"https://api.github.com/users/shleeq","html_url":"https://github.com/shleeq","followers_url":"https://api.github.com/users/shleeq/followers","following_url":"https://api.github.com/users/shleeq/following{/other_user}","gists_url":"https://api.github.com/users/shleeq/gists{/gist_id}","starred_url":"https://api.github.com/users/shleeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shleeq/subscriptions","organizations_url":"https://api.github.com/users/shleeq/orgs","repos_url":"https://api.github.com/users/shleeq/repos","events_url":"https://api.github.com/users/shleeq/events{/privacy}","received_events_url":"https://api.github.com/users/shleeq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shleeq/e-practice-mobile","description":"Mobile application for e-practice built on react-native","fork":true,"url":"https://api.github.com/repos/shleeq/e-practice-mobile","forks_url":"https://api.github.com/repos/shleeq/e-practice-mobile/forks","keys_url":"https://api.github.com/repos/shleeq/e-practice-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shleeq/e-practice-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shleeq/e-practice-mobile/teams","hooks_url":"https://api.github.com/repos/shleeq/e-practice-mobile/hooks","issue_events_url":"https://api.github.com/repos/shleeq/e-practice-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/shleeq/e-practice-mobile/events","assignees_url":"https://api.github.com/repos/shleeq/e-practice-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/shleeq/e-practice-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/shleeq/e-practice-mobile/tags","blobs_url":"https://api.github.com/repos/shleeq/e-practice-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shleeq/e-practice-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shleeq/e-practice-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/shleeq/e-practice-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shleeq/e-practice-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/shleeq/e-practice-mobile/languages","stargazers_url":"https://api.github.com/repos/shleeq/e-practice-mobile/stargazers","contributors_url":"https://api.github.com/repos/shleeq/e-practice-mobile/contributors","subscribers_url":"https://api.github.com/repos/shleeq/e-practice-mobile/subscribers","subscription_url":"https://api.github.com/repos/shleeq/e-practice-mobile/subscription","commits_url":"https://api.github.com/repos/shleeq/e-practice-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/shleeq/e-practice-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/shleeq/e-practice-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/shleeq/e-practice-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/shleeq/e-practice-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/shleeq/e-practice-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shleeq/e-practice-mobile/merges","archive_url":"https://api.github.com/repos/shleeq/e-practice-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shleeq/e-practice-mobile/downloads","issues_url":"https://api.github.com/repos/shleeq/e-practice-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/shleeq/e-practice-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/shleeq/e-practice-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/shleeq/e-practice-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shleeq/e-practice-mobile/labels{/name}","releases_url":"https://api.github.com/repos/shleeq/e-practice-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/shleeq/e-practice-mobile/deployments","created_at":"2019-07-08T20:20:01Z","updated_at":"2019-07-09T10:40:20Z","pushed_at":"2019-07-10T11:06:01Z","git_url":"git://github.com/shleeq/e-practice-mobile.git","ssh_url":"[email protected]:shleeq/e-practice-mobile.git","clone_url":"https://github.com/shleeq/e-practice-mobile.git","svn_url":"https://github.com/shleeq/e-practice-mobile","homepage":"","size":780,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"DevCAbuja:dev","ref":"dev","sha":"9dc625d0328069681cf7385f124e0813a6bc74a8","user":{"login":"DevCAbuja","id":47176008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MTc2MDA4","avatar_url":"https://avatars1.githubusercontent.com/u/47176008?v=4","gravatar_id":"","url":"https://api.github.com/users/DevCAbuja","html_url":"https://github.com/DevCAbuja","followers_url":"https://api.github.com/users/DevCAbuja/followers","following_url":"https://api.github.com/users/DevCAbuja/following{/other_user}","gists_url":"https://api.github.com/users/DevCAbuja/gists{/gist_id}","starred_url":"https://api.github.com/users/DevCAbuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevCAbuja/subscriptions","organizations_url":"https://api.github.com/users/DevCAbuja/orgs","repos_url":"https://api.github.com/users/DevCAbuja/repos","events_url":"https://api.github.com/users/DevCAbuja/events{/privacy}","received_events_url":"https://api.github.com/users/DevCAbuja/received_events","type":"Organization","site_admin":false},"repo":{"id":195862459,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU4NjI0NTk=","name":"e-practice-mobile","full_name":"DevCAbuja/e-practice-mobile","private":false,"owner":{"login":"DevCAbuja","id":47176008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MTc2MDA4","avatar_url":"https://avatars1.githubusercontent.com/u/47176008?v=4","gravatar_id":"","url":"https://api.github.com/users/DevCAbuja","html_url":"https://github.com/DevCAbuja","followers_url":"https://api.github.com/users/DevCAbuja/followers","following_url":"https://api.github.com/users/DevCAbuja/following{/other_user}","gists_url":"https://api.github.com/users/DevCAbuja/gists{/gist_id}","starred_url":"https://api.github.com/users/DevCAbuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevCAbuja/subscriptions","organizations_url":"https://api.github.com/users/DevCAbuja/orgs","repos_url":"https://api.github.com/users/DevCAbuja/repos","events_url":"https://api.github.com/users/DevCAbuja/events{/privacy}","received_events_url":"https://api.github.com/users/DevCAbuja/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DevCAbuja/e-practice-mobile","description":"Mobile application for e-practice built on react-native","fork":false,"url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile","forks_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/forks","keys_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/teams","hooks_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/hooks","issue_events_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/events","assignees_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/tags","blobs_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/languages","stargazers_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/stargazers","contributors_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/contributors","subscribers_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/subscribers","subscription_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/subscription","commits_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/merges","archive_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/downloads","issues_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/labels{/name}","releases_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/deployments","created_at":"2019-07-08T18:04:28Z","updated_at":"2019-07-08T19:12:18Z","pushed_at":"2019-07-10T11:06:03Z","git_url":"git://github.com/DevCAbuja/e-practice-mobile.git","ssh_url":"[email protected]:DevCAbuja/e-practice-mobile.git","clone_url":"https://github.com/DevCAbuja/e-practice-mobile.git","svn_url":"https://github.com/DevCAbuja/e-practice-mobile","homepage":null,"size":1,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":1,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/1"},"html":{"href":"https://github.com/DevCAbuja/e-practice-mobile/pull/1"},"issue":{"href":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/issues/1"},"comments":{"href":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/DevCAbuja/e-practice-mobile/statuses/a3be33618362e89b5af65877daafc4d5b98d0e95"}},"author_association":"NONE"}}
|
{
"id": 195862459,
"name": "DevCAbuja/e-practice-mobile",
"url": "https://api.github.com/repos/DevCAbuja/e-practice-mobile"
}
|
{
"id": 44970013,
"login": "shleeq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/44970013?",
"url": "https://api.github.com/users/shleeq"
}
|
{
"id": 47176008,
"login": "DevCAbuja",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47176008?",
"url": "https://api.github.com/orgs/DevCAbuja"
}
| 2019-07-10T12:08:56 |
9983324647
|
{"actor":{"display_login":"shleeq"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/comments/313227292","pull_request_review_id":274070463,"id":313227292,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzIyNzI5Mg==","diff_hunk":"@@ -5,9 +5,10 @@\n \"noUnusedLocals\": true,\n \"noUnusedParameters\": true,\n \"sourceMap\": false,\n- \"target\": \"es2017\",\n+ \"target\": \"es5\",","path":"tsconfig.json","position":null,"original_position":5,"commit_id":"825f17417de7b2345581098e659eb0f3acb249c6","original_commit_id":"e3e158efb721a01bc38b1fb083be56a169309310","user":{"login":"perception30","id":536174,"node_id":"MDQ6VXNlcjUzNjE3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/536174?v=4","gravatar_id":"","url":"https://api.github.com/users/perception30","html_url":"https://github.com/perception30","followers_url":"https://api.github.com/users/perception30/followers","following_url":"https://api.github.com/users/perception30/following{/other_user}","gists_url":"https://api.github.com/users/perception30/gists{/gist_id}","starred_url":"https://api.github.com/users/perception30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perception30/subscriptions","organizations_url":"https://api.github.com/users/perception30/orgs","repos_url":"https://api.github.com/users/perception30/repos","events_url":"https://api.github.com/users/perception30/events{/privacy}","received_events_url":"https://api.github.com/users/perception30/received_events","type":"User","site_admin":false},"body":"ok. Making it 2015","created_at":"2019-08-13T05:45:15Z","updated_at":"2019-08-13T05:45:16Z","html_url":"https://github.com/lendi-au/StackJanitor/pull/9#discussion_r313227292","pull_request_url":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/comments/313227292"},"html":{"href":"https://github.com/lendi-au/StackJanitor/pull/9#discussion_r313227292"},"pull_request":{"href":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/9"}},"in_reply_to_id":313225957},"pull_request":{"url":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/9","id":306709489,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2NzA5NDg5","html_url":"https://github.com/lendi-au/StackJanitor/pull/9","diff_url":"https://github.com/lendi-au/StackJanitor/pull/9.diff","patch_url":"https://github.com/lendi-au/StackJanitor/pull/9.patch","issue_url":"https://api.github.com/repos/lendi-au/StackJanitor/issues/9","number":9,"state":"open","locked":false,"title":"Plat 104 testing and refactoring","user":{"login":"perception30","id":536174,"node_id":"MDQ6VXNlcjUzNjE3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/536174?v=4","gravatar_id":"","url":"https://api.github.com/users/perception30","html_url":"https://github.com/perception30","followers_url":"https://api.github.com/users/perception30/followers","following_url":"https://api.github.com/users/perception30/following{/other_user}","gists_url":"https://api.github.com/users/perception30/gists{/gist_id}","starred_url":"https://api.github.com/users/perception30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perception30/subscriptions","organizations_url":"https://api.github.com/users/perception30/orgs","repos_url":"https://api.github.com/users/perception30/repos","events_url":"https://api.github.com/users/perception30/events{/privacy}","received_events_url":"https://api.github.com/users/perception30/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-13T00:54:45Z","updated_at":"2019-08-13T05:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/9/commits","review_comments_url":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/9/comments","review_comment_url":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lendi-au/StackJanitor/issues/9/comments","statuses_url":"https://api.github.com/repos/lendi-au/StackJanitor/statuses/825f17417de7b2345581098e659eb0f3acb249c6","head":{"label":"lendi-au:PLAT-104-testing-and-refactoring","ref":"PLAT-104-testing-and-refactoring","sha":"825f17417de7b2345581098e659eb0f3acb249c6","user":{"login":"lendi-au","id":47421454,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NDIxNDU0","avatar_url":"https://avatars2.githubusercontent.com/u/47421454?v=4","gravatar_id":"","url":"https://api.github.com/users/lendi-au","html_url":"https://github.com/lendi-au","followers_url":"https://api.github.com/users/lendi-au/followers","following_url":"https://api.github.com/users/lendi-au/following{/other_user}","gists_url":"https://api.github.com/users/lendi-au/gists{/gist_id}","starred_url":"https://api.github.com/users/lendi-au/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lendi-au/subscriptions","organizations_url":"https://api.github.com/users/lendi-au/orgs","repos_url":"https://api.github.com/users/lendi-au/repos","events_url":"https://api.github.com/users/lendi-au/events{/privacy}","received_events_url":"https://api.github.com/users/lendi-au/received_events","type":"Organization","site_admin":false},"repo":{"id":198120424,"node_id":"MDEwOlJlcG9zaXRvcnkxOTgxMjA0MjQ=","name":"StackJanitor","full_name":"lendi-au/StackJanitor","private":false,"owner":{"login":"lendi-au","id":47421454,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NDIxNDU0","avatar_url":"https://avatars2.githubusercontent.com/u/47421454?v=4","gravatar_id":"","url":"https://api.github.com/users/lendi-au","html_url":"https://github.com/lendi-au","followers_url":"https://api.github.com/users/lendi-au/followers","following_url":"https://api.github.com/users/lendi-au/following{/other_user}","gists_url":"https://api.github.com/users/lendi-au/gists{/gist_id}","starred_url":"https://api.github.com/users/lendi-au/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lendi-au/subscriptions","organizations_url":"https://api.github.com/users/lendi-au/orgs","repos_url":"https://api.github.com/users/lendi-au/repos","events_url":"https://api.github.com/users/lendi-au/events{/privacy}","received_events_url":"https://api.github.com/users/lendi-au/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lendi-au/StackJanitor","description":"StackJanitor cleans up CloudFormation stacks based on TTL and tags.","fork":false,"url":"https://api.github.com/repos/lendi-au/StackJanitor","forks_url":"https://api.github.com/repos/lendi-au/StackJanitor/forks","keys_url":"https://api.github.com/repos/lendi-au/StackJanitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lendi-au/StackJanitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lendi-au/StackJanitor/teams","hooks_url":"https://api.github.com/repos/lendi-au/StackJanitor/hooks","issue_events_url":"https://api.github.com/repos/lendi-au/StackJanitor/issues/events{/number}","events_url":"https://api.github.com/repos/lendi-au/StackJanitor/events","assignees_url":"https://api.github.com/repos/lendi-au/StackJanitor/assignees{/user}","branches_url":"https://api.github.com/repos/lendi-au/StackJanitor/branches{/branch}","tags_url":"https://api.github.com/repos/lendi-au/StackJanitor/tags","blobs_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lendi-au/StackJanitor/statuses/{sha}","languages_url":"https://api.github.com/repos/lendi-au/StackJanitor/languages","stargazers_url":"https://api.github.com/repos/lendi-au/StackJanitor/stargazers","contributors_url":"https://api.github.com/repos/lendi-au/StackJanitor/contributors","subscribers_url":"https://api.github.com/repos/lendi-au/StackJanitor/subscribers","subscription_url":"https://api.github.com/repos/lendi-au/StackJanitor/subscription","commits_url":"https://api.github.com/repos/lendi-au/StackJanitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/lendi-au/StackJanitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/lendi-au/StackJanitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/lendi-au/StackJanitor/contents/{+path}","compare_url":"https://api.github.com/repos/lendi-au/StackJanitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lendi-au/StackJanitor/merges","archive_url":"https://api.github.com/repos/lendi-au/StackJanitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lendi-au/StackJanitor/downloads","issues_url":"https://api.github.com/repos/lendi-au/StackJanitor/issues{/number}","pulls_url":"https://api.github.com/repos/lendi-au/StackJanitor/pulls{/number}","milestones_url":"https://api.github.com/repos/lendi-au/StackJanitor/milestones{/number}","notifications_url":"https://api.github.com/repos/lendi-au/StackJanitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lendi-au/StackJanitor/labels{/name}","releases_url":"https://api.github.com/repos/lendi-au/StackJanitor/releases{/id}","deployments_url":"https://api.github.com/repos/lendi-au/StackJanitor/deployments","created_at":"2019-07-22T00:44:47Z","updated_at":"2019-08-12T00:34:37Z","pushed_at":"2019-08-13T05:44:42Z","git_url":"git://github.com/lendi-au/StackJanitor.git","ssh_url":"[email protected]:lendi-au/StackJanitor.git","clone_url":"https://github.com/lendi-au/StackJanitor.git","svn_url":"https://github.com/lendi-au/StackJanitor","homepage":null,"size":207,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"lendi-au:master","ref":"master","sha":"228707b63491f2a390a50cb56e04c818fd1cc71e","user":{"login":"lendi-au","id":47421454,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NDIxNDU0","avatar_url":"https://avatars2.githubusercontent.com/u/47421454?v=4","gravatar_id":"","url":"https://api.github.com/users/lendi-au","html_url":"https://github.com/lendi-au","followers_url":"https://api.github.com/users/lendi-au/followers","following_url":"https://api.github.com/users/lendi-au/following{/other_user}","gists_url":"https://api.github.com/users/lendi-au/gists{/gist_id}","starred_url":"https://api.github.com/users/lendi-au/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lendi-au/subscriptions","organizations_url":"https://api.github.com/users/lendi-au/orgs","repos_url":"https://api.github.com/users/lendi-au/repos","events_url":"https://api.github.com/users/lendi-au/events{/privacy}","received_events_url":"https://api.github.com/users/lendi-au/received_events","type":"Organization","site_admin":false},"repo":{"id":198120424,"node_id":"MDEwOlJlcG9zaXRvcnkxOTgxMjA0MjQ=","name":"StackJanitor","full_name":"lendi-au/StackJanitor","private":false,"owner":{"login":"lendi-au","id":47421454,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NDIxNDU0","avatar_url":"https://avatars2.githubusercontent.com/u/47421454?v=4","gravatar_id":"","url":"https://api.github.com/users/lendi-au","html_url":"https://github.com/lendi-au","followers_url":"https://api.github.com/users/lendi-au/followers","following_url":"https://api.github.com/users/lendi-au/following{/other_user}","gists_url":"https://api.github.com/users/lendi-au/gists{/gist_id}","starred_url":"https://api.github.com/users/lendi-au/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lendi-au/subscriptions","organizations_url":"https://api.github.com/users/lendi-au/orgs","repos_url":"https://api.github.com/users/lendi-au/repos","events_url":"https://api.github.com/users/lendi-au/events{/privacy}","received_events_url":"https://api.github.com/users/lendi-au/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lendi-au/StackJanitor","description":"StackJanitor cleans up CloudFormation stacks based on TTL and tags.","fork":false,"url":"https://api.github.com/repos/lendi-au/StackJanitor","forks_url":"https://api.github.com/repos/lendi-au/StackJanitor/forks","keys_url":"https://api.github.com/repos/lendi-au/StackJanitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lendi-au/StackJanitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lendi-au/StackJanitor/teams","hooks_url":"https://api.github.com/repos/lendi-au/StackJanitor/hooks","issue_events_url":"https://api.github.com/repos/lendi-au/StackJanitor/issues/events{/number}","events_url":"https://api.github.com/repos/lendi-au/StackJanitor/events","assignees_url":"https://api.github.com/repos/lendi-au/StackJanitor/assignees{/user}","branches_url":"https://api.github.com/repos/lendi-au/StackJanitor/branches{/branch}","tags_url":"https://api.github.com/repos/lendi-au/StackJanitor/tags","blobs_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lendi-au/StackJanitor/statuses/{sha}","languages_url":"https://api.github.com/repos/lendi-au/StackJanitor/languages","stargazers_url":"https://api.github.com/repos/lendi-au/StackJanitor/stargazers","contributors_url":"https://api.github.com/repos/lendi-au/StackJanitor/contributors","subscribers_url":"https://api.github.com/repos/lendi-au/StackJanitor/subscribers","subscription_url":"https://api.github.com/repos/lendi-au/StackJanitor/subscription","commits_url":"https://api.github.com/repos/lendi-au/StackJanitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/lendi-au/StackJanitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/lendi-au/StackJanitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/lendi-au/StackJanitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/lendi-au/StackJanitor/contents/{+path}","compare_url":"https://api.github.com/repos/lendi-au/StackJanitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lendi-au/StackJanitor/merges","archive_url":"https://api.github.com/repos/lendi-au/StackJanitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lendi-au/StackJanitor/downloads","issues_url":"https://api.github.com/repos/lendi-au/StackJanitor/issues{/number}","pulls_url":"https://api.github.com/repos/lendi-au/StackJanitor/pulls{/number}","milestones_url":"https://api.github.com/repos/lendi-au/StackJanitor/milestones{/number}","notifications_url":"https://api.github.com/repos/lendi-au/StackJanitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lendi-au/StackJanitor/labels{/name}","releases_url":"https://api.github.com/repos/lendi-au/StackJanitor/releases{/id}","deployments_url":"https://api.github.com/repos/lendi-au/StackJanitor/deployments","created_at":"2019-07-22T00:44:47Z","updated_at":"2019-08-12T00:34:37Z","pushed_at":"2019-08-13T05:44:42Z","git_url":"git://github.com/lendi-au/StackJanitor.git","ssh_url":"[email protected]:lendi-au/StackJanitor.git","clone_url":"https://github.com/lendi-au/StackJanitor.git","svn_url":"https://github.com/lendi-au/StackJanitor","homepage":null,"size":207,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/9"},"html":{"href":"https://github.com/lendi-au/StackJanitor/pull/9"},"issue":{"href":"https://api.github.com/repos/lendi-au/StackJanitor/issues/9"},"comments":{"href":"https://api.github.com/repos/lendi-au/StackJanitor/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lendi-au/StackJanitor/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/lendi-au/StackJanitor/statuses/825f17417de7b2345581098e659eb0f3acb249c6"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 198120424,
"name": "lendi-au/StackJanitor",
"url": "https://api.github.com/repos/lendi-au/StackJanitor"
}
|
{
"id": 536174,
"login": "perception30",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/536174?",
"url": "https://api.github.com/users/perception30"
}
|
{
"id": 47421454,
"login": "lendi-au",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47421454?",
"url": "https://api.github.com/orgs/lendi-au"
}
| 2019-08-13T05:45:15 |
10198536801
|
{"actor":{"display_login":"perception30"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tektoncd/cli/pulls/comments/280385122","pull_request_review_id":232964138,"id":280385122,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDM4NTEyMg==","diff_hunk":"@@ -1,24 +1,83 @@\n package pipeline\n \n import (\n+\t\"bytes\"\n+\t\"strings\"\n \t\"testing\"\n \n+\t\"github.com/google/go-cmp/cmp\"\n+\t\"github.com/spf13/cobra\"\n+\t\"github.com/tektoncd/cli/pkg/cli\"\n \t\"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1alpha1\"\n+\t\"github.com/tektoncd/pipeline/pkg/client/clientset/versioned\"\n \t\"github.com/tektoncd/pipeline/test\"\n \ttb \"github.com/tektoncd/pipeline/test/builder\"\n )\n \n+type TestParams struct {","path":"pkg/cmd/pipeline/list_test.go","position":17,"original_position":17,"commit_id":"7554e059c61e81521a62ba1dca584347178792e4","original_commit_id":"7554e059c61e81521a62ba1dca584347178792e4","user":{"login":"piyush-garg","id":19270240,"node_id":"MDQ6VXNlcjE5MjcwMjQw","avatar_url":"https://avatars1.githubusercontent.com/u/19270240?v=4","gravatar_id":"","url":"https://api.github.com/users/piyush-garg","html_url":"https://github.com/piyush-garg","followers_url":"https://api.github.com/users/piyush-garg/followers","following_url":"https://api.github.com/users/piyush-garg/following{/other_user}","gists_url":"https://api.github.com/users/piyush-garg/gists{/gist_id}","starred_url":"https://api.github.com/users/piyush-garg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piyush-garg/subscriptions","organizations_url":"https://api.github.com/users/piyush-garg/orgs","repos_url":"https://api.github.com/users/piyush-garg/repos","events_url":"https://api.github.com/users/piyush-garg/events{/privacy}","received_events_url":"https://api.github.com/users/piyush-garg/received_events","type":"User","site_admin":false},"body":"can we put these in some common package to reuse in other tests","created_at":"2019-05-02T11:53:54Z","updated_at":"2019-05-02T11:53:55Z","html_url":"https://github.com/tektoncd/cli/pull/18#discussion_r280385122","pull_request_url":"https://api.github.com/repos/tektoncd/cli/pulls/18","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tektoncd/cli/pulls/comments/280385122"},"html":{"href":"https://github.com/tektoncd/cli/pull/18#discussion_r280385122"},"pull_request":{"href":"https://api.github.com/repos/tektoncd/cli/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/tektoncd/cli/pulls/18","id":275312179,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1MzEyMTc5","html_url":"https://github.com/tektoncd/cli/pull/18","diff_url":"https://github.com/tektoncd/cli/pull/18.diff","patch_url":"https://github.com/tektoncd/cli/pull/18.patch","issue_url":"https://api.github.com/repos/tektoncd/cli/issues/18","number":18,"state":"open","locked":false,"title":"Add test for pipeline list","user":{"login":"sthaha","id":3005132,"node_id":"MDQ6VXNlcjMwMDUxMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3005132?v=4","gravatar_id":"","url":"https://api.github.com/users/sthaha","html_url":"https://github.com/sthaha","followers_url":"https://api.github.com/users/sthaha/followers","following_url":"https://api.github.com/users/sthaha/following{/other_user}","gists_url":"https://api.github.com/users/sthaha/gists{/gist_id}","starred_url":"https://api.github.com/users/sthaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthaha/subscriptions","organizations_url":"https://api.github.com/users/sthaha/orgs","repos_url":"https://api.github.com/users/sthaha/repos","events_url":"https://api.github.com/users/sthaha/events{/privacy}","received_events_url":"https://api.github.com/users/sthaha/received_events","type":"User","site_admin":false},"body":"\r\n<!-- ๐๐๐ Thank you for the PR!!! ๐๐๐ -->\r\n\r\n# Changes\r\nAdds TestPipelineList test to validate if `pipeline list -n foo`\r\nreturns expected output\r\n\r\nSigned-off-by: [email protected]\r\n\r\n\r\n# Submitter Checklist\r\n\r\nThese are the criteria that every PR should meet, please check them off as you\r\nreview them:\r\n\r\n- [x] Includes [tests](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if functionality changed/added)\r\n- [ ] Includes [docs](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if user facing)\r\n- [x] Commit messages follow [commit message best practices](https://github.com/tektoncd/community/blob/master/standards.md#commit-messages)\r\n\r\n_See [the contribution guide](https://github.com/tektoncd/pipeline/blob/master/CONTRIBUTING.md)\r\nfor more details._\r\n\r\n# Release Notes\r\n\r\n<!--\r\nDoes your PR contain User facing changes?\r\n\r\nIf so, briefly describe them here so we can include this description in the\r\nrelease notes for the next release!\r\n-->\r\n\r\n```\r\nrelease-note\r\n```\r\n","created_at":"2019-05-02T10:42:05Z","updated_at":"2019-05-02T11:53:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9713b690c4d311de746e4f59f2cd788f9c092e8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},{"login":"chmouel","id":98980,"node_id":"MDQ6VXNlcjk4OTgw","avatar_url":"https://avatars2.githubusercontent.com/u/98980?v=4","gravatar_id":"","url":"https://api.github.com/users/chmouel","html_url":"https://github.com/chmouel","followers_url":"https://api.github.com/users/chmouel/followers","following_url":"https://api.github.com/users/chmouel/following{/other_user}","gists_url":"https://api.github.com/users/chmouel/gists{/gist_id}","starred_url":"https://api.github.com/users/chmouel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chmouel/subscriptions","organizations_url":"https://api.github.com/users/chmouel/orgs","repos_url":"https://api.github.com/users/chmouel/repos","events_url":"https://api.github.com/users/chmouel/events{/privacy}","received_events_url":"https://api.github.com/users/chmouel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1324643976,"node_id":"MDU6TGFiZWwxMzI0NjQzOTc2","url":"https://api.github.com/repos/tektoncd/cli/labels/approved","name":"approved","color":"abea59","default":false},{"id":1333809654,"node_id":"MDU6TGFiZWwxMzMzODA5NjU0","url":"https://api.github.com/repos/tektoncd/cli/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":1344517653,"node_id":"MDU6TGFiZWwxMzQ0NTE3NjUz","url":"https://api.github.com/repos/tektoncd/cli/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tektoncd/cli/pulls/18/commits","review_comments_url":"https://api.github.com/repos/tektoncd/cli/pulls/18/comments","review_comment_url":"https://api.github.com/repos/tektoncd/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tektoncd/cli/issues/18/comments","statuses_url":"https://api.github.com/repos/tektoncd/cli/statuses/7554e059c61e81521a62ba1dca584347178792e4","head":{"label":"sthaha:pipeline-test","ref":"pipeline-test","sha":"7554e059c61e81521a62ba1dca584347178792e4","user":{"login":"sthaha","id":3005132,"node_id":"MDQ6VXNlcjMwMDUxMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3005132?v=4","gravatar_id":"","url":"https://api.github.com/users/sthaha","html_url":"https://github.com/sthaha","followers_url":"https://api.github.com/users/sthaha/followers","following_url":"https://api.github.com/users/sthaha/following{/other_user}","gists_url":"https://api.github.com/users/sthaha/gists{/gist_id}","starred_url":"https://api.github.com/users/sthaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthaha/subscriptions","organizations_url":"https://api.github.com/users/sthaha/orgs","repos_url":"https://api.github.com/users/sthaha/repos","events_url":"https://api.github.com/users/sthaha/events{/privacy}","received_events_url":"https://api.github.com/users/sthaha/received_events","type":"User","site_admin":false},"repo":{"id":181993836,"node_id":"MDEwOlJlcG9zaXRvcnkxODE5OTM4MzY=","name":"cli","full_name":"sthaha/cli","private":false,"owner":{"login":"sthaha","id":3005132,"node_id":"MDQ6VXNlcjMwMDUxMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3005132?v=4","gravatar_id":"","url":"https://api.github.com/users/sthaha","html_url":"https://github.com/sthaha","followers_url":"https://api.github.com/users/sthaha/followers","following_url":"https://api.github.com/users/sthaha/following{/other_user}","gists_url":"https://api.github.com/users/sthaha/gists{/gist_id}","starred_url":"https://api.github.com/users/sthaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthaha/subscriptions","organizations_url":"https://api.github.com/users/sthaha/orgs","repos_url":"https://api.github.com/users/sthaha/repos","events_url":"https://api.github.com/users/sthaha/events{/privacy}","received_events_url":"https://api.github.com/users/sthaha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sthaha/cli","description":"A CLI for interacting with Tekton!","fork":true,"url":"https://api.github.com/repos/sthaha/cli","forks_url":"https://api.github.com/repos/sthaha/cli/forks","keys_url":"https://api.github.com/repos/sthaha/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sthaha/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sthaha/cli/teams","hooks_url":"https://api.github.com/repos/sthaha/cli/hooks","issue_events_url":"https://api.github.com/repos/sthaha/cli/issues/events{/number}","events_url":"https://api.github.com/repos/sthaha/cli/events","assignees_url":"https://api.github.com/repos/sthaha/cli/assignees{/user}","branches_url":"https://api.github.com/repos/sthaha/cli/branches{/branch}","tags_url":"https://api.github.com/repos/sthaha/cli/tags","blobs_url":"https://api.github.com/repos/sthaha/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sthaha/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sthaha/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/sthaha/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sthaha/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/sthaha/cli/languages","stargazers_url":"https://api.github.com/repos/sthaha/cli/stargazers","contributors_url":"https://api.github.com/repos/sthaha/cli/contributors","subscribers_url":"https://api.github.com/repos/sthaha/cli/subscribers","subscription_url":"https://api.github.com/repos/sthaha/cli/subscription","commits_url":"https://api.github.com/repos/sthaha/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/sthaha/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/sthaha/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/sthaha/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/sthaha/cli/contents/{+path}","compare_url":"https://api.github.com/repos/sthaha/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sthaha/cli/merges","archive_url":"https://api.github.com/repos/sthaha/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sthaha/cli/downloads","issues_url":"https://api.github.com/repos/sthaha/cli/issues{/number}","pulls_url":"https://api.github.com/repos/sthaha/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/sthaha/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/sthaha/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sthaha/cli/labels{/name}","releases_url":"https://api.github.com/repos/sthaha/cli/releases{/id}","deployments_url":"https://api.github.com/repos/sthaha/cli/deployments","created_at":"2019-04-18T01:22:10Z","updated_at":"2019-04-18T01:22:12Z","pushed_at":"2019-05-02T10:43:21Z","git_url":"git://github.com/sthaha/cli.git","ssh_url":"[email protected]:sthaha/cli.git","clone_url":"https://github.com/sthaha/cli.git","svn_url":"https://github.com/sthaha/cli","homepage":null,"size":6466,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tektoncd:master","ref":"master","sha":"a9b058020a0967cc07818e9282b6bd8b0023d9c2","user":{"login":"tektoncd","id":47602533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjAyNTMz","avatar_url":"https://avatars3.githubusercontent.com/u/47602533?v=4","gravatar_id":"","url":"https://api.github.com/users/tektoncd","html_url":"https://github.com/tektoncd","followers_url":"https://api.github.com/users/tektoncd/followers","following_url":"https://api.github.com/users/tektoncd/following{/other_user}","gists_url":"https://api.github.com/users/tektoncd/gists{/gist_id}","starred_url":"https://api.github.com/users/tektoncd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tektoncd/subscriptions","organizations_url":"https://api.github.com/users/tektoncd/orgs","repos_url":"https://api.github.com/users/tektoncd/repos","events_url":"https://api.github.com/users/tektoncd/events{/privacy}","received_events_url":"https://api.github.com/users/tektoncd/received_events","type":"Organization","site_admin":false},"repo":{"id":181939372,"node_id":"MDEwOlJlcG9zaXRvcnkxODE5MzkzNzI=","name":"cli","full_name":"tektoncd/cli","private":false,"owner":{"login":"tektoncd","id":47602533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjAyNTMz","avatar_url":"https://avatars3.githubusercontent.com/u/47602533?v=4","gravatar_id":"","url":"https://api.github.com/users/tektoncd","html_url":"https://github.com/tektoncd","followers_url":"https://api.github.com/users/tektoncd/followers","following_url":"https://api.github.com/users/tektoncd/following{/other_user}","gists_url":"https://api.github.com/users/tektoncd/gists{/gist_id}","starred_url":"https://api.github.com/users/tektoncd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tektoncd/subscriptions","organizations_url":"https://api.github.com/users/tektoncd/orgs","repos_url":"https://api.github.com/users/tektoncd/repos","events_url":"https://api.github.com/users/tektoncd/events{/privacy}","received_events_url":"https://api.github.com/users/tektoncd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tektoncd/cli","description":"A CLI for interacting with Tekton!","fork":false,"url":"https://api.github.com/repos/tektoncd/cli","forks_url":"https://api.github.com/repos/tektoncd/cli/forks","keys_url":"https://api.github.com/repos/tektoncd/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tektoncd/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tektoncd/cli/teams","hooks_url":"https://api.github.com/repos/tektoncd/cli/hooks","issue_events_url":"https://api.github.com/repos/tektoncd/cli/issues/events{/number}","events_url":"https://api.github.com/repos/tektoncd/cli/events","assignees_url":"https://api.github.com/repos/tektoncd/cli/assignees{/user}","branches_url":"https://api.github.com/repos/tektoncd/cli/branches{/branch}","tags_url":"https://api.github.com/repos/tektoncd/cli/tags","blobs_url":"https://api.github.com/repos/tektoncd/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tektoncd/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tektoncd/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/tektoncd/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tektoncd/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/tektoncd/cli/languages","stargazers_url":"https://api.github.com/repos/tektoncd/cli/stargazers","contributors_url":"https://api.github.com/repos/tektoncd/cli/contributors","subscribers_url":"https://api.github.com/repos/tektoncd/cli/subscribers","subscription_url":"https://api.github.com/repos/tektoncd/cli/subscription","commits_url":"https://api.github.com/repos/tektoncd/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/tektoncd/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/tektoncd/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/tektoncd/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/tektoncd/cli/contents/{+path}","compare_url":"https://api.github.com/repos/tektoncd/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tektoncd/cli/merges","archive_url":"https://api.github.com/repos/tektoncd/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tektoncd/cli/downloads","issues_url":"https://api.github.com/repos/tektoncd/cli/issues{/number}","pulls_url":"https://api.github.com/repos/tektoncd/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/tektoncd/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/tektoncd/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tektoncd/cli/labels{/name}","releases_url":"https://api.github.com/repos/tektoncd/cli/releases{/id}","deployments_url":"https://api.github.com/repos/tektoncd/cli/deployments","created_at":"2019-04-17T17:33:25Z","updated_at":"2019-05-02T09:03:58Z","pushed_at":"2019-05-02T10:43:22Z","git_url":"git://github.com/tektoncd/cli.git","ssh_url":"[email protected]:tektoncd/cli.git","clone_url":"https://github.com/tektoncd/cli.git","svn_url":"https://github.com/tektoncd/cli","homepage":null,"size":6445,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":12,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tektoncd/cli/pulls/18"},"html":{"href":"https://github.com/tektoncd/cli/pull/18"},"issue":{"href":"https://api.github.com/repos/tektoncd/cli/issues/18"},"comments":{"href":"https://api.github.com/repos/tektoncd/cli/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/tektoncd/cli/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/tektoncd/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tektoncd/cli/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/tektoncd/cli/statuses/7554e059c61e81521a62ba1dca584347178792e4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 181939372,
"name": "tektoncd/cli",
"url": "https://api.github.com/repos/tektoncd/cli"
}
|
{
"id": 19270240,
"login": "piyush-garg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19270240?",
"url": "https://api.github.com/users/piyush-garg"
}
|
{
"id": 47602533,
"login": "tektoncd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47602533?",
"url": "https://api.github.com/orgs/tektoncd"
}
| 2019-05-02T11:53:54 |
9550355978
|
{"actor":{"display_login":"piyush-garg"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/openenclave/openenclave/pulls/comments/319302091","pull_request_review_id":281760462,"id":319302091,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxOTMwMjA5MQ==","diff_hunk":"@@ -0,0 +1,127 @@\n+# Getting Started with Open Enclave on Windows with SGX1-FLC mode\n+\n+## Platform requirements\n+\n+The following are prerequisites for building and running Open Enclave on\n+Windows.\n+\n+- Intelยฎ X86-64bit architecture with SGX1 or SGX2\n+- A version of Windows OS with native support for SGX features:\n+ - For server: Windows Server 2016 (or newer)\n+ - For client: Windows 10 64-bit with Fall Creators Update (1709) or newer\n+\n+## Install Git and Clone the Open Enclave SDK repo\n+\n+Download and install Git for Windows from [here](https://git-scm.com/download/win)\n+\n+Clone the Open Enclave SDK\n+\n+```powershell\n+cd c:\\\n+git clone https://github.com/openenclave/openenclave\n+```\n+\n+This creates a source tree under the directory called openenclave.\n+\n+## Install project prerequisites\n+\n+First, change directory into the openenclave repository:\n+\n+```powershell\n+cd openenclave\n+```\n+\n+To deploy all the prerequisities for building Open Enclave including Intel's DCAP primitives and Azure's DCAP library, you can run the following from powershell.\n+\n+```powershell\n+cd scripts\n+.\\install-windows-prereqs.ps1 -InstallPath PATH_TO_OE_REPO -WithFLC $false\n+```\n+\n+As an example, if you cloned Open Enclave SDK repo into c:\\openenclave, you would run the following\n+\n+```powershell\n+cd scripts\n+.\\install-windows-prereqs.ps1 -InstallPath c:\\openenclave -WithFLC $false\n+```\n+\n+If you prefer to manually install prerequisites, please refer to this [document](WindowsManualInstallPrereqs.md).\n+\n+## Intelยฎ SGX Platform Software for Windows (PSW)\n+\n+The PSW should be installed automatically on Windows 10 with the Fall Creators\n+Update installed, or on a Windows Server 2016 image for an Azure Confidential\n+Compute VM. You can verify that is the case on the command line as follows:\n+\n+```cmd\n+sc query aesmservice\n+```\n+\n+The state of the service should be \"running\" (4). Follow Intel's documentation for troubleshooting.\n+\n+Note that Open Enclave is only compatible with the Intel PSW 2.2.\n+To use Intel PSW 2.3 and higher, please refer _Building with Intel Data Center Attestation\n+Primitives (DCAP) libraries_ below.\n+\n+## Building on Windows using Developer Command Prompt\n+\n+1. Launch the [x64 Native Tools Command Prompt for VS 2017](\n+https://docs.microsoft.com/en-us/dotnet/framework/tools/developer-command-prompt-for-vs)\n+Normally this is accessible under the `Visual Studio 2017` folder in the Start Menu.","path":"docs/GettingStartedDocs/Contributors/WindowsSXG1GettingStarted.md","position":70,"original_position":70,"commit_id":"8fdb57c24a9eca7108612f3deabb1f64417135ce","original_commit_id":"8fdb57c24a9eca7108612f3deabb1f64417135ce","user":{"login":"jazzybluesea","id":31323795,"node_id":"MDQ6VXNlcjMxMzIzNzk1","avatar_url":"https://avatars0.githubusercontent.com/u/31323795?v=4","gravatar_id":"","url":"https://api.github.com/users/jazzybluesea","html_url":"https://github.com/jazzybluesea","followers_url":"https://api.github.com/users/jazzybluesea/followers","following_url":"https://api.github.com/users/jazzybluesea/following{/other_user}","gists_url":"https://api.github.com/users/jazzybluesea/gists{/gist_id}","starred_url":"https://api.github.com/users/jazzybluesea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jazzybluesea/subscriptions","organizations_url":"https://api.github.com/users/jazzybluesea/orgs","repos_url":"https://api.github.com/users/jazzybluesea/repos","events_url":"https://api.github.com/users/jazzybluesea/events{/privacy}","received_events_url":"https://api.github.com/users/jazzybluesea/received_events","type":"User","site_admin":false},"body":"Yes, I can confirm this works if you installed the native tools installer.","created_at":"2019-08-29T22:51:27Z","updated_at":"2019-08-29T22:51:27Z","html_url":"https://github.com/openenclave/openenclave/pull/2127#discussion_r319302091","pull_request_url":"https://api.github.com/repos/openenclave/openenclave/pulls/2127","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openenclave/openenclave/pulls/comments/319302091"},"html":{"href":"https://github.com/openenclave/openenclave/pull/2127#discussion_r319302091"},"pull_request":{"href":"https://api.github.com/repos/openenclave/openenclave/pulls/2127"}},"in_reply_to_id":319219498},"pull_request":{"url":"https://api.github.com/repos/openenclave/openenclave/pulls/2127","id":311029125,"node_id":"MDExOlB1bGxSZXF1ZXN0MzExMDI5MTI1","html_url":"https://github.com/openenclave/openenclave/pull/2127","diff_url":"https://github.com/openenclave/openenclave/pull/2127.diff","patch_url":"https://github.com/openenclave/openenclave/pull/2127.patch","issue_url":"https://api.github.com/repos/openenclave/openenclave/issues/2127","number":2127,"state":"open","locked":false,"title":"Reorganizing Windows documentation to separate steps required for SGX1 mode and SGX1+FLC mode","user":{"login":"radhikaj","id":6453577,"node_id":"MDQ6VXNlcjY0NTM1Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6453577?v=4","gravatar_id":"","url":"https://api.github.com/users/radhikaj","html_url":"https://github.com/radhikaj","followers_url":"https://api.github.com/users/radhikaj/followers","following_url":"https://api.github.com/users/radhikaj/following{/other_user}","gists_url":"https://api.github.com/users/radhikaj/gists{/gist_id}","starred_url":"https://api.github.com/users/radhikaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radhikaj/subscriptions","organizations_url":"https://api.github.com/users/radhikaj/orgs","repos_url":"https://api.github.com/users/radhikaj/repos","events_url":"https://api.github.com/users/radhikaj/events{/privacy}","received_events_url":"https://api.github.com/users/radhikaj/received_events","type":"User","site_admin":false},"body":"Reorganizing Windows documentation to follow the thread of the Linux documentation. \r\n1. Separated installation on Windows SGX1 and SGX1+FLC\r\n2. Separated Manual installation docs and manual installation for SGX1 and SGX1+FLC","created_at":"2019-08-26T18:24:21Z","updated_at":"2019-08-29T22:51:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a5eb34b16afebbaefe8395658e58e77393b4672","assignee":null,"assignees":[],"requested_reviewers":[{"login":"soccerGB","id":19215578,"node_id":"MDQ6VXNlcjE5MjE1NTc4","avatar_url":"https://avatars2.githubusercontent.com/u/19215578?v=4","gravatar_id":"","url":"https://api.github.com/users/soccerGB","html_url":"https://github.com/soccerGB","followers_url":"https://api.github.com/users/soccerGB/followers","following_url":"https://api.github.com/users/soccerGB/following{/other_user}","gists_url":"https://api.github.com/users/soccerGB/gists{/gist_id}","starred_url":"https://api.github.com/users/soccerGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soccerGB/subscriptions","organizations_url":"https://api.github.com/users/soccerGB/orgs","repos_url":"https://api.github.com/users/soccerGB/repos","events_url":"https://api.github.com/users/soccerGB/events{/privacy}","received_events_url":"https://api.github.com/users/soccerGB/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":757272671,"node_id":"MDU6TGFiZWw3NTcyNzI2NzE=","url":"https://api.github.com/repos/openenclave/openenclave/labels/documentation","name":"documentation","color":"bfd4f2","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/openenclave/openenclave/pulls/2127/commits","review_comments_url":"https://api.github.com/repos/openenclave/openenclave/pulls/2127/comments","review_comment_url":"https://api.github.com/repos/openenclave/openenclave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openenclave/openenclave/issues/2127/comments","statuses_url":"https://api.github.com/repos/openenclave/openenclave/statuses/8fdb57c24a9eca7108612f3deabb1f64417135ce","head":{"label":"openenclave:radhikaj/reogwindowsdocs","ref":"radhikaj/reogwindowsdocs","sha":"8fdb57c24a9eca7108612f3deabb1f64417135ce","user":{"login":"openenclave","id":47616719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjE2NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/47616719?v=4","gravatar_id":"","url":"https://api.github.com/users/openenclave","html_url":"https://github.com/openenclave","followers_url":"https://api.github.com/users/openenclave/followers","following_url":"https://api.github.com/users/openenclave/following{/other_user}","gists_url":"https://api.github.com/users/openenclave/gists{/gist_id}","starred_url":"https://api.github.com/users/openenclave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openenclave/subscriptions","organizations_url":"https://api.github.com/users/openenclave/orgs","repos_url":"https://api.github.com/users/openenclave/repos","events_url":"https://api.github.com/users/openenclave/events{/privacy}","received_events_url":"https://api.github.com/users/openenclave/received_events","type":"Organization","site_admin":false},"repo":{"id":101804230,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MDQyMzA=","name":"openenclave","full_name":"openenclave/openenclave","private":false,"owner":{"login":"openenclave","id":47616719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjE2NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/47616719?v=4","gravatar_id":"","url":"https://api.github.com/users/openenclave","html_url":"https://github.com/openenclave","followers_url":"https://api.github.com/users/openenclave/followers","following_url":"https://api.github.com/users/openenclave/following{/other_user}","gists_url":"https://api.github.com/users/openenclave/gists{/gist_id}","starred_url":"https://api.github.com/users/openenclave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openenclave/subscriptions","organizations_url":"https://api.github.com/users/openenclave/orgs","repos_url":"https://api.github.com/users/openenclave/repos","events_url":"https://api.github.com/users/openenclave/events{/privacy}","received_events_url":"https://api.github.com/users/openenclave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openenclave/openenclave","description":"SDK for developing enclaves","fork":false,"url":"https://api.github.com/repos/openenclave/openenclave","forks_url":"https://api.github.com/repos/openenclave/openenclave/forks","keys_url":"https://api.github.com/repos/openenclave/openenclave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openenclave/openenclave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openenclave/openenclave/teams","hooks_url":"https://api.github.com/repos/openenclave/openenclave/hooks","issue_events_url":"https://api.github.com/repos/openenclave/openenclave/issues/events{/number}","events_url":"https://api.github.com/repos/openenclave/openenclave/events","assignees_url":"https://api.github.com/repos/openenclave/openenclave/assignees{/user}","branches_url":"https://api.github.com/repos/openenclave/openenclave/branches{/branch}","tags_url":"https://api.github.com/repos/openenclave/openenclave/tags","blobs_url":"https://api.github.com/repos/openenclave/openenclave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openenclave/openenclave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openenclave/openenclave/git/refs{/sha}","trees_url":"https://api.github.com/repos/openenclave/openenclave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openenclave/openenclave/statuses/{sha}","languages_url":"https://api.github.com/repos/openenclave/openenclave/languages","stargazers_url":"https://api.github.com/repos/openenclave/openenclave/stargazers","contributors_url":"https://api.github.com/repos/openenclave/openenclave/contributors","subscribers_url":"https://api.github.com/repos/openenclave/openenclave/subscribers","subscription_url":"https://api.github.com/repos/openenclave/openenclave/subscription","commits_url":"https://api.github.com/repos/openenclave/openenclave/commits{/sha}","git_commits_url":"https://api.github.com/repos/openenclave/openenclave/git/commits{/sha}","comments_url":"https://api.github.com/repos/openenclave/openenclave/comments{/number}","issue_comment_url":"https://api.github.com/repos/openenclave/openenclave/issues/comments{/number}","contents_url":"https://api.github.com/repos/openenclave/openenclave/contents/{+path}","compare_url":"https://api.github.com/repos/openenclave/openenclave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openenclave/openenclave/merges","archive_url":"https://api.github.com/repos/openenclave/openenclave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openenclave/openenclave/downloads","issues_url":"https://api.github.com/repos/openenclave/openenclave/issues{/number}","pulls_url":"https://api.github.com/repos/openenclave/openenclave/pulls{/number}","milestones_url":"https://api.github.com/repos/openenclave/openenclave/milestones{/number}","notifications_url":"https://api.github.com/repos/openenclave/openenclave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openenclave/openenclave/labels{/name}","releases_url":"https://api.github.com/repos/openenclave/openenclave/releases{/id}","deployments_url":"https://api.github.com/repos/openenclave/openenclave/deployments","created_at":"2017-08-29T20:31:38Z","updated_at":"2019-08-29T22:48:24Z","pushed_at":"2019-08-29T22:51:17Z","git_url":"git://github.com/openenclave/openenclave.git","ssh_url":"[email protected]:openenclave/openenclave.git","clone_url":"https://github.com/openenclave/openenclave.git","svn_url":"https://github.com/openenclave/openenclave","homepage":"https://openenclave.io/sdk/","size":320235,"stargazers_count":256,"watchers_count":256,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":81,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":214,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":81,"open_issues":214,"watchers":256,"default_branch":"master"}},"base":{"label":"openenclave:master","ref":"master","sha":"571a1c11763e212e75349f2d032e7c190318e926","user":{"login":"openenclave","id":47616719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjE2NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/47616719?v=4","gravatar_id":"","url":"https://api.github.com/users/openenclave","html_url":"https://github.com/openenclave","followers_url":"https://api.github.com/users/openenclave/followers","following_url":"https://api.github.com/users/openenclave/following{/other_user}","gists_url":"https://api.github.com/users/openenclave/gists{/gist_id}","starred_url":"https://api.github.com/users/openenclave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openenclave/subscriptions","organizations_url":"https://api.github.com/users/openenclave/orgs","repos_url":"https://api.github.com/users/openenclave/repos","events_url":"https://api.github.com/users/openenclave/events{/privacy}","received_events_url":"https://api.github.com/users/openenclave/received_events","type":"Organization","site_admin":false},"repo":{"id":101804230,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE4MDQyMzA=","name":"openenclave","full_name":"openenclave/openenclave","private":false,"owner":{"login":"openenclave","id":47616719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjE2NzE5","avatar_url":"https://avatars1.githubusercontent.com/u/47616719?v=4","gravatar_id":"","url":"https://api.github.com/users/openenclave","html_url":"https://github.com/openenclave","followers_url":"https://api.github.com/users/openenclave/followers","following_url":"https://api.github.com/users/openenclave/following{/other_user}","gists_url":"https://api.github.com/users/openenclave/gists{/gist_id}","starred_url":"https://api.github.com/users/openenclave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openenclave/subscriptions","organizations_url":"https://api.github.com/users/openenclave/orgs","repos_url":"https://api.github.com/users/openenclave/repos","events_url":"https://api.github.com/users/openenclave/events{/privacy}","received_events_url":"https://api.github.com/users/openenclave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openenclave/openenclave","description":"SDK for developing enclaves","fork":false,"url":"https://api.github.com/repos/openenclave/openenclave","forks_url":"https://api.github.com/repos/openenclave/openenclave/forks","keys_url":"https://api.github.com/repos/openenclave/openenclave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openenclave/openenclave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openenclave/openenclave/teams","hooks_url":"https://api.github.com/repos/openenclave/openenclave/hooks","issue_events_url":"https://api.github.com/repos/openenclave/openenclave/issues/events{/number}","events_url":"https://api.github.com/repos/openenclave/openenclave/events","assignees_url":"https://api.github.com/repos/openenclave/openenclave/assignees{/user}","branches_url":"https://api.github.com/repos/openenclave/openenclave/branches{/branch}","tags_url":"https://api.github.com/repos/openenclave/openenclave/tags","blobs_url":"https://api.github.com/repos/openenclave/openenclave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openenclave/openenclave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openenclave/openenclave/git/refs{/sha}","trees_url":"https://api.github.com/repos/openenclave/openenclave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openenclave/openenclave/statuses/{sha}","languages_url":"https://api.github.com/repos/openenclave/openenclave/languages","stargazers_url":"https://api.github.com/repos/openenclave/openenclave/stargazers","contributors_url":"https://api.github.com/repos/openenclave/openenclave/contributors","subscribers_url":"https://api.github.com/repos/openenclave/openenclave/subscribers","subscription_url":"https://api.github.com/repos/openenclave/openenclave/subscription","commits_url":"https://api.github.com/repos/openenclave/openenclave/commits{/sha}","git_commits_url":"https://api.github.com/repos/openenclave/openenclave/git/commits{/sha}","comments_url":"https://api.github.com/repos/openenclave/openenclave/comments{/number}","issue_comment_url":"https://api.github.com/repos/openenclave/openenclave/issues/comments{/number}","contents_url":"https://api.github.com/repos/openenclave/openenclave/contents/{+path}","compare_url":"https://api.github.com/repos/openenclave/openenclave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openenclave/openenclave/merges","archive_url":"https://api.github.com/repos/openenclave/openenclave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openenclave/openenclave/downloads","issues_url":"https://api.github.com/repos/openenclave/openenclave/issues{/number}","pulls_url":"https://api.github.com/repos/openenclave/openenclave/pulls{/number}","milestones_url":"https://api.github.com/repos/openenclave/openenclave/milestones{/number}","notifications_url":"https://api.github.com/repos/openenclave/openenclave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openenclave/openenclave/labels{/name}","releases_url":"https://api.github.com/repos/openenclave/openenclave/releases{/id}","deployments_url":"https://api.github.com/repos/openenclave/openenclave/deployments","created_at":"2017-08-29T20:31:38Z","updated_at":"2019-08-29T22:48:24Z","pushed_at":"2019-08-29T22:51:17Z","git_url":"git://github.com/openenclave/openenclave.git","ssh_url":"[email protected]:openenclave/openenclave.git","clone_url":"https://github.com/openenclave/openenclave.git","svn_url":"https://github.com/openenclave/openenclave","homepage":"https://openenclave.io/sdk/","size":320235,"stargazers_count":256,"watchers_count":256,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":81,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":214,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":81,"open_issues":214,"watchers":256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openenclave/openenclave/pulls/2127"},"html":{"href":"https://github.com/openenclave/openenclave/pull/2127"},"issue":{"href":"https://api.github.com/repos/openenclave/openenclave/issues/2127"},"comments":{"href":"https://api.github.com/repos/openenclave/openenclave/issues/2127/comments"},"review_comments":{"href":"https://api.github.com/repos/openenclave/openenclave/pulls/2127/comments"},"review_comment":{"href":"https://api.github.com/repos/openenclave/openenclave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openenclave/openenclave/pulls/2127/commits"},"statuses":{"href":"https://api.github.com/repos/openenclave/openenclave/statuses/8fdb57c24a9eca7108612f3deabb1f64417135ce"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 101804230,
"name": "openenclave/openenclave",
"url": "https://api.github.com/repos/openenclave/openenclave"
}
|
{
"id": 31323795,
"login": "jazzybluesea",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31323795?",
"url": "https://api.github.com/users/jazzybluesea"
}
|
{
"id": 47616719,
"login": "openenclave",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47616719?",
"url": "https://api.github.com/orgs/openenclave"
}
| 2019-08-29T22:51:27 |
10313446758
|
{"actor":{"display_login":"jazzybluesea"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/comments/259644269","pull_request_review_id":207175727,"id":259644269,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTY0NDI2OQ==","diff_hunk":"@@ -1,27 +1,42 @@\n 'use strict'\n-const db = require('../database/db-connection')\n+\n+const quries = require('../database/quries')\n \n module.exports = function(app) {\n app.get('/', getUserRoot)\n- app.get('/categories', getCategories)\n- app.get('/category/:id', getCategory)\n- app.post('/link/add', postLink)\n+ app.get('/categories', getCatgories)\n+ app.get('/category/:id', isValidId, getCategoryTuple)\n+ app.post('/link/add', addLink)\n }\n \n function getUserRoot(req, res) {\n res.sendFile('/Endpoints.html', { root: '.' })\n }\n \n-function getCategories(req, res) {\n- res.status(200).send([])\n+function getCatgories(req, res) {\n+ quries.getAll('categories').then(categories => {\n+ res.json(categories)\n+ })","path":"controllers/users.js","position":25,"original_position":25,"commit_id":"dfd2e498efbff67ed8142f619ce18746cac87639","original_commit_id":"dfd2e498efbff67ed8142f619ce18746cac87639","user":{"login":"kriyeng","id":3359663,"node_id":"MDQ6VXNlcjMzNTk2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3359663?v=4","gravatar_id":"","url":"https://api.github.com/users/kriyeng","html_url":"https://github.com/kriyeng","followers_url":"https://api.github.com/users/kriyeng/followers","following_url":"https://api.github.com/users/kriyeng/following{/other_user}","gists_url":"https://api.github.com/users/kriyeng/gists{/gist_id}","starred_url":"https://api.github.com/users/kriyeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriyeng/subscriptions","organizations_url":"https://api.github.com/users/kriyeng/orgs","repos_url":"https://api.github.com/users/kriyeng/repos","events_url":"https://api.github.com/users/kriyeng/events{/privacy}","received_events_url":"https://api.github.com/users/kriyeng/received_events","type":"User","site_admin":false},"body":"I'm not sure how knex works, but what happens here if there's any error?","created_at":"2019-02-24T22:26:08Z","updated_at":"2019-02-24T22:26:08Z","html_url":"https://github.com/bestfordev/BestForDev-Backend/pull/21#discussion_r259644269","pull_request_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/21","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/comments/259644269"},"html":{"href":"https://github.com/bestfordev/BestForDev-Backend/pull/21#discussion_r259644269"},"pull_request":{"href":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/21","id":255700554,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NzAwNTU0","html_url":"https://github.com/bestfordev/BestForDev-Backend/pull/21","diff_url":"https://github.com/bestfordev/BestForDev-Backend/pull/21.diff","patch_url":"https://github.com/bestfordev/BestForDev-Backend/pull/21.patch","issue_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/issues/21","number":21,"state":"open","locked":false,"title":"Database Queries for User","user":{"login":"sulemanbashir","id":31032389,"node_id":"MDQ6VXNlcjMxMDMyMzg5","avatar_url":"https://avatars1.githubusercontent.com/u/31032389?v=4","gravatar_id":"","url":"https://api.github.com/users/sulemanbashir","html_url":"https://github.com/sulemanbashir","followers_url":"https://api.github.com/users/sulemanbashir/followers","following_url":"https://api.github.com/users/sulemanbashir/following{/other_user}","gists_url":"https://api.github.com/users/sulemanbashir/gists{/gist_id}","starred_url":"https://api.github.com/users/sulemanbashir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulemanbashir/subscriptions","organizations_url":"https://api.github.com/users/sulemanbashir/orgs","repos_url":"https://api.github.com/users/sulemanbashir/repos","events_url":"https://api.github.com/users/sulemanbashir/events{/privacy}","received_events_url":"https://api.github.com/users/sulemanbashir/received_events","type":"User","site_admin":false},"body":"\" resolved #3 #4 #5 #20 \"\r\nHere I done endpoints \r\n\r\n- **/categories**\r\n- **/category/:id**\r\n- **/link/add**\r\n\r\nI did this with Knex. I used **Postman** for checking the endpoints.","created_at":"2019-02-24T17:53:22Z","updated_at":"2019-02-24T22:26:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80b07661098af5aa38a33dce1f3dd519f6f4bc8f","assignee":{"login":"sulemanbashir","id":31032389,"node_id":"MDQ6VXNlcjMxMDMyMzg5","avatar_url":"https://avatars1.githubusercontent.com/u/31032389?v=4","gravatar_id":"","url":"https://api.github.com/users/sulemanbashir","html_url":"https://github.com/sulemanbashir","followers_url":"https://api.github.com/users/sulemanbashir/followers","following_url":"https://api.github.com/users/sulemanbashir/following{/other_user}","gists_url":"https://api.github.com/users/sulemanbashir/gists{/gist_id}","starred_url":"https://api.github.com/users/sulemanbashir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulemanbashir/subscriptions","organizations_url":"https://api.github.com/users/sulemanbashir/orgs","repos_url":"https://api.github.com/users/sulemanbashir/repos","events_url":"https://api.github.com/users/sulemanbashir/events{/privacy}","received_events_url":"https://api.github.com/users/sulemanbashir/received_events","type":"User","site_admin":false},"assignees":[{"login":"sulemanbashir","id":31032389,"node_id":"MDQ6VXNlcjMxMDMyMzg5","avatar_url":"https://avatars1.githubusercontent.com/u/31032389?v=4","gravatar_id":"","url":"https://api.github.com/users/sulemanbashir","html_url":"https://github.com/sulemanbashir","followers_url":"https://api.github.com/users/sulemanbashir/followers","following_url":"https://api.github.com/users/sulemanbashir/following{/other_user}","gists_url":"https://api.github.com/users/sulemanbashir/gists{/gist_id}","starred_url":"https://api.github.com/users/sulemanbashir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulemanbashir/subscriptions","organizations_url":"https://api.github.com/users/sulemanbashir/orgs","repos_url":"https://api.github.com/users/sulemanbashir/repos","events_url":"https://api.github.com/users/sulemanbashir/events{/privacy}","received_events_url":"https://api.github.com/users/sulemanbashir/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"The24thDS","id":26633429,"node_id":"MDQ6VXNlcjI2NjMzNDI5","avatar_url":"https://avatars0.githubusercontent.com/u/26633429?v=4","gravatar_id":"","url":"https://api.github.com/users/The24thDS","html_url":"https://github.com/The24thDS","followers_url":"https://api.github.com/users/The24thDS/followers","following_url":"https://api.github.com/users/The24thDS/following{/other_user}","gists_url":"https://api.github.com/users/The24thDS/gists{/gist_id}","starred_url":"https://api.github.com/users/The24thDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The24thDS/subscriptions","organizations_url":"https://api.github.com/users/The24thDS/orgs","repos_url":"https://api.github.com/users/The24thDS/repos","events_url":"https://api.github.com/users/The24thDS/events{/privacy}","received_events_url":"https://api.github.com/users/The24thDS/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/21/commits","review_comments_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/21/comments","review_comment_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/issues/21/comments","statuses_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/statuses/dfd2e498efbff67ed8142f619ce18746cac87639","head":{"label":"sulemanbashir:feature/userDatabaseQuries","ref":"feature/userDatabaseQuries","sha":"dfd2e498efbff67ed8142f619ce18746cac87639","user":{"login":"sulemanbashir","id":31032389,"node_id":"MDQ6VXNlcjMxMDMyMzg5","avatar_url":"https://avatars1.githubusercontent.com/u/31032389?v=4","gravatar_id":"","url":"https://api.github.com/users/sulemanbashir","html_url":"https://github.com/sulemanbashir","followers_url":"https://api.github.com/users/sulemanbashir/followers","following_url":"https://api.github.com/users/sulemanbashir/following{/other_user}","gists_url":"https://api.github.com/users/sulemanbashir/gists{/gist_id}","starred_url":"https://api.github.com/users/sulemanbashir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulemanbashir/subscriptions","organizations_url":"https://api.github.com/users/sulemanbashir/orgs","repos_url":"https://api.github.com/users/sulemanbashir/repos","events_url":"https://api.github.com/users/sulemanbashir/events{/privacy}","received_events_url":"https://api.github.com/users/sulemanbashir/received_events","type":"User","site_admin":false},"repo":{"id":172309948,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIzMDk5NDg=","name":"BestForDev-Backend","full_name":"sulemanbashir/BestForDev-Backend","private":false,"owner":{"login":"sulemanbashir","id":31032389,"node_id":"MDQ6VXNlcjMxMDMyMzg5","avatar_url":"https://avatars1.githubusercontent.com/u/31032389?v=4","gravatar_id":"","url":"https://api.github.com/users/sulemanbashir","html_url":"https://github.com/sulemanbashir","followers_url":"https://api.github.com/users/sulemanbashir/followers","following_url":"https://api.github.com/users/sulemanbashir/following{/other_user}","gists_url":"https://api.github.com/users/sulemanbashir/gists{/gist_id}","starred_url":"https://api.github.com/users/sulemanbashir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulemanbashir/subscriptions","organizations_url":"https://api.github.com/users/sulemanbashir/orgs","repos_url":"https://api.github.com/users/sulemanbashir/repos","events_url":"https://api.github.com/users/sulemanbashir/events{/privacy}","received_events_url":"https://api.github.com/users/sulemanbashir/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sulemanbashir/BestForDev-Backend","description":null,"fork":true,"url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend","forks_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/forks","keys_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/teams","hooks_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/hooks","issue_events_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/issues/events{/number}","events_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/events","assignees_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/assignees{/user}","branches_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/branches{/branch}","tags_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/tags","blobs_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/statuses/{sha}","languages_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/languages","stargazers_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/stargazers","contributors_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/contributors","subscribers_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/subscribers","subscription_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/subscription","commits_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/contents/{+path}","compare_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/merges","archive_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/downloads","issues_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/issues{/number}","pulls_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/pulls{/number}","milestones_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/milestones{/number}","notifications_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/labels{/name}","releases_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/releases{/id}","deployments_url":"https://api.github.com/repos/sulemanbashir/BestForDev-Backend/deployments","created_at":"2019-02-24T07:41:41Z","updated_at":"2019-02-24T14:07:58Z","pushed_at":"2019-02-24T17:46:15Z","git_url":"git://github.com/sulemanbashir/BestForDev-Backend.git","ssh_url":"[email protected]:sulemanbashir/BestForDev-Backend.git","clone_url":"https://github.com/sulemanbashir/BestForDev-Backend.git","svn_url":"https://github.com/sulemanbashir/BestForDev-Backend","homepage":null,"size":81,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bestfordev:develop","ref":"develop","sha":"1f3496bdd4c7d8d591f3f01df8ca8a80145e7fd2","user":{"login":"bestfordev","id":47688354,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Njg4MzU0","avatar_url":"https://avatars0.githubusercontent.com/u/47688354?v=4","gravatar_id":"","url":"https://api.github.com/users/bestfordev","html_url":"https://github.com/bestfordev","followers_url":"https://api.github.com/users/bestfordev/followers","following_url":"https://api.github.com/users/bestfordev/following{/other_user}","gists_url":"https://api.github.com/users/bestfordev/gists{/gist_id}","starred_url":"https://api.github.com/users/bestfordev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestfordev/subscriptions","organizations_url":"https://api.github.com/users/bestfordev/orgs","repos_url":"https://api.github.com/users/bestfordev/repos","events_url":"https://api.github.com/users/bestfordev/events{/privacy}","received_events_url":"https://api.github.com/users/bestfordev/received_events","type":"Organization","site_admin":false},"repo":{"id":171024028,"node_id":"MDEwOlJlcG9zaXRvcnkxNzEwMjQwMjg=","name":"BestForDev-Backend","full_name":"bestfordev/BestForDev-Backend","private":false,"owner":{"login":"bestfordev","id":47688354,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Njg4MzU0","avatar_url":"https://avatars0.githubusercontent.com/u/47688354?v=4","gravatar_id":"","url":"https://api.github.com/users/bestfordev","html_url":"https://github.com/bestfordev","followers_url":"https://api.github.com/users/bestfordev/followers","following_url":"https://api.github.com/users/bestfordev/following{/other_user}","gists_url":"https://api.github.com/users/bestfordev/gists{/gist_id}","starred_url":"https://api.github.com/users/bestfordev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestfordev/subscriptions","organizations_url":"https://api.github.com/users/bestfordev/orgs","repos_url":"https://api.github.com/users/bestfordev/repos","events_url":"https://api.github.com/users/bestfordev/events{/privacy}","received_events_url":"https://api.github.com/users/bestfordev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bestfordev/BestForDev-Backend","description":null,"fork":false,"url":"https://api.github.com/repos/bestfordev/BestForDev-Backend","forks_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/forks","keys_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/teams","hooks_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/hooks","issue_events_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/issues/events{/number}","events_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/events","assignees_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/assignees{/user}","branches_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/branches{/branch}","tags_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/tags","blobs_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/statuses/{sha}","languages_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/languages","stargazers_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/stargazers","contributors_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/contributors","subscribers_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/subscribers","subscription_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/subscription","commits_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/contents/{+path}","compare_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/merges","archive_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/downloads","issues_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/issues{/number}","pulls_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls{/number}","milestones_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/milestones{/number}","notifications_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/labels{/name}","releases_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/releases{/id}","deployments_url":"https://api.github.com/repos/bestfordev/BestForDev-Backend/deployments","created_at":"2019-02-16T16:19:12Z","updated_at":"2019-02-24T12:17:58Z","pushed_at":"2019-02-24T17:53:23Z","git_url":"git://github.com/bestfordev/BestForDev-Backend.git","ssh_url":"[email protected]:bestfordev/BestForDev-Backend.git","clone_url":"https://github.com/bestfordev/BestForDev-Backend.git","svn_url":"https://github.com/bestfordev/BestForDev-Backend","homepage":null,"size":78,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":4,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/21"},"html":{"href":"https://github.com/bestfordev/BestForDev-Backend/pull/21"},"issue":{"href":"https://api.github.com/repos/bestfordev/BestForDev-Backend/issues/21"},"comments":{"href":"https://api.github.com/repos/bestfordev/BestForDev-Backend/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bestfordev/BestForDev-Backend/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/bestfordev/BestForDev-Backend/statuses/dfd2e498efbff67ed8142f619ce18746cac87639"}},"author_association":"MEMBER"}}
|
{
"id": 171024028,
"name": "bestfordev/BestForDev-Backend",
"url": "https://api.github.com/repos/bestfordev/BestForDev-Backend"
}
|
{
"id": 3359663,
"login": "kriyeng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3359663?",
"url": "https://api.github.com/users/kriyeng"
}
|
{
"id": 47688354,
"login": "bestfordev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47688354?",
"url": "https://api.github.com/orgs/bestfordev"
}
| 2019-02-24T22:26:08 |
9126553891
|
{"actor":{"display_login":"kriyeng"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/comments/325142404","pull_request_review_id":289229438,"id":325142404,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNTE0MjQwNA==","diff_hunk":"@@ -157,6 +184,87 @@ func build(projectName string, targetOS string, vmArguments []string) {\n \t} else {\n \t\tengineCachePath = enginecache.ValidateOrUpdateEngine(targetOS)\n \t}\n+\tdockerFilePath, err := filepath.Abs(filepath.Join(tmpDir, \"Dockerfile\"))\n+\tif err != nil {\n+\t\tfmt.Printf(\"hover: Failed to resolve absolute path for Dockerfile %s: %v\\n\", dockerFilePath, err)\n+\t\tos.Exit(1)\n+\t}\n+\n+\tdockerFile, err := os.Create(dockerFilePath)\n+\tif err != nil {\n+\t\tfmt.Printf(\"hover: Failed to create Dockerfile %s: %v\\n\", dockerFilePath, err)\n+\t\tos.Exit(1)\n+\t}\n+\tdockerFileContent := []string{\n+\t\t\"FROM dockercore/golang-cross\",\n+\t\t\"RUN apt-get install libgl1-mesa-dev xorg-dev -y\",\n+\t\t\"WORKDIR /app\",\n+\t\t\"CMD \" + strings.Join(buildCommand(targetOS, vmArguments, \"build/outputs/\"+targetOS+\"/\"+outputBinaryName(projectName, targetOS)), \" \"),\n+\t}\n+\tfor _, env := range buildEnv(targetOS, \"/engine\") {\n+\t\tdockerFileContent = append(dockerFileContent, \"ENV \"+env)\n+\t}\n+\n+\tfor _, line := range dockerFileContent {\n+\t\tif _, err := dockerFile.WriteString(line + \"\\n\"); err != nil {\n+\t\t\tfmt.Printf(\"hover: Could not write Dockerfile: %v\\n\", err)\n+\t\t\tos.Exit(1)\n+\t\t}\n+\t}\n+\terr = dockerFile.Close()\n+\tif err != nil {\n+\t\tfmt.Printf(\"hover: Could not close Dockerfile: %v\\n\", err)\n+\t\tos.Exit(1)\n+\t}\n+\tdockerBuildCmd := exec.Command(dockerBin, \"build\", \"-t\", \"hover-build-cc\", \".\")\n+\tdockerBuildCmd.Stderr = os.Stderr\n+\tdockerBuildCmd.Stdout = os.Stdout\n+\tdockerBuildCmd.Dir = tmpDir\n+\terr = dockerBuildCmd.Run()\n+\tif err != nil {\n+\t\tfmt.Printf(\"hover: Docker build failed: %v\\n\", err)\n+\t\tos.Exit(1)\n+\t}\n+\n+\tfmt.Println(\"hover: Cross-Compiling 'go-flutter' and plugins using docker\")\n+\n+\toutputPath, err := filepath.Abs(filepath.Join(buildPath, \"build\", \"outputs\"))\n+\tdockerRunCmd := exec.Command(dockerBin, \"run\", \"-e\", \"USERID=$UID\", \"-v\", goPath+\":/go\", \"-v\", pkgRootDir+\":/app\", \"-v\", engineCachePath+\":/engine\", \"-v\", outputPath+\":/app/build/outputs\", \"-v\", filepath.Join(userCacheDir, \"go-build\")+\":/cache\", \"hover-build-cc\")","path":"cmd/build.go","position":103,"original_position":103,"commit_id":"ad1da4cf0e047871b4d1218463c282428f0c7868","original_commit_id":"ad1da4cf0e047871b4d1218463c282428f0c7868","user":{"login":"Drakirus","id":7476655,"node_id":"MDQ6VXNlcjc0NzY2NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/7476655?v=4","gravatar_id":"","url":"https://api.github.com/users/Drakirus","html_url":"https://github.com/Drakirus","followers_url":"https://api.github.com/users/Drakirus/followers","following_url":"https://api.github.com/users/Drakirus/following{/other_user}","gists_url":"https://api.github.com/users/Drakirus/gists{/gist_id}","starred_url":"https://api.github.com/users/Drakirus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drakirus/subscriptions","organizations_url":"https://api.github.com/users/Drakirus/orgs","repos_url":"https://api.github.com/users/Drakirus/repos","events_url":"https://api.github.com/users/Drakirus/events{/privacy}","received_events_url":"https://api.github.com/users/Drakirus/received_events","type":"User","site_admin":false},"body":"By letting the user customize the Dockerfile, we could add other directories inside the container.\r\nAnd let the user add external deps for plugin. ","created_at":"2019-09-17T12:39:42Z","updated_at":"2019-09-17T12:39:42Z","html_url":"https://github.com/go-flutter-desktop/hover/pull/23#discussion_r325142404","pull_request_url":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/23","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/comments/325142404"},"html":{"href":"https://github.com/go-flutter-desktop/hover/pull/23#discussion_r325142404"},"pull_request":{"href":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/23"}},"in_reply_to_id":324387562},"pull_request":{"url":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/23","id":316598349,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2NTk4MzQ5","html_url":"https://github.com/go-flutter-desktop/hover/pull/23","diff_url":"https://github.com/go-flutter-desktop/hover/pull/23.diff","patch_url":"https://github.com/go-flutter-desktop/hover/pull/23.patch","issue_url":"https://api.github.com/repos/go-flutter-desktop/hover/issues/23","number":23,"state":"open","locked":false,"title":"Initial cross-compiling support","user":{"login":"jld3103","id":26026535,"node_id":"MDQ6VXNlcjI2MDI2NTM1","avatar_url":"https://avatars0.githubusercontent.com/u/26026535?v=4","gravatar_id":"","url":"https://api.github.com/users/jld3103","html_url":"https://github.com/jld3103","followers_url":"https://api.github.com/users/jld3103/followers","following_url":"https://api.github.com/users/jld3103/following{/other_user}","gists_url":"https://api.github.com/users/jld3103/gists{/gist_id}","starred_url":"https://api.github.com/users/jld3103/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jld3103/subscriptions","organizations_url":"https://api.github.com/users/jld3103/orgs","repos_url":"https://api.github.com/users/jld3103/repos","events_url":"https://api.github.com/users/jld3103/events{/privacy}","received_events_url":"https://api.github.com/users/jld3103/received_events","type":"User","site_admin":false},"body":"This PR add support for cross-compiling on any machine with docker installed.\r\n\r\n## How it works:\r\nIf the target OS doesn't match the machine's OS a Docker container is created and builds the app using the cross-compiling tools installed in the container.\r\n\r\n## Tests needed to be done before merging:\r\n - [ ] Check if Mac build is an actual release build\r\n - [ ] Check if non cross-compiling still works:\r\n - [x] Linux\r\n - [ ] Windows\r\n - [ ] Mac\r\n\r\nCurrently a temporary Dockerfile is created, but could be redundant if the build command gets correctly escaped. That would be no change for the user or performance, but the could would be smaller.\r\n\r\nPlease test if you have the machine(s) needed for the tests.","created_at":"2019-09-11T19:23:36Z","updated_at":"2019-09-17T12:39:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ffabaf853276bbcf3934fd77796bd010ddc6806","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/23/commits","review_comments_url":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/23/comments","review_comment_url":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-flutter-desktop/hover/issues/23/comments","statuses_url":"https://api.github.com/repos/go-flutter-desktop/hover/statuses/ad1da4cf0e047871b4d1218463c282428f0c7868","head":{"label":"jld3103:feature/cross-compiling","ref":"feature/cross-compiling","sha":"ad1da4cf0e047871b4d1218463c282428f0c7868","user":{"login":"jld3103","id":26026535,"node_id":"MDQ6VXNlcjI2MDI2NTM1","avatar_url":"https://avatars0.githubusercontent.com/u/26026535?v=4","gravatar_id":"","url":"https://api.github.com/users/jld3103","html_url":"https://github.com/jld3103","followers_url":"https://api.github.com/users/jld3103/followers","following_url":"https://api.github.com/users/jld3103/following{/other_user}","gists_url":"https://api.github.com/users/jld3103/gists{/gist_id}","starred_url":"https://api.github.com/users/jld3103/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jld3103/subscriptions","organizations_url":"https://api.github.com/users/jld3103/orgs","repos_url":"https://api.github.com/users/jld3103/repos","events_url":"https://api.github.com/users/jld3103/events{/privacy}","received_events_url":"https://api.github.com/users/jld3103/received_events","type":"User","site_admin":false},"repo":{"id":207323954,"node_id":"MDEwOlJlcG9zaXRvcnkyMDczMjM5NTQ=","name":"hover","full_name":"jld3103/hover","private":false,"owner":{"login":"jld3103","id":26026535,"node_id":"MDQ6VXNlcjI2MDI2NTM1","avatar_url":"https://avatars0.githubusercontent.com/u/26026535?v=4","gravatar_id":"","url":"https://api.github.com/users/jld3103","html_url":"https://github.com/jld3103","followers_url":"https://api.github.com/users/jld3103/followers","following_url":"https://api.github.com/users/jld3103/following{/other_user}","gists_url":"https://api.github.com/users/jld3103/gists{/gist_id}","starred_url":"https://api.github.com/users/jld3103/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jld3103/subscriptions","organizations_url":"https://api.github.com/users/jld3103/orgs","repos_url":"https://api.github.com/users/jld3103/repos","events_url":"https://api.github.com/users/jld3103/events{/privacy}","received_events_url":"https://api.github.com/users/jld3103/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jld3103/hover","description":"Hover helps developers to release Flutter applications on desktop.","fork":true,"url":"https://api.github.com/repos/jld3103/hover","forks_url":"https://api.github.com/repos/jld3103/hover/forks","keys_url":"https://api.github.com/repos/jld3103/hover/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jld3103/hover/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jld3103/hover/teams","hooks_url":"https://api.github.com/repos/jld3103/hover/hooks","issue_events_url":"https://api.github.com/repos/jld3103/hover/issues/events{/number}","events_url":"https://api.github.com/repos/jld3103/hover/events","assignees_url":"https://api.github.com/repos/jld3103/hover/assignees{/user}","branches_url":"https://api.github.com/repos/jld3103/hover/branches{/branch}","tags_url":"https://api.github.com/repos/jld3103/hover/tags","blobs_url":"https://api.github.com/repos/jld3103/hover/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jld3103/hover/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jld3103/hover/git/refs{/sha}","trees_url":"https://api.github.com/repos/jld3103/hover/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jld3103/hover/statuses/{sha}","languages_url":"https://api.github.com/repos/jld3103/hover/languages","stargazers_url":"https://api.github.com/repos/jld3103/hover/stargazers","contributors_url":"https://api.github.com/repos/jld3103/hover/contributors","subscribers_url":"https://api.github.com/repos/jld3103/hover/subscribers","subscription_url":"https://api.github.com/repos/jld3103/hover/subscription","commits_url":"https://api.github.com/repos/jld3103/hover/commits{/sha}","git_commits_url":"https://api.github.com/repos/jld3103/hover/git/commits{/sha}","comments_url":"https://api.github.com/repos/jld3103/hover/comments{/number}","issue_comment_url":"https://api.github.com/repos/jld3103/hover/issues/comments{/number}","contents_url":"https://api.github.com/repos/jld3103/hover/contents/{+path}","compare_url":"https://api.github.com/repos/jld3103/hover/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jld3103/hover/merges","archive_url":"https://api.github.com/repos/jld3103/hover/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jld3103/hover/downloads","issues_url":"https://api.github.com/repos/jld3103/hover/issues{/number}","pulls_url":"https://api.github.com/repos/jld3103/hover/pulls{/number}","milestones_url":"https://api.github.com/repos/jld3103/hover/milestones{/number}","notifications_url":"https://api.github.com/repos/jld3103/hover/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jld3103/hover/labels{/name}","releases_url":"https://api.github.com/repos/jld3103/hover/releases{/id}","deployments_url":"https://api.github.com/repos/jld3103/hover/deployments","created_at":"2019-09-09T14:05:39Z","updated_at":"2019-09-11T19:15:46Z","pushed_at":"2019-09-12T09:50:33Z","git_url":"git://github.com/jld3103/hover.git","ssh_url":"[email protected]:jld3103/hover.git","clone_url":"https://github.com/jld3103/hover.git","svn_url":"https://github.com/jld3103/hover","homepage":"https://hover.build/","size":154,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-flutter-desktop:master","ref":"master","sha":"0a31460576c2ff70a5c6cb55ba6007d52772f3a7","user":{"login":"go-flutter-desktop","id":47712234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NzEyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/47712234?v=4","gravatar_id":"","url":"https://api.github.com/users/go-flutter-desktop","html_url":"https://github.com/go-flutter-desktop","followers_url":"https://api.github.com/users/go-flutter-desktop/followers","following_url":"https://api.github.com/users/go-flutter-desktop/following{/other_user}","gists_url":"https://api.github.com/users/go-flutter-desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/go-flutter-desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-flutter-desktop/subscriptions","organizations_url":"https://api.github.com/users/go-flutter-desktop/orgs","repos_url":"https://api.github.com/users/go-flutter-desktop/repos","events_url":"https://api.github.com/users/go-flutter-desktop/events{/privacy}","received_events_url":"https://api.github.com/users/go-flutter-desktop/received_events","type":"Organization","site_admin":false},"repo":{"id":177009485,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcwMDk0ODU=","name":"hover","full_name":"go-flutter-desktop/hover","private":false,"owner":{"login":"go-flutter-desktop","id":47712234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NzEyMjM0","avatar_url":"https://avatars0.githubusercontent.com/u/47712234?v=4","gravatar_id":"","url":"https://api.github.com/users/go-flutter-desktop","html_url":"https://github.com/go-flutter-desktop","followers_url":"https://api.github.com/users/go-flutter-desktop/followers","following_url":"https://api.github.com/users/go-flutter-desktop/following{/other_user}","gists_url":"https://api.github.com/users/go-flutter-desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/go-flutter-desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-flutter-desktop/subscriptions","organizations_url":"https://api.github.com/users/go-flutter-desktop/orgs","repos_url":"https://api.github.com/users/go-flutter-desktop/repos","events_url":"https://api.github.com/users/go-flutter-desktop/events{/privacy}","received_events_url":"https://api.github.com/users/go-flutter-desktop/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/go-flutter-desktop/hover","description":"Hover helps developers to release Flutter applications on desktop.","fork":false,"url":"https://api.github.com/repos/go-flutter-desktop/hover","forks_url":"https://api.github.com/repos/go-flutter-desktop/hover/forks","keys_url":"https://api.github.com/repos/go-flutter-desktop/hover/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-flutter-desktop/hover/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-flutter-desktop/hover/teams","hooks_url":"https://api.github.com/repos/go-flutter-desktop/hover/hooks","issue_events_url":"https://api.github.com/repos/go-flutter-desktop/hover/issues/events{/number}","events_url":"https://api.github.com/repos/go-flutter-desktop/hover/events","assignees_url":"https://api.github.com/repos/go-flutter-desktop/hover/assignees{/user}","branches_url":"https://api.github.com/repos/go-flutter-desktop/hover/branches{/branch}","tags_url":"https://api.github.com/repos/go-flutter-desktop/hover/tags","blobs_url":"https://api.github.com/repos/go-flutter-desktop/hover/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-flutter-desktop/hover/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-flutter-desktop/hover/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-flutter-desktop/hover/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-flutter-desktop/hover/statuses/{sha}","languages_url":"https://api.github.com/repos/go-flutter-desktop/hover/languages","stargazers_url":"https://api.github.com/repos/go-flutter-desktop/hover/stargazers","contributors_url":"https://api.github.com/repos/go-flutter-desktop/hover/contributors","subscribers_url":"https://api.github.com/repos/go-flutter-desktop/hover/subscribers","subscription_url":"https://api.github.com/repos/go-flutter-desktop/hover/subscription","commits_url":"https://api.github.com/repos/go-flutter-desktop/hover/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-flutter-desktop/hover/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-flutter-desktop/hover/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-flutter-desktop/hover/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-flutter-desktop/hover/contents/{+path}","compare_url":"https://api.github.com/repos/go-flutter-desktop/hover/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-flutter-desktop/hover/merges","archive_url":"https://api.github.com/repos/go-flutter-desktop/hover/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-flutter-desktop/hover/downloads","issues_url":"https://api.github.com/repos/go-flutter-desktop/hover/issues{/number}","pulls_url":"https://api.github.com/repos/go-flutter-desktop/hover/pulls{/number}","milestones_url":"https://api.github.com/repos/go-flutter-desktop/hover/milestones{/number}","notifications_url":"https://api.github.com/repos/go-flutter-desktop/hover/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-flutter-desktop/hover/labels{/name}","releases_url":"https://api.github.com/repos/go-flutter-desktop/hover/releases{/id}","deployments_url":"https://api.github.com/repos/go-flutter-desktop/hover/deployments","created_at":"2019-03-21T19:16:04Z","updated_at":"2019-09-17T11:46:35Z","pushed_at":"2019-09-17T11:46:36Z","git_url":"git://github.com/go-flutter-desktop/hover.git","ssh_url":"[email protected]:go-flutter-desktop/hover.git","clone_url":"https://github.com/go-flutter-desktop/hover.git","svn_url":"https://github.com/go-flutter-desktop/hover","homepage":"https://hover.build/","size":152,"stargazers_count":249,"watchers_count":249,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":19,"open_issues":4,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/23"},"html":{"href":"https://github.com/go-flutter-desktop/hover/pull/23"},"issue":{"href":"https://api.github.com/repos/go-flutter-desktop/hover/issues/23"},"comments":{"href":"https://api.github.com/repos/go-flutter-desktop/hover/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-flutter-desktop/hover/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/go-flutter-desktop/hover/statuses/ad1da4cf0e047871b4d1218463c282428f0c7868"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 177009485,
"name": "go-flutter-desktop/hover",
"url": "https://api.github.com/repos/go-flutter-desktop/hover"
}
|
{
"id": 7476655,
"login": "Drakirus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7476655?",
"url": "https://api.github.com/users/Drakirus"
}
|
{
"id": 47712234,
"login": "go-flutter-desktop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47712234?",
"url": "https://api.github.com/orgs/go-flutter-desktop"
}
| 2019-09-17T12:39:42 |
10433023137
|
{"actor":{"display_login":"Drakirus"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/comments/308179811","pull_request_review_id":267720223,"id":308179811,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODE3OTgxMQ==","diff_hunk":"@@ -1,2 +1,3 @@\n #!/usr/bin/env sh\n # ่ฏทๅจ่ฟ้็ผๅไธๆกๅฝไปค๏ผๅฐๅฝๅ็ฎๅฝ็src็ฎๅฝไธๆๆๆไปถๅๆไปถๅคนๆท่ดๅฐdest็ฎๅฝ\n+cp -rl src dest","path":"practise-cp-all/solution.sh","position":3,"original_position":3,"commit_id":"13700c388987025805fc85d800fe43ad24ffa7ab","original_commit_id":"13700c388987025805fc85d800fe43ad24ffa7ab","user":{"login":"blindpirate","id":12689835,"node_id":"MDQ6VXNlcjEyNjg5ODM1","avatar_url":"https://avatars3.githubusercontent.com/u/12689835?v=4","gravatar_id":"","url":"https://api.github.com/users/blindpirate","html_url":"https://github.com/blindpirate","followers_url":"https://api.github.com/users/blindpirate/followers","following_url":"https://api.github.com/users/blindpirate/following{/other_user}","gists_url":"https://api.github.com/users/blindpirate/gists{/gist_id}","starred_url":"https://api.github.com/users/blindpirate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindpirate/subscriptions","organizations_url":"https://api.github.com/users/blindpirate/orgs","repos_url":"https://api.github.com/users/blindpirate/repos","events_url":"https://api.github.com/users/blindpirate/events{/privacy}","received_events_url":"https://api.github.com/users/blindpirate/received_events","type":"User","site_admin":false},"body":"็ฐๅจ็ๅๆณๆฏโๆsrcๆไปถๅคนๆดไธชๆท่ดๅฐdest้โ๏ผ่ไธๆฏโsrc็ฎๅฝไธๆๆๆไปถๅๆไปถๅคนๆท่ดๅฐdest็ฎๅฝโ","created_at":"2019-07-29T11:25:28Z","updated_at":"2019-07-29T11:25:28Z","html_url":"https://github.com/hcsp/practise-shell-commands/pull/21#discussion_r308179811","pull_request_url":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/21","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/comments/308179811"},"html":{"href":"https://github.com/hcsp/practise-shell-commands/pull/21#discussion_r308179811"},"pull_request":{"href":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/21","id":302024654,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAyMDI0NjU0","html_url":"https://github.com/hcsp/practise-shell-commands/pull/21","diff_url":"https://github.com/hcsp/practise-shell-commands/pull/21.diff","patch_url":"https://github.com/hcsp/practise-shell-commands/pull/21.patch","issue_url":"https://api.github.com/repos/hcsp/practise-shell-commands/issues/21","number":21,"state":"open","locked":false,"title":"ๅฝไปค่ก command line","user":{"login":"zhangxin","id":45200839,"node_id":"MDQ6VXNlcjQ1MjAwODM5","avatar_url":"https://avatars0.githubusercontent.com/u/45200839?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangxin","html_url":"https://github.com/zhangxin","followers_url":"https://api.github.com/users/zhangxin/followers","following_url":"https://api.github.com/users/zhangxin/following{/other_user}","gists_url":"https://api.github.com/users/zhangxin/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangxin/subscriptions","organizations_url":"https://api.github.com/users/zhangxin/orgs","repos_url":"https://api.github.com/users/zhangxin/repos","events_url":"https://api.github.com/users/zhangxin/events{/privacy}","received_events_url":"https://api.github.com/users/zhangxin/received_events","type":"User","site_admin":false},"body":" command line","created_at":"2019-07-29T11:23:40Z","updated_at":"2019-07-29T11:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78ce2d4088b33b8d9933f1543b9e889cffd2b2d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/21/commits","review_comments_url":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/21/comments","review_comment_url":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hcsp/practise-shell-commands/issues/21/comments","statuses_url":"https://api.github.com/repos/hcsp/practise-shell-commands/statuses/13700c388987025805fc85d800fe43ad24ffa7ab","head":{"label":"hcsp:zx-patch-1","ref":"zx-patch-1","sha":"13700c388987025805fc85d800fe43ad24ffa7ab","user":{"login":"hcsp","id":47730780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NzMwNzgw","avatar_url":"https://avatars3.githubusercontent.com/u/47730780?v=4","gravatar_id":"","url":"https://api.github.com/users/hcsp","html_url":"https://github.com/hcsp","followers_url":"https://api.github.com/users/hcsp/followers","following_url":"https://api.github.com/users/hcsp/following{/other_user}","gists_url":"https://api.github.com/users/hcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/hcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcsp/subscriptions","organizations_url":"https://api.github.com/users/hcsp/orgs","repos_url":"https://api.github.com/users/hcsp/repos","events_url":"https://api.github.com/users/hcsp/events{/privacy}","received_events_url":"https://api.github.com/users/hcsp/received_events","type":"Organization","site_admin":false},"repo":{"id":195528998,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU1Mjg5OTg=","name":"practise-shell-commands","full_name":"hcsp/practise-shell-commands","private":false,"owner":{"login":"hcsp","id":47730780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NzMwNzgw","avatar_url":"https://avatars3.githubusercontent.com/u/47730780?v=4","gravatar_id":"","url":"https://api.github.com/users/hcsp","html_url":"https://github.com/hcsp","followers_url":"https://api.github.com/users/hcsp/followers","following_url":"https://api.github.com/users/hcsp/following{/other_user}","gists_url":"https://api.github.com/users/hcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/hcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcsp/subscriptions","organizations_url":"https://api.github.com/users/hcsp/orgs","repos_url":"https://api.github.com/users/hcsp/repos","events_url":"https://api.github.com/users/hcsp/events{/privacy}","received_events_url":"https://api.github.com/users/hcsp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hcsp/practise-shell-commands","description":"Java basic practice for beginners: shell commands","fork":false,"url":"https://api.github.com/repos/hcsp/practise-shell-commands","forks_url":"https://api.github.com/repos/hcsp/practise-shell-commands/forks","keys_url":"https://api.github.com/repos/hcsp/practise-shell-commands/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hcsp/practise-shell-commands/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hcsp/practise-shell-commands/teams","hooks_url":"https://api.github.com/repos/hcsp/practise-shell-commands/hooks","issue_events_url":"https://api.github.com/repos/hcsp/practise-shell-commands/issues/events{/number}","events_url":"https://api.github.com/repos/hcsp/practise-shell-commands/events","assignees_url":"https://api.github.com/repos/hcsp/practise-shell-commands/assignees{/user}","branches_url":"https://api.github.com/repos/hcsp/practise-shell-commands/branches{/branch}","tags_url":"https://api.github.com/repos/hcsp/practise-shell-commands/tags","blobs_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/refs{/sha}","trees_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hcsp/practise-shell-commands/statuses/{sha}","languages_url":"https://api.github.com/repos/hcsp/practise-shell-commands/languages","stargazers_url":"https://api.github.com/repos/hcsp/practise-shell-commands/stargazers","contributors_url":"https://api.github.com/repos/hcsp/practise-shell-commands/contributors","subscribers_url":"https://api.github.com/repos/hcsp/practise-shell-commands/subscribers","subscription_url":"https://api.github.com/repos/hcsp/practise-shell-commands/subscription","commits_url":"https://api.github.com/repos/hcsp/practise-shell-commands/commits{/sha}","git_commits_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/commits{/sha}","comments_url":"https://api.github.com/repos/hcsp/practise-shell-commands/comments{/number}","issue_comment_url":"https://api.github.com/repos/hcsp/practise-shell-commands/issues/comments{/number}","contents_url":"https://api.github.com/repos/hcsp/practise-shell-commands/contents/{+path}","compare_url":"https://api.github.com/repos/hcsp/practise-shell-commands/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hcsp/practise-shell-commands/merges","archive_url":"https://api.github.com/repos/hcsp/practise-shell-commands/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hcsp/practise-shell-commands/downloads","issues_url":"https://api.github.com/repos/hcsp/practise-shell-commands/issues{/number}","pulls_url":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls{/number}","milestones_url":"https://api.github.com/repos/hcsp/practise-shell-commands/milestones{/number}","notifications_url":"https://api.github.com/repos/hcsp/practise-shell-commands/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hcsp/practise-shell-commands/labels{/name}","releases_url":"https://api.github.com/repos/hcsp/practise-shell-commands/releases{/id}","deployments_url":"https://api.github.com/repos/hcsp/practise-shell-commands/deployments","created_at":"2019-07-06T10:53:26Z","updated_at":"2019-07-29T04:14:14Z","pushed_at":"2019-07-29T11:23:40Z","git_url":"git://github.com/hcsp/practise-shell-commands.git","ssh_url":"[email protected]:hcsp/practise-shell-commands.git","clone_url":"https://github.com/hcsp/practise-shell-commands.git","svn_url":"https://github.com/hcsp/practise-shell-commands","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"hcsp:master","ref":"master","sha":"c8c76b74dd4f661513a1922135d452daa76671da","user":{"login":"hcsp","id":47730780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NzMwNzgw","avatar_url":"https://avatars3.githubusercontent.com/u/47730780?v=4","gravatar_id":"","url":"https://api.github.com/users/hcsp","html_url":"https://github.com/hcsp","followers_url":"https://api.github.com/users/hcsp/followers","following_url":"https://api.github.com/users/hcsp/following{/other_user}","gists_url":"https://api.github.com/users/hcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/hcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcsp/subscriptions","organizations_url":"https://api.github.com/users/hcsp/orgs","repos_url":"https://api.github.com/users/hcsp/repos","events_url":"https://api.github.com/users/hcsp/events{/privacy}","received_events_url":"https://api.github.com/users/hcsp/received_events","type":"Organization","site_admin":false},"repo":{"id":195528998,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU1Mjg5OTg=","name":"practise-shell-commands","full_name":"hcsp/practise-shell-commands","private":false,"owner":{"login":"hcsp","id":47730780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NzMwNzgw","avatar_url":"https://avatars3.githubusercontent.com/u/47730780?v=4","gravatar_id":"","url":"https://api.github.com/users/hcsp","html_url":"https://github.com/hcsp","followers_url":"https://api.github.com/users/hcsp/followers","following_url":"https://api.github.com/users/hcsp/following{/other_user}","gists_url":"https://api.github.com/users/hcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/hcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcsp/subscriptions","organizations_url":"https://api.github.com/users/hcsp/orgs","repos_url":"https://api.github.com/users/hcsp/repos","events_url":"https://api.github.com/users/hcsp/events{/privacy}","received_events_url":"https://api.github.com/users/hcsp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hcsp/practise-shell-commands","description":"Java basic practice for beginners: shell commands","fork":false,"url":"https://api.github.com/repos/hcsp/practise-shell-commands","forks_url":"https://api.github.com/repos/hcsp/practise-shell-commands/forks","keys_url":"https://api.github.com/repos/hcsp/practise-shell-commands/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hcsp/practise-shell-commands/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hcsp/practise-shell-commands/teams","hooks_url":"https://api.github.com/repos/hcsp/practise-shell-commands/hooks","issue_events_url":"https://api.github.com/repos/hcsp/practise-shell-commands/issues/events{/number}","events_url":"https://api.github.com/repos/hcsp/practise-shell-commands/events","assignees_url":"https://api.github.com/repos/hcsp/practise-shell-commands/assignees{/user}","branches_url":"https://api.github.com/repos/hcsp/practise-shell-commands/branches{/branch}","tags_url":"https://api.github.com/repos/hcsp/practise-shell-commands/tags","blobs_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/refs{/sha}","trees_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hcsp/practise-shell-commands/statuses/{sha}","languages_url":"https://api.github.com/repos/hcsp/practise-shell-commands/languages","stargazers_url":"https://api.github.com/repos/hcsp/practise-shell-commands/stargazers","contributors_url":"https://api.github.com/repos/hcsp/practise-shell-commands/contributors","subscribers_url":"https://api.github.com/repos/hcsp/practise-shell-commands/subscribers","subscription_url":"https://api.github.com/repos/hcsp/practise-shell-commands/subscription","commits_url":"https://api.github.com/repos/hcsp/practise-shell-commands/commits{/sha}","git_commits_url":"https://api.github.com/repos/hcsp/practise-shell-commands/git/commits{/sha}","comments_url":"https://api.github.com/repos/hcsp/practise-shell-commands/comments{/number}","issue_comment_url":"https://api.github.com/repos/hcsp/practise-shell-commands/issues/comments{/number}","contents_url":"https://api.github.com/repos/hcsp/practise-shell-commands/contents/{+path}","compare_url":"https://api.github.com/repos/hcsp/practise-shell-commands/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hcsp/practise-shell-commands/merges","archive_url":"https://api.github.com/repos/hcsp/practise-shell-commands/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hcsp/practise-shell-commands/downloads","issues_url":"https://api.github.com/repos/hcsp/practise-shell-commands/issues{/number}","pulls_url":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls{/number}","milestones_url":"https://api.github.com/repos/hcsp/practise-shell-commands/milestones{/number}","notifications_url":"https://api.github.com/repos/hcsp/practise-shell-commands/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hcsp/practise-shell-commands/labels{/name}","releases_url":"https://api.github.com/repos/hcsp/practise-shell-commands/releases{/id}","deployments_url":"https://api.github.com/repos/hcsp/practise-shell-commands/deployments","created_at":"2019-07-06T10:53:26Z","updated_at":"2019-07-29T04:14:14Z","pushed_at":"2019-07-29T11:23:40Z","git_url":"git://github.com/hcsp/practise-shell-commands.git","ssh_url":"[email protected]:hcsp/practise-shell-commands.git","clone_url":"https://github.com/hcsp/practise-shell-commands.git","svn_url":"https://github.com/hcsp/practise-shell-commands","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/21"},"html":{"href":"https://github.com/hcsp/practise-shell-commands/pull/21"},"issue":{"href":"https://api.github.com/repos/hcsp/practise-shell-commands/issues/21"},"comments":{"href":"https://api.github.com/repos/hcsp/practise-shell-commands/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hcsp/practise-shell-commands/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/hcsp/practise-shell-commands/statuses/13700c388987025805fc85d800fe43ad24ffa7ab"}},"author_association":"NONE"}}
|
{
"id": 195528998,
"name": "hcsp/practise-shell-commands",
"url": "https://api.github.com/repos/hcsp/practise-shell-commands"
}
|
{
"id": 12689835,
"login": "blindpirate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12689835?",
"url": "https://api.github.com/users/blindpirate"
}
|
{
"id": 47730780,
"login": "hcsp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47730780?",
"url": "https://api.github.com/orgs/hcsp"
}
| 2019-07-29T11:25:28 |
10102521672
|
{"actor":{"display_login":"blindpirate"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/comments/334773452","pull_request_review_id":301678668,"id":334773452,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDc3MzQ1Mg==","diff_hunk":"@@ -9,49 +9,245 @@\n \n #include <I2CDevice.hpp>\n #include <string>\n+#include <array>\n \n namespace Devices {\n \n class ADCS : public I2CDevice {\n public:\n- static constexpr unsigned int ADDRESS = 0x00;\n- /** **/\n+ static constexpr unsigned int ADDRESS = 0x4E;\n+ static constexpr unsigned int WHO_AM_I_EXPECTED = 0x0F;\n+ /**\n+ * @brief quickly tests that the device is active and working on i2c\n+ * \n+ * @return true\n+ * returns true if get_who_am_i returns the expected value\n+ * @return false \n+ * returns false if get_who_am_i does not return the expected value\n+ */\n virtual bool i2c_ping() override;\n- /** **/\n+ /**\n+ * @brief Construct a new ADCS object\n+ * \n+ * @param name The name\n+ * @param i2c_wire The assoicated i2c wire\n+ * @param address The address on i2c bus\n+ */\n ADCS(const std::string &name, i2c_t3 &i2c_wire, unsigned char address);\n- /** **/\n- void set_mode(unsigned char mode);\n- /** **/\n- void set_read_ptr(unsigned short read_ptr);\n- /** **/\n- void set_rwa_mode(unsigned char rwa_mode, float const *rwa_cmd);\n- /** **/\n- void set_rwa_cmd(float const *rwa_cmd);\n- /** **/\n- void set_rwa_speed_flt(float rwa_speed_flt);\n- /** **/\n- void set_rwa_ramp_flt(float rwa_ramp_flt);\n- /** **/\n- void set_mtr_cmd(float const *mtr_cmd);\n- /** **/\n- void set_ssa_adc_flt(float ssa_adc_flt);\n- /** **/\n- void set_ssa_mode(unsigned char ssa_mode);\n- /** **/\n- void set_imu_gyr_flt(float imu_gyr_flt);\n- /** **/\n- void set_imu_mag_flt(float imu_mag_flt);\n- /** **/\n- void get_rwa(float *rwa_speed_cmd_rd, float *rwa_speed_rd, float *rwa_ramp_rd);\n- /** **/\n- void get_ssa(unsigned char &ssa_mode, float *ssa_vec_rd);\n- /** **/\n- void get_ssa_adcs(float *ssa_adc_rd);\n- /** **/\n- void get_imu(float *gyr_rd, float *mag_rd);\n+ /**\n+ * @brief Sets the read pointer, writes len bytes into data\n+ * \n+ * @param data_register The register address to read from\n+ * @param data Where to read the bytes into\n+ * @param len The number of bytes to read\n+ */\n+ template <typename T>\n+ void i2c_point_and_read(unsigned char data_register, T* data, std::size_t len);\n+ /**\n+ * @brief Set the mode of the ADCS controller\n+ * \n+ * @param mode\n+ * 0x00โADCS passive mode (default) \n+ * 0x01โADCS active mode \n+ */\n+ void set_mode(const unsigned char mode);\n+ /**\n+ * @brief Set what address the the ADCS controller should read from\n+ * \n+ * @param read_ptr address to read from\n+ */\n+ void set_read_ptr(const unsigned char read_ptr);\n+ /**\n+ * @brief Set the rwa mode","path":"lib/Drivers/ADCS.hpp","position":86,"original_position":86,"commit_id":"efe81b21e877ad169f43e7f33891c9104d91025a","original_commit_id":"efe81b21e877ad169f43e7f33891c9104d91025a","user":{"login":"tanishqaggarwal","id":5239500,"node_id":"MDQ6VXNlcjUyMzk1MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5239500?v=4","gravatar_id":"","url":"https://api.github.com/users/tanishqaggarwal","html_url":"https://github.com/tanishqaggarwal","followers_url":"https://api.github.com/users/tanishqaggarwal/followers","following_url":"https://api.github.com/users/tanishqaggarwal/following{/other_user}","gists_url":"https://api.github.com/users/tanishqaggarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/tanishqaggarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanishqaggarwal/subscriptions","organizations_url":"https://api.github.com/users/tanishqaggarwal/orgs","repos_url":"https://api.github.com/users/tanishqaggarwal/repos","events_url":"https://api.github.com/users/tanishqaggarwal/events{/privacy}","received_events_url":"https://api.github.com/users/tanishqaggarwal/received_events","type":"User","site_admin":false},"body":"Can you clarify what \"rwa mode\" means?","created_at":"2019-10-15T06:38:43Z","updated_at":"2019-10-15T06:46:26Z","html_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware/pull/33#discussion_r334773452","pull_request_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/comments/334773452"},"html":{"href":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware/pull/33#discussion_r334773452"},"pull_request":{"href":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/33","id":323062317,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzMDYyMzE3","html_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware/pull/33","diff_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware/pull/33.diff","patch_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware/pull/33.patch","issue_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues/33","number":33,"state":"open","locked":false,"title":"Dev/adcs","user":{"login":"Shasty88","id":14984742,"node_id":"MDQ6VXNlcjE0OTg0NzQy","avatar_url":"https://avatars1.githubusercontent.com/u/14984742?v=4","gravatar_id":"","url":"https://api.github.com/users/Shasty88","html_url":"https://github.com/Shasty88","followers_url":"https://api.github.com/users/Shasty88/followers","following_url":"https://api.github.com/users/Shasty88/following{/other_user}","gists_url":"https://api.github.com/users/Shasty88/gists{/gist_id}","starred_url":"https://api.github.com/users/Shasty88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shasty88/subscriptions","organizations_url":"https://api.github.com/users/Shasty88/orgs","repos_url":"https://api.github.com/users/Shasty88/repos","events_url":"https://api.github.com/users/Shasty88/events{/privacy}","received_events_url":"https://api.github.com/users/Shasty88/received_events","type":"User","site_admin":false},"body":"Here's a pull request for my 85% finished ADCS driver. Note this is in tandem with minor bug fixes in the state_controller in the ADCSSoftware repo","created_at":"2019-10-01T03:23:07Z","updated_at":"2019-10-15T06:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41b68cd255c2f4b6a7dbaf9da9dfcf1dcbed0635","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/33/commits","review_comments_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/33/comments","review_comment_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues/33/comments","statuses_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/statuses/efe81b21e877ad169f43e7f33891c9104d91025a","head":{"label":"pathfinder-for-autonomous-navigation:dev/adcs","ref":"dev/adcs","sha":"efe81b21e877ad169f43e7f33891c9104d91025a","user":{"login":"pathfinder-for-autonomous-navigation","id":47810566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3ODEwNTY2","avatar_url":"https://avatars1.githubusercontent.com/u/47810566?v=4","gravatar_id":"","url":"https://api.github.com/users/pathfinder-for-autonomous-navigation","html_url":"https://github.com/pathfinder-for-autonomous-navigation","followers_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/followers","following_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/following{/other_user}","gists_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/gists{/gist_id}","starred_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/subscriptions","organizations_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/orgs","repos_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/repos","events_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/events{/privacy}","received_events_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/received_events","type":"Organization","site_admin":false},"repo":{"id":171626865,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2MjY4NjU=","name":"FlightSoftware","full_name":"pathfinder-for-autonomous-navigation/FlightSoftware","private":false,"owner":{"login":"pathfinder-for-autonomous-navigation","id":47810566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3ODEwNTY2","avatar_url":"https://avatars1.githubusercontent.com/u/47810566?v=4","gravatar_id":"","url":"https://api.github.com/users/pathfinder-for-autonomous-navigation","html_url":"https://github.com/pathfinder-for-autonomous-navigation","followers_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/followers","following_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/following{/other_user}","gists_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/gists{/gist_id}","starred_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/subscriptions","organizations_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/orgs","repos_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/repos","events_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/events{/privacy}","received_events_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware","description":null,"fork":false,"url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware","forks_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/forks","keys_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/teams","hooks_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/hooks","issue_events_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues/events{/number}","events_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/events","assignees_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/assignees{/user}","branches_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/branches{/branch}","tags_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/tags","blobs_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/refs{/sha}","trees_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/statuses/{sha}","languages_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/languages","stargazers_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/stargazers","contributors_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/contributors","subscribers_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/subscribers","subscription_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/subscription","commits_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/commits{/sha}","git_commits_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/commits{/sha}","comments_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/comments{/number}","issue_comment_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues/comments{/number}","contents_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/contents/{+path}","compare_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/merges","archive_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/downloads","issues_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues{/number}","pulls_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls{/number}","milestones_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/milestones{/number}","notifications_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/labels{/name}","releases_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/releases{/id}","deployments_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/deployments","created_at":"2019-02-20T07:55:33Z","updated_at":"2019-10-10T19:02:37Z","pushed_at":"2019-10-15T06:33:31Z","git_url":"git://github.com/pathfinder-for-autonomous-navigation/FlightSoftware.git","ssh_url":"[email protected]:pathfinder-for-autonomous-navigation/FlightSoftware.git","clone_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware.git","svn_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware","homepage":null,"size":2345,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"pathfinder-for-autonomous-navigation:master","ref":"master","sha":"f4362b0d4b65732f2a032828d9d7df2674db16dc","user":{"login":"pathfinder-for-autonomous-navigation","id":47810566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3ODEwNTY2","avatar_url":"https://avatars1.githubusercontent.com/u/47810566?v=4","gravatar_id":"","url":"https://api.github.com/users/pathfinder-for-autonomous-navigation","html_url":"https://github.com/pathfinder-for-autonomous-navigation","followers_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/followers","following_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/following{/other_user}","gists_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/gists{/gist_id}","starred_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/subscriptions","organizations_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/orgs","repos_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/repos","events_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/events{/privacy}","received_events_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/received_events","type":"Organization","site_admin":false},"repo":{"id":171626865,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2MjY4NjU=","name":"FlightSoftware","full_name":"pathfinder-for-autonomous-navigation/FlightSoftware","private":false,"owner":{"login":"pathfinder-for-autonomous-navigation","id":47810566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3ODEwNTY2","avatar_url":"https://avatars1.githubusercontent.com/u/47810566?v=4","gravatar_id":"","url":"https://api.github.com/users/pathfinder-for-autonomous-navigation","html_url":"https://github.com/pathfinder-for-autonomous-navigation","followers_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/followers","following_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/following{/other_user}","gists_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/gists{/gist_id}","starred_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/subscriptions","organizations_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/orgs","repos_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/repos","events_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/events{/privacy}","received_events_url":"https://api.github.com/users/pathfinder-for-autonomous-navigation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware","description":null,"fork":false,"url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware","forks_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/forks","keys_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/teams","hooks_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/hooks","issue_events_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues/events{/number}","events_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/events","assignees_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/assignees{/user}","branches_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/branches{/branch}","tags_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/tags","blobs_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/refs{/sha}","trees_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/statuses/{sha}","languages_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/languages","stargazers_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/stargazers","contributors_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/contributors","subscribers_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/subscribers","subscription_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/subscription","commits_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/commits{/sha}","git_commits_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/git/commits{/sha}","comments_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/comments{/number}","issue_comment_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues/comments{/number}","contents_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/contents/{+path}","compare_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/merges","archive_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/downloads","issues_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues{/number}","pulls_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls{/number}","milestones_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/milestones{/number}","notifications_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/labels{/name}","releases_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/releases{/id}","deployments_url":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/deployments","created_at":"2019-02-20T07:55:33Z","updated_at":"2019-10-10T19:02:37Z","pushed_at":"2019-10-15T06:33:31Z","git_url":"git://github.com/pathfinder-for-autonomous-navigation/FlightSoftware.git","ssh_url":"[email protected]:pathfinder-for-autonomous-navigation/FlightSoftware.git","clone_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware.git","svn_url":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware","homepage":null,"size":2345,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/33"},"html":{"href":"https://github.com/pathfinder-for-autonomous-navigation/FlightSoftware/pull/33"},"issue":{"href":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues/33"},"comments":{"href":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware/statuses/efe81b21e877ad169f43e7f33891c9104d91025a"}},"author_association":"COLLABORATOR"}}
|
{
"id": 171626865,
"name": "pathfinder-for-autonomous-navigation/FlightSoftware",
"url": "https://api.github.com/repos/pathfinder-for-autonomous-navigation/FlightSoftware"
}
|
{
"id": 5239500,
"login": "tanishqaggarwal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5239500?",
"url": "https://api.github.com/users/tanishqaggarwal"
}
|
{
"id": 47810566,
"login": "pathfinder-for-autonomous-navigation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47810566?",
"url": "https://api.github.com/orgs/pathfinder-for-autonomous-navigation"
}
| 2019-10-15T06:38:43 |
10630765647
|
{"actor":{"display_login":"tanishqaggarwal"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/comments/351077194","pull_request_review_id":323405422,"id":351077194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTA3NzE5NA==","diff_hunk":"@@ -0,0 +1,23 @@\n+<?php\n+namespace App\\Repositories\\Eloquents;\n+\n+use Auth;\n+use App\\Models\\Bot;\n+use App\\Repositories\\Eloquents\\BaseRepository;\n+use App\\Repositories\\Interfaces\\BotRepositoryInterface;\n+\n+class BotRepository extends BaseRepository implements BotRepositoryInterface\n+{\n+ public function getModel()\n+ {\n+ return Bot::class;\n+ }\n+\n+ public function getAllByUser()\n+ {\n+ return Auth::user()->bots()\n+ ->orderBy('bots.created_at', 'desc')\n+ ->get();\n+ }","path":"app/Repositories/Eloquents/BotRepository.php","position":21,"original_position":21,"commit_id":"d07bc6eed44011c0aaafa299b049e9a86b31283a","original_commit_id":"d07bc6eed44011c0aaafa299b049e9a86b31283a","user":{"login":"framgiaciv3","id":40970418,"node_id":"MDQ6VXNlcjQwOTcwNDE4","avatar_url":"https://avatars3.githubusercontent.com/u/40970418?v=4","gravatar_id":"","url":"https://api.github.com/users/framgiaciv3","html_url":"https://github.com/framgiaciv3","followers_url":"https://api.github.com/users/framgiaciv3/followers","following_url":"https://api.github.com/users/framgiaciv3/following{/other_user}","gists_url":"https://api.github.com/users/framgiaciv3/gists{/gist_id}","starred_url":"https://api.github.com/users/framgiaciv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgiaciv3/subscriptions","organizations_url":"https://api.github.com/users/framgiaciv3/orgs","repos_url":"https://api.github.com/users/framgiaciv3/repos","events_url":"https://api.github.com/users/framgiaciv3/events{/privacy}","received_events_url":"https://api.github.com/users/framgiaciv3/received_events","type":"User","site_admin":false},"body":"**Reporter**: CHECKSTYLE</br>**Rule**: PSR2.Classes.ClassDeclaration.CloseBraceAfterBody</br>**Severity**: error</br>**File**: app/Repositories/Eloquents/BotRepository.php</br>**Line**: 23</br>The closing brace for the class must go on the next line after the body","created_at":"2019-11-27T03:03:04Z","updated_at":"2019-11-27T03:03:04Z","html_url":"https://github.com/sun-asterisk-research/chatwork-forwarder/pull/20#discussion_r351077194","pull_request_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/20","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/comments/351077194"},"html":{"href":"https://github.com/sun-asterisk-research/chatwork-forwarder/pull/20#discussion_r351077194"},"pull_request":{"href":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/20","id":345501532,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1NTAxNTMy","html_url":"https://github.com/sun-asterisk-research/chatwork-forwarder/pull/20","diff_url":"https://github.com/sun-asterisk-research/chatwork-forwarder/pull/20.diff","patch_url":"https://github.com/sun-asterisk-research/chatwork-forwarder/pull/20.patch","issue_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/issues/20","number":20,"state":"open","locked":false,"title":"Refs Task#376104 [User] Unit test list bots","user":{"login":"nguyenthinhhn","id":40859990,"node_id":"MDQ6VXNlcjQwODU5OTkw","avatar_url":"https://avatars0.githubusercontent.com/u/40859990?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenthinhhn","html_url":"https://github.com/nguyenthinhhn","followers_url":"https://api.github.com/users/nguyenthinhhn/followers","following_url":"https://api.github.com/users/nguyenthinhhn/following{/other_user}","gists_url":"https://api.github.com/users/nguyenthinhhn/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenthinhhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenthinhhn/subscriptions","organizations_url":"https://api.github.com/users/nguyenthinhhn/orgs","repos_url":"https://api.github.com/users/nguyenthinhhn/repos","events_url":"https://api.github.com/users/nguyenthinhhn/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenthinhhn/received_events","type":"User","site_admin":false},"body":"## Related Tickets\r\n\r\n- [#376104](https://dev.sun-asterisk.com/issues/376104)\r\n\r\n## What's this PR do ?\r\n\r\n- [x] Test list bot\r\n\r\n## Library\r\n\r\n\r\n## Performance\r\n\r\n- [ ] Resolved n + 1 query\r\n- [ ] Run explain query already\r\n- [ ] Time run rake task : 1000 ms\r\n\r\n## Checklist\r\n\r\n- [ ] It was tested in local success?\r\n- [ ] Fill link PR into ticket and the opposite\r\n- [ ] Note purpose/reason, solution, scope of influence into ticket\r\n\r\n## ENV note\r\n\r\n```\r\n```\r\n\r\n## Notes\r\n*(Other notes)*\r\n","created_at":"2019-11-26T01:58:23Z","updated_at":"2019-11-27T03:03:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"684f05ecaaec8bc3e4005cb2a7fec3b3de40098c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/20/commits","review_comments_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/20/comments","review_comment_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/issues/20/comments","statuses_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/statuses/d07bc6eed44011c0aaafa299b049e9a86b31283a","head":{"label":"nguyenthinhhn:testchatbot","ref":"testchatbot","sha":"d07bc6eed44011c0aaafa299b049e9a86b31283a","user":{"login":"nguyenthinhhn","id":40859990,"node_id":"MDQ6VXNlcjQwODU5OTkw","avatar_url":"https://avatars0.githubusercontent.com/u/40859990?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenthinhhn","html_url":"https://github.com/nguyenthinhhn","followers_url":"https://api.github.com/users/nguyenthinhhn/followers","following_url":"https://api.github.com/users/nguyenthinhhn/following{/other_user}","gists_url":"https://api.github.com/users/nguyenthinhhn/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenthinhhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenthinhhn/subscriptions","organizations_url":"https://api.github.com/users/nguyenthinhhn/orgs","repos_url":"https://api.github.com/users/nguyenthinhhn/repos","events_url":"https://api.github.com/users/nguyenthinhhn/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenthinhhn/received_events","type":"User","site_admin":false},"repo":{"id":222822502,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI4MjI1MDI=","name":"chatwork-forwarder","full_name":"nguyenthinhhn/chatwork-forwarder","private":false,"owner":{"login":"nguyenthinhhn","id":40859990,"node_id":"MDQ6VXNlcjQwODU5OTkw","avatar_url":"https://avatars0.githubusercontent.com/u/40859990?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenthinhhn","html_url":"https://github.com/nguyenthinhhn","followers_url":"https://api.github.com/users/nguyenthinhhn/followers","following_url":"https://api.github.com/users/nguyenthinhhn/following{/other_user}","gists_url":"https://api.github.com/users/nguyenthinhhn/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenthinhhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenthinhhn/subscriptions","organizations_url":"https://api.github.com/users/nguyenthinhhn/orgs","repos_url":"https://api.github.com/users/nguyenthinhhn/repos","events_url":"https://api.github.com/users/nguyenthinhhn/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenthinhhn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nguyenthinhhn/chatwork-forwarder","description":null,"fork":true,"url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder","forks_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/forks","keys_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/teams","hooks_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/hooks","issue_events_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/issues/events{/number}","events_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/events","assignees_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/assignees{/user}","branches_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/branches{/branch}","tags_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/tags","blobs_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/git/refs{/sha}","trees_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/statuses/{sha}","languages_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/languages","stargazers_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/stargazers","contributors_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/contributors","subscribers_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/subscribers","subscription_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/subscription","commits_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/commits{/sha}","git_commits_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/git/commits{/sha}","comments_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/comments{/number}","issue_comment_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/issues/comments{/number}","contents_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/contents/{+path}","compare_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/merges","archive_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/downloads","issues_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/issues{/number}","pulls_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/pulls{/number}","milestones_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/milestones{/number}","notifications_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/labels{/name}","releases_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/releases{/id}","deployments_url":"https://api.github.com/repos/nguyenthinhhn/chatwork-forwarder/deployments","created_at":"2019-11-20T01:16:19Z","updated_at":"2019-11-20T01:16:20Z","pushed_at":"2019-11-27T03:01:27Z","git_url":"git://github.com/nguyenthinhhn/chatwork-forwarder.git","ssh_url":"[email protected]:nguyenthinhhn/chatwork-forwarder.git","clone_url":"https://github.com/nguyenthinhhn/chatwork-forwarder.git","svn_url":"https://github.com/nguyenthinhhn/chatwork-forwarder","homepage":null,"size":1467,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sun-asterisk-research:develop","ref":"develop","sha":"4e2da8c229712f9462fe43add7c0927c67935e4c","user":{"login":"sun-asterisk-research","id":47969958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3OTY5OTU4","avatar_url":"https://avatars2.githubusercontent.com/u/47969958?v=4","gravatar_id":"","url":"https://api.github.com/users/sun-asterisk-research","html_url":"https://github.com/sun-asterisk-research","followers_url":"https://api.github.com/users/sun-asterisk-research/followers","following_url":"https://api.github.com/users/sun-asterisk-research/following{/other_user}","gists_url":"https://api.github.com/users/sun-asterisk-research/gists{/gist_id}","starred_url":"https://api.github.com/users/sun-asterisk-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sun-asterisk-research/subscriptions","organizations_url":"https://api.github.com/users/sun-asterisk-research/orgs","repos_url":"https://api.github.com/users/sun-asterisk-research/repos","events_url":"https://api.github.com/users/sun-asterisk-research/events{/privacy}","received_events_url":"https://api.github.com/users/sun-asterisk-research/received_events","type":"Organization","site_admin":false},"repo":{"id":220891447,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA4OTE0NDc=","name":"chatwork-forwarder","full_name":"sun-asterisk-research/chatwork-forwarder","private":false,"owner":{"login":"sun-asterisk-research","id":47969958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3OTY5OTU4","avatar_url":"https://avatars2.githubusercontent.com/u/47969958?v=4","gravatar_id":"","url":"https://api.github.com/users/sun-asterisk-research","html_url":"https://github.com/sun-asterisk-research","followers_url":"https://api.github.com/users/sun-asterisk-research/followers","following_url":"https://api.github.com/users/sun-asterisk-research/following{/other_user}","gists_url":"https://api.github.com/users/sun-asterisk-research/gists{/gist_id}","starred_url":"https://api.github.com/users/sun-asterisk-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sun-asterisk-research/subscriptions","organizations_url":"https://api.github.com/users/sun-asterisk-research/orgs","repos_url":"https://api.github.com/users/sun-asterisk-research/repos","events_url":"https://api.github.com/users/sun-asterisk-research/events{/privacy}","received_events_url":"https://api.github.com/users/sun-asterisk-research/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sun-asterisk-research/chatwork-forwarder","description":null,"fork":false,"url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder","forks_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/forks","keys_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/teams","hooks_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/hooks","issue_events_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/issues/events{/number}","events_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/events","assignees_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/assignees{/user}","branches_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/branches{/branch}","tags_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/tags","blobs_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/git/refs{/sha}","trees_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/statuses/{sha}","languages_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/languages","stargazers_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/stargazers","contributors_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/contributors","subscribers_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/subscribers","subscription_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/subscription","commits_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/commits{/sha}","git_commits_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/git/commits{/sha}","comments_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/comments{/number}","issue_comment_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/issues/comments{/number}","contents_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/contents/{+path}","compare_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/merges","archive_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/downloads","issues_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/issues{/number}","pulls_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls{/number}","milestones_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/milestones{/number}","notifications_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/labels{/name}","releases_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/releases{/id}","deployments_url":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/deployments","created_at":"2019-11-11T03:12:38Z","updated_at":"2019-11-26T07:36:49Z","pushed_at":"2019-11-27T03:01:28Z","git_url":"git://github.com/sun-asterisk-research/chatwork-forwarder.git","ssh_url":"[email protected]:sun-asterisk-research/chatwork-forwarder.git","clone_url":"https://github.com/sun-asterisk-research/chatwork-forwarder.git","svn_url":"https://github.com/sun-asterisk-research/chatwork-forwarder","homepage":null,"size":1482,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":7,"open_issues":1,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/20"},"html":{"href":"https://github.com/sun-asterisk-research/chatwork-forwarder/pull/20"},"issue":{"href":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/issues/20"},"comments":{"href":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder/statuses/d07bc6eed44011c0aaafa299b049e9a86b31283a"}},"author_association":"NONE"}}
|
{
"id": 220891447,
"name": "sun-asterisk-research/chatwork-forwarder",
"url": "https://api.github.com/repos/sun-asterisk-research/chatwork-forwarder"
}
|
{
"id": 40970418,
"login": "framgiaciv3",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/40970418?",
"url": "https://api.github.com/users/framgiaciv3"
}
|
{
"id": 47969958,
"login": "sun-asterisk-research",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47969958?",
"url": "https://api.github.com/orgs/sun-asterisk-research"
}
| 2019-11-27T03:03:04 |
10956422567
|
{"actor":{"display_login":"framgiaciv3"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/libra/libra/pulls/comments/341223900","pull_request_review_id":309994052,"id":341223900,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTIyMzkwMA==","diff_hunk":"@@ -1,14 +1,17 @@\n // Copyright (c) The Libra Core Contributors\n // SPDX-License-Identifier: Apache-2.0\n \n+use std::env;\n use std::process::Command;\n \n /// Save revision info to environment variable\n fn main() {\n- let output = Command::new(\"git\")\n- .args(&[\"rev-parse\", \"--short\", \"HEAD\"])\n- .output()\n- .unwrap();\n- let git_rev = String::from_utf8(output.stdout).unwrap();\n- println!(\"cargo:rustc-env=GIT_REVISION={}\", git_rev);\n+ if env::var(\"GIT_REV\").is_err() {\n+ let output = Command::new(\"git\")\n+ .args(&[\"rev-parse\", \"--short\", \"HEAD\"])\n+ .output()\n+ .unwrap();","path":"common/metrics/build.rs","position":19,"original_position":19,"commit_id":"481f1b0525a8c17ba39def31ff46374188bb9e10","original_commit_id":"7d8a623821224d74bfe01350d5f901e0185cce06","user":{"login":"sherry-x","id":55457892,"node_id":"MDQ6VXNlcjU1NDU3ODky","avatar_url":"https://avatars1.githubusercontent.com/u/55457892?v=4","gravatar_id":"","url":"https://api.github.com/users/sherry-x","html_url":"https://github.com/sherry-x","followers_url":"https://api.github.com/users/sherry-x/followers","following_url":"https://api.github.com/users/sherry-x/following{/other_user}","gists_url":"https://api.github.com/users/sherry-x/gists{/gist_id}","starred_url":"https://api.github.com/users/sherry-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherry-x/subscriptions","organizations_url":"https://api.github.com/users/sherry-x/orgs","repos_url":"https://api.github.com/users/sherry-x/repos","events_url":"https://api.github.com/users/sherry-x/events{/privacy}","received_events_url":"https://api.github.com/users/sherry-x/received_events","type":"User","site_admin":false},"body":"@andll It's harder than I thought to use unwrap_or here, because we need to pass a same type which is std::process::Output.","created_at":"2019-10-31T15:58:25Z","updated_at":"2019-10-31T15:59:17Z","html_url":"https://github.com/libra/libra/pull/1572#discussion_r341223900","pull_request_url":"https://api.github.com/repos/libra/libra/pulls/1572","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/libra/libra/pulls/comments/341223900"},"html":{"href":"https://github.com/libra/libra/pull/1572#discussion_r341223900"},"pull_request":{"href":"https://api.github.com/repos/libra/libra/pulls/1572"}},"in_reply_to_id":340906784},"pull_request":{"url":"https://api.github.com/repos/libra/libra/pulls/1572","id":334546722,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0NTQ2NzIy","html_url":"https://github.com/libra/libra/pull/1572","diff_url":"https://github.com/libra/libra/pull/1572.diff","patch_url":"https://github.com/libra/libra/pull/1572.patch","issue_url":"https://api.github.com/repos/libra/libra/issues/1572","number":1572,"state":"open","locked":false,"title":"Use GIT_REVISION env if already exist","user":{"login":"sherry-x","id":55457892,"node_id":"MDQ6VXNlcjU1NDU3ODky","avatar_url":"https://avatars1.githubusercontent.com/u/55457892?v=4","gravatar_id":"","url":"https://api.github.com/users/sherry-x","html_url":"https://github.com/sherry-x","followers_url":"https://api.github.com/users/sherry-x/followers","following_url":"https://api.github.com/users/sherry-x/following{/other_user}","gists_url":"https://api.github.com/users/sherry-x/gists{/gist_id}","starred_url":"https://api.github.com/users/sherry-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherry-x/subscriptions","organizations_url":"https://api.github.com/users/sherry-x/orgs","repos_url":"https://api.github.com/users/sherry-x/repos","events_url":"https://api.github.com/users/sherry-x/events{/privacy}","received_events_url":"https://api.github.com/users/sherry-x/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for sending a PR. We appreciate you spending time to help improve the Libra project.\r\n\r\nThe project is undergoing daily changes. Pull Requests will be reviewed and responded to as time permits.\r\n-->\r\n\r\n## Motivation\r\n\r\ndocker build is broken because the container has no git in it\r\n\r\n### Have you read the [Contributing Guidelines on pull requests](https://github.com/libra/libra/blob/master/CONTRIBUTING.md#pull-requests)?\r\n\r\nYes\r\n\r\n## Test Plan\r\n\r\nsuccessfully build docker image locally\r\n","created_at":"2019-10-30T22:18:14Z","updated_at":"2019-10-31T15:59:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4d3d3781b5b91d10b6f2112b20044be789c4c6f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andll","id":2972353,"node_id":"MDQ6VXNlcjI5NzIzNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2972353?v=4","gravatar_id":"","url":"https://api.github.com/users/andll","html_url":"https://github.com/andll","followers_url":"https://api.github.com/users/andll/followers","following_url":"https://api.github.com/users/andll/following{/other_user}","gists_url":"https://api.github.com/users/andll/gists{/gist_id}","starred_url":"https://api.github.com/users/andll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andll/subscriptions","organizations_url":"https://api.github.com/users/andll/orgs","repos_url":"https://api.github.com/users/andll/repos","events_url":"https://api.github.com/users/andll/events{/privacy}","received_events_url":"https://api.github.com/users/andll/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libra/libra/pulls/1572/commits","review_comments_url":"https://api.github.com/repos/libra/libra/pulls/1572/comments","review_comment_url":"https://api.github.com/repos/libra/libra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libra/libra/issues/1572/comments","statuses_url":"https://api.github.com/repos/libra/libra/statuses/481f1b0525a8c17ba39def31ff46374188bb9e10","head":{"label":"sherry-x:fix_git","ref":"fix_git","sha":"481f1b0525a8c17ba39def31ff46374188bb9e10","user":{"login":"sherry-x","id":55457892,"node_id":"MDQ6VXNlcjU1NDU3ODky","avatar_url":"https://avatars1.githubusercontent.com/u/55457892?v=4","gravatar_id":"","url":"https://api.github.com/users/sherry-x","html_url":"https://github.com/sherry-x","followers_url":"https://api.github.com/users/sherry-x/followers","following_url":"https://api.github.com/users/sherry-x/following{/other_user}","gists_url":"https://api.github.com/users/sherry-x/gists{/gist_id}","starred_url":"https://api.github.com/users/sherry-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherry-x/subscriptions","organizations_url":"https://api.github.com/users/sherry-x/orgs","repos_url":"https://api.github.com/users/sherry-x/repos","events_url":"https://api.github.com/users/sherry-x/events{/privacy}","received_events_url":"https://api.github.com/users/sherry-x/received_events","type":"User","site_admin":false},"repo":{"id":209161015,"node_id":"MDEwOlJlcG9zaXRvcnkyMDkxNjEwMTU=","name":"libra","full_name":"sherry-x/libra","private":false,"owner":{"login":"sherry-x","id":55457892,"node_id":"MDQ6VXNlcjU1NDU3ODky","avatar_url":"https://avatars1.githubusercontent.com/u/55457892?v=4","gravatar_id":"","url":"https://api.github.com/users/sherry-x","html_url":"https://github.com/sherry-x","followers_url":"https://api.github.com/users/sherry-x/followers","following_url":"https://api.github.com/users/sherry-x/following{/other_user}","gists_url":"https://api.github.com/users/sherry-x/gists{/gist_id}","starred_url":"https://api.github.com/users/sherry-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherry-x/subscriptions","organizations_url":"https://api.github.com/users/sherry-x/orgs","repos_url":"https://api.github.com/users/sherry-x/repos","events_url":"https://api.github.com/users/sherry-x/events{/privacy}","received_events_url":"https://api.github.com/users/sherry-x/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sherry-x/libra","description":"Libraโs mission is to enable a simple global currency and financial infrastructure that empowers billions of people.","fork":true,"url":"https://api.github.com/repos/sherry-x/libra","forks_url":"https://api.github.com/repos/sherry-x/libra/forks","keys_url":"https://api.github.com/repos/sherry-x/libra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sherry-x/libra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sherry-x/libra/teams","hooks_url":"https://api.github.com/repos/sherry-x/libra/hooks","issue_events_url":"https://api.github.com/repos/sherry-x/libra/issues/events{/number}","events_url":"https://api.github.com/repos/sherry-x/libra/events","assignees_url":"https://api.github.com/repos/sherry-x/libra/assignees{/user}","branches_url":"https://api.github.com/repos/sherry-x/libra/branches{/branch}","tags_url":"https://api.github.com/repos/sherry-x/libra/tags","blobs_url":"https://api.github.com/repos/sherry-x/libra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sherry-x/libra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sherry-x/libra/git/refs{/sha}","trees_url":"https://api.github.com/repos/sherry-x/libra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sherry-x/libra/statuses/{sha}","languages_url":"https://api.github.com/repos/sherry-x/libra/languages","stargazers_url":"https://api.github.com/repos/sherry-x/libra/stargazers","contributors_url":"https://api.github.com/repos/sherry-x/libra/contributors","subscribers_url":"https://api.github.com/repos/sherry-x/libra/subscribers","subscription_url":"https://api.github.com/repos/sherry-x/libra/subscription","commits_url":"https://api.github.com/repos/sherry-x/libra/commits{/sha}","git_commits_url":"https://api.github.com/repos/sherry-x/libra/git/commits{/sha}","comments_url":"https://api.github.com/repos/sherry-x/libra/comments{/number}","issue_comment_url":"https://api.github.com/repos/sherry-x/libra/issues/comments{/number}","contents_url":"https://api.github.com/repos/sherry-x/libra/contents/{+path}","compare_url":"https://api.github.com/repos/sherry-x/libra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sherry-x/libra/merges","archive_url":"https://api.github.com/repos/sherry-x/libra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sherry-x/libra/downloads","issues_url":"https://api.github.com/repos/sherry-x/libra/issues{/number}","pulls_url":"https://api.github.com/repos/sherry-x/libra/pulls{/number}","milestones_url":"https://api.github.com/repos/sherry-x/libra/milestones{/number}","notifications_url":"https://api.github.com/repos/sherry-x/libra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sherry-x/libra/labels{/name}","releases_url":"https://api.github.com/repos/sherry-x/libra/releases{/id}","deployments_url":"https://api.github.com/repos/sherry-x/libra/deployments","created_at":"2019-09-17T21:37:06Z","updated_at":"2019-10-28T20:46:15Z","pushed_at":"2019-10-31T00:04:32Z","git_url":"git://github.com/sherry-x/libra.git","ssh_url":"[email protected]:sherry-x/libra.git","clone_url":"https://github.com/sherry-x/libra.git","svn_url":"https://github.com/sherry-x/libra","homepage":"https://libra.org","size":9764,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libra:master","ref":"master","sha":"570a5509fac1604de4c11870639949c4acbdc24a","user":{"login":"libra","id":48265171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MjY1MTcx","avatar_url":"https://avatars1.githubusercontent.com/u/48265171?v=4","gravatar_id":"","url":"https://api.github.com/users/libra","html_url":"https://github.com/libra","followers_url":"https://api.github.com/users/libra/followers","following_url":"https://api.github.com/users/libra/following{/other_user}","gists_url":"https://api.github.com/users/libra/gists{/gist_id}","starred_url":"https://api.github.com/users/libra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libra/subscriptions","organizations_url":"https://api.github.com/users/libra/orgs","repos_url":"https://api.github.com/users/libra/repos","events_url":"https://api.github.com/users/libra/events{/privacy}","received_events_url":"https://api.github.com/users/libra/received_events","type":"Organization","site_admin":false},"repo":{"id":179164257,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkxNjQyNTc=","name":"libra","full_name":"libra/libra","private":false,"owner":{"login":"libra","id":48265171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MjY1MTcx","avatar_url":"https://avatars1.githubusercontent.com/u/48265171?v=4","gravatar_id":"","url":"https://api.github.com/users/libra","html_url":"https://github.com/libra","followers_url":"https://api.github.com/users/libra/followers","following_url":"https://api.github.com/users/libra/following{/other_user}","gists_url":"https://api.github.com/users/libra/gists{/gist_id}","starred_url":"https://api.github.com/users/libra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libra/subscriptions","organizations_url":"https://api.github.com/users/libra/orgs","repos_url":"https://api.github.com/users/libra/repos","events_url":"https://api.github.com/users/libra/events{/privacy}","received_events_url":"https://api.github.com/users/libra/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libra/libra","description":"Libraโs mission is to enable a simple global currency and financial infrastructure that empowers billions of people.","fork":false,"url":"https://api.github.com/repos/libra/libra","forks_url":"https://api.github.com/repos/libra/libra/forks","keys_url":"https://api.github.com/repos/libra/libra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libra/libra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libra/libra/teams","hooks_url":"https://api.github.com/repos/libra/libra/hooks","issue_events_url":"https://api.github.com/repos/libra/libra/issues/events{/number}","events_url":"https://api.github.com/repos/libra/libra/events","assignees_url":"https://api.github.com/repos/libra/libra/assignees{/user}","branches_url":"https://api.github.com/repos/libra/libra/branches{/branch}","tags_url":"https://api.github.com/repos/libra/libra/tags","blobs_url":"https://api.github.com/repos/libra/libra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libra/libra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libra/libra/git/refs{/sha}","trees_url":"https://api.github.com/repos/libra/libra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libra/libra/statuses/{sha}","languages_url":"https://api.github.com/repos/libra/libra/languages","stargazers_url":"https://api.github.com/repos/libra/libra/stargazers","contributors_url":"https://api.github.com/repos/libra/libra/contributors","subscribers_url":"https://api.github.com/repos/libra/libra/subscribers","subscription_url":"https://api.github.com/repos/libra/libra/subscription","commits_url":"https://api.github.com/repos/libra/libra/commits{/sha}","git_commits_url":"https://api.github.com/repos/libra/libra/git/commits{/sha}","comments_url":"https://api.github.com/repos/libra/libra/comments{/number}","issue_comment_url":"https://api.github.com/repos/libra/libra/issues/comments{/number}","contents_url":"https://api.github.com/repos/libra/libra/contents/{+path}","compare_url":"https://api.github.com/repos/libra/libra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libra/libra/merges","archive_url":"https://api.github.com/repos/libra/libra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libra/libra/downloads","issues_url":"https://api.github.com/repos/libra/libra/issues{/number}","pulls_url":"https://api.github.com/repos/libra/libra/pulls{/number}","milestones_url":"https://api.github.com/repos/libra/libra/milestones{/number}","notifications_url":"https://api.github.com/repos/libra/libra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libra/libra/labels{/name}","releases_url":"https://api.github.com/repos/libra/libra/releases{/id}","deployments_url":"https://api.github.com/repos/libra/libra/deployments","created_at":"2019-04-02T21:51:45Z","updated_at":"2019-10-31T15:15:00Z","pushed_at":"2019-10-31T06:12:44Z","git_url":"git://github.com/libra/libra.git","ssh_url":"[email protected]:libra/libra.git","clone_url":"https://github.com/libra/libra.git","svn_url":"https://github.com/libra/libra","homepage":"https://libra.org","size":8969,"stargazers_count":13074,"watchers_count":13074,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1931,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":260,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1931,"open_issues":260,"watchers":13074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libra/libra/pulls/1572"},"html":{"href":"https://github.com/libra/libra/pull/1572"},"issue":{"href":"https://api.github.com/repos/libra/libra/issues/1572"},"comments":{"href":"https://api.github.com/repos/libra/libra/issues/1572/comments"},"review_comments":{"href":"https://api.github.com/repos/libra/libra/pulls/1572/comments"},"review_comment":{"href":"https://api.github.com/repos/libra/libra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libra/libra/pulls/1572/commits"},"statuses":{"href":"https://api.github.com/repos/libra/libra/statuses/481f1b0525a8c17ba39def31ff46374188bb9e10"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 179164257,
"name": "libra/libra",
"url": "https://api.github.com/repos/libra/libra"
}
|
{
"id": 55457892,
"login": "sherry-x",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55457892?",
"url": "https://api.github.com/users/sherry-x"
}
|
{
"id": 48265171,
"login": "libra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48265171?",
"url": "https://api.github.com/orgs/libra"
}
| 2019-10-31T15:58:25 |
10759064117
|
{"actor":{"display_login":"sherry-x"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/libra/libra/pulls/comments/362330734","pull_request_review_id":337494520,"id":362330734,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MjMzMDczNA==","diff_hunk":"@@ -85,6 +87,102 @@ impl AbstractValue {\n pub fn new_value(token: SignatureToken, kind: Kind) -> AbstractValue {\n AbstractValue { token, kind }\n }\n+\n+ /// Predicate on whether the type of the abstract value is generic -- it is if it contains a\n+ /// type parameter.\n+ pub fn is_generic(&self) -> bool {\n+ Self::is_generic_token(&self.token)\n+ }\n+\n+ fn is_generic_token(token: &SignatureToken) -> bool {\n+ match token {\n+ SignatureToken::TypeParameter(_) => true,\n+ SignatureToken::Struct(_, tys) => tys.iter().any(Self::is_generic_token),\n+ SignatureToken::Reference(tok) | SignatureToken::MutableReference(tok) => {\n+ Self::is_generic_token(tok)\n+ }\n+ _ => false,\n+ }\n+ }\n+}\n+\n+/// During the generation of a bytecode sequence, specific instantiations may need to be made, that\n+/// may not yet exist in the underlying module. Instead of mutating the underlying module (which\n+/// would require an into_inner followd by a freeze) in order to record these instantiations in the\n+/// locals signature table, we instead build wrapper around the underlying module containing the\n+/// type instantiations, and at the end materialize this updated signature pool into a module. We\n+/// also need the ability to quickly determine if an instantiation has already been created, and if\n+/// so, at which index. So this also keeps a reverse lookup table of instantiation to\n+/// LocalsSignatureIndex.\n+#[derive(Debug, Clone)]\n+pub struct InstantiableModule {\n+ // A reverse lookup table for instantiations.\n+ instance_for_offset: Vec<Vec<SignatureToken>>,\n+ instantiations: HashMap<Vec<SignatureToken>, LocalsSignatureIndex>,\n+ pub module: CompiledModule,\n+}\n+\n+impl InstantiableModule {\n+ pub fn new(module: CompiledModule) -> Self {\n+ Self {\n+ instantiations: module\n+ .locals_signatures()\n+ .iter()\n+ .enumerate()\n+ .map(|(index, sig)| (sig.0.clone(), LocalsSignatureIndex(index as TableIndex)))\n+ .collect::<HashMap<_, _>>(),\n+ instance_for_offset: module\n+ .locals_signatures()\n+ .iter()\n+ .map(|loc_sig| loc_sig.0.clone())\n+ .collect(),\n+ module,\n+ }\n+ }\n+\n+ /// If the `instantiant` is not in the `instantiations` table, this sdds the instantiant to the\n+ /// `instance_for_offset` for table, and adds the index to the reverse lookup table. Returns\n+ /// the LocalsSignatureIndex for the `instantiant`.\n+ pub fn add_instantiation(&mut self, instantiant: Vec<SignatureToken>) -> LocalsSignatureIndex {\n+ match self.instantiations.get(&instantiant) {\n+ Some(index) => *index,\n+ None => {\n+ let current_index =\n+ LocalsSignatureIndex(self.instance_for_offset.len() as TableIndex);\n+ self.instantiations\n+ .insert(instantiant.clone(), current_index);\n+ self.instance_for_offset.push(instantiant);\n+ current_index\n+ }\n+ }\n+ }\n+\n+ /// Returns the type instantiation at `index`. Errors if the instantiation does not exist.\n+ pub fn instantiantiation_at(&self, index: LocalsSignatureIndex) -> &Vec<SignatureToken> {\n+ match self.instance_for_offset.get(index.0 as usize) {\n+ Some(vec) => vec,\n+ None => {\n+ panic!(\"Unable to get instantiation at offset: {:#?}\", index);\n+ }\n+ }\n+ }\n+\n+ /// Consumes self, and adds the instantiations that have been built up to the underlying\n+ /// module, and returns the resultant compiled module.\n+ pub fn instantiate(self) -> CompiledModuleMut {\n+ let index = self.module.locals_signatures().len();","path":"language/tools/test-generation/src/abstract_state.rs","position":99,"original_position":99,"commit_id":"a75484df21d6b0cafecf4d3ff9d887d36eeb2907","original_commit_id":"a75484df21d6b0cafecf4d3ff9d887d36eeb2907","user":{"login":"dariorussi","id":4442497,"node_id":"MDQ6VXNlcjQ0NDI0OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4442497?v=4","gravatar_id":"","url":"https://api.github.com/users/dariorussi","html_url":"https://github.com/dariorussi","followers_url":"https://api.github.com/users/dariorussi/followers","following_url":"https://api.github.com/users/dariorussi/following{/other_user}","gists_url":"https://api.github.com/users/dariorussi/gists{/gist_id}","starred_url":"https://api.github.com/users/dariorussi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariorussi/subscriptions","organizations_url":"https://api.github.com/users/dariorussi/orgs","repos_url":"https://api.github.com/users/dariorussi/repos","events_url":"https://api.github.com/users/dariorussi/events{/privacy}","received_events_url":"https://api.github.com/users/dariorussi/received_events","type":"User","site_admin":false},"body":"just out of curiosity and to see what I am missing... why not use `instance_for_offset` directly here?","created_at":"2020-01-01T16:03:22Z","updated_at":"2020-01-01T16:25:47Z","html_url":"https://github.com/libra/libra/pull/2054#discussion_r362330734","pull_request_url":"https://api.github.com/repos/libra/libra/pulls/2054","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/libra/libra/pulls/comments/362330734"},"html":{"href":"https://github.com/libra/libra/pull/2054#discussion_r362330734"},"pull_request":{"href":"https://api.github.com/repos/libra/libra/pulls/2054"}}},"pull_request":{"url":"https://api.github.com/repos/libra/libra/pulls/2054","id":353946263,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzOTQ2MjYz","html_url":"https://github.com/libra/libra/pull/2054","diff_url":"https://github.com/libra/libra/pull/2054.diff","patch_url":"https://github.com/libra/libra/pull/2054.patch","issue_url":"https://api.github.com/repos/libra/libra/issues/2054","number":2054,"state":"open","locked":false,"title":"[test-generation] Allow generation of generic structs and functions","user":{"login":"tzakian","id":2895723,"node_id":"MDQ6VXNlcjI4OTU3MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2895723?v=4","gravatar_id":"","url":"https://api.github.com/users/tzakian","html_url":"https://github.com/tzakian","followers_url":"https://api.github.com/users/tzakian/followers","following_url":"https://api.github.com/users/tzakian/following{/other_user}","gists_url":"https://api.github.com/users/tzakian/gists{/gist_id}","starred_url":"https://api.github.com/users/tzakian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzakian/subscriptions","organizations_url":"https://api.github.com/users/tzakian/orgs","repos_url":"https://api.github.com/users/tzakian/repos","events_url":"https://api.github.com/users/tzakian/events{/privacy}","received_events_url":"https://api.github.com/users/tzakian/received_events","type":"User","site_admin":false},"body":"This PR adds generics to test generation. \r\n\r\nThis has a number of effects, and I'll try to explain some of the high-level ideas here. I'll first explain the reasoning for structs, and the reasoning for function calls is similar (although in many aspects, easier). \r\n\r\n#### Current Status:\r\nReady for review.\r\n\r\n## Structs/Resources\r\nWe shall assume throughout that we have the following struct definitions:\r\n```rust\r\nstruct A<T: All> {\r\n a: T,\r\n} \r\n\r\nstruct C<T: Unrestricted, L: Resource> {\r\n c: L\r\n}\r\n\r\nstruct D<T: Unrestricted, L: Unrestricted> {\r\n d: T\r\n e: B\r\n}\r\n\r\nstruct E<T: Unrestricted> {\r\n f: T,\r\n g: T,\r\n}\r\n```\r\n\r\nLet's first take a look at some examples:\r\n#### 1: Inferring Instantiations (complete case)\r\nWe have a (abstract) stack that looks like the following: `[..., U64]`. Then we need to _infer_ the instantiation of `A` to be `U64`;\r\n```rust\r\nPack(A, <u64>)\r\n```\r\n\r\nSimilarly, if we have a abstract stack of `[..., T]`, then we need to _infer_ the instantiation:\r\n```rust\r\nPack(A, <T>)\r\n```\r\n\r\nAs well, if we have an abstract stack like the following: `[..., T, A<T>]` we need to _infer_ the instantiation\r\n```rust\r\nPack(D, <T, A<T>>) \r\n```\r\nThis work is done by the `Subst` struct and the method `check_and_add` in `transitions.rs`, and in the `stack_struct_satisfies_signature`. There is also sub-kinding that is handled -- making sure that the kinds of `T` and `A<T>` are `subkinds` of the expected kinds for the parameters.\r\n\r\nWe also make sure in this substitution creation that the substitution works across fields of the same type e.g. if we had the following stack `[..., Bool, U64]` we could not infer an instantiation for `E`:\r\n```rust\r\ncheck_and_add(subst = {}, Bool, T) ~~> subst = {T |-> Bool};\r\ncheck_and_add(subst = {T |-> Bool}, U64, T) ~~> U64 == subst(T) ~~> U64 == Bool ~~> false\r\n```\r\n\r\n#### 2: Inferred, but incomplete instantiations\r\n\r\nTake the following abstract stack: `[..., L:R]`. Then according to the rules specified above, we can generate a `Pack` of `C`. However, we have a problem: the types on the abstract stack are not enough for us to fully determine the full instantiation of `C` -- we have a partial instantiation, with `T` being free. In this case we simply choose a type to instantiate with (currently `U64`, but we could do something different although I'm not sure what benefit we would get from it). We don't handle free resource instantiations...yet. \r\n\r\n#### 3: Checked\r\n\r\nThe control flow graph that is generated for bytecode generation specifies starting states for the start and end of every basic block. One of these properties are the sets of locals that are `Available` or `Unavailable` (have had their value moved out of them). In such a setting, we may need to generate a bytecode sequence that inhabits a _particular_ type. In most cases \"checked\" vs \"inferred\" cases matchup. However, in the case of a \"free\" type variable we run into issues--in the inferred context, the typing information is flowed from the abstract state to the bytecode generation, whereas in this case (the inhabitation of a _particular_ type) we need to flow the information the other way around -- from the bytecode generation into the abstract state and instantiation. If we only flowed from the abstract state, we could not generate a local of type `C<Bool, L>` (where `L` has kind `Resource`)--we could succeed in choosing `L` from the abstract stack, but when it came time to choose the instantiation for the \"`T`\" parameter of `C` we simply don't have enough information in inferred mode. This is where the `exact` flag comes into play for the summaries -- it serves as a flag to determine the direction that typing information should flow. \r\n\r\n#### 4: Unpack\r\nThis is relatively straightforward -- we grab the instantiation of the struct to be unpacked from the abstract stack, and perform type substitution on each field. We likewise use this as the instantiation for the `Unpack` instruction. \r\n\r\n#### General \r\n\r\nIn all of the cases above, the effects to the stack are dependent upon the instantiation chosen. Therefore the effects for the instructions summaries have been updated to encapsulate this e.g. `Call` and `Pack` have effects that are dependent upon the instantiation chosen (since e.g. in the `Pack` case the instantiation could cause a non-resource or resource to be pushed on the stack). \r\n\r\n## Functions\r\nThese are relatively straightforward, and follow the same kind of path as structs.\r\n\r\n# The Details\r\n\r\n## Changes to the Abstract State\r\n\r\n#### Addition of `InstantiableModule`\r\nSince we can now create instantiations in the process of generating bytecode, we need to be able to intern these, and have the ability to (1) see if the instantiation (a `Vec<SignatureToken>`) has already been interned, and if so the index of it in the table, (2) intern an instantiation, and return the index of that instantiation (in the `LocalsSignaturePool`), and (3) get the instantiation for a `LocalsSignatureIndex`. We do this by wrapping the module with a hashmap of instantiation to `LocalsSignatureIndex` and likewise have a reverse lookup table of `LocalsSignatureIndex` to instantiation (represented as a vector). Since the abstract state is thrown away from one block to another, we need to `instantiate` the module at the end of every block, and use this new module for the next block.\r\n\r\n#### Addition of `instantiation` field\r\nThis represents the kinds for the type parameters of the function that we are in. e.g. if we are generating bytecode within a function `f<T: Unrestricted, L: All>(...) { ... }` the `instantiation` field will be `[Unrestricted, All]`.\r\n\r\n#### Addition of `control_flow_allowed`\r\nWe do _not_ want to automatically generate control instructions. However, we also need to be able to manually add these, and apply their effects to the abstract state, so we have this flag that we manually set to allow us to insert these operations, but this won't be set when we are trying to generate random instructions and therefore they will never be selected as possible instructions.\r\n\r\n## Changes to transitions\r\n\r\nThe main change is that we now need to determine the instantiations for instructions (or, in the checked mode for locals, verify that the state is amenable to the particular instruction/instantiation combination). To infer the instantiation we have the `check_and_add` function in `Subst`. This allows us to build up an instantiation mapping of `<ty param offset> -> type on stack`. We then use this as the final mapping for creating an instantiation (after filling in \"free\" type parameters). We also use this to verify the substitution works for all fields. \r\n\r\nWe also have this idea of `exact`ness -- this is specifying which way the information flow is going \"inexact` is saying that type info is inferred from the stack, and \"exact\" is saying that it is being provided, or pushed down from generation.\r\n\r\n## Key things to keep in mind\r\n* We cannot narrow a stack type (either by type, or kind). But, we can narrow an instantiation kind, or type to match the type on the stack.\r\n* We need to flow type information both from the abstract state \"what instantiation should I have for this instruction\" and we also need to flow the type information the other way \"I need an instruction with exactly this type, make sure it works and apply it to the state\".\r\n\r\n### Things we don't do\r\n* Inhabitation of locals with a generic parameter...This is \"future work\"(!?!?). Tell me how to generate a value of a generic type `T` and I'll tell you you're wrong (or, you're right, and I'll be happy to help you apply for a Turing award....).\r\n* Any types of references -- I turned these instructions off until we get the borrow graph in. Without we can't really have references in the presence of structs (etc).\r\n\r\n## Future work\r\n* Need to optimize this, there's a lot of low-hanging fruit here for cleanup and optimization. But that's for a future PR.\r\n* We can sometimes generate functions bodies that are too large -- we sometimes cause a panic in the `control_flow_graph` in the bytecode verifier (and also during serialization of the blocks internally sometimes as well) since we overflow a `u16`. We need to have checks for this and fail elegantly in these cases (especially in the bytecode verifier!)\r\n* Better bounding of the value and call stacks -- we sometimes overflow these. We need to encode back pressure more effectively off of these during the generation phase.\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2019-12-17T06:53:32Z","updated_at":"2020-01-01T16:25:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ed907a59206072618c453054c701a3ba7aba69f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shazqadeer","id":7672086,"node_id":"MDQ6VXNlcjc2NzIwODY=","avatar_url":"https://avatars2.githubusercontent.com/u/7672086?v=4","gravatar_id":"","url":"https://api.github.com/users/shazqadeer","html_url":"https://github.com/shazqadeer","followers_url":"https://api.github.com/users/shazqadeer/followers","following_url":"https://api.github.com/users/shazqadeer/following{/other_user}","gists_url":"https://api.github.com/users/shazqadeer/gists{/gist_id}","starred_url":"https://api.github.com/users/shazqadeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazqadeer/subscriptions","organizations_url":"https://api.github.com/users/shazqadeer/orgs","repos_url":"https://api.github.com/users/shazqadeer/repos","events_url":"https://api.github.com/users/shazqadeer/events{/privacy}","received_events_url":"https://api.github.com/users/shazqadeer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libra/libra/pulls/2054/commits","review_comments_url":"https://api.github.com/repos/libra/libra/pulls/2054/comments","review_comment_url":"https://api.github.com/repos/libra/libra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libra/libra/issues/2054/comments","statuses_url":"https://api.github.com/repos/libra/libra/statuses/a75484df21d6b0cafecf4d3ff9d887d36eeb2907","head":{"label":"tzakian:test_generation_with_generics","ref":"test_generation_with_generics","sha":"a75484df21d6b0cafecf4d3ff9d887d36eeb2907","user":{"login":"tzakian","id":2895723,"node_id":"MDQ6VXNlcjI4OTU3MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2895723?v=4","gravatar_id":"","url":"https://api.github.com/users/tzakian","html_url":"https://github.com/tzakian","followers_url":"https://api.github.com/users/tzakian/followers","following_url":"https://api.github.com/users/tzakian/following{/other_user}","gists_url":"https://api.github.com/users/tzakian/gists{/gist_id}","starred_url":"https://api.github.com/users/tzakian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzakian/subscriptions","organizations_url":"https://api.github.com/users/tzakian/orgs","repos_url":"https://api.github.com/users/tzakian/repos","events_url":"https://api.github.com/users/tzakian/events{/privacy}","received_events_url":"https://api.github.com/users/tzakian/received_events","type":"User","site_admin":false},"repo":{"id":198350319,"node_id":"MDEwOlJlcG9zaXRvcnkxOTgzNTAzMTk=","name":"libra","full_name":"tzakian/libra","private":false,"owner":{"login":"tzakian","id":2895723,"node_id":"MDQ6VXNlcjI4OTU3MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2895723?v=4","gravatar_id":"","url":"https://api.github.com/users/tzakian","html_url":"https://github.com/tzakian","followers_url":"https://api.github.com/users/tzakian/followers","following_url":"https://api.github.com/users/tzakian/following{/other_user}","gists_url":"https://api.github.com/users/tzakian/gists{/gist_id}","starred_url":"https://api.github.com/users/tzakian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzakian/subscriptions","organizations_url":"https://api.github.com/users/tzakian/orgs","repos_url":"https://api.github.com/users/tzakian/repos","events_url":"https://api.github.com/users/tzakian/events{/privacy}","received_events_url":"https://api.github.com/users/tzakian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tzakian/libra","description":"Libraโs mission is to enable a simple global currency and financial infrastructure that empowers billions of people.","fork":true,"url":"https://api.github.com/repos/tzakian/libra","forks_url":"https://api.github.com/repos/tzakian/libra/forks","keys_url":"https://api.github.com/repos/tzakian/libra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tzakian/libra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tzakian/libra/teams","hooks_url":"https://api.github.com/repos/tzakian/libra/hooks","issue_events_url":"https://api.github.com/repos/tzakian/libra/issues/events{/number}","events_url":"https://api.github.com/repos/tzakian/libra/events","assignees_url":"https://api.github.com/repos/tzakian/libra/assignees{/user}","branches_url":"https://api.github.com/repos/tzakian/libra/branches{/branch}","tags_url":"https://api.github.com/repos/tzakian/libra/tags","blobs_url":"https://api.github.com/repos/tzakian/libra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tzakian/libra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tzakian/libra/git/refs{/sha}","trees_url":"https://api.github.com/repos/tzakian/libra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tzakian/libra/statuses/{sha}","languages_url":"https://api.github.com/repos/tzakian/libra/languages","stargazers_url":"https://api.github.com/repos/tzakian/libra/stargazers","contributors_url":"https://api.github.com/repos/tzakian/libra/contributors","subscribers_url":"https://api.github.com/repos/tzakian/libra/subscribers","subscription_url":"https://api.github.com/repos/tzakian/libra/subscription","commits_url":"https://api.github.com/repos/tzakian/libra/commits{/sha}","git_commits_url":"https://api.github.com/repos/tzakian/libra/git/commits{/sha}","comments_url":"https://api.github.com/repos/tzakian/libra/comments{/number}","issue_comment_url":"https://api.github.com/repos/tzakian/libra/issues/comments{/number}","contents_url":"https://api.github.com/repos/tzakian/libra/contents/{+path}","compare_url":"https://api.github.com/repos/tzakian/libra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tzakian/libra/merges","archive_url":"https://api.github.com/repos/tzakian/libra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tzakian/libra/downloads","issues_url":"https://api.github.com/repos/tzakian/libra/issues{/number}","pulls_url":"https://api.github.com/repos/tzakian/libra/pulls{/number}","milestones_url":"https://api.github.com/repos/tzakian/libra/milestones{/number}","notifications_url":"https://api.github.com/repos/tzakian/libra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tzakian/libra/labels{/name}","releases_url":"https://api.github.com/repos/tzakian/libra/releases{/id}","deployments_url":"https://api.github.com/repos/tzakian/libra/deployments","created_at":"2019-07-23T04:13:41Z","updated_at":"2019-07-23T04:13:46Z","pushed_at":"2019-12-30T07:37:19Z","git_url":"git://github.com/tzakian/libra.git","ssh_url":"[email protected]:tzakian/libra.git","clone_url":"https://github.com/tzakian/libra.git","svn_url":"https://github.com/tzakian/libra","homepage":"https://libra.org","size":12541,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libra:master","ref":"master","sha":"b00f706e204327147a4ab52c479882601b0accf2","user":{"login":"libra","id":48265171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MjY1MTcx","avatar_url":"https://avatars1.githubusercontent.com/u/48265171?v=4","gravatar_id":"","url":"https://api.github.com/users/libra","html_url":"https://github.com/libra","followers_url":"https://api.github.com/users/libra/followers","following_url":"https://api.github.com/users/libra/following{/other_user}","gists_url":"https://api.github.com/users/libra/gists{/gist_id}","starred_url":"https://api.github.com/users/libra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libra/subscriptions","organizations_url":"https://api.github.com/users/libra/orgs","repos_url":"https://api.github.com/users/libra/repos","events_url":"https://api.github.com/users/libra/events{/privacy}","received_events_url":"https://api.github.com/users/libra/received_events","type":"Organization","site_admin":false},"repo":{"id":179164257,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkxNjQyNTc=","name":"libra","full_name":"libra/libra","private":false,"owner":{"login":"libra","id":48265171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MjY1MTcx","avatar_url":"https://avatars1.githubusercontent.com/u/48265171?v=4","gravatar_id":"","url":"https://api.github.com/users/libra","html_url":"https://github.com/libra","followers_url":"https://api.github.com/users/libra/followers","following_url":"https://api.github.com/users/libra/following{/other_user}","gists_url":"https://api.github.com/users/libra/gists{/gist_id}","starred_url":"https://api.github.com/users/libra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libra/subscriptions","organizations_url":"https://api.github.com/users/libra/orgs","repos_url":"https://api.github.com/users/libra/repos","events_url":"https://api.github.com/users/libra/events{/privacy}","received_events_url":"https://api.github.com/users/libra/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libra/libra","description":"Libraโs mission is to enable a simple global currency and financial infrastructure that empowers billions of people.","fork":false,"url":"https://api.github.com/repos/libra/libra","forks_url":"https://api.github.com/repos/libra/libra/forks","keys_url":"https://api.github.com/repos/libra/libra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libra/libra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libra/libra/teams","hooks_url":"https://api.github.com/repos/libra/libra/hooks","issue_events_url":"https://api.github.com/repos/libra/libra/issues/events{/number}","events_url":"https://api.github.com/repos/libra/libra/events","assignees_url":"https://api.github.com/repos/libra/libra/assignees{/user}","branches_url":"https://api.github.com/repos/libra/libra/branches{/branch}","tags_url":"https://api.github.com/repos/libra/libra/tags","blobs_url":"https://api.github.com/repos/libra/libra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libra/libra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libra/libra/git/refs{/sha}","trees_url":"https://api.github.com/repos/libra/libra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libra/libra/statuses/{sha}","languages_url":"https://api.github.com/repos/libra/libra/languages","stargazers_url":"https://api.github.com/repos/libra/libra/stargazers","contributors_url":"https://api.github.com/repos/libra/libra/contributors","subscribers_url":"https://api.github.com/repos/libra/libra/subscribers","subscription_url":"https://api.github.com/repos/libra/libra/subscription","commits_url":"https://api.github.com/repos/libra/libra/commits{/sha}","git_commits_url":"https://api.github.com/repos/libra/libra/git/commits{/sha}","comments_url":"https://api.github.com/repos/libra/libra/comments{/number}","issue_comment_url":"https://api.github.com/repos/libra/libra/issues/comments{/number}","contents_url":"https://api.github.com/repos/libra/libra/contents/{+path}","compare_url":"https://api.github.com/repos/libra/libra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libra/libra/merges","archive_url":"https://api.github.com/repos/libra/libra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libra/libra/downloads","issues_url":"https://api.github.com/repos/libra/libra/issues{/number}","pulls_url":"https://api.github.com/repos/libra/libra/pulls{/number}","milestones_url":"https://api.github.com/repos/libra/libra/milestones{/number}","notifications_url":"https://api.github.com/repos/libra/libra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libra/libra/labels{/name}","releases_url":"https://api.github.com/repos/libra/libra/releases{/id}","deployments_url":"https://api.github.com/repos/libra/libra/deployments","created_at":"2019-04-02T21:51:45Z","updated_at":"2020-01-01T15:47:18Z","pushed_at":"2019-12-31T23:39:47Z","git_url":"git://github.com/libra/libra.git","ssh_url":"[email protected]:libra/libra.git","clone_url":"https://github.com/libra/libra.git","svn_url":"https://github.com/libra/libra","homepage":"https://libra.org","size":12456,"stargazers_count":13659,"watchers_count":13659,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2022,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":300,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2022,"open_issues":300,"watchers":13659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libra/libra/pulls/2054"},"html":{"href":"https://github.com/libra/libra/pull/2054"},"issue":{"href":"https://api.github.com/repos/libra/libra/issues/2054"},"comments":{"href":"https://api.github.com/repos/libra/libra/issues/2054/comments"},"review_comments":{"href":"https://api.github.com/repos/libra/libra/pulls/2054/comments"},"review_comment":{"href":"https://api.github.com/repos/libra/libra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libra/libra/pulls/2054/commits"},"statuses":{"href":"https://api.github.com/repos/libra/libra/statuses/a75484df21d6b0cafecf4d3ff9d887d36eeb2907"}},"author_association":"NONE"}}
|
{
"id": 179164257,
"name": "libra/libra",
"url": "https://api.github.com/repos/libra/libra"
}
|
{
"id": 4442497,
"login": "dariorussi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4442497?",
"url": "https://api.github.com/users/dariorussi"
}
|
{
"id": 48265171,
"login": "libra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48265171?",
"url": "https://api.github.com/orgs/libra"
}
| 2020-01-01T16:03:22 |
11186935639
|
{"actor":{"display_login":"dariorussi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/comments/280581369","pull_request_review_id":233218245,"id":280581369,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDU4MTM2OQ==","diff_hunk":"@@ -0,0 +1,54 @@\n+package ru.sberbank.school.task02;\n+\n+import ru.sberbank.school.task02.exception.FxConversionException;\n+import ru.sberbank.school.task02.util.*;\n+\n+import java.math.BigDecimal;\n+import java.util.Comparator;\n+import java.util.List;\n+\n+public class Converter implements FxConversionService {\n+\n+ private ExternalQuotesService externalQuotes;\n+\n+ public Converter(ExternalQuotesService externalQuotesService){\n+ externalQuotes = externalQuotesService;\n+ }\n+\n+ @Override\n+ public BigDecimal convert(ClientOperation operation, Symbol symbol, BigDecimal amount) {\n+ List<Quote> quotes = externalQuotes.getQuotes(symbol);\n+ Volume volume = Volume.from(amount);\n+\n+ if(volume.isInfinity()) throw new FxConversionException(\"ะกัะผะผะฐ ะผะตะฝััะต ะธะปะธ ัะฐะฒะฝะฐ 0\");","path":"solutions/src/main/java/ru/sberbank/school/task02/Converter.java","position":23,"original_position":23,"commit_id":"59b9b318d39f204204840b3218eec21d816951de","original_commit_id":"59b9b318d39f204204840b3218eec21d816951de","user":{"login":"jenkins-java-school-2019","id":49533281,"node_id":"MDQ6VXNlcjQ5NTMzMjgx","avatar_url":"https://avatars0.githubusercontent.com/u/49533281?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-java-school-2019","html_url":"https://github.com/jenkins-java-school-2019","followers_url":"https://api.github.com/users/jenkins-java-school-2019/followers","following_url":"https://api.github.com/users/jenkins-java-school-2019/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-java-school-2019/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-java-school-2019/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-java-school-2019/subscriptions","organizations_url":"https://api.github.com/users/jenkins-java-school-2019/orgs","repos_url":"https://api.github.com/users/jenkins-java-school-2019/repos","events_url":"https://api.github.com/users/jenkins-java-school-2019/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-java-school-2019/received_events","type":"User","site_admin":false},"body":"WhitespaceAround: 'if' is not followed by whitespace.\n\n*<this is a auto generated comment from violation-comments-lib F7F8ASD8123FSDF>* *<a201554248>*","created_at":"2019-05-02T20:22:02Z","updated_at":"2019-05-02T20:22:02Z","html_url":"https://github.com/sberbankjavaschool/homework/pull/33#discussion_r280581369","pull_request_url":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/comments/280581369"},"html":{"href":"https://github.com/sberbankjavaschool/homework/pull/33#discussion_r280581369"},"pull_request":{"href":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/33","id":275505403,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1NTA1NDAz","html_url":"https://github.com/sberbankjavaschool/homework/pull/33","diff_url":"https://github.com/sberbankjavaschool/homework/pull/33.diff","patch_url":"https://github.com/sberbankjavaschool/homework/pull/33.patch","issue_url":"https://api.github.com/repos/sberbankjavaschool/homework/issues/33","number":33,"state":"open","locked":false,"title":"(2) ะะพะฑะฐะฝะพะฒะฐ","user":{"login":"alobanova","id":49763961,"node_id":"MDQ6VXNlcjQ5NzYzOTYx","avatar_url":"https://avatars0.githubusercontent.com/u/49763961?v=4","gravatar_id":"","url":"https://api.github.com/users/alobanova","html_url":"https://github.com/alobanova","followers_url":"https://api.github.com/users/alobanova/followers","following_url":"https://api.github.com/users/alobanova/following{/other_user}","gists_url":"https://api.github.com/users/alobanova/gists{/gist_id}","starred_url":"https://api.github.com/users/alobanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alobanova/subscriptions","organizations_url":"https://api.github.com/users/alobanova/orgs","repos_url":"https://api.github.com/users/alobanova/repos","events_url":"https://api.github.com/users/alobanova/events{/privacy}","received_events_url":"https://api.github.com/users/alobanova/received_events","type":"User","site_admin":false},"body":"Attempt โ1","created_at":"2019-05-02T20:21:02Z","updated_at":"2019-05-02T20:22:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e07b0c5de5386f6fd7b87af1a49c6605d937bd0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/33/commits","review_comments_url":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/33/comments","review_comment_url":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sberbankjavaschool/homework/issues/33/comments","statuses_url":"https://api.github.com/repos/sberbankjavaschool/homework/statuses/59b9b318d39f204204840b3218eec21d816951de","head":{"label":"alobanova:source","ref":"source","sha":"59b9b318d39f204204840b3218eec21d816951de","user":{"login":"alobanova","id":49763961,"node_id":"MDQ6VXNlcjQ5NzYzOTYx","avatar_url":"https://avatars0.githubusercontent.com/u/49763961?v=4","gravatar_id":"","url":"https://api.github.com/users/alobanova","html_url":"https://github.com/alobanova","followers_url":"https://api.github.com/users/alobanova/followers","following_url":"https://api.github.com/users/alobanova/following{/other_user}","gists_url":"https://api.github.com/users/alobanova/gists{/gist_id}","starred_url":"https://api.github.com/users/alobanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alobanova/subscriptions","organizations_url":"https://api.github.com/users/alobanova/orgs","repos_url":"https://api.github.com/users/alobanova/repos","events_url":"https://api.github.com/users/alobanova/events{/privacy}","received_events_url":"https://api.github.com/users/alobanova/received_events","type":"User","site_admin":false},"repo":{"id":184069455,"node_id":"MDEwOlJlcG9zaXRvcnkxODQwNjk0NTU=","name":"homework","full_name":"alobanova/homework","private":false,"owner":{"login":"alobanova","id":49763961,"node_id":"MDQ6VXNlcjQ5NzYzOTYx","avatar_url":"https://avatars0.githubusercontent.com/u/49763961?v=4","gravatar_id":"","url":"https://api.github.com/users/alobanova","html_url":"https://github.com/alobanova","followers_url":"https://api.github.com/users/alobanova/followers","following_url":"https://api.github.com/users/alobanova/following{/other_user}","gists_url":"https://api.github.com/users/alobanova/gists{/gist_id}","starred_url":"https://api.github.com/users/alobanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alobanova/subscriptions","organizations_url":"https://api.github.com/users/alobanova/orgs","repos_url":"https://api.github.com/users/alobanova/repos","events_url":"https://api.github.com/users/alobanova/events{/privacy}","received_events_url":"https://api.github.com/users/alobanova/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alobanova/homework","description":null,"fork":true,"url":"https://api.github.com/repos/alobanova/homework","forks_url":"https://api.github.com/repos/alobanova/homework/forks","keys_url":"https://api.github.com/repos/alobanova/homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alobanova/homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alobanova/homework/teams","hooks_url":"https://api.github.com/repos/alobanova/homework/hooks","issue_events_url":"https://api.github.com/repos/alobanova/homework/issues/events{/number}","events_url":"https://api.github.com/repos/alobanova/homework/events","assignees_url":"https://api.github.com/repos/alobanova/homework/assignees{/user}","branches_url":"https://api.github.com/repos/alobanova/homework/branches{/branch}","tags_url":"https://api.github.com/repos/alobanova/homework/tags","blobs_url":"https://api.github.com/repos/alobanova/homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alobanova/homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alobanova/homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/alobanova/homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alobanova/homework/statuses/{sha}","languages_url":"https://api.github.com/repos/alobanova/homework/languages","stargazers_url":"https://api.github.com/repos/alobanova/homework/stargazers","contributors_url":"https://api.github.com/repos/alobanova/homework/contributors","subscribers_url":"https://api.github.com/repos/alobanova/homework/subscribers","subscription_url":"https://api.github.com/repos/alobanova/homework/subscription","commits_url":"https://api.github.com/repos/alobanova/homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/alobanova/homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/alobanova/homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/alobanova/homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/alobanova/homework/contents/{+path}","compare_url":"https://api.github.com/repos/alobanova/homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alobanova/homework/merges","archive_url":"https://api.github.com/repos/alobanova/homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alobanova/homework/downloads","issues_url":"https://api.github.com/repos/alobanova/homework/issues{/number}","pulls_url":"https://api.github.com/repos/alobanova/homework/pulls{/number}","milestones_url":"https://api.github.com/repos/alobanova/homework/milestones{/number}","notifications_url":"https://api.github.com/repos/alobanova/homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alobanova/homework/labels{/name}","releases_url":"https://api.github.com/repos/alobanova/homework/releases{/id}","deployments_url":"https://api.github.com/repos/alobanova/homework/deployments","created_at":"2019-04-29T12:44:29Z","updated_at":"2019-05-02T19:48:28Z","pushed_at":"2019-05-02T19:48:27Z","git_url":"git://github.com/alobanova/homework.git","ssh_url":"[email protected]:alobanova/homework.git","clone_url":"https://github.com/alobanova/homework.git","svn_url":"https://github.com/alobanova/homework","homepage":null,"size":132,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"source"}},"base":{"label":"sberbankjavaschool:Lobanova","ref":"Lobanova","sha":"b39b35d20247ccfc957a628c556c2f047e19edd8","user":{"login":"sberbankjavaschool","id":48329846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzI5ODQ2","avatar_url":"https://avatars1.githubusercontent.com/u/48329846?v=4","gravatar_id":"","url":"https://api.github.com/users/sberbankjavaschool","html_url":"https://github.com/sberbankjavaschool","followers_url":"https://api.github.com/users/sberbankjavaschool/followers","following_url":"https://api.github.com/users/sberbankjavaschool/following{/other_user}","gists_url":"https://api.github.com/users/sberbankjavaschool/gists{/gist_id}","starred_url":"https://api.github.com/users/sberbankjavaschool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sberbankjavaschool/subscriptions","organizations_url":"https://api.github.com/users/sberbankjavaschool/orgs","repos_url":"https://api.github.com/users/sberbankjavaschool/repos","events_url":"https://api.github.com/users/sberbankjavaschool/events{/privacy}","received_events_url":"https://api.github.com/users/sberbankjavaschool/received_events","type":"Organization","site_admin":false},"repo":{"id":181267041,"node_id":"MDEwOlJlcG9zaXRvcnkxODEyNjcwNDE=","name":"homework","full_name":"sberbankjavaschool/homework","private":false,"owner":{"login":"sberbankjavaschool","id":48329846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzI5ODQ2","avatar_url":"https://avatars1.githubusercontent.com/u/48329846?v=4","gravatar_id":"","url":"https://api.github.com/users/sberbankjavaschool","html_url":"https://github.com/sberbankjavaschool","followers_url":"https://api.github.com/users/sberbankjavaschool/followers","following_url":"https://api.github.com/users/sberbankjavaschool/following{/other_user}","gists_url":"https://api.github.com/users/sberbankjavaschool/gists{/gist_id}","starred_url":"https://api.github.com/users/sberbankjavaschool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sberbankjavaschool/subscriptions","organizations_url":"https://api.github.com/users/sberbankjavaschool/orgs","repos_url":"https://api.github.com/users/sberbankjavaschool/repos","events_url":"https://api.github.com/users/sberbankjavaschool/events{/privacy}","received_events_url":"https://api.github.com/users/sberbankjavaschool/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sberbankjavaschool/homework","description":null,"fork":false,"url":"https://api.github.com/repos/sberbankjavaschool/homework","forks_url":"https://api.github.com/repos/sberbankjavaschool/homework/forks","keys_url":"https://api.github.com/repos/sberbankjavaschool/homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sberbankjavaschool/homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sberbankjavaschool/homework/teams","hooks_url":"https://api.github.com/repos/sberbankjavaschool/homework/hooks","issue_events_url":"https://api.github.com/repos/sberbankjavaschool/homework/issues/events{/number}","events_url":"https://api.github.com/repos/sberbankjavaschool/homework/events","assignees_url":"https://api.github.com/repos/sberbankjavaschool/homework/assignees{/user}","branches_url":"https://api.github.com/repos/sberbankjavaschool/homework/branches{/branch}","tags_url":"https://api.github.com/repos/sberbankjavaschool/homework/tags","blobs_url":"https://api.github.com/repos/sberbankjavaschool/homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sberbankjavaschool/homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sberbankjavaschool/homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/sberbankjavaschool/homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sberbankjavaschool/homework/statuses/{sha}","languages_url":"https://api.github.com/repos/sberbankjavaschool/homework/languages","stargazers_url":"https://api.github.com/repos/sberbankjavaschool/homework/stargazers","contributors_url":"https://api.github.com/repos/sberbankjavaschool/homework/contributors","subscribers_url":"https://api.github.com/repos/sberbankjavaschool/homework/subscribers","subscription_url":"https://api.github.com/repos/sberbankjavaschool/homework/subscription","commits_url":"https://api.github.com/repos/sberbankjavaschool/homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/sberbankjavaschool/homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/sberbankjavaschool/homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/sberbankjavaschool/homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/sberbankjavaschool/homework/contents/{+path}","compare_url":"https://api.github.com/repos/sberbankjavaschool/homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sberbankjavaschool/homework/merges","archive_url":"https://api.github.com/repos/sberbankjavaschool/homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sberbankjavaschool/homework/downloads","issues_url":"https://api.github.com/repos/sberbankjavaschool/homework/issues{/number}","pulls_url":"https://api.github.com/repos/sberbankjavaschool/homework/pulls{/number}","milestones_url":"https://api.github.com/repos/sberbankjavaschool/homework/milestones{/number}","notifications_url":"https://api.github.com/repos/sberbankjavaschool/homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sberbankjavaschool/homework/labels{/name}","releases_url":"https://api.github.com/repos/sberbankjavaschool/homework/releases{/id}","deployments_url":"https://api.github.com/repos/sberbankjavaschool/homework/deployments","created_at":"2019-04-14T06:03:12Z","updated_at":"2019-05-02T10:25:18Z","pushed_at":"2019-05-02T20:21:48Z","git_url":"git://github.com/sberbankjavaschool/homework.git","ssh_url":"[email protected]:sberbankjavaschool/homework.git","clone_url":"https://github.com/sberbankjavaschool/homework.git","svn_url":"https://github.com/sberbankjavaschool/homework","homepage":null,"size":172,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":16,"open_issues":3,"watchers":1,"default_branch":"source"}},"_links":{"self":{"href":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/33"},"html":{"href":"https://github.com/sberbankjavaschool/homework/pull/33"},"issue":{"href":"https://api.github.com/repos/sberbankjavaschool/homework/issues/33"},"comments":{"href":"https://api.github.com/repos/sberbankjavaschool/homework/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sberbankjavaschool/homework/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/sberbankjavaschool/homework/statuses/59b9b318d39f204204840b3218eec21d816951de"}},"author_association":"COLLABORATOR"}}
|
{
"id": 181267041,
"name": "sberbankjavaschool/homework",
"url": "https://api.github.com/repos/sberbankjavaschool/homework"
}
|
{
"id": 49533281,
"login": "jenkins-java-school-2019",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49533281?",
"url": "https://api.github.com/users/jenkins-java-school-2019"
}
|
{
"id": 48329846,
"login": "sberbankjavaschool",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48329846?",
"url": "https://api.github.com/orgs/sberbankjavaschool"
}
| 2019-05-02T20:22:02 |
9553845715
|
{"actor":{"display_login":"jenkins-java-school-2019"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gambe-ro/lobsters/pulls/comments/272912396","pull_request_review_id":223676573,"id":272912396,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MjkxMjM5Ng==","diff_hunk":"@@ -578,8 +579,46 @@ it:\n rssforstoriestitle: \"RSS 2.0\"\n rssforcommentstitle: \"Commenti - RSS 2.0\"\n neweststoriestitle: \"Articoli piรน nuovi\"\n- licensetext: \"<div class=\\\"box wide\\\">Toutes les actions sur le site sont publiques ร l'exception des messages privรฉs entre utilisateurs. Les actions de modรฉration peuvent รชtre consultรฉes via le <a href=\\\"/moderations\\\">Journal de modรฉration</a>.<br/><a rel=\\\"license\\\" href=\\\"https://creativecommons.org/licenses/by/4.0/deed.fr\\\"><img alt=\\\"Licence Creative Commons\\\" style=\\\"border-width:0\\\" src=\\\"https://i.creativecommons.org/l/by/4.0/88x31.png\\\" /></a><br /><span xmlns:dct=\\\"http://purl.org/dc/terms/\\\" property=\\\"dct:title\\\">Le Journal du hacker</span> est mis ร disposition selon les termes de la <a rel=\\\"license\\\" href=\\\"https://creativecommons.org/licenses/by/4.0/deed.fr\\\">licence Creative Commons Attribution 4.0 International</a>.</div>\"\n- abouttext: \"<h2>Le Journal du hacker</h2><div class=\\\"box wide\\\">Le <a href=\\\"/\\\">Journal du hacker</a> a pour ambition de prรฉsenter l'activitรฉ des hackers francophones, du mouvement du Logiciel Libre et open source en langue franรงaise, mais aussi des startups et du mouvement entrepreunarial de la communautรฉ francophone.<br />Le Journal du hacker s'inspire directement du site anglophone <a href=\\\"https://news.ycombinator.com\\\">Hacker News</a> car l'idรฉe de base est excellente mais propose d'aller plus loin en offrant un moteur <a href=\\\"https://gitlab.com/journalduhacker/journalduhacker\\\">basรฉ sur un logiciel libre</a> fonctionnant par cooptation afin de crรฉer une vraie communautรฉ responsable. Il suffit de <a href=\\\"/invitations/request\\\">demander une invitation</a> pour nous rejoindre et partager vos infos avec nous ;)<br /></div><h2>Les acteurs du Journal du hacker</h2><div class=\\\"box wide\\\">En tant que <strong>lecteur</strong> vous avez accรจs au <a href=\\\"/\\\">site</a> et vous pouvez :<ul><li>Lire les <a href=\\\"/comments\\\">commentaires</a> sans toutefois pouvoir y participer</li><li>Suivre la publication des articles via <a href=\\\"/rss\\\">RSS</a>, <a href=\\\"https://twitter.com/journalduhacker\\\">Twitter</a>, <a href=\\\"https://framasphere.org/people/2aaaaba0110c0133c7ea2a0000053625\\\">Diaspora</a> ou <a href=\\\"https://framapiaf.org/@journalduhacker\\\">Mastodon</a></li><li>Suivre uniquement les รฉtiquettes (tags) qui vous intรฉressent par RSS exemple <a href=\\\"/t/conteneurs.rss\\\">Conteneurs</a>, il suffit de se rendre sur <a href=\\\"/filters\\\">Filtres</a> de cliquer sur une รฉtiquette et de rajouter .rss sur l'URL ainsi <a href=\\\"/t/linux\\\">https://www.journalduhacker.net/t/linux</a> devient <a href=\\\"/t/linux.rss\\\">https://www.journalduhacker.net/t/linux.rss</a> pour suivre cette รฉtiquette par RSS</li><li>Vous pourrez y faire des <a href=\\\"/search\\\">recherches</a></li></ul>En tant qu'<strong>utilisateur inscrit</strong>, vous pourrez :<ul><li>Participer aux <a href=\\\"/comments\\\" >commentaires</a></li><li>Voter pour faire remonter en haut de la page d'<a href=\\\"/\\\">accueil</a> les articles que vous apprรฉciez</li><li><a href=\\\"/stories/new\\\" >Soumettre des articles</a> (vidรฉos et podcasts compris)</li><li><a href=\\\"/filters\\\">Filtrer</a> selon les รฉtiquettes qui vous intรฉressent pour afficher uniquement certaines รฉtiquettes sur la page d'<a href=\\\"/\\\" >accueil</a></li></ul>Le Journal du hacker est un outil simple de veille pour la sphรจre professionnelle, une fenรชtre vers le monde du Libre, du Hacking, de l'Open source dans la sphรจre privรฉe, une bibliothรจque des meilleurs articles en langue franรงaise grรขce ร la <a href=\\\"/search\\\">fonction de recherche</a>. Il est animรฉ par nos <a href=\\\"/u\\\" >contributeurs</a> bรฉnรฉvoles qui sont impliquรฉs dans la communautรฉ.<br /></div><h2>Les donnรฉes publiques du Journal du hacker</h2><div class=\\\"box wide\\\">Une copie de la base de donnรฉes du Journal du hacker est mis ร disposition de la communautรฉ afin qu'elle puisse rรฉutiliser les informations prรฉsentes sur le Jdh. Ce dump est gรฉnรฉrรฉ chaque jour ร 1h du matin et purgรฉ des informations confidentielles (notamment des adresses mails et mots de passe), il est tรฉlรฉchargeable ici : <a href=\\\"/assets/database/journalduhacker.sql.tar.gz\\\">journalduhacker.sql.tar.gz</a><br /></div><h2>Informations</h2><div class=\\\"box wide\\\">L'outil est entiรจrement traduit en franรงais et basรฉ sur le projet <a href=\\\"https://github.com/jcs/lobsters\\\">lobste.rs</a> dont vous trouverez la licence <a href=\\\"https://github.com/jcs/lobsters/blob/master/LICENSE\\\" >ici</a>.<br />Adresse de contact : <a href =\\\"mailto:[email protected]\\\">[email protected]</a></div>\"\n+ licensetext: \"<div class=\\\"box wide\\\">Tutte le azioni sul sito sono pubblicche ad eccezione dei messaggi privati tra utenti. Le azioni di moderazione possono essere consultate sul <a href=\\\"/moderations\\\">Log di Moderazione</a>.<br/><a rel=\\\"license\\\" href=\\\"https://creativecommons.org/licenses/by/4.0/deed.it\\\"><img alt=\\\"Licenza Creative Commons\\\" style=\\\"border-width:0\\\" src=\\\"https://i.creativecommons.org/l/by/4.0/88x31.png\\\" /></a><br /><span xmlns:dct=\\\"http://purl.org/dc/terms/\\\" property=\\\"dct:title\\\">Gambe.ro</span> รจ pubblicato secondo i termini della <a rel=\\\"license\\\" href=\\\"https://creativecommons.org/licenses/by/4.0/deed.it\\\">licenza Creative Commons Attribution 4.0 International</a>.</div>\"\n+ abouttext: \"<p>gambe.ro nasce dalla volontร di un gruppo di programmatori di creare uno spazio di discussione in lingua italiana e di scambio focalizzato sullo sviluppo software. Al contrario di buona parte dei siti, gruppi e chat venuti prima di noi, vogliamo coinvolgere specificatamente e unicamente la comunitร di persone che produce software. Crediamo che allargare eccessivamente lo spettro delle tematiche trattate porti alla creazione di una community frammentata in cui convivono persone con background troppo differenti e pochi interessi in comune. Riteniamo che in una community del genere la qualitร del dibattito sarebbe inevitabilmente penalizzata.\n+ </p> \n+ <p>\n+ Per questo abbiamo sentito il bisogno di imitare esperienze che allโestero hanno creato comunitร di ottima qualitร per contenuti e dibattito. Seguendo lโesempio di <a href=\\\"https://journalduhacker.net\\\" target=\\\"_black\\\">journalduhacker</a> che ha portato in lingua francese il format originariamente creato da <a href=\\\"https://lobste.rs\\\" target=\\\"_black\\\">lobste.rs</a>, abbiamo deciso di tradurre in lingua italiana il loro software e su questo costruire gambe.ro.","path":"config/locales/it.yml","position":39,"original_position":39,"commit_id":"78f076349f84984e4486d86b4aa04b383f2e5f8c","original_commit_id":"78f076349f84984e4486d86b4aa04b383f2e5f8c","user":{"login":"Kratacoa","id":40217062,"node_id":"MDQ6VXNlcjQwMjE3MDYy","avatar_url":"https://avatars1.githubusercontent.com/u/40217062?v=4","gravatar_id":"","url":"https://api.github.com/users/Kratacoa","html_url":"https://github.com/Kratacoa","followers_url":"https://api.github.com/users/Kratacoa/followers","following_url":"https://api.github.com/users/Kratacoa/following{/other_user}","gists_url":"https://api.github.com/users/Kratacoa/gists{/gist_id}","starred_url":"https://api.github.com/users/Kratacoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kratacoa/subscriptions","organizations_url":"https://api.github.com/users/Kratacoa/orgs","repos_url":"https://api.github.com/users/Kratacoa/repos","events_url":"https://api.github.com/users/Kratacoa/events{/privacy}","received_events_url":"https://api.github.com/users/Kratacoa/received_events","type":"User","site_admin":false},"body":"`target=_blank` ? se si', aggiungici anche `rel=noopener` tra gli atributi.\r\nRiformulerei la frase: \"Per conseguire questo obbiettivo, abbiamo deciso di riprodurre in italiano un formato collaudato da journalduhacker e lobste.rs\"\r\n\r\n","created_at":"2019-04-08T07:22:40Z","updated_at":"2019-04-08T07:39:45Z","html_url":"https://github.com/gambe-ro/lobsters/pull/12#discussion_r272912396","pull_request_url":"https://api.github.com/repos/gambe-ro/lobsters/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gambe-ro/lobsters/pulls/comments/272912396"},"html":{"href":"https://github.com/gambe-ro/lobsters/pull/12#discussion_r272912396"},"pull_request":{"href":"https://api.github.com/repos/gambe-ro/lobsters/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/gambe-ro/lobsters/pulls/12","id":268102708,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4MTAyNzA4","html_url":"https://github.com/gambe-ro/lobsters/pull/12","diff_url":"https://github.com/gambe-ro/lobsters/pull/12.diff","patch_url":"https://github.com/gambe-ro/lobsters/pull/12.patch","issue_url":"https://api.github.com/repos/gambe-ro/lobsters/issues/12","number":12,"state":"open","locked":false,"title":"About us","user":{"login":"chobeat","id":2822010,"node_id":"MDQ6VXNlcjI4MjIwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2822010?v=4","gravatar_id":"","url":"https://api.github.com/users/chobeat","html_url":"https://github.com/chobeat","followers_url":"https://api.github.com/users/chobeat/followers","following_url":"https://api.github.com/users/chobeat/following{/other_user}","gists_url":"https://api.github.com/users/chobeat/gists{/gist_id}","starred_url":"https://api.github.com/users/chobeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chobeat/subscriptions","organizations_url":"https://api.github.com/users/chobeat/orgs","repos_url":"https://api.github.com/users/chobeat/repos","events_url":"https://api.github.com/users/chobeat/events{/privacy}","received_events_url":"https://api.github.com/users/chobeat/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-07T12:20:45Z","updated_at":"2019-04-08T07:39:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4a61a7dab32b163a3ec11784a3af6f221f58802","assignee":null,"assignees":[],"requested_reviewers":[{"login":"karjudev","id":24912798,"node_id":"MDQ6VXNlcjI0OTEyNzk4","avatar_url":"https://avatars2.githubusercontent.com/u/24912798?v=4","gravatar_id":"","url":"https://api.github.com/users/karjudev","html_url":"https://github.com/karjudev","followers_url":"https://api.github.com/users/karjudev/followers","following_url":"https://api.github.com/users/karjudev/following{/other_user}","gists_url":"https://api.github.com/users/karjudev/gists{/gist_id}","starred_url":"https://api.github.com/users/karjudev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karjudev/subscriptions","organizations_url":"https://api.github.com/users/karjudev/orgs","repos_url":"https://api.github.com/users/karjudev/repos","events_url":"https://api.github.com/users/karjudev/events{/privacy}","received_events_url":"https://api.github.com/users/karjudev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gambe-ro/lobsters/pulls/12/commits","review_comments_url":"https://api.github.com/repos/gambe-ro/lobsters/pulls/12/comments","review_comment_url":"https://api.github.com/repos/gambe-ro/lobsters/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gambe-ro/lobsters/issues/12/comments","statuses_url":"https://api.github.com/repos/gambe-ro/lobsters/statuses/78f076349f84984e4486d86b4aa04b383f2e5f8c","head":{"label":"gambe-ro:about_us","ref":"about_us","sha":"78f076349f84984e4486d86b4aa04b383f2e5f8c","user":{"login":"gambe-ro","id":48360830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzYwODMw","avatar_url":"https://avatars2.githubusercontent.com/u/48360830?v=4","gravatar_id":"","url":"https://api.github.com/users/gambe-ro","html_url":"https://github.com/gambe-ro","followers_url":"https://api.github.com/users/gambe-ro/followers","following_url":"https://api.github.com/users/gambe-ro/following{/other_user}","gists_url":"https://api.github.com/users/gambe-ro/gists{/gist_id}","starred_url":"https://api.github.com/users/gambe-ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gambe-ro/subscriptions","organizations_url":"https://api.github.com/users/gambe-ro/orgs","repos_url":"https://api.github.com/users/gambe-ro/repos","events_url":"https://api.github.com/users/gambe-ro/events{/privacy}","received_events_url":"https://api.github.com/users/gambe-ro/received_events","type":"Organization","site_admin":false},"repo":{"id":174569300,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ1NjkzMDA=","name":"lobsters","full_name":"gambe-ro/lobsters","private":false,"owner":{"login":"gambe-ro","id":48360830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzYwODMw","avatar_url":"https://avatars2.githubusercontent.com/u/48360830?v=4","gravatar_id":"","url":"https://api.github.com/users/gambe-ro","html_url":"https://github.com/gambe-ro","followers_url":"https://api.github.com/users/gambe-ro/followers","following_url":"https://api.github.com/users/gambe-ro/following{/other_user}","gists_url":"https://api.github.com/users/gambe-ro/gists{/gist_id}","starred_url":"https://api.github.com/users/gambe-ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gambe-ro/subscriptions","organizations_url":"https://api.github.com/users/gambe-ro/orgs","repos_url":"https://api.github.com/users/gambe-ro/repos","events_url":"https://api.github.com/users/gambe-ro/events{/privacy}","received_events_url":"https://api.github.com/users/gambe-ro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gambe-ro/lobsters","description":"Computing-focused community centered around link aggregation and discussion","fork":true,"url":"https://api.github.com/repos/gambe-ro/lobsters","forks_url":"https://api.github.com/repos/gambe-ro/lobsters/forks","keys_url":"https://api.github.com/repos/gambe-ro/lobsters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gambe-ro/lobsters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gambe-ro/lobsters/teams","hooks_url":"https://api.github.com/repos/gambe-ro/lobsters/hooks","issue_events_url":"https://api.github.com/repos/gambe-ro/lobsters/issues/events{/number}","events_url":"https://api.github.com/repos/gambe-ro/lobsters/events","assignees_url":"https://api.github.com/repos/gambe-ro/lobsters/assignees{/user}","branches_url":"https://api.github.com/repos/gambe-ro/lobsters/branches{/branch}","tags_url":"https://api.github.com/repos/gambe-ro/lobsters/tags","blobs_url":"https://api.github.com/repos/gambe-ro/lobsters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gambe-ro/lobsters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gambe-ro/lobsters/git/refs{/sha}","trees_url":"https://api.github.com/repos/gambe-ro/lobsters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gambe-ro/lobsters/statuses/{sha}","languages_url":"https://api.github.com/repos/gambe-ro/lobsters/languages","stargazers_url":"https://api.github.com/repos/gambe-ro/lobsters/stargazers","contributors_url":"https://api.github.com/repos/gambe-ro/lobsters/contributors","subscribers_url":"https://api.github.com/repos/gambe-ro/lobsters/subscribers","subscription_url":"https://api.github.com/repos/gambe-ro/lobsters/subscription","commits_url":"https://api.github.com/repos/gambe-ro/lobsters/commits{/sha}","git_commits_url":"https://api.github.com/repos/gambe-ro/lobsters/git/commits{/sha}","comments_url":"https://api.github.com/repos/gambe-ro/lobsters/comments{/number}","issue_comment_url":"https://api.github.com/repos/gambe-ro/lobsters/issues/comments{/number}","contents_url":"https://api.github.com/repos/gambe-ro/lobsters/contents/{+path}","compare_url":"https://api.github.com/repos/gambe-ro/lobsters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gambe-ro/lobsters/merges","archive_url":"https://api.github.com/repos/gambe-ro/lobsters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gambe-ro/lobsters/downloads","issues_url":"https://api.github.com/repos/gambe-ro/lobsters/issues{/number}","pulls_url":"https://api.github.com/repos/gambe-ro/lobsters/pulls{/number}","milestones_url":"https://api.github.com/repos/gambe-ro/lobsters/milestones{/number}","notifications_url":"https://api.github.com/repos/gambe-ro/lobsters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gambe-ro/lobsters/labels{/name}","releases_url":"https://api.github.com/repos/gambe-ro/lobsters/releases{/id}","deployments_url":"https://api.github.com/repos/gambe-ro/lobsters/deployments","created_at":"2019-03-08T16:16:05Z","updated_at":"2019-04-05T21:06:01Z","pushed_at":"2019-04-08T06:36:51Z","git_url":"git://github.com/gambe-ro/lobsters.git","ssh_url":"[email protected]:gambe-ro/lobsters.git","clone_url":"https://github.com/gambe-ro/lobsters.git","svn_url":"https://github.com/gambe-ro/lobsters","homepage":"https://lobste.rs","size":2135,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":4,"watchers":3,"default_branch":"develop"}},"base":{"label":"gambe-ro:develop","ref":"develop","sha":"9508f3d6ea1793c330a8594c04c2ae16bb878807","user":{"login":"gambe-ro","id":48360830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzYwODMw","avatar_url":"https://avatars2.githubusercontent.com/u/48360830?v=4","gravatar_id":"","url":"https://api.github.com/users/gambe-ro","html_url":"https://github.com/gambe-ro","followers_url":"https://api.github.com/users/gambe-ro/followers","following_url":"https://api.github.com/users/gambe-ro/following{/other_user}","gists_url":"https://api.github.com/users/gambe-ro/gists{/gist_id}","starred_url":"https://api.github.com/users/gambe-ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gambe-ro/subscriptions","organizations_url":"https://api.github.com/users/gambe-ro/orgs","repos_url":"https://api.github.com/users/gambe-ro/repos","events_url":"https://api.github.com/users/gambe-ro/events{/privacy}","received_events_url":"https://api.github.com/users/gambe-ro/received_events","type":"Organization","site_admin":false},"repo":{"id":174569300,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ1NjkzMDA=","name":"lobsters","full_name":"gambe-ro/lobsters","private":false,"owner":{"login":"gambe-ro","id":48360830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzYwODMw","avatar_url":"https://avatars2.githubusercontent.com/u/48360830?v=4","gravatar_id":"","url":"https://api.github.com/users/gambe-ro","html_url":"https://github.com/gambe-ro","followers_url":"https://api.github.com/users/gambe-ro/followers","following_url":"https://api.github.com/users/gambe-ro/following{/other_user}","gists_url":"https://api.github.com/users/gambe-ro/gists{/gist_id}","starred_url":"https://api.github.com/users/gambe-ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gambe-ro/subscriptions","organizations_url":"https://api.github.com/users/gambe-ro/orgs","repos_url":"https://api.github.com/users/gambe-ro/repos","events_url":"https://api.github.com/users/gambe-ro/events{/privacy}","received_events_url":"https://api.github.com/users/gambe-ro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gambe-ro/lobsters","description":"Computing-focused community centered around link aggregation and discussion","fork":true,"url":"https://api.github.com/repos/gambe-ro/lobsters","forks_url":"https://api.github.com/repos/gambe-ro/lobsters/forks","keys_url":"https://api.github.com/repos/gambe-ro/lobsters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gambe-ro/lobsters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gambe-ro/lobsters/teams","hooks_url":"https://api.github.com/repos/gambe-ro/lobsters/hooks","issue_events_url":"https://api.github.com/repos/gambe-ro/lobsters/issues/events{/number}","events_url":"https://api.github.com/repos/gambe-ro/lobsters/events","assignees_url":"https://api.github.com/repos/gambe-ro/lobsters/assignees{/user}","branches_url":"https://api.github.com/repos/gambe-ro/lobsters/branches{/branch}","tags_url":"https://api.github.com/repos/gambe-ro/lobsters/tags","blobs_url":"https://api.github.com/repos/gambe-ro/lobsters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gambe-ro/lobsters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gambe-ro/lobsters/git/refs{/sha}","trees_url":"https://api.github.com/repos/gambe-ro/lobsters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gambe-ro/lobsters/statuses/{sha}","languages_url":"https://api.github.com/repos/gambe-ro/lobsters/languages","stargazers_url":"https://api.github.com/repos/gambe-ro/lobsters/stargazers","contributors_url":"https://api.github.com/repos/gambe-ro/lobsters/contributors","subscribers_url":"https://api.github.com/repos/gambe-ro/lobsters/subscribers","subscription_url":"https://api.github.com/repos/gambe-ro/lobsters/subscription","commits_url":"https://api.github.com/repos/gambe-ro/lobsters/commits{/sha}","git_commits_url":"https://api.github.com/repos/gambe-ro/lobsters/git/commits{/sha}","comments_url":"https://api.github.com/repos/gambe-ro/lobsters/comments{/number}","issue_comment_url":"https://api.github.com/repos/gambe-ro/lobsters/issues/comments{/number}","contents_url":"https://api.github.com/repos/gambe-ro/lobsters/contents/{+path}","compare_url":"https://api.github.com/repos/gambe-ro/lobsters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gambe-ro/lobsters/merges","archive_url":"https://api.github.com/repos/gambe-ro/lobsters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gambe-ro/lobsters/downloads","issues_url":"https://api.github.com/repos/gambe-ro/lobsters/issues{/number}","pulls_url":"https://api.github.com/repos/gambe-ro/lobsters/pulls{/number}","milestones_url":"https://api.github.com/repos/gambe-ro/lobsters/milestones{/number}","notifications_url":"https://api.github.com/repos/gambe-ro/lobsters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gambe-ro/lobsters/labels{/name}","releases_url":"https://api.github.com/repos/gambe-ro/lobsters/releases{/id}","deployments_url":"https://api.github.com/repos/gambe-ro/lobsters/deployments","created_at":"2019-03-08T16:16:05Z","updated_at":"2019-04-05T21:06:01Z","pushed_at":"2019-04-08T06:36:51Z","git_url":"git://github.com/gambe-ro/lobsters.git","ssh_url":"[email protected]:gambe-ro/lobsters.git","clone_url":"https://github.com/gambe-ro/lobsters.git","svn_url":"https://github.com/gambe-ro/lobsters","homepage":"https://lobste.rs","size":2135,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":4,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gambe-ro/lobsters/pulls/12"},"html":{"href":"https://github.com/gambe-ro/lobsters/pull/12"},"issue":{"href":"https://api.github.com/repos/gambe-ro/lobsters/issues/12"},"comments":{"href":"https://api.github.com/repos/gambe-ro/lobsters/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/gambe-ro/lobsters/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/gambe-ro/lobsters/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gambe-ro/lobsters/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/gambe-ro/lobsters/statuses/78f076349f84984e4486d86b4aa04b383f2e5f8c"}},"author_association":"NONE"}}
|
{
"id": 174569300,
"name": "gambe-ro/lobsters",
"url": "https://api.github.com/repos/gambe-ro/lobsters"
}
|
{
"id": 40217062,
"login": "Kratacoa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/40217062?",
"url": "https://api.github.com/users/Kratacoa"
}
|
{
"id": 48360830,
"login": "gambe-ro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48360830?",
"url": "https://api.github.com/orgs/gambe-ro"
}
| 2019-04-08T07:22:40 |
9396598121
|
{"actor":{"display_login":"Kratacoa"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/comments/297395805","pull_request_review_id":254272997,"id":297395805,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzM5NTgwNQ==","diff_hunk":"@@ -115,6 +191,12 @@ def load(data_home=None):\n \n \n def _load_beats(beats_path):\n+ \"\"\"Private function to load beat data for a track\n+\n+ Args:\n+ beats_path (str):\n+","path":"mirdata/beatles.py","position":127,"original_position":127,"commit_id":"aa66a6b0c66eb8e26756fdf120fc2e4179034acc","original_commit_id":"aa66a6b0c66eb8e26756fdf120fc2e4179034acc","user":{"login":"keunwoochoi","id":16153797,"node_id":"MDQ6VXNlcjE2MTUzNzk3","avatar_url":"https://avatars0.githubusercontent.com/u/16153797?v=4","gravatar_id":"","url":"https://api.github.com/users/keunwoochoi","html_url":"https://github.com/keunwoochoi","followers_url":"https://api.github.com/users/keunwoochoi/followers","following_url":"https://api.github.com/users/keunwoochoi/following{/other_user}","gists_url":"https://api.github.com/users/keunwoochoi/gists{/gist_id}","starred_url":"https://api.github.com/users/keunwoochoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keunwoochoi/subscriptions","organizations_url":"https://api.github.com/users/keunwoochoi/orgs","repos_url":"https://api.github.com/users/keunwoochoi/repos","events_url":"https://api.github.com/users/keunwoochoi/events{/privacy}","received_events_url":"https://api.github.com/users/keunwoochoi/received_events","type":"User","site_admin":false},"body":"Let me work on the private in the following PR. ","created_at":"2019-06-25T21:11:58Z","updated_at":"2019-06-25T21:11:59Z","html_url":"https://github.com/mir-dataset-loaders/mirdata/pull/71#discussion_r297395805","pull_request_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/71","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/comments/297395805"},"html":{"href":"https://github.com/mir-dataset-loaders/mirdata/pull/71#discussion_r297395805"},"pull_request":{"href":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/71"}},"in_reply_to_id":297364461},"pull_request":{"url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/71","id":291287722,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMjg3NzIy","html_url":"https://github.com/mir-dataset-loaders/mirdata/pull/71","diff_url":"https://github.com/mir-dataset-loaders/mirdata/pull/71.diff","patch_url":"https://github.com/mir-dataset-loaders/mirdata/pull/71.patch","issue_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues/71","number":71,"state":"open","locked":false,"title":"Docs - first attempt","user":{"login":"keunwoochoi","id":16153797,"node_id":"MDQ6VXNlcjE2MTUzNzk3","avatar_url":"https://avatars0.githubusercontent.com/u/16153797?v=4","gravatar_id":"","url":"https://api.github.com/users/keunwoochoi","html_url":"https://github.com/keunwoochoi","followers_url":"https://api.github.com/users/keunwoochoi/followers","following_url":"https://api.github.com/users/keunwoochoi/following{/other_user}","gists_url":"https://api.github.com/users/keunwoochoi/gists{/gist_id}","starred_url":"https://api.github.com/users/keunwoochoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keunwoochoi/subscriptions","organizations_url":"https://api.github.com/users/keunwoochoi/orgs","repos_url":"https://api.github.com/users/keunwoochoi/repos","events_url":"https://api.github.com/users/keunwoochoi/events{/privacy}","received_events_url":"https://api.github.com/users/keunwoochoi/received_events","type":"User","site_admin":false},"body":"* need to configure `index.rst` etc better but it kinda works\r\n* following google docstring format\r\n","created_at":"2019-06-24T20:39:21Z","updated_at":"2019-06-25T21:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35d540f122781da4fd611b73134b5ce89b0d2c82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/71/commits","review_comments_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/71/comments","review_comment_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues/71/comments","statuses_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/statuses/aa66a6b0c66eb8e26756fdf120fc2e4179034acc","head":{"label":"mir-dataset-loaders:docs","ref":"docs","sha":"aa66a6b0c66eb8e26756fdf120fc2e4179034acc","user":{"login":"mir-dataset-loaders","id":48734618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzM0NjE4","avatar_url":"https://avatars2.githubusercontent.com/u/48734618?v=4","gravatar_id":"","url":"https://api.github.com/users/mir-dataset-loaders","html_url":"https://github.com/mir-dataset-loaders","followers_url":"https://api.github.com/users/mir-dataset-loaders/followers","following_url":"https://api.github.com/users/mir-dataset-loaders/following{/other_user}","gists_url":"https://api.github.com/users/mir-dataset-loaders/gists{/gist_id}","starred_url":"https://api.github.com/users/mir-dataset-loaders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mir-dataset-loaders/subscriptions","organizations_url":"https://api.github.com/users/mir-dataset-loaders/orgs","repos_url":"https://api.github.com/users/mir-dataset-loaders/repos","events_url":"https://api.github.com/users/mir-dataset-loaders/events{/privacy}","received_events_url":"https://api.github.com/users/mir-dataset-loaders/received_events","type":"Organization","site_admin":false},"repo":{"id":170765267,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA3NjUyNjc=","name":"mirdata","full_name":"mir-dataset-loaders/mirdata","private":false,"owner":{"login":"mir-dataset-loaders","id":48734618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzM0NjE4","avatar_url":"https://avatars2.githubusercontent.com/u/48734618?v=4","gravatar_id":"","url":"https://api.github.com/users/mir-dataset-loaders","html_url":"https://github.com/mir-dataset-loaders","followers_url":"https://api.github.com/users/mir-dataset-loaders/followers","following_url":"https://api.github.com/users/mir-dataset-loaders/following{/other_user}","gists_url":"https://api.github.com/users/mir-dataset-loaders/gists{/gist_id}","starred_url":"https://api.github.com/users/mir-dataset-loaders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mir-dataset-loaders/subscriptions","organizations_url":"https://api.github.com/users/mir-dataset-loaders/orgs","repos_url":"https://api.github.com/users/mir-dataset-loaders/repos","events_url":"https://api.github.com/users/mir-dataset-loaders/events{/privacy}","received_events_url":"https://api.github.com/users/mir-dataset-loaders/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mir-dataset-loaders/mirdata","description":"common loaders for mir datasets","fork":false,"url":"https://api.github.com/repos/mir-dataset-loaders/mirdata","forks_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/forks","keys_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/teams","hooks_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/hooks","issue_events_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues/events{/number}","events_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/events","assignees_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/assignees{/user}","branches_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/branches{/branch}","tags_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/tags","blobs_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/statuses/{sha}","languages_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/languages","stargazers_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/stargazers","contributors_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/contributors","subscribers_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/subscribers","subscription_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/subscription","commits_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/contents/{+path}","compare_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/merges","archive_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/downloads","issues_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues{/number}","pulls_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls{/number}","milestones_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/milestones{/number}","notifications_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/labels{/name}","releases_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/releases{/id}","deployments_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/deployments","created_at":"2019-02-14T22:11:33Z","updated_at":"2019-06-25T15:43:48Z","pushed_at":"2019-06-25T16:22:28Z","git_url":"git://github.com/mir-dataset-loaders/mirdata.git","ssh_url":"[email protected]:mir-dataset-loaders/mirdata.git","clone_url":"https://github.com/mir-dataset-loaders/mirdata.git","svn_url":"https://github.com/mir-dataset-loaders/mirdata","homepage":null,"size":1538,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":15,"watchers":19,"default_branch":"master"}},"base":{"label":"mir-dataset-loaders:master","ref":"master","sha":"0ef2878b7bd607b0d2a88870c295215a43399d8a","user":{"login":"mir-dataset-loaders","id":48734618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzM0NjE4","avatar_url":"https://avatars2.githubusercontent.com/u/48734618?v=4","gravatar_id":"","url":"https://api.github.com/users/mir-dataset-loaders","html_url":"https://github.com/mir-dataset-loaders","followers_url":"https://api.github.com/users/mir-dataset-loaders/followers","following_url":"https://api.github.com/users/mir-dataset-loaders/following{/other_user}","gists_url":"https://api.github.com/users/mir-dataset-loaders/gists{/gist_id}","starred_url":"https://api.github.com/users/mir-dataset-loaders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mir-dataset-loaders/subscriptions","organizations_url":"https://api.github.com/users/mir-dataset-loaders/orgs","repos_url":"https://api.github.com/users/mir-dataset-loaders/repos","events_url":"https://api.github.com/users/mir-dataset-loaders/events{/privacy}","received_events_url":"https://api.github.com/users/mir-dataset-loaders/received_events","type":"Organization","site_admin":false},"repo":{"id":170765267,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA3NjUyNjc=","name":"mirdata","full_name":"mir-dataset-loaders/mirdata","private":false,"owner":{"login":"mir-dataset-loaders","id":48734618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzM0NjE4","avatar_url":"https://avatars2.githubusercontent.com/u/48734618?v=4","gravatar_id":"","url":"https://api.github.com/users/mir-dataset-loaders","html_url":"https://github.com/mir-dataset-loaders","followers_url":"https://api.github.com/users/mir-dataset-loaders/followers","following_url":"https://api.github.com/users/mir-dataset-loaders/following{/other_user}","gists_url":"https://api.github.com/users/mir-dataset-loaders/gists{/gist_id}","starred_url":"https://api.github.com/users/mir-dataset-loaders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mir-dataset-loaders/subscriptions","organizations_url":"https://api.github.com/users/mir-dataset-loaders/orgs","repos_url":"https://api.github.com/users/mir-dataset-loaders/repos","events_url":"https://api.github.com/users/mir-dataset-loaders/events{/privacy}","received_events_url":"https://api.github.com/users/mir-dataset-loaders/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mir-dataset-loaders/mirdata","description":"common loaders for mir datasets","fork":false,"url":"https://api.github.com/repos/mir-dataset-loaders/mirdata","forks_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/forks","keys_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/teams","hooks_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/hooks","issue_events_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues/events{/number}","events_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/events","assignees_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/assignees{/user}","branches_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/branches{/branch}","tags_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/tags","blobs_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/statuses/{sha}","languages_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/languages","stargazers_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/stargazers","contributors_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/contributors","subscribers_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/subscribers","subscription_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/subscription","commits_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/contents/{+path}","compare_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/merges","archive_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/downloads","issues_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues{/number}","pulls_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls{/number}","milestones_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/milestones{/number}","notifications_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/labels{/name}","releases_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/releases{/id}","deployments_url":"https://api.github.com/repos/mir-dataset-loaders/mirdata/deployments","created_at":"2019-02-14T22:11:33Z","updated_at":"2019-06-25T15:43:48Z","pushed_at":"2019-06-25T16:22:28Z","git_url":"git://github.com/mir-dataset-loaders/mirdata.git","ssh_url":"[email protected]:mir-dataset-loaders/mirdata.git","clone_url":"https://github.com/mir-dataset-loaders/mirdata.git","svn_url":"https://github.com/mir-dataset-loaders/mirdata","homepage":null,"size":1538,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":15,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/71"},"html":{"href":"https://github.com/mir-dataset-loaders/mirdata/pull/71"},"issue":{"href":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues/71"},"comments":{"href":"https://api.github.com/repos/mir-dataset-loaders/mirdata/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mir-dataset-loaders/mirdata/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/mir-dataset-loaders/mirdata/statuses/aa66a6b0c66eb8e26756fdf120fc2e4179034acc"}},"author_association":"NONE"}}
|
{
"id": 170765267,
"name": "mir-dataset-loaders/mirdata",
"url": "https://api.github.com/repos/mir-dataset-loaders/mirdata"
}
|
{
"id": 16153797,
"login": "keunwoochoi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16153797?",
"url": "https://api.github.com/users/keunwoochoi"
}
|
{
"id": 48734618,
"login": "mir-dataset-loaders",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48734618?",
"url": "https://api.github.com/orgs/mir-dataset-loaders"
}
| 2019-06-25T21:11:58 |
9892755774
|
{"actor":{"display_login":"keunwoochoi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/komputing/KEthereum/pulls/comments/294041034","pull_request_review_id":250185989,"id":294041034,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDA0MTAzNA==","diff_hunk":"@@ -0,0 +1,37 @@\n+package org.kethereum.bloomfilter\n+\n+import org.kethereum.hashes.sha256\n+import java.math.BigInteger\n+import java.util.BitSet\n+import java.util.concurrent.locks.ReentrantReadWriteLock\n+import kotlin.concurrent.read\n+import kotlin.concurrent.write\n+\n+class BloomFilter(private val size: Int) {\n+ private val bits = BitSet(size)\n+ private val lock = ReentrantReadWriteLock()\n+\n+ fun add(value: ByteArray) {\n+ lock.write {\n+ for (seed in 1..3) {\n+ bits.set(hashing(size, seed, value))\n+ }\n+ }\n+ }\n+\n+ fun mightContains(value: ByteArray): Boolean {\n+ lock.read {\n+ for (seed in 1..3) {\n+ if (!bits.get(hashing(size, seed, value))) {\n+ return false\n+ }\n+ }\n+ }\n+ return true\n+ }\n+\n+ private fun hashing(filterSize: Int, seed: Int, value: ByteArray) =\n+ BigInteger(1, value.plus(seed.toByte()).sha256())","path":"bloomfilter/src/main/kotlin/org/kethereum/bloomfilter/BloomFilter.kt","position":34,"original_position":34,"commit_id":"5cdeccb8a04df3c0680a7fa80fdcc80395790fbc","original_commit_id":"5cdeccb8a04df3c0680a7fa80fdcc80395790fbc","user":{"login":"ackintosh","id":1885716,"node_id":"MDQ6VXNlcjE4ODU3MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1885716?v=4","gravatar_id":"","url":"https://api.github.com/users/ackintosh","html_url":"https://github.com/ackintosh","followers_url":"https://api.github.com/users/ackintosh/followers","following_url":"https://api.github.com/users/ackintosh/following{/other_user}","gists_url":"https://api.github.com/users/ackintosh/gists{/gist_id}","starred_url":"https://api.github.com/users/ackintosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ackintosh/subscriptions","organizations_url":"https://api.github.com/users/ackintosh/orgs","repos_url":"https://api.github.com/users/ackintosh/repos","events_url":"https://api.github.com/users/ackintosh/events{/privacy}","received_events_url":"https://api.github.com/users/ackintosh/received_events","type":"User","site_admin":false},"body":"Using [sha256](https://github.com/komputing/KEthereum/tree/master/hashes/src/main/kotlin/org/kethereum/hashes) which is under `hashes` package for now but the hash algorithm may not appropriate. I'd like to try to implement more lightweight algorithm into the `hashes` package. ๐ ","created_at":"2019-06-15T09:31:10Z","updated_at":"2019-06-15T09:31:10Z","html_url":"https://github.com/komputing/KEthereum/pull/69#discussion_r294041034","pull_request_url":"https://api.github.com/repos/komputing/KEthereum/pulls/69","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/komputing/KEthereum/pulls/comments/294041034"},"html":{"href":"https://github.com/komputing/KEthereum/pull/69#discussion_r294041034"},"pull_request":{"href":"https://api.github.com/repos/komputing/KEthereum/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/komputing/KEthereum/pulls/69","id":288544689,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NTQ0Njg5","html_url":"https://github.com/komputing/KEthereum/pull/69","diff_url":"https://github.com/komputing/KEthereum/pull/69.diff","patch_url":"https://github.com/komputing/KEthereum/pull/69.patch","issue_url":"https://api.github.com/repos/komputing/KEthereum/issues/69","number":69,"state":"open","locked":false,"title":"Add BloomFilter","user":{"login":"ackintosh","id":1885716,"node_id":"MDQ6VXNlcjE4ODU3MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1885716?v=4","gravatar_id":"","url":"https://api.github.com/users/ackintosh","html_url":"https://github.com/ackintosh","followers_url":"https://api.github.com/users/ackintosh/followers","following_url":"https://api.github.com/users/ackintosh/following{/other_user}","gists_url":"https://api.github.com/users/ackintosh/gists{/gist_id}","starred_url":"https://api.github.com/users/ackintosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ackintosh/subscriptions","organizations_url":"https://api.github.com/users/ackintosh/orgs","repos_url":"https://api.github.com/users/ackintosh/repos","events_url":"https://api.github.com/users/ackintosh/events{/privacy}","received_events_url":"https://api.github.com/users/ackintosh/received_events","type":"User","site_admin":false},"body":"Hi, I've added a Bloom Filter implementation. Please review when you have time. ๐ ","created_at":"2019-06-15T09:24:49Z","updated_at":"2019-06-15T09:31:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e7c346dbf17880743c9f60e0b3a3ada98b9ea20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/komputing/KEthereum/pulls/69/commits","review_comments_url":"https://api.github.com/repos/komputing/KEthereum/pulls/69/comments","review_comment_url":"https://api.github.com/repos/komputing/KEthereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/komputing/KEthereum/issues/69/comments","statuses_url":"https://api.github.com/repos/komputing/KEthereum/statuses/5cdeccb8a04df3c0680a7fa80fdcc80395790fbc","head":{"label":"ackintosh:bloomfilter","ref":"bloomfilter","sha":"5cdeccb8a04df3c0680a7fa80fdcc80395790fbc","user":{"login":"ackintosh","id":1885716,"node_id":"MDQ6VXNlcjE4ODU3MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1885716?v=4","gravatar_id":"","url":"https://api.github.com/users/ackintosh","html_url":"https://github.com/ackintosh","followers_url":"https://api.github.com/users/ackintosh/followers","following_url":"https://api.github.com/users/ackintosh/following{/other_user}","gists_url":"https://api.github.com/users/ackintosh/gists{/gist_id}","starred_url":"https://api.github.com/users/ackintosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ackintosh/subscriptions","organizations_url":"https://api.github.com/users/ackintosh/orgs","repos_url":"https://api.github.com/users/ackintosh/repos","events_url":"https://api.github.com/users/ackintosh/events{/privacy}","received_events_url":"https://api.github.com/users/ackintosh/received_events","type":"User","site_admin":false},"repo":{"id":192056521,"node_id":"MDEwOlJlcG9zaXRvcnkxOTIwNTY1MjE=","name":"KEthereum","full_name":"ackintosh/KEthereum","private":false,"owner":{"login":"ackintosh","id":1885716,"node_id":"MDQ6VXNlcjE4ODU3MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1885716?v=4","gravatar_id":"","url":"https://api.github.com/users/ackintosh","html_url":"https://github.com/ackintosh","followers_url":"https://api.github.com/users/ackintosh/followers","following_url":"https://api.github.com/users/ackintosh/following{/other_user}","gists_url":"https://api.github.com/users/ackintosh/gists{/gist_id}","starred_url":"https://api.github.com/users/ackintosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ackintosh/subscriptions","organizations_url":"https://api.github.com/users/ackintosh/orgs","repos_url":"https://api.github.com/users/ackintosh/repos","events_url":"https://api.github.com/users/ackintosh/events{/privacy}","received_events_url":"https://api.github.com/users/ackintosh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ackintosh/KEthereum","description":"Kotlin library for Ethereum","fork":true,"url":"https://api.github.com/repos/ackintosh/KEthereum","forks_url":"https://api.github.com/repos/ackintosh/KEthereum/forks","keys_url":"https://api.github.com/repos/ackintosh/KEthereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ackintosh/KEthereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ackintosh/KEthereum/teams","hooks_url":"https://api.github.com/repos/ackintosh/KEthereum/hooks","issue_events_url":"https://api.github.com/repos/ackintosh/KEthereum/issues/events{/number}","events_url":"https://api.github.com/repos/ackintosh/KEthereum/events","assignees_url":"https://api.github.com/repos/ackintosh/KEthereum/assignees{/user}","branches_url":"https://api.github.com/repos/ackintosh/KEthereum/branches{/branch}","tags_url":"https://api.github.com/repos/ackintosh/KEthereum/tags","blobs_url":"https://api.github.com/repos/ackintosh/KEthereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ackintosh/KEthereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ackintosh/KEthereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ackintosh/KEthereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ackintosh/KEthereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ackintosh/KEthereum/languages","stargazers_url":"https://api.github.com/repos/ackintosh/KEthereum/stargazers","contributors_url":"https://api.github.com/repos/ackintosh/KEthereum/contributors","subscribers_url":"https://api.github.com/repos/ackintosh/KEthereum/subscribers","subscription_url":"https://api.github.com/repos/ackintosh/KEthereum/subscription","commits_url":"https://api.github.com/repos/ackintosh/KEthereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ackintosh/KEthereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ackintosh/KEthereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ackintosh/KEthereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ackintosh/KEthereum/contents/{+path}","compare_url":"https://api.github.com/repos/ackintosh/KEthereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ackintosh/KEthereum/merges","archive_url":"https://api.github.com/repos/ackintosh/KEthereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ackintosh/KEthereum/downloads","issues_url":"https://api.github.com/repos/ackintosh/KEthereum/issues{/number}","pulls_url":"https://api.github.com/repos/ackintosh/KEthereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ackintosh/KEthereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ackintosh/KEthereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ackintosh/KEthereum/labels{/name}","releases_url":"https://api.github.com/repos/ackintosh/KEthereum/releases{/id}","deployments_url":"https://api.github.com/repos/ackintosh/KEthereum/deployments","created_at":"2019-06-15T08:43:09Z","updated_at":"2019-06-15T08:43:12Z","pushed_at":"2019-06-15T09:21:41Z","git_url":"git://github.com/ackintosh/KEthereum.git","ssh_url":"[email protected]:ackintosh/KEthereum.git","clone_url":"https://github.com/ackintosh/KEthereum.git","svn_url":"https://github.com/ackintosh/KEthereum","homepage":"","size":1701,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"komputing:master","ref":"master","sha":"d068084e2f909d2ea45d1c7abe05d2ff9892345f","user":{"login":"komputing","id":48826811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4ODI2ODEx","avatar_url":"https://avatars1.githubusercontent.com/u/48826811?v=4","gravatar_id":"","url":"https://api.github.com/users/komputing","html_url":"https://github.com/komputing","followers_url":"https://api.github.com/users/komputing/followers","following_url":"https://api.github.com/users/komputing/following{/other_user}","gists_url":"https://api.github.com/users/komputing/gists{/gist_id}","starred_url":"https://api.github.com/users/komputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komputing/subscriptions","organizations_url":"https://api.github.com/users/komputing/orgs","repos_url":"https://api.github.com/users/komputing/repos","events_url":"https://api.github.com/users/komputing/events{/privacy}","received_events_url":"https://api.github.com/users/komputing/received_events","type":"Organization","site_admin":false},"repo":{"id":92780266,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjc4MDI2Ng==","name":"KEthereum","full_name":"komputing/KEthereum","private":false,"owner":{"login":"komputing","id":48826811,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4ODI2ODEx","avatar_url":"https://avatars1.githubusercontent.com/u/48826811?v=4","gravatar_id":"","url":"https://api.github.com/users/komputing","html_url":"https://github.com/komputing","followers_url":"https://api.github.com/users/komputing/followers","following_url":"https://api.github.com/users/komputing/following{/other_user}","gists_url":"https://api.github.com/users/komputing/gists{/gist_id}","starred_url":"https://api.github.com/users/komputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komputing/subscriptions","organizations_url":"https://api.github.com/users/komputing/orgs","repos_url":"https://api.github.com/users/komputing/repos","events_url":"https://api.github.com/users/komputing/events{/privacy}","received_events_url":"https://api.github.com/users/komputing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/komputing/KEthereum","description":"Kotlin library for Ethereum","fork":false,"url":"https://api.github.com/repos/komputing/KEthereum","forks_url":"https://api.github.com/repos/komputing/KEthereum/forks","keys_url":"https://api.github.com/repos/komputing/KEthereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/komputing/KEthereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/komputing/KEthereum/teams","hooks_url":"https://api.github.com/repos/komputing/KEthereum/hooks","issue_events_url":"https://api.github.com/repos/komputing/KEthereum/issues/events{/number}","events_url":"https://api.github.com/repos/komputing/KEthereum/events","assignees_url":"https://api.github.com/repos/komputing/KEthereum/assignees{/user}","branches_url":"https://api.github.com/repos/komputing/KEthereum/branches{/branch}","tags_url":"https://api.github.com/repos/komputing/KEthereum/tags","blobs_url":"https://api.github.com/repos/komputing/KEthereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/komputing/KEthereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/komputing/KEthereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/komputing/KEthereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/komputing/KEthereum/statuses/{sha}","languages_url":"https://api.github.com/repos/komputing/KEthereum/languages","stargazers_url":"https://api.github.com/repos/komputing/KEthereum/stargazers","contributors_url":"https://api.github.com/repos/komputing/KEthereum/contributors","subscribers_url":"https://api.github.com/repos/komputing/KEthereum/subscribers","subscription_url":"https://api.github.com/repos/komputing/KEthereum/subscription","commits_url":"https://api.github.com/repos/komputing/KEthereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/komputing/KEthereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/komputing/KEthereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/komputing/KEthereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/komputing/KEthereum/contents/{+path}","compare_url":"https://api.github.com/repos/komputing/KEthereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/komputing/KEthereum/merges","archive_url":"https://api.github.com/repos/komputing/KEthereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/komputing/KEthereum/downloads","issues_url":"https://api.github.com/repos/komputing/KEthereum/issues{/number}","pulls_url":"https://api.github.com/repos/komputing/KEthereum/pulls{/number}","milestones_url":"https://api.github.com/repos/komputing/KEthereum/milestones{/number}","notifications_url":"https://api.github.com/repos/komputing/KEthereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/komputing/KEthereum/labels{/name}","releases_url":"https://api.github.com/repos/komputing/KEthereum/releases{/id}","deployments_url":"https://api.github.com/repos/komputing/KEthereum/deployments","created_at":"2017-05-29T22:37:45Z","updated_at":"2019-05-30T16:27:12Z","pushed_at":"2019-06-15T09:24:50Z","git_url":"git://github.com/komputing/KEthereum.git","ssh_url":"[email protected]:komputing/KEthereum.git","clone_url":"https://github.com/komputing/KEthereum.git","svn_url":"https://github.com/komputing/KEthereum","homepage":"","size":1701,"stargazers_count":107,"watchers_count":107,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":29,"open_issues":19,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/komputing/KEthereum/pulls/69"},"html":{"href":"https://github.com/komputing/KEthereum/pull/69"},"issue":{"href":"https://api.github.com/repos/komputing/KEthereum/issues/69"},"comments":{"href":"https://api.github.com/repos/komputing/KEthereum/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/komputing/KEthereum/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/komputing/KEthereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/komputing/KEthereum/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/komputing/KEthereum/statuses/5cdeccb8a04df3c0680a7fa80fdcc80395790fbc"}},"author_association":"NONE"}}
|
{
"id": 92780266,
"name": "komputing/KEthereum",
"url": "https://api.github.com/repos/komputing/KEthereum"
}
|
{
"id": 1885716,
"login": "ackintosh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1885716?",
"url": "https://api.github.com/users/ackintosh"
}
|
{
"id": 48826811,
"login": "komputing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48826811?",
"url": "https://api.github.com/orgs/komputing"
}
| 2019-06-15T09:31:10 |
9828227221
|
{"actor":{"display_login":"ackintosh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/BotGaia/Gaia/pulls/comments/296421064","pull_request_review_id":253066408,"id":296421064,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjQyMTA2NA==","diff_hunk":"@@ -21,23 +21,20 @@ def run(self, dispatcher, tracker, domain):\n if(len(answer_json) > 0):\n if \"Notificaรงรฃo excluรญda\" in answer_json:\n message = 'Entendido. Mande os novos dados'\n- message1 = ' da seguinte forma: Quero registrar [esporte'\n- message2 = ' desejado] para [dia(s) da semana] ร s'\n- message3 = ' [hora] e [minutos] no [local(is) desejado(s)]'\n- dispatcher.utter_message(message + message1)\n- dispatcher.utter_message(message2 + message3)\n+ message += ' da seguinte forma: Quero registrar [esporte'\n+ message += ' desejado] para [dia(s) da semana] ร s'\n+ message += ' [hora] e [minutos] no [local(is) desejado(s)]'\n+ dispatcher.utter_message(message)\n else:\n dispatcher.utter_message(\"Nรฃo foi possรญvel \\\n editar a notificaรงรฃo.\")\n else:\n- message4 = 'Vocรช nรฃo possui notificaรงรฃo.'\n- message5 = ' Para criar: Quero registrar'\n- message6 = ' [esporte desejado] para'\n- message7 = ' [dia(s) da semana] ร s [hora]'\n- message8 = ' e [minutos] no'\n- message9 = ' [local(is) desejado(s)]'\n- dispatcher.utter_message(message4 + message5)\n- dispatcher.utter_message(message6 + message7)\n- dispatcher.utter_message(message8 + message9)\n+ message1 = 'Vocรช nรฃo possui notificaรงรฃo.'\n+ message += ' Para criar: Quero registrar'\n+ message += ' [esporte desejado] para'\n+ message += ' [dia(s) da semana] ร s [hora]'\n+ message += ' e [minutos] no'\n+ message += ' [local(is) desejado(s)]'\n+ dispatcher.utter_message(message1)","path":"bot/actions/action_edit_notification.py","position":32,"original_position":32,"commit_id":"46105edfd7f38f756ea8243978e930d25f2d19fb","original_commit_id":"46105edfd7f38f756ea8243978e930d25f2d19fb","user":{"login":"CalebeRios","id":1852287,"node_id":"MDQ6VXNlcjE4NTIyODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1852287?v=4","gravatar_id":"","url":"https://api.github.com/users/CalebeRios","html_url":"https://github.com/CalebeRios","followers_url":"https://api.github.com/users/CalebeRios/followers","following_url":"https://api.github.com/users/CalebeRios/following{/other_user}","gists_url":"https://api.github.com/users/CalebeRios/gists{/gist_id}","starred_url":"https://api.github.com/users/CalebeRios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CalebeRios/subscriptions","organizations_url":"https://api.github.com/users/CalebeRios/orgs","repos_url":"https://api.github.com/users/CalebeRios/repos","events_url":"https://api.github.com/users/CalebeRios/events{/privacy}","received_events_url":"https://api.github.com/users/CalebeRios/received_events","type":"User","site_admin":false},"body":"Porque estรก passando sรณ `message1`?","created_at":"2019-06-21T23:32:23Z","updated_at":"2019-06-21T23:34:12Z","html_url":"https://github.com/BotGaia/Gaia/pull/32#discussion_r296421064","pull_request_url":"https://api.github.com/repos/BotGaia/Gaia/pulls/32","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/BotGaia/Gaia/pulls/comments/296421064"},"html":{"href":"https://github.com/BotGaia/Gaia/pull/32#discussion_r296421064"},"pull_request":{"href":"https://api.github.com/repos/BotGaia/Gaia/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/BotGaia/Gaia/pulls/32","id":290670364,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNjcwMzY0","html_url":"https://github.com/BotGaia/Gaia/pull/32","diff_url":"https://github.com/BotGaia/Gaia/pull/32.diff","patch_url":"https://github.com/BotGaia/Gaia/pull/32.patch","issue_url":"https://api.github.com/repos/BotGaia/Gaia/issues/32","number":32,"state":"open","locked":false,"title":"Wip #252 melhorar conversa","user":{"login":"micaellagouveia","id":48630408,"node_id":"MDQ6VXNlcjQ4NjMwNDA4","avatar_url":"https://avatars2.githubusercontent.com/u/48630408?v=4","gravatar_id":"","url":"https://api.github.com/users/micaellagouveia","html_url":"https://github.com/micaellagouveia","followers_url":"https://api.github.com/users/micaellagouveia/followers","following_url":"https://api.github.com/users/micaellagouveia/following{/other_user}","gists_url":"https://api.github.com/users/micaellagouveia/gists{/gist_id}","starred_url":"https://api.github.com/users/micaellagouveia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micaellagouveia/subscriptions","organizations_url":"https://api.github.com/users/micaellagouveia/orgs","repos_url":"https://api.github.com/users/micaellagouveia/repos","events_url":"https://api.github.com/users/micaellagouveia/events{/privacy}","received_events_url":"https://api.github.com/users/micaellagouveia/received_events","type":"User","site_admin":false},"body":"Nesse pull request foi feito\r\nIssue #252\r\nMelhoria na conversa da Gaia","created_at":"2019-06-21T16:20:41Z","updated_at":"2019-06-21T23:34:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a46ccb1627228ee8f464c5b4770817cd1ca7adda","assignee":{"login":"sofiapatrocinio","id":38709421,"node_id":"MDQ6VXNlcjM4NzA5NDIx","avatar_url":"https://avatars3.githubusercontent.com/u/38709421?v=4","gravatar_id":"","url":"https://api.github.com/users/sofiapatrocinio","html_url":"https://github.com/sofiapatrocinio","followers_url":"https://api.github.com/users/sofiapatrocinio/followers","following_url":"https://api.github.com/users/sofiapatrocinio/following{/other_user}","gists_url":"https://api.github.com/users/sofiapatrocinio/gists{/gist_id}","starred_url":"https://api.github.com/users/sofiapatrocinio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofiapatrocinio/subscriptions","organizations_url":"https://api.github.com/users/sofiapatrocinio/orgs","repos_url":"https://api.github.com/users/sofiapatrocinio/repos","events_url":"https://api.github.com/users/sofiapatrocinio/events{/privacy}","received_events_url":"https://api.github.com/users/sofiapatrocinio/received_events","type":"User","site_admin":false},"assignees":[{"login":"sofiapatrocinio","id":38709421,"node_id":"MDQ6VXNlcjM4NzA5NDIx","avatar_url":"https://avatars3.githubusercontent.com/u/38709421?v=4","gravatar_id":"","url":"https://api.github.com/users/sofiapatrocinio","html_url":"https://github.com/sofiapatrocinio","followers_url":"https://api.github.com/users/sofiapatrocinio/followers","following_url":"https://api.github.com/users/sofiapatrocinio/following{/other_user}","gists_url":"https://api.github.com/users/sofiapatrocinio/gists{/gist_id}","starred_url":"https://api.github.com/users/sofiapatrocinio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofiapatrocinio/subscriptions","organizations_url":"https://api.github.com/users/sofiapatrocinio/orgs","repos_url":"https://api.github.com/users/sofiapatrocinio/repos","events_url":"https://api.github.com/users/sofiapatrocinio/events{/privacy}","received_events_url":"https://api.github.com/users/sofiapatrocinio/received_events","type":"User","site_admin":false},{"login":"micaellagouveia","id":48630408,"node_id":"MDQ6VXNlcjQ4NjMwNDA4","avatar_url":"https://avatars2.githubusercontent.com/u/48630408?v=4","gravatar_id":"","url":"https://api.github.com/users/micaellagouveia","html_url":"https://github.com/micaellagouveia","followers_url":"https://api.github.com/users/micaellagouveia/followers","following_url":"https://api.github.com/users/micaellagouveia/following{/other_user}","gists_url":"https://api.github.com/users/micaellagouveia/gists{/gist_id}","starred_url":"https://api.github.com/users/micaellagouveia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micaellagouveia/subscriptions","organizations_url":"https://api.github.com/users/micaellagouveia/orgs","repos_url":"https://api.github.com/users/micaellagouveia/repos","events_url":"https://api.github.com/users/micaellagouveia/events{/privacy}","received_events_url":"https://api.github.com/users/micaellagouveia/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"inddiara","id":15816672,"node_id":"MDQ6VXNlcjE1ODE2Njcy","avatar_url":"https://avatars3.githubusercontent.com/u/15816672?v=4","gravatar_id":"","url":"https://api.github.com/users/inddiara","html_url":"https://github.com/inddiara","followers_url":"https://api.github.com/users/inddiara/followers","following_url":"https://api.github.com/users/inddiara/following{/other_user}","gists_url":"https://api.github.com/users/inddiara/gists{/gist_id}","starred_url":"https://api.github.com/users/inddiara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inddiara/subscriptions","organizations_url":"https://api.github.com/users/inddiara/orgs","repos_url":"https://api.github.com/users/inddiara/repos","events_url":"https://api.github.com/users/inddiara/events{/privacy}","received_events_url":"https://api.github.com/users/inddiara/received_events","type":"User","site_admin":false},{"login":"AmandaMuniz","id":22080321,"node_id":"MDQ6VXNlcjIyMDgwMzIx","avatar_url":"https://avatars0.githubusercontent.com/u/22080321?v=4","gravatar_id":"","url":"https://api.github.com/users/AmandaMuniz","html_url":"https://github.com/AmandaMuniz","followers_url":"https://api.github.com/users/AmandaMuniz/followers","following_url":"https://api.github.com/users/AmandaMuniz/following{/other_user}","gists_url":"https://api.github.com/users/AmandaMuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/AmandaMuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmandaMuniz/subscriptions","organizations_url":"https://api.github.com/users/AmandaMuniz/orgs","repos_url":"https://api.github.com/users/AmandaMuniz/repos","events_url":"https://api.github.com/users/AmandaMuniz/events{/privacy}","received_events_url":"https://api.github.com/users/AmandaMuniz/received_events","type":"User","site_admin":false},{"login":"SamButers","id":42394633,"node_id":"MDQ6VXNlcjQyMzk0NjMz","avatar_url":"https://avatars0.githubusercontent.com/u/42394633?v=4","gravatar_id":"","url":"https://api.github.com/users/SamButers","html_url":"https://github.com/SamButers","followers_url":"https://api.github.com/users/SamButers/followers","following_url":"https://api.github.com/users/SamButers/following{/other_user}","gists_url":"https://api.github.com/users/SamButers/gists{/gist_id}","starred_url":"https://api.github.com/users/SamButers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamButers/subscriptions","organizations_url":"https://api.github.com/users/SamButers/orgs","repos_url":"https://api.github.com/users/SamButers/repos","events_url":"https://api.github.com/users/SamButers/events{/privacy}","received_events_url":"https://api.github.com/users/SamButers/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BotGaia/Gaia/pulls/32/commits","review_comments_url":"https://api.github.com/repos/BotGaia/Gaia/pulls/32/comments","review_comment_url":"https://api.github.com/repos/BotGaia/Gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BotGaia/Gaia/issues/32/comments","statuses_url":"https://api.github.com/repos/BotGaia/Gaia/statuses/46105edfd7f38f756ea8243978e930d25f2d19fb","head":{"label":"BotGaia:#252_melhorar_conversa","ref":"#252_melhorar_conversa","sha":"46105edfd7f38f756ea8243978e930d25f2d19fb","user":{"login":"BotGaia","id":48934476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTM0NDc2","avatar_url":"https://avatars0.githubusercontent.com/u/48934476?v=4","gravatar_id":"","url":"https://api.github.com/users/BotGaia","html_url":"https://github.com/BotGaia","followers_url":"https://api.github.com/users/BotGaia/followers","following_url":"https://api.github.com/users/BotGaia/following{/other_user}","gists_url":"https://api.github.com/users/BotGaia/gists{/gist_id}","starred_url":"https://api.github.com/users/BotGaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BotGaia/subscriptions","organizations_url":"https://api.github.com/users/BotGaia/orgs","repos_url":"https://api.github.com/users/BotGaia/repos","events_url":"https://api.github.com/users/BotGaia/events{/privacy}","received_events_url":"https://api.github.com/users/BotGaia/received_events","type":"Organization","site_admin":false},"repo":{"id":178314746,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgzMTQ3NDY=","name":"Gaia","full_name":"BotGaia/Gaia","private":false,"owner":{"login":"BotGaia","id":48934476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTM0NDc2","avatar_url":"https://avatars0.githubusercontent.com/u/48934476?v=4","gravatar_id":"","url":"https://api.github.com/users/BotGaia","html_url":"https://github.com/BotGaia","followers_url":"https://api.github.com/users/BotGaia/followers","following_url":"https://api.github.com/users/BotGaia/following{/other_user}","gists_url":"https://api.github.com/users/BotGaia/gists{/gist_id}","starred_url":"https://api.github.com/users/BotGaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BotGaia/subscriptions","organizations_url":"https://api.github.com/users/BotGaia/orgs","repos_url":"https://api.github.com/users/BotGaia/repos","events_url":"https://api.github.com/users/BotGaia/events{/privacy}","received_events_url":"https://api.github.com/users/BotGaia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BotGaia/Gaia","description":"Saudaรงรตes! Sou Gaia, a Mรฃe-Terra e estou aqui para compartilhar informaรงรตes sobre minha meteorologia e correlacionรก-la com modalidades esportivas.","fork":false,"url":"https://api.github.com/repos/BotGaia/Gaia","forks_url":"https://api.github.com/repos/BotGaia/Gaia/forks","keys_url":"https://api.github.com/repos/BotGaia/Gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BotGaia/Gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BotGaia/Gaia/teams","hooks_url":"https://api.github.com/repos/BotGaia/Gaia/hooks","issue_events_url":"https://api.github.com/repos/BotGaia/Gaia/issues/events{/number}","events_url":"https://api.github.com/repos/BotGaia/Gaia/events","assignees_url":"https://api.github.com/repos/BotGaia/Gaia/assignees{/user}","branches_url":"https://api.github.com/repos/BotGaia/Gaia/branches{/branch}","tags_url":"https://api.github.com/repos/BotGaia/Gaia/tags","blobs_url":"https://api.github.com/repos/BotGaia/Gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BotGaia/Gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BotGaia/Gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/BotGaia/Gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BotGaia/Gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/BotGaia/Gaia/languages","stargazers_url":"https://api.github.com/repos/BotGaia/Gaia/stargazers","contributors_url":"https://api.github.com/repos/BotGaia/Gaia/contributors","subscribers_url":"https://api.github.com/repos/BotGaia/Gaia/subscribers","subscription_url":"https://api.github.com/repos/BotGaia/Gaia/subscription","commits_url":"https://api.github.com/repos/BotGaia/Gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/BotGaia/Gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/BotGaia/Gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/BotGaia/Gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/BotGaia/Gaia/contents/{+path}","compare_url":"https://api.github.com/repos/BotGaia/Gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BotGaia/Gaia/merges","archive_url":"https://api.github.com/repos/BotGaia/Gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BotGaia/Gaia/downloads","issues_url":"https://api.github.com/repos/BotGaia/Gaia/issues{/number}","pulls_url":"https://api.github.com/repos/BotGaia/Gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/BotGaia/Gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/BotGaia/Gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BotGaia/Gaia/labels{/name}","releases_url":"https://api.github.com/repos/BotGaia/Gaia/releases{/id}","deployments_url":"https://api.github.com/repos/BotGaia/Gaia/deployments","created_at":"2019-03-29T02:07:12Z","updated_at":"2019-06-20T05:43:07Z","pushed_at":"2019-06-21T21:46:59Z","git_url":"git://github.com/BotGaia/Gaia.git","ssh_url":"[email protected]:BotGaia/Gaia.git","clone_url":"https://github.com/BotGaia/Gaia.git","svn_url":"https://github.com/BotGaia/Gaia","homepage":"https://t.me/DeusaGaiaBot","size":2044,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":1,"watchers":4,"default_branch":"dev"}},"base":{"label":"BotGaia:dev","ref":"dev","sha":"4e481a6069045affe9b19ec834a20e2c2c831773","user":{"login":"BotGaia","id":48934476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTM0NDc2","avatar_url":"https://avatars0.githubusercontent.com/u/48934476?v=4","gravatar_id":"","url":"https://api.github.com/users/BotGaia","html_url":"https://github.com/BotGaia","followers_url":"https://api.github.com/users/BotGaia/followers","following_url":"https://api.github.com/users/BotGaia/following{/other_user}","gists_url":"https://api.github.com/users/BotGaia/gists{/gist_id}","starred_url":"https://api.github.com/users/BotGaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BotGaia/subscriptions","organizations_url":"https://api.github.com/users/BotGaia/orgs","repos_url":"https://api.github.com/users/BotGaia/repos","events_url":"https://api.github.com/users/BotGaia/events{/privacy}","received_events_url":"https://api.github.com/users/BotGaia/received_events","type":"Organization","site_admin":false},"repo":{"id":178314746,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgzMTQ3NDY=","name":"Gaia","full_name":"BotGaia/Gaia","private":false,"owner":{"login":"BotGaia","id":48934476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTM0NDc2","avatar_url":"https://avatars0.githubusercontent.com/u/48934476?v=4","gravatar_id":"","url":"https://api.github.com/users/BotGaia","html_url":"https://github.com/BotGaia","followers_url":"https://api.github.com/users/BotGaia/followers","following_url":"https://api.github.com/users/BotGaia/following{/other_user}","gists_url":"https://api.github.com/users/BotGaia/gists{/gist_id}","starred_url":"https://api.github.com/users/BotGaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BotGaia/subscriptions","organizations_url":"https://api.github.com/users/BotGaia/orgs","repos_url":"https://api.github.com/users/BotGaia/repos","events_url":"https://api.github.com/users/BotGaia/events{/privacy}","received_events_url":"https://api.github.com/users/BotGaia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BotGaia/Gaia","description":"Saudaรงรตes! Sou Gaia, a Mรฃe-Terra e estou aqui para compartilhar informaรงรตes sobre minha meteorologia e correlacionรก-la com modalidades esportivas.","fork":false,"url":"https://api.github.com/repos/BotGaia/Gaia","forks_url":"https://api.github.com/repos/BotGaia/Gaia/forks","keys_url":"https://api.github.com/repos/BotGaia/Gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BotGaia/Gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BotGaia/Gaia/teams","hooks_url":"https://api.github.com/repos/BotGaia/Gaia/hooks","issue_events_url":"https://api.github.com/repos/BotGaia/Gaia/issues/events{/number}","events_url":"https://api.github.com/repos/BotGaia/Gaia/events","assignees_url":"https://api.github.com/repos/BotGaia/Gaia/assignees{/user}","branches_url":"https://api.github.com/repos/BotGaia/Gaia/branches{/branch}","tags_url":"https://api.github.com/repos/BotGaia/Gaia/tags","blobs_url":"https://api.github.com/repos/BotGaia/Gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BotGaia/Gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BotGaia/Gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/BotGaia/Gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BotGaia/Gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/BotGaia/Gaia/languages","stargazers_url":"https://api.github.com/repos/BotGaia/Gaia/stargazers","contributors_url":"https://api.github.com/repos/BotGaia/Gaia/contributors","subscribers_url":"https://api.github.com/repos/BotGaia/Gaia/subscribers","subscription_url":"https://api.github.com/repos/BotGaia/Gaia/subscription","commits_url":"https://api.github.com/repos/BotGaia/Gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/BotGaia/Gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/BotGaia/Gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/BotGaia/Gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/BotGaia/Gaia/contents/{+path}","compare_url":"https://api.github.com/repos/BotGaia/Gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BotGaia/Gaia/merges","archive_url":"https://api.github.com/repos/BotGaia/Gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BotGaia/Gaia/downloads","issues_url":"https://api.github.com/repos/BotGaia/Gaia/issues{/number}","pulls_url":"https://api.github.com/repos/BotGaia/Gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/BotGaia/Gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/BotGaia/Gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BotGaia/Gaia/labels{/name}","releases_url":"https://api.github.com/repos/BotGaia/Gaia/releases{/id}","deployments_url":"https://api.github.com/repos/BotGaia/Gaia/deployments","created_at":"2019-03-29T02:07:12Z","updated_at":"2019-06-20T05:43:07Z","pushed_at":"2019-06-21T21:46:59Z","git_url":"git://github.com/BotGaia/Gaia.git","ssh_url":"[email protected]:BotGaia/Gaia.git","clone_url":"https://github.com/BotGaia/Gaia.git","svn_url":"https://github.com/BotGaia/Gaia","homepage":"https://t.me/DeusaGaiaBot","size":2044,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":1,"watchers":4,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/BotGaia/Gaia/pulls/32"},"html":{"href":"https://github.com/BotGaia/Gaia/pull/32"},"issue":{"href":"https://api.github.com/repos/BotGaia/Gaia/issues/32"},"comments":{"href":"https://api.github.com/repos/BotGaia/Gaia/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/BotGaia/Gaia/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/BotGaia/Gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BotGaia/Gaia/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/BotGaia/Gaia/statuses/46105edfd7f38f756ea8243978e930d25f2d19fb"}},"author_association":"COLLABORATOR"}}
|
{
"id": 178314746,
"name": "BotGaia/Gaia",
"url": "https://api.github.com/repos/BotGaia/Gaia"
}
|
{
"id": 1852287,
"login": "CalebeRios",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1852287?",
"url": "https://api.github.com/users/CalebeRios"
}
|
{
"id": 48934476,
"login": "BotGaia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48934476?",
"url": "https://api.github.com/orgs/BotGaia"
}
| 2019-06-21T23:32:23 |
9871929703
|
{"actor":{"display_login":"CalebeRios"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/comments/282628735","pull_request_review_id":235776644,"id":282628735,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MjYyODczNQ==","diff_hunk":"@@ -104,6 +110,39 @@ private Project getValidProject(Long id) {\n return ResponseEntity.ok(sprints);\n }\n \n+ @Override\n+ public ResponseEntity<SprintSummaryDto> getSprintSummary(Long projectId, Long sprintId) {\n+ Project project = getValidProject(projectId);\n+ Sprint sprint = getValidSprint(sprintId);\n+\n+ if (!isUserRoleAdmin(projectId, userContext.getUserIdn()) || !isSprintInProject(sprint, project)) {\n+ throw new ForbiddenAccessException();\n+ }\n+\n+ List<AvailabilityDto> availabilities = projectService\n+ .getAllUsersIdInProject(project)\n+ .stream()\n+ .map(id -> availabilityService.getBySprintIdAndUserId(sprintId, id).map(availabilityMapper::mapToApi)\n+ .orElseGet(\n+ () -> new AvailabilityDto().userId(id).timeAvailable(0L).timeRemaining(0L).notes(\"\")))","path":"papaya-web/src/main/java/pl/edu/agh/papaya/rest/projects/controller/ProjectsController.java","position":49,"original_position":49,"commit_id":"9294819d511ebf67f12652269f2febd00c3978cd","original_commit_id":"9294819d511ebf67f12652269f2febd00c3978cd","user":{"login":"szbrnl","id":22968437,"node_id":"MDQ6VXNlcjIyOTY4NDM3","avatar_url":"https://avatars2.githubusercontent.com/u/22968437?v=4","gravatar_id":"","url":"https://api.github.com/users/szbrnl","html_url":"https://github.com/szbrnl","followers_url":"https://api.github.com/users/szbrnl/followers","following_url":"https://api.github.com/users/szbrnl/following{/other_user}","gists_url":"https://api.github.com/users/szbrnl/gists{/gist_id}","starred_url":"https://api.github.com/users/szbrnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szbrnl/subscriptions","organizations_url":"https://api.github.com/users/szbrnl/orgs","repos_url":"https://api.github.com/users/szbrnl/repos","events_url":"https://api.github.com/users/szbrnl/events{/privacy}","received_events_url":"https://api.github.com/users/szbrnl/received_events","type":"User","site_admin":false},"body":"aa, to faktycznie problem. Pomysล z UserAvailability mi siฤ osobiลcie najbardziej podoba i jest chyba najwygodniejszy.","created_at":"2019-05-09T19:21:10Z","updated_at":"2019-05-09T19:21:10Z","html_url":"https://github.com/papaya-agh/papaya-backend/pull/32#discussion_r282628735","pull_request_url":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/32","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/comments/282628735"},"html":{"href":"https://github.com/papaya-agh/papaya-backend/pull/32#discussion_r282628735"},"pull_request":{"href":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/32"}},"in_reply_to_id":282186578},"pull_request":{"url":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/32","id":277055392,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3MDU1Mzky","html_url":"https://github.com/papaya-agh/papaya-backend/pull/32","diff_url":"https://github.com/papaya-agh/papaya-backend/pull/32.diff","patch_url":"https://github.com/papaya-agh/papaya-backend/pull/32.patch","issue_url":"https://api.github.com/repos/papaya-agh/papaya-backend/issues/32","number":32,"state":"open","locked":false,"title":"IO2019TEAM-63 Add sprint summary API implementation","user":{"login":"MrMarosis","id":15652446,"node_id":"MDQ6VXNlcjE1NjUyNDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/15652446?v=4","gravatar_id":"","url":"https://api.github.com/users/MrMarosis","html_url":"https://github.com/MrMarosis","followers_url":"https://api.github.com/users/MrMarosis/followers","following_url":"https://api.github.com/users/MrMarosis/following{/other_user}","gists_url":"https://api.github.com/users/MrMarosis/gists{/gist_id}","starred_url":"https://api.github.com/users/MrMarosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrMarosis/subscriptions","organizations_url":"https://api.github.com/users/MrMarosis/orgs","repos_url":"https://api.github.com/users/MrMarosis/repos","events_url":"https://api.github.com/users/MrMarosis/events{/privacy}","received_events_url":"https://api.github.com/users/MrMarosis/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-08T15:55:02Z","updated_at":"2019-05-09T19:21:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81fb1bf879c6ea9c8406b6b53282064546a19106","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kjarosh","id":1507072,"node_id":"MDQ6VXNlcjE1MDcwNzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507072?v=4","gravatar_id":"","url":"https://api.github.com/users/kjarosh","html_url":"https://github.com/kjarosh","followers_url":"https://api.github.com/users/kjarosh/followers","following_url":"https://api.github.com/users/kjarosh/following{/other_user}","gists_url":"https://api.github.com/users/kjarosh/gists{/gist_id}","starred_url":"https://api.github.com/users/kjarosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjarosh/subscriptions","organizations_url":"https://api.github.com/users/kjarosh/orgs","repos_url":"https://api.github.com/users/kjarosh/repos","events_url":"https://api.github.com/users/kjarosh/events{/privacy}","received_events_url":"https://api.github.com/users/kjarosh/received_events","type":"User","site_admin":false},{"login":"Sopel97","id":8037982,"node_id":"MDQ6VXNlcjgwMzc5ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/8037982?v=4","gravatar_id":"","url":"https://api.github.com/users/Sopel97","html_url":"https://github.com/Sopel97","followers_url":"https://api.github.com/users/Sopel97/followers","following_url":"https://api.github.com/users/Sopel97/following{/other_user}","gists_url":"https://api.github.com/users/Sopel97/gists{/gist_id}","starred_url":"https://api.github.com/users/Sopel97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sopel97/subscriptions","organizations_url":"https://api.github.com/users/Sopel97/orgs","repos_url":"https://api.github.com/users/Sopel97/repos","events_url":"https://api.github.com/users/Sopel97/events{/privacy}","received_events_url":"https://api.github.com/users/Sopel97/received_events","type":"User","site_admin":false},{"login":"szbrnl","id":22968437,"node_id":"MDQ6VXNlcjIyOTY4NDM3","avatar_url":"https://avatars2.githubusercontent.com/u/22968437?v=4","gravatar_id":"","url":"https://api.github.com/users/szbrnl","html_url":"https://github.com/szbrnl","followers_url":"https://api.github.com/users/szbrnl/followers","following_url":"https://api.github.com/users/szbrnl/following{/other_user}","gists_url":"https://api.github.com/users/szbrnl/gists{/gist_id}","starred_url":"https://api.github.com/users/szbrnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szbrnl/subscriptions","organizations_url":"https://api.github.com/users/szbrnl/orgs","repos_url":"https://api.github.com/users/szbrnl/repos","events_url":"https://api.github.com/users/szbrnl/events{/privacy}","received_events_url":"https://api.github.com/users/szbrnl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/32/commits","review_comments_url":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/32/comments","review_comment_url":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/papaya-agh/papaya-backend/issues/32/comments","statuses_url":"https://api.github.com/repos/papaya-agh/papaya-backend/statuses/9294819d511ebf67f12652269f2febd00c3978cd","head":{"label":"papaya-agh:IO2019TEAM-63","ref":"IO2019TEAM-63","sha":"9294819d511ebf67f12652269f2febd00c3978cd","user":{"login":"papaya-agh","id":48966735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTY2NzM1","avatar_url":"https://avatars1.githubusercontent.com/u/48966735?v=4","gravatar_id":"","url":"https://api.github.com/users/papaya-agh","html_url":"https://github.com/papaya-agh","followers_url":"https://api.github.com/users/papaya-agh/followers","following_url":"https://api.github.com/users/papaya-agh/following{/other_user}","gists_url":"https://api.github.com/users/papaya-agh/gists{/gist_id}","starred_url":"https://api.github.com/users/papaya-agh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papaya-agh/subscriptions","organizations_url":"https://api.github.com/users/papaya-agh/orgs","repos_url":"https://api.github.com/users/papaya-agh/repos","events_url":"https://api.github.com/users/papaya-agh/events{/privacy}","received_events_url":"https://api.github.com/users/papaya-agh/received_events","type":"Organization","site_admin":false},"repo":{"id":178251145,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyNTExNDU=","name":"papaya-backend","full_name":"papaya-agh/papaya-backend","private":false,"owner":{"login":"papaya-agh","id":48966735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTY2NzM1","avatar_url":"https://avatars1.githubusercontent.com/u/48966735?v=4","gravatar_id":"","url":"https://api.github.com/users/papaya-agh","html_url":"https://github.com/papaya-agh","followers_url":"https://api.github.com/users/papaya-agh/followers","following_url":"https://api.github.com/users/papaya-agh/following{/other_user}","gists_url":"https://api.github.com/users/papaya-agh/gists{/gist_id}","starred_url":"https://api.github.com/users/papaya-agh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papaya-agh/subscriptions","organizations_url":"https://api.github.com/users/papaya-agh/orgs","repos_url":"https://api.github.com/users/papaya-agh/repos","events_url":"https://api.github.com/users/papaya-agh/events{/privacy}","received_events_url":"https://api.github.com/users/papaya-agh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/papaya-agh/papaya-backend","description":null,"fork":false,"url":"https://api.github.com/repos/papaya-agh/papaya-backend","forks_url":"https://api.github.com/repos/papaya-agh/papaya-backend/forks","keys_url":"https://api.github.com/repos/papaya-agh/papaya-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papaya-agh/papaya-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papaya-agh/papaya-backend/teams","hooks_url":"https://api.github.com/repos/papaya-agh/papaya-backend/hooks","issue_events_url":"https://api.github.com/repos/papaya-agh/papaya-backend/issues/events{/number}","events_url":"https://api.github.com/repos/papaya-agh/papaya-backend/events","assignees_url":"https://api.github.com/repos/papaya-agh/papaya-backend/assignees{/user}","branches_url":"https://api.github.com/repos/papaya-agh/papaya-backend/branches{/branch}","tags_url":"https://api.github.com/repos/papaya-agh/papaya-backend/tags","blobs_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papaya-agh/papaya-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/papaya-agh/papaya-backend/languages","stargazers_url":"https://api.github.com/repos/papaya-agh/papaya-backend/stargazers","contributors_url":"https://api.github.com/repos/papaya-agh/papaya-backend/contributors","subscribers_url":"https://api.github.com/repos/papaya-agh/papaya-backend/subscribers","subscription_url":"https://api.github.com/repos/papaya-agh/papaya-backend/subscription","commits_url":"https://api.github.com/repos/papaya-agh/papaya-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/papaya-agh/papaya-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/papaya-agh/papaya-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/papaya-agh/papaya-backend/contents/{+path}","compare_url":"https://api.github.com/repos/papaya-agh/papaya-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papaya-agh/papaya-backend/merges","archive_url":"https://api.github.com/repos/papaya-agh/papaya-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papaya-agh/papaya-backend/downloads","issues_url":"https://api.github.com/repos/papaya-agh/papaya-backend/issues{/number}","pulls_url":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/papaya-agh/papaya-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/papaya-agh/papaya-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papaya-agh/papaya-backend/labels{/name}","releases_url":"https://api.github.com/repos/papaya-agh/papaya-backend/releases{/id}","deployments_url":"https://api.github.com/repos/papaya-agh/papaya-backend/deployments","created_at":"2019-03-28T17:23:19Z","updated_at":"2019-05-08T00:32:35Z","pushed_at":"2019-05-09T17:15:58Z","git_url":"git://github.com/papaya-agh/papaya-backend.git","ssh_url":"[email protected]:papaya-agh/papaya-backend.git","clone_url":"https://github.com/papaya-agh/papaya-backend.git","svn_url":"https://github.com/papaya-agh/papaya-backend","homepage":null,"size":221,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"papaya-agh:master","ref":"master","sha":"c600ac4a2d5cc14401244fd2ed165c2a5e225690","user":{"login":"papaya-agh","id":48966735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTY2NzM1","avatar_url":"https://avatars1.githubusercontent.com/u/48966735?v=4","gravatar_id":"","url":"https://api.github.com/users/papaya-agh","html_url":"https://github.com/papaya-agh","followers_url":"https://api.github.com/users/papaya-agh/followers","following_url":"https://api.github.com/users/papaya-agh/following{/other_user}","gists_url":"https://api.github.com/users/papaya-agh/gists{/gist_id}","starred_url":"https://api.github.com/users/papaya-agh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papaya-agh/subscriptions","organizations_url":"https://api.github.com/users/papaya-agh/orgs","repos_url":"https://api.github.com/users/papaya-agh/repos","events_url":"https://api.github.com/users/papaya-agh/events{/privacy}","received_events_url":"https://api.github.com/users/papaya-agh/received_events","type":"Organization","site_admin":false},"repo":{"id":178251145,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyNTExNDU=","name":"papaya-backend","full_name":"papaya-agh/papaya-backend","private":false,"owner":{"login":"papaya-agh","id":48966735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTY2NzM1","avatar_url":"https://avatars1.githubusercontent.com/u/48966735?v=4","gravatar_id":"","url":"https://api.github.com/users/papaya-agh","html_url":"https://github.com/papaya-agh","followers_url":"https://api.github.com/users/papaya-agh/followers","following_url":"https://api.github.com/users/papaya-agh/following{/other_user}","gists_url":"https://api.github.com/users/papaya-agh/gists{/gist_id}","starred_url":"https://api.github.com/users/papaya-agh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papaya-agh/subscriptions","organizations_url":"https://api.github.com/users/papaya-agh/orgs","repos_url":"https://api.github.com/users/papaya-agh/repos","events_url":"https://api.github.com/users/papaya-agh/events{/privacy}","received_events_url":"https://api.github.com/users/papaya-agh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/papaya-agh/papaya-backend","description":null,"fork":false,"url":"https://api.github.com/repos/papaya-agh/papaya-backend","forks_url":"https://api.github.com/repos/papaya-agh/papaya-backend/forks","keys_url":"https://api.github.com/repos/papaya-agh/papaya-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papaya-agh/papaya-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papaya-agh/papaya-backend/teams","hooks_url":"https://api.github.com/repos/papaya-agh/papaya-backend/hooks","issue_events_url":"https://api.github.com/repos/papaya-agh/papaya-backend/issues/events{/number}","events_url":"https://api.github.com/repos/papaya-agh/papaya-backend/events","assignees_url":"https://api.github.com/repos/papaya-agh/papaya-backend/assignees{/user}","branches_url":"https://api.github.com/repos/papaya-agh/papaya-backend/branches{/branch}","tags_url":"https://api.github.com/repos/papaya-agh/papaya-backend/tags","blobs_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papaya-agh/papaya-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/papaya-agh/papaya-backend/languages","stargazers_url":"https://api.github.com/repos/papaya-agh/papaya-backend/stargazers","contributors_url":"https://api.github.com/repos/papaya-agh/papaya-backend/contributors","subscribers_url":"https://api.github.com/repos/papaya-agh/papaya-backend/subscribers","subscription_url":"https://api.github.com/repos/papaya-agh/papaya-backend/subscription","commits_url":"https://api.github.com/repos/papaya-agh/papaya-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/papaya-agh/papaya-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/papaya-agh/papaya-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/papaya-agh/papaya-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/papaya-agh/papaya-backend/contents/{+path}","compare_url":"https://api.github.com/repos/papaya-agh/papaya-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papaya-agh/papaya-backend/merges","archive_url":"https://api.github.com/repos/papaya-agh/papaya-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papaya-agh/papaya-backend/downloads","issues_url":"https://api.github.com/repos/papaya-agh/papaya-backend/issues{/number}","pulls_url":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/papaya-agh/papaya-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/papaya-agh/papaya-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papaya-agh/papaya-backend/labels{/name}","releases_url":"https://api.github.com/repos/papaya-agh/papaya-backend/releases{/id}","deployments_url":"https://api.github.com/repos/papaya-agh/papaya-backend/deployments","created_at":"2019-03-28T17:23:19Z","updated_at":"2019-05-08T00:32:35Z","pushed_at":"2019-05-09T17:15:58Z","git_url":"git://github.com/papaya-agh/papaya-backend.git","ssh_url":"[email protected]:papaya-agh/papaya-backend.git","clone_url":"https://github.com/papaya-agh/papaya-backend.git","svn_url":"https://github.com/papaya-agh/papaya-backend","homepage":null,"size":221,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/32"},"html":{"href":"https://github.com/papaya-agh/papaya-backend/pull/32"},"issue":{"href":"https://api.github.com/repos/papaya-agh/papaya-backend/issues/32"},"comments":{"href":"https://api.github.com/repos/papaya-agh/papaya-backend/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/papaya-agh/papaya-backend/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/papaya-agh/papaya-backend/statuses/9294819d511ebf67f12652269f2febd00c3978cd"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 178251145,
"name": "papaya-agh/papaya-backend",
"url": "https://api.github.com/repos/papaya-agh/papaya-backend"
}
|
{
"id": 22968437,
"login": "szbrnl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22968437?",
"url": "https://api.github.com/users/szbrnl"
}
|
{
"id": 48966735,
"login": "papaya-agh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48966735?",
"url": "https://api.github.com/orgs/papaya-agh"
}
| 2019-05-09T19:21:10 |
9596719063
|
{"actor":{"display_login":"szbrnl"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/comments/289620100","pull_request_review_id":244603263,"id":289620100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4OTYyMDEwMA==","diff_hunk":"@@ -0,0 +1,42 @@\n+import React from 'react';\n+import Character from './character'\n+import './App.css';\n+import HomeWorld from './homeworld'; \n+import CharacterList from './characters';\n+import { BrowserRouter as Router, Route, Link} from 'react-router-dom';\n+\n+function Home(){\n+return <div><CharacterList /></div>\n+}\n+\n+function Char(){\n+ return <div>{<Character />}</div>\n+}\n+\n+function hWorld(){\n+ return <div>{<HomeWorld />}</div>\n+}\n+\n+class App extends React.Component {\n+ \n+ render(){\n+ \n+ return (\n+ <div>\n+ <Router>\n+ <Link to='/' >Skywalker Family</Link><br />\n+ <Link to=\"/hworld\">HomeWorld</Link><br />\n+ <Link to=\"/char\">Character Details</Link>\n+ <hr />\n+ <switch>\n+ <Route exact path='/' component={Home} />\n+ <Route path='/char' component={Char}/>","path":"starwars-characters/src/App.js","position":33,"original_position":33,"commit_id":"29e10fb2f425dce2a3b8ac54d0c3312386e01d50","original_commit_id":"29e10fb2f425dce2a3b8ac54d0c3312386e01d50","user":{"login":"MadEste","id":11656687,"node_id":"MDQ6VXNlcjExNjU2Njg3","avatar_url":"https://avatars3.githubusercontent.com/u/11656687?v=4","gravatar_id":"","url":"https://api.github.com/users/MadEste","html_url":"https://github.com/MadEste","followers_url":"https://api.github.com/users/MadEste/followers","following_url":"https://api.github.com/users/MadEste/following{/other_user}","gists_url":"https://api.github.com/users/MadEste/gists{/gist_id}","starred_url":"https://api.github.com/users/MadEste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadEste/subscriptions","organizations_url":"https://api.github.com/users/MadEste/orgs","repos_url":"https://api.github.com/users/MadEste/repos","events_url":"https://api.github.com/users/MadEste/events{/privacy}","received_events_url":"https://api.github.com/users/MadEste/received_events","type":"User","site_admin":false},"body":"you need to add a link param to catch whatever id is passed after 'char/' that way you can use it decide what to fetch.\r\n`<Route path='/char/:id' component={Character}/>`\r\nAlso see my note about getting rid of the function components.","created_at":"2019-06-01T22:25:45Z","updated_at":"2019-06-01T22:25:46Z","html_url":"https://github.com/modern-web-application-uw19/week5-assignment/pull/13#discussion_r289620100","pull_request_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/13","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/comments/289620100"},"html":{"href":"https://github.com/modern-web-application-uw19/week5-assignment/pull/13#discussion_r289620100"},"pull_request":{"href":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/13","id":281788458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxNzg4NDU4","html_url":"https://github.com/modern-web-application-uw19/week5-assignment/pull/13","diff_url":"https://github.com/modern-web-application-uw19/week5-assignment/pull/13.diff","patch_url":"https://github.com/modern-web-application-uw19/week5-assignment/pull/13.patch","issue_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/issues/13","number":13,"state":"open","locked":false,"title":"Week 5 Assignment submission","user":{"login":"Jeremyjdz13","id":46872022,"node_id":"MDQ6VXNlcjQ2ODcyMDIy","avatar_url":"https://avatars3.githubusercontent.com/u/46872022?v=4","gravatar_id":"","url":"https://api.github.com/users/Jeremyjdz13","html_url":"https://github.com/Jeremyjdz13","followers_url":"https://api.github.com/users/Jeremyjdz13/followers","following_url":"https://api.github.com/users/Jeremyjdz13/following{/other_user}","gists_url":"https://api.github.com/users/Jeremyjdz13/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeremyjdz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeremyjdz13/subscriptions","organizations_url":"https://api.github.com/users/Jeremyjdz13/orgs","repos_url":"https://api.github.com/users/Jeremyjdz13/repos","events_url":"https://api.github.com/users/Jeremyjdz13/events{/privacy}","received_events_url":"https://api.github.com/users/Jeremyjdz13/received_events","type":"User","site_admin":false},"body":"# Week 5 HW Submission\r\n\r\nPlease fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.\r\n\r\n* Comfort rating on this assignment (1-5):\r\n* Completion rating on this assignment (complete/incomplete):\r\n","created_at":"2019-05-23T21:20:26Z","updated_at":"2019-06-01T22:25:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ceb04ec982c26d147733bd2be86657e0b2b834b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/13/commits","review_comments_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/13/comments","review_comment_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/issues/13/comments","statuses_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/statuses/29e10fb2f425dce2a3b8ac54d0c3312386e01d50","head":{"label":"Jeremyjdz13:master","ref":"master","sha":"29e10fb2f425dce2a3b8ac54d0c3312386e01d50","user":{"login":"Jeremyjdz13","id":46872022,"node_id":"MDQ6VXNlcjQ2ODcyMDIy","avatar_url":"https://avatars3.githubusercontent.com/u/46872022?v=4","gravatar_id":"","url":"https://api.github.com/users/Jeremyjdz13","html_url":"https://github.com/Jeremyjdz13","followers_url":"https://api.github.com/users/Jeremyjdz13/followers","following_url":"https://api.github.com/users/Jeremyjdz13/following{/other_user}","gists_url":"https://api.github.com/users/Jeremyjdz13/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeremyjdz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeremyjdz13/subscriptions","organizations_url":"https://api.github.com/users/Jeremyjdz13/orgs","repos_url":"https://api.github.com/users/Jeremyjdz13/repos","events_url":"https://api.github.com/users/Jeremyjdz13/events{/privacy}","received_events_url":"https://api.github.com/users/Jeremyjdz13/received_events","type":"User","site_admin":false},"repo":{"id":185512195,"node_id":"MDEwOlJlcG9zaXRvcnkxODU1MTIxOTU=","name":"week5-assignment","full_name":"Jeremyjdz13/week5-assignment","private":false,"owner":{"login":"Jeremyjdz13","id":46872022,"node_id":"MDQ6VXNlcjQ2ODcyMDIy","avatar_url":"https://avatars3.githubusercontent.com/u/46872022?v=4","gravatar_id":"","url":"https://api.github.com/users/Jeremyjdz13","html_url":"https://github.com/Jeremyjdz13","followers_url":"https://api.github.com/users/Jeremyjdz13/followers","following_url":"https://api.github.com/users/Jeremyjdz13/following{/other_user}","gists_url":"https://api.github.com/users/Jeremyjdz13/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeremyjdz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeremyjdz13/subscriptions","organizations_url":"https://api.github.com/users/Jeremyjdz13/orgs","repos_url":"https://api.github.com/users/Jeremyjdz13/repos","events_url":"https://api.github.com/users/Jeremyjdz13/events{/privacy}","received_events_url":"https://api.github.com/users/Jeremyjdz13/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Jeremyjdz13/week5-assignment","description":"Week 5 assignment","fork":true,"url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment","forks_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/forks","keys_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/teams","hooks_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/hooks","issue_events_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/issues/events{/number}","events_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/events","assignees_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/assignees{/user}","branches_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/branches{/branch}","tags_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/tags","blobs_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/statuses/{sha}","languages_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/languages","stargazers_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/stargazers","contributors_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/contributors","subscribers_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/subscribers","subscription_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/subscription","commits_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/contents/{+path}","compare_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/merges","archive_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/downloads","issues_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/issues{/number}","pulls_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/pulls{/number}","milestones_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/milestones{/number}","notifications_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/labels{/name}","releases_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/releases{/id}","deployments_url":"https://api.github.com/repos/Jeremyjdz13/week5-assignment/deployments","created_at":"2019-05-08T02:22:29Z","updated_at":"2019-05-31T14:26:43Z","pushed_at":"2019-05-31T14:26:41Z","git_url":"git://github.com/Jeremyjdz13/week5-assignment.git","ssh_url":"[email protected]:Jeremyjdz13/week5-assignment.git","clone_url":"https://github.com/Jeremyjdz13/week5-assignment.git","svn_url":"https://github.com/Jeremyjdz13/week5-assignment","homepage":null,"size":148,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"modern-web-application-uw19:master","ref":"master","sha":"b5d60a48ff757ebb267fac7897ea4dc9852f558b","user":{"login":"modern-web-application-uw19","id":49174616,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MTc0NjE2","avatar_url":"https://avatars0.githubusercontent.com/u/49174616?v=4","gravatar_id":"","url":"https://api.github.com/users/modern-web-application-uw19","html_url":"https://github.com/modern-web-application-uw19","followers_url":"https://api.github.com/users/modern-web-application-uw19/followers","following_url":"https://api.github.com/users/modern-web-application-uw19/following{/other_user}","gists_url":"https://api.github.com/users/modern-web-application-uw19/gists{/gist_id}","starred_url":"https://api.github.com/users/modern-web-application-uw19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modern-web-application-uw19/subscriptions","organizations_url":"https://api.github.com/users/modern-web-application-uw19/orgs","repos_url":"https://api.github.com/users/modern-web-application-uw19/repos","events_url":"https://api.github.com/users/modern-web-application-uw19/events{/privacy}","received_events_url":"https://api.github.com/users/modern-web-application-uw19/received_events","type":"Organization","site_admin":false},"repo":{"id":185496273,"node_id":"MDEwOlJlcG9zaXRvcnkxODU0OTYyNzM=","name":"week5-assignment","full_name":"modern-web-application-uw19/week5-assignment","private":false,"owner":{"login":"modern-web-application-uw19","id":49174616,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MTc0NjE2","avatar_url":"https://avatars0.githubusercontent.com/u/49174616?v=4","gravatar_id":"","url":"https://api.github.com/users/modern-web-application-uw19","html_url":"https://github.com/modern-web-application-uw19","followers_url":"https://api.github.com/users/modern-web-application-uw19/followers","following_url":"https://api.github.com/users/modern-web-application-uw19/following{/other_user}","gists_url":"https://api.github.com/users/modern-web-application-uw19/gists{/gist_id}","starred_url":"https://api.github.com/users/modern-web-application-uw19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modern-web-application-uw19/subscriptions","organizations_url":"https://api.github.com/users/modern-web-application-uw19/orgs","repos_url":"https://api.github.com/users/modern-web-application-uw19/repos","events_url":"https://api.github.com/users/modern-web-application-uw19/events{/privacy}","received_events_url":"https://api.github.com/users/modern-web-application-uw19/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/modern-web-application-uw19/week5-assignment","description":"Week 5 assignment","fork":false,"url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment","forks_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/forks","keys_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/teams","hooks_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/hooks","issue_events_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/issues/events{/number}","events_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/events","assignees_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/assignees{/user}","branches_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/branches{/branch}","tags_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/tags","blobs_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/git/refs{/sha}","trees_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/statuses/{sha}","languages_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/languages","stargazers_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/stargazers","contributors_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/contributors","subscribers_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/subscribers","subscription_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/subscription","commits_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/commits{/sha}","git_commits_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/git/commits{/sha}","comments_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/comments{/number}","issue_comment_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/issues/comments{/number}","contents_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/contents/{+path}","compare_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/merges","archive_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/downloads","issues_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/issues{/number}","pulls_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls{/number}","milestones_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/milestones{/number}","notifications_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/labels{/name}","releases_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/releases{/id}","deployments_url":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/deployments","created_at":"2019-05-08T00:13:10Z","updated_at":"2019-05-08T00:13:22Z","pushed_at":"2019-06-01T08:31:47Z","git_url":"git://github.com/modern-web-application-uw19/week5-assignment.git","ssh_url":"[email protected]:modern-web-application-uw19/week5-assignment.git","clone_url":"https://github.com/modern-web-application-uw19/week5-assignment.git","svn_url":"https://github.com/modern-web-application-uw19/week5-assignment","homepage":null,"size":1,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":null,"forks":27,"open_issues":24,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/13"},"html":{"href":"https://github.com/modern-web-application-uw19/week5-assignment/pull/13"},"issue":{"href":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/issues/13"},"comments":{"href":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/modern-web-application-uw19/week5-assignment/statuses/29e10fb2f425dce2a3b8ac54d0c3312386e01d50"}},"author_association":"NONE"}}
|
{
"id": 185496273,
"name": "modern-web-application-uw19/week5-assignment",
"url": "https://api.github.com/repos/modern-web-application-uw19/week5-assignment"
}
|
{
"id": 11656687,
"login": "MadEste",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11656687?",
"url": "https://api.github.com/users/MadEste"
}
|
{
"id": 49174616,
"login": "modern-web-application-uw19",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49174616?",
"url": "https://api.github.com/orgs/modern-web-application-uw19"
}
| 2019-06-01T22:25:45 |
9740619367
|
{"actor":{"display_login":"MadEste"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/comments/355919437","pull_request_review_id":329681835,"id":355919437,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTkxOTQzNw==","diff_hunk":"@@ -19,108 +19,677 @@ sidebar:\n {% include alert.html type=\"warning\"\n icon=\"warning\"\n header=\"Site under development\"\n- body=\"This section of the Developer Portal is under construction and\n- should not be used to integrate against Swedbank Pay's\n- APIs yet.\" %}\n+ body=\"This section of the Developer Portal is under\n+ construction and should not be used to integrate against\n+ Swedbank Pay's APIs yet.\" %}\n \n ## API requests\n \n The API requests are displayed in the [invoice flow][invoice-flow].\n The options you can choose from when creating a payment with key operation\n-set to Value FinancingConsumer are listed below.\n+set to value `FinancingConsumer` are listed below.\n \n ### Options before posting a payment\n \n {:.table .table-striped}\n-| **POST Request** | Finland ![Finish flag][fi-png] |\n-| **Operation** | FinancingConsumer |\n-| **Intent** | Authorization |\n-| **Currency** | EUR |\n-| **InvoiceType** | PayExFinancingFI |\n+| | Sweden ![Swedish flag][se-png] | Norway ![Norwegian flag][no-png] | FInland ![Finish flag][fi-png] |\n+| :-------------- | :----------------------------- | :------------------------------- | :----------------------------- |\n+| **Operation** | `FinancingConsumer` | `FinancingConsumer` | `FinancingConsumer` |\n+| **Intent** | `Authorization` | `Authorization` | `Authorization` |\n+| **Currency** | SEK | NOK | EUR |\n+| **InvoiceType** | `PayExFinancingSE` | `PayExFinancingNO` | `PayExFinancingFI` |\n \n * An invoice payment is always two-phased based - ย you create an Authorize\n- transaction, that is followed by a Capture or Cancel request.\n+ transaction, that is followed by a Capture or Cancel request.\n * **Defining CallbackURL**: When implementing a scenario, it is optional\n- to set a [CallbackURL][callback-api] in the `POST` request.\n- If callbackURL is set PayEx will send a postback request to this URL when\n- the consumer has fulfilled the payment.\n- [See the Callback API description here.][callback-api]\n+ to set a [CallbackURL][callback-api] in the request.\n+ If callbackURL is set PayEx will send a postback request to this URL when\n+ the consumer has fulfilled the payment.\n+ [See the Callback API description here.][callback-api]\n \n-### Authorizations\n+{% include authorizations-resource.md payment-instrument=\"invoice\" %}\n \n-The `authorizations` resource will list the authorization transactions\n-made on a specific payment.\n+## Payment Resource\n+\n+{% include payment-resource.md %}\n+\n+## Create Payment\n+\n+Within the invoice payments part of the eCommerce API, you can create four kinds\n+of payments ([purchase][purchase], [recurrence][recurrence], and\n+[verification][verify]) and you can inspect and alter the details of the\n+individual transactions within the payment.\n+\n+To create a invoice payment, you perform an HTTP `POST` against the `payments`\n+resource.\n+\n+There are four different kinds of payment that can be created. These are\n+identified with the value of the `operation` property. Each kind are documented\n+in their own section below.\n \n {:.code-header}\n-**Request**\n+**Request**\"\n \n ```http\n-GET /psp/invoice/payments/<payments-id>/authorizations HTTP/1.1\n+POST /psp/invoice/payments HTTP/1.1\n Host: api.externalintegration.payex.com\n Authorization: Bearer <AccessToken>\n Content-Type: application/json\n+\n+{\n+ \"payment\": {\n+ \"operation\": \"<operation>\",\n+ \"intent\": \"<intent>\",\n+ }\n+}\n ```\n \n+{:.table .table-striped}\n+| Required | Property | Type | Description |\n+| :------: | ------------------- | -------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | `payment` | `object` | The `payment` object. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `operation` | `string` | Determines the initial operation, that defines the type invoice payment created.<br> <br> `Purchase`. Used to charge a card. It is followed up by a capture or cancel operation.<br> <br> `Recur`. Used to charge a card on a recurring basis. Is followed up by a capture or cancel operation (if not Autocapture is used, that is).<br> <br>`Verify`. Used when authorizing a card withouth reserveing any funds. It is followed up by a verification transaction. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `intent` | `string` | The intent of the payment identifies how and when the charge will be effectuated. This determine the type transactions used during the payment process.<br> <br>`Authorization`. Reserves the amount, and is followed by a [cancellation][cancel] or [capture][capture] of funds.<br> <br>`AutoCapture`. A one phase-option that enable capture of funds automatically after authorization. |\n+\n+## Purchase\n+\n+A `Purchase` payment is a straightforward way to charge the card of the payer.\n+It is followed up by posting a `capture`, `cancellation` or `reversal`\n+transaction.\n+\n+An example of a request is provided below. Each individual Property of the JSON\n+document is described in the following section.\n+\n+{% include risk-indicator.md %}\n+\n {:.code-header}\n-**Response**\n+**Request**\n \n ```http\n-HTTP/1.1 200 OK\n+POST /psp/invoice/payments HTTP/1.1\n+Authorization: Bearer <AccessToken>\n Content-Type: application/json\n \n {\n- \"payment\": \"/psp/invoice/payments/<payments-id>\",\n- \"authorizations\": {\n- \"id\": \"/psp/invoice/payments/<payments-id>/authorizations\",\n- \"authorizationList\": [\n+ \"payment\": {\n+ \"operation\": \"Purchase\",\n+ \"intent\": \"Authorization\",\n+ \"paymentToken\": \"\",\n+ \"currency\": \"SEK\",\n+ \"prices\": [\n {\n- \"id\": \"/psp/invoice/payments/<payments-id>/authorizations/<transaction-id>\",\n- \"consumer\": {\n- \"id\": \"/psp/invoice/payments/<payments-id>/consumer\"\n- },\n- \"legalAddress\": {\n- \"id\": \"/psp/invoice/payments/<payments-id>/legaladdress\"\n- },\n- \"billingAddress\": {\n- \"id\": \"/psp/invoice/payments/<payments-id>/billingaddress\"\n- },\n- \"transaction\": {\n- \"id\": \"/psp/invoice/payments/<payments-id>/transactions/<transaction-id>\",\n- \"created\": \"2016-09-14T01:01:01.01Z\",\n- \"updated\": \"2016-09-14T01:01:01.03Z\",\n- \"type\": \"Authorization\",\n- \"state\": \"Initialized|Completed|Failed\",\n- \"number\": 1234567890,\n- \"amount\": 1000,\n- \"vatAmount\": 250,\n- \"description\": \"Test transaction\",\n- \"payeeReference\": \"AH123456\",\n- \"failedReason\": \"\",\n- \"isOperational\": false,\n- \"operations\": [\n- {\n- \"href\": \"https://api.externalintegration.payex.com/psp/invoice/payments/<payments-id>\",\n- \"rel\": \"edit-authorization\",\n- \"method\": \"PATCH\"\n- }\n- ]\n- }\n+ \"type\": \"CreditCard\",\n+ \"amount\": 1500,\n+ \"vatAmount\": 0\n+ },\n+ {\n+ \"type\": \"Visa\",\n+ \"amount\": 1500,\n+ \"vatAmount\": 0\n+ },\n+ {\n+ \"type\": \"MasterCard\",\n+ \"amount\": 1500,\n+ \"vatAmount\": 0\n+ }\n+ ],\n+ \"description\": \"Test Purchase\",\n+ \"payerReference\": \"AB1234\",\n+ \"generatePaymentToken\": false,\n+ \"generateRecurrenceToken\": false,\n+ \"userAgent\": \"Mozilla/5.0...\",\n+ \"language\": \"sv-SE\",\n+ \"urls\": {\n+ \"hostUrls\": [\n+ \"https://example.com\"\n+ ],\n+ \"completeUrl\": \"https://example.com/payment-completed\",\n+ \"cancelUrl\": \"https://example.com/payment-canceled\",\n+ \"paymentUrl\": \"http://example.com/perform-payment\",\n+ \"callbackUrl\": \"https://example.com/payment-callback\",\n+ \"logoUrl\": \"https://example.com/payment-logo.png\",\n+ \"termsOfServiceUrl\": \"https://example.com/payment-terms.pdf\"\n+ },\n+ \"payeeInfo\": {\n+ \"payeeId\": \"12345678-1234-1234-1234-123456789012\",\n+ \"payeeReference\": \"CD1234\",\n+ \"payeeName\": \"Merchant1\",\n+ \"productCategory\": \"A123\",\n+ \"orderReference\": \"or123\",\n+ \"subsite\": \"MySubsite\"\n+ },\n+ \"metadata\": {\n+ \"key1\": \"value1\",\n+ \"key2\": 2,\n+ \"key3\": 3.1,\n+ \"key4\": false\n+ },\n+ \"cardholder\": {\n+ \"firstName\": \"firstname/companyname\",\n+ \"lastName\": \"lastname\",\n+ \"email\": \"[email protected]\",\n+ \"msisdn\": \"+4673900000\",\n+ \"homePhoneNumber\": \"homePhoneNumber\",\n+ \"workPhoneNumber\": \"workPhoneNumber\",\n+ \"shippingAddress\": {\n+ \"firstName\": \"Leia\",\n+ \"lastName\": \"Ahlstrom\",\n+ \"email\": \"[email protected]\",\n+ \"msisdn\": \"+46739000001\",\n+ \"streetAddress\": \"Helgestavรคgen 9\",\n+ \"coAddress\": \"coAddress\",\n+ \"city\": \"19792 Bro\",\n+ \"zipCode\": \"XXXXX\",\n+ \"countryCode\": \"countryCode\"\n+ },\n+ \"billingAddress\": {\n+ \"firstName\": \"firstname/companyname\",\n+ \"lastName\": \"lastname\",\n+ \"email\": \"email\",\n+ \"msisdn\": \"msisdn\",\n+ \"streetAddress\": \"streetAddress\",\n+ \"coAddress\": \"coAddress\",\n+ \"city\": \"city\",\n+ \"zipCode\": \"zipCode\",\n+ \"countryCode\": \"countrycode\"\n+ },\n+ \"accountInfo\": {\n+ \"accountAgeIndicator\": \"01\",\n+ \"accountChangeIndicator\": \"01\",\n+ \"accountPwdChangeIndicator\": \"01\",\n+ \"shippingAddressUsageIndicator\": \"01\",\n+ \"shippingNameIndicator\": \"01\",\n+ \"suspiciousAccountActivity\": \"01\",\n+ \"addressMatchIndicator\": false\n }\n- ]\n+ },\n+ \"riskIndicator\": {\n+ \"deliveryEmailAddress\": \"string\",\n+ \"deliveryTimeFrameindicator\": \"01\",\n+ \"preOrderDate\": \"YYYYMMDD\",\n+ \"preOrderPurchaseIndicator\": \"01\",\n+ \"shipIndicator\": \"01\",\n+ \"giftCardPurchase\": false,\n+ \"reOrderPurchaseIndicator\": \"01\",\n+ \"pickUpAddress\": {\n+ \"name\": \"companyname\",\n+ \"streetAddress\": \"streetAddress\",\n+ \"coAddress\": \"coAddress\",\n+ \"city\": \"city\",\n+ \"zipCode\": \"zipCode\",\n+ \"countryCode\": \"countrycode\"\n+ }\n+ }\n+ },\n+ \"creditCard\": {\n+ \"rejectCreditCards\": false,\n+ \"rejectDebitCards\": false,\n+ \"rejectConsumerCards\": false,\n+ \"rejectCorporateCards\": false,\n+ \"no3DSecure\": false,\n+ \"noCvc\": false\n }\n }\n ```\n \n-#### Create Authorization transaction\n+{:.table .table-striped}\n+| Required | Property | Type | Description |\n+| :------: | :--------------------------------------- | :------------ | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | `payment` | `object` | The payment object |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `operation` | `string` | Determines the initial operation, that defines the type invoice payment created.<br> <br> `Purchase`. Used to charge a card. It is followed up by a capture or cancel operation.<br> <br> `Recur`.Used to charge a card on a recurring basis. Is followed up by a capture or cancel operation (if not Autocapture is used, that is).<br> <br>`Verify`. Used when authorizing a card withouth reserveing any funds. It is followed up by a verification transaction. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `intent` | `string` | `Authorization`. Reserves the amount, and is followed by a [cancellation][cancel] or [capture][capture] of funds.<br> <br> `AutoCapture`. A one phase option that enable capture of funds automatically after authorization. |\n+| | โโ `paymentToken` | `string` | If you put in a paymentToken here, the payment page will preload the stored payment data related to the `paymentToken` and let the consumer make a purchase without having to enter all card data. This is called a \"One Click\" purchase. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `currency` | `string` | NOK, SEK, DKK, USD or EUR. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `prices` | `array` | The `prices` resource lists the prices related to a specific payment. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโโ `type` | `string` | Use the generic type CreditCard if you want to enable all card brands supported by merchant contract. Use card brands like Visa (for card type Visa), MasterCard (for card type Mastercard) and others if you want to specify different amount for each card brand. If you want to use more than one amount you must have one instance in the prices node for each card brand. You will not be allowed to both specify card brands and CreditCard at the same time in this field. [See the Prices resource and prices object types for more information][price-resource]. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโโ `amount` | `integer` | Amount is entered in the lowest monetary units of the selected currency. E.g. 10000 = 100.00 NOK, 5000 = 50.00 SEK. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโโ `vatAmount` | `integer` | If the amount given includes VAT, this may be displayed for the user in the payment page (redirect only). Set to 0 (zero) if this is not relevant. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `description` | `string(40)` | A textual description max 40 characters of the purchase. |\n+| | โโ `payerReference` | `string` | The reference to the payer (consumer/end user) from the merchant system. E.g mobile number, customer number etc. |\n+| | โโ `generatePaymentToken` | `boolean` | `true` or `false`. Set this to `true` if you want to create a paymentToken for future use as One Click. |\n+| | โโ `generateRecurrenceToken` | `boolean` | `true` or `false`. Set this to `true` if you want to create a recurrenceToken for future use Recurring purchases (subscription payments). |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `userAgent` | `string` | The user agent reference of the consumer's browser - [see user agent definition][user-agent-definition] |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `language` | `string` | `nb-NO`, `sv-SE` or `en-US`. |\n+| โ๏ธ | โโ `urls` | `object` | The object containing URLs relevant for the `payment`. |\n+| | โโโ `hostUrls` | `array` | The array of URLs valid for embedding of Swedbank Pay Hosted Views. If not supplied, view-operation will not be available. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโโ `completeUrl` | `string` | The URL that Swedbank Pay will redirect back to when the payment page is completed. |\n+| | โโโ `cancelUrl` | `string` | The URI to redirect the payer to if the payment is canceled. Only used in redirect scenarios. Can not be used simultaneously with `paymentUrl`; only `cancelUrl` or `paymentUrl` can be used, not both. |\n+| | โโโ `paymentUrl` | `string` | The URI that Swedbank Pay will redirect back to when the view-operation needs to be loaded, to inspect and act on the current status of the payment. Only used in Seamless Views. If both `cancelUrl` and `paymentUrl` is sent, the `paymentUrl` will used. |\n+| | โโโ `callbackUrl` | `string` | The URL that Swedbank Pay will perform an HTTP `POST` against every time a transaction is created on the payment. See [callback][callback] for details. |\n+| | โโโ `logoUrl` | `string` | The URL that will be used for showing the customer logo. Must be a picture with maximum 50px height and 400px width. Require https. |\n+| | โโโ `termsOfServiceUrl` | `string` | A URL that contains your terms and conditions for the payment, to be linked on the payment page. Require https. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโ `payeeInfo` | `string` | The `payeeInfo` object, containing information about the payee. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโโ `payeeId` | `string` | This is the unique id that identifies this payee (like merchant) set by Swedbank Pay. |\n+| โ๏ธ๏ธ๏ธ๏ธ๏ธ | โโโ `payeeReference` | `string(30*)` | A unique reference from the merchant system. It is set per operation to ensure an exactly-once delivery of a transactional operation. See [payeeReference][payee-reference] for details. |\n+| | โโโ `payeeName` | `string` | The payee name (like merchant name) that will be displayed to consumer when redirected to Swedbank Pay. |\n+| | โโโ `productCategory` | `string` | A product category or number sent in from the payee/merchant. This is not validated by Swedbank Pay, but will be passed through the payment process and may be used in the settlement process. |\n+| | โโโ `orderReference` | `String(50)` | The order reference should reflect the order reference found in the merchant's systems. |\n+| | โโโ `subsite` | `String(40)` | The subsite field can be used to perform [split settlement][split-settlement] on the payment. The subsites must be resolved with Swedbank Pay [reconciliation][settlement-and-reconciliation] before being used. |\n+| | โโ `metadata` | `object` | The keys and values that should be associated with the payment. Can be additional identifiers and data you want to associate with the payment. |\n+| | โโ `cardholder` | `object` | Optional. Cardholder object that can hold information about a buyer (private or company). The information added increases the chance for frictionless flow. |\n+| | โโโ `firstName` | `string` | Optional (increased chance for frictionless flow if set) If buyer is a company, use only firstName for companyName. |\n+| | โโโ `lastName` | `string` | Optional (increased chance for frictionless flow if set) If buyer is a company, use only firstName for companyName. |\n+| | โโโ `email` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `msisdn` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `homePhoneNumber` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `workPhoneNumber` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโ `shippingAddress` | `object` | | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `firstName` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `lastName` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `email` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `msisdn` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `streetAddress` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `coAddress` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `city` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `zipCode` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `countryCode` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโ `billingAddress` | `object` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `firstName` | `string` | Optional (increased chance for frictionless flow if set) If buyer is a company, use only firstName for companyName. |\n+| | โโโ `lastName` | `string` | Optional (increased chance for frictionless flow if set) If buyer is a company, use only firstName for companyName. |\n+| | โโโ `email` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `msisdn` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `streetAddress` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `coAddress` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `city` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `zipCode` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโโ `countryCode` | `string` | Optional (increased chance for frictionless flow if set) |\n+| | โโ `accountInfo` | `object` | Optional (increased chance for frictionless flow if set).<br> <br>If cardholder is known by merchant and have some kind of registered user then these fields can be set. |\n+| | โโโ `accountAgeIndicator` | `string` | Optional (increased chance for frictionless flow if set).<br> <br>Indicates the length of time that the payments account was enrolled in the cardholder's account with merchant.<br>01 (No account, guest)<br>02 (Created during transaction)<br>03 (Less than 30 days)<br>04 (30-60 days)<br>05 (More than 60 days) |\n+| | โโโ `accountChangeIndicator` | `string` | Optional (increased chance for frictionless flow if set).<br> <br>Length of time since the cardholder's account information with the merchant was changed. Including billing etc.<br>01 (Changed during transaction)<br>02 (Less than 30 days)<br>03 (30-60 days)<br>04 (More than 60 days) |\n+| | โโโ `accountPwdChangeIndicator` | `string` | Optional (increased chance for frictionless flow if set).<br> <br>Indicates the length of time since the cardholder's account with the merchant had a password change or account reset.<br>01 (No change)<br>02 (Changed during transaction)<br>03 (Less than 30 days)<br>04 (30-60 days)<br>05 (More than 60 days) |\n+| | โโโ `shippingAddressUsageIndicator` | `string` | Optional (increased chance for frictionless flow if set).<br> <br>Indicates when the shipping address used for this transaction was first used with the merchant.<br>01 (This transaction)<br>02 (Less than 30 days)<br>03 (30-60 days)<br>04 (More than 60 days) |\n+| | โโโ `shippingNameIndicator` | `string` | Optional (increased chance for frictionless flow if set).<br> <br>Indicates if the Cardholder Name on the account is identical to the shipping Name used for this transaction.<br>01 (Account name identical to shipping name)<br>02 (Account name different than shipping name)<br> |\n+| | โโโ `suspiciousAccountActivity` | `string` | Optional (increased chance for frictionless flow if set).<br> <br>Indicates whether merchant has experienced suspicious activity (including previous fraud) on the cardholder account.<br>01 (No suspicious activity has been observed)<br>02 (Suspicious activity has been observed)<br> |\n+| | โโโ `addressMatchIndicator` | `boolean` | Optional (increased chance for frictionless flow if set)<br> <br> Allows the 3-D Secure Requestor to indicate to the ACS whether the cardholderโs billing and shipping address are the same. |\n+| | โโ `riskIndicator` | `array` | This **optional** array consist of information that helps verifying the payer. Providing these fields decreases the likelyhood of having to promt for 3-D Secure authenticaiton of the payer when they are authenticating the purchacse. |\n+| | โโโ `deliveryEmailAddress` | `string` | Optional (increased chance for frictionless flow if set).<br> <br> For electronic delivery, the email address to which the merchandise was delivered. |\n+| | โโโ `deliveryTimeFrameIndicator` | `string` | Optional (increased chance for frictionless flow if set).<br> <br> Indicates the merchandise delivery timeframe.<br>01 (Electronic Delivery)<br>02 (Same day shipping)<br>03 (Overnight shipping)<br>04 (Two-day or more shipping)<br> |\n+| | โโโ `preOrderDate` | `string` | Optional (increased chance for frictionless flow if set).<br> <br>For a pre-ordered purchase. The expected date that the merchandise will be available.<br>FORMAT: \"YYYYMMDD\" |\n+| | โโโ `preOrderPurchaseIndicator` | `string` | Optional (increased chance for frictionless flow if set).<br> <br> Indicates whether Cardholder is placing an order for merchandise with a future availability or release date.<br>01 (Merchandise available)<br>02 (Future availability) |\n+| | โโโ `shipIndicator` | `string` | Optional (increased chance for frictionless flow if set).<br> <br>Indicates shipping method chosen for the transaction.<br> 01 (Ship to cardholder's billing address)<br>02 (Ship to another verified address on file with merchant)<br>03 (Ship to address that is different than cardholder's billing address)<br>04 (Ship to Store / Pick-up at local store. Store address shall be populated in shipping address fields)<br>05 (Digital goods, includes online services, electronic giftcards and redemption codes)<br>06 (Travel and Event tickets, not shipped)<br>07 (Other, e.g. gaming, digital service) |\n+| | โโโ `giftCardPurchase` | `boolean` | Optional (increased chance for frictionless flow if set).<br> <br>`true` if this is a purchase of a gift card. |\n+| | โโโ `reOrderPurchaseIndicator` | `string` | Optional (increased chance for frictionless flow if set).<br> <br>Indicates whether Cardholder is placing an order for merchandise with a future availability or release date.<br>01 (Merchandise available)<br>02 (Future availability) |\n+| | โโ `pickUpAddress` | `object` | If shipIndicator set to 4, then prefil this. |\n+| | โโโ `name` | `string` | If shipIndicator set to 4, then prefil this. |\n+| | โโโ `streetAddress` | `string` | If shipIndicator set to 4, then prefil this. |\n+| | โโโ `coAddress` | `string` | If shipIndicator set to 4, then prefil this. |\n+| | โโโ `city` | `string` | If shipIndicator set to 4, then pr","path":"payments/invoice/other-features.md","position":null,"original_position":361,"commit_id":"e95dd782976a6f05083a4be2f8a73df50d639958","original_commit_id":"a2b2afb6bb862961dd8307ba3fdf9f1b5a956453","user":{"login":"marinafrydenb","id":57999680,"node_id":"MDQ6VXNlcjU3OTk5Njgw","avatar_url":"https://avatars2.githubusercontent.com/u/57999680?v=4","gravatar_id":"","url":"https://api.github.com/users/marinafrydenb","html_url":"https://github.com/marinafrydenb","followers_url":"https://api.github.com/users/marinafrydenb/followers","following_url":"https://api.github.com/users/marinafrydenb/following{/other_user}","gists_url":"https://api.github.com/users/marinafrydenb/gists{/gist_id}","starred_url":"https://api.github.com/users/marinafrydenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marinafrydenb/subscriptions","organizations_url":"https://api.github.com/users/marinafrydenb/orgs","repos_url":"https://api.github.com/users/marinafrydenb/repos","events_url":"https://api.github.com/users/marinafrydenb/events{/privacy}","received_events_url":"https://api.github.com/users/marinafrydenb/received_events","type":"User","site_admin":false},"body":"Not sure if this field is necessary as we dont use card?\r\n\r\n","created_at":"2019-12-10T09:15:53Z","updated_at":"2019-12-10T09:22:09Z","html_url":"https://github.com/SwedbankPay/developer.swedbankpay.com/pull/86#discussion_r355919437","pull_request_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/86","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/comments/355919437"},"html":{"href":"https://github.com/SwedbankPay/developer.swedbankpay.com/pull/86#discussion_r355919437"},"pull_request":{"href":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/86","id":351248365,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxMjQ4MzY1","html_url":"https://github.com/SwedbankPay/developer.swedbankpay.com/pull/86","diff_url":"https://github.com/SwedbankPay/developer.swedbankpay.com/pull/86.diff","patch_url":"https://github.com/SwedbankPay/developer.swedbankpay.com/pull/86.patch","issue_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues/86","number":86,"state":"open","locked":false,"title":"Feature/dx 455 invoice other features","user":{"login":"NullableInt","id":42067409,"node_id":"MDQ6VXNlcjQyMDY3NDA5","avatar_url":"https://avatars3.githubusercontent.com/u/42067409?v=4","gravatar_id":"","url":"https://api.github.com/users/NullableInt","html_url":"https://github.com/NullableInt","followers_url":"https://api.github.com/users/NullableInt/followers","following_url":"https://api.github.com/users/NullableInt/following{/other_user}","gists_url":"https://api.github.com/users/NullableInt/gists{/gist_id}","starred_url":"https://api.github.com/users/NullableInt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NullableInt/subscriptions","organizations_url":"https://api.github.com/users/NullableInt/orgs","repos_url":"https://api.github.com/users/NullableInt/repos","events_url":"https://api.github.com/users/NullableInt/events{/privacy}","received_events_url":"https://api.github.com/users/NullableInt/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-10T07:50:15Z","updated_at":"2019-12-10T09:22:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93855e8994245d5cb7d15232e6f81c590bd82340","assignee":null,"assignees":[],"requested_reviewers":[{"login":"arebra","id":43410587,"node_id":"MDQ6VXNlcjQzNDEwNTg3","avatar_url":"https://avatars1.githubusercontent.com/u/43410587?v=4","gravatar_id":"","url":"https://api.github.com/users/arebra","html_url":"https://github.com/arebra","followers_url":"https://api.github.com/users/arebra/followers","following_url":"https://api.github.com/users/arebra/following{/other_user}","gists_url":"https://api.github.com/users/arebra/gists{/gist_id}","starred_url":"https://api.github.com/users/arebra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arebra/subscriptions","organizations_url":"https://api.github.com/users/arebra/orgs","repos_url":"https://api.github.com/users/arebra/repos","events_url":"https://api.github.com/users/arebra/events{/privacy}","received_events_url":"https://api.github.com/users/arebra/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/86/commits","review_comments_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/86/comments","review_comment_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues/86/comments","statuses_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/statuses/e95dd782976a6f05083a4be2f8a73df50d639958","head":{"label":"SwedbankPay:feature/dx-455_invoice_other_features","ref":"feature/dx-455_invoice_other_features","sha":"e95dd782976a6f05083a4be2f8a73df50d639958","user":{"login":"SwedbankPay","id":49415666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDE1NjY2","avatar_url":"https://avatars0.githubusercontent.com/u/49415666?v=4","gravatar_id":"","url":"https://api.github.com/users/SwedbankPay","html_url":"https://github.com/SwedbankPay","followers_url":"https://api.github.com/users/SwedbankPay/followers","following_url":"https://api.github.com/users/SwedbankPay/following{/other_user}","gists_url":"https://api.github.com/users/SwedbankPay/gists{/gist_id}","starred_url":"https://api.github.com/users/SwedbankPay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwedbankPay/subscriptions","organizations_url":"https://api.github.com/users/SwedbankPay/orgs","repos_url":"https://api.github.com/users/SwedbankPay/repos","events_url":"https://api.github.com/users/SwedbankPay/events{/privacy}","received_events_url":"https://api.github.com/users/SwedbankPay/received_events","type":"Organization","site_admin":false},"repo":{"id":210605116,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA2MDUxMTY=","name":"developer.swedbankpay.com","full_name":"SwedbankPay/developer.swedbankpay.com","private":false,"owner":{"login":"SwedbankPay","id":49415666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDE1NjY2","avatar_url":"https://avatars0.githubusercontent.com/u/49415666?v=4","gravatar_id":"","url":"https://api.github.com/users/SwedbankPay","html_url":"https://github.com/SwedbankPay","followers_url":"https://api.github.com/users/SwedbankPay/followers","following_url":"https://api.github.com/users/SwedbankPay/following{/other_user}","gists_url":"https://api.github.com/users/SwedbankPay/gists{/gist_id}","starred_url":"https://api.github.com/users/SwedbankPay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwedbankPay/subscriptions","organizations_url":"https://api.github.com/users/SwedbankPay/orgs","repos_url":"https://api.github.com/users/SwedbankPay/repos","events_url":"https://api.github.com/users/SwedbankPay/events{/privacy}","received_events_url":"https://api.github.com/users/SwedbankPay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SwedbankPay/developer.swedbankpay.com","description":"Swedbank Pay Developer Portal","fork":false,"url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com","forks_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/forks","keys_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/teams","hooks_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/hooks","issue_events_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues/events{/number}","events_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/events","assignees_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/assignees{/user}","branches_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/branches{/branch}","tags_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/tags","blobs_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/statuses/{sha}","languages_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/languages","stargazers_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/stargazers","contributors_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/contributors","subscribers_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/subscribers","subscription_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/subscription","commits_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/contents/{+path}","compare_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/merges","archive_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/downloads","issues_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues{/number}","pulls_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls{/number}","milestones_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/milestones{/number}","notifications_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/labels{/name}","releases_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/releases{/id}","deployments_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/deployments","created_at":"2019-09-24T13:05:36Z","updated_at":"2019-12-06T15:17:39Z","pushed_at":"2019-12-10T09:13:49Z","git_url":"git://github.com/SwedbankPay/developer.swedbankpay.com.git","ssh_url":"[email protected]:SwedbankPay/developer.swedbankpay.com.git","clone_url":"https://github.com/SwedbankPay/developer.swedbankpay.com.git","svn_url":"https://github.com/SwedbankPay/developer.swedbankpay.com","homepage":"https://developer.swedbankpay.com/","size":86910,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"SwedbankPay:develop","ref":"develop","sha":"3f3458e7d9270d9c2f8eb44e4bc895da8ec75c3a","user":{"login":"SwedbankPay","id":49415666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDE1NjY2","avatar_url":"https://avatars0.githubusercontent.com/u/49415666?v=4","gravatar_id":"","url":"https://api.github.com/users/SwedbankPay","html_url":"https://github.com/SwedbankPay","followers_url":"https://api.github.com/users/SwedbankPay/followers","following_url":"https://api.github.com/users/SwedbankPay/following{/other_user}","gists_url":"https://api.github.com/users/SwedbankPay/gists{/gist_id}","starred_url":"https://api.github.com/users/SwedbankPay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwedbankPay/subscriptions","organizations_url":"https://api.github.com/users/SwedbankPay/orgs","repos_url":"https://api.github.com/users/SwedbankPay/repos","events_url":"https://api.github.com/users/SwedbankPay/events{/privacy}","received_events_url":"https://api.github.com/users/SwedbankPay/received_events","type":"Organization","site_admin":false},"repo":{"id":210605116,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA2MDUxMTY=","name":"developer.swedbankpay.com","full_name":"SwedbankPay/developer.swedbankpay.com","private":false,"owner":{"login":"SwedbankPay","id":49415666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDE1NjY2","avatar_url":"https://avatars0.githubusercontent.com/u/49415666?v=4","gravatar_id":"","url":"https://api.github.com/users/SwedbankPay","html_url":"https://github.com/SwedbankPay","followers_url":"https://api.github.com/users/SwedbankPay/followers","following_url":"https://api.github.com/users/SwedbankPay/following{/other_user}","gists_url":"https://api.github.com/users/SwedbankPay/gists{/gist_id}","starred_url":"https://api.github.com/users/SwedbankPay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwedbankPay/subscriptions","organizations_url":"https://api.github.com/users/SwedbankPay/orgs","repos_url":"https://api.github.com/users/SwedbankPay/repos","events_url":"https://api.github.com/users/SwedbankPay/events{/privacy}","received_events_url":"https://api.github.com/users/SwedbankPay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SwedbankPay/developer.swedbankpay.com","description":"Swedbank Pay Developer Portal","fork":false,"url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com","forks_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/forks","keys_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/teams","hooks_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/hooks","issue_events_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues/events{/number}","events_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/events","assignees_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/assignees{/user}","branches_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/branches{/branch}","tags_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/tags","blobs_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/statuses/{sha}","languages_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/languages","stargazers_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/stargazers","contributors_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/contributors","subscribers_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/subscribers","subscription_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/subscription","commits_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/contents/{+path}","compare_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/merges","archive_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/downloads","issues_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues{/number}","pulls_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls{/number}","milestones_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/milestones{/number}","notifications_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/labels{/name}","releases_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/releases{/id}","deployments_url":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/deployments","created_at":"2019-09-24T13:05:36Z","updated_at":"2019-12-06T15:17:39Z","pushed_at":"2019-12-10T09:13:49Z","git_url":"git://github.com/SwedbankPay/developer.swedbankpay.com.git","ssh_url":"[email protected]:SwedbankPay/developer.swedbankpay.com.git","clone_url":"https://github.com/SwedbankPay/developer.swedbankpay.com.git","svn_url":"https://github.com/SwedbankPay/developer.swedbankpay.com","homepage":"https://developer.swedbankpay.com/","size":86910,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/86"},"html":{"href":"https://github.com/SwedbankPay/developer.swedbankpay.com/pull/86"},"issue":{"href":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues/86"},"comments":{"href":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com/statuses/e95dd782976a6f05083a4be2f8a73df50d639958"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 210605116,
"name": "SwedbankPay/developer.swedbankpay.com",
"url": "https://api.github.com/repos/SwedbankPay/developer.swedbankpay.com"
}
|
{
"id": 57999680,
"login": "marinafrydenb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/57999680?",
"url": "https://api.github.com/users/marinafrydenb"
}
|
{
"id": 49415666,
"login": "SwedbankPay",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49415666?",
"url": "https://api.github.com/orgs/SwedbankPay"
}
| 2019-12-10T09:15:53 |
11052418158
|
{"actor":{"display_login":"marinafrydenb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/fremtind/jokul/pulls/comments/365287081","pull_request_review_id":341234766,"id":365287081,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTI4NzA4MQ==","diff_hunk":"@@ -1,24 +1,53 @@\n import React from \"react\";\n import { cleanup, render } from \"@testing-library/react\";\n-import { H1, H2, H3, H4, LeadParagraph, P, SmallParagraph, TinyParagraph } from \".\";\n+import { H1, H2, H3, H4, H5, Lead, Body, Small, Micro } from \".\";\n \n describe(\"typography\", () => {\n afterEach(cleanup);\n const text = \"Hello Mr Universe\";\n \n- [H1, H2, H3, H4, LeadParagraph, P, SmallParagraph, TinyParagraph].forEach((element) => {\n- test(`should not explode`, () => {\n- const C = element;\n+ const elements = [\n+ { type: \"heading 1\", component: H1, expectedClassName: \"jkl-h1\" },\n+ { type: \"heading 2\", component: H2, expectedClassName: \"jkl-h2\" },\n+ { type: \"heading 3\", component: H3, expectedClassName: \"jkl-h3\" },\n+ { type: \"heading 4\", component: H4, expectedClassName: \"jkl-h4\" },\n+ { type: \"heading 5\", component: H5, expectedClassName: \"jkl-h5\" },\n+ { type: \"lead paragraph\", component: Lead, expectedClassName: \"jkl-lead\" },\n+ { type: \"body paragraph\", component: Body, expectedClassName: \"jkl-body\" },\n+ { type: \"small paragraph\", component: Small, expectedClassName: \"jkl-small\" },\n+ { type: \"micro paragraph\", component: Micro, expectedClassName: \"jkl-micro\" },\n+ ];\n+\n+ elements.forEach((element) => {\n+ test(`should render ${element.type} with correct text`, () => {\n+ const C = element.component;\n const { getByText } = render(<C>{text}</C>);\n- getByText(text);\n+ const res = getByText(text);\n+ expect(res).toHaveClass(element.expectedClassName);\n });\n });\n \n- [H1, H2, H3, H4].forEach((element) => {\n- test(`should not explode`, () => {\n- const C = element;\n- const { getByText } = render(<C styledAs=\"h1\">{text}</C>);\n- getByText(text);\n+ type styleElement = {\n+ element: \"h1\" | \"h2\" | \"h3\" | \"h4\" | \"h5\";\n+ expectedClassName: string;\n+ };\n+\n+ const styleElements: styleElement[] = [\n+ { element: \"h1\", expectedClassName: \"jkl-h1\" },\n+ { element: \"h2\", expectedClassName: \"jkl-h2\" },\n+ { element: \"h3\", expectedClassName: \"jkl-h3\" },\n+ { element: \"h4\", expectedClassName: \"jkl-h4\" },\n+ { element: \"h5\", expectedClassName: \"jkl-h5\" },\n+ ];\n+\n+ elements.slice(0, 5).forEach((element) => {","path":"packages/typography-react/src/Typography.test.tsx","position":53,"original_position":53,"commit_id":"710aab47f73831af1f7c7a3c35a622f9b965911b","original_commit_id":"710aab47f73831af1f7c7a3c35a622f9b965911b","user":{"login":"lfbergee","id":46530368,"node_id":"MDQ6VXNlcjQ2NTMwMzY4","avatar_url":"https://avatars0.githubusercontent.com/u/46530368?v=4","gravatar_id":"","url":"https://api.github.com/users/lfbergee","html_url":"https://github.com/lfbergee","followers_url":"https://api.github.com/users/lfbergee/followers","following_url":"https://api.github.com/users/lfbergee/following{/other_user}","gists_url":"https://api.github.com/users/lfbergee/gists{/gist_id}","starred_url":"https://api.github.com/users/lfbergee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfbergee/subscriptions","organizations_url":"https://api.github.com/users/lfbergee/orgs","repos_url":"https://api.github.com/users/lfbergee/repos","events_url":"https://api.github.com/users/lfbergee/events{/privacy}","received_events_url":"https://api.github.com/users/lfbergee/received_events","type":"User","site_admin":false},"body":"Syns denne blir litt magisk og arbirtรฆr. Foreslรฅr:\r\n\r\n```\r\n const headings = [\r\n { type: \"heading 1\", component: H1, expectedClassName: \"jkl-h1\" },\r\n { type: \"heading 2\", component: H2, expectedClassName: \"jkl-h2\" },\r\n { type: \"heading 3\", component: H3, expectedClassName: \"jkl-h3\" },\r\n { type: \"heading 4\", component: H4, expectedClassName: \"jkl-h4\" },\r\n { type: \"heading 5\", component: H5, expectedClassName: \"jkl-h5\" },\r\n ];\r\n\r\nconst paragraphs = [\r\n { type: \"lead paragraph\", component: Lead, expectedClassName: \"jkl-lead\" },\r\n { type: \"body paragraph\", component: Body, expectedClassName: \"jkl-body\" },\r\n { type: \"small paragraph\", component: Small, expectedClassName: \"jkl-small\" },\r\n { type: \"micro paragraph\", component: Micro, expectedClassName: \"jkl-micro\" },\r\n]\r\n\r\n[...headings, ...paragraphs].forEach((element) => {....\r\n\r\nheadings.forEach((element) => {....\r\n\r\n```","created_at":"2020-01-10T15:26:22Z","updated_at":"2020-01-10T15:26:23Z","html_url":"https://github.com/fremtind/jokul/pull/641#discussion_r365287081","pull_request_url":"https://api.github.com/repos/fremtind/jokul/pulls/641","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fremtind/jokul/pulls/comments/365287081"},"html":{"href":"https://github.com/fremtind/jokul/pull/641#discussion_r365287081"},"pull_request":{"href":"https://api.github.com/repos/fremtind/jokul/pulls/641"}}},"pull_request":{"url":"https://api.github.com/repos/fremtind/jokul/pulls/641","id":360436811,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYwNDM2ODEx","html_url":"https://github.com/fremtind/jokul/pull/641","diff_url":"https://github.com/fremtind/jokul/pull/641.diff","patch_url":"https://github.com/fremtind/jokul/pull/641.patch","issue_url":"https://api.github.com/repos/fremtind/jokul/issues/641","number":641,"state":"open","locked":false,"title":"Typography naming, fix inconsistent naming of variables","user":{"login":"vegardsoerlie","id":14551408,"node_id":"MDQ6VXNlcjE0NTUxNDA4","avatar_url":"https://avatars2.githubusercontent.com/u/14551408?v=4","gravatar_id":"","url":"https://api.github.com/users/vegardsoerlie","html_url":"https://github.com/vegardsoerlie","followers_url":"https://api.github.com/users/vegardsoerlie/followers","following_url":"https://api.github.com/users/vegardsoerlie/following{/other_user}","gists_url":"https://api.github.com/users/vegardsoerlie/gists{/gist_id}","starred_url":"https://api.github.com/users/vegardsoerlie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vegardsoerlie/subscriptions","organizations_url":"https://api.github.com/users/vegardsoerlie/orgs","repos_url":"https://api.github.com/users/vegardsoerlie/repos","events_url":"https://api.github.com/users/vegardsoerlie/events{/privacy}","received_events_url":"https://api.github.com/users/vegardsoerlie/received_events","type":"User","site_admin":false},"body":"## ๐ฅ Proposed changes\r\n\r\ncloses #592 \r\n\r\nUnify typography naming in mixins, classes, components and figma.\r\n\r\n\r\nFigma | Code (core: mixins) | Code (core: css classes) | Code (typography-react)\r\n-- | -- | -- | --\r\nh1 | h1-heading | jkl-h1 | H1\r\nh2 | h2-heading | jkl-h2 | H2\r\nh3 | h3-heading | jkl-h3 | H3\r\nh4 | h4-heading | jkl-h4 | H4\r\nh5 | h5-heading | jkl-h5 | H5\r\nlead | lead-paragraph | jkl-lead | Lead\r\nbody | body-paragraph | jkl-body | Body\r\nsmall | small-paragraph | jkl-small | Small\r\nmicro | micro-paragraph | jkl-micro | Micro\r\n\r\n\r\n\r\n## โ๏ธ Submission checklist\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/fremtind/jokul/blob/master/CONTRIBUTING.md) doc\r\n- [x] `yarn build` works locally with my changes\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [x] I have added necessary documentation (if appropriate)\r\n\r\n## ๐ฌ Further comments\r\n\r\nBreaking change pรฅ `feat: unify naming[...]` som omfatter `core` og `typography-react`. Ogsรฅ en ny commit pรฅ resten som oppdateres for รฅ fรธlge etter breaking changes. Er det riktig struktur pรฅ commit? Vil det funke i bruk? @lfbergee \r\n","created_at":"2020-01-08T12:36:05Z","updated_at":"2020-01-10T15:26:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f05b5957a67d34153640d2224965922ac4c4b8bd","assignee":{"login":"vegardsoerlie","id":14551408,"node_id":"MDQ6VXNlcjE0NTUxNDA4","avatar_url":"https://avatars2.githubusercontent.com/u/14551408?v=4","gravatar_id":"","url":"https://api.github.com/users/vegardsoerlie","html_url":"https://github.com/vegardsoerlie","followers_url":"https://api.github.com/users/vegardsoerlie/followers","following_url":"https://api.github.com/users/vegardsoerlie/following{/other_user}","gists_url":"https://api.github.com/users/vegardsoerlie/gists{/gist_id}","starred_url":"https://api.github.com/users/vegardsoerlie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vegardsoerlie/subscriptions","organizations_url":"https://api.github.com/users/vegardsoerlie/orgs","repos_url":"https://api.github.com/users/vegardsoerlie/repos","events_url":"https://api.github.com/users/vegardsoerlie/events{/privacy}","received_events_url":"https://api.github.com/users/vegardsoerlie/received_events","type":"User","site_admin":false},"assignees":[{"login":"vegardsoerlie","id":14551408,"node_id":"MDQ6VXNlcjE0NTUxNDA4","avatar_url":"https://avatars2.githubusercontent.com/u/14551408?v=4","gravatar_id":"","url":"https://api.github.com/users/vegardsoerlie","html_url":"https://github.com/vegardsoerlie","followers_url":"https://api.github.com/users/vegardsoerlie/followers","following_url":"https://api.github.com/users/vegardsoerlie/following{/other_user}","gists_url":"https://api.github.com/users/vegardsoerlie/gists{/gist_id}","starred_url":"https://api.github.com/users/vegardsoerlie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vegardsoerlie/subscriptions","organizations_url":"https://api.github.com/users/vegardsoerlie/orgs","repos_url":"https://api.github.com/users/vegardsoerlie/repos","events_url":"https://api.github.com/users/vegardsoerlie/events{/privacy}","received_events_url":"https://api.github.com/users/vegardsoerlie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1406182713,"node_id":"MDU6TGFiZWwxNDA2MTgyNzEz","url":"https://api.github.com/repos/fremtind/jokul/labels/%F0%9F%93%9A%20documentation","name":"๐ documentation","color":"0075ca","default":false,"description":"Improvements or additions to documentation"}],"milestone":null,"commits_url":"https://api.github.com/repos/fremtind/jokul/pulls/641/commits","review_comments_url":"https://api.github.com/repos/fremtind/jokul/pulls/641/comments","review_comment_url":"https://api.github.com/repos/fremtind/jokul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fremtind/jokul/issues/641/comments","statuses_url":"https://api.github.com/repos/fremtind/jokul/statuses/710aab47f73831af1f7c7a3c35a622f9b965911b","head":{"label":"fremtind:typography-naming","ref":"typography-naming","sha":"710aab47f73831af1f7c7a3c35a622f9b965911b","user":{"login":"fremtind","id":49439893,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDM5ODkz","avatar_url":"https://avatars1.githubusercontent.com/u/49439893?v=4","gravatar_id":"","url":"https://api.github.com/users/fremtind","html_url":"https://github.com/fremtind","followers_url":"https://api.github.com/users/fremtind/followers","following_url":"https://api.github.com/users/fremtind/following{/other_user}","gists_url":"https://api.github.com/users/fremtind/gists{/gist_id}","starred_url":"https://api.github.com/users/fremtind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fremtind/subscriptions","organizations_url":"https://api.github.com/users/fremtind/orgs","repos_url":"https://api.github.com/users/fremtind/repos","events_url":"https://api.github.com/users/fremtind/events{/privacy}","received_events_url":"https://api.github.com/users/fremtind/received_events","type":"Organization","site_admin":false},"repo":{"id":191932224,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE5MzIyMjQ=","name":"jokul","full_name":"fremtind/jokul","private":false,"owner":{"login":"fremtind","id":49439893,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDM5ODkz","avatar_url":"https://avatars1.githubusercontent.com/u/49439893?v=4","gravatar_id":"","url":"https://api.github.com/users/fremtind","html_url":"https://github.com/fremtind","followers_url":"https://api.github.com/users/fremtind/followers","following_url":"https://api.github.com/users/fremtind/following{/other_user}","gists_url":"https://api.github.com/users/fremtind/gists{/gist_id}","starred_url":"https://api.github.com/users/fremtind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fremtind/subscriptions","organizations_url":"https://api.github.com/users/fremtind/orgs","repos_url":"https://api.github.com/users/fremtind/repos","events_url":"https://api.github.com/users/fremtind/events{/privacy}","received_events_url":"https://api.github.com/users/fremtind/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fremtind/jokul","description":"Jรธkul er et designsystem utviklet av Fremtind.","fork":false,"url":"https://api.github.com/repos/fremtind/jokul","forks_url":"https://api.github.com/repos/fremtind/jokul/forks","keys_url":"https://api.github.com/repos/fremtind/jokul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fremtind/jokul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fremtind/jokul/teams","hooks_url":"https://api.github.com/repos/fremtind/jokul/hooks","issue_events_url":"https://api.github.com/repos/fremtind/jokul/issues/events{/number}","events_url":"https://api.github.com/repos/fremtind/jokul/events","assignees_url":"https://api.github.com/repos/fremtind/jokul/assignees{/user}","branches_url":"https://api.github.com/repos/fremtind/jokul/branches{/branch}","tags_url":"https://api.github.com/repos/fremtind/jokul/tags","blobs_url":"https://api.github.com/repos/fremtind/jokul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fremtind/jokul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fremtind/jokul/git/refs{/sha}","trees_url":"https://api.github.com/repos/fremtind/jokul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fremtind/jokul/statuses/{sha}","languages_url":"https://api.github.com/repos/fremtind/jokul/languages","stargazers_url":"https://api.github.com/repos/fremtind/jokul/stargazers","contributors_url":"https://api.github.com/repos/fremtind/jokul/contributors","subscribers_url":"https://api.github.com/repos/fremtind/jokul/subscribers","subscription_url":"https://api.github.com/repos/fremtind/jokul/subscription","commits_url":"https://api.github.com/repos/fremtind/jokul/commits{/sha}","git_commits_url":"https://api.github.com/repos/fremtind/jokul/git/commits{/sha}","comments_url":"https://api.github.com/repos/fremtind/jokul/comments{/number}","issue_comment_url":"https://api.github.com/repos/fremtind/jokul/issues/comments{/number}","contents_url":"https://api.github.com/repos/fremtind/jokul/contents/{+path}","compare_url":"https://api.github.com/repos/fremtind/jokul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fremtind/jokul/merges","archive_url":"https://api.github.com/repos/fremtind/jokul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fremtind/jokul/downloads","issues_url":"https://api.github.com/repos/fremtind/jokul/issues{/number}","pulls_url":"https://api.github.com/repos/fremtind/jokul/pulls{/number}","milestones_url":"https://api.github.com/repos/fremtind/jokul/milestones{/number}","notifications_url":"https://api.github.com/repos/fremtind/jokul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fremtind/jokul/labels{/name}","releases_url":"https://api.github.com/repos/fremtind/jokul/releases{/id}","deployments_url":"https://api.github.com/repos/fremtind/jokul/deployments","created_at":"2019-06-14T11:31:00Z","updated_at":"2020-01-10T11:21:39Z","pushed_at":"2020-01-10T14:53:36Z","git_url":"git://github.com/fremtind/jokul.git","ssh_url":"[email protected]:fremtind/jokul.git","clone_url":"https://github.com/fremtind/jokul.git","svn_url":"https://github.com/fremtind/jokul","homepage":"https://fremtind.github.io/jokul","size":14931,"stargazers_count":12,"watchers_count":12,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":40,"watchers":12,"default_branch":"master"}},"base":{"label":"fremtind:master","ref":"master","sha":"c66d8ecfc8dc46715524226dc6c0e0b40a1dfc8b","user":{"login":"fremtind","id":49439893,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDM5ODkz","avatar_url":"https://avatars1.githubusercontent.com/u/49439893?v=4","gravatar_id":"","url":"https://api.github.com/users/fremtind","html_url":"https://github.com/fremtind","followers_url":"https://api.github.com/users/fremtind/followers","following_url":"https://api.github.com/users/fremtind/following{/other_user}","gists_url":"https://api.github.com/users/fremtind/gists{/gist_id}","starred_url":"https://api.github.com/users/fremtind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fremtind/subscriptions","organizations_url":"https://api.github.com/users/fremtind/orgs","repos_url":"https://api.github.com/users/fremtind/repos","events_url":"https://api.github.com/users/fremtind/events{/privacy}","received_events_url":"https://api.github.com/users/fremtind/received_events","type":"Organization","site_admin":false},"repo":{"id":191932224,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE5MzIyMjQ=","name":"jokul","full_name":"fremtind/jokul","private":false,"owner":{"login":"fremtind","id":49439893,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NDM5ODkz","avatar_url":"https://avatars1.githubusercontent.com/u/49439893?v=4","gravatar_id":"","url":"https://api.github.com/users/fremtind","html_url":"https://github.com/fremtind","followers_url":"https://api.github.com/users/fremtind/followers","following_url":"https://api.github.com/users/fremtind/following{/other_user}","gists_url":"https://api.github.com/users/fremtind/gists{/gist_id}","starred_url":"https://api.github.com/users/fremtind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fremtind/subscriptions","organizations_url":"https://api.github.com/users/fremtind/orgs","repos_url":"https://api.github.com/users/fremtind/repos","events_url":"https://api.github.com/users/fremtind/events{/privacy}","received_events_url":"https://api.github.com/users/fremtind/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fremtind/jokul","description":"Jรธkul er et designsystem utviklet av Fremtind.","fork":false,"url":"https://api.github.com/repos/fremtind/jokul","forks_url":"https://api.github.com/repos/fremtind/jokul/forks","keys_url":"https://api.github.com/repos/fremtind/jokul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fremtind/jokul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fremtind/jokul/teams","hooks_url":"https://api.github.com/repos/fremtind/jokul/hooks","issue_events_url":"https://api.github.com/repos/fremtind/jokul/issues/events{/number}","events_url":"https://api.github.com/repos/fremtind/jokul/events","assignees_url":"https://api.github.com/repos/fremtind/jokul/assignees{/user}","branches_url":"https://api.github.com/repos/fremtind/jokul/branches{/branch}","tags_url":"https://api.github.com/repos/fremtind/jokul/tags","blobs_url":"https://api.github.com/repos/fremtind/jokul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fremtind/jokul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fremtind/jokul/git/refs{/sha}","trees_url":"https://api.github.com/repos/fremtind/jokul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fremtind/jokul/statuses/{sha}","languages_url":"https://api.github.com/repos/fremtind/jokul/languages","stargazers_url":"https://api.github.com/repos/fremtind/jokul/stargazers","contributors_url":"https://api.github.com/repos/fremtind/jokul/contributors","subscribers_url":"https://api.github.com/repos/fremtind/jokul/subscribers","subscription_url":"https://api.github.com/repos/fremtind/jokul/subscription","commits_url":"https://api.github.com/repos/fremtind/jokul/commits{/sha}","git_commits_url":"https://api.github.com/repos/fremtind/jokul/git/commits{/sha}","comments_url":"https://api.github.com/repos/fremtind/jokul/comments{/number}","issue_comment_url":"https://api.github.com/repos/fremtind/jokul/issues/comments{/number}","contents_url":"https://api.github.com/repos/fremtind/jokul/contents/{+path}","compare_url":"https://api.github.com/repos/fremtind/jokul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fremtind/jokul/merges","archive_url":"https://api.github.com/repos/fremtind/jokul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fremtind/jokul/downloads","issues_url":"https://api.github.com/repos/fremtind/jokul/issues{/number}","pulls_url":"https://api.github.com/repos/fremtind/jokul/pulls{/number}","milestones_url":"https://api.github.com/repos/fremtind/jokul/milestones{/number}","notifications_url":"https://api.github.com/repos/fremtind/jokul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fremtind/jokul/labels{/name}","releases_url":"https://api.github.com/repos/fremtind/jokul/releases{/id}","deployments_url":"https://api.github.com/repos/fremtind/jokul/deployments","created_at":"2019-06-14T11:31:00Z","updated_at":"2020-01-10T11:21:39Z","pushed_at":"2020-01-10T14:53:36Z","git_url":"git://github.com/fremtind/jokul.git","ssh_url":"[email protected]:fremtind/jokul.git","clone_url":"https://github.com/fremtind/jokul.git","svn_url":"https://github.com/fremtind/jokul","homepage":"https://fremtind.github.io/jokul","size":14931,"stargazers_count":12,"watchers_count":12,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":40,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fremtind/jokul/pulls/641"},"html":{"href":"https://github.com/fremtind/jokul/pull/641"},"issue":{"href":"https://api.github.com/repos/fremtind/jokul/issues/641"},"comments":{"href":"https://api.github.com/repos/fremtind/jokul/issues/641/comments"},"review_comments":{"href":"https://api.github.com/repos/fremtind/jokul/pulls/641/comments"},"review_comment":{"href":"https://api.github.com/repos/fremtind/jokul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fremtind/jokul/pulls/641/commits"},"statuses":{"href":"https://api.github.com/repos/fremtind/jokul/statuses/710aab47f73831af1f7c7a3c35a622f9b965911b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 191932224,
"name": "fremtind/jokul",
"url": "https://api.github.com/repos/fremtind/jokul"
}
|
{
"id": 46530368,
"login": "lfbergee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46530368?",
"url": "https://api.github.com/users/lfbergee"
}
|
{
"id": 49439893,
"login": "fremtind",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49439893?",
"url": "https://api.github.com/orgs/fremtind"
}
| 2020-01-10T15:26:22 |
11248015355
|
{"actor":{"display_login":"lfbergee"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/comments/278385238","pull_request_review_id":230437571,"id":278385238,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODM4NTIzOA==","diff_hunk":"@@ -1 +1,2 @@\n keroro","path":"hagehage.txt","position":1,"original_position":1,"commit_id":"cbb4db07ebfb4ff3d4c4b6ab0e679599d1b210ba","original_commit_id":"cbb4db07ebfb4ff3d4c4b6ab0e679599d1b210ba","user":{"login":"morkewriya","id":49750820,"node_id":"MDQ6VXNlcjQ5NzUwODIw","avatar_url":"https://avatars0.githubusercontent.com/u/49750820?v=4","gravatar_id":"","url":"https://api.github.com/users/morkewriya","html_url":"https://github.com/morkewriya","followers_url":"https://api.github.com/users/morkewriya/followers","following_url":"https://api.github.com/users/morkewriya/following{/other_user}","gists_url":"https://api.github.com/users/morkewriya/gists{/gist_id}","starred_url":"https://api.github.com/users/morkewriya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morkewriya/subscriptions","organizations_url":"https://api.github.com/users/morkewriya/orgs","repos_url":"https://api.github.com/users/morkewriya/repos","events_url":"https://api.github.com/users/morkewriya/events{/privacy}","received_events_url":"https://api.github.com/users/morkewriya/received_events","type":"User","site_admin":false},"body":"ใกใใใผใ","created_at":"2019-04-25T03:20:50Z","updated_at":"2019-04-25T03:21:03Z","html_url":"https://github.com/korkewriyaorg/testrepo/pull/1#discussion_r278385238","pull_request_url":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/comments/278385238"},"html":{"href":"https://github.com/korkewriyaorg/testrepo/pull/1#discussion_r278385238"},"pull_request":{"href":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/1"}},"in_reply_to_id":277578141},"pull_request":{"url":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/1","id":271637732,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxNjM3NzMy","html_url":"https://github.com/korkewriyaorg/testrepo/pull/1","diff_url":"https://github.com/korkewriyaorg/testrepo/pull/1.diff","patch_url":"https://github.com/korkewriyaorg/testrepo/pull/1.patch","issue_url":"https://api.github.com/repos/korkewriyaorg/testrepo/issues/1","number":1,"state":"open","locked":false,"title":"fix","user":{"login":"morkewriya","id":49750820,"node_id":"MDQ6VXNlcjQ5NzUwODIw","avatar_url":"https://avatars0.githubusercontent.com/u/49750820?v=4","gravatar_id":"","url":"https://api.github.com/users/morkewriya","html_url":"https://github.com/morkewriya","followers_url":"https://api.github.com/users/morkewriya/followers","following_url":"https://api.github.com/users/morkewriya/following{/other_user}","gists_url":"https://api.github.com/users/morkewriya/gists{/gist_id}","starred_url":"https://api.github.com/users/morkewriya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morkewriya/subscriptions","organizations_url":"https://api.github.com/users/morkewriya/orgs","repos_url":"https://api.github.com/users/morkewriya/repos","events_url":"https://api.github.com/users/morkewriya/events{/privacy}","received_events_url":"https://api.github.com/users/morkewriya/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-18T10:39:11Z","updated_at":"2019-04-25T03:21:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8537e657f5e3c829ca57c5f132b9d8d17ebfc590","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1324766972,"node_id":"MDU6TGFiZWwxMzI0NzY2OTcy","url":"https://api.github.com/repos/korkewriyaorg/testrepo/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":1324766975,"node_id":"MDU6TGFiZWwxMzI0NzY2OTc1","url":"https://api.github.com/repos/korkewriyaorg/testrepo/labels/help%20wanted","name":"help wanted","color":"008672","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/1/commits","review_comments_url":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/1/comments","review_comment_url":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/korkewriyaorg/testrepo/issues/1/comments","statuses_url":"https://api.github.com/repos/korkewriyaorg/testrepo/statuses/cbb4db07ebfb4ff3d4c4b6ab0e679599d1b210ba","head":{"label":"korkewriyaorg:hage","ref":"hage","sha":"cbb4db07ebfb4ff3d4c4b6ab0e679599d1b210ba","user":{"login":"korkewriyaorg","id":49751249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NzUxMjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/49751249?v=4","gravatar_id":"","url":"https://api.github.com/users/korkewriyaorg","html_url":"https://github.com/korkewriyaorg","followers_url":"https://api.github.com/users/korkewriyaorg/followers","following_url":"https://api.github.com/users/korkewriyaorg/following{/other_user}","gists_url":"https://api.github.com/users/korkewriyaorg/gists{/gist_id}","starred_url":"https://api.github.com/users/korkewriyaorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korkewriyaorg/subscriptions","organizations_url":"https://api.github.com/users/korkewriyaorg/orgs","repos_url":"https://api.github.com/users/korkewriyaorg/repos","events_url":"https://api.github.com/users/korkewriyaorg/events{/privacy}","received_events_url":"https://api.github.com/users/korkewriyaorg/received_events","type":"Organization","site_admin":false},"repo":{"id":182065357,"node_id":"MDEwOlJlcG9zaXRvcnkxODIwNjUzNTc=","name":"testrepo","full_name":"korkewriyaorg/testrepo","private":false,"owner":{"login":"korkewriyaorg","id":49751249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NzUxMjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/49751249?v=4","gravatar_id":"","url":"https://api.github.com/users/korkewriyaorg","html_url":"https://github.com/korkewriyaorg","followers_url":"https://api.github.com/users/korkewriyaorg/followers","following_url":"https://api.github.com/users/korkewriyaorg/following{/other_user}","gists_url":"https://api.github.com/users/korkewriyaorg/gists{/gist_id}","starred_url":"https://api.github.com/users/korkewriyaorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korkewriyaorg/subscriptions","organizations_url":"https://api.github.com/users/korkewriyaorg/orgs","repos_url":"https://api.github.com/users/korkewriyaorg/repos","events_url":"https://api.github.com/users/korkewriyaorg/events{/privacy}","received_events_url":"https://api.github.com/users/korkewriyaorg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/korkewriyaorg/testrepo","description":null,"fork":false,"url":"https://api.github.com/repos/korkewriyaorg/testrepo","forks_url":"https://api.github.com/repos/korkewriyaorg/testrepo/forks","keys_url":"https://api.github.com/repos/korkewriyaorg/testrepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/korkewriyaorg/testrepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/korkewriyaorg/testrepo/teams","hooks_url":"https://api.github.com/repos/korkewriyaorg/testrepo/hooks","issue_events_url":"https://api.github.com/repos/korkewriyaorg/testrepo/issues/events{/number}","events_url":"https://api.github.com/repos/korkewriyaorg/testrepo/events","assignees_url":"https://api.github.com/repos/korkewriyaorg/testrepo/assignees{/user}","branches_url":"https://api.github.com/repos/korkewriyaorg/testrepo/branches{/branch}","tags_url":"https://api.github.com/repos/korkewriyaorg/testrepo/tags","blobs_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/korkewriyaorg/testrepo/statuses/{sha}","languages_url":"https://api.github.com/repos/korkewriyaorg/testrepo/languages","stargazers_url":"https://api.github.com/repos/korkewriyaorg/testrepo/stargazers","contributors_url":"https://api.github.com/repos/korkewriyaorg/testrepo/contributors","subscribers_url":"https://api.github.com/repos/korkewriyaorg/testrepo/subscribers","subscription_url":"https://api.github.com/repos/korkewriyaorg/testrepo/subscription","commits_url":"https://api.github.com/repos/korkewriyaorg/testrepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/korkewriyaorg/testrepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/korkewriyaorg/testrepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/korkewriyaorg/testrepo/contents/{+path}","compare_url":"https://api.github.com/repos/korkewriyaorg/testrepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/korkewriyaorg/testrepo/merges","archive_url":"https://api.github.com/repos/korkewriyaorg/testrepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/korkewriyaorg/testrepo/downloads","issues_url":"https://api.github.com/repos/korkewriyaorg/testrepo/issues{/number}","pulls_url":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls{/number}","milestones_url":"https://api.github.com/repos/korkewriyaorg/testrepo/milestones{/number}","notifications_url":"https://api.github.com/repos/korkewriyaorg/testrepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/korkewriyaorg/testrepo/labels{/name}","releases_url":"https://api.github.com/repos/korkewriyaorg/testrepo/releases{/id}","deployments_url":"https://api.github.com/repos/korkewriyaorg/testrepo/deployments","created_at":"2019-04-18T10:13:27Z","updated_at":"2019-04-19T02:44:34Z","pushed_at":"2019-04-18T10:39:12Z","git_url":"git://github.com/korkewriyaorg/testrepo.git","ssh_url":"[email protected]:korkewriyaorg/testrepo.git","clone_url":"https://github.com/korkewriyaorg/testrepo.git","svn_url":"https://github.com/korkewriyaorg/testrepo","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"korkewriyaorg:master","ref":"master","sha":"0d643205f674307f6b3fc8be1eee834ba64e6759","user":{"login":"korkewriyaorg","id":49751249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NzUxMjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/49751249?v=4","gravatar_id":"","url":"https://api.github.com/users/korkewriyaorg","html_url":"https://github.com/korkewriyaorg","followers_url":"https://api.github.com/users/korkewriyaorg/followers","following_url":"https://api.github.com/users/korkewriyaorg/following{/other_user}","gists_url":"https://api.github.com/users/korkewriyaorg/gists{/gist_id}","starred_url":"https://api.github.com/users/korkewriyaorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korkewriyaorg/subscriptions","organizations_url":"https://api.github.com/users/korkewriyaorg/orgs","repos_url":"https://api.github.com/users/korkewriyaorg/repos","events_url":"https://api.github.com/users/korkewriyaorg/events{/privacy}","received_events_url":"https://api.github.com/users/korkewriyaorg/received_events","type":"Organization","site_admin":false},"repo":{"id":182065357,"node_id":"MDEwOlJlcG9zaXRvcnkxODIwNjUzNTc=","name":"testrepo","full_name":"korkewriyaorg/testrepo","private":false,"owner":{"login":"korkewriyaorg","id":49751249,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NzUxMjQ5","avatar_url":"https://avatars0.githubusercontent.com/u/49751249?v=4","gravatar_id":"","url":"https://api.github.com/users/korkewriyaorg","html_url":"https://github.com/korkewriyaorg","followers_url":"https://api.github.com/users/korkewriyaorg/followers","following_url":"https://api.github.com/users/korkewriyaorg/following{/other_user}","gists_url":"https://api.github.com/users/korkewriyaorg/gists{/gist_id}","starred_url":"https://api.github.com/users/korkewriyaorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/korkewriyaorg/subscriptions","organizations_url":"https://api.github.com/users/korkewriyaorg/orgs","repos_url":"https://api.github.com/users/korkewriyaorg/repos","events_url":"https://api.github.com/users/korkewriyaorg/events{/privacy}","received_events_url":"https://api.github.com/users/korkewriyaorg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/korkewriyaorg/testrepo","description":null,"fork":false,"url":"https://api.github.com/repos/korkewriyaorg/testrepo","forks_url":"https://api.github.com/repos/korkewriyaorg/testrepo/forks","keys_url":"https://api.github.com/repos/korkewriyaorg/testrepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/korkewriyaorg/testrepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/korkewriyaorg/testrepo/teams","hooks_url":"https://api.github.com/repos/korkewriyaorg/testrepo/hooks","issue_events_url":"https://api.github.com/repos/korkewriyaorg/testrepo/issues/events{/number}","events_url":"https://api.github.com/repos/korkewriyaorg/testrepo/events","assignees_url":"https://api.github.com/repos/korkewriyaorg/testrepo/assignees{/user}","branches_url":"https://api.github.com/repos/korkewriyaorg/testrepo/branches{/branch}","tags_url":"https://api.github.com/repos/korkewriyaorg/testrepo/tags","blobs_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/korkewriyaorg/testrepo/statuses/{sha}","languages_url":"https://api.github.com/repos/korkewriyaorg/testrepo/languages","stargazers_url":"https://api.github.com/repos/korkewriyaorg/testrepo/stargazers","contributors_url":"https://api.github.com/repos/korkewriyaorg/testrepo/contributors","subscribers_url":"https://api.github.com/repos/korkewriyaorg/testrepo/subscribers","subscription_url":"https://api.github.com/repos/korkewriyaorg/testrepo/subscription","commits_url":"https://api.github.com/repos/korkewriyaorg/testrepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/korkewriyaorg/testrepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/korkewriyaorg/testrepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/korkewriyaorg/testrepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/korkewriyaorg/testrepo/contents/{+path}","compare_url":"https://api.github.com/repos/korkewriyaorg/testrepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/korkewriyaorg/testrepo/merges","archive_url":"https://api.github.com/repos/korkewriyaorg/testrepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/korkewriyaorg/testrepo/downloads","issues_url":"https://api.github.com/repos/korkewriyaorg/testrepo/issues{/number}","pulls_url":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls{/number}","milestones_url":"https://api.github.com/repos/korkewriyaorg/testrepo/milestones{/number}","notifications_url":"https://api.github.com/repos/korkewriyaorg/testrepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/korkewriyaorg/testrepo/labels{/name}","releases_url":"https://api.github.com/repos/korkewriyaorg/testrepo/releases{/id}","deployments_url":"https://api.github.com/repos/korkewriyaorg/testrepo/deployments","created_at":"2019-04-18T10:13:27Z","updated_at":"2019-04-19T02:44:34Z","pushed_at":"2019-04-18T10:39:12Z","git_url":"git://github.com/korkewriyaorg/testrepo.git","ssh_url":"[email protected]:korkewriyaorg/testrepo.git","clone_url":"https://github.com/korkewriyaorg/testrepo.git","svn_url":"https://github.com/korkewriyaorg/testrepo","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/1"},"html":{"href":"https://github.com/korkewriyaorg/testrepo/pull/1"},"issue":{"href":"https://api.github.com/repos/korkewriyaorg/testrepo/issues/1"},"comments":{"href":"https://api.github.com/repos/korkewriyaorg/testrepo/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/korkewriyaorg/testrepo/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/korkewriyaorg/testrepo/statuses/cbb4db07ebfb4ff3d4c4b6ab0e679599d1b210ba"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 182065357,
"name": "korkewriyaorg/testrepo",
"url": "https://api.github.com/repos/korkewriyaorg/testrepo"
}
|
{
"id": 49750820,
"login": "morkewriya",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49750820?",
"url": "https://api.github.com/users/morkewriya"
}
|
{
"id": 49751249,
"login": "korkewriyaorg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49751249?",
"url": "https://api.github.com/orgs/korkewriyaorg"
}
| 2019-04-25T03:20:50 |
9507059818
|
{"actor":{"display_login":"morkewriya"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/litmuschaos/litmus/pulls/comments/361338331","pull_request_review_id":336386412,"id":361338331,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTMzODMzMQ==","diff_hunk":"@@ -0,0 +1,8 @@\n+# This will be execute on both pre/post checks\n+- name: Checking whether application pods are in running state\n+ shell: kubectl get pod {{ liveness_checking_pod }} -n {{ namespace }} -o custom-columns=:.status.phase --no-headers\n+ register: result","path":"utils/common/service_liveness_check.yml","position":4,"original_position":4,"commit_id":"5f9eb6baaa09abd27424bcac49d3998213c9798e","original_commit_id":"5f9eb6baaa09abd27424bcac49d3998213c9798e","user":{"login":"uditgaurav","id":35391335,"node_id":"MDQ6VXNlcjM1MzkxMzM1","avatar_url":"https://avatars3.githubusercontent.com/u/35391335?v=4","gravatar_id":"","url":"https://api.github.com/users/uditgaurav","html_url":"https://github.com/uditgaurav","followers_url":"https://api.github.com/users/uditgaurav/followers","following_url":"https://api.github.com/users/uditgaurav/following{/other_user}","gists_url":"https://api.github.com/users/uditgaurav/gists{/gist_id}","starred_url":"https://api.github.com/users/uditgaurav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uditgaurav/subscriptions","organizations_url":"https://api.github.com/users/uditgaurav/orgs","repos_url":"https://api.github.com/users/uditgaurav/repos","events_url":"https://api.github.com/users/uditgaurav/events{/privacy}","received_events_url":"https://api.github.com/users/uditgaurav/received_events","type":"User","site_admin":false},"body":"Try to take different variables for different register as it is overriding the previous one. ","created_at":"2019-12-25T21:32:42Z","updated_at":"2019-12-25T21:47:04Z","html_url":"https://github.com/litmuschaos/litmus/pull/1029#discussion_r361338331","pull_request_url":"https://api.github.com/repos/litmuschaos/litmus/pulls/1029","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/litmuschaos/litmus/pulls/comments/361338331"},"html":{"href":"https://github.com/litmuschaos/litmus/pull/1029#discussion_r361338331"},"pull_request":{"href":"https://api.github.com/repos/litmuschaos/litmus/pulls/1029"}}},"pull_request":{"url":"https://api.github.com/repos/litmuschaos/litmus/pulls/1029","id":356434379,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2NDM0Mzc5","html_url":"https://github.com/litmuschaos/litmus/pull/1029","diff_url":"https://github.com/litmuschaos/litmus/pull/1029.diff","patch_url":"https://github.com/litmuschaos/litmus/pull/1029.patch","issue_url":"https://api.github.com/repos/litmuschaos/litmus/issues/1029","number":1029,"state":"open","locked":false,"title":"(feat): Adding coreDNS pod delete chaos experiment","user":{"login":"rajdas98","id":20414564,"node_id":"MDQ6VXNlcjIwNDE0NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/20414564?v=4","gravatar_id":"","url":"https://api.github.com/users/rajdas98","html_url":"https://github.com/rajdas98","followers_url":"https://api.github.com/users/rajdas98/followers","following_url":"https://api.github.com/users/rajdas98/following{/other_user}","gists_url":"https://api.github.com/users/rajdas98/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdas98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdas98/subscriptions","organizations_url":"https://api.github.com/users/rajdas98/orgs","repos_url":"https://api.github.com/users/rajdas98/repos","events_url":"https://api.github.com/users/rajdas98/events{/privacy}","received_events_url":"https://api.github.com/users/rajdas98/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for sending a pull request! Here are some tips for you -->\r\n\r\n**What this PR does / why we need it**:\r\nThis PR will add a chaos experiment for pod delete of coreDNS deployment.\r\nwe need it to test the resiliency of coreDNS components.\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\nhttps://github.com/litmuschaos/litmus/issues/1025\r\n**Checklist**\r\n\r\n* [x] Does this PR have a corresponding GitHub issue? \r\n* [ ] Have you included relevant README for the chaoslib/experiment with details?\r\n* [x] Have you added debug messages where necessary? \r\n* [x] Have you added task comments where necessary? \r\n* [x] Have you tested the changes for possible failure conditions?\r\n* [x] Have you provided the positive & negative test logs for the litmusbook execution?\r\n* [x] Does the litmusbook ensure idempotency of cluster state?, i.e., is cluster restored to original state?\r\n* [ ] Have you used non-shell/command modules for Kubernetes tasks?\r\n* [x] Have you (jinja) templatized custom scripts that is run by the litmusbook, if any? \r\n* [x] Have you (jinja) templatized Kubernetes deployment manifests used by the litmusbook, if any?\r\n* [x] Have you reused/created util functions instead of repeating tasks in the litmusbook?\r\n* [ ] Do the artifacts follow the appropriate directory structure? \r\n* [ ] Have you isolated storage (eg: OpenEBS) specific implementations, checks? \r\n* [ ] Have you isolated platform (eg: baremetal kubeadm/openshift/aws/gcloud) specific implementations, checks? \r\n* [x] Are the ansible facts well defined? Is the scope explicitly set for playbook & included utils?\r\n* [ ] Have you ensured minimum/careful usage of shell utilities (awk, grep, sed, cut, xargs etc.,)?\r\n* [ ] Can the limtusbook be executed both from within & outside a container (configurable paths, no hardcode)?\r\n* [x] Can you suggest the minimal resource requirements for the litmusbook execution?\r\n* [x] Does the litmusbook job artifact carry comments/default options/range for the ENV tunables?\r\n* [x] Has the litmusbooks been linted? \r\n\r\n**Special notes for your reviewer**:\r\nLogs of the chaos experiment:\r\n[log.txt](https://github.com/litmuschaos/litmus/files/3996073/log.txt)\r\n","created_at":"2019-12-23T19:47:35Z","updated_at":"2019-12-25T21:47:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0319b18e68c2e681e67aa6b7bf080c7e4ad506a7","assignee":{"login":"rajdas98","id":20414564,"node_id":"MDQ6VXNlcjIwNDE0NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/20414564?v=4","gravatar_id":"","url":"https://api.github.com/users/rajdas98","html_url":"https://github.com/rajdas98","followers_url":"https://api.github.com/users/rajdas98/followers","following_url":"https://api.github.com/users/rajdas98/following{/other_user}","gists_url":"https://api.github.com/users/rajdas98/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdas98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdas98/subscriptions","organizations_url":"https://api.github.com/users/rajdas98/orgs","repos_url":"https://api.github.com/users/rajdas98/repos","events_url":"https://api.github.com/users/rajdas98/events{/privacy}","received_events_url":"https://api.github.com/users/rajdas98/received_events","type":"User","site_admin":false},"assignees":[{"login":"rajdas98","id":20414564,"node_id":"MDQ6VXNlcjIwNDE0NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/20414564?v=4","gravatar_id":"","url":"https://api.github.com/users/rajdas98","html_url":"https://github.com/rajdas98","followers_url":"https://api.github.com/users/rajdas98/followers","following_url":"https://api.github.com/users/rajdas98/following{/other_user}","gists_url":"https://api.github.com/users/rajdas98/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdas98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdas98/subscriptions","organizations_url":"https://api.github.com/users/rajdas98/orgs","repos_url":"https://api.github.com/users/rajdas98/repos","events_url":"https://api.github.com/users/rajdas98/events{/privacy}","received_events_url":"https://api.github.com/users/rajdas98/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ajeshbaby","id":22294158,"node_id":"MDQ6VXNlcjIyMjk0MTU4","avatar_url":"https://avatars0.githubusercontent.com/u/22294158?v=4","gravatar_id":"","url":"https://api.github.com/users/ajeshbaby","html_url":"https://github.com/ajeshbaby","followers_url":"https://api.github.com/users/ajeshbaby/followers","following_url":"https://api.github.com/users/ajeshbaby/following{/other_user}","gists_url":"https://api.github.com/users/ajeshbaby/gists{/gist_id}","starred_url":"https://api.github.com/users/ajeshbaby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajeshbaby/subscriptions","organizations_url":"https://api.github.com/users/ajeshbaby/orgs","repos_url":"https://api.github.com/users/ajeshbaby/repos","events_url":"https://api.github.com/users/ajeshbaby/events{/privacy}","received_events_url":"https://api.github.com/users/ajeshbaby/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/litmuschaos/litmus/milestones/7","html_url":"https://github.com/litmuschaos/litmus/milestone/7","labels_url":"https://api.github.com/repos/litmuschaos/litmus/milestones/7/labels","id":4918158,"node_id":"MDk6TWlsZXN0b25lNDkxODE1OA==","number":7,"title":"1.0","description":"January 2020 release","creator":{"login":"umamukkara","id":19591814,"node_id":"MDQ6VXNlcjE5NTkxODE0","avatar_url":"https://avatars1.githubusercontent.com/u/19591814?v=4","gravatar_id":"","url":"https://api.github.com/users/umamukkara","html_url":"https://github.com/umamukkara","followers_url":"https://api.github.com/users/umamukkara/followers","following_url":"https://api.github.com/users/umamukkara/following{/other_user}","gists_url":"https://api.github.com/users/umamukkara/gists{/gist_id}","starred_url":"https://api.github.com/users/umamukkara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umamukkara/subscriptions","organizations_url":"https://api.github.com/users/umamukkara/orgs","repos_url":"https://api.github.com/users/umamukkara/repos","events_url":"https://api.github.com/users/umamukkara/events{/privacy}","received_events_url":"https://api.github.com/users/umamukkara/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":3,"state":"open","created_at":"2019-12-10T09:21:17Z","updated_at":"2019-12-25T14:32:29Z","due_on":"2020-01-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/litmuschaos/litmus/pulls/1029/commits","review_comments_url":"https://api.github.com/repos/litmuschaos/litmus/pulls/1029/comments","review_comment_url":"https://api.github.com/repos/litmuschaos/litmus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/litmuschaos/litmus/issues/1029/comments","statuses_url":"https://api.github.com/repos/litmuschaos/litmus/statuses/5f9eb6baaa09abd27424bcac49d3998213c9798e","head":{"label":"rajdas98:coredns","ref":"coredns","sha":"5f9eb6baaa09abd27424bcac49d3998213c9798e","user":{"login":"rajdas98","id":20414564,"node_id":"MDQ6VXNlcjIwNDE0NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/20414564?v=4","gravatar_id":"","url":"https://api.github.com/users/rajdas98","html_url":"https://github.com/rajdas98","followers_url":"https://api.github.com/users/rajdas98/followers","following_url":"https://api.github.com/users/rajdas98/following{/other_user}","gists_url":"https://api.github.com/users/rajdas98/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdas98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdas98/subscriptions","organizations_url":"https://api.github.com/users/rajdas98/orgs","repos_url":"https://api.github.com/users/rajdas98/repos","events_url":"https://api.github.com/users/rajdas98/events{/privacy}","received_events_url":"https://api.github.com/users/rajdas98/received_events","type":"User","site_admin":false},"repo":{"id":229699509,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk2OTk1MDk=","name":"litmus","full_name":"rajdas98/litmus","private":false,"owner":{"login":"rajdas98","id":20414564,"node_id":"MDQ6VXNlcjIwNDE0NTY0","avatar_url":"https://avatars2.githubusercontent.com/u/20414564?v=4","gravatar_id":"","url":"https://api.github.com/users/rajdas98","html_url":"https://github.com/rajdas98","followers_url":"https://api.github.com/users/rajdas98/followers","following_url":"https://api.github.com/users/rajdas98/following{/other_user}","gists_url":"https://api.github.com/users/rajdas98/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdas98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdas98/subscriptions","organizations_url":"https://api.github.com/users/rajdas98/orgs","repos_url":"https://api.github.com/users/rajdas98/repos","events_url":"https://api.github.com/users/rajdas98/events{/privacy}","received_events_url":"https://api.github.com/users/rajdas98/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rajdas98/litmus","description":"Litmus is a toolset to do chaos engineering in a kubernetes native way. Litmus provides chaos CRDs for Cloud-Native developers and SREs to inject, orchestrate and monitor chaos to find weaknesses in Kubernetes deployments. Community notes is at https://hackmd.io/a4Zu_sH4TZGeih-xCimi3Q","fork":true,"url":"https://api.github.com/repos/rajdas98/litmus","forks_url":"https://api.github.com/repos/rajdas98/litmus/forks","keys_url":"https://api.github.com/repos/rajdas98/litmus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajdas98/litmus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajdas98/litmus/teams","hooks_url":"https://api.github.com/repos/rajdas98/litmus/hooks","issue_events_url":"https://api.github.com/repos/rajdas98/litmus/issues/events{/number}","events_url":"https://api.github.com/repos/rajdas98/litmus/events","assignees_url":"https://api.github.com/repos/rajdas98/litmus/assignees{/user}","branches_url":"https://api.github.com/repos/rajdas98/litmus/branches{/branch}","tags_url":"https://api.github.com/repos/rajdas98/litmus/tags","blobs_url":"https://api.github.com/repos/rajdas98/litmus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajdas98/litmus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajdas98/litmus/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajdas98/litmus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajdas98/litmus/statuses/{sha}","languages_url":"https://api.github.com/repos/rajdas98/litmus/languages","stargazers_url":"https://api.github.com/repos/rajdas98/litmus/stargazers","contributors_url":"https://api.github.com/repos/rajdas98/litmus/contributors","subscribers_url":"https://api.github.com/repos/rajdas98/litmus/subscribers","subscription_url":"https://api.github.com/repos/rajdas98/litmus/subscription","commits_url":"https://api.github.com/repos/rajdas98/litmus/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajdas98/litmus/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajdas98/litmus/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajdas98/litmus/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajdas98/litmus/contents/{+path}","compare_url":"https://api.github.com/repos/rajdas98/litmus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajdas98/litmus/merges","archive_url":"https://api.github.com/repos/rajdas98/litmus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajdas98/litmus/downloads","issues_url":"https://api.github.com/repos/rajdas98/litmus/issues{/number}","pulls_url":"https://api.github.com/repos/rajdas98/litmus/pulls{/number}","milestones_url":"https://api.github.com/repos/rajdas98/litmus/milestones{/number}","notifications_url":"https://api.github.com/repos/rajdas98/litmus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajdas98/litmus/labels{/name}","releases_url":"https://api.github.com/repos/rajdas98/litmus/releases{/id}","deployments_url":"https://api.github.com/repos/rajdas98/litmus/deployments","created_at":"2019-12-23T07:25:02Z","updated_at":"2019-12-23T07:25:03Z","pushed_at":"2019-12-25T20:28:30Z","git_url":"git://github.com/rajdas98/litmus.git","ssh_url":"[email protected]:rajdas98/litmus.git","clone_url":"https://github.com/rajdas98/litmus.git","svn_url":"https://github.com/rajdas98/litmus","homepage":"https://litmuschaos.io","size":12300,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"litmuschaos:master","ref":"master","sha":"d0b0edd67ad33d774fd3dd5452638bec4a89ce90","user":{"login":"litmuschaos","id":49853472,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5ODUzNDcy","avatar_url":"https://avatars1.githubusercontent.com/u/49853472?v=4","gravatar_id":"","url":"https://api.github.com/users/litmuschaos","html_url":"https://github.com/litmuschaos","followers_url":"https://api.github.com/users/litmuschaos/followers","following_url":"https://api.github.com/users/litmuschaos/following{/other_user}","gists_url":"https://api.github.com/users/litmuschaos/gists{/gist_id}","starred_url":"https://api.github.com/users/litmuschaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litmuschaos/subscriptions","organizations_url":"https://api.github.com/users/litmuschaos/orgs","repos_url":"https://api.github.com/users/litmuschaos/repos","events_url":"https://api.github.com/users/litmuschaos/events{/privacy}","received_events_url":"https://api.github.com/users/litmuschaos/received_events","type":"Organization","site_admin":false},"repo":{"id":85039965,"node_id":"MDEwOlJlcG9zaXRvcnk4NTAzOTk2NQ==","name":"litmus","full_name":"litmuschaos/litmus","private":false,"owner":{"login":"litmuschaos","id":49853472,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5ODUzNDcy","avatar_url":"https://avatars1.githubusercontent.com/u/49853472?v=4","gravatar_id":"","url":"https://api.github.com/users/litmuschaos","html_url":"https://github.com/litmuschaos","followers_url":"https://api.github.com/users/litmuschaos/followers","following_url":"https://api.github.com/users/litmuschaos/following{/other_user}","gists_url":"https://api.github.com/users/litmuschaos/gists{/gist_id}","starred_url":"https://api.github.com/users/litmuschaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litmuschaos/subscriptions","organizations_url":"https://api.github.com/users/litmuschaos/orgs","repos_url":"https://api.github.com/users/litmuschaos/repos","events_url":"https://api.github.com/users/litmuschaos/events{/privacy}","received_events_url":"https://api.github.com/users/litmuschaos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/litmuschaos/litmus","description":"Litmus is a toolset to do chaos engineering in a kubernetes native way. Litmus provides chaos CRDs for Cloud-Native developers and SREs to inject, orchestrate and monitor chaos to find weaknesses in Kubernetes deployments. Community notes is at https://hackmd.io/a4Zu_sH4TZGeih-xCimi3Q","fork":false,"url":"https://api.github.com/repos/litmuschaos/litmus","forks_url":"https://api.github.com/repos/litmuschaos/litmus/forks","keys_url":"https://api.github.com/repos/litmuschaos/litmus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/litmuschaos/litmus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/litmuschaos/litmus/teams","hooks_url":"https://api.github.com/repos/litmuschaos/litmus/hooks","issue_events_url":"https://api.github.com/repos/litmuschaos/litmus/issues/events{/number}","events_url":"https://api.github.com/repos/litmuschaos/litmus/events","assignees_url":"https://api.github.com/repos/litmuschaos/litmus/assignees{/user}","branches_url":"https://api.github.com/repos/litmuschaos/litmus/branches{/branch}","tags_url":"https://api.github.com/repos/litmuschaos/litmus/tags","blobs_url":"https://api.github.com/repos/litmuschaos/litmus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/litmuschaos/litmus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/litmuschaos/litmus/git/refs{/sha}","trees_url":"https://api.github.com/repos/litmuschaos/litmus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/litmuschaos/litmus/statuses/{sha}","languages_url":"https://api.github.com/repos/litmuschaos/litmus/languages","stargazers_url":"https://api.github.com/repos/litmuschaos/litmus/stargazers","contributors_url":"https://api.github.com/repos/litmuschaos/litmus/contributors","subscribers_url":"https://api.github.com/repos/litmuschaos/litmus/subscribers","subscription_url":"https://api.github.com/repos/litmuschaos/litmus/subscription","commits_url":"https://api.github.com/repos/litmuschaos/litmus/commits{/sha}","git_commits_url":"https://api.github.com/repos/litmuschaos/litmus/git/commits{/sha}","comments_url":"https://api.github.com/repos/litmuschaos/litmus/comments{/number}","issue_comment_url":"https://api.github.com/repos/litmuschaos/litmus/issues/comments{/number}","contents_url":"https://api.github.com/repos/litmuschaos/litmus/contents/{+path}","compare_url":"https://api.github.com/repos/litmuschaos/litmus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/litmuschaos/litmus/merges","archive_url":"https://api.github.com/repos/litmuschaos/litmus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/litmuschaos/litmus/downloads","issues_url":"https://api.github.com/repos/litmuschaos/litmus/issues{/number}","pulls_url":"https://api.github.com/repos/litmuschaos/litmus/pulls{/number}","milestones_url":"https://api.github.com/repos/litmuschaos/litmus/milestones{/number}","notifications_url":"https://api.github.com/repos/litmuschaos/litmus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/litmuschaos/litmus/labels{/name}","releases_url":"https://api.github.com/repos/litmuschaos/litmus/releases{/id}","deployments_url":"https://api.github.com/repos/litmuschaos/litmus/deployments","created_at":"2017-03-15T07:02:59Z","updated_at":"2019-12-25T17:02:29Z","pushed_at":"2019-12-25T20:28:31Z","git_url":"git://github.com/litmuschaos/litmus.git","ssh_url":"[email protected]:litmuschaos/litmus.git","clone_url":"https://github.com/litmuschaos/litmus.git","svn_url":"https://github.com/litmuschaos/litmus","homepage":"https://litmuschaos.io","size":12297,"stargazers_count":497,"watchers_count":497,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":166,"open_issues":95,"watchers":497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/litmuschaos/litmus/pulls/1029"},"html":{"href":"https://github.com/litmuschaos/litmus/pull/1029"},"issue":{"href":"https://api.github.com/repos/litmuschaos/litmus/issues/1029"},"comments":{"href":"https://api.github.com/repos/litmuschaos/litmus/issues/1029/comments"},"review_comments":{"href":"https://api.github.com/repos/litmuschaos/litmus/pulls/1029/comments"},"review_comment":{"href":"https://api.github.com/repos/litmuschaos/litmus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/litmuschaos/litmus/pulls/1029/commits"},"statuses":{"href":"https://api.github.com/repos/litmuschaos/litmus/statuses/5f9eb6baaa09abd27424bcac49d3998213c9798e"}},"author_association":"MEMBER"}}
|
{
"id": 85039965,
"name": "litmuschaos/litmus",
"url": "https://api.github.com/repos/litmuschaos/litmus"
}
|
{
"id": 35391335,
"login": "uditgaurav",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35391335?",
"url": "https://api.github.com/users/uditgaurav"
}
|
{
"id": 49853472,
"login": "litmuschaos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49853472?",
"url": "https://api.github.com/orgs/litmuschaos"
}
| 2019-12-25T21:32:42 |
11158500896
|
{"actor":{"display_login":"uditgaurav"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/open-telemetry/oteps/pulls/comments/318409644","pull_request_review_id":280611125,"id":318409644,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxODQwOTY0NA==","diff_hunk":"@@ -0,0 +1,69 @@\n+# Named Tracers\n+\n+**Status:** `proposed`\n+\n+_Creating tracers using a factory mechanism and naming those tracers in accordance with the library that provides the instrumentation for a traced component._\n+\n+## Suggested reading\n+\n+* [Proposal: Tracer Components](https://github.com/open-telemetry/opentelemetry-specification/issues/10)\n+* [Global Instance discussions](https://github.com/open-telemetry/opentelemetry-specification/labels/global%20instance)\n+\n+## Motivation\n+\n+Instead of having a global tracer singleton, every instrumentation library needs to create its own tracer, which also has a proper name that identifies the library / logical component that uses this tracer. If there are two different instrumentation libraries for the same technology (e.g. MongoDb), these instrumentation libraries should have distinct names.\n+\n+This proposal originates from an `opentelemetry-specification` proposal on [components](https://github.com/open-telemetry/opentelemetry-specification/issues/10), but the term \"components\" was quickly found to being too generic and possibly misleading, since it is already used frequently in differing contexts and connotations.\n+\n+The purpose of _Named Tracers_ is the ability to allow for a more fine-grained control of the amount of tracing data being generated by a library or application. Associating a name (e.g. _\"io.opentelemetry.contrib.mongodb\"_) with a tracer allows for a logical coupling of this tracer and a certain technology or library (like _MongoDB_ in this example).\n+\n+*Named Tracers* allow enabling and disabling tracing of a specific library, which might be necessary in case:\n+* A library causes too much runtime or memory overhead.\n+* A library has issues or bugs (e.g. does not call `span.end()` in every case).\n+* \"Double-Tracing\" becomes a problem. This can be the case if a vendor (e.g. Dynatrace) might already have built-in auto-instrumentation for a certain library. In this case the vendor might want to decide (automatically or configuration-based) which of the implementations should be enabled or disabled.\n+\n+\n+## Explanation\n+\n+From a user perspective, working with *Named Tracers* and *TracerFactories* is very similar to how logging frameworks like [log4j](https://www.slf4j.org/apidocs/org/slf4j/LoggerFactory.html) work. In analogy to requesting Logger objects through LoggerFactories, a tracing library would create specific 'Tracer' objects through a 'TracerFactory'.\n+\n+```java\n+Tracer tracer = OpenTelemetry.Tracing.getTracerFactory().getTracer(\"io.opentelemetry.contrib.mongodb\");\n+```\n+\n+In a way, the `TracerFactory` replaces the global `Tracer` singleton object as a ubiquitous point to request a tracer instance.\n+\n+\n+## Internal details\n+\n+By providing a TracerFactory and *Named Tracers*, a vendor or OpenTelemetry implementation gains more flexibility in providing tracers and can decide whether or not to produce spans for a specific traced component and even change this behavior at runtime.\n+\n+In the simplest case, an OpenTelemetry implementation can return a single instance for a requested tracer regardless of the name specified. This could be the case for implementations that do not want/need to enable or disable a tracer.\n+\n+Alternatively, an implementation can provide different tracer instances per specified tracer name, thus being able to associate this tracer with the component being traced. This allows for the possibility to enable / disable a tracer based on a custom configuration.","path":"text/0000-named-tracers.md","position":43,"original_position":43,"commit_id":"94c4b9cdbee8dfd75563a1e41370ceda54753feb","original_commit_id":"40d93e38463256c3724b783216e11c4b12fc2787","user":{"login":"z1c0","id":4700296,"node_id":"MDQ6VXNlcjQ3MDAyOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4700296?v=4","gravatar_id":"","url":"https://api.github.com/users/z1c0","html_url":"https://github.com/z1c0","followers_url":"https://api.github.com/users/z1c0/followers","following_url":"https://api.github.com/users/z1c0/following{/other_user}","gists_url":"https://api.github.com/users/z1c0/gists{/gist_id}","starred_url":"https://api.github.com/users/z1c0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z1c0/subscriptions","organizations_url":"https://api.github.com/users/z1c0/orgs","repos_url":"https://api.github.com/users/z1c0/repos","events_url":"https://api.github.com/users/z1c0/events{/privacy}","received_events_url":"https://api.github.com/users/z1c0/received_events","type":"User","site_admin":false},"body":"Not sure about SDKs, but this is probably beyond the scope of this RFC. Different tracer implementations however, are entirely possible in this model.","created_at":"2019-08-28T06:24:54Z","updated_at":"2019-08-28T06:24:54Z","html_url":"https://github.com/open-telemetry/oteps/pull/16#discussion_r318409644","pull_request_url":"https://api.github.com/repos/open-telemetry/oteps/pulls/16","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/open-telemetry/oteps/pulls/comments/318409644"},"html":{"href":"https://github.com/open-telemetry/oteps/pull/16#discussion_r318409644"},"pull_request":{"href":"https://api.github.com/repos/open-telemetry/oteps/pulls/16"}},"in_reply_to_id":314934461},"pull_request":{"url":"https://api.github.com/repos/open-telemetry/oteps/pulls/16","id":306480190,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2NDgwMTkw","html_url":"https://github.com/open-telemetry/oteps/pull/16","diff_url":"https://github.com/open-telemetry/oteps/pull/16.diff","patch_url":"https://github.com/open-telemetry/oteps/pull/16.patch","issue_url":"https://api.github.com/repos/open-telemetry/oteps/issues/16","number":16,"state":"open","locked":false,"title":"Propose \"Named Tracers\"","user":{"login":"z1c0","id":4700296,"node_id":"MDQ6VXNlcjQ3MDAyOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4700296?v=4","gravatar_id":"","url":"https://api.github.com/users/z1c0","html_url":"https://github.com/z1c0","followers_url":"https://api.github.com/users/z1c0/followers","following_url":"https://api.github.com/users/z1c0/following{/other_user}","gists_url":"https://api.github.com/users/z1c0/gists{/gist_id}","starred_url":"https://api.github.com/users/z1c0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z1c0/subscriptions","organizations_url":"https://api.github.com/users/z1c0/orgs","repos_url":"https://api.github.com/users/z1c0/repos","events_url":"https://api.github.com/users/z1c0/events{/privacy}","received_events_url":"https://api.github.com/users/z1c0/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-12T12:46:36Z","updated_at":"2019-08-28T06:24:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e988c0864107a6736b5bce58f82645ed46f504ca","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tedsuo","id":24074,"node_id":"MDQ6VXNlcjI0MDc0","avatar_url":"https://avatars2.githubusercontent.com/u/24074?v=4","gravatar_id":"","url":"https://api.github.com/users/tedsuo","html_url":"https://github.com/tedsuo","followers_url":"https://api.github.com/users/tedsuo/followers","following_url":"https://api.github.com/users/tedsuo/following{/other_user}","gists_url":"https://api.github.com/users/tedsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/tedsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedsuo/subscriptions","organizations_url":"https://api.github.com/users/tedsuo/orgs","repos_url":"https://api.github.com/users/tedsuo/repos","events_url":"https://api.github.com/users/tedsuo/events{/privacy}","received_events_url":"https://api.github.com/users/tedsuo/received_events","type":"User","site_admin":false},{"login":"carlosalberto","id":260065,"node_id":"MDQ6VXNlcjI2MDA2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/260065?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosalberto","html_url":"https://github.com/carlosalberto","followers_url":"https://api.github.com/users/carlosalberto/followers","following_url":"https://api.github.com/users/carlosalberto/following{/other_user}","gists_url":"https://api.github.com/users/carlosalberto/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosalberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosalberto/subscriptions","organizations_url":"https://api.github.com/users/carlosalberto/orgs","repos_url":"https://api.github.com/users/carlosalberto/repos","events_url":"https://api.github.com/users/carlosalberto/events{/privacy}","received_events_url":"https://api.github.com/users/carlosalberto/received_events","type":"User","site_admin":false},{"login":"iredelmeier","id":3298606,"node_id":"MDQ6VXNlcjMyOTg2MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3298606?v=4","gravatar_id":"","url":"https://api.github.com/users/iredelmeier","html_url":"https://github.com/iredelmeier","followers_url":"https://api.github.com/users/iredelmeier/followers","following_url":"https://api.github.com/users/iredelmeier/following{/other_user}","gists_url":"https://api.github.com/users/iredelmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/iredelmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iredelmeier/subscriptions","organizations_url":"https://api.github.com/users/iredelmeier/orgs","repos_url":"https://api.github.com/users/iredelmeier/repos","events_url":"https://api.github.com/users/iredelmeier/events{/privacy}","received_events_url":"https://api.github.com/users/iredelmeier/received_events","type":"User","site_admin":false},{"login":"SergeyKanzhelev","id":9950081,"node_id":"MDQ6VXNlcjk5NTAwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/9950081?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyKanzhelev","html_url":"https://github.com/SergeyKanzhelev","followers_url":"https://api.github.com/users/SergeyKanzhelev/followers","following_url":"https://api.github.com/users/SergeyKanzhelev/following{/other_user}","gists_url":"https://api.github.com/users/SergeyKanzhelev/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyKanzhelev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyKanzhelev/subscriptions","organizations_url":"https://api.github.com/users/SergeyKanzhelev/orgs","repos_url":"https://api.github.com/users/SergeyKanzhelev/repos","events_url":"https://api.github.com/users/SergeyKanzhelev/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyKanzhelev/received_events","type":"User","site_admin":false},{"login":"songy23","id":10536136,"node_id":"MDQ6VXNlcjEwNTM2MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/10536136?v=4","gravatar_id":"","url":"https://api.github.com/users/songy23","html_url":"https://github.com/songy23","followers_url":"https://api.github.com/users/songy23/followers","following_url":"https://api.github.com/users/songy23/following{/other_user}","gists_url":"https://api.github.com/users/songy23/gists{/gist_id}","starred_url":"https://api.github.com/users/songy23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songy23/subscriptions","organizations_url":"https://api.github.com/users/songy23/orgs","repos_url":"https://api.github.com/users/songy23/repos","events_url":"https://api.github.com/users/songy23/events{/privacy}","received_events_url":"https://api.github.com/users/songy23/received_events","type":"User","site_admin":false},{"login":"c24t","id":43799105,"node_id":"MDQ6VXNlcjQzNzk5MTA1","avatar_url":"https://avatars3.githubusercontent.com/u/43799105?v=4","gravatar_id":"","url":"https://api.github.com/users/c24t","html_url":"https://github.com/c24t","followers_url":"https://api.github.com/users/c24t/followers","following_url":"https://api.github.com/users/c24t/following{/other_user}","gists_url":"https://api.github.com/users/c24t/gists{/gist_id}","starred_url":"https://api.github.com/users/c24t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c24t/subscriptions","organizations_url":"https://api.github.com/users/c24t/orgs","repos_url":"https://api.github.com/users/c24t/repos","events_url":"https://api.github.com/users/c24t/events{/privacy}","received_events_url":"https://api.github.com/users/c24t/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-telemetry/oteps/pulls/16/commits","review_comments_url":"https://api.github.com/repos/open-telemetry/oteps/pulls/16/comments","review_comment_url":"https://api.github.com/repos/open-telemetry/oteps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-telemetry/oteps/issues/16/comments","statuses_url":"https://api.github.com/repos/open-telemetry/oteps/statuses/94c4b9cdbee8dfd75563a1e41370ceda54753feb","head":{"label":"dynatrace-oss-contrib:master","ref":"master","sha":"94c4b9cdbee8dfd75563a1e41370ceda54753feb","user":{"login":"dynatrace-oss-contrib","id":49676351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5Njc2MzUx","avatar_url":"https://avatars1.githubusercontent.com/u/49676351?v=4","gravatar_id":"","url":"https://api.github.com/users/dynatrace-oss-contrib","html_url":"https://github.com/dynatrace-oss-contrib","followers_url":"https://api.github.com/users/dynatrace-oss-contrib/followers","following_url":"https://api.github.com/users/dynatrace-oss-contrib/following{/other_user}","gists_url":"https://api.github.com/users/dynatrace-oss-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/dynatrace-oss-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dynatrace-oss-contrib/subscriptions","organizations_url":"https://api.github.com/users/dynatrace-oss-contrib/orgs","repos_url":"https://api.github.com/users/dynatrace-oss-contrib/repos","events_url":"https://api.github.com/users/dynatrace-oss-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/dynatrace-oss-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":197204487,"node_id":"MDEwOlJlcG9zaXRvcnkxOTcyMDQ0ODc=","name":"rfcs","full_name":"dynatrace-oss-contrib/rfcs","private":false,"owner":{"login":"dynatrace-oss-contrib","id":49676351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5Njc2MzUx","avatar_url":"https://avatars1.githubusercontent.com/u/49676351?v=4","gravatar_id":"","url":"https://api.github.com/users/dynatrace-oss-contrib","html_url":"https://github.com/dynatrace-oss-contrib","followers_url":"https://api.github.com/users/dynatrace-oss-contrib/followers","following_url":"https://api.github.com/users/dynatrace-oss-contrib/following{/other_user}","gists_url":"https://api.github.com/users/dynatrace-oss-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/dynatrace-oss-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dynatrace-oss-contrib/subscriptions","organizations_url":"https://api.github.com/users/dynatrace-oss-contrib/orgs","repos_url":"https://api.github.com/users/dynatrace-oss-contrib/repos","events_url":"https://api.github.com/users/dynatrace-oss-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/dynatrace-oss-contrib/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dynatrace-oss-contrib/rfcs","description":"Evolving OpenTelemetry at the speed of Markdown","fork":true,"url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs","forks_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/forks","keys_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/teams","hooks_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/hooks","issue_events_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/events","assignees_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/tags","blobs_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/languages","stargazers_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/stargazers","contributors_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/contributors","subscribers_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/subscribers","subscription_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/subscription","commits_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/merges","archive_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/downloads","issues_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/dynatrace-oss-contrib/rfcs/deployments","created_at":"2019-07-16T13:57:06Z","updated_at":"2019-08-27T15:57:32Z","pushed_at":"2019-08-27T15:57:29Z","git_url":"git://github.com/dynatrace-oss-contrib/rfcs.git","ssh_url":"[email protected]:dynatrace-oss-contrib/rfcs.git","clone_url":"https://github.com/dynatrace-oss-contrib/rfcs.git","svn_url":"https://github.com/dynatrace-oss-contrib/rfcs","homepage":null,"size":52,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-telemetry:master","ref":"master","sha":"ce99c8dde2f27d7ff404c19414af1e6c2201dc97","user":{"login":"open-telemetry","id":49998002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk4MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/49998002?v=4","gravatar_id":"","url":"https://api.github.com/users/open-telemetry","html_url":"https://github.com/open-telemetry","followers_url":"https://api.github.com/users/open-telemetry/followers","following_url":"https://api.github.com/users/open-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/open-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/open-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-telemetry/subscriptions","organizations_url":"https://api.github.com/users/open-telemetry/orgs","repos_url":"https://api.github.com/users/open-telemetry/repos","events_url":"https://api.github.com/users/open-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/open-telemetry/received_events","type":"Organization","site_admin":false},"repo":{"id":192958794,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI5NTg3OTQ=","name":"oteps","full_name":"open-telemetry/oteps","private":false,"owner":{"login":"open-telemetry","id":49998002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk4MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/49998002?v=4","gravatar_id":"","url":"https://api.github.com/users/open-telemetry","html_url":"https://github.com/open-telemetry","followers_url":"https://api.github.com/users/open-telemetry/followers","following_url":"https://api.github.com/users/open-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/open-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/open-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-telemetry/subscriptions","organizations_url":"https://api.github.com/users/open-telemetry/orgs","repos_url":"https://api.github.com/users/open-telemetry/repos","events_url":"https://api.github.com/users/open-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/open-telemetry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-telemetry/oteps","description":"OpenTelemetry Enhancement Proposals","fork":false,"url":"https://api.github.com/repos/open-telemetry/oteps","forks_url":"https://api.github.com/repos/open-telemetry/oteps/forks","keys_url":"https://api.github.com/repos/open-telemetry/oteps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-telemetry/oteps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-telemetry/oteps/teams","hooks_url":"https://api.github.com/repos/open-telemetry/oteps/hooks","issue_events_url":"https://api.github.com/repos/open-telemetry/oteps/issues/events{/number}","events_url":"https://api.github.com/repos/open-telemetry/oteps/events","assignees_url":"https://api.github.com/repos/open-telemetry/oteps/assignees{/user}","branches_url":"https://api.github.com/repos/open-telemetry/oteps/branches{/branch}","tags_url":"https://api.github.com/repos/open-telemetry/oteps/tags","blobs_url":"https://api.github.com/repos/open-telemetry/oteps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-telemetry/oteps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-telemetry/oteps/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-telemetry/oteps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-telemetry/oteps/statuses/{sha}","languages_url":"https://api.github.com/repos/open-telemetry/oteps/languages","stargazers_url":"https://api.github.com/repos/open-telemetry/oteps/stargazers","contributors_url":"https://api.github.com/repos/open-telemetry/oteps/contributors","subscribers_url":"https://api.github.com/repos/open-telemetry/oteps/subscribers","subscription_url":"https://api.github.com/repos/open-telemetry/oteps/subscription","commits_url":"https://api.github.com/repos/open-telemetry/oteps/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-telemetry/oteps/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-telemetry/oteps/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-telemetry/oteps/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-telemetry/oteps/contents/{+path}","compare_url":"https://api.github.com/repos/open-telemetry/oteps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-telemetry/oteps/merges","archive_url":"https://api.github.com/repos/open-telemetry/oteps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-telemetry/oteps/downloads","issues_url":"https://api.github.com/repos/open-telemetry/oteps/issues{/number}","pulls_url":"https://api.github.com/repos/open-telemetry/oteps/pulls{/number}","milestones_url":"https://api.github.com/repos/open-telemetry/oteps/milestones{/number}","notifications_url":"https://api.github.com/repos/open-telemetry/oteps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-telemetry/oteps/labels{/name}","releases_url":"https://api.github.com/repos/open-telemetry/oteps/releases{/id}","deployments_url":"https://api.github.com/repos/open-telemetry/oteps/deployments","created_at":"2019-06-20T17:06:50Z","updated_at":"2019-08-26T19:18:03Z","pushed_at":"2019-08-27T22:17:00Z","git_url":"git://github.com/open-telemetry/oteps.git","ssh_url":"[email protected]:open-telemetry/oteps.git","clone_url":"https://github.com/open-telemetry/oteps.git","svn_url":"https://github.com/open-telemetry/oteps","homepage":"","size":39,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":9,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-telemetry/oteps/pulls/16"},"html":{"href":"https://github.com/open-telemetry/oteps/pull/16"},"issue":{"href":"https://api.github.com/repos/open-telemetry/oteps/issues/16"},"comments":{"href":"https://api.github.com/repos/open-telemetry/oteps/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/open-telemetry/oteps/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/open-telemetry/oteps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-telemetry/oteps/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/open-telemetry/oteps/statuses/94c4b9cdbee8dfd75563a1e41370ceda54753feb"}},"author_association":"NONE"}}
|
{
"id": 192958794,
"name": "open-telemetry/oteps",
"url": "https://api.github.com/repos/open-telemetry/oteps"
}
|
{
"id": 4700296,
"login": "z1c0",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4700296?",
"url": "https://api.github.com/users/z1c0"
}
|
{
"id": 49998002,
"login": "open-telemetry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49998002?",
"url": "https://api.github.com/orgs/open-telemetry"
}
| 2019-08-28T08:24:54 |
10297711298
|
{"actor":{"display_login":"z1c0"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/comments/307406511","pull_request_review_id":266765265,"id":307406511,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzQwNjUxMQ==","diff_hunk":"@@ -31,12 +31,19 @@\n // class is available.\n public interface SpanExporter {\n \n+ enum ResultCode {\n+ SUCCESS,\n+ FAILED_RETRYABLE,\n+ FAILED_NONE_RETRYABLE\n+ }\n+\n /**\n * Called to export sampled {@code Span}s.\n *\n * @param spans the list of sampled Spans to be exported.\n+ * @return the result of the export. If","path":"sdk/src/main/java/io/opentelemetry/sdk/trace/export/SpanExporter.java","position":null,"original_position":14,"commit_id":"55ad669c58aa94ddd4fa3b88130ebd7594107a21","original_commit_id":"ecc2a5498aa676c71a3e0f66be1ad1718a665b30","user":{"login":"bogdandrutu","id":1373887,"node_id":"MDQ6VXNlcjEzNzM4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2019-07-25T17:10:29Z","updated_at":"2019-07-25T17:10:30Z","html_url":"https://github.com/open-telemetry/opentelemetry-java/pull/471#discussion_r307406511","pull_request_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/471","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/comments/307406511"},"html":{"href":"https://github.com/open-telemetry/opentelemetry-java/pull/471#discussion_r307406511"},"pull_request":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/471"}},"in_reply_to_id":307391351},"pull_request":{"url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/471","id":301190089,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMTkwMDg5","html_url":"https://github.com/open-telemetry/opentelemetry-java/pull/471","diff_url":"https://github.com/open-telemetry/opentelemetry-java/pull/471.diff","patch_url":"https://github.com/open-telemetry/opentelemetry-java/pull/471.patch","issue_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/issues/471","number":471,"state":"open","locked":false,"title":"Add ResultCode to the SpanExporter interface.","user":{"login":"bogdandrutu","id":1373887,"node_id":"MDQ6VXNlcjEzNzM4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},"body":"Based on the specification https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-exporter.md\r\n\r\n/cc @tigrannajaryan ","created_at":"2019-07-25T15:10:30Z","updated_at":"2019-07-25T17:10:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4e23b00e9ac4175ca8fe5a3b14756e26f4b1acf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carlosalberto","id":260065,"node_id":"MDQ6VXNlcjI2MDA2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/260065?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosalberto","html_url":"https://github.com/carlosalberto","followers_url":"https://api.github.com/users/carlosalberto/followers","following_url":"https://api.github.com/users/carlosalberto/following{/other_user}","gists_url":"https://api.github.com/users/carlosalberto/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosalberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosalberto/subscriptions","organizations_url":"https://api.github.com/users/carlosalberto/orgs","repos_url":"https://api.github.com/users/carlosalberto/repos","events_url":"https://api.github.com/users/carlosalberto/events{/privacy}","received_events_url":"https://api.github.com/users/carlosalberto/received_events","type":"User","site_admin":false},{"login":"tylerbenson","id":734411,"node_id":"MDQ6VXNlcjczNDQxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/734411?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerbenson","html_url":"https://github.com/tylerbenson","followers_url":"https://api.github.com/users/tylerbenson/followers","following_url":"https://api.github.com/users/tylerbenson/following{/other_user}","gists_url":"https://api.github.com/users/tylerbenson/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerbenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerbenson/subscriptions","organizations_url":"https://api.github.com/users/tylerbenson/orgs","repos_url":"https://api.github.com/users/tylerbenson/repos","events_url":"https://api.github.com/users/tylerbenson/events{/privacy}","received_events_url":"https://api.github.com/users/tylerbenson/received_events","type":"User","site_admin":false},{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/471/commits","review_comments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/471/comments","review_comment_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/issues/471/comments","statuses_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/statuses/55ad669c58aa94ddd4fa3b88130ebd7594107a21","head":{"label":"bogdandrutu:returncode","ref":"returncode","sha":"55ad669c58aa94ddd4fa3b88130ebd7594107a21","user":{"login":"bogdandrutu","id":1373887,"node_id":"MDQ6VXNlcjEzNzM4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},"repo":{"id":184468384,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ0NjgzODQ=","name":"opentelemetry-java","full_name":"bogdandrutu/opentelemetry-java","private":false,"owner":{"login":"bogdandrutu","id":1373887,"node_id":"MDQ6VXNlcjEzNzM4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bogdandrutu/opentelemetry-java","description":null,"fork":true,"url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java","forks_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/forks","keys_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/teams","hooks_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/hooks","issue_events_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/issues/events{/number}","events_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/events","assignees_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/assignees{/user}","branches_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/branches{/branch}","tags_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/tags","blobs_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/statuses/{sha}","languages_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/languages","stargazers_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/stargazers","contributors_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/contributors","subscribers_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/subscribers","subscription_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/subscription","commits_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/contents/{+path}","compare_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/merges","archive_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/downloads","issues_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/issues{/number}","pulls_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/pulls{/number}","milestones_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/milestones{/number}","notifications_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/labels{/name}","releases_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/releases{/id}","deployments_url":"https://api.github.com/repos/bogdandrutu/opentelemetry-java/deployments","created_at":"2019-05-01T19:16:41Z","updated_at":"2019-07-11T16:14:58Z","pushed_at":"2019-07-25T17:09:58Z","git_url":"git://github.com/bogdandrutu/opentelemetry-java.git","ssh_url":"[email protected]:bogdandrutu/opentelemetry-java.git","clone_url":"https://github.com/bogdandrutu/opentelemetry-java.git","svn_url":"https://github.com/bogdandrutu/opentelemetry-java","homepage":null,"size":1740,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-telemetry:master","ref":"master","sha":"0478651e34ede5960d6275626c97103e32470846","user":{"login":"open-telemetry","id":49998002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk4MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/49998002?v=4","gravatar_id":"","url":"https://api.github.com/users/open-telemetry","html_url":"https://github.com/open-telemetry","followers_url":"https://api.github.com/users/open-telemetry/followers","following_url":"https://api.github.com/users/open-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/open-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/open-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-telemetry/subscriptions","organizations_url":"https://api.github.com/users/open-telemetry/orgs","repos_url":"https://api.github.com/users/open-telemetry/repos","events_url":"https://api.github.com/users/open-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/open-telemetry/received_events","type":"Organization","site_admin":false},"repo":{"id":172750723,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI3NTA3MjM=","name":"opentelemetry-java","full_name":"open-telemetry/opentelemetry-java","private":false,"owner":{"login":"open-telemetry","id":49998002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk4MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/49998002?v=4","gravatar_id":"","url":"https://api.github.com/users/open-telemetry","html_url":"https://github.com/open-telemetry","followers_url":"https://api.github.com/users/open-telemetry/followers","following_url":"https://api.github.com/users/open-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/open-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/open-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-telemetry/subscriptions","organizations_url":"https://api.github.com/users/open-telemetry/orgs","repos_url":"https://api.github.com/users/open-telemetry/repos","events_url":"https://api.github.com/users/open-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/open-telemetry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-telemetry/opentelemetry-java","description":"OpenTelemetry Java SDK","fork":false,"url":"https://api.github.com/repos/open-telemetry/opentelemetry-java","forks_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/forks","keys_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/teams","hooks_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/hooks","issue_events_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/issues/events{/number}","events_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/events","assignees_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/assignees{/user}","branches_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/branches{/branch}","tags_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/tags","blobs_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/statuses/{sha}","languages_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/languages","stargazers_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/stargazers","contributors_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/contributors","subscribers_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/subscribers","subscription_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/subscription","commits_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/contents/{+path}","compare_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/merges","archive_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/downloads","issues_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/issues{/number}","pulls_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls{/number}","milestones_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/milestones{/number}","notifications_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/labels{/name}","releases_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/releases{/id}","deployments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-java/deployments","created_at":"2019-02-26T16:43:36Z","updated_at":"2019-07-24T21:45:01Z","pushed_at":"2019-07-25T17:09:59Z","git_url":"git://github.com/open-telemetry/opentelemetry-java.git","ssh_url":"[email protected]:open-telemetry/opentelemetry-java.git","clone_url":"https://github.com/open-telemetry/opentelemetry-java.git","svn_url":"https://github.com/open-telemetry/opentelemetry-java","homepage":"","size":1691,"stargazers_count":134,"watchers_count":134,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":33,"open_issues":37,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/471"},"html":{"href":"https://github.com/open-telemetry/opentelemetry-java/pull/471"},"issue":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-java/issues/471"},"comments":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-java/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-java/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-java/statuses/55ad669c58aa94ddd4fa3b88130ebd7594107a21"}},"author_association":"MEMBER"}}
|
{
"id": 172750723,
"name": "open-telemetry/opentelemetry-java",
"url": "https://api.github.com/repos/open-telemetry/opentelemetry-java"
}
|
{
"id": 1373887,
"login": "bogdandrutu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1373887?",
"url": "https://api.github.com/users/bogdandrutu"
}
|
{
"id": 49998002,
"login": "open-telemetry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49998002?",
"url": "https://api.github.com/orgs/open-telemetry"
}
| 2019-07-25T17:10:29 |
10085066769
|
{"actor":{"display_login":"bogdandrutu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/comments/305986484","pull_request_review_id":264997003,"id":305986484,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTk4NjQ4NA==","diff_hunk":"@@ -0,0 +1,86 @@\n+# Exporter Interface\n+\n+`Exporter` defines the interface that protocol-specific exporters must implement so that they can be plugged into OpenTelemetry SDK and support sending of telemetry data.\n+\n+The goals of the interface are:\n+\n+- Minimize burden of implementation for protocol-dependent telemetry exporters. The protocol exporter is expected to be primarily a simple telemetry data encoder and transmitter.\n+\n+- Allow implementing helpers as composable components that use the same chainable `Exporter` interface. SDK authors are encouraged to implement common functionality such as queuing, batching, tagging, etc. as helpers. This functionality will be applicable regardless of what protocol exporter is used.\n+\n+## Interface Definition\n+\n+The exporter must support two functions: **Export** and **Shutdown**. In strongly typed languages typically there will be 2 separate `Exporter` interfaces, one that accepts spans (SpanExporter) and one that accepts metrics (MetricsExporter).\n+\n+### Export(batch)\n+\n+Exports a batch of telemetry data. Protocol exporters that will implement this function are typically expected to serialize and transmit the data to the destination.\n+\n+Export() will never be called concurrently for the same exporter instance. Export() can be called again only after the current call returns.\n+\n+Export() must not block indefinitely, there must be a reasonable upper limit after which the call must time out with an error result (typically CannotExport).\n+\n+**Parameters:**\n+\n+batch - a batch of telemetry data. The exact data type of the batch is language specific, typically it is a list of telemetry items, e.g. for spans in Java it will be typically `Collection<ExportableSpan>` \n+\n+Note that the data type for a span for illustration purposes here is written as an imaginary type ExportableSpan (similarly for metrics it would be e.g. ExportableMetrics). The actual data type must be specified by language library authors, it should be able to represent the span data that can be read by the exporter.\n+\n+**Returns:** ExportResult:\n+\n+ExportResult is one of:\n+\n+- Success - batch is successfully exported. For protocol exporters this typically means that the data is sent over the wire and delivered to the destination server.\n+\n+- FailedFatal - exporting failed. The caller must not retry exporting the same batch. The batch must be dropped. This for example can happen when the batch contains bad data and cannot be serialized.\n+\n+- FailedRetryable - cannot export to the destination. The caller should record the error and may retry exporting the same batch after some time. This for example can happen when the destination is unavailable, there is a network error or endpoint does not exist. \n+\n+### Shutdown()\n+\n+Shuts down the exporter. Called when SDK is shut down. This is an opportunity for exporter to do any cleanup required.\n+\n+## Further Language Specialization\n+\n+Based on the generic interface definition layed out above library authors must define the exact interface for the particular language. \n+\n+Authors are encouraged to use efficient data structures on the interface boundary that are well suited for fast serialization to wire formats by protocol exporters and minimize the pressure on memory managers. The latter typically requires understanding of how to optimize the rapidly-generated, short-lived telemetry data structures to make life easier for the memory manager of the specific language. General recommendation is to minimize the number of allocations and use allocation arenas where possible, thus avoiding explosion of allocation/deallocation/collection operations in the presence of high rate of telemetry data generation.\n+\n+### Examples\n+\n+These are examples on what the `Exporter` interface can look like in specific languages. Examples are for illustration purposes only. Language library authors are free to deviate from these provided that their design remain true to the spirit of `Exporter` concept.\n+\n+#### Go SpanExporter Interface\n+\n+```go\n+type SpanExporter interface {\n+ Export(batch []ExportableSpan) ExportResult\n+ Shutdown()\n+}\n+\n+type ExportResult struct {\n+ Code ExportResultCode\n+ WrappedError error\n+}\n+\n+type ExportResultCode int\n+\n+const (\n+ Success ExportResultCode = iota\n+ FailedFatal","path":"specification/sdk-exporter.md","position":null,"original_position":70,"commit_id":"c83e30356998516dcd6536f91b9d0edfe5ca8df1","original_commit_id":"a4133b192409b1689d776ca5cc40a85a6adc0145","user":{"login":"tigrannajaryan","id":4194920,"node_id":"MDQ6VXNlcjQxOTQ5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/4194920?v=4","gravatar_id":"","url":"https://api.github.com/users/tigrannajaryan","html_url":"https://github.com/tigrannajaryan","followers_url":"https://api.github.com/users/tigrannajaryan/followers","following_url":"https://api.github.com/users/tigrannajaryan/following{/other_user}","gists_url":"https://api.github.com/users/tigrannajaryan/gists{/gist_id}","starred_url":"https://api.github.com/users/tigrannajaryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigrannajaryan/subscriptions","organizations_url":"https://api.github.com/users/tigrannajaryan/orgs","repos_url":"https://api.github.com/users/tigrannajaryan/repos","events_url":"https://api.github.com/users/tigrannajaryan/events{/privacy}","received_events_url":"https://api.github.com/users/tigrannajaryan/received_events","type":"User","site_admin":false},"body":"Changed to `FailedNoneRetryable`.","created_at":"2019-07-22T19:07:24Z","updated_at":"2019-07-22T19:07:25Z","html_url":"https://github.com/open-telemetry/opentelemetry-specification/pull/186#discussion_r305986484","pull_request_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/186","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/comments/305986484"},"html":{"href":"https://github.com/open-telemetry/opentelemetry-specification/pull/186#discussion_r305986484"},"pull_request":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/186"}},"in_reply_to_id":305960732},"pull_request":{"url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/186","id":299014572,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5MDE0NTcy","html_url":"https://github.com/open-telemetry/opentelemetry-specification/pull/186","diff_url":"https://github.com/open-telemetry/opentelemetry-specification/pull/186.diff","patch_url":"https://github.com/open-telemetry/opentelemetry-specification/pull/186.patch","issue_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/issues/186","number":186,"state":"open","locked":false,"title":"Add exporter API and more details about SDK implementation","user":{"login":"tigrannajaryan","id":4194920,"node_id":"MDQ6VXNlcjQxOTQ5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/4194920?v=4","gravatar_id":"","url":"https://api.github.com/users/tigrannajaryan","html_url":"https://github.com/tigrannajaryan","followers_url":"https://api.github.com/users/tigrannajaryan/followers","following_url":"https://api.github.com/users/tigrannajaryan/following{/other_user}","gists_url":"https://api.github.com/users/tigrannajaryan/gists{/gist_id}","starred_url":"https://api.github.com/users/tigrannajaryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigrannajaryan/subscriptions","organizations_url":"https://api.github.com/users/tigrannajaryan/orgs","repos_url":"https://api.github.com/users/tigrannajaryan/repos","events_url":"https://api.github.com/users/tigrannajaryan/events{/privacy}","received_events_url":"https://api.github.com/users/tigrannajaryan/received_events","type":"User","site_admin":false},"body":"This clarifies what functionality should be the core part of\r\nthe SDK and what should be available for optional usage and\r\nalso defines the API that exporters need to define.\r\n\r\nCo-authored with @bogdandrutu ","created_at":"2019-07-18T17:21:00Z","updated_at":"2019-07-22T19:07:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84e181e8b42b5864a72ed1f9a952c112f5ff5d3d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tedsuo","id":24074,"node_id":"MDQ6VXNlcjI0MDc0","avatar_url":"https://avatars2.githubusercontent.com/u/24074?v=4","gravatar_id":"","url":"https://api.github.com/users/tedsuo","html_url":"https://github.com/tedsuo","followers_url":"https://api.github.com/users/tedsuo/followers","following_url":"https://api.github.com/users/tedsuo/following{/other_user}","gists_url":"https://api.github.com/users/tedsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/tedsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedsuo/subscriptions","organizations_url":"https://api.github.com/users/tedsuo/orgs","repos_url":"https://api.github.com/users/tedsuo/repos","events_url":"https://api.github.com/users/tedsuo/events{/privacy}","received_events_url":"https://api.github.com/users/tedsuo/received_events","type":"User","site_admin":false},{"login":"carlosalberto","id":260065,"node_id":"MDQ6VXNlcjI2MDA2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/260065?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosalberto","html_url":"https://github.com/carlosalberto","followers_url":"https://api.github.com/users/carlosalberto/followers","following_url":"https://api.github.com/users/carlosalberto/following{/other_user}","gists_url":"https://api.github.com/users/carlosalberto/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosalberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosalberto/subscriptions","organizations_url":"https://api.github.com/users/carlosalberto/orgs","repos_url":"https://api.github.com/users/carlosalberto/repos","events_url":"https://api.github.com/users/carlosalberto/events{/privacy}","received_events_url":"https://api.github.com/users/carlosalberto/received_events","type":"User","site_admin":false},{"login":"AloisReitbauer","id":478193,"node_id":"MDQ6VXNlcjQ3ODE5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/478193?v=4","gravatar_id":"","url":"https://api.github.com/users/AloisReitbauer","html_url":"https://github.com/AloisReitbauer","followers_url":"https://api.github.com/users/AloisReitbauer/followers","following_url":"https://api.github.com/users/AloisReitbauer/following{/other_user}","gists_url":"https://api.github.com/users/AloisReitbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/AloisReitbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AloisReitbauer/subscriptions","organizations_url":"https://api.github.com/users/AloisReitbauer/orgs","repos_url":"https://api.github.com/users/AloisReitbauer/repos","events_url":"https://api.github.com/users/AloisReitbauer/events{/privacy}","received_events_url":"https://api.github.com/users/AloisReitbauer/received_events","type":"User","site_admin":false},{"login":"bogdandrutu","id":1373887,"node_id":"MDQ6VXNlcjEzNzM4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},{"login":"iredelmeier","id":3298606,"node_id":"MDQ6VXNlcjMyOTg2MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3298606?v=4","gravatar_id":"","url":"https://api.github.com/users/iredelmeier","html_url":"https://github.com/iredelmeier","followers_url":"https://api.github.com/users/iredelmeier/followers","following_url":"https://api.github.com/users/iredelmeier/following{/other_user}","gists_url":"https://api.github.com/users/iredelmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/iredelmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iredelmeier/subscriptions","organizations_url":"https://api.github.com/users/iredelmeier/orgs","repos_url":"https://api.github.com/users/iredelmeier/repos","events_url":"https://api.github.com/users/iredelmeier/events{/privacy}","received_events_url":"https://api.github.com/users/iredelmeier/received_events","type":"User","site_admin":false},{"login":"yurishkuro","id":3523016,"node_id":"MDQ6VXNlcjM1MjMwMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3523016?v=4","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},{"login":"SergeyKanzhelev","id":9950081,"node_id":"MDQ6VXNlcjk5NTAwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/9950081?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyKanzhelev","html_url":"https://github.com/SergeyKanzhelev","followers_url":"https://api.github.com/users/SergeyKanzhelev/followers","following_url":"https://api.github.com/users/SergeyKanzhelev/following{/other_user}","gists_url":"https://api.github.com/users/SergeyKanzhelev/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyKanzhelev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyKanzhelev/subscriptions","organizations_url":"https://api.github.com/users/SergeyKanzhelev/orgs","repos_url":"https://api.github.com/users/SergeyKanzhelev/repos","events_url":"https://api.github.com/users/SergeyKanzhelev/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyKanzhelev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/186/commits","review_comments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/186/comments","review_comment_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/issues/186/comments","statuses_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/statuses/c83e30356998516dcd6536f91b9d0edfe5ca8df1","head":{"label":"tigrannajaryan:feature/tigran/libguide","ref":"feature/tigran/libguide","sha":"c83e30356998516dcd6536f91b9d0edfe5ca8df1","user":{"login":"tigrannajaryan","id":4194920,"node_id":"MDQ6VXNlcjQxOTQ5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/4194920?v=4","gravatar_id":"","url":"https://api.github.com/users/tigrannajaryan","html_url":"https://github.com/tigrannajaryan","followers_url":"https://api.github.com/users/tigrannajaryan/followers","following_url":"https://api.github.com/users/tigrannajaryan/following{/other_user}","gists_url":"https://api.github.com/users/tigrannajaryan/gists{/gist_id}","starred_url":"https://api.github.com/users/tigrannajaryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigrannajaryan/subscriptions","organizations_url":"https://api.github.com/users/tigrannajaryan/orgs","repos_url":"https://api.github.com/users/tigrannajaryan/repos","events_url":"https://api.github.com/users/tigrannajaryan/events{/privacy}","received_events_url":"https://api.github.com/users/tigrannajaryan/received_events","type":"User","site_admin":false},"repo":{"id":190633252,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA2MzMyNTI=","name":"opentelemetry-specification","full_name":"tigrannajaryan/opentelemetry-specification","private":false,"owner":{"login":"tigrannajaryan","id":4194920,"node_id":"MDQ6VXNlcjQxOTQ5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/4194920?v=4","gravatar_id":"","url":"https://api.github.com/users/tigrannajaryan","html_url":"https://github.com/tigrannajaryan","followers_url":"https://api.github.com/users/tigrannajaryan/followers","following_url":"https://api.github.com/users/tigrannajaryan/following{/other_user}","gists_url":"https://api.github.com/users/tigrannajaryan/gists{/gist_id}","starred_url":"https://api.github.com/users/tigrannajaryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigrannajaryan/subscriptions","organizations_url":"https://api.github.com/users/tigrannajaryan/orgs","repos_url":"https://api.github.com/users/tigrannajaryan/repos","events_url":"https://api.github.com/users/tigrannajaryan/events{/privacy}","received_events_url":"https://api.github.com/users/tigrannajaryan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tigrannajaryan/opentelemetry-specification","description":"Specifications for OpenTelemetry","fork":true,"url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification","forks_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/forks","keys_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/teams","hooks_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/hooks","issue_events_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/issues/events{/number}","events_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/events","assignees_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/assignees{/user}","branches_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/branches{/branch}","tags_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/tags","blobs_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/statuses/{sha}","languages_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/languages","stargazers_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/stargazers","contributors_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/contributors","subscribers_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/subscribers","subscription_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/subscription","commits_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/contents/{+path}","compare_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/merges","archive_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/downloads","issues_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/issues{/number}","pulls_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/pulls{/number}","milestones_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/milestones{/number}","notifications_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/labels{/name}","releases_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/releases{/id}","deployments_url":"https://api.github.com/repos/tigrannajaryan/opentelemetry-specification/deployments","created_at":"2019-06-06T18:50:30Z","updated_at":"2019-07-15T19:04:41Z","pushed_at":"2019-07-22T19:06:51Z","git_url":"git://github.com/tigrannajaryan/opentelemetry-specification.git","ssh_url":"[email protected]:tigrannajaryan/opentelemetry-specification.git","clone_url":"https://github.com/tigrannajaryan/opentelemetry-specification.git","svn_url":"https://github.com/tigrannajaryan/opentelemetry-specification","homepage":"https://opentelemetry.io","size":243,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-telemetry:master","ref":"master","sha":"0a5e76f86383bc23aca9ca5811a9648b9fd09ba0","user":{"login":"open-telemetry","id":49998002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk4MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/49998002?v=4","gravatar_id":"","url":"https://api.github.com/users/open-telemetry","html_url":"https://github.com/open-telemetry","followers_url":"https://api.github.com/users/open-telemetry/followers","following_url":"https://api.github.com/users/open-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/open-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/open-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-telemetry/subscriptions","organizations_url":"https://api.github.com/users/open-telemetry/orgs","repos_url":"https://api.github.com/users/open-telemetry/repos","events_url":"https://api.github.com/users/open-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/open-telemetry/received_events","type":"Organization","site_admin":false},"repo":{"id":184463891,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ0NjM4OTE=","name":"opentelemetry-specification","full_name":"open-telemetry/opentelemetry-specification","private":false,"owner":{"login":"open-telemetry","id":49998002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk4MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/49998002?v=4","gravatar_id":"","url":"https://api.github.com/users/open-telemetry","html_url":"https://github.com/open-telemetry","followers_url":"https://api.github.com/users/open-telemetry/followers","following_url":"https://api.github.com/users/open-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/open-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/open-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-telemetry/subscriptions","organizations_url":"https://api.github.com/users/open-telemetry/orgs","repos_url":"https://api.github.com/users/open-telemetry/repos","events_url":"https://api.github.com/users/open-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/open-telemetry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-telemetry/opentelemetry-specification","description":"Specifications for OpenTelemetry","fork":false,"url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification","forks_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/forks","keys_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/teams","hooks_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/hooks","issue_events_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/issues/events{/number}","events_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/events","assignees_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/assignees{/user}","branches_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/branches{/branch}","tags_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/tags","blobs_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/statuses/{sha}","languages_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/languages","stargazers_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/stargazers","contributors_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/contributors","subscribers_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/subscribers","subscription_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/subscription","commits_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/contents/{+path}","compare_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/merges","archive_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/downloads","issues_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/issues{/number}","pulls_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls{/number}","milestones_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/milestones{/number}","notifications_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/labels{/name}","releases_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/releases{/id}","deployments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/deployments","created_at":"2019-05-01T18:41:36Z","updated_at":"2019-07-22T03:17:03Z","pushed_at":"2019-07-22T19:06:53Z","git_url":"git://github.com/open-telemetry/opentelemetry-specification.git","ssh_url":"[email protected]:open-telemetry/opentelemetry-specification.git","clone_url":"https://github.com/open-telemetry/opentelemetry-specification.git","svn_url":"https://github.com/open-telemetry/opentelemetry-specification","homepage":"https://opentelemetry.io","size":188,"stargazers_count":142,"watchers_count":142,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":88,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":88,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/186"},"html":{"href":"https://github.com/open-telemetry/opentelemetry-specification/pull/186"},"issue":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/issues/186"},"comments":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-specification/statuses/c83e30356998516dcd6536f91b9d0edfe5ca8df1"}},"author_association":"MEMBER"}}
|
{
"id": 184463891,
"name": "open-telemetry/opentelemetry-specification",
"url": "https://api.github.com/repos/open-telemetry/opentelemetry-specification"
}
|
{
"id": 4194920,
"login": "tigrannajaryan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4194920?",
"url": "https://api.github.com/users/tigrannajaryan"
}
|
{
"id": 49998002,
"login": "open-telemetry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49998002?",
"url": "https://api.github.com/orgs/open-telemetry"
}
| 2019-07-22T19:07:24 |
10060555738
|
{"actor":{"display_login":"tigrannajaryan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/comments/337159614","pull_request_review_id":304746362,"id":337159614,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzE1OTYxNA==","diff_hunk":"@@ -181,16 +178,16 @@ func createAndRegisterBatchSP(t *testing.T, option testOption, te *testBatchExpo\n \tif ssp == nil {\n \t\tt.Errorf(\"%s: Error creating new instance of BatchSpanProcessor, error: %v\\n\", option.name, err)\n \t}\n-\tsdktrace.RegisterSpanProcessor(ssp)\n+\t//sdktrace.RegisterSpanProcessor(ssp)","path":"sdk/trace/batch_span_processor_test.go","position":44,"original_position":44,"commit_id":"c94f54c89bfdd7f7c43003777ff9cf010b584532","original_commit_id":"c94f54c89bfdd7f7c43003777ff9cf010b584532","user":{"login":"akvanhar","id":10929533,"node_id":"MDQ6VXNlcjEwOTI5NTMz","avatar_url":"https://avatars1.githubusercontent.com/u/10929533?v=4","gravatar_id":"","url":"https://api.github.com/users/akvanhar","html_url":"https://github.com/akvanhar","followers_url":"https://api.github.com/users/akvanhar/followers","following_url":"https://api.github.com/users/akvanhar/following{/other_user}","gists_url":"https://api.github.com/users/akvanhar/gists{/gist_id}","starred_url":"https://api.github.com/users/akvanhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvanhar/subscriptions","organizations_url":"https://api.github.com/users/akvanhar/orgs","repos_url":"https://api.github.com/users/akvanhar/repos","events_url":"https://api.github.com/users/akvanhar/events{/privacy}","received_events_url":"https://api.github.com/users/akvanhar/received_events","type":"User","site_admin":false},"body":"delete this comment","created_at":"2019-10-21T18:02:35Z","updated_at":"2019-10-21T18:02:35Z","html_url":"https://github.com/open-telemetry/opentelemetry-go/pull/227#discussion_r337159614","pull_request_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/227","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/comments/337159614"},"html":{"href":"https://github.com/open-telemetry/opentelemetry-go/pull/227#discussion_r337159614"},"pull_request":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/227","id":330420542,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwNDIwNTQy","html_url":"https://github.com/open-telemetry/opentelemetry-go/pull/227","diff_url":"https://github.com/open-telemetry/opentelemetry-go/pull/227.diff","patch_url":"https://github.com/open-telemetry/opentelemetry-go/pull/227.patch","issue_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/issues/227","number":227,"state":"open","locked":false,"title":"WIP: Named tracer prototype","user":{"login":"rghetia","id":8052115,"node_id":"MDQ6VXNlcjgwNTIxMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8052115?v=4","gravatar_id":"","url":"https://api.github.com/users/rghetia","html_url":"https://github.com/rghetia","followers_url":"https://api.github.com/users/rghetia/followers","following_url":"https://api.github.com/users/rghetia/following{/other_user}","gists_url":"https://api.github.com/users/rghetia/gists{/gist_id}","starred_url":"https://api.github.com/users/rghetia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rghetia/subscriptions","organizations_url":"https://api.github.com/users/rghetia/orgs","repos_url":"https://api.github.com/users/rghetia/repos","events_url":"https://api.github.com/users/rghetia/events{/privacy}","received_events_url":"https://api.github.com/users/rghetia/received_events","type":"User","site_admin":false},"body":"This is a prototype for named tracer. What is in here?\r\n- Global Provider Register (instead of Tracer Registry). This may not be required.\r\n- SDK provides NewProvider method to create instance of Provider. Multiple provider instance can be created. This can help to parallelized testing.\r\n - It accepts optional parameter to associate exporters and configuration (sampler and other parameters) during instance creation.\r\n - exporters and configuration can also be applied at a later time.\r\n- Some Tests are updated to created its own provider. Remove reference to global tracer.\r\n - few tests still uses Global Tracer.\r\n","created_at":"2019-10-21T13:56:51Z","updated_at":"2019-10-21T18:02:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"tedsuo","id":24074,"node_id":"MDQ6VXNlcjI0MDc0","avatar_url":"https://avatars2.githubusercontent.com/u/24074?v=4","gravatar_id":"","url":"https://api.github.com/users/tedsuo","html_url":"https://github.com/tedsuo","followers_url":"https://api.github.com/users/tedsuo/followers","following_url":"https://api.github.com/users/tedsuo/following{/other_user}","gists_url":"https://api.github.com/users/tedsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/tedsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedsuo/subscriptions","organizations_url":"https://api.github.com/users/tedsuo/orgs","repos_url":"https://api.github.com/users/tedsuo/repos","events_url":"https://api.github.com/users/tedsuo/events{/privacy}","received_events_url":"https://api.github.com/users/tedsuo/received_events","type":"User","site_admin":false},{"login":"bogdandrutu","id":1373887,"node_id":"MDQ6VXNlcjEzNzM4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},{"login":"sjkaris","id":3521754,"node_id":"MDQ6VXNlcjM1MjE3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3521754?v=4","gravatar_id":"","url":"https://api.github.com/users/sjkaris","html_url":"https://github.com/sjkaris","followers_url":"https://api.github.com/users/sjkaris/followers","following_url":"https://api.github.com/users/sjkaris/following{/other_user}","gists_url":"https://api.github.com/users/sjkaris/gists{/gist_id}","starred_url":"https://api.github.com/users/sjkaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjkaris/subscriptions","organizations_url":"https://api.github.com/users/sjkaris/orgs","repos_url":"https://api.github.com/users/sjkaris/repos","events_url":"https://api.github.com/users/sjkaris/events{/privacy}","received_events_url":"https://api.github.com/users/sjkaris/received_events","type":"User","site_admin":false},{"login":"pjanotti","id":5600755,"node_id":"MDQ6VXNlcjU2MDA3NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5600755?v=4","gravatar_id":"","url":"https://api.github.com/users/pjanotti","html_url":"https://github.com/pjanotti","followers_url":"https://api.github.com/users/pjanotti/followers","following_url":"https://api.github.com/users/pjanotti/following{/other_user}","gists_url":"https://api.github.com/users/pjanotti/gists{/gist_id}","starred_url":"https://api.github.com/users/pjanotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjanotti/subscriptions","organizations_url":"https://api.github.com/users/pjanotti/orgs","repos_url":"https://api.github.com/users/pjanotti/repos","events_url":"https://api.github.com/users/pjanotti/events{/privacy}","received_events_url":"https://api.github.com/users/pjanotti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/227/commits","review_comments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/227/comments","review_comment_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/issues/227/comments","statuses_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/statuses/c94f54c89bfdd7f7c43003777ff9cf010b584532","head":{"label":"rghetia:named_tracer","ref":"named_tracer","sha":"c94f54c89bfdd7f7c43003777ff9cf010b584532","user":{"login":"rghetia","id":8052115,"node_id":"MDQ6VXNlcjgwNTIxMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8052115?v=4","gravatar_id":"","url":"https://api.github.com/users/rghetia","html_url":"https://github.com/rghetia","followers_url":"https://api.github.com/users/rghetia/followers","following_url":"https://api.github.com/users/rghetia/following{/other_user}","gists_url":"https://api.github.com/users/rghetia/gists{/gist_id}","starred_url":"https://api.github.com/users/rghetia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rghetia/subscriptions","organizations_url":"https://api.github.com/users/rghetia/orgs","repos_url":"https://api.github.com/users/rghetia/repos","events_url":"https://api.github.com/users/rghetia/events{/privacy}","received_events_url":"https://api.github.com/users/rghetia/received_events","type":"User","site_admin":false},"repo":{"id":191990759,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE5OTA3NTk=","name":"opentelemetry-go","full_name":"rghetia/opentelemetry-go","private":false,"owner":{"login":"rghetia","id":8052115,"node_id":"MDQ6VXNlcjgwNTIxMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8052115?v=4","gravatar_id":"","url":"https://api.github.com/users/rghetia","html_url":"https://github.com/rghetia","followers_url":"https://api.github.com/users/rghetia/followers","following_url":"https://api.github.com/users/rghetia/following{/other_user}","gists_url":"https://api.github.com/users/rghetia/gists{/gist_id}","starred_url":"https://api.github.com/users/rghetia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rghetia/subscriptions","organizations_url":"https://api.github.com/users/rghetia/orgs","repos_url":"https://api.github.com/users/rghetia/repos","events_url":"https://api.github.com/users/rghetia/events{/privacy}","received_events_url":"https://api.github.com/users/rghetia/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rghetia/opentelemetry-go","description":null,"fork":true,"url":"https://api.github.com/repos/rghetia/opentelemetry-go","forks_url":"https://api.github.com/repos/rghetia/opentelemetry-go/forks","keys_url":"https://api.github.com/repos/rghetia/opentelemetry-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rghetia/opentelemetry-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rghetia/opentelemetry-go/teams","hooks_url":"https://api.github.com/repos/rghetia/opentelemetry-go/hooks","issue_events_url":"https://api.github.com/repos/rghetia/opentelemetry-go/issues/events{/number}","events_url":"https://api.github.com/repos/rghetia/opentelemetry-go/events","assignees_url":"https://api.github.com/repos/rghetia/opentelemetry-go/assignees{/user}","branches_url":"https://api.github.com/repos/rghetia/opentelemetry-go/branches{/branch}","tags_url":"https://api.github.com/repos/rghetia/opentelemetry-go/tags","blobs_url":"https://api.github.com/repos/rghetia/opentelemetry-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rghetia/opentelemetry-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rghetia/opentelemetry-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/rghetia/opentelemetry-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rghetia/opentelemetry-go/statuses/{sha}","languages_url":"https://api.github.com/repos/rghetia/opentelemetry-go/languages","stargazers_url":"https://api.github.com/repos/rghetia/opentelemetry-go/stargazers","contributors_url":"https://api.github.com/repos/rghetia/opentelemetry-go/contributors","subscribers_url":"https://api.github.com/repos/rghetia/opentelemetry-go/subscribers","subscription_url":"https://api.github.com/repos/rghetia/opentelemetry-go/subscription","commits_url":"https://api.github.com/repos/rghetia/opentelemetry-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/rghetia/opentelemetry-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/rghetia/opentelemetry-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/rghetia/opentelemetry-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/rghetia/opentelemetry-go/contents/{+path}","compare_url":"https://api.github.com/repos/rghetia/opentelemetry-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rghetia/opentelemetry-go/merges","archive_url":"https://api.github.com/repos/rghetia/opentelemetry-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rghetia/opentelemetry-go/downloads","issues_url":"https://api.github.com/repos/rghetia/opentelemetry-go/issues{/number}","pulls_url":"https://api.github.com/repos/rghetia/opentelemetry-go/pulls{/number}","milestones_url":"https://api.github.com/repos/rghetia/opentelemetry-go/milestones{/number}","notifications_url":"https://api.github.com/repos/rghetia/opentelemetry-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rghetia/opentelemetry-go/labels{/name}","releases_url":"https://api.github.com/repos/rghetia/opentelemetry-go/releases{/id}","deployments_url":"https://api.github.com/repos/rghetia/opentelemetry-go/deployments","created_at":"2019-06-14T18:43:01Z","updated_at":"2019-10-16T18:06:57Z","pushed_at":"2019-10-21T13:38:21Z","git_url":"git://github.com/rghetia/opentelemetry-go.git","ssh_url":"[email protected]:rghetia/opentelemetry-go.git","clone_url":"https://github.com/rghetia/opentelemetry-go.git","svn_url":"https://github.com/rghetia/opentelemetry-go","homepage":null,"size":765,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-telemetry:master","ref":"master","sha":"1191a07836765fa53af3ae1264ec42992f9d872f","user":{"login":"open-telemetry","id":49998002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk4MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/49998002?v=4","gravatar_id":"","url":"https://api.github.com/users/open-telemetry","html_url":"https://github.com/open-telemetry","followers_url":"https://api.github.com/users/open-telemetry/followers","following_url":"https://api.github.com/users/open-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/open-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/open-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-telemetry/subscriptions","organizations_url":"https://api.github.com/users/open-telemetry/orgs","repos_url":"https://api.github.com/users/open-telemetry/repos","events_url":"https://api.github.com/users/open-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/open-telemetry/received_events","type":"Organization","site_admin":false},"repo":{"id":187086161,"node_id":"MDEwOlJlcG9zaXRvcnkxODcwODYxNjE=","name":"opentelemetry-go","full_name":"open-telemetry/opentelemetry-go","private":false,"owner":{"login":"open-telemetry","id":49998002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTk4MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/49998002?v=4","gravatar_id":"","url":"https://api.github.com/users/open-telemetry","html_url":"https://github.com/open-telemetry","followers_url":"https://api.github.com/users/open-telemetry/followers","following_url":"https://api.github.com/users/open-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/open-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/open-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-telemetry/subscriptions","organizations_url":"https://api.github.com/users/open-telemetry/orgs","repos_url":"https://api.github.com/users/open-telemetry/repos","events_url":"https://api.github.com/users/open-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/open-telemetry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-telemetry/opentelemetry-go","description":null,"fork":false,"url":"https://api.github.com/repos/open-telemetry/opentelemetry-go","forks_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/forks","keys_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/teams","hooks_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/hooks","issue_events_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/issues/events{/number}","events_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/events","assignees_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/assignees{/user}","branches_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/branches{/branch}","tags_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/tags","blobs_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/statuses/{sha}","languages_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/languages","stargazers_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/stargazers","contributors_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/contributors","subscribers_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/subscribers","subscription_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/subscription","commits_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/contents/{+path}","compare_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/merges","archive_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/downloads","issues_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/issues{/number}","pulls_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls{/number}","milestones_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/milestones{/number}","notifications_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/labels{/name}","releases_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/releases{/id}","deployments_url":"https://api.github.com/repos/open-telemetry/opentelemetry-go/deployments","created_at":"2019-05-16T19:05:26Z","updated_at":"2019-10-21T17:25:51Z","pushed_at":"2019-10-21T17:15:51Z","git_url":"git://github.com/open-telemetry/opentelemetry-go.git","ssh_url":"[email protected]:open-telemetry/opentelemetry-go.git","clone_url":"https://github.com/open-telemetry/opentelemetry-go.git","svn_url":"https://github.com/open-telemetry/opentelemetry-go","homepage":null,"size":726,"stargazers_count":222,"watchers_count":222,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":56,"open_issues":57,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/227"},"html":{"href":"https://github.com/open-telemetry/opentelemetry-go/pull/227"},"issue":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-go/issues/227"},"comments":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-go/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-go/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/open-telemetry/opentelemetry-go/statuses/c94f54c89bfdd7f7c43003777ff9cf010b584532"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 187086161,
"name": "open-telemetry/opentelemetry-go",
"url": "https://api.github.com/repos/open-telemetry/opentelemetry-go"
}
|
{
"id": 10929533,
"login": "akvanhar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10929533?",
"url": "https://api.github.com/users/akvanhar"
}
|
{
"id": 49998002,
"login": "open-telemetry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49998002?",
"url": "https://api.github.com/orgs/open-telemetry"
}
| 2019-10-21T18:02:35 |
10678820052
|
{"actor":{"display_login":"akvanhar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/comments/313946857","pull_request_review_id":274978408,"id":313946857,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzk0Njg1Nw==","diff_hunk":"@@ -0,0 +1,143 @@\n+//\n+// DrawerViewController.swift\n+// zScanner\n+//\n+// Created by Martin Georgiu on 10/08/2019.\n+// Copyright ยฉ 2019 Institut klinickรฉ a experimentรกlnรญ medicรญny. All rights reserved.\n+//\n+\n+import UIKit\n+\n+protocol DrawerCoordinator: BaseCoordinator {\n+ func closeDrawer()\n+ func logout()\n+ func deleteHistory()\n+ func showAbout()\n+}\n+\n+\n+class DrawerViewController: BaseViewController {\n+ private unowned let coordinator: DrawerCoordinator\n+ \n+ init(coordinator: DrawerCoordinator) {\n+ self.coordinator = coordinator\n+ \n+ super.init(coordinator: coordinator)\n+ }\n+ \n+ override func viewWillAppear(_ animated: Bool) {\n+ super.viewWillAppear(animated)\n+ \n+ setupView()\n+ }\n+ \n+ private lazy var drawerMenuItems: [String] = [\n+ \"drawer.logout.title\".localized,\n+ \"drawer.deleteHistory.title\".localized,\n+ \"drawer.aboutApp.title\".localized\n+ ]\n+\n+ \n+ private lazy var drawerLogo: UIImageView = {\n+ let imageView = UIImageView()\n+ imageView.image = UIImage(named: \"menuLogo\")\n+ imageView.contentMode = UIView.ContentMode.scaleAspectFit\n+ return imageView\n+ }()\n+ private lazy var drawerTopLabel: UILabel = {\n+ let label = UILabel()\n+ label.text = \"zScanner\"\n+ label.textColor = .white\n+ label.font = label.font.withSize(25)\n+ return label\n+ }()\n+ private lazy var topStackView: UIStackView = {\n+ let stackView = UIStackView(arrangedSubviews: [drawerLogo,drawerTopLabel])\n+ stackView.axis = .vertical\n+ stackView.alignment = .top\n+ stackView.translatesAutoresizingMaskIntoConstraints = false\n+ stackView.spacing = 10\n+ stackView.isLayoutMarginsRelativeArrangement = true\n+ stackView.spacing = UIStackView.spacingUseSystem\n+\n+ stackView.addBackground(color: .primary)\n+ return stackView\n+ }()\n+ \n+ private func drawerMakeMenuButtons (_ names: [String]) -> [DrawerMenuButton] {\n+ var drawerMenu: [DrawerMenuButton] = []\n+ \n+ for drawerMenuItem in drawerMenuItems {\n+ let button = DrawerMenuButton()\n+ button.setTitle(drawerMenuItem, for: .normal)\n+ button.addTarget(self, action: #selector(handleMenuTap(_:)), for: .touchUpInside)\n+\n+ drawerMenu.append(button)\n+ }\n+ return drawerMenu\n+ \n+ }\n+ private lazy var menuStackView: UIStackView = {\n+ let stackView = UIStackView(arrangedSubviews: drawerMakeMenuButtons(drawerMenuItems))\n+ stackView.axis = .vertical\n+ stackView.translatesAutoresizingMaskIntoConstraints = false\n+ stackView.spacing = 10\n+ stackView.distribution = .fill\n+ return stackView\n+ }()\n+ \n+\n+ private func setupView() {\n+ view.addSubview(topStackView)\n+ view.addSubview(menuStackView)\n+ \n+ topStackView.layoutMargins = UIEdgeInsets(top: 20, left: 20, bottom: 20, right: 20)\n+\n+\n+ topStackView.topAnchor.constraint(equalTo: view.topAnchor).isActive = true","path":"zScanner/ViewControllers/Drawer/DrawerViewController.swift","position":97,"original_position":97,"commit_id":"ae71759eb1c89b2e42648de6b5c25c22ab0dc110","original_commit_id":"ae71759eb1c89b2e42648de6b5c25c22ab0dc110","user":{"login":"skorepak","id":7560049,"node_id":"MDQ6VXNlcjc1NjAwNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/7560049?v=4","gravatar_id":"","url":"https://api.github.com/users/skorepak","html_url":"https://github.com/skorepak","followers_url":"https://api.github.com/users/skorepak/followers","following_url":"https://api.github.com/users/skorepak/following{/other_user}","gists_url":"https://api.github.com/users/skorepak/gists{/gist_id}","starred_url":"https://api.github.com/users/skorepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skorepak/subscriptions","organizations_url":"https://api.github.com/users/skorepak/orgs","repos_url":"https://api.github.com/users/skorepak/repos","events_url":"https://api.github.com/users/skorepak/events{/privacy}","received_events_url":"https://api.github.com/users/skorepak/received_events","type":"User","site_admin":false},"body":"Please use SnapKit for consistency ","created_at":"2019-08-14T15:43:46Z","updated_at":"2019-08-14T15:43:47Z","html_url":"https://github.com/ikem-cz/zScanner-iOS/pull/1#discussion_r313946857","pull_request_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/comments/313946857"},"html":{"href":"https://github.com/ikem-cz/zScanner-iOS/pull/1#discussion_r313946857"},"pull_request":{"href":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/1","id":306328451,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2MzI4NDUx","html_url":"https://github.com/ikem-cz/zScanner-iOS/pull/1","diff_url":"https://github.com/ikem-cz/zScanner-iOS/pull/1.diff","patch_url":"https://github.com/ikem-cz/zScanner-iOS/pull/1.patch","issue_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/issues/1","number":1,"state":"open","locked":false,"title":"drawer update","user":{"login":"killalad","id":12817515,"node_id":"MDQ6VXNlcjEyODE3NTE1","avatar_url":"https://avatars2.githubusercontent.com/u/12817515?v=4","gravatar_id":"","url":"https://api.github.com/users/killalad","html_url":"https://github.com/killalad","followers_url":"https://api.github.com/users/killalad/followers","following_url":"https://api.github.com/users/killalad/following{/other_user}","gists_url":"https://api.github.com/users/killalad/gists{/gist_id}","starred_url":"https://api.github.com/users/killalad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killalad/subscriptions","organizations_url":"https://api.github.com/users/killalad/orgs","repos_url":"https://api.github.com/users/killalad/repos","events_url":"https://api.github.com/users/killalad/events{/privacy}","received_events_url":"https://api.github.com/users/killalad/received_events","type":"User","site_admin":false},"body":"Je to resene pres samostatne drawervc ktere je volane spolu s documentslistvc v documentscoordinatoru.","created_at":"2019-08-12T01:12:42Z","updated_at":"2019-08-14T15:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bd4d8cee8d873547dd8a6dc8d0b16e204602b28","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/issues/1/comments","statuses_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/statuses/ae71759eb1c89b2e42648de6b5c25c22ab0dc110","head":{"label":"killalad:master","ref":"master","sha":"ae71759eb1c89b2e42648de6b5c25c22ab0dc110","user":{"login":"killalad","id":12817515,"node_id":"MDQ6VXNlcjEyODE3NTE1","avatar_url":"https://avatars2.githubusercontent.com/u/12817515?v=4","gravatar_id":"","url":"https://api.github.com/users/killalad","html_url":"https://github.com/killalad","followers_url":"https://api.github.com/users/killalad/followers","following_url":"https://api.github.com/users/killalad/following{/other_user}","gists_url":"https://api.github.com/users/killalad/gists{/gist_id}","starred_url":"https://api.github.com/users/killalad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killalad/subscriptions","organizations_url":"https://api.github.com/users/killalad/orgs","repos_url":"https://api.github.com/users/killalad/repos","events_url":"https://api.github.com/users/killalad/events{/privacy}","received_events_url":"https://api.github.com/users/killalad/received_events","type":"User","site_admin":false},"repo":{"id":201831685,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE4MzE2ODU=","name":"zScanner-iOS","full_name":"killalad/zScanner-iOS","private":false,"owner":{"login":"killalad","id":12817515,"node_id":"MDQ6VXNlcjEyODE3NTE1","avatar_url":"https://avatars2.githubusercontent.com/u/12817515?v=4","gravatar_id":"","url":"https://api.github.com/users/killalad","html_url":"https://github.com/killalad","followers_url":"https://api.github.com/users/killalad/followers","following_url":"https://api.github.com/users/killalad/following{/other_user}","gists_url":"https://api.github.com/users/killalad/gists{/gist_id}","starred_url":"https://api.github.com/users/killalad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killalad/subscriptions","organizations_url":"https://api.github.com/users/killalad/orgs","repos_url":"https://api.github.com/users/killalad/repos","events_url":"https://api.github.com/users/killalad/events{/privacy}","received_events_url":"https://api.github.com/users/killalad/received_events","type":"User","site_admin":false},"html_url":"https://github.com/killalad/zScanner-iOS","description":"The mobile application (iOS version) for clinical and medical photo documentation.","fork":true,"url":"https://api.github.com/repos/killalad/zScanner-iOS","forks_url":"https://api.github.com/repos/killalad/zScanner-iOS/forks","keys_url":"https://api.github.com/repos/killalad/zScanner-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/killalad/zScanner-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/killalad/zScanner-iOS/teams","hooks_url":"https://api.github.com/repos/killalad/zScanner-iOS/hooks","issue_events_url":"https://api.github.com/repos/killalad/zScanner-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/killalad/zScanner-iOS/events","assignees_url":"https://api.github.com/repos/killalad/zScanner-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/killalad/zScanner-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/killalad/zScanner-iOS/tags","blobs_url":"https://api.github.com/repos/killalad/zScanner-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/killalad/zScanner-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/killalad/zScanner-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/killalad/zScanner-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/killalad/zScanner-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/killalad/zScanner-iOS/languages","stargazers_url":"https://api.github.com/repos/killalad/zScanner-iOS/stargazers","contributors_url":"https://api.github.com/repos/killalad/zScanner-iOS/contributors","subscribers_url":"https://api.github.com/repos/killalad/zScanner-iOS/subscribers","subscription_url":"https://api.github.com/repos/killalad/zScanner-iOS/subscription","commits_url":"https://api.github.com/repos/killalad/zScanner-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/killalad/zScanner-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/killalad/zScanner-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/killalad/zScanner-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/killalad/zScanner-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/killalad/zScanner-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/killalad/zScanner-iOS/merges","archive_url":"https://api.github.com/repos/killalad/zScanner-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/killalad/zScanner-iOS/downloads","issues_url":"https://api.github.com/repos/killalad/zScanner-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/killalad/zScanner-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/killalad/zScanner-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/killalad/zScanner-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/killalad/zScanner-iOS/labels{/name}","releases_url":"https://api.github.com/repos/killalad/zScanner-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/killalad/zScanner-iOS/deployments","created_at":"2019-08-12T00:44:17Z","updated_at":"2019-08-14T15:03:46Z","pushed_at":"2019-08-14T15:03:44Z","git_url":"git://github.com/killalad/zScanner-iOS.git","ssh_url":"[email protected]:killalad/zScanner-iOS.git","clone_url":"https://github.com/killalad/zScanner-iOS.git","svn_url":"https://github.com/killalad/zScanner-iOS","homepage":null,"size":216,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ikem-cz:master","ref":"master","sha":"3a21ab69e814f2cf96e0a79e30e3e564a7676005","user":{"login":"ikem-cz","id":50015152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMDE1MTUy","avatar_url":"https://avatars0.githubusercontent.com/u/50015152?v=4","gravatar_id":"","url":"https://api.github.com/users/ikem-cz","html_url":"https://github.com/ikem-cz","followers_url":"https://api.github.com/users/ikem-cz/followers","following_url":"https://api.github.com/users/ikem-cz/following{/other_user}","gists_url":"https://api.github.com/users/ikem-cz/gists{/gist_id}","starred_url":"https://api.github.com/users/ikem-cz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikem-cz/subscriptions","organizations_url":"https://api.github.com/users/ikem-cz/orgs","repos_url":"https://api.github.com/users/ikem-cz/repos","events_url":"https://api.github.com/users/ikem-cz/events{/privacy}","received_events_url":"https://api.github.com/users/ikem-cz/received_events","type":"Organization","site_admin":false},"repo":{"id":199338384,"node_id":"MDEwOlJlcG9zaXRvcnkxOTkzMzgzODQ=","name":"zScanner-iOS","full_name":"ikem-cz/zScanner-iOS","private":false,"owner":{"login":"ikem-cz","id":50015152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMDE1MTUy","avatar_url":"https://avatars0.githubusercontent.com/u/50015152?v=4","gravatar_id":"","url":"https://api.github.com/users/ikem-cz","html_url":"https://github.com/ikem-cz","followers_url":"https://api.github.com/users/ikem-cz/followers","following_url":"https://api.github.com/users/ikem-cz/following{/other_user}","gists_url":"https://api.github.com/users/ikem-cz/gists{/gist_id}","starred_url":"https://api.github.com/users/ikem-cz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikem-cz/subscriptions","organizations_url":"https://api.github.com/users/ikem-cz/orgs","repos_url":"https://api.github.com/users/ikem-cz/repos","events_url":"https://api.github.com/users/ikem-cz/events{/privacy}","received_events_url":"https://api.github.com/users/ikem-cz/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ikem-cz/zScanner-iOS","description":"The mobile application (iOS version) for clinical and medical photo documentation.","fork":false,"url":"https://api.github.com/repos/ikem-cz/zScanner-iOS","forks_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/forks","keys_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/teams","hooks_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/hooks","issue_events_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/events","assignees_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/tags","blobs_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/languages","stargazers_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/stargazers","contributors_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/contributors","subscribers_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/subscribers","subscription_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/subscription","commits_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/merges","archive_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/downloads","issues_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/labels{/name}","releases_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/ikem-cz/zScanner-iOS/deployments","created_at":"2019-07-28T21:21:04Z","updated_at":"2019-08-12T00:01:28Z","pushed_at":"2019-08-14T15:03:45Z","git_url":"git://github.com/ikem-cz/zScanner-iOS.git","ssh_url":"[email protected]:ikem-cz/zScanner-iOS.git","clone_url":"https://github.com/ikem-cz/zScanner-iOS.git","svn_url":"https://github.com/ikem-cz/zScanner-iOS","homepage":null,"size":190,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/1"},"html":{"href":"https://github.com/ikem-cz/zScanner-iOS/pull/1"},"issue":{"href":"https://api.github.com/repos/ikem-cz/zScanner-iOS/issues/1"},"comments":{"href":"https://api.github.com/repos/ikem-cz/zScanner-iOS/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ikem-cz/zScanner-iOS/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ikem-cz/zScanner-iOS/statuses/ae71759eb1c89b2e42648de6b5c25c22ab0dc110"}},"author_association":"NONE"}}
|
{
"id": 199338384,
"name": "ikem-cz/zScanner-iOS",
"url": "https://api.github.com/repos/ikem-cz/zScanner-iOS"
}
|
{
"id": 7560049,
"login": "skorepak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7560049?",
"url": "https://api.github.com/users/skorepak"
}
|
{
"id": 50015152,
"login": "ikem-cz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50015152?",
"url": "https://api.github.com/orgs/ikem-cz"
}
| 2019-08-14T15:43:46 |
10210915780
|
{"actor":{"display_login":"skorepak"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/project-asgard/asgard/pulls/comments/331069934","pull_request_review_id":296908033,"id":331069934,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMTA2OTkzNA==","diff_hunk":"@@ -251,28 +269,23 @@ class term\n int degrees_freedom(dimension<P> const d) const\n {\n return d.get_degree() * static_cast<int>(std::pow(2, d.get_level()));\n- };\n+ }\n+\n+ std::vector<partial_term<P>> const &get_partial_terms() const\n+ {\n+ return partial_terms;\n+ }\n+\n+ int num_partial_terms() const { return partial_terms.size(); };","path":"src/pde/pde_base.hpp","position":187,"original_position":187,"commit_id":"b9653e2b58761e39341022b46f95f6eb2efcad47","original_commit_id":"ebf874b47a4b5e6323f013f754cdabdc965d8121","user":{"login":"bmcdanie","id":7290188,"node_id":"MDQ6VXNlcjcyOTAxODg=","avatar_url":"https://avatars2.githubusercontent.com/u/7290188?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcdanie","html_url":"https://github.com/bmcdanie","followers_url":"https://api.github.com/users/bmcdanie/followers","following_url":"https://api.github.com/users/bmcdanie/following{/other_user}","gists_url":"https://api.github.com/users/bmcdanie/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcdanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcdanie/subscriptions","organizations_url":"https://api.github.com/users/bmcdanie/orgs","repos_url":"https://api.github.com/users/bmcdanie/repos","events_url":"https://api.github.com/users/bmcdanie/events{/privacy}","received_events_url":"https://api.github.com/users/bmcdanie/received_events","type":"User","site_admin":false},"body":"is this needed since we have `get_partial_terms` above?","created_at":"2019-10-03T14:26:36Z","updated_at":"2019-10-03T14:39:43Z","html_url":"https://github.com/project-asgard/asgard/pull/153#discussion_r331069934","pull_request_url":"https://api.github.com/repos/project-asgard/asgard/pulls/153","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/project-asgard/asgard/pulls/comments/331069934"},"html":{"href":"https://github.com/project-asgard/asgard/pull/153#discussion_r331069934"},"pull_request":{"href":"https://api.github.com/repos/project-asgard/asgard/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/project-asgard/asgard/pulls/153","id":313810002,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzODEwMDAy","html_url":"https://github.com/project-asgard/asgard/pull/153","diff_url":"https://github.com/project-asgard/asgard/pull/153.diff","patch_url":"https://github.com/project-asgard/asgard/pull/153.patch","issue_url":"https://api.github.com/repos/project-asgard/asgard/issues/153","number":153,"state":"open","locked":false,"title":"Refactor/pde spec","user":{"login":"stonecoldhughes","id":13874854,"node_id":"MDQ6VXNlcjEzODc0ODU0","avatar_url":"https://avatars1.githubusercontent.com/u/13874854?v=4","gravatar_id":"","url":"https://api.github.com/users/stonecoldhughes","html_url":"https://github.com/stonecoldhughes","followers_url":"https://api.github.com/users/stonecoldhughes/followers","following_url":"https://api.github.com/users/stonecoldhughes/following{/other_user}","gists_url":"https://api.github.com/users/stonecoldhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/stonecoldhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonecoldhughes/subscriptions","organizations_url":"https://api.github.com/users/stonecoldhughes/orgs","repos_url":"https://api.github.com/users/stonecoldhughes/repos","events_url":"https://api.github.com/users/stonecoldhughes/events{/privacy}","received_events_url":"https://api.github.com/users/stonecoldhughes/received_events","type":"User","site_admin":false},"body":"Help! I cannot get this to compile.","created_at":"2019-09-04T00:08:27Z","updated_at":"2019-10-03T14:39:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a67956b05f64e59253279bbb5fce3d40793dfaf7","assignee":{"login":"bmcdanie","id":7290188,"node_id":"MDQ6VXNlcjcyOTAxODg=","avatar_url":"https://avatars2.githubusercontent.com/u/7290188?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcdanie","html_url":"https://github.com/bmcdanie","followers_url":"https://api.github.com/users/bmcdanie/followers","following_url":"https://api.github.com/users/bmcdanie/following{/other_user}","gists_url":"https://api.github.com/users/bmcdanie/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcdanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcdanie/subscriptions","organizations_url":"https://api.github.com/users/bmcdanie/orgs","repos_url":"https://api.github.com/users/bmcdanie/repos","events_url":"https://api.github.com/users/bmcdanie/events{/privacy}","received_events_url":"https://api.github.com/users/bmcdanie/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmcdanie","id":7290188,"node_id":"MDQ6VXNlcjcyOTAxODg=","avatar_url":"https://avatars2.githubusercontent.com/u/7290188?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcdanie","html_url":"https://github.com/bmcdanie","followers_url":"https://api.github.com/users/bmcdanie/followers","following_url":"https://api.github.com/users/bmcdanie/following{/other_user}","gists_url":"https://api.github.com/users/bmcdanie/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcdanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcdanie/subscriptions","organizations_url":"https://api.github.com/users/bmcdanie/orgs","repos_url":"https://api.github.com/users/bmcdanie/repos","events_url":"https://api.github.com/users/bmcdanie/events{/privacy}","received_events_url":"https://api.github.com/users/bmcdanie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/project-asgard/asgard/pulls/153/commits","review_comments_url":"https://api.github.com/repos/project-asgard/asgard/pulls/153/comments","review_comment_url":"https://api.github.com/repos/project-asgard/asgard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/project-asgard/asgard/issues/153/comments","statuses_url":"https://api.github.com/repos/project-asgard/asgard/statuses/b9653e2b58761e39341022b46f95f6eb2efcad47","head":{"label":"stonecoldhughes:refactor/pde_spec","ref":"refactor/pde_spec","sha":"b9653e2b58761e39341022b46f95f6eb2efcad47","user":{"login":"stonecoldhughes","id":13874854,"node_id":"MDQ6VXNlcjEzODc0ODU0","avatar_url":"https://avatars1.githubusercontent.com/u/13874854?v=4","gravatar_id":"","url":"https://api.github.com/users/stonecoldhughes","html_url":"https://github.com/stonecoldhughes","followers_url":"https://api.github.com/users/stonecoldhughes/followers","following_url":"https://api.github.com/users/stonecoldhughes/following{/other_user}","gists_url":"https://api.github.com/users/stonecoldhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/stonecoldhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonecoldhughes/subscriptions","organizations_url":"https://api.github.com/users/stonecoldhughes/orgs","repos_url":"https://api.github.com/users/stonecoldhughes/repos","events_url":"https://api.github.com/users/stonecoldhughes/events{/privacy}","received_events_url":"https://api.github.com/users/stonecoldhughes/received_events","type":"User","site_admin":false},"repo":{"id":199495594,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk0OTU1OTQ=","name":"asgard","full_name":"stonecoldhughes/asgard","private":false,"owner":{"login":"stonecoldhughes","id":13874854,"node_id":"MDQ6VXNlcjEzODc0ODU0","avatar_url":"https://avatars1.githubusercontent.com/u/13874854?v=4","gravatar_id":"","url":"https://api.github.com/users/stonecoldhughes","html_url":"https://github.com/stonecoldhughes","followers_url":"https://api.github.com/users/stonecoldhughes/followers","following_url":"https://api.github.com/users/stonecoldhughes/following{/other_user}","gists_url":"https://api.github.com/users/stonecoldhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/stonecoldhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonecoldhughes/subscriptions","organizations_url":"https://api.github.com/users/stonecoldhughes/orgs","repos_url":"https://api.github.com/users/stonecoldhughes/repos","events_url":"https://api.github.com/users/stonecoldhughes/events{/privacy}","received_events_url":"https://api.github.com/users/stonecoldhughes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stonecoldhughes/asgard","description":null,"fork":true,"url":"https://api.github.com/repos/stonecoldhughes/asgard","forks_url":"https://api.github.com/repos/stonecoldhughes/asgard/forks","keys_url":"https://api.github.com/repos/stonecoldhughes/asgard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stonecoldhughes/asgard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stonecoldhughes/asgard/teams","hooks_url":"https://api.github.com/repos/stonecoldhughes/asgard/hooks","issue_events_url":"https://api.github.com/repos/stonecoldhughes/asgard/issues/events{/number}","events_url":"https://api.github.com/repos/stonecoldhughes/asgard/events","assignees_url":"https://api.github.com/repos/stonecoldhughes/asgard/assignees{/user}","branches_url":"https://api.github.com/repos/stonecoldhughes/asgard/branches{/branch}","tags_url":"https://api.github.com/repos/stonecoldhughes/asgard/tags","blobs_url":"https://api.github.com/repos/stonecoldhughes/asgard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stonecoldhughes/asgard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stonecoldhughes/asgard/git/refs{/sha}","trees_url":"https://api.github.com/repos/stonecoldhughes/asgard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stonecoldhughes/asgard/statuses/{sha}","languages_url":"https://api.github.com/repos/stonecoldhughes/asgard/languages","stargazers_url":"https://api.github.com/repos/stonecoldhughes/asgard/stargazers","contributors_url":"https://api.github.com/repos/stonecoldhughes/asgard/contributors","subscribers_url":"https://api.github.com/repos/stonecoldhughes/asgard/subscribers","subscription_url":"https://api.github.com/repos/stonecoldhughes/asgard/subscription","commits_url":"https://api.github.com/repos/stonecoldhughes/asgard/commits{/sha}","git_commits_url":"https://api.github.com/repos/stonecoldhughes/asgard/git/commits{/sha}","comments_url":"https://api.github.com/repos/stonecoldhughes/asgard/comments{/number}","issue_comment_url":"https://api.github.com/repos/stonecoldhughes/asgard/issues/comments{/number}","contents_url":"https://api.github.com/repos/stonecoldhughes/asgard/contents/{+path}","compare_url":"https://api.github.com/repos/stonecoldhughes/asgard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stonecoldhughes/asgard/merges","archive_url":"https://api.github.com/repos/stonecoldhughes/asgard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stonecoldhughes/asgard/downloads","issues_url":"https://api.github.com/repos/stonecoldhughes/asgard/issues{/number}","pulls_url":"https://api.github.com/repos/stonecoldhughes/asgard/pulls{/number}","milestones_url":"https://api.github.com/repos/stonecoldhughes/asgard/milestones{/number}","notifications_url":"https://api.github.com/repos/stonecoldhughes/asgard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stonecoldhughes/asgard/labels{/name}","releases_url":"https://api.github.com/repos/stonecoldhughes/asgard/releases{/id}","deployments_url":"https://api.github.com/repos/stonecoldhughes/asgard/deployments","created_at":"2019-07-29T17:11:49Z","updated_at":"2019-07-29T17:11:53Z","pushed_at":"2019-10-03T14:38:47Z","git_url":"git://github.com/stonecoldhughes/asgard.git","ssh_url":"[email protected]:stonecoldhughes/asgard.git","clone_url":"https://github.com/stonecoldhughes/asgard.git","svn_url":"https://github.com/stonecoldhughes/asgard","homepage":null,"size":8730,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"project-asgard:develop","ref":"develop","sha":"ca41eb49f9332c1a5208fcc866e6562330d87a3d","user":{"login":"project-asgard","id":50125104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMTI1MTA0","avatar_url":"https://avatars0.githubusercontent.com/u/50125104?v=4","gravatar_id":"","url":"https://api.github.com/users/project-asgard","html_url":"https://github.com/project-asgard","followers_url":"https://api.github.com/users/project-asgard/followers","following_url":"https://api.github.com/users/project-asgard/following{/other_user}","gists_url":"https://api.github.com/users/project-asgard/gists{/gist_id}","starred_url":"https://api.github.com/users/project-asgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-asgard/subscriptions","organizations_url":"https://api.github.com/users/project-asgard/orgs","repos_url":"https://api.github.com/users/project-asgard/repos","events_url":"https://api.github.com/users/project-asgard/events{/privacy}","received_events_url":"https://api.github.com/users/project-asgard/received_events","type":"Organization","site_admin":false},"repo":{"id":191057628,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEwNTc2Mjg=","name":"asgard","full_name":"project-asgard/asgard","private":false,"owner":{"login":"project-asgard","id":50125104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMTI1MTA0","avatar_url":"https://avatars0.githubusercontent.com/u/50125104?v=4","gravatar_id":"","url":"https://api.github.com/users/project-asgard","html_url":"https://github.com/project-asgard","followers_url":"https://api.github.com/users/project-asgard/followers","following_url":"https://api.github.com/users/project-asgard/following{/other_user}","gists_url":"https://api.github.com/users/project-asgard/gists{/gist_id}","starred_url":"https://api.github.com/users/project-asgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-asgard/subscriptions","organizations_url":"https://api.github.com/users/project-asgard/orgs","repos_url":"https://api.github.com/users/project-asgard/repos","events_url":"https://api.github.com/users/project-asgard/events{/privacy}","received_events_url":"https://api.github.com/users/project-asgard/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/project-asgard/asgard","description":null,"fork":false,"url":"https://api.github.com/repos/project-asgard/asgard","forks_url":"https://api.github.com/repos/project-asgard/asgard/forks","keys_url":"https://api.github.com/repos/project-asgard/asgard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/project-asgard/asgard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/project-asgard/asgard/teams","hooks_url":"https://api.github.com/repos/project-asgard/asgard/hooks","issue_events_url":"https://api.github.com/repos/project-asgard/asgard/issues/events{/number}","events_url":"https://api.github.com/repos/project-asgard/asgard/events","assignees_url":"https://api.github.com/repos/project-asgard/asgard/assignees{/user}","branches_url":"https://api.github.com/repos/project-asgard/asgard/branches{/branch}","tags_url":"https://api.github.com/repos/project-asgard/asgard/tags","blobs_url":"https://api.github.com/repos/project-asgard/asgard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/project-asgard/asgard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/project-asgard/asgard/git/refs{/sha}","trees_url":"https://api.github.com/repos/project-asgard/asgard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/project-asgard/asgard/statuses/{sha}","languages_url":"https://api.github.com/repos/project-asgard/asgard/languages","stargazers_url":"https://api.github.com/repos/project-asgard/asgard/stargazers","contributors_url":"https://api.github.com/repos/project-asgard/asgard/contributors","subscribers_url":"https://api.github.com/repos/project-asgard/asgard/subscribers","subscription_url":"https://api.github.com/repos/project-asgard/asgard/subscription","commits_url":"https://api.github.com/repos/project-asgard/asgard/commits{/sha}","git_commits_url":"https://api.github.com/repos/project-asgard/asgard/git/commits{/sha}","comments_url":"https://api.github.com/repos/project-asgard/asgard/comments{/number}","issue_comment_url":"https://api.github.com/repos/project-asgard/asgard/issues/comments{/number}","contents_url":"https://api.github.com/repos/project-asgard/asgard/contents/{+path}","compare_url":"https://api.github.com/repos/project-asgard/asgard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/project-asgard/asgard/merges","archive_url":"https://api.github.com/repos/project-asgard/asgard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/project-asgard/asgard/downloads","issues_url":"https://api.github.com/repos/project-asgard/asgard/issues{/number}","pulls_url":"https://api.github.com/repos/project-asgard/asgard/pulls{/number}","milestones_url":"https://api.github.com/repos/project-asgard/asgard/milestones{/number}","notifications_url":"https://api.github.com/repos/project-asgard/asgard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/project-asgard/asgard/labels{/name}","releases_url":"https://api.github.com/repos/project-asgard/asgard/releases{/id}","deployments_url":"https://api.github.com/repos/project-asgard/asgard/deployments","created_at":"2019-06-09T21:34:52Z","updated_at":"2019-09-30T17:03:01Z","pushed_at":"2019-10-03T14:38:49Z","git_url":"git://github.com/project-asgard/asgard.git","ssh_url":"[email protected]:project-asgard/asgard.git","clone_url":"https://github.com/project-asgard/asgard.git","svn_url":"https://github.com/project-asgard/asgard","homepage":null,"size":8674,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":67,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":67,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/project-asgard/asgard/pulls/153"},"html":{"href":"https://github.com/project-asgard/asgard/pull/153"},"issue":{"href":"https://api.github.com/repos/project-asgard/asgard/issues/153"},"comments":{"href":"https://api.github.com/repos/project-asgard/asgard/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/project-asgard/asgard/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/project-asgard/asgard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/project-asgard/asgard/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/project-asgard/asgard/statuses/b9653e2b58761e39341022b46f95f6eb2efcad47"}},"author_association":"COLLABORATOR"}}
|
{
"id": 191057628,
"name": "project-asgard/asgard",
"url": "https://api.github.com/repos/project-asgard/asgard"
}
|
{
"id": 7290188,
"login": "bmcdanie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7290188?",
"url": "https://api.github.com/users/bmcdanie"
}
|
{
"id": 50125104,
"login": "project-asgard",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50125104?",
"url": "https://api.github.com/orgs/project-asgard"
}
| 2019-10-03T14:26:36 |
10552151578
|
{"actor":{"display_login":"bmcdanie"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pigly-di/pigly/pulls/comments/350049434","pull_request_review_id":322114145,"id":350049434,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MDA0OTQzNA==","diff_hunk":"@@ -1,10 +1,9 @@\n import { Newable } from \"../_newable\";\n-import { IProvider } from \"../_provider\";\n+import { IProvider, ProviderWrap } from \"../_provider\";\n import { toClass } from \"./to-class\";\n \n ///** REQUIRES TRANSFORMER - create a class provider where the constructor arguments are inferable */\n-export function toSelf<T>(ctor: Newable<T>): IProvider<T>\n-export function toSelf<T>(ctor: Newable<T>, ...providers: IProvider<any>[]): IProvider<T>\n+export function toSelf<T extends Newable<any>>(ctor: T, ...providers: ProviderWrap<ConstructorParameters<T>>): IProvider<T>","path":"packages/pigly/src/providers/to-self.ts","position":9,"original_position":9,"commit_id":"65e17b7f81b332d13b790266a6dab56504ad37dc","original_commit_id":"7684ff2ad894947392afe5c873f7e9c6109b9a58","user":{"login":"MeirionHughes","id":3584509,"node_id":"MDQ6VXNlcjM1ODQ1MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/3584509?v=4","gravatar_id":"","url":"https://api.github.com/users/MeirionHughes","html_url":"https://github.com/MeirionHughes","followers_url":"https://api.github.com/users/MeirionHughes/followers","following_url":"https://api.github.com/users/MeirionHughes/following{/other_user}","gists_url":"https://api.github.com/users/MeirionHughes/gists{/gist_id}","starred_url":"https://api.github.com/users/MeirionHughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeirionHughes/subscriptions","organizations_url":"https://api.github.com/users/MeirionHughes/orgs","repos_url":"https://api.github.com/users/MeirionHughes/repos","events_url":"https://api.github.com/users/MeirionHughes/events{/privacy}","received_events_url":"https://api.github.com/users/MeirionHughes/received_events","type":"User","site_admin":false},"body":"probably can get away with removing typing here as its a compile-concern. i.e. ```...providers: any[];```","created_at":"2019-11-25T08:51:25Z","updated_at":"2019-11-25T08:52:28Z","html_url":"https://github.com/pigly-di/pigly/pull/22#discussion_r350049434","pull_request_url":"https://api.github.com/repos/pigly-di/pigly/pulls/22","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pigly-di/pigly/pulls/comments/350049434"},"html":{"href":"https://github.com/pigly-di/pigly/pull/22#discussion_r350049434"},"pull_request":{"href":"https://api.github.com/repos/pigly-di/pigly/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/pigly-di/pigly/pulls/22","id":344859474,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0ODU5NDc0","html_url":"https://github.com/pigly-di/pigly/pull/22","diff_url":"https://github.com/pigly-di/pigly/pull/22.diff","patch_url":"https://github.com/pigly-di/pigly/pull/22.patch","issue_url":"https://api.github.com/repos/pigly-di/pigly/issues/22","number":22,"state":"open","locked":false,"title":"feat(providers): use generics to allow for typed providers for more than 5 provider arguments","user":{"login":"YePpHa","id":2348303,"node_id":"MDQ6VXNlcjIzNDgzMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2348303?v=4","gravatar_id":"","url":"https://api.github.com/users/YePpHa","html_url":"https://github.com/YePpHa","followers_url":"https://api.github.com/users/YePpHa/followers","following_url":"https://api.github.com/users/YePpHa/following{/other_user}","gists_url":"https://api.github.com/users/YePpHa/gists{/gist_id}","starred_url":"https://api.github.com/users/YePpHa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YePpHa/subscriptions","organizations_url":"https://api.github.com/users/YePpHa/orgs","repos_url":"https://api.github.com/users/YePpHa/repos","events_url":"https://api.github.com/users/YePpHa/events{/privacy}","received_events_url":"https://api.github.com/users/YePpHa/received_events","type":"User","site_admin":false},"body":"I've updated the code to allow the methods `toClass` and `toSelf` to have strict types for providers even if there's more than 5 of them.\r\nThis update made it possible to remove all the `Newable0`, `Newable1`, `Newable2`, `Newable3`, `Newable4` and `Newable5` types.\r\n\r\nI've also added a type `ProviderWrap` that wraps IProvider around each type in an array. I'm not 100% sure where to put it. So I ended with putting it in `_provider.ts`.\r\n\r\n__Update:__ I forgot about the transformer filling the parameters on compile time. So I changed `ProviderWrap` to make the values optional instead.","created_at":"2019-11-24T00:43:32Z","updated_at":"2019-11-25T08:52:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"223ff411d650849b61823d27d6cb14fb6f30f598","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1685959290,"node_id":"MDU6TGFiZWwxNjg1OTU5Mjkw","url":"https://api.github.com/repos/pigly-di/pigly/labels/package:%20pigly","name":"package: pigly","color":"a84143","default":false,"description":"relating to the pigly package"},{"id":1658522817,"node_id":"MDU6TGFiZWwxNjU4NTIyODE3","url":"https://api.github.com/repos/pigly-di/pigly/labels/priority:%20low","name":"priority: low","color":"0e8a16","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/pigly-di/pigly/pulls/22/commits","review_comments_url":"https://api.github.com/repos/pigly-di/pigly/pulls/22/comments","review_comment_url":"https://api.github.com/repos/pigly-di/pigly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pigly-di/pigly/issues/22/comments","statuses_url":"https://api.github.com/repos/pigly-di/pigly/statuses/65e17b7f81b332d13b790266a6dab56504ad37dc","head":{"label":"YePpHa:feat/toClass-expand-providers","ref":"feat/toClass-expand-providers","sha":"65e17b7f81b332d13b790266a6dab56504ad37dc","user":{"login":"YePpHa","id":2348303,"node_id":"MDQ6VXNlcjIzNDgzMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2348303?v=4","gravatar_id":"","url":"https://api.github.com/users/YePpHa","html_url":"https://github.com/YePpHa","followers_url":"https://api.github.com/users/YePpHa/followers","following_url":"https://api.github.com/users/YePpHa/following{/other_user}","gists_url":"https://api.github.com/users/YePpHa/gists{/gist_id}","starred_url":"https://api.github.com/users/YePpHa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YePpHa/subscriptions","organizations_url":"https://api.github.com/users/YePpHa/orgs","repos_url":"https://api.github.com/users/YePpHa/repos","events_url":"https://api.github.com/users/YePpHa/events{/privacy}","received_events_url":"https://api.github.com/users/YePpHa/received_events","type":"User","site_admin":false},"repo":{"id":223672532,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM2NzI1MzI=","name":"pigly","full_name":"YePpHa/pigly","private":false,"owner":{"login":"YePpHa","id":2348303,"node_id":"MDQ6VXNlcjIzNDgzMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2348303?v=4","gravatar_id":"","url":"https://api.github.com/users/YePpHa","html_url":"https://github.com/YePpHa","followers_url":"https://api.github.com/users/YePpHa/followers","following_url":"https://api.github.com/users/YePpHa/following{/other_user}","gists_url":"https://api.github.com/users/YePpHa/gists{/gist_id}","starred_url":"https://api.github.com/users/YePpHa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YePpHa/subscriptions","organizations_url":"https://api.github.com/users/YePpHa/orgs","repos_url":"https://api.github.com/users/YePpHa/repos","events_url":"https://api.github.com/users/YePpHa/events{/privacy}","received_events_url":"https://api.github.com/users/YePpHa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/YePpHa/pigly","description":"unobtrusive dependency-injection for javascript/typescript","fork":true,"url":"https://api.github.com/repos/YePpHa/pigly","forks_url":"https://api.github.com/repos/YePpHa/pigly/forks","keys_url":"https://api.github.com/repos/YePpHa/pigly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YePpHa/pigly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YePpHa/pigly/teams","hooks_url":"https://api.github.com/repos/YePpHa/pigly/hooks","issue_events_url":"https://api.github.com/repos/YePpHa/pigly/issues/events{/number}","events_url":"https://api.github.com/repos/YePpHa/pigly/events","assignees_url":"https://api.github.com/repos/YePpHa/pigly/assignees{/user}","branches_url":"https://api.github.com/repos/YePpHa/pigly/branches{/branch}","tags_url":"https://api.github.com/repos/YePpHa/pigly/tags","blobs_url":"https://api.github.com/repos/YePpHa/pigly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YePpHa/pigly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YePpHa/pigly/git/refs{/sha}","trees_url":"https://api.github.com/repos/YePpHa/pigly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YePpHa/pigly/statuses/{sha}","languages_url":"https://api.github.com/repos/YePpHa/pigly/languages","stargazers_url":"https://api.github.com/repos/YePpHa/pigly/stargazers","contributors_url":"https://api.github.com/repos/YePpHa/pigly/contributors","subscribers_url":"https://api.github.com/repos/YePpHa/pigly/subscribers","subscription_url":"https://api.github.com/repos/YePpHa/pigly/subscription","commits_url":"https://api.github.com/repos/YePpHa/pigly/commits{/sha}","git_commits_url":"https://api.github.com/repos/YePpHa/pigly/git/commits{/sha}","comments_url":"https://api.github.com/repos/YePpHa/pigly/comments{/number}","issue_comment_url":"https://api.github.com/repos/YePpHa/pigly/issues/comments{/number}","contents_url":"https://api.github.com/repos/YePpHa/pigly/contents/{+path}","compare_url":"https://api.github.com/repos/YePpHa/pigly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YePpHa/pigly/merges","archive_url":"https://api.github.com/repos/YePpHa/pigly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YePpHa/pigly/downloads","issues_url":"https://api.github.com/repos/YePpHa/pigly/issues{/number}","pulls_url":"https://api.github.com/repos/YePpHa/pigly/pulls{/number}","milestones_url":"https://api.github.com/repos/YePpHa/pigly/milestones{/number}","notifications_url":"https://api.github.com/repos/YePpHa/pigly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YePpHa/pigly/labels{/name}","releases_url":"https://api.github.com/repos/YePpHa/pigly/releases{/id}","deployments_url":"https://api.github.com/repos/YePpHa/pigly/deployments","created_at":"2019-11-24T00:35:57Z","updated_at":"2019-11-24T00:35:59Z","pushed_at":"2019-11-24T21:12:07Z","git_url":"git://github.com/YePpHa/pigly.git","ssh_url":"[email protected]:YePpHa/pigly.git","clone_url":"https://github.com/YePpHa/pigly.git","svn_url":"https://github.com/YePpHa/pigly","homepage":"","size":879,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"pigly-di:develop","ref":"develop","sha":"a9b586194134f02bfda38d6db2441df08ce84e20","user":{"login":"pigly-di","id":50213493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMjEzNDkz","avatar_url":"https://avatars2.githubusercontent.com/u/50213493?v=4","gravatar_id":"","url":"https://api.github.com/users/pigly-di","html_url":"https://github.com/pigly-di","followers_url":"https://api.github.com/users/pigly-di/followers","following_url":"https://api.github.com/users/pigly-di/following{/other_user}","gists_url":"https://api.github.com/users/pigly-di/gists{/gist_id}","starred_url":"https://api.github.com/users/pigly-di/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pigly-di/subscriptions","organizations_url":"https://api.github.com/users/pigly-di/orgs","repos_url":"https://api.github.com/users/pigly-di/repos","events_url":"https://api.github.com/users/pigly-di/events{/privacy}","received_events_url":"https://api.github.com/users/pigly-di/received_events","type":"Organization","site_admin":false},"repo":{"id":184611312,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ2MTEzMTI=","name":"pigly","full_name":"pigly-di/pigly","private":false,"owner":{"login":"pigly-di","id":50213493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMjEzNDkz","avatar_url":"https://avatars2.githubusercontent.com/u/50213493?v=4","gravatar_id":"","url":"https://api.github.com/users/pigly-di","html_url":"https://github.com/pigly-di","followers_url":"https://api.github.com/users/pigly-di/followers","following_url":"https://api.github.com/users/pigly-di/following{/other_user}","gists_url":"https://api.github.com/users/pigly-di/gists{/gist_id}","starred_url":"https://api.github.com/users/pigly-di/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pigly-di/subscriptions","organizations_url":"https://api.github.com/users/pigly-di/orgs","repos_url":"https://api.github.com/users/pigly-di/repos","events_url":"https://api.github.com/users/pigly-di/events{/privacy}","received_events_url":"https://api.github.com/users/pigly-di/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pigly-di/pigly","description":"unobtrusive dependency-injection for javascript/typescript","fork":false,"url":"https://api.github.com/repos/pigly-di/pigly","forks_url":"https://api.github.com/repos/pigly-di/pigly/forks","keys_url":"https://api.github.com/repos/pigly-di/pigly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pigly-di/pigly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pigly-di/pigly/teams","hooks_url":"https://api.github.com/repos/pigly-di/pigly/hooks","issue_events_url":"https://api.github.com/repos/pigly-di/pigly/issues/events{/number}","events_url":"https://api.github.com/repos/pigly-di/pigly/events","assignees_url":"https://api.github.com/repos/pigly-di/pigly/assignees{/user}","branches_url":"https://api.github.com/repos/pigly-di/pigly/branches{/branch}","tags_url":"https://api.github.com/repos/pigly-di/pigly/tags","blobs_url":"https://api.github.com/repos/pigly-di/pigly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pigly-di/pigly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pigly-di/pigly/git/refs{/sha}","trees_url":"https://api.github.com/repos/pigly-di/pigly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pigly-di/pigly/statuses/{sha}","languages_url":"https://api.github.com/repos/pigly-di/pigly/languages","stargazers_url":"https://api.github.com/repos/pigly-di/pigly/stargazers","contributors_url":"https://api.github.com/repos/pigly-di/pigly/contributors","subscribers_url":"https://api.github.com/repos/pigly-di/pigly/subscribers","subscription_url":"https://api.github.com/repos/pigly-di/pigly/subscription","commits_url":"https://api.github.com/repos/pigly-di/pigly/commits{/sha}","git_commits_url":"https://api.github.com/repos/pigly-di/pigly/git/commits{/sha}","comments_url":"https://api.github.com/repos/pigly-di/pigly/comments{/number}","issue_comment_url":"https://api.github.com/repos/pigly-di/pigly/issues/comments{/number}","contents_url":"https://api.github.com/repos/pigly-di/pigly/contents/{+path}","compare_url":"https://api.github.com/repos/pigly-di/pigly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pigly-di/pigly/merges","archive_url":"https://api.github.com/repos/pigly-di/pigly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pigly-di/pigly/downloads","issues_url":"https://api.github.com/repos/pigly-di/pigly/issues{/number}","pulls_url":"https://api.github.com/repos/pigly-di/pigly/pulls{/number}","milestones_url":"https://api.github.com/repos/pigly-di/pigly/milestones{/number}","notifications_url":"https://api.github.com/repos/pigly-di/pigly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pigly-di/pigly/labels{/name}","releases_url":"https://api.github.com/repos/pigly-di/pigly/releases{/id}","deployments_url":"https://api.github.com/repos/pigly-di/pigly/deployments","created_at":"2019-05-02T16:04:02Z","updated_at":"2019-11-25T07:09:05Z","pushed_at":"2019-11-25T07:14:53Z","git_url":"git://github.com/pigly-di/pigly.git","ssh_url":"[email protected]:pigly-di/pigly.git","clone_url":"https://github.com/pigly-di/pigly.git","svn_url":"https://github.com/pigly-di/pigly","homepage":"","size":1057,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":4,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pigly-di/pigly/pulls/22"},"html":{"href":"https://github.com/pigly-di/pigly/pull/22"},"issue":{"href":"https://api.github.com/repos/pigly-di/pigly/issues/22"},"comments":{"href":"https://api.github.com/repos/pigly-di/pigly/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/pigly-di/pigly/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/pigly-di/pigly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pigly-di/pigly/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/pigly-di/pigly/statuses/65e17b7f81b332d13b790266a6dab56504ad37dc"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 184611312,
"name": "pigly-di/pigly",
"url": "https://api.github.com/repos/pigly-di/pigly"
}
|
{
"id": 3584509,
"login": "MeirionHughes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3584509?",
"url": "https://api.github.com/users/MeirionHughes"
}
|
{
"id": 50213493,
"login": "pigly-di",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50213493?",
"url": "https://api.github.com/orgs/pigly-di"
}
| 2019-11-25T08:51:25 |
10938606903
|
{"actor":{"display_login":"MeirionHughes"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/onosproject/onos-config/pulls/comments/287685782","pull_request_review_id":242144951,"id":287685782,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzY4NTc4Mg==","diff_hunk":"@@ -42,6 +43,7 @@ func Test_getWithPrefixNoOtherPathsNoTarget(t *testing.T) {\n \tserver := setUp(false)\n \n \tprefixPath, err := utils.ParseGNMIElements([]string{\"test1:cont1a\", \"cont2a\"})\n+\tassert.NilError(t, err, \"Unexpected error\")","path":"pkg/northbound/gnmi/get_test.go","position":19,"original_position":19,"commit_id":"4918cc3f5d8c2098ebf6cfacf12d120313af8ee4","original_commit_id":"4918cc3f5d8c2098ebf6cfacf12d120313af8ee4","user":{"login":"SeanCondon","id":10304208,"node_id":"MDQ6VXNlcjEwMzA0MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/10304208?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCondon","html_url":"https://github.com/SeanCondon","followers_url":"https://api.github.com/users/SeanCondon/followers","following_url":"https://api.github.com/users/SeanCondon/following{/other_user}","gists_url":"https://api.github.com/users/SeanCondon/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCondon/subscriptions","organizations_url":"https://api.github.com/users/SeanCondon/orgs","repos_url":"https://api.github.com/users/SeanCondon/repos","events_url":"https://api.github.com/users/SeanCondon/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCondon/received_events","type":"User","site_admin":false},"body":"I think you can drop the comment on assert.Equals","created_at":"2019-05-27T08:02:41Z","updated_at":"2019-05-27T08:03:23Z","html_url":"https://github.com/onosproject/onos-config/pull/236#discussion_r287685782","pull_request_url":"https://api.github.com/repos/onosproject/onos-config/pulls/236","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/comments/287685782"},"html":{"href":"https://github.com/onosproject/onos-config/pull/236#discussion_r287685782"},"pull_request":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/onosproject/onos-config/pulls/236","id":282350508,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyMzUwNTA4","html_url":"https://github.com/onosproject/onos-config/pull/236","diff_url":"https://github.com/onosproject/onos-config/pull/236.diff","patch_url":"https://github.com/onosproject/onos-config/pull/236.patch","issue_url":"https://api.github.com/repos/onosproject/onos-config/issues/236","number":236,"state":"open","locked":false,"title":"Fix ineffassignments reported by goreportcard","user":{"login":"adibrastegarnia","id":10365660,"node_id":"MDQ6VXNlcjEwMzY1NjYw","avatar_url":"https://avatars1.githubusercontent.com/u/10365660?v=4","gravatar_id":"","url":"https://api.github.com/users/adibrastegarnia","html_url":"https://github.com/adibrastegarnia","followers_url":"https://api.github.com/users/adibrastegarnia/followers","following_url":"https://api.github.com/users/adibrastegarnia/following{/other_user}","gists_url":"https://api.github.com/users/adibrastegarnia/gists{/gist_id}","starred_url":"https://api.github.com/users/adibrastegarnia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adibrastegarnia/subscriptions","organizations_url":"https://api.github.com/users/adibrastegarnia/orgs","repos_url":"https://api.github.com/users/adibrastegarnia/repos","events_url":"https://api.github.com/users/adibrastegarnia/events{/privacy}","received_events_url":"https://api.github.com/users/adibrastegarnia/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-27T03:02:13Z","updated_at":"2019-05-27T08:03:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"122052429ca2d10c3b510fddcc867898e7071de4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/onosproject/onos-config/pulls/236/commits","review_comments_url":"https://api.github.com/repos/onosproject/onos-config/pulls/236/comments","review_comment_url":"https://api.github.com/repos/onosproject/onos-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onosproject/onos-config/issues/236/comments","statuses_url":"https://api.github.com/repos/onosproject/onos-config/statuses/4918cc3f5d8c2098ebf6cfacf12d120313af8ee4","head":{"label":"adibrastegarnia:ineffassign","ref":"ineffassign","sha":"4918cc3f5d8c2098ebf6cfacf12d120313af8ee4","user":{"login":"adibrastegarnia","id":10365660,"node_id":"MDQ6VXNlcjEwMzY1NjYw","avatar_url":"https://avatars1.githubusercontent.com/u/10365660?v=4","gravatar_id":"","url":"https://api.github.com/users/adibrastegarnia","html_url":"https://github.com/adibrastegarnia","followers_url":"https://api.github.com/users/adibrastegarnia/followers","following_url":"https://api.github.com/users/adibrastegarnia/following{/other_user}","gists_url":"https://api.github.com/users/adibrastegarnia/gists{/gist_id}","starred_url":"https://api.github.com/users/adibrastegarnia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adibrastegarnia/subscriptions","organizations_url":"https://api.github.com/users/adibrastegarnia/orgs","repos_url":"https://api.github.com/users/adibrastegarnia/repos","events_url":"https://api.github.com/users/adibrastegarnia/events{/privacy}","received_events_url":"https://api.github.com/users/adibrastegarnia/received_events","type":"User","site_admin":false},"repo":{"id":183636621,"node_id":"MDEwOlJlcG9zaXRvcnkxODM2MzY2MjE=","name":"onos-config","full_name":"adibrastegarnia/onos-config","private":false,"owner":{"login":"adibrastegarnia","id":10365660,"node_id":"MDQ6VXNlcjEwMzY1NjYw","avatar_url":"https://avatars1.githubusercontent.com/u/10365660?v=4","gravatar_id":"","url":"https://api.github.com/users/adibrastegarnia","html_url":"https://github.com/adibrastegarnia","followers_url":"https://api.github.com/users/adibrastegarnia/followers","following_url":"https://api.github.com/users/adibrastegarnia/following{/other_user}","gists_url":"https://api.github.com/users/adibrastegarnia/gists{/gist_id}","starred_url":"https://api.github.com/users/adibrastegarnia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adibrastegarnia/subscriptions","organizations_url":"https://api.github.com/users/adibrastegarnia/orgs","repos_url":"https://api.github.com/users/adibrastegarnia/repos","events_url":"https://api.github.com/users/adibrastegarnia/events{/privacy}","received_events_url":"https://api.github.com/users/adibrastegarnia/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adibrastegarnia/onos-config","description":"Configuration subsystem for ยตONOS - a new generation ONOS architecture","fork":true,"url":"https://api.github.com/repos/adibrastegarnia/onos-config","forks_url":"https://api.github.com/repos/adibrastegarnia/onos-config/forks","keys_url":"https://api.github.com/repos/adibrastegarnia/onos-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adibrastegarnia/onos-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adibrastegarnia/onos-config/teams","hooks_url":"https://api.github.com/repos/adibrastegarnia/onos-config/hooks","issue_events_url":"https://api.github.com/repos/adibrastegarnia/onos-config/issues/events{/number}","events_url":"https://api.github.com/repos/adibrastegarnia/onos-config/events","assignees_url":"https://api.github.com/repos/adibrastegarnia/onos-config/assignees{/user}","branches_url":"https://api.github.com/repos/adibrastegarnia/onos-config/branches{/branch}","tags_url":"https://api.github.com/repos/adibrastegarnia/onos-config/tags","blobs_url":"https://api.github.com/repos/adibrastegarnia/onos-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adibrastegarnia/onos-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adibrastegarnia/onos-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/adibrastegarnia/onos-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adibrastegarnia/onos-config/statuses/{sha}","languages_url":"https://api.github.com/repos/adibrastegarnia/onos-config/languages","stargazers_url":"https://api.github.com/repos/adibrastegarnia/onos-config/stargazers","contributors_url":"https://api.github.com/repos/adibrastegarnia/onos-config/contributors","subscribers_url":"https://api.github.com/repos/adibrastegarnia/onos-config/subscribers","subscription_url":"https://api.github.com/repos/adibrastegarnia/onos-config/subscription","commits_url":"https://api.github.com/repos/adibrastegarnia/onos-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/adibrastegarnia/onos-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/adibrastegarnia/onos-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/adibrastegarnia/onos-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/adibrastegarnia/onos-config/contents/{+path}","compare_url":"https://api.github.com/repos/adibrastegarnia/onos-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adibrastegarnia/onos-config/merges","archive_url":"https://api.github.com/repos/adibrastegarnia/onos-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adibrastegarnia/onos-config/downloads","issues_url":"https://api.github.com/repos/adibrastegarnia/onos-config/issues{/number}","pulls_url":"https://api.github.com/repos/adibrastegarnia/onos-config/pulls{/number}","milestones_url":"https://api.github.com/repos/adibrastegarnia/onos-config/milestones{/number}","notifications_url":"https://api.github.com/repos/adibrastegarnia/onos-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adibrastegarnia/onos-config/labels{/name}","releases_url":"https://api.github.com/repos/adibrastegarnia/onos-config/releases{/id}","deployments_url":"https://api.github.com/repos/adibrastegarnia/onos-config/deployments","created_at":"2019-04-26T13:48:30Z","updated_at":"2019-05-17T00:48:10Z","pushed_at":"2019-05-26T04:07:27Z","git_url":"git://github.com/adibrastegarnia/onos-config.git","ssh_url":"[email protected]:adibrastegarnia/onos-config.git","clone_url":"https://github.com/adibrastegarnia/onos-config.git","svn_url":"https://github.com/adibrastegarnia/onos-config","homepage":null,"size":11893,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onosproject:master","ref":"master","sha":"a6d170bd83b6d5fc8483c7ba52f09db9df649a78","user":{"login":"onosproject","id":50352171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzUyMTcx","avatar_url":"https://avatars1.githubusercontent.com/u/50352171?v=4","gravatar_id":"","url":"https://api.github.com/users/onosproject","html_url":"https://github.com/onosproject","followers_url":"https://api.github.com/users/onosproject/followers","following_url":"https://api.github.com/users/onosproject/following{/other_user}","gists_url":"https://api.github.com/users/onosproject/gists{/gist_id}","starred_url":"https://api.github.com/users/onosproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onosproject/subscriptions","organizations_url":"https://api.github.com/users/onosproject/orgs","repos_url":"https://api.github.com/users/onosproject/repos","events_url":"https://api.github.com/users/onosproject/events{/privacy}","received_events_url":"https://api.github.com/users/onosproject/received_events","type":"Organization","site_admin":false},"repo":{"id":179540260,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk1NDAyNjA=","name":"onos-config","full_name":"onosproject/onos-config","private":false,"owner":{"login":"onosproject","id":50352171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzUyMTcx","avatar_url":"https://avatars1.githubusercontent.com/u/50352171?v=4","gravatar_id":"","url":"https://api.github.com/users/onosproject","html_url":"https://github.com/onosproject","followers_url":"https://api.github.com/users/onosproject/followers","following_url":"https://api.github.com/users/onosproject/following{/other_user}","gists_url":"https://api.github.com/users/onosproject/gists{/gist_id}","starred_url":"https://api.github.com/users/onosproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onosproject/subscriptions","organizations_url":"https://api.github.com/users/onosproject/orgs","repos_url":"https://api.github.com/users/onosproject/repos","events_url":"https://api.github.com/users/onosproject/events{/privacy}","received_events_url":"https://api.github.com/users/onosproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/onosproject/onos-config","description":"Configuration subsystem for ONOS (ยตONOS Architecture)","fork":false,"url":"https://api.github.com/repos/onosproject/onos-config","forks_url":"https://api.github.com/repos/onosproject/onos-config/forks","keys_url":"https://api.github.com/repos/onosproject/onos-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onosproject/onos-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onosproject/onos-config/teams","hooks_url":"https://api.github.com/repos/onosproject/onos-config/hooks","issue_events_url":"https://api.github.com/repos/onosproject/onos-config/issues/events{/number}","events_url":"https://api.github.com/repos/onosproject/onos-config/events","assignees_url":"https://api.github.com/repos/onosproject/onos-config/assignees{/user}","branches_url":"https://api.github.com/repos/onosproject/onos-config/branches{/branch}","tags_url":"https://api.github.com/repos/onosproject/onos-config/tags","blobs_url":"https://api.github.com/repos/onosproject/onos-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onosproject/onos-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onosproject/onos-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/onosproject/onos-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onosproject/onos-config/statuses/{sha}","languages_url":"https://api.github.com/repos/onosproject/onos-config/languages","stargazers_url":"https://api.github.com/repos/onosproject/onos-config/stargazers","contributors_url":"https://api.github.com/repos/onosproject/onos-config/contributors","subscribers_url":"https://api.github.com/repos/onosproject/onos-config/subscribers","subscription_url":"https://api.github.com/repos/onosproject/onos-config/subscription","commits_url":"https://api.github.com/repos/onosproject/onos-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/onosproject/onos-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/onosproject/onos-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/onosproject/onos-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/onosproject/onos-config/contents/{+path}","compare_url":"https://api.github.com/repos/onosproject/onos-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onosproject/onos-config/merges","archive_url":"https://api.github.com/repos/onosproject/onos-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onosproject/onos-config/downloads","issues_url":"https://api.github.com/repos/onosproject/onos-config/issues{/number}","pulls_url":"https://api.github.com/repos/onosproject/onos-config/pulls{/number}","milestones_url":"https://api.github.com/repos/onosproject/onos-config/milestones{/number}","notifications_url":"https://api.github.com/repos/onosproject/onos-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onosproject/onos-config/labels{/name}","releases_url":"https://api.github.com/repos/onosproject/onos-config/releases{/id}","deployments_url":"https://api.github.com/repos/onosproject/onos-config/deployments","created_at":"2019-04-04T16:59:02Z","updated_at":"2019-05-27T07:46:26Z","pushed_at":"2019-05-27T03:02:14Z","git_url":"git://github.com/onosproject/onos-config.git","ssh_url":"[email protected]:onosproject/onos-config.git","clone_url":"https://github.com/onosproject/onos-config.git","svn_url":"https://github.com/onosproject/onos-config","homepage":"","size":1237,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":24,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/236"},"html":{"href":"https://github.com/onosproject/onos-config/pull/236"},"issue":{"href":"https://api.github.com/repos/onosproject/onos-config/issues/236"},"comments":{"href":"https://api.github.com/repos/onosproject/onos-config/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/onosproject/onos-config/statuses/4918cc3f5d8c2098ebf6cfacf12d120313af8ee4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 179540260,
"name": "onosproject/onos-config",
"url": "https://api.github.com/repos/onosproject/onos-config"
}
|
{
"id": 10304208,
"login": "SeanCondon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10304208?",
"url": "https://api.github.com/users/SeanCondon"
}
|
{
"id": 50352171,
"login": "onosproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50352171?",
"url": "https://api.github.com/orgs/onosproject"
}
| 2019-05-27T08:02:41 |
9702168535
|
{"actor":{"display_login":"SeanCondon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/onosproject/onos-config/pulls/comments/334900356","pull_request_review_id":301840811,"id":334900356,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDkwMDM1Ng==","diff_hunk":"@@ -102,11 +100,11 @@ func Test_ConfigValue(t *testing.T) {\n \tpath := \"/cont1a/cont2a/leaf2a\"\n \tvalue := 13\n \n-\tconfigValue2a, _ := NewChangeValue(path, types.NewTypedValueUint64(uint(value)), false)\n+\tconfigValue2a, _ := types.NewChangeValue(path, types.NewTypedValueUint64(uint(value)), false)\n \n \tassert.Equal(t, configValue2a.Path, path)\n \n-\tassert.Equal(t, configValue2a.String(), \"/cont1a/cont2a/leaf2a [13 0 0 0 0 0 0 0] false\")\n+\tassert.Equal(t, configValue2a.String(), `path:\"/cont1a/cont2a/leaf2a\" value:<bytes:\"\\r\\000\\000\\000\\000\\000\\000\\000\" type:UINT > `)","path":"pkg/store/change/change_test.go","position":59,"original_position":59,"commit_id":"c92234b6591193214434a6102f1a1a5f03298cac","original_commit_id":"c92234b6591193214434a6102f1a1a5f03298cac","user":{"login":"SeanCondon","id":10304208,"node_id":"MDQ6VXNlcjEwMzA0MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/10304208?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCondon","html_url":"https://github.com/SeanCondon","followers_url":"https://api.github.com/users/SeanCondon/followers","following_url":"https://api.github.com/users/SeanCondon/following{/other_user}","gists_url":"https://api.github.com/users/SeanCondon/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCondon/subscriptions","organizations_url":"https://api.github.com/users/SeanCondon/orgs","repos_url":"https://api.github.com/users/SeanCondon/repos","events_url":"https://api.github.com/users/SeanCondon/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCondon/received_events","type":"User","site_admin":false},"body":"done","created_at":"2019-10-15T11:41:49Z","updated_at":"2019-10-15T11:41:49Z","html_url":"https://github.com/onosproject/onos-config/pull/755#discussion_r334900356","pull_request_url":"https://api.github.com/repos/onosproject/onos-config/pulls/755","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/comments/334900356"},"html":{"href":"https://github.com/onosproject/onos-config/pull/755#discussion_r334900356"},"pull_request":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/755"}},"in_reply_to_id":334892225},"pull_request":{"url":"https://api.github.com/repos/onosproject/onos-config/pulls/755","id":328202669,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4MjAyNjY5","html_url":"https://github.com/onosproject/onos-config/pull/755","diff_url":"https://github.com/onosproject/onos-config/pull/755.diff","patch_url":"https://github.com/onosproject/onos-config/pull/755.patch","issue_url":"https://api.github.com/repos/onosproject/onos-config/issues/755","number":755,"state":"open","locked":false,"title":"Removed the deprecated types ConfigValue, ChangeValue and ValueCollection","user":{"login":"SeanCondon","id":10304208,"node_id":"MDQ6VXNlcjEwMzA0MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/10304208?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCondon","html_url":"https://github.com/SeanCondon","followers_url":"https://api.github.com/users/SeanCondon/followers","following_url":"https://api.github.com/users/SeanCondon/following{/other_user}","gists_url":"https://api.github.com/users/SeanCondon/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCondon/subscriptions","organizations_url":"https://api.github.com/users/SeanCondon/orgs","repos_url":"https://api.github.com/users/SeanCondon/repos","events_url":"https://api.github.com/users/SeanCondon/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCondon/received_events","type":"User","site_admin":false},"body":"The main points are:\r\n* Modified `pkg/types/change/device/types.proto`\r\n * Created new `PathValue` - like `Value` without removed flag e.g. for OpState values\r\n * Does not affect the `DeviceChange`\r\n* Removed `pkg/store/change/configvalue.go`\r\n* Removed `pkg/store/change/changevalue.go`\r\n* Created `pkg/types/change/device/value.go` to hold methods of old `ChangeValue`\r\n\r\nAll other changes are replacing old types with new","created_at":"2019-10-15T10:46:16Z","updated_at":"2019-10-15T11:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5c26a14341d32b1d78674fef726bda039c2aa51","assignee":{"login":"SeanCondon","id":10304208,"node_id":"MDQ6VXNlcjEwMzA0MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/10304208?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCondon","html_url":"https://github.com/SeanCondon","followers_url":"https://api.github.com/users/SeanCondon/followers","following_url":"https://api.github.com/users/SeanCondon/following{/other_user}","gists_url":"https://api.github.com/users/SeanCondon/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCondon/subscriptions","organizations_url":"https://api.github.com/users/SeanCondon/orgs","repos_url":"https://api.github.com/users/SeanCondon/repos","events_url":"https://api.github.com/users/SeanCondon/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCondon/received_events","type":"User","site_admin":false},"assignees":[{"login":"SeanCondon","id":10304208,"node_id":"MDQ6VXNlcjEwMzA0MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/10304208?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCondon","html_url":"https://github.com/SeanCondon","followers_url":"https://api.github.com/users/SeanCondon/followers","following_url":"https://api.github.com/users/SeanCondon/following{/other_user}","gists_url":"https://api.github.com/users/SeanCondon/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCondon/subscriptions","organizations_url":"https://api.github.com/users/SeanCondon/orgs","repos_url":"https://api.github.com/users/SeanCondon/repos","events_url":"https://api.github.com/users/SeanCondon/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCondon/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kuujo","id":823318,"node_id":"MDQ6VXNlcjgyMzMxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/823318?v=4","gravatar_id":"","url":"https://api.github.com/users/kuujo","html_url":"https://github.com/kuujo","followers_url":"https://api.github.com/users/kuujo/followers","following_url":"https://api.github.com/users/kuujo/following{/other_user}","gists_url":"https://api.github.com/users/kuujo/gists{/gist_id}","starred_url":"https://api.github.com/users/kuujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuujo/subscriptions","organizations_url":"https://api.github.com/users/kuujo/orgs","repos_url":"https://api.github.com/users/kuujo/repos","events_url":"https://api.github.com/users/kuujo/events{/privacy}","received_events_url":"https://api.github.com/users/kuujo/received_events","type":"User","site_admin":false},{"login":"ray-milkey","id":10082144,"node_id":"MDQ6VXNlcjEwMDgyMTQ0","avatar_url":"https://avatars0.githubusercontent.com/u/10082144?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-milkey","html_url":"https://github.com/ray-milkey","followers_url":"https://api.github.com/users/ray-milkey/followers","following_url":"https://api.github.com/users/ray-milkey/following{/other_user}","gists_url":"https://api.github.com/users/ray-milkey/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-milkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-milkey/subscriptions","organizations_url":"https://api.github.com/users/ray-milkey/orgs","repos_url":"https://api.github.com/users/ray-milkey/repos","events_url":"https://api.github.com/users/ray-milkey/events{/privacy}","received_events_url":"https://api.github.com/users/ray-milkey/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1304450218,"node_id":"MDU6TGFiZWwxMzA0NDUwMjE4","url":"https://api.github.com/repos/onosproject/onos-config/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":{"url":"https://api.github.com/repos/onosproject/onos-config/milestones/9","html_url":"https://github.com/onosproject/onos-config/milestone/9","labels_url":"https://api.github.com/repos/onosproject/onos-config/milestones/9/labels","id":4666295,"node_id":"MDk6TWlsZXN0b25lNDY2NjI5NQ==","number":9,"title":"Eighth Demo","description":"The next milestone after ONF Connect","creator":{"login":"SeanCondon","id":10304208,"node_id":"MDQ6VXNlcjEwMzA0MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/10304208?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCondon","html_url":"https://github.com/SeanCondon","followers_url":"https://api.github.com/users/SeanCondon/followers","following_url":"https://api.github.com/users/SeanCondon/following{/other_user}","gists_url":"https://api.github.com/users/SeanCondon/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCondon/subscriptions","organizations_url":"https://api.github.com/users/SeanCondon/orgs","repos_url":"https://api.github.com/users/SeanCondon/repos","events_url":"https://api.github.com/users/SeanCondon/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCondon/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":47,"state":"open","created_at":"2019-09-17T11:10:47Z","updated_at":"2019-10-15T10:46:16Z","due_on":"2019-10-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/onosproject/onos-config/pulls/755/commits","review_comments_url":"https://api.github.com/repos/onosproject/onos-config/pulls/755/comments","review_comment_url":"https://api.github.com/repos/onosproject/onos-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onosproject/onos-config/issues/755/comments","statuses_url":"https://api.github.com/repos/onosproject/onos-config/statuses/c92234b6591193214434a6102f1a1a5f03298cac","head":{"label":"SeanCondon:scRemoveChangeValue","ref":"scRemoveChangeValue","sha":"c92234b6591193214434a6102f1a1a5f03298cac","user":{"login":"SeanCondon","id":10304208,"node_id":"MDQ6VXNlcjEwMzA0MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/10304208?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCondon","html_url":"https://github.com/SeanCondon","followers_url":"https://api.github.com/users/SeanCondon/followers","following_url":"https://api.github.com/users/SeanCondon/following{/other_user}","gists_url":"https://api.github.com/users/SeanCondon/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCondon/subscriptions","organizations_url":"https://api.github.com/users/SeanCondon/orgs","repos_url":"https://api.github.com/users/SeanCondon/repos","events_url":"https://api.github.com/users/SeanCondon/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCondon/received_events","type":"User","site_admin":false},"repo":{"id":195755333,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU3NTUzMzM=","name":"onos-config","full_name":"SeanCondon/onos-config","private":false,"owner":{"login":"SeanCondon","id":10304208,"node_id":"MDQ6VXNlcjEwMzA0MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/10304208?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCondon","html_url":"https://github.com/SeanCondon","followers_url":"https://api.github.com/users/SeanCondon/followers","following_url":"https://api.github.com/users/SeanCondon/following{/other_user}","gists_url":"https://api.github.com/users/SeanCondon/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCondon/subscriptions","organizations_url":"https://api.github.com/users/SeanCondon/orgs","repos_url":"https://api.github.com/users/SeanCondon/repos","events_url":"https://api.github.com/users/SeanCondon/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCondon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SeanCondon/onos-config","description":"Configuration subsystem for ONOS (ยตONOS Architecture)","fork":true,"url":"https://api.github.com/repos/SeanCondon/onos-config","forks_url":"https://api.github.com/repos/SeanCondon/onos-config/forks","keys_url":"https://api.github.com/repos/SeanCondon/onos-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeanCondon/onos-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeanCondon/onos-config/teams","hooks_url":"https://api.github.com/repos/SeanCondon/onos-config/hooks","issue_events_url":"https://api.github.com/repos/SeanCondon/onos-config/issues/events{/number}","events_url":"https://api.github.com/repos/SeanCondon/onos-config/events","assignees_url":"https://api.github.com/repos/SeanCondon/onos-config/assignees{/user}","branches_url":"https://api.github.com/repos/SeanCondon/onos-config/branches{/branch}","tags_url":"https://api.github.com/repos/SeanCondon/onos-config/tags","blobs_url":"https://api.github.com/repos/SeanCondon/onos-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeanCondon/onos-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeanCondon/onos-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeanCondon/onos-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeanCondon/onos-config/statuses/{sha}","languages_url":"https://api.github.com/repos/SeanCondon/onos-config/languages","stargazers_url":"https://api.github.com/repos/SeanCondon/onos-config/stargazers","contributors_url":"https://api.github.com/repos/SeanCondon/onos-config/contributors","subscribers_url":"https://api.github.com/repos/SeanCondon/onos-config/subscribers","subscription_url":"https://api.github.com/repos/SeanCondon/onos-config/subscription","commits_url":"https://api.github.com/repos/SeanCondon/onos-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeanCondon/onos-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeanCondon/onos-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeanCondon/onos-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeanCondon/onos-config/contents/{+path}","compare_url":"https://api.github.com/repos/SeanCondon/onos-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeanCondon/onos-config/merges","archive_url":"https://api.github.com/repos/SeanCondon/onos-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeanCondon/onos-config/downloads","issues_url":"https://api.github.com/repos/SeanCondon/onos-config/issues{/number}","pulls_url":"https://api.github.com/repos/SeanCondon/onos-config/pulls{/number}","milestones_url":"https://api.github.com/repos/SeanCondon/onos-config/milestones{/number}","notifications_url":"https://api.github.com/repos/SeanCondon/onos-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeanCondon/onos-config/labels{/name}","releases_url":"https://api.github.com/repos/SeanCondon/onos-config/releases{/id}","deployments_url":"https://api.github.com/repos/SeanCondon/onos-config/deployments","created_at":"2019-07-08T07:05:31Z","updated_at":"2019-07-30T08:11:59Z","pushed_at":"2019-10-15T10:39:17Z","git_url":"git://github.com/SeanCondon/onos-config.git","ssh_url":"[email protected]:SeanCondon/onos-config.git","clone_url":"https://github.com/SeanCondon/onos-config.git","svn_url":"https://github.com/SeanCondon/onos-config","homepage":"","size":9034,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onosproject:master","ref":"master","sha":"91faaf1cda18106ef605fe05cde579f81cc46797","user":{"login":"onosproject","id":50352171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzUyMTcx","avatar_url":"https://avatars1.githubusercontent.com/u/50352171?v=4","gravatar_id":"","url":"https://api.github.com/users/onosproject","html_url":"https://github.com/onosproject","followers_url":"https://api.github.com/users/onosproject/followers","following_url":"https://api.github.com/users/onosproject/following{/other_user}","gists_url":"https://api.github.com/users/onosproject/gists{/gist_id}","starred_url":"https://api.github.com/users/onosproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onosproject/subscriptions","organizations_url":"https://api.github.com/users/onosproject/orgs","repos_url":"https://api.github.com/users/onosproject/repos","events_url":"https://api.github.com/users/onosproject/events{/privacy}","received_events_url":"https://api.github.com/users/onosproject/received_events","type":"Organization","site_admin":false},"repo":{"id":179540260,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk1NDAyNjA=","name":"onos-config","full_name":"onosproject/onos-config","private":false,"owner":{"login":"onosproject","id":50352171,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzUyMTcx","avatar_url":"https://avatars1.githubusercontent.com/u/50352171?v=4","gravatar_id":"","url":"https://api.github.com/users/onosproject","html_url":"https://github.com/onosproject","followers_url":"https://api.github.com/users/onosproject/followers","following_url":"https://api.github.com/users/onosproject/following{/other_user}","gists_url":"https://api.github.com/users/onosproject/gists{/gist_id}","starred_url":"https://api.github.com/users/onosproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onosproject/subscriptions","organizations_url":"https://api.github.com/users/onosproject/orgs","repos_url":"https://api.github.com/users/onosproject/repos","events_url":"https://api.github.com/users/onosproject/events{/privacy}","received_events_url":"https://api.github.com/users/onosproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/onosproject/onos-config","description":"Configuration subsystem for ONOS (ยตONOS Architecture)","fork":false,"url":"https://api.github.com/repos/onosproject/onos-config","forks_url":"https://api.github.com/repos/onosproject/onos-config/forks","keys_url":"https://api.github.com/repos/onosproject/onos-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onosproject/onos-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onosproject/onos-config/teams","hooks_url":"https://api.github.com/repos/onosproject/onos-config/hooks","issue_events_url":"https://api.github.com/repos/onosproject/onos-config/issues/events{/number}","events_url":"https://api.github.com/repos/onosproject/onos-config/events","assignees_url":"https://api.github.com/repos/onosproject/onos-config/assignees{/user}","branches_url":"https://api.github.com/repos/onosproject/onos-config/branches{/branch}","tags_url":"https://api.github.com/repos/onosproject/onos-config/tags","blobs_url":"https://api.github.com/repos/onosproject/onos-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onosproject/onos-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onosproject/onos-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/onosproject/onos-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onosproject/onos-config/statuses/{sha}","languages_url":"https://api.github.com/repos/onosproject/onos-config/languages","stargazers_url":"https://api.github.com/repos/onosproject/onos-config/stargazers","contributors_url":"https://api.github.com/repos/onosproject/onos-config/contributors","subscribers_url":"https://api.github.com/repos/onosproject/onos-config/subscribers","subscription_url":"https://api.github.com/repos/onosproject/onos-config/subscription","commits_url":"https://api.github.com/repos/onosproject/onos-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/onosproject/onos-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/onosproject/onos-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/onosproject/onos-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/onosproject/onos-config/contents/{+path}","compare_url":"https://api.github.com/repos/onosproject/onos-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onosproject/onos-config/merges","archive_url":"https://api.github.com/repos/onosproject/onos-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onosproject/onos-config/downloads","issues_url":"https://api.github.com/repos/onosproject/onos-config/issues{/number}","pulls_url":"https://api.github.com/repos/onosproject/onos-config/pulls{/number}","milestones_url":"https://api.github.com/repos/onosproject/onos-config/milestones{/number}","notifications_url":"https://api.github.com/repos/onosproject/onos-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onosproject/onos-config/labels{/name}","releases_url":"https://api.github.com/repos/onosproject/onos-config/releases{/id}","deployments_url":"https://api.github.com/repos/onosproject/onos-config/deployments","created_at":"2019-04-04T16:59:02Z","updated_at":"2019-10-14T19:21:10Z","pushed_at":"2019-10-15T10:46:17Z","git_url":"git://github.com/onosproject/onos-config.git","ssh_url":"[email protected]:onosproject/onos-config.git","clone_url":"https://github.com/onosproject/onos-config.git","svn_url":"https://github.com/onosproject/onos-config","homepage":"","size":8969,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":17,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/755"},"html":{"href":"https://github.com/onosproject/onos-config/pull/755"},"issue":{"href":"https://api.github.com/repos/onosproject/onos-config/issues/755"},"comments":{"href":"https://api.github.com/repos/onosproject/onos-config/issues/755/comments"},"review_comments":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/755/comments"},"review_comment":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onosproject/onos-config/pulls/755/commits"},"statuses":{"href":"https://api.github.com/repos/onosproject/onos-config/statuses/c92234b6591193214434a6102f1a1a5f03298cac"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 179540260,
"name": "onosproject/onos-config",
"url": "https://api.github.com/repos/onosproject/onos-config"
}
|
{
"id": 10304208,
"login": "SeanCondon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10304208?",
"url": "https://api.github.com/users/SeanCondon"
}
|
{
"id": 50352171,
"login": "onosproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50352171?",
"url": "https://api.github.com/orgs/onosproject"
}
| 2019-10-15T11:41:49 |
10633016531
|
{"actor":{"display_login":"SeanCondon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/entropic-dev/entropic/pulls/comments/291783360","pull_request_review_id":247342266,"id":291783360,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTc4MzM2MA==","diff_hunk":"@@ -0,0 +1,128 @@\n+# Package.toml format\n+\n+A proposal for a more formal Package.toml definition\n+\n+- Version: DRAFT\n+- Date: 06/06/2019\n+- Authors\n+ - Todd Kennedy <[email protected]>\n+\n+## Abstract\n+\n+This document is meant to describe the package manifest format for Entropic,\n+a federated solution to package management. Entropic needs to have its own\n+manifest file due to conflicts arising from the namespacing entropic uses.\n+\n+The key words \"MUST\", \"MUST NOT\", \"REQUIRED\", \"SHALL\", \"SHALL NOT\", \"SHOULD\",\n+\"SHOULD NOT\", \"RECOMMENDED\", \"MAY\", and \"OPTIONAL\" in this document are to be\n+interpreted as described in [RFC 2119](https://tools.ietf.org/html/rfc2119).\n+\n+## Copyright\n+\n+This document is copyright by its individual contributors, and available for\n+re-use under [CC BY 4.0](https://creativecommons.org/licenses/by/4.0/)\n+\n+## Introduction\n+\n+Entropic cannot share a manifest format with the traditional `package.json` format\n+associated with the ECMAScript ecosystem for a number of reasons:\n+\n+1. Entropic is intended to allow for federated package management for more than just the ECMAScript ecosystem\n+1. The `package.json` name specifier does not allow for the namespacing that entropic provides\n+1. There are recognized deficiencies with using JSON as human-readable metadata format\n+\n+## Filename\n+\n+The filename of the manifest **MUST** be `Package.toml` and it **MUST** live in\n+the root directory of the package's filesystem. The root of the package is defined\n+as the closest parent directory that contains the manifest file, starting with\n+the current directory.\n+\n+On case-insensitive filesystems, it **MAY** be presented as `package.toml` but care\n+should be taken to preserve case when possible.\n+\n+## Format\n+\n+The format of this file is **REQUIRED** to be in [TOML](https://github.com/toml-lang/toml)\n+version 0.5.0 or later as defined by the project.\n+\n+### Top-Level Data\n+\n+The manifest **MUST** contain the following top-level keys:\n+\n+- `\"name\"` - the canonical name of the package, as a string, including it's namespace. e.g. `\"[email protected]/packge2toml\"`\n+- `\"version\"` - a [SEMVER](https://semver.org/) designation conforming to version 2.0.0 of the semantic versioning specification. Due to how TOML parses numbers, this must be represented as a string. e.g. `\"1.0.4\"`\n+\n+The manifest **MAY** contain the following fields:\n+\n+- `\"entry\"` - the filename and package-relative path, as a string, to the main entry point of the package. The root for the relative-path is the directory which contains the `Package.toml` file. e.g `\"./src/index.js\"`\n+- `\"type\"` - if set to `\"module\"` this will output a [`package.json` with this included](https://nodejs.org/api/esm.html#esm_code_package_json_code_code_type_code_field), and will signal to the node interpreter to run this code an ES6 Module.\n+- `\"license\"` - a valid [SPDX license](https://spdx.org/licenses/) for your code. If a license is not provided then the code is considered to be `UNLICENSED`.\n+- `\"description\"` - a short description of your package\n+- `\"homepage\"` - a URL for your project's homepage\n+- `\"author\"` - who wrote this package\n+- `\"repository\"` - where does this code live\n+\n+These fields **MAY** or **MAY NOT** be validated by CLI tools or the server-side\n+software, depending on the implementation.\n+\n+Software implementing the entropic federation protocols and `Package.toml` handling **MAY** complain about any of these optional fields as missing (`license` being an obvious candidate).\n+\n+### Subsections\n+\n+The manifest file **MAY** contain zero or more subsections as defined below.\n+\n+#### Dependency Lists\n+\n+Dependencies lists contain all the resources that are required for\n+this package, in various scenarios. The dependencies **MUST** be declared as `\"key\" = \"value\"`\n+pairs where the `key` is the package's canonical name (as from the top-level section","path":"docs/RFCs/package-toml.md","position":79,"original_position":79,"commit_id":"7989280d1db5ea5697f0de735c3d73ea3d82e816","original_commit_id":"7989280d1db5ea5697f0de735c3d73ea3d82e816","user":{"login":"chrisdickinson","id":37303,"node_id":"MDQ6VXNlcjM3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/37303?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdickinson","html_url":"https://github.com/chrisdickinson","followers_url":"https://api.github.com/users/chrisdickinson/followers","following_url":"https://api.github.com/users/chrisdickinson/following{/other_user}","gists_url":"https://api.github.com/users/chrisdickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdickinson/subscriptions","organizations_url":"https://api.github.com/users/chrisdickinson/orgs","repos_url":"https://api.github.com/users/chrisdickinson/repos","events_url":"https://api.github.com/users/chrisdickinson/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdickinson/received_events","type":"User","site_admin":false},"body":"YES this. I'd also like to reserve the ability for applications to \"open\" a dependency to patch it, a la Cargo:\r\n\r\n```toml\r\n[dependencies.\"[email protected]/foo\".dependencies.\"lodash\"]\r\npatch = \"[email protected]/underscore\"\r\n```","created_at":"2019-06-07T23:49:57Z","updated_at":"2019-06-07T23:49:57Z","html_url":"https://github.com/entropic-dev/entropic/pull/189#discussion_r291783360","pull_request_url":"https://api.github.com/repos/entropic-dev/entropic/pulls/189","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/entropic-dev/entropic/pulls/comments/291783360"},"html":{"href":"https://github.com/entropic-dev/entropic/pull/189#discussion_r291783360"},"pull_request":{"href":"https://api.github.com/repos/entropic-dev/entropic/pulls/189"}},"in_reply_to_id":291767838},"pull_request":{"url":"https://api.github.com/repos/entropic-dev/entropic/pulls/189","id":285998516,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1OTk4NTE2","html_url":"https://github.com/entropic-dev/entropic/pull/189","diff_url":"https://github.com/entropic-dev/entropic/pull/189.diff","patch_url":"https://github.com/entropic-dev/entropic/pull/189.patch","issue_url":"https://api.github.com/repos/entropic-dev/entropic/issues/189","number":189,"state":"open","locked":false,"title":"Add RFC for Package.toml format","user":{"login":"toddself","id":193412,"node_id":"MDQ6VXNlcjE5MzQxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/193412?v=4","gravatar_id":"","url":"https://api.github.com/users/toddself","html_url":"https://github.com/toddself","followers_url":"https://api.github.com/users/toddself/followers","following_url":"https://api.github.com/users/toddself/following{/other_user}","gists_url":"https://api.github.com/users/toddself/gists{/gist_id}","starred_url":"https://api.github.com/users/toddself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddself/subscriptions","organizations_url":"https://api.github.com/users/toddself/orgs","repos_url":"https://api.github.com/users/toddself/repos","events_url":"https://api.github.com/users/toddself/events{/privacy}","received_events_url":"https://api.github.com/users/toddself/received_events","type":"User","site_admin":false},"body":"There are a few things that we likely can add to this, but this covers\nthe format as it is along with an \"entrypoint\" specification which we\nneed currently!","created_at":"2019-06-06T23:01:10Z","updated_at":"2019-06-07T23:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d99d8373a9c91131c0baad54ec9c0291b201ebd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1394187845,"node_id":"MDU6TGFiZWwxMzk0MTg3ODQ1","url":"https://api.github.com/repos/entropic-dev/entropic/labels/docs","name":"docs","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/entropic-dev/entropic/pulls/189/commits","review_comments_url":"https://api.github.com/repos/entropic-dev/entropic/pulls/189/comments","review_comment_url":"https://api.github.com/repos/entropic-dev/entropic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/entropic-dev/entropic/issues/189/comments","statuses_url":"https://api.github.com/repos/entropic-dev/entropic/statuses/7989280d1db5ea5697f0de735c3d73ea3d82e816","head":{"label":"toddself:package-toml-rfc","ref":"package-toml-rfc","sha":"7989280d1db5ea5697f0de735c3d73ea3d82e816","user":{"login":"toddself","id":193412,"node_id":"MDQ6VXNlcjE5MzQxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/193412?v=4","gravatar_id":"","url":"https://api.github.com/users/toddself","html_url":"https://github.com/toddself","followers_url":"https://api.github.com/users/toddself/followers","following_url":"https://api.github.com/users/toddself/following{/other_user}","gists_url":"https://api.github.com/users/toddself/gists{/gist_id}","starred_url":"https://api.github.com/users/toddself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddself/subscriptions","organizations_url":"https://api.github.com/users/toddself/orgs","repos_url":"https://api.github.com/users/toddself/repos","events_url":"https://api.github.com/users/toddself/events{/privacy}","received_events_url":"https://api.github.com/users/toddself/received_events","type":"User","site_admin":false},"repo":{"id":189765484,"node_id":"MDEwOlJlcG9zaXRvcnkxODk3NjU0ODQ=","name":"entropic","full_name":"toddself/entropic","private":false,"owner":{"login":"toddself","id":193412,"node_id":"MDQ6VXNlcjE5MzQxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/193412?v=4","gravatar_id":"","url":"https://api.github.com/users/toddself","html_url":"https://github.com/toddself","followers_url":"https://api.github.com/users/toddself/followers","following_url":"https://api.github.com/users/toddself/following{/other_user}","gists_url":"https://api.github.com/users/toddself/gists{/gist_id}","starred_url":"https://api.github.com/users/toddself/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddself/subscriptions","organizations_url":"https://api.github.com/users/toddself/orgs","repos_url":"https://api.github.com/users/toddself/repos","events_url":"https://api.github.com/users/toddself/events{/privacy}","received_events_url":"https://api.github.com/users/toddself/received_events","type":"User","site_admin":false},"html_url":"https://github.com/toddself/entropic","description":"a package registry for anything, but mostly javascript","fork":true,"url":"https://api.github.com/repos/toddself/entropic","forks_url":"https://api.github.com/repos/toddself/entropic/forks","keys_url":"https://api.github.com/repos/toddself/entropic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toddself/entropic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toddself/entropic/teams","hooks_url":"https://api.github.com/repos/toddself/entropic/hooks","issue_events_url":"https://api.github.com/repos/toddself/entropic/issues/events{/number}","events_url":"https://api.github.com/repos/toddself/entropic/events","assignees_url":"https://api.github.com/repos/toddself/entropic/assignees{/user}","branches_url":"https://api.github.com/repos/toddself/entropic/branches{/branch}","tags_url":"https://api.github.com/repos/toddself/entropic/tags","blobs_url":"https://api.github.com/repos/toddself/entropic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toddself/entropic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toddself/entropic/git/refs{/sha}","trees_url":"https://api.github.com/repos/toddself/entropic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toddself/entropic/statuses/{sha}","languages_url":"https://api.github.com/repos/toddself/entropic/languages","stargazers_url":"https://api.github.com/repos/toddself/entropic/stargazers","contributors_url":"https://api.github.com/repos/toddself/entropic/contributors","subscribers_url":"https://api.github.com/repos/toddself/entropic/subscribers","subscription_url":"https://api.github.com/repos/toddself/entropic/subscription","commits_url":"https://api.github.com/repos/toddself/entropic/commits{/sha}","git_commits_url":"https://api.github.com/repos/toddself/entropic/git/commits{/sha}","comments_url":"https://api.github.com/repos/toddself/entropic/comments{/number}","issue_comment_url":"https://api.github.com/repos/toddself/entropic/issues/comments{/number}","contents_url":"https://api.github.com/repos/toddself/entropic/contents/{+path}","compare_url":"https://api.github.com/repos/toddself/entropic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toddself/entropic/merges","archive_url":"https://api.github.com/repos/toddself/entropic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toddself/entropic/downloads","issues_url":"https://api.github.com/repos/toddself/entropic/issues{/number}","pulls_url":"https://api.github.com/repos/toddself/entropic/pulls{/number}","milestones_url":"https://api.github.com/repos/toddself/entropic/milestones{/number}","notifications_url":"https://api.github.com/repos/toddself/entropic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toddself/entropic/labels{/name}","releases_url":"https://api.github.com/repos/toddself/entropic/releases{/id}","deployments_url":"https://api.github.com/repos/toddself/entropic/deployments","created_at":"2019-06-01T18:27:43Z","updated_at":"2019-06-06T22:11:13Z","pushed_at":"2019-06-07T02:39:53Z","git_url":"git://github.com/toddself/entropic.git","ssh_url":"[email protected]:toddself/entropic.git","clone_url":"https://github.com/toddself/entropic.git","svn_url":"https://github.com/toddself/entropic","homepage":"","size":1104,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"entropic-dev:master","ref":"master","sha":"bf18c03f6354ea13e994c3bdb3e0f0f7412394ce","user":{"login":"entropic-dev","id":50472210,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNDcyMjEw","avatar_url":"https://avatars2.githubusercontent.com/u/50472210?v=4","gravatar_id":"","url":"https://api.github.com/users/entropic-dev","html_url":"https://github.com/entropic-dev","followers_url":"https://api.github.com/users/entropic-dev/followers","following_url":"https://api.github.com/users/entropic-dev/following{/other_user}","gists_url":"https://api.github.com/users/entropic-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/entropic-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/entropic-dev/subscriptions","organizations_url":"https://api.github.com/users/entropic-dev/orgs","repos_url":"https://api.github.com/users/entropic-dev/repos","events_url":"https://api.github.com/users/entropic-dev/events{/privacy}","received_events_url":"https://api.github.com/users/entropic-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":182423586,"node_id":"MDEwOlJlcG9zaXRvcnkxODI0MjM1ODY=","name":"entropic","full_name":"entropic-dev/entropic","private":false,"owner":{"login":"entropic-dev","id":50472210,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNDcyMjEw","avatar_url":"https://avatars2.githubusercontent.com/u/50472210?v=4","gravatar_id":"","url":"https://api.github.com/users/entropic-dev","html_url":"https://github.com/entropic-dev","followers_url":"https://api.github.com/users/entropic-dev/followers","following_url":"https://api.github.com/users/entropic-dev/following{/other_user}","gists_url":"https://api.github.com/users/entropic-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/entropic-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/entropic-dev/subscriptions","organizations_url":"https://api.github.com/users/entropic-dev/orgs","repos_url":"https://api.github.com/users/entropic-dev/repos","events_url":"https://api.github.com/users/entropic-dev/events{/privacy}","received_events_url":"https://api.github.com/users/entropic-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/entropic-dev/entropic","description":"๐ฆ :package: a package registry for anything, but mostly javascript ๐ฆ ๐ฆ ๐ฆ","fork":false,"url":"https://api.github.com/repos/entropic-dev/entropic","forks_url":"https://api.github.com/repos/entropic-dev/entropic/forks","keys_url":"https://api.github.com/repos/entropic-dev/entropic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/entropic-dev/entropic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/entropic-dev/entropic/teams","hooks_url":"https://api.github.com/repos/entropic-dev/entropic/hooks","issue_events_url":"https://api.github.com/repos/entropic-dev/entropic/issues/events{/number}","events_url":"https://api.github.com/repos/entropic-dev/entropic/events","assignees_url":"https://api.github.com/repos/entropic-dev/entropic/assignees{/user}","branches_url":"https://api.github.com/repos/entropic-dev/entropic/branches{/branch}","tags_url":"https://api.github.com/repos/entropic-dev/entropic/tags","blobs_url":"https://api.github.com/repos/entropic-dev/entropic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/entropic-dev/entropic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/entropic-dev/entropic/git/refs{/sha}","trees_url":"https://api.github.com/repos/entropic-dev/entropic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/entropic-dev/entropic/statuses/{sha}","languages_url":"https://api.github.com/repos/entropic-dev/entropic/languages","stargazers_url":"https://api.github.com/repos/entropic-dev/entropic/stargazers","contributors_url":"https://api.github.com/repos/entropic-dev/entropic/contributors","subscribers_url":"https://api.github.com/repos/entropic-dev/entropic/subscribers","subscription_url":"https://api.github.com/repos/entropic-dev/entropic/subscription","commits_url":"https://api.github.com/repos/entropic-dev/entropic/commits{/sha}","git_commits_url":"https://api.github.com/repos/entropic-dev/entropic/git/commits{/sha}","comments_url":"https://api.github.com/repos/entropic-dev/entropic/comments{/number}","issue_comment_url":"https://api.github.com/repos/entropic-dev/entropic/issues/comments{/number}","contents_url":"https://api.github.com/repos/entropic-dev/entropic/contents/{+path}","compare_url":"https://api.github.com/repos/entropic-dev/entropic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/entropic-dev/entropic/merges","archive_url":"https://api.github.com/repos/entropic-dev/entropic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/entropic-dev/entropic/downloads","issues_url":"https://api.github.com/repos/entropic-dev/entropic/issues{/number}","pulls_url":"https://api.github.com/repos/entropic-dev/entropic/pulls{/number}","milestones_url":"https://api.github.com/repos/entropic-dev/entropic/milestones{/number}","notifications_url":"https://api.github.com/repos/entropic-dev/entropic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/entropic-dev/entropic/labels{/name}","releases_url":"https://api.github.com/repos/entropic-dev/entropic/releases{/id}","deployments_url":"https://api.github.com/repos/entropic-dev/entropic/deployments","created_at":"2019-04-20T15:39:32Z","updated_at":"2019-06-07T23:12:30Z","pushed_at":"2019-06-07T18:55:45Z","git_url":"git://github.com/entropic-dev/entropic.git","ssh_url":"[email protected]:entropic-dev/entropic.git","clone_url":"https://github.com/entropic-dev/entropic.git","svn_url":"https://github.com/entropic-dev/entropic","homepage":"","size":1120,"stargazers_count":2091,"watchers_count":2091,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":71,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":75,"open_issues":71,"watchers":2091,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/entropic-dev/entropic/pulls/189"},"html":{"href":"https://github.com/entropic-dev/entropic/pull/189"},"issue":{"href":"https://api.github.com/repos/entropic-dev/entropic/issues/189"},"comments":{"href":"https://api.github.com/repos/entropic-dev/entropic/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/entropic-dev/entropic/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/entropic-dev/entropic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/entropic-dev/entropic/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/entropic-dev/entropic/statuses/7989280d1db5ea5697f0de735c3d73ea3d82e816"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 182423586,
"name": "entropic-dev/entropic",
"url": "https://api.github.com/repos/entropic-dev/entropic"
}
|
{
"id": 37303,
"login": "chrisdickinson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/37303?",
"url": "https://api.github.com/users/chrisdickinson"
}
|
{
"id": 50472210,
"login": "entropic-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50472210?",
"url": "https://api.github.com/orgs/entropic-dev"
}
| 2019-06-07T23:49:57 |
9782461802
|
{"actor":{"display_login":"chrisdickinson"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/coding-monads/react-starter/pulls/comments/294969086","pull_request_review_id":251271314,"id":294969086,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDk2OTA4Ng==","diff_hunk":"@@ -0,0 +1,153 @@\n+import React, { FC } from \"react\";\n+import { connect } from \"react-redux\";\n+import axios from \"axios\";\n+import * as Yup from \"yup\";\n+import { withFormik, FormikProps, Form, Field } from \"formik\";\n+import styled from \"styled-components\";\n+import MadeWithLove from \"../../components/MadeWithLove/MadeWithLove\";\n+import TextHelper from \"../../components/TextHelper/TextHelper\";\n+import TextLink from \"../../components/TextLink/TextLink\";\n+import TextField from \"../../components/TextField/TextField\";\n+import Button from \"../../components/Button/Button\";\n+import Container from \"../../components/Container/Container\";\n+import { IconAvatarLock } from \"../../components/AvatarIcon/AvatarIcon\";\n+import TextHeading from \"../../components/TextHeading/TextHeading\";\n+import { addAlert, CanAddAlert } from \"../../store/actions/alertActions\";\n+\n+const StyledFormikForm = styled(Form)`\n+ display: grid;\n+ grid-gap: 15px;\n+ width: 100%;\n+ max-width: 400px;\n+ padding: 20px 0;\n+`;\n+\n+interface FormValues {\n+ token: string;\n+ password: string;\n+ passwordConfirm: string;\n+}\n+\n+interface OtherProps {\n+ message?: string;\n+}\n+\n+const UpdatePasswordForm = (props: OtherProps & FormikProps<FormValues>) => {\n+ const { touched, errors, isSubmitting, message } = props;\n+ return (\n+ <StyledFormikForm>\n+ <h1>{message}</h1>\n+\n+ <Field\n+ name=\"password\"\n+ type=\"password\"\n+ error={!!errors.password}\n+ label=\"Password*\"\n+ outllined\n+ component={TextField}\n+ />\n+ <Field\n+ name=\"passwordConfirm\"\n+ type=\"password\"\n+ error={!!errors.passwordConfirm}\n+ label=\"Password Confirm*\"\n+ outllined\n+ component={TextField}\n+ />\n+ {touched.password && errors.password && (\n+ <TextHelper error component=\"div\">\n+ <p style={{ marginBottom: \"5px\" }}>- {errors.password}</p>\n+ </TextHelper>\n+ )}\n+ {touched.passwordConfirm && errors.passwordConfirm && (\n+ <TextHelper error component=\"div\">\n+ <p style={{ marginBottom: \"5px\" }}>- {errors.passwordConfirm}</p>\n+ </TextHelper>\n+ )}\n+ <Button type=\"submit\" color=\"primary\" disabled={isSubmitting}>\n+ Update password\n+ </Button>\n+ </StyledFormikForm>\n+ );\n+};\n+\n+interface UpdatePasswordFormProps {\n+ token: string;\n+ message?: string;\n+}\n+\n+const ResetPasswordSchema = Yup.object().shape({\n+ password: Yup.string()\n+ .min(6, \"Password length must be at least 6 characters\")\n+ .required(\"Password is required\"),\n+ passwordConfirm: Yup.string()\n+ .oneOf([Yup.ref(\"password\"), null], \"Passwords must match\")\n+ .min(6, \"Password repeat length must be at least 6 characters\")\n+ .required(\"Password repeat is required\")\n+});\n+\n+const UpdatePasswordFormWrapper = withFormik<","path":"client/src/containers/UpdatePassword/UpdatePassword.tsx","position":89,"original_position":89,"commit_id":"5f4145b4b590eb78d19b2b4be2283ad6faa8ba75","original_commit_id":"5f4145b4b590eb78d19b2b4be2283ad6faa8ba75","user":{"login":"kamilmoskal","id":45687747,"node_id":"MDQ6VXNlcjQ1Njg3NzQ3","avatar_url":"https://avatars3.githubusercontent.com/u/45687747?v=4","gravatar_id":"","url":"https://api.github.com/users/kamilmoskal","html_url":"https://github.com/kamilmoskal","followers_url":"https://api.github.com/users/kamilmoskal/followers","following_url":"https://api.github.com/users/kamilmoskal/following{/other_user}","gists_url":"https://api.github.com/users/kamilmoskal/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilmoskal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilmoskal/subscriptions","organizations_url":"https://api.github.com/users/kamilmoskal/orgs","repos_url":"https://api.github.com/users/kamilmoskal/repos","events_url":"https://api.github.com/users/kamilmoskal/events{/privacy}","received_events_url":"https://api.github.com/users/kamilmoskal/received_events","type":"User","site_admin":false},"body":"I wonder if it's better structure than I did SignInForm.tsx? I mean keeping validationSchema above component and functions logic in the top / Formik form in the bottom of component. It isn't better than seperate component and logic due to add withFormik after component","created_at":"2019-06-18T18:36:46Z","updated_at":"2019-06-18T18:44:05Z","html_url":"https://github.com/coding-monads/react-starter/pull/48#discussion_r294969086","pull_request_url":"https://api.github.com/repos/coding-monads/react-starter/pulls/48","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coding-monads/react-starter/pulls/comments/294969086"},"html":{"href":"https://github.com/coding-monads/react-starter/pull/48#discussion_r294969086"},"pull_request":{"href":"https://api.github.com/repos/coding-monads/react-starter/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/coding-monads/react-starter/pulls/48","id":289010453,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MDEwNDUz","html_url":"https://github.com/coding-monads/react-starter/pull/48","diff_url":"https://github.com/coding-monads/react-starter/pull/48.diff","patch_url":"https://github.com/coding-monads/react-starter/pull/48.patch","issue_url":"https://api.github.com/repos/coding-monads/react-starter/issues/48","number":48,"state":"open","locked":false,"title":"Feature/nt 0017","user":{"login":"damian0o","id":1453374,"node_id":"MDQ6VXNlcjE0NTMzNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1453374?v=4","gravatar_id":"","url":"https://api.github.com/users/damian0o","html_url":"https://github.com/damian0o","followers_url":"https://api.github.com/users/damian0o/followers","following_url":"https://api.github.com/users/damian0o/following{/other_user}","gists_url":"https://api.github.com/users/damian0o/gists{/gist_id}","starred_url":"https://api.github.com/users/damian0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damian0o/subscriptions","organizations_url":"https://api.github.com/users/damian0o/orgs","repos_url":"https://api.github.com/users/damian0o/repos","events_url":"https://api.github.com/users/damian0o/events{/privacy}","received_events_url":"https://api.github.com/users/damian0o/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-17T20:35:37Z","updated_at":"2019-06-18T18:44:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62e9d5f8473205b3eb99a02a5007b1dab29842e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coding-monads/react-starter/pulls/48/commits","review_comments_url":"https://api.github.com/repos/coding-monads/react-starter/pulls/48/comments","review_comment_url":"https://api.github.com/repos/coding-monads/react-starter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coding-monads/react-starter/issues/48/comments","statuses_url":"https://api.github.com/repos/coding-monads/react-starter/statuses/5f4145b4b590eb78d19b2b4be2283ad6faa8ba75","head":{"label":"coding-monads:feature/NT-0017","ref":"feature/NT-0017","sha":"5f4145b4b590eb78d19b2b4be2283ad6faa8ba75","user":{"login":"coding-monads","id":50657140,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNjU3MTQw","avatar_url":"https://avatars3.githubusercontent.com/u/50657140?v=4","gravatar_id":"","url":"https://api.github.com/users/coding-monads","html_url":"https://github.com/coding-monads","followers_url":"https://api.github.com/users/coding-monads/followers","following_url":"https://api.github.com/users/coding-monads/following{/other_user}","gists_url":"https://api.github.com/users/coding-monads/gists{/gist_id}","starred_url":"https://api.github.com/users/coding-monads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coding-monads/subscriptions","organizations_url":"https://api.github.com/users/coding-monads/orgs","repos_url":"https://api.github.com/users/coding-monads/repos","events_url":"https://api.github.com/users/coding-monads/events{/privacy}","received_events_url":"https://api.github.com/users/coding-monads/received_events","type":"Organization","site_admin":false},"repo":{"id":186851798,"node_id":"MDEwOlJlcG9zaXRvcnkxODY4NTE3OTg=","name":"react-starter","full_name":"coding-monads/react-starter","private":false,"owner":{"login":"coding-monads","id":50657140,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNjU3MTQw","avatar_url":"https://avatars3.githubusercontent.com/u/50657140?v=4","gravatar_id":"","url":"https://api.github.com/users/coding-monads","html_url":"https://github.com/coding-monads","followers_url":"https://api.github.com/users/coding-monads/followers","following_url":"https://api.github.com/users/coding-monads/following{/other_user}","gists_url":"https://api.github.com/users/coding-monads/gists{/gist_id}","starred_url":"https://api.github.com/users/coding-monads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coding-monads/subscriptions","organizations_url":"https://api.github.com/users/coding-monads/orgs","repos_url":"https://api.github.com/users/coding-monads/repos","events_url":"https://api.github.com/users/coding-monads/events{/privacy}","received_events_url":"https://api.github.com/users/coding-monads/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coding-monads/react-starter","description":null,"fork":false,"url":"https://api.github.com/repos/coding-monads/react-starter","forks_url":"https://api.github.com/repos/coding-monads/react-starter/forks","keys_url":"https://api.github.com/repos/coding-monads/react-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coding-monads/react-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coding-monads/react-starter/teams","hooks_url":"https://api.github.com/repos/coding-monads/react-starter/hooks","issue_events_url":"https://api.github.com/repos/coding-monads/react-starter/issues/events{/number}","events_url":"https://api.github.com/repos/coding-monads/react-starter/events","assignees_url":"https://api.github.com/repos/coding-monads/react-starter/assignees{/user}","branches_url":"https://api.github.com/repos/coding-monads/react-starter/branches{/branch}","tags_url":"https://api.github.com/repos/coding-monads/react-starter/tags","blobs_url":"https://api.github.com/repos/coding-monads/react-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coding-monads/react-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coding-monads/react-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/coding-monads/react-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coding-monads/react-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/coding-monads/react-starter/languages","stargazers_url":"https://api.github.com/repos/coding-monads/react-starter/stargazers","contributors_url":"https://api.github.com/repos/coding-monads/react-starter/contributors","subscribers_url":"https://api.github.com/repos/coding-monads/react-starter/subscribers","subscription_url":"https://api.github.com/repos/coding-monads/react-starter/subscription","commits_url":"https://api.github.com/repos/coding-monads/react-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/coding-monads/react-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/coding-monads/react-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/coding-monads/react-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/coding-monads/react-starter/contents/{+path}","compare_url":"https://api.github.com/repos/coding-monads/react-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coding-monads/react-starter/merges","archive_url":"https://api.github.com/repos/coding-monads/react-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coding-monads/react-starter/downloads","issues_url":"https://api.github.com/repos/coding-monads/react-starter/issues{/number}","pulls_url":"https://api.github.com/repos/coding-monads/react-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/coding-monads/react-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/coding-monads/react-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coding-monads/react-starter/labels{/name}","releases_url":"https://api.github.com/repos/coding-monads/react-starter/releases{/id}","deployments_url":"https://api.github.com/repos/coding-monads/react-starter/deployments","created_at":"2019-05-15T15:12:46Z","updated_at":"2019-06-15T13:06:27Z","pushed_at":"2019-06-18T05:00:03Z","git_url":"git://github.com/coding-monads/react-starter.git","ssh_url":"[email protected]:coding-monads/react-starter.git","clone_url":"https://github.com/coding-monads/react-starter.git","svn_url":"https://github.com/coding-monads/react-starter","homepage":null,"size":203,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":9,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"coding-monads:master","ref":"master","sha":"9a1f70578cae618f63ad592c285c4b2a68d97b64","user":{"login":"coding-monads","id":50657140,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNjU3MTQw","avatar_url":"https://avatars3.githubusercontent.com/u/50657140?v=4","gravatar_id":"","url":"https://api.github.com/users/coding-monads","html_url":"https://github.com/coding-monads","followers_url":"https://api.github.com/users/coding-monads/followers","following_url":"https://api.github.com/users/coding-monads/following{/other_user}","gists_url":"https://api.github.com/users/coding-monads/gists{/gist_id}","starred_url":"https://api.github.com/users/coding-monads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coding-monads/subscriptions","organizations_url":"https://api.github.com/users/coding-monads/orgs","repos_url":"https://api.github.com/users/coding-monads/repos","events_url":"https://api.github.com/users/coding-monads/events{/privacy}","received_events_url":"https://api.github.com/users/coding-monads/received_events","type":"Organization","site_admin":false},"repo":{"id":186851798,"node_id":"MDEwOlJlcG9zaXRvcnkxODY4NTE3OTg=","name":"react-starter","full_name":"coding-monads/react-starter","private":false,"owner":{"login":"coding-monads","id":50657140,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNjU3MTQw","avatar_url":"https://avatars3.githubusercontent.com/u/50657140?v=4","gravatar_id":"","url":"https://api.github.com/users/coding-monads","html_url":"https://github.com/coding-monads","followers_url":"https://api.github.com/users/coding-monads/followers","following_url":"https://api.github.com/users/coding-monads/following{/other_user}","gists_url":"https://api.github.com/users/coding-monads/gists{/gist_id}","starred_url":"https://api.github.com/users/coding-monads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coding-monads/subscriptions","organizations_url":"https://api.github.com/users/coding-monads/orgs","repos_url":"https://api.github.com/users/coding-monads/repos","events_url":"https://api.github.com/users/coding-monads/events{/privacy}","received_events_url":"https://api.github.com/users/coding-monads/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coding-monads/react-starter","description":null,"fork":false,"url":"https://api.github.com/repos/coding-monads/react-starter","forks_url":"https://api.github.com/repos/coding-monads/react-starter/forks","keys_url":"https://api.github.com/repos/coding-monads/react-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coding-monads/react-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coding-monads/react-starter/teams","hooks_url":"https://api.github.com/repos/coding-monads/react-starter/hooks","issue_events_url":"https://api.github.com/repos/coding-monads/react-starter/issues/events{/number}","events_url":"https://api.github.com/repos/coding-monads/react-starter/events","assignees_url":"https://api.github.com/repos/coding-monads/react-starter/assignees{/user}","branches_url":"https://api.github.com/repos/coding-monads/react-starter/branches{/branch}","tags_url":"https://api.github.com/repos/coding-monads/react-starter/tags","blobs_url":"https://api.github.com/repos/coding-monads/react-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coding-monads/react-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coding-monads/react-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/coding-monads/react-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coding-monads/react-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/coding-monads/react-starter/languages","stargazers_url":"https://api.github.com/repos/coding-monads/react-starter/stargazers","contributors_url":"https://api.github.com/repos/coding-monads/react-starter/contributors","subscribers_url":"https://api.github.com/repos/coding-monads/react-starter/subscribers","subscription_url":"https://api.github.com/repos/coding-monads/react-starter/subscription","commits_url":"https://api.github.com/repos/coding-monads/react-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/coding-monads/react-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/coding-monads/react-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/coding-monads/react-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/coding-monads/react-starter/contents/{+path}","compare_url":"https://api.github.com/repos/coding-monads/react-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coding-monads/react-starter/merges","archive_url":"https://api.github.com/repos/coding-monads/react-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coding-monads/react-starter/downloads","issues_url":"https://api.github.com/repos/coding-monads/react-starter/issues{/number}","pulls_url":"https://api.github.com/repos/coding-monads/react-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/coding-monads/react-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/coding-monads/react-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coding-monads/react-starter/labels{/name}","releases_url":"https://api.github.com/repos/coding-monads/react-starter/releases{/id}","deployments_url":"https://api.github.com/repos/coding-monads/react-starter/deployments","created_at":"2019-05-15T15:12:46Z","updated_at":"2019-06-15T13:06:27Z","pushed_at":"2019-06-18T05:00:03Z","git_url":"git://github.com/coding-monads/react-starter.git","ssh_url":"[email protected]:coding-monads/react-starter.git","clone_url":"https://github.com/coding-monads/react-starter.git","svn_url":"https://github.com/coding-monads/react-starter","homepage":null,"size":203,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":9,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coding-monads/react-starter/pulls/48"},"html":{"href":"https://github.com/coding-monads/react-starter/pull/48"},"issue":{"href":"https://api.github.com/repos/coding-monads/react-starter/issues/48"},"comments":{"href":"https://api.github.com/repos/coding-monads/react-starter/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/coding-monads/react-starter/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/coding-monads/react-starter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coding-monads/react-starter/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/coding-monads/react-starter/statuses/5f4145b4b590eb78d19b2b4be2283ad6faa8ba75"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 186851798,
"name": "coding-monads/react-starter",
"url": "https://api.github.com/repos/coding-monads/react-starter"
}
|
{
"id": 45687747,
"login": "kamilmoskal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45687747?",
"url": "https://api.github.com/users/kamilmoskal"
}
|
{
"id": 50657140,
"login": "coding-monads",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50657140?",
"url": "https://api.github.com/orgs/coding-monads"
}
| 2019-06-18T18:36:46 |
9846720466
|
{"actor":{"display_login":"kamilmoskal"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/comments/333628848","pull_request_review_id":300211917,"id":333628848,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMzYyODg0OA==","diff_hunk":"@@ -28,18 +28,9 @@ openshift_hosted_registry_storage_volume_size=10Gi\n openshift_hosted_registry_storage_host=n.n.n.n\n ```\n \n-## Installation Scripts\n-\n-Retrieve the [installation scripts from our documentation repository](https://github.com/kabanero-io/kabanero-foundation/tree/master/scripts)\n-\n ## Installation\n \n-Review the installation script for any optional components that you wish to enable. Components can be enabled by passing the appropriate environment variable to the script, or by editing the script.\n-\n-As a `cluster-admin`, execute the installation script, replacing `my.openshift.master.default.subdomain` with your subdomain:\n-```\n-openshift_master_default_subdomain=<my.openshift.master.default.subdomain> ./install-kabanero-foundation.sh\n-```\n+View [Installing Kabanero Foundation](https://kabanero.io/docs/ref/general/installing-kabanero-foundation.html) on Kabanero.io","path":"scripts/README.md","position":16,"original_position":16,"commit_id":"8aacaf8bd1b91010abed569360b5144956347414","original_commit_id":"8aacaf8bd1b91010abed569360b5144956347414","user":{"login":"kaczyns","id":7862248,"node_id":"MDQ6VXNlcjc4NjIyNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/7862248?v=4","gravatar_id":"","url":"https://api.github.com/users/kaczyns","html_url":"https://github.com/kaczyns","followers_url":"https://api.github.com/users/kaczyns/followers","following_url":"https://api.github.com/users/kaczyns/following{/other_user}","gists_url":"https://api.github.com/users/kaczyns/gists{/gist_id}","starred_url":"https://api.github.com/users/kaczyns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaczyns/subscriptions","organizations_url":"https://api.github.com/users/kaczyns/orgs","repos_url":"https://api.github.com/users/kaczyns/repos","events_url":"https://api.github.com/users/kaczyns/events{/privacy}","received_events_url":"https://api.github.com/users/kaczyns/received_events","type":"User","site_admin":false},"body":"Well, I think this is a great idea, to just have one version, but my concern is that the kabanero-foundation repository is versioned. If the readme points them to kabanero.io, the instructions that they get might not reflect the version that they are using. \r\n\r\nMaybe I am over-thinking this... we don't provide instructions today to get the version of the install script at a particular version of Kabanero.","created_at":"2019-10-10T16:52:17Z","updated_at":"2019-10-10T16:52:18Z","html_url":"https://github.com/kabanero-io/kabanero-foundation/pull/99#discussion_r333628848","pull_request_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/99","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/comments/333628848"},"html":{"href":"https://github.com/kabanero-io/kabanero-foundation/pull/99#discussion_r333628848"},"pull_request":{"href":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/99","id":326798717,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2Nzk4NzE3","html_url":"https://github.com/kabanero-io/kabanero-foundation/pull/99","diff_url":"https://github.com/kabanero-io/kabanero-foundation/pull/99.diff","patch_url":"https://github.com/kabanero-io/kabanero-foundation/pull/99.patch","issue_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues/99","number":99,"state":"open","locked":false,"title":"link install in readme doc to kabanero.io","user":{"login":"alohr51","id":3623618,"node_id":"MDQ6VXNlcjM2MjM2MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3623618?v=4","gravatar_id":"","url":"https://api.github.com/users/alohr51","html_url":"https://github.com/alohr51","followers_url":"https://api.github.com/users/alohr51/followers","following_url":"https://api.github.com/users/alohr51/following{/other_user}","gists_url":"https://api.github.com/users/alohr51/gists{/gist_id}","starred_url":"https://api.github.com/users/alohr51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alohr51/subscriptions","organizations_url":"https://api.github.com/users/alohr51/orgs","repos_url":"https://api.github.com/users/alohr51/repos","events_url":"https://api.github.com/users/alohr51/events{/privacy}","received_events_url":"https://api.github.com/users/alohr51/received_events","type":"User","site_admin":false},"body":"part of kabanero-io/kabanero-landing/issues/30","created_at":"2019-10-10T15:29:51Z","updated_at":"2019-10-10T16:52:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcbd8a18c6cf8506ad3aa1b19e4084c922605064","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/99/commits","review_comments_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/99/comments","review_comment_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues/99/comments","statuses_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/statuses/8aacaf8bd1b91010abed569360b5144956347414","head":{"label":"kabanero-io:update-install-readme","ref":"update-install-readme","sha":"8aacaf8bd1b91010abed569360b5144956347414","user":{"login":"kabanero-io","id":50876789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwODc2Nzg5","avatar_url":"https://avatars0.githubusercontent.com/u/50876789?v=4","gravatar_id":"","url":"https://api.github.com/users/kabanero-io","html_url":"https://github.com/kabanero-io","followers_url":"https://api.github.com/users/kabanero-io/followers","following_url":"https://api.github.com/users/kabanero-io/following{/other_user}","gists_url":"https://api.github.com/users/kabanero-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kabanero-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabanero-io/subscriptions","organizations_url":"https://api.github.com/users/kabanero-io/orgs","repos_url":"https://api.github.com/users/kabanero-io/repos","events_url":"https://api.github.com/users/kabanero-io/events{/privacy}","received_events_url":"https://api.github.com/users/kabanero-io/received_events","type":"Organization","site_admin":false},"repo":{"id":192741152,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI3NDExNTI=","name":"kabanero-foundation","full_name":"kabanero-io/kabanero-foundation","private":false,"owner":{"login":"kabanero-io","id":50876789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwODc2Nzg5","avatar_url":"https://avatars0.githubusercontent.com/u/50876789?v=4","gravatar_id":"","url":"https://api.github.com/users/kabanero-io","html_url":"https://github.com/kabanero-io","followers_url":"https://api.github.com/users/kabanero-io/followers","following_url":"https://api.github.com/users/kabanero-io/following{/other_user}","gists_url":"https://api.github.com/users/kabanero-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kabanero-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabanero-io/subscriptions","organizations_url":"https://api.github.com/users/kabanero-io/orgs","repos_url":"https://api.github.com/users/kabanero-io/repos","events_url":"https://api.github.com/users/kabanero-io/events{/privacy}","received_events_url":"https://api.github.com/users/kabanero-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kabanero-io/kabanero-foundation","description":null,"fork":false,"url":"https://api.github.com/repos/kabanero-io/kabanero-foundation","forks_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/forks","keys_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/teams","hooks_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/hooks","issue_events_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/events","assignees_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/tags","blobs_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/languages","stargazers_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/stargazers","contributors_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/contributors","subscribers_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/subscribers","subscription_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/subscription","commits_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/merges","archive_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/downloads","issues_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/labels{/name}","releases_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/deployments","created_at":"2019-06-19T13:46:59Z","updated_at":"2019-10-08T18:45:40Z","pushed_at":"2019-10-10T15:34:58Z","git_url":"git://github.com/kabanero-io/kabanero-foundation.git","ssh_url":"[email protected]:kabanero-io/kabanero-foundation.git","clone_url":"https://github.com/kabanero-io/kabanero-foundation.git","svn_url":"https://github.com/kabanero-io/kabanero-foundation","homepage":null,"size":175,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":null,"forks":9,"open_issues":36,"watchers":1,"default_branch":"master"}},"base":{"label":"kabanero-io:master","ref":"master","sha":"ae7b296a30ac344f1b726d759253cbb97583b0b4","user":{"login":"kabanero-io","id":50876789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwODc2Nzg5","avatar_url":"https://avatars0.githubusercontent.com/u/50876789?v=4","gravatar_id":"","url":"https://api.github.com/users/kabanero-io","html_url":"https://github.com/kabanero-io","followers_url":"https://api.github.com/users/kabanero-io/followers","following_url":"https://api.github.com/users/kabanero-io/following{/other_user}","gists_url":"https://api.github.com/users/kabanero-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kabanero-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabanero-io/subscriptions","organizations_url":"https://api.github.com/users/kabanero-io/orgs","repos_url":"https://api.github.com/users/kabanero-io/repos","events_url":"https://api.github.com/users/kabanero-io/events{/privacy}","received_events_url":"https://api.github.com/users/kabanero-io/received_events","type":"Organization","site_admin":false},"repo":{"id":192741152,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI3NDExNTI=","name":"kabanero-foundation","full_name":"kabanero-io/kabanero-foundation","private":false,"owner":{"login":"kabanero-io","id":50876789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwODc2Nzg5","avatar_url":"https://avatars0.githubusercontent.com/u/50876789?v=4","gravatar_id":"","url":"https://api.github.com/users/kabanero-io","html_url":"https://github.com/kabanero-io","followers_url":"https://api.github.com/users/kabanero-io/followers","following_url":"https://api.github.com/users/kabanero-io/following{/other_user}","gists_url":"https://api.github.com/users/kabanero-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kabanero-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabanero-io/subscriptions","organizations_url":"https://api.github.com/users/kabanero-io/orgs","repos_url":"https://api.github.com/users/kabanero-io/repos","events_url":"https://api.github.com/users/kabanero-io/events{/privacy}","received_events_url":"https://api.github.com/users/kabanero-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kabanero-io/kabanero-foundation","description":null,"fork":false,"url":"https://api.github.com/repos/kabanero-io/kabanero-foundation","forks_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/forks","keys_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/teams","hooks_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/hooks","issue_events_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/events","assignees_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/tags","blobs_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/languages","stargazers_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/stargazers","contributors_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/contributors","subscribers_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/subscribers","subscription_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/subscription","commits_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/merges","archive_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/downloads","issues_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/labels{/name}","releases_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/kabanero-io/kabanero-foundation/deployments","created_at":"2019-06-19T13:46:59Z","updated_at":"2019-10-08T18:45:40Z","pushed_at":"2019-10-10T15:34:58Z","git_url":"git://github.com/kabanero-io/kabanero-foundation.git","ssh_url":"[email protected]:kabanero-io/kabanero-foundation.git","clone_url":"https://github.com/kabanero-io/kabanero-foundation.git","svn_url":"https://github.com/kabanero-io/kabanero-foundation","homepage":null,"size":175,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":null,"forks":9,"open_issues":36,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/99"},"html":{"href":"https://github.com/kabanero-io/kabanero-foundation/pull/99"},"issue":{"href":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues/99"},"comments":{"href":"https://api.github.com/repos/kabanero-io/kabanero-foundation/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kabanero-io/kabanero-foundation/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/kabanero-io/kabanero-foundation/statuses/8aacaf8bd1b91010abed569360b5144956347414"}},"author_association":"MEMBER"}}
|
{
"id": 192741152,
"name": "kabanero-io/kabanero-foundation",
"url": "https://api.github.com/repos/kabanero-io/kabanero-foundation"
}
|
{
"id": 7862248,
"login": "kaczyns",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7862248?",
"url": "https://api.github.com/users/kaczyns"
}
|
{
"id": 50876789,
"login": "kabanero-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50876789?",
"url": "https://api.github.com/orgs/kabanero-io"
}
| 2019-10-10T16:52:17 |
10603856539
|
{"actor":{"display_login":"kaczyns"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/poemap/i18n/pulls/comments/301416494","pull_request_review_id":259292797,"id":301416494,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTQxNjQ5NA==","diff_hunk":"@@ -1,134 +1,134 @@\n {\n- \"button.trades\": \"Trades\",\n- \"button.about\": \"About\",\n- \"button.update.apply\": \"Apply update\",\n- \"button.action.start\": \"Start\",\n+ \"button.trades\": \"Intercambios\",\n+ \"button.about\": \"Sobre\",\n+ \"button.update.apply\": \"Aplicar actualizaciรณn\",\n+ \"button.action.start\": \"Comenzar\",\n \"button.action.start.hint\": \"โจ Enter\",\n- \"button.action.init\": \"Start\",\n+ \"button.action.init\": \"Iniciar\",\n \"button.action.init.hint\": \"โจ Enter\",\n- \"button.action.stop\": \"Stop\",\n+ \"button.action.stop\": \"Detener\",\n \"button.action.stop.hint\": \"โจ Enter\",\n- \"button.action.update\": \"Update\",\n+ \"button.action.update\": \"Actualizar\",\n \"button.action.update.hint\": \"โจ Enter\",\n- \"button.mute.hint\": \"Notification sound\",\n- \"button.preview.hint\": \"Copy selected maps to the clipboard for /trade 159, 820\",\n- \"button.settings.hint\": \"Settings\",\n- \"button.preview.notify\": \"Copied to Clipboard\",\n+ \"button.mute.hint\": \"Notificaciรณn con sonido\",\n+ \"button.preview.hint\": \"Copiar mapas seleccionados al portapapeles para /trade 159, 820\", \n+ \"button.settings.hint\": \"Configuraciรณn\",\n+ \"button.preview.notify\": \"Copiado al portapapeles\",\n \"button.notify.ok\": \"OK\",\n- \"button.notify.connect.force\": \"Break In\",\n- \"button.notify.league.ignore\": \"Ignore\",\n- \"button.notify.page.refresh\": \"Refresh\",\n- \"button.notify.loader.reload\": \"Reload\",\n- \"update.text\": \"Update available\",\n- \"connection.init\": \"Connecting...\",\n- \"board.tier\": \"Tier {{number}}\",\n- \"board.unique\": \"Unique\",\n- \"board.fragments\": \"Fragments\",\n- \"board.info.have\": \"You have\",\n- \"board.info.want\": \"You want\",\n- \"board.tier.selected\": \"tiers selected\",\n- \"board.label.main\": \"tier-to-tier exchange\",\n- \"board.map.type.regular\": \"Regular\",\n+ \"button.notify.connect.force\": \"Forzar\",\n+ \"button.notify.league.ignore\": \"Ignorar\",\n+ \"button.notify.page.refresh\": \"Refrescar\",\n+ \"button.notify.loader.reload\": \"Recargar\",\n+ \"update.text\": \"Actualizaciรณn disponible\",\n+ \"connection.init\": \"Conectando...\",\n+ \"board.tier\": \"Grado {{number}}\", \n+ \"board.unique\": \"รnico\",\n+ \"board.fragments\": \"Fragmentos\",\n+ \"board.info.have\": \"Tienes\",\n+ \"board.info.want\": \"Quieres\",\n+ \"board.tier.selected\": \"grados seleccionados\",\n+ \"board.label.main\": \"intercambio de grado-a-grado\",\n+ \"board.map.type.regular\": \"Mapa regular\",\n \"board.map.type.regular.short\": \"R\",\n- \"board.map.type.shaper\": \"Shaped\",\n+ \"board.map.type.shaper\": \"Mapa modificado\",\n \"board.map.type.shaper.short\": \"S\",\n- \"board.map.type.elder\": \"Elder\",\n+ \"board.map.type.elder\": \"Mapa del antiguo\",\n \"board.map.type.elder.short\": \"E\",\n- \"bar.cross.text\": \"Ignore tiers\",\n- \"bar.cross.hint\": \"It allows you to exchange maps ignoring the tier number. This option should be enabled on both sides.\",\n- \"bar.stats.main\": \"Tier - Active players\",\n- \"bar.stats.empty\": \"Nothing was found. Try later\",\n- \"bar.advice.inactive\": \"Hints are disabled. Click to enable them.\",\n- \"bar.advice.hint\": \"Click to disable hints\",\n- \"bar.advice.0\": \"\\uD83D\\uDEC8 It's simple to support us - just tell your friends or guild about PoeMap\",\n- \"bar.advice.1\": \"\\uD83D\\uDEC8 PoeMap supports multiple languages for items and UI. Change it in โ Settings\",\n- \"bar.advice.2\": \"\\uD83D\\uDEC8 Players must choose one of the maps in case of unequal exchange. The system offers all possible options. Do not exchange all maps for just one\",\n- \"bar.advice.3\": \"\\uD83D\\uDEC8 PoeMap exists thanks to ads and donations. Please, disable your ad blocker\",\n- \"bar.advice.4\": \"\\uD83D\\uDEC8 Exchange may not be as fast as in the first weeks of the league. Be patient\",\n- \"bar.advice.5\": \"\\uD83D\\uDEC8 If you click \\\"Ready\\\", the user will know that you are ready to exchange. Everyone else will see \\\"Busy\\\" and will not disturb you\",\n- \"bar.advice.6\": \"\\uD83D\\uDEC8 After messaging other people please be patient and wait for their invite to a party\",\n- \"offers.empty.message\": \"Keep playing. You will see new offers very soon...\",\n- \"settings.header\": \"Settings\",\n- \"settings.items-language.placeholder\": \"Items language\",\n- \"settings.ui-language.placeholder\": \"UI language\",\n- \"settings.connection-animation.placeholder\": \"Connection animation\",\n- \"settings.map.style.desk.placeholder\": \"Map style: desks\",\n- \"settings.map.style.offer.placeholder\": \"Map style: offers\",\n- \"settings.map.style.icon\": \"Icon\",\n- \"settings.map.style.text\": \"Text\",\n- \"settings.hints.text\": \"Enable hints\",\n+ \"bar.cross.text\": \"Ignorar niveles\",\n+ \"bar.cross.hint\": \"Te permite intercambiar mapas ignorando el grado. Esta opciรณn debe estar habilitada desde ambos lados de la negociaciรณn\", \n+ \"bar.stats.main\": \"Grado - Jugadores activos\",\n+ \"bar.stats.empty\": \"No se encontrรณ nada. Intenta mรกs tarde\",\n+ \"bar.advice.inactive\": \"Las sugerencias estรกn desactivados. Click para habilitarlas.\",\n+ \"bar.advice.hint\": \"Click para deshabilitar sugerencias.\",\n+ \"bar.advice.0\": \"\\uD83D\\uDEC8 Es simple ayudarnos - sรณlo cuรฉntale a tus amigos o tu guild sobre PoeMap\", \n+ \"bar.advice.1\": \"\\uD83D\\uDEC8 PoeMap soporte mรบltiples lenguajes para los items y su interfaz. Puedes cambiar en โ Configuraciรณn\", \n+ \"bar.advice.2\": \"\\uD83D\\uDEC8 Los jugadores deben elegir uno de los mapas en caso de un intercambio desigual. El sistema ofrece todas las opciones posibles. No intercambies todos tus mapas por uno solo\", \n+ \"bar.advice.3\": \"\\uD83D\\uDEC8 PoeMap existe gracias a los anuncios y las donacionas. Por favor, desactiva tu bloqueador de anuncios\", \n+ \"bar.advice.4\": \"\\uD83D\\uDEC8 El intercambio puede no ser tan rรกpido como en las primeras semanas de la liga. Sรฉ paciente\", \n+ \"bar.advice.5\": \"\\uD83D\\uDEC8 Si haces click en \\\"Listo\\\", el usuario sabrรก que estรกs preparado para intercambiar. El resto verรก \\\"Ocupado\\\" y no te molestarรกn\", \n+ \"bar.advice.6\": \"\\uD83D\\uDEC8 Despuรฉs de enviar un mensaje a otra persona sรฉ paciente y espera que te invite a su equipo\", \n+ \"offers.empty.message\": \"Sigue jugando. Verรกs nuevas ofertas pronto...\", \n+ \"settings.header\": \"Configuraciรณn\",\n+ \"settings.items-language.placeholder\": \"Lenguaje de los objetos\",\n+ \"settings.ui-language.placeholder\": \"Lenguaje de la pรกgina\",\n+ \"settings.connection-animation.placeholder\": \"Animaciรณn de la conexiรณn\",\n+ \"settings.map.style.desk.placeholder\": \"Estilo de mapas: escritorio\",\n+ \"settings.map.style.offer.placeholder\": \"Estilo de mapas: ofertas\",\n+ \"settings.map.style.icon\": \"รcono\",\n+ \"settings.map.style.text\": \"Texto\",\n+ \"settings.hints.text\": \"Habilitar sugerencias\",\n \"link.discord.hint\": \"Discord\",\n- \"link.forum.hint\": \"Forum (ask your questions, leave feedback)\",\n+ \"link.forum.hint\": \"Foro (pregunta, deja tu opiniรณn)\",\n \"link.telegram.hint\": \"Telegram\",\n- \"button.donate.main\": \"Support PoeMap\",\n- \"button.donate.patreon\": \"Support PoeMap using Patreon (PayPal friendly)\",\n- \"button.donate.da\": \"Support using DonationAlerts\",\n- \"offer.status.ready\": \"Ready\",\n- \"offer.status.rejected\": \"Rejected\",\n- \"offer.status.busy\": \"Busy\",\n- \"button.offer.update.hint\": \"Mark trade as finished, unregister these maps. Select maps to skip.\",\n- \"button.offer.ready.hint\": \"Notify the player that you are ready to trade\",\n- \"button.offer.copy.hint\": \"Copy the trade message to the clipboard\",\n- \"button.offer.reject.hint\": \"Remove the offer and notify the player that you don't want to trade\",\n- \"notify.browser\": \"Your browser is not supported. Try Chrome or Firefox\",\n- \"notify.hero\": \"Please, select the character again\",\n- \"notify.empty_maps\": \"You have nothing to exchange. Select the maps\",\n- \"notify.idle\": \"You have been disconnected due to inactivity\",\n- \"notify.wrong_league\": \"{{actualLeague}} league was selected for {{hero}}, but {{expectedLeague}} was expected\",\n- \"notify.server.error.credentials\": \"Wrong credentials\",\n- \"notify.server.error.denied\": \"Access is denied\",\n- \"notify.server.error.internal\": \"Internal problem\",\n- \"notify.server.error.duplicate\": \"Duplicate login\",\n- \"notify.server.error.flood\": \"You have exceeded the reconnection limit. Wait and try again\",\n- \"notify.server.error.ban\": \"You were banned\",\n- \"notify.server.error.version\": \"The version of your cached client is outdated. Try to reload the site\",\n- \"notify.server.error.league\": \"Wrong league.\",\n- \"notify.server.error.auth\": \"Auth service is inaccessible. Wait and try again\",\n- \"notify.server.error.atlas\": \"Service has not initialized the atlas yet. Wait and try again\",\n- \"notify.server.kick\": \"You were kicked by admin. Reason: {{message}}\",\n- \"notify.server.message\": \"Message from admin: {{message}}\",\n- \"notify.server.unknown\": \"Unknown code: {{code}}, Message: {{message}}\",\n- \"notify.server.error.map.internal\": \"Internal error. Maps were not registered. Try again\",\n- \"notify.server.error.map.invalid\": \"Map validation was not passed. Try again\",\n- \"notify.command.custom\": \"Custom command was executed\",\n- \"notify.command.version\": \"Your client version is {{version}}\",\n- \"notify.command.cloudflare.enabled\": \"Connection through CloudFlare was enabled\",\n- \"notify.command.cloudflare.disabled\": \"Connection through CloudFlare was disabled\",\n- \"notify.loaded.stopped\": \"Loader was stopped. Try again?\",\n- \"loader.starting\": \"Starting application...\",\n- \"loader.realm.started\": \"Loading realms...\",\n- \"loader.realm.loaded\": \"Found {{size}} realms: {{realms}}...\",\n- \"loader.realm.empty\": \"Realms are not present. Try later...\",\n- \"loader.realm.autoselected\": \"Selected '{{realm}}' realm as default...\",\n- \"loader.realm.failed\": \"Failed to load. Probably the app maintenance...\",\n- \"loader.realm.scheduled\": \"Attempt to reload realms after {{time}} seconds...\",\n- \"loader.league.started\": \"Parsing leagues from '{{realm}}'...\",\n- \"loader.league.loaded\": \"Found {{size}} leagues: {{leagues}}...\",\n- \"loader.league.empty\": \"Not found any league. Probably the app maintenance...\",\n- \"loader.league.autoselected\": \"Selected '{{league}}' league as default...\",\n- \"loader.series.started\": \"Parsing series from '{{league}}'...\",\n- \"loader.series.loaded\": \"Found {{size}} maps for '{{series}}' series...\",\n- \"loader.series.empty\": \"Series is not present. Try later...\",\n- \"loader.series.failed\": \"Failed to load series. Probably the app maintenance...\",\n- \"loader.series.scheduled\": \"Attempt to reload the series after {{time}} seconds...\",\n- \"login.hello\": \"Hello, {{username}}!\",\n- \"login.hero.selection_prompt\": \"It's time to select your character\",\n- \"login.not_logged\": \"You are not logged in.\",\n- \"login.loading\": \"Loading...\",\n- \"login.hero.selection.hint\": \"Select your character. Game will forward all messages to your active character, but it could be better to select your active character to make it easier for the players to understand which trade in the list should be marked as completed.\",\n- \"login.hero.selection.placeholder\": \"Select your active character\",\n- \"login.error.credentials\": \"Authentication error\",\n- \"login.hero.empty.main\": \"Your credentials are correct, but we didn't find any character for <b>{{username}}</b>.\",\n- \"login.hero.empty.warning.prefix\": \"Make sure your <b>characters tab</b> is not hidden \",\n- \"login.hero.empty.warning.url_word\": \"here\",\n+ \"button.donate.main\": \"Apoya a PoeMap\",\n+ \"button.donate.patreon\": \"Apoya a PoeMap mediante Patreon (PayPal disponible)\",\n+ \"button.donate.da\": \"Apoya usando alertas de donaciones\",\n+ \"offer.status.ready\": \"Listo\",\n+ \"offer.status.rejected\": \"Rechazado\",\n+ \"offer.status.busy\": \"Ocupado\",\n+ \"button.offer.update.hint\": \"Marcar intercambio como terminado, desmarcar mapas. Selecciona mapas para saltear.\", \n+ \"button.offer.ready.hint\": \"Notificar al jugador que estรกs listo para el intercambio\", \n+ \"button.offer.copy.hint\": \"Copiar el mensaje del intercambio al portapapeles\",\n+ \"button.offer.reject.hint\": \"Quitar oferta y avisarle al jugador que no quieres intercambiar\",\n+ \"notify.browser\": \"Este navegador no es compatible. Intenta con Chrome o Firefox\",\n+ \"notify.hero\": \"Por favor, selecciona el personaje nuevamente\",\n+ \"notify.empty_maps\": \"No tienes nada para intercambiar. Selecciona los mapas\",\n+ \"notify.idle\": \"Has sido desconectado por inactividad\",\n+ \"notify.wrong_league\": \"La liga {{actualLeague}} fue seleccionada para {{hero}}, pero se esperaba liga {{expectedLeague}}\", \n+ \"notify.server.error.credentials\": \"Credenciales errรณneas\",\n+ \"notify.server.error.denied\": \"Acceso denegado\",\n+ \"notify.server.error.internal\": \"Problema interno\",\n+ \"notify.server.error.duplicate\": \"Logueo duplicado\",\n+ \"notify.server.error.flood\": \"Excediste el lรญmite de reconexiones. Espera e intenta nuevamente\",\n+ \"notify.server.error.ban\": \"Has sido baneado\",\n+ \"notify.server.error.version\": \"La versiรณn cacheada de tu cliente se encuentra desactualizada. Intenta actualizando el sitio\",\n+ \"notify.server.error.league\": \"Liga errรณnea.\",\n+ \"notify.server.error.auth\": \"El servicio de autenticaciรณn es inaccesible. Espera e intenta nuevamente\",\n+ \"notify.server.error.atlas\": \"El servicio no inicializรณ el atlas aรบn. Espera e intenta nuevamente\",\n+ \"notify.server.kick\": \"Has sido expulsado por el admin. Razรณn: {{message}}\",\n+ \"notify.server.message\": \"Mensaje de un admin: {{message}}\",\n+ \"notify.server.unknown\": \"Cรณdigo desconocido: {{code}}, Mensaje: {{message}}\",\n+ \"notify.server.error.map.internal\": \"Error interno. Los mapas no fueron registrados. Intenta nuevamente\",\n+ \"notify.server.error.map.invalid\": \"No se pudo realizar la validaciรณn de los mapas. Intenta nuevamente\",\n+ \"notify.command.custom\": \"Comando personalizado ejecutado\",\n+ \"notify.command.version\": \"La versiรณn de tu cliente es {{version}}\",\n+ \"notify.command.cloudflare.enabled\": \"La conexiรณn mediante CloudFlare fue habilitada\",\n+ \"notify.command.cloudflare.disabled\": \"La conexiรณn mediante CloudFlare fue deshabilitada\",\n+ \"notify.loaded.stopped\": \"El cargador ha sido frenado. Intentar nuevamente?\",\n+ \"loader.starting\": \"Inicializando aplicaciรณn...\",\n+ \"loader.realm.started\": \"Cargando reinos...\",\n+ \"loader.realm.loaded\": \"Se encontraron {{size}} reinos: {{realms}}...\",\n+ \"loader.realm.empty\": \"No hay reinos presentes. Intenta luego...\",\n+ \"loader.realm.autoselected\": \"Se seleccionรณ '{{realm}}' como reino default...\",\n+ \"loader.realm.failed\": \"Falla al cargar. Probablemente por mantenimiento de la aplicaciรณn...\",\n+ \"loader.realm.scheduled\": \"Se intentรณ recargar reinos por {{time}} segundos...\",\n+ \"loader.league.started\": \"Parseando ligas de '{{realm}}'...\",\n+ \"loader.league.loaded\": \"Se encontraron {{size}} ligas: {{leagues}}...\",\n+ \"loader.league.empty\": \"No se encontrรณ ninguna liga. Probablemente por mantenimiento de la aplicaciรณn...\",\n+ \"loader.league.autoselected\": \"Se seleccionรณ '{{league}}' como liga default...\",\n+ \"loader.series.started\": \"Parseando series de '{{league}}'...\",\n+ \"loader.series.loaded\": \"Se encontraron {{size}} mapas para '{{series}}' series...\",\n+ \"loader.series.empty\": \"Series no presentes. Intentar luego...\",\n+ \"loader.series.failed\": \"Error al cargar series. Probablemente por mantenimiento de la aplicaciรณn...\",\n+ \"loader.series.scheduled\": \"Intentando recargar series despuรฉs de {{time}} segundos...\",\n+ \"login.hello\": \"Hola, {{username}}!\",\n+ \"login.hero.selection_prompt\": \"Es momento de elegir tu personaje\",\n+ \"login.not_logged\": \"No estรกs logueado.\",\n+ \"login.loading\": \"Cargando...\",\n+ \"login.hero.selection.hint\": \"Selecciona tu personaje. El juego destinarรก todos los mensajes a tu personaje activo, pero es mejor seleccionar tu personaje activo para simplificar a los jugadores el marcar que intercambio en la lista estรกn completos.\", \n+ \"login.hero.selection.placeholder\": \"Selecciona tu personaje activo\",\n+ \"login.error.credentials\": \"Error de autenticaciรณn\",\n+ \"login.hero.empty.main\": \"Tus credenciales son correctas pero no encontramos ningรบn personaje para <b>{{username}}</b>.\",\n+ \"login.hero.empty.warning.prefix\": \"Revisa que la <b>pestaรฑa de personajes</b> no estรก oculta\",\n+ \"login.hero.empty.warning.url_word\": \"aquรญ\",\n \"login.hero.empty.warning.suffix\": \".\",\n- \"login.hero.empty.reminder\": \"Do not forget to save your changes there\",\n+ \"login.hero.empty.reminder\": \"No olvides guardar tus cambios allรญ\",\n \"button.login.enter\": \"Enter\",\n- \"button.login.register\": \"Register\",\n- \"button.login.back\": \"Back\",\n- \"button.login.reload\": \"Reload\",\n- \"button.login.continue\": \"Continue\",\n- \"translation.info\": \"Want to improve the translation? Contribute here\",\n- \"contributors.text\": \"Translated by {{contributors.names}}\",\n+ \"button.login.register\": \"Registrarse\",\n+ \"button.login.back\": \"Volver\",\n+ \"button.login.reload\": \"Recargar\",\n+ \"button.login.continue\": \"Continuar\",\n+ \"translation.info\": \"ยฟQuieres mejorar la traducciรณn? Ayuda aquรญ\",\n+ \"contributors.text\": \"Traducciรณn por {{contributors.names}}\",\n \"contributors.names\": \"\"","path":"es.json","position":252,"original_position":252,"commit_id":"fbc457ca3e520019e8aee265dffe72818de8e5dd","original_commit_id":"fbc457ca3e520019e8aee265dffe72818de8e5dd","user":{"login":"snqlby","id":6323370,"node_id":"MDQ6VXNlcjYzMjMzNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6323370?v=4","gravatar_id":"","url":"https://api.github.com/users/snqlby","html_url":"https://github.com/snqlby","followers_url":"https://api.github.com/users/snqlby/followers","following_url":"https://api.github.com/users/snqlby/following{/other_user}","gists_url":"https://api.github.com/users/snqlby/gists{/gist_id}","starred_url":"https://api.github.com/users/snqlby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snqlby/subscriptions","organizations_url":"https://api.github.com/users/snqlby/orgs","repos_url":"https://api.github.com/users/snqlby/repos","events_url":"https://api.github.com/users/snqlby/events{/privacy}","received_events_url":"https://api.github.com/users/snqlby/received_events","type":"User","site_admin":false},"body":"Could you add your preferred name to the \"contributors.names\"?","created_at":"2019-07-09T06:36:06Z","updated_at":"2019-07-09T06:36:26Z","html_url":"https://github.com/poemap/i18n/pull/5#discussion_r301416494","pull_request_url":"https://api.github.com/repos/poemap/i18n/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/poemap/i18n/pulls/comments/301416494"},"html":{"href":"https://github.com/poemap/i18n/pull/5#discussion_r301416494"},"pull_request":{"href":"https://api.github.com/repos/poemap/i18n/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/poemap/i18n/pulls/5","id":295543405,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1NTQzNDA1","html_url":"https://github.com/poemap/i18n/pull/5","diff_url":"https://github.com/poemap/i18n/pull/5.diff","patch_url":"https://github.com/poemap/i18n/pull/5.patch","issue_url":"https://api.github.com/repos/poemap/i18n/issues/5","number":5,"state":"open","locked":false,"title":"Spanish translation - done","user":{"login":"nicolascamilo","id":16237215,"node_id":"MDQ6VXNlcjE2MjM3MjE1","avatar_url":"https://avatars1.githubusercontent.com/u/16237215?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolascamilo","html_url":"https://github.com/nicolascamilo","followers_url":"https://api.github.com/users/nicolascamilo/followers","following_url":"https://api.github.com/users/nicolascamilo/following{/other_user}","gists_url":"https://api.github.com/users/nicolascamilo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolascamilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolascamilo/subscriptions","organizations_url":"https://api.github.com/users/nicolascamilo/orgs","repos_url":"https://api.github.com/users/nicolascamilo/repos","events_url":"https://api.github.com/users/nicolascamilo/events{/privacy}","received_events_url":"https://api.github.com/users/nicolascamilo/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-09T00:44:01Z","updated_at":"2019-07-09T06:36:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"285265aeb1a9cd9ab6e8c70a50ab95ea3f4c1f9e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poemap/i18n/pulls/5/commits","review_comments_url":"https://api.github.com/repos/poemap/i18n/pulls/5/comments","review_comment_url":"https://api.github.com/repos/poemap/i18n/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poemap/i18n/issues/5/comments","statuses_url":"https://api.github.com/repos/poemap/i18n/statuses/fbc457ca3e520019e8aee265dffe72818de8e5dd","head":{"label":"nicolascamilo:master","ref":"master","sha":"fbc457ca3e520019e8aee265dffe72818de8e5dd","user":{"login":"nicolascamilo","id":16237215,"node_id":"MDQ6VXNlcjE2MjM3MjE1","avatar_url":"https://avatars1.githubusercontent.com/u/16237215?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolascamilo","html_url":"https://github.com/nicolascamilo","followers_url":"https://api.github.com/users/nicolascamilo/followers","following_url":"https://api.github.com/users/nicolascamilo/following{/other_user}","gists_url":"https://api.github.com/users/nicolascamilo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolascamilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolascamilo/subscriptions","organizations_url":"https://api.github.com/users/nicolascamilo/orgs","repos_url":"https://api.github.com/users/nicolascamilo/repos","events_url":"https://api.github.com/users/nicolascamilo/events{/privacy}","received_events_url":"https://api.github.com/users/nicolascamilo/received_events","type":"User","site_admin":false},"repo":{"id":195904983,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU5MDQ5ODM=","name":"i18n","full_name":"nicolascamilo/i18n","private":false,"owner":{"login":"nicolascamilo","id":16237215,"node_id":"MDQ6VXNlcjE2MjM3MjE1","avatar_url":"https://avatars1.githubusercontent.com/u/16237215?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolascamilo","html_url":"https://github.com/nicolascamilo","followers_url":"https://api.github.com/users/nicolascamilo/followers","following_url":"https://api.github.com/users/nicolascamilo/following{/other_user}","gists_url":"https://api.github.com/users/nicolascamilo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolascamilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolascamilo/subscriptions","organizations_url":"https://api.github.com/users/nicolascamilo/orgs","repos_url":"https://api.github.com/users/nicolascamilo/repos","events_url":"https://api.github.com/users/nicolascamilo/events{/privacy}","received_events_url":"https://api.github.com/users/nicolascamilo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nicolascamilo/i18n","description":"PoeMap website strings","fork":true,"url":"https://api.github.com/repos/nicolascamilo/i18n","forks_url":"https://api.github.com/repos/nicolascamilo/i18n/forks","keys_url":"https://api.github.com/repos/nicolascamilo/i18n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolascamilo/i18n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolascamilo/i18n/teams","hooks_url":"https://api.github.com/repos/nicolascamilo/i18n/hooks","issue_events_url":"https://api.github.com/repos/nicolascamilo/i18n/issues/events{/number}","events_url":"https://api.github.com/repos/nicolascamilo/i18n/events","assignees_url":"https://api.github.com/repos/nicolascamilo/i18n/assignees{/user}","branches_url":"https://api.github.com/repos/nicolascamilo/i18n/branches{/branch}","tags_url":"https://api.github.com/repos/nicolascamilo/i18n/tags","blobs_url":"https://api.github.com/repos/nicolascamilo/i18n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolascamilo/i18n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolascamilo/i18n/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolascamilo/i18n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolascamilo/i18n/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolascamilo/i18n/languages","stargazers_url":"https://api.github.com/repos/nicolascamilo/i18n/stargazers","contributors_url":"https://api.github.com/repos/nicolascamilo/i18n/contributors","subscribers_url":"https://api.github.com/repos/nicolascamilo/i18n/subscribers","subscription_url":"https://api.github.com/repos/nicolascamilo/i18n/subscription","commits_url":"https://api.github.com/repos/nicolascamilo/i18n/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolascamilo/i18n/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolascamilo/i18n/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolascamilo/i18n/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolascamilo/i18n/contents/{+path}","compare_url":"https://api.github.com/repos/nicolascamilo/i18n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolascamilo/i18n/merges","archive_url":"https://api.github.com/repos/nicolascamilo/i18n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolascamilo/i18n/downloads","issues_url":"https://api.github.com/repos/nicolascamilo/i18n/issues{/number}","pulls_url":"https://api.github.com/repos/nicolascamilo/i18n/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolascamilo/i18n/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolascamilo/i18n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolascamilo/i18n/labels{/name}","releases_url":"https://api.github.com/repos/nicolascamilo/i18n/releases{/id}","deployments_url":"https://api.github.com/repos/nicolascamilo/i18n/deployments","created_at":"2019-07-09T00:41:42Z","updated_at":"2019-07-09T00:43:18Z","pushed_at":"2019-07-09T00:43:16Z","git_url":"git://github.com/nicolascamilo/i18n.git","ssh_url":"[email protected]:nicolascamilo/i18n.git","clone_url":"https://github.com/nicolascamilo/i18n.git","svn_url":"https://github.com/nicolascamilo/i18n","homepage":"","size":58,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"poemap:master","ref":"master","sha":"b3b3694cc1adc96fc1a710dbd9d2b5236ae9154c","user":{"login":"poemap","id":51026372,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMDI2Mzcy","avatar_url":"https://avatars0.githubusercontent.com/u/51026372?v=4","gravatar_id":"","url":"https://api.github.com/users/poemap","html_url":"https://github.com/poemap","followers_url":"https://api.github.com/users/poemap/followers","following_url":"https://api.github.com/users/poemap/following{/other_user}","gists_url":"https://api.github.com/users/poemap/gists{/gist_id}","starred_url":"https://api.github.com/users/poemap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poemap/subscriptions","organizations_url":"https://api.github.com/users/poemap/orgs","repos_url":"https://api.github.com/users/poemap/repos","events_url":"https://api.github.com/users/poemap/events{/privacy}","received_events_url":"https://api.github.com/users/poemap/received_events","type":"Organization","site_admin":false},"repo":{"id":195454473,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU0NTQ0NzM=","name":"i18n","full_name":"poemap/i18n","private":false,"owner":{"login":"poemap","id":51026372,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMDI2Mzcy","avatar_url":"https://avatars0.githubusercontent.com/u/51026372?v=4","gravatar_id":"","url":"https://api.github.com/users/poemap","html_url":"https://github.com/poemap","followers_url":"https://api.github.com/users/poemap/followers","following_url":"https://api.github.com/users/poemap/following{/other_user}","gists_url":"https://api.github.com/users/poemap/gists{/gist_id}","starred_url":"https://api.github.com/users/poemap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poemap/subscriptions","organizations_url":"https://api.github.com/users/poemap/orgs","repos_url":"https://api.github.com/users/poemap/repos","events_url":"https://api.github.com/users/poemap/events{/privacy}","received_events_url":"https://api.github.com/users/poemap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poemap/i18n","description":"PoeMap website strings","fork":false,"url":"https://api.github.com/repos/poemap/i18n","forks_url":"https://api.github.com/repos/poemap/i18n/forks","keys_url":"https://api.github.com/repos/poemap/i18n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poemap/i18n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poemap/i18n/teams","hooks_url":"https://api.github.com/repos/poemap/i18n/hooks","issue_events_url":"https://api.github.com/repos/poemap/i18n/issues/events{/number}","events_url":"https://api.github.com/repos/poemap/i18n/events","assignees_url":"https://api.github.com/repos/poemap/i18n/assignees{/user}","branches_url":"https://api.github.com/repos/poemap/i18n/branches{/branch}","tags_url":"https://api.github.com/repos/poemap/i18n/tags","blobs_url":"https://api.github.com/repos/poemap/i18n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poemap/i18n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poemap/i18n/git/refs{/sha}","trees_url":"https://api.github.com/repos/poemap/i18n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poemap/i18n/statuses/{sha}","languages_url":"https://api.github.com/repos/poemap/i18n/languages","stargazers_url":"https://api.github.com/repos/poemap/i18n/stargazers","contributors_url":"https://api.github.com/repos/poemap/i18n/contributors","subscribers_url":"https://api.github.com/repos/poemap/i18n/subscribers","subscription_url":"https://api.github.com/repos/poemap/i18n/subscription","commits_url":"https://api.github.com/repos/poemap/i18n/commits{/sha}","git_commits_url":"https://api.github.com/repos/poemap/i18n/git/commits{/sha}","comments_url":"https://api.github.com/repos/poemap/i18n/comments{/number}","issue_comment_url":"https://api.github.com/repos/poemap/i18n/issues/comments{/number}","contents_url":"https://api.github.com/repos/poemap/i18n/contents/{+path}","compare_url":"https://api.github.com/repos/poemap/i18n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poemap/i18n/merges","archive_url":"https://api.github.com/repos/poemap/i18n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poemap/i18n/downloads","issues_url":"https://api.github.com/repos/poemap/i18n/issues{/number}","pulls_url":"https://api.github.com/repos/poemap/i18n/pulls{/number}","milestones_url":"https://api.github.com/repos/poemap/i18n/milestones{/number}","notifications_url":"https://api.github.com/repos/poemap/i18n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poemap/i18n/labels{/name}","releases_url":"https://api.github.com/repos/poemap/i18n/releases{/id}","deployments_url":"https://api.github.com/repos/poemap/i18n/deployments","created_at":"2019-07-05T18:50:36Z","updated_at":"2019-07-08T14:15:54Z","pushed_at":"2019-07-09T00:44:02Z","git_url":"git://github.com/poemap/i18n.git","ssh_url":"[email protected]:poemap/i18n.git","clone_url":"https://github.com/poemap/i18n.git","svn_url":"https://github.com/poemap/i18n","homepage":"","size":55,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":7,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poemap/i18n/pulls/5"},"html":{"href":"https://github.com/poemap/i18n/pull/5"},"issue":{"href":"https://api.github.com/repos/poemap/i18n/issues/5"},"comments":{"href":"https://api.github.com/repos/poemap/i18n/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/poemap/i18n/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/poemap/i18n/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poemap/i18n/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/poemap/i18n/statuses/fbc457ca3e520019e8aee265dffe72818de8e5dd"}},"author_association":"NONE"}}
|
{
"id": 195454473,
"name": "poemap/i18n",
"url": "https://api.github.com/repos/poemap/i18n"
}
|
{
"id": 6323370,
"login": "snqlby",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6323370?",
"url": "https://api.github.com/users/snqlby"
}
|
{
"id": 51026372,
"login": "poemap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51026372?",
"url": "https://api.github.com/orgs/poemap"
}
| 2019-07-09T06:36:06 |
9972786162
|
{"actor":{"display_login":"snqlby"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dataitgirls3/TIL/pulls/comments/315101622","pull_request_review_id":276419570,"id":315101622,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNTEwMTYyMg==","diff_hunk":"@@ -0,0 +1,25 @@\n+from grade import class_grade\n+from grade import class_grade_dic\n+\n+class_scores = [\n+ {\n+ '๊ตญ์ด': 80,\n+ '์์ด': 100,\n+ '์ํ': 50\n+ },\n+ {\n+ '๊ตญ์ด': 90,\n+ '์์ด': 70,\n+ '์ํ': 40\n+ }\n+]\n+\n+#๋จ์ผ ์ ์๋ฅผ ๋ฃ์ ๋\n+def test_class_grade():\n+ assert class_grade(80, '๊ตญ์ด') == '๊ตญ์ด : A'\n+ assert class_grade(45, '์ํ') == '์ํ : C'\n+\n+\n+print(class_grade_dic(class_scores, 0, '๊ตญ์ด'))\n+print(class_grade_dic(class_scores, 1, '์์ด'))\n+# ๋์
๋๋ฆฌ๋ฅผ ๋ฃ์ ๋","path":"yeseulbae/grade_test.py","position":25,"original_position":25,"commit_id":"874b5ae04f38b8c2532878d51abb74cb0a748dae","original_commit_id":"874b5ae04f38b8c2532878d51abb74cb0a748dae","user":{"login":"ahastudio","id":36392,"node_id":"MDQ6VXNlcjM2Mzky","avatar_url":"https://avatars1.githubusercontent.com/u/36392?v=4","gravatar_id":"","url":"https://api.github.com/users/ahastudio","html_url":"https://github.com/ahastudio","followers_url":"https://api.github.com/users/ahastudio/followers","following_url":"https://api.github.com/users/ahastudio/following{/other_user}","gists_url":"https://api.github.com/users/ahastudio/gists{/gist_id}","starred_url":"https://api.github.com/users/ahastudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahastudio/subscriptions","organizations_url":"https://api.github.com/users/ahastudio/orgs","repos_url":"https://api.github.com/users/ahastudio/repos","events_url":"https://api.github.com/users/ahastudio/events{/privacy}","received_events_url":"https://api.github.com/users/ahastudio/received_events","type":"User","site_admin":false},"body":"์ด ๋ถ๋ถ๋ ํ
์คํธ ์ฝ๋๋ฅผ ์์ฑํ๋ฉด `class_grade_dic`์ ์ด๋ป๊ฒ ์จ์ผ ํ ์ง ์๊ธฐ ์ฌ์ธ ๊ฒ ๊ฐ์์.","created_at":"2019-08-19T08:52:37Z","updated_at":"2019-08-19T08:52:48Z","html_url":"https://github.com/dataitgirls3/TIL/pull/167#discussion_r315101622","pull_request_url":"https://api.github.com/repos/dataitgirls3/TIL/pulls/167","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dataitgirls3/TIL/pulls/comments/315101622"},"html":{"href":"https://github.com/dataitgirls3/TIL/pull/167#discussion_r315101622"},"pull_request":{"href":"https://api.github.com/repos/dataitgirls3/TIL/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/dataitgirls3/TIL/pulls/167","id":308466270,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4NDY2Mjcw","html_url":"https://github.com/dataitgirls3/TIL/pull/167","diff_url":"https://github.com/dataitgirls3/TIL/pull/167.diff","patch_url":"https://github.com/dataitgirls3/TIL/pull/167.patch","issue_url":"https://api.github.com/repos/dataitgirls3/TIL/issues/167","number":167,"state":"open","locked":false,"title":"190816hw","user":{"login":"yeseul0806","id":53165716,"node_id":"MDQ6VXNlcjUzMTY1NzE2","avatar_url":"https://avatars2.githubusercontent.com/u/53165716?v=4","gravatar_id":"","url":"https://api.github.com/users/yeseul0806","html_url":"https://github.com/yeseul0806","followers_url":"https://api.github.com/users/yeseul0806/followers","following_url":"https://api.github.com/users/yeseul0806/following{/other_user}","gists_url":"https://api.github.com/users/yeseul0806/gists{/gist_id}","starred_url":"https://api.github.com/users/yeseul0806/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeseul0806/subscriptions","organizations_url":"https://api.github.com/users/yeseul0806/orgs","repos_url":"https://api.github.com/users/yeseul0806/repos","events_url":"https://api.github.com/users/yeseul0806/events{/privacy}","received_events_url":"https://api.github.com/users/yeseul0806/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-19T06:45:06Z","updated_at":"2019-08-19T08:52:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40b2017f7ce4d42b65eda7d08d30415980ab569b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dataitgirls3/TIL/pulls/167/commits","review_comments_url":"https://api.github.com/repos/dataitgirls3/TIL/pulls/167/comments","review_comment_url":"https://api.github.com/repos/dataitgirls3/TIL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dataitgirls3/TIL/issues/167/comments","statuses_url":"https://api.github.com/repos/dataitgirls3/TIL/statuses/874b5ae04f38b8c2532878d51abb74cb0a748dae","head":{"label":"yeseul0806:190816hw","ref":"190816hw","sha":"874b5ae04f38b8c2532878d51abb74cb0a748dae","user":{"login":"yeseul0806","id":53165716,"node_id":"MDQ6VXNlcjUzMTY1NzE2","avatar_url":"https://avatars2.githubusercontent.com/u/53165716?v=4","gravatar_id":"","url":"https://api.github.com/users/yeseul0806","html_url":"https://github.com/yeseul0806","followers_url":"https://api.github.com/users/yeseul0806/followers","following_url":"https://api.github.com/users/yeseul0806/following{/other_user}","gists_url":"https://api.github.com/users/yeseul0806/gists{/gist_id}","starred_url":"https://api.github.com/users/yeseul0806/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeseul0806/subscriptions","organizations_url":"https://api.github.com/users/yeseul0806/orgs","repos_url":"https://api.github.com/users/yeseul0806/repos","events_url":"https://api.github.com/users/yeseul0806/events{/privacy}","received_events_url":"https://api.github.com/users/yeseul0806/received_events","type":"User","site_admin":false},"repo":{"id":200569971,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA1Njk5NzE=","name":"TIL","full_name":"yeseul0806/TIL","private":false,"owner":{"login":"yeseul0806","id":53165716,"node_id":"MDQ6VXNlcjUzMTY1NzE2","avatar_url":"https://avatars2.githubusercontent.com/u/53165716?v=4","gravatar_id":"","url":"https://api.github.com/users/yeseul0806","html_url":"https://github.com/yeseul0806","followers_url":"https://api.github.com/users/yeseul0806/followers","following_url":"https://api.github.com/users/yeseul0806/following{/other_user}","gists_url":"https://api.github.com/users/yeseul0806/gists{/gist_id}","starred_url":"https://api.github.com/users/yeseul0806/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeseul0806/subscriptions","organizations_url":"https://api.github.com/users/yeseul0806/orgs","repos_url":"https://api.github.com/users/yeseul0806/repos","events_url":"https://api.github.com/users/yeseul0806/events{/privacy}","received_events_url":"https://api.github.com/users/yeseul0806/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yeseul0806/TIL","description":"Today I Learned","fork":true,"url":"https://api.github.com/repos/yeseul0806/TIL","forks_url":"https://api.github.com/repos/yeseul0806/TIL/forks","keys_url":"https://api.github.com/repos/yeseul0806/TIL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yeseul0806/TIL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yeseul0806/TIL/teams","hooks_url":"https://api.github.com/repos/yeseul0806/TIL/hooks","issue_events_url":"https://api.github.com/repos/yeseul0806/TIL/issues/events{/number}","events_url":"https://api.github.com/repos/yeseul0806/TIL/events","assignees_url":"https://api.github.com/repos/yeseul0806/TIL/assignees{/user}","branches_url":"https://api.github.com/repos/yeseul0806/TIL/branches{/branch}","tags_url":"https://api.github.com/repos/yeseul0806/TIL/tags","blobs_url":"https://api.github.com/repos/yeseul0806/TIL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yeseul0806/TIL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yeseul0806/TIL/git/refs{/sha}","trees_url":"https://api.github.com/repos/yeseul0806/TIL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yeseul0806/TIL/statuses/{sha}","languages_url":"https://api.github.com/repos/yeseul0806/TIL/languages","stargazers_url":"https://api.github.com/repos/yeseul0806/TIL/stargazers","contributors_url":"https://api.github.com/repos/yeseul0806/TIL/contributors","subscribers_url":"https://api.github.com/repos/yeseul0806/TIL/subscribers","subscription_url":"https://api.github.com/repos/yeseul0806/TIL/subscription","commits_url":"https://api.github.com/repos/yeseul0806/TIL/commits{/sha}","git_commits_url":"https://api.github.com/repos/yeseul0806/TIL/git/commits{/sha}","comments_url":"https://api.github.com/repos/yeseul0806/TIL/comments{/number}","issue_comment_url":"https://api.github.com/repos/yeseul0806/TIL/issues/comments{/number}","contents_url":"https://api.github.com/repos/yeseul0806/TIL/contents/{+path}","compare_url":"https://api.github.com/repos/yeseul0806/TIL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yeseul0806/TIL/merges","archive_url":"https://api.github.com/repos/yeseul0806/TIL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yeseul0806/TIL/downloads","issues_url":"https://api.github.com/repos/yeseul0806/TIL/issues{/number}","pulls_url":"https://api.github.com/repos/yeseul0806/TIL/pulls{/number}","milestones_url":"https://api.github.com/repos/yeseul0806/TIL/milestones{/number}","notifications_url":"https://api.github.com/repos/yeseul0806/TIL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yeseul0806/TIL/labels{/name}","releases_url":"https://api.github.com/repos/yeseul0806/TIL/releases{/id}","deployments_url":"https://api.github.com/repos/yeseul0806/TIL/deployments","created_at":"2019-08-05T02:41:38Z","updated_at":"2019-08-05T08:51:13Z","pushed_at":"2019-08-19T06:44:12Z","git_url":"git://github.com/yeseul0806/TIL.git","ssh_url":"[email protected]:yeseul0806/TIL.git","clone_url":"https://github.com/yeseul0806/TIL.git","svn_url":"https://github.com/yeseul0806/TIL","homepage":null,"size":11686,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dataitgirls3:master","ref":"master","sha":"24c02520099c63fc3160bbc70d4ebeb7a4c4b97b","user":{"login":"dataitgirls3","id":51121041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTIxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/51121041?v=4","gravatar_id":"","url":"https://api.github.com/users/dataitgirls3","html_url":"https://github.com/dataitgirls3","followers_url":"https://api.github.com/users/dataitgirls3/followers","following_url":"https://api.github.com/users/dataitgirls3/following{/other_user}","gists_url":"https://api.github.com/users/dataitgirls3/gists{/gist_id}","starred_url":"https://api.github.com/users/dataitgirls3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dataitgirls3/subscriptions","organizations_url":"https://api.github.com/users/dataitgirls3/orgs","repos_url":"https://api.github.com/users/dataitgirls3/repos","events_url":"https://api.github.com/users/dataitgirls3/events{/privacy}","received_events_url":"https://api.github.com/users/dataitgirls3/received_events","type":"Organization","site_admin":false},"repo":{"id":197222691,"node_id":"MDEwOlJlcG9zaXRvcnkxOTcyMjI2OTE=","name":"TIL","full_name":"dataitgirls3/TIL","private":false,"owner":{"login":"dataitgirls3","id":51121041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTIxMDQx","avatar_url":"https://avatars0.githubusercontent.com/u/51121041?v=4","gravatar_id":"","url":"https://api.github.com/users/dataitgirls3","html_url":"https://github.com/dataitgirls3","followers_url":"https://api.github.com/users/dataitgirls3/followers","following_url":"https://api.github.com/users/dataitgirls3/following{/other_user}","gists_url":"https://api.github.com/users/dataitgirls3/gists{/gist_id}","starred_url":"https://api.github.com/users/dataitgirls3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dataitgirls3/subscriptions","organizations_url":"https://api.github.com/users/dataitgirls3/orgs","repos_url":"https://api.github.com/users/dataitgirls3/repos","events_url":"https://api.github.com/users/dataitgirls3/events{/privacy}","received_events_url":"https://api.github.com/users/dataitgirls3/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dataitgirls3/TIL","description":"Today I Learned","fork":false,"url":"https://api.github.com/repos/dataitgirls3/TIL","forks_url":"https://api.github.com/repos/dataitgirls3/TIL/forks","keys_url":"https://api.github.com/repos/dataitgirls3/TIL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dataitgirls3/TIL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dataitgirls3/TIL/teams","hooks_url":"https://api.github.com/repos/dataitgirls3/TIL/hooks","issue_events_url":"https://api.github.com/repos/dataitgirls3/TIL/issues/events{/number}","events_url":"https://api.github.com/repos/dataitgirls3/TIL/events","assignees_url":"https://api.github.com/repos/dataitgirls3/TIL/assignees{/user}","branches_url":"https://api.github.com/repos/dataitgirls3/TIL/branches{/branch}","tags_url":"https://api.github.com/repos/dataitgirls3/TIL/tags","blobs_url":"https://api.github.com/repos/dataitgirls3/TIL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dataitgirls3/TIL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dataitgirls3/TIL/git/refs{/sha}","trees_url":"https://api.github.com/repos/dataitgirls3/TIL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dataitgirls3/TIL/statuses/{sha}","languages_url":"https://api.github.com/repos/dataitgirls3/TIL/languages","stargazers_url":"https://api.github.com/repos/dataitgirls3/TIL/stargazers","contributors_url":"https://api.github.com/repos/dataitgirls3/TIL/contributors","subscribers_url":"https://api.github.com/repos/dataitgirls3/TIL/subscribers","subscription_url":"https://api.github.com/repos/dataitgirls3/TIL/subscription","commits_url":"https://api.github.com/repos/dataitgirls3/TIL/commits{/sha}","git_commits_url":"https://api.github.com/repos/dataitgirls3/TIL/git/commits{/sha}","comments_url":"https://api.github.com/repos/dataitgirls3/TIL/comments{/number}","issue_comment_url":"https://api.github.com/repos/dataitgirls3/TIL/issues/comments{/number}","contents_url":"https://api.github.com/repos/dataitgirls3/TIL/contents/{+path}","compare_url":"https://api.github.com/repos/dataitgirls3/TIL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dataitgirls3/TIL/merges","archive_url":"https://api.github.com/repos/dataitgirls3/TIL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dataitgirls3/TIL/downloads","issues_url":"https://api.github.com/repos/dataitgirls3/TIL/issues{/number}","pulls_url":"https://api.github.com/repos/dataitgirls3/TIL/pulls{/number}","milestones_url":"https://api.github.com/repos/dataitgirls3/TIL/milestones{/number}","notifications_url":"https://api.github.com/repos/dataitgirls3/TIL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dataitgirls3/TIL/labels{/name}","releases_url":"https://api.github.com/repos/dataitgirls3/TIL/releases{/id}","deployments_url":"https://api.github.com/repos/dataitgirls3/TIL/deployments","created_at":"2019-07-16T15:43:23Z","updated_at":"2019-08-19T08:46:00Z","pushed_at":"2019-08-19T08:45:58Z","git_url":"git://github.com/dataitgirls3/TIL.git","ssh_url":"[email protected]:dataitgirls3/TIL.git","clone_url":"https://github.com/dataitgirls3/TIL.git","svn_url":"https://github.com/dataitgirls3/TIL","homepage":null,"size":23799,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":37,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dataitgirls3/TIL/pulls/167"},"html":{"href":"https://github.com/dataitgirls3/TIL/pull/167"},"issue":{"href":"https://api.github.com/repos/dataitgirls3/TIL/issues/167"},"comments":{"href":"https://api.github.com/repos/dataitgirls3/TIL/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/dataitgirls3/TIL/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/dataitgirls3/TIL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dataitgirls3/TIL/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/dataitgirls3/TIL/statuses/874b5ae04f38b8c2532878d51abb74cb0a748dae"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 197222691,
"name": "dataitgirls3/TIL",
"url": "https://api.github.com/repos/dataitgirls3/TIL"
}
|
{
"id": 36392,
"login": "ahastudio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36392?",
"url": "https://api.github.com/users/ahastudio"
}
|
{
"id": 51121041,
"login": "dataitgirls3",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51121041?",
"url": "https://api.github.com/orgs/dataitgirls3"
}
| 2019-08-19T08:52:37 |
10235309311
|
{"actor":{"display_login":"ahastudio"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/comments/290977208","pull_request_review_id":246310230,"id":290977208,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDk3NzIwOA==","diff_hunk":"@@ -3,9 +3,11 @@\n import com.fasterxml.jackson.annotation.JsonIgnoreProperties;\n \n import javax.persistence.*;\n+import java.lang.reflect.Array;","path":"src/main/java/com/lambdaschool/tiemendo/model/Transaction.java","position":4,"original_position":4,"commit_id":"ccd28e3b746f6340243e32e74fba99b6bf75b504","original_commit_id":"ccd28e3b746f6340243e32e74fba99b6bf75b504","user":{"login":"KerstingJ","id":18179574,"node_id":"MDQ6VXNlcjE4MTc5NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/18179574?v=4","gravatar_id":"","url":"https://api.github.com/users/KerstingJ","html_url":"https://github.com/KerstingJ","followers_url":"https://api.github.com/users/KerstingJ/followers","following_url":"https://api.github.com/users/KerstingJ/following{/other_user}","gists_url":"https://api.github.com/users/KerstingJ/gists{/gist_id}","starred_url":"https://api.github.com/users/KerstingJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KerstingJ/subscriptions","organizations_url":"https://api.github.com/users/KerstingJ/orgs","repos_url":"https://api.github.com/users/KerstingJ/repos","events_url":"https://api.github.com/users/KerstingJ/events{/privacy}","received_events_url":"https://api.github.com/users/KerstingJ/received_events","type":"User","site_admin":false},"body":"whats up with this Reflection array?","created_at":"2019-06-05T23:47:08Z","updated_at":"2019-06-05T23:47:08Z","html_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End/pull/22#discussion_r290977208","pull_request_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/comments/290977208"},"html":{"href":"https://github.com/labs13-agriculture/Tiemendo-Back-End/pull/22#discussion_r290977208"},"pull_request":{"href":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/22","id":285590793,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1NTkwNzkz","html_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End/pull/22","diff_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End/pull/22.diff","patch_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End/pull/22.patch","issue_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues/22","number":22,"state":"open","locked":false,"title":"Dustin bailey","user":{"login":"dgbailey","id":46548011,"node_id":"MDQ6VXNlcjQ2NTQ4MDEx","avatar_url":"https://avatars0.githubusercontent.com/u/46548011?v=4","gravatar_id":"","url":"https://api.github.com/users/dgbailey","html_url":"https://github.com/dgbailey","followers_url":"https://api.github.com/users/dgbailey/followers","following_url":"https://api.github.com/users/dgbailey/following{/other_user}","gists_url":"https://api.github.com/users/dgbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/dgbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgbailey/subscriptions","organizations_url":"https://api.github.com/users/dgbailey/orgs","repos_url":"https://api.github.com/users/dgbailey/repos","events_url":"https://api.github.com/users/dgbailey/events{/privacy}","received_events_url":"https://api.github.com/users/dgbailey/received_events","type":"User","site_admin":false},"body":"1. Repos added for Transaction and transactionitem\r\n2. Services and service impls added for transaction and transaction item.\r\n3. Seed data added for 1 Transaction with multiple transaction items.\r\n4. **we should discuss if we need to store Transaction totals in the db somewhere**","created_at":"2019-06-05T23:45:24Z","updated_at":"2019-06-05T23:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad494932f38095dec1c45dc3b99ed839e9dc8df7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrewlowell","id":38302613,"node_id":"MDQ6VXNlcjM4MzAyNjEz","avatar_url":"https://avatars0.githubusercontent.com/u/38302613?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewlowell","html_url":"https://github.com/andrewlowell","followers_url":"https://api.github.com/users/andrewlowell/followers","following_url":"https://api.github.com/users/andrewlowell/following{/other_user}","gists_url":"https://api.github.com/users/andrewlowell/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewlowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewlowell/subscriptions","organizations_url":"https://api.github.com/users/andrewlowell/orgs","repos_url":"https://api.github.com/users/andrewlowell/repos","events_url":"https://api.github.com/users/andrewlowell/events{/privacy}","received_events_url":"https://api.github.com/users/andrewlowell/received_events","type":"User","site_admin":false},{"login":"AWSafran","id":44010508,"node_id":"MDQ6VXNlcjQ0MDEwNTA4","avatar_url":"https://avatars0.githubusercontent.com/u/44010508?v=4","gravatar_id":"","url":"https://api.github.com/users/AWSafran","html_url":"https://github.com/AWSafran","followers_url":"https://api.github.com/users/AWSafran/followers","following_url":"https://api.github.com/users/AWSafran/following{/other_user}","gists_url":"https://api.github.com/users/AWSafran/gists{/gist_id}","starred_url":"https://api.github.com/users/AWSafran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AWSafran/subscriptions","organizations_url":"https://api.github.com/users/AWSafran/orgs","repos_url":"https://api.github.com/users/AWSafran/repos","events_url":"https://api.github.com/users/AWSafran/events{/privacy}","received_events_url":"https://api.github.com/users/AWSafran/received_events","type":"User","site_admin":false},{"login":"chasegarsee","id":47544678,"node_id":"MDQ6VXNlcjQ3NTQ0Njc4","avatar_url":"https://avatars1.githubusercontent.com/u/47544678?v=4","gravatar_id":"","url":"https://api.github.com/users/chasegarsee","html_url":"https://github.com/chasegarsee","followers_url":"https://api.github.com/users/chasegarsee/followers","following_url":"https://api.github.com/users/chasegarsee/following{/other_user}","gists_url":"https://api.github.com/users/chasegarsee/gists{/gist_id}","starred_url":"https://api.github.com/users/chasegarsee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasegarsee/subscriptions","organizations_url":"https://api.github.com/users/chasegarsee/orgs","repos_url":"https://api.github.com/users/chasegarsee/repos","events_url":"https://api.github.com/users/chasegarsee/events{/privacy}","received_events_url":"https://api.github.com/users/chasegarsee/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/22/commits","review_comments_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/22/comments","review_comment_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/comments{/number}","comments_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues/22/comments","statuses_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/statuses/ccd28e3b746f6340243e32e74fba99b6bf75b504","head":{"label":"labs13-agriculture:dustin-bailey","ref":"dustin-bailey","sha":"ccd28e3b746f6340243e32e74fba99b6bf75b504","user":{"login":"labs13-agriculture","id":51131352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTMxMzUy","avatar_url":"https://avatars3.githubusercontent.com/u/51131352?v=4","gravatar_id":"","url":"https://api.github.com/users/labs13-agriculture","html_url":"https://github.com/labs13-agriculture","followers_url":"https://api.github.com/users/labs13-agriculture/followers","following_url":"https://api.github.com/users/labs13-agriculture/following{/other_user}","gists_url":"https://api.github.com/users/labs13-agriculture/gists{/gist_id}","starred_url":"https://api.github.com/users/labs13-agriculture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labs13-agriculture/subscriptions","organizations_url":"https://api.github.com/users/labs13-agriculture/orgs","repos_url":"https://api.github.com/users/labs13-agriculture/repos","events_url":"https://api.github.com/users/labs13-agriculture/events{/privacy}","received_events_url":"https://api.github.com/users/labs13-agriculture/received_events","type":"Organization","site_admin":false},"repo":{"id":187383172,"node_id":"MDEwOlJlcG9zaXRvcnkxODczODMxNzI=","name":"Tiemendo-Back-End","full_name":"labs13-agriculture/Tiemendo-Back-End","private":false,"owner":{"login":"labs13-agriculture","id":51131352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTMxMzUy","avatar_url":"https://avatars3.githubusercontent.com/u/51131352?v=4","gravatar_id":"","url":"https://api.github.com/users/labs13-agriculture","html_url":"https://github.com/labs13-agriculture","followers_url":"https://api.github.com/users/labs13-agriculture/followers","following_url":"https://api.github.com/users/labs13-agriculture/following{/other_user}","gists_url":"https://api.github.com/users/labs13-agriculture/gists{/gist_id}","starred_url":"https://api.github.com/users/labs13-agriculture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labs13-agriculture/subscriptions","organizations_url":"https://api.github.com/users/labs13-agriculture/orgs","repos_url":"https://api.github.com/users/labs13-agriculture/repos","events_url":"https://api.github.com/users/labs13-agriculture/events{/privacy}","received_events_url":"https://api.github.com/users/labs13-agriculture/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End","description":null,"fork":false,"url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End","forks_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/forks","keys_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/teams","hooks_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/hooks","issue_events_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues/events{/number}","events_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/events","assignees_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/assignees{/user}","branches_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/branches{/branch}","tags_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/tags","blobs_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/refs{/sha}","trees_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/statuses/{sha}","languages_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/languages","stargazers_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/stargazers","contributors_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/contributors","subscribers_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/subscribers","subscription_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/subscription","commits_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/commits{/sha}","git_commits_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/commits{/sha}","comments_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/comments{/number}","issue_comment_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues/comments{/number}","contents_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/contents/{+path}","compare_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/merges","archive_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/downloads","issues_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues{/number}","pulls_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls{/number}","milestones_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/milestones{/number}","notifications_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/labels{/name}","releases_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/releases{/id}","deployments_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/deployments","created_at":"2019-05-18T16:53:59Z","updated_at":"2019-06-05T23:29:05Z","pushed_at":"2019-06-05T23:45:24Z","git_url":"git://github.com/labs13-agriculture/Tiemendo-Back-End.git","ssh_url":"[email protected]:labs13-agriculture/Tiemendo-Back-End.git","clone_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End.git","svn_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End","homepage":null,"size":136064,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"labs13-agriculture:master","ref":"master","sha":"4e4417cde1e6ec8f15131ed7b90121848267448b","user":{"login":"labs13-agriculture","id":51131352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTMxMzUy","avatar_url":"https://avatars3.githubusercontent.com/u/51131352?v=4","gravatar_id":"","url":"https://api.github.com/users/labs13-agriculture","html_url":"https://github.com/labs13-agriculture","followers_url":"https://api.github.com/users/labs13-agriculture/followers","following_url":"https://api.github.com/users/labs13-agriculture/following{/other_user}","gists_url":"https://api.github.com/users/labs13-agriculture/gists{/gist_id}","starred_url":"https://api.github.com/users/labs13-agriculture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labs13-agriculture/subscriptions","organizations_url":"https://api.github.com/users/labs13-agriculture/orgs","repos_url":"https://api.github.com/users/labs13-agriculture/repos","events_url":"https://api.github.com/users/labs13-agriculture/events{/privacy}","received_events_url":"https://api.github.com/users/labs13-agriculture/received_events","type":"Organization","site_admin":false},"repo":{"id":187383172,"node_id":"MDEwOlJlcG9zaXRvcnkxODczODMxNzI=","name":"Tiemendo-Back-End","full_name":"labs13-agriculture/Tiemendo-Back-End","private":false,"owner":{"login":"labs13-agriculture","id":51131352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMTMxMzUy","avatar_url":"https://avatars3.githubusercontent.com/u/51131352?v=4","gravatar_id":"","url":"https://api.github.com/users/labs13-agriculture","html_url":"https://github.com/labs13-agriculture","followers_url":"https://api.github.com/users/labs13-agriculture/followers","following_url":"https://api.github.com/users/labs13-agriculture/following{/other_user}","gists_url":"https://api.github.com/users/labs13-agriculture/gists{/gist_id}","starred_url":"https://api.github.com/users/labs13-agriculture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labs13-agriculture/subscriptions","organizations_url":"https://api.github.com/users/labs13-agriculture/orgs","repos_url":"https://api.github.com/users/labs13-agriculture/repos","events_url":"https://api.github.com/users/labs13-agriculture/events{/privacy}","received_events_url":"https://api.github.com/users/labs13-agriculture/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End","description":null,"fork":false,"url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End","forks_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/forks","keys_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/teams","hooks_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/hooks","issue_events_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues/events{/number}","events_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/events","assignees_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/assignees{/user}","branches_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/branches{/branch}","tags_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/tags","blobs_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/refs{/sha}","trees_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/statuses/{sha}","languages_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/languages","stargazers_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/stargazers","contributors_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/contributors","subscribers_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/subscribers","subscription_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/subscription","commits_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/commits{/sha}","git_commits_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/git/commits{/sha}","comments_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/comments{/number}","issue_comment_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues/comments{/number}","contents_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/contents/{+path}","compare_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/merges","archive_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/downloads","issues_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues{/number}","pulls_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls{/number}","milestones_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/milestones{/number}","notifications_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/labels{/name}","releases_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/releases{/id}","deployments_url":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/deployments","created_at":"2019-05-18T16:53:59Z","updated_at":"2019-06-05T23:29:05Z","pushed_at":"2019-06-05T23:45:24Z","git_url":"git://github.com/labs13-agriculture/Tiemendo-Back-End.git","ssh_url":"[email protected]:labs13-agriculture/Tiemendo-Back-End.git","clone_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End.git","svn_url":"https://github.com/labs13-agriculture/Tiemendo-Back-End","homepage":null,"size":136064,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/22"},"html":{"href":"https://github.com/labs13-agriculture/Tiemendo-Back-End/pull/22"},"issue":{"href":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues/22"},"comments":{"href":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End/statuses/ccd28e3b746f6340243e32e74fba99b6bf75b504"}},"author_association":"NONE"}}
|
{
"id": 187383172,
"name": "labs13-agriculture/Tiemendo-Back-End",
"url": "https://api.github.com/repos/labs13-agriculture/Tiemendo-Back-End"
}
|
{
"id": 18179574,
"login": "KerstingJ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18179574?",
"url": "https://api.github.com/users/KerstingJ"
}
|
{
"id": 51131352,
"login": "labs13-agriculture",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51131352?",
"url": "https://api.github.com/orgs/labs13-agriculture"
}
| 2019-06-05T23:47:08 |
9767360242
|
{"actor":{"display_login":"KerstingJ"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/comments/293143127","pull_request_review_id":249049872,"id":293143127,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzE0MzEyNw==","diff_hunk":"@@ -0,0 +1,31 @@\n+/* Develop function that will handle random name generations.\n+\n+The function will return a randomly generated name, that is defined as ```description``` + ```food```, similar to the feature found on Google Docs.\n+\n+Examples\n+```js\n+generateRandomName () // Fried Cake\n+generateRandomName () // Soggy Drumstick\n+generateRandomName () // Crispy Noodle\n+```\n+\n+Ideally, it should be designed in a way where we can easily change the available keywords\n+*/\n+\n+function generateRandomName() {","path":"random_name.js","position":15,"original_position":15,"commit_id":"5ea11d5971f7869dc9c2a12a1a72c8c690358934","original_commit_id":"5ea11d5971f7869dc9c2a12a1a72c8c690358934","user":{"login":"Chen-Jack","id":23295845,"node_id":"MDQ6VXNlcjIzMjk1ODQ1","avatar_url":"https://avatars1.githubusercontent.com/u/23295845?v=4","gravatar_id":"","url":"https://api.github.com/users/Chen-Jack","html_url":"https://github.com/Chen-Jack","followers_url":"https://api.github.com/users/Chen-Jack/followers","following_url":"https://api.github.com/users/Chen-Jack/following{/other_user}","gists_url":"https://api.github.com/users/Chen-Jack/gists{/gist_id}","starred_url":"https://api.github.com/users/Chen-Jack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chen-Jack/subscriptions","organizations_url":"https://api.github.com/users/Chen-Jack/orgs","repos_url":"https://api.github.com/users/Chen-Jack/repos","events_url":"https://api.github.com/users/Chen-Jack/events{/privacy}","received_events_url":"https://api.github.com/users/Chen-Jack/received_events","type":"User","site_admin":false},"body":"Since we need to use this function, we need to export this function. ","created_at":"2019-06-12T22:27:51Z","updated_at":"2019-06-12T22:28:33Z","html_url":"https://github.com/fwoodpwicker/fwood-pwicker/pull/17#discussion_r293143127","pull_request_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/17","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/comments/293143127"},"html":{"href":"https://github.com/fwoodpwicker/fwood-pwicker/pull/17#discussion_r293143127"},"pull_request":{"href":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/17","id":287687326,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3Njg3MzI2","html_url":"https://github.com/fwoodpwicker/fwood-pwicker/pull/17","diff_url":"https://github.com/fwoodpwicker/fwood-pwicker/pull/17.diff","patch_url":"https://github.com/fwoodpwicker/fwood-pwicker/pull/17.patch","issue_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues/17","number":17,"state":"open","locked":false,"title":"Random Name Generator","user":{"login":"iambcho","id":46508073,"node_id":"MDQ6VXNlcjQ2NTA4MDcz","avatar_url":"https://avatars1.githubusercontent.com/u/46508073?v=4","gravatar_id":"","url":"https://api.github.com/users/iambcho","html_url":"https://github.com/iambcho","followers_url":"https://api.github.com/users/iambcho/followers","following_url":"https://api.github.com/users/iambcho/following{/other_user}","gists_url":"https://api.github.com/users/iambcho/gists{/gist_id}","starred_url":"https://api.github.com/users/iambcho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iambcho/subscriptions","organizations_url":"https://api.github.com/users/iambcho/orgs","repos_url":"https://api.github.com/users/iambcho/repos","events_url":"https://api.github.com/users/iambcho/events{/privacy}","received_events_url":"https://api.github.com/users/iambcho/received_events","type":"User","site_admin":false},"body":"Random Name Generator ok?","created_at":"2019-06-12T21:44:00Z","updated_at":"2019-06-12T22:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08191aace2be770124142de90258dd330dca1bf7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/17/commits","review_comments_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/17/comments","review_comment_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues/17/comments","statuses_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/statuses/5ea11d5971f7869dc9c2a12a1a72c8c690358934","head":{"label":"fwoodpwicker:random_name","ref":"random_name","sha":"5ea11d5971f7869dc9c2a12a1a72c8c690358934","user":{"login":"fwoodpwicker","id":51300772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzAwNzcy","avatar_url":"https://avatars1.githubusercontent.com/u/51300772?v=4","gravatar_id":"","url":"https://api.github.com/users/fwoodpwicker","html_url":"https://github.com/fwoodpwicker","followers_url":"https://api.github.com/users/fwoodpwicker/followers","following_url":"https://api.github.com/users/fwoodpwicker/following{/other_user}","gists_url":"https://api.github.com/users/fwoodpwicker/gists{/gist_id}","starred_url":"https://api.github.com/users/fwoodpwicker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwoodpwicker/subscriptions","organizations_url":"https://api.github.com/users/fwoodpwicker/orgs","repos_url":"https://api.github.com/users/fwoodpwicker/repos","events_url":"https://api.github.com/users/fwoodpwicker/events{/privacy}","received_events_url":"https://api.github.com/users/fwoodpwicker/received_events","type":"Organization","site_admin":false},"repo":{"id":184649043,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ2NDkwNDM=","name":"fwood-pwicker","full_name":"fwoodpwicker/fwood-pwicker","private":false,"owner":{"login":"fwoodpwicker","id":51300772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzAwNzcy","avatar_url":"https://avatars1.githubusercontent.com/u/51300772?v=4","gravatar_id":"","url":"https://api.github.com/users/fwoodpwicker","html_url":"https://github.com/fwoodpwicker","followers_url":"https://api.github.com/users/fwoodpwicker/followers","following_url":"https://api.github.com/users/fwoodpwicker/following{/other_user}","gists_url":"https://api.github.com/users/fwoodpwicker/gists{/gist_id}","starred_url":"https://api.github.com/users/fwoodpwicker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwoodpwicker/subscriptions","organizations_url":"https://api.github.com/users/fwoodpwicker/orgs","repos_url":"https://api.github.com/users/fwoodpwicker/repos","events_url":"https://api.github.com/users/fwoodpwicker/events{/privacy}","received_events_url":"https://api.github.com/users/fwoodpwicker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fwoodpwicker/fwood-pwicker","description":"Project FP","fork":false,"url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker","forks_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/forks","keys_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/teams","hooks_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/hooks","issue_events_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues/events{/number}","events_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/events","assignees_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/assignees{/user}","branches_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/branches{/branch}","tags_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/tags","blobs_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/statuses/{sha}","languages_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/languages","stargazers_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/stargazers","contributors_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/contributors","subscribers_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/subscribers","subscription_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/subscription","commits_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/contents/{+path}","compare_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/merges","archive_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/downloads","issues_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues{/number}","pulls_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls{/number}","milestones_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/milestones{/number}","notifications_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/labels{/name}","releases_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/releases{/id}","deployments_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/deployments","created_at":"2019-05-02T20:43:44Z","updated_at":"2019-06-12T21:43:38Z","pushed_at":"2019-06-12T21:44:00Z","git_url":"git://github.com/fwoodpwicker/fwood-pwicker.git","ssh_url":"[email protected]:fwoodpwicker/fwood-pwicker.git","clone_url":"https://github.com/fwoodpwicker/fwood-pwicker.git","svn_url":"https://github.com/fwoodpwicker/fwood-pwicker","homepage":"","size":3724,"stargazers_count":4,"watchers_count":4,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"fwoodpwicker:master","ref":"master","sha":"26d27183862d2e6e37a01d8e1da506d7eddaf037","user":{"login":"fwoodpwicker","id":51300772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzAwNzcy","avatar_url":"https://avatars1.githubusercontent.com/u/51300772?v=4","gravatar_id":"","url":"https://api.github.com/users/fwoodpwicker","html_url":"https://github.com/fwoodpwicker","followers_url":"https://api.github.com/users/fwoodpwicker/followers","following_url":"https://api.github.com/users/fwoodpwicker/following{/other_user}","gists_url":"https://api.github.com/users/fwoodpwicker/gists{/gist_id}","starred_url":"https://api.github.com/users/fwoodpwicker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwoodpwicker/subscriptions","organizations_url":"https://api.github.com/users/fwoodpwicker/orgs","repos_url":"https://api.github.com/users/fwoodpwicker/repos","events_url":"https://api.github.com/users/fwoodpwicker/events{/privacy}","received_events_url":"https://api.github.com/users/fwoodpwicker/received_events","type":"Organization","site_admin":false},"repo":{"id":184649043,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ2NDkwNDM=","name":"fwood-pwicker","full_name":"fwoodpwicker/fwood-pwicker","private":false,"owner":{"login":"fwoodpwicker","id":51300772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzAwNzcy","avatar_url":"https://avatars1.githubusercontent.com/u/51300772?v=4","gravatar_id":"","url":"https://api.github.com/users/fwoodpwicker","html_url":"https://github.com/fwoodpwicker","followers_url":"https://api.github.com/users/fwoodpwicker/followers","following_url":"https://api.github.com/users/fwoodpwicker/following{/other_user}","gists_url":"https://api.github.com/users/fwoodpwicker/gists{/gist_id}","starred_url":"https://api.github.com/users/fwoodpwicker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwoodpwicker/subscriptions","organizations_url":"https://api.github.com/users/fwoodpwicker/orgs","repos_url":"https://api.github.com/users/fwoodpwicker/repos","events_url":"https://api.github.com/users/fwoodpwicker/events{/privacy}","received_events_url":"https://api.github.com/users/fwoodpwicker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fwoodpwicker/fwood-pwicker","description":"Project FP","fork":false,"url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker","forks_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/forks","keys_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/teams","hooks_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/hooks","issue_events_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues/events{/number}","events_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/events","assignees_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/assignees{/user}","branches_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/branches{/branch}","tags_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/tags","blobs_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/statuses/{sha}","languages_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/languages","stargazers_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/stargazers","contributors_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/contributors","subscribers_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/subscribers","subscription_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/subscription","commits_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/contents/{+path}","compare_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/merges","archive_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/downloads","issues_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues{/number}","pulls_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls{/number}","milestones_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/milestones{/number}","notifications_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/labels{/name}","releases_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/releases{/id}","deployments_url":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/deployments","created_at":"2019-05-02T20:43:44Z","updated_at":"2019-06-12T21:43:38Z","pushed_at":"2019-06-12T21:44:00Z","git_url":"git://github.com/fwoodpwicker/fwood-pwicker.git","ssh_url":"[email protected]:fwoodpwicker/fwood-pwicker.git","clone_url":"https://github.com/fwoodpwicker/fwood-pwicker.git","svn_url":"https://github.com/fwoodpwicker/fwood-pwicker","homepage":"","size":3724,"stargazers_count":4,"watchers_count":4,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/17"},"html":{"href":"https://github.com/fwoodpwicker/fwood-pwicker/pull/17"},"issue":{"href":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues/17"},"comments":{"href":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/fwoodpwicker/fwood-pwicker/statuses/5ea11d5971f7869dc9c2a12a1a72c8c690358934"}},"author_association":"COLLABORATOR"}}
|
{
"id": 184649043,
"name": "fwoodpwicker/fwood-pwicker",
"url": "https://api.github.com/repos/fwoodpwicker/fwood-pwicker"
}
|
{
"id": 23295845,
"login": "Chen-Jack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23295845?",
"url": "https://api.github.com/users/Chen-Jack"
}
|
{
"id": 51300772,
"login": "fwoodpwicker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51300772?",
"url": "https://api.github.com/orgs/fwoodpwicker"
}
| 2019-06-12T22:27:51 |
9811132427
|
{"actor":{"display_login":"Chen-Jack"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/comments/346510971","pull_request_review_id":317214236,"id":346510971,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NjUxMDk3MQ==","diff_hunk":"@@ -4,7 +4,7 @@ import (\n \t\"encoding/hex\"\n \t\"testing\"\n \n-\ttezosprotocol \"github.com/anchorageoss/tezosprotocol/v2\"\n+\t\"github.com/anchorageoss/tezosprotocol/v2\"","path":"base58check_test.go","position":5,"original_position":5,"commit_id":"dd663fca47a5cdab3e3d5b50471fbb17a74d5692","original_commit_id":"e22ce6e000f0b3b72ec7067a859d4d80cf7de28c","user":{"login":"joeabbey","id":759747,"node_id":"MDQ6VXNlcjc1OTc0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/759747?v=4","gravatar_id":"","url":"https://api.github.com/users/joeabbey","html_url":"https://github.com/joeabbey","followers_url":"https://api.github.com/users/joeabbey/followers","following_url":"https://api.github.com/users/joeabbey/following{/other_user}","gists_url":"https://api.github.com/users/joeabbey/gists{/gist_id}","starred_url":"https://api.github.com/users/joeabbey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeabbey/subscriptions","organizations_url":"https://api.github.com/users/joeabbey/orgs","repos_url":"https://api.github.com/users/joeabbey/repos","events_url":"https://api.github.com/users/joeabbey/events{/privacy}","received_events_url":"https://api.github.com/users/joeabbey/received_events","type":"User","site_admin":false},"body":"Agreed, but I think there's some work to make v2 honored to:\r\n\r\nhttps://blog.golang.org/v2-go-modules","created_at":"2019-11-14T19:43:15Z","updated_at":"2019-11-14T19:43:15Z","html_url":"https://github.com/anchorageoss/tezosprotocol/pull/16#discussion_r346510971","pull_request_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/16","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/comments/346510971"},"html":{"href":"https://github.com/anchorageoss/tezosprotocol/pull/16#discussion_r346510971"},"pull_request":{"href":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/16"}},"in_reply_to_id":345934701},"pull_request":{"url":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/16","id":339472058,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5NDcyMDU4","html_url":"https://github.com/anchorageoss/tezosprotocol/pull/16","diff_url":"https://github.com/anchorageoss/tezosprotocol/pull/16.diff","patch_url":"https://github.com/anchorageoss/tezosprotocol/pull/16.patch","issue_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/issues/16","number":16,"state":"open","locked":false,"title":"Dividing up the various types and interfaces in p2p_messages.go","user":{"login":"joeabbey","id":759747,"node_id":"MDQ6VXNlcjc1OTc0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/759747?v=4","gravatar_id":"","url":"https://api.github.com/users/joeabbey","html_url":"https://github.com/joeabbey","followers_url":"https://api.github.com/users/joeabbey/followers","following_url":"https://api.github.com/users/joeabbey/following{/other_user}","gists_url":"https://api.github.com/users/joeabbey/gists{/gist_id}","starred_url":"https://api.github.com/users/joeabbey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeabbey/subscriptions","organizations_url":"https://api.github.com/users/joeabbey/orgs","repos_url":"https://api.github.com/users/joeabbey/repos","events_url":"https://api.github.com/users/joeabbey/events{/privacy}","received_events_url":"https://api.github.com/users/joeabbey/received_events","type":"User","site_admin":false},"body":"**TL;DR:**\r\nThis is mostly superficial.. but the p2p_messages.go file was pretty big. So I made smaller files.\r\n\r\n**The DR:**\r\nI was trying to use [Coverage Gutters](https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters) with this package and many of the files were shown as uncovered. Upon inspecting further, I wondered if the various interface implementations were resulting in a coverage.xml that couldn't be applied. \r\n\r\nSo I started dividing the files up into separate smaller scoped files. This mostly worked but for whatever reason global scoped methods wouldn't show up either. Then I discovered: \r\n \r\n\r\n๐คฆโโ \r\n\r\nApparently Visual Studio code has a built-in coverage for go coverage that one can simply toggle on.\r\n\r\nNevertheless, the work has been done to divide the p2p_messages.go and p2p_messages_test.go into smaller files. \r\n\r\n(I also added a Makefile, but there's nothing to really install b/c as I presume this is largely a module for other tooling.. just makes it easier to run `make` from a shell to run lint, vet, and test.)\r\n ","created_at":"2019-11-11T14:53:09Z","updated_at":"2019-11-14T19:43:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e5c4397e712b065a0dc097a7fcb3049e99b0fd9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/16/commits","review_comments_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/16/comments","review_comment_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/issues/16/comments","statuses_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/statuses/dd663fca47a5cdab3e3d5b50471fbb17a74d5692","head":{"label":"joeabbey:divide-and-conquer","ref":"divide-and-conquer","sha":"dd663fca47a5cdab3e3d5b50471fbb17a74d5692","user":{"login":"joeabbey","id":759747,"node_id":"MDQ6VXNlcjc1OTc0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/759747?v=4","gravatar_id":"","url":"https://api.github.com/users/joeabbey","html_url":"https://github.com/joeabbey","followers_url":"https://api.github.com/users/joeabbey/followers","following_url":"https://api.github.com/users/joeabbey/following{/other_user}","gists_url":"https://api.github.com/users/joeabbey/gists{/gist_id}","starred_url":"https://api.github.com/users/joeabbey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeabbey/subscriptions","organizations_url":"https://api.github.com/users/joeabbey/orgs","repos_url":"https://api.github.com/users/joeabbey/repos","events_url":"https://api.github.com/users/joeabbey/events{/privacy}","received_events_url":"https://api.github.com/users/joeabbey/received_events","type":"User","site_admin":false},"repo":{"id":212344371,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIzNDQzNzE=","name":"tezosprotocol","full_name":"joeabbey/tezosprotocol","private":false,"owner":{"login":"joeabbey","id":759747,"node_id":"MDQ6VXNlcjc1OTc0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/759747?v=4","gravatar_id":"","url":"https://api.github.com/users/joeabbey","html_url":"https://github.com/joeabbey","followers_url":"https://api.github.com/users/joeabbey/followers","following_url":"https://api.github.com/users/joeabbey/following{/other_user}","gists_url":"https://api.github.com/users/joeabbey/gists{/gist_id}","starred_url":"https://api.github.com/users/joeabbey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeabbey/subscriptions","organizations_url":"https://api.github.com/users/joeabbey/orgs","repos_url":"https://api.github.com/users/joeabbey/repos","events_url":"https://api.github.com/users/joeabbey/events{/privacy}","received_events_url":"https://api.github.com/users/joeabbey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joeabbey/tezosprotocol","description":"An implementation of the Tezos peer-to-peer communications protocol.","fork":true,"url":"https://api.github.com/repos/joeabbey/tezosprotocol","forks_url":"https://api.github.com/repos/joeabbey/tezosprotocol/forks","keys_url":"https://api.github.com/repos/joeabbey/tezosprotocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joeabbey/tezosprotocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joeabbey/tezosprotocol/teams","hooks_url":"https://api.github.com/repos/joeabbey/tezosprotocol/hooks","issue_events_url":"https://api.github.com/repos/joeabbey/tezosprotocol/issues/events{/number}","events_url":"https://api.github.com/repos/joeabbey/tezosprotocol/events","assignees_url":"https://api.github.com/repos/joeabbey/tezosprotocol/assignees{/user}","branches_url":"https://api.github.com/repos/joeabbey/tezosprotocol/branches{/branch}","tags_url":"https://api.github.com/repos/joeabbey/tezosprotocol/tags","blobs_url":"https://api.github.com/repos/joeabbey/tezosprotocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joeabbey/tezosprotocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joeabbey/tezosprotocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/joeabbey/tezosprotocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joeabbey/tezosprotocol/statuses/{sha}","languages_url":"https://api.github.com/repos/joeabbey/tezosprotocol/languages","stargazers_url":"https://api.github.com/repos/joeabbey/tezosprotocol/stargazers","contributors_url":"https://api.github.com/repos/joeabbey/tezosprotocol/contributors","subscribers_url":"https://api.github.com/repos/joeabbey/tezosprotocol/subscribers","subscription_url":"https://api.github.com/repos/joeabbey/tezosprotocol/subscription","commits_url":"https://api.github.com/repos/joeabbey/tezosprotocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/joeabbey/tezosprotocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/joeabbey/tezosprotocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/joeabbey/tezosprotocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/joeabbey/tezosprotocol/contents/{+path}","compare_url":"https://api.github.com/repos/joeabbey/tezosprotocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joeabbey/tezosprotocol/merges","archive_url":"https://api.github.com/repos/joeabbey/tezosprotocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joeabbey/tezosprotocol/downloads","issues_url":"https://api.github.com/repos/joeabbey/tezosprotocol/issues{/number}","pulls_url":"https://api.github.com/repos/joeabbey/tezosprotocol/pulls{/number}","milestones_url":"https://api.github.com/repos/joeabbey/tezosprotocol/milestones{/number}","notifications_url":"https://api.github.com/repos/joeabbey/tezosprotocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joeabbey/tezosprotocol/labels{/name}","releases_url":"https://api.github.com/repos/joeabbey/tezosprotocol/releases{/id}","deployments_url":"https://api.github.com/repos/joeabbey/tezosprotocol/deployments","created_at":"2019-10-02T13:07:48Z","updated_at":"2019-10-02T13:07:50Z","pushed_at":"2019-11-14T19:22:10Z","git_url":"git://github.com/joeabbey/tezosprotocol.git","ssh_url":"[email protected]:joeabbey/tezosprotocol.git","clone_url":"https://github.com/joeabbey/tezosprotocol.git","svn_url":"https://github.com/joeabbey/tezosprotocol","homepage":"","size":77,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"anchorageoss:master","ref":"master","sha":"de00a3d8b8e1640003d0a5aac849d91ee58049a0","user":{"login":"anchorageoss","id":51490635,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNDkwNjM1","avatar_url":"https://avatars1.githubusercontent.com/u/51490635?v=4","gravatar_id":"","url":"https://api.github.com/users/anchorageoss","html_url":"https://github.com/anchorageoss","followers_url":"https://api.github.com/users/anchorageoss/followers","following_url":"https://api.github.com/users/anchorageoss/following{/other_user}","gists_url":"https://api.github.com/users/anchorageoss/gists{/gist_id}","starred_url":"https://api.github.com/users/anchorageoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchorageoss/subscriptions","organizations_url":"https://api.github.com/users/anchorageoss/orgs","repos_url":"https://api.github.com/users/anchorageoss/repos","events_url":"https://api.github.com/users/anchorageoss/events{/privacy}","received_events_url":"https://api.github.com/users/anchorageoss/received_events","type":"Organization","site_admin":false},"repo":{"id":207393279,"node_id":"MDEwOlJlcG9zaXRvcnkyMDczOTMyNzk=","name":"tezosprotocol","full_name":"anchorageoss/tezosprotocol","private":false,"owner":{"login":"anchorageoss","id":51490635,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNDkwNjM1","avatar_url":"https://avatars1.githubusercontent.com/u/51490635?v=4","gravatar_id":"","url":"https://api.github.com/users/anchorageoss","html_url":"https://github.com/anchorageoss","followers_url":"https://api.github.com/users/anchorageoss/followers","following_url":"https://api.github.com/users/anchorageoss/following{/other_user}","gists_url":"https://api.github.com/users/anchorageoss/gists{/gist_id}","starred_url":"https://api.github.com/users/anchorageoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchorageoss/subscriptions","organizations_url":"https://api.github.com/users/anchorageoss/orgs","repos_url":"https://api.github.com/users/anchorageoss/repos","events_url":"https://api.github.com/users/anchorageoss/events{/privacy}","received_events_url":"https://api.github.com/users/anchorageoss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/anchorageoss/tezosprotocol","description":"An implementation of the Tezos peer-to-peer communications protocol.","fork":false,"url":"https://api.github.com/repos/anchorageoss/tezosprotocol","forks_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/forks","keys_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/teams","hooks_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/hooks","issue_events_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/issues/events{/number}","events_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/events","assignees_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/assignees{/user}","branches_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/branches{/branch}","tags_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/tags","blobs_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/statuses/{sha}","languages_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/languages","stargazers_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/stargazers","contributors_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/contributors","subscribers_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/subscribers","subscription_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/subscription","commits_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/contents/{+path}","compare_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/merges","archive_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/downloads","issues_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/issues{/number}","pulls_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls{/number}","milestones_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/milestones{/number}","notifications_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/labels{/name}","releases_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/releases{/id}","deployments_url":"https://api.github.com/repos/anchorageoss/tezosprotocol/deployments","created_at":"2019-09-09T19:57:20Z","updated_at":"2019-11-13T18:23:58Z","pushed_at":"2019-11-14T19:22:12Z","git_url":"git://github.com/anchorageoss/tezosprotocol.git","ssh_url":"[email protected]:anchorageoss/tezosprotocol.git","clone_url":"https://github.com/anchorageoss/tezosprotocol.git","svn_url":"https://github.com/anchorageoss/tezosprotocol","homepage":"","size":60,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/16"},"html":{"href":"https://github.com/anchorageoss/tezosprotocol/pull/16"},"issue":{"href":"https://api.github.com/repos/anchorageoss/tezosprotocol/issues/16"},"comments":{"href":"https://api.github.com/repos/anchorageoss/tezosprotocol/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/anchorageoss/tezosprotocol/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/anchorageoss/tezosprotocol/statuses/dd663fca47a5cdab3e3d5b50471fbb17a74d5692"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 207393279,
"name": "anchorageoss/tezosprotocol",
"url": "https://api.github.com/repos/anchorageoss/tezosprotocol"
}
|
{
"id": 759747,
"login": "joeabbey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/759747?",
"url": "https://api.github.com/users/joeabbey"
}
|
{
"id": 51490635,
"login": "anchorageoss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51490635?",
"url": "https://api.github.com/orgs/anchorageoss"
}
| 2019-11-14T19:43:15 |
10865765659
|
{"actor":{"display_login":"joeabbey"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hatchways/team-rosebud/pulls/comments/305214880","pull_request_review_id":264030331,"id":305214880,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTIxNDg4MA==","diff_hunk":"@@ -2,23 +2,63 @@\n from flask_sqlalchemy import SQLAlchemy\n from flask_marshmallow import Marshmallow\n from marshmallow import Schema, fields, pre_load, validate\n-\n+from typing import List\n \n # Order matters: Initialize SQLAlchemy before Marshmallow\n db = SQLAlchemy()\n ma = Marshmallow()\n \n+association_table = db.Table('association_table',","path":"server/models.py","position":11,"original_position":11,"commit_id":"5f6dfa42e1022e285ecb0dfdfd2229df7b05a96f","original_commit_id":"5f6dfa42e1022e285ecb0dfdfd2229df7b05a96f","user":{"login":"skassam21","id":5060546,"node_id":"MDQ6VXNlcjUwNjA1NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5060546?v=4","gravatar_id":"","url":"https://api.github.com/users/skassam21","html_url":"https://github.com/skassam21","followers_url":"https://api.github.com/users/skassam21/followers","following_url":"https://api.github.com/users/skassam21/following{/other_user}","gists_url":"https://api.github.com/users/skassam21/gists{/gist_id}","starred_url":"https://api.github.com/users/skassam21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skassam21/subscriptions","organizations_url":"https://api.github.com/users/skassam21/orgs","repos_url":"https://api.github.com/users/skassam21/repos","events_url":"https://api.github.com/users/skassam21/events{/privacy}","received_events_url":"https://api.github.com/users/skassam21/received_events","type":"User","site_admin":false},"body":"๐ ","created_at":"2019-07-19T06:20:06Z","updated_at":"2019-07-19T06:24:56Z","html_url":"https://github.com/hatchways/team-rosebud/pull/30#discussion_r305214880","pull_request_url":"https://api.github.com/repos/hatchways/team-rosebud/pulls/30","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hatchways/team-rosebud/pulls/comments/305214880"},"html":{"href":"https://github.com/hatchways/team-rosebud/pull/30#discussion_r305214880"},"pull_request":{"href":"https://api.github.com/repos/hatchways/team-rosebud/pulls/30"}},"in_reply_to_id":304082243},"pull_request":{"url":"https://api.github.com/repos/hatchways/team-rosebud/pulls/30","id":298137141,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4MTM3MTQx","html_url":"https://github.com/hatchways/team-rosebud/pull/30","diff_url":"https://github.com/hatchways/team-rosebud/pull/30.diff","patch_url":"https://github.com/hatchways/team-rosebud/pull/30.patch","issue_url":"https://api.github.com/repos/hatchways/team-rosebud/issues/30","number":30,"state":"open","locked":false,"title":"User Model, Skills Models and M2M connections, Token Auth for Login logout","user":{"login":"sjain93","id":42393122,"node_id":"MDQ6VXNlcjQyMzkzMTIy","avatar_url":"https://avatars2.githubusercontent.com/u/42393122?v=4","gravatar_id":"","url":"https://api.github.com/users/sjain93","html_url":"https://github.com/sjain93","followers_url":"https://api.github.com/users/sjain93/followers","following_url":"https://api.github.com/users/sjain93/following{/other_user}","gists_url":"https://api.github.com/users/sjain93/gists{/gist_id}","starred_url":"https://api.github.com/users/sjain93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjain93/subscriptions","organizations_url":"https://api.github.com/users/sjain93/orgs","repos_url":"https://api.github.com/users/sjain93/repos","events_url":"https://api.github.com/users/sjain93/events{/privacy}","received_events_url":"https://api.github.com/users/sjain93/received_events","type":"User","site_admin":false},"body":"Want create a new branch once this is reviewed and merged to continue with this week's tickets. \r\nIncluded in this merge request:\r\n\r\n1. User Model attributes updated\r\n`username = db.Column(db.String(80))`\r\n`password = db.Column(db.String(80), nullable=False)`\r\n`email = db.Column(db.String(120), nullable=False, unique=True)`\r\n`location = db.Column(db.String(120), nullable=False)`\r\n`yearsexp = db.Column(db.Integer, nullable=False)`\r\n`description = db.Column(db.String(256), nullable=False)`\r\n\r\n2. Token Auth methods and endpoints added. Sign in facilitated by email and password, Werkzeug used for password hashing/verification.\r\n\r\nJWT created per user session, to add put methods with token_required decoration (upcoming PR). JWT blacklisted in memory on logout.\r\n\r\nCurrent endpoints available\r\n_Blueprinted /api/anything below_\r\n> api.add_resource(Hello, '/Hello')\r\n> api.add_resource(UserRegister, \"/register\")\r\n> api.add_resource(User, \"/user/<int:user_id>\")\r\n> api.add_resource(UserLogin, \"/login\")\r\n> api.add_resource(TokenRefresh, \"/refresh\")\r\n> api.add_resource(UserLogout, \"/logout\")\r\n> api.add_resource(ProjectCreate, \"/create\")\r\n> api.add_resource(Project, \"/project/<int:project_id>\")\r\n> api.add_resource(SkillCreate, \"/skill\")\r\n> api.add_resource(Skill, \"/skill/<int:skill_id>\")\r\n> api.add_resource(SkillList, \"/skills\")\r\n\r\n3. Skills model updated and linked to UserModel via association table\r\n4. Projects model intact","created_at":"2019-07-16T17:20:22Z","updated_at":"2019-07-19T06:24:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"016498007390b49fe7bac3d0d181d4c29e7e913d","assignee":{"login":"sjain93","id":42393122,"node_id":"MDQ6VXNlcjQyMzkzMTIy","avatar_url":"https://avatars2.githubusercontent.com/u/42393122?v=4","gravatar_id":"","url":"https://api.github.com/users/sjain93","html_url":"https://github.com/sjain93","followers_url":"https://api.github.com/users/sjain93/followers","following_url":"https://api.github.com/users/sjain93/following{/other_user}","gists_url":"https://api.github.com/users/sjain93/gists{/gist_id}","starred_url":"https://api.github.com/users/sjain93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjain93/subscriptions","organizations_url":"https://api.github.com/users/sjain93/orgs","repos_url":"https://api.github.com/users/sjain93/repos","events_url":"https://api.github.com/users/sjain93/events{/privacy}","received_events_url":"https://api.github.com/users/sjain93/received_events","type":"User","site_admin":false},"assignees":[{"login":"sjain93","id":42393122,"node_id":"MDQ6VXNlcjQyMzkzMTIy","avatar_url":"https://avatars2.githubusercontent.com/u/42393122?v=4","gravatar_id":"","url":"https://api.github.com/users/sjain93","html_url":"https://github.com/sjain93","followers_url":"https://api.github.com/users/sjain93/followers","following_url":"https://api.github.com/users/sjain93/following{/other_user}","gists_url":"https://api.github.com/users/sjain93/gists{/gist_id}","starred_url":"https://api.github.com/users/sjain93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjain93/subscriptions","organizations_url":"https://api.github.com/users/sjain93/orgs","repos_url":"https://api.github.com/users/sjain93/repos","events_url":"https://api.github.com/users/sjain93/events{/privacy}","received_events_url":"https://api.github.com/users/sjain93/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hatchways/team-rosebud/pulls/30/commits","review_comments_url":"https://api.github.com/repos/hatchways/team-rosebud/pulls/30/comments","review_comment_url":"https://api.github.com/repos/hatchways/team-rosebud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hatchways/team-rosebud/issues/30/comments","statuses_url":"https://api.github.com/repos/hatchways/team-rosebud/statuses/5f6dfa42e1022e285ecb0dfdfd2229df7b05a96f","head":{"label":"hatchways:sanchit-skills-models","ref":"sanchit-skills-models","sha":"5f6dfa42e1022e285ecb0dfdfd2229df7b05a96f","user":{"login":"hatchways","id":51765250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzY1MjUw","avatar_url":"https://avatars1.githubusercontent.com/u/51765250?v=4","gravatar_id":"","url":"https://api.github.com/users/hatchways","html_url":"https://github.com/hatchways","followers_url":"https://api.github.com/users/hatchways/followers","following_url":"https://api.github.com/users/hatchways/following{/other_user}","gists_url":"https://api.github.com/users/hatchways/gists{/gist_id}","starred_url":"https://api.github.com/users/hatchways/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatchways/subscriptions","organizations_url":"https://api.github.com/users/hatchways/orgs","repos_url":"https://api.github.com/users/hatchways/repos","events_url":"https://api.github.com/users/hatchways/events{/privacy}","received_events_url":"https://api.github.com/users/hatchways/received_events","type":"Organization","site_admin":false},"repo":{"id":195418744,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU0MTg3NDQ=","name":"team-rosebud","full_name":"hatchways/team-rosebud","private":false,"owner":{"login":"hatchways","id":51765250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzY1MjUw","avatar_url":"https://avatars1.githubusercontent.com/u/51765250?v=4","gravatar_id":"","url":"https://api.github.com/users/hatchways","html_url":"https://github.com/hatchways","followers_url":"https://api.github.com/users/hatchways/followers","following_url":"https://api.github.com/users/hatchways/following{/other_user}","gists_url":"https://api.github.com/users/hatchways/gists{/gist_id}","starred_url":"https://api.github.com/users/hatchways/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatchways/subscriptions","organizations_url":"https://api.github.com/users/hatchways/orgs","repos_url":"https://api.github.com/users/hatchways/repos","events_url":"https://api.github.com/users/hatchways/events{/privacy}","received_events_url":"https://api.github.com/users/hatchways/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hatchways/team-rosebud","description":null,"fork":false,"url":"https://api.github.com/repos/hatchways/team-rosebud","forks_url":"https://api.github.com/repos/hatchways/team-rosebud/forks","keys_url":"https://api.github.com/repos/hatchways/team-rosebud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hatchways/team-rosebud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hatchways/team-rosebud/teams","hooks_url":"https://api.github.com/repos/hatchways/team-rosebud/hooks","issue_events_url":"https://api.github.com/repos/hatchways/team-rosebud/issues/events{/number}","events_url":"https://api.github.com/repos/hatchways/team-rosebud/events","assignees_url":"https://api.github.com/repos/hatchways/team-rosebud/assignees{/user}","branches_url":"https://api.github.com/repos/hatchways/team-rosebud/branches{/branch}","tags_url":"https://api.github.com/repos/hatchways/team-rosebud/tags","blobs_url":"https://api.github.com/repos/hatchways/team-rosebud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hatchways/team-rosebud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hatchways/team-rosebud/git/refs{/sha}","trees_url":"https://api.github.com/repos/hatchways/team-rosebud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hatchways/team-rosebud/statuses/{sha}","languages_url":"https://api.github.com/repos/hatchways/team-rosebud/languages","stargazers_url":"https://api.github.com/repos/hatchways/team-rosebud/stargazers","contributors_url":"https://api.github.com/repos/hatchways/team-rosebud/contributors","subscribers_url":"https://api.github.com/repos/hatchways/team-rosebud/subscribers","subscription_url":"https://api.github.com/repos/hatchways/team-rosebud/subscription","commits_url":"https://api.github.com/repos/hatchways/team-rosebud/commits{/sha}","git_commits_url":"https://api.github.com/repos/hatchways/team-rosebud/git/commits{/sha}","comments_url":"https://api.github.com/repos/hatchways/team-rosebud/comments{/number}","issue_comment_url":"https://api.github.com/repos/hatchways/team-rosebud/issues/comments{/number}","contents_url":"https://api.github.com/repos/hatchways/team-rosebud/contents/{+path}","compare_url":"https://api.github.com/repos/hatchways/team-rosebud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hatchways/team-rosebud/merges","archive_url":"https://api.github.com/repos/hatchways/team-rosebud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hatchways/team-rosebud/downloads","issues_url":"https://api.github.com/repos/hatchways/team-rosebud/issues{/number}","pulls_url":"https://api.github.com/repos/hatchways/team-rosebud/pulls{/number}","milestones_url":"https://api.github.com/repos/hatchways/team-rosebud/milestones{/number}","notifications_url":"https://api.github.com/repos/hatchways/team-rosebud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hatchways/team-rosebud/labels{/name}","releases_url":"https://api.github.com/repos/hatchways/team-rosebud/releases{/id}","deployments_url":"https://api.github.com/repos/hatchways/team-rosebud/deployments","created_at":"2019-07-05T14:00:30Z","updated_at":"2019-07-11T16:17:32Z","pushed_at":"2019-07-19T06:02:07Z","git_url":"git://github.com/hatchways/team-rosebud.git","ssh_url":"[email protected]:hatchways/team-rosebud.git","clone_url":"https://github.com/hatchways/team-rosebud.git","svn_url":"https://github.com/hatchways/team-rosebud","homepage":null,"size":3389,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":null,"forks":0,"open_issues":19,"watchers":0,"default_branch":"dev"}},"base":{"label":"hatchways:dev","ref":"dev","sha":"5a447cb7f797dfdff38d0f9fcd3ca605893e0273","user":{"login":"hatchways","id":51765250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzY1MjUw","avatar_url":"https://avatars1.githubusercontent.com/u/51765250?v=4","gravatar_id":"","url":"https://api.github.com/users/hatchways","html_url":"https://github.com/hatchways","followers_url":"https://api.github.com/users/hatchways/followers","following_url":"https://api.github.com/users/hatchways/following{/other_user}","gists_url":"https://api.github.com/users/hatchways/gists{/gist_id}","starred_url":"https://api.github.com/users/hatchways/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatchways/subscriptions","organizations_url":"https://api.github.com/users/hatchways/orgs","repos_url":"https://api.github.com/users/hatchways/repos","events_url":"https://api.github.com/users/hatchways/events{/privacy}","received_events_url":"https://api.github.com/users/hatchways/received_events","type":"Organization","site_admin":false},"repo":{"id":195418744,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU0MTg3NDQ=","name":"team-rosebud","full_name":"hatchways/team-rosebud","private":false,"owner":{"login":"hatchways","id":51765250,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzY1MjUw","avatar_url":"https://avatars1.githubusercontent.com/u/51765250?v=4","gravatar_id":"","url":"https://api.github.com/users/hatchways","html_url":"https://github.com/hatchways","followers_url":"https://api.github.com/users/hatchways/followers","following_url":"https://api.github.com/users/hatchways/following{/other_user}","gists_url":"https://api.github.com/users/hatchways/gists{/gist_id}","starred_url":"https://api.github.com/users/hatchways/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatchways/subscriptions","organizations_url":"https://api.github.com/users/hatchways/orgs","repos_url":"https://api.github.com/users/hatchways/repos","events_url":"https://api.github.com/users/hatchways/events{/privacy}","received_events_url":"https://api.github.com/users/hatchways/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hatchways/team-rosebud","description":null,"fork":false,"url":"https://api.github.com/repos/hatchways/team-rosebud","forks_url":"https://api.github.com/repos/hatchways/team-rosebud/forks","keys_url":"https://api.github.com/repos/hatchways/team-rosebud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hatchways/team-rosebud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hatchways/team-rosebud/teams","hooks_url":"https://api.github.com/repos/hatchways/team-rosebud/hooks","issue_events_url":"https://api.github.com/repos/hatchways/team-rosebud/issues/events{/number}","events_url":"https://api.github.com/repos/hatchways/team-rosebud/events","assignees_url":"https://api.github.com/repos/hatchways/team-rosebud/assignees{/user}","branches_url":"https://api.github.com/repos/hatchways/team-rosebud/branches{/branch}","tags_url":"https://api.github.com/repos/hatchways/team-rosebud/tags","blobs_url":"https://api.github.com/repos/hatchways/team-rosebud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hatchways/team-rosebud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hatchways/team-rosebud/git/refs{/sha}","trees_url":"https://api.github.com/repos/hatchways/team-rosebud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hatchways/team-rosebud/statuses/{sha}","languages_url":"https://api.github.com/repos/hatchways/team-rosebud/languages","stargazers_url":"https://api.github.com/repos/hatchways/team-rosebud/stargazers","contributors_url":"https://api.github.com/repos/hatchways/team-rosebud/contributors","subscribers_url":"https://api.github.com/repos/hatchways/team-rosebud/subscribers","subscription_url":"https://api.github.com/repos/hatchways/team-rosebud/subscription","commits_url":"https://api.github.com/repos/hatchways/team-rosebud/commits{/sha}","git_commits_url":"https://api.github.com/repos/hatchways/team-rosebud/git/commits{/sha}","comments_url":"https://api.github.com/repos/hatchways/team-rosebud/comments{/number}","issue_comment_url":"https://api.github.com/repos/hatchways/team-rosebud/issues/comments{/number}","contents_url":"https://api.github.com/repos/hatchways/team-rosebud/contents/{+path}","compare_url":"https://api.github.com/repos/hatchways/team-rosebud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hatchways/team-rosebud/merges","archive_url":"https://api.github.com/repos/hatchways/team-rosebud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hatchways/team-rosebud/downloads","issues_url":"https://api.github.com/repos/hatchways/team-rosebud/issues{/number}","pulls_url":"https://api.github.com/repos/hatchways/team-rosebud/pulls{/number}","milestones_url":"https://api.github.com/repos/hatchways/team-rosebud/milestones{/number}","notifications_url":"https://api.github.com/repos/hatchways/team-rosebud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hatchways/team-rosebud/labels{/name}","releases_url":"https://api.github.com/repos/hatchways/team-rosebud/releases{/id}","deployments_url":"https://api.github.com/repos/hatchways/team-rosebud/deployments","created_at":"2019-07-05T14:00:30Z","updated_at":"2019-07-11T16:17:32Z","pushed_at":"2019-07-19T06:02:07Z","git_url":"git://github.com/hatchways/team-rosebud.git","ssh_url":"[email protected]:hatchways/team-rosebud.git","clone_url":"https://github.com/hatchways/team-rosebud.git","svn_url":"https://github.com/hatchways/team-rosebud","homepage":null,"size":3389,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":null,"forks":0,"open_issues":19,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/hatchways/team-rosebud/pulls/30"},"html":{"href":"https://github.com/hatchways/team-rosebud/pull/30"},"issue":{"href":"https://api.github.com/repos/hatchways/team-rosebud/issues/30"},"comments":{"href":"https://api.github.com/repos/hatchways/team-rosebud/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/hatchways/team-rosebud/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/hatchways/team-rosebud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hatchways/team-rosebud/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/hatchways/team-rosebud/statuses/5f6dfa42e1022e285ecb0dfdfd2229df7b05a96f"}},"author_association":"COLLABORATOR"}}
|
{
"id": 195418744,
"name": "hatchways/team-rosebud",
"url": "https://api.github.com/repos/hatchways/team-rosebud"
}
|
{
"id": 5060546,
"login": "skassam21",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5060546?",
"url": "https://api.github.com/users/skassam21"
}
|
{
"id": 51765250,
"login": "hatchways",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51765250?",
"url": "https://api.github.com/orgs/hatchways"
}
| 2019-07-19T06:20:06 |
10043111172
|
{"actor":{"display_login":"skassam21"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/comments/349263819","pull_request_review_id":321115626,"id":349263819,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0OTI2MzgxOQ==","diff_hunk":"@@ -24,16 +24,16 @@ public class ActorRuntime\n private const string TraceType = \"ActorRuntime\";\n \n // Map of ActorType --> ActorManager.\n- private static Dictionary<string, ActorManager> actorManagers = new Dictionary<string, ActorManager>();\n+ private readonly Dictionary<string, ActorManager> actorManagers = new Dictionary<string, ActorManager>();\n \n- private ActorRuntime()\n+ internal ActorRuntime()","path":"src/Dapr.Actors/Runtime/ActorRuntime.cs","position":8,"original_position":8,"commit_id":"0eba2197523429074e731017327c5abaa3304502","original_commit_id":"d13a6ada33fa7c52c2d3f1f230e2b9746eaa4945","user":{"login":"philliphoff","id":6402946,"node_id":"MDQ6VXNlcjY0MDI5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6402946?v=4","gravatar_id":"","url":"https://api.github.com/users/philliphoff","html_url":"https://github.com/philliphoff","followers_url":"https://api.github.com/users/philliphoff/followers","following_url":"https://api.github.com/users/philliphoff/following{/other_user}","gists_url":"https://api.github.com/users/philliphoff/gists{/gist_id}","starred_url":"https://api.github.com/users/philliphoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philliphoff/subscriptions","organizations_url":"https://api.github.com/users/philliphoff/orgs","repos_url":"https://api.github.com/users/philliphoff/repos","events_url":"https://api.github.com/users/philliphoff/events{/privacy}","received_events_url":"https://api.github.com/users/philliphoff/received_events","type":"User","site_admin":false},"body":"Once you register an actor type, you can't *unregister* it, so using a common `ActorRuntime` instance means that tests cannot run in complete isolation; they'll always be a risk that a previous test impacts the result of a following one. (It also tends to prevent tests from being able to run in parallel.)","created_at":"2019-11-21T19:01:47Z","updated_at":"2019-11-21T19:01:48Z","html_url":"https://github.com/dapr/dotnet-sdk/pull/165#discussion_r349263819","pull_request_url":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/165","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/comments/349263819"},"html":{"href":"https://github.com/dapr/dotnet-sdk/pull/165#discussion_r349263819"},"pull_request":{"href":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/165"}},"in_reply_to_id":348883990},"pull_request":{"url":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/165","id":343728078,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzNzI4MDc4","html_url":"https://github.com/dapr/dotnet-sdk/pull/165","diff_url":"https://github.com/dapr/dotnet-sdk/pull/165.diff","patch_url":"https://github.com/dapr/dotnet-sdk/pull/165.patch","issue_url":"https://api.github.com/repos/dapr/dotnet-sdk/issues/165","number":165,"state":"open","locked":false,"title":"Allow explicit actor type","user":{"login":"philliphoff","id":6402946,"node_id":"MDQ6VXNlcjY0MDI5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6402946?v=4","gravatar_id":"","url":"https://api.github.com/users/philliphoff","html_url":"https://github.com/philliphoff","followers_url":"https://api.github.com/users/philliphoff/followers","following_url":"https://api.github.com/users/philliphoff/following{/other_user}","gists_url":"https://api.github.com/users/philliphoff/gists{/gist_id}","starred_url":"https://api.github.com/users/philliphoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philliphoff/subscriptions","organizations_url":"https://api.github.com/users/philliphoff/orgs","repos_url":"https://api.github.com/users/philliphoff/repos","events_url":"https://api.github.com/users/philliphoff/events{/privacy}","received_events_url":"https://api.github.com/users/philliphoff/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nAllows developers to make the actor type name of an actor implementation explicit (i.e. not derived from the actor implementation class name).\r\n\r\nChanges include:\r\n\r\n - Adds an optional `ActorAttribute` attribute that can be attached to actor implementation types (e.g. those derived from `Actor`)\r\n - The attribute provides a property `TypeName` that can be used to explicitly set the actor type name\r\n - Adds an `ActorTypeName` property to `ActorTypeInformation`\r\n - This property is set to either `ActorAttribute.TypeName` if attached/set or the implementation type name\r\n - Updates all uses of the actor type's name to use `ActorTypeInformation.ActorTypeName`\r\n - Some refactoring of `ActorRuntime` to allow for isolated unit testing\r\n - Adds unit tests for `ActorTypeInformation` and `ActorRuntime` related features\r\n\r\nNote that the original proposal was a simple `RegisterActor()` overload that accepted the explicit type name. However, as the implementation started, the type name ended up becoming something more than just a simple registration key and more of an intrinsic property of the actor implementation (and used by components with only access to the actor, not the registration). Hence, `ActorAttribute` was created to allow overrides, like the type name, to be attached to the implementation in an optional, non-intrusive way, and then surfaced through `ActorTypeInformation`.\r\n\r\n## Issue reference\r\n\r\nResolves #164.\r\n\r\n## Checklist\r\n\r\nPlease make sure you've completed the relevant tasks for this PR, out of the following list:\r\n\r\n* [x] Code compiles correctly\r\n* [x] Created/updated tests\r\n* [x] Extended the documentation\r\n","created_at":"2019-11-20T21:19:18Z","updated_at":"2019-11-21T19:01:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ab3f83f6efe5a14b3494499a08d37f05d478685","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shalabhms","id":29718984,"node_id":"MDQ6VXNlcjI5NzE4OTg0","avatar_url":"https://avatars3.githubusercontent.com/u/29718984?v=4","gravatar_id":"","url":"https://api.github.com/users/shalabhms","html_url":"https://github.com/shalabhms","followers_url":"https://api.github.com/users/shalabhms/followers","following_url":"https://api.github.com/users/shalabhms/following{/other_user}","gists_url":"https://api.github.com/users/shalabhms/gists{/gist_id}","starred_url":"https://api.github.com/users/shalabhms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shalabhms/subscriptions","organizations_url":"https://api.github.com/users/shalabhms/orgs","repos_url":"https://api.github.com/users/shalabhms/repos","events_url":"https://api.github.com/users/shalabhms/events{/privacy}","received_events_url":"https://api.github.com/users/shalabhms/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/165/commits","review_comments_url":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/165/comments","review_comment_url":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dapr/dotnet-sdk/issues/165/comments","statuses_url":"https://api.github.com/repos/dapr/dotnet-sdk/statuses/0eba2197523429074e731017327c5abaa3304502","head":{"label":"philliphoff:philliphoff-actor-type","ref":"philliphoff-actor-type","sha":"0eba2197523429074e731017327c5abaa3304502","user":{"login":"philliphoff","id":6402946,"node_id":"MDQ6VXNlcjY0MDI5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6402946?v=4","gravatar_id":"","url":"https://api.github.com/users/philliphoff","html_url":"https://github.com/philliphoff","followers_url":"https://api.github.com/users/philliphoff/followers","following_url":"https://api.github.com/users/philliphoff/following{/other_user}","gists_url":"https://api.github.com/users/philliphoff/gists{/gist_id}","starred_url":"https://api.github.com/users/philliphoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philliphoff/subscriptions","organizations_url":"https://api.github.com/users/philliphoff/orgs","repos_url":"https://api.github.com/users/philliphoff/repos","events_url":"https://api.github.com/users/philliphoff/events{/privacy}","received_events_url":"https://api.github.com/users/philliphoff/received_events","type":"User","site_admin":false},"repo":{"id":218402054,"node_id":"MDEwOlJlcG9zaXRvcnkyMTg0MDIwNTQ=","name":"dotnet-sdk","full_name":"philliphoff/dotnet-sdk","private":false,"owner":{"login":"philliphoff","id":6402946,"node_id":"MDQ6VXNlcjY0MDI5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6402946?v=4","gravatar_id":"","url":"https://api.github.com/users/philliphoff","html_url":"https://github.com/philliphoff","followers_url":"https://api.github.com/users/philliphoff/followers","following_url":"https://api.github.com/users/philliphoff/following{/other_user}","gists_url":"https://api.github.com/users/philliphoff/gists{/gist_id}","starred_url":"https://api.github.com/users/philliphoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philliphoff/subscriptions","organizations_url":"https://api.github.com/users/philliphoff/orgs","repos_url":"https://api.github.com/users/philliphoff/repos","events_url":"https://api.github.com/users/philliphoff/events{/privacy}","received_events_url":"https://api.github.com/users/philliphoff/received_events","type":"User","site_admin":false},"html_url":"https://github.com/philliphoff/dotnet-sdk","description":"Dapr SDK for .Net","fork":true,"url":"https://api.github.com/repos/philliphoff/dotnet-sdk","forks_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/forks","keys_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/teams","hooks_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/hooks","issue_events_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/events","assignees_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/tags","blobs_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/languages","stargazers_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/stargazers","contributors_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/contributors","subscribers_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/subscribers","subscription_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/subscription","commits_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/merges","archive_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/downloads","issues_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/labels{/name}","releases_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/philliphoff/dotnet-sdk/deployments","created_at":"2019-10-29T23:22:59Z","updated_at":"2019-10-29T23:23:00Z","pushed_at":"2019-11-21T17:58:58Z","git_url":"git://github.com/philliphoff/dotnet-sdk.git","ssh_url":"[email protected]:philliphoff/dotnet-sdk.git","clone_url":"https://github.com/philliphoff/dotnet-sdk.git","svn_url":"https://github.com/philliphoff/dotnet-sdk","homepage":"","size":548,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dapr:master","ref":"master","sha":"8af6fb038e543907910b767ed25a5e36e09f70c3","user":{"login":"dapr","id":51932459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTMyNDU5","avatar_url":"https://avatars3.githubusercontent.com/u/51932459?v=4","gravatar_id":"","url":"https://api.github.com/users/dapr","html_url":"https://github.com/dapr","followers_url":"https://api.github.com/users/dapr/followers","following_url":"https://api.github.com/users/dapr/following{/other_user}","gists_url":"https://api.github.com/users/dapr/gists{/gist_id}","starred_url":"https://api.github.com/users/dapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dapr/subscriptions","organizations_url":"https://api.github.com/users/dapr/orgs","repos_url":"https://api.github.com/users/dapr/repos","events_url":"https://api.github.com/users/dapr/events{/privacy}","received_events_url":"https://api.github.com/users/dapr/received_events","type":"Organization","site_admin":false},"repo":{"id":193124882,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMxMjQ4ODI=","name":"dotnet-sdk","full_name":"dapr/dotnet-sdk","private":false,"owner":{"login":"dapr","id":51932459,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTMyNDU5","avatar_url":"https://avatars3.githubusercontent.com/u/51932459?v=4","gravatar_id":"","url":"https://api.github.com/users/dapr","html_url":"https://github.com/dapr","followers_url":"https://api.github.com/users/dapr/followers","following_url":"https://api.github.com/users/dapr/following{/other_user}","gists_url":"https://api.github.com/users/dapr/gists{/gist_id}","starred_url":"https://api.github.com/users/dapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dapr/subscriptions","organizations_url":"https://api.github.com/users/dapr/orgs","repos_url":"https://api.github.com/users/dapr/repos","events_url":"https://api.github.com/users/dapr/events{/privacy}","received_events_url":"https://api.github.com/users/dapr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dapr/dotnet-sdk","description":"Dapr SDK for .Net","fork":false,"url":"https://api.github.com/repos/dapr/dotnet-sdk","forks_url":"https://api.github.com/repos/dapr/dotnet-sdk/forks","keys_url":"https://api.github.com/repos/dapr/dotnet-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dapr/dotnet-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dapr/dotnet-sdk/teams","hooks_url":"https://api.github.com/repos/dapr/dotnet-sdk/hooks","issue_events_url":"https://api.github.com/repos/dapr/dotnet-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/dapr/dotnet-sdk/events","assignees_url":"https://api.github.com/repos/dapr/dotnet-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/dapr/dotnet-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/dapr/dotnet-sdk/tags","blobs_url":"https://api.github.com/repos/dapr/dotnet-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dapr/dotnet-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dapr/dotnet-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dapr/dotnet-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dapr/dotnet-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/dapr/dotnet-sdk/languages","stargazers_url":"https://api.github.com/repos/dapr/dotnet-sdk/stargazers","contributors_url":"https://api.github.com/repos/dapr/dotnet-sdk/contributors","subscribers_url":"https://api.github.com/repos/dapr/dotnet-sdk/subscribers","subscription_url":"https://api.github.com/repos/dapr/dotnet-sdk/subscription","commits_url":"https://api.github.com/repos/dapr/dotnet-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dapr/dotnet-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dapr/dotnet-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dapr/dotnet-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dapr/dotnet-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/dapr/dotnet-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dapr/dotnet-sdk/merges","archive_url":"https://api.github.com/repos/dapr/dotnet-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dapr/dotnet-sdk/downloads","issues_url":"https://api.github.com/repos/dapr/dotnet-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/dapr/dotnet-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/dapr/dotnet-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/dapr/dotnet-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dapr/dotnet-sdk/labels{/name}","releases_url":"https://api.github.com/repos/dapr/dotnet-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/dapr/dotnet-sdk/deployments","created_at":"2019-06-21T15:52:55Z","updated_at":"2019-11-21T06:20:35Z","pushed_at":"2019-11-21T17:59:00Z","git_url":"git://github.com/dapr/dotnet-sdk.git","ssh_url":"[email protected]:dapr/dotnet-sdk.git","clone_url":"https://github.com/dapr/dotnet-sdk.git","svn_url":"https://github.com/dapr/dotnet-sdk","homepage":"","size":526,"stargazers_count":170,"watchers_count":170,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":24,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/165"},"html":{"href":"https://github.com/dapr/dotnet-sdk/pull/165"},"issue":{"href":"https://api.github.com/repos/dapr/dotnet-sdk/issues/165"},"comments":{"href":"https://api.github.com/repos/dapr/dotnet-sdk/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dapr/dotnet-sdk/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/dapr/dotnet-sdk/statuses/0eba2197523429074e731017327c5abaa3304502"}},"author_association":"NONE"}}
|
{
"id": 193124882,
"name": "dapr/dotnet-sdk",
"url": "https://api.github.com/repos/dapr/dotnet-sdk"
}
|
{
"id": 6402946,
"login": "philliphoff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6402946?",
"url": "https://api.github.com/users/philliphoff"
}
|
{
"id": 51932459,
"login": "dapr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51932459?",
"url": "https://api.github.com/orgs/dapr"
}
| 2019-11-21T19:01:47 |
10919439628
|
{"actor":{"display_login":"philliphoff"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/comments/347070673","pull_request_review_id":317946412,"id":347070673,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzA3MDY3Mw==","diff_hunk":"@@ -8,6 +8,11 @@\n \n Ambianic Client UI is an Offline-first Progressive Web App (PWA) to manage Ambianic Edge deployments.\n \n+\n+<img src=\"public/img/ambianic-pwa-badge.png\" width=\"600\">","path":"README.md","position":5,"original_position":5,"commit_id":"09b30173acf5a041836255e74b83068757140621","original_commit_id":"09b30173acf5a041836255e74b83068757140621","user":{"login":"accesslint[bot]","id":25971091,"node_id":"MDM6Qm90MjU5NzEwOTE=","avatar_url":"https://avatars1.githubusercontent.com/in/1502?v=4","gravatar_id":"","url":"https://api.github.com/users/accesslint%5Bbot%5D","html_url":"https://github.com/apps/accesslint","followers_url":"https://api.github.com/users/accesslint%5Bbot%5D/followers","following_url":"https://api.github.com/users/accesslint%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/accesslint%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/accesslint%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accesslint%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/accesslint%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/accesslint%5Bbot%5D/repos","events_url":"https://api.github.com/users/accesslint%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/accesslint%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"This image is missing a text alternative (`alt` attribute). This is a problem for people using screen readers.","created_at":"2019-11-16T02:10:11Z","updated_at":"2019-11-16T02:10:11Z","html_url":"https://github.com/ambianic/ambianic-ui/pull/103#discussion_r347070673","pull_request_url":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/103","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/comments/347070673"},"html":{"href":"https://github.com/ambianic/ambianic-ui/pull/103#discussion_r347070673"},"pull_request":{"href":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/103","id":341711176,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxNzExMTc2","html_url":"https://github.com/ambianic/ambianic-ui/pull/103","diff_url":"https://github.com/ambianic/ambianic-ui/pull/103.diff","patch_url":"https://github.com/ambianic/ambianic-ui/pull/103.patch","issue_url":"https://api.github.com/repos/ambianic/ambianic-ui/issues/103","number":103,"state":"open","locked":false,"title":"docs: added pwa badge to README.md","user":{"login":"ivelin","id":2234901,"node_id":"MDQ6VXNlcjIyMzQ5MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/2234901?v=4","gravatar_id":"","url":"https://api.github.com/users/ivelin","html_url":"https://github.com/ivelin","followers_url":"https://api.github.com/users/ivelin/followers","following_url":"https://api.github.com/users/ivelin/following{/other_user}","gists_url":"https://api.github.com/users/ivelin/gists{/gist_id}","starred_url":"https://api.github.com/users/ivelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivelin/subscriptions","organizations_url":"https://api.github.com/users/ivelin/orgs","repos_url":"https://api.github.com/users/ivelin/repos","events_url":"https://api.github.com/users/ivelin/events{/privacy}","received_events_url":"https://api.github.com/users/ivelin/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-16T02:10:06Z","updated_at":"2019-11-16T02:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"491a19df4e2c0f5cbcc07e4f54462e9788cf7bfa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/103/commits","review_comments_url":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/103/comments","review_comment_url":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ambianic/ambianic-ui/issues/103/comments","statuses_url":"https://api.github.com/repos/ambianic/ambianic-ui/statuses/09b30173acf5a041836255e74b83068757140621","head":{"label":"ambianic:dev","ref":"dev","sha":"09b30173acf5a041836255e74b83068757140621","user":{"login":"ambianic","id":52052162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDUyMTYy","avatar_url":"https://avatars2.githubusercontent.com/u/52052162?v=4","gravatar_id":"","url":"https://api.github.com/users/ambianic","html_url":"https://github.com/ambianic","followers_url":"https://api.github.com/users/ambianic/followers","following_url":"https://api.github.com/users/ambianic/following{/other_user}","gists_url":"https://api.github.com/users/ambianic/gists{/gist_id}","starred_url":"https://api.github.com/users/ambianic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambianic/subscriptions","organizations_url":"https://api.github.com/users/ambianic/orgs","repos_url":"https://api.github.com/users/ambianic/repos","events_url":"https://api.github.com/users/ambianic/events{/privacy}","received_events_url":"https://api.github.com/users/ambianic/received_events","type":"Organization","site_admin":false},"repo":{"id":215932353,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU5MzIzNTM=","name":"ambianic-ui","full_name":"ambianic/ambianic-ui","private":false,"owner":{"login":"ambianic","id":52052162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDUyMTYy","avatar_url":"https://avatars2.githubusercontent.com/u/52052162?v=4","gravatar_id":"","url":"https://api.github.com/users/ambianic","html_url":"https://github.com/ambianic","followers_url":"https://api.github.com/users/ambianic/followers","following_url":"https://api.github.com/users/ambianic/following{/other_user}","gists_url":"https://api.github.com/users/ambianic/gists{/gist_id}","starred_url":"https://api.github.com/users/ambianic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambianic/subscriptions","organizations_url":"https://api.github.com/users/ambianic/orgs","repos_url":"https://api.github.com/users/ambianic/repos","events_url":"https://api.github.com/users/ambianic/events{/privacy}","received_events_url":"https://api.github.com/users/ambianic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ambianic/ambianic-ui","description":"Ambianic Client UI. An Offline-first Progressive Web App (PWA) to manage Ambianic Edge deployments.","fork":false,"url":"https://api.github.com/repos/ambianic/ambianic-ui","forks_url":"https://api.github.com/repos/ambianic/ambianic-ui/forks","keys_url":"https://api.github.com/repos/ambianic/ambianic-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ambianic/ambianic-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ambianic/ambianic-ui/teams","hooks_url":"https://api.github.com/repos/ambianic/ambianic-ui/hooks","issue_events_url":"https://api.github.com/repos/ambianic/ambianic-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ambianic/ambianic-ui/events","assignees_url":"https://api.github.com/repos/ambianic/ambianic-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ambianic/ambianic-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ambianic/ambianic-ui/tags","blobs_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ambianic/ambianic-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ambianic/ambianic-ui/languages","stargazers_url":"https://api.github.com/repos/ambianic/ambianic-ui/stargazers","contributors_url":"https://api.github.com/repos/ambianic/ambianic-ui/contributors","subscribers_url":"https://api.github.com/repos/ambianic/ambianic-ui/subscribers","subscription_url":"https://api.github.com/repos/ambianic/ambianic-ui/subscription","commits_url":"https://api.github.com/repos/ambianic/ambianic-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ambianic/ambianic-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ambianic/ambianic-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ambianic/ambianic-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ambianic/ambianic-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ambianic/ambianic-ui/merges","archive_url":"https://api.github.com/repos/ambianic/ambianic-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ambianic/ambianic-ui/downloads","issues_url":"https://api.github.com/repos/ambianic/ambianic-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ambianic/ambianic-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ambianic/ambianic-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ambianic/ambianic-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ambianic/ambianic-ui/labels{/name}","releases_url":"https://api.github.com/repos/ambianic/ambianic-ui/releases{/id}","deployments_url":"https://api.github.com/repos/ambianic/ambianic-ui/deployments","created_at":"2019-10-18T03:16:27Z","updated_at":"2019-11-16T01:30:23Z","pushed_at":"2019-11-16T02:10:06Z","git_url":"git://github.com/ambianic/ambianic-ui.git","ssh_url":"[email protected]:ambianic/ambianic-ui.git","clone_url":"https://github.com/ambianic/ambianic-ui.git","svn_url":"https://github.com/ambianic/ambianic-ui","homepage":"","size":10294,"stargazers_count":1,"watchers_count":1,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"ambianic:master","ref":"master","sha":"fb97e3c0c17ec41af12519be8d58ffa73c783252","user":{"login":"ambianic","id":52052162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDUyMTYy","avatar_url":"https://avatars2.githubusercontent.com/u/52052162?v=4","gravatar_id":"","url":"https://api.github.com/users/ambianic","html_url":"https://github.com/ambianic","followers_url":"https://api.github.com/users/ambianic/followers","following_url":"https://api.github.com/users/ambianic/following{/other_user}","gists_url":"https://api.github.com/users/ambianic/gists{/gist_id}","starred_url":"https://api.github.com/users/ambianic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambianic/subscriptions","organizations_url":"https://api.github.com/users/ambianic/orgs","repos_url":"https://api.github.com/users/ambianic/repos","events_url":"https://api.github.com/users/ambianic/events{/privacy}","received_events_url":"https://api.github.com/users/ambianic/received_events","type":"Organization","site_admin":false},"repo":{"id":215932353,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU5MzIzNTM=","name":"ambianic-ui","full_name":"ambianic/ambianic-ui","private":false,"owner":{"login":"ambianic","id":52052162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMDUyMTYy","avatar_url":"https://avatars2.githubusercontent.com/u/52052162?v=4","gravatar_id":"","url":"https://api.github.com/users/ambianic","html_url":"https://github.com/ambianic","followers_url":"https://api.github.com/users/ambianic/followers","following_url":"https://api.github.com/users/ambianic/following{/other_user}","gists_url":"https://api.github.com/users/ambianic/gists{/gist_id}","starred_url":"https://api.github.com/users/ambianic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambianic/subscriptions","organizations_url":"https://api.github.com/users/ambianic/orgs","repos_url":"https://api.github.com/users/ambianic/repos","events_url":"https://api.github.com/users/ambianic/events{/privacy}","received_events_url":"https://api.github.com/users/ambianic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ambianic/ambianic-ui","description":"Ambianic Client UI. An Offline-first Progressive Web App (PWA) to manage Ambianic Edge deployments.","fork":false,"url":"https://api.github.com/repos/ambianic/ambianic-ui","forks_url":"https://api.github.com/repos/ambianic/ambianic-ui/forks","keys_url":"https://api.github.com/repos/ambianic/ambianic-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ambianic/ambianic-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ambianic/ambianic-ui/teams","hooks_url":"https://api.github.com/repos/ambianic/ambianic-ui/hooks","issue_events_url":"https://api.github.com/repos/ambianic/ambianic-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ambianic/ambianic-ui/events","assignees_url":"https://api.github.com/repos/ambianic/ambianic-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ambianic/ambianic-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ambianic/ambianic-ui/tags","blobs_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ambianic/ambianic-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ambianic/ambianic-ui/languages","stargazers_url":"https://api.github.com/repos/ambianic/ambianic-ui/stargazers","contributors_url":"https://api.github.com/repos/ambianic/ambianic-ui/contributors","subscribers_url":"https://api.github.com/repos/ambianic/ambianic-ui/subscribers","subscription_url":"https://api.github.com/repos/ambianic/ambianic-ui/subscription","commits_url":"https://api.github.com/repos/ambianic/ambianic-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ambianic/ambianic-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ambianic/ambianic-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ambianic/ambianic-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ambianic/ambianic-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ambianic/ambianic-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ambianic/ambianic-ui/merges","archive_url":"https://api.github.com/repos/ambianic/ambianic-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ambianic/ambianic-ui/downloads","issues_url":"https://api.github.com/repos/ambianic/ambianic-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ambianic/ambianic-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ambianic/ambianic-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ambianic/ambianic-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ambianic/ambianic-ui/labels{/name}","releases_url":"https://api.github.com/repos/ambianic/ambianic-ui/releases{/id}","deployments_url":"https://api.github.com/repos/ambianic/ambianic-ui/deployments","created_at":"2019-10-18T03:16:27Z","updated_at":"2019-11-16T01:30:23Z","pushed_at":"2019-11-16T02:10:06Z","git_url":"git://github.com/ambianic/ambianic-ui.git","ssh_url":"[email protected]:ambianic/ambianic-ui.git","clone_url":"https://github.com/ambianic/ambianic-ui.git","svn_url":"https://github.com/ambianic/ambianic-ui","homepage":"","size":10294,"stargazers_count":1,"watchers_count":1,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/103"},"html":{"href":"https://github.com/ambianic/ambianic-ui/pull/103"},"issue":{"href":"https://api.github.com/repos/ambianic/ambianic-ui/issues/103"},"comments":{"href":"https://api.github.com/repos/ambianic/ambianic-ui/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ambianic/ambianic-ui/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/ambianic/ambianic-ui/statuses/09b30173acf5a041836255e74b83068757140621"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 215932353,
"name": "ambianic/ambianic-ui",
"url": "https://api.github.com/repos/ambianic/ambianic-ui"
}
|
{
"id": 25971091,
"login": "accesslint[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25971091?",
"url": "https://api.github.com/users/accesslint[bot]"
}
|
{
"id": 52052162,
"login": "ambianic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/52052162?",
"url": "https://api.github.com/orgs/ambianic"
}
| 2019-11-16T02:10:11 |
10876537722
|
{"actor":{"display_login":"accesslint"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/unoplatform/uno/pulls/comments/350218994","pull_request_review_id":322322011,"id":350218994,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MDIxODk5NA==","diff_hunk":"@@ -269,6 +269,8 @@ protected Size MeasureChild(View view, Size slotSize)\n \t\t\tvar frameworkElement = view as IFrameworkElement;\n \t\t\tvar ret = default(Size);\n \n+\t\t\t// NaN values are accepted as input for MeasureOverride, but are treated as Infinity.\n+\t\t\tslotSize = slotSize.NumberOrDefault(MaxSize);","path":"src/Uno.UI/UI/Xaml/Controls/Layouter/Layouter.cs","position":5,"original_position":5,"commit_id":"91fbc67c9389e87e9fc5b1f3f733fcccd6c5db49","original_commit_id":"7915d2570e506a1cbda02715e0f216363b58716c","user":{"login":"jeromelaban","id":5839577,"node_id":"MDQ6VXNlcjU4Mzk1Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5839577?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromelaban","html_url":"https://github.com/jeromelaban","followers_url":"https://api.github.com/users/jeromelaban/followers","following_url":"https://api.github.com/users/jeromelaban/following{/other_user}","gists_url":"https://api.github.com/users/jeromelaban/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromelaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromelaban/subscriptions","organizations_url":"https://api.github.com/users/jeromelaban/orgs","repos_url":"https://api.github.com/users/jeromelaban/repos","events_url":"https://api.github.com/users/jeromelaban/events{/privacy}","received_events_url":"https://api.github.com/users/jeromelaban/received_events","type":"User","site_admin":false},"body":"It was, in #2098","created_at":"2019-11-25T14:35:44Z","updated_at":"2019-11-25T14:35:44Z","html_url":"https://github.com/unoplatform/uno/pull/2175#discussion_r350218994","pull_request_url":"https://api.github.com/repos/unoplatform/uno/pulls/2175","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/unoplatform/uno/pulls/comments/350218994"},"html":{"href":"https://github.com/unoplatform/uno/pull/2175#discussion_r350218994"},"pull_request":{"href":"https://api.github.com/repos/unoplatform/uno/pulls/2175"}},"in_reply_to_id":350204949},"pull_request":{"url":"https://api.github.com/repos/unoplatform/uno/pulls/2175","id":344989035,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0OTg5MDM1","html_url":"https://github.com/unoplatform/uno/pull/2175","diff_url":"https://github.com/unoplatform/uno/pull/2175.diff","patch_url":"https://github.com/unoplatform/uno/pull/2175.patch","issue_url":"https://api.github.com/repos/unoplatform/uno/issues/2175","number":2175,"state":"open","locked":false,"title":"[Android] Fix MeasureOverride taking NaN;Nan is input failure","user":{"login":"jeromelaban","id":5839577,"node_id":"MDQ6VXNlcjU4Mzk1Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5839577?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromelaban","html_url":"https://github.com/jeromelaban","followers_url":"https://api.github.com/users/jeromelaban/followers","following_url":"https://api.github.com/users/jeromelaban/following{/other_user}","gists_url":"https://api.github.com/users/jeromelaban/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromelaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromelaban/subscriptions","organizations_url":"https://api.github.com/users/jeromelaban/orgs","repos_url":"https://api.github.com/users/jeromelaban/repos","events_url":"https://api.github.com/users/jeromelaban/events{/privacy}","received_events_url":"https://api.github.com/users/jeromelaban/received_events","type":"User","site_admin":false},"body":"GitHub Issue (If applicable): unoplatform/private#93\r\n\r\n## PR Type\r\n\r\nWhat kind of change does this PR introduce?\r\n- Bugfix\r\n\r\n## What is the new behavior?\r\n\r\nRestores the ability for a FrameworkElement to measure its children using `[NaN;NaN]` on Android.\r\n\r\n## PR Checklist\r\n\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] Tested code with current [supported SDKs](https://github.com/unoplatform/uno/blob/master/README.md#uno-features)\r\n- [ ] Docs have been added/updated which fit [documentation template](https://github.com/unoplatform/uno/blob/master/doc/.feature-template.md) (for bug fixes / features)\r\n- [x] [Unit Tests and/or UI Tests](https://github.com/unoplatform/uno/blob/master/doc/articles/uno-development/working-with-the-samples-apps.md) for the changes have been added (for bug fixes / features) (if applicable)\r\n- [ ] [Wasm UI Tests](https://github.com/unoplatform/uno/blob/master/doc/articles/uno-development/working-with-the-samples-apps.md#running-the-webassembly-ui-tests-snapshots) are not showing unexpected any differences. Validate PR `Screenshots Compare Test Run` results.\r\n- [x] Contains **NO** breaking changes\r\n- [ ] ~~Updated the [Release Notes](https://github.com/unoplatform/uno/tree/master/doc/ReleaseNotes)~~\r\n- [x] Associated with an issue (GitHub or internal)\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below.\r\n Please note that breaking changes are likely to be rejected -->\r\n\r\n\r\n## Other information\r\n\r\n<!-- Please provide any additional information if necessary -->\r\n\r\nInternal Issue (If applicable):\r\n<!-- Link to relevant internal issue if applicable. All PRs should be associated with an issue (GitHub issue or internal) -->\r\n","created_at":"2019-11-25T02:46:07Z","updated_at":"2019-11-25T14:35:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6516239165a5f63a361390933e23cba5b09a90fb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dr1rrb","id":8635919,"node_id":"MDQ6VXNlcjg2MzU5MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/8635919?v=4","gravatar_id":"","url":"https://api.github.com/users/dr1rrb","html_url":"https://github.com/dr1rrb","followers_url":"https://api.github.com/users/dr1rrb/followers","following_url":"https://api.github.com/users/dr1rrb/following{/other_user}","gists_url":"https://api.github.com/users/dr1rrb/gists{/gist_id}","starred_url":"https://api.github.com/users/dr1rrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr1rrb/subscriptions","organizations_url":"https://api.github.com/users/dr1rrb/orgs","repos_url":"https://api.github.com/users/dr1rrb/repos","events_url":"https://api.github.com/users/dr1rrb/events{/privacy}","received_events_url":"https://api.github.com/users/dr1rrb/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1412857414,"node_id":"MDU6TGFiZWwxNDEyODU3NDE0","url":"https://api.github.com/repos/unoplatform/uno/labels/ready-to-merge","name":"ready-to-merge","color":"27AE60","default":false,"description":"Automatically merge the PR once all '.mergify.yml' policies are met"}],"milestone":null,"commits_url":"https://api.github.com/repos/unoplatform/uno/pulls/2175/commits","review_comments_url":"https://api.github.com/repos/unoplatform/uno/pulls/2175/comments","review_comment_url":"https://api.github.com/repos/unoplatform/uno/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unoplatform/uno/issues/2175/comments","statuses_url":"https://api.github.com/repos/unoplatform/uno/statuses/91fbc67c9389e87e9fc5b1f3f733fcccd6c5db49","head":{"label":"unoplatform:dev/jela/nan-nested-override","ref":"dev/jela/nan-nested-override","sha":"91fbc67c9389e87e9fc5b1f3f733fcccd6c5db49","user":{"login":"unoplatform","id":52228309,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjI4MzA5","avatar_url":"https://avatars3.githubusercontent.com/u/52228309?v=4","gravatar_id":"","url":"https://api.github.com/users/unoplatform","html_url":"https://github.com/unoplatform","followers_url":"https://api.github.com/users/unoplatform/followers","following_url":"https://api.github.com/users/unoplatform/following{/other_user}","gists_url":"https://api.github.com/users/unoplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/unoplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unoplatform/subscriptions","organizations_url":"https://api.github.com/users/unoplatform/orgs","repos_url":"https://api.github.com/users/unoplatform/repos","events_url":"https://api.github.com/users/unoplatform/events{/privacy}","received_events_url":"https://api.github.com/users/unoplatform/received_events","type":"Organization","site_admin":false},"repo":{"id":132453438,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0NTM0Mzg=","name":"uno","full_name":"unoplatform/uno","private":false,"owner":{"login":"unoplatform","id":52228309,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjI4MzA5","avatar_url":"https://avatars3.githubusercontent.com/u/52228309?v=4","gravatar_id":"","url":"https://api.github.com/users/unoplatform","html_url":"https://github.com/unoplatform","followers_url":"https://api.github.com/users/unoplatform/followers","following_url":"https://api.github.com/users/unoplatform/following{/other_user}","gists_url":"https://api.github.com/users/unoplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/unoplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unoplatform/subscriptions","organizations_url":"https://api.github.com/users/unoplatform/orgs","repos_url":"https://api.github.com/users/unoplatform/repos","events_url":"https://api.github.com/users/unoplatform/events{/privacy}","received_events_url":"https://api.github.com/users/unoplatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unoplatform/uno","description":"Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.","fork":false,"url":"https://api.github.com/repos/unoplatform/uno","forks_url":"https://api.github.com/repos/unoplatform/uno/forks","keys_url":"https://api.github.com/repos/unoplatform/uno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unoplatform/uno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unoplatform/uno/teams","hooks_url":"https://api.github.com/repos/unoplatform/uno/hooks","issue_events_url":"https://api.github.com/repos/unoplatform/uno/issues/events{/number}","events_url":"https://api.github.com/repos/unoplatform/uno/events","assignees_url":"https://api.github.com/repos/unoplatform/uno/assignees{/user}","branches_url":"https://api.github.com/repos/unoplatform/uno/branches{/branch}","tags_url":"https://api.github.com/repos/unoplatform/uno/tags","blobs_url":"https://api.github.com/repos/unoplatform/uno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unoplatform/uno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unoplatform/uno/git/refs{/sha}","trees_url":"https://api.github.com/repos/unoplatform/uno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unoplatform/uno/statuses/{sha}","languages_url":"https://api.github.com/repos/unoplatform/uno/languages","stargazers_url":"https://api.github.com/repos/unoplatform/uno/stargazers","contributors_url":"https://api.github.com/repos/unoplatform/uno/contributors","subscribers_url":"https://api.github.com/repos/unoplatform/uno/subscribers","subscription_url":"https://api.github.com/repos/unoplatform/uno/subscription","commits_url":"https://api.github.com/repos/unoplatform/uno/commits{/sha}","git_commits_url":"https://api.github.com/repos/unoplatform/uno/git/commits{/sha}","comments_url":"https://api.github.com/repos/unoplatform/uno/comments{/number}","issue_comment_url":"https://api.github.com/repos/unoplatform/uno/issues/comments{/number}","contents_url":"https://api.github.com/repos/unoplatform/uno/contents/{+path}","compare_url":"https://api.github.com/repos/unoplatform/uno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unoplatform/uno/merges","archive_url":"https://api.github.com/repos/unoplatform/uno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unoplatform/uno/downloads","issues_url":"https://api.github.com/repos/unoplatform/uno/issues{/number}","pulls_url":"https://api.github.com/repos/unoplatform/uno/pulls{/number}","milestones_url":"https://api.github.com/repos/unoplatform/uno/milestones{/number}","notifications_url":"https://api.github.com/repos/unoplatform/uno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unoplatform/uno/labels{/name}","releases_url":"https://api.github.com/repos/unoplatform/uno/releases{/id}","deployments_url":"https://api.github.com/repos/unoplatform/uno/deployments","created_at":"2018-05-07T11:52:27Z","updated_at":"2019-11-25T12:50:39Z","pushed_at":"2019-11-25T14:13:17Z","git_url":"git://github.com/unoplatform/uno.git","ssh_url":"[email protected]:unoplatform/uno.git","clone_url":"https://github.com/unoplatform/uno.git","svn_url":"https://github.com/unoplatform/uno","homepage":"https://platform.uno/","size":47335,"stargazers_count":1678,"watchers_count":1678,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":472,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":252,"open_issues":472,"watchers":1678,"default_branch":"master"}},"base":{"label":"unoplatform:master","ref":"master","sha":"a9aab239a74848c09bfb57a9c51131ca68243f24","user":{"login":"unoplatform","id":52228309,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjI4MzA5","avatar_url":"https://avatars3.githubusercontent.com/u/52228309?v=4","gravatar_id":"","url":"https://api.github.com/users/unoplatform","html_url":"https://github.com/unoplatform","followers_url":"https://api.github.com/users/unoplatform/followers","following_url":"https://api.github.com/users/unoplatform/following{/other_user}","gists_url":"https://api.github.com/users/unoplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/unoplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unoplatform/subscriptions","organizations_url":"https://api.github.com/users/unoplatform/orgs","repos_url":"https://api.github.com/users/unoplatform/repos","events_url":"https://api.github.com/users/unoplatform/events{/privacy}","received_events_url":"https://api.github.com/users/unoplatform/received_events","type":"Organization","site_admin":false},"repo":{"id":132453438,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0NTM0Mzg=","name":"uno","full_name":"unoplatform/uno","private":false,"owner":{"login":"unoplatform","id":52228309,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMjI4MzA5","avatar_url":"https://avatars3.githubusercontent.com/u/52228309?v=4","gravatar_id":"","url":"https://api.github.com/users/unoplatform","html_url":"https://github.com/unoplatform","followers_url":"https://api.github.com/users/unoplatform/followers","following_url":"https://api.github.com/users/unoplatform/following{/other_user}","gists_url":"https://api.github.com/users/unoplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/unoplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unoplatform/subscriptions","organizations_url":"https://api.github.com/users/unoplatform/orgs","repos_url":"https://api.github.com/users/unoplatform/repos","events_url":"https://api.github.com/users/unoplatform/events{/privacy}","received_events_url":"https://api.github.com/users/unoplatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unoplatform/uno","description":"Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.","fork":false,"url":"https://api.github.com/repos/unoplatform/uno","forks_url":"https://api.github.com/repos/unoplatform/uno/forks","keys_url":"https://api.github.com/repos/unoplatform/uno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unoplatform/uno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unoplatform/uno/teams","hooks_url":"https://api.github.com/repos/unoplatform/uno/hooks","issue_events_url":"https://api.github.com/repos/unoplatform/uno/issues/events{/number}","events_url":"https://api.github.com/repos/unoplatform/uno/events","assignees_url":"https://api.github.com/repos/unoplatform/uno/assignees{/user}","branches_url":"https://api.github.com/repos/unoplatform/uno/branches{/branch}","tags_url":"https://api.github.com/repos/unoplatform/uno/tags","blobs_url":"https://api.github.com/repos/unoplatform/uno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unoplatform/uno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unoplatform/uno/git/refs{/sha}","trees_url":"https://api.github.com/repos/unoplatform/uno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unoplatform/uno/statuses/{sha}","languages_url":"https://api.github.com/repos/unoplatform/uno/languages","stargazers_url":"https://api.github.com/repos/unoplatform/uno/stargazers","contributors_url":"https://api.github.com/repos/unoplatform/uno/contributors","subscribers_url":"https://api.github.com/repos/unoplatform/uno/subscribers","subscription_url":"https://api.github.com/repos/unoplatform/uno/subscription","commits_url":"https://api.github.com/repos/unoplatform/uno/commits{/sha}","git_commits_url":"https://api.github.com/repos/unoplatform/uno/git/commits{/sha}","comments_url":"https://api.github.com/repos/unoplatform/uno/comments{/number}","issue_comment_url":"https://api.github.com/repos/unoplatform/uno/issues/comments{/number}","contents_url":"https://api.github.com/repos/unoplatform/uno/contents/{+path}","compare_url":"https://api.github.com/repos/unoplatform/uno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unoplatform/uno/merges","archive_url":"https://api.github.com/repos/unoplatform/uno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unoplatform/uno/downloads","issues_url":"https://api.github.com/repos/unoplatform/uno/issues{/number}","pulls_url":"https://api.github.com/repos/unoplatform/uno/pulls{/number}","milestones_url":"https://api.github.com/repos/unoplatform/uno/milestones{/number}","notifications_url":"https://api.github.com/repos/unoplatform/uno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unoplatform/uno/labels{/name}","releases_url":"https://api.github.com/repos/unoplatform/uno/releases{/id}","deployments_url":"https://api.github.com/repos/unoplatform/uno/deployments","created_at":"2018-05-07T11:52:27Z","updated_at":"2019-11-25T12:50:39Z","pushed_at":"2019-11-25T14:13:17Z","git_url":"git://github.com/unoplatform/uno.git","ssh_url":"[email protected]:unoplatform/uno.git","clone_url":"https://github.com/unoplatform/uno.git","svn_url":"https://github.com/unoplatform/uno","homepage":"https://platform.uno/","size":47335,"stargazers_count":1678,"watchers_count":1678,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":472,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":252,"open_issues":472,"watchers":1678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unoplatform/uno/pulls/2175"},"html":{"href":"https://github.com/unoplatform/uno/pull/2175"},"issue":{"href":"https://api.github.com/repos/unoplatform/uno/issues/2175"},"comments":{"href":"https://api.github.com/repos/unoplatform/uno/issues/2175/comments"},"review_comments":{"href":"https://api.github.com/repos/unoplatform/uno/pulls/2175/comments"},"review_comment":{"href":"https://api.github.com/repos/unoplatform/uno/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unoplatform/uno/pulls/2175/commits"},"statuses":{"href":"https://api.github.com/repos/unoplatform/uno/statuses/91fbc67c9389e87e9fc5b1f3f733fcccd6c5db49"}},"author_association":"MEMBER"}}
|
{
"id": 132453438,
"name": "unoplatform/uno",
"url": "https://api.github.com/repos/unoplatform/uno"
}
|
{
"id": 5839577,
"login": "jeromelaban",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5839577?",
"url": "https://api.github.com/users/jeromelaban"
}
|
{
"id": 52228309,
"login": "unoplatform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/52228309?",
"url": "https://api.github.com/orgs/unoplatform"
}
| 2019-11-25T14:35:44 |
10941450279
|
{"actor":{"display_login":"jeromelaban"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/comments/315173350","pull_request_review_id":276510185,"id":315173350,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNTE3MzM1MA==","diff_hunk":"@@ -1,3 +1,8 @@\n+`1.2.3`\n+-------\n+\n+**Fix:** Paymentlines were not displayed on the ticket when an invoice is partially paid\n+","path":"pos_invoice_pay/doc/changelog.rst","position":5,"original_position":5,"commit_id":"97ed2eb2c63dbb824244c1b0adf326131e7edb5f","original_commit_id":"97ed2eb2c63dbb824244c1b0adf326131e7edb5f","user":{"login":"kaadevelop","id":50337672,"node_id":"MDQ6VXNlcjUwMzM3Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/50337672?v=4","gravatar_id":"","url":"https://api.github.com/users/kaadevelop","html_url":"https://github.com/kaadevelop","followers_url":"https://api.github.com/users/kaadevelop/followers","following_url":"https://api.github.com/users/kaadevelop/following{/other_user}","gists_url":"https://api.github.com/users/kaadevelop/gists{/gist_id}","starred_url":"https://api.github.com/users/kaadevelop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaadevelop/subscriptions","organizations_url":"https://api.github.com/users/kaadevelop/orgs","repos_url":"https://api.github.com/users/kaadevelop/repos","events_url":"https://api.github.com/users/kaadevelop/events{/privacy}","received_events_url":"https://api.github.com/users/kaadevelop/received_events","type":"User","site_admin":false},"body":"Someone has to test it","created_at":"2019-08-19T12:00:51Z","updated_at":"2019-08-19T12:00:51Z","html_url":"https://github.com/kaadevelopment/pos-addons/pull/17#discussion_r315173350","pull_request_url":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/17","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/comments/315173350"},"html":{"href":"https://github.com/kaadevelopment/pos-addons/pull/17#discussion_r315173350"},"pull_request":{"href":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/17","id":305090138,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1MDkwMTM4","html_url":"https://github.com/kaadevelopment/pos-addons/pull/17","diff_url":"https://github.com/kaadevelopment/pos-addons/pull/17.diff","patch_url":"https://github.com/kaadevelopment/pos-addons/pull/17.patch","issue_url":"https://api.github.com/repos/kaadevelopment/pos-addons/issues/17","number":17,"state":"open","locked":false,"title":"Review bot v1","user":{"login":"kaadevelop","id":50337672,"node_id":"MDQ6VXNlcjUwMzM3Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/50337672?v=4","gravatar_id":"","url":"https://api.github.com/users/kaadevelop","html_url":"https://github.com/kaadevelop","followers_url":"https://api.github.com/users/kaadevelop/followers","following_url":"https://api.github.com/users/kaadevelop/following{/other_user}","gists_url":"https://api.github.com/users/kaadevelop/gists{/gist_id}","starred_url":"https://api.github.com/users/kaadevelop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaadevelop/subscriptions","organizations_url":"https://api.github.com/users/kaadevelop/orgs","repos_url":"https://api.github.com/users/kaadevelop/repos","events_url":"https://api.github.com/users/kaadevelop/events{/privacy}","received_events_url":"https://api.github.com/users/kaadevelop/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-07T10:46:03Z","updated_at":"2019-08-19T12:00:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9811a6bffe690f58d2642d8b6fa3fd577c696680","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/17/commits","review_comments_url":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/17/comments","review_comment_url":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaadevelopment/pos-addons/issues/17/comments","statuses_url":"https://api.github.com/repos/kaadevelopment/pos-addons/statuses/97ed2eb2c63dbb824244c1b0adf326131e7edb5f","head":{"label":"kaadevelop:review-bot_v1","ref":"review-bot_v1","sha":"97ed2eb2c63dbb824244c1b0adf326131e7edb5f","user":{"login":"kaadevelop","id":50337672,"node_id":"MDQ6VXNlcjUwMzM3Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/50337672?v=4","gravatar_id":"","url":"https://api.github.com/users/kaadevelop","html_url":"https://github.com/kaadevelop","followers_url":"https://api.github.com/users/kaadevelop/followers","following_url":"https://api.github.com/users/kaadevelop/following{/other_user}","gists_url":"https://api.github.com/users/kaadevelop/gists{/gist_id}","starred_url":"https://api.github.com/users/kaadevelop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaadevelop/subscriptions","organizations_url":"https://api.github.com/users/kaadevelop/orgs","repos_url":"https://api.github.com/users/kaadevelop/repos","events_url":"https://api.github.com/users/kaadevelop/events{/privacy}","received_events_url":"https://api.github.com/users/kaadevelop/received_events","type":"User","site_admin":false},"repo":{"id":185247651,"node_id":"MDEwOlJlcG9zaXRvcnkxODUyNDc2NTE=","name":"pos-addons","full_name":"kaadevelop/pos-addons","private":false,"owner":{"login":"kaadevelop","id":50337672,"node_id":"MDQ6VXNlcjUwMzM3Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/50337672?v=4","gravatar_id":"","url":"https://api.github.com/users/kaadevelop","html_url":"https://github.com/kaadevelop","followers_url":"https://api.github.com/users/kaadevelop/followers","following_url":"https://api.github.com/users/kaadevelop/following{/other_user}","gists_url":"https://api.github.com/users/kaadevelop/gists{/gist_id}","starred_url":"https://api.github.com/users/kaadevelop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaadevelop/subscriptions","organizations_url":"https://api.github.com/users/kaadevelop/orgs","repos_url":"https://api.github.com/users/kaadevelop/repos","events_url":"https://api.github.com/users/kaadevelop/events{/privacy}","received_events_url":"https://api.github.com/users/kaadevelop/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kaadevelop/pos-addons","description":"Odoo POS addons ","fork":true,"url":"https://api.github.com/repos/kaadevelop/pos-addons","forks_url":"https://api.github.com/repos/kaadevelop/pos-addons/forks","keys_url":"https://api.github.com/repos/kaadevelop/pos-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaadevelop/pos-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaadevelop/pos-addons/teams","hooks_url":"https://api.github.com/repos/kaadevelop/pos-addons/hooks","issue_events_url":"https://api.github.com/repos/kaadevelop/pos-addons/issues/events{/number}","events_url":"https://api.github.com/repos/kaadevelop/pos-addons/events","assignees_url":"https://api.github.com/repos/kaadevelop/pos-addons/assignees{/user}","branches_url":"https://api.github.com/repos/kaadevelop/pos-addons/branches{/branch}","tags_url":"https://api.github.com/repos/kaadevelop/pos-addons/tags","blobs_url":"https://api.github.com/repos/kaadevelop/pos-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaadevelop/pos-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaadevelop/pos-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaadevelop/pos-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaadevelop/pos-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/kaadevelop/pos-addons/languages","stargazers_url":"https://api.github.com/repos/kaadevelop/pos-addons/stargazers","contributors_url":"https://api.github.com/repos/kaadevelop/pos-addons/contributors","subscribers_url":"https://api.github.com/repos/kaadevelop/pos-addons/subscribers","subscription_url":"https://api.github.com/repos/kaadevelop/pos-addons/subscription","commits_url":"https://api.github.com/repos/kaadevelop/pos-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaadevelop/pos-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaadevelop/pos-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaadevelop/pos-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaadevelop/pos-addons/contents/{+path}","compare_url":"https://api.github.com/repos/kaadevelop/pos-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaadevelop/pos-addons/merges","archive_url":"https://api.github.com/repos/kaadevelop/pos-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaadevelop/pos-addons/downloads","issues_url":"https://api.github.com/repos/kaadevelop/pos-addons/issues{/number}","pulls_url":"https://api.github.com/repos/kaadevelop/pos-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/kaadevelop/pos-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/kaadevelop/pos-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaadevelop/pos-addons/labels{/name}","releases_url":"https://api.github.com/repos/kaadevelop/pos-addons/releases{/id}","deployments_url":"https://api.github.com/repos/kaadevelop/pos-addons/deployments","created_at":"2019-05-06T18:10:04Z","updated_at":"2019-08-02T13:36:53Z","pushed_at":"2019-08-07T10:45:47Z","git_url":"git://github.com/kaadevelop/pos-addons.git","ssh_url":"[email protected]:kaadevelop/pos-addons.git","clone_url":"https://github.com/kaadevelop/pos-addons.git","svn_url":"https://github.com/kaadevelop/pos-addons","homepage":"https://www.it-projects.info/","size":49158,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"12.0"}},"base":{"label":"kaadevelopment:12.0","ref":"12.0","sha":"60eda5780e880463562373d118a447becb0a5ffd","user":{"login":"kaadevelopment","id":52448834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDQ4ODM0","avatar_url":"https://avatars3.githubusercontent.com/u/52448834?v=4","gravatar_id":"","url":"https://api.github.com/users/kaadevelopment","html_url":"https://github.com/kaadevelopment","followers_url":"https://api.github.com/users/kaadevelopment/followers","following_url":"https://api.github.com/users/kaadevelopment/following{/other_user}","gists_url":"https://api.github.com/users/kaadevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/kaadevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaadevelopment/subscriptions","organizations_url":"https://api.github.com/users/kaadevelopment/orgs","repos_url":"https://api.github.com/users/kaadevelopment/repos","events_url":"https://api.github.com/users/kaadevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/kaadevelopment/received_events","type":"Organization","site_admin":false},"repo":{"id":194831542,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ4MzE1NDI=","name":"pos-addons","full_name":"kaadevelopment/pos-addons","private":false,"owner":{"login":"kaadevelopment","id":52448834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDQ4ODM0","avatar_url":"https://avatars3.githubusercontent.com/u/52448834?v=4","gravatar_id":"","url":"https://api.github.com/users/kaadevelopment","html_url":"https://github.com/kaadevelopment","followers_url":"https://api.github.com/users/kaadevelopment/followers","following_url":"https://api.github.com/users/kaadevelopment/following{/other_user}","gists_url":"https://api.github.com/users/kaadevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/kaadevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaadevelopment/subscriptions","organizations_url":"https://api.github.com/users/kaadevelopment/orgs","repos_url":"https://api.github.com/users/kaadevelopment/repos","events_url":"https://api.github.com/users/kaadevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/kaadevelopment/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kaadevelopment/pos-addons","description":"Odoo POS addons ","fork":true,"url":"https://api.github.com/repos/kaadevelopment/pos-addons","forks_url":"https://api.github.com/repos/kaadevelopment/pos-addons/forks","keys_url":"https://api.github.com/repos/kaadevelopment/pos-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaadevelopment/pos-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaadevelopment/pos-addons/teams","hooks_url":"https://api.github.com/repos/kaadevelopment/pos-addons/hooks","issue_events_url":"https://api.github.com/repos/kaadevelopment/pos-addons/issues/events{/number}","events_url":"https://api.github.com/repos/kaadevelopment/pos-addons/events","assignees_url":"https://api.github.com/repos/kaadevelopment/pos-addons/assignees{/user}","branches_url":"https://api.github.com/repos/kaadevelopment/pos-addons/branches{/branch}","tags_url":"https://api.github.com/repos/kaadevelopment/pos-addons/tags","blobs_url":"https://api.github.com/repos/kaadevelopment/pos-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaadevelopment/pos-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaadevelopment/pos-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaadevelopment/pos-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaadevelopment/pos-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/kaadevelopment/pos-addons/languages","stargazers_url":"https://api.github.com/repos/kaadevelopment/pos-addons/stargazers","contributors_url":"https://api.github.com/repos/kaadevelopment/pos-addons/contributors","subscribers_url":"https://api.github.com/repos/kaadevelopment/pos-addons/subscribers","subscription_url":"https://api.github.com/repos/kaadevelopment/pos-addons/subscription","commits_url":"https://api.github.com/repos/kaadevelopment/pos-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaadevelopment/pos-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaadevelopment/pos-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaadevelopment/pos-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaadevelopment/pos-addons/contents/{+path}","compare_url":"https://api.github.com/repos/kaadevelopment/pos-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaadevelopment/pos-addons/merges","archive_url":"https://api.github.com/repos/kaadevelopment/pos-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaadevelopment/pos-addons/downloads","issues_url":"https://api.github.com/repos/kaadevelopment/pos-addons/issues{/number}","pulls_url":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/kaadevelopment/pos-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/kaadevelopment/pos-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaadevelopment/pos-addons/labels{/name}","releases_url":"https://api.github.com/repos/kaadevelopment/pos-addons/releases{/id}","deployments_url":"https://api.github.com/repos/kaadevelopment/pos-addons/deployments","created_at":"2019-07-02T09:23:11Z","updated_at":"2019-07-25T12:48:11Z","pushed_at":"2019-08-07T10:46:04Z","git_url":"git://github.com/kaadevelopment/pos-addons.git","ssh_url":"[email protected]:kaadevelopment/pos-addons.git","clone_url":"https://github.com/kaadevelopment/pos-addons.git","svn_url":"https://github.com/kaadevelopment/pos-addons","homepage":"https://www.it-projects.info/","size":48064,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"12.0"}},"_links":{"self":{"href":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/17"},"html":{"href":"https://github.com/kaadevelopment/pos-addons/pull/17"},"issue":{"href":"https://api.github.com/repos/kaadevelopment/pos-addons/issues/17"},"comments":{"href":"https://api.github.com/repos/kaadevelopment/pos-addons/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaadevelopment/pos-addons/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/kaadevelopment/pos-addons/statuses/97ed2eb2c63dbb824244c1b0adf326131e7edb5f"}},"author_association":"NONE"}}
|
{
"id": 194831542,
"name": "kaadevelopment/pos-addons",
"url": "https://api.github.com/repos/kaadevelopment/pos-addons"
}
|
{
"id": 50337672,
"login": "kaadevelop",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50337672?",
"url": "https://api.github.com/users/kaadevelop"
}
|
{
"id": 52448834,
"login": "kaadevelopment",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/52448834?",
"url": "https://api.github.com/orgs/kaadevelopment"
}
| 2019-08-19T12:00:51 |
10236586626
|
{"actor":{"display_login":"kaadevelop"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/reservly/reviews/pulls/comments/300846621","pull_request_review_id":258606147,"id":300846621,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDg0NjYyMQ==","diff_hunk":"@@ -0,0 +1,4 @@\n+function sum(a, b) {","path":"sum2.js","position":1,"original_position":1,"commit_id":"adf21d0c0dbb2941cfd2ff9e5055fcde4e275755","original_commit_id":"adf21d0c0dbb2941cfd2ff9e5055fcde4e275755","user":{"login":"janicelam21","id":23692825,"node_id":"MDQ6VXNlcjIzNjkyODI1","avatar_url":"https://avatars3.githubusercontent.com/u/23692825?v=4","gravatar_id":"","url":"https://api.github.com/users/janicelam21","html_url":"https://github.com/janicelam21","followers_url":"https://api.github.com/users/janicelam21/followers","following_url":"https://api.github.com/users/janicelam21/following{/other_user}","gists_url":"https://api.github.com/users/janicelam21/gists{/gist_id}","starred_url":"https://api.github.com/users/janicelam21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicelam21/subscriptions","organizations_url":"https://api.github.com/users/janicelam21/orgs","repos_url":"https://api.github.com/users/janicelam21/repos","events_url":"https://api.github.com/users/janicelam21/events{/privacy}","received_events_url":"https://api.github.com/users/janicelam21/received_events","type":"User","site_admin":false},"body":"Cool - I added it to .gitignore!","created_at":"2019-07-07T01:20:27Z","updated_at":"2019-07-07T01:20:27Z","html_url":"https://github.com/reservly/reviews/pull/1#discussion_r300846621","pull_request_url":"https://api.github.com/repos/reservly/reviews/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/reservly/reviews/pulls/comments/300846621"},"html":{"href":"https://github.com/reservly/reviews/pull/1#discussion_r300846621"},"pull_request":{"href":"https://api.github.com/repos/reservly/reviews/pulls/1"}},"in_reply_to_id":300842496},"pull_request":{"url":"https://api.github.com/repos/reservly/reviews/pulls/1","id":294371692,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0MzcxNjky","html_url":"https://github.com/reservly/reviews/pull/1","diff_url":"https://github.com/reservly/reviews/pull/1.diff","patch_url":"https://github.com/reservly/reviews/pull/1.patch","issue_url":"https://api.github.com/repos/reservly/reviews/issues/1","number":1,"state":"closed","locked":false,"title":"Setup of testing libraries and files","user":{"login":"janicelam21","id":23692825,"node_id":"MDQ6VXNlcjIzNjkyODI1","avatar_url":"https://avatars3.githubusercontent.com/u/23692825?v=4","gravatar_id":"","url":"https://api.github.com/users/janicelam21","html_url":"https://github.com/janicelam21","followers_url":"https://api.github.com/users/janicelam21/followers","following_url":"https://api.github.com/users/janicelam21/following{/other_user}","gists_url":"https://api.github.com/users/janicelam21/gists{/gist_id}","starred_url":"https://api.github.com/users/janicelam21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicelam21/subscriptions","organizations_url":"https://api.github.com/users/janicelam21/orgs","repos_url":"https://api.github.com/users/janicelam21/repos","events_url":"https://api.github.com/users/janicelam21/events{/privacy}","received_events_url":"https://api.github.com/users/janicelam21/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-07-04T00:16:48Z","updated_at":"2019-07-07T01:20:27Z","closed_at":"2019-07-04T00:22:24Z","merged_at":"2019-07-04T00:22:23Z","merge_commit_sha":"b86d3f86c8cfca4b3e1ce5315d3be257ca7525e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reservly/reviews/pulls/1/commits","review_comments_url":"https://api.github.com/repos/reservly/reviews/pulls/1/comments","review_comment_url":"https://api.github.com/repos/reservly/reviews/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reservly/reviews/issues/1/comments","statuses_url":"https://api.github.com/repos/reservly/reviews/statuses/adf21d0c0dbb2941cfd2ff9e5055fcde4e275755","head":{"label":"reservly:setup-testing","ref":"setup-testing","sha":"adf21d0c0dbb2941cfd2ff9e5055fcde4e275755","user":{"login":"reservly","id":52468223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDY4MjIz","avatar_url":"https://avatars2.githubusercontent.com/u/52468223?v=4","gravatar_id":"","url":"https://api.github.com/users/reservly","html_url":"https://github.com/reservly","followers_url":"https://api.github.com/users/reservly/followers","following_url":"https://api.github.com/users/reservly/following{/other_user}","gists_url":"https://api.github.com/users/reservly/gists{/gist_id}","starred_url":"https://api.github.com/users/reservly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reservly/subscriptions","organizations_url":"https://api.github.com/users/reservly/orgs","repos_url":"https://api.github.com/users/reservly/repos","events_url":"https://api.github.com/users/reservly/events{/privacy}","received_events_url":"https://api.github.com/users/reservly/received_events","type":"Organization","site_admin":false},"repo":{"id":194945886,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ5NDU4ODY=","name":"reviews","full_name":"reservly/reviews","private":false,"owner":{"login":"reservly","id":52468223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDY4MjIz","avatar_url":"https://avatars2.githubusercontent.com/u/52468223?v=4","gravatar_id":"","url":"https://api.github.com/users/reservly","html_url":"https://github.com/reservly","followers_url":"https://api.github.com/users/reservly/followers","following_url":"https://api.github.com/users/reservly/following{/other_user}","gists_url":"https://api.github.com/users/reservly/gists{/gist_id}","starred_url":"https://api.github.com/users/reservly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reservly/subscriptions","organizations_url":"https://api.github.com/users/reservly/orgs","repos_url":"https://api.github.com/users/reservly/repos","events_url":"https://api.github.com/users/reservly/events{/privacy}","received_events_url":"https://api.github.com/users/reservly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reservly/reviews","description":null,"fork":false,"url":"https://api.github.com/repos/reservly/reviews","forks_url":"https://api.github.com/repos/reservly/reviews/forks","keys_url":"https://api.github.com/repos/reservly/reviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reservly/reviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reservly/reviews/teams","hooks_url":"https://api.github.com/repos/reservly/reviews/hooks","issue_events_url":"https://api.github.com/repos/reservly/reviews/issues/events{/number}","events_url":"https://api.github.com/repos/reservly/reviews/events","assignees_url":"https://api.github.com/repos/reservly/reviews/assignees{/user}","branches_url":"https://api.github.com/repos/reservly/reviews/branches{/branch}","tags_url":"https://api.github.com/repos/reservly/reviews/tags","blobs_url":"https://api.github.com/repos/reservly/reviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reservly/reviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reservly/reviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/reservly/reviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reservly/reviews/statuses/{sha}","languages_url":"https://api.github.com/repos/reservly/reviews/languages","stargazers_url":"https://api.github.com/repos/reservly/reviews/stargazers","contributors_url":"https://api.github.com/repos/reservly/reviews/contributors","subscribers_url":"https://api.github.com/repos/reservly/reviews/subscribers","subscription_url":"https://api.github.com/repos/reservly/reviews/subscription","commits_url":"https://api.github.com/repos/reservly/reviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/reservly/reviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/reservly/reviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/reservly/reviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/reservly/reviews/contents/{+path}","compare_url":"https://api.github.com/repos/reservly/reviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reservly/reviews/merges","archive_url":"https://api.github.com/repos/reservly/reviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reservly/reviews/downloads","issues_url":"https://api.github.com/repos/reservly/reviews/issues{/number}","pulls_url":"https://api.github.com/repos/reservly/reviews/pulls{/number}","milestones_url":"https://api.github.com/repos/reservly/reviews/milestones{/number}","notifications_url":"https://api.github.com/repos/reservly/reviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reservly/reviews/labels{/name}","releases_url":"https://api.github.com/repos/reservly/reviews/releases{/id}","deployments_url":"https://api.github.com/repos/reservly/reviews/deployments","created_at":"2019-07-02T23:01:39Z","updated_at":"2019-07-05T23:26:19Z","pushed_at":"2019-07-05T23:29:37Z","git_url":"git://github.com/reservly/reviews.git","ssh_url":"[email protected]:reservly/reviews.git","clone_url":"https://github.com/reservly/reviews.git","svn_url":"https://github.com/reservly/reviews","homepage":null,"size":208,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reservly:master","ref":"master","sha":"4f639574f197e64918a53b783f734ec5f2d8830c","user":{"login":"reservly","id":52468223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDY4MjIz","avatar_url":"https://avatars2.githubusercontent.com/u/52468223?v=4","gravatar_id":"","url":"https://api.github.com/users/reservly","html_url":"https://github.com/reservly","followers_url":"https://api.github.com/users/reservly/followers","following_url":"https://api.github.com/users/reservly/following{/other_user}","gists_url":"https://api.github.com/users/reservly/gists{/gist_id}","starred_url":"https://api.github.com/users/reservly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reservly/subscriptions","organizations_url":"https://api.github.com/users/reservly/orgs","repos_url":"https://api.github.com/users/reservly/repos","events_url":"https://api.github.com/users/reservly/events{/privacy}","received_events_url":"https://api.github.com/users/reservly/received_events","type":"Organization","site_admin":false},"repo":{"id":194945886,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ5NDU4ODY=","name":"reviews","full_name":"reservly/reviews","private":false,"owner":{"login":"reservly","id":52468223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDY4MjIz","avatar_url":"https://avatars2.githubusercontent.com/u/52468223?v=4","gravatar_id":"","url":"https://api.github.com/users/reservly","html_url":"https://github.com/reservly","followers_url":"https://api.github.com/users/reservly/followers","following_url":"https://api.github.com/users/reservly/following{/other_user}","gists_url":"https://api.github.com/users/reservly/gists{/gist_id}","starred_url":"https://api.github.com/users/reservly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reservly/subscriptions","organizations_url":"https://api.github.com/users/reservly/orgs","repos_url":"https://api.github.com/users/reservly/repos","events_url":"https://api.github.com/users/reservly/events{/privacy}","received_events_url":"https://api.github.com/users/reservly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reservly/reviews","description":null,"fork":false,"url":"https://api.github.com/repos/reservly/reviews","forks_url":"https://api.github.com/repos/reservly/reviews/forks","keys_url":"https://api.github.com/repos/reservly/reviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reservly/reviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reservly/reviews/teams","hooks_url":"https://api.github.com/repos/reservly/reviews/hooks","issue_events_url":"https://api.github.com/repos/reservly/reviews/issues/events{/number}","events_url":"https://api.github.com/repos/reservly/reviews/events","assignees_url":"https://api.github.com/repos/reservly/reviews/assignees{/user}","branches_url":"https://api.github.com/repos/reservly/reviews/branches{/branch}","tags_url":"https://api.github.com/repos/reservly/reviews/tags","blobs_url":"https://api.github.com/repos/reservly/reviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reservly/reviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reservly/reviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/reservly/reviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reservly/reviews/statuses/{sha}","languages_url":"https://api.github.com/repos/reservly/reviews/languages","stargazers_url":"https://api.github.com/repos/reservly/reviews/stargazers","contributors_url":"https://api.github.com/repos/reservly/reviews/contributors","subscribers_url":"https://api.github.com/repos/reservly/reviews/subscribers","subscription_url":"https://api.github.com/repos/reservly/reviews/subscription","commits_url":"https://api.github.com/repos/reservly/reviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/reservly/reviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/reservly/reviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/reservly/reviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/reservly/reviews/contents/{+path}","compare_url":"https://api.github.com/repos/reservly/reviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reservly/reviews/merges","archive_url":"https://api.github.com/repos/reservly/reviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reservly/reviews/downloads","issues_url":"https://api.github.com/repos/reservly/reviews/issues{/number}","pulls_url":"https://api.github.com/repos/reservly/reviews/pulls{/number}","milestones_url":"https://api.github.com/repos/reservly/reviews/milestones{/number}","notifications_url":"https://api.github.com/repos/reservly/reviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reservly/reviews/labels{/name}","releases_url":"https://api.github.com/repos/reservly/reviews/releases{/id}","deployments_url":"https://api.github.com/repos/reservly/reviews/deployments","created_at":"2019-07-02T23:01:39Z","updated_at":"2019-07-05T23:26:19Z","pushed_at":"2019-07-05T23:29:37Z","git_url":"git://github.com/reservly/reviews.git","ssh_url":"[email protected]:reservly/reviews.git","clone_url":"https://github.com/reservly/reviews.git","svn_url":"https://github.com/reservly/reviews","homepage":null,"size":208,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reservly/reviews/pulls/1"},"html":{"href":"https://github.com/reservly/reviews/pull/1"},"issue":{"href":"https://api.github.com/repos/reservly/reviews/issues/1"},"comments":{"href":"https://api.github.com/repos/reservly/reviews/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/reservly/reviews/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/reservly/reviews/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reservly/reviews/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/reservly/reviews/statuses/adf21d0c0dbb2941cfd2ff9e5055fcde4e275755"}},"author_association":"COLLABORATOR"}}
|
{
"id": 194945886,
"name": "reservly/reviews",
"url": "https://api.github.com/repos/reservly/reviews"
}
|
{
"id": 23692825,
"login": "janicelam21",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23692825?",
"url": "https://api.github.com/users/janicelam21"
}
|
{
"id": 52468223,
"login": "reservly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/52468223?",
"url": "https://api.github.com/orgs/reservly"
}
| 2019-07-07T01:20:27 |
9961205377
|
{"actor":{"display_login":"janicelam21"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/canonical/cloud-init/pulls/comments/359603262","pull_request_review_id":334302066,"id":359603262,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTYwMzI2Mg==","diff_hunk":"@@ -0,0 +1,164 @@\n+# This file is part of cloud-init. See LICENSE file for license information.\n+\n+import re\n+\n+from cloudinit import log as logging\n+from cloudinit import net\n+from cloudinit import util\n+from cloudinit.distros import rhel_util\n+from cloudinit.distros.parsers.resolv_conf import ResolvConf\n+\n+from . import renderer\n+\n+LOG = logging.getLogger(__name__)\n+\n+\n+class Renderer(renderer.Renderer):\n+ resolv_conf_fn = 'etc/resolv.conf'\n+ rc_conf_fn = 'etc/rc.conf'\n+\n+ def __init__(self, config=None):\n+ if not config:\n+ config = {}\n+ self.dhcp_interfaces = []\n+ self._postcmds = config.get('postcmds', True)\n+\n+ def _write_ifconfig_entries(self, settings, target=None):\n+ ifname_by_mac = net.get_interfaces_by_mac()\n+ for interface in settings.iter_interfaces():\n+ device_name = interface.get(\"name\")\n+ device_mac = interface.get(\"mac_address\")\n+ if device_name and re.match(r'^lo\\d+$', device_name):\n+ continue\n+ if device_mac and device_name:\n+ cur_name = ifname_by_mac[device_mac]\n+ if not cur_name:\n+ LOG.info('Cannot find any device with MAC %s', device_mac)\n+ continue\n+ if cur_name != device_name:\n+ rhel_util.update_sysconfig_file(\n+ util.target_path(target, self.rc_conf_fn), {\n+ 'ifconfig_%s_name' % cur_name: device_name})\n+ elif device_mac:\n+ device_name = ifname_by_mac[device_mac]\n+\n+ LOG.info('Configuring interface %s', device_name)\n+ ifconfig = 'DHCP' # default\n+ for subnet in interface.get(\"subnets\", []):\n+\n+ if subnet.get('type') == 'static':\n+ LOG.debug('Configuring dev %s with %s / %s', device_name,\n+ subnet.get('address'), subnet.get('netmask'))\n+ # Configure an ipv4 address.\n+ ifconfig = (\n+ subnet.get('address') + ' netmask ' +\n+ subnet.get('netmask'))\n+\n+ # NOTE: Known limitation, we just set one subnet per interface\n+ break\n+\n+ if ifconfig == 'DHCP':\n+ self.dhcp_interfaces.append(device_name)\n+ rhel_util.update_sysconfig_file(\n+ util.target_path(target, self.rc_conf_fn), {\n+ 'ifconfig_' + device_name: ifconfig})\n+\n+ def _write_route_entries(self, settings, target=None):\n+ routes = list(settings.iter_routes())\n+ for interface in settings.iter_interfaces():\n+ subnets = interface.get(\"subnets\", [])\n+ for subnet in subnets:\n+ if subnet.get('type') == 'static':\n+ gateway = subnet.get('gateway')\n+ if gateway:\n+ routes.append({\n+ 'network': '0.0.0.0',\n+ 'netmask': '0.0.0.0',\n+ 'gateway': gateway})\n+ routes += subnet.get('routes', [])\n+ route_cpt = 0\n+ for route in routes:\n+ network = route.get('network')\n+ netmask = route.get('netmask')\n+ gateway = route.get('gateway')\n+ route_cmd = \"-route %s/%s %s\" % (network, netmask, gateway)\n+ if not network:\n+ continue\n+ if network == '0.0.0.0':\n+ rhel_util.update_sysconfig_file(\n+ util.target_path(target, self.rc_conf_fn), {\n+ 'defaultrouter': gateway})\n+ else:\n+ rhel_util.update_sysconfig_file(\n+ util.target_path(target, self.rc_conf_fn), {\n+ 'route_net%d' % route_cpt: route_cmd})\n+ route_cpt += 1\n+\n+ def _write_resolve_conf(self, settings, target=None):\n+ nameservers = settings.dns_nameservers\n+ searchdomains = settings.dns_searchdomains\n+ for interface in settings.iter_interfaces():\n+ for subnet in interface.get(\"subnets\", []):\n+ if 'dns_nameservers' in subnet:\n+ nameservers.extend(subnet['dns_nameservers'])\n+ if 'dns_search' in subnet:\n+ searchdomains.extend(subnet['dns_search'])\n+ # Try to read the /etc/resolv.conf or just start from scratch if that\n+ # fails.\n+ try:\n+ resolvconf = ResolvConf(util.load_file(self.resolv_conf_fn))\n+ resolvconf.parse()\n+ except IOError:\n+ util.logexc(LOG, \"Failed to parse %s, use new empty file\",\n+ self.resolv_conf_fn)\n+ resolvconf = ResolvConf('')\n+ resolvconf.parse()\n+\n+ # Add some nameservers\n+ for server in nameservers:\n+ try:\n+ resolvconf.add_nameserver(server)\n+ except ValueError:\n+ util.logexc(LOG, \"Failed to add nameserver %s\", server)\n+\n+ # And add any searchdomains.\n+ for domain in searchdomains:\n+ try:\n+ resolvconf.add_search_domain(domain)\n+ except ValueError:\n+ util.logexc(LOG, \"Failed to add search domain %s\", domain)\n+ util.write_file(\n+ util.target_path(target, self.resolv_conf_fn),\n+ str(resolvconf), 0o644)\n+\n+ def _write_network(self, settings, target=None):\n+ self._write_ifconfig_entries(settings, target=None)\n+ self._write_route_entries(settings, target=None)\n+ self._write_resolve_conf(settings, target=None)","path":"cloudinit/net/freebsd.py","position":137,"original_position":137,"commit_id":"635ce14b3153934ba1041be48b7245062f21e960","original_commit_id":"635ce14b3153934ba1041be48b7245062f21e960","user":{"login":"raharper","id":10930515,"node_id":"MDQ6VXNlcjEwOTMwNTE1","avatar_url":"https://avatars2.githubusercontent.com/u/10930515?v=4","gravatar_id":"","url":"https://api.github.com/users/raharper","html_url":"https://github.com/raharper","followers_url":"https://api.github.com/users/raharper/followers","following_url":"https://api.github.com/users/raharper/following{/other_user}","gists_url":"https://api.github.com/users/raharper/gists{/gist_id}","starred_url":"https://api.github.com/users/raharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raharper/subscriptions","organizations_url":"https://api.github.com/users/raharper/orgs","repos_url":"https://api.github.com/users/raharper/repos","events_url":"https://api.github.com/users/raharper/events{/privacy}","received_events_url":"https://api.github.com/users/raharper/received_events","type":"User","site_admin":false},"body":"each call here should be target=target so the caller can set the target value.","created_at":"2019-12-18T22:34:34Z","updated_at":"2019-12-18T22:41:47Z","html_url":"https://github.com/canonical/cloud-init/pull/61#discussion_r359603262","pull_request_url":"https://api.github.com/repos/canonical/cloud-init/pulls/61","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/canonical/cloud-init/pulls/comments/359603262"},"html":{"href":"https://github.com/canonical/cloud-init/pull/61#discussion_r359603262"},"pull_request":{"href":"https://api.github.com/repos/canonical/cloud-init/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/canonical/cloud-init/pulls/61","id":344822934,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0ODIyOTM0","html_url":"https://github.com/canonical/cloud-init/pull/61","diff_url":"https://github.com/canonical/cloud-init/pull/61.diff","patch_url":"https://github.com/canonical/cloud-init/pull/61.patch","issue_url":"https://api.github.com/repos/canonical/cloud-init/issues/61","number":61,"state":"open","locked":false,"title":"freebsd: introduce the freebsd renderer","user":{"login":"goneri","id":49379,"node_id":"MDQ6VXNlcjQ5Mzc5","avatar_url":"https://avatars1.githubusercontent.com/u/49379?v=4","gravatar_id":"","url":"https://api.github.com/users/goneri","html_url":"https://github.com/goneri","followers_url":"https://api.github.com/users/goneri/followers","following_url":"https://api.github.com/users/goneri/following{/other_user}","gists_url":"https://api.github.com/users/goneri/gists{/gist_id}","starred_url":"https://api.github.com/users/goneri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goneri/subscriptions","organizations_url":"https://api.github.com/users/goneri/orgs","repos_url":"https://api.github.com/users/goneri/repos","events_url":"https://api.github.com/users/goneri/events{/privacy}","received_events_url":"https://api.github.com/users/goneri/received_events","type":"User","site_admin":false},"body":"Refactoring of the FreeBSD code base to provide a real network renderer\r\nfor FreeBSD.\r\nUse the generic update_sysconfig_file() from rhel_util to handle the\r\naccess to /etc/rc.conf.\r\nInterfaces are not automatically renamed by FreeBSD using\r\nthe following configuration in /etc/rc.conf:\r\n\r\n```\r\nifconfig_fxp0_name=\"eth0\"\r\n```","created_at":"2019-11-23T16:31:42Z","updated_at":"2019-12-18T22:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e79a10ad5c58d4624bab0409d5237ece031235ac","assignee":{"login":"OddBloke","id":62736,"node_id":"MDQ6VXNlcjYyNzM2","avatar_url":"https://avatars1.githubusercontent.com/u/62736?v=4","gravatar_id":"","url":"https://api.github.com/users/OddBloke","html_url":"https://github.com/OddBloke","followers_url":"https://api.github.com/users/OddBloke/followers","following_url":"https://api.github.com/users/OddBloke/following{/other_user}","gists_url":"https://api.github.com/users/OddBloke/gists{/gist_id}","starred_url":"https://api.github.com/users/OddBloke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OddBloke/subscriptions","organizations_url":"https://api.github.com/users/OddBloke/orgs","repos_url":"https://api.github.com/users/OddBloke/repos","events_url":"https://api.github.com/users/OddBloke/events{/privacy}","received_events_url":"https://api.github.com/users/OddBloke/received_events","type":"User","site_admin":false},"assignees":[{"login":"OddBloke","id":62736,"node_id":"MDQ6VXNlcjYyNzM2","avatar_url":"https://avatars1.githubusercontent.com/u/62736?v=4","gravatar_id":"","url":"https://api.github.com/users/OddBloke","html_url":"https://github.com/OddBloke","followers_url":"https://api.github.com/users/OddBloke/followers","following_url":"https://api.github.com/users/OddBloke/following{/other_user}","gists_url":"https://api.github.com/users/OddBloke/gists{/gist_id}","starred_url":"https://api.github.com/users/OddBloke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OddBloke/subscriptions","organizations_url":"https://api.github.com/users/OddBloke/orgs","repos_url":"https://api.github.com/users/OddBloke/repos","events_url":"https://api.github.com/users/OddBloke/events{/privacy}","received_events_url":"https://api.github.com/users/OddBloke/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/canonical/cloud-init/pulls/61/commits","review_comments_url":"https://api.github.com/repos/canonical/cloud-init/pulls/61/comments","review_comment_url":"https://api.github.com/repos/canonical/cloud-init/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canonical/cloud-init/issues/61/comments","statuses_url":"https://api.github.com/repos/canonical/cloud-init/statuses/635ce14b3153934ba1041be48b7245062f21e960","head":{"label":"goneri:freebsd_net_renderer","ref":"freebsd_net_renderer","sha":"635ce14b3153934ba1041be48b7245062f21e960","user":{"login":"goneri","id":49379,"node_id":"MDQ6VXNlcjQ5Mzc5","avatar_url":"https://avatars1.githubusercontent.com/u/49379?v=4","gravatar_id":"","url":"https://api.github.com/users/goneri","html_url":"https://github.com/goneri","followers_url":"https://api.github.com/users/goneri/followers","following_url":"https://api.github.com/users/goneri/following{/other_user}","gists_url":"https://api.github.com/users/goneri/gists{/gist_id}","starred_url":"https://api.github.com/users/goneri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goneri/subscriptions","organizations_url":"https://api.github.com/users/goneri/orgs","repos_url":"https://api.github.com/users/goneri/repos","events_url":"https://api.github.com/users/goneri/events{/privacy}","received_events_url":"https://api.github.com/users/goneri/received_events","type":"User","site_admin":false},"repo":{"id":177376688,"node_id":"MDEwOlJlcG9zaXRvcnkxNzczNzY2ODg=","name":"cloud-init","full_name":"goneri/cloud-init","private":false,"owner":{"login":"goneri","id":49379,"node_id":"MDQ6VXNlcjQ5Mzc5","avatar_url":"https://avatars1.githubusercontent.com/u/49379?v=4","gravatar_id":"","url":"https://api.github.com/users/goneri","html_url":"https://github.com/goneri","followers_url":"https://api.github.com/users/goneri/followers","following_url":"https://api.github.com/users/goneri/following{/other_user}","gists_url":"https://api.github.com/users/goneri/gists{/gist_id}","starred_url":"https://api.github.com/users/goneri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goneri/subscriptions","organizations_url":"https://api.github.com/users/goneri/orgs","repos_url":"https://api.github.com/users/goneri/repos","events_url":"https://api.github.com/users/goneri/events{/privacy}","received_events_url":"https://api.github.com/users/goneri/received_events","type":"User","site_admin":false},"html_url":"https://github.com/goneri/cloud-init","description":"FreeBSD and NetBSD branches for cloud-init","fork":true,"url":"https://api.github.com/repos/goneri/cloud-init","forks_url":"https://api.github.com/repos/goneri/cloud-init/forks","keys_url":"https://api.github.com/repos/goneri/cloud-init/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goneri/cloud-init/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goneri/cloud-init/teams","hooks_url":"https://api.github.com/repos/goneri/cloud-init/hooks","issue_events_url":"https://api.github.com/repos/goneri/cloud-init/issues/events{/number}","events_url":"https://api.github.com/repos/goneri/cloud-init/events","assignees_url":"https://api.github.com/repos/goneri/cloud-init/assignees{/user}","branches_url":"https://api.github.com/repos/goneri/cloud-init/branches{/branch}","tags_url":"https://api.github.com/repos/goneri/cloud-init/tags","blobs_url":"https://api.github.com/repos/goneri/cloud-init/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goneri/cloud-init/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goneri/cloud-init/git/refs{/sha}","trees_url":"https://api.github.com/repos/goneri/cloud-init/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goneri/cloud-init/statuses/{sha}","languages_url":"https://api.github.com/repos/goneri/cloud-init/languages","stargazers_url":"https://api.github.com/repos/goneri/cloud-init/stargazers","contributors_url":"https://api.github.com/repos/goneri/cloud-init/contributors","subscribers_url":"https://api.github.com/repos/goneri/cloud-init/subscribers","subscription_url":"https://api.github.com/repos/goneri/cloud-init/subscription","commits_url":"https://api.github.com/repos/goneri/cloud-init/commits{/sha}","git_commits_url":"https://api.github.com/repos/goneri/cloud-init/git/commits{/sha}","comments_url":"https://api.github.com/repos/goneri/cloud-init/comments{/number}","issue_comment_url":"https://api.github.com/repos/goneri/cloud-init/issues/comments{/number}","contents_url":"https://api.github.com/repos/goneri/cloud-init/contents/{+path}","compare_url":"https://api.github.com/repos/goneri/cloud-init/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goneri/cloud-init/merges","archive_url":"https://api.github.com/repos/goneri/cloud-init/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goneri/cloud-init/downloads","issues_url":"https://api.github.com/repos/goneri/cloud-init/issues{/number}","pulls_url":"https://api.github.com/repos/goneri/cloud-init/pulls{/number}","milestones_url":"https://api.github.com/repos/goneri/cloud-init/milestones{/number}","notifications_url":"https://api.github.com/repos/goneri/cloud-init/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goneri/cloud-init/labels{/name}","releases_url":"https://api.github.com/repos/goneri/cloud-init/releases{/id}","deployments_url":"https://api.github.com/repos/goneri/cloud-init/deployments","created_at":"2019-03-24T05:57:45Z","updated_at":"2019-11-06T20:54:10Z","pushed_at":"2019-12-18T14:39:50Z","git_url":"git://github.com/goneri/cloud-init.git","ssh_url":"[email protected]:goneri/cloud-init.git","clone_url":"https://github.com/goneri/cloud-init.git","svn_url":"https://github.com/goneri/cloud-init","homepage":"https://git.launchpad.net/cloud-init","size":20141,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"canonical:master","ref":"master","sha":"45cd8e19dacb0938df505646d805bfcd6b723a41","user":{"login":"canonical","id":53057619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDU3NjE5","avatar_url":"https://avatars1.githubusercontent.com/u/53057619?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical","html_url":"https://github.com/canonical","followers_url":"https://api.github.com/users/canonical/followers","following_url":"https://api.github.com/users/canonical/following{/other_user}","gists_url":"https://api.github.com/users/canonical/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical/subscriptions","organizations_url":"https://api.github.com/users/canonical/orgs","repos_url":"https://api.github.com/users/canonical/repos","events_url":"https://api.github.com/users/canonical/events{/privacy}","received_events_url":"https://api.github.com/users/canonical/received_events","type":"Organization","site_admin":false},"repo":{"id":24948315,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk0ODMxNQ==","name":"cloud-init","full_name":"canonical/cloud-init","private":false,"owner":{"login":"canonical","id":53057619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDU3NjE5","avatar_url":"https://avatars1.githubusercontent.com/u/53057619?v=4","gravatar_id":"","url":"https://api.github.com/users/canonical","html_url":"https://github.com/canonical","followers_url":"https://api.github.com/users/canonical/followers","following_url":"https://api.github.com/users/canonical/following{/other_user}","gists_url":"https://api.github.com/users/canonical/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical/subscriptions","organizations_url":"https://api.github.com/users/canonical/orgs","repos_url":"https://api.github.com/users/canonical/repos","events_url":"https://api.github.com/users/canonical/events{/privacy}","received_events_url":"https://api.github.com/users/canonical/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/canonical/cloud-init","description":"Official upstream for the cloud-init: cloud instance initialization","fork":false,"url":"https://api.github.com/repos/canonical/cloud-init","forks_url":"https://api.github.com/repos/canonical/cloud-init/forks","keys_url":"https://api.github.com/repos/canonical/cloud-init/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical/cloud-init/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical/cloud-init/teams","hooks_url":"https://api.github.com/repos/canonical/cloud-init/hooks","issue_events_url":"https://api.github.com/repos/canonical/cloud-init/issues/events{/number}","events_url":"https://api.github.com/repos/canonical/cloud-init/events","assignees_url":"https://api.github.com/repos/canonical/cloud-init/assignees{/user}","branches_url":"https://api.github.com/repos/canonical/cloud-init/branches{/branch}","tags_url":"https://api.github.com/repos/canonical/cloud-init/tags","blobs_url":"https://api.github.com/repos/canonical/cloud-init/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical/cloud-init/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical/cloud-init/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical/cloud-init/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical/cloud-init/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical/cloud-init/languages","stargazers_url":"https://api.github.com/repos/canonical/cloud-init/stargazers","contributors_url":"https://api.github.com/repos/canonical/cloud-init/contributors","subscribers_url":"https://api.github.com/repos/canonical/cloud-init/subscribers","subscription_url":"https://api.github.com/repos/canonical/cloud-init/subscription","commits_url":"https://api.github.com/repos/canonical/cloud-init/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical/cloud-init/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical/cloud-init/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical/cloud-init/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical/cloud-init/contents/{+path}","compare_url":"https://api.github.com/repos/canonical/cloud-init/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical/cloud-init/merges","archive_url":"https://api.github.com/repos/canonical/cloud-init/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical/cloud-init/downloads","issues_url":"https://api.github.com/repos/canonical/cloud-init/issues{/number}","pulls_url":"https://api.github.com/repos/canonical/cloud-init/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical/cloud-init/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical/cloud-init/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical/cloud-init/labels{/name}","releases_url":"https://api.github.com/repos/canonical/cloud-init/releases{/id}","deployments_url":"https://api.github.com/repos/canonical/cloud-init/deployments","created_at":"2014-10-08T15:54:41Z","updated_at":"2019-12-18T21:22:06Z","pushed_at":"2019-12-18T21:27:20Z","git_url":"git://github.com/canonical/cloud-init.git","ssh_url":"[email protected]:canonical/cloud-init.git","clone_url":"https://github.com/canonical/cloud-init.git","svn_url":"https://github.com/canonical/cloud-init","homepage":"https://cloud-init.io/","size":20262,"stargazers_count":387,"watchers_count":387,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":155,"open_issues":21,"watchers":387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canonical/cloud-init/pulls/61"},"html":{"href":"https://github.com/canonical/cloud-init/pull/61"},"issue":{"href":"https://api.github.com/repos/canonical/cloud-init/issues/61"},"comments":{"href":"https://api.github.com/repos/canonical/cloud-init/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/canonical/cloud-init/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/canonical/cloud-init/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canonical/cloud-init/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/canonical/cloud-init/statuses/635ce14b3153934ba1041be48b7245062f21e960"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 24948315,
"name": "canonical/cloud-init",
"url": "https://api.github.com/repos/canonical/cloud-init"
}
|
{
"id": 10930515,
"login": "raharper",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10930515?",
"url": "https://api.github.com/users/raharper"
}
|
{
"id": 53057619,
"login": "canonical",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53057619?",
"url": "https://api.github.com/orgs/canonical"
}
| 2019-12-18T22:34:34 |
11121013823
|
{"actor":{"display_login":"raharper"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/comments/365946390","pull_request_review_id":342024567,"id":365946390,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTk0NjM5MA==","diff_hunk":"@@ -0,0 +1,43 @@\n+import { Movie } from \"../entities/Movie\"\n+import { MovieGateway } from \"../gateways/MovieGateway\"\n+import { MissingInformationError } from \"../entities/errors/MissingInformationError\"\n+\n+export class CreateMovieUseCase {\n+ private movieGateway: MovieGateway\n+ constructor(\n+ movieGateway: MovieGateway\n+ ) {\n+ this.movieGateway = movieGateway\n+ }\n+ async execute(input: CreateMovieUseCaseInput) {\n+ if (!input.title ||\n+ !input.date ||\n+ !input.length ||\n+ !input.synopsis ||\n+ !input.link ||\n+ !input.picture\n+ ) {\n+ throw new MissingInformationError(\"Faltam informaรงรตes para a criaรงรฃo do filme!\")\n+ }\n+\n+ const movie = new Movie(","path":"src/business/usecases/CreateMovieUseCase.ts","position":23,"original_position":23,"commit_id":"b3c91d87606846e949634a967e341c0e22fca7fb","original_commit_id":"b3c91d87606846e949634a967e341c0e22fca7fb","user":{"login":"joaogolias","id":38192396,"node_id":"MDQ6VXNlcjM4MTkyMzk2","avatar_url":"https://avatars0.githubusercontent.com/u/38192396?v=4","gravatar_id":"","url":"https://api.github.com/users/joaogolias","html_url":"https://github.com/joaogolias","followers_url":"https://api.github.com/users/joaogolias/followers","following_url":"https://api.github.com/users/joaogolias/following{/other_user}","gists_url":"https://api.github.com/users/joaogolias/gists{/gist_id}","starred_url":"https://api.github.com/users/joaogolias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaogolias/subscriptions","organizations_url":"https://api.github.com/users/joaogolias/orgs","repos_url":"https://api.github.com/users/joaogolias/repos","events_url":"https://api.github.com/users/joaogolias/events{/privacy}","received_events_url":"https://api.github.com/users/joaogolias/received_events","type":"User","site_admin":false},"body":"Legal!","created_at":"2020-01-13T18:02:02Z","updated_at":"2020-01-13T18:05:30Z","html_url":"https://github.com/future4code/4flix-grupo1/pull/5#discussion_r365946390","pull_request_url":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/comments/365946390"},"html":{"href":"https://github.com/future4code/4flix-grupo1/pull/5#discussion_r365946390"},"pull_request":{"href":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/5","id":362078211,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYyMDc4MjEx","html_url":"https://github.com/future4code/4flix-grupo1/pull/5","diff_url":"https://github.com/future4code/4flix-grupo1/pull/5.diff","patch_url":"https://github.com/future4code/4flix-grupo1/pull/5.patch","issue_url":"https://api.github.com/repos/future4code/4flix-grupo1/issues/5","number":5,"state":"open","locked":false,"title":"Correรงรฃo","user":{"login":"joaogolias","id":38192396,"node_id":"MDQ6VXNlcjM4MTkyMzk2","avatar_url":"https://avatars0.githubusercontent.com/u/38192396?v=4","gravatar_id":"","url":"https://api.github.com/users/joaogolias","html_url":"https://github.com/joaogolias","followers_url":"https://api.github.com/users/joaogolias/followers","following_url":"https://api.github.com/users/joaogolias/following{/other_user}","gists_url":"https://api.github.com/users/joaogolias/gists{/gist_id}","starred_url":"https://api.github.com/users/joaogolias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaogolias/subscriptions","organizations_url":"https://api.github.com/users/joaogolias/orgs","repos_url":"https://api.github.com/users/joaogolias/repos","events_url":"https://api.github.com/users/joaogolias/events{/privacy}","received_events_url":"https://api.github.com/users/joaogolias/received_events","type":"User","site_admin":false},"body":"PR de Correรงรฃo. Vejam os comentรกrios.","created_at":"2020-01-13T11:53:12Z","updated_at":"2020-01-13T18:05:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35f4be65fbfb13e20a70103b8b0299715a5da04d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/5/commits","review_comments_url":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/5/comments","review_comment_url":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/future4code/4flix-grupo1/issues/5/comments","statuses_url":"https://api.github.com/repos/future4code/4flix-grupo1/statuses/b3c91d87606846e949634a967e341c0e22fca7fb","head":{"label":"future4code:master","ref":"master","sha":"b3c91d87606846e949634a967e341c0e22fca7fb","user":{"login":"future4code","id":53058090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDU4MDkw","avatar_url":"https://avatars3.githubusercontent.com/u/53058090?v=4","gravatar_id":"","url":"https://api.github.com/users/future4code","html_url":"https://github.com/future4code","followers_url":"https://api.github.com/users/future4code/followers","following_url":"https://api.github.com/users/future4code/following{/other_user}","gists_url":"https://api.github.com/users/future4code/gists{/gist_id}","starred_url":"https://api.github.com/users/future4code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/future4code/subscriptions","organizations_url":"https://api.github.com/users/future4code/orgs","repos_url":"https://api.github.com/users/future4code/repos","events_url":"https://api.github.com/users/future4code/events{/privacy}","received_events_url":"https://api.github.com/users/future4code/received_events","type":"Organization","site_admin":false},"repo":{"id":232564471,"node_id":"MDEwOlJlcG9zaXRvcnkyMzI1NjQ0NzE=","name":"4flix-grupo1","full_name":"future4code/4flix-grupo1","private":false,"owner":{"login":"future4code","id":53058090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDU4MDkw","avatar_url":"https://avatars3.githubusercontent.com/u/53058090?v=4","gravatar_id":"","url":"https://api.github.com/users/future4code","html_url":"https://github.com/future4code","followers_url":"https://api.github.com/users/future4code/followers","following_url":"https://api.github.com/users/future4code/following{/other_user}","gists_url":"https://api.github.com/users/future4code/gists{/gist_id}","starred_url":"https://api.github.com/users/future4code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/future4code/subscriptions","organizations_url":"https://api.github.com/users/future4code/orgs","repos_url":"https://api.github.com/users/future4code/repos","events_url":"https://api.github.com/users/future4code/events{/privacy}","received_events_url":"https://api.github.com/users/future4code/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/future4code/4flix-grupo1","description":null,"fork":false,"url":"https://api.github.com/repos/future4code/4flix-grupo1","forks_url":"https://api.github.com/repos/future4code/4flix-grupo1/forks","keys_url":"https://api.github.com/repos/future4code/4flix-grupo1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/future4code/4flix-grupo1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/future4code/4flix-grupo1/teams","hooks_url":"https://api.github.com/repos/future4code/4flix-grupo1/hooks","issue_events_url":"https://api.github.com/repos/future4code/4flix-grupo1/issues/events{/number}","events_url":"https://api.github.com/repos/future4code/4flix-grupo1/events","assignees_url":"https://api.github.com/repos/future4code/4flix-grupo1/assignees{/user}","branches_url":"https://api.github.com/repos/future4code/4flix-grupo1/branches{/branch}","tags_url":"https://api.github.com/repos/future4code/4flix-grupo1/tags","blobs_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/refs{/sha}","trees_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/future4code/4flix-grupo1/statuses/{sha}","languages_url":"https://api.github.com/repos/future4code/4flix-grupo1/languages","stargazers_url":"https://api.github.com/repos/future4code/4flix-grupo1/stargazers","contributors_url":"https://api.github.com/repos/future4code/4flix-grupo1/contributors","subscribers_url":"https://api.github.com/repos/future4code/4flix-grupo1/subscribers","subscription_url":"https://api.github.com/repos/future4code/4flix-grupo1/subscription","commits_url":"https://api.github.com/repos/future4code/4flix-grupo1/commits{/sha}","git_commits_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/commits{/sha}","comments_url":"https://api.github.com/repos/future4code/4flix-grupo1/comments{/number}","issue_comment_url":"https://api.github.com/repos/future4code/4flix-grupo1/issues/comments{/number}","contents_url":"https://api.github.com/repos/future4code/4flix-grupo1/contents/{+path}","compare_url":"https://api.github.com/repos/future4code/4flix-grupo1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/future4code/4flix-grupo1/merges","archive_url":"https://api.github.com/repos/future4code/4flix-grupo1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/future4code/4flix-grupo1/downloads","issues_url":"https://api.github.com/repos/future4code/4flix-grupo1/issues{/number}","pulls_url":"https://api.github.com/repos/future4code/4flix-grupo1/pulls{/number}","milestones_url":"https://api.github.com/repos/future4code/4flix-grupo1/milestones{/number}","notifications_url":"https://api.github.com/repos/future4code/4flix-grupo1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/future4code/4flix-grupo1/labels{/name}","releases_url":"https://api.github.com/repos/future4code/4flix-grupo1/releases{/id}","deployments_url":"https://api.github.com/repos/future4code/4flix-grupo1/deployments","created_at":"2020-01-08T13:01:36Z","updated_at":"2020-01-13T17:44:31Z","pushed_at":"2020-01-13T17:44:26Z","git_url":"git://github.com/future4code/4flix-grupo1.git","ssh_url":"[email protected]:future4code/4flix-grupo1.git","clone_url":"https://github.com/future4code/4flix-grupo1.git","svn_url":"https://github.com/future4code/4flix-grupo1","homepage":null,"size":18589,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"future4code:correcao","ref":"correcao","sha":"8c5c380107fb6a930b5174cd922709382c8113e0","user":{"login":"future4code","id":53058090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDU4MDkw","avatar_url":"https://avatars3.githubusercontent.com/u/53058090?v=4","gravatar_id":"","url":"https://api.github.com/users/future4code","html_url":"https://github.com/future4code","followers_url":"https://api.github.com/users/future4code/followers","following_url":"https://api.github.com/users/future4code/following{/other_user}","gists_url":"https://api.github.com/users/future4code/gists{/gist_id}","starred_url":"https://api.github.com/users/future4code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/future4code/subscriptions","organizations_url":"https://api.github.com/users/future4code/orgs","repos_url":"https://api.github.com/users/future4code/repos","events_url":"https://api.github.com/users/future4code/events{/privacy}","received_events_url":"https://api.github.com/users/future4code/received_events","type":"Organization","site_admin":false},"repo":{"id":232564471,"node_id":"MDEwOlJlcG9zaXRvcnkyMzI1NjQ0NzE=","name":"4flix-grupo1","full_name":"future4code/4flix-grupo1","private":false,"owner":{"login":"future4code","id":53058090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDU4MDkw","avatar_url":"https://avatars3.githubusercontent.com/u/53058090?v=4","gravatar_id":"","url":"https://api.github.com/users/future4code","html_url":"https://github.com/future4code","followers_url":"https://api.github.com/users/future4code/followers","following_url":"https://api.github.com/users/future4code/following{/other_user}","gists_url":"https://api.github.com/users/future4code/gists{/gist_id}","starred_url":"https://api.github.com/users/future4code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/future4code/subscriptions","organizations_url":"https://api.github.com/users/future4code/orgs","repos_url":"https://api.github.com/users/future4code/repos","events_url":"https://api.github.com/users/future4code/events{/privacy}","received_events_url":"https://api.github.com/users/future4code/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/future4code/4flix-grupo1","description":null,"fork":false,"url":"https://api.github.com/repos/future4code/4flix-grupo1","forks_url":"https://api.github.com/repos/future4code/4flix-grupo1/forks","keys_url":"https://api.github.com/repos/future4code/4flix-grupo1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/future4code/4flix-grupo1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/future4code/4flix-grupo1/teams","hooks_url":"https://api.github.com/repos/future4code/4flix-grupo1/hooks","issue_events_url":"https://api.github.com/repos/future4code/4flix-grupo1/issues/events{/number}","events_url":"https://api.github.com/repos/future4code/4flix-grupo1/events","assignees_url":"https://api.github.com/repos/future4code/4flix-grupo1/assignees{/user}","branches_url":"https://api.github.com/repos/future4code/4flix-grupo1/branches{/branch}","tags_url":"https://api.github.com/repos/future4code/4flix-grupo1/tags","blobs_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/refs{/sha}","trees_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/future4code/4flix-grupo1/statuses/{sha}","languages_url":"https://api.github.com/repos/future4code/4flix-grupo1/languages","stargazers_url":"https://api.github.com/repos/future4code/4flix-grupo1/stargazers","contributors_url":"https://api.github.com/repos/future4code/4flix-grupo1/contributors","subscribers_url":"https://api.github.com/repos/future4code/4flix-grupo1/subscribers","subscription_url":"https://api.github.com/repos/future4code/4flix-grupo1/subscription","commits_url":"https://api.github.com/repos/future4code/4flix-grupo1/commits{/sha}","git_commits_url":"https://api.github.com/repos/future4code/4flix-grupo1/git/commits{/sha}","comments_url":"https://api.github.com/repos/future4code/4flix-grupo1/comments{/number}","issue_comment_url":"https://api.github.com/repos/future4code/4flix-grupo1/issues/comments{/number}","contents_url":"https://api.github.com/repos/future4code/4flix-grupo1/contents/{+path}","compare_url":"https://api.github.com/repos/future4code/4flix-grupo1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/future4code/4flix-grupo1/merges","archive_url":"https://api.github.com/repos/future4code/4flix-grupo1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/future4code/4flix-grupo1/downloads","issues_url":"https://api.github.com/repos/future4code/4flix-grupo1/issues{/number}","pulls_url":"https://api.github.com/repos/future4code/4flix-grupo1/pulls{/number}","milestones_url":"https://api.github.com/repos/future4code/4flix-grupo1/milestones{/number}","notifications_url":"https://api.github.com/repos/future4code/4flix-grupo1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/future4code/4flix-grupo1/labels{/name}","releases_url":"https://api.github.com/repos/future4code/4flix-grupo1/releases{/id}","deployments_url":"https://api.github.com/repos/future4code/4flix-grupo1/deployments","created_at":"2020-01-08T13:01:36Z","updated_at":"2020-01-13T17:44:31Z","pushed_at":"2020-01-13T17:44:26Z","git_url":"git://github.com/future4code/4flix-grupo1.git","ssh_url":"[email protected]:future4code/4flix-grupo1.git","clone_url":"https://github.com/future4code/4flix-grupo1.git","svn_url":"https://github.com/future4code/4flix-grupo1","homepage":null,"size":18589,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/5"},"html":{"href":"https://github.com/future4code/4flix-grupo1/pull/5"},"issue":{"href":"https://api.github.com/repos/future4code/4flix-grupo1/issues/5"},"comments":{"href":"https://api.github.com/repos/future4code/4flix-grupo1/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/future4code/4flix-grupo1/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/future4code/4flix-grupo1/statuses/b3c91d87606846e949634a967e341c0e22fca7fb"}},"author_association":"NONE"}}
|
{
"id": 232564471,
"name": "future4code/4flix-grupo1",
"url": "https://api.github.com/repos/future4code/4flix-grupo1"
}
|
{
"id": 38192396,
"login": "joaogolias",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38192396?",
"url": "https://api.github.com/users/joaogolias"
}
|
{
"id": 53058090,
"login": "future4code",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53058090?",
"url": "https://api.github.com/orgs/future4code"
}
| 2020-01-13T18:02:02 |
11264304935
|
{"actor":{"display_login":"joaogolias"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/comments/311794541","pull_request_review_id":272268152,"id":311794541,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTc5NDU0MQ==","diff_hunk":"@@ -10,7 +10,26 @@\n low <= n <= high.\n */\n function count_rabbits(low, high) {\n- // your implementation\n+ // low - high is a range of numbers, inclusive\n+ // need to check each number for rabbit status\n+ let rabbitCounter = 0;\n+ for (let current = low; current < high + 1; current++) {\n+ // check if each number is a rabbit number\n+ if (Math.pow(sumDigits(current), 2) === sumDigits(Math.pow(current, 2))) {","path":"programming/p1_count_rabbits.js","position":10,"original_position":10,"commit_id":"862d224b526757b1c2668a1373ea589adb8a4286","original_commit_id":"862d224b526757b1c2668a1373ea589adb8a4286","user":{"login":"amgando","id":24913,"node_id":"MDQ6VXNlcjI0OTEz","avatar_url":"https://avatars0.githubusercontent.com/u/24913?v=4","gravatar_id":"","url":"https://api.github.com/users/amgando","html_url":"https://github.com/amgando","followers_url":"https://api.github.com/users/amgando/followers","following_url":"https://api.github.com/users/amgando/following{/other_user}","gists_url":"https://api.github.com/users/amgando/gists{/gist_id}","starred_url":"https://api.github.com/users/amgando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amgando/subscriptions","organizations_url":"https://api.github.com/users/amgando/orgs","repos_url":"https://api.github.com/users/amgando/repos","events_url":"https://api.github.com/users/amgando/events{/privacy}","received_events_url":"https://api.github.com/users/amgando/received_events","type":"User","site_admin":false},"body":"this would be better as a helper function","created_at":"2019-08-07T22:49:34Z","updated_at":"2019-08-07T22:49:35Z","html_url":"https://github.com/adjacent-academies/cis-121-final/pull/1#discussion_r311794541","pull_request_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/comments/311794541"},"html":{"href":"https://github.com/adjacent-academies/cis-121-final/pull/1#discussion_r311794541"},"pull_request":{"href":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/1","id":305347132,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1MzQ3MTMy","html_url":"https://github.com/adjacent-academies/cis-121-final/pull/1","diff_url":"https://github.com/adjacent-academies/cis-121-final/pull/1.diff","patch_url":"https://github.com/adjacent-academies/cis-121-final/pull/1.patch","issue_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues/1","number":1,"state":"open","locked":false,"title":"Wilson Goode submission","user":{"login":"amgando","id":24913,"node_id":"MDQ6VXNlcjI0OTEz","avatar_url":"https://avatars0.githubusercontent.com/u/24913?v=4","gravatar_id":"","url":"https://api.github.com/users/amgando","html_url":"https://github.com/amgando","followers_url":"https://api.github.com/users/amgando/followers","following_url":"https://api.github.com/users/amgando/following{/other_user}","gists_url":"https://api.github.com/users/amgando/gists{/gist_id}","starred_url":"https://api.github.com/users/amgando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amgando/subscriptions","organizations_url":"https://api.github.com/users/amgando/orgs","repos_url":"https://api.github.com/users/amgando/repos","events_url":"https://api.github.com/users/amgando/events{/privacy}","received_events_url":"https://api.github.com/users/amgando/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-07T22:48:14Z","updated_at":"2019-08-07T22:49:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"amgando","id":24913,"node_id":"MDQ6VXNlcjI0OTEz","avatar_url":"https://avatars0.githubusercontent.com/u/24913?v=4","gravatar_id":"","url":"https://api.github.com/users/amgando","html_url":"https://github.com/amgando","followers_url":"https://api.github.com/users/amgando/followers","following_url":"https://api.github.com/users/amgando/following{/other_user}","gists_url":"https://api.github.com/users/amgando/gists{/gist_id}","starred_url":"https://api.github.com/users/amgando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amgando/subscriptions","organizations_url":"https://api.github.com/users/amgando/orgs","repos_url":"https://api.github.com/users/amgando/repos","events_url":"https://api.github.com/users/amgando/events{/privacy}","received_events_url":"https://api.github.com/users/amgando/received_events","type":"User","site_admin":false},"assignees":[{"login":"amgando","id":24913,"node_id":"MDQ6VXNlcjI0OTEz","avatar_url":"https://avatars0.githubusercontent.com/u/24913?v=4","gravatar_id":"","url":"https://api.github.com/users/amgando","html_url":"https://github.com/amgando","followers_url":"https://api.github.com/users/amgando/followers","following_url":"https://api.github.com/users/amgando/following{/other_user}","gists_url":"https://api.github.com/users/amgando/gists{/gist_id}","starred_url":"https://api.github.com/users/amgando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amgando/subscriptions","organizations_url":"https://api.github.com/users/amgando/orgs","repos_url":"https://api.github.com/users/amgando/repos","events_url":"https://api.github.com/users/amgando/events{/privacy}","received_events_url":"https://api.github.com/users/amgando/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/1/commits","review_comments_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/1/comments","review_comment_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues/1/comments","statuses_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/statuses/862d224b526757b1c2668a1373ea589adb8a4286","head":{"label":"adjacent-academies:wilson-goode","ref":"wilson-goode","sha":"862d224b526757b1c2668a1373ea589adb8a4286","user":{"login":"adjacent-academies","id":53102211,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTAyMjEx","avatar_url":"https://avatars2.githubusercontent.com/u/53102211?v=4","gravatar_id":"","url":"https://api.github.com/users/adjacent-academies","html_url":"https://github.com/adjacent-academies","followers_url":"https://api.github.com/users/adjacent-academies/followers","following_url":"https://api.github.com/users/adjacent-academies/following{/other_user}","gists_url":"https://api.github.com/users/adjacent-academies/gists{/gist_id}","starred_url":"https://api.github.com/users/adjacent-academies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjacent-academies/subscriptions","organizations_url":"https://api.github.com/users/adjacent-academies/orgs","repos_url":"https://api.github.com/users/adjacent-academies/repos","events_url":"https://api.github.com/users/adjacent-academies/events{/privacy}","received_events_url":"https://api.github.com/users/adjacent-academies/received_events","type":"Organization","site_admin":false},"repo":{"id":200895374,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA4OTUzNzQ=","name":"cis-121-final","full_name":"adjacent-academies/cis-121-final","private":false,"owner":{"login":"adjacent-academies","id":53102211,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTAyMjEx","avatar_url":"https://avatars2.githubusercontent.com/u/53102211?v=4","gravatar_id":"","url":"https://api.github.com/users/adjacent-academies","html_url":"https://github.com/adjacent-academies","followers_url":"https://api.github.com/users/adjacent-academies/followers","following_url":"https://api.github.com/users/adjacent-academies/following{/other_user}","gists_url":"https://api.github.com/users/adjacent-academies/gists{/gist_id}","starred_url":"https://api.github.com/users/adjacent-academies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjacent-academies/subscriptions","organizations_url":"https://api.github.com/users/adjacent-academies/orgs","repos_url":"https://api.github.com/users/adjacent-academies/repos","events_url":"https://api.github.com/users/adjacent-academies/events{/privacy}","received_events_url":"https://api.github.com/users/adjacent-academies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adjacent-academies/cis-121-final","description":null,"fork":false,"url":"https://api.github.com/repos/adjacent-academies/cis-121-final","forks_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/forks","keys_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/teams","hooks_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/hooks","issue_events_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues/events{/number}","events_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/events","assignees_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/assignees{/user}","branches_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/branches{/branch}","tags_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/tags","blobs_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/refs{/sha}","trees_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/statuses/{sha}","languages_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/languages","stargazers_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/stargazers","contributors_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/contributors","subscribers_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/subscribers","subscription_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/subscription","commits_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/commits{/sha}","git_commits_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/commits{/sha}","comments_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/comments{/number}","issue_comment_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues/comments{/number}","contents_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/contents/{+path}","compare_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/merges","archive_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/downloads","issues_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues{/number}","pulls_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls{/number}","milestones_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/milestones{/number}","notifications_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/labels{/name}","releases_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/releases{/id}","deployments_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/deployments","created_at":"2019-08-06T17:25:17Z","updated_at":"2019-08-07T18:41:09Z","pushed_at":"2019-08-07T22:48:14Z","git_url":"git://github.com/adjacent-academies/cis-121-final.git","ssh_url":"[email protected]:adjacent-academies/cis-121-final.git","clone_url":"https://github.com/adjacent-academies/cis-121-final.git","svn_url":"https://github.com/adjacent-academies/cis-121-final","homepage":null,"size":416,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"adjacent-academies:master","ref":"master","sha":"4c38742620f8aa98a48bf23c14fc3702c803ecc3","user":{"login":"adjacent-academies","id":53102211,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTAyMjEx","avatar_url":"https://avatars2.githubusercontent.com/u/53102211?v=4","gravatar_id":"","url":"https://api.github.com/users/adjacent-academies","html_url":"https://github.com/adjacent-academies","followers_url":"https://api.github.com/users/adjacent-academies/followers","following_url":"https://api.github.com/users/adjacent-academies/following{/other_user}","gists_url":"https://api.github.com/users/adjacent-academies/gists{/gist_id}","starred_url":"https://api.github.com/users/adjacent-academies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjacent-academies/subscriptions","organizations_url":"https://api.github.com/users/adjacent-academies/orgs","repos_url":"https://api.github.com/users/adjacent-academies/repos","events_url":"https://api.github.com/users/adjacent-academies/events{/privacy}","received_events_url":"https://api.github.com/users/adjacent-academies/received_events","type":"Organization","site_admin":false},"repo":{"id":200895374,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA4OTUzNzQ=","name":"cis-121-final","full_name":"adjacent-academies/cis-121-final","private":false,"owner":{"login":"adjacent-academies","id":53102211,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTAyMjEx","avatar_url":"https://avatars2.githubusercontent.com/u/53102211?v=4","gravatar_id":"","url":"https://api.github.com/users/adjacent-academies","html_url":"https://github.com/adjacent-academies","followers_url":"https://api.github.com/users/adjacent-academies/followers","following_url":"https://api.github.com/users/adjacent-academies/following{/other_user}","gists_url":"https://api.github.com/users/adjacent-academies/gists{/gist_id}","starred_url":"https://api.github.com/users/adjacent-academies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adjacent-academies/subscriptions","organizations_url":"https://api.github.com/users/adjacent-academies/orgs","repos_url":"https://api.github.com/users/adjacent-academies/repos","events_url":"https://api.github.com/users/adjacent-academies/events{/privacy}","received_events_url":"https://api.github.com/users/adjacent-academies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adjacent-academies/cis-121-final","description":null,"fork":false,"url":"https://api.github.com/repos/adjacent-academies/cis-121-final","forks_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/forks","keys_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/teams","hooks_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/hooks","issue_events_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues/events{/number}","events_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/events","assignees_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/assignees{/user}","branches_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/branches{/branch}","tags_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/tags","blobs_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/refs{/sha}","trees_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/statuses/{sha}","languages_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/languages","stargazers_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/stargazers","contributors_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/contributors","subscribers_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/subscribers","subscription_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/subscription","commits_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/commits{/sha}","git_commits_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/git/commits{/sha}","comments_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/comments{/number}","issue_comment_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues/comments{/number}","contents_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/contents/{+path}","compare_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/merges","archive_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/downloads","issues_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues{/number}","pulls_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls{/number}","milestones_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/milestones{/number}","notifications_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/labels{/name}","releases_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/releases{/id}","deployments_url":"https://api.github.com/repos/adjacent-academies/cis-121-final/deployments","created_at":"2019-08-06T17:25:17Z","updated_at":"2019-08-07T18:41:09Z","pushed_at":"2019-08-07T22:48:14Z","git_url":"git://github.com/adjacent-academies/cis-121-final.git","ssh_url":"[email protected]:adjacent-academies/cis-121-final.git","clone_url":"https://github.com/adjacent-academies/cis-121-final.git","svn_url":"https://github.com/adjacent-academies/cis-121-final","homepage":null,"size":416,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/1"},"html":{"href":"https://github.com/adjacent-academies/cis-121-final/pull/1"},"issue":{"href":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues/1"},"comments":{"href":"https://api.github.com/repos/adjacent-academies/cis-121-final/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adjacent-academies/cis-121-final/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/adjacent-academies/cis-121-final/statuses/862d224b526757b1c2668a1373ea589adb8a4286"}},"author_association":"COLLABORATOR"}}
|
{
"id": 200895374,
"name": "adjacent-academies/cis-121-final",
"url": "https://api.github.com/repos/adjacent-academies/cis-121-final"
}
|
{
"id": 24913,
"login": "amgando",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24913?",
"url": "https://api.github.com/users/amgando"
}
|
{
"id": 53102211,
"login": "adjacent-academies",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53102211?",
"url": "https://api.github.com/orgs/adjacent-academies"
}
| 2019-08-07T22:49:34 |
10169064095
|
{"actor":{"display_login":"amgando"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/comments/342069564","pull_request_review_id":311095302,"id":342069564,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MjA2OTU2NA==","diff_hunk":"@@ -0,0 +1,91 @@\n+<template>\n+ <div class=\"newsletter\">\n+ <div class=\"newsletter_wrapper\">\n+ <div class=\"newsletter_content newsletter_header\">\n+ <h3 class=\"title\" v-html=\"content.title || capitalize\"></h3>\n+ <div class=\"text\" v-html=\"content.text\"></div>\n+ </div>\n+ <div v-if=\"this.$slots.body\" class=\"newsletter_content newsletter_body\">\n+ <slot name=\"body\"></slot>\n+ </div>\n+ <div class=\"newsletter_content newsletter_footer\">\n+ <form class=\"form form--newsletter\" @submit.prevent=\"handleSubscribe\">\n+ <div class=\"form_field\">\n+ <v-input\n+ placeholderTxt=\"Email Address\"\n+ inputType=\"email\"\n+ inputName=\"email\"\n+ minlength=\"3\"\n+ v-model=\"emailValue\"\n+ />\n+ </div>\n+ <div class=\"form_control\">\n+ <button type=\"submit\" class=\"btn btn--primary\">Subscribe</button>\n+ </div>\n+ </form>\n+ </div>\n+ </div>\n+ </div>\n+</template>\n+\n+<script>\n+import BaseInput from '@/components/BaseInput'\n+// import MailchimpService from '../api/newsletterService'\n+\n+export default {\n+ name: 'Newsletter',\n+ data () {\n+ return {\n+ emailValue: ''\n+ }\n+ },\n+ filters: {\n+ capitalize: content => {\n+ return content.toUpperCase()\n+ }\n+ },\n+ props: {\n+ content: {\n+ type: Object\n+ }\n+ },\n+ components: {\n+ 'v-input': BaseInput\n+ },\n+ methods: {\n+ handleSubscribe () {\n+ const api = 'https://mailinglist-257716.firebaseio.com/subscribers.json'","path":"src/components/Newsletter.vue","position":57,"original_position":57,"commit_id":"6d109332bd702bf281776aa5d599f20ea298f7a8","original_commit_id":"eb6d7599b88a30f516f2a5da73ba31195d7b368f","user":{"login":"PauloGabrielSousa","id":55989152,"node_id":"MDQ6VXNlcjU1OTg5MTUy","avatar_url":"https://avatars0.githubusercontent.com/u/55989152?v=4","gravatar_id":"","url":"https://api.github.com/users/PauloGabrielSousa","html_url":"https://github.com/PauloGabrielSousa","followers_url":"https://api.github.com/users/PauloGabrielSousa/followers","following_url":"https://api.github.com/users/PauloGabrielSousa/following{/other_user}","gists_url":"https://api.github.com/users/PauloGabrielSousa/gists{/gist_id}","starred_url":"https://api.github.com/users/PauloGabrielSousa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PauloGabrielSousa/subscriptions","organizations_url":"https://api.github.com/users/PauloGabrielSousa/orgs","repos_url":"https://api.github.com/users/PauloGabrielSousa/repos","events_url":"https://api.github.com/users/PauloGabrielSousa/events{/privacy}","received_events_url":"https://api.github.com/users/PauloGabrielSousa/received_events","type":"User","site_admin":false},"body":"Nรฃo รฉ recomendรกvel usar cรณdigo fixo na aplicaรงรฃo.","created_at":"2019-11-04T14:15:39Z","updated_at":"2019-11-04T14:15:40Z","html_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp/pull/13#discussion_r342069564","pull_request_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/13","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/comments/342069564"},"html":{"href":"https://github.com/4cadia-foundation/4cadia-governance-webapp/pull/13#discussion_r342069564"},"pull_request":{"href":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/13","id":335622849,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM1NjIyODQ5","html_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp/pull/13","diff_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp/pull/13.diff","patch_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp/pull/13.patch","issue_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues/13","number":13,"state":"open","locked":false,"title":"Use firebase to store emails","user":{"login":"jcbombardelli","id":3885020,"node_id":"MDQ6VXNlcjM4ODUwMjA=","avatar_url":"https://avatars1.githubusercontent.com/u/3885020?v=4","gravatar_id":"","url":"https://api.github.com/users/jcbombardelli","html_url":"https://github.com/jcbombardelli","followers_url":"https://api.github.com/users/jcbombardelli/followers","following_url":"https://api.github.com/users/jcbombardelli/following{/other_user}","gists_url":"https://api.github.com/users/jcbombardelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jcbombardelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcbombardelli/subscriptions","organizations_url":"https://api.github.com/users/jcbombardelli/orgs","repos_url":"https://api.github.com/users/jcbombardelli/repos","events_url":"https://api.github.com/users/jcbombardelli/events{/privacy}","received_events_url":"https://api.github.com/users/jcbombardelli/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-01T21:25:13Z","updated_at":"2019-11-04T14:15:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3ac6edf17412aeccfab53c959a714fbb9473a2c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/13/commits","review_comments_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/13/comments","review_comment_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues/13/comments","statuses_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/statuses/6d109332bd702bf281776aa5d599f20ea298f7a8","head":{"label":"4cadia-foundation:GOV-158","ref":"GOV-158","sha":"6d109332bd702bf281776aa5d599f20ea298f7a8","user":{"login":"4cadia-foundation","id":53494375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDk0Mzc1","avatar_url":"https://avatars3.githubusercontent.com/u/53494375?v=4","gravatar_id":"","url":"https://api.github.com/users/4cadia-foundation","html_url":"https://github.com/4cadia-foundation","followers_url":"https://api.github.com/users/4cadia-foundation/followers","following_url":"https://api.github.com/users/4cadia-foundation/following{/other_user}","gists_url":"https://api.github.com/users/4cadia-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/4cadia-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4cadia-foundation/subscriptions","organizations_url":"https://api.github.com/users/4cadia-foundation/orgs","repos_url":"https://api.github.com/users/4cadia-foundation/repos","events_url":"https://api.github.com/users/4cadia-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/4cadia-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":212124342,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIxMjQzNDI=","name":"4cadia-governance-webapp","full_name":"4cadia-foundation/4cadia-governance-webapp","private":false,"owner":{"login":"4cadia-foundation","id":53494375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDk0Mzc1","avatar_url":"https://avatars3.githubusercontent.com/u/53494375?v=4","gravatar_id":"","url":"https://api.github.com/users/4cadia-foundation","html_url":"https://github.com/4cadia-foundation","followers_url":"https://api.github.com/users/4cadia-foundation/followers","following_url":"https://api.github.com/users/4cadia-foundation/following{/other_user}","gists_url":"https://api.github.com/users/4cadia-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/4cadia-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4cadia-foundation/subscriptions","organizations_url":"https://api.github.com/users/4cadia-foundation/orgs","repos_url":"https://api.github.com/users/4cadia-foundation/repos","events_url":"https://api.github.com/users/4cadia-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/4cadia-foundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp","description":null,"fork":false,"url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp","forks_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/forks","keys_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/teams","hooks_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/hooks","issue_events_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/events","assignees_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/tags","blobs_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/languages","stargazers_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/stargazers","contributors_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/contributors","subscribers_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/subscribers","subscription_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/subscription","commits_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/merges","archive_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/downloads","issues_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/labels{/name}","releases_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/deployments","created_at":"2019-10-01T14:57:09Z","updated_at":"2019-11-01T12:59:04Z","pushed_at":"2019-11-01T21:25:14Z","git_url":"git://github.com/4cadia-foundation/4cadia-governance-webapp.git","ssh_url":"[email protected]:4cadia-foundation/4cadia-governance-webapp.git","clone_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp.git","svn_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp","homepage":null,"size":5119,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"4cadia-foundation:develop","ref":"develop","sha":"198144917a58096068ccca141a566b37299b7332","user":{"login":"4cadia-foundation","id":53494375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDk0Mzc1","avatar_url":"https://avatars3.githubusercontent.com/u/53494375?v=4","gravatar_id":"","url":"https://api.github.com/users/4cadia-foundation","html_url":"https://github.com/4cadia-foundation","followers_url":"https://api.github.com/users/4cadia-foundation/followers","following_url":"https://api.github.com/users/4cadia-foundation/following{/other_user}","gists_url":"https://api.github.com/users/4cadia-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/4cadia-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4cadia-foundation/subscriptions","organizations_url":"https://api.github.com/users/4cadia-foundation/orgs","repos_url":"https://api.github.com/users/4cadia-foundation/repos","events_url":"https://api.github.com/users/4cadia-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/4cadia-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":212124342,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIxMjQzNDI=","name":"4cadia-governance-webapp","full_name":"4cadia-foundation/4cadia-governance-webapp","private":false,"owner":{"login":"4cadia-foundation","id":53494375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNDk0Mzc1","avatar_url":"https://avatars3.githubusercontent.com/u/53494375?v=4","gravatar_id":"","url":"https://api.github.com/users/4cadia-foundation","html_url":"https://github.com/4cadia-foundation","followers_url":"https://api.github.com/users/4cadia-foundation/followers","following_url":"https://api.github.com/users/4cadia-foundation/following{/other_user}","gists_url":"https://api.github.com/users/4cadia-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/4cadia-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4cadia-foundation/subscriptions","organizations_url":"https://api.github.com/users/4cadia-foundation/orgs","repos_url":"https://api.github.com/users/4cadia-foundation/repos","events_url":"https://api.github.com/users/4cadia-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/4cadia-foundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp","description":null,"fork":false,"url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp","forks_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/forks","keys_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/teams","hooks_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/hooks","issue_events_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/events","assignees_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/tags","blobs_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/languages","stargazers_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/stargazers","contributors_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/contributors","subscribers_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/subscribers","subscription_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/subscription","commits_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/merges","archive_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/downloads","issues_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/labels{/name}","releases_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/deployments","created_at":"2019-10-01T14:57:09Z","updated_at":"2019-11-01T12:59:04Z","pushed_at":"2019-11-01T21:25:14Z","git_url":"git://github.com/4cadia-foundation/4cadia-governance-webapp.git","ssh_url":"[email protected]:4cadia-foundation/4cadia-governance-webapp.git","clone_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp.git","svn_url":"https://github.com/4cadia-foundation/4cadia-governance-webapp","homepage":null,"size":5119,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/13"},"html":{"href":"https://github.com/4cadia-foundation/4cadia-governance-webapp/pull/13"},"issue":{"href":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues/13"},"comments":{"href":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp/statuses/6d109332bd702bf281776aa5d599f20ea298f7a8"}},"author_association":"MEMBER"}}
|
{
"id": 212124342,
"name": "4cadia-foundation/4cadia-governance-webapp",
"url": "https://api.github.com/repos/4cadia-foundation/4cadia-governance-webapp"
}
|
{
"id": 55989152,
"login": "PauloGabrielSousa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55989152?",
"url": "https://api.github.com/users/PauloGabrielSousa"
}
|
{
"id": 53494375,
"login": "4cadia-foundation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53494375?",
"url": "https://api.github.com/orgs/4cadia-foundation"
}
| 2019-11-04T14:15:39 |
10781072282
|
{"actor":{"display_login":"PauloGabrielSousa"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/comments/311131190","pull_request_review_id":271433521,"id":311131190,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTEzMTE5MA==","diff_hunk":"@@ -54,19 +93,29 @@ inline bool Vec<T>::is_empty() {\n \n template <typename T>\n void Vec<T>::push(T data) {\n- T* new_buf = new T[this->len + 1];\n- std::copy(this->buf, this->buf + this->len, new_buf);\n- new_buf[this->len] = data;\n-\n- delete[] this->buf;\n-\n- this->buf = new_buf;\n- this->len++;\n+ size_t total = this->len + 1;\n+ if (total > this->_capacity) {\n+ if (this->_capacity == 0) {\n+ this->_capacity = 1;\n+ } else {\n+ this->_capacity = this->_capacity * 2;\n+ }\n+ reallocate(this->_capacity);\n+ }\n+ buf[this->len++] = data;\n }\n \n template <typename T>\n-std::optional<T> Vec<T>::pop() {\n- if (this->len > 0) return this->buf[this->len-- - 1];\n+std::optional<T> Vec<T>::pop() noexcept {\n+ if (this->len > 0) {\n+ T return_val = this->buf[this->len-- - 1];\n+ if (this->len == 0) {\n+ reallocate(0);\n+ } else if ((this->_capacity / this->len) > 4) {","path":"src/collections/vector.h","position":119,"original_position":119,"commit_id":"a8c040b5ef4a52e163ae59b3efd929b7f30806eb","original_commit_id":"a8c040b5ef4a52e163ae59b3efd929b7f30806eb","user":{"login":"iosmanthus","id":16307070,"node_id":"MDQ6VXNlcjE2MzA3MDcw","avatar_url":"https://avatars2.githubusercontent.com/u/16307070?v=4","gravatar_id":"","url":"https://api.github.com/users/iosmanthus","html_url":"https://github.com/iosmanthus","followers_url":"https://api.github.com/users/iosmanthus/followers","following_url":"https://api.github.com/users/iosmanthus/following{/other_user}","gists_url":"https://api.github.com/users/iosmanthus/gists{/gist_id}","starred_url":"https://api.github.com/users/iosmanthus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iosmanthus/subscriptions","organizations_url":"https://api.github.com/users/iosmanthus/orgs","repos_url":"https://api.github.com/users/iosmanthus/repos","events_url":"https://api.github.com/users/iosmanthus/events{/privacy}","received_events_url":"https://api.github.com/users/iosmanthus/received_events","type":"User","site_admin":false},"body":"prefer use `<<` or `*` to avoid `/`","created_at":"2019-08-06T15:33:07Z","updated_at":"2019-08-06T15:33:08Z","html_url":"https://github.com/0xffff-one/0xffff-lib/pull/2#discussion_r311131190","pull_request_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/comments/311131190"},"html":{"href":"https://github.com/0xffff-one/0xffff-lib/pull/2#discussion_r311131190"},"pull_request":{"href":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/2","id":304076093,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0MDc2MDkz","html_url":"https://github.com/0xffff-one/0xffff-lib/pull/2","diff_url":"https://github.com/0xffff-one/0xffff-lib/pull/2.diff","patch_url":"https://github.com/0xffff-one/0xffff-lib/pull/2.patch","issue_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/issues/2","number":2,"state":"open","locked":false,"title":"collections/vector: implement dynamic table described in `CLRS`","user":{"login":"fengkx","id":16515468,"node_id":"MDQ6VXNlcjE2NTE1NDY4","avatar_url":"https://avatars0.githubusercontent.com/u/16515468?v=4","gravatar_id":"","url":"https://api.github.com/users/fengkx","html_url":"https://github.com/fengkx","followers_url":"https://api.github.com/users/fengkx/followers","following_url":"https://api.github.com/users/fengkx/following{/other_user}","gists_url":"https://api.github.com/users/fengkx/gists{/gist_id}","starred_url":"https://api.github.com/users/fengkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengkx/subscriptions","organizations_url":"https://api.github.com/users/fengkx/orgs","repos_url":"https://api.github.com/users/fengkx/repos","events_url":"https://api.github.com/users/fengkx/events{/privacy}","received_events_url":"https://api.github.com/users/fengkx/received_events","type":"User","site_admin":false},"body":"Fix issue #1 ","created_at":"2019-08-04T15:35:10Z","updated_at":"2019-08-06T15:33:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b16203e7d77abf50f1b13b31313066d6ef2a3c9e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/2/commits","review_comments_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/2/comments","review_comment_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/issues/2/comments","statuses_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/statuses/a8c040b5ef4a52e163ae59b3efd929b7f30806eb","head":{"label":"fengkx:feat/dynamic-grow-capity","ref":"feat/dynamic-grow-capity","sha":"a8c040b5ef4a52e163ae59b3efd929b7f30806eb","user":{"login":"fengkx","id":16515468,"node_id":"MDQ6VXNlcjE2NTE1NDY4","avatar_url":"https://avatars0.githubusercontent.com/u/16515468?v=4","gravatar_id":"","url":"https://api.github.com/users/fengkx","html_url":"https://github.com/fengkx","followers_url":"https://api.github.com/users/fengkx/followers","following_url":"https://api.github.com/users/fengkx/following{/other_user}","gists_url":"https://api.github.com/users/fengkx/gists{/gist_id}","starred_url":"https://api.github.com/users/fengkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengkx/subscriptions","organizations_url":"https://api.github.com/users/fengkx/orgs","repos_url":"https://api.github.com/users/fengkx/repos","events_url":"https://api.github.com/users/fengkx/events{/privacy}","received_events_url":"https://api.github.com/users/fengkx/received_events","type":"User","site_admin":false},"repo":{"id":200487595,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA0ODc1OTU=","name":"0xffff-lib","full_name":"fengkx/0xffff-lib","private":false,"owner":{"login":"fengkx","id":16515468,"node_id":"MDQ6VXNlcjE2NTE1NDY4","avatar_url":"https://avatars0.githubusercontent.com/u/16515468?v=4","gravatar_id":"","url":"https://api.github.com/users/fengkx","html_url":"https://github.com/fengkx","followers_url":"https://api.github.com/users/fengkx/followers","following_url":"https://api.github.com/users/fengkx/following{/other_user}","gists_url":"https://api.github.com/users/fengkx/gists{/gist_id}","starred_url":"https://api.github.com/users/fengkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengkx/subscriptions","organizations_url":"https://api.github.com/users/fengkx/orgs","repos_url":"https://api.github.com/users/fengkx/repos","events_url":"https://api.github.com/users/fengkx/events{/privacy}","received_events_url":"https://api.github.com/users/fengkx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fengkx/0xffff-lib","description":"0xffff-lib, a low level core library ","fork":true,"url":"https://api.github.com/repos/fengkx/0xffff-lib","forks_url":"https://api.github.com/repos/fengkx/0xffff-lib/forks","keys_url":"https://api.github.com/repos/fengkx/0xffff-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fengkx/0xffff-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fengkx/0xffff-lib/teams","hooks_url":"https://api.github.com/repos/fengkx/0xffff-lib/hooks","issue_events_url":"https://api.github.com/repos/fengkx/0xffff-lib/issues/events{/number}","events_url":"https://api.github.com/repos/fengkx/0xffff-lib/events","assignees_url":"https://api.github.com/repos/fengkx/0xffff-lib/assignees{/user}","branches_url":"https://api.github.com/repos/fengkx/0xffff-lib/branches{/branch}","tags_url":"https://api.github.com/repos/fengkx/0xffff-lib/tags","blobs_url":"https://api.github.com/repos/fengkx/0xffff-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fengkx/0xffff-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fengkx/0xffff-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/fengkx/0xffff-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fengkx/0xffff-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/fengkx/0xffff-lib/languages","stargazers_url":"https://api.github.com/repos/fengkx/0xffff-lib/stargazers","contributors_url":"https://api.github.com/repos/fengkx/0xffff-lib/contributors","subscribers_url":"https://api.github.com/repos/fengkx/0xffff-lib/subscribers","subscription_url":"https://api.github.com/repos/fengkx/0xffff-lib/subscription","commits_url":"https://api.github.com/repos/fengkx/0xffff-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/fengkx/0xffff-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/fengkx/0xffff-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/fengkx/0xffff-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/fengkx/0xffff-lib/contents/{+path}","compare_url":"https://api.github.com/repos/fengkx/0xffff-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fengkx/0xffff-lib/merges","archive_url":"https://api.github.com/repos/fengkx/0xffff-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fengkx/0xffff-lib/downloads","issues_url":"https://api.github.com/repos/fengkx/0xffff-lib/issues{/number}","pulls_url":"https://api.github.com/repos/fengkx/0xffff-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/fengkx/0xffff-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/fengkx/0xffff-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fengkx/0xffff-lib/labels{/name}","releases_url":"https://api.github.com/repos/fengkx/0xffff-lib/releases{/id}","deployments_url":"https://api.github.com/repos/fengkx/0xffff-lib/deployments","created_at":"2019-08-04T12:04:02Z","updated_at":"2019-08-04T12:04:05Z","pushed_at":"2019-08-06T14:58:34Z","git_url":"git://github.com/fengkx/0xffff-lib.git","ssh_url":"[email protected]:fengkx/0xffff-lib.git","clone_url":"https://github.com/fengkx/0xffff-lib.git","svn_url":"https://github.com/fengkx/0xffff-lib","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"0xffff-one:master","ref":"master","sha":"cc1880af99a5b82a98f22ef3201028a38530cc70","user":{"login":"0xffff-one","id":53567536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNTY3NTM2","avatar_url":"https://avatars3.githubusercontent.com/u/53567536?v=4","gravatar_id":"","url":"https://api.github.com/users/0xffff-one","html_url":"https://github.com/0xffff-one","followers_url":"https://api.github.com/users/0xffff-one/followers","following_url":"https://api.github.com/users/0xffff-one/following{/other_user}","gists_url":"https://api.github.com/users/0xffff-one/gists{/gist_id}","starred_url":"https://api.github.com/users/0xffff-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xffff-one/subscriptions","organizations_url":"https://api.github.com/users/0xffff-one/orgs","repos_url":"https://api.github.com/users/0xffff-one/repos","events_url":"https://api.github.com/users/0xffff-one/events{/privacy}","received_events_url":"https://api.github.com/users/0xffff-one/received_events","type":"Organization","site_admin":false},"repo":{"id":200051153,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAwNTExNTM=","name":"0xffff-lib","full_name":"0xffff-one/0xffff-lib","private":false,"owner":{"login":"0xffff-one","id":53567536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNTY3NTM2","avatar_url":"https://avatars3.githubusercontent.com/u/53567536?v=4","gravatar_id":"","url":"https://api.github.com/users/0xffff-one","html_url":"https://github.com/0xffff-one","followers_url":"https://api.github.com/users/0xffff-one/followers","following_url":"https://api.github.com/users/0xffff-one/following{/other_user}","gists_url":"https://api.github.com/users/0xffff-one/gists{/gist_id}","starred_url":"https://api.github.com/users/0xffff-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xffff-one/subscriptions","organizations_url":"https://api.github.com/users/0xffff-one/orgs","repos_url":"https://api.github.com/users/0xffff-one/repos","events_url":"https://api.github.com/users/0xffff-one/events{/privacy}","received_events_url":"https://api.github.com/users/0xffff-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/0xffff-one/0xffff-lib","description":"0xffff-lib, a low level core library ","fork":false,"url":"https://api.github.com/repos/0xffff-one/0xffff-lib","forks_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/forks","keys_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/teams","hooks_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/hooks","issue_events_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/issues/events{/number}","events_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/events","assignees_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/assignees{/user}","branches_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/branches{/branch}","tags_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/tags","blobs_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/languages","stargazers_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/stargazers","contributors_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/contributors","subscribers_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/subscribers","subscription_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/subscription","commits_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/contents/{+path}","compare_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/merges","archive_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/downloads","issues_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/issues{/number}","pulls_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/labels{/name}","releases_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/releases{/id}","deployments_url":"https://api.github.com/repos/0xffff-one/0xffff-lib/deployments","created_at":"2019-08-01T12:58:42Z","updated_at":"2019-08-06T15:01:29Z","pushed_at":"2019-08-06T14:58:36Z","git_url":"git://github.com/0xffff-one/0xffff-lib.git","ssh_url":"[email protected]:0xffff-one/0xffff-lib.git","clone_url":"https://github.com/0xffff-one/0xffff-lib.git","svn_url":"https://github.com/0xffff-one/0xffff-lib","homepage":null,"size":18,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":7,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/2"},"html":{"href":"https://github.com/0xffff-one/0xffff-lib/pull/2"},"issue":{"href":"https://api.github.com/repos/0xffff-one/0xffff-lib/issues/2"},"comments":{"href":"https://api.github.com/repos/0xffff-one/0xffff-lib/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xffff-one/0xffff-lib/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/0xffff-one/0xffff-lib/statuses/a8c040b5ef4a52e163ae59b3efd929b7f30806eb"}},"author_association":"NONE"}}
|
{
"id": 200051153,
"name": "0xffff-one/0xffff-lib",
"url": "https://api.github.com/repos/0xffff-one/0xffff-lib"
}
|
{
"id": 16307070,
"login": "iosmanthus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16307070?",
"url": "https://api.github.com/users/iosmanthus"
}
|
{
"id": 53567536,
"login": "0xffff-one",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53567536?",
"url": "https://api.github.com/orgs/0xffff-one"
}
| 2019-08-06T15:33:07 |
10157846555
|
{"actor":{"display_login":"iosmanthus"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/comments/342357901","pull_request_review_id":311471023,"id":342357901,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MjM1NzkwMQ==","diff_hunk":"@@ -29,8 +30,8 @@ def test_fetch_311_data(self, MockSocrata): # noqa: N803\n client.get.assert_called_once()\n \n \[email protected](\"external.nyc311.fetch.fetch_311_data\", fetch_311_data_stub)\n class NYC311StatiscticsTests(TestCase):\n+ @mock.patch(\"external.nyc311.fetch.fetch_311_data\", fetch_311_data_stub)","path":"external/nyc311/tests.py","position":14,"original_position":14,"commit_id":"680da5472d2d8db8636d42d8c3a649e4aecdbd6c","original_commit_id":"680da5472d2d8db8636d42d8c3a649e4aecdbd6c","user":{"login":"alldne","id":3467350,"node_id":"MDQ6VXNlcjM0NjczNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3467350?v=4","gravatar_id":"","url":"https://api.github.com/users/alldne","html_url":"https://github.com/alldne","followers_url":"https://api.github.com/users/alldne/followers","following_url":"https://api.github.com/users/alldne/following{/other_user}","gists_url":"https://api.github.com/users/alldne/gists{/gist_id}","starred_url":"https://api.github.com/users/alldne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alldne/subscriptions","organizations_url":"https://api.github.com/users/alldne/orgs","repos_url":"https://api.github.com/users/alldne/repos","events_url":"https://api.github.com/users/alldne/events{/privacy}","received_events_url":"https://api.github.com/users/alldne/received_events","type":"User","site_admin":false},"body":"I guess the key difference is that I'm using `get_311_statistics` and patching `fetch_311_data`.","created_at":"2019-11-05T02:21:13Z","updated_at":"2019-11-05T02:21:13Z","html_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pull/172#discussion_r342357901","pull_request_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/172","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/comments/342357901"},"html":{"href":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pull/172#discussion_r342357901"},"pull_request":{"href":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/172"}},"in_reply_to_id":342354591},"pull_request":{"url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/172","id":336555016,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2NTU1MDE2","html_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pull/172","diff_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pull/172.diff","patch_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pull/172.patch","issue_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues/172","number":172,"state":"open","locked":false,"title":"Fix 311 and tests","user":{"login":"alldne","id":3467350,"node_id":"MDQ6VXNlcjM0NjczNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3467350?v=4","gravatar_id":"","url":"https://api.github.com/users/alldne","html_url":"https://github.com/alldne","followers_url":"https://api.github.com/users/alldne/followers","following_url":"https://api.github.com/users/alldne/following{/other_user}","gists_url":"https://api.github.com/users/alldne/gists{/gist_id}","starred_url":"https://api.github.com/users/alldne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alldne/subscriptions","organizations_url":"https://api.github.com/users/alldne/orgs","repos_url":"https://api.github.com/users/alldne/repos","events_url":"https://api.github.com/users/alldne/events{/privacy}","received_events_url":"https://api.github.com/users/alldne/received_events","type":"User","site_admin":false},"body":"- Some of our tests is making a request to nyc open data, which is supposed to be patched\r\n- Apparently 311 stat doesn't work for some input data\r\n- Our test results was inconsistent because it depends on live 311 data","created_at":"2019-11-05T01:24:41Z","updated_at":"2019-11-05T02:21:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02bcd58a63c16e06b32ed50174df6b94732de0c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/172/commits","review_comments_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/172/comments","review_comment_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues/172/comments","statuses_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/statuses/680da5472d2d8db8636d42d8c3a649e4aecdbd6c","head":{"label":"gcivil-nyu-org:fix-311","ref":"fix-311","sha":"680da5472d2d8db8636d42d8c3a649e4aecdbd6c","user":{"login":"gcivil-nyu-org","id":54147418,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTQ3NDE4","avatar_url":"https://avatars2.githubusercontent.com/u/54147418?v=4","gravatar_id":"","url":"https://api.github.com/users/gcivil-nyu-org","html_url":"https://github.com/gcivil-nyu-org","followers_url":"https://api.github.com/users/gcivil-nyu-org/followers","following_url":"https://api.github.com/users/gcivil-nyu-org/following{/other_user}","gists_url":"https://api.github.com/users/gcivil-nyu-org/gists{/gist_id}","starred_url":"https://api.github.com/users/gcivil-nyu-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcivil-nyu-org/subscriptions","organizations_url":"https://api.github.com/users/gcivil-nyu-org/orgs","repos_url":"https://api.github.com/users/gcivil-nyu-org/repos","events_url":"https://api.github.com/users/gcivil-nyu-org/events{/privacy}","received_events_url":"https://api.github.com/users/gcivil-nyu-org/received_events","type":"Organization","site_admin":false},"repo":{"id":208938451,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5Mzg0NTE=","name":"fall2019-cs-gy-6063-team-five_fries","full_name":"gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries","private":false,"owner":{"login":"gcivil-nyu-org","id":54147418,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTQ3NDE4","avatar_url":"https://avatars2.githubusercontent.com/u/54147418?v=4","gravatar_id":"","url":"https://api.github.com/users/gcivil-nyu-org","html_url":"https://github.com/gcivil-nyu-org","followers_url":"https://api.github.com/users/gcivil-nyu-org/followers","following_url":"https://api.github.com/users/gcivil-nyu-org/following{/other_user}","gists_url":"https://api.github.com/users/gcivil-nyu-org/gists{/gist_id}","starred_url":"https://api.github.com/users/gcivil-nyu-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcivil-nyu-org/subscriptions","organizations_url":"https://api.github.com/users/gcivil-nyu-org/orgs","repos_url":"https://api.github.com/users/gcivil-nyu-org/repos","events_url":"https://api.github.com/users/gcivil-nyu-org/events{/privacy}","received_events_url":"https://api.github.com/users/gcivil-nyu-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries","description":"Team Five Fries Project Repo, CS GY 6063 Fall 2019","fork":false,"url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries","forks_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/forks","keys_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/teams","hooks_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/hooks","issue_events_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues/events{/number}","events_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/events","assignees_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/assignees{/user}","branches_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/branches{/branch}","tags_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/tags","blobs_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/statuses/{sha}","languages_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/languages","stargazers_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/stargazers","contributors_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/contributors","subscribers_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/subscribers","subscription_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/subscription","commits_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/contents/{+path}","compare_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/merges","archive_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/downloads","issues_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues{/number}","pulls_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls{/number}","milestones_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/milestones{/number}","notifications_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/labels{/name}","releases_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/releases{/id}","deployments_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/deployments","created_at":"2019-09-17T02:11:10Z","updated_at":"2019-11-03T18:18:12Z","pushed_at":"2019-11-05T01:28:22Z","git_url":"git://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries.git","ssh_url":"[email protected]:gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries.git","clone_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries.git","svn_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries","homepage":null,"size":14770,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":64,"license":null,"forks":0,"open_issues":64,"watchers":0,"default_branch":"develop"}},"base":{"label":"gcivil-nyu-org:develop","ref":"develop","sha":"37747958dc553c8e32f72b70afd2b40c1993258a","user":{"login":"gcivil-nyu-org","id":54147418,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTQ3NDE4","avatar_url":"https://avatars2.githubusercontent.com/u/54147418?v=4","gravatar_id":"","url":"https://api.github.com/users/gcivil-nyu-org","html_url":"https://github.com/gcivil-nyu-org","followers_url":"https://api.github.com/users/gcivil-nyu-org/followers","following_url":"https://api.github.com/users/gcivil-nyu-org/following{/other_user}","gists_url":"https://api.github.com/users/gcivil-nyu-org/gists{/gist_id}","starred_url":"https://api.github.com/users/gcivil-nyu-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcivil-nyu-org/subscriptions","organizations_url":"https://api.github.com/users/gcivil-nyu-org/orgs","repos_url":"https://api.github.com/users/gcivil-nyu-org/repos","events_url":"https://api.github.com/users/gcivil-nyu-org/events{/privacy}","received_events_url":"https://api.github.com/users/gcivil-nyu-org/received_events","type":"Organization","site_admin":false},"repo":{"id":208938451,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5Mzg0NTE=","name":"fall2019-cs-gy-6063-team-five_fries","full_name":"gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries","private":false,"owner":{"login":"gcivil-nyu-org","id":54147418,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTQ3NDE4","avatar_url":"https://avatars2.githubusercontent.com/u/54147418?v=4","gravatar_id":"","url":"https://api.github.com/users/gcivil-nyu-org","html_url":"https://github.com/gcivil-nyu-org","followers_url":"https://api.github.com/users/gcivil-nyu-org/followers","following_url":"https://api.github.com/users/gcivil-nyu-org/following{/other_user}","gists_url":"https://api.github.com/users/gcivil-nyu-org/gists{/gist_id}","starred_url":"https://api.github.com/users/gcivil-nyu-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcivil-nyu-org/subscriptions","organizations_url":"https://api.github.com/users/gcivil-nyu-org/orgs","repos_url":"https://api.github.com/users/gcivil-nyu-org/repos","events_url":"https://api.github.com/users/gcivil-nyu-org/events{/privacy}","received_events_url":"https://api.github.com/users/gcivil-nyu-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries","description":"Team Five Fries Project Repo, CS GY 6063 Fall 2019","fork":false,"url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries","forks_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/forks","keys_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/teams","hooks_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/hooks","issue_events_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues/events{/number}","events_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/events","assignees_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/assignees{/user}","branches_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/branches{/branch}","tags_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/tags","blobs_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/statuses/{sha}","languages_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/languages","stargazers_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/stargazers","contributors_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/contributors","subscribers_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/subscribers","subscription_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/subscription","commits_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/contents/{+path}","compare_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/merges","archive_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/downloads","issues_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues{/number}","pulls_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls{/number}","milestones_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/milestones{/number}","notifications_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/labels{/name}","releases_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/releases{/id}","deployments_url":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/deployments","created_at":"2019-09-17T02:11:10Z","updated_at":"2019-11-03T18:18:12Z","pushed_at":"2019-11-05T01:28:22Z","git_url":"git://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries.git","ssh_url":"[email protected]:gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries.git","clone_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries.git","svn_url":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries","homepage":null,"size":14770,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":64,"license":null,"forks":0,"open_issues":64,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/172"},"html":{"href":"https://github.com/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pull/172"},"issue":{"href":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues/172"},"comments":{"href":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries/statuses/680da5472d2d8db8636d42d8c3a649e4aecdbd6c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 208938451,
"name": "gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries",
"url": "https://api.github.com/repos/gcivil-nyu-org/fall2019-cs-gy-6063-team-five_fries"
}
|
{
"id": 3467350,
"login": "alldne",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3467350?",
"url": "https://api.github.com/users/alldne"
}
|
{
"id": 54147418,
"login": "gcivil-nyu-org",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/54147418?",
"url": "https://api.github.com/orgs/gcivil-nyu-org"
}
| 2019-11-05T02:21:13 |
10786149949
|
{"actor":{"display_login":"alldne"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/comments/349016876","pull_request_review_id":320794058,"id":349016876,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0OTAxNjg3Ng==","diff_hunk":"@@ -0,0 +1,107 @@\n+# octant and antrea-octant-plugin installation\n+\n+## Overview\n+\n+There are two ways to deploy octant and antrea-octant-plugin.\n+\n+* Deploy octant and antrea-octant-plugin as a process (out of Kubernetes cluster).\n+\n+* Deploy octant and antrea-octant-plugin as a pod (inside Kubernetes cluster).\n+\n+### Before you start\n+antrea-octant-plugin depends on monitoring CRDs, AntreaControllerInfo and AntreaAgentInfo.","path":"docs/octant-plugin-installation.md","position":12,"original_position":12,"commit_id":"342e2775cf30fdfb2d5672cbc55124190efa574e","original_commit_id":"342e2775cf30fdfb2d5672cbc55124190efa574e","user":{"login":"mengdie-song","id":10442983,"node_id":"MDQ6VXNlcjEwNDQyOTgz","avatar_url":"https://avatars2.githubusercontent.com/u/10442983?v=4","gravatar_id":"","url":"https://api.github.com/users/mengdie-song","html_url":"https://github.com/mengdie-song","followers_url":"https://api.github.com/users/mengdie-song/followers","following_url":"https://api.github.com/users/mengdie-song/following{/other_user}","gists_url":"https://api.github.com/users/mengdie-song/gists{/gist_id}","starred_url":"https://api.github.com/users/mengdie-song/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengdie-song/subscriptions","organizations_url":"https://api.github.com/users/mengdie-song/orgs","repos_url":"https://api.github.com/users/mengdie-song/repos","events_url":"https://api.github.com/users/mengdie-song/events{/privacy}","received_events_url":"https://api.github.com/users/mengdie-song/received_events","type":"User","site_admin":false},"body":"OK.","created_at":"2019-11-21T10:51:44Z","updated_at":"2019-11-21T10:51:44Z","html_url":"https://github.com/vmware-tanzu/antrea/pull/59#discussion_r349016876","pull_request_url":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/59","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/comments/349016876"},"html":{"href":"https://github.com/vmware-tanzu/antrea/pull/59#discussion_r349016876"},"pull_request":{"href":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/59"}},"in_reply_to_id":348816838},"pull_request":{"url":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/59","id":340851020,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQwODUxMDIw","html_url":"https://github.com/vmware-tanzu/antrea/pull/59","diff_url":"https://github.com/vmware-tanzu/antrea/pull/59.diff","patch_url":"https://github.com/vmware-tanzu/antrea/pull/59.patch","issue_url":"https://api.github.com/repos/vmware-tanzu/antrea/issues/59","number":59,"state":"open","locked":false,"title":"Add document and image to deploy antrea-octant-plugin","user":{"login":"mengdie-song","id":10442983,"node_id":"MDQ6VXNlcjEwNDQyOTgz","avatar_url":"https://avatars2.githubusercontent.com/u/10442983?v=4","gravatar_id":"","url":"https://api.github.com/users/mengdie-song","html_url":"https://github.com/mengdie-song","followers_url":"https://api.github.com/users/mengdie-song/followers","following_url":"https://api.github.com/users/mengdie-song/following{/other_user}","gists_url":"https://api.github.com/users/mengdie-song/gists{/gist_id}","starred_url":"https://api.github.com/users/mengdie-song/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengdie-song/subscriptions","organizations_url":"https://api.github.com/users/mengdie-song/orgs","repos_url":"https://api.github.com/users/mengdie-song/repos","events_url":"https://api.github.com/users/mengdie-song/events{/privacy}","received_events_url":"https://api.github.com/users/mengdie-song/received_events","type":"User","site_admin":false},"body":"Add document and image for deploying octant and\r\nantrea-octant-plugin.\r\n\r\nFixes #58 ","created_at":"2019-11-14T08:39:16Z","updated_at":"2019-11-21T10:51:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa7922605721e1084219046449ac0d9ff5151ef1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tnqn","id":5331316,"node_id":"MDQ6VXNlcjUzMzEzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5331316?v=4","gravatar_id":"","url":"https://api.github.com/users/tnqn","html_url":"https://github.com/tnqn","followers_url":"https://api.github.com/users/tnqn/followers","following_url":"https://api.github.com/users/tnqn/following{/other_user}","gists_url":"https://api.github.com/users/tnqn/gists{/gist_id}","starred_url":"https://api.github.com/users/tnqn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnqn/subscriptions","organizations_url":"https://api.github.com/users/tnqn/orgs","repos_url":"https://api.github.com/users/tnqn/repos","events_url":"https://api.github.com/users/tnqn/events{/privacy}","received_events_url":"https://api.github.com/users/tnqn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/59/commits","review_comments_url":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/59/comments","review_comment_url":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware-tanzu/antrea/issues/59/comments","statuses_url":"https://api.github.com/repos/vmware-tanzu/antrea/statuses/342e2775cf30fdfb2d5672cbc55124190efa574e","head":{"label":"vmware-tanzu:songm/doc-antrea-octant","ref":"songm/doc-antrea-octant","sha":"342e2775cf30fdfb2d5672cbc55124190efa574e","user":{"login":"vmware-tanzu","id":54452117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NDUyMTE3","avatar_url":"https://avatars3.githubusercontent.com/u/54452117?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware-tanzu","html_url":"https://github.com/vmware-tanzu","followers_url":"https://api.github.com/users/vmware-tanzu/followers","following_url":"https://api.github.com/users/vmware-tanzu/following{/other_user}","gists_url":"https://api.github.com/users/vmware-tanzu/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware-tanzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware-tanzu/subscriptions","organizations_url":"https://api.github.com/users/vmware-tanzu/orgs","repos_url":"https://api.github.com/users/vmware-tanzu/repos","events_url":"https://api.github.com/users/vmware-tanzu/events{/privacy}","received_events_url":"https://api.github.com/users/vmware-tanzu/received_events","type":"Organization","site_admin":false},"repo":{"id":217420145,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc0MjAxNDU=","name":"antrea","full_name":"vmware-tanzu/antrea","private":false,"owner":{"login":"vmware-tanzu","id":54452117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NDUyMTE3","avatar_url":"https://avatars3.githubusercontent.com/u/54452117?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware-tanzu","html_url":"https://github.com/vmware-tanzu","followers_url":"https://api.github.com/users/vmware-tanzu/followers","following_url":"https://api.github.com/users/vmware-tanzu/following{/other_user}","gists_url":"https://api.github.com/users/vmware-tanzu/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware-tanzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware-tanzu/subscriptions","organizations_url":"https://api.github.com/users/vmware-tanzu/orgs","repos_url":"https://api.github.com/users/vmware-tanzu/repos","events_url":"https://api.github.com/users/vmware-tanzu/events{/privacy}","received_events_url":"https://api.github.com/users/vmware-tanzu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vmware-tanzu/antrea","description":"A Kubernetes networking solution based on Open vSwitch","fork":false,"url":"https://api.github.com/repos/vmware-tanzu/antrea","forks_url":"https://api.github.com/repos/vmware-tanzu/antrea/forks","keys_url":"https://api.github.com/repos/vmware-tanzu/antrea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware-tanzu/antrea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware-tanzu/antrea/teams","hooks_url":"https://api.github.com/repos/vmware-tanzu/antrea/hooks","issue_events_url":"https://api.github.com/repos/vmware-tanzu/antrea/issues/events{/number}","events_url":"https://api.github.com/repos/vmware-tanzu/antrea/events","assignees_url":"https://api.github.com/repos/vmware-tanzu/antrea/assignees{/user}","branches_url":"https://api.github.com/repos/vmware-tanzu/antrea/branches{/branch}","tags_url":"https://api.github.com/repos/vmware-tanzu/antrea/tags","blobs_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware-tanzu/antrea/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware-tanzu/antrea/languages","stargazers_url":"https://api.github.com/repos/vmware-tanzu/antrea/stargazers","contributors_url":"https://api.github.com/repos/vmware-tanzu/antrea/contributors","subscribers_url":"https://api.github.com/repos/vmware-tanzu/antrea/subscribers","subscription_url":"https://api.github.com/repos/vmware-tanzu/antrea/subscription","commits_url":"https://api.github.com/repos/vmware-tanzu/antrea/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware-tanzu/antrea/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware-tanzu/antrea/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware-tanzu/antrea/contents/{+path}","compare_url":"https://api.github.com/repos/vmware-tanzu/antrea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware-tanzu/antrea/merges","archive_url":"https://api.github.com/repos/vmware-tanzu/antrea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware-tanzu/antrea/downloads","issues_url":"https://api.github.com/repos/vmware-tanzu/antrea/issues{/number}","pulls_url":"https://api.github.com/repos/vmware-tanzu/antrea/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware-tanzu/antrea/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware-tanzu/antrea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware-tanzu/antrea/labels{/name}","releases_url":"https://api.github.com/repos/vmware-tanzu/antrea/releases{/id}","deployments_url":"https://api.github.com/repos/vmware-tanzu/antrea/deployments","created_at":"2019-10-25T00:42:23Z","updated_at":"2019-11-21T09:33:34Z","pushed_at":"2019-11-21T08:46:00Z","git_url":"git://github.com/vmware-tanzu/antrea.git","ssh_url":"[email protected]:vmware-tanzu/antrea.git","clone_url":"https://github.com/vmware-tanzu/antrea.git","svn_url":"https://github.com/vmware-tanzu/antrea","homepage":"","size":2145,"stargazers_count":118,"watchers_count":118,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":41,"watchers":118,"default_branch":"master"}},"base":{"label":"vmware-tanzu:master","ref":"master","sha":"ff6bc70fe1bb616410427ff5a8685f29023090d5","user":{"login":"vmware-tanzu","id":54452117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NDUyMTE3","avatar_url":"https://avatars3.githubusercontent.com/u/54452117?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware-tanzu","html_url":"https://github.com/vmware-tanzu","followers_url":"https://api.github.com/users/vmware-tanzu/followers","following_url":"https://api.github.com/users/vmware-tanzu/following{/other_user}","gists_url":"https://api.github.com/users/vmware-tanzu/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware-tanzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware-tanzu/subscriptions","organizations_url":"https://api.github.com/users/vmware-tanzu/orgs","repos_url":"https://api.github.com/users/vmware-tanzu/repos","events_url":"https://api.github.com/users/vmware-tanzu/events{/privacy}","received_events_url":"https://api.github.com/users/vmware-tanzu/received_events","type":"Organization","site_admin":false},"repo":{"id":217420145,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc0MjAxNDU=","name":"antrea","full_name":"vmware-tanzu/antrea","private":false,"owner":{"login":"vmware-tanzu","id":54452117,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NDUyMTE3","avatar_url":"https://avatars3.githubusercontent.com/u/54452117?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware-tanzu","html_url":"https://github.com/vmware-tanzu","followers_url":"https://api.github.com/users/vmware-tanzu/followers","following_url":"https://api.github.com/users/vmware-tanzu/following{/other_user}","gists_url":"https://api.github.com/users/vmware-tanzu/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware-tanzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware-tanzu/subscriptions","organizations_url":"https://api.github.com/users/vmware-tanzu/orgs","repos_url":"https://api.github.com/users/vmware-tanzu/repos","events_url":"https://api.github.com/users/vmware-tanzu/events{/privacy}","received_events_url":"https://api.github.com/users/vmware-tanzu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vmware-tanzu/antrea","description":"A Kubernetes networking solution based on Open vSwitch","fork":false,"url":"https://api.github.com/repos/vmware-tanzu/antrea","forks_url":"https://api.github.com/repos/vmware-tanzu/antrea/forks","keys_url":"https://api.github.com/repos/vmware-tanzu/antrea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware-tanzu/antrea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware-tanzu/antrea/teams","hooks_url":"https://api.github.com/repos/vmware-tanzu/antrea/hooks","issue_events_url":"https://api.github.com/repos/vmware-tanzu/antrea/issues/events{/number}","events_url":"https://api.github.com/repos/vmware-tanzu/antrea/events","assignees_url":"https://api.github.com/repos/vmware-tanzu/antrea/assignees{/user}","branches_url":"https://api.github.com/repos/vmware-tanzu/antrea/branches{/branch}","tags_url":"https://api.github.com/repos/vmware-tanzu/antrea/tags","blobs_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware-tanzu/antrea/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware-tanzu/antrea/languages","stargazers_url":"https://api.github.com/repos/vmware-tanzu/antrea/stargazers","contributors_url":"https://api.github.com/repos/vmware-tanzu/antrea/contributors","subscribers_url":"https://api.github.com/repos/vmware-tanzu/antrea/subscribers","subscription_url":"https://api.github.com/repos/vmware-tanzu/antrea/subscription","commits_url":"https://api.github.com/repos/vmware-tanzu/antrea/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware-tanzu/antrea/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware-tanzu/antrea/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware-tanzu/antrea/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware-tanzu/antrea/contents/{+path}","compare_url":"https://api.github.com/repos/vmware-tanzu/antrea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware-tanzu/antrea/merges","archive_url":"https://api.github.com/repos/vmware-tanzu/antrea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware-tanzu/antrea/downloads","issues_url":"https://api.github.com/repos/vmware-tanzu/antrea/issues{/number}","pulls_url":"https://api.github.com/repos/vmware-tanzu/antrea/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware-tanzu/antrea/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware-tanzu/antrea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware-tanzu/antrea/labels{/name}","releases_url":"https://api.github.com/repos/vmware-tanzu/antrea/releases{/id}","deployments_url":"https://api.github.com/repos/vmware-tanzu/antrea/deployments","created_at":"2019-10-25T00:42:23Z","updated_at":"2019-11-21T09:33:34Z","pushed_at":"2019-11-21T08:46:00Z","git_url":"git://github.com/vmware-tanzu/antrea.git","ssh_url":"[email protected]:vmware-tanzu/antrea.git","clone_url":"https://github.com/vmware-tanzu/antrea.git","svn_url":"https://github.com/vmware-tanzu/antrea","homepage":"","size":2145,"stargazers_count":118,"watchers_count":118,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":41,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/59"},"html":{"href":"https://github.com/vmware-tanzu/antrea/pull/59"},"issue":{"href":"https://api.github.com/repos/vmware-tanzu/antrea/issues/59"},"comments":{"href":"https://api.github.com/repos/vmware-tanzu/antrea/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware-tanzu/antrea/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/vmware-tanzu/antrea/statuses/342e2775cf30fdfb2d5672cbc55124190efa574e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 217420145,
"name": "vmware-tanzu/antrea",
"url": "https://api.github.com/repos/vmware-tanzu/antrea"
}
|
{
"id": 10442983,
"login": "mengdie-song",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10442983?",
"url": "https://api.github.com/users/mengdie-song"
}
|
{
"id": 54452117,
"login": "vmware-tanzu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/54452117?",
"url": "https://api.github.com/orgs/vmware-tanzu"
}
| 2019-11-21T10:51:44 |
10915290207
|
{"actor":{"display_login":"mengdie-song"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/comments/338467455","pull_request_review_id":306430656,"id":338467455,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODQ2NzQ1NQ==","diff_hunk":"@@ -37,46 +43,114 @@ public Feed(String name, String address) {\n * @return List of maximum 5 posts.\n */\n public ObservableList<FeedPost> fetchPosts() {\n- ObservableList<FeedPost> posts = FXCollections.observableArrayList();\n+ String feedData = this.fetchFeedData();\n+ ObservableList<FeedPost> feedPosts = this.parseFeedData(feedData);\n+\n+ return feedPosts;\n+ }\n+\n+ /**\n+ * Fetches the feed's data as a String. This method first attempts to fetch data from the feed's remote\n+ * address. If unsuccessful, it attempts to read the local cached feed data.\n+ * @return String representing the feed data.\n+ */\n+ private String fetchFeedData() {\n+ String feedData = null;\n+ String xmlFile = String.format(\"data/cache/%s.xml\", name.toLowerCase().replaceAll(\" \", \"-\"));\n \n try {\n+ // Fetch remote\n URL url = new URL(address);\n HttpURLConnection conn = (HttpURLConnection) url.openConnection();\n BufferedReader in = new BufferedReader(new InputStreamReader(conn.getInputStream()));\n \n+ int c;\n+ StringBuilder buffer = new StringBuilder();\n+\n+ while ((c = in.read()) != -1) {\n+ buffer.append((char) c);\n+ }\n+ feedData = buffer.toString();","path":"src/main/java/seedu/address/model/feed/Feed.java","position":55,"original_position":55,"commit_id":"049598960056e751d512151c2654954edde20553","original_commit_id":"049598960056e751d512151c2654954edde20553","user":{"login":"ROHITREDDYBALAM","id":42374742,"node_id":"MDQ6VXNlcjQyMzc0NzQy","avatar_url":"https://avatars2.githubusercontent.com/u/42374742?v=4","gravatar_id":"","url":"https://api.github.com/users/ROHITREDDYBALAM","html_url":"https://github.com/ROHITREDDYBALAM","followers_url":"https://api.github.com/users/ROHITREDDYBALAM/followers","following_url":"https://api.github.com/users/ROHITREDDYBALAM/following{/other_user}","gists_url":"https://api.github.com/users/ROHITREDDYBALAM/gists{/gist_id}","starred_url":"https://api.github.com/users/ROHITREDDYBALAM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROHITREDDYBALAM/subscriptions","organizations_url":"https://api.github.com/users/ROHITREDDYBALAM/orgs","repos_url":"https://api.github.com/users/ROHITREDDYBALAM/repos","events_url":"https://api.github.com/users/ROHITREDDYBALAM/events{/privacy}","received_events_url":"https://api.github.com/users/ROHITREDDYBALAM/received_events","type":"User","site_admin":false},"body":"does this mean you are reading the entire feed of the website?","created_at":"2019-10-24T09:18:33Z","updated_at":"2019-10-24T09:24:14Z","html_url":"https://github.com/AY1920S1-CS2103T-W11-3/main/pull/95#discussion_r338467455","pull_request_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/95","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/comments/338467455"},"html":{"href":"https://github.com/AY1920S1-CS2103T-W11-3/main/pull/95#discussion_r338467455"},"pull_request":{"href":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/95","id":331909244,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxOTA5MjQ0","html_url":"https://github.com/AY1920S1-CS2103T-W11-3/main/pull/95","diff_url":"https://github.com/AY1920S1-CS2103T-W11-3/main/pull/95.diff","patch_url":"https://github.com/AY1920S1-CS2103T-W11-3/main/pull/95.patch","issue_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/issues/95","number":95,"state":"open","locked":false,"title":"Implement feed caching","user":{"login":"dvrylc","id":6095637,"node_id":"MDQ6VXNlcjYwOTU2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/6095637?v=4","gravatar_id":"","url":"https://api.github.com/users/dvrylc","html_url":"https://github.com/dvrylc","followers_url":"https://api.github.com/users/dvrylc/followers","following_url":"https://api.github.com/users/dvrylc/following{/other_user}","gists_url":"https://api.github.com/users/dvrylc/gists{/gist_id}","starred_url":"https://api.github.com/users/dvrylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvrylc/subscriptions","organizations_url":"https://api.github.com/users/dvrylc/orgs","repos_url":"https://api.github.com/users/dvrylc/repos","events_url":"https://api.github.com/users/dvrylc/events{/privacy}","received_events_url":"https://api.github.com/users/dvrylc/received_events","type":"User","site_admin":false},"body":"Closes #72 ","created_at":"2019-10-24T08:00:20Z","updated_at":"2019-10-24T09:24:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c2b6cb90b01eeac835333e83f9e89d02a2b196b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/95/commits","review_comments_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/95/comments","review_comment_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/issues/95/comments","statuses_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/statuses/049598960056e751d512151c2654954edde20553","head":{"label":"dvrylc:cache-rss","ref":"cache-rss","sha":"049598960056e751d512151c2654954edde20553","user":{"login":"dvrylc","id":6095637,"node_id":"MDQ6VXNlcjYwOTU2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/6095637?v=4","gravatar_id":"","url":"https://api.github.com/users/dvrylc","html_url":"https://github.com/dvrylc","followers_url":"https://api.github.com/users/dvrylc/followers","following_url":"https://api.github.com/users/dvrylc/following{/other_user}","gists_url":"https://api.github.com/users/dvrylc/gists{/gist_id}","starred_url":"https://api.github.com/users/dvrylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvrylc/subscriptions","organizations_url":"https://api.github.com/users/dvrylc/orgs","repos_url":"https://api.github.com/users/dvrylc/repos","events_url":"https://api.github.com/users/dvrylc/events{/privacy}","received_events_url":"https://api.github.com/users/dvrylc/received_events","type":"User","site_admin":false},"repo":{"id":209538791,"node_id":"MDEwOlJlcG9zaXRvcnkyMDk1Mzg3OTE=","name":"main","full_name":"dvrylc/main","private":false,"owner":{"login":"dvrylc","id":6095637,"node_id":"MDQ6VXNlcjYwOTU2Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/6095637?v=4","gravatar_id":"","url":"https://api.github.com/users/dvrylc","html_url":"https://github.com/dvrylc","followers_url":"https://api.github.com/users/dvrylc/followers","following_url":"https://api.github.com/users/dvrylc/following{/other_user}","gists_url":"https://api.github.com/users/dvrylc/gists{/gist_id}","starred_url":"https://api.github.com/users/dvrylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvrylc/subscriptions","organizations_url":"https://api.github.com/users/dvrylc/orgs","repos_url":"https://api.github.com/users/dvrylc/repos","events_url":"https://api.github.com/users/dvrylc/events{/privacy}","received_events_url":"https://api.github.com/users/dvrylc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dvrylc/main","description":"Address Book - Level 3","fork":true,"url":"https://api.github.com/repos/dvrylc/main","forks_url":"https://api.github.com/repos/dvrylc/main/forks","keys_url":"https://api.github.com/repos/dvrylc/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvrylc/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvrylc/main/teams","hooks_url":"https://api.github.com/repos/dvrylc/main/hooks","issue_events_url":"https://api.github.com/repos/dvrylc/main/issues/events{/number}","events_url":"https://api.github.com/repos/dvrylc/main/events","assignees_url":"https://api.github.com/repos/dvrylc/main/assignees{/user}","branches_url":"https://api.github.com/repos/dvrylc/main/branches{/branch}","tags_url":"https://api.github.com/repos/dvrylc/main/tags","blobs_url":"https://api.github.com/repos/dvrylc/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvrylc/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvrylc/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvrylc/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvrylc/main/statuses/{sha}","languages_url":"https://api.github.com/repos/dvrylc/main/languages","stargazers_url":"https://api.github.com/repos/dvrylc/main/stargazers","contributors_url":"https://api.github.com/repos/dvrylc/main/contributors","subscribers_url":"https://api.github.com/repos/dvrylc/main/subscribers","subscription_url":"https://api.github.com/repos/dvrylc/main/subscription","commits_url":"https://api.github.com/repos/dvrylc/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvrylc/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvrylc/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvrylc/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvrylc/main/contents/{+path}","compare_url":"https://api.github.com/repos/dvrylc/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvrylc/main/merges","archive_url":"https://api.github.com/repos/dvrylc/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvrylc/main/downloads","issues_url":"https://api.github.com/repos/dvrylc/main/issues{/number}","pulls_url":"https://api.github.com/repos/dvrylc/main/pulls{/number}","milestones_url":"https://api.github.com/repos/dvrylc/main/milestones{/number}","notifications_url":"https://api.github.com/repos/dvrylc/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvrylc/main/labels{/name}","releases_url":"https://api.github.com/repos/dvrylc/main/releases{/id}","deployments_url":"https://api.github.com/repos/dvrylc/main/deployments","created_at":"2019-09-19T11:41:49Z","updated_at":"2019-10-24T02:04:27Z","pushed_at":"2019-10-24T07:59:14Z","git_url":"git://github.com/dvrylc/main.git","ssh_url":"[email protected]:dvrylc/main.git","clone_url":"https://github.com/dvrylc/main.git","svn_url":"https://github.com/dvrylc/main","homepage":"https://nus-cs2103-ay1920s1.github.io/addressbook-level3/","size":13764,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AY1920S1-CS2103T-W11-3:master","ref":"master","sha":"c54fb75c161c77320b0fd49b2b372d2d2f72fcd5","user":{"login":"AY1920S1-CS2103T-W11-3","id":55124144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MTI0MTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/55124144?v=4","gravatar_id":"","url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3","html_url":"https://github.com/AY1920S1-CS2103T-W11-3","followers_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/followers","following_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/following{/other_user}","gists_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/gists{/gist_id}","starred_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/subscriptions","organizations_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/orgs","repos_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/repos","events_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/events{/privacy}","received_events_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/received_events","type":"Organization","site_admin":false},"repo":{"id":207466488,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc0NjY0ODg=","name":"main","full_name":"AY1920S1-CS2103T-W11-3/main","private":false,"owner":{"login":"AY1920S1-CS2103T-W11-3","id":55124144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MTI0MTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/55124144?v=4","gravatar_id":"","url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3","html_url":"https://github.com/AY1920S1-CS2103T-W11-3","followers_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/followers","following_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/following{/other_user}","gists_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/gists{/gist_id}","starred_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/subscriptions","organizations_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/orgs","repos_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/repos","events_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/events{/privacy}","received_events_url":"https://api.github.com/users/AY1920S1-CS2103T-W11-3/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AY1920S1-CS2103T-W11-3/main","description":"EatMe","fork":true,"url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main","forks_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/forks","keys_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/teams","hooks_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/hooks","issue_events_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/issues/events{/number}","events_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/events","assignees_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/assignees{/user}","branches_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/branches{/branch}","tags_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/tags","blobs_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/statuses/{sha}","languages_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/languages","stargazers_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/stargazers","contributors_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/contributors","subscribers_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/subscribers","subscription_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/subscription","commits_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/contents/{+path}","compare_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/merges","archive_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/downloads","issues_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/issues{/number}","pulls_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls{/number}","milestones_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/milestones{/number}","notifications_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/labels{/name}","releases_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/releases{/id}","deployments_url":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/deployments","created_at":"2019-09-10T04:37:45Z","updated_at":"2019-10-24T06:39:34Z","pushed_at":"2019-10-24T08:00:21Z","git_url":"git://github.com/AY1920S1-CS2103T-W11-3/main.git","ssh_url":"[email protected]:AY1920S1-CS2103T-W11-3/main.git","clone_url":"https://github.com/AY1920S1-CS2103T-W11-3/main.git","svn_url":"https://github.com/AY1920S1-CS2103T-W11-3/main","homepage":"https://ay1920s1-cs2103t-w11-3.github.io/main/","size":13802,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":44,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/95"},"html":{"href":"https://github.com/AY1920S1-CS2103T-W11-3/main/pull/95"},"issue":{"href":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/issues/95"},"comments":{"href":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main/statuses/049598960056e751d512151c2654954edde20553"}},"author_association":"NONE"}}
|
{
"id": 207466488,
"name": "AY1920S1-CS2103T-W11-3/main",
"url": "https://api.github.com/repos/AY1920S1-CS2103T-W11-3/main"
}
|
{
"id": 42374742,
"login": "ROHITREDDYBALAM",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42374742?",
"url": "https://api.github.com/users/ROHITREDDYBALAM"
}
|
{
"id": 55124144,
"login": "AY1920S1-CS2103T-W11-3",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55124144?",
"url": "https://api.github.com/orgs/AY1920S1-CS2103T-W11-3"
}
| 2019-10-24T09:18:33 |
10703357484
|
{"actor":{"display_login":"ROHITREDDYBALAM"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/comments/348424066","pull_request_review_id":319764142,"id":348424066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODQyNDA2Ng==","diff_hunk":"@@ -0,0 +1,127 @@\n+//\n+// Message.swift\n+// PAPER Planes\n+//\n+// Created by Marco Liang on 2019-11-17.\n+// Copyright ยฉ 2019 Angus Kan. All rights reserved.\n+//\n+\n+import Foundation\n+import UIKit\n+import MessageKit\n+import Firebase\n+import FirebaseFirestore\n+\n+struct Member {\n+//TODO: Add UID\n+ let name: String\n+ let email: String\n+}\n+\n+struct Message: MessageType {\n+// var messageId: String\n+ var sender: SenderType\n+ var sentDate: Date\n+ \n+// let member: Member\n+ let text: String\n+ let id: String?\n+// let sentDate: Date\n+// let sender: Sender\n+ \n+ init(member: Member, text: String){\n+// member = member\n+ self.text = text\n+ sender = Sender(id: member.email, displayName: member.name)\n+ sentDate = Date()\n+// messageId = UUID().uuidString\n+ id = nil\n+ }\n+ \n+ var messageId: String{\n+ return id ?? UUID().uuidString\n+ }\n+ ","path":"projects/app/src/PAPER Planes/Message.swift","position":44,"original_position":44,"commit_id":"d711b409ad0437b0260b91faf3c21981186ee5b3","original_commit_id":"d711b409ad0437b0260b91faf3c21981186ee5b3","user":{"login":"hound[bot]","id":30008653,"node_id":"MDM6Qm90MzAwMDg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/in/3598?v=4","gravatar_id":"","url":"https://api.github.com/users/hound%5Bbot%5D","html_url":"https://github.com/apps/hound","followers_url":"https://api.github.com/users/hound%5Bbot%5D/followers","following_url":"https://api.github.com/users/hound%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/hound%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/hound%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hound%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/hound%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/hound%5Bbot%5D/repos","events_url":"https://api.github.com/users/hound%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/hound%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)","created_at":"2019-11-20T11:14:20Z","updated_at":"2019-11-20T11:14:23Z","html_url":"https://github.com/CMPT-275-Group-13/lucky13/pull/42#discussion_r348424066","pull_request_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/42","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/comments/348424066"},"html":{"href":"https://github.com/CMPT-275-Group-13/lucky13/pull/42#discussion_r348424066"},"pull_request":{"href":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/42","id":343300320,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzMzAwMzIw","html_url":"https://github.com/CMPT-275-Group-13/lucky13/pull/42","diff_url":"https://github.com/CMPT-275-Group-13/lucky13/pull/42.diff","patch_url":"https://github.com/CMPT-275-Group-13/lucky13/pull/42.patch","issue_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues/42","number":42,"state":"closed","locked":false,"title":"Messages and tidying up","user":{"login":"cjinn","id":9071560,"node_id":"MDQ6VXNlcjkwNzE1NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9071560?v=4","gravatar_id":"","url":"https://api.github.com/users/cjinn","html_url":"https://github.com/cjinn","followers_url":"https://api.github.com/users/cjinn/followers","following_url":"https://api.github.com/users/cjinn/following{/other_user}","gists_url":"https://api.github.com/users/cjinn/gists{/gist_id}","starred_url":"https://api.github.com/users/cjinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjinn/subscriptions","organizations_url":"https://api.github.com/users/cjinn/orgs","repos_url":"https://api.github.com/users/cjinn/repos","events_url":"https://api.github.com/users/cjinn/events{/privacy}","received_events_url":"https://api.github.com/users/cjinn/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-20T11:12:59Z","updated_at":"2019-11-20T11:14:23Z","closed_at":"2019-11-20T11:13:06Z","merged_at":"2019-11-20T11:13:06Z","merge_commit_sha":"067d0c9aa2c2ec70c6df3b79a9f893124340831c","assignee":{"login":"cjinn","id":9071560,"node_id":"MDQ6VXNlcjkwNzE1NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9071560?v=4","gravatar_id":"","url":"https://api.github.com/users/cjinn","html_url":"https://github.com/cjinn","followers_url":"https://api.github.com/users/cjinn/followers","following_url":"https://api.github.com/users/cjinn/following{/other_user}","gists_url":"https://api.github.com/users/cjinn/gists{/gist_id}","starred_url":"https://api.github.com/users/cjinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjinn/subscriptions","organizations_url":"https://api.github.com/users/cjinn/orgs","repos_url":"https://api.github.com/users/cjinn/repos","events_url":"https://api.github.com/users/cjinn/events{/privacy}","received_events_url":"https://api.github.com/users/cjinn/received_events","type":"User","site_admin":false},"assignees":[{"login":"cjinn","id":9071560,"node_id":"MDQ6VXNlcjkwNzE1NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9071560?v=4","gravatar_id":"","url":"https://api.github.com/users/cjinn","html_url":"https://github.com/cjinn","followers_url":"https://api.github.com/users/cjinn/followers","following_url":"https://api.github.com/users/cjinn/following{/other_user}","gists_url":"https://api.github.com/users/cjinn/gists{/gist_id}","starred_url":"https://api.github.com/users/cjinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjinn/subscriptions","organizations_url":"https://api.github.com/users/cjinn/orgs","repos_url":"https://api.github.com/users/cjinn/repos","events_url":"https://api.github.com/users/cjinn/events{/privacy}","received_events_url":"https://api.github.com/users/cjinn/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/milestones/5","html_url":"https://github.com/CMPT-275-Group-13/lucky13/milestone/5","labels_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/milestones/5/labels","id":4857824,"node_id":"MDk6TWlsZXN0b25lNDg1NzgyNA==","number":5,"title":"Assignment 5","description":null,"creator":{"login":"cjinn","id":9071560,"node_id":"MDQ6VXNlcjkwNzE1NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9071560?v=4","gravatar_id":"","url":"https://api.github.com/users/cjinn","html_url":"https://github.com/cjinn","followers_url":"https://api.github.com/users/cjinn/followers","following_url":"https://api.github.com/users/cjinn/following{/other_user}","gists_url":"https://api.github.com/users/cjinn/gists{/gist_id}","starred_url":"https://api.github.com/users/cjinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjinn/subscriptions","organizations_url":"https://api.github.com/users/cjinn/orgs","repos_url":"https://api.github.com/users/cjinn/repos","events_url":"https://api.github.com/users/cjinn/events{/privacy}","received_events_url":"https://api.github.com/users/cjinn/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":1,"state":"open","created_at":"2019-11-18T22:53:31Z","updated_at":"2019-11-20T11:13:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/42/commits","review_comments_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/42/comments","review_comment_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues/42/comments","statuses_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/statuses/d711b409ad0437b0260b91faf3c21981186ee5b3","head":{"label":"CMPT-275-Group-13:dev","ref":"dev","sha":"d711b409ad0437b0260b91faf3c21981186ee5b3","user":{"login":"CMPT-275-Group-13","id":55302905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MzAyOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/55302905?v=4","gravatar_id":"","url":"https://api.github.com/users/CMPT-275-Group-13","html_url":"https://github.com/CMPT-275-Group-13","followers_url":"https://api.github.com/users/CMPT-275-Group-13/followers","following_url":"https://api.github.com/users/CMPT-275-Group-13/following{/other_user}","gists_url":"https://api.github.com/users/CMPT-275-Group-13/gists{/gist_id}","starred_url":"https://api.github.com/users/CMPT-275-Group-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMPT-275-Group-13/subscriptions","organizations_url":"https://api.github.com/users/CMPT-275-Group-13/orgs","repos_url":"https://api.github.com/users/CMPT-275-Group-13/repos","events_url":"https://api.github.com/users/CMPT-275-Group-13/events{/privacy}","received_events_url":"https://api.github.com/users/CMPT-275-Group-13/received_events","type":"Organization","site_admin":false},"repo":{"id":208924135,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5MjQxMzU=","name":"lucky13","full_name":"CMPT-275-Group-13/lucky13","private":false,"owner":{"login":"CMPT-275-Group-13","id":55302905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MzAyOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/55302905?v=4","gravatar_id":"","url":"https://api.github.com/users/CMPT-275-Group-13","html_url":"https://github.com/CMPT-275-Group-13","followers_url":"https://api.github.com/users/CMPT-275-Group-13/followers","following_url":"https://api.github.com/users/CMPT-275-Group-13/following{/other_user}","gists_url":"https://api.github.com/users/CMPT-275-Group-13/gists{/gist_id}","starred_url":"https://api.github.com/users/CMPT-275-Group-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMPT-275-Group-13/subscriptions","organizations_url":"https://api.github.com/users/CMPT-275-Group-13/orgs","repos_url":"https://api.github.com/users/CMPT-275-Group-13/repos","events_url":"https://api.github.com/users/CMPT-275-Group-13/events{/privacy}","received_events_url":"https://api.github.com/users/CMPT-275-Group-13/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CMPT-275-Group-13/lucky13","description":"iOS app to assist people with Parkinson's","fork":false,"url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13","forks_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/forks","keys_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/teams","hooks_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/hooks","issue_events_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues/events{/number}","events_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/events","assignees_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/assignees{/user}","branches_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/branches{/branch}","tags_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/tags","blobs_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/statuses/{sha}","languages_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/languages","stargazers_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/stargazers","contributors_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/contributors","subscribers_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/subscribers","subscription_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/subscription","commits_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/contents/{+path}","compare_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/merges","archive_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/downloads","issues_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues{/number}","pulls_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls{/number}","milestones_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/milestones{/number}","notifications_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/labels{/name}","releases_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/releases{/id}","deployments_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/deployments","created_at":"2019-09-17T00:34:08Z","updated_at":"2019-11-20T11:11:42Z","pushed_at":"2019-11-20T11:14:18Z","git_url":"git://github.com/CMPT-275-Group-13/lucky13.git","ssh_url":"[email protected]:CMPT-275-Group-13/lucky13.git","clone_url":"https://github.com/CMPT-275-Group-13/lucky13.git","svn_url":"https://github.com/CMPT-275-Group-13/lucky13","homepage":null,"size":21197,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"dev"}},"base":{"label":"CMPT-275-Group-13:stage","ref":"stage","sha":"e94582f5e1d0d0c99bad98359e9bbdc8c659638b","user":{"login":"CMPT-275-Group-13","id":55302905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MzAyOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/55302905?v=4","gravatar_id":"","url":"https://api.github.com/users/CMPT-275-Group-13","html_url":"https://github.com/CMPT-275-Group-13","followers_url":"https://api.github.com/users/CMPT-275-Group-13/followers","following_url":"https://api.github.com/users/CMPT-275-Group-13/following{/other_user}","gists_url":"https://api.github.com/users/CMPT-275-Group-13/gists{/gist_id}","starred_url":"https://api.github.com/users/CMPT-275-Group-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMPT-275-Group-13/subscriptions","organizations_url":"https://api.github.com/users/CMPT-275-Group-13/orgs","repos_url":"https://api.github.com/users/CMPT-275-Group-13/repos","events_url":"https://api.github.com/users/CMPT-275-Group-13/events{/privacy}","received_events_url":"https://api.github.com/users/CMPT-275-Group-13/received_events","type":"Organization","site_admin":false},"repo":{"id":208924135,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5MjQxMzU=","name":"lucky13","full_name":"CMPT-275-Group-13/lucky13","private":false,"owner":{"login":"CMPT-275-Group-13","id":55302905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MzAyOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/55302905?v=4","gravatar_id":"","url":"https://api.github.com/users/CMPT-275-Group-13","html_url":"https://github.com/CMPT-275-Group-13","followers_url":"https://api.github.com/users/CMPT-275-Group-13/followers","following_url":"https://api.github.com/users/CMPT-275-Group-13/following{/other_user}","gists_url":"https://api.github.com/users/CMPT-275-Group-13/gists{/gist_id}","starred_url":"https://api.github.com/users/CMPT-275-Group-13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMPT-275-Group-13/subscriptions","organizations_url":"https://api.github.com/users/CMPT-275-Group-13/orgs","repos_url":"https://api.github.com/users/CMPT-275-Group-13/repos","events_url":"https://api.github.com/users/CMPT-275-Group-13/events{/privacy}","received_events_url":"https://api.github.com/users/CMPT-275-Group-13/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CMPT-275-Group-13/lucky13","description":"iOS app to assist people with Parkinson's","fork":false,"url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13","forks_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/forks","keys_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/teams","hooks_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/hooks","issue_events_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues/events{/number}","events_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/events","assignees_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/assignees{/user}","branches_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/branches{/branch}","tags_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/tags","blobs_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/statuses/{sha}","languages_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/languages","stargazers_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/stargazers","contributors_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/contributors","subscribers_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/subscribers","subscription_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/subscription","commits_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/contents/{+path}","compare_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/merges","archive_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/downloads","issues_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues{/number}","pulls_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls{/number}","milestones_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/milestones{/number}","notifications_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/labels{/name}","releases_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/releases{/id}","deployments_url":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/deployments","created_at":"2019-09-17T00:34:08Z","updated_at":"2019-11-20T11:11:42Z","pushed_at":"2019-11-20T11:14:18Z","git_url":"git://github.com/CMPT-275-Group-13/lucky13.git","ssh_url":"[email protected]:CMPT-275-Group-13/lucky13.git","clone_url":"https://github.com/CMPT-275-Group-13/lucky13.git","svn_url":"https://github.com/CMPT-275-Group-13/lucky13","homepage":null,"size":21197,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":1,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/42"},"html":{"href":"https://github.com/CMPT-275-Group-13/lucky13/pull/42"},"issue":{"href":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues/42"},"comments":{"href":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/CMPT-275-Group-13/lucky13/statuses/d711b409ad0437b0260b91faf3c21981186ee5b3"}},"author_association":"COLLABORATOR"}}
|
{
"id": 208924135,
"name": "CMPT-275-Group-13/lucky13",
"url": "https://api.github.com/repos/CMPT-275-Group-13/lucky13"
}
|
{
"id": 30008653,
"login": "hound[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30008653?",
"url": "https://api.github.com/users/hound[bot]"
}
|
{
"id": 55302905,
"login": "CMPT-275-Group-13",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55302905?",
"url": "https://api.github.com/orgs/CMPT-275-Group-13"
}
| 2019-11-20T11:14:20 |
10905673734
|
{"actor":{"display_login":"hound"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/comments/334015568","pull_request_review_id":300718460,"id":334015568,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDAxNTU2OA==","diff_hunk":"@@ -0,0 +1,93 @@\n+syntax = \"proto2\";\n+\n+package protos.soc;\n+\n+import \"soc/inventory.proto\";\n+import \"soc/board.proto\";\n+import \"soc/state.proto\";\n+\n+enum MoveType {\n+ ROLL_DICE = 0;\n+ END_TURN = 1;\n+ INITIAL_PLACEMENT = 2;\n+ DISCARD_RESOURCES = 3;\n+ MOVE_ROBBER_AND_STEAL = 4;\n+ BUY_DEVELOPMENT_CARD = 5;\n+ BUILD_ROAD = 6;\n+ BUILD_SETTLEMENT = 7;\n+ BUILD_CITY = 8;\n+ PORT_TRADE = 9;\n+ PLAY_KNIGHT = 10;\n+ PLAY_YEAR_OF_PLENTY = 11;\n+ PLAY_MONOPOLY = 12;\n+ PLAY_ROAD_BUILDER = 13;\n+}\n+\n+message SOCMove {\n+ required MoveType type = 1;\n+ oneof payload {\n+ InitialPlacement initial_placement_payload = 2;\n+ DiscardResources discard_resources_payload = 3;\n+ MoveRobberAndSteal move_robber_and_steal_payload = 4;\n+ BuildRoad build_road_payload = 5;\n+ BuildSettlement build_settlement_payload = 6;\n+ BuildCity build_city_payload = 7;\n+ PortTrade port_trade_payload = 8;\n+ MoveRobberAndSteal play_knight_payload = 9;\n+ PlayYearOfPlenty play_year_of_plenty_payload = 10;\n+ PlayMonopoly play_monopoly_payload = 11;\n+ PlayRoadBuilder play_road_builder_payload = 12;\n+ }\n+}\n+\n+message RollDice {}\n+message EndTurn {}\n+\n+message InitialPlacement {\n+ required Vertex settlement = 1;\n+ required Edge road = 2;\n+ required bool first_placement = 3;\n+}\n+\n+message DiscardResources {\n+ required Player player = 1;\n+ repeated ResourceCount resources = 2;\n+}\n+\n+message MoveRobberAndSteal {\n+ required Vertex robber_location = 1;\n+ optional Player player_to_steal = 2;\n+}\n+\n+message BuyDevelopmentCard {}\n+\n+message BuildRoad {\n+ required Edge edge = 1;\n+}\n+\n+message BuildSettlement {\n+ required Vertex vertex = 1;\n+}\n+\n+message BuildCity {\n+ required Vertex vertex = 1;\n+}\n+\n+message PortTrade {\n+ repeated ResourceCount give = 1;\n+ repeated ResourceCount get = 2;","path":"src/main/protobuf/soc/moves.proto","position":78,"original_position":78,"commit_id":"4b5c0511886236ad78c90e369bcb5e643921a8ed","original_commit_id":"4b5c0511886236ad78c90e369bcb5e643921a8ed","user":{"login":"danielglasgow","id":8742154,"node_id":"MDQ6VXNlcjg3NDIxNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8742154?v=4","gravatar_id":"","url":"https://api.github.com/users/danielglasgow","html_url":"https://github.com/danielglasgow","followers_url":"https://api.github.com/users/danielglasgow/followers","following_url":"https://api.github.com/users/danielglasgow/following{/other_user}","gists_url":"https://api.github.com/users/danielglasgow/gists{/gist_id}","starred_url":"https://api.github.com/users/danielglasgow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielglasgow/subscriptions","organizations_url":"https://api.github.com/users/danielglasgow/orgs","repos_url":"https://api.github.com/users/danielglasgow/repos","events_url":"https://api.github.com/users/danielglasgow/events{/privacy}","received_events_url":"https://api.github.com/users/danielglasgow/received_events","type":"User","site_admin":false},"body":"Can `get` be a single `Resource`? Also, maybe `receive` instead of `get`. ","created_at":"2019-10-11T14:20:45Z","updated_at":"2019-10-11T14:20:45Z","html_url":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6#discussion_r334015568","pull_request_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/comments/334015568"},"html":{"href":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6#discussion_r334015568"},"pull_request":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6","id":325870098,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1ODcwMDk4","html_url":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6","diff_url":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6.diff","patch_url":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6.patch","issue_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/6","number":6,"state":"open","locked":false,"title":"Adding proto support for moves","user":{"login":"grogdotcom","id":33365105,"node_id":"MDQ6VXNlcjMzMzY1MTA1","avatar_url":"https://avatars0.githubusercontent.com/u/33365105?v=4","gravatar_id":"","url":"https://api.github.com/users/grogdotcom","html_url":"https://github.com/grogdotcom","followers_url":"https://api.github.com/users/grogdotcom/followers","following_url":"https://api.github.com/users/grogdotcom/following{/other_user}","gists_url":"https://api.github.com/users/grogdotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/grogdotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grogdotcom/subscriptions","organizations_url":"https://api.github.com/users/grogdotcom/orgs","repos_url":"https://api.github.com/users/grogdotcom/repos","events_url":"https://api.github.com/users/grogdotcom/events{/privacy}","received_events_url":"https://api.github.com/users/grogdotcom/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-08T17:00:36Z","updated_at":"2019-10-11T14:20:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c70b50a392679062aafaaf63e12c41e5f56502f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6/commits","review_comments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6/comments","review_comment_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/6/comments","statuses_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/statuses/4b5c0511886236ad78c90e369bcb5e643921a8ed","head":{"label":"SOC-Training-Tool:move_proto","ref":"move_proto","sha":"4b5c0511886236ad78c90e369bcb5e643921a8ed","user":{"login":"SOC-Training-Tool","id":55442794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDQyNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/55442794?v=4","gravatar_id":"","url":"https://api.github.com/users/SOC-Training-Tool","html_url":"https://github.com/SOC-Training-Tool","followers_url":"https://api.github.com/users/SOC-Training-Tool/followers","following_url":"https://api.github.com/users/SOC-Training-Tool/following{/other_user}","gists_url":"https://api.github.com/users/SOC-Training-Tool/gists{/gist_id}","starred_url":"https://api.github.com/users/SOC-Training-Tool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SOC-Training-Tool/subscriptions","organizations_url":"https://api.github.com/users/SOC-Training-Tool/orgs","repos_url":"https://api.github.com/users/SOC-Training-Tool/repos","events_url":"https://api.github.com/users/SOC-Training-Tool/events{/privacy}","received_events_url":"https://api.github.com/users/SOC-Training-Tool/received_events","type":"Organization","site_admin":false},"repo":{"id":209044358,"node_id":"MDEwOlJlcG9zaXRvcnkyMDkwNDQzNTg=","name":"ImmutableSOC","full_name":"SOC-Training-Tool/ImmutableSOC","private":false,"owner":{"login":"SOC-Training-Tool","id":55442794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDQyNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/55442794?v=4","gravatar_id":"","url":"https://api.github.com/users/SOC-Training-Tool","html_url":"https://github.com/SOC-Training-Tool","followers_url":"https://api.github.com/users/SOC-Training-Tool/followers","following_url":"https://api.github.com/users/SOC-Training-Tool/following{/other_user}","gists_url":"https://api.github.com/users/SOC-Training-Tool/gists{/gist_id}","starred_url":"https://api.github.com/users/SOC-Training-Tool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SOC-Training-Tool/subscriptions","organizations_url":"https://api.github.com/users/SOC-Training-Tool/orgs","repos_url":"https://api.github.com/users/SOC-Training-Tool/repos","events_url":"https://api.github.com/users/SOC-Training-Tool/events{/privacy}","received_events_url":"https://api.github.com/users/SOC-Training-Tool/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SOC-Training-Tool/ImmutableSOC","description":null,"fork":false,"url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC","forks_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/forks","keys_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/teams","hooks_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/hooks","issue_events_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/events{/number}","events_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/events","assignees_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/assignees{/user}","branches_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/branches{/branch}","tags_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/tags","blobs_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/statuses/{sha}","languages_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/languages","stargazers_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/stargazers","contributors_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/contributors","subscribers_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/subscribers","subscription_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/subscription","commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/contents/{+path}","compare_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/merges","archive_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/downloads","issues_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues{/number}","pulls_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls{/number}","milestones_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/milestones{/number}","notifications_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/labels{/name}","releases_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/releases{/id}","deployments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/deployments","created_at":"2019-09-17T12:12:02Z","updated_at":"2019-10-07T15:44:13Z","pushed_at":"2019-10-08T17:00:36Z","git_url":"git://github.com/SOC-Training-Tool/ImmutableSOC.git","ssh_url":"[email protected]:SOC-Training-Tool/ImmutableSOC.git","clone_url":"https://github.com/SOC-Training-Tool/ImmutableSOC.git","svn_url":"https://github.com/SOC-Training-Tool/ImmutableSOC","homepage":null,"size":144,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SOC-Training-Tool:master","ref":"master","sha":"08df24f84c798d326347fede274a9ed7d1c9ea41","user":{"login":"SOC-Training-Tool","id":55442794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDQyNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/55442794?v=4","gravatar_id":"","url":"https://api.github.com/users/SOC-Training-Tool","html_url":"https://github.com/SOC-Training-Tool","followers_url":"https://api.github.com/users/SOC-Training-Tool/followers","following_url":"https://api.github.com/users/SOC-Training-Tool/following{/other_user}","gists_url":"https://api.github.com/users/SOC-Training-Tool/gists{/gist_id}","starred_url":"https://api.github.com/users/SOC-Training-Tool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SOC-Training-Tool/subscriptions","organizations_url":"https://api.github.com/users/SOC-Training-Tool/orgs","repos_url":"https://api.github.com/users/SOC-Training-Tool/repos","events_url":"https://api.github.com/users/SOC-Training-Tool/events{/privacy}","received_events_url":"https://api.github.com/users/SOC-Training-Tool/received_events","type":"Organization","site_admin":false},"repo":{"id":209044358,"node_id":"MDEwOlJlcG9zaXRvcnkyMDkwNDQzNTg=","name":"ImmutableSOC","full_name":"SOC-Training-Tool/ImmutableSOC","private":false,"owner":{"login":"SOC-Training-Tool","id":55442794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NDQyNzk0","avatar_url":"https://avatars3.githubusercontent.com/u/55442794?v=4","gravatar_id":"","url":"https://api.github.com/users/SOC-Training-Tool","html_url":"https://github.com/SOC-Training-Tool","followers_url":"https://api.github.com/users/SOC-Training-Tool/followers","following_url":"https://api.github.com/users/SOC-Training-Tool/following{/other_user}","gists_url":"https://api.github.com/users/SOC-Training-Tool/gists{/gist_id}","starred_url":"https://api.github.com/users/SOC-Training-Tool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SOC-Training-Tool/subscriptions","organizations_url":"https://api.github.com/users/SOC-Training-Tool/orgs","repos_url":"https://api.github.com/users/SOC-Training-Tool/repos","events_url":"https://api.github.com/users/SOC-Training-Tool/events{/privacy}","received_events_url":"https://api.github.com/users/SOC-Training-Tool/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SOC-Training-Tool/ImmutableSOC","description":null,"fork":false,"url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC","forks_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/forks","keys_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/teams","hooks_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/hooks","issue_events_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/events{/number}","events_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/events","assignees_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/assignees{/user}","branches_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/branches{/branch}","tags_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/tags","blobs_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/statuses/{sha}","languages_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/languages","stargazers_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/stargazers","contributors_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/contributors","subscribers_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/subscribers","subscription_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/subscription","commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/contents/{+path}","compare_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/merges","archive_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/downloads","issues_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues{/number}","pulls_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls{/number}","milestones_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/milestones{/number}","notifications_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/labels{/name}","releases_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/releases{/id}","deployments_url":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/deployments","created_at":"2019-09-17T12:12:02Z","updated_at":"2019-10-07T15:44:13Z","pushed_at":"2019-10-08T17:00:36Z","git_url":"git://github.com/SOC-Training-Tool/ImmutableSOC.git","ssh_url":"[email protected]:SOC-Training-Tool/ImmutableSOC.git","clone_url":"https://github.com/SOC-Training-Tool/ImmutableSOC.git","svn_url":"https://github.com/SOC-Training-Tool/ImmutableSOC","homepage":null,"size":144,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6"},"html":{"href":"https://github.com/SOC-Training-Tool/ImmutableSOC/pull/6"},"issue":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/6"},"comments":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC/statuses/4b5c0511886236ad78c90e369bcb5e643921a8ed"}},"author_association":"COLLABORATOR"}}
|
{
"id": 209044358,
"name": "SOC-Training-Tool/ImmutableSOC",
"url": "https://api.github.com/repos/SOC-Training-Tool/ImmutableSOC"
}
|
{
"id": 8742154,
"login": "danielglasgow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8742154?",
"url": "https://api.github.com/users/danielglasgow"
}
|
{
"id": 55442794,
"login": "SOC-Training-Tool",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55442794?",
"url": "https://api.github.com/orgs/SOC-Training-Tool"
}
| 2019-10-11T14:20:45 |
10611410098
|
{"actor":{"display_login":"danielglasgow"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/comments/343295224","pull_request_review_id":312690705,"id":343295224,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzI5NTIyNA==","diff_hunk":"@@ -28,21 +45,76 @@ app.get('/people/:id', (req, res, next) => {\n res.json(record[0]);\n });\n \n+/**\n+ * @route POST /api/v1/:model\n+ * Model must be a proper model, located within the ../models folder\n+ * @param {model} model.path.required\n+ * @returns {object} 200 - Count of results with an array of results\n+ * @returns {Error} 500 - Unexpected error\n+ */\n+\n // Route to Create a person\n app.post('/people', (req, res, next) => {\n let record = req.body;\n- // what can you do to ensure there are no\n- // duplicate ids?\n- record.id = Math.random();\n+ record.id = db.teams.length+=100;\n db.people.push(record);\n res.json(record);\n });\n \n // Route to Update a person\n-app.put('/people/:id', (req, res, next) => {});\n+app.put('/people/:id', (req, res, next) => {\n+ let id = parseInt(req.params.id);\n+ let record = db.people.filter(record => record.id === id);\n+ record[0].firstName = req.body.firstName;\n+ record[0].lastName = req.body.lastName;\n+ record[0].birthday = req.body.birthday;\n+ record[0].team = req.body.team; \n+ record[0].likes = req.body.likes;\n+ \n+ res.json(record);\n+});\n \n // Route to Delete a person\n-app.delete('/people/:id', (req, res, next) => {});\n+app.delete('/people/:id', (req, res, next) => {\n+ let id = req.params.id;\n+ db.people = db.people.filter(record => record.id !== parseInt(id));\n+ res.json(db.people);\n+});\n+\n+\n+// Route to Get a team\n+app.get('/teams/:id', (req, res, next) => {\n+ let id = req.params.id;\n+ let record = db.teams.filter(record => record.id === parseInt(id));\n+ res.json(record[0]);\n+});\n+\n+// Route to Create a team\n+app.post('/teams', (req, res, next) => {\n+ let record = req.body;\n+ // what can you do to ensure there are no\n+ // duplicate ids?\n+ record.id = db.teams.length+=100;\n+ db.teams.push(record);\n+ res.json(record);\n+});\n+\n+// Route to Update a team\n+app.put('/teams/:id', (req, res, next) => {\n+ let id = parseInt(req.params.id);\n+ let record = db.teams.filter(record => record.id === id);\n+ record[0].fname = req.body.name;\n+ record[0].color = req.body.color;\n+ res.json(record);\n+});","path":"lib/server.js","position":110,"original_position":110,"commit_id":"b7c432a9926646d1f393e2197ba9c7df7bcfe93a","original_commit_id":"b7c432a9926646d1f393e2197ba9c7df7bcfe93a","user":{"login":"soniakandah","id":22336391,"node_id":"MDQ6VXNlcjIyMzM2Mzkx","avatar_url":"https://avatars2.githubusercontent.com/u/22336391?v=4","gravatar_id":"","url":"https://api.github.com/users/soniakandah","html_url":"https://github.com/soniakandah","followers_url":"https://api.github.com/users/soniakandah/followers","following_url":"https://api.github.com/users/soniakandah/following{/other_user}","gists_url":"https://api.github.com/users/soniakandah/gists{/gist_id}","starred_url":"https://api.github.com/users/soniakandah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soniakandah/subscriptions","organizations_url":"https://api.github.com/users/soniakandah/orgs","repos_url":"https://api.github.com/users/soniakandah/repos","events_url":"https://api.github.com/users/soniakandah/events{/privacy}","received_events_url":"https://api.github.com/users/soniakandah/received_events","type":"User","site_admin":false},"body":"This route should be modularized","created_at":"2019-11-06T19:51:10Z","updated_at":"2019-11-06T19:58:31Z","html_url":"https://github.com/nadili-401-advanced-javascript/lab-07/pull/1#discussion_r343295224","pull_request_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/comments/343295224"},"html":{"href":"https://github.com/nadili-401-advanced-javascript/lab-07/pull/1#discussion_r343295224"},"pull_request":{"href":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/1","id":330838257,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwODM4MjU3","html_url":"https://github.com/nadili-401-advanced-javascript/lab-07/pull/1","diff_url":"https://github.com/nadili-401-advanced-javascript/lab-07/pull/1.diff","patch_url":"https://github.com/nadili-401-advanced-javascript/lab-07/pull/1.patch","issue_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues/1","number":1,"state":"open","locked":false,"title":"Dev","user":{"login":"NadyaIlinskiy","id":17692994,"node_id":"MDQ6VXNlcjE3NjkyOTk0","avatar_url":"https://avatars2.githubusercontent.com/u/17692994?v=4","gravatar_id":"","url":"https://api.github.com/users/NadyaIlinskiy","html_url":"https://github.com/NadyaIlinskiy","followers_url":"https://api.github.com/users/NadyaIlinskiy/followers","following_url":"https://api.github.com/users/NadyaIlinskiy/following{/other_user}","gists_url":"https://api.github.com/users/NadyaIlinskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/NadyaIlinskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NadyaIlinskiy/subscriptions","organizations_url":"https://api.github.com/users/NadyaIlinskiy/orgs","repos_url":"https://api.github.com/users/NadyaIlinskiy/repos","events_url":"https://api.github.com/users/NadyaIlinskiy/events{/privacy}","received_events_url":"https://api.github.com/users/NadyaIlinskiy/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-22T07:08:04Z","updated_at":"2019-11-06T19:58:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55f562fcf1a5f1ca2c95a29d78fc159c91a48949","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/1/commits","review_comments_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/1/comments","review_comment_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues/1/comments","statuses_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/statuses/b7c432a9926646d1f393e2197ba9c7df7bcfe93a","head":{"label":"nadili-401-advanced-javascript:dev","ref":"dev","sha":"b7c432a9926646d1f393e2197ba9c7df7bcfe93a","user":{"login":"nadili-401-advanced-javascript","id":55898347,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODk4MzQ3","avatar_url":"https://avatars3.githubusercontent.com/u/55898347?v=4","gravatar_id":"","url":"https://api.github.com/users/nadili-401-advanced-javascript","html_url":"https://github.com/nadili-401-advanced-javascript","followers_url":"https://api.github.com/users/nadili-401-advanced-javascript/followers","following_url":"https://api.github.com/users/nadili-401-advanced-javascript/following{/other_user}","gists_url":"https://api.github.com/users/nadili-401-advanced-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/nadili-401-advanced-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadili-401-advanced-javascript/subscriptions","organizations_url":"https://api.github.com/users/nadili-401-advanced-javascript/orgs","repos_url":"https://api.github.com/users/nadili-401-advanced-javascript/repos","events_url":"https://api.github.com/users/nadili-401-advanced-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/nadili-401-advanced-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":216716812,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY3MTY4MTI=","name":"lab-07","full_name":"nadili-401-advanced-javascript/lab-07","private":false,"owner":{"login":"nadili-401-advanced-javascript","id":55898347,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODk4MzQ3","avatar_url":"https://avatars3.githubusercontent.com/u/55898347?v=4","gravatar_id":"","url":"https://api.github.com/users/nadili-401-advanced-javascript","html_url":"https://github.com/nadili-401-advanced-javascript","followers_url":"https://api.github.com/users/nadili-401-advanced-javascript/followers","following_url":"https://api.github.com/users/nadili-401-advanced-javascript/following{/other_user}","gists_url":"https://api.github.com/users/nadili-401-advanced-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/nadili-401-advanced-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadili-401-advanced-javascript/subscriptions","organizations_url":"https://api.github.com/users/nadili-401-advanced-javascript/orgs","repos_url":"https://api.github.com/users/nadili-401-advanced-javascript/repos","events_url":"https://api.github.com/users/nadili-401-advanced-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/nadili-401-advanced-javascript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nadili-401-advanced-javascript/lab-07","description":"Express","fork":false,"url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07","forks_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/forks","keys_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/teams","hooks_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/hooks","issue_events_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues/events{/number}","events_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/events","assignees_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/assignees{/user}","branches_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/branches{/branch}","tags_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/tags","blobs_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/refs{/sha}","trees_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/statuses/{sha}","languages_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/languages","stargazers_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/stargazers","contributors_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/contributors","subscribers_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/subscribers","subscription_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/subscription","commits_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/commits{/sha}","git_commits_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/commits{/sha}","comments_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/comments{/number}","issue_comment_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues/comments{/number}","contents_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/contents/{+path}","compare_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/merges","archive_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/downloads","issues_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues{/number}","pulls_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls{/number}","milestones_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/milestones{/number}","notifications_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/labels{/name}","releases_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/releases{/id}","deployments_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/deployments","created_at":"2019-10-22T03:36:24Z","updated_at":"2019-10-22T03:38:44Z","pushed_at":"2019-10-23T02:06:46Z","git_url":"git://github.com/nadili-401-advanced-javascript/lab-07.git","ssh_url":"[email protected]:nadili-401-advanced-javascript/lab-07.git","clone_url":"https://github.com/nadili-401-advanced-javascript/lab-07.git","svn_url":"https://github.com/nadili-401-advanced-javascript/lab-07","homepage":null,"size":892,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nadili-401-advanced-javascript:master","ref":"master","sha":"6dd8185f0bdc2b82a06b67f48b84ac43cdad864b","user":{"login":"nadili-401-advanced-javascript","id":55898347,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODk4MzQ3","avatar_url":"https://avatars3.githubusercontent.com/u/55898347?v=4","gravatar_id":"","url":"https://api.github.com/users/nadili-401-advanced-javascript","html_url":"https://github.com/nadili-401-advanced-javascript","followers_url":"https://api.github.com/users/nadili-401-advanced-javascript/followers","following_url":"https://api.github.com/users/nadili-401-advanced-javascript/following{/other_user}","gists_url":"https://api.github.com/users/nadili-401-advanced-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/nadili-401-advanced-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadili-401-advanced-javascript/subscriptions","organizations_url":"https://api.github.com/users/nadili-401-advanced-javascript/orgs","repos_url":"https://api.github.com/users/nadili-401-advanced-javascript/repos","events_url":"https://api.github.com/users/nadili-401-advanced-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/nadili-401-advanced-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":216716812,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY3MTY4MTI=","name":"lab-07","full_name":"nadili-401-advanced-javascript/lab-07","private":false,"owner":{"login":"nadili-401-advanced-javascript","id":55898347,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODk4MzQ3","avatar_url":"https://avatars3.githubusercontent.com/u/55898347?v=4","gravatar_id":"","url":"https://api.github.com/users/nadili-401-advanced-javascript","html_url":"https://github.com/nadili-401-advanced-javascript","followers_url":"https://api.github.com/users/nadili-401-advanced-javascript/followers","following_url":"https://api.github.com/users/nadili-401-advanced-javascript/following{/other_user}","gists_url":"https://api.github.com/users/nadili-401-advanced-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/nadili-401-advanced-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadili-401-advanced-javascript/subscriptions","organizations_url":"https://api.github.com/users/nadili-401-advanced-javascript/orgs","repos_url":"https://api.github.com/users/nadili-401-advanced-javascript/repos","events_url":"https://api.github.com/users/nadili-401-advanced-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/nadili-401-advanced-javascript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nadili-401-advanced-javascript/lab-07","description":"Express","fork":false,"url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07","forks_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/forks","keys_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/teams","hooks_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/hooks","issue_events_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues/events{/number}","events_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/events","assignees_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/assignees{/user}","branches_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/branches{/branch}","tags_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/tags","blobs_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/refs{/sha}","trees_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/statuses/{sha}","languages_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/languages","stargazers_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/stargazers","contributors_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/contributors","subscribers_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/subscribers","subscription_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/subscription","commits_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/commits{/sha}","git_commits_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/git/commits{/sha}","comments_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/comments{/number}","issue_comment_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues/comments{/number}","contents_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/contents/{+path}","compare_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/merges","archive_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/downloads","issues_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues{/number}","pulls_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls{/number}","milestones_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/milestones{/number}","notifications_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/labels{/name}","releases_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/releases{/id}","deployments_url":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/deployments","created_at":"2019-10-22T03:36:24Z","updated_at":"2019-10-22T03:38:44Z","pushed_at":"2019-10-23T02:06:46Z","git_url":"git://github.com/nadili-401-advanced-javascript/lab-07.git","ssh_url":"[email protected]:nadili-401-advanced-javascript/lab-07.git","clone_url":"https://github.com/nadili-401-advanced-javascript/lab-07.git","svn_url":"https://github.com/nadili-401-advanced-javascript/lab-07","homepage":null,"size":892,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/1"},"html":{"href":"https://github.com/nadili-401-advanced-javascript/lab-07/pull/1"},"issue":{"href":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues/1"},"comments":{"href":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/nadili-401-advanced-javascript/lab-07/statuses/b7c432a9926646d1f393e2197ba9c7df7bcfe93a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 216716812,
"name": "nadili-401-advanced-javascript/lab-07",
"url": "https://api.github.com/repos/nadili-401-advanced-javascript/lab-07"
}
|
{
"id": 22336391,
"login": "soniakandah",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22336391?",
"url": "https://api.github.com/users/soniakandah"
}
|
{
"id": 55898347,
"login": "nadili-401-advanced-javascript",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55898347?",
"url": "https://api.github.com/orgs/nadili-401-advanced-javascript"
}
| 2019-11-06T19:51:10 |
10803470276
|
{"actor":{"display_login":"soniakandah"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityThing/Bingo/pulls/comments/336044803","pull_request_review_id":303308484,"id":336044803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjA0NDgwMw==","diff_hunk":"@@ -0,0 +1,41 @@\n+import sys\n+\n+\n+class PointsContainer:\n+\n+ def __init__(self, argv=None):\n+ pass\n+\n+ def setPlayersAndOptions(self, player_and_options: set):\n+ self.__players_and_options = player_and_options\n+ self.__addPlayers()\n+\n+ def addPointToPlayer(self, player: str, points: int = 1):\n+ if not player in self.__players_and_options: raise Exception(\"Errror\")\n+ if points < 0: raise ValueError(\"Errror\")","path":"points_container/PointsContainer.py","position":15,"original_position":15,"commit_id":"b7ff89e9720eec938cc678e1af8c97602cb68009","original_commit_id":"b7ff89e9720eec938cc678e1af8c97602cb68009","user":{"login":"Tranzystorek","id":5671049,"node_id":"MDQ6VXNlcjU2NzEwNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5671049?v=4","gravatar_id":"","url":"https://api.github.com/users/Tranzystorek","html_url":"https://github.com/Tranzystorek","followers_url":"https://api.github.com/users/Tranzystorek/followers","following_url":"https://api.github.com/users/Tranzystorek/following{/other_user}","gists_url":"https://api.github.com/users/Tranzystorek/gists{/gist_id}","starred_url":"https://api.github.com/users/Tranzystorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tranzystorek/subscriptions","organizations_url":"https://api.github.com/users/Tranzystorek/orgs","repos_url":"https://api.github.com/users/Tranzystorek/repos","events_url":"https://api.github.com/users/Tranzystorek/events{/privacy}","received_events_url":"https://api.github.com/users/Tranzystorek/received_events","type":"User","site_admin":false},"body":"Typo in \"Errror\"","created_at":"2019-10-17T14:38:26Z","updated_at":"2019-10-17T14:38:26Z","html_url":"https://github.com/TrinityThing/Bingo/pull/8#discussion_r336044803","pull_request_url":"https://api.github.com/repos/TrinityThing/Bingo/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/TrinityThing/Bingo/pulls/comments/336044803"},"html":{"href":"https://github.com/TrinityThing/Bingo/pull/8#discussion_r336044803"},"pull_request":{"href":"https://api.github.com/repos/TrinityThing/Bingo/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityThing/Bingo/pulls/8","id":329229446,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MjI5NDQ2","html_url":"https://github.com/TrinityThing/Bingo/pull/8","diff_url":"https://github.com/TrinityThing/Bingo/pull/8.diff","patch_url":"https://github.com/TrinityThing/Bingo/pull/8.patch","issue_url":"https://api.github.com/repos/TrinityThing/Bingo/issues/8","number":8,"state":"open","locked":false,"title":"Add Adding Points mechanism. Storing points is not supported yet","user":{"login":"HalfInner","id":20933478,"node_id":"MDQ6VXNlcjIwOTMzNDc4","avatar_url":"https://avatars1.githubusercontent.com/u/20933478?v=4","gravatar_id":"","url":"https://api.github.com/users/HalfInner","html_url":"https://github.com/HalfInner","followers_url":"https://api.github.com/users/HalfInner/followers","following_url":"https://api.github.com/users/HalfInner/following{/other_user}","gists_url":"https://api.github.com/users/HalfInner/gists{/gist_id}","starred_url":"https://api.github.com/users/HalfInner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HalfInner/subscriptions","organizations_url":"https://api.github.com/users/HalfInner/orgs","repos_url":"https://api.github.com/users/HalfInner/repos","events_url":"https://api.github.com/users/HalfInner/events{/privacy}","received_events_url":"https://api.github.com/users/HalfInner/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-17T12:20:33Z","updated_at":"2019-10-17T14:38:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d74ec6dec862a8f5bdb0635aea033c66aa566f99","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Opalaczi","id":56642629,"node_id":"MDQ6VXNlcjU2NjQyNjI5","avatar_url":"https://avatars1.githubusercontent.com/u/56642629?v=4","gravatar_id":"","url":"https://api.github.com/users/Opalaczi","html_url":"https://github.com/Opalaczi","followers_url":"https://api.github.com/users/Opalaczi/followers","following_url":"https://api.github.com/users/Opalaczi/following{/other_user}","gists_url":"https://api.github.com/users/Opalaczi/gists{/gist_id}","starred_url":"https://api.github.com/users/Opalaczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opalaczi/subscriptions","organizations_url":"https://api.github.com/users/Opalaczi/orgs","repos_url":"https://api.github.com/users/Opalaczi/repos","events_url":"https://api.github.com/users/Opalaczi/events{/privacy}","received_events_url":"https://api.github.com/users/Opalaczi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityThing/Bingo/pulls/8/commits","review_comments_url":"https://api.github.com/repos/TrinityThing/Bingo/pulls/8/comments","review_comment_url":"https://api.github.com/repos/TrinityThing/Bingo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityThing/Bingo/issues/8/comments","statuses_url":"https://api.github.com/repos/TrinityThing/Bingo/statuses/b7ff89e9720eec938cc678e1af8c97602cb68009","head":{"label":"TrinityThing:Bingo_Development_AddAddingPoints","ref":"Bingo_Development_AddAddingPoints","sha":"b7ff89e9720eec938cc678e1af8c97602cb68009","user":{"login":"TrinityThing","id":56642527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjQyNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/56642527?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityThing","html_url":"https://github.com/TrinityThing","followers_url":"https://api.github.com/users/TrinityThing/followers","following_url":"https://api.github.com/users/TrinityThing/following{/other_user}","gists_url":"https://api.github.com/users/TrinityThing/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityThing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityThing/subscriptions","organizations_url":"https://api.github.com/users/TrinityThing/orgs","repos_url":"https://api.github.com/users/TrinityThing/repos","events_url":"https://api.github.com/users/TrinityThing/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityThing/received_events","type":"Organization","site_admin":false},"repo":{"id":215561173,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU1NjExNzM=","name":"Bingo","full_name":"TrinityThing/Bingo","private":false,"owner":{"login":"TrinityThing","id":56642527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjQyNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/56642527?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityThing","html_url":"https://github.com/TrinityThing","followers_url":"https://api.github.com/users/TrinityThing/followers","following_url":"https://api.github.com/users/TrinityThing/following{/other_user}","gists_url":"https://api.github.com/users/TrinityThing/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityThing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityThing/subscriptions","organizations_url":"https://api.github.com/users/TrinityThing/orgs","repos_url":"https://api.github.com/users/TrinityThing/repos","events_url":"https://api.github.com/users/TrinityThing/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityThing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TrinityThing/Bingo","description":"Simple Game","fork":false,"url":"https://api.github.com/repos/TrinityThing/Bingo","forks_url":"https://api.github.com/repos/TrinityThing/Bingo/forks","keys_url":"https://api.github.com/repos/TrinityThing/Bingo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityThing/Bingo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityThing/Bingo/teams","hooks_url":"https://api.github.com/repos/TrinityThing/Bingo/hooks","issue_events_url":"https://api.github.com/repos/TrinityThing/Bingo/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityThing/Bingo/events","assignees_url":"https://api.github.com/repos/TrinityThing/Bingo/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityThing/Bingo/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityThing/Bingo/tags","blobs_url":"https://api.github.com/repos/TrinityThing/Bingo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityThing/Bingo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityThing/Bingo/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityThing/Bingo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityThing/Bingo/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityThing/Bingo/languages","stargazers_url":"https://api.github.com/repos/TrinityThing/Bingo/stargazers","contributors_url":"https://api.github.com/repos/TrinityThing/Bingo/contributors","subscribers_url":"https://api.github.com/repos/TrinityThing/Bingo/subscribers","subscription_url":"https://api.github.com/repos/TrinityThing/Bingo/subscription","commits_url":"https://api.github.com/repos/TrinityThing/Bingo/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityThing/Bingo/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityThing/Bingo/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityThing/Bingo/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityThing/Bingo/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityThing/Bingo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityThing/Bingo/merges","archive_url":"https://api.github.com/repos/TrinityThing/Bingo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityThing/Bingo/downloads","issues_url":"https://api.github.com/repos/TrinityThing/Bingo/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityThing/Bingo/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityThing/Bingo/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityThing/Bingo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityThing/Bingo/labels{/name}","releases_url":"https://api.github.com/repos/TrinityThing/Bingo/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityThing/Bingo/deployments","created_at":"2019-10-16T13:55:28Z","updated_at":"2019-10-17T12:23:41Z","pushed_at":"2019-10-17T12:23:40Z","git_url":"git://github.com/TrinityThing/Bingo.git","ssh_url":"[email protected]:TrinityThing/Bingo.git","clone_url":"https://github.com/TrinityThing/Bingo.git","svn_url":"https://github.com/TrinityThing/Bingo","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"TrinityThing:master","ref":"master","sha":"3c1407377ae33bb6889c55169c526a8a6178c891","user":{"login":"TrinityThing","id":56642527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjQyNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/56642527?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityThing","html_url":"https://github.com/TrinityThing","followers_url":"https://api.github.com/users/TrinityThing/followers","following_url":"https://api.github.com/users/TrinityThing/following{/other_user}","gists_url":"https://api.github.com/users/TrinityThing/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityThing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityThing/subscriptions","organizations_url":"https://api.github.com/users/TrinityThing/orgs","repos_url":"https://api.github.com/users/TrinityThing/repos","events_url":"https://api.github.com/users/TrinityThing/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityThing/received_events","type":"Organization","site_admin":false},"repo":{"id":215561173,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU1NjExNzM=","name":"Bingo","full_name":"TrinityThing/Bingo","private":false,"owner":{"login":"TrinityThing","id":56642527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjQyNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/56642527?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityThing","html_url":"https://github.com/TrinityThing","followers_url":"https://api.github.com/users/TrinityThing/followers","following_url":"https://api.github.com/users/TrinityThing/following{/other_user}","gists_url":"https://api.github.com/users/TrinityThing/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityThing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityThing/subscriptions","organizations_url":"https://api.github.com/users/TrinityThing/orgs","repos_url":"https://api.github.com/users/TrinityThing/repos","events_url":"https://api.github.com/users/TrinityThing/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityThing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TrinityThing/Bingo","description":"Simple Game","fork":false,"url":"https://api.github.com/repos/TrinityThing/Bingo","forks_url":"https://api.github.com/repos/TrinityThing/Bingo/forks","keys_url":"https://api.github.com/repos/TrinityThing/Bingo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityThing/Bingo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityThing/Bingo/teams","hooks_url":"https://api.github.com/repos/TrinityThing/Bingo/hooks","issue_events_url":"https://api.github.com/repos/TrinityThing/Bingo/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityThing/Bingo/events","assignees_url":"https://api.github.com/repos/TrinityThing/Bingo/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityThing/Bingo/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityThing/Bingo/tags","blobs_url":"https://api.github.com/repos/TrinityThing/Bingo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityThing/Bingo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityThing/Bingo/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityThing/Bingo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityThing/Bingo/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityThing/Bingo/languages","stargazers_url":"https://api.github.com/repos/TrinityThing/Bingo/stargazers","contributors_url":"https://api.github.com/repos/TrinityThing/Bingo/contributors","subscribers_url":"https://api.github.com/repos/TrinityThing/Bingo/subscribers","subscription_url":"https://api.github.com/repos/TrinityThing/Bingo/subscription","commits_url":"https://api.github.com/repos/TrinityThing/Bingo/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityThing/Bingo/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityThing/Bingo/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityThing/Bingo/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityThing/Bingo/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityThing/Bingo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityThing/Bingo/merges","archive_url":"https://api.github.com/repos/TrinityThing/Bingo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityThing/Bingo/downloads","issues_url":"https://api.github.com/repos/TrinityThing/Bingo/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityThing/Bingo/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityThing/Bingo/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityThing/Bingo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityThing/Bingo/labels{/name}","releases_url":"https://api.github.com/repos/TrinityThing/Bingo/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityThing/Bingo/deployments","created_at":"2019-10-16T13:55:28Z","updated_at":"2019-10-17T12:23:41Z","pushed_at":"2019-10-17T12:23:40Z","git_url":"git://github.com/TrinityThing/Bingo.git","ssh_url":"[email protected]:TrinityThing/Bingo.git","clone_url":"https://github.com/TrinityThing/Bingo.git","svn_url":"https://github.com/TrinityThing/Bingo","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityThing/Bingo/pulls/8"},"html":{"href":"https://github.com/TrinityThing/Bingo/pull/8"},"issue":{"href":"https://api.github.com/repos/TrinityThing/Bingo/issues/8"},"comments":{"href":"https://api.github.com/repos/TrinityThing/Bingo/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityThing/Bingo/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityThing/Bingo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityThing/Bingo/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityThing/Bingo/statuses/b7ff89e9720eec938cc678e1af8c97602cb68009"}},"author_association":"COLLABORATOR"}}
|
{
"id": 215561173,
"name": "TrinityThing/Bingo",
"url": "https://api.github.com/repos/TrinityThing/Bingo"
}
|
{
"id": 5671049,
"login": "Tranzystorek",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5671049?",
"url": "https://api.github.com/users/Tranzystorek"
}
|
{
"id": 56642527,
"login": "TrinityThing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56642527?",
"url": "https://api.github.com/orgs/TrinityThing"
}
| 2019-10-17T14:38:26 |
10653562039
|
{"actor":{"display_login":"Tranzystorek"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/comments/340136973","pull_request_review_id":308590777,"id":340136973,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MDEzNjk3Mw==","diff_hunk":"@@ -0,0 +1,13 @@\n+[FORMAT]\n+indent-string=' '\n+max-line-length=100","path":".pylintrc","position":3,"original_position":3,"commit_id":"ad0d55c4eb89287418ff9e6b362d45f1519350e9","original_commit_id":"89cb1b346c9d99be72933eba24374c822725d7c9","user":{"login":"mconcas","id":4990252,"node_id":"MDQ6VXNlcjQ5OTAyNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4990252?v=4","gravatar_id":"","url":"https://api.github.com/users/mconcas","html_url":"https://github.com/mconcas","followers_url":"https://api.github.com/users/mconcas/followers","following_url":"https://api.github.com/users/mconcas/following{/other_user}","gists_url":"https://api.github.com/users/mconcas/gists{/gist_id}","starred_url":"https://api.github.com/users/mconcas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconcas/subscriptions","organizations_url":"https://api.github.com/users/mconcas/orgs","repos_url":"https://api.github.com/users/mconcas/repos","events_url":"https://api.github.com/users/mconcas/events{/privacy}","received_events_url":"https://api.github.com/users/mconcas/received_events","type":"User","site_admin":false},"body":"Fine to me","created_at":"2019-10-29T15:09:44Z","updated_at":"2019-10-29T15:09:45Z","html_url":"https://github.com/hipe4ml/hipe4ml/pull/9#discussion_r340136973","pull_request_url":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/comments/340136973"},"html":{"href":"https://github.com/hipe4ml/hipe4ml/pull/9#discussion_r340136973"},"pull_request":{"href":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/9"}},"in_reply_to_id":340124920},"pull_request":{"url":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/9","id":333651439,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzNjUxNDM5","html_url":"https://github.com/hipe4ml/hipe4ml/pull/9","diff_url":"https://github.com/hipe4ml/hipe4ml/pull/9.diff","patch_url":"https://github.com/hipe4ml/hipe4ml/pull/9.patch","issue_url":"https://api.github.com/repos/hipe4ml/hipe4ml/issues/9","number":9,"state":"open","locked":false,"title":"[WIP] Improve tests","user":{"login":"mconcas","id":4990252,"node_id":"MDQ6VXNlcjQ5OTAyNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4990252?v=4","gravatar_id":"","url":"https://api.github.com/users/mconcas","html_url":"https://github.com/mconcas","followers_url":"https://api.github.com/users/mconcas/followers","following_url":"https://api.github.com/users/mconcas/following{/other_user}","gists_url":"https://api.github.com/users/mconcas/gists{/gist_id}","starred_url":"https://api.github.com/users/mconcas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconcas/subscriptions","organizations_url":"https://api.github.com/users/mconcas/orgs","repos_url":"https://api.github.com/users/mconcas/repos","events_url":"https://api.github.com/users/mconcas/events{/privacy}","received_events_url":"https://api.github.com/users/mconcas/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-29T14:27:22Z","updated_at":"2019-10-29T15:09:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40a6ce870c86525d28c52eab8f3e5256bcab1d94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/9/commits","review_comments_url":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/9/comments","review_comment_url":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hipe4ml/hipe4ml/issues/9/comments","statuses_url":"https://api.github.com/repos/hipe4ml/hipe4ml/statuses/ad0d55c4eb89287418ff9e6b362d45f1519350e9","head":{"label":"mconcas:setup-package","ref":"setup-package","sha":"ad0d55c4eb89287418ff9e6b362d45f1519350e9","user":{"login":"mconcas","id":4990252,"node_id":"MDQ6VXNlcjQ5OTAyNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4990252?v=4","gravatar_id":"","url":"https://api.github.com/users/mconcas","html_url":"https://github.com/mconcas","followers_url":"https://api.github.com/users/mconcas/followers","following_url":"https://api.github.com/users/mconcas/following{/other_user}","gists_url":"https://api.github.com/users/mconcas/gists{/gist_id}","starred_url":"https://api.github.com/users/mconcas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconcas/subscriptions","organizations_url":"https://api.github.com/users/mconcas/orgs","repos_url":"https://api.github.com/users/mconcas/repos","events_url":"https://api.github.com/users/mconcas/events{/privacy}","received_events_url":"https://api.github.com/users/mconcas/received_events","type":"User","site_admin":false},"repo":{"id":218022130,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgwMjIxMzA=","name":"hipe4ml","full_name":"mconcas/hipe4ml","private":false,"owner":{"login":"mconcas","id":4990252,"node_id":"MDQ6VXNlcjQ5OTAyNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4990252?v=4","gravatar_id":"","url":"https://api.github.com/users/mconcas","html_url":"https://github.com/mconcas","followers_url":"https://api.github.com/users/mconcas/followers","following_url":"https://api.github.com/users/mconcas/following{/other_user}","gists_url":"https://api.github.com/users/mconcas/gists{/gist_id}","starred_url":"https://api.github.com/users/mconcas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconcas/subscriptions","organizations_url":"https://api.github.com/users/mconcas/orgs","repos_url":"https://api.github.com/users/mconcas/repos","events_url":"https://api.github.com/users/mconcas/events{/privacy}","received_events_url":"https://api.github.com/users/mconcas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mconcas/hipe4ml","description":"Minimal heavy ion physics environment for Machine Learning","fork":true,"url":"https://api.github.com/repos/mconcas/hipe4ml","forks_url":"https://api.github.com/repos/mconcas/hipe4ml/forks","keys_url":"https://api.github.com/repos/mconcas/hipe4ml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mconcas/hipe4ml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mconcas/hipe4ml/teams","hooks_url":"https://api.github.com/repos/mconcas/hipe4ml/hooks","issue_events_url":"https://api.github.com/repos/mconcas/hipe4ml/issues/events{/number}","events_url":"https://api.github.com/repos/mconcas/hipe4ml/events","assignees_url":"https://api.github.com/repos/mconcas/hipe4ml/assignees{/user}","branches_url":"https://api.github.com/repos/mconcas/hipe4ml/branches{/branch}","tags_url":"https://api.github.com/repos/mconcas/hipe4ml/tags","blobs_url":"https://api.github.com/repos/mconcas/hipe4ml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mconcas/hipe4ml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mconcas/hipe4ml/git/refs{/sha}","trees_url":"https://api.github.com/repos/mconcas/hipe4ml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mconcas/hipe4ml/statuses/{sha}","languages_url":"https://api.github.com/repos/mconcas/hipe4ml/languages","stargazers_url":"https://api.github.com/repos/mconcas/hipe4ml/stargazers","contributors_url":"https://api.github.com/repos/mconcas/hipe4ml/contributors","subscribers_url":"https://api.github.com/repos/mconcas/hipe4ml/subscribers","subscription_url":"https://api.github.com/repos/mconcas/hipe4ml/subscription","commits_url":"https://api.github.com/repos/mconcas/hipe4ml/commits{/sha}","git_commits_url":"https://api.github.com/repos/mconcas/hipe4ml/git/commits{/sha}","comments_url":"https://api.github.com/repos/mconcas/hipe4ml/comments{/number}","issue_comment_url":"https://api.github.com/repos/mconcas/hipe4ml/issues/comments{/number}","contents_url":"https://api.github.com/repos/mconcas/hipe4ml/contents/{+path}","compare_url":"https://api.github.com/repos/mconcas/hipe4ml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mconcas/hipe4ml/merges","archive_url":"https://api.github.com/repos/mconcas/hipe4ml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mconcas/hipe4ml/downloads","issues_url":"https://api.github.com/repos/mconcas/hipe4ml/issues{/number}","pulls_url":"https://api.github.com/repos/mconcas/hipe4ml/pulls{/number}","milestones_url":"https://api.github.com/repos/mconcas/hipe4ml/milestones{/number}","notifications_url":"https://api.github.com/repos/mconcas/hipe4ml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mconcas/hipe4ml/labels{/name}","releases_url":"https://api.github.com/repos/mconcas/hipe4ml/releases{/id}","deployments_url":"https://api.github.com/repos/mconcas/hipe4ml/deployments","created_at":"2019-10-28T10:32:10Z","updated_at":"2019-10-28T11:19:25Z","pushed_at":"2019-10-29T15:00:59Z","git_url":"git://github.com/mconcas/hipe4ml.git","ssh_url":"[email protected]:mconcas/hipe4ml.git","clone_url":"https://github.com/mconcas/hipe4ml.git","svn_url":"https://github.com/mconcas/hipe4ml","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hipe4ml:master","ref":"master","sha":"4b47275b8f54e4c2aea8fc0225e6a605f36f1b78","user":{"login":"hipe4ml","id":56888924,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODg4OTI0","avatar_url":"https://avatars2.githubusercontent.com/u/56888924?v=4","gravatar_id":"","url":"https://api.github.com/users/hipe4ml","html_url":"https://github.com/hipe4ml","followers_url":"https://api.github.com/users/hipe4ml/followers","following_url":"https://api.github.com/users/hipe4ml/following{/other_user}","gists_url":"https://api.github.com/users/hipe4ml/gists{/gist_id}","starred_url":"https://api.github.com/users/hipe4ml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hipe4ml/subscriptions","organizations_url":"https://api.github.com/users/hipe4ml/orgs","repos_url":"https://api.github.com/users/hipe4ml/repos","events_url":"https://api.github.com/users/hipe4ml/events{/privacy}","received_events_url":"https://api.github.com/users/hipe4ml/received_events","type":"Organization","site_admin":false},"repo":{"id":218020957,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgwMjA5NTc=","name":"hipe4ml","full_name":"hipe4ml/hipe4ml","private":false,"owner":{"login":"hipe4ml","id":56888924,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODg4OTI0","avatar_url":"https://avatars2.githubusercontent.com/u/56888924?v=4","gravatar_id":"","url":"https://api.github.com/users/hipe4ml","html_url":"https://github.com/hipe4ml","followers_url":"https://api.github.com/users/hipe4ml/followers","following_url":"https://api.github.com/users/hipe4ml/following{/other_user}","gists_url":"https://api.github.com/users/hipe4ml/gists{/gist_id}","starred_url":"https://api.github.com/users/hipe4ml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hipe4ml/subscriptions","organizations_url":"https://api.github.com/users/hipe4ml/orgs","repos_url":"https://api.github.com/users/hipe4ml/repos","events_url":"https://api.github.com/users/hipe4ml/events{/privacy}","received_events_url":"https://api.github.com/users/hipe4ml/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hipe4ml/hipe4ml","description":"Minimal heavy ion physics environment for Machine Learning","fork":false,"url":"https://api.github.com/repos/hipe4ml/hipe4ml","forks_url":"https://api.github.com/repos/hipe4ml/hipe4ml/forks","keys_url":"https://api.github.com/repos/hipe4ml/hipe4ml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hipe4ml/hipe4ml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hipe4ml/hipe4ml/teams","hooks_url":"https://api.github.com/repos/hipe4ml/hipe4ml/hooks","issue_events_url":"https://api.github.com/repos/hipe4ml/hipe4ml/issues/events{/number}","events_url":"https://api.github.com/repos/hipe4ml/hipe4ml/events","assignees_url":"https://api.github.com/repos/hipe4ml/hipe4ml/assignees{/user}","branches_url":"https://api.github.com/repos/hipe4ml/hipe4ml/branches{/branch}","tags_url":"https://api.github.com/repos/hipe4ml/hipe4ml/tags","blobs_url":"https://api.github.com/repos/hipe4ml/hipe4ml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hipe4ml/hipe4ml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hipe4ml/hipe4ml/git/refs{/sha}","trees_url":"https://api.github.com/repos/hipe4ml/hipe4ml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hipe4ml/hipe4ml/statuses/{sha}","languages_url":"https://api.github.com/repos/hipe4ml/hipe4ml/languages","stargazers_url":"https://api.github.com/repos/hipe4ml/hipe4ml/stargazers","contributors_url":"https://api.github.com/repos/hipe4ml/hipe4ml/contributors","subscribers_url":"https://api.github.com/repos/hipe4ml/hipe4ml/subscribers","subscription_url":"https://api.github.com/repos/hipe4ml/hipe4ml/subscription","commits_url":"https://api.github.com/repos/hipe4ml/hipe4ml/commits{/sha}","git_commits_url":"https://api.github.com/repos/hipe4ml/hipe4ml/git/commits{/sha}","comments_url":"https://api.github.com/repos/hipe4ml/hipe4ml/comments{/number}","issue_comment_url":"https://api.github.com/repos/hipe4ml/hipe4ml/issues/comments{/number}","contents_url":"https://api.github.com/repos/hipe4ml/hipe4ml/contents/{+path}","compare_url":"https://api.github.com/repos/hipe4ml/hipe4ml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hipe4ml/hipe4ml/merges","archive_url":"https://api.github.com/repos/hipe4ml/hipe4ml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hipe4ml/hipe4ml/downloads","issues_url":"https://api.github.com/repos/hipe4ml/hipe4ml/issues{/number}","pulls_url":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls{/number}","milestones_url":"https://api.github.com/repos/hipe4ml/hipe4ml/milestones{/number}","notifications_url":"https://api.github.com/repos/hipe4ml/hipe4ml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hipe4ml/hipe4ml/labels{/name}","releases_url":"https://api.github.com/repos/hipe4ml/hipe4ml/releases{/id}","deployments_url":"https://api.github.com/repos/hipe4ml/hipe4ml/deployments","created_at":"2019-10-28T10:25:28Z","updated_at":"2019-10-29T11:57:30Z","pushed_at":"2019-10-29T15:01:00Z","git_url":"git://github.com/hipe4ml/hipe4ml.git","ssh_url":"[email protected]:hipe4ml/hipe4ml.git","clone_url":"https://github.com/hipe4ml/hipe4ml.git","svn_url":"https://github.com/hipe4ml/hipe4ml","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/9"},"html":{"href":"https://github.com/hipe4ml/hipe4ml/pull/9"},"issue":{"href":"https://api.github.com/repos/hipe4ml/hipe4ml/issues/9"},"comments":{"href":"https://api.github.com/repos/hipe4ml/hipe4ml/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hipe4ml/hipe4ml/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/hipe4ml/hipe4ml/statuses/ad0d55c4eb89287418ff9e6b362d45f1519350e9"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 218020957,
"name": "hipe4ml/hipe4ml",
"url": "https://api.github.com/repos/hipe4ml/hipe4ml"
}
|
{
"id": 4990252,
"login": "mconcas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4990252?",
"url": "https://api.github.com/users/mconcas"
}
|
{
"id": 56888924,
"login": "hipe4ml",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56888924?",
"url": "https://api.github.com/orgs/hipe4ml"
}
| 2019-10-29T15:09:44 |
10738681926
|
{"actor":{"display_login":"mconcas"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/comments/344780502","pull_request_review_id":314990054,"id":344780502,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDc4MDUwMg==","diff_hunk":"@@ -88,7 +89,7 @@ export const cart = () => dispatch => {\n const reducer = (state = initialState, action) => {\n switch (action.type) {\n case SHOW_CART:\n- return state.cart\n+ return {...state.cart}","path":"client/store/cart.js","position":22,"original_position":22,"commit_id":"6aedc2f9859f1b4aab9bb275a16e2187b0afcaa5","original_commit_id":"6aedc2f9859f1b4aab9bb275a16e2187b0afcaa5","user":{"login":"mwalsh01","id":4549677,"node_id":"MDQ6VXNlcjQ1NDk2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4549677?v=4","gravatar_id":"","url":"https://api.github.com/users/mwalsh01","html_url":"https://github.com/mwalsh01","followers_url":"https://api.github.com/users/mwalsh01/followers","following_url":"https://api.github.com/users/mwalsh01/following{/other_user}","gists_url":"https://api.github.com/users/mwalsh01/gists{/gist_id}","starred_url":"https://api.github.com/users/mwalsh01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwalsh01/subscriptions","organizations_url":"https://api.github.com/users/mwalsh01/orgs","repos_url":"https://api.github.com/users/mwalsh01/repos","events_url":"https://api.github.com/users/mwalsh01/events{/privacy}","received_events_url":"https://api.github.com/users/mwalsh01/received_events","type":"User","site_admin":false},"body":"I will make the change, but I'm not certain how this works. Looking to review this section to fix the cart.","created_at":"2019-11-11T15:58:20Z","updated_at":"2019-11-11T15:58:21Z","html_url":"https://github.com/arraysin-bran/grace_shopper/pull/52#discussion_r344780502","pull_request_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/52","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/comments/344780502"},"html":{"href":"https://github.com/arraysin-bran/grace_shopper/pull/52#discussion_r344780502"},"pull_request":{"href":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/52"}},"in_reply_to_id":344777747},"pull_request":{"url":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/52","id":339495419,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5NDk1NDE5","html_url":"https://github.com/arraysin-bran/grace_shopper/pull/52","diff_url":"https://github.com/arraysin-bran/grace_shopper/pull/52.diff","patch_url":"https://github.com/arraysin-bran/grace_shopper/pull/52.patch","issue_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues/52","number":52,"state":"open","locked":false,"title":"Add remove cart button functionality","user":{"login":"mwalsh01","id":4549677,"node_id":"MDQ6VXNlcjQ1NDk2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4549677?v=4","gravatar_id":"","url":"https://api.github.com/users/mwalsh01","html_url":"https://github.com/mwalsh01","followers_url":"https://api.github.com/users/mwalsh01/followers","following_url":"https://api.github.com/users/mwalsh01/following{/other_user}","gists_url":"https://api.github.com/users/mwalsh01/gists{/gist_id}","starred_url":"https://api.github.com/users/mwalsh01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwalsh01/subscriptions","organizations_url":"https://api.github.com/users/mwalsh01/orgs","repos_url":"https://api.github.com/users/mwalsh01/repos","events_url":"https://api.github.com/users/mwalsh01/events{/privacy}","received_events_url":"https://api.github.com/users/mwalsh01/received_events","type":"User","site_admin":false},"body":"### Assignee Tasks\r\n\r\n* [ ] added unit tests (or none needed)\r\n* [ ] written relevant docs (or none needed)\r\n* [ ] referenced any relevant issues (or none exist)\r\n\r\n### Guidelines\r\n\r\nPlease add a description of this Pull Request's motivation, scope, outstanding issues or potential alternatives, reasoning behind the current solution, and any other relevant information for posterity.\r\n\r\n---\r\n\r\n_Your PR Notes Here_\r\n","created_at":"2019-11-11T15:43:42Z","updated_at":"2019-11-11T15:58:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44be26cd782b65981c2d2e029b06146b68498d98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/52/commits","review_comments_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/52/comments","review_comment_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues/52/comments","statuses_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/statuses/6aedc2f9859f1b4aab9bb275a16e2187b0afcaa5","head":{"label":"arraysin-bran:add-remove-cart-button-functionality","ref":"add-remove-cart-button-functionality","sha":"6aedc2f9859f1b4aab9bb275a16e2187b0afcaa5","user":{"login":"arraysin-bran","id":57365797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzY1Nzk3","avatar_url":"https://avatars0.githubusercontent.com/u/57365797?v=4","gravatar_id":"","url":"https://api.github.com/users/arraysin-bran","html_url":"https://github.com/arraysin-bran","followers_url":"https://api.github.com/users/arraysin-bran/followers","following_url":"https://api.github.com/users/arraysin-bran/following{/other_user}","gists_url":"https://api.github.com/users/arraysin-bran/gists{/gist_id}","starred_url":"https://api.github.com/users/arraysin-bran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arraysin-bran/subscriptions","organizations_url":"https://api.github.com/users/arraysin-bran/orgs","repos_url":"https://api.github.com/users/arraysin-bran/repos","events_url":"https://api.github.com/users/arraysin-bran/events{/privacy}","received_events_url":"https://api.github.com/users/arraysin-bran/received_events","type":"Organization","site_admin":false},"repo":{"id":219578781,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk1Nzg3ODE=","name":"grace_shopper","full_name":"arraysin-bran/grace_shopper","private":false,"owner":{"login":"arraysin-bran","id":57365797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzY1Nzk3","avatar_url":"https://avatars0.githubusercontent.com/u/57365797?v=4","gravatar_id":"","url":"https://api.github.com/users/arraysin-bran","html_url":"https://github.com/arraysin-bran","followers_url":"https://api.github.com/users/arraysin-bran/followers","following_url":"https://api.github.com/users/arraysin-bran/following{/other_user}","gists_url":"https://api.github.com/users/arraysin-bran/gists{/gist_id}","starred_url":"https://api.github.com/users/arraysin-bran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arraysin-bran/subscriptions","organizations_url":"https://api.github.com/users/arraysin-bran/orgs","repos_url":"https://api.github.com/users/arraysin-bran/repos","events_url":"https://api.github.com/users/arraysin-bran/events{/privacy}","received_events_url":"https://api.github.com/users/arraysin-bran/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arraysin-bran/grace_shopper","description":null,"fork":false,"url":"https://api.github.com/repos/arraysin-bran/grace_shopper","forks_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/forks","keys_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/teams","hooks_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/hooks","issue_events_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues/events{/number}","events_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/events","assignees_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/assignees{/user}","branches_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/branches{/branch}","tags_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/tags","blobs_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/refs{/sha}","trees_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/statuses/{sha}","languages_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/languages","stargazers_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/stargazers","contributors_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/contributors","subscribers_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/subscribers","subscription_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/subscription","commits_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/commits{/sha}","git_commits_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/commits{/sha}","comments_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/comments{/number}","issue_comment_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues/comments{/number}","contents_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/contents/{+path}","compare_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/merges","archive_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/downloads","issues_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues{/number}","pulls_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls{/number}","milestones_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/milestones{/number}","notifications_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/labels{/name}","releases_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/releases{/id}","deployments_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/deployments","created_at":"2019-11-04T19:21:26Z","updated_at":"2019-11-11T15:45:42Z","pushed_at":"2019-11-11T15:45:40Z","git_url":"git://github.com/arraysin-bran/grace_shopper.git","ssh_url":"[email protected]:arraysin-bran/grace_shopper.git","clone_url":"https://github.com/arraysin-bran/grace_shopper.git","svn_url":"https://github.com/arraysin-bran/grace_shopper","homepage":null,"size":2919,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":26,"watchers":1,"default_branch":"master"}},"base":{"label":"arraysin-bran:master","ref":"master","sha":"7adc45dcff19c8b3b66308a9c7b1c4942c3b84c7","user":{"login":"arraysin-bran","id":57365797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzY1Nzk3","avatar_url":"https://avatars0.githubusercontent.com/u/57365797?v=4","gravatar_id":"","url":"https://api.github.com/users/arraysin-bran","html_url":"https://github.com/arraysin-bran","followers_url":"https://api.github.com/users/arraysin-bran/followers","following_url":"https://api.github.com/users/arraysin-bran/following{/other_user}","gists_url":"https://api.github.com/users/arraysin-bran/gists{/gist_id}","starred_url":"https://api.github.com/users/arraysin-bran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arraysin-bran/subscriptions","organizations_url":"https://api.github.com/users/arraysin-bran/orgs","repos_url":"https://api.github.com/users/arraysin-bran/repos","events_url":"https://api.github.com/users/arraysin-bran/events{/privacy}","received_events_url":"https://api.github.com/users/arraysin-bran/received_events","type":"Organization","site_admin":false},"repo":{"id":219578781,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk1Nzg3ODE=","name":"grace_shopper","full_name":"arraysin-bran/grace_shopper","private":false,"owner":{"login":"arraysin-bran","id":57365797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzY1Nzk3","avatar_url":"https://avatars0.githubusercontent.com/u/57365797?v=4","gravatar_id":"","url":"https://api.github.com/users/arraysin-bran","html_url":"https://github.com/arraysin-bran","followers_url":"https://api.github.com/users/arraysin-bran/followers","following_url":"https://api.github.com/users/arraysin-bran/following{/other_user}","gists_url":"https://api.github.com/users/arraysin-bran/gists{/gist_id}","starred_url":"https://api.github.com/users/arraysin-bran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arraysin-bran/subscriptions","organizations_url":"https://api.github.com/users/arraysin-bran/orgs","repos_url":"https://api.github.com/users/arraysin-bran/repos","events_url":"https://api.github.com/users/arraysin-bran/events{/privacy}","received_events_url":"https://api.github.com/users/arraysin-bran/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arraysin-bran/grace_shopper","description":null,"fork":false,"url":"https://api.github.com/repos/arraysin-bran/grace_shopper","forks_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/forks","keys_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/teams","hooks_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/hooks","issue_events_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues/events{/number}","events_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/events","assignees_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/assignees{/user}","branches_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/branches{/branch}","tags_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/tags","blobs_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/refs{/sha}","trees_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/statuses/{sha}","languages_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/languages","stargazers_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/stargazers","contributors_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/contributors","subscribers_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/subscribers","subscription_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/subscription","commits_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/commits{/sha}","git_commits_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/git/commits{/sha}","comments_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/comments{/number}","issue_comment_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues/comments{/number}","contents_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/contents/{+path}","compare_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/merges","archive_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/downloads","issues_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues{/number}","pulls_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls{/number}","milestones_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/milestones{/number}","notifications_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/labels{/name}","releases_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/releases{/id}","deployments_url":"https://api.github.com/repos/arraysin-bran/grace_shopper/deployments","created_at":"2019-11-04T19:21:26Z","updated_at":"2019-11-11T15:45:42Z","pushed_at":"2019-11-11T15:45:40Z","git_url":"git://github.com/arraysin-bran/grace_shopper.git","ssh_url":"[email protected]:arraysin-bran/grace_shopper.git","clone_url":"https://github.com/arraysin-bran/grace_shopper.git","svn_url":"https://github.com/arraysin-bran/grace_shopper","homepage":null,"size":2919,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":26,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/52"},"html":{"href":"https://github.com/arraysin-bran/grace_shopper/pull/52"},"issue":{"href":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues/52"},"comments":{"href":"https://api.github.com/repos/arraysin-bran/grace_shopper/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arraysin-bran/grace_shopper/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/arraysin-bran/grace_shopper/statuses/6aedc2f9859f1b4aab9bb275a16e2187b0afcaa5"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 219578781,
"name": "arraysin-bran/grace_shopper",
"url": "https://api.github.com/repos/arraysin-bran/grace_shopper"
}
|
{
"id": 4549677,
"login": "mwalsh01",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4549677?",
"url": "https://api.github.com/users/mwalsh01"
}
|
{
"id": 57365797,
"login": "arraysin-bran",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/57365797?",
"url": "https://api.github.com/orgs/arraysin-bran"
}
| 2019-11-11T15:58:20 |
10834928454
|
{"actor":{"display_login":"mwalsh01"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/comments/352391852","pull_request_review_id":324982921,"id":352391852,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjM5MTg1Mg==","diff_hunk":"@@ -4,15 +4,26 @@\n import pandas as pd\n import numpy as np\n import tensorflow as tf\n-from CheXpertDataset import ChexpertDataset, UZerosTransform, UOnesTransform, ReplaceNaNTransform, GreyScale_to_RGB\n+from CheXpertDataset import ChexpertDataset, \\\n+ UZerosTransform, UOnesTransform, ReplaceNaNTransform\n+from ImageTransforms import PILToNumpy, FixRatioResize, EqualizeHistogram, Gray2RGB, GaussianBlur\n from torchvision import transforms\n from torch.utils.data import Subset, DataLoader\n \n image_preprocessing = transforms.Compose([\n- # GreyScale_to_RGB(),\n- transforms.Resize((600, 600)),\n+ PILToNumpy(),\n+ EqualizeHistogram(),\n+ Gray2RGB(),\n+ FixRatioResize(512, 128),","path":"Code/training_common_utils.py","position":17,"original_position":17,"commit_id":"0ad22078f6f1852a6226feedd9a03a81176c811d","original_commit_id":"0ad22078f6f1852a6226feedd9a03a81176c811d","user":{"login":"josh-bernstein618","id":57636678,"node_id":"MDQ6VXNlcjU3NjM2Njc4","avatar_url":"https://avatars1.githubusercontent.com/u/57636678?v=4","gravatar_id":"","url":"https://api.github.com/users/josh-bernstein618","html_url":"https://github.com/josh-bernstein618","followers_url":"https://api.github.com/users/josh-bernstein618/followers","following_url":"https://api.github.com/users/josh-bernstein618/following{/other_user}","gists_url":"https://api.github.com/users/josh-bernstein618/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-bernstein618/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-bernstein618/subscriptions","organizations_url":"https://api.github.com/users/josh-bernstein618/orgs","repos_url":"https://api.github.com/users/josh-bernstein618/repos","events_url":"https://api.github.com/users/josh-bernstein618/events{/privacy}","received_events_url":"https://api.github.com/users/josh-bernstein618/received_events","type":"User","site_admin":false},"body":"This line 61\r\nhttps://github.com/ml2-final-project/Final-Project-Group8/pull/9/files#diff-37dd26a9587a0207f2418ef8c4462628R61\r\n\r\nAlso, I was concerned that this only takes one arg (aside from self)\r\nhttps://github.com/ml2-final-project/Final-Project-Group8/pull/9/files#diff-37dd26a9587a0207f2418ef8c4462628R45","created_at":"2019-12-02T01:29:41Z","updated_at":"2019-12-02T01:29:41Z","html_url":"https://github.com/ml2-final-project/Final-Project-Group8/pull/9#discussion_r352391852","pull_request_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/comments/352391852"},"html":{"href":"https://github.com/ml2-final-project/Final-Project-Group8/pull/9#discussion_r352391852"},"pull_request":{"href":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/9"}},"in_reply_to_id":352385205},"pull_request":{"url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/9","id":347383971,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MzgzOTcx","html_url":"https://github.com/ml2-final-project/Final-Project-Group8/pull/9","diff_url":"https://github.com/ml2-final-project/Final-Project-Group8/pull/9.diff","patch_url":"https://github.com/ml2-final-project/Final-Project-Group8/pull/9.patch","issue_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/issues/9","number":9,"state":"open","locked":false,"title":"modified image preprocessing based on Chexpert Competition winner","user":{"login":"zbuckley","id":608096,"node_id":"MDQ6VXNlcjYwODA5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/608096?v=4","gravatar_id":"","url":"https://api.github.com/users/zbuckley","html_url":"https://github.com/zbuckley","followers_url":"https://api.github.com/users/zbuckley/followers","following_url":"https://api.github.com/users/zbuckley/following{/other_user}","gists_url":"https://api.github.com/users/zbuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/zbuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbuckley/subscriptions","organizations_url":"https://api.github.com/users/zbuckley/orgs","repos_url":"https://api.github.com/users/zbuckley/repos","events_url":"https://api.github.com/users/zbuckley/events{/privacy}","received_events_url":"https://api.github.com/users/zbuckley/received_events","type":"User","site_admin":false},"body":"Chexpert Competition winner code: https://github.com/jfhealthcare/Chexpert\r\n\r\nThey had a mechanism for reducing the images, while maintaining the aspect ratios which I really liked. Also Using Histogram balancing, GaussianBlur, and RandomAffine(at least for the training set). \r\nAlso changed our normalization and std error values to match. ","created_at":"2019-12-01T23:24:20Z","updated_at":"2019-12-02T01:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c8a5d302a3b154a5af4c1fc4d1d62b4f23c52ee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kshitijbhat330","id":42442346,"node_id":"MDQ6VXNlcjQyNDQyMzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/42442346?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitijbhat330","html_url":"https://github.com/kshitijbhat330","followers_url":"https://api.github.com/users/kshitijbhat330/followers","following_url":"https://api.github.com/users/kshitijbhat330/following{/other_user}","gists_url":"https://api.github.com/users/kshitijbhat330/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitijbhat330/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitijbhat330/subscriptions","organizations_url":"https://api.github.com/users/kshitijbhat330/orgs","repos_url":"https://api.github.com/users/kshitijbhat330/repos","events_url":"https://api.github.com/users/kshitijbhat330/events{/privacy}","received_events_url":"https://api.github.com/users/kshitijbhat330/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/issues/9/comments","statuses_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/statuses/0ad22078f6f1852a6226feedd9a03a81176c811d","head":{"label":"zbuckley:ztb_updates","ref":"ztb_updates","sha":"0ad22078f6f1852a6226feedd9a03a81176c811d","user":{"login":"zbuckley","id":608096,"node_id":"MDQ6VXNlcjYwODA5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/608096?v=4","gravatar_id":"","url":"https://api.github.com/users/zbuckley","html_url":"https://github.com/zbuckley","followers_url":"https://api.github.com/users/zbuckley/followers","following_url":"https://api.github.com/users/zbuckley/following{/other_user}","gists_url":"https://api.github.com/users/zbuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/zbuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbuckley/subscriptions","organizations_url":"https://api.github.com/users/zbuckley/orgs","repos_url":"https://api.github.com/users/zbuckley/repos","events_url":"https://api.github.com/users/zbuckley/events{/privacy}","received_events_url":"https://api.github.com/users/zbuckley/received_events","type":"User","site_admin":false},"repo":{"id":224525083,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ1MjUwODM=","name":"Final-Project-Group8","full_name":"zbuckley/Final-Project-Group8","private":false,"owner":{"login":"zbuckley","id":608096,"node_id":"MDQ6VXNlcjYwODA5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/608096?v=4","gravatar_id":"","url":"https://api.github.com/users/zbuckley","html_url":"https://github.com/zbuckley","followers_url":"https://api.github.com/users/zbuckley/followers","following_url":"https://api.github.com/users/zbuckley/following{/other_user}","gists_url":"https://api.github.com/users/zbuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/zbuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbuckley/subscriptions","organizations_url":"https://api.github.com/users/zbuckley/orgs","repos_url":"https://api.github.com/users/zbuckley/repos","events_url":"https://api.github.com/users/zbuckley/events{/privacy}","received_events_url":"https://api.github.com/users/zbuckley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zbuckley/Final-Project-Group8","description":"Group 8 Final Project, for Group 8. Fall 2019","fork":true,"url":"https://api.github.com/repos/zbuckley/Final-Project-Group8","forks_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/forks","keys_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/teams","hooks_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/hooks","issue_events_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/issues/events{/number}","events_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/events","assignees_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/assignees{/user}","branches_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/branches{/branch}","tags_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/tags","blobs_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/git/refs{/sha}","trees_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/statuses/{sha}","languages_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/languages","stargazers_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/stargazers","contributors_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/contributors","subscribers_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/subscribers","subscription_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/subscription","commits_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/commits{/sha}","git_commits_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/git/commits{/sha}","comments_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/comments{/number}","issue_comment_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/issues/comments{/number}","contents_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/contents/{+path}","compare_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/merges","archive_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/downloads","issues_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/issues{/number}","pulls_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/pulls{/number}","milestones_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/milestones{/number}","notifications_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/labels{/name}","releases_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/releases{/id}","deployments_url":"https://api.github.com/repos/zbuckley/Final-Project-Group8/deployments","created_at":"2019-11-27T22:08:42Z","updated_at":"2019-11-27T22:08:43Z","pushed_at":"2019-12-01T23:29:29Z","git_url":"git://github.com/zbuckley/Final-Project-Group8.git","ssh_url":"[email protected]:zbuckley/Final-Project-Group8.git","clone_url":"https://github.com/zbuckley/Final-Project-Group8.git","svn_url":"https://github.com/zbuckley/Final-Project-Group8","homepage":null,"size":301,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ml2-final-project:master","ref":"master","sha":"ca8a017296bec39deb3ba1e857af81d7d67e6a91","user":{"login":"ml2-final-project","id":57636556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjM2NTU2","avatar_url":"https://avatars2.githubusercontent.com/u/57636556?v=4","gravatar_id":"","url":"https://api.github.com/users/ml2-final-project","html_url":"https://github.com/ml2-final-project","followers_url":"https://api.github.com/users/ml2-final-project/followers","following_url":"https://api.github.com/users/ml2-final-project/following{/other_user}","gists_url":"https://api.github.com/users/ml2-final-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ml2-final-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ml2-final-project/subscriptions","organizations_url":"https://api.github.com/users/ml2-final-project/orgs","repos_url":"https://api.github.com/users/ml2-final-project/repos","events_url":"https://api.github.com/users/ml2-final-project/events{/privacy}","received_events_url":"https://api.github.com/users/ml2-final-project/received_events","type":"Organization","site_admin":false},"repo":{"id":221036090,"node_id":"MDEwOlJlcG9zaXRvcnkyMjEwMzYwOTA=","name":"Final-Project-Group8","full_name":"ml2-final-project/Final-Project-Group8","private":false,"owner":{"login":"ml2-final-project","id":57636556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjM2NTU2","avatar_url":"https://avatars2.githubusercontent.com/u/57636556?v=4","gravatar_id":"","url":"https://api.github.com/users/ml2-final-project","html_url":"https://github.com/ml2-final-project","followers_url":"https://api.github.com/users/ml2-final-project/followers","following_url":"https://api.github.com/users/ml2-final-project/following{/other_user}","gists_url":"https://api.github.com/users/ml2-final-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ml2-final-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ml2-final-project/subscriptions","organizations_url":"https://api.github.com/users/ml2-final-project/orgs","repos_url":"https://api.github.com/users/ml2-final-project/repos","events_url":"https://api.github.com/users/ml2-final-project/events{/privacy}","received_events_url":"https://api.github.com/users/ml2-final-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ml2-final-project/Final-Project-Group8","description":"Group 8 Final Project, for Group 8. Fall 2019","fork":false,"url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8","forks_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/forks","keys_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/teams","hooks_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/hooks","issue_events_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/issues/events{/number}","events_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/events","assignees_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/assignees{/user}","branches_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/branches{/branch}","tags_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/tags","blobs_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/git/refs{/sha}","trees_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/statuses/{sha}","languages_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/languages","stargazers_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/stargazers","contributors_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/contributors","subscribers_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/subscribers","subscription_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/subscription","commits_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/commits{/sha}","git_commits_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/git/commits{/sha}","comments_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/comments{/number}","issue_comment_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/issues/comments{/number}","contents_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/contents/{+path}","compare_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/merges","archive_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/downloads","issues_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/issues{/number}","pulls_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls{/number}","milestones_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/milestones{/number}","notifications_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/labels{/name}","releases_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/releases{/id}","deployments_url":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/deployments","created_at":"2019-11-11T17:39:45Z","updated_at":"2019-12-01T21:58:44Z","pushed_at":"2019-12-01T23:29:30Z","git_url":"git://github.com/ml2-final-project/Final-Project-Group8.git","ssh_url":"[email protected]:ml2-final-project/Final-Project-Group8.git","clone_url":"https://github.com/ml2-final-project/Final-Project-Group8.git","svn_url":"https://github.com/ml2-final-project/Final-Project-Group8","homepage":null,"size":295,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/9"},"html":{"href":"https://github.com/ml2-final-project/Final-Project-Group8/pull/9"},"issue":{"href":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/issues/9"},"comments":{"href":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ml2-final-project/Final-Project-Group8/statuses/0ad22078f6f1852a6226feedd9a03a81176c811d"}},"author_association":"MEMBER"}}
|
{
"id": 221036090,
"name": "ml2-final-project/Final-Project-Group8",
"url": "https://api.github.com/repos/ml2-final-project/Final-Project-Group8"
}
|
{
"id": 57636678,
"login": "josh-bernstein618",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/57636678?",
"url": "https://api.github.com/users/josh-bernstein618"
}
|
{
"id": 57636556,
"login": "ml2-final-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/57636556?",
"url": "https://api.github.com/orgs/ml2-final-project"
}
| 2019-12-02T01:29:41 |
10985181364
|
{"actor":{"display_login":"josh-bernstein618"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/codewear-study/react-calculator/pulls/comments/361560521","pull_request_review_id":336645290,"id":361560521,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTU2MDUyMQ==","diff_hunk":"@@ -0,0 +1,45 @@\n+let Calculator = {","path":"src/CalculatorModel.js","position":null,"original_position":1,"commit_id":"e7992534f56de2d3ed310755c5866c562b548806","original_commit_id":"ebd9511b0d9e1efde3ad2ca0e147ab424e869014","user":{"login":"Parkhyunseo","id":20010358,"node_id":"MDQ6VXNlcjIwMDEwMzU4","avatar_url":"https://avatars3.githubusercontent.com/u/20010358?v=4","gravatar_id":"","url":"https://api.github.com/users/Parkhyunseo","html_url":"https://github.com/Parkhyunseo","followers_url":"https://api.github.com/users/Parkhyunseo/followers","following_url":"https://api.github.com/users/Parkhyunseo/following{/other_user}","gists_url":"https://api.github.com/users/Parkhyunseo/gists{/gist_id}","starred_url":"https://api.github.com/users/Parkhyunseo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parkhyunseo/subscriptions","organizations_url":"https://api.github.com/users/Parkhyunseo/orgs","repos_url":"https://api.github.com/users/Parkhyunseo/repos","events_url":"https://api.github.com/users/Parkhyunseo/events{/privacy}","received_events_url":"https://api.github.com/users/Parkhyunseo/received_events","type":"User","site_admin":false},"body":"const๋ ๋ด๋ถ ๋ณ์์ ๊ฐ์ด ๋ฐ๋์ง ์์ ๋ ์ฌ์ฉํ๋๊ฒ ์๋๋ผ const๋ฅผ ์ฌ์ฉํ๋ ๊ฐ์ฒด, ํจ์, ๋ณ์์ ๊ฐ์ด ๋ณ๊ฒฝ๋์ง ์๋๊ฒ๋๋ค. ์ ํํ ๋ค์ ํ ๋ฒ ์ ๋ฆฌํ๋๊ฒ ์ข๊ฒ ์ด์.","created_at":"2019-12-27T01:36:48Z","updated_at":"2019-12-27T01:36:48Z","html_url":"https://github.com/codewear-study/react-calculator/pull/1#discussion_r361560521","pull_request_url":"https://api.github.com/repos/codewear-study/react-calculator/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codewear-study/react-calculator/pulls/comments/361560521"},"html":{"href":"https://github.com/codewear-study/react-calculator/pull/1#discussion_r361560521"},"pull_request":{"href":"https://api.github.com/repos/codewear-study/react-calculator/pulls/1"}},"in_reply_to_id":361307305},"pull_request":{"url":"https://api.github.com/repos/codewear-study/react-calculator/pulls/1","id":356215193,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2MjE1MTkz","html_url":"https://github.com/codewear-study/react-calculator/pull/1","diff_url":"https://github.com/codewear-study/react-calculator/pull/1.diff","patch_url":"https://github.com/codewear-study/react-calculator/pull/1.patch","issue_url":"https://api.github.com/repos/codewear-study/react-calculator/issues/1","number":1,"state":"open","locked":false,"title":"[David] react-calculator ๊ตฌํ ์๋ฃ์
๋๋ค","user":{"login":"SangYeoop","id":55068107,"node_id":"MDQ6VXNlcjU1MDY4MTA3","avatar_url":"https://avatars1.githubusercontent.com/u/55068107?v=4","gravatar_id":"","url":"https://api.github.com/users/SangYeoop","html_url":"https://github.com/SangYeoop","followers_url":"https://api.github.com/users/SangYeoop/followers","following_url":"https://api.github.com/users/SangYeoop/following{/other_user}","gists_url":"https://api.github.com/users/SangYeoop/gists{/gist_id}","starred_url":"https://api.github.com/users/SangYeoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SangYeoop/subscriptions","organizations_url":"https://api.github.com/users/SangYeoop/orgs","repos_url":"https://api.github.com/users/SangYeoop/repos","events_url":"https://api.github.com/users/SangYeoop/events{/privacy}","received_events_url":"https://api.github.com/users/SangYeoop/received_events","type":"User","site_admin":false},"body":"๊ณ์ฐ๊ธฐ ์ผ๋จ ๋ง๋ค๊ธดํ๋๋ฐ ใ
ใ
ใ
ใ
React์ ๋ฐฉ์์ ์กฐ๊ธ์๋๊ฑฐ๊ฐ์์.. \r\n๊ทธ๋๋ ๋๋๋ก ReactComponent๋ props์จ๋ณผ๋ ค๊ณ ๋
ธ๋ ฅ์ํ์ต๋๋ค.... ","created_at":"2019-12-23T07:28:44Z","updated_at":"2019-12-27T01:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e341322b49aeb5f66d3ca0a24115ced834015f1b","assignee":{"login":"SangYeoop","id":55068107,"node_id":"MDQ6VXNlcjU1MDY4MTA3","avatar_url":"https://avatars1.githubusercontent.com/u/55068107?v=4","gravatar_id":"","url":"https://api.github.com/users/SangYeoop","html_url":"https://github.com/SangYeoop","followers_url":"https://api.github.com/users/SangYeoop/followers","following_url":"https://api.github.com/users/SangYeoop/following{/other_user}","gists_url":"https://api.github.com/users/SangYeoop/gists{/gist_id}","starred_url":"https://api.github.com/users/SangYeoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SangYeoop/subscriptions","organizations_url":"https://api.github.com/users/SangYeoop/orgs","repos_url":"https://api.github.com/users/SangYeoop/repos","events_url":"https://api.github.com/users/SangYeoop/events{/privacy}","received_events_url":"https://api.github.com/users/SangYeoop/received_events","type":"User","site_admin":false},"assignees":[{"login":"SangYeoop","id":55068107,"node_id":"MDQ6VXNlcjU1MDY4MTA3","avatar_url":"https://avatars1.githubusercontent.com/u/55068107?v=4","gravatar_id":"","url":"https://api.github.com/users/SangYeoop","html_url":"https://github.com/SangYeoop","followers_url":"https://api.github.com/users/SangYeoop/followers","following_url":"https://api.github.com/users/SangYeoop/following{/other_user}","gists_url":"https://api.github.com/users/SangYeoop/gists{/gist_id}","starred_url":"https://api.github.com/users/SangYeoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SangYeoop/subscriptions","organizations_url":"https://api.github.com/users/SangYeoop/orgs","repos_url":"https://api.github.com/users/SangYeoop/repos","events_url":"https://api.github.com/users/SangYeoop/events{/privacy}","received_events_url":"https://api.github.com/users/SangYeoop/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Parkhyunseo","id":20010358,"node_id":"MDQ6VXNlcjIwMDEwMzU4","avatar_url":"https://avatars3.githubusercontent.com/u/20010358?v=4","gravatar_id":"","url":"https://api.github.com/users/Parkhyunseo","html_url":"https://github.com/Parkhyunseo","followers_url":"https://api.github.com/users/Parkhyunseo/followers","following_url":"https://api.github.com/users/Parkhyunseo/following{/other_user}","gists_url":"https://api.github.com/users/Parkhyunseo/gists{/gist_id}","starred_url":"https://api.github.com/users/Parkhyunseo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parkhyunseo/subscriptions","organizations_url":"https://api.github.com/users/Parkhyunseo/orgs","repos_url":"https://api.github.com/users/Parkhyunseo/repos","events_url":"https://api.github.com/users/Parkhyunseo/events{/privacy}","received_events_url":"https://api.github.com/users/Parkhyunseo/received_events","type":"User","site_admin":false},{"login":"HodaeSsi","id":30151603,"node_id":"MDQ6VXNlcjMwMTUxNjAz","avatar_url":"https://avatars1.githubusercontent.com/u/30151603?v=4","gravatar_id":"","url":"https://api.github.com/users/HodaeSsi","html_url":"https://github.com/HodaeSsi","followers_url":"https://api.github.com/users/HodaeSsi/followers","following_url":"https://api.github.com/users/HodaeSsi/following{/other_user}","gists_url":"https://api.github.com/users/HodaeSsi/gists{/gist_id}","starred_url":"https://api.github.com/users/HodaeSsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HodaeSsi/subscriptions","organizations_url":"https://api.github.com/users/HodaeSsi/orgs","repos_url":"https://api.github.com/users/HodaeSsi/repos","events_url":"https://api.github.com/users/HodaeSsi/events{/privacy}","received_events_url":"https://api.github.com/users/HodaeSsi/received_events","type":"User","site_admin":false},{"login":"Tetramad","id":42208131,"node_id":"MDQ6VXNlcjQyMjA4MTMx","avatar_url":"https://avatars0.githubusercontent.com/u/42208131?v=4","gravatar_id":"","url":"https://api.github.com/users/Tetramad","html_url":"https://github.com/Tetramad","followers_url":"https://api.github.com/users/Tetramad/followers","following_url":"https://api.github.com/users/Tetramad/following{/other_user}","gists_url":"https://api.github.com/users/Tetramad/gists{/gist_id}","starred_url":"https://api.github.com/users/Tetramad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tetramad/subscriptions","organizations_url":"https://api.github.com/users/Tetramad/orgs","repos_url":"https://api.github.com/users/Tetramad/repos","events_url":"https://api.github.com/users/Tetramad/events{/privacy}","received_events_url":"https://api.github.com/users/Tetramad/received_events","type":"User","site_admin":false},{"login":"PParkJy","id":46422952,"node_id":"MDQ6VXNlcjQ2NDIyOTUy","avatar_url":"https://avatars1.githubusercontent.com/u/46422952?v=4","gravatar_id":"","url":"https://api.github.com/users/PParkJy","html_url":"https://github.com/PParkJy","followers_url":"https://api.github.com/users/PParkJy/followers","following_url":"https://api.github.com/users/PParkJy/following{/other_user}","gists_url":"https://api.github.com/users/PParkJy/gists{/gist_id}","starred_url":"https://api.github.com/users/PParkJy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PParkJy/subscriptions","organizations_url":"https://api.github.com/users/PParkJy/orgs","repos_url":"https://api.github.com/users/PParkJy/repos","events_url":"https://api.github.com/users/PParkJy/events{/privacy}","received_events_url":"https://api.github.com/users/PParkJy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1721330347,"node_id":"MDU6TGFiZWwxNzIxMzMwMzQ3","url":"https://api.github.com/repos/codewear-study/react-calculator/labels/enhancement","name":"enhancement","color":"a2eeef","default":true,"description":"New feature or request"}],"milestone":null,"commits_url":"https://api.github.com/repos/codewear-study/react-calculator/pulls/1/commits","review_comments_url":"https://api.github.com/repos/codewear-study/react-calculator/pulls/1/comments","review_comment_url":"https://api.github.com/repos/codewear-study/react-calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codewear-study/react-calculator/issues/1/comments","statuses_url":"https://api.github.com/repos/codewear-study/react-calculator/statuses/e7992534f56de2d3ed310755c5866c562b548806","head":{"label":"SangYeoop:david","ref":"david","sha":"e7992534f56de2d3ed310755c5866c562b548806","user":{"login":"SangYeoop","id":55068107,"node_id":"MDQ6VXNlcjU1MDY4MTA3","avatar_url":"https://avatars1.githubusercontent.com/u/55068107?v=4","gravatar_id":"","url":"https://api.github.com/users/SangYeoop","html_url":"https://github.com/SangYeoop","followers_url":"https://api.github.com/users/SangYeoop/followers","following_url":"https://api.github.com/users/SangYeoop/following{/other_user}","gists_url":"https://api.github.com/users/SangYeoop/gists{/gist_id}","starred_url":"https://api.github.com/users/SangYeoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SangYeoop/subscriptions","organizations_url":"https://api.github.com/users/SangYeoop/orgs","repos_url":"https://api.github.com/users/SangYeoop/repos","events_url":"https://api.github.com/users/SangYeoop/events{/privacy}","received_events_url":"https://api.github.com/users/SangYeoop/received_events","type":"User","site_admin":false},"repo":{"id":229694041,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk2OTQwNDE=","name":"react-calculator","full_name":"SangYeoop/react-calculator","private":false,"owner":{"login":"SangYeoop","id":55068107,"node_id":"MDQ6VXNlcjU1MDY4MTA3","avatar_url":"https://avatars1.githubusercontent.com/u/55068107?v=4","gravatar_id":"","url":"https://api.github.com/users/SangYeoop","html_url":"https://github.com/SangYeoop","followers_url":"https://api.github.com/users/SangYeoop/followers","following_url":"https://api.github.com/users/SangYeoop/following{/other_user}","gists_url":"https://api.github.com/users/SangYeoop/gists{/gist_id}","starred_url":"https://api.github.com/users/SangYeoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SangYeoop/subscriptions","organizations_url":"https://api.github.com/users/SangYeoop/orgs","repos_url":"https://api.github.com/users/SangYeoop/repos","events_url":"https://api.github.com/users/SangYeoop/events{/privacy}","received_events_url":"https://api.github.com/users/SangYeoop/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SangYeoop/react-calculator","description":"๋ ๋ฒ์งธ ์ฃผ์ : react๋ฅผ ์ฌ์ฉํด์ ๊ณ์ฐ๊ธฐ ๋ง๋ค๊ธฐ","fork":true,"url":"https://api.github.com/repos/SangYeoop/react-calculator","forks_url":"https://api.github.com/repos/SangYeoop/react-calculator/forks","keys_url":"https://api.github.com/repos/SangYeoop/react-calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SangYeoop/react-calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SangYeoop/react-calculator/teams","hooks_url":"https://api.github.com/repos/SangYeoop/react-calculator/hooks","issue_events_url":"https://api.github.com/repos/SangYeoop/react-calculator/issues/events{/number}","events_url":"https://api.github.com/repos/SangYeoop/react-calculator/events","assignees_url":"https://api.github.com/repos/SangYeoop/react-calculator/assignees{/user}","branches_url":"https://api.github.com/repos/SangYeoop/react-calculator/branches{/branch}","tags_url":"https://api.github.com/repos/SangYeoop/react-calculator/tags","blobs_url":"https://api.github.com/repos/SangYeoop/react-calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SangYeoop/react-calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SangYeoop/react-calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/SangYeoop/react-calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SangYeoop/react-calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/SangYeoop/react-calculator/languages","stargazers_url":"https://api.github.com/repos/SangYeoop/react-calculator/stargazers","contributors_url":"https://api.github.com/repos/SangYeoop/react-calculator/contributors","subscribers_url":"https://api.github.com/repos/SangYeoop/react-calculator/subscribers","subscription_url":"https://api.github.com/repos/SangYeoop/react-calculator/subscription","commits_url":"https://api.github.com/repos/SangYeoop/react-calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/SangYeoop/react-calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/SangYeoop/react-calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/SangYeoop/react-calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/SangYeoop/react-calculator/contents/{+path}","compare_url":"https://api.github.com/repos/SangYeoop/react-calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SangYeoop/react-calculator/merges","archive_url":"https://api.github.com/repos/SangYeoop/react-calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SangYeoop/react-calculator/downloads","issues_url":"https://api.github.com/repos/SangYeoop/react-calculator/issues{/number}","pulls_url":"https://api.github.com/repos/SangYeoop/react-calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/SangYeoop/react-calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/SangYeoop/react-calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SangYeoop/react-calculator/labels{/name}","releases_url":"https://api.github.com/repos/SangYeoop/react-calculator/releases{/id}","deployments_url":"https://api.github.com/repos/SangYeoop/react-calculator/deployments","created_at":"2019-12-23T06:50:28Z","updated_at":"2019-12-23T06:50:30Z","pushed_at":"2019-12-26T06:05:43Z","git_url":"git://github.com/SangYeoop/react-calculator.git","ssh_url":"[email protected]:SangYeoop/react-calculator.git","clone_url":"https://github.com/SangYeoop/react-calculator.git","svn_url":"https://github.com/SangYeoop/react-calculator","homepage":null,"size":169,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codewear-study:david","ref":"david","sha":"6cbd8904f89a97ac9c1a02e6ea4e85330566e700","user":{"login":"codewear-study","id":57822865,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3ODIyODY1","avatar_url":"https://avatars2.githubusercontent.com/u/57822865?v=4","gravatar_id":"","url":"https://api.github.com/users/codewear-study","html_url":"https://github.com/codewear-study","followers_url":"https://api.github.com/users/codewear-study/followers","following_url":"https://api.github.com/users/codewear-study/following{/other_user}","gists_url":"https://api.github.com/users/codewear-study/gists{/gist_id}","starred_url":"https://api.github.com/users/codewear-study/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codewear-study/subscriptions","organizations_url":"https://api.github.com/users/codewear-study/orgs","repos_url":"https://api.github.com/users/codewear-study/repos","events_url":"https://api.github.com/users/codewear-study/events{/privacy}","received_events_url":"https://api.github.com/users/codewear-study/received_events","type":"Organization","site_admin":false},"repo":{"id":226623669,"node_id":"MDEwOlJlcG9zaXRvcnkyMjY2MjM2Njk=","name":"react-calculator","full_name":"codewear-study/react-calculator","private":false,"owner":{"login":"codewear-study","id":57822865,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3ODIyODY1","avatar_url":"https://avatars2.githubusercontent.com/u/57822865?v=4","gravatar_id":"","url":"https://api.github.com/users/codewear-study","html_url":"https://github.com/codewear-study","followers_url":"https://api.github.com/users/codewear-study/followers","following_url":"https://api.github.com/users/codewear-study/following{/other_user}","gists_url":"https://api.github.com/users/codewear-study/gists{/gist_id}","starred_url":"https://api.github.com/users/codewear-study/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codewear-study/subscriptions","organizations_url":"https://api.github.com/users/codewear-study/orgs","repos_url":"https://api.github.com/users/codewear-study/repos","events_url":"https://api.github.com/users/codewear-study/events{/privacy}","received_events_url":"https://api.github.com/users/codewear-study/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codewear-study/react-calculator","description":"๋ ๋ฒ์งธ ์ฃผ์ : react๋ฅผ ์ฌ์ฉํด์ ๊ณ์ฐ๊ธฐ ๋ง๋ค๊ธฐ","fork":false,"url":"https://api.github.com/repos/codewear-study/react-calculator","forks_url":"https://api.github.com/repos/codewear-study/react-calculator/forks","keys_url":"https://api.github.com/repos/codewear-study/react-calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codewear-study/react-calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codewear-study/react-calculator/teams","hooks_url":"https://api.github.com/repos/codewear-study/react-calculator/hooks","issue_events_url":"https://api.github.com/repos/codewear-study/react-calculator/issues/events{/number}","events_url":"https://api.github.com/repos/codewear-study/react-calculator/events","assignees_url":"https://api.github.com/repos/codewear-study/react-calculator/assignees{/user}","branches_url":"https://api.github.com/repos/codewear-study/react-calculator/branches{/branch}","tags_url":"https://api.github.com/repos/codewear-study/react-calculator/tags","blobs_url":"https://api.github.com/repos/codewear-study/react-calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codewear-study/react-calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codewear-study/react-calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/codewear-study/react-calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codewear-study/react-calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/codewear-study/react-calculator/languages","stargazers_url":"https://api.github.com/repos/codewear-study/react-calculator/stargazers","contributors_url":"https://api.github.com/repos/codewear-study/react-calculator/contributors","subscribers_url":"https://api.github.com/repos/codewear-study/react-calculator/subscribers","subscription_url":"https://api.github.com/repos/codewear-study/react-calculator/subscription","commits_url":"https://api.github.com/repos/codewear-study/react-calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/codewear-study/react-calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/codewear-study/react-calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/codewear-study/react-calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/codewear-study/react-calculator/contents/{+path}","compare_url":"https://api.github.com/repos/codewear-study/react-calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codewear-study/react-calculator/merges","archive_url":"https://api.github.com/repos/codewear-study/react-calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codewear-study/react-calculator/downloads","issues_url":"https://api.github.com/repos/codewear-study/react-calculator/issues{/number}","pulls_url":"https://api.github.com/repos/codewear-study/react-calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/codewear-study/react-calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/codewear-study/react-calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codewear-study/react-calculator/labels{/name}","releases_url":"https://api.github.com/repos/codewear-study/react-calculator/releases{/id}","deployments_url":"https://api.github.com/repos/codewear-study/react-calculator/deployments","created_at":"2019-12-08T06:14:58Z","updated_at":"2019-12-08T06:15:02Z","pushed_at":"2019-12-26T06:05:44Z","git_url":"git://github.com/codewear-study/react-calculator.git","ssh_url":"[email protected]:codewear-study/react-calculator.git","clone_url":"https://github.com/codewear-study/react-calculator.git","svn_url":"https://github.com/codewear-study/react-calculator","homepage":null,"size":1,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codewear-study/react-calculator/pulls/1"},"html":{"href":"https://github.com/codewear-study/react-calculator/pull/1"},"issue":{"href":"https://api.github.com/repos/codewear-study/react-calculator/issues/1"},"comments":{"href":"https://api.github.com/repos/codewear-study/react-calculator/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/codewear-study/react-calculator/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/codewear-study/react-calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codewear-study/react-calculator/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/codewear-study/react-calculator/statuses/e7992534f56de2d3ed310755c5866c562b548806"}},"author_association":"NONE"}}
|
{
"id": 226623669,
"name": "codewear-study/react-calculator",
"url": "https://api.github.com/repos/codewear-study/react-calculator"
}
|
{
"id": 20010358,
"login": "Parkhyunseo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20010358?",
"url": "https://api.github.com/users/Parkhyunseo"
}
|
{
"id": 57822865,
"login": "codewear-study",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/57822865?",
"url": "https://api.github.com/orgs/codewear-study"
}
| 2019-12-27T01:36:48 |
11163869302
|
{"actor":{"display_login":"Parkhyunseo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/scrumcube/pj-movie/pulls/comments/362752523","pull_request_review_id":338003244,"id":362752523,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2Mjc1MjUyMw==","diff_hunk":"@@ -0,0 +1,123 @@\n+require \"rails_helper\"\n+\n+RSpec.describe \"MoviesController\", type: :request do\n+\n+ describe \"GET /admin/sign_in\" do\n+ let(:admin) { build(:admin) }\n+\n+ context 'admin page' do\n+ it \"before login\" do\n+ get admin_path\n+ expect(response).to have_http_status(302)\n+ expect(response).to redirect_to(new_admin_session_path)\n+ end\n+ end\n+ context 'admin login' do\n+ before { sign_in admin }\n+ it \"success request\" do\n+ get admin_path\n+ expect(response).to have_http_status(200)\n+ expect(response.body).to include(admin.username)\n+ end\n+ end\n+ context 'admin logout' do\n+ it \"success request\" do\n+ get admin_path\n+ sign_out admin\n+ expect(response).to have_http_status(302)\n+ expect(response.body).not_to include(admin.username)\n+ expect(response).to redirect_to(new_admin_session_path)\n+ end\n+ end\n+ end\n+\n+ describe \"GET #index\" do\n+ let(:admin) { build(:admin) }\n+ before { sign_in admin }\n+ context 'Check_if_movie_exist' do\n+ let!(:movie) { create(:movie) }\n+\n+ it \"Check_movies_http_status\" do\n+ get admin_movies_path, params: { page: 1 }\n+ expect(response).to have_http_status(200)\n+ end\n+ it \"Check_movie_title\" do\n+ get admin_movies_path, params: { page: 1 }\n+ expect(response.body).to include(movie.title)\n+ end\n+ it \"Check_movie_created_at\" do\n+ get admin_movies_path, params: { page: 1 }\n+ expect(response.body).to include(movie.created_at.to_date.to_s)\n+ end\n+ it \"Check_movie_view\" do\n+ get admin_movies_path, params: { page: 1 }\n+ expect(response.body).to include(movie.views.count.to_s)\n+ end\n+ end\n+\n+ context 'Check_remote_ajax' do\n+ # when click button seemore id smaller than page before\n+ let!(:movie) { create(:movie) }\n+ # display 12 movie before click button see more DESC\n+ before { create_list(:movie, 12) }\n+\n+ it \"Check_remote_http_status\" do\n+ get admin_movies_path, params: { page: 2 }, xhr: true\n+ expect(response).to have_http_status(200)\n+ end\n+ it \"Check_title_remote\" do\n+ get admin_movies_path, params: { page: 2 }, xhr: true\n+ expect(response.body).to include(movie.title)\n+ end\n+ it \"Check_movie_created_at_remote\" do\n+ get admin_movies_path, params: { page: 2 }, xhr: true\n+ expect(response.body).to include(movie.created_at.to_date.to_s)\n+ end\n+ it \"Check_view_remote\" do\n+ get admin_movies_path, params: { page: 2 }, xhr: true\n+ expect(response.body).to include(movie.views.count.to_s)\n+ end\n+\n+ end\n+\n+ it \"Check_if_no_movie\" do\n+ get admin_movies_path\n+ expect(response.body).to include(I18n.t('admin.movies.mdisplay.no_movie'))\n+ end\n+ end\n+\n+ #test action show\n+ describe \"GET #show\" do\n+ let(:admin) { build(:admin) }\n+ before { sign_in admin }\n+ context 'Check_if_movie_exist' do\n+\n+ let!(:movie) { create(:movie) }\n+ it \"Check_movies_http_status\" do\n+ get admin_movie_path(movie)\n+ expect(response).to have_http_status(200)\n+ end\n+ it \"Check_movie_title\" do\n+ get admin_movie_path(movie.id)\n+ expect(response.body).to include(movie.title)\n+ end\n+ it \"Check_movie_price\" do\n+ get admin_movie_path(movie.id)\n+ expect(response.body).to include(movie.price.to_s)\n+ end\n+ it \"Check_movie_created_at\" do\n+ get admin_movie_path(movie.id)\n+ expect(response.body).to include(movie.created_at.to_date.to_s)\n+ end\n+ it \"Check_movie_view\" do\n+ get admin_movie_path(movie.id)\n+ expect(response.body).to include(movie.views.count.to_s)\n+ end\n+ it \"Check_movie_purchase\" do\n+ get admin_movie_path(movie.id)\n+ expect(response.body).to include(movie.purchases.count.to_s)\n+ end","path":"pj_movie/spec/request/admin/movies_controller_spec.rb","position":119,"original_position":119,"commit_id":"322c6dd96f103a88d283fd7ad19dfbdfb24b68fa","original_commit_id":"322c6dd96f103a88d283fd7ad19dfbdfb24b68fa","user":{"login":"N310","id":16056616,"node_id":"MDQ6VXNlcjE2MDU2NjE2","avatar_url":"https://avatars3.githubusercontent.com/u/16056616?v=4","gravatar_id":"","url":"https://api.github.com/users/N310","html_url":"https://github.com/N310","followers_url":"https://api.github.com/users/N310/followers","following_url":"https://api.github.com/users/N310/following{/other_user}","gists_url":"https://api.github.com/users/N310/gists{/gist_id}","starred_url":"https://api.github.com/users/N310/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/N310/subscriptions","organizations_url":"https://api.github.com/users/N310/orgs","repos_url":"https://api.github.com/users/N310/repos","events_url":"https://api.github.com/users/N310/events{/privacy}","received_events_url":"https://api.github.com/users/N310/received_events","type":"User","site_admin":false},"body":"You use `movie` at line 97, but why do you use `movie.id` at these lines?","created_at":"2020-01-03T09:49:17Z","updated_at":"2020-01-03T09:49:35Z","html_url":"https://github.com/scrumcube/pj-movie/pull/25#discussion_r362752523","pull_request_url":"https://api.github.com/repos/scrumcube/pj-movie/pulls/25","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/scrumcube/pj-movie/pulls/comments/362752523"},"html":{"href":"https://github.com/scrumcube/pj-movie/pull/25#discussion_r362752523"},"pull_request":{"href":"https://api.github.com/repos/scrumcube/pj-movie/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/scrumcube/pj-movie/pulls/25","id":354999449,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0OTk5NDQ5","html_url":"https://github.com/scrumcube/pj-movie/pull/25","diff_url":"https://github.com/scrumcube/pj-movie/pull/25.diff","patch_url":"https://github.com/scrumcube/pj-movie/pull/25.patch","issue_url":"https://api.github.com/repos/scrumcube/pj-movie/issues/25","number":25,"state":"open","locked":false,"title":"Admin Video list","user":{"login":"R-Bear","id":31096204,"node_id":"MDQ6VXNlcjMxMDk2MjA0","avatar_url":"https://avatars1.githubusercontent.com/u/31096204?v=4","gravatar_id":"","url":"https://api.github.com/users/R-Bear","html_url":"https://github.com/R-Bear","followers_url":"https://api.github.com/users/R-Bear/followers","following_url":"https://api.github.com/users/R-Bear/following{/other_user}","gists_url":"https://api.github.com/users/R-Bear/gists{/gist_id}","starred_url":"https://api.github.com/users/R-Bear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R-Bear/subscriptions","organizations_url":"https://api.github.com/users/R-Bear/orgs","repos_url":"https://api.github.com/users/R-Bear/repos","events_url":"https://api.github.com/users/R-Bear/events{/privacy}","received_events_url":"https://api.github.com/users/R-Bear/received_events","type":"User","site_admin":false},"body":"# Tasks\r\n### controllers\r\n- [x] pull data from database\r\n### Views\r\n- [x] render in views\r\n### db\r\n- [x] create seed\r\n## Gemfile\r\n### add library\r\n- will_paginate\r\n- bootstrap-will_paginate\r\n","created_at":"2019-12-19T07:51:06Z","updated_at":"2020-01-03T09:49:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17ef9b13ab449e4f9bcac731ce71185261fdd470","assignee":null,"assignees":[],"requested_reviewers":[{"login":"loemhuolay","id":57249718,"node_id":"MDQ6VXNlcjU3MjQ5NzE4","avatar_url":"https://avatars3.githubusercontent.com/u/57249718?v=4","gravatar_id":"","url":"https://api.github.com/users/loemhuolay","html_url":"https://github.com/loemhuolay","followers_url":"https://api.github.com/users/loemhuolay/followers","following_url":"https://api.github.com/users/loemhuolay/following{/other_user}","gists_url":"https://api.github.com/users/loemhuolay/gists{/gist_id}","starred_url":"https://api.github.com/users/loemhuolay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loemhuolay/subscriptions","organizations_url":"https://api.github.com/users/loemhuolay/orgs","repos_url":"https://api.github.com/users/loemhuolay/repos","events_url":"https://api.github.com/users/loemhuolay/events{/privacy}","received_events_url":"https://api.github.com/users/loemhuolay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scrumcube/pj-movie/pulls/25/commits","review_comments_url":"https://api.github.com/repos/scrumcube/pj-movie/pulls/25/comments","review_comment_url":"https://api.github.com/repos/scrumcube/pj-movie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrumcube/pj-movie/issues/25/comments","statuses_url":"https://api.github.com/repos/scrumcube/pj-movie/statuses/322c6dd96f103a88d283fd7ad19dfbdfb24b68fa","head":{"label":"scrumcube:admin_movie_list","ref":"admin_movie_list","sha":"322c6dd96f103a88d283fd7ad19dfbdfb24b68fa","user":{"login":"scrumcube","id":58027230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MDI3MjMw","avatar_url":"https://avatars1.githubusercontent.com/u/58027230?v=4","gravatar_id":"","url":"https://api.github.com/users/scrumcube","html_url":"https://github.com/scrumcube","followers_url":"https://api.github.com/users/scrumcube/followers","following_url":"https://api.github.com/users/scrumcube/following{/other_user}","gists_url":"https://api.github.com/users/scrumcube/gists{/gist_id}","starred_url":"https://api.github.com/users/scrumcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrumcube/subscriptions","organizations_url":"https://api.github.com/users/scrumcube/orgs","repos_url":"https://api.github.com/users/scrumcube/repos","events_url":"https://api.github.com/users/scrumcube/events{/privacy}","received_events_url":"https://api.github.com/users/scrumcube/received_events","type":"Organization","site_admin":false},"repo":{"id":223128134,"node_id":"MDEwOlJlcG9zaXRvcnkyMjMxMjgxMzQ=","name":"pj-movie","full_name":"scrumcube/pj-movie","private":false,"owner":{"login":"scrumcube","id":58027230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MDI3MjMw","avatar_url":"https://avatars1.githubusercontent.com/u/58027230?v=4","gravatar_id":"","url":"https://api.github.com/users/scrumcube","html_url":"https://github.com/scrumcube","followers_url":"https://api.github.com/users/scrumcube/followers","following_url":"https://api.github.com/users/scrumcube/following{/other_user}","gists_url":"https://api.github.com/users/scrumcube/gists{/gist_id}","starred_url":"https://api.github.com/users/scrumcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrumcube/subscriptions","organizations_url":"https://api.github.com/users/scrumcube/orgs","repos_url":"https://api.github.com/users/scrumcube/repos","events_url":"https://api.github.com/users/scrumcube/events{/privacy}","received_events_url":"https://api.github.com/users/scrumcube/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scrumcube/pj-movie","description":null,"fork":false,"url":"https://api.github.com/repos/scrumcube/pj-movie","forks_url":"https://api.github.com/repos/scrumcube/pj-movie/forks","keys_url":"https://api.github.com/repos/scrumcube/pj-movie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrumcube/pj-movie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrumcube/pj-movie/teams","hooks_url":"https://api.github.com/repos/scrumcube/pj-movie/hooks","issue_events_url":"https://api.github.com/repos/scrumcube/pj-movie/issues/events{/number}","events_url":"https://api.github.com/repos/scrumcube/pj-movie/events","assignees_url":"https://api.github.com/repos/scrumcube/pj-movie/assignees{/user}","branches_url":"https://api.github.com/repos/scrumcube/pj-movie/branches{/branch}","tags_url":"https://api.github.com/repos/scrumcube/pj-movie/tags","blobs_url":"https://api.github.com/repos/scrumcube/pj-movie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrumcube/pj-movie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrumcube/pj-movie/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrumcube/pj-movie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrumcube/pj-movie/statuses/{sha}","languages_url":"https://api.github.com/repos/scrumcube/pj-movie/languages","stargazers_url":"https://api.github.com/repos/scrumcube/pj-movie/stargazers","contributors_url":"https://api.github.com/repos/scrumcube/pj-movie/contributors","subscribers_url":"https://api.github.com/repos/scrumcube/pj-movie/subscribers","subscription_url":"https://api.github.com/repos/scrumcube/pj-movie/subscription","commits_url":"https://api.github.com/repos/scrumcube/pj-movie/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrumcube/pj-movie/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrumcube/pj-movie/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrumcube/pj-movie/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrumcube/pj-movie/contents/{+path}","compare_url":"https://api.github.com/repos/scrumcube/pj-movie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrumcube/pj-movie/merges","archive_url":"https://api.github.com/repos/scrumcube/pj-movie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrumcube/pj-movie/downloads","issues_url":"https://api.github.com/repos/scrumcube/pj-movie/issues{/number}","pulls_url":"https://api.github.com/repos/scrumcube/pj-movie/pulls{/number}","milestones_url":"https://api.github.com/repos/scrumcube/pj-movie/milestones{/number}","notifications_url":"https://api.github.com/repos/scrumcube/pj-movie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrumcube/pj-movie/labels{/name}","releases_url":"https://api.github.com/repos/scrumcube/pj-movie/releases{/id}","deployments_url":"https://api.github.com/repos/scrumcube/pj-movie/deployments","created_at":"2019-11-21T08:43:35Z","updated_at":"2020-01-03T02:09:04Z","pushed_at":"2020-01-03T09:15:15Z","git_url":"git://github.com/scrumcube/pj-movie.git","ssh_url":"[email protected]:scrumcube/pj-movie.git","clone_url":"https://github.com/scrumcube/pj-movie.git","svn_url":"https://github.com/scrumcube/pj-movie","homepage":null,"size":2588,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"develop"}},"base":{"label":"scrumcube:develop","ref":"develop","sha":"2790084c288b3327702a6738fc1740d4af46110f","user":{"login":"scrumcube","id":58027230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MDI3MjMw","avatar_url":"https://avatars1.githubusercontent.com/u/58027230?v=4","gravatar_id":"","url":"https://api.github.com/users/scrumcube","html_url":"https://github.com/scrumcube","followers_url":"https://api.github.com/users/scrumcube/followers","following_url":"https://api.github.com/users/scrumcube/following{/other_user}","gists_url":"https://api.github.com/users/scrumcube/gists{/gist_id}","starred_url":"https://api.github.com/users/scrumcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrumcube/subscriptions","organizations_url":"https://api.github.com/users/scrumcube/orgs","repos_url":"https://api.github.com/users/scrumcube/repos","events_url":"https://api.github.com/users/scrumcube/events{/privacy}","received_events_url":"https://api.github.com/users/scrumcube/received_events","type":"Organization","site_admin":false},"repo":{"id":223128134,"node_id":"MDEwOlJlcG9zaXRvcnkyMjMxMjgxMzQ=","name":"pj-movie","full_name":"scrumcube/pj-movie","private":false,"owner":{"login":"scrumcube","id":58027230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MDI3MjMw","avatar_url":"https://avatars1.githubusercontent.com/u/58027230?v=4","gravatar_id":"","url":"https://api.github.com/users/scrumcube","html_url":"https://github.com/scrumcube","followers_url":"https://api.github.com/users/scrumcube/followers","following_url":"https://api.github.com/users/scrumcube/following{/other_user}","gists_url":"https://api.github.com/users/scrumcube/gists{/gist_id}","starred_url":"https://api.github.com/users/scrumcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrumcube/subscriptions","organizations_url":"https://api.github.com/users/scrumcube/orgs","repos_url":"https://api.github.com/users/scrumcube/repos","events_url":"https://api.github.com/users/scrumcube/events{/privacy}","received_events_url":"https://api.github.com/users/scrumcube/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scrumcube/pj-movie","description":null,"fork":false,"url":"https://api.github.com/repos/scrumcube/pj-movie","forks_url":"https://api.github.com/repos/scrumcube/pj-movie/forks","keys_url":"https://api.github.com/repos/scrumcube/pj-movie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrumcube/pj-movie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrumcube/pj-movie/teams","hooks_url":"https://api.github.com/repos/scrumcube/pj-movie/hooks","issue_events_url":"https://api.github.com/repos/scrumcube/pj-movie/issues/events{/number}","events_url":"https://api.github.com/repos/scrumcube/pj-movie/events","assignees_url":"https://api.github.com/repos/scrumcube/pj-movie/assignees{/user}","branches_url":"https://api.github.com/repos/scrumcube/pj-movie/branches{/branch}","tags_url":"https://api.github.com/repos/scrumcube/pj-movie/tags","blobs_url":"https://api.github.com/repos/scrumcube/pj-movie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrumcube/pj-movie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrumcube/pj-movie/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrumcube/pj-movie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrumcube/pj-movie/statuses/{sha}","languages_url":"https://api.github.com/repos/scrumcube/pj-movie/languages","stargazers_url":"https://api.github.com/repos/scrumcube/pj-movie/stargazers","contributors_url":"https://api.github.com/repos/scrumcube/pj-movie/contributors","subscribers_url":"https://api.github.com/repos/scrumcube/pj-movie/subscribers","subscription_url":"https://api.github.com/repos/scrumcube/pj-movie/subscription","commits_url":"https://api.github.com/repos/scrumcube/pj-movie/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrumcube/pj-movie/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrumcube/pj-movie/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrumcube/pj-movie/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrumcube/pj-movie/contents/{+path}","compare_url":"https://api.github.com/repos/scrumcube/pj-movie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrumcube/pj-movie/merges","archive_url":"https://api.github.com/repos/scrumcube/pj-movie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrumcube/pj-movie/downloads","issues_url":"https://api.github.com/repos/scrumcube/pj-movie/issues{/number}","pulls_url":"https://api.github.com/repos/scrumcube/pj-movie/pulls{/number}","milestones_url":"https://api.github.com/repos/scrumcube/pj-movie/milestones{/number}","notifications_url":"https://api.github.com/repos/scrumcube/pj-movie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrumcube/pj-movie/labels{/name}","releases_url":"https://api.github.com/repos/scrumcube/pj-movie/releases{/id}","deployments_url":"https://api.github.com/repos/scrumcube/pj-movie/deployments","created_at":"2019-11-21T08:43:35Z","updated_at":"2020-01-03T02:09:04Z","pushed_at":"2020-01-03T09:15:15Z","git_url":"git://github.com/scrumcube/pj-movie.git","ssh_url":"[email protected]:scrumcube/pj-movie.git","clone_url":"https://github.com/scrumcube/pj-movie.git","svn_url":"https://github.com/scrumcube/pj-movie","homepage":null,"size":2588,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/scrumcube/pj-movie/pulls/25"},"html":{"href":"https://github.com/scrumcube/pj-movie/pull/25"},"issue":{"href":"https://api.github.com/repos/scrumcube/pj-movie/issues/25"},"comments":{"href":"https://api.github.com/repos/scrumcube/pj-movie/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/scrumcube/pj-movie/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/scrumcube/pj-movie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrumcube/pj-movie/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/scrumcube/pj-movie/statuses/322c6dd96f103a88d283fd7ad19dfbdfb24b68fa"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 223128134,
"name": "scrumcube/pj-movie",
"url": "https://api.github.com/repos/scrumcube/pj-movie"
}
|
{
"id": 16056616,
"login": "N310",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16056616?",
"url": "https://api.github.com/users/N310"
}
|
{
"id": 58027230,
"login": "scrumcube",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/58027230?",
"url": "https://api.github.com/orgs/scrumcube"
}
| 2020-01-03T09:49:17 |
11196337187
|
{"actor":{"display_login":"N310"}}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.