sha
stringlengths 1
40
| author
stringlengths 1
63
⌀ | committer
stringlengths 1
41
⌀ | message
stringlengths 1
65.5k
⌀ | subject
stringlengths 1
5.64k
⌀ | subject_length
float64 1
5.64k
⌀ | is_chore
bool 2
classes | is_bot
bool 2
classes | subject_word_count
float64 1
806
⌀ | verb_object_spacy
bool 2
classes | verb_object_stanza
bool 2
classes | fits_requirements
bool 2
classes | owner
stringlengths 2
15
| repo
stringlengths 2
21
| __index_level_0__
int64 0
85.4k
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
f3151284698777357b972549be53b9a3c7b2d5a0
|
Alex Kanunnikov
|
GitHub
|
Update README.md
Co-Authored-By: Melanie Sumner <[email protected]>
|
update readme.md
| 16 | false | false | 2 | false | false | false |
emberjs
|
ember.js
| 2,300 |
761440a68c88f3f4225b91a7c9f2808214a3b461
|
Katie Gengler
|
Katie Gengler
|
Post-release version bump
|
post-release version bump
| 25 | false | false | 3 | false | false | false |
emberjs
|
ember.js
| 2,301 |
0e47aa17097bc515f16e93157aff4e965d89d994
|
Katie Gengler
|
Katie Gengler
|
Add v3.18.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit bf6b8f7dfe03871fcfa28142e35b523e014c0712)
|
add v3.18.0-beta.1 to changelog
| 31 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,302 |
aa58644915c37fd7cd9e82926e68354fe8bcbaef
|
Katie Gengler
|
Katie Gengler
|
Add v3.17.0 to CHANGELOG
[ci skip]
(cherry picked from commit fdb55d93fc43e339b801aeb7eb359237386721d7)
|
add v3.17.0 to changelog
| 24 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,303 |
410ff83f64eb755b2e98d2a13a9851d2adf2e16e
|
Katie Gengler
|
GitHub
|
Merge pull request #18793 from emberjs/bugfix/fix-travis-remove-matrix
[BUGFIX lts] Fixes Travis by removing matrix
|
merge pull request from emberjs/bugfix/fix-travis-remove-matrix
| 64 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,304 |
948e98c0c8fbba6807e2d7d2ad8748d3c3364dec
|
Chris Garrett
|
Chris Garrett
|
[BUGFIX lts] Fixes Travis by removing matrix
A recent change in the way Travis uses matrix broke our build.
It seems like we aren't using the matrix setting anymore
now that jobs are the way to do staging, so removing it for now
to fix the build.
|
[bugfix lts] fixes travis by removing matrix
| 44 | false | false | 7 | false | false | false |
emberjs
|
ember.js
| 2,305 |
bf61cdc11b8a07d4b10c9ccdbd6ef879112e0486
|
Mehul Kar
|
GitHub
|
Update packages/@ember/-internals/runtime/lib/mixins/array.js
Co-Authored-By: Ricardo Mendes <[email protected]>
|
update packages/@ember/-internals/runtime/lib/mixins/array.js
| 61 | false | false | 2 | false | false | false |
emberjs
|
ember.js
| 2,306 |
bf627a73681741a20c43614ab5407133144ff021
|
Ricardo Mendes
|
GitHub
|
Merge pull request #18787 from aaxelb/patch-1
[DOC release] `fn` helper has no `value` param
|
merge pull request from aaxelb/patch-1
| 39 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,307 |
290946224f526d70a2c99270f5b81882271d78d2
|
Mehul Kar
|
Mehul Kar
|
Document special values for key argument for each helper
Addresses #16719
Closes #12853
|
document special values for key argument for each helper
| 56 | false | false | 9 | false | true | false |
emberjs
|
ember.js
| 2,308 |
734d75e060237c3b9e032b2781a363d706ec975b
|
Mehul Kar
|
Mehul Kar
|
Document a contrived example for EmberArray#filter target option
Closes #18522
|
document a contrived example for emberarray#filter target option
| 64 | false | false | 8 | false | true | false |
emberjs
|
ember.js
| 2,309 |
04313dc715d946ed9c7e3add5dfb23ab660c02b2
|
Abram Booth
|
Abram Booth
|
[DOC release] `fn` helper has no `value` param
the `mut` helper docstring has an example using the `fn` helper with
`value` param, but `fn` has no `value` param.
looks like a small oversight updating the docs away from `action`.
|
[doc release] `fn` helper has no `value` param
| 46 | false | false | 8 | false | false | false |
emberjs
|
ember.js
| 2,310 |
2f817cc4399020b9d9e61d4b91568399152fb65b
|
Robert Jackson
|
Robert Jackson
|
Ensure tests for changeProperties use sync observers.
|
ensure tests for changeproperties use sync observers
| 52 | false | false | 7 | true | false | false |
emberjs
|
ember.js
| 2,311 |
a3e1c7e8b9cae1867eb2f7cef22ca739009d874e
|
Robert Jackson
|
Robert Jackson
|
Fix tests failing when enabling template-only-glimmer-components.
These tests were attempting to modify the
`ENV._TEMPLATE_ONLY_GLIMMER_COMPONENTS` value at runtime, but load
different code when it is and isn't set. So now that the test suite is setting
`template-only-glimmer-components` when the Ember code loads we can no
longer "fake" these tests.
However, the changes to the test runner mean that we still test this
both on and off so we are not loosing coverage.
|
fix tests failing when enabling template-only-glimmer-components
| 64 | false | false | 6 | false | true | false |
emberjs
|
ember.js
| 2,312 |
b22e9deded90b33fa46414e599961d084ec01b37
|
Robert Jackson
|
Robert Jackson
|
Fix tests that fail due to application-template-wrapper being set.
When there is no wrapping element around the top level outlet, the debug
render tree assertions need to tweaked.
|
fix tests that fail due to application-template-wrapper being set
| 65 | false | false | 9 | true | true | false |
emberjs
|
ember.js
| 2,313 |
b05d189099fa8cffcb18a1c5f886491d49dde256
|
Robert Jackson
|
Robert Jackson
|
Ensure the test suite runs with Octane's set of optional features.
Prior to these change we would only run the test suite in "classic"
mode, and did not run the tests with the combination of octane optional
features setup.
This adds a new test run for "classic", and makes the default test run
use "octane"'s set of optional features.
|
ensure the test suite runs with octane's set of optional features
| 65 | false | false | 11 | false | false | false |
emberjs
|
ember.js
| 2,314 |
d57409614d6246d672b36e144ca3e64da395003c
|
Robert Jackson
|
GitHub
|
Merge pull request #18785 from rwjblue/drop-node-8
Drop Node 8 support.
|
merge pull request from rwjblue/drop-node-8
| 44 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,315 |
c75f505e54530e8d3e3b57d6860f54fb0efd0534
|
Robert Jackson
|
Robert Jackson
|
Drop Node 8 support.
Our public API around Node version support says:
> To make it easier for us to deliver on our support promise we have
> adopted a policy that the HEAD of our master branches will be compatible
> with all versions of Node.js currently receiving support. For any Ember
> project on the day we drop support for a Node.js version the following
> things will happen:
>
> * We will update the engines key inside of package.json to specify the
> versions supported by the project.
> * We will update the testing targets to remove the newly-unsupported
> Node.js version from the list.
> * We will begin accepting code without testing it against the
newly-unsupported version of Node.js.
>
> For projects with an unspecified release model we will release one last
> version of the project prior to those steps. The version number change
> will reflect SemVer with respect to the APIs of the project and not take
> into consideration removal of Node.js version support. This means that
> the release may show up as a "patch" version release. For example, if
> we're dropping support for Node.js 0.10 and have a project at version
> 1.3.3 we can drop Node.js 0.10 support when we release version 1.3.4.
(from https://blog.emberjs.com/2016/09/07/ember-node-lts-support.html)
|
drop node 8 support
| 19 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,316 |
4299f0f8d1d3fa21e5686aacc7c4c5c4c1a8b673
|
Robert Jackson
|
GitHub
|
Merge pull request #18766 from mehulkar/patch-2
Update route.ts
|
merge pull request from mehulkar/patch-2
| 41 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,317 |
e2dac22c347f59fd1c9a9f721661ebad4fb9994e
|
Robert Jackson
|
GitHub
|
Merge pull request #18780 from emberjs/bugfix/fix-owner-injection
[BUGFIX release] Fix ownerInjection when used to create services directly
|
merge pull request from emberjs/bugfix/fix-owner-injection
| 59 | true | false | 5 | true | true | false |
emberjs
|
ember.js
| 2,318 |
c5886c8aa0ffe6fe3a0e57116c730a3fa9443b22
|
Robert Jackson
|
GitHub
|
Merge pull request #18770 from emberjs/bugfix/fix-array-proxy-content-update
[BUGFIX release] Make ArrayProxy Lazy
|
merge pull request from emberjs/bugfix/fix-array-proxy-content-update
| 70 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,319 |
4cfba41ebdd3eb98efba850e69f0b386544f25c8
|
Robert Jackson
|
GitHub
|
Merge pull request #18741 from emberjs/bugfix/mandatory-setters-dont-clobber
[BUGFIX release] Don't setup mandatory setters on array indexes
|
merge pull request from emberjs/bugfix/mandatory-setters-dont-clobber
| 70 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,320 |
483613d806e3da80528007e27c068baf9567cf76
|
Chris Garrett
|
Chris Garrett
|
[BUGFIX release] Fix ownerInjection when used to create services directly
Fixes `this.owner.ownerInjection()` when used to create Services,
Controllers, and other Framework classes directly. This allows unit
tests to be written for these classes, something that was more common in
older tests.
|
[bugfix release] fix ownerinjection when used to create services directly
| 73 | false | false | 10 | false | false | false |
emberjs
|
ember.js
| 2,321 |
5aa4c615d745ede2c41516b7c1edd2a52625a2d5
|
Chris Garrett
|
Chris Garrett
|
[BUGFIX] Don't setup mandatory setters on array indexes
It turns out that removing items from an array (e.g. via `splice`) will
also remove their descriptors, if any. Could be a browser bug, but I'm
not sure we intended to add setters directly to arrays in the first
place, and if we can't definitely manage them we probably shouldn't.
|
[bugfix] don't setup mandatory setters on array indexes
| 55 | false | false | 8 | false | false | false |
emberjs
|
ember.js
| 2,322 |
fbdcb9c37903e2817105148482f441fdcf98abf0
|
Chris Garrett
|
GitHub
|
Merge pull request #18774 from emberjs/bugfix/fix-property-changes
[BUGFIX] Suspend observer deactivation during property changes
|
merge pull request from emberjs/bugfix/fix-property-changes
| 60 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,323 |
8bbedfa2eebe7857dc09da4122f1caf25783dd75
|
Chris Garrett
|
Chris Garrett
|
[BUGFIX release] Make ArrayProxy Lazy
This PR refactors ArrayProxy to only begin observing the proxied array's
changes the first time the proxy is actually used. This fixes a number
of bugs that have popped up recently, and also ensures that ArrayProxy
creation does not accidentally entangle with the autotracking stack. It
also simplifies the code overall, and conceptually is more in line with
the way that autotracking works.
In addition, it adds a CUSTOM_TAG_FOR to the proxy, to forward the `[]`
and `length` tags from its content directly rather than attempting to
managed them itself. This keeps the system from encountering issues
related to tag updates, and from needing to re-notify when changes are
propagated.
As part of fixing this, I also discovered that the `hasArrayObservers`
API has been broken since ~3.11. I fixed it and added a test.
|
[bugfix release] make arrayproxy lazy
| 37 | false | false | 5 | false | false | false |
emberjs
|
ember.js
| 2,324 |
9c373be80b878f4c765036eab87be8ec4b4d7eb8
|
Chris Garrett
|
Chris Garrett
|
[BUGFIX] Suspend observer deactivation during property changes
We accidentally removed some tests for timing changes in observers when
we were originally refactoring observers. This PR adds these tests back,
and suspends deactivation of observers until after property changes have
completed and observers have been properly fired.
|
[bugfix] suspend observer deactivation during property changes
| 62 | false | false | 7 | false | false | false |
emberjs
|
ember.js
| 2,325 |
7598547531f153827cbf292522250c14a60c2272
|
Robert Jackson
|
GitHub
|
Merge pull request #18764 from emberjs/MelSumner-patch-1
Update CONTRIBUTING.md
|
merge pull request from emberjs/melsumner-patch-1
| 50 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,326 |
f265292720604be5585d0ec6f6c777fb2104e8c8
|
Robert Jackson
|
GitHub
|
Merge pull request #18767 from emberjs/fix-mem-leak
[BUGFIX release] Fix observer leaks
|
merge pull request from emberjs/fix-mem-leak
| 45 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,327 |
d4d6abd5d7a8b9d4bba9d8347db15e5bd4934673
|
Kris Selden
|
Kris Selden
|
[BUGFIX release] Fix observer leaks
|
[bugfix release] fix observer leaks
| 35 | false | false | 5 | false | false | false |
emberjs
|
ember.js
| 2,328 |
7a59e024c01b9c6aed5d527e7411061d2e71c1a9
|
Mehul Kar
|
GitHub
|
Update route.ts
|
update route.ts
| 15 | false | false | 2 | true | false | false |
emberjs
|
ember.js
| 2,329 |
8e50dde0b5753f24c5b03f21a238d3e642a70224
|
Melanie Sumner
|
GitHub
|
Update CONTRIBUTING.md
Adding a link to the community chat in the contributing guides
|
update contributing.md
| 22 | false | false | 2 | false | false | false |
emberjs
|
ember.js
| 2,330 |
3898afa44f8a3d8e57c10c3d3c9a4d86d11517b9
|
Katie Gengler
|
Katie Gengler
|
Add v3.17.0-beta.6 to CHANGELOG
[ci skip]
(cherry picked from commit f5960fcbcd2562a1d719eb94acb8cb17247c4eb0)
|
add v3.17.0-beta.6 to changelog
| 31 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,331 |
426a814b302a192bee68724a0b596d11765067fa
|
Godfrey Chan
|
Katie Gengler
|
Add v3.16.3 to CHANGELOG
[ci skip]
(cherry picked from commit 2cfb76023a5f1e80ca50b7a0512cb08f0bef9c7f)
|
add v3.16.3 to changelog
| 24 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,332 |
47ea95071066c8b5bb8251c953e2d95d68f6a001
|
Robert Jackson
|
GitHub
|
Merge pull request #18752 from mehulkar/patch-1
Update documentation for redirect() hook
|
merge pull request from mehulkar/patch-1
| 41 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,333 |
9f508787abec17c5a58285ff73dbcc30ba41a6d5
|
Robert Jackson
|
GitHub
|
Merge pull request #18761 from emberjs/docs/add-note-about-tracked-update-semantics
[DOC] Adds a note about the invalidation semantics of tracked props
|
merge pull request from emberjs/docs/add-note-about-tracked-update-semantics
| 77 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,334 |
8ad168de0d79402ed8ea56875e40c09a896d6459
|
Robert Jackson
|
GitHub
|
Merge pull request #18762 from GCheung55/bugfix/test-for-18221
[BUGFIX beta] Adding test for #18211
|
merge pull request from gcheung55/bugfix/test-for-18221
| 56 | true | false | 5 | true | true | false |
emberjs
|
ember.js
| 2,335 |
9fe5a6b5a86adb163b02a200bf7562aca87c53e0
|
Garrick Cheung
|
Garrick Cheung
|
Fix lint issues.
|
fix lint issues
| 15 | false | false | 3 | true | true | true |
emberjs
|
ember.js
| 2,336 |
a3858d3d6238ef05a21fb29247bfcfdad5697f83
|
Garrick Cheung
|
Garrick Cheung
|
[BUGFIX beta] Adding test for #18211
|
[bugfix beta] adding test for
| 29 | false | false | 5 | false | false | false |
emberjs
|
ember.js
| 2,337 |
9c4a68b5a0e9df8944d8477e173138e2b2b5dd94
|
Chris Garrett
|
Chris Garrett
|
[DOC] Adds a note about the invalidation semantics of tracked props
|
[doc] adds a note about the invalidation semantics of tracked props
| 67 | false | false | 11 | false | false | false |
emberjs
|
ember.js
| 2,338 |
ac45529b6e78722a61e55dd4ac97aee6864524b9
|
Robert Jackson
|
GitHub
|
Merge pull request #18738 from xg-wang/router-doc
[DOC release] Add note about router service event and property update…
|
merge pull request from xg-wang/router-doc
| 43 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,339 |
6ff9f4db1eb674be0e46fea49e81d76506e18e5a
|
Robert Jackson
|
GitHub
|
Merge pull request #18759 from chriskrycho/transition-to-types-n-docs
[DOCS release] improve types and docs for `transitionTo` methods
|
merge pull request from chriskrycho/transition-to-types-n-docs
| 63 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,340 |
f06f1e2f496b73b3831cac26edc91f08b8b3d9c1
|
Chris Krycho
|
Chris Krycho
|
[DOC release] document QP-only transitionTo in router service
|
[doc release] document qp-only transitionto in router service
| 61 | false | false | 8 | false | false | false |
emberjs
|
ember.js
| 2,341 |
b628b21dc1b0af8928a307b33cd9d2edb3a03a7e
|
Robert Jackson
|
GitHub
|
Merge pull request #18743 from emberjs/bugfix/upgrade-glimmer-vm-0.47.9
[BUGFIX beta] Upgrades Glimmer VM to 0.47.9
|
merge pull request from emberjs/bugfix/upgrade-glimmer-vm-0.47.9
| 65 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,342 |
696948cb813c08927df57c18c87040e4bbb009e1
|
Robert Jackson
|
GitHub
|
[BUGFIX release] Ensure typeof check for Node environments is correct
|
[bugfix release] ensure typeof check for node environments is correct
| 69 | false | false | 10 | false | false | false |
emberjs
|
ember.js
| 2,343 |
9153db64eb504c4b0a96eec622678467365b882a
|
Robert Jackson
|
GitHub
|
Merge pull request #18754 from GCheung55/bugfix/upgrade-glimmer-vm-0.47.9
[BUGFIX beta] Add test for #18693
|
merge pull request from gcheung55/bugfix/upgrade-glimmer-vm-0.47.9
| 67 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,344 |
0933925848b791597e3047c25d46d269c73de8f5
|
Garrick Cheung
|
Robert Jackson
|
[BUGFIX beta] Add test for #18693
|
[bugfix beta] add test for
| 26 | false | false | 5 | false | false | false |
emberjs
|
ember.js
| 2,345 |
b5276d38ac1a27a7c734ffd90a6231b36b8f9e32
|
Robert Jackson
|
Robert Jackson
|
[BUGFIX beta] Fix linting issue with test.
|
[bugfix beta] fix linting issue with test
| 41 | false | false | 7 | false | false | false |
emberjs
|
ember.js
| 2,346 |
f63c27ea2427d1d60671f4fdb1ee6f17c131439a
|
Chris Krycho
|
Chris Krycho
|
[DOC release] include QP-only `transitionTo` info
Both `Route.transitionTo` and `RouterService.transitionTo` support
query-params-only transitions, where the caller invokes the method
like `transitionTo({ queryParams: { ... } })`.
|
[doc release] include qp-only `transitionto` info
| 49 | false | false | 6 | false | false | false |
emberjs
|
ember.js
| 2,347 |
c7cc1c6c49e50b0bfce2257465a9af20941dd757
|
Chris Krycho
|
Chris Krycho
|
[DOC release] improve and explain types in router
A number of the type declarations in the router implementation were
incorrect, overly loose, or both. Fix a number of them, and clearly
mark safe casts with `// SAFETY: ...` and unsafe casts with
`// UNSAFE: ...` comments explaining why the cast is or is not valid.
Hopefully this will make it easier to (a) further improve the safety
of this code later and (b) narrow down the cause of bugs since unsafe
behavior is explicitly flagged.
|
[doc release] improve and explain types in router
| 49 | false | false | 8 | false | false | false |
emberjs
|
ember.js
| 2,348 |
76abb624ea2ee4d148c89970d4bcf17289d3848d
|
Robert Jackson
|
GitHub
|
Merge pull request #18751 from GCheung55/bugfix/upgrade-glimmer-vm-0.47.9
[BUGFIX beta] Adding tests for #18732
|
merge pull request from gcheung55/bugfix/upgrade-glimmer-vm-0.47.9
| 67 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,349 |
e26e058af211ca46f77f7e65c56282ebda7d1125
|
Mehul Kar
|
GitHub
|
Update route.ts
|
update route.ts
| 15 | false | false | 2 | true | false | false |
emberjs
|
ember.js
| 2,350 |
dae92959f448f5d3f22659b5ecc124420ef0c6ad
|
Mehul Kar
|
GitHub
|
Update documentation for redirect() hook
|
update documentation for redirect() hook
| 40 | false | false | 5 | true | true | true |
emberjs
|
ember.js
| 2,351 |
004cea1524184fef755c9cdc43682078eaf9d39c
|
Garrick Cheung
|
Godfrey Chan
|
[BUGFIX beta] Adding tests for #18732
|
[bugfix beta] adding tests for
| 30 | false | false | 5 | false | false | false |
emberjs
|
ember.js
| 2,352 |
9eb6012b99d3bb867123f8ab26f51f203c16717a
|
Thomas Wang
|
Thomas Wang
|
[DOC release] Add note about router service event and property update timing
|
[doc release] add note about router service event and property update timing
| 76 | false | false | 12 | false | false | false |
emberjs
|
ember.js
| 2,353 |
7e09bb2ce2d8a5b1b9ace1b07782bbade039587d
|
Chris Garrett
|
GitHub
|
Merge pull request #18742 from cloutierlp/master
[BUGFIX beta] Fix setDiff computed macro used within glimmer component
|
merge pull request from cloutierlp/master
| 42 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,354 |
230050945f50ad36aff3d05263b688870aff474b
|
Katie Gengler
|
Katie Gengler
|
Add v3.17.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit b5bfd50fe2572bb6d7aa522c73a11d6740429711)
|
add v3.17.0-beta.5 to changelog
| 31 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,355 |
b14380eb0200ea194cc4fa80211f78cc2806fce1
|
Katie Gengler
|
Katie Gengler
|
Add v3.17.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 94dd76c11b6b2ec01bf5a8155379ab9a5b854f7a)
|
add v3.17.0-beta.4 to changelog
| 31 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,356 |
699439c0aaa1917754490efeb5751d10f77e5230
|
Chris Garrett
|
Chris Garrett
|
[BUGFIX beta] Upgrades Glimmer VM to 0.47.9
|
[bugfix beta] upgrades glimmer vm to 0.47.9
| 43 | false | false | 7 | false | false | false |
emberjs
|
ember.js
| 2,357 |
2d6d60541d918285b00eb3a2c20bf74c6c4c1547
|
Louis-Philippe Cloutier
|
Louis-Philippe Cloutier
|
[BUGFIX beta] Fix setDiff computed macro used within glimmer component
|
[bugfix beta] fix setdiff computed macro used within glimmer component
| 70 | false | false | 10 | false | false | false |
emberjs
|
ember.js
| 2,358 |
1f08044fbdbbdffc9cc014b43861eeb4a2f4803f
|
Godfrey Chan
|
GitHub
|
Merge pull request #18730 from emberjs/integers-test
Workaround for #15635 (integer encoding issue)
|
merge pull request from emberjs/integers-test
| 46 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,359 |
69fc6dd37d40a99eb9c5d7c5c86882a94ed6ed41
|
Godfrey Chan
|
Godfrey Chan
|
[BUGFIX lts] Workaround for integer literals
Workaround for the Glimmer VM bug which encodes/decodes integer
literals correctly. See #15635.
Based on #18484 and https://github.com/emberjs/ember.js/pull/18484#issuecomment-566276195
Fixes #15635.
Closes #18484.
Co-authored-by: Saravana Kumar V <[email protected]>
|
[bugfix lts] workaround for integer literals
| 44 | false | false | 6 | false | false | false |
emberjs
|
ember.js
| 2,360 |
e9e726cb4278265b13ea391b6f768d7cb595a6fd
|
Ricardo Mendes
|
GitHub
|
Merge pull request #18735 from jgwhite/doc-glimmer-classic-tracking
[DOC release] Update documentation for tracked with classic classes
|
merge pull request from jgwhite/doc-glimmer-classic-tracking
| 61 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,361 |
1e92e4e9251d319470e82d46ad4f3e3c3a40187c
|
Jamie White
|
Jamie White
|
[DOC release] Update documentation for tracked with classic classes
|
[doc release] update documentation for tracked with classic classes
| 67 | false | false | 9 | false | false | false |
emberjs
|
ember.js
| 2,362 |
43104de9d654eb6f42677a5e6c6fdf73415cf9f5
|
Katie Gengler
|
Katie Gengler
|
Small fixup to CHANGELOG
[ci skip]
|
small fixup to changelog
| 24 | false | false | 4 | false | false | false |
emberjs
|
ember.js
| 2,363 |
c279c7a794779349396ef46bb30ba302b1142b04
|
Robert Jackson
|
Katie Gengler
|
Add v3.16.2 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 83410de19a7080cb5f2641762243b97e5c709614)
|
add v3.16.2 to changelog.md
| 27 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,364 |
56a7c9cd2c6afaf59f129a61fd9e825e3988970e
|
Robert Jackson
|
GitHub
|
Merge pull request #18733 from rwjblue/bring-back-correctness-test-for-lookup-during-destruction
[BUGFIX lts] Add test ensuring singletons instantiated during destruction are destroyed.
|
merge pull request from rwjblue/bring-back-correctness-test-for-lookup-during-destruction
| 90 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,365 |
bac9333d36d00553fa2e4ebb2b0c7354c447c42d
|
Robert Jackson
|
GitHub
|
Merge pull request #18726 from mehulkar/mk/api-docs
[DOC] Add API docs for Route#buildRouteInfoMetadata
|
merge pull request from mehulkar/mk/api-docs
| 45 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,366 |
9378d8f4eef854d8e5b40990f30485a66fc5bf3e
|
Robert Jackson
|
Robert Jackson
|
[BUGFIX lts] Add test ensuring singletons instantiated during destruction are destroyed.
|
[bugfix lts] add test ensuring singletons instantiated during destruction are destroyed
| 87 | false | false | 11 | false | false | false |
emberjs
|
ember.js
| 2,367 |
1b853e1ec40c8b5fbd2a3adc3e60616cc3cb5ac5
|
Godfrey Chan
|
GitHub
|
Merge pull request #18729 from emberjs/revert-container-derecation
[BUGFIX lts] Revert container deprecation
|
merge pull request from emberjs/revert-container-derecation
| 60 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,368 |
b853324e9250434471da352fd766ae53d4f2321f
|
Godfrey Chan
|
Godfrey Chan
|
[BUGFIX lts] Revert container deprecation
We agreed that it was important to fix the error cases in #18717, but
while the work may be unnecessary, there isn't necessarily any
"correctness" issues with looking up things during destruction. Using
a deprecation to warn about potentially "unnecessary" work is a bit
heavy-handed, and at minimum requires some more continued discussions,
so reverting that part of the PR for now (while keeping the errors in
tact).
|
[bugfix lts] revert container deprecation
| 41 | false | false | 5 | false | false | false |
emberjs
|
ember.js
| 2,369 |
80325ecbb7cb4e3bb6c9c1c14c6e39aa9947a641
|
Godfrey Chan
|
GitHub
|
Merge pull request #18728 from emberjs/upgrade-glimmer
[BUGFIX beta] Fix `{{#-in-element}}` double-clearing issue
|
merge pull request from emberjs/upgrade-glimmer
| 48 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,370 |
4c5fad3ea3361550838465e57dc2524fb383823f
|
Godfrey Chan
|
Godfrey Chan
|
[BUGFIX beta] Fix `{{#-in-element}}` double-clearing issue
Closes #18696
|
[bugfix beta] fix `{{#-in-element}}` double-clearing issue
| 58 | false | false | 6 | false | false | false |
emberjs
|
ember.js
| 2,371 |
04e324b7930247024915bcb32fbc75e91e3501ae
|
Robert Jackson
|
GitHub
|
Merge pull request #18724 from xg-wang/refactor/router-tests
Refactor router tests
|
merge pull request from xg-wang/refactor/router-tests
| 54 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,372 |
c8fc3d40c049756a6c3d3465fecc1edeae4daf03
|
Godfrey Chan
|
GitHub
|
Merge pull request #18727 from emberjs/fix-in-element
[BUGFIX beta] Avoid breaking {{-in-element}} usage
|
merge pull request from emberjs/fix-in-element
| 47 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,373 |
da6c5fac3cb69c932c2c77ce065b3cb947b24b53
|
Godfrey Chan
|
Godfrey Chan
|
[BUGFIX beta] Avoid breaking {{-in-element}} usage
The intimate `{{#-in-element}}` API previously defaults to appending
to the remote element without clearing. With the VM upgrade, the
default has changed to clearing the remote element as specified by
the RFC. Since we are not ready to promote the public API yet, we
should preserve the exisiting behavior and let addon authors migrate
to the new public API directly when it is ready.
|
[bugfix beta] avoid breaking {{-in-element}} usage
| 50 | false | false | 6 | false | false | false |
emberjs
|
ember.js
| 2,374 |
e3b272e01914c8149a66dd06f83e8122fe82daa4
|
Robert Jackson
|
Katie Gengler
|
Add v3.16.1 to CHANGELOG.md.
(cherry picked from commit a9e90422d1cdab636f6f0c1c78c48505eb732cee)
|
add v3.16.1 to changelog.md
| 27 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,375 |
30a6b17646d04174acb55c81e0090ec051cf7ab1
|
Katie Gengler
|
Katie Gengler
|
Add v3.17.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 253187f5b165172fa1314f59dc888542d7a6baf7)
|
add v3.17.0-beta.3 to changelog
| 31 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,376 |
7cf043b8ab7d3691eedadbc8c5331495cb828ed1
|
Mehul Kar
|
Mehul Kar
|
[DOC] Add API docs for Route#buildRouteInfoMetadata
Closes #18725
|
[doc] add api docs for route#buildrouteinfometadata
| 51 | false | false | 6 | false | false | false |
emberjs
|
ember.js
| 2,377 |
98b073b31700abe76b56f6a81feb9862b0b6e429
|
Thomas Wang
|
Thomas Wang
|
move template rendering related tests
|
move template rendering related tests
| 37 | false | false | 5 | true | false | true |
emberjs
|
ember.js
| 2,378 |
29751f69022ce939c388eeb75aa27d7f9ee23e8f
|
Thomas Wang
|
Thomas Wang
|
move model loading related tests
|
move model loading related tests
| 32 | false | false | 5 | false | false | false |
emberjs
|
ember.js
| 2,379 |
6b68df8ae7e016d2cb2834efd79769c4a8f1705b
|
Thomas Wang
|
Thomas Wang
|
move methods off test class
|
move methods off test class
| 27 | false | false | 5 | true | true | true |
emberjs
|
ember.js
| 2,380 |
9ed94673c9e2903892ae3d25bda0f95190ea0e86
|
Robert Jackson
|
GitHub
|
[BUGFIX release] Update minimum @ember/edition-utils to 1.2.0. (#18720)
[BUGFIX release] Update minimum @ember/edition-utils to 1.2.0.
|
[bugfix release] update minimum @ember/edition-utils to 1.2.0.
| 62 | false | false | 7 | false | false | false |
emberjs
|
ember.js
| 2,381 |
93d51b134f2385fb6aab45a592aa7645b4012c2b
|
Robert Jackson
|
Robert Jackson
|
Update minimum @ember/edition-utils to 1.2.0.
Prior to this, it was still possible to end up with apps using
[email protected] with @ember/[email protected]. The most common
reason for this is that the lock file mechanism (yarn or npm) attempts
to preserve @ember/[email protected] when updating ember-source from a
prior version.
|
update minimum @ember/edition-utils to 1.2.0
| 44 | false | false | 5 | false | false | false |
emberjs
|
ember.js
| 2,382 |
0a75c9e631f67da06a87a2050140eba4958be518
|
Robert Jackson
|
GitHub
|
[DOCS] Route, setupController: add missing transition param (#18596)
[DOCS] Route, setupController: add missing transition param
|
add missing transition param
| 28 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,383 |
f0fceae4b401ecfa45df56e6f3c29ddd0715793e
|
Ricardo Mendes
|
GitHub
|
Merge pull request #18718 from betocantu93/patch-3
add trailing ' to setEach
|
merge pull request from betocantu93/patch-3
| 44 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,384 |
0f9a448d3c1332a592ff1c402e12a30b4527aabf
|
Alberto Cantú Gómez
|
GitHub
|
found little ' typo
|
found little ' typo
| 19 | false | false | 4 | false | false | false |
emberjs
|
ember.js
| 2,385 |
522c2d07622aa52c83aa59d5490b686492c75a8a
|
Robert Jackson
|
GitHub
|
Merge pull request #18717 from rwjblue/container-cleanup-race-oh-my
[BUGFIX lts] Ensure instantiation cannot happen after destruction.
|
merge pull request from rwjblue/container-cleanup-race-oh-my
| 61 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,386 |
2c5b05ba9651c5b0cd3a80cccf1a89b911702708
|
Robert Jackson
|
GitHub
|
Merge pull request #18714 from rwjblue/update-glimmer
Update glimmer packages to 0.47.4.
|
merge pull request from rwjblue/update-glimmer
| 47 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,387 |
298a086c06085756caa1ac4c6f340f77061534e2
|
Robert Jackson
|
Robert Jackson
|
[BUGFIX lts] Ensure instantiation cannot happen after destruction.
This changes a bit about how destruction occurs and is enforced. Without
these changes, it is possible to introduce memory leaks in FastBoot in
a few (somewhat specialized) scenarios. Some examples:
* if you were to call `owner.lookup` sometime after the owner itself was
destroyed. During development and tests we prevent this (by way of an
assertion), but in production we happily recreate the instances
(without marking them as `isDestroying`) and never destroy them
* if you were to call `owner.lookup` _during_ destruction (e.g. in
another services `willDestroy`) we would emit no warning / assertion
even in development mode, and we would never destroy the instances
created
In order to prevent these situations, this commit introduces these
changes:
1. ensure that looking things up from the container _during_
destruction emits a deprecation
2. ensure that looking things up from the container _after_ destruction
throws an error (**not** an assertion)
3. ensure that any objects that _are_ instantiated during container
destruction (even though deprecated) will themselves be destroyed
|
[bugfix lts] ensure instantiation cannot happen after destruction
| 65 | false | false | 8 | false | false | false |
emberjs
|
ember.js
| 2,388 |
54072b75a3041a47397b2d0b35ecfad2ebb3ffdb
|
Chris Garrett
|
GitHub
|
Merge pull request #18707 from emberjs/bugfix/fix-object-proxy-tags
[BUGFIX release] Fixes tag chaining on Proxy mixins
|
merge pull request from emberjs/bugfix/fix-object-proxy-tags
| 61 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,389 |
30b324ba23a559894c182529b953a1557c0f4831
|
Robert Jackson
|
Robert Jackson
|
Update glimmer packages to 0.47.4.
The only change here is an update to simple-html-tokenizer which fixes
compilation errors for `<Title></Title>` (having a custom title
component).
|
update glimmer packages to 0.47.4
| 33 | false | false | 5 | true | true | true |
emberjs
|
ember.js
| 2,390 |
f357405c6c9a131668f92c7e907ca33a4f8d0c9a
|
Robert Jackson
|
GitHub
|
Merge pull request #18703 from emberjs/bugfix/fix-array-proxy-tags
[BUGFIX release] Correctly links ArrayProxy tags to `arrangedContent`
|
merge pull request from emberjs/bugfix/fix-array-proxy-tags
| 60 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,391 |
4934bc19054609daa8a476d238500a513eda27a9
|
Chris Garrett
|
Chris Garrett
|
[BUGFIX release] Fixes tag chaining on Proxy mixins
Currently, the Proxy mixin uses the private `UNKNOWN_PROPERTY_TAG` API
to provide the tags for the content property that the mixin is proxying
to. However, previously the chains system would do this _and_ still
entangle changes to the local property. This allowed users to manually
notify in subclasses of Proxy.
This PR adds the tag for the property back to the returned tag, so it
works the same as before. It also refactors `setupMandatorySetter`,
since we now have to do that work in two places (to avoid re-entry).
|
[bugfix release] fixes tag chaining on proxy mixins
| 51 | false | false | 8 | false | false | false |
emberjs
|
ember.js
| 2,392 |
5600946ad5d1e84df91cdb46c5a1708859ec8c64
|
Robert Jackson
|
GitHub
|
[BUGFIX beta] Adds a canary feature flag for named blocks (#18697)
[BUGFIX beta] Adds a canary feature flag for named blocks
|
[bugfix beta] adds a canary feature flag for named blocks
| 57 | false | false | 10 | false | false | false |
emberjs
|
ember.js
| 2,393 |
a3ee32ef69eb55bc6fac1352fa776d27ce3c84e2
|
Robert Jackson
|
GitHub
|
[BUGFIX release] Ensures the arg proxy works with `get` (#18708)
[BUGFIX release] Ensures the arg proxy works with `get`
|
[bugfix release] ensures the arg proxy works with `get`
| 55 | false | false | 9 | false | false | false |
emberjs
|
ember.js
| 2,394 |
99e796a0ae52bc161b8541d0e481d27b7f21164c
|
Katie Gengler
|
Katie Gengler
|
Add v3.17.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 799c0c38648e157a75dfad78aa6267b6f77f5094)
|
add v3.17.0-beta.2 to changelog
| 31 | false | false | 4 | true | true | true |
emberjs
|
ember.js
| 2,395 |
12db6df9e9167766a02ac27441aa508063a06fda
|
Godfrey Chan
|
GitHub
|
Merge pull request #18709 from emberjs/fix-tracked-initializers
[BUGFIX beta] Fix `this` in `@tracked` initializer
|
merge pull request from emberjs/fix-tracked-initializers
| 57 | true | false | 5 | true | false | false |
emberjs
|
ember.js
| 2,396 |
f942531b287515ec0f1738eea54a83ea70a3ffaf
|
Godfrey Chan
|
Godfrey Chan
|
[BUGFIX beta] Fix `this` in `@tracked` initializer
Fixes #18690
|
[bugfix beta] fix `this` in `@tracked` initializer
| 50 | false | false | 7 | false | false | false |
emberjs
|
ember.js
| 2,397 |
6e8eb68e7dfdc9620848208b0dcd5d2a4baf4630
|
Chris Garrett
|
Chris Garrett
|
[BUGFIX release] Ensures the arg proxy works with `get`
Previously, the arg proxy used a custom system for passing along its
`capturedArgs` directly to `getChainTags`, in order to interoperate with
computed properties. As it turns out, there are a number of other places
where the correct tag needs to be gotten and setup.
This PR replaces the `UNKNOWN_PROPERTY_TAG` system with a more general
`CUSTOM_TAG_FOR` system. In this system, if we detect that an object has
this method, we defer to it to get the tag, even if the property was
defined on the object. There are two users of this system:
- ProxyMixin
- The arg proxy
Given that it's private, and we have relatively few use cases, I believe
this is the cleanest solution at the moment. The alternative would be to
keep `UNKNOWN_PROPERTY_TAG` and also add `CUSTOM_TAG_FOR`, but that
seems unnecessary given low usage.
|
[bugfix release] ensures the arg proxy works with `get`
| 55 | false | false | 9 | false | false | false |
emberjs
|
ember.js
| 2,398 |
2fe2d01ad3312d1d28d4723d3f170357b2f7f688
|
Chris Garrett
|
Chris Garrett
|
add assertion for yield, fix assertion for usage
|
add assertion for yield, fix assertion for usage
| 48 | false | false | 8 | true | true | true |
emberjs
|
ember.js
| 2,399 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.