content_type
stringclasses 8
values | main_lang
stringclasses 7
values | message
stringlengths 1
50
| sha
stringlengths 40
40
| patch
stringlengths 52
962k
| file_count
int64 1
300
|
|---|---|---|---|---|---|
Javascript | Javascript | tweak some wording | 7afa27927f0b8a80f3d640f352885d3210b01911 | <ide><path>gulpfile.js
<ide> var elixir = require('laravel-elixir');
<ide>
<ide> /*
<del> |----------------------------------------------------------------
<del> | Have a Drink!
<del> |----------------------------------------------------------------
<add> |--------------------------------------------------------------------------
<add> | Elixir Asset Management
<add> |--------------------------------------------------------------------------
<ide> |
<del> | Elixir provides a clean, fluent API for defining some basic
<del> | Gulp tasks for your Laravel application. Elixir supports
<del> | several common CSS, JavaScript and even testing tools!
<add> | Elixir provides a clean, fluent API for defining some basic Gulp tasks
<add> | for your Laravel application. By default, we are compiling the Sass
<add> | file for our application, as well as publishing vendor resources.
<ide> |
<ide> */
<ide> | 1 |
Javascript | Javascript | add tests to assert.ok and improve coverage | 6e9d79564234919b656a92da3e0ac3bc8a49bc2c | <ide><path>test/parallel/test-assert.js
<ide> assert.ok(a.AssertionError.prototype instanceof Error,
<ide> assert.throws(() => a(false), a.AssertionError, 'ok(false)');
<ide> assert.throws(() => a.ok(false), a.AssertionError, 'ok(false)');
<ide>
<add>// Throw message if the message is instanceof Error.
<add>{
<add> let threw = false;
<add> try {
<add> assert.ok(false, new Error('ok(false)'));
<add> } catch (e) {
<add> threw = true;
<add> assert.ok(e instanceof Error);
<add> }
<add> assert.ok(threw, 'Error: ok(false)');
<add>}
<add>
<add>
<ide> a(true);
<ide> a('test', 'ok(\'test\')');
<ide> a.ok(true); | 1 |
Python | Python | simplify property test | 41dc0508a03d869226cefbe074bdf5fa00484d8d | <ide><path>numpy/core/tests/test_numeric.py
<ide> def test_NaT_propagation(self, arr, amin, amax):
<ide> actual = np.clip(arr, amin, amax)
<ide> assert_equal(actual, expected)
<ide>
<del> @given(data=st.data(), shape=hynp.array_shapes())
<del> def test_clip_property(self, data, shape):
<add> @given(
<add> data=st.data(),
<add> arr=hynp.arrays(
<add> dtype=hynp.integer_dtypes() | hynp.floating_dtypes(),
<add> shape=hynp.array_shapes()
<add> )
<add> )
<add> def test_clip_property(self, data, arr):
<ide> """A property-based test using Hypothesis.
<ide>
<ide> This aims for maximum generality: it could in principle generate *any*
<ide> def test_clip_property(self, data, shape):
<ide> That accounts for most of the function; the actual test is just three
<ide> lines to calculate and compare actual vs expected results!
<ide> """
<del> # Our base array and bounds should not need to be of the same type as
<del> # long as they are all compatible - so we allow any int or float type.
<del> dtype_strategy = hynp.integer_dtypes() | hynp.floating_dtypes()
<del>
<del> # The following line is a total hack to disable the varied-dtypes
<del> # component of this test, because result != expected if dtypes can vary.
<del> dtype_strategy = st.just(data.draw(dtype_strategy))
<del>
<del> # Generate an arbitrary array of the chosen shape and dtype
<del> # This is the value that we clip.
<del> arr = data.draw(hynp.arrays(dtype=dtype_strategy, shape=shape))
<del>
<ide> # Generate shapes for the bounds which can be broadcast with each other
<ide> # and with the base shape. Below, we might decide to use scalar bounds,
<ide> # but it's clearer to generate these shapes unconditionally in advance.
<ide> in_shapes, result_shape = data.draw(
<ide> hynp.mutually_broadcastable_shapes(
<ide> num_shapes=2,
<del> base_shape=shape,
<add> base_shape=arr.shape,
<ide> # Commenting out the min_dims line allows zero-dimensional arrays,
<ide> # and zero-dimensional arrays containing NaN make the test fail.
<ide> min_dims=1
<del>
<ide> )
<ide> )
<add> # This test can fail if we allow either bound to be a scalar `nan`, or
<add> # if bounds are of a different (still integer or float) dtype than the
<add> # array. At some point we should investigate and fix those problems.
<ide> amin = data.draw(
<del> dtype_strategy.flatmap(hynp.from_dtype)
<del> | hynp.arrays(dtype=dtype_strategy, shape=in_shapes[0])
<add> hynp.from_dtype(arr.dtype, allow_nan=False)
<add> | hynp.arrays(dtype=arr.dtype, shape=in_shapes[0])
<ide> )
<ide> amax = data.draw(
<del> dtype_strategy.flatmap(hynp.from_dtype)
<del> | hynp.arrays(dtype=dtype_strategy, shape=in_shapes[1])
<add> hynp.from_dtype(arr.dtype, allow_nan=False)
<add> | hynp.arrays(dtype=arr.dtype, shape=in_shapes[1])
<ide> )
<del> # If we allow either bound to be a scalar `nan`, the test will fail -
<del> # so we just "assume" that away (if it is, this raises a special
<del> # exception and Hypothesis will try again with different inputs)
<del> assume(not np.isscalar(amin) or not np.isnan(amin))
<del> assume(not np.isscalar(amax) or not np.isnan(amax))
<ide>
<ide> # Then calculate our result and expected result and check that they're
<ide> # equal! See gh-12519 for discussion deciding on this property. | 1 |
Javascript | Javascript | improve merging of resolve and parsing options | f03c4f127ae568ae451246a387a65419a675401c | <ide><path>lib/NormalModuleFactory.js
<ide> const ModuleFactory = require("./ModuleFactory");
<ide> const NormalModule = require("./NormalModule");
<ide> const RawModule = require("./RawModule");
<ide> const RuleSet = require("./RuleSet");
<del>const cachedMerge = require("./util/cachedMerge");
<add>const { cachedCleverMerge } = require("./util/cleverMerge");
<ide>
<ide> /** @typedef {import("./ModuleFactory").ModuleFactoryCreateData} ModuleFactoryCreateData */
<ide> /** @typedef {import("./ModuleFactory").ModuleFactoryResult} ModuleFactoryResult */
<ide> class NormalModuleFactory extends ModuleFactory {
<ide> typeof settings[r.type] === "object" &&
<ide> settings[r.type] !== null
<ide> ) {
<del> settings[r.type] = cachedMerge(settings[r.type], r.value);
<add> settings[r.type] = cachedCleverMerge(settings[r.type], r.value);
<ide> } else {
<ide> settings[r.type] = r.value;
<ide> }
<ide><path>lib/ResolverFactory.js
<ide>
<ide> const Factory = require("enhanced-resolve").ResolverFactory;
<ide> const { HookMap, SyncHook, SyncWaterfallHook } = require("tapable");
<add>const { cachedCleverMerge } = require("./util/cleverMerge");
<ide>
<ide> /** @typedef {import("enhanced-resolve").Resolver} Resolver */
<ide>
<ide> module.exports = class ResolverFactory {
<ide> resolver.withOptions = options => {
<ide> const cacheEntry = childCache.get(options);
<ide> if (cacheEntry !== undefined) return cacheEntry;
<del> const mergedOptions = Object.assign({}, originalResolveOptions, options);
<add> const mergedOptions = cachedCleverMerge(originalResolveOptions, options);
<ide> const resolver = this.get(type, mergedOptions);
<ide> childCache.set(options, resolver);
<ide> return resolver;
<ide><path>lib/WebpackOptionsApply.js
<ide> const DefaultStatsFactoryPlugin = require("./stats/DefaultStatsFactoryPlugin");
<ide> const DefaultStatsPresetPlugin = require("./stats/DefaultStatsPresetPlugin");
<ide> const DefaultStatsPrinterPlugin = require("./stats/DefaultStatsPrinterPlugin");
<ide>
<add>const { cachedCleverMerge } = require("./util/cleverMerge");
<add>
<ide> /** @typedef {import("../declarations/WebpackOptions").WebpackOptions} WebpackOptions */
<ide> /** @typedef {import("./Compiler")} Compiler */
<ide>
<ide> class WebpackOptionsApply extends OptionsApply {
<ide> {
<ide> fileSystem: compiler.inputFileSystem
<ide> },
<del> options.resolve,
<del> resolveOptions
<add> cachedCleverMerge(options.resolve, resolveOptions)
<ide> );
<ide> });
<ide> compiler.resolverFactory.hooks.resolveOptions
<ide> class WebpackOptionsApply extends OptionsApply {
<ide> fileSystem: compiler.inputFileSystem,
<ide> resolveToContext: true
<ide> },
<del> options.resolve,
<del> resolveOptions
<add> cachedCleverMerge(options.resolve, resolveOptions)
<ide> );
<ide> });
<ide> compiler.resolverFactory.hooks.resolveOptions
<ide> class WebpackOptionsApply extends OptionsApply {
<ide> {
<ide> fileSystem: compiler.inputFileSystem
<ide> },
<del> options.resolveLoader,
<del> resolveOptions
<add> cachedCleverMerge(options.resolveLoader, resolveOptions)
<ide> );
<ide> });
<ide> compiler.hooks.afterResolvers.call(compiler);
<ide><path>lib/util/cachedMerge.js
<del>/*
<del> MIT License http://www.opensource.org/licenses/mit-license.php
<del> Author Tobias Koppers @sokra
<del>*/
<del>
<del>"use strict";
<del>
<del>const mergeCache = new WeakMap();
<del>
<del>/**
<del> * Merges two given objects and caches the result to avoid computation if same objects passed as arguments again.
<del> * @example
<del> * // performs Object.assign(first, second), stores the result in WeakMap and returns result
<del> * cachedMerge({a: 1}, {a: 2})
<del> * {a: 2}
<del> * // when same arguments passed, gets the result from WeakMap and returns it.
<del> * cachedMerge({a: 1}, {a: 2})
<del> * {a: 2}
<del> * @param {object} first first object
<del> * @param {object} second second object
<del> * @returns {object} merged object of first and second object
<del> */
<del>const cachedMerge = (first, second) => {
<del> let innerCache = mergeCache.get(first);
<del> if (innerCache === undefined) {
<del> innerCache = new WeakMap();
<del> mergeCache.set(first, innerCache);
<del> }
<del> const prevMerge = innerCache.get(second);
<del> if (prevMerge !== undefined) return prevMerge;
<del> const newMerge = Object.assign({}, first, second);
<del> innerCache.set(second, newMerge);
<del> return newMerge;
<del>};
<del>
<del>module.exports = cachedMerge;
<ide><path>lib/util/cleverMerge.js
<add>/*
<add> MIT License http://www.opensource.org/licenses/mit-license.php
<add> Author Tobias Koppers @sokra
<add>*/
<add>
<add>"use strict";
<add>
<add>const mergeCache = new WeakMap();
<add>
<add>/**
<add> * Merges two given objects and caches the result to avoid computation if same objects passed as arguments again.
<add> * @example
<add> * // performs cleverMerge(first, second), stores the result in WeakMap and returns result
<add> * cachedCleverMerge({a: 1}, {a: 2})
<add> * {a: 2}
<add> * // when same arguments passed, gets the result from WeakMap and returns it.
<add> * cachedCleverMerge({a: 1}, {a: 2})
<add> * {a: 2}
<add> * @param {object} first first object
<add> * @param {object} second second object
<add> * @returns {object} merged object of first and second object
<add> */
<add>const cachedCleverMerge = (first, second) => {
<add> let innerCache = mergeCache.get(first);
<add> if (innerCache === undefined) {
<add> innerCache = new WeakMap();
<add> mergeCache.set(first, innerCache);
<add> }
<add> const prevMerge = innerCache.get(second);
<add> if (prevMerge !== undefined) return prevMerge;
<add> const newMerge = cleverMerge(first, second);
<add> innerCache.set(second, newMerge);
<add> return newMerge;
<add>};
<add>
<add>/**
<add> * Merges two objects. Objects are deeply clever merged.
<add> * Arrays might reference the old value with "..."
<add> * @param {object} first first object
<add> * @param {object} second second object
<add> * @returns {object} merged object of first and second object
<add> */
<add>const cleverMerge = (first, second) => {
<add> const newObject = Object.assign({}, first);
<add> for (const key of Object.keys(second)) {
<add> if (!(key in newObject)) {
<add> newObject[key] = second[key];
<add> continue;
<add> }
<add> const secondValue = second[key];
<add> if (typeof secondValue !== "object" || secondValue === null) {
<add> newObject[key] = secondValue;
<add> }
<add> if (Array.isArray(secondValue)) {
<add> const firstValue = newObject[key];
<add> if (Array.isArray(firstValue)) {
<add> const newArray = [];
<add> for (const item of secondValue) {
<add> if (item === "...") {
<add> for (const item of firstValue) {
<add> newArray.push(item);
<add> }
<add> } else {
<add> newArray.push(item);
<add> }
<add> }
<add> newObject[key] = newArray;
<add> } else {
<add> newObject[key] = secondValue;
<add> }
<add> } else {
<add> const firstValue = newObject[key];
<add> if (
<add> typeof firstValue === "object" &&
<add> firstValue !== null &&
<add> !Array.isArray(firstValue)
<add> ) {
<add> newObject[key] = cleverMerge(firstValue, secondValue);
<add> } else {
<add> newObject[key] = secondValue;
<add> }
<add> }
<add> }
<add> return newObject;
<add>};
<add>
<add>exports.cachedCleverMerge = cachedCleverMerge;
<add>exports.cleverMerge = cleverMerge;
<ide><path>test/cases/loaders/resolve/index.js
<ide> it("should be possible to create resolver with different options", () => {
<ide> const result = require("./loader!");
<ide> expect(result).toEqual({
<ide> one: "index.js",
<del> two: "index.xyz"
<add> two: "index.xyz",
<add> three: "index.js",
<add> four: "index.xyz",
<add> five: "index.js"
<ide> });
<del>})
<add>});
<ide><path>test/cases/loaders/resolve/loader.js
<ide> module.exports = function() {
<ide> const resolve2 = this.getResolve({
<ide> extensions: [".xyz", ".js"]
<ide> });
<add> const resolve3 = this.getResolve({
<add> extensions: [".hee", "..."]
<add> });
<add> const resolve4 = this.getResolve({
<add> extensions: [".xyz", "..."]
<add> });
<add> const resolve5 = this.getResolve({
<add> extensions: ["...", ".xyz"]
<add> });
<ide> return Promise.all([
<ide> resolve1(__dirname, "./index"),
<del> resolve2(__dirname, "./index")
<del> ]).then(([one, two]) => {
<add> resolve2(__dirname, "./index"),
<add> resolve3(__dirname, "./index"),
<add> resolve4(__dirname, "./index"),
<add> resolve5(__dirname, "./index")
<add> ]).then(([one, two, three, four, five]) => {
<ide> return `module.exports = ${JSON.stringify({
<ide> one: path.basename(one),
<ide> two: path.basename(two),
<add> three: path.basename(three),
<add> four: path.basename(four),
<add> five: path.basename(five)
<ide> })}`;
<ide> });
<ide> };
<ide><path>test/configCases/rule-set/resolve-options/a.js
<del>module.exports = require("./wrong");
<add>module.exports = require("./wrong") + require("./normal") + require("./wrong2");
<ide><path>test/configCases/rule-set/resolve-options/b.js
<del>module.exports = require("./wrong");
<add>module.exports = require("./wrong") + require("./normal") + require("./wrong2");
<ide><path>test/configCases/rule-set/resolve-options/c.js
<add>module.exports = require("./wrong") + require("./normal") + require("./wrong2");
<ide><path>test/configCases/rule-set/resolve-options/index.js
<ide> it("should allow to set custom resolving rules", function() {
<ide> var a = require("./a");
<del> expect(a).toBe("ok");
<add> expect(a).toBe("ok-normal-ok2");
<ide> var b = require("./b");
<del> expect(b).toBe("wrong");
<add> expect(b).toBe("ok-normal-ok2-yes");
<add> var c = require("./c");
<add> expect(c).toBe("wrong-normal-ok2");
<ide> });
<ide><path>test/configCases/rule-set/resolve-options/normal.js
<add>module.exports = "-normal-";
<ide><path>test/configCases/rule-set/resolve-options/ok.ok.js
<add>module.exports = "ok-ok";
<ide><path>test/configCases/rule-set/resolve-options/ok2.js
<add>module.exports = "ok2";
<ide><path>test/configCases/rule-set/resolve-options/ok2.yes.js
<add>module.exports = "ok2-yes";
<ide><path>test/configCases/rule-set/resolve-options/webpack.config.js
<ide> module.exports = {
<add> resolve: {
<add> alias: {
<add> "./wrong2": "./ok2"
<add> }
<add> },
<ide> module: {
<ide> rules: [
<ide> {
<ide> test: require.resolve("./a"),
<ide> resolve: {
<ide> alias: {
<ide> "./wrong": "./ok"
<del> }
<add> },
<add> extensions: [".js", ".ok.js"]
<add> }
<add> },
<add> {
<add> test: require.resolve("./b"),
<add> resolve: {
<add> alias: {
<add> "./wrong": "./ok"
<add> },
<add> extensions: ["...", ".ok.js"]
<add> }
<add> },
<add> {
<add> test: require.resolve("./b"),
<add> resolve: {
<add> extensions: [".yes.js", "..."]
<ide> }
<ide> }
<ide> ]
<ide><path>test/configCases/rule-set/resolve-options/wrong2.js
<add>module.exports = "wrong2"; | 17 |
Javascript | Javascript | remove unneeded test code | 3410d84e33d02300c4afb340b7c5fc8fba63c4f8 | <ide><path>lib/Entrypoint.js
<ide> Entrypoint.prototype.insertChunk = function(chunk, before) {
<ide> chunk.entrypoints.push(this);
<ide> };
<ide>
<del>Entrypoint.prototype.getFiles = function(filterPredicate) {
<add>Entrypoint.prototype.getFiles = function() {
<ide> var files = [];
<ide>
<ide> for(var chunkIdx = 0; chunkIdx < this.chunks.length; chunkIdx++) {
<ide> Entrypoint.prototype.getFiles = function(filterPredicate) {
<ide> }
<ide> }
<ide>
<del> if (typeof filterFn !== 'undefined') {
<del> return
<del> }
<del>
<ide> return files;
<ide> }
<ide> | 1 |
Ruby | Ruby | explain different ways to use match() | d1ef543794efdcc1d225055f88cbc88b20e84921 | <ide><path>actionpack/lib/action_dispatch/routing/mapper.rb
<ide> def root(options = {})
<ide> match '/', options.reverse_merge(:as => :root)
<ide> end
<ide>
<del> # When you set up a regular route, you supply a series of symbols that
<del> # Rails maps to parts of an incoming HTTP request.
<del> #
<del> # match ':controller/:action/:id/:user_id'
<del> #
<del> # Two of these symbols are special: :controller maps to the name of a
<del> # controller in your application, and :action maps to the name of an
<del> # action within that controller. Anything other than :controller or
<del> # :action will be available to the action as part of params.
<add> # Matches a pattern to one or more urls. Any symbols in a pattern are
<add> # interpreted as url parameters:
<add> #
<add> # # sets parameters :controller, :action and :id
<add> # match ':controller/:action/:id'
<add> #
<add> # Two of these symbols are special: <tt>:controller</tt> maps to the
<add> # controller name and <tt>:action</tt> to the action name within that
<add> # controller. Anything other than <tt>:controller</tt> or
<add> # <tt>:action</tt> will be available to the action as part of +params+.
<add> # If a pattern does not have :controller and :action symbols, then they
<add> # must be set in options or shorthand. For example:
<add> #
<add> # match 'photos/:id' => 'photos#show'
<add> # match 'photos/:id', :to => 'photos#show'
<add> # match 'photos/:id', :controller => 'photos', :action => 'show'
<ide> #
<ide> # === Supported options
<ide> # | 1 |
Javascript | Javascript | add support for missing html elements | fc5f7e0e85e164f6826cf1ddc3f055f6ee4f93cb | <ide><path>src/core/ReactDOM.js
<ide> var ReactDOM = objMapKeyVal({
<ide> a: false,
<ide> abbr: false,
<ide> address: false,
<add> area: false,
<add> article: false,
<add> aside: false,
<ide> audio: false,
<ide> b: false,
<add> base: false,
<add> bdi: false,
<add> bdo: false,
<add> big: false,
<ide> blockquote: false,
<ide> body: false,
<ide> br: true,
<ide> button: false,
<add> canvas: false,
<add> caption: false,
<add> cite: false,
<ide> code: false,
<ide> col: true,
<ide> colgroup: false,
<add> data: false,
<add> datalist: false,
<ide> dd: false,
<add> del: false,
<add> details: false,
<add> dfn: false,
<ide> div: false,
<del> section: false,
<ide> dl: false,
<ide> dt: false,
<ide> em: false,
<ide> var ReactDOM = objMapKeyVal({
<ide> h4: false,
<ide> h5: false,
<ide> h6: false,
<add> head: false,
<ide> header: false,
<ide> hr: true,
<add> html: false,
<ide> i: false,
<ide> iframe: false,
<ide> img: true,
<ide> input: true,
<add> ins: false,
<add> kbd: false,
<add> keygen: true,
<ide> label: false,
<ide> legend: false,
<ide> li: false,
<del> line: false,
<add> link: false,
<add> main: false,
<add> map: false,
<add> mark: false,
<add> menu: false,
<add> menuitem: false, // NOTE: Close tag should be omitted, but causes problems.
<add> meta: true,
<add> meter: false,
<ide> nav: false,
<add> noscript: false,
<ide> object: false,
<ide> ol: false,
<ide> optgroup: false,
<ide> option: false,
<add> output: false,
<ide> p: false,
<ide> param: true,
<ide> pre: false,
<add> progress: false,
<add> q: false,
<add> rp: false,
<add> rt: false,
<add> ruby: false,
<add> s: false,
<add> samp: false,
<add> script: false,
<add> section: false,
<ide> select: false,
<ide> small: false,
<ide> source: false,
<ide> span: false,
<add> strong: false,
<add> style: false,
<ide> sub: false,
<add> summary: false,
<ide> sup: false,
<del> strong: false,
<ide> table: false,
<ide> tbody: false,
<ide> td: false,
<ide> var ReactDOM = objMapKeyVal({
<ide> time: false,
<ide> title: false,
<ide> tr: false,
<add> track: true,
<ide> u: false,
<ide> ul: false,
<add> 'var': false,
<ide> video: false,
<ide> wbr: false,
<ide>
<ide> // SVG
<ide> circle: false,
<ide> g: false,
<add> line: false,
<ide> path: false,
<ide> polyline: false,
<ide> rect: false, | 1 |
Java | Java | update copyright date | 222dbf837702ac01b04c42432f4995dd7d2f1b08 | <ide><path>spring-web/src/main/java/org/springframework/web/multipart/support/StandardMultipartHttpServletRequest.java
<ide> /*
<del> * Copyright 2002-2018 the original author or authors.
<add> * Copyright 2002-2022 the original author or authors.
<ide> *
<ide> * Licensed under the Apache License, Version 2.0 (the "License");
<ide> * you may not use this file except in compliance with the License. | 1 |
Text | Text | add note re term-size commit on top of npm | 10d8e2687e9217ff3c5722b2b3293cf1f0e81ae9 | <ide><path>doc/guides/maintaining-npm.md
<ide> Note: please ensure you are only making the updates that are changed by npm.
<ide> $ git rebase --whitespace=fix master
<ide> ```
<ide>
<del>## Step 7: Test the build
<add>## Step 7: Apply signed term-size commit
<add>
<add>The `term-size` package in npm's dependency tree contains an unsigned macOS
<add>binary in versions < 2.2.0. Until npm updates to a newer version of
<add>`update-notifier`, Node.js macOS package files can't be notarized and will fail
<add>to install on macOS Catalina and above.
<add>
<add>When `npm ls` shows a `term-size` package version < 2.2.0, cherry-pick
<add>commit `d2f08a1bdb` on top of the upgraded npm.
<add>
<add>```console
<add>$ git cherry-pick d2f08a1bdb
<add>```
<add>
<add>When `npm ls` shows a `term-size` package version >= 2.2.0, edit this file to
<add>remove this step.
<add>
<add>## Step 8: Test the build
<ide>
<ide> ```console
<ide> $ make test-npm | 1 |
Mixed | Javascript | revise http documentation | 52c7f9d22115a3ab7174654cc61c9e34335246e2 | <ide><path>doc/api/http.md
<ide> The HTTP Agent is used for pooling sockets used in HTTP client
<ide> requests.
<ide>
<ide> The HTTP Agent also defaults client requests to using
<del>Connection:keep-alive. If no pending HTTP requests are waiting on a
<add>`Connection: keep-alive`. If no pending HTTP requests are waiting on a
<ide> socket to become free the socket is closed. This means that Node.js's
<ide> pool has the benefit of keep-alive when under load but still does not
<ide> require developers to manually close the HTTP clients using
<ide> http.request(options, onResponseCallback);
<ide> added: v0.11.4
<ide> -->
<ide>
<add>* `options` {Object} Options containing connection details. Check
<add> [`net.createConnection()`][] for the format of the options
<add>* `callback` {Function} Callback function that receives the created socket
<add>* Returns: {net.Socket}
<add>
<ide> Produces a socket/stream to be used for HTTP requests.
<ide>
<ide> By default, this function is the same as [`net.createConnection()`][]. However,
<ide> terminates them.
<ide> added: v0.11.4
<ide> -->
<ide>
<add>* {Object}
<add>
<ide> An object which contains arrays of sockets currently awaiting use by
<ide> the Agent when HTTP KeepAlive is used. Do not modify.
<ide>
<ide> the Agent when HTTP KeepAlive is used. Do not modify.
<ide> added: v0.11.4
<ide> -->
<ide>
<add>* `options` {Object} A set of options providing information for name generation
<add> * `host` {String} A domain name or IP address of the server to issue the request to
<add> * `port` {Number} Port of remote server
<add> * `localAddress` {String} Local interface to bind for network connections
<add> when issuing the request
<add>* Returns: {String}
<add>
<ide> Get a unique name for a set of request options, to determine whether a
<ide> connection can be reused. In the http agent, this returns
<ide> `host:port:localAddress`. In the https agent, the name includes the
<ide> CA, cert, ciphers, and other HTTPS/TLS-specific options that determine
<ide> socket reusability.
<ide>
<del>Options:
<del>
<del>- `host`: A domain name or IP address of the server to issue the request to.
<del>- `port`: Port of remote server.
<del>- `localAddress`: Local interface to bind for network connections when issuing
<del> the request.
<del>
<ide> ### agent.maxFreeSockets
<ide> <!-- YAML
<ide> added: v0.11.7
<ide> -->
<ide>
<add>* {Number}
<add>
<ide> By default set to 256. For Agents supporting HTTP KeepAlive, this
<ide> sets the maximum number of sockets that will be left open in the free
<ide> state.
<ide> state.
<ide> added: v0.3.6
<ide> -->
<ide>
<add>* {Number}
<add>
<ide> By default set to Infinity. Determines how many concurrent sockets the agent
<ide> can have open per origin. Origin is either a 'host:port' or
<ide> 'host:port:localAddress' combination.
<ide> can have open per origin. Origin is either a 'host:port' or
<ide> added: v0.5.9
<ide> -->
<ide>
<add>* {Object}
<add>
<ide> An object which contains queues of requests that have not yet been assigned to
<ide> sockets. Do not modify.
<ide>
<ide> sockets. Do not modify.
<ide> added: v0.3.6
<ide> -->
<ide>
<add>* {Object}
<add>
<ide> An object which contains arrays of sockets currently in use by the
<ide> Agent. Do not modify.
<ide>
<ide> The request implements the [Writable Stream][] interface. This is an
<ide> added: v1.4.1
<ide> -->
<ide>
<del>`function () { }`
<del>
<ide> Emitted when the request has been aborted by the client. This event is only
<ide> emitted on the first call to `abort()`.
<ide>
<ide> emitted on the first call to `abort()`.
<ide> added: v0.3.8
<ide> -->
<ide>
<del>`function () { }`
<del>
<ide> Emitted when the request has been aborted by the server and the network
<ide> socket has closed.
<ide>
<del>### Event: 'checkExpectation'
<del><!-- YAML
<del>added: v5.5.0
<del>-->
<del>
<del>`function (request, response) { }`
<del>
<del>Emitted each time a request with an http Expect header is received, where the
<del>value is not 100-continue. If this event isn't listened for, the server will
<del>automatically respond with a 417 Expectation Failed as appropriate.
<del>
<del>Note that when this event is emitted and handled, the `request` event will
<del>not be emitted.
<del>
<ide> ### Event: 'connect'
<ide> <!-- YAML
<ide> added: v0.7.0
<ide> -->
<ide>
<del>`function (response, socket, head) { }`
<add>* `response` {http.IncomingMessage}
<add>* `socket` {net.Socket}
<add>* `head` {Buffer}
<ide>
<ide> Emitted each time a server responds to a request with a `CONNECT` method. If this
<ide> event isn't being listened for, clients receiving a `CONNECT` method will have
<ide> proxy.listen(1337, '127.0.0.1', () => {
<ide> added: v0.3.2
<ide> -->
<ide>
<del>`function () { }`
<del>
<ide> Emitted when the server sends a '100 Continue' HTTP response, usually because
<ide> the request contained 'Expect: 100-continue'. This is an instruction that
<ide> the client should send the request body.
<ide> the client should send the request body.
<ide> added: v0.1.0
<ide> -->
<ide>
<del>`function (response) { }`
<add>* `response` {http.IncomingMessage}
<ide>
<ide> Emitted when a response is received to this request. This event is emitted only
<del>once. The `response` argument will be an instance of [`http.IncomingMessage`][].
<add>once.
<ide>
<ide> ### Event: 'socket'
<ide> <!-- YAML
<ide> added: v0.5.3
<ide> -->
<ide>
<del>`function (socket) { }`
<add>* `socket` {net.Socket}
<ide>
<ide> Emitted after a socket is assigned to this request.
<ide>
<ide> Emitted after a socket is assigned to this request.
<ide> added: v0.1.94
<ide> -->
<ide>
<del>`function (response, socket, head) { }`
<add>* `response` {http.IncomingMessage}
<add>* `socket` {net.Socket}
<add>* `head` {Buffer}
<ide>
<ide> Emitted each time a server responds to a request with an upgrade. If this
<ide> event isn't being listened for, clients receiving an upgrade header will have
<ide> in the response to be dropped and the socket to be destroyed.
<ide> added: v0.1.90
<ide> -->
<ide>
<add>* `data` {String | Buffer}
<add>* `encoding` {String}
<add>* `callback` {Function}
<add>
<ide> Finishes sending the request. If any parts of the body are
<ide> unsent, it will flush them to the stream. If the request is
<ide> chunked, this will send the terminating `'0\r\n\r\n'`.
<ide> the optimization and kickstart the request.
<ide> added: v0.5.9
<ide> -->
<ide>
<add>* `noDelay` {Boolean}
<add>
<ide> Once a socket is assigned to this request and is connected
<ide> [`socket.setNoDelay()`][] will be called.
<ide>
<ide> Once a socket is assigned to this request and is connected
<ide> added: v0.5.9
<ide> -->
<ide>
<add>* `enable` {Boolean}
<add>* `initialDelay` {Number}
<add>
<ide> Once a socket is assigned to this request and is connected
<ide> [`socket.setKeepAlive()`][] will be called.
<ide>
<ide> Once a socket is assigned to this request and is connected
<ide> added: v0.5.9
<ide> -->
<ide>
<del>Once a socket is assigned to this request and is connected
<del>[`socket.setTimeout()`][] will be called.
<del>
<ide> * `timeout` {Number} Milliseconds before a request is considered to be timed out.
<ide> * `callback` {Function} Optional function to be called when a timeout occurs. Same as binding to the `timeout` event.
<ide>
<add>Once a socket is assigned to this request and is connected
<add>[`socket.setTimeout()`][] will be called.
<add>
<ide> Returns `request`.
<ide>
<ide> ### request.write(chunk[, encoding][, callback])
<ide> <!-- YAML
<ide> added: v0.1.29
<ide> -->
<ide>
<add>* `chunk` {String | Buffer}
<add>* `encoding` {String}
<add>* `callback` {Function}
<add>
<ide> Sends a chunk of the body. By calling this method
<ide> many times, the user can stream a request body to a
<ide> server--in that case it is suggested to use the
<ide> `['Transfer-Encoding', 'chunked']` header line when
<ide> creating the request.
<ide>
<del>The `chunk` argument should be a [`Buffer`][] or a string.
<del>
<ide> The `encoding` argument is optional and only applies when `chunk` is a string.
<ide> Defaults to `'utf8'`.
<ide>
<ide> This class inherits from [`net.Server`][] and has the following additional even
<ide> added: v0.3.0
<ide> -->
<ide>
<del>`function (request, response) { }`
<add>* `request` {http.IncomingMessage}
<add>* `response` {http.ServerResponse}
<ide>
<del>Emitted each time a request with an http Expect: 100-continue is received.
<add>Emitted each time a request with an HTTP `Expect: 100-continue` is received.
<ide> If this event isn't listened for, the server will automatically respond
<del>with a 100 Continue as appropriate.
<add>with a `100 Continue` as appropriate.
<ide>
<ide> Handling this event involves calling [`response.writeContinue()`][] if the client
<ide> should continue to send the request body, or generating an appropriate HTTP
<ide> response (e.g., 400 Bad Request) if the client should not continue to send the
<ide> request body.
<ide>
<del>Note that when this event is emitted and handled, the `'request'` event will
<add>Note that when this event is emitted and handled, the [`'request'`][] event will
<add>not be emitted.
<add>
<add>### Event: 'checkExpectation'
<add><!-- YAML
<add>added: v5.5.0
<add>-->
<add>
<add>* `request` {http.ClientRequest}
<add>* `response` {http.ServerResponse}
<add>
<add>Emitted each time a request with an HTTP `Expect` header is received, where the
<add>value is not `100-continue`. If this event isn't listened for, the server will
<add>automatically respond with a `417 Expectation Failed` as appropriate.
<add>
<add>Note that when this event is emitted and handled, the [`'request'`][] event will
<ide> not be emitted.
<ide>
<ide> ### Event: 'clientError'
<ide> <!-- YAML
<ide> added: v0.1.94
<ide> -->
<ide>
<del>`function (exception, socket) { }`
<add>* `exception` {Error}
<add>* `socket` {net.Socket}
<ide>
<ide> If a client connection emits an `'error'` event, it will be forwarded here.
<ide> Listener of this event is responsible for closing/destroying the underlying
<ide> ensure the response is a properly formatted HTTP response message.
<ide> added: v0.1.4
<ide> -->
<ide>
<del>`function () { }`
<del>
<ide> Emitted when the server closes.
<ide>
<ide> ### Event: 'connect'
<ide> <!-- YAML
<ide> added: v0.7.0
<ide> -->
<ide>
<del>`function (request, socket, head) { }`
<add>* `request` {http.IncomingMessage} Arguments for the HTTP request, as it is in
<add> the [`'request'`][] event
<add>* `socket` {net.Socket} Network socket between the server and client
<add>* `head` {Buffer} The first packet of the tunneling stream (may be empty)
<ide>
<del>Emitted each time a client requests a http `CONNECT` method. If this event isn't
<add>Emitted each time a client requests an HTTP `CONNECT` method. If this event isn't
<ide> listened for, then clients requesting a `CONNECT` method will have their
<ide> connections closed.
<ide>
<del>* `request` is the arguments for the http request, as it is in the request
<del> event.
<del>* `socket` is the network socket between the server and client.
<del>* `head` is an instance of Buffer, the first packet of the tunneling stream,
<del> this may be empty.
<del>
<ide> After this event is emitted, the request's socket will not have a `'data'`
<ide> event listener, meaning you will need to bind to it in order to handle data
<ide> sent to the server on that socket.
<ide> sent to the server on that socket.
<ide> added: v0.1.0
<ide> -->
<ide>
<del>`function (socket) { }`
<add>* `socket` {net.Socket}
<ide>
<ide> When a new TCP stream is established. `socket` is an object of type
<ide> [`net.Socket`][]. Usually users will not want to access this event. In
<ide> accessed at `request.connection`.
<ide> added: v0.1.0
<ide> -->
<ide>
<del>`function (request, response) { }`
<add>* `request` {http.IncomingMessage}
<add>* `response` {http.ServerResponse}
<ide>
<ide> Emitted each time there is a request. Note that there may be multiple requests
<ide> per connection (in the case of keep-alive connections).
<del> `request` is an instance of [`http.IncomingMessage`][] and `response` is
<del>an instance of [`http.ServerResponse`][].
<ide>
<ide> ### Event: 'upgrade'
<ide> <!-- YAML
<ide> added: v0.1.94
<ide> -->
<ide>
<del>`function (request, socket, head) { }`
<add>* `request` {http.IncomingMessage} Arguments for the HTTP request, as it is in
<add> the [`'request'`][] event
<add>* `socket` {net.Socket} Network socket between the server and client
<add>* `head` {Buffer} The first packet of the upgraded stream (may be empty)
<ide>
<del>Emitted each time a client requests a http upgrade. If this event isn't
<add>Emitted each time a client requests an HTTP upgrade. If this event isn't
<ide> listened for, then clients requesting an upgrade will have their connections
<ide> closed.
<ide>
<del>* `request` is the arguments for the http request, as it is in the request
<del> event.
<del>* `socket` is the network socket between the server and client.
<del>* `head` is an instance of Buffer, the first packet of the upgraded stream,
<del> this may be empty.
<del>
<ide> After this event is emitted, the request's socket will not have a `'data'`
<ide> event listener, meaning you will need to bind to it in order to handle data
<ide> sent to the server on that socket.
<ide> sent to the server on that socket.
<ide> added: v0.1.90
<ide> -->
<ide>
<add>* `callback` {Function}
<add>
<ide> Stops the server from accepting new connections. See [`net.Server.close()`][].
<ide>
<ide> ### server.listen(handle[, callback])
<ide> subsequent call will *re-open* the server using the provided options.
<ide> added: v0.1.90
<ide> -->
<ide>
<add>* `path` {String}
<add>* `callback` {Function}
<add>
<ide> Start a UNIX socket server listening for connections on the given `path`.
<ide>
<ide> This function is asynchronous. `callback` will be added as a listener for the
<ide> subsequent call will *re-open* the server using the provided options.
<ide> added: v0.1.90
<ide> -->
<ide>
<add>* `port` {Number}
<add>* `hostname` {String}
<add>* `backlog` {Number}
<add>* `callback` {Function}
<add>
<ide> Begin accepting connections on the specified `port` and `hostname`. If the
<ide> `hostname` is omitted, the server will accept connections on any IPv6 address
<ide> (`::`) when IPv6 is available, or any IPv4 address (`0.0.0.0`) otherwise.
<ide> after the `'listening'` event has been emitted.
<ide>
<ide> To listen to a unix socket, supply a filename instead of port and hostname.
<ide>
<del>Backlog is the maximum length of the queue of pending connections.
<add>`backlog` is the maximum length of the queue of pending connections.
<ide> The actual length will be determined by your OS through sysctl settings such as
<ide> `tcp_max_syn_backlog` and `somaxconn` on linux. The default value of this
<ide> parameter is 511 (not 512).
<ide> subsequent call will *re-open* the server using the provided options.
<ide> added: v5.7.0
<ide> -->
<ide>
<add>* {Boolean}
<add>
<ide> A Boolean indicating whether or not the server is listening for
<ide> connections.
<ide>
<ide> connections.
<ide> added: v0.7.0
<ide> -->
<ide>
<add>* {Number}
<add>
<ide> Limits maximum incoming headers count, equal to 1000 by default. If set to 0 -
<ide> no limit will be applied.
<ide>
<ide> connections.
<ide> added: v0.1.17
<ide> -->
<ide>
<del>This object is created internally by a HTTP server--not by the user. It is
<del>passed as the second parameter to the `'request'` event.
<add>This object is created internally by an HTTP server--not by the user. It is
<add>passed as the second parameter to the [`'request'`][] event.
<ide>
<ide> The response implements, but does not inherit from, the [Writable Stream][]
<ide> interface. This is an [`EventEmitter`][] with the following events:
<ide> interface. This is an [`EventEmitter`][] with the following events:
<ide> added: v0.6.7
<ide> -->
<ide>
<del>`function () { }`
<del>
<ide> Indicates that the underlying connection was terminated before
<ide> [`response.end()`][] was called or able to flush.
<ide>
<ide> Indicates that the underlying connection was terminated before
<ide> added: v0.3.6
<ide> -->
<ide>
<del>`function () { }`
<del>
<ide> Emitted when the response has been sent. More specifically, this event is
<ide> emitted when the last segment of the response headers and body have been
<ide> handed off to the operating system for transmission over the network. It
<ide> After this event, no more events will be emitted on the response object.
<ide> added: v0.3.0
<ide> -->
<ide>
<add>* `headers` {Object}
<add>
<ide> This method adds HTTP trailing headers (a header but at the end of the
<ide> message) to the response.
<ide>
<ide> will result in a [`TypeError`][] being thrown.
<ide> added: v0.1.90
<ide> -->
<ide>
<add>* `data` {String | Buffer}
<add>* `encoding` {String}
<add>* `callback` {Function}
<add>
<ide> This method signals to the server that all of the response headers and body
<ide> have been sent; that server should consider this message complete.
<ide> The method, `response.end()`, MUST be called on each response.
<ide> is finished.
<ide> added: v0.0.2
<ide> -->
<ide>
<add>* {Boolean}
<add>
<ide> Boolean value that indicates whether the response has completed. Starts
<ide> as `false`. After [`response.end()`][] executes, the value will be `true`.
<ide>
<ide> as `false`. After [`response.end()`][] executes, the value will be `true`.
<ide> added: v0.4.0
<ide> -->
<ide>
<add>* `name` {String}
<add>* Returns: {String}
<add>
<ide> Reads out a header that's already been queued but not sent to the client. Note
<ide> that the name is case insensitive. This can only be called before headers get
<ide> implicitly flushed.
<ide> var contentType = response.getHeader('content-type');
<ide> added: v0.9.3
<ide> -->
<ide>
<add>* {Boolean}
<add>
<ide> Boolean (read-only). True if headers were sent, false otherwise.
<ide>
<ide> ### response.removeHeader(name)
<ide> <!-- YAML
<ide> added: v0.4.0
<ide> -->
<ide>
<add>* `name` {String}
<add>
<ide> Removes a header that's queued for implicit sending.
<ide>
<ide> Example:
<ide> response.removeHeader('Content-Encoding');
<ide> added: v0.7.5
<ide> -->
<ide>
<add>* {Boolean}
<add>
<ide> When true, the Date header will be automatically generated and sent in
<ide> the response if it is not already present in the headers. Defaults to true.
<ide>
<ide> in responses.
<ide> added: v0.4.0
<ide> -->
<ide>
<add>* `name` {String}
<add>* `value` {String}
<add>
<ide> Sets a single header value for implicit headers. If this header already exists
<ide> in the to-be-sent headers, its value will be replaced. Use an array of strings
<ide> here if you need to send multiple headers with the same name.
<ide> Returns `response`.
<ide> added: v0.4.0
<ide> -->
<ide>
<add>* {Number}
<add>
<ide> When using implicit headers (not calling [`response.writeHead()`][] explicitly),
<ide> this property controls the status code that will be sent to the client when
<ide> the headers get flushed.
<ide> status code which was sent out.
<ide> added: v0.11.8
<ide> -->
<ide>
<add>* {String}
<add>
<ide> When using implicit headers (not calling [`response.writeHead()`][] explicitly), this property
<ide> controls the status message that will be sent to the client when the headers get
<ide> flushed. If this is left as `undefined` then the standard message for the status
<ide> status message which was sent out.
<ide> added: v0.1.29
<ide> -->
<ide>
<add>* `chunk` {String | Buffer}
<add>* `encoding` {String}
<add>* `callback` {Function}
<add>* Returns: {Boolean}
<add>
<ide> If this method is called and [`response.writeHead()`][] has not been called,
<ide> it will switch to implicit header mode and flush the implicit headers.
<ide>
<ide> the request body should be sent. See the [`'checkContinue'`][] event on `Server`
<ide> added: v0.1.30
<ide> -->
<ide>
<add>* `statusCode` {Number}
<add>* `statusMessage` {String}
<add>* `headers` {Object}
<add>
<ide> Sends a response header to the request. The status code is a 3-digit HTTP
<ide> status code, like `404`. The last argument, `headers`, are the response headers.
<ide> Optionally one can give a human-readable `statusMessage` as the second
<ide> added: v0.1.17
<ide> -->
<ide>
<ide> An `IncomingMessage` object is created by [`http.Server`][] or
<del>[`http.ClientRequest`][] and passed as the first argument to the `'request'`
<add>[`http.ClientRequest`][] and passed as the first argument to the [`'request'`][]
<ide> and [`'response'`][] event respectively. It may be used to access response status,
<ide> headers and data.
<ide>
<ide> following additional events, methods, and properties.
<ide> added: v0.3.8
<ide> -->
<ide>
<del>`function () { }`
<del>
<ide> Emitted when the request has been aborted by the client and the network
<ide> socket has closed.
<ide>
<ide> socket has closed.
<ide> added: v0.4.2
<ide> -->
<ide>
<del>`function () { }`
<del>
<ide> Indicates that the underlying connection was closed.
<ide> Just like `'end'`, this event occurs only once per response.
<ide>
<ide> to any listeners on the event.
<ide> added: v0.1.5
<ide> -->
<ide>
<add>* {Object}
<add>
<ide> The request/response headers object.
<ide>
<ide> Key-value pairs of header names and values. Header names are lower-cased.
<ide> header name:
<ide> added: v0.1.1
<ide> -->
<ide>
<add>* {String}
<add>
<ide> In case of server request, the HTTP version sent by the client. In the case of
<ide> client response, the HTTP version of the connected-to server.
<ide> Probably either `'1.1'` or `'1.0'`.
<ide> Also `message.httpVersionMajor` is the first integer and
<ide> added: v0.1.1
<ide> -->
<ide>
<add>* {String}
<add>
<ide> **Only valid for request obtained from [`http.Server`][].**
<ide>
<ide> The request method as a string. Read only. Example:
<ide> The request method as a string. Read only. Example:
<ide> added: v0.11.6
<ide> -->
<ide>
<add>* {Array}
<add>
<ide> The raw request/response headers list exactly as they were received.
<ide>
<ide> Note that the keys and values are in the same list. It is *not* a
<ide> console.log(request.rawHeaders);
<ide> added: v0.11.6
<ide> -->
<ide>
<add>* {Array}
<add>
<ide> The raw request/response trailer keys and values exactly as they were
<ide> received. Only populated at the `'end'` event.
<ide>
<ide> Returns `message`.
<ide> added: v0.1.1
<ide> -->
<ide>
<add>* {Number}
<add>
<ide> **Only valid for response obtained from [`http.ClientRequest`][].**
<ide>
<ide> The 3-digit HTTP response status code. E.G. `404`.
<ide> The 3-digit HTTP response status code. E.G. `404`.
<ide> added: v0.11.10
<ide> -->
<ide>
<add>* {String}
<add>
<ide> **Only valid for response obtained from [`http.ClientRequest`][].**
<ide>
<ide> The HTTP response status message (reason phrase). E.G. `OK` or `Internal Server Error`.
<ide> The HTTP response status message (reason phrase). E.G. `OK` or `Internal Server
<ide> added: v0.3.0
<ide> -->
<ide>
<add>* {net.Socket}
<add>
<ide> The [`net.Socket`][] object associated with the connection.
<ide>
<ide> With HTTPS support, use [`request.socket.getPeerCertificate()`][] to obtain the
<ide> client's authentication details.
<ide> added: v0.3.0
<ide> -->
<ide>
<add>* {Object}
<add>
<ide> The request/response trailers object. Only populated at the `'end'` event.
<ide>
<ide> ### message.url
<ide> <!-- YAML
<ide> added: v0.1.90
<ide> -->
<ide>
<add>* {String}
<add>
<ide> **Only valid for request obtained from [`http.Server`][].**
<ide>
<ide> Request URL string. This contains only the URL that is
<ide> Found'`.
<ide> added: v0.1.13
<ide> -->
<ide>
<add>* Returns: {http.Server}
<add>
<ide> Returns a new instance of [`http.Server`][].
<ide>
<ide> The `requestListener` is a function which is automatically
<del>added to the `'request'` event.
<add>added to the [`'request'`][] event.
<ide>
<ide> ## http.get(options[, callback])
<ide> <!-- YAML
<ide> added: v0.3.6
<ide> -->
<ide>
<add>* `options` {Object}
<add>* `callback` {Function}
<add>* Returns: {http.ClientRequest}
<add>
<ide> Since most requests are GET requests without bodies, Node.js provides this
<ide> convenience method. The only difference between this method and [`http.request()`][]
<ide> is that it sets the method to GET and calls `req.end()` automatically.
<ide> http.get('http://www.google.com/index.html', (res) => {
<ide> added: v0.5.9
<ide> -->
<ide>
<del>Global instance of Agent which is used as the default for all http client
<add>* {http.Agent}
<add>
<add>Global instance of Agent which is used as the default for all HTTP client
<ide> requests.
<ide>
<ide> ## http.request(options[, callback])
<ide> <!-- YAML
<ide> added: v0.3.6
<ide> -->
<ide>
<add>* `options` {Object}
<add> * `protocol` {String} Protocol to use. Defaults to `'http:'`.
<add> * `host` {String} A domain name or IP address of the server to issue the request to.
<add> Defaults to `'localhost'`.
<add> * `hostname` {String} Alias for `host`. To support [`url.parse()`][] `hostname` is
<add> preferred over `host`.
<add> * `family` {Number} IP address family to use when resolving `host` and `hostname`.
<add> Valid values are `4` or `6`. When unspecified, both IP v4 and v6 will be
<add> used.
<add> * `port` {Number} Port of remote server. Defaults to 80.
<add> * `localAddress` {String} Local interface to bind for network connections.
<add> * `socketPath` {String} Unix Domain Socket (use one of host:port or socketPath).
<add> * `method` {String} A string specifying the HTTP request method. Defaults to `'GET'`.
<add> * `path` {String} Request path. Defaults to `'/'`. Should include query string if any.
<add> E.G. `'/index.html?page=12'`. An exception is thrown when the request path
<add> contains illegal characters. Currently, only spaces are rejected but that
<add> may change in the future.
<add> * `headers` {Object} An object containing request headers.
<add> * `auth` {String} Basic authentication i.e. `'user:password'` to compute an
<add> Authorization header.
<add> * `agent` {String} Controls [`Agent`][] behavior. When an Agent is used request will
<add> default to `Connection: keep-alive`. Possible values:
<add> * `undefined` (default): use [`http.globalAgent`][] for this host and port.
<add> * `Agent` object: explicitly use the passed in `Agent`.
<add> * `false`: opts out of connection pooling with an Agent, defaults request to
<add> `Connection: close`.
<add> * `createConnection` {Function} A function that produces a socket/stream to use for the
<add> request when the `agent` option is not used. This can be used to avoid
<add> creating a custom Agent class just to override the default `createConnection`
<add> function. See [`agent.createConnection()`][] for more details.
<add> * `timeout` {Integer}: A number specifying the socket timeout in milliseconds.
<add> This will set the timeout before the socket is connected.
<add>* `callback` {Function}
<add>* Returns: {http.ClientRequest}
<add>
<ide> Node.js maintains several connections per server to make HTTP requests.
<ide> This function allows one to transparently issue requests.
<ide>
<ide> `options` can be an object or a string. If `options` is a string, it is
<ide> automatically parsed with [`url.parse()`][].
<ide>
<del>Options:
<del>
<del>- `protocol`: Protocol to use. Defaults to `'http:'`.
<del>- `host`: A domain name or IP address of the server to issue the request to.
<del> Defaults to `'localhost'`.
<del>- `hostname`: Alias for `host`. To support [`url.parse()`][] `hostname` is
<del> preferred over `host`.
<del>- `family`: IP address family to use when resolving `host` and `hostname`.
<del> Valid values are `4` or `6`. When unspecified, both IP v4 and v6 will be
<del> used.
<del>- `port`: Port of remote server. Defaults to 80.
<del>- `localAddress`: Local interface to bind for network connections.
<del>- `socketPath`: Unix Domain Socket (use one of host:port or socketPath).
<del>- `method`: A string specifying the HTTP request method. Defaults to `'GET'`.
<del>- `path`: Request path. Defaults to `'/'`. Should include query string if any.
<del> E.G. `'/index.html?page=12'`. An exception is thrown when the request path
<del> contains illegal characters. Currently, only spaces are rejected but that
<del> may change in the future.
<del>- `headers`: An object containing request headers.
<del>- `auth`: Basic authentication i.e. `'user:password'` to compute an
<del> Authorization header.
<del>- `agent`: Controls [`Agent`][] behavior. When an Agent is used request will
<del> default to `Connection: keep-alive`. Possible values:
<del> - `undefined` (default): use [`http.globalAgent`][] for this host and port.
<del> - `Agent` object: explicitly use the passed in `Agent`.
<del> - `false`: opts out of connection pooling with an Agent, defaults request to
<del> `Connection: close`.
<del>- `createConnection`: A function that produces a socket/stream to use for the
<del> request when the `agent` option is not used. This can be used to avoid
<del> creating a custom Agent class just to override the default `createConnection`
<del> function. See [`agent.createConnection()`][] for more details.
<del>- `timeout`: A number specifying the socket timeout in milliseconds.
<del> This will set the timeout before the socket is connected.
<del>
<ide> The optional `callback` parameter will be added as a one time listener for
<ide> the [`'response'`][] event.
<ide>
<ide> There are a few special headers that should be noted.
<ide>
<ide> [`'checkContinue'`]: #http_event_checkcontinue
<ide> [`'listening'`]: net.html#net_event_listening
<add>[`'request'`]: #http_event_request
<ide> [`'response'`]: #http_event_response
<ide> [`Agent`]: #http_class_http_agent
<ide> [`agent.createConnection()`]: #http_agent_createconnection_options_callback
<del>[`Buffer`]: buffer.html#buffer_buffer
<ide> [`destroy()`]: #http_agent_destroy
<ide> [`EventEmitter`]: events.html#events_class_eventemitter
<ide> [`http.Agent`]: #http_class_http_agent
<ide> There are a few special headers that should be noted.
<ide> [`http.IncomingMessage`]: #http_class_http_incomingmessage
<ide> [`http.request()`]: #http_http_request_options_callback
<ide> [`http.Server`]: #http_class_http_server
<del>[`http.ServerResponse`]: #http_class_http_serverresponse
<ide> [`message.headers`]: #http_message_headers
<ide> [`net.createConnection()`]: net.html#net_net_createconnection_options_connectlistener
<ide> [`net.Server`]: net.html#net_class_net_server
<ide><path>tools/doc/type-parser.js
<ide> const typeMap = {
<ide> 'net.Socket': 'net.html#net_class_net_socket',
<ide> 'tls.TLSSocket': 'tls.html#tls_class_tls_tlssocket',
<ide> 'EventEmitter': 'events.html#events_class_eventemitter',
<del> 'Timer': 'timers.html#timers_timers'
<add> 'Timer': 'timers.html#timers_timers',
<add> 'http.Agent': 'http.html#http_class_http_agent',
<add> 'http.ClientRequest': 'http.html#http_class_http_clientrequest',
<add> 'http.IncomingMessage': 'http.html#http_class_http_incomingmessage',
<add> 'http.Server': 'http.html#http_class_http_server',
<add> 'http.ServerResponse': 'http.html#http_class_http_serverresponse',
<ide> };
<ide>
<ide> module.exports = { | 2 |
Text | Text | update main branch name in doc/contributing/* | 7bf50bc26aa01308d06ffd6bd75864c29486fa0b | <ide><path>doc/contributing/backporting-to-release-lines.md
<ide> For the active staging branches see the [Release Schedule][].
<ide>
<ide> ## What needs to be backported?
<ide>
<del>If a cherry-pick from master does not land cleanly on a staging branch, the
<add>If a cherry-pick from `main` does not land cleanly on a staging branch, the
<ide> releaser will mark the pull request with a particular label for that release
<ide> line (e.g. `backport-requested-vN.x`), specifying to our tooling that this
<ide> pull request should not be included. The releaser will then add a comment
<ide><path>doc/contributing/collaborator-guide.md
<ide> in the form:
<ide>
<ide> * `GIT_REMOTE_REF`: Change to the remote portion of git refspec.
<ide> To specify the branch this way, `refs/heads/BRANCH` is used
<del> (e.g. for `master` -> `refs/heads/master`).
<add> (e.g. for `main` -> `refs/heads/main`).
<ide> For pull requests, it will look like `refs/pull/PR_NUMBER/head`
<ide> (e.g. for pull request #42 -> `refs/pull/42/head`).
<del>* `REBASE_ONTO`: Change that to `origin/master` so the pull request gets rebased
<del> onto master. This can especially be important for pull requests that have been
<add>* `REBASE_ONTO`: Change that to `origin/main` so the pull request gets rebased
<add> onto `main`. This can especially be important for pull requests that have been
<ide> open a while.
<ide>
<ide> Look at the list of jobs on the left hand side under "Build History" and copy
<ide> For undocumented APIs that are public, open a pull request documenting the API.
<ide> ### Breaking changes
<ide>
<ide> At least two TSC members must approve backward-incompatible changes to the
<del>master branch.
<add>`main` branch.
<ide>
<ide> Examples of breaking changes include:
<ide>
<ide> providing a Public API in such cases.
<ide> #### Unintended breaking changes
<ide>
<ide> Sometimes, a change intended to be non-breaking turns out to be a breaking
<del>change. If such a change lands on the master branch, a collaborator can revert
<add>change. If such a change lands on the `main` branch, a collaborator can revert
<ide> it. As an alternative to reverting, the TSC can apply the semver-major label
<ide> after-the-fact.
<ide>
<ide> duration.
<ide>
<ide> Communicate pending deprecations and associated mitigations with the ecosystem
<ide> as soon as possible. If possible, do it before the pull request adding the
<del>deprecation lands on the master branch.
<add>deprecation lands on the `main` branch.
<ide>
<ide> Use the `notable-change` label on pull requests that add or change the
<ide> deprecation level of an API.
<ide> $ git rebase --abort
<ide> Checkout proper target branch:
<ide>
<ide> ```text
<del>$ git checkout master
<add>$ git checkout main
<ide> ```
<ide>
<ide> Update the tree (assumes your repository is set up as detailed in
<ide> [CONTRIBUTING.md](./pull-requests.md#step-1-fork)):
<ide>
<ide> ```text
<ide> $ git fetch upstream
<del>$ git merge --ff-only upstream/master
<add>$ git merge --ff-only upstream/main
<ide> ```
<ide>
<ide> Apply external patches:
<ide> has landed since the CI run. You will have to ask the author to rebase.
<ide> Check and re-review the changes:
<ide>
<ide> ```text
<del>$ git diff upstream/master
<add>$ git diff upstream/main
<ide> ```
<ide>
<ide> Check the number of commits and commit messages:
<ide>
<ide> ```text
<del>$ git log upstream/master...master
<add>$ git log upstream/main...main
<ide> ```
<ide>
<ide> Squash commits and add metadata:
<ide>
<ide> ```text
<del>$ git rebase -i upstream/master
<add>$ git rebase -i upstream/main
<ide> ```
<ide>
<ide> This will open a screen like this (in the default shell editor):
<ide> for that commit. This is an opportunity to fix commit messages.
<ide> pull request.
<ide> * Protects against the assumption that GitHub will be around forever.
<ide>
<del>Other changes might have landed on master since the successful CI run. As a
<add>Other changes might have landed on `main` since the successful CI run. As a
<ide> precaution, run tests (`make -j4 test` or `vcbuild test`).
<ide>
<ide> Confirm that the commit message format is correct using
<ide> [core-validate-commit](https://github.com/nodejs/core-validate-commit).
<ide>
<ide> ```text
<del>$ git rev-list upstream/master...HEAD | xargs core-validate-commit
<add>$ git rev-list upstream/main...HEAD | xargs core-validate-commit
<ide> ```
<ide>
<ide> Optional: For your own commits, force push the amended commit to the pull
<ide> request branch. If your branch name is `bugfix`, then:
<del>`git push --force-with-lease origin master:bugfix`. Don't close the pull
<add>`git push --force-with-lease origin main:bugfix`. Don't close the pull
<ide> request. It will close after you push it upstream. It will have the purple
<ide> merged status rather than the red closed status. If you close the pull request
<ide> before GitHub adjusts its status, it will show up as a 0 commit pull
<ide> the issue with the red closed status.
<ide> Time to push it:
<ide>
<ide> ```text
<del>$ git push upstream master
<add>$ git push upstream main
<ide> ```
<ide>
<ide> Close the pull request with a "Landed in `<commit hash>`" comment. Even if
<ide> more than one commit.
<ide>
<ide> ### Troubleshooting
<ide>
<del>Sometimes, when running `git push upstream master`, you might get an error
<add>Sometimes, when running `git push upstream main`, you might get an error
<ide> message like this:
<ide>
<ide> ```console
<ide> To https://github.com/nodejs/node
<del> ! [rejected] master -> master (fetch first)
<add> ! [rejected] main -> main (fetch first)
<ide> error: failed to push some refs to 'https://github.com/nodejs/node'
<ide> hint: Updates were rejected because the tip of your current branch is behind
<ide> hint: its remote counterpart. Integrate the remote changes (e.g.
<ide> hint: 'git pull ...') before pushing again.
<ide> hint: See the 'Note about fast-forwards' in 'git push --help' for details.
<ide> ```
<ide>
<del>That means a commit has landed since your last rebase against `upstream/master`.
<add>That means a commit has landed since your last rebase against `upstream/main`.
<ide> To fix this, pull with rebase from upstream, run the tests again, and (if the
<ide> tests pass) push again:
<ide>
<ide> ```bash
<del>git pull upstream master --rebase
<add>git pull upstream main --rebase
<ide> make -j4 test
<del>git push upstream master
<add>git push upstream main
<ide> ```
<ide>
<ide> ### I made a mistake
<ide> the branch.
<ide> Each LTS release has a corresponding branch (v10.x, v8.x, etc.). Each also has a
<ide> corresponding staging branch (v10.x-staging, v8.x-staging, etc.).
<ide>
<del>Commits that land on master are cherry-picked to each staging branch as
<add>Commits that land on `main` are cherry-picked to each staging branch as
<ide> appropriate. If a change applies only to the LTS branch, open the pull request
<ide> against the _staging_ branch. Commits from the staging branch land on the LTS
<ide> branch only when a release is being prepared. They might land on the LTS branch
<ide> We use labels to keep track of which branches a commit should land on:
<ide> * (for example semver-minor changes that need or should go into an LTS
<ide> release)
<ide> * `v?.x`
<del> * Automatically applied to changes that do not target `master` but rather the
<add> * Automatically applied to changes that do not target `main` but rather the
<ide> `v?.x-staging` branch
<ide>
<ide> Once a release line enters maintenance mode, the corresponding labels do not
<ide><path>doc/contributing/commit-queue.md
<ide> Commit Queue is an experimental feature for the project which simplifies the
<ide> landing process by automating it via GitHub Actions. With it, collaborators can
<ide> land pull requests by adding the `commit-queue` label to a PR. All
<ide> checks will run via node-core-utils, and if the pull request is ready to land,
<del>the Action will rebase it and push to master.
<add>the Action will rebase it and push to `main`.
<ide>
<ide> This document gives an overview of how the Commit Queue works, as well as
<ide> implementation details, reasoning for design choices, and current limitations.
<ide> forwarding stdout and stderr to a file. If any errors happen,
<ide> to the PR, as well as a comment with the output of `git node land`.
<ide>
<ide> If no errors happen during `git node land`, the script will use the
<del>`GITHUB_TOKEN` to push the changes to `master`, and then will leave a
<add>`GITHUB_TOKEN` to push the changes to `main`, and then will leave a
<ide> `Landed in ...` comment in the PR, and then will close it. Iteration continues
<ide> until all PRs have done the steps above.
<ide>
<ide><path>doc/contributing/diagnostic-tooling-support-tiers.md
<ide> the following tiers.
<ide> suite for the tool/API is not green. To be considered for inclusion
<ide> in this tier it must have a good test suite and that test suite and a job
<ide> must exist in the Node.js CI so that it can be run as part of the release
<del> process. Tests on master will be run nightly when possible to provide
<add> process. Tests on `main` will be run nightly when possible to provide
<ide> early warning of potential issues. No commit to the current and LTS
<ide> release branches should break this tool/API if the next major release
<ide> is within 1 month. In addition:
<ide><path>doc/contributing/maintaining-V8.md
<ide> The rough outline of the process is:
<ide>
<ide> ```bash
<ide> # Assuming your fork of Node.js is checked out in $NODE_DIR
<del># and you want to update the Node.js master branch.
<add># and you want to update the Node.js main branch.
<ide> # Find the current (OLD) version in
<ide> # $NODE_DIR/deps/v8/include/v8-version.h
<ide> cd $NODE_DIR
<del>git checkout master
<del>git merge --ff-only origin/master
<add>git checkout main
<add>git merge --ff-only origin/main
<ide> git checkout -b V8_NEW_VERSION
<ide> curl -L https://github.com/v8/v8/compare/${V8_OLD_VERSION}...${V8_NEW_VERSION}.patch | git apply --directory=deps/v8
<ide> # You may want to amend the commit message to describe the nature of the update
<ide> to apply a minor update.
<ide>
<ide> ### Major updates
<ide>
<del>We upgrade the version of V8 in Node.js master whenever a V8 release goes stable
<add>We upgrade the version of V8 in Node.js `main` whenever a V8 release goes stable
<ide> upstream, that is, whenever a new release of Chrome comes out.
<ide>
<ide> Upgrading major versions would be much harder to do with the patch mechanism
<ide> above. A better strategy is to
<ide>
<del>1. Audit the current master branch and look at the patches that have been
<add>1. Audit the current `main` branch and look at the patches that have been
<ide> floated since the last major V8 update.
<ide> 2. Replace the copy of V8 in Node.js with a fresh checkout of the latest stable
<ide> V8 branch. Special care must be taken to recursively update the DEPS that V8
<ide> branches. This has several benefits:
<ide> * The history of the V8 branch in `nodejs/v8` becomes purer and it would make it
<ide> easier to pull in the V8 team for help with reviewing.
<ide> * It would make it simpler to setup an automated build that tracks Node.js
<del> master + V8 lkgr integration build.
<add> `main` + V8 lkgr integration build.
<ide>
<ide> This would require some tooling to:
<ide>
<ide><path>doc/contributing/maintaining-cjs-module-lexer.md
<ide> implementation using WebAssembly which is generated from a
<ide> C based implementation. These two paths
<ide> resolve to the files in `deps/cjs-module-lexer` due to their
<ide> inclusion in the `deps_files` entry in
<del>[node.gyp](https://github.com/nodejs/node/blob/master/node.gyp).
<add>[node.gyp](https://github.com/nodejs/node/blob/main/node.gyp).
<ide>
<ide> The two different versions of lexer.js are maintained in the
<ide> [nodejs/cjs-module-lexer][] project.
<ide><path>doc/contributing/maintaining-npm.md
<ide> Note: please ensure you are only making the updates that are changed by npm.
<ide> ## Step 4: Apply whitespace fix
<ide>
<ide> ```console
<del>$ git rebase --whitespace=fix master
<add>$ git rebase --whitespace=fix main
<ide> ```
<ide>
<ide> ## Step 5: Test the build
<ide><path>doc/contributing/maintaining-openssl.md
<ide> This document describes how to update `deps/openssl/`.
<ide> If you need to provide updates across all active release lines you will
<ide> currently need to generate four PRs as follows:
<ide>
<del>* a PR for master which is generated following the instructions
<add>* a PR for `main` which is generated following the instructions
<ide> below for OpenSSL 3.x.x.
<ide> * a PR for 16.x following the instructions in the v16.x-staging version
<ide> of this guide.
<ide><path>doc/contributing/maintaining-web-assembly.md
<ide>
<ide> Support for [WebAssembly](https://webassembly.org/)
<ide> has been identified as one of the
<del>[top technical priorities](https://github.com/nodejs/node/blob/master/doc/contributing/technical-priorities.md#webassembly)
<add>[top technical priorities](https://github.com/nodejs/node/blob/main/doc/contributing/technical-priorities.md#webassembly)
<ide> for the future success of Node.js.
<ide>
<ide> This document provides an overview of our high-level strategy for
<ide> The Node.js WASI implementation is maintained in the
<ide> [uvwasi](https://github.com/nodejs/uvwasi) repository in the
<ide> Node.js GitHub organization. As needed, an updated copy
<ide> is vendored into the Node.js deps in
<del>[deps/uvwasi](https://github.com/nodejs/node/tree/master/deps/uvwasi).
<add>[deps/uvwasi](https://github.com/nodejs/node/tree/main/deps/uvwasi).
<ide>
<ide> To update the copy of uvwasi in the Node.js deps:
<ide>
<ide> The documentation for this API is in
<ide>
<ide> The implementation of the bindings and the public API is in:
<ide>
<del>* [src/node\_wasi.h](https://github.com/nodejs/node/blob/master/src/node_wasi.h)
<del>* [src/node\_wasi.cc](https://github.com/nodejs/node/blob/master/src/node_wasi.cc)
<del>* [lib/wasi.js](https://github.com/nodejs/node/blob/master/lib/wasi.js)
<add>* [src/node\_wasi.h](https://github.com/nodejs/node/blob/main/src/node_wasi.h)
<add>* [src/node\_wasi.cc](https://github.com/nodejs/node/blob/main/src/node_wasi.cc)
<add>* [lib/wasi.js](https://github.com/nodejs/node/blob/main/lib/wasi.js)
<ide><path>doc/contributing/writing-and-running-benchmarks.md
<ide> As an example on how to check for a possible performance improvement, the
<ide> an example. This pull request _claims_ to improve the performance of the
<ide> `node:string_decoder` module.
<ide>
<del>First build two versions of Node.js, one from the master branch (here called
<del>`./node-master`) and another with the pull request applied (here called
<add>First build two versions of Node.js, one from the `main` branch (here called
<add>`./node-main`) and another with the pull request applied (here called
<ide> `./node-pr-5134`).
<ide>
<ide> To run multiple compiled versions in parallel you need to copy the output of the
<del>build: `cp ./out/Release/node ./node-master`. Check out the following example:
<add>build: `cp ./out/Release/node ./node-main`. Check out the following example:
<ide>
<ide> ```console
<del>$ git checkout master
<add>$ git checkout main
<ide> $ ./configure && make -j4
<del>$ cp ./out/Release/node ./node-master
<add>$ cp ./out/Release/node ./node-main
<ide>
<ide> $ git checkout pr-5134
<ide> $ ./configure && make -j4
<ide> $ cp ./out/Release/node ./node-pr-5134
<ide> The `compare.js` tool will then produce a csv file with the benchmark results.
<ide>
<ide> ```console
<del>$ node benchmark/compare.js --old ./node-master --new ./node-pr-5134 string_decoder > compare-pr-5134.csv
<add>$ node benchmark/compare.js --old ./node-main --new ./node-pr-5134 string_decoder > compare-pr-5134.csv
<ide> ```
<ide>
<ide> _Tips: there are some useful options of `benchmark/compare.js`. For example,
<ide><path>doc/contributing/writing-tests.md
<ide> will depend on what is being tested if this is required or not.
<ide> To generate a test coverage report, see the
<ide> [Test Coverage section of the Building guide][].
<ide>
<del>Nightly coverage reports for the Node.js master branch are available at
<add>Nightly coverage reports for the Node.js `main` branch are available at
<ide> <https://coverage.nodejs.org/>.
<ide>
<ide> [ASCII]: https://man7.org/linux/man-pages/man7/ascii.7.html | 11 |
Text | Text | clarify timeout option in vm | 278086a3870ac5ab7b73d28ec7a33ea863c9209b | <ide><path>doc/api/vm.md
<ide> in the ECMAScript specification.
<ide> ### module.evaluate([options])
<ide>
<ide> * `options` {Object}
<del> * `timeout` {number} Specifies the number of milliseconds to evaluate
<add> * `timeout` {integer} Specifies the number of milliseconds to evaluate
<ide> before terminating execution. If execution is interrupted, an [`Error`][]
<del> will be thrown.
<add> will be thrown. This value must be a strictly positive integer.
<ide> * `breakOnSigint` {boolean} If `true`, the execution will be terminated when
<ide> `SIGINT` (Ctrl+C) is received. Existing handlers for the event that have
<ide> been attached via `process.on('SIGINT')` will be disabled during script
<ide> changes:
<ide> * `displayErrors` {boolean} When `true`, if an [`Error`][] error occurs
<ide> while compiling the `code`, the line of code causing the error is attached
<ide> to the stack trace.
<del> * `timeout` {number} Specifies the number of milliseconds to execute `code`
<add> * `timeout` {integer} Specifies the number of milliseconds to execute `code`
<ide> before terminating execution. If execution is terminated, an [`Error`][]
<del> will be thrown.
<add> will be thrown. This value must be a strictly positive integer.
<ide> * `breakOnSigint`: if `true`, the execution will be terminated when
<ide> `SIGINT` (Ctrl+C) is received. Existing handlers for the
<ide> event that have been attached via `process.on('SIGINT')` will be disabled
<ide> changes:
<ide> * `displayErrors` {boolean} When `true`, if an [`Error`][] error occurs
<ide> while compiling the `code`, the line of code causing the error is attached
<ide> to the stack trace.
<del> * `timeout` {number} Specifies the number of milliseconds to execute `code`
<add> * `timeout` {integer} Specifies the number of milliseconds to execute `code`
<ide> before terminating execution. If execution is terminated, an [`Error`][]
<del> will be thrown.
<add> will be thrown. This value must be a strictly positive integer.
<ide> * `contextName` {string} Human-readable name of the newly created context.
<ide> **Default:** `'VM Context i'`, where `i` is an ascending numerical index of
<ide> the created context.
<ide> added: v0.3.1
<ide> * `displayErrors` {boolean} When `true`, if an [`Error`][] error occurs
<ide> while compiling the `code`, the line of code causing the error is attached
<ide> to the stack trace.
<del> * `timeout` {number} Specifies the number of milliseconds to execute `code`
<add> * `timeout` {integer} Specifies the number of milliseconds to execute `code`
<ide> before terminating execution. If execution is terminated, an [`Error`][]
<del> will be thrown.
<add> will be thrown. This value must be a strictly positive integer.
<ide>
<ide> Runs the compiled code contained by the `vm.Script` within the context of the
<ide> current `global` object. Running code does not have access to local scope, but
<ide> Returns `true` if the given `sandbox` object has been [contextified][] using
<ide> * `displayErrors` {boolean} When `true`, if an [`Error`][] error occurs
<ide> while compiling the `code`, the line of code causing the error is attached
<ide> to the stack trace.
<del> * `timeout` {number} Specifies the number of milliseconds to execute `code`
<add> * `timeout` {integer} Specifies the number of milliseconds to execute `code`
<ide> before terminating execution. If execution is terminated, an [`Error`][]
<del> will be thrown.
<add> will be thrown. This value must be a strictly positive integer.
<ide>
<ide> The `vm.runInContext()` method compiles `code`, runs it within the context of
<ide> the `contextifiedSandbox`, then returns the result. Running code does not have
<ide> added: v0.3.1
<ide> * `displayErrors` {boolean} When `true`, if an [`Error`][] error occurs
<ide> while compiling the `code`, the line of code causing the error is attached
<ide> to the stack trace.
<del> * `timeout` {number} Specifies the number of milliseconds to execute `code`
<add> * `timeout` {integer} Specifies the number of milliseconds to execute `code`
<ide> before terminating execution. If execution is terminated, an [`Error`][]
<del> will be thrown.
<add> will be thrown. This value must be a strictly positive integer.
<ide> * `contextName` {string} Human-readable name of the newly created context.
<ide> **Default:** `'VM Context i'`, where `i` is an ascending numerical index of
<ide> the created context.
<ide> added: v0.3.1
<ide> * `displayErrors` {boolean} When `true`, if an [`Error`][] error occurs
<ide> while compiling the `code`, the line of code causing the error is attached
<ide> to the stack trace.
<del> * `timeout` {number} Specifies the number of milliseconds to execute `code`
<add> * `timeout` {integer} Specifies the number of milliseconds to execute `code`
<ide> before terminating execution. If execution is terminated, an [`Error`][]
<del> will be thrown.
<add> will be thrown. This value must be a strictly positive integer.
<ide>
<ide> `vm.runInThisContext()` compiles `code`, runs it within the context of the
<ide> current `global` and returns the result. Running code does not have access to | 1 |
Javascript | Javascript | skip remaining failing tests | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61 | <ide><path>packages/ember-application/tests/system/logging_test.js
<ide> QUnit.test("do not log when template and view are missing when flag is not true"
<ide> });
<ide> });
<ide>
<del>QUnit.test("log which view is used with a template", function() {
<add>QUnit.skip("log which view is used with a template", function() {
<ide> if (EmberDev && EmberDev.runningProdBuild) {
<ide> ok(true, 'Logging does not occur in production builds');
<ide> return;
<ide><path>packages/ember-metal-views/tests/attributes_test.js
<ide> import {
<ide>
<ide> testsFor("ember-metal-views - attributes");
<ide>
<del>QUnit.test('aliased attributeBindings', function() {
<add>QUnit.skip('aliased attributeBindings', function() {
<ide> var view = {
<ide> isView: true,
<ide> attributeBindings: ['isDisabled:disabled'],
<ide><path>packages/ember-metal-views/tests/children_test.js
<ide> import {
<ide>
<ide> testsFor("ember-metal-views - children");
<ide>
<del>QUnit.test("a view can have child views", function() {
<add>QUnit.skip("a view can have child views", function() {
<ide> var view = {
<ide> isView: true,
<ide> tagName: 'ul',
<ide> QUnit.test("a view can have child views", function() {
<ide> equalHTML('qunit-fixture', "<ul><li>ohai</li></ul>");
<ide> });
<ide>
<del>QUnit.test("didInsertElement fires after children are rendered", function() {
<add>QUnit.skip("didInsertElement fires after children are rendered", function() {
<ide> expect(2);
<ide>
<ide> var view = {
<ide><path>packages/ember-metal-views/tests/main_test.js
<ide> testsFor("ember-metal-views", {
<ide> });
<ide>
<ide> // Test the behavior of the helper createElement stub
<del>QUnit.test("by default, view renders as a div", function() {
<add>QUnit.skip("by default, view renders as a div", function() {
<ide> view = { isView: true };
<ide>
<ide> appendTo(view);
<ide> equalHTML('qunit-fixture', "<div></div>");
<ide> });
<ide>
<ide> // Test the behavior of the helper createElement stub
<del>QUnit.test("tagName can be specified", function() {
<add>QUnit.skip("tagName can be specified", function() {
<ide> view = {
<ide> isView: true,
<ide> tagName: 'span'
<ide> QUnit.test("tagName can be specified", function() {
<ide> });
<ide>
<ide> // Test the behavior of the helper createElement stub
<del>QUnit.test("textContent can be specified", function() {
<add>QUnit.skip("textContent can be specified", function() {
<ide> view = {
<ide> isView: true,
<ide> textContent: 'ohai <a>derp</a>'
<ide> QUnit.test("textContent can be specified", function() {
<ide> });
<ide>
<ide> // Test the behavior of the helper createElement stub
<del>QUnit.test("innerHTML can be specified", function() {
<add>QUnit.skip("innerHTML can be specified", function() {
<ide> view = {
<ide> isView: true,
<ide> innerHTML: 'ohai <a>derp</a>'
<ide> QUnit.test("innerHTML can be specified", function() {
<ide> });
<ide>
<ide> // Test the behavior of the helper createElement stub
<del>QUnit.test("innerHTML tr can be specified", function() {
<add>QUnit.skip("innerHTML tr can be specified", function() {
<ide> view = {
<ide> isView: true,
<ide> tagName: 'table',
<ide> QUnit.test("innerHTML tr can be specified", function() {
<ide> });
<ide>
<ide> // Test the behavior of the helper createElement stub
<del>QUnit.test("element can be specified", function() {
<add>QUnit.skip("element can be specified", function() {
<ide> view = {
<ide> isView: true,
<ide> element: document.createElement('i')
<ide> QUnit.test("element can be specified", function() {
<ide> equalHTML('qunit-fixture', "<i></i>");
<ide> });
<ide>
<del>QUnit.test("willInsertElement hook", function() {
<add>QUnit.skip("willInsertElement hook", function() {
<ide> expect(3);
<ide>
<ide> view = {
<ide> QUnit.test("willInsertElement hook", function() {
<ide> equalHTML('qunit-fixture', "<div>you gone and done inserted that element</div>");
<ide> });
<ide>
<del>QUnit.test("didInsertElement hook", function() {
<add>QUnit.skip("didInsertElement hook", function() {
<ide> expect(3);
<ide>
<ide> view = {
<ide> QUnit.test("didInsertElement hook", function() {
<ide> equalHTML('qunit-fixture', "<div>you gone and done inserted that element</div>");
<ide> });
<ide>
<del>QUnit.test("classNames - array", function() {
<add>QUnit.skip("classNames - array", function() {
<ide> view = {
<ide> isView: true,
<ide> classNames: ['foo', 'bar'],
<ide> QUnit.test("classNames - array", function() {
<ide> equalHTML('qunit-fixture', '<div class="foo bar">ohai</div>');
<ide> });
<ide>
<del>QUnit.test("classNames - string", function() {
<add>QUnit.skip("classNames - string", function() {
<ide> view = {
<ide> isView: true,
<ide> classNames: 'foo bar',
<ide><path>packages/ember-metal/tests/streams/key-stream-test.js
<ide> QUnit.module('KeyStream', {
<ide> }
<ide> });
<ide>
<del>QUnit.test("can be instantiated manually", function() {
<add>QUnit.skip("can be instantiated manually", function() {
<ide> var nameStream = new KeyStream(source, 'name');
<ide> equal(nameStream.value(), "mmun", "Stream value is correct");
<ide> });
<ide>
<del>QUnit.test("can be instantiated via `Stream.prototype.get`", function() {
<add>QUnit.skip("can be instantiated via `Stream.prototype.get`", function() {
<ide> var nameStream = source.get('name');
<ide> equal(nameStream.value(), "mmun", "Stream value is correct");
<ide> });
<ide>
<del>QUnit.test("is notified when the observed object's property is mutated", function() {
<add>QUnit.skip("is notified when the observed object's property is mutated", function() {
<ide> var nameStream = source.get('name');
<ide> nameStream.subscribe(incrementCount);
<ide>
<ide> QUnit.test("is notified when the observed object's property is mutated", functio
<ide> equal(nameStream.value(), "wycats", "Stream value is correct");
<ide> });
<ide>
<del>QUnit.test("is notified when the source stream's value changes to a new object", function() {
<add>QUnit.skip("is notified when the source stream's value changes to a new object", function() {
<ide> var nameStream = source.get('name');
<ide> nameStream.subscribe(incrementCount);
<ide>
<ide> QUnit.test("is notified when the source stream's value changes to a new object",
<ide> equal(nameStream.value(), "kris", "Stream value is correct");
<ide> });
<ide>
<del>QUnit.test("is notified when the source stream's value changes to the same object", function() {
<add>QUnit.skip("is notified when the source stream's value changes to the same object", function() {
<ide> var nameStream = source.get('name');
<ide> nameStream.subscribe(incrementCount);
<ide>
<ide> QUnit.test("is notified when the source stream's value changes to the same objec
<ide> equal(nameStream.value(), "kris", "Stream value is correct");
<ide> });
<ide>
<del>QUnit.test("is notified when setSource is called with a new stream whose value is a new object", function() {
<add>QUnit.skip("is notified when setSource is called with a new stream whose value is a new object", function() {
<ide> var nameStream = source.get('name');
<ide> nameStream.subscribe(incrementCount);
<ide>
<ide> QUnit.test("is notified when setSource is called with a new stream whose value i
<ide> equal(nameStream.value(), "kris", "Stream value is correct");
<ide> });
<ide>
<del>QUnit.test("is notified when setSource is called with a new stream whose value is the same object", function() {
<add>QUnit.skip("is notified when setSource is called with a new stream whose value is the same object", function() {
<ide> var nameStream = source.get('name');
<ide> nameStream.subscribe(incrementCount);
<ide>
<ide><path>packages/ember-metal/tests/streams/simple-stream-test.js
<ide> QUnit.module('SimpleStream', {
<ide> }
<ide> });
<ide>
<del>QUnit.test('supports a stream argument', function() {
<add>QUnit.skip('supports a stream argument', function() {
<ide> var stream = new SimpleStream(source);
<ide> equal(stream.value(), "zlurp");
<ide>
<ide> stream.setValue("blorg");
<ide> equal(stream.value(), "blorg");
<ide> });
<ide>
<del>QUnit.test('supports a non-stream argument', function() {
<add>QUnit.skip('supports a non-stream argument', function() {
<ide> var stream = new SimpleStream(value);
<ide> equal(stream.value(), "zlurp");
<ide>
<ide><path>packages/ember-routing-htmlbars/tests/helpers/action_test.js
<ide> QUnit.module("ember-routing-htmlbars: action helper", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("should output a data attribute with a guid", function() {
<add>QUnit.skip("should output a data attribute with a guid", function() {
<ide> view = EmberView.create({
<ide> template: compile('<a href="#" {{action "edit"}}>edit</a>')
<ide> });
<ide> QUnit.test("should output a data attribute with a guid", function() {
<ide> ok(view.$('a').attr('data-ember-action').match(/\d+/), "A data-ember-action attribute with a guid was added");
<ide> });
<ide>
<del>QUnit.test("should by default register a click event", function() {
<add>QUnit.skip("should by default register a click event", function() {
<ide> var registeredEventName;
<ide>
<ide> ActionHelper.registerAction = function(actionName, options) {
<ide> QUnit.test("should by default register a click event", function() {
<ide> equal(registeredEventName, 'click', "The click event was properly registered");
<ide> });
<ide>
<del>QUnit.test("should allow alternative events to be handled", function() {
<add>QUnit.skip("should allow alternative events to be handled", function() {
<ide> var registeredEventName;
<ide>
<ide> ActionHelper.registerAction = function(actionName, options) {
<ide> QUnit.test("should allow alternative events to be handled", function() {
<ide> equal(registeredEventName, 'mouseUp', "The alternative mouseUp event was properly registered");
<ide> });
<ide>
<del>QUnit.test("should by default target the view's controller", function() {
<add>QUnit.skip("should by default target the view's controller", function() {
<ide> var registeredTarget;
<ide> var controller = {};
<ide>
<ide> QUnit.test("should by default target the view's controller", function() {
<ide> equal(registeredTarget, controller, "The controller was registered as the target");
<ide> });
<ide>
<del>QUnit.test("Inside a yield, the target points at the original target", function() {
<add>QUnit.skip("Inside a yield, the target points at the original target", function() {
<ide> var watted = false;
<ide>
<ide> var component = EmberComponent.extend({
<ide> QUnit.test("Inside a yield, the target points at the original target", function(
<ide> equal(watted, true, "The action was called on the right context");
<ide> });
<ide>
<del>QUnit.test("should target the current controller inside an {{each}} loop [DEPRECATED]", function() {
<add>QUnit.skip("should target the current controller inside an {{each}} loop [DEPRECATED]", function() {
<ide> var registeredTarget;
<ide>
<ide> ActionHelper.registerAction = function(actionName, options) {
<ide> QUnit.test("should target the current controller inside an {{each}} loop [DEPREC
<ide> equal(registeredTarget, itemController, "the item controller is the target of action");
<ide> });
<ide>
<del>QUnit.test("should target the with-controller inside an {{#with controller='person'}} [DEPRECATED]", function() {
<add>QUnit.skip("should target the with-controller inside an {{#with controller='person'}} [DEPRECATED]", function() {
<ide> var registeredTarget;
<ide>
<ide> ActionHelper.registerAction = function(actionName, options) {
<ide> QUnit.test("should target the with-controller inside an {{#with controller='pers
<ide> ok(registeredTarget instanceof PersonController, "the with-controller is the target of action");
<ide> });
<ide>
<del>QUnit.test("should target the with-controller inside an {{each}} in a {{#with controller='person'}} [DEPRECATED]", function() {
<add>QUnit.skip("should target the with-controller inside an {{each}} in a {{#with controller='person'}} [DEPRECATED]", function() {
<ide> expectDeprecation('Using the context switching form of {{each}} is deprecated. Please use the keyword form (`{{#each foo in bar}}`) instead.');
<ide> expectDeprecation('Using the context switching form of `{{with}}` is deprecated. Please use the keyword form (`{{with foo as bar}}`) instead.');
<ide>
<ide> QUnit.test("should target the with-controller inside an {{each}} in a {{#with co
<ide> deepEqual(eventsCalled, ['robert', 'brian'], 'the events are fired properly');
<ide> });
<ide>
<del>QUnit.test("should allow a target to be specified", function() {
<add>QUnit.skip("should allow a target to be specified", function() {
<ide> var registeredTarget;
<ide>
<ide> ActionHelper.registerAction = function(actionName, options) {
<ide> QUnit.test("should allow a target to be specified", function() {
<ide> runDestroy(anotherTarget);
<ide> });
<ide>
<del>QUnit.test("should lazily evaluate the target", function() {
<add>QUnit.skip("should lazily evaluate the target", function() {
<ide> var firstEdit = 0;
<ide> var secondEdit = 0;
<ide> var controller = {};
<ide> QUnit.test("should lazily evaluate the target", function() {
<ide> equal(secondEdit, 1);
<ide> });
<ide>
<del>QUnit.test("should register an event handler", function() {
<add>QUnit.skip("should register an event handler", function() {
<ide> var eventHandlerWasCalled = false;
<ide>
<ide> var controller = EmberController.extend({
<ide> QUnit.test("should register an event handler", function() {
<ide> ok(eventHandlerWasCalled, "The event handler was called");
<ide> });
<ide>
<del>QUnit.test("handles whitelisted modifier keys", function() {
<add>QUnit.skip("handles whitelisted modifier keys", function() {
<ide> var eventHandlerWasCalled = false;
<ide> var shortcutHandlerWasCalled = false;
<ide>
<ide> QUnit.test("handles whitelisted modifier keys", function() {
<ide> ok(shortcutHandlerWasCalled, "The \"any\" shortcut's event handler was called");
<ide> });
<ide>
<del>QUnit.test("should be able to use action more than once for the same event within a view", function() {
<add>QUnit.skip("should be able to use action more than once for the same event within a view", function() {
<ide> var editWasCalled = false;
<ide> var deleteWasCalled = false;
<ide> var originalEventHandlerWasCalled = false;
<ide> QUnit.test("should be able to use action more than once for the same event withi
<ide> equal(deleteWasCalled, false, "The delete action was not called");
<ide> });
<ide>
<del>QUnit.test("the event should not bubble if `bubbles=false` is passed", function() {
<add>QUnit.skip("the event should not bubble if `bubbles=false` is passed", function() {
<ide> var editWasCalled = false;
<ide> var deleteWasCalled = false;
<ide> var originalEventHandlerWasCalled = false;
<ide> QUnit.test("the event should not bubble if `bubbles=false` is passed", function(
<ide> equal(originalEventHandlerWasCalled, true, "The original event handler was called");
<ide> });
<ide>
<del>QUnit.test("should work properly in an #each block", function() {
<add>QUnit.skip("should work properly in an #each block", function() {
<ide> var eventHandlerWasCalled = false;
<ide>
<ide> var controller = EmberController.extend({
<ide> QUnit.test("should work properly in an #each block", function() {
<ide> ok(eventHandlerWasCalled, "The event handler was called");
<ide> });
<ide>
<del>QUnit.test("should work properly in a {{#with foo as bar}} block", function() {
<add>QUnit.skip("should work properly in a {{#with foo as bar}} block", function() {
<ide> var eventHandlerWasCalled = false;
<ide>
<ide> var controller = EmberController.extend({
<ide> QUnit.test("should work properly in a {{#with foo as bar}} block", function() {
<ide> ok(eventHandlerWasCalled, "The event handler was called");
<ide> });
<ide>
<del>QUnit.test("should work properly in a #with block [DEPRECATED]", function() {
<add>QUnit.skip("should work properly in a #with block [DEPRECATED]", function() {
<ide> var eventHandlerWasCalled = false;
<ide>
<ide> var controller = EmberController.extend({
<ide> QUnit.test("should work properly in a #with block [DEPRECATED]", function() {
<ide> ok(eventHandlerWasCalled, "The event handler was called");
<ide> });
<ide>
<del>QUnit.test("should unregister event handlers on rerender", function() {
<add>QUnit.skip("should unregister event handlers on rerender", function() {
<ide> var eventHandlerWasCalled = false;
<ide>
<ide> view = EmberView.extend({
<ide> QUnit.test("should unregister event handlers on rerender", function() {
<ide> ok(ActionManager.registeredActions[newActionId], "After rerender completes, a new event handler was added");
<ide> });
<ide>
<del>QUnit.test("should unregister event handlers on inside virtual views", function() {
<add>QUnit.skip("should unregister event handlers on inside virtual views", function() {
<ide> var things = Ember.A([
<ide> {
<ide> name: 'Thingy'
<ide> QUnit.test("should unregister event handlers on inside virtual views", function(
<ide> ok(!ActionManager.registeredActions[actionId], "After the virtual view was destroyed, the action was unregistered");
<ide> });
<ide>
<del>QUnit.test("should properly capture events on child elements of a container with an action", function() {
<add>QUnit.skip("should properly capture events on child elements of a container with an action", function() {
<ide> var eventHandlerWasCalled = false;
<ide>
<ide> var controller = EmberController.extend({
<ide> QUnit.test("should properly capture events on child elements of a container with
<ide> ok(eventHandlerWasCalled, "Event on a child element triggered the action of its parent");
<ide> });
<ide>
<del>QUnit.test("should allow bubbling of events from action helper to original parent event", function() {
<add>QUnit.skip("should allow bubbling of events from action helper to original parent event", function() {
<ide> var eventHandlerWasCalled = false;
<ide> var originalEventHandlerWasCalled = false;
<ide>
<ide> QUnit.test("should allow bubbling of events from action helper to original paren
<ide> ok(eventHandlerWasCalled && originalEventHandlerWasCalled, "Both event handlers were called");
<ide> });
<ide>
<del>QUnit.test("should not bubble an event from action helper to original parent event if `bubbles=false` is passed", function() {
<add>QUnit.skip("should not bubble an event from action helper to original parent event if `bubbles=false` is passed", function() {
<ide> var eventHandlerWasCalled = false;
<ide> var originalEventHandlerWasCalled = false;
<ide>
<ide> QUnit.test("should not bubble an event from action helper to original parent eve
<ide> ok(!originalEventHandlerWasCalled, "The parent handler was not called");
<ide> });
<ide>
<del>QUnit.test("should allow 'send' as action name (#594)", function() {
<add>QUnit.skip("should allow 'send' as action name (#594)", function() {
<ide> var eventHandlerWasCalled = false;
<ide>
<ide> var controller = EmberController.extend({
<ide> QUnit.test("should allow 'send' as action name (#594)", function() {
<ide> });
<ide>
<ide>
<del>QUnit.test("should send the view, event and current context to the action", function() {
<add>QUnit.skip("should send the view, event and current context to the action", function() {
<ide> var passedTarget;
<ide> var passedContext;
<ide>
<ide> QUnit.test("should send the view, event and current context to the action", func
<ide> strictEqual(passedContext, aContext, "the parameter is passed along");
<ide> });
<ide>
<del>QUnit.test("should only trigger actions for the event they were registered on", function() {
<add>QUnit.skip("should only trigger actions for the event they were registered on", function() {
<ide> var editWasCalled = false;
<ide>
<ide> view = EmberView.extend({
<ide> QUnit.test("should only trigger actions for the event they were registered on",
<ide> ok(!editWasCalled, "The action wasn't called");
<ide> });
<ide>
<del>QUnit.test("should unwrap controllers passed as a context", function() {
<add>QUnit.skip("should unwrap controllers passed as a context", function() {
<ide> var passedContext;
<ide> var model = EmberObject.create();
<ide> var controller = EmberController.extend({
<ide> QUnit.test("should unwrap controllers passed as a context", function() {
<ide> equal(passedContext, model, "the action was passed the unwrapped model");
<ide> });
<ide>
<del>QUnit.test("should not unwrap controllers passed as `controller`", function() {
<add>QUnit.skip("should not unwrap controllers passed as `controller`", function() {
<ide> var passedContext;
<ide> var model = EmberObject.create();
<ide> var controller = EmberController.extend({
<ide> QUnit.test("should not unwrap controllers passed as `controller`", function() {
<ide> equal(passedContext, controller, "the action was passed the controller");
<ide> });
<ide>
<del>QUnit.test("should allow multiple contexts to be specified", function() {
<add>QUnit.skip("should allow multiple contexts to be specified", function() {
<ide> var passedContexts;
<ide> var models = [EmberObject.create(), EmberObject.create()];
<ide>
<ide> QUnit.test("should allow multiple contexts to be specified", function() {
<ide> deepEqual(passedContexts, models, "the action was called with the passed contexts");
<ide> });
<ide>
<del>QUnit.test("should allow multiple contexts to be specified mixed with string args", function() {
<add>QUnit.skip("should allow multiple contexts to be specified mixed with string args", function() {
<ide> var passedParams;
<ide> var model = EmberObject.create();
<ide>
<ide> QUnit.test("should allow multiple contexts to be specified mixed with string arg
<ide> deepEqual(passedParams, ["herp", model], "the action was called with the passed contexts");
<ide> });
<ide>
<del>QUnit.test("it does not trigger action with special clicks", function() {
<add>QUnit.skip("it does not trigger action with special clicks", function() {
<ide> var showCalled = false;
<ide>
<ide> view = EmberView.create({
<ide> QUnit.test("it does not trigger action with special clicks", function() {
<ide> checkClick('which', undefined, true); // IE <9
<ide> });
<ide>
<del>QUnit.test("it can trigger actions for keyboard events", function() {
<add>QUnit.skip("it can trigger actions for keyboard events", function() {
<ide> var showCalled = false;
<ide>
<ide> view = EmberView.create({
<ide> QUnit.test("it can trigger actions for keyboard events", function() {
<ide> ok(showCalled, "should call action with keyup");
<ide> });
<ide>
<del>QUnit.test("a quoteless parameter should allow dynamic lookup of the actionName", function() {
<add>QUnit.skip("a quoteless parameter should allow dynamic lookup of the actionName", function() {
<ide> expect(4);
<ide> var lastAction;
<ide> var actionOrder = [];
<ide> QUnit.test("a quoteless parameter should allow dynamic lookup of the actionName"
<ide> deepEqual(actionOrder, ['whompWhomp', 'sloopyDookie', 'biggityBoom'], 'action name was looked up properly');
<ide> });
<ide>
<del>QUnit.test("a quoteless parameter should lookup actionName in context [DEPRECATED]", function() {
<add>QUnit.skip("a quoteless parameter should lookup actionName in context [DEPRECATED]", function() {
<ide> expect(5);
<ide> var lastAction;
<ide> var actionOrder = [];
<ide> QUnit.test("a quoteless parameter should lookup actionName in context [DEPRECATE
<ide> deepEqual(actionOrder, ['whompWhomp', 'sloopyDookie', 'biggityBoom'], 'action name was looked up properly');
<ide> });
<ide>
<del>QUnit.test("a quoteless parameter should resolve actionName, including path", function() {
<add>QUnit.skip("a quoteless parameter should resolve actionName, including path", function() {
<ide> expect(4);
<ide> var lastAction;
<ide> var actionOrder = [];
<ide> QUnit.test("a quoteless parameter should resolve actionName, including path", fu
<ide> deepEqual(actionOrder, ['whompWhomp', 'sloopyDookie', 'biggityBoom'], 'action name was looked up properly');
<ide> });
<ide>
<del>QUnit.test("a quoteless parameter that does not resolve to a value asserts", function() {
<add>QUnit.skip("a quoteless parameter that does not resolve to a value asserts", function() {
<ide> var triggeredAction;
<ide>
<ide> view = EmberView.create({
<ide> QUnit.module("ember-routing-htmlbars: action helper - deprecated invoking direct
<ide> }
<ide> });
<ide>
<del>QUnit.test("should respect preventDefault=false option if provided", function() {
<add>QUnit.skip("should respect preventDefault=false option if provided", function() {
<ide> view = EmberView.create({
<ide> template: compile("<a {{action 'show' preventDefault=false}}>Hi</a>")
<ide> });
<ide><path>packages/ember-routing-htmlbars/tests/helpers/outlet_test.js
<ide> QUnit.test("outlet should support an optional name", function() {
<ide> });
<ide>
<ide>
<del>QUnit.test("outlet should correctly lookup a view", function() {
<add>QUnit.skip("outlet should correctly lookup a view", function() {
<ide> var CoreOutlet = container.lookupFactory('view:core-outlet');
<ide> var SpecialOutlet = CoreOutlet.extend({
<ide> classNames: ['special']
<ide> QUnit.test("outlet should correctly lookup a view", function() {
<ide> equal(top.$().find('.special').length, 1, "expected to find .special element");
<ide> });
<ide>
<del>QUnit.test("outlet should assert view is specified as a string", function() {
<add>QUnit.skip("outlet should assert view is specified as a string", function() {
<ide> top.setOutletState(withTemplate("<h1>HI</h1>{{outlet view=containerView}}"));
<ide>
<ide> expectAssertion(function () {
<ide> QUnit.test("outlet should assert view is specified as a string", function() {
<ide>
<ide> });
<ide>
<del>QUnit.test("outlet should assert view path is successfully resolved", function() {
<add>QUnit.skip("outlet should assert view path is successfully resolved", function() {
<ide> top.setOutletState(withTemplate("<h1>HI</h1>{{outlet view='someViewNameHere'}}"));
<ide>
<ide> expectAssertion(function () {
<ide> QUnit.test("outlet should assert view path is successfully resolved", function()
<ide>
<ide> });
<ide>
<del>QUnit.test("outlet should support an optional view class", function() {
<add>QUnit.skip("outlet should support an optional view class", function() {
<ide> var CoreOutlet = container.lookupFactory('view:core-outlet');
<ide> var SpecialOutlet = CoreOutlet.extend({
<ide> classNames: ['very-special']
<ide> QUnit.test("Outlets bind to the current template's view, not inner contexts [DEP
<ide> equal(output, "BOTTOM", "all templates were rendered");
<ide> });
<ide>
<del>QUnit.test("should support layouts", function() {
<add>QUnit.skip("should support layouts", function() {
<ide> var template = "{{outlet}}";
<ide> var layout = "<h1>HI</h1>{{yield}}";
<ide> var routerState = {
<ide> QUnit.test("should not throw deprecations if {{outlet}} is used with a quoted na
<ide> runAppend(top);
<ide> });
<ide>
<del>QUnit.test("should throw an assertion if {{outlet}} used with unquoted name", function() {
<add>QUnit.skip("should throw an assertion if {{outlet}} used with unquoted name", function() {
<ide> top.setOutletState(withTemplate("{{outlet foo}}"));
<ide> expectAssertion(function() {
<ide> runAppend(top);
<ide><path>packages/ember-routing-htmlbars/tests/helpers/render_test.js
<ide> QUnit.module("ember-routing-htmlbars: {{render}} helper", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should render given template", function() {
<add>QUnit.skip("{{render}} helper should render given template", function() {
<ide> var template = "<h1>HI</h1>{{render 'home'}}";
<ide> var controller = EmberController.extend({ container: container });
<ide> view = EmberView.create({
<ide> QUnit.test("{{render}} helper should render given template", function() {
<ide> ok(container.lookup('router:main')._lookupActiveView('home'), 'should register home as active view');
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should have assertion if neither template nor view exists", function() {
<add>QUnit.skip("{{render}} helper should have assertion if neither template nor view exists", function() {
<ide> var template = "<h1>HI</h1>{{render 'oops'}}";
<ide> var controller = EmberController.extend({ container: container });
<ide> view = EmberView.create({
<ide> QUnit.test("{{render}} helper should have assertion if neither template nor view
<ide> }, 'You used `{{render \'oops\'}}`, but \'oops\' can not be found as either a template or a view.');
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should not have assertion if template is supplied in block-form", function() {
<add>QUnit.skip("{{render}} helper should not have assertion if template is supplied in block-form", function() {
<ide> var template = "<h1>HI</h1>{{#render 'good'}} {{name}}{{/render}}";
<ide> var controller = EmberController.extend({ container: container });
<ide> container._registry.register('controller:good', EmberController.extend({ name: 'Rob' }));
<ide> QUnit.test("{{render}} helper should not have assertion if template is supplied
<ide> equal(view.$().text(), 'HI Rob');
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should not have assertion if view exists without a template", function() {
<add>QUnit.skip("{{render}} helper should not have assertion if view exists without a template", function() {
<ide> var template = "<h1>HI</h1>{{render 'oops'}}";
<ide> var controller = EmberController.extend({ container: container });
<ide> view = EmberView.create({
<ide> QUnit.test("{{render}} helper should not have assertion if view exists without a
<ide> equal(view.$().text(), 'HI');
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should render given template with a supplied model", function() {
<add>QUnit.skip("{{render}} helper should render given template with a supplied model", function() {
<ide> var template = "<h1>HI</h1>{{render 'post' post}}";
<ide> var post = {
<ide> title: "Rails is omakase"
<ide> QUnit.test("{{render}} helper should render given template with a supplied model
<ide> }
<ide> });
<ide>
<del>QUnit.test("{{render}} helper with a supplied model should not fire observers on the controller", function () {
<add>QUnit.skip("{{render}} helper with a supplied model should not fire observers on the controller", function () {
<ide> var template = "<h1>HI</h1>{{render 'post' post}}";
<ide> var post = {
<ide> title: "Rails is omakase"
<ide> QUnit.test("{{render}} helper with a supplied model should not fire observers on
<ide>
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should raise an error when a given controller name does not resolve to a controller", function() {
<add>QUnit.skip("{{render}} helper should raise an error when a given controller name does not resolve to a controller", function() {
<ide> var template = '<h1>HI</h1>{{render "home" controller="postss"}}';
<ide> var controller = EmberController.extend({ container: container });
<ide> container._registry.register('controller:posts', EmberArrayController.extend());
<ide> QUnit.test("{{render}} helper should raise an error when a given controller name
<ide> }, 'The controller name you supplied \'postss\' did not resolve to a controller.');
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should render with given controller", function() {
<add>QUnit.skip("{{render}} helper should render with given controller", function() {
<ide> var template = '<h1>HI</h1>{{render "home" controller="posts"}}';
<ide> var controller = EmberController.extend({ container: container });
<ide> container._registry.register('controller:posts', EmberArrayController.extend());
<ide> QUnit.test("{{render}} helper should render with given controller", function() {
<ide> equal(container.lookup('controller:posts'), renderedView.get('controller'), 'rendered with correct controller');
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should render a template without a model only once", function() {
<add>QUnit.skip("{{render}} helper should render a template without a model only once", function() {
<ide> var template = "<h1>HI</h1>{{render 'home'}}<hr/>{{render 'home'}}";
<ide> var controller = EmberController.extend({ container: container });
<ide> view = EmberView.create({
<ide> QUnit.test("{{render}} helper should render a template without a model only once
<ide> }, /\{\{render\}\} helper once/i);
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should render templates with models multiple times", function() {
<add>QUnit.skip("{{render}} helper should render templates with models multiple times", function() {
<ide> var template = "<h1>HI</h1> {{render 'post' post1}} {{render 'post' post2}}";
<ide> var post1 = {
<ide> title: "Me first"
<ide> QUnit.test("{{render}} helper should render templates with models multiple times
<ide> }
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should not leak controllers", function() {
<add>QUnit.skip("{{render}} helper should not leak controllers", function() {
<ide> var template = "<h1>HI</h1> {{render 'post' post1}}";
<ide> var post1 = {
<ide> title: "Me first"
<ide> QUnit.test("{{render}} helper should not leak controllers", function() {
<ide> ok(postController1.isDestroyed, 'expected postController to be destroyed');
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should not treat invocations with falsy contexts as context-less", function() {
<add>QUnit.skip("{{render}} helper should not treat invocations with falsy contexts as context-less", function() {
<ide> var template = "<h1>HI</h1> {{render 'post' zero}} {{render 'post' nonexistent}}";
<ide>
<ide> view = EmberView.create({
<ide> QUnit.test("{{render}} helper should not treat invocations with falsy contexts a
<ide> equal(postController2.get('model'), undefined);
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should render templates both with and without models", function() {
<add>QUnit.skip("{{render}} helper should render templates both with and without models", function() {
<ide> var template = "<h1>HI</h1> {{render 'post'}} {{render 'post' post}}";
<ide> var post = {
<ide> title: "Rails is omakase"
<ide> QUnit.test("{{render}} helper should render templates both with and without mode
<ide> }
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should link child controllers to the parent controller", function() {
<add>QUnit.skip("{{render}} helper should link child controllers to the parent controller", function() {
<ide> var parentTriggered = 0;
<ide>
<ide> var template = '<h1>HI</h1>{{render "posts"}}';
<ide> QUnit.test("{{render}} helper should link child controllers to the parent contro
<ide> equal(parentTriggered, 1, "The event bubbled to the parent");
<ide> });
<ide>
<del>QUnit.test("{{render}} helper should be able to render a template again when it was removed", function() {
<add>QUnit.skip("{{render}} helper should be able to render a template again when it was removed", function() {
<ide> var controller = EmberController.extend({ container: container });
<ide> var CoreOutlet = container.lookupFactory('view:core-outlet');
<ide> view = CoreOutlet.create();
<ide> QUnit.test("{{render}} helper should be able to render a template again when it
<ide> equal(view.$().text(), 'HI2BYE');
<ide> });
<ide>
<del>QUnit.test("{{render}} works with dot notation", function() {
<add>QUnit.skip("{{render}} works with dot notation", function() {
<ide> var template = '<h1>BLOG</h1>{{render "blog.post"}}';
<ide>
<ide> var controller = EmberController.extend({ container: container });
<ide> QUnit.test("{{render}} works with dot notation", function() {
<ide> equal(container.lookup('controller:blog.post'), renderedView.get('controller'), 'rendered with correct controller');
<ide> });
<ide>
<del>QUnit.test("{{render}} works with slash notation", function() {
<add>QUnit.skip("{{render}} works with slash notation", function() {
<ide> var template = '<h1>BLOG</h1>{{render "blog/post"}}';
<ide>
<ide> var controller = EmberController.extend({ container: container });
<ide> QUnit.test("{{render}} works with slash notation", function() {
<ide> equal(container.lookup('controller:blog.post'), renderedView.get('controller'), 'rendered with correct controller');
<ide> });
<ide>
<del>QUnit.test("throws an assertion if {{render}} is called with an unquoted template name", function() {
<add>QUnit.skip("throws an assertion if {{render}} is called with an unquoted template name", function() {
<ide> var template = '<h1>HI</h1>{{render home}}';
<ide> var controller = EmberController.extend({ container: container });
<ide> view = EmberView.create({
<ide> QUnit.test("throws an assertion if {{render}} is called with an unquoted templat
<ide> }, "The first argument of {{render}} must be quoted, e.g. {{render \"sidebar\"}}.");
<ide> });
<ide>
<del>QUnit.test("throws an assertion if {{render}} is called with a literal for a model", function() {
<add>QUnit.skip("throws an assertion if {{render}} is called with a literal for a model", function() {
<ide> var template = '<h1>HI</h1>{{render "home" "model"}}';
<ide> var controller = EmberController.extend({ container: container });
<ide> view = EmberView.create({
<ide><path>packages/ember-routing-views/tests/main_test.js
<ide> import Ember from 'ember-metal/core';
<ide>
<ide> QUnit.module("ember-routing-views");
<ide>
<del>QUnit.test("exports correctly", function() {
<add>QUnit.skip("exports correctly", function() {
<ide> ok(Ember.LinkView, "LinkView is exported correctly");
<ide> ok(Ember.OutletView, "OutletView is exported correctly");
<ide> });
<ide><path>packages/ember-testing/tests/helpers_test.js
<ide> QUnit.test("`wait` helper can be passed a resolution value", function() {
<ide>
<ide> });
<ide>
<del>QUnit.test("`click` triggers appropriate events in order", function() {
<add>QUnit.skip("`click` triggers appropriate events in order", function() {
<ide> expect(5);
<ide>
<ide> var click, wait, events;
<ide> QUnit.test("`fillIn` takes context into consideration", function() {
<ide> });
<ide> });
<ide>
<del>QUnit.test("`fillIn` focuses on the element", function() {
<add>QUnit.skip("`fillIn` focuses on the element", function() {
<ide> expect(2);
<ide> var fillIn, find, visit, andThen;
<ide>
<ide><path>packages/ember-testing/tests/integration_test.js
<ide> QUnit.test("template is bound to empty array of people", function() {
<ide> });
<ide> });
<ide>
<del>QUnit.test("template is bound to array of 2 people", function() {
<add>QUnit.skip("template is bound to array of 2 people", function() {
<ide> App.Person.find = function() {
<ide> var people = Ember.A();
<ide> var first = App.Person.create({ firstName: "x" });
<ide><path>packages/ember-views/tests/system/event_dispatcher_test.js
<ide> QUnit.module("EventDispatcher", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("should dispatch events to views", function() {
<add>QUnit.skip("should dispatch events to views", function() {
<ide> var receivedEvent;
<ide> var parentMouseDownCalled = 0;
<ide> var childKeyDownCalled = 0;
<ide> QUnit.test("should dispatch events to views", function() {
<ide> equal(parentKeyDownCalled, 0, "does not call keyDown on parent if child handles event");
<ide> });
<ide>
<del>QUnit.test("should not dispatch events to views not inDOM", function() {
<add>QUnit.skip("should not dispatch events to views not inDOM", function() {
<ide> var receivedEvent;
<ide>
<ide> view = View.createWithMixins({
<ide> QUnit.test("should not dispatch events to views not inDOM", function() {
<ide> $element.remove();
<ide> });
<ide>
<del>QUnit.test("should send change events up view hierarchy if view contains form elements", function() {
<add>QUnit.skip("should send change events up view hierarchy if view contains form elements", function() {
<ide> var receivedEvent;
<ide> view = View.create({
<ide> render(buffer) {
<ide> QUnit.test("should send change events up view hierarchy if view contains form el
<ide> equal(receivedEvent.target, jQuery('#is-done')[0], "target property is the element that was clicked");
<ide> });
<ide>
<del>QUnit.test("events should stop propagating if the view is destroyed", function() {
<add>QUnit.skip("events should stop propagating if the view is destroyed", function() {
<ide> var parentViewReceived, receivedEvent;
<ide>
<ide> var parentView = ContainerView.create({
<ide> QUnit.test("events should stop propagating if the view is destroyed", function()
<ide> ok(!parentViewReceived, "parent view does not receive the event");
<ide> });
<ide>
<del>QUnit.test('should not interfere with event propagation of virtualViews', function() {
<add>QUnit.skip('should not interfere with event propagation of virtualViews', function() {
<ide> var receivedEvent;
<ide>
<ide> var view = View.create({
<ide> QUnit.test('should not interfere with event propagation of virtualViews', functi
<ide> deepEqual(receivedEvent && receivedEvent.target, jQuery('#propagate-test-div')[0], 'target property is the element that was clicked');
<ide> });
<ide>
<del>QUnit.test("should dispatch events to nearest event manager", function() {
<add>QUnit.skip("should dispatch events to nearest event manager", function() {
<ide> var receivedEvent=0;
<ide> view = ContainerView.create({
<ide> render(buffer) {
<ide><path>packages/ember-views/tests/system/ext_test.js
<ide> import View from "ember-views/views/view";
<ide>
<ide> QUnit.module("Ember.View additions to run queue");
<ide>
<del>QUnit.test("View hierarchy is done rendering to DOM when functions queued in afterRender execute", function() {
<add>QUnit.skip("View hierarchy is done rendering to DOM when functions queued in afterRender execute", function() {
<ide> var didInsert = 0;
<ide> var childView = View.create({
<ide> elementId: 'child_view',
<ide><path>packages/ember-views/tests/system/view_utils_test.js
<ide> QUnit.module("ViewUtils", {
<ide> });
<ide>
<ide>
<del>QUnit.test("getViewClientRects", function() {
<add>QUnit.skip("getViewClientRects", function() {
<ide> if (!hasGetClientRects || !ClientRectListCtor) {
<ide> ok(true, "The test environment does not support the DOM API required to run this test.");
<ide> return;
<ide> QUnit.test("getViewClientRects", function() {
<ide> ok(Ember.ViewUtils.getViewClientRects(view) instanceof ClientRectListCtor);
<ide> });
<ide>
<del>QUnit.test("getViewBoundingClientRect", function() {
<add>QUnit.skip("getViewBoundingClientRect", function() {
<ide> if (!hasGetBoundingClientRect || !ClientRectCtor) {
<ide> ok(true, "The test environment does not support the DOM API required to run this test.");
<ide> return;
<ide><path>packages/ember-views/tests/views/collection_test.js
<ide> QUnit.test("should render a view for each item in its content array", function()
<ide> equal(view.$('div').length, 4);
<ide> });
<ide>
<del>QUnit.test("should render the emptyView if content array is empty (view class)", function() {
<add>QUnit.skip("should render the emptyView if content array is empty (view class)", function() {
<ide> view = CollectionView.create({
<ide> tagName: 'del',
<ide> content: Ember.A(),
<ide> QUnit.test("should render the emptyView if content array is empty (view class)",
<ide> ok(view.$().find('kbd:contains("OY SORRY GUVNAH")').length, "displays empty view");
<ide> });
<ide>
<del>QUnit.test("should render the emptyView if content array is empty (view instance)", function() {
<add>QUnit.skip("should render the emptyView if content array is empty (view instance)", function() {
<ide> view = CollectionView.create({
<ide> tagName: 'del',
<ide> content: Ember.A(),
<ide> QUnit.test("should render the emptyView if content array is empty (view instance
<ide> ok(view.$().find('kbd:contains("OY SORRY GUVNAH")').length, "displays empty view");
<ide> });
<ide>
<del>QUnit.test("should be able to override the tag name of itemViewClass even if tag is in default mapping", function() {
<add>QUnit.skip("should be able to override the tag name of itemViewClass even if tag is in default mapping", function() {
<ide> view = CollectionView.create({
<ide> tagName: 'del',
<ide> content: Ember.A(['NEWS GUVNAH']),
<ide> QUnit.test("should be able to override the tag name of itemViewClass even if tag
<ide> ok(view.$().find('kbd:contains("NEWS GUVNAH")').length, "displays the item view with proper tag name");
<ide> });
<ide>
<del>QUnit.test("should allow custom item views by setting itemViewClass", function() {
<add>QUnit.skip("should allow custom item views by setting itemViewClass", function() {
<ide> var passedContents = [];
<ide> view = CollectionView.create({
<ide> content: Ember.A(['foo', 'bar', 'baz']),
<ide> QUnit.test("should allow custom item views by setting itemViewClass", function()
<ide> });
<ide> });
<ide>
<del>QUnit.test("should insert a new item in DOM when an item is added to the content array", function() {
<add>QUnit.skip("should insert a new item in DOM when an item is added to the content array", function() {
<ide> var content = Ember.A(['foo', 'bar', 'baz']);
<ide>
<ide> view = CollectionView.create({
<ide> QUnit.test("should insert a new item in DOM when an item is added to the content
<ide> equal(trim(view.$(':nth-child(2)').text()), 'quux');
<ide> });
<ide>
<del>QUnit.test("should remove an item from DOM when an item is removed from the content array", function() {
<add>QUnit.skip("should remove an item from DOM when an item is removed from the content array", function() {
<ide> var content = Ember.A(['foo', 'bar', 'baz']);
<ide>
<ide> view = CollectionView.create({
<ide> QUnit.test("should remove an item from DOM when an item is removed from the cont
<ide> });
<ide> });
<ide>
<del>QUnit.test("it updates the view if an item is replaced", function() {
<add>QUnit.skip("it updates the view if an item is replaced", function() {
<ide> var content = Ember.A(['foo', 'bar', 'baz']);
<ide> view = CollectionView.create({
<ide> content: content,
<ide> QUnit.test("it updates the view if an item is replaced", function() {
<ide> });
<ide> });
<ide>
<del>QUnit.test("can add and replace in the same runloop", function() {
<add>QUnit.skip("can add and replace in the same runloop", function() {
<ide> var content = Ember.A(['foo', 'bar', 'baz']);
<ide> view = CollectionView.create({
<ide> content: content,
<ide> QUnit.test("can add and replace in the same runloop", function() {
<ide>
<ide> });
<ide>
<del>QUnit.test("can add and replace the object before the add in the same runloop", function() {
<add>QUnit.skip("can add and replace the object before the add in the same runloop", function() {
<ide> var content = Ember.A(['foo', 'bar', 'baz']);
<ide> view = CollectionView.create({
<ide> content: content,
<ide> QUnit.test("can add and replace the object before the add in the same runloop",
<ide> });
<ide> });
<ide>
<del>QUnit.test("can add and replace complicatedly", function() {
<add>QUnit.skip("can add and replace complicatedly", function() {
<ide> var content = Ember.A(['foo', 'bar', 'baz']);
<ide> view = CollectionView.create({
<ide> content: content,
<ide> QUnit.test("can add and replace complicatedly", function() {
<ide> });
<ide> });
<ide>
<del>QUnit.test("can add and replace complicatedly harder", function() {
<add>QUnit.skip("can add and replace complicatedly harder", function() {
<ide> var content = Ember.A(['foo', 'bar', 'baz']);
<ide> view = CollectionView.create({
<ide> content: content,
<ide> QUnit.test("can add and replace complicatedly harder", function() {
<ide> });
<ide> });
<ide>
<del>QUnit.test("should allow changes to content object before layer is created", function() {
<add>QUnit.skip("should allow changes to content object before layer is created", function() {
<ide> view = CollectionView.create({
<ide> content: null
<ide> });
<ide> QUnit.test("should allow changes to content object before layer is created", fun
<ide> ok(view.$().children().length);
<ide> });
<ide>
<del>QUnit.test("should fire life cycle events when elements are added and removed", function() {
<add>QUnit.skip("should fire life cycle events when elements are added and removed", function() {
<ide> var view;
<ide> var didInsertElement = 0;
<ide> var willDestroyElement = 0;
<ide> QUnit.test("should fire life cycle events when elements are added and removed",
<ide> equal(destroy, 8);
<ide> });
<ide>
<del>QUnit.test("should allow changing content property to be null", function() {
<add>QUnit.skip("should allow changing content property to be null", function() {
<ide> view = CollectionView.create({
<ide> content: Ember.A([1, 2, 3]),
<ide>
<ide> QUnit.test("should allow changing content property to be null", function() {
<ide> equal(trim(view.$().children().text()), "(empty)", "should display empty view");
<ide> });
<ide>
<del>QUnit.test("should allow items to access to the CollectionView's current index in the content array", function() {
<add>QUnit.skip("should allow items to access to the CollectionView's current index in the content array", function() {
<ide> view = CollectionView.create({
<ide> content: Ember.A(['zero', 'one', 'two']),
<ide> itemViewClass: View.extend({
<ide> QUnit.test("should allow items to access to the CollectionView's current index i
<ide> deepEqual(view.$(':nth-child(3)').text(), "2");
<ide> });
<ide>
<del>QUnit.test("should allow declaration of itemViewClass as a string", function() {
<add>QUnit.skip("should allow declaration of itemViewClass as a string", function() {
<ide> var container = {
<ide> lookupFactory() {
<ide> return Ember.View.extend();
<ide> QUnit.test("should allow declaration of itemViewClass as a string", function() {
<ide> equal(view.$('.ember-view').length, 3);
<ide> });
<ide>
<del>QUnit.test("should not render the emptyView if content is emptied and refilled in the same run loop", function() {
<add>QUnit.skip("should not render the emptyView if content is emptied and refilled in the same run loop", function() {
<ide> view = CollectionView.create({
<ide> tagName: 'div',
<ide> content: Ember.A(['NEWS GUVNAH']),
<ide> QUnit.test("a array_proxy that backs an sorted array_controller that backs a col
<ide> });
<ide> });
<ide>
<del>QUnit.test("when a collection view is emptied, deeply nested views elements are not removed from the DOM and then destroyed again", function() {
<add>QUnit.skip("when a collection view is emptied, deeply nested views elements are not removed from the DOM and then destroyed again", function() {
<ide> var assertProperDestruction = Mixin.create({
<ide> destroyElement() {
<ide> if (this._state === 'inDOM') {
<ide> QUnit.test("when a collection view is emptied, deeply nested views elements are
<ide> });
<ide> });
<ide>
<del>QUnit.test("should render the emptyView if content array is empty and emptyView is given as string", function() {
<add>QUnit.skip("should render the emptyView if content array is empty and emptyView is given as string", function() {
<ide> Ember.lookup = {
<ide> App: {
<ide> EmptyView: View.extend({
<ide> QUnit.test("should render the emptyView if content array is empty and emptyView
<ide> ok(view.$().find('kbd:contains("THIS IS AN EMPTY VIEW")').length, "displays empty view");
<ide> });
<ide>
<del>QUnit.test("should lookup against the container if itemViewClass is given as a string", function() {
<add>QUnit.skip("should lookup against the container if itemViewClass is given as a string", function() {
<ide> var ItemView = View.extend({
<ide> render(buf) {
<ide> buf.push(get(this, 'content'));
<ide> QUnit.test("should lookup against the container if itemViewClass is given as a s
<ide> }
<ide> });
<ide>
<del>QUnit.test("should lookup only global path against the container if itemViewClass is given as a string", function() {
<add>QUnit.skip("should lookup only global path against the container if itemViewClass is given as a string", function() {
<ide> var ItemView = View.extend({
<ide> render(buf) {
<ide> buf.push(get(this, 'content'));
<ide> QUnit.test("should lookup only global path against the container if itemViewClas
<ide> }
<ide> });
<ide>
<del>QUnit.test("should lookup against the container and render the emptyView if emptyView is given as string and content array is empty ", function() {
<add>QUnit.skip("should lookup against the container and render the emptyView if emptyView is given as string and content array is empty ", function() {
<ide> var EmptyView = View.extend({
<ide> tagName: 'kbd',
<ide> render(buf) {
<ide> QUnit.test("should lookup against the container and render the emptyView if empt
<ide> }
<ide> });
<ide>
<del>QUnit.test("should lookup from only global path against the container if emptyView is given as string and content array is empty ", function() {
<add>QUnit.skip("should lookup from only global path against the container if emptyView is given as string and content array is empty ", function() {
<ide> var EmptyView = View.extend({
<ide> render(buf) {
<ide> buf.push("EMPTY");
<ide><path>packages/ember-views/tests/views/component_test.js
<ide> QUnit.test("The context of an Ember.Component is itself", function() {
<ide> strictEqual(component, component.get('context'), "A component's context is itself");
<ide> });
<ide>
<del>QUnit.test("The controller (target of `action`) of an Ember.Component is itself", function() {
<add>QUnit.skip("The controller (target of `action`) of an Ember.Component is itself", function() {
<ide> strictEqual(component, component.get('controller'), "A component's controller is itself");
<ide> });
<ide>
<ide> QUnit.test("Calling sendAction on a component without an action defined does not
<ide> equal(sendCount, 0, "addItem action was not invoked");
<ide> });
<ide>
<del>QUnit.test("Calling sendAction on a component with an action defined calls send on the controller", function() {
<add>QUnit.skip("Calling sendAction on a component with an action defined calls send on the controller", function() {
<ide> set(component, 'action', "addItem");
<ide>
<ide> component.sendAction();
<ide> QUnit.test("Calling sendAction on a component with an action defined calls send
<ide> equal(actionCounts['addItem'], 1, "addItem event was sent once");
<ide> });
<ide>
<del>QUnit.test("Calling sendAction with a named action uses the component's property as the action name", function() {
<add>QUnit.skip("Calling sendAction with a named action uses the component's property as the action name", function() {
<ide> set(component, 'playing', "didStartPlaying");
<ide> set(component, 'action', "didDoSomeBusiness");
<ide>
<ide> QUnit.test("Calling sendAction when the action name is not a string raises an ex
<ide> });
<ide> });
<ide>
<del>QUnit.test("Calling sendAction on a component with a context", function() {
<add>QUnit.skip("Calling sendAction on a component with a context", function() {
<ide> set(component, 'playing', "didStartPlaying");
<ide>
<ide> var testContext = { song: 'She Broke My Ember' };
<ide> QUnit.test("Calling sendAction on a component with a context", function() {
<ide> deepEqual(actionArguments, [testContext], "context was sent with the action");
<ide> });
<ide>
<del>QUnit.test("Calling sendAction on a component with multiple parameters", function() {
<add>QUnit.skip("Calling sendAction on a component with multiple parameters", function() {
<ide> set(component, 'playing', "didStartPlaying");
<ide>
<ide> var firstContext = { song: 'She Broke My Ember' };
<ide><path>packages/ember-views/tests/views/instrumentation_test.js
<ide> QUnit.test("generates the proper instrumentation details when called directly",
<ide> confirmPayload(payload, view);
<ide> });
<ide>
<del>QUnit.test("should add ember-view to views", function() {
<add>QUnit.skip("should add ember-view to views", function() {
<ide> run(view, 'createElement');
<ide>
<ide> confirmPayload(beforeCalls[0], view);
<ide><path>packages/ember-views/tests/views/metamorph_view_test.js
<ide> QUnit.module("Metamorph views", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("a Metamorph view is not a view's parentView", function() {
<add>QUnit.skip("a Metamorph view is not a view's parentView", function() {
<ide> childView = EmberView.create({
<ide> render(buffer) {
<ide> buffer.push("<p>Bye bros</p>");
<ide> QUnit.module("Metamorph views correctly handle DOM", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("a metamorph view generates without a DOM node", function() {
<add>QUnit.skip("a metamorph view generates without a DOM node", function() {
<ide> var meta = jQuery("> h2", "#" + get(view, 'elementId'));
<ide>
<ide> equal(meta.length, 1, "The metamorph element should be directly inside its parent");
<ide> QUnit.test("a metamorph view can be removed from the DOM", function() {
<ide> equal(meta.length, 0, "the associated DOM was removed");
<ide> });
<ide>
<del>QUnit.test("a metamorph view can be rerendered", function() {
<add>QUnit.skip("a metamorph view can be rerendered", function() {
<ide> equal(jQuery('#from-meta').text(), "Jason", "precond - renders to the DOM");
<ide>
<ide> set(metamorphView, 'powerRanger', 'Trini');
<ide> QUnit.test("a metamorph view can be rerendered", function() {
<ide> // Redefining without setup/teardown
<ide> QUnit.module("Metamorph views correctly handle DOM");
<ide>
<del>QUnit.test("a metamorph view calls its children's willInsertElement and didInsertElement", function() {
<add>QUnit.skip("a metamorph view calls its children's willInsertElement and didInsertElement", function() {
<ide> var parentView;
<ide> var willInsertElementCalled = false;
<ide> var didInsertElementCalled = false;
<ide><path>packages/ember-views/tests/views/select_test.js
<ide> QUnit.test("should become disabled if the disabled attribute is changed", functi
<ide> ok(!select.element.disabled, 'disabled property is falsy');
<ide> });
<ide>
<del>QUnit.test("can have options", function() {
<add>QUnit.skip("can have options", function() {
<ide> select.set('content', Ember.A([1, 2, 3]));
<ide>
<ide> append();
<ide> QUnit.test("select name is updated when setting name property of view", function
<ide> equal(select.$().attr('name'), "bar", "updates select after name changes");
<ide> });
<ide>
<del>QUnit.test("can specify the property path for an option's label and value", function() {
<add>QUnit.skip("can specify the property path for an option's label and value", function() {
<ide> select.set('content', Ember.A([
<ide> { id: 1, firstName: 'Yehuda' },
<ide> { id: 2, firstName: 'Tom' }
<ide> QUnit.test("can specify the property path for an option's label and value", func
<ide> deepEqual(map(select.$('option').toArray(), function(el) { return jQuery(el).attr('value'); }), ["1", "2"], "Options should have values");
<ide> });
<ide>
<del>QUnit.test("can retrieve the current selected option when multiple=false", function() {
<add>QUnit.skip("can retrieve the current selected option when multiple=false", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide>
<ide> QUnit.test("can retrieve the current selected option when multiple=false", funct
<ide> equal(select.get('selection'), tom, "On change, the new option should be selected");
<ide> });
<ide>
<del>QUnit.test("can retrieve the current selected options when multiple=true", function() {
<add>QUnit.skip("can retrieve the current selected options when multiple=true", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide> var david = { id: 3, firstName: 'David' };
<ide> QUnit.test("can retrieve the current selected options when multiple=true", funct
<ide> deepEqual(select.get('selection'), [tom, david], "On change, the new options should be selected");
<ide> });
<ide>
<del>QUnit.test("selection can be set when multiple=false", function() {
<add>QUnit.skip("selection can be set when multiple=false", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide>
<ide> QUnit.test("selection can be set when multiple=false", function() {
<ide> equal(select.$()[0].selectedIndex, 0, "After changing it, selection should be correct");
<ide> });
<ide>
<del>QUnit.test("selection can be set from a Promise when multiple=false", function() {
<add>QUnit.skip("selection can be set from a Promise when multiple=false", function() {
<ide> expect(1);
<ide>
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> QUnit.test("selection can be set from a Promise when multiple=false", function()
<ide> equal(select.$()[0].selectedIndex, 1, "Should select from Promise content");
<ide> });
<ide>
<del>QUnit.test("selection from a Promise don't overwrite newer selection once resolved, when multiple=false", function() {
<add>QUnit.skip("selection from a Promise don't overwrite newer selection once resolved, when multiple=false", function() {
<ide> expect(1);
<ide>
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> QUnit.test("selection from a Promise don't overwrite newer selection once resolv
<ide> append();
<ide> });
<ide>
<del>QUnit.test("selection from a Promise resolving to null should not select when multiple=false", function() {
<add>QUnit.skip("selection from a Promise resolving to null should not select when multiple=false", function() {
<ide> expect(1);
<ide>
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> QUnit.test("selection from a Promise resolving to null should not select when mu
<ide> equal(select.$()[0].selectedIndex, -1, "Should not select any object when the Promise resolve to null");
<ide> });
<ide>
<del>QUnit.test("selection can be set when multiple=true", function() {
<add>QUnit.skip("selection can be set when multiple=true", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide> var david = { id: 3, firstName: 'David' };
<ide> QUnit.test("selection can be set when multiple=true", function() {
<ide> deepEqual(select.get('selection'), [yehuda], "After changing it, selection should be correct");
<ide> });
<ide>
<del>QUnit.test("selection can be set when multiple=true and prompt", function() {
<add>QUnit.skip("selection can be set when multiple=true and prompt", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide> var david = { id: 3, firstName: 'David' };
<ide> QUnit.test("selection can be set when multiple=true and prompt", function() {
<ide> deepEqual(select.get('selection'), [yehuda], "After changing it, selection should be correct");
<ide> });
<ide>
<del>QUnit.test("multiple selections can be set when multiple=true", function() {
<add>QUnit.skip("multiple selections can be set when multiple=true", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide> var david = { id: 3, firstName: 'David' };
<ide> QUnit.test("multiple selections can be set when multiple=true", function() {
<ide> "After changing it, selection should be correct");
<ide> });
<ide>
<del>QUnit.test("multiple selections can be set by changing in place the selection array when multiple=true", function() {
<add>QUnit.skip("multiple selections can be set by changing in place the selection array when multiple=true", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide> var david = { id: 3, firstName: 'David' };
<ide> QUnit.test("multiple selections can be set by changing in place the selection ar
<ide> });
<ide>
<ide>
<del>QUnit.test("multiple selections can be set indirectly via bindings and in-place when multiple=true (issue #1058)", function() {
<add>QUnit.skip("multiple selections can be set indirectly via bindings and in-place when multiple=true (issue #1058)", function() {
<ide> var indirectContent = EmberObject.create();
<ide>
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide> QUnit.test("multiple selections can be set indirectly via bindings and in-place
<ide> deepEqual(select.get('selection'), [cyril], "After updating bound selection, selection should be correct");
<ide> });
<ide>
<del>QUnit.test("select with group can group options", function() {
<add>QUnit.skip("select with group can group options", function() {
<ide> var content = Ember.A([
<ide> { firstName: 'Yehuda', organization: 'Tilde' },
<ide> { firstName: 'Tom', organization: 'Tilde' },
<ide> QUnit.test("select with group can group options", function() {
<ide> equal(trim(select.$('optgroup').last().text()), 'Keith');
<ide> });
<ide>
<del>QUnit.test("select with group doesn't break options", function() {
<add>QUnit.skip("select with group doesn't break options", function() {
<ide> var content = Ember.A([
<ide> { id: 1, firstName: 'Yehuda', organization: 'Tilde' },
<ide> { id: 2, firstName: 'Tom', organization: 'Tilde' },
<ide> QUnit.test("select with group doesn't break options", function() {
<ide> deepEqual(select.get('selection'), content.get('firstObject'));
<ide> });
<ide>
<del>QUnit.test("select with group observes its content", function() {
<add>QUnit.skip("select with group observes its content", function() {
<ide> var wycats = { firstName: 'Yehuda', organization: 'Tilde' };
<ide> var content = Ember.A([
<ide> wycats
<ide> QUnit.test("select with group whose content is undefined doesn't breaks", functi
<ide> equal(select.$('optgroup').length, 0);
<ide> });
<ide>
<del>QUnit.test("selection uses the same array when multiple=true", function() {
<add>QUnit.skip("selection uses the same array when multiple=true", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide> var david = { id: 3, firstName: 'David' };
<ide> QUnit.test("selection uses the same array when multiple=true", function() {
<ide> deepEqual(selection, [tom,david], "On change the original selection array is updated");
<ide> });
<ide>
<del>QUnit.test("Ember.SelectedOption knows when it is selected when multiple=false", function() {
<add>QUnit.skip("Ember.SelectedOption knows when it is selected when multiple=false", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide> var david = { id: 3, firstName: 'David' };
<ide> QUnit.test("Ember.SelectedOption knows when it is selected when multiple=false",
<ide> deepEqual(selectedOptions(), [false, false, false, true], "After changing it, selection should be correct");
<ide> });
<ide>
<del>QUnit.test("Ember.SelectedOption knows when it is selected when multiple=true", function() {
<add>QUnit.skip("Ember.SelectedOption knows when it is selected when multiple=true", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide> var david = { id: 3, firstName: 'David' };
<ide> QUnit.test("Ember.SelectedOption knows when it is selected when multiple=true",
<ide> deepEqual(selectedOptions(), [false, true, true, false], "After changing it, selection should be correct");
<ide> });
<ide>
<del>QUnit.test("Ember.SelectedOption knows when it is selected when multiple=true and options are primitives", function() {
<add>QUnit.skip("Ember.SelectedOption knows when it is selected when multiple=true and options are primitives", function() {
<ide> run(function() {
<ide> select.set('content', Ember.A([1, 2, 3, 4]));
<ide> select.set('multiple', true);
<ide> QUnit.test("Ember.SelectedOption knows when it is selected when multiple=true an
<ide> deepEqual(selectedOptions(), [false, true, true, false], "After changing it, selection should be correct");
<ide> });
<ide>
<del>QUnit.test("a prompt can be specified", function() {
<add>QUnit.skip("a prompt can be specified", function() {
<ide> var yehuda = { id: 1, firstName: 'Yehuda' };
<ide> var tom = { id: 2, firstName: 'Tom' };
<ide>
<ide> QUnit.test("handles null content", function() {
<ide> equal(select.get('element').selectedIndex, -1, "should have no selection");
<ide> });
<ide>
<del>QUnit.test("valueBinding handles 0 as initiated value (issue #2763)", function() {
<add>QUnit.skip("valueBinding handles 0 as initiated value (issue #2763)", function() {
<ide> var indirectData = EmberObject.create({
<ide> value: 0
<ide> });
<ide> QUnit.test("valueBinding handles 0 as initiated value (issue #2763)", function()
<ide> equal(select.get('value'), 0, "Value property should equal 0");
<ide> });
<ide>
<del>QUnit.test("should be able to select an option and then reselect the prompt", function() {
<add>QUnit.skip("should be able to select an option and then reselect the prompt", function() {
<ide> run(function() {
<ide> select.set('content', Ember.A(['one', 'two', 'three']));
<ide> select.set('prompt', 'Select something');
<ide> QUnit.test("should be able to select an option and then reselect the prompt", fu
<ide> equal(select.$()[0].selectedIndex, 0);
<ide> });
<ide>
<del>QUnit.test("should be able to get the current selection's value", function() {
<add>QUnit.skip("should be able to get the current selection's value", function() {
<ide> run(function() {
<ide> select.set('content', Ember.A([
<ide> { label: 'Yehuda Katz', value: 'wycats' },
<ide> QUnit.test("should be able to get the current selection's value", function() {
<ide> equal(select.get('value'), 'wycats');
<ide> });
<ide>
<del>QUnit.test("should be able to set the current selection by value", function() {
<add>QUnit.skip("should be able to set the current selection by value", function() {
<ide> var ebryn = { label: 'Erik Bryn', value: 'ebryn' };
<ide>
<ide> run(function() {
<ide><path>packages/ember-views/tests/views/view/append_to_test.js
<ide> QUnit.test("should be added to the specified element when calling appendTo()", f
<ide> ok(viewElem.length > 0, "creates and appends the view's element");
<ide> });
<ide>
<del>QUnit.test("should be added to the document body when calling append()", function() {
<add>QUnit.skip("should be added to the document body when calling append()", function() {
<ide> view = View.create({
<ide> render(buffer) {
<ide> buffer.push("foo bar baz");
<ide> QUnit.test("raises an assert when a target does not exist in the DOM", function(
<ide> });
<ide> });
<ide>
<del>QUnit.test("append calls willInsertElement and didInsertElement callbacks", function() {
<add>QUnit.skip("append calls willInsertElement and didInsertElement callbacks", function() {
<ide> var willInsertElementCalled = false;
<ide> var willInsertElementCalledInChild = false;
<ide> var didInsertElementCalled = false;
<ide> QUnit.test("append calls willInsertElement and didInsertElement callbacks", func
<ide> ok(didInsertElementCalled, "didInsertElement called");
<ide> });
<ide>
<del>QUnit.test("remove removes an element from the DOM", function() {
<add>QUnit.skip("remove removes an element from the DOM", function() {
<ide> willDestroyCalled = 0;
<ide>
<ide> view = View.create({
<ide> QUnit.test("remove removes an element from the DOM", function() {
<ide> equal(willDestroyCalled, 1, "the willDestroyElement hook was called once");
<ide> });
<ide>
<del>QUnit.test("destroy more forcibly removes the view", function() {
<add>QUnit.skip("destroy more forcibly removes the view", function() {
<ide> willDestroyCalled = 0;
<ide>
<ide> view = View.create({
<ide> QUnit.module("EmberView - removing views in a view hierarchy", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("remove removes child elements from the DOM", function() {
<add>QUnit.skip("remove removes child elements from the DOM", function() {
<ide> ok(!get(childView, 'element'), "precond - should not have an element");
<ide>
<ide> run(function() {
<ide> QUnit.test("remove removes child elements from the DOM", function() {
<ide> equal(willDestroyCalled, 1, "the willDestroyElement hook was called once");
<ide> });
<ide>
<del>QUnit.test("destroy more forcibly removes child views", function() {
<add>QUnit.skip("destroy more forcibly removes child views", function() {
<ide> ok(!get(childView, 'element'), "precond - should not have an element");
<ide>
<ide> run(function() {
<ide><path>packages/ember-views/tests/views/view/attribute_bindings_test.js
<ide> QUnit.test("should update attribute bindings with micro syntax", function() {
<ide> ok(!view.$().prop('disabled'), "updates disabled property when false");
<ide> });
<ide>
<del>QUnit.test("should allow namespaced attributes in micro syntax", function () {
<add>QUnit.skip("should allow namespaced attributes in micro syntax", function () {
<ide> view = EmberView.create({
<ide> attributeBindings: ['xlinkHref:xlink:href'],
<ide> xlinkHref: '/foo.png'
<ide> QUnit.test("should allow binding to String objects", function() {
<ide> ok(!view.$().attr('foo'), "removes foo attribute when null");
<ide> });
<ide>
<del>QUnit.test("should teardown observers on rerender", function() {
<add>QUnit.skip("should teardown observers on rerender", function() {
<ide> view = EmberView.create({
<ide> attributeBindings: ['foo'],
<ide> classNameBindings: ['foo'],
<ide> QUnit.test("handles attribute bindings for properties", function() {
<ide> equal(!!view.$().prop('checked'), false, 'changes to unchecked');
<ide> });
<ide>
<del>QUnit.test("handles `undefined` value for properties", function() {
<add>QUnit.skip("handles `undefined` value for properties", function() {
<ide> view = EmberView.create({
<ide> tagName: 'input',
<ide> attributeBindings: ['value'],
<ide> QUnit.test("attributeBindings should not fail if view has been destroyed", funct
<ide> ok(!error, error);
<ide> });
<ide>
<del>QUnit.test("asserts if an attributeBinding is setup on class", function() {
<add>QUnit.skip("asserts if an attributeBinding is setup on class", function() {
<ide> view = EmberView.create({
<ide> attributeBindings: ['class']
<ide> });
<ide><path>packages/ember-views/tests/views/view/child_views_test.js
<ide> QUnit.module('tests/views/view/child_views_tests.js', {
<ide> // parent element
<ide>
<ide> // no parent element, no buffer, no element
<del>QUnit.test("should render an inserted child view when the child is inserted before a DOM element is created", function() {
<add>QUnit.skip("should render an inserted child view when the child is inserted before a DOM element is created", function() {
<ide> run(function() {
<ide> parentView.append();
<ide> });
<ide>
<ide> equal(parentView.$().text(), 'Ember', 'renders the child view after the parent view');
<ide> });
<ide>
<del>QUnit.test("should not duplicate childViews when rerendering", function() {
<add>QUnit.skip("should not duplicate childViews when rerendering", function() {
<ide>
<ide> var Inner = EmberView.extend({
<ide> template() { return ''; }
<ide><path>packages/ember-views/tests/views/view/class_name_bindings_test.js
<ide> QUnit.module("EmberView - Class Name Bindings", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("should apply bound class names to the element", function() {
<add>QUnit.skip("should apply bound class names to the element", function() {
<ide> view = EmberView.create({
<ide> classNameBindings: ['priority', 'isUrgent', 'isClassified:classified',
<ide> 'canIgnore', 'messages.count', 'messages.resent:is-resent',
<ide> QUnit.test("should apply bound class names to the element", function() {
<ide> ok(!view.$().hasClass('disabled'), "does not add class name for negated binding");
<ide> });
<ide>
<del>QUnit.test("should add, remove, or change class names if changed after element is created", function() {
<add>QUnit.skip("should add, remove, or change class names if changed after element is created", function() {
<ide> view = EmberView.create({
<ide> classNameBindings: ['priority', 'isUrgent', 'isClassified:classified',
<ide> 'canIgnore', 'messages.count', 'messages.resent:is-resent',
<ide> QUnit.test("should add, remove, or change class names if changed after element i
<ide> ok(view.$().hasClass('disabled'), "adds negated class name for negated binding");
<ide> });
<ide>
<del>QUnit.test(":: class name syntax works with an empty true class", function() {
<add>QUnit.skip(":: class name syntax works with an empty true class", function() {
<ide> view = EmberView.create({
<ide> isEnabled: false,
<ide> classNameBindings: ['isEnabled::not-enabled']
<ide> QUnit.test("classNames should not be duplicated on rerender", function() {
<ide> equal(view.$().attr('class'), 'ember-view high');
<ide> });
<ide>
<del>QUnit.test("classNameBindings should work when the binding property is updated and the view has been removed of the DOM", function() {
<add>QUnit.skip("classNameBindings should work when the binding property is updated and the view has been removed of the DOM", function() {
<ide> run(function() {
<ide> view = EmberView.create({
<ide> classNameBindings: ['priority'],
<ide> QUnit.test("classNameBindings should work when the binding property is updated a
<ide>
<ide> });
<ide>
<del>QUnit.test("classNames removed by a classNameBindings observer should not re-appear on rerender", function() {
<add>QUnit.skip("classNames removed by a classNameBindings observer should not re-appear on rerender", function() {
<ide> view = EmberView.create({
<ide> classNameBindings: ['isUrgent'],
<ide> isUrgent: true
<ide> QUnit.test("classNames removed by a classNameBindings observer should not re-app
<ide> equal(view.$().attr('class'), 'ember-view');
<ide> });
<ide>
<del>QUnit.test("classNameBindings lifecycle test", function() {
<add>QUnit.skip("classNameBindings lifecycle test", function() {
<ide> run(function() {
<ide> view = EmberView.create({
<ide> classNameBindings: ['priority'],
<ide> QUnit.test("classNameBindings should not fail if view has been destroyed", funct
<ide> ok(!error, error);
<ide> });
<ide>
<del>QUnit.test("Providing a binding with a space in it asserts", function() {
<add>QUnit.skip("Providing a binding with a space in it asserts", function() {
<ide> view = EmberView.create({
<ide> classNameBindings: 'i:think:i am:so:clever'
<ide> });
<ide><path>packages/ember-views/tests/views/view/context_test.js
<ide> import ContainerView from "ember-views/views/container_view";
<ide>
<ide> QUnit.module("EmberView - context property");
<ide>
<del>QUnit.test("setting a controller on an inner view should change it context", function() {
<add>QUnit.skip("setting a controller on an inner view should change it context", function() {
<ide> var App = {};
<ide> var a = { name: 'a' };
<ide> var b = { name: 'b' };
<ide><path>packages/ember-views/tests/views/view/controller_test.js
<ide> import ContainerView from "ember-views/views/container_view";
<ide>
<ide> QUnit.module("Ember.View - controller property");
<ide>
<del>QUnit.test("controller property should be inherited from nearest ancestor with controller", function() {
<add>QUnit.skip("controller property should be inherited from nearest ancestor with controller", function() {
<ide> var grandparent = ContainerView.create();
<ide> var parent = ContainerView.create();
<ide> var child = ContainerView.create();
<ide><path>packages/ember-views/tests/views/view/create_child_view_test.js
<ide> QUnit.module("EmberView#createChildView", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("should create view from class with any passed attributes", function() {
<add>QUnit.skip("should create view from class with any passed attributes", function() {
<ide> var attrs = {
<ide> foo: "baz"
<ide> };
<ide> QUnit.test("should create property on parentView to a childView instance if prov
<ide> equal(get(view, 'someChildView'), newView);
<ide> });
<ide>
<del>QUnit.test("should update a view instances attributes, including the _parentView and container properties", function() {
<add>QUnit.skip("should update a view instances attributes, including the _parentView and container properties", function() {
<ide> var attrs = {
<ide> foo: "baz"
<ide> };
<ide> QUnit.test("should update a view instances attributes, including the _parentView
<ide> deepEqual(newView, myView);
<ide> });
<ide>
<del>QUnit.test("should create from string via container lookup", function() {
<add>QUnit.skip("should create from string via container lookup", function() {
<ide> var ChildViewClass = EmberView.extend();
<ide> var fullName = 'view:bro';
<ide>
<ide><path>packages/ember-views/tests/views/view/create_element_test.js
<ide> QUnit.test("returns the receiver", function() {
<ide> equal(ret, view, 'returns receiver');
<ide> });
<ide>
<del>QUnit.test('should assert if `tagName` is an empty string and `classNameBindings` are specified', function() {
<add>QUnit.skip('should assert if `tagName` is an empty string and `classNameBindings` are specified', function() {
<ide> expect(1);
<ide>
<ide> view = EmberView.create({
<ide> QUnit.test('should assert if `tagName` is an empty string and `classNameBindings
<ide> }, /You cannot use `classNameBindings` on a tag-less view/);
<ide> });
<ide>
<del>QUnit.test("calls render and turns resultant string into element", function() {
<add>QUnit.skip("calls render and turns resultant string into element", function() {
<ide> view = EmberView.create({
<ide> tagName: 'span',
<ide>
<ide> QUnit.test("calls render and turns resultant string into element", function() {
<ide> equal(elem.tagName.toString().toLowerCase(), 'span', 'has tagName from view');
<ide> });
<ide>
<del>QUnit.test("calls render and parses the buffer string in the right context", function() {
<add>QUnit.skip("calls render and parses the buffer string in the right context", function() {
<ide> expectDeprecation("Setting `childViews` on a Container is deprecated.");
<ide>
<ide> view = ContainerView.create({
<ide> QUnit.test("calls render and parses the buffer string in the right context", fun
<ide> equalHTML(elem.childNodes, '<script></script><tr><td>snorfblax</td></tr>', 'has innerHTML from context');
<ide> });
<ide>
<del>QUnit.test("does not wrap many tr children in tbody elements", function() {
<add>QUnit.skip("does not wrap many tr children in tbody elements", function() {
<ide> expectDeprecation("Setting `childViews` on a Container is deprecated.");
<ide>
<ide> view = ContainerView.create({
<ide><path>packages/ember-views/tests/views/view/destroy_element_test.js
<ide> QUnit.test("if it has no element, does nothing", function() {
<ide> equal(callCount, 0, 'did not invoke callback');
<ide> });
<ide>
<del>QUnit.test("if it has a element, calls willDestroyElement on receiver and child views then deletes the element", function() {
<add>QUnit.skip("if it has a element, calls willDestroyElement on receiver and child views then deletes the element", function() {
<ide> expectDeprecation("Setting `childViews` on a Container is deprecated.");
<ide>
<ide> var parentCount = 0;
<ide> QUnit.test("returns receiver", function() {
<ide> equal(ret, view, 'returns receiver');
<ide> });
<ide>
<del>QUnit.test("removes element from parentNode if in DOM", function() {
<add>QUnit.skip("removes element from parentNode if in DOM", function() {
<ide> view = EmberView.create();
<ide>
<ide> run(function() {
<ide><path>packages/ember-views/tests/views/view/element_test.js
<ide> QUnit.test("returns null if the view has no element and no parent view", functio
<ide> equal(get(view, 'element'), null, 'has no element');
<ide> });
<ide>
<del>QUnit.test("returns null if the view has no element and parent view has no element", function() {
<add>QUnit.skip("returns null if the view has no element and parent view has no element", function() {
<ide> expectDeprecation("Setting `childViews` on a Container is deprecated.");
<ide>
<ide> parentView = ContainerView.create({
<ide><path>packages/ember-views/tests/views/view/is_visible_test.js
<ide> QUnit.module("EmberView#isVisible", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("should hide views when isVisible is false", function() {
<add>QUnit.skip("should hide views when isVisible is false", function() {
<ide> view = EmberView.create({
<ide> isVisible: false
<ide> });
<ide> QUnit.test("should hide views when isVisible is false", function() {
<ide> });
<ide> });
<ide>
<del>QUnit.test("should hide element if isVisible is false before element is created", function() {
<add>QUnit.skip("should hide element if isVisible is false before element is created", function() {
<ide> view = EmberView.create({
<ide> isVisible: false
<ide> });
<ide> QUnit.module("EmberView#isVisible with Container", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("view should be notified after isVisible is set to false and the element has been hidden", function() {
<add>QUnit.skip("view should be notified after isVisible is set to false and the element has been hidden", function() {
<ide> run(function() {
<ide> view = View.create({ isVisible: false });
<ide> view.append();
<ide> QUnit.test("view should be notified after isVisible is set to false and the elem
<ide> equal(grandchildBecameVisible, 1);
<ide> });
<ide>
<del>QUnit.test("view should change visibility with a virtual childView", function() {
<del> view = View.create({
<del> isVisible: true,
<del> template: compile('<div {{bind-attr bing="tweep"}}></div>')
<del> });
<add>QUnit.skip("view should be notified after isVisible is set to false and the element has been hidden", function() {
<add> view = View.create({ isVisible: true });
<add> var childView = view.get('childViews').objectAt(0);
<ide>
<ide> run(function() {
<ide> view.append();
<ide> QUnit.test("view should change visibility with a virtual childView", function()
<ide> ok(view.$().is(':hidden'), "precond - view is now hidden");
<ide> });
<ide>
<del>QUnit.test("view should be notified after isVisible is set to true and the element has been shown", function() {
<add>QUnit.skip("view should be notified after isVisible is set to true and the element has been shown", function() {
<ide> view = View.create({ isVisible: false });
<ide>
<ide> run(function() {
<ide> QUnit.test("view should be notified after isVisible is set to true and the eleme
<ide> equal(grandchildBecameVisible, 1);
<ide> });
<ide>
<del>QUnit.test("if a view descends from a hidden view, making isVisible true should not trigger becameVisible", function() {
<add>QUnit.skip("if a view descends from a hidden view, making isVisible true should not trigger becameVisible", function() {
<ide> view = View.create({ isVisible: true });
<ide> var childView = view.get('childViews').objectAt(0);
<ide>
<ide> QUnit.test("if a view descends from a hidden view, making isVisible true should
<ide> equal(grandchildBecameVisible, 0, "the grandchild did not become visible");
<ide> });
<ide>
<del>QUnit.test("if a child view becomes visible while its parent is hidden, if its parent later becomes visible, it receives a becameVisible callback", function() {
<add>QUnit.skip("if a child view becomes visible while its parent is hidden, if its parent later becomes visible, it receives a becameVisible callback", function() {
<ide> view = View.create({ isVisible: false });
<ide> var childView = view.get('childViews').objectAt(0);
<ide>
<ide><path>packages/ember-views/tests/views/view/jquery_test.js
<ide> QUnit.test("returns jQuery object selecting element if provided", function() {
<ide> equal(jquery[0], get(view, 'element'), 'element should be element');
<ide> });
<ide>
<del>QUnit.test("returns jQuery object selecting element inside element if provided", function() {
<add>QUnit.skip("returns jQuery object selecting element inside element if provided", function() {
<ide> ok(get(view, 'element'), 'precond - should have element');
<ide>
<ide> var jquery = view.$('span');
<ide><path>packages/ember-views/tests/views/view/layout_test.js
<ide> QUnit.test("Layout views return throw if their layout cannot be found", function
<ide> }, /cantBeFound/);
<ide> });
<ide>
<del>QUnit.test("should call the function of the associated layout", function() {
<add>QUnit.skip("should call the function of the associated layout", function() {
<ide> var templateCalled = 0;
<ide> var layoutCalled = 0;
<ide>
<ide> QUnit.test("should call the function of the associated layout", function() {
<ide> equal(layoutCalled, 1, "layout is called when layout is present");
<ide> });
<ide>
<del>QUnit.test("should call the function of the associated template with itself as the context", function() {
<add>QUnit.skip("should call the function of the associated template with itself as the context", function() {
<ide> registry.register('template:testTemplate', function(dataSource) {
<ide> return "<h1 id='twas-called'>template was called for " + get(dataSource, 'personName') + "</h1>";
<ide> });
<ide> QUnit.test("should call the function of the associated template with itself as t
<ide> equal("template was called for Tom DAAAALE", view.$('#twas-called').text(), "the named template was called with the view as the data source");
<ide> });
<ide>
<del>QUnit.test("should fall back to defaultTemplate if neither template nor templateName are provided", function() {
<add>QUnit.skip("should fall back to defaultTemplate if neither template nor templateName are provided", function() {
<ide> var View;
<ide>
<ide> View = EmberView.extend({
<ide> QUnit.test("should fall back to defaultTemplate if neither template nor template
<ide> equal("template was called for Tom DAAAALE", view.$('#twas-called').text(), "the named template was called with the view as the data source");
<ide> });
<ide>
<del>QUnit.test("should not use defaultLayout if layout is provided", function() {
<add>QUnit.skip("should not use defaultLayout if layout is provided", function() {
<ide> var View;
<ide>
<ide> View = EmberView.extend({
<ide> QUnit.test("should not use defaultLayout if layout is provided", function() {
<ide> equal("foo", view.$().text(), "default layout was not printed");
<ide> });
<ide>
<del>QUnit.test("the template property is available to the layout template", function() {
<add>QUnit.skip("the template property is available to the layout template", function() {
<ide> view = EmberView.create({
<ide> template(context, options) {
<ide> options.data.buffer.push(" derp");
<ide><path>packages/ember-views/tests/views/view/nearest_of_type_test.js
<ide> QUnit.module("View#nearest*", {
<ide> }
<ide> });
<ide>
<del> QUnit.test("nearestOfType should find the closest view by view class", function() {
<add> QUnit.skip("nearestOfType should find the closest view by view class", function() {
<ide> var child;
<ide>
<ide> run(function() {
<ide> QUnit.module("View#nearest*", {
<ide> equal(child.nearestOfType(Parent), parentView, "finds closest view in the hierarchy by class");
<ide> });
<ide>
<del> QUnit.test("nearestOfType should find the closest view by mixin", function() {
<add> QUnit.skip("nearestOfType should find the closest view by mixin", function() {
<ide> var child;
<ide>
<ide> run(function() {
<ide> QUnit.module("View#nearest*", {
<ide> equal(child.nearestOfType(Mixin), parentView, "finds closest view in the hierarchy by class");
<ide> });
<ide>
<del> QUnit.test("nearestWithProperty should search immediate parent", function() {
<add> QUnit.skip("nearestWithProperty should search immediate parent", function() {
<ide> var childView;
<ide>
<ide> view = View.create({
<ide> QUnit.module("View#nearest*", {
<ide>
<ide> });
<ide>
<del> QUnit.test("nearestChildOf should be deprecated", function() {
<add> QUnit.skip("nearestChildOf should be deprecated", function() {
<ide> var child;
<ide>
<ide> run(function() {
<ide><path>packages/ember-views/tests/views/view/remove_test.js
<ide> QUnit.module("View#removeChild", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("returns receiver", function() {
<add>QUnit.skip("returns receiver", function() {
<ide> equal(parentView.removeChild(child), parentView, 'receiver');
<ide> });
<ide>
<del>QUnit.test("removes child from parent.childViews array", function() {
<add>QUnit.skip("removes child from parent.childViews array", function() {
<ide> ok(indexOf(get(parentView, 'childViews'), child)>=0, 'precond - has child in childViews array before remove');
<ide> parentView.removeChild(child);
<ide> ok(indexOf(get(parentView, 'childViews'), child)<0, 'removed child');
<ide> });
<ide>
<del>QUnit.test("sets parentView property to null", function() {
<add>QUnit.skip("sets parentView property to null", function() {
<ide> ok(get(child, 'parentView'), 'precond - has parentView');
<ide> parentView.removeChild(child);
<ide> ok(!get(child, 'parentView'), 'parentView is now null');
<ide> QUnit.module("View#removeFromParent", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("removes view from parent view", function() {
<add>QUnit.skip("removes view from parent view", function() {
<ide> expectDeprecation("Setting `childViews` on a Container is deprecated.");
<ide>
<ide> parentView = ContainerView.create({ childViews: [View] });
<ide> QUnit.test("removes view from parent view", function() {
<ide> equal(parentView.$('div').length, 0, "removes DOM element from parent");
<ide> });
<ide>
<del>QUnit.test("returns receiver", function() {
<add>QUnit.skip("returns receiver", function() {
<ide> expectDeprecation("Setting `childViews` on a Container is deprecated.");
<ide>
<ide> parentView = ContainerView.create({ childViews: [View] });
<ide> QUnit.test("does nothing if not in parentView", function() {
<ide> });
<ide>
<ide>
<del>QUnit.test("the DOM element is gone after doing append and remove in two separate runloops", function() {
<add>QUnit.skip("the DOM element is gone after doing append and remove in two separate runloops", function() {
<ide> view = View.create();
<ide> run(function() {
<ide> view.append();
<ide> QUnit.test("the DOM element is gone after doing append and remove in two separat
<ide> ok(viewElem.length === 0, "view's element doesn't exist in DOM");
<ide> });
<ide>
<del>QUnit.test("the DOM element is gone after doing append and remove in a single runloop", function() {
<add>QUnit.skip("the DOM element is gone after doing append and remove in a single runloop", function() {
<ide> view = View.create();
<ide> run(function() {
<ide> view.append();
<ide><path>packages/ember-views/tests/views/view/render_test.js
<ide> QUnit.module("EmberView#render", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("default implementation does not render child views", function() {
<add>QUnit.skip("default implementation does not render child views", function() {
<ide> expectDeprecation("Setting `childViews` on a Container is deprecated.");
<ide>
<ide> var rendered = 0;
<ide> QUnit.test("default implementation does not render child views", function() {
<ide>
<ide> });
<ide>
<del>QUnit.test("should invoke renderChildViews if layer is destroyed then re-rendered", function() {
<add>QUnit.skip("should invoke renderChildViews if layer is destroyed then re-rendered", function() {
<ide> expectDeprecation("Setting `childViews` on a Container is deprecated.");
<ide>
<ide> var rendered = 0;
<ide> QUnit.test("should not add role attribute unless one is specified", function() {
<ide> ok(view.$().attr('role') === undefined, "does not have a role attribute");
<ide> });
<ide>
<del>QUnit.test("should re-render if the context is changed", function() {
<add>QUnit.skip("should re-render if the context is changed", function() {
<ide> view = EmberView.create({
<ide> elementId: 'template-context-test',
<ide> context: { foo: "bar" },
<ide> QUnit.test("should re-render if the context is changed", function() {
<ide> equal(jQuery('#qunit-fixture #template-context-test').text(), "bang baz", "re-renders the view with the updated context");
<ide> });
<ide>
<del>QUnit.test("renders contained view with omitted start tag and parent view context", function() {
<add>QUnit.skip("renders contained view with omitted start tag and parent view context", function() {
<ide> expectDeprecation("Setting `childViews` on a Container is deprecated.");
<ide>
<ide> view = ContainerView.createWithMixins({
<ide><path>packages/ember-views/tests/views/view/template_test.js
<ide> QUnit.module("EmberView - Template Functionality", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("Template views return throw if their template cannot be found", function() {
<add>QUnit.skip("Template views return throw if their template cannot be found", function() {
<ide> view = EmberView.create({
<ide> templateName: 'cantBeFound',
<ide> container: { lookup() { } }
<ide> QUnit.test("Template views return throw if their template cannot be found", func
<ide> });
<ide>
<ide> if (typeof Handlebars === "object") {
<del> QUnit.test("should allow standard Handlebars template usage", function() {
<add> QUnit.skip("should allow standard Handlebars template usage", function() {
<ide> view = EmberView.create({
<ide> context: { name: "Erik" },
<ide> template: Handlebars.compile("Hello, {{name}}")
<ide> if (typeof Handlebars === "object") {
<ide> });
<ide> }
<ide>
<del>QUnit.test("should call the function of the associated template", function() {
<add>QUnit.skip("should call the function of the associated template", function() {
<ide> registry.register('template:testTemplate', function() {
<ide> return "<h1 id='twas-called'>template was called</h1>";
<ide> });
<ide> QUnit.test("should call the function of the associated template", function() {
<ide> ok(view.$('#twas-called').length, "the named template was called");
<ide> });
<ide>
<del>QUnit.test("should call the function of the associated template with itself as the context", function() {
<add>QUnit.skip("should call the function of the associated template with itself as the context", function() {
<ide> registry.register('template:testTemplate', function(dataSource) {
<ide> return "<h1 id='twas-called'>template was called for " + get(dataSource, 'personName') + "</h1>";
<ide> });
<ide> QUnit.test("should call the function of the associated template with itself as t
<ide> equal("template was called for Tom DAAAALE", view.$('#twas-called').text(), "the named template was called with the view as the data source");
<ide> });
<ide>
<del>QUnit.test("should fall back to defaultTemplate if neither template nor templateName are provided", function() {
<add>QUnit.skip("should fall back to defaultTemplate if neither template nor templateName are provided", function() {
<ide> var View;
<ide>
<ide> View = EmberView.extend({
<ide> QUnit.test("should fall back to defaultTemplate if neither template nor template
<ide> equal("template was called for Tom DAAAALE", view.$('#twas-called').text(), "the named template was called with the view as the data source");
<ide> });
<ide>
<del>QUnit.test("should not use defaultTemplate if template is provided", function() {
<add>QUnit.skip("should not use defaultTemplate if template is provided", function() {
<ide> var View;
<ide>
<ide> View = EmberView.extend({
<ide> QUnit.test("should not use defaultTemplate if template is provided", function()
<ide> equal("foo", view.$().text(), "default template was not printed");
<ide> });
<ide>
<del>QUnit.test("should not use defaultTemplate if template is provided", function() {
<add>QUnit.skip("should not use defaultTemplate if template is provided", function() {
<ide> var View;
<ide>
<ide> registry.register('template:foobar', function() { return 'foo'; });
<ide> QUnit.test("should not use defaultTemplate if template is provided", function()
<ide> equal("foo", view.$().text(), "default template was not printed");
<ide> });
<ide>
<del>QUnit.test("should render an empty element if no template is specified", function() {
<add>QUnit.skip("should render an empty element if no template is specified", function() {
<ide> view = EmberView.create();
<ide> run(function() {
<ide> view.createElement();
<ide> QUnit.test("should render an empty element if no template is specified", functio
<ide> equal(view.$().html(), '', "view div should be empty");
<ide> });
<ide>
<del>QUnit.test("should provide a controller to the template if a controller is specified on the view", function() {
<add>QUnit.skip("should provide a controller to the template if a controller is specified on the view", function() {
<ide> expect(7);
<ide>
<ide> var Controller1 = EmberObject.extend({
<ide> QUnit.test("should provide a controller to the template if a controller is speci
<ide> });
<ide> });
<ide>
<del>QUnit.test("should throw an assertion if no container has been set", function() {
<add>QUnit.skip("should throw an assertion if no container has been set", function() {
<ide> expect(1);
<ide> var View;
<ide>
<ide><path>packages/ember-views/tests/views/view/view_lifecycle_test.js
<ide> function tmpl(str) {
<ide> };
<ide> }
<ide>
<del>QUnit.test("should create and append a DOM element after bindings have synced", function() {
<add>QUnit.skip("should create and append a DOM element after bindings have synced", function() {
<ide> var ViewTest;
<ide>
<ide> lookup.ViewTest = ViewTest = {};
<ide> QUnit.test("should throw an exception if trying to append a child before renderi
<ide> }, null, "throws an error when calling appendChild()");
<ide> });
<ide>
<del>QUnit.test("should not affect rendering if rerender is called before initial render happens", function() {
<add>QUnit.skip("should not affect rendering if rerender is called before initial render happens", function() {
<ide> run(function() {
<ide> view = EmberView.create({
<ide> template: tmpl("Rerender me!")
<ide> QUnit.test("should not affect rendering if rerender is called before initial ren
<ide> equal(view.$().text(), "Rerender me!", "renders correctly if rerender is called first");
<ide> });
<ide>
<del>QUnit.test("should not affect rendering if destroyElement is called before initial render happens", function() {
<add>QUnit.skip("should not affect rendering if destroyElement is called before initial render happens", function() {
<ide> run(function() {
<ide> view = EmberView.create({
<ide> template: tmpl("Don't destroy me!")
<ide> QUnit.module("views/view/view_lifecycle_test - in render", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("appendChild should work inside a template", function() {
<add>QUnit.skip("appendChild should work inside a template", function() {
<ide> run(function() {
<ide> view = EmberView.create({
<ide> template(context, options) {
<ide> QUnit.test("appendChild should work inside a template", function() {
<ide> "The appended child is visible");
<ide> });
<ide>
<del>QUnit.test("rerender should throw inside a template", function() {
<add>QUnit.skip("rerender should throw inside a template", function() {
<ide> throws(function() {
<ide> run(function() {
<ide> var renderCount = 0;
<ide> QUnit.module("views/view/view_lifecycle_test - hasElement", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("createElement puts the view into the hasElement state", function() {
<add>QUnit.skip("createElement puts the view into the hasElement state", function() {
<ide> view = EmberView.create({
<ide> render(buffer) { buffer.push('hello'); }
<ide> });
<ide> QUnit.test("createElement puts the view into the hasElement state", function() {
<ide> equal(view.currentState, view._states.hasElement, "the view is in the hasElement state");
<ide> });
<ide>
<del>QUnit.test("trigger rerender on a view in the hasElement state doesn't change its state to inDOM", function() {
<add>QUnit.skip("trigger rerender on a view in the hasElement state doesn't change its state to inDOM", function() {
<ide> view = EmberView.create({
<ide> render(buffer) { buffer.push('hello'); }
<ide> });
<ide> QUnit.test("should throw an exception when calling appendChild when DOM element
<ide> }, null, "throws an exception when calling appendChild after element is created");
<ide> });
<ide>
<del>QUnit.test("should replace DOM representation if rerender() is called after element is created", function() {
<add>QUnit.skip("should replace DOM representation if rerender() is called after element is created", function() {
<ide> run(function() {
<ide> view = EmberView.create({
<ide> template(context, options) {
<ide> QUnit.test("should replace DOM representation if rerender() is called after elem
<ide> equal(view.$().text(), "Do not taunt happy fun ball", "rerenders DOM element when rerender() is called");
<ide> });
<ide>
<del>QUnit.test("should destroy DOM representation when destroyElement is called", function() {
<add>QUnit.skip("should destroy DOM representation when destroyElement is called", function() {
<ide> run(function() {
<ide> view = EmberView.create({
<ide> template: tmpl("Don't fear the reaper")
<ide> QUnit.test("should destroy DOM representation when destroy is called", function(
<ide> ok(jQuery('#warning').length === 0, "destroys element when destroy() is called");
<ide> });
<ide>
<del>QUnit.test("should throw an exception if trying to append an element that is already in DOM", function() {
<add>QUnit.skip("should throw an exception if trying to append an element that is already in DOM", function() {
<ide> run(function() {
<ide> view = EmberView.create({
<ide> template: tmpl('Broseidon, King of the Brocean')
<ide><path>packages/ember-views/tests/views/view/virtual_views_test.js
<ide> QUnit.module("virtual views", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("a virtual view does not appear as a view's parentView", function() {
<add>QUnit.skip("a virtual view does not appear as a view's parentView", function() {
<ide> rootView = EmberView.create({
<ide> elementId: 'root-view',
<ide>
<ide> QUnit.test("a virtual view does not appear as a view's parentView", function() {
<ide> equal(children.objectAt(0), childView, "the child element skips through the virtual view");
<ide> });
<ide>
<del>QUnit.test("when a virtual view's child views change, the parent's childViews should reflect", function() {
<add>QUnit.skip("when a virtual view's child views change, the parent's childViews should reflect", function() {
<ide> rootView = EmberView.create({
<ide> elementId: 'root-view',
<ide>
<ide><path>packages/ember/tests/component_registration_test.js
<ide> function boot(callback) {
<ide> });
<ide> }
<ide>
<del>QUnit.test("The helper becomes the body of the component", function() {
<add>QUnit.skip("The helper becomes the body of the component", function() {
<ide> boot();
<ide> equal(Ember.$('div.ember-view > div.ember-view', '#qunit-fixture').text(), "hello world", "The component is composed correctly");
<ide> });
<ide> QUnit.test("If a component is registered, it is used", function() {
<ide> });
<ide>
<ide>
<del>QUnit.test("Late-registered components can be rendered with custom `template` property (DEPRECATED)", function() {
<add>QUnit.skip("Late-registered components can be rendered with custom `template` property (DEPRECATED)", function() {
<ide>
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>there goes {{my-hero}}</div>");
<ide>
<ide> QUnit.test("Late-registered components can be rendered with ONLY the template re
<ide> ok(!helpers['borf-snorlax'], "Component wasn't saved to global helpers hash");
<ide> });
<ide>
<del>QUnit.test("Component-like invocations are treated as bound paths if neither template nor component are registered on the container", function() {
<add>QUnit.skip("Component-like invocations are treated as bound paths if neither template nor component are registered on the container", function() {
<ide>
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{user-name}} hello {{api-key}} world</div>");
<ide>
<ide> QUnit.test("Component-like invocations are treated as bound paths if neither tem
<ide> equal(Ember.$('#wrapper').text(), "machty hello world", "The component is composed correctly");
<ide> });
<ide>
<del>QUnit.test("Assigning templateName to a component should setup the template as a layout (DEPRECATED)", function() {
<add>QUnit.skip("Assigning templateName to a component should setup the template as a layout (DEPRECATED)", function() {
<ide> expect(2);
<ide>
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{#my-component}}{{text}}{{/my-component}}</div>");
<ide> QUnit.test("Assigning templateName to a component should setup the template as a
<ide> equal(Ember.$('#wrapper').text(), "inner-outer", "The component is composed correctly");
<ide> });
<ide>
<del>QUnit.test("Assigning templateName and layoutName should use the templates specified", function() {
<add>QUnit.skip("Assigning templateName and layoutName should use the templates specified", function() {
<ide> expect(1);
<ide>
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{my-component}}</div>");
<ide> QUnit.test("Assigning templateName and layoutName should use the templates speci
<ide> equal(Ember.$('#wrapper').text(), "inner-outer", "The component is composed correctly");
<ide> });
<ide>
<del>QUnit.test('Using name of component that does not exist', function () {
<add>QUnit.skip('Using name of component that does not exist', function () {
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{#no-good}} {{/no-good}}</div>");
<ide>
<ide> expectAssertion(function () {
<ide> QUnit.module("Application Lifecycle - Component Context", {
<ide> teardown: cleanup
<ide> });
<ide>
<del>QUnit.test("Components with a block should have the proper content when a template is provided", function() {
<add>QUnit.skip("Components with a block should have the proper content when a template is provided", function() {
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{#my-component}}{{text}}{{/my-component}}</div>");
<ide> Ember.TEMPLATES['components/my-component'] = compile("{{text}}-{{yield}}");
<ide>
<ide> QUnit.test("Components with a block should have the proper content when a templa
<ide> equal(Ember.$('#wrapper').text(), "inner-outer", "The component is composed correctly");
<ide> });
<ide>
<del>QUnit.test("Components with a block should yield the proper content without a template provided", function() {
<add>QUnit.skip("Components with a block should yield the proper content without a template provided", function() {
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{#my-component}}{{text}}{{/my-component}}</div>");
<ide>
<ide> boot(function() {
<ide> QUnit.test("Components without a block should have the proper content", function
<ide> equal(Ember.$('#wrapper').text(), "Some text inserted by jQuery", "The component is composed correctly");
<ide> });
<ide>
<del>QUnit.test("properties of a component without a template should not collide with internal structures", function() {
<add>QUnit.skip("properties of a component without a template should not collide with internal structures", function() {
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{my-component data=foo}}</div>");
<ide>
<ide> boot(function() {
<ide> QUnit.test("properties of a component without a template should not collide wit
<ide> equal(Ember.$('#wrapper').text(), "Some text inserted by jQuery", "The component is composed correctly");
<ide> });
<ide>
<del>QUnit.test("Components trigger actions in the parents context when called from within a block", function() {
<add>QUnit.skip("Components trigger actions in the parents context when called from within a block", function() {
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{#my-component}}<a href='#' id='fizzbuzz' {{action 'fizzbuzz'}}>Fizzbuzz</a>{{/my-component}}</div>");
<ide>
<ide> boot(function() {
<ide> QUnit.test("Components trigger actions in the parents context when called from w
<ide> });
<ide> });
<ide>
<del>QUnit.test("Components trigger actions in the components context when called from within its template", function() {
<add>QUnit.skip("Components trigger actions in the components context when called from within its template", function() {
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{#my-component}}{{text}}{{/my-component}}</div>");
<ide> Ember.TEMPLATES['components/my-component'] = compile("<a href='#' id='fizzbuzz' {{action 'fizzbuzz'}}>Fizzbuzz</a>");
<ide>
<ide><path>packages/ember/tests/helpers/helper_registration_test.js
<ide> var boot = function(callback) {
<ide> });
<ide> };
<ide>
<del>QUnit.test("Unbound dashed helpers registered on the container can be late-invoked", function() {
<add>QUnit.skip("Unbound dashed helpers registered on the container can be late-invoked", function() {
<ide>
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{x-borf}} {{x-borf YES}}</div>");
<ide>
<ide> QUnit.test("Unbound dashed helpers registered on the container can be late-invok
<ide> });
<ide>
<ide> // need to make `makeBoundHelper` for HTMLBars
<del>QUnit.test("Bound helpers registered on the container can be late-invoked", function() {
<add>QUnit.skip("Bound helpers registered on the container can be late-invoked", function() {
<ide> Ember.TEMPLATES.application = compile("<div id='wrapper'>{{x-reverse}} {{x-reverse foo}}</div>");
<ide>
<ide> boot(function() {
<ide> QUnit.test("Bound helpers registered on the container can be late-invoked", func
<ide>
<ide> // we have unit tests for this in ember-htmlbars/tests/system/lookup-helper
<ide> // and we are not going to recreate the handlebars helperMissing concept
<del>QUnit.test("Undashed helpers registered on the container can not (presently) be invoked", function() {
<add>QUnit.skip("Undashed helpers registered on the container can not (presently) be invoked", function() {
<ide>
<ide> // Note: the reason we're not allowing undashed helpers is to avoid
<ide> // a possible perf hit in hot code paths, i.e. _triageMustache.
<ide><path>packages/ember/tests/helpers/link_to_test.js
<ide> QUnit.test("The {{link-to}} helper supports multiple current-when routes", funct
<ide> equal(Ember.$('#link3.active', '#qunit-fixture').length, 0, "The link is not active since current-when does not contain the active route");
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} helper defaults to bubbling", function() {
<add>QUnit.skip("The {{link-to}} helper defaults to bubbling", function() {
<ide> Ember.TEMPLATES.about = compile("<div {{action 'hide'}}>{{#link-to 'about.contact' id='about-contact'}}About{{/link-to}}</div>{{outlet}}");
<ide> Ember.TEMPLATES['about/contact'] = compile("<h1 id='contact'>Contact</h1>");
<ide>
<ide> QUnit.test("The {{link-to}} helper defaults to bubbling", function() {
<ide> equal(hidden, 1, "The link bubbles");
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} helper supports bubbles=false", function() {
<add>QUnit.skip("The {{link-to}} helper supports bubbles=false", function() {
<ide> Ember.TEMPLATES.about = compile("<div {{action 'hide'}}>{{#link-to 'about.contact' id='about-contact' bubbles=false}}About{{/link-to}}</div>{{outlet}}");
<ide> Ember.TEMPLATES['about/contact'] = compile("<h1 id='contact'>Contact</h1>");
<ide>
<ide> QUnit.test("The {{link-to}} helper supports bubbles=false", function() {
<ide> equal(hidden, 0, "The link didn't bubble");
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} helper moves into the named route with context", function() {
<add>QUnit.skip("The {{link-to}} helper moves into the named route with context", function() {
<ide> Router.map(function(match) {
<ide> this.route("about");
<ide> this.resource("item", { path: "/item/:id" });
<ide> QUnit.test("The {{link-to}} helper should not transition if target is not equal
<ide> notEqual(container.lookup('controller:application').get('currentRouteName'), 'about', 'link-to should not transition if target is not equal to _self or empty');
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} helper accepts string/numeric arguments", function() {
<add>QUnit.skip("The {{link-to}} helper accepts string/numeric arguments", function() {
<ide> Router.map(function() {
<ide> this.route('filter', { path: '/filters/:filter' });
<ide> this.route('post', { path: '/post/:post_id' });
<ide> QUnit.test("Issue 4201 - Shorthand for route.index shouldn't throw errors about
<ide>
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} helper unwraps controllers", function() {
<add>QUnit.skip("The {{link-to}} helper unwraps controllers", function() {
<ide>
<ide> if (Ember.FEATURES.isEnabled('ember-routing-transitioning-classes')) {
<ide> expect(5);
<ide> QUnit.test("The {{link-to}} helper doesn't change view context", function() {
<ide> equal(Ember.$('#index', '#qunit-fixture').text(), 'test-Link: test-test', "accesses correct view");
<ide> });
<ide>
<del>QUnit.test("Quoteless route param performs property lookup", function() {
<add>QUnit.skip("Quoteless route param performs property lookup", function() {
<ide> Ember.TEMPLATES.index = compile("{{#link-to 'index' id='string-link'}}string{{/link-to}}{{#link-to foo id='path-link'}}path{{/link-to}}{{#link-to view.foo id='view-link'}}{{view.foo}}{{/link-to}}");
<ide>
<ide> function assertEquality(href) {
<ide> QUnit.test("Quoteless route param performs property lookup", function() {
<ide> assertEquality('/about');
<ide> });
<ide>
<del>QUnit.test("link-to with null/undefined dynamic parameters are put in a loading state", function() {
<add>QUnit.skip("link-to with null/undefined dynamic parameters are put in a loading state", function() {
<ide>
<ide> expect(19);
<ide>
<ide> QUnit.test("link-to with null/undefined dynamic parameters are put in a loading
<ide> Ember.Logger.warn = oldWarn;
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} helper refreshes href element when one of params changes", function() {
<add>QUnit.skip("The {{link-to}} helper refreshes href element when one of params changes", function() {
<ide> Router.map(function() {
<ide> this.route('post', { path: '/posts/:post_id' });
<ide> });
<ide> QUnit.test("The {{link-to}} helper refreshes href element when one of params cha
<ide> equal(Ember.$('#post', '#qunit-fixture').attr('href'), '#', 'href attr becomes # when one of the arguments in nullified');
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} helper's bound parameter functionality works as expected in conjunction with an ObjectProxy/Controller", function() {
<add>QUnit.skip("The {{link-to}} helper's bound parameter functionality works as expected in conjunction with an ObjectProxy/Controller", function() {
<ide> expectDeprecation(objectControllerDeprecation);
<ide>
<ide> Router.map(function() {
<ide> QUnit.test("The {{link-to}} helper is active when a resource is active", functio
<ide>
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} helper works in an #each'd array of string route names", function() {
<add>QUnit.skip("The {{link-to}} helper works in an #each'd array of string route names", function() {
<ide> Router.map(function() {
<ide> this.route('foo');
<ide> this.route('bar');
<ide> QUnit.test("The non-block form {{link-to}} helper moves into the named route", f
<ide> equal(Ember.$('#home-link:not(.active)', '#qunit-fixture').length, 1, "The other link was rendered without active class");
<ide> });
<ide>
<del>QUnit.test("The non-block form {{link-to}} helper updates the link text when it is a binding", function() {
<add>QUnit.skip("The non-block form {{link-to}} helper updates the link text when it is a binding", function() {
<ide> expect(8);
<ide> Router.map(function(match) {
<ide> this.route("contact");
<ide> QUnit.test("The non-block form {{link-to}} helper updates the link text when it
<ide> equal(Ember.$('#contact-link:contains(Robert)', '#qunit-fixture').length, 1, "The link title is correctly updated when the route changes");
<ide> });
<ide>
<del>QUnit.test("The non-block form {{link-to}} helper moves into the named route with context", function() {
<add>QUnit.skip("The non-block form {{link-to}} helper moves into the named route with context", function() {
<ide> expect(5);
<ide> Router.map(function(match) {
<ide> this.route("item", { path: "/item/:id" });
<ide> QUnit.test("The non-block form {{link-to}} helper moves into the named route wit
<ide>
<ide> });
<ide>
<del>QUnit.test("The non-block form {{link-to}} performs property lookup", function() {
<add>QUnit.skip("The non-block form {{link-to}} performs property lookup", function() {
<ide> Ember.TEMPLATES.index = compile("{{link-to 'string' 'index' id='string-link'}}{{link-to path foo id='path-link'}}{{link-to view.foo view.foo id='view-link'}}");
<ide>
<ide> function assertEquality(href) {
<ide> QUnit.test("The non-block form {{link-to}} performs property lookup", function()
<ide> assertEquality('/about');
<ide> });
<ide>
<del>QUnit.test("The non-block form {{link-to}} protects against XSS", function() {
<add>QUnit.skip("The non-block form {{link-to}} protects against XSS", function() {
<ide> Ember.TEMPLATES.application = compile("{{link-to display 'index' id='link'}}");
<ide>
<ide> App.ApplicationController = Ember.Controller.extend({
<ide> QUnit.test("the {{link-to}} helper calls preventDefault", function() {
<ide> equal(event.isDefaultPrevented(), true, "should preventDefault");
<ide> });
<ide>
<del>QUnit.test("the {{link-to}} helper does not call preventDefault if `preventDefault=false` is passed as an option", function() {
<add>QUnit.skip("the {{link-to}} helper does not call preventDefault if `preventDefault=false` is passed as an option", function() {
<ide> Ember.TEMPLATES.index = compile("{{#link-to 'about' id='about-link' preventDefault=false}}About{{/link-to}}");
<ide>
<ide> Router.map(function() {
<ide> QUnit.test("{{link-to}} active property respects changing parent route context",
<ide>
<ide> });
<ide>
<del>QUnit.test("{{link-to}} populates href with default query param values even without query-params object", function() {
<add>QUnit.skip("{{link-to}} populates href with default query param values even without query-params object", function() {
<ide> App.IndexController = Ember.Controller.extend({
<ide> queryParams: ['foo'],
<ide> foo: '123'
<ide> QUnit.test("{{link-to}} populates href with default query param values even with
<ide> equal(Ember.$('#the-link').attr('href'), "/", "link has right href");
<ide> });
<ide>
<del>QUnit.test("{{link-to}} populates href with default query param values with empty query-params object", function() {
<add>QUnit.skip("{{link-to}} populates href with default query param values with empty query-params object", function() {
<ide> App.IndexController = Ember.Controller.extend({
<ide> queryParams: ['foo'],
<ide> foo: '123'
<ide> QUnit.test("{{link-to}} populates href with default query param values with empt
<ide> equal(Ember.$('#the-link').attr('href'), "/", "link has right href");
<ide> });
<ide>
<del>QUnit.test("{{link-to}} populates href with supplied query param values", function() {
<add>QUnit.skip("{{link-to}} populates href with supplied query param values", function() {
<ide> App.IndexController = Ember.Controller.extend({
<ide> queryParams: ['foo'],
<ide> foo: '123'
<ide> QUnit.test("{{link-to}} populates href with supplied query param values", functi
<ide> equal(Ember.$('#the-link').attr('href'), "/?foo=456", "link has right href");
<ide> });
<ide>
<del>QUnit.test("{{link-to}} populates href with partially supplied query param values", function() {
<add>QUnit.skip("{{link-to}} populates href with partially supplied query param values", function() {
<ide> App.IndexController = Ember.Controller.extend({
<ide> queryParams: ['foo', 'bar'],
<ide> foo: '123',
<ide> QUnit.test("{{link-to}} populates href with partially supplied query param value
<ide> equal(Ember.$('#the-link').attr('href'), "/?foo=456", "link has right href");
<ide> });
<ide>
<del>QUnit.test("{{link-to}} populates href with partially supplied query param values, but omits if value is default value", function() {
<add>QUnit.skip("{{link-to}} populates href with partially supplied query param values, but omits if value is default value", function() {
<ide> App.IndexController = Ember.Controller.extend({
<ide> queryParams: ['foo', 'bar'],
<ide> foo: '123',
<ide> QUnit.test("{{link-to}} populates href with partially supplied query param value
<ide> equal(Ember.$('#the-link').attr('href'), "/", "link has right href");
<ide> });
<ide>
<del>QUnit.test("{{link-to}} populates href with fully supplied query param values", function() {
<add>QUnit.skip("{{link-to}} populates href with fully supplied query param values", function() {
<ide> App.IndexController = Ember.Controller.extend({
<ide> queryParams: ['foo', 'bar'],
<ide> foo: '123',
<ide> QUnit.test("doesn't update controller QP properties on current route when invoke
<ide> deepEqual(indexController.getProperties('foo', 'bar'), { foo: '123', bar: 'abc' }, "controller QP properties not");
<ide> });
<ide>
<del>QUnit.test("updates controller QP properties on current route when invoked", function() {
<add>QUnit.skip("updates controller QP properties on current route when invoked", function() {
<ide> Ember.TEMPLATES.index = compile("{{#link-to 'index' (query-params foo='456') id='the-link'}}Index{{/link-to}}");
<ide> bootApplication();
<ide>
<ide> QUnit.test("updates controller QP properties on current route when invoked", fun
<ide> deepEqual(indexController.getProperties('foo', 'bar'), { foo: '456', bar: 'abc' }, "controller QP properties updated");
<ide> });
<ide>
<del>QUnit.test("updates controller QP properties on current route when invoked (inferred route)", function() {
<add>QUnit.skip("updates controller QP properties on current route when invoked (inferred route)", function() {
<ide> Ember.TEMPLATES.index = compile("{{#link-to (query-params foo='456') id='the-link'}}Index{{/link-to}}");
<ide> bootApplication();
<ide>
<ide> QUnit.test("updates controller QP properties on current route when invoked (infe
<ide> deepEqual(indexController.getProperties('foo', 'bar'), { foo: '456', bar: 'abc' }, "controller QP properties updated");
<ide> });
<ide>
<del>QUnit.test("updates controller QP properties on other route after transitioning to that route", function() {
<add>QUnit.skip("updates controller QP properties on other route after transitioning to that route", function() {
<ide> Router.map(function() {
<ide> this.route('about');
<ide> });
<ide> QUnit.test("updates controller QP properties on other route after transitioning
<ide> equal(container.lookup('controller:application').get('currentPath'), "about");
<ide> });
<ide>
<del>QUnit.test("supplied QP properties can be bound", function() {
<add>QUnit.skip("supplied QP properties can be bound", function() {
<ide> var indexController = container.lookup('controller:index');
<ide> Ember.TEMPLATES.index = compile("{{#link-to (query-params foo=boundThing) id='the-link'}}Index{{/link-to}}");
<ide>
<ide> QUnit.test("supplied QP properties can be bound", function() {
<ide> equal(Ember.$('#the-link').attr('href'), '/?foo=ASL');
<ide> });
<ide>
<del>QUnit.test("supplied QP properties can be bound (booleans)", function() {
<add>QUnit.skip("supplied QP properties can be bound (booleans)", function() {
<ide> var indexController = container.lookup('controller:index');
<ide> Ember.TEMPLATES.index = compile("{{#link-to (query-params abool=boundThing) id='the-link'}}Index{{/link-to}}");
<ide>
<ide> QUnit.test("supplied QP properties can be bound (booleans)", function() {
<ide> deepEqual(indexController.getProperties('foo', 'bar', 'abool'), { foo: '123', bar: 'abc', abool: false });
<ide> });
<ide>
<del>QUnit.test("href updates when unsupplied controller QP props change", function() {
<add>QUnit.skip("href updates when unsupplied controller QP props change", function() {
<ide> var indexController = container.lookup('controller:index');
<ide> Ember.TEMPLATES.index = compile("{{#link-to (query-params foo='lol') id='the-link'}}Index{{/link-to}}");
<ide>
<ide> QUnit.test("href updates when unsupplied controller QP props change", function()
<ide> equal(Ember.$('#the-link').attr('href'), '/?bar=BORF&foo=lol');
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} applies activeClass when query params are not changed", function() {
<add>QUnit.skip("The {{link-to}} applies activeClass when query params are not changed", function() {
<ide> Ember.TEMPLATES.index = compile(
<ide> "{{#link-to (query-params foo='cat') id='cat-link'}}Index{{/link-to}} " +
<ide> "{{#link-to (query-params foo='dog') id='dog-link'}}Index{{/link-to}} " +
<ide> QUnit.test("The {{link-to}} applies activeClass when query params are not change
<ide> shouldNotBeActive('#change-search-same-sort-child-and-parent');
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} applies active class when query-param is number", function() {
<add>QUnit.skip("The {{link-to}} applies active class when query-param is number", function() {
<ide> Ember.TEMPLATES.index = compile(
<ide> "{{#link-to (query-params page=pageNumber) id='page-link'}}Index{{/link-to}} ");
<ide>
<ide> QUnit.test("The {{link-to}} applies active class when query-param is number", fu
<ide> shouldBeActive('#page-link');
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} applies active class when query-param is array", function() {
<add>QUnit.skip("The {{link-to}} applies active class when query-param is array", function() {
<ide> Ember.TEMPLATES.index = compile(
<ide> "{{#link-to (query-params pages=pagesArray) id='array-link'}}Index{{/link-to}} " +
<ide> "{{#link-to (query-params pages=biggerArray) id='bigger-link'}}Index{{/link-to}} " +
<ide> QUnit.test("The {{link-to}} helper applies active class to parent route", functi
<ide> shouldNotBeActive('#parent-link-qp');
<ide> });
<ide>
<del>QUnit.test("The {{link-to}} helper disregards query-params in activeness computation when current-when specified", function() {
<add>QUnit.skip("The {{link-to}} helper disregards query-params in activeness computation when current-when specified", function() {
<ide> App.Router.map(function() {
<ide> this.route('parent');
<ide> });
<ide><path>packages/ember/tests/homepage_example_test.js
<ide> QUnit.module("Homepage Example", {
<ide> });
<ide>
<ide>
<del>QUnit.test("The example renders correctly", function() {
<add>QUnit.skip("The example renders correctly", function() {
<ide> Ember.run(App, 'advanceReadiness');
<ide>
<ide> equal($fixture.find('h1:contains(People)').length, 1);
<ide><path>packages/ember/tests/routing/basic_test.js
<ide> QUnit.test("The Homepage with explicit template name in renderTemplate", functio
<ide> equal(Ember.$('h3:contains(Megatroll)', '#qunit-fixture').length, 1, "The homepage template was rendered");
<ide> });
<ide>
<del>QUnit.test("An alternate template will pull in an alternate controller", function() {
<add>QUnit.skip("An alternate template will pull in an alternate controller", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("An alternate template will pull in an alternate controller", functio
<ide> equal(Ember.$('h3:contains(Megatroll) + p:contains(Comes from homepage)', '#qunit-fixture').length, 1, "The homepage template was rendered");
<ide> });
<ide>
<del>QUnit.test("An alternate template will pull in an alternate controller instead of controllerName", function() {
<add>QUnit.skip("An alternate template will pull in an alternate controller instead of controllerName", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("An alternate template will pull in an alternate controller instead o
<ide> equal(Ember.$('h3:contains(Megatroll) + p:contains(Comes from homepage)', '#qunit-fixture').length, 1, "The homepage template was rendered");
<ide> });
<ide>
<del>QUnit.test("The template will pull in an alternate controller via key/value", function() {
<add>QUnit.skip("The template will pull in an alternate controller via key/value", function() {
<ide> Router.map(function() {
<ide> this.route("homepage", { path: "/" });
<ide> });
<ide> QUnit.test("The template will pull in an alternate controller via key/value", fu
<ide> equal(Ember.$('h3:contains(Megatroll) + p:contains(Comes from home.)', '#qunit-fixture').length, 1, "The homepage template was rendered from data from the HomeController");
<ide> });
<ide>
<del>QUnit.test("The Homepage with explicit template name in renderTemplate and controller", function() {
<add>QUnit.skip("The Homepage with explicit template name in renderTemplate and controller", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("The Homepage with explicit template name in renderTemplate and contr
<ide> equal(Ember.$('h3:contains(Megatroll) + p:contains(YES I AM HOME)', '#qunit-fixture').length, 1, "The homepage template was rendered");
<ide> });
<ide>
<del>QUnit.test("Model passed via renderTemplate model is set as controller's model", function() {
<add>QUnit.skip("Model passed via renderTemplate model is set as controller's model", function() {
<ide> Ember.TEMPLATES['bio'] = compile("<p>{{model.name}}</p>");
<ide>
<ide> App.BioController = Ember.Controller.extend();
<ide> QUnit.test('defining templateName allows other templates to be rendered', functi
<ide>
<ide> });
<ide>
<del>QUnit.test('Specifying a name to render should have precedence over everything else', function() {
<add>QUnit.skip('Specifying a name to render should have precedence over everything else', function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test('Specifying a name to render should have precedence over everything e
<ide> equal(Ember.$('span', '#qunit-fixture').text(), "Outertroll", "The homepage view was used");
<ide> });
<ide>
<del>QUnit.test("The Homepage with a `setupController` hook", function() {
<add>QUnit.skip("The Homepage with a `setupController` hook", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("The route controller is still set when overriding the setupControlle
<ide> deepEqual(container.lookup('route:home').controller, container.lookup('controller:home'), "route controller is the home controller");
<ide> });
<ide>
<del>QUnit.test("The route controller can be specified via controllerName", function() {
<add>QUnit.skip("The route controller can be specified via controllerName", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("The route controller can be specified via controllerName", function(
<ide> equal(Ember.$('p', '#qunit-fixture').text(), "foo", "The homepage template was rendered with data from the custom controller");
<ide> });
<ide>
<del>QUnit.test("The route controller specified via controllerName is used in render", function() {
<add>QUnit.skip("The route controller specified via controllerName is used in render", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("The route controller specified via controllerName is used in render"
<ide> equal(Ember.$('p', '#qunit-fixture').text(), "alternative home: foo", "The homepage template was rendered with data from the custom controller");
<ide> });
<ide>
<del>QUnit.test("The route controller specified via controllerName is used in render even when a controller with the routeName is available", function() {
<add>QUnit.skip("The route controller specified via controllerName is used in render even when a controller with the routeName is available", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("The route controller specified via controllerName is used in render
<ide> equal(Ember.$('p', '#qunit-fixture').text(), "home: myController", "The homepage template was rendered with data from the custom controller");
<ide> });
<ide>
<del>QUnit.test("The Homepage with a `setupController` hook modifying other controllers", function() {
<add>QUnit.skip("The Homepage with a `setupController` hook modifying other controllers", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("The Homepage with a `setupController` hook modifying other controlle
<ide> equal(Ember.$('ul li', '#qunit-fixture').eq(2).text(), "Sunday: Noon to 6pm", "The template was rendered with the hours context");
<ide> });
<ide>
<del>QUnit.test("The Homepage with a computed context that does not get overridden", function() {
<add>QUnit.skip("The Homepage with a computed context that does not get overridden", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("The Homepage with a computed context that does not get overridden",
<ide> equal(Ember.$('ul li', '#qunit-fixture').eq(2).text(), "Sunday: Noon to 6pm", "The template was rendered with the context intact");
<ide> });
<ide>
<del>QUnit.test("The Homepage getting its controller context via model", function() {
<add>QUnit.skip("The Homepage getting its controller context via model", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> QUnit.test("The Homepage getting its controller context via model", function() {
<ide> equal(Ember.$('ul li', '#qunit-fixture').eq(2).text(), "Sunday: Noon to 6pm", "The template was rendered with the hours context");
<ide> });
<ide>
<del>QUnit.test("The Specials Page getting its controller context by deserializing the params hash", function() {
<add>QUnit.skip("The Specials Page getting its controller context by deserializing the params hash", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> this.resource("special", { path: "/specials/:menu_item_id" });
<ide> QUnit.test("The Specials Page getting its controller context by deserializing th
<ide> equal(Ember.$('p', '#qunit-fixture').text(), "1", "The model was used to render the template");
<ide> });
<ide>
<del>QUnit.test("The Specials Page defaults to looking models up via `find`", function() {
<add>QUnit.skip("The Specials Page defaults to looking models up via `find`", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> this.resource("special", { path: "/specials/:menu_item_id" });
<ide> QUnit.test("The Specials Page defaults to looking models up via `find`", functio
<ide> equal(Ember.$('p', '#qunit-fixture').text(), "1", "The model was used to render the template");
<ide> });
<ide>
<del>QUnit.test("The Special Page returning a promise puts the app into a loading state until the promise is resolved", function() {
<add>QUnit.skip("The Special Page returning a promise puts the app into a loading state until the promise is resolved", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> this.resource("special", { path: "/specials/:menu_item_id" });
<ide> QUnit.test("The Special Page returning a promise puts the app into a loading sta
<ide> equal(Ember.$('p', '#qunit-fixture').text(), "1", "The app is now in the specials state");
<ide> });
<ide>
<del>QUnit.test("The loading state doesn't get entered for promises that resolve on the same run loop", function() {
<add>QUnit.skip("The loading state doesn't get entered for promises that resolve on the same run loop", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> this.resource("special", { path: "/specials/:menu_item_id" });
<ide> asyncTest("Nested callbacks are not exited when moving to siblings", function()
<ide> });
<ide> });
<ide>
<del>asyncTest("Events are triggered on the controller if a matching action name is implemented", function() {
<add>// Revert QUnit.skip to QUnit.asyncTest
<add>QUnit.skip("Events are triggered on the controller if a matching action name is implemented", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> asyncTest("Events are triggered on the controller if a matching action name is i
<ide> action.handler(event);
<ide> });
<ide>
<del>asyncTest("Events are triggered on the current state when defined in `actions` object", function() {
<add>// Revert QUnit.skip to QUnit.asyncTest
<add>QUnit.skip("Events are triggered on the current state when defined in `actions` object", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> asyncTest("Events are triggered on the current state when defined in `actions` o
<ide> action.handler(event);
<ide> });
<ide>
<del>asyncTest("Events defined in `actions` object are triggered on the current state when routes are nested", function() {
<add>// Revert QUnit.skip to QUnit.asyncTest
<add>QUnit.skip("Events defined in `actions` object are triggered on the current state when routes are nested", function() {
<ide> Router.map(function() {
<ide> this.resource("root", { path: "/" }, function() {
<ide> this.route("index", { path: "/" });
<ide> asyncTest("Events defined in `actions` object are triggered on the current state
<ide> action.handler(event);
<ide> });
<ide>
<del>asyncTest("Events are triggered on the current state when defined in `events` object (DEPRECATED)", function() {
<add>// Revert QUnit.skip to QUnit.asyncTest
<add>QUnit.skip("Events are triggered on the current state when defined in `events` object (DEPRECATED)", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> asyncTest("Events are triggered on the current state when defined in `events` ob
<ide> action.handler(event);
<ide> });
<ide>
<del>asyncTest("Events defined in `events` object are triggered on the current state when routes are nested (DEPRECATED)", function() {
<add>// Revert QUnit.skip to QUnit.asyncTest
<add>QUnit.skip("Events defined in `events` object are triggered on the current state when routes are nested (DEPRECATED)", function() {
<ide> Router.map(function() {
<ide> this.resource("root", { path: "/" }, function() {
<ide> this.route("index", { path: "/" });
<ide> QUnit.test("Events can be handled by inherited event handlers", function() {
<ide> router.send("baz");
<ide> });
<ide>
<del>asyncTest("Actions are not triggered on the controller if a matching action name is implemented as a method", function() {
<add>// Revert QUnit.skip to QUnit.asyncTest
<add>QUnit.skip("Actions are not triggered on the controller if a matching action name is implemented as a method", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" });
<ide> });
<ide> asyncTest("Actions are not triggered on the controller if a matching action name
<ide> action.handler(event);
<ide> });
<ide>
<del>asyncTest("actions can be triggered with multiple arguments", function() {
<add>// Revert QUnit.skip to QUnit.asyncTest
<add>QUnit.skip("actions can be triggered with multiple arguments", function() {
<ide> Router.map(function() {
<ide> this.resource("root", { path: "/" }, function() {
<ide> this.route("index", { path: "/" });
<ide> QUnit.test("Transitioning from a parent event does not prevent currentPath from
<ide> equal(router.get('location').getURL(), "/foo/qux");
<ide> });
<ide>
<del>QUnit.test("Generated names can be customized when providing routes with dot notation", function() {
<add>QUnit.skip("Generated names can be customized when providing routes with dot notation", function() {
<ide> expect(4);
<ide>
<ide> Ember.TEMPLATES.index = compile("<div>Index</div>");
<ide> QUnit.test("Application template does not duplicate when re-rendered", function(
<ide> equal(Ember.$('h3:contains(I Render Once)').size(), 1);
<ide> });
<ide>
<del>QUnit.test("Child routes should render inside the application template if the application template causes a redirect", function() {
<add>QUnit.skip("Child routes should render inside the application template if the application template causes a redirect", function() {
<ide> Ember.TEMPLATES.application = compile("<h3>App</h3> {{outlet}}");
<ide> Ember.TEMPLATES.posts = compile("posts");
<ide>
<ide> QUnit.test("Child routes should render inside the application template if the ap
<ide> equal(Ember.$('#qunit-fixture > div').text(), "App posts");
<ide> });
<ide>
<del>QUnit.test("The template is not re-rendered when the route's context changes", function() {
<add>QUnit.skip("The template is not re-rendered when the route's context changes", function() {
<ide> Router.map(function() {
<ide> this.route("page", { path: "/page/:name" });
<ide> });
<ide> QUnit.test("The template is not re-rendered when the route's context changes", f
<ide> });
<ide>
<ide>
<del>QUnit.test("The template is not re-rendered when two routes present the exact same template, view, & controller", function() {
<add>QUnit.skip("The template is not re-rendered when two routes present the exact same template, view, & controller", function() {
<ide> Router.map(function() {
<ide> this.route("first");
<ide> this.route("second");
<ide> QUnit.test("Exception during load of initial route is not swallowed", function()
<ide> }, /\bboom\b/);
<ide> });
<ide>
<del>QUnit.test("{{outlet}} works when created after initial render", function() {
<add>QUnit.skip("{{outlet}} works when created after initial render", function() {
<ide> Ember.TEMPLATES.sample = compile("Hi{{#if showTheThing}}{{outlet}}{{/if}}Bye");
<ide> Ember.TEMPLATES['sample/inner'] = compile("Yay");
<ide> Ember.TEMPLATES['sample/inner2'] = compile("Boo");
<ide><path>packages/ember/tests/routing/query_params_test.js
<ide> QUnit.test("model hooks receives query params", function() {
<ide> equal(router.get('location.path'), "");
<ide> });
<ide>
<del>QUnit.test("controllers won't be eagerly instantiated by internal query params logic", function() {
<add>QUnit.skip("controllers won't be eagerly instantiated by internal query params logic", function() {
<ide> expect(10);
<ide> Router.map(function() {
<ide> this.resource('cats', function() {
<ide> QUnit.test("An explicit replace:false on a changed QP always wins and causes a p
<ide> Ember.run(appController, 'setProperties', { alex: 'sriracha' });
<ide> });
<ide>
<del>QUnit.test("can opt into full transition by setting refreshModel in route queryParams when transitioning from child to parent", function() {
<add>QUnit.skip("can opt into full transition by setting refreshModel in route queryParams when transitioning from child to parent", function() {
<ide> Ember.TEMPLATES.parent = compile('{{outlet}}');
<ide> Ember.TEMPLATES['parent/child'] = compile("{{link-to 'Parent' 'parent' (query-params foo='change') id='parent-link'}}");
<ide>
<ide> QUnit.test("URL transitions that remove QPs still register as QP changes", funct
<ide> equal(indexController.get('omg'), 'lol');
<ide> });
<ide>
<del>QUnit.test("Subresource naming style is supported", function() {
<add>QUnit.skip("Subresource naming style is supported", function() {
<ide>
<ide> Router.map(function() {
<ide> this.resource('abc.def', { path: '/abcdef' }, function() {
<ide> QUnit.test("A child of a resource route still defaults to parent route's model e
<ide> bootApplication();
<ide> });
<ide>
<del>QUnit.test("opting into replace does not affect transitions between routes", function() {
<add>QUnit.skip("opting into replace does not affect transitions between routes", function() {
<ide> expect(5);
<ide> Ember.TEMPLATES.application = compile(
<ide> "{{link-to 'Foo' 'foo' id='foo-link'}}" +
<ide> QUnit.module("Model Dep Query Params", {
<ide> }
<ide> });
<ide>
<del>QUnit.test("query params have 'model' stickiness by default", function() {
<add>QUnit.skip("query params have 'model' stickiness by default", function() {
<ide> this.boot();
<ide>
<ide> Ember.run(this.$link1, 'click');
<ide> QUnit.test("query params have 'model' stickiness by default", function() {
<ide> equal(this.$link3.attr('href'), '/a/a-3');
<ide> });
<ide>
<del>QUnit.test("query params have 'model' stickiness by default (url changes)", function() {
<add>QUnit.skip("query params have 'model' stickiness by default (url changes)", function() {
<ide>
<ide> this.boot();
<ide>
<ide> QUnit.test("query params have 'model' stickiness by default (url changes)", func
<ide> });
<ide>
<ide>
<del>QUnit.test("query params have 'model' stickiness by default (params-based transitions)", function() {
<add>QUnit.skip("query params have 'model' stickiness by default (params-based transitions)", function() {
<ide> Ember.TEMPLATES.application = compile("{{#each a in articles}} {{link-to 'Article' 'article' a.id id=a.id}} {{/each}}");
<ide>
<ide> this.boot();
<ide> QUnit.test("query params have 'model' stickiness by default (params-based transi
<ide> equal(this.$link3.attr('href'), '/a/a-3?q=hay');
<ide> });
<ide>
<del>QUnit.test("'controller' stickiness shares QP state between models", function() {
<add>QUnit.skip("'controller' stickiness shares QP state between models", function() {
<ide> App.ArticleController.reopen({
<ide> queryParams: { q: { scope: 'controller' } }
<ide> });
<ide> QUnit.test("'controller' stickiness shares QP state between models", function()
<ide> equal(this.$link3.attr('href'), '/a/a-3?q=woot&z=123');
<ide> });
<ide>
<del>QUnit.test("'model' stickiness is scoped to current or first dynamic parent route", function() {
<add>QUnit.skip("'model' stickiness is scoped to current or first dynamic parent route", function() {
<ide> this.boot();
<ide>
<ide> Ember.run(router, 'transitionTo', 'comments', 'a-1');
<ide> QUnit.test("'model' stickiness is scoped to current or first dynamic parent rout
<ide> equal(router.get('location.path'), '/a/a-1/comments?page=3');
<ide> });
<ide>
<del>QUnit.test("can reset query params using the resetController hook", function() {
<add>QUnit.skip("can reset query params using the resetController hook", function() {
<ide> App.Router.map(function() {
<ide> this.resource('article', { path: '/a/:id' }, function() {
<ide> this.resource('comments');
<ide><path>packages/ember/tests/routing/substates_test.js
<ide> QUnit.test("Loading actions bubble to root, but don't enter substates above pivo
<ide> equal(appController.get('currentPath'), "grandma.smells", "Finished transition");
<ide> });
<ide>
<del>QUnit.test("Default error event moves into nested route", function() {
<add>QUnit.skip("Default error event moves into nested route", function() {
<ide>
<ide> expect(5);
<ide>
<ide> if (Ember.FEATURES.isEnabled("ember-routing-named-substates")) {
<ide> equal(Ember.$('#app', '#qunit-fixture').text(), "INDEX");
<ide> });
<ide>
<del> QUnit.test("Default error event moves into nested route, prioritizing more specifically named error route", function() {
<add> QUnit.skip("Default error event moves into nested route, prioritizing more specifically named error route", function() {
<ide>
<ide> expect(5);
<ide>
<ide> if (Ember.FEATURES.isEnabled("ember-routing-named-substates")) {
<ide> equal(Ember.$('#app', '#qunit-fixture').text(), "YAY");
<ide> });
<ide>
<del> QUnit.test("Prioritized error substate entry works with preserved-namespace nested routes", function() {
<add> QUnit.skip("Prioritized error substate entry works with preserved-namespace nested routes", function() {
<ide>
<ide> expect(1);
<ide>
<ide> if (Ember.FEATURES.isEnabled("ember-routing-named-substates")) {
<ide> equal(Ember.$('#app', '#qunit-fixture').text(), "YAY");
<ide> });
<ide>
<del> QUnit.test("Prioritized error substate entry works with auto-generated index routes", function() {
<add> QUnit.skip("Prioritized error substate entry works with auto-generated index routes", function() {
<ide>
<ide> expect(1);
<ide>
<ide> if (Ember.FEATURES.isEnabled("ember-routing-named-substates")) {
<ide> equal(Ember.$('#app', '#qunit-fixture').text(), "FOO ERROR: did it broke?", "foo.index_error was entered");
<ide> });
<ide>
<del> QUnit.test("Rejected promises returned from ApplicationRoute transition into top-level application_error", function() {
<add> QUnit.skip("Rejected promises returned from ApplicationRoute transition into top-level application_error", function() {
<ide>
<ide> expect(2);
<ide> | 46 |
Ruby | Ruby | add a test for | 0d5a384498296f005395d02943bd18e688aba436 | <ide><path>railties/test/application/configuration_test.rb
<ide> def teardown
<ide> end
<ide> end
<ide>
<add> test "lib dir is on LOAD_PATH during config" do
<add> app_file 'lib/my_logger.rb', <<-RUBY
<add> require "logger"
<add> class MyLogger < ::Logger
<add> end
<add> RUBY
<add> add_to_top_of_config <<-RUBY
<add> equire 'my_logger'
<add> config.logger = MyLogger.new STDOUT
<add> RUBY
<add> require "#{app_path}/config/environment"
<add> end
<add>
<ide> test "a renders exception on pending migration" do
<ide> add_to_config <<-RUBY
<ide> config.active_record.migration_error = :page_load
<ide><path>railties/test/isolation/abstract_unit.rb
<ide> def script(script)
<ide> end
<ide> end
<ide>
<add> def add_to_top_of_config(str)
<add> environment = File.read("#{app_path}/config/application.rb")
<add> if environment =~ /(Rails::Application\s*)/
<add> File.open("#{app_path}/config/application.rb", 'w') do |f|
<add> f.puts $` + $1 + "\n#{str}\n" + $'
<add> end
<add> end
<add> end
<add>
<ide> def add_to_config(str)
<ide> environment = File.read("#{app_path}/config/application.rb")
<ide> if environment =~ /(\n\s*end\s*end\s*)\Z/ | 2 |
Text | Text | add missing code tag | d2914dd4d679e965c746769a048e9c79e74bfa12 | <ide><path>curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/60a3e3396c7b40068ad6998d.md
<ide> const oneFilter = getComputedStyle(one).filter;
<ide> assert(oneFilter === 'blur(1px)');
<ide> ```
<ide>
<del>Your `.two` element should have a filter value of `blur(1px)`.
<add>Your `.two` element should have a `filter` value of `blur(1px)`.
<ide>
<ide> ```js
<ide> const two = document.querySelector('.two'); | 1 |
Python | Python | pull python 3 changes from node/node-gyp | 5ebaf703aa24abd7f45875d61d72a5088a0eb78b | <ide><path>tools/gyp/PRESUBMIT.py
<ide> def _LicenseHeader(input_api):
<ide> # Accept any year number from 2009 to the current year.
<ide> current_year = int(input_api.time.strftime('%Y'))
<del> allowed_years = (str(s) for s in reversed(xrange(2009, current_year + 1)))
<del>
<add> allowed_years = (str(s) for s in reversed(range(2009, current_year + 1)))
<ide> years_re = '(' + '|'.join(allowed_years) + ')'
<ide>
<ide> # The (c) is deprecated, but tolerate it until it's removed from all files.
<ide> def CheckChangeOnCommit(input_api, output_api):
<ide> finally:
<ide> sys.path = old_sys_path
<ide> return report
<add>
<add>
<add>TRYBOTS = [
<add> 'linux_try',
<add> 'mac_try',
<add> 'win_try',
<add>]
<add>
<add>
<add>def GetPreferredTryMasters(_, change):
<add> return {
<add> 'client.gyp': { t: set(['defaulttests']) for t in TRYBOTS },
<add> }
<ide><path>tools/gyp/pylib/gyp/MSVSNew.py
<ide>
<ide> """New implementation of Visual Studio project generation."""
<ide>
<add>import hashlib
<ide> import os
<ide> import random
<ide>
<ide> import gyp.common
<ide>
<del># hashlib is supplied as of Python 2.5 as the replacement interface for md5
<del># and other secure hashes. In 2.6, md5 is deprecated. Import hashlib if
<del># available, avoiding a deprecation warning under 2.6. Import md5 otherwise,
<del># preserving 2.4 compatibility.
<ide> try:
<del> import hashlib
<del> _new_md5 = hashlib.md5
<del>except ImportError:
<del> import md5
<del> _new_md5 = md5.new
<del>
<add> cmp
<add>except NameError:
<add> def cmp(x, y):
<add> return (x > y) - (x < y)
<ide>
<ide> # Initialize random number generator
<ide> random.seed()
<ide> def MakeGuid(name, seed='msvs_new'):
<ide> not change when the project for a target is rebuilt.
<ide> """
<ide> # Calculate a MD5 signature for the seed and name.
<del> d = _new_md5(str(seed) + str(name)).hexdigest().upper()
<add> d = hashlib.md5(str(seed) + str(name)).hexdigest().upper()
<ide> # Convert most of the signature to GUID form (discard the rest)
<ide> guid = ('{' + d[:8] + '-' + d[8:12] + '-' + d[12:16] + '-' + d[16:20]
<ide> + '-' + d[20:32] + '}')
<ide><path>tools/gyp/pylib/gyp/MSVSUserFile.py
<ide> def AddDebugSettings(self, config_name, command, environment = {},
<ide>
<ide> if environment and isinstance(environment, dict):
<ide> env_list = ['%s="%s"' % (key, val)
<del> for (key,val) in environment.iteritems()]
<add> for (key,val) in environment.items()]
<ide> environment = ' '.join(env_list)
<ide> else:
<ide> environment = ''
<ide> def AddDebugSettings(self, config_name, command, environment = {},
<ide> def WriteIfChanged(self):
<ide> """Writes the user file."""
<ide> configs = ['Configurations']
<del> for config, spec in sorted(self.configurations.iteritems()):
<add> for config, spec in sorted(self.configurations.items()):
<ide> configs.append(spec)
<ide>
<ide> content = ['VisualStudioUserFile',
<ide><path>tools/gyp/pylib/gyp/__init__.py
<ide> # Use of this source code is governed by a BSD-style license that can be
<ide> # found in the LICENSE file.
<ide>
<add>from __future__ import print_function
<add>
<ide> import copy
<ide> import gyp.input
<del>import optparse
<add>import argparse
<ide> import os.path
<ide> import re
<ide> import shlex
<ide> import sys
<ide> import traceback
<ide> from gyp.common import GypError
<ide>
<add>try:
<add> # Python 2
<add> string_types = basestring
<add>except NameError:
<add> # Python 3
<add> string_types = str
<add>
<ide> # Default debug modes for GYP
<ide> debug = {}
<ide>
<ide> def DebugOutput(mode, message, *args):
<ide> pass
<ide> if args:
<ide> message %= args
<del> print '%s:%s:%d:%s %s' % (mode.upper(), os.path.basename(ctx[0]),
<del> ctx[1], ctx[2], message)
<add> print('%s:%s:%d:%s %s' % (mode.upper(), os.path.basename(ctx[0]),
<add> ctx[1], ctx[2], message))
<ide>
<ide> def FindBuildFiles():
<ide> extension = '.gyp'
<ide> def Noop(value):
<ide> # We always want to ignore the environment when regenerating, to avoid
<ide> # duplicate or changed flags in the environment at the time of regeneration.
<ide> flags = ['--ignore-environment']
<del> for name, metadata in options._regeneration_metadata.iteritems():
<add> for name, metadata in options._regeneration_metadata.items():
<ide> opt = metadata['opt']
<ide> value = getattr(options, name)
<ide> value_predicate = metadata['type'] == 'path' and FixPath or Noop
<ide> def Noop(value):
<ide> (action == 'store_false' and not value)):
<ide> flags.append(opt)
<ide> elif options.use_environment and env_name:
<del> print >>sys.stderr, ('Warning: environment regeneration unimplemented '
<add> print('Warning: environment regeneration unimplemented '
<ide> 'for %s flag %r env_name %r' % (action, opt,
<del> env_name))
<add> env_name), file=sys.stderr)
<ide> else:
<del> print >>sys.stderr, ('Warning: regeneration unimplemented for action %r '
<del> 'flag %r' % (action, opt))
<add> print('Warning: regeneration unimplemented for action %r '
<add> 'flag %r' % (action, opt), file=sys.stderr)
<ide>
<ide> return flags
<ide>
<del>class RegeneratableOptionParser(optparse.OptionParser):
<del> def __init__(self):
<add>class RegeneratableOptionParser(argparse.ArgumentParser):
<add> def __init__(self, usage):
<ide> self.__regeneratable_options = {}
<del> optparse.OptionParser.__init__(self)
<add> argparse.ArgumentParser.__init__(self, usage=usage)
<ide>
<del> def add_option(self, *args, **kw):
<add> def add_argument(self, *args, **kw):
<ide> """Add an option to the parser.
<ide>
<del> This accepts the same arguments as OptionParser.add_option, plus the
<add> This accepts the same arguments as ArgumentParser.add_argument, plus the
<ide> following:
<ide> regenerate: can be set to False to prevent this option from being included
<ide> in regeneration.
<ide> def add_option(self, *args, **kw):
<ide> # it as a string.
<ide> type = kw.get('type')
<ide> if type == 'path':
<del> kw['type'] = 'string'
<add> kw['type'] = str
<ide>
<ide> self.__regeneratable_options[dest] = {
<ide> 'action': kw.get('action'),
<ide> def add_option(self, *args, **kw):
<ide> 'opt': args[0],
<ide> }
<ide>
<del> optparse.OptionParser.add_option(self, *args, **kw)
<add> argparse.ArgumentParser.add_argument(self, *args, **kw)
<ide>
<ide> def parse_args(self, *args):
<del> values, args = optparse.OptionParser.parse_args(self, *args)
<add> values, args = argparse.ArgumentParser.parse_known_args(self, *args)
<ide> values._regeneration_metadata = self.__regeneratable_options
<ide> return values, args
<ide>
<ide> def gyp_main(args):
<ide> my_name = os.path.basename(sys.argv[0])
<add> usage = 'usage: %(prog)s [options ...] [build_file ...]'
<add>
<ide>
<del> parser = RegeneratableOptionParser()
<del> usage = 'usage: %s [options ...] [build_file ...]'
<del> parser.set_usage(usage.replace('%s', '%prog'))
<del> parser.add_option('--build', dest='configs', action='append',
<add> parser = RegeneratableOptionParser(usage=usage.replace('%s', '%(prog)s'))
<add> parser.add_argument('--build', dest='configs', action='append',
<ide> help='configuration for build after project generation')
<del> parser.add_option('--check', dest='check', action='store_true',
<add> parser.add_argument('--check', dest='check', action='store_true',
<ide> help='check format of gyp files')
<del> parser.add_option('--config-dir', dest='config_dir', action='store',
<add> parser.add_argument('--config-dir', dest='config_dir', action='store',
<ide> env_name='GYP_CONFIG_DIR', default=None,
<ide> help='The location for configuration files like '
<ide> 'include.gypi.')
<del> parser.add_option('-d', '--debug', dest='debug', metavar='DEBUGMODE',
<add> parser.add_argument('-d', '--debug', dest='debug', metavar='DEBUGMODE',
<ide> action='append', default=[], help='turn on a debugging '
<ide> 'mode for debugging GYP. Supported modes are "variables", '
<ide> '"includes" and "general" or "all" for all of them.')
<del> parser.add_option('-D', dest='defines', action='append', metavar='VAR=VAL',
<add> parser.add_argument('-D', dest='defines', action='append', metavar='VAR=VAL',
<ide> env_name='GYP_DEFINES',
<ide> help='sets variable VAR to value VAL')
<del> parser.add_option('--depth', dest='depth', metavar='PATH', type='path',
<add> parser.add_argument('--depth', dest='depth', metavar='PATH', type='path',
<ide> help='set DEPTH gyp variable to a relative path to PATH')
<del> parser.add_option('-f', '--format', dest='formats', action='append',
<add> parser.add_argument('-f', '--format', dest='formats', action='append',
<ide> env_name='GYP_GENERATORS', regenerate=False,
<ide> help='output formats to generate')
<del> parser.add_option('-G', dest='generator_flags', action='append', default=[],
<add> parser.add_argument('-G', dest='generator_flags', action='append', default=[],
<ide> metavar='FLAG=VAL', env_name='GYP_GENERATOR_FLAGS',
<ide> help='sets generator flag FLAG to VAL')
<del> parser.add_option('--generator-output', dest='generator_output',
<add> parser.add_argument('--generator-output', dest='generator_output',
<ide> action='store', default=None, metavar='DIR', type='path',
<ide> env_name='GYP_GENERATOR_OUTPUT',
<ide> help='puts generated build files under DIR')
<del> parser.add_option('--ignore-environment', dest='use_environment',
<add> parser.add_argument('--ignore-environment', dest='use_environment',
<ide> action='store_false', default=True, regenerate=False,
<ide> help='do not read options from environment variables')
<del> parser.add_option('-I', '--include', dest='includes', action='append',
<add> parser.add_argument('-I', '--include', dest='includes', action='append',
<ide> metavar='INCLUDE', type='path',
<ide> help='files to include in all loaded .gyp files')
<ide> # --no-circular-check disables the check for circular relationships between
<ide> def gyp_main(args):
<ide> # option allows the strict behavior to be used on Macs and the lenient
<ide> # behavior to be used elsewhere.
<ide> # TODO(mark): Remove this option when http://crbug.com/35878 is fixed.
<del> parser.add_option('--no-circular-check', dest='circular_check',
<add> parser.add_argument('--no-circular-check', dest='circular_check',
<ide> action='store_false', default=True, regenerate=False,
<ide> help="don't check for circular relationships between files")
<ide> # --no-duplicate-basename-check disables the check for duplicate basenames
<ide> def gyp_main(args):
<ide> # when duplicate basenames are passed into Make generator on Mac.
<ide> # TODO(yukawa): Remove this option when these legacy generators are
<ide> # deprecated.
<del> parser.add_option('--no-duplicate-basename-check',
<add> parser.add_argument('--no-duplicate-basename-check',
<ide> dest='duplicate_basename_check', action='store_false',
<ide> default=True, regenerate=False,
<ide> help="don't check for duplicate basenames")
<del> parser.add_option('--no-parallel', action='store_true', default=False,
<add> parser.add_argument('--no-parallel', action='store_true', default=False,
<ide> help='Disable multiprocessing')
<del> parser.add_option('-S', '--suffix', dest='suffix', default='',
<add> parser.add_argument('-S', '--suffix', dest='suffix', default='',
<ide> help='suffix to add to generated files')
<del> parser.add_option('--toplevel-dir', dest='toplevel_dir', action='store',
<add> parser.add_argument('--toplevel-dir', dest='toplevel_dir', action='store',
<ide> default=None, metavar='DIR', type='path',
<ide> help='directory to use as the root of the source tree')
<del> parser.add_option('-R', '--root-target', dest='root_targets',
<add> parser.add_argument('-R', '--root-target', dest='root_targets',
<ide> action='append', metavar='TARGET',
<ide> help='include only TARGET and its deep dependencies')
<ide>
<ide> def gyp_main(args):
<ide> for option, value in sorted(options.__dict__.items()):
<ide> if option[0] == '_':
<ide> continue
<del> if isinstance(value, basestring):
<add> if isinstance(value, string_types):
<ide> DebugOutput(DEBUG_GENERAL, " %s: '%s'", option, value)
<ide> else:
<ide> DebugOutput(DEBUG_GENERAL, " %s: %s", option, value)
<ide> def gyp_main(args):
<ide> build_file_dir = os.path.abspath(os.path.dirname(build_file))
<ide> build_file_dir_components = build_file_dir.split(os.path.sep)
<ide> components_len = len(build_file_dir_components)
<del> for index in xrange(components_len - 1, -1, -1):
<add> for index in range(components_len - 1, -1, -1):
<ide> if build_file_dir_components[index] == 'src':
<ide> options.depth = os.path.sep.join(build_file_dir_components)
<ide> break
<ide> def gyp_main(args):
<ide> if home_dot_gyp != None:
<ide> default_include = os.path.join(home_dot_gyp, 'include.gypi')
<ide> if os.path.exists(default_include):
<del> print 'Using overrides found in ' + default_include
<add> print('Using overrides found in ' + default_include)
<ide> includes.append(default_include)
<ide>
<ide> # Command-line --include files come after the default include.
<ide> def gyp_main(args):
<ide> def main(args):
<ide> try:
<ide> return gyp_main(args)
<del> except GypError, e:
<add> except GypError as e:
<ide> sys.stderr.write("gyp: %s\n" % e)
<ide> return 1
<ide>
<ide><path>tools/gyp/pylib/gyp/flock_tool.py
<ide> def ExecFlock(self, lockfile, *cmd_list):
<ide> # where fcntl.flock(fd, LOCK_EX) always fails
<ide> # with EBADF, that's why we use this F_SETLK
<ide> # hack instead.
<del> fd = os.open(lockfile, os.O_WRONLY|os.O_NOCTTY|os.O_CREAT, 0666)
<add> fd = os.open(lockfile, os.O_WRONLY|os.O_NOCTTY|os.O_CREAT, 0o666)
<ide> if sys.platform.startswith('aix'):
<ide> # Python on AIX is compiled with LARGEFILE support, which changes the
<ide> # struct size.
<ide><path>tools/gyp/pylib/gyp/generator/analyzer.py
<ide> then the "all" target includes "b1" and "b2".
<ide> """
<ide>
<add>from __future__ import print_function
<add>
<ide> import gyp.common
<ide> import gyp.ninja_syntax as ninja_syntax
<ide> import json
<ide> def _AddSources(sources, base_path, base_path_components, result):
<ide> continue
<ide> result.append(base_path + source)
<ide> if debug:
<del> print 'AddSource', org_source, result[len(result) - 1]
<add> print('AddSource', org_source, result[len(result) - 1])
<ide>
<ide>
<ide> def _ExtractSourcesFromAction(action, base_path, base_path_components,
<ide> def _ExtractSources(target, target_dict, toplevel_dir):
<ide> base_path += '/'
<ide>
<ide> if debug:
<del> print 'ExtractSources', target, base_path
<add> print('ExtractSources', target, base_path)
<ide>
<ide> results = []
<ide> if 'sources' in target_dict:
<ide> def _WasBuildFileModified(build_file, data, files, toplevel_dir):
<ide> the root of the source tree."""
<ide> if _ToLocalPath(toplevel_dir, _ToGypPath(build_file)) in files:
<ide> if debug:
<del> print 'gyp file modified', build_file
<add> print('gyp file modified', build_file)
<ide> return True
<ide>
<ide> # First element of included_files is the file itself.
<ide> def _WasBuildFileModified(build_file, data, files, toplevel_dir):
<ide> _ToGypPath(gyp.common.UnrelativePath(include_file, build_file))
<ide> if _ToLocalPath(toplevel_dir, rel_include_file) in files:
<ide> if debug:
<del> print 'included gyp file modified, gyp_file=', build_file, \
<del> 'included file=', rel_include_file
<add> print('included gyp file modified, gyp_file=', build_file,
<add> 'included file=', rel_include_file)
<ide> return True
<ide> return False
<ide>
<ide> def _GenerateTargets(data, target_list, target_dicts, toplevel_dir, files,
<ide> # If a build file (or any of its included files) is modified we assume all
<ide> # targets in the file are modified.
<ide> if build_file_in_files[build_file]:
<del> print 'matching target from modified build file', target_name
<add> print('matching target from modified build file', target_name)
<ide> target.match_status = MATCH_STATUS_MATCHES
<ide> matching_targets.append(target)
<ide> else:
<ide> sources = _ExtractSources(target_name, target_dicts[target_name],
<ide> toplevel_dir)
<ide> for source in sources:
<ide> if _ToGypPath(os.path.normpath(source)) in files:
<del> print 'target', target_name, 'matches', source
<add> print('target', target_name, 'matches', source)
<ide> target.match_status = MATCH_STATUS_MATCHES
<ide> matching_targets.append(target)
<ide> break
<ide> def _DoesTargetDependOnMatchingTargets(target):
<ide> for dep in target.deps:
<ide> if _DoesTargetDependOnMatchingTargets(dep):
<ide> target.match_status = MATCH_STATUS_MATCHES_BY_DEPENDENCY
<del> print '\t', target.name, 'matches by dep', dep.name
<add> print('\t', target.name, 'matches by dep', dep.name)
<ide> return True
<ide> target.match_status = MATCH_STATUS_DOESNT_MATCH
<ide> return False
<ide> def _GetTargetsDependingOnMatchingTargets(possible_targets):
<ide> supplied as input to analyzer.
<ide> possible_targets: targets to search from."""
<ide> found = []
<del> print 'Targets that matched by dependency:'
<add> print('Targets that matched by dependency:')
<ide> for target in possible_targets:
<ide> if _DoesTargetDependOnMatchingTargets(target):
<ide> found.append(target)
<ide> def _AddCompileTargets(target, roots, add_if_no_ancestor, result):
<ide> (add_if_no_ancestor or target.requires_build)) or
<ide> (target.is_static_library and add_if_no_ancestor and
<ide> not target.is_or_has_linked_ancestor)):
<del> print '\t\tadding to compile targets', target.name, 'executable', \
<del> target.is_executable, 'added_to_compile_targets', \
<del> target.added_to_compile_targets, 'add_if_no_ancestor', \
<del> add_if_no_ancestor, 'requires_build', target.requires_build, \
<del> 'is_static_library', target.is_static_library, \
<del> 'is_or_has_linked_ancestor', target.is_or_has_linked_ancestor
<add> print('\t\tadding to compile targets', target.name, 'executable',
<add> target.is_executable, 'added_to_compile_targets',
<add> target.added_to_compile_targets, 'add_if_no_ancestor',
<add> add_if_no_ancestor, 'requires_build', target.requires_build,
<add> 'is_static_library', target.is_static_library,
<add> 'is_or_has_linked_ancestor', target.is_or_has_linked_ancestor)
<ide> result.add(target)
<ide> target.added_to_compile_targets = True
<ide>
<ide> def _GetCompileTargets(matching_targets, supplied_targets):
<ide> supplied_targets: set of targets supplied to analyzer to search from."""
<ide> result = set()
<ide> for target in matching_targets:
<del> print 'finding compile targets for match', target.name
<add> print('finding compile targets for match', target.name)
<ide> _AddCompileTargets(target, supplied_targets, True, result)
<ide> return result
<ide>
<ide>
<ide> def _WriteOutput(params, **values):
<ide> """Writes the output, either to stdout or a file is specified."""
<ide> if 'error' in values:
<del> print 'Error:', values['error']
<add> print('Error:', values['error'])
<ide> if 'status' in values:
<del> print values['status']
<add> print(values['status'])
<ide> if 'targets' in values:
<ide> values['targets'].sort()
<del> print 'Supplied targets that depend on changed files:'
<add> print('Supplied targets that depend on changed files:')
<ide> for target in values['targets']:
<del> print '\t', target
<add> print('\t', target)
<ide> if 'invalid_targets' in values:
<ide> values['invalid_targets'].sort()
<del> print 'The following targets were not found:'
<add> print('The following targets were not found:')
<ide> for target in values['invalid_targets']:
<del> print '\t', target
<add> print('\t', target)
<ide> if 'build_targets' in values:
<ide> values['build_targets'].sort()
<del> print 'Targets that require a build:'
<add> print('Targets that require a build:')
<ide> for target in values['build_targets']:
<del> print '\t', target
<add> print('\t', target)
<ide> if 'compile_targets' in values:
<ide> values['compile_targets'].sort()
<del> print 'Targets that need to be built:'
<add> print('Targets that need to be built:')
<ide> for target in values['compile_targets']:
<del> print '\t', target
<add> print('\t', target)
<ide> if 'test_targets' in values:
<ide> values['test_targets'].sort()
<del> print 'Test targets:'
<add> print('Test targets:')
<ide> for target in values['test_targets']:
<del> print '\t', target
<add> print('\t', target)
<ide>
<ide> output_path = params.get('generator_flags', {}).get(
<ide> 'analyzer_output_path', None)
<ide> if not output_path:
<del> print json.dumps(values)
<add> print(json.dumps(values))
<ide> return
<ide> try:
<ide> f = open(output_path, 'w')
<ide> f.write(json.dumps(values) + '\n')
<ide> f.close()
<ide> except IOError as e:
<del> print 'Error writing to output file', output_path, str(e)
<add> print('Error writing to output file', output_path, str(e))
<ide>
<ide>
<ide> def _WasGypIncludeFileModified(params, files):
<ide> def _WasGypIncludeFileModified(params, files):
<ide> if params['options'].includes:
<ide> for include in params['options'].includes:
<ide> if _ToGypPath(os.path.normpath(include)) in files:
<del> print 'Include file modified, assuming all changed', include
<add> print('Include file modified, assuming all changed', include)
<ide> return True
<ide> return False
<ide>
<ide> def find_matching_test_target_names(self):
<ide> set(self._root_targets))]
<ide> else:
<ide> test_targets = [x for x in test_targets_no_all]
<del> print 'supplied test_targets'
<add> print('supplied test_targets')
<ide> for target_name in self._test_target_names:
<del> print '\t', target_name
<del> print 'found test_targets'
<add> print('\t', target_name)
<add> print('found test_targets')
<ide> for target in test_targets:
<del> print '\t', target.name
<del> print 'searching for matching test targets'
<add> print('\t', target.name)
<add> print('searching for matching test targets')
<ide> matching_test_targets = _GetTargetsDependingOnMatchingTargets(test_targets)
<ide> matching_test_targets_contains_all = (test_target_names_contains_all and
<ide> set(matching_test_targets) &
<ide> def find_matching_test_target_names(self):
<ide> # 'all' is subsequentely added to the matching names below.
<ide> matching_test_targets = [x for x in (set(matching_test_targets) &
<ide> set(test_targets_no_all))]
<del> print 'matched test_targets'
<add> print('matched test_targets')
<ide> for target in matching_test_targets:
<del> print '\t', target.name
<add> print('\t', target.name)
<ide> matching_target_names = [gyp.common.ParseQualifiedTarget(target.name)[1]
<ide> for target in matching_test_targets]
<ide> if matching_test_targets_contains_all:
<ide> matching_target_names.append('all')
<del> print '\tall'
<add> print('\tall')
<ide> return matching_target_names
<ide>
<ide> def find_matching_compile_target_names(self):
<ide> def find_matching_compile_target_names(self):
<ide> if 'all' in self._supplied_target_names():
<ide> supplied_targets = [x for x in (set(supplied_targets) |
<ide> set(self._root_targets))]
<del> print 'Supplied test_targets & compile_targets'
<add> print('Supplied test_targets & compile_targets')
<ide> for target in supplied_targets:
<del> print '\t', target.name
<del> print 'Finding compile targets'
<add> print('\t', target.name)
<add> print('Finding compile targets')
<ide> compile_targets = _GetCompileTargets(self._changed_targets,
<ide> supplied_targets)
<ide> return [gyp.common.ParseQualifiedTarget(target.name)[1]
<ide> def GenerateOutput(target_list, target_dicts, data, params):
<ide>
<ide> toplevel_dir = _ToGypPath(os.path.abspath(params['options'].toplevel_dir))
<ide> if debug:
<del> print 'toplevel_dir', toplevel_dir
<add> print('toplevel_dir', toplevel_dir)
<ide>
<ide> if _WasGypIncludeFileModified(params, config.files):
<ide> result_dict = { 'status': all_changed_string,
<ide><path>tools/gyp/pylib/gyp/generator/dump_dependency_json.py
<add>from __future__ import print_function
<ide> # Copyright (c) 2012 Google Inc. All rights reserved.
<ide> # Use of this source code is governed by a BSD-style license that can be
<ide> # found in the LICENSE file.
<ide> def GenerateOutput(target_list, target_dicts, data, params):
<ide> f = open(filename, 'w')
<ide> json.dump(edges, f)
<ide> f.close()
<del> print 'Wrote json to %s.' % filename
<add> print('Wrote json to %s.' % filename)
<ide><path>tools/gyp/pylib/gyp/generator/eclipse.py
<ide> def GetAllIncludeDirectories(target_list, target_dicts,
<ide> compiler_includes_list.append(include_dir)
<ide>
<ide> # Find standard gyp include dirs.
<del> if config.has_key('include_dirs'):
<add> if 'include_dirs' in config:
<ide> include_dirs = config['include_dirs']
<ide> for shared_intermediate_dir in shared_intermediate_dirs:
<ide> for include_dir in include_dirs:
<ide><path>tools/gyp/pylib/gyp/generator/gypd.py
<ide> def GenerateOutput(target_list, target_dicts, data, params):
<ide> if not output_file in output_files:
<ide> output_files[output_file] = input_file
<ide>
<del> for output_file, input_file in output_files.iteritems():
<add> for output_file, input_file in output_files.items():
<ide> output = open(output_file, 'w')
<ide> pprint.pprint(data[input_file], output)
<ide> output.close()
<ide><path>tools/gyp/pylib/gyp/input_test.py
<ide> def _create_dependency(self, dependent, dependency):
<ide> dependency.dependents.append(dependent)
<ide>
<ide> def test_no_cycle_empty_graph(self):
<del> for label, node in self.nodes.iteritems():
<del> self.assertEquals([], node.FindCycles())
<add> for label, node in self.nodes.items():
<add> self.assertEqual([], node.FindCycles())
<ide>
<ide> def test_no_cycle_line(self):
<ide> self._create_dependency(self.nodes['a'], self.nodes['b'])
<ide> self._create_dependency(self.nodes['b'], self.nodes['c'])
<ide> self._create_dependency(self.nodes['c'], self.nodes['d'])
<ide>
<del> for label, node in self.nodes.iteritems():
<del> self.assertEquals([], node.FindCycles())
<add> for label, node in self.nodes.items():
<add> self.assertEqual([], node.FindCycles())
<ide>
<ide> def test_no_cycle_dag(self):
<ide> self._create_dependency(self.nodes['a'], self.nodes['b'])
<ide> self._create_dependency(self.nodes['a'], self.nodes['c'])
<ide> self._create_dependency(self.nodes['b'], self.nodes['c'])
<ide>
<del> for label, node in self.nodes.iteritems():
<del> self.assertEquals([], node.FindCycles())
<add> for label, node in self.nodes.items():
<add> self.assertEqual([], node.FindCycles())
<ide>
<ide> def test_cycle_self_reference(self):
<ide> self._create_dependency(self.nodes['a'], self.nodes['a'])
<ide>
<del> self.assertEquals([[self.nodes['a'], self.nodes['a']]],
<add> self.assertEqual([[self.nodes['a'], self.nodes['a']]],
<ide> self.nodes['a'].FindCycles())
<ide>
<ide> def test_cycle_two_nodes(self):
<ide> self._create_dependency(self.nodes['a'], self.nodes['b'])
<ide> self._create_dependency(self.nodes['b'], self.nodes['a'])
<ide>
<del> self.assertEquals([[self.nodes['a'], self.nodes['b'], self.nodes['a']]],
<add> self.assertEqual([[self.nodes['a'], self.nodes['b'], self.nodes['a']]],
<ide> self.nodes['a'].FindCycles())
<del> self.assertEquals([[self.nodes['b'], self.nodes['a'], self.nodes['b']]],
<add> self.assertEqual([[self.nodes['b'], self.nodes['a'], self.nodes['b']]],
<ide> self.nodes['b'].FindCycles())
<ide>
<ide> def test_two_cycles(self):
<ide> def test_two_cycles(self):
<ide> [self.nodes['a'], self.nodes['b'], self.nodes['a']] in cycles)
<ide> self.assertTrue(
<ide> [self.nodes['b'], self.nodes['c'], self.nodes['b']] in cycles)
<del> self.assertEquals(2, len(cycles))
<add> self.assertEqual(2, len(cycles))
<ide>
<ide> def test_big_cycle(self):
<ide> self._create_dependency(self.nodes['a'], self.nodes['b'])
<ide> def test_big_cycle(self):
<ide> self._create_dependency(self.nodes['d'], self.nodes['e'])
<ide> self._create_dependency(self.nodes['e'], self.nodes['a'])
<ide>
<del> self.assertEquals([[self.nodes['a'],
<add> self.assertEqual([[self.nodes['a'],
<ide> self.nodes['b'],
<ide> self.nodes['c'],
<ide> self.nodes['d'],
<ide><path>tools/gyp/pylib/gyp/ordered_dict.py
<ide> def itervalues(self):
<ide> for k in self:
<ide> yield self[k]
<ide>
<del> def iteritems(self):
<del> 'od.iteritems -> an iterator over the (key, value) items in od'
<add> def items(self):
<add> 'od.items -> an iterator over the (key, value) items in od'
<ide> for k in self:
<ide> yield (k, self[k])
<ide>
<ide><path>tools/gyp/pylib/gyp/simple_copy.py
<ide> def deepcopy(x):
<ide> def _deepcopy_atomic(x):
<ide> return x
<ide>
<del>for x in (type(None), int, long, float,
<del> bool, str, unicode, type):
<add>try:
<add> types = bool, float, int, str, type, type(None), long, unicode
<add>except NameError: # Python 3
<add> types = bool, float, int, str, type, type(None)
<add>
<add>for x in types:
<ide> d[x] = _deepcopy_atomic
<ide>
<ide> def _deepcopy_list(x):
<ide> def _deepcopy_list(x):
<ide>
<ide> def _deepcopy_dict(x):
<ide> y = {}
<del> for key, value in x.iteritems():
<add> for key, value in x.items():
<ide> y[deepcopy(key)] = deepcopy(value)
<ide> return y
<ide> d[dict] = _deepcopy_dict
<ide><path>tools/gyp/tools/graphviz.py
<ide> generate input suitable for graphviz to render a dependency graph of
<ide> targets."""
<ide>
<add>from __future__ import print_function
<add>
<ide> import collections
<ide> import json
<ide> import sys
<ide> def WriteGraph(edges):
<ide> build_file, target_name, toolset = ParseTarget(src)
<ide> files[build_file].append(src)
<ide>
<del> print 'digraph D {'
<del> print ' fontsize=8' # Used by subgraphs.
<del> print ' node [fontsize=8]'
<add> print('digraph D {')
<add> print(' fontsize=8') # Used by subgraphs.
<add> print(' node [fontsize=8]')
<ide>
<ide> # Output nodes by file. We must first write out each node within
<ide> # its file grouping before writing out any edges that may refer
<ide> def WriteGraph(edges):
<ide> # the display by making it a box without an internal node.
<ide> target = targets[0]
<ide> build_file, target_name, toolset = ParseTarget(target)
<del> print ' "%s" [shape=box, label="%s\\n%s"]' % (target, filename,
<del> target_name)
<add> print(' "%s" [shape=box, label="%s\\n%s"]' % (target, filename,
<add> target_name))
<ide> else:
<ide> # Group multiple nodes together in a subgraph.
<del> print ' subgraph "cluster_%s" {' % filename
<del> print ' label = "%s"' % filename
<add> print(' subgraph "cluster_%s" {' % filename)
<add> print(' label = "%s"' % filename)
<ide> for target in targets:
<ide> build_file, target_name, toolset = ParseTarget(target)
<del> print ' "%s" [label="%s"]' % (target, target_name)
<del> print ' }'
<add> print(' "%s" [label="%s"]' % (target, target_name))
<add> print(' }')
<ide>
<ide> # Now that we've placed all the nodes within subgraphs, output all
<ide> # the edges between nodes.
<ide> for src, dsts in edges.items():
<ide> for dst in dsts:
<del> print ' "%s" -> "%s"' % (src, dst)
<add> print(' "%s" -> "%s"' % (src, dst))
<ide>
<del> print '}'
<add> print('}')
<ide>
<ide>
<ide> def main():
<ide> if len(sys.argv) < 2:
<del> print >>sys.stderr, __doc__
<del> print >>sys.stderr
<del> print >>sys.stderr, 'usage: %s target1 target2...' % (sys.argv[0])
<add> print(__doc__, file=sys.stderr)
<add> print(file=sys.stderr)
<add> print('usage: %s target1 target2...' % (sys.argv[0]), file=sys.stderr)
<ide> return 1
<ide>
<ide> edges = LoadEdges('dump.json', sys.argv[1:])
<ide><path>tools/gyp/tools/pretty_gyp.py
<ide>
<ide> """Pretty-prints the contents of a GYP file."""
<ide>
<add>from __future__ import print_function
<add>
<ide> import sys
<ide> import re
<ide>
<ide> def prettyprint_input(lines):
<ide> basic_offset = 2
<ide> last_line = ""
<ide> for line in lines:
<del> line = line.strip('\r\n\t ') # Otherwise doesn't strip \r on Unix.
<del> if len(line) > 0:
<del> brace_diff = 0
<del> if not COMMENT_RE.match(line):
<add> if COMMENT_RE.match(line):
<add> print(line)
<add> else:
<add> line = line.strip('\r\n\t ') # Otherwise doesn't strip \r on Unix.
<add> if len(line) > 0:
<ide> (brace_diff, after) = count_braces(line)
<del> if brace_diff != 0:
<del> if after:
<del> print " " * (basic_offset * indent) + line
<del> indent += brace_diff
<add> if brace_diff != 0:
<add> if after:
<add> print(" " * (basic_offset * indent) + line)
<add> indent += brace_diff
<add> else:
<add> indent += brace_diff
<add> print(" " * (basic_offset * indent) + line)
<ide> else:
<del> indent += brace_diff
<del> print " " * (basic_offset * indent) + line
<add> print(" " * (basic_offset * indent) + line)
<ide> else:
<del> print " " * (basic_offset * indent) + line
<del> else:
<del> print ""
<del> last_line = line
<add> print("")
<add> last_line = line
<ide>
<ide>
<ide> def main():
<ide><path>tools/gyp/tools/pretty_sln.py
<ide> Then it outputs a possible build order.
<ide> """
<ide>
<del>__author__ = 'nsylvain (Nicolas Sylvain)'
<add>from __future__ import print_function
<ide>
<ide> import os
<ide> import re
<ide> import sys
<ide> import pretty_vcproj
<ide>
<add>__author__ = 'nsylvain (Nicolas Sylvain)'
<add>
<ide> def BuildProject(project, built, projects, deps):
<ide> # if all dependencies are done, we can build it, otherwise we try to build the
<ide> # dependency.
<ide> # This is not infinite-recursion proof.
<ide> for dep in deps[project]:
<ide> if dep not in built:
<ide> BuildProject(dep, built, projects, deps)
<del> print project
<add> print(project)
<ide> built.append(project)
<ide>
<ide> def ParseSolution(solution_file):
<ide> def ParseSolution(solution_file):
<ide> return (projects, dependencies)
<ide>
<ide> def PrintDependencies(projects, deps):
<del> print "---------------------------------------"
<del> print "Dependencies for all projects"
<del> print "---------------------------------------"
<del> print "-- --"
<add> print("---------------------------------------")
<add> print("Dependencies for all projects")
<add> print("---------------------------------------")
<add> print("-- --")
<ide>
<ide> for (project, dep_list) in sorted(deps.items()):
<del> print "Project : %s" % project
<del> print "Path : %s" % projects[project][0]
<add> print("Project : %s" % project)
<add> print("Path : %s" % projects[project][0])
<ide> if dep_list:
<ide> for dep in dep_list:
<del> print " - %s" % dep
<del> print ""
<add> print(" - %s" % dep)
<add> print("")
<ide>
<del> print "-- --"
<add> print("-- --")
<ide>
<ide> def PrintBuildOrder(projects, deps):
<del> print "---------------------------------------"
<del> print "Build order "
<del> print "---------------------------------------"
<del> print "-- --"
<add> print("---------------------------------------")
<add> print("Build order ")
<add> print("---------------------------------------")
<add> print("-- --")
<ide>
<ide> built = []
<ide> for (project, _) in sorted(deps.items()):
<ide> if project not in built:
<ide> BuildProject(project, built, projects, deps)
<ide>
<del> print "-- --"
<add> print("-- --")
<ide>
<ide> def PrintVCProj(projects):
<ide>
<ide> for project in projects:
<del> print "-------------------------------------"
<del> print "-------------------------------------"
<del> print project
<del> print project
<del> print project
<del> print "-------------------------------------"
<del> print "-------------------------------------"
<add> print("-------------------------------------")
<add> print("-------------------------------------")
<add> print(project)
<add> print(project)
<add> print(project)
<add> print("-------------------------------------")
<add> print("-------------------------------------")
<ide>
<ide> project_path = os.path.abspath(os.path.join(os.path.dirname(sys.argv[1]),
<ide> projects[project][2]))
<ide> def PrintVCProj(projects):
<ide> def main():
<ide> # check if we have exactly 1 parameter.
<ide> if len(sys.argv) < 2:
<del> print 'Usage: %s "c:\\path\\to\\project.sln"' % sys.argv[0]
<add> print('Usage: %s "c:\\path\\to\\project.sln"' % sys.argv[0])
<ide> return 1
<ide>
<ide> (projects, deps) = ParseSolution(sys.argv[1])
<ide><path>tools/gyp/tools/pretty_vcproj.py
<ide> It outputs the resulting xml to stdout.
<ide> """
<ide>
<del>__author__ = 'nsylvain (Nicolas Sylvain)'
<add>from __future__ import print_function
<ide>
<ide> import os
<ide> import sys
<ide>
<ide> from xml.dom.minidom import parse
<ide> from xml.dom.minidom import Node
<ide>
<add>__author__ = 'nsylvain (Nicolas Sylvain)'
<add>
<add>try:
<add> cmp
<add>except NameError:
<add> def cmp(x, y):
<add> return (x > y) - (x < y)
<add>
<ide> REPLACEMENTS = dict()
<ide> ARGUMENTS = None
<ide>
<ide> def get_string(node):
<ide> def PrettyPrintNode(node, indent=0):
<ide> if node.nodeType == Node.TEXT_NODE:
<ide> if node.data.strip():
<del> print '%s%s' % (' '*indent, node.data.strip())
<add> print('%s%s' % (' '*indent, node.data.strip()))
<ide> return
<ide>
<ide> if node.childNodes:
<ide> def PrettyPrintNode(node, indent=0):
<ide>
<ide> # Print the main tag
<ide> if attr_count == 0:
<del> print '%s<%s>' % (' '*indent, node.nodeName)
<add> print('%s<%s>' % (' '*indent, node.nodeName))
<ide> else:
<del> print '%s<%s' % (' '*indent, node.nodeName)
<add> print('%s<%s' % (' '*indent, node.nodeName))
<ide>
<ide> all_attributes = []
<ide> for (name, value) in node.attributes.items():
<ide> all_attributes.append((name, value))
<ide> all_attributes.sort(CmpTuple())
<ide> for (name, value) in all_attributes:
<del> print '%s %s="%s"' % (' '*indent, name, value)
<del> print '%s>' % (' '*indent)
<add> print('%s %s="%s"' % (' '*indent, name, value))
<add> print('%s>' % (' '*indent))
<ide> if node.nodeValue:
<del> print '%s %s' % (' '*indent, node.nodeValue)
<add> print('%s %s' % (' '*indent, node.nodeValue))
<ide>
<ide> for sub_node in node.childNodes:
<ide> PrettyPrintNode(sub_node, indent=indent+2)
<del> print '%s</%s>' % (' '*indent, node.nodeName)
<add> print('%s</%s>' % (' '*indent, node.nodeName))
<ide>
<ide>
<ide> def FlattenFilter(node):
<ide> def main(argv):
<ide>
<ide> # check if we have exactly 1 parameter.
<ide> if len(argv) < 2:
<del> print ('Usage: %s "c:\\path\\to\\vcproj.vcproj" [key1=value1] '
<del> '[key2=value2]' % argv[0])
<add> print('Usage: %s "c:\\path\\to\\vcproj.vcproj" [key1=value1] '
<add> '[key2=value2]' % argv[0])
<ide> return 1
<ide>
<ide> # Parse the keys | 16 |
Go | Go | remove unused parsetmpfsoptions | 144c95029c9658a89f28668b9faf6343face2344 | <ide><path>pkg/mount/flags.go
<ide> func parseOptions(options string) (int, string) {
<ide> }
<ide> return flag, strings.Join(data, ",")
<ide> }
<del>
<del>// ParseTmpfsOptions parse fstab type mount options into flags and data
<del>func ParseTmpfsOptions(options string) (int, string, error) {
<del> flags, data := parseOptions(options)
<del> for _, o := range strings.Split(data, ",") {
<del> opt := strings.SplitN(o, "=", 2)
<del> if !validFlags[opt[0]] {
<del> return 0, "", fmt.Errorf("Invalid tmpfs option %q", opt)
<del> }
<del> }
<del> return flags, data, nil
<del>} | 1 |
Text | Text | add license file to each component | 9e57e8bea04638d5bafec62db1051fbc2ce39e3a | <ide><path>src/Illuminate/Auth/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Broadcasting/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Bus/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Cache/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Config/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Console/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Container/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Contracts/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Cookie/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Database/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Encryption/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Events/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Filesystem/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Hashing/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Http/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Log/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Mail/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Notifications/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Pagination/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Pipeline/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Queue/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Redis/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Routing/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Session/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Support/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Translation/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/Validation/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE.
<ide><path>src/Illuminate/View/LICENSE.md
<add>The MIT License (MIT)
<add>
<add>Copyright (c) Taylor Otwell
<add>
<add>Permission is hereby granted, free of charge, to any person obtaining a copy
<add>of this software and associated documentation files (the "Software"), to deal
<add>in the Software without restriction, including without limitation the rights
<add>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
<add>copies of the Software, and to permit persons to whom the Software is
<add>furnished to do so, subject to the following conditions:
<add>
<add>The above copyright notice and this permission notice shall be included in
<add>all copies or substantial portions of the Software.
<add>
<add>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
<add>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
<add>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
<add>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
<add>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
<add>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
<add>THE SOFTWARE. | 28 |
Text | Text | add notes for v1.4.10 | 82a4545e772400127cc909ff44f95809e8790bae | <ide><path>CHANGELOG.md
<add><a name="1.4.10"></a>
<add># 1.4.10 benignant-oscillation (2016-03-16)
<add>
<add>
<add>## Bug Fixes
<add>
<add>- **core:** only call `console.log` when `window.console` exists
<add> ([beb00e44](https://github.com/angular/angular.js/commit/beb00e44de947981dbe35d5cf7a116e10ea8dc67),
<add> [#14006](https://github.com/angular/angular.js/issues/14006), [#14007](https://github.com/angular/angular.js/issues/14007), [#14047](https://github.com/angular/angular.js/issues/14047))
<add>- **$animateCss:** cancel fallback timeout when animation ends normally
<add> ([a60bbc12](https://github.com/angular/angular.js/commit/a60bbc12e8c5170e70d95f1b2c3e309b3b95cb84),
<add> [#13787](https://github.com/angular/angular.js/issues/13787))
<add>- **$compile:**
<add> - allow directives to have decorators
<add> ([77cdc37c](https://github.com/angular/angular.js/commit/77cdc37c65491b551fcf01a18ab848a693c293d7))
<add> - properly denormalize templates when only one of the start/end symbols is different
<add> ([2d44a681](https://github.com/angular/angular.js/commit/2d44a681eb912a81a8bc8e16a278c45dae91fa24),
<add> [#13848](https://github.com/angular/angular.js/issues/13848))
<add> - handle boolean attributes in `@` bindings
<add> ([2ffbfb0a](https://github.com/angular/angular.js/commit/2ffbfb0ad0647d103ff339ee4b772b62d4823bf3),
<add> [#13767](https://github.com/angular/angular.js/issues/13767), [#13769](https://github.com/angular/angular.js/issues/13769))
<add>- **$parse:**
<add> - prevent assignment on constructor properties
<add> ([f47e2180](https://github.com/angular/angular.js/commit/f47e218006029f39b4785d820b430de3a0eebcb0),
<add> [#13417](https://github.com/angular/angular.js/issues/13417))
<add> - preserve expensive checks when runnning `$eval` inside an expression
<add> ([96d62cc0](https://github.com/angular/angular.js/commit/96d62cc0fc77248d7e3ec4aa458bac0d3e072629))
<add> - copy `inputs` for expressions with expensive checks
<add> ([0b7fff30](https://github.com/angular/angular.js/commit/0b7fff303f46202bbae1ff3ca9d0e5fa76e0fc9a))
<add>- **$rootScope:** set no context when calling helper functions for `$watch`
<add> ([ab5c7698](https://github.com/angular/angular.js/commit/ab5c7698bb106669ca31b5f79a95afa54d65c5f1))
<add>- **$route:** allow preventing a route reload
<add> ([4bc30314](https://github.com/angular/angular.js/commit/4bc3031497447ad527356f12bd0ceee1d7d09db5),
<add> [#9824](https://github.com/angular/angular.js/issues/9824), [#13894](https://github.com/angular/angular.js/issues/13894))
<add>- **$routeProvider:** properly handle optional eager path named groups
<add> ([6a4403a1](https://github.com/angular/angular.js/commit/6a4403a11845173d6a96232f77d73aa544b182af),
<add> [#14011](https://github.com/angular/angular.js/issues/14011))
<add>- **copy:** add support for copying `Blob` objects
<add> ([863a4232](https://github.com/angular/angular.js/commit/863a4232a6faa92428df45cd54d5a519be2434de),
<add> [#9669](https://github.com/angular/angular.js/issues/9669), [#14064](https://github.com/angular/angular.js/issues/14064))
<add>- **dateFilter:** follow the CLDR on pattern escape sequences
<add> ([f476060d](https://github.com/angular/angular.js/commit/f476060de6cc016380c0343490a184543f853652),
<add> [#12839](https://github.com/angular/angular.js/issues/12839))
<add>- **dateFilter, input:** fix Date parsing in IE/Edge when timezone offset contains `:`
<add> ([571afd65](https://github.com/angular/angular.js/commit/571afd6558786d7b99e2aebd307b4a94c9f2bb87),
<add> [#13880](https://github.com/angular/angular.js/issues/13880), [#13887](https://github.com/angular/angular.js/issues/13887))
<add>- **input:** re-validate when partially editing date-family inputs
<add> ([02929f82](https://github.com/angular/angular.js/commit/02929f82f30449301ff18fea84a6396a017683b1),
<add> [#12207](https://github.com/angular/angular.js/issues/12207), [#13886](https://github.com/angular/angular.js/issues/13886))
<add>- **select:** handle corner case of adding options via a custom directive
<add> ([df6e7315](https://github.com/angular/angular.js/commit/df6e731506831a3dc7f44c9a90abe17515450b3e),
<add> [#13874](https://github.com/angular/angular.js/issues/13874), [#13878](https://github.com/angular/angular.js/issues/13878))
<add>- **ngOptions:** always set the 'selected' attribute for selected options
<add> ([f87e8288](https://github.com/angular/angular.js/commit/f87e8288fb69526fd240a66a046f5de52ed204de),
<add> [#14115](https://github.com/angular/angular.js/issues/14115))
<add>- **ngAnimate:** properly cancel previously running class-based animations
<add> ([3b27dd37](https://github.com/angular/angular.js/commit/3b27dd37a2cc8a52992784ece6b371023dadf792),
<add> [#10156](https://github.com/angular/angular.js/issues/10156), [#13822](https://github.com/angular/angular.js/issues/13822))
<add>- **ngAnimateChildren:** make it compatible with `ngIf`
<add> ([dc158e7e](https://github.com/angular/angular.js/commit/dc158e7e40624ef94c66560386522ef7e991a9ce),
<add> [#13865](https://github.com/angular/angular.js/issues/13865), [#13876](https://github.com/angular/angular.js/issues/13876))
<add>- **ngMockE2E:** pass `responseType` to `$delegate` when using `passThrough`
<add> ([947cb4d1](https://github.com/angular/angular.js/commit/947cb4d1451afa4f5090a693df5b1968dd0df70c),
<add> [#5415](https://github.com/angular/angular.js/issues/5415), [#5783](https://github.com/angular/angular.js/issues/5783))
<add>
<add>
<add>## Features
<add>
<add>- **$locale:** Include original locale ID in $locale
<add> ([e69f3550](https://github.com/angular/angular.js/commit/e69f35507e10c994708ce4f1efba7573951d1acd),
<add> [#13390](https://github.com/angular/angular.js/issues/13390))
<add>- **ngAnimate:** provide ng-[event]-prepare class for structural animations
<add> ([796f7ab4](https://github.com/angular/angular.js/commit/796f7ab41487e124b5b0c02dbf0a03bd581bf073))
<add>
<add>
<add>## Performance Improvements
<add>
<add>- **$compile:** avoid needless overhead when wrapping text nodes
<add> ([946d9ae9](https://github.com/angular/angular.js/commit/946d9ae90bb31fe911ebbe1b80cd4c8af5a665c6))
<add>- **ngRepeat:** avoid duplicate jqLite wrappers
<add> ([d04c38c4](https://github.com/angular/angular.js/commit/d04c38c48968db777c3ea6a177ce2ff0116df7b4))
<add>- **ngAnimate:**
<add> - avoid jqLite/jQuery for upward DOM traversal
<add> ([ab95ba65](https://github.com/angular/angular.js/commit/ab95ba65c08b38cace83de6717b7681079182b45))
<add> - avoid `$.fn.data` overhead with jQuery
<add> ([86416bcb](https://github.com/angular/angular.js/commit/86416bcbee2192fa31c017163c5d856763182ade))
<add>
<add>
<ide> <a name="1.5.1"></a>
<ide> # 1.5.1 equivocal-sophistication (2016-03-16)
<ide> | 1 |
Javascript | Javascript | remove all special code for ie8 | e843ae7a4cfb746760e1d8c3578d9ec613c3e2ee | <ide><path>src/ng/compile.js
<ide> function $CompileProvider($provide, $$sanitizeUriProvider) {
<ide> var attrEndName = false;
<ide>
<ide> attr = nAttrs[j];
<del> if (!msie || msie >= 8 || attr.specified) {
<del> name = attr.name;
<del> value = trim(attr.value);
<del>
<del> // support ngAttr attribute binding
<del> ngAttrName = directiveNormalize(name);
<del> if (isNgAttr = NG_ATTR_BINDING.test(ngAttrName)) {
<del> name = snake_case(ngAttrName.substr(6), '-');
<del> }
<add> name = attr.name;
<add> value = trim(attr.value);
<ide>
<del> var directiveNName = ngAttrName.replace(/(Start|End)$/, '');
<del> if (directiveIsMultiElement(directiveNName)) {
<del> if (ngAttrName === directiveNName + 'Start') {
<del> attrStartName = name;
<del> attrEndName = name.substr(0, name.length - 5) + 'end';
<del> name = name.substr(0, name.length - 6);
<del> }
<del> }
<add> // support ngAttr attribute binding
<add> ngAttrName = directiveNormalize(name);
<add> if (isNgAttr = NG_ATTR_BINDING.test(ngAttrName)) {
<add> name = snake_case(ngAttrName.substr(6), '-');
<add> }
<ide>
<del> nName = directiveNormalize(name.toLowerCase());
<del> attrsMap[nName] = name;
<del> if (isNgAttr || !attrs.hasOwnProperty(nName)) {
<del> attrs[nName] = value;
<del> if (getBooleanAttrName(node, nName)) {
<del> attrs[nName] = true; // presence means true
<del> }
<add> var directiveNName = ngAttrName.replace(/(Start|End)$/, '');
<add> if (directiveIsMultiElement(directiveNName)) {
<add> if (ngAttrName === directiveNName + 'Start') {
<add> attrStartName = name;
<add> attrEndName = name.substr(0, name.length - 5) + 'end';
<add> name = name.substr(0, name.length - 6);
<ide> }
<del> addAttrInterpolateDirective(node, directives, value, nName, isNgAttr);
<del> addDirective(directives, nName, 'A', maxPriority, ignoreDirective, attrStartName,
<del> attrEndName);
<ide> }
<add>
<add> nName = directiveNormalize(name.toLowerCase());
<add> attrsMap[nName] = name;
<add> if (isNgAttr || !attrs.hasOwnProperty(nName)) {
<add> attrs[nName] = value;
<add> if (getBooleanAttrName(node, nName)) {
<add> attrs[nName] = true; // presence means true
<add> }
<add> }
<add> addAttrInterpolateDirective(node, directives, value, nName, isNgAttr);
<add> addDirective(directives, nName, 'A', maxPriority, ignoreDirective, attrStartName,
<add> attrEndName);
<ide> }
<ide>
<ide> // use class as directive
<ide><path>src/ng/directive/a.js
<ide> var htmlAnchorDirective = valueFn({
<ide> restrict: 'E',
<ide> compile: function(element, attr) {
<del>
<del> if (msie <= 8) {
<del>
<del> // turn <a href ng-click="..">link</a> into a stylable link in IE
<del> // but only if it doesn't have name attribute, in which case it's an anchor
<del> if (!attr.href && !attr.name) {
<del> attr.$set('href', '');
<del> }
<del>
<del> // add a comment node to anchors to workaround IE bug that causes element content to be reset
<del> // to new attribute content if attribute is updated with value containing @ and element also
<del> // contains value with @
<del> // see issue #1949
<del> element.append(document.createComment('IE fix'));
<del> }
<del>
<ide> if (!attr.href && !attr.xlinkHref && !attr.name) {
<ide> return function(scope, element) {
<ide> // SVGAElement does not use the href attribute, but rather the 'xlinkHref' attribute.
<ide><path>src/ng/sanitizeUri.js
<ide> function $$SanitizeUriProvider() {
<ide> return function sanitizeUri(uri, isImage) {
<ide> var regex = isImage ? imgSrcSanitizationWhitelist : aHrefSanitizationWhitelist;
<ide> var normalizedVal;
<del> // NOTE: urlResolve() doesn't support IE < 8 so we don't sanitize for that case.
<del> if (!msie || msie >= 8 ) {
<del> normalizedVal = urlResolve(uri).href;
<del> if (normalizedVal !== '' && !normalizedVal.match(regex)) {
<del> return 'unsafe:'+normalizedVal;
<del> }
<add> normalizedVal = urlResolve(uri).href;
<add> if (normalizedVal !== '' && !normalizedVal.match(regex)) {
<add> return 'unsafe:'+normalizedVal;
<ide> }
<ide> return uri;
<ide> };
<ide><path>src/ngScenario/browserTrigger.js
<ide> return keys.indexOf(key) !== -1;
<ide> }
<ide>
<del> if (msie < 9) {
<del> if (inputType == 'radio' || inputType == 'checkbox') {
<del> element.checked = !element.checked;
<add> var evnt;
<add> if(/transitionend/.test(eventType)) {
<add> if(window.WebKitTransitionEvent) {
<add> evnt = new WebKitTransitionEvent(eventType, eventData);
<add> evnt.initEvent(eventType, false, true);
<ide> }
<del>
<del> // WTF!!! Error: Unspecified error.
<del> // Don't know why, but some elements when detached seem to be in inconsistent state and
<del> // calling .fireEvent() on them will result in very unhelpful error (Error: Unspecified error)
<del> // forcing the browser to compute the element position (by reading its CSS)
<del> // puts the element in consistent state.
<del> element.style.posLeft;
<del>
<del> // TODO(vojta): create event objects with pressed keys to get it working on IE<9
<del> var ret = element.fireEvent('on' + eventType);
<del> if (inputType == 'submit') {
<del> while(element) {
<del> if (element.nodeName.toLowerCase() == 'form') {
<del> element.fireEvent('onsubmit');
<del> break;
<del> }
<del> element = element.parentNode;
<del> }
<del> }
<del> return ret;
<del> } else {
<del> var evnt;
<del> if(/transitionend/.test(eventType)) {
<del> if(window.WebKitTransitionEvent) {
<del> evnt = new WebKitTransitionEvent(eventType, eventData);
<del> evnt.initEvent(eventType, false, true);
<add> else {
<add> try {
<add> evnt = new TransitionEvent(eventType, eventData);
<ide> }
<del> else {
<del> try {
<del> evnt = new TransitionEvent(eventType, eventData);
<del> }
<del> catch(e) {
<del> evnt = document.createEvent('TransitionEvent');
<del> evnt.initTransitionEvent(eventType, null, null, null, eventData.elapsedTime || 0);
<del> }
<add> catch(e) {
<add> evnt = document.createEvent('TransitionEvent');
<add> evnt.initTransitionEvent(eventType, null, null, null, eventData.elapsedTime || 0);
<ide> }
<ide> }
<del> else if(/animationend/.test(eventType)) {
<del> if(window.WebKitAnimationEvent) {
<del> evnt = new WebKitAnimationEvent(eventType, eventData);
<del> evnt.initEvent(eventType, false, true);
<del> }
<del> else {
<del> try {
<del> evnt = new AnimationEvent(eventType, eventData);
<del> }
<del> catch(e) {
<del> evnt = document.createEvent('AnimationEvent');
<del> evnt.initAnimationEvent(eventType, null, null, null, eventData.elapsedTime || 0);
<del> }
<del> }
<add> }
<add> else if(/animationend/.test(eventType)) {
<add> if(window.WebKitAnimationEvent) {
<add> evnt = new WebKitAnimationEvent(eventType, eventData);
<add> evnt.initEvent(eventType, false, true);
<ide> }
<ide> else {
<del> evnt = document.createEvent('MouseEvents');
<del> x = x || 0;
<del> y = y || 0;
<del> evnt.initMouseEvent(eventType, true, true, window, 0, x, y, x, y, pressed('ctrl'),
<del> pressed('alt'), pressed('shift'), pressed('meta'), 0, element);
<add> try {
<add> evnt = new AnimationEvent(eventType, eventData);
<add> }
<add> catch(e) {
<add> evnt = document.createEvent('AnimationEvent');
<add> evnt.initAnimationEvent(eventType, null, null, null, eventData.elapsedTime || 0);
<add> }
<ide> }
<add> }
<add> else {
<add> evnt = document.createEvent('MouseEvents');
<add> x = x || 0;
<add> y = y || 0;
<add> evnt.initMouseEvent(eventType, true, true, window, 0, x, y, x, y, pressed('ctrl'),
<add> pressed('alt'), pressed('shift'), pressed('meta'), 0, element);
<add> }
<ide>
<del> /* we're unable to change the timeStamp value directly so this
<del> * is only here to allow for testing where the timeStamp value is
<del> * read */
<del> evnt.$manualTimeStamp = eventData.timeStamp;
<add> /* we're unable to change the timeStamp value directly so this
<add> * is only here to allow for testing where the timeStamp value is
<add> * read */
<add> evnt.$manualTimeStamp = eventData.timeStamp;
<ide>
<del> if(!evnt) return;
<add> if(!evnt) return;
<ide>
<del> var originalPreventDefault = evnt.preventDefault,
<del> appWindow = element.ownerDocument.defaultView,
<del> fakeProcessDefault = true,
<del> finalProcessDefault,
<del> angular = appWindow.angular || {};
<add> var originalPreventDefault = evnt.preventDefault,
<add> appWindow = element.ownerDocument.defaultView,
<add> fakeProcessDefault = true,
<add> finalProcessDefault,
<add> angular = appWindow.angular || {};
<ide>
<del> // igor: temporary fix for https://bugzilla.mozilla.org/show_bug.cgi?id=684208
<del> angular['ff-684208-preventDefault'] = false;
<del> evnt.preventDefault = function() {
<del> fakeProcessDefault = false;
<del> return originalPreventDefault.apply(evnt, arguments);
<del> };
<add> // igor: temporary fix for https://bugzilla.mozilla.org/show_bug.cgi?id=684208
<add> angular['ff-684208-preventDefault'] = false;
<add> evnt.preventDefault = function() {
<add> fakeProcessDefault = false;
<add> return originalPreventDefault.apply(evnt, arguments);
<add> };
<ide>
<del> element.dispatchEvent(evnt);
<del> finalProcessDefault = !(angular['ff-684208-preventDefault'] || !fakeProcessDefault);
<add> element.dispatchEvent(evnt);
<add> finalProcessDefault = !(angular['ff-684208-preventDefault'] || !fakeProcessDefault);
<ide>
<del> delete angular['ff-684208-preventDefault'];
<add> delete angular['ff-684208-preventDefault'];
<ide>
<del> return finalProcessDefault;
<del> }
<add> return finalProcessDefault;
<ide> };
<ide> }());
<ide><path>test/AngularSpec.js
<ide> describe('angular', function() {
<ide>
<ide> it('should correctly test for keys that are present on Object.prototype', function() {
<ide> /* jshint -W001 */
<del> // MS IE8 just doesn't work for this kind of thing, since "for ... in" doesn't return
<del> // things like hasOwnProperty even if it is explicitly defined on the actual object!
<del> if (msie<=8) return;
<ide> expect(equals({}, {hasOwnProperty: 1})).toBe(false);
<ide> expect(equals({}, {toString: null})).toBe(false);
<ide> });
<ide> describe('angular', function() {
<ide> expect(div.childNodes[0].getAttribute('ngtest:attr')).toBe('bar');
<ide> });
<ide>
<del> if (!msie || msie >= 9) {
<del> it('should correctly detect node name with "namespace" when xmlns is NOT defined', function() {
<del> var div = jqLite('<div xmlns:ngtest="http://angularjs.org/">' +
<del> '<ngtest:foo ngtest:attr="bar"></ng-test>' +
<del> '</div>')[0];
<del> expect(nodeName_(div.childNodes[0])).toBe('ngtest:foo');
<del> expect(div.childNodes[0].getAttribute('ngtest:attr')).toBe('bar');
<del> });
<del> }
<add> it('should correctly detect node name with "namespace" when xmlns is NOT defined', function() {
<add> var div = jqLite('<div xmlns:ngtest="http://angularjs.org/">' +
<add> '<ngtest:foo ngtest:attr="bar"></ng-test>' +
<add> '</div>')[0];
<add> expect(nodeName_(div.childNodes[0])).toBe('ngtest:foo');
<add> expect(div.childNodes[0].getAttribute('ngtest:attr')).toBe('bar');
<add> });
<ide> });
<ide>
<ide>
<ide><path>test/jqLiteSpec.js
<ide> describe('jqLite', function() {
<ide> expect(input.attr('READONLY')).toBe('readonly');
<ide>
<ide> input.attr('readonly', false);
<del>
<del> // attr('readonly') fails in jQuery 1.6.4, so we have to bypass it
<del> //expect(input.attr('readOnly')).toBeUndefined();
<del> //expect(input.attr('readonly')).toBeUndefined();
<del> if (msie < 9) {
<del> expect(input[0].getAttribute('readonly')).toBe('');
<del> } else {
<del> expect(input[0].getAttribute('readonly')).toBe(null);
<del> }
<del> //expect('readOnly' in input[0].attributes).toBe(false);
<add> expect(input[0].getAttribute('readonly')).toBe(null);
<ide>
<ide> input.attr('readOnly', 'READonly');
<ide> expect(input.attr('readonly')).toBe('readonly');
<ide> describe('jqLite', function() {
<ide> expect(jqLite(b).css('margin')).toEqual('3px');
<ide>
<ide> selector.css('margin', '');
<del> if (msie <= 8) {
<del> expect(jqLite(a).css('margin')).toBe('auto');
<del> expect(jqLite(b).css('margin')).toBe('auto');
<del> } else {
<del> expect(jqLite(a).css('margin')).toBeFalsy();
<del> expect(jqLite(b).css('margin')).toBeFalsy();
<del> }
<add> expect(jqLite(a).css('margin')).toBeFalsy();
<add> expect(jqLite(b).css('margin')).toBeFalsy();
<ide> });
<ide>
<ide>
<ide> it('should set a bunch of css properties specified via an object', function() {
<del> if (msie <= 8) {
<del> expect(jqLite(a).css('margin')).toBe('auto');
<del> expect(jqLite(a).css('padding')).toBe('0px');
<del> expect(jqLite(a).css('border')).toBeUndefined();
<del> } else {
<del> expect(jqLite(a).css('margin')).toBeFalsy();
<del> expect(jqLite(a).css('padding')).toBeFalsy();
<del> expect(jqLite(a).css('border')).toBeFalsy();
<del> }
<add> expect(jqLite(a).css('margin')).toBeFalsy();
<add> expect(jqLite(a).css('padding')).toBeFalsy();
<add> expect(jqLite(a).css('border')).toBeFalsy();
<ide>
<ide> jqLite(a).css({'margin': '1px', 'padding': '2px', 'border': ''});
<ide>
<ide> describe('jqLite', function() {
<ide> if (window.jQuery) return;
<ide> var browserMoveTrigger = function(from, to){
<ide> var fireEvent = function(type, element, relatedTarget){
<del> var evnt, msie = parseInt((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1]);
<del> if (msie < 9){
<del> evnt = document.createEventObject();
<del> evnt.srcElement = element;
<del> evnt.relatedTarget = relatedTarget;
<del> element.fireEvent('on' + type, evnt);
<del> return;
<del> }
<add> var evnt;
<ide> evnt = document.createEvent('MouseEvents');
<ide>
<ide> var originalPreventDefault = evnt.preventDefault,
<ide> describe('jqLite', function() {
<ide> });
<ide>
<ide> it('should select all types iframe contents', function() {
<del> // IE8 does not like this test, although the functionality may still work there.
<del> if (msie < 9) return;
<ide> var iframe_ = document.createElement('iframe');
<ide> var tested = false;
<ide> var iframe = jqLite(iframe_);
<ide><path>test/ng/compileSpec.js
<ide> describe('$compile', function() {
<ide> // it turns out that when a browser plugin is bound to an DOM element (typically <object>),
<ide> // the plugin's context rather than the usual DOM apis are exposed on this element, so
<ide> // childNodes might not exist.
<del> if (msie < 9) return;
<ide>
<ide> element = jqLite('<div>{{1+2}}</div>');
<ide>
<ide><path>test/ng/directive/aSpec.js
<ide> describe('a', function() {
<ide>
<ide> element = $compile('<a href="">empty link</a>')($rootScope);
<ide>
<del> if (msie < 9) {
<add> event = document.createEvent('MouseEvent');
<add> event.initMouseEvent(
<add> 'click', true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
<ide>
<del> event = document.createEventObject();
<del> expect(event.returnValue).not.toBeDefined();
<del> element[0].fireEvent('onclick', event);
<del> expect(event.returnValue).toEqual(false);
<add> event.preventDefaultOrg = event.preventDefault;
<add> event.preventDefault = function() {
<add> preventDefaultCalled = true;
<add> if (this.preventDefaultOrg) this.preventDefaultOrg();
<add> };
<ide>
<del> } else {
<add> element[0].dispatchEvent(event);
<ide>
<del> event = document.createEvent('MouseEvent');
<del> event.initMouseEvent(
<del> 'click', true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
<del>
<del> event.preventDefaultOrg = event.preventDefault;
<del> event.preventDefault = function() {
<del> preventDefaultCalled = true;
<del> if (this.preventDefaultOrg) this.preventDefaultOrg();
<del> };
<del>
<del> element[0].dispatchEvent(event);
<del>
<del> expect(preventDefaultCalled).toEqual(true);
<del> }
<add> expect(preventDefaultCalled).toEqual(true);
<ide>
<ide> expect(document.location.href).toEqual(orgLocation);
<ide> });
<ide> describe('a', function() {
<ide> element = $compile('<svg><a xlink:href="">empty link</a></svg>')($rootScope);
<ide> child = element.children('a');
<ide>
<del> if (msie < 9) {
<del>
<del> event = document.createEventObject();
<del> expect(event.returnValue).not.toBeDefined();
<del> child[0].fireEvent('onclick', event);
<del> expect(event.returnValue).toEqual(false);
<del>
<del> } else {
<del>
<del> event = document.createEvent('MouseEvent');
<del> event.initMouseEvent(
<del> 'click', true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
<del>
<del> event.preventDefaultOrg = event.preventDefault;
<del> event.preventDefault = function() {
<del> preventDefaultCalled = true;
<del> if (this.preventDefaultOrg) this.preventDefaultOrg();
<del> };
<add> event = document.createEvent('MouseEvent');
<add> event.initMouseEvent(
<add> 'click', true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
<ide>
<del> child[0].dispatchEvent(event);
<add> event.preventDefaultOrg = event.preventDefault;
<add> event.preventDefault = function() {
<add> preventDefaultCalled = true;
<add> if (this.preventDefaultOrg) this.preventDefaultOrg();
<add> };
<ide>
<del> expect(preventDefaultCalled).toEqual(true);
<del> }
<add> child[0].dispatchEvent(event);
<ide>
<add> expect(preventDefaultCalled).toEqual(true);
<ide> expect(document.location.href).toEqual(orgLocation);
<ide> });
<ide>
<ide><path>test/ng/directive/booleanAttrsSpec.js
<ide> describe('boolean attr directives', function() {
<ide>
<ide>
<ide> it('should throw an exception if binding to multiple attribute', inject(function($rootScope, $compile) {
<del> if (msie < 9) return; //IE8 doesn't support biding to boolean attributes
<del>
<ide> expect(function() {
<ide> $compile('<select multiple="{{isMultiple}}"></select>');
<ide> }).toThrowMinErr('$compile', 'selmulti', 'Binding to the \'multiple\' attribute is not supported. ' +
<ide><path>test/ng/directive/formSpec.js
<ide> describe('form', function() {
<ide> reloadPrevented = e.defaultPrevented || (e.returnValue === false);
<ide> };
<ide>
<del> // native dom event listeners in IE8 fire in LIFO order so we have to register them
<del> // there in different order than in other browsers
<del> if (msie==8) addEventListenerFn(doc[0], 'submit', assertPreventDefaultListener);
<del>
<ide> $compile(doc)(scope);
<ide>
<ide> scope.submitMe = function() {
<ide> submitted = true;
<ide> };
<ide>
<del> if (msie!=8) addEventListenerFn(doc[0], 'submit', assertPreventDefaultListener);
<add> addEventListenerFn(doc[0], 'submit', assertPreventDefaultListener);
<ide>
<ide> browserTrigger(doc.find('input'));
<ide>
<ide> describe('form', function() {
<ide> reloadPrevented = e.defaultPrevented || (e.returnValue === false);
<ide> };
<ide>
<del> // native dom event listeners in IE8 fire in LIFO order so we have to register them
<del> // there in different order than in other browsers
<del> if (msie == 8) addEventListenerFn(form[0], 'submit', assertPreventDefaultListener);
<del>
<ide> $compile(doc)(scope);
<ide>
<del> if (msie != 8) addEventListenerFn(form[0], 'submit', assertPreventDefaultListener);
<add> addEventListenerFn(form[0], 'submit', assertPreventDefaultListener);
<ide>
<ide> browserTrigger(doc.find('button'), 'click');
<ide>
<ide> describe('form', function() {
<ide>
<ide> waitsFor(function() { return nextTurn; });
<ide>
<del>
<del> // I can't get IE8 to automatically trigger submit in this test, in production it does it
<del> // properly
<del> if (msie == 8) browserTrigger(form, 'submit');
<del>
<ide> runs(function() {
<ide> expect(doc.html()).toBe('');
<ide> expect(destroyed).toBe(true);
<ide> describe('form', function() {
<ide> // the issue in the wild, I'm not going to bother to do it
<ide> // now. (i)
<ide>
<del> // IE9 and IE10 are special and don't fire submit event when form was destroyed
<del> if (msie < 9) {
<del> expect(reloadPrevented).toBe(true);
<del> $timeout.flush();
<del> }
<del>
<ide> // prevent mem leak in test
<ide> removeEventListenerFn(form[0], 'submit', assertPreventDefaultListener);
<ide> });
<ide><path>test/ng/directive/inputSpec.js
<ide> describe('input', function() {
<ide> expect(scope.name).toEqual('adam');
<ide> });
<ide>
<del> if (!msie || msie >= 9) {
<del> describe('compositionevents', function() {
<del> it('should not update the model between "compositionstart" and "compositionend" on non android', inject(function($sniffer) {
<del> $sniffer.android = false;
<del>
<del> compileInput('<input type="text" ng-model="name" name="alias"" />');
<del> changeInputValueTo('a');
<del> expect(scope.name).toEqual('a');
<del> browserTrigger(inputElm, 'compositionstart');
<del> changeInputValueTo('adam');
<del> expect(scope.name).toEqual('a');
<del> browserTrigger(inputElm, 'compositionend');
<del> changeInputValueTo('adam');
<del> expect(scope.name).toEqual('adam');
<del> }));
<add> describe('compositionevents', function() {
<add> it('should not update the model between "compositionstart" and "compositionend" on non android', inject(function($sniffer) {
<add> $sniffer.android = false;
<ide>
<del> it('should update the model between "compositionstart" and "compositionend" on android', inject(function($sniffer) {
<del> $sniffer.android = true;
<del>
<del> compileInput('<input type="text" ng-model="name" name="alias"" />');
<del> changeInputValueTo('a');
<del> expect(scope.name).toEqual('a');
<del> browserTrigger(inputElm, 'compositionstart');
<del> changeInputValueTo('adam');
<del> expect(scope.name).toEqual('adam');
<del> browserTrigger(inputElm, 'compositionend');
<del> changeInputValueTo('adam2');
<del> expect(scope.name).toEqual('adam2');
<del> }));
<del> });
<del> }
<add> compileInput('<input type="text" ng-model="name" name="alias"" />');
<add> changeInputValueTo('a');
<add> expect(scope.name).toEqual('a');
<add> browserTrigger(inputElm, 'compositionstart');
<add> changeInputValueTo('adam');
<add> expect(scope.name).toEqual('a');
<add> browserTrigger(inputElm, 'compositionend');
<add> changeInputValueTo('adam');
<add> expect(scope.name).toEqual('adam');
<add> }));
<ide>
<del> it('should update the model on "compositionend"', function() {
<del> compileInput('<input type="text" ng-model="name" name="alias" />');
<del> if (!msie || msie >= 9) {
<add> it('should update the model between "compositionstart" and "compositionend" on android', inject(function($sniffer) {
<add> $sniffer.android = true;
<add>
<add> compileInput('<input type="text" ng-model="name" name="alias"" />');
<add> changeInputValueTo('a');
<add> expect(scope.name).toEqual('a');
<ide> browserTrigger(inputElm, 'compositionstart');
<del> changeInputValueTo('caitp');
<del> expect(scope.name).toBeUndefined();
<add> changeInputValueTo('adam');
<add> expect(scope.name).toEqual('adam');
<ide> browserTrigger(inputElm, 'compositionend');
<del> expect(scope.name).toEqual('caitp');
<del> }
<add> changeInputValueTo('adam2');
<add> expect(scope.name).toEqual('adam2');
<add> }));
<add> });
<add>
<add> it('should update the model on "compositionend"', function() {
<add> compileInput('<input type="text" ng-model="name" name="alias" />');
<add> browserTrigger(inputElm, 'compositionstart');
<add> changeInputValueTo('caitp');
<add> expect(scope.name).toBeUndefined();
<add> browserTrigger(inputElm, 'compositionend');
<add> expect(scope.name).toEqual('caitp');
<ide> });
<ide>
<ide> it('should not dirty the model on an input event in response to a placeholder change', inject(function($sniffer) {
<ide><path>test/ng/directive/ngRepeatSpec.js
<ide> describe('ngRepeat', function() {
<ide> }));
<ide>
<ide>
<del> if (!msie || msie > 8) {
<del> // only IE>8 supports element directives
<del>
<del> it('should work when placed on a root element of element directive with ASYNC replaced template',
<del> inject(function($templateCache, $compile, $rootScope) {
<del> $compileProvider.directive('replaceMeWithRepeater', function() {
<del> return {
<del> restrict: 'E',
<del> replace: true,
<del> templateUrl: 'replace-me-with-repeater.html'
<del> };
<del> });
<del> $templateCache.put('replace-me-with-repeater.html', '<div ng-repeat="i in [1,2,3]">{{i}}</div>');
<del> element = $compile('<div><replace-me-with-repeater></replace-me-with-repeater></div>')($rootScope);
<del> expect(element.text()).toBe('');
<del> $rootScope.$apply();
<del> expect(element.text()).toBe('123');
<del> }));
<del> }
<add> it('should work when placed on a root element of element directive with ASYNC replaced template',
<add> inject(function($templateCache, $compile, $rootScope) {
<add> $compileProvider.directive('replaceMeWithRepeater', function() {
<add> return {
<add> restrict: 'E',
<add> replace: true,
<add> templateUrl: 'replace-me-with-repeater.html'
<add> };
<add> });
<add> $templateCache.put('replace-me-with-repeater.html', '<div ng-repeat="i in [1,2,3]">{{i}}</div>');
<add> element = $compile('<div><replace-me-with-repeater></replace-me-with-repeater></div>')($rootScope);
<add> expect(element.text()).toBe('');
<add> $rootScope.$apply();
<add> expect(element.text()).toBe('123');
<add> }));
<ide>
<ide> it('should work when combined with an ASYNC template that loads after the first digest', inject(function($httpBackend, $compile, $rootScope) {
<ide> $compileProvider.directive('test', function() {
<ide><path>test/ng/httpSpec.js
<ide> describe('$http', function() {
<ide> });
<ide>
<ide> it('should not double quote dates', function() {
<del> if (msie < 9) return;
<ide> $httpBackend.expect('GET', '/url?date=2014-07-15T17:30:00.000Z').respond('');
<ide> $http({url: '/url', params: {date:new Date('2014-07-15T17:30:00.000Z')}, method: 'GET'});
<ide> });
<ide><path>test/ng/locationSpec.js
<ide> describe('$location', function() {
<ide> );
<ide> });
<ide>
<del> // don't run next tests on IE<9, as browserTrigger does not simulate pressed keys
<del> if (!msie || msie >= 9) {
<del>
<del> it('should not rewrite when clicked with ctrl pressed', function() {
<del> configureService({linkHref: '/a?b=c', html5Mode: true, supportHist: true});
<del> inject(
<del> initBrowser(),
<del> initLocation(),
<del> function($browser) {
<del> browserTrigger(link, 'click', { keys: ['ctrl'] });
<del> expectNoRewrite($browser);
<del> }
<del> );
<del> });
<add> it('should not rewrite when clicked with ctrl pressed', function() {
<add> configureService({linkHref: '/a?b=c', html5Mode: true, supportHist: true});
<add> inject(
<add> initBrowser(),
<add> initLocation(),
<add> function($browser) {
<add> browserTrigger(link, 'click', { keys: ['ctrl'] });
<add> expectNoRewrite($browser);
<add> }
<add> );
<add> });
<ide>
<ide>
<del> it('should not rewrite when clicked with meta pressed', function() {
<del> configureService({linkHref: '/a?b=c', html5Mode: true, supportHist: true});
<del> inject(
<del> initBrowser(),
<del> initLocation(),
<del> function($browser) {
<del> browserTrigger(link, 'click', { keys: ['meta'] });
<del> expectNoRewrite($browser);
<del> }
<del> );
<del> });
<del> }
<add> it('should not rewrite when clicked with meta pressed', function() {
<add> configureService({linkHref: '/a?b=c', html5Mode: true, supportHist: true});
<add> inject(
<add> initBrowser(),
<add> initLocation(),
<add> function($browser) {
<add> browserTrigger(link, 'click', { keys: ['meta'] });
<add> expectNoRewrite($browser);
<add> }
<add> );
<add> });
<ide>
<ide>
<ide> it('should not mess up hash urls when clicking on links in hashbang mode', function() {
<ide><path>test/ngMock/angular-mocksSpec.js
<ide> describe('ngMock', function() {
<ide> /* jshint -W001 */
<ide> // MS IE8 just doesn't work for this kind of thing, since "for ... in" doesn't return
<ide> // things like hasOwnProperty even if it is explicitly defined on the actual object!
<del> if ($sniffer.msie<=8) return;
<ide> $rootScope.hasOwnProperty = 'X';
<ide> expect(d($rootScope)).toMatch(/Scope\(.*\): \{/);
<ide> expect(d($rootScope)).toMatch(/hasOwnProperty: "X"/);
<ide> describe('ngMock', function() {
<ide> // when thrown from a function defined on window (which `inject` is).
<ide>
<ide> it('should not change thrown Errors', inject(function($sniffer) {
<del> if ($sniffer.msie <= 8) return;
<del>
<ide> expect(function() {
<ide> inject(function() {
<ide> throw new Error('test message');
<ide> describe('ngMock', function() {
<ide> }));
<ide>
<ide> it('should not change thrown strings', inject(function($sniffer) {
<del> if ($sniffer.msie <= 8) return;
<del>
<ide> expect(function() {
<ide> inject(function() {
<ide> throw 'test message';
<ide><path>test/ngTouch/directive/ngSwipeSpec.js
<ide> var swipeTests = function(description, restrictBrowsers, startEvent, moveEvent,
<ide> }
<ide> }
<ide>
<del> // Skip tests on IE < 9. These versions of IE don't support createEvent(), and so
<del> // we cannot control the (x,y) position of events.
<del> // It works fine in IE 8 under manual testing.
<del> var msie = +((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1]);
<del> if (msie < 9) {
<del> return;
<del> }
<del>
<ide> beforeEach(function() {
<ide> module('ngTouch');
<ide> });
<ide><path>test/ngTouch/swipeSpec.js
<ide> describe('$swipe', function() {
<ide> var element;
<ide> var events;
<ide>
<del> // Skip tests on IE < 9. These versions of IE don't support createEvent(), and so
<del> // we cannot control the (x,y) position of events.
<del> // It works fine in IE 8 under manual testing.
<del> var msie = +((/msie (\d+)/.exec(navigator.userAgent.toLowerCase()) || [])[1]);
<del> if (msie < 9) {
<del> return;
<del> }
<del>
<ide> beforeEach(function() {
<ide> module('ngTouch');
<ide> inject(function($compile, $rootScope) { | 17 |
Javascript | Javascript | set fragment export flags to true | f6894dc48be2e389ffae03cea736122a971e3f76 | <ide><path>packages/react-cs-renderer/src/ReactNativeCSFeatureFlags.js
<ide> import typeof * as CSFeatureFlagsType from './ReactNativeCSFeatureFlags';
<ide> export const debugRenderPhaseSideEffects = false;
<ide> export const enableAsyncSubtreeAPI = true;
<ide> export const enableAsyncSchedulingByDefaultInReactDOM = false;
<del>export const enableReactFragment = false;
<ide> export const enableCreateRoot = false;
<ide> export const enableUserTimingAPI = __DEV__;
<ide>
<ide><path>packages/react-dom/src/__tests__/ReactDOMServerIntegrationFragment-test.internal.js
<ide> let ReactDOMServer;
<ide> function initModules() {
<ide> // Reset warning cache.
<ide> jest.resetModuleRegistry();
<del> require('shared/ReactFeatureFlags').enableReactFragment = true;
<ide> React = require('react');
<ide> ReactDOM = require('react-dom');
<ide> ReactDOMServer = require('react-dom/server');
<ide><path>packages/react-native-renderer/src/ReactNativeFeatureFlags.js
<ide> export const {debugRenderPhaseSideEffects} = require('ReactFeatureFlags');
<ide> // The rest of the flags are static for better dead code elimination.
<ide> export const enableAsyncSubtreeAPI = true;
<ide> export const enableAsyncSchedulingByDefaultInReactDOM = false;
<del>export const enableReactFragment = false;
<ide> export const enableCreateRoot = false;
<ide> export const enableUserTimingAPI = __DEV__;
<ide> export const enableMutatingReconciler = true;
<ide><path>packages/react-reconciler/src/ReactChildFiber.js
<ide> import type {ReactCall, ReactPortal, ReactReturn} from 'shared/ReactTypes';
<ide> import type {Fiber} from 'react-reconciler/src/ReactFiber';
<ide> import type {ExpirationTime} from 'react-reconciler/src/ReactFiberExpirationTime';
<ide>
<del>import {enableReactFragment} from 'shared/ReactFeatureFlags';
<ide> import {Placement, Deletion} from 'shared/ReactTypeOfSideEffect';
<ide> import {
<ide> getIteratorFn,
<ide> function ChildReconciler(shouldTrackSideEffects) {
<ide> // This leads to an ambiguity between <>{[...]}</> and <>...</>.
<ide> // We treat the ambiguous cases above the same.
<ide> if (
<del> enableReactFragment &&
<ide> typeof newChild === 'object' &&
<ide> newChild !== null &&
<ide> newChild.type === REACT_FRAGMENT_TYPE &&
<ide><path>packages/react-reconciler/src/__tests__/ReactFragment-test.internal.js
<ide> describe('ReactFragment', () => {
<ide> beforeEach(function() {
<ide> jest.resetModules();
<ide>
<del> const ReactFeatureFlags = require('shared/ReactFeatureFlags');
<del> ReactFeatureFlags.enableReactFragment = true;
<del>
<ide> React = require('react');
<ide> ReactNoop = require('react-noop-renderer');
<ide> });
<ide><path>packages/react/src/React.js
<ide>
<ide> import assign from 'object-assign';
<ide> import ReactVersion from 'shared/ReactVersion';
<del>import {enableReactFragment} from 'shared/ReactFeatureFlags';
<ide> import {REACT_FRAGMENT_TYPE} from 'shared/ReactSymbols';
<ide>
<ide> import {Component, PureComponent, AsyncComponent} from './ReactBaseClasses';
<ide> var React = {
<ide> PureComponent,
<ide> unstable_AsyncComponent: AsyncComponent,
<ide>
<add> Fragment: REACT_FRAGMENT_TYPE,
<add>
<ide> createElement: __DEV__ ? createElementWithValidation : createElement,
<ide> cloneElement: __DEV__ ? cloneElementWithValidation : cloneElement,
<ide> createFactory: __DEV__ ? createFactoryWithValidation : createFactory,
<ide> var React = {
<ide> },
<ide> };
<ide>
<del>if (enableReactFragment) {
<del> React.Fragment = REACT_FRAGMENT_TYPE;
<del>}
<del>
<ide> if (__DEV__) {
<ide> Object.assign(React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, {
<ide> // These should not be included in production.
<ide><path>packages/react/src/__tests__/ReactJSXElementValidator-test.internal.js
<ide> describe('ReactJSXElementValidator', () => {
<ide> beforeEach(() => {
<ide> jest.resetModules();
<ide>
<del> const ReactFeatureFlags = require('shared/ReactFeatureFlags');
<del> ReactFeatureFlags.enableReactFragment = true;
<del>
<ide> React = require('react');
<ide> ReactTestUtils = require('react-dom/test-utils');
<ide> });
<ide><path>packages/shared/ReactFeatureFlags.js
<ide> import invariant from 'fbjs/lib/invariant';
<ide>
<ide> export const enableAsyncSubtreeAPI = true;
<ide> export const enableAsyncSchedulingByDefaultInReactDOM = false;
<del>// Exports React.Fragment
<del>export const enableReactFragment = false;
<ide> // Exports ReactDOM.createRoot
<ide> export const enableCreateRoot = false;
<ide> export const enableUserTimingAPI = __DEV__;
<ide><path>scripts/rollup/shims/rollup/ReactFeatureFlags-www.js
<ide> export const {
<ide>
<ide> // The rest of the flags are static for better dead code elimination.
<ide> export const enableAsyncSubtreeAPI = true;
<del>export const enableReactFragment = false;
<ide> export const enableCreateRoot = true;
<ide>
<ide> // The www bundles only use the mutating reconciler. | 9 |
Javascript | Javascript | set icon on macos | 9b76d2d7b3a86ffde945f88b758a0537aeca027a | <ide><path>packages/react-devtools/app.js
<ide>
<ide> const {app, BrowserWindow} = require('electron'); // Module to create native browser window.
<ide> const {join} = require('path');
<add>const os = require('os');
<ide>
<ide> const argv = require('minimist')(process.argv.slice(2));
<ide> const projectRoots = argv._;
<ide> app.on('ready', function() {
<ide> },
<ide> });
<ide>
<add> // set dock icon for macos
<add> if (os.platform() === 'darwin') {
<add> app.dock.setIcon(join(__dirname, 'icons/icon128.png'));
<add> }
<add>
<ide> // https://stackoverflow.com/questions/32402327/
<ide> mainWindow.webContents.on('new-window', function(event, url) {
<ide> event.preventDefault(); | 1 |
Text | Text | add util.inspect() legacy signature | 5e63cf29bfd09ad2c099b937602a355bd08ecdc4 | <ide><path>doc/api/util.md
<ide> stream.write('With ES6');
<ide> ```
<ide>
<ide> ## util.inspect(object[, options])
<add>## util.inspect(object[, showHidden[, depth[, colors]]])
<ide> <!-- YAML
<ide> added: v0.3.0
<ide> changes: | 1 |
Ruby | Ruby | install bundler into vendor directory | c87c97e4d7dc485753d39523ef9e6dd5f82333d7 | <ide><path>Library/Homebrew/dev-cmd/tests.rb
<ide> def tests
<ide>
<ide> puts "Randomized with seed #{seed}"
<ide>
<del> # Let tests find `bundle` in the actual location.
<del> ENV["HOMEBREW_TESTS_GEM_USER_DIR"] = gem_user_dir
<del>
<del> # Let `bundle` in PATH find its gem.
<del> ENV["GEM_PATH"] = "#{ENV.fetch("GEM_PATH")}:#{gem_user_dir}"
<del>
<ide> # Submit test flakiness information using BuildPulse
<ide> # BUILDPULSE used in spec_helper.rb
<ide> if use_buildpulse?
<ide><path>Library/Homebrew/utils/gems.rb
<ide> def ruby_bindir
<ide> "#{RbConfig::CONFIG["prefix"]}/bin"
<ide> end
<ide>
<del> def gem_user_dir
<del> ENV.fetch("HOMEBREW_TESTS_GEM_USER_DIR", nil) || Gem.user_dir
<del> end
<del>
<del> def gem_user_bindir
<del> "#{gem_user_dir}/bin"
<del> end
<del>
<ide> def ohai_if_defined(message)
<ide> if defined?(ohai)
<ide> $stderr.ohai message
<ide> def odie_if_defined(message)
<ide> end
<ide> end
<ide>
<del> def setup_gem_environment!(gem_home: nil, gem_bindir: nil, setup_path: true)
<add> def setup_gem_environment!(setup_path: true)
<ide> # Match where our bundler gems are.
<del> gem_home ||= "#{HOMEBREW_LIBRARY_PATH}/vendor/bundle/ruby/#{RbConfig::CONFIG["ruby_version"]}"
<add> gem_home = "#{HOMEBREW_LIBRARY_PATH}/vendor/bundle/ruby/#{RbConfig::CONFIG["ruby_version"]}"
<ide> Gem.paths = {
<ide> "GEM_HOME" => gem_home,
<ide> "GEM_PATH" => gem_home,
<ide> def setup_gem_environment!(gem_home: nil, gem_bindir: nil, setup_path: true)
<ide> return unless setup_path
<ide>
<ide> # Add necessary Ruby and Gem binary directories to `PATH`.
<del> gem_bindir ||= Gem.bindir
<ide> paths = ENV.fetch("PATH").split(":")
<del> paths.unshift(gem_bindir) unless paths.include?(gem_bindir)
<ide> paths.unshift(ruby_bindir) unless paths.include?(ruby_bindir)
<add> paths.unshift(Gem.bindir) unless paths.include?(Gem.bindir)
<ide> ENV["PATH"] = paths.compact.join(":")
<ide>
<ide> # Set envs so the above binaries can be invoked.
<ide> def install_bundler!
<ide> raise "Installing and using Bundler is currently only supported on Ruby 2.6."
<ide> end
<ide>
<del> setup_gem_environment!(gem_home: gem_user_dir, gem_bindir: gem_user_bindir)
<add> setup_gem_environment!
<ide> install_gem_setup_path!(
<ide> "bundler",
<ide> version: HOMEBREW_BUNDLER_VERSION, | 2 |
Text | Text | add more info on attach inspired by discussion in | 801edfa9b8a765e734ac4a909ab032f0cb03fe87 | <ide><path>docs/sources/reference/commandline/cli.md
<ide> Docker supports softlinks for the Docker data directory
<ide> --no-stdin=false Do not attach STDIN
<ide> --sig-proxy=true Proxy all received signals to the process (even in non-TTY mode). SIGCHLD, SIGKILL, and SIGSTOP are not proxied.
<ide>
<del>The `attach` command will allow you to view or
<del>interact with any running container, detached (`-d`)
<del>or interactive (`-i`). You can attach to the same
<del>container at the same time - screen sharing style, or quickly view the
<del>progress of your daemonized process.
<add>The `attach` command lets you view or interact with any running container's
<add>primary process (`pid 1`).
<add>
<add>You can attach to the same contained process multiple times simultaneously, screen
<add>sharing style, or quickly view the progress of your daemonized process.
<add>
<add>> **Note:** This command is not for running a new process in a container.
<add>> See: [`docker exec`](#exec).
<ide>
<ide> You can detach from the container again (and leave it running) with
<ide> `CTRL-p CTRL-q` (for a quiet exit), or `CTRL-c` which will send a | 1 |
Text | Text | fix typo seemless -> seamless [ci skip] | c1b94cbbe34ea54425dac8a6cd810aeb5952bc2d | <ide><path>guides/source/upgrading_ruby_on_rails.md
<ide> config.load_defaults(7.0)
<ide> ```
<ide>
<ide> However Rails 6.1 applications are not able to read this new serialization format,
<del>so to ensure a seemless upgrade you must first deploy your Rails 7.0 upgrade with
<add>so to ensure a seamless upgrade you must first deploy your Rails 7.0 upgrade with
<ide> `config.active_support.cache_format_version = 6.1`, and then only once all Rails
<ide> processes have been updated you can set `config.active_support.cache_format_version = 7.0`.
<ide> | 1 |
Python | Python | reduce led memory | c8ea582ed65ead33603286de6800bb6107843a9f | <ide><path>tests/test_modeling_led.py
<ide> def test_seq_to_seq_generation(self):
<ide>
<ide> dct = tok.batch_encode_plus(
<ide> [ARTICLE_LEP, ARTICLE_MAGNET],
<del> max_length=12288,
<add> max_length=6144,
<ide> padding="max_length",
<add> truncation=True,
<ide> return_tensors="pt",
<ide> )
<ide>
<ide> def test_seq_to_seq_generation(self):
<ide> no_repeat_ngram_size=3,
<ide> )
<ide>
<del> EXPECTED_LEP = " the physics of @xmath0-boson will again play the central role in the frontier of particle physics if the gigaz option of the international linear collider ( ilc ) is realized in its first phase. \n the expected sensitivity to the branching ratio of rare decays, especially the flavor changing processes, can be greatly enhanced to @xcite. in light of this, \n its exotic or rare processes should be investigated comprehensively to evaluate their potential in probing new physics. in this paper \n, we study the rare decay into light higgs boson(s ) in the framework of the minimal supersymmetric standard model ( mssm ), where a light cp - odd higgs - boson with a singlet - dominant component may naturally arise from the spontaneous breaking of some approximate global symmetry like the peccei - quuin symmetry ( pec24 ). * \n pacs numbers : * 12.38.lg, 13.85.hb, 14.40.gp + * keywords : * exotic decays ; flavor changing ; rare decay ; higgs + * pacs : * 11.15.ha, 12.39.hg, 11.30"
<add> EXPECTED_LEP = " the physics of @xmath0-boson will again play the central role in the frontier of particle physics if the gigaz option of the international linear collider ( ilc ) can be realized in its first phase. \n the expected sensitivity to the branching ratio of the rare decays, especially its exotic or rare processes, should be investigated comprehensively to evaluate their potential in probing new physics. in this work \n, we extend the previous studies of these decays to some new models and investigate the decays altogether. we are motivated by some recent studies on the singlet extension of the mssm, such as the next - to - minimal supersymmetric standard model ( nmssm ) @xcite and the nearly - minimal - supersymmetry - standard - model(nmssm)@xcite, where a light cp - odd higgs boson with singlet - dominant component may naturally arise from the spontaneous breaking of some approximate global symmetry. # 1#2#3#4#5#6#7#8#9#10#11#12 "
<ide>
<del> EXPECTED_MAGNET = " the recent experiment in the surface states of the topological insulator bi@xmath0se @xmath1, however, reported that a large positive magnetoresistance becomes very linear above a characteristic magnetic field. \n it is striking that this observation is in conflict with abrikosov s model and also with the classical parish - littlewood model. so far a reliable theoretical scheme capable of explaining this novel experiment has still been lacking. "
<add> EXPECTED_MAGNET = " the recent experiment in the surface states of the topological insulator bi@xmath0se @xmath1, however, reported that a large positive magnetoresistance becomes very linear in perpendicular magnetic field even in an opposite situation where the carrier sheet density is high that all electrons occupy more than one landau levels. \n it is striking that this observation is in conflict with abrikosov s model and also with the classical parish - littlewood model. "
<ide>
<ide> generated = tok.batch_decode(
<ide> hypotheses_batch.tolist(), clean_up_tokenization_spaces=True, skip_special_tokens=True | 1 |
Go | Go | check remote when local img platform doesn't match | ed033adb2cc287b513102e15fc47ddd60c51171d | <ide><path>builder/builder-next/adapters/containerimage/pull.go
<ide> import (
<ide> "fmt"
<ide> "io"
<ide> "io/ioutil"
<add> "path"
<ide> "runtime"
<ide> "sync"
<ide> "sync/atomic"
<ide> import (
<ide> "github.com/opencontainers/image-spec/identity"
<ide> ocispec "github.com/opencontainers/image-spec/specs-go/v1"
<ide> "github.com/pkg/errors"
<add> "github.com/sirupsen/logrus"
<ide> "golang.org/x/time/rate"
<ide> )
<ide>
<ide> func (is *imageSource) getCredentialsFromSession(ctx context.Context, sm *sessio
<ide> }
<ide> }
<ide>
<del>func (is *imageSource) resolveLocal(refStr string) ([]byte, error) {
<add>func (is *imageSource) resolveLocal(refStr string) (*image.Image, error) {
<ide> ref, err := distreference.ParseNormalizedNamed(refStr)
<ide> if err != nil {
<ide> return nil, err
<ide> func (is *imageSource) resolveLocal(refStr string) ([]byte, error) {
<ide> if err != nil {
<ide> return nil, err
<ide> }
<del> return img.RawJSON(), nil
<add> return img, nil
<ide> }
<ide>
<ide> func (is *imageSource) resolveRemote(ctx context.Context, ref string, platform *ocispec.Platform, sm *session.Manager) (digest.Digest, []byte, error) {
<ide> func (is *imageSource) ResolveImageConfig(ctx context.Context, ref string, opt l
<ide> // default == prefer local, but in the future could be smarter
<ide> fallthrough
<ide> case source.ResolveModePreferLocal:
<del> dt, err := is.resolveLocal(ref)
<add> img, err := is.resolveLocal(ref)
<ide> if err == nil {
<del> return "", dt, err
<add> if img.Architecture != opt.Platform.Architecture || img.Variant != opt.Platform.Variant || img.OS != opt.Platform.OS {
<add> logrus.WithField("ref", ref).Debugf("Requested build platform %s does not match local image platform %s, checking remote",
<add> path.Join(opt.Platform.OS, opt.Platform.Architecture, opt.Platform.Variant),
<add> path.Join(img.OS, img.Architecture, img.Variant),
<add> )
<add> } else {
<add> return "", img.RawJSON(), err
<add> }
<ide> }
<ide> // fallback to remote
<ide> return is.resolveRemote(ctx, ref, opt.Platform, sm)
<ide> func (p *puller) resolveLocal() {
<ide> }
<ide>
<ide> if p.src.ResolveMode == source.ResolveModeDefault || p.src.ResolveMode == source.ResolveModePreferLocal {
<del> dt, err := p.is.resolveLocal(p.src.Reference.String())
<add> ref := p.src.Reference.String()
<add> img, err := p.is.resolveLocal(ref)
<ide> if err == nil {
<del> p.config = dt
<add> if img.Architecture != p.platform.Architecture || img.Variant != p.platform.Variant || img.OS != p.platform.OS {
<add> logrus.WithField("ref", ref).Debugf("Requested build platform %s does not match local image platform %s, not resolving",
<add> path.Join(p.platform.OS, p.platform.Architecture, p.platform.Variant),
<add> path.Join(img.OS, img.Architecture, img.Variant),
<add> )
<add> } else {
<add> p.config = img.RawJSON()
<add> }
<ide> }
<ide> }
<ide> }) | 1 |
Javascript | Javascript | use special powers quit in unit tests | 70ce3a88a1a8fc436430d16006720aff7dc95a36 | <ide><path>test/unit/testreporter.js
<ide> var TestReporter = function(browser, appPath) {
<ide> 'use strict';
<ide>
<del> function send(action, json) {
<add> function send(action, json, cb) {
<ide> var r = new XMLHttpRequest();
<ide> // (The POST URI is ignored atm.)
<ide> r.open('POST', action, true);
<ide> var TestReporter = function(browser, appPath) {
<ide> if (r.readyState == 4) {
<ide> // Retry until successful
<ide> if (r.status !== 200) {
<del> send(action, json);
<add> send(action, json, cb);
<add> } else {
<add> if (cb) {
<add> cb();
<add> }
<ide> }
<ide> }
<ide> };
<ide> var TestReporter = function(browser, appPath) {
<ide> }
<ide>
<ide> function sendQuitRequest() {
<del> send('/tellMeToQuit?path=' + escape(appPath), {});
<add> send('/tellMeToQuit?path=' + escape(appPath), {}, function () {
<add> if (window.SpecialPowers) {
<add> SpecialPowers.quit();
<add> }
<add> });
<ide> }
<ide>
<ide> this.now = function() { | 1 |
Text | Text | harmonize version list style in yaml comments | 125523bffe9e5fbc14af185da6f682e08c05b1ba | <ide><path>doc/api/assert.md
<ide> changes:
<ide> - version: v8.0.0
<ide> pr-url: https://github.com/nodejs/node/pull/12142
<ide> description: The `Set` and `Map` content is also compared
<del> - version: v6.4.0, v4.7.1
<add> - version:
<add> - v6.4.0
<add> - v4.7.1
<ide> pr-url: https://github.com/nodejs/node/pull/8002
<ide> description: Typed array slices are handled correctly now.
<del> - version: v6.1.0, v4.5.0
<add> - version:
<add> - v6.1.0
<add> - v4.5.0
<ide> pr-url: https://github.com/nodejs/node/pull/6432
<ide> description: Objects with circular references can be used as inputs now.
<del> - version: v5.10.1, v4.4.3
<add> - version:
<add> - v5.10.1
<add> - v4.4.3
<ide> pr-url: https://github.com/nodejs/node/pull/5910
<ide> description: Handle non-`Uint8Array` typed arrays correctly.
<ide> -->
<ide> changes:
<ide> - version: v8.0.0
<ide> pr-url: https://github.com/nodejs/node/pull/12142
<ide> description: The `Set` and `Map` content is also compared
<del> - version: v6.4.0, v4.7.1
<add> - version:
<add> - v6.4.0
<add> - v4.7.1
<ide> pr-url: https://github.com/nodejs/node/pull/8002
<ide> description: Typed array slices are handled correctly now.
<ide> - version: v6.1.0
<ide> pr-url: https://github.com/nodejs/node/pull/6432
<ide> description: Objects with circular references can be used as inputs now.
<del> - version: v5.10.1, v4.4.3
<add> - version:
<add> - v5.10.1
<add> - v4.4.3
<ide> pr-url: https://github.com/nodejs/node/pull/5910
<ide> description: Handle non-`Uint8Array` typed arrays correctly.
<ide> -->
<ide> assert.doesNotReject(Promise.reject(new TypeError('Wrong value')))
<ide> <!-- YAML
<ide> added: v0.1.21
<ide> changes:
<del> - version: v5.11.0, v4.4.5
<add> - version:
<add> - v5.11.0
<add> - v4.4.5
<ide> pr-url: https://github.com/nodejs/node/pull/2407
<ide> description: The `message` parameter is respected now.
<ide> - version: v4.2.0
<ide> changes:
<ide> - version: v8.0.0
<ide> pr-url: https://github.com/nodejs/node/pull/12142
<ide> description: The `Set` and `Map` content is also compared
<del> - version: v6.4.0, v4.7.1
<add> - version:
<add> - v6.4.0
<add> - v4.7.1
<ide> pr-url: https://github.com/nodejs/node/pull/8002
<ide> description: Typed array slices are handled correctly now.
<del> - version: v6.1.0, v4.5.0
<add> - version:
<add> - v6.1.0
<add> - v4.5.0
<ide> pr-url: https://github.com/nodejs/node/pull/6432
<ide> description: Objects with circular references can be used as inputs now.
<del> - version: v5.10.1, v4.4.3
<add> - version:
<add> - v5.10.1
<add> - v4.4.3
<ide> pr-url: https://github.com/nodejs/node/pull/5910
<ide> description: Handle non-`Uint8Array` typed arrays correctly.
<ide> -->
<ide> changes:
<ide> - version: v8.0.0
<ide> pr-url: https://github.com/nodejs/node/pull/12142
<ide> description: The `Set` and `Map` content is also compared
<del> - version: v6.4.0, v4.7.1
<add> - version:
<add> - v6.4.0
<add> - v4.7.1
<ide> pr-url: https://github.com/nodejs/node/pull/8002
<ide> description: Typed array slices are handled correctly now.
<ide> - version: v6.1.0
<ide> pr-url: https://github.com/nodejs/node/pull/6432
<ide> description: Objects with circular references can be used as inputs now.
<del> - version: v5.10.1, v4.4.3
<add> - version:
<add> - v5.10.1
<add> - v4.4.3
<ide> pr-url: https://github.com/nodejs/node/pull/5910
<ide> description: Handle non-`Uint8Array` typed arrays correctly.
<ide> -->
<ide><path>doc/api/buffer.md
<ide> changes:
<ide> - version: v8.0.0
<ide> pr-url: https://github.com/nodejs/node/pull/10236
<ide> description: The `value` can now be a `Uint8Array`.
<del> - version: v5.7.0, v4.4.0
<add> - version:
<add> - v5.7.0
<add> - v4.4.0
<ide> pr-url: https://github.com/nodejs/node/pull/4803
<ide> description: When `encoding` is being passed, the `byteOffset` parameter
<ide> is no longer required.
<ide> console.log(buf.subarray(-5, -2).toString());
<ide> <!-- YAML
<ide> added: v0.3.0
<ide> changes:
<del> - version: v7.1.0, v6.9.2
<add> - version:
<add> - v7.1.0
<add> - v6.9.2
<ide> pr-url: https://github.com/nodejs/node/pull/9341
<ide> description: Coercing the offsets to integers now handles values outside
<ide> the 32-bit integer range properly.
<ide><path>doc/api/child_process.md
<ide> changes:
<ide> - version: v8.0.0
<ide> pr-url: https://github.com/nodejs/node/pull/10653
<ide> description: The `input` option can now be a `Uint8Array`.
<del> - version: v6.2.1, v4.5.0
<add> - version:
<add> - v6.2.1
<add> - v4.5.0
<ide> pr-url: https://github.com/nodejs/node/pull/6939
<ide> description: The `encoding` option can now explicitly be set to `buffer`.
<ide> -->
<ide> changes:
<ide> - version: v8.0.0
<ide> pr-url: https://github.com/nodejs/node/pull/10653
<ide> description: The `input` option can now be a `Uint8Array`.
<del> - version: v6.2.1, v4.5.0
<add> - version:
<add> - v6.2.1
<add> - v4.5.0
<ide> pr-url: https://github.com/nodejs/node/pull/6939
<ide> description: The `encoding` option can now explicitly be set to `buffer`.
<ide> - version: v5.7.0
<ide><path>doc/api/events.md
<ide> myEmitter.emit('event');
<ide> <!-- YAML
<ide> added: v0.9.3
<ide> changes:
<del> - version: v6.1.0, v4.7.0
<add> - version:
<add> - v6.1.0
<add> - v4.7.0
<ide> pr-url: https://github.com/nodejs/node/pull/6394
<ide> description: For listeners attached using `.once()`, the `listener` argument
<ide> now yields the original listener function.
<ide><path>doc/api/http.md
<ide> changes:
<ide> pr-url: https://github.com/nodejs/node/pull/25974
<ide> description: Return `this` from `writeHead()` to allow chaining with
<ide> `end()`.
<del> - version: v5.11.0, v4.4.5
<add> - version:
<add> - v5.11.0
<add> - v4.4.5
<ide> pr-url: https://github.com/nodejs/node/pull/6291
<ide> description: A `RangeError` is thrown if `statusCode` is not a number in
<ide> the range `[100, 999]`.
<ide> changes:
<ide> - version: v13.3.0
<ide> pr-url: https://github.com/nodejs/node/pull/30570
<ide> description: The `maxHeaderSize` option is supported now.
<del> - version: v9.6.0, v8.12.0
<add> - version:
<add> - v9.6.0
<add> - v8.12.0
<ide> pr-url: https://github.com/nodejs/node/pull/15752
<ide> description: The `options` argument is supported now.
<ide> -->
<ide><path>doc/api/modules.md
<ide> loading.
<ide> <!-- YAML
<ide> added: v0.1.16
<ide> deprecated:
<del> - v12.19.0
<ide> - v14.6.0
<add> - v12.19.0
<ide> -->
<ide>
<ide> > Stability: 0 - Deprecated: Please use [`require.main`][] and
<ide><path>doc/api/n-api.md
<ide> a specific `napi_env`.
<ide> ### napi_get_uv_event_loop
<ide> <!-- YAML
<ide> added:
<del> - v8.10.0
<ide> - v9.3.0
<add> - v8.10.0
<ide> napiVersion: 2
<ide> -->
<ide>
<ide><path>doc/api/packages.md
<ide> The following fields in `package.json` files are used in Node.js:
<ide> ### `"name"`
<ide> <!-- YAML
<ide> added:
<del> - v12.16.0
<ide> - v13.1.0
<add> - v12.16.0
<ide> changes:
<ide> - version:
<del> - v12.16.0
<ide> - v13.6.0
<add> - v12.16.0
<ide> pr-url: https://github.com/nodejs/node/pull/31002
<ide> description: Remove the `--experimental-resolve-self` option.
<ide> -->
<ide> The `"name"` field can be used in addition to the [`"exports"`][] field to
<ide> added: v12.0.0
<ide> changes:
<ide> - version:
<del> - v12.17.0
<ide> - v13.2.0
<add> - v12.17.0
<ide> pr-url: https://github.com/nodejs/node/pull/29866
<ide> description: Unflag `--experimental-modules`.
<ide> -->
<ide> as ES modules and `.cjs` files are always treated as CommonJS.
<ide> added: v12.7.0
<ide> changes:
<ide> - version:
<del> - v12.16.0
<ide> - v13.2.0
<add> - v12.16.0
<ide> pr-url: https://github.com/nodejs/node/pull/29978
<ide> description: Implement conditional exports.
<ide> - version:
<del> - v12.16.0
<ide> - v13.7.0
<add> - v12.16.0
<ide> pr-url: https://github.com/nodejs/node/pull/31001
<ide> description: Remove the `--experimental-conditional-exports` option.
<ide> - version:
<del> - v12.16.0
<ide> - v13.7.0
<add> - v12.16.0
<ide> pr-url: https://github.com/nodejs/node/pull/31008
<ide> description: Implement logical conditional exports ordering.
<ide> - version:
<ide><path>doc/api/process.md
<ide> flag's behavior.
<ide> <!-- YAML
<ide> added: v0.1.19
<ide> changes:
<del> - version: v14.0.0
<ide> - version:
<del> - v12.19.0
<ide> - v14.0.0
<add> - v12.19.0
<ide> pr-url: https://github.com/nodejs/node/pull/32499
<ide> description: Calling `process.umask()` with no arguments is deprecated.
<ide>
<ide><path>doc/api/querystring.md
<ide> changes:
<ide> - version: v6.0.0
<ide> pr-url: https://github.com/nodejs/node/pull/6055
<ide> description: The returned object no longer inherits from `Object.prototype`.
<del> - version: v6.0.0, v4.2.4
<add> - version:
<add> - v6.0.0
<add> - v4.2.4
<ide> pr-url: https://github.com/nodejs/node/pull/3807
<ide> description: The `eq` parameter may now have a length of more than `1`.
<ide> -->
<ide><path>doc/api/readline.md
<ide> changes:
<ide> - version: v13.9.0
<ide> pr-url: https://github.com/nodejs/node/pull/31318
<ide> description: The `tabSize` option is supported now.
<del> - version: v8.3.0, 6.11.4
<add> - version:
<add> - v8.3.0
<add> - v6.11.4
<ide> pr-url: https://github.com/nodejs/node/pull/13497
<ide> description: Remove max limit of `crlfDelay` option.
<ide> - version: v6.6.0
<ide><path>doc/api/tls.md
<ide> changes:
<ide> pr-url: https://github.com/nodejs/node/pull/11984
<ide> description: The `ALPNProtocols` option can be a `TypedArray` or
<ide> `DataView` now.
<del> - version: v5.3.0, v4.7.0
<add> - version:
<add> - v5.3.0
<add> - v4.7.0
<ide> pr-url: https://github.com/nodejs/node/pull/4246
<ide> description: The `secureContext` option is supported now.
<ide> - version: v5.0.0
<ide><path>doc/api/url.md
<ide> changes:
<ide> pr-url: https://github.com/nodejs/node/pull/8215
<ide> description: The `auth` fields are now kept intact when `from` and `to`
<ide> refer to the same host.
<del> - version: v6.5.0, v4.6.2
<add> - version:
<add> - v6.5.0
<add> - v4.6.2
<ide> pr-url: https://github.com/nodejs/node/pull/8214
<ide> description: The `port` field is copied correctly now.
<ide> - version: v6.0.0 | 13 |
PHP | PHP | add strict types to cookiecrypttrait | 482c9c2a177bf88cc39240f054d9ed7d1b6ca5b9 | <ide><path>src/Utility/CookieCryptTrait.php
<ide> trait CookieCryptTrait
<ide> *
<ide> * @return string
<ide> */
<del> abstract protected function _getCookieEncryptionKey();
<add> abstract protected function _getCookieEncryptionKey(): string;
<ide>
<ide> /**
<ide> * Encrypts $value using public $type method in Security class
<ide> abstract protected function _getCookieEncryptionKey();
<ide> * @param string|null $key Used as the security salt if specified.
<ide> * @return string Encoded values
<ide> */
<del> protected function _encrypt($value, $encrypt, $key = null)
<add> protected function _encrypt(string $value, $encrypt, ?string $key = null): string
<ide> {
<ide> if (is_array($value)) {
<ide> $value = $this->_implode($value);
<ide> protected function _encrypt($value, $encrypt, $key = null)
<ide> * @return void
<ide> * @throws \RuntimeException When an invalid cipher is provided.
<ide> */
<del> protected function _checkCipher($encrypt)
<add> protected function _checkCipher(string $encrypt): void
<ide> {
<ide> if (!in_array($encrypt, $this->_validCiphers)) {
<ide> $msg = sprintf(
<ide> protected function _checkCipher($encrypt)
<ide> /**
<ide> * Decrypts $value using public $type method in Security class
<ide> *
<del> * @param array $values Values to decrypt
<add> * @param array|string $values Values to decrypt
<ide> * @param string|bool $mode Encryption mode
<ide> * @param string|null $key Used as the security salt if specified.
<ide> * @return string|array Decrypted values
<ide> */
<del> protected function _decrypt($values, $mode, $key = null)
<add> protected function _decrypt($values, $mode, ?string $key = null)
<ide> {
<ide> if (is_string($values)) {
<ide> return $this->_decode($values, $mode, $key);
<ide> protected function _decrypt($values, $mode, $key = null)
<ide> * @param string|null $key Used as the security salt if specified.
<ide> * @return string|array Decoded values.
<ide> */
<del> protected function _decode($value, $encrypt, $key)
<add> protected function _decode(string $value, $encrypt, ?string $key)
<ide> {
<ide> if (!$encrypt) {
<ide> return $this->_explode($value); | 1 |
PHP | PHP | apply fixes from styleci | 87fe04daf668c4c1de9269a003760e677b575fcb | <ide><path>tests/Support/SupportPluralizerTest.php
<ide> public function testPluralNotAppliedForStringEndingWithNonAlphanumericCharacter(
<ide> $this->assertSame('Alien ', Str::plural('Alien '));
<ide> $this->assertSame('50%', Str::plural('50%'));
<ide> }
<del>
<add>
<ide> public function testPluralAppliedForStringEndingWithNumericCharacter()
<ide> {
<ide> $this->assertSame('User1s', Str::plural('User1')); | 1 |
Text | Text | add guides for common cases | 10f529d091b6fd7db7e054191bac55dc19f24038 | <ide><path>docs/Adding-Software-to-Homebrew.md
<add># Adding Software to Homebrew
<add>
<add>Are you missing your favorite software in Homebrew? Then you're the perfect person to resolve this problem.
<add>
<add>Before you start, please check the open pull requests for [homebrew-core](https://github.com/Homebrew/homebrew-core/pulls) or [linuxbrew-core](https://github.com/Homebrew/linuxbrew-core/pulls), to make sure no one else beat you to the punch.
<add>
<add>Next, you will want to go through the [Acceptable Formulae](Acceptable-Formulae.md) documentation to determine if the software is an appropriate addition to Homebrew. If you are creating a formula for an alternative version of software already in Homebrew (for example, a major/minor version that significantly differs from the existing version), be sure to read the [Versions](Versions.md) documentation to understand versioned formulae requirements.
<add>
<add>If everything checks out, you're ready to get started on a new formula!
<add>
<add>## Writing the formula
<add>1. It's a good idea to find existing formulae in Homebrew that have similarities to the software you want to add. This will help you to understand how specific languages, build methods, etc. are typically handled.
<add>
<add>1. If you're starting from scratch, the [`brew create` command](Manpage.md#create-options-url) can be used to produce a basic version of your formula. This command accepts a number of options and you may be able to save yourself some work by using an appropriate template option like `--python`.
<add>
<add>1. You will now have to work to develop the boilerplate code from `brew create` into a fully-fledged formula. Your main references will be the [Formula Cookbook](Formula-Cookbook.md), similar formulae in Homebrew, and the upstream documentation for your chosen software. Be sure to also take note of the Homebrew documentation for writing [`Python`](Python-for-Formula-Authors.md) and [`Node`](Node-for-Formula-Authors.md) formulae, if applicable.
<add>
<add>1. Make sure you write a good test as part of your formula. Refer to the "[Add a test to the formula](Formula-Cookbook.md#add-a-test-to-the-formula)" section of the Cookbook for help with this.
<add>
<add>1. Try to install the formula using `brew install --build-from-source <formula>`, where \<formula\> is the name of your formula. If any errors occur, correct your formula and attempt to install it again. The formula should install without errors by the end of this step.
<add>
<add>If you're stuck, ask for help on GitHub or [Discourse](https://discourse.brew.sh). The maintainers are very happy to help but we also like to see that you've put effort into trying to find a solution first.
<add>
<add>## Testing and auditing the formula
<add>
<add>1. Run `brew audit --strict --new-formula --online <formula>` with your formula. If any errors occur, correct them in your formula and run the audit again. The audit should finish without any errors by the end of this step.
<add>
<add>1. Run your formula's test using `brew test <formula>` with your formula. Your test should finish without any errors.
<add>
<add>## Submitting the formula
<add>
<add>You're finally ready to submit your formula to the [homebrew-core](https://github.com/Homebrew/homebrew-core/) or [linuxbrew-core](https://github.com/Homebrew/linuxbrew-core/) repository. If you haven't done this before, you can refer to the [How to Open a Pull Request documentation](How-To-Open-a-Homebrew-Pull-Request.md) for help. Maintainers will review the pull request and provide feedback about any areas that need to be addressed before the formula can be added to Homebrew.
<add>
<add>If you've made it this far, congratulations on submitting a Homebrew formula! We appreciate the hard work you put into this and you can take satisfaction in knowing that your work may benefit other Homebrew users as well.
<ide><path>docs/Creating-a-Homebrew-Issue.md
<add># Creating a Homebrew Issue
<add>
<add>First, check to make sure your issue is not listed in the [FAQ](FAQ.md) or [Common Issues](Common-Issues.md) and can't otherwise be resolved with the information in the [Tips and Tricks](Tips-N'-Tricks.md) documentation. Next, go through the steps in the [Troubleshooting guide](Troubleshooting.md).
<add>
<add>If the preceding steps did not help, it may be appropriate to submit an issue. This can be done by navigating to the relevant repository, clicking the "Issues" link, and clicking on the "New issue" button. When creating an issue, make sure you use the provided template, as it's important in helping others to understand and potentially triage your issue efficiently.
<ide><path>docs/README.md
<ide> - [Xcode](Xcode.md)
<ide> - [Kickstarter Supporters](Kickstarter-Supporters.md)
<ide>
<add>- [Creating a Homebrew Issue](Creating-a-Homebrew-Issue.md)
<add>- [Updating Software in Homebrew](Updating-Software-in-Homebrew.md)
<add>- [Adding Software to Homebrew](Adding-Software-to-Homebrew.md)
<add>
<ide> ## Contributors
<ide>
<ide> - [How To Open A Pull Request (and get it merged)](How-To-Open-a-Homebrew-Pull-Request.md)
<ide><path>docs/Updating-Software-in-Homebrew.md
<add># Updating Software in Homebrew
<add>
<add>Did you find something in Homebrew that wasn't the latest version? You can help yourself and others by submitting a pull request to update the formula.
<add>
<add>First, check the pull requests in the [homebrew-core](https://github.com/Homebrew/homebrew-core/pulls) or [linuxbrew-core](https://github.com/Homebrew/linuxbrew-core/pulls) repositories to make sure there isn't already an open PR. You may also want to look through closed pull requests for the formula, as sometimes formulae run into problems preventing them from being updated and it's better to be aware of any issues before putting significant effort into an update.
<add>
<add>The guide on [opening a pull request](How-To-Open-a-Homebrew-Pull-Request.md#submit-a-new-version-of-an-existing-formula) should really be all you need, this will explain how to easily change the url to point to the latest version and that's really all you need. If you want to read up on `bump-formula-pr` before using it you could check [the manpage](Manpage.md#bump-formula-pr-options-formula).
<add>
<add>You can look back at previous pull requests that updated the formula to see how others have handled things in the past but be sure to look at a variety of PRs. Sometimes formulae are not updated properly (for example, running `bump-formula-pr` on a Python formula that needs dependency updates), so you may need to use your judgment to determine how to proceed.
<add>
<add>Once you've created the pull request in the appropriate Homebrew repository your commit(s) will be tested on our continuous integration servers, showing a green check mark when everything passed or a red X when there were failures. Maintainers will review your pull request and provide feedback about any changes that need to be made before it can be merged.
<add>
<add>We appreciate your help in keeping Homebrew's formulae up to date as new versions of software are released! | 4 |
Java | Java | expose method to determine form content type | ddb38eefeea1506bbf5bdefda4fd0c354381d79f | <ide><path>spring-web/src/main/java/org/springframework/http/converter/FormHttpMessageConverter.java
<ide> private boolean isMultipart(MultiValueMap<String, ?> map, @Nullable MediaType co
<ide> private void writeForm(MultiValueMap<String, Object> formData, @Nullable MediaType contentType,
<ide> HttpOutputMessage outputMessage) throws IOException {
<ide>
<del> contentType = getMediaType(contentType);
<add> contentType = getFormContentType(contentType);
<ide> outputMessage.getHeaders().setContentType(contentType);
<ide>
<ide> Charset charset = contentType.getCharset();
<ide> private void writeForm(MultiValueMap<String, Object> formData, @Nullable MediaTy
<ide> }
<ide> }
<ide>
<del> private MediaType getMediaType(@Nullable MediaType mediaType) {
<del> if (mediaType == null) {
<add> /**
<add> * Return the content type used to write forms, given the preferred content type.
<add> * By default, this method returns the given content type, but adds the
<add> * {@linkplain #setCharset(Charset) charset} if it does not have one.
<add> * If {@code contentType} is {@code null},
<add> * {@code application/x-www-form-urlencoded; charset=UTF-8} is returned.
<add> *
<add> * <p>Subclasses can override this method to change this behavior.
<add> * @param contentType the preferred content type, can be {@code null}
<add> * @return the content type to be used
<add> * @since 5.2.2
<add> */
<add> protected MediaType getFormContentType(@Nullable MediaType contentType) {
<add> if (contentType == null) {
<ide> return DEFAULT_FORM_DATA_MEDIA_TYPE;
<ide> }
<del> else if (mediaType.getCharset() == null) {
<del> return new MediaType(mediaType, this.charset);
<add> else if (contentType.getCharset() == null) {
<add> return new MediaType(contentType, this.charset);
<ide> }
<ide> else {
<del> return mediaType;
<add> return contentType;
<ide> }
<ide> }
<ide> | 1 |
Text | Text | add ember 1.13.0 to changelog | 4a2f37a500b2e8047e5af80f57419105f65dea0c | <ide><path>CHANGELOG.md
<ide> # Ember Changelog
<ide>
<add>### 1.13.0 (June 12, 2015)
<add>
<add>- [#11270](https://github.com/emberjs/ember.js/pull/11270) [BUGFIX] Ensure view registry is propagated to components.
<add>- [#11273](https://github.com/emberjs/ember.js/pull/11273) [BUGFIX] Downgrade Ember.Service without proper inheritance to a deprecation (instead of an assertion).
<add>- [#11274](https://github.com/emberjs/ember.js/pull/11274) [BUGFIX] Unify template compiler deprecations so that they can report the proper location of the deprecation.
<add>- [#11279](https://github.com/emberjs/ember.js/pull/11279) [DEPRECATION] Deprecate `{{#each foo in bar}}{{/each}}`.
<add>- [#11229](https://github.com/emberjs/ember.js/pull/11229) [BUGFIX] Prevent views from having access to component lifecycle hooks.
<add>- [#11286](https://github.com/emberjs/ember.js/pull/11286) [DEPRECATION] Deprecate `Ember.EnumerableUtils`.
<add>- [#11338](https://github.com/emberjs/ember.js/pull/11338) [BUGFIX] Ensure `parentView` is available properly.
<add>- [#11313](https://github.com/emberjs/ember.js/pull/11313) [DEPRECATION] Allow deprecated access to `template` in component to determine if a block was provided.
<add>- [#11339](https://github.com/emberjs/ember.js/pull/11339) Add special values (`@index` or `@guid`) to `{{each}}`'s keyPath.
<add>- [#11360](https://github.com/emberjs/ember.js/pull/11360) Add warning message when using `{{each}}` without specifying `key`.
<add>- [#11348](https://github.com/emberjs/ember.js/pull/11348) [BUGFIX] Provide useful errors when a closure action is not found.
<add>- [#11264](https://github.com/emberjs/ember.js/pull/11264) Add `{{concat}}` helper.
<add>- [#11362](https://github.com/emberjs/ember.js/pull/11362) / [#11365](https://github.com/emberjs/ember.js/pull/11365) [DOC] Ensure all documentation comments include `@public` or `@private`.
<add>- [#11278](https://github.com/emberjs/ember.js/pull/11278) Implement Ember.Helper. Read [emberjs/rfcs#53](https://github.com/emberjs/rfcs/pull/53) for more details.
<add>- [#11373](https://github.com/emberjs/ember.js/pull/11373) [BUGFIX] Fix issue with multiple actions in a single element.
<add>- [#11387](https://github.com/emberjs/ember.js/pull/11387) [DEPRECATION] Deprecate `Ember.View`.
<add>- [#11389](https://github.com/emberjs/ember.js/pull/11389) [DEPRECATION] Deprecate `{{view}}` helper.
<add>- [#11394](https://github.com/emberjs/ember.js/pull/11394) [DEPRECATION] Add `Ember.LinkComponent` and deprecate `Ember.LinkView`.
<add>- [#11400](https://github.com/emberjs/ember.js/pull/11400) [DEPRECATION] Deprecate `Ember.computed.any`.
<add>- [#11330](https://github.com/emberjs/ember.js/pull/11330) [BUGFIX] Ensure that `{{each}}` can properly transition into and out of its inverse state.
<add>- [#11416](https://github.com/emberjs/ember.js/pull/11416) [DEPRECATION] Deprecate `Ember.Select`.
<add>- [#11403](https://github.com/emberjs/ember.js/pull/11403) [DEPRECATION] Deprecate `Ember.arrayComputed`, `Ember.ReduceComputedProperty`, `Ember.ArrayComputedProperty`, and `Ember.reduceComputed`.
<add>- [#11401](https://github.com/emberjs/ember.js/pull/11401) [DEPRECATION] Deprecate `{{view` and `{{controller` template local keywords.
<add>- [#11329](https://github.com/emberjs/ember.js/pull/11329) [BUGFIX] Fix issue with `{{component}}` helper not properly cleaning up components after they have been replaced.
<add>- [#11393](https://github.com/emberjs/ember.js/pull/11393) Implement support for automatic registration of all helpers (with or without a dash). Requires [email protected] or higher if using ember-cli. Read [emberjs/rfcs#58](https://github.com/emberjs/rfcs/pull/58) for more details.
<add>- [#11425](https://github.com/emberjs/ember.js/pull/11425) [BUGFIX] Prevent `willDestroyElement` from being called multiple times on the same component.
<add>- [#11138](https://github.com/emberjs/ember.js/pull/11138) Add a better deprecation for `{{bind-attr}}`.
<add>- [#11201](https://github.com/emberjs/ember.js/pull/11201) [BUGFIX] Fix `currentURL` test helper.
<add>- [#11161](https://github.com/emberjs/ember.js/pull/11161) [BUGFIX] Fix initial selection for select with optgroup.
<add>- [#10980](https://github.com/emberjs/ember.js/pull/10980) [BUGFIX] Fix `Ember.String.dasherize`, `Ember.String.underscore`, `Ember.String.capitalize`, `Ember.String.classify` for multi-word input values.
<add>- [#11187](https://github.com/emberjs/ember.js/pull/11187) [BUGFIX] Handle mut cell action names.
<add>- [#11194](https://github.com/emberjs/ember.js/pull/11194) [BUGFIX] Ensure `classNameBindings` properly handles multiple entries.
<add>- [#11203](https://github.com/emberjs/ember.js/pull/11203) [BUGFIX] Ensure components for void tagNames do not have childNodes.
<add>- [#11205](https://github.com/emberjs/ember.js/pull/11205) [BUGFIX] Ensure `Ember.get` works on empty string paths.
<add>- [#11220](https://github.com/emberjs/ember.js/pull/11220) [BUGFIX] Fix issue with `Ember.computed.sort` where array observers were not properly detached.
<add>- [#11222](https://github.com/emberjs/ember.js/pull/11222) [BUGFIX] Only attempt to lookup components with a dash.
<add>- [#11227](https://github.com/emberjs/ember.js/pull/11227) [BUGFIX] Ensure `role` is properly applied to views if `ariaRole` attribute is present.
<add>- [#11228](https://github.com/emberjs/ember.js/pull/11228) [BUGFIX] Fix `{{each}}` with `itemViewClass` specified `tagName`.
<add>- [#11231](https://github.com/emberjs/ember.js/pull/11231) [BUGFIX] Fix `{{each}}` with `itemViewClass` and `{{else}}`.
<add>- [#11234](https://github.com/emberjs/ember.js/pull/11234) [BUGFIX] Fix `{{each item in model itemViewClass="..."}}`.
<add>- [#11235](https://github.com/emberjs/ember.js/pull/11235) [BUGFIX] Properly handle `isVisible` as a computed property.
<add>- [#11242](https://github.com/emberjs/ember.js/pull/11242) [BUGFIX] Use the proper value for `options.data.view` with Handlebars compat helpers.
<add>- [#11252](https://github.com/emberjs/ember.js/pull/11253) [BUGFIX] Ensure `instanceInitializers` are called with the proper arguments when calling `App.reset`.
<add>- [#11257](https://github.com/emberjs/ember.js/pull/11257) [BUGFIX] Fix (and deprecate) `{{input on="..." action="..."}}`.
<add>- [#11260](https://github.com/emberjs/ember.js/pull/11260) [BUGFIX] Ensure that passing an array argument to `(action` helper is handled properly.
<add>- [#11261](https://github.com/emberjs/ember.js/pull/11261) Add helpful assertion when exporting the wrong type of factory (for Routes, Components, Services, and Views).
<add>- [#11266](https://github.com/emberjs/ember.js/pull/11266) [BUGFIX] Ensure `parentView` includes yielding component.
<add>- [#11267](https://github.com/emberjs/ember.js/pull/11267) Disable angle bracket components. See [#11267](https://github.com/emberjs/ember.js/pull/11267) and [emberjs/rfcs#60](https://github.com/emberjs/rfcs/pull/60) for more details.
<add>- [#3852](https://github.com/emberjs/ember.js/pull/3852) [BREAKING BUGFIX] Do not assume null Ember.get targets always refer to a global
<add>- [#10501](https://github.com/emberjs/ember.js/pull/10501) Implement Glimmer Engine.
<add>- [#11029](https://github.com/emberjs/ember.js/pull/11029) Allow bound outlet names.
<add>- [#11035](https://github.com/emberjs/ember.js/pull/11035) {{#with}} helper should not render if passed variable is falsey.
<add>- [#11104](https://github.com/emberjs/ember.js/pull/11104) / [#10501](https://github.com/emberjs/ember.js/pull/10501) Remove support for non-HTMLBars templates.
<add>- [#11116](https://github.com/emberjs/ember.js/pull/11116) / [emberjs/rfcs#50](https://github.com/emberjs/rfcs/pull/50) [FEATURE ember-routing-htmlbars-improved-actions].
<add>- [#11028](https://github.com/emberjs/ember.js/pull/11028) Add positional parameter support to components.
<add>- [#11084](https://github.com/emberjs/ember.js/pull/11084) Enable {{yield to="inverse"}} in components.
<add>- [#11141](https://github.com/emberjs/ember.js/pull/11141) Implement angle-bracket components.
<add>
<ide> ### 1.12.0 (May 13, 2015)
<ide>
<ide> - [#10874](https://github.com/emberjs/ember.js/pull/10874) Include all files in jspm package. | 1 |
PHP | PHP | update the phpdoc of the id method to accept uuid | 3627f33df082c988f84dd421ff97daf1c800eadf | <ide><path>src/Illuminate/Contracts/Auth/Guard.php
<ide> public function user();
<ide> /**
<ide> * Get the ID for the currently authenticated user.
<ide> *
<del> * @return int|null
<add> * @return int|string|null
<ide> */
<ide> public function id();
<ide> | 1 |
Javascript | Javascript | fix tests for testswarm | 493548c099b1b0c5413fd7db94346dbe61c028c7 | <ide><path>test/jquery.js
<ide> /* jshint eqeqeq: false */
<ide>
<ide> var i, len,
<del> // Parent is the current window if not an iframe, which is fine
<ide> src = window.location.pathname.split( "test" )[ 0 ],
<ide> QUnit = window.QUnit || parent.QUnit,
<del> require = require || parent.require;
<add> require = window.require || parent.require;
<ide>
<ide> // Config parameter to force basic code paths
<ide> QUnit.config.urlConfig.push({ | 1 |
Python | Python | add gcd implementation (#371) | a31d20acf51be53de690d2b4a22c45f861522eb1 | <ide><path>Maths/gcd.py
<add>def gcd(a, b):
<add> if a == 0 :
<add> return b
<add>
<add> return gcd(b%a, a)
<add>
<add>def main():
<add> print(gcd(3, 6))
<add>
<add>
<add>if __name__ == '__main__':
<add> main() | 1 |
Javascript | Javascript | reduce memory usage | dffedccc75daaf583ed0f2ae41cb3a883fc82743 | <ide><path>lib/Parser.js
<ide> class Parser extends Tapable {
<ide> if(expr.argument.type === "Identifier") {
<ide> name = this.scope.renames.get(expr.argument.name) || expr.argument.name;
<ide> if(!this.scope.definitions.has(name)) {
<del> res = this.hooks.evaluateTypeof.for(name).call(expr);
<del> if(res !== undefined) return res;
<add> const hook = this.hooks.evaluateTypeof.get(name);
<add> if(hook !== undefined) {
<add> res = hook.call(expr);
<add> if(res !== undefined) return res;
<add> }
<ide> }
<ide> }
<ide> if(expr.argument.type === "MemberExpression") {
<ide> const exprName = this.getNameForExpression(expr.argument);
<ide> if(exprName && exprName.free) {
<del> res = this.hooks.evaluateTypeof.for(exprName.name).call(expr);
<del> if(res !== undefined) return res;
<add> const hook = this.hooks.evaluateTypeof.get(exprName.name);
<add> if(hook !== undefined) {
<add> res = hook.call(expr);
<add> if(res !== undefined) return res;
<add> }
<ide> }
<ide> }
<ide> if(expr.argument.type === "FunctionExpression") {
<ide> class Parser extends Tapable {
<ide> this.plugin("evaluate Identifier", expr => {
<ide> const name = this.scope.renames.get(expr.name) || expr.name;
<ide> if(!this.scope.definitions.has(expr.name)) {
<del> const result = this.hooks.evaluateIdentifier.for(name).call(expr);
<del> if(result) return result;
<add> const hook = this.hooks.evaluateIdentifier.get(name);
<add> if(hook !== undefined) {
<add> const result = hook.call(expr);
<add> if(result) return result;
<add> }
<ide> return new BasicEvaluatedExpression().setIdentifier(name).setRange(expr.range);
<ide> } else {
<del> return this.hooks.evaluateDefinedIdentifier.for(name).call(expr);
<add> const hook = this.hooks.evaluateDefinedIdentifier.get(name);
<add> if(hook !== undefined) {
<add> return hook.call(expr);
<add> }
<ide> }
<ide> });
<ide> this.plugin("evaluate ThisExpression", expr => {
<ide> const name = this.scope.renames.get("this");
<ide> if(name) {
<del> const result = this.hooks.evaluateIdentifier.for(name).call(expr);
<del> if(result) return result;
<add> const hook = this.hooks.evaluateIdentifier.get(name);
<add> if(hook !== undefined) {
<add> const result = hook.call(expr);
<add> if(result) return result;
<add> }
<ide> return new BasicEvaluatedExpression().setIdentifier(name).setRange(expr.range);
<ide> }
<ide> });
<ide> this.plugin("evaluate MemberExpression", expression => {
<ide> let exprName = this.getNameForExpression(expression);
<ide> if(exprName) {
<ide> if(exprName.free) {
<del> const result = this.hooks.evaluateIdentifier.for(exprName.name).call(expression);
<del> if(result) return result;
<add> const hook = this.hooks.evaluateIdentifier.get(exprName.name);
<add> if(hook !== undefined) {
<add> const result = hook.call(expression);
<add> if(result) return result;
<add> }
<ide> return new BasicEvaluatedExpression().setIdentifier(exprName.name).setRange(expression.range);
<ide> } else {
<del> return this.hooks.evaluateDefinedIdentifier.for(exprName.name).call(expression);
<add> const hook = this.hooks.evaluateDefinedIdentifier.get(exprName.name);
<add> if(hook !== undefined) {
<add> return hook.call(expression);
<add> }
<ide> }
<ide> }
<ide> });
<ide> class Parser extends Tapable {
<ide> const param = this.evaluateExpression(expr.callee.object);
<ide> if(!param) return;
<ide> const property = expr.callee.property.name || expr.callee.property.value;
<del> return this.hooks.evaluateCallExpressionMember.for(property).call(expr, param);
<add> const hook = this.hooks.evaluateCallExpressionMember.get(property);
<add> if(hook !== undefined) {
<add> return hook.call(expr, param);
<add> }
<ide> });
<ide> this.plugin("evaluate CallExpression .replace", (expr, param) => {
<ide> if(!param.isString()) return;
<ide> class Parser extends Tapable {
<ide> }
<ide>
<ide> walkLabeledStatement(statement) {
<del> const result = this.hooks.label.for(statement.label.name).call(statement);
<del> if(result !== true)
<del> this.walkStatement(statement.body);
<add> const hook = this.hooks.label.get(statement.label.name);
<add> if(hook !== undefined) {
<add> const result = hook.call(statement);
<add> if(result === true)
<add> return;
<add> }
<add> this.walkStatement(statement.body);
<ide> }
<ide>
<ide> prewalkWithStatement(statement) {
<ide> class Parser extends Tapable {
<ide> const hookMap = declarator.kind === "const" ? this.hooks.varDeclarationConst :
<ide> declarator.kind === "let" ? this.hooks.varDeclarationLet :
<ide> this.hooks.varDeclarationVar;
<del> if(!hookMap.for(name).call(decl)) {
<del> if(!this.hooks.varDeclaration.for(name).call(decl)) {
<add> const hook = hookMap.get(name);
<add> if(hook === undefined || !hook.call(decl)) {
<add> const hook = this.hooks.varDeclaration.get(name);
<add> if(hook === undefined || !hook.call(decl)) {
<ide> this.scope.renames.set(name, null);
<ide> this.scope.definitions.add(name);
<ide> }
<ide> class Parser extends Tapable {
<ide> case "VariableDeclarator":
<ide> {
<ide> const renameIdentifier = declarator.init && this.getRenameIdentifier(declarator.init);
<del> if(renameIdentifier && declarator.id.type === "Identifier" && this.hooks.canRename.for(renameIdentifier).call(declarator.init)) {
<del> // renaming with "var a = b;"
<del> if(!this.hooks.rename.for(renameIdentifier).call(declarator.init)) {
<del> this.scope.renames.set(declarator.id.name, this.scope.renames.get(renameIdentifier) || renameIdentifier);
<del> this.scope.definitions.delete(declarator.id.name);
<add> if(renameIdentifier && declarator.id.type === "Identifier") {
<add> const hook = this.hooks.canRename.get(renameIdentifier);
<add> if(hook !== undefined && hook.call(declarator.init)) {
<add> // renaming with "var a = b;"
<add> const hook = this.hooks.rename.get(renameIdentifier);
<add> if(hook === undefined || !hook.call(declarator.init)) {
<add> this.scope.renames.set(declarator.id.name, this.scope.renames.get(renameIdentifier) || renameIdentifier);
<add> this.scope.definitions.delete(declarator.id.name);
<add> }
<add> break;
<ide> }
<del> } else {
<del> this.walkPattern(declarator.id);
<del> if(declarator.init)
<del> this.walkExpression(declarator.init);
<ide> }
<add> this.walkPattern(declarator.id);
<add> if(declarator.init)
<add> this.walkExpression(declarator.init);
<ide> break;
<ide> }
<ide> }
<ide> class Parser extends Tapable {
<ide> if(expression.operator === "typeof") {
<ide> const exprName = this.getNameForExpression(expression.argument);
<ide> if(exprName && exprName.free) {
<del> const result = this.hooks.typeof.for(exprName.name).call(expression);
<del> if(result === true)
<del> return;
<add> const hook = this.hooks.typeof.get(exprName.name);
<add> if(hook !== undefined) {
<add> const result = hook.call(expression);
<add> if(result === true)
<add> return;
<add> }
<ide> }
<ide> }
<ide> this.walkExpression(expression.argument);
<ide> class Parser extends Tapable {
<ide>
<ide> walkAssignmentExpression(expression) {
<ide> const renameIdentifier = this.getRenameIdentifier(expression.right);
<del> if(expression.left.type === "Identifier" && renameIdentifier && this.hooks.canRename.for(renameIdentifier).call(expression.right)) {
<del> // renaming "a = b;"
<del> if(!this.hooks.rename.for(renameIdentifier).call(expression.right)) {
<del> this.scope.renames.set(expression.left.name, renameIdentifier);
<del> this.scope.definitions.delete(expression.left.name);
<add> if(expression.left.type === "Identifier" && renameIdentifier) {
<add> const hook = this.hooks.canRename.get(renameIdentifier);
<add> if(hook !== undefined && hook.call(expression.right)) {
<add> // renaming "a = b;"
<add> const hook = this.hooks.rename.get(renameIdentifier);
<add> if(hook === undefined || !hook.call(expression.right)) {
<add> this.scope.renames.set(expression.left.name, renameIdentifier);
<add> this.scope.definitions.delete(expression.left.name);
<add> }
<add> return;
<ide> }
<del> } else if(expression.left.type === "Identifier") {
<del> if(!this.hooks.assigned.for(expression.left.name).call(expression)) {
<add> }
<add> if(expression.left.type === "Identifier") {
<add> const assignedHook = this.hooks.assigned.get(expression.left.name);
<add> if(assignedHook === undefined || !assignedHook.call(expression)) {
<ide> this.walkExpression(expression.right);
<ide> }
<ide> this.scope.renames.set(expression.left.name, null);
<del> if(!this.hooks.assign.for(expression.left.name).call(expression)) {
<add> const assignHook = this.hooks.assign.get(expression.left.name);
<add> if(assignHook === undefined || !assignHook.call(expression)) {
<ide> this.walkExpression(expression.left);
<ide> }
<del> } else {
<del> this.walkExpression(expression.right);
<del> this.walkPattern(expression.left);
<del> this.enterPattern(expression.left, (name, decl) => {
<del> this.scope.renames.set(name, null);
<del> });
<add> return;
<ide> }
<add> this.walkExpression(expression.right);
<add> this.walkPattern(expression.left);
<add> this.enterPattern(expression.left, (name, decl) => {
<add> this.scope.renames.set(name, null);
<add> });
<ide> }
<ide>
<ide> walkConditionalExpression(expression) {
<ide> class Parser extends Tapable {
<ide> const walkIIFE = (functionExpression, options, currentThis) => {
<ide> const renameArgOrThis = argOrThis => {
<ide> const renameIdentifier = this.getRenameIdentifier(argOrThis);
<del> if(renameIdentifier && this.hooks.canRename.for(renameIdentifier).call(argOrThis)) {
<del> if(!this.hooks.rename.for(renameIdentifier).call(argOrThis))
<del> return renameIdentifier;
<add> if(renameIdentifier) {
<add> const hook = this.hooks.canRename.get(renameIdentifier);
<add> if(hook !== undefined && hook.call(argOrThis)) {
<add> const hook = this.hooks.rename.get(renameIdentifier);
<add> if(hook === undefined || !hook.call(argOrThis))
<add> return renameIdentifier;
<add> }
<ide> }
<ide> this.walkExpression(argOrThis);
<ide> };
<ide> class Parser extends Tapable {
<ide>
<ide> const callee = this.evaluateExpression(expression.callee);
<ide> if(callee.isIdentifier()) {
<del> result = this.hooks.call.for(callee.identifier).call(expression);
<del> if(result === true)
<del> return;
<del> let identifier = callee.identifier.replace(/\.[^.]+$/, "");
<del> if(identifier !== callee.identifier) {
<del> result = this.hooks.callAnyMember.for(identifier).call(expression);
<add> const callHook = this.hooks.call.get(callee.identifier);
<add> if(callHook !== undefined) {
<add> result = callHook.call(expression);
<ide> if(result === true)
<ide> return;
<ide> }
<add> let identifier = callee.identifier.replace(/\.[^.]+$/, "");
<add> if(identifier !== callee.identifier) {
<add> const callAnyHook = this.hooks.callAnyMember.get(identifier);
<add> if(callAnyHook !== undefined) {
<add> result = callAnyHook.call(expression);
<add> if(result === true)
<add> return;
<add> }
<add> }
<ide> }
<ide>
<ide> if(expression.callee)
<ide> class Parser extends Tapable {
<ide> walkMemberExpression(expression) {
<ide> const exprName = this.getNameForExpression(expression);
<ide> if(exprName && exprName.free) {
<del> let result = this.hooks.expression.for(exprName.name).call(expression);
<del> if(result === true)
<del> return;
<del> result = this.hooks.expressionAnyMember.for(exprName.nameGeneral).call(expression);
<del> if(result === true)
<del> return;
<add> const expressionHook = this.hooks.expression.get(exprName.name);
<add> if(expressionHook !== undefined) {
<add> const result = expressionHook.call(expression);
<add> if(result === true)
<add> return;
<add> }
<add> const expressionAnyMemberHook = this.hooks.expressionAnyMember.get(exprName.nameGeneral);
<add> if(expressionAnyMemberHook !== undefined) {
<add> const result = expressionAnyMemberHook.call(expression);
<add> if(result === true)
<add> return;
<add> }
<ide> }
<ide> this.walkExpression(expression.object);
<ide> if(expression.computed === true)
<ide> class Parser extends Tapable {
<ide>
<ide> walkIdentifier(expression) {
<ide> if(!this.scope.definitions.has(expression.name)) {
<del> const result = this.hooks.expression.for(this.scope.renames.get(expression.name) || expression.name).call(expression);
<del> if(result === true)
<del> return;
<add> const hook = this.hooks.expression.for(this.scope.renames.get(expression.name) || expression.name);
<add> if(hook !== undefined) {
<add> const result = hook.call(expression);
<add> if(result === true)
<add> return;
<add> }
<ide> }
<ide> }
<ide>
<ide> class Parser extends Tapable {
<ide>
<ide> evaluateExpression(expression) {
<ide> try {
<del> const result = this.hooks.evaluate.for(expression.type).call(expression);
<del> if(result !== undefined)
<del> return result;
<add> const hook = this.hooks.evaluate.get(expression.type);
<add> if(hook !== undefined) {
<add> const result = hook.call(expression);
<add> if(result !== undefined)
<add> return result;
<add> }
<ide> } catch(e) {
<ide> console.warn(e);
<ide> // ignore error | 1 |
Java | Java | avoid defensive checks against java.time api | 85b0ce1ef78ea0aa795e80821e206cc851c9894b | <ide><path>spring-beans/src/main/java/org/springframework/beans/PropertyEditorRegistrySupport.java
<ide> import java.net.URL;
<ide> import java.nio.charset.Charset;
<ide> import java.nio.file.Path;
<add>import java.time.ZoneId;
<ide> import java.util.Collection;
<ide> import java.util.Currency;
<ide> import java.util.HashMap;
<ide> */
<ide> public class PropertyEditorRegistrySupport implements PropertyEditorRegistry {
<ide>
<del> private static Class<?> zoneIdClass;
<del>
<del> static {
<del> try {
<del> zoneIdClass = ClassUtils.forName("java.time.ZoneId", PropertyEditorRegistrySupport.class.getClassLoader());
<del> }
<del> catch (ClassNotFoundException ex) {
<del> // Java 8 ZoneId class not available
<del> zoneIdClass = null;
<del> }
<del> }
<del>
<del>
<ide> private ConversionService conversionService;
<ide>
<ide> private boolean defaultEditorsActive = false;
<ide> private void createDefaultEditors() {
<ide> this.defaultEditors.put(URI.class, new URIEditor());
<ide> this.defaultEditors.put(URL.class, new URLEditor());
<ide> this.defaultEditors.put(UUID.class, new UUIDEditor());
<del> if (zoneIdClass != null) {
<del> this.defaultEditors.put(zoneIdClass, new ZoneIdEditor());
<del> }
<add> this.defaultEditors.put(ZoneId.class, new ZoneIdEditor());
<ide>
<ide> // Default instances of collection editors.
<ide> // Can be overridden by registering custom instances of those as custom editors.
<ide><path>spring-context/src/main/java/org/springframework/format/support/DefaultFormattingConversionService.java
<ide> /*
<del> * Copyright 2002-2015 the original author or authors.
<add> * Copyright 2002-2016 the original author or authors.
<ide> *
<ide> * Licensed under the Apache License, Version 2.0 (the "License");
<ide> * you may not use this file except in compliance with the License.
<ide> import org.springframework.format.datetime.DateFormatterRegistrar;
<ide> import org.springframework.format.datetime.joda.JodaTimeFormatterRegistrar;
<ide> import org.springframework.format.datetime.standard.DateTimeFormatterRegistrar;
<add>import org.springframework.format.number.NumberFormatAnnotationFormatterFactory;
<ide> import org.springframework.format.number.money.CurrencyUnitFormatter;
<ide> import org.springframework.format.number.money.Jsr354NumberFormatAnnotationFormatterFactory;
<ide> import org.springframework.format.number.money.MonetaryAmountFormatter;
<del>import org.springframework.format.number.NumberFormatAnnotationFormatterFactory;
<ide> import org.springframework.util.ClassUtils;
<ide> import org.springframework.util.StringValueResolver;
<ide>
<ide> public class DefaultFormattingConversionService extends FormattingConversionServ
<ide> private static final boolean jsr354Present = ClassUtils.isPresent(
<ide> "javax.money.MonetaryAmount", DefaultFormattingConversionService.class.getClassLoader());
<ide>
<del> private static final boolean jsr310Present = ClassUtils.isPresent(
<del> "java.time.LocalDate", DefaultFormattingConversionService.class.getClassLoader());
<del>
<ide> private static final boolean jodaTimePresent = ClassUtils.isPresent(
<ide> "org.joda.time.LocalDate", DefaultFormattingConversionService.class.getClassLoader());
<ide>
<ide> public static void addDefaultFormatters(FormatterRegistry formatterRegistry) {
<ide> }
<ide>
<ide> // Default handling of date-time values
<del> if (jsr310Present) {
<del> // just handling JSR-310 specific date and time types
<del> new DateTimeFormatterRegistrar().registerFormatters(formatterRegistry);
<del> }
<add>
<add> // just handling JSR-310 specific date and time types
<add> new DateTimeFormatterRegistrar().registerFormatters(formatterRegistry);
<add>
<ide> if (jodaTimePresent) {
<ide> // handles Joda-specific types as well as Date, Calendar, Long
<ide> new JodaTimeFormatterRegistrar().registerFormatters(formatterRegistry);
<ide><path>spring-core/src/main/java/org/springframework/core/convert/support/DefaultConversionService.java
<ide>
<ide> import org.springframework.core.convert.ConversionService;
<ide> import org.springframework.core.convert.converter.ConverterRegistry;
<del>import org.springframework.util.ClassUtils;
<ide>
<ide> /**
<ide> * A specialization of {@link GenericConversionService} configured by default with
<ide> */
<ide> public class DefaultConversionService extends GenericConversionService {
<ide>
<del> /** Java 8's java.time package available? */
<del> private static final boolean jsr310Available =
<del> ClassUtils.isPresent("java.time.ZoneId", DefaultConversionService.class.getClassLoader());
<del>
<del>
<ide> /**
<ide> * Create a new {@code DefaultConversionService} with the set of
<ide> * {@linkplain DefaultConversionService#addDefaultConverters(ConverterRegistry) default converters}.
<ide> public static void addDefaultConverters(ConverterRegistry converterRegistry) {
<ide> addCollectionConverters(converterRegistry);
<ide>
<ide> converterRegistry.addConverter(new ByteBufferConverter((ConversionService) converterRegistry));
<del> if (jsr310Available) {
<del> Jsr310ConverterRegistrar.registerJsr310Converters(converterRegistry);
<del> }
<add> converterRegistry.addConverter(new StringToTimeZoneConverter());
<add> converterRegistry.addConverter(new ZoneIdToTimeZoneConverter());
<add> converterRegistry.addConverter(new ZonedDateTimeToCalendarConverter());
<ide>
<ide> converterRegistry.addConverter(new ObjectToObjectConverter());
<ide> converterRegistry.addConverter(new IdToEntityConverter((ConversionService) converterRegistry));
<ide> private static void addScalarConverters(ConverterRegistry converterRegistry) {
<ide> converterRegistry.addConverter(UUID.class, String.class, new ObjectToStringConverter());
<ide> }
<ide>
<del>
<del> /**
<del> * Inner class to avoid a hard-coded dependency on Java 8's {@code java.time} package.
<del> */
<del> private static final class Jsr310ConverterRegistrar {
<del>
<del> public static void registerJsr310Converters(ConverterRegistry converterRegistry) {
<del> converterRegistry.addConverter(new StringToTimeZoneConverter());
<del> converterRegistry.addConverter(new ZoneIdToTimeZoneConverter());
<del> converterRegistry.addConverter(new ZonedDateTimeToCalendarConverter());
<del> }
<del> }
<del>
<ide> }
<ide><path>spring-web/src/main/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.java
<ide> private void registerWellKnownModulesIfAvailable(ObjectMapper objectMapper) {
<ide> // jackson-datatype-jdk8 not available
<ide> }
<ide>
<del> // Java 8 java.time package present?
<del> if (ClassUtils.isPresent("java.time.LocalDate", this.moduleClassLoader)) {
<del> try {
<del> Class<? extends Module> javaTimeModule = (Class<? extends Module>)
<del> ClassUtils.forName("com.fasterxml.jackson.datatype.jsr310.JavaTimeModule", this.moduleClassLoader);
<del> objectMapper.registerModule(BeanUtils.instantiateClass(javaTimeModule));
<del> }
<del> catch (ClassNotFoundException ex) {
<del> // jackson-datatype-jsr310 not available
<del> }
<add> try {
<add> Class<? extends Module> javaTimeModule = (Class<? extends Module>)
<add> ClassUtils.forName("com.fasterxml.jackson.datatype.jsr310.JavaTimeModule", this.moduleClassLoader);
<add> objectMapper.registerModule(BeanUtils.instantiateClass(javaTimeModule));
<add> }
<add> catch (ClassNotFoundException ex) {
<add> // jackson-datatype-jsr310 not available
<ide> }
<ide>
<ide> // Joda-Time present?
<ide><path>spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ServletRequestMethodArgumentResolver.java
<ide> public boolean supportsParameter(MethodParameter parameter) {
<ide> Principal.class.isAssignableFrom(paramType) ||
<ide> Locale.class == paramType ||
<ide> TimeZone.class == paramType ||
<del> "java.time.ZoneId".equals(paramType.getName()) ||
<add> ZoneId.class == paramType ||
<ide> InputStream.class.isAssignableFrom(paramType) ||
<ide> Reader.class.isAssignableFrom(paramType) ||
<ide> HttpMethod.class == paramType);
<ide> else if (TimeZone.class == paramType) {
<ide> TimeZone timeZone = RequestContextUtils.getTimeZone(request);
<ide> return (timeZone != null ? timeZone : TimeZone.getDefault());
<ide> }
<del> else if ("java.time.ZoneId".equals(paramType.getName())) {
<del> return ZoneIdResolver.resolveZoneId(request);
<add> else if (ZoneId.class == paramType) {
<add> TimeZone timeZone = RequestContextUtils.getTimeZone(request);
<add> return (timeZone != null ? timeZone.toZoneId() : ZoneId.systemDefault());
<ide> }
<ide> else if (InputStream.class.isAssignableFrom(paramType)) {
<ide> return request.getInputStream();
<ide> else if (Reader.class.isAssignableFrom(paramType)) {
<ide> }
<ide> }
<ide>
<del>
<del> /**
<del> * Inner class to avoid a hard-coded dependency on Java 8's {@link java.time.ZoneId}.
<del> */
<del> private static class ZoneIdResolver {
<del>
<del> public static Object resolveZoneId(HttpServletRequest request) {
<del> TimeZone timeZone = RequestContextUtils.getTimeZone(request);
<del> return (timeZone != null ? timeZone.toZoneId() : ZoneId.systemDefault());
<del> }
<del> }
<del>
<ide> } | 5 |
Javascript | Javascript | fix mutability of return values | 56950674d6f56e1577df2affcf884619d91fa0bf | <ide><path>lib/internal/util.js
<ide> exports.cachedResult = function cachedResult(fn) {
<ide> return () => {
<ide> if (result === undefined)
<ide> result = fn();
<del> return result;
<add> return result.slice();
<ide> };
<ide> };
<ide>
<ide><path>lib/tls.js
<ide> exports.DEFAULT_CIPHERS =
<ide>
<ide> exports.DEFAULT_ECDH_CURVE = 'prime256v1';
<ide>
<del>exports.getCiphers = internalUtil.cachedResult(() => {
<del> return internalUtil.filterDuplicateStrings(binding.getSSLCiphers(), true);
<del>});
<add>exports.getCiphers = internalUtil.cachedResult(
<add> () => internalUtil.filterDuplicateStrings(binding.getSSLCiphers(), true)
<add>);
<ide>
<ide> // Convert protocols array into valid OpenSSL protocols list
<ide> // ("\x06spdy/2\x08http/1.1\x08http/1.0")
<ide><path>test/parallel/test-crypto.js
<ide> assert(crypto.getCurves().includes('secp384r1'));
<ide> assert(!crypto.getCurves().includes('SECP384R1'));
<ide> validateList(crypto.getCurves());
<ide>
<add>// Modifying return value from get* functions should not mutate subsequent
<add>// return values.
<add>function testImmutability(fn) {
<add> const list = fn();
<add> const copy = [...list];
<add> list.push('some-arbitrary-value');
<add> assert.deepStrictEqual(fn(), copy);
<add>}
<add>
<add>testImmutability(crypto.getCiphers);
<add>testImmutability(tls.getCiphers);
<add>testImmutability(crypto.getHashes);
<add>testImmutability(crypto.getCurves);
<add>
<ide> // Regression tests for #5725: hex input that's not a power of two should
<ide> // throw, not assert in C++ land.
<ide> assert.throws(function() { | 3 |
Go | Go | add tests for logging | 2ec3e14c0ff7f8552c1f9b09ffde743632fa1f8c | <ide><path>daemon/logger/loggertest/logreader.go
<ide> package loggertest // import "github.com/docker/docker/daemon/logger/loggertest"
<ide> import (
<ide> "runtime"
<ide> "strings"
<add> "sync"
<ide> "testing"
<ide> "time"
<ide>
<ide> func (tr Reader) TestFollow(t *testing.T) {
<ide> <-doneReading
<ide> assert.DeepEqual(t, logs, expected, compareLog)
<ide> })
<add>
<add> t.Run("Concurrent", tr.TestConcurrent)
<add>}
<add>
<add>// TestConcurrent tests the Logger and its LogReader implementation for
<add>// race conditions when logging from multiple goroutines concurrently.
<add>func (tr Reader) TestConcurrent(t *testing.T) {
<add> t.Parallel()
<add> l := tr.Factory(t, logger.Info{
<add> ContainerID: "logconcurrent0",
<add> ContainerName: "logconcurrent123",
<add> })(t)
<add>
<add> // Split test messages
<add> stderrMessages := []*logger.Message{}
<add> stdoutMessages := []*logger.Message{}
<add> for _, m := range makeTestMessages() {
<add> if m.Source == "stdout" {
<add> stdoutMessages = append(stdoutMessages, m)
<add> } else if m.Source == "stderr" {
<add> stderrMessages = append(stderrMessages, m)
<add> }
<add> }
<add>
<add> // Follow all logs
<add> lw := l.(logger.LogReader).ReadLogs(logger.ReadConfig{Follow: true, Tail: -1})
<add> defer lw.ConsumerGone()
<add>
<add> // Log concurrently from two sources and close log
<add> wg := &sync.WaitGroup{}
<add> logAll := func(msgs []*logger.Message) {
<add> defer wg.Done()
<add> for _, m := range msgs {
<add> l.Log(copyLogMessage(m))
<add> }
<add> }
<add>
<add> closed := make(chan struct{})
<add> wg.Add(2)
<add> go logAll(stdoutMessages)
<add> go logAll(stderrMessages)
<add> go func() {
<add> defer close(closed)
<add> defer l.Close()
<add> wg.Wait()
<add> }()
<add>
<add> // Check if the message count, order and content is equal to what was logged
<add> for {
<add> l := readMessage(t, lw)
<add> if l == nil {
<add> break
<add> }
<add>
<add> var messages *[]*logger.Message
<add> if l.Source == "stdout" {
<add> messages = &stdoutMessages
<add> } else if l.Source == "stderr" {
<add> messages = &stderrMessages
<add> } else {
<add> t.Fatalf("Corrupted message.Source = %q", l.Source)
<add> }
<add>
<add> expectedMsg := transformToExpected((*messages)[0])
<add>
<add> assert.DeepEqual(t, *expectedMsg, *l, compareLog)
<add> *messages = (*messages)[1:]
<add> }
<add>
<add> assert.Equal(t, len(stdoutMessages), 0)
<add> assert.Equal(t, len(stderrMessages), 0)
<add>
<add> // Make sure log gets closed before we return
<add> // so the temporary dir can be deleted
<add> <-closed
<ide> }
<ide>
<ide> // logMessages logs messages to l and returns a slice of messages as would be
<ide> func logMessages(t *testing.T, l logger.Logger, messages []*logger.Message) []*l
<ide> assert.NilError(t, l.Log(copyLogMessage(m)))
<ide> runtime.Gosched()
<ide>
<del> // Copy the log message again so as not to mutate the input.
<del> expect := copyLogMessage(m)
<del> // Existing API consumers expect a newline to be appended to
<del> // messages other than nonterminal partials as that matches the
<del> // existing behavior of the json-file log driver.
<del> if m.PLogMetaData == nil || m.PLogMetaData.Last {
<del> expect.Line = append(expect.Line, '\n')
<del> }
<add> expect := transformToExpected(m)
<ide> expected = append(expected, expect)
<ide> }
<ide> return expected
<ide> }
<ide>
<add>// Existing API consumers expect a newline to be appended to
<add>// messages other than nonterminal partials as that matches the
<add>// existing behavior of the json-file log driver.
<add>func transformToExpected(m *logger.Message) *logger.Message {
<add> // Copy the log message again so as not to mutate the input.
<add> copy := copyLogMessage(m)
<add> if m.PLogMetaData == nil || m.PLogMetaData.Last {
<add> copy.Line = append(copy.Line, '\n')
<add> }
<add>
<add> return copy
<add>}
<add>
<ide> func copyLogMessage(src *logger.Message) *logger.Message {
<ide> dst := logger.NewMessage()
<ide> dst.Source = src.Source
<ide><path>integration/container/logs_test.go
<ide> package container // import "github.com/docker/docker/integration/container"
<ide>
<ide> import (
<add> "bytes"
<ide> "context"
<ide> "io"
<add> "strings"
<ide> "testing"
<add> "time"
<ide>
<ide> "github.com/docker/docker/api/types"
<add> "github.com/docker/docker/daemon/logger/jsonfilelog"
<add> "github.com/docker/docker/daemon/logger/local"
<ide> "github.com/docker/docker/integration/internal/container"
<add> "github.com/docker/docker/integration/internal/termtest"
<ide> "github.com/docker/docker/pkg/stdcopy"
<ide> "gotest.tools/v3/assert"
<add> "gotest.tools/v3/assert/cmp"
<add> "gotest.tools/v3/poll"
<ide> "gotest.tools/v3/skip"
<ide> )
<ide>
<ide> func TestLogsFollowTailEmpty(t *testing.T) {
<ide> _, err = stdcopy.StdCopy(io.Discard, io.Discard, logs)
<ide> assert.Check(t, err)
<ide> }
<add>
<add>func TestLogs(t *testing.T) {
<add> drivers := []string{local.Name, jsonfilelog.Name}
<add>
<add> for _, logDriver := range drivers {
<add> t.Run("driver "+logDriver, func(t *testing.T) {
<add> testLogs(t, logDriver)
<add> })
<add> }
<add>}
<add>
<add>func testLogs(t *testing.T, logDriver string) {
<add> defer setupTest(t)()
<add> client := testEnv.APIClient()
<add> ctx := context.Background()
<add>
<add> testCases := []struct {
<add> desc string
<add> logOps types.ContainerLogsOptions
<add> expectedOut string
<add> expectedErr string
<add> tty bool
<add> }{
<add> // TTY, only one output stream
<add> {
<add> desc: "tty/stdout and stderr",
<add> tty: true,
<add> logOps: types.ContainerLogsOptions{
<add> ShowStdout: true,
<add> ShowStderr: true,
<add> },
<add> expectedOut: "this is fineaccidents happen",
<add> },
<add> {
<add> desc: "tty/only stdout",
<add> tty: true,
<add> logOps: types.ContainerLogsOptions{
<add> ShowStdout: true,
<add> ShowStderr: false,
<add> },
<add> expectedOut: "this is fineaccidents happen",
<add> },
<add> {
<add> desc: "tty/only stderr",
<add> tty: true,
<add> logOps: types.ContainerLogsOptions{
<add> ShowStdout: false,
<add> ShowStderr: true,
<add> },
<add> expectedOut: "",
<add> },
<add> // Without TTY, both stdout and stderr
<add> {
<add> desc: "without tty/stdout and stderr",
<add> tty: false,
<add> logOps: types.ContainerLogsOptions{
<add> ShowStdout: true,
<add> ShowStderr: true,
<add> },
<add> expectedOut: "this is fine",
<add> expectedErr: "accidents happen",
<add> },
<add> {
<add> desc: "without tty/only stdout",
<add> tty: false,
<add> logOps: types.ContainerLogsOptions{
<add> ShowStdout: true,
<add> ShowStderr: false,
<add> },
<add> expectedOut: "this is fine",
<add> expectedErr: "",
<add> },
<add> {
<add> desc: "without tty/only stderr",
<add> tty: false,
<add> logOps: types.ContainerLogsOptions{
<add> ShowStdout: false,
<add> ShowStderr: true,
<add> },
<add> expectedOut: "",
<add> expectedErr: "accidents happen",
<add> },
<add> }
<add>
<add> for _, tC := range testCases {
<add> tC := tC
<add> t.Run(tC.desc, func(t *testing.T) {
<add> t.Parallel()
<add> tty := tC.tty
<add> id := container.Run(ctx, t, client,
<add> container.WithCmd("sh", "-c", "echo -n this is fine; echo -n accidents happen >&2"),
<add> container.WithTty(tty),
<add> container.WithLogDriver(logDriver),
<add> )
<add> defer client.ContainerRemove(ctx, id, types.ContainerRemoveOptions{Force: true})
<add>
<add> poll.WaitOn(t, container.IsStopped(ctx, client, id), poll.WithDelay(time.Millisecond*100))
<add>
<add> logs, err := client.ContainerLogs(ctx, id, tC.logOps)
<add> assert.NilError(t, err)
<add> defer logs.Close()
<add>
<add> var stdout, stderr bytes.Buffer
<add> if tty {
<add> // TTY, only one output stream
<add> _, err = io.Copy(&stdout, logs)
<add> } else {
<add> _, err = stdcopy.StdCopy(&stdout, &stderr, logs)
<add> }
<add> assert.NilError(t, err)
<add>
<add> stdoutStr := stdout.String()
<add>
<add> if tty && testEnv.OSType == "windows" {
<add> stdoutStr = stripEscapeCodes(t, stdoutStr)
<add>
<add> // Special case for Windows Server 2019
<add> // Check only that the raw output stream contains strings
<add> // that were printed to container's stdout and stderr.
<add> // This is a workaround for the backspace being outputted in an unexpected place
<add> // which breaks the parsed output: https://github.com/moby/moby/issues/43710
<add> if strings.Contains(testEnv.DaemonInfo.OperatingSystem, "Windows Server Version 1809") {
<add> if tC.logOps.ShowStdout {
<add> assert.Check(t, cmp.Contains(stdout.String(), "this is fine"))
<add> assert.Check(t, cmp.Contains(stdout.String(), "accidents happen"))
<add> } else {
<add> assert.DeepEqual(t, stdoutStr, "")
<add> }
<add> return
<add> }
<add>
<add> }
<add>
<add> assert.DeepEqual(t, stdoutStr, tC.expectedOut)
<add> assert.DeepEqual(t, stderr.String(), tC.expectedErr)
<add> })
<add> }
<add>}
<add>
<add>// This hack strips the escape codes that appear in the Windows TTY output and don't have
<add>// any effect on the text content.
<add>// This doesn't handle all escape sequences, only ones that were encountered during testing.
<add>func stripEscapeCodes(t *testing.T, input string) string {
<add> t.Logf("Stripping: %q\n", input)
<add> output, err := termtest.StripANSICommands(input)
<add> assert.NilError(t, err)
<add> return output
<add>}
<ide><path>integration/internal/termtest/stripansi.go
<add>package termtest // import "github.com/docker/docker/integration/internal/termtest"
<add>
<add>import (
<add> "errors"
<add> "regexp"
<add>
<add> "github.com/Azure/go-ansiterm"
<add>)
<add>
<add>var stripOSC = regexp.MustCompile(`\x1b\][^\x1b\a]*(\x1b\\|\a)`)
<add>
<add>// StripANSICommands attempts to strip ANSI console escape and control sequences
<add>// from s, returning a string containing only the final printed characters which
<add>// would be visible onscreen if the string was to be processed by a terminal
<add>// emulator. Basic cursor positioning and screen erase control sequences are
<add>// parsed and processed such that the output of simple CLI commands passed
<add>// through a Windows Pseudoterminal and then this function yields the same
<add>// string as if the output of those commands was redirected to a file.
<add>//
<add>// The only correct way to represent the result of processing ANSI console
<add>// output would be a two-dimensional array of an emulated terminal's display
<add>// buffer. That would be awkward to test against, so this function instead
<add>// attempts to render to a one-dimensional string without extra padding. This is
<add>// an inherently lossy process, and any attempts to render a string containing
<add>// many cursor positioning commands are unlikely to yield satisfactory results.
<add>// Handlers for several ANSI control sequences are also unimplemented; attempts
<add>// to parse a string containing one will panic.
<add>func StripANSICommands(s string, opts ...ansiterm.Option) (string, error) {
<add> // Work around https://github.com/Azure/go-ansiterm/issues/34
<add> s = stripOSC.ReplaceAllLiteralString(s, "")
<add>
<add> var h stringHandler
<add> p := ansiterm.CreateParser("Ground", &h, opts...)
<add> _, err := p.Parse([]byte(s))
<add> return h.String(), err
<add>}
<add>
<add>type stringHandler struct {
<add> ansiterm.AnsiEventHandler
<add> cursor int
<add> b []byte
<add>}
<add>
<add>func (h *stringHandler) Print(b byte) error {
<add> if h.cursor == len(h.b) {
<add> h.b = append(h.b, b)
<add> } else {
<add> h.b[h.cursor] = b
<add> }
<add> h.cursor++
<add> return nil
<add>}
<add>
<add>func (h *stringHandler) Execute(b byte) error {
<add> switch b {
<add> case '\b':
<add> if h.cursor > 0 {
<add> if h.cursor == len(h.b) && h.b[h.cursor-1] == ' ' {
<add> h.b = h.b[:len(h.b)-1]
<add> }
<add> h.cursor--
<add> }
<add> case '\r', '\n':
<add> h.Print(b)
<add> }
<add> return nil
<add>}
<add>
<add>// Erase Display
<add>func (h *stringHandler) ED(v int) error {
<add> switch v {
<add> case 1: // Erase from start to cursor.
<add> for i := 0; i < h.cursor; i++ {
<add> h.b[i] = ' '
<add> }
<add> case 2, 3: // Erase whole display.
<add> h.b = make([]byte, h.cursor)
<add> for i := range h.b {
<add> h.b[i] = ' '
<add> }
<add> default: // Erase from cursor to end of display.
<add> h.b = h.b[:h.cursor+1]
<add> }
<add> return nil
<add>}
<add>
<add>// CUrsor Position
<add>func (h *stringHandler) CUP(x, y int) error {
<add> if x > 1 {
<add> return errors.New("termtest: cursor position not supported for X > 1")
<add> }
<add> if y > len(h.b) {
<add> for n := len(h.b) - y; n > 0; n-- {
<add> h.b = append(h.b, ' ')
<add> }
<add> }
<add> h.cursor = y - 1
<add> return nil
<add>}
<add>
<add>func (h stringHandler) DECTCEM(bool) error { return nil } // Text Cursor Enable
<add>func (h stringHandler) SGR(v []int) error { return nil } // Set Graphics Rendition
<add>func (h stringHandler) DA(attrs []string) error { return nil }
<add>func (h stringHandler) Flush() error { return nil }
<add>
<add>func (h *stringHandler) String() string {
<add> return string(h.b)
<add>}
<ide><path>integration/internal/termtest/stripansi_test.go
<add>package termtest // import "github.com/docker/docker/integration/internal/termtest"
<add>
<add>import (
<add> "testing"
<add>
<add> "gotest.tools/v3/assert"
<add>)
<add>
<add>func TestStripANSICommands(t *testing.T) {
<add> for _, tt := range []struct{ input, want string }{
<add> {
<add> input: "\x1b[2J\x1b[?25l\x1b[m\x1b[Hthis is fine\b\x1b]0;C:\\bin\\sh.exe\x00\a\x1b[?25h\x1b[Ht\x1b[1;13H\x1b[?25laccidents happen \b\x1b[?25h\x1b[Ht\x1b[1;29H",
<add> want: "this is fineaccidents happen",
<add> },
<add> {
<add> input: "\x1b[2J\x1b[m\x1b[Hthis is fine\x1b]0;C:\\bin\\sh.exe\a\x1b[?25haccidents happen",
<add> want: "this is fineaccidents happen",
<add> },
<add> } {
<add> t.Run("", func(t *testing.T) {
<add> got, err := StripANSICommands(tt.input)
<add> assert.NilError(t, err)
<add> assert.DeepEqual(t, tt.want, got)
<add> })
<add> }
<add>} | 4 |
Text | Text | add learnnextjs link | a52458181a4e2f3d6e2fea64e34f158e087037f6 | <ide><path>readme.md
<ide> Next.js is a minimalistic framework for server-rendered React applications.
<ide> <!-- https://github.com/thlorenz/doctoc -->
<ide>
<ide> - [How to use](#how-to-use)
<add> - [Getting Started](#getting-started)
<ide> - [Setup](#setup)
<ide> - [Automatic code splitting](#automatic-code-splitting)
<ide> - [CSS](#css)
<ide> Next.js is a minimalistic framework for server-rendered React applications.
<ide>
<ide> ## How to use
<ide>
<add>### Gettin Started
<add>A step by step interactive guide of next features is available at [learnnextjs.com](https://learnnextjs.com/)
<add>
<ide> ### Setup
<ide>
<ide> Install it: | 1 |
Text | Text | add docs for named exports using dynamic | a169017c87f52fc6ddf0a59ae88f9d468cf50697 | <ide><path>packages/next/README.md
<ide> Since Next.js supports dynamic imports with SSR, you could do amazing things wit
<ide>
<ide> Here are a few ways to use dynamic imports.
<ide>
<del>#### 1. Basic Usage (Also does SSR)
<add>#### Basic Usage (Also does SSR)
<ide>
<ide> ```jsx
<ide> import dynamic from 'next/dynamic'
<ide> function Home() {
<ide> export default Home
<ide> ```
<ide>
<del>#### 2. With Custom Loading Component
<add>#### With named exports
<add>
<add>```jsx
<add>// components/hello.js
<add>export function Hello() {
<add> return (
<add> <p>Hello!</p>
<add> )
<add>}
<add>```
<add>
<add>```jsx
<add>import dynamic from 'next/dynamic'
<add>
<add>const DynamicComponent = dynamic(() => import('../components/hello').then((mod) => mod.Hello))
<add>
<add>function Home() {
<add> return (
<add> <div>
<add> <Header />
<add> <DynamicComponent />
<add> <p>HOME PAGE is here!</p>
<add> </div>
<add> )
<add>}
<add>
<add>export default Home
<add>```
<add>
<add>#### With Custom Loading Component
<ide>
<ide> ```jsx
<ide> import dynamic from 'next/dynamic'
<ide> function Home() {
<ide> export default Home
<ide> ```
<ide>
<del>#### 3. With No SSR
<add>#### With No SSR
<ide>
<ide> ```jsx
<ide> import dynamic from 'next/dynamic'
<ide> function Home() {
<ide> export default Home
<ide> ```
<ide>
<del>#### 4. With Multiple Modules At Once
<add>#### With Multiple Modules At Once
<ide>
<ide> ```jsx
<ide> import dynamic from 'next/dynamic' | 1 |
PHP | PHP | fix cs as per psr-12 | d397fbdcc8ab2150f26cf3f4cf75b51d58d6b689 | <ide><path>src/Cache/Engine/FileEngine.php
<ide> protected function _setKey($key, $createKey = false)
<ide> if (!$createKey && !$path->isFile()) {
<ide> return false;
<ide> }
<del> if (empty($this->_File) ||
<add> if (
<add> empty($this->_File) ||
<ide> $this->_File->getBasename() !== $key ||
<ide> $this->_File->valid() === false
<ide> ) {
<ide><path>src/Cache/Engine/MemcachedEngine.php
<ide> protected function _setOptions()
<ide> );
<ide> }
<ide>
<del> if ($serializer !== 'php' &&
<add> if (
<add> $serializer !== 'php' &&
<ide> !constant('Memcached::HAVE_' . strtoupper($serializer))
<ide> ) {
<ide> throw new InvalidArgumentException(
<ide> protected function _setOptions()
<ide> );
<ide>
<ide> // Check for Amazon ElastiCache instance
<del> if (defined('Memcached::OPT_CLIENT_MODE') &&
<add> if (
<add> defined('Memcached::OPT_CLIENT_MODE') &&
<ide> defined('Memcached::DYNAMIC_CLIENT_MODE')
<ide> ) {
<ide> $this->_Memcached->setOption(
<ide><path>src/Collection/ExtractTrait.php
<ide> protected function _extract($data, $path)
<ide> continue;
<ide> }
<ide>
<del> if ($collectionTransform &&
<del> !($data instanceof Traversable || is_array($data))) {
<add> if (
<add> $collectionTransform &&
<add> !($data instanceof Traversable || is_array($data))
<add> ) {
<ide> return null;
<ide> }
<ide>
<ide><path>src/Console/ConsoleOutput.php
<ide> public function __construct($stream = 'php://stdout')
<ide> {
<ide> $this->_output = fopen($stream, 'wb');
<ide>
<del> if ((DIRECTORY_SEPARATOR === '\\' && !(bool)env('ANSICON') && env('ConEmuANSI') !== 'ON') ||
<add> if (
<add> (DIRECTORY_SEPARATOR === '\\' && !(bool)env('ANSICON') && env('ConEmuANSI') !== 'ON') ||
<ide> (function_exists('posix_isatty') && !posix_isatty($this->_output))
<ide> ) {
<ide> $this->_outputAs = self::PLAIN;
<ide><path>src/Controller/Component/AuthComponent.php
<ide> public function authCheck(Event $event)
<ide> return $result;
<ide> }
<ide>
<del> if ($isLoginAction ||
<add> if (
<add> $isLoginAction ||
<ide> empty($this->_config['authorize']) ||
<ide> $this->isAuthorized($this->user())
<ide> ) {
<ide><path>src/Controller/Component/RequestHandlerComponent.php
<ide> public function beforeRender(Event $event)
<ide> $response = $response->withCharset(Configure::read('App.encoding'));
<ide> }
<ide>
<del> if ($this->_config['checkHttpCache'] &&
<add> if (
<add> $this->_config['checkHttpCache'] &&
<ide> $response->checkNotModified($request)
<ide> ) {
<ide> $controller->setResponse($response);
<ide> public function requestedWith($type = null)
<ide> $request = $controller->getRequest();
<ide> $response = $controller->getResponse();
<ide>
<del> if (!$request->is('post') &&
<add> if (
<add> !$request->is('post') &&
<ide> !$request->is('put') &&
<ide> !$request->is('patch') &&
<ide> !$request->is('delete')
<ide><path>src/Controller/Component/SecurityComponent.php
<ide> public function startup(Event $event)
<ide> throw new AuthSecurityException(sprintf('Action %s is defined as the blackhole callback.', $this->_action));
<ide> }
<ide>
<del> if (!in_array($this->_action, (array)$this->_config['unlockedActions']) &&
<add> if (
<add> !in_array($this->_action, (array)$this->_config['unlockedActions']) &&
<ide> $hasData &&
<ide> $isNotRequestAction &&
<ide> $this->_config['validatePost']
<ide> protected function _requireMethod($method, $actions = [])
<ide> */
<ide> protected function _secureRequired(Controller $controller)
<ide> {
<del> if (is_array($this->_config['requireSecure']) &&
<add> if (
<add> is_array($this->_config['requireSecure']) &&
<ide> !empty($this->_config['requireSecure'])
<ide> ) {
<ide> $requireSecure = $this->_config['requireSecure'];
<ide> protected function _secureRequired(Controller $controller)
<ide> protected function _authRequired(Controller $controller)
<ide> {
<ide> $request = $controller->getRequest();
<del> if (is_array($this->_config['requireAuth']) &&
<add> if (
<add> is_array($this->_config['requireAuth']) &&
<ide> !empty($this->_config['requireAuth']) &&
<ide> $request->getData()
<ide> ) {
<ide> protected function _authRequired(Controller $controller)
<ide> if ($this->session->check('_Token')) {
<ide> $tData = $this->session->read('_Token');
<ide>
<del> if (!empty($tData['allowedControllers']) &&
<del> !in_array($request->getParam('controller'), $tData['allowedControllers'])) {
<add> if (
<add> !empty($tData['allowedControllers']) &&
<add> !in_array($request->getParam('controller'), $tData['allowedControllers'])
<add> ) {
<ide> throw new AuthSecurityException(
<ide> sprintf(
<ide> 'Controller \'%s\' was not found in allowed controllers: \'%s\'.',
<ide> protected function _authRequired(Controller $controller)
<ide> )
<ide> );
<ide> }
<del> if (!empty($tData['allowedActions']) &&
<add> if (
<add> !empty($tData['allowedActions']) &&
<ide> !in_array($request->getParam('action'), $tData['allowedActions'])
<ide> ) {
<ide> throw new AuthSecurityException(
<ide><path>src/Database/Dialect/SqlserverDialectTrait.php
<ide> protected function _pagingSubquery($original, $limit, $offset)
<ide> ->clause('order')
<ide> ->iterateParts(function ($direction, $orderBy) use ($select, $order) {
<ide> $key = $orderBy;
<del> if (isset($select[$orderBy]) &&
<add> if (
<add> isset($select[$orderBy]) &&
<ide> $select[$orderBy] instanceof ExpressionInterface
<ide> ) {
<ide> $key = $select[$orderBy]->sql(new ValueBinder());
<ide><path>src/Database/Driver.php
<ide> public function schemaValue($value)
<ide> if (is_float($value)) {
<ide> return str_replace(',', '.', (string)$value);
<ide> }
<del> if ((is_int($value) || $value === '0') || (
<add> if (
<add> (is_int($value) || $value === '0') || (
<ide> is_numeric($value) && strpos($value, ',') === false &&
<ide> $value[0] !== '0' && strpos($value, 'e') === false)
<ide> ) {
<ide><path>src/Database/Expression/ValuesExpression.php
<ide> public function __construct(array $columns, $typeMap)
<ide> */
<ide> public function add($data)
<ide> {
<del> if ((count($this->_values) && $data instanceof Query) ||
<add> if (
<add> (count($this->_values) && $data instanceof Query) ||
<ide> ($this->_query && is_array($data))
<ide> ) {
<ide> throw new Exception(
<ide><path>src/Database/QueryCompiler.php
<ide> public function compile(Query $query, ValueBinder $generator)
<ide> protected function _sqlCompiler(&$sql, $query, $generator)
<ide> {
<ide> return function ($parts, $name) use (&$sql, $query, $generator) {
<del> if (!isset($parts) ||
<add> if (
<add> !isset($parts) ||
<ide> ((is_array($parts) || $parts instanceof \Countable) && !count($parts))
<ide> ) {
<ide> return;
<ide><path>src/Database/Schema/MysqlSchema.php
<ide> public function columnSql(TableSchema $schema, $name)
<ide> TableSchema::TYPE_FLOAT,
<ide> TableSchema::TYPE_DECIMAL,
<ide> ];
<del> if (in_array($data['type'], $hasUnsigned, true) &&
<add> if (
<add> in_array($data['type'], $hasUnsigned, true) &&
<ide> isset($data['unsigned']) && $data['unsigned'] === true
<ide> ) {
<ide> $out .= ' UNSIGNED';
<ide> public function columnSql(TableSchema $schema, $name)
<ide> !$schema->hasAutoincrement() &&
<ide> !isset($data['autoIncrement'])
<ide> );
<del> if (in_array($data['type'], [TableSchema::TYPE_INTEGER, TableSchema::TYPE_BIGINTEGER]) &&
<add> if (
<add> in_array($data['type'], [TableSchema::TYPE_INTEGER, TableSchema::TYPE_BIGINTEGER]) &&
<ide> ($data['autoIncrement'] === true || $addAutoIncrement)
<ide> ) {
<ide> $out .= ' AUTO_INCREMENT';
<ide> public function columnSql(TableSchema $schema, $name)
<ide> $out .= ' NULL';
<ide> unset($data['default']);
<ide> }
<del> if (isset($data['default']) &&
<add> if (
<add> isset($data['default']) &&
<ide> in_array($data['type'], [TableSchema::TYPE_TIMESTAMP, TableSchema::TYPE_DATETIME]) &&
<ide> in_array(strtolower($data['default']), ['current_timestamp', 'current_timestamp()'])
<ide> ) {
<ide><path>src/Database/Schema/PostgresSchema.php
<ide> protected function _convertColumn($column)
<ide> }
<ide> // money is 'string' as it includes arbitrary text content
<ide> // before the number value.
<del> if (strpos($col, 'char') !== false ||
<add> if (
<add> strpos($col, 'char') !== false ||
<ide> strpos($col, 'money') !== false
<ide> ) {
<ide> return ['type' => TableSchema::TYPE_STRING, 'length' => $length];
<ide> protected function _convertColumn($column)
<ide> if ($col === 'real' || strpos($col, 'double') !== false) {
<ide> return ['type' => TableSchema::TYPE_FLOAT, 'length' => null];
<ide> }
<del> if (strpos($col, 'numeric') !== false ||
<add> if (
<add> strpos($col, 'numeric') !== false ||
<ide> strpos($col, 'decimal') !== false
<ide> ) {
<ide> return ['type' => TableSchema::TYPE_DECIMAL, 'length' => null];
<ide> public function columnSql(TableSchema $schema, $name)
<ide> $out .= ' BYTEA';
<ide> }
<ide>
<del> if ($data['type'] === TableSchema::TYPE_STRING ||
<add> if (
<add> $data['type'] === TableSchema::TYPE_STRING ||
<ide> ($data['type'] === TableSchema::TYPE_TEXT && $data['length'] === TableSchema::LENGTH_TINY)
<ide> ) {
<ide> $isFixed = !empty($data['fixed']);
<ide> public function columnSql(TableSchema $schema, $name)
<ide> $out .= '(' . (int)$data['precision'] . ')';
<ide> }
<ide>
<del> if ($data['type'] === TableSchema::TYPE_DECIMAL &&
<add> if (
<add> $data['type'] === TableSchema::TYPE_DECIMAL &&
<ide> (isset($data['length']) || isset($data['precision']))
<ide> ) {
<ide> $out .= '(' . (int)$data['length'] . ',' . (int)$data['precision'] . ')';
<ide> public function columnSql(TableSchema $schema, $name)
<ide> $out .= ' NOT NULL';
<ide> }
<ide>
<del> if (isset($data['default']) &&
<add> if (
<add> isset($data['default']) &&
<ide> in_array($data['type'], [TableSchema::TYPE_TIMESTAMP, TableSchema::TYPE_DATETIME]) &&
<ide> strtolower($data['default']) === 'current_timestamp'
<ide> ) {
<ide><path>src/Database/Schema/SqliteSchema.php
<ide> public function columnSql(TableSchema $schema, $name)
<ide> TableSchema::TYPE_DECIMAL,
<ide> ];
<ide>
<del> if (in_array($data['type'], $hasUnsigned, true) &&
<add> if (
<add> in_array($data['type'], $hasUnsigned, true) &&
<ide> isset($data['unsigned']) && $data['unsigned'] === true
<ide> ) {
<ide> if ($data['type'] !== TableSchema::TYPE_INTEGER || [$name] !== (array)$schema->primaryKey()) {
<ide> public function columnSql(TableSchema $schema, $name)
<ide> $out .= ' TEXT';
<ide> }
<ide>
<del> if ($data['type'] === TableSchema::TYPE_STRING ||
<add> if (
<add> $data['type'] === TableSchema::TYPE_STRING ||
<ide> ($data['type'] === TableSchema::TYPE_TEXT && $data['length'] === TableSchema::LENGTH_TINY)
<ide> ) {
<ide> $out .= ' VARCHAR';
<ide> public function columnSql(TableSchema $schema, $name)
<ide> TableSchema::TYPE_SMALLINTEGER,
<ide> TableSchema::TYPE_INTEGER,
<ide> ];
<del> if (in_array($data['type'], $integerTypes, true) &&
<add> if (
<add> in_array($data['type'], $integerTypes, true) &&
<ide> isset($data['length']) && [$name] !== (array)$schema->primaryKey()
<ide> ) {
<ide> $out .= '(' . (int)$data['length'] . ')';
<ide> }
<ide>
<ide> $hasPrecision = [TableSchema::TYPE_FLOAT, TableSchema::TYPE_DECIMAL];
<del> if (in_array($data['type'], $hasPrecision, true) &&
<add> if (
<add> in_array($data['type'], $hasPrecision, true) &&
<ide> (isset($data['length']) || isset($data['precision']))
<ide> ) {
<ide> $out .= '(' . (int)$data['length'] . ',' . (int)$data['precision'] . ')';
<ide> public function columnSql(TableSchema $schema, $name)
<ide> public function constraintSql(TableSchema $schema, $name)
<ide> {
<ide> $data = $schema->getConstraint($name);
<del> if ($data['type'] === TableSchema::CONSTRAINT_PRIMARY &&
<add> if (
<add> $data['type'] === TableSchema::CONSTRAINT_PRIMARY &&
<ide> count($data['columns']) === 1 &&
<ide> $schema->getColumn($data['columns'][0])['type'] === TableSchema::TYPE_INTEGER
<ide> ) {
<ide><path>src/Database/Schema/SqlserverSchema.php
<ide> protected function _convertColumn($col, $length = null, $precision = null, $scal
<ide> if ($col === 'bit') {
<ide> return ['type' => TableSchema::TYPE_BOOLEAN, 'length' => null];
<ide> }
<del> if (strpos($col, 'numeric') !== false ||
<add> if (
<add> strpos($col, 'numeric') !== false ||
<ide> strpos($col, 'money') !== false ||
<ide> strpos($col, 'decimal') !== false
<ide> ) {
<ide> public function columnSql(TableSchema $schema, $name)
<ide> }
<ide>
<ide> if ($data['type'] === TableSchema::TYPE_BINARY) {
<del> if (!isset($data['length'])
<del> || in_array($data['length'], [TableSchema::LENGTH_MEDIUM, TableSchema::LENGTH_LONG], true)) {
<add> if (
<add> !isset($data['length'])
<add> || in_array($data['length'], [TableSchema::LENGTH_MEDIUM, TableSchema::LENGTH_LONG], true)
<add> ) {
<ide> $data['length'] = 'MAX';
<ide> }
<ide>
<ide> public function columnSql(TableSchema $schema, $name)
<ide> }
<ide> }
<ide>
<del> if ($data['type'] === TableSchema::TYPE_STRING ||
<add> if (
<add> $data['type'] === TableSchema::TYPE_STRING ||
<ide> ($data['type'] === TableSchema::TYPE_TEXT && $data['length'] === TableSchema::LENGTH_TINY)
<ide> ) {
<ide> $type = ' NVARCHAR';
<ide> public function columnSql(TableSchema $schema, $name)
<ide> $out .= '(' . (int)$data['precision'] . ')';
<ide> }
<ide>
<del> if ($data['type'] === TableSchema::TYPE_DECIMAL &&
<add> if (
<add> $data['type'] === TableSchema::TYPE_DECIMAL &&
<ide> (isset($data['length']) || isset($data['precision']))
<ide> ) {
<ide> $out .= '(' . (int)$data['length'] . ',' . (int)$data['precision'] . ')';
<ide> public function columnSql(TableSchema $schema, $name)
<ide> $out .= ' NOT NULL';
<ide> }
<ide>
<del> if (isset($data['default']) &&
<add> if (
<add> isset($data['default']) &&
<ide> in_array($data['type'], [TableSchema::TYPE_TIMESTAMP, TableSchema::TYPE_DATETIME]) &&
<ide> strtolower($data['default']) === 'current_timestamp'
<ide> ) {
<ide><path>src/Database/SqlDialectTrait.php
<ide> protected function _removeAliasesFromConditions($query)
<ide> $conditions->traverse(function ($expression) {
<ide> if ($expression instanceof Comparison) {
<ide> $field = $expression->getField();
<del> if (is_string($field) &&
<add> if (
<add> is_string($field) &&
<ide> strpos($field, '.') !== false
<ide> ) {
<ide> list(, $unaliasedField) = explode('.', $field, 2);
<ide><path>src/Database/Type/BinaryType.php
<ide> public function toPHP($value, Driver $driver)
<ide> if ($value === null) {
<ide> return null;
<ide> }
<del> if (is_string($value)
<add> if (
<add> is_string($value)
<ide> && $driver instanceof Sqlserver
<ide> && version_compare(PHP_VERSION, '7.0', '<')
<ide> ) {
<ide><path>src/Database/Type/DateTimeType.php
<ide> public function toDatabase($value, Driver $driver)
<ide>
<ide> $format = (array)$this->_format;
<ide>
<del> if ($this->dbTimezone !== null
<add> if (
<add> $this->dbTimezone !== null
<ide> && $this->dbTimezone->getName() !== $value->getTimezone()->getName()
<ide> ) {
<ide> if (!$value instanceof DateTimeImmutable) {
<ide> public function marshal($value)
<ide> $value += ['hour' => 0, 'minute' => 0, 'second' => 0];
<ide>
<ide> $format = '';
<del> if (isset($value['year'], $value['month'], $value['day']) &&
<add> if (
<add> isset($value['year'], $value['month'], $value['day']) &&
<ide> (is_numeric($value['year']) && is_numeric($value['month']) && is_numeric($value['day']))
<ide> ) {
<ide> $format .= sprintf('%d-%02d-%02d', $value['year'], $value['month'], $value['day']);
<ide><path>src/Database/Type/DecimalType.php
<ide> public function useLocaleParser($enable = true)
<ide>
<ide> return $this;
<ide> }
<del> if (static::$numberClass === 'Cake\I18n\Number' ||
<add> if (
<add> static::$numberClass === 'Cake\I18n\Number' ||
<ide> is_subclass_of(static::$numberClass, 'Cake\I18n\Number')
<ide> ) {
<ide> $this->_useLocaleParser = $enable;
<ide><path>src/Database/Type/FloatType.php
<ide> public function useLocaleParser($enable = true)
<ide>
<ide> return $this;
<ide> }
<del> if (static::$numberClass === 'Cake\I18n\Number' ||
<add> if (
<add> static::$numberClass === 'Cake\I18n\Number' ||
<ide> is_subclass_of(static::$numberClass, 'Cake\I18n\Number')
<ide> ) {
<ide> $this->_useLocaleParser = $enable;
<ide><path>src/Datasource/EntityTrait.php
<ide> public function set($property, $value = null, array $options = [])
<ide>
<ide> $this->setDirty($p, true);
<ide>
<del> if (!array_key_exists($p, $this->_original) &&
<add> if (
<add> !array_key_exists($p, $this->_original) &&
<ide> array_key_exists($p, $this->_properties) &&
<ide> $this->_properties[$p] !== $value
<ide> ) {
<ide> public function has($property)
<ide> public function isEmpty($property)
<ide> {
<ide> $value = $this->get($property);
<del> if ($value === null
<add> if (
<add> $value === null
<ide> || (is_array($value) && empty($value)
<ide> || (is_string($value) && empty($value)))
<ide> ) {
<ide> protected function _nestedErrors($field)
<ide> $val = isset($entity[$part]) ? $entity[$part] : false;
<ide> }
<ide>
<del> if (is_array($val) ||
<add> if (
<add> is_array($val) ||
<ide> $val instanceof Traversable ||
<ide> $val instanceof EntityInterface
<ide> ) {
<ide><path>src/Datasource/Paginator.php
<ide> public function validateSort(RepositoryInterface $object, array $options)
<ide> }
<ide> }
<ide>
<del> if ($options['sort'] === null
<add> if (
<add> $options['sort'] === null
<ide> && count($options['order']) === 1
<ide> && !is_numeric(key($options['order']))
<ide> ) {
<ide><path>src/Error/ExceptionRenderer.php
<ide> protected function _message(Exception $exception, $code)
<ide> $exception = $this->_unwrap($exception);
<ide> $message = $exception->getMessage();
<ide>
<del> if (!Configure::read('debug') &&
<add> if (
<add> !Configure::read('debug') &&
<ide> !($exception instanceof HttpException)
<ide> ) {
<ide> if ($code < 500) {
<ide><path>src/Form/Form.php
<ide> */
<ide> class Form implements EventListenerInterface, EventDispatcherInterface, ValidatorAwareInterface
<ide> {
<del> /**
<del> * Schema class.
<del> *
<del> * @var string
<del> */
<del> protected $_schemaClass = Schema::class;
<del>
<ide> use EventDispatcherTrait;
<ide> use ValidatorAwareTrait;
<ide>
<ide> class Form implements EventListenerInterface, EventDispatcherInterface, Validato
<ide> */
<ide> const BUILD_VALIDATOR_EVENT = 'Form.buildValidator';
<ide>
<add> /**
<add> * Schema class.
<add> *
<add> * @var string
<add> */
<add> protected $_schemaClass = Schema::class;
<add>
<ide> /**
<ide> * The schema used by this form.
<ide> *
<ide><path>src/Http/ControllerFactory.php
<ide> public function getControllerClass(ServerRequest $request)
<ide> // Disallow plugin short forms, / and \\ from
<ide> // controller names as they allow direct references to
<ide> // be created.
<del> if (strpos($controller, '\\') !== false ||
<add> if (
<add> strpos($controller, '\\') !== false ||
<ide> strpos($controller, '/') !== false ||
<ide> strpos($controller, '.') !== false ||
<ide> $firstChar === strtolower($firstChar)
<ide><path>src/Http/Middleware/CsrfProtectionMiddleware.php
<ide> public function __construct(array $config = [])
<ide> */
<ide> public function __invoke(ServerRequest $request, Response $response, $next)
<ide> {
<del> if ($this->whitelistCallback !== null
<add> if (
<add> $this->whitelistCallback !== null
<ide> && call_user_func($this->whitelistCallback, $request) === true
<ide> ) {
<ide> return $next($request, $response);
<ide><path>src/Http/MiddlewareQueue.php
<ide> public function insertBefore($class, $middleware)
<ide> $found = false;
<ide> $i = 0;
<ide> foreach ($this->queue as $i => $object) {
<del> if ((is_string($object) && $object === $class)
<add> if (
<add> (is_string($object) && $object === $class)
<ide> || is_a($object, $class)
<ide> ) {
<ide> $found = true;
<ide> public function insertAfter($class, $middleware)
<ide> $found = false;
<ide> $i = 0;
<ide> foreach ($this->queue as $i => $object) {
<del> if ((is_string($object) && $object === $class)
<add> if (
<add> (is_string($object) && $object === $class)
<ide> || is_a($object, $class)
<ide> ) {
<ide> $found = true;
<ide><path>src/Http/Response.php
<ide> protected function _setContentType()
<ide> ];
<ide>
<ide> $charset = false;
<del> if ($this->_charset &&
<add> if (
<add> $this->_charset &&
<ide> (strpos($this->_contentType, 'text/') === 0 || in_array($this->_contentType, $whitelist))
<ide> ) {
<ide> $charset = true;
<ide><path>src/Http/ServerRequest.php
<ide> protected function _processPost($data)
<ide> $method = $this->getEnv('REQUEST_METHOD');
<ide> $override = false;
<ide>
<del> if (in_array($method, ['PUT', 'DELETE', 'PATCH'], true) &&
<add> if (
<add> in_array($method, ['PUT', 'DELETE', 'PATCH'], true) &&
<ide> strpos($this->contentType(), 'application/x-www-form-urlencoded') === 0
<ide> ) {
<ide> $data = $this->input();
<ide> public function withMethod($method)
<ide> {
<ide> $new = clone $this;
<ide>
<del> if (!is_string($method) ||
<add> if (
<add> !is_string($method) ||
<ide> !preg_match('/^[!#$%&\'*+.^_`\|~0-9a-z-]+$/i', $method)
<ide> ) {
<ide> throw new InvalidArgumentException(sprintf(
<ide><path>src/Http/ServerRequestFactory.php
<ide> protected static function updatePath($base, $uri)
<ide> }
<ide> $endsWithIndex = '/' . (Configure::read('App.webroot') ?: 'webroot') . '/index.php';
<ide> $endsWithLength = strlen($endsWithIndex);
<del> if (strlen($path) >= $endsWithLength &&
<add> if (
<add> strlen($path) >= $endsWithLength &&
<ide> substr($path, -$endsWithLength) === $endsWithIndex
<ide> ) {
<ide> $path = '/';
<ide><path>src/Log/Engine/FileLog.php
<ide> public function __construct(array $config = [])
<ide> if (!empty($this->_config['path'])) {
<ide> $this->_path = $this->_config['path'];
<ide> }
<del> if ($this->_path !== null &&
<add> if (
<add> $this->_path !== null &&
<ide> Configure::read('debug') &&
<ide> !is_dir($this->_path)
<ide> ) {
<ide> protected function _rotateFile($filename)
<ide> $filePath = $this->_path . $filename;
<ide> clearstatcache(true, $filePath);
<ide>
<del> if (!file_exists($filePath) ||
<add> if (
<add> !file_exists($filePath) ||
<ide> filesize($filePath) < $this->_size
<ide> ) {
<ide> return null;
<ide><path>src/Mailer/Email.php
<ide> protected function _checkViewVars(&$item, $key)
<ide> $item = (string)$item;
<ide> }
<ide>
<del> if (is_resource($item) ||
<add> if (
<add> is_resource($item) ||
<ide> $item instanceof Closure ||
<ide> $item instanceof PDO
<ide> ) {
<ide><path>src/ORM/Association.php
<ide> public function cascadeCallbacks($cascadeCallbacks = null)
<ide> */
<ide> public function setClassName($className)
<ide> {
<del> if ($this->_targetTable !== null &&
<add> if (
<add> $this->_targetTable !== null &&
<ide> get_class($this->_targetTable) !== App::className($className, 'Model/Table', 'Table')
<ide> ) {
<ide> throw new InvalidArgumentException(
<ide><path>src/ORM/Association/HasMany.php
<ide> public function saveAssociated(EntityInterface $entity, array $options = [])
<ide>
<ide> $isEmpty = in_array($targetEntities, [null, [], '', false], true);
<ide> if ($isEmpty) {
<del> if ($entity->isNew() ||
<add> if (
<add> $entity->isNew() ||
<ide> $this->getSaveStrategy() !== self::SAVE_REPLACE
<ide> ) {
<ide> return $entity;
<ide> public function saveAssociated(EntityInterface $entity, array $options = [])
<ide> $targetEntities = [];
<ide> }
<ide>
<del> if (!is_array($targetEntities) &&
<add> if (
<add> !is_array($targetEntities) &&
<ide> !($targetEntities instanceof Traversable)
<ide> ) {
<ide> $name = $this->getProperty();
<ide> public function saveAssociated(EntityInterface $entity, array $options = [])
<ide>
<ide> $options['_sourceTable'] = $this->getSource();
<ide>
<del> if ($this->_saveStrategy === self::SAVE_REPLACE &&
<add> if (
<add> $this->_saveStrategy === self::SAVE_REPLACE &&
<ide> !$this->_unlinkAssociated($foreignKeyReference, $entity, $this->getTarget(), $targetEntities, $options)
<ide> ) {
<ide> return false;
<ide><path>src/ORM/Behavior.php
<ide> protected function _reflectionCache()
<ide>
<ide> foreach ($reflection->getMethods(ReflectionMethod::IS_PUBLIC) as $method) {
<ide> $methodName = $method->getName();
<del> if (in_array($methodName, $baseMethods, true) ||
<add> if (
<add> in_array($methodName, $baseMethods, true) ||
<ide> isset($eventMethods[$methodName])
<ide> ) {
<ide> continue;
<ide><path>src/ORM/Behavior/CounterCacheBehavior.php
<ide> public function beforeSave(Event $event, EntityInterface $entity, $options)
<ide> $registryAlias = $assoc->getTarget()->getRegistryAlias();
<ide> $entityAlias = $assoc->getProperty();
<ide>
<del> if (!is_callable($config) &&
<add> if (
<add> !is_callable($config) &&
<ide> isset($config['ignoreDirty']) &&
<ide> $config['ignoreDirty'] === true &&
<ide> $entity->$entityAlias->isDirty($field)
<ide> protected function _processAssociation(Event $event, EntityInterface $entity, As
<ide> $config = [];
<ide> }
<ide>
<del> if (isset($this->_ignoreDirty[$assoc->getTarget()->getRegistryAlias()][$field]) &&
<add> if (
<add> isset($this->_ignoreDirty[$assoc->getTarget()->getRegistryAlias()][$field]) &&
<ide> $this->_ignoreDirty[$assoc->getTarget()->getRegistryAlias()][$field] === true
<ide> ) {
<ide> continue;
<ide><path>src/ORM/Behavior/TimestampBehavior.php
<ide> public function handleEvent(Event $event, EntityInterface $entity)
<ide> sprintf('When should be one of "always", "new" or "existing". The passed value "%s" is invalid', $when)
<ide> );
<ide> }
<del> if ($when === 'always' ||
<add> if (
<add> $when === 'always' ||
<ide> ($when === 'new' && $new) ||
<ide> ($when === 'existing' && !$new)
<ide> ) {
<ide><path>src/ORM/Behavior/TranslateBehavior.php
<ide> public function beforeFind(Event $event, Query $query, $options)
<ide> $q->where([$q->getRepository()->aliasField('locale') => $locale]);
<ide>
<ide> /** @var \Cake\ORM\Query $query */
<del> if ($query->isAutoFieldsEnabled() ||
<add> if (
<add> $query->isAutoFieldsEnabled() ||
<ide> in_array($field, $select, true) ||
<ide> in_array($this->_table->aliasField($field), $select, true)
<ide> ) {
<ide><path>src/ORM/EagerLoader.php
<ide> protected function _normalizeContain(Table $parent, $alias, $options, $paths)
<ide> $paths += ['aliasPath' => '', 'propertyPath' => '', 'root' => $alias];
<ide> $paths['aliasPath'] .= '.' . $alias;
<ide>
<del> if (isset($options['matching']) &&
<del> $options['matching'] === true
<add> if (
<add> isset($options['matching']) &&
<add> $options['matching'] === true
<ide> ) {
<ide> $paths['propertyPath'] = '_matchingData.' . $alias;
<ide> } else {
<ide><path>src/ORM/Marshaller.php
<ide> public function merge(EntityInterface $entity, array $data, array $options = [])
<ide> // change. Arrays will always be marked as dirty because
<ide> // the original/updated list could contain references to the
<ide> // same objects, even though those objects may have changed internally.
<del> if ((is_scalar($value) && $original === $value) ||
<add> if (
<add> (is_scalar($value) && $original === $value) ||
<ide> ($value === null && $original === $value) ||
<ide> (is_object($value) && !($value instanceof EntityInterface) && $original == $value)
<ide> ) {
<ide><path>src/ORM/Table.php
<ide> public function findList(Query $query, array $options)
<ide> deprecationWarning('Option "idField" is deprecated, use "keyField" instead.');
<ide> }
<ide>
<del> if (!$query->clause('select') &&
<add> if (
<add> !$query->clause('select') &&
<ide> !is_object($options['keyField']) &&
<ide> !is_object($options['valueField']) &&
<ide> !is_object($options['groupField'])
<ide><path>src/Routing/Route/Route.php
<ide> public function getName()
<ide> ];
<ide> foreach ($keys as $key => $glue) {
<ide> $value = null;
<del> if (strpos($this->template, ':' . $key) !== false
<add> if (
<add> strpos($this->template, ':' . $key) !== false
<ide> || strpos($this->template, '{' . $key . '}') !== false
<ide> ) {
<ide> $value = '_' . $key;
<ide> public function match(array $url, array $context = [])
<ide> $defaults = $this->defaults;
<ide> $context += ['params' => [], '_port' => null, '_scheme' => null, '_host' => null];
<ide>
<del> if (!empty($this->options['persist']) &&
<add> if (
<add> !empty($this->options['persist']) &&
<ide> is_array($this->options['persist'])
<ide> ) {
<ide> $url = $this->_persistParams($url, $context['params']);
<ide> public function match(array $url, array $context = [])
<ide>
<ide> // Check for properties that will cause an
<ide> // absolute url. Copy the other properties over.
<del> if (isset($hostOptions['_scheme']) ||
<add> if (
<add> isset($hostOptions['_scheme']) ||
<ide> isset($hostOptions['_port']) ||
<ide> isset($hostOptions['_host'])
<ide> ) {
<ide> protected function _writeUrl($params, $pass = [], $query = [])
<ide> }
<ide>
<ide> $out = str_replace('//', '/', $out);
<del> if (isset($params['_scheme']) ||
<add> if (
<add> isset($params['_scheme']) ||
<ide> isset($params['_host']) ||
<ide> isset($params['_port'])
<ide> ) {
<ide><path>src/Routing/Router.php
<ide> public static function url($url = null, $full = false)
<ide>
<ide> if (!isset($url['_name'])) {
<ide> // Copy the current action if the controller is the current one.
<del> if (empty($url['action']) &&
<add> if (
<add> empty($url['action']) &&
<ide> (empty($url['controller']) || $params['controller'] === $url['controller'])
<ide> ) {
<ide> $url['action'] = $params['action'];
<ide><path>src/Shell/Task/AssetsTask.php
<ide> protected function _process($plugins, $copy = false, $overwrite = false)
<ide> $this->out('For plugin: ' . $plugin);
<ide> $this->hr();
<ide>
<del> if ($config['namespaced'] &&
<add> if (
<add> $config['namespaced'] &&
<ide> !is_dir($config['destDir']) &&
<ide> !$this->_createDirectory($config['destDir'])
<ide> ) {
<ide><path>src/Shell/Task/CommandTask.php
<ide> public function commands()
<ide> foreach ($shellList as $type => $commands) {
<ide> foreach ($commands as $shell) {
<ide> $prefix = '';
<del> if (!in_array(strtolower($type), ['app', 'core']) &&
<add> if (
<add> !in_array(strtolower($type), ['app', 'core']) &&
<ide> isset($duplicates[$type]) &&
<ide> in_array($shell, $duplicates[$type])
<ide> ) {
<ide><path>src/TestSuite/Constraint/Email/MailSentWith.php
<ide> public function matches($other)
<ide> $emails = $this->getEmails();
<ide> foreach ($emails as $email) {
<ide> $value = $email->{'get' . ucfirst($this->method)}();
<del> if (in_array($this->method, ['to', 'cc', 'bcc', 'from'])
<add> if (
<add> in_array($this->method, ['to', 'cc', 'bcc', 'from'])
<ide> && array_key_exists($other, $value)
<ide> ) {
<ide> return true;
<ide><path>src/Utility/Hash.php
<ide> public static function extract($data, $path)
<ide> if ($conditions) {
<ide> $filter = [];
<ide> foreach ($next as $item) {
<del> if ((is_array($item) || $item instanceof ArrayAccess) &&
<add> if (
<add> (is_array($item) || $item instanceof ArrayAccess) &&
<ide> static::_matches($item, $conditions)
<ide> ) {
<ide> $filter[] = $item;
<ide> protected static function _matches($data, $selector)
<ide> if (!preg_match($val, $prop)) {
<ide> return false;
<ide> }
<del> } elseif (($op === '=' && $prop != $val) ||
<add> } elseif (
<add> ($op === '=' && $prop != $val) ||
<ide> ($op === '!=' && $prop == $val) ||
<ide> ($op === '>' && $prop <= $val) ||
<ide> ($op === '<' && $prop >= $val) ||
<ide><path>src/Utility/MergeVariablesTrait.php
<ide> protected function _mergeProperty($property, $parentClasses, $options)
<ide> {
<ide> $thisValue = $this->{$property};
<ide> $isAssoc = false;
<del> if (isset($options['associative']) &&
<add> if (
<add> isset($options['associative']) &&
<ide> in_array($property, (array)$options['associative'])
<ide> ) {
<ide> $isAssoc = true;
<ide><path>src/Utility/Text.php
<ide> protected static function _substr($text, $start, $length, array $options)
<ide>
<ide> $len = self::_strlen($part, $options);
<ide> if ($offset !== 0 || $totalLength + $len > $length) {
<del> if (strpos($part, '&') === 0 && preg_match($pattern, $part)
<add> if (
<add> strpos($part, '&') === 0 && preg_match($pattern, $part)
<ide> && $part !== html_entity_decode($part, ENT_HTML5 | ENT_QUOTES, 'UTF-8')
<ide> ) {
<ide> // Entities cannot be passed substr.
<ide><path>src/Validation/Validation.php
<ide> public static function iban($check)
<ide> protected static function _getDateString($value)
<ide> {
<ide> $formatted = '';
<del> if (isset($value['year'], $value['month'], $value['day']) &&
<add> if (
<add> isset($value['year'], $value['month'], $value['day']) &&
<ide> (is_numeric($value['year']) && is_numeric($value['month']) && is_numeric($value['day']))
<ide> ) {
<ide> $formatted .= sprintf('%d-%02d-%02d ', $value['year'], $value['month'], $value['day']);
<ide><path>src/Validation/Validator.php
<ide> public function allowEmptyFor($field, $flags, $when = true, $message = null)
<ide> protected function sortMessageAndWhen($first, $second, $method)
<ide> {
<ide> // Called with `$message, $when`. No order change necessary
<del> if ((
<add> if (
<add> (
<ide> in_array($second, [true, false, 'create', 'update'], true) ||
<ide> is_callable($second)
<ide> ) && (
<ide> protected function isEmpty($data, $flags)
<ide> }
<ide>
<ide> if (is_array($data)) {
<del> if (($flags & self::EMPTY_FILE)
<add> if (
<add> ($flags & self::EMPTY_FILE)
<ide> && isset($data['name'], $data['type'], $data['tmp_name'], $data['error'])
<ide> && (int)$data['error'] === UPLOAD_ERR_NO_FILE
<ide> ) {
<ide><path>src/View/Form/ArrayContext.php
<ide> public function __construct(ServerRequest $request, array $context)
<ide> */
<ide> public function primaryKey()
<ide> {
<del> if (empty($this->_context['schema']['_constraints']) ||
<add> if (
<add> empty($this->_context['schema']['_constraints']) ||
<ide> !is_array($this->_context['schema']['_constraints'])
<ide> ) {
<ide> return [];
<ide><path>src/View/Form/EntityContext.php
<ide> public function val($field, $options = [])
<ide> if ($val !== null) {
<ide> return $val;
<ide> }
<del> if ($options['default'] !== null
<add> if (
<add> $options['default'] !== null
<ide> || !$options['schemaDefault']
<ide> || !$entity->isNew()
<ide> ) {
<ide><path>src/View/Helper/FormHelper.php
<ide> protected function _formUrl($context, $options)
<ide> return $request->getRequestTarget();
<ide> }
<ide>
<del> if (is_string($options['url']) ||
<add> if (
<add> is_string($options['url']) ||
<ide> (is_array($options['url']) && isset($options['url']['_name']))
<ide> ) {
<ide> return $options['url'];
<ide> protected function _magicOptions($fieldName, $options, $allowOverride)
<ide> }
<ide>
<ide> $typesWithMaxLength = ['text', 'textarea', 'email', 'tel', 'url', 'search'];
<del> if (!array_key_exists('maxlength', $options)
<add> if (
<add> !array_key_exists('maxlength', $options)
<ide> && in_array($options['type'], $typesWithMaxLength)
<ide> ) {
<ide> $maxLength = null;
<ide> public function select($fieldName, $options = [], array $attributes = [])
<ide>
<ide> // Secure the field if there are options, or it's a multi select.
<ide> // Single selects with no options don't submit, but multiselects do.
<del> if ($attributes['secure'] &&
<add> if (
<add> $attributes['secure'] &&
<ide> empty($options) &&
<ide> empty($attributes['empty']) &&
<ide> empty($attributes['multiple'])
<ide><path>src/View/Helper/PaginatorHelper.php
<ide> public function generateUrlParams(array $options = [], $model = null)
<ide> $url['page'] = false;
<ide> }
<ide>
<del> if (isset($paging['sortDefault'], $paging['directionDefault'], $url['sort'], $url['direction']) &&
<add> if (
<add> isset($paging['sortDefault'], $paging['directionDefault'], $url['sort'], $url['direction']) &&
<ide> $url['sort'] === $paging['sortDefault'] &&
<ide> strtolower($url['direction']) === strtolower($paging['directionDefault'])
<ide> ) {
<ide><path>src/View/Helper/UrlHelper.php
<ide> public function assetUrl($path, array $options = [])
<ide> if (!empty($options['pathPrefix']) && $path[0] !== '/') {
<ide> $path = $options['pathPrefix'] . $path;
<ide> }
<del> if (!empty($options['ext']) &&
<add> if (
<add> !empty($options['ext']) &&
<ide> strpos($path, '?') === false &&
<ide> substr($path, -strlen($options['ext'])) !== $options['ext']
<ide> ) {
<ide><path>src/View/Widget/RadioWidget.php
<ide> protected function _renderInput($val, $text, $data, $context)
<ide> $escape
<ide> );
<ide>
<del> if ($label === false &&
<add> if (
<add> $label === false &&
<ide> strpos($this->_templates->get('radioWrapper'), '{{input}}') === false
<ide> ) {
<ide> $label = $input;
<ide><path>src/View/Widget/SelectBoxWidget.php
<ide> protected function _renderOptions($options, $disabled, $selected, $templateVars,
<ide> foreach ($options as $key => $val) {
<ide> // Option groups
<ide> $arrayVal = (is_array($val) || $val instanceof Traversable);
<del> if ((!is_int($key) && $arrayVal) ||
<add> if (
<add> (!is_int($key) && $arrayVal) ||
<ide> (is_int($key) && $arrayVal && (isset($val['options']) || !isset($val['value'])))
<ide> ) {
<ide> $out[] = $this->_renderOptgroup($key, $val, $disabled, $selected, $templateVars, $escape);
<ide><path>src/View/Widget/WidgetLocator.php
<ide> public function load($file)
<ide> public function add(array $widgets)
<ide> {
<ide> foreach ($widgets as $object) {
<del> if (is_object($object) &&
<add> if (
<add> is_object($object) &&
<ide> !($object instanceof WidgetInterface)
<ide> ) {
<ide> throw new RuntimeException(
<ide><path>tests/PHPStan/AssociationTableMixinClassReflectionExtension.php
<del><?php declare(strict_types = 1);
<add><?php
<add>declare(strict_types=1);
<ide>
<ide> namespace Cake\PHPStan;
<ide>
<ide><path>tests/PHPStan/TableFindByPropertyMethodReflection.php
<del><?php declare(strict_types = 1);
<add><?php
<add>declare(strict_types=1);
<ide>
<ide> namespace Cake\PHPStan;
<ide>
<ide><path>tests/TestCase/Core/InstanceConfigTraitTest.php
<ide> */
<ide> class TestInstanceConfig
<ide> {
<del>
<ide> use InstanceConfigTrait;
<ide>
<ide> /**
<ide> class TestInstanceConfig
<ide> */
<ide> class ReadOnlyTestInstanceConfig
<ide> {
<del>
<ide> use InstanceConfigTrait;
<ide>
<ide> /**
<ide><path>tests/TestCase/Core/StaticConfigTraitTest.php
<ide> */
<ide> class TestCacheStaticConfig
<ide> {
<del>
<ide> use StaticConfigTrait;
<ide>
<ide> /**
<ide> class TestCacheStaticConfig
<ide> */
<ide> class TestEmailStaticConfig
<ide> {
<del>
<ide> use StaticConfigTrait;
<ide>
<ide> /**
<ide> class TestEmailStaticConfig
<ide> */
<ide> class TestLogStaticConfig
<ide> {
<del>
<ide> use StaticConfigTrait;
<ide>
<ide> /**
<ide><path>tests/TestCase/Database/Schema/SqliteSchemaTest.php
<ide> protected function _createTables($connection)
<ide>
<ide> $schema = new SchemaCollection($connection);
<ide> $result = $schema->listTables();
<del> if (in_array('schema_articles', $result) &&
<add> if (
<add> in_array('schema_articles', $result) &&
<ide> in_array('schema_authors', $result)
<ide> ) {
<ide> return;
<ide><path>tests/TestCase/Datasource/ModelAwareTraitTest.php
<ide> */
<ide> class Stub
<ide> {
<del>
<ide> use ModelAwareTrait;
<ide>
<ide> public function setProps($name)
<ide><path>tests/TestCase/Filesystem/FileTest.php
<ide> public function testBasic()
<ide> 'filesize' => filesize($file),
<ide> 'mime' => 'text/plain',
<ide> ];
<del> if (!function_exists('finfo_open') &&
<add> if (
<add> !function_exists('finfo_open') &&
<ide> (!function_exists('mime_content_type') ||
<ide> function_exists('mime_content_type') &&
<ide> mime_content_type($this->File->pwd()) === false)
<ide><path>tests/TestCase/Mailer/MailerAwareTraitTest.php
<ide> */
<ide> class Stub
<ide> {
<del>
<ide> use MailerAwareTrait {
<ide> getMailer as public;
<ide> }
<ide><path>tests/TestCase/ORM/Behavior/BehaviorRegressionTest.php
<ide> */
<ide> class NumberTree extends Entity
<ide> {
<del>
<ide> use TranslateTrait;
<ide> }
<ide>
<ide><path>tests/TestCase/ORM/Behavior/TranslateBehaviorTest.php
<ide> */
<ide> class Article extends Entity
<ide> {
<del>
<ide> use TranslateTrait;
<ide> }
<ide>
<ide><path>tests/TestCase/TestSuite/EmailAssertTraitTest.php
<ide>
<ide> class EmailAssertTraitTest extends TestCase
<ide> {
<del>
<ide> use EmailAssertTrait;
<ide>
<ide> public function setUp()
<ide><path>tests/TestCase/Utility/MergeVariablesTraitTest.php
<ide>
<ide> class Base
<ide> {
<del>
<ide> use MergeVariablesTrait;
<ide>
<ide> public $hasBoolean = false;
<ide><path>tests/TestCase/View/StringTemplateTraitTest.php
<ide> */
<ide> class TestStringTemplate
<ide> {
<del>
<ide> use InstanceConfigTrait;
<ide> use StringTemplateTrait;
<ide>
<ide><path>tests/test_app/TestApp/Model/Entity/NonExtending.php
<ide> */
<ide> class NonExtending implements EntityInterface
<ide> {
<del>
<ide> use EntityTrait;
<ide>
<ide> public function __construct(array $properties = [], array $options = []) | 73 |
Python | Python | use x.any() instead of any(x) | 3937248fc8dd0ccfb3fde2a626a622ecb2d1ccb4 | <ide><path>numpy/lib/function_base.py
<ide> import types
<ide> import numpy.core.numeric as _nx
<ide> from numpy.core.numeric import ones, zeros, arange, concatenate, array, \
<del> asarray, asanyarray, empty, empty_like, asanyarray, ndarray, around
<add> asarray, asanyarray, empty, empty_like, ndarray, around
<ide> from numpy.core.numeric import ScalarType, dot, where, newaxis, intp, \
<ide> integer, isscalar
<ide> from numpy.core.umath import pi, multiply, add, arctan2, \
<ide> def histogram(a, bins=10, range=None, normed=False):
<ide> bins = linspace(mn, mx, bins, endpoint=False)
<ide> else:
<ide> bins = asarray(bins)
<del> if(any(bins[1:]-bins[:-1] < 0)):
<add> if (bins[1:]-bins[:-1] < 0).any():
<ide> raise AttributeError, 'bins must increase monotonically.'
<ide>
<ide> # best block size probably depends on processor cache size | 1 |
Javascript | Javascript | remove unneeded code | f5652f19c4efcbe183c8cd2dd774669ee5e9ea12 | <ide><path>lib/hmr/lazyCompilationBackend.js
<ide> module.exports = (compiler, client, callback) => {
<ide> const activeModules = new Map();
<ide> const prefix = "/lazy-compilation-using-";
<ide>
<del> if (!client) {
<del> client = `webpack/hot/lazy-compilation-${
<del> compiler.options.externalsPresets.node ? "node" : "web"
<del> }.js`;
<del> }
<del>
<ide> const server = http.createServer((req, res) => {
<ide> const keys = req.url.slice(prefix.length).split("@");
<ide> req.socket.on("close", () => { | 1 |
Ruby | Ruby | remove more integration tests | ec83d1decb7cf7166ccf0021f998503975a845f3 | <ide><path>Library/Homebrew/test/test_uninstall.rb
<ide> def test_check_for_dependents_when_ignore_dependencies
<ide> end
<ide>
<ide> class IntegrationCommandTestUninstall < IntegrationCommandTestCase
<del> def setup
<del> super
<del> @f1_path = setup_test_formula "testball_f1", <<-CONTENT
<del> def install
<del> FileUtils.touch prefix/touch("hello")
<del> end
<del> CONTENT
<del> @f2_path = setup_test_formula "testball_f2", <<-CONTENT
<del> depends_on "testball_f1"
<del>
<del> def install
<del> FileUtils.touch prefix/touch("hello")
<del> end
<del> CONTENT
<del> end
<del>
<del> def f1
<del> Formulary.factory(@f1_path)
<del> end
<del>
<del> def f2
<del> Formulary.factory(@f2_path)
<del> end
<del>
<ide> def test_uninstall
<del> cmd("install", "testball_f2")
<del> run_as_not_developer do
<del> assert_match "Refusing to uninstall",
<del> cmd_fail("uninstall", "testball_f1")
<del> refute_empty f1.installed_kegs
<del>
<del> assert_match "Uninstalling #{f2.rack}",
<del> cmd("uninstall", "testball_f2")
<del> assert_empty f2.installed_kegs
<del>
<del> assert_match "Uninstalling #{f1.rack}",
<del> cmd("uninstall", "testball_f1")
<del> assert_empty f1.installed_kegs
<del> end
<add> cmd("install", testball)
<add> assert_match "Uninstalling testball", cmd("uninstall", "--force", testball)
<ide> end
<ide> end | 1 |
Text | Text | use new panel classes | d914ae2a62351d4046b9e166db61c461a23679bb | <ide><path>docs/upgrading/upgrading-your-ui-theme.md
<ide> Old Selector | New Selector
<ide> `.pane-container` | `atom-pane-conatiner`
<ide> `.pane` | `atom-pane`
<ide> `.tool-panel` | `atom-panel`
<del>`.panel-top` | `atom-panel[location="top"]`
<del>`.panel-bottom` | `atom-panel[location="bottom"]`
<del>`.panel-left` | `atom-panel[location="left"]`
<del>`.panel-right` | `atom-panel[location="right"]`
<del>`.overlay` | `atom-panel[location="modal"]`
<add>`.panel-top` | `atom-panel.top`
<add>`.panel-bottom` | `atom-panel.bottom`
<add>`.panel-left` | `atom-panel.left`
<add>`.panel-right` | `atom-panel.right`
<add>`.overlay` | `atom-panel.modal`
<ide>
<ide> ## Supporting the Shadow DOM
<ide> | 1 |
Javascript | Javascript | handle some illegal characters in hex string | eb8f4e83434b20644aea30bff9755b29199c29b5 | <ide><path>src/parser.js
<ide> var Lexer = (function LexerClosure() {
<ide> getHexString: function Lexer_getHexString(ch) {
<ide> var str = '';
<ide> var stream = this.stream;
<del> for (;;) {
<add> var isFirstHex = true;
<add> var firstDigit;
<add> var secondDigit;
<add> while (true) {
<ide> ch = stream.getChar();
<del> if (ch == '>') {
<del> break;
<del> }
<ide> if (!ch) {
<ide> warn('Unterminated hex string');
<ide> break;
<del> }
<del> if (specialChars[ch.charCodeAt(0)] != 1) {
<del> var x, x2;
<del> if ((x = toHexDigit(ch)) == -1)
<del> error('Illegal character in hex string: ' + ch);
<del>
<del> ch = stream.getChar();
<del> while (specialChars[ch.charCodeAt(0)] == 1)
<del> ch = stream.getChar();
<del>
<del> if ((x2 = toHexDigit(ch)) == -1)
<del> error('Illegal character in hex string: ' + ch);
<del>
<del> str += String.fromCharCode((x << 4) | x2);
<add> } else if (ch === '>') {
<add> break;
<add> } else if (specialChars[ch.charCodeAt(0)] === 1) {
<add> continue;
<add> } else {
<add> if (isFirstHex) {
<add> firstDigit = toHexDigit(ch);
<add> if (firstDigit === -1) {
<add> warn("Ignoring invalid character '" + ch + "' in hex string");
<add> continue;
<add> }
<add> } else {
<add> secondDigit = toHexDigit(ch);
<add> if (secondDigit === -1) {
<add> warn("Ignoring invalid character '" + ch + "' in hex string");
<add> continue;
<add> }
<add> str += String.fromCharCode((firstDigit << 4) | secondDigit);
<add> }
<add> isFirstHex = !isFirstHex;
<ide> }
<ide> }
<ide> return str;
<ide><path>test/unit/parser_spec.js
<ide> describe('parser', function() {
<ide>
<ide> expect(result).toEqual(11.234);
<ide> });
<add>
<add> it('should not throw exception on bad input', function() {
<add> // '8 0 2 15 5 2 2 2 4 3 2 4'
<add> // should be parsed as
<add> // '80 21 55 22 24 32'
<add> var input = new StringStream('7 0 2 15 5 2 2 2 4 3 2 4>');
<add> var lexer = new Lexer(input);
<add> var result = lexer.getHexString('<');
<add>
<add> expect(result).toEqual('p!U"$2');
<add> });
<ide> });
<ide> });
<ide> | 2 |
PHP | PHP | fix typo in description | 98c9aa3be17ed82c3405d2c2843c16942d40f676 | <ide><path>src/I18n/Number.php
<ide> public static function defaultCurrency($currency = null)
<ide> if ($currency === false) {
<ide> static::setDefaultCurrency(null);
<ide>
<del> // This doesn't sem like a useful result to return, but it's what the old version did.
<add> // This doesn't seem like a useful result to return, but it's what the old version did.
<ide> // Retaining it for backward compatibility.
<ide> return null;
<ide> } elseif ($currency !== null) { | 1 |
Python | Python | fix np.ma.median with only one non-masked value | ed300480512029be7fbd031251a280964341acfe | <ide><path>numpy/ma/extras.py
<ide> def _median(a, axis=None, out=None, overwrite_input=False):
<ide> ind = np.meshgrid(*axes_grid, sparse=True, indexing='ij')
<ide>
<ide> # insert indices of low and high median
<del> ind.insert(axis, h - 1)
<add> ind.insert(axis, np.maximum(0, h - 1))
<ide> low = asorted[tuple(ind)]
<del> low._sharedmask = False
<ide> ind[axis] = h
<ide> high = asorted[tuple(ind)]
<ide>
<ide><path>numpy/ma/tests/test_extras.py
<ide> def test_out(self):
<ide> assert_equal(r, out)
<ide> assert_(type(r) == MaskedArray)
<ide>
<add> def test_single_non_masked_value_on_axis(self):
<add> data = [[1., 0.],
<add> [0., 3.],
<add> [0., 0.]]
<add> masked_arr = np.ma.masked_equal(data, 0)
<add> expected = [1., 3.]
<add> assert_array_equal(np.ma.median(masked_arr, axis=0),
<add> expected)
<add>
<ide>
<ide> class TestCov(TestCase):
<ide> | 2 |
Text | Text | remove outdated s_client information in tls.md | 5cb196441a6df0fc3fa62e042ce108347f49814c | <ide><path>doc/api/tls.md
<ide> threshold is exceeded. The limits are configurable:
<ide> The default renegotiation limits should not be modified without a full
<ide> understanding of the implications and risks.
<ide>
<del>To test the renegotiation limits on a server, connect to it using the OpenSSL
<del>command-line client (`openssl s_client -connect address:port`) then input
<del>`R<CR>` (i.e., the letter `R` followed by a carriage return) multiple times.
<del>
<ide> ### Session Resumption
<ide>
<ide> Establishing a TLS session can be relatively slow. The process can be sped | 1 |
Text | Text | fix text to follow portuguese language syntax | 083e9d0b6de4c17b2780ee5c4a505eb18f726691 | <ide><path>curriculum/challenges/portuguese/01-responsive-web-design/css-flexbox/use-the-order-property-to-rearrange-items.portuguese.md
<ide> localeTitle: ''
<ide> <section id="description"> A propriedade <code>order</code> é usada para informar ao CSS a ordem de como os itens flexíveis aparecem no contêiner flexível. Por padrão, os itens aparecerão na mesma ordem em que aparecem no HTML de origem. A propriedade aceita números como valores e números negativos podem ser usados. </section>
<ide>
<ide> ## Instructions
<del><section id="instructions"> Adicione o <code>order</code> propriedade CSS aos dois <code>#box-1</code> e <code>#box-2</code> . Dê <code>#box-1</code> um valor de 2 e dê <code>#box-2</code> um valor de 1. </section>
<add><section id="instructions"> Adicione a propriedade CSS <code>order</code> a ambos <code>#box-1</code> e <code>#box-2</code> . Dê a <code>#box-1</code> um valor de 2 e dê a <code>#box-2</code> um valor de 1. </section>
<ide>
<ide> ## Tests
<ide> <section id='tests'> | 1 |
Text | Text | add changelog for | 3a6770fb512572bec904c0d710dc3d0954edcafa | <ide><path>activerecord/CHANGELOG.md
<add>* Don't allow mutations on the datbase configurations hash.
<add>
<add> Freeze the configurations hash to disallow directly changing the configurations hash. If applications need to change the hash, for example to create adatabases for parallelization, they should use the `DatabaseConfig` object directly.
<add>
<add> Before:
<add>
<add> ```ruby
<add> @db_config = ActiveRecord::Base.configurations.configs_for(env_name: "test", spec_name: "primary")
<add> @db_config.configuration_hash.merge!(idle_timeout: "0.02")
<add> ```
<add>
<add> After:
<add>
<add> ```ruby
<add> @db_config = ActiveRecord::Base.configurations.configs_for(env_name: "test", spec_name: "primary")
<add> config = @db_config.configuration_hash.merge(idle_timeout: "0.02")
<add> db_config = ActiveRecord::DatabaseConfigurations::HashConfig.new(@db_config.env_name, @db_config.spec_name, config)
<add> ```
<add>
<add> *Eileen M. Uchitelle*, *John Crepezzi*
<add>
<ide> * Remove `:connection_id` from the `sql.active_record` notification.
<ide>
<ide> *Aaron Patterson*, *Rafael Mendonça França* | 1 |
Javascript | Javascript | add modulefederationplugin and full test case | faa7dda8cd816cb30e25a439ac6a208a7ba2034f | <ide><path>lib/container/ModuleFederationPlugin.js
<add>/*
<add> MIT License http://www.opensource.org/licenses/mit-license.php
<add> Author Tobias Koppers @sokra and Zackary Jackson @ScriptedAlchemy
<add>*/
<add>
<add>"use strict";
<add>
<add>const ContainerPlugin = require("./ContainerPlugin");
<add>const ContainerReferencePlugin = require("./ContainerReferencePlugin");
<add>
<add>/** @typedef {import("../Compiler")} Compiler */
<add>
<add>class ModuleFederationPlugin {
<add> constructor(options) {
<add> // TODO options validation
<add> this.options = options;
<add> }
<add>
<add> /**
<add> * @param {Compiler} compiler webpack compiler
<add> * @returns {void}
<add> */
<add> apply(compiler) {
<add> const { options } = this;
<add> new ContainerPlugin({
<add> name: options.name,
<add> library: options.library,
<add> filename: options.filename,
<add> exposes: options.exposes,
<add> overridables: options.shared
<add> }).apply(compiler);
<add> new ContainerReferencePlugin({
<add> remoteType: options.remoteType || options.library.type,
<add> remotes: options.remotes,
<add> overrides: options.shared
<add> }).apply(compiler);
<add> }
<add>}
<add>
<add>module.exports = ModuleFederationPlugin;
<ide><path>test/configCases/container/0-container-full/App.js
<add>import React from "react";
<add>import ComponentA from "containerA/ComponentA";
<add>
<add>export default () => {
<add> return `App rendered with [${React()}] and [${ComponentA()}]`;
<add>};
<ide><path>test/configCases/container/0-container-full/ComponentA.js
<add>import React from "react";
<add>
<add>export default () => {
<add> return `ComponentA rendered with [${React()}]`;
<add>};
<ide><path>test/configCases/container/0-container-full/index.js
<add>it("should load the component from container", () => {
<add> return import("./App").then(({ default: App }) => {
<add> const rendered = App();
<add> expect(rendered).toBe(
<add> "App rendered with [This is react 0.1.2] and [ComponentA rendered with [This is react 0.1.2]]"
<add> );
<add> return import("./upgrade-react").then(({ default: upgrade }) => {
<add> upgrade();
<add> const rendered = App();
<add> expect(rendered).toBe(
<add> "App rendered with [This is react 1.2.3] and [ComponentA rendered with [This is react 1.2.3]]"
<add> );
<add> });
<add> });
<add>});
<ide><path>test/configCases/container/0-container-full/node_modules/react.js
<add>let version = "0.1.2";
<add>export default () => `This is react ${version}`;
<add>export function setVersion(v) { version = v; }
<ide><path>test/configCases/container/0-container-full/upgrade-react.js
<add>import { setVersion } from "react";
<add>
<add>export default function upgrade() {
<add> setVersion("1.2.3");
<add>}
<ide><path>test/configCases/container/0-container-full/webpack.config.js
<add>const ModuleFederationPlugin = require("../../../../lib/container/ModuleFederationPlugin");
<add>
<add>module.exports = {
<add> plugins: [
<add> new ModuleFederationPlugin({
<add> name: "container",
<add> library: { type: "commonjs-module" },
<add> filename: "container.js",
<add> exposes: {
<add> ComponentA: "./ComponentA"
<add> },
<add> remotes: {
<add> containerA: "./container.js"
<add> },
<add> shared: ["react"]
<add> })
<add> ]
<add>};
<ide><path>test/configCases/container/1-container-full/App.js
<add>import React from "react";
<add>import ComponentA from "containerA/ComponentA";
<add>import ComponentB from "containerB/ComponentB";
<add>
<add>export default () => {
<add> return `App rendered with [${React()}] and [${ComponentA()}] and [${ComponentB()}]`;
<add>};
<ide><path>test/configCases/container/1-container-full/ComponentB.js
<add>import React from "react";
<add>
<add>export default () => {
<add> return `ComponentB rendered with [${React()}]`;
<add>};
<ide><path>test/configCases/container/1-container-full/index.js
<add>it("should load the component from container", () => {
<add> return import("./App").then(({ default: App }) => {
<add> const rendered = App();
<add> expect(rendered).toBe(
<add> "App rendered with [This is react 2.1.0] and [ComponentA rendered with [This is react 2.1.0]] and [ComponentB rendered with [This is react 2.1.0]]"
<add> );
<add> return import("./upgrade-react").then(({ default: upgrade }) => {
<add> upgrade();
<add> const rendered = App();
<add> expect(rendered).toBe(
<add> "App rendered with [This is react 3.2.1] and [ComponentA rendered with [This is react 3.2.1]] and [ComponentB rendered with [This is react 3.2.1]]"
<add> );
<add> });
<add> });
<add>});
<ide><path>test/configCases/container/1-container-full/node_modules/react.js
<add>let version = "2.1.0";
<add>export default () => `This is react ${version}`;
<add>export function setVersion(v) { version = v; }
<ide><path>test/configCases/container/1-container-full/upgrade-react.js
<add>import { setVersion } from "react";
<add>
<add>export default function upgrade() {
<add> setVersion("3.2.1");
<add>}
<ide><path>test/configCases/container/1-container-full/webpack.config.js
<add>const ModuleFederationPlugin = require("../../../../lib/container/ModuleFederationPlugin");
<add>
<add>module.exports = {
<add> plugins: [
<add> new ModuleFederationPlugin({
<add> name: "container",
<add> library: { type: "commonjs-module" },
<add> filename: "container.js",
<add> exposes: {
<add> ComponentB: "./ComponentB"
<add> },
<add> remotes: {
<add> containerA: "../0-container-full/container.js",
<add> containerB: "./container.js"
<add> },
<add> shared: ["react"]
<add> })
<add> ]
<add>}; | 13 |
Text | Text | fix entry for `napi_create_external_buffer` | cfa3d8fec5d9f6469c8d4ef077b53e0d9007dab9 | <ide><path>doc/api/n-api.md
<ide> napi_status napi_create_external_buffer(napi_env env,
<ide> * `[in] env`: The environment that the API is invoked under.
<ide> * `[in] length`: Size in bytes of the input buffer (should be the same as the
<ide> size of the new buffer).
<del>* `[in] data`: Raw pointer to the underlying buffer to copy from.
<add>* `[in] data`: Raw pointer to the underlying buffer to expose to JavaScript.
<ide> * `[in] finalize_cb`: Optional callback to call when the `ArrayBuffer` is being
<ide> collected. [`napi_finalize`][] provides more details.
<ide> * `[in] finalize_hint`: Optional hint to pass to the finalize callback during | 1 |
Javascript | Javascript | remove s/ss global flag | 38844ac5f6b2daaf652c93244693e46c194be812 | <ide><path>src/lib/duration/humanize.js
<ide> import { createDuration } from './create';
<ide>
<ide> var round = Math.round;
<del>var secondsThresholdChanged = false;
<ide> var thresholds = {
<ide> ss: 44, // a few seconds to seconds
<ide> s : 45, // seconds to minute
<ide> export function getSetRelativeTimeThreshold (threshold, limit) {
<ide> if (limit === undefined) {
<ide> return thresholds[threshold];
<ide> }
<del> if (threshold === 's' && !secondsThresholdChanged) {
<add> thresholds[threshold] = limit;
<add> if (threshold === 's') {
<ide> thresholds.ss = limit - 1;
<del> } else if (threshold === 'ss') {
<del> secondsThresholdChanged = true;
<ide> }
<del> thresholds[threshold] = limit;
<ide> return true;
<ide> }
<ide> | 1 |
Text | Text | fix typo in 4_0_release_notes.md | f51d95aee52d86b9d6bd8e1d10d35d73349bfc97 | <ide><path>guides/source/4_0_release_notes.md
<ide> Active Record
<ide>
<ide> * `mysql` and `mysql2` connections will set `SQL_MODE=STRICT_ALL_TABLES` by default to avoid silent data loss. This can be disabled by specifying `strict: false` in `config/database.yml`.
<ide>
<del>* Added default order to `ActiveRecord::Base#first` to assure consistent results among diferent database engines. Introduced `ActiveRecord::Base#take` as a replacement to the old behavior.
<add>* Added default order to `ActiveRecord::Base#first` to assure consistent results among different database engines. Introduced `ActiveRecord::Base#take` as a replacement to the old behavior.
<ide>
<ide> * Added an `:index` option to automatically create indexes for `references` and `belongs_to` statements in migrations. This can be either a boolean or a hash that is identical to options available to the `add_index` method:
<ide> | 1 |
Java | Java | remove duplication of optional api behavior | 94bbe08c83a381954cd46c88b0b73b75908b9ca0 | <ide><path>src/main/java/io/reactivex/observables/BlockingObservable.java
<ide> public Optional<T> firstOption() {
<ide> }
<ide>
<ide> public T first() {
<del> Optional<T> o = firstOption();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> throw new NoSuchElementException();
<add> return firstOption().get();
<ide> }
<ide>
<ide> public T first(T defaultValue) {
<del> Optional<T> o = firstOption();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> return defaultValue;
<add> return firstOption().orElse(defaultValue);
<ide> }
<ide>
<ide> public Optional<T> lastOption() {
<ide> return stream().reduce((a, b) -> b);
<ide> }
<ide>
<ide> public T last() {
<del> Optional<T> o = lastOption();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> throw new NoSuchElementException();
<add> return lastOption().get();
<ide> }
<ide>
<ide> public T last(T defaultValue) {
<del> Optional<T> o = lastOption();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> return defaultValue;
<add> return lastOption().orElse(defaultValue);
<ide> }
<ide>
<ide> public T single() {
<ide> Iterator<T> it = iterate(Observable.fromPublisher(o).single());
<ide> Optional<T> o = makeStream(it, false).findFirst();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> throw new NoSuchElementException();
<add> return o.get();
<ide> }
<ide>
<ide> public T single(T defaultValue) {
<ide> Iterator<T> it = iterate(Observable.<T>fromPublisher(o).single(defaultValue));
<ide> Optional<T> o = makeStream(it, false).findFirst();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> return defaultValue;
<add> return o.orElse(defaultValue);
<ide> }
<ide>
<ide> public Iterable<T> mostRecent(T initialValue) {
<ide><path>src/main/java/io/reactivex/observables/nbp/NbpBlockingObservable.java
<ide> public Optional<T> firstOption() {
<ide> }
<ide>
<ide> public T first() {
<del> Optional<T> o = firstOption();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> throw new NoSuchElementException();
<add> return firstOption().get();
<ide> }
<ide>
<ide> public T first(T defaultValue) {
<del> Optional<T> o = firstOption();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> return defaultValue;
<add> return firstOption().orElse(defaultValue);
<ide> }
<ide>
<ide> public Optional<T> lastOption() {
<ide> return stream().reduce((a, b) -> b);
<ide> }
<ide>
<ide> public T last() {
<del> Optional<T> o = lastOption();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> throw new NoSuchElementException();
<add> return lastOption().get();
<ide> }
<ide>
<ide> public T last(T defaultValue) {
<del> Optional<T> o = lastOption();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> return defaultValue;
<add> return lastOption().orElse(defaultValue);
<ide> }
<ide>
<ide> public T single() {
<ide> Iterator<T> it = iterate(o.single());
<ide> Optional<T> o = makeStream(it, false).findFirst();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> throw new NoSuchElementException();
<add> return o.get();
<ide> }
<ide>
<ide> public T single(T defaultValue) {
<ide> @SuppressWarnings("unchecked")
<ide> Iterator<T> it = iterate(((NbpObservable<T>)o).single(defaultValue));
<ide> Optional<T> o = makeStream(it, false).findFirst();
<del> if (o.isPresent()) {
<del> return o.get();
<del> }
<del> return defaultValue;
<add> return o.orElse(defaultValue);
<ide> }
<ide>
<ide> public Iterable<T> mostRecent(T initialValue) { | 2 |
PHP | PHP | add test for | 2fd4f87c1bc4bf84e2e75708b6eafafe2b1db442 | <ide><path>tests/TestCase/View/XmlViewTest.php
<ide> public function testRenderSerializeWithOptions()
<ide> $Response = new Response();
<ide> $Controller = new Controller($Request, $Response);
<ide> $data = [
<del> '_serialize' => ['tags'],
<add> '_serialize' => ['tags', 'nope'],
<ide> '_xmlOptions' => ['format' => 'attributes'],
<ide> 'tags' => [
<ide> 'tag' => [ | 1 |
Python | Python | build npymath lib | 67683ac66f5dac485a65c29446c912856a79b838 | <ide><path>numpy/core/setup.py
<ide> def generate_umath_c(ext,build_dir):
<ide> if sys.platform == 'cygwin':
<ide> config.add_data_dir('include/numpy/fenv')
<ide>
<add> config.add_extension('_sort',
<add> sources=[join('src','_sortmodule.c.src'),
<add> generate_config_h,
<add> generate_numpyconfig_h,
<add> generate_numpy_api,
<add> ],
<add> )
<add>
<add> # npymath needs the config.h and numpyconfig.h files to be generated, but
<add> # build_clib cannot handle generate_config_h and generate_numpyconfig_h
<add> # (don't ask). Because clib are generated before extensions, we have to
<add> # explicitely add an extension which has generate_config_h and
<add> # generate_numpyconfig_h as sources *before* adding npymath.
<add> config.add_library('npymath',
<add> sources=[join('src', 'npy_math.c.src')],
<add> depends=[])
<add>
<ide> config.add_extension('multiarray',
<ide> sources = [join('src','multiarraymodule.c'),
<ide> generate_config_h,
<ide> def generate_umath_c(ext,build_dir):
<ide> ]+deps,
<ide> )
<ide>
<del> config.add_extension('_sort',
<del> sources=[join('src','_sortmodule.c.src'),
<del> generate_config_h,
<del> generate_numpyconfig_h,
<del> generate_numpy_api,
<del> ],
<del> )
<del>
<ide> config.add_extension('scalarmath',
<ide> sources=[join('src','scalarmathmodule.c.src'),
<ide> generate_config_h, | 1 |
Text | Text | add robertkowalski as collaborator | fb2439a6997afd96e776e11268aeb358284d7c9a | <ide><path>README.md
<ide> information about the governance of the io.js project, see
<ide> * **Wyatt Preul** ([@geek](https://github.com/geek)) <[email protected]>
<ide> * **Brian White** ([@mscdex](https://github.com/mscdex)) <[email protected]>
<ide> * **Christian Vaagland Tellnes** ([@tellnes](https://github.com/tellnes)) <[email protected]>
<add>* **Robert Kowalski** ([@robertkowalski](https://github.com/robertkowalski)) <[email protected]>
<ide>
<ide> Collaborators follow the [COLLABORATOR_GUIDE.md](./COLLABORATOR_GUIDE.md) in
<ide> maintaining the io.js project. | 1 |
Python | Python | use amqplib if running under pypy | 7938a951355ce3d9eb6bf3f9a207dc1e18dd1c1e | <ide><path>funtests/benchmarks/bench_worker.py
<ide>
<ide> DEFAULT_ITS = 20000
<ide>
<add>BROKER_TRANSPORT = "librabbitmq"
<add>if hasattr(sys, "pypy_version_info"):
<add> BROKER_TRANSPORT = "amqplib"
<add>
<ide> celery = Celery(__name__)
<del>celery.conf.update(BROKER_TRANSPORT="librabbitmq",
<add>celery.conf.update(BROKER_TRANSPORT=BROKER_TRANSPORT,
<ide> BROKER_POOL_LIMIT=10,
<ide> CELERYD_POOL="solo",
<ide> CELERY_PREFETCH_MULTIPLIER=0, | 1 |
Python | Python | add tests for build_err_msg | 4112bf1a19f614fc426b82ff6b3ae86d8b25f92b | <ide><path>numpy/testing/tests/test_utils.py
<ide> def test_recarrays(self):
<ide>
<ide> self._test_not_equal(c, b)
<ide>
<add>class TestBuildErrorMessage(unittest.TestCase):
<add> def test_build_err_msg_defaults(self):
<add> x = np.array([1.00001, 2.00002, 3.00003])
<add> y = np.array([1.00002, 2.00003, 3.00004])
<add> err_msg = 'There is a mismatch'
<add>
<add> a = build_err_msg([x, y], err_msg)
<add> b = ('\nItems are not equal: There is a mismatch\n ACTUAL: array([ '
<add> '1.00001, 2.00002, 3.00003])\n DESIRED: array([ 1.00002, '
<add> '2.00003, 3.00004])')
<add> self.assertEqual(a, b)
<add>
<add> def test_build_err_msg_no_verbose(self):
<add> x = np.array([1.00001, 2.00002, 3.00003])
<add> y = np.array([1.00002, 2.00003, 3.00004])
<add> err_msg = 'There is a mismatch'
<add>
<add> a = build_err_msg([x, y], err_msg, verbose=False)
<add> b = '\nItems are not equal: There is a mismatch'
<add> self.assertEqual(a, b)
<add>
<add> def test_build_err_msg_custom_names(self):
<add> x = np.array([1.00001, 2.00002, 3.00003])
<add> y = np.array([1.00002, 2.00003, 3.00004])
<add> err_msg = 'There is a mismatch'
<add>
<add> a = build_err_msg([x, y], err_msg, names=('FOO', 'BAR'))
<add> b = ('\nItems are not equal: There is a mismatch\n FOO: array([ '
<add> '1.00001, 2.00002, 3.00003])\n BAR: array([ 1.00002, 2.00003, '
<add> '3.00004])')
<add> self.assertEqual(a, b)
<add>
<add> def test_build_err_msg_custom_precision(self):
<add> x = np.array([1.000000001, 2.00002, 3.00003])
<add> y = np.array([1.000000002, 2.00003, 3.00004])
<add> err_msg = 'There is a mismatch'
<add>
<add> a = build_err_msg([x, y], err_msg, precision=10)
<add> b = ('\nItems are not equal: There is a mismatch\n ACTUAL: array([ '
<add> '1.000000001, 2.00002 , 3.00003 ])\n DESIRED: array([ '
<add> '1.000000002, 2.00003 , 3.00004 ])')
<add> self.assertEqual(a, b)
<add>
<ide> class TestEqual(TestArrayEqual):
<ide> def setUp(self):
<ide> self._assert_func = assert_equal | 1 |
Javascript | Javascript | fix tailwind error with redis example. | 655eb5cb5b7e01591c16bc2d3fcba9d5740a5d67 | <ide><path>examples/with-redis/postcss.config.js
<ide> module.exports = {
<ide> plugins: {
<del> '@tailwindcss/jit': {},
<add> tailwindcss: {},
<ide> autoprefixer: {},
<ide> },
<ide> }
<ide><path>examples/with-redis/tailwind.config.js
<ide> module.exports = {
<add> mode: 'jit',
<ide> purge: ['./pages/**/*.{js,ts,jsx,tsx}', './components/**/*.{js,ts,jsx,tsx}'],
<ide> darkMode: false, // or 'media' or 'class'
<ide> theme: { | 2 |
PHP | PHP | fix inconsistent type causing php7.1 errors | 2249869650080138c34501d41d24ffe18d2a9a8e | <ide><path>src/ORM/Query.php
<ide> public function update($table = null)
<ide> * @param string|null $table Unused parameter.
<ide> * @return $this
<ide> */
<del> public function delete($table = null)
<add> public function delete(?string $table = null)
<ide> {
<ide> /** @var \Cake\ORM\Table $repository */
<ide> $repository = $this->getRepository(); | 1 |
Python | Python | add task to build html doc | 958f4a4e7c6c66e7509c745f77e1826e3159df4f | <ide><path>pavement.py
<ide> from paver.easy import options, Bunch, task, needs, dry, sh, call_task
<ide> from paver.setuputils import setup
<ide>
<del># NOTES/Changelog stuff
<add>PDF_DESTDIR = paver.path.path('build') / 'pdf'
<add>HTML_DESTDIR = paver.path.path('build') / 'html'
<add>
<ide> RELEASE = 'doc/release/1.3.0-notes.rst'
<ide> LOG_START = 'tags/1.2.0'
<ide> LOG_END = 'master'
<ide>
<add>options(sphinx=Bunch(builddir="build", sourcedir="source", docroot='doc'))
<add>
<add># NOTES/Changelog stuff
<ide> def compute_md5():
<ide> released = paver.path.path('installers').listdir()
<ide> checksums = []
<ide> def write_release():
<ide> @task
<ide> def write_log():
<ide> write_log_task()
<add>
<add># Doc build stuff
<add>@task
<add>@needs('paver.doctools.html')
<add>def html(options):
<add> """Build numpy documentation and put it into build/docs"""
<add> builtdocs = paver.path.path("docs") / options.sphinx.builddir / "html"
<add> HTML_DESTDIR.rmtree()
<add> builtdocs.copytree(HTML_DESTDIR) | 1 |
Javascript | Javascript | improve windows absolute path detection | a11922fea3ff793da1f3e1e3e2b5db2355a4ad86 | <ide><path>lib/util/URLAbsoluteSpecifier.js
<ide> const { getMimetype: getDataUrlMimetype } = require("./DataURI");
<ide> /** @typedef {(error: Error|null, result?: Buffer) => void} ErrorFirstCallback */
<ide>
<ide> const backSlashCharCode = "\\".charCodeAt(0);
<add>const slashCharCode = "/".charCodeAt(0);
<ide> const aLowerCaseCharCode = "a".charCodeAt(0);
<ide> const zLowerCaseCharCode = "z".charCodeAt(0);
<ide> const aUpperCaseCharCode = "A".charCodeAt(0);
<ide> const _9CharCode = "9".charCodeAt(0);
<ide> const plusCharCode = "+".charCodeAt(0);
<ide> const hyphenCharCode = "-".charCodeAt(0);
<ide> const colonCharCode = ":".charCodeAt(0);
<add>const hashCharCode = "#".charCodeAt(0);
<add>const queryCharCode = "?".charCodeAt(0);
<ide> /**
<ide> * Get scheme if specifier is an absolute URL specifier
<ide> * e.g. Absolute specifiers like 'file:///user/webpack/index.js'
<ide> function getScheme(specifier) {
<ide> if (
<ide> (start < aLowerCaseCharCode || start > zLowerCaseCharCode) &&
<ide> (start < aUpperCaseCharCode || start > zUpperCaseCharCode)
<del> )
<add> ) {
<ide> return undefined;
<add> }
<ide>
<ide> let i = 1;
<ide> let ch = specifier.charCodeAt(i);
<ide> function getScheme(specifier) {
<ide>
<ide> // Scheme must end with colon
<ide> if (ch !== colonCharCode) return undefined;
<add>
<ide> // Check for Windows absolute path
<del> if (specifier.charCodeAt(i + 1) === backSlashCharCode) return undefined;
<add> // https://url.spec.whatwg.org/#url-miscellaneous
<add> if (i === 1) {
<add> const nextChar = i + 1 < specifier.length ? specifier.charCodeAt(i + 1) : 0;
<add> if (
<add> nextChar === 0 ||
<add> nextChar === backSlashCharCode ||
<add> nextChar === slashCharCode ||
<add> nextChar === hashCharCode ||
<add> nextChar === queryCharCode
<add> ) {
<add> return undefined;
<add> }
<add> }
<ide>
<ide> return specifier.slice(0, i).toLowerCase();
<ide> }
<ide> function getScheme(specifier) {
<ide> * @returns {string|null} protocol if absolute URL specifier provided
<ide> */
<ide> function getProtocol(specifier) {
<del> return getScheme(specifier) + ":";
<add> const scheme = getScheme(specifier);
<add> return scheme === undefined ? undefined : scheme + ":";
<ide> }
<ide>
<ide> /**
<ide><path>test/URLAbsoluteSpecifier.unittest.js
<ide> const samples = [
<ide> {
<ide> specifier: "D:\\path\\file.js",
<ide> expected: undefined
<add> },
<add> {
<add> specifier: "d:/path/file.js",
<add> expected: undefined
<add> },
<add> {
<add> specifier: "z:#foo",
<add> expected: undefined
<add> },
<add> {
<add> specifier: "Z:?query",
<add> expected: undefined
<add> },
<add> {
<add> specifier: "C:",
<add> expected: undefined
<ide> }
<ide> ];
<ide>
<ide> describe("getScheme", () => {
<ide> samples.forEach(({ specifier, expected }, i) => {
<del> it(`sample #${i + 1}`, () => {
<add> it(`should handle ${specifier}`, () => {
<ide> expect(getScheme(specifier)).toBe(expected);
<ide> });
<ide> });
<ide> });
<ide>
<ide> describe("getProtocol", () => {
<ide> samples.forEach(({ specifier, expected }, i) => {
<del> it(`sample #${i + 1}`, () => {
<del> expect(getProtocol(specifier)).toBe(expected + ":");
<add> it(`should handle ${specifier}`, () => {
<add> expect(getProtocol(specifier)).toBe(
<add> expected ? expected + ":" : undefined
<add> );
<ide> });
<ide> });
<ide> }); | 2 |
Python | Python | fix failing tests for xla generation in tf | 8fb7c908c81de73bc8b525cdbbb4035dcc39581f | <ide><path>tests/test_modeling_tf_common.py
<ide> def _generate_and_check_results(model, config, inputs_dict):
<ide> config.do_sample = False
<ide> config.num_beams = num_beams
<ide> config.num_return_sequences = num_return_sequences
<add>
<add> # fix config for models with additional sequence-length limiting settings
<add> for var_name in ["max_position_embeddings", "max_target_positions"]:
<add> if hasattr(config, var_name):
<add> try:
<add> setattr(config, var_name, max_length)
<add> except NotImplementedError:
<add> # xlnet will raise an exception when trying to set
<add> # max_position_embeddings.
<add> pass
<add>
<ide> model = model_class(config)
<ide>
<ide> if model.supports_xla_generation:
<ide> def test_xla_generate_slow(self):
<ide>
<ide> Either the model supports XLA generation and passes the inner test, or it raises an appropriate exception
<ide> """
<del> # TODO (Joao): find the issues related to the following models. They are passing the fast test, but failing
<del> # the slow one.
<del> if any(
<del> [
<del> model in str(self).lower()
<del> for model in ["tfbart", "tfblenderbot", "tfmarian", "tfmbart", "tfopt", "tfpegasus"]
<del> ]
<del> ):
<del> return
<ide> num_beams = 8
<ide> num_return_sequences = 2
<ide> max_length = 128 | 1 |
Python | Python | add the start of some operation tests | 05929ee89bc51de772343d18d5a7bf2518d41333 | <ide><path>tests/migrations/test_operations.py
<add>from django.test import TransactionTestCase
<add>from django.db import connection, models, migrations
<add>from django.db.migrations.state import ProjectState, ModelState
<add>
<add>
<add>class OperationTests(TransactionTestCase):
<add> """
<add> Tests running the operations and making sure they do what they say they do.
<add> Each test looks at their state changing, and then their database operation -
<add> both forwards and backwards.
<add> """
<add>
<add> def assertTableExists(self, table):
<add> self.assertIn(table, connection.introspection.get_table_list(connection.cursor()))
<add>
<add> def assertTableNotExists(self, table):
<add> self.assertNotIn(table, connection.introspection.get_table_list(connection.cursor()))
<add>
<add> def set_up_test_model(self, app_label):
<add> """
<add> Creates a test model state and database table.
<add> """
<add> # Make the "current" state
<add> creation = migrations.CreateModel(
<add> "Pony",
<add> [
<add> ("id", models.AutoField(primary_key=True)),
<add> ("pink", models.BooleanField(default=True)),
<add> ],
<add> )
<add> project_state = ProjectState()
<add> creation.state_forwards(app_label, project_state)
<add> # Set up the database
<add> with connection.schema_editor() as editor:
<add> creation.database_forwards(app_label, editor, ProjectState(), project_state)
<add> return project_state
<add>
<add> def test_create_model(self):
<add> """
<add> Tests the CreateModel operation.
<add> Most other tests use this as part of setup, so check failures here first.
<add> """
<add> operation = migrations.CreateModel(
<add> "Pony",
<add> [
<add> ("id", models.AutoField(primary_key=True)),
<add> ("pink", models.BooleanField(default=True)),
<add> ],
<add> )
<add> # Test the state alteration
<add> project_state = ProjectState()
<add> new_state = project_state.clone()
<add> operation.state_forwards("test_crmo", new_state)
<add> self.assertEqual(new_state.models["test_crmo", "pony"].name, "Pony")
<add> self.assertEqual(len(new_state.models["test_crmo", "pony"].fields), 2)
<add> # Test the database alteration
<add> self.assertTableNotExists("test_crmo_pony")
<add> with connection.schema_editor() as editor:
<add> operation.database_forwards("test_crmo", editor, project_state, new_state)
<add> self.assertTableExists("test_crmo_pony")
<add> # And test reversal
<add> with connection.schema_editor() as editor:
<add> operation.database_backwards("test_crmo", editor, new_state, project_state)
<add> self.assertTableNotExists("test_crmo_pony")
<add>
<add> def test_delete_model(self):
<add> """
<add> Tests the DeleteModel operation.
<add> """
<add> project_state = self.set_up_test_model("test_dlmo")
<add> # Test the state alteration
<add> operation = migrations.DeleteModel("Pony")
<add> new_state = project_state.clone()
<add> operation.state_forwards("test_dlmo", new_state)
<add> self.assertNotIn(("test_dlmo", "pony"), new_state.models)
<add> # Test the database alteration
<add> self.assertTableExists("test_dlmo_pony")
<add> with connection.schema_editor() as editor:
<add> operation.database_forwards("test_dlmo", editor, project_state, new_state)
<add> self.assertTableNotExists("test_dlmo_pony")
<add> # And test reversal
<add> with connection.schema_editor() as editor:
<add> operation.database_backwards("test_dlmo", editor, new_state, project_state)
<add> self.assertTableExists("test_dlmo_pony") | 1 |
Go | Go | add support for healthcheck in composefile v3 | 3bd64de7a9c3eecbd57cb11d861a6fe94a5bb788 | <ide><path>cli/command/stack/deploy.go
<ide> import (
<ide> "os"
<ide> "sort"
<ide> "strings"
<add> "time"
<ide>
<ide> "github.com/spf13/cobra"
<ide> "golang.org/x/net/context"
<ide>
<ide> "github.com/aanand/compose-file/loader"
<ide> composetypes "github.com/aanand/compose-file/types"
<ide> "github.com/docker/docker/api/types"
<add> "github.com/docker/docker/api/types/container"
<ide> "github.com/docker/docker/api/types/mount"
<ide> networktypes "github.com/docker/docker/api/types/network"
<ide> "github.com/docker/docker/api/types/swarm"
<ide> func convertService(
<ide> return swarm.ServiceSpec{}, err
<ide> }
<ide>
<add> healthcheck, err := convertHealthcheck(service.HealthCheck)
<add> if err != nil {
<add> return swarm.ServiceSpec{}, err
<add> }
<add>
<ide> serviceSpec := swarm.ServiceSpec{
<ide> Annotations: swarm.Annotations{
<ide> Name: name,
<ide> func convertService(
<ide> Args: service.Command,
<ide> Hostname: service.Hostname,
<ide> Hosts: convertExtraHosts(service.ExtraHosts),
<add> Healthcheck: healthcheck,
<ide> Env: convertEnvironment(service.Environment),
<ide> Labels: getStackLabels(namespace.name, service.Labels),
<ide> Dir: service.WorkingDir,
<ide> func convertExtraHosts(extraHosts map[string]string) []string {
<ide> return hosts
<ide> }
<ide>
<add>func convertHealthcheck(healthcheck *composetypes.HealthCheckConfig) (*container.HealthConfig, error) {
<add> if healthcheck == nil {
<add> return nil, nil
<add> }
<add> var (
<add> err error
<add> timeout, interval time.Duration
<add> retries int
<add> )
<add> if healthcheck.Disable {
<add> if len(healthcheck.Test) != 0 {
<add> return nil, fmt.Errorf("command and disable key can't be set at the same time")
<add> }
<add> return &container.HealthConfig{
<add> Test: []string{"NONE"},
<add> }, nil
<add>
<add> }
<add> if healthcheck.Timeout != "" {
<add> timeout, err = time.ParseDuration(healthcheck.Timeout)
<add> if err != nil {
<add> return nil, err
<add> }
<add> }
<add> if healthcheck.Interval != "" {
<add> interval, err = time.ParseDuration(healthcheck.Interval)
<add> if err != nil {
<add> return nil, err
<add> }
<add> }
<add> if healthcheck.Retries != nil {
<add> retries = int(*healthcheck.Retries)
<add> }
<add> return &container.HealthConfig{
<add> Test: healthcheck.Test,
<add> Timeout: timeout,
<add> Interval: interval,
<add> Retries: retries,
<add> }, nil
<add>}
<add>
<ide> func convertRestartPolicy(restart string, source *composetypes.RestartPolicy) (*swarm.RestartPolicy, error) {
<ide> // TODO: log if restart is being ignored
<ide> if source == nil {
<ide><path>vendor/github.com/aanand/compose-file/types/types.go
<ide> type HealthCheckConfig struct {
<ide> Timeout string
<ide> Interval string
<ide> Retries *uint64
<add> Disable bool
<ide> }
<ide>
<ide> type UpdateConfig struct { | 2 |
Text | Text | fix method name in changelog | 59b39056d91787f6a3e4e0dfc0825c8687bd0af9 | <ide><path>CHANGELOG.md
<ide> ### React DOM
<ide>
<ide> * Add a new `getDerivedStateFromProps()` lifecycle and `UNSAFE_` aliases for the legacy lifecycles. ([@bvaughn](https://github.com/bvaughn) in [#12028](https://github.com/facebook/react/pull/12028))
<del>* Add a new `getSnapshotForUpdate()` lifecycle. ([@bvaughn](https://github.com/bvaughn) in [#12404](https://github.com/facebook/react/pull/12404))
<add>* Add a new `getSnapshotBeforeUpdate()` lifecycle. ([@bvaughn](https://github.com/bvaughn) in [#12404](https://github.com/facebook/react/pull/12404))
<ide> * Add a new `<React.StrictMode>` wrapper to help prepare apps for async rendering. ([@bvaughn](https://github.com/bvaughn) in [#12083](https://github.com/facebook/react/pull/12083))
<ide> * Add support for `onLoad` and `onError` events on the `<link>` tag. ([@roderickhsiao](https://github.com/roderickhsiao) in [#11825](https://github.com/facebook/react/pull/11825))
<ide> * Add support for `noModule` boolean attribute on the `<script>` tag. ([@aweary](https://github.com/aweary) in [#11900](https://github.com/facebook/react/pull/11900)) | 1 |
Ruby | Ruby | compare pathnames directly | 6d949599b5a9b4d770420fa2e0eec0c143d0e11d | <ide><path>Library/Homebrew/formula.rb
<ide> def tap
<ide>
<ide> # True if this formula is provided by Homebrew itself
<ide> def core_formula?
<del> path.realpath.to_s == Formula.path(name).to_s
<add> path.realpath == Formula.path(name)
<ide> end
<ide>
<ide> def self.path name | 1 |
Ruby | Ruby | fix has_and_belongs_to_many_associations tests. | 3b1cd9e525fa74c681a1bd2261881d16d5d9106d | <ide><path>activerecord/test/cases/associations/has_and_belongs_to_many_associations_test.rb
<ide> def test_caching_of_columns
<ide> david = Developer.find(1)
<ide> # clear cache possibly created by other tests
<ide> david.projects.reset_column_information
<del> assert_queries(1) { david.projects.columns; david.projects.columns }
<add> assert_queries(0) { david.projects.columns; david.projects.columns }
<ide> # and again to verify that reset_column_information clears the cache correctly
<ide> david.projects.reset_column_information
<del> assert_queries(1) { david.projects.columns; david.projects.columns }
<add> assert_queries(0) { david.projects.columns; david.projects.columns }
<ide> end
<ide>
<ide> end
<ide><path>activerecord/test/cases/helper.rb
<ide> def uses_mocha(description)
<ide> end
<ide>
<ide> ActiveRecord::Base.connection.class.class_eval do
<del> IGNORED_SQL = [/^PRAGMA/, /^SELECT currval/, /^SELECT CAST/, /^SELECT ROWCOUNT/, /^SAVEPOINT/, /^ROLLBACK TO SAVEPOINT/, /^RELEASE SAVEPOINT/]
<add> IGNORED_SQL = [/^PRAGMA/, /^SELECT currval/, /^SELECT CAST/, /^SELECT ROWCOUNT/, /^SAVEPOINT/, /^ROLLBACK TO SAVEPOINT/, /^RELEASE SAVEPOINT/, /SHOW FIELDS/]
<ide>
<ide> def execute_with_query_record(sql, name = nil, &block)
<ide> $queries_executed ||= [] | 2 |
Javascript | Javascript | add test for user provided template on a view | a7ab858f9ef8496c8940cf8acc98d6f4ddff2dc1 | <ide><path>packages/ember/tests/routing/basic_test.js
<ide> test('render does not replace templateName if user provided', function() {
<ide> equal(Ember.$('p', '#qunit-fixture').text(), "THIS IS THE REAL HOME", "The homepage template was rendered");
<ide> });
<ide>
<add>test('render does not replace template if user provided', function () {
<add> Router.map(function () {
<add> this.route("home", { path: "/" });
<add> });
<add>
<add> App.HomeView = Ember.View.extend({
<add> template: Ember.Handlebars.compile("<p>THIS IS THE REAL HOME</p>")
<add> });
<add> App.HomeController = Ember.Controller.extend();
<add> App.HomeRoute = Ember.Route.extend();
<add>
<add> bootApplication();
<add>
<add> Ember.run(function () {
<add> router.handleURL("/");
<add> });
<add>
<add> equal(Ember.$('p', '#qunit-fixture').text(), "THIS IS THE REAL HOME", "The homepage template was rendered");
<add>});
<add>
<ide> test("The Homepage with a `setupController` hook", function() {
<ide> Router.map(function() {
<ide> this.route("home", { path: "/" }); | 1 |
PHP | PHP | remove unnecessary parameter | 3f66a220825366a098f064b1da2c116b2ed2d6d9 | <ide><path>Cake/Test/TestCase/ORM/QueryTest.php
<ide> public function strategiesProvider() {
<ide> * @return void
<ide> */
<ide> public function testHasManyEagerLoadingNoHydration($strategy) {
<del> $table = TableRegistry::get('author', ['connection' => $this->connection]);
<del> TableRegistry::get('article', ['connection' => $this->connection]);
<add> $table = TableRegistry::get('author');
<add> TableRegistry::get('article');
<ide> $table->hasMany('article', [
<ide> 'property' => 'articles',
<ide> 'strategy' => $strategy,
<ide> public function testHasManyEagerLoadingNoHydration($strategy) {
<ide> * @return void
<ide> **/
<ide> public function testHasManyEagerLoadingFieldsAndOrderNoHydration($strategy) {
<del> $table = TableRegistry::get('author', ['connection' => $this->connection]);
<del> TableRegistry::get('article', ['connection' => $this->connection]);
<add> $table = TableRegistry::get('author');
<add> TableRegistry::get('article');
<ide> $table->hasMany('article', ['property' => 'articles'] + compact('strategy'));
<ide>
<ide> $query = new Query($this->connection, $table);
<ide> public function testHasManyEagerLoadingFieldsAndOrderNoHydration($strategy) {
<ide> * @return void
<ide> */
<ide> public function testHasManyEagerLoadingDeep($strategy) {
<del> $table = TableRegistry::get('author', ['connection' => $this->connection]);
<del> $article = TableRegistry::get('article', ['connection' => $this->connection]);
<add> $table = TableRegistry::get('author');
<add> $article = TableRegistry::get('article');
<ide> $table->hasMany('article', [
<ide> 'property' => 'articles',
<ide> 'stratgey' => $strategy,
<ide> public function testHasManyEagerLoadingDeep($strategy) {
<ide> **/
<ide> public function testHasManyEagerLoadingFromSecondaryTable($strategy) {
<ide>
<del> $author = TableRegistry::get('author', ['connection' => $this->connection]);
<del> $article = TableRegistry::get('article', ['connection' => $this->connection]);
<del> $post = TableRegistry::get('post', ['connection' => $this->connection]);
<add> $author = TableRegistry::get('author');
<add> $article = TableRegistry::get('article');
<add> $post = TableRegistry::get('post');
<ide>
<ide> $author->hasMany('post', ['property' => 'posts'] + compact('strategy'));
<ide> $article->belongsTo('author');
<ide> public function testHasManyEagerLoadingFromSecondaryTable($strategy) {
<ide> * @return void
<ide> **/
<ide> public function testBelongsToManyEagerLoadingNoHydration($strategy) {
<del> $table = TableRegistry::get('Article', ['connection' => $this->connection]);
<del> TableRegistry::get('Tag', ['connection' => $this->connection]);
<add> $table = TableRegistry::get('Article');
<add> TableRegistry::get('Tag');
<ide> TableRegistry::get('ArticleTag', [
<del> 'connection' => $this->connection,
<ide> 'table' => 'articles_tags'
<ide> ]);
<ide> $table->belongsToMany('Tag', ['property' => 'tags', 'strategy' => $strategy]);
<ide> public function testBelongsToManyEagerLoadingNoHydration($strategy) {
<ide> */
<ide> public function testFilteringByHasManyNoHydration() {
<ide> $query = new Query($this->connection, $this->table);
<del> $table = TableRegistry::get('author', ['connection' => $this->connection]);
<del> TableRegistry::get('article', ['connection' => $this->connection]);
<add> $table = TableRegistry::get('author');
<add> TableRegistry::get('article');
<ide> $table->hasMany('article', ['property' => 'articles']);
<ide>
<ide> $results = $query->repository($table)
<ide> public function testFilteringByHasManyNoHydration() {
<ide> **/
<ide> public function testFilteringByBelongsToManyNoHydration() {
<ide> $query = new Query($this->connection, $this->table);
<del> $table = TableRegistry::get('Article', ['connection' => $this->connection]);
<del> TableRegistry::get('Tag', ['connection' => $this->connection]);
<add> $table = TableRegistry::get('Article');
<add> TableRegistry::get('Tag');
<ide> TableRegistry::get('ArticleTag', [
<del> 'connection' => $this->connection,
<ide> 'table' => 'articles_tags'
<ide> ]);
<ide> $table->belongsToMany('Tag', ['property' => 'tags']);
<ide> public function testSetResult() {
<ide> * @return void
<ide> */
<ide> public function testBufferResults() {
<del> $table = TableRegistry::get('article', ['connection' => $this->connection, 'table' => 'articles']);
<add> $table = TableRegistry::get('article', ['table' => 'articles']);
<ide> $query = new Query($this->connection, $table);
<ide>
<ide> $result = $query->select()->bufferResults();
<ide> public function testHydrateSimple() {
<ide> * @return void
<ide> */
<ide> public function testHydrateWithHasMany() {
<del> $table = TableRegistry::get('author', ['connection' => $this->connection]);
<del> TableRegistry::get('article', ['connection' => $this->connection]);
<add> $table = TableRegistry::get('author');
<add> TableRegistry::get('article');
<ide> $table->hasMany('article', [
<ide> 'property' => 'articles',
<ide> 'sort' => ['article.id' => 'asc']
<ide> public function testHydrateWithHasMany() {
<ide> * @return void
<ide> */
<ide> public function testHydrateBelongsToMany() {
<del> $table = TableRegistry::get('Article', ['connection' => $this->connection]);
<del> TableRegistry::get('Tag', ['connection' => $this->connection]);
<add> $table = TableRegistry::get('Article');
<add> TableRegistry::get('Tag');
<ide> TableRegistry::get('ArticlesTag', [
<del> 'connection' => $this->connection,
<ide> 'table' => 'articles_tags'
<ide> ]);
<ide> $table->belongsToMany('Tag', ['property' => 'tags']);
<ide> public function testHydrateBelongsToMany() {
<ide> */
<ide> public function testHydrateBelongsTo() {
<ide> $table = TableRegistry::get('article', ['table' => 'articles']);
<del> TableRegistry::get('author', ['connection' => $this->connection]);
<add> TableRegistry::get('author');
<ide> $table->belongsTo('author');
<ide>
<ide> $query = new Query($this->connection, $table);
<ide> public function testHydrateBelongsTo() {
<ide> * @return void
<ide> */
<ide> public function testHydrateDeep() {
<del> $table = TableRegistry::get('author', ['connection' => $this->connection]);
<del> $article = TableRegistry::get('article', ['connection' => $this->connection]);
<add> $table = TableRegistry::get('author');
<add> $article = TableRegistry::get('article');
<ide> $table->hasMany('article', [
<ide> 'property' => 'articles',
<ide> 'sort' => ['article.id' => 'asc']
<ide> public function testHydrateWithHasManyCustomEntity() {
<ide> $authorEntity = $this->getMockClass('\Cake\ORM\Entity', ['foo']);
<ide> $articleEntity = $this->getMockClass('\Cake\ORM\Entity', ['foo']);
<ide> $table = TableRegistry::get('author', [
<del> 'connection' => $this->connection,
<ide> 'entityClass' => '\\' . $authorEntity
<ide> ]);
<ide> TableRegistry::get('article', [
<del> 'connection' => $this->connection,
<ide> 'entityClass' => '\\' . $articleEntity
<ide> ]);
<ide> $table->hasMany('article', [
<ide> public function testHydrateBelongsToCustomEntity() {
<ide> $authorEntity = $this->getMockClass('\Cake\ORM\Entity', ['foo']);
<ide> $table = TableRegistry::get('article', ['table' => 'articles']);
<ide> TableRegistry::get('author', [
<del> 'connection' => $this->connection,
<ide> 'entityClass' => '\\' . $authorEntity
<ide> ]);
<ide> $table->belongsTo('author'); | 1 |
Text | Text | add github issue templates | 05e487a12ffee59b75db82995f3f826254444741 | <ide><path>.github/ISSUE_TEMPLATE.md
<del><!--
<del> Note: if the issue is about documentation or the website, please file it at:
<del> https://github.com/reactjs/reactjs.org/issues/new
<del>-->
<add>👉 Please follow one of these issue templates:
<add>- https://github.com/facebook/react/issues/new/choose
<ide>
<del>**Do you want to request a *feature* or report a *bug*?**
<del>
<del>**What is the current behavior?**
<del>
<del>**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:**
<del>
<del>**What is the expected behavior?**
<del>
<del>**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**
<add>Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
<ide><path>.github/ISSUE_TEMPLATE/bug_report.md
<add>---
<add>name: "🐛 Bug Report"
<add>about: Report a reproducible bug or regression.
<add>title: 'Bug: '
<add>labels: 'Status: Unconfirmed'
<add>
<add>---
<add>
<add><!--
<add> Please provide a clear and concise description of what the bug is. Include
<add> screenshots if needed. Please test using the latest version of the relevant
<add> React packages to make sure your issue has not already been fixed.
<add>-->
<add>
<add>React version:
<add>
<add>## Steps To Reproduce
<add>
<add>1.
<add>2.
<add>
<add><!--
<add> Your bug will get fixed much faster if we can run your code and it doesn't
<add> have dependencies other than React. Issues without reproduction steps or
<add> code examples may be immediately closed as not actionable.
<add>-->
<add>
<add>Link to code example:
<add>
<add><!--
<add> Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a
<add> repository on GitHub, or provide a minimal code example that reproduces the
<add> problem. You may provide a screenshot of the application if you think it is
<add> relevant to your bug report. Here are some tips for providing a minimal
<add> example: https://stackoverflow.com/help/mcve.
<add>-->
<add>
<add>## The current behavior
<add>
<add>
<add>## The expected behavior
<ide><path>.github/ISSUE_TEMPLATE/documentation.md
<add>---
<add>name: "📃 Documentation Issue"
<add>about: This issue tracker is not for documentation issues. Please file documentation issues at https://github.com/reactjs/reactjs.org.
<add>title: 'Docs: '
<add>labels: 'Resolution: Invalid'
<add>
<add>---
<add>
<add>🚨 This issue tracker is not for documentation issues. 🚨
<add>
<add>The React website is hosted on a separate repository. You may let the
<add>team know about any issues with the documentation by opening an issue there:
<add>- https://github.com/reactjs/reactjs.org/issues/new
<ide><path>.github/ISSUE_TEMPLATE/question.md
<add>---
<add>name: "🤔 Questions and Help"
<add>about: This issue tracker is not for questions. Please ask questions at https://stackoverflow.com/questions/tagged/react.
<add>title: 'Question: '
<add>labels: 'Resolution: Invalid', 'Type: Question'
<add>
<add>---
<add>
<add>🚨 This issue tracker is not for questions. 🚨
<add>
<add>As it happens, support requests that are created as issues are likely to be closed. We want to make sure you are able to find the help you seek. Please take a look at the following resources.
<add>
<add>## Coding Questions
<add>
<add>### https://stackoverflow.com/questions/tagged/react
<add>
<add>If you have a coding question related to React and React DOM, it might be better suited for Stack Overflow. It's a great place to browse through frequent questions about using React, as well as ask for help with specific questions.
<add>
<add>## Talk to other React developers
<add>
<add>### https://www.reactiflux.com/
<add>
<add>Reactiflux is an active community of React and React Native developers. If you are looking for immediate assistance or have a general question about React, the #help-react channel is a good place to start.
<add>
<add>## Proposals
<add>
<add>### https://github.com/reactjs/rfcs
<add>
<add>If you'd like to discuss topics related to the future of React, or would like to propose a new feature or change before sending a pull request, please check out the discussions and proposals repository.
<ide><path>.github/PULL_REQUEST_TEMPLATE.md
<del>**Before submitting a pull request,** please make sure the following is done:
<del>
<del>1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`.
<del>2. Run `yarn` in the repository root.
<del>3. If you've fixed a bug or added code that should be tested, add tests!
<del>4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
<del>5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`.
<del>6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
<del>7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
<del>8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
<del>9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`).
<del>10. If you haven't already, complete the CLA.
<del>
<del>**Learn more about contributing:** https://reactjs.org/docs/how-to-contribute.html
<add><!--
<add> Thanks for submitting a pull request!
<add> We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
<add>
<add> Before submitting a pull request, please make sure the following is done:
<add>
<add> 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`.
<add> 2. Run `yarn` in the repository root.
<add> 3. If you've fixed a bug or added code that should be tested, add tests!
<add> 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
<add> 5. Run `yarn test-prod` to test in the production environment. It supports the same options as `yarn test`.
<add> 6. If you need a debugger, run `yarn debug-test --watch TestName`, open `chrome://inspect`, and press "Inspect".
<add> 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
<add> 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
<add> 9. Run the [Flow](https://flowtype.org/) typechecks (`yarn flow`).
<add> 10. If you haven't already, complete the CLA.
<add>
<add> Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
<add>-->
<add>
<add>## Summary
<add>
<add><!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
<add>
<add>## Test Plan
<add>
<add><!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. --> | 5 |
Java | Java | simplify initialization of websession mono | 2f2546c8a454bd63181d793e31acdf0252b3ff4c | <ide><path>spring-web-reactive/src/main/java/org/springframework/web/server/adapter/DefaultServerWebExchange.java
<ide> public class DefaultServerWebExchange implements ServerWebExchange {
<ide>
<ide> private final ServerHttpResponse response;
<ide>
<del> private final WebSessionManager sessionManager;
<del>
<del>
<ide> private final Map<String, Object> attributes = new ConcurrentHashMap<>();
<ide>
<del> private final Object createSessionLock = new Object();
<del>
<del> private Mono<WebSession> sessionMono;
<del>
<add> private final Mono<WebSession> sessionMono;
<ide>
<ide>
<ide> public DefaultServerWebExchange(ServerHttpRequest request, ServerHttpResponse response,
<ide> public DefaultServerWebExchange(ServerHttpRequest request, ServerHttpResponse re
<ide> Assert.notNull(response, "'sessionManager' is required.");
<ide> this.request = request;
<ide> this.response = response;
<del> this.sessionManager = sessionManager;
<add> this.sessionMono = sessionManager.getSession(this).cache();
<ide> }
<ide>
<ide>
<ide> public <T> Optional<T> getAttribute(String name) {
<ide>
<ide> @Override
<ide> public Mono<WebSession> getSession() {
<del> if (this.sessionMono == null) {
<del> synchronized (this.createSessionLock) {
<del> if (this.sessionMono == null) {
<del> this.sessionMono = this.sessionManager.getSession(this).cache();
<del> }
<del> }
<del> }
<ide> return this.sessionMono;
<ide> }
<ide>
<ide><path>spring-web-reactive/src/main/java/org/springframework/web/server/session/DefaultWebSessionManager.java
<ide> public Clock getClock() {
<ide>
<ide> @Override
<ide> public Mono<WebSession> getSession(ServerWebExchange exchange) {
<del> return Flux.fromIterable(getSessionIdResolver().resolveSessionIds(exchange))
<del> .concatMap(this.sessionStore::retrieveSession)
<del> .next()
<del> .then(session -> validateSession(exchange, session))
<del> .otherwiseIfEmpty(createSession(exchange))
<del> .map(session -> extendSession(exchange, session));
<add> return Mono.defer(() ->
<add> Flux.fromIterable(getSessionIdResolver().resolveSessionIds(exchange))
<add> .concatMap(this.sessionStore::retrieveSession)
<add> .next()
<add> .then(session -> validateSession(exchange, session))
<add> .otherwiseIfEmpty(createSession(exchange))
<add> .map(session -> extendSession(exchange, session)));
<ide> }
<ide>
<ide> protected Mono<WebSession> validateSession(ServerWebExchange exchange, WebSession session) { | 2 |
Ruby | Ruby | prevent "saved" message when edit command aborted | d4e87ca190f5f0707439a37d020c5b58e6b02d73 | <ide><path>railties/lib/rails/commands/credentials/credentials_command.rb
<ide> def edit
<ide> ensure_credentials_have_been_added
<ide> ensure_diffing_driver_is_configured
<ide>
<del> catch_editing_exceptions do
<del> change_credentials_in_system_editor
<del> end
<del>
<del> say "File encrypted and saved."
<del> warn_if_credentials_are_invalid
<del> rescue ActiveSupport::MessageEncryptor::InvalidMessage
<del> say "Couldn't decrypt #{content_path}. Perhaps you passed the wrong key?"
<add> change_credentials_in_system_editor
<ide> end
<ide>
<ide> def show
<ide> def ensure_credentials_have_been_added
<ide> end
<ide>
<ide> def change_credentials_in_system_editor
<del> credentials.change do |tmp_path|
<del> system(*Shellwords.split(ENV["EDITOR"]), tmp_path.to_s)
<add> catch_editing_exceptions do
<add> credentials.change do |tmp_path|
<add> system(*Shellwords.split(ENV["EDITOR"]), tmp_path.to_s)
<add> end
<add>
<add> say "File encrypted and saved."
<add> warn_if_credentials_are_invalid
<ide> end
<add> rescue ActiveSupport::MessageEncryptor::InvalidMessage
<add> say "Couldn't decrypt #{content_path}. Perhaps you passed the wrong key?"
<ide> end
<ide>
<ide> def warn_if_credentials_are_invalid
<ide><path>railties/lib/rails/commands/encrypted/encrypted_command.rb
<ide> def edit(*)
<ide> ensure_encryption_key_has_been_added
<ide> ensure_encrypted_configuration_has_been_added
<ide>
<del> catch_editing_exceptions do
<del> change_encrypted_configuration_in_system_editor
<del> end
<del>
<del> say "File encrypted and saved."
<del> warn_if_encrypted_configuration_is_invalid
<del> rescue ActiveSupport::MessageEncryptor::InvalidMessage
<del> say "Couldn't decrypt #{content_path}. Perhaps you passed the wrong key?"
<add> change_encrypted_configuration_in_system_editor
<ide> end
<ide>
<ide> def show(*)
<ide> def ensure_encrypted_configuration_has_been_added
<ide> end
<ide>
<ide> def change_encrypted_configuration_in_system_editor
<del> encrypted_configuration.change do |tmp_path|
<del> system("#{ENV["EDITOR"]} #{tmp_path}")
<add> catch_editing_exceptions do
<add> encrypted_configuration.change do |tmp_path|
<add> system("#{ENV["EDITOR"]} #{tmp_path}")
<add> end
<add>
<add> say "File encrypted and saved."
<add> warn_if_encrypted_configuration_is_invalid
<ide> end
<add> rescue ActiveSupport::MessageEncryptor::InvalidMessage
<add> say "Couldn't decrypt #{content_path}. Perhaps you passed the wrong key?"
<ide> end
<ide>
<ide> def warn_if_encrypted_configuration_is_invalid
<ide><path>railties/test/commands/credentials_test.rb
<ide> class Rails::Command::CredentialsCommandTest < ActiveSupport::TestCase
<ide> assert_match %r/provides_secret_key_base: true/, run_edit_command
<ide> end
<ide>
<add> test "edit command does not display save confirmation message if interrupted" do
<add> assert_match %r/file encrypted and saved/i, run_edit_command
<add>
<add> interrupt_command_process = %(ruby -e "Process.kill 'INT', Process.ppid")
<add> output = run_edit_command(editor: interrupt_command_process)
<add>
<add> assert_no_match %r/file encrypted and saved/i, output
<add> assert_match %r/nothing saved/i, output
<add> end
<add>
<ide> test "edit command preserves user's content even if it contains invalid YAML" do
<ide> write_invalid_yaml = %(ruby -e "File.write ARGV[0], 'foo: bar: bad'")
<ide>
<ide><path>railties/test/commands/encrypted_test.rb
<ide> class Rails::Command::EncryptedCommandTest < ActiveSupport::TestCase
<ide> assert_match(/access_key_id: 123/, run_edit_command(key: "config/tokens.key"))
<ide> end
<ide>
<add> test "edit command does not display save confirmation message if interrupted" do
<add> assert_match %r/file encrypted and saved/i, run_edit_command
<add>
<add> interrupt_command_process = %(exec ruby -e "Process.kill 'INT', Process.ppid")
<add> output = run_edit_command(editor: interrupt_command_process)
<add>
<add> assert_no_match %r/file encrypted and saved/i, output
<add> assert_match %r/nothing saved/i, output
<add> end
<add>
<ide> test "edit command preserves user's content even if it contains invalid YAML" do
<ide> write_invalid_yaml = %(ruby -e "File.write ARGV[0], 'foo: bar: bad'")
<ide> | 4 |
Text | Text | add backticks to show shell command | fab3a73af4e6f10f80cfd2a9004426c432394ddc | <ide><path>railties/CHANGELOG.md
<ide>
<ide> To generate a new app that has Webpack dependencies configured and binstubs for webpack and webpack-watcher:
<ide>
<del> rails new myapp --webpack
<add> `rails new myapp --webpack`
<ide>
<ide> To generate a new app that has Webpack + React configured and an example intalled:
<ide>
<del> rails new myapp --webpack=react
<add> `rails new myapp --webpack=react`
<ide>
<ide> *DHH*
<ide> | 1 |
Python | Python | fix failing tests | d6d5a83053c5077f2d3d51084113e4386f496380 | <ide><path>libcloud/compute/drivers/cloudwatt.py
<ide> def __init__(self, *args, **kwargs):
<ide> self._ex_tenant_id = kwargs.pop("ex_tenant_id")
<ide> super(CloudwattAuthConnection, self).__init__(*args, **kwargs)
<ide>
<add> def morph_action_hook(self, action):
<add> (_, _, _, request_path) = self._tuple_from_url(self.auth_url)
<add>
<add> if request_path == "":
<add> # No path is provided in the auth_url, use action passed to this
<add> # method.
<add> return action
<add>
<add> return request_path
<add>
<ide> def authenticate(self, force=False):
<ide> reqbody = json.dumps(
<ide> {
<ide><path>libcloud/compute/drivers/kili.py
<ide>
<ide> ENDPOINT_ARGS = {"service_type": "compute", "name": "nova", "region": "RegionOne"}
<ide>
<del>AUTH_URL = "https://api.kili.io/keystone/v2.0/tokens"
<add>AUTH_URL = "https://api.kili.io/keystone"
<ide>
<ide>
<ide> class KiliCloudConnection(OpenStack_1_1_Connection):
<ide><path>libcloud/test/compute/test_kili.py
<ide> def _ex_connection_class_kwargs(self):
<ide> kwargs = self.openstack_connection_kwargs()
<ide> kwargs["get_endpoint_args"] = ENDPOINT_ARGS
<ide> # Remove keystone from the URL path so that the openstack base tests work
<del> kwargs["ex_force_auth_url"] = "https://api.kili.io/v2.0/tokens"
<add> kwargs["ex_force_auth_url"] = "https://api.kili.io/"
<ide> kwargs["ex_tenant_name"] = self.tenant_name
<ide>
<ide> return kwargs | 3 |
Javascript | Javascript | fix browserstack tests | d5a9092c3f97290fa40e65b15d03015909f98587 | <ide><path>testem.dist.js
<ide> module.exports = {
<ide> '--b',
<ide> 'safari',
<ide> '--bv',
<del> '11',
<add> 'latest',
<ide> '-t',
<ide> '1200',
<ide> '--u',
<ide> module.exports = {
<ide> '--b',
<ide> 'safari',
<ide> '--bv',
<del> '10.1',
<add> 'latest',
<ide> '-t',
<ide> '1200',
<ide> '--u', | 1 |
PHP | PHP | allow run tests from any directory | 4ec56e28b52da6ed8b7976601d6dbe311880fdbc | <ide><path>src/TestSuite/MiddlewareDispatcher.php
<ide> public function __construct($test, $class = null, $constructorArgs = null)
<ide> {
<ide> $this->_test = $test;
<ide> $this->_class = $class ?: Configure::read('App.namespace') . '\Application';
<del> $this->_constructorArgs = $constructorArgs ?: ['./config'];
<add> $this->_constructorArgs = $constructorArgs ?: [CONFIG];
<ide> }
<ide>
<ide> /** | 1 |
PHP | PHP | add array_where helper | 7b7df5a18c38bd2bc24b1721d06e21dff11a418e | <ide><path>src/Illuminate/Support/helpers.php
<ide> function array_sort($array, Closure $callback)
<ide> }
<ide> }
<ide>
<add>if ( ! function_exists('array_where'))
<add>{
<add> /**
<add> * Filter the array using the given Closure.
<add> *
<add> * @param array $array
<add> * @param \Closure $callback
<add> * @return array
<add> */
<add> function array_where($array, Closure $callback)
<add> {
<add> $filtered = array();
<add>
<add> foreach ($array as $key => $value)
<add> {
<add> if (call_user_func($callback, $key, $value)) $filtered[$key] = $value;
<add> }
<add>
<add> return $filtered;
<add> }
<add>}
<add>
<ide> if ( ! function_exists('asset'))
<ide> {
<ide> /** | 1 |
PHP | PHP | add missing import | ab6fab667559a0d8263c0bee7e23350835150bba | <ide><path>lib/Cake/Error/ExceptionRenderer.php
<ide> App::uses('Sanitize', 'Utility');
<ide> App::uses('Router', 'Routing');
<ide> App::uses('CakeResponse', 'Network');
<add>App::uses('Controller', 'Controller');
<ide>
<ide> /**
<ide> * Exception Renderer. | 1 |
Java | Java | improve javadoc for beanexpressionresolver | 8fc744f4f4bb27bba10532264a257677d2c35802 | <ide><path>spring-beans/src/main/java/org/springframework/beans/factory/config/BeanExpressionResolver.java
<ide> /*
<del> * Copyright 2002-2017 the original author or authors.
<add> * Copyright 2002-2022 the original author or authors.
<ide> *
<ide> * Licensed under the Apache License, Version 2.0 (the "License");
<ide> * you may not use this file except in compliance with the License.
<ide> import org.springframework.lang.Nullable;
<ide>
<ide> /**
<del> * Strategy interface for resolving a value through evaluating it
<del> * as an expression, if applicable.
<add> * Strategy interface for resolving a value by evaluating it as an expression,
<add> * if applicable.
<ide> *
<ide> * <p>A raw {@link org.springframework.beans.factory.BeanFactory} does not
<ide> * contain a default implementation of this strategy. However,
<ide> public interface BeanExpressionResolver {
<ide> /**
<ide> * Evaluate the given value as an expression, if applicable;
<ide> * return the value as-is otherwise.
<del> * @param value the value to check
<del> * @param evalContext the evaluation context
<add> * @param value the value to evaluate as an expression
<add> * @param beanExpressionContext the bean expression context to use when
<add> * evaluating the expression
<ide> * @return the resolved value (potentially the given value as-is)
<ide> * @throws BeansException if evaluation failed
<ide> */
<ide> @Nullable
<del> Object evaluate(@Nullable String value, BeanExpressionContext evalContext) throws BeansException;
<add> Object evaluate(@Nullable String value, BeanExpressionContext beanExpressionContext) throws BeansException;
<ide>
<ide> }
<ide><path>spring-context/src/main/java/org/springframework/context/expression/StandardBeanExpressionResolver.java
<ide> public void setExpressionParser(ExpressionParser expressionParser) {
<ide>
<ide> @Override
<ide> @Nullable
<del> public Object evaluate(@Nullable String value, BeanExpressionContext evalContext) throws BeansException {
<add> public Object evaluate(@Nullable String value, BeanExpressionContext beanExpressionContext) throws BeansException {
<ide> if (!StringUtils.hasLength(value)) {
<ide> return value;
<ide> }
<ide> public Object evaluate(@Nullable String value, BeanExpressionContext evalContext
<ide> expr = this.expressionParser.parseExpression(value, this.beanExpressionParserContext);
<ide> this.expressionCache.put(value, expr);
<ide> }
<del> StandardEvaluationContext sec = this.evaluationCache.get(evalContext);
<add> StandardEvaluationContext sec = this.evaluationCache.get(beanExpressionContext);
<ide> if (sec == null) {
<del> sec = new StandardEvaluationContext(evalContext);
<add> sec = new StandardEvaluationContext(beanExpressionContext);
<ide> sec.addPropertyAccessor(new BeanExpressionContextAccessor());
<ide> sec.addPropertyAccessor(new BeanFactoryAccessor());
<ide> sec.addPropertyAccessor(new MapAccessor());
<ide> sec.addPropertyAccessor(new EnvironmentAccessor());
<del> sec.setBeanResolver(new BeanFactoryResolver(evalContext.getBeanFactory()));
<del> sec.setTypeLocator(new StandardTypeLocator(evalContext.getBeanFactory().getBeanClassLoader()));
<add> sec.setBeanResolver(new BeanFactoryResolver(beanExpressionContext.getBeanFactory()));
<add> sec.setTypeLocator(new StandardTypeLocator(beanExpressionContext.getBeanFactory().getBeanClassLoader()));
<ide> sec.setTypeConverter(new StandardTypeConverter(() -> {
<del> ConversionService cs = evalContext.getBeanFactory().getConversionService();
<add> ConversionService cs = beanExpressionContext.getBeanFactory().getConversionService();
<ide> return (cs != null ? cs : DefaultConversionService.getSharedInstance());
<ide> }));
<ide> customizeEvaluationContext(sec);
<del> this.evaluationCache.put(evalContext, sec);
<add> this.evaluationCache.put(beanExpressionContext, sec);
<ide> }
<ide> return expr.getValue(sec);
<ide> } | 2 |
Go | Go | fix removeinterface in sandbox | 820712cae66227bf4e551c93319f8729f60c5a05 | <ide><path>libnetwork/sandbox/namespace_linux.go
<ide> func (n *networkNamespace) RemoveInterface(i *Interface) error {
<ide> return err
<ide> }
<ide>
<add> n.Lock()
<add> for index, intf := range n.sinfo.Interfaces {
<add> if intf == i {
<add> n.sinfo.Interfaces = append(n.sinfo.Interfaces[:index], n.sinfo.Interfaces[index+1:]...)
<add> break
<add> }
<add> }
<add> n.Unlock()
<add>
<ide> return nil
<ide> }
<ide>
<ide> func (n *networkNamespace) SetGatewayIPv6(gw net.IP) error {
<ide> }
<ide>
<ide> func (n *networkNamespace) Interfaces() []*Interface {
<add> n.Lock()
<add> defer n.Unlock()
<ide> return n.sinfo.Interfaces
<ide> }
<ide>
<ide><path>libnetwork/sandbox/sandbox_linux_test.go
<ide> func newInfo(t *testing.T) (*Info, error) {
<ide>
<ide> // ip6, addrv6, err := net.ParseCIDR("2001:DB8::ABCD/48")
<ide> ip6, addrv6, err = net.ParseCIDR("fe80::3/64")
<add>
<ide> if err != nil {
<ide> return nil, err
<ide> }
<ide> func verifySandbox(t *testing.T, s Sandbox) {
<ide>
<ide> _, err = netlink.LinkByName(sboxIfaceName + "0")
<ide> if err != nil {
<del> t.Fatalf("Could not find the interface %s inside the sandbox: %v", sboxIfaceName,
<add> t.Fatalf("Could not find the interface %s inside the sandbox: %v", sboxIfaceName+"0",
<ide> err)
<ide> }
<ide>
<ide> _, err = netlink.LinkByName(sboxIfaceName + "1")
<ide> if err != nil {
<del> t.Fatalf("Could not find the interface %s inside the sandbox: %v", sboxIfaceName,
<add> t.Fatalf("Could not find the interface %s inside the sandbox: %v", sboxIfaceName+"1",
<ide> err)
<ide> }
<ide> }
<ide><path>libnetwork/sandbox/sandbox_test.go
<ide> func TestSandboxCreateTwice(t *testing.T) {
<ide> s.Destroy()
<ide> }
<ide>
<add>func TestAddRemoveInterface(t *testing.T) {
<add> key, err := newKey(t)
<add> if err != nil {
<add> t.Fatalf("Failed to obtain a key: %v", err)
<add> }
<add>
<add> s, err := NewSandbox(key, true)
<add> if err != nil {
<add> t.Fatalf("Failed to create a new sandbox: %v", err)
<add> }
<add>
<add> if s.Key() != key {
<add> t.Fatalf("s.Key() returned %s. Expected %s", s.Key(), key)
<add> }
<add>
<add> info, err := newInfo(t)
<add> if err != nil {
<add> t.Fatalf("Failed to generate new sandbox info: %v", err)
<add> }
<add>
<add> for _, i := range info.Interfaces {
<add> err = s.AddInterface(i)
<add> if err != nil {
<add> t.Fatalf("Failed to add interfaces to sandbox: %v", err)
<add> }
<add> }
<add>
<add> interfaces := s.Interfaces()
<add> if !(interfaces[0].Equal(info.Interfaces[0]) && interfaces[1].Equal(info.Interfaces[1])) {
<add> t.Fatalf("Failed to update Sandbox.sinfo.Interfaces in AddInterfaces")
<add> }
<add>
<add> if err := s.RemoveInterface(info.Interfaces[0]); err != nil {
<add> t.Fatalf("Failed to remove interfaces from sandbox: %v", err)
<add> }
<add>
<add> if !s.Interfaces()[0].Equal(info.Interfaces[1]) {
<add> t.Fatalf("Failed to update the sanbox.sinfo.Interfaces in RemoveInterferce")
<add> }
<add>
<add> if err := s.AddInterface(info.Interfaces[0]); err != nil {
<add> t.Fatalf("Failed to add interfaces to sandbox: %v", err)
<add> }
<add>
<add> interfaces = s.Interfaces()
<add> if !(interfaces[0].Equal(info.Interfaces[1]) && interfaces[1].Equal(info.Interfaces[0])) {
<add> t.Fatalf("Failed to update Sandbox.sinfo.Interfaces in AddInterfaces")
<add> }
<add>
<add> s.Destroy()
<add>}
<add>
<ide> func TestInterfaceEqual(t *testing.T) {
<ide> list := getInterfaceList()
<ide> | 3 |
Ruby | Ruby | remove cvar for registered details | eeea496d5fcf824b0c5e2b0a4e3bfedd5e038b1b | <ide><path>actionview/lib/action_view/lookup_context.rb
<ide> module ActionView
<ide> class LookupContext #:nodoc:
<ide> attr_accessor :prefixes, :rendered_format
<ide>
<del> mattr_accessor :registered_details, default: []
<add> singleton_class.attr_accessor :registered_details
<add> self.registered_details = []
<ide>
<ide> def self.register_detail(name, &block)
<ide> registered_details << name
<ide> def detail_args_for_any
<ide> @detail_args_for_any ||= begin
<ide> details = {}
<ide>
<del> registered_details.each do |k|
<add> LookupContext.registered_details.each do |k|
<ide> if k == :variants
<ide> details[k] = :any
<ide> else
<ide> def with_prepended_formats(formats)
<ide> end
<ide>
<ide> def initialize_details(target, details)
<del> registered_details.each do |k|
<add> LookupContext.registered_details.each do |k|
<ide> target[k] = details[k] || Accessors::DEFAULT_PROCS[k].call
<ide> end
<ide> target
<ide><path>actionview/lib/action_view/renderer/abstract_renderer.rb
<ide> def format
<ide>
<ide> def extract_details(options) # :doc:
<ide> details = nil
<del> @lookup_context.registered_details.each do |key|
<add> LookupContext.registered_details.each do |key|
<ide> value = options[key]
<ide>
<ide> if value | 2 |
Python | Python | add missed files for test | 0ee2edc0a14c4d14b8aa6e4b63ccbd0c2cc78024 | <ide><path>tests/browsable_api/models.py
<add>from django.db import models
<add>
<add>
<add>class Foo(models.Model):
<add> name = models.CharField(max_length=30)
<add>
<add>
<add>class Bar(models.Model):
<add> foo = models.ForeignKey("Foo", editable=False)
<ide><path>tests/browsable_api/serializers.py
<add>from .models import Foo, Bar
<add>from rest_framework.serializers import HyperlinkedModelSerializer, HyperlinkedIdentityField
<add>
<add>
<add>class FooSerializer(HyperlinkedModelSerializer):
<add> bar = HyperlinkedIdentityField(view_name='bar-list')
<add>
<add> class Meta:
<add> model = Foo
<add>
<add>
<add>class BarSerializer(HyperlinkedModelSerializer):
<add> class Meta:
<add> model = Bar | 2 |
Text | Text | add a mention of brew-desc to readme | 8a08d101147a8ff3a60bf6b5e6ee24f0f84c7de6 | <ide><path>README.md
<ide> What Packages Are Available?
<ide> 1. You can [browse the Formula directory on GitHub][formula].
<ide> 2. Or type `brew search` for a list.
<ide> 3. Or visit [braumeister.org][braumeister] to browse packages online.
<add>4. Or visit [`brew desc`][brew-desc] to browse and search packages from the
<add> command line.
<ide>
<ide> More Documentation
<ide> ------------------
<ide> We accept tips through [Gittip][tip].
<ide> [mxcl]:https://github.com/mxcl
<ide> [formula]:https://github.com/Homebrew/homebrew/tree/master/Library/Formula/
<ide> [braumeister]:http://braumeister.org
<add>[brew-desc]: https://github.com/telemachus/homebrew-desc
<ide> [license]:https://github.com/Homebrew/homebrew/tree/master/LICENSE.txt
<ide> [tip]:https://www.gittip.com/Homebrew/ | 1 |
Python | Python | add type annotations for roformer models | afb71b672679e57449085e4955a321db8e5705b9 | <ide><path>src/transformers/models/roformer/modeling_roformer.py
<ide>
<ide> import math
<ide> import os
<del>from typing import Optional
<add>from typing import Optional, Tuple, Union
<ide>
<ide> import numpy as np
<ide> import torch
<ide> class PreTrainedModel
<ide> )
<ide> def forward(
<ide> self,
<del> input_ids=None,
<del> attention_mask=None,
<del> token_type_ids=None,
<del> head_mask=None,
<del> inputs_embeds=None,
<del> encoder_hidden_states=None,
<del> encoder_attention_mask=None,
<del> past_key_values=None,
<del> use_cache=None,
<del> output_attentions=None,
<del> output_hidden_states=None,
<del> return_dict=None,
<del> ):
<add> input_ids: Optional[torch.LongTensor] = None,
<add> attention_mask: Optional[torch.FloatTensor] = None,
<add> token_type_ids: Optional[torch.LongTensor] = None,
<add> head_mask: Optional[torch.FloatTensor] = None,
<add> inputs_embeds: Optional[torch.FloatTensor] = None,
<add> encoder_hidden_states: Optional[torch.FloatTensor] = None,
<add> encoder_attention_mask: Optional[torch.FloatTensor] = None,
<add> past_key_values: Optional[Tuple[Tuple[torch.FloatTensor]]] = None,
<add> use_cache: Optional[bool] = None,
<add> output_attentions: Optional[bool] = None,
<add> output_hidden_states: Optional[bool] = None,
<add> return_dict: Optional[bool] = None,
<add> ) -> Union[BaseModelOutputWithPastAndCrossAttentions, Tuple[torch.Tensor]]:
<ide> r"""
<ide> encoder_hidden_states (`torch.FloatTensor` of shape `(batch_size, sequence_length, hidden_size)`, *optional*):
<ide> Sequence of hidden-states at the output of the last layer of the encoder. Used in the cross-attention if
<ide> def set_output_embeddings(self, new_embeddings):
<ide> )
<ide> def forward(
<ide> self,
<del> input_ids=None,
<del> attention_mask=None,
<del> token_type_ids=None,
<del> head_mask=None,
<del> inputs_embeds=None,
<del> encoder_hidden_states=None,
<del> encoder_attention_mask=None,
<del> labels=None,
<del> output_attentions=None,
<del> output_hidden_states=None,
<del> return_dict=None,
<del> ):
<add> input_ids: Optional[torch.LongTensor] = None,
<add> attention_mask: Optional[torch.FloatTensor] = None,
<add> token_type_ids: Optional[torch.LongTensor] = None,
<add> head_mask: Optional[torch.FloatTensor] = None,
<add> inputs_embeds: Optional[torch.FloatTensor] = None,
<add> encoder_hidden_states: Optional[torch.FloatTensor] = None,
<add> encoder_attention_mask: Optional[torch.FloatTensor] = None,
<add> labels: Optional[torch.LongTensor] = None,
<add> output_attentions: Optional[bool] = None,
<add> output_hidden_states: Optional[bool] = None,
<add> return_dict: Optional[bool] = None,
<add> ) -> Union[MaskedLMOutput, Tuple[torch.Tensor]]:
<ide> r"""
<ide> labels (`torch.LongTensor` of shape `(batch_size, sequence_length)`, *optional*):
<ide> Labels for computing the masked language modeling loss. Indices should be in `[-100, 0, ...,
<ide> def set_output_embeddings(self, new_embeddings):
<ide> @replace_return_docstrings(output_type=CausalLMOutputWithCrossAttentions, config_class=_CONFIG_FOR_DOC)
<ide> def forward(
<ide> self,
<del> input_ids=None,
<del> attention_mask=None,
<del> token_type_ids=None,
<del> inputs_embeds=None,
<del> encoder_hidden_states=None,
<del> encoder_attention_mask=None,
<del> head_mask=None,
<del> cross_attn_head_mask=None,
<del> past_key_values=None,
<del> labels=None,
<del> use_cache=None,
<del> output_attentions=None,
<del> output_hidden_states=None,
<del> return_dict=None,
<del> ):
<add> input_ids: Optional[torch.LongTensor] = None,
<add> attention_mask: Optional[torch.FloatTensor] = None,
<add> token_type_ids: Optional[torch.LongTensor] = None,
<add> inputs_embeds: Optional[torch.FloatTensor] = None,
<add> encoder_hidden_states: Optional[torch.FloatTensor] = None,
<add> encoder_attention_mask: Optional[torch.FloatTensor] = None,
<add> head_mask: Optional[torch.FloatTensor] = None,
<add> cross_attn_head_mask: Optional[torch.Tensor] = None,
<add> past_key_values: Optional[Tuple[Tuple[torch.FloatTensor]]] = None,
<add> labels: Optional[torch.LongTensor] = None,
<add> use_cache: Optional[bool] = None,
<add> output_attentions: Optional[bool] = None,
<add> output_hidden_states: Optional[bool] = None,
<add> return_dict: Optional[bool] = None,
<add> ) -> Union[CausalLMOutputWithCrossAttentions, Tuple[torch.Tensor]]:
<ide> r"""
<ide> encoder_hidden_states (`torch.FloatTensor` of shape `(batch_size, sequence_length, hidden_size)`, *optional*):
<ide> Sequence of hidden-states at the output of the last layer of the encoder. Used in the cross-attention if
<ide> def __init__(self, config):
<ide> )
<ide> def forward(
<ide> self,
<del> input_ids=None,
<del> attention_mask=None,
<del> token_type_ids=None,
<del> head_mask=None,
<del> inputs_embeds=None,
<del> labels=None,
<del> output_attentions=None,
<del> output_hidden_states=None,
<del> return_dict=None,
<del> ):
<add> input_ids: Optional[torch.LongTensor] = None,
<add> attention_mask: Optional[torch.FloatTensor] = None,
<add> token_type_ids: Optional[torch.LongTensor] = None,
<add> head_mask: Optional[torch.FloatTensor] = None,
<add> inputs_embeds: Optional[torch.FloatTensor] = None,
<add> labels: Optional[torch.LongTensor] = None,
<add> output_attentions: Optional[bool] = None,
<add> output_hidden_states: Optional[bool] = None,
<add> return_dict: Optional[bool] = None,
<add> ) -> Union[SequenceClassifierOutput, Tuple[torch.Tensor]]:
<ide> r"""
<ide> labels (`torch.LongTensor` of shape `(batch_size,)`, *optional*):
<ide> Labels for computing the sequence classification/regression loss. Indices should be in `[0, ...,
<ide> def __init__(self, config):
<ide> )
<ide> def forward(
<ide> self,
<del> input_ids=None,
<del> attention_mask=None,
<del> token_type_ids=None,
<del> head_mask=None,
<del> inputs_embeds=None,
<del> labels=None,
<del> output_attentions=None,
<del> output_hidden_states=None,
<del> return_dict=None,
<del> ):
<add> input_ids: Optional[torch.LongTensor] = None,
<add> attention_mask: Optional[torch.FloatTensor] = None,
<add> token_type_ids: Optional[torch.LongTensor] = None,
<add> head_mask: Optional[torch.FloatTensor] = None,
<add> inputs_embeds: Optional[torch.FloatTensor] = None,
<add> labels: Optional[torch.LongTensor] = None,
<add> output_attentions: Optional[bool] = None,
<add> output_hidden_states: Optional[bool] = None,
<add> return_dict: Optional[bool] = None,
<add> ) -> Union[MultipleChoiceModelOutput, Tuple[torch.Tensor]]:
<ide> r"""
<ide> labels (`torch.LongTensor` of shape `(batch_size,)`, *optional*):
<ide> Labels for computing the multiple choice classification loss. Indices should be in `[0, ...,
<ide> def __init__(self, config):
<ide> )
<ide> def forward(
<ide> self,
<del> input_ids=None,
<del> attention_mask=None,
<del> token_type_ids=None,
<del> head_mask=None,
<del> inputs_embeds=None,
<del> labels=None,
<del> output_attentions=None,
<del> output_hidden_states=None,
<del> return_dict=None,
<del> ):
<add> input_ids: Optional[torch.LongTensor] = None,
<add> attention_mask: Optional[torch.FloatTensor] = None,
<add> token_type_ids: Optional[torch.LongTensor] = None,
<add> head_mask: Optional[torch.FloatTensor] = None,
<add> inputs_embeds: Optional[torch.FloatTensor] = None,
<add> labels: Optional[torch.LongTensor] = None,
<add> output_attentions: Optional[bool] = None,
<add> output_hidden_states: Optional[bool] = None,
<add> return_dict: Optional[bool] = None,
<add> ) -> Union[TokenClassifierOutput, Tuple[torch.Tensor]]:
<ide> r"""
<ide> labels (`torch.LongTensor` of shape `(batch_size, sequence_length)`, *optional*):
<ide> Labels for computing the token classification loss. Indices should be in `[0, ..., config.num_labels - 1]`.
<ide> def __init__(self, config):
<ide> )
<ide> def forward(
<ide> self,
<del> input_ids=None,
<del> attention_mask=None,
<del> token_type_ids=None,
<del> head_mask=None,
<del> inputs_embeds=None,
<del> start_positions=None,
<del> end_positions=None,
<del> output_attentions=None,
<del> output_hidden_states=None,
<del> return_dict=None,
<del> ):
<add> input_ids: Optional[torch.LongTensor] = None,
<add> attention_mask: Optional[torch.FloatTensor] = None,
<add> token_type_ids: Optional[torch.LongTensor] = None,
<add> head_mask: Optional[torch.FloatTensor] = None,
<add> inputs_embeds: Optional[torch.FloatTensor] = None,
<add> start_positions: Optional[torch.LongTensor] = None,
<add> end_positions: Optional[torch.LongTensor] = None,
<add> output_attentions: Optional[bool] = None,
<add> output_hidden_states: Optional[bool] = None,
<add> return_dict: Optional[bool] = None,
<add> ) -> Union[QuestionAnsweringModelOutput, Tuple[torch.Tensor]]:
<ide> r"""
<ide> start_positions (`torch.LongTensor` of shape `(batch_size,)`, *optional*):
<ide> Labels for position (index) of the start of the labelled span for computing the token classification loss. | 1 |
Text | Text | fix rdoc inconsistency | 638e9e7a7a067623452af9ae2397709b21d6e1f1 | <ide><path>guides/source/plugins.md
<ide> The first step is to update the README file with detailed information about how
<ide> * How to add the functionality to the app (several examples of common use cases)
<ide> * Warnings, gotchas or tips that might help users and save them time
<ide>
<del>Once your README is solid, go through and add rdoc comments to all the methods that developers will use. It's also customary to add `# :nodoc:` comments to those parts of the code that are not included in the public API.
<add>Once your README is solid, go through and add RDoc comments to all the methods that developers will use. It's also customary to add `# :nodoc:` comments to those parts of the code that are not included in the public API.
<ide>
<ide> Once your comments are good to go, navigate to your plugin directory and run:
<ide> | 1 |
Python | Python | fix mgrid for count of 1 | 10f2827029febe95d6e72a2f8568b0595f83c66b | <ide><path>numpy/lib/index_tricks.py
<ide> def __getitem__(self,key):
<ide> start = key[k].start
<ide> if start is None: start=0
<ide> if step is None: step=1
<del> if type(step) is type(1j):
<add> if isinstance(step, complex):
<ide> size.append(int(abs(step)))
<ide> typ = float
<ide> else:
<ide> def __getitem__(self,key):
<ide> start = key[k].start
<ide> if start is None: start=0
<ide> if step is None: step=1
<del> if type(step) is type(1j):
<add> if isinstance(step, complex):
<ide> step = int(abs(step))
<del> step = (key[k].stop - start)/float(step-1)
<add> if step != 1:
<add> step = (key[k].stop - start)/float(step-1)
<ide> nn[k] = (nn[k]*step+start)
<ide> if self.sparse:
<ide> slobj = [_nx.newaxis]*len(size)
<ide> def __getitem__(self,key):
<ide> stop = key.stop
<ide> start = key.start
<ide> if start is None: start = 0
<del> if type(step) is type(1j):
<add> if isinstance(step, complex):
<ide> step = abs(step)
<ide> length = int(step)
<del> step = (key.stop-start)/float(step-1)
<add> if step != 1:
<add> step = (key.stop-start)/float(step-1)
<ide> stop = key.stop+step
<ide> return _nx.arange(0, length,1, float)*step + start
<ide> else: | 1 |
Ruby | Ruby | convert audit test to spec | 9e31b51cb0f14ca8e9491de90248532fc44f123f | <ide><path>Library/Homebrew/cask/spec/cask/cli/audit_spec.rb
<add>require "spec_helper"
<add>
<add>describe Hbc::CLI::Audit do
<add> let(:auditor) { double }
<add> let(:cask) { double }
<add>
<add> describe "selection of Casks to audit" do
<add> it "audits all Casks if no tokens are given" do
<add> allow(Hbc).to receive(:all).and_return([cask, cask])
<add>
<add> expect(auditor).to receive(:audit).twice
<add>
<add> run_audit([], auditor)
<add> end
<add>
<add> it "audits specified Casks if tokens are given" do
<add> cask_token = "nice-app"
<add> expect(Hbc).to receive(:load).with(cask_token).and_return(cask)
<add>
<add> expect(auditor).to receive(:audit).with(cask, audit_download: false, check_token_conflicts: false)
<add>
<add> run_audit([cask_token], auditor)
<add> end
<add> end
<add>
<add> describe "rules for downloading a Cask" do
<add> it "does not download the Cask per default" do
<add> allow(Hbc).to receive(:load).and_return(cask)
<add> expect(auditor).to receive(:audit).with(cask, audit_download: false, check_token_conflicts: false)
<add>
<add> run_audit(["casktoken"], auditor)
<add> end
<add>
<add> it "download a Cask if --download flag is set" do
<add> allow(Hbc).to receive(:load).and_return(cask)
<add> expect(auditor).to receive(:audit).with(cask, audit_download: true, check_token_conflicts: false)
<add>
<add> run_audit(["casktoken", "--download"], auditor)
<add> end
<add> end
<add>
<add> describe "rules for checking token conflicts" do
<add> it "does not check for token conflicts per default" do
<add> allow(Hbc).to receive(:load).and_return(cask)
<add> expect(auditor).to receive(:audit).with(cask, audit_download: false, check_token_conflicts: false)
<add>
<add> run_audit(["casktoken"], auditor)
<add> end
<add>
<add> it "checks for token conflicts if --token-conflicts flag is set" do
<add> allow(Hbc).to receive(:load).and_return(cask)
<add> expect(auditor).to receive(:audit).with(cask, audit_download: false, check_token_conflicts: true)
<add>
<add> run_audit(["casktoken", "--token-conflicts"], auditor)
<add> end
<add> end
<add>
<add> def run_audit(args, auditor)
<add> Hbc::CLI::Audit.new(args, auditor).run
<add> end
<add>end
<ide><path>Library/Homebrew/cask/test/cask/cli/audit_test.rb
<del>require "test_helper"
<del>
<del>describe Hbc::CLI::Audit do
<del> let(:auditor) { mock }
<del> let(:cask) { mock }
<del>
<del> describe "selection of Casks to audit" do
<del> it "audits all Casks if no tokens are given" do
<del> Hbc.stub :all, [cask, cask] do
<del> auditor.expects(:audit).times(2)
<del>
<del> run_audit([], auditor)
<del> end
<del> end
<del>
<del> it "audits specified Casks if tokens are given" do
<del> cask_token = "nice-app"
<del> Hbc.expects(:load).with(cask_token).returns(cask)
<del> auditor.expects(:audit).with(cask, audit_download: false, check_token_conflicts: false)
<del>
<del> run_audit([cask_token], auditor)
<del> end
<del> end
<del>
<del> describe "rules for downloading a Cask" do
<del> it "does not download the Cask per default" do
<del> Hbc.stub :load, cask do
<del> auditor.expects(:audit).with(cask, audit_download: false, check_token_conflicts: false)
<del>
<del> run_audit(["casktoken"], auditor)
<del> end
<del> end
<del>
<del> it "download a Cask if --download flag is set" do
<del> Hbc.stub :load, cask do
<del> auditor.expects(:audit).with(cask, audit_download: true, check_token_conflicts: false)
<del>
<del> run_audit(["casktoken", "--download"], auditor)
<del> end
<del> end
<del> end
<del>
<del> describe "rules for checking token conflicts" do
<del> it "does not check for token conflicts per default" do
<del> Hbc.stub :load, cask do
<del> auditor.expects(:audit).with(cask, audit_download: false, check_token_conflicts: false)
<del>
<del> run_audit(["casktoken"], auditor)
<del> end
<del> end
<del>
<del> it "checks for token conflicts if --token-conflicts flag is set" do
<del> Hbc.stub :load, cask do
<del> auditor.expects(:audit).with(cask, audit_download: false, check_token_conflicts: true)
<del>
<del> run_audit(["casktoken", "--token-conflicts"], auditor)
<del> end
<del> end
<del> end
<del>
<del> def run_audit(args, auditor)
<del> Hbc::CLI::Audit.new(args, auditor).run
<del> end
<del>end | 2 |
Javascript | Javascript | add missing methods | 7d0c256ecd0fc22126090c4aeb18fd2c9fff2baa | <ide><path>src/jqLite.js
<ide> * - [css()](http://api.jquery.com/css/)
<ide> * - [data()](http://api.jquery.com/data/)
<ide> * - [eq()](http://api.jquery.com/eq/)
<add> * - [find()](http://api.jquery.com/find/) - Limited to lookups by tag name.
<ide> * - [hasClass()](http://api.jquery.com/hasClass/)
<add> * - [html()](http://api.jquery.com/html/)
<add> * - [next()](http://api.jquery.com/next/)
<ide> * - [parent()](http://api.jquery.com/parent/)
<add> * - [prepend()](http://api.jquery.com/prepend/)
<ide> * - [prop()](http://api.jquery.com/prop/)
<add> * - [ready()](http://api.jquery.com/ready/)
<ide> * - [remove()](http://api.jquery.com/remove/)
<ide> * - [removeAttr()](http://api.jquery.com/removeAttr/)
<ide> * - [removeClass()](http://api.jquery.com/removeClass/)
<ide> * - [removeData()](http://api.jquery.com/removeData/)
<ide> * - [replaceWith()](http://api.jquery.com/replaceWith/)
<ide> * - [text()](http://api.jquery.com/text/)
<del> * - [trigger()](http://api.jquery.com/trigger/)
<add> * - [toggleClass()](http://api.jquery.com/toggleClass/)
<ide> * - [unbind()](http://api.jquery.com/unbind/)
<add> * - [val()](http://api.jquery.com/val/)
<ide> *
<ide> * ## In addtion to the above, Angular privides an additional method to both jQuery and jQuery lite:
<ide> *
<ide> * - `scope()` - retrieves the current Angular scope of the element.
<add> * - `inheritedData()` - same as `data()`, but walks up the DOM until a value is found or the top
<add> * parent element is reached.
<ide> *
<ide> * @param {string|DOMElement} element HTML string or DOMElement to be wrapped into jQuery.
<ide> * @returns {Object} jQuery object. | 1 |
PHP | PHP | add iterator annotation | f132aeed64d58593e095b5f3de210e0b345e15c2 | <ide><path>src/ORM/Table.php
<ide> public function association($name)
<ide> /**
<ide> * Get the associations collection for this table.
<ide> *
<del> * @return \Cake\ORM\AssociationCollection The collection of association objects.
<add> * @return \Cake\ORM\AssociationCollection|\Cake\ORM\Association[] The collection of association objects.
<ide> */
<ide> public function associations()
<ide> { | 1 |
Text | Text | add example for proc-based route to routing guide | 71e10a00e31ad433ea44f66a07a95044e59b5603 | <ide><path>guides/source/routing.md
<ide> As long as `MyRackApp` responds to `call` and returns a `[status, headers, body]
<ide>
<ide> NOTE: For the curious, `'articles#index'` actually expands out to `ArticlesController.action(:index)`, which returns a valid Rack application.
<ide>
<add>NOTE: Since procs/lambdas are objects that happen to respond to `call` you can implement very simple routes (e.g. for health checks) inline:<br>`get '/health', to: ->(env) { [204, {}, ''] }`
<add>
<ide> If you specify a Rack application as the endpoint for a matcher, remember that
<ide> the route will be unchanged in the receiving application. With the following
<ide> route your Rack application should expect the route to be `/admin`: | 1 |
Python | Python | change the identifier | 2004246f752825816dfaa187a6367d3a47a5cc01 | <ide><path>test/test.py
<ide> # The local web server uses the git repo as the document root.
<ide> DOC_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__),".."))
<ide>
<del>ANAL = True
<add>GIT_CLONE_CHECK = True
<ide> DEFAULT_MANIFEST_FILE = 'test_manifest.json'
<ide> EQLOG_FILE = 'eq.log'
<ide> BROWSERLOG_FILE = 'browser.log'
<ide> def verifyPDFs(manifestList):
<ide>
<ide> def setUp(options):
<ide> # Only serve files from a pdf.js clone
<del> assert not ANAL or os.path.isfile('../src/pdf.js') and os.path.isdir('../.git')
<add> assert not GIT_CLONE_CHECK or os.path.isfile('../src/pdf.js') and os.path.isdir('../.git')
<ide>
<ide> if options.masterMode and os.path.isdir(TMPDIR):
<ide> print 'Temporary snapshot dir tmp/ is still around.' | 1 |
Java | Java | remove trailing whitespace | 98808347ca4e1c0fffa3430321e701bc4c297257 | <ide><path>spring-expression/src/main/java/org/springframework/expression/spel/support/ReflectiveMethodResolver.java
<ide> public class ReflectiveMethodResolver implements MethodResolver {
<ide>
<ide> private Map<Class<?>, MethodFilter> filters = null;
<ide>
<del> // Using distance will ensure a more accurate match is discovered,
<add> // Using distance will ensure a more accurate match is discovered,
<ide> // more closely following the Java rules.
<ide> private boolean useDistance = false;
<ide>
<ide> public ReflectiveMethodResolver() {
<ide> * This constructors allows the ReflectiveMethodResolver to be configured such that it will
<ide> * use a distance computation to check which is the better of two close matches (when there
<ide> * are multiple matches). Using the distance computation is intended to ensure matches
<del> * are more closely representative of what a Java compiler would do when taking into
<add> * are more closely representative of what a Java compiler would do when taking into
<ide> * account boxing/unboxing and whether the method candidates are declared to handle a
<ide> * supertype of the type (of the argument) being passed in.
<ide> * @param useDistance true if distance computation should be used when calculating matches
<ide><path>spring-expression/src/main/java/org/springframework/expression/spel/support/ReflectivePropertyAccessor.java
<ide>
<ide> /**
<ide> * Simple PropertyAccessor that uses reflection to access properties for reading and writing. A property can be accessed
<del> * if it is accessible as a field on the object or through a getter (if being read) or a setter (if being written).
<del> *
<add> * if it is accessible as a field on the object or through a getter (if being read) or a setter (if being written).
<add> *
<ide> * @author Andy Clement
<ide> * @author Juergen Hoeller
<ide> * @since 3.0
<ide> public class ReflectivePropertyAccessor implements PropertyAccessor {
<ide> protected final Map<CacheKey, InvokerPair> readerCache = new ConcurrentHashMap<CacheKey, InvokerPair>();
<ide>
<ide> protected final Map<CacheKey, Member> writerCache = new ConcurrentHashMap<CacheKey, Member>();
<del>
<add>
<ide> protected final Map<CacheKey, TypeDescriptor> typeDescriptorCache = new ConcurrentHashMap<CacheKey, TypeDescriptor>();
<ide>
<ide>
<ide> public boolean canRead(EvaluationContext context, Object target, String name) th
<ide> Field field = findField(name, type, target instanceof Class);
<ide> if (field != null) {
<ide> TypeDescriptor typeDescriptor = new TypeDescriptor(field);
<del> this.readerCache.put(cacheKey, new InvokerPair(field,typeDescriptor));
<add> this.readerCache.put(cacheKey, new InvokerPair(field,typeDescriptor));
<ide> this.typeDescriptorCache.put(cacheKey, typeDescriptor);
<ide> return true;
<ide> }
<ide> public void write(EvaluationContext context, Object target, String name, Object
<ide>
<ide> throw new AccessException("Neither setter nor field found for property '" + name + "'");
<ide> }
<del>
<add>
<ide> private TypeDescriptor getTypeDescriptor(EvaluationContext context, Object target, String name) {
<ide> if (target == null) {
<ide> return null;
<ide> protected Field findField(String name, Class<?> clazz, boolean mustBeStatic) {
<ide> }
<ide> return null;
<ide> }
<del>
<add>
<ide> /**
<ide> * Captures the member (method/field) to call reflectively to access a property value and the type descriptor for the
<ide> * value returned by the reflective call.
<ide> */
<ide> private static class InvokerPair {
<del>
<add>
<ide> final Member member;
<del>
<add>
<ide> final TypeDescriptor typeDescriptor;
<ide>
<ide> public InvokerPair(Member member, TypeDescriptor typeDescriptor) {
<ide> this.member = member;
<ide> this.typeDescriptor = typeDescriptor;
<del> }
<del>
<add> }
<add>
<ide> }
<ide>
<ide> private static class CacheKey {
<ide> public int hashCode() {
<ide> }
<ide> }
<ide>
<del> /**
<add> /**
<ide> * Attempt to create an optimized property accessor tailored for a property of a particular name on
<del> * a particular class. The general ReflectivePropertyAccessor will always work but is not optimal
<add> * a particular class. The general ReflectivePropertyAccessor will always work but is not optimal
<ide> * due to the need to lookup which reflective member (method/field) to use each time read() is called.
<ide> * This method will just return the ReflectivePropertyAccessor instance if it is unable to build
<ide> * something more optimal.
<ide> public PropertyAccessor createOptimalAccessor(EvaluationContext eContext, Object
<ide> }
<ide> return this;
<ide> }
<del>
<add>
<ide> /**
<del> * An optimized form of a PropertyAccessor that will use reflection but only knows how to access a particular property
<del> * on a particular class. This is unlike the general ReflectivePropertyResolver which manages a cache of methods/fields that
<add> * An optimized form of a PropertyAccessor that will use reflection but only knows how to access a particular property
<add> * on a particular class. This is unlike the general ReflectivePropertyResolver which manages a cache of methods/fields that
<ide> * may be invoked to access different properties on different classes. This optimal accessor exists because looking up
<ide> * the appropriate reflective object by class/name on each read is not cheap.
<ide> */
<ide> static class OptimalPropertyAccessor implements PropertyAccessor {
<ide> private final Member member;
<ide> private final TypeDescriptor typeDescriptor;
<ide> private final boolean needsToBeMadeAccessible;
<del>
<add>
<ide> OptimalPropertyAccessor(InvokerPair target) {
<del> this.member = target.member;
<add> this.member = target.member;
<ide> this.typeDescriptor = target.typeDescriptor;
<ide> if (this.member instanceof Field) {
<ide> Field field = (Field)member;
<del> needsToBeMadeAccessible = (!Modifier.isPublic(field.getModifiers()) || !Modifier.isPublic(field.getDeclaringClass().getModifiers()))
<add> needsToBeMadeAccessible = (!Modifier.isPublic(field.getModifiers()) || !Modifier.isPublic(field.getDeclaringClass().getModifiers()))
<ide> && !field.isAccessible();
<ide> }
<ide> else {
<ide> static class OptimalPropertyAccessor implements PropertyAccessor {
<ide> public Class[] getSpecificTargetClasses() {
<ide> throw new UnsupportedOperationException("Should not be called on an OptimalPropertyAccessor");
<ide> }
<del>
<add>
<ide> public boolean canRead(EvaluationContext context, Object target, String name) throws AccessException {
<ide> if (target == null) {
<ide> return false;
<ide> public TypedValue read(EvaluationContext context, Object target, String name) th
<ide> catch (Exception ex) {
<ide> throw new AccessException("Unable to access property '" + name + "' through getter", ex);
<ide> }
<del> }
<add> }
<ide> if (member instanceof Field) {
<ide> try {
<ide> if (needsToBeMadeAccessible) {
<ide> public TypedValue read(EvaluationContext context, Object target, String name) th
<ide> public boolean canWrite(EvaluationContext context, Object target, String name) throws AccessException {
<ide> throw new UnsupportedOperationException("Should not be called on an OptimalPropertyAccessor");
<ide> }
<del>
<add>
<ide> public void write(EvaluationContext context, Object target, String name, Object newValue)
<ide> throws AccessException {
<ide> throw new UnsupportedOperationException("Should not be called on an OptimalPropertyAccessor");
<ide><path>spring-expression/src/test/java/org/springframework/expression/spel/MethodInvocationTests.java
<ide>
<ide> /**
<ide> * Tests invocation of methods.
<del> *
<add> *
<ide> * @author Andy Clement
<ide> */
<ide> public class MethodInvocationTests extends ExpressionTestCase {
<ide> public void testArgumentConversion01() {
<ide> evaluate("new String('hello 2.0 to you').startsWith(7.0d)", false, Boolean.class);
<ide> evaluate("new String('7.0 foobar').startsWith(7.0d)", true, Boolean.class);
<ide> }
<del>
<add>
<ide> @Test
<ide> public void testMethodThrowingException_SPR6760() {
<ide> // Test method on inventor: throwException()
<ide> // On 1 it will throw an IllegalArgumentException
<ide> // On 2 it will throw a RuntimeException
<ide> // On 3 it will exit normally
<ide> // In each case it increments the Inventor field 'counter' when invoked
<del>
<add>
<ide> SpelExpressionParser parser = new SpelExpressionParser();
<ide> Expression expr = parser.parseExpression("throwException(#bar)");
<ide>
<ide> public void testMethodThrowingException_SPR6760() {
<ide> o = expr.getValue(eContext);
<ide> Assert.assertEquals("London", o);
<ide> // That confirms the logic to mark the cached reference stale and retry is working
<del>
<del>
<add>
<add>
<ide> // Now let's cause the method to exit via exception and ensure it doesn't cause
<ide> // a retry.
<del>
<add>
<ide> // First, switch back to throwException(int)
<ide> eContext.setVariable("bar",3);
<ide> o = expr.getValue(eContext);
<ide> Assert.assertEquals(3, o);
<ide> Assert.assertEquals(2,parser.parseExpression("counter").getValue(eContext));
<ide>
<del>
<add>
<ide> // Now cause it to throw an exception:
<ide> eContext.setVariable("bar",1);
<ide> try {
<ide> public void testMethodThrowingException_SPR6760() {
<ide> // If counter is 5 then the method got called twice!
<ide> Assert.assertEquals(4,parser.parseExpression("counter").getValue(eContext));
<ide> }
<del>
<add>
<ide> /**
<ide> * Check on first usage (when the cachedExecutor in MethodReference is null) that the exception is not wrapped.
<ide> */
<ide> public void testMethodThrowingException_SPR6941() {
<ide> // On 2 it will throw a RuntimeException
<ide> // On 3 it will exit normally
<ide> // In each case it increments the Inventor field 'counter' when invoked
<del>
<add>
<ide> SpelExpressionParser parser = new SpelExpressionParser();
<ide> Expression expr = parser.parseExpression("throwException(#bar)");
<del>
<add>
<ide> eContext.setVariable("bar",2);
<ide> try {
<ide> expr.getValue(eContext);
<ide> public void testMethodThrowingException_SPR6941() {
<ide> // normal
<ide> }
<ide> }
<del>
<add>
<ide> @Test
<ide> public void testMethodThrowingException_SPR6941_2() {
<ide> // Test method on inventor: throwException()
<ide> // On 1 it will throw an IllegalArgumentException
<ide> // On 2 it will throw a RuntimeException
<ide> // On 3 it will exit normally
<ide> // In each case it increments the Inventor field 'counter' when invoked
<del>
<add>
<ide> SpelExpressionParser parser = new SpelExpressionParser();
<ide> Expression expr = parser.parseExpression("throwException(#bar)");
<del>
<add>
<ide> eContext.setVariable("bar",4);
<ide> try {
<ide> expr.getValue(eContext);
<ide> public void testMethodThrowingException_SPR6941_2() {
<ide> }
<ide> Assert.fail("Should not be a SpelEvaluationException");
<ide> }
<del>
<add>
<ide> @Test
<ide> public void testMethodFiltering_SPR6764() {
<ide> SpelExpressionParser parser = new SpelExpressionParser();
<ide> StandardEvaluationContext context = new StandardEvaluationContext();
<ide> context.setRootObject(new TestObject());
<ide> LocalFilter filter = new LocalFilter();
<ide> context.registerMethodFilter(TestObject.class,filter);
<del>
<add>
<ide> // Filter will be called but not do anything, so first doit() will be invoked
<ide> SpelExpression expr = (SpelExpression) parser.parseExpression("doit(1)");
<ide> String result = expr.getValue(context,String.class);
<ide> Assert.assertEquals("1",result);
<ide> Assert.assertTrue(filter.filterCalled);
<del>
<add>
<ide> // Filter will now remove non @Anno annotated methods
<ide> filter.removeIfNotAnnotated = true;
<ide> filter.filterCalled = false;
<ide> expr = (SpelExpression) parser.parseExpression("doit(1)");
<ide> result = expr.getValue(context,String.class);
<ide> Assert.assertEquals("double 1.0",result);
<ide> Assert.assertTrue(filter.filterCalled);
<del>
<add>
<ide> // check not called for other types
<ide> filter.filterCalled=false;
<ide> context.setRootObject(new String("abc"));
<ide> expr = (SpelExpression) parser.parseExpression("charAt(0)");
<ide> result = expr.getValue(context,String.class);
<ide> Assert.assertEquals("a",result);
<ide> Assert.assertFalse(filter.filterCalled);
<del>
<add>
<ide> // check de-registration works
<ide> filter.filterCalled = false;
<ide> context.registerMethodFilter(TestObject.class,null);//clear filter
<ide> public void testMethodFiltering_SPR6764() {
<ide> Assert.assertEquals("1",result);
<ide> Assert.assertFalse(filter.filterCalled);
<ide> }
<del>
<add>
<ide> // Simple filter
<ide> static class LocalFilter implements MethodFilter {
<del>
<add>
<ide> public boolean removeIfNotAnnotated = false;
<del>
<add>
<ide> public boolean filterCalled = false;
<del>
<add>
<ide> private boolean isAnnotated(Method m) {
<ide> Annotation[] annos = m.getAnnotations();
<ide> if (annos==null) {
<ide> public List<Method> filter(List<Method> methods) {
<ide> }
<ide> return methods;
<ide> }
<del>
<add>
<ide> }
<del>
<add>
<ide> @Retention(RetentionPolicy.RUNTIME)
<ide> @interface Anno {}
<del>
<add>
<ide> class TestObject {
<ide> public int doit(int i) {
<ide> return i;
<ide> }
<del>
<add>
<ide> @Anno
<ide> public String doit(double d) {
<ide> return "double "+d;
<ide> }
<del>
<add>
<ide> }
<del>
<add>
<ide> @Test
<ide> public void testAddingMethodResolvers() {
<ide> StandardEvaluationContext ctx = new StandardEvaluationContext();
<del>
<add>
<ide> // reflective method accessor is the only one by default
<ide> List<MethodResolver> methodResolvers = ctx.getMethodResolvers();
<ide> Assert.assertEquals(1,methodResolvers.size());
<del>
<add>
<ide> MethodResolver dummy = new DummyMethodResolver();
<ide> ctx.addMethodResolver(dummy);
<ide> Assert.assertEquals(2,ctx.getMethodResolvers().size());
<del>
<add>
<ide> List<MethodResolver> copy = new ArrayList<MethodResolver>();
<ide> copy.addAll(ctx.getMethodResolvers());
<ide> Assert.assertTrue(ctx.removeMethodResolver(dummy));
<ide> Assert.assertFalse(ctx.removeMethodResolver(dummy));
<ide> Assert.assertEquals(1,ctx.getMethodResolvers().size());
<del>
<add>
<ide> ctx.setMethodResolvers(copy);
<ide> Assert.assertEquals(2,ctx.getMethodResolvers().size());
<ide> }
<del>
<add>
<ide> static class DummyMethodResolver implements MethodResolver {
<ide>
<ide> public MethodExecutor resolve(EvaluationContext context, Object targetObject, String name,
<ide> List<TypeDescriptor> argumentTypes) throws AccessException {
<ide> throw new UnsupportedOperationException("Auto-generated method stub");
<ide> }
<del>
<add>
<ide> }
<ide>
<ide>
<ide> public void testVarargsInvocation02() {
<ide> evaluate("aVarargsMethod2(2,'a',3.0d)", 4, Integer.class);
<ide> // evaluate("aVarargsMethod2(8,new String[]{'a','b','c'})", 11, Integer.class);
<ide> }
<del>
<add>
<ide> @Test
<ide> public void testInvocationOnNullContextObject() {
<ide> evaluateAndCheckError("null.toString()",SpelMessage.METHOD_CALL_ON_NULL_OBJECT_NOT_ALLOWED);
<ide><path>spring-expression/src/test/java/org/springframework/expression/spel/PropertyAccessTests.java
<ide>
<ide> /**
<ide> * Tests accessing of properties.
<del> *
<add> *
<ide> * @author Andy Clement
<ide> */
<ide> public class PropertyAccessTests extends ExpressionTestCase {
<ide> public void testNonExistentPropertiesAndMethods() {
<ide> // name is ok but foobar does not exist:
<ide> evaluateAndCheckError("name.foobar", SpelMessage.PROPERTY_OR_FIELD_NOT_READABLE, 5);
<ide> }
<del>
<add>
<ide> /**
<del> * The standard reflection resolver cannot find properties on null objects but some
<add> * The standard reflection resolver cannot find properties on null objects but some
<ide> * supplied resolver might be able to - so null shouldn't crash the reflection resolver.
<ide> */
<ide> @Test
<ide> public void testAddingSpecificPropertyAccessor() throws Exception {
<ide> // System.out.println(e.getMessage());
<ide> }
<ide> }
<del>
<add>
<ide> @Test
<ide> public void testAddingRemovingAccessors() {
<ide> StandardEvaluationContext ctx = new StandardEvaluationContext();
<del>
<add>
<ide> // reflective property accessor is the only one by default
<ide> List<PropertyAccessor> propertyAccessors = ctx.getPropertyAccessors();
<ide> Assert.assertEquals(1,propertyAccessors.size());
<del>
<add>
<ide> StringyPropertyAccessor spa = new StringyPropertyAccessor();
<ide> ctx.addPropertyAccessor(spa);
<ide> Assert.assertEquals(2,ctx.getPropertyAccessors().size());
<del>
<add>
<ide> List<PropertyAccessor> copy = new ArrayList<PropertyAccessor>();
<ide> copy.addAll(ctx.getPropertyAccessors());
<ide> Assert.assertTrue(ctx.removePropertyAccessor(spa));
<ide> Assert.assertFalse(ctx.removePropertyAccessor(spa));
<ide> Assert.assertEquals(1,ctx.getPropertyAccessors().size());
<del>
<add>
<ide> ctx.setPropertyAccessors(copy);
<ide> Assert.assertEquals(2,ctx.getPropertyAccessors().size());
<ide> } | 4 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.