language
stringclasses 1
value | owner
stringlengths 2
15
| repo
stringlengths 2
21
| sha
stringlengths 45
45
| message
stringlengths 7
36.3k
| path
stringlengths 1
199
| patch
stringlengths 15
102k
| is_multipart
bool 2
classes |
|---|---|---|---|---|---|---|---|
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/ember/tests/routing/decoupled_basic_test.js
|
@@ -2035,17 +2035,27 @@ moduleFor(
return run(router, 'transitionTo', 'b', 'b-1');
})
.then(() => {
- assert.deepEqual(calls, [['setup', 'a'], ['setup', 'b']]);
+ assert.deepEqual(calls, [
+ ['setup', 'a'],
+ ['setup', 'b'],
+ ]);
calls.length = 0;
return run(router, 'transitionTo', 'c', 'c-1');
})
.then(() => {
- assert.deepEqual(calls, [['reset', 'b'], ['setup', 'c']]);
+ assert.deepEqual(calls, [
+ ['reset', 'b'],
+ ['setup', 'c'],
+ ]);
calls.length = 0;
return run(router, 'transitionTo', 'out');
})
.then(() => {
- assert.deepEqual(calls, [['reset', 'c'], ['reset', 'a'], ['setup', 'out']]);
+ assert.deepEqual(calls, [
+ ['reset', 'c'],
+ ['reset', 'a'],
+ ['setup', 'out'],
+ ]);
});
}
| true |
Other
|
emberjs
|
ember.js
|
68f4483df86c7a2e42739c3d99c87d34fa445edd.json
|
Apply new prettier autofix
|
packages/internal-test-helpers/index.js
|
@@ -18,9 +18,7 @@ export { default as QueryParamTestCase } from './lib/test-cases/query-param';
export { default as RenderingTestCase } from './lib/test-cases/rendering';
export { default as RouterTestCase } from './lib/test-cases/router';
export { default as AutobootApplicationTestCase } from './lib/test-cases/autoboot-application';
-export {
- default as DefaultResolverApplicationTestCase,
-} from './lib/test-cases/default-resolver-application';
+export { default as DefaultResolverApplicationTestCase } from './lib/test-cases/default-resolver-application';
export {
default as TestResolver,
| true |
Other
|
emberjs
|
ember.js
|
d46bbf9a4ff3cf4a5a36044dc98dd924f76350a1.json
|
Upgrade prettier to fix parse error
|
package.json
|
@@ -119,7 +119,7 @@
"eslint-plugin-ember-internal": "^1.1.1",
"eslint-plugin-import": "^2.20.2",
"eslint-plugin-node": "^11.1.0",
- "eslint-plugin-prettier": "^3.1.3",
+ "eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-qunit": "^4.0.0",
"execa": "^2.0.4",
"express": "^4.17.1",
@@ -132,7 +132,7 @@
"lodash.uniq": "^4.5.0",
"mkdirp": "^1.0.4",
"mocha": "^7.1.2",
- "prettier": "^1.18.2",
+ "prettier": "^1.19.1",
"puppeteer": "^3.0.4",
"qunit": "^2.10.0",
"rollup-plugin-commonjs": "^9.3.4",
| true |
Other
|
emberjs
|
ember.js
|
d46bbf9a4ff3cf4a5a36044dc98dd924f76350a1.json
|
Upgrade prettier to fix parse error
|
yarn.lock
|
@@ -3918,10 +3918,10 @@ eslint-plugin-node@^11.1.0:
resolve "^1.10.1"
semver "^6.1.0"
-eslint-plugin-prettier@^3.1.3:
- version "3.1.3"
- resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.1.3.tgz#ae116a0fc0e598fdae48743a4430903de5b4e6ca"
- integrity sha512-+HG5jmu/dN3ZV3T6eCD7a4BlAySdN7mLIbJYo0z1cFQuI+r2DiTJEFeF68ots93PsnrMxbzIZ2S/ieX+mkrBeQ==
+eslint-plugin-prettier@^3.1.4:
+ version "3.1.4"
+ resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-3.1.4.tgz#168ab43154e2ea57db992a2cd097c828171f75c2"
+ integrity sha512-jZDa8z76klRqo+TdGDTFJSavwbnWK2ZpqGKNZ+VvweMW516pDUMmQ2koXvxEE4JhzNvTv+radye/bWGBmA6jmg==
dependencies:
prettier-linter-helpers "^1.0.0"
@@ -7350,10 +7350,10 @@ prettier-linter-helpers@^1.0.0:
dependencies:
fast-diff "^1.1.2"
-prettier@^1.18.2:
- version "1.18.2"
- resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.18.2.tgz#6823e7c5900017b4bd3acf46fe9ac4b4d7bda9ea"
- integrity sha512-OeHeMc0JhFE9idD4ZdtNibzY0+TPHSpSSb9h8FqtP+YnoZZ1sl8Vc9b1sasjfymH3SonAF4QcA2+mzHPhMvIiw==
+prettier@^1.19.1:
+ version "1.19.1"
+ resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.19.1.tgz#f7d7f5ff8a9cd872a7be4ca142095956a60797cb"
+ integrity sha512-s7PoyDv/II1ObgQunCbB9PdLmUcBZcnWOcxDh7O0N/UwDEsHyqkW+Qh28jW+mVuCdx7gLB0BotYI1Y6uI9iyew==
pretty-ms@^3.1.0:
version "3.1.0"
| true |
Other
|
emberjs
|
ember.js
|
d654a6e588451503f8b2518d6d31ed264f95f634.json
|
Add v3.22.0-beta.3 to CHANGELOG
(cherry picked from commit 676f728fbe9a5300a7c3d0fcd24f5b23af1ca7d9)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.22.0-beta.3 (September 09, 2020)
+
+- [#19124](https://github.com/emberjs/ember.js/pull/19124) Fix rendering engine usage within a `fastboot` sandbox
+
### v3.22.0-beta.2 (August 31, 2020)
- [#19106](https://github.com/emberjs/ember.js/pull/19106) [BUGFIX] Ensure `destroy` methods on `CoreObject` are invoked.
| false |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
blueprints/initializer/index.js
|
@@ -1,5 +1,5 @@
'use strict';
module.exports = {
- description: 'Generates an initializer.'
+ description: 'Generates an initializer.',
};
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
blueprints/mixin/index.js
|
@@ -1,7 +1,5 @@
'use strict';
-const path = require('path');
-
module.exports = {
description: 'Generates a mixin.',
normalizeEntityName: function(entityName) {
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
blueprints/service/index.js
|
@@ -1,6 +1,5 @@
'use strict';
-const path = require('path');
const useEditionDetector = require('../edition-detector');
module.exports = useEditionDetector({
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
blueprints/util/index.js
|
@@ -1,7 +1,5 @@
'use strict';
-const path = require('path');
-
module.exports = {
description: 'Generates a simple utility module/function.',
normalizeEntityName: function(entityName) {
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/acceptance-test-test.js
|
@@ -142,5 +142,4 @@ describe('Blueprint: acceptance-test', function() {
});
});
});
-
});
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/controller-test.js
|
@@ -7,7 +7,6 @@ const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
const setupPodConfig = blueprintHelpers.setupPodConfig;
const modifyPackages = blueprintHelpers.modifyPackages;
-const expectError = require('../helpers/expect-error');
const chai = require('ember-cli-blueprint-test-helpers/chai');
const expect = chai.expect;
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/helper-test-test.js
|
@@ -167,5 +167,4 @@ describe('Blueprint: helper-test', function() {
});
});
});
-
});
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/initializer-test.js
|
@@ -6,7 +6,6 @@ const emberNew = blueprintHelpers.emberNew;
const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
const setupPodConfig = blueprintHelpers.setupPodConfig;
const modifyPackages = blueprintHelpers.modifyPackages;
-const expectError = require('../helpers/expect-error');
const chai = require('ember-cli-blueprint-test-helpers/chai');
const expect = chai.expect;
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/instance-initializer-test-test.js
|
@@ -112,5 +112,4 @@ describe('Blueprint: instance-initializer-test', function() {
});
});
});
-
});
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/instance-initializer-test.js
|
@@ -6,7 +6,6 @@ const emberNew = blueprintHelpers.emberNew;
const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
const setupPodConfig = blueprintHelpers.setupPodConfig;
const modifyPackages = blueprintHelpers.modifyPackages;
-const expectError = require('../helpers/expect-error');
const chai = require('ember-cli-blueprint-test-helpers/chai');
const expect = chai.expect;
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/mixin-test.js
|
@@ -5,7 +5,6 @@ const setupTestHooks = blueprintHelpers.setupTestHooks;
const emberNew = blueprintHelpers.emberNew;
const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
const setupPodConfig = blueprintHelpers.setupPodConfig;
-const expectError = require('../helpers/expect-error');
const EOL = require('os').EOL;
const chai = require('ember-cli-blueprint-test-helpers/chai');
@@ -159,7 +158,6 @@ describe('Blueprint: mixin', function() {
});
});
-
describe('in addon', function() {
beforeEach(function() {
return emberNew({ target: 'addon' });
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/template-test.js
|
@@ -5,7 +5,6 @@ const setupTestHooks = blueprintHelpers.setupTestHooks;
const emberNew = blueprintHelpers.emberNew;
const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
const setupPodConfig = blueprintHelpers.setupPodConfig;
-const expectError = require('../helpers/expect-error');
const chai = require('ember-cli-blueprint-test-helpers/chai');
const expect = chai.expect;
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/util-test-test.js
|
@@ -108,5 +108,4 @@ describe('Blueprint: util-test', function() {
});
});
});
-
});
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
node-tests/blueprints/util-test.js
|
@@ -6,7 +6,6 @@ const emberNew = blueprintHelpers.emberNew;
const emberGenerateDestroy = blueprintHelpers.emberGenerateDestroy;
const setupPodConfig = blueprintHelpers.setupPodConfig;
const modifyPackages = blueprintHelpers.modifyPackages;
-const expectError = require('../helpers/expect-error');
const chai = require('ember-cli-blueprint-test-helpers/chai');
const expect = chai.expect;
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
packages/@ember/-internals/container/tests/registry_test.js
|
@@ -1,10 +1,5 @@
import { Registry, privatize } from '..';
-import {
- factory,
- moduleFor,
- AbstractTestCase,
- ModuleBasedTestResolver,
-} from 'internal-test-helpers';
+import { factory, moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor(
'Registry',
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
packages/@ember/-internals/glimmer/lib/resolver.ts
|
@@ -2,9 +2,7 @@ import { privatize as P } from '@ember/-internals/container';
import { ENV } from '@ember/-internals/environment';
import { Factory, FactoryClass, LookupOptions, Owner } from '@ember/-internals/owner';
import { OwnedTemplateMeta } from '@ember/-internals/views';
-import {
- EMBER_GLIMMER_SET_COMPONENT_TEMPLATE,
-} from '@ember/canary-features';
+import { EMBER_GLIMMER_SET_COMPONENT_TEMPLATE } from '@ember/canary-features';
import { isTemplateOnlyComponent } from '@ember/component/template-only';
import { assert, deprecate } from '@ember/debug';
import { PARTIALS } from '@ember/deprecated-features';
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
packages/@ember/-internals/glimmer/tests/integration/components/local-lookup-test.js
|
@@ -1,14 +1,4 @@
-import {
- moduleFor,
- RenderingTestCase,
- ModuleBasedTestResolver,
- ApplicationTestCase,
- runTask,
-} from 'internal-test-helpers';
-
-import { compile } from 'ember-template-compiler';
-import { helper, Helper } from '@ember/-internals/glimmer';
-
+import { moduleFor, RenderingTestCase, runTask } from 'internal-test-helpers';
import { Component } from '../../utils/helpers';
class LocalLookupTest extends RenderingTestCase {
| true |
Other
|
emberjs
|
ember.js
|
4286b7be981ce7a0a66e098fe884867bf9bcc800.json
|
remove lint issues and experiment itself
|
packages/@ember/canary-features/index.ts
|
@@ -16,7 +16,6 @@ export const DEFAULT_FEATURES = {
EMBER_LIBRARIES_ISREGISTERED: null,
EMBER_IMPROVED_INSTRUMENTATION: null,
EMBER_NAMED_BLOCKS: null,
- EMBER_MODULE_UNIFICATION: false,
EMBER_CUSTOM_COMPONENT_ARG_PROXY: true,
EMBER_GLIMMER_SET_COMPONENT_TEMPLATE: true,
EMBER_ROUTING_MODEL_ARG: true,
@@ -74,7 +73,6 @@ function featureValue(value: null | boolean) {
export const EMBER_LIBRARIES_ISREGISTERED = featureValue(FEATURES.EMBER_LIBRARIES_ISREGISTERED);
export const EMBER_IMPROVED_INSTRUMENTATION = featureValue(FEATURES.EMBER_IMPROVED_INSTRUMENTATION);
export const EMBER_NAMED_BLOCKS = featureValue(FEATURES.EMBER_NAMED_BLOCKS);
-export const EMBER_MODULE_UNIFICATION = featureValue(FEATURES.EMBER_MODULE_UNIFICATION);
export const EMBER_CUSTOM_COMPONENT_ARG_PROXY = featureValue(
FEATURES.EMBER_CUSTOM_COMPONENT_ARG_PROXY
);
| true |
Other
|
emberjs
|
ember.js
|
6b4f58971096decca38849b7081a56178b83d2b1.json
|
Add v3.22.0-beta.2 to CHANGELOG
(cherry picked from commit a409f1de8396d11faf0e78b7b662370379417eb8)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.22.0-beta.2 (August 31, 2020)
+
+- [#19106](https://github.com/emberjs/ember.js/pull/19106) [BUGFIX] Ensure `destroy` methods on `CoreObject` are invoked.
+- [#19111](https://github.com/emberjs/ember.js/pull/19111) [BUGFIX] Fixes `ArrayProxy` length reactivity.
+
### v3.22.0-beta.1 (August 24, 2020)
- [#19062](https://github.com/emberjs/ember.js/pull/19062) / [#19068](https://github.com/emberjs/ember.js/pull/19068) [FEATURE] Add @ember/destroyable feature from the [Destroyables RFC](https://github.com/emberjs/rfcs/blob/master/text/0580-destroyables.md).
| false |
Other
|
emberjs
|
ember.js
|
37f8d9fa5d361dd756c4afc1b86d5a4e13cd62a4.json
|
Add v3.20.5 and v3.21.1 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -6,12 +6,22 @@
- [#18984](https://github.com/emberjs/ember.js/pull/18984) / [#19067](https://github.com/emberjs/ember.js/pull/19067) [FEATURE] Add low-level Cache API per [Autotracking Memoization RFC](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md)
- [#19086](https://github.com/emberjs/ember.js/pull/19086) [FEATURE] Pass transition object to activate/deactivate hooks and events
+### v3.21.1 (August 28, 2020)
+
+- [#19106](https://github.com/emberjs/ember.js/pull/19106) [BUGFIX] Ensure `destroy` methods on `CoreObject` are invoked.
+- [#19111](https://github.com/emberjs/ember.js/pull/19111) [BUGFIX] Fixes `ArrayProxy` length reactivity.
+
### v3.21.0 (August 24, 2020)
- [#18993](https://github.com/emberjs/ember.js/pull/18993) [DEPRECATION] Deprecate `getWithDefault` per [RFC #554](https://github.com/emberjs/rfcs/blob/master/text/0554-deprecate-getwithdefault.md).
- [#19087](https://github.com/emberjs/ember.js/pull/19087) [BUGFIX] Generated initializer tests no longer causes a deprecation warning
- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
+### v3.20.5 (August 28, 2020)
+
+- [#19106](https://github.com/emberjs/ember.js/pull/19106) [BUGFIX] Ensure `destroy` methods on `CoreObject` are invoked.
+- [#19111](https://github.com/emberjs/ember.js/pull/19111) [BUGFIX] Fixes `ArrayProxy` length reactivity.
+
### v3.20.4 (August 11, 2020)
- [#19047](https://github.com/emberjs/ember.js/pull/19047) Ensure `inject-babel-helpers` plugin can be parallelized
| false |
Other
|
emberjs
|
ember.js
|
1a17a61a4d4e7e89a0fd51ac39d6acf7dbbc9991.json
|
Add v3.22.0-beta.1 to CHANGELOG
(cherry picked from commit a429dda8555b812afaed5dd1874ef19bc37e1b02)
|
CHANGELOG.md
|
@@ -1,5 +1,11 @@
# Ember Changelog
+### v3.22.0-beta.1 (August 24, 2020)
+
+- [#19062](https://github.com/emberjs/ember.js/pull/19062) / [#19068](https://github.com/emberjs/ember.js/pull/19068) [FEATURE] Add @ember/destroyable feature from the [Destroyables RFC](https://github.com/emberjs/rfcs/blob/master/text/0580-destroyables.md).
+- [#18984](https://github.com/emberjs/ember.js/pull/18984) / [#19067](https://github.com/emberjs/ember.js/pull/19067) [FEATURE] Add low-level Cache API per [Autotracking Memoization RFC](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md)
+- [#19086](https://github.com/emberjs/ember.js/pull/19086) [FEATURE] Pass transition object to activate/deactivate hooks and events
+
### v3.21.0 (August 24, 2020)
- [#18993](https://github.com/emberjs/ember.js/pull/18993) [DEPRECATION] Deprecate `getWithDefault` per [RFC #554](https://github.com/emberjs/rfcs/blob/master/text/0554-deprecate-getwithdefault.md).
| false |
Other
|
emberjs
|
ember.js
|
20bc7a6a09fda8ff415fccca01dd61c8fd28b2f1.json
|
Add v3.21.0 to CHANGELOG
(cherry picked from commit 4ec9cd59f3e68dad14bd52926d1351d683564332)
|
CHANGELOG.md
|
@@ -1,35 +1,9 @@
# Ember Changelog
-### v3.21.0-beta.6 (August 17, 2020)
-
-- [#19087](https://github.com/emberjs/ember.js/pull/19087) [BUGFIX] Generated initializer tests no longer causes a deprecation warning
-- [#19077](https://github.com/emberjs/ember.js/pull/19077) Simplify `get` and improve `computed` caching scheme.
-- [#19082](https://github.com/emberjs/ember.js/pull/19082) Simplify mixin application
-- [#19089](https://github.com/emberjs/ember.js/pull/19089) Update rendering engine to improve immediate encoding performance
-
-### v3.21.0-beta.5 (August 5, 2020)
-
-- [#19028](https://github.com/emberjs/ember.js/pull/19028) [BUGFIX] Ensure setter CP's with dependent keys on curly components can be two way bound
-
-### v3.21.0-beta.4 (August 3, 2020)
-
-- [#19059](https://github.com/emberjs/ember.js/pull/19059) [BUGFIX] Prevent `<base target="_parent">` from erroring in `HistoryLocation`
-- [#19060](https://github.com/emberjs/ember.js/pull/19060) / [#19065](https://github.com/emberjs/ember.js/pull/19065) / [#19072](https://github.com/emberjs/ember.js/pull/19072) [BUGFIX] Update rendering engine to `@glimmer/*` 0.55.3
-- [#19063](https://github.com/emberjs/ember.js/pull/19063) [DOC] Fix missing docs for `{{#in-element}}`
-
-### v3.21.0-beta.3 (July 27, 2020)
-
-- [#19048](https://github.com/emberjs/ember.js/pull/19048) [BUGFIX] Update router.js to ensure transition.abort works for query param only transitions.
-- [#19056](https://github.com/emberjs/ember.js/pull/19056) [BUGFIX] Update glimmer-vm to 0.54.2.
-
-### v3.21.0-beta.2 (July 20, 2020)
-
-- [#19040](https://github.com/emberjs/ember.js/pull/19040) [BUGFIX] Fix a memory leak that occurred when changing the array passed to `{{each}}`
-- [#19047](https://github.com/emberjs/ember.js/pull/19047) [BUGFIX] Ensure `inject-babel-helpers` plugin can be parallelized
-
-### v3.21.0-beta.1 (July 13, 2020)
+### v3.21.0 (August 24, 2020)
- [#18993](https://github.com/emberjs/ember.js/pull/18993) [DEPRECATION] Deprecate `getWithDefault` per [RFC #554](https://github.com/emberjs/rfcs/blob/master/text/0554-deprecate-getwithdefault.md).
+- [#19087](https://github.com/emberjs/ember.js/pull/19087) [BUGFIX] Generated initializer tests no longer causes a deprecation warning
- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
### v3.20.4 (August 11, 2020)
| false |
Other
|
emberjs
|
ember.js
|
9ad9b7b2ff80e1100f6b278171412f4b558b111b.json
|
Add v3.21.0-beta.6 to CHANGELOG
(cherry picked from commit 04a90457311ce50a0c9ac227944be8cfe60b8009)
|
CHANGELOG.md
|
@@ -1,5 +1,12 @@
# Ember Changelog
+### v3.21.0-beta.6 (August 17, 2020)
+
+- [#19087](https://github.com/emberjs/ember.js/pull/19087) [BUGFIX] Generated initializer tests no longer causes a deprecation warning
+- [#19077](https://github.com/emberjs/ember.js/pull/19077) Simplify `get` and improve `computed` caching scheme.
+- [#19082](https://github.com/emberjs/ember.js/pull/19082) Simplify mixin application
+- [#19089](https://github.com/emberjs/ember.js/pull/19089) Update rendering engine to improve immediate encoding performance
+
### v3.21.0-beta.5 (August 5, 2020)
- [#19028](https://github.com/emberjs/ember.js/pull/19028) [BUGFIX] Ensure setter CP's with dependent keys on curly components can be two way bound
| false |
Other
|
emberjs
|
ember.js
|
863591939b63fa6c323bce1f4628e2fe4e566e4b.json
|
fix tslint complaint
|
packages/@ember/-internals/routing/lib/services/router.ts
|
@@ -4,8 +4,8 @@ import { readOnly } from '@ember/object/computed';
import { assign } from '@ember/polyfills';
import Service from '@ember/service';
import { DEBUG } from '@glimmer/env';
-import { Transition } from 'router_js';
import { consumeTag, tagFor } from '@glimmer/validator';
+import { Transition } from 'router_js';
import EmberRouter, { QueryParam } from '../system/router';
import { extractRouteArgs, resemblesURL, shallowEqual } from '../utils';
| false |
Other
|
emberjs
|
ember.js
|
a497a8e7354c334509d0b0817b2bde0126deda3c.json
|
Add v3.20.4 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -25,6 +25,17 @@
- [#18993](https://github.com/emberjs/ember.js/pull/18993) [DEPRECATION] Deprecate `getWithDefault` per [RFC #554](https://github.com/emberjs/rfcs/blob/master/text/0554-deprecate-getwithdefault.md).
- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
+### v3.20.4 (August 11, 2020)
+
+- [#19047](https://github.com/emberjs/ember.js/pull/19047) Ensure `inject-babel-helpers` plugin can be parallelized
+- [#19089](https://github.com/emberjs/ember.js/pull/19089) Update rendering engine to improve immediate encoding performance
+- [#19082](https://github.com/emberjs/ember.js/pull/19082) Simplify mixin application
+- [#19088](https://github.com/emberjs/ember.js/pull/19088) Simplify factory instantiation from the container
+- [#19028](https://github.com/emberjs/ember.js/pull/19028) Ensure setter CP's with dependent keys on curly components can be two way bound
+- [#19077](https://github.com/emberjs/ember.js/pull/19077) Simplify `get` and improve `computed` caching scheme.
+- [#19065](https://github.com/emberjs/ember.js/pull/19065) / [#19072](https://github.com/emberjs/ember.js/pull/19072) - Updates GlimmerVM to improve internal destroyable system and improve tag / revision computation.
+- [#19081](https://github.com/emberjs/ember.js/pull/19081) Reduces template compilation size in production builds.
+
### v3.20.3 (July 30, 2020)
- [#19048](https://github.com/emberjs/ember.js/pull/19048) [BUGFIX] Update `router.js` to ensure `transition.abort` works for query param only transitions
| false |
Other
|
emberjs
|
ember.js
|
0cbf985347170431af07660497c2028a8f63898f.json
|
Avoid usage of `-in-el-null` in production.
|
packages/ember-template-compiler/lib/plugins/transform-in-element.ts
|
@@ -57,7 +57,7 @@ export default function transformInElement(env: EmberASTPluginEnvironment): ASTP
if (EMBER_GLIMMER_IN_ELEMENT) {
let originalValue = node.params[0];
- if (originalValue) {
+ if (originalValue && !env.isProduction) {
let subExpr = b.sexpr('-in-el-null', [originalValue]);
node.params.shift();
| false |
Other
|
emberjs
|
ember.js
|
0460716c4ad74338cf67beb5f39827cc3fb089f5.json
|
Add v3.21.0-beta.5 to CHANGELOG
(cherry picked from commit 045bbff5a1a7aa6081bf9b3712647beef5c3a9e5)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.21.0-beta.5 (August 5, 2020)
+
+- [#19028](https://github.com/emberjs/ember.js/pull/19028) [BUGFIX] Ensure setter CP's with dependent keys on curly components can be two way bound
+
### v3.21.0-beta.4 (August 3, 2020)
- [#19059](https://github.com/emberjs/ember.js/pull/19059) [BUGFIX] Prevent `<base target="_parent">` from erroring in `HistoryLocation`
| false |
Other
|
emberjs
|
ember.js
|
7328532bbea63778fae478722b6a4972372f4ec3.json
|
Add v3.16.10 to CHANGELOG.md
[ci skip]
|
CHANGELOG.md
|
@@ -105,6 +105,10 @@
- [#18694](https://github.com/emberjs/ember.js/pull/18694) [BUGFIX] Ensure tag updates are buffered, remove error message
- [#18709](https://github.com/emberjs/ember.js/pull/18709) [BUGFIX] Fix `this` in `@tracked` initializer
+### v3.16.10 (August 5, 2020)
+
+- [#19028](https://github.com/emberjs/ember.js/pull/19028) [BUGFIX] Ensure setter CP's with dependent keys on curly components can be two way bound
+
### v3.16.9 (July 29, 2020)
- [#19001](https://github.com/emberjs/ember.js/pull/19001) [BUGFIX] Invoke methods correctly in `TextSupport` `sendAction`
| false |
Other
|
emberjs
|
ember.js
|
13ff365e9595071639f8ee6c4c338d11a86c3733.json
|
Add v3.21.0-beta.4 to CHANGELOG
(cherry picked from commit e2d28a763d0ecae1cce14bae3f9b2b59d22a05c6)
|
CHANGELOG.md
|
@@ -1,5 +1,11 @@
# Ember Changelog
+### v3.21.0-beta.4 (August 3, 2020)
+
+- [#19059](https://github.com/emberjs/ember.js/pull/19059) [BUGFIX] Prevent `<base target="_parent">` from erroring in `HistoryLocation`
+- [#19060](https://github.com/emberjs/ember.js/pull/19060) / [#19065](https://github.com/emberjs/ember.js/pull/19065) / [#19072](https://github.com/emberjs/ember.js/pull/19072) [BUGFIX] Update rendering engine to `@glimmer/*` 0.55.3
+- [#19063](https://github.com/emberjs/ember.js/pull/19063) [DOC] Fix missing docs for `{{#in-element}}`
+
### v3.21.0-beta.3 (July 27, 2020)
- [#19048](https://github.com/emberjs/ember.js/pull/19048) [BUGFIX] Update router.js to ensure transition.abort works for query param only transitions.
| false |
Other
|
emberjs
|
ember.js
|
f2e8c2d165932b2165a446cc4167aaf0589ab440.json
|
Move computed fix to computed property set
|
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
|
@@ -1,7 +1,5 @@
import { privatize as P } from '@ember/-internals/container';
import { ENV } from '@ember/-internals/environment';
-import { addObserver, descriptorForProperty, PROPERTY_DID_CHANGE } from '@ember/-internals/metal';
-import { ComputedDescriptor } from '@ember/-internals/metal/lib/decorator';
import { getOwner } from '@ember/-internals/owner';
import { guidFor } from '@ember/-internals/utils';
import { addChildView, setElementView, setViewElement } from '@ember/-internals/views';
@@ -304,33 +302,6 @@ export default class CurlyComponentManager
}
}
- // ensure two way binding works when the component has defined a computed
- // property with both a setter and dependent keys, in that scenario without
- // the sync observer added below the caller's value will never be updated
- //
- // See GH#18417 / GH#19028 for details.
- let keyName: string, descriptor: ComputedDescriptor;
- if (environment.isInteractive && capturedArgs.names.length > 0) {
- for (let i = 0; i < capturedArgs.names.length; i++) {
- keyName = capturedArgs.names[i];
- descriptor = descriptorForProperty(component, keyName);
-
- if (
- descriptor !== undefined &&
- descriptor._dependentKeys !== undefined &&
- descriptor._dependentKeys.length > 0
- ) {
- addObserver(
- component,
- keyName,
- component[PROPERTY_DID_CHANGE].bind(component, keyName),
- undefined,
- true
- );
- }
- }
- }
-
// Track additional lifecycle metadata about this component in a state bucket.
// Essentially we're saving off all the state we'll need in the future.
let bucket = new ComponentStateBucket(
| true |
Other
|
emberjs
|
ember.js
|
f2e8c2d165932b2165a446cc4167aaf0589ab440.json
|
Move computed fix to computed property set
|
packages/@ember/-internals/metal/lib/computed.ts
|
@@ -1,4 +1,5 @@
import { Meta, meta as metaFor } from '@ember/-internals/meta';
+import { addObserver, PROPERTY_DID_CHANGE } from '@ember/-internals/metal';
import { inspect, isEmberArray, toString } from '@ember/-internals/utils';
import { assert, deprecate, warn } from '@ember/debug';
import EmberError from '@ember/error';
@@ -675,6 +676,25 @@ export class ComputedProperty extends ComputedDescriptor {
let ret;
try {
+ if (obj instanceof Ember.Component) {
+ // ensure two way binding works when the component has defined a computed
+ // property with both a setter and dependent keys, in that scenario without
+ // the sync observer added below the caller's value will never be updated
+ //
+ // See GH#18417 / GH#19028 for details.
+ let descriptor: ComputedDescriptor;
+ descriptor = descriptorForProperty(obj, keyName);
+ let meta = metaFor(obj);
+ if (
+ meta.isInitializing() &&
+ descriptor !== undefined &&
+ descriptor._dependentKeys !== undefined &&
+ descriptor._dependentKeys.length > 0
+ ) {
+ addObserver(obj, keyName, obj[PROPERTY_DID_CHANGE].bind(obj, keyName), undefined, true);
+ }
+ }
+
beginPropertyChanges();
ret = this._set(obj, keyName, value);
| true |
Other
|
emberjs
|
ember.js
|
0bd4855c2d2b77f1b4ad92372a6e7c96d52430a9.json
|
Add v3.20.3 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -5,10 +5,6 @@
- [#19048](https://github.com/emberjs/ember.js/pull/19048) [BUGFIX] Update router.js to ensure transition.abort works for query param only transitions.
- [#19056](https://github.com/emberjs/ember.js/pull/19056) [BUGFIX] Update glimmer-vm to 0.54.2.
-### v3.20.2 (July 26, 2020)
-
-- [#19056](https://github.com/emberjs/ember.js/pull/19056) Update Glimmer rendering engine to 0.54.2. Fixes an issue with (private for now) destroyables work to enable the destroyables polyfill to work more appropriately.
-
### v3.21.0-beta.2 (July 20, 2020)
- [#19040](https://github.com/emberjs/ember.js/pull/19040) [BUGFIX] Fix a memory leak that occurred when changing the array passed to `{{each}}`
@@ -19,6 +15,17 @@
- [#18993](https://github.com/emberjs/ember.js/pull/18993) [DEPRECATION] Deprecate `getWithDefault` per [RFC #554](https://github.com/emberjs/rfcs/blob/master/text/0554-deprecate-getwithdefault.md).
- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
+### v3.20.3 (July 30, 2020)
+
+- [#19048](https://github.com/emberjs/ember.js/pull/19048) [BUGFIX] Update `router.js` to ensure `transition.abort` works for query param only transitions
+- [#19059](https://github.com/emberjs/ember.js/pull/19059) [BUGFIX] Prevent `<base target="_parent">` from erroring in `HistoryLocation`
+- [#19060](https://github.com/emberjs/ember.js/pull/19060) [BUGFIX] Update rendering engine to `@glimmer/*` 0.55.1
+- [#19063](https://github.com/emberjs/ember.js/pull/19063) [DOC] Fix missing docs for `{{#in-element}}`
+
+### v3.20.2 (July 26, 2020)
+
+- [#19056](https://github.com/emberjs/ember.js/pull/19056) Update Glimmer rendering engine to 0.54.2. Fixes an issue with (private for now) destroyables work to enable the destroyables polyfill to work more appropriately.
+
### v3.20.1 (July 13, 2020)
- [#19040](https://github.com/emberjs/ember.js/pull/19040) [BUGFIX] Fix a memory leak that occurred when changing the array passed to `{{each}}`
| false |
Other
|
emberjs
|
ember.js
|
71f62351f501dba5c7a04a474e8c47c9bd73ddf9.json
|
Add v3.16.9 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -92,6 +92,14 @@
- [#18694](https://github.com/emberjs/ember.js/pull/18694) [BUGFIX] Ensure tag updates are buffered, remove error message
- [#18709](https://github.com/emberjs/ember.js/pull/18709) [BUGFIX] Fix `this` in `@tracked` initializer
+### v3.16.9 (July 29, 2020)
+
+- [#19001](https://github.com/emberjs/ember.js/pull/19001) [BUGFIX] Invoke methods correctly in `TextSupport` `sendAction`
+- [#19023](https://github.com/emberjs/ember.js/pull/19023) [BUGFIX] Avoid over eager property access during `init`
+- [#19048](https://github.com/emberjs/ember.js/pull/19048) [BUGFIX] Update `router.js` to ensure `transition.abort` works for query param only transitions
+- [#19057](https://github.com/emberjs/ember.js/pull/19057) [BUGFIX] Parallelize `inject-babel-helpers` plugin
+- [#19059](https://github.com/emberjs/ember.js/pull/19059) [BUGFIX] Prevent `<base target="_parent">` from erroring in HistoryLocation
+
### v3.16.8 (April 24, 2020)
- [#18879](https://github.com/emberjs/ember.js/pull/18879) Ensure errors thrown during component construction do not cause (unrelated) errors during application teardown (fixes a common issue when using `setupOnerror` with components asserting during `constructor`/`init`/`didInssertElement`).
| false |
Other
|
emberjs
|
ember.js
|
1b8e122635607afe8f967a00f9a33c52ab1f3472.json
|
Add v3.21.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 9d50c45961f30b2efe26074e9e0ae11c3c6f82c7)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.21.0-beta.3 (July 27, 2020)
+
+- [#19048](https://github.com/emberjs/ember.js/pull/19048) [BUGFIX] Update router.js to ensure transition.abort works for query param only transitions.
+- [#19056](https://github.com/emberjs/ember.js/pull/19056) [BUGFIX] Update glimmer-vm to 0.54.2.
+
### v3.20.2 (July 26, 2020)
- [#19056](https://github.com/emberjs/ember.js/pull/19056) Update Glimmer rendering engine to 0.54.2. Fixes an issue with (private for now) destroyables work to enable the destroyables polyfill to work more appropriately.
| false |
Other
|
emberjs
|
ember.js
|
ef9f971fe94de3f5823b51060d0e16fceb4a236c.json
|
Update CHANGELOG.md for 3.20.2.
[ci skip]
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.20.2 (July 26, 2020)
+
+- [#19056](https://github.com/emberjs/ember.js/pull/19056) Update Glimmer rendering engine to 0.54.2. Fixes an issue with (private for now) destroyables work to enable the destroyables polyfill to work more appropriately.
+
### v3.21.0-beta.2 (July 20, 2020)
- [#19040](https://github.com/emberjs/ember.js/pull/19040) [BUGFIX] Fix a memory leak that occurred when changing the array passed to `{{each}}`
| false |
Other
|
emberjs
|
ember.js
|
6532c0da0a2e323f1e0f021e2dd37b40007a344a.json
|
Fix keyName binding issue
|
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
|
@@ -323,9 +323,7 @@ export default class CurlyComponentManager
addObserver(
component,
keyName,
- () => {
- component[PROPERTY_DID_CHANGE](keyName);
- },
+ component[PROPERTY_DID_CHANGE].bind(component, keyName),
undefined,
true
);
| false |
Other
|
emberjs
|
ember.js
|
a43f203010669f22fca0277a9edf0231a3e94079.json
|
Add v3.21.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 1be10910593f135cdefb2b8ecfbb932dba061c1e)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.21.0-beta.2 (July 20, 2020)
+
+- [#19040](https://github.com/emberjs/ember.js/pull/19040) [BUGFIX] Fix a memory leak that occurred when changing the array passed to `{{each}}`
+- [#19047](https://github.com/emberjs/ember.js/pull/19047) [BUGFIX] Ensure `inject-babel-helpers` plugin can be parallelized
+
### v3.21.0-beta.1 (July 13, 2020)
- [#18993](https://github.com/emberjs/ember.js/pull/18993) [DEPRECATION] Deprecate `getWithDefault` per [RFC #554](https://github.com/emberjs/rfcs/blob/master/text/0554-deprecate-getwithdefault.md).
| false |
Other
|
emberjs
|
ember.js
|
eff98d676611a5e366f19ebce62fca5c7b10a4c2.json
|
Add v3.20.1 to CHANGELOG
[ci skip]
|
CHANGELOG.md
|
@@ -5,6 +5,10 @@
- [#18993](https://github.com/emberjs/ember.js/pull/18993) [DEPRECATION] Deprecate `getWithDefault` per [RFC #554](https://github.com/emberjs/rfcs/blob/master/text/0554-deprecate-getwithdefault.md).
- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
+### v3.20.1 (July 13, 2020)
+
+- [#19040](https://github.com/emberjs/ember.js/pull/19040) [BUGFIX] Fix a memory leak that occurred when changing the array passed to `{{each}}`
+
### v3.20.0 (July 13, 2020)
- [#18867](https://github.com/emberjs/ember.js/pull/18867) / [#18927](https://github.com/emberjs/ember.js/pull/18927) / [#18928](https://github.com/emberjs/ember.js/pull/18928) [FEATURE] [Promote `{{in-element}}` to public API](https://github.com/emberjs/rfcs/blob/master/text/0287-promote-in-element-to-public-api.md) RFC.
| false |
Other
|
emberjs
|
ember.js
|
b6166734043bdea11622675bd96d4c5e4ebee7db.json
|
Add v3.21.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit 6a868bab610fb9dcb52674a4a32803f36c8c86c5)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.21.0-beta.1 (July 13, 2020)
+
+- [#18993](https://github.com/emberjs/ember.js/pull/18993) [DEPRECATION] Deprecate `getWithDefault` per [RFC #554](https://github.com/emberjs/rfcs/blob/master/text/0554-deprecate-getwithdefault.md).
+- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
+
### v3.20.0 (July 13, 2020)
- [#18867](https://github.com/emberjs/ember.js/pull/18867) / [#18927](https://github.com/emberjs/ember.js/pull/18927) / [#18928](https://github.com/emberjs/ember.js/pull/18928) [FEATURE] [Promote `{{in-element}}` to public API](https://github.com/emberjs/rfcs/blob/master/text/0287-promote-in-element-to-public-api.md) RFC.
| false |
Other
|
emberjs
|
ember.js
|
82baa28ced6dd7323955318730a0a7fa8c569a66.json
|
Add v3.20.0 to CHANGELOG
[ci skip]
(cherry picked from commit 13ec04419c77371a4ca020978860fb63c684b458)
|
CHANGELOG.md
|
@@ -1,27 +1,13 @@
# Ember Changelog
-### v3.20.0-beta.5 (July 6, 2020)
-
-- [#19034](https://github.com/emberjs/ember.js/pull/19034) [BUGFIX] Disable named blocks; please continue to use the polyfill.
-
-### v3.20.0-beta.4 (June 29, 2020)
+### v3.20.0 (July 13, 2020)
+- [#18867](https://github.com/emberjs/ember.js/pull/18867) / [#18927](https://github.com/emberjs/ember.js/pull/18927) / [#18928](https://github.com/emberjs/ember.js/pull/18928) [FEATURE] [Promote `{{in-element}}` to public API](https://github.com/emberjs/rfcs/blob/master/text/0287-promote-in-element-to-public-api.md) RFC.
- [#19025](https://github.com/emberjs/ember.js/pull/19025) [BUGFIX] Updates Glimmer VM to 0.54.0
-
-### v3.20.0-beta.3 (June 22, 2020)
-
- [#19021](https://github.com/emberjs/ember.js/pull/19021) [BUGFIX] Disallow null/undefined targets in `in-element`.
- [#19023](https://github.com/emberjs/ember.js/pull/19023) [BUGFIX] Don't access properties during init unless required to prevent unnecessary rendering invalidations.
-
-### v3.20.0-beta.2 (June 2, 2020)
-
- [#18997](https://github.com/emberjs/ember.js/pull/18997) [BUGFIX] Fix components `<Input>` and `<Textarea>` to work with native class actions correctly.
-
-### v3.20.0-beta.1 (May 26, 2020)
-
-- [#18926](https://github.com/emberjs/ember.js/pull/18926) / [#18852](https://github.com/emberjs/ember.js/pull/18852) [FEATURE] Implement the [Yieldable Named Blocks](https://github.com/emberjs/rfcs/blob/master/text/0460-yieldable-named-blocks.md) RFC.
-- [#18867](https://github.com/emberjs/ember.js/pull/18867) / [#18927](https://github.com/emberjs/ember.js/pull/18927) / [#18928](https://github.com/emberjs/ember.js/pull/18928) [FEATURE] [Promote `{{in-element}}` to public API](https://github.com/emberjs/rfcs/blob/master/text/0287-promote-in-element-to-public-api.md) RFC.
-- [#18859](https://github.com/emberjs/ember.js/pull/18859) Fix transitionTo with scoped aliased queryParam.
+- [#18859](https://github.com/emberjs/ember.js/pull/18859) [BUGFIX] Fix transitionTo with scoped aliased queryParam.
- [#18961](https://github.com/emberjs/ember.js/pull/18961) [BUGFIX] Remove assertions for updating auto-tracked state without Ember.set / this.set
### v3.19.0 (May 26, 2020)
| false |
Other
|
emberjs
|
ember.js
|
251c17f86f5375187dec7a6165cb8017d3fa7592.json
|
Add v3.20.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 0fd013db7d515737d537631923e4853293e9859c)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.20.0-beta.5 (July 6, 2020)
+
+- [#19034](https://github.com/emberjs/ember.js/pull/19034) [BUGFIX] Disable named blocks; please continue to use the polyfill.
+
### v3.20.0-beta.4 (June 29, 2020)
- [#19025](https://github.com/emberjs/ember.js/pull/19025) [BUGFIX] Updates Glimmer VM to 0.54.0
| false |
Other
|
emberjs
|
ember.js
|
b5088f6fdff164067dfb2e608531f6e8a02f9f54.json
|
Add v3.20.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit d5ce21323dd413a4fd6c6b346ea63f81e1c595b0)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.20.0-beta.4 (June 29, 2020)
+
+- [#19025](https://github.com/emberjs/ember.js/pull/19025) [BUGFIX] Updates Glimmer VM to 0.54.0
+
### v3.20.0-beta.3 (June 22, 2020)
- [#19021](https://github.com/emberjs/ember.js/pull/19021) [BUGFIX] Disallow null/undefined targets in `in-element`.
| false |
Other
|
emberjs
|
ember.js
|
5a7e16666cd0579b24f3b80be1e4f6fd6d3f0602.json
|
Fix typo in issue number in test
|
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
|
@@ -308,7 +308,7 @@ export default class CurlyComponentManager
// property with both a setter and dependent keys, in that scenario without
// the sync observer added below the caller's value will never be updated
//
- // See GH#18147 / GH#19028 for details.
+ // See GH#18417 / GH#19028 for details.
let keyName: string, descriptor: ComputedDescriptor;
if (environment.isInteractive && capturedArgs.names.length > 0) {
for (let i = 0; i < capturedArgs.names.length; i++) {
| true |
Other
|
emberjs
|
ember.js
|
5a7e16666cd0579b24f3b80be1e4f6fd6d3f0602.json
|
Fix typo in issue number in test
|
packages/@ember/-internals/glimmer/tests/integration/components/curly-components-test.js
|
@@ -2904,7 +2904,7 @@ moduleFor(
this.assertText('initial value');
}
- ['@test GH#18147 - a two way binding flows upstream to a parent component through a CP']() {
+ ['@test GH#18417 - a two way binding flows upstream to a parent component through a CP']() {
let parent, child;
let ParentComponent = Component.extend({
init() {
| true |
Other
|
emberjs
|
ember.js
|
ae0c5d83643fe1408e7620a772eb84787bc6926c.json
|
Fix lint issue
|
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
|
@@ -1,5 +1,7 @@
import { privatize as P } from '@ember/-internals/container';
import { ENV } from '@ember/-internals/environment';
+import { addObserver, descriptorForProperty, PROPERTY_DID_CHANGE } from '@ember/-internals/metal';
+import { ComputedDescriptor } from '@ember/-internals/metal/lib/decorator';
import { getOwner } from '@ember/-internals/owner';
import { guidFor } from '@ember/-internals/utils';
import { addChildView, setElementView, setViewElement } from '@ember/-internals/views';
@@ -38,12 +40,11 @@ import {
referenceForKey,
SimpleClassNameBindingReference,
} from '../utils/bindings';
+
import ComponentStateBucket, { Component } from '../utils/curly-component-state-bucket';
import { processComponentArgs } from '../utils/process-args';
import AbstractManager from './abstract';
import DefinitionState from './definition-state';
-import { addObserver, descriptorForProperty, PROPERTY_DID_CHANGE } from '@ember/-internals/metal';
-import { ComputedDescriptor } from '@ember/-internals/metal/lib/decorator';
function aliasIdToElementId(args: VMArguments, props: any) {
if (args.named.has('id')) {
| false |
Other
|
emberjs
|
ember.js
|
17f9c2800b2a48c363fe77f8762c24ac1d49ac42.json
|
Add v3.20.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 25d806cfcda2b0b6b5172e2be1a60ba869d681fc)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.20.0-beta.3 (June 22, 2020)
+
+- [#19021](https://github.com/emberjs/ember.js/pull/19021) [BUGFIX] Disallow null/undefined targets in `in-element`.
+- [#19023](https://github.com/emberjs/ember.js/pull/19023) [BUGFIX] Don't access properties during init unless required to prevent unnecessary rendering invalidations.
+
### v3.20.0-beta.2 (June 2, 2020)
- [#18997](https://github.com/emberjs/ember.js/pull/18997) [BUGFIX] Fix components `<Input>` and `<Textarea>` to work with native class actions correctly.
| false |
Other
|
emberjs
|
ember.js
|
7676db612c554ce49b1c6917762e0242e6c5d802.json
|
Add v3.20.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 74d757e6bc4b77845e61372b682f2218e6ed2535)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.20.0-beta.2 (June 2, 2020)
+
+- [#18997](https://github.com/emberjs/ember.js/pull/18997) [BUGFIX] Fix components `<Input>` and `<Textarea>` to work with native class actions correctly.
+
### v3.20.0-beta.1 (May 26, 2020)
- [#18926](https://github.com/emberjs/ember.js/pull/18926) / [#18852](https://github.com/emberjs/ember.js/pull/18852) [FEATURE] Implement the [Yieldable Named Blocks](https://github.com/emberjs/rfcs/blob/master/text/0460-yieldable-named-blocks.md) RFC.
| false |
Other
|
emberjs
|
ember.js
|
bb8cd68ee0f0a893faea1e010c3ec384f039ad73.json
|
Add v3.20.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit 3a9206aeb4147232e3e659007af5fb2868d8a842)
|
CHANGELOG.md
|
@@ -1,5 +1,12 @@
# Ember Changelog
+### v3.20.0-beta.1 (May 26, 2020)
+
+- [#18926](https://github.com/emberjs/ember.js/pull/18926) / [#18852](https://github.com/emberjs/ember.js/pull/18852) [FEATURE] Implement the [Yieldable Named Blocks](https://github.com/emberjs/rfcs/blob/master/text/0460-yieldable-named-blocks.md) RFC.
+- [#18867](https://github.com/emberjs/ember.js/pull/18867) / [#18927](https://github.com/emberjs/ember.js/pull/18927) / [#18928](https://github.com/emberjs/ember.js/pull/18928) [FEATURE] [Promote `{{in-element}}` to public API](https://github.com/emberjs/rfcs/blob/master/text/0287-promote-in-element-to-public-api.md) RFC.
+- [#18859](https://github.com/emberjs/ember.js/pull/18859) Fix transitionTo with scoped aliased queryParam.
+- [#18961](https://github.com/emberjs/ember.js/pull/18961) [BUGFIX] Remove assertions for updating auto-tracked state without Ember.set / this.set
+
### v3.19.0 (May 26, 2020)
- [#18982](https://github.com/emberjs/ember.js/pull/18982) / [#18913](https://github.com/emberjs/ember.js/pull/18913) [BUGFIX] Update rendering engine to latest version.
| false |
Other
|
emberjs
|
ember.js
|
4d3eaaeef4659f22d6dc3bf5678c4b78aa16dd27.json
|
Add v3.19.0 to CHANGELOG
[ci skip]
(cherry picked from commit b688629e07c2dbb797312cec4c86402099b63807)
|
CHANGELOG.md
|
@@ -1,24 +1,13 @@
# Ember Changelog
-### v3.19.0-beta.4 (May 12, 2020)
+### v3.19.0 (May 26, 2020)
+- [#18982](https://github.com/emberjs/ember.js/pull/18982) / [#18913](https://github.com/emberjs/ember.js/pull/18913) [BUGFIX] Update rendering engine to latest version.
+ - Add a compile time error when passing arguments to regular HTML elements (e.g. `<a @foo=`)
+ - Fix: Rerender an `{{#each`s block only when the specific item has changed
- [#18958](https://github.com/emberjs/ember.js/pull/18958) [BUGFIX] Ensure AST transforms using `in-element` work properly.
- [#18960](https://github.com/emberjs/ember.js/pull/18960) [BUGFIX] More assertions for Application lifecycle methods
-
-### v3.19-0.beta.3 (May 4, 2020)
-
-- [#18941](https://github.com/emberjs/ember.js/pull/18941) [BUGFIX] Update rendering engine to latest version.
- - Reduce template size growth to near 3.16 levels (still ~ 3% higher than 3.16)
- - Ensures destroyable items added to an `{{#each` after initial render are invoked properly
- - Fixes an issue with key collisions in `{{#each`
-
-### v3.19.0-beta.2 (April 27, 2020)
-
-- [#18913](https://github.com/emberjs/ember.js/pull/18913) [BUGFIX] Update to glimmer-vm 0.51.0.
- [#18919](https://github.com/emberjs/ember.js/pull/18919) [BUGFIX] Add error for modifier manager without capabilities.
-
-### v3.19.0-beta.1 (April 14, 2020)
-
- [#18828](https://github.com/emberjs/ember.js/pull/18828) [BUGFIX] Prepend 'TODO: ' to 'Replace this with your real tests' comments in generated tests
- [#18353](https://github.com/emberjs/ember.js/pull/18353) [BUGFIX] Improve `fn` & `on` undefined callback message
- [#18824](https://github.com/emberjs/ember.js/pull/18824) [CLEANUP] Remove deprecated private `window.ENV`
| false |
Other
|
emberjs
|
ember.js
|
68d216b1db1688b41cf8895d7b1bbf84f25864ba.json
|
Add changelog for v3.12.4 [ci skip]
(cherry picked from commit 08655e75436e189dc390bb87ce79c002c0142070)
(cherry picked from commit 0f554b1e4e164010bbc22533c1e0d4d900fbcbd4)
|
CHANGELOG.md
|
@@ -59,15 +59,15 @@
- [#18688](https://github.com/emberjs/ember.js/pull/18688) / [#18621](https://github.com/emberjs/ember.js/pull/18621) / [#18714](https://github.com/emberjs/ember.js/pull/18714) / [#18743](https://github.com/emberjs/ember.js/pull/18743) / [#18762](https://github.com/emberjs/ember.js/pull/18762) Upgrades Glimmer VM to 0.47.9, fixes ignored `checked` attribute on `input`, fixes using `array` and `hash` helper together
- [#18741](https://github.com/emberjs/ember.js/pull/18741) [BUGFIX] Don't setup mandatory setters on array indexes
- [#18767](https://github.com/emberjs/ember.js/pull/18767) [BUGFIX] Fix observer leaks
-- [#18770](https://github.com/emberjs/ember.js/pull/18770) [BUGFIX] Make ArrayProxy Lazy
+- [#18770](https://github.com/emberjs/ember.js/pull/18770) [BUGFIX] Make ArrayProxy Lazy
- [#18780](https://github.com/emberjs/ember.js/pull/18780) [BUGFIX] Fix ownerInjection when used to create services directly
- [#18742](https://github.com/emberjs/ember.js/pull/18742) [BUGFIX] Fix setDiff computed macro used within glimmer component
- [#18727](https://github.com/emberjs/ember.js/pull/18727) [BUGFIX] Avoid breaking {{-in-element}} usage
- [#18728](https://github.com/emberjs/ember.js/pull/18728) [BUGFIX] Fix `{{#-in-element}}` double-clearing issue
- [#18703](https://github.com/emberjs/ember.js/pull/18703) [BUGFIX] Correctly links ArrayProxy tags to `arrangedContent`
- [#18707](https://github.com/emberjs/ember.js/pull/18707) [BUGFIX] Fixes tag chaining on Proxy mixins
- [#18708](https://github.com/emberjs/ember.js/pull/18708) [BUGFIX] Ensures the arg proxy works with `get`
-- [#18694](https://github.com/emberjs/ember.js/pull/18694) [BUGFIX] Ensure tag updates are buffered, remove error message
+- [#18694](https://github.com/emberjs/ember.js/pull/18694) [BUGFIX] Ensure tag updates are buffered, remove error message
- [#18709](https://github.com/emberjs/ember.js/pull/18709) [BUGFIX] Fix `this` in `@tracked` initializer
### v3.16.8 (April 24, 2020)
@@ -193,6 +193,11 @@
- [#18217](https://github.com/emberjs/ember.js/pull/18217) [BUGFIX] Adds ability for computed props to depend on args
- [#18222](https://github.com/emberjs/ember.js/pull/18222) [BUGFIX] Matches assertion behavior for CPs computing after destroy
+### v3.12.4 (May 21, 2020)
+
+- [#18879](https://github.com/emberjs/ember.js/pull/18879) Ensure errors thrown during component construction do not cause (unrelated) errors during application teardown (fixes a common issue when using `setupOnerror` with components asserting during `constructor`/`init`/`didInssertElement`).
+- [#18273](https://github.com/emberjs/ember.js/pull/18273) [BUGFIX] Fix issues with SSR rehydration of <title>.
+
### v3.12.3 (March 12, 2020)
- [#18809](https://github.com/emberjs/ember.js/pull/18809) [BUGFIX] Do not error (RE: `elementId` changing) if `elementId` is not changed
| false |
Other
|
emberjs
|
ember.js
|
0317ecf1af0f7729eafb6be590e1b0100da08529.json
|
Add v3.19.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 8820630908035395f8417710a29384001eae955f)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.19.0-beta.4 (May 12, 2020)
+
+- [#18958](https://github.com/emberjs/ember.js/pull/18958) [BUGFIX] Ensure AST transforms using `in-element` work properly.
+- [#18960](https://github.com/emberjs/ember.js/pull/18960) [BUGFIX] More assertions for Application lifecycle methods
+
### v3.19-0.beta.3 (May 4, 2020)
- [#18941](https://github.com/emberjs/ember.js/pull/18941) [BUGFIX] Update rendering engine to latest version.
| false |
Other
|
emberjs
|
ember.js
|
f16f307152000c37e559c7154a8d2df6743de13c.json
|
Add v3.19.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit ddaf8e1a172ee464ee38d68cd4cacf1b6b12fe76)
|
CHANGELOG.md
|
@@ -1,5 +1,12 @@
# Ember Changelog
+### v3.19-0.beta.3 (May 4, 2020)
+
+- [#18941](https://github.com/emberjs/ember.js/pull/18941) [BUGFIX] Update rendering engine to latest version.
+ - Reduce template size growth to near 3.16 levels (still ~ 3% higher than 3.16)
+ - Ensures destroyable items added to an `{{#each` after initial render are invoked properly
+ - Fixes an issue with key collisions in `{{#each`
+
### v3.19.0-beta.2 (April 27, 2020)
- [#18913](https://github.com/emberjs/ember.js/pull/18913) [BUGFIX] Update to glimmer-vm 0.51.0.
| false |
Other
|
emberjs
|
ember.js
|
a41da5dd39739f3ef146dd71426c7e2f10f40dc5.json
|
Add v3.19.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit f4173555fb497ec96c419869a89a42a9a8114ed5)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.19.0-beta.2 (April 27, 2020)
+
+- [#18913](https://github.com/emberjs/ember.js/pull/18913) [BUGFIX] Update to glimmer-vm 0.51.0.
+- [#18919](https://github.com/emberjs/ember.js/pull/18919) [BUGFIX] Add error for modifier manager without capabilities.
+
### v3.19.0-beta.1 (April 14, 2020)
- [#18828](https://github.com/emberjs/ember.js/pull/18828) [BUGFIX] Prepend 'TODO: ' to 'Replace this with your real tests' comments in generated tests
| false |
Other
|
emberjs
|
ember.js
|
f879ca2209a48426437218af1f454d4e120375f0.json
|
Add v3.16.8 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -46,6 +46,10 @@
- [#18694](https://github.com/emberjs/ember.js/pull/18694) [BUGFIX] Ensure tag updates are buffered, remove error message
- [#18709](https://github.com/emberjs/ember.js/pull/18709) [BUGFIX] Fix `this` in `@tracked` initializer
+### v3.16.8 (April 24, 2020)
+
+- [#18879](https://github.com/emberjs/ember.js/pull/18879) Ensure errors thrown during component construction do not cause (unrelated) errors during application teardown (fixes a common issue when using `setupOnerror` with components asserting during `constructor`/`init`/`didInssertElement`).
+
### v3.16.7 (April 13, 2020)
- [#18854](https://github.com/emberjs/ember.js/pull/18854) Pass value through to `PROPERTY_DID_CHANGE` to avoid calling `get` when setting values for computed props
| false |
Other
|
emberjs
|
ember.js
|
16e1c71b4957cacf7c37535972323f97887fcead.json
|
Enable no-prototype-builtins linting rule
|
.eslintrc.js
|
@@ -22,7 +22,6 @@ module.exports = {
'no-unused-vars': 'error',
'no-throw-literal': 'error',
'no-var': 'error',
- 'no-prototype-builtins': 'off',
'prettier/prettier': 'error',
'qunit/no-commented-tests': 'off',
'qunit/require-expect': 'off',
| false |
Other
|
emberjs
|
ember.js
|
2df46156a06375817be03d9267cdca9520188204.json
|
remove duplicated global declaration
|
d8-runner.js
|
@@ -37,7 +37,7 @@
//
// begin MISC setup;
-/* globals load, print, Promise */
+/* globals load, print */
const global = new Function('return this;')();
global.self = global;
| false |
Other
|
emberjs
|
ember.js
|
c3b4e7c7ccc82935dacc19f1586ed699475aa202.json
|
coerse QUnit.module override to avoid tsc failure
|
packages/internal-test-helpers/lib/ember-dev/setup-qunit.ts
|
@@ -45,7 +45,7 @@ export default function setupQUnit() {
callback(hooks);
});
- };
+ } as typeof QUnit.module;
QUnit.assert.rejects = async function(
promise: Promise<any>,
| false |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
broccoli/packages.js
|
@@ -133,7 +133,7 @@ module.exports.handlebarsES = function _handlebars() {
};
function handlebarsFix() {
- let HANDLEBARS_PARSER = /[\/\\]parser.js$/;
+ let HANDLEBARS_PARSER = /[/\\]parser.js$/;
return {
load: function(id) {
if (HANDLEBARS_PARSER.test(id)) {
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/container/tests/container_test.js
|
@@ -198,7 +198,7 @@ moduleFor(
assert.throws(() => {
container.lookup('controller:foo');
- }, /Failed to create an instance of \'controller:foo\'/);
+ }, /Failed to create an instance of 'controller:foo'/);
}
['@test Injecting a failed lookup raises an error']() {
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/glimmer/tests/integration/components/fragment-components-test.js
|
@@ -244,7 +244,7 @@ moduleFor(
expectAssertion(() => {
this.render(`{{#foo-bar}}{{/foo-bar}}`);
- }, /You cannot access this.\$\(\) on a component with `tagName: \'\'` specified/);
+ }, /You cannot access this.\$\(\) on a component with `tagName: ''` specified/);
}
['@test renders a contained view with omitted start tag and tagless parent view context']() {
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-angle-test.js
|
@@ -9,7 +9,7 @@ import { DEBUG } from '@glimmer/env';
// IE includes the host name
function normalizeUrl(url) {
- return url.replace(/https?:\/\/[^\/]+/, '');
+ return url.replace(/https?:\/\/[^/]+/, '');
}
function shouldNotBeActive(assert, element) {
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-curly-test.js
|
@@ -9,7 +9,7 @@ import { DEBUG } from '@glimmer/env';
// IE includes the host name
function normalizeUrl(url) {
- return url.replace(/https?:\/\/[^\/]+/, '');
+ return url.replace(/https?:\/\/[^/]+/, '');
}
function shouldNotBeActive(assert, element) {
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/glimmer/tests/integration/helpers/custom-helper-test.js
|
@@ -12,7 +12,7 @@ moduleFor(
this.registerHelper('if', () => 'Nope');
expectAssertion(() => {
this.render(`{{if foo 'LOL'}}`, { foo: true });
- }, /You attempted to overwrite the built-in helper \"if\" which is not allowed. Please rename the helper./);
+ }, /You attempted to overwrite the built-in helper "if" which is not allowed. Please rename the helper./);
}
['@test it can resolve custom simple helpers with or without dashes']() {
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/glimmer/tests/integration/helpers/hash-test.js
|
@@ -8,7 +8,7 @@ moduleFor(
'Helpers test: {{hash}}',
class extends RenderingTestCase {
['@test returns a hash with the right key-value']() {
- this.render(`{{#with (hash name=\"Sergio\") as |person|}}{{person.name}}{{/with}}`);
+ this.render(`{{#with (hash name="Sergio") as |person|}}{{person.name}}{{/with}}`);
this.assertText('Sergio');
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/metal/tests/computed_test.js
|
@@ -1020,7 +1020,7 @@ moduleFor(
assert.throws(() => {
set(obj, 'bar', 'newBar');
- }, /Cannot set read\-only property "bar" on object:/);
+ }, /Cannot set read-only property "bar" on object:/);
assert.equal(get(obj, 'bar'), 'barValue');
}
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/routing/lib/system/router.ts
|
@@ -952,7 +952,7 @@ class EmberRouter extends EmberObject {
qpOther = qpsByUrlKey![urlKey];
if (qpOther && qpOther.controllerName !== qp.controllerName) {
assert(
- `You're not allowed to have more than one controller property map to the same query param key, but both \`${qpOther.scopedPropertyName}\` and \`${qp.scopedPropertyName}\` map to \`${urlKey}\`. You can fix this by mapping one of the controller properties to a different query param key via the \`as\` config option, e.g. \`${qpOther.prop}: { as: \'other-${qpOther.prop}\' }\``,
+ `You're not allowed to have more than one controller property map to the same query param key, but both \`${qpOther.scopedPropertyName}\` and \`${qp.scopedPropertyName}\` map to \`${urlKey}\`. You can fix this by mapping one of the controller properties to a different query param key via the \`as\` config option, e.g. \`${qpOther.prop}: { as: 'other-${qpOther.prop}' }\``,
false
);
}
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/routing/tests/system/route_test.js
|
@@ -123,7 +123,7 @@ moduleFor(
expectAssertion(function() {
route.model({ post_id: 1 });
- }, /You used the dynamic segment post_id in your route undefined, but <Ember.Object:ember\d+>.Post did not exist and you did not override your route\'s `model` hook./);
+ }, /You used the dynamic segment post_id in your route undefined, but <Ember.Object:ember\d+>.Post did not exist and you did not override your route's `model` hook./);
runDestroy(owner);
}
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/-internals/runtime/lib/mixins/-proxy.js
|
@@ -97,7 +97,7 @@ export default Mixin.create({
let content = contentFor(this);
assert(
- `Cannot delegate set('${key}', ${value}) to the \'content\' property of object proxy ${this}: its 'content' is undefined.`,
+ `Cannot delegate set('${key}', ${value}) to the 'content' property of object proxy ${this}: its 'content' is undefined.`,
content
);
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/debug/lib/deprecate.ts
|
@@ -115,8 +115,8 @@ if (DEBUG) {
// Chrome
stack = error.stack
.replace(/^\s+at\s+/gm, '')
- .replace(/^([^\(]+?)([\n$])/gm, '{anonymous}($1)$2')
- .replace(/^Object.<anonymous>\s*\(([^\)]+)\)/gm, '{anonymous}($1)')
+ .replace(/^([^(]+?)([\n$])/gm, '{anonymous}($1)$2')
+ .replace(/^Object.<anonymous>\s*\(([^)]+)\)/gm, '{anonymous}($1)')
.split('\n');
stack.shift();
} else {
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/object/lib/computed/computed_macros.js
|
@@ -24,7 +24,7 @@ function expandPropertiesToArray(predicateName, properties) {
for (let i = 0; i < properties.length; i++) {
let property = properties[i];
assert(
- `Dependent keys passed to computed.${predicateName}() can\'t have spaces.`,
+ `Dependent keys passed to computed.${predicateName}() can't have spaces.`,
property.indexOf(' ') < 0
);
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/object/lib/computed/reduce_computed_macros.js
|
@@ -14,7 +14,7 @@ import { compare, isArray, A as emberA, uniqBy as uniqByArray } from '@ember/-in
function reduceMacro(dependentKey, callback, initialValue, name) {
assert(
`Dependent key passed to \`computed.${name}\` shouldn't contain brace expanding pattern.`,
- !/[\[\]\{\}]/g.test(dependentKey)
+ !/[[\]{}]/g.test(dependentKey)
);
return computed(`${dependentKey}.[]`, function() {
@@ -49,7 +49,7 @@ function arrayMacro(dependentKey, additionalDependentKeys, callback) {
function multiArrayMacro(_dependentKeys, callback, name) {
assert(
`Dependent keys passed to \`computed.${name}\` shouldn't contain brace expanding pattern.`,
- _dependentKeys.every(dependentKey => !/[\[\]\{\}]/g.test(dependentKey))
+ _dependentKeys.every(dependentKey => !/[[\]{}]/g.test(dependentKey))
);
let dependentKeys = _dependentKeys.map(key => `${key}.[]`);
@@ -527,7 +527,7 @@ export function mapBy(dependentKey, propertyKey) {
);
assert(
`Dependent key passed to \`computed.mapBy\` shouldn't contain brace expanding pattern.`,
- !/[\[\]\{\}]/g.test(dependentKey)
+ !/[[\]{}]/g.test(dependentKey)
);
return map(`${dependentKey}.@each.${propertyKey}`, item => get(item, propertyKey));
@@ -751,7 +751,7 @@ export function filterBy(dependentKey, propertyKey, value) {
assert(
`Dependent key passed to \`computed.filterBy\` shouldn't contain brace expanding pattern.`,
- !/[\[\]\{\}]/g.test(dependentKey)
+ !/[[\]{}]/g.test(dependentKey)
);
let callback;
@@ -919,7 +919,7 @@ export function uniqBy(dependentKey, propertyKey) {
assert(
`Dependent key passed to \`computed.uniqBy\` shouldn't contain brace expanding pattern.`,
- !/[\[\]\{\}]/g.test(dependentKey)
+ !/[[\]{}]/g.test(dependentKey)
);
return computed(`${dependentKey}.[]`, function() {
@@ -1172,7 +1172,7 @@ export function setDiff(setAProperty, setBProperty) {
assert('`computed.setDiff` requires exactly two dependent arrays.', arguments.length === 2);
assert(
`Dependent keys passed to \`computed.setDiff\` shouldn't contain brace expanding pattern.`,
- !/[\[\]\{\}]/g.test(setAProperty) && !/[\[\]\{\}]/g.test(setBProperty)
+ !/[[\]{}]/g.test(setAProperty) && !/[[\]{}]/g.test(setBProperty)
);
return computed(`${setAProperty}.[]`, `${setBProperty}.[]`, function() {
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/object/tests/computed/reduce_computed_macros_test.js
|
@@ -917,7 +917,7 @@ moduleFor(
array2: emberA([3, 4, 5]),
});
},
- /\`computed\.setDiff\` requires exactly two dependent arrays/,
+ /`computed\.setDiff` requires exactly two dependent arrays/,
'setDiff requires two dependent arrays'
);
@@ -931,7 +931,7 @@ moduleFor(
array3: emberA([7]),
});
},
- /\`computed\.setDiff\` requires exactly two dependent arrays/,
+ /`computed\.setDiff` requires exactly two dependent arrays/,
'setDiff requires two dependent arrays'
);
}
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/@ember/string/index.ts
|
@@ -14,7 +14,7 @@ const STRING_DASHERIZE_CACHE = new Cache<string, string>(1000, key =>
decamelize(key).replace(STRING_DASHERIZE_REGEXP, '-')
);
-const STRING_CAMELIZE_REGEXP_1 = /(\-|\_|\.|\s)+(.)?/g;
+const STRING_CAMELIZE_REGEXP_1 = /(-|_|\.|\s)+(.)?/g;
const STRING_CAMELIZE_REGEXP_2 = /(^|\/)([A-Z])/g;
const CAMELIZE_CACHE = new Cache<string, string>(1000, key =>
@@ -23,8 +23,8 @@ const CAMELIZE_CACHE = new Cache<string, string>(1000, key =>
.replace(STRING_CAMELIZE_REGEXP_2, (match /*, separator, chr */) => match.toLowerCase())
);
-const STRING_CLASSIFY_REGEXP_1 = /^(\-|_)+(.)?/;
-const STRING_CLASSIFY_REGEXP_2 = /(.)(\-|\_|\.|\s)+(.)?/g;
+const STRING_CLASSIFY_REGEXP_1 = /^(-|_)+(.)?/;
+const STRING_CLASSIFY_REGEXP_2 = /(.)(-|_|\.|\s)+(.)?/g;
const STRING_CLASSIFY_REGEXP_3 = /(^|\/|\.)([a-z])/g;
const CLASSIFY_CACHE = new Cache<string, string>(1000, str => {
@@ -44,7 +44,7 @@ const CLASSIFY_CACHE = new Cache<string, string>(1000, str => {
});
const STRING_UNDERSCORE_REGEXP_1 = /([a-z\d])([A-Z]+)/g;
-const STRING_UNDERSCORE_REGEXP_2 = /\-|\s+/g;
+const STRING_UNDERSCORE_REGEXP_2 = /-|\s+/g;
const UNDERSCORE_CACHE = new Cache<string, string>(1000, str =>
str
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/ember-template-compiler/tests/plugins/deprecate-send-action-test.js
|
@@ -18,7 +18,7 @@ EVENTS.forEach(function(e) {
DeprecateSendActionTest.prototype[
`@test Using \`{{input ${e}="actionName"}}\` provides a deprecation`
] = function() {
- let expectedMessage = `Passing actions to components as strings (like \`{{input ${e}="foo-bar"}}\`) is deprecated. Please use closure actions instead (\`{{input ${e}=(action "foo-bar")}}\`)\. ('baz/foo-bar' @ L1:C0) `;
+ let expectedMessage = `Passing actions to components as strings (like \`{{input ${e}="foo-bar"}}\`) is deprecated. Please use closure actions instead (\`{{input ${e}=(action "foo-bar")}}\`). ('baz/foo-bar' @ L1:C0) `;
expectDeprecation(() => {
compile(`{{input ${e}="foo-bar"}}`, { moduleName: 'baz/foo-bar' });
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/ember-testing/tests/acceptance_test.js
|
@@ -63,7 +63,7 @@ if (!jQueryDisabled) {
<div class="posts-view">
<a class="dummy-link"></a>
<div id="comments-link">
- {{#link-to \'comments\'}}Comments{{/link-to}}
+ {{#link-to 'comments'}}Comments{{/link-to}}
</div>
</div>
`
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/ember-testing/tests/helpers_test.js
|
@@ -217,7 +217,7 @@ if (!jQueryDisabled) {
assertNoHelpers(assert, this.application, helpers);
}
- [`@test Ember.Application#removeTestHelpers resets the helperContainer\'s original values`](
+ [`@test Ember.Application#removeTestHelpers resets the helperContainer's original values`](
assert
) {
let helpers = { visit: 'snazzleflabber' };
| true |
Other
|
emberjs
|
ember.js
|
f1979539e79691d0faf04566cca8b4825d59209f.json
|
remove unnecessary escape
|
packages/internal-test-helpers/lib/equal-inner-html.js
|
@@ -18,7 +18,7 @@ function normalizeInnerHTML(actualHTML) {
actualHTML = actualHTML
.replace(/ xmlns="[^"]+"/, '')
.replace(
- /<([^ >]+) [^\/>]*\/>/gi,
+ /<([^ >]+) [^/>]*\/>/gi,
(tag, tagName) => `${tag.slice(0, tag.length - 3)}></${tagName}>`
);
}
| true |
Other
|
emberjs
|
ember.js
|
2242b45c2f36e0c8e21d3a617216f9a46d42e2ef.json
|
Add v3.19.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit 7e195d6e62f567769c4b05a0c408bdedf2f8d8df)
|
CHANGELOG.md
|
@@ -1,5 +1,14 @@
# Ember Changelog
+### v3.19.0-beta.1 (April 14, 2020)
+
+- [#18828](https://github.com/emberjs/ember.js/pull/18828) [BUGFIX] Prepend 'TODO: ' to 'Replace this with your real tests' comments in generated tests
+- [#18353](https://github.com/emberjs/ember.js/pull/18353) [BUGFIX] Improve `fn` & `on` undefined callback message
+- [#18824](https://github.com/emberjs/ember.js/pull/18824) [CLEANUP] Remove deprecated private `window.ENV`
+- [#18826](https://github.com/emberjs/ember.js/pull/18826) [CLEANUP] Remove deprecated private `_setComputedDecorator`
+- [#18832](https://github.com/emberjs/ember.js/pull/18832) [CLEANUP] Remove deprecated private`implicit-modifier-manager-capabilities`
+- [#18839](https://github.com/emberjs/ember.js/pull/18839) [CLEANUP] Updates the VM and autotracking APIs
+
### v3.18.0 (April 14, 2020)
- [#18869](https://github.com/emberjs/ember.js/pull/18869) / [#18861](https://github.com/emberjs/ember.js/pull/18861) / [#18811](https://github.com/emberjs/ember.js/pull/18811) [BUGFIX] Update to glimmer-vm 0.50.2.
| false |
Other
|
emberjs
|
ember.js
|
a3638c9a3f3d3b8f0d760bfec11c1b1c06adcb55.json
|
Update CHANGELOG.md for 3.16.7.
[ci skip]
(cherry picked from commit a2646ccb6de98852cd01730907de6a80e64b290f)
|
CHANGELOG.md
|
@@ -36,7 +36,11 @@
- [#18694](https://github.com/emberjs/ember.js/pull/18694) [BUGFIX] Ensure tag updates are buffered, remove error message
- [#18709](https://github.com/emberjs/ember.js/pull/18709) [BUGFIX] Fix `this` in `@tracked` initializer
-### v3.16.6
+### v3.16.7 (April 13, 2020)
+
+- [#18854](https://github.com/emberjs/ember.js/pull/18854) Pass value through to `PROPERTY_DID_CHANGE` to avoid calling `get` when setting values for computed props
+
+### v3.16.6 (March 24, 2020)
- [#18835](https://github.com/emberjs/ember.js/pull/18835) [BUGFIX] Make `ArrayProxy` Lazy.
| false |
Other
|
emberjs
|
ember.js
|
85f2e8c314e619eab64013cab753974974260bcd.json
|
Add v3.18.0 to CHANGELOG
[ci skip]
(cherry picked from commit 3d3a417df3ac1e59c9071a4db3d317abe4198e7e)
|
CHANGELOG.md
|
@@ -1,26 +1,8 @@
# Ember Changelog
-### v3.18.0-beta.5 (April 7, 2020)
-
-- [#18857](https://github.com/emberjs/ember.js/pull/18857) [BUGFIX] Pass value through to `PROPERTY_DID_CHANGE` to avoid calling `get` when setting values for computed props
-- [#18861](https://github.com/emberjs/ember.js/pull/18861) [BUGFIX] Update glimmer-vm to 0.50.1 to improve dev time performance.
-
-### v3.18.0-beta.4 (March 31, 2020)
-
-- [#18837](https://github.com/emberjs/ember.js/pull/18837) [BUGFIX] Fix `willDestroy` on class helpers
-- [#18838](https://github.com/emberjs/ember.js/pull/18838) [BUGFIX] Ensure destructors (e.g. `will-destroy` modifier, `@ember/component`s with `willDestroyElement`, etc) fire when used within an `{{#each}}` block.
-
-### v3.18.0-beta.3 (March 23, 2020)
-
-- [#18831](https://github.com/emberjs/ember.js/pull/18831) [BUGFIX] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+.
-
-### v3.18.0-beta.2 (March 16, 2020)
-
+### v3.18.0 (April 14, 2020)
+- [#18869](https://github.com/emberjs/ember.js/pull/18869) / [#18861](https://github.com/emberjs/ember.js/pull/18861) / [#18811](https://github.com/emberjs/ember.js/pull/18811) [BUGFIX] Update to glimmer-vm 0.50.2.
- [#18807](https://github.com/emberjs/ember.js/pull/18807) [BUGFIX] Do not error (RE: `elementId` changing) if `elementId` is not changed
-- [#18811](https://github.com/emberjs/ember.js/pull/18811) [BUGFIX] Upgrade to latest glimmer-vm
-
-### v3.18.0-beta.1 (March 5, 2020)
-
- [#18774](https://github.com/emberjs/ember.js/pull/18774) [BUGFIX] Suspend observer deactivation during property changes
- [#18785](https://github.com/emberjs/ember.js/pull/18785) Drop Node 8 support.
| false |
Other
|
emberjs
|
ember.js
|
19fb4a7eb8078c92c6c98b9c5ca98052722231e7.json
|
Add a simple (failing) test for named block usage
|
packages/@ember/-internals/glimmer/tests/integration/helpers/yield-test.js
|
@@ -7,7 +7,7 @@ import { Component } from '../../utils/helpers';
moduleFor(
'Helpers test: {{yield}} helper',
class extends RenderingTestCase {
- ['@test can yield to block']() {
+ ['@test can yield to a default block']() {
this.registerComponent('yield-comp', {
template: '[In layout:] {{yield}}',
});
@@ -26,6 +26,33 @@ moduleFor(
this.assertText('[In layout:] [In Block:] Seattle');
}
+ ['@feature(EMBER_NAMED_BLOCKS) can yield to a named block']() {
+ // This test fails when the default Ember component backing class is used:
+ this.registerComponent('yield-comp', {
+ template: '[In layout:] {{yield to="block"}}',
+
+ // It passes with no backing class:
+ // ComponentClass: null,
+
+ // And it passes using `GlimmerishComponent`:
+ // ComponentClass: require('../../utils/glimmerish-component').default,
+ });
+
+ this.render('<YieldComp><:block>[In block:] {{object.title}}</:block></YieldComp>', {
+ object: { title: 'Seattle' },
+ });
+
+ this.assertText('[In layout:] [In block:] Seattle');
+
+ this.assertStableRerender();
+
+ runTask(() => set(this.context, 'object.title', 'Vancouver'));
+ this.assertText('[In layout:] [In block:] Vancouver');
+
+ runTask(() => set(this.context, 'object', { title: 'Seattle' }));
+ this.assertText('[In layout:] [In block:] Seattle');
+ }
+
['@test templates should yield to block inside a nested component']() {
this.registerComponent('outer-comp', {
template: '<div>[In layout:] {{yield}}</div>',
| false |
Other
|
emberjs
|
ember.js
|
88ec6feeb7e0150a6422abd3f63e9a1fdcab3a8f.json
|
Add v3.18.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 6d3d800941cf3c9223af651ed7408e32417ae16e)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.18.0-beta.5 (April 7, 2020)
+
+- [#18857](https://github.com/emberjs/ember.js/pull/18857) [BUGFIX] Pass value through to `PROPERTY_DID_CHANGE` to avoid calling `get` when setting values for computed props
+- [#18861](https://github.com/emberjs/ember.js/pull/18861) [BUGFIX] Update glimmer-vm to 0.50.1 to improve dev time performance.
+
### v3.18.0-beta.4 (March 31, 2020)
- [#18837](https://github.com/emberjs/ember.js/pull/18837) [BUGFIX] Fix `willDestroy` on class helpers
| false |
Other
|
emberjs
|
ember.js
|
ad82c1b182d401f5c9107a00c2ca995f0ab3659c.json
|
Add v3.17.3 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -19,6 +19,10 @@
- [#18774](https://github.com/emberjs/ember.js/pull/18774) [BUGFIX] Suspend observer deactivation during property changes
- [#18785](https://github.com/emberjs/ember.js/pull/18785) Drop Node 8 support.
+### v3.17.3 (April 2, 2020)
+
+- [#18857](https://github.com/emberjs/ember.js/pull/18857) Pass value through to `PROPERTY_DID_CHANGE` to avoid calling `get` when setting values for computed props
+
### v3.17.2 (March 26, 2020)
- [#18837](https://github.com/emberjs/ember.js/pull/18837) [BUGFIX] Fix `willDestroy` on class based helpers.
| false |
Other
|
emberjs
|
ember.js
|
5e90b4928186d8a14d346ecc56b41ff31aab7b79.json
|
Add v3.18.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 49cb096b10c040cc3e03a5c4223a52b4b8a71979)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.18.0-beta.4 (March 31, 2020)
+
+- [#18837](https://github.com/emberjs/ember.js/pull/18837) [BUGFIX] Fix `willDestroy` on class helpers
+- [#18838](https://github.com/emberjs/ember.js/pull/18838) [BUGFIX] Ensure destructors (e.g. `will-destroy` modifier, `@ember/component`s with `willDestroyElement`, etc) fire when used within an `{{#each}}` block.
+
### v3.18.0-beta.3 (March 23, 2020)
- [#18831](https://github.com/emberjs/ember.js/pull/18831) [BUGFIX] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+.
| false |
Other
|
emberjs
|
ember.js
|
b3ce4bbb942ef7b1c72a353643ff58db6075932c.json
|
update license to 2020
|
LICENSE
|
@@ -1,4 +1,4 @@
-Copyright (c) 2019 Yehuda Katz, Tom Dale and Ember.js contributors
+Copyright (c) 2020 Yehuda Katz, Tom Dale and Ember.js contributors
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
| true |
Other
|
emberjs
|
ember.js
|
b3ce4bbb942ef7b1c72a353643ff58db6075932c.json
|
update license to 2020
|
generators/license.js
|
@@ -1,6 +1,6 @@
/*!
* @overview Ember - JavaScript Application Framework
- * @copyright Copyright 2011-2019 Tilde Inc. and contributors
+ * @copyright Copyright 2011-2020 Tilde Inc. and contributors
* Portions Copyright 2006-2011 Strobe Inc.
* Portions Copyright 2008-2011 Apple Inc. All rights reserved.
* @license Licensed under MIT license
| true |
Other
|
emberjs
|
ember.js
|
1370ef5ebea1511b3e225b5704c41edde6caa7eb.json
|
Add v3.17.2 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -14,6 +14,11 @@
- [#18774](https://github.com/emberjs/ember.js/pull/18774) [BUGFIX] Suspend observer deactivation during property changes
- [#18785](https://github.com/emberjs/ember.js/pull/18785) Drop Node 8 support.
+### v3.17.2 (March 26, 2020)
+
+- [#18837](https://github.com/emberjs/ember.js/pull/18837) [BUGFIX] Fix `willDestroy` on class based helpers.
+- [#18838](https://github.com/emberjs/ember.js/pull/18838) [BUGFIX] Ensure destructors (e.g. `will-destroy` modifier, `@ember/component`s with `willDestroyElement`, etc) fire when used within an `{{#each}}` block.
+
### v3.17.1 (March 22, 2020)
- [#18809](https://github.com/emberjs/ember.js/pull/18809) [BUGFIX] Do not error (RE: `elementId` changing) if `elementId` is not changed
| false |
Other
|
emberjs
|
ember.js
|
a58024239345addcf74009f7ac2eb15665adbca2.json
|
Add v3.16.6 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -35,6 +35,10 @@
- [#18694](https://github.com/emberjs/ember.js/pull/18694) [BUGFIX] Ensure tag updates are buffered, remove error message
- [#18709](https://github.com/emberjs/ember.js/pull/18709) [BUGFIX] Fix `this` in `@tracked` initializer
+### v3.16.6
+
+- [#18835](https://github.com/emberjs/ember.js/pull/18835) [BUGFIX] Make `ArrayProxy` Lazy.
+
### v3.16.5 (March 23, 2020)
- [#18831](https://github.com/emberjs/ember.js/pull/18831) [BUGFIX] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+.
| false |
Other
|
emberjs
|
ember.js
|
33c4d56733c5965297dc9130adf728c4699f073f.json
|
Add v3.18.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit b6fa9cb84555122dbe9f96d86b5e684fc7cdf408)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.18.0-beta.3 (March 23, 2020)
+
+- [#18831](https://github.com/emberjs/ember.js/pull/18831) [BUGFIX] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+.
+
### v3.18.0-beta.2 (March 16, 2020)
- [#18807](https://github.com/emberjs/ember.js/pull/18807) [BUGFIX] Do not error (RE: `elementId` changing) if `elementId` is not changed
| false |
Other
|
emberjs
|
ember.js
|
efdbce3d1321652b0b9ad55a5837d8fd9cb15b42.json
|
Add v3.16.5 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -31,6 +31,10 @@
- [#18694](https://github.com/emberjs/ember.js/pull/18694) [BUGFIX] Ensure tag updates are buffered, remove error message
- [#18709](https://github.com/emberjs/ember.js/pull/18709) [BUGFIX] Fix `this` in `@tracked` initializer
+### v3.16.5 (March 23, 2020)
+
+- [#18831](https://github.com/emberjs/ember.js/pull/18831) [BUGFIX] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+.
+
### v3.16.4 (March 22, 2020)
- [#18741](https://github.com/emberjs/ember.js/pull/18741) [BUGFIX] Don't setup mandatory setters on array indexes
| false |
Other
|
emberjs
|
ember.js
|
0fad0261871916041f82187a6aed1f11ad092d53.json
|
Add v3.16.4 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -31,6 +31,14 @@
- [#18694](https://github.com/emberjs/ember.js/pull/18694) [BUGFIX] Ensure tag updates are buffered, remove error message
- [#18709](https://github.com/emberjs/ember.js/pull/18709) [BUGFIX] Fix `this` in `@tracked` initializer
+### v3.16.4 (March 22, 2020)
+
+- [#18741](https://github.com/emberjs/ember.js/pull/18741) [BUGFIX] Don't setup mandatory setters on array indexes
+- [#18742](https://github.com/emberjs/ember.js/pull/18742) [BUGFIX] Fix `setDiff` computed macro used within glimmer component
+- [#18767](https://github.com/emberjs/ember.js/pull/18767) [BUGFIX] Fix `observer` leaks.
+- [#18780](https://github.com/emberjs/ember.js/pull/18780) [BUGFIX] Fix `owner.ownerInjection()` when used to create services directly
+- [#18810](https://github.com/emberjs/ember.js/pull/18810) [BUGFIX] Do not error (RE: elementId changing) if elementId is not changed
+
### v3.16.3 (February 18, 2020)
- [#18730](https://github.com/emberjs/ember.js/pull/18730) Workaround for the Glimmer VM bug which encodes/decodes integer literals correctly.
| false |
Other
|
emberjs
|
ember.js
|
da1dde24ce7743da39c8b53d14bb9efb84a8beaa.json
|
Add v3.17.1 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -10,6 +10,11 @@
- [#18774](https://github.com/emberjs/ember.js/pull/18774) [BUGFIX] Suspend observer deactivation during property changes
- [#18785](https://github.com/emberjs/ember.js/pull/18785) Drop Node 8 support.
+### v3.17.1 (March 22, 2020)
+
+- [#18809](https://github.com/emberjs/ember.js/pull/18809) [BUGFIX] Do not error (RE: `elementId` changing) if `elementId` is not changed
+- [#18831](https://github.com/emberjs/ember.js/pull/18831) [BUGFIX] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+.
+
### v3.17.0 (March 4, 2020)
- [#18688](https://github.com/emberjs/ember.js/pull/18688) / [#18621](https://github.com/emberjs/ember.js/pull/18621) / [#18714](https://github.com/emberjs/ember.js/pull/18714) / [#18743](https://github.com/emberjs/ember.js/pull/18743) / [#18762](https://github.com/emberjs/ember.js/pull/18762) Upgrades Glimmer VM to 0.47.9, fixes ignored `checked` attribute on `input`, fixes using `array` and `hash` helper together
| false |
Other
|
emberjs
|
ember.js
|
4c633b00e2567ea5a7a4178d770d332854f763a7.json
|
remove test for modifier capabilities deprecation
|
packages/@ember/-internals/glimmer/tests/integration/custom-modifier-manager-test.js
|
@@ -103,39 +103,6 @@ moduleFor(
runTask(() => set(this.context, 'truthy', true));
}
- '@test requires modifier capabilities'() {
- class WithoutCapabilities extends CustomModifierManager {
- constructor(owner) {
- super(owner);
- this.capabilities = undefined;
- }
- }
-
- let ModifierClass = setModifierManager(
- owner => {
- return new WithoutCapabilities(owner);
- },
- EmberObject.extend({
- didInsertElement() {},
- didUpdate() {},
- willDestroyElement() {},
- })
- );
-
- this.registerModifier(
- 'foo-bar',
- ModifierClass.extend({
- didUpdate() {},
- didInsertElement() {},
- willDestroyElement() {},
- })
- );
-
- expectDeprecation(() => {
- this.render('<h1 {{foo-bar truthy}}>hello world</h1>');
- }, /Custom modifier managers must define their capabilities/);
- }
-
'@test associates manager even through an inheritance structure'(assert) {
assert.expect(5);
let ModifierClass = setModifierManager(
| false |
Other
|
emberjs
|
ember.js
|
e208961a3303df6749bb571579e9f73d48a9c2bf.json
|
Add v3.18.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 8422dda393ea0477eb6ef0db4c94ef6320f15728)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.18.0-beta.2 (March 16, 2020)
+
+- [#18807](https://github.com/emberjs/ember.js/pull/18807) [BUGFIX] Do not error (RE: `elementId` changing) if `elementId` is not changed
+- [#18811](https://github.com/emberjs/ember.js/pull/18811) [BUGFIX] Upgrade to latest glimmer-vm
+
### v3.18.0-beta.1 (March 5, 2020)
- [#18774](https://github.com/emberjs/ember.js/pull/18774) [BUGFIX] Suspend observer deactivation during property changes
| false |
Other
|
emberjs
|
ember.js
|
8b9cea7ac96785bc1bc93f54ab9d937f762dbf41.json
|
Add v3.12.3 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -120,6 +120,10 @@
- [#18217](https://github.com/emberjs/ember.js/pull/18217) [BUGFIX] Adds ability for computed props to depend on args
- [#18222](https://github.com/emberjs/ember.js/pull/18222) [BUGFIX] Matches assertion behavior for CPs computing after destroy
+### v3.12.3 (March 12, 2020)
+
+- [#18809](https://github.com/emberjs/ember.js/pull/18809) [BUGFIX] Do not error (RE: `elementId` changing) if `elementId` is not changed
+
### v3.12.2 (December 4, 2019)
- [#18576](https://github.com/emberjs/ember.js/pull/18576) [BUGFIX] Fix leftover `const` expressions in legacy builds
| false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.