language
stringclasses 1
value | owner
stringlengths 2
15
| repo
stringlengths 2
21
| sha
stringlengths 45
45
| message
stringlengths 7
36.3k
| path
stringlengths 1
199
| patch
stringlengths 15
102k
| is_multipart
bool 2
classes |
|---|---|---|---|---|---|---|---|
Other
|
emberjs
|
ember.js
|
6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json
|
fix: forbid throwing of literals
|
node-tests/blueprints/component-test-test.js
|
@@ -177,7 +177,7 @@ describe('Blueprint: component-test', function() {
it('component-test x-foo --unit', function() {
return emberGenerate(['component-test', 'x-foo', '--unit'])
.then(() => {
- throw 'the command should raise an exception';
+ throw new Error('the command should raise an exception');
})
.catch(error => {
expect(error).to.equal("The --unit flag isn't supported within a module unification app");
| true |
Other
|
emberjs
|
ember.js
|
6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json
|
fix: forbid throwing of literals
|
node-tests/helpers/expect-error.js
|
@@ -6,7 +6,7 @@ const expect = chai.expect;
module.exports = function expectError(promise, expectedErrorText) {
return promise
.then(() => {
- throw 'the command should raise an exception';
+ throw new Error('the command should raise an exception');
})
.catch(error => {
expect(error).to.equal(expectedErrorText);
| true |
Other
|
emberjs
|
ember.js
|
6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json
|
fix: forbid throwing of literals
|
packages/ember/tests/routing/decoupled_basic_test.js
|
@@ -767,7 +767,7 @@ moduleFor(
'route:special',
Route.extend({
setup() {
- throw 'Setup error';
+ throw new Error('Setup error');
},
actions: {
error(reason) {
@@ -827,7 +827,7 @@ moduleFor(
'route:special',
Route.extend({
setup() {
- throw 'Setup error';
+ throw new Error('Setup error');
},
})
);
| true |
Other
|
emberjs
|
ember.js
|
4534399097361c17f3f568b6d2599761ca97f38e.json
|
Remove duplicate in is-present-helper
|
packages/@ember/-internals/metal/lib/is_present.ts
|
@@ -20,7 +20,6 @@ import isBlank from './is_blank';
isPresent(0); // true
isPresent(function() {}); // true
isPresent({}); // true
- isPresent(false); // true
isPresent('\n\t Hello'); // true
isPresent([1, 2, 3]); // true
```
| false |
Other
|
emberjs
|
ember.js
|
aca371cb177d504cf844fb81b7de70578e29e611.json
|
use willDestroy in stead of destroy
|
packages/@ember/-internals/runtime/lib/mixins/-proxy.js
|
@@ -61,9 +61,9 @@ export default Mixin.create({
m.writableTag(() => combine([DirtyableTag.create(), UpdatableTag.create(CONSTANT_TAG)]));
},
- destroy() {
- this._super(...arguments);
+ willDestroy() {
this.set('content', null);
+ this._super(...arguments);
},
isTruthy: computed('content', function() {
| false |
Other
|
emberjs
|
ember.js
|
e8b58eed1b58edd902ba5b6782cc18ccdb3b7c34.json
|
add mocha rfc 232 test blueprints for helpers
|
blueprints/helper-test/mocha-rfc-232-files/tests/__testType__/__path__/__name__-test.js
|
@@ -0,0 +1,28 @@
+import { expect } from 'chai';
+<% if (testType == 'integration') { %>import { describe, it } from 'mocha';
+import { setupRenderingTest } from 'ember-mocha';
+import { render } from '@ember/test-helpers';
+import hbs from 'htmlbars-inline-precompile';
+
+describe('<%= friendlyTestName %>', function() {
+ setupRenderingTest();
+
+ // Replace this with your real tests.
+ it('renders', async function() {
+ this.set('inputValue', '1234');
+
+ await render(hbs`{{<%= dasherizedModuleName %> inputValue}}`);
+
+ expect(this.element.textContent.trim()).to.equal('1234');
+ });
+});<% } else if (testType == 'unit') { %>import { describe, it } from 'mocha';
+import { <%= camelizedModuleName %> } from '<%= dasherizedPackageName %>/helpers/<%= dasherizedModuleName %>';
+
+describe('<%= friendlyTestName %>', function() {
+
+ // Replace this with your real tests.
+ it('works', function() {
+ let result = <%= camelizedModuleName %>(42);
+ expect(result).to.be.ok;
+ });
+});<% } %>
| true |
Other
|
emberjs
|
ember.js
|
e8b58eed1b58edd902ba5b6782cc18ccdb3b7c34.json
|
add mocha rfc 232 test blueprints for helpers
|
node-tests/blueprints/helper-test-test.js
|
@@ -109,6 +109,32 @@ describe('Blueprint: helper-test', function() {
});
});
});
+
+ describe('with [email protected]', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
+ generateFakePackageManifest('ember-mocha', '0.14.0');
+ });
+
+ it('helper-test foo/bar-baz for mocha', function() {
+ return emberGenerateDestroy(['helper-test', 'foo/bar-baz'], _file => {
+ expect(_file('tests/integration/helpers/foo/bar-baz-test.js')).to.equal(
+ fixture('helper-test/mocha-rfc232.js')
+ );
+ });
+ });
+
+ it('helper-test foo/bar-baz for mocha --unit', function() {
+ return emberGenerateDestroy(['helper-test', 'foo/bar-baz', '--unit'], _file => {
+ expect(_file('tests/unit/helpers/foo/bar-baz-test.js')).to.equal(
+ fixture('helper-test/mocha-rfc232-unit.js')
+ );
+ });
+ });
+ });
});
describe('in addon', function() {
| true |
Other
|
emberjs
|
ember.js
|
e8b58eed1b58edd902ba5b6782cc18ccdb3b7c34.json
|
add mocha rfc 232 test blueprints for helpers
|
node-tests/fixtures/helper-test/mocha-rfc232-unit.js
|
@@ -0,0 +1,12 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { fooBarBaz } from 'my-app/helpers/foo/bar-baz';
+
+describe('Unit | Helper | foo/bar-baz', function() {
+
+ // Replace this with your real tests.
+ it('works', function() {
+ let result = fooBarBaz(42);
+ expect(result).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
e8b58eed1b58edd902ba5b6782cc18ccdb3b7c34.json
|
add mocha rfc 232 test blueprints for helpers
|
node-tests/fixtures/helper-test/mocha-rfc232.js
|
@@ -0,0 +1,18 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupRenderingTest } from 'ember-mocha';
+import { render } from '@ember/test-helpers';
+import hbs from 'htmlbars-inline-precompile';
+
+describe('Integration | Helper | foo/bar-baz', function() {
+ setupRenderingTest();
+
+ // Replace this with your real tests.
+ it('renders', async function() {
+ this.set('inputValue', '1234');
+
+ await render(hbs`{{foo/bar-baz inputValue}}`);
+
+ expect(this.element.textContent.trim()).to.equal('1234');
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
d73ca4c96abbebc8ff060593dcf5f48eaddcd16c.json
|
add RFC 232 mocha controller tests
|
blueprints/controller-test/mocha-rfc-232-files/__root__/__testType__/__path__/__test__.js
|
@@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('<%= friendlyTestDescription %>', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let controller = this.owner.lookup('controller:<%= controllerPathName %>');
+ expect(controller).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
d73ca4c96abbebc8ff060593dcf5f48eaddcd16c.json
|
add RFC 232 mocha controller tests
|
node-tests/blueprints/controller-test-test.js
|
@@ -110,6 +110,32 @@ describe('Blueprint: controller-test', function() {
});
});
});
+
+ describe('with [email protected]', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
+ generateFakePackageManifest('ember-mocha', '0.14.0');
+ });
+
+ it('controller-test foo', function() {
+ return emberGenerateDestroy(['controller-test', 'foo'], _file => {
+ expect(_file('tests/unit/controllers/foo-test.js')).to.equal(
+ fixture('controller-test/mocha-rfc232.js')
+ );
+ });
+ });
+
+ it('controller-test foo/bar', function() {
+ return emberGenerateDestroy(['controller-test', 'foo/bar'], _file => {
+ expect(_file('tests/unit/controllers/foo/bar-test.js')).to.equal(
+ fixture('controller-test/mocha-rfc232-nested.js')
+ );
+ });
+ });
+ });
});
describe('in app - module unification', function() {
@@ -206,6 +232,32 @@ describe('Blueprint: controller-test', function() {
});
});
});
+
+ describe('with [email protected]', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
+ generateFakePackageManifest('ember-mocha', '0.14.0');
+ });
+
+ it('controller-test foo', function() {
+ return emberGenerateDestroy(['controller-test', 'foo'], _file => {
+ expect(_file('src/ui/routes/foo/controller-test.js')).to.equal(
+ fixture('controller-test/mocha-rfc232.js')
+ );
+ });
+ });
+
+ it('controller-test foo/bar', function() {
+ return emberGenerateDestroy(['controller-test', 'foo/bar'], _file => {
+ expect(_file('src/ui/routes/foo/bar/controller-test.js')).to.equal(
+ fixture('controller-test/mocha-rfc232-nested.js')
+ );
+ });
+ });
+ });
});
describe('in addon', function() {
| true |
Other
|
emberjs
|
ember.js
|
d73ca4c96abbebc8ff060593dcf5f48eaddcd16c.json
|
add RFC 232 mocha controller tests
|
node-tests/fixtures/controller-test/mocha-rfc232-nested.js
|
@@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('Unit | Controller | foo/bar', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let controller = this.owner.lookup('controller:foo/bar');
+ expect(controller).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
d73ca4c96abbebc8ff060593dcf5f48eaddcd16c.json
|
add RFC 232 mocha controller tests
|
node-tests/fixtures/controller-test/mocha-rfc232.js
|
@@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('Unit | Controller | foo', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let controller = this.owner.lookup('controller:foo');
+ expect(controller).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
75adb683aac7dc203340a8b6533fbe322b89880a.json
|
add mocha rfc 232 route blueprint
|
blueprints/route-test/mocha-rfc-232-files/__root__/__testType__/__path__/__test__.js
|
@@ -0,0 +1,12 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('<%= friendlyTestDescription %>', function() {
+ setupTest();
+
+ it('exists', function() {
+ let route = this.owner.lookup('route:<%= dasherizedModuleName %>');
+ expect(route).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
75adb683aac7dc203340a8b6533fbe322b89880a.json
|
add mocha rfc 232 route blueprint
|
node-tests/blueprints/route-test-test.js
|
@@ -71,6 +71,24 @@ describe('Blueprint: route-test', function() {
});
});
});
+
+ describe('with [email protected]', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
+ generateFakePackageManifest('ember-mocha', '0.14.0');
+ });
+
+ it('route-test foo', function() {
+ return emberGenerateDestroy(['route-test', 'foo'], _file => {
+ expect(_file('tests/unit/routes/foo-test.js')).to.equal(
+ fixture('route-test/mocha-rfc232.js')
+ );
+ });
+ });
+ });
});
describe('in addon', function() {
| true |
Other
|
emberjs
|
ember.js
|
75adb683aac7dc203340a8b6533fbe322b89880a.json
|
add mocha rfc 232 route blueprint
|
node-tests/fixtures/route-test/mocha-rfc232.js
|
@@ -0,0 +1,12 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('Unit | Route | foo', function() {
+ setupTest();
+
+ it('exists', function() {
+ let route = this.owner.lookup('route:foo');
+ expect(route).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
2efbfac00652c97a89ba7eadc9a15796648790ea.json
|
add mocha rfc 232 util test
|
blueprints/util-test/mocha-rfc-232-files/__root__/__testType__/__name__-test.js
|
@@ -0,0 +1,11 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import <%= camelizedModuleName %> from '<%= dasherizedPackageName %>/utils/<%= dasherizedModuleName %>';
+
+describe('<%= friendlyTestName %>', function() {
+ // Replace this with your real tests.
+ it('works', function() {
+ let result = <%= camelizedModuleName %>();
+ expect(result).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
2efbfac00652c97a89ba7eadc9a15796648790ea.json
|
add mocha rfc 232 util test
|
node-tests/blueprints/util-test-test.js
|
@@ -55,6 +55,24 @@ describe('Blueprint: util-test', function() {
});
});
});
+
+ describe('with [email protected]', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
+ generateFakePackageManifest('ember-mocha', '0.14.0');
+ });
+
+ it('util-test foo-bar', function() {
+ return emberGenerateDestroy(['util-test', 'foo-bar'], _file => {
+ expect(_file('tests/unit/utils/foo-bar-test.js')).to.equal(
+ fixture('util-test/mocha-rfc232.js')
+ );
+ });
+ });
+ });
});
describe('in app - module uninification', function() {
| true |
Other
|
emberjs
|
ember.js
|
2efbfac00652c97a89ba7eadc9a15796648790ea.json
|
add mocha rfc 232 util test
|
node-tests/fixtures/util-test/mocha-rfc232.js
|
@@ -0,0 +1,11 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import fooBar from 'my-app/utils/foo-bar';
+
+describe('Unit | Utility | foo-bar', function() {
+ // Replace this with your real tests.
+ it('works', function() {
+ let result = fooBar();
+ expect(result).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
4f51ebd5c47ec3e8089eadc2bdbfeca5f11f7581.json
|
add mocha rfc 232 service test blueprint
|
blueprints/service-test/mocha-rfc-232-files/__root__/__testType__/__path__/__test__.js
|
@@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('<%= friendlyTestDescription %>', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let service = this.owner.lookup('service:<%= dasherizedModuleName %>');
+ expect(service).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
4f51ebd5c47ec3e8089eadc2bdbfeca5f11f7581.json
|
add mocha rfc 232 service test blueprint
|
node-tests/blueprints/service-test-test.js
|
@@ -80,6 +80,24 @@ describe('Blueprint: service-test', function() {
});
});
+ describe('with [email protected]', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
+ generateFakePackageManifest('ember-mocha', '0.14.0');
+ });
+
+ it('service-test foo', function() {
+ return emberGenerateDestroy(['service-test', 'foo'], _file => {
+ expect(_file('tests/unit/services/foo-test.js')).to.equal(
+ fixture('service-test/mocha-rfc232.js')
+ );
+ });
+ });
+ });
+
describe('with [email protected]', function() {
beforeEach(function() {
generateFakePackageManifest('ember-cli-qunit', '4.2.0');
| true |
Other
|
emberjs
|
ember.js
|
4f51ebd5c47ec3e8089eadc2bdbfeca5f11f7581.json
|
add mocha rfc 232 service test blueprint
|
node-tests/fixtures/service-test/mocha-rfc232.js
|
@@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('Unit | Service | foo', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let service = this.owner.lookup('service:foo');
+ expect(service).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
95cb1d274c1cda6f9ee2e68d99a03dfe7b0449f6.json
|
add rfc 232 mocha mixin blueprint
|
blueprints/mixin-test/mocha-rfc-232-files/__root__/__testType__/__name__-test.js
|
@@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import EmberObject from '@ember/object';
+import <%= classifiedModuleName %>Mixin from '<%= dasherizedPackageName %>/mixins/<%= dasherizedModuleName %>';
+
+describe('<%= friendlyTestName %>', function() {
+ // Replace this with your real tests.
+ it('works', function() {
+ let <%= classifiedModuleName %>Object = EmberObject.extend(<%= classifiedModuleName %>Mixin);
+ let subject = <%= classifiedModuleName %>Object.create();
+ expect(subject).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
95cb1d274c1cda6f9ee2e68d99a03dfe7b0449f6.json
|
add rfc 232 mocha mixin blueprint
|
node-tests/blueprints/mixin-test-test.js
|
@@ -53,6 +53,24 @@ describe('Blueprint: mixin-test', function() {
});
});
});
+
+ describe('with [email protected]', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
+ generateFakePackageManifest('ember-mocha', '0.14.0');
+ });
+
+ it('mixin-test foo', function() {
+ return emberGenerateDestroy(['mixin-test', 'foo'], _file => {
+ expect(_file('tests/unit/mixins/foo-test.js')).to.equal(
+ fixture('mixin-test/mocha-rfc232.js')
+ );
+ });
+ });
+ });
});
describe('in app - module unification', function() {
| true |
Other
|
emberjs
|
ember.js
|
95cb1d274c1cda6f9ee2e68d99a03dfe7b0449f6.json
|
add rfc 232 mocha mixin blueprint
|
node-tests/fixtures/mixin-test/mocha-rfc232.js
|
@@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import EmberObject from '@ember/object';
+import FooMixin from 'my-app/mixins/foo';
+
+describe('Unit | Mixin | foo', function() {
+ // Replace this with your real tests.
+ it('works', function() {
+ let FooObject = EmberObject.extend(FooMixin);
+ let subject = FooObject.create();
+ expect(subject).to.be.ok;
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
73012f9d4ec06b7e3e6a09fe56b1a7bccd3dc7e3.json
|
Correct doc on paths for component templates
|
packages/@ember/-internals/glimmer/index.ts
|
@@ -15,7 +15,7 @@
});
```
- ```app/components/person-profile.hbs
+ ```app/templates/components/person-profile.hbs
{{name}}
<div>{{name}}</div>
<span data-name={{name}}></span>
| true |
Other
|
emberjs
|
ember.js
|
73012f9d4ec06b7e3e6a09fe56b1a7bccd3dc7e3.json
|
Correct doc on paths for component templates
|
packages/@ember/-internals/glimmer/lib/component.ts
|
@@ -38,15 +38,15 @@ export const BOUNDS = symbol('BOUNDS');
The easiest way to create a `Component` is via
a template. If you name a template
- `app/components/my-foo.hbs`, you will be able to use
+ `app/templates/components/my-foo.hbs`, you will be able to use
`{{my-foo}}` in other templates, which will make
an instance of the isolated component.
- ```app/components/my-foo.hbs
+ ```app/templates/components/my-foo.hbs
{{person-profile person=currentUser}}
```
- ```app/components/person-profile.hbs
+ ```app/templates/components/person-profile.hbs
<h1>{{person.title}}</h1>
<img src={{person.avatar}}>
<p class='signature'>{{person.signature}}</p>
@@ -64,7 +64,7 @@ export const BOUNDS = symbol('BOUNDS');
{{/person-profile}}
```
- ```app/components/person-profile.hbs
+ ```app/templates/components/person-profile.hbs
<h1>{{person.title}}</h1>
{{! Executed in the component's context. }}
{{yield}} {{! block contents }}
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/@ember/-internals/environment/lib/env.ts
|
@@ -111,10 +111,6 @@ export const ENV = {
*/
_JQUERY_INTEGRATION: true,
- // the following for addon support
- _ENABLE_ORPHANED_OUTLETS_SUPPORT: false,
- _ENABLE_RENDER_SUPPORT: false,
-
EMBER_LOAD_HOOKS: {} as {
[hook: string]: Function[];
},
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/@ember/-internals/glimmer/lib/component-managers/render.ts
|
@@ -1,166 +0,0 @@
-import { RENDER_HELPER } from '@ember/deprecated-features';
-import { ComponentCapabilities } from '@glimmer/interfaces';
-import { CONSTANT_TAG, Tag, VersionedPathReference } from '@glimmer/reference';
-import { Arguments, ComponentDefinition, Invocation, WithStaticLayout } from '@glimmer/runtime';
-
-import { Owner } from '@ember/-internals/owner';
-import { generateController, generateControllerFactory } from '@ember/-internals/routing';
-import { OwnedTemplateMeta } from '@ember/-internals/views';
-import { DEBUG } from '@glimmer/env';
-import Environment from '../environment';
-import { OwnedTemplate } from '../template';
-import { RootReference } from '../utils/references';
-import AbstractManager from './abstract';
-
-export interface RenderDefinitionState {
- name: string;
- template: OwnedTemplate;
-}
-
-export interface RenderState {
- controller: any;
-}
-
-export interface RenderStateWithModel extends RenderState {
- model: VersionedPathReference<any>;
-}
-
-let NON_SINGLETON_RENDER_MANAGER: any;
-let SINGLETON_RENDER_MANAGER: any;
-let RenderDefinition: {
- new (name: string, template: OwnedTemplate, manager: any): ComponentDefinition;
-};
-
-if (RENDER_HELPER) {
- abstract class AbstractRenderManager<T extends RenderState>
- extends AbstractManager<T, RenderDefinitionState>
- implements WithStaticLayout<T, RenderDefinitionState, OwnedTemplateMeta, any> {
- create(
- env: Environment,
- definition: RenderDefinitionState,
- args: Arguments
- ): T {
- let { name } = definition;
-
- if (DEBUG) {
- this._pushToDebugStack(`controller:${name} (with the render helper)`, env);
- }
-
- return this.createRenderState(args, env.owner, name);
- }
-
- abstract createRenderState(args: Arguments, owner: Owner, name: string): T;
-
- getLayout({ template }: RenderDefinitionState): Invocation {
- const layout = template!.asLayout();
- return {
- handle: layout.compile(),
- symbolTable: layout.symbolTable,
- };
- }
-
- getSelf({ controller }: T) {
- return new RootReference(controller);
- }
- }
-
- if (DEBUG) {
- AbstractRenderManager.prototype.didRenderLayout = function() {
- this.debugStack.pop();
- };
- }
-
- const CAPABILITIES = {
- dynamicLayout: false,
- dynamicTag: false,
- prepareArgs: false,
- createArgs: false,
- attributeHook: false,
- elementHook: false,
- createCaller: true,
- dynamicScope: true,
- updateHook: true,
- createInstance: true,
- };
-
- class SingletonRenderManager extends AbstractRenderManager<RenderState> {
- createRenderState(_args: Arguments, owner: Owner, name: string) {
- let controller = owner.lookup<any>(`controller:${name}`) || generateController(owner, name);
- return { controller };
- }
-
- getCapabilities(_: RenderDefinitionState): ComponentCapabilities {
- return CAPABILITIES;
- }
-
- getTag(): Tag {
- // todo this should be the tag of the state args
- return CONSTANT_TAG;
- }
-
- getDestructor() {
- return null;
- }
- }
-
- SINGLETON_RENDER_MANAGER = new SingletonRenderManager();
-
- const NONSINGLETON_CAPABILITIES: ComponentCapabilities = {
- dynamicLayout: false,
- dynamicTag: false,
- prepareArgs: false,
- createArgs: true,
- attributeHook: false,
- elementHook: false,
- dynamicScope: true,
- createCaller: false,
- updateHook: true,
- createInstance: true,
- };
-
- class NonSingletonRenderManager extends AbstractRenderManager<RenderStateWithModel> {
- createRenderState(args: Arguments, owner: Owner, name: string) {
- let model = args.positional.at(1);
- let factory =
- owner.factoryFor(`controller:${name}`) ||
- generateControllerFactory(owner, `controller:${name}`);
- let controller = factory.create({ model: model.value() });
- return { controller, model };
- }
-
- update({ controller, model }: RenderStateWithModel) {
- controller.set('model', model.value());
- }
-
- getCapabilities(_: RenderDefinitionState): ComponentCapabilities {
- return NONSINGLETON_CAPABILITIES;
- }
-
- getTag({ model }: RenderStateWithModel): Tag {
- return model.tag;
- }
-
- getDestructor({ controller }: RenderStateWithModel) {
- return controller;
- }
- }
-
- NON_SINGLETON_RENDER_MANAGER = new NonSingletonRenderManager();
-
- RenderDefinition = class RenderDefinition implements ComponentDefinition {
- public state: RenderDefinitionState;
-
- constructor(
- name: string,
- template: OwnedTemplate,
- public manager: SingletonRenderManager | NonSingletonRenderManager
- ) {
- this.state = {
- name,
- template,
- };
- }
- };
-}
-
-export { RenderDefinition, NON_SINGLETON_RENDER_MANAGER, SINGLETON_RENDER_MANAGER };
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/@ember/-internals/glimmer/lib/resolver.ts
|
@@ -4,7 +4,6 @@ import { LookupOptions, Owner, setOwner } from '@ember/-internals/owner';
import { lookupComponent, lookupPartial, OwnedTemplateMeta } from '@ember/-internals/views';
import { EMBER_MODULE_UNIFICATION, GLIMMER_CUSTOM_COMPONENT_MANAGER } from '@ember/canary-features';
import { assert } from '@ember/debug';
-import { RENDER_HELPER } from '@ember/deprecated-features';
import { _instrumentStart } from '@ember/instrumentation';
import {
ComponentDefinition,
@@ -38,7 +37,6 @@ import ActionModifierManager from './modifiers/action';
import { populateMacros } from './syntax';
import { mountHelper } from './syntax/mount';
import { outletHelper } from './syntax/outlet';
-import { renderHelper } from './syntax/render';
import { Factory as TemplateFactory, Injections, OwnedTemplate } from './template';
import { getComponentManager } from './utils/custom-component-manager';
import { ClassBasedHelperReference, SimpleHelperReference } from './utils/references';
@@ -76,10 +74,6 @@ const BUILTINS_HELPERS = {
'-outlet': outletHelper,
};
-if (RENDER_HELPER) {
- BUILTINS_HELPERS['-render'] = renderHelper;
-}
-
const BUILTIN_MODIFIERS = {
action: new ActionModifierManager(),
};
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/@ember/-internals/glimmer/lib/syntax.ts
|
@@ -1,7 +1,6 @@
import { OwnedTemplateMeta } from '@ember/-internals/views';
import { EMBER_TEMPLATE_BLOCK_LET_HELPER } from '@ember/canary-features';
import { assert } from '@ember/debug';
-import { RENDER_HELPER } from '@ember/deprecated-features';
import { CompilableBlock } from '@glimmer/interfaces';
import { Macros, OpcodeBuilder } from '@glimmer/opcode-compiler';
import { Option } from '@glimmer/util';
@@ -12,7 +11,6 @@ import { inputMacro } from './syntax/input';
import { blockLetMacro } from './syntax/let';
import { mountMacro } from './syntax/mount';
import { outletMacro } from './syntax/outlet';
-import { renderMacro } from './syntax/render';
import { hashToArgs } from './syntax/utils';
import { wrapComponentClassAttribute } from './utils/bindings';
@@ -98,9 +96,6 @@ export function registerMacros(macro: any) {
export function populateMacros(macros: Macros) {
let { inlines, blocks } = macros;
inlines.add('outlet', outletMacro);
- if (RENDER_HELPER) {
- inlines.add('render', renderMacro);
- }
inlines.add('mount', mountMacro);
inlines.add('input', inputMacro);
inlines.add('textarea', textAreaMacro);
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/@ember/-internals/glimmer/lib/syntax/render.ts
|
@@ -1,194 +0,0 @@
-/**
- @module ember
-*/
-
-// Remove after 3.4 once _ENABLE_RENDER_SUPPORT flag is no longer needed.
-
-import { ENV } from '@ember/-internals/environment';
-import { OwnedTemplateMeta } from '@ember/-internals/views';
-import { assert } from '@ember/debug';
-import { RENDER_HELPER } from '@ember/deprecated-features';
-import { Option } from '@glimmer/interfaces';
-import { OpcodeBuilder } from '@glimmer/opcode-compiler';
-import { isConst, VersionedPathReference } from '@glimmer/reference';
-import { Arguments, CurriedComponentDefinition, curry, VM } from '@glimmer/runtime';
-import * as WireFormat from '@glimmer/wire-format';
-import {
- NON_SINGLETON_RENDER_MANAGER,
- RenderDefinition,
- SINGLETON_RENDER_MANAGER,
-} from '../component-managers/render';
-import Environment from '../environment';
-import { OwnedTemplate } from '../template';
-import { UnboundReference } from '../utils/references';
-
-let renderHelper: (
- vm: VM,
- args: Arguments
-) => VersionedPathReference<CurriedComponentDefinition | null>;
-
-if (RENDER_HELPER) {
- renderHelper = function renderHelper(
- vm: VM,
- args: Arguments
- ): VersionedPathReference<CurriedComponentDefinition | null> {
- let env = vm.env as Environment;
- let nameRef = args.positional.at(0);
-
- assert(
- `The first argument of {{render}} must be quoted, e.g. {{render "sidebar"}}.`,
- isConst(nameRef)
- );
- // tslint:disable-next-line:max-line-length
- assert(
- `The second argument of {{render}} must be a path, e.g. {{render "post" post}}.`,
- args.positional.length === 1 || !isConst(args.positional.at(1))
- );
-
- let templateName = nameRef.value() as string;
-
- // tslint:disable-next-line:max-line-length
- assert(
- `You used \`{{render '${templateName}'}}\`, but '${templateName}' can not be found as a template.`,
- env.owner.hasRegistration(`template:${templateName}`)
- );
-
- let template = env.owner.lookup<OwnedTemplate>(`template:${templateName}`);
-
- let controllerName: string;
-
- if (args.named.has('controller')) {
- let controllerNameRef = args.named.get('controller');
-
- // tslint:disable-next-line:max-line-length
- assert(
- `The controller argument for {{render}} must be quoted, e.g. {{render "sidebar" controller="foo"}}.`,
- isConst(controllerNameRef)
- );
-
- // TODO should be ensuring this to string here
- controllerName = controllerNameRef.value() as string;
-
- // tslint:disable-next-line:max-line-length
- assert(
- `The controller name you supplied '${controllerName}' did not resolve to a controller.`,
- env.owner.hasRegistration(`controller:${controllerName}`)
- );
- } else {
- controllerName = templateName;
- }
-
- if (args.positional.length === 1) {
- let def = new RenderDefinition(controllerName, template, SINGLETON_RENDER_MANAGER);
- return UnboundReference.create(curry(def));
- } else {
- let def = new RenderDefinition(controllerName, template, NON_SINGLETON_RENDER_MANAGER);
- let captured = args.capture();
- return UnboundReference.create(curry(def, captured));
- }
- };
-}
-
-/**
- Calling ``{{render}}`` from within a template will insert another
- template that matches the provided name. The inserted template will
- access its properties on its own controller (rather than the controller
- of the parent template).
-
- If a view class with the same name exists, the view class also will be used.
- Note: A given controller may only be used *once* in your app in this manner.
- A singleton instance of the controller will be created for you.
-
- Example:
-
- ```app/controllers/navigation.js
- import Controller from '@ember/controller';
-
- export default Controller.extend({
- who: "world"
- });
- ```
-
- ```handlebars
- <!-- navigation.hbs -->
- Hello, {{who}}.
- ```
-
- ```handlebars
- <!-- application.hbs -->
- <h1>My great app</h1>
- {{render "navigation"}}
- ```
-
- ```html
- <h1>My great app</h1>
- <div class='ember-view'>
- Hello, world.
- </div>
- ```
-
- Optionally you may provide a second argument: a property path
- that will be bound to the `model` property of the controller.
- If a `model` property path is specified, then a new instance of the
- controller will be created and `{{render}}` can be used multiple times
- with the same name.
-
- For example if you had this `author` template.
-
- ```handlebars
- <div class="author">
- Written by {{firstName}} {{lastName}}.
- Total Posts: {{postCount}}
- </div>
- ```
-
- You could render it inside the `post` template using the `render` helper.
-
- ```handlebars
- <div class="post">
- <h1>{{title}}</h1>
- <div>{{body}}</div>
- {{render "author" author}}
- </div>
- ```
-
- @method render
- @for Ember.Templates.helpers
- @param {String} name
- @param {Object?} context
- @param {Hash} options
- @return {String} HTML string
- @public
- @deprecated Use a component instead
-*/
-let renderMacro: (
- _name: string,
- params: Option<WireFormat.Core.Params>,
- hash: Option<WireFormat.Core.Hash>,
- builder: OpcodeBuilder<OwnedTemplateMeta>
-) => boolean;
-if (RENDER_HELPER) {
- renderMacro = function renderMacro(
- _name: string,
- params: Option<WireFormat.Core.Params>,
- hash: Option<WireFormat.Core.Hash>,
- builder: OpcodeBuilder<OwnedTemplateMeta>
- ) {
- if (RENDER_HELPER && ENV._ENABLE_RENDER_SUPPORT === true) {
- // TODO needs makeComponentDefinition a helper that returns a curried definition
- // TODO not sure all args are for definition or component
- // likely the controller name should be a arg to create?
- let expr: WireFormat.Expressions.Helper = [
- WireFormat.Ops.Helper,
- '-render',
- params || [],
- hash,
- ];
- builder.dynamicComponent(expr, null, null, null, false, null, null);
- return true;
- }
- return false;
- };
-}
-
-export { renderHelper, renderMacro };
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/@ember/-internals/glimmer/tests/integration/helpers/render-test.js
|
@@ -1,522 +0,0 @@
-import { observer, set, computed } from '@ember/-internals/metal';
-import Controller from '@ember/controller';
-import { ENV } from '@ember/-internals/environment';
-import { RenderingTest, moduleFor } from '../../utils/test-case';
-
-moduleFor(
- 'Helpers test: {{render}}',
- class extends RenderingTest {
- constructor() {
- super(...arguments);
- this.originalRenderSupport = ENV._ENABLE_RENDER_SUPPORT;
- ENV._ENABLE_RENDER_SUPPORT = true;
- }
-
- teardown() {
- super.teardown();
- ENV._ENABLE_RENDER_SUPPORT = this.originalRenderSupport;
- }
-
- ['@test should render given template']() {
- this.registerTemplate('home', '<p>BYE</p>');
-
- expectDeprecation(() => {
- this.render(`<h1>HI</h1>{{render 'home'}}`);
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText('HIBYE');
- }
-
- ['@test uses `controller:basic` as the basis for a generated controller when none exists for specified name']() {
- this.owner.register(
- 'controller:basic',
- Controller.extend({
- isBasicController: true,
- })
- );
- this.registerTemplate('home', '{{isBasicController}}');
-
- expectDeprecation(() => {
- this.render(`{{render 'home'}}`);
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText('true');
- }
-
- ['@test generates a controller if none exists']() {
- this.registerTemplate('home', '<p>{{this}}</p>');
-
- expectDeprecation(() => {
- this.render(`<h1>HI</h1>{{render 'home'}}`);
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText('HI(generated home controller)');
- }
-
- ['@test should use controller with the same name as template if present']() {
- this.owner.register('controller:home', Controller.extend({ name: 'home' }));
- this.registerTemplate('home', '{{name}}<p>BYE</p>');
-
- expectDeprecation(() => {
- this.render(`<h1>HI</h1>{{render 'home'}}`);
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText('HIhomeBYE');
- }
-
- ['@test should render nested helpers']() {
- this.owner.register('controller:home', Controller.extend());
- this.owner.register('controller:foo', Controller.extend());
- this.owner.register('controller:bar', Controller.extend());
- this.owner.register('controller:baz', Controller.extend());
-
- this.registerTemplate('home', '<p>BYE</p>');
- this.registerTemplate('baz', `<p>BAZ</p>`);
-
- expectDeprecation(() => {
- this.registerTemplate('foo', `<p>FOO</p>{{render 'bar'}}`);
- this.registerTemplate('bar', `<p>BAR</p>{{render 'baz'}}`);
- this.render("<h1>HI</h1>{{render 'foo'}}");
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText('HIFOOBARBAZ');
- }
-
- ['@test should have assertion if the template does not exist']() {
- this.owner.register('controller:oops', Controller.extend());
-
- expectDeprecation(() => {
- expectAssertion(() => {
- this.render(`<h1>HI</h1>{{render 'oops'}}`);
- }, "You used `{{render 'oops'}}`, but 'oops' can not be found as a template.");
- }, /Please refactor [\w\{\}"` ]+ to a component/);
- }
-
- ['@test should render given template with the singleton controller as its context']() {
- this.owner.register(
- 'controller:post',
- Controller.extend({
- init() {
- this.set('title', `It's Simple Made Easy`);
- },
- })
- );
- this.registerTemplate('post', '<p>{{title}}</p>');
-
- expectDeprecation(() => {
- this.render(`<h1>HI</h1>{{render 'post'}}`);
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText(`HIIt's Simple Made Easy`);
-
- this.runTask(() => this.rerender());
-
- this.assertText(`HIIt's Simple Made Easy`);
-
- let controller = this.owner.lookup('controller:post');
-
- this.runTask(() => set(controller, 'title', `Rails is omakase`));
-
- this.assertText(`HIRails is omakase`);
-
- this.runTask(() => set(controller, 'title', `It's Simple Made Easy`));
-
- this.assertText(`HIIt's Simple Made Easy`);
- }
-
- ['@test should not destroy the singleton controller on teardown'](assert) {
- let willDestroyFired = 0;
-
- this.owner.register(
- 'controller:post',
- Controller.extend({
- init() {
- this.set('title', `It's Simple Made Easy`);
- },
-
- willDestroy() {
- this._super(...arguments);
- willDestroyFired++;
- },
- })
- );
-
- this.registerTemplate('post', '<p>{{title}}</p>');
-
- expectDeprecation(() => {
- this.render(`{{#if showPost}}{{render 'post'}}{{else}}Nothing here{{/if}}`, {
- showPost: false,
- });
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText(`Nothing here`);
-
- assert.strictEqual(willDestroyFired, 0, 'it did not destroy the controller');
-
- this.runTask(() => this.rerender());
-
- this.assertText(`Nothing here`);
-
- assert.strictEqual(willDestroyFired, 0, 'it did not destroy the controller');
-
- this.runTask(() => set(this.context, 'showPost', true));
-
- this.assertText(`It's Simple Made Easy`);
-
- assert.strictEqual(willDestroyFired, 0, 'it did not destroy the controller');
-
- this.runTask(() => set(this.context, 'showPost', false));
-
- this.assertText(`Nothing here`);
-
- assert.strictEqual(willDestroyFired, 0, 'it did not destroy the controller');
- }
-
- ['@test should render given template with a supplied model']() {
- this.owner.register('controller:post', Controller.extend());
- this.registerTemplate('post', '<p>{{model.title}}</p>');
-
- expectDeprecation(() => {
- this.render(`<h1>HI</h1>{{render 'post' post}}`, {
- post: {
- title: `It's Simple Made Easy`,
- },
- });
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText(`HIIt's Simple Made Easy`);
-
- this.runTask(() => this.rerender());
-
- this.assertText(`HIIt's Simple Made Easy`);
-
- this.runTask(() => set(this.context, 'post.title', `Rails is omakase`));
-
- this.assertText(`HIRails is omakase`);
-
- this.runTask(() => set(this.context, 'post', { title: `It's Simple Made Easy` }));
-
- this.assertText(`HIIt's Simple Made Easy`);
- }
-
- ['@test should destroy the non-singleton controllers on teardown'](assert) {
- let willDestroyFired = 0;
-
- this.owner.register(
- 'controller:post',
- Controller.extend({
- willDestroy() {
- this._super(...arguments);
- willDestroyFired++;
- },
- })
- );
-
- this.registerTemplate('post', '<p>{{model.title}}</p>');
-
- expectDeprecation(() => {
- this.render(`{{#if showPost}}{{render 'post' post}}{{else}}Nothing here{{/if}}`, {
- showPost: false,
- post: {
- title: `It's Simple Made Easy`,
- },
- });
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText(`Nothing here`);
-
- assert.strictEqual(willDestroyFired, 0, 'it did not destroy the controller');
-
- this.runTask(() => this.rerender());
-
- this.assertText(`Nothing here`);
-
- assert.strictEqual(willDestroyFired, 0, 'it did not destroy the controller');
-
- this.runTask(() => set(this.context, 'showPost', true));
-
- this.assertText(`It's Simple Made Easy`);
-
- assert.strictEqual(willDestroyFired, 0, 'it did not destroy the controller');
-
- this.runTask(() => set(this.context, 'showPost', false));
-
- this.assertText(`Nothing here`);
-
- assert.strictEqual(willDestroyFired, 1, 'it did destroy the controller');
-
- this.runTask(() => set(this.context, 'showPost', true));
-
- this.assertText(`It's Simple Made Easy`);
-
- assert.strictEqual(willDestroyFired, 1, 'it did not destroy the controller');
-
- this.runTask(() => set(this.context, 'showPost', false));
-
- this.assertText(`Nothing here`);
-
- assert.strictEqual(willDestroyFired, 2, 'it did destroy the controller');
- }
-
- ['@test with a supplied model should not fire observers on the controller'](assert) {
- this.owner.register('controller:post', Controller.extend());
- this.registerTemplate('post', '<p>{{model.title}}</p>');
-
- let postDidChange = 0;
- expectDeprecation(() => {
- this.render(`<h1>HI</h1>{{render 'post' post}}`, {
- postDidChange: observer('post', function() {
- postDidChange++;
- }),
- post: {
- title: `It's Simple Made Easy`,
- },
- });
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText(`HIIt's Simple Made Easy`);
-
- this.runTask(() => this.rerender());
-
- this.assertText(`HIIt's Simple Made Easy`);
- assert.equal(postDidChange, 0);
- }
-
- ['@test should raise an error when a given controller name does not resolve to a controller']() {
- this.registerTemplate('home', '<p>BYE</p>');
- this.owner.register('controller:posts', Controller.extend());
-
- expectDeprecation(() => {
- expectAssertion(() => {
- this.render(`<h1>HI</h1>{{render "home" controller="postss"}}`);
- }, /The controller name you supplied \'postss\' did not resolve to a controller./);
- }, /Please refactor [\w\{\}"` ]+ to a component/);
- }
-
- ['@test should render with given controller'](assert) {
- this.registerTemplate('home', '{{uniqueId}}');
-
- let id = 0;
- let model = {};
-
- this.owner.register(
- 'controller:posts',
- Controller.extend({
- init() {
- this._super(...arguments);
- this.uniqueId = id++;
- this.set('model', model);
- },
- })
- );
-
- expectDeprecation(() => {
- this.render('{{render "home" controller="posts"}}');
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- let renderedController = this.owner.lookup('controller:posts');
- let uniqueId = renderedController.get('uniqueId');
- let renderedModel = renderedController.get('model');
-
- assert.equal(uniqueId, 0);
- assert.equal(renderedModel, model);
- this.assertText('0');
-
- this.runTask(() => this.rerender());
-
- assert.equal(uniqueId, 0);
- assert.equal(renderedModel, model);
- this.assertText('0');
- }
-
- ['@test should render templates with models multiple times']() {
- this.owner.register('controller:post', Controller.extend());
-
- this.registerTemplate('post', '<p>{{model.title}}</p>');
- expectDeprecation(() => {
- this.render(`<h1>HI</h1> {{render 'post' post1}} {{render 'post' post2}}`, {
- post1: {
- title: 'Me First',
- },
- post2: {
- title: 'Then me',
- },
- });
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- this.assertText('HI Me First Then me');
-
- this.runTask(() => this.rerender());
-
- this.assertText('HI Me First Then me');
-
- this.runTask(() => set(this.context, 'post1.title', 'I am new'));
-
- this.assertText('HI I am new Then me');
-
- this.runTask(() => set(this.context, 'post1', { title: 'Me First' }));
-
- this.assertText('HI Me First Then me');
- }
-
- ['@test should not treat invocations with falsy contexts as context-less'](assert) {
- this.registerTemplate('post', '<p>{{#unless model.zero}}NOTHING{{/unless}}</p>');
- this.owner.register('controller:post', Controller.extend());
-
- expectDeprecation(() => {
- this.render(`<h1>HI</h1> {{render 'post' zero}} {{render 'post' nonexistent}}`, {
- model: {
- zero: false,
- },
- });
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- assert.ok(
- this.$()
- .text()
- .match(/^HI ?NOTHING ?NOTHING$/)
- );
- }
-
- ['@test should render templates both with and without models'](assert) {
- this.registerTemplate('post', `<p>Title:{{model.title}}</p>`);
- this.owner.register('controller:post', Controller.extend());
-
- let post = {
- title: 'Rails is omakase',
- };
- expectDeprecation(() => {
- this.render(`<h1>HI</h1> {{render 'post'}} {{render 'post' post}}`, {
- post,
- });
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- assert.ok(
- this.$()
- .text()
- .match(/^HI ?Title: ?Title:Rails is omakase$/)
- );
-
- this.runTask(() => this.rerender());
-
- assert.ok(
- this.$()
- .text()
- .match(/^HI ?Title: ?Title:Rails is omakase$/)
- );
-
- this.runTask(() => set(this.context, 'post.title', 'Simple Made Easy'));
-
- assert.ok(
- this.$()
- .text()
- .match(/^HI ?Title: ?Title:Simple Made Easy$/)
- );
-
- this.runTask(() => set(this.context, 'post', { title: 'Rails is omakase' }));
-
- assert.ok(
- this.$()
- .text()
- .match(/^HI ?Title: ?Title:Rails is omakase$/)
- );
- }
-
- ['@test works with dot notation']() {
- this.registerTemplate('blog.post', '{{uniqueId}}');
-
- let id = 0;
- this.owner.register(
- 'controller:blog.post',
- Controller.extend({
- init() {
- this._super(...arguments);
- this.uniqueId = id++;
- },
- })
- );
-
- expectDeprecation(() => {
- this.render('{{render "blog.post"}}');
- }, /Please refactor [\w\.{\}"` ]+ to a component/);
-
- this.assertText(`0`);
- }
-
- ['@test throws an assertion if called with an unquoted template name']() {
- this.registerTemplate('home', '<p>BYE</p>');
-
- expectAssertion(() => {
- this.render('<h1>HI</h1>{{render home}}');
- }, 'The first argument of {{render}} must be quoted, e.g. {{render "sidebar"}}.');
- }
-
- ['@test throws an assertion if called with a literal for a model']() {
- this.registerTemplate('home', '<p>BYE</p>');
- expectAssertion(() => {
- this.render('<h1>HI</h1>{{render "home" "model"}}', {
- model: {
- title: 'Simple Made Easy',
- },
- });
- }, 'The second argument of {{render}} must be a path, e.g. {{render "post" post}}.');
- }
-
- ['@test should set router as target when action not found on parentController is not found'](
- assert
- ) {
- let postController;
- this.registerTemplate('post', 'post template');
- this.owner.register(
- 'controller:post',
- Controller.extend({
- init() {
- this._super(...arguments);
- postController = this;
- },
- })
- );
-
- let routerStub = {
- send(actionName) {
- assert.equal(actionName, 'someAction');
- assert.ok(true, 'routerStub#send called');
- },
- };
-
- this.owner.register('router:main', routerStub, { instantiate: false });
-
- expectDeprecation(() => {
- this.render(`{{render 'post' post1}}`);
- }, /Please refactor [\w\{\}"` ]+ to a component/);
-
- postController.send('someAction');
- }
-
- ['@test render helper emits useful backtracking re-render assertion message']() {
- this.owner.register('controller:outer', Controller.extend());
- this.owner.register(
- 'controller:inner',
- Controller.extend({
- propertyWithError: computed(function() {
- this.set('model.name', 'this will cause a backtracking error');
- return 'foo';
- }),
- })
- );
-
- let expectedBacktrackingMessage = /modified "model\.name" twice on \[object Object\] in a single render\. It was rendered in "controller:outer \(with the render helper\)" and modified in "controller:inner \(with the render helper\)"/;
-
- expectDeprecation(() => {
- let person = { name: 'Ben' };
-
- this.registerTemplate('outer', `Hi {{model.name}} | {{render 'inner' model}}`);
- this.registerTemplate('inner', `Hi {{propertyWithError}}`);
-
- expectAssertion(() => {
- this.render(`{{render 'outer' person}}`, { person });
- }, expectedBacktrackingMessage);
- });
- }
- }
-);
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/@ember/-internals/glimmer/tests/integration/refinements-test.js
|
@@ -16,12 +16,6 @@ moduleFor(
---
- {{#with var as |render|}}
- {{render}}
- {{/with}}
-
- ---
-
{{#with var as |outlet|}}
{{outlet}}
{{/with}}
@@ -58,17 +52,15 @@ moduleFor(
{ var: 'var' }
);
- this.assertText('var---var---var---var---var---var---var---var');
+ this.assertText('var---var---var---var---var---var---var');
this.runTask(() => set(this.context, 'var', 'RARRR!!!'));
- this.assertText(
- 'RARRR!!!---RARRR!!!---RARRR!!!---RARRR!!!---RARRR!!!---RARRR!!!---RARRR!!!---RARRR!!!'
- );
+ this.assertText('RARRR!!!---RARRR!!!---RARRR!!!---RARRR!!!---RARRR!!!---RARRR!!!---RARRR!!!');
this.runTask(() => set(this.context, 'var', 'var'));
- this.assertText('var---var---var---var---var---var---var---var');
+ this.assertText('var---var---var---var---var---var---var');
}
}
);
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/@ember/-internals/routing/lib/system/router.js
|
@@ -1,9 +1,9 @@
import { getOwner } from '@ember/-internals/owner';
import { assign } from '@ember/polyfills';
-import { cancel, once, run, scheduleOnce, schedule } from '@ember/runloop';
+import { cancel, once, run, scheduleOnce } from '@ember/runloop';
import { get, set, defineProperty, computed } from '@ember/-internals/metal';
import EmberError from '@ember/error';
-import { assert, deprecate, info } from '@ember/debug';
+import { assert, info } from '@ember/debug';
import { Object as EmberObject, Evented, typeOf, A as emberA } from '@ember/-internals/runtime';
import { defaultSerialize, hasDefaultSerialize } from './route';
import EmberRouterDSL from './dsl';
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/@ember/deprecated-features/index.ts
|
@@ -9,6 +9,5 @@ export const PROPERTY_DID_CHANGE = !!'3.1.0-beta.1';
export const ROUTER_ROUTER = !!'3.2.0-beta.1';
export const ARRAY_AT_EACH = !!'3.1.0-beta.1';
export const TARGET_OBJECT = !!'2.18.0-beta.1';
-export const RENDER_HELPER = !!'2.11.0-beta.1';
export const MAP = !!'3.3.0-beta.1';
export const ORDERED_SET = !!'3.3.0-beta.1';
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/ember-template-compiler/lib/plugins/deprecate-render-model.ts
|
@@ -1,48 +0,0 @@
-import { deprecate } from '@ember/debug';
-import { RENDER_HELPER } from '@ember/deprecated-features';
-import { AST, ASTPlugin, ASTPluginEnvironment } from '@glimmer/syntax';
-import calculateLocationDisplay from '../system/calculate-location-display';
-
-// Remove after 3.4 once _ENABLE_RENDER_SUPPORT flag is no longer needed.
-export default function deprecateRenderModel(env: ASTPluginEnvironment): ASTPlugin | undefined {
- if (RENDER_HELPER) {
- let { moduleName } = env.meta;
-
- let deprecationMessage = (node: AST.MustacheStatement, param: AST.PathExpression) => {
- let sourceInformation = calculateLocationDisplay(moduleName, node.loc);
- let componentName = (node.params[0] as AST.PathExpression).original;
- let modelName = param.original;
- let original = `{{render "${componentName}" ${modelName}}}`;
- let preferred = `{{${componentName} model=${modelName}}}`;
-
- return (
- `Please refactor \`${original}\` to a component and invoke via` +
- ` \`${preferred}\`. ${sourceInformation}`
- );
- };
-
- return {
- name: 'deprecate-render-model',
-
- visitor: {
- MustacheStatement(node: AST.MustacheStatement) {
- if (node.path.original === 'render' && node.params.length > 1) {
- node.params.forEach(param => {
- if (param.type !== 'PathExpression') {
- return;
- }
-
- deprecate(deprecationMessage(node, param), false, {
- id: 'ember-template-compiler.deprecate-render-model',
- until: '3.0.0',
- url:
- 'https://emberjs.com/deprecations/v2.x#toc_model-param-in-code-render-code-helper',
- });
- });
- }
- },
- },
- };
- }
- return undefined;
-}
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/ember-template-compiler/lib/plugins/deprecate-render.ts
|
@@ -1,51 +0,0 @@
-import { deprecate } from '@ember/debug';
-import { RENDER_HELPER } from '@ember/deprecated-features';
-import { AST, ASTPlugin, ASTPluginEnvironment } from '@glimmer/syntax';
-import calculateLocationDisplay from '../system/calculate-location-display';
-
-// Remove after 3.4 once _ENABLE_RENDER_SUPPORT flag is no longer needed.
-export default function deprecateRender(env: ASTPluginEnvironment): ASTPlugin | undefined {
- if (RENDER_HELPER) {
- let { moduleName } = env.meta;
-
- let deprecationMessage = (node: AST.MustacheStatement) => {
- let sourceInformation = calculateLocationDisplay(moduleName, node.loc);
- let componentName = (node.params[0] as AST.PathExpression).original;
- let original = `{{render "${componentName}"}}`;
- let preferred = `{{${componentName}}}`;
-
- return (
- `Please refactor \`${original}\` to a component and invoke via` +
- ` \`${preferred}\`. ${sourceInformation}`
- );
- };
-
- return {
- name: 'deprecate-render',
-
- visitor: {
- MustacheStatement(node: AST.MustacheStatement) {
- if (node.path.original !== 'render') {
- return;
- }
- if (node.params.length !== 1) {
- return;
- }
-
- node.params.forEach(param => {
- if (param.type !== 'StringLiteral') {
- return;
- }
-
- deprecate(deprecationMessage(node), false, {
- id: 'ember-template-compiler.deprecate-render',
- until: '3.0.0',
- url: 'https://emberjs.com/deprecations/v2.x#toc_code-render-code-helper',
- });
- });
- },
- },
- };
- }
- return undefined;
-}
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/ember-template-compiler/lib/plugins/index.ts
|
@@ -2,8 +2,6 @@ import AssertIfHelperWithoutArguments from './assert-if-helper-without-arguments
import AssertInputHelperWithoutBlock from './assert-input-helper-without-block';
import AssertReservedNamedArguments from './assert-reserved-named-arguments';
import AssertSplattributeExpressions from './assert-splattribute-expression';
-import DeprecateRender from './deprecate-render';
-import DeprecateRenderModel from './deprecate-render-model';
import DeprecateSendAction from './deprecate-send-action';
import TransformActionSyntax from './transform-action-syntax';
import TransformAngleBracketComponents from './transform-angle-bracket-components';
@@ -18,7 +16,7 @@ import TransformOldClassBindingSyntax from './transform-old-class-binding-syntax
import TransformQuotedBindingsIntoJustBindings from './transform-quoted-bindings-into-just-bindings';
import TransformTopLevelComponents from './transform-top-level-components';
-import { RENDER_HELPER, SEND_ACTION } from '@ember/deprecated-features';
+import { SEND_ACTION } from '@ember/deprecated-features';
import { ASTPlugin, ASTPluginEnvironment } from '@glimmer/syntax';
export type APluginFunc = (env: ASTPluginEnvironment) => ASTPlugin | undefined;
@@ -42,11 +40,6 @@ const transforms: Array<APluginFunc> = [
AssertSplattributeExpressions,
];
-if (RENDER_HELPER) {
- transforms.push(DeprecateRenderModel);
- transforms.push(DeprecateRender);
-}
-
if (SEND_ACTION) {
transforms.push(DeprecateSendAction);
}
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/ember-template-compiler/tests/plugins/deprecate-render-model-test.js
|
@@ -1,19 +0,0 @@
-import { compile } from '../../index';
-import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
-
-moduleFor(
- 'ember-template-compiler: deprecate-model-render',
- class extends AbstractTestCase {
- ['@test Using `{{render` with model provides a deprecation']() {
- let expectedMessage =
- `Please refactor \`{{render "foo-bar" coolModel}}\` to a component and` +
- ` invoke via \`{{foo-bar model=coolModel}}\`. ('baz/foo-bar' @ L1:C0) `;
-
- expectDeprecation(() => {
- compile('{{render "foo-bar" coolModel}}', {
- moduleName: 'baz/foo-bar',
- });
- }, expectedMessage);
- }
- }
-);
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/ember-template-compiler/tests/plugins/deprecate-render-test.js
|
@@ -1,19 +0,0 @@
-import { compile } from '../../index';
-import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
-
-moduleFor(
- 'ember-template-compiler: deprecate-render',
- class extends AbstractTestCase {
- ['@test Using `{{render` without a model provides a deprecation']() {
- let expectedMessage =
- `Please refactor \`{{render "foo-bar"}}\` to a component and` +
- ` invoke via \`{{foo-bar}}\`. ('baz/foo-bar' @ L1:C0) `;
-
- expectDeprecation(() => {
- compile('{{render "foo-bar"}}', {
- moduleName: 'baz/foo-bar',
- });
- }, expectedMessage);
- }
- }
-);
| true |
Other
|
emberjs
|
ember.js
|
1661db0df6a5821160c9729ddc721b2d733f29b6.json
|
Remove deprecated 'RENDER_SUPPORT'
|
packages/ember/tests/routing/decoupled_basic_test.js
|
@@ -2,7 +2,6 @@
import { getOwner } from '@ember/-internals/owner';
import RSVP from 'rsvp';
import { compile } from 'ember-template-compiler';
-import { ENV } from '@ember/-internals/environment';
import { Route, NoneLocation, HistoryLocation } from '@ember/-internals/routing';
import Controller from '@ember/controller';
import { Object as EmberObject, A as emberA } from '@ember/-internals/runtime';
@@ -14,7 +13,6 @@ import { Component } from '@ember/-internals/glimmer';
import Engine from '@ember/engine';
import { Transition } from 'router';
-let originalRenderSupport;
let originalConsoleError;
moduleFor(
@@ -29,14 +27,12 @@ moduleFor(
this.router.map(function() {
this.route('home', { path: '/' });
});
- originalRenderSupport = ENV._ENABLE_RENDER_SUPPORT;
- ENV._ENABLE_RENDER_SUPPORT = true;
+
originalConsoleError = console.error;
}
teardown() {
super.teardown();
- ENV._ENABLE_RENDER_SUPPORT = originalRenderSupport;
console.error = originalConsoleError;
}
| true |
Other
|
emberjs
|
ember.js
|
75dfa757a88bfd20ef8539cc332e45a1b4c4095d.json
|
Remove deprecated flags
|
packages/@ember/-internals/environment/lib/env.ts
|
@@ -112,25 +112,9 @@ export const ENV = {
_JQUERY_INTEGRATION: true,
// the following for addon support
- _ENABLE_EMBER_K_SUPPORT: false,
- _ENABLE_SAFE_STRING_SUPPORT: false,
- _ENABLE_ENUMERABLE_CONTAINS_SUPPORT: false,
- _ENABLE_UNDERSCORE_ACTIONS_SUPPORT: false,
- _ENABLE_REVERSED_OBSERVER_SUPPORT: false,
- _ENABLE_INITIALIZER_ARGUMENTS_SUPPORT: false,
- _ENABLE_ROUTER_RESOURCE: false,
- _ENABLE_CURRENT_WHEN_SUPPORT: false,
- _ENABLE_CONTROLLER_WRAPPED_SUPPORT: false,
- _ENABLE_DEPRECATED_REGISTRY_SUPPORT: false,
- _ENABLE_IMMEDIATE_OBSERVER_SUPPORT: false,
- _ENABLE_STRING_FMT_SUPPORT: false,
- _ENABLE_FREEZABLE_SUPPORT: false,
- _ENABLE_COMPONENT_DEFAULTLAYOUT_SUPPORT: false,
- _ENABLE_INPUT_TRANSFORM_SUPPORT: false,
_ENABLE_ORPHANED_OUTLETS_SUPPORT: false,
_ENABLE_WARN_OPTIONS_SUPPORT: false,
_ENABLE_RENDER_SUPPORT: false,
- _ENABLE_PROPERTY_REQUIRED_SUPPORT: false,
EMBER_LOAD_HOOKS: {} as {
[hook: string]: Function[];
| false |
Other
|
emberjs
|
ember.js
|
790f13fedc8c3abaaea4810cc7d2e1d6be763f55.json
|
Use bare `require` in conditional URL import
This commit changes the code that sets up URL parsing in Glimmer to use the bare, global `require` in Node.js environments, rather than importing from our `node-module` helper package.
The `node-module` package is a shim we emit in the AMD build that exposes the Node `module` and `require` globals which would otherwise be shadowed by AMD. However, this creates problems when compiling Ember to package formats where we want to ultimately rely on standard Node resolution semantics, since `node-module` is not a package that appears in `node_modules`.
Instead, we switch the code to use a bare `require` and rely on the existing `inject-node-globals` Babel transform to detect this usage of bare `require` and inject the appropriate AMD require, only in the AMD build.
|
packages/@ember/-internals/glimmer/lib/protocol-for-url.ts
|
@@ -1,7 +1,6 @@
/* globals module, URL */
import { hasDOM } from '@ember/-internals/browser-environment';
-import { IS_NODE, require } from 'node-module';
import Environment from './environment';
let nodeURL: any;
@@ -24,7 +23,7 @@ export default function installProtocolForURL(environment: Environment) {
// URL globally provided, likely from FastBoot's sandbox
nodeURL = URL;
environment.protocolForURL = nodeProtocolForURL;
- } else if (IS_NODE) {
+ } else if (typeof require === 'function') {
// Otherwise, we need to fall back to our own URL parsing.
// Global `require` is shadowed by Ember's loader so we have to use the fully
// qualified `module.require`.
| false |
Other
|
emberjs
|
ember.js
|
b94707f11819866919a47005ac9c3aa241ad706e.json
|
Write package.json to ES package builds
|
broccoli/package-json-writer.js
|
@@ -0,0 +1,109 @@
+const fs = require('fs');
+const path = require('path');
+const glob = require('glob');
+const mkdirp = require('mkdirp');
+const Plugin = require('broccoli-plugin');
+
+const DEFAULT_PACKAGE_JSON = {
+ main: './index.js',
+ module: './index.js',
+ license: 'MIT',
+};
+
+/**
+ * Broccoli plugin that generates a package.json file for each subpackage, as
+ * well as any necessary package.json files for nested entry points.
+ */
+module.exports = class PackageJSONWriter extends Plugin {
+ constructor(inputNode) {
+ super([inputNode]);
+ }
+
+ /**
+ * Each time the plugin builds, discover the npm packages in the input tree
+ * and generate their package.json files.
+ */
+ build() {
+ let packages = this.discoverPackages();
+
+ packages.forEach(packageName => {
+ this.writeMainPackageJson(packageName);
+ this.discoverEntryPoints(packageName).forEach(entryPoint => {
+ this.writeEntryPointPackageJson(packageName, entryPoint);
+ });
+ });
+ }
+
+ /**
+ * Find all packages and scoped packages at the root of the input tree.
+ */
+ discoverPackages() {
+ return this.glob('{!(@*),@*/*}/');
+ }
+
+ /**
+ * Find any nested entry points (i.e. modules that are accessed other than the
+ * root package name). For example, `@ember/object/computed` is a nested entry
+ * point of `@ember/object`.
+ *
+ * To discover nested entry points, we search for any non-standard directories
+ * and files in the package root. Files that should not be considered an entry
+ * point should be placed inside the `lib/` directory.
+ *
+ */
+ discoverEntryPoints(packageName) {
+ let files = this.glob(`${packageName}/!(index).js`)
+ .map(file => path.basename(file, '.js'))
+ .map(file => [file, true]);
+ let directories = this.glob(`${packageName}/!(lib|tests)/`)
+ .map(file => path.basename(file))
+ .map(file => [file, false]);
+
+ return [...files, ...directories];
+ }
+
+ glob(globStr) {
+ return glob.sync(globStr, { cwd: this.inputPaths[0] });
+ }
+
+ writeMainPackageJson(packagePath) {
+ let packageJson = this.tryReadPackageJson(packagePath);
+ Object.assign(packageJson, DEFAULT_PACKAGE_JSON);
+
+ let packageJsonPath = path.join(this.outputPath, packagePath, 'package.json');
+ mkdirp.sync(path.dirname(packageJsonPath));
+ fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2));
+ }
+
+ writeEntryPointPackageJson(packageName, [entryPoint, isFile]) {
+ let entryPointPath = path.join(packageName, entryPoint);
+
+ let packageJson = {
+ name: entryPointPath,
+ module: isFile ? `../${entryPoint}.js` : `../${entryPoint}/index.js`,
+ };
+
+ this.writePackageJson(entryPointPath, packageJson);
+ }
+
+ writePackageJson(packagePath, packageJson) {
+ let packageJsonPath = path.join(this.outputPath, packagePath, 'package.json');
+ mkdirp.sync(path.dirname(packageJsonPath));
+ fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2));
+ }
+
+ /**
+ * Returns the package.json of the specified directory. If it doesn't exist,
+ * returns an empty object.
+ * @param {string} packagePath
+ */
+ tryReadPackageJson(packagePath) {
+ let packageJsonPath = path.join(this.inputPaths[0], packagePath, 'package.json');
+ try {
+ let data = fs.readFileSync(packageJsonPath);
+ return JSON.parse(data.toString());
+ } catch (e) {
+ return {};
+ }
+ }
+};
| true |
Other
|
emberjs
|
ember.js
|
b94707f11819866919a47005ac9c3aa241ad706e.json
|
Write package.json to ES package builds
|
broccoli/packages.js
|
@@ -11,6 +11,7 @@ const findLib = require('./find-lib');
const findPackage = require('./find-package');
const funnelLib = require('./funnel-lib');
const { VERSION } = require('./version');
+const PackageJSONWriter = require('./package-json-writer');
const WriteFile = require('broccoli-file-creator');
const StringReplace = require('broccoli-string-replace');
const GlimmerTemplatePrecompiler = require('./glimmer-template-compiler');
@@ -94,6 +95,13 @@ module.exports.getPackagesES = function getPackagesES() {
overwrite: true,
});
+ let packageJSON = debugTree(
+ new PackageJSONWriter(mergedFinalOutput),
+ `get-packages-es:package-json`
+ );
+
+ mergedFinalOutput = new MergeTrees([mergedFinalOutput, packageJSON], { overwrite: true });
+
return debugTree(mergedFinalOutput, `get-packages-es:output`);
};
| true |
Other
|
emberjs
|
ember.js
|
b94707f11819866919a47005ac9c3aa241ad706e.json
|
Write package.json to ES package builds
|
package.json
|
@@ -101,6 +101,7 @@
"broccoli-debug": "^0.6.4",
"broccoli-file-creator": "^1.1.1",
"broccoli-persistent-filter": "^1.4.3",
+ "broccoli-plugin": "^1.3.1",
"broccoli-rollup": "^2.1.0",
"broccoli-source": "^1.1.0",
"broccoli-string-replace": "^0.1.2",
@@ -131,6 +132,7 @@
"glob": "^7.1.2",
"html-differ": "^1.3.4",
"lodash.uniq": "^4.5.0",
+ "mkdirp": "^0.5.1",
"mocha": "^5.0.0",
"prettier": "1.11.1",
"puppeteer": "^1.3.0",
| true |
Other
|
emberjs
|
ember.js
|
b94707f11819866919a47005ac9c3aa241ad706e.json
|
Write package.json to ES package builds
|
yarn.lock
|
@@ -1482,6 +1482,15 @@ broccoli-plugin@^1.0.0, broccoli-plugin@^1.1.0, broccoli-plugin@^1.2.0, broccoli
rimraf "^2.3.4"
symlink-or-copy "^1.1.8"
+broccoli-plugin@^1.3.1:
+ version "1.3.1"
+ resolved "https://registry.yarnpkg.com/broccoli-plugin/-/broccoli-plugin-1.3.1.tgz#a26315732fb99ed2d9fb58f12a1e14e986b4fabd"
+ dependencies:
+ promise-map-series "^0.2.1"
+ quick-temp "^0.1.3"
+ rimraf "^2.3.4"
+ symlink-or-copy "^1.1.8"
+
broccoli-rollup@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/broccoli-rollup/-/broccoli-rollup-2.1.0.tgz#94d703625c24dbad2e57789508f63ccfcbb13c00"
| true |
Other
|
emberjs
|
ember.js
|
c26405508704bcceea751f3769a282024dc2730b.json
|
Fix eslint errors
|
.eslintrc.js
|
@@ -86,6 +86,7 @@ module.exports = {
files: [
'packages/*/tests/**/*.js',
'packages/@ember/*/tests/**/*.js',
+ 'packages/@ember/-internals/*/tests/**/*.js',
'packages/internal-test-helpers/**/*.js',
],
env: {
| true |
Other
|
emberjs
|
ember.js
|
c26405508704bcceea751f3769a282024dc2730b.json
|
Fix eslint errors
|
packages/@ember/application/lib/application.js
|
@@ -8,7 +8,11 @@ import { hasDOM } from '@ember/-internals/browser-environment';
import { assert, isTesting } from '@ember/debug';
import { DEBUG } from '@glimmer/env';
import { bind, join, once, run, schedule } from '@ember/runloop';
-import { libraries, processAllNamespaces, setNamespaceSearchDisabled } from '@ember/-internals/metal';
+import {
+ libraries,
+ processAllNamespaces,
+ setNamespaceSearchDisabled,
+} from '@ember/-internals/metal';
import { _loaded, runLoadHooks } from './lazy_load';
import { RSVP } from 'ember-runtime';
import { EventDispatcher, jQuery, jQueryDisabled } from '@ember/-internals/views';
| true |
Other
|
emberjs
|
ember.js
|
c26405508704bcceea751f3769a282024dc2730b.json
|
Fix eslint errors
|
packages/@ember/object/lib/computed/reduce_computed_macros.js
|
@@ -2,7 +2,13 @@
@module @ember/object
*/
import { assert } from '@ember/debug';
-import { get, ComputedProperty, addObserver, removeObserver, getProperties } from '@ember/-internals/metal';
+import {
+ get,
+ ComputedProperty,
+ addObserver,
+ removeObserver,
+ getProperties,
+} from '@ember/-internals/metal';
import { compare, isArray, A as emberA, uniqBy as uniqByArray } from 'ember-runtime';
function reduceMacro(dependentKey, callback, initialValue, name) {
| true |
Other
|
emberjs
|
ember.js
|
c26405508704bcceea751f3769a282024dc2730b.json
|
Fix eslint errors
|
packages/ember-runtime/lib/mixins/evented.js
|
@@ -1,4 +1,10 @@
-import { Mixin, addListener, removeListener, hasListeners, sendEvent } from '@ember/-internals/metal';
+import {
+ Mixin,
+ addListener,
+ removeListener,
+ hasListeners,
+ sendEvent,
+} from '@ember/-internals/metal';
/**
@module @ember/object
| true |
Other
|
emberjs
|
ember.js
|
c26405508704bcceea751f3769a282024dc2730b.json
|
Fix eslint errors
|
packages/ember-runtime/tests/system/object/computed_test.js
|
@@ -1,4 +1,12 @@
-import { alias, computed, set, get, getWithDefault, observer, defineProperty } from '@ember/-internals/metal';
+import {
+ alias,
+ computed,
+ set,
+ get,
+ getWithDefault,
+ observer,
+ defineProperty,
+} from '@ember/-internals/metal';
import { oneWay as reads } from '@ember/object/computed';
import EmberObject from '../../../lib/system/object';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
| true |
Other
|
emberjs
|
ember.js
|
c26405508704bcceea751f3769a282024dc2730b.json
|
Fix eslint errors
|
packages/ember-runtime/tests/system/object/destroy_test.js
|
@@ -1,5 +1,11 @@
import { run } from '@ember/runloop';
-import { observer, get, set, beginPropertyChanges, endPropertyChanges } from '@ember/-internals/metal';
+import {
+ observer,
+ get,
+ set,
+ beginPropertyChanges,
+ endPropertyChanges,
+} from '@ember/-internals/metal';
import { peekMeta } from 'ember-meta';
import EmberObject from '../../../lib/system/object';
import { DEBUG } from '@glimmer/env';
| true |
Other
|
emberjs
|
ember.js
|
c26405508704bcceea751f3769a282024dc2730b.json
|
Fix eslint errors
|
packages/ember-runtime/tests/system/object/es-compatibility-test.js
|
@@ -1,5 +1,12 @@
import EmberObject from '../../../lib/system/object';
-import { Mixin, defineProperty, computed, addObserver, addListener, sendEvent } from '@ember/-internals/metal';
+import {
+ Mixin,
+ defineProperty,
+ computed,
+ addObserver,
+ addListener,
+ sendEvent,
+} from '@ember/-internals/metal';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor(
| true |
Other
|
emberjs
|
ember.js
|
c26405508704bcceea751f3769a282024dc2730b.json
|
Fix eslint errors
|
packages/ember-runtime/tests/system/object_proxy_test.js
|
@@ -1,5 +1,12 @@
import { DEBUG } from '@glimmer/env';
-import { addObserver, computed, get, set, isWatching, removeObserver } from '@ember/-internals/metal';
+import {
+ addObserver,
+ computed,
+ get,
+ set,
+ isWatching,
+ removeObserver,
+} from '@ember/-internals/metal';
import { HAS_NATIVE_PROXY } from '@ember/-internals/utils';
import ObjectProxy from '../../lib/system/object_proxy';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
| true |
Other
|
emberjs
|
ember.js
|
428e41e864a2b109174b1c5111b2e10619a3c62d.json
|
Add v3.5.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit e77d544aa433fb57c0d2ba018eea04a21ced4f22)
|
CHANGELOG.md
|
@@ -1,6 +1,12 @@
# Ember Changelog
+### v3.5.0-beta.1 (August 28, 2018)
+
+- [#16877](https://github.com/emberjs/ember.js/pull/16877) [CLEANUP] Allow routes to be named "array" and "object"
+- [#16907](https://github.com/emberjs/ember.js/pull/16907) Upgrade to TypeScript 3.0
+
### v3.4.0 (August 27, 2018)
+
- [#16603](https://github.com/emberjs/ember.js/pull/16603) [BUGFIX] Support mouseEnter/Leave events w/o jQuery
- [#16857](https://github.com/emberjs/ember.js/pull/16857) [BUGFIX] Prevents the recursive redefinition of root chains
- [#16854](https://github.com/emberjs/ember.js/pull/16854) [BUGFIX] Don't thread FactoryManager through createComponent
| false |
Other
|
emberjs
|
ember.js
|
b2cc5662e9c020aa46f84f5801b0f1f7ce5cd0d8.json
|
Add v3.4.0 to CHANGELOG
[ci skip]
(cherry picked from commit 0143d4a97d9d63d4015518345e0ea71a0d3c34be)
|
CHANGELOG.md
|
@@ -1,18 +1,9 @@
# Ember Changelog
-### v3.4.0-beta.3 (August 21, 2018)
-
-- [#16870](https://github.com/emberjs/ember.js/pull/16870) [BUGFIX] Enable @ember/object#get to be called with an empty string
+### v3.4.0 (August 27, 2018)
- [#16603](https://github.com/emberjs/ember.js/pull/16603) [BUGFIX] Support mouseEnter/Leave events w/o jQuery
-
-### v3.4.0-beta.2 (August 06, 2018)
-
- [#16857](https://github.com/emberjs/ember.js/pull/16857) [BUGFIX] Prevents the recursive redefinition of root chains
- [#16854](https://github.com/emberjs/ember.js/pull/16854) [BUGFIX] Don't thread FactoryManager through createComponent
-- [#16853](https://github.com/emberjs/ember.js/pull/16853) [BUGFIX] Allow ArrayProxy#pushObjects to accept ArrayProxy again
-
-### v3.4.0-beta.1 (July 16, 2018)
-
- [#16773](https://github.com/emberjs/ember.js/pull/16773) [FEATURE] Custom component manager (see [emberjs/rfcs#213](https://github.com/emberjs/rfcs/blob/master/text/0213-custom-components.md) for more details)
- [#16708](https://github.com/emberjs/ember.js/pull/16708) [FEATURE] Angle bracket component invocation (see [emberjs/rfcs#311](https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md) for more details)
- [#16744](https://github.com/emberjs/ember.js/pull/16744) [DEPRECATION] Deprecate `component#sendAction` (see [emberjs/rfcs#335](https://github.com/emberjs/rfcs/blob/master/text/0335-deprecate-send-action.md) for more details)
| false |
Other
|
emberjs
|
ember.js
|
888d0070d00edca518ffb3b145aa94f24732143b.json
|
Remove unneeded import
|
packages/ember-metal/tests/tracked/set_test.ts
|
@@ -1,5 +1,5 @@
import { AbstractTestCase, moduleFor } from 'internal-test-helpers';
-import { get, set, setHasViews, tracked } from '../..';
+import { get, set, tracked } from '../..';
import { EMBER_METAL_TRACKED_PROPERTIES } from '@ember/canary-features';
| false |
Other
|
emberjs
|
ember.js
|
d593d86db88c595f3864ee08ad36578ddfe318f1.json
|
Add v3.4.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 84770c4624696aa43ceea5f1e9ab42cfe20714a0)
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### v3.4.0-beta.3 (August 21, 2018)
+
+- [#16870](https://github.com/emberjs/ember.js/pull/16870) [BUGFIX] Enable @ember/object#get to be called with an empty string
+- [#16603](https://github.com/emberjs/ember.js/pull/16603) [BUGFIX] Support mouseEnter/Leave events w/o jQuery
+
### v3.4.0-beta.2 (August 06, 2018)
- [#16857](https://github.com/emberjs/ember.js/pull/16857) [BUGFIX] Prevents the recursive redefinition of root chains
| false |
Other
|
emberjs
|
ember.js
|
4423239563501e6115688e75862d29f635bbb01c.json
|
Fix all type errors
|
packages/ember-metal/tests/tracked/computed_test.ts
|
@@ -7,7 +7,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
moduleFor(
'@tracked getters',
class extends AbstractTestCase {
- ['@test works without get'](assert) {
+ ['@test works without get'](assert: Assert) {
let count = 0;
class Count {
@@ -24,7 +24,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
assert.equal(count, 1, 'should have invoked computed property');
}
- ['@test defining computed property should invoke property on get'](assert) {
+ ['@test defining computed property should invoke property on get'](assert: Assert) {
let count = 0;
class Count {
@@ -41,10 +41,10 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
assert.equal(count, 1, 'should have invoked computed property');
}
- ['@test defining computed property should invoke property on set'](assert) {
+ ['@test defining computed property should invoke property on set'](assert: Assert) {
let count = 0;
- let obj = new class {
+ class Foo {
__foo = '';
@tracked
@@ -56,7 +56,9 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
count++;
this.__foo = `computed ${value}`;
}
- }();
+ }
+
+ let obj = new Foo();
assert.equal(set(obj, 'foo', 'bar'), 'bar', 'should return set value');
assert.equal(count, 1, 'should have invoked computed property');
| true |
Other
|
emberjs
|
ember.js
|
4423239563501e6115688e75862d29f635bbb01c.json
|
Fix all type errors
|
packages/ember-metal/tests/tracked/get_test.ts
|
@@ -43,7 +43,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
let obj = new Obj();
- this.assert.equal(get(obj, 1), 'first');
+ this.assert.equal(get(obj, '1'), 'first');
}
'@test should retrieve an empty key on an object'() {
@@ -112,7 +112,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
let obj = createObj();
for (let key in obj) {
- this.assert.equal(getWithDefault(obj, key, 'fail'), obj[key], key);
+ this.assert.equal(getWithDefault(obj, key as any, 'fail'), obj[key], key);
}
class Obj {
@@ -130,7 +130,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
'explicit undefined retrieves the default'
);
this.assert.equal(
- getWithDefault(obj2, 'not-present', 'default'),
+ getWithDefault(obj2, 'not-present' as any, 'default'),
'default',
'non-present key retrieves the default'
);
| true |
Other
|
emberjs
|
ember.js
|
4423239563501e6115688e75862d29f635bbb01c.json
|
Fix all type errors
|
packages/ember-metal/tests/tracked/set_test.ts
|
@@ -32,30 +32,34 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
setHasViews(() => false);
}
- ['@test should set arbitrary properties on an object'](assert) {
+ ['@test should set arbitrary properties on an object'](assert: Assert) {
let obj = createObj();
- let newObj = new class {
+ class Obj {
@tracked undefinedValue = 'emberjs';
constructor() {
this.undefinedValue = 'emberjs';
}
- }();
+ }
+
+ let newObj = new Obj();
for (let key in obj) {
assert.equal(set(newObj, key, obj[key]), obj[key], 'should return value');
assert.equal(get(newObj, key), obj[key], 'should set value');
}
}
- ['@test should set a number key on an object'](assert) {
- let obj = new class {
+ ['@test should set a number key on an object'](assert: Assert) {
+ class Obj {
@tracked 1 = 'original';
constructor() {
this[1] = 'original';
}
- }();
+ }
+
+ let obj = new Obj();
set(obj, '1', 'first');
assert.equal(obj[1], 'first');
| true |
Other
|
emberjs
|
ember.js
|
4423239563501e6115688e75862d29f635bbb01c.json
|
Fix all type errors
|
packages/ember-metal/tests/tracked/support.js
|
@@ -1,12 +0,0 @@
-import { tracked } from '../..';
-
-export function createWithDescriptors(values) {
- function Class() {}
-
- for (let prop in values) {
- let descriptor = Object.getOwnPropertyDescriptor(values, prop);
- Object.defineProperty(Class.prototype, prop, tracked(Class.prototype, prop, descriptor));
- }
-
- return new Class();
-}
| true |
Other
|
emberjs
|
ember.js
|
4423239563501e6115688e75862d29f635bbb01c.json
|
Fix all type errors
|
packages/ember-metal/tests/tracked/validation_test.ts
|
@@ -91,18 +91,20 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
[`@test interaction with Ember object model (Ember computed property depending on tracked property)`](
assert: Assert
) {
+ let self: EmberObject;
class EmberObject {
name: Name;
constructor(name: Name) {
this.name = name;
+ self = this;
}
}
defineProperty(
EmberObject.prototype,
'full',
computed('name', function() {
- let name = get(this, 'name');
+ let name = get(self, 'name');
return `${name.first} ${name.last}`;
})
);
@@ -145,18 +147,20 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
['@test interaction with the Ember object model (paths going through tracked properties)'](
assert: Assert
) {
+ let self: EmberObject;
class EmberObject {
contact: Contact;
constructor(contact: Contact) {
this.contact = contact;
+ self = this;
}
}
defineProperty(
EmberObject.prototype,
'full',
computed('contact.name.first', 'contact.name.last', function() {
- let contact = get(this, 'contact');
+ let contact = get(self, 'contact');
return `${get(contact.name, 'first')} ${get(contact.name, 'last')}`;
})
);
| true |
Other
|
emberjs
|
ember.js
|
5c2d210691ca486cb73a5a3242eb65bfa2b60c23.json
|
change descriptor check
|
packages/ember-metal/lib/tracked.ts
|
@@ -102,9 +102,7 @@ export function tracked(target: any, key: any, descriptor: PropertyDescriptor):
export function tracked(...dependencies: any[]): any {
let [, key, descriptor] = dependencies;
- if (!descriptor) return;
-
- if ('value' in descriptor) {
+ if (descriptor === undefined || 'initializer' in descriptor) {
return descriptorForDataProperty(key, descriptor);
} else {
return descriptorForAccessor(key, descriptor);
| true |
Other
|
emberjs
|
ember.js
|
5c2d210691ca486cb73a5a3242eb65bfa2b60c23.json
|
change descriptor check
|
packages/ember-metal/tests/tracked/validation_test.ts
|
@@ -8,17 +8,17 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
'@tracked get validation',
class extends AbstractTestCase {
[`@test validators for tracked getters with dependencies should invalidate when the dependencies invalidate`](
- assert
+ assert: Assert
) {
class Tracked {
- @tracked first: string;
- @tracked last: string;
+ @tracked first?: string = undefined;
+ @tracked last?: string = undefined;
constructor(first: string, last: string) {
this.first = first;
this.last = last;
}
- @tracked(['first', 'last'])
+ @tracked
get full() {
return `${this.first} ${this.last}`;
}
@@ -37,6 +37,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
assert.equal(tag.validate(snapshot), true);
obj.first = 'Thomas';
+
assert.equal(tag.validate(snapshot), false);
assert.equal(obj.full, 'Thomas Dale');
@@ -46,7 +47,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
}
[`@test interaction with Ember object model (tracked property depending on Ember property)`](
- assert
+ assert: Assert
) {
interface NameInterface {
first: string;
@@ -58,7 +59,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
this.name = name;
}
- @tracked('name')
+ @tracked
get full() {
return `${get(this.name, 'first')} ${get(this.name, 'last')}`;
}
@@ -88,7 +89,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
}
[`@test interaction with Ember object model (Ember computed property depending on tracked property)`](
- assert
+ assert: Assert
) {
class EmberObject {
name: Name;
@@ -142,10 +143,11 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
}
['@test interaction with the Ember object model (paths going through tracked properties)'](
- assert
+ assert: Assert
) {
class EmberObject {
- constructor(contact) {
+ contact: Contact;
+ constructor(contact: Contact) {
this.contact = contact;
}
}
@@ -160,15 +162,16 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
);
class Contact {
- constructor(name) {
+ @tracked name?: EmberName = undefined;
+ constructor(name: EmberName) {
this.name = name;
}
}
- track(Contact, ['name']);
-
class EmberName {
- constructor(first, last) {
+ first: string;
+ last: string;
+ constructor(first: string, last: string) {
this.first = first;
this.last = last;
}
@@ -208,30 +211,3 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
}
);
}
-
-function track(Class, properties, accessors = {}) {
- let proto = Class.prototype;
-
- properties.forEach(prop => defineData(proto, prop));
-
- let keys = Object.getOwnPropertyNames(accessors);
-
- keys.forEach(key => defineAccessor(proto, key, Object.getOwnPropertyDescriptor(accessors, key)));
-}
-
-function defineData(prototype, property) {
- Object.defineProperty(
- prototype,
- property,
- tracked(prototype, property, {
- enumerable: true,
- configurable: true,
- writable: true,
- value: undefined,
- })
- );
-}
-
-function defineAccessor(prototype, property, descriptor) {
- Object.defineProperty(prototype, property, tracked(prototype, property, descriptor));
-}
| true |
Other
|
emberjs
|
ember.js
|
26bf0d2b1a163ed7afe995dd6d318b75e8c96397.json
|
Add v3.3.2 to CHANGELOG
[ci skip]
(cherry picked from commit 32474519a8820e6be38c76b44add3db0c3e3f20b)
|
CHANGELOG.md
|
@@ -18,6 +18,11 @@
- [#16794](https://github.com/emberjs/ember.js/pull/16794) [BUGFIX] Fix instance-initializer-test blueprint for new QUnit testing API ([emberjs/rfcs#232](https://github.com/emberjs/rfcs/pull/232))
- [#16797](https://github.com/emberjs/ember.js/pull/16797) [BUGFIX] Drop autorun assertion
+### v3.3.2 (August 20, 2018)
+
+- [#16853](https://github.com/emberjs/ember.js/pull/16853) [BUGFIX] Allow ArrayProxy#pushObjects to accept ArrayProxy again
+- [#16870](https://github.com/emberjs/ember.js/pull/16870) [BUGFIX] Enable @ember/object#get to be called with an empty string
+
### v3.3.1 (July 23, 2018)
- [#16836](https://github.com/emberjs/ember.js/pull/16836/commits) [DOC] Fix Broken 3.3 API Documentation
@@ -81,7 +86,7 @@
### v3.1.4 (August 07, 2018)
- [#16565](https://github.com/emberjs/ember.js/pull/16565) Fix template / component caching during rendering.
-- [#16853](https://github.com/emberjs/ember.js/pull/16853) [BUGFIX beta] Allow ArrayProxy#pushObjects to accept ArrayProxy again
+- [#16853](https://github.com/emberjs/ember.js/pull/16853) [BUGFIX] Allow ArrayProxy#pushObjects to accept ArrayProxy again
### v3.1.3 (June 21, 2018)
- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix container destroy timing
| false |
Other
|
emberjs
|
ember.js
|
a47ff0933376f30cc6076f9750666f843114e796.json
|
add mocha rfc 268 acceptance tests
|
blueprints/acceptance-test/mocha-rfc-232-files/tests/acceptance/__name__-test.js
|
@@ -0,0 +1,13 @@
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+import { setupApplicationTest } from 'ember-mocha';
+import { visit, currentURL } from '@ember/test-helpers';
+
+describe('<%= friendlyTestName %>', function() {
+ setupApplicationTest();
+
+ it('can visit /<%= dasherizedModuleName %>', async function() {
+ await visit('/<%= dasherizedModuleName %>');
+ expect(currentURL()).to.equal('/<%= dasherizedModuleName %>');
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
a47ff0933376f30cc6076f9750666f843114e796.json
|
add mocha rfc 268 acceptance tests
|
node-tests/blueprints/acceptance-test-test.js
|
@@ -58,6 +58,24 @@ describe('Blueprint: acceptance-test', function() {
});
});
});
+
+ describe('with [email protected]', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
+ generateFakePackageManifest('ember-mocha', '0.14.0');
+ });
+
+ it('acceptance-test foo', function() {
+ return emberGenerateDestroy(['acceptance-test', 'foo'], _file => {
+ expect(_file('tests/acceptance/foo-test.js')).to.equal(
+ fixture('acceptance-test/mocha-rfc268.js')
+ );
+ });
+ });
+ });
});
describe('in addon', function() {
| true |
Other
|
emberjs
|
ember.js
|
a47ff0933376f30cc6076f9750666f843114e796.json
|
add mocha rfc 268 acceptance tests
|
node-tests/fixtures/acceptance-test/mocha-rfc268.js
|
@@ -0,0 +1,13 @@
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+import { setupApplicationTest } from 'ember-mocha';
+import { visit, currentURL } from '@ember/test-helpers';
+
+describe('Acceptance | foo', function() {
+ setupApplicationTest();
+
+ it('can visit /foo', async function() {
+ await visit('/foo');
+ expect(currentURL()).to.equal('/foo');
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
c504069851276f1e8156a180221d33b0b23a36d8.json
|
Remove references to unused dist/ember-runtime.js
|
lib/index.js
|
@@ -68,7 +68,6 @@ module.exports = {
let emberSourceDistPath = path.join(__dirname, '..', 'dist');
var emberFiles = [
- 'ember-runtime.js',
'ember-template-compiler.js',
'ember-testing.js',
'ember.debug.js',
| true |
Other
|
emberjs
|
ember.js
|
c504069851276f1e8156a180221d33b0b23a36d8.json
|
Remove references to unused dist/ember-runtime.js
|
package.json
|
@@ -14,8 +14,6 @@
"files": [
"build-metadata.json",
"blueprints",
- "dist/ember-runtime.js",
- "dist/ember-runtime.map",
"dist/ember-template-compiler.js",
"dist/ember-template-compiler.map",
"dist/ember-testing.js",
| true |
Other
|
emberjs
|
ember.js
|
8974f23965dbd38f4ff4497f76e3d28c3ddb3abf.json
|
Add v3.1.4 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 9f846821af454f858e7577708b7b615c0576b551)
|
CHANGELOG.md
|
@@ -78,6 +78,11 @@
- [#16462](https://github.com/emberjs/ember.js/pull/16462) [CLEANUP] Remove deprecated `MODEL_FACTORY_INJECTIONS`.
- [emberjs/rfcs#286](https://github.com/emberjs/rfcs/blob/master/text/0286-block-let-template-helper.md) [FEATURE] Enabled block `let` handlebars helper by default.
+### v3.1.4 (August 07, 2018)
+
+- [#16565](https://github.com/emberjs/ember.js/pull/16565) Fix template / component caching during rendering.
+- [#16853](https://github.com/emberjs/ember.js/pull/16853) [BUGFIX beta] Allow ArrayProxy#pushObjects to accept ArrayProxy again
+
### v3.1.3 (June 21, 2018)
- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix container destroy timing
| false |
Other
|
emberjs
|
ember.js
|
ddec402d601c9791f2f8a7ca1c83265e0e48de6c.json
|
Add v3.4.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit df84704d3b267ada2b074e7ee6aace7168fb8941)
|
CHANGELOG.md
|
@@ -1,5 +1,11 @@
# Ember Changelog
+### v3.4.0-beta.2 (August 06, 2018)
+
+- [#16857](https://github.com/emberjs/ember.js/pull/16857) [BUGFIX] Prevents the recursive redefinition of root chains
+- [#16854](https://github.com/emberjs/ember.js/pull/16854) [BUGFIX] Don't thread FactoryManager through createComponent
+- [#16853](https://github.com/emberjs/ember.js/pull/16853) [BUGFIX] Allow ArrayProxy#pushObjects to accept ArrayProxy again
+
### v3.4.0-beta.1 (July 16, 2018)
- [#16773](https://github.com/emberjs/ember.js/pull/16773) [FEATURE] Custom component manager (see [emberjs/rfcs#213](https://github.com/emberjs/rfcs/blob/master/text/0213-custom-components.md) for more details)
| false |
Other
|
emberjs
|
ember.js
|
1cbd034ce0c7f0c26970b9923d17b51c00c9ea53.json
|
Add v3.4.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit c8b6aa15884db3e93475c01583cfc86ceb9004a8)
|
CHANGELOG.md
|
@@ -1,5 +1,17 @@
# Ember Changelog
+### v3.4.0-beta.1 (July 16, 2018)
+
+- [#16773](https://github.com/emberjs/ember.js/pull/16773) [FEATURE] Custom component manager (see [emberjs/rfcs#213](https://github.com/emberjs/rfcs/blob/master/text/0213-custom-components.md) for more details)
+- [#16708](https://github.com/emberjs/ember.js/pull/16708) [FEATURE] Angle bracket component invocation (see [emberjs/rfcs#311](https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md) for more details)
+- [#16744](https://github.com/emberjs/ember.js/pull/16744) [DEPRECATION] Deprecate `component#sendAction` (see [emberjs/rfcs#335](https://github.com/emberjs/rfcs/blob/master/text/0335-deprecate-send-action.md) for more details)
+- [#16720](https://github.com/emberjs/ember.js/pull/16720) Upgrade `backburner.js` to 2.3.0
+- [#16783](https://github.com/emberjs/ember.js/pull/16783) [BUGFIX] Allow setting length on ArrayProxy.
+- [#16785](https://github.com/emberjs/ember.js/pull/16785) [BUGFIX] Ensure `ArrayMixin#invoke` returns an Ember.A.
+- [#16784](https://github.com/emberjs/ember.js/pull/16784) [BUGFIX] Setting ArrayProxy#content in willDestroy resets length.
+- [#16794](https://github.com/emberjs/ember.js/pull/16794) [BUGFIX] Fix instance-initializer-test blueprint for new QUnit testing API ([emberjs/rfcs#232](https://github.com/emberjs/rfcs/pull/232))
+- [#16797](https://github.com/emberjs/ember.js/pull/16797) [BUGFIX] Drop autorun assertion
+
### v3.3.0 (July 16, 2018)
- [#16687](https://github.com/emberjs/ember.js/pull/16687) [FEATURE] Implement optional jQuery integration (see [emberjs/rfcs#294](https://github.com/emberjs/rfcs/blob/master/text/0294-optional-jquery.md) for more details).
| false |
Other
|
emberjs
|
ember.js
|
d08990a3045367d4be73729899c6c8016c92167b.json
|
Add v3.3.0 to CHANGELOG
[ci skip]
(cherry picked from commit 1d3ab4e3033f3a46db5a7dd985e7699d196a0154)
|
CHANGELOG.md
|
@@ -1,28 +1,19 @@
# Ember Changelog
-### v3.3.0-beta.5 (July 2, 2018)
-- [#16781](https://github.com/emberjs/ember.js/pull/16781) [BUGFIX] Ensure tests from @ember/* are excluded from debug/prod builds.
-
-### v3.3.0-beta.4 (June 25, 2018)
-- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix container destroy timing
-- [#16767](https://github.com/emberjs/ember.js/pull/16767) [BUGFIX] Ensure meta._parent is initialized
-
-### v3.3.0-beta.3 (June 18, 2018)
-- [#16743](https://github.com/emberjs/ember.js/pull/16743) [BUGFIX] Update glimmer-vm to 0.35.4.
-- [#16750](https://github.com/emberjs/ember.js/pull/16750) [BUGFIX] Bring back isObject guard for ember-utils/is_proxy
-
-### v3.3.0-beta.2 (June 11, 2018)
-- [#16709](https://github.com/emberjs/ember.js/pull/16709) [BUGFIX] Avoid ordered set deprecation in @ember/ordered-set addon
-- [#16715](https://github.com/emberjs/ember.js/pull/16715) [BUGFIX] Update glimmer-vm to 0.35.3
-- [#16729](https://github.com/emberjs/ember.js/pull/16729) [BUGFIX] Throw error if run.bind receives no method
-- [#16731](https://github.com/emberjs/ember.js/pull/16731) [BUGFIX] Better error when a route name is not valid
-
-### v3.3.0-beta.1 (May 31, 2018)
+### v3.3.0 (July 16, 2018)
- [#16687](https://github.com/emberjs/ember.js/pull/16687) [FEATURE] Implement optional jQuery integration (see [emberjs/rfcs#294](https://github.com/emberjs/rfcs/blob/master/text/0294-optional-jquery.md) for more details).
- [#16690](https://github.com/emberjs/ember.js/pull/16690) [DEPRECATION] [emberjs/rfcs#294](emberjs/rfcs#294) Deprecate accessing `jQuery.Event#originalEvent`.
- [#16691](https://github.com/emberjs/ember.js/pull/16691) [DEPRECATION] [emberjs/rfcs#237](https://github.com/emberjs/rfcs/pull/237) Implement `Ember.Map`, `Ember.MapWithDefault`, and `Ember.OrderedSet` deprecation.
- [#16692](https://github.com/emberjs/ember.js/pull/16692) [DEPRECATION] [emberjs/rfcs#322](https://github.com/emberjs/rfcs/pull/322) Implement `Ember.copy`/`Ember.Copyable` deprecation.
+- [#16709](https://github.com/emberjs/ember.js/pull/16709) [BUGFIX] Avoid ordered set deprecation in @ember/ordered-set addon.
+- [#16729](https://github.com/emberjs/ember.js/pull/16729) [BUGFIX] Throw error if run.bind receives no method.
+- [#16731](https://github.com/emberjs/ember.js/pull/16731) [BUGFIX] Better error when a route name is not valid.
+- [#16743](https://github.com/emberjs/ember.js/pull/16743) [BUGFIX] Update glimmer-vm to 0.35.4.
+- [#16767](https://github.com/emberjs/ember.js/pull/16767) [BUGFIX] Ensure meta._parent is initialized.
+- [#16781](https://github.com/emberjs/ember.js/pull/16781) [BUGFIX] Ensure tests from @ember/* are excluded from debug/prod builds.
+- [#16619](https://github.com/emberjs/ember.js/pull/16619) [BUGFIX] Update router_js to ensure `(hash` works in query params.
+- [#16632](https://github.com/emberjs/ember.js/pull/16632) [BUGFIX] computed.sort array should update if sort properties array is empty/
### v3.2.2 (June 21, 2018)
| false |
Other
|
emberjs
|
ember.js
|
10cad8712e1ba4942fd88b20e0dc5a838425684a.json
|
remove double ending line
|
blueprints/service-test/qunit-rfc-232-files/__root__/__testType__/__path__/__test__.js
|
@@ -10,4 +10,3 @@ module('<%= friendlyTestDescription %>', function(hooks) {
assert.ok(service);
});
});
-
| true |
Other
|
emberjs
|
ember.js
|
10cad8712e1ba4942fd88b20e0dc5a838425684a.json
|
remove double ending line
|
node-tests/fixtures/service-test/rfc232.js
|
@@ -10,4 +10,3 @@ module('Unit | Service | foo', function(hooks) {
assert.ok(service);
});
});
-
| true |
Other
|
emberjs
|
ember.js
|
cff0b102833de4a5953ba303b3955b0164a153b7.json
|
Drop autorun assertion
This removes the autorun assertion in test mode. The original conditions that caused it to be added are no longer true, as we are on a version of backburner that uses microtask scheduling.
|
packages/@ember/runloop/index.js
|
@@ -1,4 +1,4 @@
-import { assert, deprecate, isTesting } from '@ember/debug';
+import { assert, deprecate } from '@ember/debug';
import { onErrorTarget } from 'ember-error-handling';
import { beginPropertyChanges, endPropertyChanges } from 'ember-metal';
import Backburner from 'backburner';
@@ -325,11 +325,6 @@ export function end() {
@public
*/
export function schedule(queue /*, target, method */) {
- assert(
- `You have turned on testing mode, which disabled the run-loop's autorun. ` +
- `You will need to wrap any code with asynchronous side-effects in a run`,
- currentRunLoop || !isTesting()
- );
deprecate(`Scheduling into the '${queue}' run loop queue is deprecated.`, queue !== 'sync', {
id: 'ember-metal.run.sync',
until: '3.5.0',
@@ -398,11 +393,6 @@ export function later(/*target, method*/) {
@public
*/
export function once(...args) {
- assert(
- `You have turned on testing mode, which disabled the run-loop's autorun. ` +
- `You will need to wrap any code with asynchronous side-effects in a run`,
- currentRunLoop || !isTesting()
- );
args.unshift('actions');
return backburner.scheduleOnce(...args);
}
@@ -480,11 +470,6 @@ export function once(...args) {
@public
*/
export function scheduleOnce(queue /*, target, method*/) {
- assert(
- `You have turned on testing mode, which disabled the run-loop's autorun. ` +
- `You will need to wrap any code with asynchronous side-effects in a run`,
- currentRunLoop || !isTesting()
- );
deprecate(`Scheduling into the '${queue}' run loop queue is deprecated.`, queue !== 'sync', {
id: 'ember-metal.run.sync',
until: '3.5.0',
| true |
Other
|
emberjs
|
ember.js
|
cff0b102833de4a5953ba303b3955b0164a153b7.json
|
Drop autorun assertion
This removes the autorun assertion in test mode. The original conditions that caused it to be added are no longer true, as we are on a version of backburner that uses microtask scheduling.
|
packages/@ember/runloop/tests/schedule_test.js
|
@@ -82,18 +82,5 @@ moduleFor(
assert.deepEqual(order, ['sync', 'actions', 'sync', 'actions', 'destroy']);
}
-
- ['@test makes sure it does not trigger an autorun during testing']() {
- expectAssertion(
- () => schedule('actions', () => {}),
- /wrap any code with asynchronous side-effects in a run/
- );
-
- // make sure not just the first violation is asserted.
- expectAssertion(
- () => schedule('actions', () => {}),
- /wrap any code with asynchronous side-effects in a run/
- );
- }
}
);
| true |
Other
|
emberjs
|
ember.js
|
64fe277d0d5c3c87bc1eac9d118f0e5c01f8c4de.json
|
Add v3.3.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 22811d6821de39caf5c010f930ac696db720cb93)
|
CHANGELOG.md
|
@@ -1,5 +1,8 @@
# Ember Changelog
+### v3.3.0-beta.5 (July 2, 2018)
+- [#16781](https://github.com/emberjs/ember.js/pull/16781) [BUGFIX] Ensure tests from @ember/* are excluded from debug/prod builds.
+
### v3.3.0-beta.4 (June 25, 2018)
- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix container destroy timing
- [#16767](https://github.com/emberjs/ember.js/pull/16767) [BUGFIX] Ensure meta._parent is initialized
| false |
Other
|
emberjs
|
ember.js
|
38bf61d9d11ceda9dddd90230ac3e412fca7791b.json
|
build release branches
|
.travis.yml
|
@@ -34,6 +34,8 @@ branches:
- master
- beta
- release
+ # release branches
+ - /^(?:release|lts)-\d+-\d+$/
# npm version tags
- /^v\d+\.\d+\.\d+/
| false |
Other
|
emberjs
|
ember.js
|
72733afb5e9cb11308f8e21115ccc7d6d9335f6a.json
|
Convert ObjectProxy and ArrayProxy
|
packages/ember-runtime/lib/mixins/array.js
|
@@ -208,7 +208,6 @@ const ArrayMixin = Mixin.create(Enumerable, {
@property {Number} length
@public
*/
- length: null,
/**
Returns the object at the given `index`. If the given `index` is negative
@@ -234,13 +233,6 @@ const ArrayMixin = Mixin.create(Enumerable, {
@return {*} item at index or undefined
@public
*/
- objectAt(idx) {
- if (idx < 0 || idx >= this.length) {
- return undefined;
- }
-
- return get(this, idx);
- },
/**
This returns the objects at the specified indexes, using `objectAt`.
@@ -1207,7 +1199,6 @@ const MutableArray = Mixin.create(ArrayMixin, MutableEnumerable, {
inserted into the array at *idx*
@public
*/
- replace: null,
/**
Remove all elements from the array. This is useful if you
| true |
Other
|
emberjs
|
ember.js
|
72733afb5e9cb11308f8e21115ccc7d6d9335f6a.json
|
Convert ObjectProxy and ArrayProxy
|
packages/ember-runtime/lib/system/array_proxy.js
|
@@ -5,7 +5,6 @@
import {
get,
objectAt,
- computed,
alias,
PROPERTY_DID_CHANGE,
addArrayObserver,
@@ -80,9 +79,9 @@ const ARRAY_OBSERVER_MAPPING = {
@uses MutableArray
@public
*/
-export default EmberObject.extend(MutableArray, {
+export default class ArrayProxy extends EmberObject {
init() {
- this._super(...arguments);
+ super.init(...arguments);
/*
`this._objectsDirtyIndex` determines which indexes in the `this._objects`
@@ -102,11 +101,11 @@ export default EmberObject.extend(MutableArray, {
this._arrangedContent = null;
this._addArrangedContentArrayObsever();
- },
+ }
willDestroy() {
this._removeArrangedContentArrayObsever();
- },
+ }
/**
The content array. Must be an object that implements `Array` and/or
@@ -116,17 +115,6 @@ export default EmberObject.extend(MutableArray, {
@type EmberArray
@public
*/
- content: null,
-
- /**
- The array that the proxy pretends to be. In the default `ArrayProxy`
- implementation, this and `content` are the same. Subclasses of `ArrayProxy`
- can override this property to provide things like sorting and filtering.
-
- @property arrangedContent
- @public
- */
- arrangedContent: alias('content'),
/**
Should actually retrieve the object at the specified index from the
@@ -142,15 +130,15 @@ export default EmberObject.extend(MutableArray, {
*/
objectAtContent(idx) {
return objectAt(get(this, 'arrangedContent'), idx);
- },
+ }
replace(idx, amt, objects) {
assert(
'Mutating an arranged ArrayProxy is not allowed',
get(this, 'arrangedContent') === get(this, 'content')
);
this.replaceContent(idx, amt, objects);
- },
+ }
/**
Should actually replace the specified objects on the content array.
@@ -169,7 +157,7 @@ export default EmberObject.extend(MutableArray, {
*/
replaceContent(idx, amt, objects) {
get(this, 'content').replace(idx, amt, objects);
- },
+ }
// Overriding objectAt is not supported.
objectAt(idx) {
@@ -192,18 +180,18 @@ export default EmberObject.extend(MutableArray, {
}
return this._objects[idx];
- },
+ }
// Overriding length is not supported.
- length: computed(function() {
+ get length() {
if (this._lengthDirty) {
let arrangedContent = get(this, 'arrangedContent');
this._length = arrangedContent ? get(arrangedContent, 'length') : 0;
this._lengthDirty = false;
}
return this._length;
- }).volatile(),
+ }
[PROPERTY_DID_CHANGE](key) {
if (key === 'arrangedContent') {
@@ -220,7 +208,7 @@ export default EmberObject.extend(MutableArray, {
this.arrayContentDidChange(0, oldLength, newLength);
this._addArrangedContentArrayObsever();
}
- },
+ }
_addArrangedContentArrayObsever() {
let arrangedContent = get(this, 'arrangedContent');
@@ -235,15 +223,15 @@ export default EmberObject.extend(MutableArray, {
this._arrangedContent = arrangedContent;
}
- },
+ }
_removeArrangedContentArrayObsever() {
if (this._arrangedContent) {
removeArrayObserver(this._arrangedContent, this, ARRAY_OBSERVER_MAPPING);
}
- },
+ }
- _arrangedContentArrayWillChange() {},
+ _arrangedContentArrayWillChange() {}
_arrangedContentArrayDidChange(proxy, idx, removedCnt, addedCnt) {
this.arrayContentWillChange(idx, removedCnt, addedCnt);
@@ -265,5 +253,17 @@ export default EmberObject.extend(MutableArray, {
this._lengthDirty = true;
this.arrayContentDidChange(idx, removedCnt, addedCnt);
- },
+ }
+}
+
+ArrayProxy.reopen(MutableArray, {
+ /**
+ The array that the proxy pretends to be. In the default `ArrayProxy`
+ implementation, this and `content` are the same. Subclasses of `ArrayProxy`
+ can override this property to provide things like sorting and filtering.
+
+ @property arrangedContent
+ @public
+ */
+ arrangedContent: alias('content'),
});
| true |
Other
|
emberjs
|
ember.js
|
72733afb5e9cb11308f8e21115ccc7d6d9335f6a.json
|
Convert ObjectProxy and ArrayProxy
|
packages/ember-runtime/lib/system/object_proxy.js
|
@@ -77,5 +77,5 @@ import _ProxyMixin from '../mixins/-proxy';
@uses Ember.ProxyMixin
@public
*/
-
-export default FrameworkObject.extend(_ProxyMixin);
+export default class ObjectProxy extends FrameworkObject {}
+ObjectProxy.PrototypeMixin.reopen(_ProxyMixin);
| true |
Other
|
emberjs
|
ember.js
|
e3895580d7a4f40890cf104b43584fe3baef33ba.json
|
Add v3.3.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 4f543588238b63d639a0f046b31c27b6139e23dc)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.3.0-beta.4 (June 25, 2018)
+- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix container destroy timing
+- [#16767](https://github.com/emberjs/ember.js/pull/16767) [BUGFIX] Ensure meta._parent is initialized
+
### v3.3.0-beta.3 (June 18, 2018)
- [#16743](https://github.com/emberjs/ember.js/pull/16743) [BUGFIX] Update glimmer-vm to 0.35.4.
- [#16750](https://github.com/emberjs/ember.js/pull/16750) [BUGFIX] Bring back isObject guard for ember-utils/is_proxy
| false |
Other
|
emberjs
|
ember.js
|
16b8df445f008d34cd56e6395ba9b1cea62a872e.json
|
Add v3.1.3 to CHANGELOG
[ci skip]
(cherry picked from commit 175fb43be30098433a3a868a75c74210e3c5e54e)
|
CHANGELOG.md
|
@@ -58,6 +58,9 @@
- [#16462](https://github.com/emberjs/ember.js/pull/16462) [CLEANUP] Remove deprecated `MODEL_FACTORY_INJECTIONS`.
- [emberjs/rfcs#286](https://github.com/emberjs/rfcs/blob/master/text/0286-block-let-template-helper.md) [FEATURE] Enabled block `let` handlebars helper by default.
+### v3.1.3 (June 21, 2018)
+- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix container destroy timing
+
### v3.1.2 (May 7, 2018)
- [#16600](https://github.com/emberjs/ember.js/pull/16600) [BUGFIX] Fix SimpleHelper memory leak
- [#16605](https://github.com/emberjs/ember.js/pull/16605) [BUGFIX] Use resetCache on container destroy.
| false |
Other
|
emberjs
|
ember.js
|
51e5b48a11ec1386ece8ef94606cbd6cd122ee0e.json
|
Make EmberObject and Namespace use extends
|
packages/ember-runtime/lib/system/namespace.js
|
@@ -33,12 +33,10 @@ import EmberObject from './object';
@extends EmberObject
@public
*/
-const Namespace = EmberObject.extend({
- isNamespace: true,
-
+export default class Namespace extends EmberObject {
init() {
addNamespace(this);
- },
+ }
toString() {
let name = get(this, 'name') || get(this, 'modulePrefix');
@@ -52,23 +50,20 @@ const Namespace = EmberObject.extend({
setName(this, name);
}
return name;
- },
+ }
nameClasses() {
processNamespace(this);
- },
+ }
destroy() {
removeNamespace(this);
- this._super(...arguments);
- },
-});
-
-Namespace.reopenClass({
- NAMESPACES,
- NAMESPACES_BY_ID,
- processAll: processAllNamespaces,
- byName: findNamespace,
-});
+ super.destroy();
+ }
+}
-export default Namespace;
+Namespace.prototype.isNamespace = true;
+Namespace.NAMESPACES = NAMESPACES;
+Namespace.NAMESPACES_BY_ID = NAMESPACES_BY_ID;
+Namespace.processAll = processAllNamespaces;
+Namespace.byName = findNamespace;
| true |
Other
|
emberjs
|
ember.js
|
51e5b48a11ec1386ece8ef94606cbd6cd122ee0e.json
|
Make EmberObject and Namespace use extends
|
packages/ember-runtime/lib/system/object.js
|
@@ -5,7 +5,7 @@
import { FACTORY_FOR } from 'container';
import { OWNER } from 'ember-owner';
import { symbol, setName } from 'ember-utils';
-import { on, descriptor } from 'ember-metal';
+import { addListener } from 'ember-metal';
import CoreObject from './core_object';
import Observable from '../mixins/observable';
import { assert } from '@ember/debug';
@@ -23,57 +23,51 @@ let OVERRIDE_OWNER = symbol('OVERRIDE_OWNER');
@uses Observable
@public
*/
-const EmberObject = CoreObject.extend(Observable, {
- _debugContainerKey: descriptor({
- enumerable: false,
- get() {
- let factory = FACTORY_FOR.get(this);
+export default class EmberObject extends CoreObject {
+ get _debugContainerKey() {
+ let factory = FACTORY_FOR.get(this);
+ return factory !== undefined && factory.fullName;
+ }
- return factory !== undefined && factory.fullName;
- },
- }),
+ get [OWNER]() {
+ if (this[OVERRIDE_OWNER]) {
+ return this[OVERRIDE_OWNER];
+ }
- [OWNER]: descriptor({
- enumerable: false,
- get() {
- if (this[OVERRIDE_OWNER]) {
- return this[OVERRIDE_OWNER];
- }
+ let factory = FACTORY_FOR.get(this);
+ return factory !== undefined && factory.owner;
+ }
- let factory = FACTORY_FOR.get(this);
-
- return factory !== undefined && factory.owner;
- },
-
- // we need a setter here largely to support
- // folks calling `owner.ownerInjection()` API
- set(value) {
- this[OVERRIDE_OWNER] = value;
- },
- }),
-});
+ // we need a setter here largely to support
+ // folks calling `owner.ownerInjection()` API
+ set [OWNER](value) {
+ this[OVERRIDE_OWNER] = value;
+ }
+}
setName(EmberObject, 'Ember.Object');
+Observable.apply(EmberObject.prototype);
+
export let FrameworkObject = EmberObject;
if (DEBUG) {
let INIT_WAS_CALLED = symbol('INIT_WAS_CALLED');
let ASSERT_INIT_WAS_CALLED = symbol('ASSERT_INIT_WAS_CALLED');
- FrameworkObject = EmberObject.extend({
+ FrameworkObject = class FrameworkObject extends EmberObject {
init() {
- this._super(...arguments);
+ super.init(...arguments);
this[INIT_WAS_CALLED] = true;
- },
+ }
- [ASSERT_INIT_WAS_CALLED]: on('init', function() {
+ [ASSERT_INIT_WAS_CALLED]() {
assert(
`You must call \`this._super(...arguments);\` when overriding \`init\` on a framework object. Please update ${this} to call \`this._super(...arguments);\` from \`init\`.`,
this[INIT_WAS_CALLED]
);
- }),
- });
-}
+ }
+ };
-export default EmberObject;
+ addListener(FrameworkObject.prototype, 'init', null, ASSERT_INIT_WAS_CALLED);
+}
| true |
Other
|
emberjs
|
ember.js
|
2b80236e26a48a17f976c62f0b71ceb0d21261ee.json
|
Ensure meta._parent is initialized
|
packages/ember-meta/lib/meta.ts
|
@@ -64,6 +64,7 @@ export class Meta {
counters!.metaInstantiated++;
this._values = undefined;
}
+ this._parent = undefined;
this._descriptors = undefined;
this._watching = undefined;
this._mixins = undefined;
| false |
Other
|
emberjs
|
ember.js
|
244b647ebcb984d813a4d93d5d39037dddcd9d08.json
|
Add v3.2.2 to CHANGELOG
[ci skip]
(cherry picked from commit e0f32cc98d61868895c8fae7ea7f683d77ecd8fb)
|
CHANGELOG.md
|
@@ -17,6 +17,9 @@
- [#16691](https://github.com/emberjs/ember.js/pull/16691) [DEPRECATION] [emberjs/rfcs#237](https://github.com/emberjs/rfcs/pull/237) Implement `Ember.Map`, `Ember.MapWithDefault`, and `Ember.OrderedSet` deprecation.
- [#16692](https://github.com/emberjs/ember.js/pull/16692) [DEPRECATION] [emberjs/rfcs#322](https://github.com/emberjs/rfcs/pull/322) Implement `Ember.copy`/`Ember.Copyable` deprecation.
+### v3.2.2 (June 21, 2018)
+
+- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix container destroy timing
### v3.2.1 (June 19, 2018)
| false |
Other
|
emberjs
|
ember.js
|
28d4b76017fe23bdb2e38611692f42a111091780.json
|
add interop testing for compatibility
make meta.parent lazier
|
packages/ember-meta/lib/meta.ts
|
@@ -49,15 +49,15 @@ export class Meta {
_flags: number;
source: object;
proto: object | undefined;
- parent: Meta | undefined;
+ _parent: Meta | undefined | null;
_listeners: any | undefined;
_listenersFinalized: boolean;
// DEBUG
_values: any | undefined;
_bindings: any | undefined;
- constructor(obj: object, parentMeta: Meta | undefined) {
+ constructor(obj: object) {
if (DEBUG) {
counters!.metaInstantiated++;
this._values = undefined;
@@ -85,16 +85,19 @@ export class Meta {
// prototype and doesn't need to actually be observable itself
this.proto = obj.constructor === undefined ? undefined : obj.constructor.prototype;
- // The next meta in our inheritance chain. We (will) track this
- // explicitly instead of using prototypical inheritance because we
- // have detailed knowledge of how each property should really be
- // inherited, and we can optimize it much better than JS runtimes.
- this.parent = parentMeta;
-
this._listeners = undefined;
this._listenersFinalized = false;
}
+ get parent() {
+ let parent = this._parent;
+ if (parent === undefined) {
+ let proto = getPrototypeOf(this.source);
+ this._parent = parent = proto === null ? null : meta(proto);
+ }
+ return parent;
+ }
+
isInitialized(obj: object) {
return this.proto !== obj;
}
@@ -149,8 +152,8 @@ export class Meta {
}
_getInherited(key: string) {
- let pointer: Meta | undefined = this;
- while (pointer !== undefined) {
+ let pointer: Meta | null = this;
+ while (pointer !== null) {
let map = pointer[key];
if (map !== undefined) {
return map;
@@ -160,8 +163,8 @@ export class Meta {
}
_findInherited(key: string, subkey: string): any | undefined {
- let pointer: Meta | undefined = this;
- while (pointer !== undefined) {
+ let pointer: Meta | null = this;
+ while (pointer !== null) {
let map = pointer[key];
if (map !== undefined) {
let value = map[subkey];
@@ -174,8 +177,8 @@ export class Meta {
}
_hasInInheritedSet(key: string, value: any) {
- let pointer: Meta | undefined = this;
- while (pointer !== undefined) {
+ let pointer: Meta | null = this;
+ while (pointer !== null) {
let set = pointer[key];
if (set !== undefined) {
if (set.has(value)) {
@@ -208,8 +211,8 @@ export class Meta {
}
peekDeps(subkey: string, itemkey: string): number {
- let pointer: Meta | undefined = this;
- while (pointer !== undefined) {
+ let pointer: Meta | null = this;
+ while (pointer !== null) {
let map = pointer._deps;
if (map !== undefined) {
let value = map[subkey];
@@ -227,8 +230,8 @@ export class Meta {
}
hasDeps(subkey: string) {
- let pointer: Meta | undefined = this;
- while (pointer !== undefined) {
+ let pointer: Meta | null = this;
+ while (pointer !== null) {
let deps = pointer._deps;
if (deps !== undefined && deps[subkey] !== undefined) {
return true;
@@ -243,10 +246,10 @@ export class Meta {
}
_forEachIn(key: string, subkey: string, fn: Function) {
- let pointer: Meta | undefined = this;
+ let pointer: Meta | null = this;
let seen: Set<any> | undefined;
let calls: any[] | undefined;
- while (pointer !== undefined) {
+ while (pointer !== null) {
let map = pointer[key];
if (map !== undefined) {
let innerMap = map[subkey];
@@ -325,7 +328,7 @@ export class Meta {
);
let ret = this._chains;
if (ret === undefined) {
- if (this.parent === undefined) {
+ if (this.parent === null) {
ret = create(this.source);
} else {
ret = this.parent.writableChains(create).copy(this.source);
@@ -375,9 +378,9 @@ export class Meta {
}
forEachMixins(fn: Function) {
- let pointer: Meta | undefined = this;
+ let pointer: Meta | null = this;
let seen: Set<any> | undefined;
- while (pointer !== undefined) {
+ while (pointer !== null) {
let set = pointer._mixins;
if (set !== undefined) {
seen = seen === undefined ? new Set() : seen;
@@ -416,9 +419,9 @@ export class Meta {
}
forEachDescriptors(fn: Function) {
- let pointer: Meta | undefined = this;
+ let pointer: Meta | null = this;
let seen: Set<any> | undefined;
- while (pointer !== undefined) {
+ while (pointer !== null) {
let map = pointer._descriptors;
if (map !== undefined) {
for (let key in map) {
@@ -456,7 +459,7 @@ export class Meta {
this._listeners = [];
}
let pointer = this.parent;
- while (pointer !== undefined) {
+ while (pointer !== null) {
let listeners = pointer._listeners;
if (listeners !== undefined) {
this._listeners = this._listeners.concat(listeners);
@@ -470,8 +473,8 @@ export class Meta {
}
removeFromListeners(eventName: string, target: any, method: Function | string): void {
- let pointer: Meta | undefined = this;
- while (pointer !== undefined) {
+ let pointer: Meta | null = this;
+ while (pointer !== null) {
let listeners = pointer._listeners;
if (listeners !== undefined) {
for (let index = listeners.length - 4; index >= 0; index -= 4) {
@@ -499,10 +502,10 @@ export class Meta {
}
matchingListeners(eventName: string) {
- let pointer: Meta | undefined = this;
+ let pointer: Meta | null = this;
// fix type
let result: any[] | undefined;
- while (pointer !== undefined) {
+ while (pointer !== null) {
let listeners = pointer._listeners;
if (listeners !== undefined) {
for (let index = 0; index < listeners.length; index += 4) {
@@ -553,9 +556,9 @@ if (BINDING_SUPPORT && ENV._ENABLE_BINDING_SUPPORT) {
};
Meta.prototype.forEachBindings = function(fn: Function) {
- let pointer: Meta | undefined = this;
+ let pointer: Meta | null = this;
let seen: { [key: string]: any } | undefined;
- while (pointer !== undefined) {
+ while (pointer !== null) {
let map = pointer._bindings;
if (map !== undefined) {
for (let key in map) {
@@ -608,9 +611,9 @@ if (DEBUG) {
Meta.prototype.readInheritedValue = function(key, subkey) {
let internalKey = `_${key}`;
- let pointer: Meta | undefined = this;
+ let pointer: Meta | null = this;
- while (pointer !== undefined) {
+ while (pointer !== null) {
let map = pointer[internalKey];
if (map !== undefined) {
let value = map[subkey];
@@ -743,17 +746,13 @@ export const meta: {
}
let maybeMeta = peekMeta(obj);
- let parent;
// remove this code, in-favor of explicit parent
- if (maybeMeta !== undefined) {
- if (maybeMeta.source === obj) {
- return maybeMeta;
- }
- parent = maybeMeta;
+ if (maybeMeta !== undefined && maybeMeta.source === obj) {
+ return maybeMeta;
}
- let newMeta = new Meta(obj, parent);
+ let newMeta = new Meta(obj);
setMeta(obj, newMeta);
return newMeta;
};
| true |
Other
|
emberjs
|
ember.js
|
28d4b76017fe23bdb2e38611692f42a111091780.json
|
add interop testing for compatibility
make meta.parent lazier
|
packages/ember-runtime/tests/system/object/es-compatibility-test.js
|
@@ -1,5 +1,5 @@
import EmberObject from '../../../lib/system/object';
-import { Mixin, defineProperty, computed } from 'ember-metal';
+import { Mixin, defineProperty, computed, addObserver, addListener, sendEvent } from 'ember-metal';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor(
@@ -296,5 +296,174 @@ moduleFor(
// able to get meta without throwing an error
SubEmberObject.metaForProperty('foo');
}
+
+ '@test super and _super interop between old and new methods'(assert) {
+ let calls = [];
+ let changes = [];
+ let events = [];
+ let lastProps;
+
+ class A extends EmberObject {
+ init(props) {
+ calls.push('A init');
+ lastProps = props;
+ }
+ }
+
+ let Mixin1 = Mixin.create({
+ init() {
+ calls.push('Mixin1 init before _super');
+ this._super(...arguments);
+ calls.push('Mixin1 init after _super');
+ },
+ });
+
+ let Mixin2 = Mixin.create({
+ init() {
+ calls.push('Mixin2 init before _super');
+ this._super(...arguments);
+ calls.push('Mixin2 init after _super');
+ },
+ });
+
+ class B extends A.extend(Mixin1, Mixin2) {
+ init() {
+ calls.push('B init before super.init');
+ super.init(...arguments);
+ calls.push('B init after super.init');
+ }
+
+ onSomeEvent(evt) {
+ events.push(`B onSomeEvent ${evt}`);
+ }
+
+ fullNameDidChange() {
+ changes.push('B fullNameDidChange');
+ }
+ }
+
+ // // define a CP
+ defineProperty(
+ B.prototype,
+ 'full',
+ computed('first', 'last', {
+ get() {
+ return this.first + ' ' + this.last;
+ },
+ })
+ );
+
+ // Only string observers are allowed for prototypes
+ addObserver(B.prototype, 'full', null, 'fullNameDidChange');
+
+ // Only string listeners are allowed for prototypes
+ addListener(B.prototype, 'someEvent', null, 'onSomeEvent');
+
+ B.reopen({
+ init() {
+ calls.push('reopen init before _super');
+ this._super(...arguments);
+ calls.push('reopen init after _super');
+ },
+ });
+
+ let C = B.extend({
+ init() {
+ calls.push('C init before _super');
+ this._super(...arguments);
+ calls.push('C init after _super');
+ },
+
+ onSomeEvent(evt) {
+ calls.push('C onSomeEvent before _super');
+ this._super(evt);
+ calls.push('C onSomeEvent after _super');
+ },
+
+ fullNameDidChange() {
+ calls.push('C fullNameDidChange before _super');
+ this._super();
+ calls.push('C fullNameDidChange after _super');
+ },
+ });
+
+ class D extends C {
+ constructor(props) {
+ if (props.last === undefined) {
+ props.last = 'Jackson';
+ }
+ super(props);
+ }
+
+ init() {
+ calls.push('D init before super.init');
+ super.init(...arguments);
+ calls.push('D init after super.init');
+ }
+
+ onSomeEvent(evt) {
+ events.push('D onSomeEvent before super.onSomeEvent');
+ super.onSomeEvent(evt);
+ events.push('D onSomeEvent after super.onSomeEvent');
+ }
+
+ fullNameDidChange() {
+ changes.push('D fullNameDidChange before super.fullNameDidChange');
+ super.fullNameDidChange();
+ changes.push('D fullNameDidChange after super.fullNameDidChange');
+ }
+
+ triggerSomeEvent(...args) {
+ sendEvent(this, 'someEvent', args);
+ }
+ }
+
+ assert.deepEqual(calls, [], 'nothing has been called');
+ assert.deepEqual(changes, [], 'full has not changed');
+ assert.deepEqual(events, [], 'onSomeEvent has not been triggered');
+
+ let d = D.create({ first: 'Robert' });
+
+ assert.deepEqual(calls, [
+ 'D init before super.init',
+ 'C init before _super',
+ 'reopen init before _super',
+ 'B init before super.init',
+ 'Mixin2 init before _super',
+ 'Mixin1 init before _super',
+ 'A init',
+ 'Mixin1 init after _super',
+ 'Mixin2 init after _super',
+ 'B init after super.init',
+ 'reopen init after _super',
+ 'C init after _super',
+ 'D init after super.init',
+ ]);
+ assert.deepEqual(changes, [], 'full has not changed');
+ assert.deepEqual(events, [], 'onSomeEvent has not been triggered');
+
+ assert.deepEqual(lastProps, {
+ first: 'Robert',
+ last: 'Jackson',
+ });
+
+ assert.equal(d.full, 'Robert Jackson');
+
+ d.setProperties({ first: 'Kris', last: 'Selden' });
+ assert.deepEqual(changes, [
+ 'D fullNameDidChange before super.fullNameDidChange',
+ 'B fullNameDidChange',
+ 'D fullNameDidChange after super.fullNameDidChange',
+ ]);
+
+ assert.equal(d.full, 'Kris Selden');
+
+ d.triggerSomeEvent('event arg');
+ assert.deepEqual(events, [
+ 'D onSomeEvent before super.onSomeEvent',
+ 'B onSomeEvent event arg',
+ 'D onSomeEvent after super.onSomeEvent',
+ ]);
+ }
}
);
| true |
Other
|
emberjs
|
ember.js
|
7ed1f804ebf238b07152d7fd1f24086816ee336d.json
|
remove unused code
|
packages/ember-runtime/lib/ext/function.js
|
@@ -118,29 +118,6 @@ if (ENV.EXTEND_PROTOTYPES.Function) {
},
},
- _observesImmediately: {
- configurable: true,
- enumerable: false,
- writable: true,
- value: function() {
- assert(
- 'Immediate observers must observe internal properties only, ' +
- 'not properties on other objects.',
- function checkIsInternalProperty() {
- for (let i = 0; i < arguments.length; i++) {
- if (arguments[i].indexOf('.') !== -1) {
- return false;
- }
- }
- return true;
- }
- );
-
- // observes handles property expansion
- return this.observes(...arguments);
- },
- },
-
/**
The `on` extension of Javascript's Function prototype is available
when `EmberENV.EXTEND_PROTOTYPES` or `EmberENV.EXTEND_PROTOTYPES.Function` is
| false |
Other
|
emberjs
|
ember.js
|
277294f8dabf25980d80010bc07d2950db9d2a92.json
|
Remove unused export.
|
packages/@ember/application/globals-resolver.js
|
@@ -11,23 +11,6 @@ import validateType from './lib/validate-type';
import { getTemplate } from 'ember-glimmer';
import { DEBUG } from '@glimmer/env';
-export const Resolver = EmberObject.extend({
- /*
- This will be set to the Application instance when it is
- created.
-
- @property namespace
- */
- namespace: null,
- normalize: null, // required
- resolve: null, // required
- parseName: null, // required
- lookupDescription: null, // required
- makeToString: null, // required
- resolveOther: null, // required
- _logLookup: null, // required
-});
-
/**
The DefaultResolver defines the default lookup rules to resolve
container lookups before consulting the container for registered
| false |
Other
|
emberjs
|
ember.js
|
0ddac17b8d4172dd77bd6a1e3183b67a728e3558.json
|
CHANGELOG entries for `{{#each}}` & `{{#each-in}}`
|
CHANGELOG.md
|
@@ -26,31 +26,33 @@
- [#16613](https://github.com/emberjs/ember.js/pull/16613) [BUGFIX] Prevent errors in ember-engines + 3.1 + proxies.
- [#16597](https://github.com/emberjs/ember.js/pull/16597) [BUGFIX] Ensure `Ember.run.cancelTimers` is present.
-- [#16605](https://github.com/emberjs/ember.js/pull/16605) [BUGFIX] Use resetCache on container destroy
-- [#16615](https://github.com/emberjs/ember.js/pull/16615) [BUGFIX] Fix NAMESPACES_BY_ID leaks
+- [#16605](https://github.com/emberjs/ember.js/pull/16605) [BUGFIX] Use resetCache on container destroy.
+- [#16615](https://github.com/emberjs/ember.js/pull/16615) [BUGFIX] Fix NAMESPACES_BY_ID leaks.
- [#16539](https://github.com/emberjs/ember.js/pull/16539) [BUGFIX] Ember is already registered by the libraries registry already.
-- [#16559](https://github.com/emberjs/ember.js/pull/16559) [BUGFIX] Fix property normalization, Update glimmer-vm to 0.34.0
+- [#16559](https://github.com/emberjs/ember.js/pull/16559) [BUGFIX] Fix property normalization, Update glimmer-vm to 0.34.0.
- [#16563](https://github.com/emberjs/ember.js/pull/16563) [BUGFIX] Ensure `ariaRole` can be initially false.
-- [#16550](https://github.com/emberjs/ember.js/pull/16550) [BUGFIX] Decrement counter of pending requests in the next tick
-- [#16551](https://github.com/emberjs/ember.js/pull/16551) [BUGFIX] Fix `proto` return value for native classes
+- [#16550](https://github.com/emberjs/ember.js/pull/16550) [BUGFIX] Decrement counter of pending requests in the next tick.
+- [#16551](https://github.com/emberjs/ember.js/pull/16551) [BUGFIX] Fix `proto` return value for native classes.
- [#16558](https://github.com/emberjs/ember.js/pull/16558) [BUGFIX] Ensure ComponentDefinitions do not leak heap space.
-- [#16560](https://github.com/emberjs/ember.js/pull/16560) [BUGFIX] avoid strict assertion when object proxy calls thru for function
+- [#16560](https://github.com/emberjs/ember.js/pull/16560) [BUGFIX] avoid strict assertion when object proxy calls thru for function.
- [#16564](https://github.com/emberjs/ember.js/pull/16564) [BUGFIX] Ensure Ember.isArray does not trigger proxy assertion.
-- [#16572](https://github.com/emberjs/ember.js/pull/16572) [BUGFIX] Fix curly component class reference setup
+- [#16572](https://github.com/emberjs/ember.js/pull/16572) [BUGFIX] Fix curly component class reference setup.
- [#16493](https://github.com/emberjs/ember.js/pull/16493) [BUGFIX] Ensure proxies have access to `getOwner(this)`.
-- [#16494](https://github.com/emberjs/ember.js/pull/16494) [BUGFIX] Adjust assertion to allow for either undefined or null
-- [#16499](https://github.com/emberjs/ember.js/pull/16499) [BUGFIX] Object to string serialization
+- [#16494](https://github.com/emberjs/ember.js/pull/16494) [BUGFIX] Adjust assertion to allow for either undefined or null.
+- [#16499](https://github.com/emberjs/ember.js/pull/16499) [BUGFIX] Object to string serialization.
- [#16514](https://github.com/emberjs/ember.js/pull/16514) [BUGFIX] Bring back (with deprecation) Ember.EXTEND_PROTOTYPES.
-- [#16520](https://github.com/emberjs/ember.js/pull/16520) [BUGFIX] Adds options checking ability to debug/deprecation test helpers
+- [#16520](https://github.com/emberjs/ember.js/pull/16520) [BUGFIX] Adds options checking ability to debug/deprecation test helpers.
- [#16526](https://github.com/emberjs/ember.js/pull/16526) [BUGFIX] Ensure setting a `NAME_KEY` does not error.
- [#16527](https://github.com/emberjs/ember.js/pull/16527) [BUGFIX] Update glimmer-vm to 0.33.5.
-- [#16250](https://github.com/emberjs/ember.js/pull/16250) [DEPRECATION] Deprecation of `Ember.Logger`
+- [#16250](https://github.com/emberjs/ember.js/pull/16250) [DEPRECATION] Deprecation of `Ember.Logger`.
- [#16436](https://github.com/emberjs/ember.js/pull/16436) [BUGFIX] Refactor `CoreObject` to leverage native JS semantics.
- [#16382](https://github.com/emberjs/ember.js/pull/16382) Upgrade `backburner.js` to 2.2.2.
-- [#16387](https://github.com/emberjs/ember.js/pull/16387) [BUGFIX] Add an assertion that actions cannot be sent from a destroyed/destroying object
-- [#16386](https://github.com/emberjs/ember.js/pull/16386) [BUGFIX] Add an assertion if you attempt a `transitionTo` when the app is destroyed
-- [#16433](https://github.com/emberjs/ember.js/pull/16433) [CLEANUP] Remove `content` alias
-- [#16462](https://github.com/emberjs/ember.js/pull/16462) [CLEANUP] Remove deprecated `MODEL_FACTORY_INJECTIONS`
+- [#16387](https://github.com/emberjs/ember.js/pull/16387) [BUGFIX] Add an assertion that actions cannot be sent from a destroyed/destroying object.
+- [#16386](https://github.com/emberjs/ember.js/pull/16386) [BUGFIX] Add an assertion if you attempt a `transitionTo` when the app is destroyed.
+- [#16399](https://github.com/emberjs/ember.js/pull/16399) [BUGFIX] `{{#each}}` and `{{#each-in}}` now support objects implementing the native iteration protocol, including `Map` and `Set`.
+- [#16399](https://github.com/emberjs/ember.js/pull/16399) [BUGFIX] `{{#each-in}}` now correctly handles `key="@index"` (using the index/position). The new `key="@key"` option uses the item's key.
+- [#16433](https://github.com/emberjs/ember.js/pull/16433) [CLEANUP] Remove `content` alias.
+- [#16462](https://github.com/emberjs/ember.js/pull/16462) [CLEANUP] Remove deprecated `MODEL_FACTORY_INJECTIONS`.
- [emberjs/rfcs#286](https://github.com/emberjs/rfcs/blob/master/text/0286-block-let-template-helper.md) [FEATURE] Enabled block `let` handlebars helper by default.
### v3.1.2 (May 7, 2018)
| false |
Other
|
emberjs
|
ember.js
|
372aca378c51e19daa3bd82be07b759b0b0003ce.json
|
Add v3.2.1 to CHANGELOG
[ci skip]
(cherry picked from commit d8c83ff9443138185b43c1e19ee7fd4bbdd94be8)
|
CHANGELOG.md
|
@@ -18,6 +18,10 @@
- [#16692](https://github.com/emberjs/ember.js/pull/16692) [DEPRECATION] [emberjs/rfcs#322](https://github.com/emberjs/rfcs/pull/322) Implement `Ember.copy`/`Ember.Copyable` deprecation.
+### v3.2.1 (June 19, 2018)
+
+- [#16750](https://github.com/emberjs/ember.js/pull/16750) [BUGFIX] Bring back isObject guard for ember-utils/is_proxy
+
### v3.2.0 (May 31, 2018)
- [#16613](https://github.com/emberjs/ember.js/pull/16613) [BUGFIX] Prevent errors in ember-engines + 3.1 + proxies.
| false |
Other
|
emberjs
|
ember.js
|
7863b093cb86c47fef4d9044d8beeb4d8ffef76f.json
|
Add v3.3.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 60b68a350c111ec662daa025853d4a70d35be499)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.3.0-beta.3 (June 18, 2018)
+- [#16743](https://github.com/emberjs/ember.js/pull/16743) [BUGFIX] Update glimmer-vm to 0.35.4.
+- [#16750](https://github.com/emberjs/ember.js/pull/16750) [BUGFIX] Bring back isObject guard for ember-utils/is_proxy
+
### v3.3.0-beta.2 (June 11, 2018)
- [#16709](https://github.com/emberjs/ember.js/pull/16709) [BUGFIX] Avoid ordered set deprecation in @ember/ordered-set addon
- [#16715](https://github.com/emberjs/ember.js/pull/16715) [BUGFIX] Update glimmer-vm to 0.35.3
| false |
Other
|
emberjs
|
ember.js
|
d38033daaa53db4857e775bbe491af80a5e467cd.json
|
Fix code style
|
packages/ember-runtime/tests/mixins/container_proxy_test.js
|
@@ -25,14 +25,17 @@ moduleFor(
assert.equal(result[OWNER], this.instance, 'returns an object with the OWNER symbol');
}
- ["@test actions queue completes before destruction"](assert) {
+ ['@test actions queue completes before destruction'](assert) {
assert.expect(1);
- this.registry.register('service:auth', EmberObject.extend({
- willDestroy() {
- assert.ok(getOwner(this).lookup('service:auth'), 'can still lookup');
- }
- }));
+ this.registry.register(
+ 'service:auth',
+ EmberObject.extend({
+ willDestroy() {
+ assert.ok(getOwner(this).lookup('service:auth'), 'can still lookup');
+ },
+ })
+ );
let service = this.instance.lookup('service:auth');
| false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.