language
stringclasses 1
value | owner
stringlengths 2
15
| repo
stringlengths 2
21
| sha
stringlengths 45
45
| message
stringlengths 7
36.3k
| path
stringlengths 1
199
| patch
stringlengths 15
102k
| is_multipart
bool 2
classes |
|---|---|---|---|---|---|---|---|
Other
|
emberjs
|
ember.js
|
27b852ac99c7846162f8b263ced800bbfed2833c.json
|
blueprints/component-test: Add RFC232 variants
|
blueprints/component-test/qunit-rfc-232-files/tests/__testType__/__path__/__test__.js
|
@@ -0,0 +1,36 @@
+<% if (testType === 'integration') { %>import { module, test } from 'qunit';
+import { setupRenderingTest } from 'ember-qunit';
+import { render } from '@ember/test-helpers';
+import hbs from 'htmlbars-inline-precompile';
+
+module('<%= friendlyTestDescription %>', function(hooks) {
+ setupRenderingTest(hooks);
+
+ test('it renders', async function(assert) {
+ // Set any properties with this.set('myProperty', 'value');
+ // Handle any actions with this.set('myAction', function(val) { ... });
+
+ await render(hbs`{{<%= componentPathName %>}}`);
+
+ assert.equal(this.element.textContent.trim(), '');
+
+ // Template block usage:
+ await render(hbs`
+ {{#<%= componentPathName %>}}
+ template block text
+ {{/<%= componentPathName %>}}
+ `);
+
+ assert.equal(this.element.textContent.trim(), 'template block text');
+ });
+});<% } else if (testType === 'unit') { %>import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('<%= friendlyTestDescription %>', function(hooks) {
+ setupTest(hooks);
+
+ test('it exists', function(assert) {
+ let component = this.owner.factoryFor('component:<%= componentPathName %>').create();
+ assert.ok(component);
+ });
+});<% } %>
| true |
Other
|
emberjs
|
ember.js
|
27b852ac99c7846162f8b263ced800bbfed2833c.json
|
blueprints/component-test: Add RFC232 variants
|
node-tests/blueprints/component-test.js
|
@@ -805,6 +805,28 @@ describe('Acceptance: ember generate component', function() {
}));
});
+ it('component-test x-foo for RFC232', function() {
+ var args = ['component-test', 'x-foo'];
+
+ return emberNew()
+ .then(() => generateFakePackageManifest('ember-cli-qunit', '4.1.1'))
+ .then(() => emberGenerateDestroy(args, _file => {
+ expect(_file('tests/integration/components/x-foo-test.js'))
+ .to.equal(fixture('component-test/rfc232.js'));
+ }));
+ });
+
+ it('component-test x-foo --unit for RFC232', function() {
+ var args = ['component-test', 'x-foo', '--unit'];
+
+ return emberNew()
+ .then(() => generateFakePackageManifest('ember-cli-qunit', '4.1.1'))
+ .then(() => emberGenerateDestroy(args, _file => {
+ expect(_file('tests/unit/components/x-foo-test.js'))
+ .to.equal(fixture('component-test/rfc232-unit.js'));
+ }));
+ });
+
it('component-test x-foo for mocha', function() {
var args = ['component-test', 'x-foo'];
| true |
Other
|
emberjs
|
ember.js
|
27b852ac99c7846162f8b263ced800bbfed2833c.json
|
blueprints/component-test: Add RFC232 variants
|
node-tests/fixtures/component-test/rfc232-unit.js
|
@@ -0,0 +1,11 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('Unit | Component | x foo', function(hooks) {
+ setupTest(hooks);
+
+ test('it exists', function(assert) {
+ let component = this.owner.factoryFor('component:x-foo').create();
+ assert.ok(component);
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
27b852ac99c7846162f8b263ced800bbfed2833c.json
|
blueprints/component-test: Add RFC232 variants
|
node-tests/fixtures/component-test/rfc232.js
|
@@ -0,0 +1,26 @@
+import { module, test } from 'qunit';
+import { setupRenderingTest } from 'ember-qunit';
+import { render } from '@ember/test-helpers';
+import hbs from 'htmlbars-inline-precompile';
+
+module('Integration | Component | x foo', function(hooks) {
+ setupRenderingTest(hooks);
+
+ test('it renders', async function(assert) {
+ // Set any properties with this.set('myProperty', 'value');
+ // Handle any actions with this.set('myAction', function(val) { ... });
+
+ await render(hbs`{{x-foo}}`);
+
+ assert.equal(this.element.textContent.trim(), '');
+
+ // Template block usage:
+ await render(hbs`
+ {{#x-foo}}
+ template block text
+ {{/x-foo}}
+ `);
+
+ assert.equal(this.element.textContent.trim(), 'template block text');
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
32482baeaa617ff7feb90aec5147782bbff15bb3.json
|
tests/blueprints/component-test: Use fixture files
|
node-tests/blueprints/component-test.js
|
@@ -13,6 +13,7 @@ var chai = require('ember-cli-blueprint-test-helpers/chai');
var expect = chai.expect;
var generateFakePackageManifest = require('../helpers/generate-fake-package-manifest');
+var fixture = require('../helpers/file');
describe('Acceptance: ember generate component', function() {
setupTestHooks(this);
@@ -719,12 +720,7 @@ describe('Acceptance: ember generate component', function() {
return emberNew()
.then(() => emberGenerateDestroy(args, _file => {
expect(_file('tests/integration/components/x-foo-test.js'))
- .to.contain("import { moduleForComponent, test } from 'ember-qunit';")
- .to.contain("import hbs from 'htmlbars-inline-precompile';")
- .to.contain("moduleForComponent('x-foo'")
- .to.contain("integration: true")
- .to.contain("{{x-foo}}")
- .to.contain("{{#x-foo}}");
+ .to.equal(fixture('component-test/default.js'));
}));
});
@@ -757,9 +753,7 @@ describe('Acceptance: ember generate component', function() {
return emberNew()
.then(() => emberGenerateDestroy(args, _file => {
expect(_file('tests/unit/components/x-foo-test.js'))
- .to.contain("import { moduleForComponent, test } from 'ember-qunit';")
- .to.contain("moduleForComponent('x-foo'")
- .to.contain("unit: true");
+ .to.equal(fixture('component-test/unit.js'));
}));
});
@@ -822,12 +816,7 @@ describe('Acceptance: ember generate component', function() {
.then(() => generateFakePackageManifest('ember-cli-mocha', '0.11.0'))
.then(() => emberGenerateDestroy(args, _file => {
expect(_file('tests/integration/components/x-foo-test.js'))
- .to.contain("import { describeComponent, it } from 'ember-mocha';")
- .to.contain("import hbs from 'htmlbars-inline-precompile';")
- .to.contain("describeComponent('x-foo', 'Integration | Component | x foo'")
- .to.contain("integration: true")
- .to.contain("{{x-foo}}")
- .to.contain("{{#x-foo}}");
+ .to.equal(fixture('component-test/mocha.js'));
}));
});
@@ -842,9 +831,7 @@ describe('Acceptance: ember generate component', function() {
.then(() => generateFakePackageManifest('ember-cli-mocha', '0.11.0'))
.then(() => emberGenerateDestroy(args, _file => {
expect(_file('tests/unit/components/x-foo-test.js'))
- .to.contain("import { describeComponent, it } from 'ember-mocha';")
- .to.contain("describeComponent('x-foo', 'Unit | Component | x foo")
- .to.contain("unit: true");
+ .to.equal(fixture('component-test/mocha-unit.js'));
}));
});
@@ -859,14 +846,7 @@ describe('Acceptance: ember generate component', function() {
.then(() => generateFakePackageManifest('ember-cli-mocha', '0.12.0'))
.then(() => emberGenerateDestroy(args, _file => {
expect(_file('tests/integration/components/x-foo-test.js'))
- .to.contain("import { describe, it } from 'mocha';")
- .to.contain("import { setupComponentTest } from 'ember-mocha';")
- .to.contain("import hbs from 'htmlbars-inline-precompile';")
- .to.contain("describe('Integration | Component | x foo'")
- .to.contain("setupComponentTest('x-foo',")
- .to.contain("integration: true")
- .to.contain("{{x-foo}}")
- .to.contain("{{#x-foo}}");
+ .to.equal(fixture('component-test/mocha-0.12.js'));
}));
});
@@ -881,11 +861,7 @@ describe('Acceptance: ember generate component', function() {
.then(() => generateFakePackageManifest('ember-cli-mocha', '0.12.0'))
.then(() => emberGenerateDestroy(args, _file => {
expect(_file('tests/unit/components/x-foo-test.js'))
- .to.contain("import { describe, it } from 'mocha';")
- .to.contain("import { setupComponentTest } from 'ember-mocha';")
- .to.contain("describe('Unit | Component | x foo'")
- .to.contain("setupComponentTest('x-foo',")
- .to.contain("unit: true");
+ .to.equal(fixture('component-test/mocha-0.12-unit.js'));
}));
});
});
| true |
Other
|
emberjs
|
ember.js
|
32482baeaa617ff7feb90aec5147782bbff15bb3.json
|
tests/blueprints/component-test: Use fixture files
|
node-tests/fixtures/component-test/default.js
|
@@ -0,0 +1,24 @@
+import { moduleForComponent, test } from 'ember-qunit';
+import hbs from 'htmlbars-inline-precompile';
+
+moduleForComponent('x-foo', 'Integration | Component | x foo', {
+ integration: true
+});
+
+test('it renders', function(assert) {
+ // Set any properties with this.set('myProperty', 'value');
+ // Handle any actions with this.on('myAction', function(val) { ... });
+
+ this.render(hbs`{{x-foo}}`);
+
+ assert.equal(this.$().text().trim(), '');
+
+ // Template block usage:
+ this.render(hbs`
+ {{#x-foo}}
+ template block text
+ {{/x-foo}}
+ `);
+
+ assert.equal(this.$().text().trim(), 'template block text');
+});
| true |
Other
|
emberjs
|
ember.js
|
32482baeaa617ff7feb90aec5147782bbff15bb3.json
|
tests/blueprints/component-test: Use fixture files
|
node-tests/fixtures/component-test/mocha-0.12-unit.js
|
@@ -0,0 +1,20 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupComponentTest } from 'ember-mocha';
+
+describe('Unit | Component | x foo', function() {
+ setupComponentTest('x-foo', {
+ // Specify the other units that are required for this test
+ // needs: ['component:foo', 'helper:bar'],
+ unit: true
+ });
+
+ it('renders', function() {
+ // creates the component instance
+ let component = this.subject();
+ // renders the component on the page
+ this.render();
+ expect(component).to.be.ok;
+ expect(this.$()).to.have.length(1);
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
32482baeaa617ff7feb90aec5147782bbff15bb3.json
|
tests/blueprints/component-test: Use fixture files
|
node-tests/fixtures/component-test/mocha-0.12.js
|
@@ -0,0 +1,24 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupComponentTest } from 'ember-mocha';
+import hbs from 'htmlbars-inline-precompile';
+
+describe('Integration | Component | x foo', function() {
+ setupComponentTest('x-foo', {
+ integration: true
+ });
+
+ it('renders', function() {
+ // Set any properties with this.set('myProperty', 'value');
+ // Handle any actions with this.on('myAction', function(val) { ... });
+ // Template block usage:
+ // this.render(hbs`
+ // {{#x-foo}}
+ // template content
+ // {{/x-foo}}
+ // `);
+
+ this.render(hbs`{{x-foo}}`);
+ expect(this.$()).to.have.length(1);
+ });
+});
| true |
Other
|
emberjs
|
ember.js
|
32482baeaa617ff7feb90aec5147782bbff15bb3.json
|
tests/blueprints/component-test: Use fixture files
|
node-tests/fixtures/component-test/mocha-unit.js
|
@@ -0,0 +1,20 @@
+import { expect } from 'chai';
+import { describeComponent, it } from 'ember-mocha';
+
+describeComponent('x-foo', 'Unit | Component | x foo',
+ {
+ // Specify the other units that are required for this test
+ // needs: ['component:foo', 'helper:bar'],
+ unit: true
+ },
+ function() {
+ it('renders', function() {
+ // creates the component instance
+ let component = this.subject();
+ // renders the component on the page
+ this.render();
+ expect(component).to.be.ok;
+ expect(this.$()).to.have.length(1);
+ });
+ }
+);
| true |
Other
|
emberjs
|
ember.js
|
32482baeaa617ff7feb90aec5147782bbff15bb3.json
|
tests/blueprints/component-test: Use fixture files
|
node-tests/fixtures/component-test/mocha.js
|
@@ -0,0 +1,24 @@
+import { expect } from 'chai';
+import { describeComponent, it } from 'ember-mocha';
+import hbs from 'htmlbars-inline-precompile';
+
+describeComponent('x-foo', 'Integration | Component | x foo',
+ {
+ integration: true
+ },
+ function() {
+ it('renders', function() {
+ // Set any properties with this.set('myProperty', 'value');
+ // Handle any actions with this.on('myAction', function(val) { ... });
+ // Template block usage:
+ // this.render(hbs`
+ // {{#x-foo}}
+ // template content
+ // {{/x-foo}}
+ // `);
+
+ this.render(hbs`{{x-foo}}`);
+ expect(this.$()).to.have.length(1);
+ });
+ }
+);
| true |
Other
|
emberjs
|
ember.js
|
32482baeaa617ff7feb90aec5147782bbff15bb3.json
|
tests/blueprints/component-test: Use fixture files
|
node-tests/fixtures/component-test/unit.js
|
@@ -0,0 +1,16 @@
+import { moduleForComponent, test } from 'ember-qunit';
+
+moduleForComponent('x-foo', 'Unit | Component | x foo', {
+ // Specify the other units that are required for this test
+ // needs: ['component:foo', 'helper:bar'],
+ unit: true
+});
+
+test('it renders', function(assert) {
+
+ // Creates the component instance
+ /*let component =*/ this.subject();
+ // Renders the component to the page
+ this.render();
+ assert.equal(this.$().text().trim(), '');
+});
| true |
Other
|
emberjs
|
ember.js
|
71f453292eb7d6bb253c0c7222ab8cfc9f2a739f.json
|
Remove empty willMergeMixin function
|
packages/ember-metal/lib/mixin.js
|
@@ -237,6 +237,7 @@ function mergeMixins(mixins, meta, descs, values, base, keys) {
if (props === CONTINUE) { continue; }
if (props) {
+ // remove willMergeMixin after 3.4 as it was used for _actions
if (base.willMergeMixin) { base.willMergeMixin(props); }
concats = concatenatedMixinProperties('concatenatedProperties', props, values, base);
mergings = concatenatedMixinProperties('mergedProperties', props, values, base);
| true |
Other
|
emberjs
|
ember.js
|
71f453292eb7d6bb253c0c7222ab8cfc9f2a739f.json
|
Remove empty willMergeMixin function
|
packages/ember-runtime/lib/mixins/action_handler.js
|
@@ -210,9 +210,7 @@ const ActionHandler = Mixin.create({
);
target.send(...arguments);
}
- },
-
- willMergeMixin() {}
+ }
});
export default ActionHandler;
| true |
Other
|
emberjs
|
ember.js
|
774608b3dfddc07f1070a8b0ab7c74c9e6ecde6e.json
|
Update Backburner.js to 2.0.0.
Updates to require native Map (aka drops IE < 10 and phantomjs support).
|
package.json
|
@@ -78,7 +78,7 @@
"babel-plugin-transform-es2015-template-literals": "^6.22.0",
"babel-plugin-transform-proto-to-assign": "^6.23.0",
"babel-template": "^6.24.1",
- "backburner.js": "^1.3.1",
+ "backburner.js": "^2.0.0",
"broccoli-babel-transpiler": "^6.1.1",
"broccoli-concat": "^3.2.2",
"broccoli-debug": "^0.6.3",
| true |
Other
|
emberjs
|
ember.js
|
774608b3dfddc07f1070a8b0ab7c74c9e6ecde6e.json
|
Update Backburner.js to 2.0.0.
Updates to require native Map (aka drops IE < 10 and phantomjs support).
|
yarn.lock
|
@@ -908,9 +908,9 @@ backbone@^1.1.2:
dependencies:
underscore ">=1.8.3"
-backburner.js@^1.3.1:
- version "1.3.1"
- resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-1.3.1.tgz#f89ebd433063693f2ab13b6f8a3427fefc31cdcf"
+backburner.js@^2.0.0:
+ version "2.0.0"
+ resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-2.0.0.tgz#ca78f7357776e24885f4dd4a887249b35fdd9c6c"
[email protected]:
version "1.0.2"
| true |
Other
|
emberjs
|
ember.js
|
37c0e0c5e7291800cddf57ff2c6b782661016b8d.json
|
Remove unused import
|
packages/ember-runtime/lib/mixins/registry_proxy.js
|
@@ -5,7 +5,6 @@
import {
Mixin
} from 'ember-metal';
-import { deprecate } from 'ember-debug';
/**
RegistryProxyMixin is used to provide public access to specific
| false |
Other
|
emberjs
|
ember.js
|
32b6244772dc68f9b92fcaee008accb2ed36678e.json
|
Remove unused legacy shims.
|
vendor/ember/shims.js
|
@@ -1,253 +0,0 @@
-(function() {
-/* globals define, Ember, jQuery */
-
- function processEmberShims() {
- var shims = {
- 'ember': {
- 'default': Ember
- },
- 'ember-application': {
- 'default': Ember.Application
- },
- 'ember-array': {
- 'default': Ember.Array
- },
- 'ember-array/mutable': {
- 'default': Ember.MutableArray
- },
- 'ember-array/utils': {
- 'A': Ember.A,
- 'isEmberArray': Ember.isArray,
- 'wrap': Ember.makeArray
- },
- 'ember-component': {
- 'default': Ember.Component
- },
- 'ember-components/checkbox': {
- 'default': Ember.Checkbox
- },
- 'ember-components/text-area': {
- 'default': Ember.TextArea
- },
- 'ember-components/text-field': {
- 'default': Ember.TextField
- },
- 'ember-controller': {
- 'default': Ember.Controller
- },
- 'ember-controller/inject': {
- 'default': Ember.inject.controller
- },
- 'ember-controller/proxy': {
- 'default': Ember.ArrayProxy
- },
- 'ember-controllers/sortable': {
- 'default': Ember.SortableMixin
- },
- 'ember-debug': {
- 'log': Ember.debug,
- 'inspect': Ember.inspect,
- 'run': Ember.runInDebug,
- 'warn': Ember.warn
- },
- 'ember-debug/container-debug-adapter': {
- 'default': Ember.ContainerDebugAdapter
- },
- 'ember-debug/data-adapter': {
- 'default': Ember.DataAdapter
- },
- 'ember-deprecations': {
- 'deprecate': Ember.deprecate,
- 'deprecateFunc': Ember.deprecateFunc
- },
- 'ember-enumerable': {
- 'default': Ember.Enumerable
- },
- 'ember-evented': {
- 'default': Ember.Evented
- },
- 'ember-evented/on': {
- 'default': Ember.on
- },
- 'ember-globals-resolver': {
- 'default': Ember.DefaultResolver
- },
- 'ember-helper': {
- 'default': Ember.Helper,
- 'helper': Ember.Helper && Ember.Helper.helper
- },
- 'ember-instrumentation': {
- 'instrument': Ember.Instrumentation.instrument,
- 'reset': Ember.Instrumentation.reset,
- 'subscribe': Ember.Instrumentation.subscribe,
- 'unsubscribe': Ember.Instrumentation.unsubscribe
- },
- 'ember-locations/hash': {
- 'default': Ember.HashLocation
- },
- 'ember-locations/history': {
- 'default': Ember.HistoryLocation
- },
- 'ember-locations/none': {
- 'default': Ember.NoneLocation
- },
- 'ember-map': {
- 'default': Ember.Map,
- 'withDefault': Ember.MapWithDefault
- },
- 'ember-metal/destroy': {
- 'default': Ember.destroy
- },
- 'ember-metal/events': {
- 'addListener': Ember.addListener,
- 'removeListener': Ember.removeListener,
- 'send': Ember.sendEvent
- },
- 'ember-metal/get': {
- 'default': Ember.get
- },
- 'ember-metal/mixin': {
- 'default': Ember.Mixin
- },
- 'ember-metal/observer': {
- 'default': Ember.observer,
- 'addObserver': Ember.addObserver,
- 'removeObserver': Ember.removeObserver
- },
- 'ember-metal/on-load': {
- 'default': Ember.onLoad,
- 'run': Ember.runLoadHooks
- },
- 'ember-metal/set': {
- 'default': Ember.set,
- 'setProperties': Ember.setProperties,
- 'trySet': Ember.trySet
- },
- 'ember-metal/utils': {
- 'aliasMethod': Ember.aliasMethod,
- 'assert': Ember.assert,
- 'cacheFor': Ember.cacheFor,
- 'copy': Ember.copy
- },
- 'ember-object': {
- 'default': Ember.Object
- },
- 'ember-owner/get': {
- 'default': Ember.getOwner
- },
- 'ember-owner/set': {
- 'default': Ember.setOwner
- },
- 'ember-platform': {
- 'assign': Ember.merge,
- 'create': Ember.create,
- 'defineProperty': Ember.platform.defineProperty,
- 'hasAccessors': Ember.platform.hasPropertyAccessors,
- 'keys': Ember.keys
- },
- 'ember-route': {
- 'default': Ember.Route
- },
- 'ember-router': {
- 'default': Ember.Router
- },
- 'ember-runloop': {
- 'default': Ember.run,
- 'begin': Ember.run.begin,
- 'bind': Ember.run.bind,
- 'cancel': Ember.run.cancel,
- 'debounce': Ember.run.debounce,
- 'end': Ember.run.end,
- 'join': Ember.run.join,
- 'later': Ember.run.later,
- 'next': Ember.run.next,
- 'once': Ember.run.once,
- 'schedule': Ember.run.schedule,
- 'scheduleOnce': Ember.run.scheduleOnce,
- 'throttle': Ember.run.throttle
- },
- 'ember-service': {
- 'default': Ember.Service
- },
- 'ember-service/inject': {
- 'default': Ember.inject.service
- },
- 'ember-set/ordered': {
- 'default': Ember.OrderedSet
- },
- 'ember-string': {
- 'camelize': Ember.String.camelize,
- 'capitalize': Ember.String.capitalize,
- 'classify': Ember.String.classify,
- 'dasherize': Ember.String.dasherize,
- 'decamelize': Ember.String.decamelize,
- 'fmt': Ember.String.fmt,
- 'htmlSafe': Ember.String.htmlSafe,
- 'loc': Ember.String.loc,
- 'underscore': Ember.String.underscore,
- 'w': Ember.String.w
- },
- 'ember-utils': {
- 'isBlank': Ember.isBlank,
- 'isEmpty': Ember.isEmpty,
- 'isNone': Ember.isNone,
- 'isPresent': Ember.isPresent,
- 'tryInvoke': Ember.tryInvoke,
- 'typeOf': Ember.typeOf
- }
- };
-
- // populate `ember/computed` named exports
- shims['ember-computed'] = {
- 'default': Ember.computed
- };
- var computedMacros = [
- "empty", "notEmpty", "none", "not", "bool", "match", "equal", "gt", "gte",
- "lt", "lte", "alias", "oneWay", "reads", "readOnly", "deprecatingAlias",
- "and", "or", "collect", "sum", "min", "max", "map", "sort", "setDiff",
- "mapBy", "filter", "filterBy", "uniq", "union", "intersect"
- ];
-
- for (var i = 0, l = computedMacros.length; i < l; i++) {
- var key = computedMacros[i];
- shims['ember-computed'][key] = Ember.computed[key];
- }
-
- for (var moduleName in shims) {
- generateModule(moduleName, shims[moduleName]);
- }
- }
-
- function processTestShims() {
- if (Ember.Test) {
- var testShims = {
- 'ember-test': {
- 'default': Ember.Test
- },
- 'ember-test/adapter': {
- 'default': Ember.Test.Adapter
- },
- 'ember-test/qunit-adapter': {
- 'default': Ember.Test.QUnitAdapter
- }
- };
-
- for (var moduleName in testShims) {
- generateModule(moduleName, testShims[moduleName]);
- }
- }
- }
-
- function generateModule(name, values) {
- define(name, [], function() {
- 'use strict';
-
- return values;
- });
- }
-
- processEmberShims();
- processTestShims();
- generateModule('jquery', { 'default': self.jQuery });
- generateModule('rsvp', { 'default': Ember.RSVP });
-})();
| false |
Other
|
emberjs
|
ember.js
|
d354a728c4dde56c7d91d74b41cd8e5b6eb72571.json
|
Improve error message when calling `inject()`.
Fixes #15904
|
packages/ember-runtime/lib/inject.js
|
@@ -10,7 +10,10 @@ import { assert } from 'ember-debug';
@public
*/
export default function inject() {
- assert(`Injected properties must be created through helpers, see '${Object.keys(inject).join('"', '"')}'`);
+ const helpers = Object.keys(inject)
+ .map(k => `'inject.${k}'`)
+ .join(' or ');
+ assert(`Injected properties must be created through helpers, see '${helpers}'`);
}
// Dictionary of injection validations by type, added to by `createInjectionHelper`
| false |
Other
|
emberjs
|
ember.js
|
f156c0d2c1f7273c31ad30b35e1ea7814732577d.json
|
Remove currentWhen property from link-to component
|
packages/ember-glimmer/lib/components/link-to.ts
|
@@ -350,13 +350,6 @@ const LinkComponent = EmberComponent.extend({
tagName: 'a',
- /**
- @deprecated Use current-when instead.
- @property currentWhen
- @private
- */
- currentWhen: deprecatingAlias('current-when', { id: 'ember-routing-view.deprecated-current-when', until: '3.0.0' }),
-
/**
Used to determine when this `LinkComponent` is active.
| true |
Other
|
emberjs
|
ember.js
|
f156c0d2c1f7273c31ad30b35e1ea7814732577d.json
|
Remove currentWhen property from link-to component
|
packages/ember-glimmer/tests/integration/components/link-to-test.js
|
@@ -15,26 +15,6 @@ moduleFor('Link-to component', class extends ApplicationTest {
return p;
}
- ['@test accessing `currentWhen` triggers a deprecation'](assert) {
- let component;
- this.addComponent('link-to', {
- ComponentClass: LinkComponent.extend({
- init() {
- this._super(...arguments);
- component = this;
- }
- })
- });
-
- this.addTemplate('application', `{{link-to 'Index' 'index'}}`);
-
- return this.visit('/').then(() => {
- expectDeprecation(() => {
- component.get('currentWhen');
- }, /Usage of `currentWhen` is deprecated, use `current-when` instead/);
- });
- }
-
['@test should be able to be inserted in DOM when the router is not present']() {
this.addTemplate('application', `{{#link-to 'index'}}Go to Index{{/link-to}}`);
| true |
Other
|
emberjs
|
ember.js
|
f156c0d2c1f7273c31ad30b35e1ea7814732577d.json
|
Remove currentWhen property from link-to component
|
packages/ember/tests/helpers/link_to_test.js
|
@@ -417,26 +417,6 @@ moduleFor('The {{link-to}} helper - nested routes and link-to arguments', class
assert.equal(normalizeUrl(this.$('#item a').attr('href')), '/about');
}
- ['@test The {{link-to}} helper supports currentWhen (DEPRECATED)'](assert) {
- expectDeprecation('Usage of `currentWhen` is deprecated, use `current-when` instead.');
-
- this.router.map(function() {
- this.route('index', { path: '/' }, function() {
- this.route('about');
- });
- this.route('item');
- });
-
- this.addTemplate('index', `<h3>Home</h3>{{outlet}}`);
- this.addTemplate('index.about', `
- {{#link-to 'item' id='other-link' currentWhen='index'}}ITEM{{/link-to}}
- `);
-
- this.visit('/about');
-
- assert.equal(this.$('#other-link.active').length, 1, 'The link is active since current-when is a parent route');
- }
-
[`@test The {{link-to}} helper supports custom, nested, current-when`](assert) {
this.router.map(function() {
this.route('index', { path: '/' }, function() {
| true |
Other
|
emberjs
|
ember.js
|
a0245da171c19ee7987ae0be2cf0369f79241da1.json
|
Emit valid test counts after each test run.
Both in browser and in CI runs.
|
bin/run-tests.js
|
@@ -59,6 +59,9 @@ function runInBrowser(url, retries, resolve, reject) {
var addLogging = function() {
window.document.addEventListener('DOMContentLoaded', function() {
+ var testsTotal = 0;
+ var testsPassed = 0;
+ var testsFailed = 0;
var currentTestAssertions = [];
QUnit.log(function (details) {
@@ -96,19 +99,24 @@ function runInBrowser(url, retries, resolve, reject) {
}
name += result.name;
+ testsTotal++;
+
if (result.failed) {
+ testsFailed++;
console.log('\n' + 'Test failed: ' + name);
for (i = 0, len = currentTestAssertions.length; i < len; i++) {
console.log(' ' + currentTestAssertions[i]);
}
+ } else {
+ testsPassed++;
}
currentTestAssertions.length = 0;
});
QUnit.done(function (result) {
- console.log('\n' + 'Took ' + result.runtime + 'ms to run ' + result.total + ' tests. ' + result.passed + ' passed, ' + result.failed + ' failed.');
+ console.log('\n' + 'Took ' + result.runtime + 'ms to run ' + testsTotal + ' tests. ' + testsPassed + ' passed, ' + testsFailed + ' failed.');
if (typeof window.callPhantom === 'function') {
window.callPhantom({
| true |
Other
|
emberjs
|
ember.js
|
a0245da171c19ee7987ae0be2cf0369f79241da1.json
|
Emit valid test counts after each test run.
Both in browser and in CI runs.
|
tests/index.html
|
@@ -172,11 +172,29 @@
QUnit.config.reorder = false;
}
+ var testsTotal, testsPassed, testsFailed;
+
QUnit.begin(function() {
+ testsTotal = testsPassed = testsFailed = 0;
+
if (QUnit.urlParams.hideskipped) {
$('#qunit-tests').addClass('hideskipped');
}
});
+
+ QUnit.testDone(function(results) {
+ testsTotal++;
+
+ if (results.failed) {
+ testsFailed++;
+ } else {
+ testsPassed++;
+ }
+ });
+
+ QUnit.done(function(result) {
+ console.log('\n' + 'Took ' + result.runtime + 'ms to run ' + testsTotal + ' tests. ' + testsPassed + ' passed, ' + testsFailed + ' failed.');
+ });
})();
</script>
| true |
Other
|
emberjs
|
ember.js
|
a92a7cd003f7202a397aef2bbe95397ffe483034.json
|
Simplify `console` event handler.
Prior to this change, the only content emitted was `[Object object]`
(this is due to how puppeteer provides the argument to
`page.on('console', ...)`).
|
bin/run-tests.js
|
@@ -40,20 +40,10 @@ function runInBrowser(url, retries, resolve, reject) {
puppeteer.launch().then(function(browser) {
browser.newPage().then(function(page) {
- page.on('console', function() {
+ page.on('console', function(msg) {
+ console.log(msg.text);
- var string = Array.prototype.slice.call(arguments).join('');
- var lines = string.split('\n');
-
- lines.forEach(function(line) {
- if (line.indexOf('0 failed.') > -1) {
- console.log(chalk.green(line));
- } else {
- console.log(line);
- }
- });
-
- result.output.push(string);
+ result.output.push(msg.text);
});
page.on('error', function(err) {
| false |
Other
|
emberjs
|
ember.js
|
92b459ca954fe395247a029375b4bd31572a4b83.json
|
Remove `chrome` from `testem.travis-browsers.json`
Chrome is now the default browser used, no need to test it _again_...
|
bin/run-travis-browser-tests.js
|
@@ -35,23 +35,7 @@ function run(command, _args) {
}
-function setupChrome() {
- return RSVP.resolve()
- .then(function() {
- return run('sudo', ['apt-get', 'install', '-y', 'google-chrome-stable']);
- })
- .then(function() {
- return run('/usr/bin/google-chrome', ['--version']);
- });
-}
-
RSVP.resolve()
- .then(function() {
- return run('sudo', ['apt-get', 'update']);
- })
- .then(function() {
- return setupChrome();
- })
.then(function() {
return run('./node_modules/.bin/testem', ['launchers']);
})
| true |
Other
|
emberjs
|
ember.js
|
92b459ca954fe395247a029375b4bd31572a4b83.json
|
Remove `chrome` from `testem.travis-browsers.json`
Chrome is now the default browser used, no need to test it _again_...
|
testem.travis-browsers.js
|
@@ -29,11 +29,9 @@ module.exports = {
disable_watching: true,
launch_in_dev: [
'Firefox',
- 'Chrome'
],
launch_in_ci: [
'Firefox',
- 'Chrome'
],
reporter: new FailureOnlyReporter()
};
| true |
Other
|
emberjs
|
ember.js
|
0a5388b28ba81139fec663c792dd062451c08776.json
|
Remove phantomjs infrastructure.
|
.travis.yml
|
@@ -14,7 +14,6 @@ cache:
before_install:
- |
- phantomjs --version
export DISPLAY=:99.0
sh -e /etc/init.d/xvfb start
| true |
Other
|
emberjs
|
ember.js
|
0a5388b28ba81139fec663c792dd062451c08776.json
|
Remove phantomjs infrastructure.
|
bin/run-tests.js
|
@@ -28,7 +28,6 @@ function run(queryString) {
return new RSVP.Promise(function(resolve, reject) {
var url = 'http://localhost:' + PORT + '/tests/?' + queryString;
runInBrowser(url, 3, resolve, reject);
- //runInPhantom(url, 3, resolve, reject);
});
}
@@ -171,62 +170,6 @@ function runInBrowser(url, retries, resolve, reject) {
})
}
-function runInPhantom(url, retries, resolve, reject) {
- var args = [require.resolve('qunit-phantomjs-runner'), url, '900'];
-
- console.log('Running: phantomjs ' + args.join(' '));
-
- var crashed = false;
- var child = spawn('phantomjs', args);
- var result = {output: [], errors: [], code: null};
-
- child.stdout.on('data', function (data) {
- var string = data.toString();
- var lines = string.split('\n');
-
- lines.forEach(function(line) {
- if (line.indexOf('0 failed.') > -1) {
- console.log(chalk.green(line));
- } else {
- console.log(line);
- }
- });
- result.output.push(string);
- });
-
- child.stderr.on('data', function (data) {
- var string = data.toString();
-
- if (string.indexOf('PhantomJS has crashed.') > -1) {
- crashed = true;
- }
-
- result.errors.push(string);
- console.error(chalk.red(string));
- });
-
- child.on('close', function (code) {
- result.code = code;
-
- if (!crashed && code === 0) {
- resolve(result);
- } else if (crashed) {
- console.log(chalk.red('Phantom crashed with exit code ' + code));
-
- if (retries > 1) {
- console.log(chalk.yellow('Retrying... ¯\_(ツ)_/¯'));
- runInPhantom(url, retries - 1, resolve, reject);
- } else {
- console.log(chalk.red('Giving up! (╯°□°)╯︵ ┻━┻'));
- console.log(chalk.yellow('This might be a known issue with PhantomJS 1.9.8, skipping for now'));
- resolve(result);
- }
- } else {
- reject(result);
- }
- });
-}
-
var testFunctions = [];
function generateEachPackageTests() {
| true |
Other
|
emberjs
|
ember.js
|
0a5388b28ba81139fec663c792dd062451c08776.json
|
Remove phantomjs infrastructure.
|
package.json
|
@@ -112,7 +112,6 @@
"mocha": "^2.4.5",
"puppeteer": "^0.13.0",
"qunit-extras": "^1.5.0",
- "qunit-phantomjs-runner": "^2.2.0",
"qunitjs": "^1.22.0",
"route-recognizer": "^0.3.3",
"router_js": "^2.0.0-beta.1",
| true |
Other
|
emberjs
|
ember.js
|
0a5388b28ba81139fec663c792dd062451c08776.json
|
Remove phantomjs infrastructure.
|
testem.dist.json
|
@@ -38,7 +38,7 @@
"protocol": "tap"
}
},
- "launch_in_dev": ["PhantomJS"],
+ "launch_in_dev": [],
"launch_in_ci": [
"SL_Safari_Current",
"SL_MS_Edge",
| true |
Other
|
emberjs
|
ember.js
|
0a5388b28ba81139fec663c792dd062451c08776.json
|
Remove phantomjs infrastructure.
|
testem.json
|
@@ -4,5 +4,5 @@
"timeout": 540,
"parallel": 4,
"disable_watching": true,
- "launch_in_dev": ["PhantomJS"]
+ "launch_in_dev": []
}
| true |
Other
|
emberjs
|
ember.js
|
0a5388b28ba81139fec663c792dd062451c08776.json
|
Remove phantomjs infrastructure.
|
yarn.lock
|
@@ -5046,16 +5046,6 @@ qunit-extras@^1.5.0:
version "1.5.0"
resolved "https://registry.yarnpkg.com/qunit-extras/-/qunit-extras-1.5.0.tgz#a64d1c5088ab20c01c0e1b04c72132c397b3964c"
-qunit-phantomjs-runner@^2.2.0:
- version "2.3.0"
- resolved "https://registry.yarnpkg.com/qunit-phantomjs-runner/-/qunit-phantomjs-runner-2.3.0.tgz#270acb197c0f2fcaaf06676ab0a48fd5aca66a99"
- dependencies:
- qunit-reporter-junit "^1.0.2"
-
-qunit-reporter-junit@^1.0.2:
- version "1.1.1"
- resolved "https://registry.yarnpkg.com/qunit-reporter-junit/-/qunit-reporter-junit-1.1.1.tgz#eeb6226457896993e795a11940f18af6afa579b4"
-
qunitjs@^1.22.0:
version "1.23.1"
resolved "https://registry.yarnpkg.com/qunitjs/-/qunitjs-1.23.1.tgz#1971cf97ac9be01a64d2315508d2e48e6fd4e719"
| true |
Other
|
emberjs
|
ember.js
|
66e14cf65a909dfb415495006a25e3e4f5a761d8.json
|
Run tests with Chrome headless
TL;DR: Drop-in code replacement for Phantom with Chrome headless.
The Google Chrome team came out with a slick JavaScript client library
called [puppeteer](https://github.com/googlechrome/puppeteer) to control
Chrome headless. This is a fairly (IMHO) straightforward port from
running QUnit tests through Phantom to instead using Chrome headless.
The functions are almost identical with the exceptions of how to
actually boot/load up the browser and page, and also the logging code
in-line.
There are a few TODOs (things before this PR is merged) and Future
Improvements (things likely out of scope for this PR) that I was able to
come up with, though I'm sure I may have missed a few things:
TODOs:
- Extract out the `addLogging` function to a package similar to `qunit-phantomjs-runner` (`qunit-chrome-runner`?): right now copy and pasting the code from the Phantom runner works, but this isn't sustainable. Not sure if the Ember core team wants to maintain a small package like this, or who will own it.
- Make sure testem is okay with removal of PhantomJS: there are a bunch of config files where Phantom is mentioned, those need to be looked at
- Figure out when to remove Phantom completely from `bin` scripts: my initial thought was to run tests through both phantom and Chrome headless for a little while to make sure nothing was loudly failing, but I'll love feedback from reviewers about that
Future Improvements:
- Eventually remove all PhantomJS code from `bin` scripts
- Remove `REDEFINE_SUPPORTED` / `handleBrokenPhantomDefineProperty` from [ember-metal](https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/properties.js)
- Find a way to more responsibly handle browsers: I tried to setup some `browser.close()` calls to better manage the current situation, but things got messy quickly. I think this is outside of the scope of just getting this running in the first place.
- Once Chrome headless hits stable release, add it as a Travis addon: currently the puppeteer npm package ships with a copy of the Chrome canary web browser, and it isn't necessary to install Chrome again
- Finish migrating all Ember projects off of Phantom: ember-cli has already done the migration, not sure what other repos still need attention
|
bin/run-tests.js
|
@@ -27,10 +27,150 @@ server.listen(PORT);
function run(queryString) {
return new RSVP.Promise(function(resolve, reject) {
var url = 'http://localhost:' + PORT + '/tests/?' + queryString;
- runInPhantom(url, 3, resolve, reject);
+ runInBrowser(url, 3, resolve, reject);
+ //runInPhantom(url, 3, resolve, reject);
});
}
+function runInBrowser(url, retries, resolve, reject) {
+ var result = {output: [], errors: [], code: null};
+
+ console.log('Running Chrome headless: ' + url);
+
+ var puppeteer = require('puppeteer');
+
+ puppeteer.launch().then(function(browser) {
+ browser.newPage().then(function(page) {
+ page.on('console', function() {
+
+ var string = Array.prototype.slice.call(arguments).join('');
+ var lines = string.split('\n');
+
+ lines.forEach(function(line) {
+ if (line.indexOf('0 failed.') > -1) {
+ console.log(chalk.green(line));
+ } else {
+ console.log(line);
+ }
+ });
+
+ result.output.push(string);
+ });
+
+ page.on('error', function(err) {
+ var string = err.toString();
+
+ if (string.indexOf('Chrome headless has crashed.') > -1) {
+ crashed = true;
+ }
+
+ result.errors.push(string);
+ console.error(chalk.red(string));
+ });
+
+ var addLogging = function() {
+ window.document.addEventListener('DOMContentLoaded', function() {
+ var currentTestAssertions = [];
+
+ QUnit.log(function (details) {
+ var response;
+
+ // Ignore passing assertions
+ if (details.result) {
+ return;
+ }
+
+ response = details.message || '';
+
+ if (typeof details.expected !== 'undefined') {
+ if (response) {
+ response += ', ';
+ }
+
+ response += 'expected: ' + details.expected + ', but was: ' + details.actual;
+ }
+
+ if (details.source) {
+ response += '\n' + details.source;
+ }
+
+ currentTestAssertions.push('Failed assertion: ' + response);
+ });
+
+ QUnit.testDone(function (result) {
+ var i,
+ len,
+ name = '';
+
+ if (result.module) {
+ name += result.module + ': ';
+ }
+ name += result.name;
+
+ if (result.failed) {
+ console.log('\n' + 'Test failed: ' + name);
+
+ for (i = 0, len = currentTestAssertions.length; i < len; i++) {
+ console.log(' ' + currentTestAssertions[i]);
+ }
+ }
+
+ currentTestAssertions.length = 0;
+ });
+
+ QUnit.done(function (result) {
+ console.log('\n' + 'Took ' + result.runtime + 'ms to run ' + result.total + ' tests. ' + result.passed + ' passed, ' + result.failed + ' failed.');
+
+ if (typeof window.callPhantom === 'function') {
+ window.callPhantom({
+ 'name': 'QUnit.done',
+ 'data': result
+ });
+ }
+ });
+ });
+ };
+
+ page.exposeFunction('callPhantom', function(message) {
+ if (message && message.name === 'QUnit.done') {
+ result = message.data;
+ failed = !result || !result.total || result.failed;
+
+ if (!result.total) {
+ console.error('No tests were executed. Are you loading tests asynchronously?');
+ }
+
+ var code = failed ? 1 : 0;
+ var crashed = false;
+
+ result.code = code;
+
+ if (!crashed && code === 0) {
+ resolve(result);
+ } else if (crashed) {
+ console.log(chalk.red('Browser crashed with exit code ' + code));
+
+ if (retries > 1) {
+ console.log(chalk.yellow('Retrying... ¯\_(ツ)_/¯'));
+ runInBrowser(url, retries - 1, resolve, reject);
+ } else {
+ console.log(chalk.red('Giving up! (╯°□°)╯︵ ┻━┻'));
+ console.log(chalk.yellow('This might be a known issue with Chrome headless, skipping for now'));
+ resolve(result);
+ }
+ } else {
+ reject(result);
+ }
+ }
+ });
+
+ page.evaluateOnNewDocument(addLogging);
+
+ page.goto(url, { timeout: 900 });
+ });
+ })
+}
+
function runInPhantom(url, retries, resolve, reject) {
var args = [require.resolve('qunit-phantomjs-runner'), url, '900'];
| true |
Other
|
emberjs
|
ember.js
|
66e14cf65a909dfb415495006a25e3e4f5a761d8.json
|
Run tests with Chrome headless
TL;DR: Drop-in code replacement for Phantom with Chrome headless.
The Google Chrome team came out with a slick JavaScript client library
called [puppeteer](https://github.com/googlechrome/puppeteer) to control
Chrome headless. This is a fairly (IMHO) straightforward port from
running QUnit tests through Phantom to instead using Chrome headless.
The functions are almost identical with the exceptions of how to
actually boot/load up the browser and page, and also the logging code
in-line.
There are a few TODOs (things before this PR is merged) and Future
Improvements (things likely out of scope for this PR) that I was able to
come up with, though I'm sure I may have missed a few things:
TODOs:
- Extract out the `addLogging` function to a package similar to `qunit-phantomjs-runner` (`qunit-chrome-runner`?): right now copy and pasting the code from the Phantom runner works, but this isn't sustainable. Not sure if the Ember core team wants to maintain a small package like this, or who will own it.
- Make sure testem is okay with removal of PhantomJS: there are a bunch of config files where Phantom is mentioned, those need to be looked at
- Figure out when to remove Phantom completely from `bin` scripts: my initial thought was to run tests through both phantom and Chrome headless for a little while to make sure nothing was loudly failing, but I'll love feedback from reviewers about that
Future Improvements:
- Eventually remove all PhantomJS code from `bin` scripts
- Remove `REDEFINE_SUPPORTED` / `handleBrokenPhantomDefineProperty` from [ember-metal](https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/properties.js)
- Find a way to more responsibly handle browsers: I tried to setup some `browser.close()` calls to better manage the current situation, but things got messy quickly. I think this is outside of the scope of just getting this running in the first place.
- Once Chrome headless hits stable release, add it as a Travis addon: currently the puppeteer npm package ships with a copy of the Chrome canary web browser, and it isn't necessary to install Chrome again
- Finish migrating all Ember projects off of Phantom: ember-cli has already done the migration, not sure what other repos still need attention
|
package.json
|
@@ -110,6 +110,7 @@
"html-differ": "^1.3.4",
"lodash.uniq": "^4.5.0",
"mocha": "^2.4.5",
+ "puppeteer": "^0.9.0",
"qunit-extras": "^1.5.0",
"qunit-phantomjs-runner": "^2.2.0",
"qunitjs": "^1.22.0",
| true |
Other
|
emberjs
|
ember.js
|
66e14cf65a909dfb415495006a25e3e4f5a761d8.json
|
Run tests with Chrome headless
TL;DR: Drop-in code replacement for Phantom with Chrome headless.
The Google Chrome team came out with a slick JavaScript client library
called [puppeteer](https://github.com/googlechrome/puppeteer) to control
Chrome headless. This is a fairly (IMHO) straightforward port from
running QUnit tests through Phantom to instead using Chrome headless.
The functions are almost identical with the exceptions of how to
actually boot/load up the browser and page, and also the logging code
in-line.
There are a few TODOs (things before this PR is merged) and Future
Improvements (things likely out of scope for this PR) that I was able to
come up with, though I'm sure I may have missed a few things:
TODOs:
- Extract out the `addLogging` function to a package similar to `qunit-phantomjs-runner` (`qunit-chrome-runner`?): right now copy and pasting the code from the Phantom runner works, but this isn't sustainable. Not sure if the Ember core team wants to maintain a small package like this, or who will own it.
- Make sure testem is okay with removal of PhantomJS: there are a bunch of config files where Phantom is mentioned, those need to be looked at
- Figure out when to remove Phantom completely from `bin` scripts: my initial thought was to run tests through both phantom and Chrome headless for a little while to make sure nothing was loudly failing, but I'll love feedback from reviewers about that
Future Improvements:
- Eventually remove all PhantomJS code from `bin` scripts
- Remove `REDEFINE_SUPPORTED` / `handleBrokenPhantomDefineProperty` from [ember-metal](https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/properties.js)
- Find a way to more responsibly handle browsers: I tried to setup some `browser.close()` calls to better manage the current situation, but things got messy quickly. I think this is outside of the scope of just getting this running in the first place.
- Once Chrome headless hits stable release, add it as a Travis addon: currently the puppeteer npm package ships with a copy of the Chrome canary web browser, and it isn't necessary to install Chrome again
- Finish migrating all Ember projects off of Phantom: ember-cli has already done the migration, not sure what other repos still need attention
|
yarn.lock
|
@@ -1775,7 +1775,7 @@ [email protected]:
version "0.0.1"
resolved "https://registry.yarnpkg.com/concat-map/-/concat-map-0.0.1.tgz#d8a96bd77fd68df7793a73036a3ba0d5405d477b"
-concat-stream@^1.4.7, concat-stream@^1.5.2:
[email protected], concat-stream@^1.4.7, concat-stream@^1.5.2:
version "1.6.0"
resolved "https://registry.yarnpkg.com/concat-stream/-/concat-stream-1.6.0.tgz#0aac662fd52be78964d5532f694784e70110acf7"
dependencies:
@@ -1919,9 +1919,9 @@ dashdash@^1.12.0:
dependencies:
assert-plus "^1.0.0"
-debug@2, [email protected], debug@^2.1.3, debug@~2.6.7:
- version "2.6.9"
- resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.9.tgz#5d128515df134ff327e90a4c93f4e077a536341f"
+debug@2, [email protected], debug@^2.1.0, debug@^2.1.1, debug@^2.1.3, debug@^2.2.0, debug@^2.4.0, debug@^2.6.8, debug@~2.6.7:
+ version "2.6.8"
+ resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.8.tgz#e731531ca2ede27d188222427da17821d68ff4fc"
dependencies:
ms "2.0.0"
@@ -1943,9 +1943,9 @@ [email protected]:
dependencies:
ms "2.0.0"
[email protected], debug@^2.1.0, debug@^2.1.1, debug@^2.2.0, debug@^2.4.0:
- version "2.6.8"
- resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.8.tgz#e731531ca2ede27d188222427da17821d68ff4fc"
[email protected]:
+ version "2.6.9"
+ resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.9.tgz#5d128515df134ff327e90a4c93f4e077a536341f"
dependencies:
ms "2.0.0"
@@ -2764,6 +2764,15 @@ extglob@^0.3.1:
dependencies:
is-extglob "^1.0.0"
+extract-zip@^1.6.5:
+ version "1.6.5"
+ resolved "https://registry.yarnpkg.com/extract-zip/-/extract-zip-1.6.5.tgz#99a06735b6ea20ea9b705d779acffcc87cff0440"
+ dependencies:
+ concat-stream "1.6.0"
+ debug "2.2.0"
+ mkdirp "0.5.0"
+ yauzl "2.4.1"
+
[email protected]:
version "1.0.2"
resolved "https://registry.yarnpkg.com/extsprintf/-/extsprintf-1.0.2.tgz#e1080e0658e300b06294990cc70e1502235fd550"
@@ -2803,6 +2812,12 @@ fb-watchman@^2.0.0:
dependencies:
bser "^2.0.0"
+fd-slicer@~1.0.1:
+ version "1.0.1"
+ resolved "https://registry.yarnpkg.com/fd-slicer/-/fd-slicer-1.0.1.tgz#8b5bcbd9ec327c5041bf9ab023fd6750f1177e65"
+ dependencies:
+ pend "~1.2.0"
+
figures@^1.3.5:
version "1.7.0"
resolved "https://registry.yarnpkg.com/figures/-/figures-1.7.0.tgz#cbe1e3affcf1cd44b80cadfed28dc793a9701d2e"
@@ -4320,7 +4335,7 @@ [email protected]:
version "1.3.4"
resolved "https://registry.yarnpkg.com/mime/-/mime-1.3.4.tgz#115f9e3b6b3daf2959983cb38f149a2d40eb5d53"
-mime@^1.2.11:
+mime@^1.2.11, mime@^1.3.4:
version "1.3.6"
resolved "https://registry.yarnpkg.com/mime/-/mime-1.3.6.tgz#591d84d3653a6b0b4a3b9df8de5aa8108e72e5e0"
@@ -4366,6 +4381,12 @@ [email protected]:
version "0.3.0"
resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-0.3.0.tgz#1bbf5ab1ba827af23575143490426455f481fe1e"
[email protected]:
+ version "0.5.0"
+ resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-0.5.0.tgz#1d73076a6df986cd9344e15e71fcc05a4c9abf12"
+ dependencies:
+ minimist "0.0.8"
+
[email protected], [email protected], "mkdirp@>=0.5 0", mkdirp@^0.5.0, mkdirp@^0.5.1, mkdirp@~0.5.0, mkdirp@~0.5.1:
version "0.5.1"
resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-0.5.1.tgz#30057438eac6cf7f8c4767f38648d6697d75c903"
@@ -4842,6 +4863,10 @@ [email protected]:
version "0.1.7"
resolved "https://registry.yarnpkg.com/path-to-regexp/-/path-to-regexp-0.1.7.tgz#df604178005f522f15eb4490e7247a1bfaa67f8c"
+pend@~1.2.0:
+ version "1.2.0"
+ resolved "https://registry.yarnpkg.com/pend/-/pend-1.2.0.tgz#7a57eb550a6783f9115331fcf4663d5c8e007a50"
+
performance-now@^0.2.0:
version "0.2.0"
resolved "https://registry.yarnpkg.com/performance-now/-/performance-now-0.2.0.tgz#33ef30c5c77d4ea21c5a53869d91b56d8f2555e5"
@@ -4902,6 +4927,10 @@ progress@^1.1.8:
version "1.1.8"
resolved "https://registry.yarnpkg.com/progress/-/progress-1.1.8.tgz#e260c78f6161cdd9b0e56cc3e0a85de17c7a57be"
+progress@^2.0.0:
+ version "2.0.0"
+ resolved "https://registry.yarnpkg.com/progress/-/progress-2.0.0.tgz#8a1be366bf8fc23db2bd23f10c6fe920b4389d1f"
+
promise-map-series@^0.2.1:
version "0.2.3"
resolved "https://registry.yarnpkg.com/promise-map-series/-/promise-map-series-0.2.3.tgz#c2d377afc93253f6bd03dbb77755eb88ab20a847"
@@ -4937,6 +4966,17 @@ punycode@^1.4.1:
version "1.4.1"
resolved "https://registry.yarnpkg.com/punycode/-/punycode-1.4.1.tgz#c0d5a63b2718800ad8e1eb0fa5269c84dd41845e"
+puppeteer@^0.9.0:
+ version "0.9.0"
+ resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-0.9.0.tgz#d65997ff83e24eb569e5577d2f75695dcbe5be4a"
+ dependencies:
+ debug "^2.6.8"
+ extract-zip "^1.6.5"
+ mime "^1.3.4"
+ progress "^2.0.0"
+ rimraf "^2.6.1"
+ ws "^3.0.0"
+
[email protected], q@^1.1.2:
version "1.4.1"
resolved "https://registry.yarnpkg.com/q/-/q-1.4.1.tgz#55705bcd93c5f3673530c2c2cbc0c2b3addc286e"
@@ -6146,6 +6186,10 @@ [email protected]:
version "1.0.2"
resolved "https://registry.yarnpkg.com/ultron/-/ultron-1.0.2.tgz#ace116ab557cd197386a4e88f4685378c8b2e4fa"
+ultron@~1.1.0:
+ version "1.1.0"
+ resolved "https://registry.yarnpkg.com/ultron/-/ultron-1.1.0.tgz#b07a2e6a541a815fc6a34ccd4533baec307ca864"
+
umask@~1.1.0:
version "1.1.0"
resolved "https://registry.yarnpkg.com/umask/-/umask-1.1.0.tgz#f29cebf01df517912bb58ff9c4e50fde8e33320d"
@@ -6409,6 +6453,13 @@ [email protected]:
options ">=0.0.5"
ultron "1.0.x"
+ws@^3.0.0:
+ version "3.1.0"
+ resolved "https://registry.yarnpkg.com/ws/-/ws-3.1.0.tgz#8afafecdeab46d572e5397ee880739367aa2f41c"
+ dependencies:
+ safe-buffer "~5.1.0"
+ ultron "~1.1.0"
+
[email protected]:
version "1.0.0"
resolved "https://registry.yarnpkg.com/wtf-8/-/wtf-8-1.0.0.tgz#392d8ba2d0f1c34d1ee2d630f15d0efb68e1048a"
@@ -6479,6 +6530,12 @@ yargs@~3.27.0:
window-size "^0.1.2"
y18n "^3.2.0"
[email protected]:
+ version "2.4.1"
+ resolved "https://registry.yarnpkg.com/yauzl/-/yauzl-2.4.1.tgz#9528f442dab1b2284e58b4379bb194e22e0c4005"
+ dependencies:
+ fd-slicer "~1.0.1"
+
[email protected]:
version "0.1.2"
resolved "https://registry.yarnpkg.com/yeast/-/yeast-0.1.2.tgz#008e06d8094320c372dbc2f8ed76a0ca6c8ac419"
| true |
Other
|
emberjs
|
ember.js
|
39b18554c7cd59853cfb1f14e1e0c21113881310.json
|
Add v2.18.0-beta.1 to CHANGELOG.
[ci skip]
|
CHANGELOG.md
|
@@ -1,5 +1,10 @@
# Ember Changelog
+### 2.18.0-beta.1 (November 29, 2017)
+
+- [#14590](https://github.com/emberjs/ember.js/pull/14590) [DEPRECATION] Deprecate using `targetObject`.
+- [#15754](https://github.com/emberjs/ember.js/pull/15754) [CLEANUP] Remove `router.router` deprecation.
+
### 2.17.0 (November 29, 2017)
- [#15855](https://github.com/emberjs/ember.js/pull/15855) [BUGFIX] fix regression with computed `filter/map/sort`
| false |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/assert-input-helper-without-block.js
|
@@ -7,7 +7,7 @@ export default function errorOnInputWithContent(env) {
return {
name: 'assert-input-helper-without-block',
- visitors: {
+ visitor: {
BlockStatement(node) {
if (node.path.original !== 'input') { return; }
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/assert-reserved-named-arguments.js
|
@@ -7,7 +7,7 @@ export default function assertReservedNamedArguments(env) {
return {
name: 'assert-reserved-named-arguments',
- visitors: {
+ visitor: {
PathExpression(node) {
if (node.original[0] === '@') {
assert(assertMessage(moduleName, node));
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/deprecate-render-model.js
|
@@ -8,7 +8,7 @@ export default function deprecateRenderModel(env) {
return {
name: 'deprecate-render-model',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (node.path.original === 'render' && node.params.length > 1) {
node.params.forEach(param => {
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/deprecate-render.js
|
@@ -7,7 +7,7 @@ export default function deprecateRender(env) {
return {
name: 'deprecate-render',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (node.path.original !== 'render') { return; }
if (node.params.length !== 1) { return; }
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/extract-pragma-tag.js
|
@@ -6,7 +6,7 @@ export default function extractPragmaTag(env) {
return {
name: 'exract-pragma-tag',
- visitors: {
+ visitor: {
MustacheStatement: {
enter(node) {
if (node.path.type === 'PathExpression' && node.path.original === PRAGMA_TAG) {
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-action-syntax.js
|
@@ -29,7 +29,7 @@ export default function transformActionSyntax({ syntax }) {
return {
name: 'transform-action-syntax',
- visitors: {
+ visitor: {
ElementModifierStatement(node) {
if (isAction(node)) {
insertThisAsFirstParam(node, b);
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-angle-bracket-components.js
|
@@ -2,7 +2,7 @@ export default function transformAngleBracketComponents(env) {
return {
name: 'transform-angle-bracket-components',
- visitors: {
+ visitor: {
ComponentNode(node) {
node.tag = `<${node.tag}>`;
}
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-attrs-into-args.js
|
@@ -30,7 +30,7 @@ export default function transformAttrsIntoArgs(env) {
return {
name: 'transform-attrs-into-args',
- visitors: {
+ visitor: {
Program: {
enter(node) {
let parent = stack[stack.length - 1];
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-dot-component-invocation.js
|
@@ -58,7 +58,7 @@ export default function transformDotComponentInvocation(env) {
return {
name: 'transform-dot-component-invocation',
- visitors: {
+ visitor: {
MustacheStatement: (node) => {
if (isInlineInvocation(node.path, node.params, node.hash)) {
wrapInComponent(node, b);
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-each-in-into-each.js
|
@@ -24,7 +24,7 @@ export default function transformEachInIntoEach(env) {
return {
name: 'transform-each-in-into-each',
- visitors: {
+ visitor: {
BlockStatement(node) {
if (node.path.original === 'each-in') {
node.params[0] = b.sexpr(b.path('-each-in'), [node.params[0]]);
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-has-block-syntax.js
|
@@ -30,7 +30,7 @@ export default function transformHasBlockSyntax(env) {
return {
name: 'transform-has-block-syntax',
- visitors: {
+ visitor: {
PathExpression(node) {
if (TRANSFORMATIONS[node.original]) {
return b.sexpr(b.path(TRANSFORMATIONS[node.original]));
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-inline-link-to.js
|
@@ -26,7 +26,7 @@ export default function transformInlineLinkTo(env) {
return {
name: 'transform-inline-link-to',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (node.path.original === 'link-to') {
let content = node.escaped ? node.params[0] : unsafeHtml(b, node.params[0]);
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-input-on-to-onEvent.js
|
@@ -30,7 +30,7 @@ export default function transformInputOnToOnEvent(env) {
return {
name: 'transform-input-on-to-onEvent',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (node.path.original !== 'input') {
return;
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-input-type-syntax.js
|
@@ -29,7 +29,7 @@ export default function transformInputTypeSyntax(env) {
return {
name: 'transform-input-type-syntax',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (isInput(node)) {
insertTypeHelperParameter(node, b);
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-old-binding-syntax.js
|
@@ -8,7 +8,7 @@ export default function transformOldBindingSyntax(env) {
return {
name: 'transform-old-binding-syntax',
- visitors: {
+ visitor: {
BlockStatement(node) {
processHash(b, node, moduleName);
},
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-old-class-binding-syntax.js
|
@@ -4,7 +4,7 @@ export default function transformOldClassBindingSyntax(env) {
return {
name: 'transform-old-class-binding-syntax',
- visitors: {
+ visitor: {
MustacheStatement(node) {
process(b, node);
},
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-quoted-bindings-into-just-bindings.js
|
@@ -3,7 +3,7 @@ export default function transformQuotedBindingsIntoJustBindings(env) {
return {
name: 'transform-quoted-bindings-into-just-bindings',
- visitors: {
+ visitor: {
ElementNode(node) {
let styleAttr = getStyleAttr(node);
| true |
Other
|
emberjs
|
ember.js
|
1d554114a323064be740a27a28a598bbac6f4a9b.json
|
fix AST plugins
|
packages/ember-template-compiler/lib/plugins/transform-top-level-components.js
|
@@ -2,7 +2,7 @@ export default function transformTopLevelComponent(env) {
return {
name: 'transform-top-level-component',
- visitors: {
+ visitor: {
Program(node) {
hasSingleComponentNode(node, component => {
component.tag = `@${component.tag}`;
| true |
Other
|
emberjs
|
ember.js
|
aaada07db8c4f2d6242c4954c732da59ceadf80e.json
|
WIP: Start getDynamicLayout and compileTemplate
|
packages/ember-glimmer/lib/component-managers/curly.ts
|
@@ -4,6 +4,7 @@ import {
Simple,
VMHandle
} from '@glimmer/interfaces';
+import { WrappedBuilder } from '@glimmer/opcode-compiler';
import {
combineTagged,
Tag,
@@ -150,8 +151,23 @@ export default class CurlyComponentManager extends AbstractManager<ComponentStat
implements WithDynamicTagName<Opaque>,
WithDynamicLayout<Opaque, TemplateMeta, RuntimeResolver> {
- getDynamicLayout(_component: Opaque, _resolver: RuntimeResolver): Invocation {
- throw new Error('Method not implemented.');
+ getDynamicLayout(component: Opaque, resolver: RuntimeResolver): Invocation {
+ const handle = resolver.lookupComponent(component.name, component.ComponentClass);
+ if (!handle) {
+ throw new Error('Missing dynamic layout');
+ }
+
+ return resolver.compileTemplate(handle, component.layout.name, (template, options) => {
+ const builder = new WrappedBuilder(
+ assign({}, options, { asPartial: false, referrer: null }),
+ template,
+ CAPABILITIES
+ );
+ return {
+ handle: builder.compile(),
+ symbolTable: builder.symbolTable
+ };
+ });
}
getTagName(_component: Opaque): Option<string> {
@@ -369,10 +385,10 @@ export default class CurlyComponentManager extends AbstractManager<ComponentStat
bucket.finalizer = _instrumentStart('render.component', rerenderInstrumentDetails, component);
- if (!args.tag.validate(argsRevision)) {
- let props = processComponentArgs(args);
+ if (!args!.tag.validate(argsRevision)) {
+ let props = processComponentArgs(args!);
- bucket.argsRevision = args.tag.value();
+ bucket.argsRevision = args!.tag.value();
component[IS_DISPATCHING_ATTRS] = true;
component.setProperties(props);
| true |
Other
|
emberjs
|
ember.js
|
aaada07db8c4f2d6242c4954c732da59ceadf80e.json
|
WIP: Start getDynamicLayout and compileTemplate
|
packages/ember-glimmer/lib/component-managers/root.ts
|
@@ -10,12 +10,13 @@ import {
} from 'ember-metal';
import Environment from '../environment';
import { DynamicScope } from '../renderer';
+import RuntimeResolver from '../resolver';
import ComponentStateBucket, { Component } from '../utils/curly-component-state-bucket';
import CurlyComponentManager, {
initialRenderInstrumentDetails,
processComponentInitializationAssertions,
} from './curly';
-import DefintionState from './definition-state';
+import DefinitionState from './definition-state';
class RootComponentManager extends CurlyComponentManager {
component: Component;
@@ -25,12 +26,16 @@ class RootComponentManager extends CurlyComponentManager {
this.component = component;
}
- getLayout(...args: any[]) {
- console.log(...args);
+ getLayout(state: DefinitionState, resolver: RuntimeResolver) {
+ const handle = resolver.lookupComponent(state.name, state.ComponentClass);
+ return {
+ handle,
+ symbolTable: state.symbolTable
+ };
}
create(environment: Environment,
- _state: DefintionState,
+ _state: DefinitionState,
_args: Arguments | null,
dynamicScope: DynamicScope) {
let component = this.component;
@@ -76,13 +81,14 @@ export const ROOT_CAPABILITIES: ComponentCapabilities = {
};
export class RootComponentDefinition implements ComponentDefinition {
- state: DefintionState;
+ state: DefinitionState;
manager: RootComponentManager;
constructor(public component: Component) {
let manager = new RootComponentManager(component);
this.manager = manager;
let factory = peekMeta(component)._factory;
+ console.log(factory);
this.state = {
name: factory.fullName,
capabilities: ROOT_CAPABILITIES,
| true |
Other
|
emberjs
|
ember.js
|
aaada07db8c4f2d6242c4954c732da59ceadf80e.json
|
WIP: Start getDynamicLayout and compileTemplate
|
packages/ember-glimmer/lib/resolver.ts
|
@@ -133,19 +133,16 @@ export default class RuntimeResolver implements IRuntimeResolver<TemplateMeta> {
return (vm, args) => componentHelper(vm, args, meta);
}
- let helper = this.builtInHelpers[name];
+ const helper = this.builtInHelpers[name];
if (helper !== undefined) {
return helper;
}
- let { owner, moduleName } = meta;
+ const { owner, moduleName } = meta;
- let options: LookupOptions | undefined;
- if (moduleName !== undefined) {
- options = { source: `template:${moduleName}` };
- }
+ const options: LookupOptions | undefined = makeOptions(moduleName);
- let helperFactory = owner.factoryFor(`helper:${name}`, options) || owner.factoryFor(`helper:${name}`);
+ const helperFactory = owner.factoryFor(`helper:${name}`, options) || owner.factoryFor(`helper:${name}`);
// TODO: try to unify this into a consistent protocol to avoid wasteful closure allocations
if (helperFactory.class.isHelperInstance) {
| true |
Other
|
emberjs
|
ember.js
|
aaada07db8c4f2d6242c4954c732da59ceadf80e.json
|
WIP: Start getDynamicLayout and compileTemplate
|
packages/internal-test-helpers/lib/test-cases/abstract-rendering.js
|
@@ -72,7 +72,7 @@ export default class AbstractRenderingTestCase extends AbstractTestCase {
layoutName: '-top-level'
});
- owner.register('component:-top-level', Component.extend(attrs));
+ owner.register('-top-level', Component.extend(attrs));
this.component = owner.lookup('component:-top-level');
| true |
Other
|
emberjs
|
ember.js
|
b7271b65e2fc0ca628ac90f5fa63a5ba5d2586ad.json
|
Add 2.17.0-beta.6 to CHANGELOG
[ci skip]
(cherry picked from commit d6dea181a9b3c5ce2f2f5f19dbb316a02dc19e44)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### 2.17.0-beta.6 (November 13, 2017)
+- [#15848](https://github.com/emberjs/ember.js/pull/15848) [BUGFIX] Ensure helpers have a consistent API.
+- [#15849](https://github.com/emberjs/ember.js/pull/15849) [BUGFIX] Fix issue when observing a computed property that is clobbered during creation.
+
### 2.17.0-beta.5 (November 7, 2017)
- [#15797](https://github.com/emberjs/ember.js/pull/15797) [BUGFIX] Fix issues with using partials nested within other partials.
- [#15808](https://github.com/emberjs/ember.js/pull/15808) [BUGFIX] Fix a memory leak in certain testing scenarios.
| false |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
.eslintrc.js
|
@@ -35,6 +35,8 @@ module.exports = {
'ember-internal/require-yuidoc-access': 'error',
'ember-internal/no-const-outside-module-scope': 'error',
+ 'semi': 'error',
+
// temporarily disabled
'no-unused-vars': 'off',
'comma-dangle': 'off',
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
node-tests/.eslintrc.js
|
@@ -4,6 +4,5 @@ module.exports = {
node: true,
},
rules: {
- 'semi': 'error',
},
};
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/container/lib/registry.js
|
@@ -627,7 +627,7 @@ if (DEBUG) {
}
return injections;
- }
+ };
Registry.prototype.validateInjections = function(injections) {
if (!injections) { return; }
@@ -639,7 +639,7 @@ if (DEBUG) {
assert(`Attempting to inject an unknown injection: '${fullName}'`, this.has(fullName));
}
- }
+ };
}
function expandLocalLookup(registry, normalizedName, normalizedSource) {
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-application/tests/system/application_instance_test.js
|
@@ -126,15 +126,15 @@ QUnit.test('unregistering a factory clears all cached instances of that factory'
let postController1 = appInstance.lookup('controller:post');
let postController1Factory = appInstance.factoryFor('controller:post');
assert.ok(postController1 instanceof PostController1, 'precond - lookup creates instance');
- assert.equal(PostController1, postController1Factory.class, 'precond - factoryFor().class matches')
+ assert.equal(PostController1, postController1Factory.class, 'precond - factoryFor().class matches');
appInstance.unregister('controller:post');
appInstance.register('controller:post', PostController2);
let postController2 = appInstance.lookup('controller:post');
let postController2Factory = appInstance.factoryFor('controller:post');
assert.ok(postController2 instanceof PostController2, 'lookup creates instance');
- assert.equal(PostController2, postController2Factory.class, 'factoryFor().class matches')
+ assert.equal(PostController2, postController2Factory.class, 'factoryFor().class matches');
assert.notStrictEqual(postController1, postController2, 'lookup creates a brand new instance, because the previous one was reset');
});
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-application/tests/system/application_test.js
|
@@ -218,7 +218,7 @@ moduleFor('Ember.Application, default resolver with autoboot', class extends Def
[`@test can specify custom router`](assert) {
let MyRouter = Router.extend();
this.runTask(() => {
- this.createApplication()
+ this.createApplication();
this.application.Router = MyRouter;
});
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-application/tests/system/dependency_injection/default_resolver_test.js
|
@@ -183,7 +183,7 @@ moduleFor('Ember.Application Dependency Injection - Integration - default resolv
this.application.FooRoute = Component.extend();
expectAssertion(() => {
- this.privateRegistry.resolve(`route:foo`)
+ this.privateRegistry.resolve(`route:foo`);
}, /to resolve to an Ember.Route/, 'Should assert');
}
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-application/tests/system/visit_test.js
|
@@ -128,7 +128,7 @@ moduleFor('Ember.Application - visit()', class extends ApplicationTestCase {
* Destroy the instance.
*/
return this.runTask(() => {
- this.applicationInstance.destroy()
+ this.applicationInstance.destroy();
this.applicationInstance = null;
});
}).then(() => {
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-debug/lib/deprecate.js
|
@@ -53,7 +53,7 @@ let missingOptionsDeprecation, missingOptionsIdDeprecation, missingOptionsUntilD
if (DEBUG) {
registerHandler = function registerHandler(handler) {
genericRegisterHandler('deprecate', handler);
- }
+ };
let formatMessage = function formatMessage(_message, options) {
let message = _message;
@@ -67,7 +67,7 @@ if (DEBUG) {
}
return message;
- }
+ };
registerHandler(function logDeprecationToConsole(message, options) {
let updatedMessage = formatMessage(message, options);
@@ -196,7 +196,7 @@ if (DEBUG) {
}
invoke('deprecate', ...arguments);
- }
+ };
}
export default deprecate;
@@ -206,4 +206,4 @@ export {
missingOptionsDeprecation,
missingOptionsIdDeprecation,
missingOptionsUntilDeprecation
-}
+};
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-debug/lib/handlers.js
|
@@ -12,7 +12,7 @@ if (DEBUG) {
HANDLERS[type] = (message, options) => {
callback(message, options, nextHandler);
};
- }
+ };
invoke = function invoke(type, message, test, options) {
if (test) { return; }
@@ -22,10 +22,10 @@ if (DEBUG) {
if (handlerForType) {
handlerForType(message, options);
}
- }
+ };
}
export {
registerHandler,
invoke
-}
+};
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-debug/lib/index.js
|
@@ -1,4 +1,4 @@
-import { DEBUG } from 'ember-env-flags'
+import { DEBUG } from 'ember-env-flags';
import { ENV, environment } from 'ember-environment';
import Logger from 'ember-console';
import { isTesting } from './testing';
@@ -297,4 +297,4 @@ export {
setDebugFunction,
getDebugFunction,
_warnIfUsingStrippedFeatureFlags
-}
+};
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-debug/lib/warn.js
|
@@ -46,7 +46,7 @@ if (DEBUG) {
*/
registerHandler = function registerHandler(handler) {
genericRegisterHandler('warn', handler);
- }
+ };
registerHandler(function logWarning(message, options) {
Logger.warn(`WARNING: ${message}`);
@@ -109,12 +109,12 @@ if (DEBUG) {
}
invoke('warn', message, test, options);
- }
+ };
}
export default warn;
export {
registerHandler,
missingOptionsIdDeprecation,
missingOptionsDeprecation
-}
+};
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-extension-support/tests/container_debug_adapter_test.js
|
@@ -38,7 +38,7 @@ moduleFor('Container Debug Adapter', class extends ApplicationTestCase {
}
['@test default ContainerDebugAdapter catalogs controller entries'](assert) {
- this.application.PostController = EmberController.extend()
+ this.application.PostController = EmberController.extend();
let controllerClasses = adapter.catalogEntriesByType('controller');
assert.equal(controllerClasses.length, 1, 'found 1 class');
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-glimmer/tests/integration/application/engine-test.js
|
@@ -596,12 +596,12 @@ moduleFor('Application test: engine rendering', class extends ApplicationTest {
resolveLoading.resolve();
this.runTaskNext(() => {
- this.assertText('ApplicationEnginePost')
+ this.assertText('ApplicationEnginePost');
done();
});
});
- return transition
+ return transition;
});
}
@@ -674,7 +674,7 @@ moduleFor('Application test: engine rendering', class extends ApplicationTest {
resolveLoading.resolve();
this.runTaskNext(() => {
- this.assertText('ApplicationEngineLikes')
+ this.assertText('ApplicationEngineLikes');
done();
});
});
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-glimmer/tests/integration/components/curly-components-test.js
|
@@ -2916,7 +2916,7 @@ moduleFor('Components test: curly components', class extends RenderingTest {
this.registerComponent('foo-bar', {
ComponentClass: Component.extend({
didReceiveAttrs() {
- assert.equal(1, this.get('foo'), 'expected attrs to have correct value')
+ assert.equal(1, this.get('foo'), 'expected attrs to have correct value');
}
}),
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-metal/lib/map.js
|
@@ -158,7 +158,7 @@ class OrderedSet {
@private
*/
forEach(fn /*, ...thisArg*/) {
- assert(`${Object.prototype.toString.call(fn)} is not a function`, typeof fn === 'function')
+ assert(`${Object.prototype.toString.call(fn)} is not a function`, typeof fn === 'function');
if (this.size === 0) { return; }
@@ -334,7 +334,7 @@ class Map {
@private
*/
forEach(callback/*, ...thisArg*/) {
- assert(`${Object.prototype.toString.call(callback)} is not a function`, typeof callback === 'function')
+ assert(`${Object.prototype.toString.call(callback)} is not a function`, typeof callback === 'function');
if (this.size === 0) { return; }
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-metal/lib/property_set.js
|
@@ -98,7 +98,7 @@ function setPath(root, path, value, tolerant) {
let parts = path.split('.');
let keyName = parts.pop();
- assert('Property set failed: You passed an empty path', keyName.trim().length > 0)
+ assert('Property set failed: You passed an empty path', keyName.trim().length > 0);
let newPath = parts.join('.');
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-metal/tests/alias_test.js
|
@@ -8,7 +8,7 @@ import {
addObserver,
removeObserver,
tagFor
-} from '..'
+} from '..';
let obj, count;
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-metal/tests/mixin/reopen_test.js
|
@@ -3,7 +3,7 @@ import {
run,
get,
Mixin
-} from '../..'
+} from '../..';
QUnit.module('Ember.Mixin#reopen');
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-metal/tests/observer_test.js
|
@@ -33,15 +33,15 @@ QUnit.module('addObserver');
testBoth('observer should assert to invalid input', function(get, set) {
expectAssertion(()=> {
- observer(()=>{})
+ observer(()=>{});
}, 'observer called without valid path');
- expectDeprecation('Passing the dependentKeys after the callback function in observer is deprecated. Ensure the callback function is the last argument.')
+ expectDeprecation('Passing the dependentKeys after the callback function in observer is deprecated. Ensure the callback function is the last argument.');
expectAssertion(()=> {
- observer(null)
+ observer(null);
}, 'observer called without a function');
-})
+});
testBoth('observer should fire when property is modified', function(get, set) {
let obj = {};
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-routing/lib/system/router.js
|
@@ -145,7 +145,7 @@ const EmberRouter = EmberObject.extend(Evented, {
this._resetQueuedQueryParameterChanges();
this._handledErrors = dictionary(null);
this._engineInstances = Object.create(null);
- this._engineInfoByRoute = Object.create(null)
+ this._engineInfoByRoute = Object.create(null);
},
/*
@@ -1275,7 +1275,7 @@ export function triggerEvent(handlerInfos, ignoreFailure, args) {
}
}
- let defaultHandler = defaultActionHandlers[name]
+ let defaultHandler = defaultActionHandlers[name];
if (defaultHandler) {
defaultHandler.apply(this, [handlerInfos, ...args]);
return;
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-routing/lib/utils.js
|
@@ -5,7 +5,7 @@ import { Error as EmberError } from 'ember-debug';
const ALL_PERIODS_REGEX = /\./g;
export function extractRouteArgs(args) {
- args = args.slice()
+ args = args.slice();
let possibleQueryParams = args[args.length - 1];
let queryParams;
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-runtime/lib/computed/reduce_computed_macros.js
|
@@ -23,7 +23,7 @@ function reduceMacro(dependentKey, callback, initialValue) {
let arr = get(this, dependentKey);
if (arr === null || typeof arr !== 'object') { return initialValue; }
return arr.reduce(callback, initialValue, this);
- }, { dependentKeys: [`${dependentKey}.[]`], readOnly: true })
+ }, { dependentKeys: [`${dependentKey}.[]`], readOnly: true });
return cp;
}
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-runtime/lib/system/native_array.js
|
@@ -54,7 +54,7 @@ let NativeArray = Mixin.create(MutableArray, Observable, Copyable, {
// primitive for array support.
replace(idx, amt, objects) {
assert(FROZEN_ERROR, !this.isFrozen);
- assert('The third argument to replace needs to be an array.', objects === null || objects === undefined || Array.isArray(objects))
+ assert('The third argument to replace needs to be an array.', objects === null || objects === undefined || Array.isArray(objects));
// if we replaced exactly the same number of items, then pass only the
// replaced range. Otherwise, pass the full remaining array length
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-runtime/tests/suites/mutable_array/insertAt.js
|
@@ -141,7 +141,7 @@ suite.test('[A,B,C].insertAt(1,X) => [A,X,B,C] + notify', function() {
obj.objectAt = (ix) => {
objectAtCalls.push(ix);
return objectAt.call(obj, ix);
- }
+ };
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-runtime/tests/system/string/camelize_test.js
|
@@ -15,7 +15,7 @@ function test(given, expected, description) {
if (ENV.EXTEND_PROTOTYPES.String) {
deepEqual(given.camelize(), expected);
}
- })
+ });
}
test('my favorite items', 'myFavoriteItems', 'camelize normal string');
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-template-compiler/lib/plugins/assert-reserved-named-arguments.js
|
@@ -14,7 +14,7 @@ export default function assertReservedNamedArguments(env) {
}
}
}
- }
+ };
}
function assertMessage(moduleName, node) {
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-template-compiler/lib/plugins/deprecate-render-model.js
|
@@ -23,7 +23,7 @@ export default function deprecateRenderModel(env) {
}
}
}
- }
+ };
}
function deprecationMessage(moduleName, node, param) {
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-template-compiler/lib/plugins/transform-dot-component-invocation.js
|
@@ -66,11 +66,11 @@ export default function transformDotComponentInvocation(env) {
},
BlockStatement: (node) => {
if (isMultipartPath(node.path)) {
- wrapInComponent(node, b)
+ wrapInComponent(node, b);
}
}
}
- }
+ };
}
function isMultipartPath(path) {
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-template-compiler/lib/plugins/transform-has-block-syntax.js
|
@@ -47,5 +47,5 @@ export default function transformHasBlockSyntax(env) {
}
}
}
- }
+ };
}
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-template-compiler/lib/plugins/transform-quoted-bindings-into-just-bindings.js
|
@@ -12,7 +12,7 @@ export default function transformQuotedBindingsIntoJustBindings(env) {
styleAttr.value = styleAttr.value.parts[0];
}
}
- }
+ };
}
function validStyleAttr(attr) {
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-template-compiler/lib/plugins/transform-top-level-components.js
|
@@ -10,7 +10,7 @@ export default function transformTopLevelComponent(env) {
});
}
}
- }
+ };
}
function hasSingleComponentNode(program, componentCallback) {
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember-testing/tests/ext/rsvp_test.js
|
@@ -92,7 +92,7 @@ QUnit.module('TestPromise');
QUnit.test('does not throw error when falsy value passed to then', function() {
expect(1);
return new TestPromise(function(resolve) {
- resolve()
+ resolve();
})
.then(null)
.then(function() {
@@ -104,14 +104,14 @@ QUnit.test('able to get last Promise', function() {
expect(2);
var p1 = new TestPromise(function(resolve) {
- resolve()
+ resolve();
})
.then(function() {
ok(true);
});
var p2 = new TestPromise(function(resolve) {
- resolve()
+ resolve();
});
deepEqual(getLastPromise(), p2);
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember/lib/index.js
|
@@ -11,7 +11,7 @@ import { Registry, Container } from 'container';
// ****ember-metal****
import Ember, * as metal from 'ember-metal';
import { EMBER_METAL_WEAKMAP } from 'ember/features';
-import * as FLAGS from 'ember/features'
+import * as FLAGS from 'ember/features';
// ember-utils exports
Ember.getOwner = utils.getOwner;
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember/tests/component_context_test.js
|
@@ -43,7 +43,7 @@ moduleFor('Application Lifecycle - Component Context', class extends Application
});
this.visit('/').then(() => {
- let text = this.$('#wrapper').text().trim()
+ let text = this.$('#wrapper').text().trim();
assert.equal(text, 'outer', 'The component is composed correctly');
});
}
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember/tests/helpers/link_to_test.js
|
@@ -219,7 +219,7 @@ moduleFor('The {{link-to}} helper - basic tests', class extends ApplicationTestC
assert.equal(this.$('#about-link.foo-is-true').length, 1, 'The about-link was rendered with the truthy class after toggling the property');
}
-})
+});
moduleFor('The {{link-to}} helper - location hooks', class extends ApplicationTestCase {
@@ -936,7 +936,7 @@ moduleFor('The {{link-to}} helper - nested routes and link-to arguments', class
let assertEquality = href => {
assert.equal(normalizeUrl(this.$('#string-link').attr('href')), '/');
assert.equal(normalizeUrl(this.$('#path-link').attr('href')), href);
- }
+ };
this.visit('/');
@@ -1039,7 +1039,7 @@ moduleFor('The {{link-to}} helper - nested routes and link-to arguments', class
// Old IE includes the whole hostname as well
assert.equal(href.slice(-expected[idx].length), expected[idx], `Expected link to be '${expected[idx]}', but was '${href}'`);
}
- }
+ };
linksEqual(this.$('a'), ['/foo', '/bar', '/rar', '/foo', '/bar', '/rar', '/bar', '/foo']);
@@ -1192,7 +1192,7 @@ moduleFor('The {{link-to}} helper - nested routes and link-to arguments', class
let assertEquality = href => {
assert.equal(normalizeUrl(this.$('#string-link').attr('href')), '/');
assert.equal(normalizeUrl(this.$('#path-link').attr('href')), href);
- }
+ };
assertEquality('/');
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember/tests/helpers/link_to_test/link_to_with_query_params_test.js
|
@@ -8,7 +8,7 @@ moduleFor('The {{link-to}} helper: invoking with query params', class extends Ap
let indexProperties = {
foo: '123',
bar: 'abc'
- }
+ };
this.add('controller:index', Controller.extend({
queryParams: ['foo', 'bar', 'abool'],
foo: indexProperties.foo,
@@ -158,7 +158,7 @@ moduleFor('The {{link-to}} helper: invoking with query params', class extends Ap
return this.visit('/').then(() => {
let indexController = this.getController('index');
- let theLink = this.$('#the-link')
+ let theLink = this.$('#the-link');
assert.equal(theLink.attr('href'), '/?foo=OMG');
@@ -228,7 +228,7 @@ moduleFor('The {{link-to}} helper: invoking with query params', class extends Ap
this.router.map(function() {
this.route('cars', function() {
this.route('create');
- })
+ });
});
this.add('controller:cars', Controller.extend({
@@ -285,7 +285,7 @@ moduleFor('The {{link-to}} helper: invoking with query params', class extends Ap
this.router.map(function() {
this.route('search', function() {
this.route('results');
- })
+ });
});
this.add('controller:search', Controller.extend({
@@ -323,7 +323,7 @@ moduleFor('The {{link-to}} helper: invoking with query params', class extends Ap
this.shouldNotBeActive(assert, '#only-add-archive');
this.shouldNotBeActive(assert, '#remove-one');
- return this.visit('/search?search=same&archive=true')
+ return this.visit('/search?search=same&archive=true');
}).then(() => {
this.shouldBeActive(assert, '#both-same');
this.shouldNotBeActive(assert, '#change-one');
@@ -383,7 +383,7 @@ moduleFor('The {{link-to}} helper: invoking with query params', class extends Ap
this.shouldNotBeActive(assert, '#bigger-link');
this.shouldNotBeActive(assert, '#empty-link');
- return this.visit('/?pages=%5B2%2C1%5D')
+ return this.visit('/?pages=%5B2%2C1%5D');
}).then(() => {
this.shouldNotBeActive(assert, '#array-link');
this.shouldNotBeActive(assert, '#bigger-link');
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember/tests/production_build_test.js
|
@@ -1,4 +1,4 @@
-import { DEBUG } from 'ember-env-flags'
+import { DEBUG } from 'ember-env-flags';
import {
assert as emberAssert,
runInDebug
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember/tests/reexports_test.js
|
@@ -240,11 +240,11 @@ if (DEBUG) {
assert.equal(descriptor.enumerable, false, 'descriptor is not enumerable');
assert.equal(descriptor.configurable, false, 'descriptor is not configurable');
- assert.equal(Ember.MODEL_FACTORY_INJECTIONS, false)
+ assert.equal(Ember.MODEL_FACTORY_INJECTIONS, false);
expectDeprecation(function() {
Ember.MODEL_FACTORY_INJECTIONS = true;
- }, 'Ember.MODEL_FACTORY_INJECTIONS is no longer required')
- assert.equal(Ember.MODEL_FACTORY_INJECTIONS, false, 'writing to the property has no affect')
+ }, 'Ember.MODEL_FACTORY_INJECTIONS is no longer required');
+ assert.equal(Ember.MODEL_FACTORY_INJECTIONS, false, 'writing to the property has no affect');
});
}
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember/tests/routing/basic_test.js
|
@@ -2510,7 +2510,7 @@ QUnit.test('Specifying non-existent controller name in route#render throws', fun
renderTemplate() {
expectAssertion(() => {
this.render('homepage', { controller: 'stefanpenneristhemanforme' });
- }, 'You passed `controller: \'stefanpenneristhemanforme\'` into the `render` method, but no such controller could be found.')
+ }, 'You passed `controller: \'stefanpenneristhemanforme\'` into the `render` method, but no such controller could be found.');
}
});
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember/tests/routing/decoupled_basic_test.js
|
@@ -272,7 +272,7 @@ class extends ApplicationTestCase {
'Monday through Friday: 9am to 5pm',
'Saturday: Noon to Midnight',
'Sunday: Noon to 6pm'
- ]))
+ ]));
}
}));
return this.visit('/').then(() => {
| true |
Other
|
emberjs
|
ember.js
|
cd364f5c15081c9e20ccb475f9216cf8be779c9f.json
|
promote eslint rule "semi" to entire project
|
packages/ember/tests/routing/substates_test.js
|
@@ -104,7 +104,7 @@ moduleFor('Loading/Error Substates', class extends ApplicationTestCase {
this.router.map(function() {
this.route('dummy');
- })
+ });
this.add('route:dummy', Route.extend({
model() {
return deferred.promise;
@@ -204,7 +204,7 @@ moduleFor('Loading/Error Substates', class extends ApplicationTestCase {
let promise = this.visit('/').then(() => {
let length = this.$('#toplevel-loading').length;
- text = this.$('#app').text()
+ text = this.$('#app').text();
assert.equal(
length,
@@ -307,7 +307,7 @@ moduleFor('Loading/Error Substates', class extends ApplicationTestCase {
this.router.map(function() {
this.route('foo', function() {
this.route('bar');
- })
+ });
});
this.add('route:foo.bar', Route.extend({
@@ -407,7 +407,7 @@ moduleFor('Loading/Error Substates', class extends ApplicationTestCase {
this.router.map(function() {
this.route('foo', function() {
this.route('bar');
- })
+ });
});
this.add('route:foo.index', Route.extend({
@@ -489,7 +489,7 @@ moduleFor('Loading/Error Substates - globals mode app', class extends AutobootAp
'toplevel error rendered'
);
- reject = false
+ reject = false;
return this.visit('/').then(() => {
let text = this.$('#app').text();
@@ -633,7 +633,7 @@ moduleFor('Loading/Error Substates - nested routes', class extends ApplicationTe
step(1, 'MomSallyRoute#model');
return RSVP.reject({
msg: 'did it broke?'
- })
+ });
},
actions: {
error() {
@@ -682,7 +682,7 @@ moduleFor('Loading/Error Substates - nested routes', class extends ApplicationTe
step(1, 'MomSallyRoute#model');
return RSVP.reject({
msg: 'did it broke?'
- })
+ });
},
actions: {
error(err) {
@@ -894,7 +894,7 @@ moduleFor('Loading/Error Substates - nested routes', class extends ApplicationTe
'grandma.loading',
`in pivot route's child loading state`
);
- deferred.resolve()
+ deferred.resolve();
return promise;
});
| true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.