language
stringclasses 1
value | owner
stringlengths 2
15
| repo
stringlengths 2
21
| sha
stringlengths 45
45
| message
stringlengths 7
36.3k
| path
stringlengths 1
199
| patch
stringlengths 15
102k
| is_multipart
bool 2
classes |
|---|---|---|---|---|---|---|---|
Other
|
emberjs
|
ember.js
|
5291c74d5ec0125161e8b7c72d7c6b0688efb4b2.json
|
Add 2.13.3 to CHANGELOG.md
[ci skip]
|
CHANGELOG.md
|
@@ -19,6 +19,11 @@
- [#15178](https://github.com/emberjs/ember.js/pull/15178) Refactor route to lookup controller for QPs.
- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to service:-document in ember-engines
+### 2.13.3 (May 31, 2017)
+
+- [#15284](https://github.com/emberjs/ember.js/pull/15284) [BUGFIX] remove nested transaction assertion from glimmer.
+- [glimmerjs/glimmer-vm#529](https://github.com/glimmerjs/glimmer-vm/pull/529) [BUGFIX] Fix issues identified with custom element support.
+
### 2.13.2 (May 18, 2017)
- Revert over eager dependency upgrades in 2.13.1.
| false |
Other
|
emberjs
|
ember.js
|
787e0894144fb498f5350d25a72559217b227403.json
|
Add 2.13.2 to CHANGELOG.md
[ci skip]
|
CHANGELOG.md
|
@@ -19,6 +19,10 @@
- [#15178](https://github.com/emberjs/ember.js/pull/15178) Refactor route to lookup controller for QPs.
- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to service:-document in ember-engines
+### 2.13.2 (May 18, 2017)
+
+- Revert over eager dependency upgrades in 2.13.1.
+
### 2.13.1 (May 17, 2017)
- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to document service in `ember-engines`.
| false |
Other
|
emberjs
|
ember.js
|
f7615bd2817563226d699824e5487b21c84abb97.json
|
Add 2.13.1 to CHANGELOG.
[ci skip]
|
CHANGELOG.md
|
@@ -19,6 +19,14 @@
- [#15178](https://github.com/emberjs/ember.js/pull/15178) Refactor route to lookup controller for QPs.
- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to service:-document in ember-engines
+### 2.13.1 (May 17, 2017)
+
+- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to document service in `ember-engines`.
+- [#15138](https://github.com/emberjs/ember.js/pull/15138) [BUGFIX] Fix mocha blueprint service test filename
+- [#15204](https://github.com/emberjs/ember.js/pull/15204) [DEPRECATION] `Ember.MODEL_FACTORY_INJECTIONS` is now always false, deprecate setting it.
+- [#15207](https://github.com/emberjs/ember.js/pull/15207) [BUGFIX] Ensure child engines do not have their container destroyed twice.
+- [#15242](https://github.com/emberjs/ember.js/pull/15242) [BUGFIX] Fix `EmberError` import in system/router.
+- [#15247](https://github.com/emberjs/ember.js/pull/15247) [BUGFIX] Ensure nested custom elements render properly.
### 2.13.0 (April 27, 2017)
| false |
Other
|
emberjs
|
ember.js
|
c2f40bf6e1cc898a4fa2b7c5e76d7127acbb7bcc.json
|
Add EventDispatcher tests for event bubbling
|
packages/ember-glimmer/tests/integration/event-dispatcher-test.js
|
@@ -37,6 +37,59 @@ moduleFor('EventDispatcher', class extends RenderingTest {
assert.strictEqual(receivedEvent.target, this.$('#is-done')[0]);
}
+ ['@test events bubble to parent view'](assert) {
+ let receivedEvent;
+
+ this.registerComponent('x-foo', {
+ ComponentClass: Component.extend({
+ change(event) {
+ receivedEvent = event;
+ }
+ }),
+ template: `{{yield}}`
+ });
+
+ this.registerComponent('x-bar', {
+ ComponentClass: Component.extend({
+ change() {}
+ }),
+ template: `<input id="is-done" type="checkbox">`
+ });
+
+ this.render(`{{#x-foo}}{{x-bar}}{{/x-foo}}`);
+
+ this.runTask(() => this.$('#is-done').trigger('change'));
+ assert.ok(receivedEvent, 'change event was triggered');
+ assert.strictEqual(receivedEvent.target, this.$('#is-done')[0]);
+ }
+
+ ['@test events bubbling up can be prevented'](assert) {
+ let hasReceivedEvent;
+
+ this.registerComponent('x-foo', {
+ ComponentClass: Component.extend({
+ change() {
+ hasReceivedEvent = true;
+ }
+ }),
+ template: `{{yield}}`
+ });
+
+ this.registerComponent('x-bar', {
+ ComponentClass: Component.extend({
+ change() {
+ return false;
+ }
+ }),
+ template: `<input id="is-done" type="checkbox">`
+ });
+
+ this.render(`{{#x-foo}}{{x-bar}}{{/x-foo}}`);
+
+ this.runTask(() => this.$('#is-done').trigger('change'));
+ assert.notOk(hasReceivedEvent, 'change event has not been received');
+ }
+
['@test dispatches to the nearest event manager'](assert) {
let receivedEvent;
| false |
Other
|
emberjs
|
ember.js
|
44f8068ade5b917f0a9dae6d80b9d95bcfc9e9f0.json
|
Update yarn.lock to use `[email protected]`.
Looks like this was not done when the `package.json` was updated.
|
yarn.lock
|
@@ -835,9 +835,9 @@ backbone@^1.1.2:
dependencies:
underscore ">=1.8.3"
-backburner.js@^0.4.0:
- version "0.4.0"
- resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-0.4.0.tgz#fabf211381b8c17309fda1fbea698b4204f447b5"
+backburner.js@^1.0.0:
+ version "1.0.0"
+ resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-1.0.0.tgz#fffae139998f20a161ac2140d85639b152dfc226"
[email protected]:
version "1.0.2"
| false |
Other
|
emberjs
|
ember.js
|
1ec2e33c65403abbe258c51db13475ab1c3a1277.json
|
clean undefined check
|
packages/ember-routing/lib/system/router.js
|
@@ -197,7 +197,7 @@ const EmberRouter = EmberObject.extend(Evented, {
let initialURL = get(this, 'initialURL');
if (this.setupRouter()) {
- if (typeof initialURL === 'undefined') {
+ if (initialURL === undefined) {
initialURL = get(this, 'location').getURL();
}
let initialTransition = this.handleURL(initialURL);
@@ -539,7 +539,7 @@ const EmberRouter = EmberObject.extend(Evented, {
if ('string' === typeof location && owner) {
let resolvedLocation = owner.lookup(`location:${location}`);
- if ('undefined' !== typeof resolvedLocation) {
+ if (resolvedLocation !== undefined) {
location = set(this, 'location', resolvedLocation);
} else {
// Allow for deprecated registration of custom location API's
| false |
Other
|
emberjs
|
ember.js
|
2f5f544b2901589f02d953a11e2617fa1e4ae61b.json
|
Update glimmer versions to 0.24.0-alpha.2.
|
package.json
|
@@ -39,11 +39,11 @@
"link:glimmer": "node bin/yarn-link-glimmer.js"
},
"dependencies": {
- "@glimmer/compiler": "^0.23.0-alpha.17",
- "@glimmer/node": "^0.23.0-alpha.17",
- "@glimmer/reference": "^0.23.0-alpha.17",
- "@glimmer/runtime": "^0.23.0-alpha.17",
- "@glimmer/util": "^0.23.0-alpha.17",
+ "@glimmer/compiler": "^0.24.0-alpha.2",
+ "@glimmer/node": "^0.24.0-alpha.2",
+ "@glimmer/reference": "^0.24.0-alpha.2",
+ "@glimmer/runtime": "^0.24.0-alpha.2",
+ "@glimmer/util": "^0.24.0-alpha.2",
"broccoli-funnel": "^1.2.0",
"broccoli-merge-trees": "^2.0.0",
"ember-cli-get-component-path-option": "^1.0.0",
| true |
Other
|
emberjs
|
ember.js
|
2f5f544b2901589f02d953a11e2617fa1e4ae61b.json
|
Update glimmer versions to 0.24.0-alpha.2.
|
yarn.lock
|
@@ -2,78 +2,78 @@
# yarn lockfile v1
-"@glimmer/compiler@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.23.0-alpha.17.tgz#ac30e7c24e14e6f7d299d141108b881c439f7f9c"
- dependencies:
- "@glimmer/interfaces" "^0.23.0-alpha.17"
- "@glimmer/syntax" "^0.23.0-alpha.17"
- "@glimmer/util" "^0.23.0-alpha.17"
- "@glimmer/wire-format" "^0.23.0-alpha.17"
+"@glimmer/compiler@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.24.0-alpha.2.tgz#4daf6fdc29e348907c219ec7db863ee837653e19"
+ dependencies:
+ "@glimmer/interfaces" "^0.24.0-alpha.2"
+ "@glimmer/syntax" "^0.24.0-alpha.2"
+ "@glimmer/util" "^0.24.0-alpha.2"
+ "@glimmer/wire-format" "^0.24.0-alpha.2"
simple-html-tokenizer "^0.3.0"
-"@glimmer/interfaces@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.23.0-alpha.17.tgz#fb58f14307dbc99fd9a6390f9a1ccb1ca6f3856a"
+"@glimmer/interfaces@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.24.0-alpha.2.tgz#d5fce8939545563c08e96f75bfbd4f184328ee59"
dependencies:
- "@glimmer/wire-format" "^0.23.0-alpha.17"
+ "@glimmer/wire-format" "^0.24.0-alpha.2"
-"@glimmer/node@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.23.0-alpha.17.tgz#22f19c941a01209c0990165e992d75351db6c7e0"
+"@glimmer/node@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.24.0-alpha.2.tgz#bc3a9a16253a64245e82e07430bb2396623c05c7"
dependencies:
- "@glimmer/runtime" "^0.23.0-alpha.17"
+ "@glimmer/runtime" "^0.24.0-alpha.2"
simple-dom "^0.3.0"
-"@glimmer/object-reference@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/object-reference/-/object-reference-0.23.0-alpha.17.tgz#bc96c430ba4f6de062583319f295a271c72b0b3b"
+"@glimmer/object-reference@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/object-reference/-/object-reference-0.24.0-alpha.2.tgz#f52d93f3ba0b1353a740df7c2e03a6e3f4528e61"
dependencies:
- "@glimmer/reference" "^0.23.0-alpha.17"
- "@glimmer/util" "^0.23.0-alpha.17"
+ "@glimmer/reference" "^0.24.0-alpha.2"
+ "@glimmer/util" "^0.24.0-alpha.2"
-"@glimmer/object@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/object/-/object-0.23.0-alpha.17.tgz#7441cf4ea110870b02a331263528c8f4cf379c72"
+"@glimmer/object@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/object/-/object-0.24.0-alpha.2.tgz#09c07ece175e2122d8b43bc38383dbffbb0f54bf"
dependencies:
- "@glimmer/object-reference" "^0.23.0-alpha.17"
- "@glimmer/util" "^0.23.0-alpha.17"
+ "@glimmer/object-reference" "^0.24.0-alpha.2"
+ "@glimmer/util" "^0.24.0-alpha.2"
-"@glimmer/reference@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.23.0-alpha.17.tgz#74c179ca5fb62bb4cdad528c72903e3a207e3a3d"
+"@glimmer/reference@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.24.0-alpha.2.tgz#92a7414d901ed88034e6ec5cdd4e6a213dc7c220"
dependencies:
- "@glimmer/util" "^0.23.0-alpha.17"
+ "@glimmer/util" "^0.24.0-alpha.2"
-"@glimmer/runtime@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.23.0-alpha.17.tgz#ac5a2295342608d12571caccb8c24008b791e812"
+"@glimmer/runtime@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.24.0-alpha.2.tgz#67983bb4862b87e40c19d6ae6521c433307562c7"
dependencies:
- "@glimmer/interfaces" "^0.23.0-alpha.17"
- "@glimmer/object" "^0.23.0-alpha.17"
- "@glimmer/object-reference" "^0.23.0-alpha.17"
- "@glimmer/reference" "^0.23.0-alpha.17"
- "@glimmer/util" "^0.23.0-alpha.17"
- "@glimmer/wire-format" "^0.23.0-alpha.17"
+ "@glimmer/interfaces" "^0.24.0-alpha.2"
+ "@glimmer/object" "^0.24.0-alpha.2"
+ "@glimmer/object-reference" "^0.24.0-alpha.2"
+ "@glimmer/reference" "^0.24.0-alpha.2"
+ "@glimmer/util" "^0.24.0-alpha.2"
+ "@glimmer/wire-format" "^0.24.0-alpha.2"
-"@glimmer/syntax@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.23.0-alpha.17.tgz#2e7feef382e3470743d58e60ea319b6a4ac5db25"
+"@glimmer/syntax@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.24.0-alpha.2.tgz#a3fc1fb18d7dd53cb91f98f524c5009e10174c9e"
dependencies:
- "@glimmer/interfaces" "^0.23.0-alpha.17"
- "@glimmer/util" "^0.23.0-alpha.17"
+ "@glimmer/interfaces" "^0.24.0-alpha.2"
+ "@glimmer/util" "^0.24.0-alpha.2"
handlebars "^4.0.6"
simple-html-tokenizer "^0.3.0"
-"@glimmer/util@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.23.0-alpha.17.tgz#0ba7c259e77119414d4fc9f951c108462092e3a9"
+"@glimmer/util@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.24.0-alpha.2.tgz#579c9352c9c277b8b6b5cd7fb76185f11523b9c6"
-"@glimmer/wire-format@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.23.0-alpha.17.tgz#206eaabacb1c9a55c19bd7525025c7049a812556"
+"@glimmer/wire-format@^0.24.0-alpha.2":
+ version "0.24.0-alpha.2"
+ resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.24.0-alpha.2.tgz#8bee71eded1863a2e54ac9f1c3a53b9fa0c93cea"
dependencies:
- "@glimmer/util" "^0.23.0-alpha.17"
+ "@glimmer/util" "^0.24.0-alpha.2"
abbrev@1, abbrev@~1.0.9:
version "1.0.9"
| true |
Other
|
emberjs
|
ember.js
|
3da5219649a7e2cd2a929468e97b7a11f7641590.json
|
Remove iterableForObject tests.
These are largely duplication functionality in `{{each-in}}`'s own
tests. They were added as a way to flesh out the iterable implementation.
|
packages/ember-glimmer/tests/unit/utils/iterable-test.js
|
@@ -98,70 +98,6 @@ moduleFor('Iterable', class extends TestCase {
}
}
- ['@test iterates over an object\'s own properties']() {
- let iterator = iteratorForObject({ first: 'foo', second: 'bar' });
-
- this.assert.deepEqual(iterator.next(), { key: 'first', memo: 'first', value: 'foo' });
- this.assert.deepEqual(iterator.next(), { key: 'second', memo: 'second', value: 'bar' });
- }
-
- ['@test iterates over an object\'s own properties with indices as keys']() {
- let iterator = iteratorForObject({ first: 'foo', second: 'bar' }, '@index');
-
- this.assert.deepEqual(iterator.next(), { key: 'first', memo: 'first', value: 'foo' });
- this.assert.deepEqual(iterator.next(), { key: 'second', memo: 'second', value: 'bar' });
- }
-
- ['@test iterates over an object\'s own properties with identities as keys']() {
- let iterator = iteratorForObject({ first: 'foo', second: 'bar' }, '@identity');
-
- this.assert.deepEqual(iterator.next(), { key: 'foo', memo: 'first', value: 'foo' });
- this.assert.deepEqual(iterator.next(), { key: 'bar', memo: 'second', value: 'bar' });
- }
-
- ['@test iterates over an object\'s own properties with arbitrary properties as keys']() {
- let iterator = iteratorForObject({ first: { k: 'uno', v: 'foo' }, second: { k: 'dos', v: 'bar' } }, 'k');
-
- this.assert.deepEqual(iterator.next(), { key: 'uno', memo: 'first', value: { k: 'uno', v: 'foo' } });
- this.assert.deepEqual(iterator.next(), { key: 'dos', memo: 'second', value: { k: 'dos', v: 'bar' } });
- }
-
- ['@test each-in errors on `#next` with an undefined ref']() {
- let iterator = iteratorForObject(undefined);
-
- this.assert.expect(1);
-
- try {
- iterator.next();
- } catch({ message }) {
- this.assert.equal(message, 'Cannot call next() on an empty iterator');
- }
- }
-
- ['@test each-in errors on `#next` with a null ref']() {
- let iterator = iteratorForObject(null);
-
- this.assert.expect(1);
-
- try {
- iterator.next();
- } catch({ message }) {
- this.assert.equal(message, 'Cannot call next() on an empty iterator');
- }
- }
-
- ['@test each-in errors on `#next` with an invalid ref type']() {
- let iterator = iteratorForObject('string');
-
- this.assert.expect(1);
-
- try {
- iterator.next();
- } catch({ message }) {
- this.assert.equal(message, 'Cannot call next() on an empty iterator');
- }
- }
-
['@test ensures keys are unique']() {
let iterator = iteratorForArray([{ k: 'qux', v: 'foo' }, { k: 'qux', v: 'bar' }, { k: 'qux', v: 'baz' }], 'k');
@@ -177,12 +113,3 @@ function iteratorForArray(arr, keyPath) {
return iterable.iterate();
}
-
-function iteratorForObject(obj, keyPath) {
- let vm = null;
- let positionalArgs = EvaluatedPositionalArgs.create([new UpdatableReference(obj)]);
- let ref = eachIn(vm, { positional: positionalArgs });
- let iterable = iterableFor(ref, keyPath);
-
- return iterable.iterate();
-}
| false |
Other
|
emberjs
|
ember.js
|
21696d7f4a4fe7e4d38523c809d594ef16bac9cf.json
|
remove extra wrapping function
|
packages/ember-routing/lib/location/hash_location.js
|
@@ -110,16 +110,14 @@ export default EmberObject.extend({
onUpdateURL(callback) {
this._removeEventListener();
- this._hashchangeHandler = () => {
- run(() => {
- let path = this.getURL();
- if (get(this, 'lastSetURL') === path) { return; }
+ this._hashchangeHandler = run.bind(this, function() {
+ let path = this.getURL();
+ if (get(this, 'lastSetURL') === path) { return; }
- set(this, 'lastSetURL', null);
+ set(this, 'lastSetURL', null);
- callback(path);
- });
- };
+ callback(path);
+ });
window.addEventListener('hashchange', this._hashchangeHandler);
},
| false |
Other
|
emberjs
|
ember.js
|
15c10d5692f7eb3b354334d03a54c4c6a20a388c.json
|
blueprints: remove explicit names from initializers.
See https://github.com/emberjs/guides/pull/1654 and https://github.com/ember-cli/ember-cli-legacy-blueprints/pull/54.
|
blueprints/initializer/files/__root__/initializers/__name__.js
|
@@ -3,6 +3,5 @@ export function initialize(/* application */) {
}
export default {
- name: '<%= dasherizedModuleName %>',
initialize
};
| true |
Other
|
emberjs
|
ember.js
|
15c10d5692f7eb3b354334d03a54c4c6a20a388c.json
|
blueprints: remove explicit names from initializers.
See https://github.com/emberjs/guides/pull/1654 and https://github.com/ember-cli/ember-cli-legacy-blueprints/pull/54.
|
blueprints/instance-initializer/files/__root__/instance-initializers/__name__.js
|
@@ -3,6 +3,5 @@ export function initialize(/* appInstance */) {
}
export default {
- name: '<%= dasherizedModuleName %>',
initialize
};
| true |
Other
|
emberjs
|
ember.js
|
15c10d5692f7eb3b354334d03a54c4c6a20a388c.json
|
blueprints: remove explicit names from initializers.
See https://github.com/emberjs/guides/pull/1654 and https://github.com/ember-cli/ember-cli-legacy-blueprints/pull/54.
|
node-tests/blueprints/initializer-test.js
|
@@ -24,7 +24,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
@@ -44,7 +43,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
@@ -64,7 +62,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
@@ -87,7 +84,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
@@ -110,7 +106,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
@@ -133,7 +128,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
@@ -156,7 +150,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
@@ -179,7 +172,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
@@ -204,7 +196,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
}));
@@ -222,7 +213,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
}));
@@ -239,7 +229,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
}));
@@ -258,7 +247,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
}));
| true |
Other
|
emberjs
|
ember.js
|
15c10d5692f7eb3b354334d03a54c4c6a20a388c.json
|
blueprints: remove explicit names from initializers.
See https://github.com/emberjs/guides/pull/1654 and https://github.com/ember-cli/ember-cli-legacy-blueprints/pull/54.
|
node-tests/blueprints/instance-initializer-test.js
|
@@ -24,7 +24,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
@@ -44,7 +43,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
@@ -64,7 +62,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
@@ -86,7 +83,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
@@ -108,7 +104,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
@@ -131,7 +126,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
@@ -154,7 +148,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
@@ -177,7 +170,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
@@ -202,7 +194,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
}));
@@ -220,7 +211,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
}));
@@ -237,7 +227,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
}));
@@ -256,7 +245,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo/bar',\n" +
" initialize\n" +
"};");
}));
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
CHANGELOG.md
|
@@ -218,7 +218,7 @@
- [#13672](https://github.com/emberjs/ember.js/pull/13672) [BUGFIX] Fix issue with `this.render` and `this.disconnectOutlet` in routes.
- [#13716](https://github.com/emberjs/ember.js/pull/13716) [BUGFIX] Ensure that `Ember.Test.waiters` allows access to configured test waiters.
- [#13273](https://github.com/emberjs/ember.js/pull/13273) [BUGFIX] Fix a number of query param related issues reported.
-- [#13424](https://github.com/emberjs/ember.js/pull/13424) [DEPRECATE] Deprecate Ember.Binding. See [the deprecation guide](http://emberjs.com/deprecations/v2.x/#toc_ember-binding) for more details.
+- [#13424](https://github.com/emberjs/ember.js/pull/13424) [DEPRECATE] Deprecate Ember.Binding. See [the deprecation guide](https://emberjs.com/deprecations/v2.x/#toc_ember-binding) for more details.
- [#13599](https://github.com/emberjs/ember.js/pull/13599) [FEATURE] Enable `ember-runtime-computed-uniq-by` feature.
### 2.6.2 (July 11, 2016)
@@ -359,7 +359,7 @@
### 2.3.0 (January 17, 2016)
- [#12712](https://github.com/emberjs/ember.js/pull/12712) [BUGFIX] Create a new hash parameter when creating a component cell
-- [#12746](https://github.com/emberjs/ember.js/pull/12746) [BUGFIX] Update htmlbars to 0.14.11 to fix [CVE-2015-7565](http://emberjs.com/blog/2016/01/14/security-releases-ember-1-11-4-1-12-2-1-13-12-2-0-3-2-1-2-2-2-1.html).
+- [#12746](https://github.com/emberjs/ember.js/pull/12746) [BUGFIX] Update htmlbars to 0.14.11 to fix [CVE-2015-7565](https://emberjs.com/blog/2016/01/14/security-releases-ember-1-11-4-1-12-2-1-13-12-2-0-3-2-1-2-2-2-1.html).
- [#12752](https://github.com/emberjs/ember.js/pull/12752) [BUGFIX] Do not re-raise on errors handled in route error action.
- [#12764](https://github.com/emberjs/ember.js/pull/12764) [BUGFIX] Read values of `action` helper parameters
- [#12793](https://github.com/emberjs/ember.js/pull/12793) [BUGFIX] Remove jQuery version assertion.
@@ -590,7 +590,7 @@
### 1.13.12 (January 14, 2016)
-- [CVE-2015-7565](http://emberjs.com/blog/2016/01/14/security-releases-ember-1-11-4-1-12-2-1-13-12-2-0-3-2-1-2-2-2-1.html)
+- [CVE-2015-7565](https://emberjs.com/blog/2016/01/14/security-releases-ember-1-11-4-1-12-2-1-13-12-2-0-3-2-1-2-2-2-1.html)
### 1.13.11 (November 16, 2015)
@@ -805,7 +805,7 @@
- [#10709](https://github.com/emberjs/ember.js/pull/10709) [BUGFIX] Clear `src` attributes that are set to `null` or `undefined`.
- [#10695](https://github.com/emberjs/ember.js/pull/10695) [SECURITY] Add `<base>` and `<embed>` to list of tags where `src` and `href` are sanitized.
- [#10683](https://github.com/emberjs/ember.js/pull/10683) / [#10703](https://github.com/emberjs/ember.js/pull/10703) / [#10712](https://github.com/emberjs/ember.js/pull/10712) [BUGFIX] Fix regressions added during the `{{outlet}}` refactor.
-- [#10663](https://github.com/emberjs/ember.js/pull/10663) / [#10711](https://github.com/emberjs/ember.js/pull/10711) [SECURITY] Warn when using dynamic style attributes without a `SafeString` value. [See here](http://emberjs.com/deprecations/v1.x/#toc_warning-when-binding-style-attributes) for more details.
+- [#10663](https://github.com/emberjs/ember.js/pull/10663) / [#10711](https://github.com/emberjs/ember.js/pull/10711) [SECURITY] Warn when using dynamic style attributes without a `SafeString` value. [See here](https://emberjs.com/deprecations/v1.x/#toc_warning-when-binding-style-attributes) for more details.
- [#10463](https://github.com/emberjs/ember.js/pull/10463) [BUGFIX] Make async test helpers more robust. Fixes hanging test when elements are not found.
- [#10631](https://github.com/emberjs/ember.js/pull/10631) Deprecate using `fooBinding` syntax (`{{some-thing nameBinding="model.name"}}`) in templates.
- [#10627](https://github.com/emberjs/ember.js/pull/10627) [BUGFIX] Ensure specifying `class` as a sub-expression (`{{input value=foo class=(some-sub-expr)}}`) works properly.
@@ -863,7 +863,7 @@
* [BUGFIX] Ensure that property case is normalized.
* [BUGFIX] Prevent an error from being thrown if the errorThrown property is a string when catching unhandled promise rejections.
* [BUGFIX] `contenteditable` elements should fire focus events in `ember-testing` click helper.
-* [BUGFIX] Remove HTMLBars from builds `ember.debug.js` and `ember.prod.js` builds. Please see http://emberjs.com/blog/2015/02/05/compiling-templates-in-1-10-0.html for more details.
+* [BUGFIX] Remove HTMLBars from builds `ember.debug.js` and `ember.prod.js` builds. Please see https://emberjs.com/blog/2015/02/05/compiling-templates-in-1-10-0.html for more details.
* [BUGFIX] Ensure that calling the `wait` testing helper without routing works properly.
* [BUGFIX] Ensure that a plus sign in query params are treated as spaces.
* [BUGFIX] Fix broken `Ember.Test.unregisterWaiter` semantics.
@@ -961,7 +961,7 @@
Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Previously, if `component-a` did not handle the action, it would silently continue. Now, an assertion would be triggered.
* [PERF] Speedup Mixin creation.
-* [BREAKING] Require Handlebars 2.0. See [blog post](http://emberjs.com/blog/2014/10/16/handlebars-update.html) for details.
+* [BREAKING] Require Handlebars 2.0. See [blog post](https://emberjs.com/blog/2014/10/16/handlebars-update.html) for details.
* Allow all rejection types in promises to be handled.
* Mandatory setter checks for configurable, and does not clobber non-configurable properties.
* Remove long deprecated `Ember.empty` and `Ember.none`.
@@ -1045,7 +1045,7 @@ Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Prev
* [FEATURE] ember-metal-is-present
* [FEATURE] property-brace-expansion-improvement
* Deprecate usage of Internet Explorer 6 & 7.
-* Deprecate global access to view classes from template (see the [deprecation guide](http://emberjs.com/guides/deprecations/)).
+* Deprecate global access to view classes from template (see the [deprecation guide](https://emberjs.com/guides/deprecations/)).
* Deprecate `Ember.Set` (note: this is NOT the `Ember.set`).
* Deprecate `Ember.computed.defaultTo`.
* Remove long deprecated `Ember.StateManager` warnings.
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
CODE_OF_CONDUCT.md
|
@@ -2,7 +2,7 @@ The Ember team and community are committed to everyone having a safe and inclusi
**Our Community Guidelines / Code of Conduct can be found here**:
-http://emberjs.com/guidelines/
+https://emberjs.com/guidelines/
For a history of updates, see the page history here:
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
CONTRIBUTING.md
|
@@ -90,7 +90,7 @@ along.
In short, if you have an idea that would be nice to have, create an issue on the
emberjs/rfcs repo. If you have a question about requesting a feature, start a
-discussion at [discuss.emberjs.com](http://discuss.emberjs.com)
+discussion at [discuss.emberjs.com](https://discuss.emberjs.com)
# Building Ember.js
@@ -168,7 +168,7 @@ to know that you have a clean slate: `yarn install && yarn test`.
3. Add a test for your change. Only refactoring and documentation changes
require no new tests. If you are adding functionality or fixing a bug, we need
a test! If your change is a new feature, please
-[wrap it in a feature flag](http://emberjs.com/guides/contributing/adding-new-features/).
+[wrap it in a feature flag](https://emberjs.com/guides/contributing/adding-new-features/).
4. Make sure to check out the
[JavaScript Style Guide](https://github.com/emberjs/ember.js/blob/master/STYLEGUIDE.md) and
@@ -311,7 +311,7 @@ Documentation commits are tagged as `[DOC channel]` where channel is `canary`,
### Security
-Security commits will be tagged as `[SECURITY cve]`. Please do not submit security related PRs without coordinating with the security team. See the [Security Policy](http://emberjs.com/security/) for more information.
+Security commits will be tagged as `[SECURITY cve]`. Please do not submit security related PRs without coordinating with the security team. See the [Security Policy](https://emberjs.com/security/) for more information.
### Other
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
FEATURES.md
|
@@ -1,6 +1,6 @@
## About Features
-Please read the [Feature Flag Guide](http://emberjs.com/guides/configuring-ember/feature-flags/)
+Please read the [Feature Flag Guide](https://emberjs.com/guides/configuring-ember/feature-flags/)
for a detailed explanation.
## Feature Flags
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
README.md
|
@@ -1,5 +1,5 @@
<p align="center">
- <a href="http://emberjs.com"><img width="300" src="https://raw.githubusercontent.com/emberjs/website/master/source/images/brand/ember_Ember-Light.png"></a>
+ <a href="https://emberjs.com"><img width="300" src="https://raw.githubusercontent.com/emberjs/website/master/source/images/brand/ember_Ember-Light.png"></a>
</p>
<p align="center">
@@ -17,12 +17,12 @@ to build any web application. It is focused on making you, the developer, as pro
Ember.js also provides access to the most advanced features of Javascript, HTML and the Browser giving you everything you need to create your next killer web app.
-- [Website](http://emberjs.com)
-- [Guides](http://guides.emberjs.com)
-- [API](http://emberjs.com/api)
-- [Community](http://emberjs.com/community)
-- [Blog](http://emberjs.com/blog)
-- [Builds](http://emberjs.com/builds)
+- [Website](https://emberjs.com)
+- [Guides](https://guides.emberjs.com)
+- [API](https://emberjs.com/api)
+- [Community](https://emberjs.com/community)
+- [Blog](https://emberjs.com/blog)
+- [Builds](https://emberjs.com/builds)
# Contribution
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
package.json
|
@@ -5,7 +5,7 @@
"keywords": [
"ember-addon"
],
- "homepage": "http://emberjs.com/",
+ "homepage": "https://emberjs.com/",
"bugs": {
"url": "https://github.com/emberjs/ember.js/issues"
},
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/container/lib/registry.js
|
@@ -622,7 +622,7 @@ Registry.prototype = {
function deprecateResolverFunction(registry) {
deprecate('Passing a `resolver` function into a Registry is deprecated. Please pass in a Resolver object with a `resolve` method.',
false,
- { id: 'ember-application.registry-resolver-as-function', until: '3.0.0', url: 'http://emberjs.com/deprecations/v2.x#toc_registry-resolver-as-function' });
+ { id: 'ember-application.registry-resolver-as-function', until: '3.0.0', url: 'https://emberjs.com/deprecations/v2.x#toc_registry-resolver-as-function' });
registry.resolver = {
resolve: registry.resolver
};
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-application/lib/system/engine.js
|
@@ -131,7 +131,7 @@ const Engine = Namespace.extend(RegistryProxyMixin, {
false, {
id: 'ember-application.app-initializer-initialize-arguments',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_initializer-arity'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_initializer-arity'
});
initializer.initialize(this.__registry__, this);
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-debug/lib/deprecate.js
|
@@ -15,7 +15,7 @@ import { registerHandler as genericRegisterHandler, invoke } from './handlers';
/**
Allows for runtime registration of handler functions that override the default deprecation behavior.
- Deprecations are invoked by calls to [Ember.deprecate](http://emberjs.com/api/classes/Ember.html#method_deprecate).
+ Deprecations are invoked by calls to [Ember.deprecate](https://emberjs.com/api/classes/Ember.html#method_deprecate).
The following example demonstrates its usage by registering a handler that throws an error if the
message contains the word "should", otherwise defers to the default handler.
@@ -163,7 +163,7 @@ if (DEBUG) {
{
id: 'ember-debug.deprecate-options-missing',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
}
);
}
@@ -175,7 +175,7 @@ if (DEBUG) {
{
id: 'ember-debug.deprecate-id-missing',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
}
);
}
@@ -187,7 +187,7 @@ if (DEBUG) {
{
id: 'ember-debug.deprecate-until-missing',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
}
);
}
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-debug/lib/warn.js
|
@@ -16,7 +16,7 @@ let missingOptionsDeprecation, missingOptionsIdDeprecation;
if (DEBUG) {
/**
Allows for runtime registration of handler functions that override the default warning behavior.
- Warnings are invoked by calls made to [Ember.warn](http://emberjs.com/api/classes/Ember.html#method_warn).
+ Warnings are invoked by calls made to [Ember.warn](https://emberjs.com/api/classes/Ember.html#method_warn).
The following example demonstrates its usage by registering a handler that does nothing overriding Ember's
default warning behavior.
@@ -88,7 +88,7 @@ if (DEBUG) {
{
id: 'ember-debug.warn-options-missing',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
}
);
}
@@ -100,7 +100,7 @@ if (DEBUG) {
{
id: 'ember-debug.warn-id-missing',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-debug-function-options'
}
);
}
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-glimmer/lib/component.js
|
@@ -550,7 +550,7 @@ const Component = CoreView.extend(
{
id: 'ember-views.component.defaultLayout',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-component-defaultlayout'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-component-defaultlayout'
}
);
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-glimmer/lib/syntax/input.js
|
@@ -16,7 +16,7 @@ function buildTextFieldSyntax(params, hash, builder) {
The `{{input}}` helper lets you create an HTML `<input />` component.
It causes an `Ember.TextField` component to be rendered. For more info,
see the [Ember.TextField](/api/classes/Ember.TextField.html) docs and
- the [templates guide](http://emberjs.com/guides/templates/input-helpers/).
+ the [templates guide](https://emberjs.com/guides/templates/input-helpers/).
```handlebars
{{input value="987"}}
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-glimmer/lib/syntax/outlet.js
|
@@ -49,7 +49,7 @@ function outletComponentFor(vm) {
{{my-footer}}
```
- See [templates guide](http://emberjs.com/guides/templates/the-application-template/) for
+ See [templates guide](https://emberjs.com/guides/templates/the-application-template/) for
additional information on using `{{outlet}}` in `application.hbs`.
You may also specify a name for the `{{outlet}}`, which is useful when using more than one
`{{outlet}}` in a template:
@@ -72,7 +72,7 @@ function outletComponentFor(vm) {
});
```
- See the [routing guide](http://emberjs.com/guides/routing/rendering-a-template/) for more
+ See the [routing guide](https://emberjs.com/guides/routing/rendering-a-template/) for more
information on how your `route` interacts with the `{{outlet}}` helper.
Note: Your content __will not render__ if there isn't an `{{outlet}}` for it.
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-glimmer/lib/utils/string.js
|
@@ -26,7 +26,7 @@ export function getSafeString() {
{
id: 'ember-htmlbars.ember-handlebars-safestring',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_use-ember-string-htmlsafe-over-ember-handlebars-safestring'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_use-ember-string-htmlsafe-over-ember-handlebars-safestring'
}
);
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-glimmer/tests/integration/application/rendering-test.js
|
@@ -91,7 +91,7 @@ moduleFor('Application test: rendering', class extends ApplicationTest {
`);
this.addTemplate('nav', strip`
- <a href="http://emberjs.com/">Ember</a>
+ <a href="https://emberjs.com/">Ember</a>
`);
this.add('route:application', Route.extend({
@@ -122,7 +122,7 @@ moduleFor('Application test: rendering', class extends ApplicationTest {
this.assertComponentElement(this.firstChild, {
content: strip`
<nav>
- <a href="http://emberjs.com/">Ember</a>
+ <a href="https://emberjs.com/">Ember</a>
</nav>
<main>
<ul>
@@ -147,7 +147,7 @@ moduleFor('Application test: rendering', class extends ApplicationTest {
`);
this.addTemplate('nav', strip`
- <a href="http://emberjs.com/">Ember</a>
+ <a href="https://emberjs.com/">Ember</a>
`);
this.add('route:application', Route.extend({
@@ -178,7 +178,7 @@ moduleFor('Application test: rendering', class extends ApplicationTest {
this.assertComponentElement(this.firstChild, {
content: strip`
<nav>
- <a href="http://emberjs.com/">Ember</a>
+ <a href="https://emberjs.com/">Ember</a>
</nav>
<main>
<ul>
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-metal/lib/binding.js
|
@@ -44,7 +44,7 @@ class Binding {
/**
@class Binding
@namespace Ember
- @deprecated See http://emberjs.com/deprecations/v2.x#toc_ember-binding
+ @deprecated See https://emberjs.com/deprecations/v2.x#toc_ember-binding
@public
*/
@@ -303,17 +303,17 @@ function fireDeprecations(obj, toPath, fromPath, deprecateGlobal, deprecateOneWa
deprecate(objectInfo + deprecateGlobalMessage, !deprecateGlobal, {
id: 'ember-metal.binding',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_ember-binding'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_ember-binding'
});
deprecate(objectInfo + deprecateOneWayMessage, !deprecateOneWay, {
id: 'ember-metal.binding',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_ember-binding'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_ember-binding'
});
deprecate(objectInfo + deprecateAliasMessage, !deprecateAlias, {
id: 'ember-metal.binding',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_ember-binding'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_ember-binding'
});
}
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-metal/lib/computed.js
|
@@ -121,7 +121,7 @@ const DEEP_EACH_REGEX = /\.@each\.[^.]+\./;
Additional resources:
- [New CP syntax RFC](https://github.com/emberjs/rfcs/blob/master/text/0011-improved-cp-syntax.md)
- - [New computed syntax explained in "Ember 1.12 released" ](http://emberjs.com/blog/2015/05/13/ember-1-12-released.html#toc_new-computed-syntax)
+ - [New computed syntax explained in "Ember 1.12 released" ](https://emberjs.com/blog/2015/05/13/ember-1-12-released.html#toc_new-computed-syntax)
@class ComputedProperty
@namespace Ember
@@ -512,7 +512,7 @@ ComputedPropertyPrototype.teardown = function(obj, keyName) {
_Note: This is the preferred way to define computed properties when writing third-party
libraries that depend on or use Ember, since there is no guarantee that the user
- will have [prototype Extensions](http://emberjs.com/guides/configuring-ember/disabling-prototype-extensions/) enabled._
+ will have [prototype Extensions](https://emberjs.com/guides/configuring-ember/disabling-prototype-extensions/) enabled._
The alternative syntax, with prototype extensions, might look like:
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-metal/lib/core.js
|
@@ -14,7 +14,7 @@ import { context } from 'ember-environment';
cross-platform compatibility and object property observing. Ember-Runtime is
small and performance-focused so you can use it alongside other
cross-platform libraries such as jQuery. For more details, see
- [Ember-Runtime](http://emberjs.com/api/modules/ember-runtime.html).
+ [Ember-Runtime](https://emberjs.com/api/modules/ember-runtime.html).
@class Ember
@static
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-metal/lib/events.js
|
@@ -84,7 +84,7 @@ export function addListener(obj, eventName, target, method, once) {
{
id: 'ember-views.did-init-attrs',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_ember-component-didinitattrs'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_ember-component-didinitattrs'
}
);
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-routing/lib/services/router.js
|
@@ -27,7 +27,7 @@ const RouterService = Service.extend({
Transition the application into another route. The route may
be either a single route or route path:
- See [Route.transitionTo](http://emberjs.com/api/classes/Ember.Route.html#method_transitionTo) for more info.
+ See [Route.transitionTo](https://emberjs.com/api/classes/Ember.Route.html#method_transitionTo) for more info.
@method transitionTo
@category ember-routing-router-service
@@ -48,7 +48,7 @@ const RouterService = Service.extend({
Transition into another route while replacing the current URL, if possible.
The route may be either a single route or route path:
- See [Route.replaceWith](http://emberjs.com/api/classes/Ember.Route.html#method_replaceWith) for more info.
+ See [Route.replaceWith](https://emberjs.com/api/classes/Ember.Route.html#method_replaceWith) for more info.
@method replaceWith
@category ember-routing-router-service
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-routing/lib/system/route.js
|
@@ -66,7 +66,7 @@ export function hasDefaultSerialize(route) {
/**
The `Ember.Route` class is used to define individual routes. Refer to
- the [routing guide](http://emberjs.com/guides/routing/) for documentation.
+ the [routing guide](https://emberjs.com/guides/routing/) for documentation.
@class Route
@namespace Ember
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-routing/lib/system/router.js
|
@@ -53,7 +53,7 @@ const { slice } = Array.prototype;
/**
The `Ember.Router` class manages the application state and URLs. Refer to
- the [routing guide](http://emberjs.com/guides/routing/) for documentation.
+ the [routing guide](https://emberjs.com/guides/routing/) for documentation.
@class Router
@namespace Ember
@@ -365,7 +365,7 @@ const EmberRouter = EmberObject.extend(Evented, {
Transition the application into another route. The route may
be either a single route or route path:
- See [Route.transitionTo](http://emberjs.com/api/classes/Ember.Route.html#method_transitionTo) for more info.
+ See [Route.transitionTo](https://emberjs.com/api/classes/Ember.Route.html#method_transitionTo) for more info.
@method transitionTo
@param {String} name the name of the route or a URL
@@ -1364,7 +1364,7 @@ EmberRouter.reopenClass({
```
For more detailed documentation and examples please see
- [the guides](http://emberjs.com/guides/routing/defining-your-routes/).
+ [the guides](https://emberjs.com/guides/routing/defining-your-routes/).
@method map
@param callback
@@ -1493,7 +1493,7 @@ function appendLiveRoute(liveRoutes, defaultParentState, renderOptions) {
{
id: 'ember-routing.top-level-render-helper',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_rendering-into-a-render-helper-that-resolves-to-an-outlet'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_rendering-into-a-render-helper-that-resolves-to-an-outlet'
}
);
@@ -1557,7 +1557,7 @@ function representEmptyRoute(liveRoutes, defaultParentState, route) {
deprecateProperty(EmberRouter.prototype, 'router', '_routerMicrolib', {
id: 'ember-router.router',
until: '2.16',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-router-router-renamed-to-ember-router-_routermicrolib'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-router-router-renamed-to-ember-router-_routermicrolib'
});
export default EmberRouter;
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-runtime/lib/mixins/array.js
|
@@ -307,7 +307,7 @@ const ArrayMixin = Mixin.create(Enumerable, {
deprecate(
'`Enumerable#contains` is deprecated, use `Enumerable#includes` instead.',
false,
- { id: 'ember-runtime.enumerable-contains', until: '3.0.0', url: 'http://emberjs.com/deprecations/v2.x#toc_enumerable-contains' }
+ { id: 'ember-runtime.enumerable-contains', until: '3.0.0', url: 'https://emberjs.com/deprecations/v2.x#toc_enumerable-contains' }
);
return this.indexOf(obj) >= 0;
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-runtime/lib/mixins/enumerable.js
|
@@ -221,7 +221,7 @@ const Enumerable = Mixin.create({
```
@method contains
- @deprecated Use `Enumerable#includes` instead. See http://emberjs.com/deprecations/v2.x#toc_enumerable-contains
+ @deprecated Use `Enumerable#includes` instead. See https://emberjs.com/deprecations/v2.x#toc_enumerable-contains
@param {Object} obj The object to search for.
@return {Boolean} `true` if object is found in enumerable.
@public
@@ -230,7 +230,7 @@ const Enumerable = Mixin.create({
deprecate(
'`Enumerable#contains` is deprecated, use `Enumerable#includes` instead.',
false,
- { id: 'ember-runtime.enumerable-contains', until: '3.0.0', url: 'http://emberjs.com/deprecations/v2.x#toc_enumerable-contains' }
+ { id: 'ember-runtime.enumerable-contains', until: '3.0.0', url: 'https://emberjs.com/deprecations/v2.x#toc_enumerable-contains' }
);
let found = this.find(item => item === obj);
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-runtime/lib/mixins/registry_proxy.js
|
@@ -286,7 +286,7 @@ function buildFakeRegistryFunction(instance, typeForMessage, deprecatedProperty,
{
id: 'ember-application.app-instance-registry',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-application-registry-ember-applicationinstance-registry'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-application-registry-ember-applicationinstance-registry'
}
);
return instance[nonDeprecatedProperty](...arguments);
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-template-compiler/lib/plugins/deprecate-render-model.js
|
@@ -20,7 +20,7 @@ DeprecateRenderModel.prototype.transform = function DeprecateRenderModel_transfo
deprecate(deprecationMessage(moduleName, node, param), false, {
id: 'ember-template-compiler.deprecate-render-model',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_model-param-in-code-render-code-helper'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_model-param-in-code-render-code-helper'
});
});
});
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-template-compiler/lib/plugins/deprecate-render.js
|
@@ -19,7 +19,7 @@ DeprecateRender.prototype.transform = function DeprecateRender_transform(ast) {
deprecate(deprecationMessage(moduleName, node), false, {
id: 'ember-template-compiler.deprecate-render',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_code-render-code-helper'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_code-render-code-helper'
});
});
});
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-views/lib/mixins/view_support.js
|
@@ -430,7 +430,7 @@ export default Mixin.create({
{
id: 'ember-views.did-init-attrs',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_ember-component-didinitattrs'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_ember-component-didinitattrs'
}
);
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-views/lib/system/utils.js
|
@@ -18,7 +18,7 @@ export function constructStyleDeprecationMessage(affectedStyle) {
'Binding style attributes may introduce cross-site scripting vulnerabilities; ' +
'please ensure that values being bound are properly escaped. For more information, ' +
'including how to disable this warning, see ' +
- 'http://emberjs.com/deprecations/v1.x/#toc_binding-style-attributes. ' +
+ 'https://emberjs.com/deprecations/v1.x/#toc_binding-style-attributes. ' +
'Style affected: "' + affectedStyle + '"';
}
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember-views/lib/views/view.js
|
@@ -7,7 +7,7 @@
@class View
@namespace Ember
@extends Ember.CoreView
- @deprecated See http://emberjs.com/deprecations/v1.x/#toc_ember-view
+ @deprecated See https://emberjs.com/deprecations/v1.x/#toc_ember-view
@uses Ember.ClassNamesSupport
@private
*/
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
packages/ember/lib/index.js
|
@@ -185,7 +185,7 @@ if (DEBUG) {
{
id: 'ember-metal.model_factory_injections',
until: '2.17.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_code-ember-model-factory-injections'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_code-ember-model-factory-injections'
}
);
},
@@ -243,7 +243,7 @@ Object.defineProperty(Ember, 'K', {
{
id: 'ember-metal.ember-k',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_code-ember-k-code'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_code-ember-k-code'
}
);
@@ -271,7 +271,7 @@ Ember.Backburner = function() {
{
id: 'ember-metal.ember-backburner',
until: '2.8.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-backburner'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-backburner'
}
);
| true |
Other
|
emberjs
|
ember.js
|
2db2c79e647d48dd86b52654d6992977f8d1b4e7.json
|
Use https in references to emberjs website
|
yuidoc.json
|
@@ -1,7 +1,7 @@
{
"name": "The Ember API",
"description": "The Ember API: a framework for building ambitious web applications",
- "url": "http://emberjs.com/",
+ "url": "https://emberjs.com/",
"options": {
"paths": [
"packages/ember/lib",
| true |
Other
|
emberjs
|
ember.js
|
5c3393920dad5145bae7c76b14f23a109341eb5f.json
|
use test instead of match in `isBlank`
|
packages/ember-metal/lib/is_blank.js
|
@@ -25,5 +25,5 @@ import isEmpty from './is_empty';
@public
*/
export default function isBlank(obj) {
- return isEmpty(obj) || (typeof obj === 'string' && obj.match(/\S/) === null);
+ return isEmpty(obj) || (typeof obj === 'string' && /\S/.test(obj) === false);
}
| false |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
CHANGELOG.md
|
@@ -604,7 +604,7 @@
### 1.13.10 (September 6, 2015)
- [#12104](https://github.com/emberjs/ember.js/pull/12104) [BUGFIX] Ensure `concatenatedProperties` are not stomped.
-- [#12256](https://github.com/emberjs/ember.js/pull/12256) [BUGFIX] Ensure concat streams unsubscribe properly. Fixes memory leak with attributes specified within quotes in the template (i.e. `<div data-foo="{{somethign}}"></div>`).
+- [#12256](https://github.com/emberjs/ember.js/pull/12256) [BUGFIX] Ensure concat streams unsubscribe properly. Fixes memory leak with attributes specified within quotes in the template (i.e. `<div data-foo="{{something}}"></div>`).
- [#12272](https://github.com/emberjs/ember.js/pull/12272) [BUGFIX] Update HTMLBars to fix memory leak when an `{{each}}` is inside an `{{if}}`.
### 1.13.9 (August 22, 2015)
@@ -878,7 +878,7 @@
* `removeAttribute` fix for IE <11 and SVG.
* Disable `cloneNodes` in IE8.
* Improve HTML validation and error messages thrown.
- * Fix a number of template compliation issues in IE8.
+ * Fix a number of template compilation issues in IE8.
* Use the correct namespace in `parseHTML` (fixes various issues that occur
when changing to and from alternate namespaces).
* Ensure values are converted to `String`'s when setting attributes (fixes issues in IE10 & IE11).
@@ -1116,7 +1116,7 @@ Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Prev
### Ember 1.6.0 (July, 7, 2014)
* [BREAKING BUGFIX] An empty array is treated as falsy value in `bind-attr` to be in consistent
- with `if` helper. Breaking for apps that relies on the previous behaviour which treats an empty
+ with `if` helper. Breaking for apps that relies on the previous behavior which treats an empty
array as truthy value in `bind-attr`.
* [BUGFIX] Ensure itemController's do not leak by tying them to the parent controller lifecycle.
* [BUGFIX] Spaces in brace expansion throws an error.
@@ -1955,7 +1955,7 @@ Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Prev
* Various enhancements to bound helpers: adds multiple property support to bound helpers, adds bind-able options hash properties, adds {{unbound}} helper support to render unbound form of helpers.
* Add App.inject
* Add Ember.EnumberableUtils.intersection
-* Deprecate Controller#controllerFor in favour of Controller#needs
+* Deprecate Controller#controllerFor in favor of Controller#needs
* Adds `bubbles` property to Ember.TextField
* Allow overriding of Ember.Router#handleURL
* Allow libraries loaded before Ember to tie into Ember load hooks
@@ -1987,7 +1987,7 @@ Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Prev
* Add `action` support to Ember.TextField
* Warn about using production builds in localhost
* Update Metamorph
-* Deprecate Ember.alias in favour of Ember.aliasMethod
+* Deprecate Ember.alias in favor of Ember.aliasMethod
* Add Ember.computed.alias
* Allow chaining on DeferredMixin#then
* ArrayController learned itemControllerClass.
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
CONTRIBUTING.md
|
@@ -56,7 +56,7 @@ original notice.
* If you submit a feature request as an issue, you will be invited to follow the
[instructions in this document](https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md#requesting-a-feature)
and the issue will be closed
-* Issues that become inactive will be labelled accordingly
+* Issues that become inactive will be labeled accordingly
to inform the original poster and Ember contributors that the issue
should be closed since the issue is no longer actionable. The issue
can be reopened at a later time if needed, e.g. becomes actionable again.
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/container/lib/container.js
|
@@ -60,7 +60,7 @@ Container.prototype = {
/**
Given a fullName return a corresponding instance.
- The default behaviour is for lookup to return a singleton instance.
+ The default behavior is for lookup to return a singleton instance.
The singleton is scoped to the container, allowing multiple containers
to all have their own locally scoped singletons.
```javascript
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/container/lib/registry.js
|
@@ -263,7 +263,7 @@ Registry.prototype = {
},
/**
- A hook to enable custom fullName normalization behaviour
+ A hook to enable custom fullName normalization behavior
@private
@method normalizeFullName
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-glimmer/lib/components/link-to.js
|
@@ -75,7 +75,7 @@
any passed value to `disabled` will disable it except `undefined`.
to ensure that only `true` disable the `link-to` component you can
- override the global behaviour of `Ember.LinkComponent`.
+ override the global behavior of `Ember.LinkComponent`.
```javascript
Ember.LinkComponent.reopen({
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-glimmer/lib/helpers/action.js
|
@@ -84,7 +84,7 @@ export const ACTION = symbol('ACTION');
Two options can be passed to the `action` helper when it is used in this way.
* `target=someProperty` will look to `someProperty` instead of the current
- context for the `actions` hash. This can be useful when targetting a
+ context for the `actions` hash. This can be useful when targeting a
service for actions.
* `value="target.value"` will read the path `target.value` off the first
argument to the action when it is called and rewrite the first argument
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-glimmer/lib/helpers/get.js
|
@@ -17,7 +17,7 @@ import {
Dynamically look up a property on an object. The second argument to `{{get}}`
should have a string value, although it can be bound.
- For example, these two usages are equivilent:
+ For example, these two usages are equivalent:
```handlebars
{{person.height}}
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-glimmer/lib/renderer.js
|
@@ -252,7 +252,7 @@ class Renderer {
}
getElement(view) {
- // overriden in the subclasses
+ // overridden in the subclasses
}
getBounds(view) {
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-glimmer/lib/syntax.js
|
@@ -71,7 +71,7 @@ function refineBlockSyntax(sexp, builder) {
export const experimentalMacros = [];
-// This is a private API to allow for expiremental macros
+// This is a private API to allow for experimental macros
// to be created in user space. Registering a macro should
// should be done in an initializer.
export function registerMacros(macro) {
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-glimmer/tests/integration/components/attrs-lookup-test.js
|
@@ -207,7 +207,7 @@ moduleFor('Components test: attrs lookup', class extends RenderingTest {
assert.equal(instance.get('second'), 'second', 'matches known value');
}
- ['@test bound computed properties can be overriden in extensions, set during init, and passed in as attrs']() {
+ ['@test bound computed properties can be overridden in extensions, set during init, and passed in as attrs']() {
let FooClass = Component.extend({
attributeBindings: ['style'],
style: computed('height', 'color', function() {
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-glimmer/tests/integration/components/contextual-components-test.js
|
@@ -835,14 +835,14 @@ moduleFor('Components test: contextual components', class extends RenderingTest
assert.ok(!isEmpty(instance), 'a instance was created');
assert.equal(previousInstance, undefined, 'no previous component exists');
assert.equal(initCount, 1, 'the component was constructed exactly 1 time');
- assert.equal(this.$().text(), 'open', 'the componet text is "open"');
+ assert.equal(this.$().text(), 'open', 'the components text is "open"');
this.runTask(() => this.rerender());
assert.ok(!isEmpty(instance), 'the component instance exists');
assert.equal(previousInstance, undefined, 'no previous component exists');
assert.equal(initCount, 1, 'the component was constructed exactly 1 time');
- assert.equal(this.$().text(), 'open', 'the componet text is "open"');
+ assert.equal(this.$().text(), 'open', 'the components text is "open"');
this.runTask(() => this.context.set('isOpen', false));
@@ -863,7 +863,7 @@ moduleFor('Components test: contextual components', class extends RenderingTest
assert.ok(!isEmpty(instance), 'the component instance exists');
assert.equal(previousInstance, undefined, 'no previous component exists');
assert.equal(initCount, 1, 'the component was constructed exactly 1 time');
- assert.equal(this.$().text(), 'open', 'the componet text is "open"');
+ assert.equal(this.$().text(), 'open', 'the components text is "open"');
}
['@test GH#13982 contextual component ref is stable even when bound params change (bound name param)'](assert) {
@@ -895,14 +895,14 @@ moduleFor('Components test: contextual components', class extends RenderingTest
assert.ok(!isEmpty(instance), 'a instance was created');
assert.equal(previousInstance, undefined, 'no previous component exists');
assert.equal(initCount, 1, 'the component was constructed exactly 1 time');
- assert.equal(this.$().text(), 'open', 'the componet text is "open"');
+ assert.equal(this.$().text(), 'open', 'the components text is "open"');
this.runTask(() => this.rerender());
assert.ok(!isEmpty(instance), 'the component instance exists');
assert.equal(previousInstance, undefined, 'no previous component exists');
assert.equal(initCount, 1, 'the component was constructed exactly 1 time');
- assert.equal(this.$().text(), 'open', 'the componet text is "open"');
+ assert.equal(this.$().text(), 'open', 'the components text is "open"');
this.runTask(() => this.context.set('isOpen', false));
@@ -923,7 +923,7 @@ moduleFor('Components test: contextual components', class extends RenderingTest
assert.ok(!isEmpty(instance), 'the component instance exists');
assert.equal(previousInstance, undefined, 'no previous component exists');
assert.equal(initCount, 1, 'the component was constructed exactly 1 time');
- assert.equal(this.$().text(), 'open', 'the componet text is "open"');
+ assert.equal(this.$().text(), 'open', 'the components text is "open"');
}
['@test GH#13982 contextual component ref is recomputed when component name param changes'](assert) {
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-glimmer/tests/integration/components/curly-components-test.js
|
@@ -1485,7 +1485,7 @@ moduleFor('Components test: curly components', class extends RenderingTest {
this.assertComponentElement(this.firstChild, { attrs: { role: 'main' } });
}
- ['@test `template` specified in component is overriden by block']() {
+ ['@test `template` specified in component is overridden by block']() {
this.registerComponent('with-template', {
ComponentClass: Component.extend({
template: compile('Should not be used')
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-metal/lib/run_loop.js
|
@@ -259,7 +259,7 @@ run.end = function() {
will be resolved on the target object at the time the scheduled item is
invoked allowing you to change the target function.
@param {Object} [arguments*] Optional arguments to be passed to the queued method.
- @return {*} Timer information for use in cancelling, see `run.cancel`.
+ @return {*} Timer information for use in canceling, see `run.cancel`.
@public
*/
run.schedule = function(/* queue, target, method */) {
@@ -328,7 +328,7 @@ run.sync = function() {
target at the time the method is invoked.
@param {Object} [args*] Optional arguments to pass to the timeout.
@param {Number} wait Number of milliseconds to wait.
- @return {*} Timer information for use in cancelling, see `run.cancel`.
+ @return {*} Timer information for use in canceling, see `run.cancel`.
@public
*/
run.later = function(/*target, method*/) {
@@ -345,7 +345,7 @@ run.later = function(/*target, method*/) {
If you pass a string it will be resolved on the
target at the time the method is invoked.
@param {Object} [args*] Optional arguments to pass to the timeout.
- @return {Object} Timer information for use in cancelling, see `run.cancel`.
+ @return {Object} Timer information for use in canceling, see `run.cancel`.
@public
*/
run.once = function(...args) {
@@ -407,7 +407,7 @@ run.once = function(...args) {
If you pass a string it will be resolved on the
target at the time the method is invoked.
@param {Object} [args*] Optional arguments to pass to the timeout.
- @return {Object} Timer information for use in cancelling, see `run.cancel`.
+ @return {Object} Timer information for use in canceling, see `run.cancel`.
@public
*/
run.scheduleOnce = function(/*queue, target, method*/) {
@@ -479,7 +479,7 @@ run.scheduleOnce = function(/*queue, target, method*/) {
If you pass a string it will be resolved on the
target at the time the method is invoked.
@param {Object} [args*] Optional arguments to pass to the timeout.
- @return {Object} Timer information for use in cancelling, see `run.cancel`.
+ @return {Object} Timer information for use in canceling, see `run.cancel`.
@public
*/
run.next = function(...args) {
@@ -533,13 +533,13 @@ run.next = function(...args) {
// will be executed since we passed in true (immediate)
}, 100, true);
- // the 100ms delay until this method can be called again will be cancelled
+ // the 100ms delay until this method can be called again will be canceled
run.cancel(debounceImmediate);
```
@method cancel
@param {Object} timer Timer object to cancel
- @return {Boolean} true if cancelled or false/undefined if it wasn't found
+ @return {Boolean} true if canceled or false/undefined if it wasn't found
@public
*/
run.cancel = function(timer) {
@@ -612,7 +612,7 @@ run.cancel = function(timer) {
@param {Number} wait Number of milliseconds to wait.
@param {Boolean} immediate Trigger the function on the leading instead
of the trailing edge of the wait interval. Defaults to false.
- @return {Array} Timer information for use in cancelling, see `run.cancel`.
+ @return {Array} Timer information for use in canceling, see `run.cancel`.
@public
*/
run.debounce = function() {
@@ -655,7 +655,7 @@ run.debounce = function() {
@param {Number} spacing Number of milliseconds to space out requests.
@param {Boolean} immediate Trigger the function on the leading instead
of the trailing edge of the wait interval. Defaults to true.
- @return {Array} Timer information for use in cancelling, see `run.cancel`.
+ @return {Array} Timer information for use in canceling, see `run.cancel`.
@public
*/
run.throttle = function() {
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-metal/tests/accessors/get_test.js
|
@@ -55,19 +55,19 @@ testBoth('should call unknownProperty on watched values if the value is undefine
equal(get(obj, 'foo'), 'FOO', 'should return value from unknown');
});
-QUnit.test('warn on attemps to call get with no arguments', function() {
+QUnit.test('warn on attempts to call get with no arguments', function() {
expectAssertion(function() {
get('aProperty');
}, /Get must be called with two arguments;/i);
});
-QUnit.test('warn on attemps to call get with only one argument', function() {
+QUnit.test('warn on attempts to call get with only one argument', function() {
expectAssertion(function() {
get('aProperty');
}, /Get must be called with two arguments;/i);
});
-QUnit.test('warn on attemps to call get with more then two arguments', function() {
+QUnit.test('warn on attempts to call get with more then two arguments', function() {
expectAssertion(function() {
get({}, 'aProperty', true);
}, /Get must be called with two arguments;/i);
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-metal/tests/events_test.js
|
@@ -254,7 +254,7 @@ QUnit.test('a listener added as part of a mixin may be overridden', function() {
SecondMixin.apply(obj);
sendEvent(obj, 'bar');
- equal(triggered, 0, 'should not invoke from overriden property');
+ equal(triggered, 0, 'should not invoke from overridden property');
sendEvent(obj, 'baz');
equal(triggered, 1, 'should invoke from subclass property');
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-metal/tests/injected_property_test.js
|
@@ -19,7 +19,7 @@ QUnit.test('injected properties should be overridable', function() {
set(obj, 'foo', 'bar');
- equal(get(obj, 'foo'), 'bar', 'should return the overriden value');
+ equal(get(obj, 'foo'), 'bar', 'should return the overridden value');
});
QUnit.test('getting on an object without an owner or container should fail assertion', function() {
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-metal/tests/mixin/observer_test.js
|
@@ -184,7 +184,7 @@ testBoth('observing chain with property in mixin after', function(get, set) {
equal(get(obj, 'count'), 1, 'should invoke observer after change');
});
-testBoth('observing chain with overriden property', function(get, set) {
+testBoth('observing chain with overridden property', function(get, set) {
let obj2 = { baz: 'baz' };
let obj3 = { baz: 'foo' };
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-routing/lib/ext/controller.js
|
@@ -17,7 +17,7 @@ ControllerMixin.reopen({
`this.category` and `this.page`.
By default, Ember coerces query parameter values using `toggleProperty`.
This behavior may lead to unexpected results.
- To explicity configure a query parameter property so it coerces as expected, you must define a type property:
+ To explicitly configure a query parameter property so it coerces as expected, you must define a type property:
```javascript
queryParams: [{
category: {
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-routing/lib/system/router.js
|
@@ -71,7 +71,7 @@ const EmberRouter = EmberObject.extend(Evented, {
* `history` - use the browser's history API to make the URLs look just like any standard URL
* `hash` - use `#` to separate the server part of the URL from the Ember part: `/blog/#/posts/new`
* `none` - do not store the Ember URL in the actual browser URL (mainly used for testing)
- * `auto` - use the best option based on browser capabilites: `history` if possible, then `hash` if possible, otherwise `none`
+ * `auto` - use the best option based on browser capabilities: `history` if possible, then `hash` if possible, otherwise `none`
Note: If using ember-cli, this value is defaulted to `auto` by the `locationType` setting of `/config/environment.js`
@@ -828,7 +828,7 @@ const EmberRouter = EmberObject.extend(Evented, {
/**
Returns the meta information for the query params of a given route. This
- will be overriden to allow support for lazy routes.
+ will be overridden to allow support for lazy routes.
@private
@method _getQPMeta
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-runtime/lib/mixins/container_proxy.js
|
@@ -50,7 +50,7 @@ let containerProxyMixin = {
/**
Given a fullName return a corresponding instance.
- The default behaviour is for lookup to return a singleton instance.
+ The default behavior is for lookup to return a singleton instance.
The singleton is scoped to the container, allowing multiple containers
to all have their own locally scoped singletons.
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-runtime/tests/system/array_proxy/arranged_content_test.js
|
@@ -300,7 +300,7 @@ QUnit.test('firstObject - returns first arranged object', function() {
});
QUnit.test('arrangedContentArray{Will,Did}Change are called when the arranged content changes', function() {
- // The behaviour covered by this test may change in the future if we decide
+ // The behavior covered by this test may change in the future if we decide
// that built-in array methods are not overridable.
let willChangeCallCount = 0;
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-runtime/tests/system/array_proxy/content_change_test.js
|
@@ -95,7 +95,7 @@ QUnit.test('The ArrayProxy doesn\'t explode when assigned a destroyed object', f
});
QUnit.test('arrayContent{Will,Did}Change are called when the content changes', function() {
- // The behaviour covered by this test may change in the future if we decide
+ // The behavior covered by this test may change in the future if we decide
// that built-in array methods are not overridable.
let willChangeCallCount = 0;
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-views/lib/mixins/text_support.js
|
@@ -19,7 +19,7 @@ const KEY_EVENTS = {
`TextSupport` is a shared mixin used by both `Ember.TextField` and
`Ember.TextArea`. `TextSupport` adds a number of methods that allow you to
specify a controller action to invoke when a certain event is fired on your
- text field or textarea. The specifed controller action would get the current
+ text field or textarea. The specified controller action would get the current
value of the field passed in as the only argument unless the value of
the field is empty. In that case, the instance of the field itself is passed
in as the only argument.
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember-views/lib/system/utils.js
|
@@ -158,7 +158,7 @@ export function getViewClientRects(view) {
`getViewBoundingClientRect` provides information about the position of the
bounding border box edges of a view relative to the viewport.
- It is only intended to be used by development tools like the Ember Inpsector
+ It is only intended to be used by development tools like the Ember Inspector
and may not work on older browsers.
@private
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember/tests/routing/basic_test.js
|
@@ -2032,7 +2032,7 @@ QUnit.test('Generated route should be an instance of App.Route if provided', fun
ok(generatedRoute instanceof App.Route, 'should extend the correct route');
});
-QUnit.test('Nested index route is not overriden by parent\'s implicit index route', function() {
+QUnit.test('Nested index route is not overridden by parent\'s implicit index route', function() {
Router.map(function() {
this.route('posts', function() {
this.route('index', { path: ':category' });
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/ember/tests/routing/query_params_test.js
|
@@ -204,7 +204,7 @@ moduleFor('Query Params - main', class extends QueryParamTestCase {
this.assertCurrentPath('/', 'QP did not update due to being overriden');
this.setAndFlush(indexController, 'c', false);
- this.assertCurrentPath('/?c=false', 'QP updated with overriden param');
+ this.assertCurrentPath('/?c=false', 'QP updated with overridden param');
});
}
| true |
Other
|
emberjs
|
ember.js
|
62aaae02656ed14859588dc7edfe34118337e161.json
|
fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell
|
packages/external-helpers/lib/external-helpers-dev.js
|
@@ -56,7 +56,7 @@ export function defaults(obj, defaults) {
export const possibleConstructorReturn = (function (self, call) {
if (!self) {
- throw new ReferenceError(`this hasn't been initialised - super() hasn't been called`);
+ throw new ReferenceError(`this hasn't been initialized - super() hasn't been called`);
}
return call && (typeof call === 'object' || typeof call === 'function') ? call : self;
});
| true |
Other
|
emberjs
|
ember.js
|
d3f6ffa976a0f8b9b12baf6347b60508b0278266.json
|
Fix non-singleton `{{render` tests.
|
packages/ember-glimmer/lib/syntax/render.js
|
@@ -130,7 +130,7 @@ export function renderMacro(name, params, hash, builder) {
class AbstractRenderManager extends AbstractManager {
prepareArgs(definition, args) {
- return args;
+ return null;
}
/* abstract create(environment, definition, args, dynamicScope); */
| false |
Other
|
emberjs
|
ember.js
|
19316037b03cf7e012dd8342c6764a3159603f45.json
|
Fix iterable hook
|
packages/ember-glimmer/lib/environment.js
|
@@ -236,9 +236,8 @@ export default class Environment extends GlimmerEnvironment {
return ConditionalReference.create(reference);
}
- iterableFor(ref, args) {
- let keyPath = args.named.get('key').value();
- return createIterable(ref, keyPath);
+ iterableFor(ref, key) {
+ return createIterable(ref, key);
}
scheduleInstallModifier() {
| false |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/-class.js
|
@@ -24,5 +24,5 @@ function classHelper({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(classHelper, args);
+ return new InternalHelperReference(classHelper, args.capture());
}
| true |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/-html-safe.js
|
@@ -7,5 +7,5 @@ function htmlSafe({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(htmlSafe, args);
+ return new InternalHelperReference(htmlSafe, args.capture());
}
| true |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/-input-type.js
|
@@ -9,5 +9,5 @@ function inputTypeHelper({ positional, named }) {
}
export default function(vm, args) {
- return new InternalHelperReference(inputTypeHelper, args);
+ return new InternalHelperReference(inputTypeHelper, args.capture());
}
| true |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/-normalize-class.js
|
@@ -16,5 +16,5 @@ function normalizeClass({ positional, named }) {
}
export default function(vm, args) {
- return new InternalHelperReference(normalizeClass, args);
+ return new InternalHelperReference(normalizeClass, args.capture());
}
| true |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/component.js
|
@@ -275,6 +275,6 @@ function curryArgs(definition, newArgs) {
return mergedArgs;
}
-export default function(vm, args, symbolTable) {
- return ClosureComponentReference.create(args, symbolTable, vm.env);
+export default function(vm, args, meta) {
+ return ClosureComponentReference.create(args.capture(), meta, vm.env);
}
| true |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/concat.js
|
@@ -27,5 +27,5 @@ function concat({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(concat, args);
+ return new InternalHelperReference(concat, args.capture());
}
| true |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/loc.js
|
@@ -43,5 +43,5 @@ function locHelper({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(locHelper, args);
+ return new InternalHelperReference(locHelper, args.capture());
}
| true |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/log.js
|
@@ -24,5 +24,5 @@ function log({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(log, args);
+ return new InternalHelperReference(log, args.capture());
}
| true |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/query-param.js
|
@@ -32,5 +32,5 @@ function queryParams({ positional, named }) {
}
export default function(vm, args) {
- return new InternalHelperReference(queryParams, args);
+ return new InternalHelperReference(queryParams, args.capture());
}
| true |
Other
|
emberjs
|
ember.js
|
6d1983c98a3210717689e22c3ac99dbcba72e7ca.json
|
Update helpers to use new args
|
packages/ember-glimmer/lib/helpers/unbound.js
|
@@ -37,7 +37,7 @@ import { UnboundReference } from '../utils/references';
export default function(vm, args) {
assert(
'unbound helper cannot be called with multiple params or hash params',
- args.positional.values.length === 1 && args.named.keys.length === 0
+ args.positional.length === 1 && args.named.length === 0
);
return UnboundReference.create(args.positional.at(0).value());
| true |
Other
|
emberjs
|
ember.js
|
10a2e8b84591c593ccfa79d1c6055054ef93da26.json
|
Fix build scripts for latest Glimmer
|
broccoli/packages.js
|
@@ -186,7 +186,7 @@ module.exports.emberPkgES = function _emberPkgES(name, rollup, externs) {
}
module.exports.glimmerPkgES = function _glimmerPkgES(name, externs = []) {
- return new Rollup(findLib(name, 'dist/modules'), {
+ return new Rollup(findLib(name, 'dist/modules/es5'), {
rollup: {
entry: 'index.js',
dest: `${name}.js`,
| true |
Other
|
emberjs
|
ember.js
|
10a2e8b84591c593ccfa79d1c6055054ef93da26.json
|
Fix build scripts for latest Glimmer
|
ember-cli-build.js
|
@@ -58,7 +58,7 @@ module.exports = function(options) {
let emberTemplateCompiler = emberPkgES('ember-template-compiler');
let emberTemplateCompilerES5 = toES5(emberTemplateCompiler, { annotation: 'ember-template-compiler' });
let glimmerSyntax = toES5(
- glimmerPkgES('@glimmer/syntax', ['handlebars', 'simple-html-tokenizer']),
+ glimmerPkgES('@glimmer/syntax', ['@glimmer/util', 'handlebars', 'simple-html-tokenizer']),
{ annotation: '@glimmer/syntax' }
);
let glimmerCompiler = toES5(
@@ -384,4 +384,4 @@ function testHarnessFiles() {
jquery(),
qunit()
];
-}
\ No newline at end of file
+}
| true |
Other
|
emberjs
|
ember.js
|
1e5b8a90f82d1e81cb673c4f1f6e3a8fdd5a6a2c.json
|
Add 2.14.0-beta.2 to changelog.
[ci skip]
|
CHANGELOG.md
|
@@ -1,5 +1,13 @@
# Ember Changelog
+### 2.14.0-beta.2 (May 10, 2017)
+
+- [#15138](https://github.com/emberjs/ember.js/pull/15138) [BUGFIX] Fix mocha blueprint service test filename
+- [#15193](https://github.com/emberjs/ember.js/pull/15193) [BUGFIX] Ensure `factoryFor` does validation.
+- [#15207](https://github.com/emberjs/ember.js/pull/15207) [BUGFIX] Ensure that an engines container is only destroyed once.
+- [#15218](https://github.com/emberjs/ember.js/pull/15218) [BUGFIX] Update route-recognizer to v0.3.3.
+
+
### 2.14.0-beta.1 (April 27, 2017)
- [#15015](https://github.com/emberjs/ember.js/pull/15015) Allow mounting routeless engines with a bound engine name
| false |
Other
|
emberjs
|
ember.js
|
af1a6f5289a4ec08fa40e3c8357789fe904f4b37.json
|
Remove blank line from qunit test file
|
blueprints/component-test/qunit-files/tests/__testType__/__path__/__test__.js
|
@@ -8,8 +8,7 @@ moduleForComponent('<%= componentPathName %>', '<%= friendlyTestDescription %>',
});
test('it renders', function(assert) {
-<% if (testType === 'integration' ) { %>
- // Set any properties with this.set('myProperty', 'value');
+ <% if (testType === 'integration' ) { %>// Set any properties with this.set('myProperty', 'value');
// Handle any actions with this.on('myAction', function(val) { ... });
this.render(hbs`{{<%= componentPathName %>}}`);
| false |
Other
|
emberjs
|
ember.js
|
579f857f822eef990a2f9520128120c103c240fe.json
|
Remove factory injections.
These were only around to support `lookupFactory` semantics.
|
packages/container/lib/registry.js
|
@@ -32,8 +32,6 @@ export default function Registry(options) {
this._typeInjections = dictionary(null);
this._injections = dictionary(null);
- this._factoryTypeInjections = dictionary(null);
- this._factoryInjections = dictionary(null);
this._localLookupCache = Object.create(null);
this._normalizeCache = dictionary(null);
@@ -86,22 +84,6 @@ Registry.prototype = {
*/
_injections: null,
- /**
- @private
-
- @property _factoryTypeInjections
- @type InheritingDict
- */
- _factoryTypeInjections: null,
-
- /**
- @private
-
- @property _factoryInjections
- @type InheritingDict
- */
- _factoryInjections: null,
-
/**
@private
@@ -549,115 +531,6 @@ Registry.prototype = {
});
},
-
- /**
- Used only via `factoryInjection`.
-
- Provides a specialized form of injection, specifically enabling
- all factory of one type to be injected with a reference to another
- object.
-
- For example, provided each factory of type `model` needed a `store`.
- one would do the following:
-
- ```javascript
- let registry = new Registry();
-
- registry.register('store:main', SomeStore);
-
- registry.factoryTypeInjection('model', 'store', 'store:main');
-
- let store = registry.lookup('store:main');
- let UserFactory = registry.lookupFactory('model:user');
-
- UserFactory.store instanceof SomeStore; //=> true
- ```
-
- @private
- @method factoryTypeInjection
- @param {String} type
- @param {String} property
- @param {String} fullName
- */
- factoryTypeInjection(type, property, fullName) {
- let injections = this._factoryTypeInjections[type] ||
- (this._factoryTypeInjections[type] = []);
-
- injections.push({
- property: property,
- fullName: this.normalize(fullName)
- });
- },
-
- /**
- Defines factory injection rules.
-
- Similar to regular injection rules, but are run against factories, via
- `Registry#lookupFactory`.
-
- These rules are used to inject objects onto factories when they
- are looked up.
-
- Two forms of injections are possible:
-
- * Injecting one fullName on another fullName
- * Injecting one fullName on a type
-
- Example:
-
- ```javascript
- let registry = new Registry();
- let container = registry.container();
-
- registry.register('store:main', Store);
- registry.register('store:secondary', OtherStore);
- registry.register('model:user', User);
- registry.register('model:post', Post);
-
- // injecting one fullName on another type
- registry.factoryInjection('model', 'store', 'store:main');
-
- // injecting one fullName on another fullName
- registry.factoryInjection('model:post', 'secondaryStore', 'store:secondary');
-
- let UserFactory = container.lookupFactory('model:user');
- let PostFactory = container.lookupFactory('model:post');
- let store = container.lookup('store:main');
-
- UserFactory.store instanceof Store; //=> true
- UserFactory.secondaryStore instanceof OtherStore; //=> false
-
- PostFactory.store instanceof Store; //=> true
- PostFactory.secondaryStore instanceof OtherStore; //=> true
-
- // and both models share the same source instance
- UserFactory.store === PostFactory.store; //=> true
- ```
-
- @private
- @method factoryInjection
- @param {String} factoryName
- @param {String} property
- @param {String} injectionName
- */
- factoryInjection(fullName, property, injectionName) {
- let normalizedName = this.normalize(fullName);
- let normalizedInjectionName = this.normalize(injectionName);
-
- this.validateFullName(injectionName);
-
- if (fullName.indexOf(':') === -1) {
- return this.factoryTypeInjection(normalizedName, property, normalizedInjectionName);
- }
-
- let injections = this._factoryInjections[normalizedName] || (this._factoryInjections[normalizedName] = []);
-
- injections.push({
- property: property,
- fullName: normalizedInjectionName
- });
- },
-
/**
@private
@method knownForType
@@ -743,22 +616,6 @@ Registry.prototype = {
injections = injections.concat(this.fallback.getTypeInjections(type));
}
return injections;
- },
-
- getFactoryInjections(fullName) {
- let injections = this._factoryInjections[fullName] || [];
- if (this.fallback) {
- injections = injections.concat(this.fallback.getFactoryInjections(fullName));
- }
- return injections;
- },
-
- getFactoryTypeInjections(type) {
- let injections = this._factoryTypeInjections[type] || [];
- if (this.fallback) {
- injections = injections.concat(this.fallback.getFactoryTypeInjections(type));
- }
- return injections;
}
};
| true |
Other
|
emberjs
|
ember.js
|
579f857f822eef990a2f9520128120c103c240fe.json
|
Remove factory injections.
These were only around to support `lookupFactory` semantics.
|
packages/container/tests/registry_test.js
|
@@ -436,29 +436,6 @@ QUnit.test('`getTypeInjections` includes type injections from a fallback registr
equal(registry.getTypeInjections('model').length, 1, 'Injections from the fallback registry are merged');
});
-QUnit.test('`getFactoryInjections` includes factory injections from a fallback registry', function() {
- let fallback = new Registry();
- let registry = new Registry({ fallback: fallback });
-
- equal(registry.getFactoryInjections('model:user').length, 0, 'No factory injections in the primary registry');
-
- fallback.factoryInjection('model:user', 'store', 'store:main');
-
- equal(registry.getFactoryInjections('model:user').length, 1, 'Factory injections from the fallback registry are merged');
-});
-
-
-QUnit.test('`getFactoryTypeInjections` includes factory type injections from a fallback registry', function() {
- let fallback = new Registry();
- let registry = new Registry({ fallback: fallback });
-
- equal(registry.getFactoryTypeInjections('model').length, 0, 'No factory type injections in the primary registry');
-
- fallback.factoryInjection('model', 'store', 'store:main');
-
- equal(registry.getFactoryTypeInjections('model').length, 1, 'Factory type injections from the fallback registry are merged');
-});
-
QUnit.test('`knownForType` contains keys for each item of a given type', function() {
let registry = new Registry();
| true |
Other
|
emberjs
|
ember.js
|
a787c8274c5290512cc3fdbc60cb9e27938a6674.json
|
Add 2.14.0-beta.1 to the CHANGELOG.
[ci skip]
|
CHANGELOG.md
|
@@ -1,16 +1,25 @@
# Ember Changelog
-### 2.13.0-beta.2 (April 7, 2017)
+### 2.14.0-beta.1 (April 27, 2017)
+
+- [#15015](https://github.com/emberjs/ember.js/pull/15015) Allow mounting routeless engines with a bound engine name
+- [#15078](https://github.com/emberjs/ember.js/pull/15078) [DEPRECATION] Deprecate `EventManager#canDispatchToEventManager`.
+- [#15085](https://github.com/emberjs/ember.js/pull/15085) Add missing instrumentation for compilation/lookup phase
+- [#15150](https://github.com/emberjs/ember.js/pull/15150) [PERF] Cleanup Proxy invalidation tracking.
+- [#15168](https://github.com/emberjs/ember.js/pull/15168) [BUGFIX] Ensure that retrying a transition created with `replaceWith` causes a history replacement.
+- [#15148](https://github.com/emberjs/ember.js/pull/15148) [BUGFIX] Ensure that using `replace` with `refreshModel` works properly.
+- [#15178](https://github.com/emberjs/ember.js/pull/15178) Refactor route to lookup controller for QPs.
+- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to service:-document in ember-engines
+
+
+### 2.13.0 (April 27, 2017)
- [#15111](https://github.com/emberjs/ember.js/pull/15111) / [#15029](https://github.com/emberjs/ember.js/pull/15029) [PERF] `factoryFor` should cache when possible.
- [#14961](https://github.com/emberjs/ember.js/pull/14961) [BUGIX] [Fixes #14925] remove duplicate `/` in pathname
- [#15065](https://github.com/emberjs/ember.js/pull/15065) [BUGFIX] Guard jQuery access in `setupForTesting`.
- [#15103](https://github.com/emberjs/ember.js/pull/15103) [BUGFIX] Allow calling `Ember.warn` without test.
- [#15106](https://github.com/emberjs/ember.js/pull/15106) [DOC] Introduce a more debugging data to warnings about CP dependencies.
- [#15107](https://github.com/emberjs/ember.js/pull/15107) [PERF] avoid toBoolean conversion when possible (chains).
-
-### 2.13.0-beta.1 (March 15, 2017)
-
- [#14011](https://github.com/emberjs/ember.js/pull/14011) [FEATURE ember-unique-location-history-state] Implements [RFC #186](https://github.com/emberjs/rfcs/pull/186).
- [#13231](https://github.com/emberjs/ember.js/pull/13231) [BUGFIX] Fix a bug when using commas in computer property dependent keys.
- [#14890](https://github.com/emberjs/ember.js/pull/14890) [BUGFIX] Fix a race condition where actions are invoked on destroyed DOM nodes.
| false |
Other
|
emberjs
|
ember.js
|
466960d48fcb83cd53a92f353eccb7461307ede2.json
|
Add 2.12.2 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -1,6 +1,6 @@
# Ember Changelog
-# 2.13.0-beta.2 (April 7, 2017)
+### 2.13.0-beta.2 (April 7, 2017)
- [#15111](https://github.com/emberjs/ember.js/pull/15111) / [#15029](https://github.com/emberjs/ember.js/pull/15029) [PERF] `factoryFor` should cache when possible.
- [#14961](https://github.com/emberjs/ember.js/pull/14961) [BUGIX] [Fixes #14925] remove duplicate `/` in pathname
@@ -9,7 +9,7 @@
- [#15106](https://github.com/emberjs/ember.js/pull/15106) [DOC] Introduce a more debugging data to warnings about CP dependencies.
- [#15107](https://github.com/emberjs/ember.js/pull/15107) [PERF] avoid toBoolean conversion when possible (chains).
-# 2.13.0-beta.1 (March 15, 2017)
+### 2.13.0-beta.1 (March 15, 2017)
- [#14011](https://github.com/emberjs/ember.js/pull/14011) [FEATURE ember-unique-location-history-state] Implements [RFC #186](https://github.com/emberjs/rfcs/pull/186).
- [#13231](https://github.com/emberjs/ember.js/pull/13231) [BUGFIX] Fix a bug when using commas in computer property dependent keys.
@@ -20,6 +20,14 @@
- [#14970](https://github.com/emberjs/ember.js/pull/14970) [BUGFIX] Generate integration tests for template helpers by default.
- [#14976](https://github.com/emberjs/ember.js/pull/14976) [BUGFIX] Remove "no use strict" workaround for old versions of iOS 8.
+### 2.12.2 (April 27, 2017)
+
+- [#15160](https://github.com/emberjs/ember.js/pull/15160) [BUGFIX] Ensure `Ember.Test` global is setup when including `ember-testing.js`.
+- [#15142](https://github.com/emberjs/ember.js/pull/15142) / [#15163](https://github.com/emberjs/ember.js/pull/15163) [BUGFIX] Don’t leak deprecated `container`.
+- [#15161](https://github.com/emberjs/ember.js/pull/15161) [BUGFIX] Prevent errors from being triggered during error processing on non ES6 platforms.
+- [#15180](https://github.com/emberjs/ember.js/pull/15180) [BUGFIX] Correct `until` values for `this.container` deprecations.
+
+
### 2.12.1 (April 7, 2017)
- [#14961](https://github.com/emberjs/ember.js/pull/14961) [BUGIX] Remove duplicate trailing `/` in pathname.
| false |
Other
|
emberjs
|
ember.js
|
6fead69599393c79b7ff72c9f4ace1f955fce9e2.json
|
Add 2.13.0-beta.2 to CHANGELOG.
[ci skip]
|
CHANGELOG.md
|
@@ -1,5 +1,14 @@
# Ember Changelog
+# 2.13.0-beta.2 (April 7, 2017)
+
+- [#15111](https://github.com/emberjs/ember.js/pull/15111) / [#15029](https://github.com/emberjs/ember.js/pull/15029) [PERF] `factoryFor` should cache when possible.
+- [#14961](https://github.com/emberjs/ember.js/pull/14961) [BUGIX] [Fixes #14925] remove duplicate `/` in pathname
+- [#15065](https://github.com/emberjs/ember.js/pull/15065) [BUGFIX] Guard jQuery access in `setupForTesting`.
+- [#15103](https://github.com/emberjs/ember.js/pull/15103) [BUGFIX] Allow calling `Ember.warn` without test.
+- [#15106](https://github.com/emberjs/ember.js/pull/15106) [DOC] Introduce a more debugging data to warnings about CP dependencies.
+- [#15107](https://github.com/emberjs/ember.js/pull/15107) [PERF] avoid toBoolean conversion when possible (chains).
+
# 2.13.0-beta.1 (March 15, 2017)
- [#14011](https://github.com/emberjs/ember.js/pull/14011) [FEATURE ember-unique-location-history-state] Implements [RFC #186](https://github.com/emberjs/rfcs/pull/186).
| false |
Other
|
emberjs
|
ember.js
|
3ce075b880e130508e4d7e253ae2930a0d80016c.json
|
Add 2.12.1 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -10,7 +10,12 @@
- [#14919](https://github.com/emberjs/ember.js/pull/14919) [DEPRECATION] Deprecate the private `Ember.Router.router` property in favor of `Ember.Router._routerMicrolib`.
- [#14970](https://github.com/emberjs/ember.js/pull/14970) [BUGFIX] Generate integration tests for template helpers by default.
- [#14976](https://github.com/emberjs/ember.js/pull/14976) [BUGFIX] Remove "no use strict" workaround for old versions of iOS 8.
-- [#14981](https://github.com/emberjs/ember.js/pull/14981) [FEATURE ember-testing-resume-test] Enable by default.
+
+### 2.12.1 (April 7, 2017)
+
+- [#14961](https://github.com/emberjs/ember.js/pull/14961) [BUGIX] Remove duplicate trailing `/` in pathname.
+- [#15029](https://github.com/emberjs/ember.js/pull/15029) [PERF] [BUGFIX] cache `factoryFor` injections when possible
+- [#15089](https://github.com/emberjs/ember.js/pull/15089) [BUGFIX] Fixing IE and Edge issue causing action handlers to be fired twice.
### 2.12.0 (March 14, 2017)
| false |
Other
|
emberjs
|
ember.js
|
b1161bce30e1150f39c1a943ef5a7b51f6909815.json
|
Lock testem down to 1.15.0.
|
package.json
|
@@ -116,7 +116,7 @@
"semver": "^5.3.0",
"serve-static": "^1.12.2",
"simple-dom": "^0.3.0",
- "testem": "^1.16.0"
+ "testem": "1.15.0"
},
"ember-addon": {
"after": "ember-cli-legacy-blueprints"
| true |
Other
|
emberjs
|
ember.js
|
b1161bce30e1150f39c1a943ef5a7b51f6909815.json
|
Lock testem down to 1.15.0.
|
yarn.lock
|
@@ -1732,7 +1732,7 @@ crc32-stream@^1.0.0:
buffer-crc32 "^0.2.1"
readable-stream "^2.0.0"
-cross-spawn@^5.1.0:
+cross-spawn@^5.0.0, cross-spawn@^5.1.0:
version "5.1.0"
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-5.1.0.tgz#e8bd0efee58fcff6f8f94510a0a554bbfa235449"
dependencies:
@@ -4917,7 +4917,7 @@ read@1, read@~1.0.1, read@~1.0.7:
dependencies:
mute-stream "~0.0.4"
-"readable-stream@1 || 2", readable-stream@^2.0.0, "readable-stream@^2.0.0 || ^1.1.13", readable-stream@^2.0.2, readable-stream@^2.0.5, readable-stream@^2.2.2:
+"readable-stream@1 || 2", readable-stream@^2, readable-stream@^2.0.0, "readable-stream@^2.0.0 || ^1.1.13", readable-stream@^2.0.2, readable-stream@^2.0.5, readable-stream@^2.2.2:
version "2.2.2"
resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.2.2.tgz#a9e6fec3c7dda85f8bb1b3ba7028604556fc825e"
dependencies:
@@ -4929,18 +4929,6 @@ read@1, read@~1.0.1, read@~1.0.7:
string_decoder "~0.10.x"
util-deprecate "~1.0.1"
-readable-stream@^2, readable-stream@~2.1.5:
- version "2.1.5"
- resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.1.5.tgz#66fa8b720e1438b364681f2ad1a63c618448c9d0"
- dependencies:
- buffer-shims "^1.0.0"
- core-util-is "~1.0.0"
- inherits "~2.0.1"
- isarray "~1.0.0"
- process-nextick-args "~1.0.6"
- string_decoder "~0.10.x"
- util-deprecate "~1.0.1"
-
readable-stream@~1.0.2:
version "1.0.34"
resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-1.0.34.tgz#125820e34bc842d2f2aaafafe4c2916ee32c157c"
@@ -4961,6 +4949,18 @@ readable-stream@~2.0.5:
string_decoder "~0.10.x"
util-deprecate "~1.0.1"
+readable-stream@~2.1.5:
+ version "2.1.5"
+ resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-2.1.5.tgz#66fa8b720e1438b364681f2ad1a63c618448c9d0"
+ dependencies:
+ buffer-shims "^1.0.0"
+ core-util-is "~1.0.0"
+ inherits "~2.0.1"
+ isarray "~1.0.0"
+ process-nextick-args "~1.0.6"
+ string_decoder "~0.10.x"
+ util-deprecate "~1.0.1"
+
readdir-scoped-modules@^1.0.0:
version "1.0.2"
resolved "https://registry.yarnpkg.com/readdir-scoped-modules/-/readdir-scoped-modules-1.0.2.tgz#9fafa37d286be5d92cbaebdee030dc9b5f406747"
@@ -5745,7 +5745,37 @@ [email protected]:
os-tmpdir "^1.0.0"
rimraf "~2.2.6"
-testem@^1.16.0, testem@^1.8.1:
[email protected]:
+ version "1.15.0"
+ resolved "https://registry.yarnpkg.com/testem/-/testem-1.15.0.tgz#2e3a9e7ac29f16a20f718eb0c4b12e7a44900675"
+ dependencies:
+ backbone "^1.1.2"
+ bluebird "^3.4.6"
+ charm "^1.0.0"
+ commander "^2.6.0"
+ consolidate "^0.14.0"
+ cross-spawn "^5.0.0"
+ express "^4.10.7"
+ fireworm "^0.7.0"
+ glob "^7.0.4"
+ http-proxy "^1.13.1"
+ js-yaml "^3.2.5"
+ lodash.assignin "^4.1.0"
+ lodash.clonedeep "^4.4.1"
+ lodash.find "^4.5.1"
+ mkdirp "^0.5.1"
+ mustache "^2.2.1"
+ node-notifier "^5.0.1"
+ npmlog "^4.0.0"
+ printf "^0.2.3"
+ rimraf "^2.4.4"
+ socket.io "1.6.0"
+ spawn-args "^0.2.0"
+ styled_string "0.0.1"
+ tap-parser "^5.1.0"
+ xmldom "^0.1.19"
+
+testem@^1.8.1:
version "1.16.0"
resolved "https://registry.yarnpkg.com/testem/-/testem-1.16.0.tgz#3933040b5d5b5fbdb6a2b1e7032e511b54a05867"
dependencies:
| true |
Other
|
emberjs
|
ember.js
|
c32446792cee3f1006c00b2aa546438693a6cae5.json
|
Remove usage of `LOOKUP_FACTORY`.
This was added as a "backdoor" to use `container.lookupFactory`
(and its double extend semantics) without triggering a deprecation.
|
packages/container/lib/container.js
|
@@ -14,7 +14,6 @@ import {
import { ENV } from 'ember-environment';
const CONTAINER_OVERRIDE = symbol('CONTAINER_OVERRIDE');
-export const LOOKUP_FACTORY = symbol('LOOKUP_FACTORY');
/**
A container used to instantiate and cache objects.
@@ -121,11 +120,6 @@ Container.prototype = {
return deprecatedFactoryFor(this, this.registry.normalize(fullName), options);
},
- [LOOKUP_FACTORY](fullName, options) {
- assert('fullName must be a proper full name', this.registry.validateFullName(fullName));
- return deprecatedFactoryFor(this, this.registry.normalize(fullName), options);
- },
-
/**
A depth first traversal, destroying the container, its descendant containers and all
their managed objects.
| true |
Other
|
emberjs
|
ember.js
|
c32446792cee3f1006c00b2aa546438693a6cae5.json
|
Remove usage of `LOOKUP_FACTORY`.
This was added as a "backdoor" to use `container.lookupFactory`
(and its double extend semantics) without triggering a deprecation.
|
packages/container/lib/index.js
|
@@ -8,6 +8,5 @@ The public API, specified on the application namespace should be considered the
export { default as Registry, privatize } from './registry';
export {
default as Container,
- buildFakeContainerWithDeprecations,
- LOOKUP_FACTORY
+ buildFakeContainerWithDeprecations
} from './container';
| true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.