language
stringclasses 1
value | owner
stringlengths 2
15
| repo
stringlengths 2
21
| sha
stringlengths 45
45
| message
stringlengths 7
36.3k
| path
stringlengths 1
199
| patch
stringlengths 15
102k
| is_multipart
bool 2
classes |
|---|---|---|---|---|---|---|---|
Other
|
emberjs
|
ember.js
|
30172c7bc91ae86cb61d79dbcd2328abca09570d.json
|
Remove space from generated unit-tests
|
blueprints/component-test/qunit-files/tests/__testType__/__path__/__test__.js
|
@@ -8,7 +8,8 @@ moduleForComponent('<%= componentPathName %>', '<%= friendlyTestDescription %>',
});
test('it renders', function(assert) {
- <% if (testType === 'integration' ) { %>// Set any properties with this.set('myProperty', 'value');
+<% if (testType === 'integration' ) { %>
+ // Set any properties with this.set('myProperty', 'value');
// Handle any actions with this.on('myAction', function(val) { ... });
this.render(hbs`{{<%= componentPathName %>}}`);
| false |
Other
|
emberjs
|
ember.js
|
29dc3a2192d02aef26423f642a1637661ae70ff8.json
|
Move IS_PROXY flag into meta
|
packages/ember-metal/lib/index.js
|
@@ -170,7 +170,6 @@ export {
assertNotRendered
} from './transaction';
export {
- IS_PROXY,
isProxy
} from './is_proxy';
export { default as descriptor } from './descriptor';
| true |
Other
|
emberjs
|
ember.js
|
29dc3a2192d02aef26423f642a1637661ae70ff8.json
|
Move IS_PROXY flag into meta
|
packages/ember-metal/lib/is_proxy.js
|
@@ -1,7 +1,10 @@
-import { symbol } from 'ember-utils';
-
-export const IS_PROXY = symbol('IS_PROXY');
+import { peekMeta } from './meta';
export function isProxy(value) {
- return typeof value === 'object' && value && value[IS_PROXY];
+ if (typeof value === 'object' && value) {
+ let meta = peekMeta(value);
+ return meta && meta.isProxy();
+ }
+
+ return false;
}
| true |
Other
|
emberjs
|
ember.js
|
29dc3a2192d02aef26423f642a1637661ae70ff8.json
|
Move IS_PROXY flag into meta
|
packages/ember-metal/lib/meta.js
|
@@ -58,9 +58,11 @@ let members = {
tags: ownMap
};
+// FLAGS
const SOURCE_DESTROYING = 1 << 1;
const SOURCE_DESTROYED = 1 << 2;
const META_DESTROYED = 1 << 3;
+const IS_PROXY = 1 << 4;
if (isEnabled('ember-glimmer-detect-backtracking-rerender') ||
isEnabled('ember-glimmer-allow-backtracking-rerender')) {
@@ -189,6 +191,14 @@ Meta.prototype.setMetaDestroyed = function setMetaDestroyed() {
this._flags |= META_DESTROYED;
};
+Meta.prototype.isProxy = function isProxy() {
+ return (this._flags & IS_PROXY) !== 0;
+};
+
+Meta.prototype.setProxy = function setProxy() {
+ this._flags |= IS_PROXY;
+};
+
// Implements a member that is a lazily created, non-inheritable
// POJO.
function ownMap(name, Meta) {
| true |
Other
|
emberjs
|
ember.js
|
29dc3a2192d02aef26423f642a1637661ae70ff8.json
|
Move IS_PROXY flag into meta
|
packages/ember-runtime/lib/mixins/-proxy.js
|
@@ -21,7 +21,6 @@ import {
Mixin,
observer,
tagFor,
- IS_PROXY
} from 'ember-metal';
import { bool } from '../computed/computed_macros';
@@ -71,8 +70,6 @@ class ProxyTag extends CachedTag {
@private
*/
export default Mixin.create({
- [IS_PROXY]: true,
-
/**
The object whose properties will be forwarded.
@@ -83,6 +80,11 @@ export default Mixin.create({
*/
content: null,
+ init() {
+ this._super(...arguments);
+ meta(this).setProxy();
+ },
+
_initializeTag: on('init', function() {
meta(this)._tag = new ProxyTag(this);
}),
| true |
Other
|
emberjs
|
ember.js
|
29dc3a2192d02aef26423f642a1637661ae70ff8.json
|
Move IS_PROXY flag into meta
|
packages/ember-runtime/lib/system/object_proxy.js
|
@@ -1,4 +1,4 @@
-import EmberObject from './object';
+import FrameworkObject from './object';
import _ProxyMixin from '../mixins/-proxy';
/**
@@ -71,4 +71,4 @@ import _ProxyMixin from '../mixins/-proxy';
@public
*/
-export default EmberObject.extend(_ProxyMixin);
+export default FrameworkObject.extend(_ProxyMixin);
| true |
Other
|
emberjs
|
ember.js
|
f381a441f0a963ef4176c86492f41edc642b7a10.json
|
Update CHANGELOG for 2.9.0
[ci skip]
|
CHANGELOG.md
|
@@ -4,6 +4,10 @@
- [#14156](https://github.com/emberjs/ember.js/pull/14156) [FEATURE ember-glimmer] Enable by default.
+### 2.9.0 (October 17, 2016)
+
+- No changes from 2.8.2.
+
### 2.8.2 (October 6, 2016)
- [#14365](https://github.com/emberjs/ember.js/pull/14365) [BUGFIX] Fix an issue with URLs with encoded characters and a trailing slash.
| false |
Other
|
emberjs
|
ember.js
|
63c9478c1477ec57f1e51c552ef9c7f529b1d267.json
|
Add 2.10.0-beta.1 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -1,52 +1,6 @@
# Ember Changelog
-### 2.9.0-beta.5 (October 6, 2016)
-
-- [#14403](https://github.com/emberjs/ember.js/pull/14403) [BUGFIX] Ensure `willInsertElement` is fired for tagless components.
-- [#14384](https://github.com/emberjs/ember.js/pull/14384) [BUGFIX] Fix an issue when `attrs` is used in class name and attribute bindings.
-- [#14417](https://github.com/emberjs/ember.js/pull/14417) [BUGFIX] Fix an issue when passing unused positional params to a component.
-- [#14419](https://github.com/emberjs/ember.js/pull/14419) [BUGFIX] Fix rendering `{{string.length}}` in a template.
-- [#14425](https://github.com/emberjs/ember.js/pull/14425) [BUGFIX] Fix rendering `{{this.attrs.*}}` in a template.
-- [#14427](https://github.com/emberjs/ember.js/pull/14427) [BUGFIX] Ensure `Ember.set` in `didUpdate` hooks causes a re-render.
-- [#13996](https://github.com/emberjs/ember.js/pull/13996) [BUGFIX] Fix an issue when passing closure actions via `attrs.*` to child components.
-
-### 2.9.0-beta.4 (September 28, 2016)
-
-- [#14361](https://github.com/emberjs/ember.js/pull/14361) [BUGFIX] Prevent usage of `this.element` when running in a non-interactive environment (i.e. FastBoot).
-- [#14361](https://github.com/emberjs/ember.js/pull/14361) [BUGFIX] Prevent `willRender` and `willUpdate` from running in FastBoot.
-- [#14344](https://github.com/emberjs/ember.js/pull/14344) [BUGFIX] Ensure `element` is present in `willInsertElement` hook.
-- [#14345](https://github.com/emberjs/ember.js/pull/14345) [BUGFIX] Fix an issue causing unneeded rerenders with closure actions.
-- [#14363](https://github.com/emberjs/ember.js/pull/14363) [BUGFIX] Always use `guidFor` for tagless component's with an `id`.
-- [#14365](https://github.com/emberjs/ember.js/pull/14365) [BUGFIX] Bump route-recognizer to fix an issue with encoding `/` in a dynamic segment.
-- [#14366](https://github.com/emberjs/ember.js/pull/14366) [BUGFIX] Fix `Ember.assign` export.
-- [#14367](https://github.com/emberjs/ember.js/pull/14367) [BUGFIX] Ensure feature flags are properly stripped.
-- [#14371](https://github.com/emberjs/ember.js/pull/14371) [BUGFIX] Lazily add `alias` dependent keys (correct a slight performance regression from [#14319](https://github.com/emberjs/ember.js/pull/14319)).
-
-### 2.9.0-beta.3 (September 20, 2016)
-
-- [#14313](https://github.com/emberjs/ember.js/pull/14313) [BUGFIX] Ensure `id` attribute bindings of `undefined` are handled properly.
-- [#14291](https://github.com/emberjs/ember.js/pull/14291) [BUGFIX] Fix component action bubbling semantics.
-- [#14296](https://github.com/emberjs/ember.js/pull/14296) [BUGFIX] Prevent invalid markup when used with XHTML `doctype`.
-- [#14300](https://github.com/emberjs/ember.js/pull/14300) [BUGFIX] Ensure component is `inDOM` during `didInsertElement`.
-- [#14312](https://github.com/emberjs/ember.js/pull/14312) [BUGFIX] Allow a components `layout` to be injected.
-- [#14315](https://github.com/emberjs/ember.js/pull/14315) [BUGFIX] Fix DOM output for properties and attributes.
-- [#14319](https://github.com/emberjs/ember.js/pull/14319) [BUGFIX] Fixes rerendering issues when rendering aliased paths.
-
-
-### 2.9.0-beta.2 (September 12, 2016)
-
-- [#14237](https://github.com/emberjs/ember.js/pull/14237) [BUGFIX] Ensure Engine Routes are deactivated before destruction
-- [#14176](https://github.com/emberjs/ember.js/pull/14176) [BUGFIX] Ensure Controller#transitionToRoute and Route#intermediateTransitionTo work in Engines
-- [#14244](https://github.com/emberjs/ember.js/pull/14244) [BUGFIX] Ensure params and hash are frozen in debug builds.
-- [#14245](https://github.com/emberjs/ember.js/pull/14245) [BUGFIX] Lookup partials from the current owner when rendering an Engines templates.
-- [#14247](https://github.com/emberjs/ember.js/pull/14247) [BUGFIX] Make `this.getAttr` an alias for `this.get`.
-- [#14252](https://github.com/emberjs/ember.js/pull/14252) [BUGFIX] Don't delete moduleName from the generated template compilation options.
-- [#14253](https://github.com/emberjs/ember.js/pull/14253) [BUGFIX] Prevent duplicated `Ember.meta` invocations.
-- [#14271](https://github.com/emberjs/ember.js/pull/14271) [BUGFIX] Ensure `undefined` and `null` values are not rendered as attributes or properties on initial render.
-- [#14272](https://github.com/emberjs/ember.js/pull/14272) [BUGFIX] Fix issues with `Transition#isActive` being falsey incorrectly.
-
-
-### 2.9.0-beta.1 (September 8, 2016)
+### 2.10.0-beta.1 (October 17, 2016)
- [#14156](https://github.com/emberjs/ember.js/pull/14156) [FEATURE ember-glimmer] Enable by default.
| false |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/container/lib/container.js
|
@@ -1,4 +1,4 @@
-import { dictionary, symbol, setOwner, OWNER } from 'ember-utils';
+import { dictionary, symbol, setOwner, OWNER, NAME_KEY } from 'ember-utils';
import { ENV } from 'ember-environment';
import { assert, deprecate, runInDebug } from 'ember-metal';
@@ -270,7 +270,7 @@ function factoryFor(container, fullName, options = {}) {
let factoryInjections = factoryInjectionsFor(container, fullName);
let cacheable = !areInjectionsDynamic(injections) && !areInjectionsDynamic(factoryInjections);
- factoryInjections._toString = registry.makeToString(factory, fullName);
+ factoryInjections[NAME_KEY] = registry.makeToString(factory, fullName);
let injectedFactory = factory.extend(injections);
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember-glimmer/lib/component.js
|
@@ -1,4 +1,4 @@
-import { symbol, getOwner } from 'ember-utils';
+import { symbol, getOwner, NAME_KEY } from 'ember-utils';
import {
CoreView,
ClassNamesSupport,
@@ -13,8 +13,7 @@ import {
get,
PROPERTY_DID_CHANGE,
assert,
- deprecate,
- NAME_KEY
+ deprecate
} from 'ember-metal';
import { UPDATE, RootReference } from './utils/references';
import { DirtyableTag } from 'glimmer-reference';
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember-metal/lib/index.js
|
@@ -136,7 +136,6 @@ export {
_removeBeforeObserver
} from './observer';
export {
- NAME_KEY,
Mixin,
aliasMethod,
_immediateObserver,
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember-metal/lib/mixin.js
|
@@ -10,6 +10,7 @@ import {
assign,
guidFor,
GUID_KEY,
+ NAME_KEY,
wrap,
makeArray
} from 'ember-utils';
@@ -400,8 +401,6 @@ export function mixin(obj, ...args) {
return obj;
}
-export const NAME_KEY = GUID_KEY + '_name';
-
/**
The `Ember.Mixin` class allows you to create mixins, whose properties can be
added to other classes. For instance,
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember-runtime/lib/system/core_object.js
|
@@ -15,7 +15,9 @@ import {
generateGuid,
makeArray,
GUID_KEY_PROPERTY,
- symbol
+ symbol,
+ NAME_KEY,
+ GUID_KEY
} from 'ember-utils';
import {
assert,
@@ -560,6 +562,8 @@ var ClassMixinProps = {
isClass: true,
isMethod: false,
+ [NAME_KEY]: null,
+ [GUID_KEY]: null,
/**
Creates a new subclass.
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember-runtime/lib/system/namespace.js
|
@@ -8,10 +8,9 @@ import Ember, {
Mixin,
hasUnprocessedMixins,
clearUnprocessedMixins,
- NAME_KEY
} from 'ember-metal'; // Preloaded into namespaces
import { context } from 'ember-environment';
-
+import { NAME_KEY } from 'ember-utils';
import EmberObject from './object';
let searchDisabled = false;
@@ -175,28 +174,32 @@ function superClassString(mixin) {
}
}
-function classToString() {
- if (!searchDisabled && !this[NAME_KEY]) {
- processAllNamespaces();
- }
+function calculateToString(target) {
+ let str;
- let ret;
-
- if (this[NAME_KEY]) {
- ret = this[NAME_KEY];
- } else if (this._toString) {
- ret = this._toString;
- } else {
- let str = superClassString(this);
+ if (!searchDisabled) {
+ processAllNamespaces();
+ // can also be set by processAllNamespaces
+ str = target[NAME_KEY];
if (str) {
- ret = '(subclass of ' + str + ')';
+ return str;
} else {
- ret = '(unknown mixin)';
+ str = superClassString(target);
+ str = str ? '(subclass of ' + str + ')' : str;
}
- this.toString = makeToString(ret);
}
+ if (str) {
+ return str;
+ } else {
+ return '(unknown mixin)';
+ }
+}
- return ret;
+function classToString() {
+ let name = this[NAME_KEY];
+ if (name) { return name; }
+
+ return (this[NAME_KEY] = calculateToString(this));
}
function processAllNamespaces() {
@@ -221,10 +224,6 @@ function processAllNamespaces() {
}
}
-function makeToString(ret) {
- return () => ret;
-}
-
Mixin.prototype.toString = classToString; // ES6TODO: altering imported objects. SBB.
export default Namespace;
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember-runtime/tests/system/object/toString_test.js
|
@@ -1,4 +1,4 @@
-import { guidFor, GUID_KEY } from 'ember-utils';
+import { guidFor, NAME_KEY } from 'ember-utils';
import { context } from 'ember-environment';
import EmberObject from '../../../system/object';
import Namespace from '../../../system/namespace';
@@ -15,6 +15,10 @@ QUnit.module('system/object/toString', {
}
});
+QUnit.test('NAME_KEY slot is present on Class', function() {
+ ok(EmberObject.extend().hasOwnProperty(NAME_KEY), 'Ember Class\'s have a NAME_KEY slot');
+});
+
QUnit.test('toString() returns the same value if called twice', function() {
let Foo = Namespace.create();
Foo.toString = function() { return 'Foo'; };
@@ -80,17 +84,17 @@ QUnit.test('toString on a namespace falls back to modulePrefix, if defined', fun
QUnit.test('toString includes toStringExtension if defined', function() {
let Foo = EmberObject.extend({
- toStringExtension() {
- return 'fooey';
- }
- });
+ toStringExtension() {
+ return 'fooey';
+ }
+ });
let foo = Foo.create();
let Bar = EmberObject.extend({});
let bar = Bar.create();
// simulate these classes being defined on a Namespace
- Foo[GUID_KEY + '_name'] = 'Foo';
- Bar[GUID_KEY + '_name'] = 'Bar';
+ Foo[NAME_KEY] = 'Foo';
+ Bar[NAME_KEY] = 'Bar';
equal(bar.toString(), '<Bar:' + guidFor(bar) + '>', 'does not include toStringExtension part');
equal(foo.toString(), '<Foo:' + guidFor(foo) + ':fooey>', 'Includes toStringExtension result');
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember-utils/lib/index.js
|
@@ -28,4 +28,5 @@ export { default as lookupDescriptor } from './lookup-descriptor';
export { canInvoke, tryInvoke } from './invoke';
export { default as makeArray } from './make-array';
export { default as applyStr } from './apply-str';
+export { default as NAME_KEY } from './name';
export { default as toString } from './to-string';
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember-utils/lib/name.js
|
@@ -0,0 +1,2 @@
+import symbol from './symbol';
+export default symbol('NAME_KEY');
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember-utils/lib/to-string.js
|
@@ -5,7 +5,7 @@ const objectToString = Object.prototype.toString;
method, e.g. an object created with `Object.create(null)`.
*/
export default function toString(obj) {
- if (obj && obj.toString) {
+ if (obj && typeof obj.toString === 'function') {
return obj.toString();
} else {
return objectToString.call(obj);
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember/lib/index.js
|
@@ -115,7 +115,7 @@ Ember.MapWithDefault = metal.MapWithDefault;
Ember.getProperties = metal.getProperties;
Ember.setProperties = metal.setProperties;
Ember.expandProperties = metal.expandProperties;
-Ember.NAME_KEY = metal.NAME_KEY;
+Ember.NAME_KEY = utils.NAME_KEY;
Ember.addObserver = metal.addObserver;
Ember.observersFor = metal.observersFor;
Ember.removeObserver = metal.removeObserver;
| true |
Other
|
emberjs
|
ember.js
|
f8f259a2e3c1d1c67207acd4027669185287c1db.json
|
remove _toString, always use NAME_KEY
no longer:
* have two concepts
* processAllNamespaces + find NAME_KEY if the name was pre-determined by the container (previously _toString was set, but not NAME_KEY, which made this code assume it must calculate the name again)
* change shape of `this` with a constant descriptor of toString
* have _toString (NAME_KEY is now used)
|
packages/ember/tests/reexports_test.js
|
@@ -102,7 +102,7 @@ QUnit.module('ember reexports');
['getProperties', 'ember-metal'],
['setProperties', 'ember-metal'],
['expandProperties', 'ember-metal'],
- ['NAME_KEY', 'ember-metal'],
+ ['NAME_KEY', 'ember-utils'],
['addObserver', 'ember-metal'],
['observersFor', 'ember-metal'],
['removeObserver', 'ember-metal'],
| true |
Other
|
emberjs
|
ember.js
|
100dc174af0931922379ec993a75a63b369e1f51.json
|
Add Router support for QP meta not being present
`_fullyScopeQueryParams` and `_hydrateUnsuppliedQueryParams` now have logic to skip over handlers that haven't loaded and thus can't give `qpMeta` information. Due to this, `_queryParamsFor` will not cache the result of an invocation where some `qpMeta` is missing. This way, when the `qpMeta` is available, it can then be accessed and cached. This solves the issue where QPs were never serializing into the URL during `finalizeQueryParamChange`.
|
packages/ember-routing/lib/system/router.js
|
@@ -29,7 +29,6 @@ import EmberLocation from '../location/api';
import {
routeArgs,
getActiveTargetName,
- stashParamNames,
calculateCacheKey
} from '../utils';
import RouterState from './router_state';
@@ -763,6 +762,20 @@ const EmberRouter = EmberObject.extend(Evented, {
this._pruneDefaultQueryParamValues(state.handlerInfos, queryParams);
},
+ /**
+ Returns the meta information for the query params of a given route. This
+ will be overriden to allow support for lazy routes.
+
+ @private
+ @method _getQPMeta
+ @param {HandlerInfo} handlerInfo
+ @return {Object}
+ */
+ _getQPMeta(handlerInfo) {
+ let route = handlerInfo.handler;
+ return route && get(route, '_qp');
+ },
+
/**
Returns a merged query params meta object for a given set of handlerInfos.
Useful for knowing what query params are available for a given route hierarchy.
@@ -778,19 +791,18 @@ const EmberRouter = EmberObject.extend(Evented, {
return this._qpCache[leafRouteName];
}
+ let shouldCache = true;
let qpsByUrlKey = {};
let map = {};
let qps = [];
- this._qpCache[leafRouteName] = {
- map: map,
- qps: qps
- };
for (let i = 0; i < handlerInfos.length; ++i) {
- let route = handlerInfos[i].handler;
- let qpMeta = get(route, '_qp');
+ let qpMeta = this._getQPMeta(handlerInfos[i]);
- if (!qpMeta) { continue; }
+ if (!qpMeta) {
+ shouldCache = false;
+ continue;
+ }
// Loop over each QP to make sure we don't have any collisions by urlKey
for (let i = 0; i < qpMeta.qps.length; i++) {
@@ -809,10 +821,16 @@ const EmberRouter = EmberObject.extend(Evented, {
assign(map, qpMeta.map);
}
- return {
+ let finalQPMeta = {
qps: qps,
map: map
};
+
+ if (shouldCache) {
+ this._qpCache[leafRouteName] = finalQPMeta;
+ }
+
+ return finalQPMeta;
},
/**
@@ -829,11 +847,11 @@ const EmberRouter = EmberObject.extend(Evented, {
_fullyScopeQueryParams(leafRouteName, contexts, queryParams) {
var state = calculatePostTransitionState(this, leafRouteName, contexts);
var handlerInfos = state.handlerInfos;
- stashParamNames(this, handlerInfos);
for (var i = 0, len = handlerInfos.length; i < len; ++i) {
- var route = handlerInfos[i].handler;
- var qpMeta = get(route, '_qp');
+ var qpMeta = this._getQPMeta(handlerInfos[i]);
+
+ if (!qpMeta) { continue; }
for (var j = 0, qpLen = qpMeta.qps.length; j < qpLen; ++j) {
var qp = qpMeta.qps[j];
@@ -866,11 +884,11 @@ const EmberRouter = EmberObject.extend(Evented, {
_hydrateUnsuppliedQueryParams(state, queryParams) {
let handlerInfos = state.handlerInfos;
let appCache = this._bucketCache;
- stashParamNames(this, handlerInfos);
for (let i = 0; i < handlerInfos.length; ++i) {
- let route = handlerInfos[i].handler;
- let qpMeta = get(route, '_qp');
+ let qpMeta = this._getQPMeta(handlerInfos[i]);
+
+ if (!qpMeta) { continue; }
for (let j = 0, qpLen = qpMeta.qps.length; j < qpLen; ++j) {
let qp = qpMeta.qps[j];
| false |
Other
|
emberjs
|
ember.js
|
4cac4c78c0b53fb5b787894f7e5c1683334e11c4.json
|
Fix markdown formatting
|
packages/ember-testing/lib/helpers/pause_test.js
|
@@ -28,6 +28,7 @@ export function resumeTest() {
Pauses the current test - this is useful for debugging while testing or for test-driving.
It allows you to inspect the state of your application at any point.
Example (The test will pause before clicking the button):
+
```javascript
visit('/')
return pauseTest();
| false |
Other
|
emberjs
|
ember.js
|
1f40774763a83c1ab66d111a3b5a6b4870dd577d.json
|
Remove unused argument in test
|
packages/ember-glimmer/tests/integration/components/local-lookup-test.js
|
@@ -44,7 +44,7 @@ moduleFor('Components test: local lookup', class extends RenderingTest {
this.assertText('Nested template says: Hi!', 'Re-render works');
}
- ['@test tagless blockless component can lookup local template'](assert) {
+ ['@test tagless blockless component can lookup local template']() {
this.registerComponent('x-outer/x-inner', { template: 'Nested template says: {{yield}}' });
this.registerTemplate('components/x-outer', '{{#x-inner}}Hi!{{/x-inner}}');
this.registerComponent('x-outer', {
| false |
Other
|
emberjs
|
ember.js
|
c3b7c8200c2ba1366d54e8f2e5afab75a45ddea1.json
|
Add CHANGELOG for 2.8.2 [ci skip]
(cherry picked from commit 669560d1e8a8eb4fb2437d32d447c5da78ab3cf0)
(cherry picked from commit 476fa2d4aeec35cd86cf71ee5ad2435b5c84533a)
|
CHANGELOG.md
|
@@ -50,6 +50,12 @@
- [#14156](https://github.com/emberjs/ember.js/pull/14156) [FEATURE ember-glimmer] Enable by default.
+### 2.8.2 (October 6, 2016)
+
+- [#14365](https://github.com/emberjs/ember.js/pull/14365) [BUGFIX] Fix an issue with URLs with encoded characters and a trailing slash.
+- [#14382](https://github.com/emberjs/ember.js/pull/14382) [BUGFIX] Allow bound `id` on tagless components.
+- [#14421](https://github.com/emberjs/ember.js/pull/14421) [BUGFIX] Fix an issue with local components lookup.
+
### 2.8.1 (September 14, 2016)
- [#14184](https://github.com/emberjs/ember.js/pull/14184) [BUGFIX] Ensure that promises that reject with non Errors (i.e. something without a `.stack`) do not trigger an error during Ember's internal error processing.
| false |
Other
|
emberjs
|
ember.js
|
9449635a147c4761276e63178a03eb62d5b8a4fe.json
|
Add 2.9.0-beta.4 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 26c564f5d18c9097f62bd5f76ebc3261ac7f7f7d)
|
CHANGELOG.md
|
@@ -1,5 +1,17 @@
# Ember Changelog
+### 2.9.0-beta.4 (September 28, 2016)
+
+- [#14361](https://github.com/emberjs/ember.js/pull/14361) [BUGFIX] Prevent usage of `this.element` when running in a non-interactive environment (i.e. FastBoot).
+- [#14361](https://github.com/emberjs/ember.js/pull/14361) [BUGFIX] Prevent `willRender` and `willUpdate` from running in FastBoot.
+- [#14344](https://github.com/emberjs/ember.js/pull/14344) [BUGFIX] Ensure `element` is present in `willInsertElement` hook.
+- [#14345](https://github.com/emberjs/ember.js/pull/14345) [BUGFIX] Fix an issue causing unneeded rerenders with closure actions.
+- [#14363](https://github.com/emberjs/ember.js/pull/14363) [BUGFIX] Always use `guidFor` for tagless component's with an `id`.
+- [#14365](https://github.com/emberjs/ember.js/pull/14365) [BUGFIX] Bump route-recognizer to fix an issue with encoding `/` in a dynamic segment.
+- [#14366](https://github.com/emberjs/ember.js/pull/14366) [BUGFIX] Fix `Ember.assign` export.
+- [#14367](https://github.com/emberjs/ember.js/pull/14367) [BUGFIX] Ensure feature flags are properly stripped.
+- [#14371](https://github.com/emberjs/ember.js/pull/14371) [BUGFIX] Lazily add `alias` dependent keys (correct a slight performance regression from [#14319](https://github.com/emberjs/ember.js/pull/14319)).
+
### 2.9.0-beta.3 (September 20, 2016)
- [#14313](https://github.com/emberjs/ember.js/pull/14313) [BUGFIX] Ensure `id` attribute bindings of `undefined` are handled properly.
| false |
Other
|
emberjs
|
ember.js
|
620092fb2a5ee86967f1516ca4c49c2ea0443860.json
|
Add 2.9.0-beta.3 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 40eae514e3ec40e60b68ae2d12a711c4e8eb0d5d)
|
CHANGELOG.md
|
@@ -1,5 +1,16 @@
# Ember Changelog
+### 2.9.0-beta.3 (September 20, 2016)
+
+- [#14313](https://github.com/emberjs/ember.js/pull/14313) [BUGFIX] Ensure `id` attribute bindings of `undefined` are handled properly.
+- [#14291](https://github.com/emberjs/ember.js/pull/14291) [BUGFIX] Fix component action bubbling semantics.
+- [#14296](https://github.com/emberjs/ember.js/pull/14296) [BUGFIX] Prevent invalid markup when used with XHTML `doctype`.
+- [#14300](https://github.com/emberjs/ember.js/pull/14300) [BUGFIX] Ensure component is `inDOM` during `didInsertElement`.
+- [#14312](https://github.com/emberjs/ember.js/pull/14312) [BUGFIX] Allow a components `layout` to be injected.
+- [#14315](https://github.com/emberjs/ember.js/pull/14315) [BUGFIX] Fix DOM output for properties and attributes.
+- [#14319](https://github.com/emberjs/ember.js/pull/14319) [BUGFIX] Fixes rerendering issues when rendering aliased paths.
+
+
### 2.9.0-beta.2 (September 12, 2016)
- [#14237](https://github.com/emberjs/ember.js/pull/14237) [BUGFIX] Ensure Engine Routes are deactivated before destruction
| false |
Other
|
emberjs
|
ember.js
|
d2836d09ceb36b8beaa8c6acbd226ea1dbab9cf9.json
|
Fix typo on FEATURES.md
|
FEATURES.md
|
@@ -53,4 +53,4 @@ to stay in line with ES standards (see [RFC](https://github.com/emberjs/rfcs/blo
* `ember-testing-check-waiters`
Expose a simple mechanism for test tooling to determine if all foreign async has been
-handled before continueing the test. Replaces the intimate API `Ember.Test.waiters` (with a deprecation).
+handled before continuing the test. Replaces the intimate API `Ember.Test.waiters` (with a deprecation).
| false |
Other
|
emberjs
|
ember.js
|
05fd9165c53b7e9e1c77d5e1ee1d0955b3c0bc09.json
|
Make attr.actionFn work
|
packages/ember-glimmer/lib/helpers/action.js
|
@@ -13,6 +13,7 @@ import {
} from 'ember-metal';
export const INVOKE = symbol('INVOKE');
+export const ACTION = symbol('ACTION');
/**
The `{{action}}` helper provides a way to pass triggers for behavior (usually
@@ -373,5 +374,6 @@ export function createClosureAction(target, action, valuePath, actionArgs) {
};
}
+ closureAction[ACTION] = true;
return closureAction;
}
| true |
Other
|
emberjs
|
ember.js
|
05fd9165c53b7e9e1c77d5e1ee1d0955b3c0bc09.json
|
Make attr.actionFn work
|
packages/ember-glimmer/lib/utils/process-args.js
|
@@ -3,6 +3,7 @@ import { CONSTANT_TAG } from 'glimmer-reference';
import { ARGS } from '../component';
import { UPDATE } from './references';
import { MUTABLE_CELL } from 'ember-views';
+import { ACTION } from '../helpers/action';
export default function processArgs(args, positionalParamsDefinition) {
if (!positionalParamsDefinition || positionalParamsDefinition.length === 0 || args.positional.length === 0) {
@@ -50,7 +51,9 @@ class SimpleArgs {
let ref = namedArgs.get(name);
let value = attrs[name];
- if (ref[UPDATE]) {
+ if (typeof value === 'function' && value[ACTION]) {
+ attrs[name] = value;
+ } else if (ref[UPDATE]) {
attrs[name] = new MutableCell(ref, value);
}
| true |
Other
|
emberjs
|
ember.js
|
05fd9165c53b7e9e1c77d5e1ee1d0955b3c0bc09.json
|
Make attr.actionFn work
|
packages/ember-glimmer/tests/integration/helpers/closure-action-test.js
|
@@ -970,7 +970,7 @@ moduleFor('Helpers test: closure {{action}}', class extends RenderingTest {
this.render('{{outer-component}}');
this.runTask(() => {
- innerComponent.fireAction();
+ actualReturnedValue = innerComponent.fireAction();
});
this.assert.equal(actualFirst, first, 'first argument is correct');
| true |
Other
|
emberjs
|
ember.js
|
36371e07fa7bff743e9ed15b1ee420845ed6be90.json
|
Remove unnecessary import of `metaFor`.
`watchKey` internally calls `metaFor` if no `meta` has been provided.
|
packages/ember-glimmer/lib/utils/references.js
|
@@ -4,7 +4,6 @@ import {
set,
tagFor,
didRender,
- meta as metaFor,
watchKey,
isFeatureEnabled,
runInDebug
@@ -152,7 +151,7 @@ export class RootPropertyReference extends PropertyReference {
}
if (isFeatureEnabled('mandatory-setter')) {
- watchKey(parentValue, propertyKey, metaFor(parentValue));
+ watchKey(parentValue, propertyKey);
}
}
@@ -201,8 +200,7 @@ export class NestedPropertyReference extends PropertyReference {
if (typeof parentValue === 'object' && parentValue) {
if (isFeatureEnabled('mandatory-setter')) {
- let meta = metaFor(parentValue);
- watchKey(parentValue, _propertyKey, meta);
+ watchKey(parentValue, _propertyKey);
}
if (isFeatureEnabled('ember-glimmer-detect-backtracking-rerender') ||
| false |
Other
|
emberjs
|
ember.js
|
7f8f8d7136d7392b96cc263ba124ceeb7995a4da.json
|
Fix typo in test
|
packages/ember-glimmer/tests/integration/components/utils-test.js
|
@@ -296,7 +296,7 @@ moduleFor('Bounds tests', class extends RenderingTest {
let { parentElement, firstNode, lastNode } = getViewBounds(component);
- assert.equal(parentElement, this.element, 'a regular component should have the right parentElement');
+ assert.equal(parentElement, this.element, 'a tagless component should have the right parentElement');
assert.equal(firstNode, this.$('#start-node')[0], 'a tagless component should have a range enclosing all of its nodes');
assert.equal(lastNode, this.$('#before-end-node')[0].nextSibling, 'a tagless component should have a range enclosing all of its nodes');
}
| false |
Other
|
emberjs
|
ember.js
|
29680aa6a94da74819af5e222bcda0991314feaf.json
|
move throw to warn for now.
|
index.js
|
@@ -23,7 +23,8 @@ module.exports = {
init: function() {
this._super.init && this._super.init.apply(this, arguments);
if ('ember' in this.project.bowerDependencies()) {
- throw new TypeError('Ember.js is now provided by node_module `ember-core`, please remove it from bower');
+ // TODO: move this to a throw soon.
+ this.ui.writeWarnLine('Ember.js is now provided by node_module `ember-core`, please remove it from bower');
}
},
| false |
Other
|
emberjs
|
ember.js
|
75876e5a1c20c9b20e0feca9038d71d3baeb0e48.json
|
Add getOwner/setOwner shims
|
vendor/ember/shims.js
|
@@ -132,6 +132,12 @@
'ember-object': {
'default': Ember.Object
},
+ 'ember-owner/get': {
+ 'default': Ember.getOwner
+ },
+ 'ember-owner/set': {
+ 'default': Ember.setOwner
+ },
'ember-platform': {
'assign': Ember.merge,
'create': Ember.create,
| false |
Other
|
emberjs
|
ember.js
|
bf3487086648b7d811806cfbd01c6b2836901251.json
|
provide jQuery for now
|
index.js
|
@@ -15,6 +15,7 @@ function add(paths, name, path) {
add(paths, 'prod', 'vendor/ember/ember.prod.js');
add(paths, 'debug', 'vendor/ember/ember.debug.js');
add(paths, 'shims', 'vendor/ember/shims.js');
+add(paths, 'jquery', 'vendor/ember/jquery/jquery.js');
add(absolutePaths, 'templateCompiler', __dirname + '/dist/ember-template-compiler.js');
@@ -33,15 +34,12 @@ module.exports = {
destDir: 'ember',
files: [
'ember-runtime.js',
- 'ember-runtime.map',
'ember-template-compiler.js',
- 'ember-template-compiler.map',
'ember-testing.js',
- 'ember.debug.cjs.js',
- 'ember.debug.cjs.map',
'ember.debug.js',
'ember.min.js',
- 'ember.prod.js'
+ 'ember.prod.js',
+ 'jquery/jquery.js'
]
});
| false |
Other
|
emberjs
|
ember.js
|
3d104c99337576331bc15ce24b344702dfa2ddc7.json
|
provide ember-source from NPM
* obviate the need to `bower install ember.js`
* provide an api for addons to retrieve paths to
ember.debug.js, ember.prod.js and
ember-template-compiler.js
|
index.js
|
@@ -1,6 +1,42 @@
/* jshint node: true */
'use strict';
+var stew = require('broccoli-stew');
+
+var paths = {};
+var absolutePaths = {};
+
+function add(paths, name, path) {
+ Object.defineProperty(paths, name, {
+ configurable: false,
+ get: function() { return path; }
+ });
+}
+
+add(paths, 'prod', 'vendor/ember/ember.prod.js');
+add(paths, 'debug', 'vendor/ember/ember.debug.js');
+
+add(absolutePaths, 'templateCompiler', __dirname + '/dist/ember-template-compiler.js');
module.exports = {
- name: 'ember'
+ name: 'ember-source',
+ paths: paths,
+ absolutePaths: absolutePaths,
+ treeForVendor: function() {
+ return stew.find(__dirname + '/dist', {
+ destDir: 'ember',
+ files: [
+ 'ember-runtime.js',
+ 'ember-runtime.map',
+ 'ember-template-compiler.js',
+ 'ember-template-compiler.map',
+ 'ember-testing.js',
+ 'ember.debug.cjs.js',
+ 'ember.debug.cjs.map',
+ 'ember.debug.js',
+ 'ember.min.js',
+ 'ember.prod.js',
+ // 'shims/shims.js'
+ ]
+ });
+ }
};
| true |
Other
|
emberjs
|
ember.js
|
3d104c99337576331bc15ce24b344702dfa2ddc7.json
|
provide ember-source from NPM
* obviate the need to `bower install ember.js`
* provide an api for addons to retrieve paths to
ember.debug.js, ember.prod.js and
ember-template-compiler.js
|
package.json
|
@@ -1,5 +1,5 @@
{
- "name": "ember",
+ "name": "ember-source",
"license": "MIT",
"version": "2.10.0",
"keywords": [
@@ -61,6 +61,8 @@
"ember-cli-path-utils": "^1.0.0",
"ember-cli-string-utils": "^1.0.0",
"ember-cli-test-info": "^1.0.0",
- "ember-cli-valid-component-name": "^1.0.0"
+ "ember-cli-valid-component-name": "^1.0.0",
+ "simple-dom": "^0.3.0",
+ "broccoli-stew": "^1.2.0"
}
}
| true |
Other
|
emberjs
|
ember.js
|
e91b8ac2284fc2b6c7aaa310574cb94ca4f796d0.json
|
Add failing test for #14332
|
packages/ember-glimmer/tests/integration/syntax/each-test.js
|
@@ -1,7 +1,7 @@
import { get, set, propertyDidChange } from 'ember-metal';
import { applyMixins, strip } from '../../utils/abstract-test-case';
import { moduleFor, RenderingTest } from '../../utils/test-case';
-import { A as emberA, ArrayProxy } from 'ember-runtime';
+import { A as emberA, ArrayProxy, RSVP } from 'ember-runtime';
import {
TogglingSyntaxConditionalsTest,
@@ -884,3 +884,101 @@ moduleFor('Syntax test: {{#each as}} undefined path', class extends RenderingTes
this.assertText('');
}
});
+
+/* globals MutationObserver: false */
+if (typeof MutationObserver === 'function') {
+ moduleFor('Syntax test: {{#each as}} DOM mutation test', class extends RenderingTest {
+ constructor() {
+ super();
+ this.observer = null;
+ }
+
+ observe(element) {
+ let observer = this.observer = new MutationObserver(function() {});
+ observer.observe(element, { childList: true });
+ }
+
+ teardown() {
+ if (this.observer) {
+ this.observer.disconnect();
+ }
+
+ super.teardown();
+ }
+
+ assertNoMutation() {
+ this.assert.deepEqual(this.observer.takeRecords(), [], 'Expected no mutations');
+ }
+
+ expectMutations() {
+ this.assert.ok(this.observer.takeRecords().length > 0, 'Expected some mutations');
+ }
+
+ ['@test {{#each}} should not mutate a subtree when the array has not changed [GH #14332]'](assert) {
+ let page = { title: 'Blog Posts' };
+
+ let model = [
+ { title: 'Rails is omakase' },
+ { title: 'Ember is omakase' }
+ ];
+
+ this.render(strip`
+ <h1>{{page.title}}</h1>
+
+ <ul id="posts">
+ {{#each model as |post|}}
+ <li>{{post.title}}</li>
+ {{/each}}
+ </ul>
+ `, { page, model });
+
+ this.assertHTML(strip`
+ <h1>Blog Posts</h1>
+
+ <ul id="posts">
+ <li>Rails is omakase</li>
+ <li>Ember is omakase</li>
+ </ul>
+ `);
+
+ this.observe(this.$('#posts')[0]);
+
+ // MutationObserver is async
+ return RSVP.Promise.resolve(() => {
+ this.assertStableRerender();
+ }).then(() => {
+ this.assertNoMutation();
+
+ this.runTask(() => set(this.context, 'page', { title: 'Essays' }));
+
+ this.assertHTML(strip`
+ <h1>Essays</h1>
+
+ <ul id="posts">
+ <li>Rails is omakase</li>
+ <li>Ember is omakase</li>
+ </ul>
+ `);
+ }).then(() => {
+ // 'page' and 'model' is keyed off the same object, so we do expect Glimmer
+ // to re-iterate the list
+ this.expectMutations();
+
+ this.runTask(() => set(this.context.page, 'title', 'Think Pieces™'));
+
+ this.assertHTML(strip`
+ <h1>Think Pieces™</h1>
+
+ <ul id="posts">
+ <li>Rails is omakase</li>
+ <li>Ember is omakase</li>
+ </ul>
+ `);
+ }).then(() => {
+ // The last set is localized to the `page` object, so we do not expect Glimmer
+ // to re-iterate the list
+ this.assertNoMutation();
+ });
+ }
+ });
+}
| false |
Other
|
emberjs
|
ember.js
|
0329e036952c5c2839ea61ed5e23cf8b0c615ba9.json
|
Remove duplicated comments
|
packages/ember-glimmer/lib/component.js
|
@@ -307,24 +307,6 @@ const Component = CoreView.extend(
@since 1.13.0
*/
- /**
- Called when the attributes passed into the component have been updated.
- Called both during the initial render of a container and during a rerender.
- Can be used in place of an observer; code placed here will be executed
- every time any attribute updates.
- @event didReceiveAttrs
- @public
- @since 1.13.0
- */
-
- /**
- Called after a component has been rendered, both on initial render and
- in subsequent rerenders.
- @method didRender
- @public
- @since 1.13.0
- */
-
/**
Called after a component has been rendered, both on initial render and
in subsequent rerenders.
@@ -333,14 +315,6 @@ const Component = CoreView.extend(
@since 1.13.0
*/
- /**
- Called before a component has been rendered, both on initial render and
- in subsequent rerenders.
- @method willRender
- @public
- @since 1.13.0
- */
-
/**
Called before a component has been rendered, both on initial render and
in subsequent rerenders.
@@ -349,14 +323,6 @@ const Component = CoreView.extend(
@since 1.13.0
*/
- /**
- Called when the attributes passed into the component have been changed.
- Called only during a rerender, not during an initial render.
- @method didUpdateAttrs
- @public
- @since 1.13.0
- */
-
/**
Called when the attributes passed into the component have been changed.
Called only during a rerender, not during an initial render.
@@ -365,14 +331,6 @@ const Component = CoreView.extend(
@since 1.13.0
*/
- /**
- Called when the component is about to update and rerender itself.
- Called only during a rerender, not during an initial render.
- @method willUpdate
- @public
- @since 1.13.0
- */
-
/**
Called when the component is about to update and rerender itself.
Called only during a rerender, not during an initial render.
@@ -381,14 +339,6 @@ const Component = CoreView.extend(
@since 1.13.0
*/
- /**
- Called when the component has updated and rerendered itself.
- Called only during a rerender, not during an initial render.
- @method didUpdate
- @public
- @since 1.13.0
- */
-
/**
Called when the component has updated and rerendered itself.
Called only during a rerender, not during an initial render.
| false |
Other
|
emberjs
|
ember.js
|
8ebdf85591737f23b0c100cfe537bf1a2b6065ed.json
|
Update glimmer-engine to 0.17.0.
|
package.json
|
@@ -43,7 +43,7 @@
"git-repo-info": "^1.1.4",
"git-repo-version": "^0.3.1",
"github": "^0.2.3",
- "glimmer-engine": "0.15.0",
+ "glimmer-engine": "0.17.0",
"glob": "^5.0.13",
"html-differ": "^1.3.4",
"mocha": "^2.4.5",
| false |
Other
|
emberjs
|
ember.js
|
2c430bd3270bc522f6a76828534fbb33902d9882.json
|
Update CHANGELOG.md for 2.8.1.
[ci skip]
|
CHANGELOG.md
|
@@ -17,6 +17,16 @@
- [#14156](https://github.com/emberjs/ember.js/pull/14156) [FEATURE ember-glimmer] Enable by default.
+### 2.8.1 (September 14, 2016)
+
+- [#14184](https://github.com/emberjs/ember.js/pull/14184) [BUGFIX] Ensure that promises that reject with non Errors (i.e. something without a `.stack`) do not trigger an error during Ember's internal error processing.
+- [#14237](https://github.com/emberjs/ember.js/pull/14237) [BUGFIX] Ensure Engine Routes are deactivated before destruction.
+- [#14262](https://github.com/emberjs/ember.js/pull/14262) [BUGFIX] Ensure Controller#transitionToRoute and Route#intermediateTransitionTo work in Engines.
+- [#14272](https://github.com/emberjs/ember.js/pull/14272) [BUGFIX] Bump router.js to v1.2.1.
+- [#14281](https://github.com/emberjs/ember.js/pull/14281) [BUGFIX] Ensure referencing `parentView` in a computed property / observer dependent key (or in the template) does not cause an error during teardown.
+- [#14281](https://github.com/emberjs/ember.js/pull/14281) [BUGFIX] Prevent errors from scheduling a rerender (by setting a property in `willDestroyElement`) after a component is destroyed.
+- [#14291](https://github.com/emberjs/ember.js/pull/14291) [BUGFIX] Fix component action bubbling semantics. Actions should not bubble out of a component when returning `true`.
+
### 2.8.0 (September 8, 2016)
- [#14229](https://github.com/emberjs/ember.js/pull/14229) [BUGFIX] Fix boot errors with `location: 'auto'` when using IE9.
| false |
Other
|
emberjs
|
ember.js
|
4e0a23ab93815b704ac762c793aa324039dfe2b6.json
|
Add failing test for appendTo while rendering
|
packages/ember-glimmer/tests/integration/components/append-test.js
|
@@ -251,6 +251,41 @@ moduleFor('appendTo: an element', class extends AbstractAppendTest {
});
+moduleFor('appendTo: with multiple components', class extends AbstractAppendTest {
+
+ append(component) {
+ this.runTask(() => component.appendTo('#qunit-fixture'));
+ this.didAppend(component);
+ return jQuery('#qunit-fixture')[0];
+ }
+
+ ['@test can appendTo while rendering'](assert) {
+ assert.expect(0);
+
+ let owner = this.owner;
+
+ this.registerComponent('first-component', {
+ ComponentClass: Component.extend({
+ layoutName: 'components/component-one',
+
+ didInsertElement() {
+ let SecondComponent = owner._lookupFactory('component:second-component');
+ SecondComponent.create().appendTo('#qunit-fixture');
+ }
+ })
+ });
+
+ this.registerComponent('second-component', {
+ ComponentClass: Component.extend()
+ });
+
+ let FirstComponent = this.owner._lookupFactory('component:first-component');
+
+ this.append(FirstComponent.create());
+ }
+
+});
+
moduleFor('renderToElement: no arguments (defaults to a body context)', class extends AbstractAppendTest {
append(component) {
| false |
Other
|
emberjs
|
ember.js
|
9453cfd562072e32ee28e0851d8b3b4ee54ad365.json
|
Add 2.9.0-beta.2 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -1,5 +1,18 @@
# Ember Changelog
+### 2.9.0-beta.2 (September 12, 2016)
+
+- [#14237](https://github.com/emberjs/ember.js/pull/14237) [BUGFIX] Ensure Engine Routes are deactivated before destruction
+- [#14176](https://github.com/emberjs/ember.js/pull/14176) [BUGFIX] Ensure Controller#transitionToRoute and Route#intermediateTransitionTo work in Engines
+- [#14244](https://github.com/emberjs/ember.js/pull/14244) [BUGFIX] Ensure params and hash are frozen in debug builds.
+- [#14245](https://github.com/emberjs/ember.js/pull/14245) [BUGFIX] Lookup partials from the current owner when rendering an Engines templates.
+- [#14247](https://github.com/emberjs/ember.js/pull/14247) [BUGFIX] Make `this.getAttr` an alias for `this.get`.
+- [#14252](https://github.com/emberjs/ember.js/pull/14252) [BUGFIX] Don't delete moduleName from the generated template compilation options.
+- [#14253](https://github.com/emberjs/ember.js/pull/14253) [BUGFIX] Prevent duplicated `Ember.meta` invocations.
+- [#14271](https://github.com/emberjs/ember.js/pull/14271) [BUGFIX] Ensure `undefined` and `null` values are not rendered as attributes or properties on initial render.
+- [#14272](https://github.com/emberjs/ember.js/pull/14272) [BUGFIX] Fix issues with `Transition#isActive` being falsey incorrectly.
+
+
### 2.9.0-beta.1 (September 8, 2016)
- [#14156](https://github.com/emberjs/ember.js/pull/14156) [FEATURE ember-glimmer] Enable by default.
| false |
Other
|
emberjs
|
ember.js
|
9cbda8f9ad059a98f08faf72f0df1468963eeb49.json
|
Add usage info to ember-utils entry point.
|
packages/ember-utils/lib/index.js
|
@@ -1,3 +1,13 @@
+/*
+ This package will be eagerly parsed and should have no dependencies on external
+ packages.
+
+ It is intended to be used to share utility methods that will be needed
+ by every Ember application (and is **not** a dumping ground of useful utilities).
+
+ Utility methods that are needed in < 80% of cases should be placed
+ elsewhere (so they can be lazily evaluated / parsed).
+*/
export { default as symbol } from './symbol';
export { getOwner, setOwner, OWNER } from './owner';
export { default as assign } from './assign';
| false |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/container/lib/index.js
|
@@ -10,4 +10,3 @@ export {
default as Container,
buildFakeContainerWithDeprecations
} from './container';
-export { OWNER, getOwner, setOwner } from 'ember-utils';
| true |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/container/lib/registry.js
|
@@ -1,4 +1,5 @@
import { dictionary, EmptyObject, assign, intern } from 'ember-utils';
+import { assert, deprecate } from 'ember-metal';
import Container from './container';
const VALID_FULL_NAME_REGEXP = /^[^:]+:[^:]+$/;
| true |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/ember-metal/lib/index.js
|
@@ -10,7 +10,6 @@ export {
ComputedProperty
} from './computed';
export { default as alias } from './alias';
-export { default as assign } from './assign';
export { default as merge } from './merge';
export {
assert,
@@ -33,20 +32,6 @@ export {
subscribe as instrumentationSubscribe,
unsubscribe as instrumentationUnsubscribe
} from './instrumentation';
-export {
- intern,
- GUID_KEY,
- GUID_KEY_PROPERTY,
- applyStr,
- canInvoke,
- generateGuid,
- guidFor,
- inspect,
- makeArray,
- tryInvoke,
- uuid,
- wrap
-} from 'ember-utils';
export {
isTesting,
setTesting
@@ -172,9 +157,6 @@ export {
export {
isGlobalPath
} from './path_cache';
-export { default as symbol } from './symbol';
-export { default as dictionary } from './dictionary';
-export { default as EmptyObject } from './empty_object';
export { default as InjectedProperty } from './injected_property';
export {
setHasViews,
| true |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/ember-runtime/lib/system/string.js
|
@@ -4,9 +4,9 @@
*/
import {
deprecate,
- inspect as emberInspect,
Cache
} from 'ember-metal';
+import { inspect } from 'ember-utils';
import { isArray } from '../utils';
import {
get as getString
@@ -90,7 +90,7 @@ function _fmt(str, formats) {
return str.replace(/%@([0-9]+)?/g, function(s, argIndex) {
argIndex = (argIndex) ? parseInt(argIndex, 10) - 1 : idx++;
s = cachedFormats[argIndex];
- return (s === null) ? '(null)' : (s === undefined) ? '' : emberInspect(s);
+ return (s === null) ? '(null)' : (s === undefined) ? '' : inspect(s);
});
}
| true |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/ember-template-compiler/lib/index.js
|
@@ -1,5 +1,3 @@
-import 'container';
-
import _Ember, { FEATURES } from 'ember-metal';
import { ENV } from 'ember-environment';
import VERSION from 'ember/version';
| true |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/ember-utils/lib/owner.js
|
@@ -3,7 +3,7 @@
@submodule ember-runtime
*/
-import { symbol } from 'ember-metal';
+import symbol from './symbol';
export const OWNER = symbol('OWNER');
| true |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/ember-utils/lib/symbol.js
|
@@ -1,4 +1,5 @@
-import { GUID_KEY, intern } from './index';
+import { GUID_KEY } from './guid';
+import intern from './intern';
export default function symbol(debugName) {
// TODO: Investigate using platform symbols, but we do not
| true |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/ember-views/lib/system/utils.js
|
@@ -1,3 +1,4 @@
+/* globals Element */
import { guidFor, symbol, getOwner } from 'ember-utils';
/**
| true |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/ember/lib/index.js
|
@@ -1,14 +1,32 @@
-import { getOwner, setOwner } from 'ember-utils';
import require, { has } from 'require';
// ****ember-environment****
import { ENV, context } from 'ember-environment';
+import * as utils from 'ember-utils';
import { Registry, Container } from 'container';
// ****ember-metal****
import Ember, * as metal from 'ember-metal';
+// ember-utils exports
+Ember.getOwner = utils.getOwner;
+Ember.setOwner = utils.setOwner;
+Ember.generateGuid = utils.generateGuid;
+Ember.GUID_KEY = utils.GUID_KEY;
+Ember.guidFor = utils.guidFor;
+Ember.inspect = utils.inspect;
+Ember.makeArray = utils.makeArray;
+Ember.canInvoke = utils.canInvoke;
+Ember.tryInvoke = utils.tryInvoke;
+Ember.wrap = utils.wrap;
+Ember.applyStr = utils.applyStr;
+Ember.uuid = utils.uuid;
+
+// container exports
+Ember.Container = Container;
+Ember.Registry = Registry;
+
// need to import this directly, to ensure the babel feature
// flag plugin works properly
import {
@@ -41,17 +59,6 @@ Ember.Instrumentation = {
reset: metal.instrumentationReset
};
-Ember.generateGuid = metal.generateGuid;
-Ember.GUID_KEY = metal.GUID_KEY;
-Ember.guidFor = metal.guidFor;
-Ember.inspect = metal.inspect;
-
-Ember.makeArray = metal.makeArray;
-Ember.canInvoke = metal.canInvoke;
-Ember.tryInvoke = metal.tryInvoke;
-Ember.wrap = metal.wrap;
-Ember.applyStr = metal.applyStr;
-Ember.uuid = metal.uuid;
Ember.Error = metal.Error;
Ember.META_DESC = metal.META_DESC;
Ember.meta = metal.meta;
@@ -251,11 +258,6 @@ Ember.Backburner = function() {
Ember._Backburner = Backburner;
-Ember.Container = Container;
-Ember.Registry = Registry;
-Ember.getOwner = getOwner;
-Ember.setOwner = setOwner;
-
import Logger from 'ember-console';
Ember.Logger = Logger;
| true |
Other
|
emberjs
|
ember.js
|
0667fd3d02f45a93cfd00a7e99192c630291127d.json
|
Fix global reexports for ember-utils.
|
packages/ember/tests/reexports_test.js
|
@@ -5,12 +5,25 @@ import { isFeatureEnabled } from 'ember-metal';
QUnit.module('ember reexports');
[
+ // ember-utils
+ ['getOwner', 'ember-utils', 'getOwner'],
+ ['setOwner', 'ember-utils', 'setOwner'],
+ // ['assign', 'ember-metal'], TODO: fix this test, we use `Object.assign` if present
+ ['GUID_KEY', 'ember-utils'],
+ ['uuid', 'ember-utils'],
+ ['generateGuid', 'ember-utils'],
+ ['guidFor', 'ember-utils'],
+ ['inspect', 'ember-utils'],
+ ['makeArray', 'ember-utils'],
+ ['canInvoke', 'ember-utils'],
+ ['tryInvoke', 'ember-utils'],
+ ['wrap', 'ember-utils'],
+ ['applyStr', 'ember-utils'],
+
// ember-environment
// ['ENV', 'ember-environment', 'ENV'], TODO: fix this, its failing because we are hitting the getter
// container
- ['getOwner', 'container', 'getOwner'],
- ['setOwner', 'container', 'setOwner'],
['Registry', 'container', 'Registry'],
['Container', 'container', 'Container'],
@@ -25,23 +38,12 @@ QUnit.module('ember reexports');
['warn', 'ember-metal'],
['debug', 'ember-metal'],
['runInDebug', 'ember-metal'],
- // ['assign', 'ember-metal'], TODO: fix this test, we use `Object.assign` if present
['merge', 'ember-metal'],
['instrument', 'ember-metal'],
['Instrumentation.instrument', 'ember-metal', 'instrument'],
['Instrumentation.subscribe', 'ember-metal', 'instrumentationSubscribe'],
['Instrumentation.unsubscribe', 'ember-metal', 'instrumentationUnsubscribe'],
['Instrumentation.reset', 'ember-metal', 'instrumentationReset'],
- ['generateGuid', 'ember-metal'],
- ['GUID_KEY', 'ember-metal'],
- ['guidFor', 'ember-metal'],
- ['inspect', 'ember-metal'],
- ['makeArray', 'ember-metal'],
- ['canInvoke', 'ember-metal'],
- ['tryInvoke', 'ember-metal'],
- ['wrap', 'ember-metal'],
- ['applyStr', 'ember-metal'],
- ['uuid', 'ember-metal'],
['testing', 'ember-metal', { get: 'isTesting', set: 'setTesting' }],
['onerror', 'ember-metal', { get: 'getOnerror', set: 'setOnerror' }],
// ['create'], TODO: figure out what to do here
| true |
Other
|
emberjs
|
ember.js
|
cb917916c9c69ad44e02905d7961f812b7aceab9.json
|
Add 2.9.0-beta.1 to CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### 2.9.0-beta.1 (September 8, 2012)
+
+- [#14156](https://github.com/emberjs/ember.js/pull/14156) [FEATURE ember-glimmer] Enable by default.
+
### 2.8.0 (September 8, 2016)
- [#14229](https://github.com/emberjs/ember.js/pull/14229) [BUGFIX] Fix boot errors with `location: 'auto'` when using IE9.
| false |
Other
|
emberjs
|
ember.js
|
f9a9dca98f028f22c6817983d77b6606994c5a43.json
|
Update CHANGELOG.md for 2.8.0.
[ci skip]
|
CHANGELOG.md
|
@@ -1,11 +1,10 @@
# Ember Changelog
-### 2.8.0-beta.5 (August 30, 2016)
+### 2.8.0 (September 8, 2016)
+- [#14229](https://github.com/emberjs/ember.js/pull/14229) [BUGFIX] Fix boot errors with `location: 'auto'` when using IE9.
+- [#14219](https://github.com/emberjs/ember.js/pull/14219) [BUGFIX] Fix issue with template meta (i.e. compiled template `moduleName`) was being mutated during the rendering process.
- [#14159](https://github.com/emberjs/ember.js/pull/14159) [BUGFIX] Fix rendering system cleanup.
-
-### 2.8.0-beta.4 (August 29, 2016)
-
- [#14123](https://github.com/emberjs/ember.js/pull/14123) [BUGFIX] Avoid rerendering outlet state during router destruction.
- [#14077](https://github.com/emberjs/ember.js/pull/14077) [BUGFIX] Update route-recognizer.
- [#14087](https://github.com/emberjs/ember.js/pull/14087) [BUGFIX] Check that route handler exists before triggering actions.
@@ -14,29 +13,18 @@
- [#14117](https://github.com/emberjs/ember.js/pull/14117) [BUGFIX] Call ArrayProxy's content change hooks
- [#14135](https://github.com/emberjs/ember.js/pull/14135) [BUGFIX] Fix issues around Engine setup and teardown.
- [#14140](https://github.com/emberjs/ember.js/pull/14140) [BUGFIX] Ensure component injections happen in engine instances.
-
-
-### 2.8.0-beta.3 (August 15, 2016)
-
- [#14009](https://github.com/emberjs/ember.js/pull/14009) [BUGFIX] Fix usage of `role` when used in `attributeBindings`.
- [#14044](https://github.com/emberjs/ember.js/pull/14044) / [#14062](https://github.com/emberjs/ember.js/pull/14062) / [#14066](https://github.com/emberjs/ember.js/pull/14066) [BUGFIX] Update `router.js` so that `getHandlers` is invoked lazily.
- [#14054](https://github.com/emberjs/ember.js/pull/14054) [BUGFIX] Ensure substates properly work with `resetNamespace`.
- [#14033](https://github.com/emberjs/ember.js/pull/14033) [BUGFIX] Ensure `fillIn` acceptance test helper only sets value to first matched element.
- [#14058](https://github.com/emberjs/ember.js/pull/14058) [BUGFIX] Fix issues related to `Ember.Router.map` changes in 2.7.0.
- [#14068](https://github.com/emberjs/ember.js/pull/14068) [BUGFIX] Prevent errors when clicking a `{{link-to}}` during an existing transition.
-
-
-### 2.8.0-beta.2 (August 1, 2016)
-
- [#13887](https://github.com/emberjs/ember.js/pull/13887) [BUGFIX] Add assertions for illegal component invocations.
- [#13892](https://github.com/emberjs/ember.js/pull/13892) [CLEANUP] Remove `View#createElement` / `View#destroyElement`.
- [#13895](https://github.com/emberjs/ember.js/pull/13895) [BUGFIX] Fix template meta lookup for nested tagless and blockless components.
- [#13911](https://github.com/emberjs/ember.js/pull/13911) [BUGFIX] Avoid using clobbering `.env` property on components.
- [#13913](https://github.com/emberjs/ember.js/pull/13913) [BUGFIX] Disallow paths beginning with @ in templates.
- [#13920](https://github.com/emberjs/ember.js/pull/13920) [BUGFIX] Add more info to the `Ember.Binding` deprecation.
-
-### 2.8.0-beta.1 (July 25, 2016)
-
- [#13757](https://github.com/emberjs/ember.js/pull/13757) / [#13773](https://github.com/emberjs/ember.js/pull/13773) [CLEANUP] Remove legacy view layer features.
- [#13819](https://github.com/emberjs/ember.js/pull/13819) [DOC] Add documentation for container (getOwner, etc.)
- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-string-ishtmlsafe] Enable by defaut.
| false |
Other
|
emberjs
|
ember.js
|
97601d01a05ea9f1e81e70ad24437736367d9833.json
|
Update glimmer-engine to 0.12.1.
|
package.json
|
@@ -43,7 +43,7 @@
"git-repo-info": "^1.1.4",
"git-repo-version": "^0.3.1",
"github": "^0.2.3",
- "glimmer-engine": "0.12.0",
+ "glimmer-engine": "0.12.1",
"glob": "^5.0.13",
"html-differ": "^1.3.4",
"mocha": "^2.4.5",
| false |
Other
|
emberjs
|
ember.js
|
128476187aeffc3708efab6fbb99d248f6461507.json
|
Fix siblings order for async hooks
Closes #13972
Requires corresponding Glimmer change
|
packages/ember-glimmer/tests/integration/components/life-cycle-test.js
|
@@ -1,4 +1,4 @@
-import { set, run } from 'ember-metal';
+import { set, setProperties, run } from 'ember-metal';
import { Component } from '../../utils/helpers';
import { strip } from '../../utils/abstract-test-case';
import { moduleFor, RenderingTest } from '../../utils/test-case';
@@ -276,8 +276,6 @@ class LifeCycleHooksTest extends RenderingTest {
this.assertText('Twitter: @tomdale|Name: Tom Dale|Website: tomdale.net');
- bottomAttrs = { oldAttrs: { website: 'tomdale.net' }, newAttrs: { website: 'tomdale.net' } };
-
this.assertHooks(
'after no-op rerender (middle)',
@@ -303,9 +301,6 @@ class LifeCycleHooksTest extends RenderingTest {
this.assertText('Twitter: @tomdale|Name: Tom Dale|Website: tomdale.net');
- middleAttrs = { oldAttrs: { name: 'Tom Dale' }, newAttrs: { name: 'Tom Dale' } };
-
-
this.assertHooks(
'after no-op rerender (top)',
@@ -366,6 +361,260 @@ class LifeCycleHooksTest extends RenderingTest {
});
}
+ ['@test lifecycle hooks are invoked in a correct sibling order']() {
+ let { attr, invoke } = this.boundHelpers;
+
+ this.registerComponent('the-parent', { template: strip`
+ <div>
+ ${invoke('the-first-child', { twitter: expr(attr('twitter')) })}|
+ ${invoke('the-second-child', { name: expr(attr('name')) })}|
+ ${invoke('the-last-child', { website: expr(attr('website')) })}
+ </div>`
+ });
+
+ this.registerComponent('the-first-child', { template: `Twitter: {{${attr('twitter')}}}` });
+
+ this.registerComponent('the-second-child', { template: `Name: {{${attr('name')}}}` });
+
+ this.registerComponent('the-last-child', { template: `Website: {{${attr('website')}}}` });
+
+ this.render(invoke('the-parent', {
+ twitter: expr('twitter'),
+ name: expr('name'),
+ website: expr('website')
+ }), {
+ twitter: '@tomdale',
+ name: 'Tom Dale',
+ website: 'tomdale.net'
+ });
+
+ this.assertText('Twitter: @tomdale|Name: Tom Dale|Website: tomdale.net');
+ this.assertRegisteredViews('intial render');
+
+ let parentAttrs = { twitter: '@tomdale', name: 'Tom Dale', website: 'tomdale.net' };
+ let firstAttrs = { twitter: '@tomdale' };
+ let secondAttrs = { name: 'Tom Dale' };
+ let lastAttrs = { website: 'tomdale.net' };
+
+ this.assertHooks(
+
+ 'after initial render',
+
+ // Sync hooks
+
+ ['the-parent', 'init'],
+ ['the-parent', 'didInitAttrs', { attrs: parentAttrs }],
+ ['the-parent', 'didReceiveAttrs', { newAttrs: parentAttrs }],
+ ['the-parent', 'willRender'],
+
+ ['the-first-child', 'init'],
+ ['the-first-child', 'didInitAttrs', { attrs: firstAttrs }],
+ ['the-first-child', 'didReceiveAttrs', { newAttrs: firstAttrs }],
+ ['the-first-child', 'willRender'],
+
+ ['the-second-child', 'init'],
+ ['the-second-child', 'didInitAttrs', { attrs: secondAttrs }],
+ ['the-second-child', 'didReceiveAttrs', { newAttrs: secondAttrs }],
+ ['the-second-child', 'willRender'],
+
+ ['the-last-child', 'init'],
+ ['the-last-child', 'didInitAttrs', { attrs: lastAttrs }],
+ ['the-last-child', 'didReceiveAttrs', { newAttrs: lastAttrs }],
+ ['the-last-child', 'willRender'],
+
+ // Async hooks
+
+ ['the-first-child', 'didInsertElement'],
+ ['the-first-child', 'didRender'],
+
+ ['the-second-child', 'didInsertElement'],
+ ['the-second-child', 'didRender'],
+
+ ['the-last-child', 'didInsertElement'],
+ ['the-last-child', 'didRender'],
+
+ ['the-parent', 'didInsertElement'],
+ ['the-parent', 'didRender']
+
+ );
+
+ this.runTask(() => this.components['the-first-child'].rerender());
+
+ this.assertText('Twitter: @tomdale|Name: Tom Dale|Website: tomdale.net');
+
+ this.assertHooks(
+
+ 'after no-op rerender (first child)',
+
+ // Sync hooks
+
+ ['the-parent', 'willUpdate'],
+ ['the-parent', 'willRender'],
+
+ ['the-first-child', 'willUpdate'],
+ ['the-first-child', 'willRender'],
+
+ // Async hooks
+
+ ['the-first-child', 'didUpdate'],
+ ['the-first-child', 'didRender'],
+
+ ['the-parent', 'didUpdate'],
+ ['the-parent', 'didRender']
+
+ );
+
+ this.runTask(() => this.components['the-second-child'].rerender());
+
+ this.assertText('Twitter: @tomdale|Name: Tom Dale|Website: tomdale.net');
+
+ this.assertHooks(
+
+ 'after no-op rerender (second child)',
+
+ // Sync hooks
+
+ ['the-parent', 'willUpdate'],
+ ['the-parent', 'willRender'],
+
+ ['the-second-child', 'willUpdate'],
+ ['the-second-child', 'willRender'],
+
+ // Async hooks
+
+ ['the-second-child', 'didUpdate'],
+ ['the-second-child', 'didRender'],
+
+ ['the-parent', 'didUpdate'],
+ ['the-parent', 'didRender']
+
+ );
+
+ this.runTask(() => this.components['the-last-child'].rerender());
+
+ this.assertText('Twitter: @tomdale|Name: Tom Dale|Website: tomdale.net');
+
+ this.assertHooks(
+
+ 'after no-op rerender (last child)',
+
+ // Sync hooks
+
+ ['the-parent', 'willUpdate'],
+ ['the-parent', 'willRender'],
+
+ ['the-last-child', 'willUpdate'],
+ ['the-last-child', 'willRender'],
+
+ // Async hooks
+
+ ['the-last-child', 'didUpdate'],
+ ['the-last-child', 'didRender'],
+
+ ['the-parent', 'didUpdate'],
+ ['the-parent', 'didRender']
+
+ );
+
+ this.runTask(() => this.components['the-parent'].rerender());
+
+ this.assertText('Twitter: @tomdale|Name: Tom Dale|Website: tomdale.net');
+
+ this.assertHooks(
+
+ 'after no-op rerender (parent)',
+
+ // Sync hooks
+
+ ['the-parent', 'willUpdate'],
+ ['the-parent', 'willRender'],
+
+ // Async hooks
+
+ ['the-parent', 'didUpdate'],
+ ['the-parent', 'didRender']
+
+ );
+
+ this.runTask(() => setProperties(this.context, {
+ twitter: '@horsetomdale',
+ name: 'Horse Tom Dale',
+ website: 'horsetomdale.net'
+ }));
+
+ this.assertText('Twitter: @horsetomdale|Name: Horse Tom Dale|Website: horsetomdale.net');
+
+ parentAttrs = {
+ oldAttrs: { twitter: '@tomdale', name: 'Tom Dale', website: 'tomdale.net' },
+ newAttrs: { twitter: '@horsetomdale', name: 'Horse Tom Dale', website: 'horsetomdale.net' }
+ };
+ firstAttrs = { oldAttrs: { twitter: '@tomdale' }, newAttrs: { twitter: '@horsetomdale' } };
+ secondAttrs = { oldAttrs: { name: 'Tom Dale' }, newAttrs: { name: 'Horse Tom Dale' } };
+ lastAttrs = { oldAttrs: { website: 'tomdale.net' }, newAttrs: { website: 'horsetomdale.net' } };
+
+ this.assertHooks(
+
+ 'after update',
+
+ // Sync hooks
+
+ ['the-parent', 'didUpdateAttrs', parentAttrs],
+ ['the-parent', 'didReceiveAttrs', parentAttrs],
+
+ ['the-parent', 'willUpdate'],
+ ['the-parent', 'willRender'],
+
+ ['the-first-child', 'didUpdateAttrs', firstAttrs],
+ ['the-first-child', 'didReceiveAttrs', firstAttrs],
+
+ ['the-first-child', 'willUpdate'],
+ ['the-first-child', 'willRender'],
+
+ ['the-second-child', 'didUpdateAttrs', secondAttrs],
+ ['the-second-child', 'didReceiveAttrs', secondAttrs],
+
+ ['the-second-child', 'willUpdate'],
+ ['the-second-child', 'willRender'],
+
+ ['the-last-child', 'didUpdateAttrs', lastAttrs],
+ ['the-last-child', 'didReceiveAttrs', lastAttrs],
+
+ ['the-last-child', 'willUpdate'],
+ ['the-last-child', 'willRender'],
+
+ // Async hooks
+
+ ['the-first-child', 'didUpdate'],
+ ['the-first-child', 'didRender'],
+
+ ['the-second-child', 'didUpdate'],
+ ['the-second-child', 'didRender'],
+
+ ['the-last-child', 'didUpdate'],
+ ['the-last-child', 'didRender'],
+
+ ['the-parent', 'didUpdate'],
+ ['the-parent', 'didRender']
+
+ );
+
+ this.teardownAssertions.push(() => {
+ this.assertHooks(
+ 'destroy',
+ ['the-parent', 'willDestroyElement'],
+ ['the-parent', 'willClearRender'],
+ ['the-first-child', 'willDestroyElement'],
+ ['the-first-child', 'willClearRender'],
+ ['the-second-child', 'willDestroyElement'],
+ ['the-second-child', 'willClearRender'],
+ ['the-last-child', 'willDestroyElement'],
+ ['the-last-child', 'willClearRender']
+ );
+
+ this.assertRegisteredViews('after destroy');
+ });
+ }
+
['@test passing values through attrs causes lifecycle hooks to fire if the attribute values have changed']() {
let { attr, invoke } = this.boundHelpers;
| false |
Other
|
emberjs
|
ember.js
|
cb9f9c00f2614f97f5a1dc8222aff68e093f8675.json
|
Add 2.7.3 to the CHANGELOG.md.
[ci skip]
|
CHANGELOG.md
|
@@ -44,6 +44,15 @@
- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-runtime-enumerable-includes] Enable by default.
- [#13855](https://github.com/emberjs/ember.js/pull/13855) [FEATURE ember-testing-check-waiters] Enable by default.
+### 2.7.3 (September 6, 2016)
+
+- [#14219](https://github.com/emberjs/ember.js/pull/14219) [BUGFIX] Fix issue with mutating template's metadata.
+
+### 2.7.2 (August 30, 2016)
+
+- [#13895](https://github.com/emberjs/ember.js/pull/13895) [BUGFIX] Fix template meta lookup with tagless and blockless components.
+- [#14075](https://github.com/emberjs/ember.js/pull/14075) [BUGFIX] In which we revert route-recognizer to the version used in Ember 2.6. 😢
+
### 2.7.1 (August 15, 2016)
- [#13920](https://github.com/emberjs/ember.js/pull/13920) [BUGFIX] Add more info to the `Ember.Binding` deprecation.
| false |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/application_lifecycle_test.js
|
@@ -1,10 +1,13 @@
-import Application from 'ember-application/system/application';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
-import { Component, setTemplates, getTemplates } from 'ember-glimmer';
-import jQuery from 'ember-views/system/jquery';
+import { Application } from 'ember-application';
+import { Route, controllerFor } from 'ember-routing';
+import { run } from 'ember-metal';
+import {
+ Component,
+ setTemplates,
+ getTemplates
+} from 'ember-glimmer';
+import { jQuery } from 'ember-views';
import { compile } from 'ember-template-compiler';
-import controllerFor from 'ember-routing/system/controller_for';
let App, TEMPLATES, appInstance, router;
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/component_registration_test.js
|
@@ -1,11 +1,15 @@
-import Controller from 'ember-runtime/controllers/controller';
-import run from 'ember-metal/run_loop';
+import { Controller } from 'ember-runtime';
+import { run } from 'ember-metal';
-import Application from 'ember-application/system/application';
-import Router from 'ember-routing/system/router';
+import { Application } from 'ember-application';
+import { Router } from 'ember-routing';
import { compile } from 'ember-template-compiler';
-import { Component, setTemplates, setTemplate } from 'ember-glimmer';
-import jQuery from 'ember-views/system/jquery';
+import {
+ Component,
+ setTemplates,
+ setTemplate
+} from 'ember-glimmer';
+import { jQuery } from 'ember-views';
let App, appInstance;
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/controller_test.js
|
@@ -1,10 +1,14 @@
-import Controller from 'ember-runtime/controllers/controller';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
+import { Controller } from 'ember-runtime';
+import { Route } from 'ember-routing';
+import { run } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import { Component, setTemplates, setTemplate } from 'ember-glimmer';
-import jQuery from 'ember-views/system/jquery';
+import { Application } from 'ember-application';
+import {
+ Component,
+ setTemplates,
+ setTemplate
+} from 'ember-glimmer';
+import { jQuery } from 'ember-views';
/*
In Ember 1.x, controllers subtly affect things like template scope
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/global-api-test.js
|
@@ -1,5 +1,5 @@
-import get from 'ember-metal/property_get';
-import { isArray } from 'ember-runtime/utils';
+import { get } from 'ember-metal';
+import { isArray } from 'ember-runtime';
QUnit.module('Global API Tests');
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/helpers/helper_registration_test.js
|
@@ -1,12 +1,15 @@
-import Controller from 'ember-runtime/controllers/controller';
-import run from 'ember-metal/run_loop';
+import { Controller, Service, inject } from 'ember-runtime';
+import { run } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import { Helper, helper, setTemplates, setTemplate } from 'ember-glimmer';
-import Application from 'ember-application/system/application';
-import Router from 'ember-routing/system/router';
-import Service from 'ember-runtime/system/service';
-import jQuery from 'ember-views/system/jquery';
-import inject from 'ember-runtime/inject';
+import {
+ Helper,
+ helper,
+ setTemplates,
+ setTemplate
+} from 'ember-glimmer';
+import { Application } from 'ember-application';
+import { Router } from 'ember-routing';
+import { jQuery } from 'ember-views';
let App, appInstance;
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/helpers/link_to_test.js
|
@@ -1,18 +1,22 @@
import Logger from 'ember-console';
-import Controller from 'ember-runtime/controllers/controller';
-import { set } from 'ember-metal/property_set';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
-import { subscribe, reset } from 'ember-metal/instrumentation';
-import isEnabled from 'ember-metal/features';
-import alias from 'ember-metal/alias';
-import Application from 'ember-application/system/application';
-import jQuery from 'ember-views/system/jquery';
-import EmberObject from 'ember-runtime/system/object';
-import inject from 'ember-runtime/inject';
-import { A as emberA } from 'ember-runtime/system/native_array';
-import NoneLocation from 'ember-routing/location/none_location';
+import {
+ Controller,
+ Object as EmberObject,
+ inject,
+ A as emberA
+} from 'ember-runtime';
+import {
+ set,
+ run,
+ instrumentationSubscribe as subscribe,
+ instrumentationReset as reset,
+ isFeatureEnabled,
+ alias
+} from 'ember-metal';
+import { Route, NoneLocation } from 'ember-routing';
+import { Application } from 'ember-application';
+import { jQuery } from 'ember-views';
import { compile } from 'ember-template-compiler';
import { setTemplates, setTemplate } from 'ember-glimmer';
@@ -114,7 +118,7 @@ QUnit.test('The {{link-to}} helper moves into the named route', function() {
equal(jQuery('#home-link:not(.active)', '#qunit-fixture').length, 1, 'The other link was rendered without active class');
});
-if (isEnabled('ember-improved-instrumentation')) {
+if (isFeatureEnabled('ember-improved-instrumentation')) {
QUnit.test('The {{link-to}} helper fires an interaction event', function(assert) {
assert.expect(2);
Router.map(function(match) {
@@ -1296,7 +1300,7 @@ QUnit.test('{{link-to}} active property respects changing parent route context',
QUnit.test('{{link-to}} populates href with default query param values even without query-params object', function() {
- if (isEnabled('ember-routing-route-configured-query-params')) {
+ if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
App.IndexRoute = Route.extend({
queryParams: {
foo: {
@@ -1317,7 +1321,7 @@ QUnit.test('{{link-to}} populates href with default query param values even with
});
QUnit.test('{{link-to}} populates href with default query param values with empty query-params object', function() {
- if (isEnabled('ember-routing-route-configured-query-params')) {
+ if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
App.IndexRoute = Route.extend({
queryParams: {
foo: {
@@ -1342,7 +1346,7 @@ QUnit.test('{{link-to}} with only query-params and a block updates when route ch
this.route('about');
});
- if (isEnabled('ember-routing-route-configured-query-params')) {
+ if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
App.ApplicationRoute = Route.extend({
queryParams: {
foo: {
@@ -1375,7 +1379,7 @@ QUnit.test('Block-less {{link-to}} with only query-params updates when route cha
this.route('about');
});
- if (isEnabled('ember-routing-route-configured-query-params')) {
+ if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
App.ApplicationRoute = Route.extend({
queryParams: {
foo: {
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/helpers/link_to_test/link_to_transitioning_classes_test.js
|
@@ -1,11 +1,9 @@
-import RSVP from 'ember-runtime/ext/rsvp';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
-import { set } from 'ember-metal/property_set';
+import { RSVP } from 'ember-runtime';
+import { Route, NoneLocation } from 'ember-routing';
+import { run, set } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import jQuery from 'ember-views/system/jquery';
-import NoneLocation from 'ember-routing/location/none_location';
+import { Application } from 'ember-application';
+import { jQuery } from 'ember-views';
import { setTemplates, setTemplate } from 'ember-glimmer';
let Router, App, router, registry, container;
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/helpers/link_to_test/link_to_with_query_params_test.js
|
@@ -1,14 +1,10 @@
-import { set } from 'ember-metal/property_set';
-import Controller from 'ember-runtime/controllers/controller';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
-import isEnabled from 'ember-metal/features';
+import { set, run, isFeatureEnabled } from 'ember-metal';
+import { Controller, RSVP } from 'ember-runtime';
+import { Route, NoneLocation } from 'ember-routing';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import jQuery from 'ember-views/system/jquery';
-import NoneLocation from 'ember-routing/location/none_location';
+import { Application } from 'ember-application';
+import { jQuery } from 'ember-views';
import { setTemplates, setTemplate } from 'ember-glimmer';
-import RSVP from 'ember-runtime/ext/rsvp';
let Router, App, router, registry, container;
@@ -66,7 +62,7 @@ function sharedTeardown() {
setTemplates({});
}
-if (isEnabled('ember-routing-route-configured-query-params')) {
+if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
QUnit.module('The {{link-to}} helper: invoking with query params when defined on a route', {
setup() {
run(() => {
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/homepage_example_test.js
|
@@ -1,11 +1,9 @@
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
-import Application from 'ember-application/system/application';
-import EmberObject from 'ember-runtime/system/object';
-import { computed } from 'ember-metal/computed';
+import { Route } from 'ember-routing';
+import { run, computed } from 'ember-metal';
+import { Application } from 'ember-application';
+import { Object as EmberObject, A as emberA } from 'ember-runtime';
import { compile } from 'ember-template-compiler';
-import jQuery from 'ember-views/system/jquery';
-import { A as emberA } from 'ember-runtime/system/native_array';
+import { jQuery } from 'ember-views';
import { setTemplates, setTemplate } from 'ember-glimmer';
let App, $fixture;
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/integration/multiple-app-test.js
|
@@ -1,8 +1,8 @@
-import run from 'ember-metal/run_loop';
+import { run } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
+import { Application } from 'ember-application';
import { Component } from 'ember-glimmer';
-import jQuery from 'ember-views/system/jquery';
+import { jQuery } from 'ember-views';
let App1, App2, actions;
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/reexports_test.js
|
@@ -1,6 +1,6 @@
-import Ember from 'ember';
+import Ember from '../index';
import { confirmExport } from 'internal-test-helpers';
-import isEnabled from 'ember-metal/features';
+import { isFeatureEnabled } from 'ember-metal';
QUnit.module('ember reexports');
@@ -221,13 +221,13 @@ QUnit.module('ember reexports');
});
});
-if (isEnabled('ember-string-ishtmlsafe')) {
+if (isFeatureEnabled('ember-string-ishtmlsafe')) {
QUnit.test('Ember.String.isHTMLSafe exports correctly', function(assert) {
confirmExport(Ember, assert, 'String.isHTMLSafe', 'ember-glimmer', 'isHTMLSafe');
});
}
-if (isEnabled('ember-metal-weakmap')) {
+if (isFeatureEnabled('ember-metal-weakmap')) {
QUnit.test('Ember.WeakMap exports correctly', function(assert) {
confirmExport(Ember, assert, 'WeakMap', 'ember-metal', 'WeakMap');
});
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/routing/basic_test.js
|
@@ -1,25 +1,31 @@
import Logger from 'ember-console';
-import Controller from 'ember-runtime/controllers/controller';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
-import RSVP from 'ember-runtime/ext/rsvp';
-import EmberObject from 'ember-runtime/system/object';
-import { get } from 'ember-metal/property_get';
-import { set } from 'ember-metal/property_set';
-import { computed } from 'ember-metal/computed';
-import Mixin, { observer } from 'ember-metal/mixin';
-import { Component, setTemplates, setTemplate } from 'ember-glimmer';
-import jQuery from 'ember-views/system/jquery';
+import {
+ Controller,
+ RSVP,
+ Object as EmberObject,
+ A as emberA,
+ copy
+} from 'ember-runtime';
+import { Route, NoneLocation, HistoryLocation } from 'ember-routing';
+import {
+ run,
+ get,
+ set,
+ computed,
+ Mixin,
+ observer,
+ addObserver
+} from 'ember-metal';
+import {
+ Component,
+ setTemplates,
+ setTemplate
+} from 'ember-glimmer';
+import { jQuery } from 'ember-views';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import Engine from 'ember-application/system/engine';
-import { A as emberA } from 'ember-runtime/system/native_array';
-import NoneLocation from 'ember-routing/location/none_location';
-import HistoryLocation from 'ember-routing/location/history_location';
+import { Application, Engine } from 'ember-application';
import { getOwner } from 'container';
import { Transition } from 'router';
-import copy from 'ember-runtime/copy';
-import { addObserver } from 'ember-metal/observer';
let trim = jQuery.trim;
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/routing/query_params_test.js
|
@@ -1,20 +1,23 @@
-import Controller from 'ember-runtime/controllers/controller';
-import RSVP from 'ember-runtime/ext/rsvp';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
-import get from 'ember-metal/property_get';
-import EmberObject from 'ember-runtime/system/object';
-import isEnabled from 'ember-metal/features';
-import { computed } from 'ember-metal/computed';
+import {
+ Controller,
+ RSVP,
+ Object as EmberObject,
+ A as emberA,
+ String as StringUtils
+} from 'ember-runtime';
+import { Route, NoneLocation } from 'ember-routing';
+import {
+ run,
+ get,
+ isFeatureEnabled,
+ computed,
+ Mixin,
+ meta
+} from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import jQuery from 'ember-views/system/jquery';
-import { A as emberA } from 'ember-runtime/system/native_array';
-import NoneLocation from 'ember-routing/location/none_location';
+import { Application } from 'ember-application';
+import { jQuery } from 'ember-views';
import { setTemplates } from 'ember-glimmer';
-import { dasherize } from 'ember-runtime/system/string';
-import Mixin from 'ember-metal/mixin';
-import { meta } from 'ember-metal/meta';
let App, router, container;
@@ -120,7 +123,7 @@ QUnit.module('Routing with Query Params', {
}
});
-if (isEnabled('ember-routing-route-configured-query-params')) {
+if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
QUnit.test('Single query params can be set on the route', function() {
App.Router.map(function() {
this.route('home', { path: '/' });
@@ -201,7 +204,7 @@ if (isEnabled('ember-routing-route-configured-query-params')) {
defaultValue: ''
}
},
- serializeQueryParamKey: dasherize
+ serializeQueryParamKey: StringUtils.dasherize
});
bootApplication();
@@ -1000,7 +1003,7 @@ if (isEnabled('ember-routing-route-configured-query-params')) {
defaultValue: ''
}
},
- serializeQueryParamKey: dasherize
+ serializeQueryParamKey: StringUtils.dasherize
});
bootApplication();
@@ -2119,7 +2122,7 @@ if (isEnabled('ember-routing-route-configured-query-params')) {
QUnit.test('Routes have overridable serializeQueryParamKey hook', function() {
App.IndexRoute = Route.extend({
- serializeQueryParamKey: dasherize
+ serializeQueryParamKey: StringUtils.dasherize
});
App.IndexController = Controller.extend({
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/routing/query_params_test/model_dependent_state_with_query_params_test.js
|
@@ -1,15 +1,10 @@
-import Controller from 'ember-runtime/controllers/controller';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
-import isEnabled from 'ember-metal/features';
-import { computed } from 'ember-metal/computed';
+import { Controller, A as emberA, String as StringUtils } from 'ember-runtime';
+import { Route, NoneLocation } from 'ember-routing';
+import { run, isFeatureEnabled, computed } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import jQuery from 'ember-views/system/jquery';
-import { A as emberA } from 'ember-runtime/system/native_array';
-import NoneLocation from 'ember-routing/location/none_location';
+import { Application } from 'ember-application';
+import { jQuery } from 'ember-views';
import { setTemplates } from 'ember-glimmer';
-import { classify } from 'ember-runtime/system/string';
let App, router, registry, container;
@@ -210,9 +205,9 @@ function queryParamsStickyTest3(urlPrefix, articleLookup) {
function queryParamsStickyTest4(urlPrefix, articleLookup) {
return function() {
- let articleClass = classify(articleLookup);
+ let articleClass = StringUtils.classify(articleLookup);
- if (isEnabled('ember-routing-route-configured-query-params')) {
+ if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
App[`${articleClass}Route`].reopen({
queryParams: { q: { scope: 'controller' } }
});
@@ -290,7 +285,7 @@ function queryParamsStickyTest5(urlPrefix, commentsLookupKey) {
function queryParamsStickyTest6(urlPrefix, articleLookup, commentsLookup) {
return function() {
- let articleClass = classify(articleLookup);
+ let articleClass = StringUtils.classify(articleLookup);
App[`${articleClass}Route`].reopen({
resetController(controller, isExiting) {
@@ -359,7 +354,7 @@ QUnit.module('Model Dep Query Params', {
}
});
- if (isEnabled('ember-routing-route-configured-query-params')) {
+ if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
App.ArticleRoute.reopen({
queryParams: {
q: { defaultValue: 'wat' },
@@ -450,7 +445,7 @@ QUnit.module('Model Dep Query Params (nested)', {
}
});
- if (isEnabled('ember-routing-route-configured-query-params')) {
+ if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
App.SiteArticleRoute.reopen({
queryParams: {
q: { defaultValue: 'wat' },
@@ -563,7 +558,7 @@ QUnit.module('Model Dep Query Params (nested & more than 1 dynamic segment)', {
}
});
- if (isEnabled('ember-routing-route-configured-query-params')) {
+ if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
App.SiteRoute.reopen({
queryParams: {
country: { defaultValue: 'au' }
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/routing/query_params_test/overlapping_query_params_test.js
|
@@ -1,11 +1,8 @@
-import Controller from 'ember-runtime/controllers/controller';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
-import isEnabled from 'ember-metal/features';
-import Mixin from 'ember-metal/mixin';
+import { Controller } from 'ember-runtime';
+import { Route, NoneLocation } from 'ember-routing';
+import { run, isFeatureEnabled, Mixin } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import NoneLocation from 'ember-routing/location/none_location';
+import { Application } from 'ember-application';
import { setTemplates, setTemplate } from 'ember-glimmer';
let App, router, registry, container;
@@ -88,7 +85,7 @@ function sharedTeardown() {
}
-if (isEnabled('ember-routing-route-configured-query-params')) {
+if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
QUnit.module('Query Params - overlapping query param property names when configured on the route', {
setup() {
sharedSetup();
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/routing/query_params_test/query_params_paramless_link_to_test.js
|
@@ -1,12 +1,9 @@
-import Controller from 'ember-runtime/controllers/controller';
-import Route from 'ember-routing/system/route';
-import isEnabled from 'ember-metal/features';
-import run from 'ember-metal/run_loop';
-import { capitalize } from 'ember-runtime/system/string';
+import { Controller, String as StringUtils } from 'ember-runtime';
+import { Route, NoneLocation } from 'ember-routing';
+import { isFeatureEnabled, run } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import jQuery from 'ember-views/system/jquery';
-import NoneLocation from 'ember-routing/location/none_location';
+import { Application } from 'ember-application';
+import { jQuery } from 'ember-views';
import { setTemplates, setTemplate } from 'ember-glimmer';
let App, container, router, registry;
@@ -100,7 +97,7 @@ function testParamlessLinks(routeName) {
setTemplate(routeName, compile('{{link-to \'index\' \'index\' id=\'index-link\'}}'));
- App[capitalize(routeName) + 'Controller'] = Controller.extend({
+ App[StringUtils.capitalize(routeName) + 'Controller'] = Controller.extend({
queryParams: ['foo'],
foo: 'wat'
});
@@ -118,7 +115,7 @@ function testParamlessLinksWithRouteConfig(routeName) {
setTemplate(routeName, compile('{{link-to \'index\' \'index\' id=\'index-link\'}}'));
- App[capitalize(routeName) + 'Route'] = Route.extend({
+ App[StringUtils.capitalize(routeName) + 'Route'] = Route.extend({
queryParams: {
foo: {
defaultValue: 'wat'
@@ -133,7 +130,7 @@ function testParamlessLinksWithRouteConfig(routeName) {
});
}
-if (isEnabled('ember-routing-route-configured-query-params')) {
+if (isFeatureEnabled('ember-routing-route-configured-query-params')) {
testParamlessLinksWithRouteConfig('application');
testParamlessLinksWithRouteConfig('index');
} else {
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/routing/router_map_test.js
|
@@ -1,8 +1,8 @@
-import run from 'ember-metal/run_loop';
+import { run } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import Router from 'ember-routing/system/router';
-import jQuery from 'ember-views/system/jquery';
+import { Application } from 'ember-application';
+import { Router } from 'ember-routing';
+import { jQuery } from 'ember-views';
import { setTemplates, setTemplate } from 'ember-glimmer';
let router, App, container;
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/routing/substates_test.js
|
@@ -1,13 +1,9 @@
-import RSVP from 'ember-runtime/ext/rsvp';
-import Controller from 'ember-runtime/controllers/controller';
-import Route from 'ember-routing/system/route';
-import run from 'ember-metal/run_loop';
+import { RSVP, Controller } from 'ember-runtime';
+import { Route, NoneLocation } from 'ember-routing';
+import { run } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import Engine from 'ember-application/system/engine';
-import jQuery from 'ember-views/system/jquery';
-import NoneLocation from 'ember-routing/location/none_location';
-import DefaultResolver from 'ember-application/system/resolver';
+import { Application, Engine, Resolver } from 'ember-application';
+import { jQuery } from 'ember-views';
import { setTemplates, setTemplate } from 'ember-glimmer';
let Router, App, templates, router, container, registry, counter;
@@ -42,7 +38,7 @@ QUnit.module('Loading/Error Substates', {
name: 'App',
rootElement: '#qunit-fixture',
// fake a modules resolver
- Resolver: DefaultResolver.extend({ moduleBasedResolver: true })
+ Resolver: Resolver.extend({ moduleBasedResolver: true })
});
App.deferReadiness();
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/routing/toplevel_dom_test.js
|
@@ -1,8 +1,8 @@
-import run from 'ember-metal/run_loop';
+import { run } from 'ember-metal';
import { compile } from 'ember-template-compiler';
-import Application from 'ember-application/system/application';
-import jQuery from 'ember-views/system/jquery';
-import NoneLocation from 'ember-routing/location/none_location';
+import { Application } from 'ember-application';
+import { jQuery } from 'ember-views';
+import { NoneLocation } from 'ember-routing';
import { setTemplates, setTemplate } from 'ember-glimmer';
let App, templates, router, container;
| true |
Other
|
emberjs
|
ember.js
|
42a9ea3fa6e3bdab36b4ba416851668999796627.json
|
Update imports in ember package tests.
|
packages/ember/tests/view_instrumentation_test.js
|
@@ -1,7 +1,10 @@
-import run from 'ember-metal/run_loop';
-import $ from 'ember-views/system/jquery';
-import Application from 'ember-application/system/application';
-import { subscribe, reset } from 'ember-metal/instrumentation';
+import {
+ run,
+ instrumentationSubscribe as subscribe,
+ instrumentationReset as reset
+} from 'ember-metal';
+import { jQuery as $ } from 'ember-views';
+import { Application } from 'ember-application';
import { compile } from 'ember-template-compiler';
import { setTemplates, setTemplate } from 'ember-glimmer';
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/acceptance_test.js
|
@@ -1,12 +1,12 @@
-import run from 'ember-metal/run_loop';
-import jQuery from 'ember-views/system/jquery';
-import Test from 'ember-testing/test';
-import QUnitAdapter from 'ember-testing/adapters/qunit';
-import 'ember-testing/initializers'; // ensure the initializer is setup
-import EmberApplication from 'ember-application/system/application';
-import EmberRoute from 'ember-routing/system/route';
+import { run } from 'ember-metal';
+import { jQuery } from 'ember-views';
+import Test from '../test';
+import QUnitAdapter from '../adapters/qunit';
+import '../initializers'; // ensure the initializer is setup
+import { Application as EmberApplication } from 'ember-application';
+import { Route as EmberRoute } from 'ember-routing';
import { compile } from 'ember-template-compiler';
-import RSVP from 'ember-runtime/ext/rsvp';
+import { RSVP } from 'ember-runtime';
import { setTemplates, setTemplate } from 'ember-glimmer';
//ES6TODO: we need {{link-to}} and {{outlet}} to exist here
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/adapters/adapter_test.js
|
@@ -1,5 +1,5 @@
-import run from 'ember-metal/run_loop';
-import Adapter from 'ember-testing/adapters/adapter';
+import { run } from 'ember-metal';
+import Adapter from '../../adapters/adapter';
var adapter;
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/adapters/qunit_test.js
|
@@ -1,5 +1,5 @@
-import run from 'ember-metal/run_loop';
-import QUnitAdapter from 'ember-testing/adapters/qunit';
+import { run } from 'ember-metal';
+import QUnitAdapter from '../../adapters/qunit';
var adapter;
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/adapters_test.js
|
@@ -1,8 +1,8 @@
-import run from 'ember-metal/run_loop';
-import Test from 'ember-testing/test';
-import Adapter from 'ember-testing/adapters/adapter';
-import QUnitAdapter from 'ember-testing/adapters/qunit';
-import EmberApplication from 'ember-application/system/application';
+import { run } from 'ember-metal';
+import Test from '../test';
+import Adapter from '../adapters/adapter';
+import QUnitAdapter from '../adapters/qunit';
+import { Application as EmberApplication } from 'ember-application';
var App, originalAdapter;
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/ext/rsvp_test.js
|
@@ -1,7 +1,6 @@
-import RSVP from 'ember-testing/ext/rsvp';
-import { getAdapter, setAdapter } from 'ember-testing/test/adapter';
-import { isTesting, setTesting } from 'ember-metal/testing';
-import run from 'ember-metal/run_loop';
+import RSVP from '../../ext/rsvp';
+import { getAdapter, setAdapter } from '../../test/adapter';
+import { isTesting, setTesting, run } from 'ember-metal';
const originalTestAdapter = getAdapter();
const originalTestingFlag = isTesting();
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/helper_registration_test.js
|
@@ -1,6 +1,6 @@
-import run from 'ember-metal/run_loop';
-import Test from 'ember-testing/test';
-import EmberApplication from 'ember-application/system/application';
+import { run } from 'ember-metal';
+import Test from '../test';
+import { Application as EmberApplication } from 'ember-application';
var App, appBooted, helperContainer;
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/helpers_test.js
|
@@ -1,33 +1,37 @@
-import Route from 'ember-routing/system/route';
-import Controller from 'ember-runtime/controllers/controller';
-import run from 'ember-metal/run_loop';
-import EmberObject from 'ember-runtime/system/object';
-import RSVP from 'ember-runtime/ext/rsvp';
-import jQuery from 'ember-views/system/jquery';
-import { Component, setTemplates, setTemplate } from 'ember-glimmer';
-
-import Test from 'ember-testing/test';
-import 'ember-testing/helpers'; // ensure that the helpers are loaded
-import 'ember-testing/initializers'; // ensure the initializer is setup
-import setupForTesting from 'ember-testing/setup_for_testing';
-import EmberRouter from 'ember-routing/system/router';
-import EmberRoute from 'ember-routing/system/route';
-import EmberApplication from 'ember-application/system/application';
+import { Route, Router } from 'ember-routing';
+import {
+ Controller,
+ Object as EmberObject,
+ RSVP
+} from 'ember-runtime';
+import { run } from 'ember-metal';
+import { jQuery } from 'ember-views';
+import {
+ Component,
+ setTemplates,
+ setTemplate
+} from 'ember-glimmer';
+
+import Test from '../test';
+import '../helpers'; // ensure that the helpers are loaded
+import '../initializers'; // ensure the initializer is setup
+import setupForTesting from '../setup_for_testing';
+import { Application as EmberApplication } from 'ember-application';
import { compile } from 'ember-template-compiler';
import {
pendingRequests,
incrementPendingRequests,
clearPendingRequests
-} from 'ember-testing/test/pending_requests';
+} from '../test/pending_requests';
import {
setAdapter,
getAdapter
-} from 'ember-testing/test/adapter';
+} from '../test/adapter';
import {
registerWaiter,
unregisterWaiter
-} from 'ember-testing/test/waiters';
+} from '../test/waiters';
var App;
var originalAdapter = getAdapter();
@@ -781,7 +785,7 @@ QUnit.module('ember-testing debugging helpers', {
setupApp();
run(function() {
- App.Router = EmberRouter.extend({
+ App.Router = Router.extend({
location: 'none'
});
});
@@ -816,7 +820,7 @@ QUnit.module('ember-testing routing helpers', {
App.injectTestHelpers();
- App.Router = EmberRouter.extend({
+ App.Router = Router.extend({
location: 'none'
});
@@ -917,7 +921,7 @@ QUnit.module('ember-testing async router', {
run(function() {
App = EmberApplication.create();
- App.Router = EmberRouter.extend({
+ App.Router = Router.extend({
location: 'none'
});
@@ -928,13 +932,13 @@ QUnit.module('ember-testing async router', {
});
});
- App.UserRoute = EmberRoute.extend({
+ App.UserRoute = Route.extend({
model() {
return resolveLater();
}
});
- App.UserProfileRoute = EmberRoute.extend({
+ App.UserProfileRoute = Route.extend({
beforeModel() {
var self = this;
return resolveLater().then(function() {
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/integration_test.js
|
@@ -1,16 +1,16 @@
-import run from 'ember-metal/run_loop';
-import EmberObject from 'ember-runtime/system/object';
-import jQuery from 'ember-views/system/jquery';
-import Test from 'ember-testing/test';
-import EmberRoute from 'ember-routing/system/route';
-import EmberApplication from 'ember-application/system/application';
+import { run } from 'ember-metal';
+import {
+ Object as EmberObject,
+ Controller,
+ A as emberA
+} from 'ember-runtime';
+import { jQuery } from 'ember-views';
+import Test from '../test';
+import { Route as EmberRoute } from 'ember-routing';
+import { Application as EmberApplication } from 'ember-application';
import { compile } from 'ember-template-compiler';
-import Controller from 'ember-runtime/controllers/controller';
-import { A as emberA } from 'ember-runtime/system/native_array';
import { setTemplates, setTemplate } from 'ember-glimmer';
-import 'ember-application';
-
var App, find, visit;
var originalAdapter = Test.adapter;
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/simple_setup.js
|
@@ -1,5 +1,5 @@
-import run from 'ember-metal/run_loop';
-import jQuery from 'ember-views/system/jquery';
+import { run } from 'ember-metal';
+import { jQuery } from 'ember-views';
var App;
| true |
Other
|
emberjs
|
ember.js
|
42e22ec8ff246474ea0b77b2e15e8203c6add104.json
|
Update imports in ember-testing package tests.
|
packages/ember-testing/tests/test/waiters-test.js
|
@@ -1,10 +1,10 @@
-import isEnabled from 'ember-metal/features';
+import { isFeatureEnabled } from 'ember-metal';
import {
registerWaiter,
unregisterWaiter,
checkWaiters,
generateDeprecatedWaitersArray
-} from 'ember-testing/test/waiters';
+} from '../../test/waiters';
class Waiters {
constructor() {
@@ -156,7 +156,7 @@ QUnit.test('generateDeprecatedWaitersArray provides deprecated access to waiters
this.waiters.register();
let waiters;
- if (isEnabled('ember-testing-check-waiters')) {
+ if (isFeatureEnabled('ember-testing-check-waiters')) {
expectDeprecation(function() {
waiters = generateDeprecatedWaitersArray();
}, /Usage of `Ember.Test.waiters` is deprecated/);
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/location/auto_location_test.js
|
@@ -1,14 +1,12 @@
-import { get } from 'ember-metal/property_get';
-import run from 'ember-metal/run_loop';
-import assign from 'ember-metal/assign';
-import AutoLocation from 'ember-routing/location/auto_location';
+import { get, run, assign } from 'ember-metal';
+import AutoLocation from '../../location/auto_location';
import {
getHistoryPath,
getHashPath
-} from 'ember-routing/location/auto_location';
-import HistoryLocation from 'ember-routing/location/history_location';
-import HashLocation from 'ember-routing/location/hash_location';
-import NoneLocation from 'ember-routing/location/none_location';
+} from '../../location/auto_location';
+import HistoryLocation from '../../location/history_location';
+import HashLocation from '../../location/hash_location';
+import NoneLocation from '../../location/none_location';
import { buildOwner } from 'internal-test-helpers';
import { OWNER } from 'container';
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/location/hash_location_test.js
|
@@ -1,6 +1,5 @@
-import { get } from 'ember-metal/property_get';
-import run from 'ember-metal/run_loop';
-import HashLocation from 'ember-routing/location/hash_location';
+import { get, run } from 'ember-metal';
+import HashLocation from '../../location/hash_location';
let HashTestLocation, location;
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/location/history_location_test.js
|
@@ -1,6 +1,5 @@
-import { set } from 'ember-metal/property_set';
-import run from 'ember-metal/run_loop';
-import HistoryLocation from 'ember-routing/location/history_location';
+import { set, run } from 'ember-metal';
+import HistoryLocation from '../../location/history_location';
let FakeHistory, HistoryTestLocation, location;
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/location/none_location_test.js
|
@@ -1,6 +1,5 @@
-import { set } from 'ember-metal/property_set';
-import run from 'ember-metal/run_loop';
-import NoneLocation from 'ember-routing/location/none_location';
+import { set, run } from 'ember-metal';
+import NoneLocation from '../../location/none_location';
let NoneTestLocation, location;
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/location/util_test.js
|
@@ -1,14 +1,14 @@
-import assign from 'ember-metal/assign';
+import { assign } from 'ember-metal';
import {
replacePath,
getPath,
getQuery,
getFullPath
-} from 'ember-routing/location/util';
+} from '../../location/util';
import {
supportsHistory,
supportsHashChange
-} from 'ember-routing/location/util';
+} from '../../location/util';
function mockBrowserLocation(overrides) {
return assign({
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/system/controller_for_test.js
|
@@ -1,14 +1,7 @@
-import Ember from 'ember-metal/core'; // A
-import { get } from 'ember-metal/property_get';
-import run from 'ember-metal/run_loop';
-import Namespace from 'ember-runtime/system/namespace';
-import { classify } from 'ember-runtime/system/string';
-import Controller from 'ember-runtime/controllers/controller';
-import controllerFor from 'ember-routing/system/controller_for';
-import generateController from 'ember-routing/system/generate_controller';
-import {
- generateControllerFactory
-} from 'ember-routing/system/generate_controller';
+import { get, run } from 'ember-metal'; // A
+import { Namespace, String as StringUtils, Controller } from 'ember-runtime';
+import controllerFor from '../../system/controller_for';
+import generateController from '../../system/generate_controller';
import { buildOwner } from 'internal-test-helpers';
function buildInstance(namespace) {
@@ -34,7 +27,7 @@ function resolverFor(namespace) {
if (name === 'basic') {
name = '';
}
- let className = classify(name) + classify(type);
+ let className = StringUtils.classify(name) + StringUtils.classify(type);
let factory = get(namespace, className);
if (factory) { return factory; }
@@ -78,11 +71,6 @@ QUnit.module('Ember.generateController', {
}
});
-QUnit.test('generateController and generateControllerFactory are properties on the root namespace', function() {
- equal(Ember.generateController, generateController, 'should export generateController');
- equal(Ember.generateControllerFactory, generateControllerFactory, 'should export generateControllerFactory');
-});
-
QUnit.test('generateController should create Ember.Controller', function() {
let controller = generateController(appInstance, 'home');
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/system/dsl_test.js
|
@@ -1,4 +1,4 @@
-import EmberRouter from 'ember-routing/system/router';
+import EmberRouter from '../../system/router';
import { setOwner } from 'container';
import { buildOwner } from 'internal-test-helpers';
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/system/route_test.js
|
@@ -1,9 +1,10 @@
-import { runDestroy } from 'internal-test-helpers';
-import Service from 'ember-runtime/system/service';
-import EmberObject from 'ember-runtime/system/object';
-import EmberRoute from 'ember-routing/system/route';
-import inject from 'ember-runtime/inject';
-import { buildOwner } from 'internal-test-helpers';
+import { runDestroy, buildOwner } from 'internal-test-helpers';
+import {
+ Service,
+ Object as EmberObject,
+ inject
+} from 'ember-runtime';
+import EmberRoute from '../../system/route';
import { setOwner } from 'container';
let route, routeOne, routeTwo, lookupHash;
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/system/router_test.js
|
@@ -1,8 +1,8 @@
-import HashLocation from 'ember-routing/location/hash_location';
-import HistoryLocation from 'ember-routing/location/history_location';
-import AutoLocation from 'ember-routing/location/auto_location';
-import NoneLocation from 'ember-routing/location/none_location';
-import Router, { triggerEvent } from 'ember-routing/system/router';
+import HashLocation from '../../location/hash_location';
+import HistoryLocation from '../../location/history_location';
+import AutoLocation from '../../location/auto_location';
+import NoneLocation from '../../location/none_location';
+import Router, { triggerEvent } from '../../system/router';
import { runDestroy, buildOwner } from 'internal-test-helpers';
import { setOwner } from 'container';
| true |
Other
|
emberjs
|
ember.js
|
18ad953303c6a73caad687de375499a4f22d8ed2.json
|
Update imports in ember-routing package tests.
|
packages/ember-routing/tests/utils_test.js
|
@@ -1,6 +1,6 @@
import {
normalizeControllerQueryParams
-} from 'ember-routing/utils';
+} from '../utils';
QUnit.module('Routing query parameter utils - normalizeControllerQueryParams');
| true |
Other
|
emberjs
|
ember.js
|
dd28ca046a299497aacda9e674229be99f02db52.json
|
Update imports in ember-glimmer package tests.
|
packages/ember-application/lib/index.js
|
@@ -8,6 +8,7 @@ export { default as ApplicationInstance } from './system/application-instance';
export { default as Resolver } from './system/resolver';
export { default as Engine } from './system/engine';
export { default as EngineInstance } from './system/engine-instance';
+export { getEngineParent, setEngineParent } from './system/engine-parent';
// add domTemplates initializer (only does something if `ember-template-compiler`
// is loaded already)
| true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.