language
stringclasses 1
value | owner
stringlengths 2
15
| repo
stringlengths 2
21
| sha
stringlengths 45
45
| message
stringlengths 7
36.3k
| path
stringlengths 1
199
| patch
stringlengths 15
102k
| is_multipart
bool 2
classes |
|---|---|---|---|---|---|---|---|
Other
|
emberjs
|
ember.js
|
d8f28f42043f077e1b81290d9903c4dd13dca163.json
|
Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
|
packages/@ember/object/index.d.ts
|
@@ -1 +1,3 @@
export let action: MethodDecorator;
+
+export { Object as default } from '@ember/-internals/runtime';
| true |
Other
|
emberjs
|
ember.js
|
d8f28f42043f077e1b81290d9903c4dd13dca163.json
|
Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
|
packages/@ember/object/type-tests/core.test.ts
|
@@ -0,0 +1,5 @@
+import { expectTypeOf } from 'expect-type';
+
+import CoreObject from '@ember/object/core';
+
+expectTypeOf(CoreObject.create()).toEqualTypeOf<CoreObject>();
| true |
Other
|
emberjs
|
ember.js
|
d8f28f42043f077e1b81290d9903c4dd13dca163.json
|
Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
|
packages/@ember/object/type-tests/index.test.ts
|
@@ -0,0 +1,5 @@
+import { expectTypeOf } from 'expect-type';
+
+import EmberObject from '@ember/object';
+
+expectTypeOf(EmberObject.create()).toEqualTypeOf<EmberObject>();
| true |
Other
|
emberjs
|
ember.js
|
d8f28f42043f077e1b81290d9903c4dd13dca163.json
|
Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
|
packages/@ember/object/type-tests/observable.test.ts
|
@@ -0,0 +1,5 @@
+import { expectTypeOf } from 'expect-type';
+
+import Observable from '@ember/object/observable';
+
+expectTypeOf<Observable['get']>().toEqualTypeOf<<K extends keyof Observable>(key: K) => unknown>();
| true |
Other
|
emberjs
|
ember.js
|
d8f28f42043f077e1b81290d9903c4dd13dca163.json
|
Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
|
packages/@ember/object/types/core.d.ts
|
@@ -0,0 +1 @@
+export { CoreObject as default } from '../../-internals/runtime';
| true |
Other
|
emberjs
|
ember.js
|
d8f28f42043f077e1b81290d9903c4dd13dca163.json
|
Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
|
packages/@ember/object/types/observable.d.ts
|
@@ -0,0 +1,2 @@
+import Observable from '@ember/-internals/runtime/types/observable';
+export default Observable;
| true |
Other
|
emberjs
|
ember.js
|
d8f28f42043f077e1b81290d9903c4dd13dca163.json
|
Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
|
tests/docs/expected.js
|
@@ -37,7 +37,6 @@ module.exports = {
'_invoke',
'_lazyInjections',
'_logLookup',
- '_names',
'_normalizeCache',
'_onLookup',
'_options',
| true |
Other
|
emberjs
|
ember.js
|
d8f28f42043f077e1b81290d9903c4dd13dca163.json
|
Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
|
tsconfig.json
|
@@ -24,17 +24,12 @@
"allowJs": false,
"paths": {
- "@glimmer/*": ["../node_modules/@glimmer/*"]
+ "@glimmer/*": ["../node_modules/@glimmer/*"],
+ "@ember/object/*": ["@ember/object/*", "@ember/object/types/*"]
}
},
- "include": [
- "packages/**/*.ts",
- ],
+ "include": ["packages/**/*.ts"],
- "exclude": [
- "dist",
- "node_modules",
- "tmp",
- ]
+ "exclude": ["dist", "node_modules", "tmp"]
}
| true |
Other
|
emberjs
|
ember.js
|
d8f28f42043f077e1b81290d9903c4dd13dca163.json
|
Improve types for @ember/object
Includes:
- Object, { action } from '@ember/object'
- CoreObject from '@ember/object/core'
- Observable from '@ember/object/observable'
Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
|
yarn.lock
|
@@ -5007,6 +5007,11 @@ expand-tilde@^2.0.0, expand-tilde@^2.0.2:
dependencies:
homedir-polyfill "^1.0.1"
+expect-type@^0.11.0:
+ version "0.11.0"
+ resolved "https://registry.yarnpkg.com/expect-type/-/expect-type-0.11.0.tgz#bce1a3e283f0334eedb39699b57dd27be7009cc1"
+ integrity sha512-hkObxepDKhTYloH/UZoxYTT2uUzdhvDEwAi0oqdk29XEkHF8p+5ZRpX/BZES2PtGN9YgyEqutIjXfnL9iMflMw==
+
express@^4.10.7, express@^4.13.1, express@^4.16.4, express@^4.17.1:
version "4.17.1"
resolved "https://registry.yarnpkg.com/express/-/express-4.17.1.tgz#4491fc38605cf51f8629d39c2b5d026f98a4c134"
@@ -10042,6 +10047,11 @@ type-is@~1.6.17, type-is@~1.6.18:
media-typer "0.3.0"
mime-types "~2.1.24"
+typescript@^4.2.4:
+ version "4.2.4"
+ resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.2.4.tgz#8610b59747de028fda898a8aef0e103f156d0961"
+ integrity sha512-V+evlYHZnQkaz8TRBuxTA92yZBPotr5H+WhQ7bD3hZUndx5tGOa1fuCgeSjxAzM1RiN5IzvadIXTVefuuwZCRg==
+
typescript@~4.0.3:
version "4.0.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.0.3.tgz#153bbd468ef07725c1df9c77e8b453f8d36abba5"
| true |
Other
|
emberjs
|
ember.js
|
ac201b8e3e52226dbc74daf7be476985f9109a61.json
|
Release notes for v3.27.1
(cherry picked from commit 8e57edd86d2c6a0171340b316b6c436b53efb7f6)
(cherry picked from commit b3b4e5386461f912f978edd20ff231d4261d2b93)
|
CHANGELOG.md
|
@@ -4,6 +4,13 @@
- [#19472](https://github.com/emberjs/ember.js/pull/19472) [BUGFIX] Prevent transformation of block params called `attrs`
+### v3.27.1 (May 13, 2021)
+
+- [#19540](https://github.com/emberjs/ember.js/pull/19540) [BUGFIX] Ensure ember-testing is loaded lazily
+- [#19541](https://github.com/emberjs/ember.js/pull/19541) [BUGFIX] Add missing metadata for some deprecations enabled in 3.27.0
+- [#19541](https://github.com/emberjs/ember.js/pull/19541) [BUGFIX] Ensure passing `@href` to `<LinkTo>` throws an error
+- [#19541](https://github.com/emberjs/ember.js/pull/19541) [CLEANUP] Consistently use https://deprecations.emberjs.com/ in deprecation URLs
+
### v3.27.0 (May 3, 2021)
- [#19309](https://github.com/emberjs/ember.js/pull/19309) / [#19487](https://github.com/emberjs/ember.js/pull/19487) / [#19474](https://github.com/emberjs/ember.js/pull/19474) [FEATURE] Enable `(helper` and `(modifier` helpers per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md).
@@ -14,7 +21,7 @@
- [#19442](https://github.com/emberjs/ember.js/pull/19442) [DEPRECATION] Add deprecation for `Route#render` method per [RFC #418](https://github.com/emberjs/rfcs/blob/master/text/0418-deprecate-route-render-methods.md).
- [#19429](https://github.com/emberjs/ember.js/pull/19429) [DEPRECATION] `registerPlugin` / `unregisterPlugin` and legacy class based AST plugins (private APIs)
- [#19499](https://github.com/emberjs/ember.js/pull/19499) [DEPRECATION] Deprecate `@foo={{helper}}` per [RFC #496](https://github.com/emberjs/rfcs/blob/master/text/0496-handlebars-strict-mode.md#3-no-implicit-invocation-of-argument-less-helpers).
-- [#19499](https://github.com/emberjs/ember.js/pull/19499) [BUGFIX] Update rendering engine to `@glimmer/*` 0.78.2 for fixes including:
+- [#19499](https://github.com/emberjs/ember.js/pull/19499) [BUGFIX] Update rendering engine to `@glimmer/*` 0.78.2 for fixes including:
- `<:else>` and `<:inverse>` should be aliases (see https://github.com/glimmerjs/glimmer-vm/pull/1296)
- Fix nested calls to helpers in dynamic helpers (see https://github.com/glimmerjs/glimmer-vm/pull/1293)
- [#19477](https://github.com/emberjs/ember.js/pull/19477) [BUGFIX] Allow `<LinkToExternal />` to override internal assertion
@@ -106,7 +113,7 @@
### v3.24.0 (December 28, 2020)
-- [#19224](https://github.com/emberjs/ember.js/pull/19224) [FEATURE] Add `{{page-title}}` helper to route template blueprints to implement [RFC #0654](https://github.com/emberjs/rfcs/blob/master/text/0645-add-ember-page-title-addon.md).
+- [#19224](https://github.com/emberjs/ember.js/pull/19224) [FEATURE] Add `{{page-title}}` helper to route template blueprints to implement [RFC #0654](https://github.com/emberjs/rfcs/blob/master/text/0645-add-ember-page-title-addon.md).
- [#19133](https://github.com/emberjs/ember.js/pull/19133) [FEATURE / DEPRECATION] Add new options to `deprecate()` for `for` and `since` and deprecate using `deprecate()` without those options per the [Deprecation Staging RFC](https://github.com/emberjs/rfcs/blob/master/text/0649-deprecation-staging.md).
- [#19211](https://github.com/emberjs/ember.js/pull/19211) [DEPRECATION] Deprecate `Ember.String.loc` and `{{loc}}` per the [Deprecate Ember String RFC](https://github.com/emberjs/rfcs/blob/master/text/0236-deprecation-ember-string.md).
- [#19234](https://github.com/emberjs/ember.js/pull/19234) [DEPRECATION] Deprecate String Prototype extensions per the [Deprecate Ember String RFC](https://github.com/emberjs/rfcs/blob/master/text/0236-deprecation-ember-string.md).
@@ -130,7 +137,7 @@
- [#19160](https://github.com/emberjs/ember.js/pull/19160) / [#19182](https://github.com/emberjs/ember.js/pull/19182) [FEATURE] Implements the helper manager feature specified in the [Helper Managers RFC](https://github.com/emberjs/rfcs/blob/master/text/0625-helper-managers.md).
- [#19171](https://github.com/emberjs/ember.js/pull/19171) / [#19182](https://github.com/emberjs/ember.js/pull/19182) [FEATURE] Implements `invokeHelper` from the [JavaScript Helper Invocation API RFC](https://github.com/emberjs/rfcs/blob/master/text/0626-invoke-helper.md).
-- [#19148](https://github.com/emberjs/ember.js/pull/19148) / [#19119](https://github.com/emberjs/ember.js/pull/19119) Update rendering engine to `@glimmer/*` 0.62.1
+- [#19148](https://github.com/emberjs/ember.js/pull/19148) / [#19119](https://github.com/emberjs/ember.js/pull/19119) Update rendering engine to `@glimmer/*` 0.62.1
- [#19122](https://github.com/emberjs/ember.js/pull/19122) [BUGFIX] Prevents dynamic invocations of string values when referenced directly in angle brackets
- [#19136](https://github.com/emberjs/ember.js/pull/19136) [BUGFIX] Update router microlib to improve Transition related debugging
- [#19173](https://github.com/emberjs/ember.js/pull/19173) [BUGFIX] Enforce usage of `capabilities` generation.
@@ -159,7 +166,7 @@
- [#19062](https://github.com/emberjs/ember.js/pull/19062) / [#19068](https://github.com/emberjs/ember.js/pull/19068) [FEATURE] Add @ember/destroyable feature from the [Destroyables RFC](https://github.com/emberjs/rfcs/blob/master/text/0580-destroyables.md).
- [#18984](https://github.com/emberjs/ember.js/pull/18984) / [#19067](https://github.com/emberjs/ember.js/pull/19067) [FEATURE] Add low-level Cache API per [Autotracking Memoization RFC](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md)
- [#19086](https://github.com/emberjs/ember.js/pull/19086) [FEATURE] Pass transition object to activate/deactivate hooks and events
-- [#19094](https://github.com/emberjs/ember.js/pull/19094) [BUGFIX] Fix RouterService#isActive() to work with tracking
+- [#19094](https://github.com/emberjs/ember.js/pull/19094) [BUGFIX] Fix RouterService#isActive() to work with tracking
- [#19163](https://github.com/emberjs/ember.js/pull/19163) [BUGFIX] Use args proxy for modifier managers.
- [#19170](https://github.com/emberjs/ember.js/pull/19170) [BUGFIX] Make modifier manager 3.22 accept the resolved value directly.
- [#19124](https://github.com/emberjs/ember.js/pull/19124) [BUGFIX] Fix rendering engine usage within a `fastboot` sandbox
@@ -182,7 +189,7 @@
- [#18993](https://github.com/emberjs/ember.js/pull/18993) [DEPRECATION] Deprecate `getWithDefault` per [RFC #554](https://github.com/emberjs/rfcs/blob/master/text/0554-deprecate-getwithdefault.md).
- [#19087](https://github.com/emberjs/ember.js/pull/19087) [BUGFIX] Generated initializer tests no longer causes a deprecation warning
-- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
+- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
### v3.20.6 (November 11, 2020)
@@ -240,7 +247,7 @@
- Fix: Rerender an `{{#each`s block only when the specific item has changed
- [#18958](https://github.com/emberjs/ember.js/pull/18958) [BUGFIX] Ensure AST transforms using `in-element` work properly.
- [#18960](https://github.com/emberjs/ember.js/pull/18960) [BUGFIX] More assertions for Application lifecycle methods
-- [#18919](https://github.com/emberjs/ember.js/pull/18919) [BUGFIX] Add error for modifier manager without capabilities.
+- [#18919](https://github.com/emberjs/ember.js/pull/18919) [BUGFIX] Add error for modifier manager without capabilities.
- [#18828](https://github.com/emberjs/ember.js/pull/18828) [BUGFIX] Prepend 'TODO: ' to 'Replace this with your real tests' comments in generated tests
- [#18353](https://github.com/emberjs/ember.js/pull/18353) [BUGFIX] Improve `fn` & `on` undefined callback message
- [#18824](https://github.com/emberjs/ember.js/pull/18824) [CLEANUP] Remove deprecated private `window.ENV`
| false |
Other
|
emberjs
|
ember.js
|
f77c8b0b6c03a927012250d96f448c2ec0ce31da.json
|
Add v3.28.0-beta.1 to CHANGELOG
(cherry picked from commit 916e1041d8ed38f4dc8cff0a7a9b3b4013659c6c)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.28.0-beta.1 (May 3, 2021)
+
+- [#19472](https://github.com/emberjs/ember.js/pull/19472) [BUGFIX] Prevent transformation of block params called `attrs`
+
### v3.27.0 (May 3, 2021)
- [#19309](https://github.com/emberjs/ember.js/pull/19309) / [#19487](https://github.com/emberjs/ember.js/pull/19487) / [#19474](https://github.com/emberjs/ember.js/pull/19474) [FEATURE] Enable `(helper` and `(modifier` helpers per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md).
| false |
Other
|
emberjs
|
ember.js
|
3afd20cb64c334d86c657d021fdd52de1fb0c1d6.json
|
Add v3.27.0 to CHANGELOG
(cherry picked from commit 74ef460ecb8295183efa9f5e31eeb8ec74155a49)
|
CHANGELOG.md
|
@@ -1,30 +1,20 @@
# Ember Changelog
-### v3.27.0-beta.4 (April 21, 2021)
-
-- [#19499](https://github.com/emberjs/ember.js/pull/19499) [BUGFIX beta] [DEPRECATION] Deprecate `@foo={{helper}}`
-- [#19499](https://github.com/emberjs/ember.js/pull/19499) [BUGFIX beta] `<:else>` and `<:inverse>` should be aliases (see )
-- [#19499](https://github.com/emberjs/ember.js/pull/19499) [BUGFIX beta] Fix nested calls to helpers in dynamic helpers (see https://github.com/glimmerjs/glimmer-vm/pull/1293)
-
-### v3.27.0-beta.3 (March 30, 2021)
-
-- [#19477](https://github.com/emberjs/ember.js/pull/19477) [BUGFIX] Move `LinkTo` assertion into a method so `LinkToExternal` can override it
-- [#19481](https://github.com/emberjs/ember.js/pull/19481) [BUGFIX] Export `on` from correct path
-- [#19487](https://github.com/emberjs/ember.js/pull/19487) [BUGFIX] Allow passing a string literal to {{helper}} and {{modifier}}
-
-### v3.27.0-beta.2 (March 25, 2021)
-
-- [#19473](https://github.com/emberjs/ember.js/pull/19473) Update GlimmerVM to latest (fix compatibility for template import proposals)
-- [#19474](https://github.com/emberjs/ember.js/pull/19474) [FEATURE] Enable `(helper` and `(modifier` helpers
-
-### v3.27.0-beta.1 (March 22, 2021)
+### v3.27.0 (May 3, 2021)
+- [#19309](https://github.com/emberjs/ember.js/pull/19309) / [#19487](https://github.com/emberjs/ember.js/pull/19487) / [#19474](https://github.com/emberjs/ember.js/pull/19474) [FEATURE] Enable `(helper` and `(modifier` helpers per [RFC #432](https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md).
- [#19382](https://github.com/emberjs/ember.js/pull/19382) / [#19430](https://github.com/emberjs/ember.js/pull/19430) [FEATURE] Remaining implementation work per [RFC #671](https://github.com/emberjs/rfcs/blob/master/text/0671-modernize-built-in-components-1.md).
- [#19457](https://github.com/emberjs/ember.js/pull/19457) / [#19463](https://github.com/emberjs/ember.js/pull/19463) / [#19464](https://github.com/emberjs/ember.js/pull/19464) / [#19467](https://github.com/emberjs/ember.js/pull/19467) [DEPRECATION] Add deprecation for the Ember Global per [RFC #706](https://github.com/emberjs/rfcs/blob/master/text/0706-deprecate-ember-global.md).
- [#19407](https://github.com/emberjs/ember.js/pull/19407) [DEPRECATION] Add deprecation for `Route#disconnectOutlet` per [RFC #491](https://github.com/emberjs/rfcs/blob/master/text/0491-deprecate-disconnect-outlet.md).
- [#19433](https://github.com/emberjs/ember.js/pull/19433) [DEPRECATION] Add deprecation for `Route#renderTemplate` per [RFC #418](https://github.com/emberjs/rfcs/blob/master/text/0418-deprecate-route-render-methods.md).
- [#19442](https://github.com/emberjs/ember.js/pull/19442) [DEPRECATION] Add deprecation for `Route#render` method per [RFC #418](https://github.com/emberjs/rfcs/blob/master/text/0418-deprecate-route-render-methods.md).
- [#19429](https://github.com/emberjs/ember.js/pull/19429) [DEPRECATION] `registerPlugin` / `unregisterPlugin` and legacy class based AST plugins (private APIs)
+- [#19499](https://github.com/emberjs/ember.js/pull/19499) [DEPRECATION] Deprecate `@foo={{helper}}` per [RFC #496](https://github.com/emberjs/rfcs/blob/master/text/0496-handlebars-strict-mode.md#3-no-implicit-invocation-of-argument-less-helpers).
+- [#19499](https://github.com/emberjs/ember.js/pull/19499) [BUGFIX] Update rendering engine to `@glimmer/*` 0.78.2 for fixes including:
+ - `<:else>` and `<:inverse>` should be aliases (see https://github.com/glimmerjs/glimmer-vm/pull/1296)
+ - Fix nested calls to helpers in dynamic helpers (see https://github.com/glimmerjs/glimmer-vm/pull/1293)
+- [#19477](https://github.com/emberjs/ember.js/pull/19477) [BUGFIX] Allow `<LinkToExternal />` to override internal assertion
+- [#19481](https://github.com/emberjs/ember.js/pull/19481) [BUGFIX] Export `on` from correct path
- [#19466](https://github.com/emberjs/ember.js/pull/19466) [BUGFIX] Rename private runloop functions
- [#19384](https://github.com/emberjs/ember.js/pull/19384) Use qunit-dom in helper and component test blueprints
- [#19390](https://github.com/emberjs/ember.js/pull/19390) Refactor the internal Ember loader to use the standard Ember CLI loader
| false |
Other
|
emberjs
|
ember.js
|
ba337bb40ae944c80ce8cdbda7b5b1dd9a8a8b59.json
|
Remove some unnecessary use of reopen in Route
|
packages/@ember/-internals/routing/lib/system/route.ts
|
@@ -97,6 +97,8 @@ export function hasDefaultSerialize(route: Route): boolean {
*/
class Route extends EmberObject implements IRoute {
+ static isRouteFactory = true;
+
routeName!: string;
fullRouteName!: string;
context: {} = {};
@@ -1876,11 +1878,199 @@ class Route extends EmberObject implements IRoute {
@public
*/
buildRouteInfoMetadata() {}
-}
-Route.reopenClass({
- isRouteFactory: true,
-});
+ /**
+ * @method _paramsFor
+ * @private
+ */
+ _paramsFor(routeName: string, params: {}) {
+ let transition = this._router._routerMicrolib.activeTransition;
+ if (transition !== undefined) {
+ return this.paramsFor(routeName);
+ }
+
+ return params;
+ }
+
+
+ /**
+ Store property provides a hook for data persistence libraries to inject themselves.
+
+ By default, this store property provides the exact same functionality previously
+ in the model hook.
+
+ Currently, the required interface is:
+
+ `store.find(modelName, findArguments)`
+
+ @property store
+ @type {Object}
+ @private
+ */
+ @computed
+ protected get store() {
+ let owner = getOwner(this);
+ let routeName = this.routeName;
+ let namespace = get(this, '_router.namespace');
+
+ return {
+ find(name: string, value: unknown) {
+ let modelClass: any = owner.factoryFor(`model:${name}`);
+
+ assert(
+ `You used the dynamic segment ${name}_id in your route ${routeName}, but ${namespace}.${classify(
+ name
+ )} did not exist and you did not override your route's \`model\` hook.`,
+ Boolean(modelClass)
+ );
+
+ if (!modelClass) {
+ return;
+ }
+
+ modelClass = modelClass.class;
+
+ assert(
+ `${classify(name)} has no method \`find\`.`,
+ typeof modelClass.find === 'function'
+ );
+
+ return modelClass.find(value);
+ },
+ };
+ }
+
+ protected set store(value: any) {
+ defineProperty(this, 'store', null, value);
+ }
+
+ /**
+ @private
+ @property _qp
+ */
+ @computed
+ protected get _qp() {
+ let combinedQueryParameterConfiguration;
+
+ let controllerName = this.controllerName || this.routeName;
+ let owner = getOwner(this);
+ let controller = owner.lookup<Controller>(`controller:${controllerName}`);
+ let queryParameterConfiguraton = get(this, 'queryParams');
+ let hasRouterDefinedQueryParams = Object.keys(queryParameterConfiguraton).length > 0;
+
+ if (controller) {
+ // the developer has authored a controller class in their application for
+ // this route find its query params and normalize their object shape them
+ // merge in the query params for the route. As a mergedProperty,
+ // Route#queryParams is always at least `{}`
+
+ let controllerDefinedQueryParameterConfiguration = get(controller, 'queryParams') || {};
+ let normalizedControllerQueryParameterConfiguration = normalizeControllerQueryParams(
+ controllerDefinedQueryParameterConfiguration
+ );
+ combinedQueryParameterConfiguration = mergeEachQueryParams(
+ normalizedControllerQueryParameterConfiguration,
+ queryParameterConfiguraton
+ );
+ } else if (hasRouterDefinedQueryParams) {
+ // the developer has not defined a controller but *has* supplied route query params.
+ // Generate a class for them so we can later insert default values
+ controller = generateController(owner, controllerName);
+ combinedQueryParameterConfiguration = queryParameterConfiguraton;
+ }
+
+ let qps = [];
+ let map = {};
+ let propertyNames = [];
+
+ for (let propName in combinedQueryParameterConfiguration) {
+ if (!Object.prototype.hasOwnProperty.call(combinedQueryParameterConfiguration, propName)) {
+ continue;
+ }
+
+ // to support the dubious feature of using unknownProperty
+ // on queryParams configuration
+ if (propName === 'unknownProperty' || propName === '_super') {
+ // possible todo: issue deprecation warning?
+ continue;
+ }
+
+ let desc = combinedQueryParameterConfiguration[propName];
+ let scope = desc.scope || 'model';
+ let parts;
+
+ if (scope === 'controller') {
+ parts = [];
+ }
+
+ let urlKey = desc.as || this.serializeQueryParamKey(propName);
+ let defaultValue = get(controller!, propName);
+
+ defaultValue = copyDefaultValue(defaultValue);
+
+ let type = desc.type || typeOf(defaultValue);
+
+ let defaultValueSerialized = this.serializeQueryParam(defaultValue, urlKey, type);
+ let scopedPropertyName = `${controllerName}:${propName}`;
+ let qp = {
+ undecoratedDefaultValue: get(controller!, propName),
+ defaultValue,
+ serializedDefaultValue: defaultValueSerialized,
+ serializedValue: defaultValueSerialized,
+
+ type,
+ urlKey,
+ prop: propName,
+ scopedPropertyName,
+ controllerName,
+ route: this,
+ parts, // provided later when stashNames is called if 'model' scope
+ values: null, // provided later when setup is called. no idea why.
+ scope,
+ };
+
+ map[propName] = map[urlKey] = map[scopedPropertyName] = qp;
+ qps.push(qp);
+ propertyNames.push(propName);
+ }
+
+ return {
+ qps,
+ map,
+ propertyNames,
+ states: {
+ /*
+ Called when a query parameter changes in the URL, this route cares
+ about that query parameter, but the route is not currently
+ in the active route hierarchy.
+ */
+ inactive: (prop: string, value: unknown) => {
+ let qp = map[prop];
+ this._qpChanged(prop, value, qp);
+ },
+ /*
+ Called when a query parameter changes in the URL, this route cares
+ about that query parameter, and the route is currently
+ in the active route hierarchy.
+ */
+ active: (prop: string, value: unknown) => {
+ let qp = map[prop];
+ this._qpChanged(prop, value, qp);
+ return this._activeQPChanged(qp, value);
+ },
+ /*
+ Called when a value of a query parameter this route handles changes in a controller
+ and the route is currently in the active route hierarchy.
+ */
+ allowOverrides: (prop: string, value: unknown) => {
+ let qp = map[prop];
+ this._qpChanged(prop, value, qp);
+ return this._updatingQPChanged(qp);
+ },
+ },
+ };
+ }
+}
function parentRoute(route: Route) {
let routeInfo = routeInfoFor(route, route._router._routerMicrolib.state!.routeInfos, -1);
@@ -2277,13 +2467,6 @@ Route.reopen(ActionHandler, Evented, {
*/
templateName: null,
- /**
- @private
-
- @property _names
- */
- _names: null,
-
/**
The name of the controller to associate with this route.
@@ -2306,185 +2489,6 @@ Route.reopen(ActionHandler, Evented, {
*/
controllerName: null,
- /**
- Store property provides a hook for data persistence libraries to inject themselves.
-
- By default, this store property provides the exact same functionality previously
- in the model hook.
-
- Currently, the required interface is:
-
- `store.find(modelName, findArguments)`
-
- @property store
- @type {Object}
- @private
- */
- store: computed({
- get(this: Route) {
- let owner = getOwner(this);
- let routeName = this.routeName;
- let namespace = get(this, '_router.namespace');
-
- return {
- find(name: string, value: unknown) {
- let modelClass: any = owner.factoryFor(`model:${name}`);
-
- assert(
- `You used the dynamic segment ${name}_id in your route ${routeName}, but ${namespace}.${classify(
- name
- )} did not exist and you did not override your route's \`model\` hook.`,
- Boolean(modelClass)
- );
-
- if (!modelClass) {
- return;
- }
-
- modelClass = modelClass.class;
-
- assert(
- `${classify(name)} has no method \`find\`.`,
- typeof modelClass.find === 'function'
- );
-
- return modelClass.find(value);
- },
- };
- },
-
- set(key, value) {
- defineProperty(this, key, null, value);
- },
- }),
-
- /**
- @private
-
- @property _qp
- */
- _qp: computed(function (this: Route) {
- let combinedQueryParameterConfiguration;
-
- let controllerName = this.controllerName || this.routeName;
- let owner = getOwner(this);
- let controller = owner.lookup<Controller>(`controller:${controllerName}`);
- let queryParameterConfiguraton = get(this, 'queryParams');
- let hasRouterDefinedQueryParams = Object.keys(queryParameterConfiguraton).length > 0;
-
- if (controller) {
- // the developer has authored a controller class in their application for
- // this route find its query params and normalize their object shape them
- // merge in the query params for the route. As a mergedProperty,
- // Route#queryParams is always at least `{}`
-
- let controllerDefinedQueryParameterConfiguration = get(controller, 'queryParams') || {};
- let normalizedControllerQueryParameterConfiguration = normalizeControllerQueryParams(
- controllerDefinedQueryParameterConfiguration
- );
- combinedQueryParameterConfiguration = mergeEachQueryParams(
- normalizedControllerQueryParameterConfiguration,
- queryParameterConfiguraton
- );
- } else if (hasRouterDefinedQueryParams) {
- // the developer has not defined a controller but *has* supplied route query params.
- // Generate a class for them so we can later insert default values
- controller = generateController(owner, controllerName);
- combinedQueryParameterConfiguration = queryParameterConfiguraton;
- }
-
- let qps = [];
- let map = {};
- let propertyNames = [];
-
- for (let propName in combinedQueryParameterConfiguration) {
- if (!Object.prototype.hasOwnProperty.call(combinedQueryParameterConfiguration, propName)) {
- continue;
- }
-
- // to support the dubious feature of using unknownProperty
- // on queryParams configuration
- if (propName === 'unknownProperty' || propName === '_super') {
- // possible todo: issue deprecation warning?
- continue;
- }
-
- let desc = combinedQueryParameterConfiguration[propName];
- let scope = desc.scope || 'model';
- let parts;
-
- if (scope === 'controller') {
- parts = [];
- }
-
- let urlKey = desc.as || this.serializeQueryParamKey(propName);
- let defaultValue = get(controller!, propName);
-
- defaultValue = copyDefaultValue(defaultValue);
-
- let type = desc.type || typeOf(defaultValue);
-
- let defaultValueSerialized = this.serializeQueryParam(defaultValue, urlKey, type);
- let scopedPropertyName = `${controllerName}:${propName}`;
- let qp = {
- undecoratedDefaultValue: get(controller!, propName),
- defaultValue,
- serializedDefaultValue: defaultValueSerialized,
- serializedValue: defaultValueSerialized,
-
- type,
- urlKey,
- prop: propName,
- scopedPropertyName,
- controllerName,
- route: this,
- parts, // provided later when stashNames is called if 'model' scope
- values: null, // provided later when setup is called. no idea why.
- scope,
- };
-
- map[propName] = map[urlKey] = map[scopedPropertyName] = qp;
- qps.push(qp);
- propertyNames.push(propName);
- }
-
- return {
- qps,
- map,
- propertyNames,
- states: {
- /*
- Called when a query parameter changes in the URL, this route cares
- about that query parameter, but the route is not currently
- in the active route hierarchy.
- */
- inactive: (prop: string, value: unknown) => {
- let qp = map[prop];
- this._qpChanged(prop, value, qp);
- },
- /*
- Called when a query parameter changes in the URL, this route cares
- about that query parameter, and the route is currently
- in the active route hierarchy.
- */
- active: (prop: string, value: unknown) => {
- let qp = map[prop];
- this._qpChanged(prop, value, qp);
- return this._activeQPChanged(qp, value);
- },
- /*
- Called when a value of a query parameter this route handles changes in a controller
- and the route is currently in the active route hierarchy.
- */
- allowOverrides: (prop: string, value: unknown) => {
- let qp = map[prop];
- this._qpChanged(prop, value, qp);
- return this._updatingQPChanged(qp);
- },
- },
- };
- }),
-
/**
Sends an action to the router, which will delegate it to the currently
active route hierarchy per the bubbling rules explained under `actions`.
@@ -2548,6 +2552,7 @@ Route.reopen(ActionHandler, Evented, {
}
}
},
+
/**
The controller associated with this route.
@@ -2752,16 +2757,7 @@ if (ROUTER_EVENTS) {
},
};
- Route.reopen(ROUTER_EVENT_DEPRECATIONS, {
- _paramsFor(routeName: string, params: {}) {
- let transition = this._router._routerMicrolib.activeTransition;
- if (transition !== undefined) {
- return this.paramsFor(routeName);
- }
-
- return params;
- },
- });
+ Route.reopen(ROUTER_EVENT_DEPRECATIONS);
}
export default Route;
| false |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
package.json
|
@@ -96,7 +96,7 @@
"auto-dist-tag": "^1.0.0",
"aws-sdk": "^2.686.0",
"babel-template": "^6.26.0",
- "backburner.js": "^2.6.0",
+ "backburner.js": "^2.7.0",
"broccoli-babel-transpiler": "^7.8.0",
"broccoli-file-creator": "^2.1.1",
"broccoli-persistent-filter": "^2.3.1",
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/@ember/-internals/views/lib/system/jquery.d.ts
|
@@ -0,0 +1,2 @@
+export let jQuery: any;
+export let jQueryDisabled: boolean;
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/@ember/engine/index.d.ts
|
@@ -1,7 +1,9 @@
-export { default as EngineInstance } from './instance';
+import EngineInstance from './instance';
+import { EngineInstanceOptions, Factory } from '@ember/-internals/owner';
+
export function getEngineParent(instance: EngineInstance): EngineInstance | undefined;
-import { EngineInstanceOptions, Factory } from '@ember/-internals/owner';
+export { EngineInstance };
export default class Engine {
constructor(...args: any[]);
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/@ember/runloop/index.d.ts
|
@@ -1,21 +1,25 @@
-import { Backburner, DeferredActionQueues, Timer } from 'backburner.js';
+import Backburner, { DeferredActionQueues, Timer } from 'backburner.js';
export const _backburner: Backburner;
-export const run = Backburner.run;
-export const schedule = Backburner.schedule;
-export const later = Backburner.later;
-export const join = Backburner.join;
-export const cancel = Backburner.cancel;
-export const scheduleOnce = Backburner.scheduleOnce;
+export const run: Backburner['run'];
+export const schedule: Backburner['schedule'];
+export const later: Backburner['later'];
+export const join: Backburner['join'];
+export const cancel: Backburner['cancel'];
+export const scheduleOnce: Backburner['scheduleOnce'];
export function _getCurrentRunLoop(): DeferredActionQueues;
export function once(method: Function): Timer;
-export function once<T, U extends keyof T>(target: T, method: U, ...args): Timer;
-export function once(target: unknown, method: unknown | Function, ...args): Timer;
+export function once<T, U extends keyof T>(target: T, method: U, ...args: any[]): Timer;
+export function once(target: unknown, method: unknown | Function, ...args: any[]): Timer;
export function bind<T extends Function>(target: T): T;
-export function bind<T extends Function, U>(target: unknown, method?: T, ...args: U): T;
-export function bind<T>(target: unknown, method?: string, ...args: T): Function;
+export function bind<T extends Function, U extends any[]>(
+ target: unknown,
+ method?: T,
+ ...args: U
+): T;
+export function bind<T extends any[]>(target: unknown, method?: string, ...args: T): Function;
export function bind<T>(target: unknown, method?: T, ...args: unknown[]): T;
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/assert-against-dynamic-helpers-modifiers.ts
|
@@ -7,7 +7,7 @@ import { isPath, trackLocals } from './utils';
export default function assertAgainstDynamicHelpersModifiers(
env: EmberASTPluginEnvironment
): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let { hasLocal, node } = trackLocals();
return {
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/assert-against-named-blocks.ts
|
@@ -14,7 +14,7 @@ import { EmberASTPluginEnvironment } from '../types';
@class AssertAgainstNamedBlocks
*/
export default function assertAgainstNamedBlocks(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
return {
name: 'assert-against-named-blocks',
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/assert-input-helper-without-block.ts
|
@@ -5,7 +5,7 @@ import { EmberASTPluginEnvironment } from '../types';
import { isPath } from './utils';
export default function errorOnInputWithContent(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
return {
name: 'assert-input-helper-without-block',
@@ -20,7 +20,7 @@ export default function errorOnInputWithContent(env: EmberASTPluginEnvironment):
};
}
-function assertMessage(moduleName: string, node: AST.BlockStatement): string {
+function assertMessage(moduleName: string | undefined, node: AST.BlockStatement): string {
let sourceInformation = calculateLocationDisplay(moduleName, node.loc);
return `The {{input}} helper cannot be used in block form. ${sourceInformation}`;
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/assert-reserved-named-arguments.ts
|
@@ -4,7 +4,7 @@ import calculateLocationDisplay from '../system/calculate-location-display';
import { EmberASTPluginEnvironment } from '../types';
export default function assertReservedNamedArguments(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
return {
name: 'assert-reserved-named-arguments',
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/assert-splattribute-expression.ts
|
@@ -4,7 +4,7 @@ import calculateLocationDisplay from '../system/calculate-location-display';
import { EmberASTPluginEnvironment } from '../types';
export default function assertSplattributeExpressions(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
return {
name: 'assert-splattribute-expressions',
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/deprecate-send-action.ts
|
@@ -18,7 +18,7 @@ const EVENTS = [
export default function deprecateSendAction(env: EmberASTPluginEnvironment): ASTPlugin {
if (SEND_ACTION) {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let deprecationMessage = (node: AST.Node, eventName: string, actionName: string) => {
let sourceInformation = calculateLocationDisplay(moduleName, node.loc);
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/deprecate-with.ts
|
@@ -58,7 +58,7 @@ import { isPath } from './utils';
@class DeprecateWith
*/
export default function deprecateWith(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let { builders: b } = env.syntax;
return {
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/transform-attrs-into-args.ts
|
@@ -29,7 +29,7 @@ import { EmberASTPluginEnvironment } from '../types';
export default function transformAttrsIntoArgs(env: EmberASTPluginEnvironment): ASTPlugin {
let { builders: b } = env.syntax;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let stack: string[][] = [[]];
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/transform-has-block-syntax.ts
|
@@ -32,7 +32,7 @@ const TRANSFORMATIONS: { [key: string]: string } = {
export default function transformHasBlockSyntax(env: EmberASTPluginEnvironment): ASTPlugin {
let { builders: b } = env.syntax;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
function emitDeprecationMessage(node: AST.Node, name: string) {
let sourceInformation = calculateLocationDisplay(moduleName, node.loc);
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/transform-in-element.ts
|
@@ -42,7 +42,7 @@ import { isPath } from './utils';
@class TransformInElement
*/
export default function transformInElement(env: EmberASTPluginEnvironment): ASTPlugin {
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let { builders: b } = env.syntax;
return {
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/transform-link-to.ts
|
@@ -43,7 +43,7 @@ function transformPositionalLinkToIntoNamedArguments(
hasBlock = true
): AST.BlockStatement {
let { builders: b } = env.syntax;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let {
params,
hash: { pairs },
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/transform-old-class-binding-syntax.ts
|
@@ -5,7 +5,7 @@ import { Builders, EmberASTPluginEnvironment } from '../types';
export default function transformOldClassBindingSyntax(env: EmberASTPluginEnvironment): ASTPlugin {
let b = env.syntax.builders;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
return {
name: 'transform-old-class-binding-syntax',
@@ -25,7 +25,7 @@ export default function transformOldClassBindingSyntax(env: EmberASTPluginEnviro
function process(
b: Builders,
node: AST.BlockStatement | AST.MustacheStatement,
- moduleName: string
+ moduleName: string | undefined
) {
let allOfTheMicrosyntaxes: AST.HashPair[] = [];
let allOfTheMicrosyntaxIndexes: number[] = [];
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/plugins/transform-resolutions.ts
|
@@ -65,7 +65,7 @@ const TARGETS = Object.freeze(['helper', 'modifier']);
export default function transformResolutions(env: EmberASTPluginEnvironment): ASTPlugin {
let { builders: b } = env.syntax;
- let { moduleName } = env.meta;
+ let moduleName = env.meta?.moduleName;
let { hasLocal, node: tracker } = trackLocals();
let seen: Set<AST.Node> | undefined;
@@ -155,7 +155,7 @@ function transformParams(
b: EmberASTPluginEnvironment['syntax']['builders'],
params: AST.Expression[],
type: string,
- moduleName: string,
+ moduleName: string | undefined,
loc: AST.SourceLocation | undefined
): AST.Expression[] {
let [first, ...rest] = params;
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/system/calculate-location-display.ts
|
@@ -1,7 +1,7 @@
import { AST } from '@glimmer/syntax';
export default function calculateLocationDisplay(
- moduleName: string,
+ moduleName: string | undefined,
loc?: AST.SourceLocation | undefined
): string {
let moduleInfo = '';
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/system/compile-options.ts
|
@@ -1,7 +1,6 @@
import { EMBER_STRICT_MODE } from '@ember/canary-features';
import { assert, deprecate } from '@ember/debug';
import { assign } from '@ember/polyfills';
-import { PrecompileOptions } from '@glimmer/compiler';
import { AST, ASTPlugin, ASTPluginEnvironment, Syntax } from '@glimmer/syntax';
import { RESOLUTION_MODE_TRANSFORMS, STRICT_MODE_TRANSFORMS } from '../plugins/index';
import { EmberPrecompileOptions, PluginFunc } from '../types';
@@ -13,16 +12,18 @@ function malformedComponentLookup(string: string) {
return string.indexOf('::') === -1 && string.indexOf(':') > -1;
}
-export function buildCompileOptions(
- _options: Partial<EmberPrecompileOptions>
-): EmberPrecompileOptions {
+export function buildCompileOptions(_options: EmberPrecompileOptions): EmberPrecompileOptions {
+ let moduleName = _options.moduleName;
let options: EmberPrecompileOptions = assign(
{ meta: {}, isProduction: false, plugins: { ast: [] } },
_options,
{
+ moduleName,
customizeComponentName(tagname: string): string {
assert(
- `You tried to invoke a component named <${tagname} /> in "${_options.moduleName}", but that is not a valid name for a component. Did you mean to use the "::" syntax for nested components?`,
+ `You tried to invoke a component named <${tagname} /> in "${
+ moduleName ?? '[NO MODULE]'
+ }", but that is not a valid name for a component. Did you mean to use the "::" syntax for nested components?`,
!malformedComponentLookup(tagname)
);
@@ -39,6 +40,7 @@ export function buildCompileOptions(
// move `moduleName` into `meta` property
if (options.moduleName) {
let meta = options.meta;
+ assert('has meta', meta); // We just set it
meta.moduleName = options.moduleName;
}
@@ -53,30 +55,32 @@ export function transformsFor(options: EmberPrecompileOptions): readonly PluginF
export default function compileOptions(
_options: Partial<EmberPrecompileOptions> = {}
-): PrecompileOptions {
+): EmberPrecompileOptions {
let options = buildCompileOptions(_options);
let builtInPlugins = transformsFor(options);
if (!_options.plugins) {
options.plugins = { ast: [...USER_PLUGINS, ...builtInPlugins] };
} else {
let potententialPugins = [...USER_PLUGINS, ...builtInPlugins];
+ assert('expected plugins', options.plugins);
let providedPlugins = options.plugins.ast.map((plugin) => wrapLegacyPluginIfNeeded(plugin));
let pluginsToAdd = potententialPugins.filter((plugin) => {
+ assert('expected plugins', options.plugins);
return options.plugins.ast.indexOf(plugin) === -1;
});
options.plugins.ast = providedPlugins.concat(pluginsToAdd);
}
- // TODO: Fix the types here so that this conversion isn't necessary
- return (options as unknown) as PrecompileOptions;
+ return options;
}
interface LegacyPlugin {
transform(node: AST.Program): AST.Node;
syntax: Syntax;
}
-type LegacyPluginClass = new (env: ASTPluginEnvironment) => LegacyPlugin;
+
+export type LegacyPluginClass = new (env: ASTPluginEnvironment) => LegacyPlugin;
function wrapLegacyPluginIfNeeded(_plugin: PluginFunc | LegacyPluginClass): PluginFunc {
let plugin = _plugin;
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember-template-compiler/lib/types.d.ts
|
@@ -1,10 +1,14 @@
-import { ASTPlugin, ASTPluginEnvironment, builders, PrecompileOptions } from '@glimmer/syntax';
-import { StaticTemplateMeta } from '@ember/-internals/views';
+import {
+ ASTPluginBuilder,
+ ASTPluginEnvironment,
+ builders,
+ PrecompileOptions,
+} from '@glimmer/syntax';
+import { LegacyPluginClass } from './system/compile-options';
export type Builders = typeof builders;
-export interface PluginFunc {
- (env: EmberASTPluginEnvironment): ASTPlugin;
+export interface PluginFunc extends ASTPluginBuilder<EmberASTPluginEnvironment> {
__raw?: LegacyPluginClass;
}
@@ -13,14 +17,9 @@ interface Plugins {
}
export interface EmberPrecompileOptions extends PrecompileOptions {
- strictMode?: boolean;
- locals?: string[];
- customizeComponentName(tag: string): string;
- isProduction: boolean;
- contents?: string;
+ isProduction?: boolean;
moduleName?: string;
- plugins: Plugins;
- meta: StaticTemplateMeta;
+ plugins?: Plugins;
}
export type EmberASTPluginEnvironment = ASTPluginEnvironment & EmberPrecompileOptions;
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
packages/ember/index.d.ts
|
@@ -1,5 +1,5 @@
declare module 'ember' {
- declare const Ember: any;
+ const Ember: any;
export default Ember;
}
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
tsconfig.json
|
@@ -23,10 +23,6 @@
"noEmit": true,
"allowJs": false,
- // TODO: remove this once router_js types have been fixed
- // https://github.com/tildeio/router.js/issues/290
- "skipLibCheck": true,
-
"paths": {
"@glimmer/*": ["../node_modules/@glimmer/*"]
}
| true |
Other
|
emberjs
|
ember.js
|
eb88fde44846dc0e4a20b16fb64ed562b7abe2d5.json
|
Resolve types from external libraries
|
yarn.lock
|
@@ -2520,10 +2520,10 @@ backbone@^1.1.2:
dependencies:
underscore ">=1.8.3"
-backburner.js@^2.6.0:
- version "2.6.0"
- resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-2.6.0.tgz#ff3315c38026cc52eb4447ce8de80ca71dd4cff0"
- integrity "sha1-/zMVw4AmzFLrREfOjegMpx3Uz/A= sha512-mN3OPIffal2CgTisLaJ4yaMOvZukD9PJYJBQ+5gg1WoSPVAjctvmmX+7qb9N6SIQHt0ONcZC99laWA+Ol/IIEw=="
+backburner.js@^2.7.0:
+ version "2.7.0"
+ resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-2.7.0.tgz#36a5b8a8bfceb7efc8ad56e006a238924acfd67e"
+ integrity sha512-eBZC6r7wT+YYAOKeru8IqgzOimz3VgyspXiZ1k6MI8i10zUdU8cnNII56rlnItQ89cHgQO3C/nPuFW3V9di+zg==
[email protected]:
version "1.0.2"
| true |
Other
|
emberjs
|
ember.js
|
8e02b9dc273413dfd3dfafc44b247df8769df1c9.json
|
Add comment explaining 'if' guard
|
packages/@ember/-internals/routing/lib/system/route.ts
|
@@ -502,6 +502,7 @@ class Route extends EmberObject implements IRoute {
loading(transition, route) {
const controller = this.controllerFor('foo');
+ // The controller may not be instantiated when initially loading
if (controller) {
controller.currentlyLoading = true;
| false |
Other
|
emberjs
|
ember.js
|
62e7b92b1e29a5af2aa821bef5c902066c37948b.json
|
change public to private
|
packages/@ember/-internals/glimmer/lib/components/-link-to.ts
|
@@ -637,7 +637,7 @@ const LinkComponent = EmberComponent.extend({
* link-to-external component extends the link-to component.
*
* @method assertLinkToOrigin
- * @public
+ * @private
*/
assertLinkToOrigin() {
assert(
| false |
Other
|
emberjs
|
ember.js
|
3a1bfa250dd5f2e2e03f3a4cadf97f5967ea36cf.json
|
add assertLinkToOrigin to tests/docs/expected.js
|
packages/@ember/-internals/glimmer/lib/components/-link-to.ts
|
@@ -637,6 +637,7 @@ const LinkComponent = EmberComponent.extend({
* link-to-external component extends the link-to component.
*
* @method assertLinkToOrigin
+ * @public
*/
assertLinkToOrigin() {
assert(
| true |
Other
|
emberjs
|
ember.js
|
3a1bfa250dd5f2e2e03f3a4cadf97f5967ea36cf.json
|
add assertLinkToOrigin to tests/docs/expected.js
|
tests/docs/expected.js
|
@@ -92,6 +92,7 @@ module.exports = {
'arrayContentWillChange',
'assert',
'assertDestroyablesDestroyed',
+ 'assertLinkToOrigin',
'assign',
'associateDestroyableChild',
'asyncEnd',
| true |
Other
|
emberjs
|
ember.js
|
c30f0b4dc780da35bc16afcea83bc85f31999909.json
|
fix linting errors
|
packages/@ember/-internals/glimmer/lib/components/-link-to.ts
|
@@ -645,7 +645,7 @@ const LinkComponent = EmberComponent.extend({
'See https://ember-engines.com/docs/links for more info.',
!this._isEngine || this._engineMountPoint !== undefined
);
- }
+ },
_isActive(routerState: RouterState): boolean {
if (this.loading) {
| false |
Other
|
emberjs
|
ember.js
|
3a6a3ab2fcf666af5c4d5acf89042331c3c27328.json
|
Add v3.27.0-beta.2 to CHANGELOG.md.
|
CHANGELOG.md
|
@@ -1,6 +1,11 @@
# Ember Changelog
-### v3.27.0 (March 22, 2021)
+### v3.27.0-beta.2 (March 25, 2021)
+
+- [#19473](https://github.com/emberjs/ember.js/pull/19473) Update GlimmerVM to latest (fix compatibility for template import proposals)
+- [#19474](https://github.com/emberjs/ember.js/pull/19474) [FEATURE] Enable `(helper` and `(modifier` helpers
+
+### v3.27.0-beta.1 (March 22, 2021)
- [#19382](https://github.com/emberjs/ember.js/pull/19382) / [#19430](https://github.com/emberjs/ember.js/pull/19430) [FEATURE] Remaining implementation work per [RFC #671](https://github.com/emberjs/rfcs/blob/master/text/0671-modernize-built-in-components-1.md).
- [#19457](https://github.com/emberjs/ember.js/pull/19457) / [#19463](https://github.com/emberjs/ember.js/pull/19463) / [#19464](https://github.com/emberjs/ember.js/pull/19464) / [#19467](https://github.com/emberjs/ember.js/pull/19467) [DEPRECATION] Add deprecation for the Ember Global per [RFC #706](https://github.com/emberjs/rfcs/blob/master/text/0706-deprecate-ember-global.md).
| false |
Other
|
emberjs
|
ember.js
|
3b9eee2e6e08885ab6f93b0ce81f0e6be5a870c7.json
|
Add 3.26.1 to CHANGELOG.md.
|
CHANGELOG.md
|
@@ -14,6 +14,10 @@
- [#19441](https://github.com/emberjs/ember.js/pull/19441) Add automated publishing of weekly alpha releases to NPM
- [#19462](https://github.com/emberjs/ember.js/pull/19462) Use `positional` and `named` as the argument names in `ember g helper` blueprint
+### v3.26.1 (March 24, 2021)
+
+- [#19473](https://github.com/emberjs/ember.js/pull/19473) Update Glimmer VM to latest.
+
### v3.26.0 (March 22, 2021)
- [#19255](https://github.com/emberjs/ember.js/pull/19255) [DEPRECATION] Deprecate transition methods of controller and route per [RFC #674](https://github.com/emberjs/rfcs/blob/master/text/0674-deprecate-transition-methods-of-controller-and-route.md).
| false |
Other
|
emberjs
|
ember.js
|
d3a764c35b5363c180519cf3cf0e04e1cf44f75e.json
|
Add v3.25.4 to CHANGELOG.md.
(cherry picked from commit ee25b41214aefe89edd75551f0c6e8125a60eb9b)
|
CHANGELOG.md
|
@@ -34,6 +34,10 @@
- [#19405](https://github.com/emberjs/ember.js/pull/19405) [BUGFIX] Avoid instantiation errors when `app/router.js` injects the router service.
- [#19436](https://github.com/emberjs/ember.js/pull/19436) [BUGFIX] Support observer keys with colons
+### v3.25.4 (March 24, 2021)
+
+- [#19473](https://github.com/emberjs/ember.js/pull/19473) Update Glimmer VM to latest.
+
### v3.25.3 (March 7, 2021)
- [#19448](https://github.com/emberjs/ember.js/pull/19448) Ensure query params are preserved through an intermediate loading state transition
| false |
Other
|
emberjs
|
ember.js
|
e503e67adcb7bc86f8876d81c0e3d9e3110422bf.json
|
Add v3.27.0-beta.1 to CHANGELOG
(cherry picked from commit 19ffb4993c28301f6321b347e3a887ab64e5fa44)
|
CHANGELOG.md
|
@@ -1,5 +1,19 @@
# Ember Changelog
+### v3.27.0 (March 22, 2021)
+
+- [#19382](https://github.com/emberjs/ember.js/pull/19382) / [#19430](https://github.com/emberjs/ember.js/pull/19430) [FEATURE] Remaining implementation work per [RFC #671](https://github.com/emberjs/rfcs/blob/master/text/0671-modernize-built-in-components-1.md).
+- [#19457](https://github.com/emberjs/ember.js/pull/19457) / [#19463](https://github.com/emberjs/ember.js/pull/19463) / [#19464](https://github.com/emberjs/ember.js/pull/19464) / [#19467](https://github.com/emberjs/ember.js/pull/19467) [DEPRECATION] Add deprecation for the Ember Global per [RFC #706](https://github.com/emberjs/rfcs/blob/master/text/0706-deprecate-ember-global.md).
+- [#19407](https://github.com/emberjs/ember.js/pull/19407) [DEPRECATION] Add deprecation for `Route#disconnectOutlet` per [RFC #491](https://github.com/emberjs/rfcs/blob/master/text/0491-deprecate-disconnect-outlet.md).
+- [#19433](https://github.com/emberjs/ember.js/pull/19433) [DEPRECATION] Add deprecation for `Route#renderTemplate` per [RFC #418](https://github.com/emberjs/rfcs/blob/master/text/0418-deprecate-route-render-methods.md).
+- [#19442](https://github.com/emberjs/ember.js/pull/19442) [DEPRECATION] Add deprecation for `Route#render` method per [RFC #418](https://github.com/emberjs/rfcs/blob/master/text/0418-deprecate-route-render-methods.md).
+- [#19429](https://github.com/emberjs/ember.js/pull/19429) [DEPRECATION] `registerPlugin` / `unregisterPlugin` and legacy class based AST plugins (private APIs)
+- [#19466](https://github.com/emberjs/ember.js/pull/19466) [BUGFIX] Rename private runloop functions
+- [#19384](https://github.com/emberjs/ember.js/pull/19384) Use qunit-dom in helper and component test blueprints
+- [#19390](https://github.com/emberjs/ember.js/pull/19390) Refactor the internal Ember loader to use the standard Ember CLI loader
+- [#19441](https://github.com/emberjs/ember.js/pull/19441) Add automated publishing of weekly alpha releases to NPM
+- [#19462](https://github.com/emberjs/ember.js/pull/19462) Use `positional` and `named` as the argument names in `ember g helper` blueprint
+
### v3.26.0 (March 22, 2021)
- [#19255](https://github.com/emberjs/ember.js/pull/19255) [DEPRECATION] Deprecate transition methods of controller and route per [RFC #674](https://github.com/emberjs/rfcs/blob/master/text/0674-deprecate-transition-methods-of-controller-and-route.md).
| false |
Other
|
emberjs
|
ember.js
|
d622b7c4282dcdae57d389a01e889afbd0ff93fc.json
|
Add v3.26.0 to CHANGELOG
(cherry picked from commit 8cebe0a3b87292434c440489edf4cae44cdd2119)
|
CHANGELOG.md
|
@@ -1,31 +1,6 @@
# Ember Changelog
-### v3.26.0-beta.5 (March 16, 2021)
-
-- [#19405](https://github.com/emberjs/ember.js/pull/19405) [BUGFIX] Avoid instantiation errors when `app/router.js` injects the router service.
-
-### v3.26.0-beta.4 (March 08, 2021)
-
-- [#19436](https://github.com/emberjs/ember.js/pull/19436) [BUGFIX] Support observer keys with colons
-- [#19448](https://github.com/emberjs/ember.js/pull/19448) [BUGFIX] Ensure query params are preserved through an intermediate loading state transition
-- [#19450](https://github.com/emberjs/ember.js/pull/19450) [BUGFIX] Ensure `routerService.currentRoute.name` and `routerService.currentRouteName` match during loading states
-
-### v3.26.0-beta.3 (March 02, 2021)
-
-- [#19412](https://github.com/emberjs/ember.js/pull/19412) [BUGFIX] Updates Glimmer VM to 0.76.0, fix:
- - `if` helper returns `null` instead of `undefined`
- - Using `get` helper with key `length` on a string in templates
- - Value of input not updating if it had previously updated with the same string
-- [#19416](https://github.com/emberjs/ember.js/pull/19416) [BUGFIX] Update Glimmer VM to 0.77, fix dynamic helpers/modifiers
-
-### v3.26.0-beta.2 (February 15, 2021)
-
-- [#19387](https://github.com/emberjs/ember.js/pull/19387) [BUGFIX] LinkTo with incomplete model failing in rendering tests
-- [#19395](https://github.com/emberjs/ember.js/pull/19395) [BUGFIX] Only return empty href when LinkTo href generation throws error
-- [#19396](https://github.com/emberjs/ember.js/pull/19396) [BUGFIX] Revert deprecation of htmlSafe and isHTMLSafe
-- [#19397](https://github.com/emberjs/ember.js/pull/19397) [BUGFIX] Force building Ember bundles when `targets.node` is defined
-
-### v3.26.0-beta.1 (February 08, 2021)
+### v3.26.0 (March 22, 2021)
- [#19255](https://github.com/emberjs/ember.js/pull/19255) [DEPRECATION] Deprecate transition methods of controller and route per [RFC #674](https://github.com/emberjs/rfcs/blob/master/text/0674-deprecate-transition-methods-of-controller-and-route.md).
- [#19345](https://github.com/emberjs/ember.js/pull/19345) [DEPRECATION] Deprecate `<LinkTo>` positional arguments per [RFC #698](https://github.com/emberjs/rfcs/blob/master/text/0698-deprecate-link-to-positional-arguments.md).
@@ -41,8 +16,9 @@
- [#19379](https://github.com/emberjs/ember.js/pull/19379) [CLEANUP] Refactor DataAdapter to not use observers or array observers
- [#19378](https://github.com/emberjs/ember.js/pull/19378) [BUGFIX] Fix typo in template-only-glimmer-components feature detection
- [#19298](https://github.com/emberjs/ember.js/pull/19298) [BUGFIX] Route serialize did not extract param off proxy
-- [#19326](https://github.com/emberjs/ember.js/pull/19326) [BUGFIX] Lazily setup the router in non-application tests for <LinkTo> component
-
+- [#19469](https://github.com/emberjs/ember.js/pull/19469) [BUGFIX] Prevent eager argument consumption on modifier destruction
+- [#19405](https://github.com/emberjs/ember.js/pull/19405) [BUGFIX] Avoid instantiation errors when `app/router.js` injects the router service.
+- [#19436](https://github.com/emberjs/ember.js/pull/19436) [BUGFIX] Support observer keys with colons
### v3.25.3 (March 7, 2021)
| false |
Other
|
emberjs
|
ember.js
|
04f28b234bd990e56bd3a93d7bb0485719f065e4.json
|
Add deprecation for the Ember Global
|
packages/@ember/-internals/bootstrap/index.js
|
@@ -1,5 +1,6 @@
import require from 'require';
import { context } from '@ember/-internals/environment';
+import { deprecate } from '@ember/debug';
(function () {
let Ember;
@@ -13,6 +14,20 @@ import { context } from '@ember/-internals/environment';
Ember = require('ember').default;
}
+ deprecate(
+ 'Usage of the Ember Global is deprecated. You should import the Ember module or the specific API instead.',
+ false,
+ {
+ id: 'ember-global',
+ until: '4.0.0',
+ url: 'https://deprecations.emberjs.com/v3.x/#toc_ember-global',
+ for: 'ember-source',
+ since: {
+ enabled: '3.27.0',
+ },
+ }
+ );
+
return Ember;
},
});
| true |
Other
|
emberjs
|
ember.js
|
04f28b234bd990e56bd3a93d7bb0485719f065e4.json
|
Add deprecation for the Ember Global
|
packages/internal-test-helpers/lib/test-cases/default-resolver-application.js
|
@@ -12,7 +12,7 @@ export default class DefaultResolverApplicationTestCase extends AbstractApplicat
let application;
expectDeprecation(() => {
application = this.application = Application.create(this.applicationOptions);
- }, /Using the globals resolver is deprecated/);
+ }, /(Using the globals resolver is deprecated|Usage of the Ember Global is deprecated)/);
// If the test expects a certain number of assertions, increment that number
let { assert } = QUnit.config.current;
| true |
Other
|
emberjs
|
ember.js
|
e25282f6e854a1c9e4fb318b7aa162542b964804.json
|
Add v3.26.0-beta.5 to CHANGELOG
(cherry picked from commit 9c0ab229425ac239cf402b277dea530e93fc54e8)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.26.0-beta.5 (March 16, 2021)
+
+- [#19405](https://github.com/emberjs/ember.js/pull/19405) [BUGFIX] Avoid instantiation errors when `app/router.js` injects the router service.
+
### v3.26.0-beta.4 (March 08, 2021)
- [#19436](https://github.com/emberjs/ember.js/pull/19436) [BUGFIX] Support observer keys with colons
| false |
Other
|
emberjs
|
ember.js
|
75fa7e35aadf5d260e5e9a14fe28634da0fccd82.json
|
Add v3.26.0-beta.4 to CHANGELOG
(cherry picked from commit 4d85839ca69cace64f6185ab184fc24f3f5c02d8)
|
CHANGELOG.md
|
@@ -1,5 +1,11 @@
# Ember Changelog
+### v3.26.0-beta.4 (March 08, 2021)
+
+- [#19436](https://github.com/emberjs/ember.js/pull/19436) [BUGFIX] Support observer keys with colons
+- [#19448](https://github.com/emberjs/ember.js/pull/19448) [BUGFIX] Ensure query params are preserved through an intermediate loading state transition
+- [#19450](https://github.com/emberjs/ember.js/pull/19450) [BUGFIX] Ensure `routerService.currentRoute.name` and `routerService.currentRouteName` match during loading states
+
### v3.26.0-beta.3 (March 02, 2021)
- [#19412](https://github.com/emberjs/ember.js/pull/19412) [BUGFIX] Updates Glimmer VM to 0.76.0, fix:
| false |
Other
|
emberjs
|
ember.js
|
891fc1bd25b9736e0d645bda01155d3023f7fab1.json
|
Add v3.26.0-beta.3 to CHANGELOG
(cherry picked from commit b91e6f37ee917bccf535fffd3459ee443c037dd5)
|
CHANGELOG.md
|
@@ -1,5 +1,13 @@
# Ember Changelog
+### v3.26.0-beta.3 (March 02, 2021)
+
+- [#19412](https://github.com/emberjs/ember.js/pull/19412) [BUGFIX] Updates Glimmer VM to 0.76.0, fix:
+ - `if` helper returns `null` instead of `undefined`
+ - Using `get` helper with key `length` on a string in templates
+ - Value of input not updating if it had previously updated with the same string
+- [#19416](https://github.com/emberjs/ember.js/pull/19416) [BUGFIX] Update Glimmer VM to 0.77, fix dynamic helpers/modifiers
+
### v3.26.0-beta.2 (February 15, 2021)
- [#19387](https://github.com/emberjs/ember.js/pull/19387) [BUGFIX] LinkTo with incomplete model failing in rendering tests
| false |
Other
|
emberjs
|
ember.js
|
56c3520b0e52e5bc7f357b5865c34a23eefd98e7.json
|
Add v3.24.3, v3.25.2, and v3.25.3 to CHANGELOG.md.
|
CHANGELOG.md
|
@@ -25,6 +25,23 @@
- [#19298](https://github.com/emberjs/ember.js/pull/19298) [BUGFIX] Route serialize did not extract param off proxy
- [#19326](https://github.com/emberjs/ember.js/pull/19326) [BUGFIX] Lazily setup the router in non-application tests for <LinkTo> component
+
+### v3.25.3 (March 7, 2021)
+
+- [#19448](https://github.com/emberjs/ember.js/pull/19448) Ensure query params are preserved through an intermediate loading state transition
+- [#19450](https://github.com/emberjs/ember.js/pull/19450) Ensure `routerService.currentRoute.name` and `routerService.currentRouteName` match during loading states
+
+
+### v3.25.2 (March 7, 2021)
+
+- [#19389](https://github.com/emberjs/ember.js/pull/19389) Removes template ids
+- [#19395](https://github.com/emberjs/ember.js/pull/19395) [BUGFIX] Ensure `<LinkTo>` can return a valid `href` most of the time
+- [#19396](https://github.com/emberjs/ember.js/pull/19396) [BUGFIX] Revert deprecation of htmlSafe and isHTMLSafe
+- [#19397](https://github.com/emberjs/ember.js/pull/19397) [BUGFIX] Force building Ember bundles when `targets.node` is defined
+- [#19399](https://github.com/emberjs/ember.js/pull/19399) [DOC] Update ArrayProxy Documentation
+- [#19412](https://github.com/emberjs/ember.js/pull/19412) / [#19416](https://github.com/emberjs/ember.js/pull/19416) [BUGFIX] Update Glimmer VM to 0.77 (fix dynamic helpers/modifiers)
+
+
### v3.25.1 (February 10, 2021)
- [#19326](https://github.com/emberjs/ember.js/pull/19326) / [#19387](https://github.com/emberjs/ember.js/pull/19387) [BUGFIX] Fix usage of `<LinkTo />` prior to routing (e.g. component rendering tests)
@@ -43,6 +60,15 @@
- [#19338](https://github.com/emberjs/ember.js/pull/19338) [BUGFIX] Add missing `deprecate` options (`for` + `since`)
- [#19342](https://github.com/emberjs/ember.js/pull/19342) [BUGFIX] Fix misleading LinkTo error message
+
+### v3.24.3 (March 7, 2021)
+
+- [#19448](https://github.com/emberjs/ember.js/pull/19448) Ensure query params are preserved through an intermediate loading state transition
+- [#19450](https://github.com/emberjs/ember.js/pull/19450) Ensure `routerService.currentRoute.name` and `routerService.currentRouteName` match during loading states
+- [#19395](https://github.com/emberjs/ember.js/pull/19395) [BUGFIX] Ensure `<LinkTo>` can return a valid `href` most of the time
+- [#19397](https://github.com/emberjs/ember.js/pull/19397) [BUGFIX] Force building Ember bundles when `targets.node` is defined
+
+
### v3.24.2 (February 10, 2021)
- [#19326](https://github.com/emberjs/ember.js/pull/19326) / [#19387](https://github.com/emberjs/ember.js/pull/19387) [BUGFIX] Fix usage of `<LinkTo />` prior to routing (e.g. component rendering tests)
| false |
Other
|
emberjs
|
ember.js
|
7dbeded1db214814040d987df8b40fc95e8badd6.json
|
add tests to highlight #19307
|
packages/ember/tests/routing/substates_test.js
|
@@ -1,5 +1,7 @@
import { RSVP } from '@ember/-internals/runtime';
import { Route } from '@ember/-internals/routing';
+import Controller from '@ember/controller';
+
import { moduleFor, ApplicationTestCase, runTask } from 'internal-test-helpers';
let counter;
@@ -193,6 +195,155 @@ moduleFor(
});
}
+ ['@test Enter loading route with correct query parameters'](assert) {
+ let deferred = RSVP.defer();
+
+ this.router.map(function () {
+ this.route('dummy');
+ });
+
+ this.add(
+ 'route:dummy',
+ Route.extend({
+ model() {
+ step(assert, 1, 'DummyRoute#model');
+ return deferred.promise;
+ },
+ })
+ );
+
+ this.add(
+ 'controller:application',
+ class extends Controller {
+ queryParams = ['qux'];
+
+ qux = 'initial';
+ }
+ );
+
+ this.add(
+ 'route:loading',
+ Route.extend({
+ setupController() {
+ step(assert, 2, 'LoadingRoute#setupController');
+ },
+ })
+ );
+ this.addTemplate('dummy', 'DUMMY');
+
+ return this.visit('/?qux=updated').then(() => {
+ assert.equal(
+ this.getController('application').qux,
+ 'updated',
+ 'the application controller has the correct qp value'
+ );
+
+ let promise = this.visit('/dummy?qux=updated').then(() => {
+ let text = this.$('#app').text();
+
+ assert.equal(text, 'DUMMY', `dummy template has been rendered`);
+ assert.equal(
+ this.getController('application').qux,
+ 'updated',
+ 'the application controller has the correct qp value'
+ );
+ });
+
+ assert.equal(this.currentPath, 'loading', `loading state entered`);
+ assert.equal(
+ this.currentURL,
+ '/dummy?qux=updated',
+ `during loading url reflect the correct state`
+ );
+ assert.equal(
+ this.getController('application').qux,
+ 'updated',
+ 'the application controller has the correct qp value'
+ );
+
+ deferred.resolve();
+
+ return promise;
+ });
+ }
+
+ ['@test Enter child-loading route with correct query parameters'](assert) {
+ assert.expect(9);
+ let deferred = RSVP.defer();
+
+ this.router.map(function () {
+ this.route('parent', function () {
+ this.route('child');
+ });
+ });
+
+ this.add(
+ 'route:parent.child',
+ Route.extend({
+ model() {
+ step(assert, 1, 'ChildRoute#model');
+ return deferred.promise;
+ },
+ })
+ );
+
+ this.add(
+ 'controller:parent',
+ class extends Controller {
+ queryParams = ['qux'];
+
+ qux = 'initial';
+ }
+ );
+
+ this.add(
+ 'route:parent.child_loading',
+ Route.extend({
+ setupController() {
+ step(assert, 2, 'ChildLoadingRoute#setupController');
+ },
+ })
+ );
+ this.addTemplate('parent', 'PARENT {{outlet}}');
+
+ this.addTemplate('parent.child', 'CHILD');
+
+ return this.visit('/parent?qux=updated').then(() => {
+ assert.equal(
+ this.getController('parent').qux,
+ 'updated',
+ 'in the parent route, the parent controller has the correct qp value'
+ );
+
+ let promise = this.visit('/parent/child?qux=updated').then(() => {
+ let text = this.$('#app').text();
+
+ assert.equal(text, 'PARENT CHILD', `child template has been rendered`);
+ assert.equal(
+ this.getController('parent').qux,
+ 'updated',
+ 'after entered in the parent.child route, the parent controller has the correct qp value'
+ );
+ });
+
+ assert.equal(this.currentPath, 'parent.child_loading', `child loading state entered`);
+ assert.equal(
+ this.currentURL,
+ '/parent/child?qux=updated',
+ `during child loading, url reflect the correct state`
+ );
+ assert.equal(
+ this.getController('parent').qux,
+ 'updated',
+ 'in the child_loading route, the parent controller has the correct qp value'
+ );
+
+ deferred.resolve();
+
+ return promise;
+ });
+ }
+
['@test Slow promises returned from ApplicationRoute#model enter ApplicationLoadingRoute if present'](
assert
) {
| false |
Other
|
emberjs
|
ember.js
|
0b84bc8207472f271210b0503a811c3c4b3d6dd9.json
|
add rendered output of each-in
|
packages/@ember/-internals/glimmer/lib/helpers/each-in.ts
|
@@ -148,7 +148,14 @@ import { internalHelper } from './internal-helper';
</ul>
```
- Outputting their name and age.
+ Outputting their name and age:
+
+ ```html
+ <ul>
+ <li>name: Shelly Sails</li>
+ <li>age: 42</li>
+ </ul>
+ ```
@method each-in
@for Ember.Templates.helpers
| false |
Other
|
emberjs
|
ember.js
|
7765a6758be8b8473f06d41bd02914b904485d70.json
|
Use symbol to create private render method
|
packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts
|
@@ -222,12 +222,12 @@ if (ENV._DEBUG_RENDER_TREE) {
}
renderTemplate(_: Controller, { showHeader }: Model): void {
- expectDeprecation(() => this.render(), 'Usage of `render` is deprecated.');
+ expectDeprecation(() => this.render(), /Usage of `render` is deprecated/);
if (showHeader) {
expectDeprecation(
() => this.render('header', { outlet: 'header' }),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
} else {
expectDeprecation(
| true |
Other
|
emberjs
|
ember.js
|
7765a6758be8b8473f06d41bd02914b904485d70.json
|
Use symbol to create private render method
|
packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js
|
@@ -470,7 +470,7 @@ moduleFor(
into: 'application',
outlet: 'nav',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -617,7 +617,7 @@ moduleFor(
renderTemplate(controller, model) {
expectDeprecation(
() => this.render({ controller: model.color, model }),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
})
@@ -666,7 +666,7 @@ moduleFor(
renderTemplate(controller, model) {
expectDeprecation(
() => this.render('common', { controller: 'common', model }),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
})
@@ -682,7 +682,7 @@ moduleFor(
renderTemplate(controller, model) {
expectDeprecation(
() => this.render('common', { controller: 'common', model }),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
})
| true |
Other
|
emberjs
|
ember.js
|
7765a6758be8b8473f06d41bd02914b904485d70.json
|
Use symbol to create private render method
|
packages/@ember/-internals/routing/lib/system/route.ts
|
@@ -20,7 +20,7 @@ import {
Object as EmberObject,
typeOf,
} from '@ember/-internals/runtime';
-import { isProxy, lookupDescriptor } from '@ember/-internals/utils';
+import { isProxy, lookupDescriptor, symbol } from '@ember/-internals/utils';
import Controller from '@ember/controller';
import { assert, deprecate, info, isTesting } from '@ember/debug';
import { ROUTER_EVENTS } from '@ember/deprecated-features';
@@ -49,6 +49,7 @@ import generateController from './generate_controller';
import EmberRouter, { QueryParam } from './router';
export const ROUTE_CONNECTIONS = new WeakMap();
+const RENDER = symbol('render') as string;
export function defaultSerialize(
model: {},
@@ -1486,10 +1487,10 @@ class Route extends EmberObject implements IRoute {
}
/**
- `_render` is used to render a template into a region of another template
+ `this[RENDER]` is used to render a template into a region of another template
(indicated by an `{{outlet}}`).
- @method _render
+ @method this[RENDER]
@param {String} name the name of the template to render
@param {Object} [options] the options
@param {String} [options.into] the template to render into,
@@ -1502,7 +1503,7 @@ class Route extends EmberObject implements IRoute {
Defaults to the return value of the Route's model hook
@private
*/
- _render(name?: string, options?: PartialRenderOptions) {
+ [RENDER](name?: string, options?: PartialRenderOptions) {
let renderOptions = buildRenderOptions(this, name, options);
ROUTE_CONNECTIONS.get(this).push(renderOptions);
once(this._router, '_setOutlets');
@@ -1544,7 +1545,7 @@ class Route extends EmberObject implements IRoute {
*/
renderTemplate(_controller: any, _model: {}) {
// eslint-disable-line no-unused-vars
- this._render();
+ this[RENDER]();
}
/**
@@ -1675,7 +1676,7 @@ class Route extends EmberObject implements IRoute {
@public
*/
render(name?: string, options?: PartialRenderOptions) {
- deprecate('Usage of `render` is deprecated.', false, {
+ deprecate(`Usage of \`render\` is deprecated. Route: \`${this.routeName}\``, false, {
id: 'route-render-template',
until: '4.0.0',
url: 'https://deprecations.emberjs.com/v3.x/#toc_route-render-template',
@@ -1684,7 +1685,7 @@ class Route extends EmberObject implements IRoute {
enabled: '3.27.0',
},
});
- this._render(name, options);
+ this[RENDER](name, options);
}
/**
| true |
Other
|
emberjs
|
ember.js
|
7765a6758be8b8473f06d41bd02914b904485d70.json
|
Use symbol to create private render method
|
packages/ember/tests/routing/model_loading_test.js
|
@@ -216,7 +216,7 @@ moduleFor(
renderTemplate() {
expectDeprecation(
() => this.render('alternative_home'),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
})
| true |
Other
|
emberjs
|
ember.js
|
7765a6758be8b8473f06d41bd02914b904485d70.json
|
Use symbol to create private render method
|
packages/ember/tests/routing/template_rendering_test.js
|
@@ -76,7 +76,7 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
+ expectDeprecation(() => this.render('homepage'), /Usage of `render` is deprecated/);
},
})
);
@@ -93,7 +93,7 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
+ expectDeprecation(() => this.render('homepage'), /Usage of `render` is deprecated/);
},
})
);
@@ -121,7 +121,7 @@ moduleFor(
Route.extend({
controllerName: 'foo',
renderTemplate() {
- expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
+ expectDeprecation(() => this.render('homepage'), /Usage of `render` is deprecated/);
},
})
);
@@ -161,7 +161,7 @@ moduleFor(
renderTemplate() {
expectDeprecation(
() => this.render({ controller: 'home' }),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
})
@@ -202,7 +202,7 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
+ expectDeprecation(() => this.render('homepage'), /Usage of `render` is deprecated/);
},
})
);
@@ -226,7 +226,7 @@ moduleFor(
this.render('bio', {
model: { name: 'emberjs' },
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -276,7 +276,7 @@ moduleFor(
into: 'home',
outlet: 'alert',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
},
})
@@ -306,7 +306,7 @@ moduleFor(
Route.extend({
templateName: 'alert',
renderTemplate() {
- expectDeprecation(() => this.render({}), 'Usage of `render` is deprecated.');
+ expectDeprecation(() => this.render({}), /Usage of `render` is deprecated/);
},
})
);
@@ -429,7 +429,7 @@ moduleFor(
renderTemplate() {
expectDeprecation(
() => this.render('middle/bottom', { into: 'top' }),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
})
@@ -467,7 +467,7 @@ moduleFor(
expectDeprecation(() => {
this.render('person/profile');
this.render('person/details', { into: 'person/profile' });
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -503,7 +503,7 @@ moduleFor(
into: 'application',
outlet: 'menu',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -653,7 +653,7 @@ moduleFor(
renderTemplate() {
expectDeprecation(
() => this.render('shared', { controller: 'shared' }),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
});
@@ -736,7 +736,7 @@ moduleFor(
into: 'application',
outlet: 'footer',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -806,7 +806,7 @@ moduleFor(
into: 'application',
outlet: 'modal',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
hideModal() {
expectDeprecation(
@@ -831,7 +831,7 @@ moduleFor(
this.render('posts/extra', {
into: 'posts/index',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
hideExtra() {
expectDeprecation(
@@ -940,7 +940,7 @@ moduleFor(
into: 'application',
outlet: 'modal',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
hideModal() {
expectDeprecation(
@@ -1017,7 +1017,7 @@ moduleFor(
showModal() {
expectDeprecation(
() => this.render('modal', { into: 'posts', outlet: 'modal' }),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
hideModal() {
@@ -1040,9 +1040,10 @@ moduleFor(
}
['@test Specifying non-existent controller name in route#render throws'](assert) {
- expectDeprecation('Usage of `renderTemplate` is deprecated.');
- expectDeprecation('Usage of `render` is deprecated.');
- assert.expect(3);
+ expectDeprecation(
+ /(Usage of `renderTemplate` is deprecated|Usage of `render` is deprecated)/
+ );
+ assert.expect(2);
this.router.map(function () {
this.route('home', { path: '/' });
@@ -1109,7 +1110,7 @@ moduleFor(
into: 'application',
outlet: 'other',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -1142,7 +1143,7 @@ moduleFor(
into: 'application',
outlet: 'other',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
actions: {
banish() {
@@ -1192,7 +1193,7 @@ moduleFor(
into: 'application',
outlet: 'other',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -1220,7 +1221,7 @@ moduleFor(
into: 'application',
outlet: 'other',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
},
})
@@ -1267,7 +1268,7 @@ moduleFor(
outlet: 'common',
into: 'app',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -1281,7 +1282,7 @@ moduleFor(
outlet: 'sub',
into: 'app',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
})
);
@@ -1328,7 +1329,7 @@ moduleFor(
into: 'application',
outlet: 'modal',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
close() {
expectDeprecation(
@@ -1371,10 +1372,7 @@ moduleFor(
'route:root',
Route.extend({
renderTemplate() {
- expectDeprecation(
- () => this.render('exports/root'),
- 'Usage of `render` is deprecated.'
- );
+ expectDeprecation(() => this.render('exports/root'), /Usage of `render` is deprecated/);
},
})
);
@@ -1385,7 +1383,7 @@ moduleFor(
renderTemplate() {
expectDeprecation(
() => this.render('exports/index'),
- 'Usage of `render` is deprecated.'
+ /Usage of `render` is deprecated/
);
},
})
@@ -1414,7 +1412,7 @@ moduleFor(
into: 'application',
outlet: 'modal',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
},
})
@@ -1536,7 +1534,7 @@ moduleFor(
outlet: undefined,
parentView: 'application',
});
- }, 'Usage of `render` is deprecated.');
+ }, /Usage of `render` is deprecated/);
},
hideModal() {
expectDeprecation(
| true |
Other
|
emberjs
|
ember.js
|
7765a6758be8b8473f06d41bd02914b904485d70.json
|
Use symbol to create private render method
|
tests/docs/expected.js
|
@@ -49,7 +49,6 @@ module.exports = {
'_qpChanged',
'_qpDelegate',
'_queryParamsFor',
- '_render',
'_renderMode',
'_resolveCache',
'_serializeQueryParam',
@@ -557,6 +556,7 @@ module.exports = {
'testing',
'textarea',
'then',
+ 'this[RENDER]',
'throttle',
'title',
'to',
| true |
Other
|
emberjs
|
ember.js
|
51d3614d0c9eef9d2161b54f743caae9b9007a7c.json
|
Add deprecation for `render` method
|
packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts
|
@@ -222,10 +222,13 @@ if (ENV._DEBUG_RENDER_TREE) {
}
renderTemplate(_: Controller, { showHeader }: Model): void {
- this.render();
+ expectDeprecation(() => this.render(), 'Usage of `render` is deprecated.');
if (showHeader) {
- this.render('header', { outlet: 'header' });
+ expectDeprecation(
+ () => this.render('header', { outlet: 'header' }),
+ 'Usage of `render` is deprecated.'
+ );
} else {
expectDeprecation(
() => this.disconnectOutlet('header'),
| true |
Other
|
emberjs
|
ember.js
|
51d3614d0c9eef9d2161b54f743caae9b9007a7c.json
|
Add deprecation for `render` method
|
packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js
|
@@ -464,11 +464,13 @@ moduleFor(
'route:application',
Route.extend({
renderTemplate() {
- this.render();
- this.render('nav', {
- into: 'application',
- outlet: 'nav',
- });
+ expectDeprecation(() => {
+ this.render();
+ this.render('nav', {
+ into: 'application',
+ outlet: 'nav',
+ });
+ }, 'Usage of `render` is deprecated.');
},
})
);
@@ -613,7 +615,10 @@ moduleFor(
},
renderTemplate(controller, model) {
- this.render({ controller: model.color, model });
+ expectDeprecation(
+ () => this.render({ controller: model.color, model }),
+ 'Usage of `render` is deprecated.'
+ );
},
})
);
@@ -659,7 +664,10 @@ moduleFor(
},
renderTemplate(controller, model) {
- this.render('common', { controller: 'common', model });
+ expectDeprecation(
+ () => this.render('common', { controller: 'common', model }),
+ 'Usage of `render` is deprecated.'
+ );
},
})
);
@@ -672,7 +680,10 @@ moduleFor(
},
renderTemplate(controller, model) {
- this.render('common', { controller: 'common', model });
+ expectDeprecation(
+ () => this.render('common', { controller: 'common', model }),
+ 'Usage of `render` is deprecated.'
+ );
},
})
);
| true |
Other
|
emberjs
|
ember.js
|
51d3614d0c9eef9d2161b54f743caae9b9007a7c.json
|
Add deprecation for `render` method
|
packages/@ember/-internals/routing/lib/system/route.ts
|
@@ -1485,6 +1485,29 @@ class Route extends EmberObject implements IRoute {
return route && route.currentModel;
}
+ /**
+ `_render` is used to render a template into a region of another template
+ (indicated by an `{{outlet}}`).
+
+ @method _render
+ @param {String} name the name of the template to render
+ @param {Object} [options] the options
+ @param {String} [options.into] the template to render into,
+ referenced by name. Defaults to the parent template
+ @param {String} [options.outlet] the outlet inside `options.into` to render into.
+ Defaults to 'main'
+ @param {String|Object} [options.controller] the controller to use for this template,
+ referenced by name or as a controller instance. Defaults to the Route's paired controller
+ @param {Object} [options.model] the model object to set on `options.controller`.
+ Defaults to the return value of the Route's model hook
+ @private
+ */
+ _render(name?: string, options?: PartialRenderOptions) {
+ let renderOptions = buildRenderOptions(this, name, options);
+ ROUTE_CONNECTIONS.get(this).push(renderOptions);
+ once(this._router, '_setOutlets');
+ }
+
/**
A hook you can use to render the template for the current route.
@@ -1521,7 +1544,7 @@ class Route extends EmberObject implements IRoute {
*/
renderTemplate(_controller: any, _model: {}) {
// eslint-disable-line no-unused-vars
- this.render();
+ this._render();
}
/**
@@ -1652,9 +1675,16 @@ class Route extends EmberObject implements IRoute {
@public
*/
render(name?: string, options?: PartialRenderOptions) {
- let renderOptions = buildRenderOptions(this, name, options);
- ROUTE_CONNECTIONS.get(this).push(renderOptions);
- once(this._router, '_setOutlets');
+ deprecate('Usage of `render` is deprecated.', false, {
+ id: 'route-render-template',
+ until: '4.0.0',
+ url: 'https://deprecations.emberjs.com/v3.x/#toc_route-render-template',
+ for: 'ember-source',
+ since: {
+ enabled: '3.27.0',
+ },
+ });
+ this._render(name, options);
}
/**
| true |
Other
|
emberjs
|
ember.js
|
51d3614d0c9eef9d2161b54f743caae9b9007a7c.json
|
Add deprecation for `render` method
|
packages/ember/tests/routing/model_loading_test.js
|
@@ -214,7 +214,10 @@ moduleFor(
Route.extend({
controllerName: 'myController',
renderTemplate() {
- this.render('alternative_home');
+ expectDeprecation(
+ () => this.render('alternative_home'),
+ 'Usage of `render` is deprecated.'
+ );
},
})
);
| true |
Other
|
emberjs
|
ember.js
|
51d3614d0c9eef9d2161b54f743caae9b9007a7c.json
|
Add deprecation for `render` method
|
packages/ember/tests/routing/template_rendering_test.js
|
@@ -76,7 +76,7 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- this.render('homepage');
+ expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
},
})
);
@@ -93,7 +93,7 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- this.render('homepage');
+ expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
},
})
);
@@ -121,7 +121,7 @@ moduleFor(
Route.extend({
controllerName: 'foo',
renderTemplate() {
- this.render('homepage');
+ expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
},
})
);
@@ -159,7 +159,10 @@ moduleFor(
'route:homepage',
Route.extend({
renderTemplate() {
- this.render({ controller: 'home' });
+ expectDeprecation(
+ () => this.render({ controller: 'home' }),
+ 'Usage of `render` is deprecated.'
+ );
},
})
);
@@ -199,7 +202,7 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- this.render('homepage');
+ expectDeprecation(() => this.render('homepage'), 'Usage of `render` is deprecated.');
},
})
);
@@ -219,9 +222,11 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- this.render('bio', {
- model: { name: 'emberjs' },
- });
+ expectDeprecation(() => {
+ this.render('bio', {
+ model: { name: 'emberjs' },
+ });
+ }, 'Usage of `render` is deprecated.');
},
})
);
@@ -266,10 +271,12 @@ moduleFor(
templateName: 'the_real_home_template',
actions: {
showAlert() {
- this.render('alert', {
- into: 'home',
- outlet: 'alert',
- });
+ expectDeprecation(() => {
+ this.render('alert', {
+ into: 'home',
+ outlet: 'alert',
+ });
+ }, 'Usage of `render` is deprecated.');
},
},
})
@@ -299,7 +306,7 @@ moduleFor(
Route.extend({
templateName: 'alert',
renderTemplate() {
- this.render({});
+ expectDeprecation(() => this.render({}), 'Usage of `render` is deprecated.');
},
})
);
@@ -420,7 +427,10 @@ moduleFor(
'route:middle.bottom',
Route.extend({
renderTemplate() {
- this.render('middle/bottom', { into: 'top' });
+ expectDeprecation(
+ () => this.render('middle/bottom', { into: 'top' }),
+ 'Usage of `render` is deprecated.'
+ );
},
})
);
@@ -454,8 +464,10 @@ moduleFor(
'route:home',
Route.extend({
renderTemplate() {
- this.render('person/profile');
- this.render('person/details', { into: 'person/profile' });
+ expectDeprecation(() => {
+ this.render('person/profile');
+ this.render('person/details', { into: 'person/profile' });
+ }, 'Usage of `render` is deprecated.');
},
})
);
@@ -485,11 +497,13 @@ moduleFor(
'route:posts',
Route.extend({
renderTemplate() {
- this.render();
- this.render('posts/menu', {
- into: 'application',
- outlet: 'menu',
- });
+ expectDeprecation(() => {
+ this.render();
+ this.render('posts/menu', {
+ into: 'application',
+ outlet: 'menu',
+ });
+ }, 'Usage of `render` is deprecated.');
},
})
);
@@ -637,7 +651,10 @@ moduleFor(
},
renderTemplate() {
- this.render('shared', { controller: 'shared' });
+ expectDeprecation(
+ () => this.render('shared', { controller: 'shared' }),
+ 'Usage of `render` is deprecated.'
+ );
},
});
@@ -707,17 +724,19 @@ moduleFor(
'route:posts',
Route.extend({
renderTemplate() {
- this.render('posts/menu', {
- into: 'application',
- outlet: 'menu',
- });
+ expectDeprecation(() => {
+ this.render('posts/menu', {
+ into: 'application',
+ outlet: 'menu',
+ });
- this.render();
+ this.render();
- this.render('posts/footer', {
- into: 'application',
- outlet: 'footer',
- });
+ this.render('posts/footer', {
+ into: 'application',
+ outlet: 'footer',
+ });
+ }, 'Usage of `render` is deprecated.');
},
})
);
@@ -782,10 +801,12 @@ moduleFor(
Route.extend({
actions: {
showModal() {
- this.render('posts/modal', {
- into: 'application',
- outlet: 'modal',
- });
+ expectDeprecation(() => {
+ this.render('posts/modal', {
+ into: 'application',
+ outlet: 'modal',
+ });
+ }, 'Usage of `render` is deprecated.');
},
hideModal() {
expectDeprecation(
@@ -806,9 +827,11 @@ moduleFor(
Route.extend({
actions: {
showExtra() {
- this.render('posts/extra', {
- into: 'posts/index',
- });
+ expectDeprecation(() => {
+ this.render('posts/extra', {
+ into: 'posts/index',
+ });
+ }, 'Usage of `render` is deprecated.');
},
hideExtra() {
expectDeprecation(
@@ -912,10 +935,12 @@ moduleFor(
Route.extend({
actions: {
showModal() {
- this.render('posts/modal', {
- into: 'application',
- outlet: 'modal',
- });
+ expectDeprecation(() => {
+ this.render('posts/modal', {
+ into: 'application',
+ outlet: 'modal',
+ });
+ }, 'Usage of `render` is deprecated.');
},
hideModal() {
expectDeprecation(
@@ -965,7 +990,7 @@ moduleFor(
}
['@test Route silently fails when cleaning an outlet from an inactive view'](assert) {
- assert.expect(3); // handleURL
+ assert.expect(4); // handleURL
this.addTemplate('application', '{{outlet}}');
this.addTemplate('posts', "{{outlet 'modal'}}");
@@ -990,7 +1015,10 @@ moduleFor(
);
},
showModal() {
- this.render('modal', { into: 'posts', outlet: 'modal' });
+ expectDeprecation(
+ () => this.render('modal', { into: 'posts', outlet: 'modal' }),
+ 'Usage of `render` is deprecated.'
+ );
},
hideModal() {
expectDeprecation(
@@ -1013,7 +1041,8 @@ moduleFor(
['@test Specifying non-existent controller name in route#render throws'](assert) {
expectDeprecation('Usage of `renderTemplate` is deprecated.');
- assert.expect(2);
+ expectDeprecation('Usage of `render` is deprecated.');
+ assert.expect(3);
this.router.map(function () {
this.route('home', { path: '/' });
@@ -1074,11 +1103,13 @@ moduleFor(
'route:application',
Route.extend({
renderTemplate() {
- this.render();
- this.render('modal', {
- into: 'application',
- outlet: 'other',
- });
+ expectDeprecation(() => {
+ this.render();
+ this.render('modal', {
+ into: 'application',
+ outlet: 'other',
+ });
+ }, 'Usage of `render` is deprecated.');
},
})
);
@@ -1105,11 +1136,13 @@ moduleFor(
'route:application',
Route.extend({
renderTemplate() {
- this.render();
- this.render('modal', {
- into: 'application',
- outlet: 'other',
- });
+ expectDeprecation(() => {
+ this.render();
+ this.render('modal', {
+ into: 'application',
+ outlet: 'other',
+ });
+ }, 'Usage of `render` is deprecated.');
},
actions: {
banish() {
@@ -1153,11 +1186,13 @@ moduleFor(
'route:application',
Route.extend({
renderTemplate() {
- this.render();
- this.render('modal', {
- into: 'application',
- outlet: 'other',
- });
+ expectDeprecation(() => {
+ this.render();
+ this.render('modal', {
+ into: 'application',
+ outlet: 'other',
+ });
+ }, 'Usage of `render` is deprecated.');
},
})
);
@@ -1180,10 +1215,12 @@ moduleFor(
Route.extend({
actions: {
launch() {
- this.render('modal', {
- into: 'application',
- outlet: 'other',
- });
+ expectDeprecation(() => {
+ this.render('modal', {
+ into: 'application',
+ outlet: 'other',
+ });
+ }, 'Usage of `render` is deprecated.');
},
},
})
@@ -1221,14 +1258,16 @@ moduleFor(
'route:app',
Route.extend({
renderTemplate() {
- this.render('app', {
- outlet: 'app',
- into: 'application',
- });
- this.render('common', {
- outlet: 'common',
- into: 'app',
- });
+ expectDeprecation(() => {
+ this.render('app', {
+ outlet: 'app',
+ into: 'application',
+ });
+ this.render('common', {
+ outlet: 'common',
+ into: 'app',
+ });
+ }, 'Usage of `render` is deprecated.');
},
})
);
@@ -1237,10 +1276,12 @@ moduleFor(
'route:sub',
Route.extend({
renderTemplate() {
- this.render('sub', {
- outlet: 'sub',
- into: 'app',
- });
+ expectDeprecation(() => {
+ this.render('sub', {
+ outlet: 'sub',
+ into: 'app',
+ });
+ }, 'Usage of `render` is deprecated.');
},
})
);
@@ -1282,10 +1323,12 @@ moduleFor(
Route.extend({
actions: {
openLayer() {
- this.render('layer', {
- into: 'application',
- outlet: 'modal',
- });
+ expectDeprecation(() => {
+ this.render('layer', {
+ into: 'application',
+ outlet: 'modal',
+ });
+ }, 'Usage of `render` is deprecated.');
},
close() {
expectDeprecation(
@@ -1328,7 +1371,10 @@ moduleFor(
'route:root',
Route.extend({
renderTemplate() {
- this.render('exports/root');
+ expectDeprecation(
+ () => this.render('exports/root'),
+ 'Usage of `render` is deprecated.'
+ );
},
})
);
@@ -1337,7 +1383,10 @@ moduleFor(
'route:root.index',
Route.extend({
renderTemplate() {
- this.render('exports/index');
+ expectDeprecation(
+ () => this.render('exports/index'),
+ 'Usage of `render` is deprecated.'
+ );
},
})
);
@@ -1360,10 +1409,12 @@ moduleFor(
Route.extend({
actions: {
openLayer() {
- this.render('layer', {
- into: 'application',
- outlet: 'modal',
- });
+ expectDeprecation(() => {
+ this.render('layer', {
+ into: 'application',
+ outlet: 'modal',
+ });
+ }, 'Usage of `render` is deprecated.');
},
},
})
@@ -1480,10 +1531,12 @@ moduleFor(
Route.extend({
actions: {
showModal() {
- this.render({
- outlet: undefined,
- parentView: 'application',
- });
+ expectDeprecation(() => {
+ this.render({
+ outlet: undefined,
+ parentView: 'application',
+ });
+ }, 'Usage of `render` is deprecated.');
},
hideModal() {
expectDeprecation(
| true |
Other
|
emberjs
|
ember.js
|
51d3614d0c9eef9d2161b54f743caae9b9007a7c.json
|
Add deprecation for `render` method
|
tests/docs/expected.js
|
@@ -49,6 +49,7 @@ module.exports = {
'_qpChanged',
'_qpDelegate',
'_queryParamsFor',
+ '_render',
'_renderMode',
'_resolveCache',
'_serializeQueryParam',
| true |
Other
|
emberjs
|
ember.js
|
b44adfee09f25d7dae36f8c831517f904798eb73.json
|
Update version to `3.27.0-alpha.0`.
|
package.json
|
@@ -1,6 +1,6 @@
{
"name": "ember-source",
- "version": "3.27.0",
+ "version": "3.27.0-alpha.0",
"description": "A JavaScript framework for creating ambitious web applications",
"keywords": [
"ember-addon"
| false |
Other
|
emberjs
|
ember.js
|
21350a5d8b9aa886390045701125d97143e682a0.json
|
Fix failing tests
|
packages/ember-testing/tests/acceptance_test.js
|
@@ -51,6 +51,7 @@ if (!jQueryDisabled) {
'route:posts',
Route.extend({
renderTemplate() {
+ expectDeprecation('Usage of `renderTemplate` is deprecated.');
testContext.currentRoute = 'posts';
this._super(...arguments);
},
@@ -73,6 +74,7 @@ if (!jQueryDisabled) {
'route:comments',
Route.extend({
renderTemplate() {
+ expectDeprecation('Usage of `renderTemplate` is deprecated.');
testContext.currentRoute = 'comments';
this._super(...arguments);
},
@@ -125,7 +127,7 @@ if (!jQueryDisabled) {
}
[`@test helpers can be chained with then`](assert) {
- assert.expect(6);
+ assert.expect(8);
window
.visit('/posts')
@@ -164,7 +166,7 @@ if (!jQueryDisabled) {
}
[`@test helpers can be chained to each other (legacy)`](assert) {
- assert.expect(7);
+ assert.expect(10);
window
.visit('/posts')
@@ -192,7 +194,7 @@ if (!jQueryDisabled) {
}
[`@test helpers don't need to be chained`](assert) {
- assert.expect(5);
+ assert.expect(8);
window.visit('/posts');
@@ -219,7 +221,7 @@ if (!jQueryDisabled) {
}
[`@test Nested async helpers`](assert) {
- assert.expect(5);
+ assert.expect(8);
window.visit('/posts');
@@ -247,7 +249,7 @@ if (!jQueryDisabled) {
}
[`@test Multiple nested async helpers`](assert) {
- assert.expect(3);
+ assert.expect(5);
window.visit('/posts');
@@ -270,7 +272,7 @@ if (!jQueryDisabled) {
}
[`@test Helpers nested in thens`](assert) {
- assert.expect(5);
+ assert.expect(8);
window.visit('/posts').then(() => {
window.click('a:first', '#comments-link');
@@ -311,7 +313,7 @@ if (!jQueryDisabled) {
}
[`@test Unhandled exceptions are logged via Ember.Test.adapter#exception`](assert) {
- assert.expect(2);
+ assert.expect(3);
console.error = () => {}; // eslint-disable-line no-console
let asyncHandled;
@@ -343,7 +345,7 @@ if (!jQueryDisabled) {
[`@test Unhandled exceptions in 'andThen' are logged via Ember.Test.adapter#exception`](
assert
) {
- assert.expect(1);
+ assert.expect(2);
console.error = () => {}; // eslint-disable-line no-console
Test.adapter = QUnitAdapter.create({
@@ -364,7 +366,7 @@ if (!jQueryDisabled) {
}
[`@test should not start routing on the root URL when visiting another`](assert) {
- assert.expect(4);
+ assert.expect(5);
window.visit('/posts');
@@ -427,7 +429,7 @@ if (!jQueryDisabled) {
}
[`@test visiting a URL that causes another transition should yield the correct URL`](assert) {
- assert.expect(2);
+ assert.expect(3);
window.visit('/redirect');
@@ -439,7 +441,7 @@ if (!jQueryDisabled) {
[`@test visiting a URL and then visiting a second URL with a transition should yield the correct URL`](
assert
) {
- assert.expect(3);
+ assert.expect(5);
window.visit('/posts');
| true |
Other
|
emberjs
|
ember.js
|
21350a5d8b9aa886390045701125d97143e682a0.json
|
Fix failing tests
|
packages/ember/tests/routing/template_rendering_test.js
|
@@ -305,7 +305,7 @@ moduleFor(
}
['@test Generated names can be customized when providing routes with dot notation'](assert) {
- assert.expect(4);
+ assert.expect(5);
this.addTemplate('index', '<div>Index</div>');
this.addTemplate('application', "<h1>Home</h1><div class='main'>{{outlet}}</div>");
@@ -325,6 +325,7 @@ moduleFor(
'route:foo',
Route.extend({
renderTemplate() {
+ expectDeprecation('Usage of `renderTemplate` is deprecated.');
assert.ok(true, 'FooBarRoute was called');
return this._super(...arguments);
},
| true |
Other
|
emberjs
|
ember.js
|
2676ee3b90c269a9b6606ec082dc66945317092d.json
|
Add renderTemplate deprecation
|
packages/@ember/-internals/routing/lib/system/route.ts
|
@@ -1507,6 +1507,17 @@ class Route extends EmberObject implements IRoute {
@public
*/
renderTemplate(_controller: any, _model: {}) {
+ if (this.renderTemplate !== Route.prototype.renderTemplate) {
+ deprecate('Usage of `renderTemplate` is deprecated.', false, {
+ id: 'route-render-template',
+ until: '4.0.0',
+ url: 'https://deprecations.emberjs.com/v3.x/#toc_route-render-template',
+ for: 'ember-source',
+ since: {
+ enabled: '3.27.0',
+ },
+ });
+ }
// eslint-disable-line no-unused-vars
this.render();
}
| false |
Other
|
emberjs
|
ember.js
|
e522fdc6192a45251d44dcb35deb8be1ab87294f.json
|
Add deprecation method to disconnectOutlet
|
packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts
|
@@ -4,6 +4,8 @@ import {
moduleFor,
strip,
} from 'internal-test-helpers';
+import { ExpectDeprecationFunc } from '../../../../../../internal-test-helpers/lib/ember-dev/deprecation';
+declare let expectDeprecation: ExpectDeprecationFunc;
import { ENV } from '@ember/-internals/environment';
import { Component, setComponentManager } from '@ember/-internals/glimmer';
@@ -225,7 +227,10 @@ if (ENV._DEBUG_RENDER_TREE) {
if (showHeader) {
this.render('header', { outlet: 'header' });
} else {
- this.disconnectOutlet('header');
+ expectDeprecation(
+ () => this.disconnectOutlet('header'),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
}
}
}
| true |
Other
|
emberjs
|
ember.js
|
e522fdc6192a45251d44dcb35deb8be1ab87294f.json
|
Add deprecation method to disconnectOutlet
|
packages/@ember/-internals/routing/lib/system/route.ts
|
@@ -1705,6 +1705,15 @@ class Route extends EmberObject implements IRoute {
@public
*/
disconnectOutlet(options: string | { outlet: string; parentView?: string }) {
+ deprecate('The usage of `disconnectOutlet` is deprecated.', false, {
+ id: 'route-disconnect-outlet',
+ until: '4.0.0',
+ url: 'https://deprecations.emberjs.com/v3.x/#toc_route-disconnect-outlet',
+ for: 'ember-source',
+ since: {
+ enabled: '3.27.0',
+ },
+ });
let outletName;
let parentView;
if (options) {
| true |
Other
|
emberjs
|
ember.js
|
e522fdc6192a45251d44dcb35deb8be1ab87294f.json
|
Add deprecation method to disconnectOutlet
|
packages/ember/tests/routing/template_rendering_test.js
|
@@ -775,10 +775,14 @@ moduleFor(
});
},
hideModal() {
- this.disconnectOutlet({
- outlet: 'modal',
- parentView: 'application',
- });
+ expectDeprecation(
+ () =>
+ this.disconnectOutlet({
+ outlet: 'modal',
+ parentView: 'application',
+ }),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
},
},
})
@@ -794,7 +798,10 @@ moduleFor(
});
},
hideExtra() {
- this.disconnectOutlet({ parentView: 'posts/index' });
+ expectDeprecation(
+ () => this.disconnectOutlet({ parentView: 'posts/index' }),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
},
},
})
@@ -898,7 +905,10 @@ moduleFor(
});
},
hideModal() {
- this.disconnectOutlet('modal');
+ expectDeprecation(
+ () => this.disconnectOutlet('modal'),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
},
},
})
@@ -942,7 +952,7 @@ moduleFor(
}
['@test Route silently fails when cleaning an outlet from an inactive view'](assert) {
- assert.expect(1); // handleURL
+ assert.expect(3); // handleURL
this.addTemplate('application', '{{outlet}}');
this.addTemplate('posts', "{{outlet 'modal'}}");
@@ -957,16 +967,23 @@ moduleFor(
Route.extend({
actions: {
hideSelf() {
- this.disconnectOutlet({
- outlet: 'main',
- parentView: 'application',
- });
+ expectDeprecation(
+ () =>
+ this.disconnectOutlet({
+ outlet: 'main',
+ parentView: 'application',
+ }),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
},
showModal() {
this.render('modal', { into: 'posts', outlet: 'modal' });
},
hideModal() {
- this.disconnectOutlet({ outlet: 'modal', parentView: 'posts' });
+ expectDeprecation(
+ () => this.disconnectOutlet({ outlet: 'modal', parentView: 'posts' }),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
},
},
})
@@ -1080,10 +1097,14 @@ moduleFor(
},
actions: {
banish() {
- this.disconnectOutlet({
- parentView: 'application',
- outlet: 'other',
- });
+ expectDeprecation(
+ () =>
+ this.disconnectOutlet({
+ parentView: 'application',
+ outlet: 'other',
+ }),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
},
},
})
@@ -1249,10 +1270,14 @@ moduleFor(
});
},
close() {
- this.disconnectOutlet({
- outlet: 'modal',
- parentView: 'application',
- });
+ expectDeprecation(
+ () =>
+ this.disconnectOutlet({
+ outlet: 'modal',
+ parentView: 'application',
+ }),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
},
},
})
@@ -1329,10 +1354,14 @@ moduleFor(
Route.extend({
actions: {
close() {
- this.disconnectOutlet({
- parentView: 'application',
- outlet: 'modal',
- });
+ expectDeprecation(
+ () =>
+ this.disconnectOutlet({
+ parentView: 'application',
+ outlet: 'modal',
+ }),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
},
},
})
@@ -1438,10 +1467,14 @@ moduleFor(
});
},
hideModal() {
- this.disconnectOutlet({
- outlet: undefined,
- parentView: 'application',
- });
+ expectDeprecation(
+ () =>
+ this.disconnectOutlet({
+ outlet: undefined,
+ parentView: 'application',
+ }),
+ 'The usage of `disconnectOutlet` is deprecated.'
+ );
},
},
})
| true |
Other
|
emberjs
|
ember.js
|
3ce48a43a36083dd14615a018dd6fb53d953c669.json
|
Fix glimmer-component-docs.ts typo in Markdown
Was also affecting a heading anchor link. Kudos to @kaermorchen.
|
packages/@ember/-internals/glimmer/lib/glimmer-component-docs.ts
|
@@ -158,7 +158,7 @@
to `{{yield}}`. Whenever you invoke a component without passing explicitly
named blocks, the passed block is considered the `default` block.
- ### Passing parameters to named bxlocks
+ ### Passing parameters to named blocks
You can also pass parameters to named blocks:
| false |
Other
|
emberjs
|
ember.js
|
4daccb827dffb1e4494219ca831ccb7613f5294c.json
|
unskip strict mode test
|
packages/@ember/-internals/glimmer/tests/integration/components/strict-mode-test.js
|
@@ -162,7 +162,7 @@ if (EMBER_STRICT_MODE) {
moduleFor(
'Strict Mode - built ins',
class extends RenderingTestCase {
- '@skip Can use Input'() {
+ '@test Can use Input'() {
let Foo = defineComponent({ Input }, '<Input/>');
this.registerComponent('foo', { ComponentClass: Foo });
| false |
Other
|
emberjs
|
ember.js
|
3a7c034cdc81c3ed05508f64c630e2041995d2f8.json
|
Add v3.25.1 to CHANGELOG.
(cherry picked from commit 647279b71c15eb2de8c0ac68d078ed2c583d41dd)
|
CHANGELOG.md
|
@@ -25,6 +25,10 @@
- [#19298](https://github.com/emberjs/ember.js/pull/19298) [BUGFIX] Route serialize did not extract param off proxy
- [#19326](https://github.com/emberjs/ember.js/pull/19326) [BUGFIX] Lazily setup the router in non-application tests for <LinkTo> component
+### v3.25.1 (February 10, 2021)
+
+- [#19326](https://github.com/emberjs/ember.js/pull/19326) / [#19387](https://github.com/emberjs/ember.js/pull/19387) [BUGFIX] Fix usage of `<LinkTo />` prior to routing (e.g. component rendering tests)
+
### v3.25.0 (February 08, 2021)
- [#19302](https://github.com/emberjs/ember.js/pull/19302) / [#19306](https://github.com/emberjs/ember.js/pull/19306) / [#19319](https://github.com/emberjs/ember.js/pull/19319) [FEATURE] Implement the [Handlebars Strict Mode RFC](https://github.com/emberjs/rfcs/blob/master/text/0496-handlebars-strict-mode.md).
| false |
Other
|
emberjs
|
ember.js
|
aa2594b09b8ce8e2df794aa46a1f86d03442ca43.json
|
Add v3.24.2 to CHANGELOG.md.
(cherry picked from commit 98745fbf3f9feb17d5fe32a8dcbb7c2c2b41bd06)
|
CHANGELOG.md
|
@@ -39,6 +39,10 @@
- [#19338](https://github.com/emberjs/ember.js/pull/19338) [BUGFIX] Add missing `deprecate` options (`for` + `since`)
- [#19342](https://github.com/emberjs/ember.js/pull/19342) [BUGFIX] Fix misleading LinkTo error message
+### v3.24.2 (February 10, 2021)
+
+- [#19326](https://github.com/emberjs/ember.js/pull/19326) / [#19387](https://github.com/emberjs/ember.js/pull/19387) [BUGFIX] Fix usage of `<LinkTo />` prior to routing (e.g. component rendering tests)
+
### v3.24.1 (January 14, 2021)
- [#19337](https://github.com/emberjs/ember.js/pull/19337) [BUGFIX] Ensure query param only `<LinkTo />` are properly scoped in engines
| false |
Other
|
emberjs
|
ember.js
|
7f6cd8f743a7cc2f762a69f44455a7f169ac7bac.json
|
Add v3.16.0-beta.2 to CHANGELOG
(cherry picked from commit dd26c4edd3659a314cc7419899e4b6933b9df013)
|
CHANGELOG.md
|
@@ -1,5 +1,12 @@
# Ember Changelog
+### v3.26.0-beta.2 (February 15, 2021)
+
+- [#19387](https://github.com/emberjs/ember.js/pull/19387) [BUGFIX] LinkTo with incomplete model failing in rendering tests
+- [#19395](https://github.com/emberjs/ember.js/pull/19395) [BUGFIX] Only return empty href when LinkTo href generation throws error
+- [#19396](https://github.com/emberjs/ember.js/pull/19396) [BUGFIX] Revert deprecation of htmlSafe and isHTMLSafe
+- [#19397](https://github.com/emberjs/ember.js/pull/19397) [BUGFIX] Force building Ember bundles when `targets.node` is defined
+
### v3.26.0-beta.1 (February 08, 2021)
- [#19255](https://github.com/emberjs/ember.js/pull/19255) [DEPRECATION] Deprecate transition methods of controller and route per [RFC #674](https://github.com/emberjs/rfcs/blob/master/text/0674-deprecate-transition-methods-of-controller-and-route.md).
| false |
Other
|
emberjs
|
ember.js
|
74e1b93e809eb59ed5ad3e2b1c412d170cc1ff1d.json
|
remove redundant comment and scenario
|
packages/@ember/-internals/routing/lib/services/routing.ts
|
@@ -54,10 +54,9 @@ export default class RoutingService extends Service {
generateURL(routeName: string, models: {}[], queryParams: {}) {
let router = this.router;
- // return early when the router microlib is not present, which is the case for <LinkTo/> in integration tests
- // also return early when transition has not started, when rendering in tests without visit(),
+ // Return early when transition has not started, when rendering in tests without visit(),
// we cannot infer the route context which <LinkTo/> needs be aware of
- if (!router._routerMicrolib || !router._initialTransitionStarted) {
+ if (!router._initialTransitionStarted) {
return;
}
| false |
Other
|
emberjs
|
ember.js
|
6802d0d2413104f11208adc24e9847e602418145.json
|
add failing test
While generating link to route "dynamicWithChild.child": can't access
property "shouldSupercede", newHandlerInfo is undefined
|
packages/@ember/-internals/glimmer/tests/integration/components/link-to/rendering-angle-test.js
|
@@ -1,5 +1,11 @@
-import { moduleFor, ApplicationTestCase, RenderingTestCase, runTask } from 'internal-test-helpers';
-
+import {
+ moduleFor,
+ ApplicationTestCase,
+ RenderingTestCase,
+ RouterNonApplicationTestCase,
+ runTask,
+} from 'internal-test-helpers';
+import { Router, Route } from '@ember/-internals/routing';
import Controller from '@ember/controller';
import { set } from '@ember/-internals/metal';
import { LinkComponent } from '@ember/-internals/glimmer';
@@ -92,6 +98,40 @@ moduleFor(
this.assertText('Hello');
});
}
+
+ ['@test able to pupolate innermost dynamic segment when immediate parent route is active']() {
+ this.addTemplate('application', '{{outlet}}');
+ this.addTemplate('parents', '{{outlet}}');
+ this.addTemplate(
+ 'parents.parent',
+ '<LinkTo @route="parents.parent.child" @model=1>Link To Child</LinkTo>'
+ );
+ this.addTemplate(
+ 'parents.parent.child',
+ '<LinkTo @route="parents.parent">Link To Parent</LinkTo>'
+ );
+ this.add(
+ 'route:parents.parent',
+ class extends Route {
+ async model({ id }) {
+ return { value: id };
+ }
+ }
+ );
+ this.router.map(function () {
+ this.route('parents', function () {
+ this.route('parent', { path: '/:parent_id' }, function () {
+ this.route('children');
+ this.route('child', { path: '/child/:child_id' });
+ });
+ });
+ });
+ debugger;
+ return this.visit('/parents/1').then(() => {
+ debugger;
+ this.assertText('Link To Child');
+ });
+ }
}
);
@@ -109,3 +149,35 @@ moduleFor(
}
}
);
+
+moduleFor(
+ '<LinkTo /> component (rendering tests, with router not started)',
+ class extends RouterNonApplicationTestCase {
+ constructor() {
+ super(...arguments);
+ this.resolver.add('router:main', Router.extend(this.routerOptions));
+ this.router.map(function () {
+ this.route('dynamicWithChild', { path: '/dynamic-with-child/:dynamic_id' }, function () {
+ this.route('child');
+ });
+ });
+ }
+ get routerOptions() {
+ return {
+ location: 'none',
+ };
+ }
+ get router() {
+ return this.owner.resolveRegistration('router:main');
+ }
+
+ ['@test should be able to be inserted in DOM when router is setup but not started']() {
+ this.render(`<LinkTo @route="dynamicWithChild.child">Link</LinkTo>`);
+ debugger;
+ this.assertComponentElement(this.element.firstChild, {
+ tagName: 'a',
+ content: 'Link',
+ });
+ }
+ }
+);
| false |
Other
|
emberjs
|
ember.js
|
5e6b193367308ffb3ec13bde8c947149edfb5500.json
|
Add v3.26.0-beta.1 to CHANGELOG
(cherry picked from commit 63df7b58dceecf4d79e1a8f94e4fdd590fdf7395)
|
CHANGELOG.md
|
@@ -1,5 +1,23 @@
# Ember Changelog
+### v3.26.0-beta.1 (February 08, 2021)
+
+- [#19255](https://github.com/emberjs/ember.js/pull/19255) [DEPRECATION] Deprecate transition methods of controller and route per [RFC #674](https://github.com/emberjs/rfcs/blob/master/text/0674-deprecate-transition-methods-of-controller-and-route.md).
+- [#19345](https://github.com/emberjs/ember.js/pull/19345) [DEPRECATION] Deprecate `<LinkTo>` positional arguments per [RFC #698](https://github.com/emberjs/rfcs/blob/master/text/0698-deprecate-link-to-positional-arguments.md).
+- [#19346](https://github.com/emberjs/ember.js/pull/19346) [DEPRECATION] Deprecate `{{#with}}` per [RFC #445](https://github.com/emberjs/rfcs/blob/master/text/0445-deprecate-with.md)
+- [#19358](https://github.com/emberjs/ember.js/pull/19358) [DEPRECATION] Deprecate implicit injections per [RFC #680](https://github.com/emberjs/rfcs/blob/master/text/0680-implicit-injection-deprecation.md)
+- [#19359](https://github.com/emberjs/ember.js/pull/19359) [DEPRECATION] Deprecates old browser support policy per [RFC #685 New Browser Support Policy](https://github.com/emberjs/rfcs/blob/master/text/0685-new-browser-support-policy.md).
+- [#19371](https://github.com/emberjs/ember.js/pull/19371) [DEPRECATION] Deprecate implicit `this` property lookup fallback per [RFC #308]https://github.com/emberjs/rfcs/blob/master/text/0308-deprecate-property-lookup-fallback.md
+- [#19372](https://github.com/emberjs/ember.js/pull/19372) [DEPRECATION] Adds deprecations for Classic edition and optional features per [RFC #704](https://github.com/emberjs/rfcs/blob/master/text/0704-deprecate-octane-optional-features.md) and [RFC #705](https://github.com/emberjs/rfcs/blob/master/text/0705-deprecate-jquery-optional-feature.md).
+- [#19373](https://github.com/emberjs/ember.js/pull/19373) [DEPRECATION] Deprecate old manager capabilities per [RFC #686](https://github.com/emberjs/rfcs/blob/master/text/0686-deprecate-old-manager-capabilities-versions.md)
+- [#19374](https://github.com/emberjs/ember.js/pull/19374) [DEPRECATION] Deprecate `hasBlock` and `hasBlockParams` per [RFC #689](https://github.com/emberjs/rfcs/blob/master/text/0689-deprecate-has-block.md).
+- [#19375](https://github.com/emberjs/ember.js/pull/19375) [DEPRECATION] Deprecate old class binding syntax and {{attrs}} per [RFC #691](https://github.com/emberjs/rfcs/blob/master/text/0691-deprecate-class-binding-and-class-name-bindings.md) and [RFC #690](https://github.com/emberjs/rfcs/blob/master/text/0690-deprecate-attrs-in-templates.md).
+- [#19381](https://github.com/emberjs/ember.js/pull/19381) [DEPRECATION] Deprecate Array Observers per [RFC #692](https://github.com/emberjs/rfcs/blob/master/text/0692-deprecate-array-observers.md).
+- [#19379](https://github.com/emberjs/ember.js/pull/19379) [CLEANUP] Refactor DataAdapter to not use observers or array observers
+- [#19378](https://github.com/emberjs/ember.js/pull/19378) [BUGFIX] Fix typo in template-only-glimmer-components feature detection
+- [#19298](https://github.com/emberjs/ember.js/pull/19298) [BUGFIX] Route serialize did not extract param off proxy
+- [#19326](https://github.com/emberjs/ember.js/pull/19326) [BUGFIX] Lazily setup the router in non-application tests for <LinkTo> component
+
### v3.25.0 (February 08, 2021)
- [#19302](https://github.com/emberjs/ember.js/pull/19302) / [#19306](https://github.com/emberjs/ember.js/pull/19306) / [#19319](https://github.com/emberjs/ember.js/pull/19319) [FEATURE] Implement the [Handlebars Strict Mode RFC](https://github.com/emberjs/rfcs/blob/master/text/0496-handlebars-strict-mode.md).
| false |
Other
|
emberjs
|
ember.js
|
d58886db594226e954b8c5e4a94a5e392b72facd.json
|
Add v3.25.0 to CHANGELOG
(cherry picked from commit fca5ef67c756b5fbcaf96c374631b878fcdd34ec)
|
CHANGELOG.md
|
@@ -1,32 +1,19 @@
# Ember Changelog
-### v3.25.0-beta.5 (February 02, 2021)
+### v3.25.0 (February 08, 2021)
+- [#19302](https://github.com/emberjs/ember.js/pull/19302) / [#19306](https://github.com/emberjs/ember.js/pull/19306) / [#19319](https://github.com/emberjs/ember.js/pull/19319) [FEATURE] Implement the [Handlebars Strict Mode RFC](https://github.com/emberjs/rfcs/blob/master/text/0496-handlebars-strict-mode.md).
+- [#19318](https://github.com/emberjs/ember.js/pull/19318) [FEATURE] Implement the [Named Blocks RFC](https://github.com/emberjs/rfcs/blob/master/text/0460-yieldable-named-blocks.md).
+- [#19339](https://github.com/emberjs/ember.js/pull/19339) [DEPRECATION] Deprecate importing `htmlSafe` and `isHTMLSafe` from `@ember/string` per the [Deprecate Ember String RFC](https://github.com/emberjs/rfcs/blob/master/text/0236-deprecation-ember-string.md).
+- [#19320](https://github.com/emberjs/ember.js/pull/19320) / [#19317](https://github.com/emberjs/ember.js/pull/19317) / [#19297](https://github.com/emberjs/ember.js/pull/19297) / [#19293](https://github.com/emberjs/ember.js/pull/19293) / [#19278](https://github.com/emberjs/ember.js/pull/19278) / [#19275](https://github.com/emberjs/ember.js/pull/19275) / [#19363](https://github.com/emberjs/ember.js/pull/19363) Update rendering engine to `@glimmer/*` 0.74.2 for various features and bugfixes including ensuring `{{component.name}}` works with implicit this fallback
+- [#18148](https://github.com/emberjs/ember.js/pull/18148) [BUGFIX] Fix empty `htmlSafe` string to be treated as falsy
+- [#19365](https://github.com/emberjs/ember.js/pull/19365) [BUGFIX] Remove non-existing re-export from helper-addon blueprint
- [#19370](https://github.com/emberjs/ember.js/pull/19370) [BUGFIX] Update glimmer-vm to prevent errors for older inline precompilation
-
-### v3.25.0-beta.4 (February 01, 2021)
-
-- [#19363](https://github.com/emberjs/ember.js/pull/19363) [BUGFIX] Update VM, fix component name preprocessing
-
-### v3.25.0-beta.3 (January 25, 2021)
-
- [#19351](https://github.com/emberjs/ember.js/pull/19351) [BUGFIX] Ensure locals do not clobber components of the same name
-
-### v3.25.0-beta.2 (January 19, 2021)
-
-- [#19339](https://github.com/emberjs/ember.js/pull/19339) [DEPRECATION] Deprecate importing `htmlSafe` and `isHTMLSafe` from `@ember/string` per the [Deprecate Ember String RFC](https://github.com/emberjs/rfcs/blob/master/text/0236-deprecation-ember-string.md).
- [#19336](https://github.com/emberjs/ember.js/pull/19336) [BUGFIX] Ensure Component Lookup Is Well Formed
-- [#19337](https://github.com/emberjs/ember.js/pull/19337) [BUGFIX] Ensure query param only <LinkTo /> are properly scoped in engines.
- [#19338](https://github.com/emberjs/ember.js/pull/19338) [BUGFIX] Add missing `deprecate` options (`for` + `since`)
- [#19342](https://github.com/emberjs/ember.js/pull/19342) [BUGFIX] Fix misleading LinkTo error message
-### v3.25.0-beta.1 (December 28, 2020)
-
-- [#19302](https://github.com/emberjs/ember.js/pull/19302) / [#19306](https://github.com/emberjs/ember.js/pull/19306) / [#19319](https://github.com/emberjs/ember.js/pull/19319) [FEATURE] Implement the [Handlebars Strict Mode RFC](https://github.com/emberjs/rfcs/blob/master/text/0496-handlebars-strict-mode.md).
-- [#19318](https://github.com/emberjs/ember.js/pull/19318) [FEATURE] Implement the [Named Blocks RFC](https://github.com/emberjs/rfcs/blob/master/text/0460-yieldable-named-blocks.md).
-- [#18148](https://github.com/emberjs/ember.js/pull/18148) [BUGFIX] Fix empty `htmlSafe` string to be treated as falsy
-- [#19320](https://github.com/emberjs/ember.js/pull/19320) / [#19317](https://github.com/emberjs/ember.js/pull/19317) / [#19297](https://github.com/emberjs/ember.js/pull/19297) / [#19293](https://github.com/emberjs/ember.js/pull/19293) / [#19278](https://github.com/emberjs/ember.js/pull/19278) / [#19275](https://github.com/emberjs/ember.js/pull/19275) Update rendering engine to `@glimmer/*` 0.73.1 for various features and bugfixes including ensuring `{{component.name}}` works with implicit this fallback
-
### v3.24.1 (January 14, 2021)
- [#19337](https://github.com/emberjs/ember.js/pull/19337) [BUGFIX] Ensure query param only `<LinkTo />` are properly scoped in engines
| false |
Other
|
emberjs
|
ember.js
|
bb607647f107a5046a19e67042bab33ba75f6e62.json
|
add more cases and tests
|
packages/@ember/-internals/metal/index.ts
|
@@ -59,7 +59,7 @@ export {
export { Mixin, aliasMethod, mixin, observer, applyMixin } from './lib/mixin';
export { default as inject, DEBUG_INJECTION_FUNCTIONS } from './lib/injected_property';
export { tagForProperty, tagForObject, markObjectAsDirty } from './lib/tags';
-export { tracked } from './lib/tracked';
+export { tracked, TrackedDescriptor } from './lib/tracked';
export { createCache, getValue, isConst } from './lib/cache';
export {
| true |
Other
|
emberjs
|
ember.js
|
bb607647f107a5046a19e67042bab33ba75f6e62.json
|
add more cases and tests
|
packages/@ember/-internals/metal/lib/tracked.ts
|
@@ -191,16 +191,16 @@ function descriptorForField([target, key, desc]: [
return newDesc;
}
-class TrackedDescriptor {
+export class TrackedDescriptor {
constructor(private _get: () => unknown, private _set: (value: unknown) => void) {
CHAIN_PASS_THROUGH.add(this);
}
- get(obj: object) {
+ get(obj: object): unknown {
return this._get.call(obj);
}
- set(obj: object, _key: string, value: unknown) {
+ set(obj: object, _key: string, value: unknown): void {
this._set.call(obj, value);
}
}
| true |
Other
|
emberjs
|
ember.js
|
bb607647f107a5046a19e67042bab33ba75f6e62.json
|
add more cases and tests
|
packages/@ember/-internals/runtime/lib/system/core_object.js
|
@@ -28,6 +28,7 @@ import {
classToString,
isClassicDecorator,
DEBUG_INJECTION_FUNCTIONS,
+ TrackedDescriptor,
} from '@ember/-internals/metal';
import ActionHandler from '../mixins/action_handler';
import { assert, deprecate } from '@ember/debug';
@@ -129,7 +130,7 @@ function initialize(obj, properties) {
}
if (isDescriptor) {
- if (DEBUG) {
+ if (DEBUG && injectedProperties.indexOf(keyName) !== -1) {
// need to check if implicit injection owner.inject('component:my-component', 'foo', 'service:bar') does not match explicit injection @service foo
// implicit injection takes precedence so need to tell user to rename property on obj
let isInjectedProperty = DEBUG_INJECTION_FUNCTIONS.has(possibleDesc._getter);
@@ -140,6 +141,26 @@ function initialize(obj, properties) {
obj
)}. However, a different service or value was injected via implicit injections which overrode your explicit injection. Implicit injections have been deprecated, and will be removed in the near future. In order to prevent breakage, you should inject the same value explicitly that is currently being injected implicitly.`
);
+ } else if (possibleDesc instanceof TrackedDescriptor) {
+ let descValue = possibleDesc.get(obj, keyName);
+
+ if (value !== descValue) {
+ implicitInjectionDeprecation(
+ keyName,
+ `A value was injected implicitly on the '${keyName}' tracked property of an instance of ${inspect(
+ obj
+ )}, overwriting the original value which was ${inspect(
+ descValue
+ )}. Implicit injection is now deprecated, please add an explicit injection for this value. If the injected value is a service, consider using the @service decorator.`
+ );
+ }
+ } else if (possibleDesc._setter === undefined) {
+ implicitInjectionDeprecation(
+ keyName,
+ `A value was injected implicitly on the '${keyName}' computed property of an instance of ${inspect(
+ obj
+ )}. Implicit injection is now deprecated, please add an explicit injection for this value. If the injected value is a service, consider using the @service decorator.`
+ );
}
}
| true |
Other
|
emberjs
|
ember.js
|
bb607647f107a5046a19e67042bab33ba75f6e62.json
|
add more cases and tests
|
packages/@ember/-internals/runtime/tests/system/object/create_test.js
|
@@ -1,7 +1,7 @@
import { getFactoryFor, Registry } from '@ember/-internals/container';
import { inspect } from '@ember/-internals/utils';
import { getOwner, setOwner } from '@ember/-internals/owner';
-import { computed, Mixin, observer, addObserver, alias } from '@ember/-internals/metal';
+import { computed, Mixin, observer, addObserver, alias, tracked } from '@ember/-internals/metal';
import Service, { inject as service } from '@ember/service';
import { DEBUG } from '@glimmer/env';
import EmberObject from '../../../lib/system/object';
@@ -182,6 +182,118 @@ moduleFor(
}, /A value was injected implicitly on the 'foo' property of an instance of <.*>, overwriting the original value which was <.*>. Implicit injection is now deprecated, please add an explicit injection for this value/);
}
+ ['@test does not raise deprecation if descriptor is a tracked property and equal to the implicit deprecation'](
+ assert
+ ) {
+ expectNoDeprecation();
+
+ let owner = buildOwner();
+
+ class FooService extends Service {
+ bar = 'foo';
+ }
+ class BarService extends Service {
+ bar = 'bar';
+ }
+ class FooObject extends EmberObject {
+ @tracked foo = getOwner(this).lookup('service:foo');
+ }
+ owner.register('service:foo', FooService);
+ owner.register('service:bar', BarService);
+ owner.register('foo:main', FooObject);
+ owner.inject('foo:main', 'foo', 'service:foo');
+
+ let result = owner.lookup('foo:main');
+ assert.equal(result.foo.bar, 'foo');
+ }
+
+ ['@test does raise deprecation if descriptor is a tracked property and not equal to the implicit deprecation'](
+ assert
+ ) {
+ let owner = buildOwner();
+
+ class FooService extends Service {
+ bar = 'foo';
+ }
+ class BarService extends Service {
+ bar = 'bar';
+ }
+ class FooObject extends EmberObject {
+ @tracked foo = getOwner(this).lookup('service:foo');
+ }
+ owner.register('service:foo', FooService);
+ owner.register('service:bar', BarService);
+ owner.register('foo:main', FooObject);
+ owner.inject('foo:main', 'foo', 'service:bar');
+
+ expectDeprecation(() => {
+ let result = owner.lookup('foo:main');
+ assert.equal(result.foo.bar, 'bar');
+ }, /A value was injected implicitly on the 'foo' tracked property of an instance of <.*>, overwriting the original value which was <.*>. Implicit injection is now deprecated, please add an explicit injection for this value/);
+ }
+
+ ['@test does not raise deprecation if descriptor is a computed property with a setter'](
+ assert
+ ) {
+ expectNoDeprecation();
+
+ let owner = buildOwner();
+
+ class FooService extends Service {
+ bar = 'foo';
+ }
+ class BarService extends Service {
+ bar = 'bar';
+ }
+ class FooObject extends EmberObject {
+ @computed
+ get foo() {
+ return getOwner(this).lookup('service:foo');
+ }
+
+ set foo(val) {}
+ }
+ owner.register('service:foo', FooService);
+ owner.register('service:bar', BarService);
+ owner.register('foo:main', FooObject);
+ owner.inject('foo:main', 'foo', 'service:foo');
+
+ let result = owner.lookup('foo:main');
+ assert.equal(result.foo.bar, 'foo');
+ }
+
+ ['@test does raise deprecation if descriptor is a computed property without a setter'](assert) {
+ let owner = buildOwner();
+
+ class FooService extends Service {
+ bar = 'foo';
+ }
+ class BarService extends Service {
+ bar = 'bar';
+ }
+ class FooObject extends EmberObject {
+ @computed
+ get foo() {
+ return getOwner(this).lookup('service:foo');
+ }
+ }
+ owner.register('service:foo', FooService);
+ owner.register('service:bar', BarService);
+ owner.register('foo:main', FooObject);
+ owner.inject('foo:main', 'foo', 'service:bar');
+
+ expectDeprecation(
+ /The <.*>#foo computed property was just overridden. This removes the computed property and replaces it with a plain value, and has been deprecated. If you want this behavior, consider defining a setter which does it manually./
+ );
+
+ expectDeprecation(
+ /A value was injected implicitly on the 'foo' computed property of an instance of <.*>. Implicit injection is now deprecated, please add an explicit injection for this value/
+ );
+
+ let result = owner.lookup('foo:main');
+ assert.equal(result.foo.bar, 'bar');
+ }
+
['@test does not raise deprecation if descriptor is a getter and equal to the implicit deprecation'](
assert
) {
| true |
Other
|
emberjs
|
ember.js
|
b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json
|
Address some feedback
|
packages/@ember/-internals/extension-support/lib/data_adapter.js
|
@@ -234,6 +234,7 @@ export default EmberObject.extend({
@private
@property flushWatchers
@since 3.26.0
+
*/
/**
| true |
Other
|
emberjs
|
ember.js
|
b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json
|
Address some feedback
|
packages/@ember/-internals/extension-support/tests/data_adapter_test.js
|
@@ -15,17 +15,13 @@ const DataAdapter = EmberDataAdapter.extend({
},
init() {
this._super(...arguments);
- Object.defineProperty(this, 'containerDebugAdapter', {
- get() {
- return {
- canCatalogEntriesByType() {
- return true;
- },
- catalogEntriesByType() {
- return emberA(['post']);
- },
- }
- }
+ this.set('containerDebugAdapter', {
+ canCatalogEntriesByType() {
+ return true;
+ },
+ catalogEntriesByType() {
+ return emberA(['post']);
+ },
});
},
});
| true |
Other
|
emberjs
|
ember.js
|
b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json
|
Address some feedback
|
packages/@ember/-internals/routing/lib/ext/controller.ts
|
@@ -17,7 +17,7 @@ ControllerMixin.reopen({
this.namespace = owner.lookup('application:main');
this.target = owner.lookup('router:main');
}
- }
+ },
/**
Defines which query parameters the controller accepts.
| true |
Other
|
emberjs
|
ember.js
|
b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json
|
Address some feedback
|
packages/@ember/-internals/routing/lib/system/route.ts
|
@@ -1,3 +1,4 @@
+import { privatize as P } from '@ember/-internals/container';
import {
addObserver,
computed,
@@ -106,13 +107,12 @@ class Route extends EmberObject implements IRoute {
_names: unknown;
_router: EmberRouter | undefined;
- constructor() {
+ constructor(owner: Owner) {
super(...arguments);
- let owner = getOwner(this);
if (owner) {
this._router = owner.lookup('router:main');
- this._bucketCache = owner.lookup('-bucket-cache:main');
+ this._bucketCache = owner.lookup(P`-bucket-cache:main`);
this._topLevelViewTemplate = owner.lookup('template:-outlet');
this._environment = owner.lookup('-environment:main');
}
| true |
Other
|
emberjs
|
ember.js
|
b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json
|
Address some feedback
|
packages/@ember/-internals/routing/lib/system/router.ts
|
@@ -1,3 +1,4 @@
+import { privatize as P } from '@ember/-internals/container';
import { OutletState as GlimmerOutletState, OutletView } from '@ember/-internals/glimmer';
import { computed, get, notifyPropertyChange, set } from '@ember/-internals/metal';
import { BucketCache } from '@ember/-internals/routing';
@@ -147,14 +148,13 @@ class EmberRouter extends EmberObject {
_slowTransitionTimer: unknown;
- constructor() {
+ constructor(owner: Owner) {
super(...arguments);
this._resetQueuedQueryParameterChanges();
- let owner = getOwner(this);
if (owner) {
this.namespace = owner.lookup('application:main');
- this._bucketCache = owner.lookup('-bucket-cache:main');
+ this._bucketCache = owner.lookup(P`-bucket-cache:main`);
}
}
| true |
Other
|
emberjs
|
ember.js
|
b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json
|
Address some feedback
|
packages/@ember/-internals/runtime/lib/system/core_object.js
|
@@ -90,8 +90,9 @@ function initialize(obj, properties) {
let keyNames = Object.keys(properties);
for (let i = 0; i < keyNames.length; i++) {
- var keyName = keyNames[i];
- var value = properties[keyName];
+ // Hot path so 'var' to avoid closure, which may cause perf issues
+ let keyName = keyNames[i];
+ let value = properties[keyName];
assert(
'EmberObject.create no longer supports defining computed ' +
@@ -161,9 +162,8 @@ function initialize(obj, properties) {
// TODO add setter
Object.defineProperty(obj, keyName, {
configurable: true,
- enumerable: false,
get() {
- // only want to deprecate on first access
+ // only want to deprecate on first access so we make this self destructing
Object.defineProperty(obj, keyName, { value });
implicitInjectionDeprecation(keyName, `Implicit injection for property '${keyName}' is now deprecated. Please add an explicit injection for '${keyName}' to ${inspect(obj)}`);
| true |
Other
|
emberjs
|
ember.js
|
b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json
|
Address some feedback
|
packages/@ember/-internals/utils/lib/inspect.ts
|
@@ -49,7 +49,7 @@ function inspectValue(value: any | null | undefined, depth: number, seen?: WeakS
if (value.toString === objectToString || value.toString === undefined) {
break;
}
- if (value.constructor && value.constructor.name !== 'Class') {
+ if (value.constructor && typeof value.constructor === 'function' && value.constructor.name !== 'Class') {
return value.constructor.name;
}
// custom toString
| true |
Other
|
emberjs
|
ember.js
|
b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json
|
Address some feedback
|
packages/@ember/application/lib/application.js
|
@@ -1172,7 +1172,7 @@ function commonSetupRegistry(registry) {
registry.register('location:history', HistoryLocation);
registry.register('location:none', NoneLocation);
- registry.register(`-bucket-cache:main`, {
+ registry.register(P`-bucket-cache:main`, {
create() {
return new BucketCache();
},
| true |
Other
|
emberjs
|
ember.js
|
b06d98a118b3a49fd4ac200c37c2bc67d3a40296.json
|
Address some feedback
|
packages/@ember/engine/instance.js
|
@@ -182,7 +182,7 @@ const EngineInstance = EmberObject.extend(RegistryProxyMixin, ContainerProxyMixi
let singletons = [
'router:main',
- '-bucket-cache:main',
+ P`-bucket-cache:main`,
'-view-registry:main',
`renderer:-dom`,
'service:-document',
| true |
Other
|
emberjs
|
ember.js
|
bd7833770f03dc3be95ec945013e3d2976d2317f.json
|
ES6 property syntax in Location example
|
packages/@ember/-internals/routing/lib/location/api.ts
|
@@ -58,13 +58,16 @@ export type UpdateCallback = (url: string) => void;
import HistoryLocation from '@ember/routing/history-location';
export default class MyHistory {
- implementation: 'my-custom-history',
+ implementation = 'my-custom-history';
+
constructor() {
this._history = HistoryLocation.create(...arguments);
}
+
create() {
return new this(...arguments);
}
+
pushState(path) {
this._history.pushState(path);
}
| false |
Other
|
emberjs
|
ember.js
|
002e4e86a763c6814e8035b411d41e384d76f61f.json
|
Add v3.25.0-beta.5 to CHANGELOG
(cherry picked from commit fc823791afc3d0e4b4508a751efe127ce46330b5)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.25.0-beta.5 (February 02, 2021)
+
+- [#19370](https://github.com/emberjs/ember.js/pull/19370) [BUGFIX] Update glimmer-vm to prevent errors for older inline precompilation
+
### v3.25.0-beta.4 (February 01, 2021)
- [#19363](https://github.com/emberjs/ember.js/pull/19363) [BUGFIX] Update VM, fix component name preprocessing
| false |
Other
|
emberjs
|
ember.js
|
8959f88b8678fe03660eba203af9b58220a4c053.json
|
Add v3.25.0-beta.4 to CHANGELOG
(cherry picked from commit 2dc1242d4ff7ba70cdcc1c4abebb4325e9bc973f)
|
CHANGELOG.md
|
@@ -1,5 +1,9 @@
# Ember Changelog
+### v3.25.0-beta.4 (February 01, 2021)
+
+- [#19363](https://github.com/emberjs/ember.js/pull/19363) [BUGFIX] Update VM, fix component name preprocessing
+
### v3.25.0-beta.3 (January 25, 2021)
- [#19351](https://github.com/emberjs/ember.js/pull/19351) [BUGFIX] Ensure locals do not clobber components of the same name
| false |
Other
|
emberjs
|
ember.js
|
74e0f60d573a6981ccf5aed2f36372ff46035ad6.json
|
add url for with helper deprecation
|
packages/ember-template-compiler/lib/plugins/deprecate-with.ts
|
@@ -109,6 +109,7 @@ export default function deprecateWith(env: EmberASTPluginEnvironment): ASTPlugin
id: 'ember-glimmer.with-syntax',
until: '4.0.0',
for: 'ember-source',
+ url: 'https://deprecations.emberjs.com/v3.x/#toc_ember-glimmer-with-syntax',
since: {
enabled: '3.26.0-beta.1',
},
| false |
Other
|
emberjs
|
ember.js
|
3ad915e5cf1f622e51d186b8ae910ed3b4fedca0.json
|
update license to 2021
|
generators/license.js
|
@@ -1,6 +1,6 @@
/*!
* @overview Ember - JavaScript Application Framework
- * @copyright Copyright 2011-2020 Tilde Inc. and contributors
+ * @copyright Copyright 2011-2021 Tilde Inc. and contributors
* Portions Copyright 2006-2011 Strobe Inc.
* Portions Copyright 2008-2011 Apple Inc. All rights reserved.
* @license Licensed under MIT license
| false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.