commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
qemu-img: Check getchar() return value in read_password() for WIN32
getchar() is a standard c library function which may return with failure
(e.g. -1), so like another platforms, also need check it under WIN32.
And make the related code match current qemu code styles, too.
Signed-off-by: Chen Gang <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
| fdcf6e65bce1f8972030fed7af5e8aa5f6ae92c6 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/fdcf6e65bce1f8972030fed7af5e8aa5f6ae92c6 | 2014-08-09 00:06:32+04:00 |
pc: hack for migration compatibility from QEMU 2.0
Changing the ACPI table size causes migration to break, and the memory
hotplug work opened our eyes on how horribly we were breaking things in
2.0 already.
The ACPI table size is rounded to the next 4k, which one would think
gives some headroom. In practice this is not the case, because the user
can control the ACPI table size (each CPU adds 97 bytes to the SSDT and
8 to the MADT) and so some "-smp" values will break the 4k boundary and
fail to migrate. Similarly, PCI bridges add ~1870 bytes to the SSDT.
This patch concerns itself with fixing migration from QEMU 2.0. It
computes the payload size of QEMU 2.0 and always uses that one.
The previous patch shrunk the ACPI tables enough that the QEMU 2.0 size
should always be enough; non-AML tables can change depending on the
configuration (especially MADT, SRAT, HPET) but they remain the same
between QEMU 2.0 and 2.1, so we only compute our padding based on the
sizes of the SSDT and DSDT.
Migration from QEMU 1.7 should work for guests that have a number of CPUs
other than 12, 13, 14, 54, 55, 56, 97, 98, 139, 140. It was already
broken from QEMU 1.7 to QEMU 2.0 in the same way, though.
Even with this patch, QEMU 1.7 and 2.0 have two different ideas of
"-M pc-i440fx-2.0" when there are PCI bridges. Igor sent a patch to
adopt the QEMU 1.7 definition. I think distributions should apply
it if they move directly from QEMU 1.7 to 2.1+ without ever packaging
version 2.0.
Reviewed-by: Laszlo Ersek <[email protected]>
Tested-by: Igor Mammedov <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| 07fb61760cdea7c3f1b9c897513986945bca8e89 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/07fb61760cdea7c3f1b9c897513986945bca8e89 | 2014-07-28 23:02:39+02:00 |
spapr: Fix RTAS token numbers
At the moment spapr_rtas_register() allocates a new token number for every
new RTAS callback so numbers are not fixed and depend on the number of
supported RTAS handlers and the exact order of spapr_rtas_register() calls.
These tokens are copied into the device tree and remain the same during
the guest lifetime.
When we start another guest to receive a migration, it calls
spapr_rtas_register() as well. If the number of RTAS handlers or their
order is different in QEMU on source and destination sides, the "/rtas"
node in the device tree will differ. Since migration overwrites the device
tree (as it overwrites the entire RAM), the actual RTAS config on
the destination side gets broken.
This defines global contant values for every RTAS token which QEMU
is using today.
This changes spapr_rtas_register() to accept a token number instead of
allocating one. This changes all users of spapr_rtas_register().
This changes XICS-KVM not to cache tokens registered with KVM as they
constant now.
This makes TOKEN_BASE global as RTAS_XXX use TOKEN_BASE as
a base. TOKEN_MAX is moved and renamed too and its value is changed
to the last token + 1. Boundary checks for token values are adjusted.
This reserves token numbers for "os-term" handlers and PCI hotplug
which we are working on.
Signed-off-by: Alexey Kardashevskiy <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| 3a3b8502e6f0c8d30865c5f36d2c3ae4114000b5 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/3a3b8502e6f0c8d30865c5f36d2c3ae4114000b5 | 2014-06-27 13:48:22+02:00 |
qemu-bridge-helper: Fix fd leak in main()
initialize fd and ctlfd, and close them at the end
Signed-off-by: Gonglei <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| eb3f45c5af26f5284b5f8dd7319714ca70676e50 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/eb3f45c5af26f5284b5f8dd7319714ca70676e50 | 2014-06-27 10:39:10+02:00 |
qemu-char: fix qemu_chr_fe_get_msgfd()
Commit c76bf6bb8fbbb233a7d3641e09229d23747d5ee3 ("Add chardev API
qemu_chr_fe_get_msgfds") broke qemu_chr_fe_get_msgfd() because it
changed the return value.
Callers expect -1 if no fd is available. The commit changed the return
value to 0 (which is a valid file descriptor number) so callers always
detected a file descriptor even if none was available.
This patch fixes qemu-iotests 045:
$ cd tests/qemu-iotests && ./check 045
[...]
+FAIL: test_add_fd_invalid_fd (__main__.TestFdSets)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "./045", line 123, in test_add_fd_invalid_fd
+ self.assert_qmp(result, 'error/class', 'GenericError')
+ File "/home/stefanha/qemu/tests/qemu-iotests/iotests.py", line 232, in assert_qmp
+ result = self.dictpath(d, path)
+ File "/home/stefanha/qemu/tests/qemu-iotests/iotests.py", line 211, in dictpath
+ self.fail('failed path traversal for "%s" in "%s"' % (path, str(d)))
+AssertionError: failed path traversal for "error/class" in "{u'return': {u'fdset-id': 2, u'fd': 0}}"
Cc: Nikolay Nikolaev <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| 4f8586144161d5e680fdef3e09b7e8e9111c2929 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4f8586144161d5e680fdef3e09b7e8e9111c2929 | 2014-06-23 17:38:00+03:00 |
inet_listen_opts: add error checking
Don't use atoi() function which doesn't detect errors, switch to
strtol and error out on failures. Also add a range check while
being at it.
Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
| 8bc891279604186562f59a4239e42dcb451c60d3 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8bc891279604186562f59a4239e42dcb451c60d3 | 2014-06-13 12:34:57+02:00 |
block/sheepdog: Plug memory leak in sd_snapshot_create()
Has always been leaky. Spotted by Coverity.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Benoit Canet <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 2df5fee2dbd56a9c34afd6d7df6744da2d951ccb | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/2df5fee2dbd56a9c34afd6d7df6744da2d951ccb | 2014-05-30 14:26:54+02:00 |
qcow2: Plug memory leak on qcow2_invalidate_cache() error paths
Introduced in commit 5a8a30d. Spotted by Coverity.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Benoit Canet <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| a1904e48c4a9fb114d155419700bfb7d760273b9 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a1904e48c4a9fb114d155419700bfb7d760273b9 | 2014-05-30 14:26:54+02:00 |
usb: fix up post load checks
Correct post load checks:
1. dev->setup_len == sizeof(dev->data_buf)
seems fine, no need to fail migration
2. When state is DATA, passing index > len
will cause memcpy with negative length,
resulting in heap overflow
First of the issues was reported by dgilbert.
Reported-by: "Dr. David Alan Gilbert" <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
| 719ffe1f5f72b1c7ace4afe9ba2815bcb53a829e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/719ffe1f5f72b1c7ace4afe9ba2815bcb53a829e | 2014-05-14 15:24:52+02:00 |
configure: Put tempfiles in a subdir of the build directory
When libtool support was added to configure, the new temporary files
were left out of the list of files cleaned up on exit; this results
in a lot of stale .lo files being left around in /tmp. Worse, libtool
creates a /tmp/.libs directory which we can't easily clean up.
Put all our temporary files in a single temporary directory created
as a subdirectory of the build directory, so we can easily clean it up,
and don't need fragile or complicated code for creation to avoid it
clashing with temporary directories from other instances of QEMU
configure or being subject to attack from adversaries who can write
to /tmp.
Since the temporaries now live in the build tree, we have no
need to jump through hoops with a trap handler to try to remove
them when configure exits; this fixes some weird bugs where hitting
^C during a configure run wouldn't actually make it stop, because
we would run the trap handler but then not stop. (It is possible
to get the trap handler semantics right but it is convoluted largely
because of bugs in dash, so it is simpler to just avoid it.)
Note that "temporary files go in the build directory, not /tmp" is
the way autoconf behaves.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
| 8cd05ab65a92a592e771a0a1847c7e5505d9a024 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8cd05ab65a92a592e771a0a1847c7e5505d9a024 | 2014-05-24 00:34:38+04:00 |
acpi/pcihp.c: Rewrite acpi_pcihp_get_bsel using object_property_get_int
acpi_pcihp_get_bsel implements functionality of object_property_get_int for
specific property named ACPI_PCIHP_PROP_BSEL, but fails to decrement object's
reference counter properly. Rewriting it using generic object_property_get_int
serves two purposes: reducing code duplication and fixing memory leak.
Signed-off-by: Kirill Batuzov <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| 7c38ecd09763107513bacc791856fdbb582a107c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7c38ecd09763107513bacc791856fdbb582a107c | 2014-05-07 12:13:42+03:00 |
iscsi: Don't use error_is_set() to suppress additional errors
Using error_is_set(errp) that way can sweep programming errors under
the carpet when we get called incorrectly with an error set.
Commit 24d3bd6 added a broken error path to iscsi_do_inquiry(): it
first calls error_setg(), then jumps to the preexisting error label,
where error_setg() gets called again, triggering an assertion failure.
Commit cbee81f fixed this by guarding the second error_setg() with an
error_is_set().
Replace this fix by a simpler and safer one: jump right behind the
second error_setg().
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 172fc4dd33e604dcf868c28e73398c19e161708b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/172fc4dd33e604dcf868c28e73398c19e161708b | 2014-04-25 18:05:06+02:00 |
gtk: Fix the relative pointer tracking mode
The relative pointer tracking mode was still buggy even after the
previous fix of the motion-notify-event since the events are filtered
out when the pointer moves outside the drawing window due to the
boundary check for the absolute mode.
This patch fixes the issue by moving the unnecessary boundary check
into the if block of absolute mode, and keep the coordinate in the
relative mode even if it's outside the drawing area. But this makes
the coordinate (last_x, last_y) possibly pointing to (-1,-1),
introduce a new flag to indicate the last coordinate has been
updated.
Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587
Tested-by: Cole Robinson <[email protected]>
Reviewed-by: Cole Robinson <[email protected]>
Tested-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
| e61031cdd81826c433a8bbfa3aca2bae4ffaf845 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e61031cdd81826c433a8bbfa3aca2bae4ffaf845 | 2014-04-07 10:10:10+02:00 |
qcow2: Fix NULL dereference in qcow2_open() error path (CVE-2014-0146)
The qcow2 code assumes that s->snapshots is non-NULL if s->nb_snapshots
!= 0. By having the initialisation of both fields separated in
qcow2_open(), any error occuring in between would cause the error path
to dereference NULL in qcow2_free_snapshots() if the image had any
snapshots.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 11b128f4062dd7f89b14abc8877ff20d41b28be9 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/11b128f4062dd7f89b14abc8877ff20d41b28be9 | 2014-04-01 15:22:35+02:00 |
int128.h: Avoid undefined behaviours involving signed arithmetic
Add casts when we're performing arithmetic on the .hi parts of an
Int128, to avoid undefined behaviour.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
| 423d00c857ebc814ef6b5fc63f1d6c595cdc005d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/423d00c857ebc814ef6b5fc63f1d6c595cdc005d | 2014-04-18 10:33:36+04:00 |
block: Limit request size (CVE-2014-0143)
Limiting the size of a single request to INT_MAX not only fixes a
direct integer overflow in bdrv_check_request() (which would only
trigger bad behaviour with ridiculously huge images, as in close to
2^64 bytes), but can also prevent overflows in all block drivers.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 8f4754ede56e3f9ea3fd7207f4a7c4453e59285b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8f4754ede56e3f9ea3fd7207f4a7c4453e59285b | 2014-04-01 15:22:35+02:00 |
qcow2: Check backing_file_offset (CVE-2014-0144)
Header, header extension and the backing file name must all be stored in
the first cluster. Setting the backing file to a much higher value
allowed header extensions to become much bigger than we want them to be
(unbounded allocation).
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| a1b3955c9415b1e767c130a2f59fee6aa28e575b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a1b3955c9415b1e767c130a2f59fee6aa28e575b | 2014-04-01 14:19:09+02:00 |
bochs: Check extent_size header field (CVE-2014-0142)
This fixes two possible division by zero crashes: In bochs_open() and in
seek_to_sector().
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 8e53abbc20d08ae3ec30c2054e1161314ad9501d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8e53abbc20d08ae3ec30c2054e1161314ad9501d | 2014-04-01 13:59:47+02:00 |
block/cloop: prevent offsets_size integer overflow (CVE-2014-0143)
The following integer overflow in offsets_size can lead to out-of-bounds
memory stores when n_blocks has a huge value:
uint32_t n_blocks, offsets_size;
[...]
ret = bdrv_pread(bs->file, 128 + 4, &s->n_blocks, 4);
[...]
s->n_blocks = be32_to_cpu(s->n_blocks);
/* read offsets */
offsets_size = s->n_blocks * sizeof(uint64_t);
s->offsets = g_malloc(offsets_size);
[...]
for(i=0;i<s->n_blocks;i++) {
s->offsets[i] = be64_to_cpu(s->offsets[i]);
offsets_size can be smaller than n_blocks due to integer overflow.
Therefore s->offsets[] is too small when the for loop byteswaps offsets.
This patch refuses to open files if offsets_size would overflow.
Note that changing the type of offsets_size is not a fix since 32-bit
hosts still only have 32-bit size_t.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 509a41bab5306181044b5fff02eadf96d9c8676a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/509a41bab5306181044b5fff02eadf96d9c8676a | 2014-04-01 13:59:47+02:00 |
tests/libqos/pci-pc: Avoid shifting left into sign bit
Add U suffix when doing "1 << 31" to avoid undefined behaviour.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
| a879125b47c3ae554c01824f996a64a45a86556e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a879125b47c3ae554c01824f996a64a45a86556e | 2014-03-27 19:22:49+04:00 |
qom: Add check() argument to object_property_add_link()
There are currently three types of object_property_add_link() callers:
1. The link property may be set at any time.
2. The link property of a DeviceState instance may only be set before
realize.
3. The link property may never be set, it is read-only.
Something similar can already be achieved with
object_property_add_str()'s set() argument. Follow its example and add
a check() argument to object_property_add_link().
Also provide default check() functions for case #1 and #2. Case #3 is
covered by passing a NULL function pointer.
Cc: Peter Crosthwaite <[email protected]>
Cc: Alexander Graf <[email protected]>
Cc: Anthony Liguori <[email protected]>
Cc: "Michael S. Tsirkin" <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Paolo Bonzini <[email protected]>
[AF: Tweaked documentation comment]
Signed-off-by: Andreas Färber <[email protected]>
| 39f72ef94ba74701d18daf82b44c18a60f94eb60 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/39f72ef94ba74701d18daf82b44c18a60f94eb60 | 2014-03-19 22:23:13+01:00 |
blockdev: Fix NULL pointer dereference in blockdev-add
If aio=native, we check that cache.direct is set as well. If however
cache wasn't specified at all, qemu just segfaulted.
The old condition didn't make any sense anyway because it effectively
only checked for the default cache mode case, but not for an explicitly
set cache.direct=off mode.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Benoit Canet <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
| c6e0bd9b7037937aafeb1d34ec17975a7d685bb7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c6e0bd9b7037937aafeb1d34ec17975a7d685bb7 | 2014-03-06 17:27:28+01:00 |
target-ppc: Fix htab_mask calculation
Correctly update the htab_mask using the return value of
KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1
on GET_SREGS for HV. We check for external htab and if
found true, we don't need to update sdr1
Signed-off-by: Aneesh Kumar K.V <[email protected]>
[ fixed pte group offset computation in ppc_hash64_htab_lookup() that
caused TCG to fail, Greg Kurz <[email protected]> ]
Signed-off-by: Greg Kurz <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| f3c75d42adbba553eaf218a832d4fbea32c8f7b8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f3c75d42adbba553eaf218a832d4fbea32c8f7b8 | 2014-03-05 03:07:02+01:00 |
target-ppc: Store Quadword
This patch adds support for the Store Quadword instruction in user mode. Prior
to Power ISA 2.07, stq was legal only in privileged mode. Support for Little
Endian mode is also new in ISA 2.07.
Signed-off-by: Tom Musta <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| 84cab1e2f5be3ea6eaa65c9fc0422fb992946ce0 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/84cab1e2f5be3ea6eaa65c9fc0422fb992946ce0 | 2014-03-05 03:06:50+01:00 |
qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and CreateEvent
OpenEvent and CreateEvent WinAPI return NULL when failed to open/create
events handles, instead of INVALID_HANDLE_VALUE (although their return
types are HANDLE).
This replaces INVALID_HANDLE_VALUE related to event handles with NULL.
Signed-off-by: Tomoki Sekiyama <[email protected]>
Reviewed-by: Gal Hammer <[email protected]>
Reviewed-by: Yan Vugenfirer <[email protected]>
Signed-off-by: Michael Roth <[email protected]>
| 4c1b8f1e8357d85c613d779596e4079cc581d74f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4c1b8f1e8357d85c613d779596e4079cc581d74f | 2014-02-23 13:10:20-06:00 |
quorum: Create quorum.c, add QuorumChildRequest and QuorumAIOCB.
Quorum is a block filter mirroring writes to num_children children.
For reads quorum reads each children and does a vote.
If more than vote_threshold versions are identical the quorum is reached and
this winning version is returned to the guest. So quorum prevents bit corruption.
For high availability purpose minority errors are reported via QMP but the guest
does not see them.
This patch creates the driver C source file and introduces the structures that
will be used in asynchronous reads and writes.
Signed-off-by: Benoit Canet <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 27cec15e4ed4e69155f2499ceb46d22d8425102a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/27cec15e4ed4e69155f2499ceb46d22d8425102a | 2014-02-21 22:29:48+01:00 |
KVM: Use return value for error print
Commit 94ccff13 introduced a more verbose failure message and retry
operations on KVM VM creation. However, it ended up using a variable
for its failure message that hasn't been initialized yet.
Fix it to use the value it meant to set.
Cc: [email protected]
Signed-off-by: Alexander Graf <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
| 521f438e36b0265d66862e9cd35e4db82686ca9f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/521f438e36b0265d66862e9cd35e4db82686ca9f | 2014-02-21 11:19:34+01:00 |
hmp: migrate command (without -d) now blocks correctly
This patch fixes a timing issue that migrate command (without -d) does not
block in some cases.
The original version of hmp.c:hmp_migrate_status_cb checks if the
migration status is 'active' or not to detect the completion of a migration.
However, if this function is executed when the migration status is stil
'setup' (the status before 'active'), migration command returns
immediately even if the user does not specify -d option.
Signed-off-by: Soramichi Akiyama <[email protected]>
Signed-off-by: Luiz Capitulino <[email protected]>
| dde3a2184074f5c4279fd7fbfc597b5dc5859fb8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/dde3a2184074f5c4279fd7fbfc597b5dc5859fb8 | 2014-02-17 11:57:22-05:00 |
iscsi: correctly propagate errors in iscsi_open
Before:
$ ./qemu-io-old
qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo
Failed to parse URL : foo
qemu-io-old: can't open device (null): Could not open 'foo': Invalid argument
After:
$ ./qemu-io
qemu-io> open -r -o file.driver=iscsi,file.filename=foo
qemu-io: can't open device (null): Failed to parse URL : foo
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| f2917853f715b0ef55df29eb2ffea29dc69ce814 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f2917853f715b0ef55df29eb2ffea29dc69ce814 | 2014-02-21 21:02:23+01:00 |
block: Assert serialisation assumptions in pwritev
If a request calls wait_serialising_requests() and actually has to wait
in this function (i.e. a coroutine yield), other requests can run and
previously read data (like the head or tail buffer) could become
outdated. In this case, we would have to restart from the beginning to
read in the updated data.
However, we're lucky and don't actually need to do that: A request can
only wait in the first call of wait_serialising_requests() because we
mark it as serialising before that call, so any later requests would
wait. So as we don't wait in practice, we don't have to reload the data.
This is an important assumption that may not be broken or data
corruption will happen. Document it with some assertions.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
| 28de2dcd88de31f50bbd43d9c2fcb046c3a727cb | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/28de2dcd88de31f50bbd43d9c2fcb046c3a727cb | 2014-01-24 17:40:03+01:00 |
migration: qmp_migrate(): keep working after syntax error
If a user or QMP client enter a bad syntax for the migrate
command in QMP/HMP, then the migrate command will never succeed
from that point on.
For example, if you enter:
(qemu) migrate tcp;0:4444
migrate: Parameter 'uri' expects a valid migration protocol
Then the migrate command will always fail from now on:
(qemu) migrate tcp:0:4444
migrate: There's a migration process in progress
The problem is that qmp_migrate() sets the migration status to
MIG_STATE_SETUP and doesn't reset it on syntax error. This bug
was introduced by commit 29ae8a4133082e16970c9d4be09f4b6a15034617.
Reviewed-by: Michael R. Hines <[email protected]>
Signed-off-by: Luiz Capitulino <[email protected]>
| c950114286ea358a93ce632db0421945e1008395 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c950114286ea358a93ce632db0421945e1008395 | 2014-01-06 15:02:30-05:00 |
blkdebug: Use QLIST_FOREACH_SAFE to resume IO
Qemu-iotest 030 was broken.
When the coroutine runs and finishes, it will remove itself from the req
list, so let's use safe version of foreach to avoid use after free.
Signed-off-by: Fam Zheng <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| c547e5640d5b0993cdfb252331065c1a1d813bd8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c547e5640d5b0993cdfb252331065c1a1d813bd8 | 2013-12-13 17:11:19+01:00 |
qdev-properties-system.c: Allow vlan or netdev for -device, not both
It is currently possible to specify things like:
-device e1000,netdev=foo,vlan=1
With this usage, whichever argument was specified last (vlan or netdev)
overwrites what was previousely set and results in a non-working
configuration. Even worse, when used with multiqueue devices,
it causes a segmentation fault on exit in qemu_free_net_client.
That patch treates the above command line options as invalid and
generates an error at start-up.
Signed-off-by: Vlad Yasevich <[email protected]>
Acked-by: Jason Wang <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 30c367ed446b6ea53245589a5cf373578ac075d7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/30c367ed446b6ea53245589a5cf373578ac075d7 | 2013-11-22 09:47:00+01:00 |
target-openrisc: Correct wrong epcr register in interrupt handler
This patch corrects several misbehaviors during an interrupt process.
Most of the time the pc is already correct and therefore no special treatment
of the exceptions is necessary.
Tested by checking crashing programs which otherwise work in or1ksim.
Signed-off-by: Sebastian Macke <[email protected]>
Reviewed-by: Jia Liu <[email protected]>
Signed-off-by: Jia Liu <[email protected]>
| ae52bd96ceaea36c486d8ffeb798e160f31d3be8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ae52bd96ceaea36c486d8ffeb798e160f31d3be8 | 2013-11-20 21:45:42+08:00 |
virtio-net: fix the memory leak in rxfilter_notify()
object_get_canonical_path() returns a gchar*, it should be freed by the
caller.
Signed-off-by: Amos Kong <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Vlad Yasevich <[email protected]>
Reviewed-by: Andreas Färber <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 96e35046e4a97df5b4e1e24e217eb1e1701c7c71 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/96e35046e4a97df5b4e1e24e217eb1e1701c7c71 | 2013-11-19 10:26:55+01:00 |
target-i386: do not override nr_cores for -cpu host
Commit 787aaf5 (target-i386: forward CPUID cache leaves when -cpu host is
used, 2013-09-02) brings bits 31..26 of CPUID leaf 04h out of sync with
the APIC IDs that QEMU reserves for each package. This number must come
from "-smp" options rather than from the host CPUID.
It also turns out that this unsyncing makes Windows Server 2012R2 fail
to boot.
Tested-by: Peter Lieven <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Benoit Canet <[email protected]>
Reviewed-by: Eduardo Habkost <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
| 76c2975a6feb5c232698e982b7f798431457822f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/76c2975a6feb5c232698e982b7f798431457822f | 2013-11-21 07:56:16-08:00 |
block/drive-mirror: Check for NULL backing_hd
It should be possible to execute the QMP "drive-mirror" command in
"none" sync mode and "absolute-paths" mode even for block devices
lacking a backing file.
"absolute-paths" does in fact not require a backing file to be present,
as can be seen from the "top" sync mode code path. "top" basically
states that the device should indeed have a backing file - however, the
current code catches the case if it doesn't and then simply treats it as
"full" sync mode, creating a target image without a backing file (in
"absolute-paths" mode). Thus, "absolute-paths" does not imply the target
file must indeed have a backing file.
Therefore, the target file may be left unbacked in case of "none" sync
mode as well, if the specified device is not backed either. Currently,
qemu will crash trying to dereference the backing file pointer since it
assumes that it will always be non-NULL in that case ("none" with
"absolute-paths").
Signed-off-by: Max Reitz <[email protected]>
Reviewed-by: Wenchao Xia <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 1452686495922b81d6cf43edf025c1aef15965c0 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/1452686495922b81d6cf43edf025c1aef15965c0 | 2013-11-14 13:09:06+01:00 |
target-ppc: dump-guest-memory support
This patch add support for dumping guest memory using dump-guest-memory
monitor command.
Before patch:
(qemu) dump-guest-memory testcrash
this feature or command is not currently supported
(qemu)
After patch:
(qemu) dump-guest-memory testcrash
(qemu)
crash was able to read the file
crash> bt
PID: 0 TASK: c000000000c0d0d0 CPU: 0 COMMAND: "swapper/0"
R0: 0000000028000084 R1: c000000000cafa50 R2: c000000000cb05b0
R3: 0000000000000000 R4: c000000000bc4cb0 R5: 0000000000000000
R6: 001efe93b8000000 R7: 0000000000000000 R8: 0000000000000000
R9: b000000000001032 R10: 0000000000000001 R11: 0001eb2117e00d55
....
...
NOTE: Currently crash tools doesn't look at ELF notes in the dump on ppc64.
Signed-off-by: Aneesh Kumar K.V <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| e62fbc54d459d4cc8e91dc0938383a7f4c13768c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e62fbc54d459d4cc8e91dc0938383a7f4c13768c | 2013-10-25 23:25:48+02:00 |
timer: protect timers_state's clock with seqlock
QEMU_CLOCK_VIRTUAL may be read outside BQL. This will make its
foundation, i.e. cpu_clock_offset exposed to race condition.
Using private lock to protect it.
After this patch, reading QEMU_CLOCK_VIRTUAL is thread safe
unless use_icount is true, in which case the existing callers
still rely on the BQL.
Lock rule: private lock innermost, ie BQL->"this lock"
Signed-off-by: Liu Ping Fan <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
| cb365646a942ed58aae053064b2048a415337ba2 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/cb365646a942ed58aae053064b2048a415337ba2 | 2013-10-17 17:30:52+02:00 |
sheepdog: check simultaneous create in resend_aioreq
After reconnection happens, all the inflight requests are moved to the
failed request list. As a result, sd_co_rw_vector() can send another
create request before resend_aioreq() resends a create request from
the failed list.
This patch adds a helper function check_simultaneous_create() and
checks simultaneous create requests more strictly in resend_aioreq().
Signed-off-by: MORITA Kazutaka <[email protected]>
Tested-by: Liu Yuan <[email protected]>
Reviewed-by: Liu Yuan <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 80308d33ec70834a80351a79eba106049b44a366 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/80308d33ec70834a80351a79eba106049b44a366 | 2013-10-30 12:22:24+01:00 |
vmdk: fix cluster size check for flat extents
We use the extent size as cluster size for flat extents (where no L1/L2
table is allocated so it's safe) reuse sector calculating code with
sparse extents.
Don't pass in the cluster size for adding flat extent, just set it to
sectors later, then the cluster size checking will not fail.
The cluster_sectors is changed to int64_t to allow big flat extent.
Without this, flat extent opening is broken:
# qemu-img create -f vmdk -o subformat=monolithicFlat /tmp/a.vmdk 100G
Formatting '/tmp/a.vmdk', fmt=vmdk size=107374182400 compat6=off subformat='monolithicFlat' zeroed_grain=off
# qemu-img info /tmp/a.vmdk
image: /tmp/a.vmdk
file format: raw
virtual size: 0 (0 bytes)
disk size: 4.0K
Signed-off-by: Fam Zheng <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 301c7d38a0c359b91526391d13617386f3d9bb29 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/301c7d38a0c359b91526391d13617386f3d9bb29 | 2013-09-25 16:21:28+02:00 |
qcow2: Correct snapshots size for overlap check
Using s->snapshots_size instead of snapshots_size for the metadata
overlap check in qcow2_write_snapshots leads to the detection of an
overlap with the main qcow2 image header when deleting the last
snapshot, since s->snapshots_size has not yet been updated and is
therefore non-zero. However, the offset returned by qcow2_alloc_clusters
will be zero since snapshots_size is zero. Therefore, an overlap is
detected albeit no such will occur.
This patch fixes this by replacing s->snapshots_size by snapshots_size
when calling qcow2_pre_write_overlap_check.
Signed-off-by: Max Reitz <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 0f39ac9a07cc10278e37d87076b143008f28aa3b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/0f39ac9a07cc10278e37d87076b143008f28aa3b | 2013-09-20 12:48:03+02:00 |
kvmvapic: Catch invalid ROM size
If not caught early, a zero-length ROM will cause a NULL-pointer access
later on in patch_hypercalls when allocating a zero-length ROM copy and
trying to read from it.
CC: [email protected]
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
| 18e5eec4db96a00907eb588a2b803401637c7f67 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/18e5eec4db96a00907eb588a2b803401637c7f67 | 2013-09-20 12:37:52+02:00 |
chardev: fix pty_chr_timer
pty_chr_timer first calls pty_chr_update_read_handler(), then clears
timer_tag (because it is a one-shot timer). This is the wrong order
though. pty_chr_update_read_handler might re-arm time timer, and the
new timer_tag gets overwitten in that case.
This leads to crashes when unplugging a pty chardev: pty_chr_close
thinks no timer is running -> timer isn't canceled -> pty_chr_timer gets
called with stale CharDevState -> BOOM.
This patch fixes the ordering.
Kill the pointless goto while being at it.
https://bugzilla.redhat.com/show_bug.cgi?id=994414
Cc: [email protected]
Signed-off-by: Gerd Hoffmann <[email protected]>
| b0d768c35e08d2057b63e8e77e7a513c447199fa | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b0d768c35e08d2057b63e8e77e7a513c447199fa | 2013-09-12 09:58:18+02:00 |
block: Assert validity of BdrvActionOps
In qmp_transaction, assert that the BdrvActionOps to be used is actually
valid.
This assertion failing is very improbable, however, it might happen, if
a new TransactionActionKind is introduced "out of order" and the
actions[] array is not updated.
Signed-off-by: Max Reitz <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| aa3fe714f70654da47d9c2659b2d9ee295a9d930 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/aa3fe714f70654da47d9c2659b2d9ee295a9d930 | 2013-09-12 16:28:36+02:00 |
dataplane: Fix startup race.
Avoid trying to setup dataplane again if dataplane setup is already in
progress. This may happen if an eventfd is triggered during setup.
I saw this occasionally with an experimental s390 irqfd implementation:
virtio_blk_handle_output
-> virtio_blk_data_plane_start
-> virtio_ccw_set_host_notifier
...
-> virtio_queue_set_host_notifier_fd_handler
-> virtio_queue_host_notifier_read
-> virtio_queue_notify_vq
-> virtio_blk_handle_output
-> virtio_blk_data_plane_start
-> vring_setup
-> hostmem_init
-> memory_listener_register
-> BOOM
As virtio-ccw tries to follow what virtio-pci does, it might be triggerable
for other platforms as well.
Signed-off-by: Cornelia Huck <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 8caf907f07688972e5e7cd11526079b1665d6dba | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8caf907f07688972e5e7cd11526079b1665d6dba | 2013-09-06 15:25:09+02:00 |
qcow2: Save refcount order in BDRVQcowState
Save the image refcount order in BDRVQcowState. This will be relevant
for future code supporting different refcount orders than four and also
for code that needs to verify a certain refcount order for an opened
image.
Signed-off-by: Max Reitz <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| b6481f376bc65894910dd98db3f299d698817106 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b6481f376bc65894910dd98db3f299d698817106 | 2013-09-12 10:12:46+02:00 |
pc: disable pci-info for 1.6
The BIOS that we ship in 1.6 does not use pci info
from host (yet). Several issues turned up
(e.g. around winXP boot crashes). So it's safest to disable that
interface for 1.6 machine types for now, leave it on for 1.7
as we have enough time to fix issues if any.
Reviewed-by: Richard Henderson <[email protected]>
Reviewed-by: Andreas Färber <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| 9604f70fdf8e21ec0dbf6eac5e59a0eb8beadd64 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/9604f70fdf8e21ec0dbf6eac5e59a0eb8beadd64 | 2013-08-12 12:05:33+03:00 |
rdma: memory leak RDMAContext::host
It is allocated by g_strdup(), so needs to be freed.
Reviewed-by: Michael R. Hines <[email protected]>
Signed-off-by: Isaku Yamahata <[email protected]>
Signed-off-by: Michael R. Hines <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
| e1d0fb378ae3bb4272124a12e3fe1a02c4745eb1 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e1d0fb378ae3bb4272124a12e3fe1a02c4745eb1 | 2013-08-05 11:47:47-05:00 |
virtio-9p-device: Avoid freeing uninitialized memory
In virtio_9p_device_init() there are 6x goto out that will lead to
v9fs_path_free() attempting to free unitialized path.data field.
Easiest way to trigger is: qemu-system-x86_64 -device virtio-9p-pci
Fix this by moving v9fs_path_init() before any goto out.
Signed-off-by: Andreas Färber <[email protected]>
Signed-off-by: Andreas Färber <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
| 27915efb974999dd256a6c432a17432d9d84e606 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/27915efb974999dd256a6c432a17432d9d84e606 | 2013-08-01 11:18:24-05:00 |
pc: limit 64 bit hole to 2G by default
It turns out that some 32 bit windows guests crash
if 64 bit PCI hole size is >2G.
Limit it to 2G for piix and q35 by default.
User may override default 64-bit PCI hole size by
using "pci-hole64-size" property.
Examples:
-global i440FX-pcihost.pci-hole64-size=4G
-global q35-pcihost.pci-hole64-size=4G
Reported-by: Igor Mammedov <[email protected]>,
Signed-off-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Igor Mammedov <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Andreas Färber <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
| 398489018183d613306ab022653552247d93919f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/398489018183d613306ab022653552247d93919f | 2013-07-29 19:33:34-05:00 |
tpm.c: Don't try to put -1 in a variable of type TpmModel
The TpmModel type is an enum (valid values 0 and 1), which means
the compiler can legitimately decide that comparisons like
'tpm_models[i] == -1' are never true. (For example it could
pick 'unsigned char' as its type for representing the enum.)
Avoid this issue by using TPM_MODEL_MAX to mark entries in
the tpm_models[] array which aren't filled in, instead of -1.
This silences a clang warning:
tpm.c:43:27: error: comparison of constant -1 with expression of type
'enum TpmModel' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (tpm_models[i] == -1) {
~~~~~~~~~~~~~ ^ ~~
Signed-off-by: Peter Maydell <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
| 8cdd2e0abbf593a38a146d8dfc998754cefbc27a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8cdd2e0abbf593a38a146d8dfc998754cefbc27a | 2013-07-29 10:37:10-05:00 |
Fix -machine options accel, kernel_irqchip, kvm_shadow_mem
Multiple -machine options with the same ID are merged. All but the
one without an ID are to be silently ignored.
In most places, we query these options with a null ID. This is
correct.
In some places, we instead query whatever options come first in the
list. This is wrong. When the -machine processed first happens to
have an ID, options are taken from that ID, and the ones specified
without ID are silently ignored.
Example:
$ upstream-qemu -nodefaults -S -display none -monitor stdio -machine id=foo -machine accel=kvm,usb=on
$ upstream-qemu -nodefaults -S -display none -monitor stdio -machine id=foo,accel=kvm,usb=on -machine accel=xen
$ upstream-qemu -nodefaults -S -display none -monitor stdio -machine accel=xen -machine id=foo,accel=kvm,usb=on
$ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio -machine accel=kvm,usb=on
QEMU 1.5.50 monitor - type 'help' for more information
(qemu) info kvm
kvm support: enabled
(qemu) info usb
(qemu) q
$ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio -machine id=foo -machine accel=kvm,usb=on
QEMU 1.5.50 monitor - type 'help' for more information
(qemu) info kvm
kvm support: disabled
(qemu) info usb
(qemu) q
$ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio -machine id=foo,accel=kvm,usb=on -machine accel=xen
QEMU 1.5.50 monitor - type 'help' for more information
(qemu) info kvm
kvm support: enabled
(qemu) info usb
USB support not enabled
(qemu) q
$ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio -machine accel=xen -machine id=foo,accel=kvm,usb=on
xc: error: Could not obtain handle on privileged command interface (2 = No such file or directory): Internal error
xen be core: can't open xen interface
failed to initialize Xen: Operation not permitted
Option usb is queried correctly, and the one without an ID wins,
regardless of option order.
Option accel is queried incorrectly, and which one wins depends on
option order and ID.
Affected options are accel (and its sugared forms -enable-kvm and
-no-kvm), kernel_irqchip, kvm_shadow_mem.
Additionally, option kernel_irqchip is normally on by default, except
it's off when no -machine options are given. Bug can't bite, because
kernel_irqchip is used only when KVM is enabled, KVM is off by
default, and enabling always creates -machine options. Downstreams
that enable KVM by default do get bitten, though.
Use qemu_get_machine_opts() to fix these bugs.
Signed-off-by: Markus Armbruster <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
| 36ad0e948e15d8d86c8dec1c17a8588d87b0107d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/36ad0e948e15d8d86c8dec1c17a8588d87b0107d | 2013-07-09 13:38:58-05:00 |
pvpanic: fix fwcfg for big endian hosts
Convert port number to little endian when
exposing it in fw cfg.
Signed-off-by: Michael S. Tsirkin <[email protected]>
| fea7d5966a54a5e5400cd38897a95ea576b5af4d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/fea7d5966a54a5e5400cd38897a95ea576b5af4d | 2013-07-04 10:42:51+03:00 |
pvpanic: initialization cleanup
Avoid use of static variables: PC systems
initialize pvpanic device through pvpanic_init,
so we can simply create the fw_cfg file at that point.
This also makes it possible to skip device
creation completely if fw_cfg is not there, e.g. for xen -
so the ports it reserves are not discoverable by guests.
Also, make pvpanic_init void since callers ignore return
status anyway.
Cc: Stefano Stabellini <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Cc: Paul Durrant <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| bc3e6a0d6c8ab6cd7cd4b576ed567756f1dcabd2 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/bc3e6a0d6c8ab6cd7cd4b576ed567756f1dcabd2 | 2013-07-04 10:42:51+03:00 |
scsi-generic: check the return value of bdrv_aio_ioctl in execute_command
This fixes the bug introduced by this commit ad54ae80c73f.
The bdrv_aio_ioctl() still could return null and we should return an error
in that case.
Cc: [email protected]
Signed-off-by: Pavel Hrdina <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
| d836f8d35dc418e24c3b11e2ea67d361b867b650 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/d836f8d35dc418e24c3b11e2ea67d361b867b650 | 2013-06-18 12:43:03+02:00 |
gdbstub: let the debugger resume from guest panicked state
While in general we forbid a "continue" from the guest panicked
state, it makes sense to have an exception for that when continuing
in the debugger. Perhaps the guest entered that state due to a bug,
for example, and we want to continue no matter what.
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Luiz Capitulino <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
| bc7d0e66741724216cc104034838eb34f0e94b8d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/bc7d0e66741724216cc104034838eb34f0e94b8d | 2013-06-10 11:36:11-05:00 |
gdbstub: do not restart crashed guest
If a guest has crashed with an internal error or similar, detaching
gdb (or any other debugger action) should not restart it.
Cc: Jan Kiszka <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
| 87f25c12bfeaaa0c41fb857713bbc7e8a9b757dc | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/87f25c12bfeaaa0c41fb857713bbc7e8a9b757dc | 2013-05-30 11:45:03-05:00 |
memory: limit sections in the radix tree to the actual address space size
The radix tree is statically sized to fit TARGET_PHYS_ADDR_SPACE_BITS.
If a larger memory region is registered, it will overflow.
Fix by limiting any section in the radix tree to the supported size.
This problem was not observed earlier since artificial regions (containers
and aliases) are eliminated by the memory core, leaving only device regions
which have reasonable sizes. An IOMMU however cannot be eliminated by the
memory core, and may have an artificial size.
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Avi Kivity <[email protected]>
[ Fail the build if TARGET_PHYS_ADDR_SPACE_BITS is too large - Paolo ]
Signed-off-by: Paolo Bonzini <[email protected]>
| 86a8623692b1b559a419a92eb8b6897c221bca74 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/86a8623692b1b559a419a92eb8b6897c221bca74 | 2013-05-24 18:43:35+02:00 |
target-mips: fix calculation of overflow for SHLL.PH and SHLL.QB
This change corrects and simplifies how discard is calculated for shift
left logical vector instructions. It is used to detect overflow and set bit
22 in the DSPControl register.
The existing tests (shll_ph.c, shll_qb.c) are extended with the corner cases
that expose incorrectness in the previous implementation.
Signed-off-by: Petar Jovanovic <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
| 29851ee7c8bd3fb8542e21cd0270c73132590350 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/29851ee7c8bd3fb8542e21cd0270c73132590350 | 2013-05-03 11:50:49+02:00 |
target-ppc: fix nego and subf*o instructions
The overflow computation of nego and subf*o instructions has been broken
in commit ffe30937. Contrary to other targets, the instruction is subtract
from an not subtract on PowerPC.
This patch fixes the issue by using the correct argument in the xor
computation. Thanks to Peter Maydell for the hint.
With this change the PPC emulation passes the Gwenole Beauchesne
testsuite again.
Signed-off-by: Aurelien Jarno <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| 8e7a6db96566fe4162edaeb3e8b62fc8004d1598 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8e7a6db96566fe4162edaeb3e8b62fc8004d1598 | 2013-04-26 23:02:40+02:00 |
vhost-scsi: new device supporting the tcm_vhost Linux kernel module
The WWPN specified in configfs is passed to "-device vhost-scsi-pci".
The tgpt field of the SET_ENDPOINT ioctl is obsolete now, so it is not
available from the QEMU command-line. Instead, I hardcode it to zero.
Changes in Patch-v2:
- Add vhost_scsi_get_features() in order to determine feature bits
supports by host kernel (mst + nab)
- Re-enable usage of DEFINE_VIRTIO_COMMON_FEATURES, and allow
EVENT_IDX to be disabled by host in vhost_scsi_get_features()
- Drop unused hotplug bit in DEFINE_VHOST_SCSI_PROPERTIES
Changes in Patch-v1:
- Set event_idx=off by default (nab, thanks asias)
- Disable hotplug feature bit for v3.9 tcm_vhost kernel code, need to
re-enable in v3.10 (nab)
- Update to latest qemu.git/master HEAD
Changes in WIP-V3:
- Drop ioeventfd vhost_scsi_properties (asias, thanks stefanha)
- Add CONFIG_VHOST_SCSI (asias, thanks stefanha)
- Add hotplug feature bit
Changes in WIP-V2:
- Add backend guest masking support (nab)
- Bump ABI_VERSION to 1 (nab)
- Set up set_guest_notifiers (asias)
- Set up vs->dev.vq_index (asias)
- Drop vs->vs.vdev.{set,clear}_vhost_endpoint (asias)
- Drop VIRTIO_CONFIG_S_DRIVER check in vhost_scsi_set_status (asias)
Howto:
Use the latest seabios, at least commit b44a7be17b
git clone git://git.seabios.org/seabios.git
make
cp out/bios.bin /usr/share/qemu/bios.bin
qemu -device vhost-scsi-pci,wwpn=naa.6001405bd4e8476d,event_idx=off
...
Cc: Michael S. Tsirkin <[email protected]>
Signed-off-by: Nicholas Bellinger <[email protected]>
Signed-off-by: Asias He <[email protected]>
[ Rebase on top of VirtIOSCSICommon patch, fix bugs in feature
negotiation and irqfd masking - Paolo ]
Signed-off-by: Paolo Bonzini <[email protected]>
| 5e9be92d775208cf6cc9bf9a592853888046239e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5e9be92d775208cf6cc9bf9a592853888046239e | 2013-04-19 16:18:11+02:00 |
virtio-blk: fix unplug + virsh reboot
virtio-blk registers a vmstate change handler. Unfortunately this
handler is not unregistered on unplug, leading to some random
crashes if the system is restarted, e.g. via virsh reboot.
Lets unregister the vmstate change handler if the device is removed.
Signed-off-by: Christian Borntraeger <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 69b302b2044a9a0f6d157d25b39a91ff7124c61f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/69b302b2044a9a0f6d157d25b39a91ff7124c61f | 2013-03-04 09:54:16+01:00 |
update seabios to 1.7.2.1
Alex Williamson (3):
seabios q35: Enable all PIRQn IRQs at startup
seabios q35: Add new PCI slot to irq routing function
seabios: Add a dummy PCI slot to irq mapping function
Avik Sil (1):
USB-EHCI: Fix null pointer assignment
Kevin O'Connor (4):
Update tools/acpi_extract.py to handle iasl 20130117 release.
Fix Makefile - don't reference "out/" directly, instead use "$(OUT)".
build: Don't require $(OUT) to be a sub-directory of the main
directory.
Verify CC is valid during build tests.
Signed-off-by: Gerd Hoffmann <[email protected]>
| 5c75fb10029c5fd1e705a6ef5d698fbea06c7a33 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5c75fb10029c5fd1e705a6ef5d698fbea06c7a33 | 2013-02-28 09:19:00+01:00 |
s390x: silence warning from GCC on uninitialized values
As best I can tell, this is a false positive.
[aliguori@ccnode4 qemu-s390]$ make
CC s390x-softmmu/target-s390x/helper.o
/home/aliguori/git/qemu/target-s390x/helper.c: In function ‘do_interrupt’:
/home/aliguori/git/qemu/target-s390x/helper.c:673:17: error: ‘addr’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/home/aliguori/git/qemu/target-s390x/helper.c:620:20: note: ‘addr’ was declared here
/home/aliguori/git/qemu/target-s390x/helper.c:673:17: error: ‘mask’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/home/aliguori/git/qemu/target-s390x/helper.c:620:14: note: ‘mask’ was declared here
cc1: all warnings being treated as errors
make[1]: *** [target-s390x/helper.o] Error 1
make: *** [subdir-s390x-softmmu] Error 2
Cc: Cornelia Huck <[email protected]>
Cc: Stefan Weil <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 0123c486367ab77c3c5ed349616a862eb474a03f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/0123c486367ab77c3c5ed349616a862eb474a03f | 2013-02-04 15:24:15-06:00 |
vnc: fix possible uninitialized removals
Some VncState values are not initialized before the Websocket handshake.
If it fails QEMU segfaults during the cleanup. To prevent this behavior
intialization checks are added.
Signed-off-by: Tim Hardeck <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 6fd8e79af031d8cfc0eb02d40d03281917fcb27b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/6fd8e79af031d8cfc0eb02d40d03281917fcb27b | 2013-01-21 13:33:12-06:00 |
rtc-test: skip year-2038 overflow check in case time_t is 32bit only
Signed-off-by: Gerd Hoffmann <[email protected]>
| 4e45deedf57c6cc7113b588282d0c16f89298aff | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4e45deedf57c6cc7113b588282d0c16f89298aff | 2013-01-10 15:23:39+01:00 |
vfio-pci: Loosen sanity checks to allow future features
VFIO_PCI_NUM_REGIONS and VFIO_PCI_NUM_IRQS should never have been
used in this manner as it locks a specific kernel implementation.
Future features may introduce new regions or interrupt entries
(VGA may add legacy ranges, AER might add an IRQ for error
signalling). Fix this before it gets us into trouble.
Signed-off-by: Alex Williamson <[email protected]>
Cc: [email protected]
| 8fc94e5a8046e349e07976f9bcaffbcd5833f3a2 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8fc94e5a8046e349e07976f9bcaffbcd5833f3a2 | 2013-01-08 14:10:03-07:00 |
vhost: set started flag while start is in progress
This makes it possible to use started flag for sanity checking
of callbacks that happen during start/stop.
Signed-off-by: Michael S. Tsirkin <[email protected]>
| 24f4fe345c1b80bab1ee18573914123d8028a9e6 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/24f4fe345c1b80bab1ee18573914123d8028a9e6 | 2013-01-07 19:42:23+02:00 |
sclp: Fix uninitialized var in handle_write_event_buf().
Some gcc versions rightly complain about a possibly unitialized rc,
so let's move setting it before the QTAILQ_FOREACH().
Signed-off-by: Cornelia Huck <[email protected]>
Signed-off-by: Christian Borntraeger <[email protected]>
Signed-off-by: Jens Freimann <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| 773de5c786a6050bbf3b33c0e29d1bd519a40b4b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/773de5c786a6050bbf3b33c0e29d1bd519a40b4b | 2012-11-26 20:16:26+01:00 |
hmp: do not crash on invalid SCSI hotplug
Commit 0d93692 (qdev: Convert busses to QEMU Object Model, 2012-05-02)
removed a check on the type of the bus where a SCSI disk is hotplugged.
However, hot-plugging to the wrong kind of device now causes a crash
due to either a NULL pointer dereference (avoided by the previous patch)
or a failed QOM cast.
Instead, in this case we need to use object_dynamic_cast and check for
the result, similar to what was done before that commit.
Reported-by: Markus Armbruster <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| b5007bcc9729acd995518c52eb1038c4d8416b5d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b5007bcc9729acd995518c52eb1038c4d8416b5d | 2012-11-26 09:38:54-06:00 |
vmdk: Fix data corruption bug in WRITE and READ handling
Fixed a MAJOR BUG in VMDK files on file boundaries on reads
and ALSO ON WRITES WHICH MIGHT CORRUPT THE IMAGE AND DATA!!!!!!
Triggered for example with the following VMDK file (partly listed):
RW 4193792 FLAT "XP-W1-f001.vmdk" 0
RW 2097664 FLAT "XP-W1-f002.vmdk" 0
RW 4193792 FLAT "XP-W1-f003.vmdk" 0
RW 512 FLAT "XP-W1-f004.vmdk" 0
RW 4193792 FLAT "XP-W1-f005.vmdk" 0
RW 2097664 FLAT "XP-W1-f006.vmdk" 0
RW 4193792 FLAT "XP-W1-f007.vmdk" 0
RW 512 FLAT "XP-W1-f008.vmdk" 0
Patch includes:
1.) Patch fixes wrong calculation on extent boundaries. Especially it
fixes the relativeness of the sector number to the current extent.
Verfied correctness with:
1.) Converted either with Virtualbox to VDI and then with qemu-img and
then with qemu-img only:
VBoxManage clonehd --format vdi /VM/XP-W/new/XP-W1.vmdk ~/.VirtualBox/Harddisks/XP-W1-new-test.vdi
./qemu-img convert -O raw ~/.VirtualBox/Harddisks/XP-W1-new-test.vdi /root/QEMU/VM-XP-W1/XP-W1-via-VBOX.img
md5sum /root/QEMU/VM-XP-W/XP-W1-direct.img
md5sum /root/QEMU/VM-XP-W/XP-W1-via-VBOX.img
=> same MD5 hash
2.) Verified debug log files
3.) Run Windows XP successfully
4.) chkdsk run successfully without any errors
Signed-off-by: Gerhard Wiesinger <[email protected]>
Acked-by: Fam Zheng <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| b1649fae49a899a222c3ac53c5009dd6f23349e1 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b1649fae49a899a222c3ac53c5009dd6f23349e1 | 2012-11-14 18:19:23+01:00 |
fdc: implement VERIFY command
VERIFY command is like a READ command, except that read data is not
transfered by DMA.
As DMA engine is not used, so we have to start data transfer ourselves.
Signed-off-by: Hervé Poussineau <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 7ea004ed67e08462926a8559e1c6953e387e4035 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7ea004ed67e08462926a8559e1c6953e387e4035 | 2012-11-14 18:19:22+01:00 |
i386: kvm: x2apic is not supported without in-kernel irqchip
This is necessary so that x2apic is not improperly enabled when the
in-kernel irqchip is disabled.
This won't generate a warning with "-cpu ...,check" because the current
check/enforce code is broken (it checks the host CPU data directly,
instead of using kvm_arch_get_supported_cpuid()), but it will be
eventually fixed to properly report the missing x2apic flag.
Signed-off-by: Eduardo Habkost <[email protected]>
Signed-off-by: Marcelo Tosatti <[email protected]>
| 41e5e76db07b52591d9c9b88826278b8a5112258 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/41e5e76db07b52591d9c9b88826278b8a5112258 | 2012-10-30 23:39:48-02:00 |
pci: avoid destroying bridge address space windows in a transaction
Calling memory_region_destroy() in a transaction is illegal (and aborts),
as until the transaction is committed, the region remains live.
Fix by moving destruction until after the transaction commits. This requires
having an extra set of regions, so the new and old regions can coexist.
Signed-off-by: Avi Kivity <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| 523a59f596a3e62f5a28eb171adba35e71310040 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/523a59f596a3e62f5a28eb171adba35e71310040 | 2012-10-29 18:39:49+02:00 |
qemu-options.hx: Change from recommending '?' to 'help'
Update the -help output and documentation so that it recommends
'help' rather than '?' for the various "list valid values for this
option" cases. '?' is deprecated (as it can fail confusingly if
not quoted), so it's better to steer users towards 'help'. ('?'
still works, for backwards compatibility.)
This is the -help option part of the change otherwise done in
commit c8057f9, since we are now past release 1.2 and free to
change our help text without worrying about breaking libvirt.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
| 585f60368f23e6603cf86cfdaeceb89d1169f4b8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/585f60368f23e6603cf86cfdaeceb89d1169f4b8 | 2012-10-19 20:29:54+02:00 |
uhci: Verify queue has not been changed by guest
According to the spec a guest can unlink a qh, and then as soon as frindex
has changed by 1 since the unlink, assume it is idle and re-use it. However
for various reasons, we cannot simply consider a qh as unlinked if we've not
seen it for 1 frame. This means that it is possible for a guest to re-use /
restart the queue while we still see its old state. This patch adds a safety
check for this, and "early" retires queues when they were changed by the guest.
Signed-off-by: Hans de Goede <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
| 66a08cbe6ad1aebec8eecf58b3ba042e19dd1649 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/66a08cbe6ad1aebec8eecf58b3ba042e19dd1649 | 2012-10-25 09:08:11+02:00 |
tcg-sparc: Mask shift immediates to avoid illegal insns.
The xtensa-test image generates a sra_i32 with count 0x40.
Whether this is accident of tcg constant propagation or
originating directly from the instruction stream is immaterial.
Signed-off-by: Richard Henderson <[email protected]>
| 1fd959466574c3d46f4898f2e27cd3b1060338e4 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/1fd959466574c3d46f4898f2e27cd3b1060338e4 | 2012-09-21 22:02:19+02:00 |
qemu: Use valgrind annotations to mark kvm guest memory as defined
valgrind with kvm produces a big amount of false positives regarding
"Conditional jump or move depends on uninitialised value(s)". This
happens because the guest memory is allocated with qemu_vmalloc which
boils down posix_memalign etc. This function is (correctly) considered
by valgrind as returning undefined memory.
Since valgrind is based on jitting code, it will not be able to see
changes made by the guest to guest memory if this is done by KVM_RUN,
thus keeping most of the guest memory undefined.
Now lots of places in qemu will then use guest memory to change behaviour.
To avoid the flood of these messages, lets declare the whole guest
memory as defined. This will reduce the noise and allows us to see real
problems.
In the future we might want to make this conditional, since there
is actually something that we can use those false positives for:
These messages will point to code that depends on guest memory, so
we can use these backtraces to actually make an audit that is focussed
only at those code places. For normal development we dont want to
see those messages, though.
Signed-off-by: Christian Borntraeger <[email protected]>
Signed-off-by: Avi Kivity <[email protected]>
| 62fe83318d2fc5b31f473d66326910d94c1c4907 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/62fe83318d2fc5b31f473d66326910d94c1c4907 | 2012-09-09 16:48:34+03:00 |
console: Fix warning from clang (and potential crash)
ccc-analyzer reports this warning:
console.c:1090:29: warning: Dereference of null pointer
if (active_console->cursor_timer) {
^
Function console_select allows active_console to be NULL,
but would crash when accessing cursor_timer. Fix this.
Reviewed-by: Jan Kiszka <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 8bd6b06d7b718b3e595aab279699ef3651ce2e48 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8bd6b06d7b718b3e595aab279699ef3651ce2e48 | 2012-08-31 10:05:22-05:00 |
pseries: Remove unnecessary locking from PAPR hash table hcalls
In the paravirtualized environment provided by PAPR, there is a standard
locking scheme so that hypercalls updating the hash page table from
different guest threads don't corrupt the haah table state. We implement
this HVLOCK bit in out page table hypercalls. However, it is not necessary
in our case, since the hypercalls all run in the qemu environment under the
big qemu lock.
Therefore, this patch removes the locking code. This has the additional
advantage of freeing up a hash PTE bit which will be useful for migration
support.
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| 35f9304d925a5423c51bd2c83a81fa3cc2b6e680 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/35f9304d925a5423c51bd2c83a81fa3cc2b6e680 | 2012-10-04 15:54:18+02:00 |
target-i386: make it clearer that op table accesses don't overrun
Rephrase some of the expressions used to select an entry
in the SSE op table arrays so that it's clearer that they
don't overrun the op table array size.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Stefan Weil <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| bedc2ac1a746e61e2a42c98603922c488b82cddb | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/bedc2ac1a746e61e2a42c98603922c488b82cddb | 2012-07-07 09:06:15+00:00 |
build: fix build breakage due to bad merge
34bb443ee74df3780d86044dbf6492eb798c5807 broke the build but in a subtle way.
The patch on the ML was actually based on the 1.1.1 stable branch
(accidentally). When I merged it from the ML, the fuzzing got resolved in a
such a way that the newly introduced Makefile dependency on GENERATED_HEADERS
got lost (that was not in 1.1.1).
The dist bits also got duplicated (but this is just cosmetic).
Signed-off-by: Anthony Liguori <[email protected]>
| cb5fc67db90d80c5dddbd7be1044cc10ef471974 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/cb5fc67db90d80c5dddbd7be1044cc10ef471974 | 2012-07-17 18:58:20-05:00 |
qemu-ga: guest-suspend: make the API synchronous
Currently, qemu-ga has a SIGCHLD handler that automatically reaps terminated
children processes. The idea is to avoid having qemu-ga commands blocked
waiting for children to terminate.
That approach has two problems:
1. qemu-ga is unable to detect errors in the child, meaning that qemu-ga
returns success even if the child fails to perform its task
2. if a command does depend on the child exit status, the command has to
play tricks to bypass the automatic reaper
Case 2 impacts the guest-suspend-* API, because it has to execute an external
program to check for suspend support. Today, to bypass the automatic reaper,
suspend code has to double fork and pass exit status information through a
pipe. Besides being complex, this is prone to race condition bugs. Indeed,
the current code does have such bugs.
Making the guest-suspend-* API synchronous (ie. by dropping the SIGCHLD
handler and calling waitpid() from commands) is a much simpler approach,
which fixes current race conditions bugs and enables commands to detect
errors in the child.
This commit does just that. There's a side effect though, guest-shutdown
will generate zombies if shutting down fails. This will be fixed by the
next commit.
Signed-off-by: Luiz Capitulino <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Michael Roth <[email protected]>
| dc8764f06155a7b3e635e02281b747a9e292127e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/dc8764f06155a7b3e635e02281b747a9e292127e | 2012-05-15 09:15:16-05:00 |
usb-ehci: drop assert()
Not sure what the purpose of the assert() was, in any case it is bogous.
We can arrive there if transfer descriptors passed to us from the guest
failed to pass sanity checks, i.e. it is guest-triggerable. We deal
with that case by resetting the host controller. Everything is ok, no
need to throw a core dump here.
Signed-off-by: Gerd Hoffmann <[email protected]>
| c7020c974073ba9c0110d45361720a29ff6b2f59 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c7020c974073ba9c0110d45361720a29ff6b2f59 | 2012-04-17 10:23:29+02:00 |
rtl8139: do the network/host communication only in normal operating mode
According the spec, the card works in network/host communication mode only when
both EEM1 and EEM0 are unset in 93C46 Command Register (normal op
mode). So this patch check these bits before trying to receive packets.
As some guest driver (such as linux, see cp_init_hw() in 8139cp.c)
allocate rx ring after the recevier were enabled, this would cause our
emulation codes tries to dma into guest memory when the rx descriptor
is not properly configured. This patch fixes this.
Signed-off-by: Jason Wang <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| ff71f2e8cacefae99179993204172bc65e4303df | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ff71f2e8cacefae99179993204172bc65e4303df | 2012-03-16 01:04:51+02:00 |
slirp: Fix requeuing of batchq packets in if_start
In case we requeued a packet that was the head of a longer session
queue, we failed to restore this ordering. Also, we did not properly
deal with changes to Slirp::next_m.
Instead of a cumbersome roll back, this fix simply avoids any changes
until we know if the packet was actually sent. Both fixes crashes due
to inconsistent queues and simplifies the logic.
Thanks to Zhi Yong Wu who found the reason for these crashes.
CC: Zhi Yong Wu <[email protected]>
CC: Fabien Chouteau <[email protected]>
Signed-off-by: Jan Kiszka <[email protected]>
| b248ede2ef2792d364bd305e5e92e24921c924a8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b248ede2ef2792d364bd305e5e92e24921c924a8 | 2012-02-27 14:54:49+01:00 |
hw/vmmouse.c: Disable vmmouse after reboot
Bugfix after reboot when vmmouse was enabled and another OS which uses e.g. PS/2
mouse.
Details:
When a guest activated the vmmouse followed by a reboot the vmmouse was still
enabled and the PS/2 mouse was therefore unsusable. When another guest is then
booted without vmmouse support (e.g. PS/2 mouse) the mouse is not working.
Reason is that VMMouse has priority and disables all other mouse entities
and therefore must be disabled on reset.
Testscenario:
1.) Boot e.g. OS with VMMouse support (e.g. Windows with VMMouse tools)
2.) reboot
3.) Boot e.g. OS without VMMouse support (e.g. DOS) => PS/2 mouse doesn't work
any more. Fixes that issue.
Testscenario 2 by Jan Kiszka <[email protected]>:
Confirm that this patch fixes a real issue. Setup: qemu.git,
opensuse 11.4 guest, SDL graphic, system_reset while guest is using the
vmmouse. Without the patch, the vmmouse become unusable after the
reboot. Also, the mouse stays in absolute mode even before X starts again.
Fixed by:
Disabling the vmmouse in its reset handler.
Tested-by: Andreas F=E4rber <[email protected]>
Signed-off-by: Gerhard Wiesinger <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 069ab0eb8a46bc4ff6f4d4d81bf037d3441347da | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/069ab0eb8a46bc4ff6f4d4d81bf037d3441347da | 2012-02-01 16:24:38-06:00 |
Fix qapi code generation fix
The fixes to qapi code generation had multiple bugs:
- the Null class used to drop output was missing some methods
- in some scripts it was never instantiated, leading to a None return,
which is missing even more methods
- the --source and --header options were swapped
Luckily, all those bugs were hidden by a makefile bug which caused the
old behaviour (with the race) to be invoked.
Signed-off-by: Avi Kivity <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 19bf7c87081835449d5683ecb0858255bf5a0546 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/19bf7c87081835449d5683ecb0858255bf5a0546 | 2012-01-12 10:03:28-06:00 |
w32: Disable buffering for log file
W32 does not support line buffering, but it supports unbuffered output.
Unbuffered output is better for writing to qemu.log than fully buffered
output because it also shows the latest log messages when an application
crash occurs.
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| daf767b16aeb32e5b9a77066ba130fe723f875ca | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/daf767b16aeb32e5b9a77066ba130fe723f875ca | 2011-12-10 17:05:48+00:00 |
block: Fix bdrv_open use after free
tmp_filename was used outside the block it was defined in, i.e. after it went
out of scope. Move its declaration to the top level.
Signed-off-by: Kevin Wolf <[email protected]>
| 2b5728164fcf5211bbae8d3c2fc6df62dd6b2295 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/2b5728164fcf5211bbae8d3c2fc6df62dd6b2295 | 2011-10-28 19:25:49+02:00 |
migration: add error handling to migrate_fd_put_notify().
Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed,
since migrate_fd_put_notify() isn't checking error of underlying
QEMUFile, those resources are kept open. This patch checks it and
calls migrate_fd_error() in case of error.
Signed-off-by: Yoshiaki Tamura <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
Reviewed-by: Anthony Liguori <[email protected]>
| 2350e13c93c28f717e2ba1b31560b49ac6f81d4d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/2350e13c93c28f717e2ba1b31560b49ac6f81d4d | 2011-10-20 13:23:51+02:00 |
vvfat: Fix potential buffer overflow
path2[PATH_MAX] can be used for the null termination, so make the array big
enough to allow this.
Signed-off-by: Kevin Wolf <[email protected]>
| 0d460d6f414e02805cbc348404db03b2b7907360 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/0d460d6f414e02805cbc348404db03b2b7907360 | 2011-10-11 09:42:46+02:00 |
ARM: fix segfault
Fix a bug in bccd9ec5f098668576342c83d90d6d6833d61d33,
target-arm/op_helper.c missed a change unlike all other targets.
This lead to a NULL pointer dereferences.
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| 6e19a1379d3d12c2d8f934aa8154037a609f4507 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/6e19a1379d3d12c2d8f934aa8154037a609f4507 | 2011-10-08 10:00:02+00:00 |
memory: use signed arithmetic
When trying to map an alias of a ram region, where the alias starts at
address A and we map it into address B, and A > B, we had an arithmetic
underflow. Because we use unsigned arithmetic, the underflow converted
into a large number which failed addrrange_intersects() tests.
The concrete example which triggered this was cirrus vga mapping
the framebuffer at offsets 0xc0000-0xc7fff (relative to the start of
the framebuffer) into offsets 0xa0000 (relative to system addres space
start).
With our favorite analogy of a windowing system, this is equivalent to
dragging a subwindow off the left edge of the screen, and failing to clip
it into its parent window which is on screen.
Fix by switching to signed arithmetic.
Signed-off-by: Richard Henderson <[email protected]>
Signed-off-by: Avi Kivity <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 8417cebfda193c7f9ca70be5e308eaa92cf84b94 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8417cebfda193c7f9ca70be5e308eaa92cf84b94 | 2011-08-05 10:57:36-05:00 |
ide: Ignore reads during PIO in and writes during PIO out
This fixes https://bugs.launchpad.net/qemu/+bug/786209:
When the DRQ_STAT bit is set, the IDE core permits both data reads
and data writes, regardless of whether the current transfer was
initiated as a read or write.
This potentially leaks uninitialized host memory into the guest,
if, before doing anything else to an IDE device, the guest begins a
write transaction (e.g. WIN_WRITE), but then *reads* from the IO
port instead of writing to it.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
| 40c4ed3f95f0b2ffa0848df0fc311556bb7472a1 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/40c4ed3f95f0b2ffa0848df0fc311556bb7472a1 | 2011-07-05 11:23:42+02:00 |
usb-ehci: split trace calls to handle arg count limits
Signed-off-by: Gerd Hoffmann <[email protected]>
| 025b168ca674e42896c573fdbddf3090c6dc0d8f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/025b168ca674e42896c573fdbddf3090c6dc0d8f | 2011-06-14 12:56:49+02:00 |
Fix a bug in mtsr/mtsrin emulation on ppc64
Early ppc64 CPUs include a hack to partially simulate the ppc32 segment
registers, by translating writes to them into writes to the SLB. This is
not used by any current Linux kernel, but it is used by the openbios used
in the qemu mac99 model.
Commit 81762d6dd0d430d87024f2c83e9c4dcc4329fb7d, cleaning up the SLB
handling introduced a bug in this code, breaking the openbios currently in
qemu. Specifically, there was an off by one error bitshuffling the
register format used by mtsr into the format needed for the SLB load,
causing the flag bits to end up in the wrong place. This caused the
storage keys to be wrong under openbios, meaning that the translation code
incorrectly thought a legitimate access was a permission violation.
This patch fixes the bug, at the same time it fixes some build bug in the
MMU debugging code (only exposed when DEBUG_MMU is enabled).
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| decb471488dd9e7e7ab9957f120cb501c4489f63 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/decb471488dd9e7e7ab9957f120cb501c4489f63 | 2011-05-20 17:56:03+02:00 |
ich/ahci: fix uninitialized memory use
The commit 667bb59d2358daeef179583c944becba3f1f9680
uses d->ahci.mem before it is initialized by
ahci_init(). Fix this by calling ahci_init() first thing
so that it's safe to use all fields in the ahci state struct.
Reported-by: Alexey Zaytsev <[email protected]>
Reported-by: Jan Kiszka <[email protected]>
Tested-by: Alexey Zaytsev <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| 69c8944f17cb6c084567a16c080cfa7bc780e668 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/69c8944f17cb6c084567a16c080cfa7bc780e668 | 2011-05-16 14:23:45+03:00 |
rbd: check return values when scheduling aio
If scheduling fails, the number of outstanding I/Os must be correct,
or there will be a hang when waiting for everything to be flushed.
Reviewed-by: Christian Brunner <[email protected]>
Reported-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Josh Durgin <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 51a135287ae6be62d54d7ac2a99e647cbab1a828 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/51a135287ae6be62d54d7ac2a99e647cbab1a828 | 2011-06-08 11:56:40+02:00 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.