commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
add a new runstate: RUN_STATE_GUEST_PANICKED
The guest will be in this state when it is panicked.
Signed-off-by: Wen Congyang <[email protected]>
Signed-off-by: Hu Tao <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Message-id: 0255f263ffdc2a3716f73e89098b96fd79a235b3.1366945969.git.hutao@cn.fujitsu.com
Signed-off-by: Anthony Liguori <[email protected]>
| ede085b3fedfde36cb566968c4efcfbad4845af1 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ede085b3fedfde36cb566968c4efcfbad4845af1 | 2013-04-30 10:30:00-05:00 |
configure: Check that "libtool" is not the MacOSX one
The "libtool" binary on MacOSX is not GNU libtool, and doesn't support
anything like the same set of command line options. Test whether we
have accidentally picked this up (by looking for whether it handles
the GNU --version switch), and discard it if so. The fallback machinery
for the "we don't have a libtool" case will work fine. This fixes a
failure in "make install" on MacOSX.
Reported-by: Peter Cheung <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
| 8e515b125d5f7849167dbee6cbe6ef61636607d4 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8e515b125d5f7849167dbee6cbe6ef61636607d4 | 2013-05-06 06:52:03-05:00 |
exynos4210_fimd.c: fix display resize bug introduced after console revamp
In exynos4210 display update function, we were acquiring DisplaySurface
pointer before calling screen resize function, not paying attention that resize
procedure can replace current DisplaySurface with newly allocated one.
Right thing to do is to initialize DisplaySurface AFTER a call to resize function.
Signed-off-by: Igor Mitsyanko <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
| 522fccbe71e35efc96f66cb475f778c2ce02e9fc | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/522fccbe71e35efc96f66cb475f778c2ce02e9fc | 2013-04-16 09:03:46+02:00 |
usb-redir: Fix crash on migration with no client connected
If no client is connected on the src side, then we won't receive a
parser during migrate, in this case usbredir_post_load() should be a nop,
rather then to try to derefefence the NULL dev->parser pointer.
Signed-off-by: Hans de Goede <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
| 3713e1485e6eace7d48b9c790602cfd92c616e5f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/3713e1485e6eace7d48b9c790602cfd92c616e5f | 2013-04-03 09:55:48+02:00 |
qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows
Today we reset fd_counter if it wraps, but it's better to abort()
instead, as fd_counter should never reach INT64_MAX.
Signed-off-by: Luiz Capitulino <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
*fixed typo: s/resonable/reasonable/
Signed-off-by: Michael Roth <[email protected]>
| ce7f7cc2715145eadf1ac45a5dae63f535fc8bbf | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ce7f7cc2715145eadf1ac45a5dae63f535fc8bbf | 2013-04-02 09:06:11-05:00 |
target-ppc: Add more stubs for POWER7 PMU registers
In addition to the performance monitor registers found on nearly all
6xx chips, the POWER7 has two additional counters (PMC5 & PMC6) and an
extra control register (MMCRA). This patch adds stub support for them to
qemu - the registers won't do anything, but with this change won't cause
illegal instruction traps accessing them. They're also registered with
their ONE_REG ids, so their value will be kept in sync with KVM where
appropriate.
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| 702763fa322ea69dde92517735507e0ac3879b5d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/702763fa322ea69dde92517735507e0ac3879b5d | 2013-04-26 23:02:41+02:00 |
linux-user: make bogus negative iovec lengths fail EINVAL
If the guest passes us a bogus negative length for an iovec, fail
EINVAL rather than proceeding blindly forward. This fixes some of
the error cases tests for readv and writev in the LTP.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
| dfae8e00f8ddeedcda24bd28f71d4fd2a9f988b8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/dfae8e00f8ddeedcda24bd28f71d4fd2a9f988b8 | 2013-03-11 14:34:05+02:00 |
target-mips: fix DSP overflow macro and affected routines
The previous implementation incorrectly used same macro to detect overflow
for addition and subtraction. This patch makes distinction between these
two, and creates separate macros. The affected routines are changed
accordingly.
This change also includes additions to the existing tests for SUBQ_S_PH and
SUBQ_S_W that would trigger the fixed issue, and it removes dead code from
the test file. The last test case in subq_s_w.c is a bug found/reported/
isolated by Klaus Peichl from Dolby.
Signed-off-by: Petar Jovanovic <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
| 20c334a797bf46a4ee59a6e42be6d5e7c3cda585 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/20c334a797bf46a4ee59a6e42be6d5e7c3cda585 | 2013-03-04 18:15:34+01:00 |
qemu/iovec: Don't assert if sbytes is zero
Since these values can possibly be sent from guest (for hw/9pfs), do a sanity check
on them. A 9p write request with 0 bytes caused qemu to abort without this patch
Signed-off-by: Aneesh Kumar K.V <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| facf98ad987a38d97e12511f81375380b407a828 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/facf98ad987a38d97e12511f81375380b407a828 | 2013-02-06 08:29:50-06:00 |
parallels: Fix bdrv_open() error handling
Return -errno instead of -1 on errors. Hey, no memory leak to fix here
while we're touching it!
Signed-off-by: Kevin Wolf <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 46536235d80a012cc4286b71426cafad0c7f41f0 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/46536235d80a012cc4286b71426cafad0c7f41f0 | 2013-02-01 14:58:29+01:00 |
fw_cfg: Splash image loader can overrun a stack variable, fix
read_splashfile() passes the address of an int variable as size_t *
parameter to g_file_get_contents(), with a cast to gag the compiler.
No problem on machines where sizeof(size_t) == sizeof(int).
Happens to work on my x86_64 box (64 bit little endian): the least
significant 32 bits of the file size end up in the right place
(caller's variable file_size), and the most significant 32 bits
clobber a place that gets assigned to before its next use (caller's
variable file_type).
I'd expect it to break on a 64 bit big-endian box.
Fix up the variable types and drop the problematic cast.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Laszlo Ersek <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| d09acb9b5ef0bb4fa94d3d459919a6ebaf8804bc | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/d09acb9b5ef0bb4fa94d3d459919a6ebaf8804bc | 2013-01-26 13:23:33+00:00 |
vmware_vga: fix out of bounds and invalid rects updating
This is a follow up for several attempts to fix this issue.
Previous incarnations:
1. http://thread.gmane.org/gmane.linux.ubuntu.bugs.general/3156089
https://bugs.launchpad.net/bugs/918791
"qemu-kvm dies when using vmvga driver and unity in the guest" bug.
Fix by Serge Hallyn:
https://launchpadlibrarian.net/94916786/qemu-vmware.debdiff
This fix is incomplete, since it does not check width and height
for being negative. Serge weren't sure if that's the right place
to fix it, maybe the fix should be up the stack somewhere.
2. http://thread.gmane.org/gmane.comp.emulators.qemu/166064
by Marek Vasut: "vmware_vga: Redraw only visible area"
This one adds the (incomplete) check to vmsvga_update_rect_delayed(),
the routine just queues the rect updating but does no interesting
stuff. It is also incomplete in the same way as patch by Serge,
but also does not touch width&height at all after adjusting x&y,
which is wrong.
As far as I can see, when processing guest requests, the device
places them into a queue (vmsvga_update_rect_delayed()) and
processes this queue in different place/time, namely, in
vmsvga_update_rect(). Sometimes, vmsvga_update_rect() is
called directly, without placing the request to the gueue.
This is the place this patch changes, which is the last
(deepest) in the stack. I'm not sure if this is the right
place still, since it is possible we have some queue optimization
(or may have in the future) which will be upset by negative/wrong
values here, so maybe we should check for validity of input
right when receiving request from the guest (and maybe even
use unsigned types there). But I don't know the protocol
and implementation enough to have a definitive answer.
But since vmsvga_update_rect() has other sanity checks already,
I'm adding the missing ones there as well.
Cc'ing BALATON Zoltan and Andrzej Zaborowski who shows in `git blame'
output and may know something in this area.
If this patch is accepted, it should be applied to all active
stable branches (at least since 1.1, maybe even before), with
minor context change (ds_get_*(s->vga.ds) => s->*). I'm not
Cc'ing -stable yet, will do it explicitly once the patch is
accepted.
BTW, these checks use fprintf(stderr) -- it should be converted
to something more appropriate, since stderr will most likely
disappear somewhere.
Cc: Marek Vasut <[email protected]>
CC: Serge Hallyn <[email protected]>
Cc: BALATON Zoltan <[email protected]>
Cc: Andrzej Zaborowski <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
Reviewed-by: Marek Vasut <[email protected]>
Signed-off-by: Serge Hallyn <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| 8cb6bfb54e91b1a31a6ae704def595c2099efde1 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8cb6bfb54e91b1a31a6ae704def595c2099efde1 | 2013-01-26 13:33:02+00:00 |
target-i386: Use switch in check_hw_breakpoints()
Replace an if statement using magic numbers for breakpoint type with a
more explicit switch statement. This is to aid readability.
Change the return type and force_dr6_update argument type to bool.
While at it, fix Coding Style issues (missing braces).
Signed-off-by: liguang <[email protected]>
Signed-off-by: Andreas Färber <[email protected]>
| e175bce587936bf479889881488821ea8d61c89c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e175bce587936bf479889881488821ea8d61c89c | 2013-01-15 09:23:50+01:00 |
ppc/booke: fix crit/mcheck/debug exceptions
Book E does not play games with certain bits of xSRR1 being MSR save
bits and others being error status. xSRR1 is the old MSR, period.
This was causing things like MSR[CE] to be lost, even in the saved
version, as soon as you take an exception.
rfci/rfdi/rfmci are fixed to pass the actual xSRR1 register contents,
rather than the register number.
Put FIXME comments on the hack that is "asrr0/1". The whole point of
separate exception levels is so that you can, for example, take a machine
check or debug interrupt without corrupting critical-level operations.
The right xSRR0/1 set needs to be chosen based on CPU type flags.
Signed-off-by: Scott Wood <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| a1bb73849fbd7d992b6ac2cf30c034244fb2299d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a1bb73849fbd7d992b6ac2cf30c034244fb2299d | 2013-01-07 17:37:10+01:00 |
S390: Enable -cpu help and QMP query-cpu-definitions
This enables qemu -cpu help to return a list of supported CPU models
on s390 and also to query for cpu definitions in the monitor.
Initially only cpu model = host is returned. This needs to be reworked
into a full-fledged CPU model handling later on.
This change is needed to allow libvirt exploiters (like OpenStack)
to specify a CPU model.
Signed-off-by: Viktor Mihajlovski <[email protected]>
Signed-off-by: Jens Freimann <[email protected]>
Reviewed-by: Christian Borntraeger <[email protected]>
[agraf: fix s390x-linux-user, adjust header locations]
Signed-off-by: Alexander Graf <[email protected]>
| 904e5fd5c25537fdf910bfd5db832df5d9c23ad6 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/904e5fd5c25537fdf910bfd5db832df5d9c23ad6 | 2013-01-18 19:07:47+01:00 |
qemu-img: report size overflow error message
qemu-img will complain when qcow or qcow2
size overflow for 64 bits, report the right
message in this condition.
$./qemu-img create -f qcow2 /tmp/foo 0x10000000000000000
before change:
qemu-img: Invalid image size specified! You may use k, M, G or T suffixes for
qemu-img: kilobytes, megabytes, gigabytes and terabytes.
after change:
qemu-img: Image size must be less than 8 EiB!
[Resolved conflict with a9300911 goto removal -- Stefan]
Signed-off-by: liguang <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 7944339726b4582b67fd94085c21c33636e8f973 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7944339726b4582b67fd94085c21c33636e8f973 | 2013-01-02 16:08:56+01:00 |
Update seabios to a810e4e72a0d42c7bc04eda57382f8e019add901
git shortlog:
Kevin O'Connor (6):
floppy: Minor - reduce handle_0e code size when CONFIG_FLOPPY is disabled.
vga: Minor comment spelling fix.
Don't recursively evaluate CFLAGS variables.
Don't use gcc's -combine option.
Add compile checking phase to build.
acpi: Use prt_slot() macro to describe irq pins of first PCI device.
Laszlo Ersek (1):
maininit(): print machine UUID under seabios version message
Paolo Bonzini (1):
acpi: reintroduce LNKS
Paolo's patch fixes the FreeBSD boot failure.
Cc: [email protected]
Signed-off-by: Gerd Hoffmann <[email protected]>
| 15faf946f7a17a5fab0d05a2312d43249d81af3c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/15faf946f7a17a5fab0d05a2312d43249d81af3c | 2012-12-20 08:19:40+01:00 |
savevm.c: cleanup system includes
savevm.c suffers from the same problem as some other files.
Some years ago savevm.c was created from vl.c, moving some
code from there into a separate file. At that time, all
includes were just copied from vl.c to savevm.c, without
checking which ones are needed and which are not.
But actually most of that stuff is _not_ needed. More, some
stuff is wrong, for example, *BSD #ifdef'ery around <util.h>
vs <libutil.h> - for one, it fails to build on Debian/kFreebsd.
Just remove all this. Maybe there's a possibility to clean
it up further - like removing <windows.h> (and maybe including
winsock.h for htons etc), and maybe it's possible to remove
some internal #includes too, but I didn't check this.
While at it, remove duplicate #include of qemu/timer.h.
Signed-off-by: Michael Tokarev <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 74e91370beb3fabda515623b4491a8b7a024304a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/74e91370beb3fabda515623b4491a8b7a024304a | 2013-01-02 13:32:48-06:00 |
pseries: Update SLOF for NVRAM support
Now that we have implemented PAPR compatible NVRAM interfaces in qemu, this
updates the SLOF firmware to actually initialize and use the NVRAM as a
PAPR guest firmware is expected to do.
This SLOF update also includes an ugly but useful workaround for a bug in
the SLES11 installer which caused it to fail under KVM.
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| 4fd50339c0b55fa6387fa3c28f755c306997064c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4fd50339c0b55fa6387fa3c28f755c306997064c | 2012-12-14 13:12:54+01:00 |
usb: tag usb host adapters as not hotpluggable.
Hotplugging them simply doesn't work, so tag them accordingly to
avoid users trying and then crashing qemu.
For xhci there is nothing fundamental which prevents hotplug from
working, we'll "only" need a exit() function which cleans up
everything properly. That isn't for 1.3 though.
For ehci+uhci+ohci hotplug can't be supported until qemu gains the
capability to hotplug multifunction pci devices.
https://bugzilla.redhat.com/show_bug.cgi?id=879096
Signed-off-by: Gerd Hoffmann <[email protected]>
| 6c2d1c32d084320081b0cd047f8cacd6e722d03a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/6c2d1c32d084320081b0cd047f8cacd6e722d03a | 2012-11-29 08:04:13+01:00 |
scsi: do not return short responses for emulated commands
The inquiry command, for the case of VPD=1, was returning short
responses; the number of returned bytes was just the number of bytes
in the request, without padding to the specified allocation length
with zero bytes. This is usually harmless, but it is a violation
of the SCSI specification.
To fix this, always pad with zero bytes to r->cmd.xfer in
scsi_disk_emulate_command, and return at most r->buflen bytes
(the size of the buffer for command data) rather than at most
buflen bytes (the number of bytes that was filled in).
Before this patch, "strace sg_inq -p0x83 /dev/sda" would report a
non-zero resid value. After this patch, it reports resid=0.
Signed-off-by: Paolo Bonzini <[email protected]>
| c8dcb531bcd37a4a81d2cc08a89fcd19c34348f9 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c8dcb531bcd37a4a81d2cc08a89fcd19c34348f9 | 2012-11-12 15:00:27+01:00 |
lm32: avoid buffer overrun
Actually do what the comment says, using pstrcpy NUL-terminate:
strncpy does not always do that.
Signed-off-by: Jim Meyering <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 1044dc1118d9a90e2aa324047bea9c91c889e28f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/1044dc1118d9a90e2aa324047bea9c91c889e28f | 2012-10-05 07:58:37-05:00 |
ppc: avoid buffer overrun: use pstrcpy, not strncpy
A terminal NUL is required by caller's use of strchr.
It's better not to use strncpy at all, since there is no need
to zero out hundreds of trailing bytes for each iteration.
Signed-off-by: Jim Meyering <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| ae2150680190e510dcbcdfdbfb3a54369c75367f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ae2150680190e510dcbcdfdbfb3a54369c75367f | 2012-10-05 07:58:37-05:00 |
ppc405_uc: Fix buffer overflow
Report from smatch:
ppc405_uc.c:209 dcr_read_pob(12) error: buffer overflow 'pob->besr' 2 <= 2
ppc405_uc.c:232 dcr_write_pob(12) error: buffer overflow 'pob->besr' 2 <= 2
The old code reads and writes besr[POB0_BESR1 - POB0_BESR0] or besr[2]
which is one too much.
Signed-off-by: Stefan Weil <[email protected]>
Reviewed-by: Andreas Färber <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| 5a1972c8472fafd519a68b689fdcaf33ec857945 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5a1972c8472fafd519a68b689fdcaf33ec857945 | 2012-10-04 15:54:18+02:00 |
tcg: Sanity check deposit inputs
Given these are constants, checking once here means everything
after can assume they're correct.
Signed-off-by: Richard Henderson <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
| 717e70368bdc339d241f84aba00ed72d051e0236 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/717e70368bdc339d241f84aba00ed72d051e0236 | 2012-09-26 00:31:16+02:00 |
scsi-disk: introduce check_lba_range
Abstract the test for an out-of-range (starting block, block count)
pair.
Signed-off-by: Paolo Bonzini <[email protected]>
| 444bc908611ccaf4512dc37c33ac3b54d873a62b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/444bc908611ccaf4512dc37c33ac3b54d873a62b | 2012-09-21 16:12:34+02:00 |
target-cris: Fix buffer overflow
Report from smatch:
target-cris/translate.c:3464 cpu_dump_state(32) error:
buffer overflow 'env->sregs' 4 <= 255
sregs is declared 'uint32_t sregs[4][16]', so the first index must be
less than 4 or ARRAY_SIZE(env->sregs).
Signed-off-by: Stefan Weil <[email protected]>
| c001ed15f7bfeaa3cabde5c9cc79c4dfdb674769 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c001ed15f7bfeaa3cabde5c9cc79c4dfdb674769 | 2012-09-08 06:30:25+02:00 |
arm-semi: don't leak 1KB user string lock buffer upon TARGET_SYS_OPEN
Always call unlock_user before returning.
Signed-off-by: Jim Meyering <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 396bef4b3846bf4e80a2bee38e9a2d8554d0f251 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/396bef4b3846bf4e80a2bee38e9a2d8554d0f251 | 2012-08-22 10:47:14-05:00 |
scsi: fix warning
hw/scsi-bus.c:758: warning: ‘xfer’ may be used uninitialized in this
function
Isn't true, but older gcc versions (for example 4.1 as shipped in rhel5)
are not clever enougth to figure, so sprinkle in a default: line to make
them happy.
Signed-off-by: Gerd Hoffmann <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| d83c951cce14dd3c7600c386d3791c4993744622 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/d83c951cce14dd3c7600c386d3791c4993744622 | 2012-08-18 08:50:09+00:00 |
qapi: add query-cpu-definitions command (v2)
This command attempts to map to the behavior of -cpu ?. Unfortunately, the
output of this command differs wildly across targets.
To accommodate this, we use a weak symbol to implement a default version of the
command that fails with a QERR_NOT_SUPPORTED error code. Targets can then
override and implement this command if it makes sense for them.
Signed-off-by: Anthony Liguori <[email protected]>
Signed-off-by: Luiz Capitulino <[email protected]>
| e4e31c6324af480a22bf4150266b278368eaa336 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e4e31c6324af480a22bf4150266b278368eaa336 | 2012-08-13 16:10:18-03:00 |
rtl8139: validate rx ring before receiving packets
Commit ff71f2e8cacefae99179993204172bc65e4303df prevent the possible
crash during initialization of linux driver by checking the operating
mode.This seems too strict as:
- the real card could still work in mode other than normal
- some buggy driver who does not set correct opmode after eeprom
access
So, considering rx ring address were reset to zero (which could be
safely trated as an address not intened to DMA to), in order to
both letting old guest work and preventing the unexpected DMA to
guest, we can forbid packet receiving when rx ring address is zero.
Tested-by: Avi Kivity <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| fcce6fd25f3e233f9da9ef01230a668ab35bd343 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/fcce6fd25f3e233f9da9ef01230a668ab35bd343 | 2012-06-27 16:27:00-05:00 |
spapr_vscsi: Error handling fixes
We were incorrectly g_free'ing an object that isn't allocated
in one error path and failed to release it completely in another
This fixes qemu crashes with some cases of IO errors.
Signed-off-by: Benjamin Herrenschmidt <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| a4d8e8daee324e230b0155915f562743f4fff5d8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a4d8e8daee324e230b0155915f562743f4fff5d8 | 2012-06-24 01:04:45+02:00 |
Add rate limiting of RTC_CHANGE, BALLOON_CHANGE & WATCHDOG events
Allow certain event types to be rate limited to avoid flooding
monitor clients. The monitor_protocol_event() method is changed
such that instead of immediately emitting the event to Monitor
instances, it will call a new monitor_protocol_event_queue()
method.
This will check to see if the rate limit for the event has been
exceeded, and if so schedule a timer to wakeup at the end of the
rate limit period. If further events arrive before the timer fires,
the previously queued event will be discarded in favour of the new
event. The event will eventually be emitted when the timer fires.
This logic is applied to RTC_CHANGE, BALLOON_CHANGE & WATCHDOG
events, since the data associated with these events is stateless
* monitor.c: Add support for rate limiting
* monitor.h: Define monitor_global_init for one-time setup tasks
* vl.c: Invoke monitor_global_init
* trace-events: Add hooks for monitor event tracing
Signed-off-by: Daniel P. Berrange <[email protected]>
Acked-by: Amit Shah <[email protected]>
Signed-off-by: Luiz Capitulino <[email protected]>
| afeecec2e8e99ba184c487633d5d0dde68a002ac | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/afeecec2e8e99ba184c487633d5d0dde68a002ac | 2012-06-15 13:35:00-03:00 |
tcg/ppc: Handle _CALL_DARWIN being undefined on Darwin
powerpc-apple-darwin9-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5577)
does not define _CALL_DARWIN, leading to unexpected behavior w.r.t.
register clobbering and stack frame layout.
Since _CALL_DARWIN is a reserved identifier, define a custom
TCG_TARGET_CALL_DARWIN based on either _CALL_DARWIN or __APPLE__.
Signed-off-by: Andreas F?rber <[email protected]>
Signed-off-by: malc <[email protected]>
| 24f50d7ea5896a30b0e78f68884586bb8b40ff97 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/24f50d7ea5896a30b0e78f68884586bb8b40ff97 | 2012-05-27 21:52:56+04:00 |
virtio: order index/descriptor reads
virtio has the equivalent of:
if (vq->last_avail_index != vring_avail_idx(vq)) {
read descriptor head at vq->last_avail_index;
}
In theory, processor can reorder descriptor head
read to happen speculatively before the index read.
this would trigger the following race:
host descriptor head read <- reads invalid head from ring
guest writes valid descriptor head
guest writes avail index
host avail index read <- observes valid index
as a result host will use an invalid head value.
This was not observed in the field by me but after
the experience with the previous two races
I think it is prudent to address this theoretical race condition.
Signed-off-by: Michael S. Tsirkin <[email protected]>
| a821ce59338c79bb72dc844dd44ea53701965b2b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a821ce59338c79bb72dc844dd44ea53701965b2b | 2012-04-25 10:53:47+03:00 |
qcow2: Limit COW to where it's needed
This fixes a regression introduced in commit 250196f1. The bug leads to
data corruption, found during an Autotest run with a Fedora 8 guest.
Consider a write request whose first part is covered by an already
allocated cluster, but additional clusters need to be newly allocated.
When counting the number of clusters to allocate, the qcow2 code would
decide to do COW for all remaining clusters of the write request, even
if some of them are already allocated.
If during this COW operation another write request is issued that touches
the same cluster, it will still refer to the old cluster. When the COW
completes, the first request will update the L2 table and the second
write request will be lost. Note that the requests need not overlap, it's
enough for them to touch the same cluster.
This patch ensures that only clusters that really require COW are
considered for allocation. In this case any other request writing to the
same cluster will be an allocating write and gets serialised.
Reported-by: Marcelo Tosatti <[email protected]>
Tested-by: Marcelo Tosatti <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 54e6814360ab2110ed3ed07b2b9a3f9907e1202a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/54e6814360ab2110ed3ed07b2b9a3f9907e1202a | 2012-05-07 19:33:18+02:00 |
tracetool: handle DTrace keywords 'in', 'next', 'self'
Language keywords cannot be used as argument names. The DTrace backend
appends an underscore to the argument name in order to make the argument
name legal.
This patch adds 'in', 'next', and 'self' keywords to dtrace.py.
Also drop the unnecessary argument name lstrip() call. The
Arguments.build() method already ensures there is no space around
argument names. Furthermore it is misleading to do the lstrip() *after*
checking against keywords because the keyword check would not match if
spaces were in the name.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Alon Levy <[email protected]>
Reviewed-by: Lluís Vilanova <[email protected]>
| 256a721d46a112d8807a488ec0176985c09bbbf1 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/256a721d46a112d8807a488ec0176985c09bbbf1 | 2012-04-18 14:03:00+01:00 |
scsi: force unit access on VERIFY
Also DMA data from the host, to avoid that the host reports an
underrun.
Signed-off-by: Paolo Bonzini <[email protected]>
| 7f64f8e2c3c5a02636c2a6b8d6e6c5f7a62b89f7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7f64f8e2c3c5a02636c2a6b8d6e6c5f7a62b89f7 | 2012-04-19 16:15:58+02:00 |
acpi_piix4: Fix PCI hotplug race
As Michael Tsirkin demonstrated, current PCI hotplug is vulnerable
to a few races. The first is a race with other hotplug operations
because we clear the up & down registers at each event. If a new
event comes before the last is processed, up/down is cleared and
the event is lost.
To fix this for the down register, we create a life cycle for
the event request that starts with the hot unplug request in
piix4_device_hotplug() and ends when the device is ejected.
This allows us to mask and clear individual bits, preserving them
against races. For the up register, we have no clear end point
for when the event is finished. We could modify the BIOS to
acknowledge the bit and clear it, but this creates BIOS compatibiliy
issues without offering a complete solution. Instead we note that
gratuitous ACPI device checks are not harmful, which allows us to
issue a device check for every slot. We know which slots are present
and we know which slots are hotpluggable, so we can easily reduce
this to a more manageable set for the guest.
The other race Michael noted was that an unplug request followed
by reset may also lose the eject notification, which may also
result in the eject request being lost which a subsequent add
or remove. Once we're in reset, the device is unused and we can
flush the queue of device removals ourselves. Previously if a
device_del was issued to a guest without ACPI PCI hotplug support,
it was necessary to shutdown the guest to recover the device.
With this, a guest reboot is sufficient.
Signed-off-by: Alex Williamson <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| 7faa8075d898ae56d2c533c530569bb25ab86eaf | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7faa8075d898ae56d2c533c530569bb25ab86eaf | 2012-04-15 12:17:23+03:00 |
pcnet: Properly handle TX requests during Link Fail
As long as we have no link and we aren't in internal loopback mode, no
packet must be sent. Instead, LCAR needs to be set in any active TX
descriptor and also CERR in CSR0.
Signed-off-by: Jan Kiszka <[email protected]>
| ef45c9147f534531ef5d8a20315089d43ea4ddef | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ef45c9147f534531ef5d8a20315089d43ea4ddef | 2012-04-16 15:41:28+02:00 |
Userspace ARM BE8 support
Add support for ARM BE8 userspace binaries.
i.e. big-endian data and little-endian code.
In principle LE8 mode is also possible, but AFAIK has never actually
been implemented/used.
System emulation doesn't have any useable big-endian board models,
but should in principle work once you fix that.
Dynamic endianness switching requires messing with data accesses,
preferably with TCG cooperation, and is orthogonal to BE8 support.
Signed-off-by: Paul Brook <[email protected]>
[PMM: various changes, mostly as per my suggestions in code review:
* rebase
* use EF_ defines rather than hardcoded constants
* make bswap_code a bool for future VMSTATE macro compatibility
* update comment in cpu.h about TB flags bit field usage
* factor out load-code-and-swap into arm_ld*_code functions and
get_user_code* macros
* fix stray trailing space at end of line
* added braces in disas.c to satisfy checkpatch
]
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
| d8fd2954996255ba6ad610917e7849832d0120b7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/d8fd2954996255ba6ad610917e7849832d0120b7 | 2012-04-06 19:25:57+03:00 |
kvm: fill in padding to help valgrind
valgrind warns about padding fields which are passed
to vcpu ioctls uninitialized.
This is not an error in practice because kvm ignored padding.
Since the ioctls in question are off data path and
the cost is zero anyway, initialize padding to 0
to suppress these errors.
Signed-off-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Avi Kivity <[email protected]>
| 7e680753cfa2986e0a8b3b222b6bf0b003c5eb69 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/7e680753cfa2986e0a8b3b222b6bf0b003c5eb69 | 2012-03-07 12:31:48+02:00 |
Fix vnc memory corruption with width = 1400
vnc assumes that the screen width is a multiple of 16 in several places.
If this is not the case vnc will overrun buffers, corrupt memory, make
qemu crash.
This is the minimum fix for this bug. It makes sure we don't overrun the
scanline, thereby fixing the segfault. The rendering is *not* correct
though, there is a black border at the right side of the screen, 8
pixels wide because 1400 % 16 == 8.
Signed-off-by: Gerd Hoffmann <[email protected]>
| ce3e14175ea36d851aede808fc8891313b91ec27 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ce3e14175ea36d851aede808fc8891313b91ec27 | 2012-02-10 09:58:33+01:00 |
qemu-iotests: Use zero-based offsets for IO patterns
The io_pattern style functions have the following loop:
for i in `seq 1 $count`; do
echo ... $(( start + i * step )) ...
done
Offsets are 1-based so start=1024, step=512, count=4 yields:
1536, 2048, 2560, 3072
Normally we expect:
1024, 1536, 2048, 2560
Most tests ignore this detail, which means that they perform I/O to a
slightly different range than expected by the test author.
Later on things got less innocent and tests started trying to compensate
for the 1-based indexing. This included negative start values in test
024 and my own attempt with count-1 in test 028!
The end result is that tests that use io_pattern are hard to reason
about and don't work the way you'd expect. It's time to clean this mess
up.
This patch switches io_pattern to 0-based offsets. This requires
adjusting the golden outputs since I/O ranges are now shifted and output
differs.
Verifying these output diffs is easy, however. Each diff hunk moves one
I/O from beyond the end of the pattern range to the beginning.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
| dd0c35d69b31cfccaca30842787f0450ab70056c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/dd0c35d69b31cfccaca30842787f0450ab70056c | 2012-02-23 10:29:46+01:00 |
pseries: Use correct dispatcher for PCI config space accesses
The pseries machine expects a para-virtualized guest and so supplies RTAS
functions (via a hypercall) for performing PCI config space access.
Currently the implementation of these calls into
pci_default_{read,write}_config(). However this would be incorrect for
any PCI device which overrides the default config read/write functions.
AFAICT there's only one such device today, but we should still get it
right. In addition the pci_host_config_{read,write}_common() functions
which do correctly do this dispatch, perform bounds checking on the config
space address, lack of which currently leads to an exploitable bug.
This patch corrects the problem.
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| c9c3c80af71dd2b7813d1ada9b14cb51df584221 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/c9c3c80af71dd2b7813d1ada9b14cb51df584221 | 2012-01-21 05:17:02+01:00 |
vhost: fix mem_sections memory corruption
A memset() used to delete an entry in an array did not take into account
the array element's size.
Signed-off-by: Avi Kivity <[email protected]>
Acked-by: Michael S. Tsirkin <[email protected]>
| 637f7a6a01e09bc39f7b3a24257a9cd6ea396ca0 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/637f7a6a01e09bc39f7b3a24257a9cd6ea396ca0 | 2012-01-09 13:59:50+02:00 |
hw/sd.c: Set ILLEGAL_COMMAND for ACMDs in invalid state
App commands in an invalid state should set ILLEGAL_COMMAND, not
merely return a zero response.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Andrzej Zaborowski <[email protected]>
| 5b08bfe2e94c7b1ce39aa3b196231c7f30a5defd | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5b08bfe2e94c7b1ce39aa3b196231c7f30a5defd | 2011-12-21 05:01:39+01:00 |
block: simplify failure handling for bdrv_aio_multiwrite
Now that early failure of bdrv_aio_writev is not possible anymore,
mcb->num_requests can be set before the loop starts.
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| df9309fb432f3fc9f66f4a567f70970d4e46010a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/df9309fb432f3fc9f66f4a567f70970d4e46010a | 2011-12-15 12:40:07+01:00 |
qemu-common: add QEMU_ALIGN_DOWN() and QEMU_ALIGN_UP() macros
Add macros for aligning a number to a multiple, for example:
QEMU_ALIGN_DOWN(500, 2000) = 0
QEMU_ALIGN_UP(500, 2000) = 2000
Since ALIGN_UP() is a common macro name use the QEMU_* namespace prefix.
Hopefully this will protect us from included headers that leak something
with a similar name.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 3951690a4a29e031492090131d001e5047938631 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/3951690a4a29e031492090131d001e5047938631 | 2011-12-05 14:51:37+01:00 |
pseries: Check we have a chardev in spapr_vty_init()
If qemu is run like:
qemu-system-ppc64 -nodefaults -device spapr-vty
We end up in spapr_vty_init() with dev->chardev == NULL. Currently
that leads to a segfault because we unconditionally call
qemu_chr_add_handlers().
Although we could make that call conditional, I think a spapr-vty
without a chardev is basically useless so fail the init. This is
similar to what the serial code does for example.
Signed-off-by: Michael Ellerman <[email protected]>
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
| 57285302af51a8bae334c03e1f8243e935373953 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/57285302af51a8bae334c03e1f8243e935373953 | 2011-11-18 14:22:46+01:00 |
migration: flush migration data to disk.
This patch increases robustness when migrating to a file with
two little changes:
(1) Before closing the migration file handle checks if it happens to be
a regular file and if so it issues a fsync. This way the data is
flushed to disk before qemu sends the migration completed event.
(2) It adds error checking. In case either fsync or close syscall
fails pass up the error (and fail migration).
[ v2: return -errno instead of -1 ]
Cc: Juan Quintela <[email protected]>
Cc: Jiri Denemark <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| aab2293687ee54a409f3fb53a1ab3595b595e0fb | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/aab2293687ee54a409f3fb53a1ab3595b595e0fb | 2011-11-01 11:50:21-05:00 |
usb-storage: fix NULL pointer dereference.
When a usb packet is canceled we need to check whenever we actually have
a scsi request in flight before we try to cancel it.
Signed-off-by: Gerd Hoffmann <[email protected]>
| d3ac1a87b228bcd231d19acf1ebe9844b7639237 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/d3ac1a87b228bcd231d19acf1ebe9844b7639237 | 2011-10-13 12:58:51+02:00 |
PPC: E500: Add PV spinning code
CPUs that are not the boot CPU need to run in spinning code to check if they
should run off to execute and if so where to jump to. This usually happens
by leaving secondary CPUs looping and checking if some variable in memory
changed.
In an environment like Qemu however we can be more clever. We can just export
the spin table the primary CPU modifies as MMIO region that would event based
wake up the respective secondary CPUs. That saves us quite some cycles while
the secondary CPUs are not up yet.
So this patch adds a PV device that simply exports the spinning table into the
guest and thus allows the primary CPU to wake up secondary ones.
Signed-off-by: Alexander Graf <[email protected]>
---
v1 -> v2:
- change into MMIO scheme
- map the secondary NIP instead of 0 1:1
- only map 64MB for TLB, same as u-boot
- prepare code for 64-bit spinnings
v2 -> v3:
- remove r6
- set MAS2_M
- map EA 0
- use second TLB1 entry
v3 -> v4:
- change to memoryops
v4 -> v5:
- fix endianness bugs
v5 -> v6:
- add header
| 5c145dacacad04f751ca5c3fb6467e590e7f3c46 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5c145dacacad04f751ca5c3fb6467e590e7f3c46 | 2011-10-06 09:47:52+02:00 |
scsi: Sanitize command definitions
Sanitize SCSI command definitions.
Add _10 suffix to READ_CAPACITY, WRITE_VERIFY, VERIFY, READ_LONG,
WRITE_LONG, and WRITE_SAME.
Add new command definitions for LOCATE_10, UNMAP, VARLENGTH_CDB,
WRITE_FILEMARKS_16, EXTENDED_COPY, ATA_PASSTHROUGH, ACCESS_CONTROL_IN,
ACCESS_CONTROL_OUT, COMPARE_AND_WRITE, VERIFY_16, SYNCHRONIZE_CACHE_16,
LOCATE_16, ERASE_16, WRITE_LONG_16, LOAD_UNLOAD, VERIFY_12.
Remove invalid definition of WRITE_LONG_2.
Signed-off-by: Hannes Reinecke <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 5e30a07d6d70d3073ff61e6db79d61c2b688502f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5e30a07d6d70d3073ff61e6db79d61c2b688502f | 2011-08-01 12:10:28+02:00 |
target-i386: Make x86 mfence and lfence illegal without SSE2
While trying to use qemu -cpu pentium3 to test for incorrect uses of certain
SSE2 instructions, I found that QEMU allowed the mfence and lfence
instructions to be executed even though Pentium 3 doesn't support them.
According to the processor specs (and experience on a real Pentium 3), these
instructions are only available with SSE2, but QEMU is checking for SSE. The
check for the related sfence instruction is correct (it works with SSE).
This trival patch fixes the test.
Signed-off-by: Martin Simmons <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
| 8001c294f878966c0a9efe2e811d56d3f5a7da69 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8001c294f878966c0a9efe2e811d56d3f5a7da69 | 2011-06-08 09:04:29+01:00 |
scsi: Update sense code handling
The SCSI spec has a quite detailed list of sense codes available.
It even mandates the use of specific ones for some failure cases.
The current implementation just has one type of generic error
which is actually a violation of the spec in certain cases.
This patch introduces various predefined sense codes to have the
sense code reporting more in line with the spec.
On top of Hannes's patch I fixed the reply to REQUEST SENSE commands
with DESC=0 and a small (<18) length.
Signed-off-by: Hannes Reinecke <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
| a1f0cce2ac0243572ff72aa561da67fe3766a395 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a1f0cce2ac0243572ff72aa561da67fe3766a395 | 2011-05-26 12:14:16+02:00 |
scsi: reference-count requests
With the next patch, a device may hold SCSIRequest for an indefinite
time. Split a rather big patch, and protect against access errors,
by reference counting them.
There is some ugliness in scsi_send_command implementation due to
the need to unref the request when it fails. This will go away
with the next patches, which move the unref'ing to the devices.
Signed-off-by: Paolo Bonzini <[email protected]>
Cc: Christoph Hellwig <[email protected]>
| ad2d30f79d3b0812f02c741be2189796b788d6d7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ad2d30f79d3b0812f02c741be2189796b788d6d7 | 2011-05-26 12:14:15+02:00 |
hw/virtio-9p-local.c: Remove unnecessary null char in symlink file
This patch removes the addition of null char in symlink file
which is being appended to file in case of mapped security model.
Without this patch, the extra null char causes LTP testcase lstat03
to fail and hence this fix is required.
Signed-off-by: Venkateswararao Jujjuri <[email protected]>
| f35bde2f8fb55541d4d7ddca50d64ce5a6ef384c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f35bde2f8fb55541d4d7ddca50d64ce5a6ef384c | 2011-04-27 08:27:01-07:00 |
target-arm: Handle UNDEF cases for Neon "2 regs and shift" insns
Correctly handle all the UNDEF cases for Neon instructions of the
"2 registers and shift" form, and make sure that we check for these
cases early enough not to leak TCG temporaries.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
| cc13115bdecb4596fd4201f16455220a7d1a85f8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/cc13115bdecb4596fd4201f16455220a7d1a85f8 | 2011-04-12 21:51:51+02:00 |
ide: Remove unneeded null pointer check
With bm == NULL, other code in the same function would crash.
This bug was reported by cppcheck:
hw/ide/pci.c:280: error: Possible null pointer dereference: bm
Cc: Michael S. Tsirkin <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 1635eecc413ed680013cf77e6994901cafe15590 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/1635eecc413ed680013cf77e6994901cafe15590 | 2011-01-24 16:41:49+01:00 |
kvm: x86: Prevent sign extension of DR7 in guest debugging mode
This unbreaks guest debugging when the 4th hardware breakpoint used for
guest debugging is a watchpoint of 4 or 8 byte lenght. The 31st bit of
DR7 is set in that case and used to cause a sign extension to the high
word which was breaking the guest state (vm entry failure).
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Avi Kivity <[email protected]>
| 95c077c91900c1420cd4f0be996ffeea6fb6cec8 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/95c077c91900c1420cd4f0be996ffeea6fb6cec8 | 2011-01-21 14:05:22-02:00 |
Add "broadcast" option for mce command
When the following test case is injected with mce command, maybe user could not
get the expected result.
DATA
command cpu bank status mcg_status addr misc
(qemu) mce 1 1 0xbd00000000000000 0x05 0x1234 0x8c
Expected Result
panic type: "Fatal Machine check"
That is because each mce command can only inject the given cpu and could not
inject mce interrupt to other cpus. So user will get the following result:
panic type: "Fatal machine check on current CPU"
"broadcast" option is used for injecting dummy data into other cpus. Injecting
mce with this option the expected result could be gotten.
Usage:
Broadcast[on]
command broadcast cpu bank status mcg_status addr misc
(qemu) mce -b 1 1 0xbd00000000000000 0x05 0x1234 0x8c
Broadcast[off]
command cpu bank status mcg_status addr misc
(qemu) mce 1 1 0xbd00000000000000 0x05 0x1234 0x8c
Signed-off-by: Jin Dongming <[email protected]>
Signed-off-by: Marcelo Tosatti <[email protected]>
| 31ce5e0c49821d92fb30cce2f3055ef33613b287 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/31ce5e0c49821d92fb30cce2f3055ef33613b287 | 2011-01-21 14:05:22-02:00 |
qemu-img: Fail creation if backing format is invalid
The qemu-img create command should check the backing format to ensure
only image files with valid backing formats are created. By checking in
qemu-img.c we can print a useful error message.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 5eeaad5a57b94d26747ed8a96fab69494baef75d | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5eeaad5a57b94d26747ed8a96fab69494baef75d | 2010-12-14 15:44:21+01:00 |
e1000: Fix TCP checksum overflow with TSO
When adding the length to the pseudo header, we're not properly
accounting for overflow.
From: Mark Wu <[email protected]>
Signed-off-by: Alex Williamson <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
| 1f892feb37dabedbb2492c6b499b0c1b22631a1f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/1f892feb37dabedbb2492c6b499b0c1b22631a1f | 2010-11-16 08:40:08-06:00 |
vmware_vga: Add checks to deal with non-atomic fifo writes.
Janne Huttunen noticed that the FIFO end pointer is updated by the
guest after writing each word to the FIFO, at least the X.org driver
which is open does this. This means that there's no way for the
host to know if the guest is in the middle a write operation. Qemu
thus needs to read the beginning of the command up to when it's able
to tell how many words are expected for the given command. It will
abort reading and rewind the FIFO if there aren't enough words yet,
this should be relatively rare but it is suspected to have been the
cause of the occasional FIFO overrun that killed the display.
| 4dedc07ffbbc66002e0fd2b97d5516fe6aca5eea | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4dedc07ffbbc66002e0fd2b97d5516fe6aca5eea | 2010-09-10 02:23:31+02:00 |
qed: Consistency check support
This patch adds support for the qemu-img check command. It also
introduces a dirty bit in the qed header to mark modified images as
needing a check. This bit is cleared when the image file is closed
cleanly.
If an image file is opened and it has the dirty bit set, a consistency
check will run and try to fix corrupted table offsets. These
corruptions may occur if there is power loss while an allocating write
is performed. Once the image is fixed it opens as normal again.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 01979a98d75b49c2acbbbb71521c285f8d8f9fb7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/01979a98d75b49c2acbbbb71521c285f8d8f9fb7 | 2010-12-17 16:11:04+01:00 |
virtio-9p: Add SM_NONE security model
This is equivalent to SM_PASSTHROUGH security model.
The only exception is, failure of privilige operation like chown
are ignored. This makes a passthrough like security model usable
for people who runs kvm as non root
Signed-off-by: Aneesh Kumar K.V <[email protected]>
| 12848bfc5d719bad536c5448205a3226be1fda47 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/12848bfc5d719bad536c5448205a3226be1fda47 | 2010-09-08 22:56:42+05:30 |
scsi-disk: add some optional scsi commands
I use a legacy OS which depends on some optional SCSI commands.
In fact this implementation does nothing special, but provides minimum
support for the following commands:
REZERO UNIT
WRITE AND VERIFY(10)
WRITE AND VERIFY(12)
WRITE AND VERIFY(16)
MODE SELECT(6)
MODE SELECT(10)
SEEK(6)
SEEK(10)
Signed-off-by: Bernhard Kohl <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| ebef0bbb1a8b5420a50e887972cc6bf0d150f9b7 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ebef0bbb1a8b5420a50e887972cc6bf0d150f9b7 | 2010-09-08 12:39:18+02:00 |
savevm: Survive hot-unplug of snapshot device
savevm.c keeps a pointer to the snapshot block device. If you manage
to get that device deleted, the pointer dangles, and the next snapshot
operation will crash & burn. Unplugging a guest device that uses it
does the trick:
$ MALLOC_PERTURB_=234 qemu-system-x86_64 [...]
QEMU 0.12.50 monitor - type 'help' for more information
(qemu) info snapshots
No available block device supports snapshots
(qemu) drive_add auto if=none,file=tmp.qcow2
OK
(qemu) device_add usb-storage,id=foo,drive=none1
(qemu) info snapshots
Snapshot devices: none1
Snapshot list (from none1):
ID TAG VM SIZE DATE VM CLOCK
(qemu) device_del foo
(qemu) info snapshots
Snapshot devices:
Segmentation fault (core dumped)
Move management of that pointer to block.c, and zap it when the device
it points becomes unusable.
Signed-off-by: Markus Armbruster <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| f9092b108f7b35e463e58bd3dd348ff002ba9e63 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f9092b108f7b35e463e58bd3dd348ff002ba9e63 | 2010-07-02 13:18:02+02:00 |
net: delete QemuOpts when net_client_init() fails.
This fixes the following scenario using QMP.
First, put a bogus argument "foo" to "type", which results in an error.
{"execute": "netdev_add", "arguments": { "type": "foo", "id": "netdev1" } }
Then, call it again with correct argument "user".
{"execute": "netdev_add", "arguments": { "type": "user", "id": "netdev1" } }
This results in "DuplicatedId" error.
Because the first command was invalid, it should be able to reuse the
same "id", and the second command should work.
Reported-by: Luiz Capitulino <[email protected]>
Signed-off-by: Yoshiaki Tamura <[email protected]>
Signed-off-by: Luiz Capitulino <[email protected]>
| 410cbafebc7168a278a23c856b4f5ff276ef1c85 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/410cbafebc7168a278a23c856b4f5ff276ef1c85 | 2010-07-01 14:27:13-03:00 |
qbus: fix memory leak in qbus_free()
BusState::name is allocated in qbus_create_inplace().
So it should be freed by qbus_free().
Signed-off-by: Isaku Yamahata <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| e163ae7b8f80dc4eb38445956929409601a8321c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e163ae7b8f80dc4eb38445956929409601a8321c | 2010-06-10 16:50:11+00:00 |
loadvm: improve tests before bdrv_snapshot_goto()
This patch improves the resilience of the load_vmstate() function, doing
further and better ordered tests.
In load_vmstate(), if there is any error on bdrv_snapshot_goto(), except if the
error is on VM state device, load_vmstate() will return zero and the VM will be
started with major corruption chances.
The current process:
- test if there is any writable device without snapshot support
- if exists return -error
- get the device that saves the VM state, possible return -error but unlikely
because it was tested earlier
- flush I/O
- run bdrv_snapshot_goto() on devices
- if fails, give an warning and goes to the next (not good!)
- if fails on the VM state device, return zero (not good!)
- check if the requested snapshot exists on the device that saves the VM state
and the state is not zero
- if fails return -error
- open the file with the VM state
- if fails return -error
- load the VM state
- if fails return -error
- return zero
New behavior:
- get the device that saves the VM state
- if fails return -error
- check if the requested snapshot exists on the device that saves the VM state
and the state is not zero
- if fails return -error
- test if there is any writable device without snapshot support
- if exists return -error
- test if the devices with snapshot support have the requested snapshot
- if anyone fails, return -error
- flush I/O
- run snapshot_goto() on devices
- if anyone fails, return -error
- open the file with the VM state
- if fails return -error
- load the VM state
- if fails return -error
- return zero
do_loadvm must not call vm_start if any error has occurred in load_vmstate.
Signed-off-by: Miguel Di Ciurcio Filho <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| f0aa7a8b2d518c54430e4382309281b93e51981a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f0aa7a8b2d518c54430e4382309281b93e51981a | 2010-08-03 15:57:22+02:00 |
qcow2: Fix qemu-img check segfault on corrupted images
With corrupted images, we can easily get an cluster index that exceeds the
array size of the temporary refcount table.
Signed-off-by: Kevin Wolf <[email protected]>
| 6882c8fa78dcc4882640d3e11232d995fda7d5c4 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/6882c8fa78dcc4882640d3e11232d995fda7d5c4 | 2010-06-22 14:38:02+02:00 |
Fix overflow in i440fx_init()
The ram_size parameter can be larger than an int, so it may be truncated.
Fix by using the correct type.
Signed-off-by: Avi Kivity <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
| 97679527bf2f002225d08cfb93f840cef449ac0e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/97679527bf2f002225d08cfb93f840cef449ac0e | 2010-05-28 21:33:59+02:00 |
Cleanup: bdrv_open() no need to shift total_size just to shift back.
In bdrv_open() there is no need to shift total_size >> 9 just to
multiply it by 512 again just a few lines later, since this is the
only place the variable is used.
Mask with BDRV_SECTOR_MASK to protect against case where we are
passed a corrupted image.
Signed-off-by: Jes Sorensen <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
| 3e82990b52d5afeb4957dd9b87be83d752e369b9 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/3e82990b52d5afeb4957dd9b87be83d752e369b9 | 2010-06-04 11:43:39+02:00 |
sparc64: fix TT_WOTHER value
- fix off by one error in spill trap number bit for other window (must be bit 5)
- fixes invalid instruction issue with HelenOS
Signed-off-by: Igor V. Kovalenko <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
| 88c8e03f5ddca8c8448dbb99d9de07d87b03ddd6 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/88c8e03f5ddca8c8448dbb99d9de07d87b03ddd6 | 2010-05-16 07:54:48+00:00 |
sparc64: fix build with older gccs
Fix errors missed in 2065061ede22d401aae2ce995c3af54db9d28639:
CC sparc64-softmmu/helper.o
cc1: warnings being treated as errors
/src/qemu/target-sparc/helper.c: In function 'get_physical_address':
/src/qemu/target-sparc/helper.c:426: warning: 'context' may be used uninitialized in this function
/src/qemu/target-sparc/helper.c:426: note: 'context' was declared here
Signed-off-by: Blue Swirl <[email protected]>
| 4450521668471c7685551d8c5bcc582d754e9843 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4450521668471c7685551d8c5bcc582d754e9843 | 2010-05-07 16:14:59+00:00 |
KVM: Rework VCPU state writeback API
This grand cleanup drops all reset and vmsave/load related
synchronization points in favor of four(!) generic hooks:
- cpu_synchronize_all_states in qemu_savevm_state_complete
(initial sync from kernel before vmsave)
- cpu_synchronize_all_post_init in qemu_loadvm_state
(writeback after vmload)
- cpu_synchronize_all_post_init in main after machine init
- cpu_synchronize_all_post_reset in qemu_system_reset
(writeback after system reset)
These writeback points + the existing one of VCPU exec after
cpu_synchronize_state map on three levels of writeback:
- KVM_PUT_RUNTIME_STATE (during runtime, other VCPUs continue to run)
- KVM_PUT_RESET_STATE (on synchronous system reset, all VCPUs stopped)
- KVM_PUT_FULL_STATE (on init or vmload, all VCPUs stopped as well)
This level is passed to the arch-specific VCPU state writing function
that will decide which concrete substates need to be written. That way,
no writer of load, save or reset functions that interact with in-kernel
KVM states will ever have to worry about synchronization again. That
also means that a lot of reasons for races, segfaults and deadlocks are
eliminated.
cpu_synchronize_state remains untouched, just as Anthony suggested. We
continue to need it before reading or writing of VCPU states that are
also tracked by in-kernel KVM subsystems.
Consequently, this patch removes many cpu_synchronize_state calls that
are now redundant, just like remaining explicit register syncs.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Marcelo Tosatti <[email protected]>
| ea375f9ab8c76686dca0af8cb4f87a4eb569cad3 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/ea375f9ab8c76686dca0af8cb4f87a4eb569cad3 | 2010-03-04 00:29:28-03:00 |
virtio-serial: Handle scatter-gather buffers for control messages
Current control messages are small enough to not be split into multiple
buffers but we could run into such a situation in the future or a
malicious guest could cause such a situation.
So handle the entire iov request for control messages.
Also ensure the size of the control request is >= what we expect
otherwise we risk accessing memory that we don't own.
Signed-off-by: Amit Shah <[email protected]>
CC: Avi Kivity <[email protected]>
Reported-by: Avi Kivity <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| e61da14d60ba1cceacad8396adcb9662c7f690af | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/e61da14d60ba1cceacad8396adcb9662c7f690af | 2010-04-28 08:58:22-05:00 |
Make cpu_get_real_ticks use mfspr
PowerPC CPUs have had two ways to read the time base for quite some time now.
They provide it using the mfspr instruction or - if a special bit is set in
that opcode - using mftb. For timekeeping we're currently using mftb.
While trying to get Qemu up and running on an e500v2 system, I stumbled over
the CPU not supporting mftbu. It just throws an illegal instruction trap.
So let's read the SPR values instead. All PPC CPUs should support them anyways.
I tested this patch on an e500v2 system where it makes qemu work and on my 970MP
system with 32-bit user space where everything still works with this patch
applied.
Signed-off-by: Alexander Graf <[email protected]>
Signed-off-by: malc <[email protected]>
| 4a9590f32e5692114aaae4ca10da89dac633e164 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4a9590f32e5692114aaae4ca10da89dac633e164 | 2010-04-03 14:26:45+04:00 |
qemu/msix: fix table access issues
Fixes a couple of issues with msix table access:
- With misbehaving guests, misaligned 4 byte access could overflow
msix table and cause qemu to segfault. Since PCI spec requires
host to only issue dword-aligned accesses, as a fix,
it's enough to mask the address low bits.
- Tables use pci format, not native format, and so
we must use pci_[sg]et_long on read/write.
Reported-by: Juan Quintela <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 76f5159d7fc4cdea9574dfbb54307735b280bc66 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/76f5159d7fc4cdea9574dfbb54307735b280bc66 | 2009-10-30 08:39:34-05:00 |
pci-hotplug: initialize dinfo to NULL in pci_device_hot_add
Suppress the following compiler warning emitted by at least gcc version 4.2.1 (SUSE Linux)
and gcc version 3.4.5 (mingw32 special):
hw/pci-hotplug.c: In function 'pci_device_hot_add':
hw/pci-hotplug.c:102: warning: 'dinfo' may be used uninitialized in this function
hw/pci-hotplug.c:102: note: 'dinfo' was declared here
Signed-off-by: Sebastian Herbszt <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 06c79f4ebdddbb55a27e06818eedc614e0e02815 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/06c79f4ebdddbb55a27e06818eedc614e0e02815 | 2009-08-27 19:33:15-05:00 |
vga: do not resize the screen on hw_invalidate
Hi all,
currently vga always resizes the screen when vga_hw_invalidate is called
while this is not required and all the other graphic emulators don't.
This patch fixes it, making vga invalidate behaviour consistent with the
other emulated devices.
Signed-off-by: Stefano Stabellini <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
Message-Id:
| 0bd8246bfec1dfb2eb959f52db535572c0260f4c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/0bd8246bfec1dfb2eb959f52db535572c0260f4c | 2009-08-10 13:05:31-05:00 |
gdbstub: x86: Support for setting segment registers
This allows to set segment registers via gdb also in system emulation
mode. Basic sanity checks are applied and nothing is changed if they
fail. But screwing up the target via this interface will never be
complicated, so I avoided being too paranoid here.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 84273177f25886b3476138470280890001debcbc | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/84273177f25886b3476138470280890001debcbc | 2009-07-16 08:28:13-05:00 |
Fix output of uninitialized strings
Commit ffad4116b96e29e0fbe892806f97c0a6c903d30d removed the "scratch buffer"
from check_params, but didn't care for the error messages which actually
included this string to tell the user which option was wrong. Now this string
is uninitialized, so this patch removes it from the message.
This means that the user is only told the whole parameter string and has to
pick the wrong option by himself as the callers of check_params can't know this
value any more. An alternative approach would be to revert that commit and do
whatever is needed to fix the original problem without changing check_params.
Signed-off-by: Kevin Wolf <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
| 8cf07dcbe7691dbe4f47563058659dba6ef66b05 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/8cf07dcbe7691dbe4f47563058659dba6ef66b05 | 2009-05-27 09:44:51-05:00 |
kvm: Add sanity checks to slot management (Jan Kiszka)
Fail loudly if we run out of memory slot.
Make sure that dirty log start/stop works with consistent memory regions
by reporting invalid parameters. This reveals several inconsistencies in
the vga code, patch to fix them follows later in this series.
And, for simplicity reasons, also catch and report unaligned memory
regions passed to kvm_set_phys_mem (KVM works on page basis).
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@7138 c046a42c-6fe2-441c-8c8c-71466251a162
| d3f8d37fe2d0c24ec8bac9c94d5b0e2dc09c0d2a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/d3f8d37fe2d0c24ec8bac9c94d5b0e2dc09c0d2a | 2009-04-17 14:26:29+00:00 |
chroot and change user support (Nolan)
Resent with fixed formatting.
This patch adds two new command line options:
-chroot <dir>
-runas <user>
This is useful for running qemu as an unprivileged user in a chroot
jail. To avoid having to populate the jail, chrooting happens right
before the start of guest execution.
Signed-off-by: Nolan Leake <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6652 c046a42c-6fe2-441c-8c8c-71466251a162
| 0858532ea93e0890bf13556f4ef3dc25d7636233 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/0858532ea93e0890bf13556f4ef3dc25d7636233 | 2009-02-27 22:09:45+00:00 |
Fix cpuid KVM crash on i386 (Lubomir Rintel)
Cpuid should return into vec, not overwrite past address in count.
Changeset 6565 broke this.
Signed-off-by: Lubomir Rintel <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6689 c046a42c-6fe2-441c-8c8c-71466251a162
| b36d24b6c3708413f1174e34bd86b4bf5116012f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/b36d24b6c3708413f1174e34bd86b4bf5116012f | 2009-03-05 19:01:28+00:00 |
char-mux: Use separate input buffers (Jan Kiszka)
Currently, the intermediate input buffer of mux'ed character devices
records data across all sub-devices. This has the side effect that we
easily leak data recorded over one sub-devices to another once we switch
the focus. Avoid data loss and confusion by defining exclusive buffers.
Note: In contrast to the original author's claim, the buffering concept
still breaks down when the fifo of the currently active sub-device is
full. As we cannot accept futher data from this point on without risking
to loose it, we will also miss escape sequences, just like without all
that buffering. In short: There is no reliable escape sequence handling
without infinite buffers or the risk of loosing some data.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6701 c046a42c-6fe2-441c-8c8c-71466251a162
| a80bf99fa3dd829ecea88b9bfb4f7cf146208f07 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a80bf99fa3dd829ecea88b9bfb4f7cf146208f07 | 2009-03-05 23:00:02+00:00 |
hpet config mask fix
I discovered a bug in the hpet code that caused Windows to boot without
hpet. The config mask I was using was preventing the guest from placing
the hpet into 32 bit mode.
(Beth Kon)
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6357 c046a42c-6fe2-441c-8c8c-71466251a162
| 35730fa05511cfbf19341aedf8bfd526dfc7d90f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/35730fa05511cfbf19341aedf8bfd526dfc7d90f | 2009-01-16 21:38:58+00:00 |
Handle SDL grabs failing (Mark McLoughlin)
If a X window is not viewable, XGrabPointer() fails and
returns GrabNotViewable. SDL's X backend currently handles
this by retrying the grab until the window becomes viewable
again.
This means e.g. if you Ctrl-Alt-RightArrow to switch
workspaces, QEMU tries to grab, SDL blocks because the
window isn't viewable and your guest stops executing until
you switch back to that workspace again.
See this Fedora bug for the gory details:
https://bugzilla.redhat.com/480065
Some SDL backends will return SDL_GRAB_OFF from
SDL_WM_GrabInput(), so the fix is to make the X backend do
this if the grab fails.
The only side-effect in QEMU is that if SDL_WM_GrabInput()
fails we still change the window title to indicate that it's
grabbed, when in fact it's not. This patch fixes that minor
issue.
Signed-off-by: Mark McLoughlin <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6325 c046a42c-6fe2-441c-8c8c-71466251a162
| 6bb816031f8bc0aafc3476e6dfa4293ee3a5f106 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/6bb816031f8bc0aafc3476e6dfa4293ee3a5f106 | 2009-01-15 20:47:45+00:00 |
Fix race in POSIX AIO emulation (Jan Kiszka)
When we cancel an AIO request that is already being processed by
aio_thread, qemu_paio_cancel should return QEMU_PAIO_NOTCANCELED as long
as aio_thread isn't done with this request. But as the latter currently
updates aiocb->ret after every block of the request, we may report
QEMU_PAIO_ALLDONE too early.
Futhermore, in case some zero-length request should have been queued,
aiocb->ret is never set to != -EINPROGRESS and callers like
raw_aio_cancel could get stuck in an endless loop.
Fix those issues by updating aiocb->ret _after_ the request has been
fully processed. This also simplifies the locking.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6278 c046a42c-6fe2-441c-8c8c-71466251a162
| f094a78220187996e33ba5adce29789326cf6c3c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f094a78220187996e33ba5adce29789326cf6c3c | 2009-01-13 15:13:53+00:00 |
target-i386: fix CVE-2007-1322
The icebp instruction can be abused to terminate the emulation,
resulting in denial of service.
Signed-off-by: Aurelien Jarno <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5921 c046a42c-6fe2-441c-8c8c-71466251a162
| 0b97134b2911d0e5d6789de70a3c70fab4dbde6e | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/0b97134b2911d0e5d6789de70a3c70fab4dbde6e | 2008-12-07 18:15:36+00:00 |
CRIS: Plug more temp leaks.
Signed-off-by: Edgar E. Iglesias <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5560 c046a42c-6fe2-441c-8c8c-71466251a162
| 44696296d5c2ffccef9d43d37d4f525bba7d9f5c | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/44696296d5c2ffccef9d43d37d4f525bba7d9f5c | 2008-10-28 00:13:15+00:00 |
x86: Issue reset on triple faults (Jan Kiszka)
As discussed a few times on this list: A triple fault causes a system
reset on x86, and some guests make use of this (e.g. 386BSD). To keep
the chance of tracing unexpected resets, log them if CPU_LOG_RESET is
set.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6453 c046a42c-6fe2-441c-8c8c-71466251a162
| f55761a0c46583f4faf1d7595f4f41b35b15508b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/f55761a0c46583f4faf1d7595f4f41b35b15508b | 2009-01-26 19:54:36+00:00 |
Fix IO performance regression in sparc
Replace signalfd with signal handler/pipe. There is no way to interrupt
the CPU execution loop when a file descriptor becomes readable. This
results in a large performance regression in sparc emulation during
bootup.
This patch switches us to signal handler/pipe which was originally
suggested by Ian Jackson. The signal handler lets us interrupt the
CPU emulation loop while the write to a pipe lets us avoid the
select/signal race condition.
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5451 c046a42c-6fe2-441c-8c8c-71466251a162
| 9e472e101f37233f4e32d181d2fee29014c1cf2f | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/9e472e101f37233f4e32d181d2fee29014c1cf2f | 2008-10-08 19:50:24+00:00 |
only check RCTL_EN in e1000_can_receive()
e1000_receive() has code to raise a receive overflow interrupt when the receive
buffer head and tail match. However, with the present implementation of
e1000_can_receive(), this code is unreachable -- and etherboot breaks as a
result.
Signed-off-by: Charles Duffy <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4987 c046a42c-6fe2-441c-8c8c-71466251a162
| 4105de6732f771ea64113851a2ee7172c34d3a7a | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/4105de6732f771ea64113851a2ee7172c34d3a7a | 2008-08-06 14:11:44+00:00 |
Fix block-vmdk.c:vmdk_close() use-after-free, by Ed Maste.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4526 c046a42c-6fe2-441c-8c8c-71466251a162
| 5cbdd273fbf5e977d14b1f06976489d8e4625a68 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/5cbdd273fbf5e977d14b1f06976489d8e4625a68 | 2008-05-22 13:51:48+00:00 |
Fix memory corruption reported by Julian Seward
(still more bugs to fix in PreP emulation).
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3390 c046a42c-6fe2-441c-8c8c-71466251a162
| a01d8cadadf4c0dad8fc5157ee56aea8ec323982 | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a01d8cadadf4c0dad8fc5157ee56aea8ec323982 | 2007-10-14 08:52:44+00:00 |
Fix reproductible crash: call cpu_loop_exit from micro-op, not from helper.c
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3311 c046a42c-6fe2-441c-8c8c-71466251a162
| a97fed52e57385fc749e6f6ef95be7ebdb81ba9b | qemu | devign | 1 | https://github.com/qemu/qemu | https://github.com/qemu/qemu/commit/a97fed52e57385fc749e6f6ef95be7ebdb81ba9b | 2007-10-01 21:49:57+00:00 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.